* doc/misc/cl.texi, doc/misc/dired-x.texi: Nuke hand-written node pointers.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
33017faf 12012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2
3 * callproc.c (Fcall_process): Restore a line that was accidentally
4 commented out in the 2011-02-13 change (bug#11547).
5
33017faf 62012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
7
8 * lisp.h [REL_ALLOC]: Add prototypes for external functions
9 defined on ralloc.c.
10
11 * buffer.c [REL_ALLOC]: Remove prototypes of
12 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
13 they are now on lisp.h.
14
15 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
16
17 * search.c (search_buffer): Use it to inhibit relocation of buffer
18 text while re_search_2 is doing its job, because re_search_2 is
19 passed C pointers to buffer text. (Bug#11519)
20
23415acf
EZ
21 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
22 Update value to 24.
23
44e27368
EZ
24 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
25 state after an additional call to move_it_in_display_line_to, keep
26 the values of it->max_ascent and it->max_descent found for the
27 entire line.
28 (pos_visible_p): Revert the comparison against bottom_y to what it
29 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
30 (Bug#11464)
31
c1892f11
PE
322012-05-26 Paul Eggert <eggert@cs.ucla.edu>
33
34 Fix coding-related core dumps with gcc -ftrapv.
35 The code was computing A - B, where A and B are pointers, and B is
36 random garbage. This can lead to core dumps on platforms that
37 have special pointer registers, and it also leads to core dumps on
38 x86-64 when compiled with gcc -ftrapv. The fix is to compute
39 A - B only when B is initialized properly.
40 * coding.c (coding_set_source, coding_set_destination): Return void.
41 (coding_change_source, coding_change_destinations): New functions,
42 with the old behaviors of coding_set_source and coding_set_destination.
43 All callers that need an offset changed to use these new functions.
44
eb7afdad
GM
452012-05-26 Glenn Morris <rgm@gnu.org>
46
47 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
48
f12fdf02
EZ
492012-05-26 Eli Zaretskii <eliz@gnu.org>
50
53a63be6 51 Extend mouse support on W32 text-mode console.
eb3f6f01
EZ
52 * xdisp.c (draw_row_with_mouse_face): Call
53 tty_draw_row_with_mouse_face for WINDOWSNT as well.
54
eb3f6f01
EZ
55 * w32console.c: Include window.h.
56 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face): New
57 functions.
58 (initialize_w32_display): Initialize mouse-highlight data.
59
53a63be6
EZ
60 * w32inevt.c: Include termchar.h and window.h.
61 (do_mouse_event): Support mouse-autoselect-window. When the mouse
62 moves, call note_mouse_highlight. If help_echo changed, call
63 gen_help_event to produce help-echo message in the echo area.
64 Call clear_mouse_face if mouse_face_hidden is set in the mouse
65 highlight info.
66
4cfd81f6
PE
672012-05-26 Paul Eggert <eggert@cs.ucla.edu>
68
69 * lread.c (read1): Simplify slightly to avoid an overflow warning
70 with GCC 4.7.0 on x86-64.
71
4446092a
EZ
722012-05-26 Eli Zaretskii <eliz@gnu.org>
73
74 * bidi.c (bidi_mirror_char): Revert last change: an int is
75 definitely wide enough here.
76
42b2a986 772012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 78
42b2a986 79 Fix integer width and related bugs (Bug#9874).
eb106a49 80 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
81 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
82 (string_bytes, check_sblock, allocate_string_data):
83 (compact_small_strings, Fmake_bool_vector, make_string)
84 (make_unibyte_string, make_multibyte_string)
85 (make_string_from_bytes, make_specified_string)
86 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
87 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
88 (mark_vectorlike):
89 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
90 (allocate_pseudovector):
91 Use int, not EMACS_INT, where int is wide enough.
92 (inhibit_garbage_collection, Fgarbage_collect):
93 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
94 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
95 int might not be wide enough.
96 (bidi_cache_search, bidi_cache_find, bidi_init_it)
97 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
98 (bidi_at_paragraph_end, bidi_find_paragraph_start)
99 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
100 (bidi_level_of_next_char, bidi_move_to_visually_next):
101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
102 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
103 (Fkill_buffer, Fset_buffer_major_mode)
104 (advance_to_char_boundary, Fbuffer_swap_text)
105 (Fset_buffer_multibyte, overlays_at, overlays_in)
106 (overlay_touches_p, struct sortvec, record_overlay_string)
107 (overlay_strings, recenter_overlay_lists)
108 (adjust_overlays_for_insert, adjust_overlays_for_delete)
109 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
110 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
111 (Foverlay_recenter, last_overlay_modification_hooks_used)
112 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
114 (validate_region): Omit unnecessary test for b <= e,
115 since that's guaranteed by the previous test.
d311d28c
PE
116 (adjust_overlays_for_delete): Avoid pos + length overflow.
117 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
118 (report_overlay_modification):
119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
120 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
121 Omit pointer cast, which isn't needed anyway, and doesn't work
122 after the EMACS_INT -> ptrdiff_t change.
02481186 123 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
124 * buffer.h: Adjust decls to match defn changes elsewhere.
125 (struct buffer_text, struct buffer):
126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
127 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
128 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
129 not int, to avoid needless 32-bit limit on 64-bit hosts.
130 (exec_byte_code): Use tighter memory-full test, one that checks
131 for alloca overflow. Don't compute the address of the object just
132 before an array, as that's not portable. Use EMACS_INT, not
133 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
134 * callint.c (Fcall_interactively):
135 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
136 * callproc.c (call_process_kill, Fcall_process):
137 Don't assume pid_t fits into an Emacs fixnum.
138 (call_process_cleanup, Fcall_process, child_setup):
139 Don't assume pid_t fits into int.
140 (call_process_cleanup, Fcall_process, delete_temp_file)
141 (Fcall_process_region):
142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
143 (Fcall_process): Simplify handling of volatile integers.
144 Use int, not EMACS_INT, where int will do.
145 * casefiddle.c (casify_object, casify_region, operate_on_word)
146 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
148 (casify_object): Avoid integer overflow when overallocating buffer.
149 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 150 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
151 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
152 * category.h (CATEGORYP): Don't assume arg is nonnegative.
153 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
154 integers are now checked earlier. All uses replaced with XINT.
155 (ccl_driver):
156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
157 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
158 (ccl_driver, Fregister_code_conversion_map):
159 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
160 (resolve_symbol_ccl_program): Check that vector header is in range.
161 Always copy the vector, so that we can check its contents reliably
162 now rather than having to recheck each instruction as it's being
163 executed. Check that vector words fit in 'int'.
164 (ccl_get_compiled_code, Fregister_ccl_program)
165 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
166 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
167 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
168 contents are in range.
169 (Fccl_execute_on_string): Check that status is in range.
170 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
171 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
172 Accept and return EMACS_INT, not int, because callers can pass values
173 out of 'int' range.
174 (c_string_width, strwidth, lisp_string_width, chars_in_text)
175 (multibyte_chars_in_text, parse_str_as_multibyte)
176 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
177 (str_as_unibyte, str_to_unibyte, string_count_byte8)
178 (string_escape_byte8, Fget_byte):
179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 180 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
181 avoid mishandling large integers.
182 * character.h: Adjust decls to match defn changes elsewhere.
183 * charset.c (load_charset_map_from_file, find_charsets_in_text)
184 (Ffind_charset_region):
185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
186 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
187 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 188 Don't assume fixnum fits in int.
d311d28c
PE
189 (load_charset_map_from_vector, Fmap_charset_chars):
190 Remove now-unnecessary CHECK_NATNUMs.
191 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
192 Don't rely on undefined behavior with signed left shift overflow.
193 Don't assume unsigned int fits into fixnum, or that fixnum fits
194 into unsigned int. Don't require max_code to be a valid fixnum;
195 that's not true for gb10830 4-byte on a 32-bit host. Allow
196 invalid_code to be a cons, for the same reason. Require code_offset
197 to be a character. Avoid int overflow if max_char is close
198 to INT_MAX.
199 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
200 this is intended anyway and avoids some undefined behavior.
201 (load_charset_map): Pass unsigned, not int, as 2nd arg of
202 INDEX_TO_CODE_POINT, as that's what it expects.
203 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
204 * charset.h (DECODE_CHAR): Return int, not unsigned;
205 this is what was intended anyway, and it avoids undefined behavior.
206 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
207 integer-overflow issues.
208 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
209 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
210 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
211 * chartab.c (Fmake_char_table, Fset_char_table_range)
212 (uniprop_get_decoder, uniprop_get_encoder):
213 Don't assume fixnum fits in int.
214 * cmds.c (move_point): New function, that does the gist of
215 Fforward_char and Fbackward_char, but does so while checking
216 for integer overflow more accurately.
c96e5d6a 217 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
218 (Fforward_line, Fend_of_line, internal_self_insert)
219 (internal_self_insert):
220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
221 Fix a FIXME, by checking for integer overflow when calculating
222 target_clm and actual_clm.
223 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 224 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
225 (ASSURE_DESTINATION, coding_alloc_by_realloc)
226 (coding_alloc_by_making_gap, alloc_destination)
227 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
228 (encode_coding_utf_16, detect_coding_emacs_mule)
229 (decode_coding_emacs_mule, encode_coding_emacs_mule)
230 (detect_coding_iso_2022, decode_coding_iso_2022)
231 (encode_invocation_designation, encode_designation_at_bol)
232 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
233 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
234 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
235 (encode_coding_ccl, encode_coding_raw_text)
236 (detect_coding_charset, decode_coding_charset)
237 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
238 (produce_composition, produce_charset, produce_annotation)
239 (decode_coding, handle_composition_annotation)
240 (handle_charset_annotation, consume_chars, decode_coding_gap)
241 (decode_coding_object, encode_coding_object, detect_coding_system)
242 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
243 (code_convert_region, code_convert_string)
8f50130c
PE
244 (Fdefine_coding_system_internal)
245 (coding_set_source, coding_set_destination):
d311d28c
PE
246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
247 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
248 (Fdefine_coding_system_internal):
249 Don't assume fixnums fit in int.
250 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 251 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
252 (Funencodable_char_position, Fcheck_coding_systems_region)
253 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 254 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 255 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 256 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 257 Don't access memory outside of the args array.
d311d28c 258 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
259 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
260 result of ENCODE_CHAR.
d311d28c
PE
261 * coding.h: Adjust decls to match defn changes elsewhere.
262 (struct coding_system):
263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
264 * composite.c (get_composition_id, find_composition)
265 (run_composition_function, update_compositions)
266 (compose_text, composition_gstring_put_cache)
267 (composition_gstring_p, composition_gstring_width)
268 (fill_gstring_header, fill_gstring_body, autocmp_chars)
269 (composition_compute_stop_pos, composition_reseat_it)
270 (composition_update_it, struct position_record)
271 (find_automatic_composition, composition_adjust_point)
272 (Fcomposition_get_gstring, Ffind_composition_internal):
273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
274 (update_compositions):
275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
276 * composite.h: Adjust decls to match defn changes elsewhere.
277 (struct composition):
278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
279 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
280 Do not attempt to compute the address of the object just before a
281 buffer; this is not portable.
282 (Faref, Faset):
283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
284 (Faset): Use int, not EMACS_INT, where int is wide enough.
285 (Fstring_to_number): Don't assume fixnums fit in int.
286 (Frem): Don't assume arg is nonnegative.
287 * dbusbind.c (xd_append_arg): Check for integers out of range.
288 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 289 (extract_signed, extract_unsigned): New functions.
243e0530
PE
290 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
291 (xd_get_connection_references): Return ptrdiff_t, not int.
292 All uses changed.
293 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
294 (xd_read_message_1):
295 Use int, not unsigned, where the dbus API uses int.
296 (Fdbus_message_internal): Don't overflow mtype.
297 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
298 * dired.c (directory_files_internal, file_name_completion, scmp)
299 (file_name_completion_stat):
300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
301 (file_name_completion): Don't overflow matchcount.
302 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
303 * dispextern.h: Adjust decls to match defn changes elsewhere.
304 (struct text_pos, struct glyph, struct bidi_saved_info)
305 (struct bidi_string_data, struct bidi_it, struct composition_it)
306 (struct it):
307 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
308 (struct display_pos, struct composition_it, struct it):
309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
310 * dispnew.c (increment_matrix_positions)
311 (increment_row_positions, mode_line_string)
312 (marginal_area_string):
313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 314 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
316 (duration_to_sec_usec): New function, to check for overflow better.
317 (Fsleep_for, sit_for): Use it.
318 * doc.c (get_doc_string, store_function_docstring):
319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
320 (get_doc_string, Fsnarf_documentation):
321 Use int, not EMACS_INT, where int is wide enough.
322 (get_doc_string):
323 Use SAFE_ALLOCA, not alloca.
324 Check for overflow when converting EMACS_INT to off_t.
325 * doprnt.c (doprnt):
326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
327 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
328 Don't assume uid_t fits into fixnum.
329 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
330 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
331 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
332 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
333 (general_insert_function)
334 (Finsert_char, make_buffer_string, make_buffer_string_both)
335 (update_buffer_properties, Fbuffer_substring)
336 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
337 (Fsubst_char_in_region, check_translation)
338 (Ftranslate_region_internal, save_restriction_restore, Fformat)
339 (transpose_markers, Ftranspose_regions):
340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
341 (clip_to_bounds): Move to lisp.h as an inline function).
342 (Fconstrain_to_field): Don't assume integers are nonnegative.
343 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
344 (Fsubst_char_in_region, Fsave_restriction):
345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
346 (Femacs_pid): Don't assume pid_t fits into fixnum.
347 (lo_time): Use int, not EMACS_INT, when int suffices.
348 (lisp_time_argument): Check for usec out of range.
349 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
350 (Fuser_login_name, Fuser_full_name): Signal an error
351 if a uid argument is out of range, rather than relying on
352 undefined behavior.
c8d5c857
PE
353 (Fformat_time_string): Remove now-unnecessary check.
354 lisp_time_argument checks for out-of-range usec now.
243e0530 355 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
356 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
357 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
358 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
359 (init_cmdargs, Fdump_emacs):
360 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
361 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
362 the bottom (typically) 32 bits of the fixnum.
363 * eval.c (specpdl_size, call_debugger):
364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
365 (when_entered_debugger, Fbacktrace_debug):
366 Don't assume fixnum can fit in int.
367 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
368 the object just before a buffer; this is not portable.
369 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
370 (grow_specpdl, unbind_to):
371 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
372 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
373 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 374 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
375 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
376 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
378 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
379 (a_write, e_write):
380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
381 (Fcopy_file, non_regular_nbytes, read_non_regular)
382 (Finsert_file_contents):
383 Use int, not EMACS_INT, where int is wide enough.
384 (READ_BUF_SIZE): Verify that it fits in int.
385 (Finsert_file_contents): Check that counts are in proper range,
386 rather than assuming fixnums fit into ptrdiff_t etc.
387 Don't assume fixnums fit into int.
125b3835 388 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
389 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
390 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
391 (string_char_to_byte, string_byte_to_char)
392 (string_make_multibyte, string_to_multibyte)
393 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
394 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
395 (substring_both, Fdelete, internal_equal, Ffillarray)
396 (Fclear_string, mapcar1)
397 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
398 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
399 (larger_vector, make_hash_table, maybe_resize_hash_table)
400 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
401 (Fmaphash, secure_hash):
402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
403 (concat): Check for string index and length overflow.
404 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
405 (Frequire):
406 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
407 (larger_vector): New API (vec, incr_min, size_max) replaces old
408 one (vec, new_size, init). This catches size overflow.
409 INIT was removed because it was always Qnil.
410 All callers changed.
411 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
412 the upper bound on a hash table index size.
413 (make_hash_table, maybe_resize_hash_table): Use it.
414 (secure_hash): Computer start_byte and end_byte only after
415 they're known to be in ptrdiff_t range.
416 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
417 (Ffont_get_glyphs, Ffont_at):
418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
419 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
420 (Flist_fonts, Fopen_font):
421 Don't assume fixnum can fit in int.
422 (check_gstring): Don't assume index can fit in int.
423 (font_match_p): Check that fixnum is a character, not a nonnegative
424 fixnum, since the later code needs to stuff it into an int.
425 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
426 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
427 conversion overflow issues.
428 (Fopen_font): Check for integer out of range.
429 (Ffont_get_glyphs): Don't assume index can fit in int.
430 * font.h: Adjust decls to match defn changes elsewhere.
431 * fontset.c (reorder_font_vector): Redo score calculation to avoid
432 integer overflow.
433 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
434 printmax_t, where ptrdiff_t is wide enough.
435 (Finternal_char_font):
436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
437 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
438 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
439 (Fset_frame_position, x_set_frame_parameters)
440 (x_set_line_spacing, x_set_border_width)
441 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
442 Check that fixnums are in proper range for system types.
443 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
445 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
446 Use SAFE_ALLOCA_LISP, not alloca.
447 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
448 intptr_t is wide enough.
449 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
450 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
451 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
452 Check for fixnum out of range.
453 * ftfont.c (ftfont_list): Don't assume index fits in int.
454 Check that fixnums are in proper range for system types.
455 (ftfont_shape_by_flt):
456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
457 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
459 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
460 Check that fixnums are in proper range for system types.
461 * gnutls.h: Adjust decls to match defn changes elsewhere.
462 * gtkutil.c (xg_dialog_run):
463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
464 (update_frame_tool_bar):
465 Check that fixnums are in proper range for system types.
466 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 467 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
468 * indent.c (last_known_column, last_known_column_point):
469 (current_column_bol_cache):
470 (skip_invisible, current_column, check_display_width):
471 (check_display_width, scan_for_column, current_column_1)
472 (Findent_to, Fcurrent_indentation, position_indentation)
473 (indented_beyond_p, Fmove_to_column, compute_motion):
474 (Fcompute_motion, Fvertical_motion):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (last_known_column_modified): Use EMACS_INT, not int.
477 (check_display_width):
478 (Fcompute_motion):
479 Check that fixnums and floats are in proper range for system types.
480 (compute_motion): Don't assume index or fixnum fits in int.
481 (compute_motion, Fcompute_motion):
482 Use int, not EMACS_INT, when it is wide enough.
483 (vmotion): Omit local var start_hpos that is always 0; that way
484 we don't need to worry about overflow in expressions involving it.
485 * indent.h: Adjust decls to match defn changes elsewhere.
486 (struct position):
487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
488 Use int, not EMACS_INT, where int is wide enough.
489 Remove unused members ovstring_chars_done and tab_offset;
490 all uses removed.
491 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
492 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
493 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
494 (make_gap, copy_text, insert, insert_and_inherit)
495 (insert_before_markers, insert_before_markers_and_inherit)
496 (insert_1, count_combining_before, count_combining_after)
497 (insert_1_both, insert_from_string)
498 (insert_from_string_before_markers, insert_from_string_1)
499 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
500 (adjust_after_replace, adjust_after_insert, replace_range)
501 (replace_range_2, del_range, del_range_1, del_range_byte)
502 (del_range_both, del_range_2, modify_region)
503 (prepare_to_modify_buffer, signal_before_change)
504 (signal_after_change, Fcombine_after_change_execute):
505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
506 * intervals.c (traverse_intervals, rotate_right, rotate_left)
507 (balance_an_interval, split_interval_right, split_interval_left)
508 (find_interval, next_interval, update_interval)
509 (adjust_intervals_for_insertion, delete_node, delete_interval)
510 (interval_deletion_adjustment, adjust_intervals_for_deletion)
511 (static_offset_intervals, offset_intervals)
512 (merge_interval_right, merge_interval_left, make_new_interval)
513 (graft_intervals_into_buffer, temp_set_point_both)
514 (temp_set_point, set_point, adjust_for_invis_intang)
515 (set_point_both, move_if_not_intangible, get_property_and_range)
516 (get_local_map, copy_intervals, copy_intervals_to_string)
517 (compare_string_intervals, set_intervals_multibyte_1):
518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
519 * intervals.h: Adjust decls to match defn changes elsewhere.
520 (struct interval):
521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
522 * keyboard.c (this_command_key_count, this_single_command_key_start)
523 (before_command_key_count, before_command_echo_length, echo_now)
524 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
525 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
526 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
527 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
529 (last_non_minibuf_size, last_point_position, echo_truncate)
530 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
531 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
532 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
533 (stuff_buffered_input):
534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
535 (last_auto_save, command_loop_1, read_char):
536 Use EMACS_INT, not int, to avoid integer overflow.
537 (record_char): Avoid overflow in total_keys computation.
538 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
539 * keyboard.h: Adjust decls to match defn changes elsewhere.
540 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
541 (Fkey_description, Fdescribe_vector, Flookup_key):
542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
543 (click_position): New function, to check that positions are in range.
544 (Fcurrent_active_maps):
545 (describe_command):
546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
547 (Faccessible_keymaps, Fkey_description):
548 (preferred_sequence_p):
549 Don't assume fixnum can fit into int.
550 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
551 Check for integer overflow in size calculations.
552 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
553 avoid mishandling large integers.
554 * lisp.h: Adjust decls to match defn changes elsewhere.
555 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
556 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
557 (struct Lisp_Marker):
558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
559 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
560 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
561 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
562 All callers changed.
563 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
564 Assume the arg has valid form, since it always does.
565 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
566 unsigned integer system type.
567 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
568 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
570 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
571 (duration_to_sec_usec): New decl.
572 * lread.c (read_from_string_index, read_from_string_index_byte)
573 (read_from_string_limit, readchar, unreadchar, openp)
574 (read_internal_start, read1, oblookup):
575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
576 (Fload, readevalloop, Feval_buffer, Feval_region):
577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
578 (openp): Check for out-of-range argument to 'access'.
579 (read1): Use int, not EMACS_INT, where int is wide enough.
580 Don't assume fixnum fits into int.
6efdadfd 581 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
582 (read_filtered_event): Use duration_to_sec_usec
583 to do proper overflow checking on durations.
d311d28c
PE
584 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
585 in size calculation.
586 (Fexecute_kbd_macro):
587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
588 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
589 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
590 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
591 (set_marker_both, set_marker_restricted_both, marker_position)
592 (marker_byte_position, Fbuffer_has_markers_at):
593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
594 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
595 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
596 It now merely ensures that the menu is large enough, without
597 necessarily growing it, as this avoids some integer overflow issues.
598 All callers changed.
599 (keymap_panes, parse_single_submenu, Fx_popup_menu):
600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
601 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
602 Use SAFE_ALLOCA_LISP, not alloca.
603 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
604 to EMACS_INT. Check that fixnums are in proper range for system types.
605 * minibuf.c (minibuf_prompt_width, string_to_object)
606 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
607 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
609 (get_minibuffer, read_minibuf_unwind):
610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
611 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
612 this simplifies overflow checking. All callers changed.
613 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
614 (Ftest_completion):
615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
616 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
617 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
618 Check that fixnums are in proper range for system types.
619 (Fx_create_frame, Fx_show_tip):
620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
621 * nsfont.m (ns_findfonts, nsfont_list_family):
622 Don't assume fixnum fits in long.
623 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
624 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
625 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
626 wide enough.
17fdb222 627 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
629 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
630 (PRINTDECLARE, PRINTPREPARE):
631 (strout, print_string):
632 (print, print_preprocess, print_check_string_charset_prop)
633 (print_object):
634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
635 (PRINTDECLARE):
636 (temp_output_buffer_setup, Fprin1_to_string, print_object):
637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
638 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 639 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 640 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
641 (print_error_message): Use SAFE_ALLOCA, not alloca.
642 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
643 (print_depth, new_backquote_output, print_number_index):
644 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
645 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
646 (Fset_process_window_size, Fformat_network_address)
647 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 648 (sigchld_handler):
d311d28c 649 Check that fixnums are in proper range for system types.
d44287d4 650 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
651 Check for process-ids out of pid_t range rather than relying on
652 undefined behavior.
e4d81efc 653 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
654 (Fformat_network_address, read_process_output, send_process)
655 (Fprocess_send_region, status_notify):
656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
657 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
658 (wait_reading_process_output, read_process_output, exec_sentinel):
659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
660 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
661 (Faccept_process_output): Use duration_to_sec_usec to do proper
662 overflow checking on durations.
dde14581
PE
663 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
664 Don't assume pid_t fits in int.
02481186
PE
665 * process.h (struct Lisp_Process): Members tick and update_tick
666 are now of type EMACS_INT, not int.
b62b53e8
PE
667 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
668 configured --with-wide-int.
d311d28c
PE
669 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
670 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
671 * search.c (looking_at_1, string_match_1):
672 (fast_string_match, fast_c_string_match_ignore_case)
673 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
674 (scan_newline, find_before_next_newline, search_command)
675 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
676 (set_search_regs, wordify):
677 (Freplace_match):
678 (Fmatch_data):
679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
680 (string_match_1, search_buffer, set_search_regs):
681 (Fmatch_data):
682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
683 (wordify): Check for overflow in size calculation.
684 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
685 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
686 Check that fixnums are in proper range for system types.
687 * sound.c (struct sound_device)
688 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
690 (Fplay_sound_internal):
691 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 692 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
693 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
694 (Fparse_partial_sexp):
695 Don't assume fixnums can fit in int.
696 (struct lisp_parse_state, find_start_pos, find_start_value)
697 (find_start_value_byte, find_start_begv)
698 (update_syntax_table, char_quoted, dec_bytepos)
699 (find_defun_start, prev_char_comend_first, back_comment):
700 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
701 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
703 (Finternal_describe_syntax_value): Check that match_lisp is a
704 character, not an integer, since the code stuffs it into int.
705 (scan_words, scan_sexps_forward):
706 Check that fixnums are in proper range for system types.
707 (Fforward_word):
708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
709 (scan_sexps_forward):
710 Use CHARACTERP, not INTEGERP, since the value must fit into int.
711 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
712 * syntax.h: Adjust decls to match defn changes elsewhere.
713 (struct gl_state_s):
714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
715 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
716 MOST_POSITIVE_FIXNUM.
d311d28c
PE
717 * sysdep.c (wait_for_termination_1, wait_for_termination)
718 (interruptible_wait_for_termination, mkdir):
719 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
720 (emacs_read, emacs_write):
721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
722 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
723 and double all fit in int.
d311d28c
PE
724 * term.c (set_tty_color_mode):
725 Check that fixnums are in proper range for system types.
726 * termhooks.h (struct input_event):
727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
728 * textprop.c (validate_interval_range, interval_of)
729 (Fadd_text_properties, set_text_properties_1)
730 (Fremove_text_properties, Fremove_list_of_text_properties)
731 (Ftext_property_any, Ftext_property_not_all)
732 (copy_text_properties, text_property_list, extend_property_ranges)
733 (verify_interval_modification):
734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
735 (Fnext_single_char_property_change)
736 (Fprevious_single_char_property_change):
737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
738 (copy_text_properties):
739 Check for integer overflow in index calculation.
d311d28c
PE
740 * undo.c (last_boundary_position, record_point, record_insert)
741 (record_delete, record_marker_adjustment, record_change)
742 (record_property_change):
743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
744 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
746 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
747 (Fx_hide_tip, Fx_file_dialog):
748 * w32menu.c (set_frame_menubar):
749 Use ptrdiff_t, not int, for consistency with rest of code.
750 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
751 (select_window, Fdelete_other_windows_internal)
752 (window_scroll_pixel_based, window_scroll_line_based)
753 (Frecenter, Fset_window_configuration):
754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
755 (Fset_window_hscroll, run_window_configuration_change_hook)
756 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 757 (Fscroll_other_window, Frecenter):
d311d28c
PE
758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
759 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
760 Don't assume fixnum fits in int.
761 (Fset_window_scroll_bars):
762 Check that fixnums are in proper range for system types.
763 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
764 (string_pos, c_string_pos, number_of_chars, init_iterator)
765 (in_ellipses_for_invisible_text_p, init_from_display_pos)
766 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
767 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
768 (face_before_or_after_it_pos, handle_invisible_prop)
769 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
770 (display_prop_intangible_p, string_buffer_position_lim)
771 (string_buffer_position, handle_composition_prop, load_overlay_strings)
772 (get_overlay_strings_1, get_overlay_strings)
773 (iterate_out_of_display_property, forward_to_next_line_start)
774 (back_to_previous_visible_line_start, reseat, reseat_to_string)
775 (get_next_display_element, set_iterator_to_next)
776 (get_visually_first_element, compute_stop_pos_backwards)
777 (handle_stop_backwards, next_element_from_buffer)
778 (move_it_in_display_line_to, move_it_in_display_line)
779 (move_it_to, move_it_vertically_backward, move_it_by_lines)
780 (add_to_log, message_dolog, message_log_check_duplicate)
781 (message2, message2_nolog, message3, message3_nolog
782 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
783 (current_message_1, truncate_echo_area, truncate_message_1)
784 (set_message, set_message_1, store_mode_line_noprop)
785 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
786 (text_outside_line_unchanged_p, check_point_in_composition)
787 (reconsider_clip_changes)
788 (redisplay_internal, set_cursor_from_row, try_scrolling)
789 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
790 (redisplay_window, find_last_unchanged_at_beg_row)
791 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
792 (trailing_whitespace_p, find_row_edges, display_line)
793 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
794 (display_mode_element, store_mode_line_string)
795 (pint2str, pint2hrstr, decode_mode_spec)
796 (display_count_lines, display_string, draw_glyphs)
797 (x_produce_glyphs, x_insert_glyphs)
798 (rows_from_pos_range, mouse_face_from_buffer_pos)
799 (fast_find_string_pos, mouse_face_from_string_pos)
800 (note_mode_line_or_margin_highlight, note_mouse_highlight):
801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
802 (safe_call, init_from_display_pos, handle_fontified_prop)
803 (handle_single_display_spec, load_overlay_strings)
804 (with_echo_area_buffer, setup_echo_area_for_printing)
805 (display_echo_area, echo_area_display)
806 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
807 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
808 (redisplay_window, dump_glyph_row, display_mode_line)
809 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 810 (handle_display_spec, display_prop_string_p):
d311d28c
PE
811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
812 (handle_single_display_spec, build_desired_tool_bar_string)
813 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
814 (get_specified_cursor_type):
815 Check that fixnums are in proper range for system types.
816 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
817 (Flookup_image_map):
818 Don't assume fixnums fit in int.
819 (compare_overlay_entries):
820 Avoid mishandling comparisons due to subtraction overflow.
821 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
822 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
823 (handle_tool_bar_click):
824 Use int, not unsigned, since we prefer signed and the signedness
825 doesn't matter here.
826 (get_next_display_element, next_element_from_display_vector):
827 Use int, not EMACS_INT, when int is wide enough.
828 (start_hourglass): Use duration_to_sec_usec to do proper
829 overflow checking on durations.
830 * xfaces.c (Fbitmap_spec_p):
831 Check that fixnums are in proper range for system types.
832 (compare_fonts_by_sort_order):
833 Avoid mishandling comparisons due to subtraction overflow.
834 (Fx_family_fonts, realize_basic_faces):
835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
836 (Fx_family_fonts):
837 Don't assume fixnum fits in int.
838 Use SAFE_ALLOCA_LISP, not alloca.
839 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
840 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
841 (face_at_buffer_position, face_for_overlay_string)
842 (face_at_string_position):
843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
844 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
845 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
846 (Fx_show_tip):
847 Check that fixnums are in proper range for system types.
848 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
849 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
851 (Fx_change_window_property): Don't assume fixnums fit in int.
852 * xfont.c (xfont_chars_supported):
853 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
854 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
855 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
857 * xml.c (parse_region):
858 * xrdb.c (magic_file_p):
859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
860 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
861 (x_get_local_selection, x_reply_selection_request)
862 (x_handle_selection_request, wait_for_property_change):
863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
864 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
865 short is wide enough.
866 (x_send_client_event): Don't assume fixnum fits in int.
867 * xterm.c (x_x_to_emacs_modifiers):
868 Don't assume EMACS_INT overflows nicely into int.
869 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
870 may come from Lisp.
871 (handle_one_xevent): NATNUMP can eval its arg twice.
872 (x_connection_closed):
873 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
874 * xterm.h: Adjust decls to match defn changes elsewhere.
875 (struct scroll_bar): Use struct vectorlike_header
876 rather than rolling our own approximation.
877 (SCROLL_BAR_VEC_SIZE): Remove; not used.
878
c6574eb5
GM
8792012-05-25 Glenn Morris <rgm@gnu.org>
880
881 * lisp.mk (lisp): Update for more files being compiled now.
882
e8d32c7e
SM
8832012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
884
48def666
SM
885 * lread.c: Remove `read_pure' which makes no difference.
886 (read_pure): Remove var.
887 (unreadpure): Remove function.
888 (readevalloop): Don't call read_list with -1 flag.
889 (read1, read_vector): Don't test read_pure any more.
890 (read_list): Simplify.
891
e8d32c7e
SM
892 * fileio.c, character.h: Minor style tweaks.
893
4b2addb7
DA
8942012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
895
896 * window.h (clip_changed): Remove useless declaration.
897
584461b2
JB
8982012-05-22 Juanma Barranquero <lekktu@gmail.com>
899
900 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
901 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
902
34374650
PE
9032012-05-22 Paul Eggert <eggert@cs.ucla.edu>
904
905 Remove src/m/*.
906 This directory predates autoconf and is no longer needed nowadays.
907 Move its few remaining bits of functionality to where they're needed.
908 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
909 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
910 * m/template.h: Remove.
911 * Makefile.in (M_FILE): Remove. All uses removed.
912 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
913 * lisp.h (USE_LSB_TAG):
914 * mem-limits.h (EXCEEDS_LISP_PTR):
915 Use VAL_MAX, not VALBITS, in #if.
916 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
917 (EMACS_UINT): Define unconditionally now.
918 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
919 (BITS_PER_EMACS_INT): New constants, replacing
920 what used to be in config.h, but not useful in #if.
921 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
922 define them any more.
923 (VAL_MAX): New macro.
924 (VALMASK): Use it.
925 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
926 BITS_PER_EMACS_INT, in #if.
927 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
928 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
929 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
930 * s/ms-w32.h (DATA_START):
931 Move here from removed file m/intel386.h.
932 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
933 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
934
261cb4bb
PE
9352012-05-21 Paul Eggert <eggert@cs.ucla.edu>
936
937 Assume C89 or later.
938 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
939 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
940 (xrealloc):
941 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
942 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
943 * textprop.c, tparam.c (NULL): Remove.
944 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
945 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
946 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
947 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
948 * xterm.c (input_signal_count): Assume volatile works.
949
ff23cd9f
KB
9502012-05-21 Ken Brown <kbrown@cornell.edu>
951
952 * xgselect.c (xg_select): Fix first argument in call to 'select'
953 (bug#11508).
954
1b170bc6
KB
9552012-05-20 Ken Brown <kbrown@cornell.edu>
956
957 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 958 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 959
b2f4d39f
KB
9602012-05-19 Ken Brown <kbrown@cornell.edu>
961
962 * xfns.c (x_in_use): Remove `static' qualifier.
963 * xterm.h (x_in_use): Declare.
964 * xgselect.c: Include xterm.h.
965 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
966 and `display_arg' (bug#9754).
967
003fdae2
PE
9682012-05-19 Paul Eggert <eggert@cs.ucla.edu>
969
9232a6d9
PE
970 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
971
003fdae2
PE
972 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
973 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
974
784b56e2
EZ
9752012-05-18 Eli Zaretskii <eliz@gnu.org>
976
977 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
978
979 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
980 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
981
982 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
983 reference to image_cache->refcount.
984 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
985
a0a79cde
JL
9862012-05-17 Juri Linkov <juri@jurta.org>
987
988 * search.c (Fword_search_regexp, Fword_search_backward)
989 (Fword_search_forward, Fword_search_backward_lax)
990 (Fword_search_forward_lax): Move functions to isearch.el
991 (bug#10145, bug#11381).
992
b0572523
PE
9932012-05-16 Paul Eggert <eggert@cs.ucla.edu>
994
995 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
996
9660f5fc
SM
9972012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
998
999 * lread.c (init_obarray): Declare Qt and Qnil as special.
1000
4374de83
GM
10012012-05-14 Glenn Morris <rgm@gnu.org>
1002
1003 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1004 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1005
dc44c39a
PE
10062012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1007
078c97cb
PE
1008 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1009
dc44c39a
PE
1010 * unexaix.c: Port to more-recent AIX compilers.
1011 (report_error, report_error_1, make_hdr, copy_sym)
1012 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1013 Make arguments const char *, not char *, to avoid violations of C
1014 standard and to fix some AIX warnings reported by Gilles Pion.
1015
e18afed7 10162012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1017
1018 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1019 already have overlays loaded.
1020 (handle_single_display_spec): Before returning without displaying
1021 fringe bitmap, synchronize the bidi iterator with the main display
1022 iterator, by calling iterate_out_of_display_property.
1023 (iterate_out_of_display_property): Detect buffer iteration by
1024 testing that it->string is a Lisp string.
1025 (get_next_display_element): When the current object is exhausted,
1026 and there's something on it->stack, call set_iterator_to_next to
1027 proceed with what's on the stack, instead of returning zero.
1028 (set_iterator_to_next): If called at the end of a Lisp string,
1029 proceed to consider_string_end without incrementing string
1030 position. Don't increment display vector index past the end of
1031 the display vector. (Bug#11417)
c8fb9dc6
EZ
1032 (pos_visible_p): Don't report a position visible when move_it_to
1033 stopped at the last line of window, which happens to be scanned
1034 backwards by the bidi iteration. (Bug#11464)
ac268e67 1035
e18afed7 10362012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1037
1038 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1039 and right-margin display specs even if the spec is invalid or we
1040 are on a TTY, and thus unable to display on the fringes. That's
1041 because the text with the property will not be displayed anyway,
1042 so we need to signal to the caller that this is a "replacing"
1043 display spec. This fixes display when the spec is invalid or we
1044 are on a TTY.
1045
e18afed7 10462012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1047
1048 * unexaix.c (make_hdr): Fix typo in prototype.
1049 This bug broke the build on AIX. Problem reported by Gilles Pion.
1050
9d0a235a
MA
10512012-05-14 Michael Albinus <michael.albinus@gmx.de>
1052
1053 * keyboard.c (kbd_buffer_get_event): Read special events also in
1054 batch mode. (Bug#11415)
1055
9e6b06ed
GM
10562012-05-12 Glenn Morris <rgm@gnu.org>
1057
1058 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1059
c1a1d7a3
EZ
10602012-05-12 Eli Zaretskii <eliz@gnu.org>
1061
1062 * lisp.mk (lisp): Add newcomment.elc.
1063
3fe7cdc8
GM
10642012-05-12 Glenn Morris <rgm@gnu.org>
1065
1066 * Makefile.in (MKDIR_P): New, set by configure.
1067 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1068
53f7d2c0
PE
10692012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1070
1071 Remove unused function hourglass_started.
1072 * dispextern.h (hourglass_started):
1073 * w32fns.c (hourglass_started):
1074 * xdisp.c (hourglass_started): Remove.
1075
75aafb17
JB
10762012-05-10 Juanma Barranquero <lekktu@gmail.com>
1077
1078 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1079 Update dependencies.
1080
12959e8e
PE
10812012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1082
97107e2e
PE
1083 * xgselect.c (xg_select): Put maxfds+1 into a var.
1084 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1085
12959e8e
PE
1086 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1087
836d29b3
DA
10882012-05-10 Dave Abrahams <dave@boostpro.com>
1089
1090 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1091 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1092
5cb67954
MA
10932012-05-09 Michael Albinus <michael.albinus@gmx.de>
1094
1095 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1096 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1097 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1098 Initialize xd_registered_buses.
1099
3478ec45
PE
11002012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1101
b263a6b0
PE
1102 Untag more efficiently if USE_LSB_TAG.
1103 This is based on a proposal by YAMAMOTO Mitsuharu in
1104 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1105 For an admittedly artificial (nth 8000 longlist) benchmark on
1106 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1107 Emacs's overall text size by 1%.
1108 * lisp.h (XUNTAG): New macro.
1109 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1110 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1111 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1112 * eval.c (Fautoload):
1113 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1114 * frame.h (XFRAME): Use XUNTAG.
1115
3478ec45
PE
1116 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1117 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1118 Remove unportable assumptions about print widths of types like
1119 dbus_uint32_t.
1120 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1121 intptr_t when converting between pointer and integer, to avoid GCC
1122 warnings about wrong width.
1123
666b903b 11242012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1125
1126 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1127 stack for each reader_thread, instead of defaulting to 8MB
1128 determined by the linker. This avoids failures in creating
1129 subprocesses on Windows 7, see the discussion in this thread:
1130 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1131
b120cc17
JC
11322012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1133
1134 Fix up display of the *Minibuf-0* buffer in the mini window.
1135 * keyboard.c (read_char): Don't clear the echo area if there's no
1136 message to clear.
1137 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1138 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1139
9a4b36f8
MA
11402012-05-07 Michael Albinus <michael.albinus@gmx.de>
1141
1142 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1143 batch mode.
1144
e5f9458f
CY
11452012-05-06 Chong Yidong <cyd@gnu.org>
1146
1147 * lisp.mk (lisp): Update.
1148
eceeb5fc 11492012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1150
1151 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1152
71873e2b
SM
11532012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1154
1155 * data.c (PUT_ERROR): New macro.
1156 (syms_of_data): Use it. Add new error type `user-error'.
1157 * undo.c (user_error): New function.
1158 (Fprimitive_undo): Use it.
1159 * print.c (print_error_message): Adjust print style for `user-error'.
1160 * keyboard.c (user_error): New function.
1161 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1162
ab0fa4e4
PE
11632012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1164
1165 Do not limit current-time-string to years 1000..9999.
1166 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1167 (Fcurrent_time_string): Support any year that is supported by the
1168 underlying localtime representation. Don't use asctime, as it
1169 has undefined behavior for years outside the range -999..9999.
1170
7ed806a7
PE
11712012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1172
1173 Fix race conditions involving setenv, gmtime, localtime, asctime.
1174 Without this fix, interrupts could mess up code that uses these
1175 nonreentrant functions, since setting TZ invalidates existing
1176 tm_zone or tzname values, and since most of these functions return
1177 pointers to static storage.
1178 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1179 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1180 Grow the critical sections to include not just invoking
1181 localtime/gmtime, but also accessing these functions' results
1182 including their tm_zone values if any, and any related TZ setting.
1183 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1184 so that the struct tm is saved in the critical section.
1185 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1186 motivated by the fact that memory allocation needs to be outside
1187 the critical section.
1188
0c16dfed
DA
11892012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1190
1191 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1192 with RESET_INTERVAL.
1193
1194 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1195 Remove duplicated buffer name initialization.
1196
3f83ace8
JM
11972012-05-02 Jim Meyering <jim@meyering.net>
1198
1199 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1200
c7b8541e
JM
1201 * xfns.c (x_window): Use xstrdup (Bug#11375).
1202
90207a15 12032012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1204
1205 * xdisp.c (pos_visible_p): If already at a newline from the
1206 display string before the 'while' loop, don't walk back the glyphs
1207 from it3.glyph_row. Solves assertion violation when the display
1208 string begins with a newline (egg.el). (Bug#11367)
1209
b593d6a9
AH
12102012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1211
1212 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1213 Move to simple.el.
1214
4737362e
GM
12152012-05-01 Glenn Morris <rgm@gnu.org>
1216
99cf43f9
GM
1217 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1218 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1219 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1220 All were removed before 23.1.
1221
9311dcff
GM
1222 * dispnew.c: Remove HAVE_LIBNCURSES test;
1223 it is always true on relevant platforms.
1224
4d5c6349
GM
1225 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1226 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1227
4737362e
GM
1228 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1229
74dd3a6b
AS
12302012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1231
1232 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1233 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1234 Remove.
1235
13c379ee
PE
12362012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1237
1238 Do not avoid creating empty evaporating overlays (Bug#9642).
1239 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1240 That is, do not delete an evaporating overlay if it becomes
1241 empty after its bounds are adjusted to fit within its buffer.
1242 This fix caused other problems, and I'm reverting it until we get
1243 to the bottom of them.
1244
a8e7d6d7 12452012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1246
1247 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1248
a8e7d6d7 12492012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1250
1251 * xdisp.c (pos_visible_p): If the window start position is beyond
1252 ZV, start the display from buffer beginning. Prevents assertion
1253 violation in init_iterator when the minibuffer window is scrolled
1254 via the scroll bar.
1255
1256 * window.c (window_scroll_pixel_based): Likewise.
1257
a8e7d6d7 12582012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1259
1260 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1261
a8e7d6d7 12622012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1263
1264 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1265 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1266
a8e7d6d7 12672012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1268
b593d6a9
AH
1269 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1270 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1271
1c6900d9
EZ
12722012-04-26 Eli Zaretskii <eliz@gnu.org>
1273
4c3fa1d9
EZ
1274 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1275 display element, check also the underlying string or buffer
1276 character. (Bug#11341)
1277
1c6900d9
EZ
1278 * w32menu.c: Include w32heap.h.
1279 (add_menu_item): If the call to AppendMenuW (via
1280 unicode_append_menu) fails, disable Unicode menus only if we are
1281 running on Windows 9X/Me.
1282
42bf8205
AS
12832012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1284
1285 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1286 (xgetint): Add missing shift for LSB tags.
1287
b1bac16e
MR
12882012-04-24 Martin Rudalics <rudalics@gmx.at>
1289
1290 * keyboard.c (read_char): Don't wipe echo area for select window
1291 events: These might get delayed via `mouse-autoselect-window'
1292 (Bug#11304).
1293
d69621cc
JB
12942012-04-24 Juanma Barranquero <lekktu@gmail.com>
1295
1296 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1297 manipulation of :loaded-from data.
1298
02fd101b
JB
12992012-04-23 Juanma Barranquero <lekktu@gmail.com>
1300
1301 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1302 now a cons (bug#11311).
1303
888bec30
PE
13042012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1305
89a438bd
PE
1306 Do not create empty overlays with the evaporate property (Bug#9642).
1307 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1308 if it becomes empty after its bounds are adjusted to fit within
1309 its buffer. Without this fix, in a nonempty buffer (let ((o
1310 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1311 yields an empty overlay that has the evaporate property, which is
1312 not supposed to happen.
1313
1068fe4d
PE
1314 Fix minor GTK3 problems found by static checking.
1315 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1316 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1317 (struct _EmacsFixedClass, emacs_fixed_get_type):
1318 Move decls here from emacsgtkfixed.h, since they needn't be public.
1319 (emacs_fixed_get_type): Now static.
1320 (emacs_fixed_class_init): Omit unused local.
1321 (emacs_fixed_child_type): Remove; unused.
1322 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1323 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1324 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1325 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1326 (EMACS_FIXED_GET_CLASS): Remove; unused.
1327 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1328
888bec30
PE
1329 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1330 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1331
de85e130
PE
13322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1333
d0baac98 1334 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1335 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1336 (__malloc_size_t, __malloc_ptrdiff_t):
1337 Remove. All uses removed, replaced by the definiens if needed,
1338 since we can assume C89 or better now.
1339 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1340 (protect_malloc_state, align, get_contiguous_space)
1341 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1342 (malloc_atfork_handler_child, malloc_enable_thread)
1343 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1344 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1345 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1346 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1347 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1348 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1349 Define using prototypes, not old style.
1350 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1351 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1352 (align): Don't assume that signed integer overflow wraps around.
1353 Omit unused local var.
1354 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1355 (_free_internal_nolock, memalign, mallochook, reallochook):
1356 Omit no-longer-needed casts.
1357 (valloc): Use getpagesize, not __getpagesize.
1358 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1359 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1360
de85e130
PE
1361 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1362
dcbf5805
MA
13632012-04-22 Michael Albinus <michael.albinus@gmx.de>
1364
1365 Move functions from C to Lisp. Make non-blocking method calls
1366 the default. Implement further D-Bus standard interfaces.
1367
1368 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1369 (QCdbus_request_name_allow_replacement)
1370 (QCdbus_request_name_replace_existing)
1371 (QCdbus_request_name_do_not_queue)
1372 (QCdbus_request_name_reply_primary_owner)
1373 (QCdbus_request_name_reply_in_queue)
1374 (QCdbus_request_name_reply_exists)
1375 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1376 (QCdbus_registered_serial, QCdbus_registered_method)
1377 (QCdbus_registered_signal): New Lisp objects.
1378 (XD_DEBUG_MESSAGE): Use sizeof.
1379 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1380 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1381 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1382 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1383 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1384 (xd_signature, xd_append_arg): Allow float for integer types.
1385 (xd_get_connection_references): New function.
b593d6a9
AH
1386 (xd_get_connection_address): Rename from xd_initialize.
1387 Return cached address.
dcbf5805
MA
1388 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1389 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1390 level.
1391 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1392 Return number of refcounts.
dcbf5805
MA
1393 (Fdbus_get_unique_name): Make stronger parameter check.
1394 (Fdbus_message_internal): New defun.
1395 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1396 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1397 (Fdbus_send_signal, Fdbus_register_service)
1398 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1399 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1400 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1401 (Vdbus_compiled_version, Vdbus_runtime_version)
1402 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1403 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1404 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1405 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1406 Adapt docstring.
dcbf5805 1407
52828e02
PE
14082012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1409
da05bc4c
PE
1410 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1411 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1412 Do not assume ptrdiff_t is the same width as 'int'.
1413
52828e02
PE
1414 * alloc.c: Handle unusual debugging option combinations.
1415 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1416 since the two debugging options are incompatible.
1417 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1418 is defined.
1419 (mem_init, mem_insert, mem_insert_fixup):
1420 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1421 (NEED_MEM_INSERT): Remove; no longer needed.
1422
f01769f9
LL
14232012-04-22 Leo Liu <sdl.web@gmail.com>
1424
1425 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1426
5790543d
PE
14272012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1428
1429 * sysdep.c [__FreeBSD__]: Minor cleanups.
1430 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1431 Use Emacs indenting style more consistently. Avoid some casts.
1432 Use 'double' consistently rather than mixing 'float' and 'double'.
1433
b91b7e4d
EW
14342012-04-21 Eduard Wiebe <usenet@pusto.de>
1435
b593d6a9
AH
1436 * sysdep.c (list_system_processes, system_process_attributes):
1437 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1438
6114eb15
AS
14392012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1440
1441 * lisp.mk (lisp): Update.
1442
2f38dff7
PE
14432012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1444
1445 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1446 It is never used otherwise.
1447
4ae29f89
SM
14482012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1449
1450 * print.c (print_preprocess): Only check print_depth if print-circle
1451 is nil.
1452 (print_object): Check for cycles even when print-circle is nil and
1453 print-gensym is t, but only check print_depth if print-circle is nil.
1454
f30d612a
CY
14552012-04-20 Chong Yidong <cyd@gnu.org>
1456
1457 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1458 set the status to "failed" and ensure that sentinel is run.
1459
c07a4c0b 14602012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1461
1462 * process.c (Fset_process_inherit_coding_system_flag)
1463 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1464 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1465
c07a4c0b 14662012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1467
1468 * xdisp.c (string_buffer_position_lim): Limit starting position to
1469 BEGV.
1470 (set_cursor_from_row): If called for a mode-line or header-line
1471 row, return zero immediately.
1472 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1473 farther than the first row after the header line, if any.
1474 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1475 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1476
c07a4c0b 14772012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1478
4ae29f89
SM
1479 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1480 (bug#11238).
ad3a2b41 1481
c07a4c0b 14822012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 14832012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1484
1485 configure: new option --enable-gcc-warnings (Bug#11207)
1486 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1487 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1488 (ALL_CFLAGS): Use new macros rather than old.
1489 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1490 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1491 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1492 -Wunused-result, -Wunused-variable. This should go away once
1493 the Emacs and Gnulib regex code is merged.
1494 (xmalloc, xrealloc): Now static.
1495
aba027e8
PE
14962012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 * dired.c (Fsystem_groups): Remove unused local.
1499
e5a36063
GM
15002012-04-17 Glenn Morris <rgm@gnu.org>
1501
1502 * dired.c (Fsystem_users): Doc fix.
1503
316411f0
DA
15042012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1505
1506 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1507 (syms_of_dired): Add them.
1508
9426aba4
PE
15092012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1510
b62a57be
PE
1511 Fix minor alloc.c problems found by static checking.
1512 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1513 New extern decls, to avoid calling undeclared functions.
1514 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1515 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1516 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1517 (NEED_MEM_INSERT): New macro.
1518 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1519 Remove one incorrect comment and fix another.
b62a57be 1520
3539f31f
PE
1521 Fix minor ralloc.c problems found by static checking.
1522 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1523 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1524 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1525 (r_alloc_sbrk): Now static.
1526
a041960a
PE
1527 Improve ralloc.c interface checking.
1528 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1529 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1530 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1531 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1532 [REL_ALLOC]: ... to here, to check interface.
1533 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1534 Remove decls. This fixes an "It stinks!".
1535
9426aba4
PE
1536 * alloc.c (which_symbols): Fix alignment issue / type clash.
1537
d55c12ed
AS
15382012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1539
1540 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1541 (struct Lisp_Misc_Any): Likewise.
1542 (struct Lisp_Free): Likewise.
1543 * alloc.c (union aligned_Lisp_Symbol): Define.
1544 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1545 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1546 (union aligned_Lisp_Misc): Define.
1547 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1548 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1549 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1550
b948ce8b
PE
15512012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1552
1553 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1554 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1555 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1556 * s/netbsd.h, s/sol2-6.h:
1557 Remove definition of GC_MARK_STACK, since the default now works.
1558 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1559 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1560 no longer the default.
1561 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1562
35dc09a1 15632012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1564
35dc09a1
GM
1565 * lread.c (lisp_file_lexically_bound_p):
1566 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1567
35dc09a1
GM
15682012-04-14 Eli Zaretskii <eliz@gnu.org>
1569
1570 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1571 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1572
15732012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1574
1575 * nsterm.m (constrainFrameRect): Always constrain when there is only
1576 one screen (Bug#10962).
1577
bcd86815
KB
15782012-04-13 Ken Brown <kbrown@cornell.edu>
1579
1580 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1581
c25df26e
RT
15822012-04-13 Reuben Thomas <rrt@sc3d.org>
1583
1584 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1585
0fc59f1e
DC
15862012-04-11 Daniel Colascione <dancol@dancol.org>
1587
1588 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1589 against is gone. It's better to use vfork now so that when Cygwin
1590 gains a new, working vfork, we use it automatically (bug#10398).
1591
de8c03dc
SM
15922012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1593
1594 * window.c (save_window_save): Obey window-point-insertion-type.
1595
2f097256
GM
15962012-04-11 Glenn Morris <rgm@gnu.org>
1597
1598 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1599
453b951e
SM
16002012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1601
1602 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1603
75f1671a 16042012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1605
1606 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1607 (force_quit_count): New var.
1608 (handle_interrupt): Use it.
1609
2a8ce227
JB
16102012-04-10 Juanma Barranquero <lekktu@gmail.com>
1611
1612 * w32.c (w32_delayed_load): Record the full path of the library
1613 being loaded (bug#10424).
1614
935396c0
GM
16152012-04-09 Glenn Morris <rgm@gnu.org>
1616
05920a43
GM
1617 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1618 not just in the obarray, before snarfing them. (Bug#11036)
1619
935396c0
GM
1620 * Makefile.in ($(leimdir)/leim-list.el):
1621 Pass EMACS rather than BUILT_EMACS.
1622
a18ecafa
TZ
16232012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1624
1625 * process.c (make_process):
1626 * process.h: Add integer `gnutls_handshakes_tried' member to
1627 process struct.
1628
6bbef4e5
JC
1629 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1630 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1631
1632 * gnutls.c (gnutls_log_function2i): Convenience log function.
1633 (emacs_gnutls_read): Use new log functions,
1634 `gnutls_handshakes_tried' process member, and
1635 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1636 attempts per process (connection).
1637
b4d3bc10
CY
16382012-04-09 Chong Yidong <cyd@gnu.org>
1639
1640 * eval.c (Fuser_variable_p, user_variable_p_eh)
1641 (lisp_indirect_variable): Functions deleted.
1642 (Fdefvar): Caller changed.
1643
1644 * callint.c (Finteractive, Fcall_interactively):
1645 * minibuf.c (Fread_variable): Callers changed.
1646
70f4d973
EZ
16472012-04-09 Eli Zaretskii <eliz@gnu.org>
1648
1649 * xdisp.c (set_cursor_from_row): If the display string appears in
1650 the buffer at position that is closer to point than the position
1651 after the display string, display the cursor on the first glyph of
1652 the display string. Fixes cursor display when a 'display' text
1653 property immediately follows invisible text. (Bug#11094)
1654
cb3c2e3e
PE
16552012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1656
1657 composite.c: use 'double' consistently
1658 * composite.c (get_composition_id): Use 'double' consistently
1659 instead of converting 'float' to 'double' and vice versa; this is
1660 easier to understand and avoids a GCC warning.
1661
fd06db5d
GM
16622012-04-09 Glenn Morris <rgm@gnu.org>
1663
50fe702a
GM
1664 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1665 preparation for dumping it with emacs. (Bug#4789)
1666 (leimdir): New variable.
1667 ($(leimdir)/leim-list.el): New rule.
1668 (emacs$(EXEEXT)): Depend on leim-list.el.
1669
fd06db5d
GM
1670 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1671 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1672 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1673
55c131ee
AS
16742012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1675
1676 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1677 proper alignment.
1678
9209588f
JB
16792012-04-07 Juanma Barranquero <lekktu@gmail.com>
1680
1681 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1682 Remove unused local variable.
1683
e3fb2efb
PE
16842012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1685
1686 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1687 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1688 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1689 objects, as mark_maybe_pointer will catch them otherwise.
1690 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1691 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1692
b5385551
PE
16932012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1694
1695 Fix typo that broke non-Windows builds.
1696 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1697
9078ead6
EZ
16982012-04-07 Eli Zaretskii <eliz@gnu.org>
1699
1700 Support building on MS-Windows with libxml2.
1701
1702 * makefile.w32-in (OBJ2): Add xml.$(O).
1703 (GLOBAL_SOURCES): Add xml.c.
1704 ($(BLD)/xml.$(O)): New dependency list.
1705
1706 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1707 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1708 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1709 [!WINDOWSNT]: New macros.
1710 (init_libxml2_functions, libxml2_loaded_p): New functions.
1711 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1712 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1713 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1714 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1715 linked in).
6bbef4e5
JC
1716 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1717 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
1718 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1719
1720 * emacs.c: Don't include libxml/parser.h.
1721 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1722 xmlCleanupParser directly.
1723
1724 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1725
3811fdf3
EZ
17262012-04-07 Eli Zaretskii <eliz@gnu.org>
1727
1728 * indent.c (Fvertical_motion): If there is a display string at
1729 point, use it.vpos to compute how many lines to backtrack after
1730 move_it_to point. (Bug#11133)
1731
2f8e16b2
EZ
17322012-04-06 Eli Zaretskii <eliz@gnu.org>
1733
1734 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1735 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1736 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1737 macros related to unification of CJK characters. For the details,
1738 see the discussion following the message here:
1739 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1740
3d439cd1
CY
17412012-04-04 Chong Yidong <cyd@gnu.org>
1742
1743 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1744
8bc53d00
EZ
17452012-04-01 Eli Zaretskii <eliz@gnu.org>
1746
1747 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1748 instead of alloca. (Bug#11138)
1749
3b0512a3
AS
17502012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1751
1752 * w32menu.c (is_simple_dialog): Properly check lisp types.
1753 (Bug#11141)
1754
8427ddd2
EZ
17552012-03-31 Eli Zaretskii <eliz@gnu.org>
1756
979022ef
EZ
1757 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1758 position we get to after a call to move_it_to fails the
1759 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1760 only if we wind up in a string from display property. (Bug#11063)
1761
a6b1c7cc
EZ
1762 * window.c (Fdelete_other_windows_internal): Invalidate the row
1763 and column information about mouse highlight, so that redisplay
1764 restores it after reallocating the glyph matrices. (Bug#7464)
1765
8427ddd2
EZ
1766 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1767 string comes from a `display' text property, use the buffer
1768 position of that property as if we actually saw that position in
1769 the row's glyphs.
697ba24b
EZ
1770 (move_it_by_lines): Remove the assertion that
1771 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1772 violated when there's a before-string at the beginning of a line.
1773 (Bug#11063)
8427ddd2 1774
65a0a738
EZ
17752012-03-30 Eli Zaretskii <eliz@gnu.org>
1776
1777 * xdisp.c (append_space_for_newline): If the default face was
1778 remapped, use the remapped face for the appended newline.
1779 (extend_face_to_end_of_line): Use the remapped default face for
1780 extending the face to the end of the line.
1781 (display_line): Call extend_face_to_end_of_line when the default
1782 face was remapped. (Bug#11068)
1783
581355cc
EZ
17842012-03-29 Eli Zaretskii <eliz@gnu.org>
1785
1786 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1787
e8fc049f
SM
17882012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1789
1790 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1791
4fb9a543
GM
17922012-03-27 Glenn Morris <rgm@gnu.org>
1793
1794 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1795 Doc fixes.
1796
679910f1
KH
17972012-03-26 Kenichi Handa <handa@m17n.org>
1798
1799 * dispextern.h (struct glyph): Fix previous change. Change the
1800 bit length of glyphless.ch to 25 (Bug#11082).
1801
90d49b7f
CY
18022012-03-26 Chong Yidong <cyd@gnu.org>
1803
1804 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1805 (command_loop_1): Use it; inhibit selection update for
1806 handle-select-window too (Bug#8996).
1807
f514f6f0
FP
18082012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1809
e8fc049f 1810 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 1811
bf43fa51
KH
18122012-03-25 Kenichi Handa <handa@m17n.org>
1813
1814 * dispextern.h (struct glyph): Change the bit length of
1815 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1816
8a0c01dd
EZ
18172012-03-24 Eli Zaretskii <eliz@gnu.org>
1818
1819 * s/ms-w32.h (tzname): Include time.h before redirecting to
1820 _tzname. Fixes the MSVC build. (Bug#9960)
1821
7d1c3a76
AS
18222012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1823
8ed79523
AS
1824 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1825 characters.
1826
7d1c3a76
AS
1827 * xterm.c (XTread_socket): Only modify handling_signal if
1828 !SYNC_INPUT. (Bug#11080)
1829
e99a9b8b
EZ
18302012-03-23 Eli Zaretskii <eliz@gnu.org>
1831
1832 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1833 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1834 when fetching a multibyte character consumes more bytes than
1835 CHAR_BYTES returns, due to unification of CJK characters in
1836 string_char. (Bug#11073)
1837
5063c0e1
TN
18382012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1839
1840 * process.c (wait_reading_process_output): Handle pty disconnect
1841 by refraining from sending oneself a SIGCHLD (bug#10933).
1842
9f851fbd
CY
18432012-03-22 Chong Yidong <cyd@gnu.org>
1844
1845 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1846
5063c0e1 1847 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
1848 Mark string as coming from a prefix property.
1849 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1850 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1851
fb5b8aca
CY
18522012-03-21 Chong Yidong <cyd@gnu.org>
1853
1854 * xfaces.c (Vface_remapping_alist): Doc fix.
1855
62356a1b
EZ
18562012-03-20 Eli Zaretskii <eliz@gnu.org>
1857
1858 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
1859 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1860 Doc fixes.
62356a1b 1861
025de85b
CY
18622012-03-20 Chong Yidong <cyd@gnu.org>
1863
1864 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1865 to reflect default non-nil value of redisplay-dont-pause.
1866
4827f94e
KH
18672012-03-19 Kenichi Handa <handa@m17n.org>
1868
1869 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1870 it fit in a valid range (Bug#11003).
1871
e50a24a2
EZ
18722012-03-18 Eli Zaretskii <eliz@gnu.org>
1873
1874 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1875 that is not from display property, accept the row as a "cursor
1876 row" if one of the string's character has a non-nil `cursor'
1877 property. Fixes cursor positioning when there are newlines in
1878 overlay strings, e.g. in icomplete.el. (Bug#11035)
1879
9af5ed87
PE
18802012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1881
1882 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1883
d1f55f16
CY
18842012-03-12 Chong Yidong <cyd@gnu.org>
1885
1886 * eval.c (inhibit_lisp_code): Rename from
1887 inhibit_window_configuration_change_hook; move from window.c.
1888
1889 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1890 * window.c (run_window_configuration_change_hook)
1891 (syms_of_window): Callers changed.
1892
66c5eebd
CY
18932012-03-11 Chong Yidong <cyd@gnu.org>
1894
413df973
CY
1895 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1896
66c5eebd
CY
1897 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1898
1de11f56
CY
18992012-03-10 Chong Yidong <cyd@gnu.org>
1900
1901 * frame.c (other_visible_frames): Don't assume the selected frame
1902 is visible (Bug#10955).
1903
cae07000
SM
19042012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1905
1906 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1907
89c94350
JD
19082012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1909
1910 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1911 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1912 zero (Bug#10954).
1913
999dd333
GM
19142012-03-03 Glenn Morris <rgm@gnu.org>
1915
01a6dcc8 1916 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 1917
de0100f2
EZ
19182012-03-02 Eli Zaretskii <eliz@gnu.org>
1919
1920 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1921 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
1922 (redisplay_window, next_element_from_string): Fix typos in
1923 comments.
3e441275
EZ
1924 (redisplay_window): Pass to move_it_vertically the margin in
1925 pixels, not in screen lines.
de0100f2 1926
96a72ee9
GM
19272012-03-02 Glenn Morris <rgm@gnu.org>
1928
1929 * buffer.c (buffer-list-update-hook): Doc fix.
1930
312508d7
EZ
19312012-02-29 Eli Zaretskii <eliz@gnu.org>
1932
1933 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1934 push_it before setting up the iterator for the first overlay
1935 string, even if we have an empty string loaded.
1936 (next_overlay_string): If there's an empty string on the iterator
1937 stack, pop the stack. (Bug#10903)
1938
27f3c637
PE
19392012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1940
1941 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1942 Suggested by Stefan Monnier in
1943 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1944 * alloc.c (widen_to_Lisp_Object): New static function.
1945 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1946 and widening them to Lisp_Objects. This would work even if
1947 USE_LSB_TAG is defined and wide integers are used, which might
1948 happen in a future version of Emacs.
1949
3c9dfce6
CY
19502012-02-25 Chong Yidong <cyd@gnu.org>
1951
fa74b241
CY
1952 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1953 Doc fix.
1954
3c9dfce6
CY
1955 * xselect.c (Fx_selection_exists_p): Doc fix.
1956 (x_clipboard_manager_save_all): Print an informative message
1957 before saving to clipboard manager.
1958
9486df08
CY
19592012-02-24 Chong Yidong <cyd@gnu.org>
1960
1961 * keyboard.c (process_special_events): Handle all X selection
1962 requests in kbd_buffer, not just the next one (Bug#8869).
1963
f01d3321
CY
19642012-02-23 Chong Yidong <cyd@gnu.org>
1965
1966 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1967 call when setting menu-bar-lines and tool-bar-lines parameters.
1968 (unwind_create_frame_1): New helper function.
1969
1970 * window.c (inhibit_window_configuration_change_hook): New var.
1971 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 1972 (syms_of_window): Initialize it.
f01d3321 1973
86b847b6
CY
19742012-02-22 Chong Yidong <cyd@gnu.org>
1975
1976 * xterm.c (x_draw_image_relief): Add missing type check for
1977 Vtool_bar_button_margin (Bug#10743).
1978
a59225b1
CY
19792012-02-21 Chong Yidong <cyd@gnu.org>
1980
1981 * fileio.c (Vfile_name_handler_alist): Doc fix.
1982
1983 * buffer.c (Fget_file_buffer): Protect against invalid file
1984 handler return value.
1985
310f5bd4
PE
19862012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1987
cb3a28cc
PE
1988 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1989 when computing $valmask.
1990
310f5bd4
PE
1991 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1992 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1993 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1994 It's useless in that case, and it can cause problems on hosts
1995 that allocate halves of EMACS_INT values separately.
1996 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1997 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1998 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1999 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2000 it avoids undefined behavior on hosts where shifting right by more
2001 than the word width has undefined behavior.
2002
2375c96a
CY
20032012-02-19 Chong Yidong <cyd@gnu.org>
2004
2005 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2006 (Funhandled_file_name_directory, Ffile_name_as_directory)
2007 (Fdirectory_file_name, Fexpand_file_name)
2008 (Fsubstitute_in_file_name): Protect against invalid file handler
2009 return values (Bug#10845).
2010
3eb49e71
EZ
20112012-02-18 Eli Zaretskii <eliz@gnu.org>
2012
2013 * .gdbinit (pitx): Fix incorrect references to fields of the
2014 iterator stack.
2015
7b926f3f
CY
20162012-02-17 Chong Yidong <cyd@gnu.org>
2017
2018 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2019
11273115
PE
20202012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2021
2022 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2023 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2024
c3a70e2b
CY
20252012-02-15 Chong Yidong <cyd@gnu.org>
2026
2027 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2028 marked as special. Also, starting docstrings with * is obsolete.
2029
0ca43699
AS
20302012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2031
2032 * gnutls.c (emacs_gnutls_write): Fix last change.
2033
2e8f3c56
LI
20342012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2035
2036 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2037 send_process.
2038
af70074f
SM
20392012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2040
2041 * keymap.c (Fsingle_key_description): Handle char ranges.
2042
95986d52
CY
20432012-02-12 Chong Yidong <cyd@gnu.org>
2044
afd83bd1
CY
2045 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2046 as that creates a dangerous corner case.
2047
95986d52
CY
2048 * window.c (Fdelete_window_internal): Invalidate the mouse
2049 highlight (Bug#9904).
2050
bd7da63e
GM
20512012-02-12 Glenn Morris <rgm@gnu.org>
2052
2053 * xselect.c (Fx_own_selection_internal)
2054 (Fx_get_selection_internal, Fx_disown_selection_internal)
2055 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2056 * nsselect.m (Fx_own_selection_internal)
2057 (Fx_disown_selection_internal, Fx_selection_exists_p)
2058 (Fx_selection_owner_p, Fx_get_selection_internal):
2059 Sync docs and argument specs with the xselect.c versions.
2060
77abcbc2
LI
20612012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2062
2063 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2064
90b671e2
EZ
20652012-02-11 Eli Zaretskii <eliz@gnu.org>
2066
1c0ca0b7
EZ
2067 * w32select.c (Fx_selection_exists_p): Sync doc string and
2068 argument list with xselect.c. (Bug#10783)
2069
2070 * w16select.c (Fx_selection_exists_p): Sync doc string and
2071 argument list with xselect.c. (Bug#10783)
90b671e2 2072
49241268
GM
20732012-02-10 Glenn Morris <rgm@gnu.org>
2074
2075 * fns.c (Fsecure_hash): Doc fix.
2076
f998bbe7 20772012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2078
2079 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2080
0992bd9c
CY
20812012-02-07 Chong Yidong <cyd@gnu.org>
2082
2083 * buffer.c (Fbuffer_local_variables)
2084 (buffer_lisp_local_variables): Handle unbound vars correctly;
2085 don't let Qunbound leak into Lisp.
2086
af008560
GM
20872012-02-07 Glenn Morris <rgm@gnu.org>
2088
dd605cc4
GM
2089 * image.c (Fimagemagick_types): Doc fix.
2090
af008560
GM
2091 * image.c (imagemagick-render-type): Change it from a lisp object
2092 to an integer. Move the doc here from the lisp manual.
2093 Treat all values not equal to 0 the same.
2094
1449fa1d
CY
20952012-02-06 Chong Yidong <cyd@gnu.org>
2096
2097 * doc.c (store_function_docstring): Avoid applying docstring of
2098 alias to base function (Bug#2603).
2099
3723ec07
AS
21002012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2101
2102 * .gdbinit (pp1, pv1): Remove redundant defines.
2103 (pr): Use pp.
2104
79c1cc1e
CY
21052012-02-04 Chong Yidong <cyd@gnu.org>
2106
2107 * nsterm.m: Declare a global (Bug#10694).
2108
d7f29f8e
EZ
21092012-02-04 Eli Zaretskii <eliz@gnu.org>
2110
cae07000
SM
2111 * w32.c (get_emacs_configuration_options):
2112 Include --enable-checking, if specified, in the return value.
d7f29f8e 2113
3b95a6f9
MR
21142012-02-04 Martin Rudalics <rudalics@gmx.at>
2115
2116 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2117 after rounding frame sizes. (Bug#9723)
2118
d6fa96a6
EZ
21192012-02-04 Eli Zaretskii <eliz@gnu.org>
2120
2121 * keyboard.c (adjust_point_for_property): Don't position point
2122 before BEGV. (Bug#10696)
2123
df0b2940
PE
21242012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2125
2126 Handle overflow when computing char display width (Bug#9496).
2127 * character.c (char_width): Return EMACS_INT, not int.
2128 (char_width, c_string_width): Check for overflow when
2129 computing the width; this is possible now that individual
2130 characters can have unbounded width. Problem introduced
2131 by merge from Emacs 23 on 2012-01-19.
2132
6bee44d6
MA
21332012-02-02 Michael Albinus <michael.albinus@gmx.de>
2134
2135 * dbusbind.c (Fdbus_register_method): Mention the return value
2136 :ignore in the docstring.
2137
44f92739
GM
21382012-02-02 Glenn Morris <rgm@gnu.org>
2139
1b9f60cc
GM
2140 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2141
44f92739
GM
2142 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2143 Unconditionally set to t. (Bug#10673)
2144 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2145 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2146 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2147
c5d3843c
KH
21482012-02-02 Kenichi Handa <handa@m17n.org>
2149
2150 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2151 0, do not call append_composite_glyph.
2152
159462d4 21532012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2154
2155 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2156 NULL (Bug#6988).
2157 (x_produce_glyphs): If the component of a composition is a null
2158 string, set it->pixel_width to 1 to avoid zero-width glyph.
2159
78cef877
EZ
21602012-02-01 Eli Zaretskii <eliz@gnu.org>
2161
2162 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2163 first 2 arguments are identical. This makes inserting large
2164 output from a subprocess an order of magnitude faster on
2165 MS-Windows, where all sbrk'ed memory is always contiguous.
2166
97897668
GM
21672012-01-31 Glenn Morris <rgm@gnu.org>
2168
2169 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2170 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2171 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2172
31fd3586
GM
21732012-01-29 Glenn Morris <rgm@gnu.org>
2174
2175 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2176
0e24a8b2
CY
21772012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2178
2179 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2180
cc0adcb0
CY
21812012-01-28 Chong Yidong <cyd@gnu.org>
2182
2183 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2184
acc28cb9
CY
21852012-01-26 Chong Yidong <cyd@gnu.org>
2186
9c69cfb7
CY
2187 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2188
acc28cb9
CY
2189 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2190 repeat counts (Bug#10507).
2191
48da7392
GM
21922012-01-26 Glenn Morris <rgm@gnu.org>
2193
2194 * lread.c (syms_of_lread): Doc fix.
2195
14af5f7f
CY
21962012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2197
2198 * coding.c (encode_designation_at_bol): Change return value to
2199 EMACS_INT.
2200
0b21c100
CY
22012012-01-25 Chong Yidong <cyd@gnu.org>
2202
2203 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2204
3c2907f7
CY
22052012-01-21 Chong Yidong <cyd@gnu.org>
2206
2207 * floatfns.c (Fcopysign): Make the second argument non-optional,
2208 since nil is not allowed anyway.
2209
959ad23f
AS
22102012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2211
2212 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2213 (send_process): Likewise.
2214
34a02f46
MR
22152012-01-19 Martin Rudalics <rudalics@gmx.at>
2216
2217 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2218 (Vwindow_persistent_parameters): Do not use Qstate.
2219 Rewrite doc-strings.
34a02f46 2220
1259009a 22212012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2222
2223 * character.c (char_width): New function.
70d4fdf6
GM
2224 (Fchar_width, c_string_width, lisp_string_width):
2225 Use char_width (Bug#9496).
25ed9e61 2226
6a6ee00d
MR
22272012-01-16 Martin Rudalics <rudalics@gmx.at>
2228
2229 * window.c (Vwindow_persistent_parameters): New variable.
2230 (Fset_window_configuration, save_window_save): Handle persistent
2231 window parameters.
2232
c85efaf7
EZ
22332012-01-14 Eli Zaretskii <eliz@gnu.org>
2234
2235 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2236 thrashing the stack of the thread. (Bug#9087)
2237
5944709e
PE
22382012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2241
e71f5d99
EZ
22422012-01-11 Eli Zaretskii <eliz@gnu.org>
2243
2244 * xdisp.c (rows_from_pos_range): Handle the case where the
2245 highlight ends on a newline. (Bug#10464)
2246 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2247 he end column for display of highlight that ends on a newline
2248 before a R2L line.
2249
ce316182
GM
22502012-01-11 Glenn Morris <rgm@gnu.org>
2251
2252 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2253 from load-path also when installation-directory is nil. (Bug#10208)
2254
5b43da69
GM
22552012-01-10 Glenn Morris <rgm@gnu.org>
2256
74cc8ff9
GM
2257 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2258
7d8d6e4e
GM
2259 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2260 Update template values to be closer to their typical values these days.
5b43da69 2261
a0db8d43
EZ
22622012-01-09 Eli Zaretskii <eliz@gnu.org>
2263
2264 * xdisp.c (rows_from_pos_range): Accept additional argument
2265 DISP_STRING, and accept any glyph in a row whose object is that
2266 string as eligible for mouse highlight. Fixes mouse highlight of
2267 display strings from overlays. (Bug#10464)
2268
9a0115ab 22692012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2270
b9110d6a 2271 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2272 * fileio.c (auto_saving_dir_umask): New static var.
2273 (Fmake_directory_internal): Use it.
2274 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2275 creating the directory. The old code temporarily assigns
2276 too-generous permissions to the directory.
2277 (do_auto_save_eh): Clear it.
b9110d6a 2278 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2279 that the var is always cleared.
2280
6c1bd3f3
EZ
22812012-01-07 Eli Zaretskii <eliz@gnu.org>
2282
2283 * search.c (scan_buffer): Pass character positions to
2284 know_region_cache, not byte positions. (Bug#6540)
2285
069d2b50
L
22862012-01-07 LynX <_LynX@bk.ru> (tiny change)
2287
2288 * w32.c (sys_rename): Report EXDEV when rename of a directory
2289 fails because the target is on another logical disk. (Bug#10284)
2290
75bf0d33
DB
22912012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2292
2293 * xterm.c (x_embed_request_focus): New function.
2294
2295 * xterm.h: Add prototype.
2296
2297 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2298
1c6e5a32
GM
22992012-01-05 Glenn Morris <rgm@gnu.org>
2300
2301 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2302
651e947e
EZ
23032012-01-01 Eli Zaretskii <eliz@gnu.org>
2304
2305 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2306 Load gnutls_transport_set_lowat only if GnuTLS version is below
2307 2.11.1.
2308 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2309 GnuTLS versions below 2.11.1.
2310
3778cdd8
AL
23112011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2312
2313 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2314 to the doc string advising against its use for altering the way
2315 windows are scrolled.
2316
0e5317f7
KH
23172011-12-28 Kenichi Handa <handa@m17n.org>
2318
2319 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2320 coding-system ASCII compatible only when it does not produce BOM
2321 on encoding (Bug#10383).
2322
93d5ca1f
JD
23232011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2324
2325 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2326 can scroll.
2327 (create_and_show_popup_menu): Always use menu_position_func for
2328 Gtk3 (Bug#10361).
2329
ca22b785
AS
23302011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2331
2332 * callint.c (Fcall_interactively): Don't truncate prompt string.
2333
d048e1e6
EZ
23342011-12-23 Eli Zaretskii <eliz@gnu.org>
2335
2336 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2337 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2338 resumed from there (after widening). (Bug#10360)
d048e1e6 2339
5ccaba1f
JD
23402011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2341
2342 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2343
204ee57f
JD
23442011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2345
b81d40f0
JB
2346 * nsterm.m (x_free_frame_resources):
2347 Release f->output_data.ns->miniimage.
204ee57f
JD
2348 (ns_index_color): Fix indentation. Do not retain
2349 color_table->colors[i].
2350
2351 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2352 before returning.
2353
2354 * nsfns.m (x_set_background_color): Assign return value from
2355 ns_index_color to face-background instead of NSColor*.
2356 (ns_implicitly_set_icon_type): Fix indentation.
2357 Change assignment in for loop to comparison.
2358
2359 * emacs.c (ns_pool): New variable.
2360 (main): Assign ns_pool.
2361 (Fkill_emacs): Call ns_release_autorelease_pool.
2362
2363 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2364 autorelease fdesc, release fdAttrs and tdict.
2365 (ns_get_covering_families): Release charset.
2366 (ns_findfonts): Release NSFontDescriptor created with new.
2367 (ns_uni_to_glyphs): Fix indentation.
2368 (setString): Release attrStr before assigning new value.
2369
c803b2b7
JD
23702011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2371
678f4426
JD
2372 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2373 and NS_IMPL_COCOA.
2374 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2375 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2376
cd394be1 23772011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2378
5fecd5fc
JD
2379 * nsterm.m (ns_term_init): Subscribe for notifications
2380 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2381 to method trackingNotification in EmacsMenu.
2382
2383 * nsmenu.m (trackingMenu): New variable.
3771cb17 2384 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2385 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2386 from Aquamacs (Bug#7030).
678f4426
JD
2387
23882011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2389
c803b2b7
JD
2390 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2391 (symbol_to_nsstring): Fix indentation.
2392 (ns_symbol_to_pb): New function.
cae07000
SM
2393 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2394 (Fns_rotate_cut_buffers_internal): Remove.
2395 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2396 Fns_store_cut_buffer_internal.
2397 (ns_get_foreign_selection, Fx_own_selection_internal)
2398 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2399 (Fns_get_selection_internal, Fns_store_selection_internal):
2400 Use ns_symbol_to_pb and check if return value is nil.
2401 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2402 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2403 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2404 renamed to Sns_store_selection_internal.
2405 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2406 and remove this function.
2407 (ns_handle_selection_clear): Remove, never used.
2408 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2409 here.
2410
e1b01a3a
KB
24112011-12-17 Ken Brown <kbrown@cornell.edu>
2412
2413 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2414 GID is unknown (Bug#10257).
2415
2adb6e85
PE
24162011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2417
2418 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2419 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2420 which caused a build failure on GNU/Linux IA-64. This problem was
2421 introduced by my 2011-10-07 patch.
2422
d1d7b339
JL
24232011-12-15 Juri Linkov <juri@jurta.org>
2424
2425 * image.c (imagemagick_error): New function. (Bug#10112)
2426 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2427 Use `imagemagick_error' where ImageMagick functions return
2428 `MagickFalse'.
2429 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2430 proper order.
2431
100d5755
KH
24322011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2433
2434 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2435 fill background (Bug#8992).
2436
454592a6
MR
24372011-12-13 Martin Rudalics <rudalics@gmx.at>
2438
2439 * window.c (Vwindow_combination_resize)
2440 (Vwindow_combination_limit): Use t instead of non-nil in
2441 doc-strings.
61d4b438
MR
2442 (Vrecenter_redisplay): Add first sentence of doc-string on
2443 separate line.
53524d93 2444 (Frecenter): Fix doc-string typo.
454592a6 2445
3633e3aa
KH
24462011-12-11 Kenichi Handa <handa@m17n.org>
2447
2448 * coding.c (Funencodable_char_position): Pay attention to the
2449 buffer text relocation (Bug#9389).
2450
7b9d523a 24512011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2452
7b9d523a
JD
2453 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2454 gtk_init (Bug#10100).
2455
b73189c6
EZ
24562011-12-10 Eli Zaretskii <eliz@gnu.org>
2457
2458 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2459 IT->string is nil. (Bug#10263)
2460
f7dfe5d6
JD
24612011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2462
83faebb4
JD
2463 * nsterm.h (x_free_frame_resources): Declare.
2464
f7dfe5d6
JD
2465 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2466 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2467
2468 * nsterm.h (ns_get_defaults_value): Declare.
2469
2470 * nsterm.m (ns_default): Call ns_get_defaults_value.
2471
7cd4e72c
EZ
24722011-12-09 Eli Zaretskii <eliz@gnu.org>
2473
2474 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2475 (Bug#10170)
2476
b34d7317
YM
24772011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2478
2479 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2480 that where the value of an _OBJC_* symbol points to is in the .bss
2481 section (Bug#10240).
2482
76470ad1
KH
24832011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2484
2485 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2486 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2487
745fff94
KH
24882011-12-08 Kenichi Handa <handa@m17n.org>
2489
2490 * ftfont.c (get_adstyle_property): Fix previous change
2491 (Bug#10233).
2492
6e44397c
JB
24932011-12-07 Juanma Barranquero <lekktu@gmail.com>
2494
2495 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2496 dirs from the default value of EMACSLOADPATH (bug#10208).
2497
7efa6272
GM
24982011-12-07 Glenn Morris <rgm@gnu.org>
2499
2500 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2501 installation and source directories as well. (Bug#10208)
2502
f6fc4d87
CY
25032011-12-06 Chong Yidong <cyd@gnu.org>
2504
2505 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2506
2bf26180
GM
25072011-12-06 Glenn Morris <rgm@gnu.org>
2508
2509 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2510 as an error, not just -1. (Bug#10217)
2511
3a6ad4f0
CY
25122011-12-05 Chong Yidong <cyd@gnu.org>
2513
2514 * keyboard.c (process_special_events): New function.
2515 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2516
75a3b399
PE
25172011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2518
2519 * coding.c (encode_designation_at_bol): Don't use uninitialized
2520 local variable (Bug#9318).
2521
c3c9e25e
KH
25222011-12-05 Kenichi Handa <handa@m17n.org>
2523
2524 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2525 return Qnil (Bug#8046, Bug#10193).
2526
5eb05ea3
KH
25272011-12-05 Kenichi Handa <handa@m17n.org>
2528
2529 * coding.c (encode_designation_at_bol): New args charbuf_end and
2530 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2531 (coding_set_source): Return how many bytes coding->source was
2532 relocated.
2533 (coding_set_destination): Return how many bytes
2534 coding->destination was relocated.
2535 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2536 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2537
25382011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2539
2540 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2541 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2542 macro (Bug#9318).
2543
25442011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2545
2546 The following changes are to fix Bug#9318.
2547
a79703f5 2548 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2549 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2550 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2551 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2552
7dbda6df
JB
25532011-12-05 Juanma Barranquero <lekktu@gmail.com>
2554
2555 * lisp.h (process_quit_flag): Fix external declaration.
2556
6d5eb5b0
SM
25572011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2558
2559 Don't macro-inline non-performance-critical code.
2560 * eval.c (process_quit_flag): New function.
2561 * lisp.h (QUIT): Use it.
2562
a0c3fad0
JD
25632011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2564
2565 * nsfns.m (get_geometry_from_preferences): New function.
2566 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2567
6c07aac2
AS
25682011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2569
2570 * emacs.c (Qkill_emacs): Define.
2571 (syms_of_emacs): Initialize it.
2572 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2573 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2574 (quit_throw_to_read_char): Add parameter `from_signal'.
2575 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2576 * lisp.h (QUIT): Call Fkill_emacs if requested.
2577
c052ead4
JD
25782011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2579
2580 * widget.c (update_wm_hints): Return if wmshell is null.
2581 (widget_update_wm_size_hints): New function.
2582
2583 * widget.h (widget_update_wm_size_hints): Declare.
2584
2585 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2586 widget_update_wm_size_hints (Bug#10104).
2587
9e49252b
EZ
25882011-12-03 Eli Zaretskii <eliz@gnu.org>
2589
2590 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2591 before a newline, prepare the bidi iterator for consuming the
2592 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2593 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2594
02b16839
JL
25952011-12-02 Juri Linkov <juri@jurta.org>
2596
2597 * search.c (Fword_search_regexp): New Lisp function created from
2598 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2599 (Fword_search_backward, Fword_search_forward)
2600 (Fword_search_backward_lax, Fword_search_forward_lax):
2601 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2602 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2603
0068070e
SM
26042011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2605
2606 * fileio.c (Finsert_file_contents): Move after-change-function call
2607 to before the "handled:" label, since all "goto handled" appear in
2608 cases where the *-change-functions have already been properly called
2609 (bug#10117).
2610
3360a3fc
AS
26112011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2612
2613 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2614 waiting for input. (Bug#10169)
2615
73d6c093
EZ
26162011-11-30 Eli Zaretskii <eliz@gnu.org>
2617
2618 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2619 verifies glyph row's hash code--we have just reallocated the
2620 glyphs, so their contents can be complete garbage. (Bug#10164)
2621
febe6bea
JB
26222011-11-30 Juanma Barranquero <lekktu@gmail.com>
2623
2624 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2625
801a4313
EZ
26262011-11-30 Eli Zaretskii <eliz@gnu.org>
2627
2628 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2629 attributes are tested _before_ calling verify_row_hash, to protect
2630 against GCC re-ordering of the tests. (Bug#10164)
2631
2b56b87e
JD
26322011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2633
2634 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2635
2636 * xterm.c (handle_one_xevent): Only set async_visible and friends
2637 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2638 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2639 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2640
dbf31225
PE
26412011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2642
2643 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2644 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2645 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2646 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2647 All uses changed to use GCPRO1 etc.
2648 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2649 Revert to old implementation (i.e., before 2011-03-11).
2650
1305621b
YM
26512011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2652
2653 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2654 of scroll runs so as to avoid assigning disabled bogus rows and
2655 unnecessary graphics copy operations.
2656
8c9afb46
EZ
26572011-11-27 Eli Zaretskii <eliz@gnu.org>
2658
2659 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2660 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2661 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2662 (malloc, free, realloc, calloc): Redirect to e_* only when
2663 compiling Emacs.
2664
2665 * lisp.h (GCTYPEBITS): Move before first use.
2666 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2667 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2668 this macro definition.
2669
2670 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2671 _MSC_VER.
2672
54e9e3bf
JD
26732011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2674
6d5eb5b0
SM
2675 * gtkutil.c (xg_create_frame_widgets):
2676 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2677 present with Gtk+ 2.0.
2678
83aca1cb
PE
26792011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2680
2681 * fileio.c (Finsert_file_contents): Undo previous change; see
2682 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2683
5b76caa4
PE
26842011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2685
2686 Rename locals to avoid shadowing.
2687 * fileio.c (Finsert_file_contents):
2688 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2689 * process.c (wait_reading_process_output):
2690 Rename inner 'proc' to 'p' to avoid shadowing.
2691 Indent for consistency with usual Emacs style.
2692
8c535114
EZ
26932011-11-25 Eli Zaretskii <eliz@gnu.org>
2694
2695 * xdisp.c (redisplay_window): If cursor row is not fully visible
2696 after recentering, and scroll-conservatively is set to a large
2697 number, scroll window by a few more lines to make the cursor fully
2698 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2699 (start_display): Don't move to the next line if the display should
2700 start at a newline that is part of a display vector or an overlay
2701 string. (Bug#10119)
8c535114 2702
fa4fdb5c
JL
27032011-11-24 Juri Linkov <juri@jurta.org>
2704
2705 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2706 after the `MagickPingImage' call. (Bug#10112)
2707
90ec88df
CY
27082011-11-23 Chong Yidong <cyd@gnu.org>
2709
2710 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2711
56e2e794
MR
27122011-11-23 Martin Rudalics <rudalics@gmx.at>
2713
2714 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2715 making another buffer current. (Bug#10114)
2716
b6e64c41
GM
27172011-11-23 Glenn Morris <rgm@gnu.org>
2718
2719 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2720
6b21de18
CY
27212011-11-23 Chong Yidong <cyd@gnu.org>
2722
2723 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2724 using it (Bug#5984).
2725
b12cd789
EZ
27262011-11-22 Eli Zaretskii <eliz@gnu.org>
2727
2728 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2729 and header-lines, as they don't have one computed for them.
2730 (Bug#10098)
2731
2732 * .gdbinit (prow): Make displayed values more self-explaining.
2733 Add row's hash code.
2734
261b6fd4
LMI
27352011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2736
2737 * process.c (wait_reading_process_output): Fix asynchrounous
2738 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 2739 (wait_reading_process_output): Add comment and URL.
261b6fd4 2740
e7cfd277
JD
27412011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2742
2743 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2744
a9b9b7f5
CY
27452011-11-21 Chong Yidong <cyd@gnu.org>
2746
2747 * window.c (Fnext_window, Fprevious_window): Doc fix.
2748
b0d15b4f
SM
27492011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2750
2751 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2752
fe7a3057
JB
27532011-11-20 Juanma Barranquero <lekktu@gmail.com>
2754
2755 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2756
d2999b1a
MR
27572011-11-20 Martin Rudalics <rudalics@gmx.at>
2758
2759 * window.c (Fset_window_combination_limit): Rename argument
2760 STATUS to LIMIT.
2761 (Vwindow_combination_limit): Remove "status" from doc-string.
2762
d5ff9cd0
AS
27632011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2764
2765 * m/ibms390.h: Remove.
2766 * m/ibms390x.h: Don't include "ibms390.h".
2767
a5bb9bd3
SM
27682011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2769
2770 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2771 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2772
cd1181db
JB
27732011-11-20 Juanma Barranquero <lekktu@gmail.com>
2774
2775 * casetab.c (Fset_case_table):
2776 * charset.c (Fcharset_after): Fix typos.
2777
615a3b8d 27782011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 2779
17e845af
PE
2780 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2781 Otherwise, valgrind does not work on some platforms.
2782 Problem reported by Andreas Schwab in
6a0bf43d
PE
2783 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2784 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2785 is set, removing the need for VIRT_ADDRESS_VARIES.
2786 (PURE_P): Use a more-efficient implementation that needs just one
2787 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2788 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2789 to 4 (xorl, subq, cmpq, setbe).
2790 * alloc.c (pure): Always extern now, since that's the
2791 VIRT_ADDR_VARIES behavior.
2792 (PURE_POINTER_P): Use a single comparison, not two, for
2793 consistency with the new puresize.h.
2794 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2795 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2796 Remove VIRT_ADDR_VARIES no longer needed.
2797
f8fe6f96
EZ
27982011-11-19 Eli Zaretskii <eliz@gnu.org>
2799
2800 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2801 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2802 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2803 behave as if the cursor position were at the window margin.
2804
2805 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2806 and the cursor position is out of bounds, behave as if the cursor
2807 position were at the window margin. (Bug#10075)
2808
df05a53c
CY
28092011-11-18 Chong Yidong <cyd@gnu.org>
2810
2811 * window.c (Fwindow_combination_limit): Make first argument
2812 non-optional, since it is meaningless for live windows like the
2813 selected window.
61ccba97 2814
2071918e
DA
28152011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2816
2817 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2818
b50a28de
SM
28192011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2820
2821 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2822 (graft_intervals_into_buffer): Simplify.
2823
015137db
EZ
28242011-11-18 Eli Zaretskii <eliz@gnu.org>
2825
2826 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2827 hash values of the two rows.
2828 (copy_row_except_pointers): Preserve the used[] arrays and the
2829 hash values of the two rows. (Bug#10035)
68c95424 2830 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
2831
2832 * xdisp.c (row_hash): New function, body extracted from
2833 compute_line_metrics.
2834 (compute_line_metrics): Call row_hash, instead of computing the
2835 hash code inline.
2836
2837 * dispnew.c (verify_row_hash): Call row_hash for computing the
2838 hash code of a row, instead of duplicating code from xdisp.c.
2839
2840 * dispextern.h (row_hash): Add prototype.
2841
a2addb04
TH
28422011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2843
2844 * frame.c (delete_frame): Don't delete the terminal when the last
2845 X frame is closed if emacs is built with GTK toolkit.
2846
df85d315
JB
28472011-11-17 Juanma Barranquero <lekktu@gmail.com>
2848
2849 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2850
a0c2d0ae
MR
28512011-11-17 Martin Rudalics <rudalics@gmx.at>
2852
2853 * window.c (Vwindow_splits): Rename to
2854 Vwindow_combination_resize. Suggested by Juri Linkov.
2855 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2856 of Vwindow_splits.
2857
58179cce
JB
28582011-11-16 Juanma Barranquero <lekktu@gmail.com>
2859
7877f373
JB
2860 * nsfns.m (Fns_font_name):
2861 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 2862
b6f67890
MR
28632011-11-16 Martin Rudalics <rudalics@gmx.at>
2864
2865 * window.h (window): Rename slot "nest" to "combination_limit".
2866 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2867 (Fset_window_nest): Rename to Fset_window_combination_limit.
2868 (Vwindow_nest): Rename to Vwindow_combination_limit.
2869 (recombine_windows, make_parent_window, make_window)
2870 (Fsplit_window_internal, saved_window)
2871 (Fset_window_configuration, save_window_save): Rename all
2872 occurrences of window_nest to window_combination_limit.
2873
c7015153
JB
28742011-11-15 Juanma Barranquero <lekktu@gmail.com>
2875
2876 * image.c (imagemagick_load_image): Fix typo.
2877
322ad6ec
EZ
28782011-11-14 Eli Zaretskii <eliz@gnu.org>
2879
2880 * xdisp.c (display_line): Move the call to
2881 highlight_trailing_whitespace before the call to
2882 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
2883 faces of all the glyphs to compute ROW's hash value.
2884 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 2885
f067b8ec
JB
28862011-11-14 Juanma Barranquero <lekktu@gmail.com>
2887
2888 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2889 just return (bug#10044).
2890
1e5b2111
EZ
28912011-11-12 Eli Zaretskii <eliz@gnu.org>
2892
7ef3cbd5
EZ
2893 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2894 with user-defined heap size. Bump the default size of the temacs
2895 heap to 27MB, to avoid memory warning when running temacs.
2896 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2897
1e5b2111
EZ
2898 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2899 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
2900 (verify_row_hash) [XASSERTS]: New function.
2901 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2902 that the hash value of glyph rows is correct.
1e5b2111 2903
89d61221
MR
29042011-11-12 Martin Rudalics <rudalics@gmx.at>
2905
2906 * window.h (window): Remove splits slot.
2907 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2908 (Fdelete_other_windows_internal, make_parent_window)
2909 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2910 (Fset_window_configuration, save_window_save): Don't deal with
2911 split status of windows.
2912 (saved_window): Remove splits slot.
2913 (Vwindow_splits): Rewrite doc-string.
2914
97f18cc8
JD
29152011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2916
2917 * xfns.c (unwind_create_frame):
2918 * nsfns.m (unwind_create_frame):
2919 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2920 Vframe_list (Bug#9999).
2921
22a648b4
DA
29222011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2923
0b381c7e 2924 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 2925
659afede
KH
29262011-11-11 Kenichi Handa <handa@m17n.org>
2927
2928 * callproc.c (Fcall_process): Set the member dst_multibyte of
2929 process_coding.
2930
9ac0394b
KH
29312011-11-11 Johan Bockgård <bojohan@gnu.org>
2932
2933 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2934 avoid a crash (bug#9496).
2935
2fbdc249
CY
29362011-11-09 Chong Yidong <cyd@gnu.org>
2937
2938 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2939 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2940
ac6b1f81
PE
29412011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2942
2943 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2944
09db192c
PE
29452011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2946
2947 Avoid some portability problems by eschewing 'extern inline' functions.
2948 The trivial performance wins aren't worth the portability hassles; see
2949 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2950 et seq.
2951 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2952 (window_box_width, window_box_left, window_box_left_offset)
2953 (window_box_right, window_box_right_offset): Undo previous change,
2954 by removing the "extern"s.
2955 * intervals.c (adjust_intervals_for_insertion)
2956 (adjust_intervals_for_deletion): Undo previous change,
2957 making these static again.
2958 (offset_intervals, temp_set_point_both, temp_set_point)
2959 (copy_intervals_to_string): No longer inline.
2960 * xdisp.c (window_text_bottom_y, window_box_width)
2961 (window_box_height, window_box_left_offset)
2962 (window_box_right_offset, window_box_left, window_box_right)
2963 (window_box): No longer inline.
2964
105216ed
CY
29652011-11-08 Chong Yidong <cyd@gnu.org>
2966
2967 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
2968 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2969 Signal an error if not a live window.
105216ed
CY
2970 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2971 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2972
ae9e237f
JB
29732011-11-07 Juanma Barranquero <lekktu@gmail.com>
2974
2975 * lisp.h (syms_of_abbrev): Remove declaration.
2976 Reported by CHENG Gao <chenggao@royau.me>.
2977
c7aa8333
EZ
29782011-11-07 Eli Zaretskii <eliz@gnu.org>
2979
2980 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2981 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2982 of temacs in GUI mode.
2983
be7f5545
MR
29842011-11-07 Martin Rudalics <rudalics@gmx.at>
2985
2986 * window.h: Declare delete_all_child_windows instead of
2987 delete_all_subwindows.
2988 * window.c (Fwindow_nest, Fset_window_nest)
2989 (Fset_window_new_total, Fset_window_new_normal)
2990 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2991 (delete_all_subwindows): Rename to delete_all_child_windows.
2992 (Fdelete_other_windows_internal, Fset_window_configuration):
2993 Call delete_all_child_windows instead of delete_all_subwindows.
2994 * frame.c (delete_frame): Call delete_all_child_windows instead
2995 of delete_all_subwindows.
2996
ca78dc43
PE
29972011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2998
2999 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3000 This is also needed for porting to any host where GC_MARK_STACK is
3001 not GC_MAKE_GCPROS_NOOPS.
3002 (which_symbols): Use it.
3003
a0241d01
KH
30042011-11-07 Kenichi Handa <handa@m17n.org>
3005
3006 * coding.c (coding_set_destination): Check coding->src_pos only
3007 when coding->src_object is a buffer (bug#9910).
3008
3009 * process.c (send_process): Set the member src_multibyte of coding
3010 to 0 (bug#9911) when sending a unibyte text.
3011
3012 * callproc.c (Fcall_process): Set the member src_multibyte of
3013 process_coding to 0 (bug#9912).
3014
a64bfdfa 30152011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3016
3017 * xmenu.c (cleanup_widget_value_tree): New function.
3018 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3019 calling free_menubar_widget_value_tree directly (Bug#9830).
3020
cb41b32a
PE
30212011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3022
3023 Fix some portability problems with 'inline'.
3024 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3025 (window_box_width, window_box_left, window_box_left_offset)
3026 (window_box_right, window_box_right_offset): Declare extern.
3027 Otherwise, these inline functions do not conform to C99 and
3028 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3029 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3030 * intervals.c (adjust_intervals_for_insertion)
3031 (adjust_intervals_for_deletion): Now extern, because otherwise the
3032 extern inline functions 'offset_intervals' couldn't refer to it.
3033 (static_offset_intervals): Remove.
3034 (offset_intervals): Rewrite using the old contents of
3035 static_offset_intervals. The old version didn't conform to C99
3036 because an extern inline function contained a reference to an
3037 identifier with static linkage.
3038
b7041366
AS
30392011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3040
3041 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3042 GC.
3043
88a37c4d
EZ
30442011-11-06 Eli Zaretskii <eliz@gnu.org>
3045
3046 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3047 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3048 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3049 return Qleft_to_right.
3050
49745b39
CY
30512011-11-06 Chong Yidong <cyd@gnu.org>
3052
3053 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3054 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3055 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3056 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3057 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3058 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3059 (Fwindow_vscroll): Doc fix.
3060 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3061 argument, since it makes no sense to pass a live window and for
3062 consistency with window-child.
3063
1f05cd82
CS
30642011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3065
3066 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3067 support MSVC.
3068
22610910
JR
30692011-11-05 Jason Rumney <jasonr@gnu.org>
3070
3071 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3072 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3073 fonts (Bug#6029).
3074 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3075 bitwise arithmetic preventing use of unicode-sip and non-truetype
3076 opentype fonts.
3077
a06776b2
EZ
30782011-11-05 Eli Zaretskii <eliz@gnu.org>
3079
3ad924ba
EZ
3080 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3081 "emacs"-only part.
3082
a06776b2
EZ
3083 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3084 initialization code to keep similarity to xfns.c after changes
3085 from 2011-11-05.
3086
c9e7db78
JD
30872011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3088
a97f8f3f
JD
3089 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3090 (unwind_create_frame): New function (Bug#9943).
3091 (Fx_create_frame): Restructure code to be more similar to the one in
3092 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3093 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3094 Move terminal->reference_count++ just before making the frame official
3095 (Bug#9943).
3096
3097 * nsterm.m (x_free_frame_resources): New function.
3098 (x_destroy_window): Move code to x_free_frame_resources.
3099
c9e7db78 3100 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3101 (Fx_create_frame, x_create_tip_frame):
3102 Move terminal->reference_count++ just before making the frame
75f1671a 3103 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3104 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3105
a6fc3b5c
EZ
31062011-11-05 Eli Zaretskii <eliz@gnu.org>
3107
3108 Support MSVC build with newer versions of Visual Studio.
3109 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3110 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3111 nt/gmake.defs.
3112
3113 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3114 which are not supported by MSVC.
3115 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3116 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3117 bitfields.
3118 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3119 types in bitfields.
3120 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3121
3122 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3123
58179cce 31242011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3125
3126 Support MSVC build with newer versions of Visual Studio.
3127 * w32.c: Don't include w32api.h for MSVC.
3128 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3129
3130 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3131 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3132 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3133 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3134 e_* cousins.
3135 (alloca) [_MSC_VER]: Define to _alloca.
3136
3137 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3138
3139 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3140
a58c13ed
EZ
31412011-11-04 Eli Zaretskii <eliz@gnu.org>
3142
3143 * xdisp.c (note_mouse_highlight): If either of
3144 previous/next-single-property-change returns nil, treat that as
3145 the beginning or the end of the buffer. (Bug#9955)
3146
fe0b6370
JD
31472011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3148
a58c13ed 3149 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3150 label is not null (Bug#9951).
3151 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3152 may be NULL.
3153
89bd5ee1
EZ
31542011-11-04 Eli Zaretskii <eliz@gnu.org>
3155
3156 * window.c (Fwindow_body_size): Mention in the doc string that the
3157 return value is in frame's canonical units. (Bug#9949)
3158
84c3edb9
EZ
31592011-11-03 Eli Zaretskii <eliz@gnu.org>
3160
4e2fb5c7
EZ
3161 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3162
84c3edb9 3163 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3164 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3165 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3166
bc17a887
EZ
31672011-11-01 Eli Zaretskii <eliz@gnu.org>
3168
3169 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3170 Don't stop backward scan on the continuation glyph, even though
3171 its CHARPOS is positive.
6d5eb5b0
SM
3172 (mouse_face_from_buffer_pos, note_mouse_highlight):
3173 Rename cover_string to disp_string.
bc17a887 3174
4ee88440
MR
31752011-11-01 Martin Rudalics <rudalics@gmx.at>
3176
3177 * window.c (temp_output_buffer_show): Don't use
3178 Vtemp_buffer_show_specifiers.
3179 (Vtemp_buffer_show_specifiers): Remove unused variable.
3180
c2ff3c02
EZ
31812011-10-30 Eli Zaretskii <eliz@gnu.org>
3182
3183 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3184 past the beginning of the current glyph matrix.
3185
58179cce 31862011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3187
3188 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3189 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3190 HAVE_GTK3 (Bug#9869).
b77a6a7f 3191
3b574623
JD
3192 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3193 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3194
b77a6a7f
JD
3195 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3196
3197 * xterm.c: Declare x_handle_net_wm_state to return int.
3198 (handle_one_xevent): Check if we are iconified but don't have
3199 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3200 (get_current_wm_state): Return non-zero if not hidden,
3201 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3202 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3203 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3204 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3205
196e41e4
PE
32062011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3207
3208 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3209 so that this new function doesn't get optimized away by a
3210 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3211
021f2e1a
AS
32122011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3213
3214 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3215
8b058d44
EZ
32162011-10-29 Eli Zaretskii <eliz@gnu.org>
3217
3218 Fix the `xbytecode' command.
3219 * .gdbinit (xprintbytestr): New command.
b50a28de 3220 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3221 (xbytecode): Print the byte-code string as well.
3222
4452fb80
EZ
32232011-10-29 Kim Storm <storm@cua.dk>
3224
8b058d44
EZ
3225 * alloc.c (which_symbols): New function.
3226
21b72067
AS
32272011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3228
3229 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3230 line. (Bug#9903)
3231
83ed7b5c
GM
32322011-10-29 Glenn Morris <rgm@gnu.org>
3233
3234 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3235 Not clear what it was for, and it causes various bugs. (Bug#9839)
3236
5a7a728b
EZ
32372011-10-28 Eli Zaretskii <eliz@gnu.org>
3238
3239 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3240 possible random value that matches one of those tested as
3241 condition to clear the mouse face.
3242
d3d0842f
CY
32432011-10-28 Chong Yidong <cyd@gnu.org>
3244
3245 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3246
31b39d13
DN
32472011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3248
3249 * window.c (make_window): Initialize phys_cursor_on_p.
3250
9aba6043
SM
32512011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3252
3253 * lisp.h (struct Lisp_Symbol): Update comments.
3254
c20992f4
JB
32552011-10-28 Juanma Barranquero <lekktu@gmail.com>
3256
3257 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3258
db4f02f2
EZ
32592011-10-28 Eli Zaretskii <eliz@gnu.org>
3260
3261 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3262 <oslsachem@gmail.com> for helping to debug this.
3263
3264 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3265 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3266 (g_b_init_get_glyph_outline_w): New static variables.
3267 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3268 (GetGlyphOutlineW_Proc): New typedefs.
3269 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3270 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3271 New functions.
3272 (w32font_open_internal, compute_metrics):
3273 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3274 instead of calling the "wide" APIs directly.
3275
3276 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3277
3278 * w32.h (syms_of_w32font): Add prototype.
3279
87e68db4
JB
32802011-10-27 Juanma Barranquero <lekktu@gmail.com>
3281
3282 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3283 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3284 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3285 (Fmove_to_window_line): Doc fix.
3286
435c1d67
CY
32872011-10-27 Chong Yidong <cyd@gnu.org>
3288
3289 * process.c (make_process): Set gnutls_state to NULL.
3290
3291 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3292 non-NULL, regardless of GNUTLS_INITSTAGE.
3293 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3294 an error. Set process slots as soon as we allocate them.
3295
3296 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3297
9c6c6f49
CY
32982011-10-27 Chong Yidong <cyd@gnu.org>
3299
9aba6043
SM
3300 * gnutls.c (emacs_gnutls_deinit): New function.
3301 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3302 (Fgnutls_deinit, Fgnutls_boot): Use it.
3303
3304 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3305 (deactivate_process): Call emacs_gnutls_deinit.
3306
657d08d3
JB
33072011-10-27 Juanma Barranquero <lekktu@gmail.com>
3308
3309 * image.c (x_create_x_image_and_pixmap):
3310 * w32.c (sys_rename, w32_delayed_load):
3311 * w32font.c (fill_in_logfont):
3312 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3313
5430d399
JB
33142011-10-26 Juanma Barranquero <lekktu@gmail.com>
3315
3316 * w32fns.c (w32_default_color_map): New function,
3317 extracted from Fw32_default_color_map.
a7ef684b 3318 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3319
fe0055fa
PE
33202011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3321
3322 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3323
e6346438
SM
33242011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3325
3326 * keyboard.c (test_undefined): New function (bug#9751).
3327 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3328
e112cc37
ET
33292011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3330
3331 * sysdep.c (init_sys_modes): Fix the check for the controlling
3332 terminal (Bug#6649).
3333
7b5d6677
EZ
33342011-10-20 Eli Zaretskii <eliz@gnu.org>
3335
3336 * dispextern.h (struct bidi_it): New member next_en_type.
3337
3338 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3339 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3340 current character, check also for next_en_type being WEAK_EN.
3341 (bidi_resolve_weak): Don't enter the expensive loop if the current
3342 position is before next_en_pos. Record the bidi type of the first
3343 non-ET, non-BN character we find, in addition to its position.
3344 (bidi_level_of_next_char): Invalidate next_en_type when
3345 next_en_pos is over-stepped.
3346
7da0b018
PE
33472011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3348
3349 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3350 * editfns.c: Rewrite current-time-zone so that it invokes
3351 the equivalent of (format-time-string "%Z") to get the time zone name.
3352 This fixes a bug when the time zone name contains characters that
3353 need converting from the system time locale to Emacs internal format.
3354 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3355 that patch fixed format-time-string to do the conversion, but
3356 I forgot to fix current-time-zone.
3357 (format_time_string): New function, containing most of
3358 what Fformat_time_string used to contain.
3359 (Fformat_time_string): Rewrite in terms of format_time_string.
3360 This doesn't change this function's behavior.
3361 (current-time-zone): Rewrite to use format_time_string.
3362 This fixes the bug reported by Michael Schierl in
3363 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3364 Jason Rumney's 2007-06-07 change worked around this bug, but
3365 didn't fix it.
3366 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3367
8547b010
EZ
33682011-10-19 Eli Zaretskii <eliz@gnu.org>
3369
3370 * xdisp.c (start_display): If the character at POS is displayed
3371 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3372 (try_window_reusing_current_matrix): If a line ends in a display
3373 vector or the next line starts in a display vector, continue
3374 redrawing the window even though the character position of
3375 start_row was reached.
8547b010
EZ
3376 (Bug#9771, part 2)
3377
4e948d15
CY
33782011-10-18 Chong Yidong <cyd@gnu.org>
3379
3380 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3381 with nobreak-char-display too.
3382
4787455f
EZ
33832011-10-18 Eli Zaretskii <eliz@gnu.org>
3384
3385 Fix part 3 of bug#9771.
3386 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3387 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3388 non-neutral characters if the current character is a paragraph
3389 separator (a.k.a. Newline). This avoids running the same
3390 expensive loop twice, once when we consume the preceding newline
3391 and the other time when the line actually needs to be displayed.
3392 Avoid the loop when we see neutrals on the base embedding level
3393 following a character whose directionality is the same as the
3394 paragraph's. This avoids running the expensive loop when a line
3395 ends in a long sequence of neutrals, like control characters.
3396 Add assertion against STRONG_AL type. Slightly rearrange code
3397 that determines the type of a neutral given the first non-neutral
3398 that follows it.
3399 (bidi_level_of_next_char): Set next_en_pos to zero when
3400 invalidating its info.
3401
2c91f553
EZ
34022011-10-17 Eli Zaretskii <eliz@gnu.org>
3403
3404 * xdisp.c (push_display_prop): Determine whether to record string
3405 or buffer position by IT->string, not by IT->method. Allow
3406 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3407 (move_it_vertically_backward): Don't look for character position
3408 immediately after the newline when in a continuation line.
3409 (Bug#9771, part 1)
2c91f553 3410
c7b08b0d
MR
34112011-10-15 Martin Rudalics <rudalics@gmx.at>
3412
3413 * window.c (coordinates_in_window): Rewrite and delabelize
3414 vertical border check. (Bug#5357) (Bug#9618)
3415
6b02f655
SM
34162011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3417
3418 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3419 errors in XSetWindowBorder (bug#9310).
3420
81d40c92
DA
34212011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3422
3423 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3424 avoid crash when xmalloc overrun checking is enabled.
3425
d4172c3b
EZ
34262011-10-13 Eli Zaretskii <eliz@gnu.org>
3427
3428 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3429 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3430 cursor motion with <left> and <right> arrow keys.
3431
3432 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3433 some callers set that themselves.
3434
b00eea75
EZ
34352011-10-12 Eli Zaretskii <eliz@gnu.org>
3436
3437 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3438 display string and the previous row comes from the same string and
3439 is empty. (Bug#9739) (Bug#9738)
3440
8fe012c4
SM
34412011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3442
3443 * doc.c (get_doc_string): Encode file name (bug#9735).
3444
0074aef2
EZ
34452011-10-12 Eli Zaretskii <eliz@gnu.org>
3446
79beb178
EZ
3447 * bidi.c (bidi_level_of_next_char):
3448 * xdisp.c (get_visually_first_element): Remove old incorrect
3449 comments regarding the Unicode Line Separator character.
3450
0074aef2
EZ
3451 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3452
6e4b3fbe
DA
34532011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3454
3455 * alloc.c (Fgc_status): Do not access beyond zombies array
3456 boundary if nzombies > MAX_ZOMBIES.
3457 * alloc.c (dump_zombies): Add missing format specifier.
3458
0324f3af
PE
34592011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3460
b5525cac
PE
3461 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3462 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3463
0324f3af
PE
3464 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3465 Some packages use them to denote characters with modifiers.
3466
e9b5f888
AS
34672011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3468
3469 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3470 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3471 matching a pp-number. Rename parameter var to var1.
3472
127827c0
SM
34732011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3474
3475 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3476
c8fd3bd0
GM
34772011-10-08 Glenn Morris <rgm@gnu.org>
3478
3479 * callint.c (Fcall_interactively): Give a more explicit error for the
3480 'c' case with a non-character input. (Bug#8479)
3481
352ec8ff
EZ
34822011-10-08 Eli Zaretskii <eliz@gnu.org>
3483
03669ccb
EZ
3484 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3485 lines.
7061c986
EZ
3486 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3487 lines that are hscrolled on the left.
03669ccb 3488
352ec8ff
EZ
3489 * dispnew.c (buffer_posn_from_coords): Account for a possible
3490 presence of header-line. (Bug#4426)
3491
a66cfb1c
SM
34922011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3493
6b02f655
SM
3494 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3495 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3496
7c5ee88e
PE
34972011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3498
3499 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3500 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3501 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3502 this makes Emacs dump core during garbage collection on rare
3503 occasions. sizeof is obviously inferior to offsetof here, so
3504 stick with offsetof.
3505 (GC_POINTER_ALIGNMENT): New macro.
3506 (mark_memory): Omit 3rd (offset) arg; caller changed.
3507 Don't assume EMACS_INT alignment is the same as pointer alignment.
3508
df1bbe5b
SM
35092011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3510
3511 * keyboard.c (read_key_sequence_remapped): New var.
3512 (read_key_sequence): Compute remapping in the right buffer.
3513 (command_loop_1): Use read_key_sequence's remapping directly.
3514
51553db6
SM
35152011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3516
32c1fffd
SM
3517 * dired.c (file_name_completion): Don't expand file name.
3518 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3519 before checking file name handler.
3520
51553db6
SM
3521 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3522 they've been requested explicitly (bug#9591).
3523
b6bd1599 35242011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3525
3526 * keymap.c (Fsingle_key_description): Use make_specified_string
3527 instead of build_string to build string from push_key_description.
3528 (Bug#5193)
3529
f701dc2a
PE
35302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3531
4222c55d
PE
3532 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3533 This fixes a Y2038 bug on 64-bit hosts.
3534 * buffer.c (reset_buffer):
3535 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3536 (Fclear_buffer_auto_save_failure):
3537 Use 0, not -1, to represent an unset failure time, since time_t
3538 might not be signed.
3539
f701dc2a
PE
3540 Remove dependency on glibc malloc internals.
3541 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3542 Move back here from lisp.h, but with their new implementations.
3543 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3544 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3545 * charset.c (charset_table_init): New static var.
3546 (syms_of_charset): Use it instead of xmalloc. This removes a
3547 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3548 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3549 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3550 Move back to alloc.c.
3551 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3552 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3553
9ceebf39
JD
35542011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3555
3556 * nsterm.m (windowDidResize): Call x_set_window_size only when
3557 ns_in_resize is true. Otherwise set pixelwidth/height and
3558 call change_frame_size (Bug#9628).
3559
cb993c58
PE
35602011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3561
3930c88b
PE
3562 Port --enable-checking=all to Fedora 14 x86-64.
3563 * charset.c (syms_of_charset): Also account for glibc malloc's
3564 internal overhead when calculating the initial malloc maximum.
3565
cb993c58
PE
3566 Port --enable-checking=all to Fedora 14 x86.
3567 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3568 Move to lisp.h.
3569 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3570 (overrun_check_realloc, overrun_check_free):
3571 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3572 That way, xmalloc returns a properly-aligned pointer even if
3573 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3574 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3575 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3576 into account when calculating the initial malloc maximum.
3577 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3578 Move here from alloc.c, so that charset.c can use it too.
3579 Properly align; the old code wasn't right for common 32-bit hosts
3580 when configured with --enable-checking=all.
3581 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3582 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3583
31bed486
EZ
35842011-09-29 Eli Zaretskii <eliz@gnu.org>
3585
04c70788 3586 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3587 use EDOM.
3588
fbcaa2f3
EZ
35892011-09-28 Eli Zaretskii <eliz@gnu.org>
3590
3591 * xdisp.c (compute_display_string_end): If there's no display
3592 string at CHARPOS, return -1.
3593
3594 * bidi.c (bidi_fetch_char): When compute_display_string_end
3595 returns a negative value, treat the character as a normal
3596 character not covered by a display string. (Bug#9624)
3597
a239d4e9
JB
35982011-09-28 Juanma Barranquero <lekktu@gmail.com>
3599
3600 * lread.c (Fread_from_string): Fix typo in docstring.
3601
88652fd5
EZ
36022011-09-27 Eli Zaretskii <eliz@gnu.org>
3603
3604 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3605 newline, reseat the iterator instead of bidi-iterating there one
3606 character at a time. (Bug#9610)
32c1fffd
SM
3607 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3608 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3609
ed497dd4
AS
36102011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3611
3612 * lread.c (readevalloop): Use correct code for NBSP.
3613 (read1): Likewise. (Bug#9608)
3614
b2bf61aa
MA
36152011-09-25 Michael Albinus <michael.albinus@gmx.de>
3616
3617 * dbusbind.c (Fdbus_register_signal): When service is not
3618 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3619
32bbb17c
GM
36202011-09-25 Glenn Morris <rgm@gnu.org>
3621
3622 * buffer.c (truncate-lines): Doc fix.
3623
94e0933e
CY
36242011-09-24 Chong Yidong <cyd@stupidchicken.com>
3625
3626 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3627 (Fset_window_next_buffers): Doc fix.
3628
cddde921
GM
36292011-09-24 Glenn Morris <rgm@gnu.org>
3630
3631 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3632
1260aef1
PE
36332011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3634
25b4bfa0
PE
3635 Fix minor problems found by static checking.
3636 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3637 * indent.c (Fvertical_motion): Fix == vs = typo.
3638
e3cbd34b
EZ
36392011-09-24 Eli Zaretskii <eliz@gnu.org>
3640
a66cfb1c
SM
3641 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3642 Default value is now t. Doc fix.
6bf7006f 3643
e3cbd34b 3644 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3645 logic when moving up, not only when moving down. Fix the
e3cbd34b 3646 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3647 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3648
3649 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3650 CHARPOS is covered by a display string which includes newlines.
3651 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3652 is covered by a display string with embedded newlines.
3653
a3de0cbd
MA
36542011-09-24 Michael Albinus <michael.albinus@gmx.de>
3655
3656 * dbusbind.c (Fdbus_register_signal): Add match rule to
3657 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3658 (Fdbus_register_method, Vdbus_registered_objects_table):
3659 Fix docstring.
a3de0cbd 3660
b260039d
JM
36612011-09-24 Jim Meyering <meyering@redhat.com>
3662
32c1fffd 3663 do not ignore write error for any output size
b260039d
JM
3664 The previous change was incomplete.
3665 While it makes emacs --batch detect the vast majority of stdout
3666 write failures, errors were still ignored whenever the output size is
3667 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3668 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3669 && echo FAIL: ignored write error
3670 FAIL: ignored write error
3671 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3672 && echo FAIL: ignored write error
3673 FAIL: ignored write error
3674 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3675
8eca8a7c
AS
36762011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3677
3678 * emacs.c (Fkill_emacs): In noninteractive mode exit
3679 non-successfully if a write error occurred on stdout. (Bug#9574)
3680
3341db62
EZ
36812011-09-21 Eli Zaretskii <eliz@gnu.org>
3682
3683 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3684 the xassert test.
3685
3686 * dispextern.h (struct it): Update the comment documenting what
3687 can it->OBJECT be.
3688
8c203dbf
EZ
36892011-09-20 Eli Zaretskii <eliz@gnu.org>
3690
3691 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3692 a display string, extend search for cursor position to end of row.
3693 (find_row_edges): If the row ends in a newline from a display
3694 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3695 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3696 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3697 non-empty line. Fixes confusing cursor motion with arrow keys at
3698 the beginning of a line that starts with whitespace.
8c203dbf 3699
a4824228
LMI
37002011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3701
3702 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3703 (bug#9493).
3704
33ed493b
CY
37052011-09-18 Chong Yidong <cyd@stupidchicken.com>
3706
3707 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3708 boolean (Bug#9154).
3709
56cd55c8
EZ
37102011-09-18 Eli Zaretskii <eliz@gnu.org>
3711
3712 * xdisp.c (display_line): Record maximum and minimum buffer
3713 positions even if no glyphs were produced (e.g., by a zero-width
3714 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3715 buffer positions that will be removed from the glyph row because
3716 they don't fit.
c02dcedf
EZ
3717 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3718 column is beyond frame width: don't subtract 1 "pixel" when
3719 computing width of the stretch.
3e62b7e0
EZ
3720 (reseat_at_next_visible_line_start): Undo the change made on
3721 2011-09-17 that saved paragraph information and restored it after
3722 the call to `reseat'. (Bug#9545)
56cd55c8 3723
5ed99d36 37242011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
3725
3726 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3727 and turn window cursor on if cleared (Bug#9415).
3728
5ed99d36 37292011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
3730
3731 * search.c (boyer_moore): Take unibyte characters from pattern
3732 literally. (Bug#9458)
3733
9bade7b2
EZ
37342011-09-18 Eli Zaretskii <eliz@gnu.org>
3735
3736 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3737
e5e9d610
PE
37382011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3739
87e4427a
PE
3740 Fix minor problem found by static checking.
3741 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3742 initialized, to pacify gcc -Wuninitialized.
3743
e5e9d610
PE
3744 * fileio.c: Report proper errno when syscall falls.
3745 (Finsert_file_contents): Save and restore errno,
3746 so that report_file_error outputs the correct diagnostic.
3747 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3748
a1674f0b
EZ
37492011-09-18 Eli Zaretskii <eliz@gnu.org>
3750
3751 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3752
fbfb6dd4
EZ
37532011-09-17 Eli Zaretskii <eliz@gnu.org>
3754
3755 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3756 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3757
bb187662
EZ
37582011-09-17 Eli Zaretskii <eliz@gnu.org>
3759
1137e8b8 3760 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 3761 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
3762
3763 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3764 (bidi_find_paragraph_start): Search back for paragraph beginning
3765 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3766 (bidi_move_to_visually_next): Only trigger paragraph-related
3767 computations when the last character is a newline or at EOB, not
3768 just any NEUTRAL_B. (Bug#9470)
3769
bb187662
EZ
3770 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3771 truncated lines if point is covered by a display string. (Bug#9524)
3772
2e621251
PE
37732011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3774
3775 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3776 (cons_to_x_long): New function.
3777 (lisp_data_to_selection_data): Use it. Correct the test for
3778 short-versus-long data; it was negated. Break out of vector
3779 loop, for efficiency, when a long datum is discovered.
3780
91a15bc6
SM
37812011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3782
3783 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3784
b41c3a35
EZ
37852011-09-16 Eli Zaretskii <eliz@gnu.org>
3786
3787 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3788 GCC PR/17406) by declaring this function with external scope.
3789
7812ba2d
PE
37902011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3791
3792 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3793 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3794
cf7edc2a
AS
37952011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3796
3797 * editfns.c (Fformat): Correctly handle text properties on "%%".
3798
bd01620e
EZ
37992011-09-15 Eli Zaretskii <eliz@gnu.org>
3800
3801 * xterm.c (x_draw_composite_glyph_string_foreground):
3802 * w32term.c (x_draw_composite_glyph_string_foreground):
3803 * term.c (encode_terminal_code):
3804 * composite.c (composition_update_it, get_composition_id):
3805 * xdisp.c (get_next_display_element)
3806 (fill_composite_glyph_string): Add comments about special meaning
3807 of TAB characters in a composition.
3808
a02719a3
PE
38092011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3810
3811 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
3812 This occurs when processing a multibyte format.
3813 Problem reported by Wolfgang Jenker.
a02719a3 3814
72589a3c
JB
38152011-09-15 Johan Bockgård <bojohan@gnu.org>
3816
3817 * xdisp.c (try_cursor_movement): Only check for exact match if
3818 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3819
1c14176c
PE
38202011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3821
3822 Remove unused external symbols.
3823 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3824 * xdisp.c (calc_pixel_width_or_height): Now static.
3825 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3826 * indent.c (check_display_width):
3827 * w32term.c: Fix comment to match code.
3828 * xterm.c, xterm.h (x_catching_errors): Remove.
3829
d2eea5b5
PE
38302011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 * xselect.c: Use signed conversions more consistently (Bug#9498).
3833 (selection_data_to_lisp_data): Assume incoming selection data are
3834 signed integers, not unsigned. This is to be consistent with
3835 outgoing selection data, which was modified to use signed integers
3836 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3837 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3838 expects long, not unsigned long.
3839
46888499
EZ
38402011-09-14 Eli Zaretskii <eliz@gnu.org>
3841
3842 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3843 computation of loop end. Reported by Johan Bockgård
3844 <bojohan@gnu.org>.
3845
ef8ef9fb
CY
38462011-09-13 Chong Yidong <cyd@stupidchicken.com>
3847
3848 * frame.c (Fother_visible_frames_p): Function deleted.
3849
fa819fed
EZ
38502011-09-12 Eli Zaretskii <eliz@gnu.org>
3851
3852 * indent.c (compute_motion): Process display vector front to back
3853 rather than the other way around. (Bug#2496)
3854
2ba8e008
SM
38552011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3856
3857 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3858
20f53c69
CY
38592011-09-11 Chong Yidong <cyd@stupidchicken.com>
3860
3861 * minibuf.c (Fread_from_minibuffer): Doc fix.
3862
d562d7a4
EZ
38632011-09-11 Eli Zaretskii <eliz@gnu.org>
3864
3865 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3866 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3867
1c4d7f3d
LMI
38682011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3869
3870 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3871 value for non-existent files.
3872
b885bf36
EZ
38732011-09-11 Eli Zaretskii <eliz@gnu.org>
3874
3875 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3876 set its "size" to -1. This will set the modtime_size field of
3877 the corresponding buffer to -1, which is what
3878 verify-visited-file-modtime expects for files that do not exist.
3879 (Bug#9139)
3880
6612f0bf
PE
38812011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3882
3883 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3884 here ...
3885 * lisp.h: ... from here. push_key_description is no longer
3886 defined in keyboard.c, so its declaration should not be in
3887 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3888 logically belongs with push_key_description.
3889
dfb3f755
PE
38902011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3891
3892 * buffer.h: Include <sys/types.h> instead of <time.h>.
3893 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3894 Problem reported by Herbert J. Skuhra.
3895
3134906c
LMI
38962011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3897
3898 * xml.c (parse_region): Make the parsing work for
3899 non-comment-starting XML files again (bug#9144).
3900
8d903f4e
AS
39012011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3902
3903 * image.c (gif_load): Fix calculation of bottom and right corner.
3904 (Bug#9468)
3905
80ad64f4
EZ
39062011-09-10 Eli Zaretskii <eliz@gnu.org>
3907
3908 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3909 redisplay in small windows.
3910
208a048d
EZ
39112011-09-09 Eli Zaretskii <eliz@gnu.org>
3912
3913 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3914
9b1c252e
MR
39152011-09-08 Martin Rudalics <rudalics@gmx.at>
3916
3917 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3918 Operate on live windows only.
3919
2949f33b
JB
39202011-09-08 Juanma Barranquero <lekktu@gmail.com>
3921
3922 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3923
e08dcafd
EZ
39242011-09-07 Eli Zaretskii <eliz@gnu.org>
3925
3926 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3927 only under bidi iteration.
3928
115b96bd
JD
39292011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3930
3931 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3932
c8199d0f
PE
39332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3934
3935 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3936 Without this fix, the command to link temacs failed due to an
3937 undefined symbol __builtin_isnan. This is because
3938 /usr/include/iso/math_c99.h #defines isnan(x) to
3939 __builtin_isnan(x), but the bundled gcc, which identifies itself
3940 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3941 a __builtin_isnan.
3942 * floatfns.c (isnan): #undef, and then #define to a clone of
3943 what's in data.c.
3944 (Fisnan): Always define, since it's always available now.
3945 (syms_of_floatfns): Always define isnan at the Lisp level.
3946
e39b275c 39472011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
3948
3949 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3950
b2db44d9 39512011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 3952
f4af5137 3953 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
3954 The previous code assumed that file offsets (off_t values) fit in
3955 EMACS_INT variables, which is not true on typical 32-bit hosts.
3956 The code messed up by falsely reporting buffer overflow in cases
3957 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3958 when "big" contains more than 2**29 bytes, even though this
3959 inserts just one byte and does not overflow the buffer.
3960 (Finsert_file_contents): Store file offsets as off_t
3961 values, not as EMACS_INT values. Check for overflow when
3962 converting between EMACS_INT and off_t. When checking for
3963 buffer overflow or for overlap, take the offsets into account.
3964 Don't use EMACS_INT for small values where int suffices.
3965 When checking for overlap, fix a typo: ZV was used where
3966 ZV_BYTE was intended.
3967 (Fwrite_region): Don't assume off_t fits into 'long'.
3968 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3969
ecfc0a49
MA
39702011-09-05 Michael Albinus <michael.albinus@gmx.de>
3971
3972 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3973
6511acf2 39742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 3975
0999621a 3976 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
3977
3978 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 3979 (esprintf, exprintf, evxprintf): New functions.
62f19c19 3980 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 3981 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
3982 (modify_event_symbol): Do not assume that the length of
3983 name_alist_or_stem is safe to alloca and fits in int.
3984 (Fexecute_extended_command): Likewise for function name and binding.
3985 (Frecursion_depth): Wrap around reliably on integer overflow.
3986 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3987 since some callers pass EMACS_INT values.
3988 (Fsingle_key_description): Don't crash if symbol name contains more
3989 than MAX_ALLOCA bytes.
3990 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3991 (get_minibuffer): Arg is now EMACS_INT, not int.
3992 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 3993 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
3994 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3995
2be7d702
PE
3996 * dbusbind.c (signature_cat): New function.
3997 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
3998 Do not overrun buffer; instead, report string overflow.
3999
9d1df220
PE
4000 * dispnew.c (add_window_display_history): Don't overrun buffer.
4001 Truncate instead; this is OK since it's just a log.
4002
33ef5c64
PE
4003 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4004 even if the time zone offset is outlandishly large.
4005 Don't mishandle offset == INT_MIN.
4006
66c6fdd5
PE
4007 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4008 when creating daemon; the previous buffer-overflow check was incorrect.
4009
d749b01b
PE
4010 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4011 which has the guts of the old verror function.
4012
b5cd1905
PE
4013 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4014 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4015
6e1a67fb
PE
4016 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4017 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4018 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4019 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4020 length of string rather than counting it via multiple sprintfs;
4021 that's simpler and more reliable.
c21721cc
PE
4022 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4023 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4024 sprintf, in case result does not fit in int.
4025
c57b67fc
PE
4026 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4027 (fontset_from_font): Print it.
4028
8a401434
PE
4029 * frame.c (tty_frame_count): Now printmax_t, not int.
4030 (make_terminal_frame, set_term_frame_name): Print it.
4031 (x_report_frame_params): In X, window IDs are unsigned long,
4032 not signed long, so print them as unsigned.
4033 (validate_x_resource_name): Check for implausibly long names,
4034 and don't assume name length fits in 'int'.
4035 (x_get_resource_string): Don't blindly alloca invocation name;
4036 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4037 not fit in int.
4038
6e1a67fb
PE
4039 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4040 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4041 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4042
0df02bf3
PE
4043 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4044 Use esprintf, not sprintf, in case result does not fit in int.
4045
48e30793
PE
4046 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4047 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4048 it as a large positive number.
4049 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4050 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4051
a66ff6d8
PE
4052 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4053 in case result does not fit in int.
4054
aca216ff
PE
4055 * print.c (float_to_string): Detect width overflow more reliably.
4056 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4057 buffer overrun. Don't assume list length fits in 'int'. Treat
4058 print length of 0 as 0, not as infinity; to be consistent with other
4059 uses of print length in this function. Don't overflow print length
4060 index. Don't assume hash table size fits in 'long', or that
4061 vectorlike size fits in 'unsigned long'.
4062
31c286f7
PE
4063 * process.c (make_process): Use printmax_t, not int, to format
4064 process-name gensyms.
4065
55e5faa1
PE
4066 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4067
80f2e268
PE
4068 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4069 to avoid potential buffer overrun.
4070
670741ab
PE
4071 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4072 if X resource line is longer than 512 bytes.
4073
b7163a50
PE
4074 * xfns.c (x_window): Make sprintf buffer a bit bigger
4075 to avoid potential buffer overrun.
4076
ae58ff1f
PE
4077 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4078
c43c8a6a
PE
4079 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4080
3f8236f4
PE
40812011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4082
53e9fe90 4083 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4084 Without these, Emacs silently mishandles large integers sometimes.
4085 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4086 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4087
6511acf2
PE
4088 * xdisp.c (try_window_id): Check Emacs fixnum range before
4089 converting to 'int'.
806add1d 4090
6511acf2 4091 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4092 Check that an Emacs fixnum is in range before assigning it to 'int'.
4093 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4094 values converted from Emacs fixnums.
4095 (Frecenter): Don't wrap around a line count if it is out of 'int'
4096 range; instead, treat it as an extreme value.
4097 (Fset_window_configuration, compare_window_configurations):
4098 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4099
6511acf2
PE
4100 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4101 that can exceed INT_MAX. Check that EMACS_INT value is in range
4102 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4103 (match_limit): Don't assume that a fixnum can fit in 'int'.
4104
6511acf2 4105 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4106 exceed INT_MAX.
4107
6511acf2 4108 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4109 (Fvertical_motion): Don't wrap around LINES values that don't fit
4110 in 'int'. Instead, treat them as extreme values. This is good
4111 enough for windows, which can't have more than INT_MAX lines anyway.
4112
fcb901a7
LMI
41132011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4114
0f2f6b6d
LMI
4115 * Require libxml/parser.h to avoid compilation warning.
4116
fcb901a7
LMI
4117 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4118
4119 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4120 since this reportedly can destroy thread storage.
4121
6e20a0d4
CY
41222011-08-30 Chong Yidong <cyd@stupidchicken.com>
4123
4124 * syntax.c (find_defun_start): Update all cache variables if
4125 exiting early (Bug#9401).
4126
148ae00e
EZ
41272011-08-30 Eli Zaretskii <eliz@gnu.org>
4128
f6cfbd8f
EZ
4129 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4130
148ae00e
EZ
4131 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4132 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4133 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4134
4135 * term.c (tty_append_glyph): New function.
4136 (produce_stretch_glyph): Static function and its prototype deleted.
4137
a66cfb1c
SM
4138 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4139 Add prototypes.
148ae00e 4140
c4a07a4c
PE
41412011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4142
4143 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4144 when checking :margin (Bug#9390).
4145 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4146 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4147 so that the name doesn't mislead. All uses changed.
4148
6bc8cd65
JB
41492011-08-28 Johan Bockgård <bojohan@gnu.org>
4150
4151 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4152 set_tty_hooks.
4153
dca4927e
EZ
41542011-08-27 Eli Zaretskii <eliz@gnu.org>
4155
4156 * xdisp.c (move_it_to): Don't bail out early when reaching
4157 position beyond to_charpos, if we are scanning backwards.
4158 (move_it_vertically_backward): When DY == 0, make sure we get to
4159 the first character in the line after the newline.
4160
f2cad773
PE
41612011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4162
4163 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4164 (ccl_driver): Do not generate an out-of-range pointer.
4165 (Fccl_execute_on_string): Remove unnecessary check for
4166 integer overflow, noted by Stefan Monnier in
4167 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4168 Remove a FIXME that didn't need fixing.
4169 Simplify the newly-introduced buffer reallocation code.
4170
0cae2cdb
JB
41712011-08-27 Juanma Barranquero <lekktu@gmail.com>
4172
4173 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4174
5fc295a4 41752011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4176
70c60eb2 4177 Integer and memory overflow issues (Bug#9196).
726e0ab1 4178
d31850da
PE
4179 * doc.c (get_doc_string): Rework so that
4180 get_doc_string_buffer_size is the actual buffer size, rather than
4181 being 1 less than the actual buffer size; this makes xpalloc more
4182 convenient.
4183
a69fbedb
PE
4184 * image.c (x_allocate_bitmap_record, cache_image):
4185 * xselect.c (Fx_register_dnd_atom):
4186 Simplify previous changes by using xpalloc.
4187
fe5c5d37
PE
4188 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4189 since either will do and ptrdiff_t is convenient with xpalloc.
4190
0065d054
PE
4191 * charset.c (charset_table_size)
4192 (struct charset_sort_data.priority): Now ptrdiff_t.
4193 (charset_compare): Don't overflow if priorities differ greatly.
4194 (Fsort_charsets): Don't assume list length fits in int.
4195 Check for size-calculation overflow when allocating sort data.
4196 (syms_of_charset): Allocate an initial charset table that is
4197 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4198
4199 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4200
4201 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4202 The actual value is always <= INT_MAX, and leaving it unsigned made
4203 overflow checking harder.
4204
4205 * dispextern.h (struct glyph_matrix.rows_allocated)
4206 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4207 with xpalloc. The values are still always <= INT_MAX.
4208
4209 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4210
4211 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4212 (SAFE_NALLOCA): New macro.
4213
4214 * region-cache.c (struct boundary.pos, find_cache_boundary)
4215 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4216 (set_cache_region, invalidate_region_cache)
4217 (revalidate_region_cache, know_region_cache, region_cache_forward)
4218 (region_cache_backward, pp_cache):
4219 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4220 so that ptrdiff_t * can be passed to xpalloc.
4221 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4222 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4223 (pp_cache): Don't assume cache_len fits in int.
4224 * region-cache.h: Adjust extern decls to match.
4225
4226 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4227 EMACS_INT, since either will do, for xpalloc.
4228
4229 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4230 (xnmalloc, xnrealloc, xpalloc): New functions.
4231
726e0ab1
PE
4232 * bidi.c (bidi_shelve_header_size): New constant.
4233 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4234 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4235
51f30bc5 4236 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4237 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4238 (overlay_strings):
4239 Don't update size of array until after memory allocation succeeds,
4240 because xmalloc/xrealloc may not return.
0065d054
PE
4241 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4242 now that we have proper integer overflow checking.
4243 (record_overlay_string, overlay_strings): Catch overflows when
4244 calculating size of overlay_str_buf.
726e0ab1 4245
0065d054
PE
4246 * callproc.c (Fcall_process): Check for size overflow when
4247 calculating size of args2.
4248 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4249 Normally we prefer signed values, but sticking with ptrdiff_t would
4250 require adding more-complicated checks.
726e0ab1
PE
4251
4252 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4253 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4254 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4255 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4256
4257 * character.c (Fstring): Check for size-calculation overflow.
4258
4259 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4260 unnecessary integer overflow. Check for size overflow.
4261 (encode_coding_object): Don't update size until xmalloc succeeds.
4262
4263 * composite.c (get_composition_id): Check for overflow in glyph
4264 length calculations.
4265
4266 Integer and memory overflow fixes for display code.
4267 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4268 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4269 (scrolling_window): Check for overflow in size calculations.
4270 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4271 Don't assume glyph table len fits in int.
4272 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4273 (row_table_size): Now ptrdiff_t, not int.
4274 (scrolling_window): Avoid overflow in size calculations.
4275 Don't update size until allocation succeeds.
4276 * fns.c (concat): Check for overflow in size calculations.
4277 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4278 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4279 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4280
4281 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4282 (get_doc_string): Check for size calculation overflow.
4283 Don't update size until allocation succeeds.
4284 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4285 EMACS_INT, where ptrdiff_t will do.
4286 (Fsubstitute_command_keys): Check for string overflow.
4287
4288 * editfns.c (set_time_zone_rule): Don't assume environment length
4289 fits in int.
4290 (message_length): Now ptrdiff_t, not int.
4291 (Fmessage_box): Don't update size until allocation succeeds.
4292 Don't assume message length fits in int.
4293 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4294
0065d054
PE
4295 * emacs.c (main): Do not reallocate argv, since there is a null at
4296 the end that can be overwritten, and this way there's no need to
4297 worry about size-calculation overflow.
4298 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4299
4300 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4301 alloc succeeds.
4302 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4303
4304 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4305 (x_set_scroll_bar_width, x_figure_window_size):
4306 Check for integer overflow.
4307 (x_set_alpha): Do not assume XINT fits in int.
4308
4309 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4310 This is for the members text_lines, text_cols, total_lines, total_cols,
4311 where the system imposes an 'int' limit.
4312
4313 * fringe.c (Fdefine_fringe_bitmap):
4314 Don't update size until alloc works.
4315
4316 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4317 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4318
4319 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4320 Check for size-calculation overflow.
4321 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4322 do, as we prefer signed integers.
4323 (id_to_widget.max_size, id_to_widget.used)
4324 (xg_store_widget_in_map, xg_remove_widget_from_map)
4325 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4326 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4327 Use and return ptrdiff_t, not int.
4328 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4329 * gtkutil.h: Change prototypes to match the above.
4330
4331 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4332 are duplicate now that they've been promoted to lisp.h.
4333 (x_allocate_bitmap_record, x_alloc_image_color)
4334 (make_image_cache, cache_image, xpm_load):
4335 Don't update size until alloc is done.
4336 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4337 (x_detect_edges):
3256efce 4338 Check for size calculation overflow.
726e0ab1
PE
4339 (ct_colors_allocated_max): New constant.
4340 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4341 overflow.
3256efce 4342
726e0ab1
PE
4343 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4344 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4345 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4346 Use ptrdiff_t, not int, to count maps.
4347 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4348 calculations. Don't update size until allocation succeeds.
4349 Redo calculations to avoid overflow.
726e0ab1
PE
4350 * keyboard.h: Change prototypes to match the above.
4351
4352 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4353 to count maps.
4354 (current_minor_maps): Check for size calculation overflow.
4355 * keymap.h: Change prototypes to match the above.
4356
4357 * lread.c (read1, init_obarray): Don't update size until alloc done.
4358
4359 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4360 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4361
726e0ab1
PE
4362 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4363 Now ptrdiff_t, not int.
4364 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4365 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4366
4367 * process.c (Fnetwork_interface_list): Check for overflow
4368 in size calculation.
4369
4370 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4371
4372 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4373 overflow. Don't bother calling xmalloc when xrealloc will do.
4374
4375 * search.c (Freplace_match): Check for size calculation overflow.
4376 (Fset_match_data): Don't assume list lengths fit in 'int'.
4377
4378 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4379 for command line length. Do not attempt to address one before the
4380 beginning of an array, as that's not portable.
4381
4382 * term.c (max_frame_lines): Remove; unused.
4383 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4384 not int.
4385 (encode_terminal_code, calculate_costs): Check for size
4386 calculation overflow.
4387 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4388 table lengths and related sizes. Don't update size until alloc
4389 done. Redo calculations to avoid overflow.
4390 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4391
4392 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4393 subtracting pointers.
4394 (gobble_line): Check for overflow more carefully. Don't update size
4395 until alloc done.
4396
4397 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4398 Don't update size until alloc done.
4399 Redo size calculations to avoid overflow.
4400 Check for size calculation overflow.
0065d054 4401 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4402
4403 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4404 Use ptrdiff_t, not int, for sizes.
4405 (store_mode_line_noprop_char): Don't update size until alloc done.
4406
0065d054
PE
4407 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4408 Use ptrdiff_t, not int, for sizes.
4409 (Finternal_make_lisp_face, cache_face):
4410 Check for size calculation overflow.
4411 (cache_face): Treat size calculation overflows as if they were
4412 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4413
4414 * xfns.c (x_encode_text, x_set_name_internal)
4415 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4416 sizes, since they can exceed INT_MAX in size. Check for size
4417 calculation overflow.
4418
0065d054
PE
4419 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4420 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4421 Don't update size until alloc done.
4422
0065d054 4423 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4424 as sprintf is limited to int lengths.
1d526e2f 4425
252c5ee1
PE
4426 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4427 (X_LONG_MIN): New macros.
864d7ce7
PE
4428 Use them to make the following changes clearer.
4429 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4430 This change doesn't affect the value now, but it may help remind
4431 future maintainers not to raise the value too much later.
4432 (SELECTION_QUANTUM): Remove, replacing with ...
4433 (selection_quantum): ... new function, which avoids overflow.
4434 All uses changed.
4435 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4436 assumption that selection length fits in 'int'.
4437 (x_reply_selection_request, x_handle_selection_request)
4438 (x_get_window_property, receive_incremental_selection)
4439 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4440 (lisp_data_to_selection_data, clean_local_selection_data):
4441 Use ptrdiff_t, not int, to record length of selection.
4442 (x_reply_selection_request, x_get_window_property)
4443 (receive_incremental_selection, x_property_data_to_lisp):
4444 Redo calculations to avoid overflow.
4445 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4446 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4447 something.
4448 (x_get_window_property, receive_incremental_selection)
4449 (lisp_data_to_selection_data, x_property_data_to_lisp):
4450 Check for size-calculation overflow.
4451 (x_get_window_property, receive_incremental_selection)
4452 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4453 Don't store size until memory allocation succeeds.
4454 (x_get_window_property): Plug memory leak on memory exhaustion.
4455 Don't double-block input; malloc is safe here. Don't assume 2**34
4456 - 4 fits in unsigned long. Add an xassert to check
4457 XGetWindowProperty overflow. Be more careful about overflow
4458 calculations, and distinguish size from memory overflow better.
4459 (receive_incremental_selection): When tracing, don't assume
4460 unsigned int is less than INT_MAX.
4461 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4462 harmful) conversions of unsigned short to int.
4463 (lisp_data_to_selection_data): Don't assume that integers
4464 in the range -65535 through -1 fit in an X unsigned short.
4465 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4466 result parameters unless successful. Rely on cons_to_unsigned
4467 to report problems with elements; the old code wasn't right anyway.
4468 (x_check_property_data): Check for int overflow; we cannot use
4469 a wider type due to X limits.
4470 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4471
726e0ab1 4472 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4473
0065d054
PE
4474 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4475 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4476 (x_color_cells): Don't store size until memory allocation succeeds.
4477 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4478 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4479 (x_term_init): Don't assume length fits in int (sprintf is limited
4480 to int size).
bc18e09d 4481
ebfa62c0
PE
4482 Use ptrdiff_t for composition IDs.
4483 * character.c (lisp_string_width):
4484 * composite.c (composition_table_size, n_compositions)
4485 (get_composition_id, composition_gstring_from_id):
4486 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4487 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4488 * window.c (Frecenter):
4489 Use ptrdiff_t, not int, for composition IDs.
4490 * composite.c (get_composition_id): Check for integer overflow.
4491 * composite.h: Adjust prototypes to match the above changes.
4492
d3411f89
PE
4493 Use ptrdiff_t for hash table indexes.
4494 * category.c (hash_get_category_set):
4495 * ccl.c (ccl_driver):
4496 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4497 * coding.c (coding_system_charset_list, detect_coding_system):
4498 * coding.h (struct coding_system.id):
4499 * composite.c (get_composition_id, gstring_lookup_cache):
4500 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4501 * image.c (xpm_get_color_table_h):
4502 * lisp.h (hash_lookup, hash_put):
4503 * minibuf.c (Ftest_completion):
4504 Use ptrdiff_t for hash table indexes, not int (which is too
4505 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4506 32-bit --with-wide-int hosts).
4507
e097a6fa
PE
4508 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4509 Add a FIXME comment about memory leaks.
4510 (syms_of_charset): Don't assume xmalloc returns.
4511
5637687f
PE
4512 Don't assume that stated character widths fit in int.
4513 * character.c (Fchar_width, c_string_width, lisp_string_width):
4514 * character.h (CHAR_WIDTH):
4515 * indent.c (MULTIBYTE_BYTES_WIDTH):
4516 Use sanitize_char_width to avoid undefined and/or bad behavior
4517 with outlandish widths.
a66cfb1c 4518 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4519 now that we have two such functions. All uses changed.
4520 (sanitize_char_width): New inline function.
4521
a2271ba2
PE
4522 Don't assume that tab-width fits in int.
4523 * character.h (sanitize_width): New inline function.
4524 (SANE_TAB_WIDTH): New macro.
4525 (ASCII_CHAR_WIDTH): Use it.
4526 * indent.c (sane_tab_width): Remove. All uses replaced by
4527 SANE_TAB_WIDTH (current_buffer).
4528 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4529
18c52557
PE
4530 * fileio.c: Integer overflow issues with file modes.
4531 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4532
caeeedc1
PE
4533 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4534 Remove unreachable code.
4535 (read_hex, load_charset_map_from_file): Check for integer overflow.
4536
6df6ae42 4537 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4538 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4539 (x_send_scroll_bar_event): Likewise. Check that the size does not
4540 exceed limits imposed by XClientMessageEvent, as well as the usual
4541 ptrdiff_t and size_t limits.
4542
b13995db
PE
4543 * keyboard.c: Overflow, signedness and related fixes.
4544 (make_lispy_movement): Use same integer type in forward decl
4545 that is used in the definition.
4546 (read_key_sequence, keyremap_step):
4547 Change bufsize argument back to int, undoing my 2011-03-30 change.
4548 We prefer signed types, and int is wide enough here.
4549 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4550 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4551 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4552 length, not size_t. Use ptrdiff_t for index, not int.
4553 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4554 possibility of integer overflow.
4555
13464394
PE
4556 Overflow, signedness and related fixes for images.
4557
4558 * dispextern.h (struct it.stack[0].u.image.image_id)
4559 (struct_it.image_id, struct image.id, struct image_cache.size)
4560 (struct image_cache.used, struct image_cache.ref_count):
4561 * gtkutil.c (update_frame_tool_bar):
4562 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4563 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4564 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4565 * nsmenu.m (update_frame_tool_bar):
4566 * xdisp.c (calc_pixel_width_or_height):
4567 * xfns.c (image_cache_refcount):
4568 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4569 on typical 64-bit hosts.
4570
4571 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4572 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4573 Omit unnecessary casts to int.
4574 (parse_image_spec): Check that integers fall into 'int' range
4575 when the callers expect that.
4576 (image_ascent): Redo ascent calculation to avoid int overflow.
4577 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4578 (lookup_image): Remove unnecessary tests.
4579 (xbm_image_p): Locals are now of int, not EMACS_INT,
4580 since parse_image_check makes sure they fit into int.
4581 (png_load, gif_load, svg_load_image):
4582 Prefer int to unsigned where either will do.
4583 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4584 old tiff_error_handler and tiff_warning_handler.
4585 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4586 stack buffer overflows. It uses only the features of vsnprintf
4587 that are common to both POSIX and native Microsoft.
4588 (tiff_error_handler, tiff_warning_handler): Use it.
4589 (tiff_load, gif_load, imagemagick_load_image):
4590 Don't assume :index value fits in 'int'.
4591 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4592 (imagemagick_load_image): Check that crop parameters fit into
4593 the integer types that MagickCropImage accepts. Don't assume
4594 Vimagemagick_render_type has a nonnegative value. Don't assume
4595 size_t fits in 'long'.
4596 (gs_load): Use printmax_t to print the widest integers possible.
4597 Check for integer overflow when computing image height and width.
4598
c11821d4
EZ
45992011-08-26 Eli Zaretskii <eliz@gnu.org>
4600
4601 * xdisp.c (redisplay_window): Don't force window start if point
4602 will be invisible in the resulting window. (Bug#9324)
4603
0c95fcf7
EZ
46042011-08-25 Eli Zaretskii <eliz@gnu.org>
4605
4606 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4607 the display spec is of the form `(space ...)'.
4608 (handle_display_spec): Return the value returned by
4609 handle_single_display_spec, not just 1 or zero.
4610 (handle_single_display_spec): If the display spec is of the form
4611 `(space ...)', and specifies display in the text area, return 2
4612 rather than 1.
fee65a97 4613 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4614 accurately, and prefer exact match for point under bidi.
4615 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4616
4617 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4618 into disp_prop; all users changed.
4619
4620 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4621 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4622 for the text covered by the display property.
4623
e4ed06f1
CY
46242011-08-25 Chong Yidong <cyd@stupidchicken.com>
4625
4626 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4627 Change return value to nil.
4628 (Frecord_buffer): Delete unused function.
4629
f67cdd7f
EZ
46302011-08-24 Eli Zaretskii <eliz@gnu.org>
4631
5980d4c6
EZ
4632 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4633 buffers, return left-to-right.
8610fe8b
EZ
4634 (set_cursor_from_row): Consider candidate row a win if its glyph
4635 represents a newline and point is on that newline. Fixes cursor
4636 positioning on the newline at EOL of R2L text within L2R
4637 paragraph, and vice versa.
4638 (try_cursor_movement): Check continued rows, in addition to
4639 continuation rows. Fixes unwarranted scroll when point enters a
4640 continued line of R2L text within an L2R paragraph, or vice versa.
4641 (cursor_row_p): Consider the case of point being equal to
4642 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4643 from the end of a short line to the beginning of a continued line
4644 of R2L text within L2R paragraph.
4645 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4646 composed characters.
5980d4c6 4647
f67cdd7f
EZ
4648 * bidi.c (bidi_check_type): Use xassert.
4649 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4650 members.
4651
bca633fb
EZ
46522011-08-23 Eli Zaretskii <eliz@gnu.org>
4653
4654 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4655 a character.
4656
4a5885a7
CY
46572011-08-23 Chong Yidong <cyd@stupidchicken.com>
4658
4659 * nsfont.m (ns_otf_to_script): Fix typo.
4660
0902a04e
KH
46612011-08-22 Kenichi Handa <handa@m17n.org>
4662
4663 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4664 extra slot even if the purpose is char-code-property-table.
4665
1a2e6670
EZ
46662011-08-23 Eli Zaretskii <eliz@gnu.org>
4667
8ddde651
EZ
4668 * xdisp.c (redisplay_window): When computing centering_position,
4669 account for the height of the header line. (Bug#8874)
4670
425cc014
EZ
4671 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4672 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4673 candidate is selected by the mouse, and that candidate has a
4674 composed character under the mouse.
4675
1a2e6670
EZ
4676 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4677 coordinates reported by pos-visible-in-window-p for a composed
4678 character in column zero.
4679
8b76d6f8
SM
46802011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4681
4682 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4683
dac347dd
EZ
46842011-08-22 Eli Zaretskii <eliz@gnu.org>
4685
4686 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4687 consider it a hit if to_charpos is anywhere in the range of the
4688 composed buffer positions.
4689
e013fb34
CY
46902011-08-22 Chong Yidong <cyd@stupidchicken.com>
4691
4692 * image.c (gif_load): Don't assume that each subimage has the same
4693 dimensions as the base image. Handle disposal method that is
4694 "undefined" by the gif spec (Bug#9335).
4695
bd1ba3e8
CY
46962011-08-20 Chong Yidong <cyd@stupidchicken.com>
4697
4698 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4699 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4700
54a1215b
EZ
47012011-08-19 Eli Zaretskii <eliz@gnu.org>
4702
823564e5
EZ
4703 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4704 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4705 from an Org mode buffer to a Speedbar frame.
4706
54a1215b
EZ
4707 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4708 a composition, take its buffer position from IT->cmp_it.charpos.
4709 Fixes cursor positioning at the beginning of a line that begins
4710 with a composed character.
4711
9778ebcc
EZ
47122011-08-18 Eli Zaretskii <eliz@gnu.org>
4713
0be6ee06
EZ
4714 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4715 character bidirectional type, use STRONG_L instead. Fixes crashes
4716 in a buffer produced by `describe-categories'.
4717
9778ebcc
EZ
4718 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4719 members before the level stack, so they would be saved and
4720 restored when copying iterator state. Fixes incorrect reordering
4721 around TABs covered by display properties.
4722
156bffbe
AS
47232011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4724
6b02f655 4725 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 4726
72ad093b
CY
47272011-08-17 Chong Yidong <cyd@stupidchicken.com>
4728
4729 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
4730 (internal_condition_case_2, internal_condition_case_n):
4731 Remove unnecessary aborts (Bug#9081).
72ad093b 4732
35774242
EZ
47332011-08-17 Eli Zaretskii <eliz@gnu.org>
4734
4735 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4736 has no `load' handler, try opening the file locally. (Bug#9311)
4737
db76dd85
KB
47382011-08-16 Ken Brown <kbrown@cornell.edu>
4739
4740 * gmalloc.c: Expand comment.
4741
b215eee5
EZ
47422011-08-16 Eli Zaretskii <eliz@gnu.org>
4743
4744 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4745 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4746
a4579d33
KB
47472011-08-16 Ken Brown <kbrown@cornell.edu>
4748
4749 Fix memory allocation problems in Cygwin build (Bug#9273).
4750
4751 * unexcw.c ( __malloc_initialized): Declare external variable.
4752 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4753
8b76d6f8
SM
4754 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4755 New variables.
a4579d33
KB
4756 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4757 dumped emacs.
4758 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4759 in the static heap.
4760 [CYGWIN] (special_realloc): New function.
4761 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4762 requests to realloc storage in the static heap.
4763
3ebec551
PE
47642011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4765
4766 * bidi.c (bidi_initialize): Remove unused local.
4767
9fd8be00
EZ
47682011-08-15 Eli Zaretskii <eliz@gnu.org>
4769
6b02f655
SM
4770 * bidimirror.h:
4771 * biditype.h: Remove file.
4772 * makefile.w32-in ($(BLD)/bidi.$(O)):
4773 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
4774
4775 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4776
4777 * chartab.c: Improve commentary for the uniprop_table API.
4778
32413314
EZ
4779 * bidi.c (bidi_paragraph_init): Support zero value of
4780 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
4781 (bidi_initialize): Use uniprop_table instead of including
4782 biditype.h and bidimirror.h.
32413314 4783
9fd8be00
EZ
4784 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4785 coordinates of the iterator when restoring from ppos_it.
4786 (Bug#9296)
4787
5cf2b69b
KH
47882011-08-14 Kenichi Handa <handa@m17n.org>
4789
4790 * process.c (create_process): Call setup_process_coding_systems
72ad093b 4791 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 4792
daf17d00
EZ
47932011-08-14 Eli Zaretskii <eliz@gnu.org>
4794
4795 * xdisp.c (move_it_in_display_line_to): Don't invoke
4796 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4797 ppos_it. Fixes vertical cursor motion when line beginning is
4798 covered by an image. (Bug#9296)
4799
08e3161a
JD
48002011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4801
4802 * nsterm.h (ns_run_ascript): Declare.
4803 (NSAPP_DATA2_RUNASSCRIPT): Define.
4804
4805 * nsfns.m (as_script, as_result, as_status): New static variables.
4806 (ns_run_ascript): New function.
5e617bc2 4807 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
4808 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4809 the event loop. Get status from as_status (Bug#7276).
4810
4811 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4812 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4813 the event loop (Bug#7276).
4814
a3720aa2
AS
48152011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4816
4817 * gnutls.c (QCgnutls_bootprop_priority)
4818 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4819 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4820 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4821 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4822 (QCgnutls_bootprop_verify_hostname_error)
4823 (QCgnutls_bootprop_callbacks_verify): Rename from
4824 Qgnutls_bootprop_..., all uses changed.
4825
4826 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4827 uses changed.
4828
0a0d27fb
PE
48292011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4830
19d5c50c
PE
4831 * xfaces.c (Qframe_set_background_mode): Now static.
4832 * dispextern.h (Qframe_set_background_mode): Remove decl.
4833
0a0d27fb
PE
4834 * process.c (Fnetwork_interface_info): Declare local only if needed.
4835
377538cb
JD
48362011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4837
4838 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4839 (Fnetwork_interface_list): Allocate in increments of bytes instead
4840 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4841 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4842 sockaddr.
4843 (struct ifflag_def): notrailers is smart on OSX.
4844 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4845 Get hardware address with getifaddrs if available.
4846
08fff70c
EZ
48472011-08-12 Eli Zaretskii <eliz@gnu.org>
4848
4849 * xdisp.c (iterate_out_of_display_property): xassert that
4850 IT->position is set to within IT->object's boundaries. Break from
4851 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
4852 when IT->position is set up wrongly due to some bug.
4853 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
4854 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4855 entry. Force push_it to save on the stack the current
4856 buffer/string position, to be restored by pop_it. Fix flags in
4857 the iterator structure wrt the object coming from a display
4858 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4859 properties. (Bug#9284)
4860
7be1c708 48612011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 4862
7be1c708
CY
4863 * fontset.c (fontset_get_font_group): Add proper type checks.
4864 (Bug#9172)
aac0c6e3 4865
7be1c708 48662011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 4867
7be1c708
CY
4868 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4869 and LC_VERSION_MIN_MACOSX.
4870 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4871 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 4872
97bb72a6
EZ
48732011-08-08 Eli Zaretskii <eliz@gnu.org>
4874
4875 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
4876 no-display-properties-and-no-overlays under bidi display.
4877 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 4878 properties and overlays.
97bb72a6 4879
d5617611
CY
48802011-08-08 Chong Yidong <cyd@stupidchicken.com>
4881
37e11a63
CY
4882 * editfns.c (Fset_time_zone_rule): Document relationship with the
4883 setenv function.
4884
d5617611
CY
4885 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4886 the font entity extracted from the cache (Bug#8109).
4887
58872834
CY
48882011-08-07 Chong Yidong <cyd@stupidchicken.com>
4889
4890 * composite.c (autocmp_chars): Don't reset point. That is done by
4891 restore_point_unwind (Bug#5984).
4892
75bfc667
JL
48932011-08-07 Juri Linkov <juri@jurta.org>
4894
4895 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4896 to show the arg `TIME' instead of `TIMEVAL'.
4897
d1410150
EZ
48982011-08-06 Eli Zaretskii <eliz@gnu.org>
4899
4900 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4901 display property strides EOL and includes a newline, as in
4902 longlines-mode. (Bug#9254)
75b771e4
EZ
4903 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4904 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
4905
4906 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4907 is non-zero, even if the data buffer is NULL. Fixes a crash in
4908 vertical-motion with longlines-mode. (Bug#9254)
4909
35928349
EZ
49102011-08-05 Eli Zaretskii <eliz@gnu.org>
4911
ec7cc85b
EZ
4912 * bidi.c <bidi_cache_total_alloc>: Now static.
4913 (bidi_initialize): Initialize bidi_cache_total_alloc.
4914
8b76d6f8 4915 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
4916 cache. (Bug#9221)
4917
4918 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4919 amount allocated this far in `bidi_cache_total_alloc'.
4920 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4921 non-zero, only free the data buffer without restoring the cache
4922 contents. All callers changed.
4923
4924 * dispextern.h (bidi_unshelve_cache): Update prototype.
4925
4926 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4927 (move_it_in_display_line, move_it_to)
4928 (move_it_vertically_backward, move_it_by_lines): Replace the call
4929 to xfree to an equivalent call to bidi_unshelve_cache.
4930 (move_it_in_display_line_to): Fix logic of returning
412b6358 4931 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 4932
e2e2423b
EZ
49332011-08-05 Eli Zaretskii <eliz@gnu.org>
4934
4935 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4936 came from a string character with a `cursor' property. (Bug#9229)
4937
ae9e757a
JD
49382011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4939
4940 * Makefile.in (LIB_PTHREAD): New variable.
4941 (LIBES): Add LIB_PTHREAD (Bug#9216).
4942
4943 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4944 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4945
213bd7f2
AS
49462011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4947
6b02f655 4948 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 4949
99aaf75f
JD
49502011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4951
4952 * xterm.c (x_find_topmost_parent): New function.
4953 (x_set_frame_alpha): Find topmost parent window with
4954 x_find_topmost_parent and set the property there also (bug#9181).
4955 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4956
c74e9d86
PE
49572011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4958
4959 * callproc.c (Fcall_process): Avoid vfork clobbering
4960 the local vars buffer, coding_systems, current_dir.
4961
640c8776
SM
49622011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4963
4964 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4965
f26d0e4c
PE
49662011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4967
8a10d76c
PE
4968 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4969 so that it is not optimized away.
4970
f26d0e4c
PE
4971 * xdisp.c (compute_display_string_pos): Remove unused local.
4972
55439c61
EZ
49732011-08-02 Eli Zaretskii <eliz@gnu.org>
4974
4975 Fix slow cursor motion and scrolling in large buffers with
4976 selective display, like Org Mode buffers. (Bug#9218)
4977
4978 * dispextern.h (struct bidi_it): New member disp_prop_p.
4979
4980 * xdisp.c: Remove one-slot cache of display string positions.
4981 (compute_display_string_pos): Accept an additional argument
5e617bc2 4982 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
4983 for a display string or property. If found, set DISP_PROP_P
4984 non-zero.
4985
4986 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
4987 DISP_PROP_P, and pass it to compute_display_string_pos.
4988 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
4989 non-zero. All callers of bidi_fetch_char changed.
4990
fb33fa43
SM
49912011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4992
4993 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4994
b099e063
DM
49952010-12-03 Don March <don@ohspite.net>
4996
4997 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4998 last character M-[char] is translated to ESC [char] (bug#7541).
4999
5cc7f7af
KH
50002011-08-02 Kenichi Handa <handa@m17n.org>
5001
d0fffa3f 5002 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5003
5004 * chartab.c (uniprop_table): Make it non-static.
5005
525d5e6e
EZ
50062011-08-01 Eli Zaretskii <eliz@gnu.org>
5007
5008 * xdisp.c (forward_to_next_line_start): Accept additional argument
5009 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5010 on the newline.
5011 (reseat_at_next_visible_line_start): Use the bidi iterator state
5012 returned by forward_to_next_line_start to restore the state of
5013 it->bidi_it after backing up to previous newline. (Bug#9212)
5014
31011111
AS
50152011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5016
5017 * regex.c (re_comp): Protoize.
5018 (re_exec): Fix return type.
5019 (regexec): Fix type of `ret'. (Bug#9203)
5020
476371c4
PE
50212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5022
e5d76069
PE
5023 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5024 This is needed if max-image-size is a floating-point number.
5025
9a79b20c
AS
50262011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5027
5028 * print.c (print_object): Print empty symbol as ##.
5029
5030 * lread.c (read1): Read ## as empty symbol.
5031
d8c2fa78
AA
50322011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5033
5034 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5035 setting frame foreground color (Bug#9175).
5036 (x_set_background_color): Likewise.
5037
ffe57a7a
AA
5038 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5039 contents (Bug#9176).
5040 (EmacsTooltip -init): Remove bezels and add shadows to
5041 tooltip windows.
5042
bf3492a5
AA
5043 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5044 or scroll bar (Bug#8470).
5045
d55e9c53
AA
5046 * nsfont.m (nsfont_open): Remove assignment to voffset and
5047 unnecessary vars hshink, expand, hd, full_height, min_height.
5048 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5049
5050 * nsterm.h (nsfont_info): Remove voffset field.
5051
d8c2fa78 50522011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5053
5054 Implement strike-through and overline on NextStep (Bug#8863).
5055
5056 * nsfont.m (nsfont_open): Use underline position provided by font,
5057 instead of hard-coded value of 2.
5058 (nsfont_draw): Call ns_draw_text_decoration instead.
5059
5060 * nsterm.h: Add declaration for ns_draw_text_decoration.
5061
5062 * nsterm.m (ns_draw_text_decoration): New function for drawing
5063 underline, overline, and strike-through.
5064 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5065 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5066 accommodate underlining, etc.
4843aac3 5067
4cc60b9b
EZ
50682011-07-28 Eli Zaretskii <eliz@gnu.org>
5069
bc7ece87
EZ
5070 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5071 default.
4cc60b9b 5072
476371c4
PE
50732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5074
66606eea
PE
5075 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5076 Without this fix, if a signal arrives just after memory fills up,
5077 'malloc' might be invoked reentrantly.
5078
476371c4
PE
5079 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5080 In other words, assume that every image size is allowed, on non-X
5081 hosts. This assumption is probably wrong, but it lets Emacs compile.
5082
f3fcc40d
AS
50832011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5084
5085 * regex.c (re_iswctype): Convert return values to boolean.
5086
350c992f
EZ
50872011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5088
5089 * xdisp.c (compute_display_string_pos): Don't use cached display
5090 string position if the buffer had its restriction changed.
5091 (Bug#9184)
5092
5266b4bb
PE
50932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5094
5095 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5096
2573a837 50972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5098
41f55ccd 5099 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5100
39e378da
PE
5101 * bidi.c: Integer size and overflow fixes.
5102 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5103 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5104 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5105 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5106 (bidi_find_other_level_edge):
5107 Use ptrdiff_t instead of EMACS_INT where either will do.
5108 This works better on 32-bit hosts configured --with-wide-int.
5109 (bidi_cache_ensure_space): Check for size-calculation overflow.
5110 Use % rather than repeated addition, for better worst-case speed.
5111 Don't set bidi_cache_size until after xrealloc returns, because it
5112 might not return.
5113 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5114 (bidi_cache_ensure_space): Also check that the bidi cache size
5115 does not exceed that of the largest Lisp string or buffer. See Eli
5116 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5117
5e927815
PE
5118 * alloc.c (__malloc_size_t): Remove.
5119 All uses replaced by size_t. See Andreas Schwab's note
5120 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5121
ca4aa935
PE
5122 * image.c: Improve checking for integer overflow.
5123 (check_image_size): Assume that f is nonnull, since
5124 it is always nonnull in practice. This is one less thing to
5125 worry about when checking for integer overflow later.
5126 (x_check_image_size): New function, which checks for integer
5127 overflow issues inside X.
5128 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5129 This removes the need for a memory_full check.
5130 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5131 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5132 (xbm_read_bitmap_data): Change locals back to 'int', since
5133 their values must fit in 'int'.
5134 (xpm_load_image, png_load, tiff_load):
5135 Invoke x_create_x_image_and_pixmap earlier,
5136 to avoid much needless work if the image is too large.
5137 (tiff_load): Treat overly large images as if
5138 x_create_x_image_and_pixmap failed, not as malloc failures.
5139 (gs_load): Use x_check_image_size.
5140
5f8f9cc2
PE
5141 * gtkutil.c: Omit integer casts.
5142 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5143 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5144
5adf60bc
PE
5145 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5146
c8907a93
PE
5147 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5148 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5149 would wrongly return t on a 64-bit host.
5150
e3c25c68
PE
5151 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5152 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5153 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5154 and therefore cause GCC to emit a bogus diagnostic in some cases.
5155
3f791afe
PE
5156 * image.c: Integer signedness and overflow and related fixes.
5157 This is not an exhaustive set of fixes, but it's time to
5158 record what I've got.
5159 (lookup_pixel_color, check_image_size): Remove redundant decls.
5160 (check_image_size): Don't assume that arbitrary EMACS_INT values
5161 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5162 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5163 (tiff_load, imagemagick_load_image):
5164 Check for overflow in size calculations.
5165 (x_create_x_image_and_pixmap): Remove unnecessary test for
5166 xmalloc returning NULL; that can't happen.
5167 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5168 (xpm_color_bucket): Use better integer hashing function.
5169 (xpm_cache_color): Don't possibly over-allocate memory.
5170 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5171 (gif_memory_source):
5172 Use ptrdiff_t, not int or size_t, to record sizes.
5173 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5174 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5175 either works, as we prefer signed integers.
5176 (tiff_read_from_memory, tiff_write_from_memory):
5177 Return tsize_t, not size_t, since that's what the TIFF API wants.
5178 (tiff_read_from_memory): Don't fail simply because the read would
5179 go past EOF; instead, return a short read.
5180 (tiff_load): Omit no-longer-needed casts.
5181 (Fimagemagick_types): Don't assume size fits into 'int'.
5182
3cc5a532
PE
5183 Improve hashing quality when configured --with-wide-int.
5184 * fns.c (hash_string): New function, taken from sxhash_string.
5185 Do not discard information about ASCII character case; this
5186 discarding is no longer needed.
5187 (sxhash-string): Use it. Change sig to match it. Caller changed.
5188 * lisp.h: Declare it.
5189 * lread.c (hash_string): Remove, since we now use fns.c's version.
5190 The fns.c version returns a wider integer if --with-wide-int is
5191 specified, so this should help the quality of the hashing a bit.
5192
b312a492
PE
5193 * emacs.c: Integer overflow minor fix.
5194 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5195 Define only if GNU_LINUX.
5196 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5197
dfd153ae
PE
5198 * dispnew.c: Integer signedness and overflow fixes.
5199 Remove unnecessary forward decls, that were a maintenance hassle.
5200 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5201 All uses changed.
5202 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5203 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5204 (prepare_desired_row, line_draw_cost):
5205 Use int, not unsigned, where either works.
5206 (save_current_matrix, restore_current_matrix):
5207 Use ptrdiff_t, not size_t, where either works.
5208 (init_display): Check for overflow more accurately, and without
5209 relying on undefined behavior.
5210
a81d11a3
PE
5211 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5212 Remove, replacing with the new symbols in lisp.h. All uses changed.
5213 * fileio.c (make_temp_name):
5214 * filelock.c (lock_file_1, lock_file):
5215 * xdisp.c (message_dolog):
5216 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5217 Use pMd etc. instead.
5218 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5219 replacing the pWIDE etc. symbols removed from editfns.c.
5220
3300e6fd
PE
5221 * keyboard.h (num_input_events): Now uintmax_t.
5222 This is (very slightly) less likely to mess up due to wraparound.
5223 All uses changed.
5224
fd05c7e9
PE
5225 * buffer.c: Integer signedness fixes.
5226 (alloc_buffer_text, enlarge_buffer_text):
5227 Use ptrdiff_t rather than size_t when either will do, as we prefer
5228 signed integers.
5229
903fe15d
PE
5230 * alloc.c: Integer signedness and overflow fixes.
5231 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5232 (__malloc_size_t): Default to size_t, not to int.
5233 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5234 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5235 Prefer ptrdiff_t to size_t when either would do, as we prefer
5236 signed integers.
5237 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5238 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5239 Now const. Initialize with values that are in range even if char
5240 is signed.
5241 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5242 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5243 These functions do the right thing with sizes > 2**32.
5244 (check_depth): Now ptrdiff_t, not int.
5245 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5246 Adjust to new way of storing sizes. Check for size overflow bugs
5247 in rest of code.
5248 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5249 slightly wrong anyway, as it missed one instance of
5250 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5251 (refill_memory_reserve): Omit needless cast to size_t.
5252 (mark_object_loop_halt): Mark as externally visible.
5253
ac82cc6a
PE
5254 * xselect.c: Integer signedness and overflow fixes.
5255 (Fx_register_dnd_atom, x_handle_dnd_message):
5256 Use ptrdiff_t, not size_t, since we prefer signed.
5257 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5258 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5259 x_dnd_atoms_size and x_dnd_atoms_length.
5260
c2d1e36d
PE
5261 * doprnt.c: Prefer signed to unsigned when either works.
5262 * eval.c (verror):
5263 * doprnt.c (doprnt):
5264 * lisp.h (doprnt):
5265 * xdisp.c (vmessage):
5266 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5267 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5268 prefer signed arithmetic to avoid comparison confusion.
5269 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5270 but is a bit tricky.
5271
0e926e56
PE
5272 Assume freestanding C89 headers, string.h, stdlib.h.
5273 * data.c, doprnt.c, floatfns.c, print.c:
5274 Include float.h unconditionally.
5275 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5276 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5277 * regex.c: Likewise for stddef.h, string.h.
5278 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5279 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5280 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5281 (STDC_HEADERS): Remove obsolete defines.
5282 * sysdep.c: Include limits.h unconditionally.
5283
9cfdb3ec
PE
5284 Assume support for memcmp, memcpy, memmove, memset.
5285 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5286 * regex.c (memcmp, memcpy):
5287 Remove; we assume C89 now.
5288
5289 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5290 (__malloc_safe_bcopy): Remove; no longer needed.
5291
cf950e6b 5292 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5293 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5294 well either way, and we prefer signed to unsigned.
5295
dbf38e02
LMI
52962011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5297
5298 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5299 closes the connection while we're reading (bug#9182).
5300
d6f0886c 53012011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5302
d6f0886c
JD
5303 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5304 are specified (Bug#9168).
24e0f6b1 5305
2eb1f9e6
PE
53062011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5307
5308 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5309 Found by GCC static checking and --with-wide-int on a 32-bit host.
5310
22381272 53112011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5312
5313 * xdisp.c (compute_display_string_pos): Fix logic of caching
5314 previous display string position. Initialize cached_prev_pos to
5315 -1. Fixes slow-down at the beginning of a buffer.
5316
f25e39b4
EZ
53172011-07-24 Eli Zaretskii <eliz@gnu.org>
5318
5319 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5320 for attrs[LFACE_FONTSET_INDEX].
5321
04c4b52e
PE
53222011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5323
5324 * xml.c (parse_region): Remove unused local
5325 that was recently introduced.
5326
c1734fbd
EZ
53272011-07-23 Eli Zaretskii <eliz@gnu.org>
5328
be18c5a5
EZ
5329 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5330 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5331
c1734fbd
EZ
5332 * xdisp.c (move_it_in_display_line_to): Record the best matching
5333 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5334 exit if none of the characters scanned was an exact match.
5335 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5336 when exact match is impossible due to invisible text, and the
5337 lines are truncated.
5338
a258d627
JD
53392011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5340
5341 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5342 for OSX >= 10.7.
5343
b6d5a689
EZ
53442011-07-22 Eli Zaretskii <eliz@gnu.org>
5345
0f74f785
EZ
5346 Fix a significant slow-down of cursor motion with C-n, C-p,
5347 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5348 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5349 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5350 (next_element_from_buffer): Call compute_stop_pos_backwards to
5351 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5352 base_level_stop.
5353 (reseat): Don't look for prev_stop, as that could mean a very long
5354 run.
5355 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5356 <cached_disp_overlay_modiff>: Cache for last found display string
5357 position.
551918c1 5358 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5359 about the same buffer in the same area of character positions, and
5360 the buffer wasn't changed since the time the display string
5361 position was cached.
551918c1 5362
b2d0c91a
EZ
53632011-07-22 Eli Zaretskii <eliz@gnu.org>
5364
5365 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5366 is an integer, which is important for empty lines. (Bug#9149)
5367
043604ee
CY
53682011-07-22 Chong Yidong <cyd@stupidchicken.com>
5369
5370 * frame.c (Fmodify_frame_parameters): In tty case, update the
5371 default face if necessary (Bug#4238).
5372
da4adb04
CY
53732011-07-21 Chong Yidong <cyd@stupidchicken.com>
5374
5375 * editfns.c (Fstring_to_char): No need to explain what a character
5376 is in the docstring (Bug#6576).
5377
9abd0532
LMI
53782011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5379
5380 * xml.c (parse_region): Make sure we always return a tree.
5381
36881d16
HK
53822011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5383
5384 * xml.c (parse_region): If a document contains only comments,
5385 return that, too.
5386
1e98674d
LMI
53872011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5388
5389 * xml.c (make_dom): Return comments, too.
5390
590bd467
PE
53912011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5392
5393 Port to OpenBSD.
5394 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5395 and the surrounding thread.
5396 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5397 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5398 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5399 timer goes off.
5400 * s/openbsd.h (BROKEN_SIGIO): Define.
5401 * unexelf.c (unexec) [__OpenBSD__]:
5402 Don't update the .mdebug section of the Alpha COFF symbol table.
5403
f41628b2
LMI
54042011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5405
5406 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5407 (bug#8460).
5408
b59b67c5
PE
54092011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5410
15e3a074
PE
5411 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5412 This fixes some race conditions on the permissions of any newly
5413 created file.
5414
41bed37d
PE
5415 * alloc.c (valid_pointer_p): Use pipe, not open.
5416 This fixes some permissions issues when debugging.
5417
b59b67c5
PE
5418 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5419 If fchown fails to set both uid and gid, try to set just gid,
5420 as that is sometimes allowed. Adjust the file's mode to eliminate
5421 setuid or setgid bits that are inappropriate if fchown fails.
5422
925a6be7
SM
54232011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5424
5425 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5426 to compare Lisp_Objects.
5427 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5428 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5429 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5430
52968808
AS
54312011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5432
0a6a104b
AS
5433 * lread.c (read_integer): Unread even EOF character.
5434 (read1): Likewise. Properly record start position of symbol.
5435
52968808
AS
5436 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5437 symbol character follows.
5438
9e381cdd
PE
54392011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5440
5441 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5442 This works around a problem with the previous change to Fcopy_file.
5443 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5444 and without this change, GCC might complain about discarding
5445 fchown's return value.
5446
b5641435
JB
54472011-07-16 Juanma Barranquero <lekktu@gmail.com>
5448
5449 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5450
a8031457
PE
54512011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5452
5453 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5454
dd889327
LMI
54552011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5456
750c33f7
LMI
5457 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5458 it's used from the C level.
5459
dd889327
LMI
5460 * process.c: Use the same condition for POLL_FOR_INPUT in both
5461 keyboard.c and process.c (bug#1858).
5462
87e86684
LM
54632011-07-09 Lawrence Mitchell <wence@gmx.li>
5464
5465 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5466 (Fgnutls_boot): Use it.
5467
64348f40
AS
54682011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5469
5470 * doc.c (Fsubstitute_command_keys): Revert last change.
5471
1d698799
LMI
54722011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5473
f863868c
LMI
5474 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5475 quotes the next character, and doesn't affect other longer
5476 sequences (bug#8935).
5477
1d698799
LMI
5478 * lread.c (syms_of_lread): Clarify that is isn't only
5479 `eval-buffer' and `eval-defun' that's affected by
5480 `lexical-binding' (bug#8460).
5481
aa4b6df6
EZ
54822011-07-15 Eli Zaretskii <eliz@gnu.org>
5483
5484 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5485 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5486
5d856da6
PE
54872011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5488
ad6042bb
PE
5489 Fix minor problems found by static checking.
5490 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5491 (elsz): Now a signed constant, not a size_t var. We prefer signed
5492 types to unsigned, to avoid integer comparison confusion. Without
5493 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5494 "cannot optimize loop, the loop counter may overflow", a symptom
5495 of the confusion.
f00bbb22 5496 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5497 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5498
6468f31c
LMI
54992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5500
49080b10
LMI
5501 * search.c (Fre_search_backward): Mention `case-fold-search' in
5502 all the re_search_* functions (bug#8138).
5503
6468f31c
LMI
5504 * keyboard.c (Fopen_dribble_file): Document when the file is
5505 closed (bug#8056).
5506
c965adc5
EZ
55072011-07-14 Eli Zaretskii <eliz@gnu.org>
5508
df9733bf
EZ
5509 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5510 bidi_cache_idx.
5511
0bb23927
EZ
5512 Support bidi reordering of display and overlay strings.
5513 * xdisp.c (compute_display_string_pos)
5514 (compute_display_string_end): Accept additional argument STRING.
5515 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5516 (reseat_to_string): Initialize bidi_it->string.s and
5517 bidi_it->string.schars.
5518 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5519 NULL (avoids a crash in bidi_paragraph_init).
5520 Initialize itb.string.lstring.
0bb23927
EZ
5521 (init_iterator): Call bidi_init_it only of a valid
5522 buffer position was specified. Initialize paragraph_embedding to
5523 L2R.
5524 (reseat_to_string): Initialize the bidi iterator.
5525 (display_string): If we need to ignore text properties of
5526 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5527 original value of -1 will not work with bidi.)
5528 (compute_display_string_pos): First arg is now struct
5529 `text_pos *'; all callers changed. Support display properties on
5530 Lisp strings.
5531 (compute_display_string_end): Support display properties on Lisp
5532 strings.
5533 (init_iterator, reseat_1, reseat_to_string): Initialize the
5534 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5535 when iterating on a string not from display properties).
640c8776
SM
5536 (compute_display_string_pos, compute_display_string_end):
5537 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5538 arrow keys.
5539 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5540 base_level_stop; instead, set base_level_stop to BEGV.
5541 Fixes crashes in vertical-motion.
0bb23927
EZ
5542 (next_element_from_buffer): Improve commentary for when
5543 the iterator is before prev_stop.
5544 (init_iterator): Initialize bidi_p from the default value of
5545 bidi-display-reordering, not from buffer-local value. Use the
5546 buffer-local value only if initializing for buffer iteration.
5547 (handle_invisible_prop): Support invisible properties on strings
5548 that are being bidi-reordered.
5549 (set_iterator_to_next): Support bidi reordering of C strings and
5550 Lisp strings.
5551 (next_element_from_string): Support bidi reordering of Lisp
5552 strings.
5553 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5554 (display_string): Support display of R2L glyph rows.
5555 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5556 (init_iterator): Don't initialize it->bidi_p for strings
5557 here.
5558 (reseat_to_string): Initialize it->bidi_p for strings here.
5559 (next_element_from_string, next_element_from_c_string)
5560 (next_element_from_buffer): Add xassert's for correspondence
5561 between IT's object being iterated and it->bidi_it.string
5562 structure.
5563 (face_before_or_after_it_pos): Support bidi iteration.
5564 (next_element_from_c_string): Handle the case of the first string
5565 character that is not the first one in the visual order.
5566 (get_visually_first_element): New function, refactored from common
5567 parts of next_element_from_buffer, next_element_from_string, and
5568 next_element_from_c_string.
5569 (tool_bar_lines_needed, redisplay_tool_bar)
5570 (display_menu_bar): Force left-to-right direction. Add a FIXME
5571 comment for making that be controlled by a user option.
5572 (push_it, pop_it): Save and restore the state of the
5573 bidi iterator. Save and restore the bidi_p flag.
5574 (pop_it): Iterate out of display property for string iteration as
5575 well.
5576 (iterate_out_of_display_property): Support iteration over strings.
5577 (handle_single_display_spec): Set up it->bidi_it for iteration
5578 over a display string, and call bidi_init_it.
5579 (handle_single_display_spec, next_overlay_string)
5580 (get_overlay_strings_1, push_display_prop): Set up the bidi
5581 iterator for displaying display or overlay strings.
5582 (forward_to_next_line_start): Don't use the shortcut if
5583 bidi-iterating.
5584 (back_to_previous_visible_line_start): If handle_display_prop
5585 pushed the iterator stack, restore the internal state of the bidi
5586 iterator by calling bidi_pop_it same number of times.
5587 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5588 and we are bidi-iterating, don't decrement the iterator position;
5589 instead, set the first_elt flag in the bidi iterator, to produce
5590 the same effect.
5591 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5592 (push_display_prop): xassert that we are iterating a buffer.
5593 (push_it, pop_it): Save and restore paragraph_embedding member.
5594 (handle_single_display_spec, next_overlay_string)
5595 (get_overlay_strings_1, reseat_1, reseat_to_string)
5596 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5597 correctly. Don't assume unibyte strings are not bidi-reordered.
5598 (compute_display_string_pos)
5599 (compute_display_string_end): Fix handling the case of C string.
5600 (push_it, pop_it): Save and restore from_disp_prop_p.
5601 (handle_single_display_spec, push_display_prop): Set the
5602 from_disp_prop_p flag.
5603 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5604 (pop_it): Call iterate_out_of_display_property only if we are
5605 popping after iteration over a string that came from a display
5606 property. Fix a typo in popping stretch info. Add an assertion
5607 for verifying that the iterator position is in sync with the bidi
5608 iterator.
5609 (handle_single_display_spec, get_overlay_strings_1)
5610 (push_display_prop): Fix initialization of paragraph direction for
5611 string when that of the parent object is not yet determined.
5612 (reseat_1): Call bidi_init_it to resync the bidi
5613 iterator with IT's position. (Bug#7616)
5614 (find_row_edges): If ROW->start.pos gives position
5615 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5616 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5617 Reset the from_disp_prop_p flag.
5618 (SAVE_IT, RESTORE_IT): New macros.
5619 (pos_visible_p, face_before_or_after_it_pos)
5620 (back_to_previous_visible_line_start)
5621 (move_it_in_display_line_to, move_it_in_display_line)
5622 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5623 (try_scrolling, redisplay_window, display_line): Use them when
5624 saving a temporary copy of the iterator and restoring it back.
5625 (back_to_previous_visible_line_start, reseat_1)
5626 (init_iterator): Empty the bidi cache "stack".
5627 (move_it_in_display_line_to): If iterator ended up at
5628 EOL, but we never saw any buffer positions smaller than
5629 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5630 motion in bidi-reordered lines.
5631 (move_it_in_display_line_to): Record prev_method and prev_pos
5632 immediately before the call to set_iterator_to_next. Fixes cursor
5633 motion in bidi-reordered lines with stretch glyphs and strings
5634 displayed in margins. (Bug#8133) (Bug#8867)
5635 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5636 TO_CHARPOS.
640c8776
SM
5637 (pos_visible_p): Support positions in bidi-reordered lines.
5638 Save and restore bidi cache.
0bb23927
EZ
5639
5640 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5641 (bidi_paragraph_info): Delete unused struct.
5642 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5643 (bidi_cache_start): New variable.
5644 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5645 to zero.
5646 (bidi_cache_fetch_state, bidi_cache_search)
5647 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5648 (bidi_cache_find, bidi_peek_at_next_level)
5649 (bidi_level_of_next_char, bidi_find_other_level_edge)
5650 (bidi_move_to_visually_next): Compare cache index with
5651 bidi_cache_start rather than with zero.
5652 (bidi_fetch_char): Accept new argument STRING; all callers
5653 changed. Support iteration over a string. Support strings with
5654 display properties. Support unibyte strings. Fix the type of
5655 `len' according to what STRING_CHAR_AND_LENGTH expects.
5656 (bidi_paragraph_init, bidi_resolve_explicit_1)
5657 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5658 (bidi_level_of_next_char, bidi_move_to_visually_next):
5659 Support iteration over a string.
0bb23927
EZ
5660 (bidi_set_sor_type, bidi_resolve_explicit_1)
5661 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5662 can now be zero (for strings); special values 0 and -1 were
5663 changed to -1 and -2, respectively.
5664 (bidi_char_at_pos): New function.
5665 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5666 Call it instead of FETCH_MULTIBYTE_CHAR.
5667 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5668 initialized to valid values.
5669 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5670 values.
5671 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5672 the test for valid cached positions. Fix the logic for looking up
5673 the sentinel state in the cache. GCPRO the Lisp string we are
5674 iterating.
5675 (bidi_push_it, bidi_pop_it): New functions.
5676 (bidi_initialize): Initialize the bidi cache start stack pointer.
5677 (bidi_cache_ensure_space): New function, refactored from part of
5678 bidi_cache_iterator_state. Don't assume the required size is just
5679 one BIDI_CACHE_CHUNK away.
5680 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5681 (bidi_count_bytes, bidi_char_at_pos): New functions.
5682 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5683 always valid if bidi_cache_idx is valid.
5684 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5685 is valid if it's going to be used.
5686 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5687 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5688 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5689 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5690 (bidi_find_other_level_edge, bidi_cache_start_stack):
5691 All variables related to cache indices are now EMACS_INT.
c965adc5 5692
0bb23927
EZ
5693 * dispextern.h (struct bidi_string_data): New structure.
5694 (struct bidi_it): New member `string'. Make flag members be 1-bit
5695 fields, and put them last in the struct.
640c8776
SM
5696 (compute_display_string_pos, compute_display_string_end):
5697 Update prototypes.
0bb23927
EZ
5698 (bidi_push_it, bidi_pop_it): Add prototypes.
5699 (struct iterator_stack_entry): New members bidi_p,
5700 paragraph_embedding, and from_disp_prop_p.
5701 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5702 (bidi_shelve_cache, bidi_unshelve_cache):
5703 Declare prototypes.
0bb23927
EZ
5704
5705 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5706 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5707 and vector-like objects.
5708
5709 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5710 cache around display iteration.
5711
5712 * window.c (Fwindow_end, window_scroll_pixel_based)
5713 (displayed_window_lines, Frecenter): Save and restore the bidi
5714 cache around display iteration.
5715
3bbd2265
LMI
57162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5717
5718 * editfns.c (Fdelete_region): Clarify the use of the named
5719 parameters (bug#6788).
5720
adc47434
MR
57212011-07-14 Martin Rudalics <rudalics@gmx.at>
5722
5723 * indent.c (Fvertical_motion): Set and restore w->pointm when
5724 saving and restoring the window's buffer (Bug#9006).
5725
837c31f8
LMI
57262011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5727
5728 * editfns.c (Fstring_to_char): Clarify just what is returned
5729 (bug#6576). Text by Eli Zaretskii.
5730
ac389d0c
JB
57312011-07-13 Juanma Barranquero <lekktu@gmail.com>
5732
5733 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5734
0be0ce47
EZ
57352011-07-13 Eli Zaretskii <eliz@gnu.org>
5736
5737 * buffer.c (mmap_find): Fix a typo.
5738
cd18e7e3
JB
57392011-07-13 Johan Bockgård <bojohan@gnu.org>
5740
5741 Fix execution of x selection hooks.
5742 * xselect.c (Qx_lost_selection_functions)
5743 (Qx_sent_selection_functions): New vars.
5744 (syms_of_xselect): DEFSYM them.
5745 (x_handle_selection_request): Pass Qx_sent_selection_functions
5746 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5747 (x_handle_selection_clear,x_clear_frame_selections):
5748 Pass Qx_lost_selection_functions rather than
5749 Vx_lost_selection_functions to Frun_hook_with_args.
5750
47ea7f44
PE
57512011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5752
ac389d0c 5753 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
5754 The old code sometimes used this field without initializing it.
5755
47ea7f44
PE
5756 * alloc.c (gc_sweep): Don't read past end of array.
5757 In theory, the old code could also have corrupted Emacs internals,
5758 though it'd be very unlikely.
5759
bc985c87
AS
57602011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5761
5762 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 5763 argument. (Bug#4026)
bc985c87 5764
0cf34688
LMI
57652011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5766
b3dadd76
LMI
5767 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5768 key" (bug#4257).
5769
0cf34688
LMI
5770 * window.c (Fset_window_start): Doc fix (bug#4199).
5771 (Fset_window_hscroll): Ditto.
5772
270768cd
PE
57732011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5774
077e3dda 5775 Fix minor new problems caught by GCC 4.6.1.
270768cd 5776 * term.c (init_tty): Remove unused local.
490011a6 5777 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 5778 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 5779 not used otherwise.
270768cd 5780
b1f58454
CY
57812011-07-12 Chong Yidong <cyd@stupidchicken.com>
5782
5783 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5784
22b9578d
LMI
57852011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5786
6e70ab07
LMI
5787 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5788 are the mini-buffer and the echo area (bug#3320).
5789
22b9578d
LMI
5790 * term.c (init_tty): Remove support for supdup, c10 and perq
5791 terminals, which are no longer supported (bug#1482).
5792
8974cc9f
JB
57932011-07-10 Johan Bockgård <bojohan@gnu.org>
5794
5795 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5796
a560d974
JD
57972011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5798
5799 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5800 for non-popups (Bug#3642).
5801
1dae0f0a
AS
58022011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5803
268c2c36 5804 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 5805 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
5806 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5807 * cm.c (losecursor): Likewise.
1dae0f0a
AS
5808 * data.c (fmod): Likewise.
5809 * dispnew.c (swap_glyphs_in_rows): Likewise.
5810 * emacs.c (memory_warning_signal): Likewise.
5811 * floatfns.c (float_error): Likewise.
5812 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5813 (otf_open, font_otf_capability, generate_otf_features)
5814 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5815 Likewise.
5816 * image.c (pbm_read_file): Likewise.
5817 * indent.c (string_display_width): Likewise.
5818 * intervals.c (check_for_interval, search_for_interval)
5819 (inc_interval_count, count_intervals, root_interval)
5820 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5821 * lread.c (defalias): Likewise.
268c2c36 5822 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
5823 * regex.c (set_image_of_range_1, set_image_of_range)
5824 (regex_grow_registers): Likewise.
5825 * sysdep.c (strerror): Likewise.
5826 * termcap.c (valid_filename_p, tprint, main): Likewise.
5827 * tparam.c (main): Likewise.
5828 * unexhp9k800.c (run_time_remap, save_data_space)
5829 (update_file_ptrs, read_header, write_header, calculate_checksum)
5830 (copy_file, copy_rest, display_header): Likewise.
5831 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5832 Likewise.
5833 * xdisp.c (check_it): Likewise.
5834 * xfaces.c (register_color, unregister_color, unregister_colors):
5835 Likewise.
5836 * xfns.c (print_fontset_result): Likewise.
5837 * xrdb.c (member, fatal, main): Likewise.
5838
99033785
PE
58392011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5840
5841 Fix minor problems found by static checking (Bug#9031).
5842 * chartab.c (char_table_set_range, map_sub_char_table):
5843 Remove unused locals.
5844 (uniprop_table): Now static.
5845 * composite.c (_work_char): Remove unused static var.
5846
9cb2ac56
JB
58472011-07-09 Juanma Barranquero <lekktu@gmail.com>
5848
5849 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5850
f25661f0
JD
58512011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5852
5853 * gtkutil.c (qttip_cb): Remove code without function.
5854
8278c4fe
EZ
58552011-07-09 Eli Zaretskii <eliz@gnu.org>
5856
5857 * w32.c (pthread_sigmask): New stub.
5858
1692ae2d 58592011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 5860
8a6ebd58 5861 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
5862 sigprocmask is portable only for single-threaded applications, and
5863 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
5864 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5865 (LIBES): Use it.
5866 * callproc.c (Fcall_process):
5867 * process.c (create_process):
5868 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5869 Use pthread_sigmask, not sigprocmask.
123403e4 5870
1b854618
JD
58712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5872
5873 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5874 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5875 wrong (Bug#8591).
5876
3fe4b549
JD
58772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5878
0ce7e563
JD
5879 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5880 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5881 (xg_hide_tooltip): Fix comment.
5882
3fe4b549
JD
5883 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5884 in registerServicesMenuSendTypes.
5885 (validRequestorForSendType): Don't check ns_return_types.
5886
5887 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5888 ns_return_type.
5889
5df75e47
JR
58902011-07-08 Jason Rumney <jasonr@gnu.org>
5891
22610910
JR
5892 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5893 SH_SHOW for hidden windows (Bug#5482).
5894
5df75e47
JR
5895 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5896 frame struct members of non-existent frames (Bug#6284).
5897
699c10bd
JD
58982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5899
4393663b
JD
5900 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5901 variable firstTime not needed on OSX >= 10.6.
5902 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5903 >= 10.5. Use setKnobProportion, setDoubleValue.
5904
5905 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5906 (MAC_OS_X_VERSION_10_5): Define if not defined.
5907 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5908 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5909 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5910
5911 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5912 cString and lossyCString on OSX >= 10.4
5913
58179cce 5914 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
5915 sizeToFit on OSX >= 10.2.
5916
5917 * nsimage.m (allocInitFromFile): Don't use deprecated method
5918 bestRepresentationForDevice on OSX >= 10.6.
5919
5920 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5921 to avoid warning.
5922
5923 * emacs.c: Declare unexec_init_emacs_zone.
5924
a63e0781
JD
5925 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5926
699c10bd
JD
5927 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5928
5929 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5930 on svcsMenu (Bug#8842).
5931
5932 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5933 ns_return_types.
5934 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5935
5936 * nsterm.m (QUTF8_STRING): Declare.
5937 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5938 (validRequestorForSendType): Return type is (id).
5939 Change indexOfObjectIdenticalTo to indexOfObject.
5940 Check if we have local selection before returning self (Bug#8842).
5941 (writeSelectionToPasteboard): Put local selection into paste board
5942 if we have a local selection (Bug#8842).
5943 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5944
5945 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5946 (ns_get_local_selection): Declare.
5947
54e10184
LMI
59482011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5949
9888ff71
LMI
5950 * keymap.c (describe_map_tree): Don't insert a double newline at
5951 the end of the buffer (bug#1169) and return whether we inserted
5952 something.
5953
54e10184
LMI
5954 * callint.c (Fcall_interactively): Change "reading args" to
5955 "providing args" to try to clarify what it does (bug#1010).
5956
15fa4783
KH
59572011-07-07 Kenichi Handa <handa@m17n.org>
5958
5959 * composite.c (composition_compute_stop_pos): Ignore a static
5960 composition starting before CHARPOS (Bug#8915).
5961
5962 * xdisp.c (handle_composition_prop): Likewise.
5963
a8815b00
EZ
59642011-07-07 Eli Zaretskii <eliz@gnu.org>
5965
5966 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5967 (Bug#9015)
5968
ef7b981d 59692011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
5970
5971 * character.h (unicode_category_t): New enum type.
5972
5973 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5974 (Qchar_code_property_table): New variable.
5975 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5976 (UNIPROP_COMPRESSED_FORM_P): New macros.
5977 (char_table_ascii): Uncompress the compressed values.
5978 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5979 Uncompress the compressed values.
ac389d0c 5980 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
5981 (char_table_ref_and_range): Uncompress the compressed values.
5982 (sub_char_table_set): New arg is_uniprop. Callers changed.
5983 Uncompress the compressed values.
5984 (sub_char_table_set_range): Args changed. Callers changed.
5985 (char_table_set_range): Adjuted for the above change.
5986 (map_sub_char_table): Delete args default_val and parent. Add arg
5987 top. Give decoded values to a Lisp function.
640c8776 5988 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
5989 values to a Lisp function. Gcpro more variables.
5990 (uniprop_table_uncompress)
5991 (uniprop_decode_value_run_length): New functions.
5992 (uniprop_decoder, uniprop_decoder_count): New variables.
5993 (uniprop_get_decoder, uniprop_encode_value_character)
5994 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5995 New functions.
5996 (uniprop_encoder, uniprop_encoder_count): New variables.
5997 (uniprop_get_encoder, uniprop_table)
5998 (Funicode_property_table_internal, Fget_unicode_property_internal)
5999 (Fput_unicode_property_internal): New functions.
6000 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6001 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6002 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6003 char-code-property-alist.
6004
640c8776 6005 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6006 Vunicode_category_table.
6007
640c8776 6008 * font.c (font_range): Adjust for the change of
c805dec0
KH
6009 Vunicode_category_table.
6010
76b397fb
DN
60112011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6012
6013 * m/iris4d.h: Remove file, move contents ...
6014 * s/irix6-5.h: ... here.
6015
22b4128e
PE
60162011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6017
6018 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6019 * alloc.c (mark_buffer):
6020 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6021 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6022 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6023 This isn't true in general, and it's particularly not true
6024 if Emacs is configured with --with-wide-int.
6025 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6026 New macros, used in the buffer.c change.
6027
869795d6
JD
60282011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6029
6030 * xsettings.c: Use both GConf and GSettings if both are available.
6031 (store_config_changed_event): Add comment.
6032 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6033 (store_tool_bar_style_changed): New functions.
5e617bc2 6034 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6035 (struct xsettings): Move font inside HAVE_XFT.
6036 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6037 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6038 Move inside HAVE_XFT.
640c8776 6039 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6040 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6041 also.
6042 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6043 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6044 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6045 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6046 (parse_settings): Move check for font inside HAVE_XFT.
6047 (read_settings, apply_xft_settings): Add comment.
6048 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6049 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6050 call store_font_name_changed.
6051 (xft_settings_event): Add comment.
6052 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6053 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6054 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6055 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6056 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6057 (xsettings_get_system_font, xsettings_get_system_normal_font):
6058 Add comment.
869795d6 6059
d8ed26bd
PE
60602011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6061
6062 Random fixes. E.g., (random) never returned negative values.
6063 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6064 subseconds part to the entropy, as that's a bit more random.
6065 Prefer signed to unsigned, since the signedness doesn't matter and
6066 in general we prefer signed. When given a limit, use a
6067 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6068 latter isn't right if USE_2_TAGS_FOR_INTS.
6069 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6070 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6071
cabf1cac
SM
60722011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6073
6074 * textprop.c (text_property_stickiness):
6075 Obey Vtext_property_default_nonsticky.
6076 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6077 * w32fns.c (syms_of_w32fns):
6078 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6079
6e9b2be9
PE
60802011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6081
6082 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6083 This is more efficient than Ffile_directory_p and avoids a minor race.
6084
90186c68
LMI
60852011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6086
7c301272
LMI
6087 * buffer.c (Foverlay_put): Say what the return value is
6088 (bug#7835).
6089
c4f2d8d4
LMI
6090 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6091 is a directory before asking whether to use the file name
6092 (bug#7564).
ad637907
LMI
6093 (barf_or_query_if_file_exists): Make the "File is a directory"
6094 error be more correct.
c4f2d8d4 6095
90186c68
LMI
6096 * fns.c (Frequire): Remove the mention of the .gz files, since
6097 that's installation-specific, but keep the mention of
6098 `get-load-suffixes'.
6099
da64016e
PE
61002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6101
6102 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6103 Report string overflow if the output is too long.
6104
7d47b580
JB
61052011-07-04 Juanma Barranquero <lekktu@gmail.com>
6106
a555cb87
JB
6107 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6108 (syms_of_gnutls): Remove duplicate DEFSYM for
6109 Qgnutls_bootprop_verify_hostname_error, an error for
6110 Qgnutls_bootprop_verify_error (which is no longer used).
6111
7d47b580
JB
6112 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6113 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6114 Also (re)move comments that are misplaced or no longer relevant.
6115
1e49bfab
LMI
61162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6117
6118 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6119
1485f4c0
CY
61202011-07-03 Chong Yidong <cyd@stupidchicken.com>
6121
6122 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6123 and background color parameters if they have been changed.
6124
a9ab721e
LMI
61252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6126
6127 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6128
cf7cff57
PE
61292011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6130
2e13213d
PE
6131 * xsettings.c (SYSTEM_FONT): Define only when used.
6132 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6133
cf7cff57
PE
6134 * keymap.c (access_keymap_1): Now static.
6135
7a8e04f7
CY
61362011-07-02 Chong Yidong <cyd@stupidchicken.com>
6137
6138 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6139 leave any prefix arg for the up event (Bug#1586).
6140
61352f62
LMI
61412011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6142
69bb1ef7
LMI
6143 * lread.c (syms_of_lread): Mention single symbols defined by
6144 `defvar' or `defconst' (bug#7154).
6145
61352f62 6146 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6147 (Frequire): Mention get-load-suffixes.
61352f62 6148
28545e04
MR
61492011-07-02 Martin Rudalics <rudalics@gmx.at>
6150
6151 * window.h (window): Remove clone_number slot.
6152 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6153 Remove.
6154 (make_parent_window, make_window, saved_window)
6155 (Fset_window_configuration, save_window_save): Don't deal with
6156 clone numbers.
6157 * buffer.c (Qclone_number): Remove declaration.
6158 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6159
3349e122
SM
61602011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6161
6162 Add multiple inheritance to keymaps.
6163 * keymap.c (Fmake_composed_keymap): New function.
6164 (Fset_keymap_parent): Simplify.
6165 (fix_submap_inheritance): Remove.
6166 (access_keymap_1): New function extracted from access_keymap to handle
6167 embedded parents and handle lists of maps.
6168 (access_keymap): Use it.
6169 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6170 (Fcopy_keymap): Handle embedded parents.
6171 (Fcommand_remapping, define_as_prefix): Simplify.
6172 (Fkey_binding): Simplify.
6173 (syms_of_keymap): Move minibuffer-local-completion-map,
6174 minibuffer-local-filename-completion-map,
6175 minibuffer-local-must-match-map, and
6176 minibuffer-local-filename-must-match-map to Elisp.
6177 (syms_of_keymap): Defsubr make-composed-keymap.
6178 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6179 (parse_menu_item): Trivial simplification.
6180
3279eb87
GM
61812011-07-01 Glenn Morris <rgm@gnu.org>
6182
6183 * Makefile.in (SETTINGS_LIBS): Fix typo.
6184
4550efdf
KI
61852011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6186
6187 * coding.c (Fencode_coding_string): Record the last coding system
6188 used, as the function doc string says (bug#8738).
6189
0949d2b6
JD
61902011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6191
6192 * xsettings.c (store_monospaced_changed): Take new font as arg and
6193 check for change against current_mono_font.
6194 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6195 (emacs_settings_constructor, emacs_settings_get_property)
6196 (emacs_settings_set_property, emacs_settings_class_init)
6197 (emacs_settings_init, gsettings_obj): Remove.
6198 (something_changedCB): New function for HAVE_GSETTINGS.
6199 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6200 with value as argument.
6201 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6202 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6203 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6204 "changed".
6205
6206 * xgselect.c: Add defined (HAVE_GSETTINGS).
6207 (xgselect_initialize): Ditto.
6208
6209 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6210 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6211 xg_select.
6212
bbc6b304
PE
62132011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6214
6215 * eval.c (struct backtrace): Simplify and port the data structure.
6216 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6217 signed bit field, as this assumption is not portable and it makes
6218 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6219 "char debug_on_exit : 1" as this is not portable either; instead,
6220 use the portable "unsigned int debug_on_exit : 1". Remove unused
6221 member evalargs. Remove obsolete comments about cc bombing out.
6222
9851bfc5
JD
62232011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6224
51bb811f 6225 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6226 Let HAVE_GSETTINGS override HAVE_GCONF.
6227 (store_monospaced_changed): New function.
6228 (EMACS_SETTINGS): A new type derived from GObject to handle
6229 GSettings notifications.
6230 (emacs_settings_constructor, emacs_settings_get_property)
6231 (emacs_settings_set_property, emacs_settings_class_init):
6232 New functions.
6233 (gsettings_client, gsettings_obj): New variables.
6234 (GSETTINGS_SCHEMA): New define.
6235 (something_changedCB): Call store_monospaced_changed.
6236 (init_gsettings): New function.
6237 (xsettings_initialize): Call init_gsettings.
6238 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6239 to NULL.
6240
640c8776 6241 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6242 GCONF_CFLAGS/LIBS.
6243
5386012d
MR
62442011-06-29 Martin Rudalics <rudalics@gmx.at>
6245
6246 * window.c (resize_root_window, grow_mini_window)
6247 (shrink_mini_window): Rename Qresize_root_window to
6248 Qwindow_resize_root_window and Qresize_root_window_vertically to
6249 Qwindow_resize_root_window_vertically.
6250
f13e0b08
PE
62512011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6252
6253 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6254
94515237
JB
62552011-06-27 Juanma Barranquero <lekktu@gmail.com>
6256
6257 * makefile.w32-in: Redesign dependencies so they reflect more
6258 clearly which files are directly included by each source file,
6259 and not through other includes.
6260
e43b6e43
MR
62612011-06-27 Martin Rudalics <rudalics@gmx.at>
6262
6263 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6264 (sort_overlays, overlay_strings): When an overlay's clone number
6265 matches the window's clone number process the overlay even if
6266 the overlay's window property doesn't match the current window.
6267
d68443dc
MR
6268 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6269 (Fwindow_hchild): Rename to Fwindow_left_child.
6270 (Fwindow_next): Rename to Fwindow_next_sibling.
6271 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6272 (resize_window_check): Rename to window_resize_check.
6273 (resize_window_apply): Rename to window_resize_apply.
6274 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6275 (Fdelete_other_windows_internal, resize_frame_windows)
6276 (Fsplit_window_internal, Fdelete_window_internal)
6277 (grow_mini_window, shrink_mini_window)
6278 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6279
c7e73be5
JD
62802011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6281
6282 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6283 (emacs_fixed_set_min_size): Remove.
6284 (emacs_fixed_new): Take frame as argument.
6285
6286 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6287 (_EmacsFixedPrivate): Remove minwidth/height.
6288 Add struct frame *f.
6289 (emacs_fixed_init): Initialize priv->f.
6290 (get_parent_class, emacs_fixed_set_min_size): Remove.
6291 (emacs_fixed_new): Set priv->f to argument.
6292 (emacs_fixed_get_preferred_width)
6293 (emacs_fixed_get_preferred_height): Use min_width/height from
6294 frames size_hint to set minimum and natural (Bug#8919).
6295 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6296 and use min_width/height from frames size_hint to set
6297 min_width/height (Bug#8919).
6298
6299 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6300 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6301 Fix indentation.
c7e73be5 6302
cf99dcf8
EZ
63032011-06-26 Eli Zaretskii <eliz@gnu.org>
6304
6305 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6306 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6307 called at ZV.
6308
029529ac
CY
63092011-06-26 Chong Yidong <cyd@stupidchicken.com>
6310
6311 * process.c (wait_reading_process_output): Bypass select if
6312 waiting for a cell while ignoring keyboard input, and input is
6313 pending. Suggested by Jan Djärv (Bug#8869).
6314
7a7ef429
PE
63152011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6316
6317 Use gnulib's dup2 module instead of rolling our own.
6318 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6319
11fdef7d 63202011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6321
6322 * dispnew.c (scrolling_window): Before scrolling, turn off a
6323 mouse-highlight in the window being scrolled.
6324
cd3520a4
JB
63252011-06-24 Juanma Barranquero <lekktu@gmail.com>
6326
6327 Move DEFSYM to lisp.h and use everywhere.
6328
6329 * character.h (DEFSYM): Move declaration...
6330 * lisp.h (DEFSYM): ...here.
6331
6332 * gnutls.c:
6333 * minibuf.c:
6334 * w32menu.c:
6335 * w32proc.c:
6336 * w32select.c: Don't include character.h.
6337
6338 * alloc.c (syms_of_alloc):
6339 * buffer.c (syms_of_buffer):
6340 * bytecode.c (syms_of_bytecode):
6341 * callint.c (syms_of_callint):
6342 * casefiddle.c (syms_of_casefiddle):
6343 * casetab.c (init_casetab_once):
6344 * category.c (init_category_once, syms_of_category):
6345 * ccl.c (syms_of_ccl):
6346 * cmds.c (syms_of_cmds):
6347 * composite.c (syms_of_composite):
6348 * dbusbind.c (syms_of_dbusbind):
6349 * dired.c (syms_of_dired):
6350 * dispnew.c (syms_of_display):
6351 * doc.c (syms_of_doc):
6352 * editfns.c (syms_of_editfns):
6353 * emacs.c (syms_of_emacs):
6354 * eval.c (syms_of_eval):
6355 * fileio.c (syms_of_fileio):
6356 * fns.c (syms_of_fns):
6357 * frame.c (syms_of_frame):
6358 * fringe.c (syms_of_fringe):
6359 * insdel.c (syms_of_insdel):
6360 * keymap.c (syms_of_keymap):
6361 * lread.c (init_obarray, syms_of_lread):
6362 * macros.c (syms_of_macros):
6363 * msdos.c (syms_of_msdos):
6364 * print.c (syms_of_print):
6365 * process.c (syms_of_process):
6366 * search.c (syms_of_search):
6367 * sound.c (syms_of_sound):
6368 * syntax.c (init_syntax_once, syms_of_syntax):
6369 * terminal.c (syms_of_terminal):
6370 * textprop.c (syms_of_textprop):
6371 * undo.c (syms_of_undo):
6372 * w32.c (globals_of_w32):
6373 * window.c (syms_of_window):
6374 * xdisp.c (syms_of_xdisp):
6375 * xfaces.c (syms_of_xfaces):
6376 * xfns.c (syms_of_xfns):
6377 * xmenu.c (syms_of_xmenu):
6378 * xsettings.c (syms_of_xsettings):
6379 * xterm.c (syms_of_xterm): Use DEFSYM.
6380
4228cf16
TZ
63812011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6382
cd3520a4 6383 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6384
7fcccf1e
PE
63852011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6386
7efb4e0e
PE
6387 Integer and buffer overflow fixes (Bug#8873).
6388
ff5844ad
PE
6389 * print.c (printchar, strout): Check for string overflow.
6390 (PRINTPREPARE, printchar, strout):
6391 Don't set size unless allocation succeeds.
6392
90532f02
PE
6393 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6394 for sizes. Check for string overflow more accurately.
6395 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6396
6d84508d
PE
6397 * macros.c: Integer and buffer overflow fixes.
6398 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6399 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6400 Use ptrdiff_t, not int, for sizes.
6401 Don't increment bufsize until after realloc succeeds.
6402 Check for size-calculation overflow.
6403 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6404
437b2cb4
PE
6405 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6406
8b9ac8b4
PE
6407 * lread.c: Integer overflow fixes.
6408 (read_integer): Radix is now EMACS_INT, not int,
6409 to improve quality of diagnostics for out-of-range radices.
6410 Calculate buffer size correctly for out-of-range radices.
6411 (read1): Check for integer overflow in radices, and in
6412 read-circle numbers.
82cb60d3
PE
6413 (read_escape): Avoid int overflow.
6414 (Fload, openp, read_buffer_size, read1)
6415 (substitute_object_recurse, read_vector, read_list, map_obarray):
6416 Use ptrdiff_t, not int, for sizes.
6417 (read1): Use EMACS_INT, not int, for sizes.
20270765 6418 Check for size overflow.
8b9ac8b4 6419
7fcccf1e
PE
6420 * image.c (cache_image): Check for size arithmetic overflow.
6421
bfbbd7e7
PE
6422 * lread.c: Integer overflow issues.
6423 (saved_doc_string_size, saved_doc_string_length)
6424 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6425 Now ptrdiff_t, not int.
6426 (read1): Don't assume doc string length fits in int. Check for
6427 out-of-range doc string lengths.
6428 (read_list): Don't assume file position fits in int.
39019e54 6429 (read_escape): Check for hex character overflow.
bfbbd7e7 6430
4e323265
LL
64312011-06-22 Leo Liu <sdl.web@gmail.com>
6432
6433 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6434 Move to minibuffer.el.
6435
85fece3e
PE
64362011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6437
20b84ce9 6438 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6439 The following patches are for when GLYPH_DEBUG && !XASSERT.
6440 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6441 * dispnew.c (flush_stdout):
6442 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6443 Mark as externally visible.
6444 * dispnew.c (check_window_matrix_pointers): Now static.
6445 * dispnew.c (window_to_frame_vpos):
6446 * xfns.c (unwind_create_frame):
6447 * xterm.c (x_check_font): Remove unused local.
6448 * scroll.c (CHECK_BOUNDS):
6449 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6450 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6451 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6452 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6453 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6454 Now static.
6455 (debug_method_add): Use va_list and vsprintf rather than relying
6456 on undefined behavior with wrong number of arguments.
6457 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6458 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6459 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6460 since we're not interested in debugging glyphs with old libraries.
6461 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6462 GCC 4.6.0's static checking.
6463
0766b489
PE
64642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6465
31fd4b32
PE
6466 Integer overflow and signedness fixes (Bug#8873).
6467 A few related buffer overrun fixes, too.
6468
b79e8648
PE
6469 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6470
0766b489
PE
6471 * dispextern.h (struct face.stipple):
6472 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6473 (x_bitmap_mask, x_allocate_bitmap_record)
6474 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6475 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6476 (x_create_bitmap_from_xpm_data):
6477 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6478 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6479 (.bitmaps_last):
6480 * xfaces.c (load_pixmap):
6481 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6482 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6483 (.bitmaps_last, struct x_output.icon_bitmap):
6484 Use ptrdiff_t, not int, for bitmap indexes.
6485 (x_allocate_bitmap_record): Check for size overflow.
6486 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6487
b081724f
PE
6488 Use ptrdiff_t, not int, for overlay counts.
6489 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6490 * editfns.c (overlays_around, get_pos_property):
6491 * textprop.c (get_char_property_and_overlay):
6492 * xdisp.c (next_overlay_change, note_mouse_highlight):
6493 * xfaces.c (face_at_buffer_position):
21514da7
PE
6494 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6495 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6496 (Fnext_overlay_change, Fprevious_overlay_change)
6497 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6498 Use ptrdiff_t, not int, for sizes.
21514da7 6499 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6500
3de73e5e
PE
6501 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6502
2606c57b
PE
6503 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6504 (x_session_initialize): Do not assume string length fits in int.
6505
aaafe47a
PE
6506 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6507 This is unlikely, but can occur if DPI is outlandish.
6508
2674ddc8 6509 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6510 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6511
28154962
PE
6512 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6513 * xrdb.c (magic_file_p, search_magic_path):
6514 Omit last arg SUFFIX; it was always 0. All callers changed.
6515 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6516
7de51af5
PE
6517 * xfont.c (xfont_match): Avoid need for strlen.
6518
25ed6cc3
PE
6519 * xfns.c: Don't assume strlen fits in int.
6520 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6521
4eab31dd
PE
6522 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6523 not unsigned long, as we prefer signed integers. All callers changed.
6524 Detect integer overflow in repeat count.
6525 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6526 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6527
171e2a58
PE
6528 * termcap.c: Don't assume sizes fit in int and never overflow.
6529 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6530 (gobble_line): Check for size-calculation overflow.
6531
ad39faca 6532 * minibuf.c (Fread_buffer):
6e5bb2dc 6533 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6534 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6535 Don't assume string length fits in int.
6536
52c61c22 6537 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6538 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6539
b5b8c9e5
PE
6540 * font.c: Don't assume string length fits in int.
6541 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6542 Use ptrdiff_t, not int.
ccd6111c
PE
6543 (font_intern_prop): Don't assume string length fits in int.
6544 Don't assume integer property fits in fixnum.
6545 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6546
882f0d81 6547 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6548 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6549 Reformulate so as not to need the command string.
6550 Invoke gzip -cd rather than gunzip, as it's more portable.
6551 (lock_info_type, lock_file_1, lock_file):
6552 Don't assume pid_t and time_t fit in unsigned long.
6553 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6554 (current_lock_owner): Prefer signed type for sizes.
6555 Use memcpy, not strncpy, where memcpy is what is really wanted.
6556 Don't assume (via atoi) that time_t and pid_t fit in int.
6557 Check for time_t and/or pid_t out of range, e.g., via a network share.
6558 Don't alloca where an auto var works fine.
6559
93f4cf88
PE
6560 * fileio.c: Fix some integer overflow issues.
6561 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6562 Don't assume string length fits in int.
6563 (directory_file_name): Don't assume string length fits in long.
6564 (make_temp_name): Don't assume pid fits in int, or that its print
6565 length is less than 20.
6566
f3e92b69
PE
6567 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6568
1bfdaf10
PE
6569 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6570
35016e9a
PE
6571 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6572
3d1e65a1
PE
6573 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6574 We prefer signed integers, even for size calculations.
6575
0b963a93
PE
6576 * emacs.c: Don't assume string length fits in 'int'.
6577 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6578 (main): Don't invoke strlen when not needed.
6579
573f4b54
PE
6580 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6581 (XD_DEBUG_MESSAGE): Don't waste a byte.
6582
989f33ba
PE
6583 * callproc.c (getenv_internal_1, getenv_internal)
6584 (Fgetenv_internal):
965d34eb
PE
6585 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6586
e4d29b33
PE
6587 * lread.c (invalid_syntax): Omit length argument.
6588 All uses changed. This doesn't fix a bug, but it simplifies the
6589 code away from its former Hollerith-constant appearance, and it's
6590 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6591 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6592
eb49b136
PE
6593 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6594 This didn't break anything, but it didn't help either.
6595 It's confusing to put a bogus integer in a place where the actual
6596 value does not matter.
9f62aeb1 6597 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6598 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6599
15375a22
PE
6600 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6601 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6602 implementation.
b61cc01c
PE
6603 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6604 We prefer signed types, and the value cannot exceed the EMACS_INT
6605 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6606 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6607 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6608 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6609
53b2623d
PE
6610 * indent.c (sane_tab_width): New function.
6611 (current_column, scan_for_column, Findent_to, position_indentation)
6612 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6613 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6614
51cab52b 6615 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6616
f2ed8a70
PE
6617 * lisp.h (lint_assume): New macro.
6618 * composite.c (composition_gstring_put_cache):
6619 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6620
abe80cc6
PE
6621 * editfns.c, insdel.c:
6622 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6623
b02c740e
PE
6624 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6625
ebc96716
PE
6626 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6627
b4e50fa0 6628 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6629 Use much-faster test for byte-length change.
311d5d7c 6630 Don't assume string byte-length fits in 'int'.
a4cf38e4 6631 Check that character arg fits in 'int'.
85461888 6632 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6633
c0c1ee9f
PE
6634 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6635
a498d7f4
PE
6636 * fns.c (concat): Catch string overflow earlier.
6637 Do not rely on integer wraparound.
6638
51cab52b
PE
6639 * dispextern.h (struct it.overlay_strings_charpos)
6640 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6641 * xdisp.c (forward_to_next_line_start)
6642 (back_to_previous_visible_line_start)
6643 (reseat_at_next_visible_line_start, next_element_from_buffer):
6644 Don't arbitrarily truncate the value of 'selective' to int.
6645
76031fad
PE
6646 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6647
5eb55db9
PE
6648 * composite.c: Don't truncate sizes to 'int'.
6649 (composition_gstring_p, composition_reseat_it)
6650 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6651 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6652 not EMACS_UINT, for indexes.
5eb55db9 6653
0703a717
PE
6654 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6655
d6202519
PE
6656 * buffer.c: Include <verify.h>.
6657 (struct sortvec.priority, struct sortstr.priority):
8961a454 6658 Now EMACS_INT, not int.
c20998a7 6659 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6660 (struct sortstr.size, record_overlay_string)
6661 (struct sortstrlist.size, struct sortlist.used):
6662 Don't truncate size to int.
6663 (record_overlay_string): Check for size-calculation overflow.
d6202519 6664 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6665
d5a19415
JM
66662011-06-22 Jim Meyering <meyering@redhat.com>
6667
029529ac 6668 Don't leak an XBM-image-sized buffer
d5a19415
JM
6669 * image.c (xbm_load): Free the image buffer after using it.
6670
a9041e6c
PE
66712011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6672
6673 Port to Sun C.
6674 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6675 that Sun C diagnosed.
6676 * fns.c (secure_hash): Fix pointer signedness issue.
6677 * intervals.c (static_offset_intervals): New function.
6678 (offset_intervals): Use it.
6679
7f3f739f
LL
66802011-06-21 Leo Liu <sdl.web@gmail.com>
6681
6682 * deps.mk (fns.o):
6683 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6684 sha512.h.
6685
6686 * fns.c (secure_hash): Rename from crypto_hash_function and change
6687 the first arg to accept symbols.
5b66d427 6688 (Fsecure_hash): New primitive.
7f3f739f
LL
6689 (syms_of_fns): New symbols.
6690
76147d94
DD
66912011-06-20 Deniz Dogan <deniz@dogan.se>
6692
6693 * process.c (Fset_process_buffer): Clarify return value in
6694 docstring.
6695
7d7d0045
CY
66962011-06-18 Chong Yidong <cyd@stupidchicken.com>
6697
6698 * dispnew.c (add_window_display_history): Use BVAR.
6699
6700 * xdisp.c (debug_method_add): Use BVAR.
6701 (check_window_end, dump_glyph_matrix, dump_glyph)
6702 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6703
6704 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6705 Likewise.
6706
6707 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6708 check till after the cache is created in init_frame_faces.
6709
ff2bc410
SM
67102011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6711
6712 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6713
28177add
PE
67142011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6715
dd3482fe
PE
6716 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6717 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6718 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6719
393d71f3 6720 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
6721 * fileio.c (Finsert_file_contents):
6722 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6723 Remove the old (too-loose) buffer overflow checks.
6724 They weren't needed, since make_gap checks for buffer overflow.
6725 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6726 The old code merely checked for Emacs fixnum overflow, and relied
6727 on undefined (wraparound) behavior. The new code avoids undefined
6728 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6729
2e6813b0 6730 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
6731 Tune. Don't use wider integers than needed. Don't use alloca.
6732 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6733
599a9e4f
PE
6734 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6735
99561444
PE
6736 * insdel.c, lisp.h (buffer_overflow): New function.
6737 (insert_from_buffer_1, replace_range, replace_range_2):
6738 * insdel.c (make_gap_larger):
6739 * editfns.c (Finsert_char):
6740 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6741
28177add
PE
6742 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6743
e69dafad
PE
67442011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6745
4baa020d 6746 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 6747
b1c46f02
PE
6748 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6749 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6750
e69dafad
PE
6751 * fileio.c: Don't assume EMACS_INT fits in off_t.
6752 (emacs_lseek): New static function.
6753 (Finsert_file_contents, Fwrite_region): Use it.
6754 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6755
566684ea
PE
6756 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6757
e6966cd6
PE
6758 * fns.c: Don't overflow int when computing a list length.
6759 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6760 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6761 truncation on 64-bit hosts. Check for QUIT every
6762 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6763 faster and is responsive enough.
6764 (Flength): Report an error instead of overflowing an integer.
6765 (Fsafe_length): Return a float if the value is not representable
6766 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 6767 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 6768 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 6769
dd0b0efb
PE
6770 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6771 (header_size, word_size): New constants.
6772 (allocate_vectorlike): Don't check size overflow here.
6773 (allocate_vector): Check it here instead, since this is the only
6774 caller of allocate_vectorlike that could cause overflow.
6775 Check that the new vector's length is representable as a fixnum.
6776
86fe5cfe
PE
6777 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6778 The previous code was bogus. For example, next_almost_prime (32)
6779 returned 39, which is undesirable as it is a multiple of 3; and
6780 next_almost_prime (24) returned 25, which is a multiple of 5 so
6781 why was the code bothering to check for multiples of 7?
6782
80e88859
PE
6783 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6784
4a2f0ad6
PE
6785 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6786
f66c7cf8
PE
6787 Variadic C functions now count arguments with ptrdiff_t.
6788 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6789 Back then I didn't know that the Emacs coding style prefers signed int.
6790 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
6791 were being counted with int, which may truncate counts on 64-bit
6792 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
6793 * lisp.h (struct Lisp_Subr.function.aMANY)
6794 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6795 Arg counts are now ptrdiff_t, not size_t.
6796 All variadic functions and their callers changed accordingly.
6797 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6798 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6799 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6800 * callint.c (Fcall_interactively): Check arg count for overflow,
6801 to avoid potential buffer overrun. Use signed char, not 'int',
6802 for 'varies' array, so that we needn't bother to check its size
6803 calculation for overflow.
6804 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6805 * eval.c (apply_lambda):
6806 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6807 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6808 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6809
a1759b76
PE
6810 * callint.c (Fcall_interactively): Don't use index var as event count.
6811
d96be9fc
PE
6812 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6813 * mem-limits.h (SIZE): Remove; no longer used.
6814
a690a978 6815 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 6816
578c21e6
PE
6817 Remove unnecessary casts.
6818 * xterm.c (x_term_init):
6819 * xfns.c (x_set_border_pixel):
6820 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6821 These aren't needed now that we assume ANSI C.
6822
96f53c6c
PE
6823 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6824 It's more likely to cause problems (due to unsigned overflow)
6825 than to cure them.
6826
83c77d31
PE
6827 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6828
ee2079f1
PE
6829 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6830
6da65536
PE
6831 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6832
7147c4a4
PE
6833 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6834
193e32d9
PE
6835 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6836
e5533da6
PE
6837 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6838
9910e595
PE
6839 GLYPH_CODE_FACE returns EMACS_INT, not int.
6840 * dispextern.h (merge_faces):
6841 * xfaces.c (merge_faces):
01103c44
PE
6842 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6843 Don't assume EMACS_INT fits in int.
9910e595 6844
2638320e
PE
6845 * character.h (CHAR_VALID_P): Remove unused parameter.
6846 * fontset.c, lisp.h, xdisp.c: All uses changed.
6847
045eb8d9
PE
6848 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6849
c1f134b5
PE
6850 * fns.c (concat): Minor tuning based on overflow analysis.
6851 This doesn't fix any bugs. Use int to hold character, instead
6852 of constantly refetching from Emacs object. Use XFASTINT, not
6853 XINT, for value known to be a character. Don't bother comparing
6854 a single byte to 0400, as it's always less.
6855
395fcb93 6856 * floatfns.c (Fexpt):
327eeec8
PE
6857 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6858
abbd3d23
PE
6859 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6860 for characters.
6861
684a03ef
PE
6862 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6863
0fed43f3
PE
6864 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6865 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6866 incorrectly succeed when S was a string, because 4294967386 was
6867 truncated before it was used.
6868
8fd02eb7
PE
6869 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6870 Otherwise, an out-of-range integer could cause undefined behavior
6871 on a 64-bit host.
6872
f8c86b69
PE
6873 * composite.c: Use int, not EMACS_INT, for characters.
6874 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6875 EMACS_INT, for values that are known to be in character range.
6876 This doesn't fix any bugs but is the usual style inside Emacs and
6877 may generate better code on 32-bit machines.
6878
34206dd2
PE
6879 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6880 This is for reasons similar to the recent CHAR_STRING fix.
6881 * charset.c (Fencode_char): Check that character arg is actually
6882 a character. Pass an int to ENCODE_CHAR.
6883 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6884 wider than 'int', as a compile-time check to prevent future regressions
6885 in this area.
6886
c5958d4c 6887 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
6888
6889 Make sure a 64-bit char is never passed to CHAR_STRING.
6890 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6891 by silently ignoring the top 32 bits, allowing some values
6892 that were far too large to be valid characters.
6893 * character.h: Include <verify.h>.
6894 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6895 arguments are no wider than unsigned, as a compile-time check
6896 to prevent future regressions in this area.
6897 * data.c (Faset):
01103c44 6898 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
6899 (Fsubst_char_in_region):
6900 * fns.c (concat):
6901 * xdisp.c (decode_mode_spec_coding):
6902 Adjust to CHAR_STRING's new requirement.
6903 * editfns.c (Finsert_char, Fsubst_char_in_region):
6904 * fns.c (concat): Check that character args are actually
6905 characters. Without this test, these functions did the wrong
6906 thing with wildly out-of-range values on 64-bit hosts.
6907
d37ca623
PE
6908 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6909 These casts should not be needed on 32-bit hosts, either.
6910 * keyboard.c (read_char):
6911 * lread.c (Fload): Remove casts to unsigned.
6912
ea204efb
PE
6913 * lisp.h (UNSIGNED_CMP): New macro.
6914 This fixes comparison bugs on 64-bit hosts.
6915 (ASCII_CHAR_P): Use it.
6916 * casefiddle.c (casify_object):
01103c44 6917 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
6918 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6919 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6920 * dispextern.h (FACE_FROM_ID):
6921 * keyboard.c (read_char): Use UNSIGNED_CMP.
6922
41cb286c
PE
6923 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6924 not to EMACS_INT, to avoid GCC warning.
6925
4a1b9832
PE
6926 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6927
55daad71
PE
6928 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6929 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6930 isn't needed on 32-bit machines.
8f95c75c 6931
01103c44
PE
6932 * buffer.c (Fgenerate_new_buffer_name):
6933 Use EMACS_INT for count, not int.
0ceccced 6934 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
6935
6936 * data.c (Qcompiled_function): Now static.
6937
c6f072e7
PE
6938 * window.c (window_body_lines): Now static.
6939
20ce5912
PE
6940 * image.c (gif_load): Rename local to avoid shadowing.
6941
9c4c5f81
PE
6942 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6943 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6944 * alloc.c (make_save_value): Integer argument is now of type
6945 ptrdiff_t, not int.
6946 (mark_object): Use ptrdiff_t, not int.
6947 * lisp.h (pD): New macro.
6948 * print.c (print_object): Use it.
6949
c0c5c8ae
PE
6950 * alloc.c: Use EMACS_INT, not int, to count objects.
6951 (total_conses, total_markers, total_symbols, total_vector_size)
6952 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
6953 (total_free_floats, total_floats, total_free_intervals)
6954 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
6955 Now EMACS_INT, not int. All uses changed.
6956 (Fgarbage_collect): Compute overall total using a double, so that
6957 integer overflow is less likely to be a problem. Check for overflow
6958 when converting back to an integer.
5a25e253
PE
6959 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6960 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6961 These were 'int' variables that could overflow on 64-bit hosts;
6962 they were never used, so remove them instead of repairing them.
211a0b2a 6963 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
6964 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6965 Previously, this ceilinged at INT_MAX, but that doesn't work on
6966 64-bit machines.
e46bb31a 6967 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 6968
c78baabf 6969 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 6970 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
6971 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6972 when a (possibly-narrower) signed value would do just as well.
6973 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 6974
c9d624c6
PE
6975 * alloc.c: Catch some string size overflows that we were missing.
6976 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6977 for convenience in STRING_BYTES_MAX.
6978 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6979 The definition here is exact; the one in lisp.h was approximate.
6980 (allocate_string_data): Check for string overflow. This catches
6981 some instances we weren't catching before. Also, it catches
6982 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6983 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6984 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 6985
c9d624c6
PE
6986 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6987 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 6988 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 6989
353032ce
PE
6990 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6991
2bccce07
PE
6992 * alloc.c (Fmake_string): Check for out-of-range init.
6993
0ac30604
SM
69942011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6995
6996 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6997
c195f2de
JD
69982011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6999
7000 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7001 xg_get_default_scrollbar_width.
7002
7003 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7004 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7005 (style_changed_cb): Call update_theme_scrollbar_width and call
7006 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7007 all frames (Bug#8505).
7008 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7009 Call gtk_window_set_resizable if HAVE_GTK3.
7010 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7011 and height if HAVE_GTK3 (Bug#8505).
7012 (scroll_bar_width_for_theme): New variable.
7013 (update_theme_scrollbar_width): New function.
7014 (xg_get_default_scrollbar_width): Move code to
7015 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7016 (xg_initialize): Call update_theme_scrollbar_width.
7017
7018 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7019
7020 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7021
e10ac9f1
MR
70222011-06-12 Martin Rudalics <rudalics@gmx.at>
7023
7024 * frame.c (make_frame): Call other_buffer_safely instead of
7025 other_buffer.
7026
7027 * window.c (temp_output_buffer_show): Call display_buffer with
7028 second argument Vtemp_buffer_show_specifiers and reset latter
7029 immediately after the call.
7030 (Vtemp_buffer_show_specifiers): New variable.
7031 (auto_window_vscroll_p, next_screen_context_lines)
7032 (Vscroll_preserve_screen_position): Remove leading asterisks from
7033 doc-strings.
7034
2d3c217e 70352011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7036
7b7f97e8 7037 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7038 * buffer.c (Qclone_number): Remove for now, as it's unused.
7039 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7040 (record_buffer): Remove unused local.
7041 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7042 (set_frame_buffer_list): Remove; unused.
7043 * frame.h (other_visible_frames): Remove decl.
7044 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7045 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7046 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7047 if HAVE_GPM.
7048 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7049 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7050 Define only if HAVE_GPM.
7051 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7052 (update_hints_inhibit): Remove; never set. All uses removed.
7053 * widgetprv.h (emacsFrameClassRec): Remove decl.
7054 * window.c (delete_deletable_window): Now returns void, since it
7055 wasn't returning anything.
7056 (compare_window_configurations): Remove unused locals.
7057 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7058 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7059 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7060 the same widths as pointers. This follows up on the 2011-05-06 patch.
7061 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7062 * xterm.h: Likewise.
7063 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7064
1384b89e
JB
70652011-06-12 Juanma Barranquero <lekktu@gmail.com>
7066
7067 * makefile.w32-in: Update dependencies.
7068 (LISP_H): Add lib/intprops.h.
7069
1100a63c
CY
70702011-06-11 Chong Yidong <cyd@stupidchicken.com>
7071
7072 * image.c (gif_load): Add animation frame delay to the metadata.
7073 (syms_of_image): Use DEFSYM. New symbol `delay'.
7074
6198ccd0
MR
70752011-06-11 Martin Rudalics <rudalics@gmx.at>
7076
7077 * window.c (delete_deletable_window): Re-add.
7078 (Fset_window_configuration): Rewrite to handle dead buffers and
7079 consequently deletable windows.
7080 (window_tree, Fwindow_tree): Remove. Supply functionality in
7081 window.el.
7082 (compare_window_configurations): Simplify code.
7083
b6e3633c
AS
70842011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7085
1ab0dee5
AS
7086 * image.c (imagemagick_load_image): Fix type mismatch.
7087 (Fimagemagick_types): Likewise.
7088
b6e3633c
AS
7089 * window.h (replace_buffer_in_windows): Declare.
7090
9397e56f
MR
70912011-06-11 Martin Rudalics <rudalics@gmx.at>
7092
7093 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7094 Qclone_number. Remove external declaration of Qdelete_window.
7095 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7096 code.
640c8776
SM
7097 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7098 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7099 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7100 buffer list implementation.
7101 (other_buffer_safely): New function.
7102 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7103 calls to replace_buffer_in_windows and
7104 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7105 if allowed.
7106 (record_buffer): Inhibit quitting and rewrite using quittable
7107 functions. Run Qbuffer_list_update_hook if allowed.
7108 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7109 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7110 Move switch-to-buffer to window.el.
9397e56f
MR
7111 (bury-buffer): Move to window.el.
7112 (Vbuffer_list_update_hook): New variable.
7113
7114 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7115 section.
7116
7117 * window.h (resize_frame_windows): Move up in code.
7118 (Fwindow_frame): Remove EXFUN.
7119 (replace_buffer_in_all_windows): Remove prototype.
7120 (replace_buffer_in_windows_safely): Add prototype.
7121
7122 * window.c: Declare Qdelete_window static again. Move down
7123 declaration of select_count.
7124 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7125 (Fother_window): Move to window.el.
7126 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7127 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7128 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7129 window.el.
7130 (replace_buffer_in_windows): Implement by calling
7131 Qreplace_buffer_in_windows.
7132 (replace_buffer_in_all_windows): Remove with some functionality
7133 moved into replace_buffer_in_windows_safely.
7134 (replace_buffer_in_windows_safely): New function.
7135 (select_window_norecord, select_frame_norecord): Move in front
7136 of run_window_configuration_change_hook. Remove now obsolete
7137 declarations.
640c8776
SM
7138 (Fset_window_buffer): Rewrite doc-string.
7139 Call Qrecord_window_buffer.
9397e56f
MR
7140 (keys_of_window): Move binding for other-window to window.el.
7141
b50691aa
CY
71422011-06-11 Chong Yidong <cyd@stupidchicken.com>
7143
7144 * dispextern.h (struct image): Replace data member, whose int_val
7145 and ptr_val fields were not used by anything, with a single
7146 lisp_val object.
7147
7148 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7149 (gif_clear_image, gif_load, imagemagick_load_image)
7150 (gs_clear_image, gs_load): Callers changed.
7151
3f754b86
PE
71522011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7153
cca69397
PE
7154 * buffer.h: Include <time.h>, for time_t.
7155 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7156
109e28d0
PE
7157 Fix minor problems found by static checking.
7158
60737f02
PE
7159 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7160
4b66faf3
PE
7161 Make identifiers static if they are not used in other modules.
7162 * data.c (Qcompiled_function, Qframe, Qvector):
7163 * image.c (QimageMagick, Qsvg):
7164 * minibuf.c (Qmetadata):
7165 * window.c (resize_window_check, resize_root_window): Now static.
7166 * window.h (resize_window_check, resize_root_window): Remove decls.
7167
109e28d0
PE
7168 * window.c (window_deletion_count, delete_deletable_window):
7169 Remove; unused.
46a4ce9e
PE
7170 (window_body_lines): Now static.
7171 (Fdelete_other_windows_internal): Mark vars as initialized.
7172 Make sure 'resize_failed' is initialized.
7173 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7174 (resize_window_apply): Remove unused local.
7175 * window.h (delete_deletable_window): Remove decl.
7176
109e28d0 7177 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7178 (imagemagick_load_image): Fix pointer signedness problem by changing
7179 last arg from unsigned char * to char *. All uses changed.
7180 Also, fix a local for similar reasons.
7181 Remove unused locals. Remove locals to avoid shadowing.
7182 (fn_rsvg_handle_free): Remove; unused.
7183 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7184 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7185
3f754b86
PE
7186 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7187
2547adb1
CY
71882011-06-10 Chong Yidong <cyd@stupidchicken.com>
7189
7190 * image.c (gif_load): Fix omitted cast error introduced by
7191 2011-06-06 change.
7192
2c8e37d4
MR
71932011-06-10 Martin Rudalics <rudalics@gmx.at>
7194
7195 * window.h (resize_proportionally, orig_total_lines)
7196 (orig_top_line): Remove from window structure.
7197 (set_window_height, set_window_width, change_window_heights)
7198 (Fdelete_window): Remove prototypes.
7199 (resize_frame_windows): Remove duplicate declaration.
7200
440a42e3
EZ
72012011-06-10 Eli Zaretskii <eliz@gnu.org>
7202
7203 * window.h (resize_frame_windows, resize_window_check)
7204 (delete_deletable_window, resize_root_window)
7205 (resize_frame_windows): Declare prototypes.
7206
7207 * window.c (resize_window_apply): Make definition be "static" to
7208 match the prototype.
7209
562dd5e9
MR
72102011-06-10 Martin Rudalics <rudalics@gmx.at>
7211
7212 * window.c: Remove declarations of Qwindow_size_fixed,
7213 window_min_size_1, window_min_size_2, window_min_size,
7214 size_window, window_fixed_size_p, enlarge_window, delete_window.
7215 Remove static from declaration of Qdelete_window, it's
7216 temporarily needed by Fbury_buffer.
7217 (replace_window): Don't assign orig_top_line and
7218 orig_total_lines.
7219 (Fdelete_window, delete_window): Remove. Window deletion is
7220 handled by window.el.
640c8776
SM
7221 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7222 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7223 (Fdelete_other_windows): Remove. Deleting other windows is
7224 handled by window.el.
7225 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7226 handled in window.el.
7227 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7228 Window minimum sizes are handled in window.el.
7229 (shrink_windows, size_window, set_window_height)
7230 (set_window_width, change_window_heights, window_height)
7231 (window_width, CURBEG, CURSIZE, enlarge_window)
7232 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7233 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7234 handled in window.el.
7235 (make_dummy_parent): Rename to make_parent_window and give it a
7236 second argument horflag.
7237 (make_window): Don't set resize_proportionally any more.
7238 (Fsplit_window): Remove. Windows are split in window.el.
7239 (save_restore_action, save_restore_orig_size)
7240 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7241 Resize mini windows in window.el.
7242 (grow_mini_window, shrink_mini_window): Implement by calling
7243 Qresize_root_window_vertically, resize_window_check and
7244 resize_window_apply.
640c8776
SM
7245 (saved_window, Fset_window_configuration, save_window_save):
7246 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7247 resize_proportionally.
7248 (window_min_height, window_min_width): Move to window.el.
7249 (keys_of_window): Move bindings for delete-other-windows,
7250 split-window, delete-window and enlarge-window to window.el.
7251
7252 * buffer.c: Temporarily extern Qdelete_window.
7253 (Fbury_buffer): Temporarily call Qdelete_window instead of
7254 Fdelete_window (Fbury_buffer will move to window.el soon).
7255
7256 * frame.c (set_menu_bar_lines_1): Remove code handling
7257 orig_top_line and orig_total_lines.
7258
7259 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7260 set_window_height but set heights directly.
7261 (change_frame_size_1): Use resize_frame_windows.
7262
7263 * xdisp.c (init_xdisp): Don't use set_window_height but set
7264 heights directly.
7265
640c8776
SM
7266 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7267 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7268 run_window_configuration_change_hook.
7269
7270 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7271 instead of change_window_heights and run
7272 run_window_configuration_change_hook.
7273
1a13852e
MR
72742011-06-09 Martin Rudalics <rudalics@gmx.at>
7275
7276 * window.c (replace_window): Rename second argument REPLACEMENT to
7277 NEW. New third argument SETFLAG. Rewrite.
7278 (delete_window, make_dummy_parent): Call replace_window with
7279 third argument 1.
7280 (window_list_1): Move down in code.
7281 (run_window_configuration_change_hook): Move set_buffer part
7282 before select_frame_norecord part in order to unwind correctly.
7283 Rename count1 to count.
7284 (recombine_windows, delete_deletable_window, resize_root_window)
7285 (Fdelete_other_windows_internal)
7286 (Frun_window_configuration_change_hook, make_parent_window)
7287 (resize_window_check, resize_window_apply, Fresize_window_apply)
7288 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7289 (Fdelete_window_internal, Fresize_mini_window_internal):
7290 New functions.
1a13852e
MR
7291 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7292
f3d1777e
MR
72932011-06-08 Martin Rudalics <rudalics@gmx.at>
7294
496e208e
MR
7295 * window.h (window): Add some new members to window structure -
7296 normal_lines, normal_cols, new_total, new_normal, clone_number,
7297 splits, nest, prev_buffers, next_buffers.
7298 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7299 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7300
f3d1777e
MR
7301 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7302 Remove.
496e208e
MR
7303 (make_dummy_parent): Set new members of windows structure.
7304 (make_window): Move down in code. Handle new members of window
7305 structure.
7306 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7307 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7308 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7309 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7310 (Fset_window_next_buffers, Fset_window_clone_number):
7311 New functions.
496e208e
MR
7312 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7313 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7314 Doc-string fixes.
7315 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7316 Argument WINDOW can be now internal window too.
7317 (Fwindow_use_time): Move up in code.
7318 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7319 Rewrite doc-string.
7320 (Fset_window_configuration, saved_window)
7321 (Fcurrent_window_configuration, save_window_save): Handle new
7322 members of window structure.
b9e809c2
MR
7323 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7324 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7325 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7326 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7327 Qget_mru_window, Qresize_root_window,
7328 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7329 Qauto_buffer_name; staticpro them.
f3d1777e 7330
abde8f8c
MR
73312011-06-07 Martin Rudalics <rudalics@gmx.at>
7332
7333 * window.c (Fwindow_total_size, Fwindow_left_column)
7334 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7335 (Fwindow_list_1): New functions.
7336 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7337 (Fwindow_width, Fscroll_left, Fscroll_right):
7338 Use window_body_cols instead of window_box_text_cols.
7339 (delete_window, Fset_window_configuration):
7340 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7341 (delete_all_subwindows): Take a window as argument and not a
7342 structure. Rewrite.
190b47e6
MR
7343 (window_loop): Remove handling of GET_LRU_WINDOW and
7344 GET_LARGEST_WINDOW.
7345 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7346
7347 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7348 window_box_text_cols. delete_all_subwindows now takes a
7349 Lisp_Object as argument.
abde8f8c 7350
640c8776
SM
7351 * indent.c (compute_motion, Fcompute_motion):
7352 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7353
fa8a67e6
MR
7354 * frame.c (delete_frame): Call delete_all_subwindows with root
7355 window as argument.
7356
a54e3482
DC
73572011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7358
7359 * fns.c (Fputhash): Document return value.
7360
60002bf5
CY
73612011-06-06 Chong Yidong <cyd@stupidchicken.com>
7362
7363 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7364
0c671da6 73652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7366
b862a52a 7367 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7368
be44ca6c
PE
7369 Check for overflow when converting integer to cons and back.
7370 * charset.c (Fdefine_charset_internal, Fdecode_char):
7371 Use cons_to_unsigned to catch overflow.
7372 (Fencode_char): Use INTEGER_TO_CONS.
7373 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7374 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7375 * data.c (long_to_cons, cons_to_long): Remove.
7376 (cons_to_unsigned, cons_to_signed): New functions.
7377 These signal an error for invalid or out-of-range values.
7378 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7379 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7380 * font.c (Ffont_variation_glyphs):
7381 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7382 * lisp.h: Include <intprops.h>.
7383 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7384 (cons_to_signed, cons_to_unsigned): New decls.
7385 (long_to_cons, cons_to_long): Remove decls.
7386 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7387 (Fprimitive_undo): Use CONS_TO_INTEGER.
7388 * xfns.c (Fx_window_property): Likewise.
7389 * xselect.c: Include <limits.h>.
7390 (x_own_selection, selection_data_to_lisp_data):
7391 Use INTEGER_TO_CONS.
7392 (x_handle_selection_request, x_handle_selection_clear)
7393 (x_get_foreign_selection, Fx_disown_selection_internal)
7394 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7395 (lisp_data_to_selection_data): Use cons_to_unsigned.
7396 (x_fill_property_data): Use cons_to_signed.
7397 Report values out of range.
7398
d1f3d2af
PE
7399 Check for buffer and string overflow more precisely.
7400 * buffer.h (BUF_BYTES_MAX): New macro.
7401 * lisp.h (STRING_BYTES_MAX): New macro.
7402 * alloc.c (Fmake_string):
7403 * character.c (string_escape_byte8):
7404 * coding.c (coding_alloc_by_realloc):
7405 * doprnt.c (doprnt):
7406 * editfns.c (Fformat):
7407 * eval.c (verror):
7408 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7409 since they may not be the same number.
7410 * editfns.c (Finsert_char):
7411 * fileio.c (Finsert_file_contents):
7412 Likewise for BUF_BYTES_MAX.
7413
dd52fcea
PE
7414 * image.c: Use ptrdiff_t, not int, for sizes.
7415 (slurp_file): Switch from int to ptrdiff_t.
7416 All uses changed.
7417 (slurp_file): Check that file size fits in both size_t (for
7418 malloc) and ptrdiff_t (for sanity and safety).
7419
7f9bbdbb
PE
7420 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7421 if b->modtime has its maximal value.
7422
dfe18f82
PE
7423 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7424
84acfcf0
PE
7425 Don't assume time_t can fit into int.
7426 * buffer.h (struct buffer.modtime): Now time_t, not int.
7427 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7428 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7429
ccd9a01a
PE
7430 Minor fixes for signed vs unsigned integers.
7431 * character.h (MAYBE_UNIFY_CHAR):
7432 * charset.c (maybe_unify_char):
7433 * keyboard.c (read_char, reorder_modifiers):
7434 XINT -> XFASTINT, since the integer must be nonnegative.
7435 * ftfont.c (ftfont_spec_pattern):
7436 * keymap.c (access_keymap, silly_event_symbol_error):
7437 XUINT -> XFASTINT, since the integer must be nonnegative.
7438 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7439 since it makes no difference and we prefer signed.
7440 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7441 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7442 nonnegative.
7443
d6d100dd
SM
74442011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7445
7446 * window.h (Fwindow_frame): Declare.
7447
2b6148e4
PE
74482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7449
7450 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7451 (SPARE_MEMORY): Always define.
7452 (LARGE_REQUEST): Remove.
7453 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7454
f230ecc9
MR
74552011-06-06 Martin Rudalics <rudalics@gmx.at>
7456
727e958e
MR
7457 * lisp.h: Move EXFUNS for Fframe_root_window,
7458 Fframe_first_window and Fset_frame_selected_window to window.h.
7459
7460 * window.h: Move EXFUNS for Fframe_root_window,
7461 Fframe_first_window and Fset_frame_selected_window here from
7462 lisp.h.
7463
7464 * frame.c (Fwindow_frame, Fframe_first_window)
7465 (Fframe_root_window, Fframe_selected_window)
7466 (Fset_frame_selected_window): Move to window.c.
7467 (Factive_minibuffer_window): Move to minibuf.c.
7468 (Fother_visible_frames_p): New function.
7469
7470 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7471
f230ecc9
MR
7472 * window.c (decode_window, decode_any_window): Move up in code.
7473 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7474 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7475 (Fwindow_buffer): Move up and rewrite doc-string.
7476 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7477 (Fwindow_prev): New functions.
727e958e
MR
7478 (Fwindow_frame): Move here from frame.c. Accept any window as
7479 argument.
7480 (Fframe_root_window, Fframe_first_window)
7481 (Fframe_selected_window): Move here from frame.c. Accept frame
7482 or arbitrary window as argument. Update doc-strings.
7483 (Fminibuffer_window): Move up in code.
7484 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7485 (Fset_frame_selected_window): Move here from frame.c.
7486 Marginal rewrite.
727e958e
MR
7487 (Fselected_window, select_window, Fselect_window): Move up in
7488 code. Minor doc-string fixes.
f230ecc9 7489
4d09bcf6
PE
74902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7491
7492 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7493 Do not assume that spare memory exists; that assumption is valid
7494 only if SYSTEM_MALLOC.
7495 (LARGE_REQUEST): New macro, so that the issue of large requests
7496 is separated from the issue of spare memory.
7497
810928a2
AS
74982011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7499
172418ad
AS
7500 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7501 format. (Bug#8806)
7502
43f862f7
AS
7503 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7504
810928a2
AS
7505 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7506 before statements.
7507
a059fe24
JD
75082011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7509
7510 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7511
7512 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7513
7514 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7515 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7516
989bf368
JB
75172011-06-05 Juanma Barranquero <lekktu@gmail.com>
7518
7519 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7520
4b80f674
CY
75212011-06-04 Chong Yidong <cyd@stupidchicken.com>
7522
7523 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7524 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7525 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7526 New error handlers.
4b80f674
CY
7527 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7528 Obey Vx_select_enable_clipboard_manager. Catch errors in
7529 x_clipboard_manager_save (Bug#8779).
7530 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7531 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7532
99a33b77 75332011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7534
7535 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7536
99a33b77 75372011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7538
7539 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7540 in the current matrix if keep_current_p is non-zero.
7541
8264569d
EZ
75422011-06-04 Eli Zaretskii <eliz@gnu.org>
7543
7544 * bidi.c (bidi_level_of_next_char): Fix last change.
7545
57f97249
EZ
75462011-06-03 Eli Zaretskii <eliz@gnu.org>
7547
fec2107c 7548 Support bidi reordering of text covered by display properties.
57f97249 7549
fec2107c
EZ
7550 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7551 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7552 (bidi_cache_search, bidi_cache_iterator_state)
7553 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7554 (bidi_level_of_next_char, bidi_move_to_visually_next):
7555 Support character positions inside a run of characters covered by a
fec2107c
EZ
7556 display string.
7557 (bidi_paragraph_init, bidi_resolve_explicit_1)
7558 (bidi_level_of_next_char): Call bidi_fetch_char and
7559 bidi_fetch_char_advance instead of FETCH_CHAR and
7560 FETCH_CHAR_ADVANCE.
7561 (bidi_init_it): Initialize new members.
7562 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7563 definitions.
7564 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7565 instead of using explicit *_CHAR codes.
d6d100dd
SM
7566 (bidi_resolve_explicit, bidi_resolve_weak):
7567 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7568 bidirectional text is supported only in multibyte buffers.
7569 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7570 it to initialize the frame_window_p member of struct bidi_it.
7571 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7572 (bidi_resolve_explicit, bidi_resolve_weak)
7573 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7574 bidi_it->nchars is non-positive.
7575 (bidi_level_of_next_char): Don't try to lookup the cache for the
7576 next/previous character if nothing is cached there yet, or if we
7577 were just reseat()'ed to a new position.
c40e2fb2 7578
0e14fe90
EZ
7579 * xdisp.c (set_cursor_from_row): Set start and stop points
7580 according to the row's direction when priming the loop that looks
7581 for the glyph on which to display cursor.
7582 (single_display_spec_intangible_p): Function deleted.
7583 (display_prop_intangible_p): Reimplement to call
7584 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7585 Accept 3 additional arguments needed by handle_display_spec.
7586 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7587 values: lists, `(when COND...)' forms, etc.
7588 (single_display_spec_string_p): Support property values that are
7589 lists with the argument STRING its top-level element.
7590 (display_prop_string_p): Fix the condition for processing a
7591 property that is a list to be consistent with handle_display_spec.
fec2107c 7592 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7593 last portion of handle_display_prop.
7594 (compute_display_string_pos): Accept additional argument
7595 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7596 value of a `display' property is a "replacing spec".
7597 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7598 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7599 the display property, but just return a value indicating whether
7600 the display property will replace the characters it covers.
7601 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7602 frame_window_p members of struct bidi_it.
d6d100dd
SM
7603 (compute_display_string_pos, compute_display_string_end):
7604 New functions.
fec2107c
EZ
7605 (push_it): Accept second argument POSITION, where pop_it should
7606 jump to continue iteration.
7607 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7608
fec2107c
EZ
7609 * keyboard.c (adjust_point_for_property): Adjust the call to
7610 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7611
7612 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7613 (bidi_init_it): Update prototypes.
7614 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7615 (compute_display_string_pos, compute_display_string_end):
7616 Declare prototypes.
fec2107c
EZ
7617 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7618 EMACS_INT.
fc6f18ce 7619
40087514 76202011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7621
57f53182
PE
7622 Malloc failure behavior now depends on size of allocation.
7623 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7624 * lisp.h: Change signatures accordingly.
7625 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7626 All callers changed. (Bug#8762)
7627
7628 * gnutls.c: Use Emacs's memory allocators.
7629 Without this change, the gnutls library would invoke malloc etc.
7630 directly, which causes problems on non-SYNC_INPUT hosts, and which
7631 runs afoul of improving memory_full behavior. (Bug#8761)
7632 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7633 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7634 xfree instead of the default malloc, realloc, free.
7635 (Fgnutls_boot): No need to check for memory allocation failure,
7636 since xmalloc does that for us.
7637
ac32cd99 7638 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7639 * category.c (hash_get_category_set):
7640 * ccl.c (ccl_driver):
7641 * charset.c (Fdefine_charset_internal):
7642 * charset.h (struct charset.hash_index):
7643 * composite.c (get_composition_id, gstring_lookup_cache)
7644 (composition_gstring_put_cache):
7645 * composite.h (struct composition.hash_index):
7646 * dispextern.h (struct image.hash):
7647 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7648 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7649 (hashfn_equal, hashfn_user_defined, make_hash_table)
7650 (maybe_resize_hash_table, hash_lookup, hash_put)
7651 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7652 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7653 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7654 * image.c (make_image, search_image_cache, lookup_image)
7655 (xpm_put_color_table_h):
7656 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7657 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7658 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7659 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7660 * alloc.c (allocate_vectorlike):
7661 Check for overflow in vector size calculations.
7662 * ccl.c (ccl_driver):
7663 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7664 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7665 need to be updated by these changes.
40087514
PE
7666 * fns.c (make_hash_table, maybe_resize_hash_table):
7667 Check for integer overflow with large hash tables.
0de4bb68
PE
7668 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7669 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7670 (SXHASH_REDUCE): New macro.
7671 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7672 Use it instead of discarding useful hash info with large hash values.
7673 (sxhash_float): New function.
7674 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7675 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7676 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7677 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7678 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7679 Adjust signatures to match updated version of code.
7680 (consing_since_gc): Now EMACS_INT, since a single hash table can
7681 use more than INT_MAX bytes.
7682
698d32e2
DN
76832011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7684
7685 Make it possible to build with GCC-4.6+ -O2 -flto.
7686
7687 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7688
fd6fa53f
SM
76892011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7690
7691 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7692 Call minibuffer-inactive-mode.
7693
864db017
JB
76942011-05-31 Juanma Barranquero <lekktu@gmail.com>
7695
7696 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7697 Update dependencies.
7698
2ad0baf4
DN
76992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7700
7701 * data.c (init_data): Remove code for UTS, this system is not
7702 supported anymore.
7703
4fcc2638
DN
77042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7705
7706 Don't force ./temacs to start in terminal mode.
7707
7708 * frame.c (make_initial_frame): Initialize faces in all cases, not
7709 only when CANNOT_DUMP is defined.
7710 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7711
c56e0fd5
DN
77122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7713
7714 * dispnew.c (add_window_display_history): Use const for the string
7715 pointer. Remove declaration, not needed.
7716
333d54da 77172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 7718
55d4c1b2 7719 Use 'inline', not 'INLINE'.
333d54da 7720 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
7721 * alloc.c, fontset.c (INLINE): Remove.
7722 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7723 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7724 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7725 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7726 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7727
738db178
DN
77282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7729
7730 Make it possible to run ./temacs.
7731
7732 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7733 syms_of_callproc does the same thing. Remove test for
7734 "initialized", do it in the caller.
7735 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7736
620c53a6
SM
77372011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7738
7739 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7740 (read_minibuf): Use get_minibuffer.
7741 (syms_of_minibuf): Use DEFSYM.
7742 (Qmetadata): New var.
7743 * data.c (Qbuffer): Don't make it static.
7744 (syms_of_data): Use DEFSYM.
7745
e003a292
PE
77462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7747
7748 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7749 (CCL_CODE_MIN): New macro.
7750
ed008a6d
PE
77512011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7752
3687c2ef
PE
7753 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7754
ed008a6d
PE
7755 * eval.c (Qdebug): Now static.
7756 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7757 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7758 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7759
d66c4c7c
CY
77602011-05-29 Chong Yidong <cyd@stupidchicken.com>
7761
7762 * image.c: Various fixes to ImageMagick code comments.
7763 (Fimagemagick_types): Doc fix.
7764
5fbc2025
PE
77652011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7766
0196f88a
PE
7767 Minor fixes prompted by GCC 4.6.0 warnings.
7768
7769 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7770
5fbc2025
PE
7771 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7772 (x_clipboard_manager_save_all): Move extern decl to ...
7773 * xterm.h: ... here, so that it can be checked for consistency.
7774
1dd3c2d9
CY
77752011-05-29 Chong Yidong <cyd@stupidchicken.com>
7776
7777 * xselect.c (x_clipboard_manager_save_frame)
7778 (x_clipboard_manager_save_all): New functions.
7779 (Fx_clipboard_manager_save): Lisp function deleted.
7780
7781 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7782 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7783
7784 * xterm.h: Update prototype.
7785
5ba6571d
WX
77862011-05-28 William Xu <william.xwl@gmail.com>
7787
7788 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7789 exiting (Bug#8239).
7790
3eaff834
JM
77912011-05-28 Jim Meyering <meyering@redhat.com>
7792
e1900994 7793 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
7794 * fns.c (to_uchar): Define.
7795 (crypto_hash_function): Use it to convert some newly-signed
7796 variables to unsigned, to avoid sign-extension bugs. For example,
7797 without this change, (md5 "truc") would evaluate to
7798 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7799 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 7800 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 7801
0f6990a7
PE
78022011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7803
7804 Integer overflow fixes.
c8a9ca5a 7805
08686060
PE
7806 * dbusbind.c: Serial number integer overflow fixes.
7807 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
7808 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7809 to hold a serial number that is too large for a fixnum.
7810 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7811 Check for serial numbers out of range. Decode any serial number
59568bf0 7812 that was so large that it became a float. (Bug#8722)
08686060 7813
2d1fc3c7
PE
7814 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7815 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7816 Use XFASTINT rather than XUINT when numbers are nonnegative.
7817 (xd_append_arg, Fdbus_method_return_internal):
7818 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7819 arguments, check that Lisp number is nonnegative, rather than
59568bf0 7820 silently wrapping negative numbers around. (Bug#8722)
30217ff0 7821 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 7822 (Bug#8722)
2d1fc3c7 7823
c8a9ca5a
PE
7824 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7825
519e1d69
PE
7826 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7827
6df6ae42 7828 ccl: Add integer overflow checks.
30569699
PE
7829 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7830 (IN_INT_RANGE): New macros.
7831 (ccl_driver): Use them to check for integer overflow when
7832 decoding a CCL program. Many of the new checks are whether XINT (x)
7833 fits in int; it doesn't always, on 64-bit hosts. The new version
7834 doesn't catch all possible integer overflows, but it's an
847044ea 7835 improvement. (Bug#8719)
30569699 7836
c11285dc
PE
7837 * alloc.c (make_event_array): Use XINT, not XUINT.
7838 There's no need for unsigned here.
7839
fdccd48e
PE
7840 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7841 This follows up to the 2011-05-06 change that substituted uintptr_t
7842 for EMACS_INT. This case wasn't caught back then.
7843
37910ab2
PE
7844 Rework Fformat to avoid integer overflow issues.
7845 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7846 now (part of C89). Include <verify.h>.
7847 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7848 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7849 (Fformat): Avoid the prepass trying to compute sizes; it was only
7850 approximate and thus did not catch overflow reliably. Instead, walk
7851 through the format just once, formatting and computing sizes as we go,
7852 checking for integer overflow at every step, and allocating a larger
7853 buffer as needed. Keep track separately whether the format is
7854 multibyte. Keep only the most-recently calculated precision, rather
7855 than them all. Record whether each argument has been converted to
7856 string. Use EMACS_INT, not int, for byte and char and arg counts.
7857 Support field widths and precisions larger than INT_MAX. Avoid
7858 sprintf's undefined behavior with conversion specifications such as %#d
7859 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7860 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7861 formatting out-of-range floating point numbers with int
9173deec 7862 formats. (Bug#8668)
37910ab2 7863
2e6578fb
PE
7864 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7865
0ae6bdee
PE
7866 * data.c: Avoid integer truncation in expressions involving floats.
7867 * data.c: Include <intprops.h>.
7868 (arith_driver): When there's an integer overflow in an expression
7869 involving floating point, convert the integers to floating point
7870 so that the resulting value does not suffer from catastrophic
7871 integer truncation. For example, on a 64-bit host (* 4
7872 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7873 Do not rely on undefined behavior after integer overflow.
7874
de883a70
PE
7875 merge count_size_as_multibyte, parse_str_to_multibyte
7876 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 7877 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
7878 Check for integer overflow.
7879 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7880 since it's now a duplicate of the other. This is more of
7881 a character than a buffer op, so better that it's in character.c.
7882 * fns.c, print.c: Adjust to above changes.
7883
2ff916cb
PE
78842011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7885
7886 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7887
f1b54466
PE
78882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7889
fb1ac845
PE
7890 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7891 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7892 (x_clipboard_manager_save): Now static.
7893 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7894
f1b54466
PE
7895 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7896 (crypto_hash_function): Now static.
7897 Fix pointer signedness problems. Avoid unnecessary initializations.
7898
a9f737ee
CY
78992011-05-27 Chong Yidong <cyd@stupidchicken.com>
7900
7901 * termhooks.h (Vselection_alist): Make it terminal-local.
7902
7903 * terminal.c (create_terminal): Initialize it.
7904
7905 * xselect.c: Support for clipboard managers.
7906 (Vselection_alist): Move to termhooks.h as terminal-local var.
7907 (LOCAL_SELECTION): New macro.
7908 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7909 (symbol_to_x_atom): Remove gratuitous arg.
7910 (x_handle_selection_request, lisp_data_to_selection_data)
7911 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
7912 (x_own_selection, x_get_local_selection, x_convert_selection):
7913 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
7914 (some_frame_on_display): Delete unused function.
7915 (Fx_own_selection_internal, Fx_get_selection_internal)
7916 (Fx_disown_selection_internal, Fx_selection_owner_p)
7917 (Fx_selection_exists_p): New optional frame arg.
7918 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7919 (x_handle_selection_clear): Don't treat other terminals with the
7920 same keyboard specially. Use the terminal-local Vselection_alist.
7921 (x_clear_frame_selections): Use Frun_hook_with_args.
7922
7923 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7924
7925 * xterm.h: Add support for those atoms.
7926
e067f0c1
CY
79272011-05-26 Chong Yidong <cyd@stupidchicken.com>
7928
7929 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7930 (converted_selections, conversion_fail_tag): New global variables.
7931 (x_selection_request_lisp_error): Free the above.
7932 (x_get_local_selection): Remove unnecessary code.
7933 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
7934 of converted selections stored in converted_selections.
7935 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
7936 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7937 (x_convert_selection): New function.
7938 (x_handle_selection_event): Simplify.
7939 (x_get_foreign_selection): Don't ignore incoming requests while
7940 waiting for an answer; this will fail when we implement
7941 SAVE_TARGETS, and seems unnecessary anyway.
7942 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7943 (Vx_sent_selection_functions): Doc fix.
7944
0f4aebc0
LL
79452011-05-26 Leo Liu <sdl.web@gmail.com>
7946
7947 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7948
e61124cd
YM
79492011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7950
7951 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7952
7953 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7954 for fringe update if it has periodic bitmap.
ac389d0c 7955 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
7956 and fringe_bitmap_periodic_p.
7957
7958 * fringe.c (get_fringe_bitmap_data): New function.
7959 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7960 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7961 row. Mark glyph row for fringe update if periodicity changed.
7962
7963 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7964 for fringe update unless it has periodic bitmap.
7965
f16d9837
KH
79662011-05-25 Kenichi Handa <handa@m17n.org>
7967
7968 * xdisp.c (get_next_display_element): Set correct it->face_id for
7969 a static composition.
7970
e1b90ef6
LL
79712011-05-24 Leo Liu <sdl.web@gmail.com>
7972
7973 * deps.mk (fns.o):
7974 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7975
7976 * fns.c (crypto_hash_function, Fsha1): New function.
7977 (Fmd5): Use crypto_hash_function.
7978 (syms_of_fns): Add Ssha1.
7979
7400048f
PE
79802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7981
7982 * gnutls.c: Remove unused macros.
7983 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7984 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7985 Remove macros that are defined and never used.
7986 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7987
abb71cf4
CY
79882011-05-22 Chong Yidong <cyd@stupidchicken.com>
7989
7990 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7991 (Fx_get_selection_internal): Minor cleanup.
7992 (Fx_own_selection_internal): Rename arguments for consistency with
7993 select.el.
7994
6307db39
PE
79952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7996
7997 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7998
f3d4e0a4
CY
79992011-05-22 Chong Yidong <cyd@stupidchicken.com>
8000
8001 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8002
4d8ade89
YM
80032011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8004
8005 * dispnew.c (scrolling_window): Don't exclude the case that the
8006 last enabled row in the desired matrix touches the bottom boundary.
8007
32078c8d
GM
80082011-05-21 Glenn Morris <rgm@gnu.org>
8009
8010 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8011 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8012 and add some more files.
32078c8d 8013
7285dc67
EZ
80142011-05-20 Eli Zaretskii <eliz@gnu.org>
8015
8016 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8017 report_file_error introduced by the change from 2011-05-07.
8018
89d1bd22
PE
80192011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8020
8021 * systime.h (Time): Define only if emacs is defined.
8022 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8023 where the include path doesn't have X11/X.h by default. See
8024 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8025
cd394be1 80262011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8027
8028 * composite.c (find_automatic_composition): Fix previous change.
8029
b9704ad9
GM
80302011-05-20 Glenn Morris <rgm@gnu.org>
8031
8032 * lisp.mk: New file, split from Makefile.in.
8033 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8034 (shortlisp): Remove.
8035 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8036
4a720484
GM
80372011-05-19 Glenn Morris <rgm@gnu.org>
8038
8039 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8040 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8041 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8042 (lisp): Set the order to that of loadup.el.
8043 (shortlisp): Make it a copy of $lisp.
8044 (SOME_MACHINE_LISP): Remove.
8045 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8046 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8047
a28d4396
KH
80482011-05-18 Kenichi Handa <handa@m17n.org>
8049
8050 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8051 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8052 (find_automatic_composition): Mostly rewrite for efficiency.
8053
a2b1fa8e
JB
80542011-05-18 Juanma Barranquero <lekktu@gmail.com>
8055
8056 * makefile.w32-in: Update dependencies.
8057
8e1f5610
CS
80582011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8059
8060 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8061 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8062
7025ee00 80632011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8064
cdfa6eab
PE
8065 Fix some integer overflow issues, such as string length overflow.
8066
06d6db33
PE
8067 * insdel.c (count_size_as_multibyte): Check for string overflow.
8068
2b4560a8
PE
8069 * character.c (lisp_string_width): Check for string overflow.
8070 Use EMACS_INT, not int, for string indexes and lengths; in
8071 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8072 the resulting string length overflows an EMACS_INT; instead,
8073 report a string overflow if no precision given. When checking for
8074 precision exhaustion, use a check that cannot possibly have
8075 integer overflow. (Bug#8675)
8076 * character.h (lisp_string_width): Adjust to new signature.
8077
cb93f9be
PE
8078 * alloc.c (string_overflow): New function.
8079 (Fmake_string): Use it. This doesn't change behavior, but saves
8080 a few bytes and will simplify future changes.
8081 * character.c (string_escape_byte8): Likewise.
8082 * lisp.h (string_overflow): New decl.
8083
1a1f3366
PE
8084 Fixups, following up to the user-interface timestamp change.
8085 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8086 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8087 * msdos.c (mouse_get_pos): Likewise.
8088 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8089 * w32gui.h (Time): Define by including "systime.h" rather than by
8090 declaring it ourselves. (Bug#8664)
8091
d4e3e4d3
PE
8092 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8093 * image.c (clear_image_cache): Likewise.
8094
f6a24d19
PE
8095 * term.c (term_mouse_position): Don't assume time_t wraparound.
8096
08dc5ae6
PE
8097 Be more systematic about user-interface timestamps.
8098 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8099 and sometimes 'EMACS_UINT', to represent these timestamps.
8100 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8101 This makes the code easier to follow, and makes it easier to catch
8102 integer overflow bugs such as Bug#8664.
8103 * frame.c (Fmouse_position, Fmouse_pixel_position):
8104 Use Time, not unsigned long, for user-interface timestamps.
8105 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8106 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8107 * keyboard.h (last_event_timestamp): Likewise.
8108 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8109 * menu.h (xmenu_show): Likewise.
8110 * term.c (term_mouse_position): Likewise.
8111 * termhooks.h (struct input_event.timestamp): Likewise.
8112 (struct terminal.mouse_position_hook): Likewise.
8113 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8114 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8115 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8116 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8117 what it was before.
8118 * menu.h, termhooks.h: Include "systime.h", for Time.
8119
8e55734a
PE
8120 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8121 Don't assume that the difference between two unsigned long values
8122 can fit into an integer. At this point, we know button_down_time
8123 <= event->timestamp, so the difference must be nonnegative, so
8124 there's no need to cast the result if double-click-time is
8125 nonnegative, as it should be; check that it's nonnegative, just in
8126 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8127 apart (about 25 days). (Bug#8664)
8e55734a 8128
841f1b75 8129 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8130 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8131
3e26f69c
PE
8132 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8133 that always fit in int. Use a sentinel instead of a counter, to
8134 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8135 * frame.h (struct frame): Use int for menu_bar_items_used
8136 instead of EMACS_INT, since it always fits in int.
3e26f69c 8137
5cc152c0
PE
8138 * menu.c (grow_menu_items): Check for int overflow.
8139
d89eb65e
PE
8140 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8141
5235bd3e
PE
8142 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8143 Before, the code was not consistent. These values cannot exceed
8144 2**31 - 1 so there's no need to make them unsigned.
8145 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8146 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8147 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8148 as modifiers.
8149 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8150
bc827e23
PE
8151 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8152 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8153 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8154 presumably because the widths might not match.
8155
78eb494e
PE
8156 * window.c (size_window): Avoid needless test at loop start.
8157
04f2d78b
CB
81582011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8159
8160 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8161
d2fc7e3d 81622011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8163
8164 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8165
d2fc7e3d 81662011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8167
8168 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8169 `width' to `bar_area_x' and `bar_area_width', respectively.
8170 (x_scroll_run): Take account of fringe background extension.
8171
04f2d78b
CB
8172 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8173 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8174 `bar_area_width', respectively.
8175 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8176 background extension.
8177
79b70037
GM
81782011-05-10 Jim Meyering <meyering@redhat.com>
8179
8180 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8181
2f142cc5
JB
81822011-05-10 Juanma Barranquero <lekktu@gmail.com>
8183
8184 * image.c (Finit_image_library): Return t for built-in image types,
8185 like pbm and xbm. (Bug#8640)
8186
57679c86
AS
81872011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8188
8189 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8190
888c9e86
EZ
81912011-05-07 Eli Zaretskii <eliz@gnu.org>
8192
b0512a1d
EZ
8193 * w32console.c (Fset_screen_color): Doc fix.
8194 (Fget_screen_color): New function.
8195 (syms_of_ntterm): Defsubr it.
8196
7285dc67
EZ
8197 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8198 unlink the temporary file if Fcall_process didn't create it in the
8199 first place.
8200 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8201 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8202 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8203 cue to call_process_cleanup not to close that handle.
8204
4d3fcc8e
BK
82052011-05-07 Ben Key <bkey76@gmail.com>
8206
8207 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8208 one of two shell specific rules, either bootstrap-temacs-CMD or
8209 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8210 to the previous implementation of the bootstrap-temacs rule.
8211 The bootstrap-temacs-CMD rule is similar to the previous
8212 implementation of the bootstrap-temacs rule except that it
8213 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8214 variable.
8215
8216 These changes, along with some changes to nt/configure.bat,
8217 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8218 earlier fix to add support for --cflags and --ldflags options
8219 that include quotes so that it works whether make uses cmd or
8220 sh as the shell.
8221
b4289b64
MA
82222011-05-06 Michael Albinus <michael.albinus@gmx.de>
8223
8224 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8225 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8226 is a constant.
8227 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8228 a string. Handle both cases.
8229 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8230 (Fdbus_register_method): Use Qinvalid_function.
8231
af4c0e28
JB
82322011-05-06 Juanma Barranquero <lekktu@gmail.com>
8233
8234 * makefile.w32-in: Update dependencies.
8235 (LISP_H): Add inttypes.h and stdin.h.
8236 (PROCESS_H): Add unistd.h.
8237
c51453d9
EZ
82382011-05-06 Eli Zaretskii <eliz@gnu.org>
8239
8240 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8241 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8242
8ff0ac3c 82432011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8244
4c4b566b
PE
8245 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8246
aab2b9b5
PE
8247 * term.c (vfatal): Remove stray call to va_end.
8248 It's not needed and the C Standard doesn't allow it here anyway.
8249
c378da0b
PE
8250 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8251 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8252
288b08c7
PE
8253 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8254 bytes.
8255
e3601888
PE
8256 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8257
db6c0e74
PE
8258 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8259
dd5963ea
PE
8260 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8261
88c9450f
PE
8262 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8263
2f9442b8
PE
8264 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8265
c032b5f8
PE
8266 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8267 * charset.c (Fdefine_charset_internal): Don't initialize
8268 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8269 32-bit int (Bug#8600).
a108c10b
PE
8270
8271 * lread.c (read_integer): Be more consistent with string-to-number.
8272 Use string_to_number to do the actual conversion; this avoids
8273 rounding errors and fixes some other screwups. Without this fix,
8274 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8275 (digit_to_number): Move earlier, for benefit of read_integer.
8276 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8277 not a digit in any supported base. (Bug#8602)
a108c10b 8278
ad5f9eea
PE
8279 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8280
aec1708a
PE
8281 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8282 to match comment at start of function. This also removes a
8283 GCC warning about overflow in a 32+64-bit port.
8284
47be4ab5
PE
8285 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8286
371cac43
PE
8287 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8288 Reported by Stefan Monnier in
8289 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8290 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8291 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8292
d01a7826
PE
8293 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8294 (EMACS_UINTPTR): Likewise, with uintptr_t.
8295
7fd47d5c
PE
8296 * lisp.h: Prefer 64-bit EMACS_INT if available.
8297 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8298 on 32-bit hosts that have 64-bit int, so that they can access
8299 large files.
122b0c86
PE
8300 However, temporarily disable this change unless the temporary
8301 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8302
8727937b
PE
8303 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8304
8ac068ac
PE
8305 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8306 This removes an assumption that EMACS_INT and long are the same
8307 width as pointers. The assumption is true for Emacs porting targets
8308 now, but we want to make other targets possible.
8309 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8310 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8311 In the rest of the code, change types of integers that hold casted
8312 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8313 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8314 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8315 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8316 No need to cast type when ORing.
8317 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8318 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8319 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8320 assume EMACS_INT is the same width as char *.
8321 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8322 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8323 Remove no-longer-needed casts.
8324 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8325 (xg_tool_bar_help_callback, xg_make_tool_item):
8326 Use EMACS_INTPTR to hold an integer
8327 that will be cast to void *; this can avoid a GCC warning
8328 if EMACS_INT is not the same width as void *.
8329 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8330 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8331 (current_message_1, set_message_1):
8332 Use a local to convert to proper width without a cast.
8333 * xmenu.c (dialog_selection_callback): Likewise.
8334
ede49d71
PE
8335 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8336 Also, don't assume VALBITS / RAND_BITS is less than 5,
8337 and don't rely on undefined behavior when shifting a 1 left into
8338 the sign bit.
8339 * lisp.h (get_random): Change signature to match.
8340
2f30ecd0
PE
8341 * lread.c (hash_string): Use size_t, not int, for hash computation.
8342 Normally we prefer signed values; but hashing is special, because
8343 it's better to use unsigned division on hash table sizes so that
8344 the remainder is nonnegative. Also, size_t is the natural width
8345 for hashing into memory. The previous code used 'int', which doesn't
8346 retain enough info to hash well into very large tables.
8347 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8348
2a866e7b
PE
8349 * dbusbind.c: Don't possibly lose pointer info when converting.
8350 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8351 Use XPNTR rather than XHASH, so that the high-order bits of
8352 the pointer aren't lost when converting through void *.
8353
51639eac
PE
8354 * eval.c (Fautoload): Don't double-shift a pointer.
8355
92394119
PE
8356 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8357
dbdb9a7c
JB
83582011-05-06 Juanma Barranquero <lekktu@gmail.com>
8359
8360 * gnutls.c (DEF_GNUTLS_FN):
8361 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8362
db7a0b4f
AS
83632011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8364
8365 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8366 marker. (Bug#8610)
8367
cd394be1 83682011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8369
8370 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8371 New version that can reserve upto 2GB of heap space.
8372
f7ff1b0f 83732011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8374
8375 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8376
639c109b
TZ
83772011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8378
8379 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8380 `gnutls_certificate_set_x509_key_file'.
8381
d2127135
JB
83822011-05-05 Juanma Barranquero <lekktu@gmail.com>
8383
8384 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8385 Update dependencies.
8386
e968f4f3
JB
83872011-05-04 Juanma Barranquero <lekktu@gmail.com>
8388
8389 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8390 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8391 Remove unused parameter `fildes'.
8392 * process.c (read_process_output, send_process): Don't pass it.
8393
84d358f0
JB
83942011-05-04 Juanma Barranquero <lekktu@gmail.com>
8395
8396 Fix previous change: the library cache is defined in w32.c.
8397 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8398 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8399
0898ca10
JB
84002011-05-04 Juanma Barranquero <lekktu@gmail.com>
8401
8402 Implement dynamic loading of GnuTLS on Windows.
8403
8404 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8405 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8406 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8407 Declare.
8408
8409 * gnutls.c (Qgnutls_dll): Define.
8410 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8411 (gnutls_*): Declare function pointers.
8412 (init_gnutls_functions): New function to initialize function pointers.
8413 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8414 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8415 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8416 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8417 (emacs_gnutls_write, emacs_gnutls_read)
8418 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8419 (Fgnutls_available_p): New function.
8420 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8421 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8422 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8423
8424 * image.c: Include w32.h.
8425 (Vimage_type_cache): Delete.
8426 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8427 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8428 (w32_delayed_load): Move to w32.c.
8429
8430 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8431
8432 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8433 (w32_delayed_load): Move from image.c. When loading a library, record
8434 its filename in the :loaded-from property of the library id.
8435 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8436 Initialize and staticpro them.
8437 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8438
8439 * process.c: Include lisp.h before w32.h, not after.
8440 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8441 instead of gnutls_record_check_pending.
8442
8443 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8444
ff4de4aa
TZ
84452011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8446
8447 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8448 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8449 as passed in.
8450
abe95abb
JD
84512011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8452
8453 * xterm.c (x_set_frame_alpha): Do not set property on anything
8454 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8455
e16e55d4
JB
84562011-05-02 Juanma Barranquero <lekktu@gmail.com>
8457
8458 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8459
bafcf6a5
JB
84602011-05-02 Juanma Barranquero <lekktu@gmail.com>
8461
8462 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8463 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8464 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8465 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8466 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8467 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8468 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8469 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8470 (Qgnutls_bootprop_callbacks_verify): Make static.
8471
e7a6747f
AS
84722011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8473
19ed11ba
AS
8474 * callproc.c: Indentation fixup.
8475
e7a6747f 8476 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8477 (wait_for_termination, interruptible_wait_for_termination):
8478 Move after wait_for_termination_1.
e7a6747f 8479
1ef14cb4
LMI
84802011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8481
8482 * sysdep.c (interruptible_wait_for_termination): New function
8483 which is like wait_for_termination, but allows keyboard
8484 interruptions.
8485
8486 * callproc.c (Fcall_process): Add (:file "file") as an option for
8487 the STDOUT buffer.
8488 (Fcall_process_region): Ditto.
8489
330d880c
EZ
84902011-04-30 Eli Zaretskii <eliz@gnu.org>
8491
8db90b73
EZ
8492 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8493 rather than `XVECTOR (FOO)->size'.
8494
330d880c
EZ
8495 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8496 inttypes.h, as a gnulib replacement is used if it not available in
8497 system headers.
8498
15cbd324
EZ
84992011-04-21 Eli Zaretskii <eliz@gnu.org>
8500
8501 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8502 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8503 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8504
8505 * coding.c (coding_alloc_by_realloc): Error out if destination
8506 will grow beyond MOST_POSITIVE_FIXNUM.
8507 (decode_coding_emacs_mule): Abort if there isn't enough place in
8508 charbuf for the composition carryover bytes. Reserve an extra
8509 space for up to 2 characters produced in a loop.
8510 (decode_coding_iso_2022): Abort if there isn't enough place in
8511 charbuf for the composition carryover bytes.
8512
85132011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8514
ae940cca
EZ
8515 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8516 aborting when %lld or %lll format is passed.
8517 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8518 %llo or %llx format is passed. (Bug#8545)
8519
03ab8921
EZ
8520 * window.c (window_scroll_line_based): Use a marker instead of
8521 simple variables to record original value of point. (Bug#7952)
8522
afda1437
EZ
8523 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8524 produced by %s or %c overflows available buffer space. (Bug#8545)
8525
f76dee0c
PE
85262011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8527
8528 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8529 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8530
fdc5744d
JB
85312011-04-28 Juanma Barranquero <lekktu@gmail.com>
8532
8533 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8534
638f053a
JB
85352011-04-28 Juanma Barranquero <lekktu@gmail.com>
8536
8537 * keyboard.c (Qdelayed_warnings_hook): Define.
8538 (command_loop_1): Run `delayed-warnings-hook'
8539 if Vdelayed_warnings_list is non-nil.
8540 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8541 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8542
d178f871
EZ
85432011-04-28 Eli Zaretskii <eliz@gnu.org>
8544
8545 * doprnt.c (doprnt): Don't return value smaller than the buffer
8546 size if the message was truncated. (Bug#8545).
8547
b124fd93
JB
85482011-04-28 Juanma Barranquero <lekktu@gmail.com>
8549
8550 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8551 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8552
e810457d
PE
85532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8554
8555 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8556
ea51cceb
JB
85572011-04-27 Juanma Barranquero <lekktu@gmail.com>
8558
8559 * makefile.w32-in: Update dependencies.
8560
94dcfacf
EZ
85612011-04-27 Eli Zaretskii <eliz@gnu.org>
8562
8563 Improve `doprnt' and its usage. (Bug#8545)
8564 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8565 `format_end'. Remove support for %l as a conversion specifier.
8566 Don't use xrealloc. Improve diagnostics when the %l size modifier
8567 is used. Update the commentary.
8568
8569 * eval.c (verror): Simplify calculation of size_t.
8570
8571 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8572 messages.
8573
f61f41d7
PE
85742011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8575
8576 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8577 change.
8578
96fb4434
PE
85792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8580
8581 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8582 This makes this file independent of the recent pseudovector change.
8583
671875da 85842011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8585
69e9b5a3
PE
8586 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8587
b5f869a7 8588 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8589 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8590 Remove unused local.
c8926152 8591 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8592
841a1577 8593 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8594 GCC 4.6.0 optimizes based on type-based alias analysis.
8595 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8596 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8597 != &v->size, and therefore "v->size = 1; b->size = 2; return
8598 v->size;" must therefore return 1. This assumption is incorrect
8599 for Emacs, since it type-puns struct Lisp_Vector * with many other
8600 types. To fix this problem, this patch adds a new type struct
f904488f 8601 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8602 and pseudovectors, and helps optimizing compilers not get fooled
8603 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8604 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8605 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8606 the size member.
eab3844f
PE
8607 (XSETPVECTYPE): Rewrite in terms of new macro.
8608 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8609 This is a bit clearer, and further avoids the possibility of
8610 undesirable aliasing.
8611 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8612 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8613 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8614 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8615 (ASIZE): Now uses header.size rather than size.
8616 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8617 to avoid the hassle of writing XVECTOR (foo)->header.size.
8618 (struct vectorlike_header): New type.
eab3844f
PE
8619 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8620 object, to help avoid aliasing.
8621 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8622 (SUBRP): Likewise, since Lisp_Subr is a special case.
8623 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8624 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8625 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8626 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8627 changed to be "header.size" and "header.next".
8628 * buffer.h (struct buffer): Likewise.
8629 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8630 * frame.h (struct frame): Likewise.
8631 * process.h (struct Lisp_Process): Likewise.
8632 * termhooks.h (struct terminal): Likewise.
8633 * window.c (struct save_window_data, struct saved_window): Likewise.
8634 * window.h (struct window): Likewise.
8635 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8636 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8637 * buffer.c (init_buffer_once): Likewise.
8638 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8639 special case.
8640 * process.c (Fformat_network_address): Use local var for size,
8641 for brevity.
8642
0df1eac5
PE
8643 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8644
847ab9d1 8645 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8646 * data.c (atof): Remove decl; no longer used or needed.
8647 (digit_to_number): Move to lread.c.
8648 (Fstring_to_number): Use new string_to_number function, to be
8649 consistent with how the Lisp reader treats infinities and NaNs.
8650 Do not assume that floating-point numbers represent EMACS_INT
8651 without losing information; this is not true on most 64-bit hosts.
8652 Avoid double-rounding errors, by insisting on integers when
8653 parsing non-base-10 numbers, as the documentation specifies.
8654 * lisp.h (string_to_number): New decl, replacing ...
8655 (isfloat_string): Remove.
bc0a5c13 8656 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8657 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8658 appears to have been a coding error. Similarly, do not accept
8659 strings like +-1e0 as floating point numbers. Do not report
8660 overflow for integer overflows unless the base is not 10 which
8661 means we have no simple and reliable way to continue.
8662 Break out the floating-point parsing into a new
8663 function string_to_number, so that Fstring_to_number parses
8664 floating point numbers consistently with the Lisp reader.
04f2d78b 8665 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8666 (E_CHAR, EXP_INT): Remove, replacing with ...
8667 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8668 (string_to_number): New function, replacing isfloat_string.
8669 This function checks for valid syntax and produces the resulting
8670 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8671 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8672 so that overflow for non-base-10 numbers is reported only when
8673 there's no portable and simple way to convert to floating point.
452f4150 8674
67769ffc
PE
8675 * textprop.c (set_text_properties_1): Rewrite for clarity,
8676 and to avoid GCC warning about integer overflow.
8677
c20db43f
PE
8678 * intervals.h (struct interval): Use EMACS_INT for members
8679 where EMACS_UINT might cause problems. See
8680 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8681 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8682 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8683 All uses changed.
37aa2f85
PE
8684 (offset_intervals): Tell GCC not to worry about length overflow
8685 when negating a negative length.
c20db43f 8686
2538aa2f
PE
8687 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8688 (overrun_check_free): Likewise.
8689
f2d3008d
PE
8690 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8691 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8692 word size.
8693
ec8df744
PE
8694 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8695 (gnutls_make_error): Rename local to avoid shadowing.
8696 (gnutls_emacs_global_deinit): ifdef out; not used.
8697 (Fgnutls_boot): Use const for pointer to readonly storage.
8698 Comment out unused local. Fix pointer signedness problems.
8699
640ee02d
PE
8700 * lread.c (openp): Don't stuff size_t into an 'int'.
8701 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8702 about possible signed overflow.
8703
6048fb2a
PE
8704 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8705 (GDK_KEY_g): Don't define if already defined.
8706 (xg_prepare_tooltip): Avoid pointer signedness problem.
8707 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8708
fa3c87e1
PE
8709 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8710 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8711
2172544b
PE
8712 * xfns.c (Fx_window_property): Simplify a bit,
8713 to make a bit faster and to avoid GCC 4.6.0 warning.
8714 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8715
9b821a21
PE
8716 * fns.c (internal_equal): Don't assume size_t fits in int.
8717
3c616cfa
PE
8718 * alloc.c (compact_small_strings): Tighten assertion a little.
8719
c2982e87
PE
8720 Replace pEd with more-general pI, and fix some printf arg casts.
8721 * lisp.h (pI): New macro, generalizing old pEd macro to other
8722 conversion specifiers. For example, use "...%"pI"d..." rather
8723 than "...%"pEd"...".
8724 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 8725 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
8726 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8727 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8728 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8729 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8730 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8731 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8732 64-bit hosts.
8733 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8734 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8735 * print.c (safe_debug_print, print_object): Likewise.
8736 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8737 to int.
6f04d126
PE
8738 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8739 avoiding the 0 flag, which is not portable.
c2982e87
PE
8740 * process.c (Fmake_network_process): Use pI to avoid cast.
8741 * region-cache.c (pp_cache): Likewise.
8742 * xdisp.c (decode_mode_spec): Likewise.
8743 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8744 behavior on 64-bit hosts with printf arg.
6f04d126 8745 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
8746 (x_stop_queuing_selection_requests): Likewise.
8747 (x_get_window_property): Don't truncate byte count to an 'int'
8748 when tracing.
0b432f21 8749
5e073ec7
PE
8750 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8751 here, since it parses constructs like leading '-' and spaces,
8752 which are not wanted; and it overflows with large numbers.
8753 Instead, simply match F[0-9]+, which is what is wanted anyway.
8754
36372bf9
PE
8755 * alloc.c: Remove unportable assumptions about struct layout.
8756 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8757 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8758 (allocate_vectorlike, make_pure_vector): Use the new macros,
8759 plus offsetof, to remove unportable assumptions about struct layout.
8760 These assumptions hold on all porting targets that I know of, but
8761 they are not guaranteed, they're easy to remove, and removing them
8762 makes further changes easier.
8763
0b432f21
PE
8764 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8765 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
8766 (string_overrun_cookie): Now const. Use initializers that
8767 don't formally overflow signed char, to avoid warnings.
000098c1
PE
8768 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8769 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
8770 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8771 multiple of sizeof (EMACS_INT); it need not be, if
8772 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 8773 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 8774
895009e1
JB
87752011-04-26 Juanma Barranquero <lekktu@gmail.com>
8776
8777 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8778
6a7a1b0b
TZ
87792011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8780
8781 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 8782 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
8783 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8784
841a1577 87852011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
8786
8787 * lisp.h (Qdebug): List symbol.
895009e1 8788 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
8789 * keyboard.c (debug-on-event): New variable.
8790 (handle_user_signal): Break into debugger when debug-on-event
8791 matches the current signal symbol.
8792
f2d3ba6f
DN
87932011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8794
8795 * alloc.c (check_sblock, check_string_bytes)
8796 (check_string_free_list): Convert to standard C.
8797
42ce4c63
TZ
87982011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8799
8800 * w32.c (emacs_gnutls_push): Fix typo.
8801
825cd63c
EZ
88022011-04-25 Eli Zaretskii <eliz@gnu.org>
8803
fb11d64d
EZ
8804 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8805 "cast to pointer from integer of different size".
8806
825cd63c
EZ
8807 Improve doprnt and its use in verror. (Bug#8545)
8808 * doprnt.c (doprnt): Document the set of format control sequences
8809 supported by the function. Use SAFE_ALLOCA instead of always
8810 using `alloca'.
8811
8812 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8813 is one byte too soon. Don't use xrealloc; instead xfree and
8814 xmalloc anew.
8815
e061a11b
TZ
88162011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8817
8818 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8819 callbacks stage.
8820
8821 * gnutls.c: Renamed global_initialized to
8822 gnutls_global_initialized. Added internals for the
8823 :verify-hostname-error, :verify-error, and :verify-flags
8824 parameters of `gnutls-boot' and documented those parameters in the
8825 docstring. Start callback support.
9173deec
JB
8826 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8827 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8828 on error. Return error code.
e061a11b
TZ
8829 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8830 (emacs_gnutls_read): Likewise.
8831 (Fgnutls_boot): Return handshake error code.
8832 (emacs_gnutls_handle_error): New function.
8833 (wsaerror_to_errno): Likewise.
8834
8835 * w32.h (emacs_gnutls_pull): Add prototype.
8836 (emacs_gnutls_push): Likewise.
8837
8838 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8839 (emacs_gnutls_push): Likewise.
8840
88412011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8842
8843 * process.c (wait_reading_process_output): Check if GnuTLS
8844 buffered some data internally if no FDs are set for TLS
8845 connections.
8846
8847 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8848 (LIBS): Link to USER_LIBS.
8849 ($(BLD)/gnutls.$(0)): New target.
8850
fa6996bc
EZ
88512011-04-24 Eli Zaretskii <eliz@gnu.org>
8852
eb35682e
EZ
8853 * xdisp.c (handle_single_display_spec): Rename the
8854 display_replaced_before_p argument into display_replaced_p, to
8855 make it consistent with the commentary. Fix typos in the
8856 commentary.
8857
e2ad650c
EZ
8858 * textprop.c (syms_of_textprop): Remove dead code.
8859 (copy_text_properties): Delete obsolete commentary about an
8860 interface that was deleted long ago. Fix typos in the description
8861 of arguments.
8862
1b2de274
EZ
8863 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8864 to changes in oldXMenu/XMenu.h from 2011-04-16.
8865 <menu_help_message, prev_menu_help_message>: Constify.
8866 (IT_menu_make_room): menu->help_text is now `const char **';
8867 adjust.
8868
8869 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8870 to changes in oldXMenu/XMenu.h from 2011-04-16.
8871 (struct XMenu): Declare `help_text' `const char **'.
8872
8873 * xfaces.c <Qunspecified>: Make extern again.
8874
8875 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 8876 required by POSIX.
1b2de274 8877
762b15be
EZ
8878 * doc.c (get_doc_string): Improve the format passed to `error'.
8879
8880 * doprnt.c (doprnt): Improve commentary.
8881
8882 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8883
8884 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8885 them with etags.
8886
f1052e5d
EZ
8887 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8888 changes in globals.h immediately force recompilation.
762b15be
EZ
8889 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8890 $(CURDIR)/s/ms-w32.h.
8891 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 8892
fa6996bc
EZ
8893 * character.c (Fchar_direction): Function deleted.
8894 (syms_of_character): Don't defsubr it.
8895 <char-direction-table>: Deleted.
8896
e6c3da20
EZ
88972011-04-23 Eli Zaretskii <eliz@gnu.org>
8898
8899 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8900 * doprnt.c: Include limits.h.
8901 (SIZE_MAX): New macro.
04f2d78b
CB
8902 (doprnt): Return a size_t value. 2nd arg is now size_t.
8903 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
8904 Improve overflow protection. Support `l' modifier for integer
8905 conversions. Support %l conversion. Don't assume an EMACS_INT
8906 argument for integer conversions and for %c.
8907
8908 * lisp.h (doprnt): Restore prototype.
8909
8910 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8911 $(SRC)/character.h.
8912
8913 * Makefile.in (base_obj): Add back doprnt.o.
8914
8915 * deps.mk (doprnt.o): Add back prerequisites.
8916 (callint.o): Depend on character.h.
8917
8918 * eval.c (internal_lisp_condition_case): Include the handler
8919 representation in the error message.
8920 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8921 when breaking from the loop.
8922
8923 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8924
8925 * callint.c (Fcall_interactively): When displaying error message
8926 about invalid control letter, pass the character's codepoint, not
8927 a pointer to its multibyte form. Improve display of the character
8928 in octal and display also its hex code.
8929
8930 * character.c (char_string): Use %x to display the (unsigned)
8931 codepoint of an invalid character, to avoid displaying a bogus
8932 negative value.
8933
8934 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8935 `error', not SYMBOL_NAME itself.
8936
8937 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8938 character arguments to `error'.
8939
8940 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8941 to `error' in error message about FINAL_CHAR argument. Make sure
8942 FINAL_CHAR is a character, and use %c when it is passed as
8943 argument to `error'.
8944
4ffd0d6b 89452011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
8946
8947 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8948
8949 * w32.c: Include <time.h>.
8950 (sys_localtime): New function.
8951
4ffd0d6b 89522011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
8953
8954 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8955
4ffd0d6b 8956 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 8957
4ffd0d6b 89582011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 8959
4ffd0d6b
GM
8960 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8961 zombies (Bug#8467).
aac0c6e3 8962
04c56954
EZ
89632011-04-19 Eli Zaretskii <eliz@gnu.org>
8964
8965 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8966 gl_state.e_property when gl_state.object is Qt.
8967
8968 * insdel.c (make_gap_larger): Remove limitation of buffer size
8969 to <= INT_MAX.
8970
16a43933
CY
89712011-04-18 Chong Yidong <cyd@stupidchicken.com>
8972
8973 * xdisp.c (lookup_glyphless_char_display)
8974 (produce_glyphless_glyph): Handle cons cell entry in
8975 glyphless-char-display.
8976 (Vglyphless_char_display): Document it.
8977
8978 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8979 glyphless-char-display.
8980
4581706e
CY
89812011-04-17 Chong Yidong <cyd@stupidchicken.com>
8982
8983 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8984
8985 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8986
8987 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8988 definition for no-X builds.
8989
4887c6e2 89902011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 8991
fd35b6f9
PE
8992 Static checks with GCC 4.6.0 and non-default toolkits.
8993
5c1ccb01
PE
8994 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8995
006c5daa
PE
8996 * process.c (keyboard_bit_set): Define only if SIGIO.
8997 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8998 (send_process): Repair possible setjmp clobbering.
8999
efc736d3
PE
9000 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9001
4e2fe2e6
PE
9002 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9003
f97334a2
PE
9004 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9005
4e75f29d
PE
9006 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9007 Define only if needed.
9008
90efadd1
PE
9009 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9010 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9011 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9012
3c647824
PE
9013 * dispextern.h (struct redisplay_interface): Rename param
9014 to avoid shadowing.
e264f262 9015 * termhooks.h (struct terminal): Likewise.
761383f4 9016 * xterm.c (xembed_send_message): Likewise.
3c647824 9017
b58c5c4a
PE
9018 * insdel.c (make_gap_smaller): Define only if
9019 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9020
cad59032
PE
9021 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9022 it.
9023
c339dc2e
PE
9024 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9025 so that we aren't warned about unused symbols.
9026
91a3e27b
PE
9027 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9028
399c71d3 9029 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9030
8ffc96f5
PE
9031 * xfns.c (x_real_positions): Mark locals as initialized.
9032
eef9bc79
PE
9033 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9034
098db9dd
PE
9035 * xterm.c: Fix problems found by static analysis with other toolkits.
9036 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9037 (x_dispatch_event): Declare static if USE_GTK, and
9038 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9039 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9040 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9041 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9042 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9043
eb18f6cc
PE
9044 * xmenu.c (menu_help_callback): Pointer type fixes.
9045 Use const pointers when pointing at readonly data. Avoid pointer
9046 signedness clashes.
9047 (FALSE): Remove unused macro.
9048 (update_frame_menubar): Remove unused decl.
9049
1fe72bf8
PE
9050 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9051
60d9e1db
PE
9052 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9053 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9054 (single_menu_item): Rename local to avoid shadowing.
9055
39261c26
PE
9056 * keyboard.c (make_lispy_event): Remove unused local var.
9057
018c5e19
PE
9058 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9059 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9060
63d2b86e
PE
9061 * bitmaps: Change bitmaps from unsigned char back to the X11
9062 compatible char. Avoid the old compiler warnings about
9063 out-of-range initializers by using, for example, '\xab' rather
9064 than 0xab.
9065
aefd87e1
PE
9066 * xgselect.c (xgselect_initialize): Check vs interface
9067 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9068
bf501fb9
PE
9069 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9070
e9829fdf
PE
9071 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9072 to read-only memory.
9073
1086c095
PE
9074 * fns.c (vector): Remove; this old hack is no longer needed.
9075
2baccd04 9076 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9077 Remove unused var.
dde42981 9078 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9079
72391843 9080 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9081
436c16df 9082 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9083 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9084 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9085
92bb796d 9086 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9087 (x_term_init): Remove local to avoid shadowing.
92bb796d 9088
764430a3 9089 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9090
9091 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9092 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9093
d1dfb56c
EZ
90942011-04-16 Eli Zaretskii <eliz@gnu.org>
9095
c4354cb4
EZ
9096 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9097
d1dfb56c
EZ
9098 Fix regex.c, syntax.c and friends for buffers > 2GB.
9099 * syntax.h (struct gl_state_s): Declare character position members
9100 EMACS_INT.
9101
9102 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9103
04f2d78b
CB
9104 * textprop.c (verify_interval_modification, interval_of):
9105 Declare arguments EMACS_INT.
d1dfb56c
EZ
9106
9107 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9108 EMACS_INT.
9109
9110 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9111
9112 * indent.c (Fvertical_motion): Local variable it_start is now
9113 EMACS_INT.
9114
9115 * regex.c (re_match, re_match_2, re_match_2_internal)
9116 (bcmp_translate, regcomp, regexec, print_double_string)
9117 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9118 (re_compile_pattern, re_exec): Declare arguments and local
9119 variables `size_t' and `ssize_t' and return values `regoff_t', as
9120 appropriate.
9121 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9122 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9123 <compile_stack_type>: `size' and `avail' are now `size_t'.
9124
9125 * regex.h <regoff_t>: Use ssize_t, not int.
9126 (re_search, re_search_2, re_match, re_match_2): Arguments that
9127 specify buffer/string position and length are now ssize_t and
9128 size_t. Return type is regoff_t.
9129
613052cd
BK
91302011-04-16 Ben Key <bkey76@gmail.com>
9131
9132 * nsfont.m: Fixed bugs in ns_get_family and
9133 ns_descriptor_to_entity that were caused by using free to
9134 deallocate memory blocks that were allocated by xmalloc (via
9135 xstrdup). This caused Emacs to crash when compiled with
9136 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9137 --enable-checking=xmallocoverrun). xfree is now used to
9138 deallocate these memory blocks.
9139
4170f62f 91402011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9141
71b41406
PE
9142 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9143
9587a89d
PE
9144 emacs_write: Accept and return EMACS_INT for sizes.
9145 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9146 et seq.
9147 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9148 Accept and return EMACS_INT.
9149 (emacs_gnutls_write): Return the number of bytes written on
9150 partial writes.
9151 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9152 (emacs_read, emacs_write): Remove check for negative size, as the
9153 Emacs source code has been audited now.
9587a89d
PE
9154 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9155 (emacs_read, emacs_write): Use it.
273a5f82
PE
9156 * process.c (send_process): Adjust to the new signatures of
9157 emacs_write and emacs_gnutls_write. Do not attempt to store
9158 a byte offset into an 'int'; it might overflow.
9587a89d 9159 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9160
3e047f51
PE
9161 * sound.c: Don't assume sizes fit in 'int'.
9162 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9163 Return EMACS_INT, not int.
3e047f51 9164 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9165 Accept EMACS_INT, not int.
9166 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9167 record read return values.
9168
cc39a9db
BK
91692011-04-15 Ben Key <bkey76@gmail.com>
9170
c9d0ec6d
JB
9171 * keyboard.c (Qundefined): Don't declare static since it is used
9172 in nsfns.m.
9173 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9174 static since they are used in nsfont.m.
cc39a9db 9175
6c60eb9f
SM
91762011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9177
9178 * process.c (Qprocessp): Don't declare static.
9179 * lisp.h (Qprocessp): Declare again.
9180
7990b61a
JB
91812011-04-15 Juanma Barranquero <lekktu@gmail.com>
9182
9183 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9184
5d4cb038
PE
91852011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9186
8bd7b830 9187 Improve C-level modularity by making more things 'static'.
cd64ea1d 9188
e3b27b31
PE
9189 Don't publish debugger-only interfaces to other modules.
9190 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9191 (verify_bytepos, count_markers): Move decls to the only modules
9192 that need them.
9193 * region-cache.h (pp_cache): Likewise.
9194 * window.h (check_all_windows): Likewise.
9195 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9196
5d4cb038
PE
9197 * sysdep.c (croak): Now static, if
9198 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9199 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9200
9201 * alloc.c (refill_memory_reserve): Now static if
9202 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9203 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9204
e87b6180
PE
9205 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9206 Define only if USE_LUCID.
9207
ac64929e
PE
9208 * xrdb.c (x_customization_string, x_rm_string): Now static.
9209
6f37259d
PE
9210 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9211 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9212
1683e3ab
PE
9213 * xdisp.c (draw_row_with_mouse_face): Now static.
9214 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9215
de9c2632
PE
9216 * window.h (check_all_windows): Mark externally visible.
9217
2b96acb7
PE
9218 * window.c (window_deletion_count): Now static.
9219
9220 * undo.c: Make symbols static if they're not exported.
9221 (last_undo_buffer, last_boundary_position, pending_boundary):
9222 Now static.
9223
50436f33
PE
9224 * textprop.c (interval_insert_behind_hooks): Now static.
9225 (interval_insert_in_front_hooks): Likewise.
9226
64520e5c
PE
9227 * term.c: Make symbols static if they're not exported.
9228 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9229 (max_frame_lines, tty_set_terminal_modes):
9230 (tty_reset_terminal_modes, tty_turn_off_highlight):
9231 (get_tty_terminal): Now static.
9232 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9233 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9234 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9235 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9236 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9237
1fa53021
PE
9238 * sysdep.c: Make symbols static if they're not exported.
9239 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9240 Now static.
9241 (sigprocmask_set, full_mask): Remove; unused.
9242 (wait_debugging): Mark as visible.
9243 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9244 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9245
d4b43b22
PE
9246 * syntax.c (syntax_temp): Define only if !__GNUC__.
9247
b7c513d0
PE
9248 * sound.c (current_sound_device, current_sound): Now static.
9249
989b29ad
PE
9250 * search.c (searchbufs, searchbuf_head): Now static.
9251
13a55a78
PE
9252 * scroll.c (scroll_cost): Remove; unused.
9253 * dispextern.h (scroll_cost): Remove decl.
9254
de68a1fc
PE
9255 * region-cache.h (pp_cache): Mark as externally visible.
9256
40ccffa6
PE
9257 * process.c: Make symbols static if they're not exported.
9258 (process_tick, update_tick, create_process, chan_process):
9259 (Vprocess_alist, proc_buffered_char, datagram_access):
9260 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9261 (deactivate_process): Mark defn as static, as well as decl.
9262 * lisp.h (create_process): Remove decl.
9263 * process.h (chan_process, Vprocess_alist): Remove decls.
9264
ad64fc97
PE
9265 * print.c: Make symbols static if they're not exported.
9266 (print_depth, new_backquote_output, being_printed, print_buffer):
9267 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9268 (print_interval, print_number_index, initial_stderr_stream):
9269 Now static.
9270 * lisp.h (Fprinc): Remove decl.
9271 (debug_output_compilation_hack): Mark as externally visible.
9272
adddb265
PE
9273 * sysdep.c (croak): Move decl from here to syssignal.h.
9274 * syssignal.h (croak): Put it here, so the API can be checked when
9275 'croak' is called from dissociate_if_controlling_tty.
9276
1717ede2
PE
9277 * minibuf.c: Make symbols static if they're not exported.
9278 (minibuf_save_list, choose_minibuf_frame): Now static.
9279 * lisp.h (choose_minibuf_frame): Remove decl.
9280
fa5fb2bc
PE
9281 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9282
1e3890d1
PE
9283 * lread.c: Make symbols static if they're not exported.
9284 (read_objects, initial_obarray, oblookup_last_bucket_number):
9285 Now static.
9286 (make_symbol): Remove; unused.
9287 * lisp.h (initial_obarray, make_symbol): Remove decls.
9288
8a1414fa
PE
9289 * keyboard.c: Make symbols static if they're not exported.
9290 (single_kboard, recent_keys_index, total_keys, recent_keys):
9291 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9292 (this_single_command_key_start, echoing, last_auto_save):
9293 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9294 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9295 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9296 (Vlispy_mouse_stem, double_click_count):
9297 Now static.
9298 (force_auto_save_soon): Define only if SIGDANGER.
9299 (ignore_mouse_drag_p): Now static if
9300 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9301 (print_help): Remove; unused.
9302 (stop_character, last_timer_event): Mark as externally visible.
9303 * keyboard.h (ignore_mouse_drag_p): Declare only if
9304 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9305 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9306 * lisp.h (echoing): Remove decl.
9307 (force_auto_save_soon): Declare only if SIGDANGER.
9308 * xdisp.c (redisplay_window): Simplify code, to make it more
9309 obvious that ignore_mouse_drag_p is not accessed if !defined
9310 USE_GTK && !defined HAVE_NS.
9311
93ea6e8f
PE
9312 * intervals.c: Make symbols static if they're not exported.
9313 (merge_properties_sticky, merge_interval_right, delete_interval):
9314 Now static.
9315 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9316
77382fcc
PE
9317 * insdel.c: Make symbols static if they're not exported.
9318 However, leave prepare_to_modify_buffer alone. It's never
9319 called from outside this function, but that appears to be a bug.
9320 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9321 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9322 (adjust_after_replace_noundo): Remove; unused.
9323 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9324 (signal_before_change): Remove decls.
77382fcc 9325
9306c32e
PE
9326 * indent.c (val_compute_motion, val_vmotion): Now static.
9327
cd44d2eb
PE
9328 * image.c: Make symbols static if they're not exported.
9329 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9330 if USE_GTK.
9331 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9332 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9333
ad9a7a06
PE
9334 * fringe.c (standard_bitmaps): Now static.
9335 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9336
81626931
PE
9337 * frame.c: Make symbols static if they're not exported.
9338 (x_report_frame_params, make_terminal_frame): Now static.
9339 (get_frame_param): Now static, unless HAVE_NS.
9340 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9341 (x_get_resource_string): Remove; not used.
9342 * frame.h (make_terminal_frame, x_report_frame_params):
9343 (x_get_resource_string); Remove decls.
9344 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9345 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9346
239f9db9
PE
9347 * font.c, fontset.c: Make symbols static if they're not exported.
9348 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9349 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9350 * font.c (font_close_object): Now static.
9351 * font.h (font_close_object): Remove.
9352 * fontset.c (FONTSET_OBJLIST): Remove.
9353 (free_realized_fontset) #if-0 the body, which does nothing.
9354 (face_suitable_for_char_p): #if-0, as it's never called.
9355 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9356 * xfaces.c (face_at_string_position):
9357 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9358 since 0 is always ASCII.
9359
dfcf3579
PE
9360 * fns.c (weak_hash_tables): Now static.
9361
5045092b
PE
9362 * fileio.c: Make symbols static if they're not exported.
9363 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9364 (Vwrite_region_annotation_buffers): Now static.
9365
57a96f5c
PE
9366 * eval.c: Make symbols static if they're not exported.
9367 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9368 * lisp.h (backtrace_list): Remove decl.
9369
35f08c38
PE
9370 * emacs.c: Make symbols static if they're not exported.
9371 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9372 (fatal_error_code, fatal_error_signal_hook, standard_args):
9373 Now static.
9374 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9375 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9376 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9377 * lisp.h (fatal_error_signal_hook): Remove decl.
9378 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9379
f44bd759
PE
9380 * editfns.c: Move a (normally-unused) function to its only use.
9381 * editfns.c, lisp.h (get_operating_system_release): Remove.
9382 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9383 worth the hassle of breaking this out.
9384
b532497d
PE
9385 * xterm.c: Make symbols static if they're not exported.
9386 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9387 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9388 (x_destroy_window, x_delete_display):
9389 Now static.
9390 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9391 (x_mouse_leave): Remove; unused.
9392 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9393 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9394 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9395 Remove decls.
9396 (x_mouse_leave): Declare only if WINDOWSNT.
9397 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9398 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9399 USE_X_TOOLKIT.
9400
1675728f
PE
9401 * ftxfont.c: Make symbols static if they're not exported.
9402 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9403 HAVE_FREETYPE.
9404 * font.h (ftxfont_driver): Likewise.
9405
e4cebfca
PE
9406 * xfns.c: Make symbols static if they're not exported.
9407 (x_last_font_name, x_display_info_for_name):
9408 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9409 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9410 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9411 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9412 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9413 (last_show_tip_args): Now static.
9414 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9415 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9416 (x_screen_planes): Remove; unused.
9417 * dispextern.h (x_screen_planes): Remove decl.
9418
5bf46f05
PE
9419 * dispnew.c: Make symbols static if they're not exported.
9420 * dispextern.h (redraw_garbaged_frames, scrolling):
9421 (increment_row_positions): Remove.
9422 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9423 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9424 Now static.
9425 (redraw_garbaged_frames): Remove; unused.
9426
435f4c28
PE
9427 * xfaces.c: Make symbols static if they're not exported.
9428 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9429 Remove decls.
9430 * xterm.h (defined_color): Remove decls.
9431 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9432 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9433 (menu_face_changed_default, defined_color, free_realized_face):
9434 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9435 (ascii_face_of_lisp_face): Remove; unused.
9436
8524aef3
PE
9437 * xdisp.c: Make symbols static if they're not exported.
9438 * dispextern.h (scratch_glyph_row, window_box_edges):
9439 (glyph_to_pixel_coords, set_cursor_from_row):
9440 (get_next_display_element, set_iterator_to_next):
9441 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9442 (show_mouse_face): Remove decls
9443 * frame.h (message_buf_print): Likewise.
9444 * lisp.h (pop_message, set_message, check_point_in_composition):
9445 Likewise.
9446 * xterm.h (set_vertical_scroll_bar): Likewise.
9447 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9448 (message_buf_print, scratch_glyph_row, displayed_buffer):
9449 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9450 (get_next_display_element, show_mouse_face, window_box_edges):
9451 (frame_to_window_pixel_xy, check_point_in_composition):
9452 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9453 (glyph_to_pixel_coords): Remove; unused.
9454
16390cd2
PE
9455 * dired.c (file_name_completion): Now static.
9456
9457 * dbusbind.c (xd_in_read_queued_messages): Now static.
9458
a25f4dfa
PE
9459 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9460 * data.c (circular_list_error): Remove.
9461
14a9c8df
PE
9462 * commands.h (last_point_position, last_point_position_buffer):
9463 (last_point_position_window): Remove decls.
9464 * keyboard.c: Make these variables static.
9465
04f2d78b
CB
9466 * coding.h (coding, code_convert_region, encode_coding_gap):
9467 Remove decls.
74ab6df5
PE
9468 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9469 (iso_code_class, detect_coding, code_convert_region): Now static.
9470 (encode_coding_gap): Remove; unused.
9471
38dfbee1
PE
9472 * chartab.c (chartab_chars, chartab_bits): Now static.
9473
a2cb4e63
PE
9474 * charset.h (charset_iso_8859_1): Remove decl.
9475 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9476 Now static.
9477
127198fd
PE
9478 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9479 * ccl.c (Vccl_program_table): Now static.
9480 (check_ccl_update): Remove; unused.
9481
d85b608f
PE
9482 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9483 * category.h: ... from here.
9484 * category.c (check_category_table, set_category_set): Now static.
9485
31cd66f3
PE
9486 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9487 * lisp.h: Remove these decls.
9488
c358e587
PE
9489 * buffer.c (buffer_count): Remove unused var.
9490
e78aecca
PE
9491 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9492 so that it's not optimized away.
9493 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9494 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9495 exported only to the debugger.
9496
e192d7d3 9497 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9498 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9499
92470028
PE
9500 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9501 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9502 was inaccessible from Lisp.
9503 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9504 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9505
244ed907
PE
9506 alloc.c: Import and export fewer symbols, and remove unused items.
9507 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9508 is defined.
9509 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9510 it's not optimized away by whole-program optimization.
9511 (message_enable_multibyte, free_misc): Remove.
9512 (catchlist, handlerlist, mark_backtrace):
9513 Declare only if BYTE_MARK_STACK.
9514 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9515 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9516 (message_enable_multibyte): Remove decl.
9517 (free_misc, interval_free_list, float_block, float_block_index):
9518 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9519 (cons_free_list, last_marked_index):
9520 Now static.
9521 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9522 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9523 (mark_backtrace): Define only if BYTE_MARK_STACK.
9524 * xdisp.c (message_enable_multibyte): Now static.
9525
61c2b50e 9526 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9527 This makes it easier for human readers (and static analyzers)
9528 to see whether these variables are used from other modules.
9529 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9530 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9531 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9532 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9533 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9534 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9535 * xmenu.c, xselect.c:
9536 Declare Q* vars static if they are not used in other modules.
9537 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9538 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9539 Remove decls of unexported vars.
9540 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9541
95c82688
PE
9542 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9543
16a97296
PE
9544 Make Emacs functions such as Fatom 'static' by default.
9545 This makes it easier for human readers (and static analyzers)
9546 to see whether these functions can be called from other modules.
9547 DEFUN now defines a static function. To make the function external
9548 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9549 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9550 (Finit_image_library):
16a97296
PE
9551 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9552 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9553 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9554 Remove decls, since these functions are now static.
9555 (Funintern, Fget_internal_run_time): New decls, since these functions
9556 were already external.
95c82688 9557
16a97296
PE
9558 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9559 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9560 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9561 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9562 * keyboard.c, keymap.c, lread.c:
9563 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9564 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9565 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9566 Mark functions with DEFUE instead of DEFUN,
9567 if they are used in other modules.
9568 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9569 decls for now-static functions.
9570 * buffer.h (Fdelete_overlay): Remove decl.
9571 * callproc.c (Fgetenv_internal): Mark as internal.
9572 * composite.c (Fremove_list_of_text_properties): Remove decl.
9573 (Fcomposition_get_gstring): New forward static decl.
9574 * composite.h (Fcomposite_get_gstring): Remove decl.
9575 * dired.c (Ffile_attributes): New forward static decl.
9576 * doc.c (Fdocumntation_property): New forward static decl.
9577 * eval.c (Ffetch_bytecode): New forward static decl.
9578 (Funintern): Remove extern decl; now in .h file where it belongs.
9579 * fileio.c (Fmake_symbolic_link): New forward static decl.
9580 * image.c (Finit_image_library): New forward static decl.
9581 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9582 * intervals.h (Fprevious_property_change):
9583 (Fremove_list_of_text_properties): Remove decls.
9584 * keyboard.c (Fthis_command_keys): Remove decl.
9585 (Fcommand_execute): New forward static decl.
9586 * keymap.c (Flookup_key): New forward static decl.
9587 (Fcopy_keymap): Now static.
9588 * keymap.h (Flookup_key): Remove decl.
9589 * process.c (Fget_process): New forward static decl.
9590 (Fprocess_datagram_address): Mark as internal.
9591 * syntax.c (Fsyntax_table_p): New forward static decl.
9592 (skip_chars): Remove duplicate decl.
9593 * textprop.c (Fprevious_property_change): New forward static decl.
9594 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9595 Now internal.
9596 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9597 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9598
785bbd42
PE
9599 * editfns.c (Fformat): Remove unreachable code.
9600
8b913b57
AS
96012011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9602
9603 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9604 change. (Bug#8496)
9605
a6744a35
EZ
96062011-04-13 Eli Zaretskii <eliz@gnu.org>
9607
9608 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9609 when at ZV. (Bug#8487)
9610
e7974947
AS
96112011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9612
baad03f0
AS
9613 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9614 (Bug#8437)
9615 * keyboard.c (parse_tool_bar_item): Likewise.
9616 * sound.c (sound_cleanup, alsa_close): Likewise.
9617 * termcap.c (tgetent): Likewise.
9618 * xfns.c (x_default_font_parameter): Likewise.
9619 * xsettings.c (read_and_apply_settings): Likewise.
9620
e7974947
AS
9621 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9622 (overrun_check_free): Protoize.
9623
28272684
PE
96242011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9625
9626 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9627 since callers should never pass a negative size.
9628 Change the signature to match that of plain 'read' and 'write'; see
9629 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9630 * lisp.h: Update prototypes of emacs_write and emacs_read.
9631
11997c76
EZ
96322011-04-11 Eli Zaretskii <eliz@gnu.org>
9633
9634 * xdisp.c (redisplay_window): Don't try to determine the character
9635 position of the scroll margin if the window start point w->startp
e896f03c 9636 is outside the buffer's accessible region. (Bug#8468)
11997c76 9637
8a2cbd72
EZ
96382011-04-10 Eli Zaretskii <eliz@gnu.org>
9639
9640 Fix write-region and its subroutines for buffers > 2GB.
9641 * fileio.c (a_write, e_write): Modify declaration of arguments and
9642 local variables to support buffers larger than 2GB.
9643 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9644
9645 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9646 argument, local variables, and return value.
9647
9648 * lisp.h: Update prototypes of emacs_write and emacs_read.
9649
9650 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9651
4073e537 96522011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9653
1ebfdcb6
PE
9654 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9655
b2ded58d
PE
9656 Fix more problems found by GCC 4.6.0's static checks.
9657
7d66342c
PE
9658 * xdisp.c (vmessage): Use a better test for character truncation.
9659
bbf47d44
PE
9660 * charset.c (load_charset_map): <, not <=, for optimization,
9661 and to avoid potential problems with integer overflow.
9248994d 9662 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9663 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9664 * editfns.c (Fformat): Likewise.
1e69125e 9665 * syntax.c (skip_chars): Likewise.
3befa583 9666
e3019616
PE
9667 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9668 This also lets GCC 4.6.0 generate slightly better loop code.
9669
becfa255
PE
9670 * callint.c (Fcall_interactively): <, not <=, for optimization.
9671 (Fcall_interactively): Count the number of arguments produced,
9672 not the number of arguments given. This is simpler and lets GCC
9673 4.6.0 generate slightly better code.
9674
dae0cd48
PE
9675 * ftfont.c: Distingish more carefully between FcChar8 and char.
9676 The previous code passed unsigned char * to a functions like
9677 strlen and xstrcasecmp that expect char *, which does not
9678 conform to the C standard.
9679 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9680 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9681 char * when the C standard requires it.
9682
76032d70
PE
9683 * keyboard.c (read_char): Remove unused var.
9684
eb3f1cc8
PE
9685 * eval.c: Port to Windows vsnprintf (Bug#8435).
9686 Include <limits.h>.
9687 (SIZE_MAX): Define if the headers do not.
9688 (verror): Do not give up if vsnprintf returns a negative count.
9689 Instead, grow the buffer. This ports to Windows vsnprintf, which
9690 does not conform to C99. Problem reported by Eli Zaretskii.
9691 Also, simplify the allocation scheme, by avoiding the need for
9692 calling realloc, and removing the ALLOCATED variable.
9693
70476b54
PE
9694 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9695
12020a9e
PE
9696 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9697 But keep the doprint source code for now, as we might revamp it
9698 and use it again (Bug#8435).
ea6c7ae6
PE
9699 * lisp.h (doprnt): Remove.
9700 * Makefile.in (base_obj): Remove doprnt.o.
9701 * deps.mk (doprnt.o): Remove.
9702
5fdb398c
PE
9703 error: Print 32- and 64-bit integers portably (Bug#8435).
9704 Without this change, on typical 64-bit hosts error ("...%d...", N)
9705 was used to print both 32- and 64-bit integers N, which relied on
9706 undefined behavior.
61bdb816 9707 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9708 * lisp.h (error, verror): Mark as printf-like functions.
9709 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9710 Report overflow in size calculations when allocating printf buffer.
9711 Do not truncate output string at its first null byte.
9712 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9713 Truncate the output at a character boundary, since vsnprintf does not
9714 do that.
9715 * charset.c (check_iso_charset_parameter): Convert internal
9716 character to string before calling 'error', since %c now has the
9717 printf meaning.
9718 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9719 overflow when computing char to be passed to 'error'. Do not
9720 pass Lisp_Object to 'error'; pass the integer instead.
9721 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9722 formatted with plain %d.
9723
b189fa66
PE
9724 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9725
bff87ef0
PE
9726 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9727
7e2cac20
PE
9728 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9729
ce4d90b5
PE
9730 * xterm.c (x_catch_errors): Remove duplicate declaration.
9731
266c9547
PE
9732 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9733
79c49ad2
PE
9734 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9735
368f4090
JM
97362011-04-10 Jim Meyering <meyering@redhat.com>
9737
9738 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9739 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9740 return ssize_t not "int", and use size_t as the buffer length.
9741 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9742 * gnutls.h: Update declarations.
9743 * process.c (read_process_output): Use ssize_t, to match.
9744 (send_process): Likewise.
9745
a32d4040
CY
97462011-04-09 Chong Yidong <cyd@stupidchicken.com>
9747
9748 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9749
8546720e 97502011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 9751
04f2d78b
CB
9752 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9753 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 9754
8546720e
GM
9755 * xterm.c (handle_one_xevent):
9756 * xmenu.c (create_and_show_popup_menu):
9757 * xselect.c (x_decline_selection_request)
9758 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 9759
0a2f5c1a 97602011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
9761
9762 Fix some uses of `int' instead of EMACS_INT.
9763 * search.c (string_match_1, fast_string_match)
9764 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9765 (scan_buffer, find_next_newline_no_quit)
9766 (find_before_next_newline, search_command, Freplace_match)
9767 (Fmatch_data): Make some `int' variables be EMACS_INT.
9768
9769 * xdisp.c (display_count_lines): 3rd argument and return value now
9770 EMACS_INT. All callers changed.
9771 (pint2hrstr): Last argument is now EMACS_INT.
9772
9773 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9774 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9775 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9776 (decode_coding_utf_16, decode_coding_emacs_mule)
9777 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9778 (decode_coding_ccl, decode_coding_charset)
9779 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9780 (decode_coding_iso_2022, decode_coding_emacs_mule)
9781 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9782 <char_offset, last_offset>: Declare EMACS_INT.
9783 (encode_coding_utf_8, encode_coding_utf_16)
9784 (encode_coding_emacs_mule, encode_invocation_designation)
9785 (encode_designation_at_bol, encode_coding_iso_2022)
9786 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9787 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9788 Declare EMACS_INT.
9789 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9790 (encode_invocation_designation): Last argument P_NCHARS is now
9791 EMACS_INT.
9792 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9793 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9794
9795 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9796 All users changed.
9797
9798 * ccl.c (Fccl_execute_on_string): Declare some variables
9799 EMACS_INT.
9800
8546720e 98012011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
9802
9803 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9804
4e19a977
CS
98052011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9806
9807 * process.c (Fformat_network_address): Doc fix.
9808
87302331
R
98092011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9810
ee7683eb 9811 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 9812
cbb59342
CY
98132011-04-08 Chong Yidong <cyd@stupidchicken.com>
9814
9815 * keyboard.c (read_char): Call Lisp function help-form-show,
9816 instead of using internal_with_output_to_temp_buffer.
9817 (Qhelp_form_show): New var.
e0d38eeb 9818 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
9819
9820 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9821
9822 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9823
e67a13ab
CY
98242011-04-06 Chong Yidong <cyd@stupidchicken.com>
9825
04f2d78b
CB
9826 * process.c (Flist_processes): Remove to Lisp.
9827 (list_processes_1): Delete.
e67a13ab 9828
973f782d
EZ
98292011-04-06 Eli Zaretskii <eliz@gnu.org>
9830
7c106b1e
EZ
9831 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9832
973f782d
EZ
9833 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9834
41cf7d1a 98352011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 9836
ca23cc88
PE
9837 Fix more problems found by GCC 4.6.0's static checks.
9838
f390e2d5
PE
9839 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9840
42eea0d0
PE
9841 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9842
b69769da 9843 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 9844
f9541e84
PE
9845 * xdisp.c (vmessage): Mark as a printf-like function.
9846
13841b55
PE
9847 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9848
c136c10f
PE
9849 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9850
5e2d4a30
PE
9851 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9852 printf-like functions.
9853 (tiff_load): Add casts to remove these marks before passing them
9854 to system-supplied API.
9855
583f48b9
PE
9856 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9857
b25d760e
PE
9858 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9859 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
9860 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9861 directly, rather than having caller test rule sign. This avoids
9862 some unnecessary tests.
9863 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9864 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9865 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 9866
bc7b6697 9867 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 9868 (xfont_open): Avoid unnecessary tests.
bc7b6697 9869
27ccc379
PE
9870 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9871
dcd5c89a
PE
9872 * composite.h, composite.c (composition_gstring_put_cache):
9873 Use EMACS_INT, not int, for length.
9874
b13a45c6
PE
9875 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9876 breaking out part of COMPOSITION_DECODE_RULE.
9877 (COMPOSITION_DECODE_RULE): Use it.
9878 * composite.c (get_composition_id): Remove unused local vars,
9879 by using the new macro.
9880
1e792e4d
PE
9881 * textprop.c (set_text_properties_1): Change while to do-while,
9882 since the condition is always true at first.
9883
dc6c6455 9884 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
9885 (interval_deletion_adjustment): Return unsigned value.
9886 All uses changed.
dc6c6455 9887
aba7731a
PE
9888 * process.c (list_processes_1, create_pty, read_process_output):
9889 (exec_sentinel): Remove vars that were set but not used.
afd4052b 9890 (create_pty): Remove unnecessary "volatile"s.
bc57d757 9891 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 9892 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 9893 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 9894
fdfc4bf3
PE
9895 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9896
fca8fe46 9897 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 9898 (update_syntax_table): Use unsigned instead of int.
fca8fe46 9899
06a0259a 9900 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 9901 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 9902 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 9903
e7b9e80f
PE
9904 * print.c (print_error_message): Avoid int overflow.
9905
56201685
PE
9906 * font.c (font_list_entities): Redo for clarity,
9907 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9908
78834453 9909 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 9910 (font_score): Avoid potential overflow in diff calculation.
78834453 9911
0bc0b309 9912 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 9913 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 9914
e610eaca
PE
9915 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9916
b895abce
PE
9917 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9918 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9919 can always succeed if overflow has undefined behavior.
9920
1f1d9321 9921 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 9922 (wordify): Omit three unnecessary tests.
1f1d9321 9923
c59478bc
PE
9924 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9925 All callers changed. This avoids the need for an unused var.
9926
79b73827
PE
9927 * casefiddle.c (casify_region): Remove var that is set but not used.
9928
a4db5dfe
PE
9929 * dired.c (file_name_completion): Remove var that is set but not used.
9930
43aae36e
PE
9931 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9932
2a47c44d 9933 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 9934 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 9935
a37c69bf
PE
9936 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9937 Check for integer overflow on size calculations.
9938
328ab8e7
PE
9939 * buffer.c (Fprevious_overlay_change): Remove var that is set
9940 but not used.
9941
e5a2a5cb
PE
9942 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9943 Remove vars that are set but not used.
8d84a6eb 9944 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 9945 (timer_check_2): Mark vars as initialized.
e5a2a5cb 9946
a60e5f68
PE
9947 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9948
f661cb61 9949 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 9950 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 9951
f0397f5a
PE
9952 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9953 that are set but not used.
9954
8664db06 9955 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 9956 if XCreateBitmapFromData fails (Bug#8410).
8664db06 9957
6abdaa4a
PE
9958 * xselect.c (x_get_local_selection, x_handle_property_notify):
9959 Remove vars that are set but not used.
9960
0ce7538d 9961 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 9962 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 9963
9ae848fc
PE
9964 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9965 Remove var that is set but not used.
0b918413
PE
9966 (scroll_bar_windows_size): Now size_t, not int.
9967 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9968 Check for overflow.
9ae848fc 9969
a5a62657
PE
9970 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9971 (map_tty_color) [!defined MSDOS]: Likewise.
9972
5c5cdd39
PE
9973 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9974
66ebf983
PE
9975 * coding.c: Remove vars that are set but not used.
9976 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9977 All callers changed.
9978 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9979 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9980 (decode_coding_charset): Remove vars that are set but not used.
9981
1be4d761
PE
9982 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9983 that is set but not used.
9984
47553fa8
PE
9985 * print.c (print_object): Remove var that is set but not used.
9986
1f7196bf 9987 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
9988 The gnulib version avoids calling malloc in the usual case,
9989 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9990 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9991 * filelock.c (current_lock_owner): Likewise.
9992 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9993 * sysdep.c: Include allocator.h, careadlinkat.h.
9994 (emacs_no_realloc_allocator): New static constant.
9995 (emacs_readlink): New function.
fdb61804
PE
9996 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9997 ../lib/careadlinkat.h.
d1fdcab7 9998
f84c17c7
SM
99992011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10000
10001 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10002 first non-nil return value).
10003
ef3862ad
JD
100042011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10005
10006 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10007 if not defined (Bug#8403).
10008
376a7006
JB
100092011-04-02 Juanma Barranquero <lekktu@gmail.com>
10010
10011 * xdisp.c (display_count_lines): Remove parameter `start',
10012 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10013 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10014 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10015 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10016 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10017 and thereabouts. All callers changed.
10018 (get_per_char_metric): Remove parameter `f', unused since
10019 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10020
6ca3801d
JM
100212011-04-02 Jim Meyering <meyering@redhat.com>
10022
10023 do not dereference NULL upon failed strdup
10024 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10025 (ns_get_family): Likewise.
10026
d8e2b5ba
JB
100272011-04-02 Juanma Barranquero <lekktu@gmail.com>
10028
10029 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10030
8c74fcbd
JD
100312011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10032
10033 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10034 later (Bug#8403).
10035
7200d79c
SM
100362011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10037
03408648 10038 Add lexical binding.
7200d79c 10039
03408648
SM
10040 * window.c (Ftemp_output_buffer_show): New fun.
10041 (Fsave_window_excursion):
10042 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10043
10044 * lread.c (lisp_file_lexically_bound_p): New function.
10045 (Fload): Bind Qlexical_binding.
10046 (readevalloop): Remove `evalfun' arg.
10047 Bind Qinternal_interpreter_environment.
10048 (Feval_buffer): Bind Qlexical_binding.
10049 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10050 Mark as dynamic.
10051 (syms_of_lread): Declare `lexical-binding'.
10052
10053 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10054
10055 * keyboard.c (eval_dyn): New fun.
10056 (menu_item_eval_property): Use it.
ca105506
SM
10057
10058 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10059
03408648
SM
10060 * fns.c (concat, mapcar1): Accept byte-code-functions.
10061
10062 * eval.c (Fsetq): Handle lexical vars.
10063 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10064 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10065 (FletX, Flet): Obey lexical binding.
10066 (Fcommandp): Handle closures.
10067 (Feval): New `lexical' arg.
10068 (eval_sub): New function extracted from Feval. Use it almost
10069 everywhere where Feval was used. Look up vars in lexical env.
10070 Handle closures.
10071 (Ffunctionp): Move from subr.el.
10072 (Ffuncall): Handle closures.
10073 (apply_lambda): Remove `eval_flags'.
10074 (funcall_lambda): Handle closures and new byte-code-functions.
10075 (Fspecial_variable_p): New function.
10076 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10077 but without exporting it to Lisp.
23aba0ea 10078
23aba0ea 10079 * doc.c (Fdocumentation, store_function_docstring):
03408648 10080 * data.c (Finteractive_form): Handle closures.
23aba0ea 10081
03408648
SM
10082 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10083 interactive spec.
ba83908c 10084
04f2d78b
CB
10085 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10086 New byte-codes.
03408648
SM
10087 (exec_byte_code): New function extracted from Fbyte_code to handle new
10088 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10089
03408648 10090 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10091
03408648 10092 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10093
e2abce01
JB
100942011-03-31 Juanma Barranquero <lekktu@gmail.com>
10095
10096 * xdisp.c (redisplay_internal): Fix prototype.
10097
63696a73 100982011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10099
63696a73 10100 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10101 (try_scrolling): Use it when setting scroll_limit.
10102 Limit scrolling to 100 screen lines.
63696a73
EZ
10103 (redisplay_window): Even when falling back on "recentering",
10104 position point in the window according to scroll-conservatively,
10105 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10106
10107 (try_scrolling): When point is above the window, allow searching
10108 as far as scroll_max, or one screenful, to compute vertical
10109 distance from PT to the scroll margin position. This prevents
10110 try_scrolling from unnecessarily failing when
10111 scroll-conservatively is set to a value slightly larger than the
10112 window height. Clean up the case of PT below the margin at bottom
10113 of window: scroll_max can no longer be INT_MAX. When aggressive
10114 scrolling is in use, don't let point enter the opposite scroll
10115 margin as result of the scroll.
10116 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10117 threshold of 100 lines for never-recentering scrolling.
10118
e4cc2dfc
JB
101192011-03-31 Juanma Barranquero <lekktu@gmail.com>
10120
10121 * dispextern.h (move_it_by_lines):
10122 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10123 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10124 (message_log_check_duplicate): Remove parameters `prev_bol' and
10125 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10126 (redisplay_internal): Remove parameter `preserve_echo_area',
10127 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10128
10129 * indent.c (Fvertical_motion):
10130 * window.c (window_scroll_pixel_based, Frecenter):
10131 Don't pass `need_y_p' to `move_it_by_lines'.
10132
1c470562
SM
101332011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10134
44f230aa
SM
10135 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10136 steal a few bits to be more compact.
10137 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10138 Remove unneeded casts.
10139
1c470562
SM
10140 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10141
888adce9
ZK
101422011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10143
10144 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10145 binding" message (bug#7967).
10146
f838ed7b
PE
101472011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10148
77861b95
PE
10149 Fix more problems found by GCC 4.6.0's static checks.
10150
de6dbc14
PE
10151 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10152 Remove unused local var.
10153
f838ed7b
PE
10154 * editfns.c (Fmessage_box): Remove unused local var.
10155
792c7b2b
PE
10156 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10157 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10158 Omit unused local vars.
c499e557 10159 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10160 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10161 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10162 Omit unused local var.
10163
ba0165e1
PE
10164 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10165 Don't assume string length fits in int.
32ad8845 10166 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10167 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10168
3c59b4c9
PE
10169 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10170 instead of alloca (Bug#8344).
10171
a3eed478 10172 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10173 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10174
eb4d412d
PE
10175 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10176
1658b401
PE
10177 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10178 concerns.
10179
10180 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10181
10182 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10183
9a2c6e05
PE
10184 * keyboard.c (syms_of_keyboard): Use the same style as later
10185 in this function when indexing through an array. This also
10186 works around GCC bug 48267.
10187
03d0a109
PE
10188 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10189
44f730c8
PE
10190 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10191
fe75f926
PE
10192 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10193 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10194
ffa8c828
PE
10195 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10196 This avoids undefined behavior on integer overflow, and is a bit
10197 more convenient anyway since it is compared to a size_t variable.
10198
c5101a77
PE
10199 Variadic C functions now count arguments with size_t, not int.
10200 This avoids an unnecessary limitation on 64-bit machines, which
10201 caused (substring ...) to crash on large vectors (Bug#8344).
10202 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10203 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10204 All variadic functions and their callers changed accordingly.
c5101a77
PE
10205 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10206 * data.c (arith_driver, float_arith_driver): Likewise.
10207 * editfns.c (general_insert_function): Likewise.
10208 * eval.c (struct backtrace.nargs, interactive_p)
10209 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10210 (funcall_lambda, mark_backtrace): Likewise.
10211 * fns.c (concat): Likewise.
10212 * frame.c (x_set_frame_parameters): Likewise.
10213 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10214 0 if not found, not -1. All callers changed.
10215
dd3f25f7
PE
10216 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10217 (stack_copy_size): Now size_t, not int.
10218 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10219
461c2ab9
JB
102202011-03-28 Juanma Barranquero <lekktu@gmail.com>
10221
10222 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10223 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10224 All callers changed.
10225
10226 * lisp.h (multibyte_char_to_unibyte):
10227 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10228 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10229 * character.h (CHAR_TO_BYTE8):
10230 * cmds.c (internal_self_insert):
10231 * editfns.c (general_insert_function):
10232 * keymap.c (push_key_description):
10233 * search.c (Freplace_match):
10234 * xdisp.c (message_dolog, set_message_1): All callers changed.
10235
f6d62986
SM
102362011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10237
10238 * keyboard.c (safe_run_hook_funcall): New function.
10239 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10240 don't set the hook to nil, but remove the offending function instead.
10241 (Qcommand_hook_internal): Remove, unused.
10242 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10243 Vcommand_hook_internal.
10244
10245 * eval.c (enum run_hooks_condition): Remove.
10246 (funcall_nil, funcall_not): New functions.
10247 (run_hook_with_args): Call each function through a `funcall' argument.
10248 Remove `cond' argument, now redundant.
10249 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10250 (Frun_hook_with_args_until_failure): Adjust accordingly.
10251 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10252
1db5b1ad
JB
102532011-03-28 Juanma Barranquero <lekktu@gmail.com>
10254
10255 * dispextern.h (string_buffer_position): Remove declaration.
10256
10257 * print.c (strout): Remove parameter `multibyte', unused since
10258 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10259
10260 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10261 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10262 All callers changed.
10263
10264 * w32.c (_wsa_errlist): Use braces for struct initializers.
10265
10266 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10267 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10268 All callers changed.
10269 (string_buffer_position): Likewise. Also, make static (it's never
10270 used outside xdisp.c).
10271 (cursor_row_p): Remove parameter `w', unused since
10272 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10273 (decode_mode_spec): Remove parameter `precision', introduced during
10274 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10275 All callers changed.
10276
5ffb62aa
JD
102772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10278
10279 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10280
461c2ab9 102812011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10282
10283 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10284 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10285 (ns_update_auto_hide_menu_bar): New functions.
10286 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10287 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10288 ns_constrain_all_frames.
10289 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10290 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10291
5c380ffb
JD
102922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10293
10294 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10295
9af30bdf
GM
102962011-03-27 Glenn Morris <rgm@gnu.org>
10297
10298 * syssignal.h: Replace RETSIGTYPE with void.
10299 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10300 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10301 Replace SIGTYPE with void everywhere.
10302 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10303 * s/template.h (SIGTYPE): Remove commented out definition.
10304
e2abce01
JB
103052011-03-26 Eli Zaretskii <eliz@gnu.org>
10306
10307 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10308 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10309
f868cd8a
JB
103102011-03-26 Juanma Barranquero <lekktu@gmail.com>
10311
59eb0929
JB
10312 * w32.c (read_unc_volume): Use parameter `henum', instead of
10313 global variable `wget_enum_handle'.
10314
10315 * keymap.c (describe_vector): Remove parameters `indices' and
10316 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10317 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10318
f868cd8a
JB
10319 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10320
10321 * keyboard.c (timer_check): Remove parameter `do_it_now',
10322 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10323 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10324 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10325
10326 * keyboard.c (read_char):
10327 * w32menu.c (w32_menu_display_help):
10328 * xmenu.c (show_help_event, menu_help_callback):
10329 Adjust calls to `show_help_echo'.
10330
10331 * gtkutil.c (xg_maybe_add_timer):
10332 * keyboard.c (readable_events):
10333 * process.c (wait_reading_process_output):
10334 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10335
10336 * insdel.c (adjust_markers_gap_motion):
10337 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10338 (gap_left, gap_right): Don't call it.
10339
2ecf6fdb
CY
103402011-03-25 Chong Yidong <cyd@stupidchicken.com>
10341
10342 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10343 incurred during fontification.
10344
6b1f9ba4
JB
103452011-03-25 Juanma Barranquero <lekktu@gmail.com>
10346
10347 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10348 (DEFVAR_PER_BUFFER): Don't pass it.
10349
10350 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10351 (scrolling_window): Don't pass it.
10352
0f4a96b5
JB
103532011-03-25 Juanma Barranquero <lekktu@gmail.com>
10354
10355 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10356
10357 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10358 and `suffix'.
10359 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10360 of variables specific to SELinux and computation of `encoded_absname'.
10361
10362 * image.c (XPutPixel): Remove unused variable `height'.
10363
10364 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10365
10366 * unexw32.c (get_section_info): Remove unused variable `section'.
10367
10368 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10369 (system_process_attributes): Remove unused variable `sess'.
10370 (sys_read): Remove unused variable `err'.
10371
10372 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10373 (w32_wnd_proc): Remove unused variable `isdead'.
10374 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10375 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10376 (x_create_tip_frame): Remove unused variable `tem'.
10377
10378 * w32inevt.c (w32_console_read_socket):
10379 Remove unused variable `no_events'.
10380
10381 * w32term.c (x_draw_composite_glyph_string_foreground):
10382 Remove unused variable `width'.
10383
1149507c
JB
103842011-03-24 Juanma Barranquero <lekktu@gmail.com>
10385
10386 * w32term.c (x_set_glyph_string_clipping):
10387 Don't pass uninitialized region to CombineRgn.
10388
9c88f339
JB
103892011-03-23 Juanma Barranquero <lekktu@gmail.com>
10390
10391 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10392 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10393 (Fx_close_connection): Remove unused variable `i'.
10394
10395 * w32font.c (w32font_draw): Return number of glyphs.
10396 (w32font_open_internal): Remove unused variable `i'.
10397 (w32font_driver): Add missing initializer.
10398
10399 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10400 (fill_in_menu): Remove unused variable `items_added'.
10401
10402 * w32term.c (last_mouse_press_frame): Remove static global variable.
10403 (w32_clip_to_row): Remove unused variable `f'.
10404 (x_delete_terminal): Remove unused variable `i'.
10405
10406 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10407 (NOTHING): Remove unused static global variable.
10408 (uniscribe_check_otf): Remove unused variable `table'.
10409 (uniscribe_font_driver): Add missing initializers.
10410
dee091a3
JD
104112011-03-23 Julien Danjou <julien@danjou.info>
10412
10413 * term.c (Fsuspend_tty, Fresume_tty):
10414 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10415 * window.c (temp_output_buffer_show):
10416 * insdel.c (signal_before_change):
10417 * frame.c (Fhandle_switch_frame):
10418 * fileio.c (Fdo_auto_save):
10419 * emacs.c (Fkill_emacs):
10420 * editfns.c (save_excursion_restore):
10421 * cmds.c (internal_self_insert):
10422 * callint.c (Fcall_interactively):
10423 * buffer.c (Fkill_all_local_variables):
10424 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10425 Use Frun_hooks.
0f4a96b5 10426 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10427 unconditionally since it does the check itself.
dee091a3 10428
2c520ab5 104292011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10430
c9c49752
PE
10431 Fix more problems found by GCC 4.5.2's static checks.
10432
8abc3f12
PE
10433 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10434 the first time through the loop, since we know p0 < p1 then.
10435 This also avoids a gcc -Wstrict-overflow warning.
10436
a2d26660
PE
10437 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10438 leading to a memory leak, possible in functions like
10439 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10440 of objects (Bug#8318).
a2d26660 10441
916c72e9
PE
10442 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10443 that could (at least in theory) be that large.
10444
19ab8a18
PE
10445 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10446 This is less likely to overflow, and avoids undefined behavior if
10447 overflow does occur. All callers changed. Use strtoul to scan
10448 for the unsigned long integer.
b7cbbd6f
PE
10449 (pint2hrstr): Simplify and tune code slightly.
10450 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10451
f0641eff
PE
10452 * scroll.c (do_scrolling): Work around GCC bug 48228.
10453 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10454
7f650bb9
PE
10455 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10456 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10457 (validate_x_resource_name): Simplify count usage.
10458 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10459
37dd57d1
PE
10460 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10461 fail (Bug#8306).
81e56e61 10462
699979fc 10463 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10464
401bf9b4
PE
10465 * process.c (Fmake_network_process): Use socklen_t, not int,
10466 where POSIX says socklen_t is required in portable programs.
10467 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10468 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10469 (Fmake_network_process, server_accept_connection):
10470 (wait_reading_process_output, read_process_output):
10471 Likewise.
10472
b93aacde
PE
10473 * process.c: Rename or move locals to avoid shadowing.
10474 (list_processes_1, Fmake_network_process):
10475 (read_process_output_error_handler, exec_sentinel_error_handler):
10476 Rename or move locals.
4dc343ee 10477 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10478 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10479 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10480 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10481 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10482
af8a867c 10483 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10484 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10485 Include tparam.h instead, since it declares them.
af8a867c
PE
10486 * cm.h (PC): Remove extern decl; tparam.h now does this.
10487 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10488 * terminfo.c: Include tparam.h, to check interfaces.
10489 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10490 (tparam): Adjust signature to match interface in tparam.h;
10491 this removes some undefined behavior. Check that outstring and len
10492 are zero, which they always are with Emacs.
10493 * tparam.h (PC, BC, UP): New extern decls.
10494
0248044d 10495 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10496 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10497
8ff096c1 10498 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10499 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10500 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10501 (ftfont_list): Remove unused local.
49eaafba
PE
10502 (get_adstyle_property, ftfont_pattern_entity):
10503 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10504 Rename locals to avoid shadowing.
8ff096c1 10505
e2be39f6
PE
10506 * xfont.c (xfont_list_family): Mark var as initialized.
10507
c9735e30
PE
10508 * xml.c (make_dom): Now static.
10509
8f5201ae
PE
10510 * composite.c (composition_compute_stop_pos): Rename local to
10511 avoid shadowing.
b246f932
PE
10512 (composition_reseat_it): Remove unused locals.
10513 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10514 (composition_update_it): Mark var as initialized.
11b61122
PE
10515 (find_automatic_composition): Mark vars as initialized,
10516 with a FIXME (Bug#8290).
8f5201ae 10517
760fbc2c
PE
10518 character.h: Rename locals to avoid shadowing.
10519 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10520 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10521 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10522 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10523 to avoid shadowing.
10524
ff08eb85
PE
10525 * textprop.c (property_change_between_p): Remove; unused.
10526
fc7bf025
PE
10527 * intervals.c (interval_start_pos): Now static.
10528
235d7abc
PE
10529 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10530
44f230aa
SM
10531 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10532 Rename locals to avoid shadowing.
3e7d6594 10533
50060332
PE
10534 * sound.c (wav_play, au_play, Fplay_sound_internal):
10535 Fix pointer signedness.
d01f234b 10536 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10537 (wav_play): Initialize a variable to 0, to prevent undefined
10538 behavior (Bug#8278).
50060332 10539
c4fc4e30
PE
10540 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10541
918436ed
PE
10542 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10543
c939f91b
PE
10544 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10545 clobbering (Bug#8298).
b9c7f648
PE
10546 * sysdep.c (sys_subshell): Likewise.
10547 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10548
6bd8c144
PE
10549 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10550 This should get cleaned up, so that child_setup has the
10551 same signature on all platforms.
10552
7710357c 10553 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10554 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10555
c59da222
CY
105562011-03-22 Chong Yidong <cyd@stupidchicken.com>
10557
10558 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10559 not to be necessary, and produces flickering.
10560
66b87493
GM
105612011-03-20 Glenn Morris <rgm@gnu.org>
10562
10563 * config.in: Remove file.
10564
45b6f6d5
JB
105652011-03-20 Juanma Barranquero <lekktu@gmail.com>
10566
10567 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10568 are now in src/globals.h.
10569 (syms_of_minibuf): Remove spurious & from previous change.
10570
cd394be1 105712011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10572
10573 * minibuf.c (completing-read-function): New variable.
10574 (completing-read-default): Rename from completing-read.
10575 (completing-read): Call completing-read-function.
10576
b14e3e21
CY
105772011-03-19 Juanma Barranquero <lekktu@gmail.com>
10578
10579 * xfaces.c (Fx_load_color_file):
10580 Read color file from absolute filename (bug#8250).
10581
f2b726e6
JB
105822011-03-19 Juanma Barranquero <lekktu@gmail.com>
10583
10584 * makefile.w32-in: Update dependencies.
10585
09f6ff02
EZ
105862011-03-17 Eli Zaretskii <eliz@gnu.org>
10587
10588 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10589
29a6015a
PE
105902011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10591
a3a6c54e
PE
10592 Fix more problems found by GCC 4.5.2's static checks.
10593
b766f867
PE
10594 * process.c (make_serial_process_unwind, send_process_trap):
10595 (sigchld_handler): Now static.
10596
be02381c
PE
10597 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10598 That way, the code declares only the vars that it needs.
10599 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10600 * s/cygwin.h (PTY_ITERATION): Likewise.
10601 * s/darwin.h (PTY_ITERATION): Likewise.
10602 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10603
57048744
PE
10604 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10605 * process.c (allocate_pty): Don't declare stb unless it's needed.
10606
7914961c 10607 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10608 (CONSTANTLIM): Remove; unused.
10609 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10610 Define only if needed.
7914961c 10611
b3967b18
PE
10612 * unexelf.c (unexec): Name an expression,
10613 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10614 Use a different way to cause a compilation error if anyone uses
10615 n rather than nn, a way that does not involve shadowing.
73366a00 10616 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10617
29a6015a
PE
10618 * deps.mk (unexalpha.o): Remove; unused.
10619
43cfc33e 10620 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10621 * unexec.h: New file.
ce701a33
PE
10622 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10623 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10624 Depend on unexec.h.
10625 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10626 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10627 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10628 Change as necessary to match prototype in unexec.h.
ce701a33 10629
01f44d5a
PE
10630 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10631 shadowing.
4f63c6bb 10632 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10633
a6670b0b
PE
10634 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10635 Rename locals to avoid shadowing.
10636
cef2010d 10637 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10638 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10639
d4d7173a
PE
10640 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10641
f08b802a
PE
10642 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10643 warning when compiling print.c.
10644
3ddb0639
PE
10645 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10646 instead of using an uninitialized var.
5ad03b97 10647 (font_sort_entities): Mark var as initialized.
3ddb0639 10648
170a2692
PE
10649 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10650
e663c700
PE
10651 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10652 pointers to constants.
89bc529a 10653 (font_parse_fcname): Remove unused vars.
7b81e2d0 10654 (font_delete_unmatched): Now static.
ea838e10 10655 (font_get_spec): Remove; unused.
13a547c6
PE
10656 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10657 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10658 Rename or move locals to avoid shadowing.
e663c700 10659
2a80c887 10660 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10661 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10662
1384fa33 10663 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10664 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10665
8b2c52e9
PE
10666 * alloc.c (mark_backtrace): Move decl from here ...
10667 * lisp.h: ... to here, so that it can be checked.
10668
475545b5 10669 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10670 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10671 (lisp_indirect_variable): Name an expression,
10672 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10673 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10674
b1349114 10675 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10676 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10677 Use const pointer when appropriate.
b1349114 10678
a2928364
PE
10679 * lisp.h (get_system_name, get_operating_system_release):
10680 Move decls here, to check interfaces.
10681 * process.c (get_operating_system_release): Move decl to lisp.h.
10682 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10683 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10684 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10685 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10686 (Fformat_time_string, Fencode_time, Finsert_char):
10687 (Ftranslate_region_internal, Fformat):
10688 Rename or remove local vars to avoid shadowing.
9710023e 10689 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10690
a415e694
PE
10691 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10692 avoid shadowing.
10693
8ef4622d
PE
10694 * lisp.h (eassert): Check that the argument compiles, even if
10695 ENABLE_CHECKING is not defined.
10696
946f9a5b
PE
10697 * data.c (Findirect_variable): Name an expression, to avoid
10698 gcc -Wbad-function-cast warning.
112396d6 10699 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10700 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10701 (Fmake_variable_buffer_local, Fmake_local_variable):
10702 Mark variables as initialized.
52746918 10703 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10704
e5aab7e7 10705 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10706 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10707 Rename locals to avoid shadowing.
dff45157
PE
10708 (mark_stack): Move local variables into the #ifdef region where
10709 they're used.
7bc26fdb
PE
10710 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10711 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10712 needed otherwise.
10713 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10714 (GC_STRING_CHARS): Remove; not used.
d40d4be1 10715 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 10716
e5aab7e7
PE
10717 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10718 avoids undefined behavior in theory.
10719
4da60324
PE
10720 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10721
88043301
PE
10722 Use functions, not macros, for up- and down-casing (Bug#8254).
10723 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10724 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10725 to use the following functions instead of these macros.
10726 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10727 EMACS_INT, since callers assume the returned value fits in int.
10728 (upcase1): Likewise, for UPCASE_TABLE.
10729 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 10730 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 10731 the race-condition problem in the old DOWNCASE.
88043301 10732
19ed5445
PE
10733 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10734 Rename locals to avoid shadowing.
10735 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
10736 (regex_compile, re_search_2, re_match_2_internal):
10737 Remove unused local vars.
952db0d7
PE
10738 (FREE_VAR): Rewrite so as not to use empty "else",
10739 which gcc can warn about.
da053e48 10740 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
10741 (RETALLOC_IF): Define only if needed.
10742 (WORDCHAR_P): Likewise. This one is never needed, but is used
10743 only in a comment talking about a compiler bug, so put inside
10744 the #if 0 of that comment.
10745 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10746 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10747 Remove; unused.
19ed5445 10748
1f3561e4 10749 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
10750 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10751 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 10752
ded6f8f7
PE
10753 * search.c (simple_search): Remove unused var.
10754
dbd37a95
PE
10755 * dired.c (compile_pattern): Move decl from here ...
10756 * lisp.h: ... to here, so that it can be checked.
10757 (struct re_registers): New forward decl.
10758
7e47afad
PE
10759 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10760
85f24f61
PE
10761 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10762 All uses changed.
10763 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10764 Rename locals to avoid shadowing.
5671df8f 10765 (Fvertical_motion): Mark locals as initialized.
85f24f61 10766
181aa2be 10767 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 10768 (casify_region): Mark local as initialized.
181aa2be 10769
930d429c
PE
10770 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10771
7082eac6
PE
10772 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10773 New macros, so that the caller can use some names other than
10774 gcpro1, gcpro2, etc.
10775 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10776 of the new macros.
10777 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10778 argument, for consistency with GCPRO2_VAR, etc: it is now the
10779 prefix of the variable, not the variable itself. All uses
10780 changed.
38b2c076
PE
10781 * dired.c (directory_files_internal, file_name_completion):
10782 Rename locals to avoid shadowing.
10783
15206ed9
PE
10784 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10785 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10786 dired.c's scmp function, had undefined behavior.
10787 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10788 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10789 * buffer.h: ... to here, because these macros use current_buffer,
10790 and the new implementation with inline functions needs to have
10791 current_buffer in scope now, rather than later when the macros
10792 are used.
10793 (downcase, upcase1): New static inline functions.
10794 (DOWNCASE, UPCASE1): Reimplement using these functions.
10795 This avoids undefined behavior in expressions like
10796 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10797 from race conditions in accessing the global variables
10798 case_temp1 and case_temp2.
10799 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10800 * lisp.h (case_temp1, case_temp2): Remove their decls.
10801 * character.h (ASCII_CHAR_P): Move from here ...
10802 * lisp.h: ... to here, so that the inline functions mentioned
10803 above can use them.
10804
4a6bea26
PE
10805 * dired.c (directory_files_internal_unwind): Now static.
10806
f14b7e14
PE
10807 * fileio.c (file_name_as_directory, directory_file_name):
10808 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10809 Now static.
2893f146
PE
10810 (file_name_as_directory): Use const pointers when appropriate.
10811 (Fexpand_file_name): Likewise. In particular, newdir might
10812 point at constant storage, so make it a const pointer.
fd4ead52 10813 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
10814 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10815 signedness issues.
f839df0c
PE
10816 (Fset_file_times, Finsert_file_contents, auto_save_error):
10817 Rename locals to avoid shadowing.
f14b7e14 10818
5716756e 10819 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
10820 (Ftry_completion, Fall_completions): Rename or remove locals
10821 to avoid shadowing.
5716756e 10822
b4c3046a
PE
10823 * marker.c (bytepos_to_charpos): Remove; unused.
10824
b45db522
PE
10825 * lisp.h (verify_bytepos, count_markers): New decls,
10826 so that gcc does not warn that these functions aren't declared.
10827
85876d07
PE
10828 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10829 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 10830 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 10831 (copy_text): Remove unused local var.
85876d07 10832
03d78a21 10833 * filelock.c (within_one_second): Now static.
b3dd38ab 10834 (lock_file_1): Rename local to avoid shadowing.
03d78a21 10835
5df8f01b
PE
10836 * buffer.c (fix_overlays_before): Mark locals as initialized.
10837 (fix_start_end_in_overlays): Likewise. This function should be
10838 simplified by using pointers-to-pointers, but that's a different
10839 matter.
b1d876f1 10840 (switch_to_buffer_1): Now static.
8f54f30a
PE
10841 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10842 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 10843
a70072c9 10844 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 10845 Fix pointer signedness issue.
edced198
PE
10846 (sys_subshell): Mark local as volatile if checking for lint,
10847 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 10848 (MAXPATHLEN): Define only if needed.
a70072c9 10849
a0977c44
PE
10850 * process.c (serial_open, serial_configure): Move decls from here ...
10851 * systty.h: ... to here, so that they can be checked.
10852
a884fdcc
PE
10853 * fns.c (get_random, seed_random): Move extern decls from here ...
10854 * lisp.h: ... to here, so that they can be checked.
10855
604efe86 10856 * sysdep.c (reset_io): Now static.
b8950c94 10857 (wait_for_termination_signal): Remove; unused.
604efe86 10858
38fc62d9
PE
10859 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10860 (copy_keymap_item, append_key, push_text_char_description):
10861 Now static.
1004a21a 10862 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 10863 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
10864 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10865 (describe_map_tree):
10866 Rename locals to avoid shadowing.
38fc62d9 10867
2f2650da
PE
10868 * keyboard.c: Declare functions static if they are not used elsewhere.
10869 (echo_char, echo_dash, cmd_error, top_level_2):
10870 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
10871 (read_char, kbd_buffer_get_event, make_lispy_position):
10872 (make_lispy_event, make_lispy_movement, apply_modifiers):
10873 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10874 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10875 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 10876 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 10877 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 10878
a053e86c 10879 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
10880 (mark_kboards): Move decl here ...
10881 * alloc.c (mark_kboards): ... from here.
a053e86c 10882
4752793e
PE
10883 * lisp.h (force_auto_save_soon): New decl.
10884
74f10ca7 10885 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
10886 (DEFINE_DUMMY_FUNCTION): New macro.
10887 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10888 Use it.
c03cd23f
PE
10889 (main): Add casts to avoid warnings
10890 if GCC considers string literals to be constants.
74f10ca7 10891
022e70d4
PE
10892 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10893
59d6fe83
PE
10894 * dbusbind.c: Pointer signedness fixes.
10895 (xd_signature, xd_append_arg, xd_initialize):
10896 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10897 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10898 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10899 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10900
78320123
PE
10901 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10902 if GCC considers string literals to be constants.
49cebcca 10903 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 10904
35ac2a97
SM
109052011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10906
fb103ca9
SM
10907 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10908 (print_preprocess, print_object): New macro to fix last change.
10909
35ac2a97
SM
10910 * print.c (print_preprocess): Don't forget font objects.
10911
62973b41
JB
109122011-03-16 Juanma Barranquero <lekktu@gmail.com>
10913
10914 * emacs.c (USAGE3): Doc fixes.
10915
0e48bb22
AS
109162011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10917
10918 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10919 structure.
10920
7684e57b
JB
109212011-03-14 Juanma Barranquero <lekktu@gmail.com>
10922
10923 * lisp.h (VWindow_system, Qfile_name_history):
10924 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10925 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10926 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10927
10928 * w32select.c: Don't #include "keyboard.h".
c96bbc66 10929 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
10930
10931 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10932 * w32console.c (detect_input_pending, read_input_pending)
10933 (encode_terminal_code):
10934 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10935 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10936 (w32_system_caret_y, Qfile_name_history):
10937 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10938 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10939 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10940 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10941 * w32proc.c (Qlocal, report_file_error):
10942 * w32term.c (Vwindow_system, updating_frame):
10943 * w32uniscribe.c (initialized, uniscribe_font_driver):
10944 Remove unneeded extern declarations.
10945
2aa46d6c
CY
109462011-03-14 Chong Yidong <cyd@stupidchicken.com>
10947
c96bbc66 10948 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 10949
cffc6f3b
CY
109502011-03-13 Chong Yidong <cyd@stupidchicken.com>
10951
10952 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10953 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10954 These macros can no longer be used for assignment.
10955
44f230aa
SM
10956 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10957 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
10958 (record_buffer_markers, fetch_buffer_markers): New functions for
10959 recording and fetching special buffer markers.
10960 (set_buffer_internal_1, set_buffer_temp): Use them.
10961
10962 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10963
10964 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10965
10966 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10967 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10968
10969 * xdisp.c (hscroll_window_tree):
10970 (reconsider_clip_changes): Use PT instead of BUF_PT.
10971
d251f04b
EZ
109722011-03-13 Eli Zaretskii <eliz@gnu.org>
10973
10974 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10975 $(EMACS_ROOT)/lib/intprops.h.
10976
f0c77cd1
PE
109772011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10978
3eca4629
PE
10979 Fix more problems found by GCC 4.5.2's static checks.
10980
7c86ee98
PE
10981 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10982 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
10983 (xg_free_frame_widgets): Make it clear that a local variable is
10984 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
10985 (gdk_window_get_screen): Make it clear that this macro is needed
10986 only if USE_GTK_TOOLTIP.
1e5524e7
PE
10987 (int_gtk_range_get_value): New function, which avoids a diagnostic
10988 from gcc -Wbad-function-cast.
10989 (xg_set_toolkit_scroll_bar_thumb): Use it.
10990 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10991 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
10992 (get_utf8_string, xg_get_file_with_chooser):
10993 Rename locals to avoid shadowing.
10994 (create_dialog): Move locals to avoid shadowing.
7c86ee98 10995
41729b81
PE
10996 * xgselect.c (xg_select): Remove unused var.
10997
f0c77cd1
PE
10998 * image.c (four_corners_best): Mark locals as initialized.
10999 (gif_load): Initialize transparent_p to zero (Bug#8238).
11000 Mark another local as initialized.
ec6cf4c6 11001 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11002
ce0ad53d 11003 * image.c (clear_image_cache): Now static.
d5d5a617 11004 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11005 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11006 (x_edge_detection): Remove unnecessary cast that
11007 gcc -Wbad-function-cast diagnoses.
2037898d 11008 (gif_load): Fix pointer signedness.
6ae141d6
PE
11009 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11010 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11011
33383987 110122011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11013
d32df629
PE
11014 Improve quality of tests for time stamp overflow.
11015 For example, without this patch (encode-time 0 0 0 1 1
11016 1152921504606846976) returns the obviously-bogus value (-948597
11017 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11018 reports time overflow. See
11019 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11020 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11021 * editfns.c: Include limits.h and intprops.h.
11022 (TIME_T_MIN, TIME_T_MAX): New macros.
11023 (time_overflow): Move earlier, to before first use.
11024 (hi_time, lo_time): New functions, for an accurate test for
11025 out-of-range times.
11026 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11027 (Fget_internal_run_time): Don't assume time_t fits in int.
11028 (make_time): Use list2 instead of Fcons twice.
11029 (Fdecode_time): More accurate test for out-of-range times.
11030 (check_tm_member): New function.
11031 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11032 (lisp_time_argument): Don't rely on undefined left-shift and
11033 right-shift behavior when checking for time stamp overflow.
8be6f318 11034
fe31d94c
PE
11035 * editfns.c (time_overflow): New function, refactoring common code.
11036 (Fformat_time_string, Fdecode_time, Fencode_time):
11037 (Fcurrent_time_string): Use it.
11038
8be6f318
PE
11039 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11040 * dired.c (make_time): Move to ...
11041 * editfns.c (make_time): ... here.
11042 * systime.h: Note the move.
11043
09d9db2c 110442011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11045
126bc0dc
YM
11046 * fringe.c (update_window_fringes): Remove unused variables.
11047
c47cbdfd
YM
11048 * unexmacosx.c (copy_data_segment): Also copy __got section.
11049 (Bug#8223)
11050
7ac80be9
EZ
110512011-03-12 Eli Zaretskii <eliz@gnu.org>
11052
c96bbc66 11053 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11054 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11055 Constify `char *' arguments and their references according to
11056 prototypes in tparam.h.
11057
ecb0f94d 11058 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11059
7ac80be9
EZ
11060 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11061 Adapt all references accordingly.
11062
11063 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11064
ef1fd07e
TT
110652011-03-11 Tom Tromey <tromey@redhat.com>
11066
11067 * buffer.c (syms_of_buffer): Remove obsolete comment.
11068
7ef4b50c
EZ
110692011-03-11 Eli Zaretskii <eliz@gnu.org>
11070
11071 * termhooks.h (encode_terminal_code): Declare prototype.
11072
11073 * msdos.c (encode_terminal_code): Don't declare prototype.
11074
11075 * term.c (encode_terminal_code): Now external again, used by
11076 w32console.c and msdos.c.
11077
44f230aa
SM
11078 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11079 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11080
4b1ec863 110812011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11082
1714f52b 11083 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11084
4b1ec863
PE
11085 * fringe.c (update_window_fringes): Mark locals as initialized
11086 (Bug#8227).
11087 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11088
524c7aa6
PE
11089 * alloc.c (mark_fringe_data): Move decl from here ...
11090 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11091 to check its interface.
11092 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11093
a5c0af81 11094 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11095 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11096 (fontset_font): Mark local as initialized.
a9a06e0b 11097 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11098
b4716021
PE
11099 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11100
811e9bac 11101 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11102 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11103 (x_own_selection, Fx_disown_selection_internal): Rename locals
11104 to avoid shadowing.
11105 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11106
7e3ab302
PE
11107 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11108 so that the caller can use some name other than gcpro1.
11109 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11110 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11111 (Fx_backspace_delete_keys_p):
11112 Use them to avoid shadowing, and rename vars to avoid shadowing.
11113 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11114 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11115 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11116 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11117 Remove unused locals.
7e3ab302
PE
11118 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11119 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11120 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11121 macros.
f78faa98 11122
e2b13473
PE
11123 * xterm.h (x_mouse_leave): New decl.
11124
77f23912
PE
11125 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11126 Remove unused functions.
cdf4ba58
PE
11127 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11128 (x_calc_absolute_position): Now static.
7411c686 11129 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11130 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11131 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11132 unless they are used.
38d0b34a
PE
11133 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11134 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11135 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11136 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11137 (x_error_catcher, x_connection_closed, x_error_handler):
11138 (x_error_quitter, xembed_send_message, x_iconify_frame):
11139 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11140 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11141 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11142
44f230aa
SM
11143 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11144 Rename or move locals to avoid shadowing.
6b463e58 11145 (tty_defined_color, merge_face_heights): Now static.
5967d051 11146 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11147 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11148 does not deduce is never used uninitialized.
73719eba
PE
11149 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11150 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11151
426994c3 11152 * terminal.c (store_terminal_param): Now static.
5489860b 11153
032f1620 11154 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11155 (set_frame_menubar): Remove unused local.
d4323972 11156 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11157 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11158 since they might point to immutable storage.
281585b0
PE
11159 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11160 since it's unused otherwise.
032f1620 11161
367c19e5 11162 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11163 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11164 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11165 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11166 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11167 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11168 does not deduce are never used uninitialized.
70739cbe 11169
07b48fa9
PE
11170 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11171
8868a238 11172 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11173 * window.c (window_loop, size_window):
11174 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11175
7e5cf297 11176 * window.c (display_buffer): Now static.
d6550a9f
PE
11177 (size_window): Mark variables that gcc -Wuninitialized
11178 does not deduce are never used uninitialized.
a586633d
PE
11179 * window.h (check_all_windows): New decl, to forestall
11180 gcc -Wmissing-prototypes diagnostic.
5b555da1 11181 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11182
f6095868
PE
11183 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11184 shadowing.
11185 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11186 Include <limits.h>.
11187 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11188 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11189 (load_charset_map): Mark variables that gcc -Wuninitialized
11190 does not deduce are never used uninitialized.
53df7c11 11191 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11192
f38b440c
PE
11193 * coding.c (coding_set_source, coding_set_destination):
11194 Use "else { /* comment */ }" rather than "else /* comment */;"
11195 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11196 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11197 a block, when the outer 'i' will do.
11198 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11199 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11200 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11201 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11202 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11203 Rename locals to avoid shadowing.
11204 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11205 * coding.c (emacs_mule_char, encode_invocation_designation):
11206 Now static, since they're not used elsewhere.
413bb2db 11207 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11208 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11209 (decode_coding_emacs_mule): Mark variables that gcc
11210 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11211 (detect_coding_iso_2022): Initialize a local variable that might
11212 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11213 this initialization is needed. (Bug#8211)
5f58e762
PE
11214 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11215 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11216 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11217 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11218 Remove unused macros.
f38b440c 11219
232b38b9 11220 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11221 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11222 * character.c (string_count_byte8): Likewise.
232b38b9 11223
fb90da1b
PE
11224 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11225 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11226
fb93dbc2
PE
11227 * chartab.c (copy_sub_char_table): Now static, since it's not used
11228 elsewhere.
5c156ace
PE
11229 (sub_char_table_ref_and_range, char_table_ref_and_range):
11230 Rename locals to avoid shadowing.
bbcd0949 11231 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11232
7d3b3862 11233 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11234 (BIDI_BOB): Remove unused macro.
7d3b3862 11235
6be7d3da
PE
11236 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11237 deduce are never used uninitialized.
c2ed9c8b 11238 * term.c (encode_terminal_code): Likewise.
6be7d3da 11239
75f8807f 11240 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11241
50938595
PE
11242 * tparam.h: New file.
11243 * term.c, tparam.h: Include it.
11244 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11245 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11246 Move these decls to tparam.h, and make them agree with what
11247 is actually in tparam.c. The previous trick of using incompatible
11248 decls in different modules does not conform to the C standard.
11249 All callers of tparam changed to use tparam's actual API.
11250 * tparam.c (tparam1, tparam, tgoto):
11251 Use const pointers where appropriate.
11252
fbceeba2
PE
11253 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11254 * cm.h (struct cm): Likewise.
11255 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11256 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11257 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11258 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11259 (turn_on_face, init_tty): Likewise.
11260 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11261
7f3f1250
PE
11262 * term.c (term_mouse_position): Rename local to avoid shadowing.
11263
e6ca6543
PE
11264 * alloc.c (mark_ttys): Move decl from here ...
11265 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11266
c40f8d15
AS
112672011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11268
11269 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11270
cfe0661d
JB
112712011-03-09 Juanma Barranquero <lekktu@gmail.com>
11272
11273 * search.c (compile_pattern_1): Remove argument regp, unused since
11274 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11275 (compile_pattern): Don't pass it.
11276
0afb4571
J
112772011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11278
11279 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11280 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11281 for ! HAVE_GTK3.
11282 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11283
11284 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11285
11286 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11287 gdk_window_get_screen, gdk_window_get_geometry,
11288 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11289 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11290 (xg_get_pixbuf_from_pixmap): New function.
11291 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11292 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11293 Call xg_get_pixbuf_from_pixmap instead of
11294 gdk_pixbuf_get_from_drawable.
11295 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11296 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11297 (xg_check_special_colors): Use GtkStyleContext and its functions
11298 for HAVE_GTK3.
11299 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11300 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11301 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11302 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11303 Call gtk_widget_get_preferred_size.
0afb4571
J
11304 (xg_frame_resized): gdk_window_get_geometry only takes 5
11305 parameters.
44f230aa
SM
11306 (xg_win_to_widget, xg_event_is_for_menubar):
11307 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11308 (xg_set_widget_bg): New function.
11309 (delete_cb): New function.
895009e1 11310 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11311 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11312 (xg_set_background_color): Call xg_set_widget_bg.
11313 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11314 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11315 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11316 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11317 if ! HAVE_GTK3.
11318 (update_frame_tool_bar): Call gtk_widget_hide.
11319 (xg_initialize): Use GDK_KEY_g.
11320
11321 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11322 if ! HAVE_GTK3
11323 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11324
11325 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11326 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11327 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11328
1c2cc4ef
JB
113292011-03-08 Juanma Barranquero <lekktu@gmail.com>
11330
11331 * w32xfns.c (select_palette): Check success of RealizePalette against
11332 GDI_ERROR, not zero.
11333
33383987 11334See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11335
11336;; Local Variables:
11337;; coding: utf-8
aac0c6e3
MR
11338;; End:
11339
2f097256 11340 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11341
11342 This file is part of GNU Emacs.
11343
11344 GNU Emacs is free software: you can redistribute it and/or modify
11345 it under the terms of the GNU General Public License as published by
11346 the Free Software Foundation, either version 3 of the License, or
11347 (at your option) any later version.
11348
11349 GNU Emacs is distributed in the hope that it will be useful,
11350 but WITHOUT ANY WARRANTY; without even the implied warranty of
11351 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11352 GNU General Public License for more details.
11353
11354 You should have received a copy of the GNU General Public License
11355 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.