src/xdisp.c (hscroll_window_tree): Support hscroll in right-to-left lines.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
352ec8ff
EZ
12011-10-08 Eli Zaretskii <eliz@gnu.org>
2
03669ccb
EZ
3 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4 lines.
5
352ec8ff
EZ
6 * dispnew.c (buffer_posn_from_coords): Account for a possible
7 presence of header-line. (Bug#4426)
8
a66cfb1c
SM
92011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
10
11 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
12 advertise functionality which we discourage or doesn't work.
13
7c5ee88e
PE
142011-10-07 Paul Eggert <eggert@cs.ucla.edu>
15
16 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
17 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
18 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
19 this makes Emacs dump core during garbage collection on rare
20 occasions. sizeof is obviously inferior to offsetof here, so
21 stick with offsetof.
22 (GC_POINTER_ALIGNMENT): New macro.
23 (mark_memory): Omit 3rd (offset) arg; caller changed.
24 Don't assume EMACS_INT alignment is the same as pointer alignment.
25
df1bbe5b
SM
262011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
27
28 * keyboard.c (read_key_sequence_remapped): New var.
29 (read_key_sequence): Compute remapping in the right buffer.
30 (command_loop_1): Use read_key_sequence's remapping directly.
31
51553db6
SM
322011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
33
32c1fffd
SM
34 * dired.c (file_name_completion): Don't expand file name.
35 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
36 before checking file name handler.
37
51553db6
SM
38 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
39 they've been requested explicitly (bug#9591).
40
b6bd1599 412011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
42
43 * keymap.c (Fsingle_key_description): Use make_specified_string
44 instead of build_string to build string from push_key_description.
45 (Bug#5193)
46
f701dc2a
PE
472011-09-30 Paul Eggert <eggert@cs.ucla.edu>
48
4222c55d
PE
49 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
50 This fixes a Y2038 bug on 64-bit hosts.
51 * buffer.c (reset_buffer):
52 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
53 (Fclear_buffer_auto_save_failure):
54 Use 0, not -1, to represent an unset failure time, since time_t
55 might not be signed.
56
f701dc2a
PE
57 Remove dependency on glibc malloc internals.
58 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
59 Move back here from lisp.h, but with their new implementations.
60 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
61 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
62 * charset.c (charset_table_init): New static var.
63 (syms_of_charset): Use it instead of xmalloc. This removes a
64 dependency on glibc malloc internals. See Eli Zaretskii's comment in
65 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
66 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
67 Move back to alloc.c.
68 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
69 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
70
9ceebf39
JD
712011-09-30 Jan Djärv <jan.h.d@swipnet.se>
72
73 * nsterm.m (windowDidResize): Call x_set_window_size only when
74 ns_in_resize is true. Otherwise set pixelwidth/height and
75 call change_frame_size (Bug#9628).
76
cb993c58
PE
772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
78
3930c88b
PE
79 Port --enable-checking=all to Fedora 14 x86-64.
80 * charset.c (syms_of_charset): Also account for glibc malloc's
81 internal overhead when calculating the initial malloc maximum.
82
cb993c58
PE
83 Port --enable-checking=all to Fedora 14 x86.
84 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
85 Move to lisp.h.
86 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
87 (overrun_check_realloc, overrun_check_free):
88 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
89 That way, xmalloc returns a properly-aligned pointer even if
90 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
91 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
92 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
93 into account when calculating the initial malloc maximum.
94 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
95 Move here from alloc.c, so that charset.c can use it too.
96 Properly align; the old code wasn't right for common 32-bit hosts
97 when configured with --enable-checking=all.
98 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
99 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
100
31bed486
EZ
1012011-09-29 Eli Zaretskii <eliz@gnu.org>
102
04c70788 103 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
104 use EDOM.
105
fbcaa2f3
EZ
1062011-09-28 Eli Zaretskii <eliz@gnu.org>
107
108 * xdisp.c (compute_display_string_end): If there's no display
109 string at CHARPOS, return -1.
110
111 * bidi.c (bidi_fetch_char): When compute_display_string_end
112 returns a negative value, treat the character as a normal
113 character not covered by a display string. (Bug#9624)
114
a239d4e9
JB
1152011-09-28 Juanma Barranquero <lekktu@gmail.com>
116
117 * lread.c (Fread_from_string): Fix typo in docstring.
118
88652fd5
EZ
1192011-09-27 Eli Zaretskii <eliz@gnu.org>
120
121 * xdisp.c (handle_invisible_prop): If invisible text ends on a
122 newline, reseat the iterator instead of bidi-iterating there one
123 character at a time. (Bug#9610)
32c1fffd
SM
124 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
125 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 126
ed497dd4
AS
1272011-09-27 Andreas Schwab <schwab@linux-m68k.org>
128
129 * lread.c (readevalloop): Use correct code for NBSP.
130 (read1): Likewise. (Bug#9608)
131
b2bf61aa
MA
1322011-09-25 Michael Albinus <michael.albinus@gmx.de>
133
134 * dbusbind.c (Fdbus_register_signal): When service is not
135 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
136
32bbb17c
GM
1372011-09-25 Glenn Morris <rgm@gnu.org>
138
139 * buffer.c (truncate-lines): Doc fix.
140
94e0933e
CY
1412011-09-24 Chong Yidong <cyd@stupidchicken.com>
142
143 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
144 (Fset_window_next_buffers): Doc fix.
145
cddde921
GM
1462011-09-24 Glenn Morris <rgm@gnu.org>
147
148 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
149
1260aef1
PE
1502011-09-24 Paul Eggert <eggert@cs.ucla.edu>
151
25b4bfa0
PE
152 Fix minor problems found by static checking.
153 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
154 * indent.c (Fvertical_motion): Fix == vs = typo.
155
e3cbd34b
EZ
1562011-09-24 Eli Zaretskii <eliz@gnu.org>
157
a66cfb1c
SM
158 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
159 Default value is now t. Doc fix.
6bf7006f 160
e3cbd34b 161 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 162 logic when moving up, not only when moving down. Fix the
e3cbd34b 163 confusing name and values of the it_overshoot_expected variable;
32c1fffd 164 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
165
166 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
167 CHARPOS is covered by a display string which includes newlines.
168 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
169 is covered by a display string with embedded newlines.
170
a3de0cbd
MA
1712011-09-24 Michael Albinus <michael.albinus@gmx.de>
172
173 * dbusbind.c (Fdbus_register_signal): Add match rule to
174 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
175 (Fdbus_register_method, Vdbus_registered_objects_table):
176 Fix docstring.
a3de0cbd 177
b260039d
JM
1782011-09-24 Jim Meyering <meyering@redhat.com>
179
32c1fffd 180 do not ignore write error for any output size
b260039d
JM
181 The previous change was incomplete.
182 While it makes emacs --batch detect the vast majority of stdout
183 write failures, errors were still ignored whenever the output size is
184 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
185 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
186 && echo FAIL: ignored write error
187 FAIL: ignored write error
188 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
189 && echo FAIL: ignored write error
190 FAIL: ignored write error
191 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
192
8eca8a7c
AS
1932011-09-23 Andreas Schwab <schwab@linux-m68k.org>
194
195 * emacs.c (Fkill_emacs): In noninteractive mode exit
196 non-successfully if a write error occurred on stdout. (Bug#9574)
197
3341db62
EZ
1982011-09-21 Eli Zaretskii <eliz@gnu.org>
199
200 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
201 the xassert test.
202
203 * dispextern.h (struct it): Update the comment documenting what
204 can it->OBJECT be.
205
8c203dbf
EZ
2062011-09-20 Eli Zaretskii <eliz@gnu.org>
207
208 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
209 a display string, extend search for cursor position to end of row.
210 (find_row_edges): If the row ends in a newline from a display
211 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
212 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
213 (Fcurrent_bidi_paragraph_direction): Fix search for previous
214 non-empty line. Fixes confusing cursor motion with arrow keys at
215 the beginning of a line that starts with whitespace.
8c203dbf 216
a4824228
LMI
2172011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
218
219 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
220 (bug#9493).
221
33ed493b
CY
2222011-09-18 Chong Yidong <cyd@stupidchicken.com>
223
224 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
225 boolean (Bug#9154).
226
56cd55c8
EZ
2272011-09-18 Eli Zaretskii <eliz@gnu.org>
228
229 * xdisp.c (display_line): Record maximum and minimum buffer
230 positions even if no glyphs were produced (e.g., by a zero-width
231 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
232 buffer positions that will be removed from the glyph row because
233 they don't fit.
c02dcedf
EZ
234 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
235 column is beyond frame width: don't subtract 1 "pixel" when
236 computing width of the stretch.
3e62b7e0
EZ
237 (reseat_at_next_visible_line_start): Undo the change made on
238 2011-09-17 that saved paragraph information and restored it after
239 the call to `reseat'. (Bug#9545)
56cd55c8 240
5ed99d36 2412011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
242
243 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
244 and turn window cursor on if cleared (Bug#9415).
245
5ed99d36 2462011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
247
248 * search.c (boyer_moore): Take unibyte characters from pattern
249 literally. (Bug#9458)
250
9bade7b2
EZ
2512011-09-18 Eli Zaretskii <eliz@gnu.org>
252
253 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
254
e5e9d610
PE
2552011-09-18 Paul Eggert <eggert@cs.ucla.edu>
256
87e4427a
PE
257 Fix minor problem found by static checking.
258 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
259 initialized, to pacify gcc -Wuninitialized.
260
e5e9d610
PE
261 * fileio.c: Report proper errno when syscall falls.
262 (Finsert_file_contents): Save and restore errno,
263 so that report_file_error outputs the correct diagnostic.
264 (Fwrite_region) [CLASH_DETECTION]: Likewise.
265
a1674f0b
EZ
2662011-09-18 Eli Zaretskii <eliz@gnu.org>
267
268 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
269
fbfb6dd4
EZ
2702011-09-17 Eli Zaretskii <eliz@gnu.org>
271
272 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
273 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
274
bb187662
EZ
2752011-09-17 Eli Zaretskii <eliz@gnu.org>
276
1137e8b8
EZ
277 * xdisp.c (reseat_at_next_visible_line_start): Keep information
278 about the current paragraph and restore it after the call to
279 reseat.
280
281 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
282 (bidi_find_paragraph_start): Search back for paragraph beginning
283 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
284 (bidi_move_to_visually_next): Only trigger paragraph-related
285 computations when the last character is a newline or at EOB, not
286 just any NEUTRAL_B. (Bug#9470)
287
bb187662
EZ
288 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
289 truncated lines if point is covered by a display string. (Bug#9524)
290
2e621251
PE
2912011-09-16 Paul Eggert <eggert@cs.ucla.edu>
292
293 * xselect.c: Relax test for outgoing X longs (Bug#9498).
294 (cons_to_x_long): New function.
295 (lisp_data_to_selection_data): Use it. Correct the test for
296 short-versus-long data; it was negated. Break out of vector
297 loop, for efficiency, when a long datum is discovered.
298
91a15bc6
SM
2992011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
300
301 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
302
b41c3a35
EZ
3032011-09-16 Eli Zaretskii <eliz@gnu.org>
304
305 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
306 GCC PR/17406) by declaring this function with external scope.
307
7812ba2d
PE
3082011-09-15 Paul Eggert <eggert@cs.ucla.edu>
309
310 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
311 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
312
cf7edc2a
AS
3132011-09-15 Andreas Schwab <schwab@linux-m68k.org>
314
315 * editfns.c (Fformat): Correctly handle text properties on "%%".
316
bd01620e
EZ
3172011-09-15 Eli Zaretskii <eliz@gnu.org>
318
319 * xterm.c (x_draw_composite_glyph_string_foreground):
320 * w32term.c (x_draw_composite_glyph_string_foreground):
321 * term.c (encode_terminal_code):
322 * composite.c (composition_update_it, get_composition_id):
323 * xdisp.c (get_next_display_element)
324 (fill_composite_glyph_string): Add comments about special meaning
325 of TAB characters in a composition.
326
a02719a3
PE
3272011-09-15 Paul Eggert <eggert@cs.ucla.edu>
328
329 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
330 This occurs when processing a multibyte format.
331 Problem reported by Wolfgang Jenker.
a02719a3 332
72589a3c
JB
3332011-09-15 Johan Bockgård <bojohan@gnu.org>
334
335 * xdisp.c (try_cursor_movement): Only check for exact match if
336 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
337
1c14176c
PE
3382011-09-14 Paul Eggert <eggert@cs.ucla.edu>
339
340 Remove unused external symbols.
341 * dispextern.h (calc_pixel_width_or_height): Remove decl.
342 * xdisp.c (calc_pixel_width_or_height): Now static.
343 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
344 * indent.c (check_display_width):
345 * w32term.c: Fix comment to match code.
346 * xterm.c, xterm.h (x_catching_errors): Remove.
347
d2eea5b5
PE
3482011-09-14 Paul Eggert <eggert@cs.ucla.edu>
349
350 * xselect.c: Use signed conversions more consistently (Bug#9498).
351 (selection_data_to_lisp_data): Assume incoming selection data are
352 signed integers, not unsigned. This is to be consistent with
353 outgoing selection data, which was modified to use signed integers
354 in as part of the fix to Bug#9196 in response to Jan D.'s comment
355 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
356 expects long, not unsigned long.
357
46888499
EZ
3582011-09-14 Eli Zaretskii <eliz@gnu.org>
359
360 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
361 computation of loop end. Reported by Johan Bockgård
362 <bojohan@gnu.org>.
363
ef8ef9fb
CY
3642011-09-13 Chong Yidong <cyd@stupidchicken.com>
365
366 * frame.c (Fother_visible_frames_p): Function deleted.
367
fa819fed
EZ
3682011-09-12 Eli Zaretskii <eliz@gnu.org>
369
370 * indent.c (compute_motion): Process display vector front to back
371 rather than the other way around. (Bug#2496)
372
2ba8e008
SM
3732011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
374
375 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
376
20f53c69
CY
3772011-09-11 Chong Yidong <cyd@stupidchicken.com>
378
379 * minibuf.c (Fread_from_minibuffer): Doc fix.
380
d562d7a4
EZ
3812011-09-11 Eli Zaretskii <eliz@gnu.org>
382
383 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
384 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
385
1c4d7f3d
LMI
3862011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
387
388 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
389 value for non-existent files.
390
b885bf36
EZ
3912011-09-11 Eli Zaretskii <eliz@gnu.org>
392
393 * fileio.c (Finsert_file_contents): If the file cannot be opened,
394 set its "size" to -1. This will set the modtime_size field of
395 the corresponding buffer to -1, which is what
396 verify-visited-file-modtime expects for files that do not exist.
397 (Bug#9139)
398
6612f0bf
PE
3992011-09-11 Paul Eggert <eggert@cs.ucla.edu>
400
401 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
402 here ...
403 * lisp.h: ... from here. push_key_description is no longer
404 defined in keyboard.c, so its declaration should not be in
405 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
406 logically belongs with push_key_description.
407
dfb3f755
PE
4082011-09-10 Paul Eggert <eggert@cs.ucla.edu>
409
410 * buffer.h: Include <sys/types.h> instead of <time.h>.
411 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
412 Problem reported by Herbert J. Skuhra.
413
3134906c
LMI
4142011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
415
416 * xml.c (parse_region): Make the parsing work for
417 non-comment-starting XML files again (bug#9144).
418
8d903f4e
AS
4192011-09-10 Andreas Schwab <schwab@linux-m68k.org>
420
421 * image.c (gif_load): Fix calculation of bottom and right corner.
422 (Bug#9468)
423
80ad64f4
EZ
4242011-09-10 Eli Zaretskii <eliz@gnu.org>
425
426 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
427 redisplay in small windows.
428
208a048d
EZ
4292011-09-09 Eli Zaretskii <eliz@gnu.org>
430
431 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
432
9b1c252e
MR
4332011-09-08 Martin Rudalics <rudalics@gmx.at>
434
435 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
436 Operate on live windows only.
437
2949f33b
JB
4382011-09-08 Juanma Barranquero <lekktu@gmail.com>
439
440 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
441
e08dcafd
EZ
4422011-09-07 Eli Zaretskii <eliz@gnu.org>
443
444 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
445 only under bidi iteration.
446
115b96bd
JD
4472011-09-07 Jan Djärv <jan.h.d@swipnet.se>
448
449 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
450
c8199d0f
PE
4512011-09-06 Paul Eggert <eggert@cs.ucla.edu>
452
453 isnan: Fix porting problem to Solaris 10 with bundled gcc.
454 Without this fix, the command to link temacs failed due to an
455 undefined symbol __builtin_isnan. This is because
456 /usr/include/iso/math_c99.h #defines isnan(x) to
457 __builtin_isnan(x), but the bundled gcc, which identifies itself
458 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
459 a __builtin_isnan.
460 * floatfns.c (isnan): #undef, and then #define to a clone of
461 what's in data.c.
462 (Fisnan): Always define, since it's always available now.
463 (syms_of_floatfns): Always define isnan at the Lisp level.
464
e39b275c 4652011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
466
467 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
468
b2db44d9 4692011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 470
f4af5137 471 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
472 The previous code assumed that file offsets (off_t values) fit in
473 EMACS_INT variables, which is not true on typical 32-bit hosts.
474 The code messed up by falsely reporting buffer overflow in cases
475 such as (insert-file-contents "big" nil 1 2) into an empty buffer
476 when "big" contains more than 2**29 bytes, even though this
477 inserts just one byte and does not overflow the buffer.
478 (Finsert_file_contents): Store file offsets as off_t
479 values, not as EMACS_INT values. Check for overflow when
480 converting between EMACS_INT and off_t. When checking for
481 buffer overflow or for overlap, take the offsets into account.
482 Don't use EMACS_INT for small values where int suffices.
483 When checking for overlap, fix a typo: ZV was used where
484 ZV_BYTE was intended.
485 (Fwrite_region): Don't assume off_t fits into 'long'.
486 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
487
ecfc0a49
MA
4882011-09-05 Michael Albinus <michael.albinus@gmx.de>
489
490 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
491
6511acf2 4922011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 493
0999621a 494 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
495
496 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 497 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
498 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
499 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
500 (modify_event_symbol): Do not assume that the length of
501 name_alist_or_stem is safe to alloca and fits in int.
502 (Fexecute_extended_command): Likewise for function name and binding.
503 (Frecursion_depth): Wrap around reliably on integer overflow.
504 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
505 since some callers pass EMACS_INT values.
506 (Fsingle_key_description): Don't crash if symbol name contains more
507 than MAX_ALLOCA bytes.
508 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
509 (get_minibuffer): Arg is now EMACS_INT, not int.
510 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 511 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
512 * window.h (command_loop_level, minibuf_level): Reflect API changes.
513
2be7d702
PE
514 * dbusbind.c (signature_cat): New function.
515 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
516 Do not overrun buffer; instead, report string overflow.
517
9d1df220
PE
518 * dispnew.c (add_window_display_history): Don't overrun buffer.
519 Truncate instead; this is OK since it's just a log.
520
33ef5c64
PE
521 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
522 even if the time zone offset is outlandishly large.
523 Don't mishandle offset == INT_MIN.
524
66c6fdd5
PE
525 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
526 when creating daemon; the previous buffer-overflow check was incorrect.
527
d749b01b
PE
528 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
529 which has the guts of the old verror function.
530
b5cd1905
PE
531 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
532 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
533
6e1a67fb
PE
534 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
535 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 536 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 537 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
538 length of string rather than counting it via multiple sprintfs;
539 that's simpler and more reliable.
c21721cc
PE
540 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
541 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
542 sprintf, in case result does not fit in int.
543
c57b67fc
PE
544 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
545 (fontset_from_font): Print it.
546
8a401434
PE
547 * frame.c (tty_frame_count): Now printmax_t, not int.
548 (make_terminal_frame, set_term_frame_name): Print it.
549 (x_report_frame_params): In X, window IDs are unsigned long,
550 not signed long, so print them as unsigned.
551 (validate_x_resource_name): Check for implausibly long names,
552 and don't assume name length fits in 'int'.
553 (x_get_resource_string): Don't blindly alloca invocation name;
554 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
555 not fit in int.
556
6e1a67fb
PE
557 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
558 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
559 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
560
0df02bf3
PE
561 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
562 Use esprintf, not sprintf, in case result does not fit in int.
563
48e30793
PE
564 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
565 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
566 it as a large positive number.
567 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
568 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
569
a66ff6d8
PE
570 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
571 in case result does not fit in int.
572
aca216ff
PE
573 * print.c (float_to_string): Detect width overflow more reliably.
574 (print_object): Make sprintf buffer a bit bigger, to avoid potential
575 buffer overrun. Don't assume list length fits in 'int'. Treat
576 print length of 0 as 0, not as infinity; to be consistent with other
577 uses of print length in this function. Don't overflow print length
578 index. Don't assume hash table size fits in 'long', or that
579 vectorlike size fits in 'unsigned long'.
580
31c286f7
PE
581 * process.c (make_process): Use printmax_t, not int, to format
582 process-name gensyms.
583
55e5faa1
PE
584 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
585
80f2e268
PE
586 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
587 to avoid potential buffer overrun.
588
670741ab
PE
589 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
590 if X resource line is longer than 512 bytes.
591
b7163a50
PE
592 * xfns.c (x_window): Make sprintf buffer a bit bigger
593 to avoid potential buffer overrun.
594
ae58ff1f
PE
595 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
596
c43c8a6a
PE
597 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
598
3f8236f4
PE
5992011-09-04 Paul Eggert <eggert@cs.ucla.edu>
600
53e9fe90 601 Integer overflow fixes for scrolling, etc.
6511acf2
PE
602 Without these, Emacs silently mishandles large integers sometimes.
603 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
604 it were "C-u 1 M-x recenter" on a typical 64-bit host.
605
6511acf2
PE
606 * xdisp.c (try_window_id): Check Emacs fixnum range before
607 converting to 'int'.
806add1d 608
6511acf2 609 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
610 Check that an Emacs fixnum is in range before assigning it to 'int'.
611 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
612 values converted from Emacs fixnums.
613 (Frecenter): Don't wrap around a line count if it is out of 'int'
614 range; instead, treat it as an extreme value.
615 (Fset_window_configuration, compare_window_configurations):
616 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
617
6511acf2
PE
618 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
619 that can exceed INT_MAX. Check that EMACS_INT value is in range
620 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
621 (match_limit): Don't assume that a fixnum can fit in 'int'.
622
6511acf2 623 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
624 exceed INT_MAX.
625
6511acf2 626 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
627 (Fvertical_motion): Don't wrap around LINES values that don't fit
628 in 'int'. Instead, treat them as extreme values. This is good
629 enough for windows, which can't have more than INT_MAX lines anyway.
630
fcb901a7
LMI
6312011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
632
0f2f6b6d
LMI
633 * Require libxml/parser.h to avoid compilation warning.
634
fcb901a7
LMI
635 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
636
637 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
638 since this reportedly can destroy thread storage.
639
6e20a0d4
CY
6402011-08-30 Chong Yidong <cyd@stupidchicken.com>
641
642 * syntax.c (find_defun_start): Update all cache variables if
643 exiting early (Bug#9401).
644
148ae00e
EZ
6452011-08-30 Eli Zaretskii <eliz@gnu.org>
646
f6cfbd8f
EZ
647 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
648
148ae00e
EZ
649 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
650 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
651 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
652
653 * term.c (tty_append_glyph): New function.
654 (produce_stretch_glyph): Static function and its prototype deleted.
655
a66cfb1c
SM
656 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
657 Add prototypes.
148ae00e 658
c4a07a4c
PE
6592011-08-29 Paul Eggert <eggert@cs.ucla.edu>
660
661 * image.c (parse_image_spec): Check for nonnegative, not for positive,
662 when checking :margin (Bug#9390).
663 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 664 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
665 so that the name doesn't mislead. All uses changed.
666
6bc8cd65
JB
6672011-08-28 Johan Bockgård <bojohan@gnu.org>
668
669 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
670 set_tty_hooks.
671
dca4927e
EZ
6722011-08-27 Eli Zaretskii <eliz@gnu.org>
673
674 * xdisp.c (move_it_to): Don't bail out early when reaching
675 position beyond to_charpos, if we are scanning backwards.
676 (move_it_vertically_backward): When DY == 0, make sure we get to
677 the first character in the line after the newline.
678
f2cad773
PE
6792011-08-27 Paul Eggert <eggert@cs.ucla.edu>
680
681 * ccl.c: Improve and simplify overflow checking (Bug#9196).
682 (ccl_driver): Do not generate an out-of-range pointer.
683 (Fccl_execute_on_string): Remove unnecessary check for
684 integer overflow, noted by Stefan Monnier in
685 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
686 Remove a FIXME that didn't need fixing.
687 Simplify the newly-introduced buffer reallocation code.
688
0cae2cdb
JB
6892011-08-27 Juanma Barranquero <lekktu@gmail.com>
690
691 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
692
5fc295a4 6932011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 694
70c60eb2 695 Integer and memory overflow issues (Bug#9196).
726e0ab1 696
d31850da
PE
697 * doc.c (get_doc_string): Rework so that
698 get_doc_string_buffer_size is the actual buffer size, rather than
699 being 1 less than the actual buffer size; this makes xpalloc more
700 convenient.
701
a69fbedb
PE
702 * image.c (x_allocate_bitmap_record, cache_image):
703 * xselect.c (Fx_register_dnd_atom):
704 Simplify previous changes by using xpalloc.
705
fe5c5d37
PE
706 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
707 since either will do and ptrdiff_t is convenient with xpalloc.
708
0065d054
PE
709 * charset.c (charset_table_size)
710 (struct charset_sort_data.priority): Now ptrdiff_t.
711 (charset_compare): Don't overflow if priorities differ greatly.
712 (Fsort_charsets): Don't assume list length fits in int.
713 Check for size-calculation overflow when allocating sort data.
714 (syms_of_charset): Allocate an initial charset table that is
715 just under 64 KiB, to avoid problems with glibc malloc and mmap.
716
717 * cmds.c (internal_self_insert): Check for size-calculation overflow.
718
719 * composite.h (struct composition.glyph_len): Now int, not unsigned.
720 The actual value is always <= INT_MAX, and leaving it unsigned made
721 overflow checking harder.
722
723 * dispextern.h (struct glyph_matrix.rows_allocated)
724 (struct face_cache.size): Now ptrdiff_t, for convenience in use
725 with xpalloc. The values are still always <= INT_MAX.
726
727 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
728
729 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
730 (SAFE_NALLOCA): New macro.
731
732 * region-cache.c (struct boundary.pos, find_cache_boundary)
733 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
734 (set_cache_region, invalidate_region_cache)
735 (revalidate_region_cache, know_region_cache, region_cache_forward)
736 (region_cache_backward, pp_cache):
737 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
738 so that ptrdiff_t * can be passed to xpalloc.
739 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
740 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
741 (pp_cache): Don't assume cache_len fits in int.
742 * region-cache.h: Adjust extern decls to match.
743
744 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
745 EMACS_INT, since either will do, for xpalloc.
746
747 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
748 (xnmalloc, xnrealloc, xpalloc): New functions.
749
726e0ab1
PE
750 * bidi.c (bidi_shelve_header_size): New constant.
751 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
752 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
753
51f30bc5 754 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
755 * buffer.c (overlays_at, overlays_in, record_overlay_string)
756 (overlay_strings):
757 Don't update size of array until after memory allocation succeeds,
758 because xmalloc/xrealloc may not return.
0065d054
PE
759 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
760 now that we have proper integer overflow checking.
761 (record_overlay_string, overlay_strings): Catch overflows when
762 calculating size of overlay_str_buf.
726e0ab1 763
0065d054
PE
764 * callproc.c (Fcall_process): Check for size overflow when
765 calculating size of args2.
766 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
767 Normally we prefer signed values, but sticking with ptrdiff_t would
768 require adding more-complicated checks.
726e0ab1
PE
769
770 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
771 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
772 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 773 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
774
775 * character.c (Fstring): Check for size-calculation overflow.
776
777 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
778 unnecessary integer overflow. Check for size overflow.
779 (encode_coding_object): Don't update size until xmalloc succeeds.
780
781 * composite.c (get_composition_id): Check for overflow in glyph
782 length calculations.
783
784 Integer and memory overflow fixes for display code.
785 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
786 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
787 (scrolling_window): Check for overflow in size calculations.
788 (line_draw_cost, realloc_glyph_pool, add_row_entry):
789 Don't assume glyph table len fits in int.
790 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
791 (row_table_size): Now ptrdiff_t, not int.
792 (scrolling_window): Avoid overflow in size calculations.
793 Don't update size until allocation succeeds.
794 * fns.c (concat): Check for overflow in size calculations.
795 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
796 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
797 (NEXT_ALMOST_PRIME_LIMIT): New constant.
798
799 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
800 (get_doc_string): Check for size calculation overflow.
801 Don't update size until allocation succeeds.
802 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
803 EMACS_INT, where ptrdiff_t will do.
804 (Fsubstitute_command_keys): Check for string overflow.
805
806 * editfns.c (set_time_zone_rule): Don't assume environment length
807 fits in int.
808 (message_length): Now ptrdiff_t, not int.
809 (Fmessage_box): Don't update size until allocation succeeds.
810 Don't assume message length fits in int.
811 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
812
0065d054
PE
813 * emacs.c (main): Do not reallocate argv, since there is a null at
814 the end that can be overwritten, and this way there's no need to
815 worry about size-calculation overflow.
816 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
817
818 * eval.c (init_eval_once, grow_specpdl): Don't update size until
819 alloc succeeds.
820 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
821
822 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
823 (x_set_scroll_bar_width, x_figure_window_size):
824 Check for integer overflow.
825 (x_set_alpha): Do not assume XINT fits in int.
826
827 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
828 This is for the members text_lines, text_cols, total_lines, total_cols,
829 where the system imposes an 'int' limit.
830
831 * fringe.c (Fdefine_fringe_bitmap):
832 Don't update size until alloc works.
833
834 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
835 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
836
837 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
838 Check for size-calculation overflow.
839 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
840 do, as we prefer signed integers.
841 (id_to_widget.max_size, id_to_widget.used)
842 (xg_store_widget_in_map, xg_remove_widget_from_map)
843 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
844 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
845 Use and return ptrdiff_t, not int.
846 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
847 * gtkutil.h: Change prototypes to match the above.
848
849 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
850 are duplicate now that they've been promoted to lisp.h.
851 (x_allocate_bitmap_record, x_alloc_image_color)
852 (make_image_cache, cache_image, xpm_load):
853 Don't update size until alloc is done.
854 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
855 (x_detect_edges):
3256efce 856 Check for size calculation overflow.
726e0ab1
PE
857 (ct_colors_allocated_max): New constant.
858 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
859 overflow.
3256efce 860
726e0ab1
PE
861 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
862 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
863 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
864 Use ptrdiff_t, not int, to count maps.
865 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
866 calculations. Don't update size until allocation succeeds.
867 Redo calculations to avoid overflow.
726e0ab1
PE
868 * keyboard.h: Change prototypes to match the above.
869
870 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
871 to count maps.
872 (current_minor_maps): Check for size calculation overflow.
873 * keymap.h: Change prototypes to match the above.
874
875 * lread.c (read1, init_obarray): Don't update size until alloc done.
876
877 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
878 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
879
726e0ab1
PE
880 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
881 Now ptrdiff_t, not int.
882 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
883 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
884
885 * process.c (Fnetwork_interface_list): Check for overflow
886 in size calculation.
887
888 * region-cache.c (move_cache_gap): Check for size calculation overflow.
889
890 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
891 overflow. Don't bother calling xmalloc when xrealloc will do.
892
893 * search.c (Freplace_match): Check for size calculation overflow.
894 (Fset_match_data): Don't assume list lengths fit in 'int'.
895
896 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
897 for command line length. Do not attempt to address one before the
898 beginning of an array, as that's not portable.
899
900 * term.c (max_frame_lines): Remove; unused.
901 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
902 not int.
903 (encode_terminal_code, calculate_costs): Check for size
904 calculation overflow.
905 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
906 table lengths and related sizes. Don't update size until alloc
907 done. Redo calculations to avoid overflow.
908 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
909
910 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
911 subtracting pointers.
912 (gobble_line): Check for overflow more carefully. Don't update size
913 until alloc done.
914
915 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
916 Don't update size until alloc done.
917 Redo size calculations to avoid overflow.
918 Check for size calculation overflow.
0065d054 919 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
920
921 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
922 Use ptrdiff_t, not int, for sizes.
923 (store_mode_line_noprop_char): Don't update size until alloc done.
924
0065d054
PE
925 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
926 Use ptrdiff_t, not int, for sizes.
927 (Finternal_make_lisp_face, cache_face):
928 Check for size calculation overflow.
929 (cache_face): Treat size calculation overflows as if they were
930 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
931
932 * xfns.c (x_encode_text, x_set_name_internal)
933 (Fx_change_window_property): Use ptrdiff_t, not int, to count
934 sizes, since they can exceed INT_MAX in size. Check for size
935 calculation overflow.
936
0065d054
PE
937 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
938 (xg_select): Check for size calculation overflow.
726e0ab1
PE
939 Don't update size until alloc done.
940
0065d054 941 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 942 as sprintf is limited to int lengths.
1d526e2f 943
252c5ee1
PE
944 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
945 (X_LONG_MIN): New macros.
864d7ce7
PE
946 Use them to make the following changes clearer.
947 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
948 This change doesn't affect the value now, but it may help remind
949 future maintainers not to raise the value too much later.
950 (SELECTION_QUANTUM): Remove, replacing with ...
951 (selection_quantum): ... new function, which avoids overflow.
952 All uses changed.
953 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
954 assumption that selection length fits in 'int'.
955 (x_reply_selection_request, x_handle_selection_request)
956 (x_get_window_property, receive_incremental_selection)
957 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
958 (lisp_data_to_selection_data, clean_local_selection_data):
959 Use ptrdiff_t, not int, to record length of selection.
960 (x_reply_selection_request, x_get_window_property)
961 (receive_incremental_selection, x_property_data_to_lisp):
962 Redo calculations to avoid overflow.
963 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 964 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
965 something.
966 (x_get_window_property, receive_incremental_selection)
967 (lisp_data_to_selection_data, x_property_data_to_lisp):
968 Check for size-calculation overflow.
969 (x_get_window_property, receive_incremental_selection)
970 (lisp_data_to_selection_data, Fx_register_dnd_atom):
971 Don't store size until memory allocation succeeds.
972 (x_get_window_property): Plug memory leak on memory exhaustion.
973 Don't double-block input; malloc is safe here. Don't assume 2**34
974 - 4 fits in unsigned long. Add an xassert to check
975 XGetWindowProperty overflow. Be more careful about overflow
976 calculations, and distinguish size from memory overflow better.
977 (receive_incremental_selection): When tracing, don't assume
978 unsigned int is less than INT_MAX.
979 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
980 harmful) conversions of unsigned short to int.
981 (lisp_data_to_selection_data): Don't assume that integers
982 in the range -65535 through -1 fit in an X unsigned short.
983 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
984 result parameters unless successful. Rely on cons_to_unsigned
985 to report problems with elements; the old code wasn't right anyway.
986 (x_check_property_data): Check for int overflow; we cannot use
987 a wider type due to X limits.
988 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
989
726e0ab1 990 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 991
0065d054
PE
992 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
993 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
994 (x_color_cells): Don't store size until memory allocation succeeds.
995 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 996 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
997 (x_term_init): Don't assume length fits in int (sprintf is limited
998 to int size).
bc18e09d 999
ebfa62c0
PE
1000 Use ptrdiff_t for composition IDs.
1001 * character.c (lisp_string_width):
1002 * composite.c (composition_table_size, n_compositions)
1003 (get_composition_id, composition_gstring_from_id):
1004 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1005 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1006 * window.c (Frecenter):
1007 Use ptrdiff_t, not int, for composition IDs.
1008 * composite.c (get_composition_id): Check for integer overflow.
1009 * composite.h: Adjust prototypes to match the above changes.
1010
d3411f89
PE
1011 Use ptrdiff_t for hash table indexes.
1012 * category.c (hash_get_category_set):
1013 * ccl.c (ccl_driver):
1014 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1015 * coding.c (coding_system_charset_list, detect_coding_system):
1016 * coding.h (struct coding_system.id):
1017 * composite.c (get_composition_id, gstring_lookup_cache):
1018 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1019 * image.c (xpm_get_color_table_h):
1020 * lisp.h (hash_lookup, hash_put):
1021 * minibuf.c (Ftest_completion):
1022 Use ptrdiff_t for hash table indexes, not int (which is too
1023 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1024 32-bit --with-wide-int hosts).
1025
e097a6fa
PE
1026 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1027 Add a FIXME comment about memory leaks.
1028 (syms_of_charset): Don't assume xmalloc returns.
1029
5637687f
PE
1030 Don't assume that stated character widths fit in int.
1031 * character.c (Fchar_width, c_string_width, lisp_string_width):
1032 * character.h (CHAR_WIDTH):
1033 * indent.c (MULTIBYTE_BYTES_WIDTH):
1034 Use sanitize_char_width to avoid undefined and/or bad behavior
1035 with outlandish widths.
a66cfb1c 1036 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1037 now that we have two such functions. All uses changed.
1038 (sanitize_char_width): New inline function.
1039
a2271ba2
PE
1040 Don't assume that tab-width fits in int.
1041 * character.h (sanitize_width): New inline function.
1042 (SANE_TAB_WIDTH): New macro.
1043 (ASCII_CHAR_WIDTH): Use it.
1044 * indent.c (sane_tab_width): Remove. All uses replaced by
1045 SANE_TAB_WIDTH (current_buffer).
1046 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1047
18c52557
PE
1048 * fileio.c: Integer overflow issues with file modes.
1049 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1050
caeeedc1
PE
1051 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1052 Remove unreachable code.
1053 (read_hex, load_charset_map_from_file): Check for integer overflow.
1054
50849c52
PE
1055 * xterm.c: don't go over XClientMessageEvent limit
1056 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1057 (x_send_scroll_bar_event): Likewise. Check that the size does not
1058 exceed limits imposed by XClientMessageEvent, as well as the usual
1059 ptrdiff_t and size_t limits.
1060
b13995db
PE
1061 * keyboard.c: Overflow, signedness and related fixes.
1062 (make_lispy_movement): Use same integer type in forward decl
1063 that is used in the definition.
1064 (read_key_sequence, keyremap_step):
1065 Change bufsize argument back to int, undoing my 2011-03-30 change.
1066 We prefer signed types, and int is wide enough here.
1067 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1068 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1069 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1070 length, not size_t. Use ptrdiff_t for index, not int.
1071 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1072 possibility of integer overflow.
1073
13464394
PE
1074 Overflow, signedness and related fixes for images.
1075
1076 * dispextern.h (struct it.stack[0].u.image.image_id)
1077 (struct_it.image_id, struct image.id, struct image_cache.size)
1078 (struct image_cache.used, struct image_cache.ref_count):
1079 * gtkutil.c (update_frame_tool_bar):
1080 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1081 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1082 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1083 * nsmenu.m (update_frame_tool_bar):
1084 * xdisp.c (calc_pixel_width_or_height):
1085 * xfns.c (image_cache_refcount):
1086 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1087 on typical 64-bit hosts.
1088
1089 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1090 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1091 Omit unnecessary casts to int.
1092 (parse_image_spec): Check that integers fall into 'int' range
1093 when the callers expect that.
1094 (image_ascent): Redo ascent calculation to avoid int overflow.
1095 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1096 (lookup_image): Remove unnecessary tests.
1097 (xbm_image_p): Locals are now of int, not EMACS_INT,
1098 since parse_image_check makes sure they fit into int.
1099 (png_load, gif_load, svg_load_image):
1100 Prefer int to unsigned where either will do.
1101 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1102 old tiff_error_handler and tiff_warning_handler.
1103 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1104 stack buffer overflows. It uses only the features of vsnprintf
1105 that are common to both POSIX and native Microsoft.
1106 (tiff_error_handler, tiff_warning_handler): Use it.
1107 (tiff_load, gif_load, imagemagick_load_image):
1108 Don't assume :index value fits in 'int'.
1109 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1110 (imagemagick_load_image): Check that crop parameters fit into
1111 the integer types that MagickCropImage accepts. Don't assume
1112 Vimagemagick_render_type has a nonnegative value. Don't assume
1113 size_t fits in 'long'.
1114 (gs_load): Use printmax_t to print the widest integers possible.
1115 Check for integer overflow when computing image height and width.
1116
c11821d4
EZ
11172011-08-26 Eli Zaretskii <eliz@gnu.org>
1118
1119 * xdisp.c (redisplay_window): Don't force window start if point
1120 will be invisible in the resulting window. (Bug#9324)
1121
0c95fcf7
EZ
11222011-08-25 Eli Zaretskii <eliz@gnu.org>
1123
1124 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1125 the display spec is of the form `(space ...)'.
1126 (handle_display_spec): Return the value returned by
1127 handle_single_display_spec, not just 1 or zero.
1128 (handle_single_display_spec): If the display spec is of the form
1129 `(space ...)', and specifies display in the text area, return 2
1130 rather than 1.
fee65a97 1131 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1132 accurately, and prefer exact match for point under bidi.
1133 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1134
1135 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1136 into disp_prop; all users changed.
1137
1138 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1139 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1140 for the text covered by the display property.
1141
e4ed06f1
CY
11422011-08-25 Chong Yidong <cyd@stupidchicken.com>
1143
1144 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1145 Change return value to nil.
1146 (Frecord_buffer): Delete unused function.
1147
f67cdd7f
EZ
11482011-08-24 Eli Zaretskii <eliz@gnu.org>
1149
5980d4c6
EZ
1150 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1151 buffers, return left-to-right.
8610fe8b
EZ
1152 (set_cursor_from_row): Consider candidate row a win if its glyph
1153 represents a newline and point is on that newline. Fixes cursor
1154 positioning on the newline at EOL of R2L text within L2R
1155 paragraph, and vice versa.
1156 (try_cursor_movement): Check continued rows, in addition to
1157 continuation rows. Fixes unwarranted scroll when point enters a
1158 continued line of R2L text within an L2R paragraph, or vice versa.
1159 (cursor_row_p): Consider the case of point being equal to
1160 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1161 from the end of a short line to the beginning of a continued line
1162 of R2L text within L2R paragraph.
1163 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1164 composed characters.
5980d4c6 1165
f67cdd7f
EZ
1166 * bidi.c (bidi_check_type): Use xassert.
1167 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1168 members.
1169
bca633fb
EZ
11702011-08-23 Eli Zaretskii <eliz@gnu.org>
1171
1172 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1173 a character.
1174
4a5885a7
CY
11752011-08-23 Chong Yidong <cyd@stupidchicken.com>
1176
1177 * nsfont.m (ns_otf_to_script): Fix typo.
1178
0902a04e
KH
11792011-08-22 Kenichi Handa <handa@m17n.org>
1180
1181 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1182 extra slot even if the purpose is char-code-property-table.
1183
1a2e6670
EZ
11842011-08-23 Eli Zaretskii <eliz@gnu.org>
1185
8ddde651
EZ
1186 * xdisp.c (redisplay_window): When computing centering_position,
1187 account for the height of the header line. (Bug#8874)
1188
425cc014
EZ
1189 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1190 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1191 candidate is selected by the mouse, and that candidate has a
1192 composed character under the mouse.
1193
1a2e6670
EZ
1194 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1195 coordinates reported by pos-visible-in-window-p for a composed
1196 character in column zero.
1197
8b76d6f8
SM
11982011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1199
1200 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1201
dac347dd
EZ
12022011-08-22 Eli Zaretskii <eliz@gnu.org>
1203
1204 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1205 consider it a hit if to_charpos is anywhere in the range of the
1206 composed buffer positions.
1207
e013fb34
CY
12082011-08-22 Chong Yidong <cyd@stupidchicken.com>
1209
1210 * image.c (gif_load): Don't assume that each subimage has the same
1211 dimensions as the base image. Handle disposal method that is
1212 "undefined" by the gif spec (Bug#9335).
1213
bd1ba3e8
CY
12142011-08-20 Chong Yidong <cyd@stupidchicken.com>
1215
1216 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1217 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1218
54a1215b
EZ
12192011-08-19 Eli Zaretskii <eliz@gnu.org>
1220
823564e5
EZ
1221 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1222 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1223 from an Org mode buffer to a Speedbar frame.
1224
54a1215b
EZ
1225 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1226 a composition, take its buffer position from IT->cmp_it.charpos.
1227 Fixes cursor positioning at the beginning of a line that begins
1228 with a composed character.
1229
9778ebcc
EZ
12302011-08-18 Eli Zaretskii <eliz@gnu.org>
1231
0be6ee06
EZ
1232 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1233 character bidirectional type, use STRONG_L instead. Fixes crashes
1234 in a buffer produced by `describe-categories'.
1235
9778ebcc
EZ
1236 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1237 members before the level stack, so they would be saved and
1238 restored when copying iterator state. Fixes incorrect reordering
1239 around TABs covered by display properties.
1240
156bffbe
AS
12412011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1242
1243 * process.c (Fnetwork_interface_list): Correctly determine buffer
1244 size.
1245
72ad093b
CY
12462011-08-17 Chong Yidong <cyd@stupidchicken.com>
1247
1248 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1249 (internal_condition_case_2, internal_condition_case_n):
1250 Remove unnecessary aborts (Bug#9081).
72ad093b 1251
35774242
EZ
12522011-08-17 Eli Zaretskii <eliz@gnu.org>
1253
1254 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1255 has no `load' handler, try opening the file locally. (Bug#9311)
1256
db76dd85
KB
12572011-08-16 Ken Brown <kbrown@cornell.edu>
1258
1259 * gmalloc.c: Expand comment.
1260
b215eee5
EZ
12612011-08-16 Eli Zaretskii <eliz@gnu.org>
1262
1263 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1264 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1265
a4579d33
KB
12662011-08-16 Ken Brown <kbrown@cornell.edu>
1267
1268 Fix memory allocation problems in Cygwin build (Bug#9273).
1269
1270 * unexcw.c ( __malloc_initialized): Declare external variable.
1271 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1272
8b76d6f8
SM
1273 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1274 New variables.
a4579d33
KB
1275 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1276 dumped emacs.
1277 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1278 in the static heap.
1279 [CYGWIN] (special_realloc): New function.
1280 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1281 requests to realloc storage in the static heap.
1282
3ebec551
PE
12832011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1284
1285 * bidi.c (bidi_initialize): Remove unused local.
1286
9fd8be00
EZ
12872011-08-15 Eli Zaretskii <eliz@gnu.org>
1288
474a8465
EZ
1289 * biditype.h: File removed.
1290
1291 * bidimirror.h: File removed.
1292
1293 * deps.mk (bidi.o): Remove biditype.h and
1294 bidimirror.h.
1295
1296 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1297 bidimirror.h.
1298
1299 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1300
1301 * chartab.c: Improve commentary for the uniprop_table API.
1302
32413314
EZ
1303 * bidi.c (bidi_paragraph_init): Support zero value of
1304 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1305 (bidi_initialize): Use uniprop_table instead of including
1306 biditype.h and bidimirror.h.
32413314 1307
9fd8be00
EZ
1308 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1309 coordinates of the iterator when restoring from ppos_it.
1310 (Bug#9296)
1311
5cf2b69b
KH
13122011-08-14 Kenichi Handa <handa@m17n.org>
1313
1314 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1315 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1316
daf17d00
EZ
13172011-08-14 Eli Zaretskii <eliz@gnu.org>
1318
1319 * xdisp.c (move_it_in_display_line_to): Don't invoke
1320 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1321 ppos_it. Fixes vertical cursor motion when line beginning is
1322 covered by an image. (Bug#9296)
1323
08e3161a
JD
13242011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1325
1326 * nsterm.h (ns_run_ascript): Declare.
1327 (NSAPP_DATA2_RUNASSCRIPT): Define.
1328
1329 * nsfns.m (as_script, as_result, as_status): New static variables.
1330 (ns_run_ascript): New function.
5e617bc2 1331 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1332 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1333 the event loop. Get status from as_status (Bug#7276).
1334
1335 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1336 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1337 the event loop (Bug#7276).
1338
a3720aa2
AS
13392011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1340
1341 * gnutls.c (QCgnutls_bootprop_priority)
1342 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1343 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1344 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1345 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1346 (QCgnutls_bootprop_verify_hostname_error)
1347 (QCgnutls_bootprop_callbacks_verify): Rename from
1348 Qgnutls_bootprop_..., all uses changed.
1349
1350 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1351 uses changed.
1352
0a0d27fb
PE
13532011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1354
19d5c50c
PE
1355 * xfaces.c (Qframe_set_background_mode): Now static.
1356 * dispextern.h (Qframe_set_background_mode): Remove decl.
1357
0a0d27fb
PE
1358 * process.c (Fnetwork_interface_info): Declare local only if needed.
1359
377538cb
JD
13602011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1361
1362 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1363 (Fnetwork_interface_list): Allocate in increments of bytes instead
1364 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1365 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1366 sockaddr.
1367 (struct ifflag_def): notrailers is smart on OSX.
1368 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1369 Get hardware address with getifaddrs if available.
1370
08fff70c
EZ
13712011-08-12 Eli Zaretskii <eliz@gnu.org>
1372
1373 * xdisp.c (iterate_out_of_display_property): xassert that
1374 IT->position is set to within IT->object's boundaries. Break from
1375 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1376 when IT->position is set up wrongly due to some bug.
1377 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1378 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1379 entry. Force push_it to save on the stack the current
1380 buffer/string position, to be restored by pop_it. Fix flags in
1381 the iterator structure wrt the object coming from a display
1382 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1383 properties. (Bug#9284)
1384
7be1c708 13852011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1386
7be1c708
CY
1387 * fontset.c (fontset_get_font_group): Add proper type checks.
1388 (Bug#9172)
aac0c6e3 1389
7be1c708 13902011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1391
7be1c708
CY
1392 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1393 and LC_VERSION_MIN_MACOSX.
1394 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1395 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1396
97bb72a6
EZ
13972011-08-08 Eli Zaretskii <eliz@gnu.org>
1398
1399 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1400 no-display-properties-and-no-overlays under bidi display.
1401 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1402 properties and overlays.
97bb72a6 1403
d5617611
CY
14042011-08-08 Chong Yidong <cyd@stupidchicken.com>
1405
37e11a63
CY
1406 * editfns.c (Fset_time_zone_rule): Document relationship with the
1407 setenv function.
1408
d5617611
CY
1409 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1410 the font entity extracted from the cache (Bug#8109).
1411
58872834
CY
14122011-08-07 Chong Yidong <cyd@stupidchicken.com>
1413
1414 * composite.c (autocmp_chars): Don't reset point. That is done by
1415 restore_point_unwind (Bug#5984).
1416
75bfc667
JL
14172011-08-07 Juri Linkov <juri@jurta.org>
1418
1419 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1420 to show the arg `TIME' instead of `TIMEVAL'.
1421
d1410150
EZ
14222011-08-06 Eli Zaretskii <eliz@gnu.org>
1423
1424 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1425 display property strides EOL and includes a newline, as in
1426 longlines-mode. (Bug#9254)
75b771e4
EZ
1427 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1428 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1429
1430 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1431 is non-zero, even if the data buffer is NULL. Fixes a crash in
1432 vertical-motion with longlines-mode. (Bug#9254)
1433
35928349
EZ
14342011-08-05 Eli Zaretskii <eliz@gnu.org>
1435
ec7cc85b
EZ
1436 * bidi.c <bidi_cache_total_alloc>: Now static.
1437 (bidi_initialize): Initialize bidi_cache_total_alloc.
1438
8b76d6f8 1439 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1440 cache. (Bug#9221)
1441
1442 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1443 amount allocated this far in `bidi_cache_total_alloc'.
1444 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1445 non-zero, only free the data buffer without restoring the cache
1446 contents. All callers changed.
1447
1448 * dispextern.h (bidi_unshelve_cache): Update prototype.
1449
1450 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1451 (move_it_in_display_line, move_it_to)
1452 (move_it_vertically_backward, move_it_by_lines): Replace the call
1453 to xfree to an equivalent call to bidi_unshelve_cache.
1454 (move_it_in_display_line_to): Fix logic of returning
412b6358 1455 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1456
e2e2423b
EZ
14572011-08-05 Eli Zaretskii <eliz@gnu.org>
1458
1459 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1460 came from a string character with a `cursor' property. (Bug#9229)
1461
ae9e757a
JD
14622011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1463
1464 * Makefile.in (LIB_PTHREAD): New variable.
1465 (LIBES): Add LIB_PTHREAD (Bug#9216).
1466
1467 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1468 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1469
213bd7f2
AS
14702011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1471
1472 * regex.c (re_iswctype): Remove some redundant boolean
1473 conversions.
1474
99aaf75f
JD
14752011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1476
1477 * xterm.c (x_find_topmost_parent): New function.
1478 (x_set_frame_alpha): Find topmost parent window with
1479 x_find_topmost_parent and set the property there also (bug#9181).
1480 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1481
c74e9d86
PE
14822011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1483
1484 * callproc.c (Fcall_process): Avoid vfork clobbering
1485 the local vars buffer, coding_systems, current_dir.
1486
640c8776
SM
14872011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1488
1489 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1490
f26d0e4c
PE
14912011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1492
8a10d76c
PE
1493 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1494 so that it is not optimized away.
1495
f26d0e4c
PE
1496 * xdisp.c (compute_display_string_pos): Remove unused local.
1497
55439c61
EZ
14982011-08-02 Eli Zaretskii <eliz@gnu.org>
1499
1500 Fix slow cursor motion and scrolling in large buffers with
1501 selective display, like Org Mode buffers. (Bug#9218)
1502
1503 * dispextern.h (struct bidi_it): New member disp_prop_p.
1504
1505 * xdisp.c: Remove one-slot cache of display string positions.
1506 (compute_display_string_pos): Accept an additional argument
5e617bc2 1507 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1508 for a display string or property. If found, set DISP_PROP_P
1509 non-zero.
1510
1511 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1512 DISP_PROP_P, and pass it to compute_display_string_pos.
1513 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1514 non-zero. All callers of bidi_fetch_char changed.
1515
fb33fa43
SM
15162011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1517
1518 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1519
b099e063
DM
15202010-12-03 Don March <don@ohspite.net>
1521
1522 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1523 last character M-[char] is translated to ESC [char] (bug#7541).
1524
5cc7f7af
KH
15252011-08-02 Kenichi Handa <handa@m17n.org>
1526
d0fffa3f 1527 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1528
1529 * chartab.c (uniprop_table): Make it non-static.
1530
525d5e6e
EZ
15312011-08-01 Eli Zaretskii <eliz@gnu.org>
1532
1533 * xdisp.c (forward_to_next_line_start): Accept additional argument
1534 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1535 on the newline.
1536 (reseat_at_next_visible_line_start): Use the bidi iterator state
1537 returned by forward_to_next_line_start to restore the state of
1538 it->bidi_it after backing up to previous newline. (Bug#9212)
1539
31011111
AS
15402011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1541
1542 * regex.c (re_comp): Protoize.
1543 (re_exec): Fix return type.
1544 (regexec): Fix type of `ret'. (Bug#9203)
1545
476371c4
PE
15462011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1547
e5d76069
PE
1548 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1549 This is needed if max-image-size is a floating-point number.
1550
9a79b20c
AS
15512011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1552
1553 * print.c (print_object): Print empty symbol as ##.
1554
1555 * lread.c (read1): Read ## as empty symbol.
1556
d8c2fa78
AA
15572011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1558
1559 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1560 setting frame foreground color (Bug#9175).
1561 (x_set_background_color): Likewise.
1562
ffe57a7a
AA
1563 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1564 contents (Bug#9176).
1565 (EmacsTooltip -init): Remove bezels and add shadows to
1566 tooltip windows.
1567
bf3492a5
AA
1568 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1569 or scroll bar (Bug#8470).
1570
d55e9c53
AA
1571 * nsfont.m (nsfont_open): Remove assignment to voffset and
1572 unnecessary vars hshink, expand, hd, full_height, min_height.
1573 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1574
1575 * nsterm.h (nsfont_info): Remove voffset field.
1576
d8c2fa78 15772011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1578
1579 Implement strike-through and overline on NextStep (Bug#8863).
1580
1581 * nsfont.m (nsfont_open): Use underline position provided by font,
1582 instead of hard-coded value of 2.
1583 (nsfont_draw): Call ns_draw_text_decoration instead.
1584
1585 * nsterm.h: Add declaration for ns_draw_text_decoration.
1586
1587 * nsterm.m (ns_draw_text_decoration): New function for drawing
1588 underline, overline, and strike-through.
1589 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1590 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1591 accommodate underlining, etc.
4843aac3 1592
4cc60b9b
EZ
15932011-07-28 Eli Zaretskii <eliz@gnu.org>
1594
bc7ece87
EZ
1595 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1596 default.
4cc60b9b 1597
476371c4
PE
15982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1599
66606eea
PE
1600 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1601 Without this fix, if a signal arrives just after memory fills up,
1602 'malloc' might be invoked reentrantly.
1603
476371c4
PE
1604 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1605 In other words, assume that every image size is allowed, on non-X
1606 hosts. This assumption is probably wrong, but it lets Emacs compile.
1607
f3fcc40d
AS
16082011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1609
1610 * regex.c (re_iswctype): Convert return values to boolean.
1611
350c992f
EZ
16122011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1613
1614 * xdisp.c (compute_display_string_pos): Don't use cached display
1615 string position if the buffer had its restriction changed.
1616 (Bug#9184)
1617
5266b4bb
PE
16182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1621
2573a837 16222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1623
41f55ccd 1624 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1625
39e378da
PE
1626 * bidi.c: Integer size and overflow fixes.
1627 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1628 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1629 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1630 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1631 (bidi_find_other_level_edge):
1632 Use ptrdiff_t instead of EMACS_INT where either will do.
1633 This works better on 32-bit hosts configured --with-wide-int.
1634 (bidi_cache_ensure_space): Check for size-calculation overflow.
1635 Use % rather than repeated addition, for better worst-case speed.
1636 Don't set bidi_cache_size until after xrealloc returns, because it
1637 might not return.
1638 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1639 (bidi_cache_ensure_space): Also check that the bidi cache size
1640 does not exceed that of the largest Lisp string or buffer. See Eli
1641 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1642
5e927815
PE
1643 * alloc.c (__malloc_size_t): Remove.
1644 All uses replaced by size_t. See Andreas Schwab's note
1645 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1646
ca4aa935
PE
1647 * image.c: Improve checking for integer overflow.
1648 (check_image_size): Assume that f is nonnull, since
1649 it is always nonnull in practice. This is one less thing to
1650 worry about when checking for integer overflow later.
1651 (x_check_image_size): New function, which checks for integer
1652 overflow issues inside X.
1653 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1654 This removes the need for a memory_full check.
1655 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1656 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1657 (xbm_read_bitmap_data): Change locals back to 'int', since
1658 their values must fit in 'int'.
1659 (xpm_load_image, png_load, tiff_load):
1660 Invoke x_create_x_image_and_pixmap earlier,
1661 to avoid much needless work if the image is too large.
1662 (tiff_load): Treat overly large images as if
1663 x_create_x_image_and_pixmap failed, not as malloc failures.
1664 (gs_load): Use x_check_image_size.
1665
5f8f9cc2
PE
1666 * gtkutil.c: Omit integer casts.
1667 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1668 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1669
5adf60bc
PE
1670 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1671
c8907a93
PE
1672 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1673 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1674 would wrongly return t on a 64-bit host.
1675
e3c25c68
PE
1676 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1677 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1678 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1679 and therefore cause GCC to emit a bogus diagnostic in some cases.
1680
3f791afe
PE
1681 * image.c: Integer signedness and overflow and related fixes.
1682 This is not an exhaustive set of fixes, but it's time to
1683 record what I've got.
1684 (lookup_pixel_color, check_image_size): Remove redundant decls.
1685 (check_image_size): Don't assume that arbitrary EMACS_INT values
1686 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1687 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1688 (tiff_load, imagemagick_load_image):
1689 Check for overflow in size calculations.
1690 (x_create_x_image_and_pixmap): Remove unnecessary test for
1691 xmalloc returning NULL; that can't happen.
1692 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1693 (xpm_color_bucket): Use better integer hashing function.
1694 (xpm_cache_color): Don't possibly over-allocate memory.
1695 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1696 (gif_memory_source):
1697 Use ptrdiff_t, not int or size_t, to record sizes.
1698 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1699 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1700 either works, as we prefer signed integers.
1701 (tiff_read_from_memory, tiff_write_from_memory):
1702 Return tsize_t, not size_t, since that's what the TIFF API wants.
1703 (tiff_read_from_memory): Don't fail simply because the read would
1704 go past EOF; instead, return a short read.
1705 (tiff_load): Omit no-longer-needed casts.
1706 (Fimagemagick_types): Don't assume size fits into 'int'.
1707
3cc5a532
PE
1708 Improve hashing quality when configured --with-wide-int.
1709 * fns.c (hash_string): New function, taken from sxhash_string.
1710 Do not discard information about ASCII character case; this
1711 discarding is no longer needed.
1712 (sxhash-string): Use it. Change sig to match it. Caller changed.
1713 * lisp.h: Declare it.
1714 * lread.c (hash_string): Remove, since we now use fns.c's version.
1715 The fns.c version returns a wider integer if --with-wide-int is
1716 specified, so this should help the quality of the hashing a bit.
1717
b312a492
PE
1718 * emacs.c: Integer overflow minor fix.
1719 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1720 Define only if GNU_LINUX.
1721 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1722
dfd153ae
PE
1723 * dispnew.c: Integer signedness and overflow fixes.
1724 Remove unnecessary forward decls, that were a maintenance hassle.
1725 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1726 All uses changed.
1727 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1728 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1729 (prepare_desired_row, line_draw_cost):
1730 Use int, not unsigned, where either works.
1731 (save_current_matrix, restore_current_matrix):
1732 Use ptrdiff_t, not size_t, where either works.
1733 (init_display): Check for overflow more accurately, and without
1734 relying on undefined behavior.
1735
a81d11a3
PE
1736 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1737 Remove, replacing with the new symbols in lisp.h. All uses changed.
1738 * fileio.c (make_temp_name):
1739 * filelock.c (lock_file_1, lock_file):
1740 * xdisp.c (message_dolog):
1741 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1742 Use pMd etc. instead.
1743 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1744 replacing the pWIDE etc. symbols removed from editfns.c.
1745
3300e6fd
PE
1746 * keyboard.h (num_input_events): Now uintmax_t.
1747 This is (very slightly) less likely to mess up due to wraparound.
1748 All uses changed.
1749
fd05c7e9
PE
1750 * buffer.c: Integer signedness fixes.
1751 (alloc_buffer_text, enlarge_buffer_text):
1752 Use ptrdiff_t rather than size_t when either will do, as we prefer
1753 signed integers.
1754
903fe15d
PE
1755 * alloc.c: Integer signedness and overflow fixes.
1756 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1757 (__malloc_size_t): Default to size_t, not to int.
1758 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1759 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1760 Prefer ptrdiff_t to size_t when either would do, as we prefer
1761 signed integers.
1762 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1763 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1764 Now const. Initialize with values that are in range even if char
1765 is signed.
1766 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1767 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1768 These functions do the right thing with sizes > 2**32.
1769 (check_depth): Now ptrdiff_t, not int.
1770 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1771 Adjust to new way of storing sizes. Check for size overflow bugs
1772 in rest of code.
1773 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1774 slightly wrong anyway, as it missed one instance of
1775 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1776 (refill_memory_reserve): Omit needless cast to size_t.
1777 (mark_object_loop_halt): Mark as externally visible.
1778
ac82cc6a
PE
1779 * xselect.c: Integer signedness and overflow fixes.
1780 (Fx_register_dnd_atom, x_handle_dnd_message):
1781 Use ptrdiff_t, not size_t, since we prefer signed.
1782 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1783 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1784 x_dnd_atoms_size and x_dnd_atoms_length.
1785
c2d1e36d
PE
1786 * doprnt.c: Prefer signed to unsigned when either works.
1787 * eval.c (verror):
1788 * doprnt.c (doprnt):
1789 * lisp.h (doprnt):
1790 * xdisp.c (vmessage):
1791 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1792 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1793 prefer signed arithmetic to avoid comparison confusion.
1794 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1795 but is a bit tricky.
1796
0e926e56
PE
1797 Assume freestanding C89 headers, string.h, stdlib.h.
1798 * data.c, doprnt.c, floatfns.c, print.c:
1799 Include float.h unconditionally.
1800 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1801 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1802 * regex.c: Likewise for stddef.h, string.h.
1803 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1804 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1805 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1806 (STDC_HEADERS): Remove obsolete defines.
1807 * sysdep.c: Include limits.h unconditionally.
1808
9cfdb3ec
PE
1809 Assume support for memcmp, memcpy, memmove, memset.
1810 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1811 * regex.c (memcmp, memcpy):
1812 Remove; we assume C89 now.
1813
1814 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1815 (__malloc_safe_bcopy): Remove; no longer needed.
1816
cf950e6b 1817 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1818 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1819 well either way, and we prefer signed to unsigned.
1820
dbf38e02
LMI
18212011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1822
1823 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1824 closes the connection while we're reading (bug#9182).
1825
d6f0886c 18262011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1827
d6f0886c
JD
1828 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1829 are specified (Bug#9168).
24e0f6b1 1830
2eb1f9e6
PE
18312011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1832
1833 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1834 Found by GCC static checking and --with-wide-int on a 32-bit host.
1835
22381272 18362011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1837
1838 * xdisp.c (compute_display_string_pos): Fix logic of caching
1839 previous display string position. Initialize cached_prev_pos to
1840 -1. Fixes slow-down at the beginning of a buffer.
1841
f25e39b4
EZ
18422011-07-24 Eli Zaretskii <eliz@gnu.org>
1843
1844 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1845 for attrs[LFACE_FONTSET_INDEX].
1846
04c4b52e
PE
18472011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1848
1849 * xml.c (parse_region): Remove unused local
1850 that was recently introduced.
1851
c1734fbd
EZ
18522011-07-23 Eli Zaretskii <eliz@gnu.org>
1853
be18c5a5
EZ
1854 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1855 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1856
c1734fbd
EZ
1857 * xdisp.c (move_it_in_display_line_to): Record the best matching
1858 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1859 exit if none of the characters scanned was an exact match.
1860 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1861 when exact match is impossible due to invisible text, and the
1862 lines are truncated.
1863
a258d627
JD
18642011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1865
1866 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1867 for OSX >= 10.7.
1868
b6d5a689
EZ
18692011-07-22 Eli Zaretskii <eliz@gnu.org>
1870
0f74f785
EZ
1871 Fix a significant slow-down of cursor motion with C-n, C-p,
1872 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1873 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1874 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1875 (next_element_from_buffer): Call compute_stop_pos_backwards to
1876 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1877 base_level_stop.
1878 (reseat): Don't look for prev_stop, as that could mean a very long
1879 run.
1880 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1881 <cached_disp_overlay_modiff>: Cache for last found display string
1882 position.
551918c1 1883 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1884 about the same buffer in the same area of character positions, and
1885 the buffer wasn't changed since the time the display string
1886 position was cached.
551918c1 1887
b2d0c91a
EZ
18882011-07-22 Eli Zaretskii <eliz@gnu.org>
1889
1890 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1891 is an integer, which is important for empty lines. (Bug#9149)
1892
043604ee
CY
18932011-07-22 Chong Yidong <cyd@stupidchicken.com>
1894
1895 * frame.c (Fmodify_frame_parameters): In tty case, update the
1896 default face if necessary (Bug#4238).
1897
da4adb04
CY
18982011-07-21 Chong Yidong <cyd@stupidchicken.com>
1899
1900 * editfns.c (Fstring_to_char): No need to explain what a character
1901 is in the docstring (Bug#6576).
1902
9abd0532
LMI
19032011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1904
1905 * xml.c (parse_region): Make sure we always return a tree.
1906
36881d16
HK
19072011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1908
1909 * xml.c (parse_region): If a document contains only comments,
1910 return that, too.
1911
1e98674d
LMI
19122011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1913
1914 * xml.c (make_dom): Return comments, too.
1915
590bd467
PE
19162011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1917
1918 Port to OpenBSD.
1919 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1920 and the surrounding thread.
1921 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1922 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1923 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1924 timer goes off.
1925 * s/openbsd.h (BROKEN_SIGIO): Define.
1926 * unexelf.c (unexec) [__OpenBSD__]:
1927 Don't update the .mdebug section of the Alpha COFF symbol table.
1928
f41628b2
LMI
19292011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1930
1931 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1932 (bug#8460).
1933
b59b67c5
PE
19342011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1935
15e3a074
PE
1936 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1937 This fixes some race conditions on the permissions of any newly
1938 created file.
1939
41bed37d
PE
1940 * alloc.c (valid_pointer_p): Use pipe, not open.
1941 This fixes some permissions issues when debugging.
1942
b59b67c5
PE
1943 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1944 If fchown fails to set both uid and gid, try to set just gid,
1945 as that is sometimes allowed. Adjust the file's mode to eliminate
1946 setuid or setgid bits that are inappropriate if fchown fails.
1947
925a6be7
SM
19482011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1949
1950 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1951 to compare Lisp_Objects.
1952 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1953 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1954 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1955
52968808
AS
19562011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1957
0a6a104b
AS
1958 * lread.c (read_integer): Unread even EOF character.
1959 (read1): Likewise. Properly record start position of symbol.
1960
52968808
AS
1961 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1962 symbol character follows.
1963
9e381cdd
PE
19642011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1967 This works around a problem with the previous change to Fcopy_file.
1968 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1969 and without this change, GCC might complain about discarding
1970 fchown's return value.
1971
b5641435
JB
19722011-07-16 Juanma Barranquero <lekktu@gmail.com>
1973
1974 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1975
a8031457
PE
19762011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1977
1978 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1979
dd889327
LMI
19802011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1981
750c33f7
LMI
1982 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1983 it's used from the C level.
1984
dd889327
LMI
1985 * process.c: Use the same condition for POLL_FOR_INPUT in both
1986 keyboard.c and process.c (bug#1858).
1987
87e86684
LM
19882011-07-09 Lawrence Mitchell <wence@gmx.li>
1989
1990 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1991 (Fgnutls_boot): Use it.
1992
64348f40
AS
19932011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1994
1995 * doc.c (Fsubstitute_command_keys): Revert last change.
1996
1d698799
LMI
19972011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1998
f863868c
LMI
1999 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2000 quotes the next character, and doesn't affect other longer
2001 sequences (bug#8935).
2002
1d698799
LMI
2003 * lread.c (syms_of_lread): Clarify that is isn't only
2004 `eval-buffer' and `eval-defun' that's affected by
2005 `lexical-binding' (bug#8460).
2006
aa4b6df6
EZ
20072011-07-15 Eli Zaretskii <eliz@gnu.org>
2008
2009 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2010 bidi redisplay when a line includes both an image and is
2011 truncated.
2012
5d856da6
PE
20132011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2014
ad6042bb
PE
2015 Fix minor problems found by static checking.
2016 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2017 (elsz): Now a signed constant, not a size_t var. We prefer signed
2018 types to unsigned, to avoid integer comparison confusion. Without
2019 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2020 "cannot optimize loop, the loop counter may overflow", a symptom
2021 of the confusion.
f00bbb22 2022 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2023 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2024
6468f31c
LMI
20252011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2026
49080b10
LMI
2027 * search.c (Fre_search_backward): Mention `case-fold-search' in
2028 all the re_search_* functions (bug#8138).
2029
6468f31c
LMI
2030 * keyboard.c (Fopen_dribble_file): Document when the file is
2031 closed (bug#8056).
2032
c965adc5
EZ
20332011-07-14 Eli Zaretskii <eliz@gnu.org>
2034
df9733bf
EZ
2035 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2036 bidi_cache_idx.
2037
0bb23927
EZ
2038 Support bidi reordering of display and overlay strings.
2039 * xdisp.c (compute_display_string_pos)
2040 (compute_display_string_end): Accept additional argument STRING.
2041 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2042 (reseat_to_string): Initialize bidi_it->string.s and
2043 bidi_it->string.schars.
2044 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2045 NULL (avoids a crash in bidi_paragraph_init).
2046 Initialize itb.string.lstring.
0bb23927
EZ
2047 (init_iterator): Call bidi_init_it only of a valid
2048 buffer position was specified. Initialize paragraph_embedding to
2049 L2R.
2050 (reseat_to_string): Initialize the bidi iterator.
2051 (display_string): If we need to ignore text properties of
2052 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2053 original value of -1 will not work with bidi.)
2054 (compute_display_string_pos): First arg is now struct
2055 `text_pos *'; all callers changed. Support display properties on
2056 Lisp strings.
2057 (compute_display_string_end): Support display properties on Lisp
2058 strings.
2059 (init_iterator, reseat_1, reseat_to_string): Initialize the
2060 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2061 when iterating on a string not from display properties).
640c8776
SM
2062 (compute_display_string_pos, compute_display_string_end):
2063 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2064 arrow keys.
2065 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2066 base_level_stop; instead, set base_level_stop to BEGV.
2067 Fixes crashes in vertical-motion.
0bb23927
EZ
2068 (next_element_from_buffer): Improve commentary for when
2069 the iterator is before prev_stop.
2070 (init_iterator): Initialize bidi_p from the default value of
2071 bidi-display-reordering, not from buffer-local value. Use the
2072 buffer-local value only if initializing for buffer iteration.
2073 (handle_invisible_prop): Support invisible properties on strings
2074 that are being bidi-reordered.
2075 (set_iterator_to_next): Support bidi reordering of C strings and
2076 Lisp strings.
2077 (next_element_from_string): Support bidi reordering of Lisp
2078 strings.
2079 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2080 (display_string): Support display of R2L glyph rows.
2081 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2082 (init_iterator): Don't initialize it->bidi_p for strings
2083 here.
2084 (reseat_to_string): Initialize it->bidi_p for strings here.
2085 (next_element_from_string, next_element_from_c_string)
2086 (next_element_from_buffer): Add xassert's for correspondence
2087 between IT's object being iterated and it->bidi_it.string
2088 structure.
2089 (face_before_or_after_it_pos): Support bidi iteration.
2090 (next_element_from_c_string): Handle the case of the first string
2091 character that is not the first one in the visual order.
2092 (get_visually_first_element): New function, refactored from common
2093 parts of next_element_from_buffer, next_element_from_string, and
2094 next_element_from_c_string.
2095 (tool_bar_lines_needed, redisplay_tool_bar)
2096 (display_menu_bar): Force left-to-right direction. Add a FIXME
2097 comment for making that be controlled by a user option.
2098 (push_it, pop_it): Save and restore the state of the
2099 bidi iterator. Save and restore the bidi_p flag.
2100 (pop_it): Iterate out of display property for string iteration as
2101 well.
2102 (iterate_out_of_display_property): Support iteration over strings.
2103 (handle_single_display_spec): Set up it->bidi_it for iteration
2104 over a display string, and call bidi_init_it.
2105 (handle_single_display_spec, next_overlay_string)
2106 (get_overlay_strings_1, push_display_prop): Set up the bidi
2107 iterator for displaying display or overlay strings.
2108 (forward_to_next_line_start): Don't use the shortcut if
2109 bidi-iterating.
2110 (back_to_previous_visible_line_start): If handle_display_prop
2111 pushed the iterator stack, restore the internal state of the bidi
2112 iterator by calling bidi_pop_it same number of times.
2113 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2114 and we are bidi-iterating, don't decrement the iterator position;
2115 instead, set the first_elt flag in the bidi iterator, to produce
2116 the same effect.
2117 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2118 (push_display_prop): xassert that we are iterating a buffer.
2119 (push_it, pop_it): Save and restore paragraph_embedding member.
2120 (handle_single_display_spec, next_overlay_string)
2121 (get_overlay_strings_1, reseat_1, reseat_to_string)
2122 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2123 correctly. Don't assume unibyte strings are not bidi-reordered.
2124 (compute_display_string_pos)
2125 (compute_display_string_end): Fix handling the case of C string.
2126 (push_it, pop_it): Save and restore from_disp_prop_p.
2127 (handle_single_display_spec, push_display_prop): Set the
2128 from_disp_prop_p flag.
2129 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2130 (pop_it): Call iterate_out_of_display_property only if we are
2131 popping after iteration over a string that came from a display
2132 property. Fix a typo in popping stretch info. Add an assertion
2133 for verifying that the iterator position is in sync with the bidi
2134 iterator.
2135 (handle_single_display_spec, get_overlay_strings_1)
2136 (push_display_prop): Fix initialization of paragraph direction for
2137 string when that of the parent object is not yet determined.
2138 (reseat_1): Call bidi_init_it to resync the bidi
2139 iterator with IT's position. (Bug#7616)
2140 (find_row_edges): If ROW->start.pos gives position
2141 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2142 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2143 Reset the from_disp_prop_p flag.
2144 (SAVE_IT, RESTORE_IT): New macros.
2145 (pos_visible_p, face_before_or_after_it_pos)
2146 (back_to_previous_visible_line_start)
2147 (move_it_in_display_line_to, move_it_in_display_line)
2148 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2149 (try_scrolling, redisplay_window, display_line): Use them when
2150 saving a temporary copy of the iterator and restoring it back.
2151 (back_to_previous_visible_line_start, reseat_1)
2152 (init_iterator): Empty the bidi cache "stack".
2153 (move_it_in_display_line_to): If iterator ended up at
2154 EOL, but we never saw any buffer positions smaller than
2155 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2156 motion in bidi-reordered lines.
2157 (move_it_in_display_line_to): Record prev_method and prev_pos
2158 immediately before the call to set_iterator_to_next. Fixes cursor
2159 motion in bidi-reordered lines with stretch glyphs and strings
2160 displayed in margins. (Bug#8133) (Bug#8867)
2161 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2162 TO_CHARPOS.
640c8776
SM
2163 (pos_visible_p): Support positions in bidi-reordered lines.
2164 Save and restore bidi cache.
0bb23927
EZ
2165
2166 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2167 (bidi_paragraph_info): Delete unused struct.
2168 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2169 (bidi_cache_start): New variable.
2170 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2171 to zero.
2172 (bidi_cache_fetch_state, bidi_cache_search)
2173 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2174 (bidi_cache_find, bidi_peek_at_next_level)
2175 (bidi_level_of_next_char, bidi_find_other_level_edge)
2176 (bidi_move_to_visually_next): Compare cache index with
2177 bidi_cache_start rather than with zero.
2178 (bidi_fetch_char): Accept new argument STRING; all callers
2179 changed. Support iteration over a string. Support strings with
2180 display properties. Support unibyte strings. Fix the type of
2181 `len' according to what STRING_CHAR_AND_LENGTH expects.
2182 (bidi_paragraph_init, bidi_resolve_explicit_1)
2183 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2184 (bidi_level_of_next_char, bidi_move_to_visually_next):
2185 Support iteration over a string.
0bb23927
EZ
2186 (bidi_set_sor_type, bidi_resolve_explicit_1)
2187 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2188 can now be zero (for strings); special values 0 and -1 were
2189 changed to -1 and -2, respectively.
2190 (bidi_char_at_pos): New function.
2191 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2192 Call it instead of FETCH_MULTIBYTE_CHAR.
2193 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2194 initialized to valid values.
2195 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2196 values.
2197 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2198 the test for valid cached positions. Fix the logic for looking up
2199 the sentinel state in the cache. GCPRO the Lisp string we are
2200 iterating.
2201 (bidi_push_it, bidi_pop_it): New functions.
2202 (bidi_initialize): Initialize the bidi cache start stack pointer.
2203 (bidi_cache_ensure_space): New function, refactored from part of
2204 bidi_cache_iterator_state. Don't assume the required size is just
2205 one BIDI_CACHE_CHUNK away.
2206 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2207 (bidi_count_bytes, bidi_char_at_pos): New functions.
2208 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2209 always valid if bidi_cache_idx is valid.
2210 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2211 is valid if it's going to be used.
2212 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2213 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2214 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2215 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2216 (bidi_find_other_level_edge, bidi_cache_start_stack):
2217 All variables related to cache indices are now EMACS_INT.
c965adc5 2218
0bb23927
EZ
2219 * dispextern.h (struct bidi_string_data): New structure.
2220 (struct bidi_it): New member `string'. Make flag members be 1-bit
2221 fields, and put them last in the struct.
640c8776
SM
2222 (compute_display_string_pos, compute_display_string_end):
2223 Update prototypes.
0bb23927
EZ
2224 (bidi_push_it, bidi_pop_it): Add prototypes.
2225 (struct iterator_stack_entry): New members bidi_p,
2226 paragraph_embedding, and from_disp_prop_p.
2227 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2228 (bidi_shelve_cache, bidi_unshelve_cache):
2229 Declare prototypes.
0bb23927
EZ
2230
2231 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2232 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2233 and vector-like objects.
2234
2235 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2236 cache around display iteration.
2237
2238 * window.c (Fwindow_end, window_scroll_pixel_based)
2239 (displayed_window_lines, Frecenter): Save and restore the bidi
2240 cache around display iteration.
2241
3bbd2265
LMI
22422011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2243
2244 * editfns.c (Fdelete_region): Clarify the use of the named
2245 parameters (bug#6788).
2246
adc47434
MR
22472011-07-14 Martin Rudalics <rudalics@gmx.at>
2248
2249 * indent.c (Fvertical_motion): Set and restore w->pointm when
2250 saving and restoring the window's buffer (Bug#9006).
2251
837c31f8
LMI
22522011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2253
2254 * editfns.c (Fstring_to_char): Clarify just what is returned
2255 (bug#6576). Text by Eli Zaretskii.
2256
ac389d0c
JB
22572011-07-13 Juanma Barranquero <lekktu@gmail.com>
2258
2259 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2260
0be0ce47
EZ
22612011-07-13 Eli Zaretskii <eliz@gnu.org>
2262
2263 * buffer.c (mmap_find): Fix a typo.
2264
cd18e7e3
JB
22652011-07-13 Johan Bockgård <bojohan@gnu.org>
2266
2267 Fix execution of x selection hooks.
2268 * xselect.c (Qx_lost_selection_functions)
2269 (Qx_sent_selection_functions): New vars.
2270 (syms_of_xselect): DEFSYM them.
2271 (x_handle_selection_request): Pass Qx_sent_selection_functions
2272 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2273 (x_handle_selection_clear,x_clear_frame_selections):
2274 Pass Qx_lost_selection_functions rather than
2275 Vx_lost_selection_functions to Frun_hook_with_args.
2276
47ea7f44
PE
22772011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2278
ac389d0c 2279 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2280 The old code sometimes used this field without initializing it.
2281
47ea7f44
PE
2282 * alloc.c (gc_sweep): Don't read past end of array.
2283 In theory, the old code could also have corrupted Emacs internals,
2284 though it'd be very unlikely.
2285
bc985c87
AS
22862011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2287
2288 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2289 argument. (Bug#4026)
bc985c87 2290
0cf34688
LMI
22912011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2292
b3dadd76
LMI
2293 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2294 key" (bug#4257).
2295
0cf34688
LMI
2296 * window.c (Fset_window_start): Doc fix (bug#4199).
2297 (Fset_window_hscroll): Ditto.
2298
270768cd
PE
22992011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2300
077e3dda 2301 Fix minor new problems caught by GCC 4.6.1.
270768cd 2302 * term.c (init_tty): Remove unused local.
490011a6 2303 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2304 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2305 not used otherwise.
270768cd 2306
b1f58454
CY
23072011-07-12 Chong Yidong <cyd@stupidchicken.com>
2308
2309 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2310
22b9578d
LMI
23112011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2312
6e70ab07
LMI
2313 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2314 are the mini-buffer and the echo area (bug#3320).
2315
22b9578d
LMI
2316 * term.c (init_tty): Remove support for supdup, c10 and perq
2317 terminals, which are no longer supported (bug#1482).
2318
8974cc9f
JB
23192011-07-10 Johan Bockgård <bojohan@gnu.org>
2320
2321 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2322
a560d974
JD
23232011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2324
2325 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2326 for non-popups (Bug#3642).
2327
1dae0f0a
AS
23282011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2329
268c2c36 2330 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2331 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2332 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2333 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2334 * data.c (fmod): Likewise.
2335 * dispnew.c (swap_glyphs_in_rows): Likewise.
2336 * emacs.c (memory_warning_signal): Likewise.
2337 * floatfns.c (float_error): Likewise.
2338 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2339 (otf_open, font_otf_capability, generate_otf_features)
2340 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2341 Likewise.
2342 * image.c (pbm_read_file): Likewise.
2343 * indent.c (string_display_width): Likewise.
2344 * intervals.c (check_for_interval, search_for_interval)
2345 (inc_interval_count, count_intervals, root_interval)
2346 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2347 * lread.c (defalias): Likewise.
268c2c36 2348 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2349 * regex.c (set_image_of_range_1, set_image_of_range)
2350 (regex_grow_registers): Likewise.
2351 * sysdep.c (strerror): Likewise.
2352 * termcap.c (valid_filename_p, tprint, main): Likewise.
2353 * tparam.c (main): Likewise.
2354 * unexhp9k800.c (run_time_remap, save_data_space)
2355 (update_file_ptrs, read_header, write_header, calculate_checksum)
2356 (copy_file, copy_rest, display_header): Likewise.
2357 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2358 Likewise.
2359 * xdisp.c (check_it): Likewise.
2360 * xfaces.c (register_color, unregister_color, unregister_colors):
2361 Likewise.
2362 * xfns.c (print_fontset_result): Likewise.
2363 * xrdb.c (member, fatal, main): Likewise.
2364
99033785
PE
23652011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2366
2367 Fix minor problems found by static checking (Bug#9031).
2368 * chartab.c (char_table_set_range, map_sub_char_table):
2369 Remove unused locals.
2370 (uniprop_table): Now static.
2371 * composite.c (_work_char): Remove unused static var.
2372
9cb2ac56
JB
23732011-07-09 Juanma Barranquero <lekktu@gmail.com>
2374
2375 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2376
f25661f0
JD
23772011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2378
2379 * gtkutil.c (qttip_cb): Remove code without function.
2380
8278c4fe
EZ
23812011-07-09 Eli Zaretskii <eliz@gnu.org>
2382
2383 * w32.c (pthread_sigmask): New stub.
2384
1692ae2d 23852011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2386
8a6ebd58 2387 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2388 sigprocmask is portable only for single-threaded applications, and
2389 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2390 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2391 (LIBES): Use it.
2392 * callproc.c (Fcall_process):
2393 * process.c (create_process):
2394 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2395 Use pthread_sigmask, not sigprocmask.
123403e4 2396
1b854618
JD
23972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2398
2399 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2400 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2401 wrong (Bug#8591).
2402
3fe4b549
JD
24032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2404
0ce7e563
JD
2405 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2406 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2407 (xg_hide_tooltip): Fix comment.
2408
3fe4b549
JD
2409 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2410 in registerServicesMenuSendTypes.
2411 (validRequestorForSendType): Don't check ns_return_types.
2412
2413 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2414 ns_return_type.
2415
5df75e47
JR
24162011-07-08 Jason Rumney <jasonr@gnu.org>
2417
2418 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2419 frame struct members of non-existent frames (Bug#6284).
2420
699c10bd
JD
24212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2422
4393663b
JD
2423 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2424 variable firstTime not needed on OSX >= 10.6.
2425 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2426 >= 10.5. Use setKnobProportion, setDoubleValue.
2427
2428 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2429 (MAC_OS_X_VERSION_10_5): Define if not defined.
2430 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2431 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2432 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2433
2434 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2435 cString and lossyCString on OSX >= 10.4
2436
2437 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2438 sizeToFit on OSX >= 10.2.
2439
2440 * nsimage.m (allocInitFromFile): Don't use deprecated method
2441 bestRepresentationForDevice on OSX >= 10.6.
2442
2443 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2444 to avoid warning.
2445
2446 * emacs.c: Declare unexec_init_emacs_zone.
2447
a63e0781
JD
2448 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2449
699c10bd
JD
2450 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2451
2452 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2453 on svcsMenu (Bug#8842).
2454
2455 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2456 ns_return_types.
2457 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2458
2459 * nsterm.m (QUTF8_STRING): Declare.
2460 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2461 (validRequestorForSendType): Return type is (id).
2462 Change indexOfObjectIdenticalTo to indexOfObject.
2463 Check if we have local selection before returning self (Bug#8842).
2464 (writeSelectionToPasteboard): Put local selection into paste board
2465 if we have a local selection (Bug#8842).
2466 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2467
2468 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2469 (ns_get_local_selection): Declare.
2470
54e10184
LMI
24712011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2472
9888ff71
LMI
2473 * keymap.c (describe_map_tree): Don't insert a double newline at
2474 the end of the buffer (bug#1169) and return whether we inserted
2475 something.
2476
54e10184
LMI
2477 * callint.c (Fcall_interactively): Change "reading args" to
2478 "providing args" to try to clarify what it does (bug#1010).
2479
15fa4783
KH
24802011-07-07 Kenichi Handa <handa@m17n.org>
2481
2482 * composite.c (composition_compute_stop_pos): Ignore a static
2483 composition starting before CHARPOS (Bug#8915).
2484
2485 * xdisp.c (handle_composition_prop): Likewise.
2486
a8815b00
EZ
24872011-07-07 Eli Zaretskii <eliz@gnu.org>
2488
2489 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2490 (Bug#9015)
2491
ef7b981d 24922011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2493
2494 * character.h (unicode_category_t): New enum type.
2495
2496 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2497 (Qchar_code_property_table): New variable.
2498 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2499 (UNIPROP_COMPRESSED_FORM_P): New macros.
2500 (char_table_ascii): Uncompress the compressed values.
2501 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2502 Uncompress the compressed values.
ac389d0c 2503 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2504 (char_table_ref_and_range): Uncompress the compressed values.
2505 (sub_char_table_set): New arg is_uniprop. Callers changed.
2506 Uncompress the compressed values.
2507 (sub_char_table_set_range): Args changed. Callers changed.
2508 (char_table_set_range): Adjuted for the above change.
2509 (map_sub_char_table): Delete args default_val and parent. Add arg
2510 top. Give decoded values to a Lisp function.
640c8776 2511 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2512 values to a Lisp function. Gcpro more variables.
2513 (uniprop_table_uncompress)
2514 (uniprop_decode_value_run_length): New functions.
2515 (uniprop_decoder, uniprop_decoder_count): New variables.
2516 (uniprop_get_decoder, uniprop_encode_value_character)
2517 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2518 New functions.
2519 (uniprop_encoder, uniprop_encoder_count): New variables.
2520 (uniprop_get_encoder, uniprop_table)
2521 (Funicode_property_table_internal, Fget_unicode_property_internal)
2522 (Fput_unicode_property_internal): New functions.
2523 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2524 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2525 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2526 char-code-property-alist.
2527
640c8776 2528 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2529 Vunicode_category_table.
2530
640c8776 2531 * font.c (font_range): Adjust for the change of
c805dec0
KH
2532 Vunicode_category_table.
2533
76b397fb
DN
25342011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2535
2536 * m/iris4d.h: Remove file, move contents ...
2537 * s/irix6-5.h: ... here.
2538
22b4128e
PE
25392011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2540
2541 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2542 * alloc.c (mark_buffer):
2543 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2544 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2545 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2546 This isn't true in general, and it's particularly not true
2547 if Emacs is configured with --with-wide-int.
2548 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2549 New macros, used in the buffer.c change.
2550
869795d6
JD
25512011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2552
2553 * xsettings.c: Use both GConf and GSettings if both are available.
2554 (store_config_changed_event): Add comment.
2555 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2556 (store_tool_bar_style_changed): New functions.
5e617bc2 2557 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2558 (struct xsettings): Move font inside HAVE_XFT.
2559 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2560 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2561 Move inside HAVE_XFT.
640c8776 2562 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2563 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2564 also.
2565 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2566 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2567 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2568 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2569 (parse_settings): Move check for font inside HAVE_XFT.
2570 (read_settings, apply_xft_settings): Add comment.
2571 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2572 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2573 call store_font_name_changed.
2574 (xft_settings_event): Add comment.
2575 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2576 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2577 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2578 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2579 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2580 (xsettings_get_system_font, xsettings_get_system_normal_font):
2581 Add comment.
869795d6 2582
d8ed26bd
PE
25832011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2584
2585 Random fixes. E.g., (random) never returned negative values.
2586 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2587 subseconds part to the entropy, as that's a bit more random.
2588 Prefer signed to unsigned, since the signedness doesn't matter and
2589 in general we prefer signed. When given a limit, use a
2590 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2591 latter isn't right if USE_2_TAGS_FOR_INTS.
2592 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2593 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2594
cabf1cac
SM
25952011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2596
2597 * textprop.c (text_property_stickiness):
2598 Obey Vtext_property_default_nonsticky.
2599 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2600 * w32fns.c (syms_of_w32fns):
2601 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2602
6e9b2be9
PE
26032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2604
2605 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2606 This is more efficient than Ffile_directory_p and avoids a minor race.
2607
90186c68
LMI
26082011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2609
7c301272
LMI
2610 * buffer.c (Foverlay_put): Say what the return value is
2611 (bug#7835).
2612
c4f2d8d4
LMI
2613 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2614 is a directory before asking whether to use the file name
2615 (bug#7564).
ad637907
LMI
2616 (barf_or_query_if_file_exists): Make the "File is a directory"
2617 error be more correct.
c4f2d8d4 2618
90186c68
LMI
2619 * fns.c (Frequire): Remove the mention of the .gz files, since
2620 that's installation-specific, but keep the mention of
2621 `get-load-suffixes'.
2622
da64016e
PE
26232011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2624
2625 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2626 Report string overflow if the output is too long.
2627
7d47b580
JB
26282011-07-04 Juanma Barranquero <lekktu@gmail.com>
2629
a555cb87
JB
2630 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2631 (syms_of_gnutls): Remove duplicate DEFSYM for
2632 Qgnutls_bootprop_verify_hostname_error, an error for
2633 Qgnutls_bootprop_verify_error (which is no longer used).
2634
7d47b580
JB
2635 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2636 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2637 Also (re)move comments that are misplaced or no longer relevant.
2638
1e49bfab
LMI
26392011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2640
2641 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2642
1485f4c0
CY
26432011-07-03 Chong Yidong <cyd@stupidchicken.com>
2644
2645 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2646 and background color parameters if they have been changed.
2647
a9ab721e
LMI
26482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2649
2650 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2651
cf7cff57
PE
26522011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2653
2e13213d
PE
2654 * xsettings.c (SYSTEM_FONT): Define only when used.
2655 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2656
cf7cff57
PE
2657 * keymap.c (access_keymap_1): Now static.
2658
7a8e04f7
CY
26592011-07-02 Chong Yidong <cyd@stupidchicken.com>
2660
2661 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2662 leave any prefix arg for the up event (Bug#1586).
2663
61352f62
LMI
26642011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2665
69bb1ef7
LMI
2666 * lread.c (syms_of_lread): Mention single symbols defined by
2667 `defvar' or `defconst' (bug#7154).
2668
61352f62 2669 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2670 (Frequire): Mention get-load-suffixes.
61352f62 2671
28545e04
MR
26722011-07-02 Martin Rudalics <rudalics@gmx.at>
2673
2674 * window.h (window): Remove clone_number slot.
2675 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2676 Remove.
2677 (make_parent_window, make_window, saved_window)
2678 (Fset_window_configuration, save_window_save): Don't deal with
2679 clone numbers.
2680 * buffer.c (Qclone_number): Remove declaration.
2681 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2682
3349e122
SM
26832011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2684
2685 Add multiple inheritance to keymaps.
2686 * keymap.c (Fmake_composed_keymap): New function.
2687 (Fset_keymap_parent): Simplify.
2688 (fix_submap_inheritance): Remove.
2689 (access_keymap_1): New function extracted from access_keymap to handle
2690 embedded parents and handle lists of maps.
2691 (access_keymap): Use it.
2692 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2693 (Fcopy_keymap): Handle embedded parents.
2694 (Fcommand_remapping, define_as_prefix): Simplify.
2695 (Fkey_binding): Simplify.
2696 (syms_of_keymap): Move minibuffer-local-completion-map,
2697 minibuffer-local-filename-completion-map,
2698 minibuffer-local-must-match-map, and
2699 minibuffer-local-filename-must-match-map to Elisp.
2700 (syms_of_keymap): Defsubr make-composed-keymap.
2701 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2702 (parse_menu_item): Trivial simplification.
2703
3279eb87
GM
27042011-07-01 Glenn Morris <rgm@gnu.org>
2705
2706 * Makefile.in (SETTINGS_LIBS): Fix typo.
2707
4550efdf
KI
27082011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2709
2710 * coding.c (Fencode_coding_string): Record the last coding system
2711 used, as the function doc string says (bug#8738).
2712
0949d2b6
JD
27132011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2714
2715 * xsettings.c (store_monospaced_changed): Take new font as arg and
2716 check for change against current_mono_font.
2717 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2718 (emacs_settings_constructor, emacs_settings_get_property)
2719 (emacs_settings_set_property, emacs_settings_class_init)
2720 (emacs_settings_init, gsettings_obj): Remove.
2721 (something_changedCB): New function for HAVE_GSETTINGS.
2722 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2723 with value as argument.
2724 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2725 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2726 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2727 "changed".
2728
2729 * xgselect.c: Add defined (HAVE_GSETTINGS).
2730 (xgselect_initialize): Ditto.
2731
2732 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2733 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2734 xg_select.
2735
bbc6b304
PE
27362011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2737
2738 * eval.c (struct backtrace): Simplify and port the data structure.
2739 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2740 signed bit field, as this assumption is not portable and it makes
2741 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2742 "char debug_on_exit : 1" as this is not portable either; instead,
2743 use the portable "unsigned int debug_on_exit : 1". Remove unused
2744 member evalargs. Remove obsolete comments about cc bombing out.
2745
9851bfc5
JD
27462011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2747
51bb811f 2748 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2749 Let HAVE_GSETTINGS override HAVE_GCONF.
2750 (store_monospaced_changed): New function.
2751 (EMACS_SETTINGS): A new type derived from GObject to handle
2752 GSettings notifications.
2753 (emacs_settings_constructor, emacs_settings_get_property)
2754 (emacs_settings_set_property, emacs_settings_class_init):
2755 New functions.
2756 (gsettings_client, gsettings_obj): New variables.
2757 (GSETTINGS_SCHEMA): New define.
2758 (something_changedCB): Call store_monospaced_changed.
2759 (init_gsettings): New function.
2760 (xsettings_initialize): Call init_gsettings.
2761 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2762 to NULL.
2763
640c8776 2764 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2765 GCONF_CFLAGS/LIBS.
2766
5386012d
MR
27672011-06-29 Martin Rudalics <rudalics@gmx.at>
2768
2769 * window.c (resize_root_window, grow_mini_window)
2770 (shrink_mini_window): Rename Qresize_root_window to
2771 Qwindow_resize_root_window and Qresize_root_window_vertically to
2772 Qwindow_resize_root_window_vertically.
2773
f13e0b08
PE
27742011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2775
2776 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2777
94515237
JB
27782011-06-27 Juanma Barranquero <lekktu@gmail.com>
2779
2780 * makefile.w32-in: Redesign dependencies so they reflect more
2781 clearly which files are directly included by each source file,
2782 and not through other includes.
2783
e43b6e43
MR
27842011-06-27 Martin Rudalics <rudalics@gmx.at>
2785
2786 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2787 (sort_overlays, overlay_strings): When an overlay's clone number
2788 matches the window's clone number process the overlay even if
2789 the overlay's window property doesn't match the current window.
2790
d68443dc
MR
2791 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2792 (Fwindow_hchild): Rename to Fwindow_left_child.
2793 (Fwindow_next): Rename to Fwindow_next_sibling.
2794 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2795 (resize_window_check): Rename to window_resize_check.
2796 (resize_window_apply): Rename to window_resize_apply.
2797 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2798 (Fdelete_other_windows_internal, resize_frame_windows)
2799 (Fsplit_window_internal, Fdelete_window_internal)
2800 (grow_mini_window, shrink_mini_window)
2801 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2802
c7e73be5
JD
28032011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2804
2805 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2806 (emacs_fixed_set_min_size): Remove.
2807 (emacs_fixed_new): Take frame as argument.
2808
2809 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2810 (_EmacsFixedPrivate): Remove minwidth/height.
2811 Add struct frame *f.
2812 (emacs_fixed_init): Initialize priv->f.
2813 (get_parent_class, emacs_fixed_set_min_size): Remove.
2814 (emacs_fixed_new): Set priv->f to argument.
2815 (emacs_fixed_get_preferred_width)
2816 (emacs_fixed_get_preferred_height): Use min_width/height from
2817 frames size_hint to set minimum and natural (Bug#8919).
2818 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2819 and use min_width/height from frames size_hint to set
2820 min_width/height (Bug#8919).
2821
2822 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2823 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2824 Fix indentation.
c7e73be5 2825
cf99dcf8
EZ
28262011-06-26 Eli Zaretskii <eliz@gnu.org>
2827
2828 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2829 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2830 called at ZV.
2831
029529ac
CY
28322011-06-26 Chong Yidong <cyd@stupidchicken.com>
2833
2834 * process.c (wait_reading_process_output): Bypass select if
2835 waiting for a cell while ignoring keyboard input, and input is
2836 pending. Suggested by Jan Djärv (Bug#8869).
2837
7a7ef429
PE
28382011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2839
2840 Use gnulib's dup2 module instead of rolling our own.
2841 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2842
11fdef7d 28432011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2844
2845 * dispnew.c (scrolling_window): Before scrolling, turn off a
2846 mouse-highlight in the window being scrolled.
2847
cd3520a4
JB
28482011-06-24 Juanma Barranquero <lekktu@gmail.com>
2849
2850 Move DEFSYM to lisp.h and use everywhere.
2851
2852 * character.h (DEFSYM): Move declaration...
2853 * lisp.h (DEFSYM): ...here.
2854
2855 * gnutls.c:
2856 * minibuf.c:
2857 * w32menu.c:
2858 * w32proc.c:
2859 * w32select.c: Don't include character.h.
2860
2861 * alloc.c (syms_of_alloc):
2862 * buffer.c (syms_of_buffer):
2863 * bytecode.c (syms_of_bytecode):
2864 * callint.c (syms_of_callint):
2865 * casefiddle.c (syms_of_casefiddle):
2866 * casetab.c (init_casetab_once):
2867 * category.c (init_category_once, syms_of_category):
2868 * ccl.c (syms_of_ccl):
2869 * cmds.c (syms_of_cmds):
2870 * composite.c (syms_of_composite):
2871 * dbusbind.c (syms_of_dbusbind):
2872 * dired.c (syms_of_dired):
2873 * dispnew.c (syms_of_display):
2874 * doc.c (syms_of_doc):
2875 * editfns.c (syms_of_editfns):
2876 * emacs.c (syms_of_emacs):
2877 * eval.c (syms_of_eval):
2878 * fileio.c (syms_of_fileio):
2879 * fns.c (syms_of_fns):
2880 * frame.c (syms_of_frame):
2881 * fringe.c (syms_of_fringe):
2882 * insdel.c (syms_of_insdel):
2883 * keymap.c (syms_of_keymap):
2884 * lread.c (init_obarray, syms_of_lread):
2885 * macros.c (syms_of_macros):
2886 * msdos.c (syms_of_msdos):
2887 * print.c (syms_of_print):
2888 * process.c (syms_of_process):
2889 * search.c (syms_of_search):
2890 * sound.c (syms_of_sound):
2891 * syntax.c (init_syntax_once, syms_of_syntax):
2892 * terminal.c (syms_of_terminal):
2893 * textprop.c (syms_of_textprop):
2894 * undo.c (syms_of_undo):
2895 * w32.c (globals_of_w32):
2896 * window.c (syms_of_window):
2897 * xdisp.c (syms_of_xdisp):
2898 * xfaces.c (syms_of_xfaces):
2899 * xfns.c (syms_of_xfns):
2900 * xmenu.c (syms_of_xmenu):
2901 * xsettings.c (syms_of_xsettings):
2902 * xterm.c (syms_of_xterm): Use DEFSYM.
2903
4228cf16
TZ
29042011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2905
cd3520a4 2906 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2907
7fcccf1e
PE
29082011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2909
7efb4e0e
PE
2910 Integer and buffer overflow fixes (Bug#8873).
2911
ff5844ad
PE
2912 * print.c (printchar, strout): Check for string overflow.
2913 (PRINTPREPARE, printchar, strout):
2914 Don't set size unless allocation succeeds.
2915
90532f02
PE
2916 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2917 for sizes. Check for string overflow more accurately.
2918 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2919
6d84508d
PE
2920 * macros.c: Integer and buffer overflow fixes.
2921 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2922 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2923 Use ptrdiff_t, not int, for sizes.
2924 Don't increment bufsize until after realloc succeeds.
2925 Check for size-calculation overflow.
2926 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2927
437b2cb4
PE
2928 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2929
8b9ac8b4
PE
2930 * lread.c: Integer overflow fixes.
2931 (read_integer): Radix is now EMACS_INT, not int,
2932 to improve quality of diagnostics for out-of-range radices.
2933 Calculate buffer size correctly for out-of-range radices.
2934 (read1): Check for integer overflow in radices, and in
2935 read-circle numbers.
82cb60d3
PE
2936 (read_escape): Avoid int overflow.
2937 (Fload, openp, read_buffer_size, read1)
2938 (substitute_object_recurse, read_vector, read_list, map_obarray):
2939 Use ptrdiff_t, not int, for sizes.
2940 (read1): Use EMACS_INT, not int, for sizes.
20270765 2941 Check for size overflow.
8b9ac8b4 2942
7fcccf1e
PE
2943 * image.c (cache_image): Check for size arithmetic overflow.
2944
bfbbd7e7
PE
2945 * lread.c: Integer overflow issues.
2946 (saved_doc_string_size, saved_doc_string_length)
2947 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2948 Now ptrdiff_t, not int.
2949 (read1): Don't assume doc string length fits in int. Check for
2950 out-of-range doc string lengths.
2951 (read_list): Don't assume file position fits in int.
39019e54 2952 (read_escape): Check for hex character overflow.
bfbbd7e7 2953
4e323265
LL
29542011-06-22 Leo Liu <sdl.web@gmail.com>
2955
2956 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2957 Move to minibuffer.el.
2958
85fece3e
PE
29592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2960
20b84ce9 2961 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2962 The following patches are for when GLYPH_DEBUG && !XASSERT.
2963 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2964 * dispnew.c (flush_stdout):
2965 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2966 Mark as externally visible.
2967 * dispnew.c (check_window_matrix_pointers): Now static.
2968 * dispnew.c (window_to_frame_vpos):
2969 * xfns.c (unwind_create_frame):
2970 * xterm.c (x_check_font): Remove unused local.
2971 * scroll.c (CHECK_BOUNDS):
2972 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2973 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2974 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2975 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2976 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2977 Now static.
2978 (debug_method_add): Use va_list and vsprintf rather than relying
2979 on undefined behavior with wrong number of arguments.
2980 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2981 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2982 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2983 since we're not interested in debugging glyphs with old libraries.
2984 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2985 GCC 4.6.0's static checking.
2986
0766b489
PE
29872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2988
31fd4b32
PE
2989 Integer overflow and signedness fixes (Bug#8873).
2990 A few related buffer overrun fixes, too.
2991
b79e8648
PE
2992 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2993
0766b489
PE
2994 * dispextern.h (struct face.stipple):
2995 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2996 (x_bitmap_mask, x_allocate_bitmap_record)
2997 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2998 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2999 (x_create_bitmap_from_xpm_data):
3000 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3001 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3002 (.bitmaps_last):
3003 * xfaces.c (load_pixmap):
3004 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3005 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3006 (.bitmaps_last, struct x_output.icon_bitmap):
3007 Use ptrdiff_t, not int, for bitmap indexes.
3008 (x_allocate_bitmap_record): Check for size overflow.
3009 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3010
b081724f
PE
3011 Use ptrdiff_t, not int, for overlay counts.
3012 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3013 * editfns.c (overlays_around, get_pos_property):
3014 * textprop.c (get_char_property_and_overlay):
3015 * xdisp.c (next_overlay_change, note_mouse_highlight):
3016 * xfaces.c (face_at_buffer_position):
21514da7
PE
3017 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3018 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3019 (Fnext_overlay_change, Fprevious_overlay_change)
3020 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3021 Use ptrdiff_t, not int, for sizes.
21514da7 3022 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3023
3de73e5e
PE
3024 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3025
2606c57b
PE
3026 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3027 (x_session_initialize): Do not assume string length fits in int.
3028
aaafe47a
PE
3029 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3030 This is unlikely, but can occur if DPI is outlandish.
3031
2674ddc8 3032 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3033 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3034
28154962
PE
3035 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3036 * xrdb.c (magic_file_p, search_magic_path):
3037 Omit last arg SUFFIX; it was always 0. All callers changed.
3038 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3039
7de51af5
PE
3040 * xfont.c (xfont_match): Avoid need for strlen.
3041
25ed6cc3
PE
3042 * xfns.c: Don't assume strlen fits in int.
3043 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3044
4eab31dd
PE
3045 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3046 not unsigned long, as we prefer signed integers. All callers changed.
3047 Detect integer overflow in repeat count.
3048 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3049 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3050
171e2a58
PE
3051 * termcap.c: Don't assume sizes fit in int and never overflow.
3052 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3053 (gobble_line): Check for size-calculation overflow.
3054
ad39faca 3055 * minibuf.c (Fread_buffer):
6e5bb2dc 3056 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3057 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3058 Don't assume string length fits in int.
3059
52c61c22 3060 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3061 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3062
b5b8c9e5
PE
3063 * font.c: Don't assume string length fits in int.
3064 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3065 Use ptrdiff_t, not int.
ccd6111c
PE
3066 (font_intern_prop): Don't assume string length fits in int.
3067 Don't assume integer property fits in fixnum.
3068 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3069
882f0d81 3070 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3071 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3072 Reformulate so as not to need the command string.
3073 Invoke gzip -cd rather than gunzip, as it's more portable.
3074 (lock_info_type, lock_file_1, lock_file):
3075 Don't assume pid_t and time_t fit in unsigned long.
3076 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3077 (current_lock_owner): Prefer signed type for sizes.
3078 Use memcpy, not strncpy, where memcpy is what is really wanted.
3079 Don't assume (via atoi) that time_t and pid_t fit in int.
3080 Check for time_t and/or pid_t out of range, e.g., via a network share.
3081 Don't alloca where an auto var works fine.
3082
93f4cf88
PE
3083 * fileio.c: Fix some integer overflow issues.
3084 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3085 Don't assume string length fits in int.
3086 (directory_file_name): Don't assume string length fits in long.
3087 (make_temp_name): Don't assume pid fits in int, or that its print
3088 length is less than 20.
3089
f3e92b69
PE
3090 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3091
1bfdaf10
PE
3092 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3093
35016e9a
PE
3094 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3095
3d1e65a1
PE
3096 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3097 We prefer signed integers, even for size calculations.
3098
0b963a93
PE
3099 * emacs.c: Don't assume string length fits in 'int'.
3100 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3101 (main): Don't invoke strlen when not needed.
3102
573f4b54
PE
3103 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3104 (XD_DEBUG_MESSAGE): Don't waste a byte.
3105
989f33ba
PE
3106 * callproc.c (getenv_internal_1, getenv_internal)
3107 (Fgetenv_internal):
965d34eb
PE
3108 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3109
e4d29b33
PE
3110 * lread.c (invalid_syntax): Omit length argument.
3111 All uses changed. This doesn't fix a bug, but it simplifies the
3112 code away from its former Hollerith-constant appearance, and it's
3113 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3114 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3115
eb49b136
PE
3116 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3117 This didn't break anything, but it didn't help either.
3118 It's confusing to put a bogus integer in a place where the actual
3119 value does not matter.
9f62aeb1 3120 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3121 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3122
15375a22
PE
3123 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3124 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3125 implementation.
b61cc01c
PE
3126 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3127 We prefer signed types, and the value cannot exceed the EMACS_INT
3128 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3129 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3130 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3131 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3132
53b2623d
PE
3133 * indent.c (sane_tab_width): New function.
3134 (current_column, scan_for_column, Findent_to, position_indentation)
3135 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3136 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3137
51cab52b 3138 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3139
f2ed8a70
PE
3140 * lisp.h (lint_assume): New macro.
3141 * composite.c (composition_gstring_put_cache):
3142 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3143
abe80cc6
PE
3144 * editfns.c, insdel.c:
3145 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3146
b02c740e
PE
3147 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3148
ebc96716
PE
3149 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3150
b4e50fa0 3151 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3152 Use much-faster test for byte-length change.
311d5d7c 3153 Don't assume string byte-length fits in 'int'.
a4cf38e4 3154 Check that character arg fits in 'int'.
85461888 3155 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3156
c0c1ee9f
PE
3157 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3158
a498d7f4
PE
3159 * fns.c (concat): Catch string overflow earlier.
3160 Do not rely on integer wraparound.
3161
51cab52b
PE
3162 * dispextern.h (struct it.overlay_strings_charpos)
3163 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3164 * xdisp.c (forward_to_next_line_start)
3165 (back_to_previous_visible_line_start)
3166 (reseat_at_next_visible_line_start, next_element_from_buffer):
3167 Don't arbitrarily truncate the value of 'selective' to int.
3168
76031fad
PE
3169 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3170
5eb55db9
PE
3171 * composite.c: Don't truncate sizes to 'int'.
3172 (composition_gstring_p, composition_reseat_it)
3173 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3174 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3175 not EMACS_UINT, for indexes.
5eb55db9 3176
0703a717
PE
3177 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3178
d6202519
PE
3179 * buffer.c: Include <verify.h>.
3180 (struct sortvec.priority, struct sortstr.priority):
8961a454 3181 Now EMACS_INT, not int.
c20998a7 3182 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3183 (struct sortstr.size, record_overlay_string)
3184 (struct sortstrlist.size, struct sortlist.used):
3185 Don't truncate size to int.
3186 (record_overlay_string): Check for size-calculation overflow.
d6202519 3187 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3188
d5a19415
JM
31892011-06-22 Jim Meyering <meyering@redhat.com>
3190
029529ac 3191 Don't leak an XBM-image-sized buffer
d5a19415
JM
3192 * image.c (xbm_load): Free the image buffer after using it.
3193
a9041e6c
PE
31942011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3195
3196 Port to Sun C.
3197 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3198 that Sun C diagnosed.
3199 * fns.c (secure_hash): Fix pointer signedness issue.
3200 * intervals.c (static_offset_intervals): New function.
3201 (offset_intervals): Use it.
3202
7f3f739f
LL
32032011-06-21 Leo Liu <sdl.web@gmail.com>
3204
3205 * deps.mk (fns.o):
3206 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3207 sha512.h.
3208
3209 * fns.c (secure_hash): Rename from crypto_hash_function and change
3210 the first arg to accept symbols.
5b66d427 3211 (Fsecure_hash): New primitive.
7f3f739f
LL
3212 (syms_of_fns): New symbols.
3213
76147d94
DD
32142011-06-20 Deniz Dogan <deniz@dogan.se>
3215
3216 * process.c (Fset_process_buffer): Clarify return value in
3217 docstring.
3218
7d7d0045
CY
32192011-06-18 Chong Yidong <cyd@stupidchicken.com>
3220
3221 * dispnew.c (add_window_display_history): Use BVAR.
3222
3223 * xdisp.c (debug_method_add): Use BVAR.
3224 (check_window_end, dump_glyph_matrix, dump_glyph)
3225 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3226
3227 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3228 Likewise.
3229
3230 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3231 check till after the cache is created in init_frame_faces.
3232
ff2bc410
SM
32332011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3234
3235 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3236
28177add
PE
32372011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3238
dd3482fe
PE
3239 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3240 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3241 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3242
393d71f3 3243 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3244 * fileio.c (Finsert_file_contents):
3245 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3246 Remove the old (too-loose) buffer overflow checks.
3247 They weren't needed, since make_gap checks for buffer overflow.
3248 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3249 The old code merely checked for Emacs fixnum overflow, and relied
3250 on undefined (wraparound) behavior. The new code avoids undefined
3251 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3252
2e6813b0 3253 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3254 Tune. Don't use wider integers than needed. Don't use alloca.
3255 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3256
599a9e4f
PE
3257 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3258
99561444
PE
3259 * insdel.c, lisp.h (buffer_overflow): New function.
3260 (insert_from_buffer_1, replace_range, replace_range_2):
3261 * insdel.c (make_gap_larger):
3262 * editfns.c (Finsert_char):
3263 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3264
28177add
PE
3265 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3266
e69dafad
PE
32672011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3268
a7af7fde 3269 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3270
b1c46f02
PE
3271 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3272 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3273
e69dafad
PE
3274 * fileio.c: Don't assume EMACS_INT fits in off_t.
3275 (emacs_lseek): New static function.
3276 (Finsert_file_contents, Fwrite_region): Use it.
3277 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3278
566684ea
PE
3279 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3280
e6966cd6
PE
3281 * fns.c: Don't overflow int when computing a list length.
3282 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3283 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3284 truncation on 64-bit hosts. Check for QUIT every
3285 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3286 faster and is responsive enough.
3287 (Flength): Report an error instead of overflowing an integer.
3288 (Fsafe_length): Return a float if the value is not representable
3289 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3290 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3291 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3292
dd0b0efb
PE
3293 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3294 (header_size, word_size): New constants.
3295 (allocate_vectorlike): Don't check size overflow here.
3296 (allocate_vector): Check it here instead, since this is the only
3297 caller of allocate_vectorlike that could cause overflow.
3298 Check that the new vector's length is representable as a fixnum.
3299
86fe5cfe
PE
3300 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3301 The previous code was bogus. For example, next_almost_prime (32)
3302 returned 39, which is undesirable as it is a multiple of 3; and
3303 next_almost_prime (24) returned 25, which is a multiple of 5 so
3304 why was the code bothering to check for multiples of 7?
3305
80e88859
PE
3306 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3307
4a2f0ad6
PE
3308 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3309
f66c7cf8
PE
3310 Variadic C functions now count arguments with ptrdiff_t.
3311 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3312 Back then I didn't know that the Emacs coding style prefers signed int.
3313 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3314 were being counted with int, which may truncate counts on 64-bit
3315 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3316 * lisp.h (struct Lisp_Subr.function.aMANY)
3317 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3318 Arg counts are now ptrdiff_t, not size_t.
3319 All variadic functions and their callers changed accordingly.
3320 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3321 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3322 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3323 * callint.c (Fcall_interactively): Check arg count for overflow,
3324 to avoid potential buffer overrun. Use signed char, not 'int',
3325 for 'varies' array, so that we needn't bother to check its size
3326 calculation for overflow.
3327 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3328 * eval.c (apply_lambda):
3329 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3330 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3331 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3332
a1759b76
PE
3333 * callint.c (Fcall_interactively): Don't use index var as event count.
3334
d96be9fc
PE
3335 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3336 * mem-limits.h (SIZE): Remove; no longer used.
3337
a690a978 3338 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3339
578c21e6
PE
3340 Remove unnecessary casts.
3341 * xterm.c (x_term_init):
3342 * xfns.c (x_set_border_pixel):
3343 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3344 These aren't needed now that we assume ANSI C.
3345
96f53c6c
PE
3346 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3347 It's more likely to cause problems (due to unsigned overflow)
3348 than to cure them.
3349
83c77d31
PE
3350 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3351
ee2079f1
PE
3352 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3353
6da65536
PE
3354 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3355
7147c4a4
PE
3356 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3357
193e32d9
PE
3358 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3359
e5533da6
PE
3360 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3361
9910e595
PE
3362 GLYPH_CODE_FACE returns EMACS_INT, not int.
3363 * dispextern.h (merge_faces):
3364 * xfaces.c (merge_faces):
01103c44
PE
3365 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3366 Don't assume EMACS_INT fits in int.
9910e595 3367
2638320e
PE
3368 * character.h (CHAR_VALID_P): Remove unused parameter.
3369 * fontset.c, lisp.h, xdisp.c: All uses changed.
3370
045eb8d9
PE
3371 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3372
c1f134b5
PE
3373 * fns.c (concat): Minor tuning based on overflow analysis.
3374 This doesn't fix any bugs. Use int to hold character, instead
3375 of constantly refetching from Emacs object. Use XFASTINT, not
3376 XINT, for value known to be a character. Don't bother comparing
3377 a single byte to 0400, as it's always less.
3378
395fcb93 3379 * floatfns.c (Fexpt):
327eeec8
PE
3380 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3381
abbd3d23
PE
3382 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3383 for characters.
3384
684a03ef
PE
3385 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3386
0fed43f3
PE
3387 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3388 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3389 incorrectly succeed when S was a string, because 4294967386 was
3390 truncated before it was used.
3391
8fd02eb7
PE
3392 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3393 Otherwise, an out-of-range integer could cause undefined behavior
3394 on a 64-bit host.
3395
f8c86b69
PE
3396 * composite.c: Use int, not EMACS_INT, for characters.
3397 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3398 EMACS_INT, for values that are known to be in character range.
3399 This doesn't fix any bugs but is the usual style inside Emacs and
3400 may generate better code on 32-bit machines.
3401
34206dd2
PE
3402 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3403 This is for reasons similar to the recent CHAR_STRING fix.
3404 * charset.c (Fencode_char): Check that character arg is actually
3405 a character. Pass an int to ENCODE_CHAR.
3406 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3407 wider than 'int', as a compile-time check to prevent future regressions
3408 in this area.
3409
c5958d4c 3410 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3411
3412 Make sure a 64-bit char is never passed to CHAR_STRING.
3413 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3414 by silently ignoring the top 32 bits, allowing some values
3415 that were far too large to be valid characters.
3416 * character.h: Include <verify.h>.
3417 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3418 arguments are no wider than unsigned, as a compile-time check
3419 to prevent future regressions in this area.
3420 * data.c (Faset):
01103c44 3421 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3422 (Fsubst_char_in_region):
3423 * fns.c (concat):
3424 * xdisp.c (decode_mode_spec_coding):
3425 Adjust to CHAR_STRING's new requirement.
3426 * editfns.c (Finsert_char, Fsubst_char_in_region):
3427 * fns.c (concat): Check that character args are actually
3428 characters. Without this test, these functions did the wrong
3429 thing with wildly out-of-range values on 64-bit hosts.
3430
d37ca623
PE
3431 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3432 These casts should not be needed on 32-bit hosts, either.
3433 * keyboard.c (read_char):
3434 * lread.c (Fload): Remove casts to unsigned.
3435
ea204efb
PE
3436 * lisp.h (UNSIGNED_CMP): New macro.
3437 This fixes comparison bugs on 64-bit hosts.
3438 (ASCII_CHAR_P): Use it.
3439 * casefiddle.c (casify_object):
01103c44 3440 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3441 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3442 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3443 * dispextern.h (FACE_FROM_ID):
3444 * keyboard.c (read_char): Use UNSIGNED_CMP.
3445
41cb286c
PE
3446 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3447 not to EMACS_INT, to avoid GCC warning.
3448
4a1b9832
PE
3449 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3450
55daad71
PE
3451 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3452 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3453 isn't needed on 32-bit machines.
8f95c75c 3454
01103c44
PE
3455 * buffer.c (Fgenerate_new_buffer_name):
3456 Use EMACS_INT for count, not int.
0ceccced 3457 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3458
3459 * data.c (Qcompiled_function): Now static.
3460
c6f072e7
PE
3461 * window.c (window_body_lines): Now static.
3462
20ce5912
PE
3463 * image.c (gif_load): Rename local to avoid shadowing.
3464
9c4c5f81
PE
3465 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3466 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3467 * alloc.c (make_save_value): Integer argument is now of type
3468 ptrdiff_t, not int.
3469 (mark_object): Use ptrdiff_t, not int.
3470 * lisp.h (pD): New macro.
3471 * print.c (print_object): Use it.
3472
c0c5c8ae
PE
3473 * alloc.c: Use EMACS_INT, not int, to count objects.
3474 (total_conses, total_markers, total_symbols, total_vector_size)
3475 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3476 (total_free_floats, total_floats, total_free_intervals)
3477 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3478 Now EMACS_INT, not int. All uses changed.
3479 (Fgarbage_collect): Compute overall total using a double, so that
3480 integer overflow is less likely to be a problem. Check for overflow
3481 when converting back to an integer.
5a25e253
PE
3482 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3483 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3484 These were 'int' variables that could overflow on 64-bit hosts;
3485 they were never used, so remove them instead of repairing them.
211a0b2a 3486 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3487 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3488 Previously, this ceilinged at INT_MAX, but that doesn't work on
3489 64-bit machines.
e46bb31a 3490 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3491
c78baabf 3492 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3493 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3494 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3495 when a (possibly-narrower) signed value would do just as well.
3496 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3497
c9d624c6
PE
3498 * alloc.c: Catch some string size overflows that we were missing.
3499 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3500 for convenience in STRING_BYTES_MAX.
3501 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3502 The definition here is exact; the one in lisp.h was approximate.
3503 (allocate_string_data): Check for string overflow. This catches
3504 some instances we weren't catching before. Also, it catches
3505 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3506 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3507 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3508
c9d624c6
PE
3509 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3510 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3511 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3512
353032ce
PE
3513 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3514
2bccce07
PE
3515 * alloc.c (Fmake_string): Check for out-of-range init.
3516
0ac30604
SM
35172011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3518
3519 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3520
c195f2de
JD
35212011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3522
3523 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3524 xg_get_default_scrollbar_width.
3525
3526 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3527 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3528 (style_changed_cb): Call update_theme_scrollbar_width and call
3529 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3530 all frames (Bug#8505).
3531 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3532 Call gtk_window_set_resizable if HAVE_GTK3.
3533 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3534 and height if HAVE_GTK3 (Bug#8505).
3535 (scroll_bar_width_for_theme): New variable.
3536 (update_theme_scrollbar_width): New function.
3537 (xg_get_default_scrollbar_width): Move code to
3538 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3539 (xg_initialize): Call update_theme_scrollbar_width.
3540
3541 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3542
3543 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3544
e10ac9f1
MR
35452011-06-12 Martin Rudalics <rudalics@gmx.at>
3546
3547 * frame.c (make_frame): Call other_buffer_safely instead of
3548 other_buffer.
3549
3550 * window.c (temp_output_buffer_show): Call display_buffer with
3551 second argument Vtemp_buffer_show_specifiers and reset latter
3552 immediately after the call.
3553 (Vtemp_buffer_show_specifiers): New variable.
3554 (auto_window_vscroll_p, next_screen_context_lines)
3555 (Vscroll_preserve_screen_position): Remove leading asterisks from
3556 doc-strings.
3557
2d3c217e 35582011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3559
7b7f97e8 3560 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3561 * buffer.c (Qclone_number): Remove for now, as it's unused.
3562 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3563 (record_buffer): Remove unused local.
3564 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3565 (set_frame_buffer_list): Remove; unused.
3566 * frame.h (other_visible_frames): Remove decl.
3567 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3568 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3569 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3570 if HAVE_GPM.
3571 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3572 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3573 Define only if HAVE_GPM.
3574 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3575 (update_hints_inhibit): Remove; never set. All uses removed.
3576 * widgetprv.h (emacsFrameClassRec): Remove decl.
3577 * window.c (delete_deletable_window): Now returns void, since it
3578 wasn't returning anything.
3579 (compare_window_configurations): Remove unused locals.
3580 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3581 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3582 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3583 the same widths as pointers. This follows up on the 2011-05-06 patch.
3584 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3585 * xterm.h: Likewise.
3586 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3587
1384b89e
JB
35882011-06-12 Juanma Barranquero <lekktu@gmail.com>
3589
3590 * makefile.w32-in: Update dependencies.
3591 (LISP_H): Add lib/intprops.h.
3592
1100a63c
CY
35932011-06-11 Chong Yidong <cyd@stupidchicken.com>
3594
3595 * image.c (gif_load): Add animation frame delay to the metadata.
3596 (syms_of_image): Use DEFSYM. New symbol `delay'.
3597
6198ccd0
MR
35982011-06-11 Martin Rudalics <rudalics@gmx.at>
3599
3600 * window.c (delete_deletable_window): Re-add.
3601 (Fset_window_configuration): Rewrite to handle dead buffers and
3602 consequently deletable windows.
3603 (window_tree, Fwindow_tree): Remove. Supply functionality in
3604 window.el.
3605 (compare_window_configurations): Simplify code.
3606
b6e3633c
AS
36072011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3608
1ab0dee5
AS
3609 * image.c (imagemagick_load_image): Fix type mismatch.
3610 (Fimagemagick_types): Likewise.
3611
b6e3633c
AS
3612 * window.h (replace_buffer_in_windows): Declare.
3613
9397e56f
MR
36142011-06-11 Martin Rudalics <rudalics@gmx.at>
3615
3616 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3617 Qclone_number. Remove external declaration of Qdelete_window.
3618 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3619 code.
640c8776
SM
3620 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3621 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3622 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3623 buffer list implementation.
3624 (other_buffer_safely): New function.
3625 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3626 calls to replace_buffer_in_windows and
3627 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3628 if allowed.
3629 (record_buffer): Inhibit quitting and rewrite using quittable
3630 functions. Run Qbuffer_list_update_hook if allowed.
3631 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3632 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3633 Move switch-to-buffer to window.el.
9397e56f
MR
3634 (bury-buffer): Move to window.el.
3635 (Vbuffer_list_update_hook): New variable.
3636
3637 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3638 section.
3639
3640 * window.h (resize_frame_windows): Move up in code.
3641 (Fwindow_frame): Remove EXFUN.
3642 (replace_buffer_in_all_windows): Remove prototype.
3643 (replace_buffer_in_windows_safely): Add prototype.
3644
3645 * window.c: Declare Qdelete_window static again. Move down
3646 declaration of select_count.
3647 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3648 (Fother_window): Move to window.el.
3649 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3650 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3651 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3652 window.el.
3653 (replace_buffer_in_windows): Implement by calling
3654 Qreplace_buffer_in_windows.
3655 (replace_buffer_in_all_windows): Remove with some functionality
3656 moved into replace_buffer_in_windows_safely.
3657 (replace_buffer_in_windows_safely): New function.
3658 (select_window_norecord, select_frame_norecord): Move in front
3659 of run_window_configuration_change_hook. Remove now obsolete
3660 declarations.
640c8776
SM
3661 (Fset_window_buffer): Rewrite doc-string.
3662 Call Qrecord_window_buffer.
9397e56f
MR
3663 (keys_of_window): Move binding for other-window to window.el.
3664
b50691aa
CY
36652011-06-11 Chong Yidong <cyd@stupidchicken.com>
3666
3667 * dispextern.h (struct image): Replace data member, whose int_val
3668 and ptr_val fields were not used by anything, with a single
3669 lisp_val object.
3670
3671 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3672 (gif_clear_image, gif_load, imagemagick_load_image)
3673 (gs_clear_image, gs_load): Callers changed.
3674
3f754b86
PE
36752011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3676
cca69397
PE
3677 * buffer.h: Include <time.h>, for time_t.
3678 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3679
109e28d0
PE
3680 Fix minor problems found by static checking.
3681
60737f02
PE
3682 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3683
4b66faf3
PE
3684 Make identifiers static if they are not used in other modules.
3685 * data.c (Qcompiled_function, Qframe, Qvector):
3686 * image.c (QimageMagick, Qsvg):
3687 * minibuf.c (Qmetadata):
3688 * window.c (resize_window_check, resize_root_window): Now static.
3689 * window.h (resize_window_check, resize_root_window): Remove decls.
3690
109e28d0
PE
3691 * window.c (window_deletion_count, delete_deletable_window):
3692 Remove; unused.
46a4ce9e
PE
3693 (window_body_lines): Now static.
3694 (Fdelete_other_windows_internal): Mark vars as initialized.
3695 Make sure 'resize_failed' is initialized.
3696 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3697 (resize_window_apply): Remove unused local.
3698 * window.h (delete_deletable_window): Remove decl.
3699
109e28d0 3700 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3701 (imagemagick_load_image): Fix pointer signedness problem by changing
3702 last arg from unsigned char * to char *. All uses changed.
3703 Also, fix a local for similar reasons.
3704 Remove unused locals. Remove locals to avoid shadowing.
3705 (fn_rsvg_handle_free): Remove; unused.
3706 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3707 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3708
3f754b86
PE
3709 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3710
2547adb1
CY
37112011-06-10 Chong Yidong <cyd@stupidchicken.com>
3712
3713 * image.c (gif_load): Fix omitted cast error introduced by
3714 2011-06-06 change.
3715
2c8e37d4
MR
37162011-06-10 Martin Rudalics <rudalics@gmx.at>
3717
3718 * window.h (resize_proportionally, orig_total_lines)
3719 (orig_top_line): Remove from window structure.
3720 (set_window_height, set_window_width, change_window_heights)
3721 (Fdelete_window): Remove prototypes.
3722 (resize_frame_windows): Remove duplicate declaration.
3723
440a42e3
EZ
37242011-06-10 Eli Zaretskii <eliz@gnu.org>
3725
3726 * window.h (resize_frame_windows, resize_window_check)
3727 (delete_deletable_window, resize_root_window)
3728 (resize_frame_windows): Declare prototypes.
3729
3730 * window.c (resize_window_apply): Make definition be "static" to
3731 match the prototype.
3732
562dd5e9
MR
37332011-06-10 Martin Rudalics <rudalics@gmx.at>
3734
3735 * window.c: Remove declarations of Qwindow_size_fixed,
3736 window_min_size_1, window_min_size_2, window_min_size,
3737 size_window, window_fixed_size_p, enlarge_window, delete_window.
3738 Remove static from declaration of Qdelete_window, it's
3739 temporarily needed by Fbury_buffer.
3740 (replace_window): Don't assign orig_top_line and
3741 orig_total_lines.
3742 (Fdelete_window, delete_window): Remove. Window deletion is
3743 handled by window.el.
640c8776
SM
3744 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3745 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3746 (Fdelete_other_windows): Remove. Deleting other windows is
3747 handled by window.el.
3748 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3749 handled in window.el.
3750 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3751 Window minimum sizes are handled in window.el.
3752 (shrink_windows, size_window, set_window_height)
3753 (set_window_width, change_window_heights, window_height)
3754 (window_width, CURBEG, CURSIZE, enlarge_window)
3755 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3756 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3757 handled in window.el.
3758 (make_dummy_parent): Rename to make_parent_window and give it a
3759 second argument horflag.
3760 (make_window): Don't set resize_proportionally any more.
3761 (Fsplit_window): Remove. Windows are split in window.el.
3762 (save_restore_action, save_restore_orig_size)
3763 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3764 Resize mini windows in window.el.
3765 (grow_mini_window, shrink_mini_window): Implement by calling
3766 Qresize_root_window_vertically, resize_window_check and
3767 resize_window_apply.
640c8776
SM
3768 (saved_window, Fset_window_configuration, save_window_save):
3769 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3770 resize_proportionally.
3771 (window_min_height, window_min_width): Move to window.el.
3772 (keys_of_window): Move bindings for delete-other-windows,
3773 split-window, delete-window and enlarge-window to window.el.
3774
3775 * buffer.c: Temporarily extern Qdelete_window.
3776 (Fbury_buffer): Temporarily call Qdelete_window instead of
3777 Fdelete_window (Fbury_buffer will move to window.el soon).
3778
3779 * frame.c (set_menu_bar_lines_1): Remove code handling
3780 orig_top_line and orig_total_lines.
3781
3782 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3783 set_window_height but set heights directly.
3784 (change_frame_size_1): Use resize_frame_windows.
3785
3786 * xdisp.c (init_xdisp): Don't use set_window_height but set
3787 heights directly.
3788
640c8776
SM
3789 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3790 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3791 run_window_configuration_change_hook.
3792
3793 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3794 instead of change_window_heights and run
3795 run_window_configuration_change_hook.
3796
1a13852e
MR
37972011-06-09 Martin Rudalics <rudalics@gmx.at>
3798
3799 * window.c (replace_window): Rename second argument REPLACEMENT to
3800 NEW. New third argument SETFLAG. Rewrite.
3801 (delete_window, make_dummy_parent): Call replace_window with
3802 third argument 1.
3803 (window_list_1): Move down in code.
3804 (run_window_configuration_change_hook): Move set_buffer part
3805 before select_frame_norecord part in order to unwind correctly.
3806 Rename count1 to count.
3807 (recombine_windows, delete_deletable_window, resize_root_window)
3808 (Fdelete_other_windows_internal)
3809 (Frun_window_configuration_change_hook, make_parent_window)
3810 (resize_window_check, resize_window_apply, Fresize_window_apply)
3811 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3812 (Fdelete_window_internal, Fresize_mini_window_internal):
3813 New functions.
1a13852e
MR
3814 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3815
f3d1777e
MR
38162011-06-08 Martin Rudalics <rudalics@gmx.at>
3817
496e208e
MR
3818 * window.h (window): Add some new members to window structure -
3819 normal_lines, normal_cols, new_total, new_normal, clone_number,
3820 splits, nest, prev_buffers, next_buffers.
3821 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3822 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3823
f3d1777e
MR
3824 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3825 Remove.
496e208e
MR
3826 (make_dummy_parent): Set new members of windows structure.
3827 (make_window): Move down in code. Handle new members of window
3828 structure.
3829 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3830 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3831 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3832 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3833 (Fset_window_next_buffers, Fset_window_clone_number):
3834 New functions.
496e208e
MR
3835 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3836 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3837 Doc-string fixes.
3838 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3839 Argument WINDOW can be now internal window too.
3840 (Fwindow_use_time): Move up in code.
3841 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3842 Rewrite doc-string.
3843 (Fset_window_configuration, saved_window)
3844 (Fcurrent_window_configuration, save_window_save): Handle new
3845 members of window structure.
b9e809c2
MR
3846 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3847 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3848 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3849 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3850 Qget_mru_window, Qresize_root_window,
3851 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3852 Qauto_buffer_name; staticpro them.
f3d1777e 3853
abde8f8c
MR
38542011-06-07 Martin Rudalics <rudalics@gmx.at>
3855
3856 * window.c (Fwindow_total_size, Fwindow_left_column)
3857 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3858 (Fwindow_list_1): New functions.
3859 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3860 (Fwindow_width, Fscroll_left, Fscroll_right):
3861 Use window_body_cols instead of window_box_text_cols.
3862 (delete_window, Fset_window_configuration):
3863 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3864 (delete_all_subwindows): Take a window as argument and not a
3865 structure. Rewrite.
190b47e6
MR
3866 (window_loop): Remove handling of GET_LRU_WINDOW and
3867 GET_LARGEST_WINDOW.
3868 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3869
3870 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3871 window_box_text_cols. delete_all_subwindows now takes a
3872 Lisp_Object as argument.
abde8f8c 3873
640c8776
SM
3874 * indent.c (compute_motion, Fcompute_motion):
3875 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3876
fa8a67e6
MR
3877 * frame.c (delete_frame): Call delete_all_subwindows with root
3878 window as argument.
3879
a54e3482
DC
38802011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3881
3882 * fns.c (Fputhash): Document return value.
3883
60002bf5
CY
38842011-06-06 Chong Yidong <cyd@stupidchicken.com>
3885
3886 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3887
0c671da6 38882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3889
b862a52a 3890 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3891
be44ca6c
PE
3892 Check for overflow when converting integer to cons and back.
3893 * charset.c (Fdefine_charset_internal, Fdecode_char):
3894 Use cons_to_unsigned to catch overflow.
3895 (Fencode_char): Use INTEGER_TO_CONS.
3896 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3897 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3898 * data.c (long_to_cons, cons_to_long): Remove.
3899 (cons_to_unsigned, cons_to_signed): New functions.
3900 These signal an error for invalid or out-of-range values.
3901 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3902 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3903 * font.c (Ffont_variation_glyphs):
3904 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3905 * lisp.h: Include <intprops.h>.
3906 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3907 (cons_to_signed, cons_to_unsigned): New decls.
3908 (long_to_cons, cons_to_long): Remove decls.
3909 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3910 (Fprimitive_undo): Use CONS_TO_INTEGER.
3911 * xfns.c (Fx_window_property): Likewise.
3912 * xselect.c: Include <limits.h>.
3913 (x_own_selection, selection_data_to_lisp_data):
3914 Use INTEGER_TO_CONS.
3915 (x_handle_selection_request, x_handle_selection_clear)
3916 (x_get_foreign_selection, Fx_disown_selection_internal)
3917 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3918 (lisp_data_to_selection_data): Use cons_to_unsigned.
3919 (x_fill_property_data): Use cons_to_signed.
3920 Report values out of range.
3921
d1f3d2af
PE
3922 Check for buffer and string overflow more precisely.
3923 * buffer.h (BUF_BYTES_MAX): New macro.
3924 * lisp.h (STRING_BYTES_MAX): New macro.
3925 * alloc.c (Fmake_string):
3926 * character.c (string_escape_byte8):
3927 * coding.c (coding_alloc_by_realloc):
3928 * doprnt.c (doprnt):
3929 * editfns.c (Fformat):
3930 * eval.c (verror):
3931 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3932 since they may not be the same number.
3933 * editfns.c (Finsert_char):
3934 * fileio.c (Finsert_file_contents):
3935 Likewise for BUF_BYTES_MAX.
3936
dd52fcea
PE
3937 * image.c: Use ptrdiff_t, not int, for sizes.
3938 (slurp_file): Switch from int to ptrdiff_t.
3939 All uses changed.
3940 (slurp_file): Check that file size fits in both size_t (for
3941 malloc) and ptrdiff_t (for sanity and safety).
3942
7f9bbdbb
PE
3943 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3944 if b->modtime has its maximal value.
3945
dfe18f82
PE
3946 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3947
84acfcf0
PE
3948 Don't assume time_t can fit into int.
3949 * buffer.h (struct buffer.modtime): Now time_t, not int.
3950 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3951 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3952
ccd9a01a
PE
3953 Minor fixes for signed vs unsigned integers.
3954 * character.h (MAYBE_UNIFY_CHAR):
3955 * charset.c (maybe_unify_char):
3956 * keyboard.c (read_char, reorder_modifiers):
3957 XINT -> XFASTINT, since the integer must be nonnegative.
3958 * ftfont.c (ftfont_spec_pattern):
3959 * keymap.c (access_keymap, silly_event_symbol_error):
3960 XUINT -> XFASTINT, since the integer must be nonnegative.
3961 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3962 since it makes no difference and we prefer signed.
3963 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3964 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3965 nonnegative.
3966
d6d100dd
SM
39672011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3968
3969 * window.h (Fwindow_frame): Declare.
3970
2b6148e4
PE
39712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3972
3973 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3974 (SPARE_MEMORY): Always define.
3975 (LARGE_REQUEST): Remove.
3976 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3977
f230ecc9
MR
39782011-06-06 Martin Rudalics <rudalics@gmx.at>
3979
727e958e
MR
3980 * lisp.h: Move EXFUNS for Fframe_root_window,
3981 Fframe_first_window and Fset_frame_selected_window to window.h.
3982
3983 * window.h: Move EXFUNS for Fframe_root_window,
3984 Fframe_first_window and Fset_frame_selected_window here from
3985 lisp.h.
3986
3987 * frame.c (Fwindow_frame, Fframe_first_window)
3988 (Fframe_root_window, Fframe_selected_window)
3989 (Fset_frame_selected_window): Move to window.c.
3990 (Factive_minibuffer_window): Move to minibuf.c.
3991 (Fother_visible_frames_p): New function.
3992
3993 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3994
f230ecc9
MR
3995 * window.c (decode_window, decode_any_window): Move up in code.
3996 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3997 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3998 (Fwindow_buffer): Move up and rewrite doc-string.
3999 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4000 (Fwindow_prev): New functions.
727e958e
MR
4001 (Fwindow_frame): Move here from frame.c. Accept any window as
4002 argument.
4003 (Fframe_root_window, Fframe_first_window)
4004 (Fframe_selected_window): Move here from frame.c. Accept frame
4005 or arbitrary window as argument. Update doc-strings.
4006 (Fminibuffer_window): Move up in code.
4007 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4008 (Fset_frame_selected_window): Move here from frame.c.
4009 Marginal rewrite.
727e958e
MR
4010 (Fselected_window, select_window, Fselect_window): Move up in
4011 code. Minor doc-string fixes.
f230ecc9 4012
4d09bcf6
PE
40132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4014
4015 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4016 Do not assume that spare memory exists; that assumption is valid
4017 only if SYSTEM_MALLOC.
4018 (LARGE_REQUEST): New macro, so that the issue of large requests
4019 is separated from the issue of spare memory.
4020
810928a2
AS
40212011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4022
172418ad
AS
4023 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4024 format. (Bug#8806)
4025
43f862f7
AS
4026 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4027
810928a2
AS
4028 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4029 before statements.
4030
a059fe24
JD
40312011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4032
4033 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4034
4035 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4036
4037 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4038 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4039
989bf368
JB
40402011-06-05 Juanma Barranquero <lekktu@gmail.com>
4041
4042 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4043
4b80f674
CY
40442011-06-04 Chong Yidong <cyd@stupidchicken.com>
4045
4046 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4047 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4048 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4049 New error handlers.
4b80f674
CY
4050 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4051 Obey Vx_select_enable_clipboard_manager. Catch errors in
4052 x_clipboard_manager_save (Bug#8779).
4053 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4054 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4055
99a33b77 40562011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4057
4058 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4059
99a33b77 40602011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4061
4062 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4063 in the current matrix if keep_current_p is non-zero.
4064
8264569d
EZ
40652011-06-04 Eli Zaretskii <eliz@gnu.org>
4066
4067 * bidi.c (bidi_level_of_next_char): Fix last change.
4068
57f97249
EZ
40692011-06-03 Eli Zaretskii <eliz@gnu.org>
4070
fec2107c 4071 Support bidi reordering of text covered by display properties.
57f97249 4072
fec2107c
EZ
4073 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4074 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4075 (bidi_cache_search, bidi_cache_iterator_state)
4076 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4077 (bidi_level_of_next_char, bidi_move_to_visually_next):
4078 Support character positions inside a run of characters covered by a
fec2107c
EZ
4079 display string.
4080 (bidi_paragraph_init, bidi_resolve_explicit_1)
4081 (bidi_level_of_next_char): Call bidi_fetch_char and
4082 bidi_fetch_char_advance instead of FETCH_CHAR and
4083 FETCH_CHAR_ADVANCE.
4084 (bidi_init_it): Initialize new members.
4085 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4086 definitions.
4087 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4088 instead of using explicit *_CHAR codes.
d6d100dd
SM
4089 (bidi_resolve_explicit, bidi_resolve_weak):
4090 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4091 bidirectional text is supported only in multibyte buffers.
4092 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4093 it to initialize the frame_window_p member of struct bidi_it.
4094 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4095 (bidi_resolve_explicit, bidi_resolve_weak)
4096 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4097 bidi_it->nchars is non-positive.
4098 (bidi_level_of_next_char): Don't try to lookup the cache for the
4099 next/previous character if nothing is cached there yet, or if we
4100 were just reseat()'ed to a new position.
c40e2fb2 4101
0e14fe90
EZ
4102 * xdisp.c (set_cursor_from_row): Set start and stop points
4103 according to the row's direction when priming the loop that looks
4104 for the glyph on which to display cursor.
4105 (single_display_spec_intangible_p): Function deleted.
4106 (display_prop_intangible_p): Reimplement to call
4107 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4108 Accept 3 additional arguments needed by handle_display_spec.
4109 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4110 values: lists, `(when COND...)' forms, etc.
4111 (single_display_spec_string_p): Support property values that are
4112 lists with the argument STRING its top-level element.
4113 (display_prop_string_p): Fix the condition for processing a
4114 property that is a list to be consistent with handle_display_spec.
fec2107c 4115 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4116 last portion of handle_display_prop.
4117 (compute_display_string_pos): Accept additional argument
4118 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4119 value of a `display' property is a "replacing spec".
4120 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4121 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4122 the display property, but just return a value indicating whether
4123 the display property will replace the characters it covers.
4124 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4125 frame_window_p members of struct bidi_it.
d6d100dd
SM
4126 (compute_display_string_pos, compute_display_string_end):
4127 New functions.
fec2107c
EZ
4128 (push_it): Accept second argument POSITION, where pop_it should
4129 jump to continue iteration.
4130 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4131
fec2107c
EZ
4132 * keyboard.c (adjust_point_for_property): Adjust the call to
4133 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4134
4135 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4136 (bidi_init_it): Update prototypes.
4137 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4138 (compute_display_string_pos, compute_display_string_end):
4139 Declare prototypes.
fec2107c
EZ
4140 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4141 EMACS_INT.
fc6f18ce 4142
40087514 41432011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4144
57f53182
PE
4145 Malloc failure behavior now depends on size of allocation.
4146 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4147 * lisp.h: Change signatures accordingly.
4148 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4149 All callers changed. (Bug#8762)
4150
4151 * gnutls.c: Use Emacs's memory allocators.
4152 Without this change, the gnutls library would invoke malloc etc.
4153 directly, which causes problems on non-SYNC_INPUT hosts, and which
4154 runs afoul of improving memory_full behavior. (Bug#8761)
4155 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4156 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4157 xfree instead of the default malloc, realloc, free.
4158 (Fgnutls_boot): No need to check for memory allocation failure,
4159 since xmalloc does that for us.
4160
ac32cd99 4161 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4162 * category.c (hash_get_category_set):
4163 * ccl.c (ccl_driver):
4164 * charset.c (Fdefine_charset_internal):
4165 * charset.h (struct charset.hash_index):
4166 * composite.c (get_composition_id, gstring_lookup_cache)
4167 (composition_gstring_put_cache):
4168 * composite.h (struct composition.hash_index):
4169 * dispextern.h (struct image.hash):
4170 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4171 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4172 (hashfn_equal, hashfn_user_defined, make_hash_table)
4173 (maybe_resize_hash_table, hash_lookup, hash_put)
4174 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4175 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4176 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4177 * image.c (make_image, search_image_cache, lookup_image)
4178 (xpm_put_color_table_h):
4179 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4180 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4181 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4182 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4183 * alloc.c (allocate_vectorlike):
4184 Check for overflow in vector size calculations.
4185 * ccl.c (ccl_driver):
4186 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4187 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4188 need to be updated by these changes.
40087514
PE
4189 * fns.c (make_hash_table, maybe_resize_hash_table):
4190 Check for integer overflow with large hash tables.
0de4bb68
PE
4191 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4192 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4193 (SXHASH_REDUCE): New macro.
4194 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4195 Use it instead of discarding useful hash info with large hash values.
4196 (sxhash_float): New function.
4197 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4198 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4199 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4200 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4201 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4202 Adjust signatures to match updated version of code.
4203 (consing_since_gc): Now EMACS_INT, since a single hash table can
4204 use more than INT_MAX bytes.
4205
698d32e2
DN
42062011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4207
4208 Make it possible to build with GCC-4.6+ -O2 -flto.
4209
4210 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4211
fd6fa53f
SM
42122011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4213
4214 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4215 Call minibuffer-inactive-mode.
4216
864db017
JB
42172011-05-31 Juanma Barranquero <lekktu@gmail.com>
4218
4219 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4220 Update dependencies.
4221
2ad0baf4
DN
42222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4223
4224 * data.c (init_data): Remove code for UTS, this system is not
4225 supported anymore.
4226
4fcc2638
DN
42272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4228
4229 Don't force ./temacs to start in terminal mode.
4230
4231 * frame.c (make_initial_frame): Initialize faces in all cases, not
4232 only when CANNOT_DUMP is defined.
4233 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4234
c56e0fd5
DN
42352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4236
4237 * dispnew.c (add_window_display_history): Use const for the string
4238 pointer. Remove declaration, not needed.
4239
333d54da 42402011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4241
55d4c1b2 4242 Use 'inline', not 'INLINE'.
333d54da 4243 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4244 * alloc.c, fontset.c (INLINE): Remove.
4245 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4246 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4247 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4248 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4249 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4250
738db178
DN
42512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4252
4253 Make it possible to run ./temacs.
4254
4255 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4256 syms_of_callproc does the same thing. Remove test for
4257 "initialized", do it in the caller.
4258 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4259
620c53a6
SM
42602011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4261
4262 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4263 (read_minibuf): Use get_minibuffer.
4264 (syms_of_minibuf): Use DEFSYM.
4265 (Qmetadata): New var.
4266 * data.c (Qbuffer): Don't make it static.
4267 (syms_of_data): Use DEFSYM.
4268
e003a292
PE
42692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4270
4271 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4272 (CCL_CODE_MIN): New macro.
4273
ed008a6d
PE
42742011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4275
3687c2ef
PE
4276 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4277
ed008a6d
PE
4278 * eval.c (Qdebug): Now static.
4279 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4280 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4281 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4282
d66c4c7c
CY
42832011-05-29 Chong Yidong <cyd@stupidchicken.com>
4284
4285 * image.c: Various fixes to ImageMagick code comments.
4286 (Fimagemagick_types): Doc fix.
4287
5fbc2025
PE
42882011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4289
0196f88a
PE
4290 Minor fixes prompted by GCC 4.6.0 warnings.
4291
4292 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4293
5fbc2025
PE
4294 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4295 (x_clipboard_manager_save_all): Move extern decl to ...
4296 * xterm.h: ... here, so that it can be checked for consistency.
4297
1dd3c2d9
CY
42982011-05-29 Chong Yidong <cyd@stupidchicken.com>
4299
4300 * xselect.c (x_clipboard_manager_save_frame)
4301 (x_clipboard_manager_save_all): New functions.
4302 (Fx_clipboard_manager_save): Lisp function deleted.
4303
4304 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4305 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4306
4307 * xterm.h: Update prototype.
4308
5ba6571d
WX
43092011-05-28 William Xu <william.xwl@gmail.com>
4310
4311 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4312 exiting (Bug#8239).
4313
3eaff834
JM
43142011-05-28 Jim Meyering <meyering@redhat.com>
4315
e1900994 4316 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4317 * fns.c (to_uchar): Define.
4318 (crypto_hash_function): Use it to convert some newly-signed
4319 variables to unsigned, to avoid sign-extension bugs. For example,
4320 without this change, (md5 "truc") would evaluate to
4321 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4322 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4323 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4324
0f6990a7
PE
43252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4326
4327 Integer overflow fixes.
c8a9ca5a 4328
08686060
PE
4329 * dbusbind.c: Serial number integer overflow fixes.
4330 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4331 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4332 to hold a serial number that is too large for a fixnum.
4333 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4334 Check for serial numbers out of range. Decode any serial number
59568bf0 4335 that was so large that it became a float. (Bug#8722)
08686060 4336
2d1fc3c7
PE
4337 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4338 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4339 Use XFASTINT rather than XUINT when numbers are nonnegative.
4340 (xd_append_arg, Fdbus_method_return_internal):
4341 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4342 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4343 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4344 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4345 (Bug#8722)
2d1fc3c7 4346
c8a9ca5a
PE
4347 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4348
519e1d69
PE
4349 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4350
30569699
PE
4351 ccl: add integer overflow checks
4352 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4353 (IN_INT_RANGE): New macros.
4354 (ccl_driver): Use them to check for integer overflow when
4355 decoding a CCL program. Many of the new checks are whether XINT (x)
4356 fits in int; it doesn't always, on 64-bit hosts. The new version
4357 doesn't catch all possible integer overflows, but it's an
847044ea 4358 improvement. (Bug#8719)
30569699 4359
c11285dc
PE
4360 * alloc.c (make_event_array): Use XINT, not XUINT.
4361 There's no need for unsigned here.
4362
fdccd48e
PE
4363 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4364 This follows up to the 2011-05-06 change that substituted uintptr_t
4365 for EMACS_INT. This case wasn't caught back then.
4366
37910ab2
PE
4367 Rework Fformat to avoid integer overflow issues.
4368 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4369 now (part of C89). Include <verify.h>.
4370 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4371 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4372 (Fformat): Avoid the prepass trying to compute sizes; it was only
4373 approximate and thus did not catch overflow reliably. Instead, walk
4374 through the format just once, formatting and computing sizes as we go,
4375 checking for integer overflow at every step, and allocating a larger
4376 buffer as needed. Keep track separately whether the format is
4377 multibyte. Keep only the most-recently calculated precision, rather
4378 than them all. Record whether each argument has been converted to
4379 string. Use EMACS_INT, not int, for byte and char and arg counts.
4380 Support field widths and precisions larger than INT_MAX. Avoid
4381 sprintf's undefined behavior with conversion specifications such as %#d
4382 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4383 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4384 formatting out-of-range floating point numbers with int
9173deec 4385 formats. (Bug#8668)
37910ab2 4386
2e6578fb
PE
4387 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4388
0ae6bdee
PE
4389 * data.c: Avoid integer truncation in expressions involving floats.
4390 * data.c: Include <intprops.h>.
4391 (arith_driver): When there's an integer overflow in an expression
4392 involving floating point, convert the integers to floating point
4393 so that the resulting value does not suffer from catastrophic
4394 integer truncation. For example, on a 64-bit host (* 4
4395 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4396 Do not rely on undefined behavior after integer overflow.
4397
de883a70
PE
4398 merge count_size_as_multibyte, parse_str_to_multibyte
4399 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4400 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4401 Check for integer overflow.
4402 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4403 since it's now a duplicate of the other. This is more of
4404 a character than a buffer op, so better that it's in character.c.
4405 * fns.c, print.c: Adjust to above changes.
4406
2ff916cb
PE
44072011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4408
4409 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4410
f1b54466
PE
44112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4412
fb1ac845
PE
4413 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4414 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4415 (x_clipboard_manager_save): Now static.
4416 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4417
f1b54466
PE
4418 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4419 (crypto_hash_function): Now static.
4420 Fix pointer signedness problems. Avoid unnecessary initializations.
4421
a9f737ee
CY
44222011-05-27 Chong Yidong <cyd@stupidchicken.com>
4423
4424 * termhooks.h (Vselection_alist): Make it terminal-local.
4425
4426 * terminal.c (create_terminal): Initialize it.
4427
4428 * xselect.c: Support for clipboard managers.
4429 (Vselection_alist): Move to termhooks.h as terminal-local var.
4430 (LOCAL_SELECTION): New macro.
4431 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4432 (symbol_to_x_atom): Remove gratuitous arg.
4433 (x_handle_selection_request, lisp_data_to_selection_data)
4434 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4435 (x_own_selection, x_get_local_selection, x_convert_selection):
4436 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4437 (some_frame_on_display): Delete unused function.
4438 (Fx_own_selection_internal, Fx_get_selection_internal)
4439 (Fx_disown_selection_internal, Fx_selection_owner_p)
4440 (Fx_selection_exists_p): New optional frame arg.
4441 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4442 (x_handle_selection_clear): Don't treat other terminals with the
4443 same keyboard specially. Use the terminal-local Vselection_alist.
4444 (x_clear_frame_selections): Use Frun_hook_with_args.
4445
4446 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4447
4448 * xterm.h: Add support for those atoms.
4449
e067f0c1
CY
44502011-05-26 Chong Yidong <cyd@stupidchicken.com>
4451
4452 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4453 (converted_selections, conversion_fail_tag): New global variables.
4454 (x_selection_request_lisp_error): Free the above.
4455 (x_get_local_selection): Remove unnecessary code.
4456 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4457 of converted selections stored in converted_selections.
4458 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4459 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4460 (x_convert_selection): New function.
4461 (x_handle_selection_event): Simplify.
4462 (x_get_foreign_selection): Don't ignore incoming requests while
4463 waiting for an answer; this will fail when we implement
4464 SAVE_TARGETS, and seems unnecessary anyway.
4465 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4466 (Vx_sent_selection_functions): Doc fix.
4467
0f4aebc0
LL
44682011-05-26 Leo Liu <sdl.web@gmail.com>
4469
4470 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4471
e61124cd
YM
44722011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4473
4474 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4475
4476 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4477 for fringe update if it has periodic bitmap.
ac389d0c 4478 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4479 and fringe_bitmap_periodic_p.
4480
4481 * fringe.c (get_fringe_bitmap_data): New function.
4482 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4483 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4484 row. Mark glyph row for fringe update if periodicity changed.
4485
4486 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4487 for fringe update unless it has periodic bitmap.
4488
f16d9837
KH
44892011-05-25 Kenichi Handa <handa@m17n.org>
4490
4491 * xdisp.c (get_next_display_element): Set correct it->face_id for
4492 a static composition.
4493
e1b90ef6
LL
44942011-05-24 Leo Liu <sdl.web@gmail.com>
4495
4496 * deps.mk (fns.o):
4497 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4498
4499 * fns.c (crypto_hash_function, Fsha1): New function.
4500 (Fmd5): Use crypto_hash_function.
4501 (syms_of_fns): Add Ssha1.
4502
7400048f
PE
45032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4504
4505 * gnutls.c: Remove unused macros.
4506 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4507 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4508 Remove macros that are defined and never used.
4509 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4510
abb71cf4
CY
45112011-05-22 Chong Yidong <cyd@stupidchicken.com>
4512
4513 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4514 (Fx_get_selection_internal): Minor cleanup.
4515 (Fx_own_selection_internal): Rename arguments for consistency with
4516 select.el.
4517
6307db39
PE
45182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4519
4520 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4521
f3d4e0a4
CY
45222011-05-22 Chong Yidong <cyd@stupidchicken.com>
4523
4524 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4525
4d8ade89
YM
45262011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4527
4528 * dispnew.c (scrolling_window): Don't exclude the case that the
4529 last enabled row in the desired matrix touches the bottom boundary.
4530
32078c8d
GM
45312011-05-21 Glenn Morris <rgm@gnu.org>
4532
4533 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4534 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4535 and add some more files.
32078c8d 4536
7285dc67
EZ
45372011-05-20 Eli Zaretskii <eliz@gnu.org>
4538
4539 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4540 report_file_error introduced by the change from 2011-05-07.
4541
89d1bd22
PE
45422011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4543
4544 * systime.h (Time): Define only if emacs is defined.
4545 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4546 where the include path doesn't have X11/X.h by default. See
4547 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4548
e23640bb 45492011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4550
4551 * composite.c (find_automatic_composition): Fix previous change.
4552
b9704ad9
GM
45532011-05-20 Glenn Morris <rgm@gnu.org>
4554
4555 * lisp.mk: New file, split from Makefile.in.
4556 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4557 (shortlisp): Remove.
4558 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4559
4a720484
GM
45602011-05-19 Glenn Morris <rgm@gnu.org>
4561
4562 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4563 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4564 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4565 (lisp): Set the order to that of loadup.el.
4566 (shortlisp): Make it a copy of $lisp.
4567 (SOME_MACHINE_LISP): Remove.
4568 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4569 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4570
a28d4396
KH
45712011-05-18 Kenichi Handa <handa@m17n.org>
4572
4573 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4574 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4575 (find_automatic_composition): Mostly rewrite for efficiency.
4576
a2b1fa8e
JB
45772011-05-18 Juanma Barranquero <lekktu@gmail.com>
4578
4579 * makefile.w32-in: Update dependencies.
4580
8e1f5610
CS
45812011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4582
4583 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4584 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4585
7025ee00 45862011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4587
cdfa6eab
PE
4588 Fix some integer overflow issues, such as string length overflow.
4589
06d6db33
PE
4590 * insdel.c (count_size_as_multibyte): Check for string overflow.
4591
2b4560a8
PE
4592 * character.c (lisp_string_width): Check for string overflow.
4593 Use EMACS_INT, not int, for string indexes and lengths; in
4594 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4595 the resulting string length overflows an EMACS_INT; instead,
4596 report a string overflow if no precision given. When checking for
4597 precision exhaustion, use a check that cannot possibly have
4598 integer overflow. (Bug#8675)
4599 * character.h (lisp_string_width): Adjust to new signature.
4600
cb93f9be
PE
4601 * alloc.c (string_overflow): New function.
4602 (Fmake_string): Use it. This doesn't change behavior, but saves
4603 a few bytes and will simplify future changes.
4604 * character.c (string_escape_byte8): Likewise.
4605 * lisp.h (string_overflow): New decl.
4606
1a1f3366
PE
4607 Fixups, following up to the user-interface timestamp change.
4608 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4609 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4610 * msdos.c (mouse_get_pos): Likewise.
4611 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4612 * w32gui.h (Time): Define by including "systime.h" rather than by
4613 declaring it ourselves. (Bug#8664)
4614
d4e3e4d3
PE
4615 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4616 * image.c (clear_image_cache): Likewise.
4617
f6a24d19
PE
4618 * term.c (term_mouse_position): Don't assume time_t wraparound.
4619
08dc5ae6
PE
4620 Be more systematic about user-interface timestamps.
4621 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4622 and sometimes 'EMACS_UINT', to represent these timestamps.
4623 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4624 This makes the code easier to follow, and makes it easier to catch
4625 integer overflow bugs such as Bug#8664.
4626 * frame.c (Fmouse_position, Fmouse_pixel_position):
4627 Use Time, not unsigned long, for user-interface timestamps.
4628 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4629 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4630 * keyboard.h (last_event_timestamp): Likewise.
4631 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4632 * menu.h (xmenu_show): Likewise.
4633 * term.c (term_mouse_position): Likewise.
4634 * termhooks.h (struct input_event.timestamp): Likewise.
4635 (struct terminal.mouse_position_hook): Likewise.
4636 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4637 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4638 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4639 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4640 what it was before.
4641 * menu.h, termhooks.h: Include "systime.h", for Time.
4642
8e55734a
PE
4643 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4644 Don't assume that the difference between two unsigned long values
4645 can fit into an integer. At this point, we know button_down_time
4646 <= event->timestamp, so the difference must be nonnegative, so
4647 there's no need to cast the result if double-click-time is
4648 nonnegative, as it should be; check that it's nonnegative, just in
4649 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4650 apart (about 25 days). (Bug#8664)
8e55734a 4651
841f1b75 4652 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4653 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4654
3e26f69c
PE
4655 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4656 that always fit in int. Use a sentinel instead of a counter, to
4657 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4658 * frame.h (struct frame): Use int for menu_bar_items_used
4659 instead of EMACS_INT, since it always fits in int.
3e26f69c 4660
5cc152c0
PE
4661 * menu.c (grow_menu_items): Check for int overflow.
4662
d89eb65e
PE
4663 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4664
5235bd3e
PE
4665 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4666 Before, the code was not consistent. These values cannot exceed
4667 2**31 - 1 so there's no need to make them unsigned.
4668 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4669 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4670 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4671 as modifiers.
4672 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4673
bc827e23
PE
4674 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4675 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4676 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4677 presumably because the widths might not match.
4678
78eb494e
PE
4679 * window.c (size_window): Avoid needless test at loop start.
4680
04f2d78b
CB
46812011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4682
4683 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4684
d2fc7e3d 46852011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4686
4687 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4688
d2fc7e3d 46892011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4690
4691 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4692 `width' to `bar_area_x' and `bar_area_width', respectively.
4693 (x_scroll_run): Take account of fringe background extension.
4694
04f2d78b
CB
4695 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4696 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4697 `bar_area_width', respectively.
4698 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4699 background extension.
4700
79b70037
GM
47012011-05-10 Jim Meyering <meyering@redhat.com>
4702
4703 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4704
2f142cc5
JB
47052011-05-10 Juanma Barranquero <lekktu@gmail.com>
4706
4707 * image.c (Finit_image_library): Return t for built-in image types,
4708 like pbm and xbm. (Bug#8640)
4709
57679c86
AS
47102011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4711
4712 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4713
888c9e86
EZ
47142011-05-07 Eli Zaretskii <eliz@gnu.org>
4715
b0512a1d
EZ
4716 * w32console.c (Fset_screen_color): Doc fix.
4717 (Fget_screen_color): New function.
4718 (syms_of_ntterm): Defsubr it.
4719
7285dc67
EZ
4720 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4721 unlink the temporary file if Fcall_process didn't create it in the
4722 first place.
4723 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4724 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4725 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4726 cue to call_process_cleanup not to close that handle.
4727
4d3fcc8e
BK
47282011-05-07 Ben Key <bkey76@gmail.com>
4729
4730 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4731 one of two shell specific rules, either bootstrap-temacs-CMD or
4732 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4733 to the previous implementation of the bootstrap-temacs rule.
4734 The bootstrap-temacs-CMD rule is similar to the previous
4735 implementation of the bootstrap-temacs rule except that it
4736 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4737 variable.
4738
4739 These changes, along with some changes to nt/configure.bat,
4740 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4741 earlier fix to add support for --cflags and --ldflags options
4742 that include quotes so that it works whether make uses cmd or
4743 sh as the shell.
4744
b4289b64
MA
47452011-05-06 Michael Albinus <michael.albinus@gmx.de>
4746
4747 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4748 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4749 is a constant.
4750 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4751 a string. Handle both cases.
4752 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4753 (Fdbus_register_method): Use Qinvalid_function.
4754
af4c0e28
JB
47552011-05-06 Juanma Barranquero <lekktu@gmail.com>
4756
4757 * makefile.w32-in: Update dependencies.
4758 (LISP_H): Add inttypes.h and stdin.h.
4759 (PROCESS_H): Add unistd.h.
4760
c51453d9
EZ
47612011-05-06 Eli Zaretskii <eliz@gnu.org>
4762
4763 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4764 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4765
8ff0ac3c 47662011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4767
4c4b566b
PE
4768 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4769
aab2b9b5
PE
4770 * term.c (vfatal): Remove stray call to va_end.
4771 It's not needed and the C Standard doesn't allow it here anyway.
4772
c378da0b
PE
4773 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4774 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4775
288b08c7
PE
4776 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4777 bytes.
4778
e3601888
PE
4779 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4780
db6c0e74
PE
4781 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4782
dd5963ea
PE
4783 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4784
88c9450f
PE
4785 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4786
2f9442b8
PE
4787 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4788
c032b5f8
PE
4789 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4790 * charset.c (Fdefine_charset_internal): Don't initialize
4791 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4792 32-bit int (Bug#8600).
a108c10b
PE
4793
4794 * lread.c (read_integer): Be more consistent with string-to-number.
4795 Use string_to_number to do the actual conversion; this avoids
4796 rounding errors and fixes some other screwups. Without this fix,
4797 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4798 (digit_to_number): Move earlier, for benefit of read_integer.
4799 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4800 not a digit in any supported base. (Bug#8602)
a108c10b 4801
ad5f9eea
PE
4802 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4803
aec1708a
PE
4804 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4805 to match comment at start of function. This also removes a
4806 GCC warning about overflow in a 32+64-bit port.
4807
47be4ab5
PE
4808 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4809
371cac43
PE
4810 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4811 Reported by Stefan Monnier in
4812 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4813 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4814 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4815
d01a7826
PE
4816 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4817 (EMACS_UINTPTR): Likewise, with uintptr_t.
4818
7fd47d5c
PE
4819 * lisp.h: Prefer 64-bit EMACS_INT if available.
4820 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4821 on 32-bit hosts that have 64-bit int, so that they can access
4822 large files.
122b0c86
PE
4823 However, temporarily disable this change unless the temporary
4824 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4825
8727937b
PE
4826 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4827
8ac068ac
PE
4828 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4829 This removes an assumption that EMACS_INT and long are the same
4830 width as pointers. The assumption is true for Emacs porting targets
4831 now, but we want to make other targets possible.
4832 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4833 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4834 In the rest of the code, change types of integers that hold casted
4835 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4836 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4837 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4838 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4839 No need to cast type when ORing.
4840 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4841 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4842 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4843 assume EMACS_INT is the same width as char *.
4844 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4845 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4846 Remove no-longer-needed casts.
4847 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4848 (xg_tool_bar_help_callback, xg_make_tool_item):
4849 Use EMACS_INTPTR to hold an integer
4850 that will be cast to void *; this can avoid a GCC warning
4851 if EMACS_INT is not the same width as void *.
4852 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4853 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4854 (current_message_1, set_message_1):
4855 Use a local to convert to proper width without a cast.
4856 * xmenu.c (dialog_selection_callback): Likewise.
4857
ede49d71
PE
4858 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4859 Also, don't assume VALBITS / RAND_BITS is less than 5,
4860 and don't rely on undefined behavior when shifting a 1 left into
4861 the sign bit.
4862 * lisp.h (get_random): Change signature to match.
4863
2f30ecd0
PE
4864 * lread.c (hash_string): Use size_t, not int, for hash computation.
4865 Normally we prefer signed values; but hashing is special, because
4866 it's better to use unsigned division on hash table sizes so that
4867 the remainder is nonnegative. Also, size_t is the natural width
4868 for hashing into memory. The previous code used 'int', which doesn't
4869 retain enough info to hash well into very large tables.
4870 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4871
2a866e7b
PE
4872 * dbusbind.c: Don't possibly lose pointer info when converting.
4873 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4874 Use XPNTR rather than XHASH, so that the high-order bits of
4875 the pointer aren't lost when converting through void *.
4876
51639eac
PE
4877 * eval.c (Fautoload): Don't double-shift a pointer.
4878
92394119
PE
4879 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4880
dbdb9a7c
JB
48812011-05-06 Juanma Barranquero <lekktu@gmail.com>
4882
4883 * gnutls.c (DEF_GNUTLS_FN):
4884 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4885
db7a0b4f
AS
48862011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4887
4888 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4889 marker. (Bug#8610)
4890
f7ff1b0f 48912011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4892
4893 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4894 New version that can reserve upto 2GB of heap space.
4895
f7ff1b0f 48962011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4897
4898 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4899
639c109b
TZ
49002011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4901
4902 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4903 `gnutls_certificate_set_x509_key_file'.
4904
d2127135
JB
49052011-05-05 Juanma Barranquero <lekktu@gmail.com>
4906
4907 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4908 Update dependencies.
4909
e968f4f3
JB
49102011-05-04 Juanma Barranquero <lekktu@gmail.com>
4911
4912 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4913 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4914 Remove unused parameter `fildes'.
4915 * process.c (read_process_output, send_process): Don't pass it.
4916
84d358f0
JB
49172011-05-04 Juanma Barranquero <lekktu@gmail.com>
4918
4919 Fix previous change: the library cache is defined in w32.c.
4920 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4921 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4922
0898ca10
JB
49232011-05-04 Juanma Barranquero <lekktu@gmail.com>
4924
4925 Implement dynamic loading of GnuTLS on Windows.
4926
4927 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4928 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4929 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4930 Declare.
4931
4932 * gnutls.c (Qgnutls_dll): Define.
4933 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4934 (gnutls_*): Declare function pointers.
4935 (init_gnutls_functions): New function to initialize function pointers.
4936 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4937 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4938 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4939 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4940 (emacs_gnutls_write, emacs_gnutls_read)
4941 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4942 (Fgnutls_available_p): New function.
4943 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4944 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4945 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4946
4947 * image.c: Include w32.h.
4948 (Vimage_type_cache): Delete.
4949 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4950 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4951 (w32_delayed_load): Move to w32.c.
4952
4953 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4954
4955 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4956 (w32_delayed_load): Move from image.c. When loading a library, record
4957 its filename in the :loaded-from property of the library id.
4958 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4959 Initialize and staticpro them.
4960 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4961
4962 * process.c: Include lisp.h before w32.h, not after.
4963 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4964 instead of gnutls_record_check_pending.
4965
4966 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4967
ff4de4aa
TZ
49682011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4969
4970 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4971 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4972 as passed in.
4973
abe95abb
JD
49742011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4975
4976 * xterm.c (x_set_frame_alpha): Do not set property on anything
4977 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4978
e16e55d4
JB
49792011-05-02 Juanma Barranquero <lekktu@gmail.com>
4980
4981 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4982
bafcf6a5
JB
49832011-05-02 Juanma Barranquero <lekktu@gmail.com>
4984
4985 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4986 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4987 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4988 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4989 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4990 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4991 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4992 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4993 (Qgnutls_bootprop_callbacks_verify): Make static.
4994
e7a6747f
AS
49952011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4996
19ed11ba
AS
4997 * callproc.c: Indentation fixup.
4998
e7a6747f 4999 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5000 (wait_for_termination, interruptible_wait_for_termination):
5001 Move after wait_for_termination_1.
e7a6747f 5002
1ef14cb4
LMI
50032011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5004
5005 * sysdep.c (interruptible_wait_for_termination): New function
5006 which is like wait_for_termination, but allows keyboard
5007 interruptions.
5008
5009 * callproc.c (Fcall_process): Add (:file "file") as an option for
5010 the STDOUT buffer.
5011 (Fcall_process_region): Ditto.
5012
330d880c
EZ
50132011-04-30 Eli Zaretskii <eliz@gnu.org>
5014
8db90b73
EZ
5015 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5016 rather than `XVECTOR (FOO)->size'.
5017
330d880c
EZ
5018 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5019 inttypes.h, as a gnulib replacement is used if it not available in
5020 system headers.
5021
15cbd324
EZ
50222011-04-21 Eli Zaretskii <eliz@gnu.org>
5023
5024 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5025 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5026 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5027
5028 * coding.c (coding_alloc_by_realloc): Error out if destination
5029 will grow beyond MOST_POSITIVE_FIXNUM.
5030 (decode_coding_emacs_mule): Abort if there isn't enough place in
5031 charbuf for the composition carryover bytes. Reserve an extra
5032 space for up to 2 characters produced in a loop.
5033 (decode_coding_iso_2022): Abort if there isn't enough place in
5034 charbuf for the composition carryover bytes.
5035
50362011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5037
ae940cca
EZ
5038 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5039 aborting when %lld or %lll format is passed.
5040 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5041 %llo or %llx format is passed. (Bug#8545)
5042
03ab8921
EZ
5043 * window.c (window_scroll_line_based): Use a marker instead of
5044 simple variables to record original value of point. (Bug#7952)
5045
afda1437
EZ
5046 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5047 produced by %s or %c overflows available buffer space. (Bug#8545)
5048
f76dee0c
PE
50492011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5050
5051 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5052 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5053
fdc5744d
JB
50542011-04-28 Juanma Barranquero <lekktu@gmail.com>
5055
5056 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5057
638f053a
JB
50582011-04-28 Juanma Barranquero <lekktu@gmail.com>
5059
5060 * keyboard.c (Qdelayed_warnings_hook): Define.
5061 (command_loop_1): Run `delayed-warnings-hook'
5062 if Vdelayed_warnings_list is non-nil.
5063 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5064 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5065
d178f871
EZ
50662011-04-28 Eli Zaretskii <eliz@gnu.org>
5067
5068 * doprnt.c (doprnt): Don't return value smaller than the buffer
5069 size if the message was truncated. (Bug#8545).
5070
b124fd93
JB
50712011-04-28 Juanma Barranquero <lekktu@gmail.com>
5072
5073 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5074 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5075
e810457d
PE
50762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5077
5078 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5079
ea51cceb
JB
50802011-04-27 Juanma Barranquero <lekktu@gmail.com>
5081
5082 * makefile.w32-in: Update dependencies.
5083
94dcfacf
EZ
50842011-04-27 Eli Zaretskii <eliz@gnu.org>
5085
5086 Improve `doprnt' and its usage. (Bug#8545)
5087 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5088 `format_end'. Remove support for %l as a conversion specifier.
5089 Don't use xrealloc. Improve diagnostics when the %l size modifier
5090 is used. Update the commentary.
5091
5092 * eval.c (verror): Simplify calculation of size_t.
5093
5094 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5095 messages.
5096
f61f41d7
PE
50972011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5098
5099 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5100 change.
5101
96fb4434
PE
51022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5103
5104 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5105 This makes this file independent of the recent pseudovector change.
5106
671875da 51072011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5108
69e9b5a3
PE
5109 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5110
b5f869a7 5111 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5112 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5113 Remove unused local.
c8926152 5114 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5115
841a1577 5116 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5117 GCC 4.6.0 optimizes based on type-based alias analysis.
5118 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5119 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5120 != &v->size, and therefore "v->size = 1; b->size = 2; return
5121 v->size;" must therefore return 1. This assumption is incorrect
5122 for Emacs, since it type-puns struct Lisp_Vector * with many other
5123 types. To fix this problem, this patch adds a new type struct
f904488f 5124 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5125 and pseudovectors, and helps optimizing compilers not get fooled
5126 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5127 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5128 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5129 the size member.
eab3844f
PE
5130 (XSETPVECTYPE): Rewrite in terms of new macro.
5131 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5132 This is a bit clearer, and further avoids the possibility of
5133 undesirable aliasing.
5134 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5135 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5136 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5137 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5138 (ASIZE): Now uses header.size rather than size.
5139 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5140 to avoid the hassle of writing XVECTOR (foo)->header.size.
5141 (struct vectorlike_header): New type.
eab3844f
PE
5142 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5143 object, to help avoid aliasing.
5144 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5145 (SUBRP): Likewise, since Lisp_Subr is a special case.
5146 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5147 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5148 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5149 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5150 changed to be "header.size" and "header.next".
5151 * buffer.h (struct buffer): Likewise.
5152 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5153 * frame.h (struct frame): Likewise.
5154 * process.h (struct Lisp_Process): Likewise.
5155 * termhooks.h (struct terminal): Likewise.
5156 * window.c (struct save_window_data, struct saved_window): Likewise.
5157 * window.h (struct window): Likewise.
5158 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5159 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5160 * buffer.c (init_buffer_once): Likewise.
5161 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5162 special case.
5163 * process.c (Fformat_network_address): Use local var for size,
5164 for brevity.
5165
0df1eac5
PE
5166 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5167
847ab9d1 5168 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5169 * data.c (atof): Remove decl; no longer used or needed.
5170 (digit_to_number): Move to lread.c.
5171 (Fstring_to_number): Use new string_to_number function, to be
5172 consistent with how the Lisp reader treats infinities and NaNs.
5173 Do not assume that floating-point numbers represent EMACS_INT
5174 without losing information; this is not true on most 64-bit hosts.
5175 Avoid double-rounding errors, by insisting on integers when
5176 parsing non-base-10 numbers, as the documentation specifies.
5177 * lisp.h (string_to_number): New decl, replacing ...
5178 (isfloat_string): Remove.
bc0a5c13 5179 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5180 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5181 appears to have been a coding error. Similarly, do not accept
5182 strings like +-1e0 as floating point numbers. Do not report
5183 overflow for integer overflows unless the base is not 10 which
5184 means we have no simple and reliable way to continue.
5185 Break out the floating-point parsing into a new
5186 function string_to_number, so that Fstring_to_number parses
5187 floating point numbers consistently with the Lisp reader.
04f2d78b 5188 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5189 (E_CHAR, EXP_INT): Remove, replacing with ...
5190 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5191 (string_to_number): New function, replacing isfloat_string.
5192 This function checks for valid syntax and produces the resulting
5193 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5194 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5195 so that overflow for non-base-10 numbers is reported only when
5196 there's no portable and simple way to convert to floating point.
452f4150 5197
67769ffc
PE
5198 * textprop.c (set_text_properties_1): Rewrite for clarity,
5199 and to avoid GCC warning about integer overflow.
5200
c20db43f
PE
5201 * intervals.h (struct interval): Use EMACS_INT for members
5202 where EMACS_UINT might cause problems. See
5203 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5204 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5205 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5206 All uses changed.
37aa2f85
PE
5207 (offset_intervals): Tell GCC not to worry about length overflow
5208 when negating a negative length.
c20db43f 5209
2538aa2f
PE
5210 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5211 (overrun_check_free): Likewise.
5212
f2d3008d
PE
5213 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5214 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5215 word size.
5216
ec8df744
PE
5217 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5218 (gnutls_make_error): Rename local to avoid shadowing.
5219 (gnutls_emacs_global_deinit): ifdef out; not used.
5220 (Fgnutls_boot): Use const for pointer to readonly storage.
5221 Comment out unused local. Fix pointer signedness problems.
5222
640ee02d
PE
5223 * lread.c (openp): Don't stuff size_t into an 'int'.
5224 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5225 about possible signed overflow.
5226
6048fb2a
PE
5227 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5228 (GDK_KEY_g): Don't define if already defined.
5229 (xg_prepare_tooltip): Avoid pointer signedness problem.
5230 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5231
fa3c87e1
PE
5232 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5233 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5234
2172544b
PE
5235 * xfns.c (Fx_window_property): Simplify a bit,
5236 to make a bit faster and to avoid GCC 4.6.0 warning.
5237 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5238
9b821a21
PE
5239 * fns.c (internal_equal): Don't assume size_t fits in int.
5240
3c616cfa
PE
5241 * alloc.c (compact_small_strings): Tighten assertion a little.
5242
c2982e87
PE
5243 Replace pEd with more-general pI, and fix some printf arg casts.
5244 * lisp.h (pI): New macro, generalizing old pEd macro to other
5245 conversion specifiers. For example, use "...%"pI"d..." rather
5246 than "...%"pEd"...".
5247 (pEd): Remove. All uses replaced with similar uses of pI.
5248 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5249 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5250 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5251 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5252 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5253 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5254 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5255 64-bit hosts.
5256 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5257 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5258 * print.c (safe_debug_print, print_object): Likewise.
5259 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5260 to int.
6f04d126
PE
5261 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5262 avoiding the 0 flag, which is not portable.
c2982e87
PE
5263 * process.c (Fmake_network_process): Use pI to avoid cast.
5264 * region-cache.c (pp_cache): Likewise.
5265 * xdisp.c (decode_mode_spec): Likewise.
5266 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5267 behavior on 64-bit hosts with printf arg.
6f04d126 5268 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5269 (x_stop_queuing_selection_requests): Likewise.
5270 (x_get_window_property): Don't truncate byte count to an 'int'
5271 when tracing.
0b432f21 5272
5e073ec7
PE
5273 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5274 here, since it parses constructs like leading '-' and spaces,
5275 which are not wanted; and it overflows with large numbers.
5276 Instead, simply match F[0-9]+, which is what is wanted anyway.
5277
36372bf9
PE
5278 * alloc.c: Remove unportable assumptions about struct layout.
5279 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5280 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5281 (allocate_vectorlike, make_pure_vector): Use the new macros,
5282 plus offsetof, to remove unportable assumptions about struct layout.
5283 These assumptions hold on all porting targets that I know of, but
5284 they are not guaranteed, they're easy to remove, and removing them
5285 makes further changes easier.
5286
0b432f21
PE
5287 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5288 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5289 (string_overrun_cookie): Now const. Use initializers that
5290 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5291 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5292 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5293 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5294 multiple of sizeof (EMACS_INT); it need not be, if
5295 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5296 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5297
895009e1
JB
52982011-04-26 Juanma Barranquero <lekktu@gmail.com>
5299
5300 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5301
6a7a1b0b
TZ
53022011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5303
5304 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5305 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5306 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5307
841a1577 53082011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5309
5310 * lisp.h (Qdebug): List symbol.
895009e1 5311 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5312 * keyboard.c (debug-on-event): New variable.
5313 (handle_user_signal): Break into debugger when debug-on-event
5314 matches the current signal symbol.
5315
f2d3ba6f
DN
53162011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5317
5318 * alloc.c (check_sblock, check_string_bytes)
5319 (check_string_free_list): Convert to standard C.
5320
42ce4c63
TZ
53212011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5322
5323 * w32.c (emacs_gnutls_push): Fix typo.
5324
825cd63c
EZ
53252011-04-25 Eli Zaretskii <eliz@gnu.org>
5326
fb11d64d
EZ
5327 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5328 "cast to pointer from integer of different size".
5329
825cd63c
EZ
5330 Improve doprnt and its use in verror. (Bug#8545)
5331 * doprnt.c (doprnt): Document the set of format control sequences
5332 supported by the function. Use SAFE_ALLOCA instead of always
5333 using `alloca'.
5334
5335 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5336 is one byte too soon. Don't use xrealloc; instead xfree and
5337 xmalloc anew.
5338
e061a11b
TZ
53392011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5340
5341 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5342 callbacks stage.
5343
5344 * gnutls.c: Renamed global_initialized to
5345 gnutls_global_initialized. Added internals for the
5346 :verify-hostname-error, :verify-error, and :verify-flags
5347 parameters of `gnutls-boot' and documented those parameters in the
5348 docstring. Start callback support.
9173deec
JB
5349 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5350 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5351 on error. Return error code.
e061a11b
TZ
5352 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5353 (emacs_gnutls_read): Likewise.
5354 (Fgnutls_boot): Return handshake error code.
5355 (emacs_gnutls_handle_error): New function.
5356 (wsaerror_to_errno): Likewise.
5357
5358 * w32.h (emacs_gnutls_pull): Add prototype.
5359 (emacs_gnutls_push): Likewise.
5360
5361 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5362 (emacs_gnutls_push): Likewise.
5363
53642011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5365
5366 * process.c (wait_reading_process_output): Check if GnuTLS
5367 buffered some data internally if no FDs are set for TLS
5368 connections.
5369
5370 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5371 (LIBS): Link to USER_LIBS.
5372 ($(BLD)/gnutls.$(0)): New target.
5373
fa6996bc
EZ
53742011-04-24 Eli Zaretskii <eliz@gnu.org>
5375
eb35682e
EZ
5376 * xdisp.c (handle_single_display_spec): Rename the
5377 display_replaced_before_p argument into display_replaced_p, to
5378 make it consistent with the commentary. Fix typos in the
5379 commentary.
5380
e2ad650c
EZ
5381 * textprop.c (syms_of_textprop): Remove dead code.
5382 (copy_text_properties): Delete obsolete commentary about an
5383 interface that was deleted long ago. Fix typos in the description
5384 of arguments.
5385
1b2de274
EZ
5386 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5387 to changes in oldXMenu/XMenu.h from 2011-04-16.
5388 <menu_help_message, prev_menu_help_message>: Constify.
5389 (IT_menu_make_room): menu->help_text is now `const char **';
5390 adjust.
5391
5392 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5393 to changes in oldXMenu/XMenu.h from 2011-04-16.
5394 (struct XMenu): Declare `help_text' `const char **'.
5395
5396 * xfaces.c <Qunspecified>: Make extern again.
5397
5398 * syntax.c: Include sys/types.h before including regex.h, as
5399 required by Posix.
5400
762b15be
EZ
5401 * doc.c (get_doc_string): Improve the format passed to `error'.
5402
5403 * doprnt.c (doprnt): Improve commentary.
5404
5405 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5406
5407 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5408 them with etags.
5409
f1052e5d
EZ
5410 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5411 changes in globals.h immediately force recompilation.
762b15be
EZ
5412 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5413 $(CURDIR)/s/ms-w32.h.
5414 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5415
fa6996bc
EZ
5416 * character.c (Fchar_direction): Function deleted.
5417 (syms_of_character): Don't defsubr it.
5418 <char-direction-table>: Deleted.
5419
e6c3da20
EZ
54202011-04-23 Eli Zaretskii <eliz@gnu.org>
5421
5422 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5423 * doprnt.c: Include limits.h.
5424 (SIZE_MAX): New macro.
04f2d78b
CB
5425 (doprnt): Return a size_t value. 2nd arg is now size_t.
5426 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5427 Improve overflow protection. Support `l' modifier for integer
5428 conversions. Support %l conversion. Don't assume an EMACS_INT
5429 argument for integer conversions and for %c.
5430
5431 * lisp.h (doprnt): Restore prototype.
5432
5433 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5434 $(SRC)/character.h.
5435
5436 * Makefile.in (base_obj): Add back doprnt.o.
5437
5438 * deps.mk (doprnt.o): Add back prerequisites.
5439 (callint.o): Depend on character.h.
5440
5441 * eval.c (internal_lisp_condition_case): Include the handler
5442 representation in the error message.
5443 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5444 when breaking from the loop.
5445
5446 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5447
5448 * callint.c (Fcall_interactively): When displaying error message
5449 about invalid control letter, pass the character's codepoint, not
5450 a pointer to its multibyte form. Improve display of the character
5451 in octal and display also its hex code.
5452
5453 * character.c (char_string): Use %x to display the (unsigned)
5454 codepoint of an invalid character, to avoid displaying a bogus
5455 negative value.
5456
5457 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5458 `error', not SYMBOL_NAME itself.
5459
5460 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5461 character arguments to `error'.
5462
5463 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5464 to `error' in error message about FINAL_CHAR argument. Make sure
5465 FINAL_CHAR is a character, and use %c when it is passed as
5466 argument to `error'.
5467
4ffd0d6b 54682011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5469
5470 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5471
5472 * w32.c: Include <time.h>.
5473 (sys_localtime): New function.
5474
4ffd0d6b 54752011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5476
5477 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5478
4ffd0d6b 5479 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5480
4ffd0d6b 54812011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5482
4ffd0d6b
GM
5483 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5484 zombies (Bug#8467).
aac0c6e3 5485
04c56954
EZ
54862011-04-19 Eli Zaretskii <eliz@gnu.org>
5487
5488 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5489 gl_state.e_property when gl_state.object is Qt.
5490
5491 * insdel.c (make_gap_larger): Remove limitation of buffer size
5492 to <= INT_MAX.
5493
16a43933
CY
54942011-04-18 Chong Yidong <cyd@stupidchicken.com>
5495
5496 * xdisp.c (lookup_glyphless_char_display)
5497 (produce_glyphless_glyph): Handle cons cell entry in
5498 glyphless-char-display.
5499 (Vglyphless_char_display): Document it.
5500
5501 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5502 glyphless-char-display.
5503
4581706e
CY
55042011-04-17 Chong Yidong <cyd@stupidchicken.com>
5505
5506 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5507
5508 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5509
5510 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5511 definition for no-X builds.
5512
4887c6e2 55132011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5514
fd35b6f9
PE
5515 Static checks with GCC 4.6.0 and non-default toolkits.
5516
5c1ccb01
PE
5517 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5518
006c5daa
PE
5519 * process.c (keyboard_bit_set): Define only if SIGIO.
5520 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5521 (send_process): Repair possible setjmp clobbering.
5522
efc736d3
PE
5523 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5524
4e2fe2e6
PE
5525 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5526
f97334a2
PE
5527 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5528
4e75f29d
PE
5529 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5530 Define only if needed.
5531
90efadd1
PE
5532 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5533 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5534 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5535
3c647824
PE
5536 * dispextern.h (struct redisplay_interface): Rename param
5537 to avoid shadowing.
e264f262 5538 * termhooks.h (struct terminal): Likewise.
761383f4 5539 * xterm.c (xembed_send_message): Likewise.
3c647824 5540
b58c5c4a
PE
5541 * insdel.c (make_gap_smaller): Define only if
5542 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5543
cad59032
PE
5544 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5545 it.
5546
c339dc2e
PE
5547 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5548 so that we aren't warned about unused symbols.
5549
91a3e27b
PE
5550 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5551
399c71d3 5552 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5553
8ffc96f5
PE
5554 * xfns.c (x_real_positions): Mark locals as initialized.
5555
eef9bc79
PE
5556 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5557
098db9dd
PE
5558 * xterm.c: Fix problems found by static analysis with other toolkits.
5559 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5560 (x_dispatch_event): Declare static if USE_GTK, and
5561 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5562 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5563 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5564 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5565 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5566
eb18f6cc
PE
5567 * xmenu.c (menu_help_callback): Pointer type fixes.
5568 Use const pointers when pointing at readonly data. Avoid pointer
5569 signedness clashes.
5570 (FALSE): Remove unused macro.
5571 (update_frame_menubar): Remove unused decl.
5572
1fe72bf8
PE
5573 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5574
60d9e1db
PE
5575 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5576 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5577 (single_menu_item): Rename local to avoid shadowing.
5578
39261c26
PE
5579 * keyboard.c (make_lispy_event): Remove unused local var.
5580
018c5e19
PE
5581 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5582 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5583
63d2b86e
PE
5584 * bitmaps: Change bitmaps from unsigned char back to the X11
5585 compatible char. Avoid the old compiler warnings about
5586 out-of-range initializers by using, for example, '\xab' rather
5587 than 0xab.
5588
aefd87e1
PE
5589 * xgselect.c (xgselect_initialize): Check vs interface
5590 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5591
bf501fb9
PE
5592 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5593
e9829fdf
PE
5594 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5595 to read-only memory.
5596
1086c095
PE
5597 * fns.c (vector): Remove; this old hack is no longer needed.
5598
2baccd04 5599 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5600 Remove unused var.
dde42981 5601 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5602
72391843 5603 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5604
436c16df 5605 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5606 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5607 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5608
92bb796d 5609 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5610 (x_term_init): Remove local to avoid shadowing.
92bb796d 5611
764430a3 5612 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5613
5614 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5615 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5616
d1dfb56c
EZ
56172011-04-16 Eli Zaretskii <eliz@gnu.org>
5618
c4354cb4
EZ
5619 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5620
d1dfb56c
EZ
5621 Fix regex.c, syntax.c and friends for buffers > 2GB.
5622 * syntax.h (struct gl_state_s): Declare character position members
5623 EMACS_INT.
5624
5625 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5626
04f2d78b
CB
5627 * textprop.c (verify_interval_modification, interval_of):
5628 Declare arguments EMACS_INT.
d1dfb56c
EZ
5629
5630 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5631 EMACS_INT.
5632
5633 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5634
5635 * indent.c (Fvertical_motion): Local variable it_start is now
5636 EMACS_INT.
5637
5638 * regex.c (re_match, re_match_2, re_match_2_internal)
5639 (bcmp_translate, regcomp, regexec, print_double_string)
5640 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5641 (re_compile_pattern, re_exec): Declare arguments and local
5642 variables `size_t' and `ssize_t' and return values `regoff_t', as
5643 appropriate.
5644 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5645 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5646 <compile_stack_type>: `size' and `avail' are now `size_t'.
5647
5648 * regex.h <regoff_t>: Use ssize_t, not int.
5649 (re_search, re_search_2, re_match, re_match_2): Arguments that
5650 specify buffer/string position and length are now ssize_t and
5651 size_t. Return type is regoff_t.
5652
613052cd
BK
56532011-04-16 Ben Key <bkey76@gmail.com>
5654
5655 * nsfont.m: Fixed bugs in ns_get_family and
5656 ns_descriptor_to_entity that were caused by using free to
5657 deallocate memory blocks that were allocated by xmalloc (via
5658 xstrdup). This caused Emacs to crash when compiled with
5659 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5660 --enable-checking=xmallocoverrun). xfree is now used to
5661 deallocate these memory blocks.
5662
4170f62f 56632011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5664
71b41406
PE
5665 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5666
9587a89d
PE
5667 emacs_write: Accept and return EMACS_INT for sizes.
5668 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5669 et seq.
5670 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5671 Accept and return EMACS_INT.
5672 (emacs_gnutls_write): Return the number of bytes written on
5673 partial writes.
5674 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5675 (emacs_read, emacs_write): Remove check for negative size, as the
5676 Emacs source code has been audited now.
9587a89d
PE
5677 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5678 (emacs_read, emacs_write): Use it.
273a5f82
PE
5679 * process.c (send_process): Adjust to the new signatures of
5680 emacs_write and emacs_gnutls_write. Do not attempt to store
5681 a byte offset into an 'int'; it might overflow.
9587a89d 5682 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5683
3e047f51
PE
5684 * sound.c: Don't assume sizes fit in 'int'.
5685 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5686 Return EMACS_INT, not int.
3e047f51 5687 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5688 Accept EMACS_INT, not int.
5689 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5690 record read return values.
5691
cc39a9db
BK
56922011-04-15 Ben Key <bkey76@gmail.com>
5693
c9d0ec6d
JB
5694 * keyboard.c (Qundefined): Don't declare static since it is used
5695 in nsfns.m.
5696 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5697 static since they are used in nsfont.m.
cc39a9db 5698
6c60eb9f
SM
56992011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5700
5701 * process.c (Qprocessp): Don't declare static.
5702 * lisp.h (Qprocessp): Declare again.
5703
7990b61a
JB
57042011-04-15 Juanma Barranquero <lekktu@gmail.com>
5705
5706 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5707
5d4cb038
PE
57082011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5709
8bd7b830 5710 Improve C-level modularity by making more things 'static'.
cd64ea1d 5711
e3b27b31
PE
5712 Don't publish debugger-only interfaces to other modules.
5713 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5714 (verify_bytepos, count_markers): Move decls to the only modules
5715 that need them.
5716 * region-cache.h (pp_cache): Likewise.
5717 * window.h (check_all_windows): Likewise.
5718 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5719
5d4cb038
PE
5720 * sysdep.c (croak): Now static, if
5721 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5722 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5723
5724 * alloc.c (refill_memory_reserve): Now static if
5725 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5726 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5727
e87b6180
PE
5728 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5729 Define only if USE_LUCID.
5730
ac64929e
PE
5731 * xrdb.c (x_customization_string, x_rm_string): Now static.
5732
6f37259d
PE
5733 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5734 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5735
1683e3ab
PE
5736 * xdisp.c (draw_row_with_mouse_face): Now static.
5737 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5738
de9c2632
PE
5739 * window.h (check_all_windows): Mark externally visible.
5740
2b96acb7
PE
5741 * window.c (window_deletion_count): Now static.
5742
5743 * undo.c: Make symbols static if they're not exported.
5744 (last_undo_buffer, last_boundary_position, pending_boundary):
5745 Now static.
5746
50436f33
PE
5747 * textprop.c (interval_insert_behind_hooks): Now static.
5748 (interval_insert_in_front_hooks): Likewise.
5749
64520e5c
PE
5750 * term.c: Make symbols static if they're not exported.
5751 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5752 (max_frame_lines, tty_set_terminal_modes):
5753 (tty_reset_terminal_modes, tty_turn_off_highlight):
5754 (get_tty_terminal): Now static.
5755 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5756 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5757 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5758 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5759 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5760
1fa53021
PE
5761 * sysdep.c: Make symbols static if they're not exported.
5762 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5763 Now static.
5764 (sigprocmask_set, full_mask): Remove; unused.
5765 (wait_debugging): Mark as visible.
5766 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5767 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5768
d4b43b22
PE
5769 * syntax.c (syntax_temp): Define only if !__GNUC__.
5770
b7c513d0
PE
5771 * sound.c (current_sound_device, current_sound): Now static.
5772
989b29ad
PE
5773 * search.c (searchbufs, searchbuf_head): Now static.
5774
13a55a78
PE
5775 * scroll.c (scroll_cost): Remove; unused.
5776 * dispextern.h (scroll_cost): Remove decl.
5777
de68a1fc
PE
5778 * region-cache.h (pp_cache): Mark as externally visible.
5779
40ccffa6
PE
5780 * process.c: Make symbols static if they're not exported.
5781 (process_tick, update_tick, create_process, chan_process):
5782 (Vprocess_alist, proc_buffered_char, datagram_access):
5783 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5784 (deactivate_process): Mark defn as static, as well as decl.
5785 * lisp.h (create_process): Remove decl.
5786 * process.h (chan_process, Vprocess_alist): Remove decls.
5787
ad64fc97
PE
5788 * print.c: Make symbols static if they're not exported.
5789 (print_depth, new_backquote_output, being_printed, print_buffer):
5790 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5791 (print_interval, print_number_index, initial_stderr_stream):
5792 Now static.
5793 * lisp.h (Fprinc): Remove decl.
5794 (debug_output_compilation_hack): Mark as externally visible.
5795
adddb265
PE
5796 * sysdep.c (croak): Move decl from here to syssignal.h.
5797 * syssignal.h (croak): Put it here, so the API can be checked when
5798 'croak' is called from dissociate_if_controlling_tty.
5799
1717ede2
PE
5800 * minibuf.c: Make symbols static if they're not exported.
5801 (minibuf_save_list, choose_minibuf_frame): Now static.
5802 * lisp.h (choose_minibuf_frame): Remove decl.
5803
fa5fb2bc
PE
5804 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5805
1e3890d1
PE
5806 * lread.c: Make symbols static if they're not exported.
5807 (read_objects, initial_obarray, oblookup_last_bucket_number):
5808 Now static.
5809 (make_symbol): Remove; unused.
5810 * lisp.h (initial_obarray, make_symbol): Remove decls.
5811
8a1414fa
PE
5812 * keyboard.c: Make symbols static if they're not exported.
5813 (single_kboard, recent_keys_index, total_keys, recent_keys):
5814 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5815 (this_single_command_key_start, echoing, last_auto_save):
5816 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5817 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5818 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5819 (Vlispy_mouse_stem, double_click_count):
5820 Now static.
5821 (force_auto_save_soon): Define only if SIGDANGER.
5822 (ignore_mouse_drag_p): Now static if
5823 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5824 (print_help): Remove; unused.
5825 (stop_character, last_timer_event): Mark as externally visible.
5826 * keyboard.h (ignore_mouse_drag_p): Declare only if
5827 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5828 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5829 * lisp.h (echoing): Remove decl.
5830 (force_auto_save_soon): Declare only if SIGDANGER.
5831 * xdisp.c (redisplay_window): Simplify code, to make it more
5832 obvious that ignore_mouse_drag_p is not accessed if !defined
5833 USE_GTK && !defined HAVE_NS.
5834
93ea6e8f
PE
5835 * intervals.c: Make symbols static if they're not exported.
5836 (merge_properties_sticky, merge_interval_right, delete_interval):
5837 Now static.
5838 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5839
77382fcc
PE
5840 * insdel.c: Make symbols static if they're not exported.
5841 However, leave prepare_to_modify_buffer alone. It's never
5842 called from outside this function, but that appears to be a bug.
5843 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5844 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5845 (adjust_after_replace_noundo): Remove; unused.
5846 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5847 (signal_before_change): Remove decls.
77382fcc 5848
9306c32e
PE
5849 * indent.c (val_compute_motion, val_vmotion): Now static.
5850
cd44d2eb
PE
5851 * image.c: Make symbols static if they're not exported.
5852 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5853 if USE_GTK.
5854 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5855 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5856
ad9a7a06
PE
5857 * fringe.c (standard_bitmaps): Now static.
5858 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5859
81626931
PE
5860 * frame.c: Make symbols static if they're not exported.
5861 (x_report_frame_params, make_terminal_frame): Now static.
5862 (get_frame_param): Now static, unless HAVE_NS.
5863 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5864 (x_get_resource_string): Remove; not used.
5865 * frame.h (make_terminal_frame, x_report_frame_params):
5866 (x_get_resource_string); Remove decls.
5867 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5868 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5869
239f9db9
PE
5870 * font.c, fontset.c: Make symbols static if they're not exported.
5871 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5872 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5873 * font.c (font_close_object): Now static.
5874 * font.h (font_close_object): Remove.
5875 * fontset.c (FONTSET_OBJLIST): Remove.
5876 (free_realized_fontset) #if-0 the body, which does nothing.
5877 (face_suitable_for_char_p): #if-0, as it's never called.
5878 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5879 * xfaces.c (face_at_string_position):
5880 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5881 since 0 is always ASCII.
5882
dfcf3579
PE
5883 * fns.c (weak_hash_tables): Now static.
5884
5045092b
PE
5885 * fileio.c: Make symbols static if they're not exported.
5886 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5887 (Vwrite_region_annotation_buffers): Now static.
5888
57a96f5c
PE
5889 * eval.c: Make symbols static if they're not exported.
5890 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5891 * lisp.h (backtrace_list): Remove decl.
5892
35f08c38
PE
5893 * emacs.c: Make symbols static if they're not exported.
5894 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5895 (fatal_error_code, fatal_error_signal_hook, standard_args):
5896 Now static.
5897 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5898 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5899 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5900 * lisp.h (fatal_error_signal_hook): Remove decl.
5901 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5902
f44bd759
PE
5903 * editfns.c: Move a (normally-unused) function to its only use.
5904 * editfns.c, lisp.h (get_operating_system_release): Remove.
5905 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5906 worth the hassle of breaking this out.
5907
b532497d
PE
5908 * xterm.c: Make symbols static if they're not exported.
5909 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5910 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5911 (x_destroy_window, x_delete_display):
5912 Now static.
5913 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5914 (x_mouse_leave): Remove; unused.
5915 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5916 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5917 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5918 Remove decls.
5919 (x_mouse_leave): Declare only if WINDOWSNT.
5920 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5921 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5922 USE_X_TOOLKIT.
5923
1675728f
PE
5924 * ftxfont.c: Make symbols static if they're not exported.
5925 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5926 HAVE_FREETYPE.
5927 * font.h (ftxfont_driver): Likewise.
5928
e4cebfca
PE
5929 * xfns.c: Make symbols static if they're not exported.
5930 (x_last_font_name, x_display_info_for_name):
5931 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5932 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5933 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5934 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5935 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5936 (last_show_tip_args): Now static.
5937 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5938 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5939 (x_screen_planes): Remove; unused.
5940 * dispextern.h (x_screen_planes): Remove decl.
5941
5bf46f05
PE
5942 * dispnew.c: Make symbols static if they're not exported.
5943 * dispextern.h (redraw_garbaged_frames, scrolling):
5944 (increment_row_positions): Remove.
5945 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5946 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5947 Now static.
5948 (redraw_garbaged_frames): Remove; unused.
5949
435f4c28
PE
5950 * xfaces.c: Make symbols static if they're not exported.
5951 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5952 Remove decls.
5953 * xterm.h (defined_color): Remove decls.
5954 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5955 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5956 (menu_face_changed_default, defined_color, free_realized_face):
5957 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5958 (ascii_face_of_lisp_face): Remove; unused.
5959
8524aef3
PE
5960 * xdisp.c: Make symbols static if they're not exported.
5961 * dispextern.h (scratch_glyph_row, window_box_edges):
5962 (glyph_to_pixel_coords, set_cursor_from_row):
5963 (get_next_display_element, set_iterator_to_next):
5964 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5965 (show_mouse_face): Remove decls
5966 * frame.h (message_buf_print): Likewise.
5967 * lisp.h (pop_message, set_message, check_point_in_composition):
5968 Likewise.
5969 * xterm.h (set_vertical_scroll_bar): Likewise.
5970 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5971 (message_buf_print, scratch_glyph_row, displayed_buffer):
5972 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5973 (get_next_display_element, show_mouse_face, window_box_edges):
5974 (frame_to_window_pixel_xy, check_point_in_composition):
5975 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5976 (glyph_to_pixel_coords): Remove; unused.
5977
16390cd2
PE
5978 * dired.c (file_name_completion): Now static.
5979
5980 * dbusbind.c (xd_in_read_queued_messages): Now static.
5981
a25f4dfa
PE
5982 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5983 * data.c (circular_list_error): Remove.
5984
14a9c8df
PE
5985 * commands.h (last_point_position, last_point_position_buffer):
5986 (last_point_position_window): Remove decls.
5987 * keyboard.c: Make these variables static.
5988
04f2d78b
CB
5989 * coding.h (coding, code_convert_region, encode_coding_gap):
5990 Remove decls.
74ab6df5
PE
5991 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5992 (iso_code_class, detect_coding, code_convert_region): Now static.
5993 (encode_coding_gap): Remove; unused.
5994
38dfbee1
PE
5995 * chartab.c (chartab_chars, chartab_bits): Now static.
5996
a2cb4e63
PE
5997 * charset.h (charset_iso_8859_1): Remove decl.
5998 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5999 Now static.
6000
127198fd
PE
6001 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6002 * ccl.c (Vccl_program_table): Now static.
6003 (check_ccl_update): Remove; unused.
6004
d85b608f
PE
6005 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6006 * category.h: ... from here.
6007 * category.c (check_category_table, set_category_set): Now static.
6008
31cd66f3
PE
6009 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6010 * lisp.h: Remove these decls.
6011
c358e587
PE
6012 * buffer.c (buffer_count): Remove unused var.
6013
e78aecca
PE
6014 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6015 so that it's not optimized away.
6016 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6017 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6018 exported only to the debugger.
6019
e192d7d3 6020 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6021 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6022
92470028
PE
6023 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6024 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6025 was inaccessible from Lisp.
6026 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6027 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6028
244ed907
PE
6029 alloc.c: Import and export fewer symbols, and remove unused items.
6030 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6031 is defined.
6032 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6033 it's not optimized away by whole-program optimization.
6034 (message_enable_multibyte, free_misc): Remove.
6035 (catchlist, handlerlist, mark_backtrace):
6036 Declare only if BYTE_MARK_STACK.
6037 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6038 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6039 (message_enable_multibyte): Remove decl.
6040 (free_misc, interval_free_list, float_block, float_block_index):
6041 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6042 (cons_free_list, last_marked_index):
6043 Now static.
6044 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6045 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6046 (mark_backtrace): Define only if BYTE_MARK_STACK.
6047 * xdisp.c (message_enable_multibyte): Now static.
6048
61c2b50e 6049 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6050 This makes it easier for human readers (and static analyzers)
6051 to see whether these variables are used from other modules.
6052 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6053 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6054 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6055 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6056 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6057 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6058 * xmenu.c, xselect.c:
6059 Declare Q* vars static if they are not used in other modules.
6060 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6061 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6062 Remove decls of unexported vars.
6063 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6064
95c82688
PE
6065 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6066
16a97296
PE
6067 Make Emacs functions such as Fatom 'static' by default.
6068 This makes it easier for human readers (and static analyzers)
6069 to see whether these functions can be called from other modules.
6070 DEFUN now defines a static function. To make the function external
6071 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6072 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6073 (Finit_image_library):
16a97296
PE
6074 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6075 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6076 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6077 Remove decls, since these functions are now static.
6078 (Funintern, Fget_internal_run_time): New decls, since these functions
6079 were already external.
95c82688 6080
16a97296
PE
6081 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6082 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6083 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6084 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6085 * keyboard.c, keymap.c, lread.c:
6086 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6087 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6088 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6089 Mark functions with DEFUE instead of DEFUN,
6090 if they are used in other modules.
6091 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6092 decls for now-static functions.
6093 * buffer.h (Fdelete_overlay): Remove decl.
6094 * callproc.c (Fgetenv_internal): Mark as internal.
6095 * composite.c (Fremove_list_of_text_properties): Remove decl.
6096 (Fcomposition_get_gstring): New forward static decl.
6097 * composite.h (Fcomposite_get_gstring): Remove decl.
6098 * dired.c (Ffile_attributes): New forward static decl.
6099 * doc.c (Fdocumntation_property): New forward static decl.
6100 * eval.c (Ffetch_bytecode): New forward static decl.
6101 (Funintern): Remove extern decl; now in .h file where it belongs.
6102 * fileio.c (Fmake_symbolic_link): New forward static decl.
6103 * image.c (Finit_image_library): New forward static decl.
6104 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6105 * intervals.h (Fprevious_property_change):
6106 (Fremove_list_of_text_properties): Remove decls.
6107 * keyboard.c (Fthis_command_keys): Remove decl.
6108 (Fcommand_execute): New forward static decl.
6109 * keymap.c (Flookup_key): New forward static decl.
6110 (Fcopy_keymap): Now static.
6111 * keymap.h (Flookup_key): Remove decl.
6112 * process.c (Fget_process): New forward static decl.
6113 (Fprocess_datagram_address): Mark as internal.
6114 * syntax.c (Fsyntax_table_p): New forward static decl.
6115 (skip_chars): Remove duplicate decl.
6116 * textprop.c (Fprevious_property_change): New forward static decl.
6117 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6118 Now internal.
6119 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6120 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6121
785bbd42
PE
6122 * editfns.c (Fformat): Remove unreachable code.
6123
8b913b57
AS
61242011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6125
6126 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6127 change. (Bug#8496)
6128
a6744a35
EZ
61292011-04-13 Eli Zaretskii <eliz@gnu.org>
6130
6131 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6132 when at ZV. (Bug#8487)
6133
e7974947
AS
61342011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6135
baad03f0
AS
6136 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6137 (Bug#8437)
6138 * keyboard.c (parse_tool_bar_item): Likewise.
6139 * sound.c (sound_cleanup, alsa_close): Likewise.
6140 * termcap.c (tgetent): Likewise.
6141 * xfns.c (x_default_font_parameter): Likewise.
6142 * xsettings.c (read_and_apply_settings): Likewise.
6143
e7974947
AS
6144 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6145 (overrun_check_free): Protoize.
6146
28272684
PE
61472011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6148
6149 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6150 since callers should never pass a negative size.
6151 Change the signature to match that of plain 'read' and 'write'; see
6152 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6153 * lisp.h: Update prototypes of emacs_write and emacs_read.
6154
11997c76
EZ
61552011-04-11 Eli Zaretskii <eliz@gnu.org>
6156
6157 * xdisp.c (redisplay_window): Don't try to determine the character
6158 position of the scroll margin if the window start point w->startp
e896f03c 6159 is outside the buffer's accessible region. (Bug#8468)
11997c76 6160
8a2cbd72
EZ
61612011-04-10 Eli Zaretskii <eliz@gnu.org>
6162
6163 Fix write-region and its subroutines for buffers > 2GB.
6164 * fileio.c (a_write, e_write): Modify declaration of arguments and
6165 local variables to support buffers larger than 2GB.
6166 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6167
6168 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6169 argument, local variables, and return value.
6170
6171 * lisp.h: Update prototypes of emacs_write and emacs_read.
6172
6173 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6174
4073e537 61752011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6176
1ebfdcb6
PE
6177 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6178
b2ded58d
PE
6179 Fix more problems found by GCC 4.6.0's static checks.
6180
7d66342c
PE
6181 * xdisp.c (vmessage): Use a better test for character truncation.
6182
bbf47d44
PE
6183 * charset.c (load_charset_map): <, not <=, for optimization,
6184 and to avoid potential problems with integer overflow.
9248994d 6185 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6186 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6187 * editfns.c (Fformat): Likewise.
1e69125e 6188 * syntax.c (skip_chars): Likewise.
3befa583 6189
e3019616
PE
6190 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6191 This also lets GCC 4.6.0 generate slightly better loop code.
6192
becfa255
PE
6193 * callint.c (Fcall_interactively): <, not <=, for optimization.
6194 (Fcall_interactively): Count the number of arguments produced,
6195 not the number of arguments given. This is simpler and lets GCC
6196 4.6.0 generate slightly better code.
6197
dae0cd48
PE
6198 * ftfont.c: Distingish more carefully between FcChar8 and char.
6199 The previous code passed unsigned char * to a functions like
6200 strlen and xstrcasecmp that expect char *, which does not
6201 conform to the C standard.
6202 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6203 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6204 char * when the C standard requires it.
6205
76032d70
PE
6206 * keyboard.c (read_char): Remove unused var.
6207
eb3f1cc8
PE
6208 * eval.c: Port to Windows vsnprintf (Bug#8435).
6209 Include <limits.h>.
6210 (SIZE_MAX): Define if the headers do not.
6211 (verror): Do not give up if vsnprintf returns a negative count.
6212 Instead, grow the buffer. This ports to Windows vsnprintf, which
6213 does not conform to C99. Problem reported by Eli Zaretskii.
6214 Also, simplify the allocation scheme, by avoiding the need for
6215 calling realloc, and removing the ALLOCATED variable.
6216
70476b54
PE
6217 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6218
12020a9e
PE
6219 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6220 But keep the doprint source code for now, as we might revamp it
6221 and use it again (Bug#8435).
ea6c7ae6
PE
6222 * lisp.h (doprnt): Remove.
6223 * Makefile.in (base_obj): Remove doprnt.o.
6224 * deps.mk (doprnt.o): Remove.
6225
5fdb398c
PE
6226 error: Print 32- and 64-bit integers portably (Bug#8435).
6227 Without this change, on typical 64-bit hosts error ("...%d...", N)
6228 was used to print both 32- and 64-bit integers N, which relied on
6229 undefined behavior.
6230 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6231 New macro.
6232 * lisp.h (error, verror): Mark as printf-like functions.
6233 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6234 Report overflow in size calculations when allocating printf buffer.
6235 Do not truncate output string at its first null byte.
6236 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6237 Truncate the output at a character boundary, since vsnprintf does not
6238 do that.
6239 * charset.c (check_iso_charset_parameter): Convert internal
6240 character to string before calling 'error', since %c now has the
6241 printf meaning.
6242 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6243 overflow when computing char to be passed to 'error'. Do not
6244 pass Lisp_Object to 'error'; pass the integer instead.
6245 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6246 formatted with plain %d.
6247
b189fa66
PE
6248 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6249
bff87ef0
PE
6250 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6251
7e2cac20
PE
6252 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6253
ce4d90b5
PE
6254 * xterm.c (x_catch_errors): Remove duplicate declaration.
6255
266c9547
PE
6256 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6257
79c49ad2
PE
6258 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6259
368f4090
JM
62602011-04-10 Jim Meyering <meyering@redhat.com>
6261
6262 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6263 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6264 return ssize_t not "int", and use size_t as the buffer length.
6265 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6266 * gnutls.h: Update declarations.
6267 * process.c (read_process_output): Use ssize_t, to match.
6268 (send_process): Likewise.
6269
a32d4040
CY
62702011-04-09 Chong Yidong <cyd@stupidchicken.com>
6271
6272 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6273
8546720e 62742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6275
04f2d78b
CB
6276 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6277 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6278
8546720e
GM
6279 * xterm.c (handle_one_xevent):
6280 * xmenu.c (create_and_show_popup_menu):
6281 * xselect.c (x_decline_selection_request)
6282 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6283
0a2f5c1a 62842011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6285
6286 Fix some uses of `int' instead of EMACS_INT.
6287 * search.c (string_match_1, fast_string_match)
6288 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6289 (scan_buffer, find_next_newline_no_quit)
6290 (find_before_next_newline, search_command, Freplace_match)
6291 (Fmatch_data): Make some `int' variables be EMACS_INT.
6292
6293 * xdisp.c (display_count_lines): 3rd argument and return value now
6294 EMACS_INT. All callers changed.
6295 (pint2hrstr): Last argument is now EMACS_INT.
6296
6297 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6298 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6299 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6300 (decode_coding_utf_16, decode_coding_emacs_mule)
6301 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6302 (decode_coding_ccl, decode_coding_charset)
6303 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6304 (decode_coding_iso_2022, decode_coding_emacs_mule)
6305 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6306 <char_offset, last_offset>: Declare EMACS_INT.
6307 (encode_coding_utf_8, encode_coding_utf_16)
6308 (encode_coding_emacs_mule, encode_invocation_designation)
6309 (encode_designation_at_bol, encode_coding_iso_2022)
6310 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6311 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6312 Declare EMACS_INT.
6313 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6314 (encode_invocation_designation): Last argument P_NCHARS is now
6315 EMACS_INT.
6316 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6317 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6318
6319 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6320 All users changed.
6321
6322 * ccl.c (Fccl_execute_on_string): Declare some variables
6323 EMACS_INT.
6324
8546720e 63252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6326
6327 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6328
4e19a977
CS
63292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6330
6331 * process.c (Fformat_network_address): Doc fix.
6332
87302331
R
63332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6334
6335 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6336
cbb59342
CY
63372011-04-08 Chong Yidong <cyd@stupidchicken.com>
6338
6339 * keyboard.c (read_char): Call Lisp function help-form-show,
6340 instead of using internal_with_output_to_temp_buffer.
6341 (Qhelp_form_show): New var.
e0d38eeb 6342 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6343
6344 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6345
6346 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6347
e67a13ab
CY
63482011-04-06 Chong Yidong <cyd@stupidchicken.com>
6349
04f2d78b
CB
6350 * process.c (Flist_processes): Remove to Lisp.
6351 (list_processes_1): Delete.
e67a13ab 6352
973f782d
EZ
63532011-04-06 Eli Zaretskii <eliz@gnu.org>
6354
7c106b1e
EZ
6355 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6356
973f782d
EZ
6357 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6358
41cf7d1a 63592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6360
ca23cc88
PE
6361 Fix more problems found by GCC 4.6.0's static checks.
6362
f390e2d5
PE
6363 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6364
42eea0d0
PE
6365 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6366
b69769da 6367 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6368
f9541e84
PE
6369 * xdisp.c (vmessage): Mark as a printf-like function.
6370
13841b55
PE
6371 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6372
c136c10f
PE
6373 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6374
5e2d4a30
PE
6375 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6376 printf-like functions.
6377 (tiff_load): Add casts to remove these marks before passing them
6378 to system-supplied API.
6379
583f48b9
PE
6380 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6381
b25d760e
PE
6382 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6383 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6384 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6385 directly, rather than having caller test rule sign. This avoids
6386 some unnecessary tests.
6387 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6388 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6389 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6390
bc7b6697 6391 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6392 (xfont_open): Avoid unnecessary tests.
bc7b6697 6393
27ccc379
PE
6394 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6395
dcd5c89a
PE
6396 * composite.h, composite.c (composition_gstring_put_cache):
6397 Use EMACS_INT, not int, for length.
6398
b13a45c6
PE
6399 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6400 breaking out part of COMPOSITION_DECODE_RULE.
6401 (COMPOSITION_DECODE_RULE): Use it.
6402 * composite.c (get_composition_id): Remove unused local vars,
6403 by using the new macro.
6404
1e792e4d
PE
6405 * textprop.c (set_text_properties_1): Change while to do-while,
6406 since the condition is always true at first.
6407
dc6c6455 6408 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6409 (interval_deletion_adjustment): Return unsigned value.
6410 All uses changed.
dc6c6455 6411
aba7731a
PE
6412 * process.c (list_processes_1, create_pty, read_process_output):
6413 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6414 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6415 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6416 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6417 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6418
fdfc4bf3
PE
6419 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6420
fca8fe46 6421 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6422 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6423
06a0259a 6424 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6425 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6426 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6427
e7b9e80f
PE
6428 * print.c (print_error_message): Avoid int overflow.
6429
56201685
PE
6430 * font.c (font_list_entities): Redo for clarity,
6431 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6432
78834453 6433 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6434 (font_score): Avoid potential overflow in diff calculation.
78834453 6435
0bc0b309 6436 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6437 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6438
e610eaca
PE
6439 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6440
b895abce
PE
6441 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6442 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6443 can always succeed if overflow has undefined behavior.
6444
1f1d9321 6445 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6446 (wordify): Omit three unnecessary tests.
1f1d9321 6447
c59478bc
PE
6448 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6449 All callers changed. This avoids the need for an unused var.
6450
79b73827
PE
6451 * casefiddle.c (casify_region): Remove var that is set but not used.
6452
a4db5dfe
PE
6453 * dired.c (file_name_completion): Remove var that is set but not used.
6454
43aae36e
PE
6455 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6456
2a47c44d 6457 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6458 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6459
a37c69bf
PE
6460 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6461 Check for integer overflow on size calculations.
6462
328ab8e7
PE
6463 * buffer.c (Fprevious_overlay_change): Remove var that is set
6464 but not used.
6465
e5a2a5cb
PE
6466 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6467 Remove vars that are set but not used.
8d84a6eb 6468 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6469 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6470
a60e5f68
PE
6471 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6472
f661cb61 6473 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6474 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6475
f0397f5a
PE
6476 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6477 that are set but not used.
6478
8664db06 6479 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6480 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6481
6abdaa4a
PE
6482 * xselect.c (x_get_local_selection, x_handle_property_notify):
6483 Remove vars that are set but not used.
6484
0ce7538d 6485 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6486 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6487
9ae848fc
PE
6488 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6489 Remove var that is set but not used.
0b918413
PE
6490 (scroll_bar_windows_size): Now size_t, not int.
6491 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6492 Check for overflow.
9ae848fc 6493
a5a62657
PE
6494 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6495 (map_tty_color) [!defined MSDOS]: Likewise.
6496
5c5cdd39
PE
6497 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6498
66ebf983
PE
6499 * coding.c: Remove vars that are set but not used.
6500 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6501 All callers changed.
6502 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6503 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6504 (decode_coding_charset): Remove vars that are set but not used.
6505
1be4d761
PE
6506 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6507 that is set but not used.
6508
47553fa8
PE
6509 * print.c (print_object): Remove var that is set but not used.
6510
1f7196bf 6511 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6512 The gnulib version avoids calling malloc in the usual case,
6513 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6514 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6515 * filelock.c (current_lock_owner): Likewise.
6516 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6517 * sysdep.c: Include allocator.h, careadlinkat.h.
6518 (emacs_no_realloc_allocator): New static constant.
6519 (emacs_readlink): New function.
fdb61804
PE
6520 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6521 ../lib/careadlinkat.h.
d1fdcab7 6522
f84c17c7
SM
65232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6524
6525 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6526 first non-nil return value).
6527
ef3862ad
JD
65282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6529
6530 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6531 if not defined (Bug#8403).
6532
376a7006
JB
65332011-04-02 Juanma Barranquero <lekktu@gmail.com>
6534
6535 * xdisp.c (display_count_lines): Remove parameter `start',
6536 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6537 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6538 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6539 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6540 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6541 and thereabouts. All callers changed.
6542 (get_per_char_metric): Remove parameter `f', unused since
6543 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6544
6ca3801d
JM
65452011-04-02 Jim Meyering <meyering@redhat.com>
6546
6547 do not dereference NULL upon failed strdup
6548 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6549 (ns_get_family): Likewise.
6550
d8e2b5ba
JB
65512011-04-02 Juanma Barranquero <lekktu@gmail.com>
6552
6553 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6554
8c74fcbd
JD
65552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6556
6557 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6558 later (Bug#8403).
6559
7200d79c
SM
65602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6561
03408648 6562 Add lexical binding.
7200d79c 6563
03408648
SM
6564 * window.c (Ftemp_output_buffer_show): New fun.
6565 (Fsave_window_excursion):
6566 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6567
6568 * lread.c (lisp_file_lexically_bound_p): New function.
6569 (Fload): Bind Qlexical_binding.
6570 (readevalloop): Remove `evalfun' arg.
6571 Bind Qinternal_interpreter_environment.
6572 (Feval_buffer): Bind Qlexical_binding.
6573 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6574 Mark as dynamic.
6575 (syms_of_lread): Declare `lexical-binding'.
6576
6577 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6578
6579 * keyboard.c (eval_dyn): New fun.
6580 (menu_item_eval_property): Use it.
ca105506
SM
6581
6582 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6583
03408648
SM
6584 * fns.c (concat, mapcar1): Accept byte-code-functions.
6585
6586 * eval.c (Fsetq): Handle lexical vars.
6587 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6588 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6589 (FletX, Flet): Obey lexical binding.
6590 (Fcommandp): Handle closures.
6591 (Feval): New `lexical' arg.
6592 (eval_sub): New function extracted from Feval. Use it almost
6593 everywhere where Feval was used. Look up vars in lexical env.
6594 Handle closures.
6595 (Ffunctionp): Move from subr.el.
6596 (Ffuncall): Handle closures.
6597 (apply_lambda): Remove `eval_flags'.
6598 (funcall_lambda): Handle closures and new byte-code-functions.
6599 (Fspecial_variable_p): New function.
6600 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6601 but without exporting it to Lisp.
23aba0ea 6602
23aba0ea 6603 * doc.c (Fdocumentation, store_function_docstring):
03408648 6604 * data.c (Finteractive_form): Handle closures.
23aba0ea 6605
03408648
SM
6606 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6607 interactive spec.
ba83908c 6608
04f2d78b
CB
6609 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6610 New byte-codes.
03408648
SM
6611 (exec_byte_code): New function extracted from Fbyte_code to handle new
6612 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6613
03408648 6614 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6615
03408648 6616 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6617
e2abce01
JB
66182011-03-31 Juanma Barranquero <lekktu@gmail.com>
6619
6620 * xdisp.c (redisplay_internal): Fix prototype.
6621
63696a73 66222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6623
63696a73 6624 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6625 (try_scrolling): Use it when setting scroll_limit.
6626 Limit scrolling to 100 screen lines.
63696a73
EZ
6627 (redisplay_window): Even when falling back on "recentering",
6628 position point in the window according to scroll-conservatively,
6629 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6630
6631 (try_scrolling): When point is above the window, allow searching
6632 as far as scroll_max, or one screenful, to compute vertical
6633 distance from PT to the scroll margin position. This prevents
6634 try_scrolling from unnecessarily failing when
6635 scroll-conservatively is set to a value slightly larger than the
6636 window height. Clean up the case of PT below the margin at bottom
6637 of window: scroll_max can no longer be INT_MAX. When aggressive
6638 scrolling is in use, don't let point enter the opposite scroll
6639 margin as result of the scroll.
6640 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6641 threshold of 100 lines for never-recentering scrolling.
6642
e4cc2dfc
JB
66432011-03-31 Juanma Barranquero <lekktu@gmail.com>
6644
6645 * dispextern.h (move_it_by_lines):
6646 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6647 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6648 (message_log_check_duplicate): Remove parameters `prev_bol' and
6649 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6650 (redisplay_internal): Remove parameter `preserve_echo_area',
6651 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6652
6653 * indent.c (Fvertical_motion):
6654 * window.c (window_scroll_pixel_based, Frecenter):
6655 Don't pass `need_y_p' to `move_it_by_lines'.
6656
1c470562
SM
66572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6658
44f230aa
SM
6659 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6660 steal a few bits to be more compact.
6661 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6662 Remove unneeded casts.
6663
1c470562
SM
6664 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6665
888adce9
ZK
66662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6667
6668 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6669 binding" message (bug#7967).
6670
f838ed7b
PE
66712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6672
77861b95
PE
6673 Fix more problems found by GCC 4.6.0's static checks.
6674
de6dbc14
PE
6675 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6676 Remove unused local var.
6677
f838ed7b
PE
6678 * editfns.c (Fmessage_box): Remove unused local var.
6679
792c7b2b
PE
6680 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6681 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6682 Omit unused local vars.
c499e557 6683 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6684 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6685 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6686 Omit unused local var.
6687
ba0165e1
PE
6688 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6689 Don't assume string length fits in int.
32ad8845 6690 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6691 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6692
3c59b4c9
PE
6693 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6694 instead of alloca (Bug#8344).
6695
a3eed478 6696 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6697 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6698
eb4d412d
PE
6699 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6700
1658b401
PE
6701 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6702 concerns.
6703
6704 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6705
6706 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6707
9a2c6e05
PE
6708 * keyboard.c (syms_of_keyboard): Use the same style as later
6709 in this function when indexing through an array. This also
6710 works around GCC bug 48267.
6711
03d0a109
PE
6712 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6713
44f730c8
PE
6714 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6715
fe75f926
PE
6716 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6717 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6718
ffa8c828
PE
6719 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6720 This avoids undefined behavior on integer overflow, and is a bit
6721 more convenient anyway since it is compared to a size_t variable.
6722
c5101a77
PE
6723 Variadic C functions now count arguments with size_t, not int.
6724 This avoids an unnecessary limitation on 64-bit machines, which
6725 caused (substring ...) to crash on large vectors (Bug#8344).
6726 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6727 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6728 All variadic functions and their callers changed accordingly.
c5101a77
PE
6729 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6730 * data.c (arith_driver, float_arith_driver): Likewise.
6731 * editfns.c (general_insert_function): Likewise.
6732 * eval.c (struct backtrace.nargs, interactive_p)
6733 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6734 (funcall_lambda, mark_backtrace): Likewise.
6735 * fns.c (concat): Likewise.
6736 * frame.c (x_set_frame_parameters): Likewise.
6737 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6738 0 if not found, not -1. All callers changed.
6739
dd3f25f7
PE
6740 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6741 (stack_copy_size): Now size_t, not int.
6742 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6743
461c2ab9
JB
67442011-03-28 Juanma Barranquero <lekktu@gmail.com>
6745
6746 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6747 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6748 All callers changed.
6749
6750 * lisp.h (multibyte_char_to_unibyte):
6751 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6752 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6753 * character.h (CHAR_TO_BYTE8):
6754 * cmds.c (internal_self_insert):
6755 * editfns.c (general_insert_function):
6756 * keymap.c (push_key_description):
6757 * search.c (Freplace_match):
6758 * xdisp.c (message_dolog, set_message_1): All callers changed.
6759
f6d62986
SM
67602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6761
6762 * keyboard.c (safe_run_hook_funcall): New function.
6763 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6764 don't set the hook to nil, but remove the offending function instead.
6765 (Qcommand_hook_internal): Remove, unused.
6766 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6767 Vcommand_hook_internal.
6768
6769 * eval.c (enum run_hooks_condition): Remove.
6770 (funcall_nil, funcall_not): New functions.
6771 (run_hook_with_args): Call each function through a `funcall' argument.
6772 Remove `cond' argument, now redundant.
6773 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6774 (Frun_hook_with_args_until_failure): Adjust accordingly.
6775 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6776
1db5b1ad
JB
67772011-03-28 Juanma Barranquero <lekktu@gmail.com>
6778
6779 * dispextern.h (string_buffer_position): Remove declaration.
6780
6781 * print.c (strout): Remove parameter `multibyte', unused since
6782 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6783
6784 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6785 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6786 All callers changed.
6787
6788 * w32.c (_wsa_errlist): Use braces for struct initializers.
6789
6790 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6791 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6792 All callers changed.
6793 (string_buffer_position): Likewise. Also, make static (it's never
6794 used outside xdisp.c).
6795 (cursor_row_p): Remove parameter `w', unused since
6796 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6797 (decode_mode_spec): Remove parameter `precision', introduced during
6798 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6799 All callers changed.
6800
5ffb62aa
JD
68012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6802
6803 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6804
461c2ab9 68052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6806
6807 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6808 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6809 (ns_update_auto_hide_menu_bar): New functions.
6810 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6811 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6812 ns_constrain_all_frames.
6813 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6814 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6815
5c380ffb
JD
68162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6817
6818 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6819
9af30bdf
GM
68202011-03-27 Glenn Morris <rgm@gnu.org>
6821
6822 * syssignal.h: Replace RETSIGTYPE with void.
6823 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6824 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6825 Replace SIGTYPE with void everywhere.
6826 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6827 * s/template.h (SIGTYPE): Remove commented out definition.
6828
e2abce01
JB
68292011-03-26 Eli Zaretskii <eliz@gnu.org>
6830
6831 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6832 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6833
f868cd8a
JB
68342011-03-26 Juanma Barranquero <lekktu@gmail.com>
6835
59eb0929
JB
6836 * w32.c (read_unc_volume): Use parameter `henum', instead of
6837 global variable `wget_enum_handle'.
6838
6839 * keymap.c (describe_vector): Remove parameters `indices' and
6840 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6841 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6842
f868cd8a
JB
6843 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6844
6845 * keyboard.c (timer_check): Remove parameter `do_it_now',
6846 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6847 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6848 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6849
6850 * keyboard.c (read_char):
6851 * w32menu.c (w32_menu_display_help):
6852 * xmenu.c (show_help_event, menu_help_callback):
6853 Adjust calls to `show_help_echo'.
6854
6855 * gtkutil.c (xg_maybe_add_timer):
6856 * keyboard.c (readable_events):
6857 * process.c (wait_reading_process_output):
6858 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6859
6860 * insdel.c (adjust_markers_gap_motion):
6861 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6862 (gap_left, gap_right): Don't call it.
6863
2ecf6fdb
CY
68642011-03-25 Chong Yidong <cyd@stupidchicken.com>
6865
6866 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6867 incurred during fontification.
6868
6b1f9ba4
JB
68692011-03-25 Juanma Barranquero <lekktu@gmail.com>
6870
6871 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6872 (DEFVAR_PER_BUFFER): Don't pass it.
6873
6874 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6875 (scrolling_window): Don't pass it.
6876
0f4a96b5
JB
68772011-03-25 Juanma Barranquero <lekktu@gmail.com>
6878
6879 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6880
6881 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6882 and `suffix'.
6883 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6884 of variables specific to SELinux and computation of `encoded_absname'.
6885
6886 * image.c (XPutPixel): Remove unused variable `height'.
6887
6888 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6889
6890 * unexw32.c (get_section_info): Remove unused variable `section'.
6891
6892 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6893 (system_process_attributes): Remove unused variable `sess'.
6894 (sys_read): Remove unused variable `err'.
6895
6896 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6897 (w32_wnd_proc): Remove unused variable `isdead'.
6898 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6899 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6900 (x_create_tip_frame): Remove unused variable `tem'.
6901
6902 * w32inevt.c (w32_console_read_socket):
6903 Remove unused variable `no_events'.
6904
6905 * w32term.c (x_draw_composite_glyph_string_foreground):
6906 Remove unused variable `width'.
6907
1149507c
JB
69082011-03-24 Juanma Barranquero <lekktu@gmail.com>
6909
6910 * w32term.c (x_set_glyph_string_clipping):
6911 Don't pass uninitialized region to CombineRgn.
6912
9c88f339
JB
69132011-03-23 Juanma Barranquero <lekktu@gmail.com>
6914
6915 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6916 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6917 (Fx_close_connection): Remove unused variable `i'.
6918
6919 * w32font.c (w32font_draw): Return number of glyphs.
6920 (w32font_open_internal): Remove unused variable `i'.
6921 (w32font_driver): Add missing initializer.
6922
6923 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6924 (fill_in_menu): Remove unused variable `items_added'.
6925
6926 * w32term.c (last_mouse_press_frame): Remove static global variable.
6927 (w32_clip_to_row): Remove unused variable `f'.
6928 (x_delete_terminal): Remove unused variable `i'.
6929
6930 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6931 (NOTHING): Remove unused static global variable.
6932 (uniscribe_check_otf): Remove unused variable `table'.
6933 (uniscribe_font_driver): Add missing initializers.
6934
dee091a3
JD
69352011-03-23 Julien Danjou <julien@danjou.info>
6936
6937 * term.c (Fsuspend_tty, Fresume_tty):
6938 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6939 * window.c (temp_output_buffer_show):
6940 * insdel.c (signal_before_change):
6941 * frame.c (Fhandle_switch_frame):
6942 * fileio.c (Fdo_auto_save):
6943 * emacs.c (Fkill_emacs):
6944 * editfns.c (save_excursion_restore):
6945 * cmds.c (internal_self_insert):
6946 * callint.c (Fcall_interactively):
6947 * buffer.c (Fkill_all_local_variables):
6948 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6949 Use Frun_hooks.
0f4a96b5 6950 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6951 unconditionnaly since it does the check itself.
6952
2c520ab5 69532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6954
c9c49752
PE
6955 Fix more problems found by GCC 4.5.2's static checks.
6956
8abc3f12
PE
6957 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6958 the first time through the loop, since we know p0 < p1 then.
6959 This also avoids a gcc -Wstrict-overflow warning.
6960
a2d26660
PE
6961 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6962 leading to a memory leak, possible in functions like
6963 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6964 of objects (Bug#8318).
a2d26660 6965
916c72e9
PE
6966 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6967 that could (at least in theory) be that large.
6968
19ab8a18
PE
6969 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6970 This is less likely to overflow, and avoids undefined behavior if
6971 overflow does occur. All callers changed. Use strtoul to scan
6972 for the unsigned long integer.
b7cbbd6f
PE
6973 (pint2hrstr): Simplify and tune code slightly.
6974 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6975
f0641eff
PE
6976 * scroll.c (do_scrolling): Work around GCC bug 48228.
6977 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6978
7f650bb9
PE
6979 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6980 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6981 (validate_x_resource_name): Simplify count usage.
6982 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6983
37dd57d1
PE
6984 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6985 fail (Bug#8306).
81e56e61 6986
699979fc 6987 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6988
401bf9b4
PE
6989 * process.c (Fmake_network_process): Use socklen_t, not int,
6990 where POSIX says socklen_t is required in portable programs.
6991 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6992 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6993 (Fmake_network_process, server_accept_connection):
6994 (wait_reading_process_output, read_process_output):
6995 Likewise.
6996
b93aacde
PE
6997 * process.c: Rename or move locals to avoid shadowing.
6998 (list_processes_1, Fmake_network_process):
6999 (read_process_output_error_handler, exec_sentinel_error_handler):
7000 Rename or move locals.
4dc343ee 7001 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7002 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7003 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7004 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7005 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7006
af8a867c 7007 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7008 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7009 Include tparam.h instead, since it declares them.
af8a867c
PE
7010 * cm.h (PC): Remove extern decl; tparam.h now does this.
7011 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7012 * terminfo.c: Include tparam.h, to check interfaces.
7013 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7014 (tparam): Adjust signature to match interface in tparam.h;
7015 this removes some undefined behavior. Check that outstring and len
7016 are zero, which they always are with Emacs.
7017 * tparam.h (PC, BC, UP): New extern decls.
7018
0248044d 7019 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7020 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7021
8ff096c1 7022 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7023 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7024 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7025 (ftfont_list): Remove unused local.
49eaafba
PE
7026 (get_adstyle_property, ftfont_pattern_entity):
7027 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7028 Rename locals to avoid shadowing.
8ff096c1 7029
e2be39f6
PE
7030 * xfont.c (xfont_list_family): Mark var as initialized.
7031
c9735e30
PE
7032 * xml.c (make_dom): Now static.
7033
8f5201ae
PE
7034 * composite.c (composition_compute_stop_pos): Rename local to
7035 avoid shadowing.
b246f932
PE
7036 (composition_reseat_it): Remove unused locals.
7037 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7038 (composition_update_it): Mark var as initialized.
11b61122
PE
7039 (find_automatic_composition): Mark vars as initialized,
7040 with a FIXME (Bug#8290).
8f5201ae 7041
760fbc2c
PE
7042 character.h: Rename locals to avoid shadowing.
7043 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7044 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7045 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7046 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7047 to avoid shadowing.
7048
ff08eb85
PE
7049 * textprop.c (property_change_between_p): Remove; unused.
7050
fc7bf025
PE
7051 * intervals.c (interval_start_pos): Now static.
7052
235d7abc
PE
7053 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7054
44f230aa
SM
7055 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7056 Rename locals to avoid shadowing.
3e7d6594 7057
50060332
PE
7058 * sound.c (wav_play, au_play, Fplay_sound_internal):
7059 Fix pointer signedness.
d01f234b 7060 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7061 (wav_play): Initialize a variable to 0, to prevent undefined
7062 behavior (Bug#8278).
50060332 7063
c4fc4e30
PE
7064 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7065
918436ed
PE
7066 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7067
c939f91b
PE
7068 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7069 clobbering (Bug#8298).
b9c7f648
PE
7070 * sysdep.c (sys_subshell): Likewise.
7071 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7072
6bd8c144
PE
7073 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7074 This should get cleaned up, so that child_setup has the
7075 same signature on all platforms.
7076
7710357c 7077 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7078 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7079
c59da222
CY
70802011-03-22 Chong Yidong <cyd@stupidchicken.com>
7081
7082 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7083 not to be necessary, and produces flickering.
7084
66b87493
GM
70852011-03-20 Glenn Morris <rgm@gnu.org>
7086
7087 * config.in: Remove file.
7088
45b6f6d5
JB
70892011-03-20 Juanma Barranquero <lekktu@gmail.com>
7090
7091 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7092 are now in src/globals.h.
7093 (syms_of_minibuf): Remove spurious & from previous change.
7094
3ec03f7e
LL
70952011-03-20 Leo <sdl.web@gmail.com>
7096
7097 * minibuf.c (completing-read-function): New variable.
7098 (completing-read-default): Rename from completing-read.
7099 (completing-read): Call completing-read-function.
7100
b14e3e21
CY
71012011-03-19 Juanma Barranquero <lekktu@gmail.com>
7102
7103 * xfaces.c (Fx_load_color_file):
7104 Read color file from absolute filename (bug#8250).
7105
f2b726e6
JB
71062011-03-19 Juanma Barranquero <lekktu@gmail.com>
7107
7108 * makefile.w32-in: Update dependencies.
7109
09f6ff02
EZ
71102011-03-17 Eli Zaretskii <eliz@gnu.org>
7111
7112 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7113
29a6015a
PE
71142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7115
a3a6c54e
PE
7116 Fix more problems found by GCC 4.5.2's static checks.
7117
b766f867
PE
7118 * process.c (make_serial_process_unwind, send_process_trap):
7119 (sigchld_handler): Now static.
7120
be02381c
PE
7121 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7122 That way, the code declares only the vars that it needs.
7123 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7124 * s/cygwin.h (PTY_ITERATION): Likewise.
7125 * s/darwin.h (PTY_ITERATION): Likewise.
7126 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7127
57048744
PE
7128 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7129 * process.c (allocate_pty): Don't declare stb unless it's needed.
7130
7914961c 7131 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7132 (CONSTANTLIM): Remove; unused.
7133 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7134 Define only if needed.
7914961c 7135
b3967b18
PE
7136 * unexelf.c (unexec): Name an expression,
7137 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7138 Use a different way to cause a compilation error if anyone uses
7139 n rather than nn, a way that does not involve shadowing.
73366a00 7140 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7141
29a6015a
PE
7142 * deps.mk (unexalpha.o): Remove; unused.
7143
43cfc33e 7144 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7145 * unexec.h: New file.
ce701a33
PE
7146 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7147 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7148 Depend on unexec.h.
7149 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7150 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7151 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7152 Change as necessary to match prototype in unexec.h.
ce701a33 7153
01f44d5a
PE
7154 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7155 shadowing.
4f63c6bb 7156 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7157
a6670b0b
PE
7158 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7159 Rename locals to avoid shadowing.
7160
cef2010d 7161 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7162 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7163
d4d7173a
PE
7164 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7165
f08b802a
PE
7166 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7167 warning when compiling print.c.
7168
3ddb0639
PE
7169 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7170 instead of using an uninitialized var.
5ad03b97 7171 (font_sort_entities): Mark var as initialized.
3ddb0639 7172
170a2692
PE
7173 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7174
e663c700
PE
7175 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7176 pointers to constants.
89bc529a 7177 (font_parse_fcname): Remove unused vars.
7b81e2d0 7178 (font_delete_unmatched): Now static.
ea838e10 7179 (font_get_spec): Remove; unused.
13a547c6
PE
7180 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7181 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7182 Rename or move locals to avoid shadowing.
e663c700 7183
2a80c887 7184 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7185 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7186
1384fa33 7187 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7188 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7189
8b2c52e9
PE
7190 * alloc.c (mark_backtrace): Move decl from here ...
7191 * lisp.h: ... to here, so that it can be checked.
7192
475545b5 7193 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7194 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7195 (lisp_indirect_variable): Name an expression,
7196 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7197 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7198
b1349114 7199 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7200 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7201 Use const pointer when appropriate.
b1349114 7202
a2928364
PE
7203 * lisp.h (get_system_name, get_operating_system_release):
7204 Move decls here, to check interfaces.
7205 * process.c (get_operating_system_release): Move decl to lisp.h.
7206 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7207 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7208 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7209 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7210 (Fformat_time_string, Fencode_time, Finsert_char):
7211 (Ftranslate_region_internal, Fformat):
7212 Rename or remove local vars to avoid shadowing.
9710023e 7213 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7214
a415e694
PE
7215 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7216 avoid shadowing.
7217
8ef4622d
PE
7218 * lisp.h (eassert): Check that the argument compiles, even if
7219 ENABLE_CHECKING is not defined.
7220
946f9a5b
PE
7221 * data.c (Findirect_variable): Name an expression, to avoid
7222 gcc -Wbad-function-cast warning.
112396d6 7223 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7224 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7225 (Fmake_variable_buffer_local, Fmake_local_variable):
7226 Mark variables as initialized.
52746918 7227 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7228
e5aab7e7 7229 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7230 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7231 Rename locals to avoid shadowing.
dff45157
PE
7232 (mark_stack): Move local variables into the #ifdef region where
7233 they're used.
7bc26fdb
PE
7234 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7235 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7236 needed otherwise.
7237 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7238 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7239 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7240
e5aab7e7
PE
7241 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7242 avoids undefined behavior in theory.
7243
4da60324
PE
7244 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7245
88043301
PE
7246 Use functions, not macros, for up- and down-casing (Bug#8254).
7247 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7248 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7249 to use the following functions instead of these macros.
7250 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7251 EMACS_INT, since callers assume the returned value fits in int.
7252 (upcase1): Likewise, for UPCASE_TABLE.
7253 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7254 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7255 the race-condition problem in the old DOWNCASE.
88043301 7256
19ed5445
PE
7257 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7258 Rename locals to avoid shadowing.
7259 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7260 (regex_compile, re_search_2, re_match_2_internal):
7261 Remove unused local vars.
952db0d7
PE
7262 (FREE_VAR): Rewrite so as not to use empty "else",
7263 which gcc can warn about.
da053e48 7264 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7265 (RETALLOC_IF): Define only if needed.
7266 (WORDCHAR_P): Likewise. This one is never needed, but is used
7267 only in a comment talking about a compiler bug, so put inside
7268 the #if 0 of that comment.
7269 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7270 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7271 Remove; unused.
19ed5445 7272
1f3561e4 7273 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7274 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7275 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7276
ded6f8f7
PE
7277 * search.c (simple_search): Remove unused var.
7278
dbd37a95
PE
7279 * dired.c (compile_pattern): Move decl from here ...
7280 * lisp.h: ... to here, so that it can be checked.
7281 (struct re_registers): New forward decl.
7282
7e47afad
PE
7283 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7284
85f24f61
PE
7285 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7286 All uses changed.
7287 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7288 Rename locals to avoid shadowing.
5671df8f 7289 (Fvertical_motion): Mark locals as initialized.
85f24f61 7290
181aa2be 7291 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7292 (casify_region): Mark local as initialized.
181aa2be 7293
930d429c
PE
7294 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7295
7082eac6
PE
7296 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7297 New macros, so that the caller can use some names other than
7298 gcpro1, gcpro2, etc.
7299 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7300 of the new macros.
7301 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7302 argument, for consistency with GCPRO2_VAR, etc: it is now the
7303 prefix of the variable, not the variable itself. All uses
7304 changed.
38b2c076
PE
7305 * dired.c (directory_files_internal, file_name_completion):
7306 Rename locals to avoid shadowing.
7307
15206ed9
PE
7308 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7309 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7310 dired.c's scmp function, had undefined behavior.
7311 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7312 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7313 * buffer.h: ... to here, because these macros use current_buffer,
7314 and the new implementation with inline functions needs to have
7315 current_buffer in scope now, rather than later when the macros
7316 are used.
7317 (downcase, upcase1): New static inline functions.
7318 (DOWNCASE, UPCASE1): Reimplement using these functions.
7319 This avoids undefined behavior in expressions like
7320 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7321 from race conditions in accessing the global variables
7322 case_temp1 and case_temp2.
7323 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7324 * lisp.h (case_temp1, case_temp2): Remove their decls.
7325 * character.h (ASCII_CHAR_P): Move from here ...
7326 * lisp.h: ... to here, so that the inline functions mentioned
7327 above can use them.
7328
4a6bea26
PE
7329 * dired.c (directory_files_internal_unwind): Now static.
7330
f14b7e14
PE
7331 * fileio.c (file_name_as_directory, directory_file_name):
7332 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7333 Now static.
2893f146
PE
7334 (file_name_as_directory): Use const pointers when appropriate.
7335 (Fexpand_file_name): Likewise. In particular, newdir might
7336 point at constant storage, so make it a const pointer.
fd4ead52 7337 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7338 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7339 signedness issues.
f839df0c
PE
7340 (Fset_file_times, Finsert_file_contents, auto_save_error):
7341 Rename locals to avoid shadowing.
f14b7e14 7342
5716756e 7343 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7344 (Ftry_completion, Fall_completions): Rename or remove locals
7345 to avoid shadowing.
5716756e 7346
b4c3046a
PE
7347 * marker.c (bytepos_to_charpos): Remove; unused.
7348
b45db522
PE
7349 * lisp.h (verify_bytepos, count_markers): New decls,
7350 so that gcc does not warn that these functions aren't declared.
7351
85876d07
PE
7352 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7353 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7354 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7355 (copy_text): Remove unused local var.
85876d07 7356
03d78a21 7357 * filelock.c (within_one_second): Now static.
b3dd38ab 7358 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7359
5df8f01b
PE
7360 * buffer.c (fix_overlays_before): Mark locals as initialized.
7361 (fix_start_end_in_overlays): Likewise. This function should be
7362 simplified by using pointers-to-pointers, but that's a different
7363 matter.
b1d876f1 7364 (switch_to_buffer_1): Now static.
8f54f30a
PE
7365 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7366 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7367
a70072c9 7368 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7369 Fix pointer signedness issue.
edced198
PE
7370 (sys_subshell): Mark local as volatile if checking for lint,
7371 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7372 (MAXPATHLEN): Define only if needed.
a70072c9 7373
a0977c44
PE
7374 * process.c (serial_open, serial_configure): Move decls from here ...
7375 * systty.h: ... to here, so that they can be checked.
7376
a884fdcc
PE
7377 * fns.c (get_random, seed_random): Move extern decls from here ...
7378 * lisp.h: ... to here, so that they can be checked.
7379
604efe86 7380 * sysdep.c (reset_io): Now static.
b8950c94 7381 (wait_for_termination_signal): Remove; unused.
604efe86 7382
38fc62d9
PE
7383 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7384 (copy_keymap_item, append_key, push_text_char_description):
7385 Now static.
1004a21a 7386 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7387 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7388 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7389 (describe_map_tree):
7390 Rename locals to avoid shadowing.
38fc62d9 7391
2f2650da
PE
7392 * keyboard.c: Declare functions static if they are not used elsewhere.
7393 (echo_char, echo_dash, cmd_error, top_level_2):
7394 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7395 (read_char, kbd_buffer_get_event, make_lispy_position):
7396 (make_lispy_event, make_lispy_movement, apply_modifiers):
7397 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7398 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7399 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7400 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7401 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7402
a053e86c 7403 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7404 (mark_kboards): Move decl here ...
7405 * alloc.c (mark_kboards): ... from here.
a053e86c 7406
4752793e
PE
7407 * lisp.h (force_auto_save_soon): New decl.
7408
74f10ca7 7409 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7410 (DEFINE_DUMMY_FUNCTION): New macro.
7411 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7412 Use it.
c03cd23f
PE
7413 (main): Add casts to avoid warnings
7414 if GCC considers string literals to be constants.
74f10ca7 7415
022e70d4
PE
7416 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7417
59d6fe83
PE
7418 * dbusbind.c: Pointer signedness fixes.
7419 (xd_signature, xd_append_arg, xd_initialize):
7420 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7421 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7422 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7423 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7424
78320123
PE
7425 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7426 if GCC considers string literals to be constants.
49cebcca 7427 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7428
35ac2a97
SM
74292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7430
fb103ca9
SM
7431 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7432 (print_preprocess, print_object): New macro to fix last change.
7433
35ac2a97
SM
7434 * print.c (print_preprocess): Don't forget font objects.
7435
62973b41
JB
74362011-03-16 Juanma Barranquero <lekktu@gmail.com>
7437
7438 * emacs.c (USAGE3): Doc fixes.
7439
0e48bb22
AS
74402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7441
7442 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7443 structure.
7444
7684e57b
JB
74452011-03-14 Juanma Barranquero <lekktu@gmail.com>
7446
7447 * lisp.h (VWindow_system, Qfile_name_history):
7448 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7449 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7450 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7451
7452 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7453 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7454
7455 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7456 * w32console.c (detect_input_pending, read_input_pending)
7457 (encode_terminal_code):
7458 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7459 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7460 (w32_system_caret_y, Qfile_name_history):
7461 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7462 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7463 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7464 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7465 * w32proc.c (Qlocal, report_file_error):
7466 * w32term.c (Vwindow_system, updating_frame):
7467 * w32uniscribe.c (initialized, uniscribe_font_driver):
7468 Remove unneeded extern declarations.
7469
2aa46d6c
CY
74702011-03-14 Chong Yidong <cyd@stupidchicken.com>
7471
c96bbc66 7472 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7473
cffc6f3b
CY
74742011-03-13 Chong Yidong <cyd@stupidchicken.com>
7475
7476 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7477 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7478 These macros can no longer be used for assignment.
7479
44f230aa
SM
7480 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7481 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7482 (record_buffer_markers, fetch_buffer_markers): New functions for
7483 recording and fetching special buffer markers.
7484 (set_buffer_internal_1, set_buffer_temp): Use them.
7485
7486 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7487
7488 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7489
7490 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7491 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7492
7493 * xdisp.c (hscroll_window_tree):
7494 (reconsider_clip_changes): Use PT instead of BUF_PT.
7495
d251f04b
EZ
74962011-03-13 Eli Zaretskii <eliz@gnu.org>
7497
7498 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7499 $(EMACS_ROOT)/lib/intprops.h.
7500
f0c77cd1
PE
75012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7502
3eca4629
PE
7503 Fix more problems found by GCC 4.5.2's static checks.
7504
7c86ee98
PE
7505 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7506 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7507 (xg_free_frame_widgets): Make it clear that a local variable is
7508 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7509 (gdk_window_get_screen): Make it clear that this macro is needed
7510 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7511 (int_gtk_range_get_value): New function, which avoids a diagnostic
7512 from gcc -Wbad-function-cast.
7513 (xg_set_toolkit_scroll_bar_thumb): Use it.
7514 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7515 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7516 (get_utf8_string, xg_get_file_with_chooser):
7517 Rename locals to avoid shadowing.
7518 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7519
41729b81
PE
7520 * xgselect.c (xg_select): Remove unused var.
7521
f0c77cd1
PE
7522 * image.c (four_corners_best): Mark locals as initialized.
7523 (gif_load): Initialize transparent_p to zero (Bug#8238).
7524 Mark another local as initialized.
ec6cf4c6 7525 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7526
ce0ad53d 7527 * image.c (clear_image_cache): Now static.
d5d5a617 7528 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7529 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7530 (x_edge_detection): Remove unnecessary cast that
7531 gcc -Wbad-function-cast diagnoses.
2037898d 7532 (gif_load): Fix pointer signedness.
6ae141d6
PE
7533 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7534 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7535
33383987 75362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7537
d32df629
PE
7538 Improve quality of tests for time stamp overflow.
7539 For example, without this patch (encode-time 0 0 0 1 1
7540 1152921504606846976) returns the obviously-bogus value (-948597
7541 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7542 reports time overflow. See
7543 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7544 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7545 * editfns.c: Include limits.h and intprops.h.
7546 (TIME_T_MIN, TIME_T_MAX): New macros.
7547 (time_overflow): Move earlier, to before first use.
7548 (hi_time, lo_time): New functions, for an accurate test for
7549 out-of-range times.
7550 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7551 (Fget_internal_run_time): Don't assume time_t fits in int.
7552 (make_time): Use list2 instead of Fcons twice.
7553 (Fdecode_time): More accurate test for out-of-range times.
7554 (check_tm_member): New function.
7555 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7556 (lisp_time_argument): Don't rely on undefined left-shift and
7557 right-shift behavior when checking for time stamp overflow.
8be6f318 7558
fe31d94c
PE
7559 * editfns.c (time_overflow): New function, refactoring common code.
7560 (Fformat_time_string, Fdecode_time, Fencode_time):
7561 (Fcurrent_time_string): Use it.
7562
8be6f318
PE
7563 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7564 * dired.c (make_time): Move to ...
7565 * editfns.c (make_time): ... here.
7566 * systime.h: Note the move.
7567
09d9db2c 75682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7569
126bc0dc
YM
7570 * fringe.c (update_window_fringes): Remove unused variables.
7571
c47cbdfd
YM
7572 * unexmacosx.c (copy_data_segment): Also copy __got section.
7573 (Bug#8223)
7574
7ac80be9
EZ
75752011-03-12 Eli Zaretskii <eliz@gnu.org>
7576
c96bbc66 7577 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7578 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7579 Constify `char *' arguments and their references according to
7580 prototypes in tparam.h.
7581
ecb0f94d 7582 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7583
7ac80be9
EZ
7584 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7585 Adapt all references accordingly.
7586
7587 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7588
ef1fd07e
TT
75892011-03-11 Tom Tromey <tromey@redhat.com>
7590
7591 * buffer.c (syms_of_buffer): Remove obsolete comment.
7592
7ef4b50c
EZ
75932011-03-11 Eli Zaretskii <eliz@gnu.org>
7594
7595 * termhooks.h (encode_terminal_code): Declare prototype.
7596
7597 * msdos.c (encode_terminal_code): Don't declare prototype.
7598
7599 * term.c (encode_terminal_code): Now external again, used by
7600 w32console.c and msdos.c.
7601
44f230aa
SM
7602 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7603 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7604
4b1ec863 76052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7606
1714f52b 7607 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7608
4b1ec863
PE
7609 * fringe.c (update_window_fringes): Mark locals as initialized
7610 (Bug#8227).
7611 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7612
524c7aa6
PE
7613 * alloc.c (mark_fringe_data): Move decl from here ...
7614 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7615 to check its interface.
7616 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7617
a5c0af81 7618 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7619 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7620 (fontset_font): Mark local as initialized.
a9a06e0b 7621 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7622
b4716021
PE
7623 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7624
811e9bac 7625 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7626 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7627 (x_own_selection, Fx_disown_selection_internal): Rename locals
7628 to avoid shadowing.
7629 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7630
7e3ab302
PE
7631 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7632 so that the caller can use some name other than gcpro1.
7633 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7634 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7635 (Fx_backspace_delete_keys_p):
7636 Use them to avoid shadowing, and rename vars to avoid shadowing.
7637 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7638 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7639 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7640 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7641 Remove unused locals.
7e3ab302
PE
7642 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7643 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7644 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7645 macros.
f78faa98 7646
e2b13473
PE
7647 * xterm.h (x_mouse_leave): New decl.
7648
77f23912
PE
7649 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7650 Remove unused functions.
cdf4ba58
PE
7651 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7652 (x_calc_absolute_position): Now static.
7411c686 7653 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7654 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7655 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7656 unless they are used.
38d0b34a
PE
7657 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7658 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7659 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7660 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7661 (x_error_catcher, x_connection_closed, x_error_handler):
7662 (x_error_quitter, xembed_send_message, x_iconify_frame):
7663 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7664 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7665 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7666
44f230aa
SM
7667 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7668 Rename or move locals to avoid shadowing.
6b463e58 7669 (tty_defined_color, merge_face_heights): Now static.
5967d051 7670 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7671 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7672 does not deduce is never used uninitialized.
73719eba
PE
7673 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7674 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7675
426994c3 7676 * terminal.c (store_terminal_param): Now static.
5489860b 7677
032f1620 7678 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7679 (set_frame_menubar): Remove unused local.
d4323972 7680 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7681 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7682 since they might point to immutable storage.
281585b0
PE
7683 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7684 since it's unused otherwise.
032f1620 7685
367c19e5 7686 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7687 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7688 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7689 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7690 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7691 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7692 does not deduce are never used uninitialized.
70739cbe 7693
07b48fa9
PE
7694 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7695
8868a238 7696 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7697 * window.c (window_loop, size_window):
7698 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7699
7e5cf297 7700 * window.c (display_buffer): Now static.
d6550a9f
PE
7701 (size_window): Mark variables that gcc -Wuninitialized
7702 does not deduce are never used uninitialized.
a586633d
PE
7703 * window.h (check_all_windows): New decl, to forestall
7704 gcc -Wmissing-prototypes diagnostic.
5b555da1 7705 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7706
f6095868
PE
7707 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7708 shadowing.
7709 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7710 Include <limits.h>.
7711 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7712 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7713 (load_charset_map): Mark variables that gcc -Wuninitialized
7714 does not deduce are never used uninitialized.
53df7c11 7715 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7716
f38b440c
PE
7717 * coding.c (coding_set_source, coding_set_destination):
7718 Use "else { /* comment */ }" rather than "else /* comment */;"
7719 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7720 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7721 a block, when the outer 'i' will do.
7722 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7723 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7724 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7725 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7726 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7727 Rename locals to avoid shadowing.
7728 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7729 * coding.c (emacs_mule_char, encode_invocation_designation):
7730 Now static, since they're not used elsewhere.
413bb2db 7731 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7732 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7733 (decode_coding_emacs_mule): Mark variables that gcc
7734 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7735 (detect_coding_iso_2022): Initialize a local variable that might
7736 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7737 this initialization is needed. (Bug#8211)
5f58e762
PE
7738 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7739 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7740 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7741 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7742 Remove unused macros.
f38b440c 7743
232b38b9 7744 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7745 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7746 * character.c (string_count_byte8): Likewise.
232b38b9 7747
fb90da1b
PE
7748 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7749 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7750
fb93dbc2
PE
7751 * chartab.c (copy_sub_char_table): Now static, since it's not used
7752 elsewhere.
5c156ace
PE
7753 (sub_char_table_ref_and_range, char_table_ref_and_range):
7754 Rename locals to avoid shadowing.
bbcd0949 7755 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7756
7d3b3862 7757 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7758 (BIDI_BOB): Remove unused macro.
7d3b3862 7759
6be7d3da
PE
7760 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7761 deduce are never used uninitialized.
c2ed9c8b 7762 * term.c (encode_terminal_code): Likewise.
6be7d3da 7763
75f8807f 7764 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7765
50938595
PE
7766 * tparam.h: New file.
7767 * term.c, tparam.h: Include it.
7768 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7769 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7770 Move these decls to tparam.h, and make them agree with what
7771 is actually in tparam.c. The previous trick of using incompatible
7772 decls in different modules does not conform to the C standard.
7773 All callers of tparam changed to use tparam's actual API.
7774 * tparam.c (tparam1, tparam, tgoto):
7775 Use const pointers where appropriate.
7776
fbceeba2
PE
7777 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7778 * cm.h (struct cm): Likewise.
7779 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7780 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7781 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7782 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7783 (turn_on_face, init_tty): Likewise.
7784 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7785
7f3f1250
PE
7786 * term.c (term_mouse_position): Rename local to avoid shadowing.
7787
e6ca6543
PE
7788 * alloc.c (mark_ttys): Move decl from here ...
7789 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7790
c40f8d15
AS
77912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7792
7793 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7794
cfe0661d
JB
77952011-03-09 Juanma Barranquero <lekktu@gmail.com>
7796
7797 * search.c (compile_pattern_1): Remove argument regp, unused since
7798 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7799 (compile_pattern): Don't pass it.
7800
0afb4571
J
78012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7802
7803 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7804 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7805 for ! HAVE_GTK3.
7806 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7807
7808 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7809
7810 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7811 gdk_window_get_screen, gdk_window_get_geometry,
7812 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7813 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7814 (xg_get_pixbuf_from_pixmap): New function.
7815 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7816 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7817 Call xg_get_pixbuf_from_pixmap instead of
7818 gdk_pixbuf_get_from_drawable.
7819 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7820 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7821 (xg_check_special_colors): Use GtkStyleContext and its functions
7822 for HAVE_GTK3.
7823 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7824 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7825 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7826 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7827 Call gtk_widget_get_preferred_size.
0afb4571
J
7828 (xg_frame_resized): gdk_window_get_geometry only takes 5
7829 parameters.
44f230aa
SM
7830 (xg_win_to_widget, xg_event_is_for_menubar):
7831 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7832 (xg_set_widget_bg): New function.
7833 (delete_cb): New function.
895009e1 7834 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7835 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7836 (xg_set_background_color): Call xg_set_widget_bg.
7837 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7838 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7839 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7840 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7841 if ! HAVE_GTK3.
7842 (update_frame_tool_bar): Call gtk_widget_hide.
7843 (xg_initialize): Use GDK_KEY_g.
7844
7845 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7846 if ! HAVE_GTK3
7847 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7848
7849 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7850 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7851 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7852
1c2cc4ef
JB
78532011-03-08 Juanma Barranquero <lekktu@gmail.com>
7854
7855 * w32xfns.c (select_palette): Check success of RealizePalette against
7856 GDI_ERROR, not zero.
7857
33383987 7858See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7859
7860;; Local Variables:
7861;; coding: utf-8
aac0c6e3
MR
7862;; End:
7863
33383987 7864 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7865
7866 This file is part of GNU Emacs.
7867
7868 GNU Emacs is free software: you can redistribute it and/or modify
7869 it under the terms of the GNU General Public License as published by
7870 the Free Software Foundation, either version 3 of the License, or
7871 (at your option) any later version.
7872
7873 GNU Emacs is distributed in the hope that it will be useful,
7874 but WITHOUT ANY WARRANTY; without even the implied warranty of
7875 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7876 GNU General Public License for more details.
7877
7878 You should have received a copy of the GNU General Public License
7879 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.