src/w32font.c (w32_load_unicows_or_gdi32): Add missing return.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c20992f4
JB
12011-10-28 Juanma Barranquero <lekktu@gmail.com>
2
3 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4
db4f02f2
EZ
52011-10-28 Eli Zaretskii <eliz@gnu.org>
6
7 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
8 <oslsachem@gmail.com> for helping to debug this.
9
10 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
11 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
12 (g_b_init_get_glyph_outline_w): New static variables.
13 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
14 (GetGlyphOutlineW_Proc): New typedefs.
15 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
16 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font): New
17 functions.
18 (w32font_open_internal, compute_metrics): Call
19 get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
20 instead of calling the "wide" APIs directly.
21
22 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
23
24 * w32.h (syms_of_w32font): Add prototype.
25
87e68db4
JB
262011-10-27 Juanma Barranquero <lekktu@gmail.com>
27
28 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
29 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
30 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
31 (Fmove_to_window_line): Doc fix.
32
435c1d67
CY
332011-10-27 Chong Yidong <cyd@gnu.org>
34
35 * process.c (make_process): Set gnutls_state to NULL.
36
37 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
38 non-NULL, regardless of GNUTLS_INITSTAGE.
39 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
40 an error. Set process slots as soon as we allocate them.
41
42 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
43
9c6c6f49
CY
442011-10-27 Chong Yidong <cyd@gnu.org>
45
46 * gnutls.c (emacs_gnutls_deinit): New function. Deallocate
47 credentials structures as well as calling gnutls_deinit.
48 (Fgnutls_deinit, Fgnutls_boot): Use it.
49
50 * process.c (make_process): Initialize GnuTLS credentials to NULL.
51 (deactivate_process): Call emacs_gnutls_deinit.
52
657d08d3
JB
532011-10-27 Juanma Barranquero <lekktu@gmail.com>
54
55 * image.c (x_create_x_image_and_pixmap):
56 * w32.c (sys_rename, w32_delayed_load):
57 * w32font.c (fill_in_logfont):
58 * w32reg.c (x_get_string_resource): Silence compiler warnings.
59
5430d399
JB
602011-10-26 Juanma Barranquero <lekktu@gmail.com>
61
62 * w32fns.c (w32_default_color_map): New function,
63 extracted from Fw32_default_color_map.
a7ef684b 64 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 65
fe0055fa
PE
662011-10-25 Paul Eggert <eggert@cs.ucla.edu>
67
68 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
69
e6346438
SM
702011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
71
72 * keyboard.c (test_undefined): New function (bug#9751).
73 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
74
e112cc37
ET
752011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
76
77 * sysdep.c (init_sys_modes): Fix the check for the controlling
78 terminal (Bug#6649).
79
7b5d6677
EZ
802011-10-20 Eli Zaretskii <eliz@gnu.org>
81
82 * dispextern.h (struct bidi_it): New member next_en_type.
83
84 * bidi.c (bidi_line_init): Initialize the next_en_type member.
85 (bidi_resolve_explicit_1): When next_en_pos is valid for the
86 current character, check also for next_en_type being WEAK_EN.
87 (bidi_resolve_weak): Don't enter the expensive loop if the current
88 position is before next_en_pos. Record the bidi type of the first
89 non-ET, non-BN character we find, in addition to its position.
90 (bidi_level_of_next_char): Invalidate next_en_type when
91 next_en_pos is over-stepped.
92
7da0b018
PE
932011-10-20 Paul Eggert <eggert@cs.ucla.edu>
94
95 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
96 * editfns.c: Rewrite current-time-zone so that it invokes
97 the equivalent of (format-time-string "%Z") to get the time zone name.
98 This fixes a bug when the time zone name contains characters that
99 need converting from the system time locale to Emacs internal format.
100 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
101 that patch fixed format-time-string to do the conversion, but
102 I forgot to fix current-time-zone.
103 (format_time_string): New function, containing most of
104 what Fformat_time_string used to contain.
105 (Fformat_time_string): Rewrite in terms of format_time_string.
106 This doesn't change this function's behavior.
107 (current-time-zone): Rewrite to use format_time_string.
108 This fixes the bug reported by Michael Schierl in
109 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
110 Jason Rumney's 2007-06-07 change worked around this bug, but
111 didn't fix it.
112 * systime.h (tzname, timezone): Remove no-longer-used declarations.
113
8547b010
EZ
1142011-10-19 Eli Zaretskii <eliz@gnu.org>
115
116 * xdisp.c (start_display): If the character at POS is displayed
117 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
118 (try_window_reusing_current_matrix): If a line ends in a display
119 vector or the next line starts in a display vector, continue
120 redrawing the window even though the character position of
121 start_row was reached.
8547b010
EZ
122 (Bug#9771, part 2)
123
4e948d15
CY
1242011-10-18 Chong Yidong <cyd@gnu.org>
125
126 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
127 with nobreak-char-display too.
128
4787455f
EZ
1292011-10-18 Eli Zaretskii <eliz@gnu.org>
130
131 Fix part 3 of bug#9771.
132 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
133 (bidi_resolve_neutral): Don't enter the expensive loop looking for
134 non-neutral characters if the current character is a paragraph
135 separator (a.k.a. Newline). This avoids running the same
136 expensive loop twice, once when we consume the preceding newline
137 and the other time when the line actually needs to be displayed.
138 Avoid the loop when we see neutrals on the base embedding level
139 following a character whose directionality is the same as the
140 paragraph's. This avoids running the expensive loop when a line
141 ends in a long sequence of neutrals, like control characters.
142 Add assertion against STRONG_AL type. Slightly rearrange code
143 that determines the type of a neutral given the first non-neutral
144 that follows it.
145 (bidi_level_of_next_char): Set next_en_pos to zero when
146 invalidating its info.
147
2c91f553
EZ
1482011-10-17 Eli Zaretskii <eliz@gnu.org>
149
150 * xdisp.c (push_display_prop): Determine whether to record string
151 or buffer position by IT->string, not by IT->method. Allow
152 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
153 (move_it_vertically_backward): Don't look for character position
154 immediately after the newline when in a continuation line.
155 (Bug#9771, part 1)
2c91f553 156
c7b08b0d
MR
1572011-10-15 Martin Rudalics <rudalics@gmx.at>
158
159 * window.c (coordinates_in_window): Rewrite and delabelize
160 vertical border check. (Bug#5357) (Bug#9618)
161
6b02f655
SM
1622011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
163
164 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
165 errors in XSetWindowBorder (bug#9310).
166
81d40c92
DA
1672011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
168
169 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
170 avoid crash when xmalloc overrun checking is enabled.
171
d4172c3b
EZ
1722011-10-13 Eli Zaretskii <eliz@gnu.org>
173
174 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
175 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
176 cursor motion with <left> and <right> arrow keys.
177
178 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
179 some callers set that themselves.
180
b00eea75
EZ
1812011-10-12 Eli Zaretskii <eliz@gnu.org>
182
183 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
184 display string and the previous row comes from the same string and
185 is empty. (Bug#9739) (Bug#9738)
186
8fe012c4
SM
1872011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
188
189 * doc.c (get_doc_string): Encode file name (bug#9735).
190
0074aef2
EZ
1912011-10-12 Eli Zaretskii <eliz@gnu.org>
192
79beb178
EZ
193 * bidi.c (bidi_level_of_next_char):
194 * xdisp.c (get_visually_first_element): Remove old incorrect
195 comments regarding the Unicode Line Separator character.
196
0074aef2
EZ
197 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
198
6e4b3fbe
DA
1992011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
200
201 * alloc.c (Fgc_status): Do not access beyond zombies array
202 boundary if nzombies > MAX_ZOMBIES.
203 * alloc.c (dump_zombies): Add missing format specifier.
204
0324f3af
PE
2052011-10-12 Paul Eggert <eggert@cs.ucla.edu>
206
b5525cac
PE
207 * xdisp.c (set_cursor_from_row): Simplify conditionals,
208 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
209
0324f3af
PE
210 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
211 Some packages use them to denote characters with modifiers.
212
e9b5f888
AS
2132011-10-11 Andreas Schwab <schwab@linux-m68k.org>
214
215 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
216 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
217 matching a pp-number. Rename parameter var to var1.
218
127827c0
SM
2192011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
220
221 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
222
c8fd3bd0
GM
2232011-10-08 Glenn Morris <rgm@gnu.org>
224
225 * callint.c (Fcall_interactively): Give a more explicit error for the
226 'c' case with a non-character input. (Bug#8479)
227
352ec8ff
EZ
2282011-10-08 Eli Zaretskii <eliz@gnu.org>
229
03669ccb
EZ
230 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
231 lines.
7061c986
EZ
232 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
233 lines that are hscrolled on the left.
03669ccb 234
352ec8ff
EZ
235 * dispnew.c (buffer_posn_from_coords): Account for a possible
236 presence of header-line. (Bug#4426)
237
a66cfb1c
SM
2382011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
239
6b02f655
SM
240 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
241 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 242
7c5ee88e
PE
2432011-10-07 Paul Eggert <eggert@cs.ucla.edu>
244
245 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
246 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
247 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
248 this makes Emacs dump core during garbage collection on rare
249 occasions. sizeof is obviously inferior to offsetof here, so
250 stick with offsetof.
251 (GC_POINTER_ALIGNMENT): New macro.
252 (mark_memory): Omit 3rd (offset) arg; caller changed.
253 Don't assume EMACS_INT alignment is the same as pointer alignment.
254
df1bbe5b
SM
2552011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
256
257 * keyboard.c (read_key_sequence_remapped): New var.
258 (read_key_sequence): Compute remapping in the right buffer.
259 (command_loop_1): Use read_key_sequence's remapping directly.
260
51553db6
SM
2612011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
262
32c1fffd
SM
263 * dired.c (file_name_completion): Don't expand file name.
264 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
265 before checking file name handler.
266
51553db6
SM
267 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
268 they've been requested explicitly (bug#9591).
269
b6bd1599 2702011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
271
272 * keymap.c (Fsingle_key_description): Use make_specified_string
273 instead of build_string to build string from push_key_description.
274 (Bug#5193)
275
f701dc2a
PE
2762011-09-30 Paul Eggert <eggert@cs.ucla.edu>
277
4222c55d
PE
278 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
279 This fixes a Y2038 bug on 64-bit hosts.
280 * buffer.c (reset_buffer):
281 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
282 (Fclear_buffer_auto_save_failure):
283 Use 0, not -1, to represent an unset failure time, since time_t
284 might not be signed.
285
f701dc2a
PE
286 Remove dependency on glibc malloc internals.
287 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
288 Move back here from lisp.h, but with their new implementations.
289 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
290 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
291 * charset.c (charset_table_init): New static var.
292 (syms_of_charset): Use it instead of xmalloc. This removes a
293 dependency on glibc malloc internals. See Eli Zaretskii's comment in
294 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
295 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
296 Move back to alloc.c.
297 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
298 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
299
9ceebf39
JD
3002011-09-30 Jan Djärv <jan.h.d@swipnet.se>
301
302 * nsterm.m (windowDidResize): Call x_set_window_size only when
303 ns_in_resize is true. Otherwise set pixelwidth/height and
304 call change_frame_size (Bug#9628).
305
cb993c58
PE
3062011-09-30 Paul Eggert <eggert@cs.ucla.edu>
307
3930c88b
PE
308 Port --enable-checking=all to Fedora 14 x86-64.
309 * charset.c (syms_of_charset): Also account for glibc malloc's
310 internal overhead when calculating the initial malloc maximum.
311
cb993c58
PE
312 Port --enable-checking=all to Fedora 14 x86.
313 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
314 Move to lisp.h.
315 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
316 (overrun_check_realloc, overrun_check_free):
317 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
318 That way, xmalloc returns a properly-aligned pointer even if
319 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
320 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
321 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
322 into account when calculating the initial malloc maximum.
323 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
324 Move here from alloc.c, so that charset.c can use it too.
325 Properly align; the old code wasn't right for common 32-bit hosts
326 when configured with --enable-checking=all.
327 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
328 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
329
31bed486
EZ
3302011-09-29 Eli Zaretskii <eliz@gnu.org>
331
04c70788 332 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
333 use EDOM.
334
fbcaa2f3
EZ
3352011-09-28 Eli Zaretskii <eliz@gnu.org>
336
337 * xdisp.c (compute_display_string_end): If there's no display
338 string at CHARPOS, return -1.
339
340 * bidi.c (bidi_fetch_char): When compute_display_string_end
341 returns a negative value, treat the character as a normal
342 character not covered by a display string. (Bug#9624)
343
a239d4e9
JB
3442011-09-28 Juanma Barranquero <lekktu@gmail.com>
345
346 * lread.c (Fread_from_string): Fix typo in docstring.
347
88652fd5
EZ
3482011-09-27 Eli Zaretskii <eliz@gnu.org>
349
350 * xdisp.c (handle_invisible_prop): If invisible text ends on a
351 newline, reseat the iterator instead of bidi-iterating there one
352 character at a time. (Bug#9610)
32c1fffd
SM
353 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
354 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 355
ed497dd4
AS
3562011-09-27 Andreas Schwab <schwab@linux-m68k.org>
357
358 * lread.c (readevalloop): Use correct code for NBSP.
359 (read1): Likewise. (Bug#9608)
360
b2bf61aa
MA
3612011-09-25 Michael Albinus <michael.albinus@gmx.de>
362
363 * dbusbind.c (Fdbus_register_signal): When service is not
364 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
365
32bbb17c
GM
3662011-09-25 Glenn Morris <rgm@gnu.org>
367
368 * buffer.c (truncate-lines): Doc fix.
369
94e0933e
CY
3702011-09-24 Chong Yidong <cyd@stupidchicken.com>
371
372 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
373 (Fset_window_next_buffers): Doc fix.
374
cddde921
GM
3752011-09-24 Glenn Morris <rgm@gnu.org>
376
377 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
378
1260aef1
PE
3792011-09-24 Paul Eggert <eggert@cs.ucla.edu>
380
25b4bfa0
PE
381 Fix minor problems found by static checking.
382 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
383 * indent.c (Fvertical_motion): Fix == vs = typo.
384
e3cbd34b
EZ
3852011-09-24 Eli Zaretskii <eliz@gnu.org>
386
a66cfb1c
SM
387 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
388 Default value is now t. Doc fix.
6bf7006f 389
e3cbd34b 390 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 391 logic when moving up, not only when moving down. Fix the
e3cbd34b 392 confusing name and values of the it_overshoot_expected variable;
32c1fffd 393 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
394
395 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
396 CHARPOS is covered by a display string which includes newlines.
397 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
398 is covered by a display string with embedded newlines.
399
a3de0cbd
MA
4002011-09-24 Michael Albinus <michael.albinus@gmx.de>
401
402 * dbusbind.c (Fdbus_register_signal): Add match rule to
403 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
404 (Fdbus_register_method, Vdbus_registered_objects_table):
405 Fix docstring.
a3de0cbd 406
b260039d
JM
4072011-09-24 Jim Meyering <meyering@redhat.com>
408
32c1fffd 409 do not ignore write error for any output size
b260039d
JM
410 The previous change was incomplete.
411 While it makes emacs --batch detect the vast majority of stdout
412 write failures, errors were still ignored whenever the output size is
413 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
414 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
415 && echo FAIL: ignored write error
416 FAIL: ignored write error
417 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
418 && echo FAIL: ignored write error
419 FAIL: ignored write error
420 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
421
8eca8a7c
AS
4222011-09-23 Andreas Schwab <schwab@linux-m68k.org>
423
424 * emacs.c (Fkill_emacs): In noninteractive mode exit
425 non-successfully if a write error occurred on stdout. (Bug#9574)
426
3341db62
EZ
4272011-09-21 Eli Zaretskii <eliz@gnu.org>
428
429 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
430 the xassert test.
431
432 * dispextern.h (struct it): Update the comment documenting what
433 can it->OBJECT be.
434
8c203dbf
EZ
4352011-09-20 Eli Zaretskii <eliz@gnu.org>
436
437 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
438 a display string, extend search for cursor position to end of row.
439 (find_row_edges): If the row ends in a newline from a display
440 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
441 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
442 (Fcurrent_bidi_paragraph_direction): Fix search for previous
443 non-empty line. Fixes confusing cursor motion with arrow keys at
444 the beginning of a line that starts with whitespace.
8c203dbf 445
a4824228
LMI
4462011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
447
448 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
449 (bug#9493).
450
33ed493b
CY
4512011-09-18 Chong Yidong <cyd@stupidchicken.com>
452
453 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
454 boolean (Bug#9154).
455
56cd55c8
EZ
4562011-09-18 Eli Zaretskii <eliz@gnu.org>
457
458 * xdisp.c (display_line): Record maximum and minimum buffer
459 positions even if no glyphs were produced (e.g., by a zero-width
460 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
461 buffer positions that will be removed from the glyph row because
462 they don't fit.
c02dcedf
EZ
463 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
464 column is beyond frame width: don't subtract 1 "pixel" when
465 computing width of the stretch.
3e62b7e0
EZ
466 (reseat_at_next_visible_line_start): Undo the change made on
467 2011-09-17 that saved paragraph information and restored it after
468 the call to `reseat'. (Bug#9545)
56cd55c8 469
5ed99d36 4702011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
471
472 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
473 and turn window cursor on if cleared (Bug#9415).
474
5ed99d36 4752011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
476
477 * search.c (boyer_moore): Take unibyte characters from pattern
478 literally. (Bug#9458)
479
9bade7b2
EZ
4802011-09-18 Eli Zaretskii <eliz@gnu.org>
481
482 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
483
e5e9d610
PE
4842011-09-18 Paul Eggert <eggert@cs.ucla.edu>
485
87e4427a
PE
486 Fix minor problem found by static checking.
487 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
488 initialized, to pacify gcc -Wuninitialized.
489
e5e9d610
PE
490 * fileio.c: Report proper errno when syscall falls.
491 (Finsert_file_contents): Save and restore errno,
492 so that report_file_error outputs the correct diagnostic.
493 (Fwrite_region) [CLASH_DETECTION]: Likewise.
494
a1674f0b
EZ
4952011-09-18 Eli Zaretskii <eliz@gnu.org>
496
497 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
498
fbfb6dd4
EZ
4992011-09-17 Eli Zaretskii <eliz@gnu.org>
500
501 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
502 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
503
bb187662
EZ
5042011-09-17 Eli Zaretskii <eliz@gnu.org>
505
1137e8b8 506 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 507 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
508
509 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
510 (bidi_find_paragraph_start): Search back for paragraph beginning
511 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
512 (bidi_move_to_visually_next): Only trigger paragraph-related
513 computations when the last character is a newline or at EOB, not
514 just any NEUTRAL_B. (Bug#9470)
515
bb187662
EZ
516 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
517 truncated lines if point is covered by a display string. (Bug#9524)
518
2e621251
PE
5192011-09-16 Paul Eggert <eggert@cs.ucla.edu>
520
521 * xselect.c: Relax test for outgoing X longs (Bug#9498).
522 (cons_to_x_long): New function.
523 (lisp_data_to_selection_data): Use it. Correct the test for
524 short-versus-long data; it was negated. Break out of vector
525 loop, for efficiency, when a long datum is discovered.
526
91a15bc6
SM
5272011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
528
529 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
530
b41c3a35
EZ
5312011-09-16 Eli Zaretskii <eliz@gnu.org>
532
533 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
534 GCC PR/17406) by declaring this function with external scope.
535
7812ba2d
PE
5362011-09-15 Paul Eggert <eggert@cs.ucla.edu>
537
538 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
539 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
540
cf7edc2a
AS
5412011-09-15 Andreas Schwab <schwab@linux-m68k.org>
542
543 * editfns.c (Fformat): Correctly handle text properties on "%%".
544
bd01620e
EZ
5452011-09-15 Eli Zaretskii <eliz@gnu.org>
546
547 * xterm.c (x_draw_composite_glyph_string_foreground):
548 * w32term.c (x_draw_composite_glyph_string_foreground):
549 * term.c (encode_terminal_code):
550 * composite.c (composition_update_it, get_composition_id):
551 * xdisp.c (get_next_display_element)
552 (fill_composite_glyph_string): Add comments about special meaning
553 of TAB characters in a composition.
554
a02719a3
PE
5552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
556
557 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
558 This occurs when processing a multibyte format.
559 Problem reported by Wolfgang Jenker.
a02719a3 560
72589a3c
JB
5612011-09-15 Johan Bockgård <bojohan@gnu.org>
562
563 * xdisp.c (try_cursor_movement): Only check for exact match if
564 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
565
1c14176c
PE
5662011-09-14 Paul Eggert <eggert@cs.ucla.edu>
567
568 Remove unused external symbols.
569 * dispextern.h (calc_pixel_width_or_height): Remove decl.
570 * xdisp.c (calc_pixel_width_or_height): Now static.
571 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
572 * indent.c (check_display_width):
573 * w32term.c: Fix comment to match code.
574 * xterm.c, xterm.h (x_catching_errors): Remove.
575
d2eea5b5
PE
5762011-09-14 Paul Eggert <eggert@cs.ucla.edu>
577
578 * xselect.c: Use signed conversions more consistently (Bug#9498).
579 (selection_data_to_lisp_data): Assume incoming selection data are
580 signed integers, not unsigned. This is to be consistent with
581 outgoing selection data, which was modified to use signed integers
582 in as part of the fix to Bug#9196 in response to Jan D.'s comment
583 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
584 expects long, not unsigned long.
585
46888499
EZ
5862011-09-14 Eli Zaretskii <eliz@gnu.org>
587
588 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
589 computation of loop end. Reported by Johan Bockgård
590 <bojohan@gnu.org>.
591
ef8ef9fb
CY
5922011-09-13 Chong Yidong <cyd@stupidchicken.com>
593
594 * frame.c (Fother_visible_frames_p): Function deleted.
595
fa819fed
EZ
5962011-09-12 Eli Zaretskii <eliz@gnu.org>
597
598 * indent.c (compute_motion): Process display vector front to back
599 rather than the other way around. (Bug#2496)
600
2ba8e008
SM
6012011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
602
603 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
604
20f53c69
CY
6052011-09-11 Chong Yidong <cyd@stupidchicken.com>
606
607 * minibuf.c (Fread_from_minibuffer): Doc fix.
608
d562d7a4
EZ
6092011-09-11 Eli Zaretskii <eliz@gnu.org>
610
611 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
612 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
613
1c4d7f3d
LMI
6142011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
615
616 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
617 value for non-existent files.
618
b885bf36
EZ
6192011-09-11 Eli Zaretskii <eliz@gnu.org>
620
621 * fileio.c (Finsert_file_contents): If the file cannot be opened,
622 set its "size" to -1. This will set the modtime_size field of
623 the corresponding buffer to -1, which is what
624 verify-visited-file-modtime expects for files that do not exist.
625 (Bug#9139)
626
6612f0bf
PE
6272011-09-11 Paul Eggert <eggert@cs.ucla.edu>
628
629 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
630 here ...
631 * lisp.h: ... from here. push_key_description is no longer
632 defined in keyboard.c, so its declaration should not be in
633 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
634 logically belongs with push_key_description.
635
dfb3f755
PE
6362011-09-10 Paul Eggert <eggert@cs.ucla.edu>
637
638 * buffer.h: Include <sys/types.h> instead of <time.h>.
639 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
640 Problem reported by Herbert J. Skuhra.
641
3134906c
LMI
6422011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
643
644 * xml.c (parse_region): Make the parsing work for
645 non-comment-starting XML files again (bug#9144).
646
8d903f4e
AS
6472011-09-10 Andreas Schwab <schwab@linux-m68k.org>
648
649 * image.c (gif_load): Fix calculation of bottom and right corner.
650 (Bug#9468)
651
80ad64f4
EZ
6522011-09-10 Eli Zaretskii <eliz@gnu.org>
653
654 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
655 redisplay in small windows.
656
208a048d
EZ
6572011-09-09 Eli Zaretskii <eliz@gnu.org>
658
659 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
660
9b1c252e
MR
6612011-09-08 Martin Rudalics <rudalics@gmx.at>
662
663 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
664 Operate on live windows only.
665
2949f33b
JB
6662011-09-08 Juanma Barranquero <lekktu@gmail.com>
667
668 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
669
e08dcafd
EZ
6702011-09-07 Eli Zaretskii <eliz@gnu.org>
671
672 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
673 only under bidi iteration.
674
115b96bd
JD
6752011-09-07 Jan Djärv <jan.h.d@swipnet.se>
676
677 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
678
c8199d0f
PE
6792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
680
681 isnan: Fix porting problem to Solaris 10 with bundled gcc.
682 Without this fix, the command to link temacs failed due to an
683 undefined symbol __builtin_isnan. This is because
684 /usr/include/iso/math_c99.h #defines isnan(x) to
685 __builtin_isnan(x), but the bundled gcc, which identifies itself
686 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
687 a __builtin_isnan.
688 * floatfns.c (isnan): #undef, and then #define to a clone of
689 what's in data.c.
690 (Fisnan): Always define, since it's always available now.
691 (syms_of_floatfns): Always define isnan at the Lisp level.
692
e39b275c 6932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
694
695 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
696
b2db44d9 6972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 698
f4af5137 699 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
700 The previous code assumed that file offsets (off_t values) fit in
701 EMACS_INT variables, which is not true on typical 32-bit hosts.
702 The code messed up by falsely reporting buffer overflow in cases
703 such as (insert-file-contents "big" nil 1 2) into an empty buffer
704 when "big" contains more than 2**29 bytes, even though this
705 inserts just one byte and does not overflow the buffer.
706 (Finsert_file_contents): Store file offsets as off_t
707 values, not as EMACS_INT values. Check for overflow when
708 converting between EMACS_INT and off_t. When checking for
709 buffer overflow or for overlap, take the offsets into account.
710 Don't use EMACS_INT for small values where int suffices.
711 When checking for overlap, fix a typo: ZV was used where
712 ZV_BYTE was intended.
713 (Fwrite_region): Don't assume off_t fits into 'long'.
714 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
715
ecfc0a49
MA
7162011-09-05 Michael Albinus <michael.albinus@gmx.de>
717
718 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
719
6511acf2 7202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 721
0999621a 722 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
723
724 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 725 (esprintf, exprintf, evxprintf): New functions.
62f19c19 726 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 727 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
728 (modify_event_symbol): Do not assume that the length of
729 name_alist_or_stem is safe to alloca and fits in int.
730 (Fexecute_extended_command): Likewise for function name and binding.
731 (Frecursion_depth): Wrap around reliably on integer overflow.
732 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
733 since some callers pass EMACS_INT values.
734 (Fsingle_key_description): Don't crash if symbol name contains more
735 than MAX_ALLOCA bytes.
736 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
737 (get_minibuffer): Arg is now EMACS_INT, not int.
738 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 739 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
740 * window.h (command_loop_level, minibuf_level): Reflect API changes.
741
2be7d702
PE
742 * dbusbind.c (signature_cat): New function.
743 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
744 Do not overrun buffer; instead, report string overflow.
745
9d1df220
PE
746 * dispnew.c (add_window_display_history): Don't overrun buffer.
747 Truncate instead; this is OK since it's just a log.
748
33ef5c64
PE
749 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
750 even if the time zone offset is outlandishly large.
751 Don't mishandle offset == INT_MIN.
752
66c6fdd5
PE
753 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
754 when creating daemon; the previous buffer-overflow check was incorrect.
755
d749b01b
PE
756 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
757 which has the guts of the old verror function.
758
b5cd1905
PE
759 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
760 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
761
6e1a67fb
PE
762 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
763 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 764 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 765 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
766 length of string rather than counting it via multiple sprintfs;
767 that's simpler and more reliable.
c21721cc
PE
768 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
769 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
770 sprintf, in case result does not fit in int.
771
c57b67fc
PE
772 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
773 (fontset_from_font): Print it.
774
8a401434
PE
775 * frame.c (tty_frame_count): Now printmax_t, not int.
776 (make_terminal_frame, set_term_frame_name): Print it.
777 (x_report_frame_params): In X, window IDs are unsigned long,
778 not signed long, so print them as unsigned.
779 (validate_x_resource_name): Check for implausibly long names,
780 and don't assume name length fits in 'int'.
781 (x_get_resource_string): Don't blindly alloca invocation name;
782 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
783 not fit in int.
784
6e1a67fb
PE
785 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
786 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
787 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
788
0df02bf3
PE
789 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
790 Use esprintf, not sprintf, in case result does not fit in int.
791
48e30793
PE
792 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
793 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
794 it as a large positive number.
795 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
796 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
797
a66ff6d8
PE
798 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
799 in case result does not fit in int.
800
aca216ff
PE
801 * print.c (float_to_string): Detect width overflow more reliably.
802 (print_object): Make sprintf buffer a bit bigger, to avoid potential
803 buffer overrun. Don't assume list length fits in 'int'. Treat
804 print length of 0 as 0, not as infinity; to be consistent with other
805 uses of print length in this function. Don't overflow print length
806 index. Don't assume hash table size fits in 'long', or that
807 vectorlike size fits in 'unsigned long'.
808
31c286f7
PE
809 * process.c (make_process): Use printmax_t, not int, to format
810 process-name gensyms.
811
55e5faa1
PE
812 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
813
80f2e268
PE
814 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
815 to avoid potential buffer overrun.
816
670741ab
PE
817 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
818 if X resource line is longer than 512 bytes.
819
b7163a50
PE
820 * xfns.c (x_window): Make sprintf buffer a bit bigger
821 to avoid potential buffer overrun.
822
ae58ff1f
PE
823 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
824
c43c8a6a
PE
825 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
826
3f8236f4
PE
8272011-09-04 Paul Eggert <eggert@cs.ucla.edu>
828
53e9fe90 829 Integer overflow fixes for scrolling, etc.
6511acf2
PE
830 Without these, Emacs silently mishandles large integers sometimes.
831 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
832 it were "C-u 1 M-x recenter" on a typical 64-bit host.
833
6511acf2
PE
834 * xdisp.c (try_window_id): Check Emacs fixnum range before
835 converting to 'int'.
806add1d 836
6511acf2 837 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
838 Check that an Emacs fixnum is in range before assigning it to 'int'.
839 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
840 values converted from Emacs fixnums.
841 (Frecenter): Don't wrap around a line count if it is out of 'int'
842 range; instead, treat it as an extreme value.
843 (Fset_window_configuration, compare_window_configurations):
844 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
845
6511acf2
PE
846 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
847 that can exceed INT_MAX. Check that EMACS_INT value is in range
848 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
849 (match_limit): Don't assume that a fixnum can fit in 'int'.
850
6511acf2 851 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
852 exceed INT_MAX.
853
6511acf2 854 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
855 (Fvertical_motion): Don't wrap around LINES values that don't fit
856 in 'int'. Instead, treat them as extreme values. This is good
857 enough for windows, which can't have more than INT_MAX lines anyway.
858
fcb901a7
LMI
8592011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
860
0f2f6b6d
LMI
861 * Require libxml/parser.h to avoid compilation warning.
862
fcb901a7
LMI
863 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
864
865 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
866 since this reportedly can destroy thread storage.
867
6e20a0d4
CY
8682011-08-30 Chong Yidong <cyd@stupidchicken.com>
869
870 * syntax.c (find_defun_start): Update all cache variables if
871 exiting early (Bug#9401).
872
148ae00e
EZ
8732011-08-30 Eli Zaretskii <eliz@gnu.org>
874
f6cfbd8f
EZ
875 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
876
148ae00e
EZ
877 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
878 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
879 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
880
881 * term.c (tty_append_glyph): New function.
882 (produce_stretch_glyph): Static function and its prototype deleted.
883
a66cfb1c
SM
884 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
885 Add prototypes.
148ae00e 886
c4a07a4c
PE
8872011-08-29 Paul Eggert <eggert@cs.ucla.edu>
888
889 * image.c (parse_image_spec): Check for nonnegative, not for positive,
890 when checking :margin (Bug#9390).
891 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 892 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
893 so that the name doesn't mislead. All uses changed.
894
6bc8cd65
JB
8952011-08-28 Johan Bockgård <bojohan@gnu.org>
896
897 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
898 set_tty_hooks.
899
dca4927e
EZ
9002011-08-27 Eli Zaretskii <eliz@gnu.org>
901
902 * xdisp.c (move_it_to): Don't bail out early when reaching
903 position beyond to_charpos, if we are scanning backwards.
904 (move_it_vertically_backward): When DY == 0, make sure we get to
905 the first character in the line after the newline.
906
f2cad773
PE
9072011-08-27 Paul Eggert <eggert@cs.ucla.edu>
908
909 * ccl.c: Improve and simplify overflow checking (Bug#9196).
910 (ccl_driver): Do not generate an out-of-range pointer.
911 (Fccl_execute_on_string): Remove unnecessary check for
912 integer overflow, noted by Stefan Monnier in
913 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
914 Remove a FIXME that didn't need fixing.
915 Simplify the newly-introduced buffer reallocation code.
916
0cae2cdb
JB
9172011-08-27 Juanma Barranquero <lekktu@gmail.com>
918
919 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
920
5fc295a4 9212011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 922
70c60eb2 923 Integer and memory overflow issues (Bug#9196).
726e0ab1 924
d31850da
PE
925 * doc.c (get_doc_string): Rework so that
926 get_doc_string_buffer_size is the actual buffer size, rather than
927 being 1 less than the actual buffer size; this makes xpalloc more
928 convenient.
929
a69fbedb
PE
930 * image.c (x_allocate_bitmap_record, cache_image):
931 * xselect.c (Fx_register_dnd_atom):
932 Simplify previous changes by using xpalloc.
933
fe5c5d37
PE
934 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
935 since either will do and ptrdiff_t is convenient with xpalloc.
936
0065d054
PE
937 * charset.c (charset_table_size)
938 (struct charset_sort_data.priority): Now ptrdiff_t.
939 (charset_compare): Don't overflow if priorities differ greatly.
940 (Fsort_charsets): Don't assume list length fits in int.
941 Check for size-calculation overflow when allocating sort data.
942 (syms_of_charset): Allocate an initial charset table that is
943 just under 64 KiB, to avoid problems with glibc malloc and mmap.
944
945 * cmds.c (internal_self_insert): Check for size-calculation overflow.
946
947 * composite.h (struct composition.glyph_len): Now int, not unsigned.
948 The actual value is always <= INT_MAX, and leaving it unsigned made
949 overflow checking harder.
950
951 * dispextern.h (struct glyph_matrix.rows_allocated)
952 (struct face_cache.size): Now ptrdiff_t, for convenience in use
953 with xpalloc. The values are still always <= INT_MAX.
954
955 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
956
957 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
958 (SAFE_NALLOCA): New macro.
959
960 * region-cache.c (struct boundary.pos, find_cache_boundary)
961 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
962 (set_cache_region, invalidate_region_cache)
963 (revalidate_region_cache, know_region_cache, region_cache_forward)
964 (region_cache_backward, pp_cache):
965 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
966 so that ptrdiff_t * can be passed to xpalloc.
967 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
968 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
969 (pp_cache): Don't assume cache_len fits in int.
970 * region-cache.h: Adjust extern decls to match.
971
972 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
973 EMACS_INT, since either will do, for xpalloc.
974
975 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
976 (xnmalloc, xnrealloc, xpalloc): New functions.
977
726e0ab1
PE
978 * bidi.c (bidi_shelve_header_size): New constant.
979 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
980 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
981
51f30bc5 982 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
983 * buffer.c (overlays_at, overlays_in, record_overlay_string)
984 (overlay_strings):
985 Don't update size of array until after memory allocation succeeds,
986 because xmalloc/xrealloc may not return.
0065d054
PE
987 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
988 now that we have proper integer overflow checking.
989 (record_overlay_string, overlay_strings): Catch overflows when
990 calculating size of overlay_str_buf.
726e0ab1 991
0065d054
PE
992 * callproc.c (Fcall_process): Check for size overflow when
993 calculating size of args2.
994 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
995 Normally we prefer signed values, but sticking with ptrdiff_t would
996 require adding more-complicated checks.
726e0ab1
PE
997
998 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
999 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1000 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1001 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1002
1003 * character.c (Fstring): Check for size-calculation overflow.
1004
1005 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1006 unnecessary integer overflow. Check for size overflow.
1007 (encode_coding_object): Don't update size until xmalloc succeeds.
1008
1009 * composite.c (get_composition_id): Check for overflow in glyph
1010 length calculations.
1011
1012 Integer and memory overflow fixes for display code.
1013 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1014 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1015 (scrolling_window): Check for overflow in size calculations.
1016 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1017 Don't assume glyph table len fits in int.
1018 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1019 (row_table_size): Now ptrdiff_t, not int.
1020 (scrolling_window): Avoid overflow in size calculations.
1021 Don't update size until allocation succeeds.
1022 * fns.c (concat): Check for overflow in size calculations.
1023 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1024 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1025 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1026
1027 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1028 (get_doc_string): Check for size calculation overflow.
1029 Don't update size until allocation succeeds.
1030 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1031 EMACS_INT, where ptrdiff_t will do.
1032 (Fsubstitute_command_keys): Check for string overflow.
1033
1034 * editfns.c (set_time_zone_rule): Don't assume environment length
1035 fits in int.
1036 (message_length): Now ptrdiff_t, not int.
1037 (Fmessage_box): Don't update size until allocation succeeds.
1038 Don't assume message length fits in int.
1039 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1040
0065d054
PE
1041 * emacs.c (main): Do not reallocate argv, since there is a null at
1042 the end that can be overwritten, and this way there's no need to
1043 worry about size-calculation overflow.
1044 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1045
1046 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1047 alloc succeeds.
1048 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1049
1050 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1051 (x_set_scroll_bar_width, x_figure_window_size):
1052 Check for integer overflow.
1053 (x_set_alpha): Do not assume XINT fits in int.
1054
1055 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1056 This is for the members text_lines, text_cols, total_lines, total_cols,
1057 where the system imposes an 'int' limit.
1058
1059 * fringe.c (Fdefine_fringe_bitmap):
1060 Don't update size until alloc works.
1061
1062 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1063 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1064
1065 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1066 Check for size-calculation overflow.
1067 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1068 do, as we prefer signed integers.
1069 (id_to_widget.max_size, id_to_widget.used)
1070 (xg_store_widget_in_map, xg_remove_widget_from_map)
1071 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1072 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1073 Use and return ptrdiff_t, not int.
1074 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1075 * gtkutil.h: Change prototypes to match the above.
1076
1077 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1078 are duplicate now that they've been promoted to lisp.h.
1079 (x_allocate_bitmap_record, x_alloc_image_color)
1080 (make_image_cache, cache_image, xpm_load):
1081 Don't update size until alloc is done.
1082 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1083 (x_detect_edges):
3256efce 1084 Check for size calculation overflow.
726e0ab1
PE
1085 (ct_colors_allocated_max): New constant.
1086 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1087 overflow.
3256efce 1088
726e0ab1
PE
1089 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1090 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1091 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1092 Use ptrdiff_t, not int, to count maps.
1093 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1094 calculations. Don't update size until allocation succeeds.
1095 Redo calculations to avoid overflow.
726e0ab1
PE
1096 * keyboard.h: Change prototypes to match the above.
1097
1098 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1099 to count maps.
1100 (current_minor_maps): Check for size calculation overflow.
1101 * keymap.h: Change prototypes to match the above.
1102
1103 * lread.c (read1, init_obarray): Don't update size until alloc done.
1104
1105 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1106 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1107
726e0ab1
PE
1108 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1109 Now ptrdiff_t, not int.
1110 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1111 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1112
1113 * process.c (Fnetwork_interface_list): Check for overflow
1114 in size calculation.
1115
1116 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1117
1118 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1119 overflow. Don't bother calling xmalloc when xrealloc will do.
1120
1121 * search.c (Freplace_match): Check for size calculation overflow.
1122 (Fset_match_data): Don't assume list lengths fit in 'int'.
1123
1124 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1125 for command line length. Do not attempt to address one before the
1126 beginning of an array, as that's not portable.
1127
1128 * term.c (max_frame_lines): Remove; unused.
1129 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1130 not int.
1131 (encode_terminal_code, calculate_costs): Check for size
1132 calculation overflow.
1133 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1134 table lengths and related sizes. Don't update size until alloc
1135 done. Redo calculations to avoid overflow.
1136 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1137
1138 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1139 subtracting pointers.
1140 (gobble_line): Check for overflow more carefully. Don't update size
1141 until alloc done.
1142
1143 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1144 Don't update size until alloc done.
1145 Redo size calculations to avoid overflow.
1146 Check for size calculation overflow.
0065d054 1147 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1148
1149 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1150 Use ptrdiff_t, not int, for sizes.
1151 (store_mode_line_noprop_char): Don't update size until alloc done.
1152
0065d054
PE
1153 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1154 Use ptrdiff_t, not int, for sizes.
1155 (Finternal_make_lisp_face, cache_face):
1156 Check for size calculation overflow.
1157 (cache_face): Treat size calculation overflows as if they were
1158 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1159
1160 * xfns.c (x_encode_text, x_set_name_internal)
1161 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1162 sizes, since they can exceed INT_MAX in size. Check for size
1163 calculation overflow.
1164
0065d054
PE
1165 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1166 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1167 Don't update size until alloc done.
1168
0065d054 1169 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1170 as sprintf is limited to int lengths.
1d526e2f 1171
252c5ee1
PE
1172 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1173 (X_LONG_MIN): New macros.
864d7ce7
PE
1174 Use them to make the following changes clearer.
1175 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1176 This change doesn't affect the value now, but it may help remind
1177 future maintainers not to raise the value too much later.
1178 (SELECTION_QUANTUM): Remove, replacing with ...
1179 (selection_quantum): ... new function, which avoids overflow.
1180 All uses changed.
1181 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1182 assumption that selection length fits in 'int'.
1183 (x_reply_selection_request, x_handle_selection_request)
1184 (x_get_window_property, receive_incremental_selection)
1185 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1186 (lisp_data_to_selection_data, clean_local_selection_data):
1187 Use ptrdiff_t, not int, to record length of selection.
1188 (x_reply_selection_request, x_get_window_property)
1189 (receive_incremental_selection, x_property_data_to_lisp):
1190 Redo calculations to avoid overflow.
1191 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1192 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1193 something.
1194 (x_get_window_property, receive_incremental_selection)
1195 (lisp_data_to_selection_data, x_property_data_to_lisp):
1196 Check for size-calculation overflow.
1197 (x_get_window_property, receive_incremental_selection)
1198 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1199 Don't store size until memory allocation succeeds.
1200 (x_get_window_property): Plug memory leak on memory exhaustion.
1201 Don't double-block input; malloc is safe here. Don't assume 2**34
1202 - 4 fits in unsigned long. Add an xassert to check
1203 XGetWindowProperty overflow. Be more careful about overflow
1204 calculations, and distinguish size from memory overflow better.
1205 (receive_incremental_selection): When tracing, don't assume
1206 unsigned int is less than INT_MAX.
1207 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1208 harmful) conversions of unsigned short to int.
1209 (lisp_data_to_selection_data): Don't assume that integers
1210 in the range -65535 through -1 fit in an X unsigned short.
1211 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1212 result parameters unless successful. Rely on cons_to_unsigned
1213 to report problems with elements; the old code wasn't right anyway.
1214 (x_check_property_data): Check for int overflow; we cannot use
1215 a wider type due to X limits.
1216 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1217
726e0ab1 1218 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1219
0065d054
PE
1220 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1221 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1222 (x_color_cells): Don't store size until memory allocation succeeds.
1223 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1224 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1225 (x_term_init): Don't assume length fits in int (sprintf is limited
1226 to int size).
bc18e09d 1227
ebfa62c0
PE
1228 Use ptrdiff_t for composition IDs.
1229 * character.c (lisp_string_width):
1230 * composite.c (composition_table_size, n_compositions)
1231 (get_composition_id, composition_gstring_from_id):
1232 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1233 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1234 * window.c (Frecenter):
1235 Use ptrdiff_t, not int, for composition IDs.
1236 * composite.c (get_composition_id): Check for integer overflow.
1237 * composite.h: Adjust prototypes to match the above changes.
1238
d3411f89
PE
1239 Use ptrdiff_t for hash table indexes.
1240 * category.c (hash_get_category_set):
1241 * ccl.c (ccl_driver):
1242 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1243 * coding.c (coding_system_charset_list, detect_coding_system):
1244 * coding.h (struct coding_system.id):
1245 * composite.c (get_composition_id, gstring_lookup_cache):
1246 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1247 * image.c (xpm_get_color_table_h):
1248 * lisp.h (hash_lookup, hash_put):
1249 * minibuf.c (Ftest_completion):
1250 Use ptrdiff_t for hash table indexes, not int (which is too
1251 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1252 32-bit --with-wide-int hosts).
1253
e097a6fa
PE
1254 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1255 Add a FIXME comment about memory leaks.
1256 (syms_of_charset): Don't assume xmalloc returns.
1257
5637687f
PE
1258 Don't assume that stated character widths fit in int.
1259 * character.c (Fchar_width, c_string_width, lisp_string_width):
1260 * character.h (CHAR_WIDTH):
1261 * indent.c (MULTIBYTE_BYTES_WIDTH):
1262 Use sanitize_char_width to avoid undefined and/or bad behavior
1263 with outlandish widths.
a66cfb1c 1264 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1265 now that we have two such functions. All uses changed.
1266 (sanitize_char_width): New inline function.
1267
a2271ba2
PE
1268 Don't assume that tab-width fits in int.
1269 * character.h (sanitize_width): New inline function.
1270 (SANE_TAB_WIDTH): New macro.
1271 (ASCII_CHAR_WIDTH): Use it.
1272 * indent.c (sane_tab_width): Remove. All uses replaced by
1273 SANE_TAB_WIDTH (current_buffer).
1274 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1275
18c52557
PE
1276 * fileio.c: Integer overflow issues with file modes.
1277 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1278
caeeedc1
PE
1279 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1280 Remove unreachable code.
1281 (read_hex, load_charset_map_from_file): Check for integer overflow.
1282
50849c52
PE
1283 * xterm.c: don't go over XClientMessageEvent limit
1284 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1285 (x_send_scroll_bar_event): Likewise. Check that the size does not
1286 exceed limits imposed by XClientMessageEvent, as well as the usual
1287 ptrdiff_t and size_t limits.
1288
b13995db
PE
1289 * keyboard.c: Overflow, signedness and related fixes.
1290 (make_lispy_movement): Use same integer type in forward decl
1291 that is used in the definition.
1292 (read_key_sequence, keyremap_step):
1293 Change bufsize argument back to int, undoing my 2011-03-30 change.
1294 We prefer signed types, and int is wide enough here.
1295 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1296 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1297 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1298 length, not size_t. Use ptrdiff_t for index, not int.
1299 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1300 possibility of integer overflow.
1301
13464394
PE
1302 Overflow, signedness and related fixes for images.
1303
1304 * dispextern.h (struct it.stack[0].u.image.image_id)
1305 (struct_it.image_id, struct image.id, struct image_cache.size)
1306 (struct image_cache.used, struct image_cache.ref_count):
1307 * gtkutil.c (update_frame_tool_bar):
1308 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1309 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1310 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1311 * nsmenu.m (update_frame_tool_bar):
1312 * xdisp.c (calc_pixel_width_or_height):
1313 * xfns.c (image_cache_refcount):
1314 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1315 on typical 64-bit hosts.
1316
1317 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1318 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1319 Omit unnecessary casts to int.
1320 (parse_image_spec): Check that integers fall into 'int' range
1321 when the callers expect that.
1322 (image_ascent): Redo ascent calculation to avoid int overflow.
1323 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1324 (lookup_image): Remove unnecessary tests.
1325 (xbm_image_p): Locals are now of int, not EMACS_INT,
1326 since parse_image_check makes sure they fit into int.
1327 (png_load, gif_load, svg_load_image):
1328 Prefer int to unsigned where either will do.
1329 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1330 old tiff_error_handler and tiff_warning_handler.
1331 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1332 stack buffer overflows. It uses only the features of vsnprintf
1333 that are common to both POSIX and native Microsoft.
1334 (tiff_error_handler, tiff_warning_handler): Use it.
1335 (tiff_load, gif_load, imagemagick_load_image):
1336 Don't assume :index value fits in 'int'.
1337 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1338 (imagemagick_load_image): Check that crop parameters fit into
1339 the integer types that MagickCropImage accepts. Don't assume
1340 Vimagemagick_render_type has a nonnegative value. Don't assume
1341 size_t fits in 'long'.
1342 (gs_load): Use printmax_t to print the widest integers possible.
1343 Check for integer overflow when computing image height and width.
1344
c11821d4
EZ
13452011-08-26 Eli Zaretskii <eliz@gnu.org>
1346
1347 * xdisp.c (redisplay_window): Don't force window start if point
1348 will be invisible in the resulting window. (Bug#9324)
1349
0c95fcf7
EZ
13502011-08-25 Eli Zaretskii <eliz@gnu.org>
1351
1352 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1353 the display spec is of the form `(space ...)'.
1354 (handle_display_spec): Return the value returned by
1355 handle_single_display_spec, not just 1 or zero.
1356 (handle_single_display_spec): If the display spec is of the form
1357 `(space ...)', and specifies display in the text area, return 2
1358 rather than 1.
fee65a97 1359 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1360 accurately, and prefer exact match for point under bidi.
1361 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1362
1363 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1364 into disp_prop; all users changed.
1365
1366 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1367 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1368 for the text covered by the display property.
1369
e4ed06f1
CY
13702011-08-25 Chong Yidong <cyd@stupidchicken.com>
1371
1372 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1373 Change return value to nil.
1374 (Frecord_buffer): Delete unused function.
1375
f67cdd7f
EZ
13762011-08-24 Eli Zaretskii <eliz@gnu.org>
1377
5980d4c6
EZ
1378 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1379 buffers, return left-to-right.
8610fe8b
EZ
1380 (set_cursor_from_row): Consider candidate row a win if its glyph
1381 represents a newline and point is on that newline. Fixes cursor
1382 positioning on the newline at EOL of R2L text within L2R
1383 paragraph, and vice versa.
1384 (try_cursor_movement): Check continued rows, in addition to
1385 continuation rows. Fixes unwarranted scroll when point enters a
1386 continued line of R2L text within an L2R paragraph, or vice versa.
1387 (cursor_row_p): Consider the case of point being equal to
1388 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1389 from the end of a short line to the beginning of a continued line
1390 of R2L text within L2R paragraph.
1391 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1392 composed characters.
5980d4c6 1393
f67cdd7f
EZ
1394 * bidi.c (bidi_check_type): Use xassert.
1395 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1396 members.
1397
bca633fb
EZ
13982011-08-23 Eli Zaretskii <eliz@gnu.org>
1399
1400 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1401 a character.
1402
4a5885a7
CY
14032011-08-23 Chong Yidong <cyd@stupidchicken.com>
1404
1405 * nsfont.m (ns_otf_to_script): Fix typo.
1406
0902a04e
KH
14072011-08-22 Kenichi Handa <handa@m17n.org>
1408
1409 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1410 extra slot even if the purpose is char-code-property-table.
1411
1a2e6670
EZ
14122011-08-23 Eli Zaretskii <eliz@gnu.org>
1413
8ddde651
EZ
1414 * xdisp.c (redisplay_window): When computing centering_position,
1415 account for the height of the header line. (Bug#8874)
1416
425cc014
EZ
1417 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1418 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1419 candidate is selected by the mouse, and that candidate has a
1420 composed character under the mouse.
1421
1a2e6670
EZ
1422 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1423 coordinates reported by pos-visible-in-window-p for a composed
1424 character in column zero.
1425
8b76d6f8
SM
14262011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1427
1428 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1429
dac347dd
EZ
14302011-08-22 Eli Zaretskii <eliz@gnu.org>
1431
1432 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1433 consider it a hit if to_charpos is anywhere in the range of the
1434 composed buffer positions.
1435
e013fb34
CY
14362011-08-22 Chong Yidong <cyd@stupidchicken.com>
1437
1438 * image.c (gif_load): Don't assume that each subimage has the same
1439 dimensions as the base image. Handle disposal method that is
1440 "undefined" by the gif spec (Bug#9335).
1441
bd1ba3e8
CY
14422011-08-20 Chong Yidong <cyd@stupidchicken.com>
1443
1444 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1445 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1446
54a1215b
EZ
14472011-08-19 Eli Zaretskii <eliz@gnu.org>
1448
823564e5
EZ
1449 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1450 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1451 from an Org mode buffer to a Speedbar frame.
1452
54a1215b
EZ
1453 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1454 a composition, take its buffer position from IT->cmp_it.charpos.
1455 Fixes cursor positioning at the beginning of a line that begins
1456 with a composed character.
1457
9778ebcc
EZ
14582011-08-18 Eli Zaretskii <eliz@gnu.org>
1459
0be6ee06
EZ
1460 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1461 character bidirectional type, use STRONG_L instead. Fixes crashes
1462 in a buffer produced by `describe-categories'.
1463
9778ebcc
EZ
1464 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1465 members before the level stack, so they would be saved and
1466 restored when copying iterator state. Fixes incorrect reordering
1467 around TABs covered by display properties.
1468
156bffbe
AS
14692011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1470
6b02f655 1471 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1472
72ad093b
CY
14732011-08-17 Chong Yidong <cyd@stupidchicken.com>
1474
1475 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1476 (internal_condition_case_2, internal_condition_case_n):
1477 Remove unnecessary aborts (Bug#9081).
72ad093b 1478
35774242
EZ
14792011-08-17 Eli Zaretskii <eliz@gnu.org>
1480
1481 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1482 has no `load' handler, try opening the file locally. (Bug#9311)
1483
db76dd85
KB
14842011-08-16 Ken Brown <kbrown@cornell.edu>
1485
1486 * gmalloc.c: Expand comment.
1487
b215eee5
EZ
14882011-08-16 Eli Zaretskii <eliz@gnu.org>
1489
1490 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1491 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1492
a4579d33
KB
14932011-08-16 Ken Brown <kbrown@cornell.edu>
1494
1495 Fix memory allocation problems in Cygwin build (Bug#9273).
1496
1497 * unexcw.c ( __malloc_initialized): Declare external variable.
1498 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1499
8b76d6f8
SM
1500 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1501 New variables.
a4579d33
KB
1502 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1503 dumped emacs.
1504 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1505 in the static heap.
1506 [CYGWIN] (special_realloc): New function.
1507 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1508 requests to realloc storage in the static heap.
1509
3ebec551
PE
15102011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1511
1512 * bidi.c (bidi_initialize): Remove unused local.
1513
9fd8be00
EZ
15142011-08-15 Eli Zaretskii <eliz@gnu.org>
1515
6b02f655
SM
1516 * bidimirror.h:
1517 * biditype.h: Remove file.
1518 * makefile.w32-in ($(BLD)/bidi.$(O)):
1519 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1520
1521 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1522
1523 * chartab.c: Improve commentary for the uniprop_table API.
1524
32413314
EZ
1525 * bidi.c (bidi_paragraph_init): Support zero value of
1526 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1527 (bidi_initialize): Use uniprop_table instead of including
1528 biditype.h and bidimirror.h.
32413314 1529
9fd8be00
EZ
1530 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1531 coordinates of the iterator when restoring from ppos_it.
1532 (Bug#9296)
1533
5cf2b69b
KH
15342011-08-14 Kenichi Handa <handa@m17n.org>
1535
1536 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1537 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1538
daf17d00
EZ
15392011-08-14 Eli Zaretskii <eliz@gnu.org>
1540
1541 * xdisp.c (move_it_in_display_line_to): Don't invoke
1542 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1543 ppos_it. Fixes vertical cursor motion when line beginning is
1544 covered by an image. (Bug#9296)
1545
08e3161a
JD
15462011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1547
1548 * nsterm.h (ns_run_ascript): Declare.
1549 (NSAPP_DATA2_RUNASSCRIPT): Define.
1550
1551 * nsfns.m (as_script, as_result, as_status): New static variables.
1552 (ns_run_ascript): New function.
5e617bc2 1553 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1554 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1555 the event loop. Get status from as_status (Bug#7276).
1556
1557 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1558 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1559 the event loop (Bug#7276).
1560
a3720aa2
AS
15612011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1562
1563 * gnutls.c (QCgnutls_bootprop_priority)
1564 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1565 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1566 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1567 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1568 (QCgnutls_bootprop_verify_hostname_error)
1569 (QCgnutls_bootprop_callbacks_verify): Rename from
1570 Qgnutls_bootprop_..., all uses changed.
1571
1572 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1573 uses changed.
1574
0a0d27fb
PE
15752011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1576
19d5c50c
PE
1577 * xfaces.c (Qframe_set_background_mode): Now static.
1578 * dispextern.h (Qframe_set_background_mode): Remove decl.
1579
0a0d27fb
PE
1580 * process.c (Fnetwork_interface_info): Declare local only if needed.
1581
377538cb
JD
15822011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1583
1584 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1585 (Fnetwork_interface_list): Allocate in increments of bytes instead
1586 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1587 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1588 sockaddr.
1589 (struct ifflag_def): notrailers is smart on OSX.
1590 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1591 Get hardware address with getifaddrs if available.
1592
08fff70c
EZ
15932011-08-12 Eli Zaretskii <eliz@gnu.org>
1594
1595 * xdisp.c (iterate_out_of_display_property): xassert that
1596 IT->position is set to within IT->object's boundaries. Break from
1597 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1598 when IT->position is set up wrongly due to some bug.
1599 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1600 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1601 entry. Force push_it to save on the stack the current
1602 buffer/string position, to be restored by pop_it. Fix flags in
1603 the iterator structure wrt the object coming from a display
1604 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1605 properties. (Bug#9284)
1606
7be1c708 16072011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1608
7be1c708
CY
1609 * fontset.c (fontset_get_font_group): Add proper type checks.
1610 (Bug#9172)
aac0c6e3 1611
7be1c708 16122011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1613
7be1c708
CY
1614 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1615 and LC_VERSION_MIN_MACOSX.
1616 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1617 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1618
97bb72a6
EZ
16192011-08-08 Eli Zaretskii <eliz@gnu.org>
1620
1621 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1622 no-display-properties-and-no-overlays under bidi display.
1623 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1624 properties and overlays.
97bb72a6 1625
d5617611
CY
16262011-08-08 Chong Yidong <cyd@stupidchicken.com>
1627
37e11a63
CY
1628 * editfns.c (Fset_time_zone_rule): Document relationship with the
1629 setenv function.
1630
d5617611
CY
1631 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1632 the font entity extracted from the cache (Bug#8109).
1633
58872834
CY
16342011-08-07 Chong Yidong <cyd@stupidchicken.com>
1635
1636 * composite.c (autocmp_chars): Don't reset point. That is done by
1637 restore_point_unwind (Bug#5984).
1638
75bfc667
JL
16392011-08-07 Juri Linkov <juri@jurta.org>
1640
1641 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1642 to show the arg `TIME' instead of `TIMEVAL'.
1643
d1410150
EZ
16442011-08-06 Eli Zaretskii <eliz@gnu.org>
1645
1646 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1647 display property strides EOL and includes a newline, as in
1648 longlines-mode. (Bug#9254)
75b771e4
EZ
1649 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1650 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1651
1652 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1653 is non-zero, even if the data buffer is NULL. Fixes a crash in
1654 vertical-motion with longlines-mode. (Bug#9254)
1655
35928349
EZ
16562011-08-05 Eli Zaretskii <eliz@gnu.org>
1657
ec7cc85b
EZ
1658 * bidi.c <bidi_cache_total_alloc>: Now static.
1659 (bidi_initialize): Initialize bidi_cache_total_alloc.
1660
8b76d6f8 1661 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1662 cache. (Bug#9221)
1663
1664 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1665 amount allocated this far in `bidi_cache_total_alloc'.
1666 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1667 non-zero, only free the data buffer without restoring the cache
1668 contents. All callers changed.
1669
1670 * dispextern.h (bidi_unshelve_cache): Update prototype.
1671
1672 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1673 (move_it_in_display_line, move_it_to)
1674 (move_it_vertically_backward, move_it_by_lines): Replace the call
1675 to xfree to an equivalent call to bidi_unshelve_cache.
1676 (move_it_in_display_line_to): Fix logic of returning
412b6358 1677 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1678
e2e2423b
EZ
16792011-08-05 Eli Zaretskii <eliz@gnu.org>
1680
1681 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1682 came from a string character with a `cursor' property. (Bug#9229)
1683
ae9e757a
JD
16842011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1685
1686 * Makefile.in (LIB_PTHREAD): New variable.
1687 (LIBES): Add LIB_PTHREAD (Bug#9216).
1688
1689 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1690 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1691
213bd7f2
AS
16922011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1693
6b02f655 1694 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1695
99aaf75f
JD
16962011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1697
1698 * xterm.c (x_find_topmost_parent): New function.
1699 (x_set_frame_alpha): Find topmost parent window with
1700 x_find_topmost_parent and set the property there also (bug#9181).
1701 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1702
c74e9d86
PE
17032011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1704
1705 * callproc.c (Fcall_process): Avoid vfork clobbering
1706 the local vars buffer, coding_systems, current_dir.
1707
640c8776
SM
17082011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1709
1710 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1711
f26d0e4c
PE
17122011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1713
8a10d76c
PE
1714 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1715 so that it is not optimized away.
1716
f26d0e4c
PE
1717 * xdisp.c (compute_display_string_pos): Remove unused local.
1718
55439c61
EZ
17192011-08-02 Eli Zaretskii <eliz@gnu.org>
1720
1721 Fix slow cursor motion and scrolling in large buffers with
1722 selective display, like Org Mode buffers. (Bug#9218)
1723
1724 * dispextern.h (struct bidi_it): New member disp_prop_p.
1725
1726 * xdisp.c: Remove one-slot cache of display string positions.
1727 (compute_display_string_pos): Accept an additional argument
5e617bc2 1728 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1729 for a display string or property. If found, set DISP_PROP_P
1730 non-zero.
1731
1732 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1733 DISP_PROP_P, and pass it to compute_display_string_pos.
1734 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1735 non-zero. All callers of bidi_fetch_char changed.
1736
fb33fa43
SM
17372011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1738
1739 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1740
b099e063
DM
17412010-12-03 Don March <don@ohspite.net>
1742
1743 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1744 last character M-[char] is translated to ESC [char] (bug#7541).
1745
5cc7f7af
KH
17462011-08-02 Kenichi Handa <handa@m17n.org>
1747
d0fffa3f 1748 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1749
1750 * chartab.c (uniprop_table): Make it non-static.
1751
525d5e6e
EZ
17522011-08-01 Eli Zaretskii <eliz@gnu.org>
1753
1754 * xdisp.c (forward_to_next_line_start): Accept additional argument
1755 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1756 on the newline.
1757 (reseat_at_next_visible_line_start): Use the bidi iterator state
1758 returned by forward_to_next_line_start to restore the state of
1759 it->bidi_it after backing up to previous newline. (Bug#9212)
1760
31011111
AS
17612011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1762
1763 * regex.c (re_comp): Protoize.
1764 (re_exec): Fix return type.
1765 (regexec): Fix type of `ret'. (Bug#9203)
1766
476371c4
PE
17672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1768
e5d76069
PE
1769 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1770 This is needed if max-image-size is a floating-point number.
1771
9a79b20c
AS
17722011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1773
1774 * print.c (print_object): Print empty symbol as ##.
1775
1776 * lread.c (read1): Read ## as empty symbol.
1777
d8c2fa78
AA
17782011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1779
1780 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1781 setting frame foreground color (Bug#9175).
1782 (x_set_background_color): Likewise.
1783
ffe57a7a
AA
1784 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1785 contents (Bug#9176).
1786 (EmacsTooltip -init): Remove bezels and add shadows to
1787 tooltip windows.
1788
bf3492a5
AA
1789 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1790 or scroll bar (Bug#8470).
1791
d55e9c53
AA
1792 * nsfont.m (nsfont_open): Remove assignment to voffset and
1793 unnecessary vars hshink, expand, hd, full_height, min_height.
1794 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1795
1796 * nsterm.h (nsfont_info): Remove voffset field.
1797
d8c2fa78 17982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1799
1800 Implement strike-through and overline on NextStep (Bug#8863).
1801
1802 * nsfont.m (nsfont_open): Use underline position provided by font,
1803 instead of hard-coded value of 2.
1804 (nsfont_draw): Call ns_draw_text_decoration instead.
1805
1806 * nsterm.h: Add declaration for ns_draw_text_decoration.
1807
1808 * nsterm.m (ns_draw_text_decoration): New function for drawing
1809 underline, overline, and strike-through.
1810 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1811 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1812 accommodate underlining, etc.
4843aac3 1813
4cc60b9b
EZ
18142011-07-28 Eli Zaretskii <eliz@gnu.org>
1815
bc7ece87
EZ
1816 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1817 default.
4cc60b9b 1818
476371c4
PE
18192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1820
66606eea
PE
1821 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1822 Without this fix, if a signal arrives just after memory fills up,
1823 'malloc' might be invoked reentrantly.
1824
476371c4
PE
1825 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1826 In other words, assume that every image size is allowed, on non-X
1827 hosts. This assumption is probably wrong, but it lets Emacs compile.
1828
f3fcc40d
AS
18292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1830
1831 * regex.c (re_iswctype): Convert return values to boolean.
1832
350c992f
EZ
18332011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1834
1835 * xdisp.c (compute_display_string_pos): Don't use cached display
1836 string position if the buffer had its restriction changed.
1837 (Bug#9184)
1838
5266b4bb
PE
18392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1842
2573a837 18432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1844
41f55ccd 1845 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1846
39e378da
PE
1847 * bidi.c: Integer size and overflow fixes.
1848 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1849 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1850 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1851 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1852 (bidi_find_other_level_edge):
1853 Use ptrdiff_t instead of EMACS_INT where either will do.
1854 This works better on 32-bit hosts configured --with-wide-int.
1855 (bidi_cache_ensure_space): Check for size-calculation overflow.
1856 Use % rather than repeated addition, for better worst-case speed.
1857 Don't set bidi_cache_size until after xrealloc returns, because it
1858 might not return.
1859 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1860 (bidi_cache_ensure_space): Also check that the bidi cache size
1861 does not exceed that of the largest Lisp string or buffer. See Eli
1862 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1863
5e927815
PE
1864 * alloc.c (__malloc_size_t): Remove.
1865 All uses replaced by size_t. See Andreas Schwab's note
1866 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1867
ca4aa935
PE
1868 * image.c: Improve checking for integer overflow.
1869 (check_image_size): Assume that f is nonnull, since
1870 it is always nonnull in practice. This is one less thing to
1871 worry about when checking for integer overflow later.
1872 (x_check_image_size): New function, which checks for integer
1873 overflow issues inside X.
1874 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1875 This removes the need for a memory_full check.
1876 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1877 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1878 (xbm_read_bitmap_data): Change locals back to 'int', since
1879 their values must fit in 'int'.
1880 (xpm_load_image, png_load, tiff_load):
1881 Invoke x_create_x_image_and_pixmap earlier,
1882 to avoid much needless work if the image is too large.
1883 (tiff_load): Treat overly large images as if
1884 x_create_x_image_and_pixmap failed, not as malloc failures.
1885 (gs_load): Use x_check_image_size.
1886
5f8f9cc2
PE
1887 * gtkutil.c: Omit integer casts.
1888 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1889 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1890
5adf60bc
PE
1891 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1892
c8907a93
PE
1893 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1894 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1895 would wrongly return t on a 64-bit host.
1896
e3c25c68
PE
1897 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1898 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1899 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1900 and therefore cause GCC to emit a bogus diagnostic in some cases.
1901
3f791afe
PE
1902 * image.c: Integer signedness and overflow and related fixes.
1903 This is not an exhaustive set of fixes, but it's time to
1904 record what I've got.
1905 (lookup_pixel_color, check_image_size): Remove redundant decls.
1906 (check_image_size): Don't assume that arbitrary EMACS_INT values
1907 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1908 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1909 (tiff_load, imagemagick_load_image):
1910 Check for overflow in size calculations.
1911 (x_create_x_image_and_pixmap): Remove unnecessary test for
1912 xmalloc returning NULL; that can't happen.
1913 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1914 (xpm_color_bucket): Use better integer hashing function.
1915 (xpm_cache_color): Don't possibly over-allocate memory.
1916 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1917 (gif_memory_source):
1918 Use ptrdiff_t, not int or size_t, to record sizes.
1919 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1920 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1921 either works, as we prefer signed integers.
1922 (tiff_read_from_memory, tiff_write_from_memory):
1923 Return tsize_t, not size_t, since that's what the TIFF API wants.
1924 (tiff_read_from_memory): Don't fail simply because the read would
1925 go past EOF; instead, return a short read.
1926 (tiff_load): Omit no-longer-needed casts.
1927 (Fimagemagick_types): Don't assume size fits into 'int'.
1928
3cc5a532
PE
1929 Improve hashing quality when configured --with-wide-int.
1930 * fns.c (hash_string): New function, taken from sxhash_string.
1931 Do not discard information about ASCII character case; this
1932 discarding is no longer needed.
1933 (sxhash-string): Use it. Change sig to match it. Caller changed.
1934 * lisp.h: Declare it.
1935 * lread.c (hash_string): Remove, since we now use fns.c's version.
1936 The fns.c version returns a wider integer if --with-wide-int is
1937 specified, so this should help the quality of the hashing a bit.
1938
b312a492
PE
1939 * emacs.c: Integer overflow minor fix.
1940 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1941 Define only if GNU_LINUX.
1942 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1943
dfd153ae
PE
1944 * dispnew.c: Integer signedness and overflow fixes.
1945 Remove unnecessary forward decls, that were a maintenance hassle.
1946 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1947 All uses changed.
1948 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1949 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1950 (prepare_desired_row, line_draw_cost):
1951 Use int, not unsigned, where either works.
1952 (save_current_matrix, restore_current_matrix):
1953 Use ptrdiff_t, not size_t, where either works.
1954 (init_display): Check for overflow more accurately, and without
1955 relying on undefined behavior.
1956
a81d11a3
PE
1957 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1958 Remove, replacing with the new symbols in lisp.h. All uses changed.
1959 * fileio.c (make_temp_name):
1960 * filelock.c (lock_file_1, lock_file):
1961 * xdisp.c (message_dolog):
1962 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1963 Use pMd etc. instead.
1964 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1965 replacing the pWIDE etc. symbols removed from editfns.c.
1966
3300e6fd
PE
1967 * keyboard.h (num_input_events): Now uintmax_t.
1968 This is (very slightly) less likely to mess up due to wraparound.
1969 All uses changed.
1970
fd05c7e9
PE
1971 * buffer.c: Integer signedness fixes.
1972 (alloc_buffer_text, enlarge_buffer_text):
1973 Use ptrdiff_t rather than size_t when either will do, as we prefer
1974 signed integers.
1975
903fe15d
PE
1976 * alloc.c: Integer signedness and overflow fixes.
1977 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1978 (__malloc_size_t): Default to size_t, not to int.
1979 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1980 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1981 Prefer ptrdiff_t to size_t when either would do, as we prefer
1982 signed integers.
1983 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1984 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1985 Now const. Initialize with values that are in range even if char
1986 is signed.
1987 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1988 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1989 These functions do the right thing with sizes > 2**32.
1990 (check_depth): Now ptrdiff_t, not int.
1991 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1992 Adjust to new way of storing sizes. Check for size overflow bugs
1993 in rest of code.
1994 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1995 slightly wrong anyway, as it missed one instance of
1996 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1997 (refill_memory_reserve): Omit needless cast to size_t.
1998 (mark_object_loop_halt): Mark as externally visible.
1999
ac82cc6a
PE
2000 * xselect.c: Integer signedness and overflow fixes.
2001 (Fx_register_dnd_atom, x_handle_dnd_message):
2002 Use ptrdiff_t, not size_t, since we prefer signed.
2003 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2004 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2005 x_dnd_atoms_size and x_dnd_atoms_length.
2006
c2d1e36d
PE
2007 * doprnt.c: Prefer signed to unsigned when either works.
2008 * eval.c (verror):
2009 * doprnt.c (doprnt):
2010 * lisp.h (doprnt):
2011 * xdisp.c (vmessage):
2012 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2013 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2014 prefer signed arithmetic to avoid comparison confusion.
2015 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2016 but is a bit tricky.
2017
0e926e56
PE
2018 Assume freestanding C89 headers, string.h, stdlib.h.
2019 * data.c, doprnt.c, floatfns.c, print.c:
2020 Include float.h unconditionally.
2021 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2022 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2023 * regex.c: Likewise for stddef.h, string.h.
2024 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2025 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2026 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2027 (STDC_HEADERS): Remove obsolete defines.
2028 * sysdep.c: Include limits.h unconditionally.
2029
9cfdb3ec
PE
2030 Assume support for memcmp, memcpy, memmove, memset.
2031 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2032 * regex.c (memcmp, memcpy):
2033 Remove; we assume C89 now.
2034
2035 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2036 (__malloc_safe_bcopy): Remove; no longer needed.
2037
cf950e6b 2038 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2039 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2040 well either way, and we prefer signed to unsigned.
2041
dbf38e02
LMI
20422011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2043
2044 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2045 closes the connection while we're reading (bug#9182).
2046
d6f0886c 20472011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2048
d6f0886c
JD
2049 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2050 are specified (Bug#9168).
24e0f6b1 2051
2eb1f9e6
PE
20522011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2055 Found by GCC static checking and --with-wide-int on a 32-bit host.
2056
22381272 20572011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2058
2059 * xdisp.c (compute_display_string_pos): Fix logic of caching
2060 previous display string position. Initialize cached_prev_pos to
2061 -1. Fixes slow-down at the beginning of a buffer.
2062
f25e39b4
EZ
20632011-07-24 Eli Zaretskii <eliz@gnu.org>
2064
2065 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2066 for attrs[LFACE_FONTSET_INDEX].
2067
04c4b52e
PE
20682011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2069
2070 * xml.c (parse_region): Remove unused local
2071 that was recently introduced.
2072
c1734fbd
EZ
20732011-07-23 Eli Zaretskii <eliz@gnu.org>
2074
be18c5a5
EZ
2075 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2076 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2077
c1734fbd
EZ
2078 * xdisp.c (move_it_in_display_line_to): Record the best matching
2079 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2080 exit if none of the characters scanned was an exact match.
2081 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2082 when exact match is impossible due to invisible text, and the
2083 lines are truncated.
2084
a258d627
JD
20852011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2086
2087 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2088 for OSX >= 10.7.
2089
b6d5a689
EZ
20902011-07-22 Eli Zaretskii <eliz@gnu.org>
2091
0f74f785
EZ
2092 Fix a significant slow-down of cursor motion with C-n, C-p,
2093 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2094 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2095 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2096 (next_element_from_buffer): Call compute_stop_pos_backwards to
2097 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2098 base_level_stop.
2099 (reseat): Don't look for prev_stop, as that could mean a very long
2100 run.
2101 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2102 <cached_disp_overlay_modiff>: Cache for last found display string
2103 position.
551918c1 2104 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2105 about the same buffer in the same area of character positions, and
2106 the buffer wasn't changed since the time the display string
2107 position was cached.
551918c1 2108
b2d0c91a
EZ
21092011-07-22 Eli Zaretskii <eliz@gnu.org>
2110
2111 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2112 is an integer, which is important for empty lines. (Bug#9149)
2113
043604ee
CY
21142011-07-22 Chong Yidong <cyd@stupidchicken.com>
2115
2116 * frame.c (Fmodify_frame_parameters): In tty case, update the
2117 default face if necessary (Bug#4238).
2118
da4adb04
CY
21192011-07-21 Chong Yidong <cyd@stupidchicken.com>
2120
2121 * editfns.c (Fstring_to_char): No need to explain what a character
2122 is in the docstring (Bug#6576).
2123
9abd0532
LMI
21242011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2125
2126 * xml.c (parse_region): Make sure we always return a tree.
2127
36881d16
HK
21282011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2129
2130 * xml.c (parse_region): If a document contains only comments,
2131 return that, too.
2132
1e98674d
LMI
21332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2134
2135 * xml.c (make_dom): Return comments, too.
2136
590bd467
PE
21372011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2138
2139 Port to OpenBSD.
2140 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2141 and the surrounding thread.
2142 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2143 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2144 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2145 timer goes off.
2146 * s/openbsd.h (BROKEN_SIGIO): Define.
2147 * unexelf.c (unexec) [__OpenBSD__]:
2148 Don't update the .mdebug section of the Alpha COFF symbol table.
2149
f41628b2
LMI
21502011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2151
2152 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2153 (bug#8460).
2154
b59b67c5
PE
21552011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2156
15e3a074
PE
2157 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2158 This fixes some race conditions on the permissions of any newly
2159 created file.
2160
41bed37d
PE
2161 * alloc.c (valid_pointer_p): Use pipe, not open.
2162 This fixes some permissions issues when debugging.
2163
b59b67c5
PE
2164 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2165 If fchown fails to set both uid and gid, try to set just gid,
2166 as that is sometimes allowed. Adjust the file's mode to eliminate
2167 setuid or setgid bits that are inappropriate if fchown fails.
2168
925a6be7
SM
21692011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2170
2171 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2172 to compare Lisp_Objects.
2173 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2174 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2175 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2176
52968808
AS
21772011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2178
0a6a104b
AS
2179 * lread.c (read_integer): Unread even EOF character.
2180 (read1): Likewise. Properly record start position of symbol.
2181
52968808
AS
2182 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2183 symbol character follows.
2184
9e381cdd
PE
21852011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2186
2187 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2188 This works around a problem with the previous change to Fcopy_file.
2189 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2190 and without this change, GCC might complain about discarding
2191 fchown's return value.
2192
b5641435
JB
21932011-07-16 Juanma Barranquero <lekktu@gmail.com>
2194
2195 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2196
a8031457
PE
21972011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2198
2199 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2200
dd889327
LMI
22012011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2202
750c33f7
LMI
2203 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2204 it's used from the C level.
2205
dd889327
LMI
2206 * process.c: Use the same condition for POLL_FOR_INPUT in both
2207 keyboard.c and process.c (bug#1858).
2208
87e86684
LM
22092011-07-09 Lawrence Mitchell <wence@gmx.li>
2210
2211 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2212 (Fgnutls_boot): Use it.
2213
64348f40
AS
22142011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2215
2216 * doc.c (Fsubstitute_command_keys): Revert last change.
2217
1d698799
LMI
22182011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2219
f863868c
LMI
2220 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2221 quotes the next character, and doesn't affect other longer
2222 sequences (bug#8935).
2223
1d698799
LMI
2224 * lread.c (syms_of_lread): Clarify that is isn't only
2225 `eval-buffer' and `eval-defun' that's affected by
2226 `lexical-binding' (bug#8460).
2227
aa4b6df6
EZ
22282011-07-15 Eli Zaretskii <eliz@gnu.org>
2229
2230 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2231 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2232
5d856da6
PE
22332011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2234
ad6042bb
PE
2235 Fix minor problems found by static checking.
2236 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2237 (elsz): Now a signed constant, not a size_t var. We prefer signed
2238 types to unsigned, to avoid integer comparison confusion. Without
2239 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2240 "cannot optimize loop, the loop counter may overflow", a symptom
2241 of the confusion.
f00bbb22 2242 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2243 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2244
6468f31c
LMI
22452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2246
49080b10
LMI
2247 * search.c (Fre_search_backward): Mention `case-fold-search' in
2248 all the re_search_* functions (bug#8138).
2249
6468f31c
LMI
2250 * keyboard.c (Fopen_dribble_file): Document when the file is
2251 closed (bug#8056).
2252
c965adc5
EZ
22532011-07-14 Eli Zaretskii <eliz@gnu.org>
2254
df9733bf
EZ
2255 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2256 bidi_cache_idx.
2257
0bb23927
EZ
2258 Support bidi reordering of display and overlay strings.
2259 * xdisp.c (compute_display_string_pos)
2260 (compute_display_string_end): Accept additional argument STRING.
2261 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2262 (reseat_to_string): Initialize bidi_it->string.s and
2263 bidi_it->string.schars.
2264 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2265 NULL (avoids a crash in bidi_paragraph_init).
2266 Initialize itb.string.lstring.
0bb23927
EZ
2267 (init_iterator): Call bidi_init_it only of a valid
2268 buffer position was specified. Initialize paragraph_embedding to
2269 L2R.
2270 (reseat_to_string): Initialize the bidi iterator.
2271 (display_string): If we need to ignore text properties of
2272 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2273 original value of -1 will not work with bidi.)
2274 (compute_display_string_pos): First arg is now struct
2275 `text_pos *'; all callers changed. Support display properties on
2276 Lisp strings.
2277 (compute_display_string_end): Support display properties on Lisp
2278 strings.
2279 (init_iterator, reseat_1, reseat_to_string): Initialize the
2280 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2281 when iterating on a string not from display properties).
640c8776
SM
2282 (compute_display_string_pos, compute_display_string_end):
2283 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2284 arrow keys.
2285 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2286 base_level_stop; instead, set base_level_stop to BEGV.
2287 Fixes crashes in vertical-motion.
0bb23927
EZ
2288 (next_element_from_buffer): Improve commentary for when
2289 the iterator is before prev_stop.
2290 (init_iterator): Initialize bidi_p from the default value of
2291 bidi-display-reordering, not from buffer-local value. Use the
2292 buffer-local value only if initializing for buffer iteration.
2293 (handle_invisible_prop): Support invisible properties on strings
2294 that are being bidi-reordered.
2295 (set_iterator_to_next): Support bidi reordering of C strings and
2296 Lisp strings.
2297 (next_element_from_string): Support bidi reordering of Lisp
2298 strings.
2299 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2300 (display_string): Support display of R2L glyph rows.
2301 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2302 (init_iterator): Don't initialize it->bidi_p for strings
2303 here.
2304 (reseat_to_string): Initialize it->bidi_p for strings here.
2305 (next_element_from_string, next_element_from_c_string)
2306 (next_element_from_buffer): Add xassert's for correspondence
2307 between IT's object being iterated and it->bidi_it.string
2308 structure.
2309 (face_before_or_after_it_pos): Support bidi iteration.
2310 (next_element_from_c_string): Handle the case of the first string
2311 character that is not the first one in the visual order.
2312 (get_visually_first_element): New function, refactored from common
2313 parts of next_element_from_buffer, next_element_from_string, and
2314 next_element_from_c_string.
2315 (tool_bar_lines_needed, redisplay_tool_bar)
2316 (display_menu_bar): Force left-to-right direction. Add a FIXME
2317 comment for making that be controlled by a user option.
2318 (push_it, pop_it): Save and restore the state of the
2319 bidi iterator. Save and restore the bidi_p flag.
2320 (pop_it): Iterate out of display property for string iteration as
2321 well.
2322 (iterate_out_of_display_property): Support iteration over strings.
2323 (handle_single_display_spec): Set up it->bidi_it for iteration
2324 over a display string, and call bidi_init_it.
2325 (handle_single_display_spec, next_overlay_string)
2326 (get_overlay_strings_1, push_display_prop): Set up the bidi
2327 iterator for displaying display or overlay strings.
2328 (forward_to_next_line_start): Don't use the shortcut if
2329 bidi-iterating.
2330 (back_to_previous_visible_line_start): If handle_display_prop
2331 pushed the iterator stack, restore the internal state of the bidi
2332 iterator by calling bidi_pop_it same number of times.
2333 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2334 and we are bidi-iterating, don't decrement the iterator position;
2335 instead, set the first_elt flag in the bidi iterator, to produce
2336 the same effect.
2337 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2338 (push_display_prop): xassert that we are iterating a buffer.
2339 (push_it, pop_it): Save and restore paragraph_embedding member.
2340 (handle_single_display_spec, next_overlay_string)
2341 (get_overlay_strings_1, reseat_1, reseat_to_string)
2342 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2343 correctly. Don't assume unibyte strings are not bidi-reordered.
2344 (compute_display_string_pos)
2345 (compute_display_string_end): Fix handling the case of C string.
2346 (push_it, pop_it): Save and restore from_disp_prop_p.
2347 (handle_single_display_spec, push_display_prop): Set the
2348 from_disp_prop_p flag.
2349 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2350 (pop_it): Call iterate_out_of_display_property only if we are
2351 popping after iteration over a string that came from a display
2352 property. Fix a typo in popping stretch info. Add an assertion
2353 for verifying that the iterator position is in sync with the bidi
2354 iterator.
2355 (handle_single_display_spec, get_overlay_strings_1)
2356 (push_display_prop): Fix initialization of paragraph direction for
2357 string when that of the parent object is not yet determined.
2358 (reseat_1): Call bidi_init_it to resync the bidi
2359 iterator with IT's position. (Bug#7616)
2360 (find_row_edges): If ROW->start.pos gives position
2361 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2362 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2363 Reset the from_disp_prop_p flag.
2364 (SAVE_IT, RESTORE_IT): New macros.
2365 (pos_visible_p, face_before_or_after_it_pos)
2366 (back_to_previous_visible_line_start)
2367 (move_it_in_display_line_to, move_it_in_display_line)
2368 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2369 (try_scrolling, redisplay_window, display_line): Use them when
2370 saving a temporary copy of the iterator and restoring it back.
2371 (back_to_previous_visible_line_start, reseat_1)
2372 (init_iterator): Empty the bidi cache "stack".
2373 (move_it_in_display_line_to): If iterator ended up at
2374 EOL, but we never saw any buffer positions smaller than
2375 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2376 motion in bidi-reordered lines.
2377 (move_it_in_display_line_to): Record prev_method and prev_pos
2378 immediately before the call to set_iterator_to_next. Fixes cursor
2379 motion in bidi-reordered lines with stretch glyphs and strings
2380 displayed in margins. (Bug#8133) (Bug#8867)
2381 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2382 TO_CHARPOS.
640c8776
SM
2383 (pos_visible_p): Support positions in bidi-reordered lines.
2384 Save and restore bidi cache.
0bb23927
EZ
2385
2386 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2387 (bidi_paragraph_info): Delete unused struct.
2388 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2389 (bidi_cache_start): New variable.
2390 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2391 to zero.
2392 (bidi_cache_fetch_state, bidi_cache_search)
2393 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2394 (bidi_cache_find, bidi_peek_at_next_level)
2395 (bidi_level_of_next_char, bidi_find_other_level_edge)
2396 (bidi_move_to_visually_next): Compare cache index with
2397 bidi_cache_start rather than with zero.
2398 (bidi_fetch_char): Accept new argument STRING; all callers
2399 changed. Support iteration over a string. Support strings with
2400 display properties. Support unibyte strings. Fix the type of
2401 `len' according to what STRING_CHAR_AND_LENGTH expects.
2402 (bidi_paragraph_init, bidi_resolve_explicit_1)
2403 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2404 (bidi_level_of_next_char, bidi_move_to_visually_next):
2405 Support iteration over a string.
0bb23927
EZ
2406 (bidi_set_sor_type, bidi_resolve_explicit_1)
2407 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2408 can now be zero (for strings); special values 0 and -1 were
2409 changed to -1 and -2, respectively.
2410 (bidi_char_at_pos): New function.
2411 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2412 Call it instead of FETCH_MULTIBYTE_CHAR.
2413 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2414 initialized to valid values.
2415 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2416 values.
2417 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2418 the test for valid cached positions. Fix the logic for looking up
2419 the sentinel state in the cache. GCPRO the Lisp string we are
2420 iterating.
2421 (bidi_push_it, bidi_pop_it): New functions.
2422 (bidi_initialize): Initialize the bidi cache start stack pointer.
2423 (bidi_cache_ensure_space): New function, refactored from part of
2424 bidi_cache_iterator_state. Don't assume the required size is just
2425 one BIDI_CACHE_CHUNK away.
2426 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2427 (bidi_count_bytes, bidi_char_at_pos): New functions.
2428 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2429 always valid if bidi_cache_idx is valid.
2430 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2431 is valid if it's going to be used.
2432 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2433 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2434 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2435 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2436 (bidi_find_other_level_edge, bidi_cache_start_stack):
2437 All variables related to cache indices are now EMACS_INT.
c965adc5 2438
0bb23927
EZ
2439 * dispextern.h (struct bidi_string_data): New structure.
2440 (struct bidi_it): New member `string'. Make flag members be 1-bit
2441 fields, and put them last in the struct.
640c8776
SM
2442 (compute_display_string_pos, compute_display_string_end):
2443 Update prototypes.
0bb23927
EZ
2444 (bidi_push_it, bidi_pop_it): Add prototypes.
2445 (struct iterator_stack_entry): New members bidi_p,
2446 paragraph_embedding, and from_disp_prop_p.
2447 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2448 (bidi_shelve_cache, bidi_unshelve_cache):
2449 Declare prototypes.
0bb23927
EZ
2450
2451 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2452 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2453 and vector-like objects.
2454
2455 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2456 cache around display iteration.
2457
2458 * window.c (Fwindow_end, window_scroll_pixel_based)
2459 (displayed_window_lines, Frecenter): Save and restore the bidi
2460 cache around display iteration.
2461
3bbd2265
LMI
24622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2463
2464 * editfns.c (Fdelete_region): Clarify the use of the named
2465 parameters (bug#6788).
2466
adc47434
MR
24672011-07-14 Martin Rudalics <rudalics@gmx.at>
2468
2469 * indent.c (Fvertical_motion): Set and restore w->pointm when
2470 saving and restoring the window's buffer (Bug#9006).
2471
837c31f8
LMI
24722011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2473
2474 * editfns.c (Fstring_to_char): Clarify just what is returned
2475 (bug#6576). Text by Eli Zaretskii.
2476
ac389d0c
JB
24772011-07-13 Juanma Barranquero <lekktu@gmail.com>
2478
2479 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2480
0be0ce47
EZ
24812011-07-13 Eli Zaretskii <eliz@gnu.org>
2482
2483 * buffer.c (mmap_find): Fix a typo.
2484
cd18e7e3
JB
24852011-07-13 Johan Bockgård <bojohan@gnu.org>
2486
2487 Fix execution of x selection hooks.
2488 * xselect.c (Qx_lost_selection_functions)
2489 (Qx_sent_selection_functions): New vars.
2490 (syms_of_xselect): DEFSYM them.
2491 (x_handle_selection_request): Pass Qx_sent_selection_functions
2492 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2493 (x_handle_selection_clear,x_clear_frame_selections):
2494 Pass Qx_lost_selection_functions rather than
2495 Vx_lost_selection_functions to Frun_hook_with_args.
2496
47ea7f44
PE
24972011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2498
ac389d0c 2499 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2500 The old code sometimes used this field without initializing it.
2501
47ea7f44
PE
2502 * alloc.c (gc_sweep): Don't read past end of array.
2503 In theory, the old code could also have corrupted Emacs internals,
2504 though it'd be very unlikely.
2505
bc985c87
AS
25062011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2507
2508 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2509 argument. (Bug#4026)
bc985c87 2510
0cf34688
LMI
25112011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2512
b3dadd76
LMI
2513 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2514 key" (bug#4257).
2515
0cf34688
LMI
2516 * window.c (Fset_window_start): Doc fix (bug#4199).
2517 (Fset_window_hscroll): Ditto.
2518
270768cd
PE
25192011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2520
077e3dda 2521 Fix minor new problems caught by GCC 4.6.1.
270768cd 2522 * term.c (init_tty): Remove unused local.
490011a6 2523 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2524 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2525 not used otherwise.
270768cd 2526
b1f58454
CY
25272011-07-12 Chong Yidong <cyd@stupidchicken.com>
2528
2529 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2530
22b9578d
LMI
25312011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2532
6e70ab07
LMI
2533 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2534 are the mini-buffer and the echo area (bug#3320).
2535
22b9578d
LMI
2536 * term.c (init_tty): Remove support for supdup, c10 and perq
2537 terminals, which are no longer supported (bug#1482).
2538
8974cc9f
JB
25392011-07-10 Johan Bockgård <bojohan@gnu.org>
2540
2541 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2542
a560d974
JD
25432011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2544
2545 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2546 for non-popups (Bug#3642).
2547
1dae0f0a
AS
25482011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2549
268c2c36 2550 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2551 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2552 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2553 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2554 * data.c (fmod): Likewise.
2555 * dispnew.c (swap_glyphs_in_rows): Likewise.
2556 * emacs.c (memory_warning_signal): Likewise.
2557 * floatfns.c (float_error): Likewise.
2558 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2559 (otf_open, font_otf_capability, generate_otf_features)
2560 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2561 Likewise.
2562 * image.c (pbm_read_file): Likewise.
2563 * indent.c (string_display_width): Likewise.
2564 * intervals.c (check_for_interval, search_for_interval)
2565 (inc_interval_count, count_intervals, root_interval)
2566 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2567 * lread.c (defalias): Likewise.
268c2c36 2568 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2569 * regex.c (set_image_of_range_1, set_image_of_range)
2570 (regex_grow_registers): Likewise.
2571 * sysdep.c (strerror): Likewise.
2572 * termcap.c (valid_filename_p, tprint, main): Likewise.
2573 * tparam.c (main): Likewise.
2574 * unexhp9k800.c (run_time_remap, save_data_space)
2575 (update_file_ptrs, read_header, write_header, calculate_checksum)
2576 (copy_file, copy_rest, display_header): Likewise.
2577 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2578 Likewise.
2579 * xdisp.c (check_it): Likewise.
2580 * xfaces.c (register_color, unregister_color, unregister_colors):
2581 Likewise.
2582 * xfns.c (print_fontset_result): Likewise.
2583 * xrdb.c (member, fatal, main): Likewise.
2584
99033785
PE
25852011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2586
2587 Fix minor problems found by static checking (Bug#9031).
2588 * chartab.c (char_table_set_range, map_sub_char_table):
2589 Remove unused locals.
2590 (uniprop_table): Now static.
2591 * composite.c (_work_char): Remove unused static var.
2592
9cb2ac56
JB
25932011-07-09 Juanma Barranquero <lekktu@gmail.com>
2594
2595 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2596
f25661f0
JD
25972011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2598
2599 * gtkutil.c (qttip_cb): Remove code without function.
2600
8278c4fe
EZ
26012011-07-09 Eli Zaretskii <eliz@gnu.org>
2602
2603 * w32.c (pthread_sigmask): New stub.
2604
1692ae2d 26052011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2606
8a6ebd58 2607 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2608 sigprocmask is portable only for single-threaded applications, and
2609 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2610 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2611 (LIBES): Use it.
2612 * callproc.c (Fcall_process):
2613 * process.c (create_process):
2614 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2615 Use pthread_sigmask, not sigprocmask.
123403e4 2616
1b854618
JD
26172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2618
2619 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2620 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2621 wrong (Bug#8591).
2622
3fe4b549
JD
26232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2624
0ce7e563
JD
2625 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2626 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2627 (xg_hide_tooltip): Fix comment.
2628
3fe4b549
JD
2629 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2630 in registerServicesMenuSendTypes.
2631 (validRequestorForSendType): Don't check ns_return_types.
2632
2633 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2634 ns_return_type.
2635
5df75e47
JR
26362011-07-08 Jason Rumney <jasonr@gnu.org>
2637
2638 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2639 frame struct members of non-existent frames (Bug#6284).
2640
699c10bd
JD
26412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2642
4393663b
JD
2643 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2644 variable firstTime not needed on OSX >= 10.6.
2645 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2646 >= 10.5. Use setKnobProportion, setDoubleValue.
2647
2648 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2649 (MAC_OS_X_VERSION_10_5): Define if not defined.
2650 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2651 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2652 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2653
2654 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2655 cString and lossyCString on OSX >= 10.4
2656
2657 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2658 sizeToFit on OSX >= 10.2.
2659
2660 * nsimage.m (allocInitFromFile): Don't use deprecated method
2661 bestRepresentationForDevice on OSX >= 10.6.
2662
2663 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2664 to avoid warning.
2665
2666 * emacs.c: Declare unexec_init_emacs_zone.
2667
a63e0781
JD
2668 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2669
699c10bd
JD
2670 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2671
2672 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2673 on svcsMenu (Bug#8842).
2674
2675 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2676 ns_return_types.
2677 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2678
2679 * nsterm.m (QUTF8_STRING): Declare.
2680 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2681 (validRequestorForSendType): Return type is (id).
2682 Change indexOfObjectIdenticalTo to indexOfObject.
2683 Check if we have local selection before returning self (Bug#8842).
2684 (writeSelectionToPasteboard): Put local selection into paste board
2685 if we have a local selection (Bug#8842).
2686 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2687
2688 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2689 (ns_get_local_selection): Declare.
2690
54e10184
LMI
26912011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2692
9888ff71
LMI
2693 * keymap.c (describe_map_tree): Don't insert a double newline at
2694 the end of the buffer (bug#1169) and return whether we inserted
2695 something.
2696
54e10184
LMI
2697 * callint.c (Fcall_interactively): Change "reading args" to
2698 "providing args" to try to clarify what it does (bug#1010).
2699
15fa4783
KH
27002011-07-07 Kenichi Handa <handa@m17n.org>
2701
2702 * composite.c (composition_compute_stop_pos): Ignore a static
2703 composition starting before CHARPOS (Bug#8915).
2704
2705 * xdisp.c (handle_composition_prop): Likewise.
2706
a8815b00
EZ
27072011-07-07 Eli Zaretskii <eliz@gnu.org>
2708
2709 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2710 (Bug#9015)
2711
ef7b981d 27122011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2713
2714 * character.h (unicode_category_t): New enum type.
2715
2716 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2717 (Qchar_code_property_table): New variable.
2718 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2719 (UNIPROP_COMPRESSED_FORM_P): New macros.
2720 (char_table_ascii): Uncompress the compressed values.
2721 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2722 Uncompress the compressed values.
ac389d0c 2723 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2724 (char_table_ref_and_range): Uncompress the compressed values.
2725 (sub_char_table_set): New arg is_uniprop. Callers changed.
2726 Uncompress the compressed values.
2727 (sub_char_table_set_range): Args changed. Callers changed.
2728 (char_table_set_range): Adjuted for the above change.
2729 (map_sub_char_table): Delete args default_val and parent. Add arg
2730 top. Give decoded values to a Lisp function.
640c8776 2731 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2732 values to a Lisp function. Gcpro more variables.
2733 (uniprop_table_uncompress)
2734 (uniprop_decode_value_run_length): New functions.
2735 (uniprop_decoder, uniprop_decoder_count): New variables.
2736 (uniprop_get_decoder, uniprop_encode_value_character)
2737 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2738 New functions.
2739 (uniprop_encoder, uniprop_encoder_count): New variables.
2740 (uniprop_get_encoder, uniprop_table)
2741 (Funicode_property_table_internal, Fget_unicode_property_internal)
2742 (Fput_unicode_property_internal): New functions.
2743 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2744 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2745 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2746 char-code-property-alist.
2747
640c8776 2748 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2749 Vunicode_category_table.
2750
640c8776 2751 * font.c (font_range): Adjust for the change of
c805dec0
KH
2752 Vunicode_category_table.
2753
76b397fb
DN
27542011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2755
2756 * m/iris4d.h: Remove file, move contents ...
2757 * s/irix6-5.h: ... here.
2758
22b4128e
PE
27592011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2760
2761 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2762 * alloc.c (mark_buffer):
2763 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2764 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2765 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2766 This isn't true in general, and it's particularly not true
2767 if Emacs is configured with --with-wide-int.
2768 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2769 New macros, used in the buffer.c change.
2770
869795d6
JD
27712011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2772
2773 * xsettings.c: Use both GConf and GSettings if both are available.
2774 (store_config_changed_event): Add comment.
2775 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2776 (store_tool_bar_style_changed): New functions.
5e617bc2 2777 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2778 (struct xsettings): Move font inside HAVE_XFT.
2779 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2780 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2781 Move inside HAVE_XFT.
640c8776 2782 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2783 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2784 also.
2785 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2786 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2787 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2788 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2789 (parse_settings): Move check for font inside HAVE_XFT.
2790 (read_settings, apply_xft_settings): Add comment.
2791 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2792 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2793 call store_font_name_changed.
2794 (xft_settings_event): Add comment.
2795 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2796 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2797 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2798 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2799 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2800 (xsettings_get_system_font, xsettings_get_system_normal_font):
2801 Add comment.
869795d6 2802
d8ed26bd
PE
28032011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 Random fixes. E.g., (random) never returned negative values.
2806 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2807 subseconds part to the entropy, as that's a bit more random.
2808 Prefer signed to unsigned, since the signedness doesn't matter and
2809 in general we prefer signed. When given a limit, use a
2810 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2811 latter isn't right if USE_2_TAGS_FOR_INTS.
2812 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2813 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2814
cabf1cac
SM
28152011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2816
2817 * textprop.c (text_property_stickiness):
2818 Obey Vtext_property_default_nonsticky.
2819 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2820 * w32fns.c (syms_of_w32fns):
2821 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2822
6e9b2be9
PE
28232011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2824
2825 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2826 This is more efficient than Ffile_directory_p and avoids a minor race.
2827
90186c68
LMI
28282011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2829
7c301272
LMI
2830 * buffer.c (Foverlay_put): Say what the return value is
2831 (bug#7835).
2832
c4f2d8d4
LMI
2833 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2834 is a directory before asking whether to use the file name
2835 (bug#7564).
ad637907
LMI
2836 (barf_or_query_if_file_exists): Make the "File is a directory"
2837 error be more correct.
c4f2d8d4 2838
90186c68
LMI
2839 * fns.c (Frequire): Remove the mention of the .gz files, since
2840 that's installation-specific, but keep the mention of
2841 `get-load-suffixes'.
2842
da64016e
PE
28432011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2844
2845 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2846 Report string overflow if the output is too long.
2847
7d47b580
JB
28482011-07-04 Juanma Barranquero <lekktu@gmail.com>
2849
a555cb87
JB
2850 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2851 (syms_of_gnutls): Remove duplicate DEFSYM for
2852 Qgnutls_bootprop_verify_hostname_error, an error for
2853 Qgnutls_bootprop_verify_error (which is no longer used).
2854
7d47b580
JB
2855 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2856 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2857 Also (re)move comments that are misplaced or no longer relevant.
2858
1e49bfab
LMI
28592011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2860
2861 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2862
1485f4c0
CY
28632011-07-03 Chong Yidong <cyd@stupidchicken.com>
2864
2865 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2866 and background color parameters if they have been changed.
2867
a9ab721e
LMI
28682011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2869
2870 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2871
cf7cff57
PE
28722011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2873
2e13213d
PE
2874 * xsettings.c (SYSTEM_FONT): Define only when used.
2875 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2876
cf7cff57
PE
2877 * keymap.c (access_keymap_1): Now static.
2878
7a8e04f7
CY
28792011-07-02 Chong Yidong <cyd@stupidchicken.com>
2880
2881 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2882 leave any prefix arg for the up event (Bug#1586).
2883
61352f62
LMI
28842011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2885
69bb1ef7
LMI
2886 * lread.c (syms_of_lread): Mention single symbols defined by
2887 `defvar' or `defconst' (bug#7154).
2888
61352f62 2889 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2890 (Frequire): Mention get-load-suffixes.
61352f62 2891
28545e04
MR
28922011-07-02 Martin Rudalics <rudalics@gmx.at>
2893
2894 * window.h (window): Remove clone_number slot.
2895 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2896 Remove.
2897 (make_parent_window, make_window, saved_window)
2898 (Fset_window_configuration, save_window_save): Don't deal with
2899 clone numbers.
2900 * buffer.c (Qclone_number): Remove declaration.
2901 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2902
3349e122
SM
29032011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2904
2905 Add multiple inheritance to keymaps.
2906 * keymap.c (Fmake_composed_keymap): New function.
2907 (Fset_keymap_parent): Simplify.
2908 (fix_submap_inheritance): Remove.
2909 (access_keymap_1): New function extracted from access_keymap to handle
2910 embedded parents and handle lists of maps.
2911 (access_keymap): Use it.
2912 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2913 (Fcopy_keymap): Handle embedded parents.
2914 (Fcommand_remapping, define_as_prefix): Simplify.
2915 (Fkey_binding): Simplify.
2916 (syms_of_keymap): Move minibuffer-local-completion-map,
2917 minibuffer-local-filename-completion-map,
2918 minibuffer-local-must-match-map, and
2919 minibuffer-local-filename-must-match-map to Elisp.
2920 (syms_of_keymap): Defsubr make-composed-keymap.
2921 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2922 (parse_menu_item): Trivial simplification.
2923
3279eb87
GM
29242011-07-01 Glenn Morris <rgm@gnu.org>
2925
2926 * Makefile.in (SETTINGS_LIBS): Fix typo.
2927
4550efdf
KI
29282011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2929
2930 * coding.c (Fencode_coding_string): Record the last coding system
2931 used, as the function doc string says (bug#8738).
2932
0949d2b6
JD
29332011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2934
2935 * xsettings.c (store_monospaced_changed): Take new font as arg and
2936 check for change against current_mono_font.
2937 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2938 (emacs_settings_constructor, emacs_settings_get_property)
2939 (emacs_settings_set_property, emacs_settings_class_init)
2940 (emacs_settings_init, gsettings_obj): Remove.
2941 (something_changedCB): New function for HAVE_GSETTINGS.
2942 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2943 with value as argument.
2944 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2945 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2946 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2947 "changed".
2948
2949 * xgselect.c: Add defined (HAVE_GSETTINGS).
2950 (xgselect_initialize): Ditto.
2951
2952 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2953 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2954 xg_select.
2955
bbc6b304
PE
29562011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2957
2958 * eval.c (struct backtrace): Simplify and port the data structure.
2959 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2960 signed bit field, as this assumption is not portable and it makes
2961 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2962 "char debug_on_exit : 1" as this is not portable either; instead,
2963 use the portable "unsigned int debug_on_exit : 1". Remove unused
2964 member evalargs. Remove obsolete comments about cc bombing out.
2965
9851bfc5
JD
29662011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2967
51bb811f 2968 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2969 Let HAVE_GSETTINGS override HAVE_GCONF.
2970 (store_monospaced_changed): New function.
2971 (EMACS_SETTINGS): A new type derived from GObject to handle
2972 GSettings notifications.
2973 (emacs_settings_constructor, emacs_settings_get_property)
2974 (emacs_settings_set_property, emacs_settings_class_init):
2975 New functions.
2976 (gsettings_client, gsettings_obj): New variables.
2977 (GSETTINGS_SCHEMA): New define.
2978 (something_changedCB): Call store_monospaced_changed.
2979 (init_gsettings): New function.
2980 (xsettings_initialize): Call init_gsettings.
2981 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2982 to NULL.
2983
640c8776 2984 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2985 GCONF_CFLAGS/LIBS.
2986
5386012d
MR
29872011-06-29 Martin Rudalics <rudalics@gmx.at>
2988
2989 * window.c (resize_root_window, grow_mini_window)
2990 (shrink_mini_window): Rename Qresize_root_window to
2991 Qwindow_resize_root_window and Qresize_root_window_vertically to
2992 Qwindow_resize_root_window_vertically.
2993
f13e0b08
PE
29942011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2995
2996 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2997
94515237
JB
29982011-06-27 Juanma Barranquero <lekktu@gmail.com>
2999
3000 * makefile.w32-in: Redesign dependencies so they reflect more
3001 clearly which files are directly included by each source file,
3002 and not through other includes.
3003
e43b6e43
MR
30042011-06-27 Martin Rudalics <rudalics@gmx.at>
3005
3006 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3007 (sort_overlays, overlay_strings): When an overlay's clone number
3008 matches the window's clone number process the overlay even if
3009 the overlay's window property doesn't match the current window.
3010
d68443dc
MR
3011 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3012 (Fwindow_hchild): Rename to Fwindow_left_child.
3013 (Fwindow_next): Rename to Fwindow_next_sibling.
3014 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3015 (resize_window_check): Rename to window_resize_check.
3016 (resize_window_apply): Rename to window_resize_apply.
3017 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3018 (Fdelete_other_windows_internal, resize_frame_windows)
3019 (Fsplit_window_internal, Fdelete_window_internal)
3020 (grow_mini_window, shrink_mini_window)
3021 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3022
c7e73be5
JD
30232011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3024
3025 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3026 (emacs_fixed_set_min_size): Remove.
3027 (emacs_fixed_new): Take frame as argument.
3028
3029 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3030 (_EmacsFixedPrivate): Remove minwidth/height.
3031 Add struct frame *f.
3032 (emacs_fixed_init): Initialize priv->f.
3033 (get_parent_class, emacs_fixed_set_min_size): Remove.
3034 (emacs_fixed_new): Set priv->f to argument.
3035 (emacs_fixed_get_preferred_width)
3036 (emacs_fixed_get_preferred_height): Use min_width/height from
3037 frames size_hint to set minimum and natural (Bug#8919).
3038 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3039 and use min_width/height from frames size_hint to set
3040 min_width/height (Bug#8919).
3041
3042 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3043 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3044 Fix indentation.
c7e73be5 3045
cf99dcf8
EZ
30462011-06-26 Eli Zaretskii <eliz@gnu.org>
3047
3048 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3049 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3050 called at ZV.
3051
029529ac
CY
30522011-06-26 Chong Yidong <cyd@stupidchicken.com>
3053
3054 * process.c (wait_reading_process_output): Bypass select if
3055 waiting for a cell while ignoring keyboard input, and input is
3056 pending. Suggested by Jan Djärv (Bug#8869).
3057
7a7ef429
PE
30582011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3059
3060 Use gnulib's dup2 module instead of rolling our own.
3061 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3062
11fdef7d 30632011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3064
3065 * dispnew.c (scrolling_window): Before scrolling, turn off a
3066 mouse-highlight in the window being scrolled.
3067
cd3520a4
JB
30682011-06-24 Juanma Barranquero <lekktu@gmail.com>
3069
3070 Move DEFSYM to lisp.h and use everywhere.
3071
3072 * character.h (DEFSYM): Move declaration...
3073 * lisp.h (DEFSYM): ...here.
3074
3075 * gnutls.c:
3076 * minibuf.c:
3077 * w32menu.c:
3078 * w32proc.c:
3079 * w32select.c: Don't include character.h.
3080
3081 * alloc.c (syms_of_alloc):
3082 * buffer.c (syms_of_buffer):
3083 * bytecode.c (syms_of_bytecode):
3084 * callint.c (syms_of_callint):
3085 * casefiddle.c (syms_of_casefiddle):
3086 * casetab.c (init_casetab_once):
3087 * category.c (init_category_once, syms_of_category):
3088 * ccl.c (syms_of_ccl):
3089 * cmds.c (syms_of_cmds):
3090 * composite.c (syms_of_composite):
3091 * dbusbind.c (syms_of_dbusbind):
3092 * dired.c (syms_of_dired):
3093 * dispnew.c (syms_of_display):
3094 * doc.c (syms_of_doc):
3095 * editfns.c (syms_of_editfns):
3096 * emacs.c (syms_of_emacs):
3097 * eval.c (syms_of_eval):
3098 * fileio.c (syms_of_fileio):
3099 * fns.c (syms_of_fns):
3100 * frame.c (syms_of_frame):
3101 * fringe.c (syms_of_fringe):
3102 * insdel.c (syms_of_insdel):
3103 * keymap.c (syms_of_keymap):
3104 * lread.c (init_obarray, syms_of_lread):
3105 * macros.c (syms_of_macros):
3106 * msdos.c (syms_of_msdos):
3107 * print.c (syms_of_print):
3108 * process.c (syms_of_process):
3109 * search.c (syms_of_search):
3110 * sound.c (syms_of_sound):
3111 * syntax.c (init_syntax_once, syms_of_syntax):
3112 * terminal.c (syms_of_terminal):
3113 * textprop.c (syms_of_textprop):
3114 * undo.c (syms_of_undo):
3115 * w32.c (globals_of_w32):
3116 * window.c (syms_of_window):
3117 * xdisp.c (syms_of_xdisp):
3118 * xfaces.c (syms_of_xfaces):
3119 * xfns.c (syms_of_xfns):
3120 * xmenu.c (syms_of_xmenu):
3121 * xsettings.c (syms_of_xsettings):
3122 * xterm.c (syms_of_xterm): Use DEFSYM.
3123
4228cf16
TZ
31242011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3125
cd3520a4 3126 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3127
7fcccf1e
PE
31282011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3129
7efb4e0e
PE
3130 Integer and buffer overflow fixes (Bug#8873).
3131
ff5844ad
PE
3132 * print.c (printchar, strout): Check for string overflow.
3133 (PRINTPREPARE, printchar, strout):
3134 Don't set size unless allocation succeeds.
3135
90532f02
PE
3136 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3137 for sizes. Check for string overflow more accurately.
3138 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3139
6d84508d
PE
3140 * macros.c: Integer and buffer overflow fixes.
3141 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3142 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3143 Use ptrdiff_t, not int, for sizes.
3144 Don't increment bufsize until after realloc succeeds.
3145 Check for size-calculation overflow.
3146 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3147
437b2cb4
PE
3148 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3149
8b9ac8b4
PE
3150 * lread.c: Integer overflow fixes.
3151 (read_integer): Radix is now EMACS_INT, not int,
3152 to improve quality of diagnostics for out-of-range radices.
3153 Calculate buffer size correctly for out-of-range radices.
3154 (read1): Check for integer overflow in radices, and in
3155 read-circle numbers.
82cb60d3
PE
3156 (read_escape): Avoid int overflow.
3157 (Fload, openp, read_buffer_size, read1)
3158 (substitute_object_recurse, read_vector, read_list, map_obarray):
3159 Use ptrdiff_t, not int, for sizes.
3160 (read1): Use EMACS_INT, not int, for sizes.
20270765 3161 Check for size overflow.
8b9ac8b4 3162
7fcccf1e
PE
3163 * image.c (cache_image): Check for size arithmetic overflow.
3164
bfbbd7e7
PE
3165 * lread.c: Integer overflow issues.
3166 (saved_doc_string_size, saved_doc_string_length)
3167 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3168 Now ptrdiff_t, not int.
3169 (read1): Don't assume doc string length fits in int. Check for
3170 out-of-range doc string lengths.
3171 (read_list): Don't assume file position fits in int.
39019e54 3172 (read_escape): Check for hex character overflow.
bfbbd7e7 3173
4e323265
LL
31742011-06-22 Leo Liu <sdl.web@gmail.com>
3175
3176 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3177 Move to minibuffer.el.
3178
85fece3e
PE
31792011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3180
20b84ce9 3181 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3182 The following patches are for when GLYPH_DEBUG && !XASSERT.
3183 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3184 * dispnew.c (flush_stdout):
3185 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3186 Mark as externally visible.
3187 * dispnew.c (check_window_matrix_pointers): Now static.
3188 * dispnew.c (window_to_frame_vpos):
3189 * xfns.c (unwind_create_frame):
3190 * xterm.c (x_check_font): Remove unused local.
3191 * scroll.c (CHECK_BOUNDS):
3192 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3193 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3194 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3195 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3196 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3197 Now static.
3198 (debug_method_add): Use va_list and vsprintf rather than relying
3199 on undefined behavior with wrong number of arguments.
3200 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3201 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3202 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3203 since we're not interested in debugging glyphs with old libraries.
3204 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3205 GCC 4.6.0's static checking.
3206
0766b489
PE
32072011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3208
31fd4b32
PE
3209 Integer overflow and signedness fixes (Bug#8873).
3210 A few related buffer overrun fixes, too.
3211
b79e8648
PE
3212 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3213
0766b489
PE
3214 * dispextern.h (struct face.stipple):
3215 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3216 (x_bitmap_mask, x_allocate_bitmap_record)
3217 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3218 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3219 (x_create_bitmap_from_xpm_data):
3220 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3221 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3222 (.bitmaps_last):
3223 * xfaces.c (load_pixmap):
3224 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3225 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3226 (.bitmaps_last, struct x_output.icon_bitmap):
3227 Use ptrdiff_t, not int, for bitmap indexes.
3228 (x_allocate_bitmap_record): Check for size overflow.
3229 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3230
b081724f
PE
3231 Use ptrdiff_t, not int, for overlay counts.
3232 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3233 * editfns.c (overlays_around, get_pos_property):
3234 * textprop.c (get_char_property_and_overlay):
3235 * xdisp.c (next_overlay_change, note_mouse_highlight):
3236 * xfaces.c (face_at_buffer_position):
21514da7
PE
3237 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3238 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3239 (Fnext_overlay_change, Fprevious_overlay_change)
3240 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3241 Use ptrdiff_t, not int, for sizes.
21514da7 3242 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3243
3de73e5e
PE
3244 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3245
2606c57b
PE
3246 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3247 (x_session_initialize): Do not assume string length fits in int.
3248
aaafe47a
PE
3249 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3250 This is unlikely, but can occur if DPI is outlandish.
3251
2674ddc8 3252 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3253 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3254
28154962
PE
3255 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3256 * xrdb.c (magic_file_p, search_magic_path):
3257 Omit last arg SUFFIX; it was always 0. All callers changed.
3258 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3259
7de51af5
PE
3260 * xfont.c (xfont_match): Avoid need for strlen.
3261
25ed6cc3
PE
3262 * xfns.c: Don't assume strlen fits in int.
3263 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3264
4eab31dd
PE
3265 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3266 not unsigned long, as we prefer signed integers. All callers changed.
3267 Detect integer overflow in repeat count.
3268 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3269 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3270
171e2a58
PE
3271 * termcap.c: Don't assume sizes fit in int and never overflow.
3272 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3273 (gobble_line): Check for size-calculation overflow.
3274
ad39faca 3275 * minibuf.c (Fread_buffer):
6e5bb2dc 3276 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3277 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3278 Don't assume string length fits in int.
3279
52c61c22 3280 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3281 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3282
b5b8c9e5
PE
3283 * font.c: Don't assume string length fits in int.
3284 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3285 Use ptrdiff_t, not int.
ccd6111c
PE
3286 (font_intern_prop): Don't assume string length fits in int.
3287 Don't assume integer property fits in fixnum.
3288 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3289
882f0d81 3290 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3291 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3292 Reformulate so as not to need the command string.
3293 Invoke gzip -cd rather than gunzip, as it's more portable.
3294 (lock_info_type, lock_file_1, lock_file):
3295 Don't assume pid_t and time_t fit in unsigned long.
3296 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3297 (current_lock_owner): Prefer signed type for sizes.
3298 Use memcpy, not strncpy, where memcpy is what is really wanted.
3299 Don't assume (via atoi) that time_t and pid_t fit in int.
3300 Check for time_t and/or pid_t out of range, e.g., via a network share.
3301 Don't alloca where an auto var works fine.
3302
93f4cf88
PE
3303 * fileio.c: Fix some integer overflow issues.
3304 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3305 Don't assume string length fits in int.
3306 (directory_file_name): Don't assume string length fits in long.
3307 (make_temp_name): Don't assume pid fits in int, or that its print
3308 length is less than 20.
3309
f3e92b69
PE
3310 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3311
1bfdaf10
PE
3312 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3313
35016e9a
PE
3314 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3315
3d1e65a1
PE
3316 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3317 We prefer signed integers, even for size calculations.
3318
0b963a93
PE
3319 * emacs.c: Don't assume string length fits in 'int'.
3320 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3321 (main): Don't invoke strlen when not needed.
3322
573f4b54
PE
3323 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3324 (XD_DEBUG_MESSAGE): Don't waste a byte.
3325
989f33ba
PE
3326 * callproc.c (getenv_internal_1, getenv_internal)
3327 (Fgetenv_internal):
965d34eb
PE
3328 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3329
e4d29b33
PE
3330 * lread.c (invalid_syntax): Omit length argument.
3331 All uses changed. This doesn't fix a bug, but it simplifies the
3332 code away from its former Hollerith-constant appearance, and it's
3333 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3334 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3335
eb49b136
PE
3336 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3337 This didn't break anything, but it didn't help either.
3338 It's confusing to put a bogus integer in a place where the actual
3339 value does not matter.
9f62aeb1 3340 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3341 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3342
15375a22
PE
3343 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3344 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3345 implementation.
b61cc01c
PE
3346 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3347 We prefer signed types, and the value cannot exceed the EMACS_INT
3348 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3349 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3350 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3351 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3352
53b2623d
PE
3353 * indent.c (sane_tab_width): New function.
3354 (current_column, scan_for_column, Findent_to, position_indentation)
3355 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3356 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3357
51cab52b 3358 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3359
f2ed8a70
PE
3360 * lisp.h (lint_assume): New macro.
3361 * composite.c (composition_gstring_put_cache):
3362 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3363
abe80cc6
PE
3364 * editfns.c, insdel.c:
3365 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3366
b02c740e
PE
3367 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3368
ebc96716
PE
3369 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3370
b4e50fa0 3371 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3372 Use much-faster test for byte-length change.
311d5d7c 3373 Don't assume string byte-length fits in 'int'.
a4cf38e4 3374 Check that character arg fits in 'int'.
85461888 3375 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3376
c0c1ee9f
PE
3377 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3378
a498d7f4
PE
3379 * fns.c (concat): Catch string overflow earlier.
3380 Do not rely on integer wraparound.
3381
51cab52b
PE
3382 * dispextern.h (struct it.overlay_strings_charpos)
3383 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3384 * xdisp.c (forward_to_next_line_start)
3385 (back_to_previous_visible_line_start)
3386 (reseat_at_next_visible_line_start, next_element_from_buffer):
3387 Don't arbitrarily truncate the value of 'selective' to int.
3388
76031fad
PE
3389 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3390
5eb55db9
PE
3391 * composite.c: Don't truncate sizes to 'int'.
3392 (composition_gstring_p, composition_reseat_it)
3393 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3394 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3395 not EMACS_UINT, for indexes.
5eb55db9 3396
0703a717
PE
3397 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3398
d6202519
PE
3399 * buffer.c: Include <verify.h>.
3400 (struct sortvec.priority, struct sortstr.priority):
8961a454 3401 Now EMACS_INT, not int.
c20998a7 3402 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3403 (struct sortstr.size, record_overlay_string)
3404 (struct sortstrlist.size, struct sortlist.used):
3405 Don't truncate size to int.
3406 (record_overlay_string): Check for size-calculation overflow.
d6202519 3407 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3408
d5a19415
JM
34092011-06-22 Jim Meyering <meyering@redhat.com>
3410
029529ac 3411 Don't leak an XBM-image-sized buffer
d5a19415
JM
3412 * image.c (xbm_load): Free the image buffer after using it.
3413
a9041e6c
PE
34142011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3415
3416 Port to Sun C.
3417 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3418 that Sun C diagnosed.
3419 * fns.c (secure_hash): Fix pointer signedness issue.
3420 * intervals.c (static_offset_intervals): New function.
3421 (offset_intervals): Use it.
3422
7f3f739f
LL
34232011-06-21 Leo Liu <sdl.web@gmail.com>
3424
3425 * deps.mk (fns.o):
3426 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3427 sha512.h.
3428
3429 * fns.c (secure_hash): Rename from crypto_hash_function and change
3430 the first arg to accept symbols.
5b66d427 3431 (Fsecure_hash): New primitive.
7f3f739f
LL
3432 (syms_of_fns): New symbols.
3433
76147d94
DD
34342011-06-20 Deniz Dogan <deniz@dogan.se>
3435
3436 * process.c (Fset_process_buffer): Clarify return value in
3437 docstring.
3438
7d7d0045
CY
34392011-06-18 Chong Yidong <cyd@stupidchicken.com>
3440
3441 * dispnew.c (add_window_display_history): Use BVAR.
3442
3443 * xdisp.c (debug_method_add): Use BVAR.
3444 (check_window_end, dump_glyph_matrix, dump_glyph)
3445 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3446
3447 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3448 Likewise.
3449
3450 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3451 check till after the cache is created in init_frame_faces.
3452
ff2bc410
SM
34532011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3454
3455 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3456
28177add
PE
34572011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3458
dd3482fe
PE
3459 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3460 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3461 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3462
393d71f3 3463 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3464 * fileio.c (Finsert_file_contents):
3465 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3466 Remove the old (too-loose) buffer overflow checks.
3467 They weren't needed, since make_gap checks for buffer overflow.
3468 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3469 The old code merely checked for Emacs fixnum overflow, and relied
3470 on undefined (wraparound) behavior. The new code avoids undefined
3471 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3472
2e6813b0 3473 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3474 Tune. Don't use wider integers than needed. Don't use alloca.
3475 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3476
599a9e4f
PE
3477 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3478
99561444
PE
3479 * insdel.c, lisp.h (buffer_overflow): New function.
3480 (insert_from_buffer_1, replace_range, replace_range_2):
3481 * insdel.c (make_gap_larger):
3482 * editfns.c (Finsert_char):
3483 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3484
28177add
PE
3485 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3486
e69dafad
PE
34872011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3488
a7af7fde 3489 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3490
b1c46f02
PE
3491 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3492 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3493
e69dafad
PE
3494 * fileio.c: Don't assume EMACS_INT fits in off_t.
3495 (emacs_lseek): New static function.
3496 (Finsert_file_contents, Fwrite_region): Use it.
3497 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3498
566684ea
PE
3499 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3500
e6966cd6
PE
3501 * fns.c: Don't overflow int when computing a list length.
3502 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3503 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3504 truncation on 64-bit hosts. Check for QUIT every
3505 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3506 faster and is responsive enough.
3507 (Flength): Report an error instead of overflowing an integer.
3508 (Fsafe_length): Return a float if the value is not representable
3509 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3510 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3511 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3512
dd0b0efb
PE
3513 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3514 (header_size, word_size): New constants.
3515 (allocate_vectorlike): Don't check size overflow here.
3516 (allocate_vector): Check it here instead, since this is the only
3517 caller of allocate_vectorlike that could cause overflow.
3518 Check that the new vector's length is representable as a fixnum.
3519
86fe5cfe
PE
3520 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3521 The previous code was bogus. For example, next_almost_prime (32)
3522 returned 39, which is undesirable as it is a multiple of 3; and
3523 next_almost_prime (24) returned 25, which is a multiple of 5 so
3524 why was the code bothering to check for multiples of 7?
3525
80e88859
PE
3526 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3527
4a2f0ad6
PE
3528 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3529
f66c7cf8
PE
3530 Variadic C functions now count arguments with ptrdiff_t.
3531 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3532 Back then I didn't know that the Emacs coding style prefers signed int.
3533 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3534 were being counted with int, which may truncate counts on 64-bit
3535 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3536 * lisp.h (struct Lisp_Subr.function.aMANY)
3537 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3538 Arg counts are now ptrdiff_t, not size_t.
3539 All variadic functions and their callers changed accordingly.
3540 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3541 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3542 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3543 * callint.c (Fcall_interactively): Check arg count for overflow,
3544 to avoid potential buffer overrun. Use signed char, not 'int',
3545 for 'varies' array, so that we needn't bother to check its size
3546 calculation for overflow.
3547 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3548 * eval.c (apply_lambda):
3549 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3550 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3551 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3552
a1759b76
PE
3553 * callint.c (Fcall_interactively): Don't use index var as event count.
3554
d96be9fc
PE
3555 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3556 * mem-limits.h (SIZE): Remove; no longer used.
3557
a690a978 3558 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3559
578c21e6
PE
3560 Remove unnecessary casts.
3561 * xterm.c (x_term_init):
3562 * xfns.c (x_set_border_pixel):
3563 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3564 These aren't needed now that we assume ANSI C.
3565
96f53c6c
PE
3566 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3567 It's more likely to cause problems (due to unsigned overflow)
3568 than to cure them.
3569
83c77d31
PE
3570 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3571
ee2079f1
PE
3572 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3573
6da65536
PE
3574 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3575
7147c4a4
PE
3576 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3577
193e32d9
PE
3578 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3579
e5533da6
PE
3580 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3581
9910e595
PE
3582 GLYPH_CODE_FACE returns EMACS_INT, not int.
3583 * dispextern.h (merge_faces):
3584 * xfaces.c (merge_faces):
01103c44
PE
3585 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3586 Don't assume EMACS_INT fits in int.
9910e595 3587
2638320e
PE
3588 * character.h (CHAR_VALID_P): Remove unused parameter.
3589 * fontset.c, lisp.h, xdisp.c: All uses changed.
3590
045eb8d9
PE
3591 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3592
c1f134b5
PE
3593 * fns.c (concat): Minor tuning based on overflow analysis.
3594 This doesn't fix any bugs. Use int to hold character, instead
3595 of constantly refetching from Emacs object. Use XFASTINT, not
3596 XINT, for value known to be a character. Don't bother comparing
3597 a single byte to 0400, as it's always less.
3598
395fcb93 3599 * floatfns.c (Fexpt):
327eeec8
PE
3600 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3601
abbd3d23
PE
3602 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3603 for characters.
3604
684a03ef
PE
3605 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3606
0fed43f3
PE
3607 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3608 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3609 incorrectly succeed when S was a string, because 4294967386 was
3610 truncated before it was used.
3611
8fd02eb7
PE
3612 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3613 Otherwise, an out-of-range integer could cause undefined behavior
3614 on a 64-bit host.
3615
f8c86b69
PE
3616 * composite.c: Use int, not EMACS_INT, for characters.
3617 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3618 EMACS_INT, for values that are known to be in character range.
3619 This doesn't fix any bugs but is the usual style inside Emacs and
3620 may generate better code on 32-bit machines.
3621
34206dd2
PE
3622 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3623 This is for reasons similar to the recent CHAR_STRING fix.
3624 * charset.c (Fencode_char): Check that character arg is actually
3625 a character. Pass an int to ENCODE_CHAR.
3626 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3627 wider than 'int', as a compile-time check to prevent future regressions
3628 in this area.
3629
c5958d4c 3630 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3631
3632 Make sure a 64-bit char is never passed to CHAR_STRING.
3633 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3634 by silently ignoring the top 32 bits, allowing some values
3635 that were far too large to be valid characters.
3636 * character.h: Include <verify.h>.
3637 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3638 arguments are no wider than unsigned, as a compile-time check
3639 to prevent future regressions in this area.
3640 * data.c (Faset):
01103c44 3641 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3642 (Fsubst_char_in_region):
3643 * fns.c (concat):
3644 * xdisp.c (decode_mode_spec_coding):
3645 Adjust to CHAR_STRING's new requirement.
3646 * editfns.c (Finsert_char, Fsubst_char_in_region):
3647 * fns.c (concat): Check that character args are actually
3648 characters. Without this test, these functions did the wrong
3649 thing with wildly out-of-range values on 64-bit hosts.
3650
d37ca623
PE
3651 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3652 These casts should not be needed on 32-bit hosts, either.
3653 * keyboard.c (read_char):
3654 * lread.c (Fload): Remove casts to unsigned.
3655
ea204efb
PE
3656 * lisp.h (UNSIGNED_CMP): New macro.
3657 This fixes comparison bugs on 64-bit hosts.
3658 (ASCII_CHAR_P): Use it.
3659 * casefiddle.c (casify_object):
01103c44 3660 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3661 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3662 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3663 * dispextern.h (FACE_FROM_ID):
3664 * keyboard.c (read_char): Use UNSIGNED_CMP.
3665
41cb286c
PE
3666 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3667 not to EMACS_INT, to avoid GCC warning.
3668
4a1b9832
PE
3669 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3670
55daad71
PE
3671 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3672 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3673 isn't needed on 32-bit machines.
8f95c75c 3674
01103c44
PE
3675 * buffer.c (Fgenerate_new_buffer_name):
3676 Use EMACS_INT for count, not int.
0ceccced 3677 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3678
3679 * data.c (Qcompiled_function): Now static.
3680
c6f072e7
PE
3681 * window.c (window_body_lines): Now static.
3682
20ce5912
PE
3683 * image.c (gif_load): Rename local to avoid shadowing.
3684
9c4c5f81
PE
3685 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3686 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3687 * alloc.c (make_save_value): Integer argument is now of type
3688 ptrdiff_t, not int.
3689 (mark_object): Use ptrdiff_t, not int.
3690 * lisp.h (pD): New macro.
3691 * print.c (print_object): Use it.
3692
c0c5c8ae
PE
3693 * alloc.c: Use EMACS_INT, not int, to count objects.
3694 (total_conses, total_markers, total_symbols, total_vector_size)
3695 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3696 (total_free_floats, total_floats, total_free_intervals)
3697 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3698 Now EMACS_INT, not int. All uses changed.
3699 (Fgarbage_collect): Compute overall total using a double, so that
3700 integer overflow is less likely to be a problem. Check for overflow
3701 when converting back to an integer.
5a25e253
PE
3702 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3703 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3704 These were 'int' variables that could overflow on 64-bit hosts;
3705 they were never used, so remove them instead of repairing them.
211a0b2a 3706 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3707 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3708 Previously, this ceilinged at INT_MAX, but that doesn't work on
3709 64-bit machines.
e46bb31a 3710 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3711
c78baabf 3712 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3713 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3714 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3715 when a (possibly-narrower) signed value would do just as well.
3716 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3717
c9d624c6
PE
3718 * alloc.c: Catch some string size overflows that we were missing.
3719 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3720 for convenience in STRING_BYTES_MAX.
3721 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3722 The definition here is exact; the one in lisp.h was approximate.
3723 (allocate_string_data): Check for string overflow. This catches
3724 some instances we weren't catching before. Also, it catches
3725 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3726 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3727 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3728
c9d624c6
PE
3729 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3730 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3731 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3732
353032ce
PE
3733 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3734
2bccce07
PE
3735 * alloc.c (Fmake_string): Check for out-of-range init.
3736
0ac30604
SM
37372011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3738
3739 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3740
c195f2de
JD
37412011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3742
3743 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3744 xg_get_default_scrollbar_width.
3745
3746 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3747 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3748 (style_changed_cb): Call update_theme_scrollbar_width and call
3749 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3750 all frames (Bug#8505).
3751 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3752 Call gtk_window_set_resizable if HAVE_GTK3.
3753 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3754 and height if HAVE_GTK3 (Bug#8505).
3755 (scroll_bar_width_for_theme): New variable.
3756 (update_theme_scrollbar_width): New function.
3757 (xg_get_default_scrollbar_width): Move code to
3758 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3759 (xg_initialize): Call update_theme_scrollbar_width.
3760
3761 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3762
3763 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3764
e10ac9f1
MR
37652011-06-12 Martin Rudalics <rudalics@gmx.at>
3766
3767 * frame.c (make_frame): Call other_buffer_safely instead of
3768 other_buffer.
3769
3770 * window.c (temp_output_buffer_show): Call display_buffer with
3771 second argument Vtemp_buffer_show_specifiers and reset latter
3772 immediately after the call.
3773 (Vtemp_buffer_show_specifiers): New variable.
3774 (auto_window_vscroll_p, next_screen_context_lines)
3775 (Vscroll_preserve_screen_position): Remove leading asterisks from
3776 doc-strings.
3777
2d3c217e 37782011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3779
7b7f97e8 3780 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3781 * buffer.c (Qclone_number): Remove for now, as it's unused.
3782 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3783 (record_buffer): Remove unused local.
3784 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3785 (set_frame_buffer_list): Remove; unused.
3786 * frame.h (other_visible_frames): Remove decl.
3787 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3788 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3789 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3790 if HAVE_GPM.
3791 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3792 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3793 Define only if HAVE_GPM.
3794 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3795 (update_hints_inhibit): Remove; never set. All uses removed.
3796 * widgetprv.h (emacsFrameClassRec): Remove decl.
3797 * window.c (delete_deletable_window): Now returns void, since it
3798 wasn't returning anything.
3799 (compare_window_configurations): Remove unused locals.
3800 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3801 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3802 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3803 the same widths as pointers. This follows up on the 2011-05-06 patch.
3804 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3805 * xterm.h: Likewise.
3806 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3807
1384b89e
JB
38082011-06-12 Juanma Barranquero <lekktu@gmail.com>
3809
3810 * makefile.w32-in: Update dependencies.
3811 (LISP_H): Add lib/intprops.h.
3812
1100a63c
CY
38132011-06-11 Chong Yidong <cyd@stupidchicken.com>
3814
3815 * image.c (gif_load): Add animation frame delay to the metadata.
3816 (syms_of_image): Use DEFSYM. New symbol `delay'.
3817
6198ccd0
MR
38182011-06-11 Martin Rudalics <rudalics@gmx.at>
3819
3820 * window.c (delete_deletable_window): Re-add.
3821 (Fset_window_configuration): Rewrite to handle dead buffers and
3822 consequently deletable windows.
3823 (window_tree, Fwindow_tree): Remove. Supply functionality in
3824 window.el.
3825 (compare_window_configurations): Simplify code.
3826
b6e3633c
AS
38272011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3828
1ab0dee5
AS
3829 * image.c (imagemagick_load_image): Fix type mismatch.
3830 (Fimagemagick_types): Likewise.
3831
b6e3633c
AS
3832 * window.h (replace_buffer_in_windows): Declare.
3833
9397e56f
MR
38342011-06-11 Martin Rudalics <rudalics@gmx.at>
3835
3836 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3837 Qclone_number. Remove external declaration of Qdelete_window.
3838 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3839 code.
640c8776
SM
3840 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3841 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3842 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3843 buffer list implementation.
3844 (other_buffer_safely): New function.
3845 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3846 calls to replace_buffer_in_windows and
3847 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3848 if allowed.
3849 (record_buffer): Inhibit quitting and rewrite using quittable
3850 functions. Run Qbuffer_list_update_hook if allowed.
3851 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3852 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3853 Move switch-to-buffer to window.el.
9397e56f
MR
3854 (bury-buffer): Move to window.el.
3855 (Vbuffer_list_update_hook): New variable.
3856
3857 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3858 section.
3859
3860 * window.h (resize_frame_windows): Move up in code.
3861 (Fwindow_frame): Remove EXFUN.
3862 (replace_buffer_in_all_windows): Remove prototype.
3863 (replace_buffer_in_windows_safely): Add prototype.
3864
3865 * window.c: Declare Qdelete_window static again. Move down
3866 declaration of select_count.
3867 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3868 (Fother_window): Move to window.el.
3869 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3870 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3871 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3872 window.el.
3873 (replace_buffer_in_windows): Implement by calling
3874 Qreplace_buffer_in_windows.
3875 (replace_buffer_in_all_windows): Remove with some functionality
3876 moved into replace_buffer_in_windows_safely.
3877 (replace_buffer_in_windows_safely): New function.
3878 (select_window_norecord, select_frame_norecord): Move in front
3879 of run_window_configuration_change_hook. Remove now obsolete
3880 declarations.
640c8776
SM
3881 (Fset_window_buffer): Rewrite doc-string.
3882 Call Qrecord_window_buffer.
9397e56f
MR
3883 (keys_of_window): Move binding for other-window to window.el.
3884
b50691aa
CY
38852011-06-11 Chong Yidong <cyd@stupidchicken.com>
3886
3887 * dispextern.h (struct image): Replace data member, whose int_val
3888 and ptr_val fields were not used by anything, with a single
3889 lisp_val object.
3890
3891 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3892 (gif_clear_image, gif_load, imagemagick_load_image)
3893 (gs_clear_image, gs_load): Callers changed.
3894
3f754b86
PE
38952011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3896
cca69397
PE
3897 * buffer.h: Include <time.h>, for time_t.
3898 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3899
109e28d0
PE
3900 Fix minor problems found by static checking.
3901
60737f02
PE
3902 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3903
4b66faf3
PE
3904 Make identifiers static if they are not used in other modules.
3905 * data.c (Qcompiled_function, Qframe, Qvector):
3906 * image.c (QimageMagick, Qsvg):
3907 * minibuf.c (Qmetadata):
3908 * window.c (resize_window_check, resize_root_window): Now static.
3909 * window.h (resize_window_check, resize_root_window): Remove decls.
3910
109e28d0
PE
3911 * window.c (window_deletion_count, delete_deletable_window):
3912 Remove; unused.
46a4ce9e
PE
3913 (window_body_lines): Now static.
3914 (Fdelete_other_windows_internal): Mark vars as initialized.
3915 Make sure 'resize_failed' is initialized.
3916 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3917 (resize_window_apply): Remove unused local.
3918 * window.h (delete_deletable_window): Remove decl.
3919
109e28d0 3920 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3921 (imagemagick_load_image): Fix pointer signedness problem by changing
3922 last arg from unsigned char * to char *. All uses changed.
3923 Also, fix a local for similar reasons.
3924 Remove unused locals. Remove locals to avoid shadowing.
3925 (fn_rsvg_handle_free): Remove; unused.
3926 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3927 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3928
3f754b86
PE
3929 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3930
2547adb1
CY
39312011-06-10 Chong Yidong <cyd@stupidchicken.com>
3932
3933 * image.c (gif_load): Fix omitted cast error introduced by
3934 2011-06-06 change.
3935
2c8e37d4
MR
39362011-06-10 Martin Rudalics <rudalics@gmx.at>
3937
3938 * window.h (resize_proportionally, orig_total_lines)
3939 (orig_top_line): Remove from window structure.
3940 (set_window_height, set_window_width, change_window_heights)
3941 (Fdelete_window): Remove prototypes.
3942 (resize_frame_windows): Remove duplicate declaration.
3943
440a42e3
EZ
39442011-06-10 Eli Zaretskii <eliz@gnu.org>
3945
3946 * window.h (resize_frame_windows, resize_window_check)
3947 (delete_deletable_window, resize_root_window)
3948 (resize_frame_windows): Declare prototypes.
3949
3950 * window.c (resize_window_apply): Make definition be "static" to
3951 match the prototype.
3952
562dd5e9
MR
39532011-06-10 Martin Rudalics <rudalics@gmx.at>
3954
3955 * window.c: Remove declarations of Qwindow_size_fixed,
3956 window_min_size_1, window_min_size_2, window_min_size,
3957 size_window, window_fixed_size_p, enlarge_window, delete_window.
3958 Remove static from declaration of Qdelete_window, it's
3959 temporarily needed by Fbury_buffer.
3960 (replace_window): Don't assign orig_top_line and
3961 orig_total_lines.
3962 (Fdelete_window, delete_window): Remove. Window deletion is
3963 handled by window.el.
640c8776
SM
3964 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3965 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3966 (Fdelete_other_windows): Remove. Deleting other windows is
3967 handled by window.el.
3968 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3969 handled in window.el.
3970 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3971 Window minimum sizes are handled in window.el.
3972 (shrink_windows, size_window, set_window_height)
3973 (set_window_width, change_window_heights, window_height)
3974 (window_width, CURBEG, CURSIZE, enlarge_window)
3975 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3976 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3977 handled in window.el.
3978 (make_dummy_parent): Rename to make_parent_window and give it a
3979 second argument horflag.
3980 (make_window): Don't set resize_proportionally any more.
3981 (Fsplit_window): Remove. Windows are split in window.el.
3982 (save_restore_action, save_restore_orig_size)
3983 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3984 Resize mini windows in window.el.
3985 (grow_mini_window, shrink_mini_window): Implement by calling
3986 Qresize_root_window_vertically, resize_window_check and
3987 resize_window_apply.
640c8776
SM
3988 (saved_window, Fset_window_configuration, save_window_save):
3989 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3990 resize_proportionally.
3991 (window_min_height, window_min_width): Move to window.el.
3992 (keys_of_window): Move bindings for delete-other-windows,
3993 split-window, delete-window and enlarge-window to window.el.
3994
3995 * buffer.c: Temporarily extern Qdelete_window.
3996 (Fbury_buffer): Temporarily call Qdelete_window instead of
3997 Fdelete_window (Fbury_buffer will move to window.el soon).
3998
3999 * frame.c (set_menu_bar_lines_1): Remove code handling
4000 orig_top_line and orig_total_lines.
4001
4002 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4003 set_window_height but set heights directly.
4004 (change_frame_size_1): Use resize_frame_windows.
4005
4006 * xdisp.c (init_xdisp): Don't use set_window_height but set
4007 heights directly.
4008
640c8776
SM
4009 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4010 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4011 run_window_configuration_change_hook.
4012
4013 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4014 instead of change_window_heights and run
4015 run_window_configuration_change_hook.
4016
1a13852e
MR
40172011-06-09 Martin Rudalics <rudalics@gmx.at>
4018
4019 * window.c (replace_window): Rename second argument REPLACEMENT to
4020 NEW. New third argument SETFLAG. Rewrite.
4021 (delete_window, make_dummy_parent): Call replace_window with
4022 third argument 1.
4023 (window_list_1): Move down in code.
4024 (run_window_configuration_change_hook): Move set_buffer part
4025 before select_frame_norecord part in order to unwind correctly.
4026 Rename count1 to count.
4027 (recombine_windows, delete_deletable_window, resize_root_window)
4028 (Fdelete_other_windows_internal)
4029 (Frun_window_configuration_change_hook, make_parent_window)
4030 (resize_window_check, resize_window_apply, Fresize_window_apply)
4031 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4032 (Fdelete_window_internal, Fresize_mini_window_internal):
4033 New functions.
1a13852e
MR
4034 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4035
f3d1777e
MR
40362011-06-08 Martin Rudalics <rudalics@gmx.at>
4037
496e208e
MR
4038 * window.h (window): Add some new members to window structure -
4039 normal_lines, normal_cols, new_total, new_normal, clone_number,
4040 splits, nest, prev_buffers, next_buffers.
4041 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4042 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4043
f3d1777e
MR
4044 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4045 Remove.
496e208e
MR
4046 (make_dummy_parent): Set new members of windows structure.
4047 (make_window): Move down in code. Handle new members of window
4048 structure.
4049 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4050 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4051 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4052 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4053 (Fset_window_next_buffers, Fset_window_clone_number):
4054 New functions.
496e208e
MR
4055 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4056 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4057 Doc-string fixes.
4058 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4059 Argument WINDOW can be now internal window too.
4060 (Fwindow_use_time): Move up in code.
4061 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4062 Rewrite doc-string.
4063 (Fset_window_configuration, saved_window)
4064 (Fcurrent_window_configuration, save_window_save): Handle new
4065 members of window structure.
b9e809c2
MR
4066 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4067 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4068 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4069 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4070 Qget_mru_window, Qresize_root_window,
4071 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4072 Qauto_buffer_name; staticpro them.
f3d1777e 4073
abde8f8c
MR
40742011-06-07 Martin Rudalics <rudalics@gmx.at>
4075
4076 * window.c (Fwindow_total_size, Fwindow_left_column)
4077 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4078 (Fwindow_list_1): New functions.
4079 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4080 (Fwindow_width, Fscroll_left, Fscroll_right):
4081 Use window_body_cols instead of window_box_text_cols.
4082 (delete_window, Fset_window_configuration):
4083 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4084 (delete_all_subwindows): Take a window as argument and not a
4085 structure. Rewrite.
190b47e6
MR
4086 (window_loop): Remove handling of GET_LRU_WINDOW and
4087 GET_LARGEST_WINDOW.
4088 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4089
4090 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4091 window_box_text_cols. delete_all_subwindows now takes a
4092 Lisp_Object as argument.
abde8f8c 4093
640c8776
SM
4094 * indent.c (compute_motion, Fcompute_motion):
4095 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4096
fa8a67e6
MR
4097 * frame.c (delete_frame): Call delete_all_subwindows with root
4098 window as argument.
4099
a54e3482
DC
41002011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4101
4102 * fns.c (Fputhash): Document return value.
4103
60002bf5
CY
41042011-06-06 Chong Yidong <cyd@stupidchicken.com>
4105
4106 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4107
0c671da6 41082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4109
b862a52a 4110 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4111
be44ca6c
PE
4112 Check for overflow when converting integer to cons and back.
4113 * charset.c (Fdefine_charset_internal, Fdecode_char):
4114 Use cons_to_unsigned to catch overflow.
4115 (Fencode_char): Use INTEGER_TO_CONS.
4116 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4117 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4118 * data.c (long_to_cons, cons_to_long): Remove.
4119 (cons_to_unsigned, cons_to_signed): New functions.
4120 These signal an error for invalid or out-of-range values.
4121 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4122 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4123 * font.c (Ffont_variation_glyphs):
4124 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4125 * lisp.h: Include <intprops.h>.
4126 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4127 (cons_to_signed, cons_to_unsigned): New decls.
4128 (long_to_cons, cons_to_long): Remove decls.
4129 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4130 (Fprimitive_undo): Use CONS_TO_INTEGER.
4131 * xfns.c (Fx_window_property): Likewise.
4132 * xselect.c: Include <limits.h>.
4133 (x_own_selection, selection_data_to_lisp_data):
4134 Use INTEGER_TO_CONS.
4135 (x_handle_selection_request, x_handle_selection_clear)
4136 (x_get_foreign_selection, Fx_disown_selection_internal)
4137 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4138 (lisp_data_to_selection_data): Use cons_to_unsigned.
4139 (x_fill_property_data): Use cons_to_signed.
4140 Report values out of range.
4141
d1f3d2af
PE
4142 Check for buffer and string overflow more precisely.
4143 * buffer.h (BUF_BYTES_MAX): New macro.
4144 * lisp.h (STRING_BYTES_MAX): New macro.
4145 * alloc.c (Fmake_string):
4146 * character.c (string_escape_byte8):
4147 * coding.c (coding_alloc_by_realloc):
4148 * doprnt.c (doprnt):
4149 * editfns.c (Fformat):
4150 * eval.c (verror):
4151 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4152 since they may not be the same number.
4153 * editfns.c (Finsert_char):
4154 * fileio.c (Finsert_file_contents):
4155 Likewise for BUF_BYTES_MAX.
4156
dd52fcea
PE
4157 * image.c: Use ptrdiff_t, not int, for sizes.
4158 (slurp_file): Switch from int to ptrdiff_t.
4159 All uses changed.
4160 (slurp_file): Check that file size fits in both size_t (for
4161 malloc) and ptrdiff_t (for sanity and safety).
4162
7f9bbdbb
PE
4163 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4164 if b->modtime has its maximal value.
4165
dfe18f82
PE
4166 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4167
84acfcf0
PE
4168 Don't assume time_t can fit into int.
4169 * buffer.h (struct buffer.modtime): Now time_t, not int.
4170 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4171 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4172
ccd9a01a
PE
4173 Minor fixes for signed vs unsigned integers.
4174 * character.h (MAYBE_UNIFY_CHAR):
4175 * charset.c (maybe_unify_char):
4176 * keyboard.c (read_char, reorder_modifiers):
4177 XINT -> XFASTINT, since the integer must be nonnegative.
4178 * ftfont.c (ftfont_spec_pattern):
4179 * keymap.c (access_keymap, silly_event_symbol_error):
4180 XUINT -> XFASTINT, since the integer must be nonnegative.
4181 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4182 since it makes no difference and we prefer signed.
4183 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4184 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4185 nonnegative.
4186
d6d100dd
SM
41872011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4188
4189 * window.h (Fwindow_frame): Declare.
4190
2b6148e4
PE
41912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4192
4193 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4194 (SPARE_MEMORY): Always define.
4195 (LARGE_REQUEST): Remove.
4196 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4197
f230ecc9
MR
41982011-06-06 Martin Rudalics <rudalics@gmx.at>
4199
727e958e
MR
4200 * lisp.h: Move EXFUNS for Fframe_root_window,
4201 Fframe_first_window and Fset_frame_selected_window to window.h.
4202
4203 * window.h: Move EXFUNS for Fframe_root_window,
4204 Fframe_first_window and Fset_frame_selected_window here from
4205 lisp.h.
4206
4207 * frame.c (Fwindow_frame, Fframe_first_window)
4208 (Fframe_root_window, Fframe_selected_window)
4209 (Fset_frame_selected_window): Move to window.c.
4210 (Factive_minibuffer_window): Move to minibuf.c.
4211 (Fother_visible_frames_p): New function.
4212
4213 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4214
f230ecc9
MR
4215 * window.c (decode_window, decode_any_window): Move up in code.
4216 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4217 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4218 (Fwindow_buffer): Move up and rewrite doc-string.
4219 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4220 (Fwindow_prev): New functions.
727e958e
MR
4221 (Fwindow_frame): Move here from frame.c. Accept any window as
4222 argument.
4223 (Fframe_root_window, Fframe_first_window)
4224 (Fframe_selected_window): Move here from frame.c. Accept frame
4225 or arbitrary window as argument. Update doc-strings.
4226 (Fminibuffer_window): Move up in code.
4227 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4228 (Fset_frame_selected_window): Move here from frame.c.
4229 Marginal rewrite.
727e958e
MR
4230 (Fselected_window, select_window, Fselect_window): Move up in
4231 code. Minor doc-string fixes.
f230ecc9 4232
4d09bcf6
PE
42332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4234
4235 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4236 Do not assume that spare memory exists; that assumption is valid
4237 only if SYSTEM_MALLOC.
4238 (LARGE_REQUEST): New macro, so that the issue of large requests
4239 is separated from the issue of spare memory.
4240
810928a2
AS
42412011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4242
172418ad
AS
4243 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4244 format. (Bug#8806)
4245
43f862f7
AS
4246 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4247
810928a2
AS
4248 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4249 before statements.
4250
a059fe24
JD
42512011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4252
4253 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4254
4255 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4256
4257 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4258 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4259
989bf368
JB
42602011-06-05 Juanma Barranquero <lekktu@gmail.com>
4261
4262 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4263
4b80f674
CY
42642011-06-04 Chong Yidong <cyd@stupidchicken.com>
4265
4266 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4267 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4268 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4269 New error handlers.
4b80f674
CY
4270 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4271 Obey Vx_select_enable_clipboard_manager. Catch errors in
4272 x_clipboard_manager_save (Bug#8779).
4273 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4274 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4275
99a33b77 42762011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4277
4278 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4279
99a33b77 42802011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4281
4282 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4283 in the current matrix if keep_current_p is non-zero.
4284
8264569d
EZ
42852011-06-04 Eli Zaretskii <eliz@gnu.org>
4286
4287 * bidi.c (bidi_level_of_next_char): Fix last change.
4288
57f97249
EZ
42892011-06-03 Eli Zaretskii <eliz@gnu.org>
4290
fec2107c 4291 Support bidi reordering of text covered by display properties.
57f97249 4292
fec2107c
EZ
4293 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4294 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4295 (bidi_cache_search, bidi_cache_iterator_state)
4296 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4297 (bidi_level_of_next_char, bidi_move_to_visually_next):
4298 Support character positions inside a run of characters covered by a
fec2107c
EZ
4299 display string.
4300 (bidi_paragraph_init, bidi_resolve_explicit_1)
4301 (bidi_level_of_next_char): Call bidi_fetch_char and
4302 bidi_fetch_char_advance instead of FETCH_CHAR and
4303 FETCH_CHAR_ADVANCE.
4304 (bidi_init_it): Initialize new members.
4305 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4306 definitions.
4307 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4308 instead of using explicit *_CHAR codes.
d6d100dd
SM
4309 (bidi_resolve_explicit, bidi_resolve_weak):
4310 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4311 bidirectional text is supported only in multibyte buffers.
4312 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4313 it to initialize the frame_window_p member of struct bidi_it.
4314 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4315 (bidi_resolve_explicit, bidi_resolve_weak)
4316 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4317 bidi_it->nchars is non-positive.
4318 (bidi_level_of_next_char): Don't try to lookup the cache for the
4319 next/previous character if nothing is cached there yet, or if we
4320 were just reseat()'ed to a new position.
c40e2fb2 4321
0e14fe90
EZ
4322 * xdisp.c (set_cursor_from_row): Set start and stop points
4323 according to the row's direction when priming the loop that looks
4324 for the glyph on which to display cursor.
4325 (single_display_spec_intangible_p): Function deleted.
4326 (display_prop_intangible_p): Reimplement to call
4327 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4328 Accept 3 additional arguments needed by handle_display_spec.
4329 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4330 values: lists, `(when COND...)' forms, etc.
4331 (single_display_spec_string_p): Support property values that are
4332 lists with the argument STRING its top-level element.
4333 (display_prop_string_p): Fix the condition for processing a
4334 property that is a list to be consistent with handle_display_spec.
fec2107c 4335 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4336 last portion of handle_display_prop.
4337 (compute_display_string_pos): Accept additional argument
4338 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4339 value of a `display' property is a "replacing spec".
4340 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4341 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4342 the display property, but just return a value indicating whether
4343 the display property will replace the characters it covers.
4344 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4345 frame_window_p members of struct bidi_it.
d6d100dd
SM
4346 (compute_display_string_pos, compute_display_string_end):
4347 New functions.
fec2107c
EZ
4348 (push_it): Accept second argument POSITION, where pop_it should
4349 jump to continue iteration.
4350 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4351
fec2107c
EZ
4352 * keyboard.c (adjust_point_for_property): Adjust the call to
4353 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4354
4355 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4356 (bidi_init_it): Update prototypes.
4357 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4358 (compute_display_string_pos, compute_display_string_end):
4359 Declare prototypes.
fec2107c
EZ
4360 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4361 EMACS_INT.
fc6f18ce 4362
40087514 43632011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4364
57f53182
PE
4365 Malloc failure behavior now depends on size of allocation.
4366 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4367 * lisp.h: Change signatures accordingly.
4368 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4369 All callers changed. (Bug#8762)
4370
4371 * gnutls.c: Use Emacs's memory allocators.
4372 Without this change, the gnutls library would invoke malloc etc.
4373 directly, which causes problems on non-SYNC_INPUT hosts, and which
4374 runs afoul of improving memory_full behavior. (Bug#8761)
4375 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4376 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4377 xfree instead of the default malloc, realloc, free.
4378 (Fgnutls_boot): No need to check for memory allocation failure,
4379 since xmalloc does that for us.
4380
ac32cd99 4381 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4382 * category.c (hash_get_category_set):
4383 * ccl.c (ccl_driver):
4384 * charset.c (Fdefine_charset_internal):
4385 * charset.h (struct charset.hash_index):
4386 * composite.c (get_composition_id, gstring_lookup_cache)
4387 (composition_gstring_put_cache):
4388 * composite.h (struct composition.hash_index):
4389 * dispextern.h (struct image.hash):
4390 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4391 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4392 (hashfn_equal, hashfn_user_defined, make_hash_table)
4393 (maybe_resize_hash_table, hash_lookup, hash_put)
4394 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4395 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4396 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4397 * image.c (make_image, search_image_cache, lookup_image)
4398 (xpm_put_color_table_h):
4399 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4400 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4401 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4402 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4403 * alloc.c (allocate_vectorlike):
4404 Check for overflow in vector size calculations.
4405 * ccl.c (ccl_driver):
4406 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4407 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4408 need to be updated by these changes.
40087514
PE
4409 * fns.c (make_hash_table, maybe_resize_hash_table):
4410 Check for integer overflow with large hash tables.
0de4bb68
PE
4411 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4412 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4413 (SXHASH_REDUCE): New macro.
4414 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4415 Use it instead of discarding useful hash info with large hash values.
4416 (sxhash_float): New function.
4417 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4418 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4419 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4420 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4421 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4422 Adjust signatures to match updated version of code.
4423 (consing_since_gc): Now EMACS_INT, since a single hash table can
4424 use more than INT_MAX bytes.
4425
698d32e2
DN
44262011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4427
4428 Make it possible to build with GCC-4.6+ -O2 -flto.
4429
4430 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4431
fd6fa53f
SM
44322011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4433
4434 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4435 Call minibuffer-inactive-mode.
4436
864db017
JB
44372011-05-31 Juanma Barranquero <lekktu@gmail.com>
4438
4439 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4440 Update dependencies.
4441
2ad0baf4
DN
44422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4443
4444 * data.c (init_data): Remove code for UTS, this system is not
4445 supported anymore.
4446
4fcc2638
DN
44472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4448
4449 Don't force ./temacs to start in terminal mode.
4450
4451 * frame.c (make_initial_frame): Initialize faces in all cases, not
4452 only when CANNOT_DUMP is defined.
4453 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4454
c56e0fd5
DN
44552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4456
4457 * dispnew.c (add_window_display_history): Use const for the string
4458 pointer. Remove declaration, not needed.
4459
333d54da 44602011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4461
55d4c1b2 4462 Use 'inline', not 'INLINE'.
333d54da 4463 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4464 * alloc.c, fontset.c (INLINE): Remove.
4465 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4466 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4467 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4468 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4469 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4470
738db178
DN
44712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4472
4473 Make it possible to run ./temacs.
4474
4475 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4476 syms_of_callproc does the same thing. Remove test for
4477 "initialized", do it in the caller.
4478 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4479
620c53a6
SM
44802011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4481
4482 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4483 (read_minibuf): Use get_minibuffer.
4484 (syms_of_minibuf): Use DEFSYM.
4485 (Qmetadata): New var.
4486 * data.c (Qbuffer): Don't make it static.
4487 (syms_of_data): Use DEFSYM.
4488
e003a292
PE
44892011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4490
4491 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4492 (CCL_CODE_MIN): New macro.
4493
ed008a6d
PE
44942011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4495
3687c2ef
PE
4496 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4497
ed008a6d
PE
4498 * eval.c (Qdebug): Now static.
4499 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4500 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4501 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4502
d66c4c7c
CY
45032011-05-29 Chong Yidong <cyd@stupidchicken.com>
4504
4505 * image.c: Various fixes to ImageMagick code comments.
4506 (Fimagemagick_types): Doc fix.
4507
5fbc2025
PE
45082011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4509
0196f88a
PE
4510 Minor fixes prompted by GCC 4.6.0 warnings.
4511
4512 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4513
5fbc2025
PE
4514 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4515 (x_clipboard_manager_save_all): Move extern decl to ...
4516 * xterm.h: ... here, so that it can be checked for consistency.
4517
1dd3c2d9
CY
45182011-05-29 Chong Yidong <cyd@stupidchicken.com>
4519
4520 * xselect.c (x_clipboard_manager_save_frame)
4521 (x_clipboard_manager_save_all): New functions.
4522 (Fx_clipboard_manager_save): Lisp function deleted.
4523
4524 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4525 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4526
4527 * xterm.h: Update prototype.
4528
5ba6571d
WX
45292011-05-28 William Xu <william.xwl@gmail.com>
4530
4531 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4532 exiting (Bug#8239).
4533
3eaff834
JM
45342011-05-28 Jim Meyering <meyering@redhat.com>
4535
e1900994 4536 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4537 * fns.c (to_uchar): Define.
4538 (crypto_hash_function): Use it to convert some newly-signed
4539 variables to unsigned, to avoid sign-extension bugs. For example,
4540 without this change, (md5 "truc") would evaluate to
4541 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4542 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4543 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4544
0f6990a7
PE
45452011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4546
4547 Integer overflow fixes.
c8a9ca5a 4548
08686060
PE
4549 * dbusbind.c: Serial number integer overflow fixes.
4550 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4551 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4552 to hold a serial number that is too large for a fixnum.
4553 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4554 Check for serial numbers out of range. Decode any serial number
59568bf0 4555 that was so large that it became a float. (Bug#8722)
08686060 4556
2d1fc3c7
PE
4557 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4558 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4559 Use XFASTINT rather than XUINT when numbers are nonnegative.
4560 (xd_append_arg, Fdbus_method_return_internal):
4561 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4562 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4563 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4564 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4565 (Bug#8722)
2d1fc3c7 4566
c8a9ca5a
PE
4567 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4568
519e1d69
PE
4569 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4570
30569699
PE
4571 ccl: add integer overflow checks
4572 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4573 (IN_INT_RANGE): New macros.
4574 (ccl_driver): Use them to check for integer overflow when
4575 decoding a CCL program. Many of the new checks are whether XINT (x)
4576 fits in int; it doesn't always, on 64-bit hosts. The new version
4577 doesn't catch all possible integer overflows, but it's an
847044ea 4578 improvement. (Bug#8719)
30569699 4579
c11285dc
PE
4580 * alloc.c (make_event_array): Use XINT, not XUINT.
4581 There's no need for unsigned here.
4582
fdccd48e
PE
4583 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4584 This follows up to the 2011-05-06 change that substituted uintptr_t
4585 for EMACS_INT. This case wasn't caught back then.
4586
37910ab2
PE
4587 Rework Fformat to avoid integer overflow issues.
4588 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4589 now (part of C89). Include <verify.h>.
4590 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4591 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4592 (Fformat): Avoid the prepass trying to compute sizes; it was only
4593 approximate and thus did not catch overflow reliably. Instead, walk
4594 through the format just once, formatting and computing sizes as we go,
4595 checking for integer overflow at every step, and allocating a larger
4596 buffer as needed. Keep track separately whether the format is
4597 multibyte. Keep only the most-recently calculated precision, rather
4598 than them all. Record whether each argument has been converted to
4599 string. Use EMACS_INT, not int, for byte and char and arg counts.
4600 Support field widths and precisions larger than INT_MAX. Avoid
4601 sprintf's undefined behavior with conversion specifications such as %#d
4602 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4603 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4604 formatting out-of-range floating point numbers with int
9173deec 4605 formats. (Bug#8668)
37910ab2 4606
2e6578fb
PE
4607 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4608
0ae6bdee
PE
4609 * data.c: Avoid integer truncation in expressions involving floats.
4610 * data.c: Include <intprops.h>.
4611 (arith_driver): When there's an integer overflow in an expression
4612 involving floating point, convert the integers to floating point
4613 so that the resulting value does not suffer from catastrophic
4614 integer truncation. For example, on a 64-bit host (* 4
4615 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4616 Do not rely on undefined behavior after integer overflow.
4617
de883a70
PE
4618 merge count_size_as_multibyte, parse_str_to_multibyte
4619 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4620 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4621 Check for integer overflow.
4622 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4623 since it's now a duplicate of the other. This is more of
4624 a character than a buffer op, so better that it's in character.c.
4625 * fns.c, print.c: Adjust to above changes.
4626
2ff916cb
PE
46272011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4628
4629 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4630
f1b54466
PE
46312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4632
fb1ac845
PE
4633 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4634 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4635 (x_clipboard_manager_save): Now static.
4636 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4637
f1b54466
PE
4638 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4639 (crypto_hash_function): Now static.
4640 Fix pointer signedness problems. Avoid unnecessary initializations.
4641
a9f737ee
CY
46422011-05-27 Chong Yidong <cyd@stupidchicken.com>
4643
4644 * termhooks.h (Vselection_alist): Make it terminal-local.
4645
4646 * terminal.c (create_terminal): Initialize it.
4647
4648 * xselect.c: Support for clipboard managers.
4649 (Vselection_alist): Move to termhooks.h as terminal-local var.
4650 (LOCAL_SELECTION): New macro.
4651 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4652 (symbol_to_x_atom): Remove gratuitous arg.
4653 (x_handle_selection_request, lisp_data_to_selection_data)
4654 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4655 (x_own_selection, x_get_local_selection, x_convert_selection):
4656 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4657 (some_frame_on_display): Delete unused function.
4658 (Fx_own_selection_internal, Fx_get_selection_internal)
4659 (Fx_disown_selection_internal, Fx_selection_owner_p)
4660 (Fx_selection_exists_p): New optional frame arg.
4661 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4662 (x_handle_selection_clear): Don't treat other terminals with the
4663 same keyboard specially. Use the terminal-local Vselection_alist.
4664 (x_clear_frame_selections): Use Frun_hook_with_args.
4665
4666 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4667
4668 * xterm.h: Add support for those atoms.
4669
e067f0c1
CY
46702011-05-26 Chong Yidong <cyd@stupidchicken.com>
4671
4672 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4673 (converted_selections, conversion_fail_tag): New global variables.
4674 (x_selection_request_lisp_error): Free the above.
4675 (x_get_local_selection): Remove unnecessary code.
4676 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4677 of converted selections stored in converted_selections.
4678 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4679 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4680 (x_convert_selection): New function.
4681 (x_handle_selection_event): Simplify.
4682 (x_get_foreign_selection): Don't ignore incoming requests while
4683 waiting for an answer; this will fail when we implement
4684 SAVE_TARGETS, and seems unnecessary anyway.
4685 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4686 (Vx_sent_selection_functions): Doc fix.
4687
0f4aebc0
LL
46882011-05-26 Leo Liu <sdl.web@gmail.com>
4689
4690 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4691
e61124cd
YM
46922011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4693
4694 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4695
4696 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4697 for fringe update if it has periodic bitmap.
ac389d0c 4698 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4699 and fringe_bitmap_periodic_p.
4700
4701 * fringe.c (get_fringe_bitmap_data): New function.
4702 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4703 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4704 row. Mark glyph row for fringe update if periodicity changed.
4705
4706 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4707 for fringe update unless it has periodic bitmap.
4708
f16d9837
KH
47092011-05-25 Kenichi Handa <handa@m17n.org>
4710
4711 * xdisp.c (get_next_display_element): Set correct it->face_id for
4712 a static composition.
4713
e1b90ef6
LL
47142011-05-24 Leo Liu <sdl.web@gmail.com>
4715
4716 * deps.mk (fns.o):
4717 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4718
4719 * fns.c (crypto_hash_function, Fsha1): New function.
4720 (Fmd5): Use crypto_hash_function.
4721 (syms_of_fns): Add Ssha1.
4722
7400048f
PE
47232011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4724
4725 * gnutls.c: Remove unused macros.
4726 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4727 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4728 Remove macros that are defined and never used.
4729 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4730
abb71cf4
CY
47312011-05-22 Chong Yidong <cyd@stupidchicken.com>
4732
4733 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4734 (Fx_get_selection_internal): Minor cleanup.
4735 (Fx_own_selection_internal): Rename arguments for consistency with
4736 select.el.
4737
6307db39
PE
47382011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4739
4740 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4741
f3d4e0a4
CY
47422011-05-22 Chong Yidong <cyd@stupidchicken.com>
4743
4744 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4745
4d8ade89
YM
47462011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4747
4748 * dispnew.c (scrolling_window): Don't exclude the case that the
4749 last enabled row in the desired matrix touches the bottom boundary.
4750
32078c8d
GM
47512011-05-21 Glenn Morris <rgm@gnu.org>
4752
4753 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4754 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4755 and add some more files.
32078c8d 4756
7285dc67
EZ
47572011-05-20 Eli Zaretskii <eliz@gnu.org>
4758
4759 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4760 report_file_error introduced by the change from 2011-05-07.
4761
89d1bd22
PE
47622011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4763
4764 * systime.h (Time): Define only if emacs is defined.
4765 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4766 where the include path doesn't have X11/X.h by default. See
4767 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4768
e23640bb 47692011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4770
4771 * composite.c (find_automatic_composition): Fix previous change.
4772
b9704ad9
GM
47732011-05-20 Glenn Morris <rgm@gnu.org>
4774
4775 * lisp.mk: New file, split from Makefile.in.
4776 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4777 (shortlisp): Remove.
4778 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4779
4a720484
GM
47802011-05-19 Glenn Morris <rgm@gnu.org>
4781
4782 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4783 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4784 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4785 (lisp): Set the order to that of loadup.el.
4786 (shortlisp): Make it a copy of $lisp.
4787 (SOME_MACHINE_LISP): Remove.
4788 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4789 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4790
a28d4396
KH
47912011-05-18 Kenichi Handa <handa@m17n.org>
4792
4793 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4794 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4795 (find_automatic_composition): Mostly rewrite for efficiency.
4796
a2b1fa8e
JB
47972011-05-18 Juanma Barranquero <lekktu@gmail.com>
4798
4799 * makefile.w32-in: Update dependencies.
4800
8e1f5610
CS
48012011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4802
4803 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4804 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4805
7025ee00 48062011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4807
cdfa6eab
PE
4808 Fix some integer overflow issues, such as string length overflow.
4809
06d6db33
PE
4810 * insdel.c (count_size_as_multibyte): Check for string overflow.
4811
2b4560a8
PE
4812 * character.c (lisp_string_width): Check for string overflow.
4813 Use EMACS_INT, not int, for string indexes and lengths; in
4814 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4815 the resulting string length overflows an EMACS_INT; instead,
4816 report a string overflow if no precision given. When checking for
4817 precision exhaustion, use a check that cannot possibly have
4818 integer overflow. (Bug#8675)
4819 * character.h (lisp_string_width): Adjust to new signature.
4820
cb93f9be
PE
4821 * alloc.c (string_overflow): New function.
4822 (Fmake_string): Use it. This doesn't change behavior, but saves
4823 a few bytes and will simplify future changes.
4824 * character.c (string_escape_byte8): Likewise.
4825 * lisp.h (string_overflow): New decl.
4826
1a1f3366
PE
4827 Fixups, following up to the user-interface timestamp change.
4828 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4829 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4830 * msdos.c (mouse_get_pos): Likewise.
4831 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4832 * w32gui.h (Time): Define by including "systime.h" rather than by
4833 declaring it ourselves. (Bug#8664)
4834
d4e3e4d3
PE
4835 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4836 * image.c (clear_image_cache): Likewise.
4837
f6a24d19
PE
4838 * term.c (term_mouse_position): Don't assume time_t wraparound.
4839
08dc5ae6
PE
4840 Be more systematic about user-interface timestamps.
4841 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4842 and sometimes 'EMACS_UINT', to represent these timestamps.
4843 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4844 This makes the code easier to follow, and makes it easier to catch
4845 integer overflow bugs such as Bug#8664.
4846 * frame.c (Fmouse_position, Fmouse_pixel_position):
4847 Use Time, not unsigned long, for user-interface timestamps.
4848 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4849 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4850 * keyboard.h (last_event_timestamp): Likewise.
4851 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4852 * menu.h (xmenu_show): Likewise.
4853 * term.c (term_mouse_position): Likewise.
4854 * termhooks.h (struct input_event.timestamp): Likewise.
4855 (struct terminal.mouse_position_hook): Likewise.
4856 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4857 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4858 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4859 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4860 what it was before.
4861 * menu.h, termhooks.h: Include "systime.h", for Time.
4862
8e55734a
PE
4863 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4864 Don't assume that the difference between two unsigned long values
4865 can fit into an integer. At this point, we know button_down_time
4866 <= event->timestamp, so the difference must be nonnegative, so
4867 there's no need to cast the result if double-click-time is
4868 nonnegative, as it should be; check that it's nonnegative, just in
4869 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4870 apart (about 25 days). (Bug#8664)
8e55734a 4871
841f1b75 4872 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4873 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4874
3e26f69c
PE
4875 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4876 that always fit in int. Use a sentinel instead of a counter, to
4877 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4878 * frame.h (struct frame): Use int for menu_bar_items_used
4879 instead of EMACS_INT, since it always fits in int.
3e26f69c 4880
5cc152c0
PE
4881 * menu.c (grow_menu_items): Check for int overflow.
4882
d89eb65e
PE
4883 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4884
5235bd3e
PE
4885 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4886 Before, the code was not consistent. These values cannot exceed
4887 2**31 - 1 so there's no need to make them unsigned.
4888 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4889 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4890 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4891 as modifiers.
4892 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4893
bc827e23
PE
4894 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4895 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4896 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4897 presumably because the widths might not match.
4898
78eb494e
PE
4899 * window.c (size_window): Avoid needless test at loop start.
4900
04f2d78b
CB
49012011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4902
4903 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4904
d2fc7e3d 49052011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4906
4907 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4908
d2fc7e3d 49092011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4910
4911 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4912 `width' to `bar_area_x' and `bar_area_width', respectively.
4913 (x_scroll_run): Take account of fringe background extension.
4914
04f2d78b
CB
4915 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4916 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4917 `bar_area_width', respectively.
4918 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4919 background extension.
4920
79b70037
GM
49212011-05-10 Jim Meyering <meyering@redhat.com>
4922
4923 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4924
2f142cc5
JB
49252011-05-10 Juanma Barranquero <lekktu@gmail.com>
4926
4927 * image.c (Finit_image_library): Return t for built-in image types,
4928 like pbm and xbm. (Bug#8640)
4929
57679c86
AS
49302011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4931
4932 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4933
888c9e86
EZ
49342011-05-07 Eli Zaretskii <eliz@gnu.org>
4935
b0512a1d
EZ
4936 * w32console.c (Fset_screen_color): Doc fix.
4937 (Fget_screen_color): New function.
4938 (syms_of_ntterm): Defsubr it.
4939
7285dc67
EZ
4940 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4941 unlink the temporary file if Fcall_process didn't create it in the
4942 first place.
4943 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4944 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4945 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4946 cue to call_process_cleanup not to close that handle.
4947
4d3fcc8e
BK
49482011-05-07 Ben Key <bkey76@gmail.com>
4949
4950 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4951 one of two shell specific rules, either bootstrap-temacs-CMD or
4952 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4953 to the previous implementation of the bootstrap-temacs rule.
4954 The bootstrap-temacs-CMD rule is similar to the previous
4955 implementation of the bootstrap-temacs rule except that it
4956 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4957 variable.
4958
4959 These changes, along with some changes to nt/configure.bat,
4960 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4961 earlier fix to add support for --cflags and --ldflags options
4962 that include quotes so that it works whether make uses cmd or
4963 sh as the shell.
4964
b4289b64
MA
49652011-05-06 Michael Albinus <michael.albinus@gmx.de>
4966
4967 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4968 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4969 is a constant.
4970 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4971 a string. Handle both cases.
4972 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4973 (Fdbus_register_method): Use Qinvalid_function.
4974
af4c0e28
JB
49752011-05-06 Juanma Barranquero <lekktu@gmail.com>
4976
4977 * makefile.w32-in: Update dependencies.
4978 (LISP_H): Add inttypes.h and stdin.h.
4979 (PROCESS_H): Add unistd.h.
4980
c51453d9
EZ
49812011-05-06 Eli Zaretskii <eliz@gnu.org>
4982
4983 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4984 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4985
8ff0ac3c 49862011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4987
4c4b566b
PE
4988 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4989
aab2b9b5
PE
4990 * term.c (vfatal): Remove stray call to va_end.
4991 It's not needed and the C Standard doesn't allow it here anyway.
4992
c378da0b
PE
4993 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4994 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4995
288b08c7
PE
4996 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4997 bytes.
4998
e3601888
PE
4999 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5000
db6c0e74
PE
5001 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5002
dd5963ea
PE
5003 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5004
88c9450f
PE
5005 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5006
2f9442b8
PE
5007 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5008
c032b5f8
PE
5009 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5010 * charset.c (Fdefine_charset_internal): Don't initialize
5011 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5012 32-bit int (Bug#8600).
a108c10b
PE
5013
5014 * lread.c (read_integer): Be more consistent with string-to-number.
5015 Use string_to_number to do the actual conversion; this avoids
5016 rounding errors and fixes some other screwups. Without this fix,
5017 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5018 (digit_to_number): Move earlier, for benefit of read_integer.
5019 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5020 not a digit in any supported base. (Bug#8602)
a108c10b 5021
ad5f9eea
PE
5022 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5023
aec1708a
PE
5024 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5025 to match comment at start of function. This also removes a
5026 GCC warning about overflow in a 32+64-bit port.
5027
47be4ab5
PE
5028 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5029
371cac43
PE
5030 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5031 Reported by Stefan Monnier in
5032 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5033 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5034 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5035
d01a7826
PE
5036 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5037 (EMACS_UINTPTR): Likewise, with uintptr_t.
5038
7fd47d5c
PE
5039 * lisp.h: Prefer 64-bit EMACS_INT if available.
5040 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5041 on 32-bit hosts that have 64-bit int, so that they can access
5042 large files.
122b0c86
PE
5043 However, temporarily disable this change unless the temporary
5044 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5045
8727937b
PE
5046 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5047
8ac068ac
PE
5048 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5049 This removes an assumption that EMACS_INT and long are the same
5050 width as pointers. The assumption is true for Emacs porting targets
5051 now, but we want to make other targets possible.
5052 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5053 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5054 In the rest of the code, change types of integers that hold casted
5055 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5056 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5057 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5058 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5059 No need to cast type when ORing.
5060 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5061 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5062 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5063 assume EMACS_INT is the same width as char *.
5064 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5065 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5066 Remove no-longer-needed casts.
5067 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5068 (xg_tool_bar_help_callback, xg_make_tool_item):
5069 Use EMACS_INTPTR to hold an integer
5070 that will be cast to void *; this can avoid a GCC warning
5071 if EMACS_INT is not the same width as void *.
5072 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5073 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5074 (current_message_1, set_message_1):
5075 Use a local to convert to proper width without a cast.
5076 * xmenu.c (dialog_selection_callback): Likewise.
5077
ede49d71
PE
5078 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5079 Also, don't assume VALBITS / RAND_BITS is less than 5,
5080 and don't rely on undefined behavior when shifting a 1 left into
5081 the sign bit.
5082 * lisp.h (get_random): Change signature to match.
5083
2f30ecd0
PE
5084 * lread.c (hash_string): Use size_t, not int, for hash computation.
5085 Normally we prefer signed values; but hashing is special, because
5086 it's better to use unsigned division on hash table sizes so that
5087 the remainder is nonnegative. Also, size_t is the natural width
5088 for hashing into memory. The previous code used 'int', which doesn't
5089 retain enough info to hash well into very large tables.
5090 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5091
2a866e7b
PE
5092 * dbusbind.c: Don't possibly lose pointer info when converting.
5093 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5094 Use XPNTR rather than XHASH, so that the high-order bits of
5095 the pointer aren't lost when converting through void *.
5096
51639eac
PE
5097 * eval.c (Fautoload): Don't double-shift a pointer.
5098
92394119
PE
5099 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5100
dbdb9a7c
JB
51012011-05-06 Juanma Barranquero <lekktu@gmail.com>
5102
5103 * gnutls.c (DEF_GNUTLS_FN):
5104 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5105
db7a0b4f
AS
51062011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5107
5108 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5109 marker. (Bug#8610)
5110
f7ff1b0f 51112011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5112
5113 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5114 New version that can reserve upto 2GB of heap space.
5115
f7ff1b0f 51162011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5117
5118 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5119
639c109b
TZ
51202011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5121
5122 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5123 `gnutls_certificate_set_x509_key_file'.
5124
d2127135
JB
51252011-05-05 Juanma Barranquero <lekktu@gmail.com>
5126
5127 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5128 Update dependencies.
5129
e968f4f3
JB
51302011-05-04 Juanma Barranquero <lekktu@gmail.com>
5131
5132 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5133 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5134 Remove unused parameter `fildes'.
5135 * process.c (read_process_output, send_process): Don't pass it.
5136
84d358f0
JB
51372011-05-04 Juanma Barranquero <lekktu@gmail.com>
5138
5139 Fix previous change: the library cache is defined in w32.c.
5140 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5141 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5142
0898ca10
JB
51432011-05-04 Juanma Barranquero <lekktu@gmail.com>
5144
5145 Implement dynamic loading of GnuTLS on Windows.
5146
5147 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5148 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5149 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5150 Declare.
5151
5152 * gnutls.c (Qgnutls_dll): Define.
5153 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5154 (gnutls_*): Declare function pointers.
5155 (init_gnutls_functions): New function to initialize function pointers.
5156 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5157 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5158 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5159 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5160 (emacs_gnutls_write, emacs_gnutls_read)
5161 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5162 (Fgnutls_available_p): New function.
5163 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5164 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5165 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5166
5167 * image.c: Include w32.h.
5168 (Vimage_type_cache): Delete.
5169 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5170 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5171 (w32_delayed_load): Move to w32.c.
5172
5173 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5174
5175 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5176 (w32_delayed_load): Move from image.c. When loading a library, record
5177 its filename in the :loaded-from property of the library id.
5178 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5179 Initialize and staticpro them.
5180 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5181
5182 * process.c: Include lisp.h before w32.h, not after.
5183 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5184 instead of gnutls_record_check_pending.
5185
5186 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5187
ff4de4aa
TZ
51882011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5189
5190 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5191 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5192 as passed in.
5193
abe95abb
JD
51942011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5195
5196 * xterm.c (x_set_frame_alpha): Do not set property on anything
5197 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5198
e16e55d4
JB
51992011-05-02 Juanma Barranquero <lekktu@gmail.com>
5200
5201 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5202
bafcf6a5
JB
52032011-05-02 Juanma Barranquero <lekktu@gmail.com>
5204
5205 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5206 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5207 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5208 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5209 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5210 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5211 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5212 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5213 (Qgnutls_bootprop_callbacks_verify): Make static.
5214
e7a6747f
AS
52152011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5216
19ed11ba
AS
5217 * callproc.c: Indentation fixup.
5218
e7a6747f 5219 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5220 (wait_for_termination, interruptible_wait_for_termination):
5221 Move after wait_for_termination_1.
e7a6747f 5222
1ef14cb4
LMI
52232011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5224
5225 * sysdep.c (interruptible_wait_for_termination): New function
5226 which is like wait_for_termination, but allows keyboard
5227 interruptions.
5228
5229 * callproc.c (Fcall_process): Add (:file "file") as an option for
5230 the STDOUT buffer.
5231 (Fcall_process_region): Ditto.
5232
330d880c
EZ
52332011-04-30 Eli Zaretskii <eliz@gnu.org>
5234
8db90b73
EZ
5235 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5236 rather than `XVECTOR (FOO)->size'.
5237
330d880c
EZ
5238 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5239 inttypes.h, as a gnulib replacement is used if it not available in
5240 system headers.
5241
15cbd324
EZ
52422011-04-21 Eli Zaretskii <eliz@gnu.org>
5243
5244 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5245 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5246 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5247
5248 * coding.c (coding_alloc_by_realloc): Error out if destination
5249 will grow beyond MOST_POSITIVE_FIXNUM.
5250 (decode_coding_emacs_mule): Abort if there isn't enough place in
5251 charbuf for the composition carryover bytes. Reserve an extra
5252 space for up to 2 characters produced in a loop.
5253 (decode_coding_iso_2022): Abort if there isn't enough place in
5254 charbuf for the composition carryover bytes.
5255
52562011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5257
ae940cca
EZ
5258 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5259 aborting when %lld or %lll format is passed.
5260 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5261 %llo or %llx format is passed. (Bug#8545)
5262
03ab8921
EZ
5263 * window.c (window_scroll_line_based): Use a marker instead of
5264 simple variables to record original value of point. (Bug#7952)
5265
afda1437
EZ
5266 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5267 produced by %s or %c overflows available buffer space. (Bug#8545)
5268
f76dee0c
PE
52692011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5270
5271 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5272 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5273
fdc5744d
JB
52742011-04-28 Juanma Barranquero <lekktu@gmail.com>
5275
5276 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5277
638f053a
JB
52782011-04-28 Juanma Barranquero <lekktu@gmail.com>
5279
5280 * keyboard.c (Qdelayed_warnings_hook): Define.
5281 (command_loop_1): Run `delayed-warnings-hook'
5282 if Vdelayed_warnings_list is non-nil.
5283 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5284 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5285
d178f871
EZ
52862011-04-28 Eli Zaretskii <eliz@gnu.org>
5287
5288 * doprnt.c (doprnt): Don't return value smaller than the buffer
5289 size if the message was truncated. (Bug#8545).
5290
b124fd93
JB
52912011-04-28 Juanma Barranquero <lekktu@gmail.com>
5292
5293 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5294 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5295
e810457d
PE
52962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5297
5298 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5299
ea51cceb
JB
53002011-04-27 Juanma Barranquero <lekktu@gmail.com>
5301
5302 * makefile.w32-in: Update dependencies.
5303
94dcfacf
EZ
53042011-04-27 Eli Zaretskii <eliz@gnu.org>
5305
5306 Improve `doprnt' and its usage. (Bug#8545)
5307 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5308 `format_end'. Remove support for %l as a conversion specifier.
5309 Don't use xrealloc. Improve diagnostics when the %l size modifier
5310 is used. Update the commentary.
5311
5312 * eval.c (verror): Simplify calculation of size_t.
5313
5314 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5315 messages.
5316
f61f41d7
PE
53172011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5318
5319 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5320 change.
5321
96fb4434
PE
53222011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5323
5324 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5325 This makes this file independent of the recent pseudovector change.
5326
671875da 53272011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5328
69e9b5a3
PE
5329 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5330
b5f869a7 5331 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5332 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5333 Remove unused local.
c8926152 5334 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5335
841a1577 5336 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5337 GCC 4.6.0 optimizes based on type-based alias analysis.
5338 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5339 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5340 != &v->size, and therefore "v->size = 1; b->size = 2; return
5341 v->size;" must therefore return 1. This assumption is incorrect
5342 for Emacs, since it type-puns struct Lisp_Vector * with many other
5343 types. To fix this problem, this patch adds a new type struct
f904488f 5344 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5345 and pseudovectors, and helps optimizing compilers not get fooled
5346 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5347 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5348 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5349 the size member.
eab3844f
PE
5350 (XSETPVECTYPE): Rewrite in terms of new macro.
5351 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5352 This is a bit clearer, and further avoids the possibility of
5353 undesirable aliasing.
5354 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5355 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5356 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5357 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5358 (ASIZE): Now uses header.size rather than size.
5359 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5360 to avoid the hassle of writing XVECTOR (foo)->header.size.
5361 (struct vectorlike_header): New type.
eab3844f
PE
5362 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5363 object, to help avoid aliasing.
5364 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5365 (SUBRP): Likewise, since Lisp_Subr is a special case.
5366 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5367 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5368 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5369 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5370 changed to be "header.size" and "header.next".
5371 * buffer.h (struct buffer): Likewise.
5372 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5373 * frame.h (struct frame): Likewise.
5374 * process.h (struct Lisp_Process): Likewise.
5375 * termhooks.h (struct terminal): Likewise.
5376 * window.c (struct save_window_data, struct saved_window): Likewise.
5377 * window.h (struct window): Likewise.
5378 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5379 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5380 * buffer.c (init_buffer_once): Likewise.
5381 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5382 special case.
5383 * process.c (Fformat_network_address): Use local var for size,
5384 for brevity.
5385
0df1eac5
PE
5386 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5387
847ab9d1 5388 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5389 * data.c (atof): Remove decl; no longer used or needed.
5390 (digit_to_number): Move to lread.c.
5391 (Fstring_to_number): Use new string_to_number function, to be
5392 consistent with how the Lisp reader treats infinities and NaNs.
5393 Do not assume that floating-point numbers represent EMACS_INT
5394 without losing information; this is not true on most 64-bit hosts.
5395 Avoid double-rounding errors, by insisting on integers when
5396 parsing non-base-10 numbers, as the documentation specifies.
5397 * lisp.h (string_to_number): New decl, replacing ...
5398 (isfloat_string): Remove.
bc0a5c13 5399 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5400 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5401 appears to have been a coding error. Similarly, do not accept
5402 strings like +-1e0 as floating point numbers. Do not report
5403 overflow for integer overflows unless the base is not 10 which
5404 means we have no simple and reliable way to continue.
5405 Break out the floating-point parsing into a new
5406 function string_to_number, so that Fstring_to_number parses
5407 floating point numbers consistently with the Lisp reader.
04f2d78b 5408 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5409 (E_CHAR, EXP_INT): Remove, replacing with ...
5410 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5411 (string_to_number): New function, replacing isfloat_string.
5412 This function checks for valid syntax and produces the resulting
5413 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5414 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5415 so that overflow for non-base-10 numbers is reported only when
5416 there's no portable and simple way to convert to floating point.
452f4150 5417
67769ffc
PE
5418 * textprop.c (set_text_properties_1): Rewrite for clarity,
5419 and to avoid GCC warning about integer overflow.
5420
c20db43f
PE
5421 * intervals.h (struct interval): Use EMACS_INT for members
5422 where EMACS_UINT might cause problems. See
5423 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5424 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5425 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5426 All uses changed.
37aa2f85
PE
5427 (offset_intervals): Tell GCC not to worry about length overflow
5428 when negating a negative length.
c20db43f 5429
2538aa2f
PE
5430 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5431 (overrun_check_free): Likewise.
5432
f2d3008d
PE
5433 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5434 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5435 word size.
5436
ec8df744
PE
5437 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5438 (gnutls_make_error): Rename local to avoid shadowing.
5439 (gnutls_emacs_global_deinit): ifdef out; not used.
5440 (Fgnutls_boot): Use const for pointer to readonly storage.
5441 Comment out unused local. Fix pointer signedness problems.
5442
640ee02d
PE
5443 * lread.c (openp): Don't stuff size_t into an 'int'.
5444 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5445 about possible signed overflow.
5446
6048fb2a
PE
5447 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5448 (GDK_KEY_g): Don't define if already defined.
5449 (xg_prepare_tooltip): Avoid pointer signedness problem.
5450 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5451
fa3c87e1
PE
5452 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5453 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5454
2172544b
PE
5455 * xfns.c (Fx_window_property): Simplify a bit,
5456 to make a bit faster and to avoid GCC 4.6.0 warning.
5457 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5458
9b821a21
PE
5459 * fns.c (internal_equal): Don't assume size_t fits in int.
5460
3c616cfa
PE
5461 * alloc.c (compact_small_strings): Tighten assertion a little.
5462
c2982e87
PE
5463 Replace pEd with more-general pI, and fix some printf arg casts.
5464 * lisp.h (pI): New macro, generalizing old pEd macro to other
5465 conversion specifiers. For example, use "...%"pI"d..." rather
5466 than "...%"pEd"...".
5467 (pEd): Remove. All uses replaced with similar uses of pI.
5468 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5469 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5470 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5471 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5472 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5473 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5474 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5475 64-bit hosts.
5476 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5477 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5478 * print.c (safe_debug_print, print_object): Likewise.
5479 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5480 to int.
6f04d126
PE
5481 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5482 avoiding the 0 flag, which is not portable.
c2982e87
PE
5483 * process.c (Fmake_network_process): Use pI to avoid cast.
5484 * region-cache.c (pp_cache): Likewise.
5485 * xdisp.c (decode_mode_spec): Likewise.
5486 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5487 behavior on 64-bit hosts with printf arg.
6f04d126 5488 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5489 (x_stop_queuing_selection_requests): Likewise.
5490 (x_get_window_property): Don't truncate byte count to an 'int'
5491 when tracing.
0b432f21 5492
5e073ec7
PE
5493 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5494 here, since it parses constructs like leading '-' and spaces,
5495 which are not wanted; and it overflows with large numbers.
5496 Instead, simply match F[0-9]+, which is what is wanted anyway.
5497
36372bf9
PE
5498 * alloc.c: Remove unportable assumptions about struct layout.
5499 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5500 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5501 (allocate_vectorlike, make_pure_vector): Use the new macros,
5502 plus offsetof, to remove unportable assumptions about struct layout.
5503 These assumptions hold on all porting targets that I know of, but
5504 they are not guaranteed, they're easy to remove, and removing them
5505 makes further changes easier.
5506
0b432f21
PE
5507 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5508 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5509 (string_overrun_cookie): Now const. Use initializers that
5510 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5511 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5512 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5513 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5514 multiple of sizeof (EMACS_INT); it need not be, if
5515 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5516 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5517
895009e1
JB
55182011-04-26 Juanma Barranquero <lekktu@gmail.com>
5519
5520 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5521
6a7a1b0b
TZ
55222011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5523
5524 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5525 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5526 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5527
841a1577 55282011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5529
5530 * lisp.h (Qdebug): List symbol.
895009e1 5531 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5532 * keyboard.c (debug-on-event): New variable.
5533 (handle_user_signal): Break into debugger when debug-on-event
5534 matches the current signal symbol.
5535
f2d3ba6f
DN
55362011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5537
5538 * alloc.c (check_sblock, check_string_bytes)
5539 (check_string_free_list): Convert to standard C.
5540
42ce4c63
TZ
55412011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5542
5543 * w32.c (emacs_gnutls_push): Fix typo.
5544
825cd63c
EZ
55452011-04-25 Eli Zaretskii <eliz@gnu.org>
5546
fb11d64d
EZ
5547 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5548 "cast to pointer from integer of different size".
5549
825cd63c
EZ
5550 Improve doprnt and its use in verror. (Bug#8545)
5551 * doprnt.c (doprnt): Document the set of format control sequences
5552 supported by the function. Use SAFE_ALLOCA instead of always
5553 using `alloca'.
5554
5555 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5556 is one byte too soon. Don't use xrealloc; instead xfree and
5557 xmalloc anew.
5558
e061a11b
TZ
55592011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5560
5561 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5562 callbacks stage.
5563
5564 * gnutls.c: Renamed global_initialized to
5565 gnutls_global_initialized. Added internals for the
5566 :verify-hostname-error, :verify-error, and :verify-flags
5567 parameters of `gnutls-boot' and documented those parameters in the
5568 docstring. Start callback support.
9173deec
JB
5569 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5570 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5571 on error. Return error code.
e061a11b
TZ
5572 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5573 (emacs_gnutls_read): Likewise.
5574 (Fgnutls_boot): Return handshake error code.
5575 (emacs_gnutls_handle_error): New function.
5576 (wsaerror_to_errno): Likewise.
5577
5578 * w32.h (emacs_gnutls_pull): Add prototype.
5579 (emacs_gnutls_push): Likewise.
5580
5581 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5582 (emacs_gnutls_push): Likewise.
5583
55842011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5585
5586 * process.c (wait_reading_process_output): Check if GnuTLS
5587 buffered some data internally if no FDs are set for TLS
5588 connections.
5589
5590 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5591 (LIBS): Link to USER_LIBS.
5592 ($(BLD)/gnutls.$(0)): New target.
5593
fa6996bc
EZ
55942011-04-24 Eli Zaretskii <eliz@gnu.org>
5595
eb35682e
EZ
5596 * xdisp.c (handle_single_display_spec): Rename the
5597 display_replaced_before_p argument into display_replaced_p, to
5598 make it consistent with the commentary. Fix typos in the
5599 commentary.
5600
e2ad650c
EZ
5601 * textprop.c (syms_of_textprop): Remove dead code.
5602 (copy_text_properties): Delete obsolete commentary about an
5603 interface that was deleted long ago. Fix typos in the description
5604 of arguments.
5605
1b2de274
EZ
5606 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5607 to changes in oldXMenu/XMenu.h from 2011-04-16.
5608 <menu_help_message, prev_menu_help_message>: Constify.
5609 (IT_menu_make_room): menu->help_text is now `const char **';
5610 adjust.
5611
5612 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5613 to changes in oldXMenu/XMenu.h from 2011-04-16.
5614 (struct XMenu): Declare `help_text' `const char **'.
5615
5616 * xfaces.c <Qunspecified>: Make extern again.
5617
5618 * syntax.c: Include sys/types.h before including regex.h, as
5619 required by Posix.
5620
762b15be
EZ
5621 * doc.c (get_doc_string): Improve the format passed to `error'.
5622
5623 * doprnt.c (doprnt): Improve commentary.
5624
5625 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5626
5627 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5628 them with etags.
5629
f1052e5d
EZ
5630 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5631 changes in globals.h immediately force recompilation.
762b15be
EZ
5632 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5633 $(CURDIR)/s/ms-w32.h.
5634 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5635
fa6996bc
EZ
5636 * character.c (Fchar_direction): Function deleted.
5637 (syms_of_character): Don't defsubr it.
5638 <char-direction-table>: Deleted.
5639
e6c3da20
EZ
56402011-04-23 Eli Zaretskii <eliz@gnu.org>
5641
5642 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5643 * doprnt.c: Include limits.h.
5644 (SIZE_MAX): New macro.
04f2d78b
CB
5645 (doprnt): Return a size_t value. 2nd arg is now size_t.
5646 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5647 Improve overflow protection. Support `l' modifier for integer
5648 conversions. Support %l conversion. Don't assume an EMACS_INT
5649 argument for integer conversions and for %c.
5650
5651 * lisp.h (doprnt): Restore prototype.
5652
5653 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5654 $(SRC)/character.h.
5655
5656 * Makefile.in (base_obj): Add back doprnt.o.
5657
5658 * deps.mk (doprnt.o): Add back prerequisites.
5659 (callint.o): Depend on character.h.
5660
5661 * eval.c (internal_lisp_condition_case): Include the handler
5662 representation in the error message.
5663 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5664 when breaking from the loop.
5665
5666 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5667
5668 * callint.c (Fcall_interactively): When displaying error message
5669 about invalid control letter, pass the character's codepoint, not
5670 a pointer to its multibyte form. Improve display of the character
5671 in octal and display also its hex code.
5672
5673 * character.c (char_string): Use %x to display the (unsigned)
5674 codepoint of an invalid character, to avoid displaying a bogus
5675 negative value.
5676
5677 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5678 `error', not SYMBOL_NAME itself.
5679
5680 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5681 character arguments to `error'.
5682
5683 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5684 to `error' in error message about FINAL_CHAR argument. Make sure
5685 FINAL_CHAR is a character, and use %c when it is passed as
5686 argument to `error'.
5687
4ffd0d6b 56882011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5689
5690 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5691
5692 * w32.c: Include <time.h>.
5693 (sys_localtime): New function.
5694
4ffd0d6b 56952011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5696
5697 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5698
4ffd0d6b 5699 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5700
4ffd0d6b 57012011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5702
4ffd0d6b
GM
5703 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5704 zombies (Bug#8467).
aac0c6e3 5705
04c56954
EZ
57062011-04-19 Eli Zaretskii <eliz@gnu.org>
5707
5708 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5709 gl_state.e_property when gl_state.object is Qt.
5710
5711 * insdel.c (make_gap_larger): Remove limitation of buffer size
5712 to <= INT_MAX.
5713
16a43933
CY
57142011-04-18 Chong Yidong <cyd@stupidchicken.com>
5715
5716 * xdisp.c (lookup_glyphless_char_display)
5717 (produce_glyphless_glyph): Handle cons cell entry in
5718 glyphless-char-display.
5719 (Vglyphless_char_display): Document it.
5720
5721 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5722 glyphless-char-display.
5723
4581706e
CY
57242011-04-17 Chong Yidong <cyd@stupidchicken.com>
5725
5726 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5727
5728 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5729
5730 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5731 definition for no-X builds.
5732
4887c6e2 57332011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5734
fd35b6f9
PE
5735 Static checks with GCC 4.6.0 and non-default toolkits.
5736
5c1ccb01
PE
5737 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5738
006c5daa
PE
5739 * process.c (keyboard_bit_set): Define only if SIGIO.
5740 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5741 (send_process): Repair possible setjmp clobbering.
5742
efc736d3
PE
5743 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5744
4e2fe2e6
PE
5745 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5746
f97334a2
PE
5747 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5748
4e75f29d
PE
5749 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5750 Define only if needed.
5751
90efadd1
PE
5752 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5753 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5754 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5755
3c647824
PE
5756 * dispextern.h (struct redisplay_interface): Rename param
5757 to avoid shadowing.
e264f262 5758 * termhooks.h (struct terminal): Likewise.
761383f4 5759 * xterm.c (xembed_send_message): Likewise.
3c647824 5760
b58c5c4a
PE
5761 * insdel.c (make_gap_smaller): Define only if
5762 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5763
cad59032
PE
5764 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5765 it.
5766
c339dc2e
PE
5767 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5768 so that we aren't warned about unused symbols.
5769
91a3e27b
PE
5770 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5771
399c71d3 5772 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5773
8ffc96f5
PE
5774 * xfns.c (x_real_positions): Mark locals as initialized.
5775
eef9bc79
PE
5776 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5777
098db9dd
PE
5778 * xterm.c: Fix problems found by static analysis with other toolkits.
5779 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5780 (x_dispatch_event): Declare static if USE_GTK, and
5781 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5782 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5783 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5784 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5785 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5786
eb18f6cc
PE
5787 * xmenu.c (menu_help_callback): Pointer type fixes.
5788 Use const pointers when pointing at readonly data. Avoid pointer
5789 signedness clashes.
5790 (FALSE): Remove unused macro.
5791 (update_frame_menubar): Remove unused decl.
5792
1fe72bf8
PE
5793 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5794
60d9e1db
PE
5795 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5796 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5797 (single_menu_item): Rename local to avoid shadowing.
5798
39261c26
PE
5799 * keyboard.c (make_lispy_event): Remove unused local var.
5800
018c5e19
PE
5801 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5802 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5803
63d2b86e
PE
5804 * bitmaps: Change bitmaps from unsigned char back to the X11
5805 compatible char. Avoid the old compiler warnings about
5806 out-of-range initializers by using, for example, '\xab' rather
5807 than 0xab.
5808
aefd87e1
PE
5809 * xgselect.c (xgselect_initialize): Check vs interface
5810 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5811
bf501fb9
PE
5812 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5813
e9829fdf
PE
5814 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5815 to read-only memory.
5816
1086c095
PE
5817 * fns.c (vector): Remove; this old hack is no longer needed.
5818
2baccd04 5819 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5820 Remove unused var.
dde42981 5821 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5822
72391843 5823 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5824
436c16df 5825 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5826 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5827 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5828
92bb796d 5829 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5830 (x_term_init): Remove local to avoid shadowing.
92bb796d 5831
764430a3 5832 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5833
5834 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5835 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5836
d1dfb56c
EZ
58372011-04-16 Eli Zaretskii <eliz@gnu.org>
5838
c4354cb4
EZ
5839 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5840
d1dfb56c
EZ
5841 Fix regex.c, syntax.c and friends for buffers > 2GB.
5842 * syntax.h (struct gl_state_s): Declare character position members
5843 EMACS_INT.
5844
5845 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5846
04f2d78b
CB
5847 * textprop.c (verify_interval_modification, interval_of):
5848 Declare arguments EMACS_INT.
d1dfb56c
EZ
5849
5850 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5851 EMACS_INT.
5852
5853 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5854
5855 * indent.c (Fvertical_motion): Local variable it_start is now
5856 EMACS_INT.
5857
5858 * regex.c (re_match, re_match_2, re_match_2_internal)
5859 (bcmp_translate, regcomp, regexec, print_double_string)
5860 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5861 (re_compile_pattern, re_exec): Declare arguments and local
5862 variables `size_t' and `ssize_t' and return values `regoff_t', as
5863 appropriate.
5864 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5865 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5866 <compile_stack_type>: `size' and `avail' are now `size_t'.
5867
5868 * regex.h <regoff_t>: Use ssize_t, not int.
5869 (re_search, re_search_2, re_match, re_match_2): Arguments that
5870 specify buffer/string position and length are now ssize_t and
5871 size_t. Return type is regoff_t.
5872
613052cd
BK
58732011-04-16 Ben Key <bkey76@gmail.com>
5874
5875 * nsfont.m: Fixed bugs in ns_get_family and
5876 ns_descriptor_to_entity that were caused by using free to
5877 deallocate memory blocks that were allocated by xmalloc (via
5878 xstrdup). This caused Emacs to crash when compiled with
5879 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5880 --enable-checking=xmallocoverrun). xfree is now used to
5881 deallocate these memory blocks.
5882
4170f62f 58832011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5884
71b41406
PE
5885 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5886
9587a89d
PE
5887 emacs_write: Accept and return EMACS_INT for sizes.
5888 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5889 et seq.
5890 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5891 Accept and return EMACS_INT.
5892 (emacs_gnutls_write): Return the number of bytes written on
5893 partial writes.
5894 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5895 (emacs_read, emacs_write): Remove check for negative size, as the
5896 Emacs source code has been audited now.
9587a89d
PE
5897 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5898 (emacs_read, emacs_write): Use it.
273a5f82
PE
5899 * process.c (send_process): Adjust to the new signatures of
5900 emacs_write and emacs_gnutls_write. Do not attempt to store
5901 a byte offset into an 'int'; it might overflow.
9587a89d 5902 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5903
3e047f51
PE
5904 * sound.c: Don't assume sizes fit in 'int'.
5905 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5906 Return EMACS_INT, not int.
3e047f51 5907 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5908 Accept EMACS_INT, not int.
5909 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5910 record read return values.
5911
cc39a9db
BK
59122011-04-15 Ben Key <bkey76@gmail.com>
5913
c9d0ec6d
JB
5914 * keyboard.c (Qundefined): Don't declare static since it is used
5915 in nsfns.m.
5916 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5917 static since they are used in nsfont.m.
cc39a9db 5918
6c60eb9f
SM
59192011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5920
5921 * process.c (Qprocessp): Don't declare static.
5922 * lisp.h (Qprocessp): Declare again.
5923
7990b61a
JB
59242011-04-15 Juanma Barranquero <lekktu@gmail.com>
5925
5926 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5927
5d4cb038
PE
59282011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5929
8bd7b830 5930 Improve C-level modularity by making more things 'static'.
cd64ea1d 5931
e3b27b31
PE
5932 Don't publish debugger-only interfaces to other modules.
5933 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5934 (verify_bytepos, count_markers): Move decls to the only modules
5935 that need them.
5936 * region-cache.h (pp_cache): Likewise.
5937 * window.h (check_all_windows): Likewise.
5938 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5939
5d4cb038
PE
5940 * sysdep.c (croak): Now static, if
5941 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5942 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5943
5944 * alloc.c (refill_memory_reserve): Now static if
5945 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5946 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5947
e87b6180
PE
5948 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5949 Define only if USE_LUCID.
5950
ac64929e
PE
5951 * xrdb.c (x_customization_string, x_rm_string): Now static.
5952
6f37259d
PE
5953 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5954 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5955
1683e3ab
PE
5956 * xdisp.c (draw_row_with_mouse_face): Now static.
5957 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5958
de9c2632
PE
5959 * window.h (check_all_windows): Mark externally visible.
5960
2b96acb7
PE
5961 * window.c (window_deletion_count): Now static.
5962
5963 * undo.c: Make symbols static if they're not exported.
5964 (last_undo_buffer, last_boundary_position, pending_boundary):
5965 Now static.
5966
50436f33
PE
5967 * textprop.c (interval_insert_behind_hooks): Now static.
5968 (interval_insert_in_front_hooks): Likewise.
5969
64520e5c
PE
5970 * term.c: Make symbols static if they're not exported.
5971 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5972 (max_frame_lines, tty_set_terminal_modes):
5973 (tty_reset_terminal_modes, tty_turn_off_highlight):
5974 (get_tty_terminal): Now static.
5975 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5976 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5977 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5978 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5979 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5980
1fa53021
PE
5981 * sysdep.c: Make symbols static if they're not exported.
5982 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5983 Now static.
5984 (sigprocmask_set, full_mask): Remove; unused.
5985 (wait_debugging): Mark as visible.
5986 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5987 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5988
d4b43b22
PE
5989 * syntax.c (syntax_temp): Define only if !__GNUC__.
5990
b7c513d0
PE
5991 * sound.c (current_sound_device, current_sound): Now static.
5992
989b29ad
PE
5993 * search.c (searchbufs, searchbuf_head): Now static.
5994
13a55a78
PE
5995 * scroll.c (scroll_cost): Remove; unused.
5996 * dispextern.h (scroll_cost): Remove decl.
5997
de68a1fc
PE
5998 * region-cache.h (pp_cache): Mark as externally visible.
5999
40ccffa6
PE
6000 * process.c: Make symbols static if they're not exported.
6001 (process_tick, update_tick, create_process, chan_process):
6002 (Vprocess_alist, proc_buffered_char, datagram_access):
6003 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6004 (deactivate_process): Mark defn as static, as well as decl.
6005 * lisp.h (create_process): Remove decl.
6006 * process.h (chan_process, Vprocess_alist): Remove decls.
6007
ad64fc97
PE
6008 * print.c: Make symbols static if they're not exported.
6009 (print_depth, new_backquote_output, being_printed, print_buffer):
6010 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6011 (print_interval, print_number_index, initial_stderr_stream):
6012 Now static.
6013 * lisp.h (Fprinc): Remove decl.
6014 (debug_output_compilation_hack): Mark as externally visible.
6015
adddb265
PE
6016 * sysdep.c (croak): Move decl from here to syssignal.h.
6017 * syssignal.h (croak): Put it here, so the API can be checked when
6018 'croak' is called from dissociate_if_controlling_tty.
6019
1717ede2
PE
6020 * minibuf.c: Make symbols static if they're not exported.
6021 (minibuf_save_list, choose_minibuf_frame): Now static.
6022 * lisp.h (choose_minibuf_frame): Remove decl.
6023
fa5fb2bc
PE
6024 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6025
1e3890d1
PE
6026 * lread.c: Make symbols static if they're not exported.
6027 (read_objects, initial_obarray, oblookup_last_bucket_number):
6028 Now static.
6029 (make_symbol): Remove; unused.
6030 * lisp.h (initial_obarray, make_symbol): Remove decls.
6031
8a1414fa
PE
6032 * keyboard.c: Make symbols static if they're not exported.
6033 (single_kboard, recent_keys_index, total_keys, recent_keys):
6034 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6035 (this_single_command_key_start, echoing, last_auto_save):
6036 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6037 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6038 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6039 (Vlispy_mouse_stem, double_click_count):
6040 Now static.
6041 (force_auto_save_soon): Define only if SIGDANGER.
6042 (ignore_mouse_drag_p): Now static if
6043 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6044 (print_help): Remove; unused.
6045 (stop_character, last_timer_event): Mark as externally visible.
6046 * keyboard.h (ignore_mouse_drag_p): Declare only if
6047 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6048 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6049 * lisp.h (echoing): Remove decl.
6050 (force_auto_save_soon): Declare only if SIGDANGER.
6051 * xdisp.c (redisplay_window): Simplify code, to make it more
6052 obvious that ignore_mouse_drag_p is not accessed if !defined
6053 USE_GTK && !defined HAVE_NS.
6054
93ea6e8f
PE
6055 * intervals.c: Make symbols static if they're not exported.
6056 (merge_properties_sticky, merge_interval_right, delete_interval):
6057 Now static.
6058 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6059
77382fcc
PE
6060 * insdel.c: Make symbols static if they're not exported.
6061 However, leave prepare_to_modify_buffer alone. It's never
6062 called from outside this function, but that appears to be a bug.
6063 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6064 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6065 (adjust_after_replace_noundo): Remove; unused.
6066 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6067 (signal_before_change): Remove decls.
77382fcc 6068
9306c32e
PE
6069 * indent.c (val_compute_motion, val_vmotion): Now static.
6070
cd44d2eb
PE
6071 * image.c: Make symbols static if they're not exported.
6072 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6073 if USE_GTK.
6074 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6075 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6076
ad9a7a06
PE
6077 * fringe.c (standard_bitmaps): Now static.
6078 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6079
81626931
PE
6080 * frame.c: Make symbols static if they're not exported.
6081 (x_report_frame_params, make_terminal_frame): Now static.
6082 (get_frame_param): Now static, unless HAVE_NS.
6083 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6084 (x_get_resource_string): Remove; not used.
6085 * frame.h (make_terminal_frame, x_report_frame_params):
6086 (x_get_resource_string); Remove decls.
6087 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6088 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6089
239f9db9
PE
6090 * font.c, fontset.c: Make symbols static if they're not exported.
6091 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6092 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6093 * font.c (font_close_object): Now static.
6094 * font.h (font_close_object): Remove.
6095 * fontset.c (FONTSET_OBJLIST): Remove.
6096 (free_realized_fontset) #if-0 the body, which does nothing.
6097 (face_suitable_for_char_p): #if-0, as it's never called.
6098 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6099 * xfaces.c (face_at_string_position):
6100 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6101 since 0 is always ASCII.
6102
dfcf3579
PE
6103 * fns.c (weak_hash_tables): Now static.
6104
5045092b
PE
6105 * fileio.c: Make symbols static if they're not exported.
6106 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6107 (Vwrite_region_annotation_buffers): Now static.
6108
57a96f5c
PE
6109 * eval.c: Make symbols static if they're not exported.
6110 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6111 * lisp.h (backtrace_list): Remove decl.
6112
35f08c38
PE
6113 * emacs.c: Make symbols static if they're not exported.
6114 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6115 (fatal_error_code, fatal_error_signal_hook, standard_args):
6116 Now static.
6117 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6118 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6119 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6120 * lisp.h (fatal_error_signal_hook): Remove decl.
6121 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6122
f44bd759
PE
6123 * editfns.c: Move a (normally-unused) function to its only use.
6124 * editfns.c, lisp.h (get_operating_system_release): Remove.
6125 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6126 worth the hassle of breaking this out.
6127
b532497d
PE
6128 * xterm.c: Make symbols static if they're not exported.
6129 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6130 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6131 (x_destroy_window, x_delete_display):
6132 Now static.
6133 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6134 (x_mouse_leave): Remove; unused.
6135 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6136 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6137 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6138 Remove decls.
6139 (x_mouse_leave): Declare only if WINDOWSNT.
6140 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6141 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6142 USE_X_TOOLKIT.
6143
1675728f
PE
6144 * ftxfont.c: Make symbols static if they're not exported.
6145 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6146 HAVE_FREETYPE.
6147 * font.h (ftxfont_driver): Likewise.
6148
e4cebfca
PE
6149 * xfns.c: Make symbols static if they're not exported.
6150 (x_last_font_name, x_display_info_for_name):
6151 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6152 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6153 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6154 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6155 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6156 (last_show_tip_args): Now static.
6157 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6158 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6159 (x_screen_planes): Remove; unused.
6160 * dispextern.h (x_screen_planes): Remove decl.
6161
5bf46f05
PE
6162 * dispnew.c: Make symbols static if they're not exported.
6163 * dispextern.h (redraw_garbaged_frames, scrolling):
6164 (increment_row_positions): Remove.
6165 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6166 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6167 Now static.
6168 (redraw_garbaged_frames): Remove; unused.
6169
435f4c28
PE
6170 * xfaces.c: Make symbols static if they're not exported.
6171 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6172 Remove decls.
6173 * xterm.h (defined_color): Remove decls.
6174 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6175 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6176 (menu_face_changed_default, defined_color, free_realized_face):
6177 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6178 (ascii_face_of_lisp_face): Remove; unused.
6179
8524aef3
PE
6180 * xdisp.c: Make symbols static if they're not exported.
6181 * dispextern.h (scratch_glyph_row, window_box_edges):
6182 (glyph_to_pixel_coords, set_cursor_from_row):
6183 (get_next_display_element, set_iterator_to_next):
6184 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6185 (show_mouse_face): Remove decls
6186 * frame.h (message_buf_print): Likewise.
6187 * lisp.h (pop_message, set_message, check_point_in_composition):
6188 Likewise.
6189 * xterm.h (set_vertical_scroll_bar): Likewise.
6190 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6191 (message_buf_print, scratch_glyph_row, displayed_buffer):
6192 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6193 (get_next_display_element, show_mouse_face, window_box_edges):
6194 (frame_to_window_pixel_xy, check_point_in_composition):
6195 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6196 (glyph_to_pixel_coords): Remove; unused.
6197
16390cd2
PE
6198 * dired.c (file_name_completion): Now static.
6199
6200 * dbusbind.c (xd_in_read_queued_messages): Now static.
6201
a25f4dfa
PE
6202 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6203 * data.c (circular_list_error): Remove.
6204
14a9c8df
PE
6205 * commands.h (last_point_position, last_point_position_buffer):
6206 (last_point_position_window): Remove decls.
6207 * keyboard.c: Make these variables static.
6208
04f2d78b
CB
6209 * coding.h (coding, code_convert_region, encode_coding_gap):
6210 Remove decls.
74ab6df5
PE
6211 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6212 (iso_code_class, detect_coding, code_convert_region): Now static.
6213 (encode_coding_gap): Remove; unused.
6214
38dfbee1
PE
6215 * chartab.c (chartab_chars, chartab_bits): Now static.
6216
a2cb4e63
PE
6217 * charset.h (charset_iso_8859_1): Remove decl.
6218 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6219 Now static.
6220
127198fd
PE
6221 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6222 * ccl.c (Vccl_program_table): Now static.
6223 (check_ccl_update): Remove; unused.
6224
d85b608f
PE
6225 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6226 * category.h: ... from here.
6227 * category.c (check_category_table, set_category_set): Now static.
6228
31cd66f3
PE
6229 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6230 * lisp.h: Remove these decls.
6231
c358e587
PE
6232 * buffer.c (buffer_count): Remove unused var.
6233
e78aecca
PE
6234 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6235 so that it's not optimized away.
6236 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6237 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6238 exported only to the debugger.
6239
e192d7d3 6240 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6241 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6242
92470028
PE
6243 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6244 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6245 was inaccessible from Lisp.
6246 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6247 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6248
244ed907
PE
6249 alloc.c: Import and export fewer symbols, and remove unused items.
6250 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6251 is defined.
6252 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6253 it's not optimized away by whole-program optimization.
6254 (message_enable_multibyte, free_misc): Remove.
6255 (catchlist, handlerlist, mark_backtrace):
6256 Declare only if BYTE_MARK_STACK.
6257 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6258 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6259 (message_enable_multibyte): Remove decl.
6260 (free_misc, interval_free_list, float_block, float_block_index):
6261 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6262 (cons_free_list, last_marked_index):
6263 Now static.
6264 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6265 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6266 (mark_backtrace): Define only if BYTE_MARK_STACK.
6267 * xdisp.c (message_enable_multibyte): Now static.
6268
61c2b50e 6269 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6270 This makes it easier for human readers (and static analyzers)
6271 to see whether these variables are used from other modules.
6272 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6273 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6274 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6275 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6276 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6277 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6278 * xmenu.c, xselect.c:
6279 Declare Q* vars static if they are not used in other modules.
6280 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6281 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6282 Remove decls of unexported vars.
6283 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6284
95c82688
PE
6285 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6286
16a97296
PE
6287 Make Emacs functions such as Fatom 'static' by default.
6288 This makes it easier for human readers (and static analyzers)
6289 to see whether these functions can be called from other modules.
6290 DEFUN now defines a static function. To make the function external
6291 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6292 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6293 (Finit_image_library):
16a97296
PE
6294 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6295 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6296 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6297 Remove decls, since these functions are now static.
6298 (Funintern, Fget_internal_run_time): New decls, since these functions
6299 were already external.
95c82688 6300
16a97296
PE
6301 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6302 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6303 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6304 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6305 * keyboard.c, keymap.c, lread.c:
6306 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6307 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6308 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6309 Mark functions with DEFUE instead of DEFUN,
6310 if they are used in other modules.
6311 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6312 decls for now-static functions.
6313 * buffer.h (Fdelete_overlay): Remove decl.
6314 * callproc.c (Fgetenv_internal): Mark as internal.
6315 * composite.c (Fremove_list_of_text_properties): Remove decl.
6316 (Fcomposition_get_gstring): New forward static decl.
6317 * composite.h (Fcomposite_get_gstring): Remove decl.
6318 * dired.c (Ffile_attributes): New forward static decl.
6319 * doc.c (Fdocumntation_property): New forward static decl.
6320 * eval.c (Ffetch_bytecode): New forward static decl.
6321 (Funintern): Remove extern decl; now in .h file where it belongs.
6322 * fileio.c (Fmake_symbolic_link): New forward static decl.
6323 * image.c (Finit_image_library): New forward static decl.
6324 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6325 * intervals.h (Fprevious_property_change):
6326 (Fremove_list_of_text_properties): Remove decls.
6327 * keyboard.c (Fthis_command_keys): Remove decl.
6328 (Fcommand_execute): New forward static decl.
6329 * keymap.c (Flookup_key): New forward static decl.
6330 (Fcopy_keymap): Now static.
6331 * keymap.h (Flookup_key): Remove decl.
6332 * process.c (Fget_process): New forward static decl.
6333 (Fprocess_datagram_address): Mark as internal.
6334 * syntax.c (Fsyntax_table_p): New forward static decl.
6335 (skip_chars): Remove duplicate decl.
6336 * textprop.c (Fprevious_property_change): New forward static decl.
6337 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6338 Now internal.
6339 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6340 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6341
785bbd42
PE
6342 * editfns.c (Fformat): Remove unreachable code.
6343
8b913b57
AS
63442011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6345
6346 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6347 change. (Bug#8496)
6348
a6744a35
EZ
63492011-04-13 Eli Zaretskii <eliz@gnu.org>
6350
6351 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6352 when at ZV. (Bug#8487)
6353
e7974947
AS
63542011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6355
baad03f0
AS
6356 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6357 (Bug#8437)
6358 * keyboard.c (parse_tool_bar_item): Likewise.
6359 * sound.c (sound_cleanup, alsa_close): Likewise.
6360 * termcap.c (tgetent): Likewise.
6361 * xfns.c (x_default_font_parameter): Likewise.
6362 * xsettings.c (read_and_apply_settings): Likewise.
6363
e7974947
AS
6364 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6365 (overrun_check_free): Protoize.
6366
28272684
PE
63672011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6368
6369 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6370 since callers should never pass a negative size.
6371 Change the signature to match that of plain 'read' and 'write'; see
6372 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6373 * lisp.h: Update prototypes of emacs_write and emacs_read.
6374
11997c76
EZ
63752011-04-11 Eli Zaretskii <eliz@gnu.org>
6376
6377 * xdisp.c (redisplay_window): Don't try to determine the character
6378 position of the scroll margin if the window start point w->startp
e896f03c 6379 is outside the buffer's accessible region. (Bug#8468)
11997c76 6380
8a2cbd72
EZ
63812011-04-10 Eli Zaretskii <eliz@gnu.org>
6382
6383 Fix write-region and its subroutines for buffers > 2GB.
6384 * fileio.c (a_write, e_write): Modify declaration of arguments and
6385 local variables to support buffers larger than 2GB.
6386 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6387
6388 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6389 argument, local variables, and return value.
6390
6391 * lisp.h: Update prototypes of emacs_write and emacs_read.
6392
6393 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6394
4073e537 63952011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6396
1ebfdcb6
PE
6397 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6398
b2ded58d
PE
6399 Fix more problems found by GCC 4.6.0's static checks.
6400
7d66342c
PE
6401 * xdisp.c (vmessage): Use a better test for character truncation.
6402
bbf47d44
PE
6403 * charset.c (load_charset_map): <, not <=, for optimization,
6404 and to avoid potential problems with integer overflow.
9248994d 6405 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6406 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6407 * editfns.c (Fformat): Likewise.
1e69125e 6408 * syntax.c (skip_chars): Likewise.
3befa583 6409
e3019616
PE
6410 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6411 This also lets GCC 4.6.0 generate slightly better loop code.
6412
becfa255
PE
6413 * callint.c (Fcall_interactively): <, not <=, for optimization.
6414 (Fcall_interactively): Count the number of arguments produced,
6415 not the number of arguments given. This is simpler and lets GCC
6416 4.6.0 generate slightly better code.
6417
dae0cd48
PE
6418 * ftfont.c: Distingish more carefully between FcChar8 and char.
6419 The previous code passed unsigned char * to a functions like
6420 strlen and xstrcasecmp that expect char *, which does not
6421 conform to the C standard.
6422 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6423 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6424 char * when the C standard requires it.
6425
76032d70
PE
6426 * keyboard.c (read_char): Remove unused var.
6427
eb3f1cc8
PE
6428 * eval.c: Port to Windows vsnprintf (Bug#8435).
6429 Include <limits.h>.
6430 (SIZE_MAX): Define if the headers do not.
6431 (verror): Do not give up if vsnprintf returns a negative count.
6432 Instead, grow the buffer. This ports to Windows vsnprintf, which
6433 does not conform to C99. Problem reported by Eli Zaretskii.
6434 Also, simplify the allocation scheme, by avoiding the need for
6435 calling realloc, and removing the ALLOCATED variable.
6436
70476b54
PE
6437 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6438
12020a9e
PE
6439 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6440 But keep the doprint source code for now, as we might revamp it
6441 and use it again (Bug#8435).
ea6c7ae6
PE
6442 * lisp.h (doprnt): Remove.
6443 * Makefile.in (base_obj): Remove doprnt.o.
6444 * deps.mk (doprnt.o): Remove.
6445
5fdb398c
PE
6446 error: Print 32- and 64-bit integers portably (Bug#8435).
6447 Without this change, on typical 64-bit hosts error ("...%d...", N)
6448 was used to print both 32- and 64-bit integers N, which relied on
6449 undefined behavior.
6450 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6451 New macro.
6452 * lisp.h (error, verror): Mark as printf-like functions.
6453 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6454 Report overflow in size calculations when allocating printf buffer.
6455 Do not truncate output string at its first null byte.
6456 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6457 Truncate the output at a character boundary, since vsnprintf does not
6458 do that.
6459 * charset.c (check_iso_charset_parameter): Convert internal
6460 character to string before calling 'error', since %c now has the
6461 printf meaning.
6462 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6463 overflow when computing char to be passed to 'error'. Do not
6464 pass Lisp_Object to 'error'; pass the integer instead.
6465 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6466 formatted with plain %d.
6467
b189fa66
PE
6468 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6469
bff87ef0
PE
6470 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6471
7e2cac20
PE
6472 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6473
ce4d90b5
PE
6474 * xterm.c (x_catch_errors): Remove duplicate declaration.
6475
266c9547
PE
6476 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6477
79c49ad2
PE
6478 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6479
368f4090
JM
64802011-04-10 Jim Meyering <meyering@redhat.com>
6481
6482 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6483 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6484 return ssize_t not "int", and use size_t as the buffer length.
6485 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6486 * gnutls.h: Update declarations.
6487 * process.c (read_process_output): Use ssize_t, to match.
6488 (send_process): Likewise.
6489
a32d4040
CY
64902011-04-09 Chong Yidong <cyd@stupidchicken.com>
6491
6492 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6493
8546720e 64942011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6495
04f2d78b
CB
6496 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6497 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6498
8546720e
GM
6499 * xterm.c (handle_one_xevent):
6500 * xmenu.c (create_and_show_popup_menu):
6501 * xselect.c (x_decline_selection_request)
6502 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6503
0a2f5c1a 65042011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6505
6506 Fix some uses of `int' instead of EMACS_INT.
6507 * search.c (string_match_1, fast_string_match)
6508 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6509 (scan_buffer, find_next_newline_no_quit)
6510 (find_before_next_newline, search_command, Freplace_match)
6511 (Fmatch_data): Make some `int' variables be EMACS_INT.
6512
6513 * xdisp.c (display_count_lines): 3rd argument and return value now
6514 EMACS_INT. All callers changed.
6515 (pint2hrstr): Last argument is now EMACS_INT.
6516
6517 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6518 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6519 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6520 (decode_coding_utf_16, decode_coding_emacs_mule)
6521 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6522 (decode_coding_ccl, decode_coding_charset)
6523 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6524 (decode_coding_iso_2022, decode_coding_emacs_mule)
6525 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6526 <char_offset, last_offset>: Declare EMACS_INT.
6527 (encode_coding_utf_8, encode_coding_utf_16)
6528 (encode_coding_emacs_mule, encode_invocation_designation)
6529 (encode_designation_at_bol, encode_coding_iso_2022)
6530 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6531 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6532 Declare EMACS_INT.
6533 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6534 (encode_invocation_designation): Last argument P_NCHARS is now
6535 EMACS_INT.
6536 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6537 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6538
6539 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6540 All users changed.
6541
6542 * ccl.c (Fccl_execute_on_string): Declare some variables
6543 EMACS_INT.
6544
8546720e 65452011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6546
6547 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6548
4e19a977
CS
65492011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6550
6551 * process.c (Fformat_network_address): Doc fix.
6552
87302331
R
65532011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6554
6555 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6556
cbb59342
CY
65572011-04-08 Chong Yidong <cyd@stupidchicken.com>
6558
6559 * keyboard.c (read_char): Call Lisp function help-form-show,
6560 instead of using internal_with_output_to_temp_buffer.
6561 (Qhelp_form_show): New var.
e0d38eeb 6562 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6563
6564 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6565
6566 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6567
e67a13ab
CY
65682011-04-06 Chong Yidong <cyd@stupidchicken.com>
6569
04f2d78b
CB
6570 * process.c (Flist_processes): Remove to Lisp.
6571 (list_processes_1): Delete.
e67a13ab 6572
973f782d
EZ
65732011-04-06 Eli Zaretskii <eliz@gnu.org>
6574
7c106b1e
EZ
6575 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6576
973f782d
EZ
6577 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6578
41cf7d1a 65792011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6580
ca23cc88
PE
6581 Fix more problems found by GCC 4.6.0's static checks.
6582
f390e2d5
PE
6583 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6584
42eea0d0
PE
6585 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6586
b69769da 6587 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6588
f9541e84
PE
6589 * xdisp.c (vmessage): Mark as a printf-like function.
6590
13841b55
PE
6591 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6592
c136c10f
PE
6593 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6594
5e2d4a30
PE
6595 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6596 printf-like functions.
6597 (tiff_load): Add casts to remove these marks before passing them
6598 to system-supplied API.
6599
583f48b9
PE
6600 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6601
b25d760e
PE
6602 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6603 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6604 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6605 directly, rather than having caller test rule sign. This avoids
6606 some unnecessary tests.
6607 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6608 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6609 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6610
bc7b6697 6611 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6612 (xfont_open): Avoid unnecessary tests.
bc7b6697 6613
27ccc379
PE
6614 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6615
dcd5c89a
PE
6616 * composite.h, composite.c (composition_gstring_put_cache):
6617 Use EMACS_INT, not int, for length.
6618
b13a45c6
PE
6619 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6620 breaking out part of COMPOSITION_DECODE_RULE.
6621 (COMPOSITION_DECODE_RULE): Use it.
6622 * composite.c (get_composition_id): Remove unused local vars,
6623 by using the new macro.
6624
1e792e4d
PE
6625 * textprop.c (set_text_properties_1): Change while to do-while,
6626 since the condition is always true at first.
6627
dc6c6455 6628 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6629 (interval_deletion_adjustment): Return unsigned value.
6630 All uses changed.
dc6c6455 6631
aba7731a
PE
6632 * process.c (list_processes_1, create_pty, read_process_output):
6633 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6634 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6635 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6636 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6637 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6638
fdfc4bf3
PE
6639 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6640
fca8fe46 6641 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6642 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6643
06a0259a 6644 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6645 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6646 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6647
e7b9e80f
PE
6648 * print.c (print_error_message): Avoid int overflow.
6649
56201685
PE
6650 * font.c (font_list_entities): Redo for clarity,
6651 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6652
78834453 6653 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6654 (font_score): Avoid potential overflow in diff calculation.
78834453 6655
0bc0b309 6656 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6657 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6658
e610eaca
PE
6659 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6660
b895abce
PE
6661 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6662 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6663 can always succeed if overflow has undefined behavior.
6664
1f1d9321 6665 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6666 (wordify): Omit three unnecessary tests.
1f1d9321 6667
c59478bc
PE
6668 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6669 All callers changed. This avoids the need for an unused var.
6670
79b73827
PE
6671 * casefiddle.c (casify_region): Remove var that is set but not used.
6672
a4db5dfe
PE
6673 * dired.c (file_name_completion): Remove var that is set but not used.
6674
43aae36e
PE
6675 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6676
2a47c44d 6677 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6678 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6679
a37c69bf
PE
6680 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6681 Check for integer overflow on size calculations.
6682
328ab8e7
PE
6683 * buffer.c (Fprevious_overlay_change): Remove var that is set
6684 but not used.
6685
e5a2a5cb
PE
6686 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6687 Remove vars that are set but not used.
8d84a6eb 6688 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6689 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6690
a60e5f68
PE
6691 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6692
f661cb61 6693 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6694 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6695
f0397f5a
PE
6696 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6697 that are set but not used.
6698
8664db06 6699 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6700 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6701
6abdaa4a
PE
6702 * xselect.c (x_get_local_selection, x_handle_property_notify):
6703 Remove vars that are set but not used.
6704
0ce7538d 6705 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6706 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6707
9ae848fc
PE
6708 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6709 Remove var that is set but not used.
0b918413
PE
6710 (scroll_bar_windows_size): Now size_t, not int.
6711 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6712 Check for overflow.
9ae848fc 6713
a5a62657
PE
6714 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6715 (map_tty_color) [!defined MSDOS]: Likewise.
6716
5c5cdd39
PE
6717 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6718
66ebf983
PE
6719 * coding.c: Remove vars that are set but not used.
6720 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6721 All callers changed.
6722 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6723 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6724 (decode_coding_charset): Remove vars that are set but not used.
6725
1be4d761
PE
6726 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6727 that is set but not used.
6728
47553fa8
PE
6729 * print.c (print_object): Remove var that is set but not used.
6730
1f7196bf 6731 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6732 The gnulib version avoids calling malloc in the usual case,
6733 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6734 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6735 * filelock.c (current_lock_owner): Likewise.
6736 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6737 * sysdep.c: Include allocator.h, careadlinkat.h.
6738 (emacs_no_realloc_allocator): New static constant.
6739 (emacs_readlink): New function.
fdb61804
PE
6740 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6741 ../lib/careadlinkat.h.
d1fdcab7 6742
f84c17c7
SM
67432011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6744
6745 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6746 first non-nil return value).
6747
ef3862ad
JD
67482011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6749
6750 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6751 if not defined (Bug#8403).
6752
376a7006
JB
67532011-04-02 Juanma Barranquero <lekktu@gmail.com>
6754
6755 * xdisp.c (display_count_lines): Remove parameter `start',
6756 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6757 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6758 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6759 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6760 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6761 and thereabouts. All callers changed.
6762 (get_per_char_metric): Remove parameter `f', unused since
6763 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6764
6ca3801d
JM
67652011-04-02 Jim Meyering <meyering@redhat.com>
6766
6767 do not dereference NULL upon failed strdup
6768 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6769 (ns_get_family): Likewise.
6770
d8e2b5ba
JB
67712011-04-02 Juanma Barranquero <lekktu@gmail.com>
6772
6773 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6774
8c74fcbd
JD
67752011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6776
6777 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6778 later (Bug#8403).
6779
7200d79c
SM
67802011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6781
03408648 6782 Add lexical binding.
7200d79c 6783
03408648
SM
6784 * window.c (Ftemp_output_buffer_show): New fun.
6785 (Fsave_window_excursion):
6786 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6787
6788 * lread.c (lisp_file_lexically_bound_p): New function.
6789 (Fload): Bind Qlexical_binding.
6790 (readevalloop): Remove `evalfun' arg.
6791 Bind Qinternal_interpreter_environment.
6792 (Feval_buffer): Bind Qlexical_binding.
6793 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6794 Mark as dynamic.
6795 (syms_of_lread): Declare `lexical-binding'.
6796
6797 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6798
6799 * keyboard.c (eval_dyn): New fun.
6800 (menu_item_eval_property): Use it.
ca105506
SM
6801
6802 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6803
03408648
SM
6804 * fns.c (concat, mapcar1): Accept byte-code-functions.
6805
6806 * eval.c (Fsetq): Handle lexical vars.
6807 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6808 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6809 (FletX, Flet): Obey lexical binding.
6810 (Fcommandp): Handle closures.
6811 (Feval): New `lexical' arg.
6812 (eval_sub): New function extracted from Feval. Use it almost
6813 everywhere where Feval was used. Look up vars in lexical env.
6814 Handle closures.
6815 (Ffunctionp): Move from subr.el.
6816 (Ffuncall): Handle closures.
6817 (apply_lambda): Remove `eval_flags'.
6818 (funcall_lambda): Handle closures and new byte-code-functions.
6819 (Fspecial_variable_p): New function.
6820 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6821 but without exporting it to Lisp.
23aba0ea 6822
23aba0ea 6823 * doc.c (Fdocumentation, store_function_docstring):
03408648 6824 * data.c (Finteractive_form): Handle closures.
23aba0ea 6825
03408648
SM
6826 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6827 interactive spec.
ba83908c 6828
04f2d78b
CB
6829 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6830 New byte-codes.
03408648
SM
6831 (exec_byte_code): New function extracted from Fbyte_code to handle new
6832 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6833
03408648 6834 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6835
03408648 6836 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6837
e2abce01
JB
68382011-03-31 Juanma Barranquero <lekktu@gmail.com>
6839
6840 * xdisp.c (redisplay_internal): Fix prototype.
6841
63696a73 68422011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6843
63696a73 6844 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6845 (try_scrolling): Use it when setting scroll_limit.
6846 Limit scrolling to 100 screen lines.
63696a73
EZ
6847 (redisplay_window): Even when falling back on "recentering",
6848 position point in the window according to scroll-conservatively,
6849 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6850
6851 (try_scrolling): When point is above the window, allow searching
6852 as far as scroll_max, or one screenful, to compute vertical
6853 distance from PT to the scroll margin position. This prevents
6854 try_scrolling from unnecessarily failing when
6855 scroll-conservatively is set to a value slightly larger than the
6856 window height. Clean up the case of PT below the margin at bottom
6857 of window: scroll_max can no longer be INT_MAX. When aggressive
6858 scrolling is in use, don't let point enter the opposite scroll
6859 margin as result of the scroll.
6860 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6861 threshold of 100 lines for never-recentering scrolling.
6862
e4cc2dfc
JB
68632011-03-31 Juanma Barranquero <lekktu@gmail.com>
6864
6865 * dispextern.h (move_it_by_lines):
6866 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6867 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6868 (message_log_check_duplicate): Remove parameters `prev_bol' and
6869 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6870 (redisplay_internal): Remove parameter `preserve_echo_area',
6871 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6872
6873 * indent.c (Fvertical_motion):
6874 * window.c (window_scroll_pixel_based, Frecenter):
6875 Don't pass `need_y_p' to `move_it_by_lines'.
6876
1c470562
SM
68772011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6878
44f230aa
SM
6879 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6880 steal a few bits to be more compact.
6881 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6882 Remove unneeded casts.
6883
1c470562
SM
6884 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6885
888adce9
ZK
68862011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6887
6888 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6889 binding" message (bug#7967).
6890
f838ed7b
PE
68912011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6892
77861b95
PE
6893 Fix more problems found by GCC 4.6.0's static checks.
6894
de6dbc14
PE
6895 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6896 Remove unused local var.
6897
f838ed7b
PE
6898 * editfns.c (Fmessage_box): Remove unused local var.
6899
792c7b2b
PE
6900 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6901 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6902 Omit unused local vars.
c499e557 6903 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6904 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6905 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6906 Omit unused local var.
6907
ba0165e1
PE
6908 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6909 Don't assume string length fits in int.
32ad8845 6910 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6911 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6912
3c59b4c9
PE
6913 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6914 instead of alloca (Bug#8344).
6915
a3eed478 6916 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6917 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6918
eb4d412d
PE
6919 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6920
1658b401
PE
6921 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6922 concerns.
6923
6924 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6925
6926 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6927
9a2c6e05
PE
6928 * keyboard.c (syms_of_keyboard): Use the same style as later
6929 in this function when indexing through an array. This also
6930 works around GCC bug 48267.
6931
03d0a109
PE
6932 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6933
44f730c8
PE
6934 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6935
fe75f926
PE
6936 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6937 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6938
ffa8c828
PE
6939 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6940 This avoids undefined behavior on integer overflow, and is a bit
6941 more convenient anyway since it is compared to a size_t variable.
6942
c5101a77
PE
6943 Variadic C functions now count arguments with size_t, not int.
6944 This avoids an unnecessary limitation on 64-bit machines, which
6945 caused (substring ...) to crash on large vectors (Bug#8344).
6946 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6947 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6948 All variadic functions and their callers changed accordingly.
c5101a77
PE
6949 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6950 * data.c (arith_driver, float_arith_driver): Likewise.
6951 * editfns.c (general_insert_function): Likewise.
6952 * eval.c (struct backtrace.nargs, interactive_p)
6953 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6954 (funcall_lambda, mark_backtrace): Likewise.
6955 * fns.c (concat): Likewise.
6956 * frame.c (x_set_frame_parameters): Likewise.
6957 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6958 0 if not found, not -1. All callers changed.
6959
dd3f25f7
PE
6960 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6961 (stack_copy_size): Now size_t, not int.
6962 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6963
461c2ab9
JB
69642011-03-28 Juanma Barranquero <lekktu@gmail.com>
6965
6966 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6967 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6968 All callers changed.
6969
6970 * lisp.h (multibyte_char_to_unibyte):
6971 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6972 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6973 * character.h (CHAR_TO_BYTE8):
6974 * cmds.c (internal_self_insert):
6975 * editfns.c (general_insert_function):
6976 * keymap.c (push_key_description):
6977 * search.c (Freplace_match):
6978 * xdisp.c (message_dolog, set_message_1): All callers changed.
6979
f6d62986
SM
69802011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6981
6982 * keyboard.c (safe_run_hook_funcall): New function.
6983 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6984 don't set the hook to nil, but remove the offending function instead.
6985 (Qcommand_hook_internal): Remove, unused.
6986 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6987 Vcommand_hook_internal.
6988
6989 * eval.c (enum run_hooks_condition): Remove.
6990 (funcall_nil, funcall_not): New functions.
6991 (run_hook_with_args): Call each function through a `funcall' argument.
6992 Remove `cond' argument, now redundant.
6993 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6994 (Frun_hook_with_args_until_failure): Adjust accordingly.
6995 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6996
1db5b1ad
JB
69972011-03-28 Juanma Barranquero <lekktu@gmail.com>
6998
6999 * dispextern.h (string_buffer_position): Remove declaration.
7000
7001 * print.c (strout): Remove parameter `multibyte', unused since
7002 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7003
7004 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7005 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7006 All callers changed.
7007
7008 * w32.c (_wsa_errlist): Use braces for struct initializers.
7009
7010 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7011 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7012 All callers changed.
7013 (string_buffer_position): Likewise. Also, make static (it's never
7014 used outside xdisp.c).
7015 (cursor_row_p): Remove parameter `w', unused since
7016 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7017 (decode_mode_spec): Remove parameter `precision', introduced during
7018 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7019 All callers changed.
7020
5ffb62aa
JD
70212011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7022
7023 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7024
461c2ab9 70252011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7026
7027 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7028 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7029 (ns_update_auto_hide_menu_bar): New functions.
7030 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7031 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7032 ns_constrain_all_frames.
7033 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7034 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7035
5c380ffb
JD
70362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7037
7038 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7039
9af30bdf
GM
70402011-03-27 Glenn Morris <rgm@gnu.org>
7041
7042 * syssignal.h: Replace RETSIGTYPE with void.
7043 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7044 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7045 Replace SIGTYPE with void everywhere.
7046 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7047 * s/template.h (SIGTYPE): Remove commented out definition.
7048
e2abce01
JB
70492011-03-26 Eli Zaretskii <eliz@gnu.org>
7050
7051 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7052 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7053
f868cd8a
JB
70542011-03-26 Juanma Barranquero <lekktu@gmail.com>
7055
59eb0929
JB
7056 * w32.c (read_unc_volume): Use parameter `henum', instead of
7057 global variable `wget_enum_handle'.
7058
7059 * keymap.c (describe_vector): Remove parameters `indices' and
7060 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7061 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7062
f868cd8a
JB
7063 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7064
7065 * keyboard.c (timer_check): Remove parameter `do_it_now',
7066 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7067 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7068 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7069
7070 * keyboard.c (read_char):
7071 * w32menu.c (w32_menu_display_help):
7072 * xmenu.c (show_help_event, menu_help_callback):
7073 Adjust calls to `show_help_echo'.
7074
7075 * gtkutil.c (xg_maybe_add_timer):
7076 * keyboard.c (readable_events):
7077 * process.c (wait_reading_process_output):
7078 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7079
7080 * insdel.c (adjust_markers_gap_motion):
7081 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7082 (gap_left, gap_right): Don't call it.
7083
2ecf6fdb
CY
70842011-03-25 Chong Yidong <cyd@stupidchicken.com>
7085
7086 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7087 incurred during fontification.
7088
6b1f9ba4
JB
70892011-03-25 Juanma Barranquero <lekktu@gmail.com>
7090
7091 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7092 (DEFVAR_PER_BUFFER): Don't pass it.
7093
7094 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7095 (scrolling_window): Don't pass it.
7096
0f4a96b5
JB
70972011-03-25 Juanma Barranquero <lekktu@gmail.com>
7098
7099 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7100
7101 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7102 and `suffix'.
7103 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7104 of variables specific to SELinux and computation of `encoded_absname'.
7105
7106 * image.c (XPutPixel): Remove unused variable `height'.
7107
7108 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7109
7110 * unexw32.c (get_section_info): Remove unused variable `section'.
7111
7112 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7113 (system_process_attributes): Remove unused variable `sess'.
7114 (sys_read): Remove unused variable `err'.
7115
7116 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7117 (w32_wnd_proc): Remove unused variable `isdead'.
7118 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7119 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7120 (x_create_tip_frame): Remove unused variable `tem'.
7121
7122 * w32inevt.c (w32_console_read_socket):
7123 Remove unused variable `no_events'.
7124
7125 * w32term.c (x_draw_composite_glyph_string_foreground):
7126 Remove unused variable `width'.
7127
1149507c
JB
71282011-03-24 Juanma Barranquero <lekktu@gmail.com>
7129
7130 * w32term.c (x_set_glyph_string_clipping):
7131 Don't pass uninitialized region to CombineRgn.
7132
9c88f339
JB
71332011-03-23 Juanma Barranquero <lekktu@gmail.com>
7134
7135 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7136 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7137 (Fx_close_connection): Remove unused variable `i'.
7138
7139 * w32font.c (w32font_draw): Return number of glyphs.
7140 (w32font_open_internal): Remove unused variable `i'.
7141 (w32font_driver): Add missing initializer.
7142
7143 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7144 (fill_in_menu): Remove unused variable `items_added'.
7145
7146 * w32term.c (last_mouse_press_frame): Remove static global variable.
7147 (w32_clip_to_row): Remove unused variable `f'.
7148 (x_delete_terminal): Remove unused variable `i'.
7149
7150 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7151 (NOTHING): Remove unused static global variable.
7152 (uniscribe_check_otf): Remove unused variable `table'.
7153 (uniscribe_font_driver): Add missing initializers.
7154
dee091a3
JD
71552011-03-23 Julien Danjou <julien@danjou.info>
7156
7157 * term.c (Fsuspend_tty, Fresume_tty):
7158 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7159 * window.c (temp_output_buffer_show):
7160 * insdel.c (signal_before_change):
7161 * frame.c (Fhandle_switch_frame):
7162 * fileio.c (Fdo_auto_save):
7163 * emacs.c (Fkill_emacs):
7164 * editfns.c (save_excursion_restore):
7165 * cmds.c (internal_self_insert):
7166 * callint.c (Fcall_interactively):
7167 * buffer.c (Fkill_all_local_variables):
7168 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7169 Use Frun_hooks.
0f4a96b5 7170 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7171 unconditionnaly since it does the check itself.
7172
2c520ab5 71732011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7174
c9c49752
PE
7175 Fix more problems found by GCC 4.5.2's static checks.
7176
8abc3f12
PE
7177 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7178 the first time through the loop, since we know p0 < p1 then.
7179 This also avoids a gcc -Wstrict-overflow warning.
7180
a2d26660
PE
7181 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7182 leading to a memory leak, possible in functions like
7183 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7184 of objects (Bug#8318).
a2d26660 7185
916c72e9
PE
7186 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7187 that could (at least in theory) be that large.
7188
19ab8a18
PE
7189 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7190 This is less likely to overflow, and avoids undefined behavior if
7191 overflow does occur. All callers changed. Use strtoul to scan
7192 for the unsigned long integer.
b7cbbd6f
PE
7193 (pint2hrstr): Simplify and tune code slightly.
7194 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7195
f0641eff
PE
7196 * scroll.c (do_scrolling): Work around GCC bug 48228.
7197 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7198
7f650bb9
PE
7199 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7200 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7201 (validate_x_resource_name): Simplify count usage.
7202 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7203
37dd57d1
PE
7204 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7205 fail (Bug#8306).
81e56e61 7206
699979fc 7207 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7208
401bf9b4
PE
7209 * process.c (Fmake_network_process): Use socklen_t, not int,
7210 where POSIX says socklen_t is required in portable programs.
7211 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7212 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7213 (Fmake_network_process, server_accept_connection):
7214 (wait_reading_process_output, read_process_output):
7215 Likewise.
7216
b93aacde
PE
7217 * process.c: Rename or move locals to avoid shadowing.
7218 (list_processes_1, Fmake_network_process):
7219 (read_process_output_error_handler, exec_sentinel_error_handler):
7220 Rename or move locals.
4dc343ee 7221 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7222 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7223 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7224 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7225 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7226
af8a867c 7227 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7228 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7229 Include tparam.h instead, since it declares them.
af8a867c
PE
7230 * cm.h (PC): Remove extern decl; tparam.h now does this.
7231 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7232 * terminfo.c: Include tparam.h, to check interfaces.
7233 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7234 (tparam): Adjust signature to match interface in tparam.h;
7235 this removes some undefined behavior. Check that outstring and len
7236 are zero, which they always are with Emacs.
7237 * tparam.h (PC, BC, UP): New extern decls.
7238
0248044d 7239 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7240 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7241
8ff096c1 7242 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7243 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7244 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7245 (ftfont_list): Remove unused local.
49eaafba
PE
7246 (get_adstyle_property, ftfont_pattern_entity):
7247 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7248 Rename locals to avoid shadowing.
8ff096c1 7249
e2be39f6
PE
7250 * xfont.c (xfont_list_family): Mark var as initialized.
7251
c9735e30
PE
7252 * xml.c (make_dom): Now static.
7253
8f5201ae
PE
7254 * composite.c (composition_compute_stop_pos): Rename local to
7255 avoid shadowing.
b246f932
PE
7256 (composition_reseat_it): Remove unused locals.
7257 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7258 (composition_update_it): Mark var as initialized.
11b61122
PE
7259 (find_automatic_composition): Mark vars as initialized,
7260 with a FIXME (Bug#8290).
8f5201ae 7261
760fbc2c
PE
7262 character.h: Rename locals to avoid shadowing.
7263 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7264 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7265 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7266 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7267 to avoid shadowing.
7268
ff08eb85
PE
7269 * textprop.c (property_change_between_p): Remove; unused.
7270
fc7bf025
PE
7271 * intervals.c (interval_start_pos): Now static.
7272
235d7abc
PE
7273 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7274
44f230aa
SM
7275 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7276 Rename locals to avoid shadowing.
3e7d6594 7277
50060332
PE
7278 * sound.c (wav_play, au_play, Fplay_sound_internal):
7279 Fix pointer signedness.
d01f234b 7280 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7281 (wav_play): Initialize a variable to 0, to prevent undefined
7282 behavior (Bug#8278).
50060332 7283
c4fc4e30
PE
7284 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7285
918436ed
PE
7286 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7287
c939f91b
PE
7288 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7289 clobbering (Bug#8298).
b9c7f648
PE
7290 * sysdep.c (sys_subshell): Likewise.
7291 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7292
6bd8c144
PE
7293 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7294 This should get cleaned up, so that child_setup has the
7295 same signature on all platforms.
7296
7710357c 7297 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7298 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7299
c59da222
CY
73002011-03-22 Chong Yidong <cyd@stupidchicken.com>
7301
7302 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7303 not to be necessary, and produces flickering.
7304
66b87493
GM
73052011-03-20 Glenn Morris <rgm@gnu.org>
7306
7307 * config.in: Remove file.
7308
45b6f6d5
JB
73092011-03-20 Juanma Barranquero <lekktu@gmail.com>
7310
7311 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7312 are now in src/globals.h.
7313 (syms_of_minibuf): Remove spurious & from previous change.
7314
3ec03f7e
LL
73152011-03-20 Leo <sdl.web@gmail.com>
7316
7317 * minibuf.c (completing-read-function): New variable.
7318 (completing-read-default): Rename from completing-read.
7319 (completing-read): Call completing-read-function.
7320
b14e3e21
CY
73212011-03-19 Juanma Barranquero <lekktu@gmail.com>
7322
7323 * xfaces.c (Fx_load_color_file):
7324 Read color file from absolute filename (bug#8250).
7325
f2b726e6
JB
73262011-03-19 Juanma Barranquero <lekktu@gmail.com>
7327
7328 * makefile.w32-in: Update dependencies.
7329
09f6ff02
EZ
73302011-03-17 Eli Zaretskii <eliz@gnu.org>
7331
7332 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7333
29a6015a
PE
73342011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7335
a3a6c54e
PE
7336 Fix more problems found by GCC 4.5.2's static checks.
7337
b766f867
PE
7338 * process.c (make_serial_process_unwind, send_process_trap):
7339 (sigchld_handler): Now static.
7340
be02381c
PE
7341 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7342 That way, the code declares only the vars that it needs.
7343 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7344 * s/cygwin.h (PTY_ITERATION): Likewise.
7345 * s/darwin.h (PTY_ITERATION): Likewise.
7346 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7347
57048744
PE
7348 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7349 * process.c (allocate_pty): Don't declare stb unless it's needed.
7350
7914961c 7351 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7352 (CONSTANTLIM): Remove; unused.
7353 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7354 Define only if needed.
7914961c 7355
b3967b18
PE
7356 * unexelf.c (unexec): Name an expression,
7357 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7358 Use a different way to cause a compilation error if anyone uses
7359 n rather than nn, a way that does not involve shadowing.
73366a00 7360 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7361
29a6015a
PE
7362 * deps.mk (unexalpha.o): Remove; unused.
7363
43cfc33e 7364 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7365 * unexec.h: New file.
ce701a33
PE
7366 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7367 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7368 Depend on unexec.h.
7369 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7370 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7371 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7372 Change as necessary to match prototype in unexec.h.
ce701a33 7373
01f44d5a
PE
7374 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7375 shadowing.
4f63c6bb 7376 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7377
a6670b0b
PE
7378 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7379 Rename locals to avoid shadowing.
7380
cef2010d 7381 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7382 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7383
d4d7173a
PE
7384 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7385
f08b802a
PE
7386 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7387 warning when compiling print.c.
7388
3ddb0639
PE
7389 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7390 instead of using an uninitialized var.
5ad03b97 7391 (font_sort_entities): Mark var as initialized.
3ddb0639 7392
170a2692
PE
7393 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7394
e663c700
PE
7395 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7396 pointers to constants.
89bc529a 7397 (font_parse_fcname): Remove unused vars.
7b81e2d0 7398 (font_delete_unmatched): Now static.
ea838e10 7399 (font_get_spec): Remove; unused.
13a547c6
PE
7400 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7401 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7402 Rename or move locals to avoid shadowing.
e663c700 7403
2a80c887 7404 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7405 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7406
1384fa33 7407 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7408 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7409
8b2c52e9
PE
7410 * alloc.c (mark_backtrace): Move decl from here ...
7411 * lisp.h: ... to here, so that it can be checked.
7412
475545b5 7413 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7414 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7415 (lisp_indirect_variable): Name an expression,
7416 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7417 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7418
b1349114 7419 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7420 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7421 Use const pointer when appropriate.
b1349114 7422
a2928364
PE
7423 * lisp.h (get_system_name, get_operating_system_release):
7424 Move decls here, to check interfaces.
7425 * process.c (get_operating_system_release): Move decl to lisp.h.
7426 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7427 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7428 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7429 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7430 (Fformat_time_string, Fencode_time, Finsert_char):
7431 (Ftranslate_region_internal, Fformat):
7432 Rename or remove local vars to avoid shadowing.
9710023e 7433 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7434
a415e694
PE
7435 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7436 avoid shadowing.
7437
8ef4622d
PE
7438 * lisp.h (eassert): Check that the argument compiles, even if
7439 ENABLE_CHECKING is not defined.
7440
946f9a5b
PE
7441 * data.c (Findirect_variable): Name an expression, to avoid
7442 gcc -Wbad-function-cast warning.
112396d6 7443 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7444 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7445 (Fmake_variable_buffer_local, Fmake_local_variable):
7446 Mark variables as initialized.
52746918 7447 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7448
e5aab7e7 7449 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7450 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7451 Rename locals to avoid shadowing.
dff45157
PE
7452 (mark_stack): Move local variables into the #ifdef region where
7453 they're used.
7bc26fdb
PE
7454 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7455 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7456 needed otherwise.
7457 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7458 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7459 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7460
e5aab7e7
PE
7461 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7462 avoids undefined behavior in theory.
7463
4da60324
PE
7464 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7465
88043301
PE
7466 Use functions, not macros, for up- and down-casing (Bug#8254).
7467 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7468 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7469 to use the following functions instead of these macros.
7470 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7471 EMACS_INT, since callers assume the returned value fits in int.
7472 (upcase1): Likewise, for UPCASE_TABLE.
7473 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7474 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7475 the race-condition problem in the old DOWNCASE.
88043301 7476
19ed5445
PE
7477 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7478 Rename locals to avoid shadowing.
7479 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7480 (regex_compile, re_search_2, re_match_2_internal):
7481 Remove unused local vars.
952db0d7
PE
7482 (FREE_VAR): Rewrite so as not to use empty "else",
7483 which gcc can warn about.
da053e48 7484 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7485 (RETALLOC_IF): Define only if needed.
7486 (WORDCHAR_P): Likewise. This one is never needed, but is used
7487 only in a comment talking about a compiler bug, so put inside
7488 the #if 0 of that comment.
7489 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7490 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7491 Remove; unused.
19ed5445 7492
1f3561e4 7493 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7494 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7495 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7496
ded6f8f7
PE
7497 * search.c (simple_search): Remove unused var.
7498
dbd37a95
PE
7499 * dired.c (compile_pattern): Move decl from here ...
7500 * lisp.h: ... to here, so that it can be checked.
7501 (struct re_registers): New forward decl.
7502
7e47afad
PE
7503 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7504
85f24f61
PE
7505 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7506 All uses changed.
7507 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7508 Rename locals to avoid shadowing.
5671df8f 7509 (Fvertical_motion): Mark locals as initialized.
85f24f61 7510
181aa2be 7511 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7512 (casify_region): Mark local as initialized.
181aa2be 7513
930d429c
PE
7514 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7515
7082eac6
PE
7516 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7517 New macros, so that the caller can use some names other than
7518 gcpro1, gcpro2, etc.
7519 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7520 of the new macros.
7521 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7522 argument, for consistency with GCPRO2_VAR, etc: it is now the
7523 prefix of the variable, not the variable itself. All uses
7524 changed.
38b2c076
PE
7525 * dired.c (directory_files_internal, file_name_completion):
7526 Rename locals to avoid shadowing.
7527
15206ed9
PE
7528 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7529 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7530 dired.c's scmp function, had undefined behavior.
7531 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7532 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7533 * buffer.h: ... to here, because these macros use current_buffer,
7534 and the new implementation with inline functions needs to have
7535 current_buffer in scope now, rather than later when the macros
7536 are used.
7537 (downcase, upcase1): New static inline functions.
7538 (DOWNCASE, UPCASE1): Reimplement using these functions.
7539 This avoids undefined behavior in expressions like
7540 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7541 from race conditions in accessing the global variables
7542 case_temp1 and case_temp2.
7543 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7544 * lisp.h (case_temp1, case_temp2): Remove their decls.
7545 * character.h (ASCII_CHAR_P): Move from here ...
7546 * lisp.h: ... to here, so that the inline functions mentioned
7547 above can use them.
7548
4a6bea26
PE
7549 * dired.c (directory_files_internal_unwind): Now static.
7550
f14b7e14
PE
7551 * fileio.c (file_name_as_directory, directory_file_name):
7552 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7553 Now static.
2893f146
PE
7554 (file_name_as_directory): Use const pointers when appropriate.
7555 (Fexpand_file_name): Likewise. In particular, newdir might
7556 point at constant storage, so make it a const pointer.
fd4ead52 7557 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7558 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7559 signedness issues.
f839df0c
PE
7560 (Fset_file_times, Finsert_file_contents, auto_save_error):
7561 Rename locals to avoid shadowing.
f14b7e14 7562
5716756e 7563 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7564 (Ftry_completion, Fall_completions): Rename or remove locals
7565 to avoid shadowing.
5716756e 7566
b4c3046a
PE
7567 * marker.c (bytepos_to_charpos): Remove; unused.
7568
b45db522
PE
7569 * lisp.h (verify_bytepos, count_markers): New decls,
7570 so that gcc does not warn that these functions aren't declared.
7571
85876d07
PE
7572 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7573 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7574 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7575 (copy_text): Remove unused local var.
85876d07 7576
03d78a21 7577 * filelock.c (within_one_second): Now static.
b3dd38ab 7578 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7579
5df8f01b
PE
7580 * buffer.c (fix_overlays_before): Mark locals as initialized.
7581 (fix_start_end_in_overlays): Likewise. This function should be
7582 simplified by using pointers-to-pointers, but that's a different
7583 matter.
b1d876f1 7584 (switch_to_buffer_1): Now static.
8f54f30a
PE
7585 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7586 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7587
a70072c9 7588 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7589 Fix pointer signedness issue.
edced198
PE
7590 (sys_subshell): Mark local as volatile if checking for lint,
7591 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7592 (MAXPATHLEN): Define only if needed.
a70072c9 7593
a0977c44
PE
7594 * process.c (serial_open, serial_configure): Move decls from here ...
7595 * systty.h: ... to here, so that they can be checked.
7596
a884fdcc
PE
7597 * fns.c (get_random, seed_random): Move extern decls from here ...
7598 * lisp.h: ... to here, so that they can be checked.
7599
604efe86 7600 * sysdep.c (reset_io): Now static.
b8950c94 7601 (wait_for_termination_signal): Remove; unused.
604efe86 7602
38fc62d9
PE
7603 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7604 (copy_keymap_item, append_key, push_text_char_description):
7605 Now static.
1004a21a 7606 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7607 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7608 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7609 (describe_map_tree):
7610 Rename locals to avoid shadowing.
38fc62d9 7611
2f2650da
PE
7612 * keyboard.c: Declare functions static if they are not used elsewhere.
7613 (echo_char, echo_dash, cmd_error, top_level_2):
7614 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7615 (read_char, kbd_buffer_get_event, make_lispy_position):
7616 (make_lispy_event, make_lispy_movement, apply_modifiers):
7617 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7618 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7619 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7620 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7621 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7622
a053e86c 7623 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7624 (mark_kboards): Move decl here ...
7625 * alloc.c (mark_kboards): ... from here.
a053e86c 7626
4752793e
PE
7627 * lisp.h (force_auto_save_soon): New decl.
7628
74f10ca7 7629 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7630 (DEFINE_DUMMY_FUNCTION): New macro.
7631 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7632 Use it.
c03cd23f
PE
7633 (main): Add casts to avoid warnings
7634 if GCC considers string literals to be constants.
74f10ca7 7635
022e70d4
PE
7636 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7637
59d6fe83
PE
7638 * dbusbind.c: Pointer signedness fixes.
7639 (xd_signature, xd_append_arg, xd_initialize):
7640 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7641 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7642 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7643 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7644
78320123
PE
7645 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7646 if GCC considers string literals to be constants.
49cebcca 7647 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7648
35ac2a97
SM
76492011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7650
fb103ca9
SM
7651 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7652 (print_preprocess, print_object): New macro to fix last change.
7653
35ac2a97
SM
7654 * print.c (print_preprocess): Don't forget font objects.
7655
62973b41
JB
76562011-03-16 Juanma Barranquero <lekktu@gmail.com>
7657
7658 * emacs.c (USAGE3): Doc fixes.
7659
0e48bb22
AS
76602011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7661
7662 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7663 structure.
7664
7684e57b
JB
76652011-03-14 Juanma Barranquero <lekktu@gmail.com>
7666
7667 * lisp.h (VWindow_system, Qfile_name_history):
7668 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7669 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7670 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7671
7672 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7673 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7674
7675 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7676 * w32console.c (detect_input_pending, read_input_pending)
7677 (encode_terminal_code):
7678 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7679 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7680 (w32_system_caret_y, Qfile_name_history):
7681 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7682 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7683 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7684 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7685 * w32proc.c (Qlocal, report_file_error):
7686 * w32term.c (Vwindow_system, updating_frame):
7687 * w32uniscribe.c (initialized, uniscribe_font_driver):
7688 Remove unneeded extern declarations.
7689
2aa46d6c
CY
76902011-03-14 Chong Yidong <cyd@stupidchicken.com>
7691
c96bbc66 7692 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7693
cffc6f3b
CY
76942011-03-13 Chong Yidong <cyd@stupidchicken.com>
7695
7696 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7697 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7698 These macros can no longer be used for assignment.
7699
44f230aa
SM
7700 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7701 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7702 (record_buffer_markers, fetch_buffer_markers): New functions for
7703 recording and fetching special buffer markers.
7704 (set_buffer_internal_1, set_buffer_temp): Use them.
7705
7706 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7707
7708 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7709
7710 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7711 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7712
7713 * xdisp.c (hscroll_window_tree):
7714 (reconsider_clip_changes): Use PT instead of BUF_PT.
7715
d251f04b
EZ
77162011-03-13 Eli Zaretskii <eliz@gnu.org>
7717
7718 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7719 $(EMACS_ROOT)/lib/intprops.h.
7720
f0c77cd1
PE
77212011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7722
3eca4629
PE
7723 Fix more problems found by GCC 4.5.2's static checks.
7724
7c86ee98
PE
7725 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7726 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7727 (xg_free_frame_widgets): Make it clear that a local variable is
7728 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7729 (gdk_window_get_screen): Make it clear that this macro is needed
7730 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7731 (int_gtk_range_get_value): New function, which avoids a diagnostic
7732 from gcc -Wbad-function-cast.
7733 (xg_set_toolkit_scroll_bar_thumb): Use it.
7734 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7735 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7736 (get_utf8_string, xg_get_file_with_chooser):
7737 Rename locals to avoid shadowing.
7738 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7739
41729b81
PE
7740 * xgselect.c (xg_select): Remove unused var.
7741
f0c77cd1
PE
7742 * image.c (four_corners_best): Mark locals as initialized.
7743 (gif_load): Initialize transparent_p to zero (Bug#8238).
7744 Mark another local as initialized.
ec6cf4c6 7745 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7746
ce0ad53d 7747 * image.c (clear_image_cache): Now static.
d5d5a617 7748 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7749 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7750 (x_edge_detection): Remove unnecessary cast that
7751 gcc -Wbad-function-cast diagnoses.
2037898d 7752 (gif_load): Fix pointer signedness.
6ae141d6
PE
7753 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7754 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7755
33383987 77562011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7757
d32df629
PE
7758 Improve quality of tests for time stamp overflow.
7759 For example, without this patch (encode-time 0 0 0 1 1
7760 1152921504606846976) returns the obviously-bogus value (-948597
7761 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7762 reports time overflow. See
7763 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7764 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7765 * editfns.c: Include limits.h and intprops.h.
7766 (TIME_T_MIN, TIME_T_MAX): New macros.
7767 (time_overflow): Move earlier, to before first use.
7768 (hi_time, lo_time): New functions, for an accurate test for
7769 out-of-range times.
7770 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7771 (Fget_internal_run_time): Don't assume time_t fits in int.
7772 (make_time): Use list2 instead of Fcons twice.
7773 (Fdecode_time): More accurate test for out-of-range times.
7774 (check_tm_member): New function.
7775 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7776 (lisp_time_argument): Don't rely on undefined left-shift and
7777 right-shift behavior when checking for time stamp overflow.
8be6f318 7778
fe31d94c
PE
7779 * editfns.c (time_overflow): New function, refactoring common code.
7780 (Fformat_time_string, Fdecode_time, Fencode_time):
7781 (Fcurrent_time_string): Use it.
7782
8be6f318
PE
7783 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7784 * dired.c (make_time): Move to ...
7785 * editfns.c (make_time): ... here.
7786 * systime.h: Note the move.
7787
09d9db2c 77882011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7789
126bc0dc
YM
7790 * fringe.c (update_window_fringes): Remove unused variables.
7791
c47cbdfd
YM
7792 * unexmacosx.c (copy_data_segment): Also copy __got section.
7793 (Bug#8223)
7794
7ac80be9
EZ
77952011-03-12 Eli Zaretskii <eliz@gnu.org>
7796
c96bbc66 7797 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7798 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7799 Constify `char *' arguments and their references according to
7800 prototypes in tparam.h.
7801
ecb0f94d 7802 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7803
7ac80be9
EZ
7804 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7805 Adapt all references accordingly.
7806
7807 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7808
ef1fd07e
TT
78092011-03-11 Tom Tromey <tromey@redhat.com>
7810
7811 * buffer.c (syms_of_buffer): Remove obsolete comment.
7812
7ef4b50c
EZ
78132011-03-11 Eli Zaretskii <eliz@gnu.org>
7814
7815 * termhooks.h (encode_terminal_code): Declare prototype.
7816
7817 * msdos.c (encode_terminal_code): Don't declare prototype.
7818
7819 * term.c (encode_terminal_code): Now external again, used by
7820 w32console.c and msdos.c.
7821
44f230aa
SM
7822 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7823 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7824
4b1ec863 78252011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7826
1714f52b 7827 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7828
4b1ec863
PE
7829 * fringe.c (update_window_fringes): Mark locals as initialized
7830 (Bug#8227).
7831 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7832
524c7aa6
PE
7833 * alloc.c (mark_fringe_data): Move decl from here ...
7834 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7835 to check its interface.
7836 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7837
a5c0af81 7838 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7839 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7840 (fontset_font): Mark local as initialized.
a9a06e0b 7841 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7842
b4716021
PE
7843 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7844
811e9bac 7845 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7846 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7847 (x_own_selection, Fx_disown_selection_internal): Rename locals
7848 to avoid shadowing.
7849 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7850
7e3ab302
PE
7851 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7852 so that the caller can use some name other than gcpro1.
7853 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7854 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7855 (Fx_backspace_delete_keys_p):
7856 Use them to avoid shadowing, and rename vars to avoid shadowing.
7857 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7858 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7859 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7860 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7861 Remove unused locals.
7e3ab302
PE
7862 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7863 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7864 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7865 macros.
f78faa98 7866
e2b13473
PE
7867 * xterm.h (x_mouse_leave): New decl.
7868
77f23912
PE
7869 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7870 Remove unused functions.
cdf4ba58
PE
7871 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7872 (x_calc_absolute_position): Now static.
7411c686 7873 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7874 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7875 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7876 unless they are used.
38d0b34a
PE
7877 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7878 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7879 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7880 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7881 (x_error_catcher, x_connection_closed, x_error_handler):
7882 (x_error_quitter, xembed_send_message, x_iconify_frame):
7883 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7884 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7885 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7886
44f230aa
SM
7887 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7888 Rename or move locals to avoid shadowing.
6b463e58 7889 (tty_defined_color, merge_face_heights): Now static.
5967d051 7890 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7891 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7892 does not deduce is never used uninitialized.
73719eba
PE
7893 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7894 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7895
426994c3 7896 * terminal.c (store_terminal_param): Now static.
5489860b 7897
032f1620 7898 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7899 (set_frame_menubar): Remove unused local.
d4323972 7900 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7901 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7902 since they might point to immutable storage.
281585b0
PE
7903 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7904 since it's unused otherwise.
032f1620 7905
367c19e5 7906 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7907 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7908 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7909 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7910 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7911 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7912 does not deduce are never used uninitialized.
70739cbe 7913
07b48fa9
PE
7914 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7915
8868a238 7916 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7917 * window.c (window_loop, size_window):
7918 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7919
7e5cf297 7920 * window.c (display_buffer): Now static.
d6550a9f
PE
7921 (size_window): Mark variables that gcc -Wuninitialized
7922 does not deduce are never used uninitialized.
a586633d
PE
7923 * window.h (check_all_windows): New decl, to forestall
7924 gcc -Wmissing-prototypes diagnostic.
5b555da1 7925 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7926
f6095868
PE
7927 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7928 shadowing.
7929 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7930 Include <limits.h>.
7931 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7932 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7933 (load_charset_map): Mark variables that gcc -Wuninitialized
7934 does not deduce are never used uninitialized.
53df7c11 7935 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7936
f38b440c
PE
7937 * coding.c (coding_set_source, coding_set_destination):
7938 Use "else { /* comment */ }" rather than "else /* comment */;"
7939 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7940 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7941 a block, when the outer 'i' will do.
7942 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7943 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7944 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7945 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7946 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7947 Rename locals to avoid shadowing.
7948 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7949 * coding.c (emacs_mule_char, encode_invocation_designation):
7950 Now static, since they're not used elsewhere.
413bb2db 7951 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7952 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7953 (decode_coding_emacs_mule): Mark variables that gcc
7954 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7955 (detect_coding_iso_2022): Initialize a local variable that might
7956 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7957 this initialization is needed. (Bug#8211)
5f58e762
PE
7958 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7959 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7960 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7961 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7962 Remove unused macros.
f38b440c 7963
232b38b9 7964 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7965 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7966 * character.c (string_count_byte8): Likewise.
232b38b9 7967
fb90da1b
PE
7968 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7969 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7970
fb93dbc2
PE
7971 * chartab.c (copy_sub_char_table): Now static, since it's not used
7972 elsewhere.
5c156ace
PE
7973 (sub_char_table_ref_and_range, char_table_ref_and_range):
7974 Rename locals to avoid shadowing.
bbcd0949 7975 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7976
7d3b3862 7977 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7978 (BIDI_BOB): Remove unused macro.
7d3b3862 7979
6be7d3da
PE
7980 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7981 deduce are never used uninitialized.
c2ed9c8b 7982 * term.c (encode_terminal_code): Likewise.
6be7d3da 7983
75f8807f 7984 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7985
50938595
PE
7986 * tparam.h: New file.
7987 * term.c, tparam.h: Include it.
7988 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7989 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7990 Move these decls to tparam.h, and make them agree with what
7991 is actually in tparam.c. The previous trick of using incompatible
7992 decls in different modules does not conform to the C standard.
7993 All callers of tparam changed to use tparam's actual API.
7994 * tparam.c (tparam1, tparam, tgoto):
7995 Use const pointers where appropriate.
7996
fbceeba2
PE
7997 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7998 * cm.h (struct cm): Likewise.
7999 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8000 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8001 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8002 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8003 (turn_on_face, init_tty): Likewise.
8004 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8005
7f3f1250
PE
8006 * term.c (term_mouse_position): Rename local to avoid shadowing.
8007
e6ca6543
PE
8008 * alloc.c (mark_ttys): Move decl from here ...
8009 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8010
c40f8d15
AS
80112011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8012
8013 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8014
cfe0661d
JB
80152011-03-09 Juanma Barranquero <lekktu@gmail.com>
8016
8017 * search.c (compile_pattern_1): Remove argument regp, unused since
8018 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8019 (compile_pattern): Don't pass it.
8020
0afb4571
J
80212011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8022
8023 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8024 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8025 for ! HAVE_GTK3.
8026 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8027
8028 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8029
8030 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8031 gdk_window_get_screen, gdk_window_get_geometry,
8032 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8033 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8034 (xg_get_pixbuf_from_pixmap): New function.
8035 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8036 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8037 Call xg_get_pixbuf_from_pixmap instead of
8038 gdk_pixbuf_get_from_drawable.
8039 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8040 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8041 (xg_check_special_colors): Use GtkStyleContext and its functions
8042 for HAVE_GTK3.
8043 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8044 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8045 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8046 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8047 Call gtk_widget_get_preferred_size.
0afb4571
J
8048 (xg_frame_resized): gdk_window_get_geometry only takes 5
8049 parameters.
44f230aa
SM
8050 (xg_win_to_widget, xg_event_is_for_menubar):
8051 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8052 (xg_set_widget_bg): New function.
8053 (delete_cb): New function.
895009e1 8054 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8055 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8056 (xg_set_background_color): Call xg_set_widget_bg.
8057 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8058 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8059 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8060 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8061 if ! HAVE_GTK3.
8062 (update_frame_tool_bar): Call gtk_widget_hide.
8063 (xg_initialize): Use GDK_KEY_g.
8064
8065 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8066 if ! HAVE_GTK3
8067 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8068
8069 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8070 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8071 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8072
1c2cc4ef
JB
80732011-03-08 Juanma Barranquero <lekktu@gmail.com>
8074
8075 * w32xfns.c (select_palette): Check success of RealizePalette against
8076 GDI_ERROR, not zero.
8077
33383987 8078See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8079
8080;; Local Variables:
8081;; coding: utf-8
aac0c6e3
MR
8082;; End:
8083
33383987 8084 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8085
8086 This file is part of GNU Emacs.
8087
8088 GNU Emacs is free software: you can redistribute it and/or modify
8089 it under the terms of the GNU General Public License as published by
8090 the Free Software Foundation, either version 3 of the License, or
8091 (at your option) any later version.
8092
8093 GNU Emacs is distributed in the hope that it will be useful,
8094 but WITHOUT ANY WARRANTY; without even the implied warranty of
8095 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8096 GNU General Public License for more details.
8097
8098 You should have received a copy of the GNU General Public License
8099 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.