* configure.in (dbus_type_is_valid): Check for library function.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
44286096
CY
12012-06-09 Chong Yidong <cyd@gnu.org>
2
1682701f
CY
3 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
4
44286096
CY
5 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
6 case (Bug#9752).
7
d86feb17
PE
82012-06-08 Paul Eggert <eggert@cs.ucla.edu>
9
10 * xdisp.c (vmessage): Treat frame message as multibyte.
11 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
12 would generate the diagnostic "Making \302\247 buffer-local while
13 let-bound!".
14
d5c20fe8
EZ
152012-06-08 Eli Zaretskii <eliz@gnu.org>
16
17 * dispnew.c (showing_window_margins_p): Undo last change, which
18 was done due to an inadvertent commit.
19 (adjust_frame_glyphs_for_frame_redisplay): Do call
20 showing_window_margins_p.
21
513749ee
SM
222012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
23
24 * eval.c (Fmake_var_non_special): New primitive.
25 (syms_of_eval): Defsubr it.
26 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
27
d4a8f5c1
JB
282012-06-08 Juanma Barranquero <lekktu@gmail.com>
29
30 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
31 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
32
8bbbc977
EZ
332012-06-08 Eli Zaretskii <eliz@gnu.org>
34
35 * alloc.c (allocate_vectorlike): Fix last change.
36
f3372c87
DA
372012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
38
39 Block-based vector allocation of small vectors.
40 * lisp.h (struct vectorlike_header): New field `nbytes',
41 adjust comment accordingly.
42 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
43 to denote vector blocks. Adjust users (live_vector_p,
44 mark_maybe_pointer, valid_lisp_object_p) accordingly.
45 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
46 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
47 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
48 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
49 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
50 (roundup_size): New constant.
51 (struct vector_block): New data type.
52 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 53 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
54 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
55 (sweep_vectors): New functions.
56 (allocate_vectorlike): Return `zero_vector' as the only vector of
57 0 items. Allocate new vector from block if vector size is less than
58 or equal to VBLOCK_BYTES_MAX.
59 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
60 (init_alloc_once): Add call to init_vectors.
61
4f18a4ed
SM
622012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
63
64 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
65
86f158bc
PE
662012-06-07 Paul Eggert <eggert@cs.ucla.edu>
67
68 * doprnt.c (doprnt): Truncate multibyte char correctly.
69 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
70 would mishandle a string argument "Xc" if X was a multibyte
71 character of length 2: it would truncate after X's first byte
72 rather than including all of X.
73
c5cfcbe0
CY
742012-06-06 Chong Yidong <cyd@gnu.org>
75
76 * buffer.c (word_wrap): Doc fix.
77
c05cf390
PE
782012-06-04 Paul Eggert <eggert@cs.ucla.edu>
79
80 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
81
0c3461de
GM
822012-06-03 Glenn Morris <rgm@gnu.org>
83
84 * xdisp.c (tool-bar-style): Doc fix.
85
c71232db
UM
862012-06-03 Ulrich Müller <ulm@gentoo.org>
87
88 * Makefile.in (PAXCTL): Define.
89 (temacs$(EXEEXT)): Disable memory randomization for the temacs
90 binary via PaX flags if the paxctl utility is available.
91 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
92 Restore PaX flags to their default. (Bug#11398)
93
383f7350
CY
942012-06-03 Chong Yidong <cyd@gnu.org>
95
96 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
97 buffer (Bug#11226).
98
5f2c76c6
CY
992012-06-03 Chong Yidong <cyd@gnu.org>
100
101 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
102 (note_mode_line_or_margin_highlight): If there is no help echo,
103 use mode-line-default-help-echo. Handle the case where the mouse
104 position is past the end of the mode line string.
105
106 * buffer.c (buffer_local_value_1): New function, split from
107 Fbuffer_local_value; can return Qunbound.
108 (Fbuffer_local_value): Use it.
109 (Vmode_line_format): Docstring tweaks.
110
773d47f6
PE
1112012-06-02 Paul Eggert <eggert@cs.ucla.edu>
112
113 * sysdep.c (system_process_attributes): Improve comment.
114
f2d6a3df
SM
1152012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
116
117 * keyboard.c: Export real-this-command to Elisp.
118 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
119 and DEFVAR it. Update all users.
120
63810350
PE
1212012-06-02 Paul Eggert <eggert@cs.ucla.edu>
122
7bd5c1f4
PE
123 * minibuf.c (Fassoc_string): Remove duplicate declaration.
124
63810350
PE
125 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
126 Convert pctcpu and pctmem to Lisp float properly.
127 Let the compiler fold better, as 100.0/0x8000 is exact.
128
a2821611
AS
1292012-06-02 Andreas Schwab <schwab@linux-m68k.org>
130
131 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
132 cons_block.
133
5fceba1d
PE
1342012-06-01 Paul Eggert <eggert@cs.ucla.edu>
135
136 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
137
c98ff5dd
DA
1382012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
139
140 For a 'struct window', replace some Lisp_Object fields to
141 bitfields where appropriate, remove unused fields.
142 * window.h (struct window): Remove unused 'last_mark_x' and
143 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
144 change it's type from Lisp_Object to bitfield.
145 Change type of 'force_start', 'optional_new_start',
146 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
147 fields from Lisp_Object to bitfield. Adjust users accordingly.
148
ca34e0be
PE
1492012-05-31 Paul Eggert <eggert@cs.ucla.edu>
150
151 Pacify gcc -Wdouble-precision when using Xaw.
152 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
153 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
154 Use 'float' consistently, rather than 'float' in most places
155 and 'double' in a couple of places.
156
efc00ab1 1572012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
158
159 * xdisp.c (handle_stop): Detect whether we have overlay strings
160 loaded by testing it->current.overlay_string_index to be
161 non-negative, instead of checking whether n_overlay_strings is
162 positive. (Bug#11587)
163
efc00ab1 1642012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
165
166 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
167
168 * doc.c (Fsubstitute_command_keys): Doc fix.
169
efc00ab1 1702012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
171
172 * search.c (search_buffer): Remove calls to
173 r_alloc_inhibit_buffer_relocation, as it is now called by
174 maybe_unify_char, which was the cause of relocation of buffer text
175 in bug#11519.
176
efc00ab1 1772012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
178
179 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
180 for the duration of call to load_charset, to avoid problems with
181 callers of maybe_unify_char that access buffer text through C
182 pointers.
183
184 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
185 decrement the inhibition flag, instead of just setting or
186 resetting it.
187
ba93a187
PE
1882012-05-31 Paul Eggert <eggert@cs.ucla.edu>
189
190 Remove obsolete '#define static' cruft.
191 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
192 This #undef was "temporary" in 2000; it is no longer needed
193 now that '#define static' has gone away.
194 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
195 (gray_bitmap_bits): Remove; no longer needed.
196 All uses replaced with definiens.
197 * xterm.c: Include "bitmaps/gray.xbm".
198
9e4bf381
PE
1992012-05-30 Paul Eggert <eggert@cs.ucla.edu>
200
201 Clean up __executable_start, monstartup when --enable-profiling.
202 The following changes affect the code only when profiling.
203 * dispnew.c (__executable_start): Rename from safe_bcopy.
204 Define only on platforms that need it.
205 * emacs.c: Include <sys/gmon.h> when profiling.
206 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
207 (__executable_start): Remove decl, since lisp.h does it now.
208 (safe_bcopy): Remove decl; no longer has that name.
209 (main): Coalesce #if into single bit of code, for simplicity.
210 Cast pointers to uintptr_t, since standard libraries want integers
211 and not pointers.
212 * lisp.h (__executable_start): New decl.
213
32d72c2f
GM
2142012-05-31 Glenn Morris <rgm@gnu.org>
215
216 * image.c (Fimagemagick_types): Doc fix.
217
baac5bc7
JM
2182012-05-30 Jim Meyering <meyering@redhat.com>
219
220 * callproc.c (Fcall_process_region): Include directory component
221 in mkstemp error message (Bug#11586).
222
72cb32cf
PE
2232012-05-30 Paul Eggert <eggert@cs.ucla.edu>
224
225 * alloc.c, lisp.h (make_pure_vector): Now static.
226
61b108cc
SM
2272012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
228
229 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
230 Move to byte-run.el.
231 (Fautoload): Do the hash-doc more carefully.
232 * data.c (Fdefalias): Purify definition, except for keymaps.
233 (Qdefun): Move from eval.c.
234 * lisp.h (Qdefun): Remove.
235 * lread.c (read1): Tiny simplification.
236
471fe23d
TN
2372012-05-29 Troels Nielsen <bn.troels@gmail.com>
238
934f3f58 239 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
240 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
241 Bug#9642, but explicitly check that the buffer the overlay would
242 be moved to is live and rearrange lines to make sure that errors
243 will not put the overlay in an inconsistent state.
244 (Fdelete_overlay): Cosmetics.
245
85d0efd1
EZ
2462012-05-28 Eli Zaretskii <eliz@gnu.org>
247
248 * w32term.c (my_bring_window_to_top): New function.
249 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
250 could be different from the original one.
251 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
252 (Bug#11513)
253
254 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
255 by calling BringWindowToTop.
256
257 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
258 (WM_EMACS_END): Increase by one.
259
da92a98c
PE
2602012-05-28 Paul Eggert <eggert@cs.ucla.edu>
261
262 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
263 This avoids undefined behavior that might cause the eassert
264 to not catch an out-of-range value.
265
74d1f848
JB
2662012-05-28 Juanma Barranquero <lekktu@gmail.com>
267
268 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
269 Update dependencies.
270
9e1a06fc
EZ
2712012-05-27 Eli Zaretskii <eliz@gnu.org>
272
273 * bidi.c (bidi_mirror_char): Fix last change.
274
f3dd7312
AS
2752012-05-27 Andreas Schwab <schwab@linux-m68k.org>
276
277 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
278 when referring to sectname field in printf format.
279
81899c91
PE
2802012-05-27 Paul Eggert <eggert@cs.ucla.edu>
281
57b81a9f
PE
282 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
283 Only r_alloc_inhibit_buffer_relocation needed to be added;
284 the others were already declared.
285
81899c91
PE
286 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
287 before checking whether it's out of range. Put the check inside
288 eassert. See
289 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
290
33017faf 2912012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
292
293 * callproc.c (Fcall_process): Restore a line that was accidentally
294 commented out in the 2011-02-13 change (bug#11547).
295
33017faf 2962012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
297
298 * lisp.h [REL_ALLOC]: Add prototypes for external functions
299 defined on ralloc.c.
300
301 * buffer.c [REL_ALLOC]: Remove prototypes of
302 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
303 they are now on lisp.h.
304
305 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
306
307 * search.c (search_buffer): Use it to inhibit relocation of buffer
308 text while re_search_2 is doing its job, because re_search_2 is
309 passed C pointers to buffer text. (Bug#11519)
310
23415acf
EZ
311 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
312 Update value to 24.
313
44e27368
EZ
314 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
315 state after an additional call to move_it_in_display_line_to, keep
316 the values of it->max_ascent and it->max_descent found for the
317 entire line.
318 (pos_visible_p): Revert the comparison against bottom_y to what it
319 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
320 (Bug#11464)
321
c1892f11
PE
3222012-05-26 Paul Eggert <eggert@cs.ucla.edu>
323
324 Fix coding-related core dumps with gcc -ftrapv.
325 The code was computing A - B, where A and B are pointers, and B is
326 random garbage. This can lead to core dumps on platforms that
327 have special pointer registers, and it also leads to core dumps on
328 x86-64 when compiled with gcc -ftrapv. The fix is to compute
329 A - B only when B is initialized properly.
330 * coding.c (coding_set_source, coding_set_destination): Return void.
331 (coding_change_source, coding_change_destinations): New functions,
332 with the old behaviors of coding_set_source and coding_set_destination.
333 All callers that need an offset changed to use these new functions.
334
eb7afdad
GM
3352012-05-26 Glenn Morris <rgm@gnu.org>
336
337 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
338
f12fdf02
EZ
3392012-05-26 Eli Zaretskii <eliz@gnu.org>
340
53a63be6 341 Extend mouse support on W32 text-mode console.
61b108cc
SM
342 * xdisp.c (draw_row_with_mouse_face):
343 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 344
eb3f6f01 345 * w32console.c: Include window.h.
61b108cc
SM
346 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
347 New functions.
eb3f6f01
EZ
348 (initialize_w32_display): Initialize mouse-highlight data.
349
53a63be6
EZ
350 * w32inevt.c: Include termchar.h and window.h.
351 (do_mouse_event): Support mouse-autoselect-window. When the mouse
352 moves, call note_mouse_highlight. If help_echo changed, call
353 gen_help_event to produce help-echo message in the echo area.
354 Call clear_mouse_face if mouse_face_hidden is set in the mouse
355 highlight info.
356
4cfd81f6
PE
3572012-05-26 Paul Eggert <eggert@cs.ucla.edu>
358
359 * lread.c (read1): Simplify slightly to avoid an overflow warning
360 with GCC 4.7.0 on x86-64.
361
4446092a
EZ
3622012-05-26 Eli Zaretskii <eliz@gnu.org>
363
364 * bidi.c (bidi_mirror_char): Revert last change: an int is
365 definitely wide enough here.
366
42b2a986 3672012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 368
42b2a986 369 Fix integer width and related bugs (Bug#9874).
eb106a49 370 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
371 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
372 (string_bytes, check_sblock, allocate_string_data):
373 (compact_small_strings, Fmake_bool_vector, make_string)
374 (make_unibyte_string, make_multibyte_string)
375 (make_string_from_bytes, make_specified_string)
376 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
377 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
378 (mark_vectorlike):
379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
380 (allocate_pseudovector):
381 Use int, not EMACS_INT, where int is wide enough.
382 (inhibit_garbage_collection, Fgarbage_collect):
383 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
384 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
385 int might not be wide enough.
386 (bidi_cache_search, bidi_cache_find, bidi_init_it)
387 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
388 (bidi_at_paragraph_end, bidi_find_paragraph_start)
389 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
390 (bidi_level_of_next_char, bidi_move_to_visually_next):
391 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
392 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
393 (Fkill_buffer, Fset_buffer_major_mode)
394 (advance_to_char_boundary, Fbuffer_swap_text)
395 (Fset_buffer_multibyte, overlays_at, overlays_in)
396 (overlay_touches_p, struct sortvec, record_overlay_string)
397 (overlay_strings, recenter_overlay_lists)
398 (adjust_overlays_for_insert, adjust_overlays_for_delete)
399 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
400 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
401 (Foverlay_recenter, last_overlay_modification_hooks_used)
402 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
404 (validate_region): Omit unnecessary test for b <= e,
405 since that's guaranteed by the previous test.
d311d28c
PE
406 (adjust_overlays_for_delete): Avoid pos + length overflow.
407 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
408 (report_overlay_modification):
409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
410 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
411 Omit pointer cast, which isn't needed anyway, and doesn't work
412 after the EMACS_INT -> ptrdiff_t change.
02481186 413 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
414 * buffer.h: Adjust decls to match defn changes elsewhere.
415 (struct buffer_text, struct buffer):
416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
417 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
418 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
419 not int, to avoid needless 32-bit limit on 64-bit hosts.
420 (exec_byte_code): Use tighter memory-full test, one that checks
421 for alloca overflow. Don't compute the address of the object just
422 before an array, as that's not portable. Use EMACS_INT, not
423 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
424 * callint.c (Fcall_interactively):
425 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
426 * callproc.c (call_process_kill, Fcall_process):
427 Don't assume pid_t fits into an Emacs fixnum.
428 (call_process_cleanup, Fcall_process, child_setup):
429 Don't assume pid_t fits into int.
430 (call_process_cleanup, Fcall_process, delete_temp_file)
431 (Fcall_process_region):
432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
433 (Fcall_process): Simplify handling of volatile integers.
434 Use int, not EMACS_INT, where int will do.
435 * casefiddle.c (casify_object, casify_region, operate_on_word)
436 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
438 (casify_object): Avoid integer overflow when overallocating buffer.
439 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 440 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
441 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
442 * category.h (CATEGORYP): Don't assume arg is nonnegative.
443 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
444 integers are now checked earlier. All uses replaced with XINT.
445 (ccl_driver):
446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
447 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
448 (ccl_driver, Fregister_code_conversion_map):
449 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
450 (resolve_symbol_ccl_program): Check that vector header is in range.
451 Always copy the vector, so that we can check its contents reliably
452 now rather than having to recheck each instruction as it's being
453 executed. Check that vector words fit in 'int'.
454 (ccl_get_compiled_code, Fregister_ccl_program)
455 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
456 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
457 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
458 contents are in range.
459 (Fccl_execute_on_string): Check that status is in range.
460 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
461 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
462 Accept and return EMACS_INT, not int, because callers can pass values
463 out of 'int' range.
464 (c_string_width, strwidth, lisp_string_width, chars_in_text)
465 (multibyte_chars_in_text, parse_str_as_multibyte)
466 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
467 (str_as_unibyte, str_to_unibyte, string_count_byte8)
468 (string_escape_byte8, Fget_byte):
469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 470 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
471 avoid mishandling large integers.
472 * character.h: Adjust decls to match defn changes elsewhere.
473 * charset.c (load_charset_map_from_file, find_charsets_in_text)
474 (Ffind_charset_region):
475 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
476 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
477 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 478 Don't assume fixnum fits in int.
d311d28c
PE
479 (load_charset_map_from_vector, Fmap_charset_chars):
480 Remove now-unnecessary CHECK_NATNUMs.
481 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
482 Don't rely on undefined behavior with signed left shift overflow.
483 Don't assume unsigned int fits into fixnum, or that fixnum fits
484 into unsigned int. Don't require max_code to be a valid fixnum;
485 that's not true for gb10830 4-byte on a 32-bit host. Allow
486 invalid_code to be a cons, for the same reason. Require code_offset
487 to be a character. Avoid int overflow if max_char is close
488 to INT_MAX.
489 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
490 this is intended anyway and avoids some undefined behavior.
491 (load_charset_map): Pass unsigned, not int, as 2nd arg of
492 INDEX_TO_CODE_POINT, as that's what it expects.
493 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
494 * charset.h (DECODE_CHAR): Return int, not unsigned;
495 this is what was intended anyway, and it avoids undefined behavior.
496 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
497 integer-overflow issues.
498 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
499 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
500 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
501 * chartab.c (Fmake_char_table, Fset_char_table_range)
502 (uniprop_get_decoder, uniprop_get_encoder):
503 Don't assume fixnum fits in int.
504 * cmds.c (move_point): New function, that does the gist of
505 Fforward_char and Fbackward_char, but does so while checking
506 for integer overflow more accurately.
c96e5d6a 507 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
508 (Fforward_line, Fend_of_line, internal_self_insert)
509 (internal_self_insert):
510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
511 Fix a FIXME, by checking for integer overflow when calculating
512 target_clm and actual_clm.
513 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 514 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
515 (ASSURE_DESTINATION, coding_alloc_by_realloc)
516 (coding_alloc_by_making_gap, alloc_destination)
517 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
518 (encode_coding_utf_16, detect_coding_emacs_mule)
519 (decode_coding_emacs_mule, encode_coding_emacs_mule)
520 (detect_coding_iso_2022, decode_coding_iso_2022)
521 (encode_invocation_designation, encode_designation_at_bol)
522 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
523 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
524 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
525 (encode_coding_ccl, encode_coding_raw_text)
526 (detect_coding_charset, decode_coding_charset)
527 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
528 (produce_composition, produce_charset, produce_annotation)
529 (decode_coding, handle_composition_annotation)
530 (handle_charset_annotation, consume_chars, decode_coding_gap)
531 (decode_coding_object, encode_coding_object, detect_coding_system)
532 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
533 (code_convert_region, code_convert_string)
8f50130c
PE
534 (Fdefine_coding_system_internal)
535 (coding_set_source, coding_set_destination):
d311d28c
PE
536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
537 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
538 (Fdefine_coding_system_internal):
539 Don't assume fixnums fit in int.
540 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 541 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
542 (Funencodable_char_position, Fcheck_coding_systems_region)
543 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 545 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 546 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 547 Don't access memory outside of the args array.
d311d28c 548 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
549 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
550 result of ENCODE_CHAR.
d311d28c
PE
551 * coding.h: Adjust decls to match defn changes elsewhere.
552 (struct coding_system):
553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
554 * composite.c (get_composition_id, find_composition)
555 (run_composition_function, update_compositions)
556 (compose_text, composition_gstring_put_cache)
557 (composition_gstring_p, composition_gstring_width)
558 (fill_gstring_header, fill_gstring_body, autocmp_chars)
559 (composition_compute_stop_pos, composition_reseat_it)
560 (composition_update_it, struct position_record)
561 (find_automatic_composition, composition_adjust_point)
562 (Fcomposition_get_gstring, Ffind_composition_internal):
563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
564 (update_compositions):
565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
566 * composite.h: Adjust decls to match defn changes elsewhere.
567 (struct composition):
568 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
569 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
570 Do not attempt to compute the address of the object just before a
571 buffer; this is not portable.
572 (Faref, Faset):
573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
574 (Faset): Use int, not EMACS_INT, where int is wide enough.
575 (Fstring_to_number): Don't assume fixnums fit in int.
576 (Frem): Don't assume arg is nonnegative.
577 * dbusbind.c (xd_append_arg): Check for integers out of range.
578 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 579 (extract_signed, extract_unsigned): New functions.
243e0530
PE
580 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
581 (xd_get_connection_references): Return ptrdiff_t, not int.
582 All uses changed.
583 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
584 (xd_read_message_1):
585 Use int, not unsigned, where the dbus API uses int.
586 (Fdbus_message_internal): Don't overflow mtype.
587 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
588 * dired.c (directory_files_internal, file_name_completion, scmp)
589 (file_name_completion_stat):
590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
591 (file_name_completion): Don't overflow matchcount.
592 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
593 * dispextern.h: Adjust decls to match defn changes elsewhere.
594 (struct text_pos, struct glyph, struct bidi_saved_info)
595 (struct bidi_string_data, struct bidi_it, struct composition_it)
596 (struct it):
597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
598 (struct display_pos, struct composition_it, struct it):
599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
600 * dispnew.c (increment_matrix_positions)
601 (increment_row_positions, mode_line_string)
602 (marginal_area_string):
603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 604 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
606 (duration_to_sec_usec): New function, to check for overflow better.
607 (Fsleep_for, sit_for): Use it.
608 * doc.c (get_doc_string, store_function_docstring):
609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
610 (get_doc_string, Fsnarf_documentation):
611 Use int, not EMACS_INT, where int is wide enough.
612 (get_doc_string):
613 Use SAFE_ALLOCA, not alloca.
614 Check for overflow when converting EMACS_INT to off_t.
615 * doprnt.c (doprnt):
616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
617 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
618 Don't assume uid_t fits into fixnum.
619 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
620 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
621 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
622 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
623 (general_insert_function)
624 (Finsert_char, make_buffer_string, make_buffer_string_both)
625 (update_buffer_properties, Fbuffer_substring)
626 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
627 (Fsubst_char_in_region, check_translation)
628 (Ftranslate_region_internal, save_restriction_restore, Fformat)
629 (transpose_markers, Ftranspose_regions):
630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
631 (clip_to_bounds): Move to lisp.h as an inline function).
632 (Fconstrain_to_field): Don't assume integers are nonnegative.
633 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
634 (Fsubst_char_in_region, Fsave_restriction):
635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
636 (Femacs_pid): Don't assume pid_t fits into fixnum.
637 (lo_time): Use int, not EMACS_INT, when int suffices.
638 (lisp_time_argument): Check for usec out of range.
639 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
640 (Fuser_login_name, Fuser_full_name): Signal an error
641 if a uid argument is out of range, rather than relying on
642 undefined behavior.
c8d5c857
PE
643 (Fformat_time_string): Remove now-unnecessary check.
644 lisp_time_argument checks for out-of-range usec now.
243e0530 645 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
646 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
647 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
648 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
649 (init_cmdargs, Fdump_emacs):
650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
651 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
652 the bottom (typically) 32 bits of the fixnum.
653 * eval.c (specpdl_size, call_debugger):
654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
655 (when_entered_debugger, Fbacktrace_debug):
656 Don't assume fixnum can fit in int.
657 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
658 the object just before a buffer; this is not portable.
659 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
660 (grow_specpdl, unbind_to):
661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
662 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
663 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 664 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
665 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
666 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
668 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
669 (a_write, e_write):
670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
671 (Fcopy_file, non_regular_nbytes, read_non_regular)
672 (Finsert_file_contents):
673 Use int, not EMACS_INT, where int is wide enough.
674 (READ_BUF_SIZE): Verify that it fits in int.
675 (Finsert_file_contents): Check that counts are in proper range,
676 rather than assuming fixnums fit into ptrdiff_t etc.
677 Don't assume fixnums fit into int.
125b3835 678 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
679 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
680 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
681 (string_char_to_byte, string_byte_to_char)
682 (string_make_multibyte, string_to_multibyte)
683 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
684 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
685 (substring_both, Fdelete, internal_equal, Ffillarray)
686 (Fclear_string, mapcar1)
687 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
688 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
689 (larger_vector, make_hash_table, maybe_resize_hash_table)
690 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
691 (Fmaphash, secure_hash):
692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
693 (concat): Check for string index and length overflow.
694 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
695 (Frequire):
696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
697 (larger_vector): New API (vec, incr_min, size_max) replaces old
698 one (vec, new_size, init). This catches size overflow.
699 INIT was removed because it was always Qnil.
700 All callers changed.
701 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
702 the upper bound on a hash table index size.
703 (make_hash_table, maybe_resize_hash_table): Use it.
704 (secure_hash): Computer start_byte and end_byte only after
705 they're known to be in ptrdiff_t range.
706 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
707 (Ffont_get_glyphs, Ffont_at):
708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
709 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
710 (Flist_fonts, Fopen_font):
711 Don't assume fixnum can fit in int.
712 (check_gstring): Don't assume index can fit in int.
713 (font_match_p): Check that fixnum is a character, not a nonnegative
714 fixnum, since the later code needs to stuff it into an int.
715 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
716 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
717 conversion overflow issues.
718 (Fopen_font): Check for integer out of range.
719 (Ffont_get_glyphs): Don't assume index can fit in int.
720 * font.h: Adjust decls to match defn changes elsewhere.
721 * fontset.c (reorder_font_vector): Redo score calculation to avoid
722 integer overflow.
723 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
724 printmax_t, where ptrdiff_t is wide enough.
725 (Finternal_char_font):
726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
727 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
728 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
729 (Fset_frame_position, x_set_frame_parameters)
730 (x_set_line_spacing, x_set_border_width)
731 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
732 Check that fixnums are in proper range for system types.
733 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
735 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
736 Use SAFE_ALLOCA_LISP, not alloca.
737 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
738 intptr_t is wide enough.
739 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
740 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
741 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
742 Check for fixnum out of range.
743 * ftfont.c (ftfont_list): Don't assume index fits in int.
744 Check that fixnums are in proper range for system types.
745 (ftfont_shape_by_flt):
746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
747 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
749 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
750 Check that fixnums are in proper range for system types.
751 * gnutls.h: Adjust decls to match defn changes elsewhere.
752 * gtkutil.c (xg_dialog_run):
753 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
754 (update_frame_tool_bar):
755 Check that fixnums are in proper range for system types.
756 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 757 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
758 * indent.c (last_known_column, last_known_column_point):
759 (current_column_bol_cache):
760 (skip_invisible, current_column, check_display_width):
761 (check_display_width, scan_for_column, current_column_1)
762 (Findent_to, Fcurrent_indentation, position_indentation)
763 (indented_beyond_p, Fmove_to_column, compute_motion):
764 (Fcompute_motion, Fvertical_motion):
765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
766 (last_known_column_modified): Use EMACS_INT, not int.
767 (check_display_width):
768 (Fcompute_motion):
769 Check that fixnums and floats are in proper range for system types.
770 (compute_motion): Don't assume index or fixnum fits in int.
771 (compute_motion, Fcompute_motion):
772 Use int, not EMACS_INT, when it is wide enough.
773 (vmotion): Omit local var start_hpos that is always 0; that way
774 we don't need to worry about overflow in expressions involving it.
775 * indent.h: Adjust decls to match defn changes elsewhere.
776 (struct position):
777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
778 Use int, not EMACS_INT, where int is wide enough.
779 Remove unused members ovstring_chars_done and tab_offset;
780 all uses removed.
781 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
782 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
783 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
784 (make_gap, copy_text, insert, insert_and_inherit)
785 (insert_before_markers, insert_before_markers_and_inherit)
786 (insert_1, count_combining_before, count_combining_after)
787 (insert_1_both, insert_from_string)
788 (insert_from_string_before_markers, insert_from_string_1)
789 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
790 (adjust_after_replace, adjust_after_insert, replace_range)
791 (replace_range_2, del_range, del_range_1, del_range_byte)
792 (del_range_both, del_range_2, modify_region)
793 (prepare_to_modify_buffer, signal_before_change)
794 (signal_after_change, Fcombine_after_change_execute):
795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
796 * intervals.c (traverse_intervals, rotate_right, rotate_left)
797 (balance_an_interval, split_interval_right, split_interval_left)
798 (find_interval, next_interval, update_interval)
799 (adjust_intervals_for_insertion, delete_node, delete_interval)
800 (interval_deletion_adjustment, adjust_intervals_for_deletion)
801 (static_offset_intervals, offset_intervals)
802 (merge_interval_right, merge_interval_left, make_new_interval)
803 (graft_intervals_into_buffer, temp_set_point_both)
804 (temp_set_point, set_point, adjust_for_invis_intang)
805 (set_point_both, move_if_not_intangible, get_property_and_range)
806 (get_local_map, copy_intervals, copy_intervals_to_string)
807 (compare_string_intervals, set_intervals_multibyte_1):
808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
809 * intervals.h: Adjust decls to match defn changes elsewhere.
810 (struct interval):
811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
812 * keyboard.c (this_command_key_count, this_single_command_key_start)
813 (before_command_key_count, before_command_echo_length, echo_now)
814 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
815 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
816 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
817 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
819 (last_non_minibuf_size, last_point_position, echo_truncate)
820 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
821 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
822 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
823 (stuff_buffered_input):
824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
825 (last_auto_save, command_loop_1, read_char):
826 Use EMACS_INT, not int, to avoid integer overflow.
827 (record_char): Avoid overflow in total_keys computation.
828 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
829 * keyboard.h: Adjust decls to match defn changes elsewhere.
830 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
831 (Fkey_description, Fdescribe_vector, Flookup_key):
832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
833 (click_position): New function, to check that positions are in range.
834 (Fcurrent_active_maps):
835 (describe_command):
836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
837 (Faccessible_keymaps, Fkey_description):
838 (preferred_sequence_p):
839 Don't assume fixnum can fit into int.
840 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
841 Check for integer overflow in size calculations.
842 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
843 avoid mishandling large integers.
844 * lisp.h: Adjust decls to match defn changes elsewhere.
845 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
846 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
847 (struct Lisp_Marker):
848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
849 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
850 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
851 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
852 All callers changed.
853 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
854 Assume the arg has valid form, since it always does.
855 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
856 unsigned integer system type.
857 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
858 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
860 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
861 (duration_to_sec_usec): New decl.
862 * lread.c (read_from_string_index, read_from_string_index_byte)
863 (read_from_string_limit, readchar, unreadchar, openp)
864 (read_internal_start, read1, oblookup):
865 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
866 (Fload, readevalloop, Feval_buffer, Feval_region):
867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
868 (openp): Check for out-of-range argument to 'access'.
869 (read1): Use int, not EMACS_INT, where int is wide enough.
870 Don't assume fixnum fits into int.
6efdadfd 871 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
872 (read_filtered_event): Use duration_to_sec_usec
873 to do proper overflow checking on durations.
d311d28c
PE
874 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
875 in size calculation.
876 (Fexecute_kbd_macro):
877 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
878 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
879 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
880 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
881 (set_marker_both, set_marker_restricted_both, marker_position)
882 (marker_byte_position, Fbuffer_has_markers_at):
883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
884 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 885 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
886 It now merely ensures that the menu is large enough, without
887 necessarily growing it, as this avoids some integer overflow issues.
888 All callers changed.
889 (keymap_panes, parse_single_submenu, Fx_popup_menu):
890 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
891 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
892 Use SAFE_ALLOCA_LISP, not alloca.
893 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
894 to EMACS_INT. Check that fixnums are in proper range for system types.
895 * minibuf.c (minibuf_prompt_width, string_to_object)
896 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
897 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
899 (get_minibuffer, read_minibuf_unwind):
900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
901 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
902 this simplifies overflow checking. All callers changed.
903 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
904 (Ftest_completion):
905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
906 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
907 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
908 Check that fixnums are in proper range for system types.
909 (Fx_create_frame, Fx_show_tip):
910 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
911 * nsfont.m (ns_findfonts, nsfont_list_family):
912 Don't assume fixnum fits in long.
913 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
914 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
915 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
916 wide enough.
17fdb222 917 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
919 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
920 (PRINTDECLARE, PRINTPREPARE):
921 (strout, print_string):
922 (print, print_preprocess, print_check_string_charset_prop)
923 (print_object):
924 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
925 (PRINTDECLARE):
926 (temp_output_buffer_setup, Fprin1_to_string, print_object):
927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
928 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 929 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 930 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
931 (print_error_message): Use SAFE_ALLOCA, not alloca.
932 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
933 (print_depth, new_backquote_output, print_number_index):
934 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
935 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
936 (Fset_process_window_size, Fformat_network_address)
937 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 938 (sigchld_handler):
d311d28c 939 Check that fixnums are in proper range for system types.
d44287d4 940 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
941 Check for process-ids out of pid_t range rather than relying on
942 undefined behavior.
e4d81efc 943 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
944 (Fformat_network_address, read_process_output, send_process)
945 (Fprocess_send_region, status_notify):
946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
947 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
948 (wait_reading_process_output, read_process_output, exec_sentinel):
949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
950 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
951 (Faccept_process_output): Use duration_to_sec_usec to do proper
952 overflow checking on durations.
dde14581
PE
953 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
954 Don't assume pid_t fits in int.
02481186
PE
955 * process.h (struct Lisp_Process): Members tick and update_tick
956 are now of type EMACS_INT, not int.
b62b53e8
PE
957 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
958 configured --with-wide-int.
d311d28c
PE
959 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
960 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
961 * search.c (looking_at_1, string_match_1):
962 (fast_string_match, fast_c_string_match_ignore_case)
963 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
964 (scan_newline, find_before_next_newline, search_command)
965 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
966 (set_search_regs, wordify):
967 (Freplace_match):
968 (Fmatch_data):
969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
970 (string_match_1, search_buffer, set_search_regs):
971 (Fmatch_data):
972 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
973 (wordify): Check for overflow in size calculation.
974 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
975 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
976 Check that fixnums are in proper range for system types.
977 * sound.c (struct sound_device)
978 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
980 (Fplay_sound_internal):
981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 982 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
983 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
984 (Fparse_partial_sexp):
985 Don't assume fixnums can fit in int.
986 (struct lisp_parse_state, find_start_pos, find_start_value)
987 (find_start_value_byte, find_start_begv)
988 (update_syntax_table, char_quoted, dec_bytepos)
989 (find_defun_start, prev_char_comend_first, back_comment):
990 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
991 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
993 (Finternal_describe_syntax_value): Check that match_lisp is a
994 character, not an integer, since the code stuffs it into int.
995 (scan_words, scan_sexps_forward):
996 Check that fixnums are in proper range for system types.
997 (Fforward_word):
998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
999 (scan_sexps_forward):
1000 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1001 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1002 * syntax.h: Adjust decls to match defn changes elsewhere.
1003 (struct gl_state_s):
1004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1005 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1006 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1007 * sysdep.c (wait_for_termination_1, wait_for_termination)
1008 (interruptible_wait_for_termination, mkdir):
1009 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1010 (emacs_read, emacs_write):
1011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1012 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1013 and double all fit in int.
d311d28c
PE
1014 * term.c (set_tty_color_mode):
1015 Check that fixnums are in proper range for system types.
1016 * termhooks.h (struct input_event):
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 * textprop.c (validate_interval_range, interval_of)
1019 (Fadd_text_properties, set_text_properties_1)
1020 (Fremove_text_properties, Fremove_list_of_text_properties)
1021 (Ftext_property_any, Ftext_property_not_all)
1022 (copy_text_properties, text_property_list, extend_property_ranges)
1023 (verify_interval_modification):
1024 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1025 (Fnext_single_char_property_change)
1026 (Fprevious_single_char_property_change):
1027 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1028 (copy_text_properties):
1029 Check for integer overflow in index calculation.
d311d28c
PE
1030 * undo.c (last_boundary_position, record_point, record_insert)
1031 (record_delete, record_marker_adjustment, record_change)
1032 (record_property_change):
1033 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1034 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1035 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1036 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1037 (Fx_hide_tip, Fx_file_dialog):
1038 * w32menu.c (set_frame_menubar):
1039 Use ptrdiff_t, not int, for consistency with rest of code.
1040 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1041 (select_window, Fdelete_other_windows_internal)
1042 (window_scroll_pixel_based, window_scroll_line_based)
1043 (Frecenter, Fset_window_configuration):
1044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1045 (Fset_window_hscroll, run_window_configuration_change_hook)
1046 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1047 (Fscroll_other_window, Frecenter):
d311d28c
PE
1048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1049 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1050 Don't assume fixnum fits in int.
1051 (Fset_window_scroll_bars):
1052 Check that fixnums are in proper range for system types.
1053 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1054 (string_pos, c_string_pos, number_of_chars, init_iterator)
1055 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1056 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1057 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1058 (face_before_or_after_it_pos, handle_invisible_prop)
1059 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1060 (display_prop_intangible_p, string_buffer_position_lim)
1061 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1062 (get_overlay_strings_1, get_overlay_strings)
1063 (iterate_out_of_display_property, forward_to_next_line_start)
1064 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1065 (get_next_display_element, set_iterator_to_next)
1066 (get_visually_first_element, compute_stop_pos_backwards)
1067 (handle_stop_backwards, next_element_from_buffer)
1068 (move_it_in_display_line_to, move_it_in_display_line)
1069 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1070 (add_to_log, message_dolog, message_log_check_duplicate)
1071 (message2, message2_nolog, message3, message3_nolog
1072 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1073 (current_message_1, truncate_echo_area, truncate_message_1)
1074 (set_message, set_message_1, store_mode_line_noprop)
1075 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1076 (text_outside_line_unchanged_p, check_point_in_composition)
1077 (reconsider_clip_changes)
1078 (redisplay_internal, set_cursor_from_row, try_scrolling)
1079 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1080 (redisplay_window, find_last_unchanged_at_beg_row)
1081 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1082 (trailing_whitespace_p, find_row_edges, display_line)
1083 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1084 (display_mode_element, store_mode_line_string)
1085 (pint2str, pint2hrstr, decode_mode_spec)
1086 (display_count_lines, display_string, draw_glyphs)
1087 (x_produce_glyphs, x_insert_glyphs)
1088 (rows_from_pos_range, mouse_face_from_buffer_pos)
1089 (fast_find_string_pos, mouse_face_from_string_pos)
1090 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1092 (safe_call, init_from_display_pos, handle_fontified_prop)
1093 (handle_single_display_spec, load_overlay_strings)
1094 (with_echo_area_buffer, setup_echo_area_for_printing)
1095 (display_echo_area, echo_area_display)
1096 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1097 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1098 (redisplay_window, dump_glyph_row, display_mode_line)
1099 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1100 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1102 (handle_single_display_spec, build_desired_tool_bar_string)
1103 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1104 (get_specified_cursor_type):
1105 Check that fixnums are in proper range for system types.
1106 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1107 (Flookup_image_map):
1108 Don't assume fixnums fit in int.
1109 (compare_overlay_entries):
1110 Avoid mishandling comparisons due to subtraction overflow.
1111 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1112 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1113 (handle_tool_bar_click):
1114 Use int, not unsigned, since we prefer signed and the signedness
1115 doesn't matter here.
1116 (get_next_display_element, next_element_from_display_vector):
1117 Use int, not EMACS_INT, when int is wide enough.
1118 (start_hourglass): Use duration_to_sec_usec to do proper
1119 overflow checking on durations.
1120 * xfaces.c (Fbitmap_spec_p):
1121 Check that fixnums are in proper range for system types.
1122 (compare_fonts_by_sort_order):
1123 Avoid mishandling comparisons due to subtraction overflow.
1124 (Fx_family_fonts, realize_basic_faces):
1125 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1126 (Fx_family_fonts):
1127 Don't assume fixnum fits in int.
1128 Use SAFE_ALLOCA_LISP, not alloca.
1129 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1130 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1131 (face_at_buffer_position, face_for_overlay_string)
1132 (face_at_string_position):
1133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1134 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1135 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1136 (Fx_show_tip):
1137 Check that fixnums are in proper range for system types.
1138 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1139 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1140 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1141 (Fx_change_window_property): Don't assume fixnums fit in int.
1142 * xfont.c (xfont_chars_supported):
1143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1144 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1145 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1147 * xml.c (parse_region):
1148 * xrdb.c (magic_file_p):
1149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1150 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1151 (x_get_local_selection, x_reply_selection_request)
1152 (x_handle_selection_request, wait_for_property_change):
1153 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1154 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1155 short is wide enough.
1156 (x_send_client_event): Don't assume fixnum fits in int.
1157 * xterm.c (x_x_to_emacs_modifiers):
1158 Don't assume EMACS_INT overflows nicely into int.
1159 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1160 may come from Lisp.
1161 (handle_one_xevent): NATNUMP can eval its arg twice.
1162 (x_connection_closed):
1163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1164 * xterm.h: Adjust decls to match defn changes elsewhere.
1165 (struct scroll_bar): Use struct vectorlike_header
1166 rather than rolling our own approximation.
1167 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1168
c6574eb5
GM
11692012-05-25 Glenn Morris <rgm@gnu.org>
1170
1171 * lisp.mk (lisp): Update for more files being compiled now.
1172
e8d32c7e
SM
11732012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1174
48def666
SM
1175 * lread.c: Remove `read_pure' which makes no difference.
1176 (read_pure): Remove var.
1177 (unreadpure): Remove function.
1178 (readevalloop): Don't call read_list with -1 flag.
1179 (read1, read_vector): Don't test read_pure any more.
1180 (read_list): Simplify.
1181
e8d32c7e
SM
1182 * fileio.c, character.h: Minor style tweaks.
1183
4b2addb7
DA
11842012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1185
1186 * window.h (clip_changed): Remove useless declaration.
1187
584461b2
JB
11882012-05-22 Juanma Barranquero <lekktu@gmail.com>
1189
1190 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1191 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1192
34374650
PE
11932012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1194
1195 Remove src/m/*.
1196 This directory predates autoconf and is no longer needed nowadays.
1197 Move its few remaining bits of functionality to where they're needed.
1198 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1199 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1200 * m/template.h: Remove.
1201 * Makefile.in (M_FILE): Remove. All uses removed.
1202 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1203 * lisp.h (USE_LSB_TAG):
1204 * mem-limits.h (EXCEEDS_LISP_PTR):
1205 Use VAL_MAX, not VALBITS, in #if.
1206 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1207 (EMACS_UINT): Define unconditionally now.
1208 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1209 (BITS_PER_EMACS_INT): New constants, replacing
1210 what used to be in config.h, but not useful in #if.
1211 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1212 define them any more.
1213 (VAL_MAX): New macro.
1214 (VALMASK): Use it.
1215 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1216 BITS_PER_EMACS_INT, in #if.
1217 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1218 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1219 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1220 * s/ms-w32.h (DATA_START):
1221 Move here from removed file m/intel386.h.
1222 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1223 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1224
261cb4bb
PE
12252012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1226
1227 Assume C89 or later.
1228 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1229 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1230 (xrealloc):
1231 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1232 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1233 * textprop.c, tparam.c (NULL): Remove.
1234 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1235 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1236 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1237 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1238 * xterm.c (input_signal_count): Assume volatile works.
1239
ff23cd9f
KB
12402012-05-21 Ken Brown <kbrown@cornell.edu>
1241
1242 * xgselect.c (xg_select): Fix first argument in call to 'select'
1243 (bug#11508).
1244
1b170bc6
KB
12452012-05-20 Ken Brown <kbrown@cornell.edu>
1246
1247 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1248 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1249
b2f4d39f
KB
12502012-05-19 Ken Brown <kbrown@cornell.edu>
1251
1252 * xfns.c (x_in_use): Remove `static' qualifier.
1253 * xterm.h (x_in_use): Declare.
1254 * xgselect.c: Include xterm.h.
1255 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1256 and `display_arg' (bug#9754).
1257
003fdae2
PE
12582012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1259
9232a6d9
PE
1260 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1261
003fdae2
PE
1262 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1263 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1264
784b56e2
EZ
12652012-05-18 Eli Zaretskii <eliz@gnu.org>
1266
1267 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1268
1269 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1270 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1271
1272 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1273 reference to image_cache->refcount.
1274 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1275
a0a79cde
JL
12762012-05-17 Juri Linkov <juri@jurta.org>
1277
1278 * search.c (Fword_search_regexp, Fword_search_backward)
1279 (Fword_search_forward, Fword_search_backward_lax)
1280 (Fword_search_forward_lax): Move functions to isearch.el
1281 (bug#10145, bug#11381).
1282
b0572523
PE
12832012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1284
1285 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1286
9660f5fc
SM
12872012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1288
1289 * lread.c (init_obarray): Declare Qt and Qnil as special.
1290
4374de83
GM
12912012-05-14 Glenn Morris <rgm@gnu.org>
1292
1293 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1294 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1295
dc44c39a
PE
12962012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1297
078c97cb
PE
1298 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1299
dc44c39a
PE
1300 * unexaix.c: Port to more-recent AIX compilers.
1301 (report_error, report_error_1, make_hdr, copy_sym)
1302 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1303 Make arguments const char *, not char *, to avoid violations of C
1304 standard and to fix some AIX warnings reported by Gilles Pion.
1305
e18afed7 13062012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1307
1308 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1309 already have overlays loaded.
1310 (handle_single_display_spec): Before returning without displaying
1311 fringe bitmap, synchronize the bidi iterator with the main display
1312 iterator, by calling iterate_out_of_display_property.
1313 (iterate_out_of_display_property): Detect buffer iteration by
1314 testing that it->string is a Lisp string.
1315 (get_next_display_element): When the current object is exhausted,
1316 and there's something on it->stack, call set_iterator_to_next to
1317 proceed with what's on the stack, instead of returning zero.
1318 (set_iterator_to_next): If called at the end of a Lisp string,
1319 proceed to consider_string_end without incrementing string
1320 position. Don't increment display vector index past the end of
1321 the display vector. (Bug#11417)
c8fb9dc6
EZ
1322 (pos_visible_p): Don't report a position visible when move_it_to
1323 stopped at the last line of window, which happens to be scanned
1324 backwards by the bidi iteration. (Bug#11464)
ac268e67 1325
e18afed7 13262012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1327
1328 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1329 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1330 are on a TTY, and thus unable to display on the fringes.
1331 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1332 so we need to signal to the caller that this is a "replacing"
1333 display spec. This fixes display when the spec is invalid or we
1334 are on a TTY.
1335
e18afed7 13362012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1337
1338 * unexaix.c (make_hdr): Fix typo in prototype.
1339 This bug broke the build on AIX. Problem reported by Gilles Pion.
1340
9d0a235a
MA
13412012-05-14 Michael Albinus <michael.albinus@gmx.de>
1342
1343 * keyboard.c (kbd_buffer_get_event): Read special events also in
1344 batch mode. (Bug#11415)
1345
9e6b06ed
GM
13462012-05-12 Glenn Morris <rgm@gnu.org>
1347
1348 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1349
c1a1d7a3
EZ
13502012-05-12 Eli Zaretskii <eliz@gnu.org>
1351
1352 * lisp.mk (lisp): Add newcomment.elc.
1353
3fe7cdc8
GM
13542012-05-12 Glenn Morris <rgm@gnu.org>
1355
1356 * Makefile.in (MKDIR_P): New, set by configure.
1357 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1358
53f7d2c0
PE
13592012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 Remove unused function hourglass_started.
1362 * dispextern.h (hourglass_started):
1363 * w32fns.c (hourglass_started):
1364 * xdisp.c (hourglass_started): Remove.
1365
75aafb17
JB
13662012-05-10 Juanma Barranquero <lekktu@gmail.com>
1367
1368 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1369 Update dependencies.
1370
12959e8e
PE
13712012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1372
97107e2e
PE
1373 * xgselect.c (xg_select): Put maxfds+1 into a var.
1374 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1375
12959e8e
PE
1376 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1377
836d29b3
DA
13782012-05-10 Dave Abrahams <dave@boostpro.com>
1379
1380 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1381 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1382
5cb67954
MA
13832012-05-09 Michael Albinus <michael.albinus@gmx.de>
1384
1385 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1386 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1387 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1388 Initialize xd_registered_buses.
1389
3478ec45
PE
13902012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1391
b263a6b0
PE
1392 Untag more efficiently if USE_LSB_TAG.
1393 This is based on a proposal by YAMAMOTO Mitsuharu in
1394 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1395 For an admittedly artificial (nth 8000 longlist) benchmark on
1396 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1397 Emacs's overall text size by 1%.
1398 * lisp.h (XUNTAG): New macro.
1399 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1400 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1401 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1402 * eval.c (Fautoload):
1403 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1404 * frame.h (XFRAME): Use XUNTAG.
1405
3478ec45
PE
1406 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1407 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1408 Remove unportable assumptions about print widths of types like
1409 dbus_uint32_t.
1410 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1411 intptr_t when converting between pointer and integer, to avoid GCC
1412 warnings about wrong width.
1413
666b903b 14142012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1415
1416 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1417 stack for each reader_thread, instead of defaulting to 8MB
1418 determined by the linker. This avoids failures in creating
1419 subprocesses on Windows 7, see the discussion in this thread:
1420 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1421
b120cc17
JC
14222012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1423
1424 Fix up display of the *Minibuf-0* buffer in the mini window.
1425 * keyboard.c (read_char): Don't clear the echo area if there's no
1426 message to clear.
1427 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1428 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1429
9a4b36f8
MA
14302012-05-07 Michael Albinus <michael.albinus@gmx.de>
1431
1432 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1433 batch mode.
1434
e5f9458f
CY
14352012-05-06 Chong Yidong <cyd@gnu.org>
1436
1437 * lisp.mk (lisp): Update.
1438
eceeb5fc 14392012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1440
1441 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1442
71873e2b
SM
14432012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1444
1445 * data.c (PUT_ERROR): New macro.
1446 (syms_of_data): Use it. Add new error type `user-error'.
1447 * undo.c (user_error): New function.
1448 (Fprimitive_undo): Use it.
1449 * print.c (print_error_message): Adjust print style for `user-error'.
1450 * keyboard.c (user_error): New function.
1451 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1452
ab0fa4e4
PE
14532012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1454
1455 Do not limit current-time-string to years 1000..9999.
1456 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1457 (Fcurrent_time_string): Support any year that is supported by the
1458 underlying localtime representation. Don't use asctime, as it
1459 has undefined behavior for years outside the range -999..9999.
1460
7ed806a7
PE
14612012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1462
1463 Fix race conditions involving setenv, gmtime, localtime, asctime.
1464 Without this fix, interrupts could mess up code that uses these
1465 nonreentrant functions, since setting TZ invalidates existing
1466 tm_zone or tzname values, and since most of these functions return
1467 pointers to static storage.
1468 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1469 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1470 Grow the critical sections to include not just invoking
1471 localtime/gmtime, but also accessing these functions' results
1472 including their tm_zone values if any, and any related TZ setting.
1473 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1474 so that the struct tm is saved in the critical section.
1475 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1476 motivated by the fact that memory allocation needs to be outside
1477 the critical section.
1478
0c16dfed
DA
14792012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1480
1481 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1482 with RESET_INTERVAL.
1483
1484 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1485 Remove duplicated buffer name initialization.
1486
3f83ace8
JM
14872012-05-02 Jim Meyering <jim@meyering.net>
1488
1489 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1490
c7b8541e
JM
1491 * xfns.c (x_window): Use xstrdup (Bug#11375).
1492
90207a15 14932012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1494
1495 * xdisp.c (pos_visible_p): If already at a newline from the
1496 display string before the 'while' loop, don't walk back the glyphs
1497 from it3.glyph_row. Solves assertion violation when the display
1498 string begins with a newline (egg.el). (Bug#11367)
1499
b593d6a9
AH
15002012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1501
1502 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1503 Move to simple.el.
1504
4737362e
GM
15052012-05-01 Glenn Morris <rgm@gnu.org>
1506
99cf43f9
GM
1507 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1508 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1509 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1510 All were removed before 23.1.
1511
9311dcff
GM
1512 * dispnew.c: Remove HAVE_LIBNCURSES test;
1513 it is always true on relevant platforms.
1514
4d5c6349
GM
1515 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1516 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1517
4737362e
GM
1518 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1519
74dd3a6b
AS
15202012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1521
1522 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1523 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1524 Remove.
1525
13c379ee
PE
15262012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1527
1528 Do not avoid creating empty evaporating overlays (Bug#9642).
1529 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1530 That is, do not delete an evaporating overlay if it becomes
1531 empty after its bounds are adjusted to fit within its buffer.
1532 This fix caused other problems, and I'm reverting it until we get
1533 to the bottom of them.
1534
a8e7d6d7 15352012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1536
1537 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1538
a8e7d6d7 15392012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1540
1541 * xdisp.c (pos_visible_p): If the window start position is beyond
1542 ZV, start the display from buffer beginning. Prevents assertion
1543 violation in init_iterator when the minibuffer window is scrolled
1544 via the scroll bar.
1545
1546 * window.c (window_scroll_pixel_based): Likewise.
1547
a8e7d6d7 15482012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1549
1550 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1551
a8e7d6d7 15522012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1553
1554 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1555 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1556
a8e7d6d7 15572012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1558
b593d6a9
AH
1559 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1560 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1561
1c6900d9
EZ
15622012-04-26 Eli Zaretskii <eliz@gnu.org>
1563
4c3fa1d9
EZ
1564 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1565 display element, check also the underlying string or buffer
1566 character. (Bug#11341)
1567
1c6900d9
EZ
1568 * w32menu.c: Include w32heap.h.
1569 (add_menu_item): If the call to AppendMenuW (via
1570 unicode_append_menu) fails, disable Unicode menus only if we are
1571 running on Windows 9X/Me.
1572
42bf8205
AS
15732012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1574
1575 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1576 (xgetint): Add missing shift for LSB tags.
1577
b1bac16e
MR
15782012-04-24 Martin Rudalics <rudalics@gmx.at>
1579
1580 * keyboard.c (read_char): Don't wipe echo area for select window
1581 events: These might get delayed via `mouse-autoselect-window'
1582 (Bug#11304).
1583
d69621cc
JB
15842012-04-24 Juanma Barranquero <lekktu@gmail.com>
1585
1586 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1587 manipulation of :loaded-from data.
1588
02fd101b
JB
15892012-04-23 Juanma Barranquero <lekktu@gmail.com>
1590
1591 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1592 now a cons (bug#11311).
1593
888bec30
PE
15942012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1595
89a438bd
PE
1596 Do not create empty overlays with the evaporate property (Bug#9642).
1597 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1598 if it becomes empty after its bounds are adjusted to fit within
1599 its buffer. Without this fix, in a nonempty buffer (let ((o
1600 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1601 yields an empty overlay that has the evaporate property, which is
1602 not supposed to happen.
1603
1068fe4d
PE
1604 Fix minor GTK3 problems found by static checking.
1605 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1606 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1607 (struct _EmacsFixedClass, emacs_fixed_get_type):
1608 Move decls here from emacsgtkfixed.h, since they needn't be public.
1609 (emacs_fixed_get_type): Now static.
1610 (emacs_fixed_class_init): Omit unused local.
1611 (emacs_fixed_child_type): Remove; unused.
1612 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1613 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1614 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1615 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1616 (EMACS_FIXED_GET_CLASS): Remove; unused.
1617 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1618
888bec30
PE
1619 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1620 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1621
de85e130
PE
16222012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1623
d0baac98 1624 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1625 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1626 (__malloc_size_t, __malloc_ptrdiff_t):
1627 Remove. All uses removed, replaced by the definiens if needed,
1628 since we can assume C89 or better now.
1629 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1630 (protect_malloc_state, align, get_contiguous_space)
1631 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1632 (malloc_atfork_handler_child, malloc_enable_thread)
1633 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1634 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1635 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1636 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1637 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1638 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1639 Define using prototypes, not old style.
1640 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1641 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1642 (align): Don't assume that signed integer overflow wraps around.
1643 Omit unused local var.
1644 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1645 (_free_internal_nolock, memalign, mallochook, reallochook):
1646 Omit no-longer-needed casts.
1647 (valloc): Use getpagesize, not __getpagesize.
1648 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1649 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1650
de85e130
PE
1651 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1652
dcbf5805
MA
16532012-04-22 Michael Albinus <michael.albinus@gmx.de>
1654
1655 Move functions from C to Lisp. Make non-blocking method calls
1656 the default. Implement further D-Bus standard interfaces.
1657
1658 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1659 (QCdbus_request_name_allow_replacement)
1660 (QCdbus_request_name_replace_existing)
1661 (QCdbus_request_name_do_not_queue)
1662 (QCdbus_request_name_reply_primary_owner)
1663 (QCdbus_request_name_reply_in_queue)
1664 (QCdbus_request_name_reply_exists)
1665 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1666 (QCdbus_registered_serial, QCdbus_registered_method)
1667 (QCdbus_registered_signal): New Lisp objects.
1668 (XD_DEBUG_MESSAGE): Use sizeof.
1669 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1670 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1671 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1672 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1673 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1674 (xd_signature, xd_append_arg): Allow float for integer types.
1675 (xd_get_connection_references): New function.
b593d6a9
AH
1676 (xd_get_connection_address): Rename from xd_initialize.
1677 Return cached address.
dcbf5805
MA
1678 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1679 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1680 level.
1681 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1682 Return number of refcounts.
dcbf5805
MA
1683 (Fdbus_get_unique_name): Make stronger parameter check.
1684 (Fdbus_message_internal): New defun.
1685 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1686 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1687 (Fdbus_send_signal, Fdbus_register_service)
1688 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1689 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1690 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1691 (Vdbus_compiled_version, Vdbus_runtime_version)
1692 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1693 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1694 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1695 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1696 Adapt docstring.
dcbf5805 1697
52828e02
PE
16982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1699
da05bc4c
PE
1700 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1701 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1702 Do not assume ptrdiff_t is the same width as 'int'.
1703
52828e02
PE
1704 * alloc.c: Handle unusual debugging option combinations.
1705 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1706 since the two debugging options are incompatible.
1707 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1708 is defined.
1709 (mem_init, mem_insert, mem_insert_fixup):
1710 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1711 (NEED_MEM_INSERT): Remove; no longer needed.
1712
f01769f9
LL
17132012-04-22 Leo Liu <sdl.web@gmail.com>
1714
1715 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1716
5790543d
PE
17172012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1718
1719 * sysdep.c [__FreeBSD__]: Minor cleanups.
1720 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1721 Use Emacs indenting style more consistently. Avoid some casts.
1722 Use 'double' consistently rather than mixing 'float' and 'double'.
1723
b91b7e4d
EW
17242012-04-21 Eduard Wiebe <usenet@pusto.de>
1725
b593d6a9
AH
1726 * sysdep.c (list_system_processes, system_process_attributes):
1727 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1728
6114eb15
AS
17292012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1730
1731 * lisp.mk (lisp): Update.
1732
2f38dff7
PE
17332012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1734
1735 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1736 It is never used otherwise.
1737
4ae29f89
SM
17382012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1739
1740 * print.c (print_preprocess): Only check print_depth if print-circle
1741 is nil.
1742 (print_object): Check for cycles even when print-circle is nil and
1743 print-gensym is t, but only check print_depth if print-circle is nil.
1744
f30d612a
CY
17452012-04-20 Chong Yidong <cyd@gnu.org>
1746
1747 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1748 set the status to "failed" and ensure that sentinel is run.
1749
c07a4c0b 17502012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1751
1752 * process.c (Fset_process_inherit_coding_system_flag)
1753 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1754 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1755
c07a4c0b 17562012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1757
1758 * xdisp.c (string_buffer_position_lim): Limit starting position to
1759 BEGV.
1760 (set_cursor_from_row): If called for a mode-line or header-line
1761 row, return zero immediately.
1762 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1763 farther than the first row after the header line, if any.
1764 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1765 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1766
c07a4c0b 17672012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1768
4ae29f89
SM
1769 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1770 (bug#11238).
ad3a2b41 1771
c07a4c0b 17722012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 17732012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1774
1775 configure: new option --enable-gcc-warnings (Bug#11207)
1776 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1777 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1778 (ALL_CFLAGS): Use new macros rather than old.
1779 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1780 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1781 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1782 -Wunused-result, -Wunused-variable. This should go away once
1783 the Emacs and Gnulib regex code is merged.
1784 (xmalloc, xrealloc): Now static.
1785
aba027e8
PE
17862012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1787
1788 * dired.c (Fsystem_groups): Remove unused local.
1789
e5a36063
GM
17902012-04-17 Glenn Morris <rgm@gnu.org>
1791
1792 * dired.c (Fsystem_users): Doc fix.
1793
316411f0
DA
17942012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1795
1796 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1797 (syms_of_dired): Add them.
1798
9426aba4
PE
17992012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1800
b62a57be
PE
1801 Fix minor alloc.c problems found by static checking.
1802 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1803 New extern decls, to avoid calling undeclared functions.
1804 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1805 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1806 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1807 (NEED_MEM_INSERT): New macro.
1808 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1809 Remove one incorrect comment and fix another.
b62a57be 1810
3539f31f
PE
1811 Fix minor ralloc.c problems found by static checking.
1812 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1813 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1814 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1815 (r_alloc_sbrk): Now static.
1816
a041960a
PE
1817 Improve ralloc.c interface checking.
1818 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1819 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1820 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1821 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1822 [REL_ALLOC]: ... to here, to check interface.
1823 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1824 Remove decls. This fixes an "It stinks!".
1825
9426aba4
PE
1826 * alloc.c (which_symbols): Fix alignment issue / type clash.
1827
d55c12ed
AS
18282012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1829
1830 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1831 (struct Lisp_Misc_Any): Likewise.
1832 (struct Lisp_Free): Likewise.
1833 * alloc.c (union aligned_Lisp_Symbol): Define.
1834 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1835 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1836 (union aligned_Lisp_Misc): Define.
1837 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1838 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1839 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1840
b948ce8b
PE
18412012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1842
1843 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1844 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1845 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1846 * s/netbsd.h, s/sol2-6.h:
1847 Remove definition of GC_MARK_STACK, since the default now works.
1848 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1849 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1850 no longer the default.
1851 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1852
35dc09a1 18532012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1854
35dc09a1
GM
1855 * lread.c (lisp_file_lexically_bound_p):
1856 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1857
35dc09a1
GM
18582012-04-14 Eli Zaretskii <eliz@gnu.org>
1859
1860 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1861 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1862
18632012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1864
1865 * nsterm.m (constrainFrameRect): Always constrain when there is only
1866 one screen (Bug#10962).
1867
bcd86815
KB
18682012-04-13 Ken Brown <kbrown@cornell.edu>
1869
1870 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1871
c25df26e
RT
18722012-04-13 Reuben Thomas <rrt@sc3d.org>
1873
1874 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1875
0fc59f1e
DC
18762012-04-11 Daniel Colascione <dancol@dancol.org>
1877
1878 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1879 against is gone. It's better to use vfork now so that when Cygwin
1880 gains a new, working vfork, we use it automatically (bug#10398).
1881
de8c03dc
SM
18822012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1883
1884 * window.c (save_window_save): Obey window-point-insertion-type.
1885
2f097256
GM
18862012-04-11 Glenn Morris <rgm@gnu.org>
1887
1888 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1889
453b951e
SM
18902012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1891
1892 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1893
75f1671a 18942012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1895
1896 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1897 (force_quit_count): New var.
1898 (handle_interrupt): Use it.
1899
2a8ce227
JB
19002012-04-10 Juanma Barranquero <lekktu@gmail.com>
1901
1902 * w32.c (w32_delayed_load): Record the full path of the library
1903 being loaded (bug#10424).
1904
935396c0
GM
19052012-04-09 Glenn Morris <rgm@gnu.org>
1906
05920a43
GM
1907 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1908 not just in the obarray, before snarfing them. (Bug#11036)
1909
935396c0
GM
1910 * Makefile.in ($(leimdir)/leim-list.el):
1911 Pass EMACS rather than BUILT_EMACS.
1912
a18ecafa
TZ
19132012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1914
1915 * process.c (make_process):
1916 * process.h: Add integer `gnutls_handshakes_tried' member to
1917 process struct.
1918
6bbef4e5
JC
1919 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1920 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1921
1922 * gnutls.c (gnutls_log_function2i): Convenience log function.
1923 (emacs_gnutls_read): Use new log functions,
1924 `gnutls_handshakes_tried' process member, and
1925 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1926 attempts per process (connection).
1927
b4d3bc10
CY
19282012-04-09 Chong Yidong <cyd@gnu.org>
1929
1930 * eval.c (Fuser_variable_p, user_variable_p_eh)
1931 (lisp_indirect_variable): Functions deleted.
1932 (Fdefvar): Caller changed.
1933
1934 * callint.c (Finteractive, Fcall_interactively):
1935 * minibuf.c (Fread_variable): Callers changed.
1936
70f4d973
EZ
19372012-04-09 Eli Zaretskii <eliz@gnu.org>
1938
1939 * xdisp.c (set_cursor_from_row): If the display string appears in
1940 the buffer at position that is closer to point than the position
1941 after the display string, display the cursor on the first glyph of
1942 the display string. Fixes cursor display when a 'display' text
1943 property immediately follows invisible text. (Bug#11094)
1944
cb3c2e3e
PE
19452012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 composite.c: use 'double' consistently
1948 * composite.c (get_composition_id): Use 'double' consistently
1949 instead of converting 'float' to 'double' and vice versa; this is
1950 easier to understand and avoids a GCC warning.
1951
fd06db5d
GM
19522012-04-09 Glenn Morris <rgm@gnu.org>
1953
50fe702a
GM
1954 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1955 preparation for dumping it with emacs. (Bug#4789)
1956 (leimdir): New variable.
1957 ($(leimdir)/leim-list.el): New rule.
1958 (emacs$(EXEEXT)): Depend on leim-list.el.
1959
fd06db5d
GM
1960 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1961 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1962 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1963
55c131ee
AS
19642012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1965
1966 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1967 proper alignment.
1968
9209588f
JB
19692012-04-07 Juanma Barranquero <lekktu@gmail.com>
1970
1971 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1972 Remove unused local variable.
1973
e3fb2efb
PE
19742012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1975
1976 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1977 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1978 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1979 objects, as mark_maybe_pointer will catch them otherwise.
1980 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1981 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1982
b5385551
PE
19832012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1984
1985 Fix typo that broke non-Windows builds.
1986 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1987
9078ead6
EZ
19882012-04-07 Eli Zaretskii <eliz@gnu.org>
1989
1990 Support building on MS-Windows with libxml2.
1991
1992 * makefile.w32-in (OBJ2): Add xml.$(O).
1993 (GLOBAL_SOURCES): Add xml.c.
1994 ($(BLD)/xml.$(O)): New dependency list.
1995
1996 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1997 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1998 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1999 [!WINDOWSNT]: New macros.
2000 (init_libxml2_functions, libxml2_loaded_p): New functions.
2001 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2002 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2003 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2004 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2005 linked in).
6bbef4e5
JC
2006 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2007 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2008 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2009
2010 * emacs.c: Don't include libxml/parser.h.
2011 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2012 xmlCleanupParser directly.
2013
2014 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2015
3811fdf3
EZ
20162012-04-07 Eli Zaretskii <eliz@gnu.org>
2017
2018 * indent.c (Fvertical_motion): If there is a display string at
2019 point, use it.vpos to compute how many lines to backtrack after
2020 move_it_to point. (Bug#11133)
2021
2f8e16b2
EZ
20222012-04-06 Eli Zaretskii <eliz@gnu.org>
2023
2024 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2025 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2026 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2027 macros related to unification of CJK characters. For the details,
2028 see the discussion following the message here:
2029 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2030
3d439cd1
CY
20312012-04-04 Chong Yidong <cyd@gnu.org>
2032
2033 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2034
8bc53d00
EZ
20352012-04-01 Eli Zaretskii <eliz@gnu.org>
2036
2037 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2038 instead of alloca. (Bug#11138)
2039
3b0512a3
AS
20402012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2041
2042 * w32menu.c (is_simple_dialog): Properly check lisp types.
2043 (Bug#11141)
2044
8427ddd2
EZ
20452012-03-31 Eli Zaretskii <eliz@gnu.org>
2046
979022ef
EZ
2047 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2048 position we get to after a call to move_it_to fails the
2049 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2050 only if we wind up in a string from display property. (Bug#11063)
2051
a6b1c7cc
EZ
2052 * window.c (Fdelete_other_windows_internal): Invalidate the row
2053 and column information about mouse highlight, so that redisplay
2054 restores it after reallocating the glyph matrices. (Bug#7464)
2055
8427ddd2
EZ
2056 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2057 string comes from a `display' text property, use the buffer
2058 position of that property as if we actually saw that position in
2059 the row's glyphs.
697ba24b
EZ
2060 (move_it_by_lines): Remove the assertion that
2061 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2062 violated when there's a before-string at the beginning of a line.
2063 (Bug#11063)
8427ddd2 2064
65a0a738
EZ
20652012-03-30 Eli Zaretskii <eliz@gnu.org>
2066
2067 * xdisp.c (append_space_for_newline): If the default face was
2068 remapped, use the remapped face for the appended newline.
2069 (extend_face_to_end_of_line): Use the remapped default face for
2070 extending the face to the end of the line.
2071 (display_line): Call extend_face_to_end_of_line when the default
2072 face was remapped. (Bug#11068)
2073
581355cc
EZ
20742012-03-29 Eli Zaretskii <eliz@gnu.org>
2075
2076 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2077
e8fc049f
SM
20782012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2079
2080 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2081
4fb9a543
GM
20822012-03-27 Glenn Morris <rgm@gnu.org>
2083
2084 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2085 Doc fixes.
2086
679910f1
KH
20872012-03-26 Kenichi Handa <handa@m17n.org>
2088
2089 * dispextern.h (struct glyph): Fix previous change. Change the
2090 bit length of glyphless.ch to 25 (Bug#11082).
2091
90d49b7f
CY
20922012-03-26 Chong Yidong <cyd@gnu.org>
2093
2094 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2095 (command_loop_1): Use it; inhibit selection update for
2096 handle-select-window too (Bug#8996).
2097
f514f6f0
FP
20982012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2099
e8fc049f 2100 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2101
bf43fa51
KH
21022012-03-25 Kenichi Handa <handa@m17n.org>
2103
2104 * dispextern.h (struct glyph): Change the bit length of
2105 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2106
8a0c01dd
EZ
21072012-03-24 Eli Zaretskii <eliz@gnu.org>
2108
2109 * s/ms-w32.h (tzname): Include time.h before redirecting to
2110 _tzname. Fixes the MSVC build. (Bug#9960)
2111
7d1c3a76
AS
21122012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2113
8ed79523
AS
2114 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2115 characters.
2116
7d1c3a76
AS
2117 * xterm.c (XTread_socket): Only modify handling_signal if
2118 !SYNC_INPUT. (Bug#11080)
2119
e99a9b8b
EZ
21202012-03-23 Eli Zaretskii <eliz@gnu.org>
2121
2122 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2123 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2124 when fetching a multibyte character consumes more bytes than
2125 CHAR_BYTES returns, due to unification of CJK characters in
2126 string_char. (Bug#11073)
2127
5063c0e1
TN
21282012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2129
2130 * process.c (wait_reading_process_output): Handle pty disconnect
2131 by refraining from sending oneself a SIGCHLD (bug#10933).
2132
9f851fbd
CY
21332012-03-22 Chong Yidong <cyd@gnu.org>
2134
2135 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2136
5063c0e1 2137 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2138 Mark string as coming from a prefix property.
2139 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2140 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2141
fb5b8aca
CY
21422012-03-21 Chong Yidong <cyd@gnu.org>
2143
2144 * xfaces.c (Vface_remapping_alist): Doc fix.
2145
62356a1b
EZ
21462012-03-20 Eli Zaretskii <eliz@gnu.org>
2147
2148 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2149 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2150 Doc fixes.
62356a1b 2151
025de85b
CY
21522012-03-20 Chong Yidong <cyd@gnu.org>
2153
2154 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2155 to reflect default non-nil value of redisplay-dont-pause.
2156
4827f94e
KH
21572012-03-19 Kenichi Handa <handa@m17n.org>
2158
2159 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2160 it fit in a valid range (Bug#11003).
2161
e50a24a2
EZ
21622012-03-18 Eli Zaretskii <eliz@gnu.org>
2163
2164 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2165 that is not from display property, accept the row as a "cursor
2166 row" if one of the string's character has a non-nil `cursor'
2167 property. Fixes cursor positioning when there are newlines in
2168 overlay strings, e.g. in icomplete.el. (Bug#11035)
2169
9af5ed87
PE
21702012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2171
2172 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2173
d1f55f16
CY
21742012-03-12 Chong Yidong <cyd@gnu.org>
2175
2176 * eval.c (inhibit_lisp_code): Rename from
2177 inhibit_window_configuration_change_hook; move from window.c.
2178
2179 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2180 * window.c (run_window_configuration_change_hook)
2181 (syms_of_window): Callers changed.
2182
66c5eebd
CY
21832012-03-11 Chong Yidong <cyd@gnu.org>
2184
413df973
CY
2185 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2186
66c5eebd
CY
2187 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2188
1de11f56
CY
21892012-03-10 Chong Yidong <cyd@gnu.org>
2190
2191 * frame.c (other_visible_frames): Don't assume the selected frame
2192 is visible (Bug#10955).
2193
cae07000
SM
21942012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2195
2196 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2197
89c94350
JD
21982012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2199
2200 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2201 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2202 zero (Bug#10954).
2203
999dd333
GM
22042012-03-03 Glenn Morris <rgm@gnu.org>
2205
01a6dcc8 2206 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2207
de0100f2
EZ
22082012-03-02 Eli Zaretskii <eliz@gnu.org>
2209
2210 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2211 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2212 (redisplay_window, next_element_from_string): Fix typos in
2213 comments.
3e441275
EZ
2214 (redisplay_window): Pass to move_it_vertically the margin in
2215 pixels, not in screen lines.
de0100f2 2216
96a72ee9
GM
22172012-03-02 Glenn Morris <rgm@gnu.org>
2218
2219 * buffer.c (buffer-list-update-hook): Doc fix.
2220
312508d7
EZ
22212012-02-29 Eli Zaretskii <eliz@gnu.org>
2222
2223 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2224 push_it before setting up the iterator for the first overlay
2225 string, even if we have an empty string loaded.
2226 (next_overlay_string): If there's an empty string on the iterator
2227 stack, pop the stack. (Bug#10903)
2228
27f3c637
PE
22292012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2232 Suggested by Stefan Monnier in
2233 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2234 * alloc.c (widen_to_Lisp_Object): New static function.
2235 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2236 and widening them to Lisp_Objects. This would work even if
2237 USE_LSB_TAG is defined and wide integers are used, which might
2238 happen in a future version of Emacs.
2239
3c9dfce6
CY
22402012-02-25 Chong Yidong <cyd@gnu.org>
2241
fa74b241
CY
2242 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2243 Doc fix.
2244
3c9dfce6
CY
2245 * xselect.c (Fx_selection_exists_p): Doc fix.
2246 (x_clipboard_manager_save_all): Print an informative message
2247 before saving to clipboard manager.
2248
9486df08
CY
22492012-02-24 Chong Yidong <cyd@gnu.org>
2250
2251 * keyboard.c (process_special_events): Handle all X selection
2252 requests in kbd_buffer, not just the next one (Bug#8869).
2253
f01d3321
CY
22542012-02-23 Chong Yidong <cyd@gnu.org>
2255
2256 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2257 call when setting menu-bar-lines and tool-bar-lines parameters.
2258 (unwind_create_frame_1): New helper function.
2259
2260 * window.c (inhibit_window_configuration_change_hook): New var.
2261 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2262 (syms_of_window): Initialize it.
f01d3321 2263
86b847b6
CY
22642012-02-22 Chong Yidong <cyd@gnu.org>
2265
2266 * xterm.c (x_draw_image_relief): Add missing type check for
2267 Vtool_bar_button_margin (Bug#10743).
2268
a59225b1
CY
22692012-02-21 Chong Yidong <cyd@gnu.org>
2270
2271 * fileio.c (Vfile_name_handler_alist): Doc fix.
2272
2273 * buffer.c (Fget_file_buffer): Protect against invalid file
2274 handler return value.
2275
310f5bd4
PE
22762012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2277
cb3a28cc
PE
2278 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2279 when computing $valmask.
2280
310f5bd4
PE
2281 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2282 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2283 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2284 It's useless in that case, and it can cause problems on hosts
2285 that allocate halves of EMACS_INT values separately.
2286 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2287 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2288 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2289 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2290 it avoids undefined behavior on hosts where shifting right by more
2291 than the word width has undefined behavior.
2292
2375c96a
CY
22932012-02-19 Chong Yidong <cyd@gnu.org>
2294
2295 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2296 (Funhandled_file_name_directory, Ffile_name_as_directory)
2297 (Fdirectory_file_name, Fexpand_file_name)
2298 (Fsubstitute_in_file_name): Protect against invalid file handler
2299 return values (Bug#10845).
2300
3eb49e71
EZ
23012012-02-18 Eli Zaretskii <eliz@gnu.org>
2302
2303 * .gdbinit (pitx): Fix incorrect references to fields of the
2304 iterator stack.
2305
7b926f3f
CY
23062012-02-17 Chong Yidong <cyd@gnu.org>
2307
2308 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2309
11273115
PE
23102012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2313 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2314
c3a70e2b
CY
23152012-02-15 Chong Yidong <cyd@gnu.org>
2316
2317 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2318 marked as special. Also, starting docstrings with * is obsolete.
2319
0ca43699
AS
23202012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2321
2322 * gnutls.c (emacs_gnutls_write): Fix last change.
2323
2e8f3c56
LI
23242012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2325
2326 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2327 send_process.
2328
af70074f
SM
23292012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2330
2331 * keymap.c (Fsingle_key_description): Handle char ranges.
2332
95986d52
CY
23332012-02-12 Chong Yidong <cyd@gnu.org>
2334
afd83bd1
CY
2335 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2336 as that creates a dangerous corner case.
2337
95986d52
CY
2338 * window.c (Fdelete_window_internal): Invalidate the mouse
2339 highlight (Bug#9904).
2340
bd7da63e
GM
23412012-02-12 Glenn Morris <rgm@gnu.org>
2342
2343 * xselect.c (Fx_own_selection_internal)
2344 (Fx_get_selection_internal, Fx_disown_selection_internal)
2345 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2346 * nsselect.m (Fx_own_selection_internal)
2347 (Fx_disown_selection_internal, Fx_selection_exists_p)
2348 (Fx_selection_owner_p, Fx_get_selection_internal):
2349 Sync docs and argument specs with the xselect.c versions.
2350
77abcbc2
LI
23512012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2352
2353 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2354
90b671e2
EZ
23552012-02-11 Eli Zaretskii <eliz@gnu.org>
2356
1c0ca0b7
EZ
2357 * w32select.c (Fx_selection_exists_p): Sync doc string and
2358 argument list with xselect.c. (Bug#10783)
2359
2360 * w16select.c (Fx_selection_exists_p): Sync doc string and
2361 argument list with xselect.c. (Bug#10783)
90b671e2 2362
49241268
GM
23632012-02-10 Glenn Morris <rgm@gnu.org>
2364
2365 * fns.c (Fsecure_hash): Doc fix.
2366
f998bbe7 23672012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2368
2369 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2370
0992bd9c
CY
23712012-02-07 Chong Yidong <cyd@gnu.org>
2372
2373 * buffer.c (Fbuffer_local_variables)
2374 (buffer_lisp_local_variables): Handle unbound vars correctly;
2375 don't let Qunbound leak into Lisp.
2376
af008560
GM
23772012-02-07 Glenn Morris <rgm@gnu.org>
2378
dd605cc4
GM
2379 * image.c (Fimagemagick_types): Doc fix.
2380
af008560
GM
2381 * image.c (imagemagick-render-type): Change it from a lisp object
2382 to an integer. Move the doc here from the lisp manual.
2383 Treat all values not equal to 0 the same.
2384
1449fa1d
CY
23852012-02-06 Chong Yidong <cyd@gnu.org>
2386
2387 * doc.c (store_function_docstring): Avoid applying docstring of
2388 alias to base function (Bug#2603).
2389
3723ec07
AS
23902012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2391
2392 * .gdbinit (pp1, pv1): Remove redundant defines.
2393 (pr): Use pp.
2394
79c1cc1e
CY
23952012-02-04 Chong Yidong <cyd@gnu.org>
2396
2397 * nsterm.m: Declare a global (Bug#10694).
2398
d7f29f8e
EZ
23992012-02-04 Eli Zaretskii <eliz@gnu.org>
2400
cae07000
SM
2401 * w32.c (get_emacs_configuration_options):
2402 Include --enable-checking, if specified, in the return value.
d7f29f8e 2403
3b95a6f9
MR
24042012-02-04 Martin Rudalics <rudalics@gmx.at>
2405
2406 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2407 after rounding frame sizes. (Bug#9723)
2408
d6fa96a6
EZ
24092012-02-04 Eli Zaretskii <eliz@gnu.org>
2410
2411 * keyboard.c (adjust_point_for_property): Don't position point
2412 before BEGV. (Bug#10696)
2413
df0b2940
PE
24142012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2415
2416 Handle overflow when computing char display width (Bug#9496).
2417 * character.c (char_width): Return EMACS_INT, not int.
2418 (char_width, c_string_width): Check for overflow when
2419 computing the width; this is possible now that individual
2420 characters can have unbounded width. Problem introduced
2421 by merge from Emacs 23 on 2012-01-19.
2422
6bee44d6
MA
24232012-02-02 Michael Albinus <michael.albinus@gmx.de>
2424
2425 * dbusbind.c (Fdbus_register_method): Mention the return value
2426 :ignore in the docstring.
2427
44f92739
GM
24282012-02-02 Glenn Morris <rgm@gnu.org>
2429
1b9f60cc
GM
2430 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2431
44f92739
GM
2432 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2433 Unconditionally set to t. (Bug#10673)
2434 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2435 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2436 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2437
c5d3843c
KH
24382012-02-02 Kenichi Handa <handa@m17n.org>
2439
2440 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2441 0, do not call append_composite_glyph.
2442
159462d4 24432012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2444
2445 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2446 NULL (Bug#6988).
2447 (x_produce_glyphs): If the component of a composition is a null
2448 string, set it->pixel_width to 1 to avoid zero-width glyph.
2449
78cef877
EZ
24502012-02-01 Eli Zaretskii <eliz@gnu.org>
2451
2452 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2453 first 2 arguments are identical. This makes inserting large
2454 output from a subprocess an order of magnitude faster on
2455 MS-Windows, where all sbrk'ed memory is always contiguous.
2456
97897668
GM
24572012-01-31 Glenn Morris <rgm@gnu.org>
2458
2459 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2460 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2461 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2462
31fd3586
GM
24632012-01-29 Glenn Morris <rgm@gnu.org>
2464
2465 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2466
0e24a8b2
CY
24672012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2468
2469 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2470
cc0adcb0
CY
24712012-01-28 Chong Yidong <cyd@gnu.org>
2472
2473 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2474
acc28cb9
CY
24752012-01-26 Chong Yidong <cyd@gnu.org>
2476
9c69cfb7
CY
2477 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2478
acc28cb9
CY
2479 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2480 repeat counts (Bug#10507).
2481
48da7392
GM
24822012-01-26 Glenn Morris <rgm@gnu.org>
2483
2484 * lread.c (syms_of_lread): Doc fix.
2485
14af5f7f
CY
24862012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2487
2488 * coding.c (encode_designation_at_bol): Change return value to
2489 EMACS_INT.
2490
0b21c100
CY
24912012-01-25 Chong Yidong <cyd@gnu.org>
2492
2493 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2494
3c2907f7
CY
24952012-01-21 Chong Yidong <cyd@gnu.org>
2496
2497 * floatfns.c (Fcopysign): Make the second argument non-optional,
2498 since nil is not allowed anyway.
2499
959ad23f
AS
25002012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2501
2502 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2503 (send_process): Likewise.
2504
34a02f46
MR
25052012-01-19 Martin Rudalics <rudalics@gmx.at>
2506
2507 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2508 (Vwindow_persistent_parameters): Do not use Qstate.
2509 Rewrite doc-strings.
34a02f46 2510
1259009a 25112012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2512
2513 * character.c (char_width): New function.
70d4fdf6
GM
2514 (Fchar_width, c_string_width, lisp_string_width):
2515 Use char_width (Bug#9496).
25ed9e61 2516
6a6ee00d
MR
25172012-01-16 Martin Rudalics <rudalics@gmx.at>
2518
2519 * window.c (Vwindow_persistent_parameters): New variable.
2520 (Fset_window_configuration, save_window_save): Handle persistent
2521 window parameters.
2522
c85efaf7
EZ
25232012-01-14 Eli Zaretskii <eliz@gnu.org>
2524
2525 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2526 thrashing the stack of the thread. (Bug#9087)
2527
5944709e
PE
25282012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2529
2530 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2531
e71f5d99
EZ
25322012-01-11 Eli Zaretskii <eliz@gnu.org>
2533
2534 * xdisp.c (rows_from_pos_range): Handle the case where the
2535 highlight ends on a newline. (Bug#10464)
2536 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2537 he end column for display of highlight that ends on a newline
2538 before a R2L line.
2539
ce316182
GM
25402012-01-11 Glenn Morris <rgm@gnu.org>
2541
2542 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2543 from load-path also when installation-directory is nil. (Bug#10208)
2544
5b43da69
GM
25452012-01-10 Glenn Morris <rgm@gnu.org>
2546
74cc8ff9
GM
2547 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2548
7d8d6e4e
GM
2549 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2550 Update template values to be closer to their typical values these days.
5b43da69 2551
a0db8d43
EZ
25522012-01-09 Eli Zaretskii <eliz@gnu.org>
2553
2554 * xdisp.c (rows_from_pos_range): Accept additional argument
2555 DISP_STRING, and accept any glyph in a row whose object is that
2556 string as eligible for mouse highlight. Fixes mouse highlight of
2557 display strings from overlays. (Bug#10464)
2558
9a0115ab 25592012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2560
b9110d6a 2561 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2562 * fileio.c (auto_saving_dir_umask): New static var.
2563 (Fmake_directory_internal): Use it.
2564 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2565 creating the directory. The old code temporarily assigns
2566 too-generous permissions to the directory.
2567 (do_auto_save_eh): Clear it.
b9110d6a 2568 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2569 that the var is always cleared.
2570
6c1bd3f3
EZ
25712012-01-07 Eli Zaretskii <eliz@gnu.org>
2572
2573 * search.c (scan_buffer): Pass character positions to
2574 know_region_cache, not byte positions. (Bug#6540)
2575
069d2b50
L
25762012-01-07 LynX <_LynX@bk.ru> (tiny change)
2577
2578 * w32.c (sys_rename): Report EXDEV when rename of a directory
2579 fails because the target is on another logical disk. (Bug#10284)
2580
75bf0d33
DB
25812012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2582
2583 * xterm.c (x_embed_request_focus): New function.
2584
2585 * xterm.h: Add prototype.
2586
2587 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2588
1c6e5a32
GM
25892012-01-05 Glenn Morris <rgm@gnu.org>
2590
2591 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2592
651e947e
EZ
25932012-01-01 Eli Zaretskii <eliz@gnu.org>
2594
2595 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2596 Load gnutls_transport_set_lowat only if GnuTLS version is below
2597 2.11.1.
2598 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2599 GnuTLS versions below 2.11.1.
2600
3778cdd8
AL
26012011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2602
2603 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2604 to the doc string advising against its use for altering the way
2605 windows are scrolled.
2606
0e5317f7
KH
26072011-12-28 Kenichi Handa <handa@m17n.org>
2608
2609 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2610 coding-system ASCII compatible only when it does not produce BOM
2611 on encoding (Bug#10383).
2612
93d5ca1f
JD
26132011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2614
2615 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2616 can scroll.
2617 (create_and_show_popup_menu): Always use menu_position_func for
2618 Gtk3 (Bug#10361).
2619
ca22b785
AS
26202011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2621
2622 * callint.c (Fcall_interactively): Don't truncate prompt string.
2623
d048e1e6
EZ
26242011-12-23 Eli Zaretskii <eliz@gnu.org>
2625
2626 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2627 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2628 resumed from there (after widening). (Bug#10360)
d048e1e6 2629
5ccaba1f
JD
26302011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2631
2632 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2633
204ee57f
JD
26342011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2635
b81d40f0
JB
2636 * nsterm.m (x_free_frame_resources):
2637 Release f->output_data.ns->miniimage.
204ee57f
JD
2638 (ns_index_color): Fix indentation. Do not retain
2639 color_table->colors[i].
2640
2641 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2642 before returning.
2643
2644 * nsfns.m (x_set_background_color): Assign return value from
2645 ns_index_color to face-background instead of NSColor*.
2646 (ns_implicitly_set_icon_type): Fix indentation.
2647 Change assignment in for loop to comparison.
2648
2649 * emacs.c (ns_pool): New variable.
2650 (main): Assign ns_pool.
2651 (Fkill_emacs): Call ns_release_autorelease_pool.
2652
2653 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2654 autorelease fdesc, release fdAttrs and tdict.
2655 (ns_get_covering_families): Release charset.
2656 (ns_findfonts): Release NSFontDescriptor created with new.
2657 (ns_uni_to_glyphs): Fix indentation.
2658 (setString): Release attrStr before assigning new value.
2659
c803b2b7
JD
26602011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2661
678f4426
JD
2662 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2663 and NS_IMPL_COCOA.
2664 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2665 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2666
cd394be1 26672011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2668
5fecd5fc
JD
2669 * nsterm.m (ns_term_init): Subscribe for notifications
2670 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2671 to method trackingNotification in EmacsMenu.
2672
2673 * nsmenu.m (trackingMenu): New variable.
3771cb17 2674 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2675 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2676 from Aquamacs (Bug#7030).
678f4426
JD
2677
26782011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2679
c803b2b7
JD
2680 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2681 (symbol_to_nsstring): Fix indentation.
2682 (ns_symbol_to_pb): New function.
cae07000
SM
2683 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2684 (Fns_rotate_cut_buffers_internal): Remove.
2685 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2686 Fns_store_cut_buffer_internal.
2687 (ns_get_foreign_selection, Fx_own_selection_internal)
2688 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2689 (Fns_get_selection_internal, Fns_store_selection_internal):
2690 Use ns_symbol_to_pb and check if return value is nil.
2691 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2692 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2693 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2694 renamed to Sns_store_selection_internal.
2695 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2696 and remove this function.
2697 (ns_handle_selection_clear): Remove, never used.
2698 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2699 here.
2700
e1b01a3a
KB
27012011-12-17 Ken Brown <kbrown@cornell.edu>
2702
2703 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2704 GID is unknown (Bug#10257).
2705
2adb6e85
PE
27062011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2707
2708 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2709 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2710 which caused a build failure on GNU/Linux IA-64. This problem was
2711 introduced by my 2011-10-07 patch.
2712
d1d7b339
JL
27132011-12-15 Juri Linkov <juri@jurta.org>
2714
2715 * image.c (imagemagick_error): New function. (Bug#10112)
2716 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2717 Use `imagemagick_error' where ImageMagick functions return
2718 `MagickFalse'.
2719 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2720 proper order.
2721
100d5755
KH
27222011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2723
2724 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2725 fill background (Bug#8992).
2726
454592a6
MR
27272011-12-13 Martin Rudalics <rudalics@gmx.at>
2728
2729 * window.c (Vwindow_combination_resize)
2730 (Vwindow_combination_limit): Use t instead of non-nil in
2731 doc-strings.
61d4b438
MR
2732 (Vrecenter_redisplay): Add first sentence of doc-string on
2733 separate line.
53524d93 2734 (Frecenter): Fix doc-string typo.
454592a6 2735
3633e3aa
KH
27362011-12-11 Kenichi Handa <handa@m17n.org>
2737
2738 * coding.c (Funencodable_char_position): Pay attention to the
2739 buffer text relocation (Bug#9389).
2740
7b9d523a 27412011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2742
7b9d523a
JD
2743 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2744 gtk_init (Bug#10100).
2745
b73189c6
EZ
27462011-12-10 Eli Zaretskii <eliz@gnu.org>
2747
2748 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2749 IT->string is nil. (Bug#10263)
2750
f7dfe5d6
JD
27512011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2752
83faebb4
JD
2753 * nsterm.h (x_free_frame_resources): Declare.
2754
f7dfe5d6
JD
2755 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2756 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2757
2758 * nsterm.h (ns_get_defaults_value): Declare.
2759
2760 * nsterm.m (ns_default): Call ns_get_defaults_value.
2761
7cd4e72c
EZ
27622011-12-09 Eli Zaretskii <eliz@gnu.org>
2763
2764 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2765 (Bug#10170)
2766
b34d7317
YM
27672011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2768
2769 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2770 that where the value of an _OBJC_* symbol points to is in the .bss
2771 section (Bug#10240).
2772
76470ad1
KH
27732011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2774
2775 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2776 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2777
745fff94
KH
27782011-12-08 Kenichi Handa <handa@m17n.org>
2779
2780 * ftfont.c (get_adstyle_property): Fix previous change
2781 (Bug#10233).
2782
6e44397c
JB
27832011-12-07 Juanma Barranquero <lekktu@gmail.com>
2784
2785 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2786 dirs from the default value of EMACSLOADPATH (bug#10208).
2787
7efa6272
GM
27882011-12-07 Glenn Morris <rgm@gnu.org>
2789
2790 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2791 installation and source directories as well. (Bug#10208)
2792
f6fc4d87
CY
27932011-12-06 Chong Yidong <cyd@gnu.org>
2794
2795 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2796
2bf26180
GM
27972011-12-06 Glenn Morris <rgm@gnu.org>
2798
2799 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2800 as an error, not just -1. (Bug#10217)
2801
3a6ad4f0
CY
28022011-12-05 Chong Yidong <cyd@gnu.org>
2803
2804 * keyboard.c (process_special_events): New function.
2805 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2806
75a3b399
PE
28072011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2808
2809 * coding.c (encode_designation_at_bol): Don't use uninitialized
2810 local variable (Bug#9318).
2811
c3c9e25e
KH
28122011-12-05 Kenichi Handa <handa@m17n.org>
2813
2814 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2815 return Qnil (Bug#8046, Bug#10193).
2816
5eb05ea3
KH
28172011-12-05 Kenichi Handa <handa@m17n.org>
2818
2819 * coding.c (encode_designation_at_bol): New args charbuf_end and
2820 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2821 (coding_set_source): Return how many bytes coding->source was
2822 relocated.
2823 (coding_set_destination): Return how many bytes
2824 coding->destination was relocated.
2825 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2826 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2827
28282011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2829
2830 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2831 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2832 macro (Bug#9318).
2833
28342011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2835
2836 The following changes are to fix Bug#9318.
2837
a79703f5 2838 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2839 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2840 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2841 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2842
7dbda6df
JB
28432011-12-05 Juanma Barranquero <lekktu@gmail.com>
2844
2845 * lisp.h (process_quit_flag): Fix external declaration.
2846
6d5eb5b0
SM
28472011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2848
2849 Don't macro-inline non-performance-critical code.
2850 * eval.c (process_quit_flag): New function.
2851 * lisp.h (QUIT): Use it.
2852
a0c3fad0
JD
28532011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2854
2855 * nsfns.m (get_geometry_from_preferences): New function.
2856 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2857
6c07aac2
AS
28582011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2859
2860 * emacs.c (Qkill_emacs): Define.
2861 (syms_of_emacs): Initialize it.
2862 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2863 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2864 (quit_throw_to_read_char): Add parameter `from_signal'.
2865 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2866 * lisp.h (QUIT): Call Fkill_emacs if requested.
2867
c052ead4
JD
28682011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2869
2870 * widget.c (update_wm_hints): Return if wmshell is null.
2871 (widget_update_wm_size_hints): New function.
2872
2873 * widget.h (widget_update_wm_size_hints): Declare.
2874
2875 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2876 widget_update_wm_size_hints (Bug#10104).
2877
9e49252b
EZ
28782011-12-03 Eli Zaretskii <eliz@gnu.org>
2879
2880 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2881 before a newline, prepare the bidi iterator for consuming the
2882 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2883 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2884
02b16839
JL
28852011-12-02 Juri Linkov <juri@jurta.org>
2886
2887 * search.c (Fword_search_regexp): New Lisp function created from
2888 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2889 (Fword_search_backward, Fword_search_forward)
2890 (Fword_search_backward_lax, Fword_search_forward_lax):
2891 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2892 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2893
0068070e
SM
28942011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2895
2896 * fileio.c (Finsert_file_contents): Move after-change-function call
2897 to before the "handled:" label, since all "goto handled" appear in
2898 cases where the *-change-functions have already been properly called
2899 (bug#10117).
2900
3360a3fc
AS
29012011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2902
2903 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2904 waiting for input. (Bug#10169)
2905
73d6c093
EZ
29062011-11-30 Eli Zaretskii <eliz@gnu.org>
2907
2908 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2909 verifies glyph row's hash code--we have just reallocated the
2910 glyphs, so their contents can be complete garbage. (Bug#10164)
2911
febe6bea
JB
29122011-11-30 Juanma Barranquero <lekktu@gmail.com>
2913
2914 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2915
801a4313
EZ
29162011-11-30 Eli Zaretskii <eliz@gnu.org>
2917
2918 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2919 attributes are tested _before_ calling verify_row_hash, to protect
2920 against GCC re-ordering of the tests. (Bug#10164)
2921
2b56b87e
JD
29222011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2923
2924 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2925
2926 * xterm.c (handle_one_xevent): Only set async_visible and friends
2927 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2928 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2929 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2930
dbf31225
PE
29312011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2932
2933 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2934 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2935 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2936 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2937 All uses changed to use GCPRO1 etc.
2938 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2939 Revert to old implementation (i.e., before 2011-03-11).
2940
1305621b
YM
29412011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2942
2943 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2944 of scroll runs so as to avoid assigning disabled bogus rows and
2945 unnecessary graphics copy operations.
2946
8c9afb46
EZ
29472011-11-27 Eli Zaretskii <eliz@gnu.org>
2948
2949 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2950 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2951 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2952 (malloc, free, realloc, calloc): Redirect to e_* only when
2953 compiling Emacs.
2954
2955 * lisp.h (GCTYPEBITS): Move before first use.
2956 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2957 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2958 this macro definition.
2959
2960 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2961 _MSC_VER.
2962
54e9e3bf
JD
29632011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2964
6d5eb5b0
SM
2965 * gtkutil.c (xg_create_frame_widgets):
2966 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2967 present with Gtk+ 2.0.
2968
83aca1cb
PE
29692011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2970
2971 * fileio.c (Finsert_file_contents): Undo previous change; see
2972 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2973
5b76caa4
PE
29742011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 Rename locals to avoid shadowing.
2977 * fileio.c (Finsert_file_contents):
2978 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2979 * process.c (wait_reading_process_output):
2980 Rename inner 'proc' to 'p' to avoid shadowing.
2981 Indent for consistency with usual Emacs style.
2982
8c535114
EZ
29832011-11-25 Eli Zaretskii <eliz@gnu.org>
2984
2985 * xdisp.c (redisplay_window): If cursor row is not fully visible
2986 after recentering, and scroll-conservatively is set to a large
2987 number, scroll window by a few more lines to make the cursor fully
2988 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2989 (start_display): Don't move to the next line if the display should
2990 start at a newline that is part of a display vector or an overlay
2991 string. (Bug#10119)
8c535114 2992
fa4fdb5c
JL
29932011-11-24 Juri Linkov <juri@jurta.org>
2994
2995 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2996 after the `MagickPingImage' call. (Bug#10112)
2997
90ec88df
CY
29982011-11-23 Chong Yidong <cyd@gnu.org>
2999
3000 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3001
56e2e794
MR
30022011-11-23 Martin Rudalics <rudalics@gmx.at>
3003
3004 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3005 making another buffer current. (Bug#10114)
3006
b6e64c41
GM
30072011-11-23 Glenn Morris <rgm@gnu.org>
3008
3009 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3010
6b21de18
CY
30112011-11-23 Chong Yidong <cyd@gnu.org>
3012
3013 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3014 using it (Bug#5984).
3015
b12cd789
EZ
30162011-11-22 Eli Zaretskii <eliz@gnu.org>
3017
3018 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3019 and header-lines, as they don't have one computed for them.
3020 (Bug#10098)
3021
3022 * .gdbinit (prow): Make displayed values more self-explaining.
3023 Add row's hash code.
3024
261b6fd4
LMI
30252011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3026
3027 * process.c (wait_reading_process_output): Fix asynchrounous
3028 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3029 (wait_reading_process_output): Add comment and URL.
261b6fd4 3030
e7cfd277
JD
30312011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3032
3033 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3034
a9b9b7f5
CY
30352011-11-21 Chong Yidong <cyd@gnu.org>
3036
3037 * window.c (Fnext_window, Fprevious_window): Doc fix.
3038
b0d15b4f
SM
30392011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3040
3041 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3042
fe7a3057
JB
30432011-11-20 Juanma Barranquero <lekktu@gmail.com>
3044
3045 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3046
d2999b1a
MR
30472011-11-20 Martin Rudalics <rudalics@gmx.at>
3048
3049 * window.c (Fset_window_combination_limit): Rename argument
3050 STATUS to LIMIT.
3051 (Vwindow_combination_limit): Remove "status" from doc-string.
3052
d5ff9cd0
AS
30532011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3054
3055 * m/ibms390.h: Remove.
3056 * m/ibms390x.h: Don't include "ibms390.h".
3057
a5bb9bd3
SM
30582011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3059
3060 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3061 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3062
cd1181db
JB
30632011-11-20 Juanma Barranquero <lekktu@gmail.com>
3064
3065 * casetab.c (Fset_case_table):
3066 * charset.c (Fcharset_after): Fix typos.
3067
615a3b8d 30682011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3069
17e845af
PE
3070 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3071 Otherwise, valgrind does not work on some platforms.
3072 Problem reported by Andreas Schwab in
6a0bf43d
PE
3073 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3074 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3075 is set, removing the need for VIRT_ADDRESS_VARIES.
3076 (PURE_P): Use a more-efficient implementation that needs just one
3077 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3078 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3079 to 4 (xorl, subq, cmpq, setbe).
3080 * alloc.c (pure): Always extern now, since that's the
3081 VIRT_ADDR_VARIES behavior.
3082 (PURE_POINTER_P): Use a single comparison, not two, for
3083 consistency with the new puresize.h.
3084 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3085 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3086 Remove VIRT_ADDR_VARIES no longer needed.
3087
f8fe6f96
EZ
30882011-11-19 Eli Zaretskii <eliz@gnu.org>
3089
3090 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3091 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3092 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3093 behave as if the cursor position were at the window margin.
3094
3095 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3096 and the cursor position is out of bounds, behave as if the cursor
3097 position were at the window margin. (Bug#10075)
3098
df05a53c
CY
30992011-11-18 Chong Yidong <cyd@gnu.org>
3100
3101 * window.c (Fwindow_combination_limit): Make first argument
3102 non-optional, since it is meaningless for live windows like the
3103 selected window.
61ccba97 3104
2071918e
DA
31052011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3106
3107 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3108
b50a28de
SM
31092011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3110
3111 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3112 (graft_intervals_into_buffer): Simplify.
3113
015137db
EZ
31142011-11-18 Eli Zaretskii <eliz@gnu.org>
3115
3116 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3117 hash values of the two rows.
3118 (copy_row_except_pointers): Preserve the used[] arrays and the
3119 hash values of the two rows. (Bug#10035)
68c95424 3120 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3121
3122 * xdisp.c (row_hash): New function, body extracted from
3123 compute_line_metrics.
3124 (compute_line_metrics): Call row_hash, instead of computing the
3125 hash code inline.
3126
3127 * dispnew.c (verify_row_hash): Call row_hash for computing the
3128 hash code of a row, instead of duplicating code from xdisp.c.
3129
3130 * dispextern.h (row_hash): Add prototype.
3131
a2addb04
TH
31322011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3133
3134 * frame.c (delete_frame): Don't delete the terminal when the last
3135 X frame is closed if emacs is built with GTK toolkit.
3136
df85d315
JB
31372011-11-17 Juanma Barranquero <lekktu@gmail.com>
3138
3139 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3140
a0c2d0ae
MR
31412011-11-17 Martin Rudalics <rudalics@gmx.at>
3142
3143 * window.c (Vwindow_splits): Rename to
3144 Vwindow_combination_resize. Suggested by Juri Linkov.
3145 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3146 of Vwindow_splits.
3147
58179cce
JB
31482011-11-16 Juanma Barranquero <lekktu@gmail.com>
3149
7877f373
JB
3150 * nsfns.m (Fns_font_name):
3151 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3152
b6f67890
MR
31532011-11-16 Martin Rudalics <rudalics@gmx.at>
3154
3155 * window.h (window): Rename slot "nest" to "combination_limit".
3156 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3157 (Fset_window_nest): Rename to Fset_window_combination_limit.
3158 (Vwindow_nest): Rename to Vwindow_combination_limit.
3159 (recombine_windows, make_parent_window, make_window)
3160 (Fsplit_window_internal, saved_window)
3161 (Fset_window_configuration, save_window_save): Rename all
3162 occurrences of window_nest to window_combination_limit.
3163
c7015153
JB
31642011-11-15 Juanma Barranquero <lekktu@gmail.com>
3165
3166 * image.c (imagemagick_load_image): Fix typo.
3167
322ad6ec
EZ
31682011-11-14 Eli Zaretskii <eliz@gnu.org>
3169
3170 * xdisp.c (display_line): Move the call to
3171 highlight_trailing_whitespace before the call to
3172 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3173 faces of all the glyphs to compute ROW's hash value.
3174 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3175
f067b8ec
JB
31762011-11-14 Juanma Barranquero <lekktu@gmail.com>
3177
3178 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3179 just return (bug#10044).
3180
1e5b2111
EZ
31812011-11-12 Eli Zaretskii <eliz@gnu.org>
3182
7ef3cbd5
EZ
3183 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3184 with user-defined heap size. Bump the default size of the temacs
3185 heap to 27MB, to avoid memory warning when running temacs.
3186 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3187
1e5b2111
EZ
3188 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3189 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3190 (verify_row_hash) [XASSERTS]: New function.
3191 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3192 that the hash value of glyph rows is correct.
1e5b2111 3193
89d61221
MR
31942011-11-12 Martin Rudalics <rudalics@gmx.at>
3195
3196 * window.h (window): Remove splits slot.
3197 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3198 (Fdelete_other_windows_internal, make_parent_window)
3199 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3200 (Fset_window_configuration, save_window_save): Don't deal with
3201 split status of windows.
3202 (saved_window): Remove splits slot.
3203 (Vwindow_splits): Rewrite doc-string.
3204
97f18cc8
JD
32052011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3206
3207 * xfns.c (unwind_create_frame):
3208 * nsfns.m (unwind_create_frame):
3209 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3210 Vframe_list (Bug#9999).
3211
22a648b4
DA
32122011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3213
0b381c7e 3214 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3215
659afede
KH
32162011-11-11 Kenichi Handa <handa@m17n.org>
3217
3218 * callproc.c (Fcall_process): Set the member dst_multibyte of
3219 process_coding.
3220
9ac0394b
KH
32212011-11-11 Johan Bockgård <bojohan@gnu.org>
3222
3223 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3224 avoid a crash (bug#9496).
3225
2fbdc249
CY
32262011-11-09 Chong Yidong <cyd@gnu.org>
3227
3228 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3229 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3230
ac6b1f81
PE
32312011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3232
3233 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3234
09db192c
PE
32352011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3236
3237 Avoid some portability problems by eschewing 'extern inline' functions.
3238 The trivial performance wins aren't worth the portability hassles; see
3239 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3240 et seq.
3241 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3242 (window_box_width, window_box_left, window_box_left_offset)
3243 (window_box_right, window_box_right_offset): Undo previous change,
3244 by removing the "extern"s.
3245 * intervals.c (adjust_intervals_for_insertion)
3246 (adjust_intervals_for_deletion): Undo previous change,
3247 making these static again.
3248 (offset_intervals, temp_set_point_both, temp_set_point)
3249 (copy_intervals_to_string): No longer inline.
3250 * xdisp.c (window_text_bottom_y, window_box_width)
3251 (window_box_height, window_box_left_offset)
3252 (window_box_right_offset, window_box_left, window_box_right)
3253 (window_box): No longer inline.
3254
105216ed
CY
32552011-11-08 Chong Yidong <cyd@gnu.org>
3256
3257 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3258 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3259 Signal an error if not a live window.
105216ed
CY
3260 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3261 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3262
ae9e237f
JB
32632011-11-07 Juanma Barranquero <lekktu@gmail.com>
3264
3265 * lisp.h (syms_of_abbrev): Remove declaration.
3266 Reported by CHENG Gao <chenggao@royau.me>.
3267
c7aa8333
EZ
32682011-11-07 Eli Zaretskii <eliz@gnu.org>
3269
3270 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3271 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3272 of temacs in GUI mode.
3273
be7f5545
MR
32742011-11-07 Martin Rudalics <rudalics@gmx.at>
3275
3276 * window.h: Declare delete_all_child_windows instead of
3277 delete_all_subwindows.
3278 * window.c (Fwindow_nest, Fset_window_nest)
3279 (Fset_window_new_total, Fset_window_new_normal)
3280 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3281 (delete_all_subwindows): Rename to delete_all_child_windows.
3282 (Fdelete_other_windows_internal, Fset_window_configuration):
3283 Call delete_all_child_windows instead of delete_all_subwindows.
3284 * frame.c (delete_frame): Call delete_all_child_windows instead
3285 of delete_all_subwindows.
3286
ca78dc43
PE
32872011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3288
3289 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3290 This is also needed for porting to any host where GC_MARK_STACK is
3291 not GC_MAKE_GCPROS_NOOPS.
3292 (which_symbols): Use it.
3293
a0241d01
KH
32942011-11-07 Kenichi Handa <handa@m17n.org>
3295
3296 * coding.c (coding_set_destination): Check coding->src_pos only
3297 when coding->src_object is a buffer (bug#9910).
3298
3299 * process.c (send_process): Set the member src_multibyte of coding
3300 to 0 (bug#9911) when sending a unibyte text.
3301
3302 * callproc.c (Fcall_process): Set the member src_multibyte of
3303 process_coding to 0 (bug#9912).
3304
a64bfdfa 33052011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3306
3307 * xmenu.c (cleanup_widget_value_tree): New function.
3308 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3309 calling free_menubar_widget_value_tree directly (Bug#9830).
3310
cb41b32a
PE
33112011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3312
3313 Fix some portability problems with 'inline'.
3314 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3315 (window_box_width, window_box_left, window_box_left_offset)
3316 (window_box_right, window_box_right_offset): Declare extern.
3317 Otherwise, these inline functions do not conform to C99 and
3318 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3319 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3320 * intervals.c (adjust_intervals_for_insertion)
3321 (adjust_intervals_for_deletion): Now extern, because otherwise the
3322 extern inline functions 'offset_intervals' couldn't refer to it.
3323 (static_offset_intervals): Remove.
3324 (offset_intervals): Rewrite using the old contents of
3325 static_offset_intervals. The old version didn't conform to C99
3326 because an extern inline function contained a reference to an
3327 identifier with static linkage.
3328
b7041366
AS
33292011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3330
3331 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3332 GC.
3333
88a37c4d
EZ
33342011-11-06 Eli Zaretskii <eliz@gnu.org>
3335
3336 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3337 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3338 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3339 return Qleft_to_right.
3340
49745b39
CY
33412011-11-06 Chong Yidong <cyd@gnu.org>
3342
3343 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3344 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3345 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3346 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3347 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3348 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3349 (Fwindow_vscroll): Doc fix.
3350 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3351 argument, since it makes no sense to pass a live window and for
3352 consistency with window-child.
3353
1f05cd82
CS
33542011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3355
3356 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3357 support MSVC.
3358
22610910
JR
33592011-11-05 Jason Rumney <jasonr@gnu.org>
3360
3361 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3362 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3363 fonts (Bug#6029).
3364 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3365 bitwise arithmetic preventing use of unicode-sip and non-truetype
3366 opentype fonts.
3367
a06776b2
EZ
33682011-11-05 Eli Zaretskii <eliz@gnu.org>
3369
3ad924ba
EZ
3370 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3371 "emacs"-only part.
3372
a06776b2
EZ
3373 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3374 initialization code to keep similarity to xfns.c after changes
3375 from 2011-11-05.
3376
c9e7db78
JD
33772011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3378
a97f8f3f
JD
3379 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3380 (unwind_create_frame): New function (Bug#9943).
3381 (Fx_create_frame): Restructure code to be more similar to the one in
3382 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3383 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3384 Move terminal->reference_count++ just before making the frame official
3385 (Bug#9943).
3386
3387 * nsterm.m (x_free_frame_resources): New function.
3388 (x_destroy_window): Move code to x_free_frame_resources.
3389
c9e7db78 3390 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3391 (Fx_create_frame, x_create_tip_frame):
3392 Move terminal->reference_count++ just before making the frame
75f1671a 3393 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3394 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3395
a6fc3b5c
EZ
33962011-11-05 Eli Zaretskii <eliz@gnu.org>
3397
3398 Support MSVC build with newer versions of Visual Studio.
3399 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3400 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3401 nt/gmake.defs.
3402
3403 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3404 which are not supported by MSVC.
3405 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3406 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3407 bitfields.
3408 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3409 types in bitfields.
3410 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3411
3412 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3413
58179cce 34142011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3415
3416 Support MSVC build with newer versions of Visual Studio.
3417 * w32.c: Don't include w32api.h for MSVC.
3418 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3419
3420 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3421 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3422 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3423 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3424 e_* cousins.
3425 (alloca) [_MSC_VER]: Define to _alloca.
3426
3427 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3428
3429 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3430
a58c13ed
EZ
34312011-11-04 Eli Zaretskii <eliz@gnu.org>
3432
3433 * xdisp.c (note_mouse_highlight): If either of
3434 previous/next-single-property-change returns nil, treat that as
3435 the beginning or the end of the buffer. (Bug#9955)
3436
fe0b6370
JD
34372011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3438
a58c13ed 3439 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3440 label is not null (Bug#9951).
3441 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3442 may be NULL.
3443
89bd5ee1
EZ
34442011-11-04 Eli Zaretskii <eliz@gnu.org>
3445
3446 * window.c (Fwindow_body_size): Mention in the doc string that the
3447 return value is in frame's canonical units. (Bug#9949)
3448
84c3edb9
EZ
34492011-11-03 Eli Zaretskii <eliz@gnu.org>
3450
4e2fb5c7
EZ
3451 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3452
84c3edb9 3453 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3454 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3455 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3456
bc17a887
EZ
34572011-11-01 Eli Zaretskii <eliz@gnu.org>
3458
3459 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3460 Don't stop backward scan on the continuation glyph, even though
3461 its CHARPOS is positive.
6d5eb5b0
SM
3462 (mouse_face_from_buffer_pos, note_mouse_highlight):
3463 Rename cover_string to disp_string.
bc17a887 3464
4ee88440
MR
34652011-11-01 Martin Rudalics <rudalics@gmx.at>
3466
3467 * window.c (temp_output_buffer_show): Don't use
3468 Vtemp_buffer_show_specifiers.
3469 (Vtemp_buffer_show_specifiers): Remove unused variable.
3470
c2ff3c02
EZ
34712011-10-30 Eli Zaretskii <eliz@gnu.org>
3472
3473 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3474 past the beginning of the current glyph matrix.
3475
58179cce 34762011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3477
3478 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3479 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3480 HAVE_GTK3 (Bug#9869).
b77a6a7f 3481
3b574623
JD
3482 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3483 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3484
b77a6a7f
JD
3485 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3486
3487 * xterm.c: Declare x_handle_net_wm_state to return int.
3488 (handle_one_xevent): Check if we are iconified but don't have
3489 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3490 (get_current_wm_state): Return non-zero if not hidden,
3491 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3492 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3493 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3494 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3495
196e41e4
PE
34962011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3497
3498 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3499 so that this new function doesn't get optimized away by a
3500 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3501
021f2e1a
AS
35022011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3503
3504 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3505
8b058d44
EZ
35062011-10-29 Eli Zaretskii <eliz@gnu.org>
3507
3508 Fix the `xbytecode' command.
3509 * .gdbinit (xprintbytestr): New command.
b50a28de 3510 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3511 (xbytecode): Print the byte-code string as well.
3512
4452fb80
EZ
35132011-10-29 Kim Storm <storm@cua.dk>
3514
8b058d44
EZ
3515 * alloc.c (which_symbols): New function.
3516
21b72067
AS
35172011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3518
3519 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3520 line. (Bug#9903)
3521
83ed7b5c
GM
35222011-10-29 Glenn Morris <rgm@gnu.org>
3523
3524 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3525 Not clear what it was for, and it causes various bugs. (Bug#9839)
3526
5a7a728b
EZ
35272011-10-28 Eli Zaretskii <eliz@gnu.org>
3528
3529 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3530 possible random value that matches one of those tested as
3531 condition to clear the mouse face.
3532
d3d0842f
CY
35332011-10-28 Chong Yidong <cyd@gnu.org>
3534
3535 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3536
31b39d13
DN
35372011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3538
3539 * window.c (make_window): Initialize phys_cursor_on_p.
3540
9aba6043
SM
35412011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3542
3543 * lisp.h (struct Lisp_Symbol): Update comments.
3544
c20992f4
JB
35452011-10-28 Juanma Barranquero <lekktu@gmail.com>
3546
3547 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3548
db4f02f2
EZ
35492011-10-28 Eli Zaretskii <eliz@gnu.org>
3550
3551 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3552 <oslsachem@gmail.com> for helping to debug this.
3553
3554 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3555 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3556 (g_b_init_get_glyph_outline_w): New static variables.
3557 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3558 (GetGlyphOutlineW_Proc): New typedefs.
3559 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3560 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3561 New functions.
3562 (w32font_open_internal, compute_metrics):
3563 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3564 instead of calling the "wide" APIs directly.
3565
3566 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3567
3568 * w32.h (syms_of_w32font): Add prototype.
3569
87e68db4
JB
35702011-10-27 Juanma Barranquero <lekktu@gmail.com>
3571
3572 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3573 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3574 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3575 (Fmove_to_window_line): Doc fix.
3576
435c1d67
CY
35772011-10-27 Chong Yidong <cyd@gnu.org>
3578
3579 * process.c (make_process): Set gnutls_state to NULL.
3580
3581 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3582 non-NULL, regardless of GNUTLS_INITSTAGE.
3583 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3584 an error. Set process slots as soon as we allocate them.
3585
3586 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3587
9c6c6f49
CY
35882011-10-27 Chong Yidong <cyd@gnu.org>
3589
9aba6043
SM
3590 * gnutls.c (emacs_gnutls_deinit): New function.
3591 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3592 (Fgnutls_deinit, Fgnutls_boot): Use it.
3593
3594 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3595 (deactivate_process): Call emacs_gnutls_deinit.
3596
657d08d3
JB
35972011-10-27 Juanma Barranquero <lekktu@gmail.com>
3598
3599 * image.c (x_create_x_image_and_pixmap):
3600 * w32.c (sys_rename, w32_delayed_load):
3601 * w32font.c (fill_in_logfont):
3602 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3603
5430d399
JB
36042011-10-26 Juanma Barranquero <lekktu@gmail.com>
3605
3606 * w32fns.c (w32_default_color_map): New function,
3607 extracted from Fw32_default_color_map.
a7ef684b 3608 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3609
fe0055fa
PE
36102011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3611
3612 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3613
e6346438
SM
36142011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3615
3616 * keyboard.c (test_undefined): New function (bug#9751).
3617 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3618
e112cc37
ET
36192011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3620
3621 * sysdep.c (init_sys_modes): Fix the check for the controlling
3622 terminal (Bug#6649).
3623
7b5d6677
EZ
36242011-10-20 Eli Zaretskii <eliz@gnu.org>
3625
3626 * dispextern.h (struct bidi_it): New member next_en_type.
3627
3628 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3629 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3630 current character, check also for next_en_type being WEAK_EN.
3631 (bidi_resolve_weak): Don't enter the expensive loop if the current
3632 position is before next_en_pos. Record the bidi type of the first
3633 non-ET, non-BN character we find, in addition to its position.
3634 (bidi_level_of_next_char): Invalidate next_en_type when
3635 next_en_pos is over-stepped.
3636
7da0b018
PE
36372011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3638
3639 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3640 * editfns.c: Rewrite current-time-zone so that it invokes
3641 the equivalent of (format-time-string "%Z") to get the time zone name.
3642 This fixes a bug when the time zone name contains characters that
3643 need converting from the system time locale to Emacs internal format.
3644 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3645 that patch fixed format-time-string to do the conversion, but
3646 I forgot to fix current-time-zone.
3647 (format_time_string): New function, containing most of
3648 what Fformat_time_string used to contain.
3649 (Fformat_time_string): Rewrite in terms of format_time_string.
3650 This doesn't change this function's behavior.
3651 (current-time-zone): Rewrite to use format_time_string.
3652 This fixes the bug reported by Michael Schierl in
3653 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3654 Jason Rumney's 2007-06-07 change worked around this bug, but
3655 didn't fix it.
3656 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3657
8547b010
EZ
36582011-10-19 Eli Zaretskii <eliz@gnu.org>
3659
3660 * xdisp.c (start_display): If the character at POS is displayed
3661 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3662 (try_window_reusing_current_matrix): If a line ends in a display
3663 vector or the next line starts in a display vector, continue
3664 redrawing the window even though the character position of
3665 start_row was reached.
8547b010
EZ
3666 (Bug#9771, part 2)
3667
4e948d15
CY
36682011-10-18 Chong Yidong <cyd@gnu.org>
3669
3670 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3671 with nobreak-char-display too.
3672
4787455f
EZ
36732011-10-18 Eli Zaretskii <eliz@gnu.org>
3674
3675 Fix part 3 of bug#9771.
3676 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3677 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3678 non-neutral characters if the current character is a paragraph
3679 separator (a.k.a. Newline). This avoids running the same
3680 expensive loop twice, once when we consume the preceding newline
3681 and the other time when the line actually needs to be displayed.
3682 Avoid the loop when we see neutrals on the base embedding level
3683 following a character whose directionality is the same as the
3684 paragraph's. This avoids running the expensive loop when a line
3685 ends in a long sequence of neutrals, like control characters.
3686 Add assertion against STRONG_AL type. Slightly rearrange code
3687 that determines the type of a neutral given the first non-neutral
3688 that follows it.
3689 (bidi_level_of_next_char): Set next_en_pos to zero when
3690 invalidating its info.
3691
2c91f553
EZ
36922011-10-17 Eli Zaretskii <eliz@gnu.org>
3693
3694 * xdisp.c (push_display_prop): Determine whether to record string
3695 or buffer position by IT->string, not by IT->method. Allow
3696 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3697 (move_it_vertically_backward): Don't look for character position
3698 immediately after the newline when in a continuation line.
3699 (Bug#9771, part 1)
2c91f553 3700
c7b08b0d
MR
37012011-10-15 Martin Rudalics <rudalics@gmx.at>
3702
3703 * window.c (coordinates_in_window): Rewrite and delabelize
3704 vertical border check. (Bug#5357) (Bug#9618)
3705
6b02f655
SM
37062011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3707
3708 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3709 errors in XSetWindowBorder (bug#9310).
3710
81d40c92
DA
37112011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3712
3713 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3714 avoid crash when xmalloc overrun checking is enabled.
3715
d4172c3b
EZ
37162011-10-13 Eli Zaretskii <eliz@gnu.org>
3717
3718 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3719 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3720 cursor motion with <left> and <right> arrow keys.
3721
3722 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3723 some callers set that themselves.
3724
b00eea75
EZ
37252011-10-12 Eli Zaretskii <eliz@gnu.org>
3726
3727 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3728 display string and the previous row comes from the same string and
3729 is empty. (Bug#9739) (Bug#9738)
3730
8fe012c4
SM
37312011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3732
3733 * doc.c (get_doc_string): Encode file name (bug#9735).
3734
0074aef2
EZ
37352011-10-12 Eli Zaretskii <eliz@gnu.org>
3736
79beb178
EZ
3737 * bidi.c (bidi_level_of_next_char):
3738 * xdisp.c (get_visually_first_element): Remove old incorrect
3739 comments regarding the Unicode Line Separator character.
3740
0074aef2
EZ
3741 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3742
6e4b3fbe
DA
37432011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3744
3745 * alloc.c (Fgc_status): Do not access beyond zombies array
3746 boundary if nzombies > MAX_ZOMBIES.
3747 * alloc.c (dump_zombies): Add missing format specifier.
3748
0324f3af
PE
37492011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3750
b5525cac
PE
3751 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3752 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3753
0324f3af
PE
3754 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3755 Some packages use them to denote characters with modifiers.
3756
e9b5f888
AS
37572011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3758
3759 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3760 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3761 matching a pp-number. Rename parameter var to var1.
3762
127827c0
SM
37632011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3764
3765 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3766
c8fd3bd0
GM
37672011-10-08 Glenn Morris <rgm@gnu.org>
3768
3769 * callint.c (Fcall_interactively): Give a more explicit error for the
3770 'c' case with a non-character input. (Bug#8479)
3771
352ec8ff
EZ
37722011-10-08 Eli Zaretskii <eliz@gnu.org>
3773
03669ccb
EZ
3774 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3775 lines.
7061c986
EZ
3776 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3777 lines that are hscrolled on the left.
03669ccb 3778
352ec8ff
EZ
3779 * dispnew.c (buffer_posn_from_coords): Account for a possible
3780 presence of header-line. (Bug#4426)
3781
a66cfb1c
SM
37822011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3783
6b02f655
SM
3784 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3785 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3786
7c5ee88e
PE
37872011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3788
3789 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3790 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3791 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3792 this makes Emacs dump core during garbage collection on rare
3793 occasions. sizeof is obviously inferior to offsetof here, so
3794 stick with offsetof.
3795 (GC_POINTER_ALIGNMENT): New macro.
3796 (mark_memory): Omit 3rd (offset) arg; caller changed.
3797 Don't assume EMACS_INT alignment is the same as pointer alignment.
3798
df1bbe5b
SM
37992011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3800
3801 * keyboard.c (read_key_sequence_remapped): New var.
3802 (read_key_sequence): Compute remapping in the right buffer.
3803 (command_loop_1): Use read_key_sequence's remapping directly.
3804
51553db6
SM
38052011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3806
32c1fffd
SM
3807 * dired.c (file_name_completion): Don't expand file name.
3808 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3809 before checking file name handler.
3810
51553db6
SM
3811 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3812 they've been requested explicitly (bug#9591).
3813
b6bd1599 38142011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3815
3816 * keymap.c (Fsingle_key_description): Use make_specified_string
3817 instead of build_string to build string from push_key_description.
3818 (Bug#5193)
3819
f701dc2a
PE
38202011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3821
4222c55d
PE
3822 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3823 This fixes a Y2038 bug on 64-bit hosts.
3824 * buffer.c (reset_buffer):
3825 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3826 (Fclear_buffer_auto_save_failure):
3827 Use 0, not -1, to represent an unset failure time, since time_t
3828 might not be signed.
3829
f701dc2a
PE
3830 Remove dependency on glibc malloc internals.
3831 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3832 Move back here from lisp.h, but with their new implementations.
3833 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3834 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3835 * charset.c (charset_table_init): New static var.
3836 (syms_of_charset): Use it instead of xmalloc. This removes a
3837 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3838 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3839 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3840 Move back to alloc.c.
3841 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3842 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3843
9ceebf39
JD
38442011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3845
3846 * nsterm.m (windowDidResize): Call x_set_window_size only when
3847 ns_in_resize is true. Otherwise set pixelwidth/height and
3848 call change_frame_size (Bug#9628).
3849
cb993c58
PE
38502011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3851
3930c88b
PE
3852 Port --enable-checking=all to Fedora 14 x86-64.
3853 * charset.c (syms_of_charset): Also account for glibc malloc's
3854 internal overhead when calculating the initial malloc maximum.
3855
cb993c58
PE
3856 Port --enable-checking=all to Fedora 14 x86.
3857 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3858 Move to lisp.h.
3859 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3860 (overrun_check_realloc, overrun_check_free):
3861 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3862 That way, xmalloc returns a properly-aligned pointer even if
3863 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3864 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3865 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3866 into account when calculating the initial malloc maximum.
3867 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3868 Move here from alloc.c, so that charset.c can use it too.
3869 Properly align; the old code wasn't right for common 32-bit hosts
3870 when configured with --enable-checking=all.
3871 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3872 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3873
31bed486
EZ
38742011-09-29 Eli Zaretskii <eliz@gnu.org>
3875
04c70788 3876 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3877 use EDOM.
3878
fbcaa2f3
EZ
38792011-09-28 Eli Zaretskii <eliz@gnu.org>
3880
3881 * xdisp.c (compute_display_string_end): If there's no display
3882 string at CHARPOS, return -1.
3883
3884 * bidi.c (bidi_fetch_char): When compute_display_string_end
3885 returns a negative value, treat the character as a normal
3886 character not covered by a display string. (Bug#9624)
3887
a239d4e9
JB
38882011-09-28 Juanma Barranquero <lekktu@gmail.com>
3889
3890 * lread.c (Fread_from_string): Fix typo in docstring.
3891
88652fd5
EZ
38922011-09-27 Eli Zaretskii <eliz@gnu.org>
3893
3894 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3895 newline, reseat the iterator instead of bidi-iterating there one
3896 character at a time. (Bug#9610)
32c1fffd
SM
3897 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3898 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3899
ed497dd4
AS
39002011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3901
3902 * lread.c (readevalloop): Use correct code for NBSP.
3903 (read1): Likewise. (Bug#9608)
3904
b2bf61aa
MA
39052011-09-25 Michael Albinus <michael.albinus@gmx.de>
3906
3907 * dbusbind.c (Fdbus_register_signal): When service is not
3908 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3909
32bbb17c
GM
39102011-09-25 Glenn Morris <rgm@gnu.org>
3911
3912 * buffer.c (truncate-lines): Doc fix.
3913
94e0933e
CY
39142011-09-24 Chong Yidong <cyd@stupidchicken.com>
3915
3916 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3917 (Fset_window_next_buffers): Doc fix.
3918
cddde921
GM
39192011-09-24 Glenn Morris <rgm@gnu.org>
3920
3921 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3922
1260aef1
PE
39232011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3924
25b4bfa0
PE
3925 Fix minor problems found by static checking.
3926 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3927 * indent.c (Fvertical_motion): Fix == vs = typo.
3928
e3cbd34b
EZ
39292011-09-24 Eli Zaretskii <eliz@gnu.org>
3930
a66cfb1c
SM
3931 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3932 Default value is now t. Doc fix.
6bf7006f 3933
e3cbd34b 3934 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3935 logic when moving up, not only when moving down. Fix the
e3cbd34b 3936 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3937 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3938
3939 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3940 CHARPOS is covered by a display string which includes newlines.
3941 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3942 is covered by a display string with embedded newlines.
3943
a3de0cbd
MA
39442011-09-24 Michael Albinus <michael.albinus@gmx.de>
3945
3946 * dbusbind.c (Fdbus_register_signal): Add match rule to
3947 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3948 (Fdbus_register_method, Vdbus_registered_objects_table):
3949 Fix docstring.
a3de0cbd 3950
b260039d
JM
39512011-09-24 Jim Meyering <meyering@redhat.com>
3952
32c1fffd 3953 do not ignore write error for any output size
b260039d
JM
3954 The previous change was incomplete.
3955 While it makes emacs --batch detect the vast majority of stdout
3956 write failures, errors were still ignored whenever the output size is
3957 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3958 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3959 && echo FAIL: ignored write error
3960 FAIL: ignored write error
3961 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3962 && echo FAIL: ignored write error
3963 FAIL: ignored write error
3964 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3965
8eca8a7c
AS
39662011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3967
3968 * emacs.c (Fkill_emacs): In noninteractive mode exit
3969 non-successfully if a write error occurred on stdout. (Bug#9574)
3970
3341db62
EZ
39712011-09-21 Eli Zaretskii <eliz@gnu.org>
3972
3973 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3974 the xassert test.
3975
3976 * dispextern.h (struct it): Update the comment documenting what
3977 can it->OBJECT be.
3978
8c203dbf
EZ
39792011-09-20 Eli Zaretskii <eliz@gnu.org>
3980
3981 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3982 a display string, extend search for cursor position to end of row.
3983 (find_row_edges): If the row ends in a newline from a display
3984 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3985 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3986 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3987 non-empty line. Fixes confusing cursor motion with arrow keys at
3988 the beginning of a line that starts with whitespace.
8c203dbf 3989
a4824228
LMI
39902011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3991
3992 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3993 (bug#9493).
3994
33ed493b
CY
39952011-09-18 Chong Yidong <cyd@stupidchicken.com>
3996
3997 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3998 boolean (Bug#9154).
3999
56cd55c8
EZ
40002011-09-18 Eli Zaretskii <eliz@gnu.org>
4001
4002 * xdisp.c (display_line): Record maximum and minimum buffer
4003 positions even if no glyphs were produced (e.g., by a zero-width
4004 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4005 buffer positions that will be removed from the glyph row because
4006 they don't fit.
c02dcedf
EZ
4007 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4008 column is beyond frame width: don't subtract 1 "pixel" when
4009 computing width of the stretch.
3e62b7e0
EZ
4010 (reseat_at_next_visible_line_start): Undo the change made on
4011 2011-09-17 that saved paragraph information and restored it after
4012 the call to `reseat'. (Bug#9545)
56cd55c8 4013
5ed99d36 40142011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4015
4016 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4017 and turn window cursor on if cleared (Bug#9415).
4018
5ed99d36 40192011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4020
4021 * search.c (boyer_moore): Take unibyte characters from pattern
4022 literally. (Bug#9458)
4023
9bade7b2
EZ
40242011-09-18 Eli Zaretskii <eliz@gnu.org>
4025
4026 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4027
e5e9d610
PE
40282011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4029
87e4427a
PE
4030 Fix minor problem found by static checking.
4031 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4032 initialized, to pacify gcc -Wuninitialized.
4033
e5e9d610
PE
4034 * fileio.c: Report proper errno when syscall falls.
4035 (Finsert_file_contents): Save and restore errno,
4036 so that report_file_error outputs the correct diagnostic.
4037 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4038
a1674f0b
EZ
40392011-09-18 Eli Zaretskii <eliz@gnu.org>
4040
4041 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4042
fbfb6dd4
EZ
40432011-09-17 Eli Zaretskii <eliz@gnu.org>
4044
4045 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4046 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4047
bb187662
EZ
40482011-09-17 Eli Zaretskii <eliz@gnu.org>
4049
1137e8b8 4050 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4051 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4052
4053 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4054 (bidi_find_paragraph_start): Search back for paragraph beginning
4055 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4056 (bidi_move_to_visually_next): Only trigger paragraph-related
4057 computations when the last character is a newline or at EOB, not
4058 just any NEUTRAL_B. (Bug#9470)
4059
bb187662
EZ
4060 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4061 truncated lines if point is covered by a display string. (Bug#9524)
4062
2e621251
PE
40632011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4064
4065 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4066 (cons_to_x_long): New function.
4067 (lisp_data_to_selection_data): Use it. Correct the test for
4068 short-versus-long data; it was negated. Break out of vector
4069 loop, for efficiency, when a long datum is discovered.
4070
91a15bc6
SM
40712011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4072
4073 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4074
b41c3a35
EZ
40752011-09-16 Eli Zaretskii <eliz@gnu.org>
4076
4077 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4078 GCC PR/17406) by declaring this function with external scope.
4079
7812ba2d
PE
40802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4081
4082 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4083 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4084
cf7edc2a
AS
40852011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4086
4087 * editfns.c (Fformat): Correctly handle text properties on "%%".
4088
bd01620e
EZ
40892011-09-15 Eli Zaretskii <eliz@gnu.org>
4090
4091 * xterm.c (x_draw_composite_glyph_string_foreground):
4092 * w32term.c (x_draw_composite_glyph_string_foreground):
4093 * term.c (encode_terminal_code):
4094 * composite.c (composition_update_it, get_composition_id):
4095 * xdisp.c (get_next_display_element)
4096 (fill_composite_glyph_string): Add comments about special meaning
4097 of TAB characters in a composition.
4098
a02719a3
PE
40992011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4100
4101 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4102 This occurs when processing a multibyte format.
4103 Problem reported by Wolfgang Jenker.
a02719a3 4104
72589a3c
JB
41052011-09-15 Johan Bockgård <bojohan@gnu.org>
4106
4107 * xdisp.c (try_cursor_movement): Only check for exact match if
4108 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4109
1c14176c
PE
41102011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4111
4112 Remove unused external symbols.
4113 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4114 * xdisp.c (calc_pixel_width_or_height): Now static.
4115 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4116 * indent.c (check_display_width):
4117 * w32term.c: Fix comment to match code.
4118 * xterm.c, xterm.h (x_catching_errors): Remove.
4119
d2eea5b5
PE
41202011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4121
4122 * xselect.c: Use signed conversions more consistently (Bug#9498).
4123 (selection_data_to_lisp_data): Assume incoming selection data are
4124 signed integers, not unsigned. This is to be consistent with
4125 outgoing selection data, which was modified to use signed integers
4126 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4127 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4128 expects long, not unsigned long.
4129
46888499
EZ
41302011-09-14 Eli Zaretskii <eliz@gnu.org>
4131
4132 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4133 computation of loop end. Reported by Johan Bockgård
4134 <bojohan@gnu.org>.
4135
ef8ef9fb
CY
41362011-09-13 Chong Yidong <cyd@stupidchicken.com>
4137
4138 * frame.c (Fother_visible_frames_p): Function deleted.
4139
fa819fed
EZ
41402011-09-12 Eli Zaretskii <eliz@gnu.org>
4141
4142 * indent.c (compute_motion): Process display vector front to back
4143 rather than the other way around. (Bug#2496)
4144
2ba8e008
SM
41452011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4146
4147 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4148
20f53c69
CY
41492011-09-11 Chong Yidong <cyd@stupidchicken.com>
4150
4151 * minibuf.c (Fread_from_minibuffer): Doc fix.
4152
d562d7a4
EZ
41532011-09-11 Eli Zaretskii <eliz@gnu.org>
4154
4155 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4156 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4157
1c4d7f3d
LMI
41582011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4159
4160 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4161 value for non-existent files.
4162
b885bf36
EZ
41632011-09-11 Eli Zaretskii <eliz@gnu.org>
4164
4165 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4166 set its "size" to -1. This will set the modtime_size field of
4167 the corresponding buffer to -1, which is what
4168 verify-visited-file-modtime expects for files that do not exist.
4169 (Bug#9139)
4170
6612f0bf
PE
41712011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4172
4173 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4174 here ...
4175 * lisp.h: ... from here. push_key_description is no longer
4176 defined in keyboard.c, so its declaration should not be in
4177 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4178 logically belongs with push_key_description.
4179
dfb3f755
PE
41802011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4181
4182 * buffer.h: Include <sys/types.h> instead of <time.h>.
4183 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4184 Problem reported by Herbert J. Skuhra.
4185
3134906c
LMI
41862011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4187
4188 * xml.c (parse_region): Make the parsing work for
4189 non-comment-starting XML files again (bug#9144).
4190
8d903f4e
AS
41912011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4192
4193 * image.c (gif_load): Fix calculation of bottom and right corner.
4194 (Bug#9468)
4195
80ad64f4
EZ
41962011-09-10 Eli Zaretskii <eliz@gnu.org>
4197
4198 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4199 redisplay in small windows.
4200
208a048d
EZ
42012011-09-09 Eli Zaretskii <eliz@gnu.org>
4202
4203 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4204
9b1c252e
MR
42052011-09-08 Martin Rudalics <rudalics@gmx.at>
4206
4207 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4208 Operate on live windows only.
4209
2949f33b
JB
42102011-09-08 Juanma Barranquero <lekktu@gmail.com>
4211
4212 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4213
e08dcafd
EZ
42142011-09-07 Eli Zaretskii <eliz@gnu.org>
4215
4216 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4217 only under bidi iteration.
4218
115b96bd
JD
42192011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4220
4221 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4222
c8199d0f
PE
42232011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4224
4225 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4226 Without this fix, the command to link temacs failed due to an
4227 undefined symbol __builtin_isnan. This is because
4228 /usr/include/iso/math_c99.h #defines isnan(x) to
4229 __builtin_isnan(x), but the bundled gcc, which identifies itself
4230 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4231 a __builtin_isnan.
4232 * floatfns.c (isnan): #undef, and then #define to a clone of
4233 what's in data.c.
4234 (Fisnan): Always define, since it's always available now.
4235 (syms_of_floatfns): Always define isnan at the Lisp level.
4236
e39b275c 42372011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4238
4239 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4240
b2db44d9 42412011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4242
f4af5137 4243 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4244 The previous code assumed that file offsets (off_t values) fit in
4245 EMACS_INT variables, which is not true on typical 32-bit hosts.
4246 The code messed up by falsely reporting buffer overflow in cases
4247 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4248 when "big" contains more than 2**29 bytes, even though this
4249 inserts just one byte and does not overflow the buffer.
4250 (Finsert_file_contents): Store file offsets as off_t
4251 values, not as EMACS_INT values. Check for overflow when
4252 converting between EMACS_INT and off_t. When checking for
4253 buffer overflow or for overlap, take the offsets into account.
4254 Don't use EMACS_INT for small values where int suffices.
4255 When checking for overlap, fix a typo: ZV was used where
4256 ZV_BYTE was intended.
4257 (Fwrite_region): Don't assume off_t fits into 'long'.
4258 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4259
ecfc0a49
MA
42602011-09-05 Michael Albinus <michael.albinus@gmx.de>
4261
4262 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4263
6511acf2 42642011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4265
0999621a 4266 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4267
4268 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4269 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4270 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4271 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4272 (modify_event_symbol): Do not assume that the length of
4273 name_alist_or_stem is safe to alloca and fits in int.
4274 (Fexecute_extended_command): Likewise for function name and binding.
4275 (Frecursion_depth): Wrap around reliably on integer overflow.
4276 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4277 since some callers pass EMACS_INT values.
4278 (Fsingle_key_description): Don't crash if symbol name contains more
4279 than MAX_ALLOCA bytes.
4280 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4281 (get_minibuffer): Arg is now EMACS_INT, not int.
4282 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4283 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4284 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4285
2be7d702
PE
4286 * dbusbind.c (signature_cat): New function.
4287 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4288 Do not overrun buffer; instead, report string overflow.
4289
9d1df220
PE
4290 * dispnew.c (add_window_display_history): Don't overrun buffer.
4291 Truncate instead; this is OK since it's just a log.
4292
33ef5c64
PE
4293 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4294 even if the time zone offset is outlandishly large.
4295 Don't mishandle offset == INT_MIN.
4296
66c6fdd5
PE
4297 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4298 when creating daemon; the previous buffer-overflow check was incorrect.
4299
d749b01b
PE
4300 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4301 which has the guts of the old verror function.
4302
b5cd1905
PE
4303 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4304 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4305
6e1a67fb
PE
4306 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4307 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4308 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4309 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4310 length of string rather than counting it via multiple sprintfs;
4311 that's simpler and more reliable.
c21721cc
PE
4312 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4313 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4314 sprintf, in case result does not fit in int.
4315
c57b67fc
PE
4316 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4317 (fontset_from_font): Print it.
4318
8a401434
PE
4319 * frame.c (tty_frame_count): Now printmax_t, not int.
4320 (make_terminal_frame, set_term_frame_name): Print it.
4321 (x_report_frame_params): In X, window IDs are unsigned long,
4322 not signed long, so print them as unsigned.
4323 (validate_x_resource_name): Check for implausibly long names,
4324 and don't assume name length fits in 'int'.
4325 (x_get_resource_string): Don't blindly alloca invocation name;
4326 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4327 not fit in int.
4328
6e1a67fb
PE
4329 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4330 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4331 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4332
0df02bf3
PE
4333 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4334 Use esprintf, not sprintf, in case result does not fit in int.
4335
48e30793
PE
4336 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4337 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4338 it as a large positive number.
4339 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4340 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4341
a66ff6d8
PE
4342 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4343 in case result does not fit in int.
4344
aca216ff
PE
4345 * print.c (float_to_string): Detect width overflow more reliably.
4346 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4347 buffer overrun. Don't assume list length fits in 'int'. Treat
4348 print length of 0 as 0, not as infinity; to be consistent with other
4349 uses of print length in this function. Don't overflow print length
4350 index. Don't assume hash table size fits in 'long', or that
4351 vectorlike size fits in 'unsigned long'.
4352
31c286f7
PE
4353 * process.c (make_process): Use printmax_t, not int, to format
4354 process-name gensyms.
4355
55e5faa1
PE
4356 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4357
80f2e268
PE
4358 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4359 to avoid potential buffer overrun.
4360
670741ab
PE
4361 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4362 if X resource line is longer than 512 bytes.
4363
b7163a50
PE
4364 * xfns.c (x_window): Make sprintf buffer a bit bigger
4365 to avoid potential buffer overrun.
4366
ae58ff1f
PE
4367 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4368
c43c8a6a
PE
4369 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4370
3f8236f4
PE
43712011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4372
53e9fe90 4373 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4374 Without these, Emacs silently mishandles large integers sometimes.
4375 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4376 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4377
6511acf2
PE
4378 * xdisp.c (try_window_id): Check Emacs fixnum range before
4379 converting to 'int'.
806add1d 4380
6511acf2 4381 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4382 Check that an Emacs fixnum is in range before assigning it to 'int'.
4383 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4384 values converted from Emacs fixnums.
4385 (Frecenter): Don't wrap around a line count if it is out of 'int'
4386 range; instead, treat it as an extreme value.
4387 (Fset_window_configuration, compare_window_configurations):
4388 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4389
6511acf2
PE
4390 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4391 that can exceed INT_MAX. Check that EMACS_INT value is in range
4392 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4393 (match_limit): Don't assume that a fixnum can fit in 'int'.
4394
6511acf2 4395 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4396 exceed INT_MAX.
4397
6511acf2 4398 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4399 (Fvertical_motion): Don't wrap around LINES values that don't fit
4400 in 'int'. Instead, treat them as extreme values. This is good
4401 enough for windows, which can't have more than INT_MAX lines anyway.
4402
fcb901a7
LMI
44032011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4404
0f2f6b6d
LMI
4405 * Require libxml/parser.h to avoid compilation warning.
4406
fcb901a7
LMI
4407 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4408
4409 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4410 since this reportedly can destroy thread storage.
4411
6e20a0d4
CY
44122011-08-30 Chong Yidong <cyd@stupidchicken.com>
4413
4414 * syntax.c (find_defun_start): Update all cache variables if
4415 exiting early (Bug#9401).
4416
148ae00e
EZ
44172011-08-30 Eli Zaretskii <eliz@gnu.org>
4418
f6cfbd8f
EZ
4419 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4420
148ae00e
EZ
4421 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4422 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4423 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4424
4425 * term.c (tty_append_glyph): New function.
4426 (produce_stretch_glyph): Static function and its prototype deleted.
4427
a66cfb1c
SM
4428 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4429 Add prototypes.
148ae00e 4430
c4a07a4c
PE
44312011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4432
4433 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4434 when checking :margin (Bug#9390).
4435 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4436 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4437 so that the name doesn't mislead. All uses changed.
4438
6bc8cd65
JB
44392011-08-28 Johan Bockgård <bojohan@gnu.org>
4440
4441 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4442 set_tty_hooks.
4443
dca4927e
EZ
44442011-08-27 Eli Zaretskii <eliz@gnu.org>
4445
4446 * xdisp.c (move_it_to): Don't bail out early when reaching
4447 position beyond to_charpos, if we are scanning backwards.
4448 (move_it_vertically_backward): When DY == 0, make sure we get to
4449 the first character in the line after the newline.
4450
f2cad773
PE
44512011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4452
4453 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4454 (ccl_driver): Do not generate an out-of-range pointer.
4455 (Fccl_execute_on_string): Remove unnecessary check for
4456 integer overflow, noted by Stefan Monnier in
4457 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4458 Remove a FIXME that didn't need fixing.
4459 Simplify the newly-introduced buffer reallocation code.
4460
0cae2cdb
JB
44612011-08-27 Juanma Barranquero <lekktu@gmail.com>
4462
4463 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4464
5fc295a4 44652011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4466
70c60eb2 4467 Integer and memory overflow issues (Bug#9196).
726e0ab1 4468
d31850da
PE
4469 * doc.c (get_doc_string): Rework so that
4470 get_doc_string_buffer_size is the actual buffer size, rather than
4471 being 1 less than the actual buffer size; this makes xpalloc more
4472 convenient.
4473
a69fbedb
PE
4474 * image.c (x_allocate_bitmap_record, cache_image):
4475 * xselect.c (Fx_register_dnd_atom):
4476 Simplify previous changes by using xpalloc.
4477
fe5c5d37
PE
4478 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4479 since either will do and ptrdiff_t is convenient with xpalloc.
4480
0065d054
PE
4481 * charset.c (charset_table_size)
4482 (struct charset_sort_data.priority): Now ptrdiff_t.
4483 (charset_compare): Don't overflow if priorities differ greatly.
4484 (Fsort_charsets): Don't assume list length fits in int.
4485 Check for size-calculation overflow when allocating sort data.
4486 (syms_of_charset): Allocate an initial charset table that is
4487 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4488
4489 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4490
4491 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4492 The actual value is always <= INT_MAX, and leaving it unsigned made
4493 overflow checking harder.
4494
4495 * dispextern.h (struct glyph_matrix.rows_allocated)
4496 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4497 with xpalloc. The values are still always <= INT_MAX.
4498
4499 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4500
4501 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4502 (SAFE_NALLOCA): New macro.
4503
4504 * region-cache.c (struct boundary.pos, find_cache_boundary)
4505 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4506 (set_cache_region, invalidate_region_cache)
4507 (revalidate_region_cache, know_region_cache, region_cache_forward)
4508 (region_cache_backward, pp_cache):
4509 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4510 so that ptrdiff_t * can be passed to xpalloc.
4511 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4512 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4513 (pp_cache): Don't assume cache_len fits in int.
4514 * region-cache.h: Adjust extern decls to match.
4515
4516 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4517 EMACS_INT, since either will do, for xpalloc.
4518
4519 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4520 (xnmalloc, xnrealloc, xpalloc): New functions.
4521
726e0ab1
PE
4522 * bidi.c (bidi_shelve_header_size): New constant.
4523 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4524 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4525
51f30bc5 4526 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4527 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4528 (overlay_strings):
4529 Don't update size of array until after memory allocation succeeds,
4530 because xmalloc/xrealloc may not return.
0065d054
PE
4531 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4532 now that we have proper integer overflow checking.
4533 (record_overlay_string, overlay_strings): Catch overflows when
4534 calculating size of overlay_str_buf.
726e0ab1 4535
0065d054
PE
4536 * callproc.c (Fcall_process): Check for size overflow when
4537 calculating size of args2.
4538 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4539 Normally we prefer signed values, but sticking with ptrdiff_t would
4540 require adding more-complicated checks.
726e0ab1
PE
4541
4542 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4543 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4544 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4545 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4546
4547 * character.c (Fstring): Check for size-calculation overflow.
4548
4549 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4550 unnecessary integer overflow. Check for size overflow.
4551 (encode_coding_object): Don't update size until xmalloc succeeds.
4552
4553 * composite.c (get_composition_id): Check for overflow in glyph
4554 length calculations.
4555
4556 Integer and memory overflow fixes for display code.
4557 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4558 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4559 (scrolling_window): Check for overflow in size calculations.
4560 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4561 Don't assume glyph table len fits in int.
4562 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4563 (row_table_size): Now ptrdiff_t, not int.
4564 (scrolling_window): Avoid overflow in size calculations.
4565 Don't update size until allocation succeeds.
4566 * fns.c (concat): Check for overflow in size calculations.
4567 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4568 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4569 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4570
4571 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4572 (get_doc_string): Check for size calculation overflow.
4573 Don't update size until allocation succeeds.
4574 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4575 EMACS_INT, where ptrdiff_t will do.
4576 (Fsubstitute_command_keys): Check for string overflow.
4577
4578 * editfns.c (set_time_zone_rule): Don't assume environment length
4579 fits in int.
4580 (message_length): Now ptrdiff_t, not int.
4581 (Fmessage_box): Don't update size until allocation succeeds.
4582 Don't assume message length fits in int.
4583 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4584
0065d054
PE
4585 * emacs.c (main): Do not reallocate argv, since there is a null at
4586 the end that can be overwritten, and this way there's no need to
4587 worry about size-calculation overflow.
4588 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4589
4590 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4591 alloc succeeds.
4592 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4593
4594 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4595 (x_set_scroll_bar_width, x_figure_window_size):
4596 Check for integer overflow.
4597 (x_set_alpha): Do not assume XINT fits in int.
4598
4599 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4600 This is for the members text_lines, text_cols, total_lines, total_cols,
4601 where the system imposes an 'int' limit.
4602
4603 * fringe.c (Fdefine_fringe_bitmap):
4604 Don't update size until alloc works.
4605
4606 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4607 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4608
4609 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4610 Check for size-calculation overflow.
4611 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4612 do, as we prefer signed integers.
4613 (id_to_widget.max_size, id_to_widget.used)
4614 (xg_store_widget_in_map, xg_remove_widget_from_map)
4615 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4616 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4617 Use and return ptrdiff_t, not int.
4618 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4619 * gtkutil.h: Change prototypes to match the above.
4620
4621 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4622 are duplicate now that they've been promoted to lisp.h.
4623 (x_allocate_bitmap_record, x_alloc_image_color)
4624 (make_image_cache, cache_image, xpm_load):
4625 Don't update size until alloc is done.
4626 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4627 (x_detect_edges):
3256efce 4628 Check for size calculation overflow.
726e0ab1
PE
4629 (ct_colors_allocated_max): New constant.
4630 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4631 overflow.
3256efce 4632
726e0ab1
PE
4633 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4634 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4635 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4636 Use ptrdiff_t, not int, to count maps.
4637 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4638 calculations. Don't update size until allocation succeeds.
4639 Redo calculations to avoid overflow.
726e0ab1
PE
4640 * keyboard.h: Change prototypes to match the above.
4641
4642 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4643 to count maps.
4644 (current_minor_maps): Check for size calculation overflow.
4645 * keymap.h: Change prototypes to match the above.
4646
4647 * lread.c (read1, init_obarray): Don't update size until alloc done.
4648
4649 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4650 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4651
726e0ab1
PE
4652 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4653 Now ptrdiff_t, not int.
4654 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4655 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4656
4657 * process.c (Fnetwork_interface_list): Check for overflow
4658 in size calculation.
4659
4660 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4661
4662 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4663 overflow. Don't bother calling xmalloc when xrealloc will do.
4664
4665 * search.c (Freplace_match): Check for size calculation overflow.
4666 (Fset_match_data): Don't assume list lengths fit in 'int'.
4667
4668 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4669 for command line length. Do not attempt to address one before the
4670 beginning of an array, as that's not portable.
4671
4672 * term.c (max_frame_lines): Remove; unused.
4673 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4674 not int.
4675 (encode_terminal_code, calculate_costs): Check for size
4676 calculation overflow.
4677 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4678 table lengths and related sizes. Don't update size until alloc
4679 done. Redo calculations to avoid overflow.
4680 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4681
4682 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4683 subtracting pointers.
4684 (gobble_line): Check for overflow more carefully. Don't update size
4685 until alloc done.
4686
4687 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4688 Don't update size until alloc done.
4689 Redo size calculations to avoid overflow.
4690 Check for size calculation overflow.
0065d054 4691 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4692
4693 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4694 Use ptrdiff_t, not int, for sizes.
4695 (store_mode_line_noprop_char): Don't update size until alloc done.
4696
0065d054
PE
4697 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4698 Use ptrdiff_t, not int, for sizes.
4699 (Finternal_make_lisp_face, cache_face):
4700 Check for size calculation overflow.
4701 (cache_face): Treat size calculation overflows as if they were
4702 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4703
4704 * xfns.c (x_encode_text, x_set_name_internal)
4705 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4706 sizes, since they can exceed INT_MAX in size. Check for size
4707 calculation overflow.
4708
0065d054
PE
4709 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4710 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4711 Don't update size until alloc done.
4712
0065d054 4713 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4714 as sprintf is limited to int lengths.
1d526e2f 4715
252c5ee1
PE
4716 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4717 (X_LONG_MIN): New macros.
864d7ce7
PE
4718 Use them to make the following changes clearer.
4719 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4720 This change doesn't affect the value now, but it may help remind
4721 future maintainers not to raise the value too much later.
4722 (SELECTION_QUANTUM): Remove, replacing with ...
4723 (selection_quantum): ... new function, which avoids overflow.
4724 All uses changed.
4725 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4726 assumption that selection length fits in 'int'.
4727 (x_reply_selection_request, x_handle_selection_request)
4728 (x_get_window_property, receive_incremental_selection)
4729 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4730 (lisp_data_to_selection_data, clean_local_selection_data):
4731 Use ptrdiff_t, not int, to record length of selection.
4732 (x_reply_selection_request, x_get_window_property)
4733 (receive_incremental_selection, x_property_data_to_lisp):
4734 Redo calculations to avoid overflow.
4735 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4736 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4737 something.
4738 (x_get_window_property, receive_incremental_selection)
4739 (lisp_data_to_selection_data, x_property_data_to_lisp):
4740 Check for size-calculation overflow.
4741 (x_get_window_property, receive_incremental_selection)
4742 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4743 Don't store size until memory allocation succeeds.
4744 (x_get_window_property): Plug memory leak on memory exhaustion.
4745 Don't double-block input; malloc is safe here. Don't assume 2**34
4746 - 4 fits in unsigned long. Add an xassert to check
4747 XGetWindowProperty overflow. Be more careful about overflow
4748 calculations, and distinguish size from memory overflow better.
4749 (receive_incremental_selection): When tracing, don't assume
4750 unsigned int is less than INT_MAX.
4751 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4752 harmful) conversions of unsigned short to int.
4753 (lisp_data_to_selection_data): Don't assume that integers
4754 in the range -65535 through -1 fit in an X unsigned short.
4755 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4756 result parameters unless successful. Rely on cons_to_unsigned
4757 to report problems with elements; the old code wasn't right anyway.
4758 (x_check_property_data): Check for int overflow; we cannot use
4759 a wider type due to X limits.
4760 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4761
726e0ab1 4762 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4763
0065d054
PE
4764 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4765 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4766 (x_color_cells): Don't store size until memory allocation succeeds.
4767 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4768 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4769 (x_term_init): Don't assume length fits in int (sprintf is limited
4770 to int size).
bc18e09d 4771
ebfa62c0
PE
4772 Use ptrdiff_t for composition IDs.
4773 * character.c (lisp_string_width):
4774 * composite.c (composition_table_size, n_compositions)
4775 (get_composition_id, composition_gstring_from_id):
4776 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4777 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4778 * window.c (Frecenter):
4779 Use ptrdiff_t, not int, for composition IDs.
4780 * composite.c (get_composition_id): Check for integer overflow.
4781 * composite.h: Adjust prototypes to match the above changes.
4782
d3411f89
PE
4783 Use ptrdiff_t for hash table indexes.
4784 * category.c (hash_get_category_set):
4785 * ccl.c (ccl_driver):
4786 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4787 * coding.c (coding_system_charset_list, detect_coding_system):
4788 * coding.h (struct coding_system.id):
4789 * composite.c (get_composition_id, gstring_lookup_cache):
4790 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4791 * image.c (xpm_get_color_table_h):
4792 * lisp.h (hash_lookup, hash_put):
4793 * minibuf.c (Ftest_completion):
4794 Use ptrdiff_t for hash table indexes, not int (which is too
4795 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4796 32-bit --with-wide-int hosts).
4797
e097a6fa
PE
4798 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4799 Add a FIXME comment about memory leaks.
4800 (syms_of_charset): Don't assume xmalloc returns.
4801
5637687f
PE
4802 Don't assume that stated character widths fit in int.
4803 * character.c (Fchar_width, c_string_width, lisp_string_width):
4804 * character.h (CHAR_WIDTH):
4805 * indent.c (MULTIBYTE_BYTES_WIDTH):
4806 Use sanitize_char_width to avoid undefined and/or bad behavior
4807 with outlandish widths.
a66cfb1c 4808 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4809 now that we have two such functions. All uses changed.
4810 (sanitize_char_width): New inline function.
4811
a2271ba2
PE
4812 Don't assume that tab-width fits in int.
4813 * character.h (sanitize_width): New inline function.
4814 (SANE_TAB_WIDTH): New macro.
4815 (ASCII_CHAR_WIDTH): Use it.
4816 * indent.c (sane_tab_width): Remove. All uses replaced by
4817 SANE_TAB_WIDTH (current_buffer).
4818 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4819
18c52557
PE
4820 * fileio.c: Integer overflow issues with file modes.
4821 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4822
caeeedc1
PE
4823 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4824 Remove unreachable code.
4825 (read_hex, load_charset_map_from_file): Check for integer overflow.
4826
6df6ae42 4827 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4828 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4829 (x_send_scroll_bar_event): Likewise. Check that the size does not
4830 exceed limits imposed by XClientMessageEvent, as well as the usual
4831 ptrdiff_t and size_t limits.
4832
b13995db
PE
4833 * keyboard.c: Overflow, signedness and related fixes.
4834 (make_lispy_movement): Use same integer type in forward decl
4835 that is used in the definition.
4836 (read_key_sequence, keyremap_step):
4837 Change bufsize argument back to int, undoing my 2011-03-30 change.
4838 We prefer signed types, and int is wide enough here.
4839 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4840 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4841 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4842 length, not size_t. Use ptrdiff_t for index, not int.
4843 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4844 possibility of integer overflow.
4845
13464394
PE
4846 Overflow, signedness and related fixes for images.
4847
4848 * dispextern.h (struct it.stack[0].u.image.image_id)
4849 (struct_it.image_id, struct image.id, struct image_cache.size)
4850 (struct image_cache.used, struct image_cache.ref_count):
4851 * gtkutil.c (update_frame_tool_bar):
4852 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4853 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4854 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4855 * nsmenu.m (update_frame_tool_bar):
4856 * xdisp.c (calc_pixel_width_or_height):
4857 * xfns.c (image_cache_refcount):
4858 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4859 on typical 64-bit hosts.
4860
4861 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4862 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4863 Omit unnecessary casts to int.
4864 (parse_image_spec): Check that integers fall into 'int' range
4865 when the callers expect that.
4866 (image_ascent): Redo ascent calculation to avoid int overflow.
4867 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4868 (lookup_image): Remove unnecessary tests.
4869 (xbm_image_p): Locals are now of int, not EMACS_INT,
4870 since parse_image_check makes sure they fit into int.
4871 (png_load, gif_load, svg_load_image):
4872 Prefer int to unsigned where either will do.
4873 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4874 old tiff_error_handler and tiff_warning_handler.
4875 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4876 stack buffer overflows. It uses only the features of vsnprintf
4877 that are common to both POSIX and native Microsoft.
4878 (tiff_error_handler, tiff_warning_handler): Use it.
4879 (tiff_load, gif_load, imagemagick_load_image):
4880 Don't assume :index value fits in 'int'.
4881 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4882 (imagemagick_load_image): Check that crop parameters fit into
4883 the integer types that MagickCropImage accepts. Don't assume
4884 Vimagemagick_render_type has a nonnegative value. Don't assume
4885 size_t fits in 'long'.
4886 (gs_load): Use printmax_t to print the widest integers possible.
4887 Check for integer overflow when computing image height and width.
4888
c11821d4
EZ
48892011-08-26 Eli Zaretskii <eliz@gnu.org>
4890
4891 * xdisp.c (redisplay_window): Don't force window start if point
4892 will be invisible in the resulting window. (Bug#9324)
4893
0c95fcf7
EZ
48942011-08-25 Eli Zaretskii <eliz@gnu.org>
4895
4896 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4897 the display spec is of the form `(space ...)'.
4898 (handle_display_spec): Return the value returned by
4899 handle_single_display_spec, not just 1 or zero.
4900 (handle_single_display_spec): If the display spec is of the form
4901 `(space ...)', and specifies display in the text area, return 2
4902 rather than 1.
fee65a97 4903 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4904 accurately, and prefer exact match for point under bidi.
4905 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4906
4907 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4908 into disp_prop; all users changed.
4909
4910 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4911 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4912 for the text covered by the display property.
4913
e4ed06f1
CY
49142011-08-25 Chong Yidong <cyd@stupidchicken.com>
4915
4916 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4917 Change return value to nil.
4918 (Frecord_buffer): Delete unused function.
4919
f67cdd7f
EZ
49202011-08-24 Eli Zaretskii <eliz@gnu.org>
4921
5980d4c6
EZ
4922 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4923 buffers, return left-to-right.
8610fe8b
EZ
4924 (set_cursor_from_row): Consider candidate row a win if its glyph
4925 represents a newline and point is on that newline. Fixes cursor
4926 positioning on the newline at EOL of R2L text within L2R
4927 paragraph, and vice versa.
4928 (try_cursor_movement): Check continued rows, in addition to
4929 continuation rows. Fixes unwarranted scroll when point enters a
4930 continued line of R2L text within an L2R paragraph, or vice versa.
4931 (cursor_row_p): Consider the case of point being equal to
4932 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4933 from the end of a short line to the beginning of a continued line
4934 of R2L text within L2R paragraph.
4935 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4936 composed characters.
5980d4c6 4937
f67cdd7f
EZ
4938 * bidi.c (bidi_check_type): Use xassert.
4939 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4940 members.
4941
bca633fb
EZ
49422011-08-23 Eli Zaretskii <eliz@gnu.org>
4943
4944 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4945 a character.
4946
4a5885a7
CY
49472011-08-23 Chong Yidong <cyd@stupidchicken.com>
4948
4949 * nsfont.m (ns_otf_to_script): Fix typo.
4950
0902a04e
KH
49512011-08-22 Kenichi Handa <handa@m17n.org>
4952
4953 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4954 extra slot even if the purpose is char-code-property-table.
4955
1a2e6670
EZ
49562011-08-23 Eli Zaretskii <eliz@gnu.org>
4957
8ddde651
EZ
4958 * xdisp.c (redisplay_window): When computing centering_position,
4959 account for the height of the header line. (Bug#8874)
4960
425cc014
EZ
4961 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4962 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4963 candidate is selected by the mouse, and that candidate has a
4964 composed character under the mouse.
4965
1a2e6670
EZ
4966 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4967 coordinates reported by pos-visible-in-window-p for a composed
4968 character in column zero.
4969
8b76d6f8
SM
49702011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4971
4972 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4973
dac347dd
EZ
49742011-08-22 Eli Zaretskii <eliz@gnu.org>
4975
4976 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4977 consider it a hit if to_charpos is anywhere in the range of the
4978 composed buffer positions.
4979
e013fb34
CY
49802011-08-22 Chong Yidong <cyd@stupidchicken.com>
4981
4982 * image.c (gif_load): Don't assume that each subimage has the same
4983 dimensions as the base image. Handle disposal method that is
4984 "undefined" by the gif spec (Bug#9335).
4985
bd1ba3e8
CY
49862011-08-20 Chong Yidong <cyd@stupidchicken.com>
4987
4988 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4989 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4990
54a1215b
EZ
49912011-08-19 Eli Zaretskii <eliz@gnu.org>
4992
823564e5
EZ
4993 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4994 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4995 from an Org mode buffer to a Speedbar frame.
4996
54a1215b
EZ
4997 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4998 a composition, take its buffer position from IT->cmp_it.charpos.
4999 Fixes cursor positioning at the beginning of a line that begins
5000 with a composed character.
5001
9778ebcc
EZ
50022011-08-18 Eli Zaretskii <eliz@gnu.org>
5003
0be6ee06
EZ
5004 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5005 character bidirectional type, use STRONG_L instead. Fixes crashes
5006 in a buffer produced by `describe-categories'.
5007
9778ebcc
EZ
5008 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5009 members before the level stack, so they would be saved and
5010 restored when copying iterator state. Fixes incorrect reordering
5011 around TABs covered by display properties.
5012
156bffbe
AS
50132011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5014
6b02f655 5015 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5016
72ad093b
CY
50172011-08-17 Chong Yidong <cyd@stupidchicken.com>
5018
5019 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5020 (internal_condition_case_2, internal_condition_case_n):
5021 Remove unnecessary aborts (Bug#9081).
72ad093b 5022
35774242
EZ
50232011-08-17 Eli Zaretskii <eliz@gnu.org>
5024
5025 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5026 has no `load' handler, try opening the file locally. (Bug#9311)
5027
db76dd85
KB
50282011-08-16 Ken Brown <kbrown@cornell.edu>
5029
5030 * gmalloc.c: Expand comment.
5031
b215eee5
EZ
50322011-08-16 Eli Zaretskii <eliz@gnu.org>
5033
5034 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5035 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5036
a4579d33
KB
50372011-08-16 Ken Brown <kbrown@cornell.edu>
5038
5039 Fix memory allocation problems in Cygwin build (Bug#9273).
5040
5041 * unexcw.c ( __malloc_initialized): Declare external variable.
5042 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5043
8b76d6f8
SM
5044 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5045 New variables.
a4579d33
KB
5046 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5047 dumped emacs.
5048 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5049 in the static heap.
5050 [CYGWIN] (special_realloc): New function.
5051 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5052 requests to realloc storage in the static heap.
5053
3ebec551
PE
50542011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5055
5056 * bidi.c (bidi_initialize): Remove unused local.
5057
9fd8be00
EZ
50582011-08-15 Eli Zaretskii <eliz@gnu.org>
5059
6b02f655
SM
5060 * bidimirror.h:
5061 * biditype.h: Remove file.
5062 * makefile.w32-in ($(BLD)/bidi.$(O)):
5063 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5064
5065 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5066
5067 * chartab.c: Improve commentary for the uniprop_table API.
5068
32413314
EZ
5069 * bidi.c (bidi_paragraph_init): Support zero value of
5070 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5071 (bidi_initialize): Use uniprop_table instead of including
5072 biditype.h and bidimirror.h.
32413314 5073
9fd8be00
EZ
5074 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5075 coordinates of the iterator when restoring from ppos_it.
5076 (Bug#9296)
5077
5cf2b69b
KH
50782011-08-14 Kenichi Handa <handa@m17n.org>
5079
5080 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5081 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5082
daf17d00
EZ
50832011-08-14 Eli Zaretskii <eliz@gnu.org>
5084
5085 * xdisp.c (move_it_in_display_line_to): Don't invoke
5086 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5087 ppos_it. Fixes vertical cursor motion when line beginning is
5088 covered by an image. (Bug#9296)
5089
08e3161a
JD
50902011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5091
5092 * nsterm.h (ns_run_ascript): Declare.
5093 (NSAPP_DATA2_RUNASSCRIPT): Define.
5094
5095 * nsfns.m (as_script, as_result, as_status): New static variables.
5096 (ns_run_ascript): New function.
5e617bc2 5097 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5098 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5099 the event loop. Get status from as_status (Bug#7276).
5100
5101 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5102 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5103 the event loop (Bug#7276).
5104
a3720aa2
AS
51052011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5106
5107 * gnutls.c (QCgnutls_bootprop_priority)
5108 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5109 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5110 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5111 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5112 (QCgnutls_bootprop_verify_hostname_error)
5113 (QCgnutls_bootprop_callbacks_verify): Rename from
5114 Qgnutls_bootprop_..., all uses changed.
5115
5116 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5117 uses changed.
5118
0a0d27fb
PE
51192011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5120
19d5c50c
PE
5121 * xfaces.c (Qframe_set_background_mode): Now static.
5122 * dispextern.h (Qframe_set_background_mode): Remove decl.
5123
0a0d27fb
PE
5124 * process.c (Fnetwork_interface_info): Declare local only if needed.
5125
377538cb
JD
51262011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5127
5128 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5129 (Fnetwork_interface_list): Allocate in increments of bytes instead
5130 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5131 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5132 sockaddr.
5133 (struct ifflag_def): notrailers is smart on OSX.
5134 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5135 Get hardware address with getifaddrs if available.
5136
08fff70c
EZ
51372011-08-12 Eli Zaretskii <eliz@gnu.org>
5138
5139 * xdisp.c (iterate_out_of_display_property): xassert that
5140 IT->position is set to within IT->object's boundaries. Break from
5141 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5142 when IT->position is set up wrongly due to some bug.
5143 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5144 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5145 entry. Force push_it to save on the stack the current
5146 buffer/string position, to be restored by pop_it. Fix flags in
5147 the iterator structure wrt the object coming from a display
5148 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5149 properties. (Bug#9284)
5150
7be1c708 51512011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5152
7be1c708
CY
5153 * fontset.c (fontset_get_font_group): Add proper type checks.
5154 (Bug#9172)
aac0c6e3 5155
7be1c708 51562011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5157
7be1c708
CY
5158 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5159 and LC_VERSION_MIN_MACOSX.
5160 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5161 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5162
97bb72a6
EZ
51632011-08-08 Eli Zaretskii <eliz@gnu.org>
5164
5165 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5166 no-display-properties-and-no-overlays under bidi display.
5167 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5168 properties and overlays.
97bb72a6 5169
d5617611
CY
51702011-08-08 Chong Yidong <cyd@stupidchicken.com>
5171
37e11a63
CY
5172 * editfns.c (Fset_time_zone_rule): Document relationship with the
5173 setenv function.
5174
d5617611
CY
5175 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5176 the font entity extracted from the cache (Bug#8109).
5177
58872834
CY
51782011-08-07 Chong Yidong <cyd@stupidchicken.com>
5179
5180 * composite.c (autocmp_chars): Don't reset point. That is done by
5181 restore_point_unwind (Bug#5984).
5182
75bfc667
JL
51832011-08-07 Juri Linkov <juri@jurta.org>
5184
5185 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5186 to show the arg `TIME' instead of `TIMEVAL'.
5187
d1410150
EZ
51882011-08-06 Eli Zaretskii <eliz@gnu.org>
5189
5190 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5191 display property strides EOL and includes a newline, as in
5192 longlines-mode. (Bug#9254)
75b771e4
EZ
5193 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5194 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5195
5196 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5197 is non-zero, even if the data buffer is NULL. Fixes a crash in
5198 vertical-motion with longlines-mode. (Bug#9254)
5199
35928349
EZ
52002011-08-05 Eli Zaretskii <eliz@gnu.org>
5201
ec7cc85b
EZ
5202 * bidi.c <bidi_cache_total_alloc>: Now static.
5203 (bidi_initialize): Initialize bidi_cache_total_alloc.
5204
8b76d6f8 5205 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5206 cache. (Bug#9221)
5207
5208 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5209 amount allocated this far in `bidi_cache_total_alloc'.
5210 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5211 non-zero, only free the data buffer without restoring the cache
5212 contents. All callers changed.
5213
5214 * dispextern.h (bidi_unshelve_cache): Update prototype.
5215
5216 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5217 (move_it_in_display_line, move_it_to)
5218 (move_it_vertically_backward, move_it_by_lines): Replace the call
5219 to xfree to an equivalent call to bidi_unshelve_cache.
5220 (move_it_in_display_line_to): Fix logic of returning
412b6358 5221 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5222
e2e2423b
EZ
52232011-08-05 Eli Zaretskii <eliz@gnu.org>
5224
5225 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5226 came from a string character with a `cursor' property. (Bug#9229)
5227
ae9e757a
JD
52282011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5229
5230 * Makefile.in (LIB_PTHREAD): New variable.
5231 (LIBES): Add LIB_PTHREAD (Bug#9216).
5232
5233 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5234 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5235
213bd7f2
AS
52362011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5237
6b02f655 5238 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5239
99aaf75f
JD
52402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5241
5242 * xterm.c (x_find_topmost_parent): New function.
5243 (x_set_frame_alpha): Find topmost parent window with
5244 x_find_topmost_parent and set the property there also (bug#9181).
5245 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5246
c74e9d86
PE
52472011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5248
5249 * callproc.c (Fcall_process): Avoid vfork clobbering
5250 the local vars buffer, coding_systems, current_dir.
5251
640c8776
SM
52522011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5253
5254 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5255
f26d0e4c
PE
52562011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5257
8a10d76c
PE
5258 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5259 so that it is not optimized away.
5260
f26d0e4c
PE
5261 * xdisp.c (compute_display_string_pos): Remove unused local.
5262
55439c61
EZ
52632011-08-02 Eli Zaretskii <eliz@gnu.org>
5264
5265 Fix slow cursor motion and scrolling in large buffers with
5266 selective display, like Org Mode buffers. (Bug#9218)
5267
5268 * dispextern.h (struct bidi_it): New member disp_prop_p.
5269
5270 * xdisp.c: Remove one-slot cache of display string positions.
5271 (compute_display_string_pos): Accept an additional argument
5e617bc2 5272 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5273 for a display string or property. If found, set DISP_PROP_P
5274 non-zero.
5275
5276 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5277 DISP_PROP_P, and pass it to compute_display_string_pos.
5278 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5279 non-zero. All callers of bidi_fetch_char changed.
5280
fb33fa43
SM
52812011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5282
5283 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5284
b099e063
DM
52852010-12-03 Don March <don@ohspite.net>
5286
5287 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5288 last character M-[char] is translated to ESC [char] (bug#7541).
5289
5cc7f7af
KH
52902011-08-02 Kenichi Handa <handa@m17n.org>
5291
d0fffa3f 5292 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5293
5294 * chartab.c (uniprop_table): Make it non-static.
5295
525d5e6e
EZ
52962011-08-01 Eli Zaretskii <eliz@gnu.org>
5297
5298 * xdisp.c (forward_to_next_line_start): Accept additional argument
5299 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5300 on the newline.
5301 (reseat_at_next_visible_line_start): Use the bidi iterator state
5302 returned by forward_to_next_line_start to restore the state of
5303 it->bidi_it after backing up to previous newline. (Bug#9212)
5304
31011111
AS
53052011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5306
5307 * regex.c (re_comp): Protoize.
5308 (re_exec): Fix return type.
5309 (regexec): Fix type of `ret'. (Bug#9203)
5310
476371c4
PE
53112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5312
e5d76069
PE
5313 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5314 This is needed if max-image-size is a floating-point number.
5315
9a79b20c
AS
53162011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5317
5318 * print.c (print_object): Print empty symbol as ##.
5319
5320 * lread.c (read1): Read ## as empty symbol.
5321
d8c2fa78
AA
53222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5323
5324 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5325 setting frame foreground color (Bug#9175).
5326 (x_set_background_color): Likewise.
5327
ffe57a7a
AA
5328 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5329 contents (Bug#9176).
5330 (EmacsTooltip -init): Remove bezels and add shadows to
5331 tooltip windows.
5332
bf3492a5
AA
5333 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5334 or scroll bar (Bug#8470).
5335
d55e9c53
AA
5336 * nsfont.m (nsfont_open): Remove assignment to voffset and
5337 unnecessary vars hshink, expand, hd, full_height, min_height.
5338 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5339
5340 * nsterm.h (nsfont_info): Remove voffset field.
5341
d8c2fa78 53422011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5343
5344 Implement strike-through and overline on NextStep (Bug#8863).
5345
5346 * nsfont.m (nsfont_open): Use underline position provided by font,
5347 instead of hard-coded value of 2.
5348 (nsfont_draw): Call ns_draw_text_decoration instead.
5349
5350 * nsterm.h: Add declaration for ns_draw_text_decoration.
5351
5352 * nsterm.m (ns_draw_text_decoration): New function for drawing
5353 underline, overline, and strike-through.
5354 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5355 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5356 accommodate underlining, etc.
4843aac3 5357
4cc60b9b
EZ
53582011-07-28 Eli Zaretskii <eliz@gnu.org>
5359
bc7ece87
EZ
5360 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5361 default.
4cc60b9b 5362
476371c4
PE
53632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5364
66606eea
PE
5365 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5366 Without this fix, if a signal arrives just after memory fills up,
5367 'malloc' might be invoked reentrantly.
5368
476371c4
PE
5369 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5370 In other words, assume that every image size is allowed, on non-X
5371 hosts. This assumption is probably wrong, but it lets Emacs compile.
5372
f3fcc40d
AS
53732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5374
5375 * regex.c (re_iswctype): Convert return values to boolean.
5376
350c992f
EZ
53772011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5378
5379 * xdisp.c (compute_display_string_pos): Don't use cached display
5380 string position if the buffer had its restriction changed.
5381 (Bug#9184)
5382
5266b4bb
PE
53832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5384
5385 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5386
2573a837 53872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5388
41f55ccd 5389 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5390
39e378da
PE
5391 * bidi.c: Integer size and overflow fixes.
5392 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5393 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5394 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5395 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5396 (bidi_find_other_level_edge):
5397 Use ptrdiff_t instead of EMACS_INT where either will do.
5398 This works better on 32-bit hosts configured --with-wide-int.
5399 (bidi_cache_ensure_space): Check for size-calculation overflow.
5400 Use % rather than repeated addition, for better worst-case speed.
5401 Don't set bidi_cache_size until after xrealloc returns, because it
5402 might not return.
5403 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5404 (bidi_cache_ensure_space): Also check that the bidi cache size
5405 does not exceed that of the largest Lisp string or buffer. See Eli
5406 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5407
5e927815
PE
5408 * alloc.c (__malloc_size_t): Remove.
5409 All uses replaced by size_t. See Andreas Schwab's note
5410 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5411
ca4aa935
PE
5412 * image.c: Improve checking for integer overflow.
5413 (check_image_size): Assume that f is nonnull, since
5414 it is always nonnull in practice. This is one less thing to
5415 worry about when checking for integer overflow later.
5416 (x_check_image_size): New function, which checks for integer
5417 overflow issues inside X.
5418 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5419 This removes the need for a memory_full check.
5420 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5421 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5422 (xbm_read_bitmap_data): Change locals back to 'int', since
5423 their values must fit in 'int'.
5424 (xpm_load_image, png_load, tiff_load):
5425 Invoke x_create_x_image_and_pixmap earlier,
5426 to avoid much needless work if the image is too large.
5427 (tiff_load): Treat overly large images as if
5428 x_create_x_image_and_pixmap failed, not as malloc failures.
5429 (gs_load): Use x_check_image_size.
5430
5f8f9cc2
PE
5431 * gtkutil.c: Omit integer casts.
5432 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5433 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5434
5adf60bc
PE
5435 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5436
c8907a93
PE
5437 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5438 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5439 would wrongly return t on a 64-bit host.
5440
e3c25c68
PE
5441 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5442 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5443 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5444 and therefore cause GCC to emit a bogus diagnostic in some cases.
5445
3f791afe
PE
5446 * image.c: Integer signedness and overflow and related fixes.
5447 This is not an exhaustive set of fixes, but it's time to
5448 record what I've got.
5449 (lookup_pixel_color, check_image_size): Remove redundant decls.
5450 (check_image_size): Don't assume that arbitrary EMACS_INT values
5451 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5452 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5453 (tiff_load, imagemagick_load_image):
5454 Check for overflow in size calculations.
5455 (x_create_x_image_and_pixmap): Remove unnecessary test for
5456 xmalloc returning NULL; that can't happen.
5457 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5458 (xpm_color_bucket): Use better integer hashing function.
5459 (xpm_cache_color): Don't possibly over-allocate memory.
5460 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5461 (gif_memory_source):
5462 Use ptrdiff_t, not int or size_t, to record sizes.
5463 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5464 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5465 either works, as we prefer signed integers.
5466 (tiff_read_from_memory, tiff_write_from_memory):
5467 Return tsize_t, not size_t, since that's what the TIFF API wants.
5468 (tiff_read_from_memory): Don't fail simply because the read would
5469 go past EOF; instead, return a short read.
5470 (tiff_load): Omit no-longer-needed casts.
5471 (Fimagemagick_types): Don't assume size fits into 'int'.
5472
3cc5a532
PE
5473 Improve hashing quality when configured --with-wide-int.
5474 * fns.c (hash_string): New function, taken from sxhash_string.
5475 Do not discard information about ASCII character case; this
5476 discarding is no longer needed.
5477 (sxhash-string): Use it. Change sig to match it. Caller changed.
5478 * lisp.h: Declare it.
5479 * lread.c (hash_string): Remove, since we now use fns.c's version.
5480 The fns.c version returns a wider integer if --with-wide-int is
5481 specified, so this should help the quality of the hashing a bit.
5482
b312a492
PE
5483 * emacs.c: Integer overflow minor fix.
5484 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5485 Define only if GNU_LINUX.
5486 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5487
dfd153ae
PE
5488 * dispnew.c: Integer signedness and overflow fixes.
5489 Remove unnecessary forward decls, that were a maintenance hassle.
5490 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5491 All uses changed.
5492 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5493 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5494 (prepare_desired_row, line_draw_cost):
5495 Use int, not unsigned, where either works.
5496 (save_current_matrix, restore_current_matrix):
5497 Use ptrdiff_t, not size_t, where either works.
5498 (init_display): Check for overflow more accurately, and without
5499 relying on undefined behavior.
5500
a81d11a3
PE
5501 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5502 Remove, replacing with the new symbols in lisp.h. All uses changed.
5503 * fileio.c (make_temp_name):
5504 * filelock.c (lock_file_1, lock_file):
5505 * xdisp.c (message_dolog):
5506 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5507 Use pMd etc. instead.
5508 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5509 replacing the pWIDE etc. symbols removed from editfns.c.
5510
3300e6fd
PE
5511 * keyboard.h (num_input_events): Now uintmax_t.
5512 This is (very slightly) less likely to mess up due to wraparound.
5513 All uses changed.
5514
fd05c7e9
PE
5515 * buffer.c: Integer signedness fixes.
5516 (alloc_buffer_text, enlarge_buffer_text):
5517 Use ptrdiff_t rather than size_t when either will do, as we prefer
5518 signed integers.
5519
903fe15d
PE
5520 * alloc.c: Integer signedness and overflow fixes.
5521 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5522 (__malloc_size_t): Default to size_t, not to int.
5523 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5524 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5525 Prefer ptrdiff_t to size_t when either would do, as we prefer
5526 signed integers.
5527 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5528 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5529 Now const. Initialize with values that are in range even if char
5530 is signed.
5531 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5532 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5533 These functions do the right thing with sizes > 2**32.
5534 (check_depth): Now ptrdiff_t, not int.
5535 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5536 Adjust to new way of storing sizes. Check for size overflow bugs
5537 in rest of code.
5538 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5539 slightly wrong anyway, as it missed one instance of
5540 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5541 (refill_memory_reserve): Omit needless cast to size_t.
5542 (mark_object_loop_halt): Mark as externally visible.
5543
ac82cc6a
PE
5544 * xselect.c: Integer signedness and overflow fixes.
5545 (Fx_register_dnd_atom, x_handle_dnd_message):
5546 Use ptrdiff_t, not size_t, since we prefer signed.
5547 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5548 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5549 x_dnd_atoms_size and x_dnd_atoms_length.
5550
c2d1e36d
PE
5551 * doprnt.c: Prefer signed to unsigned when either works.
5552 * eval.c (verror):
5553 * doprnt.c (doprnt):
5554 * lisp.h (doprnt):
5555 * xdisp.c (vmessage):
5556 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5557 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5558 prefer signed arithmetic to avoid comparison confusion.
5559 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5560 but is a bit tricky.
5561
0e926e56
PE
5562 Assume freestanding C89 headers, string.h, stdlib.h.
5563 * data.c, doprnt.c, floatfns.c, print.c:
5564 Include float.h unconditionally.
5565 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5566 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5567 * regex.c: Likewise for stddef.h, string.h.
5568 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5569 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5570 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5571 (STDC_HEADERS): Remove obsolete defines.
5572 * sysdep.c: Include limits.h unconditionally.
5573
9cfdb3ec
PE
5574 Assume support for memcmp, memcpy, memmove, memset.
5575 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5576 * regex.c (memcmp, memcpy):
5577 Remove; we assume C89 now.
5578
5579 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5580 (__malloc_safe_bcopy): Remove; no longer needed.
5581
cf950e6b 5582 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5583 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5584 well either way, and we prefer signed to unsigned.
5585
dbf38e02
LMI
55862011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5587
5588 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5589 closes the connection while we're reading (bug#9182).
5590
d6f0886c 55912011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5592
d6f0886c
JD
5593 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5594 are specified (Bug#9168).
24e0f6b1 5595
2eb1f9e6
PE
55962011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5597
5598 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5599 Found by GCC static checking and --with-wide-int on a 32-bit host.
5600
22381272 56012011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5602
5603 * xdisp.c (compute_display_string_pos): Fix logic of caching
5604 previous display string position. Initialize cached_prev_pos to
5605 -1. Fixes slow-down at the beginning of a buffer.
5606
f25e39b4
EZ
56072011-07-24 Eli Zaretskii <eliz@gnu.org>
5608
5609 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5610 for attrs[LFACE_FONTSET_INDEX].
5611
04c4b52e
PE
56122011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5613
5614 * xml.c (parse_region): Remove unused local
5615 that was recently introduced.
5616
c1734fbd
EZ
56172011-07-23 Eli Zaretskii <eliz@gnu.org>
5618
be18c5a5
EZ
5619 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5620 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5621
c1734fbd
EZ
5622 * xdisp.c (move_it_in_display_line_to): Record the best matching
5623 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5624 exit if none of the characters scanned was an exact match.
5625 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5626 when exact match is impossible due to invisible text, and the
5627 lines are truncated.
5628
a258d627
JD
56292011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5630
5631 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5632 for OSX >= 10.7.
5633
b6d5a689
EZ
56342011-07-22 Eli Zaretskii <eliz@gnu.org>
5635
0f74f785
EZ
5636 Fix a significant slow-down of cursor motion with C-n, C-p,
5637 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5638 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5639 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5640 (next_element_from_buffer): Call compute_stop_pos_backwards to
5641 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5642 base_level_stop.
5643 (reseat): Don't look for prev_stop, as that could mean a very long
5644 run.
5645 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5646 <cached_disp_overlay_modiff>: Cache for last found display string
5647 position.
551918c1 5648 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5649 about the same buffer in the same area of character positions, and
5650 the buffer wasn't changed since the time the display string
5651 position was cached.
551918c1 5652
b2d0c91a
EZ
56532011-07-22 Eli Zaretskii <eliz@gnu.org>
5654
5655 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5656 is an integer, which is important for empty lines. (Bug#9149)
5657
043604ee
CY
56582011-07-22 Chong Yidong <cyd@stupidchicken.com>
5659
5660 * frame.c (Fmodify_frame_parameters): In tty case, update the
5661 default face if necessary (Bug#4238).
5662
da4adb04
CY
56632011-07-21 Chong Yidong <cyd@stupidchicken.com>
5664
5665 * editfns.c (Fstring_to_char): No need to explain what a character
5666 is in the docstring (Bug#6576).
5667
9abd0532
LMI
56682011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5669
5670 * xml.c (parse_region): Make sure we always return a tree.
5671
36881d16
HK
56722011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5673
5674 * xml.c (parse_region): If a document contains only comments,
5675 return that, too.
5676
1e98674d
LMI
56772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5678
5679 * xml.c (make_dom): Return comments, too.
5680
590bd467
PE
56812011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5682
5683 Port to OpenBSD.
5684 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5685 and the surrounding thread.
5686 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5687 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5688 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5689 timer goes off.
5690 * s/openbsd.h (BROKEN_SIGIO): Define.
5691 * unexelf.c (unexec) [__OpenBSD__]:
5692 Don't update the .mdebug section of the Alpha COFF symbol table.
5693
f41628b2
LMI
56942011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5695
5696 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5697 (bug#8460).
5698
b59b67c5
PE
56992011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5700
15e3a074
PE
5701 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5702 This fixes some race conditions on the permissions of any newly
5703 created file.
5704
41bed37d
PE
5705 * alloc.c (valid_pointer_p): Use pipe, not open.
5706 This fixes some permissions issues when debugging.
5707
b59b67c5
PE
5708 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5709 If fchown fails to set both uid and gid, try to set just gid,
5710 as that is sometimes allowed. Adjust the file's mode to eliminate
5711 setuid or setgid bits that are inappropriate if fchown fails.
5712
925a6be7
SM
57132011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5714
5715 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5716 to compare Lisp_Objects.
5717 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5718 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5719 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5720
52968808
AS
57212011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5722
0a6a104b
AS
5723 * lread.c (read_integer): Unread even EOF character.
5724 (read1): Likewise. Properly record start position of symbol.
5725
52968808
AS
5726 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5727 symbol character follows.
5728
9e381cdd
PE
57292011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5730
5731 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5732 This works around a problem with the previous change to Fcopy_file.
5733 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5734 and without this change, GCC might complain about discarding
5735 fchown's return value.
5736
b5641435
JB
57372011-07-16 Juanma Barranquero <lekktu@gmail.com>
5738
5739 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5740
a8031457
PE
57412011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5742
5743 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5744
dd889327
LMI
57452011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5746
750c33f7
LMI
5747 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5748 it's used from the C level.
5749
dd889327
LMI
5750 * process.c: Use the same condition for POLL_FOR_INPUT in both
5751 keyboard.c and process.c (bug#1858).
5752
87e86684
LM
57532011-07-09 Lawrence Mitchell <wence@gmx.li>
5754
5755 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5756 (Fgnutls_boot): Use it.
5757
64348f40
AS
57582011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5759
5760 * doc.c (Fsubstitute_command_keys): Revert last change.
5761
1d698799
LMI
57622011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5763
f863868c
LMI
5764 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5765 quotes the next character, and doesn't affect other longer
5766 sequences (bug#8935).
5767
1d698799
LMI
5768 * lread.c (syms_of_lread): Clarify that is isn't only
5769 `eval-buffer' and `eval-defun' that's affected by
5770 `lexical-binding' (bug#8460).
5771
aa4b6df6
EZ
57722011-07-15 Eli Zaretskii <eliz@gnu.org>
5773
5774 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5775 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5776
5d856da6
PE
57772011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5778
ad6042bb
PE
5779 Fix minor problems found by static checking.
5780 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5781 (elsz): Now a signed constant, not a size_t var. We prefer signed
5782 types to unsigned, to avoid integer comparison confusion. Without
5783 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5784 "cannot optimize loop, the loop counter may overflow", a symptom
5785 of the confusion.
f00bbb22 5786 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5787 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5788
6468f31c
LMI
57892011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5790
49080b10
LMI
5791 * search.c (Fre_search_backward): Mention `case-fold-search' in
5792 all the re_search_* functions (bug#8138).
5793
6468f31c
LMI
5794 * keyboard.c (Fopen_dribble_file): Document when the file is
5795 closed (bug#8056).
5796
c965adc5
EZ
57972011-07-14 Eli Zaretskii <eliz@gnu.org>
5798
df9733bf
EZ
5799 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5800 bidi_cache_idx.
5801
0bb23927
EZ
5802 Support bidi reordering of display and overlay strings.
5803 * xdisp.c (compute_display_string_pos)
5804 (compute_display_string_end): Accept additional argument STRING.
5805 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5806 (reseat_to_string): Initialize bidi_it->string.s and
5807 bidi_it->string.schars.
5808 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5809 NULL (avoids a crash in bidi_paragraph_init).
5810 Initialize itb.string.lstring.
0bb23927
EZ
5811 (init_iterator): Call bidi_init_it only of a valid
5812 buffer position was specified. Initialize paragraph_embedding to
5813 L2R.
5814 (reseat_to_string): Initialize the bidi iterator.
5815 (display_string): If we need to ignore text properties of
5816 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5817 original value of -1 will not work with bidi.)
5818 (compute_display_string_pos): First arg is now struct
5819 `text_pos *'; all callers changed. Support display properties on
5820 Lisp strings.
5821 (compute_display_string_end): Support display properties on Lisp
5822 strings.
5823 (init_iterator, reseat_1, reseat_to_string): Initialize the
5824 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5825 when iterating on a string not from display properties).
640c8776
SM
5826 (compute_display_string_pos, compute_display_string_end):
5827 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5828 arrow keys.
5829 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5830 base_level_stop; instead, set base_level_stop to BEGV.
5831 Fixes crashes in vertical-motion.
0bb23927
EZ
5832 (next_element_from_buffer): Improve commentary for when
5833 the iterator is before prev_stop.
5834 (init_iterator): Initialize bidi_p from the default value of
5835 bidi-display-reordering, not from buffer-local value. Use the
5836 buffer-local value only if initializing for buffer iteration.
5837 (handle_invisible_prop): Support invisible properties on strings
5838 that are being bidi-reordered.
5839 (set_iterator_to_next): Support bidi reordering of C strings and
5840 Lisp strings.
5841 (next_element_from_string): Support bidi reordering of Lisp
5842 strings.
5843 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5844 (display_string): Support display of R2L glyph rows.
5845 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5846 (init_iterator): Don't initialize it->bidi_p for strings
5847 here.
5848 (reseat_to_string): Initialize it->bidi_p for strings here.
5849 (next_element_from_string, next_element_from_c_string)
5850 (next_element_from_buffer): Add xassert's for correspondence
5851 between IT's object being iterated and it->bidi_it.string
5852 structure.
5853 (face_before_or_after_it_pos): Support bidi iteration.
5854 (next_element_from_c_string): Handle the case of the first string
5855 character that is not the first one in the visual order.
5856 (get_visually_first_element): New function, refactored from common
5857 parts of next_element_from_buffer, next_element_from_string, and
5858 next_element_from_c_string.
5859 (tool_bar_lines_needed, redisplay_tool_bar)
5860 (display_menu_bar): Force left-to-right direction. Add a FIXME
5861 comment for making that be controlled by a user option.
5862 (push_it, pop_it): Save and restore the state of the
5863 bidi iterator. Save and restore the bidi_p flag.
5864 (pop_it): Iterate out of display property for string iteration as
5865 well.
5866 (iterate_out_of_display_property): Support iteration over strings.
5867 (handle_single_display_spec): Set up it->bidi_it for iteration
5868 over a display string, and call bidi_init_it.
5869 (handle_single_display_spec, next_overlay_string)
5870 (get_overlay_strings_1, push_display_prop): Set up the bidi
5871 iterator for displaying display or overlay strings.
5872 (forward_to_next_line_start): Don't use the shortcut if
5873 bidi-iterating.
5874 (back_to_previous_visible_line_start): If handle_display_prop
5875 pushed the iterator stack, restore the internal state of the bidi
5876 iterator by calling bidi_pop_it same number of times.
5877 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5878 and we are bidi-iterating, don't decrement the iterator position;
5879 instead, set the first_elt flag in the bidi iterator, to produce
5880 the same effect.
5881 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5882 (push_display_prop): xassert that we are iterating a buffer.
5883 (push_it, pop_it): Save and restore paragraph_embedding member.
5884 (handle_single_display_spec, next_overlay_string)
5885 (get_overlay_strings_1, reseat_1, reseat_to_string)
5886 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5887 correctly. Don't assume unibyte strings are not bidi-reordered.
5888 (compute_display_string_pos)
5889 (compute_display_string_end): Fix handling the case of C string.
5890 (push_it, pop_it): Save and restore from_disp_prop_p.
5891 (handle_single_display_spec, push_display_prop): Set the
5892 from_disp_prop_p flag.
5893 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5894 (pop_it): Call iterate_out_of_display_property only if we are
5895 popping after iteration over a string that came from a display
5896 property. Fix a typo in popping stretch info. Add an assertion
5897 for verifying that the iterator position is in sync with the bidi
5898 iterator.
5899 (handle_single_display_spec, get_overlay_strings_1)
5900 (push_display_prop): Fix initialization of paragraph direction for
5901 string when that of the parent object is not yet determined.
5902 (reseat_1): Call bidi_init_it to resync the bidi
5903 iterator with IT's position. (Bug#7616)
5904 (find_row_edges): If ROW->start.pos gives position
5905 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5906 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5907 Reset the from_disp_prop_p flag.
5908 (SAVE_IT, RESTORE_IT): New macros.
5909 (pos_visible_p, face_before_or_after_it_pos)
5910 (back_to_previous_visible_line_start)
5911 (move_it_in_display_line_to, move_it_in_display_line)
5912 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5913 (try_scrolling, redisplay_window, display_line): Use them when
5914 saving a temporary copy of the iterator and restoring it back.
5915 (back_to_previous_visible_line_start, reseat_1)
5916 (init_iterator): Empty the bidi cache "stack".
5917 (move_it_in_display_line_to): If iterator ended up at
5918 EOL, but we never saw any buffer positions smaller than
5919 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5920 motion in bidi-reordered lines.
5921 (move_it_in_display_line_to): Record prev_method and prev_pos
5922 immediately before the call to set_iterator_to_next. Fixes cursor
5923 motion in bidi-reordered lines with stretch glyphs and strings
5924 displayed in margins. (Bug#8133) (Bug#8867)
5925 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5926 TO_CHARPOS.
640c8776
SM
5927 (pos_visible_p): Support positions in bidi-reordered lines.
5928 Save and restore bidi cache.
0bb23927
EZ
5929
5930 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5931 (bidi_paragraph_info): Delete unused struct.
5932 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5933 (bidi_cache_start): New variable.
5934 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5935 to zero.
5936 (bidi_cache_fetch_state, bidi_cache_search)
5937 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5938 (bidi_cache_find, bidi_peek_at_next_level)
5939 (bidi_level_of_next_char, bidi_find_other_level_edge)
5940 (bidi_move_to_visually_next): Compare cache index with
5941 bidi_cache_start rather than with zero.
5942 (bidi_fetch_char): Accept new argument STRING; all callers
5943 changed. Support iteration over a string. Support strings with
5944 display properties. Support unibyte strings. Fix the type of
5945 `len' according to what STRING_CHAR_AND_LENGTH expects.
5946 (bidi_paragraph_init, bidi_resolve_explicit_1)
5947 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5948 (bidi_level_of_next_char, bidi_move_to_visually_next):
5949 Support iteration over a string.
0bb23927
EZ
5950 (bidi_set_sor_type, bidi_resolve_explicit_1)
5951 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5952 can now be zero (for strings); special values 0 and -1 were
5953 changed to -1 and -2, respectively.
5954 (bidi_char_at_pos): New function.
5955 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5956 Call it instead of FETCH_MULTIBYTE_CHAR.
5957 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5958 initialized to valid values.
5959 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5960 values.
5961 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5962 the test for valid cached positions. Fix the logic for looking up
5963 the sentinel state in the cache. GCPRO the Lisp string we are
5964 iterating.
5965 (bidi_push_it, bidi_pop_it): New functions.
5966 (bidi_initialize): Initialize the bidi cache start stack pointer.
5967 (bidi_cache_ensure_space): New function, refactored from part of
5968 bidi_cache_iterator_state. Don't assume the required size is just
5969 one BIDI_CACHE_CHUNK away.
5970 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5971 (bidi_count_bytes, bidi_char_at_pos): New functions.
5972 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5973 always valid if bidi_cache_idx is valid.
5974 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5975 is valid if it's going to be used.
5976 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5977 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5978 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5979 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5980 (bidi_find_other_level_edge, bidi_cache_start_stack):
5981 All variables related to cache indices are now EMACS_INT.
c965adc5 5982
0bb23927
EZ
5983 * dispextern.h (struct bidi_string_data): New structure.
5984 (struct bidi_it): New member `string'. Make flag members be 1-bit
5985 fields, and put them last in the struct.
640c8776
SM
5986 (compute_display_string_pos, compute_display_string_end):
5987 Update prototypes.
0bb23927
EZ
5988 (bidi_push_it, bidi_pop_it): Add prototypes.
5989 (struct iterator_stack_entry): New members bidi_p,
5990 paragraph_embedding, and from_disp_prop_p.
5991 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5992 (bidi_shelve_cache, bidi_unshelve_cache):
5993 Declare prototypes.
0bb23927
EZ
5994
5995 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5996 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5997 and vector-like objects.
5998
5999 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6000 cache around display iteration.
6001
6002 * window.c (Fwindow_end, window_scroll_pixel_based)
6003 (displayed_window_lines, Frecenter): Save and restore the bidi
6004 cache around display iteration.
6005
3bbd2265
LMI
60062011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6007
6008 * editfns.c (Fdelete_region): Clarify the use of the named
6009 parameters (bug#6788).
6010
adc47434
MR
60112011-07-14 Martin Rudalics <rudalics@gmx.at>
6012
6013 * indent.c (Fvertical_motion): Set and restore w->pointm when
6014 saving and restoring the window's buffer (Bug#9006).
6015
837c31f8
LMI
60162011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6017
6018 * editfns.c (Fstring_to_char): Clarify just what is returned
6019 (bug#6576). Text by Eli Zaretskii.
6020
ac389d0c
JB
60212011-07-13 Juanma Barranquero <lekktu@gmail.com>
6022
6023 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6024
0be0ce47
EZ
60252011-07-13 Eli Zaretskii <eliz@gnu.org>
6026
6027 * buffer.c (mmap_find): Fix a typo.
6028
cd18e7e3
JB
60292011-07-13 Johan Bockgård <bojohan@gnu.org>
6030
6031 Fix execution of x selection hooks.
6032 * xselect.c (Qx_lost_selection_functions)
6033 (Qx_sent_selection_functions): New vars.
6034 (syms_of_xselect): DEFSYM them.
6035 (x_handle_selection_request): Pass Qx_sent_selection_functions
6036 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6037 (x_handle_selection_clear,x_clear_frame_selections):
6038 Pass Qx_lost_selection_functions rather than
6039 Vx_lost_selection_functions to Frun_hook_with_args.
6040
47ea7f44
PE
60412011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6042
ac389d0c 6043 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6044 The old code sometimes used this field without initializing it.
6045
47ea7f44
PE
6046 * alloc.c (gc_sweep): Don't read past end of array.
6047 In theory, the old code could also have corrupted Emacs internals,
6048 though it'd be very unlikely.
6049
bc985c87
AS
60502011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6051
6052 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6053 argument. (Bug#4026)
bc985c87 6054
0cf34688
LMI
60552011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6056
b3dadd76
LMI
6057 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6058 key" (bug#4257).
6059
0cf34688
LMI
6060 * window.c (Fset_window_start): Doc fix (bug#4199).
6061 (Fset_window_hscroll): Ditto.
6062
270768cd
PE
60632011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6064
077e3dda 6065 Fix minor new problems caught by GCC 4.6.1.
270768cd 6066 * term.c (init_tty): Remove unused local.
490011a6 6067 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6068 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6069 not used otherwise.
270768cd 6070
b1f58454
CY
60712011-07-12 Chong Yidong <cyd@stupidchicken.com>
6072
6073 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6074
22b9578d
LMI
60752011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6076
6e70ab07
LMI
6077 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6078 are the mini-buffer and the echo area (bug#3320).
6079
22b9578d
LMI
6080 * term.c (init_tty): Remove support for supdup, c10 and perq
6081 terminals, which are no longer supported (bug#1482).
6082
8974cc9f
JB
60832011-07-10 Johan Bockgård <bojohan@gnu.org>
6084
6085 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6086
a560d974
JD
60872011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6088
6089 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6090 for non-popups (Bug#3642).
6091
1dae0f0a
AS
60922011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6093
268c2c36 6094 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6095 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6096 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6097 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6098 * data.c (fmod): Likewise.
6099 * dispnew.c (swap_glyphs_in_rows): Likewise.
6100 * emacs.c (memory_warning_signal): Likewise.
6101 * floatfns.c (float_error): Likewise.
6102 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6103 (otf_open, font_otf_capability, generate_otf_features)
6104 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6105 Likewise.
6106 * image.c (pbm_read_file): Likewise.
6107 * indent.c (string_display_width): Likewise.
6108 * intervals.c (check_for_interval, search_for_interval)
6109 (inc_interval_count, count_intervals, root_interval)
6110 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6111 * lread.c (defalias): Likewise.
268c2c36 6112 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6113 * regex.c (set_image_of_range_1, set_image_of_range)
6114 (regex_grow_registers): Likewise.
6115 * sysdep.c (strerror): Likewise.
6116 * termcap.c (valid_filename_p, tprint, main): Likewise.
6117 * tparam.c (main): Likewise.
6118 * unexhp9k800.c (run_time_remap, save_data_space)
6119 (update_file_ptrs, read_header, write_header, calculate_checksum)
6120 (copy_file, copy_rest, display_header): Likewise.
6121 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6122 Likewise.
6123 * xdisp.c (check_it): Likewise.
6124 * xfaces.c (register_color, unregister_color, unregister_colors):
6125 Likewise.
6126 * xfns.c (print_fontset_result): Likewise.
6127 * xrdb.c (member, fatal, main): Likewise.
6128
99033785
PE
61292011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6130
6131 Fix minor problems found by static checking (Bug#9031).
6132 * chartab.c (char_table_set_range, map_sub_char_table):
6133 Remove unused locals.
6134 (uniprop_table): Now static.
6135 * composite.c (_work_char): Remove unused static var.
6136
9cb2ac56
JB
61372011-07-09 Juanma Barranquero <lekktu@gmail.com>
6138
6139 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6140
f25661f0
JD
61412011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6142
6143 * gtkutil.c (qttip_cb): Remove code without function.
6144
8278c4fe
EZ
61452011-07-09 Eli Zaretskii <eliz@gnu.org>
6146
6147 * w32.c (pthread_sigmask): New stub.
6148
1692ae2d 61492011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6150
8a6ebd58 6151 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6152 sigprocmask is portable only for single-threaded applications, and
6153 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6154 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6155 (LIBES): Use it.
6156 * callproc.c (Fcall_process):
6157 * process.c (create_process):
6158 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6159 Use pthread_sigmask, not sigprocmask.
123403e4 6160
1b854618
JD
61612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6162
6163 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6164 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6165 wrong (Bug#8591).
6166
3fe4b549
JD
61672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6168
0ce7e563
JD
6169 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6170 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6171 (xg_hide_tooltip): Fix comment.
6172
3fe4b549
JD
6173 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6174 in registerServicesMenuSendTypes.
6175 (validRequestorForSendType): Don't check ns_return_types.
6176
6177 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6178 ns_return_type.
6179
5df75e47
JR
61802011-07-08 Jason Rumney <jasonr@gnu.org>
6181
22610910
JR
6182 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6183 SH_SHOW for hidden windows (Bug#5482).
6184
5df75e47
JR
6185 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6186 frame struct members of non-existent frames (Bug#6284).
6187
699c10bd
JD
61882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6189
4393663b
JD
6190 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6191 variable firstTime not needed on OSX >= 10.6.
6192 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6193 >= 10.5. Use setKnobProportion, setDoubleValue.
6194
6195 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6196 (MAC_OS_X_VERSION_10_5): Define if not defined.
6197 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6198 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6199 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6200
6201 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6202 cString and lossyCString on OSX >= 10.4
6203
58179cce 6204 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6205 sizeToFit on OSX >= 10.2.
6206
6207 * nsimage.m (allocInitFromFile): Don't use deprecated method
6208 bestRepresentationForDevice on OSX >= 10.6.
6209
6210 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6211 to avoid warning.
6212
6213 * emacs.c: Declare unexec_init_emacs_zone.
6214
a63e0781
JD
6215 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6216
699c10bd
JD
6217 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6218
6219 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6220 on svcsMenu (Bug#8842).
6221
6222 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6223 ns_return_types.
6224 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6225
6226 * nsterm.m (QUTF8_STRING): Declare.
6227 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6228 (validRequestorForSendType): Return type is (id).
6229 Change indexOfObjectIdenticalTo to indexOfObject.
6230 Check if we have local selection before returning self (Bug#8842).
6231 (writeSelectionToPasteboard): Put local selection into paste board
6232 if we have a local selection (Bug#8842).
6233 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6234
6235 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6236 (ns_get_local_selection): Declare.
6237
54e10184
LMI
62382011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6239
9888ff71
LMI
6240 * keymap.c (describe_map_tree): Don't insert a double newline at
6241 the end of the buffer (bug#1169) and return whether we inserted
6242 something.
6243
54e10184
LMI
6244 * callint.c (Fcall_interactively): Change "reading args" to
6245 "providing args" to try to clarify what it does (bug#1010).
6246
15fa4783
KH
62472011-07-07 Kenichi Handa <handa@m17n.org>
6248
6249 * composite.c (composition_compute_stop_pos): Ignore a static
6250 composition starting before CHARPOS (Bug#8915).
6251
6252 * xdisp.c (handle_composition_prop): Likewise.
6253
a8815b00
EZ
62542011-07-07 Eli Zaretskii <eliz@gnu.org>
6255
6256 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6257 (Bug#9015)
6258
ef7b981d 62592011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6260
6261 * character.h (unicode_category_t): New enum type.
6262
6263 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6264 (Qchar_code_property_table): New variable.
6265 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6266 (UNIPROP_COMPRESSED_FORM_P): New macros.
6267 (char_table_ascii): Uncompress the compressed values.
6268 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6269 Uncompress the compressed values.
ac389d0c 6270 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6271 (char_table_ref_and_range): Uncompress the compressed values.
6272 (sub_char_table_set): New arg is_uniprop. Callers changed.
6273 Uncompress the compressed values.
6274 (sub_char_table_set_range): Args changed. Callers changed.
6275 (char_table_set_range): Adjuted for the above change.
6276 (map_sub_char_table): Delete args default_val and parent. Add arg
6277 top. Give decoded values to a Lisp function.
640c8776 6278 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6279 values to a Lisp function. Gcpro more variables.
6280 (uniprop_table_uncompress)
6281 (uniprop_decode_value_run_length): New functions.
6282 (uniprop_decoder, uniprop_decoder_count): New variables.
6283 (uniprop_get_decoder, uniprop_encode_value_character)
6284 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6285 New functions.
6286 (uniprop_encoder, uniprop_encoder_count): New variables.
6287 (uniprop_get_encoder, uniprop_table)
6288 (Funicode_property_table_internal, Fget_unicode_property_internal)
6289 (Fput_unicode_property_internal): New functions.
6290 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6291 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6292 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6293 char-code-property-alist.
6294
640c8776 6295 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6296 Vunicode_category_table.
6297
640c8776 6298 * font.c (font_range): Adjust for the change of
c805dec0
KH
6299 Vunicode_category_table.
6300
76b397fb
DN
63012011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6302
6303 * m/iris4d.h: Remove file, move contents ...
6304 * s/irix6-5.h: ... here.
6305
22b4128e
PE
63062011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6307
6308 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6309 * alloc.c (mark_buffer):
6310 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6311 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6312 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6313 This isn't true in general, and it's particularly not true
6314 if Emacs is configured with --with-wide-int.
6315 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6316 New macros, used in the buffer.c change.
6317
869795d6
JD
63182011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6319
6320 * xsettings.c: Use both GConf and GSettings if both are available.
6321 (store_config_changed_event): Add comment.
6322 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6323 (store_tool_bar_style_changed): New functions.
5e617bc2 6324 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6325 (struct xsettings): Move font inside HAVE_XFT.
6326 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6327 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6328 Move inside HAVE_XFT.
640c8776 6329 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6330 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6331 also.
6332 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6333 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6334 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6335 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6336 (parse_settings): Move check for font inside HAVE_XFT.
6337 (read_settings, apply_xft_settings): Add comment.
6338 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6339 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6340 call store_font_name_changed.
6341 (xft_settings_event): Add comment.
6342 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6343 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6344 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6345 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6346 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6347 (xsettings_get_system_font, xsettings_get_system_normal_font):
6348 Add comment.
869795d6 6349
d8ed26bd
PE
63502011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6351
6352 Random fixes. E.g., (random) never returned negative values.
6353 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6354 subseconds part to the entropy, as that's a bit more random.
6355 Prefer signed to unsigned, since the signedness doesn't matter and
6356 in general we prefer signed. When given a limit, use a
6357 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6358 latter isn't right if USE_2_TAGS_FOR_INTS.
6359 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6360 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6361
cabf1cac
SM
63622011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6363
6364 * textprop.c (text_property_stickiness):
6365 Obey Vtext_property_default_nonsticky.
6366 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6367 * w32fns.c (syms_of_w32fns):
6368 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6369
6e9b2be9
PE
63702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6371
6372 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6373 This is more efficient than Ffile_directory_p and avoids a minor race.
6374
90186c68
LMI
63752011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6376
7c301272
LMI
6377 * buffer.c (Foverlay_put): Say what the return value is
6378 (bug#7835).
6379
c4f2d8d4
LMI
6380 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6381 is a directory before asking whether to use the file name
6382 (bug#7564).
ad637907
LMI
6383 (barf_or_query_if_file_exists): Make the "File is a directory"
6384 error be more correct.
c4f2d8d4 6385
90186c68
LMI
6386 * fns.c (Frequire): Remove the mention of the .gz files, since
6387 that's installation-specific, but keep the mention of
6388 `get-load-suffixes'.
6389
da64016e
PE
63902011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6391
6392 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6393 Report string overflow if the output is too long.
6394
7d47b580
JB
63952011-07-04 Juanma Barranquero <lekktu@gmail.com>
6396
a555cb87
JB
6397 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6398 (syms_of_gnutls): Remove duplicate DEFSYM for
6399 Qgnutls_bootprop_verify_hostname_error, an error for
6400 Qgnutls_bootprop_verify_error (which is no longer used).
6401
7d47b580
JB
6402 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6403 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6404 Also (re)move comments that are misplaced or no longer relevant.
6405
1e49bfab
LMI
64062011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6407
6408 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6409
1485f4c0
CY
64102011-07-03 Chong Yidong <cyd@stupidchicken.com>
6411
6412 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6413 and background color parameters if they have been changed.
6414
a9ab721e
LMI
64152011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6416
6417 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6418
cf7cff57
PE
64192011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6420
2e13213d
PE
6421 * xsettings.c (SYSTEM_FONT): Define only when used.
6422 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6423
cf7cff57
PE
6424 * keymap.c (access_keymap_1): Now static.
6425
7a8e04f7
CY
64262011-07-02 Chong Yidong <cyd@stupidchicken.com>
6427
6428 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6429 leave any prefix arg for the up event (Bug#1586).
6430
61352f62
LMI
64312011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6432
69bb1ef7
LMI
6433 * lread.c (syms_of_lread): Mention single symbols defined by
6434 `defvar' or `defconst' (bug#7154).
6435
61352f62 6436 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6437 (Frequire): Mention get-load-suffixes.
61352f62 6438
28545e04
MR
64392011-07-02 Martin Rudalics <rudalics@gmx.at>
6440
6441 * window.h (window): Remove clone_number slot.
6442 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6443 Remove.
6444 (make_parent_window, make_window, saved_window)
6445 (Fset_window_configuration, save_window_save): Don't deal with
6446 clone numbers.
6447 * buffer.c (Qclone_number): Remove declaration.
6448 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6449
3349e122
SM
64502011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6451
6452 Add multiple inheritance to keymaps.
6453 * keymap.c (Fmake_composed_keymap): New function.
6454 (Fset_keymap_parent): Simplify.
6455 (fix_submap_inheritance): Remove.
6456 (access_keymap_1): New function extracted from access_keymap to handle
6457 embedded parents and handle lists of maps.
6458 (access_keymap): Use it.
6459 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6460 (Fcopy_keymap): Handle embedded parents.
6461 (Fcommand_remapping, define_as_prefix): Simplify.
6462 (Fkey_binding): Simplify.
6463 (syms_of_keymap): Move minibuffer-local-completion-map,
6464 minibuffer-local-filename-completion-map,
6465 minibuffer-local-must-match-map, and
6466 minibuffer-local-filename-must-match-map to Elisp.
6467 (syms_of_keymap): Defsubr make-composed-keymap.
6468 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6469 (parse_menu_item): Trivial simplification.
6470
3279eb87
GM
64712011-07-01 Glenn Morris <rgm@gnu.org>
6472
6473 * Makefile.in (SETTINGS_LIBS): Fix typo.
6474
4550efdf
KI
64752011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6476
6477 * coding.c (Fencode_coding_string): Record the last coding system
6478 used, as the function doc string says (bug#8738).
6479
0949d2b6
JD
64802011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6481
6482 * xsettings.c (store_monospaced_changed): Take new font as arg and
6483 check for change against current_mono_font.
6484 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6485 (emacs_settings_constructor, emacs_settings_get_property)
6486 (emacs_settings_set_property, emacs_settings_class_init)
6487 (emacs_settings_init, gsettings_obj): Remove.
6488 (something_changedCB): New function for HAVE_GSETTINGS.
6489 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6490 with value as argument.
6491 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6492 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6493 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6494 "changed".
6495
6496 * xgselect.c: Add defined (HAVE_GSETTINGS).
6497 (xgselect_initialize): Ditto.
6498
6499 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6500 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6501 xg_select.
6502
bbc6b304
PE
65032011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6504
6505 * eval.c (struct backtrace): Simplify and port the data structure.
6506 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6507 signed bit field, as this assumption is not portable and it makes
6508 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6509 "char debug_on_exit : 1" as this is not portable either; instead,
6510 use the portable "unsigned int debug_on_exit : 1". Remove unused
6511 member evalargs. Remove obsolete comments about cc bombing out.
6512
9851bfc5
JD
65132011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6514
51bb811f 6515 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6516 Let HAVE_GSETTINGS override HAVE_GCONF.
6517 (store_monospaced_changed): New function.
6518 (EMACS_SETTINGS): A new type derived from GObject to handle
6519 GSettings notifications.
6520 (emacs_settings_constructor, emacs_settings_get_property)
6521 (emacs_settings_set_property, emacs_settings_class_init):
6522 New functions.
6523 (gsettings_client, gsettings_obj): New variables.
6524 (GSETTINGS_SCHEMA): New define.
6525 (something_changedCB): Call store_monospaced_changed.
6526 (init_gsettings): New function.
6527 (xsettings_initialize): Call init_gsettings.
6528 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6529 to NULL.
6530
640c8776 6531 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6532 GCONF_CFLAGS/LIBS.
6533
5386012d
MR
65342011-06-29 Martin Rudalics <rudalics@gmx.at>
6535
6536 * window.c (resize_root_window, grow_mini_window)
6537 (shrink_mini_window): Rename Qresize_root_window to
6538 Qwindow_resize_root_window and Qresize_root_window_vertically to
6539 Qwindow_resize_root_window_vertically.
6540
f13e0b08
PE
65412011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6542
6543 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6544
94515237
JB
65452011-06-27 Juanma Barranquero <lekktu@gmail.com>
6546
6547 * makefile.w32-in: Redesign dependencies so they reflect more
6548 clearly which files are directly included by each source file,
6549 and not through other includes.
6550
e43b6e43
MR
65512011-06-27 Martin Rudalics <rudalics@gmx.at>
6552
6553 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6554 (sort_overlays, overlay_strings): When an overlay's clone number
6555 matches the window's clone number process the overlay even if
6556 the overlay's window property doesn't match the current window.
6557
d68443dc
MR
6558 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6559 (Fwindow_hchild): Rename to Fwindow_left_child.
6560 (Fwindow_next): Rename to Fwindow_next_sibling.
6561 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6562 (resize_window_check): Rename to window_resize_check.
6563 (resize_window_apply): Rename to window_resize_apply.
6564 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6565 (Fdelete_other_windows_internal, resize_frame_windows)
6566 (Fsplit_window_internal, Fdelete_window_internal)
6567 (grow_mini_window, shrink_mini_window)
6568 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6569
c7e73be5
JD
65702011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6571
6572 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6573 (emacs_fixed_set_min_size): Remove.
6574 (emacs_fixed_new): Take frame as argument.
6575
6576 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6577 (_EmacsFixedPrivate): Remove minwidth/height.
6578 Add struct frame *f.
6579 (emacs_fixed_init): Initialize priv->f.
6580 (get_parent_class, emacs_fixed_set_min_size): Remove.
6581 (emacs_fixed_new): Set priv->f to argument.
6582 (emacs_fixed_get_preferred_width)
6583 (emacs_fixed_get_preferred_height): Use min_width/height from
6584 frames size_hint to set minimum and natural (Bug#8919).
6585 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6586 and use min_width/height from frames size_hint to set
6587 min_width/height (Bug#8919).
6588
6589 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6590 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6591 Fix indentation.
c7e73be5 6592
cf99dcf8
EZ
65932011-06-26 Eli Zaretskii <eliz@gnu.org>
6594
6595 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6596 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6597 called at ZV.
6598
029529ac
CY
65992011-06-26 Chong Yidong <cyd@stupidchicken.com>
6600
6601 * process.c (wait_reading_process_output): Bypass select if
6602 waiting for a cell while ignoring keyboard input, and input is
6603 pending. Suggested by Jan Djärv (Bug#8869).
6604
7a7ef429
PE
66052011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6606
6607 Use gnulib's dup2 module instead of rolling our own.
6608 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6609
11fdef7d 66102011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6611
6612 * dispnew.c (scrolling_window): Before scrolling, turn off a
6613 mouse-highlight in the window being scrolled.
6614
cd3520a4
JB
66152011-06-24 Juanma Barranquero <lekktu@gmail.com>
6616
6617 Move DEFSYM to lisp.h and use everywhere.
6618
6619 * character.h (DEFSYM): Move declaration...
6620 * lisp.h (DEFSYM): ...here.
6621
6622 * gnutls.c:
6623 * minibuf.c:
6624 * w32menu.c:
6625 * w32proc.c:
6626 * w32select.c: Don't include character.h.
6627
6628 * alloc.c (syms_of_alloc):
6629 * buffer.c (syms_of_buffer):
6630 * bytecode.c (syms_of_bytecode):
6631 * callint.c (syms_of_callint):
6632 * casefiddle.c (syms_of_casefiddle):
6633 * casetab.c (init_casetab_once):
6634 * category.c (init_category_once, syms_of_category):
6635 * ccl.c (syms_of_ccl):
6636 * cmds.c (syms_of_cmds):
6637 * composite.c (syms_of_composite):
6638 * dbusbind.c (syms_of_dbusbind):
6639 * dired.c (syms_of_dired):
6640 * dispnew.c (syms_of_display):
6641 * doc.c (syms_of_doc):
6642 * editfns.c (syms_of_editfns):
6643 * emacs.c (syms_of_emacs):
6644 * eval.c (syms_of_eval):
6645 * fileio.c (syms_of_fileio):
6646 * fns.c (syms_of_fns):
6647 * frame.c (syms_of_frame):
6648 * fringe.c (syms_of_fringe):
6649 * insdel.c (syms_of_insdel):
6650 * keymap.c (syms_of_keymap):
6651 * lread.c (init_obarray, syms_of_lread):
6652 * macros.c (syms_of_macros):
6653 * msdos.c (syms_of_msdos):
6654 * print.c (syms_of_print):
6655 * process.c (syms_of_process):
6656 * search.c (syms_of_search):
6657 * sound.c (syms_of_sound):
6658 * syntax.c (init_syntax_once, syms_of_syntax):
6659 * terminal.c (syms_of_terminal):
6660 * textprop.c (syms_of_textprop):
6661 * undo.c (syms_of_undo):
6662 * w32.c (globals_of_w32):
6663 * window.c (syms_of_window):
6664 * xdisp.c (syms_of_xdisp):
6665 * xfaces.c (syms_of_xfaces):
6666 * xfns.c (syms_of_xfns):
6667 * xmenu.c (syms_of_xmenu):
6668 * xsettings.c (syms_of_xsettings):
6669 * xterm.c (syms_of_xterm): Use DEFSYM.
6670
4228cf16
TZ
66712011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6672
cd3520a4 6673 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6674
7fcccf1e
PE
66752011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6676
7efb4e0e
PE
6677 Integer and buffer overflow fixes (Bug#8873).
6678
ff5844ad
PE
6679 * print.c (printchar, strout): Check for string overflow.
6680 (PRINTPREPARE, printchar, strout):
6681 Don't set size unless allocation succeeds.
6682
90532f02
PE
6683 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6684 for sizes. Check for string overflow more accurately.
6685 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6686
6d84508d
PE
6687 * macros.c: Integer and buffer overflow fixes.
6688 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6689 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6690 Use ptrdiff_t, not int, for sizes.
6691 Don't increment bufsize until after realloc succeeds.
6692 Check for size-calculation overflow.
6693 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6694
437b2cb4
PE
6695 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6696
8b9ac8b4
PE
6697 * lread.c: Integer overflow fixes.
6698 (read_integer): Radix is now EMACS_INT, not int,
6699 to improve quality of diagnostics for out-of-range radices.
6700 Calculate buffer size correctly for out-of-range radices.
6701 (read1): Check for integer overflow in radices, and in
6702 read-circle numbers.
82cb60d3
PE
6703 (read_escape): Avoid int overflow.
6704 (Fload, openp, read_buffer_size, read1)
6705 (substitute_object_recurse, read_vector, read_list, map_obarray):
6706 Use ptrdiff_t, not int, for sizes.
6707 (read1): Use EMACS_INT, not int, for sizes.
20270765 6708 Check for size overflow.
8b9ac8b4 6709
7fcccf1e
PE
6710 * image.c (cache_image): Check for size arithmetic overflow.
6711
bfbbd7e7
PE
6712 * lread.c: Integer overflow issues.
6713 (saved_doc_string_size, saved_doc_string_length)
6714 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6715 Now ptrdiff_t, not int.
6716 (read1): Don't assume doc string length fits in int. Check for
6717 out-of-range doc string lengths.
6718 (read_list): Don't assume file position fits in int.
39019e54 6719 (read_escape): Check for hex character overflow.
bfbbd7e7 6720
4e323265
LL
67212011-06-22 Leo Liu <sdl.web@gmail.com>
6722
6723 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6724 Move to minibuffer.el.
6725
85fece3e
PE
67262011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6727
20b84ce9 6728 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6729 The following patches are for when GLYPH_DEBUG && !XASSERT.
6730 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6731 * dispnew.c (flush_stdout):
6732 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6733 Mark as externally visible.
6734 * dispnew.c (check_window_matrix_pointers): Now static.
6735 * dispnew.c (window_to_frame_vpos):
6736 * xfns.c (unwind_create_frame):
6737 * xterm.c (x_check_font): Remove unused local.
6738 * scroll.c (CHECK_BOUNDS):
6739 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6740 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6741 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6742 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6743 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6744 Now static.
6745 (debug_method_add): Use va_list and vsprintf rather than relying
6746 on undefined behavior with wrong number of arguments.
6747 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6748 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6749 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6750 since we're not interested in debugging glyphs with old libraries.
6751 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6752 GCC 4.6.0's static checking.
6753
0766b489
PE
67542011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6755
31fd4b32
PE
6756 Integer overflow and signedness fixes (Bug#8873).
6757 A few related buffer overrun fixes, too.
6758
b79e8648
PE
6759 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6760
0766b489
PE
6761 * dispextern.h (struct face.stipple):
6762 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6763 (x_bitmap_mask, x_allocate_bitmap_record)
6764 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6765 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6766 (x_create_bitmap_from_xpm_data):
6767 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6768 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6769 (.bitmaps_last):
6770 * xfaces.c (load_pixmap):
6771 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6772 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6773 (.bitmaps_last, struct x_output.icon_bitmap):
6774 Use ptrdiff_t, not int, for bitmap indexes.
6775 (x_allocate_bitmap_record): Check for size overflow.
6776 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6777
b081724f
PE
6778 Use ptrdiff_t, not int, for overlay counts.
6779 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6780 * editfns.c (overlays_around, get_pos_property):
6781 * textprop.c (get_char_property_and_overlay):
6782 * xdisp.c (next_overlay_change, note_mouse_highlight):
6783 * xfaces.c (face_at_buffer_position):
21514da7
PE
6784 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6785 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6786 (Fnext_overlay_change, Fprevious_overlay_change)
6787 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6788 Use ptrdiff_t, not int, for sizes.
21514da7 6789 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6790
3de73e5e
PE
6791 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6792
2606c57b
PE
6793 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6794 (x_session_initialize): Do not assume string length fits in int.
6795
aaafe47a
PE
6796 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6797 This is unlikely, but can occur if DPI is outlandish.
6798
2674ddc8 6799 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6800 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6801
28154962
PE
6802 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6803 * xrdb.c (magic_file_p, search_magic_path):
6804 Omit last arg SUFFIX; it was always 0. All callers changed.
6805 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6806
7de51af5
PE
6807 * xfont.c (xfont_match): Avoid need for strlen.
6808
25ed6cc3
PE
6809 * xfns.c: Don't assume strlen fits in int.
6810 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6811
4eab31dd
PE
6812 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6813 not unsigned long, as we prefer signed integers. All callers changed.
6814 Detect integer overflow in repeat count.
6815 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6816 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6817
171e2a58
PE
6818 * termcap.c: Don't assume sizes fit in int and never overflow.
6819 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6820 (gobble_line): Check for size-calculation overflow.
6821
ad39faca 6822 * minibuf.c (Fread_buffer):
6e5bb2dc 6823 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6824 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6825 Don't assume string length fits in int.
6826
52c61c22 6827 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6828 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6829
b5b8c9e5
PE
6830 * font.c: Don't assume string length fits in int.
6831 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6832 Use ptrdiff_t, not int.
ccd6111c
PE
6833 (font_intern_prop): Don't assume string length fits in int.
6834 Don't assume integer property fits in fixnum.
6835 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6836
882f0d81 6837 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6838 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6839 Reformulate so as not to need the command string.
6840 Invoke gzip -cd rather than gunzip, as it's more portable.
6841 (lock_info_type, lock_file_1, lock_file):
6842 Don't assume pid_t and time_t fit in unsigned long.
6843 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6844 (current_lock_owner): Prefer signed type for sizes.
6845 Use memcpy, not strncpy, where memcpy is what is really wanted.
6846 Don't assume (via atoi) that time_t and pid_t fit in int.
6847 Check for time_t and/or pid_t out of range, e.g., via a network share.
6848 Don't alloca where an auto var works fine.
6849
93f4cf88
PE
6850 * fileio.c: Fix some integer overflow issues.
6851 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6852 Don't assume string length fits in int.
6853 (directory_file_name): Don't assume string length fits in long.
6854 (make_temp_name): Don't assume pid fits in int, or that its print
6855 length is less than 20.
6856
f3e92b69
PE
6857 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6858
1bfdaf10
PE
6859 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6860
35016e9a
PE
6861 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6862
3d1e65a1
PE
6863 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6864 We prefer signed integers, even for size calculations.
6865
0b963a93
PE
6866 * emacs.c: Don't assume string length fits in 'int'.
6867 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6868 (main): Don't invoke strlen when not needed.
6869
573f4b54
PE
6870 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6871 (XD_DEBUG_MESSAGE): Don't waste a byte.
6872
989f33ba
PE
6873 * callproc.c (getenv_internal_1, getenv_internal)
6874 (Fgetenv_internal):
965d34eb
PE
6875 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6876
e4d29b33
PE
6877 * lread.c (invalid_syntax): Omit length argument.
6878 All uses changed. This doesn't fix a bug, but it simplifies the
6879 code away from its former Hollerith-constant appearance, and it's
6880 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6881 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6882
eb49b136
PE
6883 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6884 This didn't break anything, but it didn't help either.
6885 It's confusing to put a bogus integer in a place where the actual
6886 value does not matter.
9f62aeb1 6887 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6888 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6889
15375a22
PE
6890 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6891 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6892 implementation.
b61cc01c
PE
6893 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6894 We prefer signed types, and the value cannot exceed the EMACS_INT
6895 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6896 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6897 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6898 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6899
53b2623d
PE
6900 * indent.c (sane_tab_width): New function.
6901 (current_column, scan_for_column, Findent_to, position_indentation)
6902 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6903 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6904
51cab52b 6905 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6906
f2ed8a70
PE
6907 * lisp.h (lint_assume): New macro.
6908 * composite.c (composition_gstring_put_cache):
6909 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6910
abe80cc6
PE
6911 * editfns.c, insdel.c:
6912 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6913
b02c740e
PE
6914 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6915
ebc96716
PE
6916 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6917
b4e50fa0 6918 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6919 Use much-faster test for byte-length change.
311d5d7c 6920 Don't assume string byte-length fits in 'int'.
a4cf38e4 6921 Check that character arg fits in 'int'.
85461888 6922 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6923
c0c1ee9f
PE
6924 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6925
a498d7f4
PE
6926 * fns.c (concat): Catch string overflow earlier.
6927 Do not rely on integer wraparound.
6928
51cab52b
PE
6929 * dispextern.h (struct it.overlay_strings_charpos)
6930 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6931 * xdisp.c (forward_to_next_line_start)
6932 (back_to_previous_visible_line_start)
6933 (reseat_at_next_visible_line_start, next_element_from_buffer):
6934 Don't arbitrarily truncate the value of 'selective' to int.
6935
76031fad
PE
6936 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6937
5eb55db9
PE
6938 * composite.c: Don't truncate sizes to 'int'.
6939 (composition_gstring_p, composition_reseat_it)
6940 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6941 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6942 not EMACS_UINT, for indexes.
5eb55db9 6943
0703a717
PE
6944 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6945
d6202519
PE
6946 * buffer.c: Include <verify.h>.
6947 (struct sortvec.priority, struct sortstr.priority):
8961a454 6948 Now EMACS_INT, not int.
c20998a7 6949 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6950 (struct sortstr.size, record_overlay_string)
6951 (struct sortstrlist.size, struct sortlist.used):
6952 Don't truncate size to int.
6953 (record_overlay_string): Check for size-calculation overflow.
d6202519 6954 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6955
d5a19415
JM
69562011-06-22 Jim Meyering <meyering@redhat.com>
6957
029529ac 6958 Don't leak an XBM-image-sized buffer
d5a19415
JM
6959 * image.c (xbm_load): Free the image buffer after using it.
6960
a9041e6c
PE
69612011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6962
6963 Port to Sun C.
6964 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6965 that Sun C diagnosed.
6966 * fns.c (secure_hash): Fix pointer signedness issue.
6967 * intervals.c (static_offset_intervals): New function.
6968 (offset_intervals): Use it.
6969
7f3f739f
LL
69702011-06-21 Leo Liu <sdl.web@gmail.com>
6971
6972 * deps.mk (fns.o):
6973 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6974 sha512.h.
6975
6976 * fns.c (secure_hash): Rename from crypto_hash_function and change
6977 the first arg to accept symbols.
5b66d427 6978 (Fsecure_hash): New primitive.
7f3f739f
LL
6979 (syms_of_fns): New symbols.
6980
76147d94
DD
69812011-06-20 Deniz Dogan <deniz@dogan.se>
6982
6983 * process.c (Fset_process_buffer): Clarify return value in
6984 docstring.
6985
7d7d0045
CY
69862011-06-18 Chong Yidong <cyd@stupidchicken.com>
6987
6988 * dispnew.c (add_window_display_history): Use BVAR.
6989
6990 * xdisp.c (debug_method_add): Use BVAR.
6991 (check_window_end, dump_glyph_matrix, dump_glyph)
6992 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6993
6994 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6995 Likewise.
6996
6997 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6998 check till after the cache is created in init_frame_faces.
6999
ff2bc410
SM
70002011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7001
7002 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7003
28177add
PE
70042011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7005
dd3482fe
PE
7006 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7007 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7008 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7009
393d71f3 7010 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7011 * fileio.c (Finsert_file_contents):
7012 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7013 Remove the old (too-loose) buffer overflow checks.
7014 They weren't needed, since make_gap checks for buffer overflow.
7015 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7016 The old code merely checked for Emacs fixnum overflow, and relied
7017 on undefined (wraparound) behavior. The new code avoids undefined
7018 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7019
2e6813b0 7020 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7021 Tune. Don't use wider integers than needed. Don't use alloca.
7022 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7023
599a9e4f
PE
7024 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7025
99561444
PE
7026 * insdel.c, lisp.h (buffer_overflow): New function.
7027 (insert_from_buffer_1, replace_range, replace_range_2):
7028 * insdel.c (make_gap_larger):
7029 * editfns.c (Finsert_char):
7030 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7031
28177add
PE
7032 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7033
e69dafad
PE
70342011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7035
4baa020d 7036 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7037
b1c46f02
PE
7038 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7039 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7040
e69dafad
PE
7041 * fileio.c: Don't assume EMACS_INT fits in off_t.
7042 (emacs_lseek): New static function.
7043 (Finsert_file_contents, Fwrite_region): Use it.
7044 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7045
566684ea
PE
7046 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7047
e6966cd6
PE
7048 * fns.c: Don't overflow int when computing a list length.
7049 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7050 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7051 truncation on 64-bit hosts. Check for QUIT every
7052 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7053 faster and is responsive enough.
7054 (Flength): Report an error instead of overflowing an integer.
7055 (Fsafe_length): Return a float if the value is not representable
7056 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7057 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7058 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7059
dd0b0efb
PE
7060 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7061 (header_size, word_size): New constants.
7062 (allocate_vectorlike): Don't check size overflow here.
7063 (allocate_vector): Check it here instead, since this is the only
7064 caller of allocate_vectorlike that could cause overflow.
7065 Check that the new vector's length is representable as a fixnum.
7066
86fe5cfe
PE
7067 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7068 The previous code was bogus. For example, next_almost_prime (32)
7069 returned 39, which is undesirable as it is a multiple of 3; and
7070 next_almost_prime (24) returned 25, which is a multiple of 5 so
7071 why was the code bothering to check for multiples of 7?
7072
80e88859
PE
7073 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7074
4a2f0ad6
PE
7075 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7076
f66c7cf8
PE
7077 Variadic C functions now count arguments with ptrdiff_t.
7078 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7079 Back then I didn't know that the Emacs coding style prefers signed int.
7080 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7081 were being counted with int, which may truncate counts on 64-bit
7082 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7083 * lisp.h (struct Lisp_Subr.function.aMANY)
7084 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7085 Arg counts are now ptrdiff_t, not size_t.
7086 All variadic functions and their callers changed accordingly.
7087 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7088 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7089 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7090 * callint.c (Fcall_interactively): Check arg count for overflow,
7091 to avoid potential buffer overrun. Use signed char, not 'int',
7092 for 'varies' array, so that we needn't bother to check its size
7093 calculation for overflow.
7094 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7095 * eval.c (apply_lambda):
7096 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7097 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7098 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7099
a1759b76
PE
7100 * callint.c (Fcall_interactively): Don't use index var as event count.
7101
d96be9fc
PE
7102 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7103 * mem-limits.h (SIZE): Remove; no longer used.
7104
a690a978 7105 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7106
578c21e6
PE
7107 Remove unnecessary casts.
7108 * xterm.c (x_term_init):
7109 * xfns.c (x_set_border_pixel):
7110 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7111 These aren't needed now that we assume ANSI C.
7112
96f53c6c
PE
7113 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7114 It's more likely to cause problems (due to unsigned overflow)
7115 than to cure them.
7116
83c77d31
PE
7117 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7118
ee2079f1
PE
7119 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7120
6da65536
PE
7121 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7122
7147c4a4
PE
7123 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7124
193e32d9
PE
7125 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7126
e5533da6
PE
7127 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7128
9910e595
PE
7129 GLYPH_CODE_FACE returns EMACS_INT, not int.
7130 * dispextern.h (merge_faces):
7131 * xfaces.c (merge_faces):
01103c44
PE
7132 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7133 Don't assume EMACS_INT fits in int.
9910e595 7134
2638320e
PE
7135 * character.h (CHAR_VALID_P): Remove unused parameter.
7136 * fontset.c, lisp.h, xdisp.c: All uses changed.
7137
045eb8d9
PE
7138 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7139
c1f134b5
PE
7140 * fns.c (concat): Minor tuning based on overflow analysis.
7141 This doesn't fix any bugs. Use int to hold character, instead
7142 of constantly refetching from Emacs object. Use XFASTINT, not
7143 XINT, for value known to be a character. Don't bother comparing
7144 a single byte to 0400, as it's always less.
7145
395fcb93 7146 * floatfns.c (Fexpt):
327eeec8
PE
7147 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7148
abbd3d23
PE
7149 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7150 for characters.
7151
684a03ef
PE
7152 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7153
0fed43f3
PE
7154 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7155 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7156 incorrectly succeed when S was a string, because 4294967386 was
7157 truncated before it was used.
7158
8fd02eb7
PE
7159 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7160 Otherwise, an out-of-range integer could cause undefined behavior
7161 on a 64-bit host.
7162
f8c86b69
PE
7163 * composite.c: Use int, not EMACS_INT, for characters.
7164 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7165 EMACS_INT, for values that are known to be in character range.
7166 This doesn't fix any bugs but is the usual style inside Emacs and
7167 may generate better code on 32-bit machines.
7168
34206dd2
PE
7169 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7170 This is for reasons similar to the recent CHAR_STRING fix.
7171 * charset.c (Fencode_char): Check that character arg is actually
7172 a character. Pass an int to ENCODE_CHAR.
7173 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7174 wider than 'int', as a compile-time check to prevent future regressions
7175 in this area.
7176
c5958d4c 7177 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7178
7179 Make sure a 64-bit char is never passed to CHAR_STRING.
7180 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7181 by silently ignoring the top 32 bits, allowing some values
7182 that were far too large to be valid characters.
7183 * character.h: Include <verify.h>.
7184 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7185 arguments are no wider than unsigned, as a compile-time check
7186 to prevent future regressions in this area.
7187 * data.c (Faset):
01103c44 7188 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7189 (Fsubst_char_in_region):
7190 * fns.c (concat):
7191 * xdisp.c (decode_mode_spec_coding):
7192 Adjust to CHAR_STRING's new requirement.
7193 * editfns.c (Finsert_char, Fsubst_char_in_region):
7194 * fns.c (concat): Check that character args are actually
7195 characters. Without this test, these functions did the wrong
7196 thing with wildly out-of-range values on 64-bit hosts.
7197
d37ca623
PE
7198 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7199 These casts should not be needed on 32-bit hosts, either.
7200 * keyboard.c (read_char):
7201 * lread.c (Fload): Remove casts to unsigned.
7202
ea204efb
PE
7203 * lisp.h (UNSIGNED_CMP): New macro.
7204 This fixes comparison bugs on 64-bit hosts.
7205 (ASCII_CHAR_P): Use it.
7206 * casefiddle.c (casify_object):
01103c44 7207 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7208 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7209 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7210 * dispextern.h (FACE_FROM_ID):
7211 * keyboard.c (read_char): Use UNSIGNED_CMP.
7212
41cb286c
PE
7213 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7214 not to EMACS_INT, to avoid GCC warning.
7215
4a1b9832
PE
7216 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7217
55daad71
PE
7218 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7219 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7220 isn't needed on 32-bit machines.
8f95c75c 7221
01103c44
PE
7222 * buffer.c (Fgenerate_new_buffer_name):
7223 Use EMACS_INT for count, not int.
0ceccced 7224 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7225
7226 * data.c (Qcompiled_function): Now static.
7227
c6f072e7
PE
7228 * window.c (window_body_lines): Now static.
7229
20ce5912
PE
7230 * image.c (gif_load): Rename local to avoid shadowing.
7231
9c4c5f81
PE
7232 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7233 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7234 * alloc.c (make_save_value): Integer argument is now of type
7235 ptrdiff_t, not int.
7236 (mark_object): Use ptrdiff_t, not int.
7237 * lisp.h (pD): New macro.
7238 * print.c (print_object): Use it.
7239
c0c5c8ae
PE
7240 * alloc.c: Use EMACS_INT, not int, to count objects.
7241 (total_conses, total_markers, total_symbols, total_vector_size)
7242 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7243 (total_free_floats, total_floats, total_free_intervals)
7244 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7245 Now EMACS_INT, not int. All uses changed.
7246 (Fgarbage_collect): Compute overall total using a double, so that
7247 integer overflow is less likely to be a problem. Check for overflow
7248 when converting back to an integer.
5a25e253
PE
7249 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7250 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7251 These were 'int' variables that could overflow on 64-bit hosts;
7252 they were never used, so remove them instead of repairing them.
211a0b2a 7253 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7254 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7255 Previously, this ceilinged at INT_MAX, but that doesn't work on
7256 64-bit machines.
e46bb31a 7257 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7258
c78baabf 7259 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7260 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7261 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7262 when a (possibly-narrower) signed value would do just as well.
7263 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7264
c9d624c6
PE
7265 * alloc.c: Catch some string size overflows that we were missing.
7266 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7267 for convenience in STRING_BYTES_MAX.
7268 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7269 The definition here is exact; the one in lisp.h was approximate.
7270 (allocate_string_data): Check for string overflow. This catches
7271 some instances we weren't catching before. Also, it catches
7272 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7273 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7274 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7275
c9d624c6
PE
7276 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7277 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7278 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7279
353032ce
PE
7280 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7281
2bccce07
PE
7282 * alloc.c (Fmake_string): Check for out-of-range init.
7283
0ac30604
SM
72842011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7285
7286 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7287
c195f2de
JD
72882011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7289
7290 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7291 xg_get_default_scrollbar_width.
7292
7293 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7294 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7295 (style_changed_cb): Call update_theme_scrollbar_width and call
7296 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7297 all frames (Bug#8505).
7298 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7299 Call gtk_window_set_resizable if HAVE_GTK3.
7300 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7301 and height if HAVE_GTK3 (Bug#8505).
7302 (scroll_bar_width_for_theme): New variable.
7303 (update_theme_scrollbar_width): New function.
7304 (xg_get_default_scrollbar_width): Move code to
7305 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7306 (xg_initialize): Call update_theme_scrollbar_width.
7307
7308 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7309
7310 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7311
e10ac9f1
MR
73122011-06-12 Martin Rudalics <rudalics@gmx.at>
7313
7314 * frame.c (make_frame): Call other_buffer_safely instead of
7315 other_buffer.
7316
7317 * window.c (temp_output_buffer_show): Call display_buffer with
7318 second argument Vtemp_buffer_show_specifiers and reset latter
7319 immediately after the call.
7320 (Vtemp_buffer_show_specifiers): New variable.
7321 (auto_window_vscroll_p, next_screen_context_lines)
7322 (Vscroll_preserve_screen_position): Remove leading asterisks from
7323 doc-strings.
7324
2d3c217e 73252011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7326
7b7f97e8 7327 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7328 * buffer.c (Qclone_number): Remove for now, as it's unused.
7329 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7330 (record_buffer): Remove unused local.
7331 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7332 (set_frame_buffer_list): Remove; unused.
7333 * frame.h (other_visible_frames): Remove decl.
7334 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7335 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7336 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7337 if HAVE_GPM.
7338 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7339 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7340 Define only if HAVE_GPM.
7341 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7342 (update_hints_inhibit): Remove; never set. All uses removed.
7343 * widgetprv.h (emacsFrameClassRec): Remove decl.
7344 * window.c (delete_deletable_window): Now returns void, since it
7345 wasn't returning anything.
7346 (compare_window_configurations): Remove unused locals.
7347 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7348 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7349 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7350 the same widths as pointers. This follows up on the 2011-05-06 patch.
7351 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7352 * xterm.h: Likewise.
7353 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7354
1384b89e
JB
73552011-06-12 Juanma Barranquero <lekktu@gmail.com>
7356
7357 * makefile.w32-in: Update dependencies.
7358 (LISP_H): Add lib/intprops.h.
7359
1100a63c
CY
73602011-06-11 Chong Yidong <cyd@stupidchicken.com>
7361
7362 * image.c (gif_load): Add animation frame delay to the metadata.
7363 (syms_of_image): Use DEFSYM. New symbol `delay'.
7364
6198ccd0
MR
73652011-06-11 Martin Rudalics <rudalics@gmx.at>
7366
7367 * window.c (delete_deletable_window): Re-add.
7368 (Fset_window_configuration): Rewrite to handle dead buffers and
7369 consequently deletable windows.
7370 (window_tree, Fwindow_tree): Remove. Supply functionality in
7371 window.el.
7372 (compare_window_configurations): Simplify code.
7373
b6e3633c
AS
73742011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7375
1ab0dee5
AS
7376 * image.c (imagemagick_load_image): Fix type mismatch.
7377 (Fimagemagick_types): Likewise.
7378
b6e3633c
AS
7379 * window.h (replace_buffer_in_windows): Declare.
7380
9397e56f
MR
73812011-06-11 Martin Rudalics <rudalics@gmx.at>
7382
7383 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7384 Qclone_number. Remove external declaration of Qdelete_window.
7385 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7386 code.
640c8776
SM
7387 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7388 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7389 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7390 buffer list implementation.
7391 (other_buffer_safely): New function.
7392 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7393 calls to replace_buffer_in_windows and
7394 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7395 if allowed.
7396 (record_buffer): Inhibit quitting and rewrite using quittable
7397 functions. Run Qbuffer_list_update_hook if allowed.
7398 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7399 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7400 Move switch-to-buffer to window.el.
9397e56f
MR
7401 (bury-buffer): Move to window.el.
7402 (Vbuffer_list_update_hook): New variable.
7403
7404 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7405 section.
7406
7407 * window.h (resize_frame_windows): Move up in code.
7408 (Fwindow_frame): Remove EXFUN.
7409 (replace_buffer_in_all_windows): Remove prototype.
7410 (replace_buffer_in_windows_safely): Add prototype.
7411
7412 * window.c: Declare Qdelete_window static again. Move down
7413 declaration of select_count.
7414 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7415 (Fother_window): Move to window.el.
7416 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7417 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7418 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7419 window.el.
7420 (replace_buffer_in_windows): Implement by calling
7421 Qreplace_buffer_in_windows.
7422 (replace_buffer_in_all_windows): Remove with some functionality
7423 moved into replace_buffer_in_windows_safely.
7424 (replace_buffer_in_windows_safely): New function.
7425 (select_window_norecord, select_frame_norecord): Move in front
7426 of run_window_configuration_change_hook. Remove now obsolete
7427 declarations.
640c8776
SM
7428 (Fset_window_buffer): Rewrite doc-string.
7429 Call Qrecord_window_buffer.
9397e56f
MR
7430 (keys_of_window): Move binding for other-window to window.el.
7431
b50691aa
CY
74322011-06-11 Chong Yidong <cyd@stupidchicken.com>
7433
7434 * dispextern.h (struct image): Replace data member, whose int_val
7435 and ptr_val fields were not used by anything, with a single
7436 lisp_val object.
7437
7438 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7439 (gif_clear_image, gif_load, imagemagick_load_image)
7440 (gs_clear_image, gs_load): Callers changed.
7441
3f754b86
PE
74422011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7443
cca69397
PE
7444 * buffer.h: Include <time.h>, for time_t.
7445 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7446
109e28d0
PE
7447 Fix minor problems found by static checking.
7448
60737f02
PE
7449 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7450
4b66faf3
PE
7451 Make identifiers static if they are not used in other modules.
7452 * data.c (Qcompiled_function, Qframe, Qvector):
7453 * image.c (QimageMagick, Qsvg):
7454 * minibuf.c (Qmetadata):
7455 * window.c (resize_window_check, resize_root_window): Now static.
7456 * window.h (resize_window_check, resize_root_window): Remove decls.
7457
109e28d0
PE
7458 * window.c (window_deletion_count, delete_deletable_window):
7459 Remove; unused.
46a4ce9e
PE
7460 (window_body_lines): Now static.
7461 (Fdelete_other_windows_internal): Mark vars as initialized.
7462 Make sure 'resize_failed' is initialized.
7463 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7464 (resize_window_apply): Remove unused local.
7465 * window.h (delete_deletable_window): Remove decl.
7466
109e28d0 7467 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7468 (imagemagick_load_image): Fix pointer signedness problem by changing
7469 last arg from unsigned char * to char *. All uses changed.
7470 Also, fix a local for similar reasons.
7471 Remove unused locals. Remove locals to avoid shadowing.
7472 (fn_rsvg_handle_free): Remove; unused.
7473 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7474 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7475
3f754b86
PE
7476 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7477
2547adb1
CY
74782011-06-10 Chong Yidong <cyd@stupidchicken.com>
7479
7480 * image.c (gif_load): Fix omitted cast error introduced by
7481 2011-06-06 change.
7482
2c8e37d4
MR
74832011-06-10 Martin Rudalics <rudalics@gmx.at>
7484
7485 * window.h (resize_proportionally, orig_total_lines)
7486 (orig_top_line): Remove from window structure.
7487 (set_window_height, set_window_width, change_window_heights)
7488 (Fdelete_window): Remove prototypes.
7489 (resize_frame_windows): Remove duplicate declaration.
7490
440a42e3
EZ
74912011-06-10 Eli Zaretskii <eliz@gnu.org>
7492
7493 * window.h (resize_frame_windows, resize_window_check)
7494 (delete_deletable_window, resize_root_window)
7495 (resize_frame_windows): Declare prototypes.
7496
7497 * window.c (resize_window_apply): Make definition be "static" to
7498 match the prototype.
7499
562dd5e9
MR
75002011-06-10 Martin Rudalics <rudalics@gmx.at>
7501
7502 * window.c: Remove declarations of Qwindow_size_fixed,
7503 window_min_size_1, window_min_size_2, window_min_size,
7504 size_window, window_fixed_size_p, enlarge_window, delete_window.
7505 Remove static from declaration of Qdelete_window, it's
7506 temporarily needed by Fbury_buffer.
7507 (replace_window): Don't assign orig_top_line and
7508 orig_total_lines.
7509 (Fdelete_window, delete_window): Remove. Window deletion is
7510 handled by window.el.
640c8776
SM
7511 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7512 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7513 (Fdelete_other_windows): Remove. Deleting other windows is
7514 handled by window.el.
7515 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7516 handled in window.el.
7517 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7518 Window minimum sizes are handled in window.el.
7519 (shrink_windows, size_window, set_window_height)
7520 (set_window_width, change_window_heights, window_height)
7521 (window_width, CURBEG, CURSIZE, enlarge_window)
7522 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7523 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7524 handled in window.el.
7525 (make_dummy_parent): Rename to make_parent_window and give it a
7526 second argument horflag.
7527 (make_window): Don't set resize_proportionally any more.
7528 (Fsplit_window): Remove. Windows are split in window.el.
7529 (save_restore_action, save_restore_orig_size)
7530 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7531 Resize mini windows in window.el.
7532 (grow_mini_window, shrink_mini_window): Implement by calling
7533 Qresize_root_window_vertically, resize_window_check and
7534 resize_window_apply.
640c8776
SM
7535 (saved_window, Fset_window_configuration, save_window_save):
7536 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7537 resize_proportionally.
7538 (window_min_height, window_min_width): Move to window.el.
7539 (keys_of_window): Move bindings for delete-other-windows,
7540 split-window, delete-window and enlarge-window to window.el.
7541
7542 * buffer.c: Temporarily extern Qdelete_window.
7543 (Fbury_buffer): Temporarily call Qdelete_window instead of
7544 Fdelete_window (Fbury_buffer will move to window.el soon).
7545
7546 * frame.c (set_menu_bar_lines_1): Remove code handling
7547 orig_top_line and orig_total_lines.
7548
7549 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7550 set_window_height but set heights directly.
7551 (change_frame_size_1): Use resize_frame_windows.
7552
7553 * xdisp.c (init_xdisp): Don't use set_window_height but set
7554 heights directly.
7555
640c8776
SM
7556 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7557 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7558 run_window_configuration_change_hook.
7559
7560 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7561 instead of change_window_heights and run
7562 run_window_configuration_change_hook.
7563
1a13852e
MR
75642011-06-09 Martin Rudalics <rudalics@gmx.at>
7565
7566 * window.c (replace_window): Rename second argument REPLACEMENT to
7567 NEW. New third argument SETFLAG. Rewrite.
7568 (delete_window, make_dummy_parent): Call replace_window with
7569 third argument 1.
7570 (window_list_1): Move down in code.
7571 (run_window_configuration_change_hook): Move set_buffer part
7572 before select_frame_norecord part in order to unwind correctly.
7573 Rename count1 to count.
7574 (recombine_windows, delete_deletable_window, resize_root_window)
7575 (Fdelete_other_windows_internal)
7576 (Frun_window_configuration_change_hook, make_parent_window)
7577 (resize_window_check, resize_window_apply, Fresize_window_apply)
7578 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7579 (Fdelete_window_internal, Fresize_mini_window_internal):
7580 New functions.
1a13852e
MR
7581 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7582
f3d1777e
MR
75832011-06-08 Martin Rudalics <rudalics@gmx.at>
7584
496e208e
MR
7585 * window.h (window): Add some new members to window structure -
7586 normal_lines, normal_cols, new_total, new_normal, clone_number,
7587 splits, nest, prev_buffers, next_buffers.
7588 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7589 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7590
f3d1777e
MR
7591 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7592 Remove.
496e208e
MR
7593 (make_dummy_parent): Set new members of windows structure.
7594 (make_window): Move down in code. Handle new members of window
7595 structure.
7596 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7597 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7598 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7599 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7600 (Fset_window_next_buffers, Fset_window_clone_number):
7601 New functions.
496e208e
MR
7602 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7603 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7604 Doc-string fixes.
7605 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7606 Argument WINDOW can be now internal window too.
7607 (Fwindow_use_time): Move up in code.
7608 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7609 Rewrite doc-string.
7610 (Fset_window_configuration, saved_window)
7611 (Fcurrent_window_configuration, save_window_save): Handle new
7612 members of window structure.
b9e809c2
MR
7613 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7614 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7615 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7616 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7617 Qget_mru_window, Qresize_root_window,
7618 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7619 Qauto_buffer_name; staticpro them.
f3d1777e 7620
abde8f8c
MR
76212011-06-07 Martin Rudalics <rudalics@gmx.at>
7622
7623 * window.c (Fwindow_total_size, Fwindow_left_column)
7624 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7625 (Fwindow_list_1): New functions.
7626 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7627 (Fwindow_width, Fscroll_left, Fscroll_right):
7628 Use window_body_cols instead of window_box_text_cols.
7629 (delete_window, Fset_window_configuration):
7630 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7631 (delete_all_subwindows): Take a window as argument and not a
7632 structure. Rewrite.
190b47e6
MR
7633 (window_loop): Remove handling of GET_LRU_WINDOW and
7634 GET_LARGEST_WINDOW.
7635 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7636
7637 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7638 window_box_text_cols. delete_all_subwindows now takes a
7639 Lisp_Object as argument.
abde8f8c 7640
640c8776
SM
7641 * indent.c (compute_motion, Fcompute_motion):
7642 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7643
fa8a67e6
MR
7644 * frame.c (delete_frame): Call delete_all_subwindows with root
7645 window as argument.
7646
a54e3482
DC
76472011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7648
7649 * fns.c (Fputhash): Document return value.
7650
60002bf5
CY
76512011-06-06 Chong Yidong <cyd@stupidchicken.com>
7652
7653 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7654
0c671da6 76552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7656
b862a52a 7657 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7658
be44ca6c
PE
7659 Check for overflow when converting integer to cons and back.
7660 * charset.c (Fdefine_charset_internal, Fdecode_char):
7661 Use cons_to_unsigned to catch overflow.
7662 (Fencode_char): Use INTEGER_TO_CONS.
7663 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7664 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7665 * data.c (long_to_cons, cons_to_long): Remove.
7666 (cons_to_unsigned, cons_to_signed): New functions.
7667 These signal an error for invalid or out-of-range values.
7668 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7669 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7670 * font.c (Ffont_variation_glyphs):
7671 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7672 * lisp.h: Include <intprops.h>.
7673 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7674 (cons_to_signed, cons_to_unsigned): New decls.
7675 (long_to_cons, cons_to_long): Remove decls.
7676 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7677 (Fprimitive_undo): Use CONS_TO_INTEGER.
7678 * xfns.c (Fx_window_property): Likewise.
7679 * xselect.c: Include <limits.h>.
7680 (x_own_selection, selection_data_to_lisp_data):
7681 Use INTEGER_TO_CONS.
7682 (x_handle_selection_request, x_handle_selection_clear)
7683 (x_get_foreign_selection, Fx_disown_selection_internal)
7684 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7685 (lisp_data_to_selection_data): Use cons_to_unsigned.
7686 (x_fill_property_data): Use cons_to_signed.
7687 Report values out of range.
7688
d1f3d2af
PE
7689 Check for buffer and string overflow more precisely.
7690 * buffer.h (BUF_BYTES_MAX): New macro.
7691 * lisp.h (STRING_BYTES_MAX): New macro.
7692 * alloc.c (Fmake_string):
7693 * character.c (string_escape_byte8):
7694 * coding.c (coding_alloc_by_realloc):
7695 * doprnt.c (doprnt):
7696 * editfns.c (Fformat):
7697 * eval.c (verror):
7698 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7699 since they may not be the same number.
7700 * editfns.c (Finsert_char):
7701 * fileio.c (Finsert_file_contents):
7702 Likewise for BUF_BYTES_MAX.
7703
dd52fcea
PE
7704 * image.c: Use ptrdiff_t, not int, for sizes.
7705 (slurp_file): Switch from int to ptrdiff_t.
7706 All uses changed.
7707 (slurp_file): Check that file size fits in both size_t (for
7708 malloc) and ptrdiff_t (for sanity and safety).
7709
7f9bbdbb
PE
7710 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7711 if b->modtime has its maximal value.
7712
dfe18f82
PE
7713 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7714
84acfcf0
PE
7715 Don't assume time_t can fit into int.
7716 * buffer.h (struct buffer.modtime): Now time_t, not int.
7717 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7718 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7719
ccd9a01a
PE
7720 Minor fixes for signed vs unsigned integers.
7721 * character.h (MAYBE_UNIFY_CHAR):
7722 * charset.c (maybe_unify_char):
7723 * keyboard.c (read_char, reorder_modifiers):
7724 XINT -> XFASTINT, since the integer must be nonnegative.
7725 * ftfont.c (ftfont_spec_pattern):
7726 * keymap.c (access_keymap, silly_event_symbol_error):
7727 XUINT -> XFASTINT, since the integer must be nonnegative.
7728 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7729 since it makes no difference and we prefer signed.
7730 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7731 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7732 nonnegative.
7733
d6d100dd
SM
77342011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7735
7736 * window.h (Fwindow_frame): Declare.
7737
2b6148e4
PE
77382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7739
7740 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7741 (SPARE_MEMORY): Always define.
7742 (LARGE_REQUEST): Remove.
7743 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7744
f230ecc9
MR
77452011-06-06 Martin Rudalics <rudalics@gmx.at>
7746
727e958e
MR
7747 * lisp.h: Move EXFUNS for Fframe_root_window,
7748 Fframe_first_window and Fset_frame_selected_window to window.h.
7749
7750 * window.h: Move EXFUNS for Fframe_root_window,
7751 Fframe_first_window and Fset_frame_selected_window here from
7752 lisp.h.
7753
7754 * frame.c (Fwindow_frame, Fframe_first_window)
7755 (Fframe_root_window, Fframe_selected_window)
7756 (Fset_frame_selected_window): Move to window.c.
7757 (Factive_minibuffer_window): Move to minibuf.c.
7758 (Fother_visible_frames_p): New function.
7759
7760 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7761
f230ecc9
MR
7762 * window.c (decode_window, decode_any_window): Move up in code.
7763 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7764 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7765 (Fwindow_buffer): Move up and rewrite doc-string.
7766 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7767 (Fwindow_prev): New functions.
727e958e
MR
7768 (Fwindow_frame): Move here from frame.c. Accept any window as
7769 argument.
7770 (Fframe_root_window, Fframe_first_window)
7771 (Fframe_selected_window): Move here from frame.c. Accept frame
7772 or arbitrary window as argument. Update doc-strings.
7773 (Fminibuffer_window): Move up in code.
7774 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7775 (Fset_frame_selected_window): Move here from frame.c.
7776 Marginal rewrite.
727e958e
MR
7777 (Fselected_window, select_window, Fselect_window): Move up in
7778 code. Minor doc-string fixes.
f230ecc9 7779
4d09bcf6
PE
77802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7781
7782 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7783 Do not assume that spare memory exists; that assumption is valid
7784 only if SYSTEM_MALLOC.
7785 (LARGE_REQUEST): New macro, so that the issue of large requests
7786 is separated from the issue of spare memory.
7787
810928a2
AS
77882011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7789
172418ad
AS
7790 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7791 format. (Bug#8806)
7792
43f862f7
AS
7793 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7794
810928a2
AS
7795 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7796 before statements.
7797
a059fe24
JD
77982011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7799
7800 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7801
7802 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7803
7804 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7805 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7806
989bf368
JB
78072011-06-05 Juanma Barranquero <lekktu@gmail.com>
7808
7809 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7810
4b80f674
CY
78112011-06-04 Chong Yidong <cyd@stupidchicken.com>
7812
7813 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7814 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7815 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7816 New error handlers.
4b80f674
CY
7817 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7818 Obey Vx_select_enable_clipboard_manager. Catch errors in
7819 x_clipboard_manager_save (Bug#8779).
7820 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7821 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7822
99a33b77 78232011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7824
7825 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7826
99a33b77 78272011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7828
7829 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7830 in the current matrix if keep_current_p is non-zero.
7831
8264569d
EZ
78322011-06-04 Eli Zaretskii <eliz@gnu.org>
7833
7834 * bidi.c (bidi_level_of_next_char): Fix last change.
7835
57f97249
EZ
78362011-06-03 Eli Zaretskii <eliz@gnu.org>
7837
fec2107c 7838 Support bidi reordering of text covered by display properties.
57f97249 7839
fec2107c
EZ
7840 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7841 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7842 (bidi_cache_search, bidi_cache_iterator_state)
7843 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7844 (bidi_level_of_next_char, bidi_move_to_visually_next):
7845 Support character positions inside a run of characters covered by a
fec2107c
EZ
7846 display string.
7847 (bidi_paragraph_init, bidi_resolve_explicit_1)
7848 (bidi_level_of_next_char): Call bidi_fetch_char and
7849 bidi_fetch_char_advance instead of FETCH_CHAR and
7850 FETCH_CHAR_ADVANCE.
7851 (bidi_init_it): Initialize new members.
7852 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7853 definitions.
7854 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7855 instead of using explicit *_CHAR codes.
d6d100dd
SM
7856 (bidi_resolve_explicit, bidi_resolve_weak):
7857 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7858 bidirectional text is supported only in multibyte buffers.
7859 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7860 it to initialize the frame_window_p member of struct bidi_it.
7861 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7862 (bidi_resolve_explicit, bidi_resolve_weak)
7863 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7864 bidi_it->nchars is non-positive.
7865 (bidi_level_of_next_char): Don't try to lookup the cache for the
7866 next/previous character if nothing is cached there yet, or if we
7867 were just reseat()'ed to a new position.
c40e2fb2 7868
0e14fe90
EZ
7869 * xdisp.c (set_cursor_from_row): Set start and stop points
7870 according to the row's direction when priming the loop that looks
7871 for the glyph on which to display cursor.
7872 (single_display_spec_intangible_p): Function deleted.
7873 (display_prop_intangible_p): Reimplement to call
7874 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7875 Accept 3 additional arguments needed by handle_display_spec.
7876 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7877 values: lists, `(when COND...)' forms, etc.
7878 (single_display_spec_string_p): Support property values that are
7879 lists with the argument STRING its top-level element.
7880 (display_prop_string_p): Fix the condition for processing a
7881 property that is a list to be consistent with handle_display_spec.
fec2107c 7882 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7883 last portion of handle_display_prop.
7884 (compute_display_string_pos): Accept additional argument
7885 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7886 value of a `display' property is a "replacing spec".
7887 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7888 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7889 the display property, but just return a value indicating whether
7890 the display property will replace the characters it covers.
7891 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7892 frame_window_p members of struct bidi_it.
d6d100dd
SM
7893 (compute_display_string_pos, compute_display_string_end):
7894 New functions.
fec2107c
EZ
7895 (push_it): Accept second argument POSITION, where pop_it should
7896 jump to continue iteration.
7897 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7898
fec2107c
EZ
7899 * keyboard.c (adjust_point_for_property): Adjust the call to
7900 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7901
7902 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7903 (bidi_init_it): Update prototypes.
7904 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7905 (compute_display_string_pos, compute_display_string_end):
7906 Declare prototypes.
fec2107c
EZ
7907 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7908 EMACS_INT.
fc6f18ce 7909
40087514 79102011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7911
57f53182
PE
7912 Malloc failure behavior now depends on size of allocation.
7913 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7914 * lisp.h: Change signatures accordingly.
7915 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7916 All callers changed. (Bug#8762)
7917
7918 * gnutls.c: Use Emacs's memory allocators.
7919 Without this change, the gnutls library would invoke malloc etc.
7920 directly, which causes problems on non-SYNC_INPUT hosts, and which
7921 runs afoul of improving memory_full behavior. (Bug#8761)
7922 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7923 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7924 xfree instead of the default malloc, realloc, free.
7925 (Fgnutls_boot): No need to check for memory allocation failure,
7926 since xmalloc does that for us.
7927
ac32cd99 7928 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7929 * category.c (hash_get_category_set):
7930 * ccl.c (ccl_driver):
7931 * charset.c (Fdefine_charset_internal):
7932 * charset.h (struct charset.hash_index):
7933 * composite.c (get_composition_id, gstring_lookup_cache)
7934 (composition_gstring_put_cache):
7935 * composite.h (struct composition.hash_index):
7936 * dispextern.h (struct image.hash):
7937 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7938 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7939 (hashfn_equal, hashfn_user_defined, make_hash_table)
7940 (maybe_resize_hash_table, hash_lookup, hash_put)
7941 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7942 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7943 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7944 * image.c (make_image, search_image_cache, lookup_image)
7945 (xpm_put_color_table_h):
7946 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7947 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7948 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7949 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7950 * alloc.c (allocate_vectorlike):
7951 Check for overflow in vector size calculations.
7952 * ccl.c (ccl_driver):
7953 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7954 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7955 need to be updated by these changes.
40087514
PE
7956 * fns.c (make_hash_table, maybe_resize_hash_table):
7957 Check for integer overflow with large hash tables.
0de4bb68
PE
7958 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7959 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7960 (SXHASH_REDUCE): New macro.
7961 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7962 Use it instead of discarding useful hash info with large hash values.
7963 (sxhash_float): New function.
7964 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7965 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7966 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7967 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7968 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7969 Adjust signatures to match updated version of code.
7970 (consing_since_gc): Now EMACS_INT, since a single hash table can
7971 use more than INT_MAX bytes.
7972
698d32e2
DN
79732011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7974
7975 Make it possible to build with GCC-4.6+ -O2 -flto.
7976
7977 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7978
fd6fa53f
SM
79792011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7980
7981 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7982 Call minibuffer-inactive-mode.
7983
864db017
JB
79842011-05-31 Juanma Barranquero <lekktu@gmail.com>
7985
7986 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7987 Update dependencies.
7988
2ad0baf4
DN
79892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7990
7991 * data.c (init_data): Remove code for UTS, this system is not
7992 supported anymore.
7993
4fcc2638
DN
79942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7995
7996 Don't force ./temacs to start in terminal mode.
7997
7998 * frame.c (make_initial_frame): Initialize faces in all cases, not
7999 only when CANNOT_DUMP is defined.
8000 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8001
c56e0fd5
DN
80022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8003
8004 * dispnew.c (add_window_display_history): Use const for the string
8005 pointer. Remove declaration, not needed.
8006
333d54da 80072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8008
55d4c1b2 8009 Use 'inline', not 'INLINE'.
333d54da 8010 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8011 * alloc.c, fontset.c (INLINE): Remove.
8012 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8013 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8014 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8015 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8016 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8017
738db178
DN
80182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8019
8020 Make it possible to run ./temacs.
8021
8022 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8023 syms_of_callproc does the same thing. Remove test for
8024 "initialized", do it in the caller.
8025 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8026
620c53a6
SM
80272011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8028
8029 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8030 (read_minibuf): Use get_minibuffer.
8031 (syms_of_minibuf): Use DEFSYM.
8032 (Qmetadata): New var.
8033 * data.c (Qbuffer): Don't make it static.
8034 (syms_of_data): Use DEFSYM.
8035
e003a292
PE
80362011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8037
8038 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8039 (CCL_CODE_MIN): New macro.
8040
ed008a6d
PE
80412011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8042
3687c2ef
PE
8043 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8044
ed008a6d
PE
8045 * eval.c (Qdebug): Now static.
8046 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8047 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8048 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8049
d66c4c7c
CY
80502011-05-29 Chong Yidong <cyd@stupidchicken.com>
8051
8052 * image.c: Various fixes to ImageMagick code comments.
8053 (Fimagemagick_types): Doc fix.
8054
5fbc2025
PE
80552011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8056
0196f88a
PE
8057 Minor fixes prompted by GCC 4.6.0 warnings.
8058
8059 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8060
5fbc2025
PE
8061 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8062 (x_clipboard_manager_save_all): Move extern decl to ...
8063 * xterm.h: ... here, so that it can be checked for consistency.
8064
1dd3c2d9
CY
80652011-05-29 Chong Yidong <cyd@stupidchicken.com>
8066
8067 * xselect.c (x_clipboard_manager_save_frame)
8068 (x_clipboard_manager_save_all): New functions.
8069 (Fx_clipboard_manager_save): Lisp function deleted.
8070
8071 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8072 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8073
8074 * xterm.h: Update prototype.
8075
5ba6571d
WX
80762011-05-28 William Xu <william.xwl@gmail.com>
8077
8078 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8079 exiting (Bug#8239).
8080
3eaff834
JM
80812011-05-28 Jim Meyering <meyering@redhat.com>
8082
e1900994 8083 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8084 * fns.c (to_uchar): Define.
8085 (crypto_hash_function): Use it to convert some newly-signed
8086 variables to unsigned, to avoid sign-extension bugs. For example,
8087 without this change, (md5 "truc") would evaluate to
8088 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8089 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8090 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8091
0f6990a7
PE
80922011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8093
8094 Integer overflow fixes.
c8a9ca5a 8095
08686060
PE
8096 * dbusbind.c: Serial number integer overflow fixes.
8097 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8098 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8099 to hold a serial number that is too large for a fixnum.
8100 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8101 Check for serial numbers out of range. Decode any serial number
59568bf0 8102 that was so large that it became a float. (Bug#8722)
08686060 8103
2d1fc3c7
PE
8104 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8105 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8106 Use XFASTINT rather than XUINT when numbers are nonnegative.
8107 (xd_append_arg, Fdbus_method_return_internal):
8108 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8109 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8110 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8111 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8112 (Bug#8722)
2d1fc3c7 8113
c8a9ca5a
PE
8114 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8115
519e1d69
PE
8116 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8117
6df6ae42 8118 ccl: Add integer overflow checks.
30569699
PE
8119 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8120 (IN_INT_RANGE): New macros.
8121 (ccl_driver): Use them to check for integer overflow when
8122 decoding a CCL program. Many of the new checks are whether XINT (x)
8123 fits in int; it doesn't always, on 64-bit hosts. The new version
8124 doesn't catch all possible integer overflows, but it's an
847044ea 8125 improvement. (Bug#8719)
30569699 8126
c11285dc
PE
8127 * alloc.c (make_event_array): Use XINT, not XUINT.
8128 There's no need for unsigned here.
8129
fdccd48e
PE
8130 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8131 This follows up to the 2011-05-06 change that substituted uintptr_t
8132 for EMACS_INT. This case wasn't caught back then.
8133
37910ab2
PE
8134 Rework Fformat to avoid integer overflow issues.
8135 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8136 now (part of C89). Include <verify.h>.
8137 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8138 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8139 (Fformat): Avoid the prepass trying to compute sizes; it was only
8140 approximate and thus did not catch overflow reliably. Instead, walk
8141 through the format just once, formatting and computing sizes as we go,
8142 checking for integer overflow at every step, and allocating a larger
8143 buffer as needed. Keep track separately whether the format is
8144 multibyte. Keep only the most-recently calculated precision, rather
8145 than them all. Record whether each argument has been converted to
8146 string. Use EMACS_INT, not int, for byte and char and arg counts.
8147 Support field widths and precisions larger than INT_MAX. Avoid
8148 sprintf's undefined behavior with conversion specifications such as %#d
8149 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8150 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8151 formatting out-of-range floating point numbers with int
9173deec 8152 formats. (Bug#8668)
37910ab2 8153
2e6578fb
PE
8154 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8155
0ae6bdee
PE
8156 * data.c: Avoid integer truncation in expressions involving floats.
8157 * data.c: Include <intprops.h>.
8158 (arith_driver): When there's an integer overflow in an expression
8159 involving floating point, convert the integers to floating point
8160 so that the resulting value does not suffer from catastrophic
8161 integer truncation. For example, on a 64-bit host (* 4
8162 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8163 Do not rely on undefined behavior after integer overflow.
8164
de883a70
PE
8165 merge count_size_as_multibyte, parse_str_to_multibyte
8166 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8167 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8168 Check for integer overflow.
8169 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8170 since it's now a duplicate of the other. This is more of
8171 a character than a buffer op, so better that it's in character.c.
8172 * fns.c, print.c: Adjust to above changes.
8173
2ff916cb
PE
81742011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8175
8176 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8177
f1b54466
PE
81782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8179
fb1ac845
PE
8180 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8181 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8182 (x_clipboard_manager_save): Now static.
8183 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8184
f1b54466
PE
8185 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8186 (crypto_hash_function): Now static.
8187 Fix pointer signedness problems. Avoid unnecessary initializations.
8188
a9f737ee
CY
81892011-05-27 Chong Yidong <cyd@stupidchicken.com>
8190
8191 * termhooks.h (Vselection_alist): Make it terminal-local.
8192
8193 * terminal.c (create_terminal): Initialize it.
8194
8195 * xselect.c: Support for clipboard managers.
8196 (Vselection_alist): Move to termhooks.h as terminal-local var.
8197 (LOCAL_SELECTION): New macro.
8198 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8199 (symbol_to_x_atom): Remove gratuitous arg.
8200 (x_handle_selection_request, lisp_data_to_selection_data)
8201 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8202 (x_own_selection, x_get_local_selection, x_convert_selection):
8203 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8204 (some_frame_on_display): Delete unused function.
8205 (Fx_own_selection_internal, Fx_get_selection_internal)
8206 (Fx_disown_selection_internal, Fx_selection_owner_p)
8207 (Fx_selection_exists_p): New optional frame arg.
8208 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8209 (x_handle_selection_clear): Don't treat other terminals with the
8210 same keyboard specially. Use the terminal-local Vselection_alist.
8211 (x_clear_frame_selections): Use Frun_hook_with_args.
8212
8213 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8214
8215 * xterm.h: Add support for those atoms.
8216
e067f0c1
CY
82172011-05-26 Chong Yidong <cyd@stupidchicken.com>
8218
8219 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8220 (converted_selections, conversion_fail_tag): New global variables.
8221 (x_selection_request_lisp_error): Free the above.
8222 (x_get_local_selection): Remove unnecessary code.
8223 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8224 of converted selections stored in converted_selections.
8225 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8226 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8227 (x_convert_selection): New function.
8228 (x_handle_selection_event): Simplify.
8229 (x_get_foreign_selection): Don't ignore incoming requests while
8230 waiting for an answer; this will fail when we implement
8231 SAVE_TARGETS, and seems unnecessary anyway.
8232 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8233 (Vx_sent_selection_functions): Doc fix.
8234
0f4aebc0
LL
82352011-05-26 Leo Liu <sdl.web@gmail.com>
8236
8237 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8238
e61124cd
YM
82392011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8240
8241 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8242
8243 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8244 for fringe update if it has periodic bitmap.
ac389d0c 8245 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8246 and fringe_bitmap_periodic_p.
8247
8248 * fringe.c (get_fringe_bitmap_data): New function.
8249 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8250 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8251 row. Mark glyph row for fringe update if periodicity changed.
8252
8253 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8254 for fringe update unless it has periodic bitmap.
8255
f16d9837
KH
82562011-05-25 Kenichi Handa <handa@m17n.org>
8257
8258 * xdisp.c (get_next_display_element): Set correct it->face_id for
8259 a static composition.
8260
e1b90ef6
LL
82612011-05-24 Leo Liu <sdl.web@gmail.com>
8262
8263 * deps.mk (fns.o):
8264 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8265
8266 * fns.c (crypto_hash_function, Fsha1): New function.
8267 (Fmd5): Use crypto_hash_function.
8268 (syms_of_fns): Add Ssha1.
8269
7400048f
PE
82702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8271
8272 * gnutls.c: Remove unused macros.
8273 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8274 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8275 Remove macros that are defined and never used.
8276 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8277
abb71cf4
CY
82782011-05-22 Chong Yidong <cyd@stupidchicken.com>
8279
8280 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8281 (Fx_get_selection_internal): Minor cleanup.
8282 (Fx_own_selection_internal): Rename arguments for consistency with
8283 select.el.
8284
6307db39
PE
82852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8286
8287 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8288
f3d4e0a4
CY
82892011-05-22 Chong Yidong <cyd@stupidchicken.com>
8290
8291 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8292
4d8ade89
YM
82932011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8294
8295 * dispnew.c (scrolling_window): Don't exclude the case that the
8296 last enabled row in the desired matrix touches the bottom boundary.
8297
32078c8d
GM
82982011-05-21 Glenn Morris <rgm@gnu.org>
8299
8300 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8301 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8302 and add some more files.
32078c8d 8303
7285dc67
EZ
83042011-05-20 Eli Zaretskii <eliz@gnu.org>
8305
8306 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8307 report_file_error introduced by the change from 2011-05-07.
8308
89d1bd22
PE
83092011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8310
8311 * systime.h (Time): Define only if emacs is defined.
8312 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8313 where the include path doesn't have X11/X.h by default. See
8314 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8315
cd394be1 83162011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8317
8318 * composite.c (find_automatic_composition): Fix previous change.
8319
b9704ad9
GM
83202011-05-20 Glenn Morris <rgm@gnu.org>
8321
8322 * lisp.mk: New file, split from Makefile.in.
8323 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8324 (shortlisp): Remove.
8325 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8326
4a720484
GM
83272011-05-19 Glenn Morris <rgm@gnu.org>
8328
8329 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8330 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8331 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8332 (lisp): Set the order to that of loadup.el.
8333 (shortlisp): Make it a copy of $lisp.
8334 (SOME_MACHINE_LISP): Remove.
8335 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8336 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8337
a28d4396
KH
83382011-05-18 Kenichi Handa <handa@m17n.org>
8339
8340 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8341 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8342 (find_automatic_composition): Mostly rewrite for efficiency.
8343
a2b1fa8e
JB
83442011-05-18 Juanma Barranquero <lekktu@gmail.com>
8345
8346 * makefile.w32-in: Update dependencies.
8347
8e1f5610
CS
83482011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8349
8350 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8351 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8352
7025ee00 83532011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8354
cdfa6eab
PE
8355 Fix some integer overflow issues, such as string length overflow.
8356
06d6db33
PE
8357 * insdel.c (count_size_as_multibyte): Check for string overflow.
8358
2b4560a8
PE
8359 * character.c (lisp_string_width): Check for string overflow.
8360 Use EMACS_INT, not int, for string indexes and lengths; in
8361 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8362 the resulting string length overflows an EMACS_INT; instead,
8363 report a string overflow if no precision given. When checking for
8364 precision exhaustion, use a check that cannot possibly have
8365 integer overflow. (Bug#8675)
8366 * character.h (lisp_string_width): Adjust to new signature.
8367
cb93f9be
PE
8368 * alloc.c (string_overflow): New function.
8369 (Fmake_string): Use it. This doesn't change behavior, but saves
8370 a few bytes and will simplify future changes.
8371 * character.c (string_escape_byte8): Likewise.
8372 * lisp.h (string_overflow): New decl.
8373
1a1f3366
PE
8374 Fixups, following up to the user-interface timestamp change.
8375 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8376 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8377 * msdos.c (mouse_get_pos): Likewise.
8378 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8379 * w32gui.h (Time): Define by including "systime.h" rather than by
8380 declaring it ourselves. (Bug#8664)
8381
d4e3e4d3
PE
8382 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8383 * image.c (clear_image_cache): Likewise.
8384
f6a24d19
PE
8385 * term.c (term_mouse_position): Don't assume time_t wraparound.
8386
08dc5ae6
PE
8387 Be more systematic about user-interface timestamps.
8388 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8389 and sometimes 'EMACS_UINT', to represent these timestamps.
8390 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8391 This makes the code easier to follow, and makes it easier to catch
8392 integer overflow bugs such as Bug#8664.
8393 * frame.c (Fmouse_position, Fmouse_pixel_position):
8394 Use Time, not unsigned long, for user-interface timestamps.
8395 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8396 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8397 * keyboard.h (last_event_timestamp): Likewise.
8398 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8399 * menu.h (xmenu_show): Likewise.
8400 * term.c (term_mouse_position): Likewise.
8401 * termhooks.h (struct input_event.timestamp): Likewise.
8402 (struct terminal.mouse_position_hook): Likewise.
8403 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8404 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8405 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8406 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8407 what it was before.
8408 * menu.h, termhooks.h: Include "systime.h", for Time.
8409
8e55734a
PE
8410 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8411 Don't assume that the difference between two unsigned long values
8412 can fit into an integer. At this point, we know button_down_time
8413 <= event->timestamp, so the difference must be nonnegative, so
8414 there's no need to cast the result if double-click-time is
8415 nonnegative, as it should be; check that it's nonnegative, just in
8416 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8417 apart (about 25 days). (Bug#8664)
8e55734a 8418
841f1b75 8419 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8420 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8421
3e26f69c
PE
8422 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8423 that always fit in int. Use a sentinel instead of a counter, to
8424 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8425 * frame.h (struct frame): Use int for menu_bar_items_used
8426 instead of EMACS_INT, since it always fits in int.
3e26f69c 8427
5cc152c0
PE
8428 * menu.c (grow_menu_items): Check for int overflow.
8429
d89eb65e
PE
8430 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8431
5235bd3e
PE
8432 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8433 Before, the code was not consistent. These values cannot exceed
8434 2**31 - 1 so there's no need to make them unsigned.
8435 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8436 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8437 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8438 as modifiers.
8439 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8440
bc827e23
PE
8441 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8442 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8443 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8444 presumably because the widths might not match.
8445
78eb494e
PE
8446 * window.c (size_window): Avoid needless test at loop start.
8447
04f2d78b
CB
84482011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8449
8450 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8451
d2fc7e3d 84522011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8453
8454 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8455
d2fc7e3d 84562011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8457
8458 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8459 `width' to `bar_area_x' and `bar_area_width', respectively.
8460 (x_scroll_run): Take account of fringe background extension.
8461
04f2d78b
CB
8462 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8463 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8464 `bar_area_width', respectively.
8465 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8466 background extension.
8467
79b70037
GM
84682011-05-10 Jim Meyering <meyering@redhat.com>
8469
8470 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8471
2f142cc5
JB
84722011-05-10 Juanma Barranquero <lekktu@gmail.com>
8473
8474 * image.c (Finit_image_library): Return t for built-in image types,
8475 like pbm and xbm. (Bug#8640)
8476
57679c86
AS
84772011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8478
8479 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8480
888c9e86
EZ
84812011-05-07 Eli Zaretskii <eliz@gnu.org>
8482
b0512a1d
EZ
8483 * w32console.c (Fset_screen_color): Doc fix.
8484 (Fget_screen_color): New function.
8485 (syms_of_ntterm): Defsubr it.
8486
7285dc67
EZ
8487 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8488 unlink the temporary file if Fcall_process didn't create it in the
8489 first place.
8490 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8491 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8492 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8493 cue to call_process_cleanup not to close that handle.
8494
4d3fcc8e
BK
84952011-05-07 Ben Key <bkey76@gmail.com>
8496
8497 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8498 one of two shell specific rules, either bootstrap-temacs-CMD or
8499 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8500 to the previous implementation of the bootstrap-temacs rule.
8501 The bootstrap-temacs-CMD rule is similar to the previous
8502 implementation of the bootstrap-temacs rule except that it
8503 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8504 variable.
8505
8506 These changes, along with some changes to nt/configure.bat,
8507 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8508 earlier fix to add support for --cflags and --ldflags options
8509 that include quotes so that it works whether make uses cmd or
8510 sh as the shell.
8511
b4289b64
MA
85122011-05-06 Michael Albinus <michael.albinus@gmx.de>
8513
8514 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8515 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8516 is a constant.
8517 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8518 a string. Handle both cases.
8519 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8520 (Fdbus_register_method): Use Qinvalid_function.
8521
af4c0e28
JB
85222011-05-06 Juanma Barranquero <lekktu@gmail.com>
8523
8524 * makefile.w32-in: Update dependencies.
8525 (LISP_H): Add inttypes.h and stdin.h.
8526 (PROCESS_H): Add unistd.h.
8527
c51453d9
EZ
85282011-05-06 Eli Zaretskii <eliz@gnu.org>
8529
8530 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8531 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8532
8ff0ac3c 85332011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8534
4c4b566b
PE
8535 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8536
aab2b9b5
PE
8537 * term.c (vfatal): Remove stray call to va_end.
8538 It's not needed and the C Standard doesn't allow it here anyway.
8539
c378da0b
PE
8540 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8541 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8542
288b08c7
PE
8543 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8544 bytes.
8545
e3601888
PE
8546 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8547
db6c0e74
PE
8548 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8549
dd5963ea
PE
8550 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8551
88c9450f
PE
8552 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8553
2f9442b8
PE
8554 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8555
c032b5f8
PE
8556 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8557 * charset.c (Fdefine_charset_internal): Don't initialize
8558 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8559 32-bit int (Bug#8600).
a108c10b
PE
8560
8561 * lread.c (read_integer): Be more consistent with string-to-number.
8562 Use string_to_number to do the actual conversion; this avoids
8563 rounding errors and fixes some other screwups. Without this fix,
8564 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8565 (digit_to_number): Move earlier, for benefit of read_integer.
8566 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8567 not a digit in any supported base. (Bug#8602)
a108c10b 8568
ad5f9eea
PE
8569 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8570
aec1708a
PE
8571 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8572 to match comment at start of function. This also removes a
8573 GCC warning about overflow in a 32+64-bit port.
8574
47be4ab5
PE
8575 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8576
371cac43
PE
8577 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8578 Reported by Stefan Monnier in
8579 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8580 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8581 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8582
d01a7826
PE
8583 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8584 (EMACS_UINTPTR): Likewise, with uintptr_t.
8585
7fd47d5c
PE
8586 * lisp.h: Prefer 64-bit EMACS_INT if available.
8587 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8588 on 32-bit hosts that have 64-bit int, so that they can access
8589 large files.
122b0c86
PE
8590 However, temporarily disable this change unless the temporary
8591 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8592
8727937b
PE
8593 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8594
8ac068ac
PE
8595 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8596 This removes an assumption that EMACS_INT and long are the same
8597 width as pointers. The assumption is true for Emacs porting targets
8598 now, but we want to make other targets possible.
8599 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8600 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8601 In the rest of the code, change types of integers that hold casted
8602 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8603 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8604 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8605 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8606 No need to cast type when ORing.
8607 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8608 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8609 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8610 assume EMACS_INT is the same width as char *.
8611 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8612 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8613 Remove no-longer-needed casts.
8614 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8615 (xg_tool_bar_help_callback, xg_make_tool_item):
8616 Use EMACS_INTPTR to hold an integer
8617 that will be cast to void *; this can avoid a GCC warning
8618 if EMACS_INT is not the same width as void *.
8619 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8620 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8621 (current_message_1, set_message_1):
8622 Use a local to convert to proper width without a cast.
8623 * xmenu.c (dialog_selection_callback): Likewise.
8624
ede49d71
PE
8625 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8626 Also, don't assume VALBITS / RAND_BITS is less than 5,
8627 and don't rely on undefined behavior when shifting a 1 left into
8628 the sign bit.
8629 * lisp.h (get_random): Change signature to match.
8630
2f30ecd0
PE
8631 * lread.c (hash_string): Use size_t, not int, for hash computation.
8632 Normally we prefer signed values; but hashing is special, because
8633 it's better to use unsigned division on hash table sizes so that
8634 the remainder is nonnegative. Also, size_t is the natural width
8635 for hashing into memory. The previous code used 'int', which doesn't
8636 retain enough info to hash well into very large tables.
8637 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8638
2a866e7b
PE
8639 * dbusbind.c: Don't possibly lose pointer info when converting.
8640 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8641 Use XPNTR rather than XHASH, so that the high-order bits of
8642 the pointer aren't lost when converting through void *.
8643
51639eac
PE
8644 * eval.c (Fautoload): Don't double-shift a pointer.
8645
92394119
PE
8646 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8647
dbdb9a7c
JB
86482011-05-06 Juanma Barranquero <lekktu@gmail.com>
8649
8650 * gnutls.c (DEF_GNUTLS_FN):
8651 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8652
db7a0b4f
AS
86532011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8654
8655 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8656 marker. (Bug#8610)
8657
cd394be1 86582011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8659
8660 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8661 New version that can reserve upto 2GB of heap space.
8662
f7ff1b0f 86632011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8664
8665 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8666
639c109b
TZ
86672011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8668
8669 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8670 `gnutls_certificate_set_x509_key_file'.
8671
d2127135
JB
86722011-05-05 Juanma Barranquero <lekktu@gmail.com>
8673
8674 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8675 Update dependencies.
8676
e968f4f3
JB
86772011-05-04 Juanma Barranquero <lekktu@gmail.com>
8678
8679 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8680 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8681 Remove unused parameter `fildes'.
8682 * process.c (read_process_output, send_process): Don't pass it.
8683
84d358f0
JB
86842011-05-04 Juanma Barranquero <lekktu@gmail.com>
8685
8686 Fix previous change: the library cache is defined in w32.c.
8687 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8688 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8689
0898ca10
JB
86902011-05-04 Juanma Barranquero <lekktu@gmail.com>
8691
8692 Implement dynamic loading of GnuTLS on Windows.
8693
8694 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8695 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8696 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8697 Declare.
8698
8699 * gnutls.c (Qgnutls_dll): Define.
8700 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8701 (gnutls_*): Declare function pointers.
8702 (init_gnutls_functions): New function to initialize function pointers.
8703 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8704 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8705 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8706 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8707 (emacs_gnutls_write, emacs_gnutls_read)
8708 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8709 (Fgnutls_available_p): New function.
8710 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8711 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8712 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8713
8714 * image.c: Include w32.h.
8715 (Vimage_type_cache): Delete.
8716 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8717 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8718 (w32_delayed_load): Move to w32.c.
8719
8720 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8721
8722 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8723 (w32_delayed_load): Move from image.c. When loading a library, record
8724 its filename in the :loaded-from property of the library id.
8725 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8726 Initialize and staticpro them.
8727 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8728
8729 * process.c: Include lisp.h before w32.h, not after.
8730 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8731 instead of gnutls_record_check_pending.
8732
8733 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8734
ff4de4aa
TZ
87352011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8736
8737 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8738 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8739 as passed in.
8740
abe95abb
JD
87412011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8742
8743 * xterm.c (x_set_frame_alpha): Do not set property on anything
8744 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8745
e16e55d4
JB
87462011-05-02 Juanma Barranquero <lekktu@gmail.com>
8747
8748 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8749
bafcf6a5
JB
87502011-05-02 Juanma Barranquero <lekktu@gmail.com>
8751
8752 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8753 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8754 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8755 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8756 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8757 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8758 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8759 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8760 (Qgnutls_bootprop_callbacks_verify): Make static.
8761
e7a6747f
AS
87622011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8763
19ed11ba
AS
8764 * callproc.c: Indentation fixup.
8765
e7a6747f 8766 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8767 (wait_for_termination, interruptible_wait_for_termination):
8768 Move after wait_for_termination_1.
e7a6747f 8769
1ef14cb4
LMI
87702011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8771
8772 * sysdep.c (interruptible_wait_for_termination): New function
8773 which is like wait_for_termination, but allows keyboard
8774 interruptions.
8775
8776 * callproc.c (Fcall_process): Add (:file "file") as an option for
8777 the STDOUT buffer.
8778 (Fcall_process_region): Ditto.
8779
330d880c
EZ
87802011-04-30 Eli Zaretskii <eliz@gnu.org>
8781
8db90b73
EZ
8782 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8783 rather than `XVECTOR (FOO)->size'.
8784
330d880c
EZ
8785 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8786 inttypes.h, as a gnulib replacement is used if it not available in
8787 system headers.
8788
15cbd324
EZ
87892011-04-21 Eli Zaretskii <eliz@gnu.org>
8790
8791 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8792 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8793 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8794
8795 * coding.c (coding_alloc_by_realloc): Error out if destination
8796 will grow beyond MOST_POSITIVE_FIXNUM.
8797 (decode_coding_emacs_mule): Abort if there isn't enough place in
8798 charbuf for the composition carryover bytes. Reserve an extra
8799 space for up to 2 characters produced in a loop.
8800 (decode_coding_iso_2022): Abort if there isn't enough place in
8801 charbuf for the composition carryover bytes.
8802
88032011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8804
ae940cca
EZ
8805 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8806 aborting when %lld or %lll format is passed.
8807 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8808 %llo or %llx format is passed. (Bug#8545)
8809
03ab8921
EZ
8810 * window.c (window_scroll_line_based): Use a marker instead of
8811 simple variables to record original value of point. (Bug#7952)
8812
afda1437
EZ
8813 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8814 produced by %s or %c overflows available buffer space. (Bug#8545)
8815
f76dee0c
PE
88162011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8817
8818 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8819 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8820
fdc5744d
JB
88212011-04-28 Juanma Barranquero <lekktu@gmail.com>
8822
8823 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8824
638f053a
JB
88252011-04-28 Juanma Barranquero <lekktu@gmail.com>
8826
8827 * keyboard.c (Qdelayed_warnings_hook): Define.
8828 (command_loop_1): Run `delayed-warnings-hook'
8829 if Vdelayed_warnings_list is non-nil.
8830 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8831 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8832
d178f871
EZ
88332011-04-28 Eli Zaretskii <eliz@gnu.org>
8834
8835 * doprnt.c (doprnt): Don't return value smaller than the buffer
8836 size if the message was truncated. (Bug#8545).
8837
b124fd93
JB
88382011-04-28 Juanma Barranquero <lekktu@gmail.com>
8839
8840 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8841 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8842
e810457d
PE
88432011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8844
8845 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8846
ea51cceb
JB
88472011-04-27 Juanma Barranquero <lekktu@gmail.com>
8848
8849 * makefile.w32-in: Update dependencies.
8850
94dcfacf
EZ
88512011-04-27 Eli Zaretskii <eliz@gnu.org>
8852
8853 Improve `doprnt' and its usage. (Bug#8545)
8854 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8855 `format_end'. Remove support for %l as a conversion specifier.
8856 Don't use xrealloc. Improve diagnostics when the %l size modifier
8857 is used. Update the commentary.
8858
8859 * eval.c (verror): Simplify calculation of size_t.
8860
8861 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8862 messages.
8863
f61f41d7
PE
88642011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8865
8866 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8867 change.
8868
96fb4434
PE
88692011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8870
8871 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8872 This makes this file independent of the recent pseudovector change.
8873
671875da 88742011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8875
69e9b5a3
PE
8876 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8877
b5f869a7 8878 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8879 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8880 Remove unused local.
c8926152 8881 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8882
841a1577 8883 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8884 GCC 4.6.0 optimizes based on type-based alias analysis.
8885 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8886 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8887 != &v->size, and therefore "v->size = 1; b->size = 2; return
8888 v->size;" must therefore return 1. This assumption is incorrect
8889 for Emacs, since it type-puns struct Lisp_Vector * with many other
8890 types. To fix this problem, this patch adds a new type struct
f904488f 8891 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8892 and pseudovectors, and helps optimizing compilers not get fooled
8893 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8894 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8895 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8896 the size member.
eab3844f
PE
8897 (XSETPVECTYPE): Rewrite in terms of new macro.
8898 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8899 This is a bit clearer, and further avoids the possibility of
8900 undesirable aliasing.
8901 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8902 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8903 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8904 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8905 (ASIZE): Now uses header.size rather than size.
8906 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8907 to avoid the hassle of writing XVECTOR (foo)->header.size.
8908 (struct vectorlike_header): New type.
eab3844f
PE
8909 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8910 object, to help avoid aliasing.
8911 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8912 (SUBRP): Likewise, since Lisp_Subr is a special case.
8913 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8914 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8915 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8916 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8917 changed to be "header.size" and "header.next".
8918 * buffer.h (struct buffer): Likewise.
8919 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8920 * frame.h (struct frame): Likewise.
8921 * process.h (struct Lisp_Process): Likewise.
8922 * termhooks.h (struct terminal): Likewise.
8923 * window.c (struct save_window_data, struct saved_window): Likewise.
8924 * window.h (struct window): Likewise.
8925 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8926 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8927 * buffer.c (init_buffer_once): Likewise.
8928 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8929 special case.
8930 * process.c (Fformat_network_address): Use local var for size,
8931 for brevity.
8932
0df1eac5
PE
8933 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8934
847ab9d1 8935 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8936 * data.c (atof): Remove decl; no longer used or needed.
8937 (digit_to_number): Move to lread.c.
8938 (Fstring_to_number): Use new string_to_number function, to be
8939 consistent with how the Lisp reader treats infinities and NaNs.
8940 Do not assume that floating-point numbers represent EMACS_INT
8941 without losing information; this is not true on most 64-bit hosts.
8942 Avoid double-rounding errors, by insisting on integers when
8943 parsing non-base-10 numbers, as the documentation specifies.
8944 * lisp.h (string_to_number): New decl, replacing ...
8945 (isfloat_string): Remove.
bc0a5c13 8946 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8947 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8948 appears to have been a coding error. Similarly, do not accept
8949 strings like +-1e0 as floating point numbers. Do not report
8950 overflow for integer overflows unless the base is not 10 which
8951 means we have no simple and reliable way to continue.
8952 Break out the floating-point parsing into a new
8953 function string_to_number, so that Fstring_to_number parses
8954 floating point numbers consistently with the Lisp reader.
04f2d78b 8955 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8956 (E_CHAR, EXP_INT): Remove, replacing with ...
8957 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8958 (string_to_number): New function, replacing isfloat_string.
8959 This function checks for valid syntax and produces the resulting
8960 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8961 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8962 so that overflow for non-base-10 numbers is reported only when
8963 there's no portable and simple way to convert to floating point.
452f4150 8964
67769ffc
PE
8965 * textprop.c (set_text_properties_1): Rewrite for clarity,
8966 and to avoid GCC warning about integer overflow.
8967
c20db43f
PE
8968 * intervals.h (struct interval): Use EMACS_INT for members
8969 where EMACS_UINT might cause problems. See
8970 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8971 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8972 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8973 All uses changed.
37aa2f85
PE
8974 (offset_intervals): Tell GCC not to worry about length overflow
8975 when negating a negative length.
c20db43f 8976
2538aa2f
PE
8977 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8978 (overrun_check_free): Likewise.
8979
f2d3008d
PE
8980 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8981 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8982 word size.
8983
ec8df744
PE
8984 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8985 (gnutls_make_error): Rename local to avoid shadowing.
8986 (gnutls_emacs_global_deinit): ifdef out; not used.
8987 (Fgnutls_boot): Use const for pointer to readonly storage.
8988 Comment out unused local. Fix pointer signedness problems.
8989
640ee02d
PE
8990 * lread.c (openp): Don't stuff size_t into an 'int'.
8991 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8992 about possible signed overflow.
8993
6048fb2a
PE
8994 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8995 (GDK_KEY_g): Don't define if already defined.
8996 (xg_prepare_tooltip): Avoid pointer signedness problem.
8997 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8998
fa3c87e1
PE
8999 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9000 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9001
2172544b
PE
9002 * xfns.c (Fx_window_property): Simplify a bit,
9003 to make a bit faster and to avoid GCC 4.6.0 warning.
9004 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9005
9b821a21
PE
9006 * fns.c (internal_equal): Don't assume size_t fits in int.
9007
3c616cfa
PE
9008 * alloc.c (compact_small_strings): Tighten assertion a little.
9009
c2982e87
PE
9010 Replace pEd with more-general pI, and fix some printf arg casts.
9011 * lisp.h (pI): New macro, generalizing old pEd macro to other
9012 conversion specifiers. For example, use "...%"pI"d..." rather
9013 than "...%"pEd"...".
9014 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9015 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9016 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9017 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9018 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9019 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9020 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9021 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9022 64-bit hosts.
9023 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9024 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9025 * print.c (safe_debug_print, print_object): Likewise.
9026 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9027 to int.
6f04d126
PE
9028 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9029 avoiding the 0 flag, which is not portable.
c2982e87
PE
9030 * process.c (Fmake_network_process): Use pI to avoid cast.
9031 * region-cache.c (pp_cache): Likewise.
9032 * xdisp.c (decode_mode_spec): Likewise.
9033 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9034 behavior on 64-bit hosts with printf arg.
6f04d126 9035 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9036 (x_stop_queuing_selection_requests): Likewise.
9037 (x_get_window_property): Don't truncate byte count to an 'int'
9038 when tracing.
0b432f21 9039
5e073ec7
PE
9040 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9041 here, since it parses constructs like leading '-' and spaces,
9042 which are not wanted; and it overflows with large numbers.
9043 Instead, simply match F[0-9]+, which is what is wanted anyway.
9044
36372bf9
PE
9045 * alloc.c: Remove unportable assumptions about struct layout.
9046 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9047 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9048 (allocate_vectorlike, make_pure_vector): Use the new macros,
9049 plus offsetof, to remove unportable assumptions about struct layout.
9050 These assumptions hold on all porting targets that I know of, but
9051 they are not guaranteed, they're easy to remove, and removing them
9052 makes further changes easier.
9053
0b432f21
PE
9054 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9055 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9056 (string_overrun_cookie): Now const. Use initializers that
9057 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9058 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9059 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9060 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9061 multiple of sizeof (EMACS_INT); it need not be, if
9062 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9063 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9064
895009e1
JB
90652011-04-26 Juanma Barranquero <lekktu@gmail.com>
9066
9067 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9068
6a7a1b0b
TZ
90692011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9070
9071 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9072 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9073 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9074
841a1577 90752011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9076
9077 * lisp.h (Qdebug): List symbol.
895009e1 9078 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9079 * keyboard.c (debug-on-event): New variable.
9080 (handle_user_signal): Break into debugger when debug-on-event
9081 matches the current signal symbol.
9082
f2d3ba6f
DN
90832011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9084
9085 * alloc.c (check_sblock, check_string_bytes)
9086 (check_string_free_list): Convert to standard C.
9087
42ce4c63
TZ
90882011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9089
9090 * w32.c (emacs_gnutls_push): Fix typo.
9091
825cd63c
EZ
90922011-04-25 Eli Zaretskii <eliz@gnu.org>
9093
fb11d64d
EZ
9094 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9095 "cast to pointer from integer of different size".
9096
825cd63c
EZ
9097 Improve doprnt and its use in verror. (Bug#8545)
9098 * doprnt.c (doprnt): Document the set of format control sequences
9099 supported by the function. Use SAFE_ALLOCA instead of always
9100 using `alloca'.
9101
9102 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9103 is one byte too soon. Don't use xrealloc; instead xfree and
9104 xmalloc anew.
9105
e061a11b
TZ
91062011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9107
9108 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9109 callbacks stage.
9110
9111 * gnutls.c: Renamed global_initialized to
9112 gnutls_global_initialized. Added internals for the
9113 :verify-hostname-error, :verify-error, and :verify-flags
9114 parameters of `gnutls-boot' and documented those parameters in the
9115 docstring. Start callback support.
9173deec
JB
9116 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9117 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9118 on error. Return error code.
e061a11b
TZ
9119 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9120 (emacs_gnutls_read): Likewise.
9121 (Fgnutls_boot): Return handshake error code.
9122 (emacs_gnutls_handle_error): New function.
9123 (wsaerror_to_errno): Likewise.
9124
9125 * w32.h (emacs_gnutls_pull): Add prototype.
9126 (emacs_gnutls_push): Likewise.
9127
9128 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9129 (emacs_gnutls_push): Likewise.
9130
91312011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9132
9133 * process.c (wait_reading_process_output): Check if GnuTLS
9134 buffered some data internally if no FDs are set for TLS
9135 connections.
9136
9137 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9138 (LIBS): Link to USER_LIBS.
9139 ($(BLD)/gnutls.$(0)): New target.
9140
fa6996bc
EZ
91412011-04-24 Eli Zaretskii <eliz@gnu.org>
9142
eb35682e
EZ
9143 * xdisp.c (handle_single_display_spec): Rename the
9144 display_replaced_before_p argument into display_replaced_p, to
9145 make it consistent with the commentary. Fix typos in the
9146 commentary.
9147
e2ad650c
EZ
9148 * textprop.c (syms_of_textprop): Remove dead code.
9149 (copy_text_properties): Delete obsolete commentary about an
9150 interface that was deleted long ago. Fix typos in the description
9151 of arguments.
9152
1b2de274
EZ
9153 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9154 to changes in oldXMenu/XMenu.h from 2011-04-16.
9155 <menu_help_message, prev_menu_help_message>: Constify.
9156 (IT_menu_make_room): menu->help_text is now `const char **';
9157 adjust.
9158
9159 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9160 to changes in oldXMenu/XMenu.h from 2011-04-16.
9161 (struct XMenu): Declare `help_text' `const char **'.
9162
9163 * xfaces.c <Qunspecified>: Make extern again.
9164
9165 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9166 required by POSIX.
1b2de274 9167
762b15be
EZ
9168 * doc.c (get_doc_string): Improve the format passed to `error'.
9169
9170 * doprnt.c (doprnt): Improve commentary.
9171
9172 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9173
9174 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9175 them with etags.
9176
f1052e5d
EZ
9177 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9178 changes in globals.h immediately force recompilation.
762b15be
EZ
9179 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9180 $(CURDIR)/s/ms-w32.h.
9181 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9182
fa6996bc
EZ
9183 * character.c (Fchar_direction): Function deleted.
9184 (syms_of_character): Don't defsubr it.
9185 <char-direction-table>: Deleted.
9186
e6c3da20
EZ
91872011-04-23 Eli Zaretskii <eliz@gnu.org>
9188
9189 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9190 * doprnt.c: Include limits.h.
9191 (SIZE_MAX): New macro.
04f2d78b
CB
9192 (doprnt): Return a size_t value. 2nd arg is now size_t.
9193 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9194 Improve overflow protection. Support `l' modifier for integer
9195 conversions. Support %l conversion. Don't assume an EMACS_INT
9196 argument for integer conversions and for %c.
9197
9198 * lisp.h (doprnt): Restore prototype.
9199
9200 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9201 $(SRC)/character.h.
9202
9203 * Makefile.in (base_obj): Add back doprnt.o.
9204
9205 * deps.mk (doprnt.o): Add back prerequisites.
9206 (callint.o): Depend on character.h.
9207
9208 * eval.c (internal_lisp_condition_case): Include the handler
9209 representation in the error message.
9210 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9211 when breaking from the loop.
9212
9213 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9214
9215 * callint.c (Fcall_interactively): When displaying error message
9216 about invalid control letter, pass the character's codepoint, not
9217 a pointer to its multibyte form. Improve display of the character
9218 in octal and display also its hex code.
9219
9220 * character.c (char_string): Use %x to display the (unsigned)
9221 codepoint of an invalid character, to avoid displaying a bogus
9222 negative value.
9223
9224 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9225 `error', not SYMBOL_NAME itself.
9226
9227 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9228 character arguments to `error'.
9229
9230 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9231 to `error' in error message about FINAL_CHAR argument. Make sure
9232 FINAL_CHAR is a character, and use %c when it is passed as
9233 argument to `error'.
9234
4ffd0d6b 92352011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9236
9237 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9238
9239 * w32.c: Include <time.h>.
9240 (sys_localtime): New function.
9241
4ffd0d6b 92422011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9243
9244 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9245
4ffd0d6b 9246 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9247
4ffd0d6b 92482011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9249
4ffd0d6b
GM
9250 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9251 zombies (Bug#8467).
aac0c6e3 9252
04c56954
EZ
92532011-04-19 Eli Zaretskii <eliz@gnu.org>
9254
9255 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9256 gl_state.e_property when gl_state.object is Qt.
9257
9258 * insdel.c (make_gap_larger): Remove limitation of buffer size
9259 to <= INT_MAX.
9260
16a43933
CY
92612011-04-18 Chong Yidong <cyd@stupidchicken.com>
9262
9263 * xdisp.c (lookup_glyphless_char_display)
9264 (produce_glyphless_glyph): Handle cons cell entry in
9265 glyphless-char-display.
9266 (Vglyphless_char_display): Document it.
9267
9268 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9269 glyphless-char-display.
9270
4581706e
CY
92712011-04-17 Chong Yidong <cyd@stupidchicken.com>
9272
9273 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9274
9275 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9276
9277 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9278 definition for no-X builds.
9279
4887c6e2 92802011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9281
fd35b6f9
PE
9282 Static checks with GCC 4.6.0 and non-default toolkits.
9283
5c1ccb01
PE
9284 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9285
006c5daa
PE
9286 * process.c (keyboard_bit_set): Define only if SIGIO.
9287 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9288 (send_process): Repair possible setjmp clobbering.
9289
efc736d3
PE
9290 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9291
4e2fe2e6
PE
9292 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9293
f97334a2
PE
9294 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9295
4e75f29d
PE
9296 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9297 Define only if needed.
9298
90efadd1
PE
9299 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9300 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9301 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9302
3c647824
PE
9303 * dispextern.h (struct redisplay_interface): Rename param
9304 to avoid shadowing.
e264f262 9305 * termhooks.h (struct terminal): Likewise.
761383f4 9306 * xterm.c (xembed_send_message): Likewise.
3c647824 9307
b58c5c4a
PE
9308 * insdel.c (make_gap_smaller): Define only if
9309 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9310
cad59032
PE
9311 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9312 it.
9313
c339dc2e
PE
9314 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9315 so that we aren't warned about unused symbols.
9316
91a3e27b
PE
9317 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9318
399c71d3 9319 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9320
8ffc96f5
PE
9321 * xfns.c (x_real_positions): Mark locals as initialized.
9322
eef9bc79
PE
9323 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9324
098db9dd
PE
9325 * xterm.c: Fix problems found by static analysis with other toolkits.
9326 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9327 (x_dispatch_event): Declare static if USE_GTK, and
9328 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9329 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9330 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9331 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9332 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9333
eb18f6cc
PE
9334 * xmenu.c (menu_help_callback): Pointer type fixes.
9335 Use const pointers when pointing at readonly data. Avoid pointer
9336 signedness clashes.
9337 (FALSE): Remove unused macro.
9338 (update_frame_menubar): Remove unused decl.
9339
1fe72bf8
PE
9340 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9341
60d9e1db
PE
9342 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9343 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9344 (single_menu_item): Rename local to avoid shadowing.
9345
39261c26
PE
9346 * keyboard.c (make_lispy_event): Remove unused local var.
9347
018c5e19
PE
9348 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9349 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9350
63d2b86e
PE
9351 * bitmaps: Change bitmaps from unsigned char back to the X11
9352 compatible char. Avoid the old compiler warnings about
9353 out-of-range initializers by using, for example, '\xab' rather
9354 than 0xab.
9355
aefd87e1
PE
9356 * xgselect.c (xgselect_initialize): Check vs interface
9357 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9358
bf501fb9
PE
9359 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9360
e9829fdf
PE
9361 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9362 to read-only memory.
9363
1086c095
PE
9364 * fns.c (vector): Remove; this old hack is no longer needed.
9365
2baccd04 9366 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9367 Remove unused var.
dde42981 9368 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9369
72391843 9370 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9371
436c16df 9372 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9373 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9374 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9375
92bb796d 9376 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9377 (x_term_init): Remove local to avoid shadowing.
92bb796d 9378
764430a3 9379 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9380
9381 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9382 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9383
d1dfb56c
EZ
93842011-04-16 Eli Zaretskii <eliz@gnu.org>
9385
c4354cb4
EZ
9386 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9387
d1dfb56c
EZ
9388 Fix regex.c, syntax.c and friends for buffers > 2GB.
9389 * syntax.h (struct gl_state_s): Declare character position members
9390 EMACS_INT.
9391
9392 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9393
04f2d78b
CB
9394 * textprop.c (verify_interval_modification, interval_of):
9395 Declare arguments EMACS_INT.
d1dfb56c
EZ
9396
9397 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9398 EMACS_INT.
9399
9400 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9401
9402 * indent.c (Fvertical_motion): Local variable it_start is now
9403 EMACS_INT.
9404
9405 * regex.c (re_match, re_match_2, re_match_2_internal)
9406 (bcmp_translate, regcomp, regexec, print_double_string)
9407 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9408 (re_compile_pattern, re_exec): Declare arguments and local
9409 variables `size_t' and `ssize_t' and return values `regoff_t', as
9410 appropriate.
9411 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9412 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9413 <compile_stack_type>: `size' and `avail' are now `size_t'.
9414
9415 * regex.h <regoff_t>: Use ssize_t, not int.
9416 (re_search, re_search_2, re_match, re_match_2): Arguments that
9417 specify buffer/string position and length are now ssize_t and
9418 size_t. Return type is regoff_t.
9419
613052cd
BK
94202011-04-16 Ben Key <bkey76@gmail.com>
9421
9422 * nsfont.m: Fixed bugs in ns_get_family and
9423 ns_descriptor_to_entity that were caused by using free to
9424 deallocate memory blocks that were allocated by xmalloc (via
9425 xstrdup). This caused Emacs to crash when compiled with
9426 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9427 --enable-checking=xmallocoverrun). xfree is now used to
9428 deallocate these memory blocks.
9429
4170f62f 94302011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9431
71b41406
PE
9432 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9433
9587a89d
PE
9434 emacs_write: Accept and return EMACS_INT for sizes.
9435 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9436 et seq.
9437 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9438 Accept and return EMACS_INT.
9439 (emacs_gnutls_write): Return the number of bytes written on
9440 partial writes.
9441 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9442 (emacs_read, emacs_write): Remove check for negative size, as the
9443 Emacs source code has been audited now.
9587a89d
PE
9444 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9445 (emacs_read, emacs_write): Use it.
273a5f82
PE
9446 * process.c (send_process): Adjust to the new signatures of
9447 emacs_write and emacs_gnutls_write. Do not attempt to store
9448 a byte offset into an 'int'; it might overflow.
9587a89d 9449 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9450
3e047f51
PE
9451 * sound.c: Don't assume sizes fit in 'int'.
9452 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9453 Return EMACS_INT, not int.
3e047f51 9454 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9455 Accept EMACS_INT, not int.
9456 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9457 record read return values.
9458
cc39a9db
BK
94592011-04-15 Ben Key <bkey76@gmail.com>
9460
c9d0ec6d
JB
9461 * keyboard.c (Qundefined): Don't declare static since it is used
9462 in nsfns.m.
9463 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9464 static since they are used in nsfont.m.
cc39a9db 9465
6c60eb9f
SM
94662011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9467
9468 * process.c (Qprocessp): Don't declare static.
9469 * lisp.h (Qprocessp): Declare again.
9470
7990b61a
JB
94712011-04-15 Juanma Barranquero <lekktu@gmail.com>
9472
9473 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9474
5d4cb038
PE
94752011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9476
8bd7b830 9477 Improve C-level modularity by making more things 'static'.
cd64ea1d 9478
e3b27b31
PE
9479 Don't publish debugger-only interfaces to other modules.
9480 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9481 (verify_bytepos, count_markers): Move decls to the only modules
9482 that need them.
9483 * region-cache.h (pp_cache): Likewise.
9484 * window.h (check_all_windows): Likewise.
9485 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9486
5d4cb038
PE
9487 * sysdep.c (croak): Now static, if
9488 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9489 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9490
9491 * alloc.c (refill_memory_reserve): Now static if
9492 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9493 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9494
e87b6180
PE
9495 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9496 Define only if USE_LUCID.
9497
ac64929e
PE
9498 * xrdb.c (x_customization_string, x_rm_string): Now static.
9499
6f37259d
PE
9500 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9501 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9502
1683e3ab
PE
9503 * xdisp.c (draw_row_with_mouse_face): Now static.
9504 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9505
de9c2632
PE
9506 * window.h (check_all_windows): Mark externally visible.
9507
2b96acb7
PE
9508 * window.c (window_deletion_count): Now static.
9509
9510 * undo.c: Make symbols static if they're not exported.
9511 (last_undo_buffer, last_boundary_position, pending_boundary):
9512 Now static.
9513
50436f33
PE
9514 * textprop.c (interval_insert_behind_hooks): Now static.
9515 (interval_insert_in_front_hooks): Likewise.
9516
64520e5c
PE
9517 * term.c: Make symbols static if they're not exported.
9518 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9519 (max_frame_lines, tty_set_terminal_modes):
9520 (tty_reset_terminal_modes, tty_turn_off_highlight):
9521 (get_tty_terminal): Now static.
9522 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9523 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9524 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9525 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9526 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9527
1fa53021
PE
9528 * sysdep.c: Make symbols static if they're not exported.
9529 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9530 Now static.
9531 (sigprocmask_set, full_mask): Remove; unused.
9532 (wait_debugging): Mark as visible.
9533 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9534 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9535
d4b43b22
PE
9536 * syntax.c (syntax_temp): Define only if !__GNUC__.
9537
b7c513d0
PE
9538 * sound.c (current_sound_device, current_sound): Now static.
9539
989b29ad
PE
9540 * search.c (searchbufs, searchbuf_head): Now static.
9541
13a55a78
PE
9542 * scroll.c (scroll_cost): Remove; unused.
9543 * dispextern.h (scroll_cost): Remove decl.
9544
de68a1fc
PE
9545 * region-cache.h (pp_cache): Mark as externally visible.
9546
40ccffa6
PE
9547 * process.c: Make symbols static if they're not exported.
9548 (process_tick, update_tick, create_process, chan_process):
9549 (Vprocess_alist, proc_buffered_char, datagram_access):
9550 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9551 (deactivate_process): Mark defn as static, as well as decl.
9552 * lisp.h (create_process): Remove decl.
9553 * process.h (chan_process, Vprocess_alist): Remove decls.
9554
ad64fc97
PE
9555 * print.c: Make symbols static if they're not exported.
9556 (print_depth, new_backquote_output, being_printed, print_buffer):
9557 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9558 (print_interval, print_number_index, initial_stderr_stream):
9559 Now static.
9560 * lisp.h (Fprinc): Remove decl.
9561 (debug_output_compilation_hack): Mark as externally visible.
9562
adddb265
PE
9563 * sysdep.c (croak): Move decl from here to syssignal.h.
9564 * syssignal.h (croak): Put it here, so the API can be checked when
9565 'croak' is called from dissociate_if_controlling_tty.
9566
1717ede2
PE
9567 * minibuf.c: Make symbols static if they're not exported.
9568 (minibuf_save_list, choose_minibuf_frame): Now static.
9569 * lisp.h (choose_minibuf_frame): Remove decl.
9570
fa5fb2bc
PE
9571 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9572
1e3890d1
PE
9573 * lread.c: Make symbols static if they're not exported.
9574 (read_objects, initial_obarray, oblookup_last_bucket_number):
9575 Now static.
9576 (make_symbol): Remove; unused.
9577 * lisp.h (initial_obarray, make_symbol): Remove decls.
9578
8a1414fa
PE
9579 * keyboard.c: Make symbols static if they're not exported.
9580 (single_kboard, recent_keys_index, total_keys, recent_keys):
9581 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9582 (this_single_command_key_start, echoing, last_auto_save):
9583 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9584 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9585 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9586 (Vlispy_mouse_stem, double_click_count):
9587 Now static.
9588 (force_auto_save_soon): Define only if SIGDANGER.
9589 (ignore_mouse_drag_p): Now static if
9590 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9591 (print_help): Remove; unused.
9592 (stop_character, last_timer_event): Mark as externally visible.
9593 * keyboard.h (ignore_mouse_drag_p): Declare only if
9594 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9595 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9596 * lisp.h (echoing): Remove decl.
9597 (force_auto_save_soon): Declare only if SIGDANGER.
9598 * xdisp.c (redisplay_window): Simplify code, to make it more
9599 obvious that ignore_mouse_drag_p is not accessed if !defined
9600 USE_GTK && !defined HAVE_NS.
9601
93ea6e8f
PE
9602 * intervals.c: Make symbols static if they're not exported.
9603 (merge_properties_sticky, merge_interval_right, delete_interval):
9604 Now static.
9605 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9606
77382fcc
PE
9607 * insdel.c: Make symbols static if they're not exported.
9608 However, leave prepare_to_modify_buffer alone. It's never
9609 called from outside this function, but that appears to be a bug.
9610 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9611 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9612 (adjust_after_replace_noundo): Remove; unused.
9613 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9614 (signal_before_change): Remove decls.
77382fcc 9615
9306c32e
PE
9616 * indent.c (val_compute_motion, val_vmotion): Now static.
9617
cd44d2eb
PE
9618 * image.c: Make symbols static if they're not exported.
9619 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9620 if USE_GTK.
9621 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9622 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9623
ad9a7a06
PE
9624 * fringe.c (standard_bitmaps): Now static.
9625 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9626
81626931
PE
9627 * frame.c: Make symbols static if they're not exported.
9628 (x_report_frame_params, make_terminal_frame): Now static.
9629 (get_frame_param): Now static, unless HAVE_NS.
9630 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9631 (x_get_resource_string): Remove; not used.
9632 * frame.h (make_terminal_frame, x_report_frame_params):
9633 (x_get_resource_string); Remove decls.
9634 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9635 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9636
239f9db9
PE
9637 * font.c, fontset.c: Make symbols static if they're not exported.
9638 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9639 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9640 * font.c (font_close_object): Now static.
9641 * font.h (font_close_object): Remove.
9642 * fontset.c (FONTSET_OBJLIST): Remove.
9643 (free_realized_fontset) #if-0 the body, which does nothing.
9644 (face_suitable_for_char_p): #if-0, as it's never called.
9645 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9646 * xfaces.c (face_at_string_position):
9647 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9648 since 0 is always ASCII.
9649
dfcf3579
PE
9650 * fns.c (weak_hash_tables): Now static.
9651
5045092b
PE
9652 * fileio.c: Make symbols static if they're not exported.
9653 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9654 (Vwrite_region_annotation_buffers): Now static.
9655
57a96f5c
PE
9656 * eval.c: Make symbols static if they're not exported.
9657 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9658 * lisp.h (backtrace_list): Remove decl.
9659
35f08c38
PE
9660 * emacs.c: Make symbols static if they're not exported.
9661 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9662 (fatal_error_code, fatal_error_signal_hook, standard_args):
9663 Now static.
9664 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9665 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9666 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9667 * lisp.h (fatal_error_signal_hook): Remove decl.
9668 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9669
f44bd759
PE
9670 * editfns.c: Move a (normally-unused) function to its only use.
9671 * editfns.c, lisp.h (get_operating_system_release): Remove.
9672 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9673 worth the hassle of breaking this out.
9674
b532497d
PE
9675 * xterm.c: Make symbols static if they're not exported.
9676 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9677 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9678 (x_destroy_window, x_delete_display):
9679 Now static.
9680 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9681 (x_mouse_leave): Remove; unused.
9682 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9683 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9684 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9685 Remove decls.
9686 (x_mouse_leave): Declare only if WINDOWSNT.
9687 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9688 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9689 USE_X_TOOLKIT.
9690
1675728f
PE
9691 * ftxfont.c: Make symbols static if they're not exported.
9692 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9693 HAVE_FREETYPE.
9694 * font.h (ftxfont_driver): Likewise.
9695
e4cebfca
PE
9696 * xfns.c: Make symbols static if they're not exported.
9697 (x_last_font_name, x_display_info_for_name):
9698 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9699 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9700 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9701 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9702 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9703 (last_show_tip_args): Now static.
9704 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9705 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9706 (x_screen_planes): Remove; unused.
9707 * dispextern.h (x_screen_planes): Remove decl.
9708
5bf46f05
PE
9709 * dispnew.c: Make symbols static if they're not exported.
9710 * dispextern.h (redraw_garbaged_frames, scrolling):
9711 (increment_row_positions): Remove.
9712 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9713 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9714 Now static.
9715 (redraw_garbaged_frames): Remove; unused.
9716
435f4c28
PE
9717 * xfaces.c: Make symbols static if they're not exported.
9718 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9719 Remove decls.
9720 * xterm.h (defined_color): Remove decls.
9721 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9722 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9723 (menu_face_changed_default, defined_color, free_realized_face):
9724 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9725 (ascii_face_of_lisp_face): Remove; unused.
9726
8524aef3
PE
9727 * xdisp.c: Make symbols static if they're not exported.
9728 * dispextern.h (scratch_glyph_row, window_box_edges):
9729 (glyph_to_pixel_coords, set_cursor_from_row):
9730 (get_next_display_element, set_iterator_to_next):
9731 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9732 (show_mouse_face): Remove decls
9733 * frame.h (message_buf_print): Likewise.
9734 * lisp.h (pop_message, set_message, check_point_in_composition):
9735 Likewise.
9736 * xterm.h (set_vertical_scroll_bar): Likewise.
9737 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9738 (message_buf_print, scratch_glyph_row, displayed_buffer):
9739 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9740 (get_next_display_element, show_mouse_face, window_box_edges):
9741 (frame_to_window_pixel_xy, check_point_in_composition):
9742 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9743 (glyph_to_pixel_coords): Remove; unused.
9744
16390cd2
PE
9745 * dired.c (file_name_completion): Now static.
9746
9747 * dbusbind.c (xd_in_read_queued_messages): Now static.
9748
a25f4dfa
PE
9749 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9750 * data.c (circular_list_error): Remove.
9751
14a9c8df
PE
9752 * commands.h (last_point_position, last_point_position_buffer):
9753 (last_point_position_window): Remove decls.
9754 * keyboard.c: Make these variables static.
9755
04f2d78b
CB
9756 * coding.h (coding, code_convert_region, encode_coding_gap):
9757 Remove decls.
74ab6df5
PE
9758 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9759 (iso_code_class, detect_coding, code_convert_region): Now static.
9760 (encode_coding_gap): Remove; unused.
9761
38dfbee1
PE
9762 * chartab.c (chartab_chars, chartab_bits): Now static.
9763
a2cb4e63
PE
9764 * charset.h (charset_iso_8859_1): Remove decl.
9765 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9766 Now static.
9767
127198fd
PE
9768 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9769 * ccl.c (Vccl_program_table): Now static.
9770 (check_ccl_update): Remove; unused.
9771
d85b608f
PE
9772 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9773 * category.h: ... from here.
9774 * category.c (check_category_table, set_category_set): Now static.
9775
31cd66f3
PE
9776 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9777 * lisp.h: Remove these decls.
9778
c358e587
PE
9779 * buffer.c (buffer_count): Remove unused var.
9780
e78aecca
PE
9781 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9782 so that it's not optimized away.
9783 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9784 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9785 exported only to the debugger.
9786
e192d7d3 9787 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9788 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9789
92470028
PE
9790 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9791 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9792 was inaccessible from Lisp.
9793 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9794 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9795
244ed907
PE
9796 alloc.c: Import and export fewer symbols, and remove unused items.
9797 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9798 is defined.
9799 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9800 it's not optimized away by whole-program optimization.
9801 (message_enable_multibyte, free_misc): Remove.
9802 (catchlist, handlerlist, mark_backtrace):
9803 Declare only if BYTE_MARK_STACK.
9804 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9805 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9806 (message_enable_multibyte): Remove decl.
9807 (free_misc, interval_free_list, float_block, float_block_index):
9808 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9809 (cons_free_list, last_marked_index):
9810 Now static.
9811 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9812 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9813 (mark_backtrace): Define only if BYTE_MARK_STACK.
9814 * xdisp.c (message_enable_multibyte): Now static.
9815
61c2b50e 9816 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9817 This makes it easier for human readers (and static analyzers)
9818 to see whether these variables are used from other modules.
9819 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9820 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9821 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9822 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9823 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9824 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9825 * xmenu.c, xselect.c:
9826 Declare Q* vars static if they are not used in other modules.
9827 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9828 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9829 Remove decls of unexported vars.
9830 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9831
95c82688
PE
9832 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9833
16a97296
PE
9834 Make Emacs functions such as Fatom 'static' by default.
9835 This makes it easier for human readers (and static analyzers)
9836 to see whether these functions can be called from other modules.
9837 DEFUN now defines a static function. To make the function external
9838 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9839 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9840 (Finit_image_library):
16a97296
PE
9841 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9842 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9843 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9844 Remove decls, since these functions are now static.
9845 (Funintern, Fget_internal_run_time): New decls, since these functions
9846 were already external.
95c82688 9847
16a97296
PE
9848 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9849 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9850 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9851 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9852 * keyboard.c, keymap.c, lread.c:
9853 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9854 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9855 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9856 Mark functions with DEFUE instead of DEFUN,
9857 if they are used in other modules.
9858 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9859 decls for now-static functions.
9860 * buffer.h (Fdelete_overlay): Remove decl.
9861 * callproc.c (Fgetenv_internal): Mark as internal.
9862 * composite.c (Fremove_list_of_text_properties): Remove decl.
9863 (Fcomposition_get_gstring): New forward static decl.
9864 * composite.h (Fcomposite_get_gstring): Remove decl.
9865 * dired.c (Ffile_attributes): New forward static decl.
9866 * doc.c (Fdocumntation_property): New forward static decl.
9867 * eval.c (Ffetch_bytecode): New forward static decl.
9868 (Funintern): Remove extern decl; now in .h file where it belongs.
9869 * fileio.c (Fmake_symbolic_link): New forward static decl.
9870 * image.c (Finit_image_library): New forward static decl.
9871 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9872 * intervals.h (Fprevious_property_change):
9873 (Fremove_list_of_text_properties): Remove decls.
9874 * keyboard.c (Fthis_command_keys): Remove decl.
9875 (Fcommand_execute): New forward static decl.
9876 * keymap.c (Flookup_key): New forward static decl.
9877 (Fcopy_keymap): Now static.
9878 * keymap.h (Flookup_key): Remove decl.
9879 * process.c (Fget_process): New forward static decl.
9880 (Fprocess_datagram_address): Mark as internal.
9881 * syntax.c (Fsyntax_table_p): New forward static decl.
9882 (skip_chars): Remove duplicate decl.
9883 * textprop.c (Fprevious_property_change): New forward static decl.
9884 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9885 Now internal.
9886 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9887 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9888
785bbd42
PE
9889 * editfns.c (Fformat): Remove unreachable code.
9890
8b913b57
AS
98912011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9892
9893 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9894 change. (Bug#8496)
9895
a6744a35
EZ
98962011-04-13 Eli Zaretskii <eliz@gnu.org>
9897
9898 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9899 when at ZV. (Bug#8487)
9900
e7974947
AS
99012011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9902
baad03f0
AS
9903 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9904 (Bug#8437)
9905 * keyboard.c (parse_tool_bar_item): Likewise.
9906 * sound.c (sound_cleanup, alsa_close): Likewise.
9907 * termcap.c (tgetent): Likewise.
9908 * xfns.c (x_default_font_parameter): Likewise.
9909 * xsettings.c (read_and_apply_settings): Likewise.
9910
e7974947
AS
9911 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9912 (overrun_check_free): Protoize.
9913
28272684
PE
99142011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9915
9916 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9917 since callers should never pass a negative size.
9918 Change the signature to match that of plain 'read' and 'write'; see
9919 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9920 * lisp.h: Update prototypes of emacs_write and emacs_read.
9921
11997c76
EZ
99222011-04-11 Eli Zaretskii <eliz@gnu.org>
9923
9924 * xdisp.c (redisplay_window): Don't try to determine the character
9925 position of the scroll margin if the window start point w->startp
e896f03c 9926 is outside the buffer's accessible region. (Bug#8468)
11997c76 9927
8a2cbd72
EZ
99282011-04-10 Eli Zaretskii <eliz@gnu.org>
9929
9930 Fix write-region and its subroutines for buffers > 2GB.
9931 * fileio.c (a_write, e_write): Modify declaration of arguments and
9932 local variables to support buffers larger than 2GB.
9933 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9934
9935 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9936 argument, local variables, and return value.
9937
9938 * lisp.h: Update prototypes of emacs_write and emacs_read.
9939
9940 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9941
4073e537 99422011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9943
1ebfdcb6
PE
9944 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9945
b2ded58d
PE
9946 Fix more problems found by GCC 4.6.0's static checks.
9947
7d66342c
PE
9948 * xdisp.c (vmessage): Use a better test for character truncation.
9949
bbf47d44
PE
9950 * charset.c (load_charset_map): <, not <=, for optimization,
9951 and to avoid potential problems with integer overflow.
9248994d 9952 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9953 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9954 * editfns.c (Fformat): Likewise.
1e69125e 9955 * syntax.c (skip_chars): Likewise.
3befa583 9956
e3019616
PE
9957 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9958 This also lets GCC 4.6.0 generate slightly better loop code.
9959
becfa255
PE
9960 * callint.c (Fcall_interactively): <, not <=, for optimization.
9961 (Fcall_interactively): Count the number of arguments produced,
9962 not the number of arguments given. This is simpler and lets GCC
9963 4.6.0 generate slightly better code.
9964
dae0cd48
PE
9965 * ftfont.c: Distingish more carefully between FcChar8 and char.
9966 The previous code passed unsigned char * to a functions like
9967 strlen and xstrcasecmp that expect char *, which does not
9968 conform to the C standard.
9969 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9970 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9971 char * when the C standard requires it.
9972
76032d70
PE
9973 * keyboard.c (read_char): Remove unused var.
9974
eb3f1cc8
PE
9975 * eval.c: Port to Windows vsnprintf (Bug#8435).
9976 Include <limits.h>.
9977 (SIZE_MAX): Define if the headers do not.
9978 (verror): Do not give up if vsnprintf returns a negative count.
9979 Instead, grow the buffer. This ports to Windows vsnprintf, which
9980 does not conform to C99. Problem reported by Eli Zaretskii.
9981 Also, simplify the allocation scheme, by avoiding the need for
9982 calling realloc, and removing the ALLOCATED variable.
9983
70476b54
PE
9984 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9985
12020a9e
PE
9986 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9987 But keep the doprint source code for now, as we might revamp it
9988 and use it again (Bug#8435).
ea6c7ae6
PE
9989 * lisp.h (doprnt): Remove.
9990 * Makefile.in (base_obj): Remove doprnt.o.
9991 * deps.mk (doprnt.o): Remove.
9992
5fdb398c
PE
9993 error: Print 32- and 64-bit integers portably (Bug#8435).
9994 Without this change, on typical 64-bit hosts error ("...%d...", N)
9995 was used to print both 32- and 64-bit integers N, which relied on
9996 undefined behavior.
61bdb816 9997 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9998 * lisp.h (error, verror): Mark as printf-like functions.
9999 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10000 Report overflow in size calculations when allocating printf buffer.
10001 Do not truncate output string at its first null byte.
10002 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10003 Truncate the output at a character boundary, since vsnprintf does not
10004 do that.
10005 * charset.c (check_iso_charset_parameter): Convert internal
10006 character to string before calling 'error', since %c now has the
10007 printf meaning.
10008 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10009 overflow when computing char to be passed to 'error'. Do not
10010 pass Lisp_Object to 'error'; pass the integer instead.
10011 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10012 formatted with plain %d.
10013
b189fa66
PE
10014 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10015
bff87ef0
PE
10016 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10017
7e2cac20
PE
10018 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10019
ce4d90b5
PE
10020 * xterm.c (x_catch_errors): Remove duplicate declaration.
10021
266c9547
PE
10022 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10023
79c49ad2
PE
10024 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10025
368f4090
JM
100262011-04-10 Jim Meyering <meyering@redhat.com>
10027
10028 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10029 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10030 return ssize_t not "int", and use size_t as the buffer length.
10031 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10032 * gnutls.h: Update declarations.
10033 * process.c (read_process_output): Use ssize_t, to match.
10034 (send_process): Likewise.
10035
a32d4040
CY
100362011-04-09 Chong Yidong <cyd@stupidchicken.com>
10037
10038 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10039
8546720e 100402011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10041
04f2d78b
CB
10042 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10043 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10044
8546720e
GM
10045 * xterm.c (handle_one_xevent):
10046 * xmenu.c (create_and_show_popup_menu):
10047 * xselect.c (x_decline_selection_request)
10048 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10049
0a2f5c1a 100502011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10051
10052 Fix some uses of `int' instead of EMACS_INT.
10053 * search.c (string_match_1, fast_string_match)
10054 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10055 (scan_buffer, find_next_newline_no_quit)
10056 (find_before_next_newline, search_command, Freplace_match)
10057 (Fmatch_data): Make some `int' variables be EMACS_INT.
10058
10059 * xdisp.c (display_count_lines): 3rd argument and return value now
10060 EMACS_INT. All callers changed.
10061 (pint2hrstr): Last argument is now EMACS_INT.
10062
10063 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10064 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10065 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10066 (decode_coding_utf_16, decode_coding_emacs_mule)
10067 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10068 (decode_coding_ccl, decode_coding_charset)
10069 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10070 (decode_coding_iso_2022, decode_coding_emacs_mule)
10071 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10072 <char_offset, last_offset>: Declare EMACS_INT.
10073 (encode_coding_utf_8, encode_coding_utf_16)
10074 (encode_coding_emacs_mule, encode_invocation_designation)
10075 (encode_designation_at_bol, encode_coding_iso_2022)
10076 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10077 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10078 Declare EMACS_INT.
10079 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10080 (encode_invocation_designation): Last argument P_NCHARS is now
10081 EMACS_INT.
10082 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10083 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10084
10085 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10086 All users changed.
10087
10088 * ccl.c (Fccl_execute_on_string): Declare some variables
10089 EMACS_INT.
10090
8546720e 100912011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10092
10093 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10094
4e19a977
CS
100952011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10096
10097 * process.c (Fformat_network_address): Doc fix.
10098
87302331
R
100992011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10100
ee7683eb 10101 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10102
cbb59342
CY
101032011-04-08 Chong Yidong <cyd@stupidchicken.com>
10104
10105 * keyboard.c (read_char): Call Lisp function help-form-show,
10106 instead of using internal_with_output_to_temp_buffer.
10107 (Qhelp_form_show): New var.
e0d38eeb 10108 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10109
10110 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10111
10112 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10113
e67a13ab
CY
101142011-04-06 Chong Yidong <cyd@stupidchicken.com>
10115
04f2d78b
CB
10116 * process.c (Flist_processes): Remove to Lisp.
10117 (list_processes_1): Delete.
e67a13ab 10118
973f782d
EZ
101192011-04-06 Eli Zaretskii <eliz@gnu.org>
10120
7c106b1e
EZ
10121 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10122
973f782d
EZ
10123 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10124
41cf7d1a 101252011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10126
ca23cc88
PE
10127 Fix more problems found by GCC 4.6.0's static checks.
10128
f390e2d5
PE
10129 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10130
42eea0d0
PE
10131 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10132
b69769da 10133 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10134
f9541e84
PE
10135 * xdisp.c (vmessage): Mark as a printf-like function.
10136
13841b55
PE
10137 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10138
c136c10f
PE
10139 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10140
5e2d4a30
PE
10141 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10142 printf-like functions.
10143 (tiff_load): Add casts to remove these marks before passing them
10144 to system-supplied API.
10145
583f48b9
PE
10146 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10147
b25d760e
PE
10148 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10149 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10150 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10151 directly, rather than having caller test rule sign. This avoids
10152 some unnecessary tests.
10153 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10154 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10155 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10156
bc7b6697 10157 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10158 (xfont_open): Avoid unnecessary tests.
bc7b6697 10159
27ccc379
PE
10160 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10161
dcd5c89a
PE
10162 * composite.h, composite.c (composition_gstring_put_cache):
10163 Use EMACS_INT, not int, for length.
10164
b13a45c6
PE
10165 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10166 breaking out part of COMPOSITION_DECODE_RULE.
10167 (COMPOSITION_DECODE_RULE): Use it.
10168 * composite.c (get_composition_id): Remove unused local vars,
10169 by using the new macro.
10170
1e792e4d
PE
10171 * textprop.c (set_text_properties_1): Change while to do-while,
10172 since the condition is always true at first.
10173
dc6c6455 10174 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10175 (interval_deletion_adjustment): Return unsigned value.
10176 All uses changed.
dc6c6455 10177
aba7731a
PE
10178 * process.c (list_processes_1, create_pty, read_process_output):
10179 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10180 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10181 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10182 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10183 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10184
fdfc4bf3
PE
10185 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10186
fca8fe46 10187 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10188 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10189
06a0259a 10190 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10191 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10192 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10193
e7b9e80f
PE
10194 * print.c (print_error_message): Avoid int overflow.
10195
56201685
PE
10196 * font.c (font_list_entities): Redo for clarity,
10197 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10198
78834453 10199 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10200 (font_score): Avoid potential overflow in diff calculation.
78834453 10201
0bc0b309 10202 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10203 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10204
e610eaca
PE
10205 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10206
b895abce
PE
10207 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10208 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10209 can always succeed if overflow has undefined behavior.
10210
1f1d9321 10211 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10212 (wordify): Omit three unnecessary tests.
1f1d9321 10213
c59478bc
PE
10214 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10215 All callers changed. This avoids the need for an unused var.
10216
79b73827
PE
10217 * casefiddle.c (casify_region): Remove var that is set but not used.
10218
a4db5dfe
PE
10219 * dired.c (file_name_completion): Remove var that is set but not used.
10220
43aae36e
PE
10221 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10222
2a47c44d 10223 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10224 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10225
a37c69bf
PE
10226 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10227 Check for integer overflow on size calculations.
10228
328ab8e7
PE
10229 * buffer.c (Fprevious_overlay_change): Remove var that is set
10230 but not used.
10231
e5a2a5cb
PE
10232 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10233 Remove vars that are set but not used.
8d84a6eb 10234 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10235 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10236
a60e5f68
PE
10237 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10238
f661cb61 10239 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10240 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10241
f0397f5a
PE
10242 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10243 that are set but not used.
10244
8664db06 10245 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10246 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10247
6abdaa4a
PE
10248 * xselect.c (x_get_local_selection, x_handle_property_notify):
10249 Remove vars that are set but not used.
10250
0ce7538d 10251 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10252 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10253
9ae848fc
PE
10254 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10255 Remove var that is set but not used.
0b918413
PE
10256 (scroll_bar_windows_size): Now size_t, not int.
10257 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10258 Check for overflow.
9ae848fc 10259
a5a62657
PE
10260 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10261 (map_tty_color) [!defined MSDOS]: Likewise.
10262
5c5cdd39
PE
10263 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10264
66ebf983
PE
10265 * coding.c: Remove vars that are set but not used.
10266 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10267 All callers changed.
10268 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10269 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10270 (decode_coding_charset): Remove vars that are set but not used.
10271
1be4d761
PE
10272 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10273 that is set but not used.
10274
47553fa8
PE
10275 * print.c (print_object): Remove var that is set but not used.
10276
1f7196bf 10277 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10278 The gnulib version avoids calling malloc in the usual case,
10279 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10280 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10281 * filelock.c (current_lock_owner): Likewise.
10282 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10283 * sysdep.c: Include allocator.h, careadlinkat.h.
10284 (emacs_no_realloc_allocator): New static constant.
10285 (emacs_readlink): New function.
fdb61804
PE
10286 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10287 ../lib/careadlinkat.h.
d1fdcab7 10288
f84c17c7
SM
102892011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10290
10291 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10292 first non-nil return value).
10293
ef3862ad
JD
102942011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10295
10296 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10297 if not defined (Bug#8403).
10298
376a7006
JB
102992011-04-02 Juanma Barranquero <lekktu@gmail.com>
10300
10301 * xdisp.c (display_count_lines): Remove parameter `start',
10302 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10303 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10304 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10305 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10306 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10307 and thereabouts. All callers changed.
10308 (get_per_char_metric): Remove parameter `f', unused since
10309 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10310
6ca3801d
JM
103112011-04-02 Jim Meyering <meyering@redhat.com>
10312
10313 do not dereference NULL upon failed strdup
10314 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10315 (ns_get_family): Likewise.
10316
d8e2b5ba
JB
103172011-04-02 Juanma Barranquero <lekktu@gmail.com>
10318
10319 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10320
8c74fcbd
JD
103212011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10322
10323 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10324 later (Bug#8403).
10325
7200d79c
SM
103262011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10327
03408648 10328 Add lexical binding.
7200d79c 10329
03408648
SM
10330 * window.c (Ftemp_output_buffer_show): New fun.
10331 (Fsave_window_excursion):
10332 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10333
10334 * lread.c (lisp_file_lexically_bound_p): New function.
10335 (Fload): Bind Qlexical_binding.
10336 (readevalloop): Remove `evalfun' arg.
10337 Bind Qinternal_interpreter_environment.
10338 (Feval_buffer): Bind Qlexical_binding.
10339 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10340 Mark as dynamic.
10341 (syms_of_lread): Declare `lexical-binding'.
10342
10343 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10344
10345 * keyboard.c (eval_dyn): New fun.
10346 (menu_item_eval_property): Use it.
ca105506
SM
10347
10348 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10349
03408648
SM
10350 * fns.c (concat, mapcar1): Accept byte-code-functions.
10351
10352 * eval.c (Fsetq): Handle lexical vars.
10353 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10354 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10355 (FletX, Flet): Obey lexical binding.
10356 (Fcommandp): Handle closures.
10357 (Feval): New `lexical' arg.
10358 (eval_sub): New function extracted from Feval. Use it almost
10359 everywhere where Feval was used. Look up vars in lexical env.
10360 Handle closures.
10361 (Ffunctionp): Move from subr.el.
10362 (Ffuncall): Handle closures.
10363 (apply_lambda): Remove `eval_flags'.
10364 (funcall_lambda): Handle closures and new byte-code-functions.
10365 (Fspecial_variable_p): New function.
10366 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10367 but without exporting it to Lisp.
23aba0ea 10368
23aba0ea 10369 * doc.c (Fdocumentation, store_function_docstring):
03408648 10370 * data.c (Finteractive_form): Handle closures.
23aba0ea 10371
03408648
SM
10372 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10373 interactive spec.
ba83908c 10374
04f2d78b
CB
10375 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10376 New byte-codes.
03408648
SM
10377 (exec_byte_code): New function extracted from Fbyte_code to handle new
10378 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10379
03408648 10380 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10381
03408648 10382 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10383
e2abce01
JB
103842011-03-31 Juanma Barranquero <lekktu@gmail.com>
10385
10386 * xdisp.c (redisplay_internal): Fix prototype.
10387
63696a73 103882011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10389
63696a73 10390 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10391 (try_scrolling): Use it when setting scroll_limit.
10392 Limit scrolling to 100 screen lines.
63696a73
EZ
10393 (redisplay_window): Even when falling back on "recentering",
10394 position point in the window according to scroll-conservatively,
10395 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10396
10397 (try_scrolling): When point is above the window, allow searching
10398 as far as scroll_max, or one screenful, to compute vertical
10399 distance from PT to the scroll margin position. This prevents
10400 try_scrolling from unnecessarily failing when
10401 scroll-conservatively is set to a value slightly larger than the
10402 window height. Clean up the case of PT below the margin at bottom
10403 of window: scroll_max can no longer be INT_MAX. When aggressive
10404 scrolling is in use, don't let point enter the opposite scroll
10405 margin as result of the scroll.
10406 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10407 threshold of 100 lines for never-recentering scrolling.
10408
e4cc2dfc
JB
104092011-03-31 Juanma Barranquero <lekktu@gmail.com>
10410
10411 * dispextern.h (move_it_by_lines):
10412 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10413 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10414 (message_log_check_duplicate): Remove parameters `prev_bol' and
10415 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10416 (redisplay_internal): Remove parameter `preserve_echo_area',
10417 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10418
10419 * indent.c (Fvertical_motion):
10420 * window.c (window_scroll_pixel_based, Frecenter):
10421 Don't pass `need_y_p' to `move_it_by_lines'.
10422
1c470562
SM
104232011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10424
44f230aa
SM
10425 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10426 steal a few bits to be more compact.
10427 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10428 Remove unneeded casts.
10429
1c470562
SM
10430 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10431
888adce9
ZK
104322011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10433
10434 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10435 binding" message (bug#7967).
10436
f838ed7b
PE
104372011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10438
77861b95
PE
10439 Fix more problems found by GCC 4.6.0's static checks.
10440
de6dbc14
PE
10441 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10442 Remove unused local var.
10443
f838ed7b
PE
10444 * editfns.c (Fmessage_box): Remove unused local var.
10445
792c7b2b
PE
10446 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10447 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10448 Omit unused local vars.
c499e557 10449 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10450 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10451 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10452 Omit unused local var.
10453
ba0165e1
PE
10454 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10455 Don't assume string length fits in int.
32ad8845 10456 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10457 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10458
3c59b4c9
PE
10459 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10460 instead of alloca (Bug#8344).
10461
a3eed478 10462 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10463 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10464
eb4d412d
PE
10465 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10466
1658b401
PE
10467 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10468 concerns.
10469
10470 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10471
10472 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10473
9a2c6e05
PE
10474 * keyboard.c (syms_of_keyboard): Use the same style as later
10475 in this function when indexing through an array. This also
10476 works around GCC bug 48267.
10477
03d0a109
PE
10478 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10479
44f730c8
PE
10480 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10481
fe75f926
PE
10482 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10483 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10484
ffa8c828
PE
10485 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10486 This avoids undefined behavior on integer overflow, and is a bit
10487 more convenient anyway since it is compared to a size_t variable.
10488
c5101a77
PE
10489 Variadic C functions now count arguments with size_t, not int.
10490 This avoids an unnecessary limitation on 64-bit machines, which
10491 caused (substring ...) to crash on large vectors (Bug#8344).
10492 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10493 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10494 All variadic functions and their callers changed accordingly.
c5101a77
PE
10495 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10496 * data.c (arith_driver, float_arith_driver): Likewise.
10497 * editfns.c (general_insert_function): Likewise.
10498 * eval.c (struct backtrace.nargs, interactive_p)
10499 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10500 (funcall_lambda, mark_backtrace): Likewise.
10501 * fns.c (concat): Likewise.
10502 * frame.c (x_set_frame_parameters): Likewise.
10503 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10504 0 if not found, not -1. All callers changed.
10505
dd3f25f7
PE
10506 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10507 (stack_copy_size): Now size_t, not int.
10508 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10509
461c2ab9
JB
105102011-03-28 Juanma Barranquero <lekktu@gmail.com>
10511
10512 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10513 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10514 All callers changed.
10515
10516 * lisp.h (multibyte_char_to_unibyte):
10517 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10518 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10519 * character.h (CHAR_TO_BYTE8):
10520 * cmds.c (internal_self_insert):
10521 * editfns.c (general_insert_function):
10522 * keymap.c (push_key_description):
10523 * search.c (Freplace_match):
10524 * xdisp.c (message_dolog, set_message_1): All callers changed.
10525
f6d62986
SM
105262011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10527
10528 * keyboard.c (safe_run_hook_funcall): New function.
10529 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10530 don't set the hook to nil, but remove the offending function instead.
10531 (Qcommand_hook_internal): Remove, unused.
10532 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10533 Vcommand_hook_internal.
10534
10535 * eval.c (enum run_hooks_condition): Remove.
10536 (funcall_nil, funcall_not): New functions.
10537 (run_hook_with_args): Call each function through a `funcall' argument.
10538 Remove `cond' argument, now redundant.
10539 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10540 (Frun_hook_with_args_until_failure): Adjust accordingly.
10541 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10542
1db5b1ad
JB
105432011-03-28 Juanma Barranquero <lekktu@gmail.com>
10544
10545 * dispextern.h (string_buffer_position): Remove declaration.
10546
10547 * print.c (strout): Remove parameter `multibyte', unused since
10548 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10549
10550 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10551 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10552 All callers changed.
10553
10554 * w32.c (_wsa_errlist): Use braces for struct initializers.
10555
10556 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10557 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10558 All callers changed.
10559 (string_buffer_position): Likewise. Also, make static (it's never
10560 used outside xdisp.c).
10561 (cursor_row_p): Remove parameter `w', unused since
10562 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10563 (decode_mode_spec): Remove parameter `precision', introduced during
10564 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10565 All callers changed.
10566
5ffb62aa
JD
105672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10568
10569 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10570
461c2ab9 105712011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10572
10573 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10574 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10575 (ns_update_auto_hide_menu_bar): New functions.
10576 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10577 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10578 ns_constrain_all_frames.
10579 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10580 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10581
5c380ffb
JD
105822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10583
10584 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10585
9af30bdf
GM
105862011-03-27 Glenn Morris <rgm@gnu.org>
10587
10588 * syssignal.h: Replace RETSIGTYPE with void.
10589 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10590 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10591 Replace SIGTYPE with void everywhere.
10592 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10593 * s/template.h (SIGTYPE): Remove commented out definition.
10594
e2abce01
JB
105952011-03-26 Eli Zaretskii <eliz@gnu.org>
10596
10597 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10598 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10599
f868cd8a
JB
106002011-03-26 Juanma Barranquero <lekktu@gmail.com>
10601
59eb0929
JB
10602 * w32.c (read_unc_volume): Use parameter `henum', instead of
10603 global variable `wget_enum_handle'.
10604
10605 * keymap.c (describe_vector): Remove parameters `indices' and
10606 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10607 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10608
f868cd8a
JB
10609 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10610
10611 * keyboard.c (timer_check): Remove parameter `do_it_now',
10612 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10613 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10614 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10615
10616 * keyboard.c (read_char):
10617 * w32menu.c (w32_menu_display_help):
10618 * xmenu.c (show_help_event, menu_help_callback):
10619 Adjust calls to `show_help_echo'.
10620
10621 * gtkutil.c (xg_maybe_add_timer):
10622 * keyboard.c (readable_events):
10623 * process.c (wait_reading_process_output):
10624 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10625
10626 * insdel.c (adjust_markers_gap_motion):
10627 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10628 (gap_left, gap_right): Don't call it.
10629
2ecf6fdb
CY
106302011-03-25 Chong Yidong <cyd@stupidchicken.com>
10631
10632 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10633 incurred during fontification.
10634
6b1f9ba4
JB
106352011-03-25 Juanma Barranquero <lekktu@gmail.com>
10636
10637 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10638 (DEFVAR_PER_BUFFER): Don't pass it.
10639
10640 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10641 (scrolling_window): Don't pass it.
10642
0f4a96b5
JB
106432011-03-25 Juanma Barranquero <lekktu@gmail.com>
10644
10645 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10646
10647 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10648 and `suffix'.
10649 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10650 of variables specific to SELinux and computation of `encoded_absname'.
10651
10652 * image.c (XPutPixel): Remove unused variable `height'.
10653
10654 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10655
10656 * unexw32.c (get_section_info): Remove unused variable `section'.
10657
10658 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10659 (system_process_attributes): Remove unused variable `sess'.
10660 (sys_read): Remove unused variable `err'.
10661
10662 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10663 (w32_wnd_proc): Remove unused variable `isdead'.
10664 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10665 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10666 (x_create_tip_frame): Remove unused variable `tem'.
10667
10668 * w32inevt.c (w32_console_read_socket):
10669 Remove unused variable `no_events'.
10670
10671 * w32term.c (x_draw_composite_glyph_string_foreground):
10672 Remove unused variable `width'.
10673
1149507c
JB
106742011-03-24 Juanma Barranquero <lekktu@gmail.com>
10675
10676 * w32term.c (x_set_glyph_string_clipping):
10677 Don't pass uninitialized region to CombineRgn.
10678
9c88f339
JB
106792011-03-23 Juanma Barranquero <lekktu@gmail.com>
10680
10681 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10682 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10683 (Fx_close_connection): Remove unused variable `i'.
10684
10685 * w32font.c (w32font_draw): Return number of glyphs.
10686 (w32font_open_internal): Remove unused variable `i'.
10687 (w32font_driver): Add missing initializer.
10688
10689 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10690 (fill_in_menu): Remove unused variable `items_added'.
10691
10692 * w32term.c (last_mouse_press_frame): Remove static global variable.
10693 (w32_clip_to_row): Remove unused variable `f'.
10694 (x_delete_terminal): Remove unused variable `i'.
10695
10696 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10697 (NOTHING): Remove unused static global variable.
10698 (uniscribe_check_otf): Remove unused variable `table'.
10699 (uniscribe_font_driver): Add missing initializers.
10700
dee091a3
JD
107012011-03-23 Julien Danjou <julien@danjou.info>
10702
10703 * term.c (Fsuspend_tty, Fresume_tty):
10704 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10705 * window.c (temp_output_buffer_show):
10706 * insdel.c (signal_before_change):
10707 * frame.c (Fhandle_switch_frame):
10708 * fileio.c (Fdo_auto_save):
10709 * emacs.c (Fkill_emacs):
10710 * editfns.c (save_excursion_restore):
10711 * cmds.c (internal_self_insert):
10712 * callint.c (Fcall_interactively):
10713 * buffer.c (Fkill_all_local_variables):
10714 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10715 Use Frun_hooks.
0f4a96b5 10716 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10717 unconditionally since it does the check itself.
dee091a3 10718
2c520ab5 107192011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10720
c9c49752
PE
10721 Fix more problems found by GCC 4.5.2's static checks.
10722
8abc3f12
PE
10723 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10724 the first time through the loop, since we know p0 < p1 then.
10725 This also avoids a gcc -Wstrict-overflow warning.
10726
a2d26660
PE
10727 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10728 leading to a memory leak, possible in functions like
10729 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10730 of objects (Bug#8318).
a2d26660 10731
916c72e9
PE
10732 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10733 that could (at least in theory) be that large.
10734
19ab8a18
PE
10735 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10736 This is less likely to overflow, and avoids undefined behavior if
10737 overflow does occur. All callers changed. Use strtoul to scan
10738 for the unsigned long integer.
b7cbbd6f
PE
10739 (pint2hrstr): Simplify and tune code slightly.
10740 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10741
f0641eff
PE
10742 * scroll.c (do_scrolling): Work around GCC bug 48228.
10743 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10744
7f650bb9
PE
10745 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10746 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10747 (validate_x_resource_name): Simplify count usage.
10748 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10749
37dd57d1
PE
10750 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10751 fail (Bug#8306).
81e56e61 10752
699979fc 10753 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10754
401bf9b4
PE
10755 * process.c (Fmake_network_process): Use socklen_t, not int,
10756 where POSIX says socklen_t is required in portable programs.
10757 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10758 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10759 (Fmake_network_process, server_accept_connection):
10760 (wait_reading_process_output, read_process_output):
10761 Likewise.
10762
b93aacde
PE
10763 * process.c: Rename or move locals to avoid shadowing.
10764 (list_processes_1, Fmake_network_process):
10765 (read_process_output_error_handler, exec_sentinel_error_handler):
10766 Rename or move locals.
4dc343ee 10767 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10768 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10769 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10770 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10771 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10772
af8a867c 10773 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10774 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10775 Include tparam.h instead, since it declares them.
af8a867c
PE
10776 * cm.h (PC): Remove extern decl; tparam.h now does this.
10777 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10778 * terminfo.c: Include tparam.h, to check interfaces.
10779 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10780 (tparam): Adjust signature to match interface in tparam.h;
10781 this removes some undefined behavior. Check that outstring and len
10782 are zero, which they always are with Emacs.
10783 * tparam.h (PC, BC, UP): New extern decls.
10784
0248044d 10785 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10786 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10787
8ff096c1 10788 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10789 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10790 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10791 (ftfont_list): Remove unused local.
49eaafba
PE
10792 (get_adstyle_property, ftfont_pattern_entity):
10793 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10794 Rename locals to avoid shadowing.
8ff096c1 10795
e2be39f6
PE
10796 * xfont.c (xfont_list_family): Mark var as initialized.
10797
c9735e30
PE
10798 * xml.c (make_dom): Now static.
10799
8f5201ae
PE
10800 * composite.c (composition_compute_stop_pos): Rename local to
10801 avoid shadowing.
b246f932
PE
10802 (composition_reseat_it): Remove unused locals.
10803 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10804 (composition_update_it): Mark var as initialized.
11b61122
PE
10805 (find_automatic_composition): Mark vars as initialized,
10806 with a FIXME (Bug#8290).
8f5201ae 10807
760fbc2c
PE
10808 character.h: Rename locals to avoid shadowing.
10809 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10810 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10811 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10812 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10813 to avoid shadowing.
10814
ff08eb85
PE
10815 * textprop.c (property_change_between_p): Remove; unused.
10816
fc7bf025
PE
10817 * intervals.c (interval_start_pos): Now static.
10818
235d7abc
PE
10819 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10820
44f230aa
SM
10821 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10822 Rename locals to avoid shadowing.
3e7d6594 10823
50060332
PE
10824 * sound.c (wav_play, au_play, Fplay_sound_internal):
10825 Fix pointer signedness.
d01f234b 10826 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10827 (wav_play): Initialize a variable to 0, to prevent undefined
10828 behavior (Bug#8278).
50060332 10829
c4fc4e30
PE
10830 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10831
918436ed
PE
10832 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10833
c939f91b
PE
10834 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10835 clobbering (Bug#8298).
b9c7f648
PE
10836 * sysdep.c (sys_subshell): Likewise.
10837 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10838
6bd8c144
PE
10839 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10840 This should get cleaned up, so that child_setup has the
10841 same signature on all platforms.
10842
7710357c 10843 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10844 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10845
c59da222
CY
108462011-03-22 Chong Yidong <cyd@stupidchicken.com>
10847
10848 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10849 not to be necessary, and produces flickering.
10850
66b87493
GM
108512011-03-20 Glenn Morris <rgm@gnu.org>
10852
10853 * config.in: Remove file.
10854
45b6f6d5
JB
108552011-03-20 Juanma Barranquero <lekktu@gmail.com>
10856
10857 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10858 are now in src/globals.h.
10859 (syms_of_minibuf): Remove spurious & from previous change.
10860
cd394be1 108612011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10862
10863 * minibuf.c (completing-read-function): New variable.
10864 (completing-read-default): Rename from completing-read.
10865 (completing-read): Call completing-read-function.
10866
b14e3e21
CY
108672011-03-19 Juanma Barranquero <lekktu@gmail.com>
10868
10869 * xfaces.c (Fx_load_color_file):
10870 Read color file from absolute filename (bug#8250).
10871
f2b726e6
JB
108722011-03-19 Juanma Barranquero <lekktu@gmail.com>
10873
10874 * makefile.w32-in: Update dependencies.
10875
09f6ff02
EZ
108762011-03-17 Eli Zaretskii <eliz@gnu.org>
10877
10878 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10879
29a6015a
PE
108802011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10881
a3a6c54e
PE
10882 Fix more problems found by GCC 4.5.2's static checks.
10883
b766f867
PE
10884 * process.c (make_serial_process_unwind, send_process_trap):
10885 (sigchld_handler): Now static.
10886
be02381c
PE
10887 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10888 That way, the code declares only the vars that it needs.
10889 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10890 * s/cygwin.h (PTY_ITERATION): Likewise.
10891 * s/darwin.h (PTY_ITERATION): Likewise.
10892 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10893
57048744
PE
10894 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10895 * process.c (allocate_pty): Don't declare stb unless it's needed.
10896
7914961c 10897 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10898 (CONSTANTLIM): Remove; unused.
10899 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10900 Define only if needed.
7914961c 10901
b3967b18
PE
10902 * unexelf.c (unexec): Name an expression,
10903 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10904 Use a different way to cause a compilation error if anyone uses
10905 n rather than nn, a way that does not involve shadowing.
73366a00 10906 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10907
29a6015a
PE
10908 * deps.mk (unexalpha.o): Remove; unused.
10909
43cfc33e 10910 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10911 * unexec.h: New file.
ce701a33
PE
10912 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10913 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10914 Depend on unexec.h.
10915 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10916 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10917 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10918 Change as necessary to match prototype in unexec.h.
ce701a33 10919
01f44d5a
PE
10920 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10921 shadowing.
4f63c6bb 10922 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10923
a6670b0b
PE
10924 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10925 Rename locals to avoid shadowing.
10926
cef2010d 10927 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10928 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10929
d4d7173a
PE
10930 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10931
f08b802a
PE
10932 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10933 warning when compiling print.c.
10934
3ddb0639
PE
10935 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10936 instead of using an uninitialized var.
5ad03b97 10937 (font_sort_entities): Mark var as initialized.
3ddb0639 10938
170a2692
PE
10939 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10940
e663c700
PE
10941 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10942 pointers to constants.
89bc529a 10943 (font_parse_fcname): Remove unused vars.
7b81e2d0 10944 (font_delete_unmatched): Now static.
ea838e10 10945 (font_get_spec): Remove; unused.
13a547c6
PE
10946 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10947 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10948 Rename or move locals to avoid shadowing.
e663c700 10949
2a80c887 10950 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10951 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10952
1384fa33 10953 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10954 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10955
8b2c52e9
PE
10956 * alloc.c (mark_backtrace): Move decl from here ...
10957 * lisp.h: ... to here, so that it can be checked.
10958
475545b5 10959 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10960 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10961 (lisp_indirect_variable): Name an expression,
10962 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10963 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10964
b1349114 10965 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10966 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10967 Use const pointer when appropriate.
b1349114 10968
a2928364
PE
10969 * lisp.h (get_system_name, get_operating_system_release):
10970 Move decls here, to check interfaces.
10971 * process.c (get_operating_system_release): Move decl to lisp.h.
10972 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10973 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10974 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10975 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10976 (Fformat_time_string, Fencode_time, Finsert_char):
10977 (Ftranslate_region_internal, Fformat):
10978 Rename or remove local vars to avoid shadowing.
9710023e 10979 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10980
a415e694
PE
10981 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10982 avoid shadowing.
10983
8ef4622d
PE
10984 * lisp.h (eassert): Check that the argument compiles, even if
10985 ENABLE_CHECKING is not defined.
10986
946f9a5b
PE
10987 * data.c (Findirect_variable): Name an expression, to avoid
10988 gcc -Wbad-function-cast warning.
112396d6 10989 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10990 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10991 (Fmake_variable_buffer_local, Fmake_local_variable):
10992 Mark variables as initialized.
52746918 10993 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10994
e5aab7e7 10995 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10996 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10997 Rename locals to avoid shadowing.
dff45157
PE
10998 (mark_stack): Move local variables into the #ifdef region where
10999 they're used.
7bc26fdb
PE
11000 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11001 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11002 needed otherwise.
11003 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11004 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11005 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11006
e5aab7e7
PE
11007 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11008 avoids undefined behavior in theory.
11009
4da60324
PE
11010 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11011
88043301
PE
11012 Use functions, not macros, for up- and down-casing (Bug#8254).
11013 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11014 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11015 to use the following functions instead of these macros.
11016 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11017 EMACS_INT, since callers assume the returned value fits in int.
11018 (upcase1): Likewise, for UPCASE_TABLE.
11019 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11020 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11021 the race-condition problem in the old DOWNCASE.
88043301 11022
19ed5445
PE
11023 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11024 Rename locals to avoid shadowing.
11025 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11026 (regex_compile, re_search_2, re_match_2_internal):
11027 Remove unused local vars.
952db0d7
PE
11028 (FREE_VAR): Rewrite so as not to use empty "else",
11029 which gcc can warn about.
da053e48 11030 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11031 (RETALLOC_IF): Define only if needed.
11032 (WORDCHAR_P): Likewise. This one is never needed, but is used
11033 only in a comment talking about a compiler bug, so put inside
11034 the #if 0 of that comment.
11035 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11036 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11037 Remove; unused.
19ed5445 11038
1f3561e4 11039 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11040 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11041 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11042
ded6f8f7
PE
11043 * search.c (simple_search): Remove unused var.
11044
dbd37a95
PE
11045 * dired.c (compile_pattern): Move decl from here ...
11046 * lisp.h: ... to here, so that it can be checked.
11047 (struct re_registers): New forward decl.
11048
7e47afad
PE
11049 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11050
85f24f61
PE
11051 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11052 All uses changed.
11053 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11054 Rename locals to avoid shadowing.
5671df8f 11055 (Fvertical_motion): Mark locals as initialized.
85f24f61 11056
181aa2be 11057 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11058 (casify_region): Mark local as initialized.
181aa2be 11059
930d429c
PE
11060 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11061
7082eac6
PE
11062 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11063 New macros, so that the caller can use some names other than
11064 gcpro1, gcpro2, etc.
11065 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11066 of the new macros.
11067 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11068 argument, for consistency with GCPRO2_VAR, etc: it is now the
11069 prefix of the variable, not the variable itself. All uses
11070 changed.
38b2c076
PE
11071 * dired.c (directory_files_internal, file_name_completion):
11072 Rename locals to avoid shadowing.
11073
15206ed9
PE
11074 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11075 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11076 dired.c's scmp function, had undefined behavior.
11077 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11078 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11079 * buffer.h: ... to here, because these macros use current_buffer,
11080 and the new implementation with inline functions needs to have
11081 current_buffer in scope now, rather than later when the macros
11082 are used.
11083 (downcase, upcase1): New static inline functions.
11084 (DOWNCASE, UPCASE1): Reimplement using these functions.
11085 This avoids undefined behavior in expressions like
11086 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11087 from race conditions in accessing the global variables
11088 case_temp1 and case_temp2.
11089 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11090 * lisp.h (case_temp1, case_temp2): Remove their decls.
11091 * character.h (ASCII_CHAR_P): Move from here ...
11092 * lisp.h: ... to here, so that the inline functions mentioned
11093 above can use them.
11094
4a6bea26
PE
11095 * dired.c (directory_files_internal_unwind): Now static.
11096
f14b7e14
PE
11097 * fileio.c (file_name_as_directory, directory_file_name):
11098 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11099 Now static.
2893f146
PE
11100 (file_name_as_directory): Use const pointers when appropriate.
11101 (Fexpand_file_name): Likewise. In particular, newdir might
11102 point at constant storage, so make it a const pointer.
fd4ead52 11103 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11104 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11105 signedness issues.
f839df0c
PE
11106 (Fset_file_times, Finsert_file_contents, auto_save_error):
11107 Rename locals to avoid shadowing.
f14b7e14 11108
5716756e 11109 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11110 (Ftry_completion, Fall_completions): Rename or remove locals
11111 to avoid shadowing.
5716756e 11112
b4c3046a
PE
11113 * marker.c (bytepos_to_charpos): Remove; unused.
11114
b45db522
PE
11115 * lisp.h (verify_bytepos, count_markers): New decls,
11116 so that gcc does not warn that these functions aren't declared.
11117
85876d07
PE
11118 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11119 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11120 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11121 (copy_text): Remove unused local var.
85876d07 11122
03d78a21 11123 * filelock.c (within_one_second): Now static.
b3dd38ab 11124 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11125
5df8f01b
PE
11126 * buffer.c (fix_overlays_before): Mark locals as initialized.
11127 (fix_start_end_in_overlays): Likewise. This function should be
11128 simplified by using pointers-to-pointers, but that's a different
11129 matter.
b1d876f1 11130 (switch_to_buffer_1): Now static.
8f54f30a
PE
11131 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11132 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11133
a70072c9 11134 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11135 Fix pointer signedness issue.
edced198
PE
11136 (sys_subshell): Mark local as volatile if checking for lint,
11137 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11138 (MAXPATHLEN): Define only if needed.
a70072c9 11139
a0977c44
PE
11140 * process.c (serial_open, serial_configure): Move decls from here ...
11141 * systty.h: ... to here, so that they can be checked.
11142
a884fdcc
PE
11143 * fns.c (get_random, seed_random): Move extern decls from here ...
11144 * lisp.h: ... to here, so that they can be checked.
11145
604efe86 11146 * sysdep.c (reset_io): Now static.
b8950c94 11147 (wait_for_termination_signal): Remove; unused.
604efe86 11148
38fc62d9
PE
11149 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11150 (copy_keymap_item, append_key, push_text_char_description):
11151 Now static.
1004a21a 11152 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11153 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11154 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11155 (describe_map_tree):
11156 Rename locals to avoid shadowing.
38fc62d9 11157
2f2650da
PE
11158 * keyboard.c: Declare functions static if they are not used elsewhere.
11159 (echo_char, echo_dash, cmd_error, top_level_2):
11160 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11161 (read_char, kbd_buffer_get_event, make_lispy_position):
11162 (make_lispy_event, make_lispy_movement, apply_modifiers):
11163 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11164 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11165 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11166 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11167 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11168
a053e86c 11169 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11170 (mark_kboards): Move decl here ...
11171 * alloc.c (mark_kboards): ... from here.
a053e86c 11172
4752793e
PE
11173 * lisp.h (force_auto_save_soon): New decl.
11174
74f10ca7 11175 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11176 (DEFINE_DUMMY_FUNCTION): New macro.
11177 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11178 Use it.
c03cd23f
PE
11179 (main): Add casts to avoid warnings
11180 if GCC considers string literals to be constants.
74f10ca7 11181
022e70d4
PE
11182 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11183
59d6fe83
PE
11184 * dbusbind.c: Pointer signedness fixes.
11185 (xd_signature, xd_append_arg, xd_initialize):
11186 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11187 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11188 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11189 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11190
78320123
PE
11191 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11192 if GCC considers string literals to be constants.
49cebcca 11193 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11194
35ac2a97
SM
111952011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11196
fb103ca9
SM
11197 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11198 (print_preprocess, print_object): New macro to fix last change.
11199
35ac2a97
SM
11200 * print.c (print_preprocess): Don't forget font objects.
11201
62973b41
JB
112022011-03-16 Juanma Barranquero <lekktu@gmail.com>
11203
11204 * emacs.c (USAGE3): Doc fixes.
11205
0e48bb22
AS
112062011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11207
11208 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11209 structure.
11210
7684e57b
JB
112112011-03-14 Juanma Barranquero <lekktu@gmail.com>
11212
11213 * lisp.h (VWindow_system, Qfile_name_history):
11214 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11215 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11216 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11217
11218 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11219 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11220
11221 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11222 * w32console.c (detect_input_pending, read_input_pending)
11223 (encode_terminal_code):
11224 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11225 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11226 (w32_system_caret_y, Qfile_name_history):
11227 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11228 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11229 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11230 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11231 * w32proc.c (Qlocal, report_file_error):
11232 * w32term.c (Vwindow_system, updating_frame):
11233 * w32uniscribe.c (initialized, uniscribe_font_driver):
11234 Remove unneeded extern declarations.
11235
2aa46d6c
CY
112362011-03-14 Chong Yidong <cyd@stupidchicken.com>
11237
c96bbc66 11238 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11239
cffc6f3b
CY
112402011-03-13 Chong Yidong <cyd@stupidchicken.com>
11241
11242 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11243 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11244 These macros can no longer be used for assignment.
11245
44f230aa
SM
11246 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11247 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11248 (record_buffer_markers, fetch_buffer_markers): New functions for
11249 recording and fetching special buffer markers.
11250 (set_buffer_internal_1, set_buffer_temp): Use them.
11251
11252 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11253
11254 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11255
11256 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11257 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11258
11259 * xdisp.c (hscroll_window_tree):
11260 (reconsider_clip_changes): Use PT instead of BUF_PT.
11261
d251f04b
EZ
112622011-03-13 Eli Zaretskii <eliz@gnu.org>
11263
11264 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11265 $(EMACS_ROOT)/lib/intprops.h.
11266
f0c77cd1
PE
112672011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11268
3eca4629
PE
11269 Fix more problems found by GCC 4.5.2's static checks.
11270
7c86ee98
PE
11271 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11272 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11273 (xg_free_frame_widgets): Make it clear that a local variable is
11274 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11275 (gdk_window_get_screen): Make it clear that this macro is needed
11276 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11277 (int_gtk_range_get_value): New function, which avoids a diagnostic
11278 from gcc -Wbad-function-cast.
11279 (xg_set_toolkit_scroll_bar_thumb): Use it.
11280 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11281 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11282 (get_utf8_string, xg_get_file_with_chooser):
11283 Rename locals to avoid shadowing.
11284 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11285
41729b81
PE
11286 * xgselect.c (xg_select): Remove unused var.
11287
f0c77cd1
PE
11288 * image.c (four_corners_best): Mark locals as initialized.
11289 (gif_load): Initialize transparent_p to zero (Bug#8238).
11290 Mark another local as initialized.
ec6cf4c6 11291 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11292
ce0ad53d 11293 * image.c (clear_image_cache): Now static.
d5d5a617 11294 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11295 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11296 (x_edge_detection): Remove unnecessary cast that
11297 gcc -Wbad-function-cast diagnoses.
2037898d 11298 (gif_load): Fix pointer signedness.
6ae141d6
PE
11299 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11300 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11301
33383987 113022011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11303
d32df629
PE
11304 Improve quality of tests for time stamp overflow.
11305 For example, without this patch (encode-time 0 0 0 1 1
11306 1152921504606846976) returns the obviously-bogus value (-948597
11307 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11308 reports time overflow. See
11309 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11310 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11311 * editfns.c: Include limits.h and intprops.h.
11312 (TIME_T_MIN, TIME_T_MAX): New macros.
11313 (time_overflow): Move earlier, to before first use.
11314 (hi_time, lo_time): New functions, for an accurate test for
11315 out-of-range times.
11316 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11317 (Fget_internal_run_time): Don't assume time_t fits in int.
11318 (make_time): Use list2 instead of Fcons twice.
11319 (Fdecode_time): More accurate test for out-of-range times.
11320 (check_tm_member): New function.
11321 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11322 (lisp_time_argument): Don't rely on undefined left-shift and
11323 right-shift behavior when checking for time stamp overflow.
8be6f318 11324
fe31d94c
PE
11325 * editfns.c (time_overflow): New function, refactoring common code.
11326 (Fformat_time_string, Fdecode_time, Fencode_time):
11327 (Fcurrent_time_string): Use it.
11328
8be6f318
PE
11329 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11330 * dired.c (make_time): Move to ...
11331 * editfns.c (make_time): ... here.
11332 * systime.h: Note the move.
11333
09d9db2c 113342011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11335
126bc0dc
YM
11336 * fringe.c (update_window_fringes): Remove unused variables.
11337
c47cbdfd
YM
11338 * unexmacosx.c (copy_data_segment): Also copy __got section.
11339 (Bug#8223)
11340
7ac80be9
EZ
113412011-03-12 Eli Zaretskii <eliz@gnu.org>
11342
c96bbc66 11343 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11344 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11345 Constify `char *' arguments and their references according to
11346 prototypes in tparam.h.
11347
ecb0f94d 11348 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11349
7ac80be9
EZ
11350 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11351 Adapt all references accordingly.
11352
11353 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11354
ef1fd07e
TT
113552011-03-11 Tom Tromey <tromey@redhat.com>
11356
11357 * buffer.c (syms_of_buffer): Remove obsolete comment.
11358
7ef4b50c
EZ
113592011-03-11 Eli Zaretskii <eliz@gnu.org>
11360
11361 * termhooks.h (encode_terminal_code): Declare prototype.
11362
11363 * msdos.c (encode_terminal_code): Don't declare prototype.
11364
11365 * term.c (encode_terminal_code): Now external again, used by
11366 w32console.c and msdos.c.
11367
44f230aa
SM
11368 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11369 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11370
4b1ec863 113712011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11372
1714f52b 11373 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11374
4b1ec863
PE
11375 * fringe.c (update_window_fringes): Mark locals as initialized
11376 (Bug#8227).
11377 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11378
524c7aa6
PE
11379 * alloc.c (mark_fringe_data): Move decl from here ...
11380 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11381 to check its interface.
11382 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11383
a5c0af81 11384 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11385 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11386 (fontset_font): Mark local as initialized.
a9a06e0b 11387 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11388
b4716021
PE
11389 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11390
811e9bac 11391 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11392 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11393 (x_own_selection, Fx_disown_selection_internal): Rename locals
11394 to avoid shadowing.
11395 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11396
7e3ab302
PE
11397 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11398 so that the caller can use some name other than gcpro1.
11399 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11400 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11401 (Fx_backspace_delete_keys_p):
11402 Use them to avoid shadowing, and rename vars to avoid shadowing.
11403 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11404 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11405 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11406 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11407 Remove unused locals.
7e3ab302
PE
11408 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11409 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11410 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11411 macros.
f78faa98 11412
e2b13473
PE
11413 * xterm.h (x_mouse_leave): New decl.
11414
77f23912
PE
11415 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11416 Remove unused functions.
cdf4ba58
PE
11417 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11418 (x_calc_absolute_position): Now static.
7411c686 11419 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11420 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11421 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11422 unless they are used.
38d0b34a
PE
11423 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11424 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11425 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11426 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11427 (x_error_catcher, x_connection_closed, x_error_handler):
11428 (x_error_quitter, xembed_send_message, x_iconify_frame):
11429 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11430 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11431 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11432
44f230aa
SM
11433 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11434 Rename or move locals to avoid shadowing.
6b463e58 11435 (tty_defined_color, merge_face_heights): Now static.
5967d051 11436 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11437 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11438 does not deduce is never used uninitialized.
73719eba
PE
11439 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11440 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11441
426994c3 11442 * terminal.c (store_terminal_param): Now static.
5489860b 11443
032f1620 11444 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11445 (set_frame_menubar): Remove unused local.
d4323972 11446 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11447 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11448 since they might point to immutable storage.
281585b0
PE
11449 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11450 since it's unused otherwise.
032f1620 11451
367c19e5 11452 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11453 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11454 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11455 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11456 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11457 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11458 does not deduce are never used uninitialized.
70739cbe 11459
07b48fa9
PE
11460 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11461
8868a238 11462 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11463 * window.c (window_loop, size_window):
11464 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11465
7e5cf297 11466 * window.c (display_buffer): Now static.
d6550a9f
PE
11467 (size_window): Mark variables that gcc -Wuninitialized
11468 does not deduce are never used uninitialized.
a586633d
PE
11469 * window.h (check_all_windows): New decl, to forestall
11470 gcc -Wmissing-prototypes diagnostic.
5b555da1 11471 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11472
f6095868
PE
11473 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11474 shadowing.
11475 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11476 Include <limits.h>.
11477 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11478 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11479 (load_charset_map): Mark variables that gcc -Wuninitialized
11480 does not deduce are never used uninitialized.
53df7c11 11481 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11482
f38b440c
PE
11483 * coding.c (coding_set_source, coding_set_destination):
11484 Use "else { /* comment */ }" rather than "else /* comment */;"
11485 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11486 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11487 a block, when the outer 'i' will do.
11488 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11489 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11490 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11491 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11492 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11493 Rename locals to avoid shadowing.
11494 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11495 * coding.c (emacs_mule_char, encode_invocation_designation):
11496 Now static, since they're not used elsewhere.
413bb2db 11497 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11498 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11499 (decode_coding_emacs_mule): Mark variables that gcc
11500 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11501 (detect_coding_iso_2022): Initialize a local variable that might
11502 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11503 this initialization is needed. (Bug#8211)
5f58e762
PE
11504 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11505 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11506 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11507 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11508 Remove unused macros.
f38b440c 11509
232b38b9 11510 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11511 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11512 * character.c (string_count_byte8): Likewise.
232b38b9 11513
fb90da1b
PE
11514 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11515 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11516
fb93dbc2
PE
11517 * chartab.c (copy_sub_char_table): Now static, since it's not used
11518 elsewhere.
5c156ace
PE
11519 (sub_char_table_ref_and_range, char_table_ref_and_range):
11520 Rename locals to avoid shadowing.
bbcd0949 11521 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11522
7d3b3862 11523 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11524 (BIDI_BOB): Remove unused macro.
7d3b3862 11525
6be7d3da
PE
11526 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11527 deduce are never used uninitialized.
c2ed9c8b 11528 * term.c (encode_terminal_code): Likewise.
6be7d3da 11529
75f8807f 11530 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11531
50938595
PE
11532 * tparam.h: New file.
11533 * term.c, tparam.h: Include it.
11534 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11535 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11536 Move these decls to tparam.h, and make them agree with what
11537 is actually in tparam.c. The previous trick of using incompatible
11538 decls in different modules does not conform to the C standard.
11539 All callers of tparam changed to use tparam's actual API.
11540 * tparam.c (tparam1, tparam, tgoto):
11541 Use const pointers where appropriate.
11542
fbceeba2
PE
11543 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11544 * cm.h (struct cm): Likewise.
11545 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11546 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11547 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11548 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11549 (turn_on_face, init_tty): Likewise.
11550 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11551
7f3f1250
PE
11552 * term.c (term_mouse_position): Rename local to avoid shadowing.
11553
e6ca6543
PE
11554 * alloc.c (mark_ttys): Move decl from here ...
11555 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11556
c40f8d15
AS
115572011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11558
11559 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11560
cfe0661d
JB
115612011-03-09 Juanma Barranquero <lekktu@gmail.com>
11562
11563 * search.c (compile_pattern_1): Remove argument regp, unused since
11564 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11565 (compile_pattern): Don't pass it.
11566
0afb4571
J
115672011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11568
11569 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11570 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11571 for ! HAVE_GTK3.
11572 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11573
11574 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11575
11576 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11577 gdk_window_get_screen, gdk_window_get_geometry,
11578 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11579 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11580 (xg_get_pixbuf_from_pixmap): New function.
11581 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11582 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11583 Call xg_get_pixbuf_from_pixmap instead of
11584 gdk_pixbuf_get_from_drawable.
11585 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11586 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11587 (xg_check_special_colors): Use GtkStyleContext and its functions
11588 for HAVE_GTK3.
11589 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11590 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11591 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11592 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11593 Call gtk_widget_get_preferred_size.
0afb4571
J
11594 (xg_frame_resized): gdk_window_get_geometry only takes 5
11595 parameters.
44f230aa
SM
11596 (xg_win_to_widget, xg_event_is_for_menubar):
11597 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11598 (xg_set_widget_bg): New function.
11599 (delete_cb): New function.
895009e1 11600 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11601 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11602 (xg_set_background_color): Call xg_set_widget_bg.
11603 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11604 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11605 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11606 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11607 if ! HAVE_GTK3.
11608 (update_frame_tool_bar): Call gtk_widget_hide.
11609 (xg_initialize): Use GDK_KEY_g.
11610
11611 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11612 if ! HAVE_GTK3
11613 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11614
11615 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11616 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11617 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11618
1c2cc4ef
JB
116192011-03-08 Juanma Barranquero <lekktu@gmail.com>
11620
11621 * w32xfns.c (select_palette): Check success of RealizePalette against
11622 GDI_ERROR, not zero.
11623
33383987 11624See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11625
11626;; Local Variables:
11627;; coding: utf-8
aac0c6e3
MR
11628;; End:
11629
2f097256 11630 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11631
11632 This file is part of GNU Emacs.
11633
11634 GNU Emacs is free software: you can redistribute it and/or modify
11635 it under the terms of the GNU General Public License as published by
11636 the Free Software Foundation, either version 3 of the License, or
11637 (at your option) any later version.
11638
11639 GNU Emacs is distributed in the hope that it will be useful,
11640 but WITHOUT ANY WARRANTY; without even the implied warranty of
11641 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11642 GNU General Public License for more details.
11643
11644 You should have received a copy of the GNU General Public License
11645 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.