merge trunk
[bpt/emacs.git] / src / ChangeLog
CommitLineData
159462d4 12012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2
3 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4 NULL (Bug#6988).
5 (x_produce_glyphs): If the component of a composition is a null
6 string, set it->pixel_width to 1 to avoid zero-width glyph.
7
78cef877
EZ
82012-02-01 Eli Zaretskii <eliz@gnu.org>
9
10 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
11 first 2 arguments are identical. This makes inserting large
12 output from a subprocess an order of magnitude faster on
13 MS-Windows, where all sbrk'ed memory is always contiguous.
14
97897668
GM
152012-01-31 Glenn Morris <rgm@gnu.org>
16
17 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 18 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
19 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
20
31fd3586
GM
212012-01-29 Glenn Morris <rgm@gnu.org>
22
23 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
24
0e24a8b2
CY
252012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
26
27 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
28
cc0adcb0
CY
292012-01-28 Chong Yidong <cyd@gnu.org>
30
31 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
32
acc28cb9
CY
332012-01-26 Chong Yidong <cyd@gnu.org>
34
9c69cfb7
CY
35 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
36
acc28cb9
CY
37 * search.c (Fsearch_forward, Fsearch_backward): Document negative
38 repeat counts (Bug#10507).
39
48da7392
GM
402012-01-26 Glenn Morris <rgm@gnu.org>
41
42 * lread.c (syms_of_lread): Doc fix.
43
14af5f7f
CY
442012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
45
46 * coding.c (encode_designation_at_bol): Change return value to
47 EMACS_INT.
48
0b21c100
CY
492012-01-25 Chong Yidong <cyd@gnu.org>
50
51 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
52
3c2907f7
CY
532012-01-21 Chong Yidong <cyd@gnu.org>
54
55 * floatfns.c (Fcopysign): Make the second argument non-optional,
56 since nil is not allowed anyway.
57
959ad23f
AS
582012-01-21 Andreas Schwab <schwab@linux-m68k.org>
59
60 * process.c (read_process_output): Use p instead of XPROCESS (proc).
61 (send_process): Likewise.
62
34a02f46
MR
632012-01-19 Martin Rudalics <rudalics@gmx.at>
64
65 * window.c (save_window_save, Fcurrent_window_configuration)
66 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
67 doc-strings.
68
1259009a 692012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
70
71 * character.c (char_width): New function.
70d4fdf6
GM
72 (Fchar_width, c_string_width, lisp_string_width):
73 Use char_width (Bug#9496).
25ed9e61 74
6a6ee00d
MR
752012-01-16 Martin Rudalics <rudalics@gmx.at>
76
77 * window.c (Vwindow_persistent_parameters): New variable.
78 (Fset_window_configuration, save_window_save): Handle persistent
79 window parameters.
80
c85efaf7
EZ
812012-01-14 Eli Zaretskii <eliz@gnu.org>
82
83 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
84 thrashing the stack of the thread. (Bug#9087)
85
5944709e
PE
862012-01-12 Paul Eggert <eggert@cs.ucla.edu>
87
88 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
89
e71f5d99
EZ
902012-01-11 Eli Zaretskii <eliz@gnu.org>
91
92 * xdisp.c (rows_from_pos_range): Handle the case where the
93 highlight ends on a newline. (Bug#10464)
94 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
95 he end column for display of highlight that ends on a newline
96 before a R2L line.
97
ce316182
GM
982012-01-11 Glenn Morris <rgm@gnu.org>
99
100 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
101 from load-path also when installation-directory is nil. (Bug#10208)
102
5b43da69
GM
1032012-01-10 Glenn Morris <rgm@gnu.org>
104
74cc8ff9
GM
105 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
106
7d8d6e4e
GM
107 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
108 Update template values to be closer to their typical values these days.
5b43da69 109
a0db8d43
EZ
1102012-01-09 Eli Zaretskii <eliz@gnu.org>
111
112 * xdisp.c (rows_from_pos_range): Accept additional argument
113 DISP_STRING, and accept any glyph in a row whose object is that
114 string as eligible for mouse highlight. Fixes mouse highlight of
115 display strings from overlays. (Bug#10464)
116
9a0115ab 1172012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 118
b9110d6a 119 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
120 * fileio.c (auto_saving_dir_umask): New static var.
121 (Fmake_directory_internal): Use it.
122 (do_auto_save_make_dir): Set it, instead of invoking chmod after
123 creating the directory. The old code temporarily assigns
124 too-generous permissions to the directory.
125 (do_auto_save_eh): Clear it.
b9110d6a 126 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
127 that the var is always cleared.
128
6c1bd3f3
EZ
1292012-01-07 Eli Zaretskii <eliz@gnu.org>
130
131 * search.c (scan_buffer): Pass character positions to
132 know_region_cache, not byte positions. (Bug#6540)
133
069d2b50
L
1342012-01-07 LynX <_LynX@bk.ru> (tiny change)
135
136 * w32.c (sys_rename): Report EXDEV when rename of a directory
137 fails because the target is on another logical disk. (Bug#10284)
138
75bf0d33
DB
1392012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
140
141 * xterm.c (x_embed_request_focus): New function.
142
143 * xterm.h: Add prototype.
144
145 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
146
1c6e5a32
GM
1472012-01-05 Glenn Morris <rgm@gnu.org>
148
149 * emacs.c (emacs_copyright): Update short copyright year to 2012.
150
651e947e
EZ
1512012-01-01 Eli Zaretskii <eliz@gnu.org>
152
153 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
154 Load gnutls_transport_set_lowat only if GnuTLS version is below
155 2.11.1.
156 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
157 GnuTLS versions below 2.11.1.
158
3778cdd8
AL
1592011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
160
161 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
162 to the doc string advising against its use for altering the way
163 windows are scrolled.
164
0e5317f7
KH
1652011-12-28 Kenichi Handa <handa@m17n.org>
166
167 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
168 coding-system ASCII compatible only when it does not produce BOM
169 on encoding (Bug#10383).
170
93d5ca1f
JD
1712011-12-26 Jan Djärv <jan.h.d@swipnet.se>
172
173 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
174 can scroll.
175 (create_and_show_popup_menu): Always use menu_position_func for
176 Gtk3 (Bug#10361).
177
ca22b785
AS
1782011-12-24 Andreas Schwab <schwab@linux-m68k.org>
179
180 * callint.c (Fcall_interactively): Don't truncate prompt string.
181
d048e1e6
EZ
1822011-12-23 Eli Zaretskii <eliz@gnu.org>
183
184 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
185 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 186 resumed from there (after widening). (Bug#10360)
d048e1e6 187
5ccaba1f
JD
1882011-12-22 Jan Djärv <jan.h.d@swipnet.se>
189
190 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
191
204ee57f
JD
1922011-12-21 Jan Djärv <jan.h.d@swipnet.se>
193
b81d40f0
JB
194 * nsterm.m (x_free_frame_resources):
195 Release f->output_data.ns->miniimage.
204ee57f
JD
196 (ns_index_color): Fix indentation. Do not retain
197 color_table->colors[i].
198
199 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
200 before returning.
201
202 * nsfns.m (x_set_background_color): Assign return value from
203 ns_index_color to face-background instead of NSColor*.
204 (ns_implicitly_set_icon_type): Fix indentation.
205 Change assignment in for loop to comparison.
206
207 * emacs.c (ns_pool): New variable.
208 (main): Assign ns_pool.
209 (Fkill_emacs): Call ns_release_autorelease_pool.
210
211 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
212 autorelease fdesc, release fdAttrs and tdict.
213 (ns_get_covering_families): Release charset.
214 (ns_findfonts): Release NSFontDescriptor created with new.
215 (ns_uni_to_glyphs): Fix indentation.
216 (setString): Release attrStr before assigning new value.
217
c803b2b7
JD
2182011-12-18 Jan Djärv <jan.h.d@swipnet.se>
219
678f4426
JD
220 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
221 and NS_IMPL_COCOA.
222 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
223 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
224
cd394be1 2252011-12-18 David Reitter <reitter@cmu.edu>
678f4426 226
5fecd5fc
JD
227 * nsterm.m (ns_term_init): Subscribe for notifications
228 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
229 to method trackingNotification in EmacsMenu.
230
231 * nsmenu.m (trackingMenu): New variable.
3771cb17 232 (trackingNotification): New method (from Aquamacs).
5fecd5fc 233 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 234 from Aquamacs (Bug#7030).
678f4426
JD
235
2362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 237
c803b2b7
JD
238 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
239 (symbol_to_nsstring): Fix indentation.
240 (ns_symbol_to_pb): New function.
241 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
242 (Fns_rotate_cut_buffers_internal): Removed.
243 (Fns_store_selection_internal): Renamed from
244 Fns_store_cut_buffer_internal.
245 (ns_get_foreign_selection, Fx_own_selection_internal)
246 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
247 (Fns_get_selection_internal, Fns_store_selection_internal):
248 Use ns_symbol_to_pb and check if return value is nil.
249 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
250 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
251 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
252 renamed to Sns_store_selection_internal.
253 (ns_handle_selection_request): Move code to Fx_own_selection_internal
254 and remove this function.
255 (ns_handle_selection_clear): Remove, never used.
256 (Fx_own_selection_internal): Move code from ns_handle_selection_request
257 here.
258
e1b01a3a
KB
2592011-12-17 Ken Brown <kbrown@cornell.edu>
260
261 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
262 GID is unknown (Bug#10257).
263
2adb6e85
PE
2642011-12-17 Paul Eggert <eggert@cs.ucla.edu>
265
266 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
267 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
268 which caused a build failure on GNU/Linux IA-64. This problem was
269 introduced by my 2011-10-07 patch.
270
d1d7b339
JL
2712011-12-15 Juri Linkov <juri@jurta.org>
272
273 * image.c (imagemagick_error): New function. (Bug#10112)
274 (imagemagick_load_image): Comment out `MagickSetResolution' call.
275 Use `imagemagick_error' where ImageMagick functions return
276 `MagickFalse'.
277 (Fimagemagick_types): Add `Fnreverse' to return the list in the
278 proper order.
279
100d5755
KH
2802011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
281
282 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
283 fill background (Bug#8992).
284
454592a6
MR
2852011-12-13 Martin Rudalics <rudalics@gmx.at>
286
287 * window.c (Vwindow_combination_resize)
288 (Vwindow_combination_limit): Use t instead of non-nil in
289 doc-strings.
61d4b438
MR
290 (Vrecenter_redisplay): Add first sentence of doc-string on
291 separate line.
53524d93 292 (Frecenter): Fix doc-string typo.
454592a6 293
3633e3aa
KH
2942011-12-11 Kenichi Handa <handa@m17n.org>
295
296 * coding.c (Funencodable_char_position): Pay attention to the
297 buffer text relocation (Bug#9389).
298
7b9d523a
JD
2992011-12-10 Jan Djärv <jan.h.d@swipnet.se>
300
301 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
302 gtk_init (Bug#10100).
303
b73189c6
EZ
3042011-12-10 Eli Zaretskii <eliz@gnu.org>
305
306 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
307 IT->string is nil. (Bug#10263)
308
f7dfe5d6
JD
3092011-12-10 Jan Djärv <jan.h.d@swipnet.se>
310
83faebb4
JD
311 * nsterm.h (x_free_frame_resources): Declare.
312
f7dfe5d6
JD
313 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
314 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
315
316 * nsterm.h (ns_get_defaults_value): Declare.
317
318 * nsterm.m (ns_default): Call ns_get_defaults_value.
319
7cd4e72c
EZ
3202011-12-09 Eli Zaretskii <eliz@gnu.org>
321
322 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
323 (Bug#10170)
324
b34d7317
YM
3252011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
326
327 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
328 that where the value of an _OBJC_* symbol points to is in the .bss
329 section (Bug#10240).
330
76470ad1
KH
3312011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
332
333 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 334 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 335
745fff94
KH
3362011-12-08 Kenichi Handa <handa@m17n.org>
337
338 * ftfont.c (get_adstyle_property): Fix previous change
339 (Bug#10233).
340
6e44397c
JB
3412011-12-07 Juanma Barranquero <lekktu@gmail.com>
342
343 * w32.c (init_environment): If no_site_lisp, remove site-lisp
344 dirs from the default value of EMACSLOADPATH (bug#10208).
345
7efa6272
GM
3462011-12-07 Glenn Morris <rgm@gnu.org>
347
348 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
349 installation and source directories as well. (Bug#10208)
350
f6fc4d87
CY
3512011-12-06 Chong Yidong <cyd@gnu.org>
352
353 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
354
2bf26180
GM
3552011-12-06 Glenn Morris <rgm@gnu.org>
356
357 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
358 as an error, not just -1. (Bug#10217)
359
3a6ad4f0
CY
3602011-12-05 Chong Yidong <cyd@gnu.org>
361
362 * keyboard.c (process_special_events): New function.
363 (swallow_events, Finput_pending_p): Use it (Bug#10195).
364
75a3b399
PE
3652011-12-05 Paul Eggert <eggert@cs.ucla.edu>
366
367 * coding.c (encode_designation_at_bol): Don't use uninitialized
368 local variable (Bug#9318).
369
c3c9e25e
KH
3702011-12-05 Kenichi Handa <handa@m17n.org>
371
372 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
373 return Qnil (Bug#8046, Bug#10193).
374
5eb05ea3
KH
3752011-12-05 Kenichi Handa <handa@m17n.org>
376
377 * coding.c (encode_designation_at_bol): New args charbuf_end and
378 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
379 (coding_set_source): Return how many bytes coding->source was
380 relocated.
381 (coding_set_destination): Return how many bytes
382 coding->destination was relocated.
383 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
384 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
385
3862011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
387
388 * coding.c (CODING_CHAR_CHARSET_P): New macro.
389 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
390 macro (Bug#9318).
391
3922011-12-05 Andreas Schwab <schwab@linux-m68k.org>
393
394 The following changes are to fix Bug#9318.
395
a79703f5 396 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
397 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
398 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 399 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 400
7dbda6df
JB
4012011-12-05 Juanma Barranquero <lekktu@gmail.com>
402
403 * lisp.h (process_quit_flag): Fix external declaration.
404
6d5eb5b0
SM
4052011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
406
407 Don't macro-inline non-performance-critical code.
408 * eval.c (process_quit_flag): New function.
409 * lisp.h (QUIT): Use it.
410
a0c3fad0
JD
4112011-12-04 Jan Djärv <jan.h.d@swipnet.se>
412
413 * nsfns.m (get_geometry_from_preferences): New function.
414 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
415
6c07aac2
AS
4162011-12-04 Andreas Schwab <schwab@linux-m68k.org>
417
418 * emacs.c (Qkill_emacs): Define.
419 (syms_of_emacs): Initialize it.
420 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
421 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
422 (quit_throw_to_read_char): Add parameter `from_signal'.
423 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
424 * lisp.h (QUIT): Call Fkill_emacs if requested.
425
c052ead4
JD
4262011-12-03 Jan Djärv <jan.h.d@swipnet.se>
427
428 * widget.c (update_wm_hints): Return if wmshell is null.
429 (widget_update_wm_size_hints): New function.
430
431 * widget.h (widget_update_wm_size_hints): Declare.
432
433 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
434 widget_update_wm_size_hints (Bug#10104).
435
9e49252b
EZ
4362011-12-03 Eli Zaretskii <eliz@gnu.org>
437
438 * xdisp.c (handle_invisible_prop): If the invisible text ends just
439 before a newline, prepare the bidi iterator for consuming the
440 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 441 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 442
02b16839
JL
4432011-12-02 Juri Linkov <juri@jurta.org>
444
445 * search.c (Fword_search_regexp): New Lisp function created from
446 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
447 (Fword_search_backward, Fword_search_forward)
448 (Fword_search_backward_lax, Fword_search_forward_lax):
449 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
450 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
451
0068070e
SM
4522011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
453
454 * fileio.c (Finsert_file_contents): Move after-change-function call
455 to before the "handled:" label, since all "goto handled" appear in
456 cases where the *-change-functions have already been properly called
457 (bug#10117).
458
3360a3fc
AS
4592011-12-01 Andreas Schwab <schwab@linux-m68k.org>
460
461 * keyboard.c (interrupt_signal): Don't call kill-emacs when
462 waiting for input. (Bug#10169)
463
73d6c093
EZ
4642011-11-30 Eli Zaretskii <eliz@gnu.org>
465
466 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
467 verifies glyph row's hash code--we have just reallocated the
468 glyphs, so their contents can be complete garbage. (Bug#10164)
469
febe6bea
JB
4702011-11-30 Juanma Barranquero <lekktu@gmail.com>
471
472 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
473
801a4313
EZ
4742011-11-30 Eli Zaretskii <eliz@gnu.org>
475
476 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
477 attributes are tested _before_ calling verify_row_hash, to protect
478 against GCC re-ordering of the tests. (Bug#10164)
479
2b56b87e
JD
4802011-11-29 Jan Djärv <jan.h.d@swipnet.se>
481
482 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
483
484 * xterm.c (handle_one_xevent): Only set async_visible and friends
485 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 486 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
487 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
488
dbf31225
PE
4892011-11-28 Paul Eggert <eggert@cs.ucla.edu>
490
491 Remove GCPRO-related macros that exist only to avoid shadowing locals.
492 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
493 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
494 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
495 All uses changed to use GCPRO1 etc.
496 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
497 Revert to old implementation (i.e., before 2011-03-11).
498
1305621b
YM
4992011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
500
501 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
502 of scroll runs so as to avoid assigning disabled bogus rows and
503 unnecessary graphics copy operations.
504
8c9afb46
EZ
5052011-11-27 Eli Zaretskii <eliz@gnu.org>
506
507 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
508 (snprintf) [_MSC_VER]: Redirect to _snprintf.
509 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
510 (malloc, free, realloc, calloc): Redirect to e_* only when
511 compiling Emacs.
512
513 * lisp.h (GCTYPEBITS): Move before first use.
514 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
515 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
516 this macro definition.
517
518 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
519 _MSC_VER.
520
54e9e3bf
JD
5212011-11-27 Jan Djärv <jan.h.d@swipnet.se>
522
6d5eb5b0
SM
523 * gtkutil.c (xg_create_frame_widgets):
524 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
525 present with Gtk+ 2.0.
526
83aca1cb
PE
5272011-11-26 Paul Eggert <eggert@cs.ucla.edu>
528
529 * fileio.c (Finsert_file_contents): Undo previous change; see
530 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
531
5b76caa4
PE
5322011-11-26 Paul Eggert <eggert@cs.ucla.edu>
533
534 Rename locals to avoid shadowing.
535 * fileio.c (Finsert_file_contents):
536 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
537 * process.c (wait_reading_process_output):
538 Rename inner 'proc' to 'p' to avoid shadowing.
539 Indent for consistency with usual Emacs style.
540
8c535114
EZ
5412011-11-25 Eli Zaretskii <eliz@gnu.org>
542
543 * xdisp.c (redisplay_window): If cursor row is not fully visible
544 after recentering, and scroll-conservatively is set to a large
545 number, scroll window by a few more lines to make the cursor fully
546 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
547 (start_display): Don't move to the next line if the display should
548 start at a newline that is part of a display vector or an overlay
549 string. (Bug#10119)
8c535114 550
fa4fdb5c
JL
5512011-11-24 Juri Linkov <juri@jurta.org>
552
553 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
554 after the `MagickPingImage' call. (Bug#10112)
555
90ec88df
CY
5562011-11-23 Chong Yidong <cyd@gnu.org>
557
558 * window.c (Fcoordinates_in_window_p): Accept only live windows.
559
56e2e794
MR
5602011-11-23 Martin Rudalics <rudalics@gmx.at>
561
562 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
563 making another buffer current. (Bug#10114)
564
b6e64c41
GM
5652011-11-23 Glenn Morris <rgm@gnu.org>
566
567 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
568
6b21de18
CY
5692011-11-23 Chong Yidong <cyd@gnu.org>
570
571 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
572 using it (Bug#5984).
573
b12cd789
EZ
5742011-11-22 Eli Zaretskii <eliz@gnu.org>
575
576 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
577 and header-lines, as they don't have one computed for them.
578 (Bug#10098)
579
580 * .gdbinit (prow): Make displayed values more self-explaining.
581 Add row's hash code.
582
261b6fd4
LMI
5832011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
584
585 * process.c (wait_reading_process_output): Fix asynchrounous
586 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 587 (wait_reading_process_output): Add comment and URL.
261b6fd4 588
e7cfd277
JD
5892011-11-21 Jan Djärv <jan.h.d@swipnet.se>
590
591 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
592
a9b9b7f5
CY
5932011-11-21 Chong Yidong <cyd@gnu.org>
594
595 * window.c (Fnext_window, Fprevious_window): Doc fix.
596
b0d15b4f
SM
5972011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
598
599 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
600
fe7a3057
JB
6012011-11-20 Juanma Barranquero <lekktu@gmail.com>
602
603 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
604
d2999b1a
MR
6052011-11-20 Martin Rudalics <rudalics@gmx.at>
606
607 * window.c (Fset_window_combination_limit): Rename argument
608 STATUS to LIMIT.
609 (Vwindow_combination_limit): Remove "status" from doc-string.
610
d5ff9cd0
AS
6112011-11-20 Andreas Schwab <schwab@linux-m68k.org>
612
613 * m/ibms390.h: Remove.
614 * m/ibms390x.h: Don't include "ibms390.h".
615
a5bb9bd3
SM
6162011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
617
618 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
619 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
620
cd1181db
JB
6212011-11-20 Juanma Barranquero <lekktu@gmail.com>
622
623 * casetab.c (Fset_case_table):
624 * charset.c (Fcharset_after): Fix typos.
625
615a3b8d 6262011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 627
17e845af
PE
628 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
629 Otherwise, valgrind does not work on some platforms.
630 Problem reported by Andreas Schwab in
6a0bf43d
PE
631 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
632 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
633 is set, removing the need for VIRT_ADDRESS_VARIES.
634 (PURE_P): Use a more-efficient implementation that needs just one
635 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
636 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
637 to 4 (xorl, subq, cmpq, setbe).
638 * alloc.c (pure): Always extern now, since that's the
639 VIRT_ADDR_VARIES behavior.
640 (PURE_POINTER_P): Use a single comparison, not two, for
641 consistency with the new puresize.h.
642 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
643 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
644 Remove VIRT_ADDR_VARIES no longer needed.
645
f8fe6f96
EZ
6462011-11-19 Eli Zaretskii <eliz@gnu.org>
647
648 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
649 (erase_phys_cursor, update_window_cursor, show_mouse_face)
650 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
651 behave as if the cursor position were at the window margin.
652
653 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
654 and the cursor position is out of bounds, behave as if the cursor
655 position were at the window margin. (Bug#10075)
656
df05a53c
CY
6572011-11-18 Chong Yidong <cyd@gnu.org>
658
659 * window.c (Fwindow_combination_limit): Make first argument
660 non-optional, since it is meaningless for live windows like the
661 selected window.
662
2071918e
DA
6632011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
664
665 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
666
b50a28de
SM
6672011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
668
669 * intervals.c: Fix grafting over the whole buffer (bug#10071).
670 (graft_intervals_into_buffer): Simplify.
671
015137db
EZ
6722011-11-18 Eli Zaretskii <eliz@gnu.org>
673
674 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
675 hash values of the two rows.
676 (copy_row_except_pointers): Preserve the used[] arrays and the
677 hash values of the two rows. (Bug#10035)
68c95424 678 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
679
680 * xdisp.c (row_hash): New function, body extracted from
681 compute_line_metrics.
682 (compute_line_metrics): Call row_hash, instead of computing the
683 hash code inline.
684
685 * dispnew.c (verify_row_hash): Call row_hash for computing the
686 hash code of a row, instead of duplicating code from xdisp.c.
687
688 * dispextern.h (row_hash): Add prototype.
689
a2addb04
TH
6902011-11-18 Tassilo Horn <tassilo@member.fsf.org>
691
692 * frame.c (delete_frame): Don't delete the terminal when the last
693 X frame is closed if emacs is built with GTK toolkit.
694
df85d315
JB
6952011-11-17 Juanma Barranquero <lekktu@gmail.com>
696
697 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
698
a0c2d0ae
MR
6992011-11-17 Martin Rudalics <rudalics@gmx.at>
700
701 * window.c (Vwindow_splits): Rename to
702 Vwindow_combination_resize. Suggested by Juri Linkov.
703 (Fsplit_window_internal): Use Vwindow_combination_resize instead
704 of Vwindow_splits.
705
58179cce
JB
7062011-11-16 Juanma Barranquero <lekktu@gmail.com>
707
7877f373
JB
708 * nsfns.m (Fns_font_name):
709 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 710
b6f67890
MR
7112011-11-16 Martin Rudalics <rudalics@gmx.at>
712
713 * window.h (window): Rename slot "nest" to "combination_limit".
714 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
715 (Fset_window_nest): Rename to Fset_window_combination_limit.
716 (Vwindow_nest): Rename to Vwindow_combination_limit.
717 (recombine_windows, make_parent_window, make_window)
718 (Fsplit_window_internal, saved_window)
719 (Fset_window_configuration, save_window_save): Rename all
720 occurrences of window_nest to window_combination_limit.
721
c7015153
JB
7222011-11-15 Juanma Barranquero <lekktu@gmail.com>
723
724 * image.c (imagemagick_load_image): Fix typo.
725
322ad6ec
EZ
7262011-11-14 Eli Zaretskii <eliz@gnu.org>
727
728 * xdisp.c (display_line): Move the call to
729 highlight_trailing_whitespace before the call to
730 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
731 faces of all the glyphs to compute ROW's hash value.
732 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 733
f067b8ec
JB
7342011-11-14 Juanma Barranquero <lekktu@gmail.com>
735
736 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
737 just return (bug#10044).
738
1e5b2111
EZ
7392011-11-12 Eli Zaretskii <eliz@gnu.org>
740
7ef3cbd5
EZ
741 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
742 with user-defined heap size. Bump the default size of the temacs
743 heap to 27MB, to avoid memory warning when running temacs.
744 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
745
1e5b2111
EZ
746 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
747 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
748 (verify_row_hash) [XASSERTS]: New function.
749 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
750 that the hash value of glyph rows is correct.
1e5b2111 751
89d61221
MR
7522011-11-12 Martin Rudalics <rudalics@gmx.at>
753
754 * window.h (window): Remove splits slot.
755 * window.c (Fwindow_splits, Fset_window_splits): Remove.
756 (Fdelete_other_windows_internal, make_parent_window)
757 (make_window, Fsplit_window_internal, Fdelete_window_internal)
758 (Fset_window_configuration, save_window_save): Don't deal with
759 split status of windows.
760 (saved_window): Remove splits slot.
761 (Vwindow_splits): Rewrite doc-string.
762
97f18cc8
JD
7632011-11-11 Jan Djärv <jan.h.d@swipnet.se>
764
765 * xfns.c (unwind_create_frame):
766 * nsfns.m (unwind_create_frame):
767 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
768 Vframe_list (Bug#9999).
769
22a648b4
DA
7702011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
771
0b381c7e 772 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 773
659afede
KH
7742011-11-11 Kenichi Handa <handa@m17n.org>
775
776 * callproc.c (Fcall_process): Set the member dst_multibyte of
777 process_coding.
778
9ac0394b
KH
7792011-11-11 Johan Bockgård <bojohan@gnu.org>
780
781 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
782 avoid a crash (bug#9496).
783
2fbdc249
CY
7842011-11-09 Chong Yidong <cyd@gnu.org>
785
786 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
787 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
788
ac6b1f81
PE
7892011-11-08 Paul Eggert <eggert@cs.ucla.edu>
790
791 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
792
09db192c
PE
7932011-11-08 Paul Eggert <eggert@cs.ucla.edu>
794
795 Avoid some portability problems by eschewing 'extern inline' functions.
796 The trivial performance wins aren't worth the portability hassles; see
797 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
798 et seq.
799 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
800 (window_box_width, window_box_left, window_box_left_offset)
801 (window_box_right, window_box_right_offset): Undo previous change,
802 by removing the "extern"s.
803 * intervals.c (adjust_intervals_for_insertion)
804 (adjust_intervals_for_deletion): Undo previous change,
805 making these static again.
806 (offset_intervals, temp_set_point_both, temp_set_point)
807 (copy_intervals_to_string): No longer inline.
808 * xdisp.c (window_text_bottom_y, window_box_width)
809 (window_box_height, window_box_left_offset)
810 (window_box_right_offset, window_box_left, window_box_right)
811 (window_box): No longer inline.
812
105216ed
CY
8132011-11-08 Chong Yidong <cyd@gnu.org>
814
815 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
816 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
817 Signal an error if not a live window.
105216ed
CY
818 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
819 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
820
ae9e237f
JB
8212011-11-07 Juanma Barranquero <lekktu@gmail.com>
822
823 * lisp.h (syms_of_abbrev): Remove declaration.
824 Reported by CHENG Gao <chenggao@royau.me>.
825
c7aa8333
EZ
8262011-11-07 Eli Zaretskii <eliz@gnu.org>
827
828 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
829 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
830 of temacs in GUI mode.
831
be7f5545
MR
8322011-11-07 Martin Rudalics <rudalics@gmx.at>
833
834 * window.h: Declare delete_all_child_windows instead of
835 delete_all_subwindows.
836 * window.c (Fwindow_nest, Fset_window_nest)
837 (Fset_window_new_total, Fset_window_new_normal)
838 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
839 (delete_all_subwindows): Rename to delete_all_child_windows.
840 (Fdelete_other_windows_internal, Fset_window_configuration):
841 Call delete_all_child_windows instead of delete_all_subwindows.
842 * frame.c (delete_frame): Call delete_all_child_windows instead
843 of delete_all_subwindows.
844
ca78dc43
PE
8452011-11-07 Paul Eggert <eggert@cs.ucla.edu>
846
847 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
848 This is also needed for porting to any host where GC_MARK_STACK is
849 not GC_MAKE_GCPROS_NOOPS.
850 (which_symbols): Use it.
851
a0241d01
KH
8522011-11-07 Kenichi Handa <handa@m17n.org>
853
854 * coding.c (coding_set_destination): Check coding->src_pos only
855 when coding->src_object is a buffer (bug#9910).
856
857 * process.c (send_process): Set the member src_multibyte of coding
858 to 0 (bug#9911) when sending a unibyte text.
859
860 * callproc.c (Fcall_process): Set the member src_multibyte of
861 process_coding to 0 (bug#9912).
862
a64bfdfa 8632011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
864
865 * xmenu.c (cleanup_widget_value_tree): New function.
866 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
867 calling free_menubar_widget_value_tree directly (Bug#9830).
868
cb41b32a
PE
8692011-11-06 Paul Eggert <eggert@cs.ucla.edu>
870
871 Fix some portability problems with 'inline'.
872 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
873 (window_box_width, window_box_left, window_box_left_offset)
874 (window_box_right, window_box_right_offset): Declare extern.
875 Otherwise, these inline functions do not conform to C99 and
876 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
877 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
878 * intervals.c (adjust_intervals_for_insertion)
879 (adjust_intervals_for_deletion): Now extern, because otherwise the
880 extern inline functions 'offset_intervals' couldn't refer to it.
881 (static_offset_intervals): Remove.
882 (offset_intervals): Rewrite using the old contents of
883 static_offset_intervals. The old version didn't conform to C99
884 because an extern inline function contained a reference to an
885 identifier with static linkage.
886
b7041366
AS
8872011-11-06 Andreas Schwab <schwab@linux-m68k.org>
888
889 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
890 GC.
891
88a37c4d
EZ
8922011-11-06 Eli Zaretskii <eliz@gnu.org>
893
894 * xdisp.c (init_iterator, reseat_to_string): Don't set the
895 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
896 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
897 return Qleft_to_right.
898
49745b39
CY
8992011-11-06 Chong Yidong <cyd@gnu.org>
900
901 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
902 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
903 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
904 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
905 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
906 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
907 (Fwindow_vscroll): Doc fix.
908 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
909 argument, since it makes no sense to pass a live window and for
910 consistency with window-child.
911
1f05cd82
CS
9122011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
913
914 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
915 support MSVC.
916
22610910
JR
9172011-11-05 Jason Rumney <jasonr@gnu.org>
918
919 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
920 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
921 fonts (Bug#6029).
922 (add_font_entity_to_list): Fix logic errors in mixed boolean and
923 bitwise arithmetic preventing use of unicode-sip and non-truetype
924 opentype fonts.
925
a06776b2
EZ
9262011-11-05 Eli Zaretskii <eliz@gnu.org>
927
3ad924ba
EZ
928 * s/ms-w32.h (fstat, stat, utime): Move redirections to
929 "emacs"-only part.
930
a06776b2
EZ
931 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
932 initialization code to keep similarity to xfns.c after changes
933 from 2011-11-05.
934
c9e7db78
JD
9352011-11-05 Jan Djärv <jan.h.d@swipnet.se>
936
a97f8f3f
JD
937 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
938 (unwind_create_frame): New function (Bug#9943).
939 (Fx_create_frame): Restructure code to be more similar to the one in
940 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
941 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
942 Move terminal->reference_count++ just before making the frame official
943 (Bug#9943).
944
945 * nsterm.m (x_free_frame_resources): New function.
946 (x_destroy_window): Move code to x_free_frame_resources.
947
c9e7db78 948 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
949 (Fx_create_frame, x_create_tip_frame):
950 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
951 official. Move initialization of image_cache_refcount and
952 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
953
a6fc3b5c
EZ
9542011-11-05 Eli Zaretskii <eliz@gnu.org>
955
956 Support MSVC build with newer versions of Visual Studio.
957 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
958 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
959 nt/gmake.defs.
960
961 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
962 which are not supported by MSVC.
963 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
964 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
965 bitfields.
966 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
967 types in bitfields.
968 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
969
970 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
971
58179cce 9722011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
973
974 Support MSVC build with newer versions of Visual Studio.
975 * w32.c: Don't include w32api.h for MSVC.
976 (init_environment) [_MSC_VER]: Call sys_access, not _access.
977
978 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
979 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
980 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
981 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
982 e_* cousins.
983 (alloca) [_MSC_VER]: Define to _alloca.
984
985 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
986
987 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
988
a58c13ed
EZ
9892011-11-04 Eli Zaretskii <eliz@gnu.org>
990
991 * xdisp.c (note_mouse_highlight): If either of
992 previous/next-single-property-change returns nil, treat that as
993 the beginning or the end of the buffer. (Bug#9955)
994
fe0b6370
JD
9952011-11-04 Jan Djärv <jan.h.d@swipnet.se>
996
a58c13ed 997 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
998 label is not null (Bug#9951).
999 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1000 may be NULL.
1001
89bd5ee1
EZ
10022011-11-04 Eli Zaretskii <eliz@gnu.org>
1003
1004 * window.c (Fwindow_body_size): Mention in the doc string that the
1005 return value is in frame's canonical units. (Bug#9949)
1006
84c3edb9
EZ
10072011-11-03 Eli Zaretskii <eliz@gnu.org>
1008
4e2fb5c7
EZ
1009 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1010
84c3edb9 1011 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1012 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1013 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1014
bc17a887
EZ
10152011-11-01 Eli Zaretskii <eliz@gnu.org>
1016
1017 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1018 Don't stop backward scan on the continuation glyph, even though
1019 its CHARPOS is positive.
6d5eb5b0
SM
1020 (mouse_face_from_buffer_pos, note_mouse_highlight):
1021 Rename cover_string to disp_string.
bc17a887 1022
4ee88440
MR
10232011-11-01 Martin Rudalics <rudalics@gmx.at>
1024
1025 * window.c (temp_output_buffer_show): Don't use
1026 Vtemp_buffer_show_specifiers.
1027 (Vtemp_buffer_show_specifiers): Remove unused variable.
1028
c2ff3c02
EZ
10292011-10-30 Eli Zaretskii <eliz@gnu.org>
1030
1031 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1032 past the beginning of the current glyph matrix.
1033
58179cce 10342011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1035
1036 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1037 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1038 HAVE_GTK3 (Bug#9869).
b77a6a7f 1039
3b574623
JD
1040 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1041 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1042
b77a6a7f
JD
1043 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1044
1045 * xterm.c: Declare x_handle_net_wm_state to return int.
1046 (handle_one_xevent): Check if we are iconified but don't have
1047 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1048 (get_current_wm_state): Return non-zero if not hidden,
1049 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1050 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1051 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1052 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1053
196e41e4
PE
10542011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1055
1056 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1057 so that this new function doesn't get optimized away by a
1058 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1059
021f2e1a
AS
10602011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1061
1062 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1063
8b058d44
EZ
10642011-10-29 Eli Zaretskii <eliz@gnu.org>
1065
1066 Fix the `xbytecode' command.
1067 * .gdbinit (xprintbytestr): New command.
b50a28de 1068 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1069 (xbytecode): Print the byte-code string as well.
1070
4452fb80
EZ
10712011-10-29 Kim Storm <storm@cua.dk>
1072
8b058d44
EZ
1073 * alloc.c (which_symbols): New function.
1074
21b72067
AS
10752011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1076
1077 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1078 line. (Bug#9903)
1079
83ed7b5c
GM
10802011-10-29 Glenn Morris <rgm@gnu.org>
1081
1082 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1083 Not clear what it was for, and it causes various bugs. (Bug#9839)
1084
5a7a728b
EZ
10852011-10-28 Eli Zaretskii <eliz@gnu.org>
1086
1087 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1088 possible random value that matches one of those tested as
1089 condition to clear the mouse face.
1090
d3d0842f
CY
10912011-10-28 Chong Yidong <cyd@gnu.org>
1092
1093 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1094
31b39d13
DN
10952011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1096
1097 * window.c (make_window): Initialize phys_cursor_on_p.
1098
9aba6043
SM
10992011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1100
1101 * lisp.h (struct Lisp_Symbol): Update comments.
1102
c20992f4
JB
11032011-10-28 Juanma Barranquero <lekktu@gmail.com>
1104
1105 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1106
db4f02f2
EZ
11072011-10-28 Eli Zaretskii <eliz@gnu.org>
1108
1109 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1110 <oslsachem@gmail.com> for helping to debug this.
1111
1112 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1113 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1114 (g_b_init_get_glyph_outline_w): New static variables.
1115 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1116 (GetGlyphOutlineW_Proc): New typedefs.
1117 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1118 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1119 New functions.
1120 (w32font_open_internal, compute_metrics):
1121 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1122 instead of calling the "wide" APIs directly.
1123
1124 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1125
1126 * w32.h (syms_of_w32font): Add prototype.
1127
87e68db4
JB
11282011-10-27 Juanma Barranquero <lekktu@gmail.com>
1129
1130 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1131 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1132 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1133 (Fmove_to_window_line): Doc fix.
1134
435c1d67
CY
11352011-10-27 Chong Yidong <cyd@gnu.org>
1136
1137 * process.c (make_process): Set gnutls_state to NULL.
1138
1139 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1140 non-NULL, regardless of GNUTLS_INITSTAGE.
1141 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1142 an error. Set process slots as soon as we allocate them.
1143
1144 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1145
9c6c6f49
CY
11462011-10-27 Chong Yidong <cyd@gnu.org>
1147
9aba6043
SM
1148 * gnutls.c (emacs_gnutls_deinit): New function.
1149 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1150 (Fgnutls_deinit, Fgnutls_boot): Use it.
1151
1152 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1153 (deactivate_process): Call emacs_gnutls_deinit.
1154
657d08d3
JB
11552011-10-27 Juanma Barranquero <lekktu@gmail.com>
1156
1157 * image.c (x_create_x_image_and_pixmap):
1158 * w32.c (sys_rename, w32_delayed_load):
1159 * w32font.c (fill_in_logfont):
1160 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1161
5430d399
JB
11622011-10-26 Juanma Barranquero <lekktu@gmail.com>
1163
1164 * w32fns.c (w32_default_color_map): New function,
1165 extracted from Fw32_default_color_map.
a7ef684b 1166 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1167
fe0055fa
PE
11682011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1169
1170 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1171
e6346438
SM
11722011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1173
1174 * keyboard.c (test_undefined): New function (bug#9751).
1175 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1176
e112cc37
ET
11772011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1178
1179 * sysdep.c (init_sys_modes): Fix the check for the controlling
1180 terminal (Bug#6649).
1181
7b5d6677
EZ
11822011-10-20 Eli Zaretskii <eliz@gnu.org>
1183
1184 * dispextern.h (struct bidi_it): New member next_en_type.
1185
1186 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1187 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1188 current character, check also for next_en_type being WEAK_EN.
1189 (bidi_resolve_weak): Don't enter the expensive loop if the current
1190 position is before next_en_pos. Record the bidi type of the first
1191 non-ET, non-BN character we find, in addition to its position.
1192 (bidi_level_of_next_char): Invalidate next_en_type when
1193 next_en_pos is over-stepped.
1194
7da0b018
PE
11952011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1196
1197 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1198 * editfns.c: Rewrite current-time-zone so that it invokes
1199 the equivalent of (format-time-string "%Z") to get the time zone name.
1200 This fixes a bug when the time zone name contains characters that
1201 need converting from the system time locale to Emacs internal format.
1202 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1203 that patch fixed format-time-string to do the conversion, but
1204 I forgot to fix current-time-zone.
1205 (format_time_string): New function, containing most of
1206 what Fformat_time_string used to contain.
1207 (Fformat_time_string): Rewrite in terms of format_time_string.
1208 This doesn't change this function's behavior.
1209 (current-time-zone): Rewrite to use format_time_string.
1210 This fixes the bug reported by Michael Schierl in
1211 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1212 Jason Rumney's 2007-06-07 change worked around this bug, but
1213 didn't fix it.
1214 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1215
8547b010
EZ
12162011-10-19 Eli Zaretskii <eliz@gnu.org>
1217
1218 * xdisp.c (start_display): If the character at POS is displayed
1219 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1220 (try_window_reusing_current_matrix): If a line ends in a display
1221 vector or the next line starts in a display vector, continue
1222 redrawing the window even though the character position of
1223 start_row was reached.
8547b010
EZ
1224 (Bug#9771, part 2)
1225
4e948d15
CY
12262011-10-18 Chong Yidong <cyd@gnu.org>
1227
1228 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1229 with nobreak-char-display too.
1230
4787455f
EZ
12312011-10-18 Eli Zaretskii <eliz@gnu.org>
1232
1233 Fix part 3 of bug#9771.
1234 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1235 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1236 non-neutral characters if the current character is a paragraph
1237 separator (a.k.a. Newline). This avoids running the same
1238 expensive loop twice, once when we consume the preceding newline
1239 and the other time when the line actually needs to be displayed.
1240 Avoid the loop when we see neutrals on the base embedding level
1241 following a character whose directionality is the same as the
1242 paragraph's. This avoids running the expensive loop when a line
1243 ends in a long sequence of neutrals, like control characters.
1244 Add assertion against STRONG_AL type. Slightly rearrange code
1245 that determines the type of a neutral given the first non-neutral
1246 that follows it.
1247 (bidi_level_of_next_char): Set next_en_pos to zero when
1248 invalidating its info.
1249
2c91f553
EZ
12502011-10-17 Eli Zaretskii <eliz@gnu.org>
1251
1252 * xdisp.c (push_display_prop): Determine whether to record string
1253 or buffer position by IT->string, not by IT->method. Allow
1254 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1255 (move_it_vertically_backward): Don't look for character position
1256 immediately after the newline when in a continuation line.
1257 (Bug#9771, part 1)
2c91f553 1258
c7b08b0d
MR
12592011-10-15 Martin Rudalics <rudalics@gmx.at>
1260
1261 * window.c (coordinates_in_window): Rewrite and delabelize
1262 vertical border check. (Bug#5357) (Bug#9618)
1263
6b02f655
SM
12642011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1265
1266 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1267 errors in XSetWindowBorder (bug#9310).
1268
81d40c92
DA
12692011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1270
1271 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1272 avoid crash when xmalloc overrun checking is enabled.
1273
d4172c3b
EZ
12742011-10-13 Eli Zaretskii <eliz@gnu.org>
1275
1276 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1277 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1278 cursor motion with <left> and <right> arrow keys.
1279
1280 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1281 some callers set that themselves.
1282
b00eea75
EZ
12832011-10-12 Eli Zaretskii <eliz@gnu.org>
1284
1285 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1286 display string and the previous row comes from the same string and
1287 is empty. (Bug#9739) (Bug#9738)
1288
8fe012c4
SM
12892011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1290
1291 * doc.c (get_doc_string): Encode file name (bug#9735).
1292
0074aef2
EZ
12932011-10-12 Eli Zaretskii <eliz@gnu.org>
1294
79beb178
EZ
1295 * bidi.c (bidi_level_of_next_char):
1296 * xdisp.c (get_visually_first_element): Remove old incorrect
1297 comments regarding the Unicode Line Separator character.
1298
0074aef2
EZ
1299 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1300
6e4b3fbe
DA
13012011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1302
1303 * alloc.c (Fgc_status): Do not access beyond zombies array
1304 boundary if nzombies > MAX_ZOMBIES.
1305 * alloc.c (dump_zombies): Add missing format specifier.
1306
0324f3af
PE
13072011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1308
b5525cac
PE
1309 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1310 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1311
0324f3af
PE
1312 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1313 Some packages use them to denote characters with modifiers.
1314
e9b5f888
AS
13152011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1316
1317 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1318 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1319 matching a pp-number. Rename parameter var to var1.
1320
127827c0
SM
13212011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1322
1323 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1324
c8fd3bd0
GM
13252011-10-08 Glenn Morris <rgm@gnu.org>
1326
1327 * callint.c (Fcall_interactively): Give a more explicit error for the
1328 'c' case with a non-character input. (Bug#8479)
1329
352ec8ff
EZ
13302011-10-08 Eli Zaretskii <eliz@gnu.org>
1331
03669ccb
EZ
1332 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1333 lines.
7061c986
EZ
1334 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1335 lines that are hscrolled on the left.
03669ccb 1336
352ec8ff
EZ
1337 * dispnew.c (buffer_posn_from_coords): Account for a possible
1338 presence of header-line. (Bug#4426)
1339
a66cfb1c
SM
13402011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1341
6b02f655
SM
1342 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1343 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1344
7c5ee88e
PE
13452011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1346
1347 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1348 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1349 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1350 this makes Emacs dump core during garbage collection on rare
1351 occasions. sizeof is obviously inferior to offsetof here, so
1352 stick with offsetof.
1353 (GC_POINTER_ALIGNMENT): New macro.
1354 (mark_memory): Omit 3rd (offset) arg; caller changed.
1355 Don't assume EMACS_INT alignment is the same as pointer alignment.
1356
df1bbe5b
SM
13572011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1358
1359 * keyboard.c (read_key_sequence_remapped): New var.
1360 (read_key_sequence): Compute remapping in the right buffer.
1361 (command_loop_1): Use read_key_sequence's remapping directly.
1362
51553db6
SM
13632011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1364
32c1fffd
SM
1365 * dired.c (file_name_completion): Don't expand file name.
1366 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1367 before checking file name handler.
1368
51553db6
SM
1369 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1370 they've been requested explicitly (bug#9591).
1371
b6bd1599 13722011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1373
1374 * keymap.c (Fsingle_key_description): Use make_specified_string
1375 instead of build_string to build string from push_key_description.
1376 (Bug#5193)
1377
f701dc2a
PE
13782011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1379
4222c55d
PE
1380 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1381 This fixes a Y2038 bug on 64-bit hosts.
1382 * buffer.c (reset_buffer):
1383 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1384 (Fclear_buffer_auto_save_failure):
1385 Use 0, not -1, to represent an unset failure time, since time_t
1386 might not be signed.
1387
f701dc2a
PE
1388 Remove dependency on glibc malloc internals.
1389 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1390 Move back here from lisp.h, but with their new implementations.
1391 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1392 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1393 * charset.c (charset_table_init): New static var.
1394 (syms_of_charset): Use it instead of xmalloc. This removes a
1395 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1396 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1397 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1398 Move back to alloc.c.
1399 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1400 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1401
9ceebf39
JD
14022011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1403
1404 * nsterm.m (windowDidResize): Call x_set_window_size only when
1405 ns_in_resize is true. Otherwise set pixelwidth/height and
1406 call change_frame_size (Bug#9628).
1407
cb993c58
PE
14082011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1409
3930c88b
PE
1410 Port --enable-checking=all to Fedora 14 x86-64.
1411 * charset.c (syms_of_charset): Also account for glibc malloc's
1412 internal overhead when calculating the initial malloc maximum.
1413
cb993c58
PE
1414 Port --enable-checking=all to Fedora 14 x86.
1415 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1416 Move to lisp.h.
1417 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1418 (overrun_check_realloc, overrun_check_free):
1419 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1420 That way, xmalloc returns a properly-aligned pointer even if
1421 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1422 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1423 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1424 into account when calculating the initial malloc maximum.
1425 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1426 Move here from alloc.c, so that charset.c can use it too.
1427 Properly align; the old code wasn't right for common 32-bit hosts
1428 when configured with --enable-checking=all.
1429 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1430 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1431
31bed486
EZ
14322011-09-29 Eli Zaretskii <eliz@gnu.org>
1433
04c70788 1434 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1435 use EDOM.
1436
fbcaa2f3
EZ
14372011-09-28 Eli Zaretskii <eliz@gnu.org>
1438
1439 * xdisp.c (compute_display_string_end): If there's no display
1440 string at CHARPOS, return -1.
1441
1442 * bidi.c (bidi_fetch_char): When compute_display_string_end
1443 returns a negative value, treat the character as a normal
1444 character not covered by a display string. (Bug#9624)
1445
a239d4e9
JB
14462011-09-28 Juanma Barranquero <lekktu@gmail.com>
1447
1448 * lread.c (Fread_from_string): Fix typo in docstring.
1449
88652fd5
EZ
14502011-09-27 Eli Zaretskii <eliz@gnu.org>
1451
1452 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1453 newline, reseat the iterator instead of bidi-iterating there one
1454 character at a time. (Bug#9610)
32c1fffd
SM
1455 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1456 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1457
ed497dd4
AS
14582011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1459
1460 * lread.c (readevalloop): Use correct code for NBSP.
1461 (read1): Likewise. (Bug#9608)
1462
b2bf61aa
MA
14632011-09-25 Michael Albinus <michael.albinus@gmx.de>
1464
1465 * dbusbind.c (Fdbus_register_signal): When service is not
1466 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1467
32bbb17c
GM
14682011-09-25 Glenn Morris <rgm@gnu.org>
1469
1470 * buffer.c (truncate-lines): Doc fix.
1471
94e0933e
CY
14722011-09-24 Chong Yidong <cyd@stupidchicken.com>
1473
1474 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1475 (Fset_window_next_buffers): Doc fix.
1476
cddde921
GM
14772011-09-24 Glenn Morris <rgm@gnu.org>
1478
1479 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1480
1260aef1
PE
14812011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1482
25b4bfa0
PE
1483 Fix minor problems found by static checking.
1484 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1485 * indent.c (Fvertical_motion): Fix == vs = typo.
1486
e3cbd34b
EZ
14872011-09-24 Eli Zaretskii <eliz@gnu.org>
1488
a66cfb1c
SM
1489 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1490 Default value is now t. Doc fix.
6bf7006f 1491
e3cbd34b 1492 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1493 logic when moving up, not only when moving down. Fix the
e3cbd34b 1494 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1495 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1496
1497 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1498 CHARPOS is covered by a display string which includes newlines.
1499 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1500 is covered by a display string with embedded newlines.
1501
a3de0cbd
MA
15022011-09-24 Michael Albinus <michael.albinus@gmx.de>
1503
1504 * dbusbind.c (Fdbus_register_signal): Add match rule to
1505 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1506 (Fdbus_register_method, Vdbus_registered_objects_table):
1507 Fix docstring.
a3de0cbd 1508
b260039d
JM
15092011-09-24 Jim Meyering <meyering@redhat.com>
1510
32c1fffd 1511 do not ignore write error for any output size
b260039d
JM
1512 The previous change was incomplete.
1513 While it makes emacs --batch detect the vast majority of stdout
1514 write failures, errors were still ignored whenever the output size is
1515 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1516 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1517 && echo FAIL: ignored write error
1518 FAIL: ignored write error
1519 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1520 && echo FAIL: ignored write error
1521 FAIL: ignored write error
1522 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1523
8eca8a7c
AS
15242011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1525
1526 * emacs.c (Fkill_emacs): In noninteractive mode exit
1527 non-successfully if a write error occurred on stdout. (Bug#9574)
1528
3341db62
EZ
15292011-09-21 Eli Zaretskii <eliz@gnu.org>
1530
1531 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1532 the xassert test.
1533
1534 * dispextern.h (struct it): Update the comment documenting what
1535 can it->OBJECT be.
1536
8c203dbf
EZ
15372011-09-20 Eli Zaretskii <eliz@gnu.org>
1538
1539 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1540 a display string, extend search for cursor position to end of row.
1541 (find_row_edges): If the row ends in a newline from a display
1542 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1543 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1544 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1545 non-empty line. Fixes confusing cursor motion with arrow keys at
1546 the beginning of a line that starts with whitespace.
8c203dbf 1547
a4824228
LMI
15482011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1549
1550 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1551 (bug#9493).
1552
33ed493b
CY
15532011-09-18 Chong Yidong <cyd@stupidchicken.com>
1554
1555 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1556 boolean (Bug#9154).
1557
56cd55c8
EZ
15582011-09-18 Eli Zaretskii <eliz@gnu.org>
1559
1560 * xdisp.c (display_line): Record maximum and minimum buffer
1561 positions even if no glyphs were produced (e.g., by a zero-width
1562 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1563 buffer positions that will be removed from the glyph row because
1564 they don't fit.
c02dcedf
EZ
1565 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1566 column is beyond frame width: don't subtract 1 "pixel" when
1567 computing width of the stretch.
3e62b7e0
EZ
1568 (reseat_at_next_visible_line_start): Undo the change made on
1569 2011-09-17 that saved paragraph information and restored it after
1570 the call to `reseat'. (Bug#9545)
56cd55c8 1571
5ed99d36 15722011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1573
1574 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1575 and turn window cursor on if cleared (Bug#9415).
1576
5ed99d36 15772011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1578
1579 * search.c (boyer_moore): Take unibyte characters from pattern
1580 literally. (Bug#9458)
1581
9bade7b2
EZ
15822011-09-18 Eli Zaretskii <eliz@gnu.org>
1583
1584 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1585
e5e9d610
PE
15862011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1587
87e4427a
PE
1588 Fix minor problem found by static checking.
1589 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1590 initialized, to pacify gcc -Wuninitialized.
1591
e5e9d610
PE
1592 * fileio.c: Report proper errno when syscall falls.
1593 (Finsert_file_contents): Save and restore errno,
1594 so that report_file_error outputs the correct diagnostic.
1595 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1596
a1674f0b
EZ
15972011-09-18 Eli Zaretskii <eliz@gnu.org>
1598
1599 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1600
fbfb6dd4
EZ
16012011-09-17 Eli Zaretskii <eliz@gnu.org>
1602
1603 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1604 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1605
bb187662
EZ
16062011-09-17 Eli Zaretskii <eliz@gnu.org>
1607
1137e8b8 1608 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1609 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1610
1611 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1612 (bidi_find_paragraph_start): Search back for paragraph beginning
1613 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1614 (bidi_move_to_visually_next): Only trigger paragraph-related
1615 computations when the last character is a newline or at EOB, not
1616 just any NEUTRAL_B. (Bug#9470)
1617
bb187662
EZ
1618 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1619 truncated lines if point is covered by a display string. (Bug#9524)
1620
2e621251
PE
16212011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1622
1623 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1624 (cons_to_x_long): New function.
1625 (lisp_data_to_selection_data): Use it. Correct the test for
1626 short-versus-long data; it was negated. Break out of vector
1627 loop, for efficiency, when a long datum is discovered.
1628
91a15bc6
SM
16292011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1630
1631 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1632
b41c3a35
EZ
16332011-09-16 Eli Zaretskii <eliz@gnu.org>
1634
1635 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1636 GCC PR/17406) by declaring this function with external scope.
1637
7812ba2d
PE
16382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1639
1640 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1641 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1642
cf7edc2a
AS
16432011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1644
1645 * editfns.c (Fformat): Correctly handle text properties on "%%".
1646
bd01620e
EZ
16472011-09-15 Eli Zaretskii <eliz@gnu.org>
1648
1649 * xterm.c (x_draw_composite_glyph_string_foreground):
1650 * w32term.c (x_draw_composite_glyph_string_foreground):
1651 * term.c (encode_terminal_code):
1652 * composite.c (composition_update_it, get_composition_id):
1653 * xdisp.c (get_next_display_element)
1654 (fill_composite_glyph_string): Add comments about special meaning
1655 of TAB characters in a composition.
1656
a02719a3
PE
16572011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1658
1659 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1660 This occurs when processing a multibyte format.
1661 Problem reported by Wolfgang Jenker.
a02719a3 1662
72589a3c
JB
16632011-09-15 Johan Bockgård <bojohan@gnu.org>
1664
1665 * xdisp.c (try_cursor_movement): Only check for exact match if
1666 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1667
1c14176c
PE
16682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1669
1670 Remove unused external symbols.
1671 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1672 * xdisp.c (calc_pixel_width_or_height): Now static.
1673 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1674 * indent.c (check_display_width):
1675 * w32term.c: Fix comment to match code.
1676 * xterm.c, xterm.h (x_catching_errors): Remove.
1677
d2eea5b5
PE
16782011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 * xselect.c: Use signed conversions more consistently (Bug#9498).
1681 (selection_data_to_lisp_data): Assume incoming selection data are
1682 signed integers, not unsigned. This is to be consistent with
1683 outgoing selection data, which was modified to use signed integers
1684 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1685 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1686 expects long, not unsigned long.
1687
46888499
EZ
16882011-09-14 Eli Zaretskii <eliz@gnu.org>
1689
1690 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1691 computation of loop end. Reported by Johan Bockgård
1692 <bojohan@gnu.org>.
1693
ef8ef9fb
CY
16942011-09-13 Chong Yidong <cyd@stupidchicken.com>
1695
1696 * frame.c (Fother_visible_frames_p): Function deleted.
1697
fa819fed
EZ
16982011-09-12 Eli Zaretskii <eliz@gnu.org>
1699
1700 * indent.c (compute_motion): Process display vector front to back
1701 rather than the other way around. (Bug#2496)
1702
2ba8e008
SM
17032011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1704
1705 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1706
20f53c69
CY
17072011-09-11 Chong Yidong <cyd@stupidchicken.com>
1708
1709 * minibuf.c (Fread_from_minibuffer): Doc fix.
1710
d562d7a4
EZ
17112011-09-11 Eli Zaretskii <eliz@gnu.org>
1712
1713 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1714 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1715
1c4d7f3d
LMI
17162011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1717
1718 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1719 value for non-existent files.
1720
b885bf36
EZ
17212011-09-11 Eli Zaretskii <eliz@gnu.org>
1722
1723 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1724 set its "size" to -1. This will set the modtime_size field of
1725 the corresponding buffer to -1, which is what
1726 verify-visited-file-modtime expects for files that do not exist.
1727 (Bug#9139)
1728
6612f0bf
PE
17292011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1730
1731 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1732 here ...
1733 * lisp.h: ... from here. push_key_description is no longer
1734 defined in keyboard.c, so its declaration should not be in
1735 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1736 logically belongs with push_key_description.
1737
dfb3f755
PE
17382011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1739
1740 * buffer.h: Include <sys/types.h> instead of <time.h>.
1741 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1742 Problem reported by Herbert J. Skuhra.
1743
3134906c
LMI
17442011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1745
1746 * xml.c (parse_region): Make the parsing work for
1747 non-comment-starting XML files again (bug#9144).
1748
8d903f4e
AS
17492011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1750
1751 * image.c (gif_load): Fix calculation of bottom and right corner.
1752 (Bug#9468)
1753
80ad64f4
EZ
17542011-09-10 Eli Zaretskii <eliz@gnu.org>
1755
1756 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1757 redisplay in small windows.
1758
208a048d
EZ
17592011-09-09 Eli Zaretskii <eliz@gnu.org>
1760
1761 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1762
9b1c252e
MR
17632011-09-08 Martin Rudalics <rudalics@gmx.at>
1764
1765 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1766 Operate on live windows only.
1767
2949f33b
JB
17682011-09-08 Juanma Barranquero <lekktu@gmail.com>
1769
1770 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1771
e08dcafd
EZ
17722011-09-07 Eli Zaretskii <eliz@gnu.org>
1773
1774 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1775 only under bidi iteration.
1776
115b96bd
JD
17772011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1778
1779 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1780
c8199d0f
PE
17812011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1782
1783 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1784 Without this fix, the command to link temacs failed due to an
1785 undefined symbol __builtin_isnan. This is because
1786 /usr/include/iso/math_c99.h #defines isnan(x) to
1787 __builtin_isnan(x), but the bundled gcc, which identifies itself
1788 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1789 a __builtin_isnan.
1790 * floatfns.c (isnan): #undef, and then #define to a clone of
1791 what's in data.c.
1792 (Fisnan): Always define, since it's always available now.
1793 (syms_of_floatfns): Always define isnan at the Lisp level.
1794
e39b275c 17952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1796
1797 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1798
b2db44d9 17992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1800
f4af5137 1801 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1802 The previous code assumed that file offsets (off_t values) fit in
1803 EMACS_INT variables, which is not true on typical 32-bit hosts.
1804 The code messed up by falsely reporting buffer overflow in cases
1805 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1806 when "big" contains more than 2**29 bytes, even though this
1807 inserts just one byte and does not overflow the buffer.
1808 (Finsert_file_contents): Store file offsets as off_t
1809 values, not as EMACS_INT values. Check for overflow when
1810 converting between EMACS_INT and off_t. When checking for
1811 buffer overflow or for overlap, take the offsets into account.
1812 Don't use EMACS_INT for small values where int suffices.
1813 When checking for overlap, fix a typo: ZV was used where
1814 ZV_BYTE was intended.
1815 (Fwrite_region): Don't assume off_t fits into 'long'.
1816 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1817
ecfc0a49
MA
18182011-09-05 Michael Albinus <michael.albinus@gmx.de>
1819
1820 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1821
6511acf2 18222011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1823
0999621a 1824 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1825
1826 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1827 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1828 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1829 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1830 (modify_event_symbol): Do not assume that the length of
1831 name_alist_or_stem is safe to alloca and fits in int.
1832 (Fexecute_extended_command): Likewise for function name and binding.
1833 (Frecursion_depth): Wrap around reliably on integer overflow.
1834 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1835 since some callers pass EMACS_INT values.
1836 (Fsingle_key_description): Don't crash if symbol name contains more
1837 than MAX_ALLOCA bytes.
1838 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1839 (get_minibuffer): Arg is now EMACS_INT, not int.
1840 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1841 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1842 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1843
2be7d702
PE
1844 * dbusbind.c (signature_cat): New function.
1845 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1846 Do not overrun buffer; instead, report string overflow.
1847
9d1df220
PE
1848 * dispnew.c (add_window_display_history): Don't overrun buffer.
1849 Truncate instead; this is OK since it's just a log.
1850
33ef5c64
PE
1851 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1852 even if the time zone offset is outlandishly large.
1853 Don't mishandle offset == INT_MIN.
1854
66c6fdd5
PE
1855 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1856 when creating daemon; the previous buffer-overflow check was incorrect.
1857
d749b01b
PE
1858 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1859 which has the guts of the old verror function.
1860
b5cd1905
PE
1861 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1862 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1863
6e1a67fb
PE
1864 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1865 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1866 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1867 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1868 length of string rather than counting it via multiple sprintfs;
1869 that's simpler and more reliable.
c21721cc
PE
1870 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1871 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1872 sprintf, in case result does not fit in int.
1873
c57b67fc
PE
1874 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1875 (fontset_from_font): Print it.
1876
8a401434
PE
1877 * frame.c (tty_frame_count): Now printmax_t, not int.
1878 (make_terminal_frame, set_term_frame_name): Print it.
1879 (x_report_frame_params): In X, window IDs are unsigned long,
1880 not signed long, so print them as unsigned.
1881 (validate_x_resource_name): Check for implausibly long names,
1882 and don't assume name length fits in 'int'.
1883 (x_get_resource_string): Don't blindly alloca invocation name;
1884 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1885 not fit in int.
1886
6e1a67fb
PE
1887 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1888 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1889 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1890
0df02bf3
PE
1891 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1892 Use esprintf, not sprintf, in case result does not fit in int.
1893
48e30793
PE
1894 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1895 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1896 it as a large positive number.
1897 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1898 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1899
a66ff6d8
PE
1900 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1901 in case result does not fit in int.
1902
aca216ff
PE
1903 * print.c (float_to_string): Detect width overflow more reliably.
1904 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1905 buffer overrun. Don't assume list length fits in 'int'. Treat
1906 print length of 0 as 0, not as infinity; to be consistent with other
1907 uses of print length in this function. Don't overflow print length
1908 index. Don't assume hash table size fits in 'long', or that
1909 vectorlike size fits in 'unsigned long'.
1910
31c286f7
PE
1911 * process.c (make_process): Use printmax_t, not int, to format
1912 process-name gensyms.
1913
55e5faa1
PE
1914 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1915
80f2e268
PE
1916 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1917 to avoid potential buffer overrun.
1918
670741ab
PE
1919 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1920 if X resource line is longer than 512 bytes.
1921
b7163a50
PE
1922 * xfns.c (x_window): Make sprintf buffer a bit bigger
1923 to avoid potential buffer overrun.
1924
ae58ff1f
PE
1925 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1926
c43c8a6a
PE
1927 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1928
3f8236f4
PE
19292011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1930
53e9fe90 1931 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1932 Without these, Emacs silently mishandles large integers sometimes.
1933 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1934 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1935
6511acf2
PE
1936 * xdisp.c (try_window_id): Check Emacs fixnum range before
1937 converting to 'int'.
806add1d 1938
6511acf2 1939 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1940 Check that an Emacs fixnum is in range before assigning it to 'int'.
1941 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1942 values converted from Emacs fixnums.
1943 (Frecenter): Don't wrap around a line count if it is out of 'int'
1944 range; instead, treat it as an extreme value.
1945 (Fset_window_configuration, compare_window_configurations):
1946 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1947
6511acf2
PE
1948 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1949 that can exceed INT_MAX. Check that EMACS_INT value is in range
1950 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1951 (match_limit): Don't assume that a fixnum can fit in 'int'.
1952
6511acf2 1953 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1954 exceed INT_MAX.
1955
6511acf2 1956 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1957 (Fvertical_motion): Don't wrap around LINES values that don't fit
1958 in 'int'. Instead, treat them as extreme values. This is good
1959 enough for windows, which can't have more than INT_MAX lines anyway.
1960
fcb901a7
LMI
19612011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1962
0f2f6b6d
LMI
1963 * Require libxml/parser.h to avoid compilation warning.
1964
fcb901a7
LMI
1965 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1966
1967 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1968 since this reportedly can destroy thread storage.
1969
6e20a0d4
CY
19702011-08-30 Chong Yidong <cyd@stupidchicken.com>
1971
1972 * syntax.c (find_defun_start): Update all cache variables if
1973 exiting early (Bug#9401).
1974
148ae00e
EZ
19752011-08-30 Eli Zaretskii <eliz@gnu.org>
1976
f6cfbd8f
EZ
1977 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1978
148ae00e
EZ
1979 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1980 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1981 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1982
1983 * term.c (tty_append_glyph): New function.
1984 (produce_stretch_glyph): Static function and its prototype deleted.
1985
a66cfb1c
SM
1986 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1987 Add prototypes.
148ae00e 1988
c4a07a4c
PE
19892011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1990
1991 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1992 when checking :margin (Bug#9390).
1993 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1994 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1995 so that the name doesn't mislead. All uses changed.
1996
6bc8cd65
JB
19972011-08-28 Johan Bockgård <bojohan@gnu.org>
1998
1999 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2000 set_tty_hooks.
2001
dca4927e
EZ
20022011-08-27 Eli Zaretskii <eliz@gnu.org>
2003
2004 * xdisp.c (move_it_to): Don't bail out early when reaching
2005 position beyond to_charpos, if we are scanning backwards.
2006 (move_it_vertically_backward): When DY == 0, make sure we get to
2007 the first character in the line after the newline.
2008
f2cad773
PE
20092011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2012 (ccl_driver): Do not generate an out-of-range pointer.
2013 (Fccl_execute_on_string): Remove unnecessary check for
2014 integer overflow, noted by Stefan Monnier in
2015 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2016 Remove a FIXME that didn't need fixing.
2017 Simplify the newly-introduced buffer reallocation code.
2018
0cae2cdb
JB
20192011-08-27 Juanma Barranquero <lekktu@gmail.com>
2020
2021 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2022
5fc295a4 20232011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2024
70c60eb2 2025 Integer and memory overflow issues (Bug#9196).
726e0ab1 2026
d31850da
PE
2027 * doc.c (get_doc_string): Rework so that
2028 get_doc_string_buffer_size is the actual buffer size, rather than
2029 being 1 less than the actual buffer size; this makes xpalloc more
2030 convenient.
2031
a69fbedb
PE
2032 * image.c (x_allocate_bitmap_record, cache_image):
2033 * xselect.c (Fx_register_dnd_atom):
2034 Simplify previous changes by using xpalloc.
2035
fe5c5d37
PE
2036 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2037 since either will do and ptrdiff_t is convenient with xpalloc.
2038
0065d054
PE
2039 * charset.c (charset_table_size)
2040 (struct charset_sort_data.priority): Now ptrdiff_t.
2041 (charset_compare): Don't overflow if priorities differ greatly.
2042 (Fsort_charsets): Don't assume list length fits in int.
2043 Check for size-calculation overflow when allocating sort data.
2044 (syms_of_charset): Allocate an initial charset table that is
2045 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2046
2047 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2048
2049 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2050 The actual value is always <= INT_MAX, and leaving it unsigned made
2051 overflow checking harder.
2052
2053 * dispextern.h (struct glyph_matrix.rows_allocated)
2054 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2055 with xpalloc. The values are still always <= INT_MAX.
2056
2057 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2058
2059 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2060 (SAFE_NALLOCA): New macro.
2061
2062 * region-cache.c (struct boundary.pos, find_cache_boundary)
2063 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2064 (set_cache_region, invalidate_region_cache)
2065 (revalidate_region_cache, know_region_cache, region_cache_forward)
2066 (region_cache_backward, pp_cache):
2067 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2068 so that ptrdiff_t * can be passed to xpalloc.
2069 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2070 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2071 (pp_cache): Don't assume cache_len fits in int.
2072 * region-cache.h: Adjust extern decls to match.
2073
2074 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2075 EMACS_INT, since either will do, for xpalloc.
2076
2077 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2078 (xnmalloc, xnrealloc, xpalloc): New functions.
2079
726e0ab1
PE
2080 * bidi.c (bidi_shelve_header_size): New constant.
2081 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2082 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2083
51f30bc5 2084 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2085 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2086 (overlay_strings):
2087 Don't update size of array until after memory allocation succeeds,
2088 because xmalloc/xrealloc may not return.
0065d054
PE
2089 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2090 now that we have proper integer overflow checking.
2091 (record_overlay_string, overlay_strings): Catch overflows when
2092 calculating size of overlay_str_buf.
726e0ab1 2093
0065d054
PE
2094 * callproc.c (Fcall_process): Check for size overflow when
2095 calculating size of args2.
2096 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2097 Normally we prefer signed values, but sticking with ptrdiff_t would
2098 require adding more-complicated checks.
726e0ab1
PE
2099
2100 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2101 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2102 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2103 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2104
2105 * character.c (Fstring): Check for size-calculation overflow.
2106
2107 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2108 unnecessary integer overflow. Check for size overflow.
2109 (encode_coding_object): Don't update size until xmalloc succeeds.
2110
2111 * composite.c (get_composition_id): Check for overflow in glyph
2112 length calculations.
2113
2114 Integer and memory overflow fixes for display code.
2115 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2116 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2117 (scrolling_window): Check for overflow in size calculations.
2118 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2119 Don't assume glyph table len fits in int.
2120 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2121 (row_table_size): Now ptrdiff_t, not int.
2122 (scrolling_window): Avoid overflow in size calculations.
2123 Don't update size until allocation succeeds.
2124 * fns.c (concat): Check for overflow in size calculations.
2125 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2126 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2127 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2128
2129 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2130 (get_doc_string): Check for size calculation overflow.
2131 Don't update size until allocation succeeds.
2132 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2133 EMACS_INT, where ptrdiff_t will do.
2134 (Fsubstitute_command_keys): Check for string overflow.
2135
2136 * editfns.c (set_time_zone_rule): Don't assume environment length
2137 fits in int.
2138 (message_length): Now ptrdiff_t, not int.
2139 (Fmessage_box): Don't update size until allocation succeeds.
2140 Don't assume message length fits in int.
2141 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2142
0065d054
PE
2143 * emacs.c (main): Do not reallocate argv, since there is a null at
2144 the end that can be overwritten, and this way there's no need to
2145 worry about size-calculation overflow.
2146 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2147
2148 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2149 alloc succeeds.
2150 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2151
2152 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2153 (x_set_scroll_bar_width, x_figure_window_size):
2154 Check for integer overflow.
2155 (x_set_alpha): Do not assume XINT fits in int.
2156
2157 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2158 This is for the members text_lines, text_cols, total_lines, total_cols,
2159 where the system imposes an 'int' limit.
2160
2161 * fringe.c (Fdefine_fringe_bitmap):
2162 Don't update size until alloc works.
2163
2164 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2165 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2166
2167 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2168 Check for size-calculation overflow.
2169 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2170 do, as we prefer signed integers.
2171 (id_to_widget.max_size, id_to_widget.used)
2172 (xg_store_widget_in_map, xg_remove_widget_from_map)
2173 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2174 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2175 Use and return ptrdiff_t, not int.
2176 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2177 * gtkutil.h: Change prototypes to match the above.
2178
2179 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2180 are duplicate now that they've been promoted to lisp.h.
2181 (x_allocate_bitmap_record, x_alloc_image_color)
2182 (make_image_cache, cache_image, xpm_load):
2183 Don't update size until alloc is done.
2184 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2185 (x_detect_edges):
3256efce 2186 Check for size calculation overflow.
726e0ab1
PE
2187 (ct_colors_allocated_max): New constant.
2188 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2189 overflow.
3256efce 2190
726e0ab1
PE
2191 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2192 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2193 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2194 Use ptrdiff_t, not int, to count maps.
2195 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2196 calculations. Don't update size until allocation succeeds.
2197 Redo calculations to avoid overflow.
726e0ab1
PE
2198 * keyboard.h: Change prototypes to match the above.
2199
2200 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2201 to count maps.
2202 (current_minor_maps): Check for size calculation overflow.
2203 * keymap.h: Change prototypes to match the above.
2204
2205 * lread.c (read1, init_obarray): Don't update size until alloc done.
2206
2207 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2208 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2209
726e0ab1
PE
2210 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2211 Now ptrdiff_t, not int.
2212 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2213 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2214
2215 * process.c (Fnetwork_interface_list): Check for overflow
2216 in size calculation.
2217
2218 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2219
2220 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2221 overflow. Don't bother calling xmalloc when xrealloc will do.
2222
2223 * search.c (Freplace_match): Check for size calculation overflow.
2224 (Fset_match_data): Don't assume list lengths fit in 'int'.
2225
2226 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2227 for command line length. Do not attempt to address one before the
2228 beginning of an array, as that's not portable.
2229
2230 * term.c (max_frame_lines): Remove; unused.
2231 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2232 not int.
2233 (encode_terminal_code, calculate_costs): Check for size
2234 calculation overflow.
2235 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2236 table lengths and related sizes. Don't update size until alloc
2237 done. Redo calculations to avoid overflow.
2238 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2239
2240 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2241 subtracting pointers.
2242 (gobble_line): Check for overflow more carefully. Don't update size
2243 until alloc done.
2244
2245 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2246 Don't update size until alloc done.
2247 Redo size calculations to avoid overflow.
2248 Check for size calculation overflow.
0065d054 2249 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2250
2251 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2252 Use ptrdiff_t, not int, for sizes.
2253 (store_mode_line_noprop_char): Don't update size until alloc done.
2254
0065d054
PE
2255 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2256 Use ptrdiff_t, not int, for sizes.
2257 (Finternal_make_lisp_face, cache_face):
2258 Check for size calculation overflow.
2259 (cache_face): Treat size calculation overflows as if they were
2260 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2261
2262 * xfns.c (x_encode_text, x_set_name_internal)
2263 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2264 sizes, since they can exceed INT_MAX in size. Check for size
2265 calculation overflow.
2266
0065d054
PE
2267 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2268 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2269 Don't update size until alloc done.
2270
0065d054 2271 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2272 as sprintf is limited to int lengths.
1d526e2f 2273
252c5ee1
PE
2274 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2275 (X_LONG_MIN): New macros.
864d7ce7
PE
2276 Use them to make the following changes clearer.
2277 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2278 This change doesn't affect the value now, but it may help remind
2279 future maintainers not to raise the value too much later.
2280 (SELECTION_QUANTUM): Remove, replacing with ...
2281 (selection_quantum): ... new function, which avoids overflow.
2282 All uses changed.
2283 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2284 assumption that selection length fits in 'int'.
2285 (x_reply_selection_request, x_handle_selection_request)
2286 (x_get_window_property, receive_incremental_selection)
2287 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2288 (lisp_data_to_selection_data, clean_local_selection_data):
2289 Use ptrdiff_t, not int, to record length of selection.
2290 (x_reply_selection_request, x_get_window_property)
2291 (receive_incremental_selection, x_property_data_to_lisp):
2292 Redo calculations to avoid overflow.
2293 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2294 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2295 something.
2296 (x_get_window_property, receive_incremental_selection)
2297 (lisp_data_to_selection_data, x_property_data_to_lisp):
2298 Check for size-calculation overflow.
2299 (x_get_window_property, receive_incremental_selection)
2300 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2301 Don't store size until memory allocation succeeds.
2302 (x_get_window_property): Plug memory leak on memory exhaustion.
2303 Don't double-block input; malloc is safe here. Don't assume 2**34
2304 - 4 fits in unsigned long. Add an xassert to check
2305 XGetWindowProperty overflow. Be more careful about overflow
2306 calculations, and distinguish size from memory overflow better.
2307 (receive_incremental_selection): When tracing, don't assume
2308 unsigned int is less than INT_MAX.
2309 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2310 harmful) conversions of unsigned short to int.
2311 (lisp_data_to_selection_data): Don't assume that integers
2312 in the range -65535 through -1 fit in an X unsigned short.
2313 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2314 result parameters unless successful. Rely on cons_to_unsigned
2315 to report problems with elements; the old code wasn't right anyway.
2316 (x_check_property_data): Check for int overflow; we cannot use
2317 a wider type due to X limits.
2318 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2319
726e0ab1 2320 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2321
0065d054
PE
2322 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2323 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2324 (x_color_cells): Don't store size until memory allocation succeeds.
2325 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2326 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2327 (x_term_init): Don't assume length fits in int (sprintf is limited
2328 to int size).
bc18e09d 2329
ebfa62c0
PE
2330 Use ptrdiff_t for composition IDs.
2331 * character.c (lisp_string_width):
2332 * composite.c (composition_table_size, n_compositions)
2333 (get_composition_id, composition_gstring_from_id):
2334 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2335 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2336 * window.c (Frecenter):
2337 Use ptrdiff_t, not int, for composition IDs.
2338 * composite.c (get_composition_id): Check for integer overflow.
2339 * composite.h: Adjust prototypes to match the above changes.
2340
d3411f89
PE
2341 Use ptrdiff_t for hash table indexes.
2342 * category.c (hash_get_category_set):
2343 * ccl.c (ccl_driver):
2344 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2345 * coding.c (coding_system_charset_list, detect_coding_system):
2346 * coding.h (struct coding_system.id):
2347 * composite.c (get_composition_id, gstring_lookup_cache):
2348 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2349 * image.c (xpm_get_color_table_h):
2350 * lisp.h (hash_lookup, hash_put):
2351 * minibuf.c (Ftest_completion):
2352 Use ptrdiff_t for hash table indexes, not int (which is too
2353 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2354 32-bit --with-wide-int hosts).
2355
e097a6fa
PE
2356 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2357 Add a FIXME comment about memory leaks.
2358 (syms_of_charset): Don't assume xmalloc returns.
2359
5637687f
PE
2360 Don't assume that stated character widths fit in int.
2361 * character.c (Fchar_width, c_string_width, lisp_string_width):
2362 * character.h (CHAR_WIDTH):
2363 * indent.c (MULTIBYTE_BYTES_WIDTH):
2364 Use sanitize_char_width to avoid undefined and/or bad behavior
2365 with outlandish widths.
a66cfb1c 2366 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2367 now that we have two such functions. All uses changed.
2368 (sanitize_char_width): New inline function.
2369
a2271ba2
PE
2370 Don't assume that tab-width fits in int.
2371 * character.h (sanitize_width): New inline function.
2372 (SANE_TAB_WIDTH): New macro.
2373 (ASCII_CHAR_WIDTH): Use it.
2374 * indent.c (sane_tab_width): Remove. All uses replaced by
2375 SANE_TAB_WIDTH (current_buffer).
2376 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2377
18c52557
PE
2378 * fileio.c: Integer overflow issues with file modes.
2379 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2380
caeeedc1
PE
2381 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2382 Remove unreachable code.
2383 (read_hex, load_charset_map_from_file): Check for integer overflow.
2384
6df6ae42 2385 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2386 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2387 (x_send_scroll_bar_event): Likewise. Check that the size does not
2388 exceed limits imposed by XClientMessageEvent, as well as the usual
2389 ptrdiff_t and size_t limits.
2390
b13995db
PE
2391 * keyboard.c: Overflow, signedness and related fixes.
2392 (make_lispy_movement): Use same integer type in forward decl
2393 that is used in the definition.
2394 (read_key_sequence, keyremap_step):
2395 Change bufsize argument back to int, undoing my 2011-03-30 change.
2396 We prefer signed types, and int is wide enough here.
2397 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2398 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2399 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2400 length, not size_t. Use ptrdiff_t for index, not int.
2401 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2402 possibility of integer overflow.
2403
13464394
PE
2404 Overflow, signedness and related fixes for images.
2405
2406 * dispextern.h (struct it.stack[0].u.image.image_id)
2407 (struct_it.image_id, struct image.id, struct image_cache.size)
2408 (struct image_cache.used, struct image_cache.ref_count):
2409 * gtkutil.c (update_frame_tool_bar):
2410 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2411 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2412 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2413 * nsmenu.m (update_frame_tool_bar):
2414 * xdisp.c (calc_pixel_width_or_height):
2415 * xfns.c (image_cache_refcount):
2416 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2417 on typical 64-bit hosts.
2418
2419 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2420 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2421 Omit unnecessary casts to int.
2422 (parse_image_spec): Check that integers fall into 'int' range
2423 when the callers expect that.
2424 (image_ascent): Redo ascent calculation to avoid int overflow.
2425 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2426 (lookup_image): Remove unnecessary tests.
2427 (xbm_image_p): Locals are now of int, not EMACS_INT,
2428 since parse_image_check makes sure they fit into int.
2429 (png_load, gif_load, svg_load_image):
2430 Prefer int to unsigned where either will do.
2431 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2432 old tiff_error_handler and tiff_warning_handler.
2433 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2434 stack buffer overflows. It uses only the features of vsnprintf
2435 that are common to both POSIX and native Microsoft.
2436 (tiff_error_handler, tiff_warning_handler): Use it.
2437 (tiff_load, gif_load, imagemagick_load_image):
2438 Don't assume :index value fits in 'int'.
2439 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2440 (imagemagick_load_image): Check that crop parameters fit into
2441 the integer types that MagickCropImage accepts. Don't assume
2442 Vimagemagick_render_type has a nonnegative value. Don't assume
2443 size_t fits in 'long'.
2444 (gs_load): Use printmax_t to print the widest integers possible.
2445 Check for integer overflow when computing image height and width.
2446
c11821d4
EZ
24472011-08-26 Eli Zaretskii <eliz@gnu.org>
2448
2449 * xdisp.c (redisplay_window): Don't force window start if point
2450 will be invisible in the resulting window. (Bug#9324)
2451
0c95fcf7
EZ
24522011-08-25 Eli Zaretskii <eliz@gnu.org>
2453
2454 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2455 the display spec is of the form `(space ...)'.
2456 (handle_display_spec): Return the value returned by
2457 handle_single_display_spec, not just 1 or zero.
2458 (handle_single_display_spec): If the display spec is of the form
2459 `(space ...)', and specifies display in the text area, return 2
2460 rather than 1.
fee65a97 2461 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2462 accurately, and prefer exact match for point under bidi.
2463 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2464
2465 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2466 into disp_prop; all users changed.
2467
2468 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2469 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2470 for the text covered by the display property.
2471
e4ed06f1
CY
24722011-08-25 Chong Yidong <cyd@stupidchicken.com>
2473
2474 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2475 Change return value to nil.
2476 (Frecord_buffer): Delete unused function.
2477
f67cdd7f
EZ
24782011-08-24 Eli Zaretskii <eliz@gnu.org>
2479
5980d4c6
EZ
2480 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2481 buffers, return left-to-right.
8610fe8b
EZ
2482 (set_cursor_from_row): Consider candidate row a win if its glyph
2483 represents a newline and point is on that newline. Fixes cursor
2484 positioning on the newline at EOL of R2L text within L2R
2485 paragraph, and vice versa.
2486 (try_cursor_movement): Check continued rows, in addition to
2487 continuation rows. Fixes unwarranted scroll when point enters a
2488 continued line of R2L text within an L2R paragraph, or vice versa.
2489 (cursor_row_p): Consider the case of point being equal to
2490 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2491 from the end of a short line to the beginning of a continued line
2492 of R2L text within L2R paragraph.
2493 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2494 composed characters.
5980d4c6 2495
f67cdd7f
EZ
2496 * bidi.c (bidi_check_type): Use xassert.
2497 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2498 members.
2499
bca633fb
EZ
25002011-08-23 Eli Zaretskii <eliz@gnu.org>
2501
2502 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2503 a character.
2504
4a5885a7
CY
25052011-08-23 Chong Yidong <cyd@stupidchicken.com>
2506
2507 * nsfont.m (ns_otf_to_script): Fix typo.
2508
0902a04e
KH
25092011-08-22 Kenichi Handa <handa@m17n.org>
2510
2511 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2512 extra slot even if the purpose is char-code-property-table.
2513
1a2e6670
EZ
25142011-08-23 Eli Zaretskii <eliz@gnu.org>
2515
8ddde651
EZ
2516 * xdisp.c (redisplay_window): When computing centering_position,
2517 account for the height of the header line. (Bug#8874)
2518
425cc014
EZ
2519 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2520 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2521 candidate is selected by the mouse, and that candidate has a
2522 composed character under the mouse.
2523
1a2e6670
EZ
2524 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2525 coordinates reported by pos-visible-in-window-p for a composed
2526 character in column zero.
2527
8b76d6f8
SM
25282011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2529
2530 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2531
dac347dd
EZ
25322011-08-22 Eli Zaretskii <eliz@gnu.org>
2533
2534 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2535 consider it a hit if to_charpos is anywhere in the range of the
2536 composed buffer positions.
2537
e013fb34
CY
25382011-08-22 Chong Yidong <cyd@stupidchicken.com>
2539
2540 * image.c (gif_load): Don't assume that each subimage has the same
2541 dimensions as the base image. Handle disposal method that is
2542 "undefined" by the gif spec (Bug#9335).
2543
bd1ba3e8
CY
25442011-08-20 Chong Yidong <cyd@stupidchicken.com>
2545
2546 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2547 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2548
54a1215b
EZ
25492011-08-19 Eli Zaretskii <eliz@gnu.org>
2550
823564e5
EZ
2551 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2552 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2553 from an Org mode buffer to a Speedbar frame.
2554
54a1215b
EZ
2555 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2556 a composition, take its buffer position from IT->cmp_it.charpos.
2557 Fixes cursor positioning at the beginning of a line that begins
2558 with a composed character.
2559
9778ebcc
EZ
25602011-08-18 Eli Zaretskii <eliz@gnu.org>
2561
0be6ee06
EZ
2562 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2563 character bidirectional type, use STRONG_L instead. Fixes crashes
2564 in a buffer produced by `describe-categories'.
2565
9778ebcc
EZ
2566 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2567 members before the level stack, so they would be saved and
2568 restored when copying iterator state. Fixes incorrect reordering
2569 around TABs covered by display properties.
2570
156bffbe
AS
25712011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2572
6b02f655 2573 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2574
72ad093b
CY
25752011-08-17 Chong Yidong <cyd@stupidchicken.com>
2576
2577 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2578 (internal_condition_case_2, internal_condition_case_n):
2579 Remove unnecessary aborts (Bug#9081).
72ad093b 2580
35774242
EZ
25812011-08-17 Eli Zaretskii <eliz@gnu.org>
2582
2583 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2584 has no `load' handler, try opening the file locally. (Bug#9311)
2585
db76dd85
KB
25862011-08-16 Ken Brown <kbrown@cornell.edu>
2587
2588 * gmalloc.c: Expand comment.
2589
b215eee5
EZ
25902011-08-16 Eli Zaretskii <eliz@gnu.org>
2591
2592 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2593 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2594
a4579d33
KB
25952011-08-16 Ken Brown <kbrown@cornell.edu>
2596
2597 Fix memory allocation problems in Cygwin build (Bug#9273).
2598
2599 * unexcw.c ( __malloc_initialized): Declare external variable.
2600 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2601
8b76d6f8
SM
2602 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2603 New variables.
a4579d33
KB
2604 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2605 dumped emacs.
2606 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2607 in the static heap.
2608 [CYGWIN] (special_realloc): New function.
2609 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2610 requests to realloc storage in the static heap.
2611
3ebec551
PE
26122011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2613
2614 * bidi.c (bidi_initialize): Remove unused local.
2615
9fd8be00
EZ
26162011-08-15 Eli Zaretskii <eliz@gnu.org>
2617
6b02f655
SM
2618 * bidimirror.h:
2619 * biditype.h: Remove file.
2620 * makefile.w32-in ($(BLD)/bidi.$(O)):
2621 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2622
2623 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2624
2625 * chartab.c: Improve commentary for the uniprop_table API.
2626
32413314
EZ
2627 * bidi.c (bidi_paragraph_init): Support zero value of
2628 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2629 (bidi_initialize): Use uniprop_table instead of including
2630 biditype.h and bidimirror.h.
32413314 2631
9fd8be00
EZ
2632 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2633 coordinates of the iterator when restoring from ppos_it.
2634 (Bug#9296)
2635
5cf2b69b
KH
26362011-08-14 Kenichi Handa <handa@m17n.org>
2637
2638 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2639 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2640
daf17d00
EZ
26412011-08-14 Eli Zaretskii <eliz@gnu.org>
2642
2643 * xdisp.c (move_it_in_display_line_to): Don't invoke
2644 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2645 ppos_it. Fixes vertical cursor motion when line beginning is
2646 covered by an image. (Bug#9296)
2647
08e3161a
JD
26482011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2649
2650 * nsterm.h (ns_run_ascript): Declare.
2651 (NSAPP_DATA2_RUNASSCRIPT): Define.
2652
2653 * nsfns.m (as_script, as_result, as_status): New static variables.
2654 (ns_run_ascript): New function.
5e617bc2 2655 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2656 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2657 the event loop. Get status from as_status (Bug#7276).
2658
2659 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2660 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2661 the event loop (Bug#7276).
2662
a3720aa2
AS
26632011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2664
2665 * gnutls.c (QCgnutls_bootprop_priority)
2666 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2667 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2668 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2669 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2670 (QCgnutls_bootprop_verify_hostname_error)
2671 (QCgnutls_bootprop_callbacks_verify): Rename from
2672 Qgnutls_bootprop_..., all uses changed.
2673
2674 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2675 uses changed.
2676
0a0d27fb
PE
26772011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2678
19d5c50c
PE
2679 * xfaces.c (Qframe_set_background_mode): Now static.
2680 * dispextern.h (Qframe_set_background_mode): Remove decl.
2681
0a0d27fb
PE
2682 * process.c (Fnetwork_interface_info): Declare local only if needed.
2683
377538cb
JD
26842011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2685
2686 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2687 (Fnetwork_interface_list): Allocate in increments of bytes instead
2688 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2689 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2690 sockaddr.
2691 (struct ifflag_def): notrailers is smart on OSX.
2692 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2693 Get hardware address with getifaddrs if available.
2694
08fff70c
EZ
26952011-08-12 Eli Zaretskii <eliz@gnu.org>
2696
2697 * xdisp.c (iterate_out_of_display_property): xassert that
2698 IT->position is set to within IT->object's boundaries. Break from
2699 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2700 when IT->position is set up wrongly due to some bug.
2701 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2702 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2703 entry. Force push_it to save on the stack the current
2704 buffer/string position, to be restored by pop_it. Fix flags in
2705 the iterator structure wrt the object coming from a display
2706 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2707 properties. (Bug#9284)
2708
7be1c708 27092011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2710
7be1c708
CY
2711 * fontset.c (fontset_get_font_group): Add proper type checks.
2712 (Bug#9172)
aac0c6e3 2713
7be1c708 27142011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2715
7be1c708
CY
2716 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2717 and LC_VERSION_MIN_MACOSX.
2718 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2719 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2720
97bb72a6
EZ
27212011-08-08 Eli Zaretskii <eliz@gnu.org>
2722
2723 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2724 no-display-properties-and-no-overlays under bidi display.
2725 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2726 properties and overlays.
97bb72a6 2727
d5617611
CY
27282011-08-08 Chong Yidong <cyd@stupidchicken.com>
2729
37e11a63
CY
2730 * editfns.c (Fset_time_zone_rule): Document relationship with the
2731 setenv function.
2732
d5617611
CY
2733 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2734 the font entity extracted from the cache (Bug#8109).
2735
58872834
CY
27362011-08-07 Chong Yidong <cyd@stupidchicken.com>
2737
2738 * composite.c (autocmp_chars): Don't reset point. That is done by
2739 restore_point_unwind (Bug#5984).
2740
75bfc667
JL
27412011-08-07 Juri Linkov <juri@jurta.org>
2742
2743 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2744 to show the arg `TIME' instead of `TIMEVAL'.
2745
d1410150
EZ
27462011-08-06 Eli Zaretskii <eliz@gnu.org>
2747
2748 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2749 display property strides EOL and includes a newline, as in
2750 longlines-mode. (Bug#9254)
75b771e4
EZ
2751 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2752 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2753
2754 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2755 is non-zero, even if the data buffer is NULL. Fixes a crash in
2756 vertical-motion with longlines-mode. (Bug#9254)
2757
35928349
EZ
27582011-08-05 Eli Zaretskii <eliz@gnu.org>
2759
ec7cc85b
EZ
2760 * bidi.c <bidi_cache_total_alloc>: Now static.
2761 (bidi_initialize): Initialize bidi_cache_total_alloc.
2762
8b76d6f8 2763 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2764 cache. (Bug#9221)
2765
2766 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2767 amount allocated this far in `bidi_cache_total_alloc'.
2768 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2769 non-zero, only free the data buffer without restoring the cache
2770 contents. All callers changed.
2771
2772 * dispextern.h (bidi_unshelve_cache): Update prototype.
2773
2774 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2775 (move_it_in_display_line, move_it_to)
2776 (move_it_vertically_backward, move_it_by_lines): Replace the call
2777 to xfree to an equivalent call to bidi_unshelve_cache.
2778 (move_it_in_display_line_to): Fix logic of returning
412b6358 2779 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2780
e2e2423b
EZ
27812011-08-05 Eli Zaretskii <eliz@gnu.org>
2782
2783 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2784 came from a string character with a `cursor' property. (Bug#9229)
2785
ae9e757a
JD
27862011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2787
2788 * Makefile.in (LIB_PTHREAD): New variable.
2789 (LIBES): Add LIB_PTHREAD (Bug#9216).
2790
2791 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2792 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2793
213bd7f2
AS
27942011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2795
6b02f655 2796 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2797
99aaf75f
JD
27982011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2799
2800 * xterm.c (x_find_topmost_parent): New function.
2801 (x_set_frame_alpha): Find topmost parent window with
2802 x_find_topmost_parent and set the property there also (bug#9181).
2803 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2804
c74e9d86
PE
28052011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2806
2807 * callproc.c (Fcall_process): Avoid vfork clobbering
2808 the local vars buffer, coding_systems, current_dir.
2809
640c8776
SM
28102011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2811
2812 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2813
f26d0e4c
PE
28142011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2815
8a10d76c
PE
2816 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2817 so that it is not optimized away.
2818
f26d0e4c
PE
2819 * xdisp.c (compute_display_string_pos): Remove unused local.
2820
55439c61
EZ
28212011-08-02 Eli Zaretskii <eliz@gnu.org>
2822
2823 Fix slow cursor motion and scrolling in large buffers with
2824 selective display, like Org Mode buffers. (Bug#9218)
2825
2826 * dispextern.h (struct bidi_it): New member disp_prop_p.
2827
2828 * xdisp.c: Remove one-slot cache of display string positions.
2829 (compute_display_string_pos): Accept an additional argument
5e617bc2 2830 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2831 for a display string or property. If found, set DISP_PROP_P
2832 non-zero.
2833
2834 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2835 DISP_PROP_P, and pass it to compute_display_string_pos.
2836 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2837 non-zero. All callers of bidi_fetch_char changed.
2838
fb33fa43
SM
28392011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2840
2841 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2842
b099e063
DM
28432010-12-03 Don March <don@ohspite.net>
2844
2845 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2846 last character M-[char] is translated to ESC [char] (bug#7541).
2847
5cc7f7af
KH
28482011-08-02 Kenichi Handa <handa@m17n.org>
2849
d0fffa3f 2850 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2851
2852 * chartab.c (uniprop_table): Make it non-static.
2853
525d5e6e
EZ
28542011-08-01 Eli Zaretskii <eliz@gnu.org>
2855
2856 * xdisp.c (forward_to_next_line_start): Accept additional argument
2857 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2858 on the newline.
2859 (reseat_at_next_visible_line_start): Use the bidi iterator state
2860 returned by forward_to_next_line_start to restore the state of
2861 it->bidi_it after backing up to previous newline. (Bug#9212)
2862
31011111
AS
28632011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2864
2865 * regex.c (re_comp): Protoize.
2866 (re_exec): Fix return type.
2867 (regexec): Fix type of `ret'. (Bug#9203)
2868
476371c4
PE
28692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2870
e5d76069
PE
2871 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2872 This is needed if max-image-size is a floating-point number.
2873
9a79b20c
AS
28742011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2875
2876 * print.c (print_object): Print empty symbol as ##.
2877
2878 * lread.c (read1): Read ## as empty symbol.
2879
d8c2fa78
AA
28802011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2881
2882 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2883 setting frame foreground color (Bug#9175).
2884 (x_set_background_color): Likewise.
2885
ffe57a7a
AA
2886 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2887 contents (Bug#9176).
2888 (EmacsTooltip -init): Remove bezels and add shadows to
2889 tooltip windows.
2890
bf3492a5
AA
2891 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2892 or scroll bar (Bug#8470).
2893
d55e9c53
AA
2894 * nsfont.m (nsfont_open): Remove assignment to voffset and
2895 unnecessary vars hshink, expand, hd, full_height, min_height.
2896 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2897
2898 * nsterm.h (nsfont_info): Remove voffset field.
2899
d8c2fa78 29002011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2901
2902 Implement strike-through and overline on NextStep (Bug#8863).
2903
2904 * nsfont.m (nsfont_open): Use underline position provided by font,
2905 instead of hard-coded value of 2.
2906 (nsfont_draw): Call ns_draw_text_decoration instead.
2907
2908 * nsterm.h: Add declaration for ns_draw_text_decoration.
2909
2910 * nsterm.m (ns_draw_text_decoration): New function for drawing
2911 underline, overline, and strike-through.
2912 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2913 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2914 accommodate underlining, etc.
4843aac3 2915
4cc60b9b
EZ
29162011-07-28 Eli Zaretskii <eliz@gnu.org>
2917
bc7ece87
EZ
2918 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2919 default.
4cc60b9b 2920
476371c4
PE
29212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2922
66606eea
PE
2923 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2924 Without this fix, if a signal arrives just after memory fills up,
2925 'malloc' might be invoked reentrantly.
2926
476371c4
PE
2927 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2928 In other words, assume that every image size is allowed, on non-X
2929 hosts. This assumption is probably wrong, but it lets Emacs compile.
2930
f3fcc40d
AS
29312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2932
2933 * regex.c (re_iswctype): Convert return values to boolean.
2934
350c992f
EZ
29352011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2936
2937 * xdisp.c (compute_display_string_pos): Don't use cached display
2938 string position if the buffer had its restriction changed.
2939 (Bug#9184)
2940
5266b4bb
PE
29412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2942
2943 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2944
2573a837 29452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2946
41f55ccd 2947 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2948
39e378da
PE
2949 * bidi.c: Integer size and overflow fixes.
2950 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2951 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2952 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2953 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2954 (bidi_find_other_level_edge):
2955 Use ptrdiff_t instead of EMACS_INT where either will do.
2956 This works better on 32-bit hosts configured --with-wide-int.
2957 (bidi_cache_ensure_space): Check for size-calculation overflow.
2958 Use % rather than repeated addition, for better worst-case speed.
2959 Don't set bidi_cache_size until after xrealloc returns, because it
2960 might not return.
2961 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2962 (bidi_cache_ensure_space): Also check that the bidi cache size
2963 does not exceed that of the largest Lisp string or buffer. See Eli
2964 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2965
5e927815
PE
2966 * alloc.c (__malloc_size_t): Remove.
2967 All uses replaced by size_t. See Andreas Schwab's note
2968 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2969
ca4aa935
PE
2970 * image.c: Improve checking for integer overflow.
2971 (check_image_size): Assume that f is nonnull, since
2972 it is always nonnull in practice. This is one less thing to
2973 worry about when checking for integer overflow later.
2974 (x_check_image_size): New function, which checks for integer
2975 overflow issues inside X.
2976 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2977 This removes the need for a memory_full check.
2978 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2979 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2980 (xbm_read_bitmap_data): Change locals back to 'int', since
2981 their values must fit in 'int'.
2982 (xpm_load_image, png_load, tiff_load):
2983 Invoke x_create_x_image_and_pixmap earlier,
2984 to avoid much needless work if the image is too large.
2985 (tiff_load): Treat overly large images as if
2986 x_create_x_image_and_pixmap failed, not as malloc failures.
2987 (gs_load): Use x_check_image_size.
2988
5f8f9cc2
PE
2989 * gtkutil.c: Omit integer casts.
2990 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2991 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2992
5adf60bc
PE
2993 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2994
c8907a93
PE
2995 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2996 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2997 would wrongly return t on a 64-bit host.
2998
e3c25c68
PE
2999 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3000 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3001 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3002 and therefore cause GCC to emit a bogus diagnostic in some cases.
3003
3f791afe
PE
3004 * image.c: Integer signedness and overflow and related fixes.
3005 This is not an exhaustive set of fixes, but it's time to
3006 record what I've got.
3007 (lookup_pixel_color, check_image_size): Remove redundant decls.
3008 (check_image_size): Don't assume that arbitrary EMACS_INT values
3009 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3010 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3011 (tiff_load, imagemagick_load_image):
3012 Check for overflow in size calculations.
3013 (x_create_x_image_and_pixmap): Remove unnecessary test for
3014 xmalloc returning NULL; that can't happen.
3015 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3016 (xpm_color_bucket): Use better integer hashing function.
3017 (xpm_cache_color): Don't possibly over-allocate memory.
3018 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3019 (gif_memory_source):
3020 Use ptrdiff_t, not int or size_t, to record sizes.
3021 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3022 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3023 either works, as we prefer signed integers.
3024 (tiff_read_from_memory, tiff_write_from_memory):
3025 Return tsize_t, not size_t, since that's what the TIFF API wants.
3026 (tiff_read_from_memory): Don't fail simply because the read would
3027 go past EOF; instead, return a short read.
3028 (tiff_load): Omit no-longer-needed casts.
3029 (Fimagemagick_types): Don't assume size fits into 'int'.
3030
3cc5a532
PE
3031 Improve hashing quality when configured --with-wide-int.
3032 * fns.c (hash_string): New function, taken from sxhash_string.
3033 Do not discard information about ASCII character case; this
3034 discarding is no longer needed.
3035 (sxhash-string): Use it. Change sig to match it. Caller changed.
3036 * lisp.h: Declare it.
3037 * lread.c (hash_string): Remove, since we now use fns.c's version.
3038 The fns.c version returns a wider integer if --with-wide-int is
3039 specified, so this should help the quality of the hashing a bit.
3040
b312a492
PE
3041 * emacs.c: Integer overflow minor fix.
3042 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3043 Define only if GNU_LINUX.
3044 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3045
dfd153ae
PE
3046 * dispnew.c: Integer signedness and overflow fixes.
3047 Remove unnecessary forward decls, that were a maintenance hassle.
3048 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3049 All uses changed.
3050 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3051 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3052 (prepare_desired_row, line_draw_cost):
3053 Use int, not unsigned, where either works.
3054 (save_current_matrix, restore_current_matrix):
3055 Use ptrdiff_t, not size_t, where either works.
3056 (init_display): Check for overflow more accurately, and without
3057 relying on undefined behavior.
3058
a81d11a3
PE
3059 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3060 Remove, replacing with the new symbols in lisp.h. All uses changed.
3061 * fileio.c (make_temp_name):
3062 * filelock.c (lock_file_1, lock_file):
3063 * xdisp.c (message_dolog):
3064 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3065 Use pMd etc. instead.
3066 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3067 replacing the pWIDE etc. symbols removed from editfns.c.
3068
3300e6fd
PE
3069 * keyboard.h (num_input_events): Now uintmax_t.
3070 This is (very slightly) less likely to mess up due to wraparound.
3071 All uses changed.
3072
fd05c7e9
PE
3073 * buffer.c: Integer signedness fixes.
3074 (alloc_buffer_text, enlarge_buffer_text):
3075 Use ptrdiff_t rather than size_t when either will do, as we prefer
3076 signed integers.
3077
903fe15d
PE
3078 * alloc.c: Integer signedness and overflow fixes.
3079 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3080 (__malloc_size_t): Default to size_t, not to int.
3081 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3082 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3083 Prefer ptrdiff_t to size_t when either would do, as we prefer
3084 signed integers.
3085 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3086 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3087 Now const. Initialize with values that are in range even if char
3088 is signed.
3089 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3090 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3091 These functions do the right thing with sizes > 2**32.
3092 (check_depth): Now ptrdiff_t, not int.
3093 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3094 Adjust to new way of storing sizes. Check for size overflow bugs
3095 in rest of code.
3096 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3097 slightly wrong anyway, as it missed one instance of
3098 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3099 (refill_memory_reserve): Omit needless cast to size_t.
3100 (mark_object_loop_halt): Mark as externally visible.
3101
ac82cc6a
PE
3102 * xselect.c: Integer signedness and overflow fixes.
3103 (Fx_register_dnd_atom, x_handle_dnd_message):
3104 Use ptrdiff_t, not size_t, since we prefer signed.
3105 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3106 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3107 x_dnd_atoms_size and x_dnd_atoms_length.
3108
c2d1e36d
PE
3109 * doprnt.c: Prefer signed to unsigned when either works.
3110 * eval.c (verror):
3111 * doprnt.c (doprnt):
3112 * lisp.h (doprnt):
3113 * xdisp.c (vmessage):
3114 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3115 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3116 prefer signed arithmetic to avoid comparison confusion.
3117 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3118 but is a bit tricky.
3119
0e926e56
PE
3120 Assume freestanding C89 headers, string.h, stdlib.h.
3121 * data.c, doprnt.c, floatfns.c, print.c:
3122 Include float.h unconditionally.
3123 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3124 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3125 * regex.c: Likewise for stddef.h, string.h.
3126 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3127 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3128 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3129 (STDC_HEADERS): Remove obsolete defines.
3130 * sysdep.c: Include limits.h unconditionally.
3131
9cfdb3ec
PE
3132 Assume support for memcmp, memcpy, memmove, memset.
3133 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3134 * regex.c (memcmp, memcpy):
3135 Remove; we assume C89 now.
3136
3137 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3138 (__malloc_safe_bcopy): Remove; no longer needed.
3139
cf950e6b 3140 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3141 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3142 well either way, and we prefer signed to unsigned.
3143
dbf38e02
LMI
31442011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3145
3146 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3147 closes the connection while we're reading (bug#9182).
3148
d6f0886c 31492011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3150
d6f0886c
JD
3151 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3152 are specified (Bug#9168).
24e0f6b1 3153
2eb1f9e6
PE
31542011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3157 Found by GCC static checking and --with-wide-int on a 32-bit host.
3158
22381272 31592011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3160
3161 * xdisp.c (compute_display_string_pos): Fix logic of caching
3162 previous display string position. Initialize cached_prev_pos to
3163 -1. Fixes slow-down at the beginning of a buffer.
3164
f25e39b4
EZ
31652011-07-24 Eli Zaretskii <eliz@gnu.org>
3166
3167 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3168 for attrs[LFACE_FONTSET_INDEX].
3169
04c4b52e
PE
31702011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3171
3172 * xml.c (parse_region): Remove unused local
3173 that was recently introduced.
3174
c1734fbd
EZ
31752011-07-23 Eli Zaretskii <eliz@gnu.org>
3176
be18c5a5
EZ
3177 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3178 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3179
c1734fbd
EZ
3180 * xdisp.c (move_it_in_display_line_to): Record the best matching
3181 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3182 exit if none of the characters scanned was an exact match.
3183 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3184 when exact match is impossible due to invisible text, and the
3185 lines are truncated.
3186
a258d627
JD
31872011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3188
3189 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3190 for OSX >= 10.7.
3191
b6d5a689
EZ
31922011-07-22 Eli Zaretskii <eliz@gnu.org>
3193
0f74f785
EZ
3194 Fix a significant slow-down of cursor motion with C-n, C-p,
3195 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3196 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3197 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3198 (next_element_from_buffer): Call compute_stop_pos_backwards to
3199 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3200 base_level_stop.
3201 (reseat): Don't look for prev_stop, as that could mean a very long
3202 run.
3203 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3204 <cached_disp_overlay_modiff>: Cache for last found display string
3205 position.
551918c1 3206 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3207 about the same buffer in the same area of character positions, and
3208 the buffer wasn't changed since the time the display string
3209 position was cached.
551918c1 3210
b2d0c91a
EZ
32112011-07-22 Eli Zaretskii <eliz@gnu.org>
3212
3213 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3214 is an integer, which is important for empty lines. (Bug#9149)
3215
043604ee
CY
32162011-07-22 Chong Yidong <cyd@stupidchicken.com>
3217
3218 * frame.c (Fmodify_frame_parameters): In tty case, update the
3219 default face if necessary (Bug#4238).
3220
da4adb04
CY
32212011-07-21 Chong Yidong <cyd@stupidchicken.com>
3222
3223 * editfns.c (Fstring_to_char): No need to explain what a character
3224 is in the docstring (Bug#6576).
3225
9abd0532
LMI
32262011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3227
3228 * xml.c (parse_region): Make sure we always return a tree.
3229
36881d16
HK
32302011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3231
3232 * xml.c (parse_region): If a document contains only comments,
3233 return that, too.
3234
1e98674d
LMI
32352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3236
3237 * xml.c (make_dom): Return comments, too.
3238
590bd467
PE
32392011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3240
3241 Port to OpenBSD.
3242 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3243 and the surrounding thread.
3244 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3245 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3246 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3247 timer goes off.
3248 * s/openbsd.h (BROKEN_SIGIO): Define.
3249 * unexelf.c (unexec) [__OpenBSD__]:
3250 Don't update the .mdebug section of the Alpha COFF symbol table.
3251
f41628b2
LMI
32522011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3253
3254 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3255 (bug#8460).
3256
b59b67c5
PE
32572011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3258
15e3a074
PE
3259 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3260 This fixes some race conditions on the permissions of any newly
3261 created file.
3262
41bed37d
PE
3263 * alloc.c (valid_pointer_p): Use pipe, not open.
3264 This fixes some permissions issues when debugging.
3265
b59b67c5
PE
3266 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3267 If fchown fails to set both uid and gid, try to set just gid,
3268 as that is sometimes allowed. Adjust the file's mode to eliminate
3269 setuid or setgid bits that are inappropriate if fchown fails.
3270
925a6be7
SM
32712011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3272
3273 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3274 to compare Lisp_Objects.
3275 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3276 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3277 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3278
52968808
AS
32792011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3280
0a6a104b
AS
3281 * lread.c (read_integer): Unread even EOF character.
3282 (read1): Likewise. Properly record start position of symbol.
3283
52968808
AS
3284 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3285 symbol character follows.
3286
9e381cdd
PE
32872011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3288
3289 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3290 This works around a problem with the previous change to Fcopy_file.
3291 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3292 and without this change, GCC might complain about discarding
3293 fchown's return value.
3294
b5641435
JB
32952011-07-16 Juanma Barranquero <lekktu@gmail.com>
3296
3297 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3298
a8031457
PE
32992011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3300
3301 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3302
dd889327
LMI
33032011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3304
750c33f7
LMI
3305 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3306 it's used from the C level.
3307
dd889327
LMI
3308 * process.c: Use the same condition for POLL_FOR_INPUT in both
3309 keyboard.c and process.c (bug#1858).
3310
87e86684
LM
33112011-07-09 Lawrence Mitchell <wence@gmx.li>
3312
3313 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3314 (Fgnutls_boot): Use it.
3315
64348f40
AS
33162011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3317
3318 * doc.c (Fsubstitute_command_keys): Revert last change.
3319
1d698799
LMI
33202011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3321
f863868c
LMI
3322 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3323 quotes the next character, and doesn't affect other longer
3324 sequences (bug#8935).
3325
1d698799
LMI
3326 * lread.c (syms_of_lread): Clarify that is isn't only
3327 `eval-buffer' and `eval-defun' that's affected by
3328 `lexical-binding' (bug#8460).
3329
aa4b6df6
EZ
33302011-07-15 Eli Zaretskii <eliz@gnu.org>
3331
3332 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3333 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3334
5d856da6
PE
33352011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3336
ad6042bb
PE
3337 Fix minor problems found by static checking.
3338 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3339 (elsz): Now a signed constant, not a size_t var. We prefer signed
3340 types to unsigned, to avoid integer comparison confusion. Without
3341 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3342 "cannot optimize loop, the loop counter may overflow", a symptom
3343 of the confusion.
f00bbb22 3344 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3345 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3346
6468f31c
LMI
33472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3348
49080b10
LMI
3349 * search.c (Fre_search_backward): Mention `case-fold-search' in
3350 all the re_search_* functions (bug#8138).
3351
6468f31c
LMI
3352 * keyboard.c (Fopen_dribble_file): Document when the file is
3353 closed (bug#8056).
3354
c965adc5
EZ
33552011-07-14 Eli Zaretskii <eliz@gnu.org>
3356
df9733bf
EZ
3357 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3358 bidi_cache_idx.
3359
0bb23927
EZ
3360 Support bidi reordering of display and overlay strings.
3361 * xdisp.c (compute_display_string_pos)
3362 (compute_display_string_end): Accept additional argument STRING.
3363 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3364 (reseat_to_string): Initialize bidi_it->string.s and
3365 bidi_it->string.schars.
3366 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3367 NULL (avoids a crash in bidi_paragraph_init).
3368 Initialize itb.string.lstring.
0bb23927
EZ
3369 (init_iterator): Call bidi_init_it only of a valid
3370 buffer position was specified. Initialize paragraph_embedding to
3371 L2R.
3372 (reseat_to_string): Initialize the bidi iterator.
3373 (display_string): If we need to ignore text properties of
3374 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3375 original value of -1 will not work with bidi.)
3376 (compute_display_string_pos): First arg is now struct
3377 `text_pos *'; all callers changed. Support display properties on
3378 Lisp strings.
3379 (compute_display_string_end): Support display properties on Lisp
3380 strings.
3381 (init_iterator, reseat_1, reseat_to_string): Initialize the
3382 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3383 when iterating on a string not from display properties).
640c8776
SM
3384 (compute_display_string_pos, compute_display_string_end):
3385 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3386 arrow keys.
3387 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3388 base_level_stop; instead, set base_level_stop to BEGV.
3389 Fixes crashes in vertical-motion.
0bb23927
EZ
3390 (next_element_from_buffer): Improve commentary for when
3391 the iterator is before prev_stop.
3392 (init_iterator): Initialize bidi_p from the default value of
3393 bidi-display-reordering, not from buffer-local value. Use the
3394 buffer-local value only if initializing for buffer iteration.
3395 (handle_invisible_prop): Support invisible properties on strings
3396 that are being bidi-reordered.
3397 (set_iterator_to_next): Support bidi reordering of C strings and
3398 Lisp strings.
3399 (next_element_from_string): Support bidi reordering of Lisp
3400 strings.
3401 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3402 (display_string): Support display of R2L glyph rows.
3403 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3404 (init_iterator): Don't initialize it->bidi_p for strings
3405 here.
3406 (reseat_to_string): Initialize it->bidi_p for strings here.
3407 (next_element_from_string, next_element_from_c_string)
3408 (next_element_from_buffer): Add xassert's for correspondence
3409 between IT's object being iterated and it->bidi_it.string
3410 structure.
3411 (face_before_or_after_it_pos): Support bidi iteration.
3412 (next_element_from_c_string): Handle the case of the first string
3413 character that is not the first one in the visual order.
3414 (get_visually_first_element): New function, refactored from common
3415 parts of next_element_from_buffer, next_element_from_string, and
3416 next_element_from_c_string.
3417 (tool_bar_lines_needed, redisplay_tool_bar)
3418 (display_menu_bar): Force left-to-right direction. Add a FIXME
3419 comment for making that be controlled by a user option.
3420 (push_it, pop_it): Save and restore the state of the
3421 bidi iterator. Save and restore the bidi_p flag.
3422 (pop_it): Iterate out of display property for string iteration as
3423 well.
3424 (iterate_out_of_display_property): Support iteration over strings.
3425 (handle_single_display_spec): Set up it->bidi_it for iteration
3426 over a display string, and call bidi_init_it.
3427 (handle_single_display_spec, next_overlay_string)
3428 (get_overlay_strings_1, push_display_prop): Set up the bidi
3429 iterator for displaying display or overlay strings.
3430 (forward_to_next_line_start): Don't use the shortcut if
3431 bidi-iterating.
3432 (back_to_previous_visible_line_start): If handle_display_prop
3433 pushed the iterator stack, restore the internal state of the bidi
3434 iterator by calling bidi_pop_it same number of times.
3435 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3436 and we are bidi-iterating, don't decrement the iterator position;
3437 instead, set the first_elt flag in the bidi iterator, to produce
3438 the same effect.
3439 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3440 (push_display_prop): xassert that we are iterating a buffer.
3441 (push_it, pop_it): Save and restore paragraph_embedding member.
3442 (handle_single_display_spec, next_overlay_string)
3443 (get_overlay_strings_1, reseat_1, reseat_to_string)
3444 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3445 correctly. Don't assume unibyte strings are not bidi-reordered.
3446 (compute_display_string_pos)
3447 (compute_display_string_end): Fix handling the case of C string.
3448 (push_it, pop_it): Save and restore from_disp_prop_p.
3449 (handle_single_display_spec, push_display_prop): Set the
3450 from_disp_prop_p flag.
3451 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3452 (pop_it): Call iterate_out_of_display_property only if we are
3453 popping after iteration over a string that came from a display
3454 property. Fix a typo in popping stretch info. Add an assertion
3455 for verifying that the iterator position is in sync with the bidi
3456 iterator.
3457 (handle_single_display_spec, get_overlay_strings_1)
3458 (push_display_prop): Fix initialization of paragraph direction for
3459 string when that of the parent object is not yet determined.
3460 (reseat_1): Call bidi_init_it to resync the bidi
3461 iterator with IT's position. (Bug#7616)
3462 (find_row_edges): If ROW->start.pos gives position
3463 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3464 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3465 Reset the from_disp_prop_p flag.
3466 (SAVE_IT, RESTORE_IT): New macros.
3467 (pos_visible_p, face_before_or_after_it_pos)
3468 (back_to_previous_visible_line_start)
3469 (move_it_in_display_line_to, move_it_in_display_line)
3470 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3471 (try_scrolling, redisplay_window, display_line): Use them when
3472 saving a temporary copy of the iterator and restoring it back.
3473 (back_to_previous_visible_line_start, reseat_1)
3474 (init_iterator): Empty the bidi cache "stack".
3475 (move_it_in_display_line_to): If iterator ended up at
3476 EOL, but we never saw any buffer positions smaller than
3477 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3478 motion in bidi-reordered lines.
3479 (move_it_in_display_line_to): Record prev_method and prev_pos
3480 immediately before the call to set_iterator_to_next. Fixes cursor
3481 motion in bidi-reordered lines with stretch glyphs and strings
3482 displayed in margins. (Bug#8133) (Bug#8867)
3483 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3484 TO_CHARPOS.
640c8776
SM
3485 (pos_visible_p): Support positions in bidi-reordered lines.
3486 Save and restore bidi cache.
0bb23927
EZ
3487
3488 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3489 (bidi_paragraph_info): Delete unused struct.
3490 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3491 (bidi_cache_start): New variable.
3492 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3493 to zero.
3494 (bidi_cache_fetch_state, bidi_cache_search)
3495 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3496 (bidi_cache_find, bidi_peek_at_next_level)
3497 (bidi_level_of_next_char, bidi_find_other_level_edge)
3498 (bidi_move_to_visually_next): Compare cache index with
3499 bidi_cache_start rather than with zero.
3500 (bidi_fetch_char): Accept new argument STRING; all callers
3501 changed. Support iteration over a string. Support strings with
3502 display properties. Support unibyte strings. Fix the type of
3503 `len' according to what STRING_CHAR_AND_LENGTH expects.
3504 (bidi_paragraph_init, bidi_resolve_explicit_1)
3505 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3506 (bidi_level_of_next_char, bidi_move_to_visually_next):
3507 Support iteration over a string.
0bb23927
EZ
3508 (bidi_set_sor_type, bidi_resolve_explicit_1)
3509 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3510 can now be zero (for strings); special values 0 and -1 were
3511 changed to -1 and -2, respectively.
3512 (bidi_char_at_pos): New function.
3513 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3514 Call it instead of FETCH_MULTIBYTE_CHAR.
3515 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3516 initialized to valid values.
3517 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3518 values.
3519 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3520 the test for valid cached positions. Fix the logic for looking up
3521 the sentinel state in the cache. GCPRO the Lisp string we are
3522 iterating.
3523 (bidi_push_it, bidi_pop_it): New functions.
3524 (bidi_initialize): Initialize the bidi cache start stack pointer.
3525 (bidi_cache_ensure_space): New function, refactored from part of
3526 bidi_cache_iterator_state. Don't assume the required size is just
3527 one BIDI_CACHE_CHUNK away.
3528 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3529 (bidi_count_bytes, bidi_char_at_pos): New functions.
3530 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3531 always valid if bidi_cache_idx is valid.
3532 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3533 is valid if it's going to be used.
3534 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3535 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3536 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3537 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3538 (bidi_find_other_level_edge, bidi_cache_start_stack):
3539 All variables related to cache indices are now EMACS_INT.
c965adc5 3540
0bb23927
EZ
3541 * dispextern.h (struct bidi_string_data): New structure.
3542 (struct bidi_it): New member `string'. Make flag members be 1-bit
3543 fields, and put them last in the struct.
640c8776
SM
3544 (compute_display_string_pos, compute_display_string_end):
3545 Update prototypes.
0bb23927
EZ
3546 (bidi_push_it, bidi_pop_it): Add prototypes.
3547 (struct iterator_stack_entry): New members bidi_p,
3548 paragraph_embedding, and from_disp_prop_p.
3549 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3550 (bidi_shelve_cache, bidi_unshelve_cache):
3551 Declare prototypes.
0bb23927
EZ
3552
3553 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3554 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3555 and vector-like objects.
3556
3557 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3558 cache around display iteration.
3559
3560 * window.c (Fwindow_end, window_scroll_pixel_based)
3561 (displayed_window_lines, Frecenter): Save and restore the bidi
3562 cache around display iteration.
3563
3bbd2265
LMI
35642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3565
3566 * editfns.c (Fdelete_region): Clarify the use of the named
3567 parameters (bug#6788).
3568
adc47434
MR
35692011-07-14 Martin Rudalics <rudalics@gmx.at>
3570
3571 * indent.c (Fvertical_motion): Set and restore w->pointm when
3572 saving and restoring the window's buffer (Bug#9006).
3573
837c31f8
LMI
35742011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3575
3576 * editfns.c (Fstring_to_char): Clarify just what is returned
3577 (bug#6576). Text by Eli Zaretskii.
3578
ac389d0c
JB
35792011-07-13 Juanma Barranquero <lekktu@gmail.com>
3580
3581 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3582
0be0ce47
EZ
35832011-07-13 Eli Zaretskii <eliz@gnu.org>
3584
3585 * buffer.c (mmap_find): Fix a typo.
3586
cd18e7e3
JB
35872011-07-13 Johan Bockgård <bojohan@gnu.org>
3588
3589 Fix execution of x selection hooks.
3590 * xselect.c (Qx_lost_selection_functions)
3591 (Qx_sent_selection_functions): New vars.
3592 (syms_of_xselect): DEFSYM them.
3593 (x_handle_selection_request): Pass Qx_sent_selection_functions
3594 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3595 (x_handle_selection_clear,x_clear_frame_selections):
3596 Pass Qx_lost_selection_functions rather than
3597 Vx_lost_selection_functions to Frun_hook_with_args.
3598
47ea7f44
PE
35992011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3600
ac389d0c 3601 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3602 The old code sometimes used this field without initializing it.
3603
47ea7f44
PE
3604 * alloc.c (gc_sweep): Don't read past end of array.
3605 In theory, the old code could also have corrupted Emacs internals,
3606 though it'd be very unlikely.
3607
bc985c87
AS
36082011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3609
3610 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3611 argument. (Bug#4026)
bc985c87 3612
0cf34688
LMI
36132011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3614
b3dadd76
LMI
3615 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3616 key" (bug#4257).
3617
0cf34688
LMI
3618 * window.c (Fset_window_start): Doc fix (bug#4199).
3619 (Fset_window_hscroll): Ditto.
3620
270768cd
PE
36212011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3622
077e3dda 3623 Fix minor new problems caught by GCC 4.6.1.
270768cd 3624 * term.c (init_tty): Remove unused local.
490011a6 3625 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3626 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3627 not used otherwise.
270768cd 3628
b1f58454
CY
36292011-07-12 Chong Yidong <cyd@stupidchicken.com>
3630
3631 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3632
22b9578d
LMI
36332011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3634
6e70ab07
LMI
3635 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3636 are the mini-buffer and the echo area (bug#3320).
3637
22b9578d
LMI
3638 * term.c (init_tty): Remove support for supdup, c10 and perq
3639 terminals, which are no longer supported (bug#1482).
3640
8974cc9f
JB
36412011-07-10 Johan Bockgård <bojohan@gnu.org>
3642
3643 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3644
a560d974
JD
36452011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3646
3647 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3648 for non-popups (Bug#3642).
3649
1dae0f0a
AS
36502011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3651
268c2c36 3652 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3653 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3654 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3655 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3656 * data.c (fmod): Likewise.
3657 * dispnew.c (swap_glyphs_in_rows): Likewise.
3658 * emacs.c (memory_warning_signal): Likewise.
3659 * floatfns.c (float_error): Likewise.
3660 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3661 (otf_open, font_otf_capability, generate_otf_features)
3662 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3663 Likewise.
3664 * image.c (pbm_read_file): Likewise.
3665 * indent.c (string_display_width): Likewise.
3666 * intervals.c (check_for_interval, search_for_interval)
3667 (inc_interval_count, count_intervals, root_interval)
3668 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3669 * lread.c (defalias): Likewise.
268c2c36 3670 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3671 * regex.c (set_image_of_range_1, set_image_of_range)
3672 (regex_grow_registers): Likewise.
3673 * sysdep.c (strerror): Likewise.
3674 * termcap.c (valid_filename_p, tprint, main): Likewise.
3675 * tparam.c (main): Likewise.
3676 * unexhp9k800.c (run_time_remap, save_data_space)
3677 (update_file_ptrs, read_header, write_header, calculate_checksum)
3678 (copy_file, copy_rest, display_header): Likewise.
3679 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3680 Likewise.
3681 * xdisp.c (check_it): Likewise.
3682 * xfaces.c (register_color, unregister_color, unregister_colors):
3683 Likewise.
3684 * xfns.c (print_fontset_result): Likewise.
3685 * xrdb.c (member, fatal, main): Likewise.
3686
99033785
PE
36872011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3688
3689 Fix minor problems found by static checking (Bug#9031).
3690 * chartab.c (char_table_set_range, map_sub_char_table):
3691 Remove unused locals.
3692 (uniprop_table): Now static.
3693 * composite.c (_work_char): Remove unused static var.
3694
9cb2ac56
JB
36952011-07-09 Juanma Barranquero <lekktu@gmail.com>
3696
3697 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3698
f25661f0
JD
36992011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3700
3701 * gtkutil.c (qttip_cb): Remove code without function.
3702
8278c4fe
EZ
37032011-07-09 Eli Zaretskii <eliz@gnu.org>
3704
3705 * w32.c (pthread_sigmask): New stub.
3706
1692ae2d 37072011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3708
8a6ebd58 3709 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3710 sigprocmask is portable only for single-threaded applications, and
3711 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3712 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3713 (LIBES): Use it.
3714 * callproc.c (Fcall_process):
3715 * process.c (create_process):
3716 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3717 Use pthread_sigmask, not sigprocmask.
123403e4 3718
1b854618
JD
37192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3720
3721 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3722 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3723 wrong (Bug#8591).
3724
3fe4b549
JD
37252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3726
0ce7e563
JD
3727 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3728 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3729 (xg_hide_tooltip): Fix comment.
3730
3fe4b549
JD
3731 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3732 in registerServicesMenuSendTypes.
3733 (validRequestorForSendType): Don't check ns_return_types.
3734
3735 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3736 ns_return_type.
3737
5df75e47
JR
37382011-07-08 Jason Rumney <jasonr@gnu.org>
3739
22610910
JR
3740 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3741 SH_SHOW for hidden windows (Bug#5482).
3742
5df75e47
JR
3743 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3744 frame struct members of non-existent frames (Bug#6284).
3745
699c10bd
JD
37462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3747
4393663b
JD
3748 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3749 variable firstTime not needed on OSX >= 10.6.
3750 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3751 >= 10.5. Use setKnobProportion, setDoubleValue.
3752
3753 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3754 (MAC_OS_X_VERSION_10_5): Define if not defined.
3755 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3756 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3757 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3758
3759 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3760 cString and lossyCString on OSX >= 10.4
3761
58179cce 3762 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3763 sizeToFit on OSX >= 10.2.
3764
3765 * nsimage.m (allocInitFromFile): Don't use deprecated method
3766 bestRepresentationForDevice on OSX >= 10.6.
3767
3768 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3769 to avoid warning.
3770
3771 * emacs.c: Declare unexec_init_emacs_zone.
3772
a63e0781
JD
3773 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3774
699c10bd
JD
3775 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3776
3777 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3778 on svcsMenu (Bug#8842).
3779
3780 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3781 ns_return_types.
3782 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3783
3784 * nsterm.m (QUTF8_STRING): Declare.
3785 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3786 (validRequestorForSendType): Return type is (id).
3787 Change indexOfObjectIdenticalTo to indexOfObject.
3788 Check if we have local selection before returning self (Bug#8842).
3789 (writeSelectionToPasteboard): Put local selection into paste board
3790 if we have a local selection (Bug#8842).
3791 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3792
3793 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3794 (ns_get_local_selection): Declare.
3795
54e10184
LMI
37962011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3797
9888ff71
LMI
3798 * keymap.c (describe_map_tree): Don't insert a double newline at
3799 the end of the buffer (bug#1169) and return whether we inserted
3800 something.
3801
54e10184
LMI
3802 * callint.c (Fcall_interactively): Change "reading args" to
3803 "providing args" to try to clarify what it does (bug#1010).
3804
15fa4783
KH
38052011-07-07 Kenichi Handa <handa@m17n.org>
3806
3807 * composite.c (composition_compute_stop_pos): Ignore a static
3808 composition starting before CHARPOS (Bug#8915).
3809
3810 * xdisp.c (handle_composition_prop): Likewise.
3811
a8815b00
EZ
38122011-07-07 Eli Zaretskii <eliz@gnu.org>
3813
3814 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3815 (Bug#9015)
3816
ef7b981d 38172011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3818
3819 * character.h (unicode_category_t): New enum type.
3820
3821 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3822 (Qchar_code_property_table): New variable.
3823 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3824 (UNIPROP_COMPRESSED_FORM_P): New macros.
3825 (char_table_ascii): Uncompress the compressed values.
3826 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3827 Uncompress the compressed values.
ac389d0c 3828 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3829 (char_table_ref_and_range): Uncompress the compressed values.
3830 (sub_char_table_set): New arg is_uniprop. Callers changed.
3831 Uncompress the compressed values.
3832 (sub_char_table_set_range): Args changed. Callers changed.
3833 (char_table_set_range): Adjuted for the above change.
3834 (map_sub_char_table): Delete args default_val and parent. Add arg
3835 top. Give decoded values to a Lisp function.
640c8776 3836 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3837 values to a Lisp function. Gcpro more variables.
3838 (uniprop_table_uncompress)
3839 (uniprop_decode_value_run_length): New functions.
3840 (uniprop_decoder, uniprop_decoder_count): New variables.
3841 (uniprop_get_decoder, uniprop_encode_value_character)
3842 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3843 New functions.
3844 (uniprop_encoder, uniprop_encoder_count): New variables.
3845 (uniprop_get_encoder, uniprop_table)
3846 (Funicode_property_table_internal, Fget_unicode_property_internal)
3847 (Fput_unicode_property_internal): New functions.
3848 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3849 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3850 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3851 char-code-property-alist.
3852
640c8776 3853 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3854 Vunicode_category_table.
3855
640c8776 3856 * font.c (font_range): Adjust for the change of
c805dec0
KH
3857 Vunicode_category_table.
3858
76b397fb
DN
38592011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3860
3861 * m/iris4d.h: Remove file, move contents ...
3862 * s/irix6-5.h: ... here.
3863
22b4128e
PE
38642011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3865
3866 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3867 * alloc.c (mark_buffer):
3868 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3869 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3870 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3871 This isn't true in general, and it's particularly not true
3872 if Emacs is configured with --with-wide-int.
3873 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3874 New macros, used in the buffer.c change.
3875
869795d6
JD
38762011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3877
3878 * xsettings.c: Use both GConf and GSettings if both are available.
3879 (store_config_changed_event): Add comment.
3880 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3881 (store_tool_bar_style_changed): New functions.
5e617bc2 3882 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3883 (struct xsettings): Move font inside HAVE_XFT.
3884 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3885 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3886 Move inside HAVE_XFT.
640c8776 3887 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3888 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3889 also.
3890 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3891 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3892 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3893 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3894 (parse_settings): Move check for font inside HAVE_XFT.
3895 (read_settings, apply_xft_settings): Add comment.
3896 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3897 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3898 call store_font_name_changed.
3899 (xft_settings_event): Add comment.
3900 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3901 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3902 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3903 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3904 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3905 (xsettings_get_system_font, xsettings_get_system_normal_font):
3906 Add comment.
869795d6 3907
d8ed26bd
PE
39082011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3909
3910 Random fixes. E.g., (random) never returned negative values.
3911 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3912 subseconds part to the entropy, as that's a bit more random.
3913 Prefer signed to unsigned, since the signedness doesn't matter and
3914 in general we prefer signed. When given a limit, use a
3915 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3916 latter isn't right if USE_2_TAGS_FOR_INTS.
3917 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3918 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3919
cabf1cac
SM
39202011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3921
3922 * textprop.c (text_property_stickiness):
3923 Obey Vtext_property_default_nonsticky.
3924 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3925 * w32fns.c (syms_of_w32fns):
3926 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3927
6e9b2be9
PE
39282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3929
3930 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3931 This is more efficient than Ffile_directory_p and avoids a minor race.
3932
90186c68
LMI
39332011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3934
7c301272
LMI
3935 * buffer.c (Foverlay_put): Say what the return value is
3936 (bug#7835).
3937
c4f2d8d4
LMI
3938 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3939 is a directory before asking whether to use the file name
3940 (bug#7564).
ad637907
LMI
3941 (barf_or_query_if_file_exists): Make the "File is a directory"
3942 error be more correct.
c4f2d8d4 3943
90186c68
LMI
3944 * fns.c (Frequire): Remove the mention of the .gz files, since
3945 that's installation-specific, but keep the mention of
3946 `get-load-suffixes'.
3947
da64016e
PE
39482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3949
3950 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3951 Report string overflow if the output is too long.
3952
7d47b580
JB
39532011-07-04 Juanma Barranquero <lekktu@gmail.com>
3954
a555cb87
JB
3955 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3956 (syms_of_gnutls): Remove duplicate DEFSYM for
3957 Qgnutls_bootprop_verify_hostname_error, an error for
3958 Qgnutls_bootprop_verify_error (which is no longer used).
3959
7d47b580
JB
3960 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3961 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3962 Also (re)move comments that are misplaced or no longer relevant.
3963
1e49bfab
LMI
39642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3965
3966 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3967
1485f4c0
CY
39682011-07-03 Chong Yidong <cyd@stupidchicken.com>
3969
3970 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3971 and background color parameters if they have been changed.
3972
a9ab721e
LMI
39732011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3974
3975 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3976
cf7cff57
PE
39772011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3978
2e13213d
PE
3979 * xsettings.c (SYSTEM_FONT): Define only when used.
3980 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3981
cf7cff57
PE
3982 * keymap.c (access_keymap_1): Now static.
3983
7a8e04f7
CY
39842011-07-02 Chong Yidong <cyd@stupidchicken.com>
3985
3986 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3987 leave any prefix arg for the up event (Bug#1586).
3988
61352f62
LMI
39892011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3990
69bb1ef7
LMI
3991 * lread.c (syms_of_lread): Mention single symbols defined by
3992 `defvar' or `defconst' (bug#7154).
3993
61352f62 3994 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3995 (Frequire): Mention get-load-suffixes.
61352f62 3996
28545e04
MR
39972011-07-02 Martin Rudalics <rudalics@gmx.at>
3998
3999 * window.h (window): Remove clone_number slot.
4000 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4001 Remove.
4002 (make_parent_window, make_window, saved_window)
4003 (Fset_window_configuration, save_window_save): Don't deal with
4004 clone numbers.
4005 * buffer.c (Qclone_number): Remove declaration.
4006 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4007
3349e122
SM
40082011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4009
4010 Add multiple inheritance to keymaps.
4011 * keymap.c (Fmake_composed_keymap): New function.
4012 (Fset_keymap_parent): Simplify.
4013 (fix_submap_inheritance): Remove.
4014 (access_keymap_1): New function extracted from access_keymap to handle
4015 embedded parents and handle lists of maps.
4016 (access_keymap): Use it.
4017 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4018 (Fcopy_keymap): Handle embedded parents.
4019 (Fcommand_remapping, define_as_prefix): Simplify.
4020 (Fkey_binding): Simplify.
4021 (syms_of_keymap): Move minibuffer-local-completion-map,
4022 minibuffer-local-filename-completion-map,
4023 minibuffer-local-must-match-map, and
4024 minibuffer-local-filename-must-match-map to Elisp.
4025 (syms_of_keymap): Defsubr make-composed-keymap.
4026 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4027 (parse_menu_item): Trivial simplification.
4028
3279eb87
GM
40292011-07-01 Glenn Morris <rgm@gnu.org>
4030
4031 * Makefile.in (SETTINGS_LIBS): Fix typo.
4032
4550efdf
KI
40332011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4034
4035 * coding.c (Fencode_coding_string): Record the last coding system
4036 used, as the function doc string says (bug#8738).
4037
0949d2b6
JD
40382011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4039
4040 * xsettings.c (store_monospaced_changed): Take new font as arg and
4041 check for change against current_mono_font.
4042 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4043 (emacs_settings_constructor, emacs_settings_get_property)
4044 (emacs_settings_set_property, emacs_settings_class_init)
4045 (emacs_settings_init, gsettings_obj): Remove.
4046 (something_changedCB): New function for HAVE_GSETTINGS.
4047 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4048 with value as argument.
4049 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4050 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4051 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4052 "changed".
4053
4054 * xgselect.c: Add defined (HAVE_GSETTINGS).
4055 (xgselect_initialize): Ditto.
4056
4057 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4058 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4059 xg_select.
4060
bbc6b304
PE
40612011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4062
4063 * eval.c (struct backtrace): Simplify and port the data structure.
4064 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4065 signed bit field, as this assumption is not portable and it makes
4066 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4067 "char debug_on_exit : 1" as this is not portable either; instead,
4068 use the portable "unsigned int debug_on_exit : 1". Remove unused
4069 member evalargs. Remove obsolete comments about cc bombing out.
4070
9851bfc5
JD
40712011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4072
51bb811f 4073 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4074 Let HAVE_GSETTINGS override HAVE_GCONF.
4075 (store_monospaced_changed): New function.
4076 (EMACS_SETTINGS): A new type derived from GObject to handle
4077 GSettings notifications.
4078 (emacs_settings_constructor, emacs_settings_get_property)
4079 (emacs_settings_set_property, emacs_settings_class_init):
4080 New functions.
4081 (gsettings_client, gsettings_obj): New variables.
4082 (GSETTINGS_SCHEMA): New define.
4083 (something_changedCB): Call store_monospaced_changed.
4084 (init_gsettings): New function.
4085 (xsettings_initialize): Call init_gsettings.
4086 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4087 to NULL.
4088
640c8776 4089 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4090 GCONF_CFLAGS/LIBS.
4091
5386012d
MR
40922011-06-29 Martin Rudalics <rudalics@gmx.at>
4093
4094 * window.c (resize_root_window, grow_mini_window)
4095 (shrink_mini_window): Rename Qresize_root_window to
4096 Qwindow_resize_root_window and Qresize_root_window_vertically to
4097 Qwindow_resize_root_window_vertically.
4098
f13e0b08
PE
40992011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4100
4101 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4102
94515237
JB
41032011-06-27 Juanma Barranquero <lekktu@gmail.com>
4104
4105 * makefile.w32-in: Redesign dependencies so they reflect more
4106 clearly which files are directly included by each source file,
4107 and not through other includes.
4108
e43b6e43
MR
41092011-06-27 Martin Rudalics <rudalics@gmx.at>
4110
4111 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4112 (sort_overlays, overlay_strings): When an overlay's clone number
4113 matches the window's clone number process the overlay even if
4114 the overlay's window property doesn't match the current window.
4115
d68443dc
MR
4116 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4117 (Fwindow_hchild): Rename to Fwindow_left_child.
4118 (Fwindow_next): Rename to Fwindow_next_sibling.
4119 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4120 (resize_window_check): Rename to window_resize_check.
4121 (resize_window_apply): Rename to window_resize_apply.
4122 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4123 (Fdelete_other_windows_internal, resize_frame_windows)
4124 (Fsplit_window_internal, Fdelete_window_internal)
4125 (grow_mini_window, shrink_mini_window)
4126 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4127
c7e73be5
JD
41282011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4129
4130 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4131 (emacs_fixed_set_min_size): Remove.
4132 (emacs_fixed_new): Take frame as argument.
4133
4134 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4135 (_EmacsFixedPrivate): Remove minwidth/height.
4136 Add struct frame *f.
4137 (emacs_fixed_init): Initialize priv->f.
4138 (get_parent_class, emacs_fixed_set_min_size): Remove.
4139 (emacs_fixed_new): Set priv->f to argument.
4140 (emacs_fixed_get_preferred_width)
4141 (emacs_fixed_get_preferred_height): Use min_width/height from
4142 frames size_hint to set minimum and natural (Bug#8919).
4143 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4144 and use min_width/height from frames size_hint to set
4145 min_width/height (Bug#8919).
4146
4147 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4148 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4149 Fix indentation.
c7e73be5 4150
cf99dcf8
EZ
41512011-06-26 Eli Zaretskii <eliz@gnu.org>
4152
4153 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4154 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4155 called at ZV.
4156
029529ac
CY
41572011-06-26 Chong Yidong <cyd@stupidchicken.com>
4158
4159 * process.c (wait_reading_process_output): Bypass select if
4160 waiting for a cell while ignoring keyboard input, and input is
4161 pending. Suggested by Jan Djärv (Bug#8869).
4162
7a7ef429
PE
41632011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4164
4165 Use gnulib's dup2 module instead of rolling our own.
4166 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4167
11fdef7d 41682011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4169
4170 * dispnew.c (scrolling_window): Before scrolling, turn off a
4171 mouse-highlight in the window being scrolled.
4172
cd3520a4
JB
41732011-06-24 Juanma Barranquero <lekktu@gmail.com>
4174
4175 Move DEFSYM to lisp.h and use everywhere.
4176
4177 * character.h (DEFSYM): Move declaration...
4178 * lisp.h (DEFSYM): ...here.
4179
4180 * gnutls.c:
4181 * minibuf.c:
4182 * w32menu.c:
4183 * w32proc.c:
4184 * w32select.c: Don't include character.h.
4185
4186 * alloc.c (syms_of_alloc):
4187 * buffer.c (syms_of_buffer):
4188 * bytecode.c (syms_of_bytecode):
4189 * callint.c (syms_of_callint):
4190 * casefiddle.c (syms_of_casefiddle):
4191 * casetab.c (init_casetab_once):
4192 * category.c (init_category_once, syms_of_category):
4193 * ccl.c (syms_of_ccl):
4194 * cmds.c (syms_of_cmds):
4195 * composite.c (syms_of_composite):
4196 * dbusbind.c (syms_of_dbusbind):
4197 * dired.c (syms_of_dired):
4198 * dispnew.c (syms_of_display):
4199 * doc.c (syms_of_doc):
4200 * editfns.c (syms_of_editfns):
4201 * emacs.c (syms_of_emacs):
4202 * eval.c (syms_of_eval):
4203 * fileio.c (syms_of_fileio):
4204 * fns.c (syms_of_fns):
4205 * frame.c (syms_of_frame):
4206 * fringe.c (syms_of_fringe):
4207 * insdel.c (syms_of_insdel):
4208 * keymap.c (syms_of_keymap):
4209 * lread.c (init_obarray, syms_of_lread):
4210 * macros.c (syms_of_macros):
4211 * msdos.c (syms_of_msdos):
4212 * print.c (syms_of_print):
4213 * process.c (syms_of_process):
4214 * search.c (syms_of_search):
4215 * sound.c (syms_of_sound):
4216 * syntax.c (init_syntax_once, syms_of_syntax):
4217 * terminal.c (syms_of_terminal):
4218 * textprop.c (syms_of_textprop):
4219 * undo.c (syms_of_undo):
4220 * w32.c (globals_of_w32):
4221 * window.c (syms_of_window):
4222 * xdisp.c (syms_of_xdisp):
4223 * xfaces.c (syms_of_xfaces):
4224 * xfns.c (syms_of_xfns):
4225 * xmenu.c (syms_of_xmenu):
4226 * xsettings.c (syms_of_xsettings):
4227 * xterm.c (syms_of_xterm): Use DEFSYM.
4228
4228cf16
TZ
42292011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4230
cd3520a4 4231 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4232
7fcccf1e
PE
42332011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4234
7efb4e0e
PE
4235 Integer and buffer overflow fixes (Bug#8873).
4236
ff5844ad
PE
4237 * print.c (printchar, strout): Check for string overflow.
4238 (PRINTPREPARE, printchar, strout):
4239 Don't set size unless allocation succeeds.
4240
90532f02
PE
4241 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4242 for sizes. Check for string overflow more accurately.
4243 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4244
6d84508d
PE
4245 * macros.c: Integer and buffer overflow fixes.
4246 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4247 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4248 Use ptrdiff_t, not int, for sizes.
4249 Don't increment bufsize until after realloc succeeds.
4250 Check for size-calculation overflow.
4251 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4252
437b2cb4
PE
4253 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4254
8b9ac8b4
PE
4255 * lread.c: Integer overflow fixes.
4256 (read_integer): Radix is now EMACS_INT, not int,
4257 to improve quality of diagnostics for out-of-range radices.
4258 Calculate buffer size correctly for out-of-range radices.
4259 (read1): Check for integer overflow in radices, and in
4260 read-circle numbers.
82cb60d3
PE
4261 (read_escape): Avoid int overflow.
4262 (Fload, openp, read_buffer_size, read1)
4263 (substitute_object_recurse, read_vector, read_list, map_obarray):
4264 Use ptrdiff_t, not int, for sizes.
4265 (read1): Use EMACS_INT, not int, for sizes.
20270765 4266 Check for size overflow.
8b9ac8b4 4267
7fcccf1e
PE
4268 * image.c (cache_image): Check for size arithmetic overflow.
4269
bfbbd7e7
PE
4270 * lread.c: Integer overflow issues.
4271 (saved_doc_string_size, saved_doc_string_length)
4272 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4273 Now ptrdiff_t, not int.
4274 (read1): Don't assume doc string length fits in int. Check for
4275 out-of-range doc string lengths.
4276 (read_list): Don't assume file position fits in int.
39019e54 4277 (read_escape): Check for hex character overflow.
bfbbd7e7 4278
4e323265
LL
42792011-06-22 Leo Liu <sdl.web@gmail.com>
4280
4281 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4282 Move to minibuffer.el.
4283
85fece3e
PE
42842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4285
20b84ce9 4286 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4287 The following patches are for when GLYPH_DEBUG && !XASSERT.
4288 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4289 * dispnew.c (flush_stdout):
4290 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4291 Mark as externally visible.
4292 * dispnew.c (check_window_matrix_pointers): Now static.
4293 * dispnew.c (window_to_frame_vpos):
4294 * xfns.c (unwind_create_frame):
4295 * xterm.c (x_check_font): Remove unused local.
4296 * scroll.c (CHECK_BOUNDS):
4297 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4298 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4299 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4300 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4301 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4302 Now static.
4303 (debug_method_add): Use va_list and vsprintf rather than relying
4304 on undefined behavior with wrong number of arguments.
4305 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4306 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4307 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4308 since we're not interested in debugging glyphs with old libraries.
4309 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4310 GCC 4.6.0's static checking.
4311
0766b489
PE
43122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4313
31fd4b32
PE
4314 Integer overflow and signedness fixes (Bug#8873).
4315 A few related buffer overrun fixes, too.
4316
b79e8648
PE
4317 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4318
0766b489
PE
4319 * dispextern.h (struct face.stipple):
4320 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4321 (x_bitmap_mask, x_allocate_bitmap_record)
4322 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4323 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4324 (x_create_bitmap_from_xpm_data):
4325 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4326 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4327 (.bitmaps_last):
4328 * xfaces.c (load_pixmap):
4329 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4330 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4331 (.bitmaps_last, struct x_output.icon_bitmap):
4332 Use ptrdiff_t, not int, for bitmap indexes.
4333 (x_allocate_bitmap_record): Check for size overflow.
4334 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4335
b081724f
PE
4336 Use ptrdiff_t, not int, for overlay counts.
4337 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4338 * editfns.c (overlays_around, get_pos_property):
4339 * textprop.c (get_char_property_and_overlay):
4340 * xdisp.c (next_overlay_change, note_mouse_highlight):
4341 * xfaces.c (face_at_buffer_position):
21514da7
PE
4342 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4343 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4344 (Fnext_overlay_change, Fprevious_overlay_change)
4345 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4346 Use ptrdiff_t, not int, for sizes.
21514da7 4347 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4348
3de73e5e
PE
4349 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4350
2606c57b
PE
4351 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4352 (x_session_initialize): Do not assume string length fits in int.
4353
aaafe47a
PE
4354 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4355 This is unlikely, but can occur if DPI is outlandish.
4356
2674ddc8 4357 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4358 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4359
28154962
PE
4360 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4361 * xrdb.c (magic_file_p, search_magic_path):
4362 Omit last arg SUFFIX; it was always 0. All callers changed.
4363 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4364
7de51af5
PE
4365 * xfont.c (xfont_match): Avoid need for strlen.
4366
25ed6cc3
PE
4367 * xfns.c: Don't assume strlen fits in int.
4368 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4369
4eab31dd
PE
4370 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4371 not unsigned long, as we prefer signed integers. All callers changed.
4372 Detect integer overflow in repeat count.
4373 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4374 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4375
171e2a58
PE
4376 * termcap.c: Don't assume sizes fit in int and never overflow.
4377 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4378 (gobble_line): Check for size-calculation overflow.
4379
ad39faca 4380 * minibuf.c (Fread_buffer):
6e5bb2dc 4381 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4382 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4383 Don't assume string length fits in int.
4384
52c61c22 4385 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4386 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4387
b5b8c9e5
PE
4388 * font.c: Don't assume string length fits in int.
4389 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4390 Use ptrdiff_t, not int.
ccd6111c
PE
4391 (font_intern_prop): Don't assume string length fits in int.
4392 Don't assume integer property fits in fixnum.
4393 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4394
882f0d81 4395 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4396 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4397 Reformulate so as not to need the command string.
4398 Invoke gzip -cd rather than gunzip, as it's more portable.
4399 (lock_info_type, lock_file_1, lock_file):
4400 Don't assume pid_t and time_t fit in unsigned long.
4401 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4402 (current_lock_owner): Prefer signed type for sizes.
4403 Use memcpy, not strncpy, where memcpy is what is really wanted.
4404 Don't assume (via atoi) that time_t and pid_t fit in int.
4405 Check for time_t and/or pid_t out of range, e.g., via a network share.
4406 Don't alloca where an auto var works fine.
4407
93f4cf88
PE
4408 * fileio.c: Fix some integer overflow issues.
4409 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4410 Don't assume string length fits in int.
4411 (directory_file_name): Don't assume string length fits in long.
4412 (make_temp_name): Don't assume pid fits in int, or that its print
4413 length is less than 20.
4414
f3e92b69
PE
4415 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4416
1bfdaf10
PE
4417 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4418
35016e9a
PE
4419 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4420
3d1e65a1
PE
4421 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4422 We prefer signed integers, even for size calculations.
4423
0b963a93
PE
4424 * emacs.c: Don't assume string length fits in 'int'.
4425 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4426 (main): Don't invoke strlen when not needed.
4427
573f4b54
PE
4428 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4429 (XD_DEBUG_MESSAGE): Don't waste a byte.
4430
989f33ba
PE
4431 * callproc.c (getenv_internal_1, getenv_internal)
4432 (Fgetenv_internal):
965d34eb
PE
4433 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4434
e4d29b33
PE
4435 * lread.c (invalid_syntax): Omit length argument.
4436 All uses changed. This doesn't fix a bug, but it simplifies the
4437 code away from its former Hollerith-constant appearance, and it's
4438 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4439 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4440
eb49b136
PE
4441 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4442 This didn't break anything, but it didn't help either.
4443 It's confusing to put a bogus integer in a place where the actual
4444 value does not matter.
9f62aeb1 4445 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4446 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4447
15375a22
PE
4448 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4449 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4450 implementation.
b61cc01c
PE
4451 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4452 We prefer signed types, and the value cannot exceed the EMACS_INT
4453 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4454 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4455 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4456 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4457
53b2623d
PE
4458 * indent.c (sane_tab_width): New function.
4459 (current_column, scan_for_column, Findent_to, position_indentation)
4460 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4461 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4462
51cab52b 4463 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4464
f2ed8a70
PE
4465 * lisp.h (lint_assume): New macro.
4466 * composite.c (composition_gstring_put_cache):
4467 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4468
abe80cc6
PE
4469 * editfns.c, insdel.c:
4470 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4471
b02c740e
PE
4472 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4473
ebc96716
PE
4474 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4475
b4e50fa0 4476 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4477 Use much-faster test for byte-length change.
311d5d7c 4478 Don't assume string byte-length fits in 'int'.
a4cf38e4 4479 Check that character arg fits in 'int'.
85461888 4480 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4481
c0c1ee9f
PE
4482 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4483
a498d7f4
PE
4484 * fns.c (concat): Catch string overflow earlier.
4485 Do not rely on integer wraparound.
4486
51cab52b
PE
4487 * dispextern.h (struct it.overlay_strings_charpos)
4488 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4489 * xdisp.c (forward_to_next_line_start)
4490 (back_to_previous_visible_line_start)
4491 (reseat_at_next_visible_line_start, next_element_from_buffer):
4492 Don't arbitrarily truncate the value of 'selective' to int.
4493
76031fad
PE
4494 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4495
5eb55db9
PE
4496 * composite.c: Don't truncate sizes to 'int'.
4497 (composition_gstring_p, composition_reseat_it)
4498 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4499 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4500 not EMACS_UINT, for indexes.
5eb55db9 4501
0703a717
PE
4502 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4503
d6202519
PE
4504 * buffer.c: Include <verify.h>.
4505 (struct sortvec.priority, struct sortstr.priority):
8961a454 4506 Now EMACS_INT, not int.
c20998a7 4507 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4508 (struct sortstr.size, record_overlay_string)
4509 (struct sortstrlist.size, struct sortlist.used):
4510 Don't truncate size to int.
4511 (record_overlay_string): Check for size-calculation overflow.
d6202519 4512 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4513
d5a19415
JM
45142011-06-22 Jim Meyering <meyering@redhat.com>
4515
029529ac 4516 Don't leak an XBM-image-sized buffer
d5a19415
JM
4517 * image.c (xbm_load): Free the image buffer after using it.
4518
a9041e6c
PE
45192011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4520
4521 Port to Sun C.
4522 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4523 that Sun C diagnosed.
4524 * fns.c (secure_hash): Fix pointer signedness issue.
4525 * intervals.c (static_offset_intervals): New function.
4526 (offset_intervals): Use it.
4527
7f3f739f
LL
45282011-06-21 Leo Liu <sdl.web@gmail.com>
4529
4530 * deps.mk (fns.o):
4531 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4532 sha512.h.
4533
4534 * fns.c (secure_hash): Rename from crypto_hash_function and change
4535 the first arg to accept symbols.
5b66d427 4536 (Fsecure_hash): New primitive.
7f3f739f
LL
4537 (syms_of_fns): New symbols.
4538
76147d94
DD
45392011-06-20 Deniz Dogan <deniz@dogan.se>
4540
4541 * process.c (Fset_process_buffer): Clarify return value in
4542 docstring.
4543
7d7d0045
CY
45442011-06-18 Chong Yidong <cyd@stupidchicken.com>
4545
4546 * dispnew.c (add_window_display_history): Use BVAR.
4547
4548 * xdisp.c (debug_method_add): Use BVAR.
4549 (check_window_end, dump_glyph_matrix, dump_glyph)
4550 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4551
4552 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4553 Likewise.
4554
4555 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4556 check till after the cache is created in init_frame_faces.
4557
ff2bc410
SM
45582011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4559
4560 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4561
28177add
PE
45622011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4563
dd3482fe
PE
4564 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4565 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4566 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4567
393d71f3 4568 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4569 * fileio.c (Finsert_file_contents):
4570 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4571 Remove the old (too-loose) buffer overflow checks.
4572 They weren't needed, since make_gap checks for buffer overflow.
4573 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4574 The old code merely checked for Emacs fixnum overflow, and relied
4575 on undefined (wraparound) behavior. The new code avoids undefined
4576 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4577
2e6813b0 4578 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4579 Tune. Don't use wider integers than needed. Don't use alloca.
4580 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4581
599a9e4f
PE
4582 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4583
99561444
PE
4584 * insdel.c, lisp.h (buffer_overflow): New function.
4585 (insert_from_buffer_1, replace_range, replace_range_2):
4586 * insdel.c (make_gap_larger):
4587 * editfns.c (Finsert_char):
4588 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4589
28177add
PE
4590 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4591
e69dafad
PE
45922011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4593
4baa020d 4594 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4595
b1c46f02
PE
4596 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4597 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4598
e69dafad
PE
4599 * fileio.c: Don't assume EMACS_INT fits in off_t.
4600 (emacs_lseek): New static function.
4601 (Finsert_file_contents, Fwrite_region): Use it.
4602 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4603
566684ea
PE
4604 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4605
e6966cd6
PE
4606 * fns.c: Don't overflow int when computing a list length.
4607 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4608 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4609 truncation on 64-bit hosts. Check for QUIT every
4610 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4611 faster and is responsive enough.
4612 (Flength): Report an error instead of overflowing an integer.
4613 (Fsafe_length): Return a float if the value is not representable
4614 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4615 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4616 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4617
dd0b0efb
PE
4618 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4619 (header_size, word_size): New constants.
4620 (allocate_vectorlike): Don't check size overflow here.
4621 (allocate_vector): Check it here instead, since this is the only
4622 caller of allocate_vectorlike that could cause overflow.
4623 Check that the new vector's length is representable as a fixnum.
4624
86fe5cfe
PE
4625 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4626 The previous code was bogus. For example, next_almost_prime (32)
4627 returned 39, which is undesirable as it is a multiple of 3; and
4628 next_almost_prime (24) returned 25, which is a multiple of 5 so
4629 why was the code bothering to check for multiples of 7?
4630
80e88859
PE
4631 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4632
4a2f0ad6
PE
4633 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4634
f66c7cf8
PE
4635 Variadic C functions now count arguments with ptrdiff_t.
4636 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4637 Back then I didn't know that the Emacs coding style prefers signed int.
4638 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4639 were being counted with int, which may truncate counts on 64-bit
4640 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4641 * lisp.h (struct Lisp_Subr.function.aMANY)
4642 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4643 Arg counts are now ptrdiff_t, not size_t.
4644 All variadic functions and their callers changed accordingly.
4645 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4646 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4647 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4648 * callint.c (Fcall_interactively): Check arg count for overflow,
4649 to avoid potential buffer overrun. Use signed char, not 'int',
4650 for 'varies' array, so that we needn't bother to check its size
4651 calculation for overflow.
4652 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4653 * eval.c (apply_lambda):
4654 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4655 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4656 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4657
a1759b76
PE
4658 * callint.c (Fcall_interactively): Don't use index var as event count.
4659
d96be9fc
PE
4660 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4661 * mem-limits.h (SIZE): Remove; no longer used.
4662
a690a978 4663 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4664
578c21e6
PE
4665 Remove unnecessary casts.
4666 * xterm.c (x_term_init):
4667 * xfns.c (x_set_border_pixel):
4668 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4669 These aren't needed now that we assume ANSI C.
4670
96f53c6c
PE
4671 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4672 It's more likely to cause problems (due to unsigned overflow)
4673 than to cure them.
4674
83c77d31
PE
4675 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4676
ee2079f1
PE
4677 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4678
6da65536
PE
4679 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4680
7147c4a4
PE
4681 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4682
193e32d9
PE
4683 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4684
e5533da6
PE
4685 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4686
9910e595
PE
4687 GLYPH_CODE_FACE returns EMACS_INT, not int.
4688 * dispextern.h (merge_faces):
4689 * xfaces.c (merge_faces):
01103c44
PE
4690 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4691 Don't assume EMACS_INT fits in int.
9910e595 4692
2638320e
PE
4693 * character.h (CHAR_VALID_P): Remove unused parameter.
4694 * fontset.c, lisp.h, xdisp.c: All uses changed.
4695
045eb8d9
PE
4696 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4697
c1f134b5
PE
4698 * fns.c (concat): Minor tuning based on overflow analysis.
4699 This doesn't fix any bugs. Use int to hold character, instead
4700 of constantly refetching from Emacs object. Use XFASTINT, not
4701 XINT, for value known to be a character. Don't bother comparing
4702 a single byte to 0400, as it's always less.
4703
395fcb93 4704 * floatfns.c (Fexpt):
327eeec8
PE
4705 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4706
abbd3d23
PE
4707 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4708 for characters.
4709
684a03ef
PE
4710 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4711
0fed43f3
PE
4712 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4713 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4714 incorrectly succeed when S was a string, because 4294967386 was
4715 truncated before it was used.
4716
8fd02eb7
PE
4717 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4718 Otherwise, an out-of-range integer could cause undefined behavior
4719 on a 64-bit host.
4720
f8c86b69
PE
4721 * composite.c: Use int, not EMACS_INT, for characters.
4722 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4723 EMACS_INT, for values that are known to be in character range.
4724 This doesn't fix any bugs but is the usual style inside Emacs and
4725 may generate better code on 32-bit machines.
4726
34206dd2
PE
4727 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4728 This is for reasons similar to the recent CHAR_STRING fix.
4729 * charset.c (Fencode_char): Check that character arg is actually
4730 a character. Pass an int to ENCODE_CHAR.
4731 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4732 wider than 'int', as a compile-time check to prevent future regressions
4733 in this area.
4734
c5958d4c 4735 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4736
4737 Make sure a 64-bit char is never passed to CHAR_STRING.
4738 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4739 by silently ignoring the top 32 bits, allowing some values
4740 that were far too large to be valid characters.
4741 * character.h: Include <verify.h>.
4742 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4743 arguments are no wider than unsigned, as a compile-time check
4744 to prevent future regressions in this area.
4745 * data.c (Faset):
01103c44 4746 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4747 (Fsubst_char_in_region):
4748 * fns.c (concat):
4749 * xdisp.c (decode_mode_spec_coding):
4750 Adjust to CHAR_STRING's new requirement.
4751 * editfns.c (Finsert_char, Fsubst_char_in_region):
4752 * fns.c (concat): Check that character args are actually
4753 characters. Without this test, these functions did the wrong
4754 thing with wildly out-of-range values on 64-bit hosts.
4755
d37ca623
PE
4756 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4757 These casts should not be needed on 32-bit hosts, either.
4758 * keyboard.c (read_char):
4759 * lread.c (Fload): Remove casts to unsigned.
4760
ea204efb
PE
4761 * lisp.h (UNSIGNED_CMP): New macro.
4762 This fixes comparison bugs on 64-bit hosts.
4763 (ASCII_CHAR_P): Use it.
4764 * casefiddle.c (casify_object):
01103c44 4765 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4766 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4767 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4768 * dispextern.h (FACE_FROM_ID):
4769 * keyboard.c (read_char): Use UNSIGNED_CMP.
4770
41cb286c
PE
4771 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4772 not to EMACS_INT, to avoid GCC warning.
4773
4a1b9832
PE
4774 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4775
55daad71
PE
4776 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4777 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4778 isn't needed on 32-bit machines.
8f95c75c 4779
01103c44
PE
4780 * buffer.c (Fgenerate_new_buffer_name):
4781 Use EMACS_INT for count, not int.
0ceccced 4782 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4783
4784 * data.c (Qcompiled_function): Now static.
4785
c6f072e7
PE
4786 * window.c (window_body_lines): Now static.
4787
20ce5912
PE
4788 * image.c (gif_load): Rename local to avoid shadowing.
4789
9c4c5f81
PE
4790 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4791 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4792 * alloc.c (make_save_value): Integer argument is now of type
4793 ptrdiff_t, not int.
4794 (mark_object): Use ptrdiff_t, not int.
4795 * lisp.h (pD): New macro.
4796 * print.c (print_object): Use it.
4797
c0c5c8ae
PE
4798 * alloc.c: Use EMACS_INT, not int, to count objects.
4799 (total_conses, total_markers, total_symbols, total_vector_size)
4800 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4801 (total_free_floats, total_floats, total_free_intervals)
4802 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4803 Now EMACS_INT, not int. All uses changed.
4804 (Fgarbage_collect): Compute overall total using a double, so that
4805 integer overflow is less likely to be a problem. Check for overflow
4806 when converting back to an integer.
5a25e253
PE
4807 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4808 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4809 These were 'int' variables that could overflow on 64-bit hosts;
4810 they were never used, so remove them instead of repairing them.
211a0b2a 4811 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4812 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4813 Previously, this ceilinged at INT_MAX, but that doesn't work on
4814 64-bit machines.
e46bb31a 4815 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4816
c78baabf 4817 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4818 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4819 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4820 when a (possibly-narrower) signed value would do just as well.
4821 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4822
c9d624c6
PE
4823 * alloc.c: Catch some string size overflows that we were missing.
4824 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4825 for convenience in STRING_BYTES_MAX.
4826 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4827 The definition here is exact; the one in lisp.h was approximate.
4828 (allocate_string_data): Check for string overflow. This catches
4829 some instances we weren't catching before. Also, it catches
4830 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4831 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4832 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4833
c9d624c6
PE
4834 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4835 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4836 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4837
353032ce
PE
4838 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4839
2bccce07
PE
4840 * alloc.c (Fmake_string): Check for out-of-range init.
4841
0ac30604
SM
48422011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4843
4844 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4845
c195f2de
JD
48462011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4847
4848 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4849 xg_get_default_scrollbar_width.
4850
4851 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4852 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4853 (style_changed_cb): Call update_theme_scrollbar_width and call
4854 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4855 all frames (Bug#8505).
4856 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4857 Call gtk_window_set_resizable if HAVE_GTK3.
4858 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4859 and height if HAVE_GTK3 (Bug#8505).
4860 (scroll_bar_width_for_theme): New variable.
4861 (update_theme_scrollbar_width): New function.
4862 (xg_get_default_scrollbar_width): Move code to
4863 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4864 (xg_initialize): Call update_theme_scrollbar_width.
4865
4866 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4867
4868 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4869
e10ac9f1
MR
48702011-06-12 Martin Rudalics <rudalics@gmx.at>
4871
4872 * frame.c (make_frame): Call other_buffer_safely instead of
4873 other_buffer.
4874
4875 * window.c (temp_output_buffer_show): Call display_buffer with
4876 second argument Vtemp_buffer_show_specifiers and reset latter
4877 immediately after the call.
4878 (Vtemp_buffer_show_specifiers): New variable.
4879 (auto_window_vscroll_p, next_screen_context_lines)
4880 (Vscroll_preserve_screen_position): Remove leading asterisks from
4881 doc-strings.
4882
2d3c217e 48832011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4884
7b7f97e8 4885 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4886 * buffer.c (Qclone_number): Remove for now, as it's unused.
4887 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4888 (record_buffer): Remove unused local.
4889 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4890 (set_frame_buffer_list): Remove; unused.
4891 * frame.h (other_visible_frames): Remove decl.
4892 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4893 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4894 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4895 if HAVE_GPM.
4896 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4897 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4898 Define only if HAVE_GPM.
4899 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4900 (update_hints_inhibit): Remove; never set. All uses removed.
4901 * widgetprv.h (emacsFrameClassRec): Remove decl.
4902 * window.c (delete_deletable_window): Now returns void, since it
4903 wasn't returning anything.
4904 (compare_window_configurations): Remove unused locals.
4905 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4906 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4907 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4908 the same widths as pointers. This follows up on the 2011-05-06 patch.
4909 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4910 * xterm.h: Likewise.
4911 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4912
1384b89e
JB
49132011-06-12 Juanma Barranquero <lekktu@gmail.com>
4914
4915 * makefile.w32-in: Update dependencies.
4916 (LISP_H): Add lib/intprops.h.
4917
1100a63c
CY
49182011-06-11 Chong Yidong <cyd@stupidchicken.com>
4919
4920 * image.c (gif_load): Add animation frame delay to the metadata.
4921 (syms_of_image): Use DEFSYM. New symbol `delay'.
4922
6198ccd0
MR
49232011-06-11 Martin Rudalics <rudalics@gmx.at>
4924
4925 * window.c (delete_deletable_window): Re-add.
4926 (Fset_window_configuration): Rewrite to handle dead buffers and
4927 consequently deletable windows.
4928 (window_tree, Fwindow_tree): Remove. Supply functionality in
4929 window.el.
4930 (compare_window_configurations): Simplify code.
4931
b6e3633c
AS
49322011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4933
1ab0dee5
AS
4934 * image.c (imagemagick_load_image): Fix type mismatch.
4935 (Fimagemagick_types): Likewise.
4936
b6e3633c
AS
4937 * window.h (replace_buffer_in_windows): Declare.
4938
9397e56f
MR
49392011-06-11 Martin Rudalics <rudalics@gmx.at>
4940
4941 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4942 Qclone_number. Remove external declaration of Qdelete_window.
4943 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4944 code.
640c8776
SM
4945 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4946 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4947 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4948 buffer list implementation.
4949 (other_buffer_safely): New function.
4950 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4951 calls to replace_buffer_in_windows and
4952 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4953 if allowed.
4954 (record_buffer): Inhibit quitting and rewrite using quittable
4955 functions. Run Qbuffer_list_update_hook if allowed.
4956 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4957 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4958 Move switch-to-buffer to window.el.
9397e56f
MR
4959 (bury-buffer): Move to window.el.
4960 (Vbuffer_list_update_hook): New variable.
4961
4962 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4963 section.
4964
4965 * window.h (resize_frame_windows): Move up in code.
4966 (Fwindow_frame): Remove EXFUN.
4967 (replace_buffer_in_all_windows): Remove prototype.
4968 (replace_buffer_in_windows_safely): Add prototype.
4969
4970 * window.c: Declare Qdelete_window static again. Move down
4971 declaration of select_count.
4972 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4973 (Fother_window): Move to window.el.
4974 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4975 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4976 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4977 window.el.
4978 (replace_buffer_in_windows): Implement by calling
4979 Qreplace_buffer_in_windows.
4980 (replace_buffer_in_all_windows): Remove with some functionality
4981 moved into replace_buffer_in_windows_safely.
4982 (replace_buffer_in_windows_safely): New function.
4983 (select_window_norecord, select_frame_norecord): Move in front
4984 of run_window_configuration_change_hook. Remove now obsolete
4985 declarations.
640c8776
SM
4986 (Fset_window_buffer): Rewrite doc-string.
4987 Call Qrecord_window_buffer.
9397e56f
MR
4988 (keys_of_window): Move binding for other-window to window.el.
4989
b50691aa
CY
49902011-06-11 Chong Yidong <cyd@stupidchicken.com>
4991
4992 * dispextern.h (struct image): Replace data member, whose int_val
4993 and ptr_val fields were not used by anything, with a single
4994 lisp_val object.
4995
4996 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4997 (gif_clear_image, gif_load, imagemagick_load_image)
4998 (gs_clear_image, gs_load): Callers changed.
4999
3f754b86
PE
50002011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5001
cca69397
PE
5002 * buffer.h: Include <time.h>, for time_t.
5003 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5004
109e28d0
PE
5005 Fix minor problems found by static checking.
5006
60737f02
PE
5007 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5008
4b66faf3
PE
5009 Make identifiers static if they are not used in other modules.
5010 * data.c (Qcompiled_function, Qframe, Qvector):
5011 * image.c (QimageMagick, Qsvg):
5012 * minibuf.c (Qmetadata):
5013 * window.c (resize_window_check, resize_root_window): Now static.
5014 * window.h (resize_window_check, resize_root_window): Remove decls.
5015
109e28d0
PE
5016 * window.c (window_deletion_count, delete_deletable_window):
5017 Remove; unused.
46a4ce9e
PE
5018 (window_body_lines): Now static.
5019 (Fdelete_other_windows_internal): Mark vars as initialized.
5020 Make sure 'resize_failed' is initialized.
5021 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5022 (resize_window_apply): Remove unused local.
5023 * window.h (delete_deletable_window): Remove decl.
5024
109e28d0 5025 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5026 (imagemagick_load_image): Fix pointer signedness problem by changing
5027 last arg from unsigned char * to char *. All uses changed.
5028 Also, fix a local for similar reasons.
5029 Remove unused locals. Remove locals to avoid shadowing.
5030 (fn_rsvg_handle_free): Remove; unused.
5031 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5032 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5033
3f754b86
PE
5034 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5035
2547adb1
CY
50362011-06-10 Chong Yidong <cyd@stupidchicken.com>
5037
5038 * image.c (gif_load): Fix omitted cast error introduced by
5039 2011-06-06 change.
5040
2c8e37d4
MR
50412011-06-10 Martin Rudalics <rudalics@gmx.at>
5042
5043 * window.h (resize_proportionally, orig_total_lines)
5044 (orig_top_line): Remove from window structure.
5045 (set_window_height, set_window_width, change_window_heights)
5046 (Fdelete_window): Remove prototypes.
5047 (resize_frame_windows): Remove duplicate declaration.
5048
440a42e3
EZ
50492011-06-10 Eli Zaretskii <eliz@gnu.org>
5050
5051 * window.h (resize_frame_windows, resize_window_check)
5052 (delete_deletable_window, resize_root_window)
5053 (resize_frame_windows): Declare prototypes.
5054
5055 * window.c (resize_window_apply): Make definition be "static" to
5056 match the prototype.
5057
562dd5e9
MR
50582011-06-10 Martin Rudalics <rudalics@gmx.at>
5059
5060 * window.c: Remove declarations of Qwindow_size_fixed,
5061 window_min_size_1, window_min_size_2, window_min_size,
5062 size_window, window_fixed_size_p, enlarge_window, delete_window.
5063 Remove static from declaration of Qdelete_window, it's
5064 temporarily needed by Fbury_buffer.
5065 (replace_window): Don't assign orig_top_line and
5066 orig_total_lines.
5067 (Fdelete_window, delete_window): Remove. Window deletion is
5068 handled by window.el.
640c8776
SM
5069 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5070 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5071 (Fdelete_other_windows): Remove. Deleting other windows is
5072 handled by window.el.
5073 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5074 handled in window.el.
5075 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5076 Window minimum sizes are handled in window.el.
5077 (shrink_windows, size_window, set_window_height)
5078 (set_window_width, change_window_heights, window_height)
5079 (window_width, CURBEG, CURSIZE, enlarge_window)
5080 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5081 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5082 handled in window.el.
5083 (make_dummy_parent): Rename to make_parent_window and give it a
5084 second argument horflag.
5085 (make_window): Don't set resize_proportionally any more.
5086 (Fsplit_window): Remove. Windows are split in window.el.
5087 (save_restore_action, save_restore_orig_size)
5088 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5089 Resize mini windows in window.el.
5090 (grow_mini_window, shrink_mini_window): Implement by calling
5091 Qresize_root_window_vertically, resize_window_check and
5092 resize_window_apply.
640c8776
SM
5093 (saved_window, Fset_window_configuration, save_window_save):
5094 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5095 resize_proportionally.
5096 (window_min_height, window_min_width): Move to window.el.
5097 (keys_of_window): Move bindings for delete-other-windows,
5098 split-window, delete-window and enlarge-window to window.el.
5099
5100 * buffer.c: Temporarily extern Qdelete_window.
5101 (Fbury_buffer): Temporarily call Qdelete_window instead of
5102 Fdelete_window (Fbury_buffer will move to window.el soon).
5103
5104 * frame.c (set_menu_bar_lines_1): Remove code handling
5105 orig_top_line and orig_total_lines.
5106
5107 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5108 set_window_height but set heights directly.
5109 (change_frame_size_1): Use resize_frame_windows.
5110
5111 * xdisp.c (init_xdisp): Don't use set_window_height but set
5112 heights directly.
5113
640c8776
SM
5114 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5115 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5116 run_window_configuration_change_hook.
5117
5118 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5119 instead of change_window_heights and run
5120 run_window_configuration_change_hook.
5121
1a13852e
MR
51222011-06-09 Martin Rudalics <rudalics@gmx.at>
5123
5124 * window.c (replace_window): Rename second argument REPLACEMENT to
5125 NEW. New third argument SETFLAG. Rewrite.
5126 (delete_window, make_dummy_parent): Call replace_window with
5127 third argument 1.
5128 (window_list_1): Move down in code.
5129 (run_window_configuration_change_hook): Move set_buffer part
5130 before select_frame_norecord part in order to unwind correctly.
5131 Rename count1 to count.
5132 (recombine_windows, delete_deletable_window, resize_root_window)
5133 (Fdelete_other_windows_internal)
5134 (Frun_window_configuration_change_hook, make_parent_window)
5135 (resize_window_check, resize_window_apply, Fresize_window_apply)
5136 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5137 (Fdelete_window_internal, Fresize_mini_window_internal):
5138 New functions.
1a13852e
MR
5139 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5140
f3d1777e
MR
51412011-06-08 Martin Rudalics <rudalics@gmx.at>
5142
496e208e
MR
5143 * window.h (window): Add some new members to window structure -
5144 normal_lines, normal_cols, new_total, new_normal, clone_number,
5145 splits, nest, prev_buffers, next_buffers.
5146 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5147 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5148
f3d1777e
MR
5149 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5150 Remove.
496e208e
MR
5151 (make_dummy_parent): Set new members of windows structure.
5152 (make_window): Move down in code. Handle new members of window
5153 structure.
5154 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5155 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5156 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5157 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5158 (Fset_window_next_buffers, Fset_window_clone_number):
5159 New functions.
496e208e
MR
5160 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5161 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5162 Doc-string fixes.
5163 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5164 Argument WINDOW can be now internal window too.
5165 (Fwindow_use_time): Move up in code.
5166 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5167 Rewrite doc-string.
5168 (Fset_window_configuration, saved_window)
5169 (Fcurrent_window_configuration, save_window_save): Handle new
5170 members of window structure.
b9e809c2
MR
5171 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5172 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5173 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5174 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5175 Qget_mru_window, Qresize_root_window,
5176 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5177 Qauto_buffer_name; staticpro them.
f3d1777e 5178
abde8f8c
MR
51792011-06-07 Martin Rudalics <rudalics@gmx.at>
5180
5181 * window.c (Fwindow_total_size, Fwindow_left_column)
5182 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5183 (Fwindow_list_1): New functions.
5184 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5185 (Fwindow_width, Fscroll_left, Fscroll_right):
5186 Use window_body_cols instead of window_box_text_cols.
5187 (delete_window, Fset_window_configuration):
5188 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5189 (delete_all_subwindows): Take a window as argument and not a
5190 structure. Rewrite.
190b47e6
MR
5191 (window_loop): Remove handling of GET_LRU_WINDOW and
5192 GET_LARGEST_WINDOW.
5193 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5194
5195 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5196 window_box_text_cols. delete_all_subwindows now takes a
5197 Lisp_Object as argument.
abde8f8c 5198
640c8776
SM
5199 * indent.c (compute_motion, Fcompute_motion):
5200 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5201
fa8a67e6
MR
5202 * frame.c (delete_frame): Call delete_all_subwindows with root
5203 window as argument.
5204
a54e3482
DC
52052011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5206
5207 * fns.c (Fputhash): Document return value.
5208
60002bf5
CY
52092011-06-06 Chong Yidong <cyd@stupidchicken.com>
5210
5211 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5212
0c671da6 52132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5214
b862a52a 5215 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5216
be44ca6c
PE
5217 Check for overflow when converting integer to cons and back.
5218 * charset.c (Fdefine_charset_internal, Fdecode_char):
5219 Use cons_to_unsigned to catch overflow.
5220 (Fencode_char): Use INTEGER_TO_CONS.
5221 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5222 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5223 * data.c (long_to_cons, cons_to_long): Remove.
5224 (cons_to_unsigned, cons_to_signed): New functions.
5225 These signal an error for invalid or out-of-range values.
5226 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5227 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5228 * font.c (Ffont_variation_glyphs):
5229 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5230 * lisp.h: Include <intprops.h>.
5231 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5232 (cons_to_signed, cons_to_unsigned): New decls.
5233 (long_to_cons, cons_to_long): Remove decls.
5234 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5235 (Fprimitive_undo): Use CONS_TO_INTEGER.
5236 * xfns.c (Fx_window_property): Likewise.
5237 * xselect.c: Include <limits.h>.
5238 (x_own_selection, selection_data_to_lisp_data):
5239 Use INTEGER_TO_CONS.
5240 (x_handle_selection_request, x_handle_selection_clear)
5241 (x_get_foreign_selection, Fx_disown_selection_internal)
5242 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5243 (lisp_data_to_selection_data): Use cons_to_unsigned.
5244 (x_fill_property_data): Use cons_to_signed.
5245 Report values out of range.
5246
d1f3d2af
PE
5247 Check for buffer and string overflow more precisely.
5248 * buffer.h (BUF_BYTES_MAX): New macro.
5249 * lisp.h (STRING_BYTES_MAX): New macro.
5250 * alloc.c (Fmake_string):
5251 * character.c (string_escape_byte8):
5252 * coding.c (coding_alloc_by_realloc):
5253 * doprnt.c (doprnt):
5254 * editfns.c (Fformat):
5255 * eval.c (verror):
5256 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5257 since they may not be the same number.
5258 * editfns.c (Finsert_char):
5259 * fileio.c (Finsert_file_contents):
5260 Likewise for BUF_BYTES_MAX.
5261
dd52fcea
PE
5262 * image.c: Use ptrdiff_t, not int, for sizes.
5263 (slurp_file): Switch from int to ptrdiff_t.
5264 All uses changed.
5265 (slurp_file): Check that file size fits in both size_t (for
5266 malloc) and ptrdiff_t (for sanity and safety).
5267
7f9bbdbb
PE
5268 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5269 if b->modtime has its maximal value.
5270
dfe18f82
PE
5271 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5272
84acfcf0
PE
5273 Don't assume time_t can fit into int.
5274 * buffer.h (struct buffer.modtime): Now time_t, not int.
5275 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5276 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5277
ccd9a01a
PE
5278 Minor fixes for signed vs unsigned integers.
5279 * character.h (MAYBE_UNIFY_CHAR):
5280 * charset.c (maybe_unify_char):
5281 * keyboard.c (read_char, reorder_modifiers):
5282 XINT -> XFASTINT, since the integer must be nonnegative.
5283 * ftfont.c (ftfont_spec_pattern):
5284 * keymap.c (access_keymap, silly_event_symbol_error):
5285 XUINT -> XFASTINT, since the integer must be nonnegative.
5286 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5287 since it makes no difference and we prefer signed.
5288 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5289 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5290 nonnegative.
5291
d6d100dd
SM
52922011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5293
5294 * window.h (Fwindow_frame): Declare.
5295
2b6148e4
PE
52962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5297
5298 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5299 (SPARE_MEMORY): Always define.
5300 (LARGE_REQUEST): Remove.
5301 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5302
f230ecc9
MR
53032011-06-06 Martin Rudalics <rudalics@gmx.at>
5304
727e958e
MR
5305 * lisp.h: Move EXFUNS for Fframe_root_window,
5306 Fframe_first_window and Fset_frame_selected_window to window.h.
5307
5308 * window.h: Move EXFUNS for Fframe_root_window,
5309 Fframe_first_window and Fset_frame_selected_window here from
5310 lisp.h.
5311
5312 * frame.c (Fwindow_frame, Fframe_first_window)
5313 (Fframe_root_window, Fframe_selected_window)
5314 (Fset_frame_selected_window): Move to window.c.
5315 (Factive_minibuffer_window): Move to minibuf.c.
5316 (Fother_visible_frames_p): New function.
5317
5318 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5319
f230ecc9
MR
5320 * window.c (decode_window, decode_any_window): Move up in code.
5321 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5322 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5323 (Fwindow_buffer): Move up and rewrite doc-string.
5324 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5325 (Fwindow_prev): New functions.
727e958e
MR
5326 (Fwindow_frame): Move here from frame.c. Accept any window as
5327 argument.
5328 (Fframe_root_window, Fframe_first_window)
5329 (Fframe_selected_window): Move here from frame.c. Accept frame
5330 or arbitrary window as argument. Update doc-strings.
5331 (Fminibuffer_window): Move up in code.
5332 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5333 (Fset_frame_selected_window): Move here from frame.c.
5334 Marginal rewrite.
727e958e
MR
5335 (Fselected_window, select_window, Fselect_window): Move up in
5336 code. Minor doc-string fixes.
f230ecc9 5337
4d09bcf6
PE
53382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5339
5340 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5341 Do not assume that spare memory exists; that assumption is valid
5342 only if SYSTEM_MALLOC.
5343 (LARGE_REQUEST): New macro, so that the issue of large requests
5344 is separated from the issue of spare memory.
5345
810928a2
AS
53462011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5347
172418ad
AS
5348 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5349 format. (Bug#8806)
5350
43f862f7
AS
5351 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5352
810928a2
AS
5353 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5354 before statements.
5355
a059fe24
JD
53562011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5357
5358 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5359
5360 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5361
5362 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5363 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5364
989bf368
JB
53652011-06-05 Juanma Barranquero <lekktu@gmail.com>
5366
5367 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5368
4b80f674
CY
53692011-06-04 Chong Yidong <cyd@stupidchicken.com>
5370
5371 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5372 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5373 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5374 New error handlers.
4b80f674
CY
5375 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5376 Obey Vx_select_enable_clipboard_manager. Catch errors in
5377 x_clipboard_manager_save (Bug#8779).
5378 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5379 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5380
99a33b77 53812011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5382
5383 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5384
99a33b77 53852011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5386
5387 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5388 in the current matrix if keep_current_p is non-zero.
5389
8264569d
EZ
53902011-06-04 Eli Zaretskii <eliz@gnu.org>
5391
5392 * bidi.c (bidi_level_of_next_char): Fix last change.
5393
57f97249
EZ
53942011-06-03 Eli Zaretskii <eliz@gnu.org>
5395
fec2107c 5396 Support bidi reordering of text covered by display properties.
57f97249 5397
fec2107c
EZ
5398 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5399 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5400 (bidi_cache_search, bidi_cache_iterator_state)
5401 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5402 (bidi_level_of_next_char, bidi_move_to_visually_next):
5403 Support character positions inside a run of characters covered by a
fec2107c
EZ
5404 display string.
5405 (bidi_paragraph_init, bidi_resolve_explicit_1)
5406 (bidi_level_of_next_char): Call bidi_fetch_char and
5407 bidi_fetch_char_advance instead of FETCH_CHAR and
5408 FETCH_CHAR_ADVANCE.
5409 (bidi_init_it): Initialize new members.
5410 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5411 definitions.
5412 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5413 instead of using explicit *_CHAR codes.
d6d100dd
SM
5414 (bidi_resolve_explicit, bidi_resolve_weak):
5415 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5416 bidirectional text is supported only in multibyte buffers.
5417 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5418 it to initialize the frame_window_p member of struct bidi_it.
5419 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5420 (bidi_resolve_explicit, bidi_resolve_weak)
5421 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5422 bidi_it->nchars is non-positive.
5423 (bidi_level_of_next_char): Don't try to lookup the cache for the
5424 next/previous character if nothing is cached there yet, or if we
5425 were just reseat()'ed to a new position.
c40e2fb2 5426
0e14fe90
EZ
5427 * xdisp.c (set_cursor_from_row): Set start and stop points
5428 according to the row's direction when priming the loop that looks
5429 for the glyph on which to display cursor.
5430 (single_display_spec_intangible_p): Function deleted.
5431 (display_prop_intangible_p): Reimplement to call
5432 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5433 Accept 3 additional arguments needed by handle_display_spec.
5434 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5435 values: lists, `(when COND...)' forms, etc.
5436 (single_display_spec_string_p): Support property values that are
5437 lists with the argument STRING its top-level element.
5438 (display_prop_string_p): Fix the condition for processing a
5439 property that is a list to be consistent with handle_display_spec.
fec2107c 5440 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5441 last portion of handle_display_prop.
5442 (compute_display_string_pos): Accept additional argument
5443 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5444 value of a `display' property is a "replacing spec".
5445 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5446 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5447 the display property, but just return a value indicating whether
5448 the display property will replace the characters it covers.
5449 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5450 frame_window_p members of struct bidi_it.
d6d100dd
SM
5451 (compute_display_string_pos, compute_display_string_end):
5452 New functions.
fec2107c
EZ
5453 (push_it): Accept second argument POSITION, where pop_it should
5454 jump to continue iteration.
5455 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5456
fec2107c
EZ
5457 * keyboard.c (adjust_point_for_property): Adjust the call to
5458 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5459
5460 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5461 (bidi_init_it): Update prototypes.
5462 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5463 (compute_display_string_pos, compute_display_string_end):
5464 Declare prototypes.
fec2107c
EZ
5465 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5466 EMACS_INT.
fc6f18ce 5467
40087514 54682011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5469
57f53182
PE
5470 Malloc failure behavior now depends on size of allocation.
5471 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5472 * lisp.h: Change signatures accordingly.
5473 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5474 All callers changed. (Bug#8762)
5475
5476 * gnutls.c: Use Emacs's memory allocators.
5477 Without this change, the gnutls library would invoke malloc etc.
5478 directly, which causes problems on non-SYNC_INPUT hosts, and which
5479 runs afoul of improving memory_full behavior. (Bug#8761)
5480 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5481 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5482 xfree instead of the default malloc, realloc, free.
5483 (Fgnutls_boot): No need to check for memory allocation failure,
5484 since xmalloc does that for us.
5485
ac32cd99 5486 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5487 * category.c (hash_get_category_set):
5488 * ccl.c (ccl_driver):
5489 * charset.c (Fdefine_charset_internal):
5490 * charset.h (struct charset.hash_index):
5491 * composite.c (get_composition_id, gstring_lookup_cache)
5492 (composition_gstring_put_cache):
5493 * composite.h (struct composition.hash_index):
5494 * dispextern.h (struct image.hash):
5495 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5496 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5497 (hashfn_equal, hashfn_user_defined, make_hash_table)
5498 (maybe_resize_hash_table, hash_lookup, hash_put)
5499 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5500 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5501 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5502 * image.c (make_image, search_image_cache, lookup_image)
5503 (xpm_put_color_table_h):
5504 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5505 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5506 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5507 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5508 * alloc.c (allocate_vectorlike):
5509 Check for overflow in vector size calculations.
5510 * ccl.c (ccl_driver):
5511 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5512 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5513 need to be updated by these changes.
40087514
PE
5514 * fns.c (make_hash_table, maybe_resize_hash_table):
5515 Check for integer overflow with large hash tables.
0de4bb68
PE
5516 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5517 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5518 (SXHASH_REDUCE): New macro.
5519 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5520 Use it instead of discarding useful hash info with large hash values.
5521 (sxhash_float): New function.
5522 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5523 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5524 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5525 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5526 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5527 Adjust signatures to match updated version of code.
5528 (consing_since_gc): Now EMACS_INT, since a single hash table can
5529 use more than INT_MAX bytes.
5530
698d32e2
DN
55312011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5532
5533 Make it possible to build with GCC-4.6+ -O2 -flto.
5534
5535 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5536
fd6fa53f
SM
55372011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5538
5539 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5540 Call minibuffer-inactive-mode.
5541
864db017
JB
55422011-05-31 Juanma Barranquero <lekktu@gmail.com>
5543
5544 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5545 Update dependencies.
5546
2ad0baf4
DN
55472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5548
5549 * data.c (init_data): Remove code for UTS, this system is not
5550 supported anymore.
5551
4fcc2638
DN
55522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5553
5554 Don't force ./temacs to start in terminal mode.
5555
5556 * frame.c (make_initial_frame): Initialize faces in all cases, not
5557 only when CANNOT_DUMP is defined.
5558 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5559
c56e0fd5
DN
55602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5561
5562 * dispnew.c (add_window_display_history): Use const for the string
5563 pointer. Remove declaration, not needed.
5564
333d54da 55652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5566
55d4c1b2 5567 Use 'inline', not 'INLINE'.
333d54da 5568 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5569 * alloc.c, fontset.c (INLINE): Remove.
5570 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5571 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5572 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5573 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5574 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5575
738db178
DN
55762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5577
5578 Make it possible to run ./temacs.
5579
5580 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5581 syms_of_callproc does the same thing. Remove test for
5582 "initialized", do it in the caller.
5583 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5584
620c53a6
SM
55852011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5586
5587 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5588 (read_minibuf): Use get_minibuffer.
5589 (syms_of_minibuf): Use DEFSYM.
5590 (Qmetadata): New var.
5591 * data.c (Qbuffer): Don't make it static.
5592 (syms_of_data): Use DEFSYM.
5593
e003a292
PE
55942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5595
5596 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5597 (CCL_CODE_MIN): New macro.
5598
ed008a6d
PE
55992011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5600
3687c2ef
PE
5601 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5602
ed008a6d
PE
5603 * eval.c (Qdebug): Now static.
5604 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5605 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5606 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5607
d66c4c7c
CY
56082011-05-29 Chong Yidong <cyd@stupidchicken.com>
5609
5610 * image.c: Various fixes to ImageMagick code comments.
5611 (Fimagemagick_types): Doc fix.
5612
5fbc2025
PE
56132011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5614
0196f88a
PE
5615 Minor fixes prompted by GCC 4.6.0 warnings.
5616
5617 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5618
5fbc2025
PE
5619 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5620 (x_clipboard_manager_save_all): Move extern decl to ...
5621 * xterm.h: ... here, so that it can be checked for consistency.
5622
1dd3c2d9
CY
56232011-05-29 Chong Yidong <cyd@stupidchicken.com>
5624
5625 * xselect.c (x_clipboard_manager_save_frame)
5626 (x_clipboard_manager_save_all): New functions.
5627 (Fx_clipboard_manager_save): Lisp function deleted.
5628
5629 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5630 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5631
5632 * xterm.h: Update prototype.
5633
5ba6571d
WX
56342011-05-28 William Xu <william.xwl@gmail.com>
5635
5636 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5637 exiting (Bug#8239).
5638
3eaff834
JM
56392011-05-28 Jim Meyering <meyering@redhat.com>
5640
e1900994 5641 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5642 * fns.c (to_uchar): Define.
5643 (crypto_hash_function): Use it to convert some newly-signed
5644 variables to unsigned, to avoid sign-extension bugs. For example,
5645 without this change, (md5 "truc") would evaluate to
5646 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5647 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5648 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5649
0f6990a7
PE
56502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5651
5652 Integer overflow fixes.
c8a9ca5a 5653
08686060
PE
5654 * dbusbind.c: Serial number integer overflow fixes.
5655 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5656 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5657 to hold a serial number that is too large for a fixnum.
5658 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5659 Check for serial numbers out of range. Decode any serial number
59568bf0 5660 that was so large that it became a float. (Bug#8722)
08686060 5661
2d1fc3c7
PE
5662 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5663 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5664 Use XFASTINT rather than XUINT when numbers are nonnegative.
5665 (xd_append_arg, Fdbus_method_return_internal):
5666 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5667 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5668 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5669 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5670 (Bug#8722)
2d1fc3c7 5671
c8a9ca5a
PE
5672 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5673
519e1d69
PE
5674 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5675
6df6ae42 5676 ccl: Add integer overflow checks.
30569699
PE
5677 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5678 (IN_INT_RANGE): New macros.
5679 (ccl_driver): Use them to check for integer overflow when
5680 decoding a CCL program. Many of the new checks are whether XINT (x)
5681 fits in int; it doesn't always, on 64-bit hosts. The new version
5682 doesn't catch all possible integer overflows, but it's an
847044ea 5683 improvement. (Bug#8719)
30569699 5684
c11285dc
PE
5685 * alloc.c (make_event_array): Use XINT, not XUINT.
5686 There's no need for unsigned here.
5687
fdccd48e
PE
5688 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5689 This follows up to the 2011-05-06 change that substituted uintptr_t
5690 for EMACS_INT. This case wasn't caught back then.
5691
37910ab2
PE
5692 Rework Fformat to avoid integer overflow issues.
5693 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5694 now (part of C89). Include <verify.h>.
5695 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5696 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5697 (Fformat): Avoid the prepass trying to compute sizes; it was only
5698 approximate and thus did not catch overflow reliably. Instead, walk
5699 through the format just once, formatting and computing sizes as we go,
5700 checking for integer overflow at every step, and allocating a larger
5701 buffer as needed. Keep track separately whether the format is
5702 multibyte. Keep only the most-recently calculated precision, rather
5703 than them all. Record whether each argument has been converted to
5704 string. Use EMACS_INT, not int, for byte and char and arg counts.
5705 Support field widths and precisions larger than INT_MAX. Avoid
5706 sprintf's undefined behavior with conversion specifications such as %#d
5707 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5708 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5709 formatting out-of-range floating point numbers with int
9173deec 5710 formats. (Bug#8668)
37910ab2 5711
2e6578fb
PE
5712 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5713
0ae6bdee
PE
5714 * data.c: Avoid integer truncation in expressions involving floats.
5715 * data.c: Include <intprops.h>.
5716 (arith_driver): When there's an integer overflow in an expression
5717 involving floating point, convert the integers to floating point
5718 so that the resulting value does not suffer from catastrophic
5719 integer truncation. For example, on a 64-bit host (* 4
5720 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5721 Do not rely on undefined behavior after integer overflow.
5722
de883a70
PE
5723 merge count_size_as_multibyte, parse_str_to_multibyte
5724 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5725 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5726 Check for integer overflow.
5727 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5728 since it's now a duplicate of the other. This is more of
5729 a character than a buffer op, so better that it's in character.c.
5730 * fns.c, print.c: Adjust to above changes.
5731
2ff916cb
PE
57322011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5733
5734 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5735
f1b54466
PE
57362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5737
fb1ac845
PE
5738 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5739 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5740 (x_clipboard_manager_save): Now static.
5741 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5742
f1b54466
PE
5743 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5744 (crypto_hash_function): Now static.
5745 Fix pointer signedness problems. Avoid unnecessary initializations.
5746
a9f737ee
CY
57472011-05-27 Chong Yidong <cyd@stupidchicken.com>
5748
5749 * termhooks.h (Vselection_alist): Make it terminal-local.
5750
5751 * terminal.c (create_terminal): Initialize it.
5752
5753 * xselect.c: Support for clipboard managers.
5754 (Vselection_alist): Move to termhooks.h as terminal-local var.
5755 (LOCAL_SELECTION): New macro.
5756 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5757 (symbol_to_x_atom): Remove gratuitous arg.
5758 (x_handle_selection_request, lisp_data_to_selection_data)
5759 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5760 (x_own_selection, x_get_local_selection, x_convert_selection):
5761 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5762 (some_frame_on_display): Delete unused function.
5763 (Fx_own_selection_internal, Fx_get_selection_internal)
5764 (Fx_disown_selection_internal, Fx_selection_owner_p)
5765 (Fx_selection_exists_p): New optional frame arg.
5766 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5767 (x_handle_selection_clear): Don't treat other terminals with the
5768 same keyboard specially. Use the terminal-local Vselection_alist.
5769 (x_clear_frame_selections): Use Frun_hook_with_args.
5770
5771 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5772
5773 * xterm.h: Add support for those atoms.
5774
e067f0c1
CY
57752011-05-26 Chong Yidong <cyd@stupidchicken.com>
5776
5777 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5778 (converted_selections, conversion_fail_tag): New global variables.
5779 (x_selection_request_lisp_error): Free the above.
5780 (x_get_local_selection): Remove unnecessary code.
5781 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5782 of converted selections stored in converted_selections.
5783 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5784 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5785 (x_convert_selection): New function.
5786 (x_handle_selection_event): Simplify.
5787 (x_get_foreign_selection): Don't ignore incoming requests while
5788 waiting for an answer; this will fail when we implement
5789 SAVE_TARGETS, and seems unnecessary anyway.
5790 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5791 (Vx_sent_selection_functions): Doc fix.
5792
0f4aebc0
LL
57932011-05-26 Leo Liu <sdl.web@gmail.com>
5794
5795 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5796
e61124cd
YM
57972011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5798
5799 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5800
5801 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5802 for fringe update if it has periodic bitmap.
ac389d0c 5803 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5804 and fringe_bitmap_periodic_p.
5805
5806 * fringe.c (get_fringe_bitmap_data): New function.
5807 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5808 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5809 row. Mark glyph row for fringe update if periodicity changed.
5810
5811 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5812 for fringe update unless it has periodic bitmap.
5813
f16d9837
KH
58142011-05-25 Kenichi Handa <handa@m17n.org>
5815
5816 * xdisp.c (get_next_display_element): Set correct it->face_id for
5817 a static composition.
5818
e1b90ef6
LL
58192011-05-24 Leo Liu <sdl.web@gmail.com>
5820
5821 * deps.mk (fns.o):
5822 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5823
5824 * fns.c (crypto_hash_function, Fsha1): New function.
5825 (Fmd5): Use crypto_hash_function.
5826 (syms_of_fns): Add Ssha1.
5827
7400048f
PE
58282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5829
5830 * gnutls.c: Remove unused macros.
5831 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5832 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5833 Remove macros that are defined and never used.
5834 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5835
abb71cf4
CY
58362011-05-22 Chong Yidong <cyd@stupidchicken.com>
5837
5838 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5839 (Fx_get_selection_internal): Minor cleanup.
5840 (Fx_own_selection_internal): Rename arguments for consistency with
5841 select.el.
5842
6307db39
PE
58432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5844
5845 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5846
f3d4e0a4
CY
58472011-05-22 Chong Yidong <cyd@stupidchicken.com>
5848
5849 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5850
4d8ade89
YM
58512011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5852
5853 * dispnew.c (scrolling_window): Don't exclude the case that the
5854 last enabled row in the desired matrix touches the bottom boundary.
5855
32078c8d
GM
58562011-05-21 Glenn Morris <rgm@gnu.org>
5857
5858 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5859 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5860 and add some more files.
32078c8d 5861
7285dc67
EZ
58622011-05-20 Eli Zaretskii <eliz@gnu.org>
5863
5864 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5865 report_file_error introduced by the change from 2011-05-07.
5866
89d1bd22
PE
58672011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5868
5869 * systime.h (Time): Define only if emacs is defined.
5870 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5871 where the include path doesn't have X11/X.h by default. See
5872 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5873
cd394be1 58742011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5875
5876 * composite.c (find_automatic_composition): Fix previous change.
5877
b9704ad9
GM
58782011-05-20 Glenn Morris <rgm@gnu.org>
5879
5880 * lisp.mk: New file, split from Makefile.in.
5881 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5882 (shortlisp): Remove.
5883 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5884
4a720484
GM
58852011-05-19 Glenn Morris <rgm@gnu.org>
5886
5887 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5888 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5889 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5890 (lisp): Set the order to that of loadup.el.
5891 (shortlisp): Make it a copy of $lisp.
5892 (SOME_MACHINE_LISP): Remove.
5893 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5894 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5895
a28d4396
KH
58962011-05-18 Kenichi Handa <handa@m17n.org>
5897
5898 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5899 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5900 (find_automatic_composition): Mostly rewrite for efficiency.
5901
a2b1fa8e
JB
59022011-05-18 Juanma Barranquero <lekktu@gmail.com>
5903
5904 * makefile.w32-in: Update dependencies.
5905
8e1f5610
CS
59062011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5907
5908 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5909 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5910
7025ee00 59112011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5912
cdfa6eab
PE
5913 Fix some integer overflow issues, such as string length overflow.
5914
06d6db33
PE
5915 * insdel.c (count_size_as_multibyte): Check for string overflow.
5916
2b4560a8
PE
5917 * character.c (lisp_string_width): Check for string overflow.
5918 Use EMACS_INT, not int, for string indexes and lengths; in
5919 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5920 the resulting string length overflows an EMACS_INT; instead,
5921 report a string overflow if no precision given. When checking for
5922 precision exhaustion, use a check that cannot possibly have
5923 integer overflow. (Bug#8675)
5924 * character.h (lisp_string_width): Adjust to new signature.
5925
cb93f9be
PE
5926 * alloc.c (string_overflow): New function.
5927 (Fmake_string): Use it. This doesn't change behavior, but saves
5928 a few bytes and will simplify future changes.
5929 * character.c (string_escape_byte8): Likewise.
5930 * lisp.h (string_overflow): New decl.
5931
1a1f3366
PE
5932 Fixups, following up to the user-interface timestamp change.
5933 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5934 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5935 * msdos.c (mouse_get_pos): Likewise.
5936 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5937 * w32gui.h (Time): Define by including "systime.h" rather than by
5938 declaring it ourselves. (Bug#8664)
5939
d4e3e4d3
PE
5940 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5941 * image.c (clear_image_cache): Likewise.
5942
f6a24d19
PE
5943 * term.c (term_mouse_position): Don't assume time_t wraparound.
5944
08dc5ae6
PE
5945 Be more systematic about user-interface timestamps.
5946 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5947 and sometimes 'EMACS_UINT', to represent these timestamps.
5948 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5949 This makes the code easier to follow, and makes it easier to catch
5950 integer overflow bugs such as Bug#8664.
5951 * frame.c (Fmouse_position, Fmouse_pixel_position):
5952 Use Time, not unsigned long, for user-interface timestamps.
5953 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5954 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5955 * keyboard.h (last_event_timestamp): Likewise.
5956 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5957 * menu.h (xmenu_show): Likewise.
5958 * term.c (term_mouse_position): Likewise.
5959 * termhooks.h (struct input_event.timestamp): Likewise.
5960 (struct terminal.mouse_position_hook): Likewise.
5961 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5962 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5963 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5964 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5965 what it was before.
5966 * menu.h, termhooks.h: Include "systime.h", for Time.
5967
8e55734a
PE
5968 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5969 Don't assume that the difference between two unsigned long values
5970 can fit into an integer. At this point, we know button_down_time
5971 <= event->timestamp, so the difference must be nonnegative, so
5972 there's no need to cast the result if double-click-time is
5973 nonnegative, as it should be; check that it's nonnegative, just in
5974 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5975 apart (about 25 days). (Bug#8664)
8e55734a 5976
841f1b75 5977 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5978 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5979
3e26f69c
PE
5980 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5981 that always fit in int. Use a sentinel instead of a counter, to
5982 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5983 * frame.h (struct frame): Use int for menu_bar_items_used
5984 instead of EMACS_INT, since it always fits in int.
3e26f69c 5985
5cc152c0
PE
5986 * menu.c (grow_menu_items): Check for int overflow.
5987
d89eb65e
PE
5988 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5989
5235bd3e
PE
5990 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5991 Before, the code was not consistent. These values cannot exceed
5992 2**31 - 1 so there's no need to make them unsigned.
5993 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5994 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5995 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5996 as modifiers.
5997 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5998
bc827e23
PE
5999 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6000 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6001 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6002 presumably because the widths might not match.
6003
78eb494e
PE
6004 * window.c (size_window): Avoid needless test at loop start.
6005
04f2d78b
CB
60062011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6007
6008 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6009
d2fc7e3d 60102011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6011
6012 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6013
d2fc7e3d 60142011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6015
6016 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6017 `width' to `bar_area_x' and `bar_area_width', respectively.
6018 (x_scroll_run): Take account of fringe background extension.
6019
04f2d78b
CB
6020 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6021 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6022 `bar_area_width', respectively.
6023 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6024 background extension.
6025
79b70037
GM
60262011-05-10 Jim Meyering <meyering@redhat.com>
6027
6028 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6029
2f142cc5
JB
60302011-05-10 Juanma Barranquero <lekktu@gmail.com>
6031
6032 * image.c (Finit_image_library): Return t for built-in image types,
6033 like pbm and xbm. (Bug#8640)
6034
57679c86
AS
60352011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6036
6037 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6038
888c9e86
EZ
60392011-05-07 Eli Zaretskii <eliz@gnu.org>
6040
b0512a1d
EZ
6041 * w32console.c (Fset_screen_color): Doc fix.
6042 (Fget_screen_color): New function.
6043 (syms_of_ntterm): Defsubr it.
6044
7285dc67
EZ
6045 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6046 unlink the temporary file if Fcall_process didn't create it in the
6047 first place.
6048 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6049 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6050 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6051 cue to call_process_cleanup not to close that handle.
6052
4d3fcc8e
BK
60532011-05-07 Ben Key <bkey76@gmail.com>
6054
6055 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6056 one of two shell specific rules, either bootstrap-temacs-CMD or
6057 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6058 to the previous implementation of the bootstrap-temacs rule.
6059 The bootstrap-temacs-CMD rule is similar to the previous
6060 implementation of the bootstrap-temacs rule except that it
6061 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6062 variable.
6063
6064 These changes, along with some changes to nt/configure.bat,
6065 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6066 earlier fix to add support for --cflags and --ldflags options
6067 that include quotes so that it works whether make uses cmd or
6068 sh as the shell.
6069
b4289b64
MA
60702011-05-06 Michael Albinus <michael.albinus@gmx.de>
6071
6072 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6073 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6074 is a constant.
6075 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6076 a string. Handle both cases.
6077 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6078 (Fdbus_register_method): Use Qinvalid_function.
6079
af4c0e28
JB
60802011-05-06 Juanma Barranquero <lekktu@gmail.com>
6081
6082 * makefile.w32-in: Update dependencies.
6083 (LISP_H): Add inttypes.h and stdin.h.
6084 (PROCESS_H): Add unistd.h.
6085
c51453d9
EZ
60862011-05-06 Eli Zaretskii <eliz@gnu.org>
6087
6088 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6089 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6090
8ff0ac3c 60912011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6092
4c4b566b
PE
6093 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6094
aab2b9b5
PE
6095 * term.c (vfatal): Remove stray call to va_end.
6096 It's not needed and the C Standard doesn't allow it here anyway.
6097
c378da0b
PE
6098 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6099 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6100
288b08c7
PE
6101 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6102 bytes.
6103
e3601888
PE
6104 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6105
db6c0e74
PE
6106 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6107
dd5963ea
PE
6108 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6109
88c9450f
PE
6110 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6111
2f9442b8
PE
6112 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6113
c032b5f8
PE
6114 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6115 * charset.c (Fdefine_charset_internal): Don't initialize
6116 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6117 32-bit int (Bug#8600).
a108c10b
PE
6118
6119 * lread.c (read_integer): Be more consistent with string-to-number.
6120 Use string_to_number to do the actual conversion; this avoids
6121 rounding errors and fixes some other screwups. Without this fix,
6122 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6123 (digit_to_number): Move earlier, for benefit of read_integer.
6124 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6125 not a digit in any supported base. (Bug#8602)
a108c10b 6126
ad5f9eea
PE
6127 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6128
aec1708a
PE
6129 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6130 to match comment at start of function. This also removes a
6131 GCC warning about overflow in a 32+64-bit port.
6132
47be4ab5
PE
6133 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6134
371cac43
PE
6135 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6136 Reported by Stefan Monnier in
6137 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6138 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6139 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6140
d01a7826
PE
6141 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6142 (EMACS_UINTPTR): Likewise, with uintptr_t.
6143
7fd47d5c
PE
6144 * lisp.h: Prefer 64-bit EMACS_INT if available.
6145 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6146 on 32-bit hosts that have 64-bit int, so that they can access
6147 large files.
122b0c86
PE
6148 However, temporarily disable this change unless the temporary
6149 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6150
8727937b
PE
6151 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6152
8ac068ac
PE
6153 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6154 This removes an assumption that EMACS_INT and long are the same
6155 width as pointers. The assumption is true for Emacs porting targets
6156 now, but we want to make other targets possible.
6157 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6158 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6159 In the rest of the code, change types of integers that hold casted
6160 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6161 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6162 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6163 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6164 No need to cast type when ORing.
6165 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6166 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6167 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6168 assume EMACS_INT is the same width as char *.
6169 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6170 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6171 Remove no-longer-needed casts.
6172 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6173 (xg_tool_bar_help_callback, xg_make_tool_item):
6174 Use EMACS_INTPTR to hold an integer
6175 that will be cast to void *; this can avoid a GCC warning
6176 if EMACS_INT is not the same width as void *.
6177 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6178 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6179 (current_message_1, set_message_1):
6180 Use a local to convert to proper width without a cast.
6181 * xmenu.c (dialog_selection_callback): Likewise.
6182
ede49d71
PE
6183 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6184 Also, don't assume VALBITS / RAND_BITS is less than 5,
6185 and don't rely on undefined behavior when shifting a 1 left into
6186 the sign bit.
6187 * lisp.h (get_random): Change signature to match.
6188
2f30ecd0
PE
6189 * lread.c (hash_string): Use size_t, not int, for hash computation.
6190 Normally we prefer signed values; but hashing is special, because
6191 it's better to use unsigned division on hash table sizes so that
6192 the remainder is nonnegative. Also, size_t is the natural width
6193 for hashing into memory. The previous code used 'int', which doesn't
6194 retain enough info to hash well into very large tables.
6195 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6196
2a866e7b
PE
6197 * dbusbind.c: Don't possibly lose pointer info when converting.
6198 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6199 Use XPNTR rather than XHASH, so that the high-order bits of
6200 the pointer aren't lost when converting through void *.
6201
51639eac
PE
6202 * eval.c (Fautoload): Don't double-shift a pointer.
6203
92394119
PE
6204 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6205
dbdb9a7c
JB
62062011-05-06 Juanma Barranquero <lekktu@gmail.com>
6207
6208 * gnutls.c (DEF_GNUTLS_FN):
6209 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6210
db7a0b4f
AS
62112011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6212
6213 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6214 marker. (Bug#8610)
6215
cd394be1 62162011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6217
6218 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6219 New version that can reserve upto 2GB of heap space.
6220
f7ff1b0f 62212011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6222
6223 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6224
639c109b
TZ
62252011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6226
6227 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6228 `gnutls_certificate_set_x509_key_file'.
6229
d2127135
JB
62302011-05-05 Juanma Barranquero <lekktu@gmail.com>
6231
6232 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6233 Update dependencies.
6234
e968f4f3
JB
62352011-05-04 Juanma Barranquero <lekktu@gmail.com>
6236
6237 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6238 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6239 Remove unused parameter `fildes'.
6240 * process.c (read_process_output, send_process): Don't pass it.
6241
84d358f0
JB
62422011-05-04 Juanma Barranquero <lekktu@gmail.com>
6243
6244 Fix previous change: the library cache is defined in w32.c.
6245 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6246 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6247
0898ca10
JB
62482011-05-04 Juanma Barranquero <lekktu@gmail.com>
6249
6250 Implement dynamic loading of GnuTLS on Windows.
6251
6252 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6253 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6254 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6255 Declare.
6256
6257 * gnutls.c (Qgnutls_dll): Define.
6258 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6259 (gnutls_*): Declare function pointers.
6260 (init_gnutls_functions): New function to initialize function pointers.
6261 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6262 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6263 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6264 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6265 (emacs_gnutls_write, emacs_gnutls_read)
6266 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6267 (Fgnutls_available_p): New function.
6268 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6269 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6270 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6271
6272 * image.c: Include w32.h.
6273 (Vimage_type_cache): Delete.
6274 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6275 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6276 (w32_delayed_load): Move to w32.c.
6277
6278 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6279
6280 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6281 (w32_delayed_load): Move from image.c. When loading a library, record
6282 its filename in the :loaded-from property of the library id.
6283 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6284 Initialize and staticpro them.
6285 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6286
6287 * process.c: Include lisp.h before w32.h, not after.
6288 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6289 instead of gnutls_record_check_pending.
6290
6291 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6292
ff4de4aa
TZ
62932011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6294
6295 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6296 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6297 as passed in.
6298
abe95abb
JD
62992011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6300
6301 * xterm.c (x_set_frame_alpha): Do not set property on anything
6302 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6303
e16e55d4
JB
63042011-05-02 Juanma Barranquero <lekktu@gmail.com>
6305
6306 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6307
bafcf6a5
JB
63082011-05-02 Juanma Barranquero <lekktu@gmail.com>
6309
6310 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6311 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6312 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6313 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6314 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6315 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6316 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6317 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6318 (Qgnutls_bootprop_callbacks_verify): Make static.
6319
e7a6747f
AS
63202011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6321
19ed11ba
AS
6322 * callproc.c: Indentation fixup.
6323
e7a6747f 6324 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6325 (wait_for_termination, interruptible_wait_for_termination):
6326 Move after wait_for_termination_1.
e7a6747f 6327
1ef14cb4
LMI
63282011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6329
6330 * sysdep.c (interruptible_wait_for_termination): New function
6331 which is like wait_for_termination, but allows keyboard
6332 interruptions.
6333
6334 * callproc.c (Fcall_process): Add (:file "file") as an option for
6335 the STDOUT buffer.
6336 (Fcall_process_region): Ditto.
6337
330d880c
EZ
63382011-04-30 Eli Zaretskii <eliz@gnu.org>
6339
8db90b73
EZ
6340 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6341 rather than `XVECTOR (FOO)->size'.
6342
330d880c
EZ
6343 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6344 inttypes.h, as a gnulib replacement is used if it not available in
6345 system headers.
6346
15cbd324
EZ
63472011-04-21 Eli Zaretskii <eliz@gnu.org>
6348
6349 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6350 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6351 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6352
6353 * coding.c (coding_alloc_by_realloc): Error out if destination
6354 will grow beyond MOST_POSITIVE_FIXNUM.
6355 (decode_coding_emacs_mule): Abort if there isn't enough place in
6356 charbuf for the composition carryover bytes. Reserve an extra
6357 space for up to 2 characters produced in a loop.
6358 (decode_coding_iso_2022): Abort if there isn't enough place in
6359 charbuf for the composition carryover bytes.
6360
63612011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6362
ae940cca
EZ
6363 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6364 aborting when %lld or %lll format is passed.
6365 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6366 %llo or %llx format is passed. (Bug#8545)
6367
03ab8921
EZ
6368 * window.c (window_scroll_line_based): Use a marker instead of
6369 simple variables to record original value of point. (Bug#7952)
6370
afda1437
EZ
6371 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6372 produced by %s or %c overflows available buffer space. (Bug#8545)
6373
f76dee0c
PE
63742011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6375
6376 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6377 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6378
fdc5744d
JB
63792011-04-28 Juanma Barranquero <lekktu@gmail.com>
6380
6381 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6382
638f053a
JB
63832011-04-28 Juanma Barranquero <lekktu@gmail.com>
6384
6385 * keyboard.c (Qdelayed_warnings_hook): Define.
6386 (command_loop_1): Run `delayed-warnings-hook'
6387 if Vdelayed_warnings_list is non-nil.
6388 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6389 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6390
d178f871
EZ
63912011-04-28 Eli Zaretskii <eliz@gnu.org>
6392
6393 * doprnt.c (doprnt): Don't return value smaller than the buffer
6394 size if the message was truncated. (Bug#8545).
6395
b124fd93
JB
63962011-04-28 Juanma Barranquero <lekktu@gmail.com>
6397
6398 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6399 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6400
e810457d
PE
64012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6402
6403 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6404
ea51cceb
JB
64052011-04-27 Juanma Barranquero <lekktu@gmail.com>
6406
6407 * makefile.w32-in: Update dependencies.
6408
94dcfacf
EZ
64092011-04-27 Eli Zaretskii <eliz@gnu.org>
6410
6411 Improve `doprnt' and its usage. (Bug#8545)
6412 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6413 `format_end'. Remove support for %l as a conversion specifier.
6414 Don't use xrealloc. Improve diagnostics when the %l size modifier
6415 is used. Update the commentary.
6416
6417 * eval.c (verror): Simplify calculation of size_t.
6418
6419 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6420 messages.
6421
f61f41d7
PE
64222011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6423
6424 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6425 change.
6426
96fb4434
PE
64272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6428
6429 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6430 This makes this file independent of the recent pseudovector change.
6431
671875da 64322011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6433
69e9b5a3
PE
6434 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6435
b5f869a7 6436 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6437 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6438 Remove unused local.
c8926152 6439 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6440
841a1577 6441 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6442 GCC 4.6.0 optimizes based on type-based alias analysis.
6443 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6444 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6445 != &v->size, and therefore "v->size = 1; b->size = 2; return
6446 v->size;" must therefore return 1. This assumption is incorrect
6447 for Emacs, since it type-puns struct Lisp_Vector * with many other
6448 types. To fix this problem, this patch adds a new type struct
f904488f 6449 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6450 and pseudovectors, and helps optimizing compilers not get fooled
6451 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6452 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6453 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6454 the size member.
eab3844f
PE
6455 (XSETPVECTYPE): Rewrite in terms of new macro.
6456 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6457 This is a bit clearer, and further avoids the possibility of
6458 undesirable aliasing.
6459 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6460 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6461 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6462 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6463 (ASIZE): Now uses header.size rather than size.
6464 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6465 to avoid the hassle of writing XVECTOR (foo)->header.size.
6466 (struct vectorlike_header): New type.
eab3844f
PE
6467 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6468 object, to help avoid aliasing.
6469 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6470 (SUBRP): Likewise, since Lisp_Subr is a special case.
6471 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6472 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6473 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6474 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6475 changed to be "header.size" and "header.next".
6476 * buffer.h (struct buffer): Likewise.
6477 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6478 * frame.h (struct frame): Likewise.
6479 * process.h (struct Lisp_Process): Likewise.
6480 * termhooks.h (struct terminal): Likewise.
6481 * window.c (struct save_window_data, struct saved_window): Likewise.
6482 * window.h (struct window): Likewise.
6483 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6484 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6485 * buffer.c (init_buffer_once): Likewise.
6486 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6487 special case.
6488 * process.c (Fformat_network_address): Use local var for size,
6489 for brevity.
6490
0df1eac5
PE
6491 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6492
847ab9d1 6493 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6494 * data.c (atof): Remove decl; no longer used or needed.
6495 (digit_to_number): Move to lread.c.
6496 (Fstring_to_number): Use new string_to_number function, to be
6497 consistent with how the Lisp reader treats infinities and NaNs.
6498 Do not assume that floating-point numbers represent EMACS_INT
6499 without losing information; this is not true on most 64-bit hosts.
6500 Avoid double-rounding errors, by insisting on integers when
6501 parsing non-base-10 numbers, as the documentation specifies.
6502 * lisp.h (string_to_number): New decl, replacing ...
6503 (isfloat_string): Remove.
bc0a5c13 6504 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6505 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6506 appears to have been a coding error. Similarly, do not accept
6507 strings like +-1e0 as floating point numbers. Do not report
6508 overflow for integer overflows unless the base is not 10 which
6509 means we have no simple and reliable way to continue.
6510 Break out the floating-point parsing into a new
6511 function string_to_number, so that Fstring_to_number parses
6512 floating point numbers consistently with the Lisp reader.
04f2d78b 6513 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6514 (E_CHAR, EXP_INT): Remove, replacing with ...
6515 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6516 (string_to_number): New function, replacing isfloat_string.
6517 This function checks for valid syntax and produces the resulting
6518 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6519 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6520 so that overflow for non-base-10 numbers is reported only when
6521 there's no portable and simple way to convert to floating point.
452f4150 6522
67769ffc
PE
6523 * textprop.c (set_text_properties_1): Rewrite for clarity,
6524 and to avoid GCC warning about integer overflow.
6525
c20db43f
PE
6526 * intervals.h (struct interval): Use EMACS_INT for members
6527 where EMACS_UINT might cause problems. See
6528 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6529 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6530 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6531 All uses changed.
37aa2f85
PE
6532 (offset_intervals): Tell GCC not to worry about length overflow
6533 when negating a negative length.
c20db43f 6534
2538aa2f
PE
6535 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6536 (overrun_check_free): Likewise.
6537
f2d3008d
PE
6538 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6539 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6540 word size.
6541
ec8df744
PE
6542 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6543 (gnutls_make_error): Rename local to avoid shadowing.
6544 (gnutls_emacs_global_deinit): ifdef out; not used.
6545 (Fgnutls_boot): Use const for pointer to readonly storage.
6546 Comment out unused local. Fix pointer signedness problems.
6547
640ee02d
PE
6548 * lread.c (openp): Don't stuff size_t into an 'int'.
6549 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6550 about possible signed overflow.
6551
6048fb2a
PE
6552 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6553 (GDK_KEY_g): Don't define if already defined.
6554 (xg_prepare_tooltip): Avoid pointer signedness problem.
6555 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6556
fa3c87e1
PE
6557 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6558 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6559
2172544b
PE
6560 * xfns.c (Fx_window_property): Simplify a bit,
6561 to make a bit faster and to avoid GCC 4.6.0 warning.
6562 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6563
9b821a21
PE
6564 * fns.c (internal_equal): Don't assume size_t fits in int.
6565
3c616cfa
PE
6566 * alloc.c (compact_small_strings): Tighten assertion a little.
6567
c2982e87
PE
6568 Replace pEd with more-general pI, and fix some printf arg casts.
6569 * lisp.h (pI): New macro, generalizing old pEd macro to other
6570 conversion specifiers. For example, use "...%"pI"d..." rather
6571 than "...%"pEd"...".
6572 (pEd): Remove. All uses replaced with similar uses of pI.
6573 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6574 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6575 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6576 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6577 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6578 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6579 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6580 64-bit hosts.
6581 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6582 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6583 * print.c (safe_debug_print, print_object): Likewise.
6584 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6585 to int.
6f04d126
PE
6586 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6587 avoiding the 0 flag, which is not portable.
c2982e87
PE
6588 * process.c (Fmake_network_process): Use pI to avoid cast.
6589 * region-cache.c (pp_cache): Likewise.
6590 * xdisp.c (decode_mode_spec): Likewise.
6591 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6592 behavior on 64-bit hosts with printf arg.
6f04d126 6593 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6594 (x_stop_queuing_selection_requests): Likewise.
6595 (x_get_window_property): Don't truncate byte count to an 'int'
6596 when tracing.
0b432f21 6597
5e073ec7
PE
6598 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6599 here, since it parses constructs like leading '-' and spaces,
6600 which are not wanted; and it overflows with large numbers.
6601 Instead, simply match F[0-9]+, which is what is wanted anyway.
6602
36372bf9
PE
6603 * alloc.c: Remove unportable assumptions about struct layout.
6604 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6605 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6606 (allocate_vectorlike, make_pure_vector): Use the new macros,
6607 plus offsetof, to remove unportable assumptions about struct layout.
6608 These assumptions hold on all porting targets that I know of, but
6609 they are not guaranteed, they're easy to remove, and removing them
6610 makes further changes easier.
6611
0b432f21
PE
6612 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6613 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6614 (string_overrun_cookie): Now const. Use initializers that
6615 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6616 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6617 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6618 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6619 multiple of sizeof (EMACS_INT); it need not be, if
6620 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6621 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6622
895009e1
JB
66232011-04-26 Juanma Barranquero <lekktu@gmail.com>
6624
6625 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6626
6a7a1b0b
TZ
66272011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6628
6629 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6630 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6631 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6632
841a1577 66332011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6634
6635 * lisp.h (Qdebug): List symbol.
895009e1 6636 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6637 * keyboard.c (debug-on-event): New variable.
6638 (handle_user_signal): Break into debugger when debug-on-event
6639 matches the current signal symbol.
6640
f2d3ba6f
DN
66412011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6642
6643 * alloc.c (check_sblock, check_string_bytes)
6644 (check_string_free_list): Convert to standard C.
6645
42ce4c63
TZ
66462011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6647
6648 * w32.c (emacs_gnutls_push): Fix typo.
6649
825cd63c
EZ
66502011-04-25 Eli Zaretskii <eliz@gnu.org>
6651
fb11d64d
EZ
6652 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6653 "cast to pointer from integer of different size".
6654
825cd63c
EZ
6655 Improve doprnt and its use in verror. (Bug#8545)
6656 * doprnt.c (doprnt): Document the set of format control sequences
6657 supported by the function. Use SAFE_ALLOCA instead of always
6658 using `alloca'.
6659
6660 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6661 is one byte too soon. Don't use xrealloc; instead xfree and
6662 xmalloc anew.
6663
e061a11b
TZ
66642011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6665
6666 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6667 callbacks stage.
6668
6669 * gnutls.c: Renamed global_initialized to
6670 gnutls_global_initialized. Added internals for the
6671 :verify-hostname-error, :verify-error, and :verify-flags
6672 parameters of `gnutls-boot' and documented those parameters in the
6673 docstring. Start callback support.
9173deec
JB
6674 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6675 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6676 on error. Return error code.
e061a11b
TZ
6677 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6678 (emacs_gnutls_read): Likewise.
6679 (Fgnutls_boot): Return handshake error code.
6680 (emacs_gnutls_handle_error): New function.
6681 (wsaerror_to_errno): Likewise.
6682
6683 * w32.h (emacs_gnutls_pull): Add prototype.
6684 (emacs_gnutls_push): Likewise.
6685
6686 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6687 (emacs_gnutls_push): Likewise.
6688
66892011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6690
6691 * process.c (wait_reading_process_output): Check if GnuTLS
6692 buffered some data internally if no FDs are set for TLS
6693 connections.
6694
6695 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6696 (LIBS): Link to USER_LIBS.
6697 ($(BLD)/gnutls.$(0)): New target.
6698
fa6996bc
EZ
66992011-04-24 Eli Zaretskii <eliz@gnu.org>
6700
eb35682e
EZ
6701 * xdisp.c (handle_single_display_spec): Rename the
6702 display_replaced_before_p argument into display_replaced_p, to
6703 make it consistent with the commentary. Fix typos in the
6704 commentary.
6705
e2ad650c
EZ
6706 * textprop.c (syms_of_textprop): Remove dead code.
6707 (copy_text_properties): Delete obsolete commentary about an
6708 interface that was deleted long ago. Fix typos in the description
6709 of arguments.
6710
1b2de274
EZ
6711 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6712 to changes in oldXMenu/XMenu.h from 2011-04-16.
6713 <menu_help_message, prev_menu_help_message>: Constify.
6714 (IT_menu_make_room): menu->help_text is now `const char **';
6715 adjust.
6716
6717 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6718 to changes in oldXMenu/XMenu.h from 2011-04-16.
6719 (struct XMenu): Declare `help_text' `const char **'.
6720
6721 * xfaces.c <Qunspecified>: Make extern again.
6722
6723 * syntax.c: Include sys/types.h before including regex.h, as
6724 required by Posix.
6725
762b15be
EZ
6726 * doc.c (get_doc_string): Improve the format passed to `error'.
6727
6728 * doprnt.c (doprnt): Improve commentary.
6729
6730 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6731
6732 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6733 them with etags.
6734
f1052e5d
EZ
6735 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6736 changes in globals.h immediately force recompilation.
762b15be
EZ
6737 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6738 $(CURDIR)/s/ms-w32.h.
6739 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6740
fa6996bc
EZ
6741 * character.c (Fchar_direction): Function deleted.
6742 (syms_of_character): Don't defsubr it.
6743 <char-direction-table>: Deleted.
6744
e6c3da20
EZ
67452011-04-23 Eli Zaretskii <eliz@gnu.org>
6746
6747 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6748 * doprnt.c: Include limits.h.
6749 (SIZE_MAX): New macro.
04f2d78b
CB
6750 (doprnt): Return a size_t value. 2nd arg is now size_t.
6751 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6752 Improve overflow protection. Support `l' modifier for integer
6753 conversions. Support %l conversion. Don't assume an EMACS_INT
6754 argument for integer conversions and for %c.
6755
6756 * lisp.h (doprnt): Restore prototype.
6757
6758 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6759 $(SRC)/character.h.
6760
6761 * Makefile.in (base_obj): Add back doprnt.o.
6762
6763 * deps.mk (doprnt.o): Add back prerequisites.
6764 (callint.o): Depend on character.h.
6765
6766 * eval.c (internal_lisp_condition_case): Include the handler
6767 representation in the error message.
6768 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6769 when breaking from the loop.
6770
6771 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6772
6773 * callint.c (Fcall_interactively): When displaying error message
6774 about invalid control letter, pass the character's codepoint, not
6775 a pointer to its multibyte form. Improve display of the character
6776 in octal and display also its hex code.
6777
6778 * character.c (char_string): Use %x to display the (unsigned)
6779 codepoint of an invalid character, to avoid displaying a bogus
6780 negative value.
6781
6782 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6783 `error', not SYMBOL_NAME itself.
6784
6785 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6786 character arguments to `error'.
6787
6788 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6789 to `error' in error message about FINAL_CHAR argument. Make sure
6790 FINAL_CHAR is a character, and use %c when it is passed as
6791 argument to `error'.
6792
4ffd0d6b 67932011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6794
6795 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6796
6797 * w32.c: Include <time.h>.
6798 (sys_localtime): New function.
6799
4ffd0d6b 68002011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6801
6802 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6803
4ffd0d6b 6804 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6805
4ffd0d6b 68062011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6807
4ffd0d6b
GM
6808 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6809 zombies (Bug#8467).
aac0c6e3 6810
04c56954
EZ
68112011-04-19 Eli Zaretskii <eliz@gnu.org>
6812
6813 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6814 gl_state.e_property when gl_state.object is Qt.
6815
6816 * insdel.c (make_gap_larger): Remove limitation of buffer size
6817 to <= INT_MAX.
6818
16a43933
CY
68192011-04-18 Chong Yidong <cyd@stupidchicken.com>
6820
6821 * xdisp.c (lookup_glyphless_char_display)
6822 (produce_glyphless_glyph): Handle cons cell entry in
6823 glyphless-char-display.
6824 (Vglyphless_char_display): Document it.
6825
6826 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6827 glyphless-char-display.
6828
4581706e
CY
68292011-04-17 Chong Yidong <cyd@stupidchicken.com>
6830
6831 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6832
6833 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6834
6835 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6836 definition for no-X builds.
6837
4887c6e2 68382011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6839
fd35b6f9
PE
6840 Static checks with GCC 4.6.0 and non-default toolkits.
6841
5c1ccb01
PE
6842 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6843
006c5daa
PE
6844 * process.c (keyboard_bit_set): Define only if SIGIO.
6845 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6846 (send_process): Repair possible setjmp clobbering.
6847
efc736d3
PE
6848 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6849
4e2fe2e6
PE
6850 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6851
f97334a2
PE
6852 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6853
4e75f29d
PE
6854 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6855 Define only if needed.
6856
90efadd1
PE
6857 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6858 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6859 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6860
3c647824
PE
6861 * dispextern.h (struct redisplay_interface): Rename param
6862 to avoid shadowing.
e264f262 6863 * termhooks.h (struct terminal): Likewise.
761383f4 6864 * xterm.c (xembed_send_message): Likewise.
3c647824 6865
b58c5c4a
PE
6866 * insdel.c (make_gap_smaller): Define only if
6867 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6868
cad59032
PE
6869 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6870 it.
6871
c339dc2e
PE
6872 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6873 so that we aren't warned about unused symbols.
6874
91a3e27b
PE
6875 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6876
399c71d3 6877 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6878
8ffc96f5
PE
6879 * xfns.c (x_real_positions): Mark locals as initialized.
6880
eef9bc79
PE
6881 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6882
098db9dd
PE
6883 * xterm.c: Fix problems found by static analysis with other toolkits.
6884 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6885 (x_dispatch_event): Declare static if USE_GTK, and
6886 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6887 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6888 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6889 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6890 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6891
eb18f6cc
PE
6892 * xmenu.c (menu_help_callback): Pointer type fixes.
6893 Use const pointers when pointing at readonly data. Avoid pointer
6894 signedness clashes.
6895 (FALSE): Remove unused macro.
6896 (update_frame_menubar): Remove unused decl.
6897
1fe72bf8
PE
6898 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6899
60d9e1db
PE
6900 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6901 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6902 (single_menu_item): Rename local to avoid shadowing.
6903
39261c26
PE
6904 * keyboard.c (make_lispy_event): Remove unused local var.
6905
018c5e19
PE
6906 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6907 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6908
63d2b86e
PE
6909 * bitmaps: Change bitmaps from unsigned char back to the X11
6910 compatible char. Avoid the old compiler warnings about
6911 out-of-range initializers by using, for example, '\xab' rather
6912 than 0xab.
6913
aefd87e1
PE
6914 * xgselect.c (xgselect_initialize): Check vs interface
6915 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6916
bf501fb9
PE
6917 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6918
e9829fdf
PE
6919 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6920 to read-only memory.
6921
1086c095
PE
6922 * fns.c (vector): Remove; this old hack is no longer needed.
6923
2baccd04 6924 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6925 Remove unused var.
dde42981 6926 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6927
72391843 6928 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6929
436c16df 6930 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6931 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6932 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6933
92bb796d 6934 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6935 (x_term_init): Remove local to avoid shadowing.
92bb796d 6936
764430a3 6937 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6938
6939 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6940 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6941
d1dfb56c
EZ
69422011-04-16 Eli Zaretskii <eliz@gnu.org>
6943
c4354cb4
EZ
6944 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6945
d1dfb56c
EZ
6946 Fix regex.c, syntax.c and friends for buffers > 2GB.
6947 * syntax.h (struct gl_state_s): Declare character position members
6948 EMACS_INT.
6949
6950 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6951
04f2d78b
CB
6952 * textprop.c (verify_interval_modification, interval_of):
6953 Declare arguments EMACS_INT.
d1dfb56c
EZ
6954
6955 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6956 EMACS_INT.
6957
6958 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6959
6960 * indent.c (Fvertical_motion): Local variable it_start is now
6961 EMACS_INT.
6962
6963 * regex.c (re_match, re_match_2, re_match_2_internal)
6964 (bcmp_translate, regcomp, regexec, print_double_string)
6965 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6966 (re_compile_pattern, re_exec): Declare arguments and local
6967 variables `size_t' and `ssize_t' and return values `regoff_t', as
6968 appropriate.
6969 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6970 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6971 <compile_stack_type>: `size' and `avail' are now `size_t'.
6972
6973 * regex.h <regoff_t>: Use ssize_t, not int.
6974 (re_search, re_search_2, re_match, re_match_2): Arguments that
6975 specify buffer/string position and length are now ssize_t and
6976 size_t. Return type is regoff_t.
6977
613052cd
BK
69782011-04-16 Ben Key <bkey76@gmail.com>
6979
6980 * nsfont.m: Fixed bugs in ns_get_family and
6981 ns_descriptor_to_entity that were caused by using free to
6982 deallocate memory blocks that were allocated by xmalloc (via
6983 xstrdup). This caused Emacs to crash when compiled with
6984 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6985 --enable-checking=xmallocoverrun). xfree is now used to
6986 deallocate these memory blocks.
6987
4170f62f 69882011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6989
71b41406
PE
6990 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6991
9587a89d
PE
6992 emacs_write: Accept and return EMACS_INT for sizes.
6993 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6994 et seq.
6995 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6996 Accept and return EMACS_INT.
6997 (emacs_gnutls_write): Return the number of bytes written on
6998 partial writes.
6999 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7000 (emacs_read, emacs_write): Remove check for negative size, as the
7001 Emacs source code has been audited now.
9587a89d
PE
7002 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7003 (emacs_read, emacs_write): Use it.
273a5f82
PE
7004 * process.c (send_process): Adjust to the new signatures of
7005 emacs_write and emacs_gnutls_write. Do not attempt to store
7006 a byte offset into an 'int'; it might overflow.
9587a89d 7007 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7008
3e047f51
PE
7009 * sound.c: Don't assume sizes fit in 'int'.
7010 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7011 Return EMACS_INT, not int.
3e047f51 7012 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7013 Accept EMACS_INT, not int.
7014 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7015 record read return values.
7016
cc39a9db
BK
70172011-04-15 Ben Key <bkey76@gmail.com>
7018
c9d0ec6d
JB
7019 * keyboard.c (Qundefined): Don't declare static since it is used
7020 in nsfns.m.
7021 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7022 static since they are used in nsfont.m.
cc39a9db 7023
6c60eb9f
SM
70242011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7025
7026 * process.c (Qprocessp): Don't declare static.
7027 * lisp.h (Qprocessp): Declare again.
7028
7990b61a
JB
70292011-04-15 Juanma Barranquero <lekktu@gmail.com>
7030
7031 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7032
5d4cb038
PE
70332011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7034
8bd7b830 7035 Improve C-level modularity by making more things 'static'.
cd64ea1d 7036
e3b27b31
PE
7037 Don't publish debugger-only interfaces to other modules.
7038 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7039 (verify_bytepos, count_markers): Move decls to the only modules
7040 that need them.
7041 * region-cache.h (pp_cache): Likewise.
7042 * window.h (check_all_windows): Likewise.
7043 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7044
5d4cb038
PE
7045 * sysdep.c (croak): Now static, if
7046 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7047 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7048
7049 * alloc.c (refill_memory_reserve): Now static if
7050 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7051 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7052
e87b6180
PE
7053 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7054 Define only if USE_LUCID.
7055
ac64929e
PE
7056 * xrdb.c (x_customization_string, x_rm_string): Now static.
7057
6f37259d
PE
7058 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7059 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7060
1683e3ab
PE
7061 * xdisp.c (draw_row_with_mouse_face): Now static.
7062 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7063
de9c2632
PE
7064 * window.h (check_all_windows): Mark externally visible.
7065
2b96acb7
PE
7066 * window.c (window_deletion_count): Now static.
7067
7068 * undo.c: Make symbols static if they're not exported.
7069 (last_undo_buffer, last_boundary_position, pending_boundary):
7070 Now static.
7071
50436f33
PE
7072 * textprop.c (interval_insert_behind_hooks): Now static.
7073 (interval_insert_in_front_hooks): Likewise.
7074
64520e5c
PE
7075 * term.c: Make symbols static if they're not exported.
7076 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7077 (max_frame_lines, tty_set_terminal_modes):
7078 (tty_reset_terminal_modes, tty_turn_off_highlight):
7079 (get_tty_terminal): Now static.
7080 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7081 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7082 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7083 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7084 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7085
1fa53021
PE
7086 * sysdep.c: Make symbols static if they're not exported.
7087 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7088 Now static.
7089 (sigprocmask_set, full_mask): Remove; unused.
7090 (wait_debugging): Mark as visible.
7091 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7092 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7093
d4b43b22
PE
7094 * syntax.c (syntax_temp): Define only if !__GNUC__.
7095
b7c513d0
PE
7096 * sound.c (current_sound_device, current_sound): Now static.
7097
989b29ad
PE
7098 * search.c (searchbufs, searchbuf_head): Now static.
7099
13a55a78
PE
7100 * scroll.c (scroll_cost): Remove; unused.
7101 * dispextern.h (scroll_cost): Remove decl.
7102
de68a1fc
PE
7103 * region-cache.h (pp_cache): Mark as externally visible.
7104
40ccffa6
PE
7105 * process.c: Make symbols static if they're not exported.
7106 (process_tick, update_tick, create_process, chan_process):
7107 (Vprocess_alist, proc_buffered_char, datagram_access):
7108 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7109 (deactivate_process): Mark defn as static, as well as decl.
7110 * lisp.h (create_process): Remove decl.
7111 * process.h (chan_process, Vprocess_alist): Remove decls.
7112
ad64fc97
PE
7113 * print.c: Make symbols static if they're not exported.
7114 (print_depth, new_backquote_output, being_printed, print_buffer):
7115 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7116 (print_interval, print_number_index, initial_stderr_stream):
7117 Now static.
7118 * lisp.h (Fprinc): Remove decl.
7119 (debug_output_compilation_hack): Mark as externally visible.
7120
adddb265
PE
7121 * sysdep.c (croak): Move decl from here to syssignal.h.
7122 * syssignal.h (croak): Put it here, so the API can be checked when
7123 'croak' is called from dissociate_if_controlling_tty.
7124
1717ede2
PE
7125 * minibuf.c: Make symbols static if they're not exported.
7126 (minibuf_save_list, choose_minibuf_frame): Now static.
7127 * lisp.h (choose_minibuf_frame): Remove decl.
7128
fa5fb2bc
PE
7129 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7130
1e3890d1
PE
7131 * lread.c: Make symbols static if they're not exported.
7132 (read_objects, initial_obarray, oblookup_last_bucket_number):
7133 Now static.
7134 (make_symbol): Remove; unused.
7135 * lisp.h (initial_obarray, make_symbol): Remove decls.
7136
8a1414fa
PE
7137 * keyboard.c: Make symbols static if they're not exported.
7138 (single_kboard, recent_keys_index, total_keys, recent_keys):
7139 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7140 (this_single_command_key_start, echoing, last_auto_save):
7141 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7142 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7143 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7144 (Vlispy_mouse_stem, double_click_count):
7145 Now static.
7146 (force_auto_save_soon): Define only if SIGDANGER.
7147 (ignore_mouse_drag_p): Now static if
7148 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7149 (print_help): Remove; unused.
7150 (stop_character, last_timer_event): Mark as externally visible.
7151 * keyboard.h (ignore_mouse_drag_p): Declare only if
7152 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7153 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7154 * lisp.h (echoing): Remove decl.
7155 (force_auto_save_soon): Declare only if SIGDANGER.
7156 * xdisp.c (redisplay_window): Simplify code, to make it more
7157 obvious that ignore_mouse_drag_p is not accessed if !defined
7158 USE_GTK && !defined HAVE_NS.
7159
93ea6e8f
PE
7160 * intervals.c: Make symbols static if they're not exported.
7161 (merge_properties_sticky, merge_interval_right, delete_interval):
7162 Now static.
7163 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7164
77382fcc
PE
7165 * insdel.c: Make symbols static if they're not exported.
7166 However, leave prepare_to_modify_buffer alone. It's never
7167 called from outside this function, but that appears to be a bug.
7168 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7169 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7170 (adjust_after_replace_noundo): Remove; unused.
7171 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7172 (signal_before_change): Remove decls.
77382fcc 7173
9306c32e
PE
7174 * indent.c (val_compute_motion, val_vmotion): Now static.
7175
cd44d2eb
PE
7176 * image.c: Make symbols static if they're not exported.
7177 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7178 if USE_GTK.
7179 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7180 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7181
ad9a7a06
PE
7182 * fringe.c (standard_bitmaps): Now static.
7183 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7184
81626931
PE
7185 * frame.c: Make symbols static if they're not exported.
7186 (x_report_frame_params, make_terminal_frame): Now static.
7187 (get_frame_param): Now static, unless HAVE_NS.
7188 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7189 (x_get_resource_string): Remove; not used.
7190 * frame.h (make_terminal_frame, x_report_frame_params):
7191 (x_get_resource_string); Remove decls.
7192 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7193 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7194
239f9db9
PE
7195 * font.c, fontset.c: Make symbols static if they're not exported.
7196 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7197 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7198 * font.c (font_close_object): Now static.
7199 * font.h (font_close_object): Remove.
7200 * fontset.c (FONTSET_OBJLIST): Remove.
7201 (free_realized_fontset) #if-0 the body, which does nothing.
7202 (face_suitable_for_char_p): #if-0, as it's never called.
7203 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7204 * xfaces.c (face_at_string_position):
7205 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7206 since 0 is always ASCII.
7207
dfcf3579
PE
7208 * fns.c (weak_hash_tables): Now static.
7209
5045092b
PE
7210 * fileio.c: Make symbols static if they're not exported.
7211 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7212 (Vwrite_region_annotation_buffers): Now static.
7213
57a96f5c
PE
7214 * eval.c: Make symbols static if they're not exported.
7215 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7216 * lisp.h (backtrace_list): Remove decl.
7217
35f08c38
PE
7218 * emacs.c: Make symbols static if they're not exported.
7219 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7220 (fatal_error_code, fatal_error_signal_hook, standard_args):
7221 Now static.
7222 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7223 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7224 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7225 * lisp.h (fatal_error_signal_hook): Remove decl.
7226 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7227
f44bd759
PE
7228 * editfns.c: Move a (normally-unused) function to its only use.
7229 * editfns.c, lisp.h (get_operating_system_release): Remove.
7230 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7231 worth the hassle of breaking this out.
7232
b532497d
PE
7233 * xterm.c: Make symbols static if they're not exported.
7234 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7235 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7236 (x_destroy_window, x_delete_display):
7237 Now static.
7238 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7239 (x_mouse_leave): Remove; unused.
7240 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7241 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7242 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7243 Remove decls.
7244 (x_mouse_leave): Declare only if WINDOWSNT.
7245 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7246 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7247 USE_X_TOOLKIT.
7248
1675728f
PE
7249 * ftxfont.c: Make symbols static if they're not exported.
7250 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7251 HAVE_FREETYPE.
7252 * font.h (ftxfont_driver): Likewise.
7253
e4cebfca
PE
7254 * xfns.c: Make symbols static if they're not exported.
7255 (x_last_font_name, x_display_info_for_name):
7256 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7257 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7258 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7259 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7260 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7261 (last_show_tip_args): Now static.
7262 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7263 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7264 (x_screen_planes): Remove; unused.
7265 * dispextern.h (x_screen_planes): Remove decl.
7266
5bf46f05
PE
7267 * dispnew.c: Make symbols static if they're not exported.
7268 * dispextern.h (redraw_garbaged_frames, scrolling):
7269 (increment_row_positions): Remove.
7270 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7271 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7272 Now static.
7273 (redraw_garbaged_frames): Remove; unused.
7274
435f4c28
PE
7275 * xfaces.c: Make symbols static if they're not exported.
7276 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7277 Remove decls.
7278 * xterm.h (defined_color): Remove decls.
7279 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7280 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7281 (menu_face_changed_default, defined_color, free_realized_face):
7282 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7283 (ascii_face_of_lisp_face): Remove; unused.
7284
8524aef3
PE
7285 * xdisp.c: Make symbols static if they're not exported.
7286 * dispextern.h (scratch_glyph_row, window_box_edges):
7287 (glyph_to_pixel_coords, set_cursor_from_row):
7288 (get_next_display_element, set_iterator_to_next):
7289 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7290 (show_mouse_face): Remove decls
7291 * frame.h (message_buf_print): Likewise.
7292 * lisp.h (pop_message, set_message, check_point_in_composition):
7293 Likewise.
7294 * xterm.h (set_vertical_scroll_bar): Likewise.
7295 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7296 (message_buf_print, scratch_glyph_row, displayed_buffer):
7297 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7298 (get_next_display_element, show_mouse_face, window_box_edges):
7299 (frame_to_window_pixel_xy, check_point_in_composition):
7300 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7301 (glyph_to_pixel_coords): Remove; unused.
7302
16390cd2
PE
7303 * dired.c (file_name_completion): Now static.
7304
7305 * dbusbind.c (xd_in_read_queued_messages): Now static.
7306
a25f4dfa
PE
7307 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7308 * data.c (circular_list_error): Remove.
7309
14a9c8df
PE
7310 * commands.h (last_point_position, last_point_position_buffer):
7311 (last_point_position_window): Remove decls.
7312 * keyboard.c: Make these variables static.
7313
04f2d78b
CB
7314 * coding.h (coding, code_convert_region, encode_coding_gap):
7315 Remove decls.
74ab6df5
PE
7316 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7317 (iso_code_class, detect_coding, code_convert_region): Now static.
7318 (encode_coding_gap): Remove; unused.
7319
38dfbee1
PE
7320 * chartab.c (chartab_chars, chartab_bits): Now static.
7321
a2cb4e63
PE
7322 * charset.h (charset_iso_8859_1): Remove decl.
7323 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7324 Now static.
7325
127198fd
PE
7326 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7327 * ccl.c (Vccl_program_table): Now static.
7328 (check_ccl_update): Remove; unused.
7329
d85b608f
PE
7330 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7331 * category.h: ... from here.
7332 * category.c (check_category_table, set_category_set): Now static.
7333
31cd66f3
PE
7334 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7335 * lisp.h: Remove these decls.
7336
c358e587
PE
7337 * buffer.c (buffer_count): Remove unused var.
7338
e78aecca
PE
7339 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7340 so that it's not optimized away.
7341 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7342 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7343 exported only to the debugger.
7344
e192d7d3 7345 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7346 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7347
92470028
PE
7348 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7349 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7350 was inaccessible from Lisp.
7351 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7352 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7353
244ed907
PE
7354 alloc.c: Import and export fewer symbols, and remove unused items.
7355 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7356 is defined.
7357 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7358 it's not optimized away by whole-program optimization.
7359 (message_enable_multibyte, free_misc): Remove.
7360 (catchlist, handlerlist, mark_backtrace):
7361 Declare only if BYTE_MARK_STACK.
7362 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7363 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7364 (message_enable_multibyte): Remove decl.
7365 (free_misc, interval_free_list, float_block, float_block_index):
7366 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7367 (cons_free_list, last_marked_index):
7368 Now static.
7369 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7370 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7371 (mark_backtrace): Define only if BYTE_MARK_STACK.
7372 * xdisp.c (message_enable_multibyte): Now static.
7373
61c2b50e 7374 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7375 This makes it easier for human readers (and static analyzers)
7376 to see whether these variables are used from other modules.
7377 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7378 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7379 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7380 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7381 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7382 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7383 * xmenu.c, xselect.c:
7384 Declare Q* vars static if they are not used in other modules.
7385 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7386 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7387 Remove decls of unexported vars.
7388 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7389
95c82688
PE
7390 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7391
16a97296
PE
7392 Make Emacs functions such as Fatom 'static' by default.
7393 This makes it easier for human readers (and static analyzers)
7394 to see whether these functions can be called from other modules.
7395 DEFUN now defines a static function. To make the function external
7396 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7397 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7398 (Finit_image_library):
16a97296
PE
7399 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7400 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7401 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7402 Remove decls, since these functions are now static.
7403 (Funintern, Fget_internal_run_time): New decls, since these functions
7404 were already external.
95c82688 7405
16a97296
PE
7406 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7407 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7408 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7409 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7410 * keyboard.c, keymap.c, lread.c:
7411 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7412 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7413 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7414 Mark functions with DEFUE instead of DEFUN,
7415 if they are used in other modules.
7416 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7417 decls for now-static functions.
7418 * buffer.h (Fdelete_overlay): Remove decl.
7419 * callproc.c (Fgetenv_internal): Mark as internal.
7420 * composite.c (Fremove_list_of_text_properties): Remove decl.
7421 (Fcomposition_get_gstring): New forward static decl.
7422 * composite.h (Fcomposite_get_gstring): Remove decl.
7423 * dired.c (Ffile_attributes): New forward static decl.
7424 * doc.c (Fdocumntation_property): New forward static decl.
7425 * eval.c (Ffetch_bytecode): New forward static decl.
7426 (Funintern): Remove extern decl; now in .h file where it belongs.
7427 * fileio.c (Fmake_symbolic_link): New forward static decl.
7428 * image.c (Finit_image_library): New forward static decl.
7429 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7430 * intervals.h (Fprevious_property_change):
7431 (Fremove_list_of_text_properties): Remove decls.
7432 * keyboard.c (Fthis_command_keys): Remove decl.
7433 (Fcommand_execute): New forward static decl.
7434 * keymap.c (Flookup_key): New forward static decl.
7435 (Fcopy_keymap): Now static.
7436 * keymap.h (Flookup_key): Remove decl.
7437 * process.c (Fget_process): New forward static decl.
7438 (Fprocess_datagram_address): Mark as internal.
7439 * syntax.c (Fsyntax_table_p): New forward static decl.
7440 (skip_chars): Remove duplicate decl.
7441 * textprop.c (Fprevious_property_change): New forward static decl.
7442 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7443 Now internal.
7444 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7445 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7446
785bbd42
PE
7447 * editfns.c (Fformat): Remove unreachable code.
7448
8b913b57
AS
74492011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7450
7451 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7452 change. (Bug#8496)
7453
a6744a35
EZ
74542011-04-13 Eli Zaretskii <eliz@gnu.org>
7455
7456 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7457 when at ZV. (Bug#8487)
7458
e7974947
AS
74592011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7460
baad03f0
AS
7461 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7462 (Bug#8437)
7463 * keyboard.c (parse_tool_bar_item): Likewise.
7464 * sound.c (sound_cleanup, alsa_close): Likewise.
7465 * termcap.c (tgetent): Likewise.
7466 * xfns.c (x_default_font_parameter): Likewise.
7467 * xsettings.c (read_and_apply_settings): Likewise.
7468
e7974947
AS
7469 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7470 (overrun_check_free): Protoize.
7471
28272684
PE
74722011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7473
7474 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7475 since callers should never pass a negative size.
7476 Change the signature to match that of plain 'read' and 'write'; see
7477 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7478 * lisp.h: Update prototypes of emacs_write and emacs_read.
7479
11997c76
EZ
74802011-04-11 Eli Zaretskii <eliz@gnu.org>
7481
7482 * xdisp.c (redisplay_window): Don't try to determine the character
7483 position of the scroll margin if the window start point w->startp
e896f03c 7484 is outside the buffer's accessible region. (Bug#8468)
11997c76 7485
8a2cbd72
EZ
74862011-04-10 Eli Zaretskii <eliz@gnu.org>
7487
7488 Fix write-region and its subroutines for buffers > 2GB.
7489 * fileio.c (a_write, e_write): Modify declaration of arguments and
7490 local variables to support buffers larger than 2GB.
7491 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7492
7493 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7494 argument, local variables, and return value.
7495
7496 * lisp.h: Update prototypes of emacs_write and emacs_read.
7497
7498 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7499
4073e537 75002011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7501
1ebfdcb6
PE
7502 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7503
b2ded58d
PE
7504 Fix more problems found by GCC 4.6.0's static checks.
7505
7d66342c
PE
7506 * xdisp.c (vmessage): Use a better test for character truncation.
7507
bbf47d44
PE
7508 * charset.c (load_charset_map): <, not <=, for optimization,
7509 and to avoid potential problems with integer overflow.
9248994d 7510 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7511 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7512 * editfns.c (Fformat): Likewise.
1e69125e 7513 * syntax.c (skip_chars): Likewise.
3befa583 7514
e3019616
PE
7515 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7516 This also lets GCC 4.6.0 generate slightly better loop code.
7517
becfa255
PE
7518 * callint.c (Fcall_interactively): <, not <=, for optimization.
7519 (Fcall_interactively): Count the number of arguments produced,
7520 not the number of arguments given. This is simpler and lets GCC
7521 4.6.0 generate slightly better code.
7522
dae0cd48
PE
7523 * ftfont.c: Distingish more carefully between FcChar8 and char.
7524 The previous code passed unsigned char * to a functions like
7525 strlen and xstrcasecmp that expect char *, which does not
7526 conform to the C standard.
7527 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7528 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7529 char * when the C standard requires it.
7530
76032d70
PE
7531 * keyboard.c (read_char): Remove unused var.
7532
eb3f1cc8
PE
7533 * eval.c: Port to Windows vsnprintf (Bug#8435).
7534 Include <limits.h>.
7535 (SIZE_MAX): Define if the headers do not.
7536 (verror): Do not give up if vsnprintf returns a negative count.
7537 Instead, grow the buffer. This ports to Windows vsnprintf, which
7538 does not conform to C99. Problem reported by Eli Zaretskii.
7539 Also, simplify the allocation scheme, by avoiding the need for
7540 calling realloc, and removing the ALLOCATED variable.
7541
70476b54
PE
7542 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7543
12020a9e
PE
7544 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7545 But keep the doprint source code for now, as we might revamp it
7546 and use it again (Bug#8435).
ea6c7ae6
PE
7547 * lisp.h (doprnt): Remove.
7548 * Makefile.in (base_obj): Remove doprnt.o.
7549 * deps.mk (doprnt.o): Remove.
7550
5fdb398c
PE
7551 error: Print 32- and 64-bit integers portably (Bug#8435).
7552 Without this change, on typical 64-bit hosts error ("...%d...", N)
7553 was used to print both 32- and 64-bit integers N, which relied on
7554 undefined behavior.
7555 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7556 New macro.
7557 * lisp.h (error, verror): Mark as printf-like functions.
7558 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7559 Report overflow in size calculations when allocating printf buffer.
7560 Do not truncate output string at its first null byte.
7561 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7562 Truncate the output at a character boundary, since vsnprintf does not
7563 do that.
7564 * charset.c (check_iso_charset_parameter): Convert internal
7565 character to string before calling 'error', since %c now has the
7566 printf meaning.
7567 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7568 overflow when computing char to be passed to 'error'. Do not
7569 pass Lisp_Object to 'error'; pass the integer instead.
7570 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7571 formatted with plain %d.
7572
b189fa66
PE
7573 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7574
bff87ef0
PE
7575 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7576
7e2cac20
PE
7577 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7578
ce4d90b5
PE
7579 * xterm.c (x_catch_errors): Remove duplicate declaration.
7580
266c9547
PE
7581 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7582
79c49ad2
PE
7583 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7584
368f4090
JM
75852011-04-10 Jim Meyering <meyering@redhat.com>
7586
7587 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7588 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7589 return ssize_t not "int", and use size_t as the buffer length.
7590 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7591 * gnutls.h: Update declarations.
7592 * process.c (read_process_output): Use ssize_t, to match.
7593 (send_process): Likewise.
7594
a32d4040
CY
75952011-04-09 Chong Yidong <cyd@stupidchicken.com>
7596
7597 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7598
8546720e 75992011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7600
04f2d78b
CB
7601 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7602 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7603
8546720e
GM
7604 * xterm.c (handle_one_xevent):
7605 * xmenu.c (create_and_show_popup_menu):
7606 * xselect.c (x_decline_selection_request)
7607 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7608
0a2f5c1a 76092011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7610
7611 Fix some uses of `int' instead of EMACS_INT.
7612 * search.c (string_match_1, fast_string_match)
7613 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7614 (scan_buffer, find_next_newline_no_quit)
7615 (find_before_next_newline, search_command, Freplace_match)
7616 (Fmatch_data): Make some `int' variables be EMACS_INT.
7617
7618 * xdisp.c (display_count_lines): 3rd argument and return value now
7619 EMACS_INT. All callers changed.
7620 (pint2hrstr): Last argument is now EMACS_INT.
7621
7622 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7623 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7624 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7625 (decode_coding_utf_16, decode_coding_emacs_mule)
7626 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7627 (decode_coding_ccl, decode_coding_charset)
7628 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7629 (decode_coding_iso_2022, decode_coding_emacs_mule)
7630 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7631 <char_offset, last_offset>: Declare EMACS_INT.
7632 (encode_coding_utf_8, encode_coding_utf_16)
7633 (encode_coding_emacs_mule, encode_invocation_designation)
7634 (encode_designation_at_bol, encode_coding_iso_2022)
7635 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7636 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7637 Declare EMACS_INT.
7638 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7639 (encode_invocation_designation): Last argument P_NCHARS is now
7640 EMACS_INT.
7641 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7642 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7643
7644 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7645 All users changed.
7646
7647 * ccl.c (Fccl_execute_on_string): Declare some variables
7648 EMACS_INT.
7649
8546720e 76502011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7651
7652 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7653
4e19a977
CS
76542011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7655
7656 * process.c (Fformat_network_address): Doc fix.
7657
87302331
R
76582011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7659
ee7683eb 7660 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7661
cbb59342
CY
76622011-04-08 Chong Yidong <cyd@stupidchicken.com>
7663
7664 * keyboard.c (read_char): Call Lisp function help-form-show,
7665 instead of using internal_with_output_to_temp_buffer.
7666 (Qhelp_form_show): New var.
e0d38eeb 7667 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7668
7669 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7670
7671 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7672
e67a13ab
CY
76732011-04-06 Chong Yidong <cyd@stupidchicken.com>
7674
04f2d78b
CB
7675 * process.c (Flist_processes): Remove to Lisp.
7676 (list_processes_1): Delete.
e67a13ab 7677
973f782d
EZ
76782011-04-06 Eli Zaretskii <eliz@gnu.org>
7679
7c106b1e
EZ
7680 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7681
973f782d
EZ
7682 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7683
41cf7d1a 76842011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7685
ca23cc88
PE
7686 Fix more problems found by GCC 4.6.0's static checks.
7687
f390e2d5
PE
7688 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7689
42eea0d0
PE
7690 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7691
b69769da 7692 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7693
f9541e84
PE
7694 * xdisp.c (vmessage): Mark as a printf-like function.
7695
13841b55
PE
7696 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7697
c136c10f
PE
7698 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7699
5e2d4a30
PE
7700 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7701 printf-like functions.
7702 (tiff_load): Add casts to remove these marks before passing them
7703 to system-supplied API.
7704
583f48b9
PE
7705 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7706
b25d760e
PE
7707 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7708 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7709 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7710 directly, rather than having caller test rule sign. This avoids
7711 some unnecessary tests.
7712 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7713 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7714 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7715
bc7b6697 7716 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7717 (xfont_open): Avoid unnecessary tests.
bc7b6697 7718
27ccc379
PE
7719 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7720
dcd5c89a
PE
7721 * composite.h, composite.c (composition_gstring_put_cache):
7722 Use EMACS_INT, not int, for length.
7723
b13a45c6
PE
7724 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7725 breaking out part of COMPOSITION_DECODE_RULE.
7726 (COMPOSITION_DECODE_RULE): Use it.
7727 * composite.c (get_composition_id): Remove unused local vars,
7728 by using the new macro.
7729
1e792e4d
PE
7730 * textprop.c (set_text_properties_1): Change while to do-while,
7731 since the condition is always true at first.
7732
dc6c6455 7733 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7734 (interval_deletion_adjustment): Return unsigned value.
7735 All uses changed.
dc6c6455 7736
aba7731a
PE
7737 * process.c (list_processes_1, create_pty, read_process_output):
7738 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7739 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7740 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7741 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7742 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7743
fdfc4bf3
PE
7744 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7745
fca8fe46 7746 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7747 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7748
06a0259a 7749 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7750 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7751 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7752
e7b9e80f
PE
7753 * print.c (print_error_message): Avoid int overflow.
7754
56201685
PE
7755 * font.c (font_list_entities): Redo for clarity,
7756 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7757
78834453 7758 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7759 (font_score): Avoid potential overflow in diff calculation.
78834453 7760
0bc0b309 7761 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7762 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7763
e610eaca
PE
7764 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7765
b895abce
PE
7766 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7767 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7768 can always succeed if overflow has undefined behavior.
7769
1f1d9321 7770 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7771 (wordify): Omit three unnecessary tests.
1f1d9321 7772
c59478bc
PE
7773 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7774 All callers changed. This avoids the need for an unused var.
7775
79b73827
PE
7776 * casefiddle.c (casify_region): Remove var that is set but not used.
7777
a4db5dfe
PE
7778 * dired.c (file_name_completion): Remove var that is set but not used.
7779
43aae36e
PE
7780 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7781
2a47c44d 7782 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7783 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7784
a37c69bf
PE
7785 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7786 Check for integer overflow on size calculations.
7787
328ab8e7
PE
7788 * buffer.c (Fprevious_overlay_change): Remove var that is set
7789 but not used.
7790
e5a2a5cb
PE
7791 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7792 Remove vars that are set but not used.
8d84a6eb 7793 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7794 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7795
a60e5f68
PE
7796 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7797
f661cb61 7798 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7799 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7800
f0397f5a
PE
7801 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7802 that are set but not used.
7803
8664db06 7804 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7805 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7806
6abdaa4a
PE
7807 * xselect.c (x_get_local_selection, x_handle_property_notify):
7808 Remove vars that are set but not used.
7809
0ce7538d 7810 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7811 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7812
9ae848fc
PE
7813 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7814 Remove var that is set but not used.
0b918413
PE
7815 (scroll_bar_windows_size): Now size_t, not int.
7816 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7817 Check for overflow.
9ae848fc 7818
a5a62657
PE
7819 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7820 (map_tty_color) [!defined MSDOS]: Likewise.
7821
5c5cdd39
PE
7822 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7823
66ebf983
PE
7824 * coding.c: Remove vars that are set but not used.
7825 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7826 All callers changed.
7827 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7828 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7829 (decode_coding_charset): Remove vars that are set but not used.
7830
1be4d761
PE
7831 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7832 that is set but not used.
7833
47553fa8
PE
7834 * print.c (print_object): Remove var that is set but not used.
7835
1f7196bf 7836 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7837 The gnulib version avoids calling malloc in the usual case,
7838 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7839 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7840 * filelock.c (current_lock_owner): Likewise.
7841 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7842 * sysdep.c: Include allocator.h, careadlinkat.h.
7843 (emacs_no_realloc_allocator): New static constant.
7844 (emacs_readlink): New function.
fdb61804
PE
7845 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7846 ../lib/careadlinkat.h.
d1fdcab7 7847
f84c17c7
SM
78482011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7849
7850 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7851 first non-nil return value).
7852
ef3862ad
JD
78532011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7854
7855 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7856 if not defined (Bug#8403).
7857
376a7006
JB
78582011-04-02 Juanma Barranquero <lekktu@gmail.com>
7859
7860 * xdisp.c (display_count_lines): Remove parameter `start',
7861 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7862 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7863 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7864 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7865 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7866 and thereabouts. All callers changed.
7867 (get_per_char_metric): Remove parameter `f', unused since
7868 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7869
6ca3801d
JM
78702011-04-02 Jim Meyering <meyering@redhat.com>
7871
7872 do not dereference NULL upon failed strdup
7873 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7874 (ns_get_family): Likewise.
7875
d8e2b5ba
JB
78762011-04-02 Juanma Barranquero <lekktu@gmail.com>
7877
7878 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7879
8c74fcbd
JD
78802011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7881
7882 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7883 later (Bug#8403).
7884
7200d79c
SM
78852011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7886
03408648 7887 Add lexical binding.
7200d79c 7888
03408648
SM
7889 * window.c (Ftemp_output_buffer_show): New fun.
7890 (Fsave_window_excursion):
7891 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7892
7893 * lread.c (lisp_file_lexically_bound_p): New function.
7894 (Fload): Bind Qlexical_binding.
7895 (readevalloop): Remove `evalfun' arg.
7896 Bind Qinternal_interpreter_environment.
7897 (Feval_buffer): Bind Qlexical_binding.
7898 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7899 Mark as dynamic.
7900 (syms_of_lread): Declare `lexical-binding'.
7901
7902 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7903
7904 * keyboard.c (eval_dyn): New fun.
7905 (menu_item_eval_property): Use it.
ca105506
SM
7906
7907 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7908
03408648
SM
7909 * fns.c (concat, mapcar1): Accept byte-code-functions.
7910
7911 * eval.c (Fsetq): Handle lexical vars.
7912 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7913 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7914 (FletX, Flet): Obey lexical binding.
7915 (Fcommandp): Handle closures.
7916 (Feval): New `lexical' arg.
7917 (eval_sub): New function extracted from Feval. Use it almost
7918 everywhere where Feval was used. Look up vars in lexical env.
7919 Handle closures.
7920 (Ffunctionp): Move from subr.el.
7921 (Ffuncall): Handle closures.
7922 (apply_lambda): Remove `eval_flags'.
7923 (funcall_lambda): Handle closures and new byte-code-functions.
7924 (Fspecial_variable_p): New function.
7925 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7926 but without exporting it to Lisp.
23aba0ea 7927
23aba0ea 7928 * doc.c (Fdocumentation, store_function_docstring):
03408648 7929 * data.c (Finteractive_form): Handle closures.
23aba0ea 7930
03408648
SM
7931 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7932 interactive spec.
ba83908c 7933
04f2d78b
CB
7934 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7935 New byte-codes.
03408648
SM
7936 (exec_byte_code): New function extracted from Fbyte_code to handle new
7937 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7938
03408648 7939 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7940
03408648 7941 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7942
e2abce01
JB
79432011-03-31 Juanma Barranquero <lekktu@gmail.com>
7944
7945 * xdisp.c (redisplay_internal): Fix prototype.
7946
63696a73 79472011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7948
63696a73 7949 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7950 (try_scrolling): Use it when setting scroll_limit.
7951 Limit scrolling to 100 screen lines.
63696a73
EZ
7952 (redisplay_window): Even when falling back on "recentering",
7953 position point in the window according to scroll-conservatively,
7954 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7955
7956 (try_scrolling): When point is above the window, allow searching
7957 as far as scroll_max, or one screenful, to compute vertical
7958 distance from PT to the scroll margin position. This prevents
7959 try_scrolling from unnecessarily failing when
7960 scroll-conservatively is set to a value slightly larger than the
7961 window height. Clean up the case of PT below the margin at bottom
7962 of window: scroll_max can no longer be INT_MAX. When aggressive
7963 scrolling is in use, don't let point enter the opposite scroll
7964 margin as result of the scroll.
7965 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7966 threshold of 100 lines for never-recentering scrolling.
7967
e4cc2dfc
JB
79682011-03-31 Juanma Barranquero <lekktu@gmail.com>
7969
7970 * dispextern.h (move_it_by_lines):
7971 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7972 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7973 (message_log_check_duplicate): Remove parameters `prev_bol' and
7974 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7975 (redisplay_internal): Remove parameter `preserve_echo_area',
7976 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7977
7978 * indent.c (Fvertical_motion):
7979 * window.c (window_scroll_pixel_based, Frecenter):
7980 Don't pass `need_y_p' to `move_it_by_lines'.
7981
1c470562
SM
79822011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7983
44f230aa
SM
7984 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7985 steal a few bits to be more compact.
7986 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7987 Remove unneeded casts.
7988
1c470562
SM
7989 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7990
888adce9
ZK
79912011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7992
7993 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7994 binding" message (bug#7967).
7995
f838ed7b
PE
79962011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7997
77861b95
PE
7998 Fix more problems found by GCC 4.6.0's static checks.
7999
de6dbc14
PE
8000 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8001 Remove unused local var.
8002
f838ed7b
PE
8003 * editfns.c (Fmessage_box): Remove unused local var.
8004
792c7b2b
PE
8005 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8006 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8007 Omit unused local vars.
c499e557 8008 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8009 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8010 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8011 Omit unused local var.
8012
ba0165e1
PE
8013 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8014 Don't assume string length fits in int.
32ad8845 8015 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8016 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8017
3c59b4c9
PE
8018 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8019 instead of alloca (Bug#8344).
8020
a3eed478 8021 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8022 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8023
eb4d412d
PE
8024 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8025
1658b401
PE
8026 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8027 concerns.
8028
8029 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8030
8031 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8032
9a2c6e05
PE
8033 * keyboard.c (syms_of_keyboard): Use the same style as later
8034 in this function when indexing through an array. This also
8035 works around GCC bug 48267.
8036
03d0a109
PE
8037 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8038
44f730c8
PE
8039 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8040
fe75f926
PE
8041 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8042 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8043
ffa8c828
PE
8044 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8045 This avoids undefined behavior on integer overflow, and is a bit
8046 more convenient anyway since it is compared to a size_t variable.
8047
c5101a77
PE
8048 Variadic C functions now count arguments with size_t, not int.
8049 This avoids an unnecessary limitation on 64-bit machines, which
8050 caused (substring ...) to crash on large vectors (Bug#8344).
8051 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8052 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8053 All variadic functions and their callers changed accordingly.
c5101a77
PE
8054 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8055 * data.c (arith_driver, float_arith_driver): Likewise.
8056 * editfns.c (general_insert_function): Likewise.
8057 * eval.c (struct backtrace.nargs, interactive_p)
8058 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8059 (funcall_lambda, mark_backtrace): Likewise.
8060 * fns.c (concat): Likewise.
8061 * frame.c (x_set_frame_parameters): Likewise.
8062 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8063 0 if not found, not -1. All callers changed.
8064
dd3f25f7
PE
8065 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8066 (stack_copy_size): Now size_t, not int.
8067 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8068
461c2ab9
JB
80692011-03-28 Juanma Barranquero <lekktu@gmail.com>
8070
8071 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8072 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8073 All callers changed.
8074
8075 * lisp.h (multibyte_char_to_unibyte):
8076 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8077 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8078 * character.h (CHAR_TO_BYTE8):
8079 * cmds.c (internal_self_insert):
8080 * editfns.c (general_insert_function):
8081 * keymap.c (push_key_description):
8082 * search.c (Freplace_match):
8083 * xdisp.c (message_dolog, set_message_1): All callers changed.
8084
f6d62986
SM
80852011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8086
8087 * keyboard.c (safe_run_hook_funcall): New function.
8088 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8089 don't set the hook to nil, but remove the offending function instead.
8090 (Qcommand_hook_internal): Remove, unused.
8091 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8092 Vcommand_hook_internal.
8093
8094 * eval.c (enum run_hooks_condition): Remove.
8095 (funcall_nil, funcall_not): New functions.
8096 (run_hook_with_args): Call each function through a `funcall' argument.
8097 Remove `cond' argument, now redundant.
8098 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8099 (Frun_hook_with_args_until_failure): Adjust accordingly.
8100 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8101
1db5b1ad
JB
81022011-03-28 Juanma Barranquero <lekktu@gmail.com>
8103
8104 * dispextern.h (string_buffer_position): Remove declaration.
8105
8106 * print.c (strout): Remove parameter `multibyte', unused since
8107 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8108
8109 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8110 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8111 All callers changed.
8112
8113 * w32.c (_wsa_errlist): Use braces for struct initializers.
8114
8115 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8116 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8117 All callers changed.
8118 (string_buffer_position): Likewise. Also, make static (it's never
8119 used outside xdisp.c).
8120 (cursor_row_p): Remove parameter `w', unused since
8121 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8122 (decode_mode_spec): Remove parameter `precision', introduced during
8123 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8124 All callers changed.
8125
5ffb62aa
JD
81262011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8127
8128 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8129
461c2ab9 81302011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8131
8132 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8133 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8134 (ns_update_auto_hide_menu_bar): New functions.
8135 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8136 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8137 ns_constrain_all_frames.
8138 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8139 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8140
5c380ffb
JD
81412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8142
8143 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8144
9af30bdf
GM
81452011-03-27 Glenn Morris <rgm@gnu.org>
8146
8147 * syssignal.h: Replace RETSIGTYPE with void.
8148 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8149 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8150 Replace SIGTYPE with void everywhere.
8151 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8152 * s/template.h (SIGTYPE): Remove commented out definition.
8153
e2abce01
JB
81542011-03-26 Eli Zaretskii <eliz@gnu.org>
8155
8156 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8157 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8158
f868cd8a
JB
81592011-03-26 Juanma Barranquero <lekktu@gmail.com>
8160
59eb0929
JB
8161 * w32.c (read_unc_volume): Use parameter `henum', instead of
8162 global variable `wget_enum_handle'.
8163
8164 * keymap.c (describe_vector): Remove parameters `indices' and
8165 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8166 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8167
f868cd8a
JB
8168 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8169
8170 * keyboard.c (timer_check): Remove parameter `do_it_now',
8171 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8172 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8173 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8174
8175 * keyboard.c (read_char):
8176 * w32menu.c (w32_menu_display_help):
8177 * xmenu.c (show_help_event, menu_help_callback):
8178 Adjust calls to `show_help_echo'.
8179
8180 * gtkutil.c (xg_maybe_add_timer):
8181 * keyboard.c (readable_events):
8182 * process.c (wait_reading_process_output):
8183 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8184
8185 * insdel.c (adjust_markers_gap_motion):
8186 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8187 (gap_left, gap_right): Don't call it.
8188
2ecf6fdb
CY
81892011-03-25 Chong Yidong <cyd@stupidchicken.com>
8190
8191 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8192 incurred during fontification.
8193
6b1f9ba4
JB
81942011-03-25 Juanma Barranquero <lekktu@gmail.com>
8195
8196 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8197 (DEFVAR_PER_BUFFER): Don't pass it.
8198
8199 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8200 (scrolling_window): Don't pass it.
8201
0f4a96b5
JB
82022011-03-25 Juanma Barranquero <lekktu@gmail.com>
8203
8204 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8205
8206 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8207 and `suffix'.
8208 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8209 of variables specific to SELinux and computation of `encoded_absname'.
8210
8211 * image.c (XPutPixel): Remove unused variable `height'.
8212
8213 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8214
8215 * unexw32.c (get_section_info): Remove unused variable `section'.
8216
8217 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8218 (system_process_attributes): Remove unused variable `sess'.
8219 (sys_read): Remove unused variable `err'.
8220
8221 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8222 (w32_wnd_proc): Remove unused variable `isdead'.
8223 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8224 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8225 (x_create_tip_frame): Remove unused variable `tem'.
8226
8227 * w32inevt.c (w32_console_read_socket):
8228 Remove unused variable `no_events'.
8229
8230 * w32term.c (x_draw_composite_glyph_string_foreground):
8231 Remove unused variable `width'.
8232
1149507c
JB
82332011-03-24 Juanma Barranquero <lekktu@gmail.com>
8234
8235 * w32term.c (x_set_glyph_string_clipping):
8236 Don't pass uninitialized region to CombineRgn.
8237
9c88f339
JB
82382011-03-23 Juanma Barranquero <lekktu@gmail.com>
8239
8240 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8241 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8242 (Fx_close_connection): Remove unused variable `i'.
8243
8244 * w32font.c (w32font_draw): Return number of glyphs.
8245 (w32font_open_internal): Remove unused variable `i'.
8246 (w32font_driver): Add missing initializer.
8247
8248 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8249 (fill_in_menu): Remove unused variable `items_added'.
8250
8251 * w32term.c (last_mouse_press_frame): Remove static global variable.
8252 (w32_clip_to_row): Remove unused variable `f'.
8253 (x_delete_terminal): Remove unused variable `i'.
8254
8255 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8256 (NOTHING): Remove unused static global variable.
8257 (uniscribe_check_otf): Remove unused variable `table'.
8258 (uniscribe_font_driver): Add missing initializers.
8259
dee091a3
JD
82602011-03-23 Julien Danjou <julien@danjou.info>
8261
8262 * term.c (Fsuspend_tty, Fresume_tty):
8263 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8264 * window.c (temp_output_buffer_show):
8265 * insdel.c (signal_before_change):
8266 * frame.c (Fhandle_switch_frame):
8267 * fileio.c (Fdo_auto_save):
8268 * emacs.c (Fkill_emacs):
8269 * editfns.c (save_excursion_restore):
8270 * cmds.c (internal_self_insert):
8271 * callint.c (Fcall_interactively):
8272 * buffer.c (Fkill_all_local_variables):
8273 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8274 Use Frun_hooks.
0f4a96b5 8275 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8276 unconditionally since it does the check itself.
dee091a3 8277
2c520ab5 82782011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8279
c9c49752
PE
8280 Fix more problems found by GCC 4.5.2's static checks.
8281
8abc3f12
PE
8282 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8283 the first time through the loop, since we know p0 < p1 then.
8284 This also avoids a gcc -Wstrict-overflow warning.
8285
a2d26660
PE
8286 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8287 leading to a memory leak, possible in functions like
8288 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8289 of objects (Bug#8318).
a2d26660 8290
916c72e9
PE
8291 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8292 that could (at least in theory) be that large.
8293
19ab8a18
PE
8294 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8295 This is less likely to overflow, and avoids undefined behavior if
8296 overflow does occur. All callers changed. Use strtoul to scan
8297 for the unsigned long integer.
b7cbbd6f
PE
8298 (pint2hrstr): Simplify and tune code slightly.
8299 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8300
f0641eff
PE
8301 * scroll.c (do_scrolling): Work around GCC bug 48228.
8302 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8303
7f650bb9
PE
8304 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8305 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8306 (validate_x_resource_name): Simplify count usage.
8307 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8308
37dd57d1
PE
8309 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8310 fail (Bug#8306).
81e56e61 8311
699979fc 8312 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8313
401bf9b4
PE
8314 * process.c (Fmake_network_process): Use socklen_t, not int,
8315 where POSIX says socklen_t is required in portable programs.
8316 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8317 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8318 (Fmake_network_process, server_accept_connection):
8319 (wait_reading_process_output, read_process_output):
8320 Likewise.
8321
b93aacde
PE
8322 * process.c: Rename or move locals to avoid shadowing.
8323 (list_processes_1, Fmake_network_process):
8324 (read_process_output_error_handler, exec_sentinel_error_handler):
8325 Rename or move locals.
4dc343ee 8326 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8327 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8328 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8329 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8330 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8331
af8a867c 8332 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8333 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8334 Include tparam.h instead, since it declares them.
af8a867c
PE
8335 * cm.h (PC): Remove extern decl; tparam.h now does this.
8336 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8337 * terminfo.c: Include tparam.h, to check interfaces.
8338 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8339 (tparam): Adjust signature to match interface in tparam.h;
8340 this removes some undefined behavior. Check that outstring and len
8341 are zero, which they always are with Emacs.
8342 * tparam.h (PC, BC, UP): New extern decls.
8343
0248044d 8344 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8345 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8346
8ff096c1 8347 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8348 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8349 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8350 (ftfont_list): Remove unused local.
49eaafba
PE
8351 (get_adstyle_property, ftfont_pattern_entity):
8352 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8353 Rename locals to avoid shadowing.
8ff096c1 8354
e2be39f6
PE
8355 * xfont.c (xfont_list_family): Mark var as initialized.
8356
c9735e30
PE
8357 * xml.c (make_dom): Now static.
8358
8f5201ae
PE
8359 * composite.c (composition_compute_stop_pos): Rename local to
8360 avoid shadowing.
b246f932
PE
8361 (composition_reseat_it): Remove unused locals.
8362 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8363 (composition_update_it): Mark var as initialized.
11b61122
PE
8364 (find_automatic_composition): Mark vars as initialized,
8365 with a FIXME (Bug#8290).
8f5201ae 8366
760fbc2c
PE
8367 character.h: Rename locals to avoid shadowing.
8368 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8369 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8370 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8371 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8372 to avoid shadowing.
8373
ff08eb85
PE
8374 * textprop.c (property_change_between_p): Remove; unused.
8375
fc7bf025
PE
8376 * intervals.c (interval_start_pos): Now static.
8377
235d7abc
PE
8378 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8379
44f230aa
SM
8380 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8381 Rename locals to avoid shadowing.
3e7d6594 8382
50060332
PE
8383 * sound.c (wav_play, au_play, Fplay_sound_internal):
8384 Fix pointer signedness.
d01f234b 8385 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8386 (wav_play): Initialize a variable to 0, to prevent undefined
8387 behavior (Bug#8278).
50060332 8388
c4fc4e30
PE
8389 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8390
918436ed
PE
8391 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8392
c939f91b
PE
8393 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8394 clobbering (Bug#8298).
b9c7f648
PE
8395 * sysdep.c (sys_subshell): Likewise.
8396 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8397
6bd8c144
PE
8398 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8399 This should get cleaned up, so that child_setup has the
8400 same signature on all platforms.
8401
7710357c 8402 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8403 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8404
c59da222
CY
84052011-03-22 Chong Yidong <cyd@stupidchicken.com>
8406
8407 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8408 not to be necessary, and produces flickering.
8409
66b87493
GM
84102011-03-20 Glenn Morris <rgm@gnu.org>
8411
8412 * config.in: Remove file.
8413
45b6f6d5
JB
84142011-03-20 Juanma Barranquero <lekktu@gmail.com>
8415
8416 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8417 are now in src/globals.h.
8418 (syms_of_minibuf): Remove spurious & from previous change.
8419
cd394be1 84202011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8421
8422 * minibuf.c (completing-read-function): New variable.
8423 (completing-read-default): Rename from completing-read.
8424 (completing-read): Call completing-read-function.
8425
b14e3e21
CY
84262011-03-19 Juanma Barranquero <lekktu@gmail.com>
8427
8428 * xfaces.c (Fx_load_color_file):
8429 Read color file from absolute filename (bug#8250).
8430
f2b726e6
JB
84312011-03-19 Juanma Barranquero <lekktu@gmail.com>
8432
8433 * makefile.w32-in: Update dependencies.
8434
09f6ff02
EZ
84352011-03-17 Eli Zaretskii <eliz@gnu.org>
8436
8437 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8438
29a6015a
PE
84392011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8440
a3a6c54e
PE
8441 Fix more problems found by GCC 4.5.2's static checks.
8442
b766f867
PE
8443 * process.c (make_serial_process_unwind, send_process_trap):
8444 (sigchld_handler): Now static.
8445
be02381c
PE
8446 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8447 That way, the code declares only the vars that it needs.
8448 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8449 * s/cygwin.h (PTY_ITERATION): Likewise.
8450 * s/darwin.h (PTY_ITERATION): Likewise.
8451 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8452
57048744
PE
8453 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8454 * process.c (allocate_pty): Don't declare stb unless it's needed.
8455
7914961c 8456 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8457 (CONSTANTLIM): Remove; unused.
8458 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8459 Define only if needed.
7914961c 8460
b3967b18
PE
8461 * unexelf.c (unexec): Name an expression,
8462 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8463 Use a different way to cause a compilation error if anyone uses
8464 n rather than nn, a way that does not involve shadowing.
73366a00 8465 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8466
29a6015a
PE
8467 * deps.mk (unexalpha.o): Remove; unused.
8468
43cfc33e 8469 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8470 * unexec.h: New file.
ce701a33
PE
8471 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8472 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8473 Depend on unexec.h.
8474 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8475 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8476 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8477 Change as necessary to match prototype in unexec.h.
ce701a33 8478
01f44d5a
PE
8479 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8480 shadowing.
4f63c6bb 8481 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8482
a6670b0b
PE
8483 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8484 Rename locals to avoid shadowing.
8485
cef2010d 8486 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8487 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8488
d4d7173a
PE
8489 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8490
f08b802a
PE
8491 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8492 warning when compiling print.c.
8493
3ddb0639
PE
8494 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8495 instead of using an uninitialized var.
5ad03b97 8496 (font_sort_entities): Mark var as initialized.
3ddb0639 8497
170a2692
PE
8498 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8499
e663c700
PE
8500 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8501 pointers to constants.
89bc529a 8502 (font_parse_fcname): Remove unused vars.
7b81e2d0 8503 (font_delete_unmatched): Now static.
ea838e10 8504 (font_get_spec): Remove; unused.
13a547c6
PE
8505 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8506 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8507 Rename or move locals to avoid shadowing.
e663c700 8508
2a80c887 8509 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8510 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8511
1384fa33 8512 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8513 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8514
8b2c52e9
PE
8515 * alloc.c (mark_backtrace): Move decl from here ...
8516 * lisp.h: ... to here, so that it can be checked.
8517
475545b5 8518 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8519 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8520 (lisp_indirect_variable): Name an expression,
8521 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8522 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8523
b1349114 8524 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8525 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8526 Use const pointer when appropriate.
b1349114 8527
a2928364
PE
8528 * lisp.h (get_system_name, get_operating_system_release):
8529 Move decls here, to check interfaces.
8530 * process.c (get_operating_system_release): Move decl to lisp.h.
8531 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8532 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8533 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8534 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8535 (Fformat_time_string, Fencode_time, Finsert_char):
8536 (Ftranslate_region_internal, Fformat):
8537 Rename or remove local vars to avoid shadowing.
9710023e 8538 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8539
a415e694
PE
8540 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8541 avoid shadowing.
8542
8ef4622d
PE
8543 * lisp.h (eassert): Check that the argument compiles, even if
8544 ENABLE_CHECKING is not defined.
8545
946f9a5b
PE
8546 * data.c (Findirect_variable): Name an expression, to avoid
8547 gcc -Wbad-function-cast warning.
112396d6 8548 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8549 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8550 (Fmake_variable_buffer_local, Fmake_local_variable):
8551 Mark variables as initialized.
52746918 8552 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8553
e5aab7e7 8554 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8555 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8556 Rename locals to avoid shadowing.
dff45157
PE
8557 (mark_stack): Move local variables into the #ifdef region where
8558 they're used.
7bc26fdb
PE
8559 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8560 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8561 needed otherwise.
8562 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8563 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8564 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8565
e5aab7e7
PE
8566 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8567 avoids undefined behavior in theory.
8568
4da60324
PE
8569 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8570
88043301
PE
8571 Use functions, not macros, for up- and down-casing (Bug#8254).
8572 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8573 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8574 to use the following functions instead of these macros.
8575 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8576 EMACS_INT, since callers assume the returned value fits in int.
8577 (upcase1): Likewise, for UPCASE_TABLE.
8578 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8579 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8580 the race-condition problem in the old DOWNCASE.
88043301 8581
19ed5445
PE
8582 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8583 Rename locals to avoid shadowing.
8584 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8585 (regex_compile, re_search_2, re_match_2_internal):
8586 Remove unused local vars.
952db0d7
PE
8587 (FREE_VAR): Rewrite so as not to use empty "else",
8588 which gcc can warn about.
da053e48 8589 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8590 (RETALLOC_IF): Define only if needed.
8591 (WORDCHAR_P): Likewise. This one is never needed, but is used
8592 only in a comment talking about a compiler bug, so put inside
8593 the #if 0 of that comment.
8594 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8595 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8596 Remove; unused.
19ed5445 8597
1f3561e4 8598 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8599 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8600 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8601
ded6f8f7
PE
8602 * search.c (simple_search): Remove unused var.
8603
dbd37a95
PE
8604 * dired.c (compile_pattern): Move decl from here ...
8605 * lisp.h: ... to here, so that it can be checked.
8606 (struct re_registers): New forward decl.
8607
7e47afad
PE
8608 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8609
85f24f61
PE
8610 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8611 All uses changed.
8612 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8613 Rename locals to avoid shadowing.
5671df8f 8614 (Fvertical_motion): Mark locals as initialized.
85f24f61 8615
181aa2be 8616 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8617 (casify_region): Mark local as initialized.
181aa2be 8618
930d429c
PE
8619 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8620
7082eac6
PE
8621 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8622 New macros, so that the caller can use some names other than
8623 gcpro1, gcpro2, etc.
8624 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8625 of the new macros.
8626 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8627 argument, for consistency with GCPRO2_VAR, etc: it is now the
8628 prefix of the variable, not the variable itself. All uses
8629 changed.
38b2c076
PE
8630 * dired.c (directory_files_internal, file_name_completion):
8631 Rename locals to avoid shadowing.
8632
15206ed9
PE
8633 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8634 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8635 dired.c's scmp function, had undefined behavior.
8636 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8637 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8638 * buffer.h: ... to here, because these macros use current_buffer,
8639 and the new implementation with inline functions needs to have
8640 current_buffer in scope now, rather than later when the macros
8641 are used.
8642 (downcase, upcase1): New static inline functions.
8643 (DOWNCASE, UPCASE1): Reimplement using these functions.
8644 This avoids undefined behavior in expressions like
8645 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8646 from race conditions in accessing the global variables
8647 case_temp1 and case_temp2.
8648 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8649 * lisp.h (case_temp1, case_temp2): Remove their decls.
8650 * character.h (ASCII_CHAR_P): Move from here ...
8651 * lisp.h: ... to here, so that the inline functions mentioned
8652 above can use them.
8653
4a6bea26
PE
8654 * dired.c (directory_files_internal_unwind): Now static.
8655
f14b7e14
PE
8656 * fileio.c (file_name_as_directory, directory_file_name):
8657 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8658 Now static.
2893f146
PE
8659 (file_name_as_directory): Use const pointers when appropriate.
8660 (Fexpand_file_name): Likewise. In particular, newdir might
8661 point at constant storage, so make it a const pointer.
fd4ead52 8662 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8663 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8664 signedness issues.
f839df0c
PE
8665 (Fset_file_times, Finsert_file_contents, auto_save_error):
8666 Rename locals to avoid shadowing.
f14b7e14 8667
5716756e 8668 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8669 (Ftry_completion, Fall_completions): Rename or remove locals
8670 to avoid shadowing.
5716756e 8671
b4c3046a
PE
8672 * marker.c (bytepos_to_charpos): Remove; unused.
8673
b45db522
PE
8674 * lisp.h (verify_bytepos, count_markers): New decls,
8675 so that gcc does not warn that these functions aren't declared.
8676
85876d07
PE
8677 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8678 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8679 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8680 (copy_text): Remove unused local var.
85876d07 8681
03d78a21 8682 * filelock.c (within_one_second): Now static.
b3dd38ab 8683 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8684
5df8f01b
PE
8685 * buffer.c (fix_overlays_before): Mark locals as initialized.
8686 (fix_start_end_in_overlays): Likewise. This function should be
8687 simplified by using pointers-to-pointers, but that's a different
8688 matter.
b1d876f1 8689 (switch_to_buffer_1): Now static.
8f54f30a
PE
8690 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8691 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8692
a70072c9 8693 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8694 Fix pointer signedness issue.
edced198
PE
8695 (sys_subshell): Mark local as volatile if checking for lint,
8696 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8697 (MAXPATHLEN): Define only if needed.
a70072c9 8698
a0977c44
PE
8699 * process.c (serial_open, serial_configure): Move decls from here ...
8700 * systty.h: ... to here, so that they can be checked.
8701
a884fdcc
PE
8702 * fns.c (get_random, seed_random): Move extern decls from here ...
8703 * lisp.h: ... to here, so that they can be checked.
8704
604efe86 8705 * sysdep.c (reset_io): Now static.
b8950c94 8706 (wait_for_termination_signal): Remove; unused.
604efe86 8707
38fc62d9
PE
8708 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8709 (copy_keymap_item, append_key, push_text_char_description):
8710 Now static.
1004a21a 8711 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8712 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8713 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8714 (describe_map_tree):
8715 Rename locals to avoid shadowing.
38fc62d9 8716
2f2650da
PE
8717 * keyboard.c: Declare functions static if they are not used elsewhere.
8718 (echo_char, echo_dash, cmd_error, top_level_2):
8719 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8720 (read_char, kbd_buffer_get_event, make_lispy_position):
8721 (make_lispy_event, make_lispy_movement, apply_modifiers):
8722 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8723 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8724 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8725 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8726 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8727
a053e86c 8728 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8729 (mark_kboards): Move decl here ...
8730 * alloc.c (mark_kboards): ... from here.
a053e86c 8731
4752793e
PE
8732 * lisp.h (force_auto_save_soon): New decl.
8733
74f10ca7 8734 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8735 (DEFINE_DUMMY_FUNCTION): New macro.
8736 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8737 Use it.
c03cd23f
PE
8738 (main): Add casts to avoid warnings
8739 if GCC considers string literals to be constants.
74f10ca7 8740
022e70d4
PE
8741 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8742
59d6fe83
PE
8743 * dbusbind.c: Pointer signedness fixes.
8744 (xd_signature, xd_append_arg, xd_initialize):
8745 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8746 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8747 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8748 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8749
78320123
PE
8750 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8751 if GCC considers string literals to be constants.
49cebcca 8752 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8753
35ac2a97
SM
87542011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8755
fb103ca9
SM
8756 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8757 (print_preprocess, print_object): New macro to fix last change.
8758
35ac2a97
SM
8759 * print.c (print_preprocess): Don't forget font objects.
8760
62973b41
JB
87612011-03-16 Juanma Barranquero <lekktu@gmail.com>
8762
8763 * emacs.c (USAGE3): Doc fixes.
8764
0e48bb22
AS
87652011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8766
8767 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8768 structure.
8769
7684e57b
JB
87702011-03-14 Juanma Barranquero <lekktu@gmail.com>
8771
8772 * lisp.h (VWindow_system, Qfile_name_history):
8773 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8774 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8775 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8776
8777 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8778 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8779
8780 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8781 * w32console.c (detect_input_pending, read_input_pending)
8782 (encode_terminal_code):
8783 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8784 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8785 (w32_system_caret_y, Qfile_name_history):
8786 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8787 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8788 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8789 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8790 * w32proc.c (Qlocal, report_file_error):
8791 * w32term.c (Vwindow_system, updating_frame):
8792 * w32uniscribe.c (initialized, uniscribe_font_driver):
8793 Remove unneeded extern declarations.
8794
2aa46d6c
CY
87952011-03-14 Chong Yidong <cyd@stupidchicken.com>
8796
c96bbc66 8797 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8798
cffc6f3b
CY
87992011-03-13 Chong Yidong <cyd@stupidchicken.com>
8800
8801 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8802 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8803 These macros can no longer be used for assignment.
8804
44f230aa
SM
8805 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8806 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8807 (record_buffer_markers, fetch_buffer_markers): New functions for
8808 recording and fetching special buffer markers.
8809 (set_buffer_internal_1, set_buffer_temp): Use them.
8810
8811 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8812
8813 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8814
8815 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8816 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8817
8818 * xdisp.c (hscroll_window_tree):
8819 (reconsider_clip_changes): Use PT instead of BUF_PT.
8820
d251f04b
EZ
88212011-03-13 Eli Zaretskii <eliz@gnu.org>
8822
8823 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8824 $(EMACS_ROOT)/lib/intprops.h.
8825
f0c77cd1
PE
88262011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8827
3eca4629
PE
8828 Fix more problems found by GCC 4.5.2's static checks.
8829
7c86ee98
PE
8830 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8831 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8832 (xg_free_frame_widgets): Make it clear that a local variable is
8833 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8834 (gdk_window_get_screen): Make it clear that this macro is needed
8835 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8836 (int_gtk_range_get_value): New function, which avoids a diagnostic
8837 from gcc -Wbad-function-cast.
8838 (xg_set_toolkit_scroll_bar_thumb): Use it.
8839 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8840 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8841 (get_utf8_string, xg_get_file_with_chooser):
8842 Rename locals to avoid shadowing.
8843 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8844
41729b81
PE
8845 * xgselect.c (xg_select): Remove unused var.
8846
f0c77cd1
PE
8847 * image.c (four_corners_best): Mark locals as initialized.
8848 (gif_load): Initialize transparent_p to zero (Bug#8238).
8849 Mark another local as initialized.
ec6cf4c6 8850 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8851
ce0ad53d 8852 * image.c (clear_image_cache): Now static.
d5d5a617 8853 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8854 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8855 (x_edge_detection): Remove unnecessary cast that
8856 gcc -Wbad-function-cast diagnoses.
2037898d 8857 (gif_load): Fix pointer signedness.
6ae141d6
PE
8858 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8859 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8860
33383987 88612011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8862
d32df629
PE
8863 Improve quality of tests for time stamp overflow.
8864 For example, without this patch (encode-time 0 0 0 1 1
8865 1152921504606846976) returns the obviously-bogus value (-948597
8866 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8867 reports time overflow. See
8868 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8869 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8870 * editfns.c: Include limits.h and intprops.h.
8871 (TIME_T_MIN, TIME_T_MAX): New macros.
8872 (time_overflow): Move earlier, to before first use.
8873 (hi_time, lo_time): New functions, for an accurate test for
8874 out-of-range times.
8875 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8876 (Fget_internal_run_time): Don't assume time_t fits in int.
8877 (make_time): Use list2 instead of Fcons twice.
8878 (Fdecode_time): More accurate test for out-of-range times.
8879 (check_tm_member): New function.
8880 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8881 (lisp_time_argument): Don't rely on undefined left-shift and
8882 right-shift behavior when checking for time stamp overflow.
8be6f318 8883
fe31d94c
PE
8884 * editfns.c (time_overflow): New function, refactoring common code.
8885 (Fformat_time_string, Fdecode_time, Fencode_time):
8886 (Fcurrent_time_string): Use it.
8887
8be6f318
PE
8888 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8889 * dired.c (make_time): Move to ...
8890 * editfns.c (make_time): ... here.
8891 * systime.h: Note the move.
8892
09d9db2c 88932011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8894
126bc0dc
YM
8895 * fringe.c (update_window_fringes): Remove unused variables.
8896
c47cbdfd
YM
8897 * unexmacosx.c (copy_data_segment): Also copy __got section.
8898 (Bug#8223)
8899
7ac80be9
EZ
89002011-03-12 Eli Zaretskii <eliz@gnu.org>
8901
c96bbc66 8902 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8903 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8904 Constify `char *' arguments and their references according to
8905 prototypes in tparam.h.
8906
ecb0f94d 8907 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8908
7ac80be9
EZ
8909 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8910 Adapt all references accordingly.
8911
8912 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8913
ef1fd07e
TT
89142011-03-11 Tom Tromey <tromey@redhat.com>
8915
8916 * buffer.c (syms_of_buffer): Remove obsolete comment.
8917
7ef4b50c
EZ
89182011-03-11 Eli Zaretskii <eliz@gnu.org>
8919
8920 * termhooks.h (encode_terminal_code): Declare prototype.
8921
8922 * msdos.c (encode_terminal_code): Don't declare prototype.
8923
8924 * term.c (encode_terminal_code): Now external again, used by
8925 w32console.c and msdos.c.
8926
44f230aa
SM
8927 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8928 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8929
4b1ec863 89302011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8931
1714f52b 8932 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8933
4b1ec863
PE
8934 * fringe.c (update_window_fringes): Mark locals as initialized
8935 (Bug#8227).
8936 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8937
524c7aa6
PE
8938 * alloc.c (mark_fringe_data): Move decl from here ...
8939 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8940 to check its interface.
8941 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8942
a5c0af81 8943 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8944 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8945 (fontset_font): Mark local as initialized.
a9a06e0b 8946 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8947
b4716021
PE
8948 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8949
811e9bac 8950 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8951 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8952 (x_own_selection, Fx_disown_selection_internal): Rename locals
8953 to avoid shadowing.
8954 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8955
7e3ab302
PE
8956 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8957 so that the caller can use some name other than gcpro1.
8958 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8959 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8960 (Fx_backspace_delete_keys_p):
8961 Use them to avoid shadowing, and rename vars to avoid shadowing.
8962 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8963 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8964 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8965 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8966 Remove unused locals.
7e3ab302
PE
8967 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8968 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8969 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8970 macros.
f78faa98 8971
e2b13473
PE
8972 * xterm.h (x_mouse_leave): New decl.
8973
77f23912
PE
8974 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8975 Remove unused functions.
cdf4ba58
PE
8976 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8977 (x_calc_absolute_position): Now static.
7411c686 8978 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8979 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8980 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8981 unless they are used.
38d0b34a
PE
8982 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8983 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8984 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8985 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8986 (x_error_catcher, x_connection_closed, x_error_handler):
8987 (x_error_quitter, xembed_send_message, x_iconify_frame):
8988 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8989 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8990 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8991
44f230aa
SM
8992 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8993 Rename or move locals to avoid shadowing.
6b463e58 8994 (tty_defined_color, merge_face_heights): Now static.
5967d051 8995 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8996 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8997 does not deduce is never used uninitialized.
73719eba
PE
8998 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8999 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9000
426994c3 9001 * terminal.c (store_terminal_param): Now static.
5489860b 9002
032f1620 9003 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9004 (set_frame_menubar): Remove unused local.
d4323972 9005 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9006 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9007 since they might point to immutable storage.
281585b0
PE
9008 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9009 since it's unused otherwise.
032f1620 9010
367c19e5 9011 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9012 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9013 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9014 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9015 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9016 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9017 does not deduce are never used uninitialized.
70739cbe 9018
07b48fa9
PE
9019 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9020
8868a238 9021 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9022 * window.c (window_loop, size_window):
9023 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9024
7e5cf297 9025 * window.c (display_buffer): Now static.
d6550a9f
PE
9026 (size_window): Mark variables that gcc -Wuninitialized
9027 does not deduce are never used uninitialized.
a586633d
PE
9028 * window.h (check_all_windows): New decl, to forestall
9029 gcc -Wmissing-prototypes diagnostic.
5b555da1 9030 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9031
f6095868
PE
9032 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9033 shadowing.
9034 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9035 Include <limits.h>.
9036 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9037 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9038 (load_charset_map): Mark variables that gcc -Wuninitialized
9039 does not deduce are never used uninitialized.
53df7c11 9040 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9041
f38b440c
PE
9042 * coding.c (coding_set_source, coding_set_destination):
9043 Use "else { /* comment */ }" rather than "else /* comment */;"
9044 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9045 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9046 a block, when the outer 'i' will do.
9047 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9048 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9049 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9050 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9051 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9052 Rename locals to avoid shadowing.
9053 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9054 * coding.c (emacs_mule_char, encode_invocation_designation):
9055 Now static, since they're not used elsewhere.
413bb2db 9056 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9057 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9058 (decode_coding_emacs_mule): Mark variables that gcc
9059 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9060 (detect_coding_iso_2022): Initialize a local variable that might
9061 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9062 this initialization is needed. (Bug#8211)
5f58e762
PE
9063 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9064 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9065 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9066 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9067 Remove unused macros.
f38b440c 9068
232b38b9 9069 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9070 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9071 * character.c (string_count_byte8): Likewise.
232b38b9 9072
fb90da1b
PE
9073 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9074 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9075
fb93dbc2
PE
9076 * chartab.c (copy_sub_char_table): Now static, since it's not used
9077 elsewhere.
5c156ace
PE
9078 (sub_char_table_ref_and_range, char_table_ref_and_range):
9079 Rename locals to avoid shadowing.
bbcd0949 9080 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9081
7d3b3862 9082 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9083 (BIDI_BOB): Remove unused macro.
7d3b3862 9084
6be7d3da
PE
9085 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9086 deduce are never used uninitialized.
c2ed9c8b 9087 * term.c (encode_terminal_code): Likewise.
6be7d3da 9088
75f8807f 9089 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9090
50938595
PE
9091 * tparam.h: New file.
9092 * term.c, tparam.h: Include it.
9093 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9094 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9095 Move these decls to tparam.h, and make them agree with what
9096 is actually in tparam.c. The previous trick of using incompatible
9097 decls in different modules does not conform to the C standard.
9098 All callers of tparam changed to use tparam's actual API.
9099 * tparam.c (tparam1, tparam, tgoto):
9100 Use const pointers where appropriate.
9101
fbceeba2
PE
9102 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9103 * cm.h (struct cm): Likewise.
9104 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9105 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9106 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9107 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9108 (turn_on_face, init_tty): Likewise.
9109 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9110
7f3f1250
PE
9111 * term.c (term_mouse_position): Rename local to avoid shadowing.
9112
e6ca6543
PE
9113 * alloc.c (mark_ttys): Move decl from here ...
9114 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9115
c40f8d15
AS
91162011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9117
9118 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9119
cfe0661d
JB
91202011-03-09 Juanma Barranquero <lekktu@gmail.com>
9121
9122 * search.c (compile_pattern_1): Remove argument regp, unused since
9123 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9124 (compile_pattern): Don't pass it.
9125
0afb4571
J
91262011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9127
9128 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9129 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9130 for ! HAVE_GTK3.
9131 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9132
9133 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9134
9135 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9136 gdk_window_get_screen, gdk_window_get_geometry,
9137 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9138 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9139 (xg_get_pixbuf_from_pixmap): New function.
9140 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9141 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9142 Call xg_get_pixbuf_from_pixmap instead of
9143 gdk_pixbuf_get_from_drawable.
9144 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9145 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9146 (xg_check_special_colors): Use GtkStyleContext and its functions
9147 for HAVE_GTK3.
9148 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9149 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9150 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9151 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9152 Call gtk_widget_get_preferred_size.
0afb4571
J
9153 (xg_frame_resized): gdk_window_get_geometry only takes 5
9154 parameters.
44f230aa
SM
9155 (xg_win_to_widget, xg_event_is_for_menubar):
9156 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9157 (xg_set_widget_bg): New function.
9158 (delete_cb): New function.
895009e1 9159 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9160 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9161 (xg_set_background_color): Call xg_set_widget_bg.
9162 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9163 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9164 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9165 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9166 if ! HAVE_GTK3.
9167 (update_frame_tool_bar): Call gtk_widget_hide.
9168 (xg_initialize): Use GDK_KEY_g.
9169
9170 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9171 if ! HAVE_GTK3
9172 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9173
9174 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9175 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9176 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9177
1c2cc4ef
JB
91782011-03-08 Juanma Barranquero <lekktu@gmail.com>
9179
9180 * w32xfns.c (select_palette): Check success of RealizePalette against
9181 GDI_ERROR, not zero.
9182
33383987 9183See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9184
9185;; Local Variables:
9186;; coding: utf-8
aac0c6e3
MR
9187;; End:
9188
acaf905b 9189 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9190
9191 This file is part of GNU Emacs.
9192
9193 GNU Emacs is free software: you can redistribute it and/or modify
9194 it under the terms of the GNU General Public License as published by
9195 the Free Software Foundation, either version 3 of the License, or
9196 (at your option) any later version.
9197
9198 GNU Emacs is distributed in the hope that it will be useful,
9199 but WITHOUT ANY WARRANTY; without even the implied warranty of
9200 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9201 GNU General Public License for more details.
9202
9203 You should have received a copy of the GNU General Public License
9204 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.