* xmenu.c (xmenu_show): Don't use uninitialized vars.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
eef9bc79
PE
3 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4
098db9dd
PE
5 * xterm.c: Fix problems found by static analysis with other toolkits.
6 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7 (x_dispatch_event): Declare static only if !USE_GTK && USE_X_TOOLKIT.
8 Define if USE_GTK || (HAVE_MENUS && USE_X_TOOLKIT); USE_MOTIF need
9 not be part of this test.
10 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11 * xterm.h (x_dispatch_event): Use USE_GTK, not USE_MOTIF, when testing
12 whether to declare.
13 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
14 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
15
eb18f6cc
PE
16 * xmenu.c (menu_help_callback): Pointer type fixes.
17 Use const pointers when pointing at readonly data. Avoid pointer
18 signedness clashes.
19 (FALSE): Remove unused macro.
20 (update_frame_menubar): Remove unused decl.
21
1fe72bf8
PE
22 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
23
60d9e1db
PE
24 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
25 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
26 (single_menu_item): Rename local to avoid shadowing.
27
39261c26
PE
28 * keyboard.c (make_lispy_event): Remove unused local var.
29
018c5e19
PE
30 * frame.c, frame.h (x_get_resource_string): Bring this back, but
31 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
32
63d2b86e
PE
33 * bitmaps: Change bitmaps from unsigned char back to the X11
34 compatible char. Avoid the old compiler warnings about
35 out-of-range initializers by using, for example, '\xab' rather
36 than 0xab.
37
aefd87e1
PE
38 * xgselect.c (xgselect_initialize): Check vs interface
39 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
40
bf501fb9
PE
41 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
42
e9829fdf
PE
43 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
44 to read-only memory.
45
1086c095
PE
46 * fns.c (vector): Remove; this old hack is no longer needed.
47
2baccd04 48 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 49 Remove unused var.
dde42981 50 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 51
72391843 52 * xrdb.c (x_load_resources): Omit unused local.
3565b346 53
436c16df 54 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 55 (x_window): Rename locals to avoid shadowing.
dc5ddd85 56 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 57
92bb796d 58 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 59 (x_term_init): Remove local to avoid shadowing.
92bb796d 60
764430a3 61 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
62
63 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
64 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
65
4170f62f 662011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 67
71b41406
PE
68 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
69
9587a89d
PE
70 emacs_write: Accept and return EMACS_INT for sizes.
71 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
72 et seq.
73 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
74 Accept and return EMACS_INT.
75 (emacs_gnutls_write): Return the number of bytes written on
76 partial writes.
77 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
78 (emacs_read, emacs_write): Remove check for negative size, as the
79 Emacs source code has been audited now.
9587a89d
PE
80 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
81 (emacs_read, emacs_write): Use it.
273a5f82
PE
82 * process.c (send_process): Adjust to the new signatures of
83 emacs_write and emacs_gnutls_write. Do not attempt to store
84 a byte offset into an 'int'; it might overflow.
9587a89d 85 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 86
3e047f51
PE
87 * sound.c: Don't assume sizes fit in 'int'.
88 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 89 Return EMACS_INT, not int.
3e047f51 90 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
91 Accept EMACS_INT, not int.
92 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
93 record read return values.
94
cc39a9db
BK
952011-04-15 Ben Key <bkey76@gmail.com>
96
97 * keyboard.c (Qundefined): Don't declare static since it is
98 used in nsfns.m.
99 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
100 declare static since they are used in nsfont.m.
101
6c60eb9f
SM
1022011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
103
104 * process.c (Qprocessp): Don't declare static.
105 * lisp.h (Qprocessp): Declare again.
106
7990b61a
JB
1072011-04-15 Juanma Barranquero <lekktu@gmail.com>
108
109 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
110
5d4cb038
PE
1112011-04-14 Paul Eggert <eggert@cs.ucla.edu>
112
8bd7b830 113 Improve C-level modularity by making more things 'static'.
cd64ea1d 114
e3b27b31
PE
115 Don't publish debugger-only interfaces to other modules.
116 * lisp.h (safe_debug_print, debug_output_compilation_hack):
117 (verify_bytepos, count_markers): Move decls to the only modules
118 that need them.
119 * region-cache.h (pp_cache): Likewise.
120 * window.h (check_all_windows): Likewise.
121 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
122
5d4cb038
PE
123 * sysdep.c (croak): Now static, if
124 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
125 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
126
127 * alloc.c (refill_memory_reserve): Now static if
128 !defined REL_ALLOC || defined SYSTEM_MALLOC.
129 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 130
e87b6180
PE
131 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
132 Define only if USE_LUCID.
133
ac64929e
PE
134 * xrdb.c (x_customization_string, x_rm_string): Now static.
135
6f37259d
PE
136 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
137 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
138
1683e3ab
PE
139 * xdisp.c (draw_row_with_mouse_face): Now static.
140 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
141
de9c2632
PE
142 * window.h (check_all_windows): Mark externally visible.
143
2b96acb7
PE
144 * window.c (window_deletion_count): Now static.
145
146 * undo.c: Make symbols static if they're not exported.
147 (last_undo_buffer, last_boundary_position, pending_boundary):
148 Now static.
149
50436f33
PE
150 * textprop.c (interval_insert_behind_hooks): Now static.
151 (interval_insert_in_front_hooks): Likewise.
152
64520e5c
PE
153 * term.c: Make symbols static if they're not exported.
154 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
155 (max_frame_lines, tty_set_terminal_modes):
156 (tty_reset_terminal_modes, tty_turn_off_highlight):
157 (get_tty_terminal): Now static.
158 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
159 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 160 HAVE_WINDOW_SYSTEM.
64520e5c
PE
161 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
162 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
163
1fa53021
PE
164 * sysdep.c: Make symbols static if they're not exported.
165 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
166 Now static.
167 (sigprocmask_set, full_mask): Remove; unused.
168 (wait_debugging): Mark as visible.
169 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
170 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
171
d4b43b22
PE
172 * syntax.c (syntax_temp): Define only if !__GNUC__.
173
b7c513d0
PE
174 * sound.c (current_sound_device, current_sound): Now static.
175
989b29ad
PE
176 * search.c (searchbufs, searchbuf_head): Now static.
177
13a55a78
PE
178 * scroll.c (scroll_cost): Remove; unused.
179 * dispextern.h (scroll_cost): Remove decl.
180
de68a1fc
PE
181 * region-cache.h (pp_cache): Mark as externally visible.
182
40ccffa6
PE
183 * process.c: Make symbols static if they're not exported.
184 (process_tick, update_tick, create_process, chan_process):
185 (Vprocess_alist, proc_buffered_char, datagram_access):
186 (fd_callback_data, send_process_frame, process_sent_to): Now static.
187 (deactivate_process): Mark defn as static, as well as decl.
188 * lisp.h (create_process): Remove decl.
189 * process.h (chan_process, Vprocess_alist): Remove decls.
190
ad64fc97
PE
191 * print.c: Make symbols static if they're not exported.
192 (print_depth, new_backquote_output, being_printed, print_buffer):
193 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
194 (print_interval, print_number_index, initial_stderr_stream):
195 Now static.
196 * lisp.h (Fprinc): Remove decl.
197 (debug_output_compilation_hack): Mark as externally visible.
198
adddb265
PE
199 * sysdep.c (croak): Move decl from here to syssignal.h.
200 * syssignal.h (croak): Put it here, so the API can be checked when
201 'croak' is called from dissociate_if_controlling_tty.
202
1717ede2
PE
203 * minibuf.c: Make symbols static if they're not exported.
204 (minibuf_save_list, choose_minibuf_frame): Now static.
205 * lisp.h (choose_minibuf_frame): Remove decl.
206
fa5fb2bc
PE
207 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
208
1e3890d1
PE
209 * lread.c: Make symbols static if they're not exported.
210 (read_objects, initial_obarray, oblookup_last_bucket_number):
211 Now static.
212 (make_symbol): Remove; unused.
213 * lisp.h (initial_obarray, make_symbol): Remove decls.
214
8a1414fa
PE
215 * keyboard.c: Make symbols static if they're not exported.
216 (single_kboard, recent_keys_index, total_keys, recent_keys):
217 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
218 (this_single_command_key_start, echoing, last_auto_save):
219 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
220 (command_loop, echo_now, keyboard_init_hook, help_char_p):
221 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
222 (Vlispy_mouse_stem, double_click_count):
223 Now static.
224 (force_auto_save_soon): Define only if SIGDANGER.
225 (ignore_mouse_drag_p): Now static if
226 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
227 (print_help): Remove; unused.
228 (stop_character, last_timer_event): Mark as externally visible.
229 * keyboard.h (ignore_mouse_drag_p): Declare only if
230 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
231 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
232 * lisp.h (echoing): Remove decl.
233 (force_auto_save_soon): Declare only if SIGDANGER.
234 * xdisp.c (redisplay_window): Simplify code, to make it more
235 obvious that ignore_mouse_drag_p is not accessed if !defined
236 USE_GTK && !defined HAVE_NS.
237
93ea6e8f
PE
238 * intervals.c: Make symbols static if they're not exported.
239 (merge_properties_sticky, merge_interval_right, delete_interval):
240 Now static.
241 * intervals.h (merge_interval_right, delete_interval): Remove decls.
242
77382fcc
PE
243 * insdel.c: Make symbols static if they're not exported.
244 However, leave prepare_to_modify_buffer alone. It's never
245 called from outside this function, but that appears to be a bug.
246 (combine_after_change_list, combine_after_change_buffer):
4889fc82 247 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
248 (adjust_after_replace_noundo): Remove; unused.
249 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 250 (signal_before_change): Remove decls.
77382fcc 251
9306c32e
PE
252 * indent.c (val_compute_motion, val_vmotion): Now static.
253
cd44d2eb
PE
254 * image.c: Make symbols static if they're not exported.
255 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
256 if USE_GTK.
257 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
258 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
259
ad9a7a06
PE
260 * fringe.c (standard_bitmaps): Now static.
261 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
262
81626931
PE
263 * frame.c: Make symbols static if they're not exported.
264 (x_report_frame_params, make_terminal_frame): Now static.
265 (get_frame_param): Now static, unless HAVE_NS.
266 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
267 (x_get_resource_string): Remove; not used.
268 * frame.h (make_terminal_frame, x_report_frame_params):
269 (x_get_resource_string); Remove decls.
270 (x_fullscreen_adjust): Declare only if WINDOWSNT.
271 * lisp.h (get_frame_param): Declare only if HAVE_NS.
272
239f9db9
PE
273 * font.c, fontset.c: Make symbols static if they're not exported.
274 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
275 (FACE_SUITABLE_FOR_CHAR_P): Use it.
276 * font.c (font_close_object): Now static.
277 * font.h (font_close_object): Remove.
278 * fontset.c (FONTSET_OBJLIST): Remove.
279 (free_realized_fontset) #if-0 the body, which does nothing.
280 (face_suitable_for_char_p): #if-0, as it's never called.
281 * fontset.h (face_suitable_for_char_p): Remove decl.
282 * xfaces.c (face_at_string_position): Use
283 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
284 since 0 is always ASCII.
285
dfcf3579
PE
286 * fns.c (weak_hash_tables): Now static.
287
5045092b
PE
288 * fileio.c: Make symbols static if they're not exported.
289 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
290 (Vwrite_region_annotation_buffers): Now static.
291
57a96f5c
PE
292 * eval.c: Make symbols static if they're not exported.
293 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
294 * lisp.h (backtrace_list): Remove decl.
295
35f08c38
PE
296 * emacs.c: Make symbols static if they're not exported.
297 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
298 (fatal_error_code, fatal_error_signal_hook, standard_args):
299 Now static.
300 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
301 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
302 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
303 * lisp.h (fatal_error_signal_hook): Remove decl.
304 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
305
f44bd759
PE
306 * editfns.c: Move a (normally-unused) function to its only use.
307 * editfns.c, lisp.h (get_operating_system_release): Remove.
308 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
309 worth the hassle of breaking this out.
310
b532497d
PE
311 * xterm.c: Make symbols static if they're not exported.
312 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
313 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
314 (x_destroy_window, x_delete_display):
315 Now static.
316 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
317 (x_mouse_leave): Remove; unused.
318 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
319 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
320 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
321 Remove decls.
322 (x_mouse_leave): Declare only if WINDOWSNT.
323 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
324 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
325 USE_X_TOOLKIT.
326
1675728f
PE
327 * ftxfont.c: Make symbols static if they're not exported.
328 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
329 HAVE_FREETYPE.
330 * font.h (ftxfont_driver): Likewise.
331
e4cebfca
PE
332 * xfns.c: Make symbols static if they're not exported.
333 (x_last_font_name, x_display_info_for_name):
334 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
335 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
336 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
337 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
338 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
339 (last_show_tip_args): Now static.
340 (xic_defaut_fontset, xic_create_fontsetname): Define only if
341 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
342 (x_screen_planes): Remove; unused.
343 * dispextern.h (x_screen_planes): Remove decl.
344
5bf46f05
PE
345 * dispnew.c: Make symbols static if they're not exported.
346 * dispextern.h (redraw_garbaged_frames, scrolling):
347 (increment_row_positions): Remove.
348 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
349 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
350 Now static.
351 (redraw_garbaged_frames): Remove; unused.
352
435f4c28
PE
353 * xfaces.c: Make symbols static if they're not exported.
354 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
355 Remove decls.
356 * xterm.h (defined_color): Remove decls.
357 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
358 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
359 (menu_face_changed_default, defined_color, free_realized_face):
360 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
361 (ascii_face_of_lisp_face): Remove; unused.
362
8524aef3
PE
363 * xdisp.c: Make symbols static if they're not exported.
364 * dispextern.h (scratch_glyph_row, window_box_edges):
365 (glyph_to_pixel_coords, set_cursor_from_row):
366 (get_next_display_element, set_iterator_to_next):
367 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
368 (show_mouse_face): Remove decls
369 * frame.h (message_buf_print): Likewise.
370 * lisp.h (pop_message, set_message, check_point_in_composition):
371 Likewise.
372 * xterm.h (set_vertical_scroll_bar): Likewise.
373 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
374 (message_buf_print, scratch_glyph_row, displayed_buffer):
375 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
376 (get_next_display_element, show_mouse_face, window_box_edges):
377 (frame_to_window_pixel_xy, check_point_in_composition):
378 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
379 (glyph_to_pixel_coords): Remove; unused.
380
16390cd2
PE
381 * dired.c (file_name_completion): Now static.
382
383 * dbusbind.c (xd_in_read_queued_messages): Now static.
384
a25f4dfa
PE
385 * lisp.h (circular_list_error, FOREACH): Remove; unused.
386 * data.c (circular_list_error): Remove.
387
14a9c8df
PE
388 * commands.h (last_point_position, last_point_position_buffer):
389 (last_point_position_window): Remove decls.
390 * keyboard.c: Make these variables static.
391
74ab6df5
PE
392 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
393 decls.
394 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
395 (iso_code_class, detect_coding, code_convert_region): Now static.
396 (encode_coding_gap): Remove; unused.
397
38dfbee1
PE
398 * chartab.c (chartab_chars, chartab_bits): Now static.
399
a2cb4e63
PE
400 * charset.h (charset_iso_8859_1): Remove decl.
401 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
402 Now static.
403
127198fd
PE
404 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
405 * ccl.c (Vccl_program_table): Now static.
406 (check_ccl_update): Remove; unused.
407
d85b608f
PE
408 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
409 * category.h: ... from here.
410 * category.c (check_category_table, set_category_set): Now static.
411
31cd66f3
PE
412 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
413 * lisp.h: Remove these decls.
414
c358e587
PE
415 * buffer.c (buffer_count): Remove unused var.
416
e78aecca
PE
417 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
418 so that it's not optimized away.
419 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
420 * dispextern.h (bidi_dump_cached_states): Remove, since it's
421 exported only to the debugger.
422
e192d7d3
PE
423 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
424 * atimer.h (run_all_atimers): Removed; not exported.
425
92470028
PE
426 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
427 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
428 was inaccessible from Lisp.
429 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
430 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
431
244ed907
PE
432 alloc.c: Import and export fewer symbols, and remove unused items.
433 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
434 is defined.
435 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
436 it's not optimized away by whole-program optimization.
437 (message_enable_multibyte, free_misc): Remove.
438 (catchlist, handlerlist, mark_backtrace):
439 Declare only if BYTE_MARK_STACK.
440 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
441 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
442 (message_enable_multibyte): Remove decl.
443 (free_misc, interval_free_list, float_block, float_block_index):
444 (n_float_blocks, float_free_list, cons_block, cons_block_index):
445 (cons_free_list, last_marked_index):
446 Now static.
447 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
448 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
449 (mark_backtrace): Define only if BYTE_MARK_STACK.
450 * xdisp.c (message_enable_multibyte): Now static.
451
955cbe7b
PE
452 Declare Lisp_Object Q* variables to be 'static' if not exproted.
453 This makes it easier for human readers (and static analyzers)
454 to see whether these variables are used from other modules.
455 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
456 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
457 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
458 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
459 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
460 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
461 * xmenu.c, xselect.c:
462 Declare Q* vars static if they are not used in other modules.
463 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
464 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
465 Remove decls of unexported vars.
466 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
467
95c82688
PE
468 * lisp.h (DEFINE_FUNC): Make sname 'static'.
469
16a97296
PE
470 Make Emacs functions such as Fatom 'static' by default.
471 This makes it easier for human readers (and static analyzers)
472 to see whether these functions can be called from other modules.
473 DEFUN now defines a static function. To make the function external
474 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
475 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
476 (Finit_image_library):
16a97296
PE
477 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
478 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
479 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
480 Remove decls, since these functions are now static.
481 (Funintern, Fget_internal_run_time): New decls, since these functions
482 were already external.
95c82688 483
16a97296
PE
484 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
485 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
486 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
487 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
488 * keyboard.c, keymap.c, lread.c:
489 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
490 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
491 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
492 Mark functions with DEFUE instead of DEFUN,
493 if they are used in other modules.
494 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
495 decls for now-static functions.
496 * buffer.h (Fdelete_overlay): Remove decl.
497 * callproc.c (Fgetenv_internal): Mark as internal.
498 * composite.c (Fremove_list_of_text_properties): Remove decl.
499 (Fcomposition_get_gstring): New forward static decl.
500 * composite.h (Fcomposite_get_gstring): Remove decl.
501 * dired.c (Ffile_attributes): New forward static decl.
502 * doc.c (Fdocumntation_property): New forward static decl.
503 * eval.c (Ffetch_bytecode): New forward static decl.
504 (Funintern): Remove extern decl; now in .h file where it belongs.
505 * fileio.c (Fmake_symbolic_link): New forward static decl.
506 * image.c (Finit_image_library): New forward static decl.
507 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
508 * intervals.h (Fprevious_property_change):
509 (Fremove_list_of_text_properties): Remove decls.
510 * keyboard.c (Fthis_command_keys): Remove decl.
511 (Fcommand_execute): New forward static decl.
512 * keymap.c (Flookup_key): New forward static decl.
513 (Fcopy_keymap): Now static.
514 * keymap.h (Flookup_key): Remove decl.
515 * process.c (Fget_process): New forward static decl.
516 (Fprocess_datagram_address): Mark as internal.
517 * syntax.c (Fsyntax_table_p): New forward static decl.
518 (skip_chars): Remove duplicate decl.
519 * textprop.c (Fprevious_property_change): New forward static decl.
520 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
521 Now internal.
522 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
523 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
524
785bbd42
PE
525 * editfns.c (Fformat): Remove unreachable code.
526
8b913b57
AS
5272011-04-14 Andreas Schwab <schwab@linux-m68k.org>
528
529 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
530 change. (Bug#8496)
531
a6744a35
EZ
5322011-04-13 Eli Zaretskii <eliz@gnu.org>
533
534 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
535 when at ZV. (Bug#8487)
536
e7974947
AS
5372011-04-12 Andreas Schwab <schwab@linux-m68k.org>
538
baad03f0
AS
539 * charset.c (Fclear_charset_maps): Use xfree instead of free.
540 (Bug#8437)
541 * keyboard.c (parse_tool_bar_item): Likewise.
542 * sound.c (sound_cleanup, alsa_close): Likewise.
543 * termcap.c (tgetent): Likewise.
544 * xfns.c (x_default_font_parameter): Likewise.
545 * xsettings.c (read_and_apply_settings): Likewise.
546
e7974947
AS
547 * alloc.c (overrun_check_malloc, overrun_check_realloc)
548 (overrun_check_free): Protoize.
549
28272684
PE
5502011-04-12 Paul Eggert <eggert@cs.ucla.edu>
551
552 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
553 since callers should never pass a negative size.
554 Change the signature to match that of plain 'read' and 'write'; see
555 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
556 * lisp.h: Update prototypes of emacs_write and emacs_read.
557
11997c76
EZ
5582011-04-11 Eli Zaretskii <eliz@gnu.org>
559
560 * xdisp.c (redisplay_window): Don't try to determine the character
561 position of the scroll margin if the window start point w->startp
e896f03c 562 is outside the buffer's accessible region. (Bug#8468)
11997c76 563
8a2cbd72
EZ
5642011-04-10 Eli Zaretskii <eliz@gnu.org>
565
566 Fix write-region and its subroutines for buffers > 2GB.
567 * fileio.c (a_write, e_write): Modify declaration of arguments and
568 local variables to support buffers larger than 2GB.
569 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
570
571 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
572 argument, local variables, and return value.
573
574 * lisp.h: Update prototypes of emacs_write and emacs_read.
575
576 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
577
4073e537 5782011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 579
1ebfdcb6
PE
580 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
581
b2ded58d
PE
582 Fix more problems found by GCC 4.6.0's static checks.
583
7d66342c
PE
584 * xdisp.c (vmessage): Use a better test for character truncation.
585
bbf47d44
PE
586 * charset.c (load_charset_map): <, not <=, for optimization,
587 and to avoid potential problems with integer overflow.
9248994d 588 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 589 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 590 * editfns.c (Fformat): Likewise.
1e69125e 591 * syntax.c (skip_chars): Likewise.
3befa583 592
e3019616
PE
593 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
594 This also lets GCC 4.6.0 generate slightly better loop code.
595
becfa255
PE
596 * callint.c (Fcall_interactively): <, not <=, for optimization.
597 (Fcall_interactively): Count the number of arguments produced,
598 not the number of arguments given. This is simpler and lets GCC
599 4.6.0 generate slightly better code.
600
dae0cd48
PE
601 * ftfont.c: Distingish more carefully between FcChar8 and char.
602 The previous code passed unsigned char * to a functions like
603 strlen and xstrcasecmp that expect char *, which does not
604 conform to the C standard.
605 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
606 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
607 char * when the C standard requires it.
608
76032d70
PE
609 * keyboard.c (read_char): Remove unused var.
610
eb3f1cc8
PE
611 * eval.c: Port to Windows vsnprintf (Bug#8435).
612 Include <limits.h>.
613 (SIZE_MAX): Define if the headers do not.
614 (verror): Do not give up if vsnprintf returns a negative count.
615 Instead, grow the buffer. This ports to Windows vsnprintf, which
616 does not conform to C99. Problem reported by Eli Zaretskii.
617 Also, simplify the allocation scheme, by avoiding the need for
618 calling realloc, and removing the ALLOCATED variable.
619
70476b54
PE
620 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
621
12020a9e
PE
622 Remove invocations of doprnt, as Emacs now uses vsnprintf.
623 But keep the doprint source code for now, as we might revamp it
624 and use it again (Bug#8435).
ea6c7ae6
PE
625 * lisp.h (doprnt): Remove.
626 * Makefile.in (base_obj): Remove doprnt.o.
627 * deps.mk (doprnt.o): Remove.
628
5fdb398c
PE
629 error: Print 32- and 64-bit integers portably (Bug#8435).
630 Without this change, on typical 64-bit hosts error ("...%d...", N)
631 was used to print both 32- and 64-bit integers N, which relied on
632 undefined behavior.
633 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
634 New macro.
635 * lisp.h (error, verror): Mark as printf-like functions.
636 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
637 Report overflow in size calculations when allocating printf buffer.
638 Do not truncate output string at its first null byte.
639 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
640 Truncate the output at a character boundary, since vsnprintf does not
641 do that.
642 * charset.c (check_iso_charset_parameter): Convert internal
643 character to string before calling 'error', since %c now has the
644 printf meaning.
645 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
646 overflow when computing char to be passed to 'error'. Do not
647 pass Lisp_Object to 'error'; pass the integer instead.
648 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
649 formatted with plain %d.
650
b189fa66
PE
651 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
652
bff87ef0
PE
653 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
654
7e2cac20
PE
655 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
656
ce4d90b5
PE
657 * xterm.c (x_catch_errors): Remove duplicate declaration.
658
266c9547
PE
659 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
660
79c49ad2
PE
661 * xdisp.c, lisp.h (message_nolog): Remove; unused.
662
368f4090
JM
6632011-04-10 Jim Meyering <meyering@redhat.com>
664
665 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
666 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
667 return ssize_t not "int", and use size_t as the buffer length.
668 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
669 * gnutls.h: Update declarations.
670 * process.c (read_process_output): Use ssize_t, to match.
671 (send_process): Likewise.
672
a32d4040
CY
6732011-04-09 Chong Yidong <cyd@stupidchicken.com>
674
675 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
676
8546720e 6772011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 678
8546720e
GM
679 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
680 unsigned char, to match FcChar8 type definition.
aac0c6e3 681
8546720e
GM
682 * xterm.c (handle_one_xevent):
683 * xmenu.c (create_and_show_popup_menu):
684 * xselect.c (x_decline_selection_request)
685 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 686
0a2f5c1a 6872011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
688
689 Fix some uses of `int' instead of EMACS_INT.
690 * search.c (string_match_1, fast_string_match)
691 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
692 (scan_buffer, find_next_newline_no_quit)
693 (find_before_next_newline, search_command, Freplace_match)
694 (Fmatch_data): Make some `int' variables be EMACS_INT.
695
696 * xdisp.c (display_count_lines): 3rd argument and return value now
697 EMACS_INT. All callers changed.
698 (pint2hrstr): Last argument is now EMACS_INT.
699
700 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
701 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
702 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
703 (decode_coding_utf_16, decode_coding_emacs_mule)
704 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
705 (decode_coding_ccl, decode_coding_charset)
706 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
707 (decode_coding_iso_2022, decode_coding_emacs_mule)
708 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
709 <char_offset, last_offset>: Declare EMACS_INT.
710 (encode_coding_utf_8, encode_coding_utf_16)
711 (encode_coding_emacs_mule, encode_invocation_designation)
712 (encode_designation_at_bol, encode_coding_iso_2022)
713 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
714 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
715 Declare EMACS_INT.
716 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
717 (encode_invocation_designation): Last argument P_NCHARS is now
718 EMACS_INT.
719 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
720 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
721
722 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
723 All users changed.
724
725 * ccl.c (Fccl_execute_on_string): Declare some variables
726 EMACS_INT.
727
8546720e 7282011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
729
730 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
731
4e19a977
CS
7322011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
733
734 * process.c (Fformat_network_address): Doc fix.
735
87302331
R
7362011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
737
738 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
739
cbb59342
CY
7402011-04-08 Chong Yidong <cyd@stupidchicken.com>
741
742 * keyboard.c (read_char): Call Lisp function help-form-show,
743 instead of using internal_with_output_to_temp_buffer.
744 (Qhelp_form_show): New var.
e0d38eeb 745 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
746
747 * print.c (internal_with_output_to_temp_buffer): Function deleted.
748
749 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
750
e67a13ab
CY
7512011-04-06 Chong Yidong <cyd@stupidchicken.com>
752
753 * process.c (Flist_processes): Removed to Lisp.
754 (list_processes_1): Deleted.
755
973f782d
EZ
7562011-04-06 Eli Zaretskii <eliz@gnu.org>
757
7c106b1e
EZ
758 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
759
973f782d
EZ
760 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
761
41cf7d1a 7622011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 763
ca23cc88
PE
764 Fix more problems found by GCC 4.6.0's static checks.
765
f390e2d5
PE
766 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
767
42eea0d0
PE
768 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
769
b69769da 770 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 771
f9541e84
PE
772 * xdisp.c (vmessage): Mark as a printf-like function.
773
13841b55
PE
774 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
775
c136c10f
PE
776 * sound.c (sound_warning): Don't crash if arg contains a printf format.
777
5e2d4a30
PE
778 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
779 printf-like functions.
780 (tiff_load): Add casts to remove these marks before passing them
781 to system-supplied API.
782
583f48b9
PE
783 * eval.c (Fsignal): Remove excess argument to 'fatal'.
784
b25d760e
PE
785 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
786 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
787 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
788 directly, rather than having caller test rule sign. This avoids
789 some unnecessary tests.
790 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
791 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
792 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 793
bc7b6697 794 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 795 (xfont_open): Avoid unnecessary tests.
bc7b6697 796
27ccc379
PE
797 * composite.c (composition_gstring_put_cache): Use unsigned integer.
798
dcd5c89a
PE
799 * composite.h, composite.c (composition_gstring_put_cache):
800 Use EMACS_INT, not int, for length.
801
b13a45c6
PE
802 * composite.h (COMPOSITION_DECODE_REFS): New macro,
803 breaking out part of COMPOSITION_DECODE_RULE.
804 (COMPOSITION_DECODE_RULE): Use it.
805 * composite.c (get_composition_id): Remove unused local vars,
806 by using the new macro.
807
1e792e4d
PE
808 * textprop.c (set_text_properties_1): Change while to do-while,
809 since the condition is always true at first.
810
dc6c6455 811 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
812 (interval_deletion_adjustment): Return unsigned value.
813 All uses changed.
dc6c6455 814
aba7731a
PE
815 * process.c (list_processes_1, create_pty, read_process_output):
816 (exec_sentinel): Remove vars that were set but not used.
afd4052b 817 (create_pty): Remove unnecessary "volatile"s.
bc57d757 818 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 819 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 820 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 821
fdfc4bf3
PE
822 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
823
fca8fe46 824 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 825 (update_syntax_table): Use unsigned instead of int.
fca8fe46 826
06a0259a 827 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 828 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 829 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 830
e7b9e80f
PE
831 * print.c (print_error_message): Avoid int overflow.
832
56201685
PE
833 * font.c (font_list_entities): Redo for clarity,
834 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
835
78834453 836 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 837 (font_score): Avoid potential overflow in diff calculation.
78834453 838
0bc0b309 839 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 840 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 841
e610eaca
PE
842 * eval.c (funcall_lambda): Rename local to avoid shadowing.
843
b895abce
PE
844 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
845 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
846 can always succeed if overflow has undefined behavior.
847
1f1d9321 848 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 849 (wordify): Omit three unnecessary tests.
1f1d9321 850
c59478bc
PE
851 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
852 All callers changed. This avoids the need for an unused var.
853
79b73827
PE
854 * casefiddle.c (casify_region): Remove var that is set but not used.
855
a4db5dfe
PE
856 * dired.c (file_name_completion): Remove var that is set but not used.
857
43aae36e
PE
858 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
859
2a47c44d 860 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 861 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 862
a37c69bf
PE
863 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
864 Check for integer overflow on size calculations.
865
328ab8e7
PE
866 * buffer.c (Fprevious_overlay_change): Remove var that is set
867 but not used.
868
e5a2a5cb
PE
869 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
870 Remove vars that are set but not used.
8d84a6eb 871 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 872 (timer_check_2): Mark vars as initialized.
e5a2a5cb 873
a60e5f68
PE
874 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
875
f661cb61 876 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 877 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 878
f0397f5a
PE
879 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
880 that are set but not used.
881
8664db06 882 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 883 if XCreateBitmapFromData fails (Bug#8410).
8664db06 884
6abdaa4a
PE
885 * xselect.c (x_get_local_selection, x_handle_property_notify):
886 Remove vars that are set but not used.
887
0ce7538d 888 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 889 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 890
9ae848fc
PE
891 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
892 Remove var that is set but not used.
0b918413
PE
893 (scroll_bar_windows_size): Now size_t, not int.
894 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
895 Check for overflow.
9ae848fc 896
a5a62657
PE
897 * xfaces.c (realize_named_face): Remove vars that are set but not used.
898 (map_tty_color) [!defined MSDOS]: Likewise.
899
5c5cdd39
PE
900 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
901
66ebf983
PE
902 * coding.c: Remove vars that are set but not used.
903 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
904 All callers changed.
905 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
906 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
907 (decode_coding_charset): Remove vars that are set but not used.
908
1be4d761
PE
909 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
910 that is set but not used.
911
47553fa8
PE
912 * print.c (print_object): Remove var that is set but not used.
913
1f7196bf 914 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
915 The gnulib version avoids calling malloc in the usual case,
916 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
917 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
918 * filelock.c (current_lock_owner): Likewise.
919 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
920 * sysdep.c: Include allocator.h, careadlinkat.h.
921 (emacs_no_realloc_allocator): New static constant.
922 (emacs_readlink): New function.
fdb61804
PE
923 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
924 ../lib/careadlinkat.h.
d1fdcab7 925
f84c17c7
SM
9262011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
927
928 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
929 first non-nil return value).
930
ef3862ad
JD
9312011-04-03 Jan Djärv <jan.h.d@swipnet.se>
932
933 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
934 if not defined (Bug#8403).
935
376a7006
JB
9362011-04-02 Juanma Barranquero <lekktu@gmail.com>
937
938 * xdisp.c (display_count_lines): Remove parameter `start',
939 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
940 (get_char_face_and_encoding): Remove parameter `multibyte_p',
941 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
942 (fill_stretch_glyph_string): Remove parameters `row' and `area',
943 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
944 and thereabouts. All callers changed.
945 (get_per_char_metric): Remove parameter `f', unused since
946 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
947
6ca3801d
JM
9482011-04-02 Jim Meyering <meyering@redhat.com>
949
950 do not dereference NULL upon failed strdup
951 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
952 (ns_get_family): Likewise.
953
d8e2b5ba
JB
9542011-04-02 Juanma Barranquero <lekktu@gmail.com>
955
956 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
957
8c74fcbd
JD
9582011-04-02 Jan Djärv <jan.h.d@swipnet.se>
959
960 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
961 later (Bug#8403).
962
7200d79c
SM
9632011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
964
03408648 965 Add lexical binding.
7200d79c 966
03408648
SM
967 * window.c (Ftemp_output_buffer_show): New fun.
968 (Fsave_window_excursion):
969 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
970
971 * lread.c (lisp_file_lexically_bound_p): New function.
972 (Fload): Bind Qlexical_binding.
973 (readevalloop): Remove `evalfun' arg.
974 Bind Qinternal_interpreter_environment.
975 (Feval_buffer): Bind Qlexical_binding.
976 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
977 Mark as dynamic.
978 (syms_of_lread): Declare `lexical-binding'.
979
980 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
981
982 * keyboard.c (eval_dyn): New fun.
983 (menu_item_eval_property): Use it.
ca105506
SM
984
985 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 986
03408648
SM
987 * fns.c (concat, mapcar1): Accept byte-code-functions.
988
989 * eval.c (Fsetq): Handle lexical vars.
990 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
991 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
992 (FletX, Flet): Obey lexical binding.
993 (Fcommandp): Handle closures.
994 (Feval): New `lexical' arg.
995 (eval_sub): New function extracted from Feval. Use it almost
996 everywhere where Feval was used. Look up vars in lexical env.
997 Handle closures.
998 (Ffunctionp): Move from subr.el.
999 (Ffuncall): Handle closures.
1000 (apply_lambda): Remove `eval_flags'.
1001 (funcall_lambda): Handle closures and new byte-code-functions.
1002 (Fspecial_variable_p): New function.
1003 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1004 but without exporting it to Lisp.
23aba0ea 1005
23aba0ea 1006 * doc.c (Fdocumentation, store_function_docstring):
03408648 1007 * data.c (Finteractive_form): Handle closures.
23aba0ea 1008
03408648
SM
1009 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1010 interactive spec.
ba83908c 1011
03408648
SM
1012 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1013 byte-codes.
1014 (exec_byte_code): New function extracted from Fbyte_code to handle new
1015 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1016
03408648 1017 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1018
03408648 1019 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1020
e2abce01
JB
10212011-03-31 Juanma Barranquero <lekktu@gmail.com>
1022
1023 * xdisp.c (redisplay_internal): Fix prototype.
1024
63696a73 10252011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1026
63696a73
EZ
1027 * xdisp.c (SCROLL_LIMIT): New macro.
1028 (try_scrolling): Use it when setting scroll_limit. Limit
1029 scrolling to 100 screen lines.
1030 (redisplay_window): Even when falling back on "recentering",
1031 position point in the window according to scroll-conservatively,
1032 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1033
1034 (try_scrolling): When point is above the window, allow searching
1035 as far as scroll_max, or one screenful, to compute vertical
1036 distance from PT to the scroll margin position. This prevents
1037 try_scrolling from unnecessarily failing when
1038 scroll-conservatively is set to a value slightly larger than the
1039 window height. Clean up the case of PT below the margin at bottom
1040 of window: scroll_max can no longer be INT_MAX. When aggressive
1041 scrolling is in use, don't let point enter the opposite scroll
1042 margin as result of the scroll.
1043 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1044 threshold of 100 lines for never-recentering scrolling.
1045
e4cc2dfc
JB
10462011-03-31 Juanma Barranquero <lekktu@gmail.com>
1047
1048 * dispextern.h (move_it_by_lines):
1049 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1050 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1051 (message_log_check_duplicate): Remove parameters `prev_bol' and
1052 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1053 (redisplay_internal): Remove parameter `preserve_echo_area',
1054 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1055
1056 * indent.c (Fvertical_motion):
1057 * window.c (window_scroll_pixel_based, Frecenter):
1058 Don't pass `need_y_p' to `move_it_by_lines'.
1059
1c470562
SM
10602011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1061
44f230aa
SM
1062 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1063 steal a few bits to be more compact.
1064 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1065 Remove unneeded casts.
1066
1c470562
SM
1067 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1068
888adce9
ZK
10692011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1070
1071 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1072 binding" message (bug#7967).
1073
f838ed7b
PE
10742011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1075
77861b95
PE
1076 Fix more problems found by GCC 4.6.0's static checks.
1077
de6dbc14
PE
1078 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1079 Remove unused local var.
1080
f838ed7b
PE
1081 * editfns.c (Fmessage_box): Remove unused local var.
1082
792c7b2b
PE
1083 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1084 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1085 Omit unused local vars.
c499e557 1086 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1087 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1088 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1089 Omit unused local var.
1090
ba0165e1
PE
1091 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1092 Don't assume string length fits in int.
32ad8845 1093 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1094 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1095
3c59b4c9
PE
1096 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1097 instead of alloca (Bug#8344).
1098
a3eed478 1099 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1100 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1101
eb4d412d
PE
1102 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1103
1658b401
PE
1104 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1105 concerns.
1106
1107 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1108
1109 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1110
9a2c6e05
PE
1111 * keyboard.c (syms_of_keyboard): Use the same style as later
1112 in this function when indexing through an array. This also
1113 works around GCC bug 48267.
1114
03d0a109
PE
1115 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1116
44f730c8
PE
1117 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1118
fe75f926
PE
1119 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1120 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1121
ffa8c828
PE
1122 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1123 This avoids undefined behavior on integer overflow, and is a bit
1124 more convenient anyway since it is compared to a size_t variable.
1125
c5101a77
PE
1126 Variadic C functions now count arguments with size_t, not int.
1127 This avoids an unnecessary limitation on 64-bit machines, which
1128 caused (substring ...) to crash on large vectors (Bug#8344).
1129 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1130 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1131 All variadic functions and their callers changed accordingly.
c5101a77
PE
1132 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1133 * data.c (arith_driver, float_arith_driver): Likewise.
1134 * editfns.c (general_insert_function): Likewise.
1135 * eval.c (struct backtrace.nargs, interactive_p)
1136 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1137 (funcall_lambda, mark_backtrace): Likewise.
1138 * fns.c (concat): Likewise.
1139 * frame.c (x_set_frame_parameters): Likewise.
1140 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1141 0 if not found, not -1. All callers changed.
1142
dd3f25f7
PE
1143 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1144 (stack_copy_size): Now size_t, not int.
1145 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1146
461c2ab9
JB
11472011-03-28 Juanma Barranquero <lekktu@gmail.com>
1148
1149 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1150 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1151 All callers changed.
1152
1153 * lisp.h (multibyte_char_to_unibyte):
1154 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1155 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1156 * character.h (CHAR_TO_BYTE8):
1157 * cmds.c (internal_self_insert):
1158 * editfns.c (general_insert_function):
1159 * keymap.c (push_key_description):
1160 * search.c (Freplace_match):
1161 * xdisp.c (message_dolog, set_message_1): All callers changed.
1162
f6d62986
SM
11632011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1164
1165 * keyboard.c (safe_run_hook_funcall): New function.
1166 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1167 don't set the hook to nil, but remove the offending function instead.
1168 (Qcommand_hook_internal): Remove, unused.
1169 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1170 Vcommand_hook_internal.
1171
1172 * eval.c (enum run_hooks_condition): Remove.
1173 (funcall_nil, funcall_not): New functions.
1174 (run_hook_with_args): Call each function through a `funcall' argument.
1175 Remove `cond' argument, now redundant.
1176 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1177 (Frun_hook_with_args_until_failure): Adjust accordingly.
1178 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1179
1db5b1ad
JB
11802011-03-28 Juanma Barranquero <lekktu@gmail.com>
1181
1182 * dispextern.h (string_buffer_position): Remove declaration.
1183
1184 * print.c (strout): Remove parameter `multibyte', unused since
1185 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1186
1187 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1188 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1189 All callers changed.
1190
1191 * w32.c (_wsa_errlist): Use braces for struct initializers.
1192
1193 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1194 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1195 All callers changed.
1196 (string_buffer_position): Likewise. Also, make static (it's never
1197 used outside xdisp.c).
1198 (cursor_row_p): Remove parameter `w', unused since
1199 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1200 (decode_mode_spec): Remove parameter `precision', introduced during
1201 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1202 All callers changed.
1203
5ffb62aa
JD
12042011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1205
1206 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1207
461c2ab9 12082011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1209
1210 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1211 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1212 (ns_update_auto_hide_menu_bar): New functions.
1213 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1214 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1215 ns_constrain_all_frames.
1216 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1217 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1218
5c380ffb
JD
12192011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1220
1221 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1222
9af30bdf
GM
12232011-03-27 Glenn Morris <rgm@gnu.org>
1224
1225 * syssignal.h: Replace RETSIGTYPE with void.
1226 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1227 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1228 Replace SIGTYPE with void everywhere.
1229 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1230 * s/template.h (SIGTYPE): Remove commented out definition.
1231
e2abce01
JB
12322011-03-26 Eli Zaretskii <eliz@gnu.org>
1233
1234 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1235 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1236
f868cd8a
JB
12372011-03-26 Juanma Barranquero <lekktu@gmail.com>
1238
59eb0929
JB
1239 * w32.c (read_unc_volume): Use parameter `henum', instead of
1240 global variable `wget_enum_handle'.
1241
1242 * keymap.c (describe_vector): Remove parameters `indices' and
1243 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1244 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1245
f868cd8a
JB
1246 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1247
1248 * keyboard.c (timer_check): Remove parameter `do_it_now',
1249 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1250 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1251 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1252
1253 * keyboard.c (read_char):
1254 * w32menu.c (w32_menu_display_help):
1255 * xmenu.c (show_help_event, menu_help_callback):
1256 Adjust calls to `show_help_echo'.
1257
1258 * gtkutil.c (xg_maybe_add_timer):
1259 * keyboard.c (readable_events):
1260 * process.c (wait_reading_process_output):
1261 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1262
1263 * insdel.c (adjust_markers_gap_motion):
1264 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1265 (gap_left, gap_right): Don't call it.
1266
2ecf6fdb
CY
12672011-03-25 Chong Yidong <cyd@stupidchicken.com>
1268
1269 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1270 incurred during fontification.
1271
6b1f9ba4
JB
12722011-03-25 Juanma Barranquero <lekktu@gmail.com>
1273
1274 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1275 (DEFVAR_PER_BUFFER): Don't pass it.
1276
1277 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1278 (scrolling_window): Don't pass it.
1279
0f4a96b5
JB
12802011-03-25 Juanma Barranquero <lekktu@gmail.com>
1281
1282 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1283
1284 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1285 and `suffix'.
1286 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1287 of variables specific to SELinux and computation of `encoded_absname'.
1288
1289 * image.c (XPutPixel): Remove unused variable `height'.
1290
1291 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1292
1293 * unexw32.c (get_section_info): Remove unused variable `section'.
1294
1295 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1296 (system_process_attributes): Remove unused variable `sess'.
1297 (sys_read): Remove unused variable `err'.
1298
1299 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1300 (w32_wnd_proc): Remove unused variable `isdead'.
1301 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1302 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1303 (x_create_tip_frame): Remove unused variable `tem'.
1304
1305 * w32inevt.c (w32_console_read_socket):
1306 Remove unused variable `no_events'.
1307
1308 * w32term.c (x_draw_composite_glyph_string_foreground):
1309 Remove unused variable `width'.
1310
1149507c
JB
13112011-03-24 Juanma Barranquero <lekktu@gmail.com>
1312
1313 * w32term.c (x_set_glyph_string_clipping):
1314 Don't pass uninitialized region to CombineRgn.
1315
9c88f339
JB
13162011-03-23 Juanma Barranquero <lekktu@gmail.com>
1317
1318 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1319 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1320 (Fx_close_connection): Remove unused variable `i'.
1321
1322 * w32font.c (w32font_draw): Return number of glyphs.
1323 (w32font_open_internal): Remove unused variable `i'.
1324 (w32font_driver): Add missing initializer.
1325
1326 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1327 (fill_in_menu): Remove unused variable `items_added'.
1328
1329 * w32term.c (last_mouse_press_frame): Remove static global variable.
1330 (w32_clip_to_row): Remove unused variable `f'.
1331 (x_delete_terminal): Remove unused variable `i'.
1332
1333 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1334 (NOTHING): Remove unused static global variable.
1335 (uniscribe_check_otf): Remove unused variable `table'.
1336 (uniscribe_font_driver): Add missing initializers.
1337
dee091a3
JD
13382011-03-23 Julien Danjou <julien@danjou.info>
1339
1340 * term.c (Fsuspend_tty, Fresume_tty):
1341 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1342 * window.c (temp_output_buffer_show):
1343 * insdel.c (signal_before_change):
1344 * frame.c (Fhandle_switch_frame):
1345 * fileio.c (Fdo_auto_save):
1346 * emacs.c (Fkill_emacs):
1347 * editfns.c (save_excursion_restore):
1348 * cmds.c (internal_self_insert):
1349 * callint.c (Fcall_interactively):
1350 * buffer.c (Fkill_all_local_variables):
1351 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1352 Use Frun_hooks.
0f4a96b5 1353 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1354 unconditionnaly since it does the check itself.
1355
2c520ab5 13562011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1357
c9c49752
PE
1358 Fix more problems found by GCC 4.5.2's static checks.
1359
8abc3f12
PE
1360 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1361 the first time through the loop, since we know p0 < p1 then.
1362 This also avoids a gcc -Wstrict-overflow warning.
1363
a2d26660
PE
1364 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1365 leading to a memory leak, possible in functions like
1366 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1367 of objects (Bug#8318).
a2d26660 1368
916c72e9
PE
1369 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1370 that could (at least in theory) be that large.
1371
19ab8a18
PE
1372 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1373 This is less likely to overflow, and avoids undefined behavior if
1374 overflow does occur. All callers changed. Use strtoul to scan
1375 for the unsigned long integer.
b7cbbd6f
PE
1376 (pint2hrstr): Simplify and tune code slightly.
1377 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1378
f0641eff
PE
1379 * scroll.c (do_scrolling): Work around GCC bug 48228.
1380 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1381
7f650bb9
PE
1382 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1383 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1384 (validate_x_resource_name): Simplify count usage.
1385 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1386
37dd57d1
PE
1387 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1388 fail (Bug#8306).
81e56e61 1389
699979fc 1390 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1391
401bf9b4
PE
1392 * process.c (Fmake_network_process): Use socklen_t, not int,
1393 where POSIX says socklen_t is required in portable programs.
1394 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1395 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1396 (Fmake_network_process, server_accept_connection):
1397 (wait_reading_process_output, read_process_output):
1398 Likewise.
1399
b93aacde
PE
1400 * process.c: Rename or move locals to avoid shadowing.
1401 (list_processes_1, Fmake_network_process):
1402 (read_process_output_error_handler, exec_sentinel_error_handler):
1403 Rename or move locals.
4dc343ee 1404 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1405 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1406 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1407 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1408 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1409
af8a867c 1410 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1411 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1412 Include tparam.h instead, since it declares them.
af8a867c
PE
1413 * cm.h (PC): Remove extern decl; tparam.h now does this.
1414 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1415 * terminfo.c: Include tparam.h, to check interfaces.
1416 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1417 (tparam): Adjust signature to match interface in tparam.h;
1418 this removes some undefined behavior. Check that outstring and len
1419 are zero, which they always are with Emacs.
1420 * tparam.h (PC, BC, UP): New extern decls.
1421
0248044d 1422 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1423 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1424
8ff096c1 1425 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1426 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1427 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1428 (ftfont_list): Remove unused local.
49eaafba
PE
1429 (get_adstyle_property, ftfont_pattern_entity):
1430 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1431 Rename locals to avoid shadowing.
8ff096c1 1432
e2be39f6
PE
1433 * xfont.c (xfont_list_family): Mark var as initialized.
1434
c9735e30
PE
1435 * xml.c (make_dom): Now static.
1436
8f5201ae
PE
1437 * composite.c (composition_compute_stop_pos): Rename local to
1438 avoid shadowing.
b246f932
PE
1439 (composition_reseat_it): Remove unused locals.
1440 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1441 (composition_update_it): Mark var as initialized.
11b61122
PE
1442 (find_automatic_composition): Mark vars as initialized,
1443 with a FIXME (Bug#8290).
8f5201ae 1444
760fbc2c
PE
1445 character.h: Rename locals to avoid shadowing.
1446 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1447 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1448 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1449 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1450 to avoid shadowing.
1451
ff08eb85
PE
1452 * textprop.c (property_change_between_p): Remove; unused.
1453
fc7bf025
PE
1454 * intervals.c (interval_start_pos): Now static.
1455
235d7abc
PE
1456 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1457
44f230aa
SM
1458 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1459 Rename locals to avoid shadowing.
3e7d6594 1460
50060332
PE
1461 * sound.c (wav_play, au_play, Fplay_sound_internal):
1462 Fix pointer signedness.
d01f234b 1463 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1464 (wav_play): Initialize a variable to 0, to prevent undefined
1465 behavior (Bug#8278).
50060332 1466
c4fc4e30
PE
1467 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1468
918436ed
PE
1469 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1470
c939f91b
PE
1471 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1472 clobbering (Bug#8298).
b9c7f648
PE
1473 * sysdep.c (sys_subshell): Likewise.
1474 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1475
6bd8c144
PE
1476 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1477 This should get cleaned up, so that child_setup has the
1478 same signature on all platforms.
1479
7710357c 1480 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1481 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1482
c59da222
CY
14832011-03-22 Chong Yidong <cyd@stupidchicken.com>
1484
1485 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1486 not to be necessary, and produces flickering.
1487
66b87493
GM
14882011-03-20 Glenn Morris <rgm@gnu.org>
1489
1490 * config.in: Remove file.
1491
45b6f6d5
JB
14922011-03-20 Juanma Barranquero <lekktu@gmail.com>
1493
1494 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1495 are now in src/globals.h.
1496 (syms_of_minibuf): Remove spurious & from previous change.
1497
3ec03f7e
LL
14982011-03-20 Leo <sdl.web@gmail.com>
1499
1500 * minibuf.c (completing-read-function): New variable.
1501 (completing-read-default): Rename from completing-read.
1502 (completing-read): Call completing-read-function.
1503
b14e3e21
CY
15042011-03-19 Juanma Barranquero <lekktu@gmail.com>
1505
1506 * xfaces.c (Fx_load_color_file):
1507 Read color file from absolute filename (bug#8250).
1508
f2b726e6
JB
15092011-03-19 Juanma Barranquero <lekktu@gmail.com>
1510
1511 * makefile.w32-in: Update dependencies.
1512
09f6ff02
EZ
15132011-03-17 Eli Zaretskii <eliz@gnu.org>
1514
1515 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1516
29a6015a
PE
15172011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1518
a3a6c54e
PE
1519 Fix more problems found by GCC 4.5.2's static checks.
1520
b766f867
PE
1521 * process.c (make_serial_process_unwind, send_process_trap):
1522 (sigchld_handler): Now static.
1523
be02381c
PE
1524 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1525 That way, the code declares only the vars that it needs.
1526 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1527 * s/cygwin.h (PTY_ITERATION): Likewise.
1528 * s/darwin.h (PTY_ITERATION): Likewise.
1529 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1530
57048744
PE
1531 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1532 * process.c (allocate_pty): Don't declare stb unless it's needed.
1533
7914961c 1534 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1535 (CONSTANTLIM): Remove; unused.
1536 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1537 Define only if needed.
7914961c 1538
b3967b18
PE
1539 * unexelf.c (unexec): Name an expression,
1540 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1541 Use a different way to cause a compilation error if anyone uses
1542 n rather than nn, a way that does not involve shadowing.
73366a00 1543 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1544
29a6015a
PE
1545 * deps.mk (unexalpha.o): Remove; unused.
1546
43cfc33e 1547 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1548 * unexec.h: New file.
ce701a33
PE
1549 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1550 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1551 Depend on unexec.h.
1552 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1553 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1554 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1555 Change as necessary to match prototype in unexec.h.
ce701a33 1556
01f44d5a
PE
1557 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1558 shadowing.
4f63c6bb 1559 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1560
a6670b0b
PE
1561 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1562 Rename locals to avoid shadowing.
1563
cef2010d 1564 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1565 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1566
d4d7173a
PE
1567 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1568
f08b802a
PE
1569 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1570 warning when compiling print.c.
1571
3ddb0639
PE
1572 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1573 instead of using an uninitialized var.
5ad03b97 1574 (font_sort_entities): Mark var as initialized.
3ddb0639 1575
170a2692
PE
1576 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1577
e663c700
PE
1578 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1579 pointers to constants.
89bc529a 1580 (font_parse_fcname): Remove unused vars.
7b81e2d0 1581 (font_delete_unmatched): Now static.
ea838e10 1582 (font_get_spec): Remove; unused.
13a547c6
PE
1583 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1584 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1585 Rename or move locals to avoid shadowing.
e663c700 1586
2a80c887 1587 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1588 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1589
1384fa33 1590 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1591 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1592
8b2c52e9
PE
1593 * alloc.c (mark_backtrace): Move decl from here ...
1594 * lisp.h: ... to here, so that it can be checked.
1595
475545b5 1596 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1597 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1598 (lisp_indirect_variable): Name an expression,
1599 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1600 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1601
b1349114 1602 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1603 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1604 Use const pointer when appropriate.
b1349114 1605
a2928364
PE
1606 * lisp.h (get_system_name, get_operating_system_release):
1607 Move decls here, to check interfaces.
1608 * process.c (get_operating_system_release): Move decl to lisp.h.
1609 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1610 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1611 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1612 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1613 (Fformat_time_string, Fencode_time, Finsert_char):
1614 (Ftranslate_region_internal, Fformat):
1615 Rename or remove local vars to avoid shadowing.
9710023e 1616 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1617
a415e694
PE
1618 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1619 avoid shadowing.
1620
8ef4622d
PE
1621 * lisp.h (eassert): Check that the argument compiles, even if
1622 ENABLE_CHECKING is not defined.
1623
946f9a5b
PE
1624 * data.c (Findirect_variable): Name an expression, to avoid
1625 gcc -Wbad-function-cast warning.
112396d6 1626 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1627 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1628 (Fmake_variable_buffer_local, Fmake_local_variable):
1629 Mark variables as initialized.
52746918 1630 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1631
e5aab7e7 1632 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1633 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1634 Rename locals to avoid shadowing.
dff45157
PE
1635 (mark_stack): Move local variables into the #ifdef region where
1636 they're used.
7bc26fdb
PE
1637 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1638 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1639 needed otherwise.
1640 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1641 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1642 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1643
e5aab7e7
PE
1644 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1645 avoids undefined behavior in theory.
1646
4da60324
PE
1647 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1648
88043301
PE
1649 Use functions, not macros, for up- and down-casing (Bug#8254).
1650 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1651 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1652 to use the following functions instead of these macros.
1653 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1654 EMACS_INT, since callers assume the returned value fits in int.
1655 (upcase1): Likewise, for UPCASE_TABLE.
1656 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1657 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1658 the race-condition problem in the old DOWNCASE.
88043301 1659
19ed5445
PE
1660 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1661 Rename locals to avoid shadowing.
1662 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1663 (regex_compile, re_search_2, re_match_2_internal):
1664 Remove unused local vars.
952db0d7
PE
1665 (FREE_VAR): Rewrite so as not to use empty "else",
1666 which gcc can warn about.
da053e48 1667 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1668 (RETALLOC_IF): Define only if needed.
1669 (WORDCHAR_P): Likewise. This one is never needed, but is used
1670 only in a comment talking about a compiler bug, so put inside
1671 the #if 0 of that comment.
1672 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1673 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1674 Remove; unused.
19ed5445 1675
1f3561e4 1676 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1677 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1678 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1679
ded6f8f7
PE
1680 * search.c (simple_search): Remove unused var.
1681
dbd37a95
PE
1682 * dired.c (compile_pattern): Move decl from here ...
1683 * lisp.h: ... to here, so that it can be checked.
1684 (struct re_registers): New forward decl.
1685
7e47afad
PE
1686 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1687
85f24f61
PE
1688 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1689 All uses changed.
1690 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1691 Rename locals to avoid shadowing.
5671df8f 1692 (Fvertical_motion): Mark locals as initialized.
85f24f61 1693
181aa2be 1694 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1695 (casify_region): Mark local as initialized.
181aa2be 1696
930d429c
PE
1697 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1698
7082eac6
PE
1699 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1700 New macros, so that the caller can use some names other than
1701 gcpro1, gcpro2, etc.
1702 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1703 of the new macros.
1704 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1705 argument, for consistency with GCPRO2_VAR, etc: it is now the
1706 prefix of the variable, not the variable itself. All uses
1707 changed.
38b2c076
PE
1708 * dired.c (directory_files_internal, file_name_completion):
1709 Rename locals to avoid shadowing.
1710
15206ed9
PE
1711 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1712 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1713 dired.c's scmp function, had undefined behavior.
1714 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1715 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1716 * buffer.h: ... to here, because these macros use current_buffer,
1717 and the new implementation with inline functions needs to have
1718 current_buffer in scope now, rather than later when the macros
1719 are used.
1720 (downcase, upcase1): New static inline functions.
1721 (DOWNCASE, UPCASE1): Reimplement using these functions.
1722 This avoids undefined behavior in expressions like
1723 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1724 from race conditions in accessing the global variables
1725 case_temp1 and case_temp2.
1726 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1727 * lisp.h (case_temp1, case_temp2): Remove their decls.
1728 * character.h (ASCII_CHAR_P): Move from here ...
1729 * lisp.h: ... to here, so that the inline functions mentioned
1730 above can use them.
1731
4a6bea26
PE
1732 * dired.c (directory_files_internal_unwind): Now static.
1733
f14b7e14
PE
1734 * fileio.c (file_name_as_directory, directory_file_name):
1735 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1736 Now static.
2893f146
PE
1737 (file_name_as_directory): Use const pointers when appropriate.
1738 (Fexpand_file_name): Likewise. In particular, newdir might
1739 point at constant storage, so make it a const pointer.
fd4ead52 1740 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1741 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1742 signedness issues.
f839df0c
PE
1743 (Fset_file_times, Finsert_file_contents, auto_save_error):
1744 Rename locals to avoid shadowing.
f14b7e14 1745
5716756e 1746 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1747 (Ftry_completion, Fall_completions): Rename or remove locals
1748 to avoid shadowing.
5716756e 1749
b4c3046a
PE
1750 * marker.c (bytepos_to_charpos): Remove; unused.
1751
b45db522
PE
1752 * lisp.h (verify_bytepos, count_markers): New decls,
1753 so that gcc does not warn that these functions aren't declared.
1754
85876d07
PE
1755 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1756 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1757 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1758 (copy_text): Remove unused local var.
85876d07 1759
03d78a21 1760 * filelock.c (within_one_second): Now static.
b3dd38ab 1761 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1762
5df8f01b
PE
1763 * buffer.c (fix_overlays_before): Mark locals as initialized.
1764 (fix_start_end_in_overlays): Likewise. This function should be
1765 simplified by using pointers-to-pointers, but that's a different
1766 matter.
b1d876f1 1767 (switch_to_buffer_1): Now static.
8f54f30a
PE
1768 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1769 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1770
a70072c9 1771 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1772 Fix pointer signedness issue.
edced198
PE
1773 (sys_subshell): Mark local as volatile if checking for lint,
1774 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1775 (MAXPATHLEN): Define only if needed.
a70072c9 1776
a0977c44
PE
1777 * process.c (serial_open, serial_configure): Move decls from here ...
1778 * systty.h: ... to here, so that they can be checked.
1779
a884fdcc
PE
1780 * fns.c (get_random, seed_random): Move extern decls from here ...
1781 * lisp.h: ... to here, so that they can be checked.
1782
604efe86 1783 * sysdep.c (reset_io): Now static.
b8950c94 1784 (wait_for_termination_signal): Remove; unused.
604efe86 1785
38fc62d9
PE
1786 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1787 (copy_keymap_item, append_key, push_text_char_description):
1788 Now static.
1004a21a 1789 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1790 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1791 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1792 (describe_map_tree):
1793 Rename locals to avoid shadowing.
38fc62d9 1794
2f2650da
PE
1795 * keyboard.c: Declare functions static if they are not used elsewhere.
1796 (echo_char, echo_dash, cmd_error, top_level_2):
1797 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1798 (read_char, kbd_buffer_get_event, make_lispy_position):
1799 (make_lispy_event, make_lispy_movement, apply_modifiers):
1800 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1801 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1802 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1803 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1804 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1805
a053e86c 1806 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1807 (mark_kboards): Move decl here ...
1808 * alloc.c (mark_kboards): ... from here.
a053e86c 1809
4752793e
PE
1810 * lisp.h (force_auto_save_soon): New decl.
1811
74f10ca7 1812 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1813 (DEFINE_DUMMY_FUNCTION): New macro.
1814 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1815 Use it.
c03cd23f
PE
1816 (main): Add casts to avoid warnings
1817 if GCC considers string literals to be constants.
74f10ca7 1818
022e70d4
PE
1819 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1820
59d6fe83
PE
1821 * dbusbind.c: Pointer signedness fixes.
1822 (xd_signature, xd_append_arg, xd_initialize):
1823 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1824 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1825 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1826 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1827
78320123
PE
1828 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1829 if GCC considers string literals to be constants.
49cebcca 1830 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1831
35ac2a97
SM
18322011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1833
fb103ca9
SM
1834 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1835 (print_preprocess, print_object): New macro to fix last change.
1836
35ac2a97
SM
1837 * print.c (print_preprocess): Don't forget font objects.
1838
62973b41
JB
18392011-03-16 Juanma Barranquero <lekktu@gmail.com>
1840
1841 * emacs.c (USAGE3): Doc fixes.
1842
0e48bb22
AS
18432011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1844
1845 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1846 structure.
1847
7684e57b
JB
18482011-03-14 Juanma Barranquero <lekktu@gmail.com>
1849
1850 * lisp.h (VWindow_system, Qfile_name_history):
1851 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1852 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1853 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1854
1855 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1856 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1857
1858 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1859 * w32console.c (detect_input_pending, read_input_pending)
1860 (encode_terminal_code):
1861 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1862 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1863 (w32_system_caret_y, Qfile_name_history):
1864 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1865 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1866 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1867 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1868 * w32proc.c (Qlocal, report_file_error):
1869 * w32term.c (Vwindow_system, updating_frame):
1870 * w32uniscribe.c (initialized, uniscribe_font_driver):
1871 Remove unneeded extern declarations.
1872
2aa46d6c
CY
18732011-03-14 Chong Yidong <cyd@stupidchicken.com>
1874
c96bbc66 1875 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1876
cffc6f3b
CY
18772011-03-13 Chong Yidong <cyd@stupidchicken.com>
1878
1879 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1880 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1881 These macros can no longer be used for assignment.
1882
44f230aa
SM
1883 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1884 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1885 (record_buffer_markers, fetch_buffer_markers): New functions for
1886 recording and fetching special buffer markers.
1887 (set_buffer_internal_1, set_buffer_temp): Use them.
1888
1889 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1890
1891 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1892
1893 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1894 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1895
1896 * xdisp.c (hscroll_window_tree):
1897 (reconsider_clip_changes): Use PT instead of BUF_PT.
1898
d251f04b
EZ
18992011-03-13 Eli Zaretskii <eliz@gnu.org>
1900
1901 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1902 $(EMACS_ROOT)/lib/intprops.h.
1903
f0c77cd1
PE
19042011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1905
3eca4629
PE
1906 Fix more problems found by GCC 4.5.2's static checks.
1907
7c86ee98
PE
1908 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1909 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1910 (xg_free_frame_widgets): Make it clear that a local variable is
1911 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1912 (gdk_window_get_screen): Make it clear that this macro is needed
1913 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1914 (int_gtk_range_get_value): New function, which avoids a diagnostic
1915 from gcc -Wbad-function-cast.
1916 (xg_set_toolkit_scroll_bar_thumb): Use it.
1917 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1918 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1919 (get_utf8_string, xg_get_file_with_chooser):
1920 Rename locals to avoid shadowing.
1921 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1922
41729b81
PE
1923 * xgselect.c (xg_select): Remove unused var.
1924
f0c77cd1
PE
1925 * image.c (four_corners_best): Mark locals as initialized.
1926 (gif_load): Initialize transparent_p to zero (Bug#8238).
1927 Mark another local as initialized.
ec6cf4c6 1928 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1929
ce0ad53d 1930 * image.c (clear_image_cache): Now static.
d5d5a617 1931 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1932 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1933 (x_edge_detection): Remove unnecessary cast that
1934 gcc -Wbad-function-cast diagnoses.
2037898d 1935 (gif_load): Fix pointer signedness.
6ae141d6
PE
1936 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1937 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1938
33383987 19392011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1940
d32df629
PE
1941 Improve quality of tests for time stamp overflow.
1942 For example, without this patch (encode-time 0 0 0 1 1
1943 1152921504606846976) returns the obviously-bogus value (-948597
1944 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1945 reports time overflow. See
1946 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1947 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1948 * editfns.c: Include limits.h and intprops.h.
1949 (TIME_T_MIN, TIME_T_MAX): New macros.
1950 (time_overflow): Move earlier, to before first use.
1951 (hi_time, lo_time): New functions, for an accurate test for
1952 out-of-range times.
1953 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1954 (Fget_internal_run_time): Don't assume time_t fits in int.
1955 (make_time): Use list2 instead of Fcons twice.
1956 (Fdecode_time): More accurate test for out-of-range times.
1957 (check_tm_member): New function.
1958 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1959 (lisp_time_argument): Don't rely on undefined left-shift and
1960 right-shift behavior when checking for time stamp overflow.
8be6f318 1961
fe31d94c
PE
1962 * editfns.c (time_overflow): New function, refactoring common code.
1963 (Fformat_time_string, Fdecode_time, Fencode_time):
1964 (Fcurrent_time_string): Use it.
1965
8be6f318
PE
1966 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1967 * dired.c (make_time): Move to ...
1968 * editfns.c (make_time): ... here.
1969 * systime.h: Note the move.
1970
09d9db2c 19712011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1972
126bc0dc
YM
1973 * fringe.c (update_window_fringes): Remove unused variables.
1974
c47cbdfd
YM
1975 * unexmacosx.c (copy_data_segment): Also copy __got section.
1976 (Bug#8223)
1977
7ac80be9
EZ
19782011-03-12 Eli Zaretskii <eliz@gnu.org>
1979
c96bbc66 1980 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1981 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1982 Constify `char *' arguments and their references according to
1983 prototypes in tparam.h.
1984
ecb0f94d 1985 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1986
7ac80be9
EZ
1987 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1988 Adapt all references accordingly.
1989
1990 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1991
ef1fd07e
TT
19922011-03-11 Tom Tromey <tromey@redhat.com>
1993
1994 * buffer.c (syms_of_buffer): Remove obsolete comment.
1995
7ef4b50c
EZ
19962011-03-11 Eli Zaretskii <eliz@gnu.org>
1997
1998 * termhooks.h (encode_terminal_code): Declare prototype.
1999
2000 * msdos.c (encode_terminal_code): Don't declare prototype.
2001
2002 * term.c (encode_terminal_code): Now external again, used by
2003 w32console.c and msdos.c.
2004
44f230aa
SM
2005 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2006 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2007
4b1ec863 20082011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2009
1714f52b 2010 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2011
4b1ec863
PE
2012 * fringe.c (update_window_fringes): Mark locals as initialized
2013 (Bug#8227).
2014 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2015
524c7aa6
PE
2016 * alloc.c (mark_fringe_data): Move decl from here ...
2017 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2018 to check its interface.
2019 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2020
a5c0af81 2021 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2022 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2023 (fontset_font): Mark local as initialized.
a9a06e0b 2024 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2025
b4716021
PE
2026 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2027
811e9bac 2028 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2029 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2030 (x_own_selection, Fx_disown_selection_internal): Rename locals
2031 to avoid shadowing.
2032 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2033
7e3ab302
PE
2034 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2035 so that the caller can use some name other than gcpro1.
2036 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2037 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2038 (Fx_backspace_delete_keys_p):
2039 Use them to avoid shadowing, and rename vars to avoid shadowing.
2040 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2041 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2042 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2043 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2044 Remove unused locals.
7e3ab302
PE
2045 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2046 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2047 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2048 macros.
f78faa98 2049
e2b13473
PE
2050 * xterm.h (x_mouse_leave): New decl.
2051
77f23912
PE
2052 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2053 Remove unused functions.
cdf4ba58
PE
2054 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2055 (x_calc_absolute_position): Now static.
7411c686 2056 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2057 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2058 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2059 unless they are used.
38d0b34a
PE
2060 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2061 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2062 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2063 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2064 (x_error_catcher, x_connection_closed, x_error_handler):
2065 (x_error_quitter, xembed_send_message, x_iconify_frame):
2066 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2067 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2068 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2069
44f230aa
SM
2070 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2071 Rename or move locals to avoid shadowing.
6b463e58 2072 (tty_defined_color, merge_face_heights): Now static.
5967d051 2073 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2074 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2075 does not deduce is never used uninitialized.
73719eba
PE
2076 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2077 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2078
426994c3 2079 * terminal.c (store_terminal_param): Now static.
5489860b 2080
032f1620 2081 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2082 (set_frame_menubar): Remove unused local.
d4323972 2083 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2084 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2085 since they might point to immutable storage.
281585b0
PE
2086 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2087 since it's unused otherwise.
032f1620 2088
367c19e5 2089 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2090 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2091 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2092 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2093 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2094 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2095 does not deduce are never used uninitialized.
70739cbe 2096
07b48fa9
PE
2097 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2098
8868a238 2099 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2100 * window.c (window_loop, size_window):
2101 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2102
7e5cf297 2103 * window.c (display_buffer): Now static.
d6550a9f
PE
2104 (size_window): Mark variables that gcc -Wuninitialized
2105 does not deduce are never used uninitialized.
a586633d
PE
2106 * window.h (check_all_windows): New decl, to forestall
2107 gcc -Wmissing-prototypes diagnostic.
5b555da1 2108 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2109
f6095868
PE
2110 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2111 shadowing.
2112 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2113 Include <limits.h>.
2114 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2115 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2116 (load_charset_map): Mark variables that gcc -Wuninitialized
2117 does not deduce are never used uninitialized.
53df7c11 2118 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2119
f38b440c
PE
2120 * coding.c (coding_set_source, coding_set_destination):
2121 Use "else { /* comment */ }" rather than "else /* comment */;"
2122 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2123 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2124 a block, when the outer 'i' will do.
2125 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2126 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2127 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2128 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2129 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2130 Rename locals to avoid shadowing.
2131 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2132 * coding.c (emacs_mule_char, encode_invocation_designation):
2133 Now static, since they're not used elsewhere.
413bb2db 2134 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2135 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2136 (decode_coding_emacs_mule): Mark variables that gcc
2137 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2138 (detect_coding_iso_2022): Initialize a local variable that might
2139 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2140 this initialization is needed. (Bug#8211)
5f58e762
PE
2141 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2142 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2143 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2144 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2145 Remove unused macros.
f38b440c 2146
232b38b9 2147 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2148 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2149 * character.c (string_count_byte8): Likewise.
232b38b9 2150
fb90da1b
PE
2151 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2152 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2153
fb93dbc2
PE
2154 * chartab.c (copy_sub_char_table): Now static, since it's not used
2155 elsewhere.
5c156ace
PE
2156 (sub_char_table_ref_and_range, char_table_ref_and_range):
2157 Rename locals to avoid shadowing.
bbcd0949 2158 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2159
7d3b3862 2160 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2161 (BIDI_BOB): Remove unused macro.
7d3b3862 2162
6be7d3da
PE
2163 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2164 deduce are never used uninitialized.
c2ed9c8b 2165 * term.c (encode_terminal_code): Likewise.
6be7d3da 2166
75f8807f 2167 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2168
50938595
PE
2169 * tparam.h: New file.
2170 * term.c, tparam.h: Include it.
2171 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2172 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2173 Move these decls to tparam.h, and make them agree with what
2174 is actually in tparam.c. The previous trick of using incompatible
2175 decls in different modules does not conform to the C standard.
2176 All callers of tparam changed to use tparam's actual API.
2177 * tparam.c (tparam1, tparam, tgoto):
2178 Use const pointers where appropriate.
2179
fbceeba2
PE
2180 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2181 * cm.h (struct cm): Likewise.
2182 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2183 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2184 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2185 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2186 (turn_on_face, init_tty): Likewise.
2187 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2188
7f3f1250
PE
2189 * term.c (term_mouse_position): Rename local to avoid shadowing.
2190
e6ca6543
PE
2191 * alloc.c (mark_ttys): Move decl from here ...
2192 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2193
c40f8d15
AS
21942011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2195
2196 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2197
cfe0661d
JB
21982011-03-09 Juanma Barranquero <lekktu@gmail.com>
2199
2200 * search.c (compile_pattern_1): Remove argument regp, unused since
2201 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2202 (compile_pattern): Don't pass it.
2203
0afb4571
J
22042011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2205
2206 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2207 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2208 for ! HAVE_GTK3.
2209 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2210
2211 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2212
2213 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2214 gdk_window_get_screen, gdk_window_get_geometry,
2215 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2216 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2217 (xg_get_pixbuf_from_pixmap): New function.
2218 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2219 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2220 Call xg_get_pixbuf_from_pixmap instead of
2221 gdk_pixbuf_get_from_drawable.
2222 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2223 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2224 (xg_check_special_colors): Use GtkStyleContext and its functions
2225 for HAVE_GTK3.
2226 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2227 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2228 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2229 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2230 Call gtk_widget_get_preferred_size.
0afb4571
J
2231 (xg_frame_resized): gdk_window_get_geometry only takes 5
2232 parameters.
44f230aa
SM
2233 (xg_win_to_widget, xg_event_is_for_menubar):
2234 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2235 (xg_set_widget_bg): New function.
2236 (delete_cb): New function.
2237 (xg_create_frame_widgets): connect delete-event to delete_cb.
2238 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2239 (xg_set_background_color): Call xg_set_widget_bg.
2240 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2241 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2242 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2243 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2244 if ! HAVE_GTK3.
2245 (update_frame_tool_bar): Call gtk_widget_hide.
2246 (xg_initialize): Use GDK_KEY_g.
2247
2248 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2249 if ! HAVE_GTK3
2250 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2251
2252 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2253 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2254 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2255
1c2cc4ef
JB
22562011-03-08 Juanma Barranquero <lekktu@gmail.com>
2257
2258 * w32xfns.c (select_palette): Check success of RealizePalette against
2259 GDI_ERROR, not zero.
2260
33383987 2261See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2262
2263;; Local Variables:
2264;; coding: utf-8
aac0c6e3
MR
2265;; End:
2266
33383987 2267 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2268
2269 This file is part of GNU Emacs.
2270
2271 GNU Emacs is free software: you can redistribute it and/or modify
2272 it under the terms of the GNU General Public License as published by
2273 the Free Software Foundation, either version 3 of the License, or
2274 (at your option) any later version.
2275
2276 GNU Emacs is distributed in the hope that it will be useful,
2277 but WITHOUT ANY WARRANTY; without even the implied warranty of
2278 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2279 GNU General Public License for more details.
2280
2281 You should have received a copy of the GNU General Public License
2282 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.