Spelling fixes (mostly "inactive" vs "deactivate").
[bpt/emacs.git] / src / ChangeLog
CommitLineData
83aca1cb
PE
12011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2
3 * fileio.c (Finsert_file_contents): Undo previous change; see
4 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5
5b76caa4
PE
62011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7
8 Rename locals to avoid shadowing.
9 * fileio.c (Finsert_file_contents):
10 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
11 * process.c (wait_reading_process_output):
12 Rename inner 'proc' to 'p' to avoid shadowing.
13 Indent for consistency with usual Emacs style.
14
8c535114
EZ
152011-11-25 Eli Zaretskii <eliz@gnu.org>
16
17 * xdisp.c (redisplay_window): If cursor row is not fully visible
18 after recentering, and scroll-conservatively is set to a large
19 number, scroll window by a few more lines to make the cursor fully
20 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
21 (start_display): Don't move to the next line if the display should
22 start at a newline that is part of a display vector or an overlay
23 string. (Bug#10119)
8c535114 24
fa4fdb5c
JL
252011-11-24 Juri Linkov <juri@jurta.org>
26
27 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
28 after the `MagickPingImage' call. (Bug#10112)
29
90ec88df
CY
302011-11-23 Chong Yidong <cyd@gnu.org>
31
32 * window.c (Fcoordinates_in_window_p): Accept only live windows.
33
56e2e794
MR
342011-11-23 Martin Rudalics <rudalics@gmx.at>
35
36 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
37 making another buffer current. (Bug#10114)
38
b6e64c41
GM
392011-11-23 Glenn Morris <rgm@gnu.org>
40
41 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
42
6b21de18
CY
432011-11-23 Chong Yidong <cyd@gnu.org>
44
45 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
46 using it (Bug#5984).
47
b12cd789
EZ
482011-11-22 Eli Zaretskii <eliz@gnu.org>
49
50 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
51 and header-lines, as they don't have one computed for them.
52 (Bug#10098)
53
54 * .gdbinit (prow): Make displayed values more self-explaining.
55 Add row's hash code.
56
261b6fd4
LMI
572011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
58
59 * process.c (wait_reading_process_output): Fix asynchrounous
60 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 61 (wait_reading_process_output): Add comment and URL.
261b6fd4 62
e7cfd277
JD
632011-11-21 Jan Djärv <jan.h.d@swipnet.se>
64
65 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
66
a9b9b7f5
CY
672011-11-21 Chong Yidong <cyd@gnu.org>
68
69 * window.c (Fnext_window, Fprevious_window): Doc fix.
70
b0d15b4f
SM
712011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
72
73 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
74
fe7a3057
JB
752011-11-20 Juanma Barranquero <lekktu@gmail.com>
76
77 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
78
d2999b1a
MR
792011-11-20 Martin Rudalics <rudalics@gmx.at>
80
81 * window.c (Fset_window_combination_limit): Rename argument
82 STATUS to LIMIT.
83 (Vwindow_combination_limit): Remove "status" from doc-string.
84
d5ff9cd0
AS
852011-11-20 Andreas Schwab <schwab@linux-m68k.org>
86
87 * m/ibms390.h: Remove.
88 * m/ibms390x.h: Don't include "ibms390.h".
89
a5bb9bd3
SM
902011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
91
92 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
93 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
94
cd1181db
JB
952011-11-20 Juanma Barranquero <lekktu@gmail.com>
96
97 * casetab.c (Fset_case_table):
98 * charset.c (Fcharset_after): Fix typos.
99
615a3b8d 1002011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 101
17e845af
PE
102 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
103 Otherwise, valgrind does not work on some platforms.
104 Problem reported by Andreas Schwab in
6a0bf43d
PE
105 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
106 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
107 is set, removing the need for VIRT_ADDRESS_VARIES.
108 (PURE_P): Use a more-efficient implementation that needs just one
109 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
110 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
111 to 4 (xorl, subq, cmpq, setbe).
112 * alloc.c (pure): Always extern now, since that's the
113 VIRT_ADDR_VARIES behavior.
114 (PURE_POINTER_P): Use a single comparison, not two, for
115 consistency with the new puresize.h.
116 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
117 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
118 Remove VIRT_ADDR_VARIES no longer needed.
119
f8fe6f96
EZ
1202011-11-19 Eli Zaretskii <eliz@gnu.org>
121
122 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
123 (erase_phys_cursor, update_window_cursor, show_mouse_face)
124 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
125 behave as if the cursor position were at the window margin.
126
127 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
128 and the cursor position is out of bounds, behave as if the cursor
129 position were at the window margin. (Bug#10075)
130
df05a53c
CY
1312011-11-18 Chong Yidong <cyd@gnu.org>
132
133 * window.c (Fwindow_combination_limit): Make first argument
134 non-optional, since it is meaningless for live windows like the
135 selected window.
136
2071918e
DA
1372011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
138
139 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
140
b50a28de
SM
1412011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
142
143 * intervals.c: Fix grafting over the whole buffer (bug#10071).
144 (graft_intervals_into_buffer): Simplify.
145
015137db
EZ
1462011-11-18 Eli Zaretskii <eliz@gnu.org>
147
148 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
149 hash values of the two rows.
150 (copy_row_except_pointers): Preserve the used[] arrays and the
151 hash values of the two rows. (Bug#10035)
68c95424 152 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
153
154 * xdisp.c (row_hash): New function, body extracted from
155 compute_line_metrics.
156 (compute_line_metrics): Call row_hash, instead of computing the
157 hash code inline.
158
159 * dispnew.c (verify_row_hash): Call row_hash for computing the
160 hash code of a row, instead of duplicating code from xdisp.c.
161
162 * dispextern.h (row_hash): Add prototype.
163
a2addb04
TH
1642011-11-18 Tassilo Horn <tassilo@member.fsf.org>
165
166 * frame.c (delete_frame): Don't delete the terminal when the last
167 X frame is closed if emacs is built with GTK toolkit.
168
df85d315
JB
1692011-11-17 Juanma Barranquero <lekktu@gmail.com>
170
171 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
172
a0c2d0ae
MR
1732011-11-17 Martin Rudalics <rudalics@gmx.at>
174
175 * window.c (Vwindow_splits): Rename to
176 Vwindow_combination_resize. Suggested by Juri Linkov.
177 (Fsplit_window_internal): Use Vwindow_combination_resize instead
178 of Vwindow_splits.
179
58179cce
JB
1802011-11-16 Juanma Barranquero <lekktu@gmail.com>
181
7877f373
JB
182 * nsfns.m (Fns_font_name):
183 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 184
b6f67890
MR
1852011-11-16 Martin Rudalics <rudalics@gmx.at>
186
187 * window.h (window): Rename slot "nest" to "combination_limit".
188 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
189 (Fset_window_nest): Rename to Fset_window_combination_limit.
190 (Vwindow_nest): Rename to Vwindow_combination_limit.
191 (recombine_windows, make_parent_window, make_window)
192 (Fsplit_window_internal, saved_window)
193 (Fset_window_configuration, save_window_save): Rename all
194 occurrences of window_nest to window_combination_limit.
195
c7015153
JB
1962011-11-15 Juanma Barranquero <lekktu@gmail.com>
197
198 * image.c (imagemagick_load_image): Fix typo.
199
322ad6ec
EZ
2002011-11-14 Eli Zaretskii <eliz@gnu.org>
201
202 * xdisp.c (display_line): Move the call to
203 highlight_trailing_whitespace before the call to
204 compute_line_metrics, since the latter needs to see the final
205 faces of all the glyphs to compute ROW's hash value. Fixes
206 assertion violations in row_equal_p. (Bug#10035)
207
f067b8ec
JB
2082011-11-14 Juanma Barranquero <lekktu@gmail.com>
209
210 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
211 just return (bug#10044).
212
1e5b2111
EZ
2132011-11-12 Eli Zaretskii <eliz@gnu.org>
214
7ef3cbd5
EZ
215 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
216 with user-defined heap size. Bump the default size of the temacs
217 heap to 27MB, to avoid memory warning when running temacs.
218 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
219
1e5b2111
EZ
220 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
221 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
222 (verify_row_hash) [XASSERTS]: New function.
223 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
224 that the hash value of glyph rows is correct.
1e5b2111 225
89d61221
MR
2262011-11-12 Martin Rudalics <rudalics@gmx.at>
227
228 * window.h (window): Remove splits slot.
229 * window.c (Fwindow_splits, Fset_window_splits): Remove.
230 (Fdelete_other_windows_internal, make_parent_window)
231 (make_window, Fsplit_window_internal, Fdelete_window_internal)
232 (Fset_window_configuration, save_window_save): Don't deal with
233 split status of windows.
234 (saved_window): Remove splits slot.
235 (Vwindow_splits): Rewrite doc-string.
236
97f18cc8
JD
2372011-11-11 Jan Djärv <jan.h.d@swipnet.se>
238
239 * xfns.c (unwind_create_frame):
240 * nsfns.m (unwind_create_frame):
241 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
242 Vframe_list (Bug#9999).
243
22a648b4
DA
2442011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
245
0b381c7e 246 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 247
659afede
KH
2482011-11-11 Kenichi Handa <handa@m17n.org>
249
250 * callproc.c (Fcall_process): Set the member dst_multibyte of
251 process_coding.
252
9ac0394b
KH
2532011-11-11 Johan Bockgård <bojohan@gnu.org>
254
255 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
256 avoid a crash (bug#9496).
257
2fbdc249
CY
2582011-11-09 Chong Yidong <cyd@gnu.org>
259
260 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
261 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
262
ac6b1f81
PE
2632011-11-08 Paul Eggert <eggert@cs.ucla.edu>
264
265 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
266
09db192c
PE
2672011-11-08 Paul Eggert <eggert@cs.ucla.edu>
268
269 Avoid some portability problems by eschewing 'extern inline' functions.
270 The trivial performance wins aren't worth the portability hassles; see
271 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
272 et seq.
273 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
274 (window_box_width, window_box_left, window_box_left_offset)
275 (window_box_right, window_box_right_offset): Undo previous change,
276 by removing the "extern"s.
277 * intervals.c (adjust_intervals_for_insertion)
278 (adjust_intervals_for_deletion): Undo previous change,
279 making these static again.
280 (offset_intervals, temp_set_point_both, temp_set_point)
281 (copy_intervals_to_string): No longer inline.
282 * xdisp.c (window_text_bottom_y, window_box_width)
283 (window_box_height, window_box_left_offset)
284 (window_box_right_offset, window_box_left, window_box_right)
285 (window_box): No longer inline.
286
105216ed
CY
2872011-11-08 Chong Yidong <cyd@gnu.org>
288
289 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
290 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
291 an error if not a live window.
292 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
293 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
294
ae9e237f
JB
2952011-11-07 Juanma Barranquero <lekktu@gmail.com>
296
297 * lisp.h (syms_of_abbrev): Remove declaration.
298 Reported by CHENG Gao <chenggao@royau.me>.
299
c7aa8333
EZ
3002011-11-07 Eli Zaretskii <eliz@gnu.org>
301
302 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
303 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
304 of temacs in GUI mode.
305
be7f5545
MR
3062011-11-07 Martin Rudalics <rudalics@gmx.at>
307
308 * window.h: Declare delete_all_child_windows instead of
309 delete_all_subwindows.
310 * window.c (Fwindow_nest, Fset_window_nest)
311 (Fset_window_new_total, Fset_window_new_normal)
312 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
313 (delete_all_subwindows): Rename to delete_all_child_windows.
314 (Fdelete_other_windows_internal, Fset_window_configuration):
315 Call delete_all_child_windows instead of delete_all_subwindows.
316 * frame.c (delete_frame): Call delete_all_child_windows instead
317 of delete_all_subwindows.
318
ca78dc43
PE
3192011-11-07 Paul Eggert <eggert@cs.ucla.edu>
320
321 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
322 This is also needed for porting to any host where GC_MARK_STACK is
323 not GC_MAKE_GCPROS_NOOPS.
324 (which_symbols): Use it.
325
a0241d01
KH
3262011-11-07 Kenichi Handa <handa@m17n.org>
327
328 * coding.c (coding_set_destination): Check coding->src_pos only
329 when coding->src_object is a buffer (bug#9910).
330
331 * process.c (send_process): Set the member src_multibyte of coding
332 to 0 (bug#9911) when sending a unibyte text.
333
334 * callproc.c (Fcall_process): Set the member src_multibyte of
335 process_coding to 0 (bug#9912).
336
a64bfdfa 3372011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
338
339 * xmenu.c (cleanup_widget_value_tree): New function.
340 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
341 calling free_menubar_widget_value_tree directly (Bug#9830).
342
cb41b32a
PE
3432011-11-06 Paul Eggert <eggert@cs.ucla.edu>
344
345 Fix some portability problems with 'inline'.
346 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
347 (window_box_width, window_box_left, window_box_left_offset)
348 (window_box_right, window_box_right_offset): Declare extern.
349 Otherwise, these inline functions do not conform to C99 and
350 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
351 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
352 * intervals.c (adjust_intervals_for_insertion)
353 (adjust_intervals_for_deletion): Now extern, because otherwise the
354 extern inline functions 'offset_intervals' couldn't refer to it.
355 (static_offset_intervals): Remove.
356 (offset_intervals): Rewrite using the old contents of
357 static_offset_intervals. The old version didn't conform to C99
358 because an extern inline function contained a reference to an
359 identifier with static linkage.
360
b7041366
AS
3612011-11-06 Andreas Schwab <schwab@linux-m68k.org>
362
363 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
364 GC.
365
88a37c4d
EZ
3662011-11-06 Eli Zaretskii <eliz@gnu.org>
367
368 * xdisp.c (init_iterator, reseat_to_string): Don't set the
369 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
370 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
371 return Qleft_to_right.
372
49745b39
CY
3732011-11-06 Chong Yidong <cyd@gnu.org>
374
375 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
376 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
377 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
378 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
379 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
380 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
381 (Fwindow_vscroll): Doc fix.
382 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
383 argument, since it makes no sense to pass a live window and for
384 consistency with window-child.
385
1f05cd82
CS
3862011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
387
388 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
389 support MSVC.
390
22610910
JR
3912011-11-05 Jason Rumney <jasonr@gnu.org>
392
393 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
394 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
395 fonts (Bug#6029).
396 (add_font_entity_to_list): Fix logic errors in mixed boolean and
397 bitwise arithmetic preventing use of unicode-sip and non-truetype
398 opentype fonts.
399
a06776b2
EZ
4002011-11-05 Eli Zaretskii <eliz@gnu.org>
401
3ad924ba
EZ
402 * s/ms-w32.h (fstat, stat, utime): Move redirections to
403 "emacs"-only part.
404
a06776b2
EZ
405 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
406 initialization code to keep similarity to xfns.c after changes
407 from 2011-11-05.
408
c9e7db78
JD
4092011-11-05 Jan Djärv <jan.h.d@swipnet.se>
410
a97f8f3f
JD
411 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
412 (unwind_create_frame): New function (Bug#9943).
413 (Fx_create_frame): Restructure code to be more similar to the one in
414 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
415 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
416 Move terminal->reference_count++ just before making the frame official
417 (Bug#9943).
418
419 * nsterm.m (x_free_frame_resources): New function.
420 (x_destroy_window): Move code to x_free_frame_resources.
421
c9e7db78
JD
422 * xfns.c (unwind_create_frame): Fix comment.
423 (Fx_create_frame, x_create_tip_frame): Move
424 terminal->reference_count++ just before making the frame
425 official. Move initialization of image_cache_refcount and
426 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
427
a6fc3b5c
EZ
4282011-11-05 Eli Zaretskii <eliz@gnu.org>
429
430 Support MSVC build with newer versions of Visual Studio.
431 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
432 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
433 nt/gmake.defs.
434
435 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
436 which are not supported by MSVC.
437 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
438 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
439 bitfields.
440 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
441 types in bitfields.
442 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
443
444 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
445
58179cce 4462011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
447
448 Support MSVC build with newer versions of Visual Studio.
449 * w32.c: Don't include w32api.h for MSVC.
450 (init_environment) [_MSC_VER]: Call sys_access, not _access.
451
452 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
453 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
454 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
455 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
456 e_* cousins.
457 (alloca) [_MSC_VER]: Define to _alloca.
458
459 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
460
461 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
462
a58c13ed
EZ
4632011-11-04 Eli Zaretskii <eliz@gnu.org>
464
465 * xdisp.c (note_mouse_highlight): If either of
466 previous/next-single-property-change returns nil, treat that as
467 the beginning or the end of the buffer. (Bug#9955)
468
fe0b6370
JD
4692011-11-04 Jan Djärv <jan.h.d@swipnet.se>
470
a58c13ed 471 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
472 label is not null (Bug#9951).
473 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
474 may be NULL.
475
89bd5ee1
EZ
4762011-11-04 Eli Zaretskii <eliz@gnu.org>
477
478 * window.c (Fwindow_body_size): Mention in the doc string that the
479 return value is in frame's canonical units. (Bug#9949)
480
84c3edb9
EZ
4812011-11-03 Eli Zaretskii <eliz@gnu.org>
482
4e2fb5c7
EZ
483 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
484
84c3edb9 485 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 486 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 487 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 488
bc17a887
EZ
4892011-11-01 Eli Zaretskii <eliz@gnu.org>
490
491 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
492 Don't stop backward scan on the continuation glyph, even though
493 its CHARPOS is positive.
26b46e51
EZ
494 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
495 cover_string to disp_string.
bc17a887 496
4ee88440
MR
4972011-11-01 Martin Rudalics <rudalics@gmx.at>
498
499 * window.c (temp_output_buffer_show): Don't use
500 Vtemp_buffer_show_specifiers.
501 (Vtemp_buffer_show_specifiers): Remove unused variable.
502
c2ff3c02
EZ
5032011-10-30 Eli Zaretskii <eliz@gnu.org>
504
505 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
506 past the beginning of the current glyph matrix.
507
58179cce 5082011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
509
510 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
511 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
512 HAVE_GTK3 (Bug#9869).
b77a6a7f 513
3b574623
JD
514 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
515 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
516
b77a6a7f
JD
517 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
518
519 * xterm.c: Declare x_handle_net_wm_state to return int.
520 (handle_one_xevent): Check if we are iconified but don't have
521 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
522 (get_current_wm_state): Return non-zero if not hidden,
523 check for _NET_WM_STATE_HIDDEN (Bug#9893).
524 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
525 (x_handle_net_wm_state): Return what get_current_wm_state returns.
526 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
527
196e41e4
PE
5282011-10-29 Paul Eggert <eggert@cs.ucla.edu>
529
530 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
531 so that this new function doesn't get optimized away by a
532 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
533
021f2e1a
AS
5342011-10-29 Andreas Schwab <schwab@linux-m68k.org>
535
536 * frame.h (MOUSE_HL_INFO): Remove excess parens.
537
8b058d44
EZ
5382011-10-29 Eli Zaretskii <eliz@gnu.org>
539
540 Fix the `xbytecode' command.
541 * .gdbinit (xprintbytestr): New command.
b50a28de 542 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
543 (xbytecode): Print the byte-code string as well.
544
4452fb80
EZ
5452011-10-29 Kim Storm <storm@cua.dk>
546
8b058d44
EZ
547 * alloc.c (which_symbols): New function.
548
21b72067
AS
5492011-10-29 Andreas Schwab <schwab@linux-m68k.org>
550
551 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
552 line. (Bug#9903)
553
83ed7b5c
GM
5542011-10-29 Glenn Morris <rgm@gnu.org>
555
556 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
557 Not clear what it was for, and it causes various bugs. (Bug#9839)
558
5a7a728b
EZ
5592011-10-28 Eli Zaretskii <eliz@gnu.org>
560
561 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
562 possible random value that matches one of those tested as
563 condition to clear the mouse face.
564
d3d0842f
CY
5652011-10-28 Chong Yidong <cyd@gnu.org>
566
567 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
568
31b39d13
DN
5692011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
570
571 * window.c (make_window): Initialize phys_cursor_on_p.
572
9aba6043
SM
5732011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
574
575 * lisp.h (struct Lisp_Symbol): Update comments.
576
c20992f4
JB
5772011-10-28 Juanma Barranquero <lekktu@gmail.com>
578
579 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
580
db4f02f2
EZ
5812011-10-28 Eli Zaretskii <eliz@gnu.org>
582
583 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
584 <oslsachem@gmail.com> for helping to debug this.
585
586 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
587 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
588 (g_b_init_get_glyph_outline_w): New static variables.
589 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
590 (GetGlyphOutlineW_Proc): New typedefs.
591 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
592 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
593 New functions.
594 (w32font_open_internal, compute_metrics):
595 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
596 instead of calling the "wide" APIs directly.
597
598 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
599
600 * w32.h (syms_of_w32font): Add prototype.
601
87e68db4
JB
6022011-10-27 Juanma Barranquero <lekktu@gmail.com>
603
604 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
605 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
606 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
607 (Fmove_to_window_line): Doc fix.
608
435c1d67
CY
6092011-10-27 Chong Yidong <cyd@gnu.org>
610
611 * process.c (make_process): Set gnutls_state to NULL.
612
613 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
614 non-NULL, regardless of GNUTLS_INITSTAGE.
615 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
616 an error. Set process slots as soon as we allocate them.
617
618 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
619
9c6c6f49
CY
6202011-10-27 Chong Yidong <cyd@gnu.org>
621
9aba6043
SM
622 * gnutls.c (emacs_gnutls_deinit): New function.
623 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
624 (Fgnutls_deinit, Fgnutls_boot): Use it.
625
626 * process.c (make_process): Initialize GnuTLS credentials to NULL.
627 (deactivate_process): Call emacs_gnutls_deinit.
628
657d08d3
JB
6292011-10-27 Juanma Barranquero <lekktu@gmail.com>
630
631 * image.c (x_create_x_image_and_pixmap):
632 * w32.c (sys_rename, w32_delayed_load):
633 * w32font.c (fill_in_logfont):
634 * w32reg.c (x_get_string_resource): Silence compiler warnings.
635
5430d399
JB
6362011-10-26 Juanma Barranquero <lekktu@gmail.com>
637
638 * w32fns.c (w32_default_color_map): New function,
639 extracted from Fw32_default_color_map.
a7ef684b 640 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 641
fe0055fa
PE
6422011-10-25 Paul Eggert <eggert@cs.ucla.edu>
643
644 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
645
e6346438
SM
6462011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
647
648 * keyboard.c (test_undefined): New function (bug#9751).
649 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
650
e112cc37
ET
6512011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
652
653 * sysdep.c (init_sys_modes): Fix the check for the controlling
654 terminal (Bug#6649).
655
7b5d6677
EZ
6562011-10-20 Eli Zaretskii <eliz@gnu.org>
657
658 * dispextern.h (struct bidi_it): New member next_en_type.
659
660 * bidi.c (bidi_line_init): Initialize the next_en_type member.
661 (bidi_resolve_explicit_1): When next_en_pos is valid for the
662 current character, check also for next_en_type being WEAK_EN.
663 (bidi_resolve_weak): Don't enter the expensive loop if the current
664 position is before next_en_pos. Record the bidi type of the first
665 non-ET, non-BN character we find, in addition to its position.
666 (bidi_level_of_next_char): Invalidate next_en_type when
667 next_en_pos is over-stepped.
668
7da0b018
PE
6692011-10-20 Paul Eggert <eggert@cs.ucla.edu>
670
671 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
672 * editfns.c: Rewrite current-time-zone so that it invokes
673 the equivalent of (format-time-string "%Z") to get the time zone name.
674 This fixes a bug when the time zone name contains characters that
675 need converting from the system time locale to Emacs internal format.
676 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
677 that patch fixed format-time-string to do the conversion, but
678 I forgot to fix current-time-zone.
679 (format_time_string): New function, containing most of
680 what Fformat_time_string used to contain.
681 (Fformat_time_string): Rewrite in terms of format_time_string.
682 This doesn't change this function's behavior.
683 (current-time-zone): Rewrite to use format_time_string.
684 This fixes the bug reported by Michael Schierl in
685 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
686 Jason Rumney's 2007-06-07 change worked around this bug, but
687 didn't fix it.
688 * systime.h (tzname, timezone): Remove no-longer-used declarations.
689
8547b010
EZ
6902011-10-19 Eli Zaretskii <eliz@gnu.org>
691
692 * xdisp.c (start_display): If the character at POS is displayed
693 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
694 (try_window_reusing_current_matrix): If a line ends in a display
695 vector or the next line starts in a display vector, continue
696 redrawing the window even though the character position of
697 start_row was reached.
8547b010
EZ
698 (Bug#9771, part 2)
699
4e948d15
CY
7002011-10-18 Chong Yidong <cyd@gnu.org>
701
702 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
703 with nobreak-char-display too.
704
4787455f
EZ
7052011-10-18 Eli Zaretskii <eliz@gnu.org>
706
707 Fix part 3 of bug#9771.
708 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
709 (bidi_resolve_neutral): Don't enter the expensive loop looking for
710 non-neutral characters if the current character is a paragraph
711 separator (a.k.a. Newline). This avoids running the same
712 expensive loop twice, once when we consume the preceding newline
713 and the other time when the line actually needs to be displayed.
714 Avoid the loop when we see neutrals on the base embedding level
715 following a character whose directionality is the same as the
716 paragraph's. This avoids running the expensive loop when a line
717 ends in a long sequence of neutrals, like control characters.
718 Add assertion against STRONG_AL type. Slightly rearrange code
719 that determines the type of a neutral given the first non-neutral
720 that follows it.
721 (bidi_level_of_next_char): Set next_en_pos to zero when
722 invalidating its info.
723
2c91f553
EZ
7242011-10-17 Eli Zaretskii <eliz@gnu.org>
725
726 * xdisp.c (push_display_prop): Determine whether to record string
727 or buffer position by IT->string, not by IT->method. Allow
728 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
729 (move_it_vertically_backward): Don't look for character position
730 immediately after the newline when in a continuation line.
731 (Bug#9771, part 1)
2c91f553 732
c7b08b0d
MR
7332011-10-15 Martin Rudalics <rudalics@gmx.at>
734
735 * window.c (coordinates_in_window): Rewrite and delabelize
736 vertical border check. (Bug#5357) (Bug#9618)
737
6b02f655
SM
7382011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
739
740 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
741 errors in XSetWindowBorder (bug#9310).
742
81d40c92
DA
7432011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
744
745 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
746 avoid crash when xmalloc overrun checking is enabled.
747
d4172c3b
EZ
7482011-10-13 Eli Zaretskii <eliz@gnu.org>
749
750 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
751 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
752 cursor motion with <left> and <right> arrow keys.
753
754 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
755 some callers set that themselves.
756
b00eea75
EZ
7572011-10-12 Eli Zaretskii <eliz@gnu.org>
758
759 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
760 display string and the previous row comes from the same string and
761 is empty. (Bug#9739) (Bug#9738)
762
8fe012c4
SM
7632011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
764
765 * doc.c (get_doc_string): Encode file name (bug#9735).
766
0074aef2
EZ
7672011-10-12 Eli Zaretskii <eliz@gnu.org>
768
79beb178
EZ
769 * bidi.c (bidi_level_of_next_char):
770 * xdisp.c (get_visually_first_element): Remove old incorrect
771 comments regarding the Unicode Line Separator character.
772
0074aef2
EZ
773 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
774
6e4b3fbe
DA
7752011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
776
777 * alloc.c (Fgc_status): Do not access beyond zombies array
778 boundary if nzombies > MAX_ZOMBIES.
779 * alloc.c (dump_zombies): Add missing format specifier.
780
0324f3af
PE
7812011-10-12 Paul Eggert <eggert@cs.ucla.edu>
782
b5525cac
PE
783 * xdisp.c (set_cursor_from_row): Simplify conditionals,
784 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
785
0324f3af
PE
786 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
787 Some packages use them to denote characters with modifiers.
788
e9b5f888
AS
7892011-10-11 Andreas Schwab <schwab@linux-m68k.org>
790
791 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
792 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
793 matching a pp-number. Rename parameter var to var1.
794
127827c0
SM
7952011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
796
797 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
798
c8fd3bd0
GM
7992011-10-08 Glenn Morris <rgm@gnu.org>
800
801 * callint.c (Fcall_interactively): Give a more explicit error for the
802 'c' case with a non-character input. (Bug#8479)
803
352ec8ff
EZ
8042011-10-08 Eli Zaretskii <eliz@gnu.org>
805
03669ccb
EZ
806 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
807 lines.
7061c986
EZ
808 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
809 lines that are hscrolled on the left.
03669ccb 810
352ec8ff
EZ
811 * dispnew.c (buffer_posn_from_coords): Account for a possible
812 presence of header-line. (Bug#4426)
813
a66cfb1c
SM
8142011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
815
6b02f655
SM
816 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
817 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 818
7c5ee88e
PE
8192011-10-07 Paul Eggert <eggert@cs.ucla.edu>
820
821 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
822 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
823 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
824 this makes Emacs dump core during garbage collection on rare
825 occasions. sizeof is obviously inferior to offsetof here, so
826 stick with offsetof.
827 (GC_POINTER_ALIGNMENT): New macro.
828 (mark_memory): Omit 3rd (offset) arg; caller changed.
829 Don't assume EMACS_INT alignment is the same as pointer alignment.
830
df1bbe5b
SM
8312011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
832
833 * keyboard.c (read_key_sequence_remapped): New var.
834 (read_key_sequence): Compute remapping in the right buffer.
835 (command_loop_1): Use read_key_sequence's remapping directly.
836
51553db6
SM
8372011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
838
32c1fffd
SM
839 * dired.c (file_name_completion): Don't expand file name.
840 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
841 before checking file name handler.
842
51553db6
SM
843 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
844 they've been requested explicitly (bug#9591).
845
b6bd1599 8462011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
847
848 * keymap.c (Fsingle_key_description): Use make_specified_string
849 instead of build_string to build string from push_key_description.
850 (Bug#5193)
851
f701dc2a
PE
8522011-09-30 Paul Eggert <eggert@cs.ucla.edu>
853
4222c55d
PE
854 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
855 This fixes a Y2038 bug on 64-bit hosts.
856 * buffer.c (reset_buffer):
857 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
858 (Fclear_buffer_auto_save_failure):
859 Use 0, not -1, to represent an unset failure time, since time_t
860 might not be signed.
861
f701dc2a
PE
862 Remove dependency on glibc malloc internals.
863 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
864 Move back here from lisp.h, but with their new implementations.
865 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
866 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
867 * charset.c (charset_table_init): New static var.
868 (syms_of_charset): Use it instead of xmalloc. This removes a
869 dependency on glibc malloc internals. See Eli Zaretskii's comment in
870 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
871 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
872 Move back to alloc.c.
873 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
874 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
875
9ceebf39
JD
8762011-09-30 Jan Djärv <jan.h.d@swipnet.se>
877
878 * nsterm.m (windowDidResize): Call x_set_window_size only when
879 ns_in_resize is true. Otherwise set pixelwidth/height and
880 call change_frame_size (Bug#9628).
881
cb993c58
PE
8822011-09-30 Paul Eggert <eggert@cs.ucla.edu>
883
3930c88b
PE
884 Port --enable-checking=all to Fedora 14 x86-64.
885 * charset.c (syms_of_charset): Also account for glibc malloc's
886 internal overhead when calculating the initial malloc maximum.
887
cb993c58
PE
888 Port --enable-checking=all to Fedora 14 x86.
889 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
890 Move to lisp.h.
891 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
892 (overrun_check_realloc, overrun_check_free):
893 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
894 That way, xmalloc returns a properly-aligned pointer even if
895 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
896 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
897 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
898 into account when calculating the initial malloc maximum.
899 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
900 Move here from alloc.c, so that charset.c can use it too.
901 Properly align; the old code wasn't right for common 32-bit hosts
902 when configured with --enable-checking=all.
903 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
904 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
905
31bed486
EZ
9062011-09-29 Eli Zaretskii <eliz@gnu.org>
907
04c70788 908 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
909 use EDOM.
910
fbcaa2f3
EZ
9112011-09-28 Eli Zaretskii <eliz@gnu.org>
912
913 * xdisp.c (compute_display_string_end): If there's no display
914 string at CHARPOS, return -1.
915
916 * bidi.c (bidi_fetch_char): When compute_display_string_end
917 returns a negative value, treat the character as a normal
918 character not covered by a display string. (Bug#9624)
919
a239d4e9
JB
9202011-09-28 Juanma Barranquero <lekktu@gmail.com>
921
922 * lread.c (Fread_from_string): Fix typo in docstring.
923
88652fd5
EZ
9242011-09-27 Eli Zaretskii <eliz@gnu.org>
925
926 * xdisp.c (handle_invisible_prop): If invisible text ends on a
927 newline, reseat the iterator instead of bidi-iterating there one
928 character at a time. (Bug#9610)
32c1fffd
SM
929 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
930 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 931
ed497dd4
AS
9322011-09-27 Andreas Schwab <schwab@linux-m68k.org>
933
934 * lread.c (readevalloop): Use correct code for NBSP.
935 (read1): Likewise. (Bug#9608)
936
b2bf61aa
MA
9372011-09-25 Michael Albinus <michael.albinus@gmx.de>
938
939 * dbusbind.c (Fdbus_register_signal): When service is not
940 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
941
32bbb17c
GM
9422011-09-25 Glenn Morris <rgm@gnu.org>
943
944 * buffer.c (truncate-lines): Doc fix.
945
94e0933e
CY
9462011-09-24 Chong Yidong <cyd@stupidchicken.com>
947
948 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
949 (Fset_window_next_buffers): Doc fix.
950
cddde921
GM
9512011-09-24 Glenn Morris <rgm@gnu.org>
952
953 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
954
1260aef1
PE
9552011-09-24 Paul Eggert <eggert@cs.ucla.edu>
956
25b4bfa0
PE
957 Fix minor problems found by static checking.
958 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
959 * indent.c (Fvertical_motion): Fix == vs = typo.
960
e3cbd34b
EZ
9612011-09-24 Eli Zaretskii <eliz@gnu.org>
962
a66cfb1c
SM
963 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
964 Default value is now t. Doc fix.
6bf7006f 965
e3cbd34b 966 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 967 logic when moving up, not only when moving down. Fix the
e3cbd34b 968 confusing name and values of the it_overshoot_expected variable;
32c1fffd 969 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
970
971 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
972 CHARPOS is covered by a display string which includes newlines.
973 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
974 is covered by a display string with embedded newlines.
975
a3de0cbd
MA
9762011-09-24 Michael Albinus <michael.albinus@gmx.de>
977
978 * dbusbind.c (Fdbus_register_signal): Add match rule to
979 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
980 (Fdbus_register_method, Vdbus_registered_objects_table):
981 Fix docstring.
a3de0cbd 982
b260039d
JM
9832011-09-24 Jim Meyering <meyering@redhat.com>
984
32c1fffd 985 do not ignore write error for any output size
b260039d
JM
986 The previous change was incomplete.
987 While it makes emacs --batch detect the vast majority of stdout
988 write failures, errors were still ignored whenever the output size is
989 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
990 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
991 && echo FAIL: ignored write error
992 FAIL: ignored write error
993 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
994 && echo FAIL: ignored write error
995 FAIL: ignored write error
996 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
997
8eca8a7c
AS
9982011-09-23 Andreas Schwab <schwab@linux-m68k.org>
999
1000 * emacs.c (Fkill_emacs): In noninteractive mode exit
1001 non-successfully if a write error occurred on stdout. (Bug#9574)
1002
3341db62
EZ
10032011-09-21 Eli Zaretskii <eliz@gnu.org>
1004
1005 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1006 the xassert test.
1007
1008 * dispextern.h (struct it): Update the comment documenting what
1009 can it->OBJECT be.
1010
8c203dbf
EZ
10112011-09-20 Eli Zaretskii <eliz@gnu.org>
1012
1013 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1014 a display string, extend search for cursor position to end of row.
1015 (find_row_edges): If the row ends in a newline from a display
1016 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1017 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1018 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1019 non-empty line. Fixes confusing cursor motion with arrow keys at
1020 the beginning of a line that starts with whitespace.
8c203dbf 1021
a4824228
LMI
10222011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1023
1024 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1025 (bug#9493).
1026
33ed493b
CY
10272011-09-18 Chong Yidong <cyd@stupidchicken.com>
1028
1029 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1030 boolean (Bug#9154).
1031
56cd55c8
EZ
10322011-09-18 Eli Zaretskii <eliz@gnu.org>
1033
1034 * xdisp.c (display_line): Record maximum and minimum buffer
1035 positions even if no glyphs were produced (e.g., by a zero-width
1036 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1037 buffer positions that will be removed from the glyph row because
1038 they don't fit.
c02dcedf
EZ
1039 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1040 column is beyond frame width: don't subtract 1 "pixel" when
1041 computing width of the stretch.
3e62b7e0
EZ
1042 (reseat_at_next_visible_line_start): Undo the change made on
1043 2011-09-17 that saved paragraph information and restored it after
1044 the call to `reseat'. (Bug#9545)
56cd55c8 1045
5ed99d36 10462011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1047
1048 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1049 and turn window cursor on if cleared (Bug#9415).
1050
5ed99d36 10512011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1052
1053 * search.c (boyer_moore): Take unibyte characters from pattern
1054 literally. (Bug#9458)
1055
9bade7b2
EZ
10562011-09-18 Eli Zaretskii <eliz@gnu.org>
1057
1058 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1059
e5e9d610
PE
10602011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1061
87e4427a
PE
1062 Fix minor problem found by static checking.
1063 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1064 initialized, to pacify gcc -Wuninitialized.
1065
e5e9d610
PE
1066 * fileio.c: Report proper errno when syscall falls.
1067 (Finsert_file_contents): Save and restore errno,
1068 so that report_file_error outputs the correct diagnostic.
1069 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1070
a1674f0b
EZ
10712011-09-18 Eli Zaretskii <eliz@gnu.org>
1072
1073 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1074
fbfb6dd4
EZ
10752011-09-17 Eli Zaretskii <eliz@gnu.org>
1076
1077 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1078 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1079
bb187662
EZ
10802011-09-17 Eli Zaretskii <eliz@gnu.org>
1081
1137e8b8 1082 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1083 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1084
1085 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1086 (bidi_find_paragraph_start): Search back for paragraph beginning
1087 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1088 (bidi_move_to_visually_next): Only trigger paragraph-related
1089 computations when the last character is a newline or at EOB, not
1090 just any NEUTRAL_B. (Bug#9470)
1091
bb187662
EZ
1092 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1093 truncated lines if point is covered by a display string. (Bug#9524)
1094
2e621251
PE
10952011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1096
1097 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1098 (cons_to_x_long): New function.
1099 (lisp_data_to_selection_data): Use it. Correct the test for
1100 short-versus-long data; it was negated. Break out of vector
1101 loop, for efficiency, when a long datum is discovered.
1102
91a15bc6
SM
11032011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1104
1105 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1106
b41c3a35
EZ
11072011-09-16 Eli Zaretskii <eliz@gnu.org>
1108
1109 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1110 GCC PR/17406) by declaring this function with external scope.
1111
7812ba2d
PE
11122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1113
1114 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1115 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1116
cf7edc2a
AS
11172011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1118
1119 * editfns.c (Fformat): Correctly handle text properties on "%%".
1120
bd01620e
EZ
11212011-09-15 Eli Zaretskii <eliz@gnu.org>
1122
1123 * xterm.c (x_draw_composite_glyph_string_foreground):
1124 * w32term.c (x_draw_composite_glyph_string_foreground):
1125 * term.c (encode_terminal_code):
1126 * composite.c (composition_update_it, get_composition_id):
1127 * xdisp.c (get_next_display_element)
1128 (fill_composite_glyph_string): Add comments about special meaning
1129 of TAB characters in a composition.
1130
a02719a3
PE
11312011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1132
1133 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1134 This occurs when processing a multibyte format.
1135 Problem reported by Wolfgang Jenker.
a02719a3 1136
72589a3c
JB
11372011-09-15 Johan Bockgård <bojohan@gnu.org>
1138
1139 * xdisp.c (try_cursor_movement): Only check for exact match if
1140 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1141
1c14176c
PE
11422011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1143
1144 Remove unused external symbols.
1145 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1146 * xdisp.c (calc_pixel_width_or_height): Now static.
1147 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1148 * indent.c (check_display_width):
1149 * w32term.c: Fix comment to match code.
1150 * xterm.c, xterm.h (x_catching_errors): Remove.
1151
d2eea5b5
PE
11522011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1153
1154 * xselect.c: Use signed conversions more consistently (Bug#9498).
1155 (selection_data_to_lisp_data): Assume incoming selection data are
1156 signed integers, not unsigned. This is to be consistent with
1157 outgoing selection data, which was modified to use signed integers
1158 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1159 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1160 expects long, not unsigned long.
1161
46888499
EZ
11622011-09-14 Eli Zaretskii <eliz@gnu.org>
1163
1164 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1165 computation of loop end. Reported by Johan Bockgård
1166 <bojohan@gnu.org>.
1167
ef8ef9fb
CY
11682011-09-13 Chong Yidong <cyd@stupidchicken.com>
1169
1170 * frame.c (Fother_visible_frames_p): Function deleted.
1171
fa819fed
EZ
11722011-09-12 Eli Zaretskii <eliz@gnu.org>
1173
1174 * indent.c (compute_motion): Process display vector front to back
1175 rather than the other way around. (Bug#2496)
1176
2ba8e008
SM
11772011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1178
1179 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1180
20f53c69
CY
11812011-09-11 Chong Yidong <cyd@stupidchicken.com>
1182
1183 * minibuf.c (Fread_from_minibuffer): Doc fix.
1184
d562d7a4
EZ
11852011-09-11 Eli Zaretskii <eliz@gnu.org>
1186
1187 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1188 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1189
1c4d7f3d
LMI
11902011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1191
1192 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1193 value for non-existent files.
1194
b885bf36
EZ
11952011-09-11 Eli Zaretskii <eliz@gnu.org>
1196
1197 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1198 set its "size" to -1. This will set the modtime_size field of
1199 the corresponding buffer to -1, which is what
1200 verify-visited-file-modtime expects for files that do not exist.
1201 (Bug#9139)
1202
6612f0bf
PE
12032011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1204
1205 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1206 here ...
1207 * lisp.h: ... from here. push_key_description is no longer
1208 defined in keyboard.c, so its declaration should not be in
1209 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1210 logically belongs with push_key_description.
1211
dfb3f755
PE
12122011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1213
1214 * buffer.h: Include <sys/types.h> instead of <time.h>.
1215 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1216 Problem reported by Herbert J. Skuhra.
1217
3134906c
LMI
12182011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1219
1220 * xml.c (parse_region): Make the parsing work for
1221 non-comment-starting XML files again (bug#9144).
1222
8d903f4e
AS
12232011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1224
1225 * image.c (gif_load): Fix calculation of bottom and right corner.
1226 (Bug#9468)
1227
80ad64f4
EZ
12282011-09-10 Eli Zaretskii <eliz@gnu.org>
1229
1230 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1231 redisplay in small windows.
1232
208a048d
EZ
12332011-09-09 Eli Zaretskii <eliz@gnu.org>
1234
1235 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1236
9b1c252e
MR
12372011-09-08 Martin Rudalics <rudalics@gmx.at>
1238
1239 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1240 Operate on live windows only.
1241
2949f33b
JB
12422011-09-08 Juanma Barranquero <lekktu@gmail.com>
1243
1244 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1245
e08dcafd
EZ
12462011-09-07 Eli Zaretskii <eliz@gnu.org>
1247
1248 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1249 only under bidi iteration.
1250
115b96bd
JD
12512011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1252
1253 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1254
c8199d0f
PE
12552011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1256
1257 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1258 Without this fix, the command to link temacs failed due to an
1259 undefined symbol __builtin_isnan. This is because
1260 /usr/include/iso/math_c99.h #defines isnan(x) to
1261 __builtin_isnan(x), but the bundled gcc, which identifies itself
1262 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1263 a __builtin_isnan.
1264 * floatfns.c (isnan): #undef, and then #define to a clone of
1265 what's in data.c.
1266 (Fisnan): Always define, since it's always available now.
1267 (syms_of_floatfns): Always define isnan at the Lisp level.
1268
e39b275c 12692011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1270
1271 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1272
b2db44d9 12732011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1274
f4af5137 1275 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1276 The previous code assumed that file offsets (off_t values) fit in
1277 EMACS_INT variables, which is not true on typical 32-bit hosts.
1278 The code messed up by falsely reporting buffer overflow in cases
1279 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1280 when "big" contains more than 2**29 bytes, even though this
1281 inserts just one byte and does not overflow the buffer.
1282 (Finsert_file_contents): Store file offsets as off_t
1283 values, not as EMACS_INT values. Check for overflow when
1284 converting between EMACS_INT and off_t. When checking for
1285 buffer overflow or for overlap, take the offsets into account.
1286 Don't use EMACS_INT for small values where int suffices.
1287 When checking for overlap, fix a typo: ZV was used where
1288 ZV_BYTE was intended.
1289 (Fwrite_region): Don't assume off_t fits into 'long'.
1290 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1291
ecfc0a49
MA
12922011-09-05 Michael Albinus <michael.albinus@gmx.de>
1293
1294 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1295
6511acf2 12962011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1297
0999621a 1298 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1299
1300 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1301 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1302 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1303 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1304 (modify_event_symbol): Do not assume that the length of
1305 name_alist_or_stem is safe to alloca and fits in int.
1306 (Fexecute_extended_command): Likewise for function name and binding.
1307 (Frecursion_depth): Wrap around reliably on integer overflow.
1308 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1309 since some callers pass EMACS_INT values.
1310 (Fsingle_key_description): Don't crash if symbol name contains more
1311 than MAX_ALLOCA bytes.
1312 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1313 (get_minibuffer): Arg is now EMACS_INT, not int.
1314 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1315 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1316 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1317
2be7d702
PE
1318 * dbusbind.c (signature_cat): New function.
1319 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1320 Do not overrun buffer; instead, report string overflow.
1321
9d1df220
PE
1322 * dispnew.c (add_window_display_history): Don't overrun buffer.
1323 Truncate instead; this is OK since it's just a log.
1324
33ef5c64
PE
1325 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1326 even if the time zone offset is outlandishly large.
1327 Don't mishandle offset == INT_MIN.
1328
66c6fdd5
PE
1329 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1330 when creating daemon; the previous buffer-overflow check was incorrect.
1331
d749b01b
PE
1332 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1333 which has the guts of the old verror function.
1334
b5cd1905
PE
1335 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1336 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1337
6e1a67fb
PE
1338 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1339 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1340 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1341 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1342 length of string rather than counting it via multiple sprintfs;
1343 that's simpler and more reliable.
c21721cc
PE
1344 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1345 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1346 sprintf, in case result does not fit in int.
1347
c57b67fc
PE
1348 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1349 (fontset_from_font): Print it.
1350
8a401434
PE
1351 * frame.c (tty_frame_count): Now printmax_t, not int.
1352 (make_terminal_frame, set_term_frame_name): Print it.
1353 (x_report_frame_params): In X, window IDs are unsigned long,
1354 not signed long, so print them as unsigned.
1355 (validate_x_resource_name): Check for implausibly long names,
1356 and don't assume name length fits in 'int'.
1357 (x_get_resource_string): Don't blindly alloca invocation name;
1358 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1359 not fit in int.
1360
6e1a67fb
PE
1361 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1362 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1363 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1364
0df02bf3
PE
1365 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1366 Use esprintf, not sprintf, in case result does not fit in int.
1367
48e30793
PE
1368 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1369 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1370 it as a large positive number.
1371 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1372 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1373
a66ff6d8
PE
1374 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1375 in case result does not fit in int.
1376
aca216ff
PE
1377 * print.c (float_to_string): Detect width overflow more reliably.
1378 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1379 buffer overrun. Don't assume list length fits in 'int'. Treat
1380 print length of 0 as 0, not as infinity; to be consistent with other
1381 uses of print length in this function. Don't overflow print length
1382 index. Don't assume hash table size fits in 'long', or that
1383 vectorlike size fits in 'unsigned long'.
1384
31c286f7
PE
1385 * process.c (make_process): Use printmax_t, not int, to format
1386 process-name gensyms.
1387
55e5faa1
PE
1388 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1389
80f2e268
PE
1390 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1391 to avoid potential buffer overrun.
1392
670741ab
PE
1393 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1394 if X resource line is longer than 512 bytes.
1395
b7163a50
PE
1396 * xfns.c (x_window): Make sprintf buffer a bit bigger
1397 to avoid potential buffer overrun.
1398
ae58ff1f
PE
1399 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1400
c43c8a6a
PE
1401 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1402
3f8236f4
PE
14032011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1404
53e9fe90 1405 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1406 Without these, Emacs silently mishandles large integers sometimes.
1407 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1408 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1409
6511acf2
PE
1410 * xdisp.c (try_window_id): Check Emacs fixnum range before
1411 converting to 'int'.
806add1d 1412
6511acf2 1413 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1414 Check that an Emacs fixnum is in range before assigning it to 'int'.
1415 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1416 values converted from Emacs fixnums.
1417 (Frecenter): Don't wrap around a line count if it is out of 'int'
1418 range; instead, treat it as an extreme value.
1419 (Fset_window_configuration, compare_window_configurations):
1420 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1421
6511acf2
PE
1422 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1423 that can exceed INT_MAX. Check that EMACS_INT value is in range
1424 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1425 (match_limit): Don't assume that a fixnum can fit in 'int'.
1426
6511acf2 1427 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1428 exceed INT_MAX.
1429
6511acf2 1430 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1431 (Fvertical_motion): Don't wrap around LINES values that don't fit
1432 in 'int'. Instead, treat them as extreme values. This is good
1433 enough for windows, which can't have more than INT_MAX lines anyway.
1434
fcb901a7
LMI
14352011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1436
0f2f6b6d
LMI
1437 * Require libxml/parser.h to avoid compilation warning.
1438
fcb901a7
LMI
1439 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1440
1441 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1442 since this reportedly can destroy thread storage.
1443
6e20a0d4
CY
14442011-08-30 Chong Yidong <cyd@stupidchicken.com>
1445
1446 * syntax.c (find_defun_start): Update all cache variables if
1447 exiting early (Bug#9401).
1448
148ae00e
EZ
14492011-08-30 Eli Zaretskii <eliz@gnu.org>
1450
f6cfbd8f
EZ
1451 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1452
148ae00e
EZ
1453 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1454 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1455 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1456
1457 * term.c (tty_append_glyph): New function.
1458 (produce_stretch_glyph): Static function and its prototype deleted.
1459
a66cfb1c
SM
1460 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1461 Add prototypes.
148ae00e 1462
c4a07a4c
PE
14632011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1464
1465 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1466 when checking :margin (Bug#9390).
1467 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1468 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1469 so that the name doesn't mislead. All uses changed.
1470
6bc8cd65
JB
14712011-08-28 Johan Bockgård <bojohan@gnu.org>
1472
1473 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1474 set_tty_hooks.
1475
dca4927e
EZ
14762011-08-27 Eli Zaretskii <eliz@gnu.org>
1477
1478 * xdisp.c (move_it_to): Don't bail out early when reaching
1479 position beyond to_charpos, if we are scanning backwards.
1480 (move_it_vertically_backward): When DY == 0, make sure we get to
1481 the first character in the line after the newline.
1482
f2cad773
PE
14832011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1484
1485 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1486 (ccl_driver): Do not generate an out-of-range pointer.
1487 (Fccl_execute_on_string): Remove unnecessary check for
1488 integer overflow, noted by Stefan Monnier in
1489 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1490 Remove a FIXME that didn't need fixing.
1491 Simplify the newly-introduced buffer reallocation code.
1492
0cae2cdb
JB
14932011-08-27 Juanma Barranquero <lekktu@gmail.com>
1494
1495 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1496
5fc295a4 14972011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1498
70c60eb2 1499 Integer and memory overflow issues (Bug#9196).
726e0ab1 1500
d31850da
PE
1501 * doc.c (get_doc_string): Rework so that
1502 get_doc_string_buffer_size is the actual buffer size, rather than
1503 being 1 less than the actual buffer size; this makes xpalloc more
1504 convenient.
1505
a69fbedb
PE
1506 * image.c (x_allocate_bitmap_record, cache_image):
1507 * xselect.c (Fx_register_dnd_atom):
1508 Simplify previous changes by using xpalloc.
1509
fe5c5d37
PE
1510 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1511 since either will do and ptrdiff_t is convenient with xpalloc.
1512
0065d054
PE
1513 * charset.c (charset_table_size)
1514 (struct charset_sort_data.priority): Now ptrdiff_t.
1515 (charset_compare): Don't overflow if priorities differ greatly.
1516 (Fsort_charsets): Don't assume list length fits in int.
1517 Check for size-calculation overflow when allocating sort data.
1518 (syms_of_charset): Allocate an initial charset table that is
1519 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1520
1521 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1522
1523 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1524 The actual value is always <= INT_MAX, and leaving it unsigned made
1525 overflow checking harder.
1526
1527 * dispextern.h (struct glyph_matrix.rows_allocated)
1528 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1529 with xpalloc. The values are still always <= INT_MAX.
1530
1531 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1532
1533 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1534 (SAFE_NALLOCA): New macro.
1535
1536 * region-cache.c (struct boundary.pos, find_cache_boundary)
1537 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1538 (set_cache_region, invalidate_region_cache)
1539 (revalidate_region_cache, know_region_cache, region_cache_forward)
1540 (region_cache_backward, pp_cache):
1541 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1542 so that ptrdiff_t * can be passed to xpalloc.
1543 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1544 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1545 (pp_cache): Don't assume cache_len fits in int.
1546 * region-cache.h: Adjust extern decls to match.
1547
1548 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1549 EMACS_INT, since either will do, for xpalloc.
1550
1551 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1552 (xnmalloc, xnrealloc, xpalloc): New functions.
1553
726e0ab1
PE
1554 * bidi.c (bidi_shelve_header_size): New constant.
1555 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1556 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1557
51f30bc5 1558 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1559 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1560 (overlay_strings):
1561 Don't update size of array until after memory allocation succeeds,
1562 because xmalloc/xrealloc may not return.
0065d054
PE
1563 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1564 now that we have proper integer overflow checking.
1565 (record_overlay_string, overlay_strings): Catch overflows when
1566 calculating size of overlay_str_buf.
726e0ab1 1567
0065d054
PE
1568 * callproc.c (Fcall_process): Check for size overflow when
1569 calculating size of args2.
1570 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1571 Normally we prefer signed values, but sticking with ptrdiff_t would
1572 require adding more-complicated checks.
726e0ab1
PE
1573
1574 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1575 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1576 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1577 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1578
1579 * character.c (Fstring): Check for size-calculation overflow.
1580
1581 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1582 unnecessary integer overflow. Check for size overflow.
1583 (encode_coding_object): Don't update size until xmalloc succeeds.
1584
1585 * composite.c (get_composition_id): Check for overflow in glyph
1586 length calculations.
1587
1588 Integer and memory overflow fixes for display code.
1589 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1590 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1591 (scrolling_window): Check for overflow in size calculations.
1592 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1593 Don't assume glyph table len fits in int.
1594 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1595 (row_table_size): Now ptrdiff_t, not int.
1596 (scrolling_window): Avoid overflow in size calculations.
1597 Don't update size until allocation succeeds.
1598 * fns.c (concat): Check for overflow in size calculations.
1599 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1600 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1601 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1602
1603 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1604 (get_doc_string): Check for size calculation overflow.
1605 Don't update size until allocation succeeds.
1606 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1607 EMACS_INT, where ptrdiff_t will do.
1608 (Fsubstitute_command_keys): Check for string overflow.
1609
1610 * editfns.c (set_time_zone_rule): Don't assume environment length
1611 fits in int.
1612 (message_length): Now ptrdiff_t, not int.
1613 (Fmessage_box): Don't update size until allocation succeeds.
1614 Don't assume message length fits in int.
1615 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1616
0065d054
PE
1617 * emacs.c (main): Do not reallocate argv, since there is a null at
1618 the end that can be overwritten, and this way there's no need to
1619 worry about size-calculation overflow.
1620 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1621
1622 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1623 alloc succeeds.
1624 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1625
1626 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1627 (x_set_scroll_bar_width, x_figure_window_size):
1628 Check for integer overflow.
1629 (x_set_alpha): Do not assume XINT fits in int.
1630
1631 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1632 This is for the members text_lines, text_cols, total_lines, total_cols,
1633 where the system imposes an 'int' limit.
1634
1635 * fringe.c (Fdefine_fringe_bitmap):
1636 Don't update size until alloc works.
1637
1638 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1639 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1640
1641 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1642 Check for size-calculation overflow.
1643 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1644 do, as we prefer signed integers.
1645 (id_to_widget.max_size, id_to_widget.used)
1646 (xg_store_widget_in_map, xg_remove_widget_from_map)
1647 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1648 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1649 Use and return ptrdiff_t, not int.
1650 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1651 * gtkutil.h: Change prototypes to match the above.
1652
1653 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1654 are duplicate now that they've been promoted to lisp.h.
1655 (x_allocate_bitmap_record, x_alloc_image_color)
1656 (make_image_cache, cache_image, xpm_load):
1657 Don't update size until alloc is done.
1658 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1659 (x_detect_edges):
3256efce 1660 Check for size calculation overflow.
726e0ab1
PE
1661 (ct_colors_allocated_max): New constant.
1662 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1663 overflow.
3256efce 1664
726e0ab1
PE
1665 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1666 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1667 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1668 Use ptrdiff_t, not int, to count maps.
1669 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1670 calculations. Don't update size until allocation succeeds.
1671 Redo calculations to avoid overflow.
726e0ab1
PE
1672 * keyboard.h: Change prototypes to match the above.
1673
1674 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1675 to count maps.
1676 (current_minor_maps): Check for size calculation overflow.
1677 * keymap.h: Change prototypes to match the above.
1678
1679 * lread.c (read1, init_obarray): Don't update size until alloc done.
1680
1681 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1682 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1683
726e0ab1
PE
1684 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1685 Now ptrdiff_t, not int.
1686 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1687 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1688
1689 * process.c (Fnetwork_interface_list): Check for overflow
1690 in size calculation.
1691
1692 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1693
1694 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1695 overflow. Don't bother calling xmalloc when xrealloc will do.
1696
1697 * search.c (Freplace_match): Check for size calculation overflow.
1698 (Fset_match_data): Don't assume list lengths fit in 'int'.
1699
1700 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1701 for command line length. Do not attempt to address one before the
1702 beginning of an array, as that's not portable.
1703
1704 * term.c (max_frame_lines): Remove; unused.
1705 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1706 not int.
1707 (encode_terminal_code, calculate_costs): Check for size
1708 calculation overflow.
1709 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1710 table lengths and related sizes. Don't update size until alloc
1711 done. Redo calculations to avoid overflow.
1712 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1713
1714 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1715 subtracting pointers.
1716 (gobble_line): Check for overflow more carefully. Don't update size
1717 until alloc done.
1718
1719 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1720 Don't update size until alloc done.
1721 Redo size calculations to avoid overflow.
1722 Check for size calculation overflow.
0065d054 1723 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1724
1725 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1726 Use ptrdiff_t, not int, for sizes.
1727 (store_mode_line_noprop_char): Don't update size until alloc done.
1728
0065d054
PE
1729 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1730 Use ptrdiff_t, not int, for sizes.
1731 (Finternal_make_lisp_face, cache_face):
1732 Check for size calculation overflow.
1733 (cache_face): Treat size calculation overflows as if they were
1734 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1735
1736 * xfns.c (x_encode_text, x_set_name_internal)
1737 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1738 sizes, since they can exceed INT_MAX in size. Check for size
1739 calculation overflow.
1740
0065d054
PE
1741 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1742 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1743 Don't update size until alloc done.
1744
0065d054 1745 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1746 as sprintf is limited to int lengths.
1d526e2f 1747
252c5ee1
PE
1748 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1749 (X_LONG_MIN): New macros.
864d7ce7
PE
1750 Use them to make the following changes clearer.
1751 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1752 This change doesn't affect the value now, but it may help remind
1753 future maintainers not to raise the value too much later.
1754 (SELECTION_QUANTUM): Remove, replacing with ...
1755 (selection_quantum): ... new function, which avoids overflow.
1756 All uses changed.
1757 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1758 assumption that selection length fits in 'int'.
1759 (x_reply_selection_request, x_handle_selection_request)
1760 (x_get_window_property, receive_incremental_selection)
1761 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1762 (lisp_data_to_selection_data, clean_local_selection_data):
1763 Use ptrdiff_t, not int, to record length of selection.
1764 (x_reply_selection_request, x_get_window_property)
1765 (receive_incremental_selection, x_property_data_to_lisp):
1766 Redo calculations to avoid overflow.
1767 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1768 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1769 something.
1770 (x_get_window_property, receive_incremental_selection)
1771 (lisp_data_to_selection_data, x_property_data_to_lisp):
1772 Check for size-calculation overflow.
1773 (x_get_window_property, receive_incremental_selection)
1774 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1775 Don't store size until memory allocation succeeds.
1776 (x_get_window_property): Plug memory leak on memory exhaustion.
1777 Don't double-block input; malloc is safe here. Don't assume 2**34
1778 - 4 fits in unsigned long. Add an xassert to check
1779 XGetWindowProperty overflow. Be more careful about overflow
1780 calculations, and distinguish size from memory overflow better.
1781 (receive_incremental_selection): When tracing, don't assume
1782 unsigned int is less than INT_MAX.
1783 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1784 harmful) conversions of unsigned short to int.
1785 (lisp_data_to_selection_data): Don't assume that integers
1786 in the range -65535 through -1 fit in an X unsigned short.
1787 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1788 result parameters unless successful. Rely on cons_to_unsigned
1789 to report problems with elements; the old code wasn't right anyway.
1790 (x_check_property_data): Check for int overflow; we cannot use
1791 a wider type due to X limits.
1792 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1793
726e0ab1 1794 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1795
0065d054
PE
1796 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1797 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1798 (x_color_cells): Don't store size until memory allocation succeeds.
1799 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1800 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1801 (x_term_init): Don't assume length fits in int (sprintf is limited
1802 to int size).
bc18e09d 1803
ebfa62c0
PE
1804 Use ptrdiff_t for composition IDs.
1805 * character.c (lisp_string_width):
1806 * composite.c (composition_table_size, n_compositions)
1807 (get_composition_id, composition_gstring_from_id):
1808 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1809 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1810 * window.c (Frecenter):
1811 Use ptrdiff_t, not int, for composition IDs.
1812 * composite.c (get_composition_id): Check for integer overflow.
1813 * composite.h: Adjust prototypes to match the above changes.
1814
d3411f89
PE
1815 Use ptrdiff_t for hash table indexes.
1816 * category.c (hash_get_category_set):
1817 * ccl.c (ccl_driver):
1818 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1819 * coding.c (coding_system_charset_list, detect_coding_system):
1820 * coding.h (struct coding_system.id):
1821 * composite.c (get_composition_id, gstring_lookup_cache):
1822 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1823 * image.c (xpm_get_color_table_h):
1824 * lisp.h (hash_lookup, hash_put):
1825 * minibuf.c (Ftest_completion):
1826 Use ptrdiff_t for hash table indexes, not int (which is too
1827 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1828 32-bit --with-wide-int hosts).
1829
e097a6fa
PE
1830 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1831 Add a FIXME comment about memory leaks.
1832 (syms_of_charset): Don't assume xmalloc returns.
1833
5637687f
PE
1834 Don't assume that stated character widths fit in int.
1835 * character.c (Fchar_width, c_string_width, lisp_string_width):
1836 * character.h (CHAR_WIDTH):
1837 * indent.c (MULTIBYTE_BYTES_WIDTH):
1838 Use sanitize_char_width to avoid undefined and/or bad behavior
1839 with outlandish widths.
a66cfb1c 1840 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1841 now that we have two such functions. All uses changed.
1842 (sanitize_char_width): New inline function.
1843
a2271ba2
PE
1844 Don't assume that tab-width fits in int.
1845 * character.h (sanitize_width): New inline function.
1846 (SANE_TAB_WIDTH): New macro.
1847 (ASCII_CHAR_WIDTH): Use it.
1848 * indent.c (sane_tab_width): Remove. All uses replaced by
1849 SANE_TAB_WIDTH (current_buffer).
1850 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1851
18c52557
PE
1852 * fileio.c: Integer overflow issues with file modes.
1853 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1854
caeeedc1
PE
1855 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1856 Remove unreachable code.
1857 (read_hex, load_charset_map_from_file): Check for integer overflow.
1858
50849c52
PE
1859 * xterm.c: don't go over XClientMessageEvent limit
1860 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1861 (x_send_scroll_bar_event): Likewise. Check that the size does not
1862 exceed limits imposed by XClientMessageEvent, as well as the usual
1863 ptrdiff_t and size_t limits.
1864
b13995db
PE
1865 * keyboard.c: Overflow, signedness and related fixes.
1866 (make_lispy_movement): Use same integer type in forward decl
1867 that is used in the definition.
1868 (read_key_sequence, keyremap_step):
1869 Change bufsize argument back to int, undoing my 2011-03-30 change.
1870 We prefer signed types, and int is wide enough here.
1871 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1872 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1873 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1874 length, not size_t. Use ptrdiff_t for index, not int.
1875 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1876 possibility of integer overflow.
1877
13464394
PE
1878 Overflow, signedness and related fixes for images.
1879
1880 * dispextern.h (struct it.stack[0].u.image.image_id)
1881 (struct_it.image_id, struct image.id, struct image_cache.size)
1882 (struct image_cache.used, struct image_cache.ref_count):
1883 * gtkutil.c (update_frame_tool_bar):
1884 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1885 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1886 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1887 * nsmenu.m (update_frame_tool_bar):
1888 * xdisp.c (calc_pixel_width_or_height):
1889 * xfns.c (image_cache_refcount):
1890 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1891 on typical 64-bit hosts.
1892
1893 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1894 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1895 Omit unnecessary casts to int.
1896 (parse_image_spec): Check that integers fall into 'int' range
1897 when the callers expect that.
1898 (image_ascent): Redo ascent calculation to avoid int overflow.
1899 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1900 (lookup_image): Remove unnecessary tests.
1901 (xbm_image_p): Locals are now of int, not EMACS_INT,
1902 since parse_image_check makes sure they fit into int.
1903 (png_load, gif_load, svg_load_image):
1904 Prefer int to unsigned where either will do.
1905 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1906 old tiff_error_handler and tiff_warning_handler.
1907 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1908 stack buffer overflows. It uses only the features of vsnprintf
1909 that are common to both POSIX and native Microsoft.
1910 (tiff_error_handler, tiff_warning_handler): Use it.
1911 (tiff_load, gif_load, imagemagick_load_image):
1912 Don't assume :index value fits in 'int'.
1913 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1914 (imagemagick_load_image): Check that crop parameters fit into
1915 the integer types that MagickCropImage accepts. Don't assume
1916 Vimagemagick_render_type has a nonnegative value. Don't assume
1917 size_t fits in 'long'.
1918 (gs_load): Use printmax_t to print the widest integers possible.
1919 Check for integer overflow when computing image height and width.
1920
c11821d4
EZ
19212011-08-26 Eli Zaretskii <eliz@gnu.org>
1922
1923 * xdisp.c (redisplay_window): Don't force window start if point
1924 will be invisible in the resulting window. (Bug#9324)
1925
0c95fcf7
EZ
19262011-08-25 Eli Zaretskii <eliz@gnu.org>
1927
1928 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1929 the display spec is of the form `(space ...)'.
1930 (handle_display_spec): Return the value returned by
1931 handle_single_display_spec, not just 1 or zero.
1932 (handle_single_display_spec): If the display spec is of the form
1933 `(space ...)', and specifies display in the text area, return 2
1934 rather than 1.
fee65a97 1935 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1936 accurately, and prefer exact match for point under bidi.
1937 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1938
1939 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1940 into disp_prop; all users changed.
1941
1942 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1943 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1944 for the text covered by the display property.
1945
e4ed06f1
CY
19462011-08-25 Chong Yidong <cyd@stupidchicken.com>
1947
1948 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1949 Change return value to nil.
1950 (Frecord_buffer): Delete unused function.
1951
f67cdd7f
EZ
19522011-08-24 Eli Zaretskii <eliz@gnu.org>
1953
5980d4c6
EZ
1954 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1955 buffers, return left-to-right.
8610fe8b
EZ
1956 (set_cursor_from_row): Consider candidate row a win if its glyph
1957 represents a newline and point is on that newline. Fixes cursor
1958 positioning on the newline at EOL of R2L text within L2R
1959 paragraph, and vice versa.
1960 (try_cursor_movement): Check continued rows, in addition to
1961 continuation rows. Fixes unwarranted scroll when point enters a
1962 continued line of R2L text within an L2R paragraph, or vice versa.
1963 (cursor_row_p): Consider the case of point being equal to
1964 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1965 from the end of a short line to the beginning of a continued line
1966 of R2L text within L2R paragraph.
1967 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1968 composed characters.
5980d4c6 1969
f67cdd7f
EZ
1970 * bidi.c (bidi_check_type): Use xassert.
1971 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1972 members.
1973
bca633fb
EZ
19742011-08-23 Eli Zaretskii <eliz@gnu.org>
1975
1976 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1977 a character.
1978
4a5885a7
CY
19792011-08-23 Chong Yidong <cyd@stupidchicken.com>
1980
1981 * nsfont.m (ns_otf_to_script): Fix typo.
1982
0902a04e
KH
19832011-08-22 Kenichi Handa <handa@m17n.org>
1984
1985 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1986 extra slot even if the purpose is char-code-property-table.
1987
1a2e6670
EZ
19882011-08-23 Eli Zaretskii <eliz@gnu.org>
1989
8ddde651
EZ
1990 * xdisp.c (redisplay_window): When computing centering_position,
1991 account for the height of the header line. (Bug#8874)
1992
425cc014
EZ
1993 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1994 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1995 candidate is selected by the mouse, and that candidate has a
1996 composed character under the mouse.
1997
1a2e6670
EZ
1998 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1999 coordinates reported by pos-visible-in-window-p for a composed
2000 character in column zero.
2001
8b76d6f8
SM
20022011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2003
2004 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2005
dac347dd
EZ
20062011-08-22 Eli Zaretskii <eliz@gnu.org>
2007
2008 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2009 consider it a hit if to_charpos is anywhere in the range of the
2010 composed buffer positions.
2011
e013fb34
CY
20122011-08-22 Chong Yidong <cyd@stupidchicken.com>
2013
2014 * image.c (gif_load): Don't assume that each subimage has the same
2015 dimensions as the base image. Handle disposal method that is
2016 "undefined" by the gif spec (Bug#9335).
2017
bd1ba3e8
CY
20182011-08-20 Chong Yidong <cyd@stupidchicken.com>
2019
2020 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2021 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2022
54a1215b
EZ
20232011-08-19 Eli Zaretskii <eliz@gnu.org>
2024
823564e5
EZ
2025 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2026 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2027 from an Org mode buffer to a Speedbar frame.
2028
54a1215b
EZ
2029 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2030 a composition, take its buffer position from IT->cmp_it.charpos.
2031 Fixes cursor positioning at the beginning of a line that begins
2032 with a composed character.
2033
9778ebcc
EZ
20342011-08-18 Eli Zaretskii <eliz@gnu.org>
2035
0be6ee06
EZ
2036 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2037 character bidirectional type, use STRONG_L instead. Fixes crashes
2038 in a buffer produced by `describe-categories'.
2039
9778ebcc
EZ
2040 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2041 members before the level stack, so they would be saved and
2042 restored when copying iterator state. Fixes incorrect reordering
2043 around TABs covered by display properties.
2044
156bffbe
AS
20452011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2046
6b02f655 2047 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2048
72ad093b
CY
20492011-08-17 Chong Yidong <cyd@stupidchicken.com>
2050
2051 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2052 (internal_condition_case_2, internal_condition_case_n):
2053 Remove unnecessary aborts (Bug#9081).
72ad093b 2054
35774242
EZ
20552011-08-17 Eli Zaretskii <eliz@gnu.org>
2056
2057 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2058 has no `load' handler, try opening the file locally. (Bug#9311)
2059
db76dd85
KB
20602011-08-16 Ken Brown <kbrown@cornell.edu>
2061
2062 * gmalloc.c: Expand comment.
2063
b215eee5
EZ
20642011-08-16 Eli Zaretskii <eliz@gnu.org>
2065
2066 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2067 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2068
a4579d33
KB
20692011-08-16 Ken Brown <kbrown@cornell.edu>
2070
2071 Fix memory allocation problems in Cygwin build (Bug#9273).
2072
2073 * unexcw.c ( __malloc_initialized): Declare external variable.
2074 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2075
8b76d6f8
SM
2076 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2077 New variables.
a4579d33
KB
2078 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2079 dumped emacs.
2080 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2081 in the static heap.
2082 [CYGWIN] (special_realloc): New function.
2083 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2084 requests to realloc storage in the static heap.
2085
3ebec551
PE
20862011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2087
2088 * bidi.c (bidi_initialize): Remove unused local.
2089
9fd8be00
EZ
20902011-08-15 Eli Zaretskii <eliz@gnu.org>
2091
6b02f655
SM
2092 * bidimirror.h:
2093 * biditype.h: Remove file.
2094 * makefile.w32-in ($(BLD)/bidi.$(O)):
2095 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2096
2097 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2098
2099 * chartab.c: Improve commentary for the uniprop_table API.
2100
32413314
EZ
2101 * bidi.c (bidi_paragraph_init): Support zero value of
2102 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2103 (bidi_initialize): Use uniprop_table instead of including
2104 biditype.h and bidimirror.h.
32413314 2105
9fd8be00
EZ
2106 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2107 coordinates of the iterator when restoring from ppos_it.
2108 (Bug#9296)
2109
5cf2b69b
KH
21102011-08-14 Kenichi Handa <handa@m17n.org>
2111
2112 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2113 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2114
daf17d00
EZ
21152011-08-14 Eli Zaretskii <eliz@gnu.org>
2116
2117 * xdisp.c (move_it_in_display_line_to): Don't invoke
2118 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2119 ppos_it. Fixes vertical cursor motion when line beginning is
2120 covered by an image. (Bug#9296)
2121
08e3161a
JD
21222011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2123
2124 * nsterm.h (ns_run_ascript): Declare.
2125 (NSAPP_DATA2_RUNASSCRIPT): Define.
2126
2127 * nsfns.m (as_script, as_result, as_status): New static variables.
2128 (ns_run_ascript): New function.
5e617bc2 2129 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2130 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2131 the event loop. Get status from as_status (Bug#7276).
2132
2133 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2134 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2135 the event loop (Bug#7276).
2136
a3720aa2
AS
21372011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2138
2139 * gnutls.c (QCgnutls_bootprop_priority)
2140 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2141 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2142 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2143 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2144 (QCgnutls_bootprop_verify_hostname_error)
2145 (QCgnutls_bootprop_callbacks_verify): Rename from
2146 Qgnutls_bootprop_..., all uses changed.
2147
2148 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2149 uses changed.
2150
0a0d27fb
PE
21512011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2152
19d5c50c
PE
2153 * xfaces.c (Qframe_set_background_mode): Now static.
2154 * dispextern.h (Qframe_set_background_mode): Remove decl.
2155
0a0d27fb
PE
2156 * process.c (Fnetwork_interface_info): Declare local only if needed.
2157
377538cb
JD
21582011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2159
2160 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2161 (Fnetwork_interface_list): Allocate in increments of bytes instead
2162 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2163 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2164 sockaddr.
2165 (struct ifflag_def): notrailers is smart on OSX.
2166 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2167 Get hardware address with getifaddrs if available.
2168
08fff70c
EZ
21692011-08-12 Eli Zaretskii <eliz@gnu.org>
2170
2171 * xdisp.c (iterate_out_of_display_property): xassert that
2172 IT->position is set to within IT->object's boundaries. Break from
2173 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2174 when IT->position is set up wrongly due to some bug.
2175 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2176 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2177 entry. Force push_it to save on the stack the current
2178 buffer/string position, to be restored by pop_it. Fix flags in
2179 the iterator structure wrt the object coming from a display
2180 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2181 properties. (Bug#9284)
2182
7be1c708 21832011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2184
7be1c708
CY
2185 * fontset.c (fontset_get_font_group): Add proper type checks.
2186 (Bug#9172)
aac0c6e3 2187
7be1c708 21882011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2189
7be1c708
CY
2190 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2191 and LC_VERSION_MIN_MACOSX.
2192 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2193 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2194
97bb72a6
EZ
21952011-08-08 Eli Zaretskii <eliz@gnu.org>
2196
2197 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2198 no-display-properties-and-no-overlays under bidi display.
2199 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2200 properties and overlays.
97bb72a6 2201
d5617611
CY
22022011-08-08 Chong Yidong <cyd@stupidchicken.com>
2203
37e11a63
CY
2204 * editfns.c (Fset_time_zone_rule): Document relationship with the
2205 setenv function.
2206
d5617611
CY
2207 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2208 the font entity extracted from the cache (Bug#8109).
2209
58872834
CY
22102011-08-07 Chong Yidong <cyd@stupidchicken.com>
2211
2212 * composite.c (autocmp_chars): Don't reset point. That is done by
2213 restore_point_unwind (Bug#5984).
2214
75bfc667
JL
22152011-08-07 Juri Linkov <juri@jurta.org>
2216
2217 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2218 to show the arg `TIME' instead of `TIMEVAL'.
2219
d1410150
EZ
22202011-08-06 Eli Zaretskii <eliz@gnu.org>
2221
2222 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2223 display property strides EOL and includes a newline, as in
2224 longlines-mode. (Bug#9254)
75b771e4
EZ
2225 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2226 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2227
2228 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2229 is non-zero, even if the data buffer is NULL. Fixes a crash in
2230 vertical-motion with longlines-mode. (Bug#9254)
2231
35928349
EZ
22322011-08-05 Eli Zaretskii <eliz@gnu.org>
2233
ec7cc85b
EZ
2234 * bidi.c <bidi_cache_total_alloc>: Now static.
2235 (bidi_initialize): Initialize bidi_cache_total_alloc.
2236
8b76d6f8 2237 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2238 cache. (Bug#9221)
2239
2240 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2241 amount allocated this far in `bidi_cache_total_alloc'.
2242 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2243 non-zero, only free the data buffer without restoring the cache
2244 contents. All callers changed.
2245
2246 * dispextern.h (bidi_unshelve_cache): Update prototype.
2247
2248 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2249 (move_it_in_display_line, move_it_to)
2250 (move_it_vertically_backward, move_it_by_lines): Replace the call
2251 to xfree to an equivalent call to bidi_unshelve_cache.
2252 (move_it_in_display_line_to): Fix logic of returning
412b6358 2253 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2254
e2e2423b
EZ
22552011-08-05 Eli Zaretskii <eliz@gnu.org>
2256
2257 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2258 came from a string character with a `cursor' property. (Bug#9229)
2259
ae9e757a
JD
22602011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2261
2262 * Makefile.in (LIB_PTHREAD): New variable.
2263 (LIBES): Add LIB_PTHREAD (Bug#9216).
2264
2265 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2266 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2267
213bd7f2
AS
22682011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2269
6b02f655 2270 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2271
99aaf75f
JD
22722011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2273
2274 * xterm.c (x_find_topmost_parent): New function.
2275 (x_set_frame_alpha): Find topmost parent window with
2276 x_find_topmost_parent and set the property there also (bug#9181).
2277 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2278
c74e9d86
PE
22792011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2280
2281 * callproc.c (Fcall_process): Avoid vfork clobbering
2282 the local vars buffer, coding_systems, current_dir.
2283
640c8776
SM
22842011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2285
2286 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2287
f26d0e4c
PE
22882011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2289
8a10d76c
PE
2290 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2291 so that it is not optimized away.
2292
f26d0e4c
PE
2293 * xdisp.c (compute_display_string_pos): Remove unused local.
2294
55439c61
EZ
22952011-08-02 Eli Zaretskii <eliz@gnu.org>
2296
2297 Fix slow cursor motion and scrolling in large buffers with
2298 selective display, like Org Mode buffers. (Bug#9218)
2299
2300 * dispextern.h (struct bidi_it): New member disp_prop_p.
2301
2302 * xdisp.c: Remove one-slot cache of display string positions.
2303 (compute_display_string_pos): Accept an additional argument
5e617bc2 2304 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2305 for a display string or property. If found, set DISP_PROP_P
2306 non-zero.
2307
2308 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2309 DISP_PROP_P, and pass it to compute_display_string_pos.
2310 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2311 non-zero. All callers of bidi_fetch_char changed.
2312
fb33fa43
SM
23132011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2314
2315 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2316
b099e063
DM
23172010-12-03 Don March <don@ohspite.net>
2318
2319 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2320 last character M-[char] is translated to ESC [char] (bug#7541).
2321
5cc7f7af
KH
23222011-08-02 Kenichi Handa <handa@m17n.org>
2323
d0fffa3f 2324 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2325
2326 * chartab.c (uniprop_table): Make it non-static.
2327
525d5e6e
EZ
23282011-08-01 Eli Zaretskii <eliz@gnu.org>
2329
2330 * xdisp.c (forward_to_next_line_start): Accept additional argument
2331 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2332 on the newline.
2333 (reseat_at_next_visible_line_start): Use the bidi iterator state
2334 returned by forward_to_next_line_start to restore the state of
2335 it->bidi_it after backing up to previous newline. (Bug#9212)
2336
31011111
AS
23372011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2338
2339 * regex.c (re_comp): Protoize.
2340 (re_exec): Fix return type.
2341 (regexec): Fix type of `ret'. (Bug#9203)
2342
476371c4
PE
23432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2344
e5d76069
PE
2345 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2346 This is needed if max-image-size is a floating-point number.
2347
9a79b20c
AS
23482011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2349
2350 * print.c (print_object): Print empty symbol as ##.
2351
2352 * lread.c (read1): Read ## as empty symbol.
2353
d8c2fa78
AA
23542011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2355
2356 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2357 setting frame foreground color (Bug#9175).
2358 (x_set_background_color): Likewise.
2359
ffe57a7a
AA
2360 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2361 contents (Bug#9176).
2362 (EmacsTooltip -init): Remove bezels and add shadows to
2363 tooltip windows.
2364
bf3492a5
AA
2365 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2366 or scroll bar (Bug#8470).
2367
d55e9c53
AA
2368 * nsfont.m (nsfont_open): Remove assignment to voffset and
2369 unnecessary vars hshink, expand, hd, full_height, min_height.
2370 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2371
2372 * nsterm.h (nsfont_info): Remove voffset field.
2373
d8c2fa78 23742011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2375
2376 Implement strike-through and overline on NextStep (Bug#8863).
2377
2378 * nsfont.m (nsfont_open): Use underline position provided by font,
2379 instead of hard-coded value of 2.
2380 (nsfont_draw): Call ns_draw_text_decoration instead.
2381
2382 * nsterm.h: Add declaration for ns_draw_text_decoration.
2383
2384 * nsterm.m (ns_draw_text_decoration): New function for drawing
2385 underline, overline, and strike-through.
2386 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2387 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2388 accommodate underlining, etc.
4843aac3 2389
4cc60b9b
EZ
23902011-07-28 Eli Zaretskii <eliz@gnu.org>
2391
bc7ece87
EZ
2392 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2393 default.
4cc60b9b 2394
476371c4
PE
23952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2396
66606eea
PE
2397 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2398 Without this fix, if a signal arrives just after memory fills up,
2399 'malloc' might be invoked reentrantly.
2400
476371c4
PE
2401 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2402 In other words, assume that every image size is allowed, on non-X
2403 hosts. This assumption is probably wrong, but it lets Emacs compile.
2404
f3fcc40d
AS
24052011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2406
2407 * regex.c (re_iswctype): Convert return values to boolean.
2408
350c992f
EZ
24092011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2410
2411 * xdisp.c (compute_display_string_pos): Don't use cached display
2412 string position if the buffer had its restriction changed.
2413 (Bug#9184)
2414
5266b4bb
PE
24152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2418
2573a837 24192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2420
41f55ccd 2421 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2422
39e378da
PE
2423 * bidi.c: Integer size and overflow fixes.
2424 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2425 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2426 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2427 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2428 (bidi_find_other_level_edge):
2429 Use ptrdiff_t instead of EMACS_INT where either will do.
2430 This works better on 32-bit hosts configured --with-wide-int.
2431 (bidi_cache_ensure_space): Check for size-calculation overflow.
2432 Use % rather than repeated addition, for better worst-case speed.
2433 Don't set bidi_cache_size until after xrealloc returns, because it
2434 might not return.
2435 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2436 (bidi_cache_ensure_space): Also check that the bidi cache size
2437 does not exceed that of the largest Lisp string or buffer. See Eli
2438 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2439
5e927815
PE
2440 * alloc.c (__malloc_size_t): Remove.
2441 All uses replaced by size_t. See Andreas Schwab's note
2442 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2443
ca4aa935
PE
2444 * image.c: Improve checking for integer overflow.
2445 (check_image_size): Assume that f is nonnull, since
2446 it is always nonnull in practice. This is one less thing to
2447 worry about when checking for integer overflow later.
2448 (x_check_image_size): New function, which checks for integer
2449 overflow issues inside X.
2450 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2451 This removes the need for a memory_full check.
2452 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2453 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2454 (xbm_read_bitmap_data): Change locals back to 'int', since
2455 their values must fit in 'int'.
2456 (xpm_load_image, png_load, tiff_load):
2457 Invoke x_create_x_image_and_pixmap earlier,
2458 to avoid much needless work if the image is too large.
2459 (tiff_load): Treat overly large images as if
2460 x_create_x_image_and_pixmap failed, not as malloc failures.
2461 (gs_load): Use x_check_image_size.
2462
5f8f9cc2
PE
2463 * gtkutil.c: Omit integer casts.
2464 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2465 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2466
5adf60bc
PE
2467 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2468
c8907a93
PE
2469 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2470 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2471 would wrongly return t on a 64-bit host.
2472
e3c25c68
PE
2473 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2474 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2475 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2476 and therefore cause GCC to emit a bogus diagnostic in some cases.
2477
3f791afe
PE
2478 * image.c: Integer signedness and overflow and related fixes.
2479 This is not an exhaustive set of fixes, but it's time to
2480 record what I've got.
2481 (lookup_pixel_color, check_image_size): Remove redundant decls.
2482 (check_image_size): Don't assume that arbitrary EMACS_INT values
2483 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2484 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2485 (tiff_load, imagemagick_load_image):
2486 Check for overflow in size calculations.
2487 (x_create_x_image_and_pixmap): Remove unnecessary test for
2488 xmalloc returning NULL; that can't happen.
2489 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2490 (xpm_color_bucket): Use better integer hashing function.
2491 (xpm_cache_color): Don't possibly over-allocate memory.
2492 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2493 (gif_memory_source):
2494 Use ptrdiff_t, not int or size_t, to record sizes.
2495 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2496 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2497 either works, as we prefer signed integers.
2498 (tiff_read_from_memory, tiff_write_from_memory):
2499 Return tsize_t, not size_t, since that's what the TIFF API wants.
2500 (tiff_read_from_memory): Don't fail simply because the read would
2501 go past EOF; instead, return a short read.
2502 (tiff_load): Omit no-longer-needed casts.
2503 (Fimagemagick_types): Don't assume size fits into 'int'.
2504
3cc5a532
PE
2505 Improve hashing quality when configured --with-wide-int.
2506 * fns.c (hash_string): New function, taken from sxhash_string.
2507 Do not discard information about ASCII character case; this
2508 discarding is no longer needed.
2509 (sxhash-string): Use it. Change sig to match it. Caller changed.
2510 * lisp.h: Declare it.
2511 * lread.c (hash_string): Remove, since we now use fns.c's version.
2512 The fns.c version returns a wider integer if --with-wide-int is
2513 specified, so this should help the quality of the hashing a bit.
2514
b312a492
PE
2515 * emacs.c: Integer overflow minor fix.
2516 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2517 Define only if GNU_LINUX.
2518 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2519
dfd153ae
PE
2520 * dispnew.c: Integer signedness and overflow fixes.
2521 Remove unnecessary forward decls, that were a maintenance hassle.
2522 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2523 All uses changed.
2524 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2525 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2526 (prepare_desired_row, line_draw_cost):
2527 Use int, not unsigned, where either works.
2528 (save_current_matrix, restore_current_matrix):
2529 Use ptrdiff_t, not size_t, where either works.
2530 (init_display): Check for overflow more accurately, and without
2531 relying on undefined behavior.
2532
a81d11a3
PE
2533 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2534 Remove, replacing with the new symbols in lisp.h. All uses changed.
2535 * fileio.c (make_temp_name):
2536 * filelock.c (lock_file_1, lock_file):
2537 * xdisp.c (message_dolog):
2538 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2539 Use pMd etc. instead.
2540 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2541 replacing the pWIDE etc. symbols removed from editfns.c.
2542
3300e6fd
PE
2543 * keyboard.h (num_input_events): Now uintmax_t.
2544 This is (very slightly) less likely to mess up due to wraparound.
2545 All uses changed.
2546
fd05c7e9
PE
2547 * buffer.c: Integer signedness fixes.
2548 (alloc_buffer_text, enlarge_buffer_text):
2549 Use ptrdiff_t rather than size_t when either will do, as we prefer
2550 signed integers.
2551
903fe15d
PE
2552 * alloc.c: Integer signedness and overflow fixes.
2553 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2554 (__malloc_size_t): Default to size_t, not to int.
2555 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2556 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2557 Prefer ptrdiff_t to size_t when either would do, as we prefer
2558 signed integers.
2559 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2560 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2561 Now const. Initialize with values that are in range even if char
2562 is signed.
2563 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2564 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2565 These functions do the right thing with sizes > 2**32.
2566 (check_depth): Now ptrdiff_t, not int.
2567 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2568 Adjust to new way of storing sizes. Check for size overflow bugs
2569 in rest of code.
2570 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2571 slightly wrong anyway, as it missed one instance of
2572 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2573 (refill_memory_reserve): Omit needless cast to size_t.
2574 (mark_object_loop_halt): Mark as externally visible.
2575
ac82cc6a
PE
2576 * xselect.c: Integer signedness and overflow fixes.
2577 (Fx_register_dnd_atom, x_handle_dnd_message):
2578 Use ptrdiff_t, not size_t, since we prefer signed.
2579 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2580 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2581 x_dnd_atoms_size and x_dnd_atoms_length.
2582
c2d1e36d
PE
2583 * doprnt.c: Prefer signed to unsigned when either works.
2584 * eval.c (verror):
2585 * doprnt.c (doprnt):
2586 * lisp.h (doprnt):
2587 * xdisp.c (vmessage):
2588 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2589 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2590 prefer signed arithmetic to avoid comparison confusion.
2591 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2592 but is a bit tricky.
2593
0e926e56
PE
2594 Assume freestanding C89 headers, string.h, stdlib.h.
2595 * data.c, doprnt.c, floatfns.c, print.c:
2596 Include float.h unconditionally.
2597 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2598 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2599 * regex.c: Likewise for stddef.h, string.h.
2600 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2601 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2602 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2603 (STDC_HEADERS): Remove obsolete defines.
2604 * sysdep.c: Include limits.h unconditionally.
2605
9cfdb3ec
PE
2606 Assume support for memcmp, memcpy, memmove, memset.
2607 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2608 * regex.c (memcmp, memcpy):
2609 Remove; we assume C89 now.
2610
2611 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2612 (__malloc_safe_bcopy): Remove; no longer needed.
2613
cf950e6b 2614 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2615 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2616 well either way, and we prefer signed to unsigned.
2617
dbf38e02
LMI
26182011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2619
2620 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2621 closes the connection while we're reading (bug#9182).
2622
d6f0886c 26232011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2624
d6f0886c
JD
2625 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2626 are specified (Bug#9168).
24e0f6b1 2627
2eb1f9e6
PE
26282011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2629
2630 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2631 Found by GCC static checking and --with-wide-int on a 32-bit host.
2632
22381272 26332011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2634
2635 * xdisp.c (compute_display_string_pos): Fix logic of caching
2636 previous display string position. Initialize cached_prev_pos to
2637 -1. Fixes slow-down at the beginning of a buffer.
2638
f25e39b4
EZ
26392011-07-24 Eli Zaretskii <eliz@gnu.org>
2640
2641 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2642 for attrs[LFACE_FONTSET_INDEX].
2643
04c4b52e
PE
26442011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2645
2646 * xml.c (parse_region): Remove unused local
2647 that was recently introduced.
2648
c1734fbd
EZ
26492011-07-23 Eli Zaretskii <eliz@gnu.org>
2650
be18c5a5
EZ
2651 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2652 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2653
c1734fbd
EZ
2654 * xdisp.c (move_it_in_display_line_to): Record the best matching
2655 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2656 exit if none of the characters scanned was an exact match.
2657 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2658 when exact match is impossible due to invisible text, and the
2659 lines are truncated.
2660
a258d627
JD
26612011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2662
2663 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2664 for OSX >= 10.7.
2665
b6d5a689
EZ
26662011-07-22 Eli Zaretskii <eliz@gnu.org>
2667
0f74f785
EZ
2668 Fix a significant slow-down of cursor motion with C-n, C-p,
2669 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2670 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2671 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2672 (next_element_from_buffer): Call compute_stop_pos_backwards to
2673 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2674 base_level_stop.
2675 (reseat): Don't look for prev_stop, as that could mean a very long
2676 run.
2677 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2678 <cached_disp_overlay_modiff>: Cache for last found display string
2679 position.
551918c1 2680 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2681 about the same buffer in the same area of character positions, and
2682 the buffer wasn't changed since the time the display string
2683 position was cached.
551918c1 2684
b2d0c91a
EZ
26852011-07-22 Eli Zaretskii <eliz@gnu.org>
2686
2687 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2688 is an integer, which is important for empty lines. (Bug#9149)
2689
043604ee
CY
26902011-07-22 Chong Yidong <cyd@stupidchicken.com>
2691
2692 * frame.c (Fmodify_frame_parameters): In tty case, update the
2693 default face if necessary (Bug#4238).
2694
da4adb04
CY
26952011-07-21 Chong Yidong <cyd@stupidchicken.com>
2696
2697 * editfns.c (Fstring_to_char): No need to explain what a character
2698 is in the docstring (Bug#6576).
2699
9abd0532
LMI
27002011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2701
2702 * xml.c (parse_region): Make sure we always return a tree.
2703
36881d16
HK
27042011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2705
2706 * xml.c (parse_region): If a document contains only comments,
2707 return that, too.
2708
1e98674d
LMI
27092011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2710
2711 * xml.c (make_dom): Return comments, too.
2712
590bd467
PE
27132011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2714
2715 Port to OpenBSD.
2716 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2717 and the surrounding thread.
2718 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2719 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2720 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2721 timer goes off.
2722 * s/openbsd.h (BROKEN_SIGIO): Define.
2723 * unexelf.c (unexec) [__OpenBSD__]:
2724 Don't update the .mdebug section of the Alpha COFF symbol table.
2725
f41628b2
LMI
27262011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2727
2728 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2729 (bug#8460).
2730
b59b67c5
PE
27312011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2732
15e3a074
PE
2733 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2734 This fixes some race conditions on the permissions of any newly
2735 created file.
2736
41bed37d
PE
2737 * alloc.c (valid_pointer_p): Use pipe, not open.
2738 This fixes some permissions issues when debugging.
2739
b59b67c5
PE
2740 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2741 If fchown fails to set both uid and gid, try to set just gid,
2742 as that is sometimes allowed. Adjust the file's mode to eliminate
2743 setuid or setgid bits that are inappropriate if fchown fails.
2744
925a6be7
SM
27452011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2746
2747 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2748 to compare Lisp_Objects.
2749 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2750 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2751 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2752
52968808
AS
27532011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2754
0a6a104b
AS
2755 * lread.c (read_integer): Unread even EOF character.
2756 (read1): Likewise. Properly record start position of symbol.
2757
52968808
AS
2758 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2759 symbol character follows.
2760
9e381cdd
PE
27612011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2762
2763 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2764 This works around a problem with the previous change to Fcopy_file.
2765 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2766 and without this change, GCC might complain about discarding
2767 fchown's return value.
2768
b5641435
JB
27692011-07-16 Juanma Barranquero <lekktu@gmail.com>
2770
2771 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2772
a8031457
PE
27732011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2774
2775 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2776
dd889327
LMI
27772011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2778
750c33f7
LMI
2779 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2780 it's used from the C level.
2781
dd889327
LMI
2782 * process.c: Use the same condition for POLL_FOR_INPUT in both
2783 keyboard.c and process.c (bug#1858).
2784
87e86684
LM
27852011-07-09 Lawrence Mitchell <wence@gmx.li>
2786
2787 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2788 (Fgnutls_boot): Use it.
2789
64348f40
AS
27902011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2791
2792 * doc.c (Fsubstitute_command_keys): Revert last change.
2793
1d698799
LMI
27942011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2795
f863868c
LMI
2796 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2797 quotes the next character, and doesn't affect other longer
2798 sequences (bug#8935).
2799
1d698799
LMI
2800 * lread.c (syms_of_lread): Clarify that is isn't only
2801 `eval-buffer' and `eval-defun' that's affected by
2802 `lexical-binding' (bug#8460).
2803
aa4b6df6
EZ
28042011-07-15 Eli Zaretskii <eliz@gnu.org>
2805
2806 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2807 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2808
5d856da6
PE
28092011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2810
ad6042bb
PE
2811 Fix minor problems found by static checking.
2812 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2813 (elsz): Now a signed constant, not a size_t var. We prefer signed
2814 types to unsigned, to avoid integer comparison confusion. Without
2815 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2816 "cannot optimize loop, the loop counter may overflow", a symptom
2817 of the confusion.
f00bbb22 2818 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2819 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2820
6468f31c
LMI
28212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2822
49080b10
LMI
2823 * search.c (Fre_search_backward): Mention `case-fold-search' in
2824 all the re_search_* functions (bug#8138).
2825
6468f31c
LMI
2826 * keyboard.c (Fopen_dribble_file): Document when the file is
2827 closed (bug#8056).
2828
c965adc5
EZ
28292011-07-14 Eli Zaretskii <eliz@gnu.org>
2830
df9733bf
EZ
2831 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2832 bidi_cache_idx.
2833
0bb23927
EZ
2834 Support bidi reordering of display and overlay strings.
2835 * xdisp.c (compute_display_string_pos)
2836 (compute_display_string_end): Accept additional argument STRING.
2837 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2838 (reseat_to_string): Initialize bidi_it->string.s and
2839 bidi_it->string.schars.
2840 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2841 NULL (avoids a crash in bidi_paragraph_init).
2842 Initialize itb.string.lstring.
0bb23927
EZ
2843 (init_iterator): Call bidi_init_it only of a valid
2844 buffer position was specified. Initialize paragraph_embedding to
2845 L2R.
2846 (reseat_to_string): Initialize the bidi iterator.
2847 (display_string): If we need to ignore text properties of
2848 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2849 original value of -1 will not work with bidi.)
2850 (compute_display_string_pos): First arg is now struct
2851 `text_pos *'; all callers changed. Support display properties on
2852 Lisp strings.
2853 (compute_display_string_end): Support display properties on Lisp
2854 strings.
2855 (init_iterator, reseat_1, reseat_to_string): Initialize the
2856 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2857 when iterating on a string not from display properties).
640c8776
SM
2858 (compute_display_string_pos, compute_display_string_end):
2859 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2860 arrow keys.
2861 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2862 base_level_stop; instead, set base_level_stop to BEGV.
2863 Fixes crashes in vertical-motion.
0bb23927
EZ
2864 (next_element_from_buffer): Improve commentary for when
2865 the iterator is before prev_stop.
2866 (init_iterator): Initialize bidi_p from the default value of
2867 bidi-display-reordering, not from buffer-local value. Use the
2868 buffer-local value only if initializing for buffer iteration.
2869 (handle_invisible_prop): Support invisible properties on strings
2870 that are being bidi-reordered.
2871 (set_iterator_to_next): Support bidi reordering of C strings and
2872 Lisp strings.
2873 (next_element_from_string): Support bidi reordering of Lisp
2874 strings.
2875 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2876 (display_string): Support display of R2L glyph rows.
2877 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2878 (init_iterator): Don't initialize it->bidi_p for strings
2879 here.
2880 (reseat_to_string): Initialize it->bidi_p for strings here.
2881 (next_element_from_string, next_element_from_c_string)
2882 (next_element_from_buffer): Add xassert's for correspondence
2883 between IT's object being iterated and it->bidi_it.string
2884 structure.
2885 (face_before_or_after_it_pos): Support bidi iteration.
2886 (next_element_from_c_string): Handle the case of the first string
2887 character that is not the first one in the visual order.
2888 (get_visually_first_element): New function, refactored from common
2889 parts of next_element_from_buffer, next_element_from_string, and
2890 next_element_from_c_string.
2891 (tool_bar_lines_needed, redisplay_tool_bar)
2892 (display_menu_bar): Force left-to-right direction. Add a FIXME
2893 comment for making that be controlled by a user option.
2894 (push_it, pop_it): Save and restore the state of the
2895 bidi iterator. Save and restore the bidi_p flag.
2896 (pop_it): Iterate out of display property for string iteration as
2897 well.
2898 (iterate_out_of_display_property): Support iteration over strings.
2899 (handle_single_display_spec): Set up it->bidi_it for iteration
2900 over a display string, and call bidi_init_it.
2901 (handle_single_display_spec, next_overlay_string)
2902 (get_overlay_strings_1, push_display_prop): Set up the bidi
2903 iterator for displaying display or overlay strings.
2904 (forward_to_next_line_start): Don't use the shortcut if
2905 bidi-iterating.
2906 (back_to_previous_visible_line_start): If handle_display_prop
2907 pushed the iterator stack, restore the internal state of the bidi
2908 iterator by calling bidi_pop_it same number of times.
2909 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2910 and we are bidi-iterating, don't decrement the iterator position;
2911 instead, set the first_elt flag in the bidi iterator, to produce
2912 the same effect.
2913 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2914 (push_display_prop): xassert that we are iterating a buffer.
2915 (push_it, pop_it): Save and restore paragraph_embedding member.
2916 (handle_single_display_spec, next_overlay_string)
2917 (get_overlay_strings_1, reseat_1, reseat_to_string)
2918 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2919 correctly. Don't assume unibyte strings are not bidi-reordered.
2920 (compute_display_string_pos)
2921 (compute_display_string_end): Fix handling the case of C string.
2922 (push_it, pop_it): Save and restore from_disp_prop_p.
2923 (handle_single_display_spec, push_display_prop): Set the
2924 from_disp_prop_p flag.
2925 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2926 (pop_it): Call iterate_out_of_display_property only if we are
2927 popping after iteration over a string that came from a display
2928 property. Fix a typo in popping stretch info. Add an assertion
2929 for verifying that the iterator position is in sync with the bidi
2930 iterator.
2931 (handle_single_display_spec, get_overlay_strings_1)
2932 (push_display_prop): Fix initialization of paragraph direction for
2933 string when that of the parent object is not yet determined.
2934 (reseat_1): Call bidi_init_it to resync the bidi
2935 iterator with IT's position. (Bug#7616)
2936 (find_row_edges): If ROW->start.pos gives position
2937 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2938 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2939 Reset the from_disp_prop_p flag.
2940 (SAVE_IT, RESTORE_IT): New macros.
2941 (pos_visible_p, face_before_or_after_it_pos)
2942 (back_to_previous_visible_line_start)
2943 (move_it_in_display_line_to, move_it_in_display_line)
2944 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2945 (try_scrolling, redisplay_window, display_line): Use them when
2946 saving a temporary copy of the iterator and restoring it back.
2947 (back_to_previous_visible_line_start, reseat_1)
2948 (init_iterator): Empty the bidi cache "stack".
2949 (move_it_in_display_line_to): If iterator ended up at
2950 EOL, but we never saw any buffer positions smaller than
2951 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2952 motion in bidi-reordered lines.
2953 (move_it_in_display_line_to): Record prev_method and prev_pos
2954 immediately before the call to set_iterator_to_next. Fixes cursor
2955 motion in bidi-reordered lines with stretch glyphs and strings
2956 displayed in margins. (Bug#8133) (Bug#8867)
2957 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2958 TO_CHARPOS.
640c8776
SM
2959 (pos_visible_p): Support positions in bidi-reordered lines.
2960 Save and restore bidi cache.
0bb23927
EZ
2961
2962 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2963 (bidi_paragraph_info): Delete unused struct.
2964 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2965 (bidi_cache_start): New variable.
2966 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2967 to zero.
2968 (bidi_cache_fetch_state, bidi_cache_search)
2969 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2970 (bidi_cache_find, bidi_peek_at_next_level)
2971 (bidi_level_of_next_char, bidi_find_other_level_edge)
2972 (bidi_move_to_visually_next): Compare cache index with
2973 bidi_cache_start rather than with zero.
2974 (bidi_fetch_char): Accept new argument STRING; all callers
2975 changed. Support iteration over a string. Support strings with
2976 display properties. Support unibyte strings. Fix the type of
2977 `len' according to what STRING_CHAR_AND_LENGTH expects.
2978 (bidi_paragraph_init, bidi_resolve_explicit_1)
2979 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2980 (bidi_level_of_next_char, bidi_move_to_visually_next):
2981 Support iteration over a string.
0bb23927
EZ
2982 (bidi_set_sor_type, bidi_resolve_explicit_1)
2983 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2984 can now be zero (for strings); special values 0 and -1 were
2985 changed to -1 and -2, respectively.
2986 (bidi_char_at_pos): New function.
2987 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2988 Call it instead of FETCH_MULTIBYTE_CHAR.
2989 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2990 initialized to valid values.
2991 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2992 values.
2993 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2994 the test for valid cached positions. Fix the logic for looking up
2995 the sentinel state in the cache. GCPRO the Lisp string we are
2996 iterating.
2997 (bidi_push_it, bidi_pop_it): New functions.
2998 (bidi_initialize): Initialize the bidi cache start stack pointer.
2999 (bidi_cache_ensure_space): New function, refactored from part of
3000 bidi_cache_iterator_state. Don't assume the required size is just
3001 one BIDI_CACHE_CHUNK away.
3002 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3003 (bidi_count_bytes, bidi_char_at_pos): New functions.
3004 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3005 always valid if bidi_cache_idx is valid.
3006 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3007 is valid if it's going to be used.
3008 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3009 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3010 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3011 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3012 (bidi_find_other_level_edge, bidi_cache_start_stack):
3013 All variables related to cache indices are now EMACS_INT.
c965adc5 3014
0bb23927
EZ
3015 * dispextern.h (struct bidi_string_data): New structure.
3016 (struct bidi_it): New member `string'. Make flag members be 1-bit
3017 fields, and put them last in the struct.
640c8776
SM
3018 (compute_display_string_pos, compute_display_string_end):
3019 Update prototypes.
0bb23927
EZ
3020 (bidi_push_it, bidi_pop_it): Add prototypes.
3021 (struct iterator_stack_entry): New members bidi_p,
3022 paragraph_embedding, and from_disp_prop_p.
3023 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3024 (bidi_shelve_cache, bidi_unshelve_cache):
3025 Declare prototypes.
0bb23927
EZ
3026
3027 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3028 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3029 and vector-like objects.
3030
3031 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3032 cache around display iteration.
3033
3034 * window.c (Fwindow_end, window_scroll_pixel_based)
3035 (displayed_window_lines, Frecenter): Save and restore the bidi
3036 cache around display iteration.
3037
3bbd2265
LMI
30382011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3039
3040 * editfns.c (Fdelete_region): Clarify the use of the named
3041 parameters (bug#6788).
3042
adc47434
MR
30432011-07-14 Martin Rudalics <rudalics@gmx.at>
3044
3045 * indent.c (Fvertical_motion): Set and restore w->pointm when
3046 saving and restoring the window's buffer (Bug#9006).
3047
837c31f8
LMI
30482011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3049
3050 * editfns.c (Fstring_to_char): Clarify just what is returned
3051 (bug#6576). Text by Eli Zaretskii.
3052
ac389d0c
JB
30532011-07-13 Juanma Barranquero <lekktu@gmail.com>
3054
3055 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3056
0be0ce47
EZ
30572011-07-13 Eli Zaretskii <eliz@gnu.org>
3058
3059 * buffer.c (mmap_find): Fix a typo.
3060
cd18e7e3
JB
30612011-07-13 Johan Bockgård <bojohan@gnu.org>
3062
3063 Fix execution of x selection hooks.
3064 * xselect.c (Qx_lost_selection_functions)
3065 (Qx_sent_selection_functions): New vars.
3066 (syms_of_xselect): DEFSYM them.
3067 (x_handle_selection_request): Pass Qx_sent_selection_functions
3068 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3069 (x_handle_selection_clear,x_clear_frame_selections):
3070 Pass Qx_lost_selection_functions rather than
3071 Vx_lost_selection_functions to Frun_hook_with_args.
3072
47ea7f44
PE
30732011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3074
ac389d0c 3075 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3076 The old code sometimes used this field without initializing it.
3077
47ea7f44
PE
3078 * alloc.c (gc_sweep): Don't read past end of array.
3079 In theory, the old code could also have corrupted Emacs internals,
3080 though it'd be very unlikely.
3081
bc985c87
AS
30822011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3083
3084 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3085 argument. (Bug#4026)
bc985c87 3086
0cf34688
LMI
30872011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3088
b3dadd76
LMI
3089 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3090 key" (bug#4257).
3091
0cf34688
LMI
3092 * window.c (Fset_window_start): Doc fix (bug#4199).
3093 (Fset_window_hscroll): Ditto.
3094
270768cd
PE
30952011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3096
077e3dda 3097 Fix minor new problems caught by GCC 4.6.1.
270768cd 3098 * term.c (init_tty): Remove unused local.
490011a6 3099 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3100 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3101 not used otherwise.
270768cd 3102
b1f58454
CY
31032011-07-12 Chong Yidong <cyd@stupidchicken.com>
3104
3105 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3106
22b9578d
LMI
31072011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3108
6e70ab07
LMI
3109 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3110 are the mini-buffer and the echo area (bug#3320).
3111
22b9578d
LMI
3112 * term.c (init_tty): Remove support for supdup, c10 and perq
3113 terminals, which are no longer supported (bug#1482).
3114
8974cc9f
JB
31152011-07-10 Johan Bockgård <bojohan@gnu.org>
3116
3117 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3118
a560d974
JD
31192011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3120
3121 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3122 for non-popups (Bug#3642).
3123
1dae0f0a
AS
31242011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3125
268c2c36 3126 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3127 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3128 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3129 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3130 * data.c (fmod): Likewise.
3131 * dispnew.c (swap_glyphs_in_rows): Likewise.
3132 * emacs.c (memory_warning_signal): Likewise.
3133 * floatfns.c (float_error): Likewise.
3134 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3135 (otf_open, font_otf_capability, generate_otf_features)
3136 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3137 Likewise.
3138 * image.c (pbm_read_file): Likewise.
3139 * indent.c (string_display_width): Likewise.
3140 * intervals.c (check_for_interval, search_for_interval)
3141 (inc_interval_count, count_intervals, root_interval)
3142 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3143 * lread.c (defalias): Likewise.
268c2c36 3144 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3145 * regex.c (set_image_of_range_1, set_image_of_range)
3146 (regex_grow_registers): Likewise.
3147 * sysdep.c (strerror): Likewise.
3148 * termcap.c (valid_filename_p, tprint, main): Likewise.
3149 * tparam.c (main): Likewise.
3150 * unexhp9k800.c (run_time_remap, save_data_space)
3151 (update_file_ptrs, read_header, write_header, calculate_checksum)
3152 (copy_file, copy_rest, display_header): Likewise.
3153 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3154 Likewise.
3155 * xdisp.c (check_it): Likewise.
3156 * xfaces.c (register_color, unregister_color, unregister_colors):
3157 Likewise.
3158 * xfns.c (print_fontset_result): Likewise.
3159 * xrdb.c (member, fatal, main): Likewise.
3160
99033785
PE
31612011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3162
3163 Fix minor problems found by static checking (Bug#9031).
3164 * chartab.c (char_table_set_range, map_sub_char_table):
3165 Remove unused locals.
3166 (uniprop_table): Now static.
3167 * composite.c (_work_char): Remove unused static var.
3168
9cb2ac56
JB
31692011-07-09 Juanma Barranquero <lekktu@gmail.com>
3170
3171 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3172
f25661f0
JD
31732011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3174
3175 * gtkutil.c (qttip_cb): Remove code without function.
3176
8278c4fe
EZ
31772011-07-09 Eli Zaretskii <eliz@gnu.org>
3178
3179 * w32.c (pthread_sigmask): New stub.
3180
1692ae2d 31812011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3182
8a6ebd58 3183 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3184 sigprocmask is portable only for single-threaded applications, and
3185 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3186 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3187 (LIBES): Use it.
3188 * callproc.c (Fcall_process):
3189 * process.c (create_process):
3190 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3191 Use pthread_sigmask, not sigprocmask.
123403e4 3192
1b854618
JD
31932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3194
3195 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3196 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3197 wrong (Bug#8591).
3198
3fe4b549
JD
31992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3200
0ce7e563
JD
3201 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3202 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3203 (xg_hide_tooltip): Fix comment.
3204
3fe4b549
JD
3205 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3206 in registerServicesMenuSendTypes.
3207 (validRequestorForSendType): Don't check ns_return_types.
3208
3209 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3210 ns_return_type.
3211
5df75e47
JR
32122011-07-08 Jason Rumney <jasonr@gnu.org>
3213
22610910
JR
3214 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3215 SH_SHOW for hidden windows (Bug#5482).
3216
5df75e47
JR
3217 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3218 frame struct members of non-existent frames (Bug#6284).
3219
699c10bd
JD
32202011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3221
4393663b
JD
3222 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3223 variable firstTime not needed on OSX >= 10.6.
3224 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3225 >= 10.5. Use setKnobProportion, setDoubleValue.
3226
3227 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3228 (MAC_OS_X_VERSION_10_5): Define if not defined.
3229 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3230 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3231 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3232
3233 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3234 cString and lossyCString on OSX >= 10.4
3235
58179cce 3236 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3237 sizeToFit on OSX >= 10.2.
3238
3239 * nsimage.m (allocInitFromFile): Don't use deprecated method
3240 bestRepresentationForDevice on OSX >= 10.6.
3241
3242 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3243 to avoid warning.
3244
3245 * emacs.c: Declare unexec_init_emacs_zone.
3246
a63e0781
JD
3247 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3248
699c10bd
JD
3249 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3250
3251 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3252 on svcsMenu (Bug#8842).
3253
3254 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3255 ns_return_types.
3256 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3257
3258 * nsterm.m (QUTF8_STRING): Declare.
3259 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3260 (validRequestorForSendType): Return type is (id).
3261 Change indexOfObjectIdenticalTo to indexOfObject.
3262 Check if we have local selection before returning self (Bug#8842).
3263 (writeSelectionToPasteboard): Put local selection into paste board
3264 if we have a local selection (Bug#8842).
3265 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3266
3267 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3268 (ns_get_local_selection): Declare.
3269
54e10184
LMI
32702011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3271
9888ff71
LMI
3272 * keymap.c (describe_map_tree): Don't insert a double newline at
3273 the end of the buffer (bug#1169) and return whether we inserted
3274 something.
3275
54e10184
LMI
3276 * callint.c (Fcall_interactively): Change "reading args" to
3277 "providing args" to try to clarify what it does (bug#1010).
3278
15fa4783
KH
32792011-07-07 Kenichi Handa <handa@m17n.org>
3280
3281 * composite.c (composition_compute_stop_pos): Ignore a static
3282 composition starting before CHARPOS (Bug#8915).
3283
3284 * xdisp.c (handle_composition_prop): Likewise.
3285
a8815b00
EZ
32862011-07-07 Eli Zaretskii <eliz@gnu.org>
3287
3288 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3289 (Bug#9015)
3290
ef7b981d 32912011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3292
3293 * character.h (unicode_category_t): New enum type.
3294
3295 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3296 (Qchar_code_property_table): New variable.
3297 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3298 (UNIPROP_COMPRESSED_FORM_P): New macros.
3299 (char_table_ascii): Uncompress the compressed values.
3300 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3301 Uncompress the compressed values.
ac389d0c 3302 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3303 (char_table_ref_and_range): Uncompress the compressed values.
3304 (sub_char_table_set): New arg is_uniprop. Callers changed.
3305 Uncompress the compressed values.
3306 (sub_char_table_set_range): Args changed. Callers changed.
3307 (char_table_set_range): Adjuted for the above change.
3308 (map_sub_char_table): Delete args default_val and parent. Add arg
3309 top. Give decoded values to a Lisp function.
640c8776 3310 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3311 values to a Lisp function. Gcpro more variables.
3312 (uniprop_table_uncompress)
3313 (uniprop_decode_value_run_length): New functions.
3314 (uniprop_decoder, uniprop_decoder_count): New variables.
3315 (uniprop_get_decoder, uniprop_encode_value_character)
3316 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3317 New functions.
3318 (uniprop_encoder, uniprop_encoder_count): New variables.
3319 (uniprop_get_encoder, uniprop_table)
3320 (Funicode_property_table_internal, Fget_unicode_property_internal)
3321 (Fput_unicode_property_internal): New functions.
3322 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3323 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3324 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3325 char-code-property-alist.
3326
640c8776 3327 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3328 Vunicode_category_table.
3329
640c8776 3330 * font.c (font_range): Adjust for the change of
c805dec0
KH
3331 Vunicode_category_table.
3332
76b397fb
DN
33332011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3334
3335 * m/iris4d.h: Remove file, move contents ...
3336 * s/irix6-5.h: ... here.
3337
22b4128e
PE
33382011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3339
3340 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3341 * alloc.c (mark_buffer):
3342 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3343 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3344 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3345 This isn't true in general, and it's particularly not true
3346 if Emacs is configured with --with-wide-int.
3347 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3348 New macros, used in the buffer.c change.
3349
869795d6
JD
33502011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3351
3352 * xsettings.c: Use both GConf and GSettings if both are available.
3353 (store_config_changed_event): Add comment.
3354 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3355 (store_tool_bar_style_changed): New functions.
5e617bc2 3356 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3357 (struct xsettings): Move font inside HAVE_XFT.
3358 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3359 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3360 Move inside HAVE_XFT.
640c8776 3361 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3362 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3363 also.
3364 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3365 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3366 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3367 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3368 (parse_settings): Move check for font inside HAVE_XFT.
3369 (read_settings, apply_xft_settings): Add comment.
3370 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3371 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3372 call store_font_name_changed.
3373 (xft_settings_event): Add comment.
3374 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3375 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3376 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3377 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3378 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3379 (xsettings_get_system_font, xsettings_get_system_normal_font):
3380 Add comment.
869795d6 3381
d8ed26bd
PE
33822011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 Random fixes. E.g., (random) never returned negative values.
3385 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3386 subseconds part to the entropy, as that's a bit more random.
3387 Prefer signed to unsigned, since the signedness doesn't matter and
3388 in general we prefer signed. When given a limit, use a
3389 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3390 latter isn't right if USE_2_TAGS_FOR_INTS.
3391 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3392 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3393
cabf1cac
SM
33942011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3395
3396 * textprop.c (text_property_stickiness):
3397 Obey Vtext_property_default_nonsticky.
3398 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3399 * w32fns.c (syms_of_w32fns):
3400 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3401
6e9b2be9
PE
34022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3403
3404 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3405 This is more efficient than Ffile_directory_p and avoids a minor race.
3406
90186c68
LMI
34072011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3408
7c301272
LMI
3409 * buffer.c (Foverlay_put): Say what the return value is
3410 (bug#7835).
3411
c4f2d8d4
LMI
3412 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3413 is a directory before asking whether to use the file name
3414 (bug#7564).
ad637907
LMI
3415 (barf_or_query_if_file_exists): Make the "File is a directory"
3416 error be more correct.
c4f2d8d4 3417
90186c68
LMI
3418 * fns.c (Frequire): Remove the mention of the .gz files, since
3419 that's installation-specific, but keep the mention of
3420 `get-load-suffixes'.
3421
da64016e
PE
34222011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3423
3424 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3425 Report string overflow if the output is too long.
3426
7d47b580
JB
34272011-07-04 Juanma Barranquero <lekktu@gmail.com>
3428
a555cb87
JB
3429 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3430 (syms_of_gnutls): Remove duplicate DEFSYM for
3431 Qgnutls_bootprop_verify_hostname_error, an error for
3432 Qgnutls_bootprop_verify_error (which is no longer used).
3433
7d47b580
JB
3434 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3435 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3436 Also (re)move comments that are misplaced or no longer relevant.
3437
1e49bfab
LMI
34382011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3439
3440 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3441
1485f4c0
CY
34422011-07-03 Chong Yidong <cyd@stupidchicken.com>
3443
3444 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3445 and background color parameters if they have been changed.
3446
a9ab721e
LMI
34472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3448
3449 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3450
cf7cff57
PE
34512011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3452
2e13213d
PE
3453 * xsettings.c (SYSTEM_FONT): Define only when used.
3454 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3455
cf7cff57
PE
3456 * keymap.c (access_keymap_1): Now static.
3457
7a8e04f7
CY
34582011-07-02 Chong Yidong <cyd@stupidchicken.com>
3459
3460 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3461 leave any prefix arg for the up event (Bug#1586).
3462
61352f62
LMI
34632011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3464
69bb1ef7
LMI
3465 * lread.c (syms_of_lread): Mention single symbols defined by
3466 `defvar' or `defconst' (bug#7154).
3467
61352f62 3468 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3469 (Frequire): Mention get-load-suffixes.
61352f62 3470
28545e04
MR
34712011-07-02 Martin Rudalics <rudalics@gmx.at>
3472
3473 * window.h (window): Remove clone_number slot.
3474 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3475 Remove.
3476 (make_parent_window, make_window, saved_window)
3477 (Fset_window_configuration, save_window_save): Don't deal with
3478 clone numbers.
3479 * buffer.c (Qclone_number): Remove declaration.
3480 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3481
3349e122
SM
34822011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3483
3484 Add multiple inheritance to keymaps.
3485 * keymap.c (Fmake_composed_keymap): New function.
3486 (Fset_keymap_parent): Simplify.
3487 (fix_submap_inheritance): Remove.
3488 (access_keymap_1): New function extracted from access_keymap to handle
3489 embedded parents and handle lists of maps.
3490 (access_keymap): Use it.
3491 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3492 (Fcopy_keymap): Handle embedded parents.
3493 (Fcommand_remapping, define_as_prefix): Simplify.
3494 (Fkey_binding): Simplify.
3495 (syms_of_keymap): Move minibuffer-local-completion-map,
3496 minibuffer-local-filename-completion-map,
3497 minibuffer-local-must-match-map, and
3498 minibuffer-local-filename-must-match-map to Elisp.
3499 (syms_of_keymap): Defsubr make-composed-keymap.
3500 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3501 (parse_menu_item): Trivial simplification.
3502
3279eb87
GM
35032011-07-01 Glenn Morris <rgm@gnu.org>
3504
3505 * Makefile.in (SETTINGS_LIBS): Fix typo.
3506
4550efdf
KI
35072011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3508
3509 * coding.c (Fencode_coding_string): Record the last coding system
3510 used, as the function doc string says (bug#8738).
3511
0949d2b6
JD
35122011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3513
3514 * xsettings.c (store_monospaced_changed): Take new font as arg and
3515 check for change against current_mono_font.
3516 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3517 (emacs_settings_constructor, emacs_settings_get_property)
3518 (emacs_settings_set_property, emacs_settings_class_init)
3519 (emacs_settings_init, gsettings_obj): Remove.
3520 (something_changedCB): New function for HAVE_GSETTINGS.
3521 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3522 with value as argument.
3523 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3524 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3525 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3526 "changed".
3527
3528 * xgselect.c: Add defined (HAVE_GSETTINGS).
3529 (xgselect_initialize): Ditto.
3530
3531 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3532 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3533 xg_select.
3534
bbc6b304
PE
35352011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3536
3537 * eval.c (struct backtrace): Simplify and port the data structure.
3538 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3539 signed bit field, as this assumption is not portable and it makes
3540 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3541 "char debug_on_exit : 1" as this is not portable either; instead,
3542 use the portable "unsigned int debug_on_exit : 1". Remove unused
3543 member evalargs. Remove obsolete comments about cc bombing out.
3544
9851bfc5
JD
35452011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3546
51bb811f 3547 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3548 Let HAVE_GSETTINGS override HAVE_GCONF.
3549 (store_monospaced_changed): New function.
3550 (EMACS_SETTINGS): A new type derived from GObject to handle
3551 GSettings notifications.
3552 (emacs_settings_constructor, emacs_settings_get_property)
3553 (emacs_settings_set_property, emacs_settings_class_init):
3554 New functions.
3555 (gsettings_client, gsettings_obj): New variables.
3556 (GSETTINGS_SCHEMA): New define.
3557 (something_changedCB): Call store_monospaced_changed.
3558 (init_gsettings): New function.
3559 (xsettings_initialize): Call init_gsettings.
3560 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3561 to NULL.
3562
640c8776 3563 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3564 GCONF_CFLAGS/LIBS.
3565
5386012d
MR
35662011-06-29 Martin Rudalics <rudalics@gmx.at>
3567
3568 * window.c (resize_root_window, grow_mini_window)
3569 (shrink_mini_window): Rename Qresize_root_window to
3570 Qwindow_resize_root_window and Qresize_root_window_vertically to
3571 Qwindow_resize_root_window_vertically.
3572
f13e0b08
PE
35732011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3574
3575 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3576
94515237
JB
35772011-06-27 Juanma Barranquero <lekktu@gmail.com>
3578
3579 * makefile.w32-in: Redesign dependencies so they reflect more
3580 clearly which files are directly included by each source file,
3581 and not through other includes.
3582
e43b6e43
MR
35832011-06-27 Martin Rudalics <rudalics@gmx.at>
3584
3585 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3586 (sort_overlays, overlay_strings): When an overlay's clone number
3587 matches the window's clone number process the overlay even if
3588 the overlay's window property doesn't match the current window.
3589
d68443dc
MR
3590 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3591 (Fwindow_hchild): Rename to Fwindow_left_child.
3592 (Fwindow_next): Rename to Fwindow_next_sibling.
3593 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3594 (resize_window_check): Rename to window_resize_check.
3595 (resize_window_apply): Rename to window_resize_apply.
3596 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3597 (Fdelete_other_windows_internal, resize_frame_windows)
3598 (Fsplit_window_internal, Fdelete_window_internal)
3599 (grow_mini_window, shrink_mini_window)
3600 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3601
c7e73be5
JD
36022011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3603
3604 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3605 (emacs_fixed_set_min_size): Remove.
3606 (emacs_fixed_new): Take frame as argument.
3607
3608 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3609 (_EmacsFixedPrivate): Remove minwidth/height.
3610 Add struct frame *f.
3611 (emacs_fixed_init): Initialize priv->f.
3612 (get_parent_class, emacs_fixed_set_min_size): Remove.
3613 (emacs_fixed_new): Set priv->f to argument.
3614 (emacs_fixed_get_preferred_width)
3615 (emacs_fixed_get_preferred_height): Use min_width/height from
3616 frames size_hint to set minimum and natural (Bug#8919).
3617 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3618 and use min_width/height from frames size_hint to set
3619 min_width/height (Bug#8919).
3620
3621 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3622 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3623 Fix indentation.
c7e73be5 3624
cf99dcf8
EZ
36252011-06-26 Eli Zaretskii <eliz@gnu.org>
3626
3627 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3628 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3629 called at ZV.
3630
029529ac
CY
36312011-06-26 Chong Yidong <cyd@stupidchicken.com>
3632
3633 * process.c (wait_reading_process_output): Bypass select if
3634 waiting for a cell while ignoring keyboard input, and input is
3635 pending. Suggested by Jan Djärv (Bug#8869).
3636
7a7ef429
PE
36372011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3638
3639 Use gnulib's dup2 module instead of rolling our own.
3640 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3641
11fdef7d 36422011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3643
3644 * dispnew.c (scrolling_window): Before scrolling, turn off a
3645 mouse-highlight in the window being scrolled.
3646
cd3520a4
JB
36472011-06-24 Juanma Barranquero <lekktu@gmail.com>
3648
3649 Move DEFSYM to lisp.h and use everywhere.
3650
3651 * character.h (DEFSYM): Move declaration...
3652 * lisp.h (DEFSYM): ...here.
3653
3654 * gnutls.c:
3655 * minibuf.c:
3656 * w32menu.c:
3657 * w32proc.c:
3658 * w32select.c: Don't include character.h.
3659
3660 * alloc.c (syms_of_alloc):
3661 * buffer.c (syms_of_buffer):
3662 * bytecode.c (syms_of_bytecode):
3663 * callint.c (syms_of_callint):
3664 * casefiddle.c (syms_of_casefiddle):
3665 * casetab.c (init_casetab_once):
3666 * category.c (init_category_once, syms_of_category):
3667 * ccl.c (syms_of_ccl):
3668 * cmds.c (syms_of_cmds):
3669 * composite.c (syms_of_composite):
3670 * dbusbind.c (syms_of_dbusbind):
3671 * dired.c (syms_of_dired):
3672 * dispnew.c (syms_of_display):
3673 * doc.c (syms_of_doc):
3674 * editfns.c (syms_of_editfns):
3675 * emacs.c (syms_of_emacs):
3676 * eval.c (syms_of_eval):
3677 * fileio.c (syms_of_fileio):
3678 * fns.c (syms_of_fns):
3679 * frame.c (syms_of_frame):
3680 * fringe.c (syms_of_fringe):
3681 * insdel.c (syms_of_insdel):
3682 * keymap.c (syms_of_keymap):
3683 * lread.c (init_obarray, syms_of_lread):
3684 * macros.c (syms_of_macros):
3685 * msdos.c (syms_of_msdos):
3686 * print.c (syms_of_print):
3687 * process.c (syms_of_process):
3688 * search.c (syms_of_search):
3689 * sound.c (syms_of_sound):
3690 * syntax.c (init_syntax_once, syms_of_syntax):
3691 * terminal.c (syms_of_terminal):
3692 * textprop.c (syms_of_textprop):
3693 * undo.c (syms_of_undo):
3694 * w32.c (globals_of_w32):
3695 * window.c (syms_of_window):
3696 * xdisp.c (syms_of_xdisp):
3697 * xfaces.c (syms_of_xfaces):
3698 * xfns.c (syms_of_xfns):
3699 * xmenu.c (syms_of_xmenu):
3700 * xsettings.c (syms_of_xsettings):
3701 * xterm.c (syms_of_xterm): Use DEFSYM.
3702
4228cf16
TZ
37032011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3704
cd3520a4 3705 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3706
7fcccf1e
PE
37072011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3708
7efb4e0e
PE
3709 Integer and buffer overflow fixes (Bug#8873).
3710
ff5844ad
PE
3711 * print.c (printchar, strout): Check for string overflow.
3712 (PRINTPREPARE, printchar, strout):
3713 Don't set size unless allocation succeeds.
3714
90532f02
PE
3715 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3716 for sizes. Check for string overflow more accurately.
3717 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3718
6d84508d
PE
3719 * macros.c: Integer and buffer overflow fixes.
3720 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3721 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3722 Use ptrdiff_t, not int, for sizes.
3723 Don't increment bufsize until after realloc succeeds.
3724 Check for size-calculation overflow.
3725 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3726
437b2cb4
PE
3727 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3728
8b9ac8b4
PE
3729 * lread.c: Integer overflow fixes.
3730 (read_integer): Radix is now EMACS_INT, not int,
3731 to improve quality of diagnostics for out-of-range radices.
3732 Calculate buffer size correctly for out-of-range radices.
3733 (read1): Check for integer overflow in radices, and in
3734 read-circle numbers.
82cb60d3
PE
3735 (read_escape): Avoid int overflow.
3736 (Fload, openp, read_buffer_size, read1)
3737 (substitute_object_recurse, read_vector, read_list, map_obarray):
3738 Use ptrdiff_t, not int, for sizes.
3739 (read1): Use EMACS_INT, not int, for sizes.
20270765 3740 Check for size overflow.
8b9ac8b4 3741
7fcccf1e
PE
3742 * image.c (cache_image): Check for size arithmetic overflow.
3743
bfbbd7e7
PE
3744 * lread.c: Integer overflow issues.
3745 (saved_doc_string_size, saved_doc_string_length)
3746 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3747 Now ptrdiff_t, not int.
3748 (read1): Don't assume doc string length fits in int. Check for
3749 out-of-range doc string lengths.
3750 (read_list): Don't assume file position fits in int.
39019e54 3751 (read_escape): Check for hex character overflow.
bfbbd7e7 3752
4e323265
LL
37532011-06-22 Leo Liu <sdl.web@gmail.com>
3754
3755 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3756 Move to minibuffer.el.
3757
85fece3e
PE
37582011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3759
20b84ce9 3760 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3761 The following patches are for when GLYPH_DEBUG && !XASSERT.
3762 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3763 * dispnew.c (flush_stdout):
3764 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3765 Mark as externally visible.
3766 * dispnew.c (check_window_matrix_pointers): Now static.
3767 * dispnew.c (window_to_frame_vpos):
3768 * xfns.c (unwind_create_frame):
3769 * xterm.c (x_check_font): Remove unused local.
3770 * scroll.c (CHECK_BOUNDS):
3771 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3772 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3773 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3774 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3775 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3776 Now static.
3777 (debug_method_add): Use va_list and vsprintf rather than relying
3778 on undefined behavior with wrong number of arguments.
3779 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3780 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3781 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3782 since we're not interested in debugging glyphs with old libraries.
3783 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3784 GCC 4.6.0's static checking.
3785
0766b489
PE
37862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3787
31fd4b32
PE
3788 Integer overflow and signedness fixes (Bug#8873).
3789 A few related buffer overrun fixes, too.
3790
b79e8648
PE
3791 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3792
0766b489
PE
3793 * dispextern.h (struct face.stipple):
3794 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3795 (x_bitmap_mask, x_allocate_bitmap_record)
3796 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3797 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3798 (x_create_bitmap_from_xpm_data):
3799 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3800 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3801 (.bitmaps_last):
3802 * xfaces.c (load_pixmap):
3803 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3804 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3805 (.bitmaps_last, struct x_output.icon_bitmap):
3806 Use ptrdiff_t, not int, for bitmap indexes.
3807 (x_allocate_bitmap_record): Check for size overflow.
3808 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3809
b081724f
PE
3810 Use ptrdiff_t, not int, for overlay counts.
3811 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3812 * editfns.c (overlays_around, get_pos_property):
3813 * textprop.c (get_char_property_and_overlay):
3814 * xdisp.c (next_overlay_change, note_mouse_highlight):
3815 * xfaces.c (face_at_buffer_position):
21514da7
PE
3816 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3817 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3818 (Fnext_overlay_change, Fprevious_overlay_change)
3819 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3820 Use ptrdiff_t, not int, for sizes.
21514da7 3821 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3822
3de73e5e
PE
3823 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3824
2606c57b
PE
3825 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3826 (x_session_initialize): Do not assume string length fits in int.
3827
aaafe47a
PE
3828 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3829 This is unlikely, but can occur if DPI is outlandish.
3830
2674ddc8 3831 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3832 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3833
28154962
PE
3834 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3835 * xrdb.c (magic_file_p, search_magic_path):
3836 Omit last arg SUFFIX; it was always 0. All callers changed.
3837 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3838
7de51af5
PE
3839 * xfont.c (xfont_match): Avoid need for strlen.
3840
25ed6cc3
PE
3841 * xfns.c: Don't assume strlen fits in int.
3842 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3843
4eab31dd
PE
3844 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3845 not unsigned long, as we prefer signed integers. All callers changed.
3846 Detect integer overflow in repeat count.
3847 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3848 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3849
171e2a58
PE
3850 * termcap.c: Don't assume sizes fit in int and never overflow.
3851 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3852 (gobble_line): Check for size-calculation overflow.
3853
ad39faca 3854 * minibuf.c (Fread_buffer):
6e5bb2dc 3855 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3856 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3857 Don't assume string length fits in int.
3858
52c61c22 3859 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3860 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3861
b5b8c9e5
PE
3862 * font.c: Don't assume string length fits in int.
3863 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3864 Use ptrdiff_t, not int.
ccd6111c
PE
3865 (font_intern_prop): Don't assume string length fits in int.
3866 Don't assume integer property fits in fixnum.
3867 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3868
882f0d81 3869 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3870 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3871 Reformulate so as not to need the command string.
3872 Invoke gzip -cd rather than gunzip, as it's more portable.
3873 (lock_info_type, lock_file_1, lock_file):
3874 Don't assume pid_t and time_t fit in unsigned long.
3875 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3876 (current_lock_owner): Prefer signed type for sizes.
3877 Use memcpy, not strncpy, where memcpy is what is really wanted.
3878 Don't assume (via atoi) that time_t and pid_t fit in int.
3879 Check for time_t and/or pid_t out of range, e.g., via a network share.
3880 Don't alloca where an auto var works fine.
3881
93f4cf88
PE
3882 * fileio.c: Fix some integer overflow issues.
3883 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3884 Don't assume string length fits in int.
3885 (directory_file_name): Don't assume string length fits in long.
3886 (make_temp_name): Don't assume pid fits in int, or that its print
3887 length is less than 20.
3888
f3e92b69
PE
3889 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3890
1bfdaf10
PE
3891 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3892
35016e9a
PE
3893 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3894
3d1e65a1
PE
3895 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3896 We prefer signed integers, even for size calculations.
3897
0b963a93
PE
3898 * emacs.c: Don't assume string length fits in 'int'.
3899 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3900 (main): Don't invoke strlen when not needed.
3901
573f4b54
PE
3902 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3903 (XD_DEBUG_MESSAGE): Don't waste a byte.
3904
989f33ba
PE
3905 * callproc.c (getenv_internal_1, getenv_internal)
3906 (Fgetenv_internal):
965d34eb
PE
3907 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3908
e4d29b33
PE
3909 * lread.c (invalid_syntax): Omit length argument.
3910 All uses changed. This doesn't fix a bug, but it simplifies the
3911 code away from its former Hollerith-constant appearance, and it's
3912 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3913 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3914
eb49b136
PE
3915 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3916 This didn't break anything, but it didn't help either.
3917 It's confusing to put a bogus integer in a place where the actual
3918 value does not matter.
9f62aeb1 3919 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3920 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3921
15375a22
PE
3922 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3923 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3924 implementation.
b61cc01c
PE
3925 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3926 We prefer signed types, and the value cannot exceed the EMACS_INT
3927 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3928 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3929 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3930 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3931
53b2623d
PE
3932 * indent.c (sane_tab_width): New function.
3933 (current_column, scan_for_column, Findent_to, position_indentation)
3934 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3935 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3936
51cab52b 3937 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3938
f2ed8a70
PE
3939 * lisp.h (lint_assume): New macro.
3940 * composite.c (composition_gstring_put_cache):
3941 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3942
abe80cc6
PE
3943 * editfns.c, insdel.c:
3944 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3945
b02c740e
PE
3946 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3947
ebc96716
PE
3948 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3949
b4e50fa0 3950 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3951 Use much-faster test for byte-length change.
311d5d7c 3952 Don't assume string byte-length fits in 'int'.
a4cf38e4 3953 Check that character arg fits in 'int'.
85461888 3954 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3955
c0c1ee9f
PE
3956 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3957
a498d7f4
PE
3958 * fns.c (concat): Catch string overflow earlier.
3959 Do not rely on integer wraparound.
3960
51cab52b
PE
3961 * dispextern.h (struct it.overlay_strings_charpos)
3962 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3963 * xdisp.c (forward_to_next_line_start)
3964 (back_to_previous_visible_line_start)
3965 (reseat_at_next_visible_line_start, next_element_from_buffer):
3966 Don't arbitrarily truncate the value of 'selective' to int.
3967
76031fad
PE
3968 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3969
5eb55db9
PE
3970 * composite.c: Don't truncate sizes to 'int'.
3971 (composition_gstring_p, composition_reseat_it)
3972 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3973 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3974 not EMACS_UINT, for indexes.
5eb55db9 3975
0703a717
PE
3976 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3977
d6202519
PE
3978 * buffer.c: Include <verify.h>.
3979 (struct sortvec.priority, struct sortstr.priority):
8961a454 3980 Now EMACS_INT, not int.
c20998a7 3981 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3982 (struct sortstr.size, record_overlay_string)
3983 (struct sortstrlist.size, struct sortlist.used):
3984 Don't truncate size to int.
3985 (record_overlay_string): Check for size-calculation overflow.
d6202519 3986 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3987
d5a19415
JM
39882011-06-22 Jim Meyering <meyering@redhat.com>
3989
029529ac 3990 Don't leak an XBM-image-sized buffer
d5a19415
JM
3991 * image.c (xbm_load): Free the image buffer after using it.
3992
a9041e6c
PE
39932011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3994
3995 Port to Sun C.
3996 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3997 that Sun C diagnosed.
3998 * fns.c (secure_hash): Fix pointer signedness issue.
3999 * intervals.c (static_offset_intervals): New function.
4000 (offset_intervals): Use it.
4001
7f3f739f
LL
40022011-06-21 Leo Liu <sdl.web@gmail.com>
4003
4004 * deps.mk (fns.o):
4005 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4006 sha512.h.
4007
4008 * fns.c (secure_hash): Rename from crypto_hash_function and change
4009 the first arg to accept symbols.
5b66d427 4010 (Fsecure_hash): New primitive.
7f3f739f
LL
4011 (syms_of_fns): New symbols.
4012
76147d94
DD
40132011-06-20 Deniz Dogan <deniz@dogan.se>
4014
4015 * process.c (Fset_process_buffer): Clarify return value in
4016 docstring.
4017
7d7d0045
CY
40182011-06-18 Chong Yidong <cyd@stupidchicken.com>
4019
4020 * dispnew.c (add_window_display_history): Use BVAR.
4021
4022 * xdisp.c (debug_method_add): Use BVAR.
4023 (check_window_end, dump_glyph_matrix, dump_glyph)
4024 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4025
4026 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4027 Likewise.
4028
4029 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4030 check till after the cache is created in init_frame_faces.
4031
ff2bc410
SM
40322011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4033
4034 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4035
28177add
PE
40362011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4037
dd3482fe
PE
4038 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4039 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4040 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4041
393d71f3 4042 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4043 * fileio.c (Finsert_file_contents):
4044 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4045 Remove the old (too-loose) buffer overflow checks.
4046 They weren't needed, since make_gap checks for buffer overflow.
4047 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4048 The old code merely checked for Emacs fixnum overflow, and relied
4049 on undefined (wraparound) behavior. The new code avoids undefined
4050 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4051
2e6813b0 4052 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4053 Tune. Don't use wider integers than needed. Don't use alloca.
4054 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4055
599a9e4f
PE
4056 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4057
99561444
PE
4058 * insdel.c, lisp.h (buffer_overflow): New function.
4059 (insert_from_buffer_1, replace_range, replace_range_2):
4060 * insdel.c (make_gap_larger):
4061 * editfns.c (Finsert_char):
4062 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4063
28177add
PE
4064 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4065
e69dafad
PE
40662011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4067
a7af7fde 4068 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4069
b1c46f02
PE
4070 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4071 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4072
e69dafad
PE
4073 * fileio.c: Don't assume EMACS_INT fits in off_t.
4074 (emacs_lseek): New static function.
4075 (Finsert_file_contents, Fwrite_region): Use it.
4076 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4077
566684ea
PE
4078 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4079
e6966cd6
PE
4080 * fns.c: Don't overflow int when computing a list length.
4081 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4082 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4083 truncation on 64-bit hosts. Check for QUIT every
4084 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4085 faster and is responsive enough.
4086 (Flength): Report an error instead of overflowing an integer.
4087 (Fsafe_length): Return a float if the value is not representable
4088 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4089 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4090 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4091
dd0b0efb
PE
4092 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4093 (header_size, word_size): New constants.
4094 (allocate_vectorlike): Don't check size overflow here.
4095 (allocate_vector): Check it here instead, since this is the only
4096 caller of allocate_vectorlike that could cause overflow.
4097 Check that the new vector's length is representable as a fixnum.
4098
86fe5cfe
PE
4099 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4100 The previous code was bogus. For example, next_almost_prime (32)
4101 returned 39, which is undesirable as it is a multiple of 3; and
4102 next_almost_prime (24) returned 25, which is a multiple of 5 so
4103 why was the code bothering to check for multiples of 7?
4104
80e88859
PE
4105 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4106
4a2f0ad6
PE
4107 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4108
f66c7cf8
PE
4109 Variadic C functions now count arguments with ptrdiff_t.
4110 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4111 Back then I didn't know that the Emacs coding style prefers signed int.
4112 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4113 were being counted with int, which may truncate counts on 64-bit
4114 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4115 * lisp.h (struct Lisp_Subr.function.aMANY)
4116 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4117 Arg counts are now ptrdiff_t, not size_t.
4118 All variadic functions and their callers changed accordingly.
4119 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4120 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4121 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4122 * callint.c (Fcall_interactively): Check arg count for overflow,
4123 to avoid potential buffer overrun. Use signed char, not 'int',
4124 for 'varies' array, so that we needn't bother to check its size
4125 calculation for overflow.
4126 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4127 * eval.c (apply_lambda):
4128 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4129 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4130 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4131
a1759b76
PE
4132 * callint.c (Fcall_interactively): Don't use index var as event count.
4133
d96be9fc
PE
4134 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4135 * mem-limits.h (SIZE): Remove; no longer used.
4136
a690a978 4137 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4138
578c21e6
PE
4139 Remove unnecessary casts.
4140 * xterm.c (x_term_init):
4141 * xfns.c (x_set_border_pixel):
4142 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4143 These aren't needed now that we assume ANSI C.
4144
96f53c6c
PE
4145 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4146 It's more likely to cause problems (due to unsigned overflow)
4147 than to cure them.
4148
83c77d31
PE
4149 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4150
ee2079f1
PE
4151 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4152
6da65536
PE
4153 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4154
7147c4a4
PE
4155 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4156
193e32d9
PE
4157 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4158
e5533da6
PE
4159 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4160
9910e595
PE
4161 GLYPH_CODE_FACE returns EMACS_INT, not int.
4162 * dispextern.h (merge_faces):
4163 * xfaces.c (merge_faces):
01103c44
PE
4164 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4165 Don't assume EMACS_INT fits in int.
9910e595 4166
2638320e
PE
4167 * character.h (CHAR_VALID_P): Remove unused parameter.
4168 * fontset.c, lisp.h, xdisp.c: All uses changed.
4169
045eb8d9
PE
4170 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4171
c1f134b5
PE
4172 * fns.c (concat): Minor tuning based on overflow analysis.
4173 This doesn't fix any bugs. Use int to hold character, instead
4174 of constantly refetching from Emacs object. Use XFASTINT, not
4175 XINT, for value known to be a character. Don't bother comparing
4176 a single byte to 0400, as it's always less.
4177
395fcb93 4178 * floatfns.c (Fexpt):
327eeec8
PE
4179 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4180
abbd3d23
PE
4181 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4182 for characters.
4183
684a03ef
PE
4184 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4185
0fed43f3
PE
4186 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4187 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4188 incorrectly succeed when S was a string, because 4294967386 was
4189 truncated before it was used.
4190
8fd02eb7
PE
4191 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4192 Otherwise, an out-of-range integer could cause undefined behavior
4193 on a 64-bit host.
4194
f8c86b69
PE
4195 * composite.c: Use int, not EMACS_INT, for characters.
4196 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4197 EMACS_INT, for values that are known to be in character range.
4198 This doesn't fix any bugs but is the usual style inside Emacs and
4199 may generate better code on 32-bit machines.
4200
34206dd2
PE
4201 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4202 This is for reasons similar to the recent CHAR_STRING fix.
4203 * charset.c (Fencode_char): Check that character arg is actually
4204 a character. Pass an int to ENCODE_CHAR.
4205 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4206 wider than 'int', as a compile-time check to prevent future regressions
4207 in this area.
4208
c5958d4c 4209 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4210
4211 Make sure a 64-bit char is never passed to CHAR_STRING.
4212 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4213 by silently ignoring the top 32 bits, allowing some values
4214 that were far too large to be valid characters.
4215 * character.h: Include <verify.h>.
4216 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4217 arguments are no wider than unsigned, as a compile-time check
4218 to prevent future regressions in this area.
4219 * data.c (Faset):
01103c44 4220 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4221 (Fsubst_char_in_region):
4222 * fns.c (concat):
4223 * xdisp.c (decode_mode_spec_coding):
4224 Adjust to CHAR_STRING's new requirement.
4225 * editfns.c (Finsert_char, Fsubst_char_in_region):
4226 * fns.c (concat): Check that character args are actually
4227 characters. Without this test, these functions did the wrong
4228 thing with wildly out-of-range values on 64-bit hosts.
4229
d37ca623
PE
4230 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4231 These casts should not be needed on 32-bit hosts, either.
4232 * keyboard.c (read_char):
4233 * lread.c (Fload): Remove casts to unsigned.
4234
ea204efb
PE
4235 * lisp.h (UNSIGNED_CMP): New macro.
4236 This fixes comparison bugs on 64-bit hosts.
4237 (ASCII_CHAR_P): Use it.
4238 * casefiddle.c (casify_object):
01103c44 4239 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4240 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4241 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4242 * dispextern.h (FACE_FROM_ID):
4243 * keyboard.c (read_char): Use UNSIGNED_CMP.
4244
41cb286c
PE
4245 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4246 not to EMACS_INT, to avoid GCC warning.
4247
4a1b9832
PE
4248 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4249
55daad71
PE
4250 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4251 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4252 isn't needed on 32-bit machines.
8f95c75c 4253
01103c44
PE
4254 * buffer.c (Fgenerate_new_buffer_name):
4255 Use EMACS_INT for count, not int.
0ceccced 4256 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4257
4258 * data.c (Qcompiled_function): Now static.
4259
c6f072e7
PE
4260 * window.c (window_body_lines): Now static.
4261
20ce5912
PE
4262 * image.c (gif_load): Rename local to avoid shadowing.
4263
9c4c5f81
PE
4264 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4265 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4266 * alloc.c (make_save_value): Integer argument is now of type
4267 ptrdiff_t, not int.
4268 (mark_object): Use ptrdiff_t, not int.
4269 * lisp.h (pD): New macro.
4270 * print.c (print_object): Use it.
4271
c0c5c8ae
PE
4272 * alloc.c: Use EMACS_INT, not int, to count objects.
4273 (total_conses, total_markers, total_symbols, total_vector_size)
4274 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4275 (total_free_floats, total_floats, total_free_intervals)
4276 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4277 Now EMACS_INT, not int. All uses changed.
4278 (Fgarbage_collect): Compute overall total using a double, so that
4279 integer overflow is less likely to be a problem. Check for overflow
4280 when converting back to an integer.
5a25e253
PE
4281 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4282 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4283 These were 'int' variables that could overflow on 64-bit hosts;
4284 they were never used, so remove them instead of repairing them.
211a0b2a 4285 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4286 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4287 Previously, this ceilinged at INT_MAX, but that doesn't work on
4288 64-bit machines.
e46bb31a 4289 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4290
c78baabf 4291 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4292 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4293 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4294 when a (possibly-narrower) signed value would do just as well.
4295 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4296
c9d624c6
PE
4297 * alloc.c: Catch some string size overflows that we were missing.
4298 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4299 for convenience in STRING_BYTES_MAX.
4300 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4301 The definition here is exact; the one in lisp.h was approximate.
4302 (allocate_string_data): Check for string overflow. This catches
4303 some instances we weren't catching before. Also, it catches
4304 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4305 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4306 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4307
c9d624c6
PE
4308 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4309 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4310 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4311
353032ce
PE
4312 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4313
2bccce07
PE
4314 * alloc.c (Fmake_string): Check for out-of-range init.
4315
0ac30604
SM
43162011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4317
4318 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4319
c195f2de
JD
43202011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4321
4322 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4323 xg_get_default_scrollbar_width.
4324
4325 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4326 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4327 (style_changed_cb): Call update_theme_scrollbar_width and call
4328 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4329 all frames (Bug#8505).
4330 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4331 Call gtk_window_set_resizable if HAVE_GTK3.
4332 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4333 and height if HAVE_GTK3 (Bug#8505).
4334 (scroll_bar_width_for_theme): New variable.
4335 (update_theme_scrollbar_width): New function.
4336 (xg_get_default_scrollbar_width): Move code to
4337 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4338 (xg_initialize): Call update_theme_scrollbar_width.
4339
4340 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4341
4342 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4343
e10ac9f1
MR
43442011-06-12 Martin Rudalics <rudalics@gmx.at>
4345
4346 * frame.c (make_frame): Call other_buffer_safely instead of
4347 other_buffer.
4348
4349 * window.c (temp_output_buffer_show): Call display_buffer with
4350 second argument Vtemp_buffer_show_specifiers and reset latter
4351 immediately after the call.
4352 (Vtemp_buffer_show_specifiers): New variable.
4353 (auto_window_vscroll_p, next_screen_context_lines)
4354 (Vscroll_preserve_screen_position): Remove leading asterisks from
4355 doc-strings.
4356
2d3c217e 43572011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4358
7b7f97e8 4359 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4360 * buffer.c (Qclone_number): Remove for now, as it's unused.
4361 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4362 (record_buffer): Remove unused local.
4363 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4364 (set_frame_buffer_list): Remove; unused.
4365 * frame.h (other_visible_frames): Remove decl.
4366 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4367 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4368 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4369 if HAVE_GPM.
4370 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4371 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4372 Define only if HAVE_GPM.
4373 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4374 (update_hints_inhibit): Remove; never set. All uses removed.
4375 * widgetprv.h (emacsFrameClassRec): Remove decl.
4376 * window.c (delete_deletable_window): Now returns void, since it
4377 wasn't returning anything.
4378 (compare_window_configurations): Remove unused locals.
4379 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4380 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4381 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4382 the same widths as pointers. This follows up on the 2011-05-06 patch.
4383 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4384 * xterm.h: Likewise.
4385 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4386
1384b89e
JB
43872011-06-12 Juanma Barranquero <lekktu@gmail.com>
4388
4389 * makefile.w32-in: Update dependencies.
4390 (LISP_H): Add lib/intprops.h.
4391
1100a63c
CY
43922011-06-11 Chong Yidong <cyd@stupidchicken.com>
4393
4394 * image.c (gif_load): Add animation frame delay to the metadata.
4395 (syms_of_image): Use DEFSYM. New symbol `delay'.
4396
6198ccd0
MR
43972011-06-11 Martin Rudalics <rudalics@gmx.at>
4398
4399 * window.c (delete_deletable_window): Re-add.
4400 (Fset_window_configuration): Rewrite to handle dead buffers and
4401 consequently deletable windows.
4402 (window_tree, Fwindow_tree): Remove. Supply functionality in
4403 window.el.
4404 (compare_window_configurations): Simplify code.
4405
b6e3633c
AS
44062011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4407
1ab0dee5
AS
4408 * image.c (imagemagick_load_image): Fix type mismatch.
4409 (Fimagemagick_types): Likewise.
4410
b6e3633c
AS
4411 * window.h (replace_buffer_in_windows): Declare.
4412
9397e56f
MR
44132011-06-11 Martin Rudalics <rudalics@gmx.at>
4414
4415 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4416 Qclone_number. Remove external declaration of Qdelete_window.
4417 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4418 code.
640c8776
SM
4419 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4420 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4421 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4422 buffer list implementation.
4423 (other_buffer_safely): New function.
4424 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4425 calls to replace_buffer_in_windows and
4426 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4427 if allowed.
4428 (record_buffer): Inhibit quitting and rewrite using quittable
4429 functions. Run Qbuffer_list_update_hook if allowed.
4430 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4431 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4432 Move switch-to-buffer to window.el.
9397e56f
MR
4433 (bury-buffer): Move to window.el.
4434 (Vbuffer_list_update_hook): New variable.
4435
4436 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4437 section.
4438
4439 * window.h (resize_frame_windows): Move up in code.
4440 (Fwindow_frame): Remove EXFUN.
4441 (replace_buffer_in_all_windows): Remove prototype.
4442 (replace_buffer_in_windows_safely): Add prototype.
4443
4444 * window.c: Declare Qdelete_window static again. Move down
4445 declaration of select_count.
4446 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4447 (Fother_window): Move to window.el.
4448 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4449 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4450 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4451 window.el.
4452 (replace_buffer_in_windows): Implement by calling
4453 Qreplace_buffer_in_windows.
4454 (replace_buffer_in_all_windows): Remove with some functionality
4455 moved into replace_buffer_in_windows_safely.
4456 (replace_buffer_in_windows_safely): New function.
4457 (select_window_norecord, select_frame_norecord): Move in front
4458 of run_window_configuration_change_hook. Remove now obsolete
4459 declarations.
640c8776
SM
4460 (Fset_window_buffer): Rewrite doc-string.
4461 Call Qrecord_window_buffer.
9397e56f
MR
4462 (keys_of_window): Move binding for other-window to window.el.
4463
b50691aa
CY
44642011-06-11 Chong Yidong <cyd@stupidchicken.com>
4465
4466 * dispextern.h (struct image): Replace data member, whose int_val
4467 and ptr_val fields were not used by anything, with a single
4468 lisp_val object.
4469
4470 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4471 (gif_clear_image, gif_load, imagemagick_load_image)
4472 (gs_clear_image, gs_load): Callers changed.
4473
3f754b86
PE
44742011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4475
cca69397
PE
4476 * buffer.h: Include <time.h>, for time_t.
4477 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4478
109e28d0
PE
4479 Fix minor problems found by static checking.
4480
60737f02
PE
4481 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4482
4b66faf3
PE
4483 Make identifiers static if they are not used in other modules.
4484 * data.c (Qcompiled_function, Qframe, Qvector):
4485 * image.c (QimageMagick, Qsvg):
4486 * minibuf.c (Qmetadata):
4487 * window.c (resize_window_check, resize_root_window): Now static.
4488 * window.h (resize_window_check, resize_root_window): Remove decls.
4489
109e28d0
PE
4490 * window.c (window_deletion_count, delete_deletable_window):
4491 Remove; unused.
46a4ce9e
PE
4492 (window_body_lines): Now static.
4493 (Fdelete_other_windows_internal): Mark vars as initialized.
4494 Make sure 'resize_failed' is initialized.
4495 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4496 (resize_window_apply): Remove unused local.
4497 * window.h (delete_deletable_window): Remove decl.
4498
109e28d0 4499 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4500 (imagemagick_load_image): Fix pointer signedness problem by changing
4501 last arg from unsigned char * to char *. All uses changed.
4502 Also, fix a local for similar reasons.
4503 Remove unused locals. Remove locals to avoid shadowing.
4504 (fn_rsvg_handle_free): Remove; unused.
4505 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4506 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4507
3f754b86
PE
4508 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4509
2547adb1
CY
45102011-06-10 Chong Yidong <cyd@stupidchicken.com>
4511
4512 * image.c (gif_load): Fix omitted cast error introduced by
4513 2011-06-06 change.
4514
2c8e37d4
MR
45152011-06-10 Martin Rudalics <rudalics@gmx.at>
4516
4517 * window.h (resize_proportionally, orig_total_lines)
4518 (orig_top_line): Remove from window structure.
4519 (set_window_height, set_window_width, change_window_heights)
4520 (Fdelete_window): Remove prototypes.
4521 (resize_frame_windows): Remove duplicate declaration.
4522
440a42e3
EZ
45232011-06-10 Eli Zaretskii <eliz@gnu.org>
4524
4525 * window.h (resize_frame_windows, resize_window_check)
4526 (delete_deletable_window, resize_root_window)
4527 (resize_frame_windows): Declare prototypes.
4528
4529 * window.c (resize_window_apply): Make definition be "static" to
4530 match the prototype.
4531
562dd5e9
MR
45322011-06-10 Martin Rudalics <rudalics@gmx.at>
4533
4534 * window.c: Remove declarations of Qwindow_size_fixed,
4535 window_min_size_1, window_min_size_2, window_min_size,
4536 size_window, window_fixed_size_p, enlarge_window, delete_window.
4537 Remove static from declaration of Qdelete_window, it's
4538 temporarily needed by Fbury_buffer.
4539 (replace_window): Don't assign orig_top_line and
4540 orig_total_lines.
4541 (Fdelete_window, delete_window): Remove. Window deletion is
4542 handled by window.el.
640c8776
SM
4543 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4544 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4545 (Fdelete_other_windows): Remove. Deleting other windows is
4546 handled by window.el.
4547 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4548 handled in window.el.
4549 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4550 Window minimum sizes are handled in window.el.
4551 (shrink_windows, size_window, set_window_height)
4552 (set_window_width, change_window_heights, window_height)
4553 (window_width, CURBEG, CURSIZE, enlarge_window)
4554 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4555 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4556 handled in window.el.
4557 (make_dummy_parent): Rename to make_parent_window and give it a
4558 second argument horflag.
4559 (make_window): Don't set resize_proportionally any more.
4560 (Fsplit_window): Remove. Windows are split in window.el.
4561 (save_restore_action, save_restore_orig_size)
4562 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4563 Resize mini windows in window.el.
4564 (grow_mini_window, shrink_mini_window): Implement by calling
4565 Qresize_root_window_vertically, resize_window_check and
4566 resize_window_apply.
640c8776
SM
4567 (saved_window, Fset_window_configuration, save_window_save):
4568 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4569 resize_proportionally.
4570 (window_min_height, window_min_width): Move to window.el.
4571 (keys_of_window): Move bindings for delete-other-windows,
4572 split-window, delete-window and enlarge-window to window.el.
4573
4574 * buffer.c: Temporarily extern Qdelete_window.
4575 (Fbury_buffer): Temporarily call Qdelete_window instead of
4576 Fdelete_window (Fbury_buffer will move to window.el soon).
4577
4578 * frame.c (set_menu_bar_lines_1): Remove code handling
4579 orig_top_line and orig_total_lines.
4580
4581 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4582 set_window_height but set heights directly.
4583 (change_frame_size_1): Use resize_frame_windows.
4584
4585 * xdisp.c (init_xdisp): Don't use set_window_height but set
4586 heights directly.
4587
640c8776
SM
4588 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4589 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4590 run_window_configuration_change_hook.
4591
4592 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4593 instead of change_window_heights and run
4594 run_window_configuration_change_hook.
4595
1a13852e
MR
45962011-06-09 Martin Rudalics <rudalics@gmx.at>
4597
4598 * window.c (replace_window): Rename second argument REPLACEMENT to
4599 NEW. New third argument SETFLAG. Rewrite.
4600 (delete_window, make_dummy_parent): Call replace_window with
4601 third argument 1.
4602 (window_list_1): Move down in code.
4603 (run_window_configuration_change_hook): Move set_buffer part
4604 before select_frame_norecord part in order to unwind correctly.
4605 Rename count1 to count.
4606 (recombine_windows, delete_deletable_window, resize_root_window)
4607 (Fdelete_other_windows_internal)
4608 (Frun_window_configuration_change_hook, make_parent_window)
4609 (resize_window_check, resize_window_apply, Fresize_window_apply)
4610 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4611 (Fdelete_window_internal, Fresize_mini_window_internal):
4612 New functions.
1a13852e
MR
4613 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4614
f3d1777e
MR
46152011-06-08 Martin Rudalics <rudalics@gmx.at>
4616
496e208e
MR
4617 * window.h (window): Add some new members to window structure -
4618 normal_lines, normal_cols, new_total, new_normal, clone_number,
4619 splits, nest, prev_buffers, next_buffers.
4620 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4621 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4622
f3d1777e
MR
4623 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4624 Remove.
496e208e
MR
4625 (make_dummy_parent): Set new members of windows structure.
4626 (make_window): Move down in code. Handle new members of window
4627 structure.
4628 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4629 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4630 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4631 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4632 (Fset_window_next_buffers, Fset_window_clone_number):
4633 New functions.
496e208e
MR
4634 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4635 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4636 Doc-string fixes.
4637 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4638 Argument WINDOW can be now internal window too.
4639 (Fwindow_use_time): Move up in code.
4640 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4641 Rewrite doc-string.
4642 (Fset_window_configuration, saved_window)
4643 (Fcurrent_window_configuration, save_window_save): Handle new
4644 members of window structure.
b9e809c2
MR
4645 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4646 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4647 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4648 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4649 Qget_mru_window, Qresize_root_window,
4650 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4651 Qauto_buffer_name; staticpro them.
f3d1777e 4652
abde8f8c
MR
46532011-06-07 Martin Rudalics <rudalics@gmx.at>
4654
4655 * window.c (Fwindow_total_size, Fwindow_left_column)
4656 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4657 (Fwindow_list_1): New functions.
4658 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4659 (Fwindow_width, Fscroll_left, Fscroll_right):
4660 Use window_body_cols instead of window_box_text_cols.
4661 (delete_window, Fset_window_configuration):
4662 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4663 (delete_all_subwindows): Take a window as argument and not a
4664 structure. Rewrite.
190b47e6
MR
4665 (window_loop): Remove handling of GET_LRU_WINDOW and
4666 GET_LARGEST_WINDOW.
4667 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4668
4669 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4670 window_box_text_cols. delete_all_subwindows now takes a
4671 Lisp_Object as argument.
abde8f8c 4672
640c8776
SM
4673 * indent.c (compute_motion, Fcompute_motion):
4674 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4675
fa8a67e6
MR
4676 * frame.c (delete_frame): Call delete_all_subwindows with root
4677 window as argument.
4678
a54e3482
DC
46792011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4680
4681 * fns.c (Fputhash): Document return value.
4682
60002bf5
CY
46832011-06-06 Chong Yidong <cyd@stupidchicken.com>
4684
4685 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4686
0c671da6 46872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4688
b862a52a 4689 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4690
be44ca6c
PE
4691 Check for overflow when converting integer to cons and back.
4692 * charset.c (Fdefine_charset_internal, Fdecode_char):
4693 Use cons_to_unsigned to catch overflow.
4694 (Fencode_char): Use INTEGER_TO_CONS.
4695 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4696 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4697 * data.c (long_to_cons, cons_to_long): Remove.
4698 (cons_to_unsigned, cons_to_signed): New functions.
4699 These signal an error for invalid or out-of-range values.
4700 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4701 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4702 * font.c (Ffont_variation_glyphs):
4703 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4704 * lisp.h: Include <intprops.h>.
4705 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4706 (cons_to_signed, cons_to_unsigned): New decls.
4707 (long_to_cons, cons_to_long): Remove decls.
4708 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4709 (Fprimitive_undo): Use CONS_TO_INTEGER.
4710 * xfns.c (Fx_window_property): Likewise.
4711 * xselect.c: Include <limits.h>.
4712 (x_own_selection, selection_data_to_lisp_data):
4713 Use INTEGER_TO_CONS.
4714 (x_handle_selection_request, x_handle_selection_clear)
4715 (x_get_foreign_selection, Fx_disown_selection_internal)
4716 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4717 (lisp_data_to_selection_data): Use cons_to_unsigned.
4718 (x_fill_property_data): Use cons_to_signed.
4719 Report values out of range.
4720
d1f3d2af
PE
4721 Check for buffer and string overflow more precisely.
4722 * buffer.h (BUF_BYTES_MAX): New macro.
4723 * lisp.h (STRING_BYTES_MAX): New macro.
4724 * alloc.c (Fmake_string):
4725 * character.c (string_escape_byte8):
4726 * coding.c (coding_alloc_by_realloc):
4727 * doprnt.c (doprnt):
4728 * editfns.c (Fformat):
4729 * eval.c (verror):
4730 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4731 since they may not be the same number.
4732 * editfns.c (Finsert_char):
4733 * fileio.c (Finsert_file_contents):
4734 Likewise for BUF_BYTES_MAX.
4735
dd52fcea
PE
4736 * image.c: Use ptrdiff_t, not int, for sizes.
4737 (slurp_file): Switch from int to ptrdiff_t.
4738 All uses changed.
4739 (slurp_file): Check that file size fits in both size_t (for
4740 malloc) and ptrdiff_t (for sanity and safety).
4741
7f9bbdbb
PE
4742 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4743 if b->modtime has its maximal value.
4744
dfe18f82
PE
4745 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4746
84acfcf0
PE
4747 Don't assume time_t can fit into int.
4748 * buffer.h (struct buffer.modtime): Now time_t, not int.
4749 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4750 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4751
ccd9a01a
PE
4752 Minor fixes for signed vs unsigned integers.
4753 * character.h (MAYBE_UNIFY_CHAR):
4754 * charset.c (maybe_unify_char):
4755 * keyboard.c (read_char, reorder_modifiers):
4756 XINT -> XFASTINT, since the integer must be nonnegative.
4757 * ftfont.c (ftfont_spec_pattern):
4758 * keymap.c (access_keymap, silly_event_symbol_error):
4759 XUINT -> XFASTINT, since the integer must be nonnegative.
4760 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4761 since it makes no difference and we prefer signed.
4762 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4763 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4764 nonnegative.
4765
d6d100dd
SM
47662011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4767
4768 * window.h (Fwindow_frame): Declare.
4769
2b6148e4
PE
47702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4771
4772 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4773 (SPARE_MEMORY): Always define.
4774 (LARGE_REQUEST): Remove.
4775 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4776
f230ecc9
MR
47772011-06-06 Martin Rudalics <rudalics@gmx.at>
4778
727e958e
MR
4779 * lisp.h: Move EXFUNS for Fframe_root_window,
4780 Fframe_first_window and Fset_frame_selected_window to window.h.
4781
4782 * window.h: Move EXFUNS for Fframe_root_window,
4783 Fframe_first_window and Fset_frame_selected_window here from
4784 lisp.h.
4785
4786 * frame.c (Fwindow_frame, Fframe_first_window)
4787 (Fframe_root_window, Fframe_selected_window)
4788 (Fset_frame_selected_window): Move to window.c.
4789 (Factive_minibuffer_window): Move to minibuf.c.
4790 (Fother_visible_frames_p): New function.
4791
4792 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4793
f230ecc9
MR
4794 * window.c (decode_window, decode_any_window): Move up in code.
4795 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4796 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4797 (Fwindow_buffer): Move up and rewrite doc-string.
4798 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4799 (Fwindow_prev): New functions.
727e958e
MR
4800 (Fwindow_frame): Move here from frame.c. Accept any window as
4801 argument.
4802 (Fframe_root_window, Fframe_first_window)
4803 (Fframe_selected_window): Move here from frame.c. Accept frame
4804 or arbitrary window as argument. Update doc-strings.
4805 (Fminibuffer_window): Move up in code.
4806 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4807 (Fset_frame_selected_window): Move here from frame.c.
4808 Marginal rewrite.
727e958e
MR
4809 (Fselected_window, select_window, Fselect_window): Move up in
4810 code. Minor doc-string fixes.
f230ecc9 4811
4d09bcf6
PE
48122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4813
4814 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4815 Do not assume that spare memory exists; that assumption is valid
4816 only if SYSTEM_MALLOC.
4817 (LARGE_REQUEST): New macro, so that the issue of large requests
4818 is separated from the issue of spare memory.
4819
810928a2
AS
48202011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4821
172418ad
AS
4822 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4823 format. (Bug#8806)
4824
43f862f7
AS
4825 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4826
810928a2
AS
4827 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4828 before statements.
4829
a059fe24
JD
48302011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4831
4832 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4833
4834 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4835
4836 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4837 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4838
989bf368
JB
48392011-06-05 Juanma Barranquero <lekktu@gmail.com>
4840
4841 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4842
4b80f674
CY
48432011-06-04 Chong Yidong <cyd@stupidchicken.com>
4844
4845 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4846 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4847 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4848 New error handlers.
4b80f674
CY
4849 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4850 Obey Vx_select_enable_clipboard_manager. Catch errors in
4851 x_clipboard_manager_save (Bug#8779).
4852 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4853 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4854
99a33b77 48552011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4856
4857 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4858
99a33b77 48592011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4860
4861 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4862 in the current matrix if keep_current_p is non-zero.
4863
8264569d
EZ
48642011-06-04 Eli Zaretskii <eliz@gnu.org>
4865
4866 * bidi.c (bidi_level_of_next_char): Fix last change.
4867
57f97249
EZ
48682011-06-03 Eli Zaretskii <eliz@gnu.org>
4869
fec2107c 4870 Support bidi reordering of text covered by display properties.
57f97249 4871
fec2107c
EZ
4872 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4873 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4874 (bidi_cache_search, bidi_cache_iterator_state)
4875 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4876 (bidi_level_of_next_char, bidi_move_to_visually_next):
4877 Support character positions inside a run of characters covered by a
fec2107c
EZ
4878 display string.
4879 (bidi_paragraph_init, bidi_resolve_explicit_1)
4880 (bidi_level_of_next_char): Call bidi_fetch_char and
4881 bidi_fetch_char_advance instead of FETCH_CHAR and
4882 FETCH_CHAR_ADVANCE.
4883 (bidi_init_it): Initialize new members.
4884 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4885 definitions.
4886 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4887 instead of using explicit *_CHAR codes.
d6d100dd
SM
4888 (bidi_resolve_explicit, bidi_resolve_weak):
4889 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4890 bidirectional text is supported only in multibyte buffers.
4891 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4892 it to initialize the frame_window_p member of struct bidi_it.
4893 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4894 (bidi_resolve_explicit, bidi_resolve_weak)
4895 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4896 bidi_it->nchars is non-positive.
4897 (bidi_level_of_next_char): Don't try to lookup the cache for the
4898 next/previous character if nothing is cached there yet, or if we
4899 were just reseat()'ed to a new position.
c40e2fb2 4900
0e14fe90
EZ
4901 * xdisp.c (set_cursor_from_row): Set start and stop points
4902 according to the row's direction when priming the loop that looks
4903 for the glyph on which to display cursor.
4904 (single_display_spec_intangible_p): Function deleted.
4905 (display_prop_intangible_p): Reimplement to call
4906 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4907 Accept 3 additional arguments needed by handle_display_spec.
4908 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4909 values: lists, `(when COND...)' forms, etc.
4910 (single_display_spec_string_p): Support property values that are
4911 lists with the argument STRING its top-level element.
4912 (display_prop_string_p): Fix the condition for processing a
4913 property that is a list to be consistent with handle_display_spec.
fec2107c 4914 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4915 last portion of handle_display_prop.
4916 (compute_display_string_pos): Accept additional argument
4917 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4918 value of a `display' property is a "replacing spec".
4919 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4920 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4921 the display property, but just return a value indicating whether
4922 the display property will replace the characters it covers.
4923 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4924 frame_window_p members of struct bidi_it.
d6d100dd
SM
4925 (compute_display_string_pos, compute_display_string_end):
4926 New functions.
fec2107c
EZ
4927 (push_it): Accept second argument POSITION, where pop_it should
4928 jump to continue iteration.
4929 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4930
fec2107c
EZ
4931 * keyboard.c (adjust_point_for_property): Adjust the call to
4932 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4933
4934 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4935 (bidi_init_it): Update prototypes.
4936 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4937 (compute_display_string_pos, compute_display_string_end):
4938 Declare prototypes.
fec2107c
EZ
4939 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4940 EMACS_INT.
fc6f18ce 4941
40087514 49422011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4943
57f53182
PE
4944 Malloc failure behavior now depends on size of allocation.
4945 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4946 * lisp.h: Change signatures accordingly.
4947 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4948 All callers changed. (Bug#8762)
4949
4950 * gnutls.c: Use Emacs's memory allocators.
4951 Without this change, the gnutls library would invoke malloc etc.
4952 directly, which causes problems on non-SYNC_INPUT hosts, and which
4953 runs afoul of improving memory_full behavior. (Bug#8761)
4954 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4955 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4956 xfree instead of the default malloc, realloc, free.
4957 (Fgnutls_boot): No need to check for memory allocation failure,
4958 since xmalloc does that for us.
4959
ac32cd99 4960 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4961 * category.c (hash_get_category_set):
4962 * ccl.c (ccl_driver):
4963 * charset.c (Fdefine_charset_internal):
4964 * charset.h (struct charset.hash_index):
4965 * composite.c (get_composition_id, gstring_lookup_cache)
4966 (composition_gstring_put_cache):
4967 * composite.h (struct composition.hash_index):
4968 * dispextern.h (struct image.hash):
4969 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4970 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4971 (hashfn_equal, hashfn_user_defined, make_hash_table)
4972 (maybe_resize_hash_table, hash_lookup, hash_put)
4973 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4974 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4975 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4976 * image.c (make_image, search_image_cache, lookup_image)
4977 (xpm_put_color_table_h):
4978 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4979 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4980 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4981 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4982 * alloc.c (allocate_vectorlike):
4983 Check for overflow in vector size calculations.
4984 * ccl.c (ccl_driver):
4985 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4986 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4987 need to be updated by these changes.
40087514
PE
4988 * fns.c (make_hash_table, maybe_resize_hash_table):
4989 Check for integer overflow with large hash tables.
0de4bb68
PE
4990 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4991 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4992 (SXHASH_REDUCE): New macro.
4993 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4994 Use it instead of discarding useful hash info with large hash values.
4995 (sxhash_float): New function.
4996 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4997 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4998 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4999 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5000 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5001 Adjust signatures to match updated version of code.
5002 (consing_since_gc): Now EMACS_INT, since a single hash table can
5003 use more than INT_MAX bytes.
5004
698d32e2
DN
50052011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5006
5007 Make it possible to build with GCC-4.6+ -O2 -flto.
5008
5009 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5010
fd6fa53f
SM
50112011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5012
5013 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5014 Call minibuffer-inactive-mode.
5015
864db017
JB
50162011-05-31 Juanma Barranquero <lekktu@gmail.com>
5017
5018 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5019 Update dependencies.
5020
2ad0baf4
DN
50212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5022
5023 * data.c (init_data): Remove code for UTS, this system is not
5024 supported anymore.
5025
4fcc2638
DN
50262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5027
5028 Don't force ./temacs to start in terminal mode.
5029
5030 * frame.c (make_initial_frame): Initialize faces in all cases, not
5031 only when CANNOT_DUMP is defined.
5032 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5033
c56e0fd5
DN
50342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5035
5036 * dispnew.c (add_window_display_history): Use const for the string
5037 pointer. Remove declaration, not needed.
5038
333d54da 50392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5040
55d4c1b2 5041 Use 'inline', not 'INLINE'.
333d54da 5042 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5043 * alloc.c, fontset.c (INLINE): Remove.
5044 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5045 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5046 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5047 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5048 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5049
738db178
DN
50502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5051
5052 Make it possible to run ./temacs.
5053
5054 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5055 syms_of_callproc does the same thing. Remove test for
5056 "initialized", do it in the caller.
5057 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5058
620c53a6
SM
50592011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5060
5061 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5062 (read_minibuf): Use get_minibuffer.
5063 (syms_of_minibuf): Use DEFSYM.
5064 (Qmetadata): New var.
5065 * data.c (Qbuffer): Don't make it static.
5066 (syms_of_data): Use DEFSYM.
5067
e003a292
PE
50682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5069
5070 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5071 (CCL_CODE_MIN): New macro.
5072
ed008a6d
PE
50732011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5074
3687c2ef
PE
5075 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5076
ed008a6d
PE
5077 * eval.c (Qdebug): Now static.
5078 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5079 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5080 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5081
d66c4c7c
CY
50822011-05-29 Chong Yidong <cyd@stupidchicken.com>
5083
5084 * image.c: Various fixes to ImageMagick code comments.
5085 (Fimagemagick_types): Doc fix.
5086
5fbc2025
PE
50872011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5088
0196f88a
PE
5089 Minor fixes prompted by GCC 4.6.0 warnings.
5090
5091 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5092
5fbc2025
PE
5093 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5094 (x_clipboard_manager_save_all): Move extern decl to ...
5095 * xterm.h: ... here, so that it can be checked for consistency.
5096
1dd3c2d9
CY
50972011-05-29 Chong Yidong <cyd@stupidchicken.com>
5098
5099 * xselect.c (x_clipboard_manager_save_frame)
5100 (x_clipboard_manager_save_all): New functions.
5101 (Fx_clipboard_manager_save): Lisp function deleted.
5102
5103 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5104 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5105
5106 * xterm.h: Update prototype.
5107
5ba6571d
WX
51082011-05-28 William Xu <william.xwl@gmail.com>
5109
5110 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5111 exiting (Bug#8239).
5112
3eaff834
JM
51132011-05-28 Jim Meyering <meyering@redhat.com>
5114
e1900994 5115 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5116 * fns.c (to_uchar): Define.
5117 (crypto_hash_function): Use it to convert some newly-signed
5118 variables to unsigned, to avoid sign-extension bugs. For example,
5119 without this change, (md5 "truc") would evaluate to
5120 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5121 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5122 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5123
0f6990a7
PE
51242011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5125
5126 Integer overflow fixes.
c8a9ca5a 5127
08686060
PE
5128 * dbusbind.c: Serial number integer overflow fixes.
5129 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5130 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5131 to hold a serial number that is too large for a fixnum.
5132 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5133 Check for serial numbers out of range. Decode any serial number
59568bf0 5134 that was so large that it became a float. (Bug#8722)
08686060 5135
2d1fc3c7
PE
5136 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5137 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5138 Use XFASTINT rather than XUINT when numbers are nonnegative.
5139 (xd_append_arg, Fdbus_method_return_internal):
5140 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5141 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5142 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5143 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5144 (Bug#8722)
2d1fc3c7 5145
c8a9ca5a
PE
5146 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5147
519e1d69
PE
5148 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5149
30569699
PE
5150 ccl: add integer overflow checks
5151 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5152 (IN_INT_RANGE): New macros.
5153 (ccl_driver): Use them to check for integer overflow when
5154 decoding a CCL program. Many of the new checks are whether XINT (x)
5155 fits in int; it doesn't always, on 64-bit hosts. The new version
5156 doesn't catch all possible integer overflows, but it's an
847044ea 5157 improvement. (Bug#8719)
30569699 5158
c11285dc
PE
5159 * alloc.c (make_event_array): Use XINT, not XUINT.
5160 There's no need for unsigned here.
5161
fdccd48e
PE
5162 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5163 This follows up to the 2011-05-06 change that substituted uintptr_t
5164 for EMACS_INT. This case wasn't caught back then.
5165
37910ab2
PE
5166 Rework Fformat to avoid integer overflow issues.
5167 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5168 now (part of C89). Include <verify.h>.
5169 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5170 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5171 (Fformat): Avoid the prepass trying to compute sizes; it was only
5172 approximate and thus did not catch overflow reliably. Instead, walk
5173 through the format just once, formatting and computing sizes as we go,
5174 checking for integer overflow at every step, and allocating a larger
5175 buffer as needed. Keep track separately whether the format is
5176 multibyte. Keep only the most-recently calculated precision, rather
5177 than them all. Record whether each argument has been converted to
5178 string. Use EMACS_INT, not int, for byte and char and arg counts.
5179 Support field widths and precisions larger than INT_MAX. Avoid
5180 sprintf's undefined behavior with conversion specifications such as %#d
5181 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5182 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5183 formatting out-of-range floating point numbers with int
9173deec 5184 formats. (Bug#8668)
37910ab2 5185
2e6578fb
PE
5186 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5187
0ae6bdee
PE
5188 * data.c: Avoid integer truncation in expressions involving floats.
5189 * data.c: Include <intprops.h>.
5190 (arith_driver): When there's an integer overflow in an expression
5191 involving floating point, convert the integers to floating point
5192 so that the resulting value does not suffer from catastrophic
5193 integer truncation. For example, on a 64-bit host (* 4
5194 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5195 Do not rely on undefined behavior after integer overflow.
5196
de883a70
PE
5197 merge count_size_as_multibyte, parse_str_to_multibyte
5198 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5199 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5200 Check for integer overflow.
5201 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5202 since it's now a duplicate of the other. This is more of
5203 a character than a buffer op, so better that it's in character.c.
5204 * fns.c, print.c: Adjust to above changes.
5205
2ff916cb
PE
52062011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5207
5208 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5209
f1b54466
PE
52102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5211
fb1ac845
PE
5212 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5213 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5214 (x_clipboard_manager_save): Now static.
5215 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5216
f1b54466
PE
5217 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5218 (crypto_hash_function): Now static.
5219 Fix pointer signedness problems. Avoid unnecessary initializations.
5220
a9f737ee
CY
52212011-05-27 Chong Yidong <cyd@stupidchicken.com>
5222
5223 * termhooks.h (Vselection_alist): Make it terminal-local.
5224
5225 * terminal.c (create_terminal): Initialize it.
5226
5227 * xselect.c: Support for clipboard managers.
5228 (Vselection_alist): Move to termhooks.h as terminal-local var.
5229 (LOCAL_SELECTION): New macro.
5230 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5231 (symbol_to_x_atom): Remove gratuitous arg.
5232 (x_handle_selection_request, lisp_data_to_selection_data)
5233 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5234 (x_own_selection, x_get_local_selection, x_convert_selection):
5235 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5236 (some_frame_on_display): Delete unused function.
5237 (Fx_own_selection_internal, Fx_get_selection_internal)
5238 (Fx_disown_selection_internal, Fx_selection_owner_p)
5239 (Fx_selection_exists_p): New optional frame arg.
5240 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5241 (x_handle_selection_clear): Don't treat other terminals with the
5242 same keyboard specially. Use the terminal-local Vselection_alist.
5243 (x_clear_frame_selections): Use Frun_hook_with_args.
5244
5245 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5246
5247 * xterm.h: Add support for those atoms.
5248
e067f0c1
CY
52492011-05-26 Chong Yidong <cyd@stupidchicken.com>
5250
5251 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5252 (converted_selections, conversion_fail_tag): New global variables.
5253 (x_selection_request_lisp_error): Free the above.
5254 (x_get_local_selection): Remove unnecessary code.
5255 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5256 of converted selections stored in converted_selections.
5257 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5258 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5259 (x_convert_selection): New function.
5260 (x_handle_selection_event): Simplify.
5261 (x_get_foreign_selection): Don't ignore incoming requests while
5262 waiting for an answer; this will fail when we implement
5263 SAVE_TARGETS, and seems unnecessary anyway.
5264 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5265 (Vx_sent_selection_functions): Doc fix.
5266
0f4aebc0
LL
52672011-05-26 Leo Liu <sdl.web@gmail.com>
5268
5269 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5270
e61124cd
YM
52712011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5272
5273 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5274
5275 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5276 for fringe update if it has periodic bitmap.
ac389d0c 5277 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5278 and fringe_bitmap_periodic_p.
5279
5280 * fringe.c (get_fringe_bitmap_data): New function.
5281 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5282 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5283 row. Mark glyph row for fringe update if periodicity changed.
5284
5285 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5286 for fringe update unless it has periodic bitmap.
5287
f16d9837
KH
52882011-05-25 Kenichi Handa <handa@m17n.org>
5289
5290 * xdisp.c (get_next_display_element): Set correct it->face_id for
5291 a static composition.
5292
e1b90ef6
LL
52932011-05-24 Leo Liu <sdl.web@gmail.com>
5294
5295 * deps.mk (fns.o):
5296 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5297
5298 * fns.c (crypto_hash_function, Fsha1): New function.
5299 (Fmd5): Use crypto_hash_function.
5300 (syms_of_fns): Add Ssha1.
5301
7400048f
PE
53022011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5303
5304 * gnutls.c: Remove unused macros.
5305 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5306 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5307 Remove macros that are defined and never used.
5308 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5309
abb71cf4
CY
53102011-05-22 Chong Yidong <cyd@stupidchicken.com>
5311
5312 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5313 (Fx_get_selection_internal): Minor cleanup.
5314 (Fx_own_selection_internal): Rename arguments for consistency with
5315 select.el.
5316
6307db39
PE
53172011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5318
5319 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5320
f3d4e0a4
CY
53212011-05-22 Chong Yidong <cyd@stupidchicken.com>
5322
5323 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5324
4d8ade89
YM
53252011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5326
5327 * dispnew.c (scrolling_window): Don't exclude the case that the
5328 last enabled row in the desired matrix touches the bottom boundary.
5329
32078c8d
GM
53302011-05-21 Glenn Morris <rgm@gnu.org>
5331
5332 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5333 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5334 and add some more files.
32078c8d 5335
7285dc67
EZ
53362011-05-20 Eli Zaretskii <eliz@gnu.org>
5337
5338 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5339 report_file_error introduced by the change from 2011-05-07.
5340
89d1bd22
PE
53412011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5342
5343 * systime.h (Time): Define only if emacs is defined.
5344 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5345 where the include path doesn't have X11/X.h by default. See
5346 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5347
e23640bb 53482011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5349
5350 * composite.c (find_automatic_composition): Fix previous change.
5351
b9704ad9
GM
53522011-05-20 Glenn Morris <rgm@gnu.org>
5353
5354 * lisp.mk: New file, split from Makefile.in.
5355 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5356 (shortlisp): Remove.
5357 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5358
4a720484
GM
53592011-05-19 Glenn Morris <rgm@gnu.org>
5360
5361 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5362 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5363 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5364 (lisp): Set the order to that of loadup.el.
5365 (shortlisp): Make it a copy of $lisp.
5366 (SOME_MACHINE_LISP): Remove.
5367 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5368 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5369
a28d4396
KH
53702011-05-18 Kenichi Handa <handa@m17n.org>
5371
5372 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5373 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5374 (find_automatic_composition): Mostly rewrite for efficiency.
5375
a2b1fa8e
JB
53762011-05-18 Juanma Barranquero <lekktu@gmail.com>
5377
5378 * makefile.w32-in: Update dependencies.
5379
8e1f5610
CS
53802011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5381
5382 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5383 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5384
7025ee00 53852011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5386
cdfa6eab
PE
5387 Fix some integer overflow issues, such as string length overflow.
5388
06d6db33
PE
5389 * insdel.c (count_size_as_multibyte): Check for string overflow.
5390
2b4560a8
PE
5391 * character.c (lisp_string_width): Check for string overflow.
5392 Use EMACS_INT, not int, for string indexes and lengths; in
5393 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5394 the resulting string length overflows an EMACS_INT; instead,
5395 report a string overflow if no precision given. When checking for
5396 precision exhaustion, use a check that cannot possibly have
5397 integer overflow. (Bug#8675)
5398 * character.h (lisp_string_width): Adjust to new signature.
5399
cb93f9be
PE
5400 * alloc.c (string_overflow): New function.
5401 (Fmake_string): Use it. This doesn't change behavior, but saves
5402 a few bytes and will simplify future changes.
5403 * character.c (string_escape_byte8): Likewise.
5404 * lisp.h (string_overflow): New decl.
5405
1a1f3366
PE
5406 Fixups, following up to the user-interface timestamp change.
5407 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5408 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5409 * msdos.c (mouse_get_pos): Likewise.
5410 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5411 * w32gui.h (Time): Define by including "systime.h" rather than by
5412 declaring it ourselves. (Bug#8664)
5413
d4e3e4d3
PE
5414 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5415 * image.c (clear_image_cache): Likewise.
5416
f6a24d19
PE
5417 * term.c (term_mouse_position): Don't assume time_t wraparound.
5418
08dc5ae6
PE
5419 Be more systematic about user-interface timestamps.
5420 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5421 and sometimes 'EMACS_UINT', to represent these timestamps.
5422 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5423 This makes the code easier to follow, and makes it easier to catch
5424 integer overflow bugs such as Bug#8664.
5425 * frame.c (Fmouse_position, Fmouse_pixel_position):
5426 Use Time, not unsigned long, for user-interface timestamps.
5427 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5428 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5429 * keyboard.h (last_event_timestamp): Likewise.
5430 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5431 * menu.h (xmenu_show): Likewise.
5432 * term.c (term_mouse_position): Likewise.
5433 * termhooks.h (struct input_event.timestamp): Likewise.
5434 (struct terminal.mouse_position_hook): Likewise.
5435 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5436 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5437 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5438 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5439 what it was before.
5440 * menu.h, termhooks.h: Include "systime.h", for Time.
5441
8e55734a
PE
5442 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5443 Don't assume that the difference between two unsigned long values
5444 can fit into an integer. At this point, we know button_down_time
5445 <= event->timestamp, so the difference must be nonnegative, so
5446 there's no need to cast the result if double-click-time is
5447 nonnegative, as it should be; check that it's nonnegative, just in
5448 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5449 apart (about 25 days). (Bug#8664)
8e55734a 5450
841f1b75 5451 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5452 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5453
3e26f69c
PE
5454 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5455 that always fit in int. Use a sentinel instead of a counter, to
5456 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5457 * frame.h (struct frame): Use int for menu_bar_items_used
5458 instead of EMACS_INT, since it always fits in int.
3e26f69c 5459
5cc152c0
PE
5460 * menu.c (grow_menu_items): Check for int overflow.
5461
d89eb65e
PE
5462 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5463
5235bd3e
PE
5464 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5465 Before, the code was not consistent. These values cannot exceed
5466 2**31 - 1 so there's no need to make them unsigned.
5467 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5468 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5469 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5470 as modifiers.
5471 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5472
bc827e23
PE
5473 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5474 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5475 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5476 presumably because the widths might not match.
5477
78eb494e
PE
5478 * window.c (size_window): Avoid needless test at loop start.
5479
04f2d78b
CB
54802011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5481
5482 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5483
d2fc7e3d 54842011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5485
5486 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5487
d2fc7e3d 54882011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5489
5490 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5491 `width' to `bar_area_x' and `bar_area_width', respectively.
5492 (x_scroll_run): Take account of fringe background extension.
5493
04f2d78b
CB
5494 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5495 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5496 `bar_area_width', respectively.
5497 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5498 background extension.
5499
79b70037
GM
55002011-05-10 Jim Meyering <meyering@redhat.com>
5501
5502 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5503
2f142cc5
JB
55042011-05-10 Juanma Barranquero <lekktu@gmail.com>
5505
5506 * image.c (Finit_image_library): Return t for built-in image types,
5507 like pbm and xbm. (Bug#8640)
5508
57679c86
AS
55092011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5510
5511 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5512
888c9e86
EZ
55132011-05-07 Eli Zaretskii <eliz@gnu.org>
5514
b0512a1d
EZ
5515 * w32console.c (Fset_screen_color): Doc fix.
5516 (Fget_screen_color): New function.
5517 (syms_of_ntterm): Defsubr it.
5518
7285dc67
EZ
5519 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5520 unlink the temporary file if Fcall_process didn't create it in the
5521 first place.
5522 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5523 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5524 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5525 cue to call_process_cleanup not to close that handle.
5526
4d3fcc8e
BK
55272011-05-07 Ben Key <bkey76@gmail.com>
5528
5529 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5530 one of two shell specific rules, either bootstrap-temacs-CMD or
5531 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5532 to the previous implementation of the bootstrap-temacs rule.
5533 The bootstrap-temacs-CMD rule is similar to the previous
5534 implementation of the bootstrap-temacs rule except that it
5535 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5536 variable.
5537
5538 These changes, along with some changes to nt/configure.bat,
5539 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5540 earlier fix to add support for --cflags and --ldflags options
5541 that include quotes so that it works whether make uses cmd or
5542 sh as the shell.
5543
b4289b64
MA
55442011-05-06 Michael Albinus <michael.albinus@gmx.de>
5545
5546 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5547 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5548 is a constant.
5549 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5550 a string. Handle both cases.
5551 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5552 (Fdbus_register_method): Use Qinvalid_function.
5553
af4c0e28
JB
55542011-05-06 Juanma Barranquero <lekktu@gmail.com>
5555
5556 * makefile.w32-in: Update dependencies.
5557 (LISP_H): Add inttypes.h and stdin.h.
5558 (PROCESS_H): Add unistd.h.
5559
c51453d9
EZ
55602011-05-06 Eli Zaretskii <eliz@gnu.org>
5561
5562 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5563 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5564
8ff0ac3c 55652011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5566
4c4b566b
PE
5567 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5568
aab2b9b5
PE
5569 * term.c (vfatal): Remove stray call to va_end.
5570 It's not needed and the C Standard doesn't allow it here anyway.
5571
c378da0b
PE
5572 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5573 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5574
288b08c7
PE
5575 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5576 bytes.
5577
e3601888
PE
5578 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5579
db6c0e74
PE
5580 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5581
dd5963ea
PE
5582 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5583
88c9450f
PE
5584 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5585
2f9442b8
PE
5586 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5587
c032b5f8
PE
5588 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5589 * charset.c (Fdefine_charset_internal): Don't initialize
5590 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5591 32-bit int (Bug#8600).
a108c10b
PE
5592
5593 * lread.c (read_integer): Be more consistent with string-to-number.
5594 Use string_to_number to do the actual conversion; this avoids
5595 rounding errors and fixes some other screwups. Without this fix,
5596 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5597 (digit_to_number): Move earlier, for benefit of read_integer.
5598 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5599 not a digit in any supported base. (Bug#8602)
a108c10b 5600
ad5f9eea
PE
5601 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5602
aec1708a
PE
5603 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5604 to match comment at start of function. This also removes a
5605 GCC warning about overflow in a 32+64-bit port.
5606
47be4ab5
PE
5607 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5608
371cac43
PE
5609 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5610 Reported by Stefan Monnier in
5611 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5612 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5613 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5614
d01a7826
PE
5615 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5616 (EMACS_UINTPTR): Likewise, with uintptr_t.
5617
7fd47d5c
PE
5618 * lisp.h: Prefer 64-bit EMACS_INT if available.
5619 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5620 on 32-bit hosts that have 64-bit int, so that they can access
5621 large files.
122b0c86
PE
5622 However, temporarily disable this change unless the temporary
5623 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5624
8727937b
PE
5625 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5626
8ac068ac
PE
5627 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5628 This removes an assumption that EMACS_INT and long are the same
5629 width as pointers. The assumption is true for Emacs porting targets
5630 now, but we want to make other targets possible.
5631 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5632 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5633 In the rest of the code, change types of integers that hold casted
5634 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5635 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5636 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5637 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5638 No need to cast type when ORing.
5639 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5640 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5641 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5642 assume EMACS_INT is the same width as char *.
5643 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5644 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5645 Remove no-longer-needed casts.
5646 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5647 (xg_tool_bar_help_callback, xg_make_tool_item):
5648 Use EMACS_INTPTR to hold an integer
5649 that will be cast to void *; this can avoid a GCC warning
5650 if EMACS_INT is not the same width as void *.
5651 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5652 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5653 (current_message_1, set_message_1):
5654 Use a local to convert to proper width without a cast.
5655 * xmenu.c (dialog_selection_callback): Likewise.
5656
ede49d71
PE
5657 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5658 Also, don't assume VALBITS / RAND_BITS is less than 5,
5659 and don't rely on undefined behavior when shifting a 1 left into
5660 the sign bit.
5661 * lisp.h (get_random): Change signature to match.
5662
2f30ecd0
PE
5663 * lread.c (hash_string): Use size_t, not int, for hash computation.
5664 Normally we prefer signed values; but hashing is special, because
5665 it's better to use unsigned division on hash table sizes so that
5666 the remainder is nonnegative. Also, size_t is the natural width
5667 for hashing into memory. The previous code used 'int', which doesn't
5668 retain enough info to hash well into very large tables.
5669 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5670
2a866e7b
PE
5671 * dbusbind.c: Don't possibly lose pointer info when converting.
5672 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5673 Use XPNTR rather than XHASH, so that the high-order bits of
5674 the pointer aren't lost when converting through void *.
5675
51639eac
PE
5676 * eval.c (Fautoload): Don't double-shift a pointer.
5677
92394119
PE
5678 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5679
dbdb9a7c
JB
56802011-05-06 Juanma Barranquero <lekktu@gmail.com>
5681
5682 * gnutls.c (DEF_GNUTLS_FN):
5683 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5684
db7a0b4f
AS
56852011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5686
5687 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5688 marker. (Bug#8610)
5689
f7ff1b0f 56902011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5691
5692 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5693 New version that can reserve upto 2GB of heap space.
5694
f7ff1b0f 56952011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5696
5697 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5698
639c109b
TZ
56992011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5700
5701 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5702 `gnutls_certificate_set_x509_key_file'.
5703
d2127135
JB
57042011-05-05 Juanma Barranquero <lekktu@gmail.com>
5705
5706 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5707 Update dependencies.
5708
e968f4f3
JB
57092011-05-04 Juanma Barranquero <lekktu@gmail.com>
5710
5711 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5712 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5713 Remove unused parameter `fildes'.
5714 * process.c (read_process_output, send_process): Don't pass it.
5715
84d358f0
JB
57162011-05-04 Juanma Barranquero <lekktu@gmail.com>
5717
5718 Fix previous change: the library cache is defined in w32.c.
5719 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5720 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5721
0898ca10
JB
57222011-05-04 Juanma Barranquero <lekktu@gmail.com>
5723
5724 Implement dynamic loading of GnuTLS on Windows.
5725
5726 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5727 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5728 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5729 Declare.
5730
5731 * gnutls.c (Qgnutls_dll): Define.
5732 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5733 (gnutls_*): Declare function pointers.
5734 (init_gnutls_functions): New function to initialize function pointers.
5735 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5736 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5737 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5738 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5739 (emacs_gnutls_write, emacs_gnutls_read)
5740 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5741 (Fgnutls_available_p): New function.
5742 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5743 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5744 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5745
5746 * image.c: Include w32.h.
5747 (Vimage_type_cache): Delete.
5748 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5749 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5750 (w32_delayed_load): Move to w32.c.
5751
5752 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5753
5754 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5755 (w32_delayed_load): Move from image.c. When loading a library, record
5756 its filename in the :loaded-from property of the library id.
5757 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5758 Initialize and staticpro them.
5759 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5760
5761 * process.c: Include lisp.h before w32.h, not after.
5762 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5763 instead of gnutls_record_check_pending.
5764
5765 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5766
ff4de4aa
TZ
57672011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5768
5769 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5770 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5771 as passed in.
5772
abe95abb
JD
57732011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5774
5775 * xterm.c (x_set_frame_alpha): Do not set property on anything
5776 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5777
e16e55d4
JB
57782011-05-02 Juanma Barranquero <lekktu@gmail.com>
5779
5780 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5781
bafcf6a5
JB
57822011-05-02 Juanma Barranquero <lekktu@gmail.com>
5783
5784 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5785 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5786 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5787 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5788 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5789 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5790 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5791 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5792 (Qgnutls_bootprop_callbacks_verify): Make static.
5793
e7a6747f
AS
57942011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5795
19ed11ba
AS
5796 * callproc.c: Indentation fixup.
5797
e7a6747f 5798 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5799 (wait_for_termination, interruptible_wait_for_termination):
5800 Move after wait_for_termination_1.
e7a6747f 5801
1ef14cb4
LMI
58022011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5803
5804 * sysdep.c (interruptible_wait_for_termination): New function
5805 which is like wait_for_termination, but allows keyboard
5806 interruptions.
5807
5808 * callproc.c (Fcall_process): Add (:file "file") as an option for
5809 the STDOUT buffer.
5810 (Fcall_process_region): Ditto.
5811
330d880c
EZ
58122011-04-30 Eli Zaretskii <eliz@gnu.org>
5813
8db90b73
EZ
5814 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5815 rather than `XVECTOR (FOO)->size'.
5816
330d880c
EZ
5817 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5818 inttypes.h, as a gnulib replacement is used if it not available in
5819 system headers.
5820
15cbd324
EZ
58212011-04-21 Eli Zaretskii <eliz@gnu.org>
5822
5823 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5824 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5825 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5826
5827 * coding.c (coding_alloc_by_realloc): Error out if destination
5828 will grow beyond MOST_POSITIVE_FIXNUM.
5829 (decode_coding_emacs_mule): Abort if there isn't enough place in
5830 charbuf for the composition carryover bytes. Reserve an extra
5831 space for up to 2 characters produced in a loop.
5832 (decode_coding_iso_2022): Abort if there isn't enough place in
5833 charbuf for the composition carryover bytes.
5834
58352011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5836
ae940cca
EZ
5837 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5838 aborting when %lld or %lll format is passed.
5839 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5840 %llo or %llx format is passed. (Bug#8545)
5841
03ab8921
EZ
5842 * window.c (window_scroll_line_based): Use a marker instead of
5843 simple variables to record original value of point. (Bug#7952)
5844
afda1437
EZ
5845 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5846 produced by %s or %c overflows available buffer space. (Bug#8545)
5847
f76dee0c
PE
58482011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5849
5850 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5851 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5852
fdc5744d
JB
58532011-04-28 Juanma Barranquero <lekktu@gmail.com>
5854
5855 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5856
638f053a
JB
58572011-04-28 Juanma Barranquero <lekktu@gmail.com>
5858
5859 * keyboard.c (Qdelayed_warnings_hook): Define.
5860 (command_loop_1): Run `delayed-warnings-hook'
5861 if Vdelayed_warnings_list is non-nil.
5862 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5863 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5864
d178f871
EZ
58652011-04-28 Eli Zaretskii <eliz@gnu.org>
5866
5867 * doprnt.c (doprnt): Don't return value smaller than the buffer
5868 size if the message was truncated. (Bug#8545).
5869
b124fd93
JB
58702011-04-28 Juanma Barranquero <lekktu@gmail.com>
5871
5872 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5873 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5874
e810457d
PE
58752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5876
5877 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5878
ea51cceb
JB
58792011-04-27 Juanma Barranquero <lekktu@gmail.com>
5880
5881 * makefile.w32-in: Update dependencies.
5882
94dcfacf
EZ
58832011-04-27 Eli Zaretskii <eliz@gnu.org>
5884
5885 Improve `doprnt' and its usage. (Bug#8545)
5886 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5887 `format_end'. Remove support for %l as a conversion specifier.
5888 Don't use xrealloc. Improve diagnostics when the %l size modifier
5889 is used. Update the commentary.
5890
5891 * eval.c (verror): Simplify calculation of size_t.
5892
5893 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5894 messages.
5895
f61f41d7
PE
58962011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5897
5898 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5899 change.
5900
96fb4434
PE
59012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5902
5903 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5904 This makes this file independent of the recent pseudovector change.
5905
671875da 59062011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5907
69e9b5a3
PE
5908 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5909
b5f869a7 5910 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5911 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5912 Remove unused local.
c8926152 5913 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5914
841a1577 5915 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5916 GCC 4.6.0 optimizes based on type-based alias analysis.
5917 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5918 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5919 != &v->size, and therefore "v->size = 1; b->size = 2; return
5920 v->size;" must therefore return 1. This assumption is incorrect
5921 for Emacs, since it type-puns struct Lisp_Vector * with many other
5922 types. To fix this problem, this patch adds a new type struct
f904488f 5923 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5924 and pseudovectors, and helps optimizing compilers not get fooled
5925 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5926 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5927 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5928 the size member.
eab3844f
PE
5929 (XSETPVECTYPE): Rewrite in terms of new macro.
5930 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5931 This is a bit clearer, and further avoids the possibility of
5932 undesirable aliasing.
5933 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5934 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5935 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5936 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5937 (ASIZE): Now uses header.size rather than size.
5938 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5939 to avoid the hassle of writing XVECTOR (foo)->header.size.
5940 (struct vectorlike_header): New type.
eab3844f
PE
5941 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5942 object, to help avoid aliasing.
5943 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5944 (SUBRP): Likewise, since Lisp_Subr is a special case.
5945 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5946 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5947 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5948 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5949 changed to be "header.size" and "header.next".
5950 * buffer.h (struct buffer): Likewise.
5951 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5952 * frame.h (struct frame): Likewise.
5953 * process.h (struct Lisp_Process): Likewise.
5954 * termhooks.h (struct terminal): Likewise.
5955 * window.c (struct save_window_data, struct saved_window): Likewise.
5956 * window.h (struct window): Likewise.
5957 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5958 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5959 * buffer.c (init_buffer_once): Likewise.
5960 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5961 special case.
5962 * process.c (Fformat_network_address): Use local var for size,
5963 for brevity.
5964
0df1eac5
PE
5965 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5966
847ab9d1 5967 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5968 * data.c (atof): Remove decl; no longer used or needed.
5969 (digit_to_number): Move to lread.c.
5970 (Fstring_to_number): Use new string_to_number function, to be
5971 consistent with how the Lisp reader treats infinities and NaNs.
5972 Do not assume that floating-point numbers represent EMACS_INT
5973 without losing information; this is not true on most 64-bit hosts.
5974 Avoid double-rounding errors, by insisting on integers when
5975 parsing non-base-10 numbers, as the documentation specifies.
5976 * lisp.h (string_to_number): New decl, replacing ...
5977 (isfloat_string): Remove.
bc0a5c13 5978 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5979 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5980 appears to have been a coding error. Similarly, do not accept
5981 strings like +-1e0 as floating point numbers. Do not report
5982 overflow for integer overflows unless the base is not 10 which
5983 means we have no simple and reliable way to continue.
5984 Break out the floating-point parsing into a new
5985 function string_to_number, so that Fstring_to_number parses
5986 floating point numbers consistently with the Lisp reader.
04f2d78b 5987 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5988 (E_CHAR, EXP_INT): Remove, replacing with ...
5989 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5990 (string_to_number): New function, replacing isfloat_string.
5991 This function checks for valid syntax and produces the resulting
5992 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5993 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5994 so that overflow for non-base-10 numbers is reported only when
5995 there's no portable and simple way to convert to floating point.
452f4150 5996
67769ffc
PE
5997 * textprop.c (set_text_properties_1): Rewrite for clarity,
5998 and to avoid GCC warning about integer overflow.
5999
c20db43f
PE
6000 * intervals.h (struct interval): Use EMACS_INT for members
6001 where EMACS_UINT might cause problems. See
6002 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6003 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6004 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6005 All uses changed.
37aa2f85
PE
6006 (offset_intervals): Tell GCC not to worry about length overflow
6007 when negating a negative length.
c20db43f 6008
2538aa2f
PE
6009 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6010 (overrun_check_free): Likewise.
6011
f2d3008d
PE
6012 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6013 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6014 word size.
6015
ec8df744
PE
6016 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6017 (gnutls_make_error): Rename local to avoid shadowing.
6018 (gnutls_emacs_global_deinit): ifdef out; not used.
6019 (Fgnutls_boot): Use const for pointer to readonly storage.
6020 Comment out unused local. Fix pointer signedness problems.
6021
640ee02d
PE
6022 * lread.c (openp): Don't stuff size_t into an 'int'.
6023 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6024 about possible signed overflow.
6025
6048fb2a
PE
6026 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6027 (GDK_KEY_g): Don't define if already defined.
6028 (xg_prepare_tooltip): Avoid pointer signedness problem.
6029 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6030
fa3c87e1
PE
6031 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6032 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6033
2172544b
PE
6034 * xfns.c (Fx_window_property): Simplify a bit,
6035 to make a bit faster and to avoid GCC 4.6.0 warning.
6036 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6037
9b821a21
PE
6038 * fns.c (internal_equal): Don't assume size_t fits in int.
6039
3c616cfa
PE
6040 * alloc.c (compact_small_strings): Tighten assertion a little.
6041
c2982e87
PE
6042 Replace pEd with more-general pI, and fix some printf arg casts.
6043 * lisp.h (pI): New macro, generalizing old pEd macro to other
6044 conversion specifiers. For example, use "...%"pI"d..." rather
6045 than "...%"pEd"...".
6046 (pEd): Remove. All uses replaced with similar uses of pI.
6047 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6048 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6049 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6050 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6051 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6052 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6053 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6054 64-bit hosts.
6055 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6056 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6057 * print.c (safe_debug_print, print_object): Likewise.
6058 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6059 to int.
6f04d126
PE
6060 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6061 avoiding the 0 flag, which is not portable.
c2982e87
PE
6062 * process.c (Fmake_network_process): Use pI to avoid cast.
6063 * region-cache.c (pp_cache): Likewise.
6064 * xdisp.c (decode_mode_spec): Likewise.
6065 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6066 behavior on 64-bit hosts with printf arg.
6f04d126 6067 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6068 (x_stop_queuing_selection_requests): Likewise.
6069 (x_get_window_property): Don't truncate byte count to an 'int'
6070 when tracing.
0b432f21 6071
5e073ec7
PE
6072 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6073 here, since it parses constructs like leading '-' and spaces,
6074 which are not wanted; and it overflows with large numbers.
6075 Instead, simply match F[0-9]+, which is what is wanted anyway.
6076
36372bf9
PE
6077 * alloc.c: Remove unportable assumptions about struct layout.
6078 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6079 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6080 (allocate_vectorlike, make_pure_vector): Use the new macros,
6081 plus offsetof, to remove unportable assumptions about struct layout.
6082 These assumptions hold on all porting targets that I know of, but
6083 they are not guaranteed, they're easy to remove, and removing them
6084 makes further changes easier.
6085
0b432f21
PE
6086 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6087 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6088 (string_overrun_cookie): Now const. Use initializers that
6089 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6090 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6091 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6092 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6093 multiple of sizeof (EMACS_INT); it need not be, if
6094 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6095 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6096
895009e1
JB
60972011-04-26 Juanma Barranquero <lekktu@gmail.com>
6098
6099 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6100
6a7a1b0b
TZ
61012011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6102
6103 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6104 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6105 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6106
841a1577 61072011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6108
6109 * lisp.h (Qdebug): List symbol.
895009e1 6110 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6111 * keyboard.c (debug-on-event): New variable.
6112 (handle_user_signal): Break into debugger when debug-on-event
6113 matches the current signal symbol.
6114
f2d3ba6f
DN
61152011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6116
6117 * alloc.c (check_sblock, check_string_bytes)
6118 (check_string_free_list): Convert to standard C.
6119
42ce4c63
TZ
61202011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6121
6122 * w32.c (emacs_gnutls_push): Fix typo.
6123
825cd63c
EZ
61242011-04-25 Eli Zaretskii <eliz@gnu.org>
6125
fb11d64d
EZ
6126 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6127 "cast to pointer from integer of different size".
6128
825cd63c
EZ
6129 Improve doprnt and its use in verror. (Bug#8545)
6130 * doprnt.c (doprnt): Document the set of format control sequences
6131 supported by the function. Use SAFE_ALLOCA instead of always
6132 using `alloca'.
6133
6134 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6135 is one byte too soon. Don't use xrealloc; instead xfree and
6136 xmalloc anew.
6137
e061a11b
TZ
61382011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6139
6140 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6141 callbacks stage.
6142
6143 * gnutls.c: Renamed global_initialized to
6144 gnutls_global_initialized. Added internals for the
6145 :verify-hostname-error, :verify-error, and :verify-flags
6146 parameters of `gnutls-boot' and documented those parameters in the
6147 docstring. Start callback support.
9173deec
JB
6148 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6149 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6150 on error. Return error code.
e061a11b
TZ
6151 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6152 (emacs_gnutls_read): Likewise.
6153 (Fgnutls_boot): Return handshake error code.
6154 (emacs_gnutls_handle_error): New function.
6155 (wsaerror_to_errno): Likewise.
6156
6157 * w32.h (emacs_gnutls_pull): Add prototype.
6158 (emacs_gnutls_push): Likewise.
6159
6160 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6161 (emacs_gnutls_push): Likewise.
6162
61632011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6164
6165 * process.c (wait_reading_process_output): Check if GnuTLS
6166 buffered some data internally if no FDs are set for TLS
6167 connections.
6168
6169 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6170 (LIBS): Link to USER_LIBS.
6171 ($(BLD)/gnutls.$(0)): New target.
6172
fa6996bc
EZ
61732011-04-24 Eli Zaretskii <eliz@gnu.org>
6174
eb35682e
EZ
6175 * xdisp.c (handle_single_display_spec): Rename the
6176 display_replaced_before_p argument into display_replaced_p, to
6177 make it consistent with the commentary. Fix typos in the
6178 commentary.
6179
e2ad650c
EZ
6180 * textprop.c (syms_of_textprop): Remove dead code.
6181 (copy_text_properties): Delete obsolete commentary about an
6182 interface that was deleted long ago. Fix typos in the description
6183 of arguments.
6184
1b2de274
EZ
6185 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6186 to changes in oldXMenu/XMenu.h from 2011-04-16.
6187 <menu_help_message, prev_menu_help_message>: Constify.
6188 (IT_menu_make_room): menu->help_text is now `const char **';
6189 adjust.
6190
6191 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6192 to changes in oldXMenu/XMenu.h from 2011-04-16.
6193 (struct XMenu): Declare `help_text' `const char **'.
6194
6195 * xfaces.c <Qunspecified>: Make extern again.
6196
6197 * syntax.c: Include sys/types.h before including regex.h, as
6198 required by Posix.
6199
762b15be
EZ
6200 * doc.c (get_doc_string): Improve the format passed to `error'.
6201
6202 * doprnt.c (doprnt): Improve commentary.
6203
6204 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6205
6206 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6207 them with etags.
6208
f1052e5d
EZ
6209 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6210 changes in globals.h immediately force recompilation.
762b15be
EZ
6211 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6212 $(CURDIR)/s/ms-w32.h.
6213 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6214
fa6996bc
EZ
6215 * character.c (Fchar_direction): Function deleted.
6216 (syms_of_character): Don't defsubr it.
6217 <char-direction-table>: Deleted.
6218
e6c3da20
EZ
62192011-04-23 Eli Zaretskii <eliz@gnu.org>
6220
6221 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6222 * doprnt.c: Include limits.h.
6223 (SIZE_MAX): New macro.
04f2d78b
CB
6224 (doprnt): Return a size_t value. 2nd arg is now size_t.
6225 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6226 Improve overflow protection. Support `l' modifier for integer
6227 conversions. Support %l conversion. Don't assume an EMACS_INT
6228 argument for integer conversions and for %c.
6229
6230 * lisp.h (doprnt): Restore prototype.
6231
6232 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6233 $(SRC)/character.h.
6234
6235 * Makefile.in (base_obj): Add back doprnt.o.
6236
6237 * deps.mk (doprnt.o): Add back prerequisites.
6238 (callint.o): Depend on character.h.
6239
6240 * eval.c (internal_lisp_condition_case): Include the handler
6241 representation in the error message.
6242 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6243 when breaking from the loop.
6244
6245 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6246
6247 * callint.c (Fcall_interactively): When displaying error message
6248 about invalid control letter, pass the character's codepoint, not
6249 a pointer to its multibyte form. Improve display of the character
6250 in octal and display also its hex code.
6251
6252 * character.c (char_string): Use %x to display the (unsigned)
6253 codepoint of an invalid character, to avoid displaying a bogus
6254 negative value.
6255
6256 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6257 `error', not SYMBOL_NAME itself.
6258
6259 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6260 character arguments to `error'.
6261
6262 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6263 to `error' in error message about FINAL_CHAR argument. Make sure
6264 FINAL_CHAR is a character, and use %c when it is passed as
6265 argument to `error'.
6266
4ffd0d6b 62672011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6268
6269 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6270
6271 * w32.c: Include <time.h>.
6272 (sys_localtime): New function.
6273
4ffd0d6b 62742011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6275
6276 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6277
4ffd0d6b 6278 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6279
4ffd0d6b 62802011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6281
4ffd0d6b
GM
6282 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6283 zombies (Bug#8467).
aac0c6e3 6284
04c56954
EZ
62852011-04-19 Eli Zaretskii <eliz@gnu.org>
6286
6287 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6288 gl_state.e_property when gl_state.object is Qt.
6289
6290 * insdel.c (make_gap_larger): Remove limitation of buffer size
6291 to <= INT_MAX.
6292
16a43933
CY
62932011-04-18 Chong Yidong <cyd@stupidchicken.com>
6294
6295 * xdisp.c (lookup_glyphless_char_display)
6296 (produce_glyphless_glyph): Handle cons cell entry in
6297 glyphless-char-display.
6298 (Vglyphless_char_display): Document it.
6299
6300 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6301 glyphless-char-display.
6302
4581706e
CY
63032011-04-17 Chong Yidong <cyd@stupidchicken.com>
6304
6305 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6306
6307 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6308
6309 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6310 definition for no-X builds.
6311
4887c6e2 63122011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6313
fd35b6f9
PE
6314 Static checks with GCC 4.6.0 and non-default toolkits.
6315
5c1ccb01
PE
6316 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6317
006c5daa
PE
6318 * process.c (keyboard_bit_set): Define only if SIGIO.
6319 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6320 (send_process): Repair possible setjmp clobbering.
6321
efc736d3
PE
6322 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6323
4e2fe2e6
PE
6324 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6325
f97334a2
PE
6326 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6327
4e75f29d
PE
6328 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6329 Define only if needed.
6330
90efadd1
PE
6331 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6332 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6333 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6334
3c647824
PE
6335 * dispextern.h (struct redisplay_interface): Rename param
6336 to avoid shadowing.
e264f262 6337 * termhooks.h (struct terminal): Likewise.
761383f4 6338 * xterm.c (xembed_send_message): Likewise.
3c647824 6339
b58c5c4a
PE
6340 * insdel.c (make_gap_smaller): Define only if
6341 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6342
cad59032
PE
6343 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6344 it.
6345
c339dc2e
PE
6346 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6347 so that we aren't warned about unused symbols.
6348
91a3e27b
PE
6349 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6350
399c71d3 6351 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6352
8ffc96f5
PE
6353 * xfns.c (x_real_positions): Mark locals as initialized.
6354
eef9bc79
PE
6355 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6356
098db9dd
PE
6357 * xterm.c: Fix problems found by static analysis with other toolkits.
6358 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6359 (x_dispatch_event): Declare static if USE_GTK, and
6360 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6361 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6362 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6363 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6364 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6365
eb18f6cc
PE
6366 * xmenu.c (menu_help_callback): Pointer type fixes.
6367 Use const pointers when pointing at readonly data. Avoid pointer
6368 signedness clashes.
6369 (FALSE): Remove unused macro.
6370 (update_frame_menubar): Remove unused decl.
6371
1fe72bf8
PE
6372 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6373
60d9e1db
PE
6374 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6375 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6376 (single_menu_item): Rename local to avoid shadowing.
6377
39261c26
PE
6378 * keyboard.c (make_lispy_event): Remove unused local var.
6379
018c5e19
PE
6380 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6381 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6382
63d2b86e
PE
6383 * bitmaps: Change bitmaps from unsigned char back to the X11
6384 compatible char. Avoid the old compiler warnings about
6385 out-of-range initializers by using, for example, '\xab' rather
6386 than 0xab.
6387
aefd87e1
PE
6388 * xgselect.c (xgselect_initialize): Check vs interface
6389 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6390
bf501fb9
PE
6391 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6392
e9829fdf
PE
6393 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6394 to read-only memory.
6395
1086c095
PE
6396 * fns.c (vector): Remove; this old hack is no longer needed.
6397
2baccd04 6398 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6399 Remove unused var.
dde42981 6400 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6401
72391843 6402 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6403
436c16df 6404 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6405 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6406 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6407
92bb796d 6408 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6409 (x_term_init): Remove local to avoid shadowing.
92bb796d 6410
764430a3 6411 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6412
6413 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6414 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6415
d1dfb56c
EZ
64162011-04-16 Eli Zaretskii <eliz@gnu.org>
6417
c4354cb4
EZ
6418 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6419
d1dfb56c
EZ
6420 Fix regex.c, syntax.c and friends for buffers > 2GB.
6421 * syntax.h (struct gl_state_s): Declare character position members
6422 EMACS_INT.
6423
6424 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6425
04f2d78b
CB
6426 * textprop.c (verify_interval_modification, interval_of):
6427 Declare arguments EMACS_INT.
d1dfb56c
EZ
6428
6429 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6430 EMACS_INT.
6431
6432 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6433
6434 * indent.c (Fvertical_motion): Local variable it_start is now
6435 EMACS_INT.
6436
6437 * regex.c (re_match, re_match_2, re_match_2_internal)
6438 (bcmp_translate, regcomp, regexec, print_double_string)
6439 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6440 (re_compile_pattern, re_exec): Declare arguments and local
6441 variables `size_t' and `ssize_t' and return values `regoff_t', as
6442 appropriate.
6443 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6444 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6445 <compile_stack_type>: `size' and `avail' are now `size_t'.
6446
6447 * regex.h <regoff_t>: Use ssize_t, not int.
6448 (re_search, re_search_2, re_match, re_match_2): Arguments that
6449 specify buffer/string position and length are now ssize_t and
6450 size_t. Return type is regoff_t.
6451
613052cd
BK
64522011-04-16 Ben Key <bkey76@gmail.com>
6453
6454 * nsfont.m: Fixed bugs in ns_get_family and
6455 ns_descriptor_to_entity that were caused by using free to
6456 deallocate memory blocks that were allocated by xmalloc (via
6457 xstrdup). This caused Emacs to crash when compiled with
6458 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6459 --enable-checking=xmallocoverrun). xfree is now used to
6460 deallocate these memory blocks.
6461
4170f62f 64622011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6463
71b41406
PE
6464 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6465
9587a89d
PE
6466 emacs_write: Accept and return EMACS_INT for sizes.
6467 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6468 et seq.
6469 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6470 Accept and return EMACS_INT.
6471 (emacs_gnutls_write): Return the number of bytes written on
6472 partial writes.
6473 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6474 (emacs_read, emacs_write): Remove check for negative size, as the
6475 Emacs source code has been audited now.
9587a89d
PE
6476 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6477 (emacs_read, emacs_write): Use it.
273a5f82
PE
6478 * process.c (send_process): Adjust to the new signatures of
6479 emacs_write and emacs_gnutls_write. Do not attempt to store
6480 a byte offset into an 'int'; it might overflow.
9587a89d 6481 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6482
3e047f51
PE
6483 * sound.c: Don't assume sizes fit in 'int'.
6484 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6485 Return EMACS_INT, not int.
3e047f51 6486 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6487 Accept EMACS_INT, not int.
6488 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6489 record read return values.
6490
cc39a9db
BK
64912011-04-15 Ben Key <bkey76@gmail.com>
6492
c9d0ec6d
JB
6493 * keyboard.c (Qundefined): Don't declare static since it is used
6494 in nsfns.m.
6495 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6496 static since they are used in nsfont.m.
cc39a9db 6497
6c60eb9f
SM
64982011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6499
6500 * process.c (Qprocessp): Don't declare static.
6501 * lisp.h (Qprocessp): Declare again.
6502
7990b61a
JB
65032011-04-15 Juanma Barranquero <lekktu@gmail.com>
6504
6505 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6506
5d4cb038
PE
65072011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6508
8bd7b830 6509 Improve C-level modularity by making more things 'static'.
cd64ea1d 6510
e3b27b31
PE
6511 Don't publish debugger-only interfaces to other modules.
6512 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6513 (verify_bytepos, count_markers): Move decls to the only modules
6514 that need them.
6515 * region-cache.h (pp_cache): Likewise.
6516 * window.h (check_all_windows): Likewise.
6517 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6518
5d4cb038
PE
6519 * sysdep.c (croak): Now static, if
6520 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6521 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6522
6523 * alloc.c (refill_memory_reserve): Now static if
6524 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6525 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6526
e87b6180
PE
6527 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6528 Define only if USE_LUCID.
6529
ac64929e
PE
6530 * xrdb.c (x_customization_string, x_rm_string): Now static.
6531
6f37259d
PE
6532 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6533 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6534
1683e3ab
PE
6535 * xdisp.c (draw_row_with_mouse_face): Now static.
6536 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6537
de9c2632
PE
6538 * window.h (check_all_windows): Mark externally visible.
6539
2b96acb7
PE
6540 * window.c (window_deletion_count): Now static.
6541
6542 * undo.c: Make symbols static if they're not exported.
6543 (last_undo_buffer, last_boundary_position, pending_boundary):
6544 Now static.
6545
50436f33
PE
6546 * textprop.c (interval_insert_behind_hooks): Now static.
6547 (interval_insert_in_front_hooks): Likewise.
6548
64520e5c
PE
6549 * term.c: Make symbols static if they're not exported.
6550 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6551 (max_frame_lines, tty_set_terminal_modes):
6552 (tty_reset_terminal_modes, tty_turn_off_highlight):
6553 (get_tty_terminal): Now static.
6554 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6555 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6556 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6557 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6558 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6559
1fa53021
PE
6560 * sysdep.c: Make symbols static if they're not exported.
6561 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6562 Now static.
6563 (sigprocmask_set, full_mask): Remove; unused.
6564 (wait_debugging): Mark as visible.
6565 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6566 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6567
d4b43b22
PE
6568 * syntax.c (syntax_temp): Define only if !__GNUC__.
6569
b7c513d0
PE
6570 * sound.c (current_sound_device, current_sound): Now static.
6571
989b29ad
PE
6572 * search.c (searchbufs, searchbuf_head): Now static.
6573
13a55a78
PE
6574 * scroll.c (scroll_cost): Remove; unused.
6575 * dispextern.h (scroll_cost): Remove decl.
6576
de68a1fc
PE
6577 * region-cache.h (pp_cache): Mark as externally visible.
6578
40ccffa6
PE
6579 * process.c: Make symbols static if they're not exported.
6580 (process_tick, update_tick, create_process, chan_process):
6581 (Vprocess_alist, proc_buffered_char, datagram_access):
6582 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6583 (deactivate_process): Mark defn as static, as well as decl.
6584 * lisp.h (create_process): Remove decl.
6585 * process.h (chan_process, Vprocess_alist): Remove decls.
6586
ad64fc97
PE
6587 * print.c: Make symbols static if they're not exported.
6588 (print_depth, new_backquote_output, being_printed, print_buffer):
6589 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6590 (print_interval, print_number_index, initial_stderr_stream):
6591 Now static.
6592 * lisp.h (Fprinc): Remove decl.
6593 (debug_output_compilation_hack): Mark as externally visible.
6594
adddb265
PE
6595 * sysdep.c (croak): Move decl from here to syssignal.h.
6596 * syssignal.h (croak): Put it here, so the API can be checked when
6597 'croak' is called from dissociate_if_controlling_tty.
6598
1717ede2
PE
6599 * minibuf.c: Make symbols static if they're not exported.
6600 (minibuf_save_list, choose_minibuf_frame): Now static.
6601 * lisp.h (choose_minibuf_frame): Remove decl.
6602
fa5fb2bc
PE
6603 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6604
1e3890d1
PE
6605 * lread.c: Make symbols static if they're not exported.
6606 (read_objects, initial_obarray, oblookup_last_bucket_number):
6607 Now static.
6608 (make_symbol): Remove; unused.
6609 * lisp.h (initial_obarray, make_symbol): Remove decls.
6610
8a1414fa
PE
6611 * keyboard.c: Make symbols static if they're not exported.
6612 (single_kboard, recent_keys_index, total_keys, recent_keys):
6613 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6614 (this_single_command_key_start, echoing, last_auto_save):
6615 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6616 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6617 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6618 (Vlispy_mouse_stem, double_click_count):
6619 Now static.
6620 (force_auto_save_soon): Define only if SIGDANGER.
6621 (ignore_mouse_drag_p): Now static if
6622 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6623 (print_help): Remove; unused.
6624 (stop_character, last_timer_event): Mark as externally visible.
6625 * keyboard.h (ignore_mouse_drag_p): Declare only if
6626 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6627 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6628 * lisp.h (echoing): Remove decl.
6629 (force_auto_save_soon): Declare only if SIGDANGER.
6630 * xdisp.c (redisplay_window): Simplify code, to make it more
6631 obvious that ignore_mouse_drag_p is not accessed if !defined
6632 USE_GTK && !defined HAVE_NS.
6633
93ea6e8f
PE
6634 * intervals.c: Make symbols static if they're not exported.
6635 (merge_properties_sticky, merge_interval_right, delete_interval):
6636 Now static.
6637 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6638
77382fcc
PE
6639 * insdel.c: Make symbols static if they're not exported.
6640 However, leave prepare_to_modify_buffer alone. It's never
6641 called from outside this function, but that appears to be a bug.
6642 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6643 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6644 (adjust_after_replace_noundo): Remove; unused.
6645 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6646 (signal_before_change): Remove decls.
77382fcc 6647
9306c32e
PE
6648 * indent.c (val_compute_motion, val_vmotion): Now static.
6649
cd44d2eb
PE
6650 * image.c: Make symbols static if they're not exported.
6651 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6652 if USE_GTK.
6653 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6654 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6655
ad9a7a06
PE
6656 * fringe.c (standard_bitmaps): Now static.
6657 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6658
81626931
PE
6659 * frame.c: Make symbols static if they're not exported.
6660 (x_report_frame_params, make_terminal_frame): Now static.
6661 (get_frame_param): Now static, unless HAVE_NS.
6662 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6663 (x_get_resource_string): Remove; not used.
6664 * frame.h (make_terminal_frame, x_report_frame_params):
6665 (x_get_resource_string); Remove decls.
6666 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6667 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6668
239f9db9
PE
6669 * font.c, fontset.c: Make symbols static if they're not exported.
6670 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6671 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6672 * font.c (font_close_object): Now static.
6673 * font.h (font_close_object): Remove.
6674 * fontset.c (FONTSET_OBJLIST): Remove.
6675 (free_realized_fontset) #if-0 the body, which does nothing.
6676 (face_suitable_for_char_p): #if-0, as it's never called.
6677 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6678 * xfaces.c (face_at_string_position):
6679 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6680 since 0 is always ASCII.
6681
dfcf3579
PE
6682 * fns.c (weak_hash_tables): Now static.
6683
5045092b
PE
6684 * fileio.c: Make symbols static if they're not exported.
6685 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6686 (Vwrite_region_annotation_buffers): Now static.
6687
57a96f5c
PE
6688 * eval.c: Make symbols static if they're not exported.
6689 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6690 * lisp.h (backtrace_list): Remove decl.
6691
35f08c38
PE
6692 * emacs.c: Make symbols static if they're not exported.
6693 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6694 (fatal_error_code, fatal_error_signal_hook, standard_args):
6695 Now static.
6696 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6697 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6698 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6699 * lisp.h (fatal_error_signal_hook): Remove decl.
6700 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6701
f44bd759
PE
6702 * editfns.c: Move a (normally-unused) function to its only use.
6703 * editfns.c, lisp.h (get_operating_system_release): Remove.
6704 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6705 worth the hassle of breaking this out.
6706
b532497d
PE
6707 * xterm.c: Make symbols static if they're not exported.
6708 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6709 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6710 (x_destroy_window, x_delete_display):
6711 Now static.
6712 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6713 (x_mouse_leave): Remove; unused.
6714 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6715 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6716 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6717 Remove decls.
6718 (x_mouse_leave): Declare only if WINDOWSNT.
6719 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6720 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6721 USE_X_TOOLKIT.
6722
1675728f
PE
6723 * ftxfont.c: Make symbols static if they're not exported.
6724 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6725 HAVE_FREETYPE.
6726 * font.h (ftxfont_driver): Likewise.
6727
e4cebfca
PE
6728 * xfns.c: Make symbols static if they're not exported.
6729 (x_last_font_name, x_display_info_for_name):
6730 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6731 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6732 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6733 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6734 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6735 (last_show_tip_args): Now static.
6736 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6737 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6738 (x_screen_planes): Remove; unused.
6739 * dispextern.h (x_screen_planes): Remove decl.
6740
5bf46f05
PE
6741 * dispnew.c: Make symbols static if they're not exported.
6742 * dispextern.h (redraw_garbaged_frames, scrolling):
6743 (increment_row_positions): Remove.
6744 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6745 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6746 Now static.
6747 (redraw_garbaged_frames): Remove; unused.
6748
435f4c28
PE
6749 * xfaces.c: Make symbols static if they're not exported.
6750 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6751 Remove decls.
6752 * xterm.h (defined_color): Remove decls.
6753 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6754 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6755 (menu_face_changed_default, defined_color, free_realized_face):
6756 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6757 (ascii_face_of_lisp_face): Remove; unused.
6758
8524aef3
PE
6759 * xdisp.c: Make symbols static if they're not exported.
6760 * dispextern.h (scratch_glyph_row, window_box_edges):
6761 (glyph_to_pixel_coords, set_cursor_from_row):
6762 (get_next_display_element, set_iterator_to_next):
6763 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6764 (show_mouse_face): Remove decls
6765 * frame.h (message_buf_print): Likewise.
6766 * lisp.h (pop_message, set_message, check_point_in_composition):
6767 Likewise.
6768 * xterm.h (set_vertical_scroll_bar): Likewise.
6769 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6770 (message_buf_print, scratch_glyph_row, displayed_buffer):
6771 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6772 (get_next_display_element, show_mouse_face, window_box_edges):
6773 (frame_to_window_pixel_xy, check_point_in_composition):
6774 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6775 (glyph_to_pixel_coords): Remove; unused.
6776
16390cd2
PE
6777 * dired.c (file_name_completion): Now static.
6778
6779 * dbusbind.c (xd_in_read_queued_messages): Now static.
6780
a25f4dfa
PE
6781 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6782 * data.c (circular_list_error): Remove.
6783
14a9c8df
PE
6784 * commands.h (last_point_position, last_point_position_buffer):
6785 (last_point_position_window): Remove decls.
6786 * keyboard.c: Make these variables static.
6787
04f2d78b
CB
6788 * coding.h (coding, code_convert_region, encode_coding_gap):
6789 Remove decls.
74ab6df5
PE
6790 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6791 (iso_code_class, detect_coding, code_convert_region): Now static.
6792 (encode_coding_gap): Remove; unused.
6793
38dfbee1
PE
6794 * chartab.c (chartab_chars, chartab_bits): Now static.
6795
a2cb4e63
PE
6796 * charset.h (charset_iso_8859_1): Remove decl.
6797 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6798 Now static.
6799
127198fd
PE
6800 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6801 * ccl.c (Vccl_program_table): Now static.
6802 (check_ccl_update): Remove; unused.
6803
d85b608f
PE
6804 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6805 * category.h: ... from here.
6806 * category.c (check_category_table, set_category_set): Now static.
6807
31cd66f3
PE
6808 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6809 * lisp.h: Remove these decls.
6810
c358e587
PE
6811 * buffer.c (buffer_count): Remove unused var.
6812
e78aecca
PE
6813 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6814 so that it's not optimized away.
6815 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6816 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6817 exported only to the debugger.
6818
e192d7d3 6819 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6820 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6821
92470028
PE
6822 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6823 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6824 was inaccessible from Lisp.
6825 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6826 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6827
244ed907
PE
6828 alloc.c: Import and export fewer symbols, and remove unused items.
6829 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6830 is defined.
6831 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6832 it's not optimized away by whole-program optimization.
6833 (message_enable_multibyte, free_misc): Remove.
6834 (catchlist, handlerlist, mark_backtrace):
6835 Declare only if BYTE_MARK_STACK.
6836 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6837 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6838 (message_enable_multibyte): Remove decl.
6839 (free_misc, interval_free_list, float_block, float_block_index):
6840 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6841 (cons_free_list, last_marked_index):
6842 Now static.
6843 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6844 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6845 (mark_backtrace): Define only if BYTE_MARK_STACK.
6846 * xdisp.c (message_enable_multibyte): Now static.
6847
61c2b50e 6848 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6849 This makes it easier for human readers (and static analyzers)
6850 to see whether these variables are used from other modules.
6851 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6852 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6853 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6854 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6855 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6856 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6857 * xmenu.c, xselect.c:
6858 Declare Q* vars static if they are not used in other modules.
6859 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6860 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6861 Remove decls of unexported vars.
6862 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6863
95c82688
PE
6864 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6865
16a97296
PE
6866 Make Emacs functions such as Fatom 'static' by default.
6867 This makes it easier for human readers (and static analyzers)
6868 to see whether these functions can be called from other modules.
6869 DEFUN now defines a static function. To make the function external
6870 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6871 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6872 (Finit_image_library):
16a97296
PE
6873 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6874 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6875 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6876 Remove decls, since these functions are now static.
6877 (Funintern, Fget_internal_run_time): New decls, since these functions
6878 were already external.
95c82688 6879
16a97296
PE
6880 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6881 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6882 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6883 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6884 * keyboard.c, keymap.c, lread.c:
6885 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6886 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6887 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6888 Mark functions with DEFUE instead of DEFUN,
6889 if they are used in other modules.
6890 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6891 decls for now-static functions.
6892 * buffer.h (Fdelete_overlay): Remove decl.
6893 * callproc.c (Fgetenv_internal): Mark as internal.
6894 * composite.c (Fremove_list_of_text_properties): Remove decl.
6895 (Fcomposition_get_gstring): New forward static decl.
6896 * composite.h (Fcomposite_get_gstring): Remove decl.
6897 * dired.c (Ffile_attributes): New forward static decl.
6898 * doc.c (Fdocumntation_property): New forward static decl.
6899 * eval.c (Ffetch_bytecode): New forward static decl.
6900 (Funintern): Remove extern decl; now in .h file where it belongs.
6901 * fileio.c (Fmake_symbolic_link): New forward static decl.
6902 * image.c (Finit_image_library): New forward static decl.
6903 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6904 * intervals.h (Fprevious_property_change):
6905 (Fremove_list_of_text_properties): Remove decls.
6906 * keyboard.c (Fthis_command_keys): Remove decl.
6907 (Fcommand_execute): New forward static decl.
6908 * keymap.c (Flookup_key): New forward static decl.
6909 (Fcopy_keymap): Now static.
6910 * keymap.h (Flookup_key): Remove decl.
6911 * process.c (Fget_process): New forward static decl.
6912 (Fprocess_datagram_address): Mark as internal.
6913 * syntax.c (Fsyntax_table_p): New forward static decl.
6914 (skip_chars): Remove duplicate decl.
6915 * textprop.c (Fprevious_property_change): New forward static decl.
6916 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6917 Now internal.
6918 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6919 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6920
785bbd42
PE
6921 * editfns.c (Fformat): Remove unreachable code.
6922
8b913b57
AS
69232011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6924
6925 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6926 change. (Bug#8496)
6927
a6744a35
EZ
69282011-04-13 Eli Zaretskii <eliz@gnu.org>
6929
6930 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6931 when at ZV. (Bug#8487)
6932
e7974947
AS
69332011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6934
baad03f0
AS
6935 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6936 (Bug#8437)
6937 * keyboard.c (parse_tool_bar_item): Likewise.
6938 * sound.c (sound_cleanup, alsa_close): Likewise.
6939 * termcap.c (tgetent): Likewise.
6940 * xfns.c (x_default_font_parameter): Likewise.
6941 * xsettings.c (read_and_apply_settings): Likewise.
6942
e7974947
AS
6943 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6944 (overrun_check_free): Protoize.
6945
28272684
PE
69462011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6947
6948 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6949 since callers should never pass a negative size.
6950 Change the signature to match that of plain 'read' and 'write'; see
6951 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6952 * lisp.h: Update prototypes of emacs_write and emacs_read.
6953
11997c76
EZ
69542011-04-11 Eli Zaretskii <eliz@gnu.org>
6955
6956 * xdisp.c (redisplay_window): Don't try to determine the character
6957 position of the scroll margin if the window start point w->startp
e896f03c 6958 is outside the buffer's accessible region. (Bug#8468)
11997c76 6959
8a2cbd72
EZ
69602011-04-10 Eli Zaretskii <eliz@gnu.org>
6961
6962 Fix write-region and its subroutines for buffers > 2GB.
6963 * fileio.c (a_write, e_write): Modify declaration of arguments and
6964 local variables to support buffers larger than 2GB.
6965 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6966
6967 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6968 argument, local variables, and return value.
6969
6970 * lisp.h: Update prototypes of emacs_write and emacs_read.
6971
6972 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6973
4073e537 69742011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6975
1ebfdcb6
PE
6976 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6977
b2ded58d
PE
6978 Fix more problems found by GCC 4.6.0's static checks.
6979
7d66342c
PE
6980 * xdisp.c (vmessage): Use a better test for character truncation.
6981
bbf47d44
PE
6982 * charset.c (load_charset_map): <, not <=, for optimization,
6983 and to avoid potential problems with integer overflow.
9248994d 6984 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6985 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6986 * editfns.c (Fformat): Likewise.
1e69125e 6987 * syntax.c (skip_chars): Likewise.
3befa583 6988
e3019616
PE
6989 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6990 This also lets GCC 4.6.0 generate slightly better loop code.
6991
becfa255
PE
6992 * callint.c (Fcall_interactively): <, not <=, for optimization.
6993 (Fcall_interactively): Count the number of arguments produced,
6994 not the number of arguments given. This is simpler and lets GCC
6995 4.6.0 generate slightly better code.
6996
dae0cd48
PE
6997 * ftfont.c: Distingish more carefully between FcChar8 and char.
6998 The previous code passed unsigned char * to a functions like
6999 strlen and xstrcasecmp that expect char *, which does not
7000 conform to the C standard.
7001 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7002 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7003 char * when the C standard requires it.
7004
76032d70
PE
7005 * keyboard.c (read_char): Remove unused var.
7006
eb3f1cc8
PE
7007 * eval.c: Port to Windows vsnprintf (Bug#8435).
7008 Include <limits.h>.
7009 (SIZE_MAX): Define if the headers do not.
7010 (verror): Do not give up if vsnprintf returns a negative count.
7011 Instead, grow the buffer. This ports to Windows vsnprintf, which
7012 does not conform to C99. Problem reported by Eli Zaretskii.
7013 Also, simplify the allocation scheme, by avoiding the need for
7014 calling realloc, and removing the ALLOCATED variable.
7015
70476b54
PE
7016 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7017
12020a9e
PE
7018 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7019 But keep the doprint source code for now, as we might revamp it
7020 and use it again (Bug#8435).
ea6c7ae6
PE
7021 * lisp.h (doprnt): Remove.
7022 * Makefile.in (base_obj): Remove doprnt.o.
7023 * deps.mk (doprnt.o): Remove.
7024
5fdb398c
PE
7025 error: Print 32- and 64-bit integers portably (Bug#8435).
7026 Without this change, on typical 64-bit hosts error ("...%d...", N)
7027 was used to print both 32- and 64-bit integers N, which relied on
7028 undefined behavior.
7029 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7030 New macro.
7031 * lisp.h (error, verror): Mark as printf-like functions.
7032 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7033 Report overflow in size calculations when allocating printf buffer.
7034 Do not truncate output string at its first null byte.
7035 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7036 Truncate the output at a character boundary, since vsnprintf does not
7037 do that.
7038 * charset.c (check_iso_charset_parameter): Convert internal
7039 character to string before calling 'error', since %c now has the
7040 printf meaning.
7041 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7042 overflow when computing char to be passed to 'error'. Do not
7043 pass Lisp_Object to 'error'; pass the integer instead.
7044 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7045 formatted with plain %d.
7046
b189fa66
PE
7047 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7048
bff87ef0
PE
7049 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7050
7e2cac20
PE
7051 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7052
ce4d90b5
PE
7053 * xterm.c (x_catch_errors): Remove duplicate declaration.
7054
266c9547
PE
7055 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7056
79c49ad2
PE
7057 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7058
368f4090
JM
70592011-04-10 Jim Meyering <meyering@redhat.com>
7060
7061 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7062 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7063 return ssize_t not "int", and use size_t as the buffer length.
7064 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7065 * gnutls.h: Update declarations.
7066 * process.c (read_process_output): Use ssize_t, to match.
7067 (send_process): Likewise.
7068
a32d4040
CY
70692011-04-09 Chong Yidong <cyd@stupidchicken.com>
7070
7071 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7072
8546720e 70732011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7074
04f2d78b
CB
7075 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7076 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7077
8546720e
GM
7078 * xterm.c (handle_one_xevent):
7079 * xmenu.c (create_and_show_popup_menu):
7080 * xselect.c (x_decline_selection_request)
7081 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7082
0a2f5c1a 70832011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7084
7085 Fix some uses of `int' instead of EMACS_INT.
7086 * search.c (string_match_1, fast_string_match)
7087 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7088 (scan_buffer, find_next_newline_no_quit)
7089 (find_before_next_newline, search_command, Freplace_match)
7090 (Fmatch_data): Make some `int' variables be EMACS_INT.
7091
7092 * xdisp.c (display_count_lines): 3rd argument and return value now
7093 EMACS_INT. All callers changed.
7094 (pint2hrstr): Last argument is now EMACS_INT.
7095
7096 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7097 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7098 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7099 (decode_coding_utf_16, decode_coding_emacs_mule)
7100 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7101 (decode_coding_ccl, decode_coding_charset)
7102 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7103 (decode_coding_iso_2022, decode_coding_emacs_mule)
7104 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7105 <char_offset, last_offset>: Declare EMACS_INT.
7106 (encode_coding_utf_8, encode_coding_utf_16)
7107 (encode_coding_emacs_mule, encode_invocation_designation)
7108 (encode_designation_at_bol, encode_coding_iso_2022)
7109 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7110 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7111 Declare EMACS_INT.
7112 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7113 (encode_invocation_designation): Last argument P_NCHARS is now
7114 EMACS_INT.
7115 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7116 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7117
7118 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7119 All users changed.
7120
7121 * ccl.c (Fccl_execute_on_string): Declare some variables
7122 EMACS_INT.
7123
8546720e 71242011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7125
7126 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7127
4e19a977
CS
71282011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7129
7130 * process.c (Fformat_network_address): Doc fix.
7131
87302331
R
71322011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7133
ee7683eb 7134 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7135
cbb59342
CY
71362011-04-08 Chong Yidong <cyd@stupidchicken.com>
7137
7138 * keyboard.c (read_char): Call Lisp function help-form-show,
7139 instead of using internal_with_output_to_temp_buffer.
7140 (Qhelp_form_show): New var.
e0d38eeb 7141 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7142
7143 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7144
7145 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7146
e67a13ab
CY
71472011-04-06 Chong Yidong <cyd@stupidchicken.com>
7148
04f2d78b
CB
7149 * process.c (Flist_processes): Remove to Lisp.
7150 (list_processes_1): Delete.
e67a13ab 7151
973f782d
EZ
71522011-04-06 Eli Zaretskii <eliz@gnu.org>
7153
7c106b1e
EZ
7154 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7155
973f782d
EZ
7156 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7157
41cf7d1a 71582011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7159
ca23cc88
PE
7160 Fix more problems found by GCC 4.6.0's static checks.
7161
f390e2d5
PE
7162 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7163
42eea0d0
PE
7164 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7165
b69769da 7166 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7167
f9541e84
PE
7168 * xdisp.c (vmessage): Mark as a printf-like function.
7169
13841b55
PE
7170 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7171
c136c10f
PE
7172 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7173
5e2d4a30
PE
7174 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7175 printf-like functions.
7176 (tiff_load): Add casts to remove these marks before passing them
7177 to system-supplied API.
7178
583f48b9
PE
7179 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7180
b25d760e
PE
7181 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7182 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7183 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7184 directly, rather than having caller test rule sign. This avoids
7185 some unnecessary tests.
7186 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7187 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7188 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7189
bc7b6697 7190 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7191 (xfont_open): Avoid unnecessary tests.
bc7b6697 7192
27ccc379
PE
7193 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7194
dcd5c89a
PE
7195 * composite.h, composite.c (composition_gstring_put_cache):
7196 Use EMACS_INT, not int, for length.
7197
b13a45c6
PE
7198 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7199 breaking out part of COMPOSITION_DECODE_RULE.
7200 (COMPOSITION_DECODE_RULE): Use it.
7201 * composite.c (get_composition_id): Remove unused local vars,
7202 by using the new macro.
7203
1e792e4d
PE
7204 * textprop.c (set_text_properties_1): Change while to do-while,
7205 since the condition is always true at first.
7206
dc6c6455 7207 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7208 (interval_deletion_adjustment): Return unsigned value.
7209 All uses changed.
dc6c6455 7210
aba7731a
PE
7211 * process.c (list_processes_1, create_pty, read_process_output):
7212 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7213 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7214 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7215 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7216 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7217
fdfc4bf3
PE
7218 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7219
fca8fe46 7220 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7221 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7222
06a0259a 7223 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7224 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7225 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7226
e7b9e80f
PE
7227 * print.c (print_error_message): Avoid int overflow.
7228
56201685
PE
7229 * font.c (font_list_entities): Redo for clarity,
7230 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7231
78834453 7232 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7233 (font_score): Avoid potential overflow in diff calculation.
78834453 7234
0bc0b309 7235 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7236 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7237
e610eaca
PE
7238 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7239
b895abce
PE
7240 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7241 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7242 can always succeed if overflow has undefined behavior.
7243
1f1d9321 7244 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7245 (wordify): Omit three unnecessary tests.
1f1d9321 7246
c59478bc
PE
7247 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7248 All callers changed. This avoids the need for an unused var.
7249
79b73827
PE
7250 * casefiddle.c (casify_region): Remove var that is set but not used.
7251
a4db5dfe
PE
7252 * dired.c (file_name_completion): Remove var that is set but not used.
7253
43aae36e
PE
7254 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7255
2a47c44d 7256 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7257 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7258
a37c69bf
PE
7259 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7260 Check for integer overflow on size calculations.
7261
328ab8e7
PE
7262 * buffer.c (Fprevious_overlay_change): Remove var that is set
7263 but not used.
7264
e5a2a5cb
PE
7265 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7266 Remove vars that are set but not used.
8d84a6eb 7267 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7268 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7269
a60e5f68
PE
7270 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7271
f661cb61 7272 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7273 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7274
f0397f5a
PE
7275 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7276 that are set but not used.
7277
8664db06 7278 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7279 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7280
6abdaa4a
PE
7281 * xselect.c (x_get_local_selection, x_handle_property_notify):
7282 Remove vars that are set but not used.
7283
0ce7538d 7284 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7285 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7286
9ae848fc
PE
7287 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7288 Remove var that is set but not used.
0b918413
PE
7289 (scroll_bar_windows_size): Now size_t, not int.
7290 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7291 Check for overflow.
9ae848fc 7292
a5a62657
PE
7293 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7294 (map_tty_color) [!defined MSDOS]: Likewise.
7295
5c5cdd39
PE
7296 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7297
66ebf983
PE
7298 * coding.c: Remove vars that are set but not used.
7299 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7300 All callers changed.
7301 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7302 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7303 (decode_coding_charset): Remove vars that are set but not used.
7304
1be4d761
PE
7305 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7306 that is set but not used.
7307
47553fa8
PE
7308 * print.c (print_object): Remove var that is set but not used.
7309
1f7196bf 7310 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7311 The gnulib version avoids calling malloc in the usual case,
7312 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7313 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7314 * filelock.c (current_lock_owner): Likewise.
7315 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7316 * sysdep.c: Include allocator.h, careadlinkat.h.
7317 (emacs_no_realloc_allocator): New static constant.
7318 (emacs_readlink): New function.
fdb61804
PE
7319 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7320 ../lib/careadlinkat.h.
d1fdcab7 7321
f84c17c7
SM
73222011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7323
7324 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7325 first non-nil return value).
7326
ef3862ad
JD
73272011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7328
7329 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7330 if not defined (Bug#8403).
7331
376a7006
JB
73322011-04-02 Juanma Barranquero <lekktu@gmail.com>
7333
7334 * xdisp.c (display_count_lines): Remove parameter `start',
7335 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7336 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7337 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7338 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7339 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7340 and thereabouts. All callers changed.
7341 (get_per_char_metric): Remove parameter `f', unused since
7342 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7343
6ca3801d
JM
73442011-04-02 Jim Meyering <meyering@redhat.com>
7345
7346 do not dereference NULL upon failed strdup
7347 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7348 (ns_get_family): Likewise.
7349
d8e2b5ba
JB
73502011-04-02 Juanma Barranquero <lekktu@gmail.com>
7351
7352 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7353
8c74fcbd
JD
73542011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7355
7356 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7357 later (Bug#8403).
7358
7200d79c
SM
73592011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7360
03408648 7361 Add lexical binding.
7200d79c 7362
03408648
SM
7363 * window.c (Ftemp_output_buffer_show): New fun.
7364 (Fsave_window_excursion):
7365 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7366
7367 * lread.c (lisp_file_lexically_bound_p): New function.
7368 (Fload): Bind Qlexical_binding.
7369 (readevalloop): Remove `evalfun' arg.
7370 Bind Qinternal_interpreter_environment.
7371 (Feval_buffer): Bind Qlexical_binding.
7372 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7373 Mark as dynamic.
7374 (syms_of_lread): Declare `lexical-binding'.
7375
7376 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7377
7378 * keyboard.c (eval_dyn): New fun.
7379 (menu_item_eval_property): Use it.
ca105506
SM
7380
7381 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7382
03408648
SM
7383 * fns.c (concat, mapcar1): Accept byte-code-functions.
7384
7385 * eval.c (Fsetq): Handle lexical vars.
7386 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7387 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7388 (FletX, Flet): Obey lexical binding.
7389 (Fcommandp): Handle closures.
7390 (Feval): New `lexical' arg.
7391 (eval_sub): New function extracted from Feval. Use it almost
7392 everywhere where Feval was used. Look up vars in lexical env.
7393 Handle closures.
7394 (Ffunctionp): Move from subr.el.
7395 (Ffuncall): Handle closures.
7396 (apply_lambda): Remove `eval_flags'.
7397 (funcall_lambda): Handle closures and new byte-code-functions.
7398 (Fspecial_variable_p): New function.
7399 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7400 but without exporting it to Lisp.
23aba0ea 7401
23aba0ea 7402 * doc.c (Fdocumentation, store_function_docstring):
03408648 7403 * data.c (Finteractive_form): Handle closures.
23aba0ea 7404
03408648
SM
7405 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7406 interactive spec.
ba83908c 7407
04f2d78b
CB
7408 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7409 New byte-codes.
03408648
SM
7410 (exec_byte_code): New function extracted from Fbyte_code to handle new
7411 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7412
03408648 7413 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7414
03408648 7415 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7416
e2abce01
JB
74172011-03-31 Juanma Barranquero <lekktu@gmail.com>
7418
7419 * xdisp.c (redisplay_internal): Fix prototype.
7420
63696a73 74212011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7422
63696a73 7423 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7424 (try_scrolling): Use it when setting scroll_limit.
7425 Limit scrolling to 100 screen lines.
63696a73
EZ
7426 (redisplay_window): Even when falling back on "recentering",
7427 position point in the window according to scroll-conservatively,
7428 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7429
7430 (try_scrolling): When point is above the window, allow searching
7431 as far as scroll_max, or one screenful, to compute vertical
7432 distance from PT to the scroll margin position. This prevents
7433 try_scrolling from unnecessarily failing when
7434 scroll-conservatively is set to a value slightly larger than the
7435 window height. Clean up the case of PT below the margin at bottom
7436 of window: scroll_max can no longer be INT_MAX. When aggressive
7437 scrolling is in use, don't let point enter the opposite scroll
7438 margin as result of the scroll.
7439 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7440 threshold of 100 lines for never-recentering scrolling.
7441
e4cc2dfc
JB
74422011-03-31 Juanma Barranquero <lekktu@gmail.com>
7443
7444 * dispextern.h (move_it_by_lines):
7445 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7446 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7447 (message_log_check_duplicate): Remove parameters `prev_bol' and
7448 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7449 (redisplay_internal): Remove parameter `preserve_echo_area',
7450 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7451
7452 * indent.c (Fvertical_motion):
7453 * window.c (window_scroll_pixel_based, Frecenter):
7454 Don't pass `need_y_p' to `move_it_by_lines'.
7455
1c470562
SM
74562011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7457
44f230aa
SM
7458 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7459 steal a few bits to be more compact.
7460 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7461 Remove unneeded casts.
7462
1c470562
SM
7463 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7464
888adce9
ZK
74652011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7466
7467 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7468 binding" message (bug#7967).
7469
f838ed7b
PE
74702011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7471
77861b95
PE
7472 Fix more problems found by GCC 4.6.0's static checks.
7473
de6dbc14
PE
7474 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7475 Remove unused local var.
7476
f838ed7b
PE
7477 * editfns.c (Fmessage_box): Remove unused local var.
7478
792c7b2b
PE
7479 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7480 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7481 Omit unused local vars.
c499e557 7482 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7483 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7484 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7485 Omit unused local var.
7486
ba0165e1
PE
7487 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7488 Don't assume string length fits in int.
32ad8845 7489 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7490 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7491
3c59b4c9
PE
7492 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7493 instead of alloca (Bug#8344).
7494
a3eed478 7495 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7496 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7497
eb4d412d
PE
7498 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7499
1658b401
PE
7500 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7501 concerns.
7502
7503 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7504
7505 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7506
9a2c6e05
PE
7507 * keyboard.c (syms_of_keyboard): Use the same style as later
7508 in this function when indexing through an array. This also
7509 works around GCC bug 48267.
7510
03d0a109
PE
7511 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7512
44f730c8
PE
7513 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7514
fe75f926
PE
7515 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7516 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7517
ffa8c828
PE
7518 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7519 This avoids undefined behavior on integer overflow, and is a bit
7520 more convenient anyway since it is compared to a size_t variable.
7521
c5101a77
PE
7522 Variadic C functions now count arguments with size_t, not int.
7523 This avoids an unnecessary limitation on 64-bit machines, which
7524 caused (substring ...) to crash on large vectors (Bug#8344).
7525 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7526 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7527 All variadic functions and their callers changed accordingly.
c5101a77
PE
7528 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7529 * data.c (arith_driver, float_arith_driver): Likewise.
7530 * editfns.c (general_insert_function): Likewise.
7531 * eval.c (struct backtrace.nargs, interactive_p)
7532 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7533 (funcall_lambda, mark_backtrace): Likewise.
7534 * fns.c (concat): Likewise.
7535 * frame.c (x_set_frame_parameters): Likewise.
7536 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7537 0 if not found, not -1. All callers changed.
7538
dd3f25f7
PE
7539 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7540 (stack_copy_size): Now size_t, not int.
7541 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7542
461c2ab9
JB
75432011-03-28 Juanma Barranquero <lekktu@gmail.com>
7544
7545 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7546 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7547 All callers changed.
7548
7549 * lisp.h (multibyte_char_to_unibyte):
7550 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7551 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7552 * character.h (CHAR_TO_BYTE8):
7553 * cmds.c (internal_self_insert):
7554 * editfns.c (general_insert_function):
7555 * keymap.c (push_key_description):
7556 * search.c (Freplace_match):
7557 * xdisp.c (message_dolog, set_message_1): All callers changed.
7558
f6d62986
SM
75592011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7560
7561 * keyboard.c (safe_run_hook_funcall): New function.
7562 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7563 don't set the hook to nil, but remove the offending function instead.
7564 (Qcommand_hook_internal): Remove, unused.
7565 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7566 Vcommand_hook_internal.
7567
7568 * eval.c (enum run_hooks_condition): Remove.
7569 (funcall_nil, funcall_not): New functions.
7570 (run_hook_with_args): Call each function through a `funcall' argument.
7571 Remove `cond' argument, now redundant.
7572 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7573 (Frun_hook_with_args_until_failure): Adjust accordingly.
7574 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7575
1db5b1ad
JB
75762011-03-28 Juanma Barranquero <lekktu@gmail.com>
7577
7578 * dispextern.h (string_buffer_position): Remove declaration.
7579
7580 * print.c (strout): Remove parameter `multibyte', unused since
7581 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7582
7583 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7584 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7585 All callers changed.
7586
7587 * w32.c (_wsa_errlist): Use braces for struct initializers.
7588
7589 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7590 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7591 All callers changed.
7592 (string_buffer_position): Likewise. Also, make static (it's never
7593 used outside xdisp.c).
7594 (cursor_row_p): Remove parameter `w', unused since
7595 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7596 (decode_mode_spec): Remove parameter `precision', introduced during
7597 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7598 All callers changed.
7599
5ffb62aa
JD
76002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7601
7602 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7603
461c2ab9 76042011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7605
7606 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7607 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7608 (ns_update_auto_hide_menu_bar): New functions.
7609 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7610 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7611 ns_constrain_all_frames.
7612 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7613 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7614
5c380ffb
JD
76152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7616
7617 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7618
9af30bdf
GM
76192011-03-27 Glenn Morris <rgm@gnu.org>
7620
7621 * syssignal.h: Replace RETSIGTYPE with void.
7622 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7623 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7624 Replace SIGTYPE with void everywhere.
7625 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7626 * s/template.h (SIGTYPE): Remove commented out definition.
7627
e2abce01
JB
76282011-03-26 Eli Zaretskii <eliz@gnu.org>
7629
7630 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7631 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7632
f868cd8a
JB
76332011-03-26 Juanma Barranquero <lekktu@gmail.com>
7634
59eb0929
JB
7635 * w32.c (read_unc_volume): Use parameter `henum', instead of
7636 global variable `wget_enum_handle'.
7637
7638 * keymap.c (describe_vector): Remove parameters `indices' and
7639 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7640 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7641
f868cd8a
JB
7642 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7643
7644 * keyboard.c (timer_check): Remove parameter `do_it_now',
7645 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7646 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7647 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7648
7649 * keyboard.c (read_char):
7650 * w32menu.c (w32_menu_display_help):
7651 * xmenu.c (show_help_event, menu_help_callback):
7652 Adjust calls to `show_help_echo'.
7653
7654 * gtkutil.c (xg_maybe_add_timer):
7655 * keyboard.c (readable_events):
7656 * process.c (wait_reading_process_output):
7657 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7658
7659 * insdel.c (adjust_markers_gap_motion):
7660 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7661 (gap_left, gap_right): Don't call it.
7662
2ecf6fdb
CY
76632011-03-25 Chong Yidong <cyd@stupidchicken.com>
7664
7665 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7666 incurred during fontification.
7667
6b1f9ba4
JB
76682011-03-25 Juanma Barranquero <lekktu@gmail.com>
7669
7670 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7671 (DEFVAR_PER_BUFFER): Don't pass it.
7672
7673 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7674 (scrolling_window): Don't pass it.
7675
0f4a96b5
JB
76762011-03-25 Juanma Barranquero <lekktu@gmail.com>
7677
7678 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7679
7680 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7681 and `suffix'.
7682 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7683 of variables specific to SELinux and computation of `encoded_absname'.
7684
7685 * image.c (XPutPixel): Remove unused variable `height'.
7686
7687 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7688
7689 * unexw32.c (get_section_info): Remove unused variable `section'.
7690
7691 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7692 (system_process_attributes): Remove unused variable `sess'.
7693 (sys_read): Remove unused variable `err'.
7694
7695 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7696 (w32_wnd_proc): Remove unused variable `isdead'.
7697 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7698 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7699 (x_create_tip_frame): Remove unused variable `tem'.
7700
7701 * w32inevt.c (w32_console_read_socket):
7702 Remove unused variable `no_events'.
7703
7704 * w32term.c (x_draw_composite_glyph_string_foreground):
7705 Remove unused variable `width'.
7706
1149507c
JB
77072011-03-24 Juanma Barranquero <lekktu@gmail.com>
7708
7709 * w32term.c (x_set_glyph_string_clipping):
7710 Don't pass uninitialized region to CombineRgn.
7711
9c88f339
JB
77122011-03-23 Juanma Barranquero <lekktu@gmail.com>
7713
7714 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7715 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7716 (Fx_close_connection): Remove unused variable `i'.
7717
7718 * w32font.c (w32font_draw): Return number of glyphs.
7719 (w32font_open_internal): Remove unused variable `i'.
7720 (w32font_driver): Add missing initializer.
7721
7722 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7723 (fill_in_menu): Remove unused variable `items_added'.
7724
7725 * w32term.c (last_mouse_press_frame): Remove static global variable.
7726 (w32_clip_to_row): Remove unused variable `f'.
7727 (x_delete_terminal): Remove unused variable `i'.
7728
7729 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7730 (NOTHING): Remove unused static global variable.
7731 (uniscribe_check_otf): Remove unused variable `table'.
7732 (uniscribe_font_driver): Add missing initializers.
7733
dee091a3
JD
77342011-03-23 Julien Danjou <julien@danjou.info>
7735
7736 * term.c (Fsuspend_tty, Fresume_tty):
7737 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7738 * window.c (temp_output_buffer_show):
7739 * insdel.c (signal_before_change):
7740 * frame.c (Fhandle_switch_frame):
7741 * fileio.c (Fdo_auto_save):
7742 * emacs.c (Fkill_emacs):
7743 * editfns.c (save_excursion_restore):
7744 * cmds.c (internal_self_insert):
7745 * callint.c (Fcall_interactively):
7746 * buffer.c (Fkill_all_local_variables):
7747 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7748 Use Frun_hooks.
0f4a96b5 7749 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7750 unconditionally since it does the check itself.
dee091a3 7751
2c520ab5 77522011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7753
c9c49752
PE
7754 Fix more problems found by GCC 4.5.2's static checks.
7755
8abc3f12
PE
7756 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7757 the first time through the loop, since we know p0 < p1 then.
7758 This also avoids a gcc -Wstrict-overflow warning.
7759
a2d26660
PE
7760 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7761 leading to a memory leak, possible in functions like
7762 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7763 of objects (Bug#8318).
a2d26660 7764
916c72e9
PE
7765 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7766 that could (at least in theory) be that large.
7767
19ab8a18
PE
7768 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7769 This is less likely to overflow, and avoids undefined behavior if
7770 overflow does occur. All callers changed. Use strtoul to scan
7771 for the unsigned long integer.
b7cbbd6f
PE
7772 (pint2hrstr): Simplify and tune code slightly.
7773 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7774
f0641eff
PE
7775 * scroll.c (do_scrolling): Work around GCC bug 48228.
7776 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7777
7f650bb9
PE
7778 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7779 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7780 (validate_x_resource_name): Simplify count usage.
7781 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7782
37dd57d1
PE
7783 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7784 fail (Bug#8306).
81e56e61 7785
699979fc 7786 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7787
401bf9b4
PE
7788 * process.c (Fmake_network_process): Use socklen_t, not int,
7789 where POSIX says socklen_t is required in portable programs.
7790 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7791 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7792 (Fmake_network_process, server_accept_connection):
7793 (wait_reading_process_output, read_process_output):
7794 Likewise.
7795
b93aacde
PE
7796 * process.c: Rename or move locals to avoid shadowing.
7797 (list_processes_1, Fmake_network_process):
7798 (read_process_output_error_handler, exec_sentinel_error_handler):
7799 Rename or move locals.
4dc343ee 7800 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7801 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7802 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7803 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7804 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7805
af8a867c 7806 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7807 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7808 Include tparam.h instead, since it declares them.
af8a867c
PE
7809 * cm.h (PC): Remove extern decl; tparam.h now does this.
7810 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7811 * terminfo.c: Include tparam.h, to check interfaces.
7812 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7813 (tparam): Adjust signature to match interface in tparam.h;
7814 this removes some undefined behavior. Check that outstring and len
7815 are zero, which they always are with Emacs.
7816 * tparam.h (PC, BC, UP): New extern decls.
7817
0248044d 7818 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7819 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7820
8ff096c1 7821 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7822 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7823 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7824 (ftfont_list): Remove unused local.
49eaafba
PE
7825 (get_adstyle_property, ftfont_pattern_entity):
7826 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7827 Rename locals to avoid shadowing.
8ff096c1 7828
e2be39f6
PE
7829 * xfont.c (xfont_list_family): Mark var as initialized.
7830
c9735e30
PE
7831 * xml.c (make_dom): Now static.
7832
8f5201ae
PE
7833 * composite.c (composition_compute_stop_pos): Rename local to
7834 avoid shadowing.
b246f932
PE
7835 (composition_reseat_it): Remove unused locals.
7836 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7837 (composition_update_it): Mark var as initialized.
11b61122
PE
7838 (find_automatic_composition): Mark vars as initialized,
7839 with a FIXME (Bug#8290).
8f5201ae 7840
760fbc2c
PE
7841 character.h: Rename locals to avoid shadowing.
7842 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7843 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7844 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7845 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7846 to avoid shadowing.
7847
ff08eb85
PE
7848 * textprop.c (property_change_between_p): Remove; unused.
7849
fc7bf025
PE
7850 * intervals.c (interval_start_pos): Now static.
7851
235d7abc
PE
7852 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7853
44f230aa
SM
7854 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7855 Rename locals to avoid shadowing.
3e7d6594 7856
50060332
PE
7857 * sound.c (wav_play, au_play, Fplay_sound_internal):
7858 Fix pointer signedness.
d01f234b 7859 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7860 (wav_play): Initialize a variable to 0, to prevent undefined
7861 behavior (Bug#8278).
50060332 7862
c4fc4e30
PE
7863 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7864
918436ed
PE
7865 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7866
c939f91b
PE
7867 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7868 clobbering (Bug#8298).
b9c7f648
PE
7869 * sysdep.c (sys_subshell): Likewise.
7870 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7871
6bd8c144
PE
7872 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7873 This should get cleaned up, so that child_setup has the
7874 same signature on all platforms.
7875
7710357c 7876 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7877 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7878
c59da222
CY
78792011-03-22 Chong Yidong <cyd@stupidchicken.com>
7880
7881 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7882 not to be necessary, and produces flickering.
7883
66b87493
GM
78842011-03-20 Glenn Morris <rgm@gnu.org>
7885
7886 * config.in: Remove file.
7887
45b6f6d5
JB
78882011-03-20 Juanma Barranquero <lekktu@gmail.com>
7889
7890 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7891 are now in src/globals.h.
7892 (syms_of_minibuf): Remove spurious & from previous change.
7893
3ec03f7e
LL
78942011-03-20 Leo <sdl.web@gmail.com>
7895
7896 * minibuf.c (completing-read-function): New variable.
7897 (completing-read-default): Rename from completing-read.
7898 (completing-read): Call completing-read-function.
7899
b14e3e21
CY
79002011-03-19 Juanma Barranquero <lekktu@gmail.com>
7901
7902 * xfaces.c (Fx_load_color_file):
7903 Read color file from absolute filename (bug#8250).
7904
f2b726e6
JB
79052011-03-19 Juanma Barranquero <lekktu@gmail.com>
7906
7907 * makefile.w32-in: Update dependencies.
7908
09f6ff02
EZ
79092011-03-17 Eli Zaretskii <eliz@gnu.org>
7910
7911 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7912
29a6015a
PE
79132011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7914
a3a6c54e
PE
7915 Fix more problems found by GCC 4.5.2's static checks.
7916
b766f867
PE
7917 * process.c (make_serial_process_unwind, send_process_trap):
7918 (sigchld_handler): Now static.
7919
be02381c
PE
7920 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7921 That way, the code declares only the vars that it needs.
7922 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7923 * s/cygwin.h (PTY_ITERATION): Likewise.
7924 * s/darwin.h (PTY_ITERATION): Likewise.
7925 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7926
57048744
PE
7927 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7928 * process.c (allocate_pty): Don't declare stb unless it's needed.
7929
7914961c 7930 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7931 (CONSTANTLIM): Remove; unused.
7932 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7933 Define only if needed.
7914961c 7934
b3967b18
PE
7935 * unexelf.c (unexec): Name an expression,
7936 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7937 Use a different way to cause a compilation error if anyone uses
7938 n rather than nn, a way that does not involve shadowing.
73366a00 7939 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7940
29a6015a
PE
7941 * deps.mk (unexalpha.o): Remove; unused.
7942
43cfc33e 7943 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7944 * unexec.h: New file.
ce701a33
PE
7945 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7946 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7947 Depend on unexec.h.
7948 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7949 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7950 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7951 Change as necessary to match prototype in unexec.h.
ce701a33 7952
01f44d5a
PE
7953 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7954 shadowing.
4f63c6bb 7955 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7956
a6670b0b
PE
7957 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7958 Rename locals to avoid shadowing.
7959
cef2010d 7960 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7961 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7962
d4d7173a
PE
7963 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7964
f08b802a
PE
7965 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7966 warning when compiling print.c.
7967
3ddb0639
PE
7968 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7969 instead of using an uninitialized var.
5ad03b97 7970 (font_sort_entities): Mark var as initialized.
3ddb0639 7971
170a2692
PE
7972 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7973
e663c700
PE
7974 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7975 pointers to constants.
89bc529a 7976 (font_parse_fcname): Remove unused vars.
7b81e2d0 7977 (font_delete_unmatched): Now static.
ea838e10 7978 (font_get_spec): Remove; unused.
13a547c6
PE
7979 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7980 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7981 Rename or move locals to avoid shadowing.
e663c700 7982
2a80c887 7983 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7984 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7985
1384fa33 7986 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7987 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7988
8b2c52e9
PE
7989 * alloc.c (mark_backtrace): Move decl from here ...
7990 * lisp.h: ... to here, so that it can be checked.
7991
475545b5 7992 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7993 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7994 (lisp_indirect_variable): Name an expression,
7995 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7996 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7997
b1349114 7998 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7999 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8000 Use const pointer when appropriate.
b1349114 8001
a2928364
PE
8002 * lisp.h (get_system_name, get_operating_system_release):
8003 Move decls here, to check interfaces.
8004 * process.c (get_operating_system_release): Move decl to lisp.h.
8005 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8006 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8007 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8008 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8009 (Fformat_time_string, Fencode_time, Finsert_char):
8010 (Ftranslate_region_internal, Fformat):
8011 Rename or remove local vars to avoid shadowing.
9710023e 8012 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8013
a415e694
PE
8014 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8015 avoid shadowing.
8016
8ef4622d
PE
8017 * lisp.h (eassert): Check that the argument compiles, even if
8018 ENABLE_CHECKING is not defined.
8019
946f9a5b
PE
8020 * data.c (Findirect_variable): Name an expression, to avoid
8021 gcc -Wbad-function-cast warning.
112396d6 8022 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8023 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8024 (Fmake_variable_buffer_local, Fmake_local_variable):
8025 Mark variables as initialized.
52746918 8026 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8027
e5aab7e7 8028 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8029 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8030 Rename locals to avoid shadowing.
dff45157
PE
8031 (mark_stack): Move local variables into the #ifdef region where
8032 they're used.
7bc26fdb
PE
8033 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8034 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8035 needed otherwise.
8036 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8037 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8038 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8039
e5aab7e7
PE
8040 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8041 avoids undefined behavior in theory.
8042
4da60324
PE
8043 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8044
88043301
PE
8045 Use functions, not macros, for up- and down-casing (Bug#8254).
8046 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8047 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8048 to use the following functions instead of these macros.
8049 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8050 EMACS_INT, since callers assume the returned value fits in int.
8051 (upcase1): Likewise, for UPCASE_TABLE.
8052 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8053 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8054 the race-condition problem in the old DOWNCASE.
88043301 8055
19ed5445
PE
8056 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8057 Rename locals to avoid shadowing.
8058 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8059 (regex_compile, re_search_2, re_match_2_internal):
8060 Remove unused local vars.
952db0d7
PE
8061 (FREE_VAR): Rewrite so as not to use empty "else",
8062 which gcc can warn about.
da053e48 8063 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8064 (RETALLOC_IF): Define only if needed.
8065 (WORDCHAR_P): Likewise. This one is never needed, but is used
8066 only in a comment talking about a compiler bug, so put inside
8067 the #if 0 of that comment.
8068 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8069 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8070 Remove; unused.
19ed5445 8071
1f3561e4 8072 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8073 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8074 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8075
ded6f8f7
PE
8076 * search.c (simple_search): Remove unused var.
8077
dbd37a95
PE
8078 * dired.c (compile_pattern): Move decl from here ...
8079 * lisp.h: ... to here, so that it can be checked.
8080 (struct re_registers): New forward decl.
8081
7e47afad
PE
8082 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8083
85f24f61
PE
8084 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8085 All uses changed.
8086 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8087 Rename locals to avoid shadowing.
5671df8f 8088 (Fvertical_motion): Mark locals as initialized.
85f24f61 8089
181aa2be 8090 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8091 (casify_region): Mark local as initialized.
181aa2be 8092
930d429c
PE
8093 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8094
7082eac6
PE
8095 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8096 New macros, so that the caller can use some names other than
8097 gcpro1, gcpro2, etc.
8098 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8099 of the new macros.
8100 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8101 argument, for consistency with GCPRO2_VAR, etc: it is now the
8102 prefix of the variable, not the variable itself. All uses
8103 changed.
38b2c076
PE
8104 * dired.c (directory_files_internal, file_name_completion):
8105 Rename locals to avoid shadowing.
8106
15206ed9
PE
8107 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8108 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8109 dired.c's scmp function, had undefined behavior.
8110 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8111 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8112 * buffer.h: ... to here, because these macros use current_buffer,
8113 and the new implementation with inline functions needs to have
8114 current_buffer in scope now, rather than later when the macros
8115 are used.
8116 (downcase, upcase1): New static inline functions.
8117 (DOWNCASE, UPCASE1): Reimplement using these functions.
8118 This avoids undefined behavior in expressions like
8119 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8120 from race conditions in accessing the global variables
8121 case_temp1 and case_temp2.
8122 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8123 * lisp.h (case_temp1, case_temp2): Remove their decls.
8124 * character.h (ASCII_CHAR_P): Move from here ...
8125 * lisp.h: ... to here, so that the inline functions mentioned
8126 above can use them.
8127
4a6bea26
PE
8128 * dired.c (directory_files_internal_unwind): Now static.
8129
f14b7e14
PE
8130 * fileio.c (file_name_as_directory, directory_file_name):
8131 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8132 Now static.
2893f146
PE
8133 (file_name_as_directory): Use const pointers when appropriate.
8134 (Fexpand_file_name): Likewise. In particular, newdir might
8135 point at constant storage, so make it a const pointer.
fd4ead52 8136 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8137 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8138 signedness issues.
f839df0c
PE
8139 (Fset_file_times, Finsert_file_contents, auto_save_error):
8140 Rename locals to avoid shadowing.
f14b7e14 8141
5716756e 8142 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8143 (Ftry_completion, Fall_completions): Rename or remove locals
8144 to avoid shadowing.
5716756e 8145
b4c3046a
PE
8146 * marker.c (bytepos_to_charpos): Remove; unused.
8147
b45db522
PE
8148 * lisp.h (verify_bytepos, count_markers): New decls,
8149 so that gcc does not warn that these functions aren't declared.
8150
85876d07
PE
8151 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8152 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8153 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8154 (copy_text): Remove unused local var.
85876d07 8155
03d78a21 8156 * filelock.c (within_one_second): Now static.
b3dd38ab 8157 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8158
5df8f01b
PE
8159 * buffer.c (fix_overlays_before): Mark locals as initialized.
8160 (fix_start_end_in_overlays): Likewise. This function should be
8161 simplified by using pointers-to-pointers, but that's a different
8162 matter.
b1d876f1 8163 (switch_to_buffer_1): Now static.
8f54f30a
PE
8164 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8165 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8166
a70072c9 8167 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8168 Fix pointer signedness issue.
edced198
PE
8169 (sys_subshell): Mark local as volatile if checking for lint,
8170 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8171 (MAXPATHLEN): Define only if needed.
a70072c9 8172
a0977c44
PE
8173 * process.c (serial_open, serial_configure): Move decls from here ...
8174 * systty.h: ... to here, so that they can be checked.
8175
a884fdcc
PE
8176 * fns.c (get_random, seed_random): Move extern decls from here ...
8177 * lisp.h: ... to here, so that they can be checked.
8178
604efe86 8179 * sysdep.c (reset_io): Now static.
b8950c94 8180 (wait_for_termination_signal): Remove; unused.
604efe86 8181
38fc62d9
PE
8182 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8183 (copy_keymap_item, append_key, push_text_char_description):
8184 Now static.
1004a21a 8185 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8186 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8187 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8188 (describe_map_tree):
8189 Rename locals to avoid shadowing.
38fc62d9 8190
2f2650da
PE
8191 * keyboard.c: Declare functions static if they are not used elsewhere.
8192 (echo_char, echo_dash, cmd_error, top_level_2):
8193 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8194 (read_char, kbd_buffer_get_event, make_lispy_position):
8195 (make_lispy_event, make_lispy_movement, apply_modifiers):
8196 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8197 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8198 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8199 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8200 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8201
a053e86c 8202 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8203 (mark_kboards): Move decl here ...
8204 * alloc.c (mark_kboards): ... from here.
a053e86c 8205
4752793e
PE
8206 * lisp.h (force_auto_save_soon): New decl.
8207
74f10ca7 8208 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8209 (DEFINE_DUMMY_FUNCTION): New macro.
8210 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8211 Use it.
c03cd23f
PE
8212 (main): Add casts to avoid warnings
8213 if GCC considers string literals to be constants.
74f10ca7 8214
022e70d4
PE
8215 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8216
59d6fe83
PE
8217 * dbusbind.c: Pointer signedness fixes.
8218 (xd_signature, xd_append_arg, xd_initialize):
8219 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8220 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8221 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8222 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8223
78320123
PE
8224 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8225 if GCC considers string literals to be constants.
49cebcca 8226 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8227
35ac2a97
SM
82282011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8229
fb103ca9
SM
8230 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8231 (print_preprocess, print_object): New macro to fix last change.
8232
35ac2a97
SM
8233 * print.c (print_preprocess): Don't forget font objects.
8234
62973b41
JB
82352011-03-16 Juanma Barranquero <lekktu@gmail.com>
8236
8237 * emacs.c (USAGE3): Doc fixes.
8238
0e48bb22
AS
82392011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8240
8241 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8242 structure.
8243
7684e57b
JB
82442011-03-14 Juanma Barranquero <lekktu@gmail.com>
8245
8246 * lisp.h (VWindow_system, Qfile_name_history):
8247 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8248 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8249 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8250
8251 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8252 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8253
8254 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8255 * w32console.c (detect_input_pending, read_input_pending)
8256 (encode_terminal_code):
8257 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8258 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8259 (w32_system_caret_y, Qfile_name_history):
8260 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8261 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8262 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8263 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8264 * w32proc.c (Qlocal, report_file_error):
8265 * w32term.c (Vwindow_system, updating_frame):
8266 * w32uniscribe.c (initialized, uniscribe_font_driver):
8267 Remove unneeded extern declarations.
8268
2aa46d6c
CY
82692011-03-14 Chong Yidong <cyd@stupidchicken.com>
8270
c96bbc66 8271 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8272
cffc6f3b
CY
82732011-03-13 Chong Yidong <cyd@stupidchicken.com>
8274
8275 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8276 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8277 These macros can no longer be used for assignment.
8278
44f230aa
SM
8279 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8280 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8281 (record_buffer_markers, fetch_buffer_markers): New functions for
8282 recording and fetching special buffer markers.
8283 (set_buffer_internal_1, set_buffer_temp): Use them.
8284
8285 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8286
8287 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8288
8289 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8290 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8291
8292 * xdisp.c (hscroll_window_tree):
8293 (reconsider_clip_changes): Use PT instead of BUF_PT.
8294
d251f04b
EZ
82952011-03-13 Eli Zaretskii <eliz@gnu.org>
8296
8297 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8298 $(EMACS_ROOT)/lib/intprops.h.
8299
f0c77cd1
PE
83002011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8301
3eca4629
PE
8302 Fix more problems found by GCC 4.5.2's static checks.
8303
7c86ee98
PE
8304 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8305 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8306 (xg_free_frame_widgets): Make it clear that a local variable is
8307 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8308 (gdk_window_get_screen): Make it clear that this macro is needed
8309 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8310 (int_gtk_range_get_value): New function, which avoids a diagnostic
8311 from gcc -Wbad-function-cast.
8312 (xg_set_toolkit_scroll_bar_thumb): Use it.
8313 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8314 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8315 (get_utf8_string, xg_get_file_with_chooser):
8316 Rename locals to avoid shadowing.
8317 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8318
41729b81
PE
8319 * xgselect.c (xg_select): Remove unused var.
8320
f0c77cd1
PE
8321 * image.c (four_corners_best): Mark locals as initialized.
8322 (gif_load): Initialize transparent_p to zero (Bug#8238).
8323 Mark another local as initialized.
ec6cf4c6 8324 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8325
ce0ad53d 8326 * image.c (clear_image_cache): Now static.
d5d5a617 8327 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8328 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8329 (x_edge_detection): Remove unnecessary cast that
8330 gcc -Wbad-function-cast diagnoses.
2037898d 8331 (gif_load): Fix pointer signedness.
6ae141d6
PE
8332 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8333 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8334
33383987 83352011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8336
d32df629
PE
8337 Improve quality of tests for time stamp overflow.
8338 For example, without this patch (encode-time 0 0 0 1 1
8339 1152921504606846976) returns the obviously-bogus value (-948597
8340 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8341 reports time overflow. See
8342 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8343 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8344 * editfns.c: Include limits.h and intprops.h.
8345 (TIME_T_MIN, TIME_T_MAX): New macros.
8346 (time_overflow): Move earlier, to before first use.
8347 (hi_time, lo_time): New functions, for an accurate test for
8348 out-of-range times.
8349 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8350 (Fget_internal_run_time): Don't assume time_t fits in int.
8351 (make_time): Use list2 instead of Fcons twice.
8352 (Fdecode_time): More accurate test for out-of-range times.
8353 (check_tm_member): New function.
8354 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8355 (lisp_time_argument): Don't rely on undefined left-shift and
8356 right-shift behavior when checking for time stamp overflow.
8be6f318 8357
fe31d94c
PE
8358 * editfns.c (time_overflow): New function, refactoring common code.
8359 (Fformat_time_string, Fdecode_time, Fencode_time):
8360 (Fcurrent_time_string): Use it.
8361
8be6f318
PE
8362 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8363 * dired.c (make_time): Move to ...
8364 * editfns.c (make_time): ... here.
8365 * systime.h: Note the move.
8366
09d9db2c 83672011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8368
126bc0dc
YM
8369 * fringe.c (update_window_fringes): Remove unused variables.
8370
c47cbdfd
YM
8371 * unexmacosx.c (copy_data_segment): Also copy __got section.
8372 (Bug#8223)
8373
7ac80be9
EZ
83742011-03-12 Eli Zaretskii <eliz@gnu.org>
8375
c96bbc66 8376 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8377 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8378 Constify `char *' arguments and their references according to
8379 prototypes in tparam.h.
8380
ecb0f94d 8381 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8382
7ac80be9
EZ
8383 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8384 Adapt all references accordingly.
8385
8386 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8387
ef1fd07e
TT
83882011-03-11 Tom Tromey <tromey@redhat.com>
8389
8390 * buffer.c (syms_of_buffer): Remove obsolete comment.
8391
7ef4b50c
EZ
83922011-03-11 Eli Zaretskii <eliz@gnu.org>
8393
8394 * termhooks.h (encode_terminal_code): Declare prototype.
8395
8396 * msdos.c (encode_terminal_code): Don't declare prototype.
8397
8398 * term.c (encode_terminal_code): Now external again, used by
8399 w32console.c and msdos.c.
8400
44f230aa
SM
8401 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8402 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8403
4b1ec863 84042011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8405
1714f52b 8406 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8407
4b1ec863
PE
8408 * fringe.c (update_window_fringes): Mark locals as initialized
8409 (Bug#8227).
8410 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8411
524c7aa6
PE
8412 * alloc.c (mark_fringe_data): Move decl from here ...
8413 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8414 to check its interface.
8415 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8416
a5c0af81 8417 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8418 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8419 (fontset_font): Mark local as initialized.
a9a06e0b 8420 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8421
b4716021
PE
8422 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8423
811e9bac 8424 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8425 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8426 (x_own_selection, Fx_disown_selection_internal): Rename locals
8427 to avoid shadowing.
8428 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8429
7e3ab302
PE
8430 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8431 so that the caller can use some name other than gcpro1.
8432 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8433 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8434 (Fx_backspace_delete_keys_p):
8435 Use them to avoid shadowing, and rename vars to avoid shadowing.
8436 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8437 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8438 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8439 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8440 Remove unused locals.
7e3ab302
PE
8441 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8442 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8443 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8444 macros.
f78faa98 8445
e2b13473
PE
8446 * xterm.h (x_mouse_leave): New decl.
8447
77f23912
PE
8448 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8449 Remove unused functions.
cdf4ba58
PE
8450 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8451 (x_calc_absolute_position): Now static.
7411c686 8452 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8453 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8454 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8455 unless they are used.
38d0b34a
PE
8456 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8457 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8458 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8459 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8460 (x_error_catcher, x_connection_closed, x_error_handler):
8461 (x_error_quitter, xembed_send_message, x_iconify_frame):
8462 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8463 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8464 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8465
44f230aa
SM
8466 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8467 Rename or move locals to avoid shadowing.
6b463e58 8468 (tty_defined_color, merge_face_heights): Now static.
5967d051 8469 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8470 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8471 does not deduce is never used uninitialized.
73719eba
PE
8472 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8473 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8474
426994c3 8475 * terminal.c (store_terminal_param): Now static.
5489860b 8476
032f1620 8477 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8478 (set_frame_menubar): Remove unused local.
d4323972 8479 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8480 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8481 since they might point to immutable storage.
281585b0
PE
8482 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8483 since it's unused otherwise.
032f1620 8484
367c19e5 8485 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8486 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8487 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8488 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8489 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8490 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8491 does not deduce are never used uninitialized.
70739cbe 8492
07b48fa9
PE
8493 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8494
8868a238 8495 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8496 * window.c (window_loop, size_window):
8497 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8498
7e5cf297 8499 * window.c (display_buffer): Now static.
d6550a9f
PE
8500 (size_window): Mark variables that gcc -Wuninitialized
8501 does not deduce are never used uninitialized.
a586633d
PE
8502 * window.h (check_all_windows): New decl, to forestall
8503 gcc -Wmissing-prototypes diagnostic.
5b555da1 8504 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8505
f6095868
PE
8506 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8507 shadowing.
8508 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8509 Include <limits.h>.
8510 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8511 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8512 (load_charset_map): Mark variables that gcc -Wuninitialized
8513 does not deduce are never used uninitialized.
53df7c11 8514 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8515
f38b440c
PE
8516 * coding.c (coding_set_source, coding_set_destination):
8517 Use "else { /* comment */ }" rather than "else /* comment */;"
8518 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8519 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8520 a block, when the outer 'i' will do.
8521 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8522 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8523 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8524 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8525 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8526 Rename locals to avoid shadowing.
8527 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8528 * coding.c (emacs_mule_char, encode_invocation_designation):
8529 Now static, since they're not used elsewhere.
413bb2db 8530 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8531 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8532 (decode_coding_emacs_mule): Mark variables that gcc
8533 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8534 (detect_coding_iso_2022): Initialize a local variable that might
8535 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8536 this initialization is needed. (Bug#8211)
5f58e762
PE
8537 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8538 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8539 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8540 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8541 Remove unused macros.
f38b440c 8542
232b38b9 8543 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8544 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8545 * character.c (string_count_byte8): Likewise.
232b38b9 8546
fb90da1b
PE
8547 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8548 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8549
fb93dbc2
PE
8550 * chartab.c (copy_sub_char_table): Now static, since it's not used
8551 elsewhere.
5c156ace
PE
8552 (sub_char_table_ref_and_range, char_table_ref_and_range):
8553 Rename locals to avoid shadowing.
bbcd0949 8554 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8555
7d3b3862 8556 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8557 (BIDI_BOB): Remove unused macro.
7d3b3862 8558
6be7d3da
PE
8559 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8560 deduce are never used uninitialized.
c2ed9c8b 8561 * term.c (encode_terminal_code): Likewise.
6be7d3da 8562
75f8807f 8563 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8564
50938595
PE
8565 * tparam.h: New file.
8566 * term.c, tparam.h: Include it.
8567 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8568 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8569 Move these decls to tparam.h, and make them agree with what
8570 is actually in tparam.c. The previous trick of using incompatible
8571 decls in different modules does not conform to the C standard.
8572 All callers of tparam changed to use tparam's actual API.
8573 * tparam.c (tparam1, tparam, tgoto):
8574 Use const pointers where appropriate.
8575
fbceeba2
PE
8576 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8577 * cm.h (struct cm): Likewise.
8578 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8579 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8580 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8581 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8582 (turn_on_face, init_tty): Likewise.
8583 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8584
7f3f1250
PE
8585 * term.c (term_mouse_position): Rename local to avoid shadowing.
8586
e6ca6543
PE
8587 * alloc.c (mark_ttys): Move decl from here ...
8588 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8589
c40f8d15
AS
85902011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8591
8592 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8593
cfe0661d
JB
85942011-03-09 Juanma Barranquero <lekktu@gmail.com>
8595
8596 * search.c (compile_pattern_1): Remove argument regp, unused since
8597 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8598 (compile_pattern): Don't pass it.
8599
0afb4571
J
86002011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8601
8602 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8603 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8604 for ! HAVE_GTK3.
8605 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8606
8607 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8608
8609 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8610 gdk_window_get_screen, gdk_window_get_geometry,
8611 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8612 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8613 (xg_get_pixbuf_from_pixmap): New function.
8614 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8615 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8616 Call xg_get_pixbuf_from_pixmap instead of
8617 gdk_pixbuf_get_from_drawable.
8618 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8619 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8620 (xg_check_special_colors): Use GtkStyleContext and its functions
8621 for HAVE_GTK3.
8622 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8623 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8624 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8625 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8626 Call gtk_widget_get_preferred_size.
0afb4571
J
8627 (xg_frame_resized): gdk_window_get_geometry only takes 5
8628 parameters.
44f230aa
SM
8629 (xg_win_to_widget, xg_event_is_for_menubar):
8630 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8631 (xg_set_widget_bg): New function.
8632 (delete_cb): New function.
895009e1 8633 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8634 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8635 (xg_set_background_color): Call xg_set_widget_bg.
8636 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8637 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8638 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8639 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8640 if ! HAVE_GTK3.
8641 (update_frame_tool_bar): Call gtk_widget_hide.
8642 (xg_initialize): Use GDK_KEY_g.
8643
8644 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8645 if ! HAVE_GTK3
8646 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8647
8648 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8649 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8650 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8651
1c2cc4ef
JB
86522011-03-08 Juanma Barranquero <lekktu@gmail.com>
8653
8654 * w32xfns.c (select_palette): Check success of RealizePalette against
8655 GDI_ERROR, not zero.
8656
33383987 8657See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8658
8659;; Local Variables:
8660;; coding: utf-8
aac0c6e3
MR
8661;; End:
8662
33383987 8663 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8664
8665 This file is part of GNU Emacs.
8666
8667 GNU Emacs is free software: you can redistribute it and/or modify
8668 it under the terms of the GNU General Public License as published by
8669 the Free Software Foundation, either version 3 of the License, or
8670 (at your option) any later version.
8671
8672 GNU Emacs is distributed in the hope that it will be useful,
8673 but WITHOUT ANY WARRANTY; without even the implied warranty of
8674 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8675 GNU General Public License for more details.
8676
8677 You should have received a copy of the GNU General Public License
8678 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.