* filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
[bpt/emacs.git] / src / ChangeLog
CommitLineData
62f19c19
PE
12011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 sprintf-related integer and memory overflow issues.
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
2ea16b89
PE
23 * dbusbind.c (xd_signature, Fdbus_register_signal):
24 Do not overrun buffer; instead, report string overflow.
25
9d1df220
PE
26 * dispnew.c (add_window_display_history): Don't overrun buffer.
27 Truncate instead; this is OK since it's just a log.
28
33ef5c64
PE
29 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
30 even if the time zone offset is outlandishly large.
31 Don't mishandle offset == INT_MIN.
32
66c6fdd5
PE
33 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
34 when creating daemon; the previous buffer-overflow check was incorrect.
35
d749b01b
PE
36 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
37 which has the guts of the old verror function.
38
b5cd1905
PE
39 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
40 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
41
5fc295a4 422011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 43
70c60eb2 44 Integer and memory overflow issues (Bug#9196).
726e0ab1 45
d31850da
PE
46 * doc.c (get_doc_string): Rework so that
47 get_doc_string_buffer_size is the actual buffer size, rather than
48 being 1 less than the actual buffer size; this makes xpalloc more
49 convenient.
50
a69fbedb
PE
51 * image.c (x_allocate_bitmap_record, cache_image):
52 * xselect.c (Fx_register_dnd_atom):
53 Simplify previous changes by using xpalloc.
54
fe5c5d37
PE
55 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
56 since either will do and ptrdiff_t is convenient with xpalloc.
57
0065d054
PE
58 * charset.c (charset_table_size)
59 (struct charset_sort_data.priority): Now ptrdiff_t.
60 (charset_compare): Don't overflow if priorities differ greatly.
61 (Fsort_charsets): Don't assume list length fits in int.
62 Check for size-calculation overflow when allocating sort data.
63 (syms_of_charset): Allocate an initial charset table that is
64 just under 64 KiB, to avoid problems with glibc malloc and mmap.
65
66 * cmds.c (internal_self_insert): Check for size-calculation overflow.
67
68 * composite.h (struct composition.glyph_len): Now int, not unsigned.
69 The actual value is always <= INT_MAX, and leaving it unsigned made
70 overflow checking harder.
71
72 * dispextern.h (struct glyph_matrix.rows_allocated)
73 (struct face_cache.size): Now ptrdiff_t, for convenience in use
74 with xpalloc. The values are still always <= INT_MAX.
75
76 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
77
78 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
79 (SAFE_NALLOCA): New macro.
80
81 * region-cache.c (struct boundary.pos, find_cache_boundary)
82 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
83 (set_cache_region, invalidate_region_cache)
84 (revalidate_region_cache, know_region_cache, region_cache_forward)
85 (region_cache_backward, pp_cache):
86 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
87 so that ptrdiff_t * can be passed to xpalloc.
88 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
89 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
90 (pp_cache): Don't assume cache_len fits in int.
91 * region-cache.h: Adjust extern decls to match.
92
93 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
94 EMACS_INT, since either will do, for xpalloc.
95
96 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
97 (xnmalloc, xnrealloc, xpalloc): New functions.
98
726e0ab1
PE
99 * bidi.c (bidi_shelve_header_size): New constant.
100 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
101 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
102
51f30bc5 103 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
104 * buffer.c (overlays_at, overlays_in, record_overlay_string)
105 (overlay_strings):
106 Don't update size of array until after memory allocation succeeds,
107 because xmalloc/xrealloc may not return.
0065d054
PE
108 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
109 now that we have proper integer overflow checking.
110 (record_overlay_string, overlay_strings): Catch overflows when
111 calculating size of overlay_str_buf.
726e0ab1 112
0065d054
PE
113 * callproc.c (Fcall_process): Check for size overflow when
114 calculating size of args2.
115 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
116 Normally we prefer signed values, but sticking with ptrdiff_t would
117 require adding more-complicated checks.
726e0ab1
PE
118
119 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
120 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
121 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 122 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
123
124 * character.c (Fstring): Check for size-calculation overflow.
125
126 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
127 unnecessary integer overflow. Check for size overflow.
128 (encode_coding_object): Don't update size until xmalloc succeeds.
129
130 * composite.c (get_composition_id): Check for overflow in glyph
131 length calculations.
132
133 Integer and memory overflow fixes for display code.
134 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
135 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
136 (scrolling_window): Check for overflow in size calculations.
137 (line_draw_cost, realloc_glyph_pool, add_row_entry):
138 Don't assume glyph table len fits in int.
139 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
140 (row_table_size): Now ptrdiff_t, not int.
141 (scrolling_window): Avoid overflow in size calculations.
142 Don't update size until allocation succeeds.
143 * fns.c (concat): Check for overflow in size calculations.
144 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
145 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
146 (NEXT_ALMOST_PRIME_LIMIT): New constant.
147
148 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
149 (get_doc_string): Check for size calculation overflow.
150 Don't update size until allocation succeeds.
151 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
152 EMACS_INT, where ptrdiff_t will do.
153 (Fsubstitute_command_keys): Check for string overflow.
154
155 * editfns.c (set_time_zone_rule): Don't assume environment length
156 fits in int.
157 (message_length): Now ptrdiff_t, not int.
158 (Fmessage_box): Don't update size until allocation succeeds.
159 Don't assume message length fits in int.
160 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
161
0065d054
PE
162 * emacs.c (main): Do not reallocate argv, since there is a null at
163 the end that can be overwritten, and this way there's no need to
164 worry about size-calculation overflow.
165 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
166
167 * eval.c (init_eval_once, grow_specpdl): Don't update size until
168 alloc succeeds.
169 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
170
171 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
172 (x_set_scroll_bar_width, x_figure_window_size):
173 Check for integer overflow.
174 (x_set_alpha): Do not assume XINT fits in int.
175
176 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
177 This is for the members text_lines, text_cols, total_lines, total_cols,
178 where the system imposes an 'int' limit.
179
180 * fringe.c (Fdefine_fringe_bitmap):
181 Don't update size until alloc works.
182
183 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
184 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
185
186 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
187 Check for size-calculation overflow.
188 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
189 do, as we prefer signed integers.
190 (id_to_widget.max_size, id_to_widget.used)
191 (xg_store_widget_in_map, xg_remove_widget_from_map)
192 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
193 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
194 Use and return ptrdiff_t, not int.
195 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
196 * gtkutil.h: Change prototypes to match the above.
197
198 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
199 are duplicate now that they've been promoted to lisp.h.
200 (x_allocate_bitmap_record, x_alloc_image_color)
201 (make_image_cache, cache_image, xpm_load):
202 Don't update size until alloc is done.
203 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
204 (x_detect_edges):
3256efce 205 Check for size calculation overflow.
726e0ab1
PE
206 (ct_colors_allocated_max): New constant.
207 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
208 overflow.
3256efce 209
726e0ab1
PE
210 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
211 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
212 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
213 Use ptrdiff_t, not int, to count maps.
214 (read_char_minibuf_menu_prompt): Check for overflow in size
215 calculations. Don't update size until allocation succeeds. Redo
216 calculations to avoid overflow.
217 * keyboard.h: Change prototypes to match the above.
218
219 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
220 to count maps.
221 (current_minor_maps): Check for size calculation overflow.
222 * keymap.h: Change prototypes to match the above.
223
224 * lread.c (read1, init_obarray): Don't update size until alloc done.
225
226 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
227 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
228
726e0ab1
PE
229 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
230 Now ptrdiff_t, not int.
231 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
232 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
233
234 * process.c (Fnetwork_interface_list): Check for overflow
235 in size calculation.
236
237 * region-cache.c (move_cache_gap): Check for size calculation overflow.
238
239 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
240 overflow. Don't bother calling xmalloc when xrealloc will do.
241
242 * search.c (Freplace_match): Check for size calculation overflow.
243 (Fset_match_data): Don't assume list lengths fit in 'int'.
244
245 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
246 for command line length. Do not attempt to address one before the
247 beginning of an array, as that's not portable.
248
249 * term.c (max_frame_lines): Remove; unused.
250 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
251 not int.
252 (encode_terminal_code, calculate_costs): Check for size
253 calculation overflow.
254 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
255 table lengths and related sizes. Don't update size until alloc
256 done. Redo calculations to avoid overflow.
257 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
258
259 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
260 subtracting pointers.
261 (gobble_line): Check for overflow more carefully. Don't update size
262 until alloc done.
263
264 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
265 Don't update size until alloc done.
266 Redo size calculations to avoid overflow.
267 Check for size calculation overflow.
0065d054 268 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
269
270 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
271 Use ptrdiff_t, not int, for sizes.
272 (store_mode_line_noprop_char): Don't update size until alloc done.
273
0065d054
PE
274 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
275 Use ptrdiff_t, not int, for sizes.
276 (Finternal_make_lisp_face, cache_face):
277 Check for size calculation overflow.
278 (cache_face): Treat size calculation overflows as if they were
279 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
280
281 * xfns.c (x_encode_text, x_set_name_internal)
282 (Fx_change_window_property): Use ptrdiff_t, not int, to count
283 sizes, since they can exceed INT_MAX in size. Check for size
284 calculation overflow.
285
0065d054
PE
286 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
287 (xg_select): Check for size calculation overflow.
726e0ab1
PE
288 Don't update size until alloc done.
289
0065d054 290 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 291 as sprintf is limited to int lengths.
1d526e2f 292
252c5ee1
PE
293 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
294 (X_LONG_MIN): New macros.
864d7ce7
PE
295 Use them to make the following changes clearer.
296 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
297 This change doesn't affect the value now, but it may help remind
298 future maintainers not to raise the value too much later.
299 (SELECTION_QUANTUM): Remove, replacing with ...
300 (selection_quantum): ... new function, which avoids overflow.
301 All uses changed.
302 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
303 assumption that selection length fits in 'int'.
304 (x_reply_selection_request, x_handle_selection_request)
305 (x_get_window_property, receive_incremental_selection)
306 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
307 (lisp_data_to_selection_data, clean_local_selection_data):
308 Use ptrdiff_t, not int, to record length of selection.
309 (x_reply_selection_request, x_get_window_property)
310 (receive_incremental_selection, x_property_data_to_lisp):
311 Redo calculations to avoid overflow.
312 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 313 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
314 something.
315 (x_get_window_property, receive_incremental_selection)
316 (lisp_data_to_selection_data, x_property_data_to_lisp):
317 Check for size-calculation overflow.
318 (x_get_window_property, receive_incremental_selection)
319 (lisp_data_to_selection_data, Fx_register_dnd_atom):
320 Don't store size until memory allocation succeeds.
321 (x_get_window_property): Plug memory leak on memory exhaustion.
322 Don't double-block input; malloc is safe here. Don't assume 2**34
323 - 4 fits in unsigned long. Add an xassert to check
324 XGetWindowProperty overflow. Be more careful about overflow
325 calculations, and distinguish size from memory overflow better.
326 (receive_incremental_selection): When tracing, don't assume
327 unsigned int is less than INT_MAX.
328 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
329 harmful) conversions of unsigned short to int.
330 (lisp_data_to_selection_data): Don't assume that integers
331 in the range -65535 through -1 fit in an X unsigned short.
332 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
333 result parameters unless successful. Rely on cons_to_unsigned
334 to report problems with elements; the old code wasn't right anyway.
335 (x_check_property_data): Check for int overflow; we cannot use
336 a wider type due to X limits.
337 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
338
726e0ab1 339 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 340
0065d054
PE
341 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
342 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
343 (x_color_cells): Don't store size until memory allocation succeeds.
344 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 345 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
346 (x_term_init): Don't assume length fits in int (sprintf is limited
347 to int size).
bc18e09d 348
ebfa62c0
PE
349 Use ptrdiff_t for composition IDs.
350 * character.c (lisp_string_width):
351 * composite.c (composition_table_size, n_compositions)
352 (get_composition_id, composition_gstring_from_id):
353 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
354 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
355 * window.c (Frecenter):
356 Use ptrdiff_t, not int, for composition IDs.
357 * composite.c (get_composition_id): Check for integer overflow.
358 * composite.h: Adjust prototypes to match the above changes.
359
d3411f89
PE
360 Use ptrdiff_t for hash table indexes.
361 * category.c (hash_get_category_set):
362 * ccl.c (ccl_driver):
363 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
364 * coding.c (coding_system_charset_list, detect_coding_system):
365 * coding.h (struct coding_system.id):
366 * composite.c (get_composition_id, gstring_lookup_cache):
367 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
368 * image.c (xpm_get_color_table_h):
369 * lisp.h (hash_lookup, hash_put):
370 * minibuf.c (Ftest_completion):
371 Use ptrdiff_t for hash table indexes, not int (which is too
372 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
373 32-bit --with-wide-int hosts).
374
e097a6fa
PE
375 * charset.c (Fdefine_charset_internal): Check for integer overflow.
376 Add a FIXME comment about memory leaks.
377 (syms_of_charset): Don't assume xmalloc returns.
378
5637687f
PE
379 Don't assume that stated character widths fit in int.
380 * character.c (Fchar_width, c_string_width, lisp_string_width):
381 * character.h (CHAR_WIDTH):
382 * indent.c (MULTIBYTE_BYTES_WIDTH):
383 Use sanitize_char_width to avoid undefined and/or bad behavior
384 with outlandish widths.
385 * character.h (sanitize_tab_width): Renamed from sanitize_width,
386 now that we have two such functions. All uses changed.
387 (sanitize_char_width): New inline function.
388
a2271ba2
PE
389 Don't assume that tab-width fits in int.
390 * character.h (sanitize_width): New inline function.
391 (SANE_TAB_WIDTH): New macro.
392 (ASCII_CHAR_WIDTH): Use it.
393 * indent.c (sane_tab_width): Remove. All uses replaced by
394 SANE_TAB_WIDTH (current_buffer).
395 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
396
18c52557
PE
397 * fileio.c: Integer overflow issues with file modes.
398 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
399
caeeedc1
PE
400 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
401 Remove unreachable code.
402 (read_hex, load_charset_map_from_file): Check for integer overflow.
403
50849c52
PE
404 * xterm.c: don't go over XClientMessageEvent limit
405 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
406 (x_send_scroll_bar_event): Likewise. Check that the size does not
407 exceed limits imposed by XClientMessageEvent, as well as the usual
408 ptrdiff_t and size_t limits.
409
b13995db
PE
410 * keyboard.c: Overflow, signedness and related fixes.
411 (make_lispy_movement): Use same integer type in forward decl
412 that is used in the definition.
413 (read_key_sequence, keyremap_step):
414 Change bufsize argument back to int, undoing my 2011-03-30 change.
415 We prefer signed types, and int is wide enough here.
416 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
417 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
418 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
419 length, not size_t. Use ptrdiff_t for index, not int.
420 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
421 possibility of integer overflow.
422
13464394
PE
423 Overflow, signedness and related fixes for images.
424
425 * dispextern.h (struct it.stack[0].u.image.image_id)
426 (struct_it.image_id, struct image.id, struct image_cache.size)
427 (struct image_cache.used, struct image_cache.ref_count):
428 * gtkutil.c (update_frame_tool_bar):
429 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
430 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
431 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
432 * nsmenu.m (update_frame_tool_bar):
433 * xdisp.c (calc_pixel_width_or_height):
434 * xfns.c (image_cache_refcount):
435 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
436 on typical 64-bit hosts.
437
438 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
439 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
440 Omit unnecessary casts to int.
441 (parse_image_spec): Check that integers fall into 'int' range
442 when the callers expect that.
443 (image_ascent): Redo ascent calculation to avoid int overflow.
444 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
445 (lookup_image): Remove unnecessary tests.
446 (xbm_image_p): Locals are now of int, not EMACS_INT,
447 since parse_image_check makes sure they fit into int.
448 (png_load, gif_load, svg_load_image):
449 Prefer int to unsigned where either will do.
450 (tiff_handler): New function, combining the cores of the
451 old tiff_error_handler and tiff_warning_handler. This
452 function is rewritten to use vsnprintf and thereby avoid
453 stack buffer overflows. It uses only the features of vsnprintf
454 that are common to both POSIX and native Microsoft.
455 (tiff_error_handler, tiff_warning_handler): Use it.
456 (tiff_load, gif_load, imagemagick_load_image):
457 Don't assume :index value fits in 'int'.
458 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
459 (imagemagick_load_image): Check that crop parameters fit into
460 the integer types that MagickCropImage accepts. Don't assume
461 Vimagemagick_render_type has a nonnegative value. Don't assume
462 size_t fits in 'long'.
463 (gs_load): Use printmax_t to print the widest integers possible.
464 Check for integer overflow when computing image height and width.
465
c11821d4
EZ
4662011-08-26 Eli Zaretskii <eliz@gnu.org>
467
468 * xdisp.c (redisplay_window): Don't force window start if point
469 will be invisible in the resulting window. (Bug#9324)
470
0c95fcf7
EZ
4712011-08-25 Eli Zaretskii <eliz@gnu.org>
472
473 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
474 the display spec is of the form `(space ...)'.
475 (handle_display_spec): Return the value returned by
476 handle_single_display_spec, not just 1 or zero.
477 (handle_single_display_spec): If the display spec is of the form
478 `(space ...)', and specifies display in the text area, return 2
479 rather than 1.
fee65a97 480 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
481 accurately, and prefer exact match for point under bidi. Don't
482 advance `row' beyond the last row of the window.
0c95fcf7
EZ
483
484 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
485 into disp_prop; all users changed.
486
487 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
488 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
489 for the text covered by the display property.
490
e4ed06f1
CY
4912011-08-25 Chong Yidong <cyd@stupidchicken.com>
492
493 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
494 Change return value to nil.
495 (Frecord_buffer): Delete unused function.
496
f67cdd7f
EZ
4972011-08-24 Eli Zaretskii <eliz@gnu.org>
498
5980d4c6
EZ
499 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
500 buffers, return left-to-right.
8610fe8b
EZ
501 (set_cursor_from_row): Consider candidate row a win if its glyph
502 represents a newline and point is on that newline. Fixes cursor
503 positioning on the newline at EOL of R2L text within L2R
504 paragraph, and vice versa.
505 (try_cursor_movement): Check continued rows, in addition to
506 continuation rows. Fixes unwarranted scroll when point enters a
507 continued line of R2L text within an L2R paragraph, or vice versa.
508 (cursor_row_p): Consider the case of point being equal to
509 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
510 from the end of a short line to the beginning of a continued line
511 of R2L text within L2R paragraph.
512 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
513 composed characters.
5980d4c6 514
f67cdd7f
EZ
515 * bidi.c (bidi_check_type): Use xassert.
516 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
517 members.
518
bca633fb
EZ
5192011-08-23 Eli Zaretskii <eliz@gnu.org>
520
521 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
522 a character.
523
4a5885a7
CY
5242011-08-23 Chong Yidong <cyd@stupidchicken.com>
525
526 * nsfont.m (ns_otf_to_script): Fix typo.
527
0902a04e
KH
5282011-08-22 Kenichi Handa <handa@m17n.org>
529
530 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
531 extra slot even if the purpose is char-code-property-table.
532
1a2e6670
EZ
5332011-08-23 Eli Zaretskii <eliz@gnu.org>
534
8ddde651
EZ
535 * xdisp.c (redisplay_window): When computing centering_position,
536 account for the height of the header line. (Bug#8874)
537
425cc014
EZ
538 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
539 instead of CHAR_TO_BYTE. Fixes a crash when a completion
540 candidate is selected by the mouse, and that candidate has a
541 composed character under the mouse.
542
1a2e6670
EZ
543 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
544 coordinates reported by pos-visible-in-window-p for a composed
545 character in column zero.
546
8b76d6f8
SM
5472011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
548
549 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
550
dac347dd
EZ
5512011-08-22 Eli Zaretskii <eliz@gnu.org>
552
553 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
554 consider it a hit if to_charpos is anywhere in the range of the
555 composed buffer positions.
556
e013fb34
CY
5572011-08-22 Chong Yidong <cyd@stupidchicken.com>
558
559 * image.c (gif_load): Don't assume that each subimage has the same
560 dimensions as the base image. Handle disposal method that is
561 "undefined" by the gif spec (Bug#9335).
562
bd1ba3e8
CY
5632011-08-20 Chong Yidong <cyd@stupidchicken.com>
564
565 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 566 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 567
54a1215b
EZ
5682011-08-19 Eli Zaretskii <eliz@gnu.org>
569
823564e5
EZ
570 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
571 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
572 from an Org mode buffer to a Speedbar frame.
573
54a1215b
EZ
574 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
575 a composition, take its buffer position from IT->cmp_it.charpos.
576 Fixes cursor positioning at the beginning of a line that begins
577 with a composed character.
578
9778ebcc
EZ
5792011-08-18 Eli Zaretskii <eliz@gnu.org>
580
0be6ee06
EZ
581 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
582 character bidirectional type, use STRONG_L instead. Fixes crashes
583 in a buffer produced by `describe-categories'.
584
9778ebcc
EZ
585 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
586 members before the level stack, so they would be saved and
587 restored when copying iterator state. Fixes incorrect reordering
588 around TABs covered by display properties.
589
156bffbe
AS
5902011-08-18 Andreas Schwab <schwab@linux-m68k.org>
591
592 * process.c (Fnetwork_interface_list): Correctly determine buffer
593 size.
594
72ad093b
CY
5952011-08-17 Chong Yidong <cyd@stupidchicken.com>
596
597 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
598 (internal_condition_case_2, internal_condition_case_n):
599 Remove unnecessary aborts (Bug#9081).
72ad093b 600
35774242
EZ
6012011-08-17 Eli Zaretskii <eliz@gnu.org>
602
603 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
604 has no `load' handler, try opening the file locally. (Bug#9311)
605
db76dd85
KB
6062011-08-16 Ken Brown <kbrown@cornell.edu>
607
608 * gmalloc.c: Expand comment.
609
b215eee5
EZ
6102011-08-16 Eli Zaretskii <eliz@gnu.org>
611
612 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
613 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
614
a4579d33
KB
6152011-08-16 Ken Brown <kbrown@cornell.edu>
616
617 Fix memory allocation problems in Cygwin build (Bug#9273).
618
619 * unexcw.c ( __malloc_initialized): Declare external variable.
620 (fixup_executable): Force the dumped emacs to reinitialize malloc.
621
8b76d6f8
SM
622 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
623 New variables.
a4579d33
KB
624 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
625 dumped emacs.
626 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
627 in the static heap.
628 [CYGWIN] (special_realloc): New function.
629 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
630 requests to realloc storage in the static heap.
631
3ebec551
PE
6322011-08-15 Paul Eggert <eggert@cs.ucla.edu>
633
634 * bidi.c (bidi_initialize): Remove unused local.
635
9fd8be00
EZ
6362011-08-15 Eli Zaretskii <eliz@gnu.org>
637
474a8465
EZ
638 * biditype.h: File removed.
639
640 * bidimirror.h: File removed.
641
642 * deps.mk (bidi.o): Remove biditype.h and
643 bidimirror.h.
644
645 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
646 bidimirror.h.
647
648 * dispextern.h: Fix a typo in the comment to bidi_type_t.
649
650 * chartab.c: Improve commentary for the uniprop_table API.
651
32413314
EZ
652 * bidi.c (bidi_paragraph_init): Support zero value of
653 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
654 (bidi_initialize): Use uniprop_table instead of including
655 biditype.h and bidimirror.h.
32413314 656
9fd8be00
EZ
657 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
658 coordinates of the iterator when restoring from ppos_it.
659 (Bug#9296)
660
5cf2b69b
KH
6612011-08-14 Kenichi Handa <handa@m17n.org>
662
663 * process.c (create_process): Call setup_process_coding_systems
72ad093b 664 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 665
daf17d00
EZ
6662011-08-14 Eli Zaretskii <eliz@gnu.org>
667
668 * xdisp.c (move_it_in_display_line_to): Don't invoke
669 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
670 ppos_it. Fixes vertical cursor motion when line beginning is
671 covered by an image. (Bug#9296)
672
08e3161a
JD
6732011-08-14 Jan Djärv <jan.h.d@swipnet.se>
674
675 * nsterm.h (ns_run_ascript): Declare.
676 (NSAPP_DATA2_RUNASSCRIPT): Define.
677
678 * nsfns.m (as_script, as_result, as_status): New static variables.
679 (ns_run_ascript): New function.
680 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
681 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
682 the event loop. Get status from as_status (Bug#7276).
683
684 * nsterm.m (sendEvent): If event is NSApplicationDefined and
685 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
686 the event loop (Bug#7276).
687
a3720aa2
AS
6882011-08-14 Andreas Schwab <schwab@linux-m68k.org>
689
690 * gnutls.c (QCgnutls_bootprop_priority)
691 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
692 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
693 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
694 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
695 (QCgnutls_bootprop_verify_hostname_error)
696 (QCgnutls_bootprop_callbacks_verify): Rename from
697 Qgnutls_bootprop_..., all uses changed.
698
699 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
700 uses changed.
701
0a0d27fb
PE
7022011-08-14 Paul Eggert <eggert@cs.ucla.edu>
703
19d5c50c
PE
704 * xfaces.c (Qframe_set_background_mode): Now static.
705 * dispextern.h (Qframe_set_background_mode): Remove decl.
706
0a0d27fb
PE
707 * process.c (Fnetwork_interface_info): Declare local only if needed.
708
377538cb
JD
7092011-08-13 Jan Djärv <jan.h.d@swipnet.se>
710
711 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
712 (Fnetwork_interface_list): Allocate in increments of bytes instead
713 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
714 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
715 sockaddr.
716 (struct ifflag_def): notrailers is smart on OSX.
717 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
718 Get hardware address with getifaddrs if available.
719
08fff70c
EZ
7202011-08-12 Eli Zaretskii <eliz@gnu.org>
721
722 * xdisp.c (iterate_out_of_display_property): xassert that
723 IT->position is set to within IT->object's boundaries. Break from
724 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
725 when IT->position is set up wrongly due to some bug.
726 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
727 (push_display_prop): Allow GET_FROM_STRING as IT->method on
728 entry. Force push_it to save on the stack the current
729 buffer/string position, to be restored by pop_it. Fix flags in
730 the iterator structure wrt the object coming from a display
731 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
732 properties. (Bug#9284)
733
7be1c708 7342011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 735
7be1c708
CY
736 * fontset.c (fontset_get_font_group): Add proper type checks.
737 (Bug#9172)
aac0c6e3 738
7be1c708 7392011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 740
7be1c708
CY
741 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
742 and LC_VERSION_MIN_MACOSX.
743 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
744 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 745
97bb72a6
EZ
7462011-08-08 Eli Zaretskii <eliz@gnu.org>
747
748 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
749 no-display-properties-and-no-overlays under bidi display.
750 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 751 properties and overlays.
97bb72a6 752
d5617611
CY
7532011-08-08 Chong Yidong <cyd@stupidchicken.com>
754
37e11a63
CY
755 * editfns.c (Fset_time_zone_rule): Document relationship with the
756 setenv function.
757
d5617611
CY
758 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
759 the font entity extracted from the cache (Bug#8109).
760
58872834
CY
7612011-08-07 Chong Yidong <cyd@stupidchicken.com>
762
763 * composite.c (autocmp_chars): Don't reset point. That is done by
764 restore_point_unwind (Bug#5984).
765
75bfc667
JL
7662011-08-07 Juri Linkov <juri@jurta.org>
767
768 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
769 to show the arg `TIME' instead of `TIMEVAL'.
770
d1410150
EZ
7712011-08-06 Eli Zaretskii <eliz@gnu.org>
772
773 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
774 display property strides EOL and includes a newline, as in
775 longlines-mode. (Bug#9254)
75b771e4
EZ
776 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
777 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
778
779 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
780 is non-zero, even if the data buffer is NULL. Fixes a crash in
781 vertical-motion with longlines-mode. (Bug#9254)
782
35928349
EZ
7832011-08-05 Eli Zaretskii <eliz@gnu.org>
784
ec7cc85b
EZ
785 * bidi.c <bidi_cache_total_alloc>: Now static.
786 (bidi_initialize): Initialize bidi_cache_total_alloc.
787
8b76d6f8 788 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
789 cache. (Bug#9221)
790
791 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
792 amount allocated this far in `bidi_cache_total_alloc'.
793 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
794 non-zero, only free the data buffer without restoring the cache
795 contents. All callers changed.
796
797 * dispextern.h (bidi_unshelve_cache): Update prototype.
798
799 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
800 (move_it_in_display_line, move_it_to)
801 (move_it_vertically_backward, move_it_by_lines): Replace the call
802 to xfree to an equivalent call to bidi_unshelve_cache.
803 (move_it_in_display_line_to): Fix logic of returning
412b6358 804 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 805
e2e2423b
EZ
8062011-08-05 Eli Zaretskii <eliz@gnu.org>
807
808 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
809 came from a string character with a `cursor' property. (Bug#9229)
810
ae9e757a
JD
8112011-08-04 Jan Djärv <jan.h.d@swipnet.se>
812
813 * Makefile.in (LIB_PTHREAD): New variable.
814 (LIBES): Add LIB_PTHREAD (Bug#9216).
815
816 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
817 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
818
213bd7f2
AS
8192011-08-04 Andreas Schwab <schwab@linux-m68k.org>
820
821 * regex.c (re_iswctype): Remove some redundant boolean
822 conversions.
823
99aaf75f
JD
8242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
825
826 * xterm.c (x_find_topmost_parent): New function.
827 (x_set_frame_alpha): Find topmost parent window with
828 x_find_topmost_parent and set the property there also (bug#9181).
829 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
830
c74e9d86
PE
8312011-08-04 Paul Eggert <eggert@cs.ucla.edu>
832
833 * callproc.c (Fcall_process): Avoid vfork clobbering
834 the local vars buffer, coding_systems, current_dir.
835
640c8776
SM
8362011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
837
838 * keymap.c (Fmake_composed_keymap): Move to subr.el.
839
f26d0e4c
PE
8402011-08-03 Paul Eggert <eggert@cs.ucla.edu>
841
8a10d76c
PE
842 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
843 so that it is not optimized away.
844
f26d0e4c
PE
845 * xdisp.c (compute_display_string_pos): Remove unused local.
846
55439c61
EZ
8472011-08-02 Eli Zaretskii <eliz@gnu.org>
848
849 Fix slow cursor motion and scrolling in large buffers with
850 selective display, like Org Mode buffers. (Bug#9218)
851
852 * dispextern.h (struct bidi_it): New member disp_prop_p.
853
854 * xdisp.c: Remove one-slot cache of display string positions.
855 (compute_display_string_pos): Accept an additional argument
856 DISP_PROP_P; callers changed. Scan at most 5K characters forward
857 for a display string or property. If found, set DISP_PROP_P
858 non-zero.
859
860 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
861 DISP_PROP_P, and pass it to compute_display_string_pos.
862 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
863 non-zero. All callers of bidi_fetch_char changed.
864
fb33fa43
SM
8652011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
866
867 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
868
b099e063
DM
8692010-12-03 Don March <don@ohspite.net>
870
871 * keymap.c (Fdefine_key): Fix non-prefix key error message when
872 last character M-[char] is translated to ESC [char] (bug#7541).
873
5cc7f7af
KH
8742011-08-02 Kenichi Handa <handa@m17n.org>
875
d0fffa3f 876 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
877
878 * chartab.c (uniprop_table): Make it non-static.
879
525d5e6e
EZ
8802011-08-01 Eli Zaretskii <eliz@gnu.org>
881
882 * xdisp.c (forward_to_next_line_start): Accept additional argument
883 BIDI_IT_PREV, and store into it the state of the bidi iterator had
884 on the newline.
885 (reseat_at_next_visible_line_start): Use the bidi iterator state
886 returned by forward_to_next_line_start to restore the state of
887 it->bidi_it after backing up to previous newline. (Bug#9212)
888
31011111
AS
8892011-07-30 Andreas Schwab <schwab@linux-m68k.org>
890
891 * regex.c (re_comp): Protoize.
892 (re_exec): Fix return type.
893 (regexec): Fix type of `ret'. (Bug#9203)
894
e5d76069
PE
8952011-07-29 Paul Eggert <eggert@cs.ucla.edu>
896
897 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
898 This is needed if max-image-size is a floating-point number.
899
9a79b20c
AS
9002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
901
902 * print.c (print_object): Print empty symbol as ##.
903
904 * lread.c (read1): Read ## as empty symbol.
905
d8c2fa78
AA
9062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
907
908 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
909 setting frame foreground color (Bug#9175).
910 (x_set_background_color): Likewise.
911
ffe57a7a
AA
912 * nsmenu.m (-setText): Size tooltip dimensions precisely to
913 contents (Bug#9176).
914 (EmacsTooltip -init): Remove bezels and add shadows to
915 tooltip windows.
916
bf3492a5
AA
917 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
918 or scroll bar (Bug#8470).
919
d55e9c53
AA
920 * nsfont.m (nsfont_open): Remove assignment to voffset and
921 unnecessary vars hshink, expand, hd, full_height, min_height.
922 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
923
924 * nsterm.h (nsfont_info): Remove voffset field.
925
d8c2fa78 9262011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
927
928 Implement strike-through and overline on NextStep (Bug#8863).
929
930 * nsfont.m (nsfont_open): Use underline position provided by font,
931 instead of hard-coded value of 2.
932 (nsfont_draw): Call ns_draw_text_decoration instead.
933
934 * nsterm.h: Add declaration for ns_draw_text_decoration.
935
936 * nsterm.m (ns_draw_text_decoration): New function for drawing
937 underline, overline, and strike-through.
938 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
939 ns_draw_text_decoration. Change treatment of cursor drawing to
940 accomodate underlining, etc.
941
4cc60b9b
EZ
9422011-07-28 Eli Zaretskii <eliz@gnu.org>
943
bc7ece87
EZ
944 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
945 default.
4cc60b9b 946
476371c4
PE
9472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
948
66606eea
PE
949 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
950 Without this fix, if a signal arrives just after memory fills up,
951 'malloc' might be invoked reentrantly.
952
476371c4
PE
953 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
954 In other words, assume that every image size is allowed, on non-X
955 hosts. This assumption is probably wrong, but it lets Emacs compile.
956
f3fcc40d
AS
9572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
958
959 * regex.c (re_iswctype): Convert return values to boolean.
960
350c992f
EZ
9612011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
962
963 * xdisp.c (compute_display_string_pos): Don't use cached display
964 string position if the buffer had its restriction changed.
965 (Bug#9184)
966
5266b4bb
PE
9672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
968
969 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
970
2573a837 9712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 972
41f55ccd 973 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 974
39e378da
PE
975 * bidi.c: Integer size and overflow fixes.
976 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
977 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
978 (bidi_cache_find_level_change, bidi_cache_ensure_space)
979 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
980 (bidi_find_other_level_edge):
981 Use ptrdiff_t instead of EMACS_INT where either will do.
982 This works better on 32-bit hosts configured --with-wide-int.
983 (bidi_cache_ensure_space): Check for size-calculation overflow.
984 Use % rather than repeated addition, for better worst-case speed.
985 Don't set bidi_cache_size until after xrealloc returns, because it
986 might not return.
987 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
988 (bidi_cache_ensure_space): Also check that the bidi cache size
989 does not exceed that of the largest Lisp string or buffer. See Eli
990 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 991
5e927815
PE
992 * alloc.c (__malloc_size_t): Remove.
993 All uses replaced by size_t. See Andreas Schwab's note
994 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
995
ca4aa935
PE
996 * image.c: Improve checking for integer overflow.
997 (check_image_size): Assume that f is nonnull, since
998 it is always nonnull in practice. This is one less thing to
999 worry about when checking for integer overflow later.
1000 (x_check_image_size): New function, which checks for integer
1001 overflow issues inside X.
1002 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1003 This removes the need for a memory_full check.
1004 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1005 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1006 (xbm_read_bitmap_data): Change locals back to 'int', since
1007 their values must fit in 'int'.
1008 (xpm_load_image, png_load, tiff_load):
1009 Invoke x_create_x_image_and_pixmap earlier,
1010 to avoid much needless work if the image is too large.
1011 (tiff_load): Treat overly large images as if
1012 x_create_x_image_and_pixmap failed, not as malloc failures.
1013 (gs_load): Use x_check_image_size.
1014
5f8f9cc2
PE
1015 * gtkutil.c: Omit integer casts.
1016 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1017 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1018
5adf60bc
PE
1019 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1020
c8907a93
PE
1021 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1022 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1023 would wrongly return t on a 64-bit host.
1024
e3c25c68
PE
1025 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1026 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1027 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1028 and therefore cause GCC to emit a bogus diagnostic in some cases.
1029
3f791afe
PE
1030 * image.c: Integer signedness and overflow and related fixes.
1031 This is not an exhaustive set of fixes, but it's time to
1032 record what I've got.
1033 (lookup_pixel_color, check_image_size): Remove redundant decls.
1034 (check_image_size): Don't assume that arbitrary EMACS_INT values
1035 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1036 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1037 (tiff_load, imagemagick_load_image):
1038 Check for overflow in size calculations.
1039 (x_create_x_image_and_pixmap): Remove unnecessary test for
1040 xmalloc returning NULL; that can't happen.
1041 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1042 (xpm_color_bucket): Use better integer hashing function.
1043 (xpm_cache_color): Don't possibly over-allocate memory.
1044 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1045 (gif_memory_source):
1046 Use ptrdiff_t, not int or size_t, to record sizes.
1047 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1048 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1049 either works, as we prefer signed integers.
1050 (tiff_read_from_memory, tiff_write_from_memory):
1051 Return tsize_t, not size_t, since that's what the TIFF API wants.
1052 (tiff_read_from_memory): Don't fail simply because the read would
1053 go past EOF; instead, return a short read.
1054 (tiff_load): Omit no-longer-needed casts.
1055 (Fimagemagick_types): Don't assume size fits into 'int'.
1056
3cc5a532
PE
1057 Improve hashing quality when configured --with-wide-int.
1058 * fns.c (hash_string): New function, taken from sxhash_string.
1059 Do not discard information about ASCII character case; this
1060 discarding is no longer needed.
1061 (sxhash-string): Use it. Change sig to match it. Caller changed.
1062 * lisp.h: Declare it.
1063 * lread.c (hash_string): Remove, since we now use fns.c's version.
1064 The fns.c version returns a wider integer if --with-wide-int is
1065 specified, so this should help the quality of the hashing a bit.
1066
b312a492
PE
1067 * emacs.c: Integer overflow minor fix.
1068 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1069 Define only if GNU_LINUX.
1070 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1071
dfd153ae
PE
1072 * dispnew.c: Integer signedness and overflow fixes.
1073 Remove unnecessary forward decls, that were a maintenance hassle.
1074 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1075 All uses changed.
1076 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1077 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1078 (prepare_desired_row, line_draw_cost):
1079 Use int, not unsigned, where either works.
1080 (save_current_matrix, restore_current_matrix):
1081 Use ptrdiff_t, not size_t, where either works.
1082 (init_display): Check for overflow more accurately, and without
1083 relying on undefined behavior.
1084
a81d11a3
PE
1085 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1086 Remove, replacing with the new symbols in lisp.h. All uses changed.
1087 * fileio.c (make_temp_name):
1088 * filelock.c (lock_file_1, lock_file):
1089 * xdisp.c (message_dolog):
1090 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1091 Use pMd etc. instead.
1092 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1093 replacing the pWIDE etc. symbols removed from editfns.c.
1094
3300e6fd
PE
1095 * keyboard.h (num_input_events): Now uintmax_t.
1096 This is (very slightly) less likely to mess up due to wraparound.
1097 All uses changed.
1098
fd05c7e9
PE
1099 * buffer.c: Integer signedness fixes.
1100 (alloc_buffer_text, enlarge_buffer_text):
1101 Use ptrdiff_t rather than size_t when either will do, as we prefer
1102 signed integers.
1103
903fe15d
PE
1104 * alloc.c: Integer signedness and overflow fixes.
1105 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1106 (__malloc_size_t): Default to size_t, not to int.
1107 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1108 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1109 Prefer ptrdiff_t to size_t when either would do, as we prefer
1110 signed integers.
1111 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1112 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1113 Now const. Initialize with values that are in range even if char
1114 is signed.
1115 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1116 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1117 These functions do the right thing with sizes > 2**32.
1118 (check_depth): Now ptrdiff_t, not int.
1119 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1120 Adjust to new way of storing sizes. Check for size overflow bugs
1121 in rest of code.
1122 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1123 slightly wrong anyway, as it missed one instance of
1124 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1125 (refill_memory_reserve): Omit needless cast to size_t.
1126 (mark_object_loop_halt): Mark as externally visible.
1127
ac82cc6a
PE
1128 * xselect.c: Integer signedness and overflow fixes.
1129 (Fx_register_dnd_atom, x_handle_dnd_message):
1130 Use ptrdiff_t, not size_t, since we prefer signed.
1131 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1132 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1133 x_dnd_atoms_size and x_dnd_atoms_length.
1134
c2d1e36d
PE
1135 * doprnt.c: Prefer signed to unsigned when either works.
1136 * eval.c (verror):
1137 * doprnt.c (doprnt):
1138 * lisp.h (doprnt):
1139 * xdisp.c (vmessage):
1140 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1141 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1142 prefer signed arithmetic to avoid comparison confusion.
1143 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1144 but is a bit tricky.
1145
0e926e56
PE
1146 Assume freestanding C89 headers, string.h, stdlib.h.
1147 * data.c, doprnt.c, floatfns.c, print.c:
1148 Include float.h unconditionally.
1149 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1150 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1151 * regex.c: Likewise for stddef.h, string.h.
1152 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1153 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1154 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1155 (STDC_HEADERS): Remove obsolete defines.
1156 * sysdep.c: Include limits.h unconditionally.
1157
9cfdb3ec
PE
1158 Assume support for memcmp, memcpy, memmove, memset.
1159 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1160 * regex.c (memcmp, memcpy):
1161 Remove; we assume C89 now.
1162
1163 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1164 (__malloc_safe_bcopy): Remove; no longer needed.
1165
cf950e6b 1166 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1167 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1168 well either way, and we prefer signed to unsigned.
1169
dbf38e02
LMI
11702011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1171
1172 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1173 closes the connection while we're reading (bug#9182).
1174
d6f0886c
JD
11752011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1176
1177 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1178 are specified (Bug#9168).
1179
2eb1f9e6
PE
11802011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1183 Found by GCC static checking and --with-wide-int on a 32-bit host.
1184
22381272 11852011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1186
1187 * xdisp.c (compute_display_string_pos): Fix logic of caching
1188 previous display string position. Initialize cached_prev_pos to
1189 -1. Fixes slow-down at the beginning of a buffer.
1190
f25e39b4
EZ
11912011-07-24 Eli Zaretskii <eliz@gnu.org>
1192
1193 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1194 for attrs[LFACE_FONTSET_INDEX].
1195
04c4b52e
PE
11962011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1197
1198 * xml.c (parse_region): Remove unused local
1199 that was recently introduced.
1200
c1734fbd
EZ
12012011-07-23 Eli Zaretskii <eliz@gnu.org>
1202
be18c5a5
EZ
1203 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1204 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1205
c1734fbd
EZ
1206 * xdisp.c (move_it_in_display_line_to): Record the best matching
1207 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1208 exit if none of the characters scanned was an exact match.
1209 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1210 when exact match is impossible due to invisible text, and the
1211 lines are truncated.
1212
a258d627
JD
12132011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1214
1215 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1216 for OSX >= 10.7.
1217
b6d5a689
EZ
12182011-07-22 Eli Zaretskii <eliz@gnu.org>
1219
0f74f785
EZ
1220 Fix a significant slow-down of cursor motion with C-n, C-p,
1221 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1222 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1223 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1224 (next_element_from_buffer): Call compute_stop_pos_backwards to
1225 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1226 base_level_stop.
1227 (reseat): Don't look for prev_stop, as that could mean a very long
1228 run.
1229 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1230 <cached_disp_overlay_modiff>: Cache for last found display string
1231 position.
551918c1 1232 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1233 about the same buffer in the same area of character positions, and
1234 the buffer wasn't changed since the time the display string
1235 position was cached.
551918c1 1236
b2d0c91a
EZ
12372011-07-22 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1240 is an integer, which is important for empty lines. (Bug#9149)
1241
043604ee
CY
12422011-07-22 Chong Yidong <cyd@stupidchicken.com>
1243
1244 * frame.c (Fmodify_frame_parameters): In tty case, update the
1245 default face if necessary (Bug#4238).
1246
da4adb04
CY
12472011-07-21 Chong Yidong <cyd@stupidchicken.com>
1248
1249 * editfns.c (Fstring_to_char): No need to explain what a character
1250 is in the docstring (Bug#6576).
1251
9abd0532
LMI
12522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1253
1254 * xml.c (parse_region): Make sure we always return a tree.
1255
36881d16
HK
12562011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1257
1258 * xml.c (parse_region): If a document contains only comments,
1259 return that, too.
1260
1e98674d
LMI
12612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1262
1263 * xml.c (make_dom): Return comments, too.
1264
590bd467
PE
12652011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1266
1267 Port to OpenBSD.
1268 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1269 and the surrounding thread.
1270 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1271 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1272 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1273 timer goes off.
1274 * s/openbsd.h (BROKEN_SIGIO): Define.
1275 * unexelf.c (unexec) [__OpenBSD__]:
1276 Don't update the .mdebug section of the Alpha COFF symbol table.
1277
f41628b2
LMI
12782011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1279
1280 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1281 (bug#8460).
1282
b59b67c5
PE
12832011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1284
15e3a074
PE
1285 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1286 This fixes some race conditions on the permissions of any newly
1287 created file.
1288
41bed37d
PE
1289 * alloc.c (valid_pointer_p): Use pipe, not open.
1290 This fixes some permissions issues when debugging.
1291
b59b67c5
PE
1292 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1293 If fchown fails to set both uid and gid, try to set just gid,
1294 as that is sometimes allowed. Adjust the file's mode to eliminate
1295 setuid or setgid bits that are inappropriate if fchown fails.
1296
925a6be7
SM
12972011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1298
1299 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1300 to compare Lisp_Objects.
1301 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1302 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1303 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1304
52968808
AS
13052011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1306
0a6a104b
AS
1307 * lread.c (read_integer): Unread even EOF character.
1308 (read1): Likewise. Properly record start position of symbol.
1309
52968808
AS
1310 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1311 symbol character follows.
1312
9e381cdd
PE
13132011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1314
1315 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1316 This works around a problem with the previous change to Fcopy_file.
1317 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1318 and without this change, GCC might complain about discarding
1319 fchown's return value.
1320
b5641435
JB
13212011-07-16 Juanma Barranquero <lekktu@gmail.com>
1322
1323 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1324
a8031457
PE
13252011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1326
1327 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1328
dd889327
LMI
13292011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1330
750c33f7
LMI
1331 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1332 it's used from the C level.
1333
dd889327
LMI
1334 * process.c: Use the same condition for POLL_FOR_INPUT in both
1335 keyboard.c and process.c (bug#1858).
1336
87e86684
LM
13372011-07-09 Lawrence Mitchell <wence@gmx.li>
1338
1339 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1340 (Fgnutls_boot): Use it.
1341
64348f40
AS
13422011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1343
1344 * doc.c (Fsubstitute_command_keys): Revert last change.
1345
1d698799
LMI
13462011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1347
f863868c
LMI
1348 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1349 quotes the next character, and doesn't affect other longer
1350 sequences (bug#8935).
1351
1d698799
LMI
1352 * lread.c (syms_of_lread): Clarify that is isn't only
1353 `eval-buffer' and `eval-defun' that's affected by
1354 `lexical-binding' (bug#8460).
1355
aa4b6df6
EZ
13562011-07-15 Eli Zaretskii <eliz@gnu.org>
1357
1358 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1359 bidi redisplay when a line includes both an image and is
1360 truncated.
1361
5d856da6
PE
13622011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1363
ad6042bb
PE
1364 Fix minor problems found by static checking.
1365 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1366 (elsz): Now a signed constant, not a size_t var. We prefer signed
1367 types to unsigned, to avoid integer comparison confusion. Without
1368 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1369 "cannot optimize loop, the loop counter may overflow", a symptom
1370 of the confusion.
f00bbb22 1371 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1372 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1373
6468f31c
LMI
13742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1375
49080b10
LMI
1376 * search.c (Fre_search_backward): Mention `case-fold-search' in
1377 all the re_search_* functions (bug#8138).
1378
6468f31c
LMI
1379 * keyboard.c (Fopen_dribble_file): Document when the file is
1380 closed (bug#8056).
1381
c965adc5
EZ
13822011-07-14 Eli Zaretskii <eliz@gnu.org>
1383
df9733bf
EZ
1384 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1385 bidi_cache_idx.
1386
0bb23927
EZ
1387 Support bidi reordering of display and overlay strings.
1388 * xdisp.c (compute_display_string_pos)
1389 (compute_display_string_end): Accept additional argument STRING.
1390 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1391 (reseat_to_string): Initialize bidi_it->string.s and
1392 bidi_it->string.schars.
1393 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1394 NULL (avoids a crash in bidi_paragraph_init).
1395 Initialize itb.string.lstring.
0bb23927
EZ
1396 (init_iterator): Call bidi_init_it only of a valid
1397 buffer position was specified. Initialize paragraph_embedding to
1398 L2R.
1399 (reseat_to_string): Initialize the bidi iterator.
1400 (display_string): If we need to ignore text properties of
1401 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1402 original value of -1 will not work with bidi.)
1403 (compute_display_string_pos): First arg is now struct
1404 `text_pos *'; all callers changed. Support display properties on
1405 Lisp strings.
1406 (compute_display_string_end): Support display properties on Lisp
1407 strings.
1408 (init_iterator, reseat_1, reseat_to_string): Initialize the
1409 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1410 when iterating on a string not from display properties).
640c8776
SM
1411 (compute_display_string_pos, compute_display_string_end):
1412 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1413 arrow keys.
1414 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1415 base_level_stop; instead, set base_level_stop to BEGV.
1416 Fixes crashes in vertical-motion.
0bb23927
EZ
1417 (next_element_from_buffer): Improve commentary for when
1418 the iterator is before prev_stop.
1419 (init_iterator): Initialize bidi_p from the default value of
1420 bidi-display-reordering, not from buffer-local value. Use the
1421 buffer-local value only if initializing for buffer iteration.
1422 (handle_invisible_prop): Support invisible properties on strings
1423 that are being bidi-reordered.
1424 (set_iterator_to_next): Support bidi reordering of C strings and
1425 Lisp strings.
1426 (next_element_from_string): Support bidi reordering of Lisp
1427 strings.
1428 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1429 (display_string): Support display of R2L glyph rows.
1430 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1431 (init_iterator): Don't initialize it->bidi_p for strings
1432 here.
1433 (reseat_to_string): Initialize it->bidi_p for strings here.
1434 (next_element_from_string, next_element_from_c_string)
1435 (next_element_from_buffer): Add xassert's for correspondence
1436 between IT's object being iterated and it->bidi_it.string
1437 structure.
1438 (face_before_or_after_it_pos): Support bidi iteration.
1439 (next_element_from_c_string): Handle the case of the first string
1440 character that is not the first one in the visual order.
1441 (get_visually_first_element): New function, refactored from common
1442 parts of next_element_from_buffer, next_element_from_string, and
1443 next_element_from_c_string.
1444 (tool_bar_lines_needed, redisplay_tool_bar)
1445 (display_menu_bar): Force left-to-right direction. Add a FIXME
1446 comment for making that be controlled by a user option.
1447 (push_it, pop_it): Save and restore the state of the
1448 bidi iterator. Save and restore the bidi_p flag.
1449 (pop_it): Iterate out of display property for string iteration as
1450 well.
1451 (iterate_out_of_display_property): Support iteration over strings.
1452 (handle_single_display_spec): Set up it->bidi_it for iteration
1453 over a display string, and call bidi_init_it.
1454 (handle_single_display_spec, next_overlay_string)
1455 (get_overlay_strings_1, push_display_prop): Set up the bidi
1456 iterator for displaying display or overlay strings.
1457 (forward_to_next_line_start): Don't use the shortcut if
1458 bidi-iterating.
1459 (back_to_previous_visible_line_start): If handle_display_prop
1460 pushed the iterator stack, restore the internal state of the bidi
1461 iterator by calling bidi_pop_it same number of times.
1462 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1463 and we are bidi-iterating, don't decrement the iterator position;
1464 instead, set the first_elt flag in the bidi iterator, to produce
1465 the same effect.
1466 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1467 (push_display_prop): xassert that we are iterating a buffer.
1468 (push_it, pop_it): Save and restore paragraph_embedding member.
1469 (handle_single_display_spec, next_overlay_string)
1470 (get_overlay_strings_1, reseat_1, reseat_to_string)
1471 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1472 correctly. Don't assume unibyte strings are not bidi-reordered.
1473 (compute_display_string_pos)
1474 (compute_display_string_end): Fix handling the case of C string.
1475 (push_it, pop_it): Save and restore from_disp_prop_p.
1476 (handle_single_display_spec, push_display_prop): Set the
1477 from_disp_prop_p flag.
1478 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1479 (pop_it): Call iterate_out_of_display_property only if we are
1480 popping after iteration over a string that came from a display
1481 property. Fix a typo in popping stretch info. Add an assertion
1482 for verifying that the iterator position is in sync with the bidi
1483 iterator.
1484 (handle_single_display_spec, get_overlay_strings_1)
1485 (push_display_prop): Fix initialization of paragraph direction for
1486 string when that of the parent object is not yet determined.
1487 (reseat_1): Call bidi_init_it to resync the bidi
1488 iterator with IT's position. (Bug#7616)
1489 (find_row_edges): If ROW->start.pos gives position
1490 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1491 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1492 Reset the from_disp_prop_p flag.
1493 (SAVE_IT, RESTORE_IT): New macros.
1494 (pos_visible_p, face_before_or_after_it_pos)
1495 (back_to_previous_visible_line_start)
1496 (move_it_in_display_line_to, move_it_in_display_line)
1497 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1498 (try_scrolling, redisplay_window, display_line): Use them when
1499 saving a temporary copy of the iterator and restoring it back.
1500 (back_to_previous_visible_line_start, reseat_1)
1501 (init_iterator): Empty the bidi cache "stack".
1502 (move_it_in_display_line_to): If iterator ended up at
1503 EOL, but we never saw any buffer positions smaller than
1504 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1505 motion in bidi-reordered lines.
1506 (move_it_in_display_line_to): Record prev_method and prev_pos
1507 immediately before the call to set_iterator_to_next. Fixes cursor
1508 motion in bidi-reordered lines with stretch glyphs and strings
1509 displayed in margins. (Bug#8133) (Bug#8867)
1510 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1511 TO_CHARPOS.
640c8776
SM
1512 (pos_visible_p): Support positions in bidi-reordered lines.
1513 Save and restore bidi cache.
0bb23927
EZ
1514
1515 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1516 (bidi_paragraph_info): Delete unused struct.
1517 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1518 (bidi_cache_start): New variable.
1519 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1520 to zero.
1521 (bidi_cache_fetch_state, bidi_cache_search)
1522 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1523 (bidi_cache_find, bidi_peek_at_next_level)
1524 (bidi_level_of_next_char, bidi_find_other_level_edge)
1525 (bidi_move_to_visually_next): Compare cache index with
1526 bidi_cache_start rather than with zero.
1527 (bidi_fetch_char): Accept new argument STRING; all callers
1528 changed. Support iteration over a string. Support strings with
1529 display properties. Support unibyte strings. Fix the type of
1530 `len' according to what STRING_CHAR_AND_LENGTH expects.
1531 (bidi_paragraph_init, bidi_resolve_explicit_1)
1532 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1533 (bidi_level_of_next_char, bidi_move_to_visually_next):
1534 Support iteration over a string.
0bb23927
EZ
1535 (bidi_set_sor_type, bidi_resolve_explicit_1)
1536 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1537 can now be zero (for strings); special values 0 and -1 were
1538 changed to -1 and -2, respectively.
1539 (bidi_char_at_pos): New function.
1540 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1541 Call it instead of FETCH_MULTIBYTE_CHAR.
1542 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1543 initialized to valid values.
1544 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1545 values.
1546 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1547 the test for valid cached positions. Fix the logic for looking up
1548 the sentinel state in the cache. GCPRO the Lisp string we are
1549 iterating.
1550 (bidi_push_it, bidi_pop_it): New functions.
1551 (bidi_initialize): Initialize the bidi cache start stack pointer.
1552 (bidi_cache_ensure_space): New function, refactored from part of
1553 bidi_cache_iterator_state. Don't assume the required size is just
1554 one BIDI_CACHE_CHUNK away.
1555 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1556 (bidi_count_bytes, bidi_char_at_pos): New functions.
1557 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1558 always valid if bidi_cache_idx is valid.
1559 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1560 is valid if it's going to be used.
1561 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1562 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1563 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1564 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1565 (bidi_find_other_level_edge, bidi_cache_start_stack):
1566 All variables related to cache indices are now EMACS_INT.
c965adc5 1567
0bb23927
EZ
1568 * dispextern.h (struct bidi_string_data): New structure.
1569 (struct bidi_it): New member `string'. Make flag members be 1-bit
1570 fields, and put them last in the struct.
640c8776
SM
1571 (compute_display_string_pos, compute_display_string_end):
1572 Update prototypes.
0bb23927
EZ
1573 (bidi_push_it, bidi_pop_it): Add prototypes.
1574 (struct iterator_stack_entry): New members bidi_p,
1575 paragraph_embedding, and from_disp_prop_p.
1576 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1577 (bidi_shelve_cache, bidi_unshelve_cache):
1578 Declare prototypes.
0bb23927
EZ
1579
1580 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1581 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1582 and vector-like objects.
1583
1584 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1585 cache around display iteration.
1586
1587 * window.c (Fwindow_end, window_scroll_pixel_based)
1588 (displayed_window_lines, Frecenter): Save and restore the bidi
1589 cache around display iteration.
1590
3bbd2265
LMI
15912011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1592
1593 * editfns.c (Fdelete_region): Clarify the use of the named
1594 parameters (bug#6788).
1595
adc47434
MR
15962011-07-14 Martin Rudalics <rudalics@gmx.at>
1597
1598 * indent.c (Fvertical_motion): Set and restore w->pointm when
1599 saving and restoring the window's buffer (Bug#9006).
1600
837c31f8
LMI
16012011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1602
1603 * editfns.c (Fstring_to_char): Clarify just what is returned
1604 (bug#6576). Text by Eli Zaretskii.
1605
ac389d0c
JB
16062011-07-13 Juanma Barranquero <lekktu@gmail.com>
1607
1608 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1609
0be0ce47
EZ
16102011-07-13 Eli Zaretskii <eliz@gnu.org>
1611
1612 * buffer.c (mmap_find): Fix a typo.
1613
cd18e7e3
JB
16142011-07-13 Johan Bockgård <bojohan@gnu.org>
1615
1616 Fix execution of x selection hooks.
1617 * xselect.c (Qx_lost_selection_functions)
1618 (Qx_sent_selection_functions): New vars.
1619 (syms_of_xselect): DEFSYM them.
1620 (x_handle_selection_request): Pass Qx_sent_selection_functions
1621 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1622 (x_handle_selection_clear,x_clear_frame_selections):
1623 Pass Qx_lost_selection_functions rather than
1624 Vx_lost_selection_functions to Frun_hook_with_args.
1625
47ea7f44
PE
16262011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1627
ac389d0c 1628 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1629 The old code sometimes used this field without initializing it.
1630
47ea7f44
PE
1631 * alloc.c (gc_sweep): Don't read past end of array.
1632 In theory, the old code could also have corrupted Emacs internals,
1633 though it'd be very unlikely.
1634
bc985c87
AS
16352011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1636
1637 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1638 argument. (Bug#4026)
bc985c87 1639
0cf34688
LMI
16402011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1641
b3dadd76
LMI
1642 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1643 key" (bug#4257).
1644
0cf34688
LMI
1645 * window.c (Fset_window_start): Doc fix (bug#4199).
1646 (Fset_window_hscroll): Ditto.
1647
270768cd
PE
16482011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1649
077e3dda 1650 Fix minor new problems caught by GCC 4.6.1.
270768cd 1651 * term.c (init_tty): Remove unused local.
490011a6 1652 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1653 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1654 not used otherwise.
270768cd 1655
b1f58454
CY
16562011-07-12 Chong Yidong <cyd@stupidchicken.com>
1657
1658 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1659
22b9578d
LMI
16602011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1661
6e70ab07
LMI
1662 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1663 are the mini-buffer and the echo area (bug#3320).
1664
22b9578d
LMI
1665 * term.c (init_tty): Remove support for supdup, c10 and perq
1666 terminals, which are no longer supported (bug#1482).
1667
8974cc9f
JB
16682011-07-10 Johan Bockgård <bojohan@gnu.org>
1669
1670 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1671
a560d974
JD
16722011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1673
1674 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1675 for non-popups (Bug#3642).
1676
1dae0f0a
AS
16772011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1678
268c2c36 1679 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1680 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1681 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1682 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1683 * data.c (fmod): Likewise.
1684 * dispnew.c (swap_glyphs_in_rows): Likewise.
1685 * emacs.c (memory_warning_signal): Likewise.
1686 * floatfns.c (float_error): Likewise.
1687 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1688 (otf_open, font_otf_capability, generate_otf_features)
1689 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1690 Likewise.
1691 * image.c (pbm_read_file): Likewise.
1692 * indent.c (string_display_width): Likewise.
1693 * intervals.c (check_for_interval, search_for_interval)
1694 (inc_interval_count, count_intervals, root_interval)
1695 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1696 * lread.c (defalias): Likewise.
268c2c36 1697 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1698 * regex.c (set_image_of_range_1, set_image_of_range)
1699 (regex_grow_registers): Likewise.
1700 * sysdep.c (strerror): Likewise.
1701 * termcap.c (valid_filename_p, tprint, main): Likewise.
1702 * tparam.c (main): Likewise.
1703 * unexhp9k800.c (run_time_remap, save_data_space)
1704 (update_file_ptrs, read_header, write_header, calculate_checksum)
1705 (copy_file, copy_rest, display_header): Likewise.
1706 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1707 Likewise.
1708 * xdisp.c (check_it): Likewise.
1709 * xfaces.c (register_color, unregister_color, unregister_colors):
1710 Likewise.
1711 * xfns.c (print_fontset_result): Likewise.
1712 * xrdb.c (member, fatal, main): Likewise.
1713
99033785
PE
17142011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1715
1716 Fix minor problems found by static checking (Bug#9031).
1717 * chartab.c (char_table_set_range, map_sub_char_table):
1718 Remove unused locals.
1719 (uniprop_table): Now static.
1720 * composite.c (_work_char): Remove unused static var.
1721
9cb2ac56
JB
17222011-07-09 Juanma Barranquero <lekktu@gmail.com>
1723
1724 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1725
f25661f0
JD
17262011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1727
1728 * gtkutil.c (qttip_cb): Remove code without function.
1729
8278c4fe
EZ
17302011-07-09 Eli Zaretskii <eliz@gnu.org>
1731
1732 * w32.c (pthread_sigmask): New stub.
1733
1692ae2d 17342011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1735
8a6ebd58 1736 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1737 sigprocmask is portable only for single-threaded applications, and
1738 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1739 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1740 (LIBES): Use it.
1741 * callproc.c (Fcall_process):
1742 * process.c (create_process):
1743 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1744 Use pthread_sigmask, not sigprocmask.
123403e4 1745
1b854618
JD
17462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1747
1748 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1749 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1750 wrong (Bug#8591).
1751
3fe4b549
JD
17522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1753
0ce7e563
JD
1754 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1755 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1756 (xg_hide_tooltip): Fix comment.
1757
3fe4b549
JD
1758 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1759 in registerServicesMenuSendTypes.
1760 (validRequestorForSendType): Don't check ns_return_types.
1761
1762 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1763 ns_return_type.
1764
5df75e47
JR
17652011-07-08 Jason Rumney <jasonr@gnu.org>
1766
1767 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1768 frame struct members of non-existent frames (Bug#6284).
1769
699c10bd
JD
17702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1771
4393663b
JD
1772 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1773 variable firstTime not needed on OSX >= 10.6.
1774 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1775 >= 10.5. Use setKnobProportion, setDoubleValue.
1776
1777 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1778 (MAC_OS_X_VERSION_10_5): Define if not defined.
1779 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1780 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1781 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1782
1783 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1784 cString and lossyCString on OSX >= 10.4
1785
1786 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1787 sizeToFit on OSX >= 10.2.
1788
1789 * nsimage.m (allocInitFromFile): Don't use deprecated method
1790 bestRepresentationForDevice on OSX >= 10.6.
1791
1792 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1793 to avoid warning.
1794
1795 * emacs.c: Declare unexec_init_emacs_zone.
1796
a63e0781
JD
1797 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1798
699c10bd
JD
1799 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1800
1801 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1802 on svcsMenu (Bug#8842).
1803
1804 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1805 ns_return_types.
1806 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1807
1808 * nsterm.m (QUTF8_STRING): Declare.
1809 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1810 (validRequestorForSendType): Return type is (id).
1811 Change indexOfObjectIdenticalTo to indexOfObject.
1812 Check if we have local selection before returning self (Bug#8842).
1813 (writeSelectionToPasteboard): Put local selection into paste board
1814 if we have a local selection (Bug#8842).
1815 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1816
1817 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1818 (ns_get_local_selection): Declare.
1819
54e10184
LMI
18202011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1821
9888ff71
LMI
1822 * keymap.c (describe_map_tree): Don't insert a double newline at
1823 the end of the buffer (bug#1169) and return whether we inserted
1824 something.
1825
54e10184
LMI
1826 * callint.c (Fcall_interactively): Change "reading args" to
1827 "providing args" to try to clarify what it does (bug#1010).
1828
15fa4783
KH
18292011-07-07 Kenichi Handa <handa@m17n.org>
1830
1831 * composite.c (composition_compute_stop_pos): Ignore a static
1832 composition starting before CHARPOS (Bug#8915).
1833
1834 * xdisp.c (handle_composition_prop): Likewise.
1835
a8815b00
EZ
18362011-07-07 Eli Zaretskii <eliz@gnu.org>
1837
1838 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1839 (Bug#9015)
1840
ef7b981d 18412011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1842
1843 * character.h (unicode_category_t): New enum type.
1844
1845 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1846 (Qchar_code_property_table): New variable.
1847 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1848 (UNIPROP_COMPRESSED_FORM_P): New macros.
1849 (char_table_ascii): Uncompress the compressed values.
1850 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1851 Uncompress the compressed values.
ac389d0c 1852 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1853 (char_table_ref_and_range): Uncompress the compressed values.
1854 (sub_char_table_set): New arg is_uniprop. Callers changed.
1855 Uncompress the compressed values.
1856 (sub_char_table_set_range): Args changed. Callers changed.
1857 (char_table_set_range): Adjuted for the above change.
1858 (map_sub_char_table): Delete args default_val and parent. Add arg
1859 top. Give decoded values to a Lisp function.
640c8776 1860 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1861 values to a Lisp function. Gcpro more variables.
1862 (uniprop_table_uncompress)
1863 (uniprop_decode_value_run_length): New functions.
1864 (uniprop_decoder, uniprop_decoder_count): New variables.
1865 (uniprop_get_decoder, uniprop_encode_value_character)
1866 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1867 New functions.
1868 (uniprop_encoder, uniprop_encoder_count): New variables.
1869 (uniprop_get_encoder, uniprop_table)
1870 (Funicode_property_table_internal, Fget_unicode_property_internal)
1871 (Fput_unicode_property_internal): New functions.
1872 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1873 Sunicode_property_table_internal, Sget_unicode_property_internal,
1874 and Sput_unicode_property_internal. Defvar_lisp
1875 char-code-property-alist.
1876
640c8776 1877 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1878 Vunicode_category_table.
1879
640c8776 1880 * font.c (font_range): Adjust for the change of
c805dec0
KH
1881 Vunicode_category_table.
1882
76b397fb
DN
18832011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1884
1885 * m/iris4d.h: Remove file, move contents ...
1886 * s/irix6-5.h: ... here.
1887
22b4128e
PE
18882011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1891 * alloc.c (mark_buffer):
1892 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1893 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1894 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1895 This isn't true in general, and it's particularly not true
1896 if Emacs is configured with --with-wide-int.
1897 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1898 New macros, used in the buffer.c change.
1899
869795d6
JD
19002011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1901
1902 * xsettings.c: Use both GConf and GSettings if both are available.
1903 (store_config_changed_event): Add comment.
1904 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1905 (store_tool_bar_style_changed): New functions.
1906 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1907 (struct xsettings): Move font inside HAVE_XFT.
1908 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1909 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1910 Move inside HAVE_XFT.
640c8776 1911 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1912 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1913 also.
1914 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1915 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1916 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1917 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1918 (parse_settings): Move check for font inside HAVE_XFT.
1919 (read_settings, apply_xft_settings): Add comment.
1920 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1921 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1922 call store_font_name_changed.
1923 (xft_settings_event): Add comment.
1924 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1925 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1926 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1927 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1928 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1929 (xsettings_get_system_font, xsettings_get_system_normal_font):
1930 Add comment.
869795d6 1931
d8ed26bd
PE
19322011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1933
1934 Random fixes. E.g., (random) never returned negative values.
1935 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1936 subseconds part to the entropy, as that's a bit more random.
1937 Prefer signed to unsigned, since the signedness doesn't matter and
1938 in general we prefer signed. When given a limit, use a
1939 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1940 latter isn't right if USE_2_TAGS_FOR_INTS.
1941 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1942 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1943
cabf1cac
SM
19442011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1945
1946 * textprop.c (text_property_stickiness):
1947 Obey Vtext_property_default_nonsticky.
1948 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1949 * w32fns.c (syms_of_w32fns):
1950 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1951
6e9b2be9
PE
19522011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1953
1954 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1955 This is more efficient than Ffile_directory_p and avoids a minor race.
1956
90186c68
LMI
19572011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1958
7c301272
LMI
1959 * buffer.c (Foverlay_put): Say what the return value is
1960 (bug#7835).
1961
c4f2d8d4
LMI
1962 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1963 is a directory before asking whether to use the file name
1964 (bug#7564).
ad637907
LMI
1965 (barf_or_query_if_file_exists): Make the "File is a directory"
1966 error be more correct.
c4f2d8d4 1967
90186c68
LMI
1968 * fns.c (Frequire): Remove the mention of the .gz files, since
1969 that's installation-specific, but keep the mention of
1970 `get-load-suffixes'.
1971
da64016e
PE
19722011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1975 Report string overflow if the output is too long.
1976
7d47b580
JB
19772011-07-04 Juanma Barranquero <lekktu@gmail.com>
1978
a555cb87
JB
1979 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1980 (syms_of_gnutls): Remove duplicate DEFSYM for
1981 Qgnutls_bootprop_verify_hostname_error, an error for
1982 Qgnutls_bootprop_verify_error (which is no longer used).
1983
7d47b580
JB
1984 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1985 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1986 Also (re)move comments that are misplaced or no longer relevant.
1987
1e49bfab
LMI
19882011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1989
1990 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1991
1485f4c0
CY
19922011-07-03 Chong Yidong <cyd@stupidchicken.com>
1993
1994 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1995 and background color parameters if they have been changed.
1996
a9ab721e
LMI
19972011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1998
1999 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2000
cf7cff57
PE
20012011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2002
2e13213d
PE
2003 * xsettings.c (SYSTEM_FONT): Define only when used.
2004 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2005
cf7cff57
PE
2006 * keymap.c (access_keymap_1): Now static.
2007
7a8e04f7
CY
20082011-07-02 Chong Yidong <cyd@stupidchicken.com>
2009
2010 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2011 leave any prefix arg for the up event (Bug#1586).
2012
61352f62
LMI
20132011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2014
69bb1ef7
LMI
2015 * lread.c (syms_of_lread): Mention single symbols defined by
2016 `defvar' or `defconst' (bug#7154).
2017
61352f62 2018 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2019 (Frequire): Mention get-load-suffixes.
61352f62 2020
28545e04
MR
20212011-07-02 Martin Rudalics <rudalics@gmx.at>
2022
2023 * window.h (window): Remove clone_number slot.
2024 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2025 Remove.
2026 (make_parent_window, make_window, saved_window)
2027 (Fset_window_configuration, save_window_save): Don't deal with
2028 clone numbers.
2029 * buffer.c (Qclone_number): Remove declaration.
2030 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2031
3349e122
SM
20322011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2033
2034 Add multiple inheritance to keymaps.
2035 * keymap.c (Fmake_composed_keymap): New function.
2036 (Fset_keymap_parent): Simplify.
2037 (fix_submap_inheritance): Remove.
2038 (access_keymap_1): New function extracted from access_keymap to handle
2039 embedded parents and handle lists of maps.
2040 (access_keymap): Use it.
2041 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2042 (Fcopy_keymap): Handle embedded parents.
2043 (Fcommand_remapping, define_as_prefix): Simplify.
2044 (Fkey_binding): Simplify.
2045 (syms_of_keymap): Move minibuffer-local-completion-map,
2046 minibuffer-local-filename-completion-map,
2047 minibuffer-local-must-match-map, and
2048 minibuffer-local-filename-must-match-map to Elisp.
2049 (syms_of_keymap): Defsubr make-composed-keymap.
2050 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2051 (parse_menu_item): Trivial simplification.
2052
3279eb87
GM
20532011-07-01 Glenn Morris <rgm@gnu.org>
2054
2055 * Makefile.in (SETTINGS_LIBS): Fix typo.
2056
4550efdf
KI
20572011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2058
2059 * coding.c (Fencode_coding_string): Record the last coding system
2060 used, as the function doc string says (bug#8738).
2061
0949d2b6
JD
20622011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2063
2064 * xsettings.c (store_monospaced_changed): Take new font as arg and
2065 check for change against current_mono_font.
2066 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2067 (emacs_settings_constructor, emacs_settings_get_property)
2068 (emacs_settings_set_property, emacs_settings_class_init)
2069 (emacs_settings_init, gsettings_obj): Remove.
2070 (something_changedCB): New function for HAVE_GSETTINGS.
2071 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2072 with value as argument.
2073 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2074 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2075 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2076 "changed".
2077
2078 * xgselect.c: Add defined (HAVE_GSETTINGS).
2079 (xgselect_initialize): Ditto.
2080
2081 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2082 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2083 xg_select.
2084
bbc6b304
PE
20852011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2086
2087 * eval.c (struct backtrace): Simplify and port the data structure.
2088 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2089 signed bit field, as this assumption is not portable and it makes
2090 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2091 "char debug_on_exit : 1" as this is not portable either; instead,
2092 use the portable "unsigned int debug_on_exit : 1". Remove unused
2093 member evalargs. Remove obsolete comments about cc bombing out.
2094
9851bfc5
JD
20952011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2096
51bb811f 2097 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2098 Let HAVE_GSETTINGS override HAVE_GCONF.
2099 (store_monospaced_changed): New function.
2100 (EMACS_SETTINGS): A new type derived from GObject to handle
2101 GSettings notifications.
2102 (emacs_settings_constructor, emacs_settings_get_property)
2103 (emacs_settings_set_property, emacs_settings_class_init):
2104 New functions.
2105 (gsettings_client, gsettings_obj): New variables.
2106 (GSETTINGS_SCHEMA): New define.
2107 (something_changedCB): Call store_monospaced_changed.
2108 (init_gsettings): New function.
2109 (xsettings_initialize): Call init_gsettings.
2110 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2111 to NULL.
2112
640c8776 2113 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2114 GCONF_CFLAGS/LIBS.
2115
5386012d
MR
21162011-06-29 Martin Rudalics <rudalics@gmx.at>
2117
2118 * window.c (resize_root_window, grow_mini_window)
2119 (shrink_mini_window): Rename Qresize_root_window to
2120 Qwindow_resize_root_window and Qresize_root_window_vertically to
2121 Qwindow_resize_root_window_vertically.
2122
f13e0b08
PE
21232011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2124
2125 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2126
94515237
JB
21272011-06-27 Juanma Barranquero <lekktu@gmail.com>
2128
2129 * makefile.w32-in: Redesign dependencies so they reflect more
2130 clearly which files are directly included by each source file,
2131 and not through other includes.
2132
e43b6e43
MR
21332011-06-27 Martin Rudalics <rudalics@gmx.at>
2134
2135 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2136 (sort_overlays, overlay_strings): When an overlay's clone number
2137 matches the window's clone number process the overlay even if
2138 the overlay's window property doesn't match the current window.
2139
d68443dc
MR
2140 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2141 (Fwindow_hchild): Rename to Fwindow_left_child.
2142 (Fwindow_next): Rename to Fwindow_next_sibling.
2143 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2144 (resize_window_check): Rename to window_resize_check.
2145 (resize_window_apply): Rename to window_resize_apply.
2146 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2147 (Fdelete_other_windows_internal, resize_frame_windows)
2148 (Fsplit_window_internal, Fdelete_window_internal)
2149 (grow_mini_window, shrink_mini_window)
2150 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2151
c7e73be5
JD
21522011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2153
2154 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2155 (emacs_fixed_set_min_size): Remove.
2156 (emacs_fixed_new): Take frame as argument.
2157
2158 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2159 (_EmacsFixedPrivate): Remove minwidth/height.
2160 Add struct frame *f.
2161 (emacs_fixed_init): Initialize priv->f.
2162 (get_parent_class, emacs_fixed_set_min_size): Remove.
2163 (emacs_fixed_new): Set priv->f to argument.
2164 (emacs_fixed_get_preferred_width)
2165 (emacs_fixed_get_preferred_height): Use min_width/height from
2166 frames size_hint to set minimum and natural (Bug#8919).
2167 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2168 and use min_width/height from frames size_hint to set
2169 min_width/height (Bug#8919).
2170
2171 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2172 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2173 Fix indentation.
c7e73be5 2174
cf99dcf8
EZ
21752011-06-26 Eli Zaretskii <eliz@gnu.org>
2176
2177 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2178 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2179 called at ZV.
2180
029529ac
CY
21812011-06-26 Chong Yidong <cyd@stupidchicken.com>
2182
2183 * process.c (wait_reading_process_output): Bypass select if
2184 waiting for a cell while ignoring keyboard input, and input is
2185 pending. Suggested by Jan Djärv (Bug#8869).
2186
7a7ef429
PE
21872011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2188
2189 Use gnulib's dup2 module instead of rolling our own.
2190 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2191
11fdef7d 21922011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2193
2194 * dispnew.c (scrolling_window): Before scrolling, turn off a
2195 mouse-highlight in the window being scrolled.
2196
cd3520a4
JB
21972011-06-24 Juanma Barranquero <lekktu@gmail.com>
2198
2199 Move DEFSYM to lisp.h and use everywhere.
2200
2201 * character.h (DEFSYM): Move declaration...
2202 * lisp.h (DEFSYM): ...here.
2203
2204 * gnutls.c:
2205 * minibuf.c:
2206 * w32menu.c:
2207 * w32proc.c:
2208 * w32select.c: Don't include character.h.
2209
2210 * alloc.c (syms_of_alloc):
2211 * buffer.c (syms_of_buffer):
2212 * bytecode.c (syms_of_bytecode):
2213 * callint.c (syms_of_callint):
2214 * casefiddle.c (syms_of_casefiddle):
2215 * casetab.c (init_casetab_once):
2216 * category.c (init_category_once, syms_of_category):
2217 * ccl.c (syms_of_ccl):
2218 * cmds.c (syms_of_cmds):
2219 * composite.c (syms_of_composite):
2220 * dbusbind.c (syms_of_dbusbind):
2221 * dired.c (syms_of_dired):
2222 * dispnew.c (syms_of_display):
2223 * doc.c (syms_of_doc):
2224 * editfns.c (syms_of_editfns):
2225 * emacs.c (syms_of_emacs):
2226 * eval.c (syms_of_eval):
2227 * fileio.c (syms_of_fileio):
2228 * fns.c (syms_of_fns):
2229 * frame.c (syms_of_frame):
2230 * fringe.c (syms_of_fringe):
2231 * insdel.c (syms_of_insdel):
2232 * keymap.c (syms_of_keymap):
2233 * lread.c (init_obarray, syms_of_lread):
2234 * macros.c (syms_of_macros):
2235 * msdos.c (syms_of_msdos):
2236 * print.c (syms_of_print):
2237 * process.c (syms_of_process):
2238 * search.c (syms_of_search):
2239 * sound.c (syms_of_sound):
2240 * syntax.c (init_syntax_once, syms_of_syntax):
2241 * terminal.c (syms_of_terminal):
2242 * textprop.c (syms_of_textprop):
2243 * undo.c (syms_of_undo):
2244 * w32.c (globals_of_w32):
2245 * window.c (syms_of_window):
2246 * xdisp.c (syms_of_xdisp):
2247 * xfaces.c (syms_of_xfaces):
2248 * xfns.c (syms_of_xfns):
2249 * xmenu.c (syms_of_xmenu):
2250 * xsettings.c (syms_of_xsettings):
2251 * xterm.c (syms_of_xterm): Use DEFSYM.
2252
4228cf16
TZ
22532011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2254
cd3520a4 2255 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2256
7fcccf1e
PE
22572011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2258
7efb4e0e
PE
2259 Integer and buffer overflow fixes (Bug#8873).
2260
ff5844ad
PE
2261 * print.c (printchar, strout): Check for string overflow.
2262 (PRINTPREPARE, printchar, strout):
2263 Don't set size unless allocation succeeds.
2264
90532f02
PE
2265 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2266 for sizes. Check for string overflow more accurately.
2267 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2268
6d84508d
PE
2269 * macros.c: Integer and buffer overflow fixes.
2270 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2271 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2272 Use ptrdiff_t, not int, for sizes.
2273 Don't increment bufsize until after realloc succeeds.
2274 Check for size-calculation overflow.
2275 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2276
437b2cb4
PE
2277 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2278
8b9ac8b4
PE
2279 * lread.c: Integer overflow fixes.
2280 (read_integer): Radix is now EMACS_INT, not int,
2281 to improve quality of diagnostics for out-of-range radices.
2282 Calculate buffer size correctly for out-of-range radices.
2283 (read1): Check for integer overflow in radices, and in
2284 read-circle numbers.
82cb60d3
PE
2285 (read_escape): Avoid int overflow.
2286 (Fload, openp, read_buffer_size, read1)
2287 (substitute_object_recurse, read_vector, read_list, map_obarray):
2288 Use ptrdiff_t, not int, for sizes.
2289 (read1): Use EMACS_INT, not int, for sizes.
20270765 2290 Check for size overflow.
8b9ac8b4 2291
7fcccf1e
PE
2292 * image.c (cache_image): Check for size arithmetic overflow.
2293
bfbbd7e7
PE
2294 * lread.c: Integer overflow issues.
2295 (saved_doc_string_size, saved_doc_string_length)
2296 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2297 Now ptrdiff_t, not int.
2298 (read1): Don't assume doc string length fits in int. Check for
2299 out-of-range doc string lengths.
2300 (read_list): Don't assume file position fits in int.
39019e54 2301 (read_escape): Check for hex character overflow.
bfbbd7e7 2302
4e323265
LL
23032011-06-22 Leo Liu <sdl.web@gmail.com>
2304
2305 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2306 Move to minibuffer.el.
2307
85fece3e
PE
23082011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2309
20b84ce9 2310 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2311 The following patches are for when GLYPH_DEBUG && !XASSERT.
2312 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2313 * dispnew.c (flush_stdout):
2314 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2315 Mark as externally visible.
2316 * dispnew.c (check_window_matrix_pointers): Now static.
2317 * dispnew.c (window_to_frame_vpos):
2318 * xfns.c (unwind_create_frame):
2319 * xterm.c (x_check_font): Remove unused local.
2320 * scroll.c (CHECK_BOUNDS):
2321 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2322 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2323 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2324 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2325 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2326 Now static.
2327 (debug_method_add): Use va_list and vsprintf rather than relying
2328 on undefined behavior with wrong number of arguments.
2329 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2330 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2331 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2332 since we're not interested in debugging glyphs with old libraries.
2333 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2334 GCC 4.6.0's static checking.
2335
0766b489
PE
23362011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2337
31fd4b32
PE
2338 Integer overflow and signedness fixes (Bug#8873).
2339 A few related buffer overrun fixes, too.
2340
b79e8648
PE
2341 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2342
0766b489
PE
2343 * dispextern.h (struct face.stipple):
2344 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2345 (x_bitmap_mask, x_allocate_bitmap_record)
2346 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2347 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2348 (x_create_bitmap_from_xpm_data):
2349 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2350 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2351 (.bitmaps_last):
2352 * xfaces.c (load_pixmap):
2353 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2354 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2355 (.bitmaps_last, struct x_output.icon_bitmap):
2356 Use ptrdiff_t, not int, for bitmap indexes.
2357 (x_allocate_bitmap_record): Check for size overflow.
2358 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2359
b081724f
PE
2360 Use ptrdiff_t, not int, for overlay counts.
2361 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2362 * editfns.c (overlays_around, get_pos_property):
2363 * textprop.c (get_char_property_and_overlay):
2364 * xdisp.c (next_overlay_change, note_mouse_highlight):
2365 * xfaces.c (face_at_buffer_position):
21514da7
PE
2366 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2367 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2368 (Fnext_overlay_change, Fprevious_overlay_change)
2369 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2370 Use ptrdiff_t, not int, for sizes.
21514da7 2371 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2372
3de73e5e
PE
2373 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2374
2606c57b
PE
2375 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2376 (x_session_initialize): Do not assume string length fits in int.
2377
aaafe47a
PE
2378 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2379 This is unlikely, but can occur if DPI is outlandish.
2380
2674ddc8 2381 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2382 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2383
28154962
PE
2384 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2385 * xrdb.c (magic_file_p, search_magic_path):
2386 Omit last arg SUFFIX; it was always 0. All callers changed.
2387 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2388
7de51af5
PE
2389 * xfont.c (xfont_match): Avoid need for strlen.
2390
25ed6cc3
PE
2391 * xfns.c: Don't assume strlen fits in int.
2392 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2393
4eab31dd
PE
2394 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2395 not unsigned long, as we prefer signed integers. All callers changed.
2396 Detect integer overflow in repeat count.
2397 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2398 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2399
171e2a58
PE
2400 * termcap.c: Don't assume sizes fit in int and never overflow.
2401 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2402 (gobble_line): Check for size-calculation overflow.
2403
ad39faca 2404 * minibuf.c (Fread_buffer):
6e5bb2dc 2405 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2406 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2407 Don't assume string length fits in int.
2408
52c61c22 2409 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2410 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2411
b5b8c9e5
PE
2412 * font.c: Don't assume string length fits in int.
2413 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2414 Use ptrdiff_t, not int.
ccd6111c
PE
2415 (font_intern_prop): Don't assume string length fits in int.
2416 Don't assume integer property fits in fixnum.
2417 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2418
882f0d81 2419 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2420 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2421 Reformulate so as not to need the command string.
2422 Invoke gzip -cd rather than gunzip, as it's more portable.
2423 (lock_info_type, lock_file_1, lock_file):
2424 Don't assume pid_t and time_t fit in unsigned long.
2425 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2426 (current_lock_owner): Prefer signed type for sizes.
2427 Use memcpy, not strncpy, where memcpy is what is really wanted.
2428 Don't assume (via atoi) that time_t and pid_t fit in int.
2429 Check for time_t and/or pid_t out of range, e.g., via a network share.
2430 Don't alloca where an auto var works fine.
2431
93f4cf88
PE
2432 * fileio.c: Fix some integer overflow issues.
2433 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2434 Don't assume string length fits in int.
2435 (directory_file_name): Don't assume string length fits in long.
2436 (make_temp_name): Don't assume pid fits in int, or that its print
2437 length is less than 20.
2438
f3e92b69
PE
2439 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2440
1bfdaf10
PE
2441 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2442
35016e9a
PE
2443 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2444
3d1e65a1
PE
2445 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2446 We prefer signed integers, even for size calculations.
2447
0b963a93
PE
2448 * emacs.c: Don't assume string length fits in 'int'.
2449 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2450 (main): Don't invoke strlen when not needed.
2451
573f4b54
PE
2452 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2453 (XD_DEBUG_MESSAGE): Don't waste a byte.
2454
989f33ba
PE
2455 * callproc.c (getenv_internal_1, getenv_internal)
2456 (Fgetenv_internal):
965d34eb
PE
2457 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2458
e4d29b33
PE
2459 * lread.c (invalid_syntax): Omit length argument.
2460 All uses changed. This doesn't fix a bug, but it simplifies the
2461 code away from its former Hollerith-constant appearance, and it's
2462 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2463 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2464
eb49b136
PE
2465 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2466 This didn't break anything, but it didn't help either.
2467 It's confusing to put a bogus integer in a place where the actual
2468 value does not matter.
9f62aeb1 2469 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2470 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2471
15375a22
PE
2472 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2473 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2474 implementation.
b61cc01c
PE
2475 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2476 We prefer signed types, and the value cannot exceed the EMACS_INT
2477 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2478 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2479 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2480 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2481
53b2623d
PE
2482 * indent.c (sane_tab_width): New function.
2483 (current_column, scan_for_column, Findent_to, position_indentation)
2484 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2485 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2486
51cab52b 2487 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2488
f2ed8a70
PE
2489 * lisp.h (lint_assume): New macro.
2490 * composite.c (composition_gstring_put_cache):
2491 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2492
abe80cc6
PE
2493 * editfns.c, insdel.c:
2494 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2495
b02c740e
PE
2496 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2497
ebc96716
PE
2498 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2499
b4e50fa0 2500 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2501 Use much-faster test for byte-length change.
311d5d7c 2502 Don't assume string byte-length fits in 'int'.
a4cf38e4 2503 Check that character arg fits in 'int'.
85461888 2504 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2505
c0c1ee9f
PE
2506 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2507
a498d7f4
PE
2508 * fns.c (concat): Catch string overflow earlier.
2509 Do not rely on integer wraparound.
2510
51cab52b
PE
2511 * dispextern.h (struct it.overlay_strings_charpos)
2512 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2513 * xdisp.c (forward_to_next_line_start)
2514 (back_to_previous_visible_line_start)
2515 (reseat_at_next_visible_line_start, next_element_from_buffer):
2516 Don't arbitrarily truncate the value of 'selective' to int.
2517
76031fad
PE
2518 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2519
5eb55db9
PE
2520 * composite.c: Don't truncate sizes to 'int'.
2521 (composition_gstring_p, composition_reseat_it)
2522 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2523 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2524 not EMACS_UINT, for indexes.
5eb55db9 2525
0703a717
PE
2526 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2527
d6202519
PE
2528 * buffer.c: Include <verify.h>.
2529 (struct sortvec.priority, struct sortstr.priority):
8961a454 2530 Now EMACS_INT, not int.
c20998a7 2531 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2532 (struct sortstr.size, record_overlay_string)
2533 (struct sortstrlist.size, struct sortlist.used):
2534 Don't truncate size to int.
2535 (record_overlay_string): Check for size-calculation overflow.
d6202519 2536 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2537
d5a19415
JM
25382011-06-22 Jim Meyering <meyering@redhat.com>
2539
029529ac 2540 Don't leak an XBM-image-sized buffer
d5a19415
JM
2541 * image.c (xbm_load): Free the image buffer after using it.
2542
a9041e6c
PE
25432011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2544
2545 Port to Sun C.
2546 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2547 that Sun C diagnosed.
2548 * fns.c (secure_hash): Fix pointer signedness issue.
2549 * intervals.c (static_offset_intervals): New function.
2550 (offset_intervals): Use it.
2551
7f3f739f
LL
25522011-06-21 Leo Liu <sdl.web@gmail.com>
2553
2554 * deps.mk (fns.o):
2555 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2556 sha512.h.
2557
2558 * fns.c (secure_hash): Rename from crypto_hash_function and change
2559 the first arg to accept symbols.
5b66d427 2560 (Fsecure_hash): New primitive.
7f3f739f
LL
2561 (syms_of_fns): New symbols.
2562
76147d94
DD
25632011-06-20 Deniz Dogan <deniz@dogan.se>
2564
2565 * process.c (Fset_process_buffer): Clarify return value in
2566 docstring.
2567
7d7d0045
CY
25682011-06-18 Chong Yidong <cyd@stupidchicken.com>
2569
2570 * dispnew.c (add_window_display_history): Use BVAR.
2571
2572 * xdisp.c (debug_method_add): Use BVAR.
2573 (check_window_end, dump_glyph_matrix, dump_glyph)
2574 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2575
2576 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2577 Likewise.
2578
2579 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2580 check till after the cache is created in init_frame_faces.
2581
ff2bc410
SM
25822011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2583
2584 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2585
28177add
PE
25862011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2587
dd3482fe
PE
2588 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2589 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2590 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2591
393d71f3 2592 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2593 * fileio.c (Finsert_file_contents):
2594 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2595 Remove the old (too-loose) buffer overflow checks.
2596 They weren't needed, since make_gap checks for buffer overflow.
2597 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2598 The old code merely checked for Emacs fixnum overflow, and relied
2599 on undefined (wraparound) behavior. The new code avoids undefined
2600 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2601
2e6813b0 2602 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2603 Tune. Don't use wider integers than needed. Don't use alloca.
2604 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2605
599a9e4f
PE
2606 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2607
99561444
PE
2608 * insdel.c, lisp.h (buffer_overflow): New function.
2609 (insert_from_buffer_1, replace_range, replace_range_2):
2610 * insdel.c (make_gap_larger):
2611 * editfns.c (Finsert_char):
2612 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2613
28177add
PE
2614 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2615
e69dafad
PE
26162011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2617
a7af7fde 2618 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2619
b1c46f02
PE
2620 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2621 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2622
e69dafad
PE
2623 * fileio.c: Don't assume EMACS_INT fits in off_t.
2624 (emacs_lseek): New static function.
2625 (Finsert_file_contents, Fwrite_region): Use it.
2626 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2627
566684ea
PE
2628 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2629
e6966cd6
PE
2630 * fns.c: Don't overflow int when computing a list length.
2631 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2632 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2633 truncation on 64-bit hosts. Check for QUIT every
2634 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2635 faster and is responsive enough.
2636 (Flength): Report an error instead of overflowing an integer.
2637 (Fsafe_length): Return a float if the value is not representable
2638 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2639 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2640 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2641
dd0b0efb
PE
2642 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2643 (header_size, word_size): New constants.
2644 (allocate_vectorlike): Don't check size overflow here.
2645 (allocate_vector): Check it here instead, since this is the only
2646 caller of allocate_vectorlike that could cause overflow.
2647 Check that the new vector's length is representable as a fixnum.
2648
86fe5cfe
PE
2649 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2650 The previous code was bogus. For example, next_almost_prime (32)
2651 returned 39, which is undesirable as it is a multiple of 3; and
2652 next_almost_prime (24) returned 25, which is a multiple of 5 so
2653 why was the code bothering to check for multiples of 7?
2654
80e88859
PE
2655 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2656
4a2f0ad6
PE
2657 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2658
f66c7cf8
PE
2659 Variadic C functions now count arguments with ptrdiff_t.
2660 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2661 Back then I didn't know that the Emacs coding style prefers signed int.
2662 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2663 were being counted with int, which may truncate counts on 64-bit
2664 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2665 * lisp.h (struct Lisp_Subr.function.aMANY)
2666 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2667 Arg counts are now ptrdiff_t, not size_t.
2668 All variadic functions and their callers changed accordingly.
2669 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2670 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2671 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2672 * callint.c (Fcall_interactively): Check arg count for overflow,
2673 to avoid potential buffer overrun. Use signed char, not 'int',
2674 for 'varies' array, so that we needn't bother to check its size
2675 calculation for overflow.
2676 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2677 * eval.c (apply_lambda):
2678 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2679 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2680 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2681
a1759b76
PE
2682 * callint.c (Fcall_interactively): Don't use index var as event count.
2683
d96be9fc
PE
2684 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2685 * mem-limits.h (SIZE): Remove; no longer used.
2686
a690a978 2687 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2688
578c21e6
PE
2689 Remove unnecessary casts.
2690 * xterm.c (x_term_init):
2691 * xfns.c (x_set_border_pixel):
2692 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2693 These aren't needed now that we assume ANSI C.
2694
96f53c6c
PE
2695 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2696 It's more likely to cause problems (due to unsigned overflow)
2697 than to cure them.
2698
83c77d31
PE
2699 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2700
ee2079f1
PE
2701 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2702
6da65536
PE
2703 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2704
7147c4a4
PE
2705 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2706
193e32d9
PE
2707 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2708
e5533da6
PE
2709 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2710
9910e595
PE
2711 GLYPH_CODE_FACE returns EMACS_INT, not int.
2712 * dispextern.h (merge_faces):
2713 * xfaces.c (merge_faces):
01103c44
PE
2714 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2715 Don't assume EMACS_INT fits in int.
9910e595 2716
2638320e
PE
2717 * character.h (CHAR_VALID_P): Remove unused parameter.
2718 * fontset.c, lisp.h, xdisp.c: All uses changed.
2719
045eb8d9
PE
2720 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2721
c1f134b5
PE
2722 * fns.c (concat): Minor tuning based on overflow analysis.
2723 This doesn't fix any bugs. Use int to hold character, instead
2724 of constantly refetching from Emacs object. Use XFASTINT, not
2725 XINT, for value known to be a character. Don't bother comparing
2726 a single byte to 0400, as it's always less.
2727
395fcb93 2728 * floatfns.c (Fexpt):
327eeec8
PE
2729 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2730
abbd3d23
PE
2731 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2732 for characters.
2733
684a03ef
PE
2734 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2735
0fed43f3
PE
2736 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2737 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2738 incorrectly succeed when S was a string, because 4294967386 was
2739 truncated before it was used.
2740
8fd02eb7
PE
2741 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2742 Otherwise, an out-of-range integer could cause undefined behavior
2743 on a 64-bit host.
2744
f8c86b69
PE
2745 * composite.c: Use int, not EMACS_INT, for characters.
2746 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2747 EMACS_INT, for values that are known to be in character range.
2748 This doesn't fix any bugs but is the usual style inside Emacs and
2749 may generate better code on 32-bit machines.
2750
34206dd2
PE
2751 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2752 This is for reasons similar to the recent CHAR_STRING fix.
2753 * charset.c (Fencode_char): Check that character arg is actually
2754 a character. Pass an int to ENCODE_CHAR.
2755 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2756 wider than 'int', as a compile-time check to prevent future regressions
2757 in this area.
2758
c5958d4c 2759 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2760
2761 Make sure a 64-bit char is never passed to CHAR_STRING.
2762 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2763 by silently ignoring the top 32 bits, allowing some values
2764 that were far too large to be valid characters.
2765 * character.h: Include <verify.h>.
2766 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2767 arguments are no wider than unsigned, as a compile-time check
2768 to prevent future regressions in this area.
2769 * data.c (Faset):
01103c44 2770 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2771 (Fsubst_char_in_region):
2772 * fns.c (concat):
2773 * xdisp.c (decode_mode_spec_coding):
2774 Adjust to CHAR_STRING's new requirement.
2775 * editfns.c (Finsert_char, Fsubst_char_in_region):
2776 * fns.c (concat): Check that character args are actually
2777 characters. Without this test, these functions did the wrong
2778 thing with wildly out-of-range values on 64-bit hosts.
2779
d37ca623
PE
2780 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2781 These casts should not be needed on 32-bit hosts, either.
2782 * keyboard.c (read_char):
2783 * lread.c (Fload): Remove casts to unsigned.
2784
ea204efb
PE
2785 * lisp.h (UNSIGNED_CMP): New macro.
2786 This fixes comparison bugs on 64-bit hosts.
2787 (ASCII_CHAR_P): Use it.
2788 * casefiddle.c (casify_object):
01103c44 2789 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2790 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2791 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2792 * dispextern.h (FACE_FROM_ID):
2793 * keyboard.c (read_char): Use UNSIGNED_CMP.
2794
41cb286c
PE
2795 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2796 not to EMACS_INT, to avoid GCC warning.
2797
4a1b9832
PE
2798 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2799
55daad71
PE
2800 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2801 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2802 isn't needed on 32-bit machines.
8f95c75c 2803
01103c44
PE
2804 * buffer.c (Fgenerate_new_buffer_name):
2805 Use EMACS_INT for count, not int.
0ceccced 2806 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2807
2808 * data.c (Qcompiled_function): Now static.
2809
c6f072e7
PE
2810 * window.c (window_body_lines): Now static.
2811
20ce5912
PE
2812 * image.c (gif_load): Rename local to avoid shadowing.
2813
9c4c5f81
PE
2814 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2815 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2816 * alloc.c (make_save_value): Integer argument is now of type
2817 ptrdiff_t, not int.
2818 (mark_object): Use ptrdiff_t, not int.
2819 * lisp.h (pD): New macro.
2820 * print.c (print_object): Use it.
2821
c0c5c8ae
PE
2822 * alloc.c: Use EMACS_INT, not int, to count objects.
2823 (total_conses, total_markers, total_symbols, total_vector_size)
2824 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2825 (total_free_floats, total_floats, total_free_intervals)
2826 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2827 Now EMACS_INT, not int. All uses changed.
2828 (Fgarbage_collect): Compute overall total using a double, so that
2829 integer overflow is less likely to be a problem. Check for overflow
2830 when converting back to an integer.
5a25e253
PE
2831 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2832 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2833 These were 'int' variables that could overflow on 64-bit hosts;
2834 they were never used, so remove them instead of repairing them.
211a0b2a 2835 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2836 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2837 Previously, this ceilinged at INT_MAX, but that doesn't work on
2838 64-bit machines.
e46bb31a 2839 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2840
c78baabf 2841 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2842 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2843 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2844 when a (possibly-narrower) signed value would do just as well.
2845 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2846
c9d624c6
PE
2847 * alloc.c: Catch some string size overflows that we were missing.
2848 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2849 for convenience in STRING_BYTES_MAX.
2850 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2851 The definition here is exact; the one in lisp.h was approximate.
2852 (allocate_string_data): Check for string overflow. This catches
2853 some instances we weren't catching before. Also, it catches
2854 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2855 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2856 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2857
c9d624c6
PE
2858 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2859 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2860 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2861
353032ce
PE
2862 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2863
2bccce07
PE
2864 * alloc.c (Fmake_string): Check for out-of-range init.
2865
0ac30604
SM
28662011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2867
2868 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2869
c195f2de
JD
28702011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2871
2872 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2873 xg_get_default_scrollbar_width.
2874
2875 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2876 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2877 (style_changed_cb): Call update_theme_scrollbar_width and call
2878 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2879 all frames (Bug#8505).
2880 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2881 Call gtk_window_set_resizable if HAVE_GTK3.
2882 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2883 and height if HAVE_GTK3 (Bug#8505).
2884 (scroll_bar_width_for_theme): New variable.
2885 (update_theme_scrollbar_width): New function.
2886 (xg_get_default_scrollbar_width): Move code to
2887 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2888 (xg_initialize): Call update_theme_scrollbar_width.
2889
2890 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2891
2892 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2893
e10ac9f1
MR
28942011-06-12 Martin Rudalics <rudalics@gmx.at>
2895
2896 * frame.c (make_frame): Call other_buffer_safely instead of
2897 other_buffer.
2898
2899 * window.c (temp_output_buffer_show): Call display_buffer with
2900 second argument Vtemp_buffer_show_specifiers and reset latter
2901 immediately after the call.
2902 (Vtemp_buffer_show_specifiers): New variable.
2903 (auto_window_vscroll_p, next_screen_context_lines)
2904 (Vscroll_preserve_screen_position): Remove leading asterisks from
2905 doc-strings.
2906
2d3c217e 29072011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2908
7b7f97e8 2909 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2910 * buffer.c (Qclone_number): Remove for now, as it's unused.
2911 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2912 (record_buffer): Remove unused local.
2913 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2914 (set_frame_buffer_list): Remove; unused.
2915 * frame.h (other_visible_frames): Remove decl.
2916 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2917 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2918 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2919 if HAVE_GPM.
2920 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2921 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2922 Define only if HAVE_GPM.
2923 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2924 (update_hints_inhibit): Remove; never set. All uses removed.
2925 * widgetprv.h (emacsFrameClassRec): Remove decl.
2926 * window.c (delete_deletable_window): Now returns void, since it
2927 wasn't returning anything.
2928 (compare_window_configurations): Remove unused locals.
2929 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2930 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2931 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2932 the same widths as pointers. This follows up on the 2011-05-06 patch.
2933 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2934 * xterm.h: Likewise.
2935 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2936
1384b89e
JB
29372011-06-12 Juanma Barranquero <lekktu@gmail.com>
2938
2939 * makefile.w32-in: Update dependencies.
2940 (LISP_H): Add lib/intprops.h.
2941
1100a63c
CY
29422011-06-11 Chong Yidong <cyd@stupidchicken.com>
2943
2944 * image.c (gif_load): Add animation frame delay to the metadata.
2945 (syms_of_image): Use DEFSYM. New symbol `delay'.
2946
6198ccd0
MR
29472011-06-11 Martin Rudalics <rudalics@gmx.at>
2948
2949 * window.c (delete_deletable_window): Re-add.
2950 (Fset_window_configuration): Rewrite to handle dead buffers and
2951 consequently deletable windows.
2952 (window_tree, Fwindow_tree): Remove. Supply functionality in
2953 window.el.
2954 (compare_window_configurations): Simplify code.
2955
b6e3633c
AS
29562011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2957
1ab0dee5
AS
2958 * image.c (imagemagick_load_image): Fix type mismatch.
2959 (Fimagemagick_types): Likewise.
2960
b6e3633c
AS
2961 * window.h (replace_buffer_in_windows): Declare.
2962
9397e56f
MR
29632011-06-11 Martin Rudalics <rudalics@gmx.at>
2964
2965 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2966 Qclone_number. Remove external declaration of Qdelete_window.
2967 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2968 code.
640c8776
SM
2969 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2970 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2971 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2972 buffer list implementation.
2973 (other_buffer_safely): New function.
2974 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2975 calls to replace_buffer_in_windows and
2976 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2977 if allowed.
2978 (record_buffer): Inhibit quitting and rewrite using quittable
2979 functions. Run Qbuffer_list_update_hook if allowed.
2980 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2981 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2982 Move switch-to-buffer to window.el.
9397e56f
MR
2983 (bury-buffer): Move to window.el.
2984 (Vbuffer_list_update_hook): New variable.
2985
2986 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2987 section.
2988
2989 * window.h (resize_frame_windows): Move up in code.
2990 (Fwindow_frame): Remove EXFUN.
2991 (replace_buffer_in_all_windows): Remove prototype.
2992 (replace_buffer_in_windows_safely): Add prototype.
2993
2994 * window.c: Declare Qdelete_window static again. Move down
2995 declaration of select_count.
2996 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2997 (Fother_window): Move to window.el.
2998 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2999 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3000 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3001 window.el.
3002 (replace_buffer_in_windows): Implement by calling
3003 Qreplace_buffer_in_windows.
3004 (replace_buffer_in_all_windows): Remove with some functionality
3005 moved into replace_buffer_in_windows_safely.
3006 (replace_buffer_in_windows_safely): New function.
3007 (select_window_norecord, select_frame_norecord): Move in front
3008 of run_window_configuration_change_hook. Remove now obsolete
3009 declarations.
640c8776
SM
3010 (Fset_window_buffer): Rewrite doc-string.
3011 Call Qrecord_window_buffer.
9397e56f
MR
3012 (keys_of_window): Move binding for other-window to window.el.
3013
b50691aa
CY
30142011-06-11 Chong Yidong <cyd@stupidchicken.com>
3015
3016 * dispextern.h (struct image): Replace data member, whose int_val
3017 and ptr_val fields were not used by anything, with a single
3018 lisp_val object.
3019
3020 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3021 (gif_clear_image, gif_load, imagemagick_load_image)
3022 (gs_clear_image, gs_load): Callers changed.
3023
3f754b86
PE
30242011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3025
cca69397
PE
3026 * buffer.h: Include <time.h>, for time_t.
3027 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3028
109e28d0
PE
3029 Fix minor problems found by static checking.
3030
60737f02
PE
3031 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3032
4b66faf3
PE
3033 Make identifiers static if they are not used in other modules.
3034 * data.c (Qcompiled_function, Qframe, Qvector):
3035 * image.c (QimageMagick, Qsvg):
3036 * minibuf.c (Qmetadata):
3037 * window.c (resize_window_check, resize_root_window): Now static.
3038 * window.h (resize_window_check, resize_root_window): Remove decls.
3039
109e28d0
PE
3040 * window.c (window_deletion_count, delete_deletable_window):
3041 Remove; unused.
46a4ce9e
PE
3042 (window_body_lines): Now static.
3043 (Fdelete_other_windows_internal): Mark vars as initialized.
3044 Make sure 'resize_failed' is initialized.
3045 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3046 (resize_window_apply): Remove unused local.
3047 * window.h (delete_deletable_window): Remove decl.
3048
109e28d0 3049 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3050 (imagemagick_load_image): Fix pointer signedness problem by changing
3051 last arg from unsigned char * to char *. All uses changed.
3052 Also, fix a local for similar reasons.
3053 Remove unused locals. Remove locals to avoid shadowing.
3054 (fn_rsvg_handle_free): Remove; unused.
3055 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3056 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3057
3f754b86
PE
3058 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3059
2547adb1
CY
30602011-06-10 Chong Yidong <cyd@stupidchicken.com>
3061
3062 * image.c (gif_load): Fix omitted cast error introduced by
3063 2011-06-06 change.
3064
2c8e37d4
MR
30652011-06-10 Martin Rudalics <rudalics@gmx.at>
3066
3067 * window.h (resize_proportionally, orig_total_lines)
3068 (orig_top_line): Remove from window structure.
3069 (set_window_height, set_window_width, change_window_heights)
3070 (Fdelete_window): Remove prototypes.
3071 (resize_frame_windows): Remove duplicate declaration.
3072
440a42e3
EZ
30732011-06-10 Eli Zaretskii <eliz@gnu.org>
3074
3075 * window.h (resize_frame_windows, resize_window_check)
3076 (delete_deletable_window, resize_root_window)
3077 (resize_frame_windows): Declare prototypes.
3078
3079 * window.c (resize_window_apply): Make definition be "static" to
3080 match the prototype.
3081
562dd5e9
MR
30822011-06-10 Martin Rudalics <rudalics@gmx.at>
3083
3084 * window.c: Remove declarations of Qwindow_size_fixed,
3085 window_min_size_1, window_min_size_2, window_min_size,
3086 size_window, window_fixed_size_p, enlarge_window, delete_window.
3087 Remove static from declaration of Qdelete_window, it's
3088 temporarily needed by Fbury_buffer.
3089 (replace_window): Don't assign orig_top_line and
3090 orig_total_lines.
3091 (Fdelete_window, delete_window): Remove. Window deletion is
3092 handled by window.el.
640c8776
SM
3093 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3094 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3095 (Fdelete_other_windows): Remove. Deleting other windows is
3096 handled by window.el.
3097 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3098 handled in window.el.
3099 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3100 Window minimum sizes are handled in window.el.
3101 (shrink_windows, size_window, set_window_height)
3102 (set_window_width, change_window_heights, window_height)
3103 (window_width, CURBEG, CURSIZE, enlarge_window)
3104 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3105 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3106 handled in window.el.
3107 (make_dummy_parent): Rename to make_parent_window and give it a
3108 second argument horflag.
3109 (make_window): Don't set resize_proportionally any more.
3110 (Fsplit_window): Remove. Windows are split in window.el.
3111 (save_restore_action, save_restore_orig_size)
3112 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3113 Resize mini windows in window.el.
3114 (grow_mini_window, shrink_mini_window): Implement by calling
3115 Qresize_root_window_vertically, resize_window_check and
3116 resize_window_apply.
640c8776
SM
3117 (saved_window, Fset_window_configuration, save_window_save):
3118 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3119 resize_proportionally.
3120 (window_min_height, window_min_width): Move to window.el.
3121 (keys_of_window): Move bindings for delete-other-windows,
3122 split-window, delete-window and enlarge-window to window.el.
3123
3124 * buffer.c: Temporarily extern Qdelete_window.
3125 (Fbury_buffer): Temporarily call Qdelete_window instead of
3126 Fdelete_window (Fbury_buffer will move to window.el soon).
3127
3128 * frame.c (set_menu_bar_lines_1): Remove code handling
3129 orig_top_line and orig_total_lines.
3130
3131 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3132 set_window_height but set heights directly.
3133 (change_frame_size_1): Use resize_frame_windows.
3134
3135 * xdisp.c (init_xdisp): Don't use set_window_height but set
3136 heights directly.
3137
640c8776
SM
3138 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3139 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3140 run_window_configuration_change_hook.
3141
3142 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3143 instead of change_window_heights and run
3144 run_window_configuration_change_hook.
3145
1a13852e
MR
31462011-06-09 Martin Rudalics <rudalics@gmx.at>
3147
3148 * window.c (replace_window): Rename second argument REPLACEMENT to
3149 NEW. New third argument SETFLAG. Rewrite.
3150 (delete_window, make_dummy_parent): Call replace_window with
3151 third argument 1.
3152 (window_list_1): Move down in code.
3153 (run_window_configuration_change_hook): Move set_buffer part
3154 before select_frame_norecord part in order to unwind correctly.
3155 Rename count1 to count.
3156 (recombine_windows, delete_deletable_window, resize_root_window)
3157 (Fdelete_other_windows_internal)
3158 (Frun_window_configuration_change_hook, make_parent_window)
3159 (resize_window_check, resize_window_apply, Fresize_window_apply)
3160 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3161 (Fdelete_window_internal, Fresize_mini_window_internal):
3162 New functions.
1a13852e
MR
3163 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3164
f3d1777e
MR
31652011-06-08 Martin Rudalics <rudalics@gmx.at>
3166
496e208e
MR
3167 * window.h (window): Add some new members to window structure -
3168 normal_lines, normal_cols, new_total, new_normal, clone_number,
3169 splits, nest, prev_buffers, next_buffers.
3170 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3171 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3172
f3d1777e
MR
3173 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3174 Remove.
496e208e
MR
3175 (make_dummy_parent): Set new members of windows structure.
3176 (make_window): Move down in code. Handle new members of window
3177 structure.
3178 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3179 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3180 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3181 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3182 (Fset_window_next_buffers, Fset_window_clone_number):
3183 New functions.
496e208e
MR
3184 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3185 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3186 Doc-string fixes.
3187 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3188 Argument WINDOW can be now internal window too.
3189 (Fwindow_use_time): Move up in code.
3190 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3191 Rewrite doc-string.
3192 (Fset_window_configuration, saved_window)
3193 (Fcurrent_window_configuration, save_window_save): Handle new
3194 members of window structure.
b9e809c2
MR
3195 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3196 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3197 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3198 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3199 Qget_mru_window, Qresize_root_window,
3200 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3201 Qauto_buffer_name; staticpro them.
f3d1777e 3202
abde8f8c
MR
32032011-06-07 Martin Rudalics <rudalics@gmx.at>
3204
3205 * window.c (Fwindow_total_size, Fwindow_left_column)
3206 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3207 (Fwindow_list_1): New functions.
3208 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3209 (Fwindow_width, Fscroll_left, Fscroll_right):
3210 Use window_body_cols instead of window_box_text_cols.
3211 (delete_window, Fset_window_configuration):
3212 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3213 (delete_all_subwindows): Take a window as argument and not a
3214 structure. Rewrite.
190b47e6
MR
3215 (window_loop): Remove handling of GET_LRU_WINDOW and
3216 GET_LARGEST_WINDOW.
3217 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3218
3219 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3220 window_box_text_cols. delete_all_subwindows now takes a
3221 Lisp_Object as argument.
abde8f8c 3222
640c8776
SM
3223 * indent.c (compute_motion, Fcompute_motion):
3224 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3225
fa8a67e6
MR
3226 * frame.c (delete_frame): Call delete_all_subwindows with root
3227 window as argument.
3228
a54e3482
DC
32292011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3230
3231 * fns.c (Fputhash): Document return value.
3232
60002bf5
CY
32332011-06-06 Chong Yidong <cyd@stupidchicken.com>
3234
3235 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3236
0c671da6 32372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3238
b862a52a 3239 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3240
be44ca6c
PE
3241 Check for overflow when converting integer to cons and back.
3242 * charset.c (Fdefine_charset_internal, Fdecode_char):
3243 Use cons_to_unsigned to catch overflow.
3244 (Fencode_char): Use INTEGER_TO_CONS.
3245 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3246 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3247 * data.c (long_to_cons, cons_to_long): Remove.
3248 (cons_to_unsigned, cons_to_signed): New functions.
3249 These signal an error for invalid or out-of-range values.
3250 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3251 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3252 * font.c (Ffont_variation_glyphs):
3253 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3254 * lisp.h: Include <intprops.h>.
3255 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3256 (cons_to_signed, cons_to_unsigned): New decls.
3257 (long_to_cons, cons_to_long): Remove decls.
3258 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3259 (Fprimitive_undo): Use CONS_TO_INTEGER.
3260 * xfns.c (Fx_window_property): Likewise.
3261 * xselect.c: Include <limits.h>.
3262 (x_own_selection, selection_data_to_lisp_data):
3263 Use INTEGER_TO_CONS.
3264 (x_handle_selection_request, x_handle_selection_clear)
3265 (x_get_foreign_selection, Fx_disown_selection_internal)
3266 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3267 (lisp_data_to_selection_data): Use cons_to_unsigned.
3268 (x_fill_property_data): Use cons_to_signed.
3269 Report values out of range.
3270
d1f3d2af
PE
3271 Check for buffer and string overflow more precisely.
3272 * buffer.h (BUF_BYTES_MAX): New macro.
3273 * lisp.h (STRING_BYTES_MAX): New macro.
3274 * alloc.c (Fmake_string):
3275 * character.c (string_escape_byte8):
3276 * coding.c (coding_alloc_by_realloc):
3277 * doprnt.c (doprnt):
3278 * editfns.c (Fformat):
3279 * eval.c (verror):
3280 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3281 since they may not be the same number.
3282 * editfns.c (Finsert_char):
3283 * fileio.c (Finsert_file_contents):
3284 Likewise for BUF_BYTES_MAX.
3285
dd52fcea
PE
3286 * image.c: Use ptrdiff_t, not int, for sizes.
3287 (slurp_file): Switch from int to ptrdiff_t.
3288 All uses changed.
3289 (slurp_file): Check that file size fits in both size_t (for
3290 malloc) and ptrdiff_t (for sanity and safety).
3291
7f9bbdbb
PE
3292 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3293 if b->modtime has its maximal value.
3294
dfe18f82
PE
3295 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3296
84acfcf0
PE
3297 Don't assume time_t can fit into int.
3298 * buffer.h (struct buffer.modtime): Now time_t, not int.
3299 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3300 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3301
ccd9a01a
PE
3302 Minor fixes for signed vs unsigned integers.
3303 * character.h (MAYBE_UNIFY_CHAR):
3304 * charset.c (maybe_unify_char):
3305 * keyboard.c (read_char, reorder_modifiers):
3306 XINT -> XFASTINT, since the integer must be nonnegative.
3307 * ftfont.c (ftfont_spec_pattern):
3308 * keymap.c (access_keymap, silly_event_symbol_error):
3309 XUINT -> XFASTINT, since the integer must be nonnegative.
3310 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3311 since it makes no difference and we prefer signed.
3312 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3313 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3314 nonnegative.
3315
d6d100dd
SM
33162011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3317
3318 * window.h (Fwindow_frame): Declare.
3319
2b6148e4
PE
33202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3321
3322 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3323 (SPARE_MEMORY): Always define.
3324 (LARGE_REQUEST): Remove.
3325 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3326
f230ecc9
MR
33272011-06-06 Martin Rudalics <rudalics@gmx.at>
3328
727e958e
MR
3329 * lisp.h: Move EXFUNS for Fframe_root_window,
3330 Fframe_first_window and Fset_frame_selected_window to window.h.
3331
3332 * window.h: Move EXFUNS for Fframe_root_window,
3333 Fframe_first_window and Fset_frame_selected_window here from
3334 lisp.h.
3335
3336 * frame.c (Fwindow_frame, Fframe_first_window)
3337 (Fframe_root_window, Fframe_selected_window)
3338 (Fset_frame_selected_window): Move to window.c.
3339 (Factive_minibuffer_window): Move to minibuf.c.
3340 (Fother_visible_frames_p): New function.
3341
3342 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3343
f230ecc9
MR
3344 * window.c (decode_window, decode_any_window): Move up in code.
3345 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3346 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3347 (Fwindow_buffer): Move up and rewrite doc-string.
3348 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3349 (Fwindow_prev): New functions.
727e958e
MR
3350 (Fwindow_frame): Move here from frame.c. Accept any window as
3351 argument.
3352 (Fframe_root_window, Fframe_first_window)
3353 (Fframe_selected_window): Move here from frame.c. Accept frame
3354 or arbitrary window as argument. Update doc-strings.
3355 (Fminibuffer_window): Move up in code.
3356 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3357 (Fset_frame_selected_window): Move here from frame.c.
3358 Marginal rewrite.
727e958e
MR
3359 (Fselected_window, select_window, Fselect_window): Move up in
3360 code. Minor doc-string fixes.
f230ecc9 3361
4d09bcf6
PE
33622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3363
3364 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3365 Do not assume that spare memory exists; that assumption is valid
3366 only if SYSTEM_MALLOC.
3367 (LARGE_REQUEST): New macro, so that the issue of large requests
3368 is separated from the issue of spare memory.
3369
810928a2
AS
33702011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3371
172418ad
AS
3372 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3373 format. (Bug#8806)
3374
43f862f7
AS
3375 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3376
810928a2
AS
3377 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3378 before statements.
3379
a059fe24
JD
33802011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3381
3382 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3383
3384 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3385
3386 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3387 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3388
989bf368
JB
33892011-06-05 Juanma Barranquero <lekktu@gmail.com>
3390
3391 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3392
4b80f674
CY
33932011-06-04 Chong Yidong <cyd@stupidchicken.com>
3394
3395 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3396 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3397 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3398 New error handlers.
4b80f674
CY
3399 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3400 Obey Vx_select_enable_clipboard_manager. Catch errors in
3401 x_clipboard_manager_save (Bug#8779).
3402 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3403 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3404
99a33b77 34052011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3406
3407 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3408
99a33b77 34092011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3410
3411 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3412 in the current matrix if keep_current_p is non-zero.
3413
8264569d
EZ
34142011-06-04 Eli Zaretskii <eliz@gnu.org>
3415
3416 * bidi.c (bidi_level_of_next_char): Fix last change.
3417
57f97249
EZ
34182011-06-03 Eli Zaretskii <eliz@gnu.org>
3419
fec2107c 3420 Support bidi reordering of text covered by display properties.
57f97249 3421
fec2107c
EZ
3422 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3423 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3424 (bidi_cache_search, bidi_cache_iterator_state)
3425 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3426 (bidi_level_of_next_char, bidi_move_to_visually_next):
3427 Support character positions inside a run of characters covered by a
fec2107c
EZ
3428 display string.
3429 (bidi_paragraph_init, bidi_resolve_explicit_1)
3430 (bidi_level_of_next_char): Call bidi_fetch_char and
3431 bidi_fetch_char_advance instead of FETCH_CHAR and
3432 FETCH_CHAR_ADVANCE.
3433 (bidi_init_it): Initialize new members.
3434 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3435 definitions.
3436 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3437 instead of using explicit *_CHAR codes.
d6d100dd
SM
3438 (bidi_resolve_explicit, bidi_resolve_weak):
3439 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3440 bidirectional text is supported only in multibyte buffers.
3441 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3442 it to initialize the frame_window_p member of struct bidi_it.
3443 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3444 (bidi_resolve_explicit, bidi_resolve_weak)
3445 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3446 bidi_it->nchars is non-positive.
3447 (bidi_level_of_next_char): Don't try to lookup the cache for the
3448 next/previous character if nothing is cached there yet, or if we
3449 were just reseat()'ed to a new position.
c40e2fb2 3450
0e14fe90
EZ
3451 * xdisp.c (set_cursor_from_row): Set start and stop points
3452 according to the row's direction when priming the loop that looks
3453 for the glyph on which to display cursor.
3454 (single_display_spec_intangible_p): Function deleted.
3455 (display_prop_intangible_p): Reimplement to call
3456 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3457 Accept 3 additional arguments needed by handle_display_spec.
3458 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3459 values: lists, `(when COND...)' forms, etc.
3460 (single_display_spec_string_p): Support property values that are
3461 lists with the argument STRING its top-level element.
3462 (display_prop_string_p): Fix the condition for processing a
3463 property that is a list to be consistent with handle_display_spec.
fec2107c 3464 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3465 last portion of handle_display_prop.
3466 (compute_display_string_pos): Accept additional argument
3467 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3468 value of a `display' property is a "replacing spec".
3469 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3470 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3471 the display property, but just return a value indicating whether
3472 the display property will replace the characters it covers.
3473 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3474 frame_window_p members of struct bidi_it.
d6d100dd
SM
3475 (compute_display_string_pos, compute_display_string_end):
3476 New functions.
fec2107c
EZ
3477 (push_it): Accept second argument POSITION, where pop_it should
3478 jump to continue iteration.
3479 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3480
fec2107c
EZ
3481 * keyboard.c (adjust_point_for_property): Adjust the call to
3482 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3483
3484 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3485 (bidi_init_it): Update prototypes.
3486 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3487 (compute_display_string_pos, compute_display_string_end):
3488 Declare prototypes.
fec2107c
EZ
3489 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3490 EMACS_INT.
fc6f18ce 3491
40087514 34922011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3493
57f53182
PE
3494 Malloc failure behavior now depends on size of allocation.
3495 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3496 * lisp.h: Change signatures accordingly.
3497 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3498 All callers changed. (Bug#8762)
3499
3500 * gnutls.c: Use Emacs's memory allocators.
3501 Without this change, the gnutls library would invoke malloc etc.
3502 directly, which causes problems on non-SYNC_INPUT hosts, and which
3503 runs afoul of improving memory_full behavior. (Bug#8761)
3504 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3505 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3506 xfree instead of the default malloc, realloc, free.
3507 (Fgnutls_boot): No need to check for memory allocation failure,
3508 since xmalloc does that for us.
3509
ac32cd99 3510 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3511 * category.c (hash_get_category_set):
3512 * ccl.c (ccl_driver):
3513 * charset.c (Fdefine_charset_internal):
3514 * charset.h (struct charset.hash_index):
3515 * composite.c (get_composition_id, gstring_lookup_cache)
3516 (composition_gstring_put_cache):
3517 * composite.h (struct composition.hash_index):
3518 * dispextern.h (struct image.hash):
3519 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3520 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3521 (hashfn_equal, hashfn_user_defined, make_hash_table)
3522 (maybe_resize_hash_table, hash_lookup, hash_put)
3523 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3524 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3525 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3526 * image.c (make_image, search_image_cache, lookup_image)
3527 (xpm_put_color_table_h):
3528 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3529 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3530 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3531 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3532 * alloc.c (allocate_vectorlike):
3533 Check for overflow in vector size calculations.
3534 * ccl.c (ccl_driver):
3535 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3536 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3537 need to be updated by these changes.
40087514
PE
3538 * fns.c (make_hash_table, maybe_resize_hash_table):
3539 Check for integer overflow with large hash tables.
0de4bb68
PE
3540 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3541 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3542 (SXHASH_REDUCE): New macro.
3543 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3544 Use it instead of discarding useful hash info with large hash values.
3545 (sxhash_float): New function.
3546 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3547 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3548 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3549 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3550 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3551 Adjust signatures to match updated version of code.
3552 (consing_since_gc): Now EMACS_INT, since a single hash table can
3553 use more than INT_MAX bytes.
3554
698d32e2
DN
35552011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3556
3557 Make it possible to build with GCC-4.6+ -O2 -flto.
3558
3559 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3560
fd6fa53f
SM
35612011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3562
3563 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3564 Call minibuffer-inactive-mode.
3565
864db017
JB
35662011-05-31 Juanma Barranquero <lekktu@gmail.com>
3567
3568 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3569 Update dependencies.
3570
2ad0baf4
DN
35712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3572
3573 * data.c (init_data): Remove code for UTS, this system is not
3574 supported anymore.
3575
4fcc2638
DN
35762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3577
3578 Don't force ./temacs to start in terminal mode.
3579
3580 * frame.c (make_initial_frame): Initialize faces in all cases, not
3581 only when CANNOT_DUMP is defined.
3582 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3583
c56e0fd5
DN
35842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3585
3586 * dispnew.c (add_window_display_history): Use const for the string
3587 pointer. Remove declaration, not needed.
3588
333d54da 35892011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3590
55d4c1b2 3591 Use 'inline', not 'INLINE'.
333d54da 3592 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3593 * alloc.c, fontset.c (INLINE): Remove.
3594 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3595 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3596 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3597 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3598 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3599
738db178
DN
36002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3601
3602 Make it possible to run ./temacs.
3603
3604 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3605 syms_of_callproc does the same thing. Remove test for
3606 "initialized", do it in the caller.
3607 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3608
620c53a6
SM
36092011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3610
3611 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3612 (read_minibuf): Use get_minibuffer.
3613 (syms_of_minibuf): Use DEFSYM.
3614 (Qmetadata): New var.
3615 * data.c (Qbuffer): Don't make it static.
3616 (syms_of_data): Use DEFSYM.
3617
e003a292
PE
36182011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3619
3620 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3621 (CCL_CODE_MIN): New macro.
3622
ed008a6d
PE
36232011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3624
3687c2ef
PE
3625 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3626
ed008a6d
PE
3627 * eval.c (Qdebug): Now static.
3628 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3629 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3630 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3631
d66c4c7c
CY
36322011-05-29 Chong Yidong <cyd@stupidchicken.com>
3633
3634 * image.c: Various fixes to ImageMagick code comments.
3635 (Fimagemagick_types): Doc fix.
3636
5fbc2025
PE
36372011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3638
0196f88a
PE
3639 Minor fixes prompted by GCC 4.6.0 warnings.
3640
3641 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3642
5fbc2025
PE
3643 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3644 (x_clipboard_manager_save_all): Move extern decl to ...
3645 * xterm.h: ... here, so that it can be checked for consistency.
3646
1dd3c2d9
CY
36472011-05-29 Chong Yidong <cyd@stupidchicken.com>
3648
3649 * xselect.c (x_clipboard_manager_save_frame)
3650 (x_clipboard_manager_save_all): New functions.
3651 (Fx_clipboard_manager_save): Lisp function deleted.
3652
3653 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3654 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3655
3656 * xterm.h: Update prototype.
3657
5ba6571d
WX
36582011-05-28 William Xu <william.xwl@gmail.com>
3659
3660 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3661 exiting (Bug#8239).
3662
3eaff834
JM
36632011-05-28 Jim Meyering <meyering@redhat.com>
3664
e1900994 3665 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3666 * fns.c (to_uchar): Define.
3667 (crypto_hash_function): Use it to convert some newly-signed
3668 variables to unsigned, to avoid sign-extension bugs. For example,
3669 without this change, (md5 "truc") would evaluate to
3670 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3671 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3672 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3673
0f6990a7
PE
36742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3675
3676 Integer overflow fixes.
c8a9ca5a 3677
08686060
PE
3678 * dbusbind.c: Serial number integer overflow fixes.
3679 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3680 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3681 to hold a serial number that is too large for a fixnum.
3682 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3683 Check for serial numbers out of range. Decode any serial number
59568bf0 3684 that was so large that it became a float. (Bug#8722)
08686060 3685
2d1fc3c7
PE
3686 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3687 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3688 Use XFASTINT rather than XUINT when numbers are nonnegative.
3689 (xd_append_arg, Fdbus_method_return_internal):
3690 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3691 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3692 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3693 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3694 (Bug#8722)
2d1fc3c7 3695
c8a9ca5a
PE
3696 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3697
519e1d69
PE
3698 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3699
30569699
PE
3700 ccl: add integer overflow checks
3701 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3702 (IN_INT_RANGE): New macros.
3703 (ccl_driver): Use them to check for integer overflow when
3704 decoding a CCL program. Many of the new checks are whether XINT (x)
3705 fits in int; it doesn't always, on 64-bit hosts. The new version
3706 doesn't catch all possible integer overflows, but it's an
847044ea 3707 improvement. (Bug#8719)
30569699 3708
c11285dc
PE
3709 * alloc.c (make_event_array): Use XINT, not XUINT.
3710 There's no need for unsigned here.
3711
fdccd48e
PE
3712 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3713 This follows up to the 2011-05-06 change that substituted uintptr_t
3714 for EMACS_INT. This case wasn't caught back then.
3715
37910ab2
PE
3716 Rework Fformat to avoid integer overflow issues.
3717 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3718 now (part of C89). Include <verify.h>.
3719 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3720 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3721 (Fformat): Avoid the prepass trying to compute sizes; it was only
3722 approximate and thus did not catch overflow reliably. Instead, walk
3723 through the format just once, formatting and computing sizes as we go,
3724 checking for integer overflow at every step, and allocating a larger
3725 buffer as needed. Keep track separately whether the format is
3726 multibyte. Keep only the most-recently calculated precision, rather
3727 than them all. Record whether each argument has been converted to
3728 string. Use EMACS_INT, not int, for byte and char and arg counts.
3729 Support field widths and precisions larger than INT_MAX. Avoid
3730 sprintf's undefined behavior with conversion specifications such as %#d
3731 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3732 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3733 formatting out-of-range floating point numbers with int
9173deec 3734 formats. (Bug#8668)
37910ab2 3735
2e6578fb
PE
3736 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3737
0ae6bdee
PE
3738 * data.c: Avoid integer truncation in expressions involving floats.
3739 * data.c: Include <intprops.h>.
3740 (arith_driver): When there's an integer overflow in an expression
3741 involving floating point, convert the integers to floating point
3742 so that the resulting value does not suffer from catastrophic
3743 integer truncation. For example, on a 64-bit host (* 4
3744 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3745 Do not rely on undefined behavior after integer overflow.
3746
de883a70
PE
3747 merge count_size_as_multibyte, parse_str_to_multibyte
3748 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3749 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3750 Check for integer overflow.
3751 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3752 since it's now a duplicate of the other. This is more of
3753 a character than a buffer op, so better that it's in character.c.
3754 * fns.c, print.c: Adjust to above changes.
3755
2ff916cb
PE
37562011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3757
3758 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3759
f1b54466
PE
37602011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3761
fb1ac845
PE
3762 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3763 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3764 (x_clipboard_manager_save): Now static.
3765 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3766
f1b54466
PE
3767 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3768 (crypto_hash_function): Now static.
3769 Fix pointer signedness problems. Avoid unnecessary initializations.
3770
a9f737ee
CY
37712011-05-27 Chong Yidong <cyd@stupidchicken.com>
3772
3773 * termhooks.h (Vselection_alist): Make it terminal-local.
3774
3775 * terminal.c (create_terminal): Initialize it.
3776
3777 * xselect.c: Support for clipboard managers.
3778 (Vselection_alist): Move to termhooks.h as terminal-local var.
3779 (LOCAL_SELECTION): New macro.
3780 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3781 (symbol_to_x_atom): Remove gratuitous arg.
3782 (x_handle_selection_request, lisp_data_to_selection_data)
3783 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3784 (x_own_selection, x_get_local_selection, x_convert_selection):
3785 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3786 (some_frame_on_display): Delete unused function.
3787 (Fx_own_selection_internal, Fx_get_selection_internal)
3788 (Fx_disown_selection_internal, Fx_selection_owner_p)
3789 (Fx_selection_exists_p): New optional frame arg.
3790 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3791 (x_handle_selection_clear): Don't treat other terminals with the
3792 same keyboard specially. Use the terminal-local Vselection_alist.
3793 (x_clear_frame_selections): Use Frun_hook_with_args.
3794
3795 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3796
3797 * xterm.h: Add support for those atoms.
3798
e067f0c1
CY
37992011-05-26 Chong Yidong <cyd@stupidchicken.com>
3800
3801 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3802 (converted_selections, conversion_fail_tag): New global variables.
3803 (x_selection_request_lisp_error): Free the above.
3804 (x_get_local_selection): Remove unnecessary code.
3805 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3806 of converted selections stored in converted_selections.
3807 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3808 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3809 (x_convert_selection): New function.
3810 (x_handle_selection_event): Simplify.
3811 (x_get_foreign_selection): Don't ignore incoming requests while
3812 waiting for an answer; this will fail when we implement
3813 SAVE_TARGETS, and seems unnecessary anyway.
3814 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3815 (Vx_sent_selection_functions): Doc fix.
3816
0f4aebc0
LL
38172011-05-26 Leo Liu <sdl.web@gmail.com>
3818
3819 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3820
e61124cd
YM
38212011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3822
3823 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3824
3825 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3826 for fringe update if it has periodic bitmap.
ac389d0c 3827 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3828 and fringe_bitmap_periodic_p.
3829
3830 * fringe.c (get_fringe_bitmap_data): New function.
3831 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3832 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3833 row. Mark glyph row for fringe update if periodicity changed.
3834
3835 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3836 for fringe update unless it has periodic bitmap.
3837
f16d9837
KH
38382011-05-25 Kenichi Handa <handa@m17n.org>
3839
3840 * xdisp.c (get_next_display_element): Set correct it->face_id for
3841 a static composition.
3842
e1b90ef6
LL
38432011-05-24 Leo Liu <sdl.web@gmail.com>
3844
3845 * deps.mk (fns.o):
3846 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3847
3848 * fns.c (crypto_hash_function, Fsha1): New function.
3849 (Fmd5): Use crypto_hash_function.
3850 (syms_of_fns): Add Ssha1.
3851
7400048f
PE
38522011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3853
3854 * gnutls.c: Remove unused macros.
3855 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3856 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3857 Remove macros that are defined and never used.
3858 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3859
abb71cf4
CY
38602011-05-22 Chong Yidong <cyd@stupidchicken.com>
3861
3862 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3863 (Fx_get_selection_internal): Minor cleanup.
3864 (Fx_own_selection_internal): Rename arguments for consistency with
3865 select.el.
3866
6307db39
PE
38672011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3868
3869 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3870
f3d4e0a4
CY
38712011-05-22 Chong Yidong <cyd@stupidchicken.com>
3872
3873 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3874
4d8ade89
YM
38752011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3876
3877 * dispnew.c (scrolling_window): Don't exclude the case that the
3878 last enabled row in the desired matrix touches the bottom boundary.
3879
32078c8d
GM
38802011-05-21 Glenn Morris <rgm@gnu.org>
3881
3882 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3883 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3884 and add some more files.
32078c8d 3885
7285dc67
EZ
38862011-05-20 Eli Zaretskii <eliz@gnu.org>
3887
3888 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3889 report_file_error introduced by the change from 2011-05-07.
3890
89d1bd22
PE
38912011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3892
3893 * systime.h (Time): Define only if emacs is defined.
3894 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3895 where the include path doesn't have X11/X.h by default. See
3896 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3897
e23640bb 38982011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3899
3900 * composite.c (find_automatic_composition): Fix previous change.
3901
b9704ad9
GM
39022011-05-20 Glenn Morris <rgm@gnu.org>
3903
3904 * lisp.mk: New file, split from Makefile.in.
3905 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3906 (shortlisp): Remove.
3907 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3908
4a720484
GM
39092011-05-19 Glenn Morris <rgm@gnu.org>
3910
3911 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3912 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3913 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3914 (lisp): Set the order to that of loadup.el.
3915 (shortlisp): Make it a copy of $lisp.
3916 (SOME_MACHINE_LISP): Remove.
3917 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3918 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3919
a28d4396
KH
39202011-05-18 Kenichi Handa <handa@m17n.org>
3921
3922 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3923 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3924 (find_automatic_composition): Mostly rewrite for efficiency.
3925
a2b1fa8e
JB
39262011-05-18 Juanma Barranquero <lekktu@gmail.com>
3927
3928 * makefile.w32-in: Update dependencies.
3929
8e1f5610
CS
39302011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3931
3932 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3933 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3934
7025ee00 39352011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3936
cdfa6eab
PE
3937 Fix some integer overflow issues, such as string length overflow.
3938
06d6db33
PE
3939 * insdel.c (count_size_as_multibyte): Check for string overflow.
3940
2b4560a8
PE
3941 * character.c (lisp_string_width): Check for string overflow.
3942 Use EMACS_INT, not int, for string indexes and lengths; in
3943 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3944 the resulting string length overflows an EMACS_INT; instead,
3945 report a string overflow if no precision given. When checking for
3946 precision exhaustion, use a check that cannot possibly have
3947 integer overflow. (Bug#8675)
3948 * character.h (lisp_string_width): Adjust to new signature.
3949
cb93f9be
PE
3950 * alloc.c (string_overflow): New function.
3951 (Fmake_string): Use it. This doesn't change behavior, but saves
3952 a few bytes and will simplify future changes.
3953 * character.c (string_escape_byte8): Likewise.
3954 * lisp.h (string_overflow): New decl.
3955
1a1f3366
PE
3956 Fixups, following up to the user-interface timestamp change.
3957 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3958 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3959 * msdos.c (mouse_get_pos): Likewise.
3960 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3961 * w32gui.h (Time): Define by including "systime.h" rather than by
3962 declaring it ourselves. (Bug#8664)
3963
d4e3e4d3
PE
3964 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3965 * image.c (clear_image_cache): Likewise.
3966
f6a24d19
PE
3967 * term.c (term_mouse_position): Don't assume time_t wraparound.
3968
08dc5ae6
PE
3969 Be more systematic about user-interface timestamps.
3970 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3971 and sometimes 'EMACS_UINT', to represent these timestamps.
3972 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3973 This makes the code easier to follow, and makes it easier to catch
3974 integer overflow bugs such as Bug#8664.
3975 * frame.c (Fmouse_position, Fmouse_pixel_position):
3976 Use Time, not unsigned long, for user-interface timestamps.
3977 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3978 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3979 * keyboard.h (last_event_timestamp): Likewise.
3980 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3981 * menu.h (xmenu_show): Likewise.
3982 * term.c (term_mouse_position): Likewise.
3983 * termhooks.h (struct input_event.timestamp): Likewise.
3984 (struct terminal.mouse_position_hook): Likewise.
3985 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3986 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3987 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3988 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3989 what it was before.
3990 * menu.h, termhooks.h: Include "systime.h", for Time.
3991
8e55734a
PE
3992 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3993 Don't assume that the difference between two unsigned long values
3994 can fit into an integer. At this point, we know button_down_time
3995 <= event->timestamp, so the difference must be nonnegative, so
3996 there's no need to cast the result if double-click-time is
3997 nonnegative, as it should be; check that it's nonnegative, just in
3998 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3999 apart (about 25 days). (Bug#8664)
8e55734a 4000
841f1b75 4001 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4002 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4003
3e26f69c
PE
4004 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4005 that always fit in int. Use a sentinel instead of a counter, to
4006 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4007 * frame.h (struct frame): Use int for menu_bar_items_used
4008 instead of EMACS_INT, since it always fits in int.
3e26f69c 4009
5cc152c0
PE
4010 * menu.c (grow_menu_items): Check for int overflow.
4011
d89eb65e
PE
4012 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4013
5235bd3e
PE
4014 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4015 Before, the code was not consistent. These values cannot exceed
4016 2**31 - 1 so there's no need to make them unsigned.
4017 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4018 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4019 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4020 as modifiers.
4021 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4022
bc827e23
PE
4023 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4024 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4025 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4026 presumably because the widths might not match.
4027
78eb494e
PE
4028 * window.c (size_window): Avoid needless test at loop start.
4029
04f2d78b
CB
40302011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4031
4032 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4033
d2fc7e3d 40342011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4035
4036 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4037
d2fc7e3d 40382011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4039
4040 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4041 `width' to `bar_area_x' and `bar_area_width', respectively.
4042 (x_scroll_run): Take account of fringe background extension.
4043
04f2d78b
CB
4044 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4045 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4046 `bar_area_width', respectively.
4047 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4048 background extension.
4049
79b70037
GM
40502011-05-10 Jim Meyering <meyering@redhat.com>
4051
4052 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4053
2f142cc5
JB
40542011-05-10 Juanma Barranquero <lekktu@gmail.com>
4055
4056 * image.c (Finit_image_library): Return t for built-in image types,
4057 like pbm and xbm. (Bug#8640)
4058
57679c86
AS
40592011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4060
4061 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4062
888c9e86
EZ
40632011-05-07 Eli Zaretskii <eliz@gnu.org>
4064
b0512a1d
EZ
4065 * w32console.c (Fset_screen_color): Doc fix.
4066 (Fget_screen_color): New function.
4067 (syms_of_ntterm): Defsubr it.
4068
7285dc67
EZ
4069 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4070 unlink the temporary file if Fcall_process didn't create it in the
4071 first place.
4072 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4073 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4074 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4075 cue to call_process_cleanup not to close that handle.
4076
4d3fcc8e
BK
40772011-05-07 Ben Key <bkey76@gmail.com>
4078
4079 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4080 one of two shell specific rules, either bootstrap-temacs-CMD or
4081 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4082 to the previous implementation of the bootstrap-temacs rule.
4083 The bootstrap-temacs-CMD rule is similar to the previous
4084 implementation of the bootstrap-temacs rule except that it
4085 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4086 variable.
4087
4088 These changes, along with some changes to nt/configure.bat,
4089 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4090 earlier fix to add support for --cflags and --ldflags options
4091 that include quotes so that it works whether make uses cmd or
4092 sh as the shell.
4093
b4289b64
MA
40942011-05-06 Michael Albinus <michael.albinus@gmx.de>
4095
4096 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4097 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4098 is a constant.
4099 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4100 a string. Handle both cases.
4101 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4102 (Fdbus_register_method): Use Qinvalid_function.
4103
af4c0e28
JB
41042011-05-06 Juanma Barranquero <lekktu@gmail.com>
4105
4106 * makefile.w32-in: Update dependencies.
4107 (LISP_H): Add inttypes.h and stdin.h.
4108 (PROCESS_H): Add unistd.h.
4109
c51453d9
EZ
41102011-05-06 Eli Zaretskii <eliz@gnu.org>
4111
4112 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4113 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4114
8ff0ac3c 41152011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4116
4c4b566b
PE
4117 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4118
aab2b9b5
PE
4119 * term.c (vfatal): Remove stray call to va_end.
4120 It's not needed and the C Standard doesn't allow it here anyway.
4121
c378da0b
PE
4122 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4123 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4124
288b08c7
PE
4125 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4126 bytes.
4127
e3601888
PE
4128 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4129
db6c0e74
PE
4130 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4131
dd5963ea
PE
4132 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4133
88c9450f
PE
4134 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4135
2f9442b8
PE
4136 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4137
c032b5f8
PE
4138 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4139 * charset.c (Fdefine_charset_internal): Don't initialize
4140 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4141 32-bit int (Bug#8600).
a108c10b
PE
4142
4143 * lread.c (read_integer): Be more consistent with string-to-number.
4144 Use string_to_number to do the actual conversion; this avoids
4145 rounding errors and fixes some other screwups. Without this fix,
4146 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4147 (digit_to_number): Move earlier, for benefit of read_integer.
4148 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4149 not a digit in any supported base. (Bug#8602)
a108c10b 4150
ad5f9eea
PE
4151 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4152
aec1708a
PE
4153 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4154 to match comment at start of function. This also removes a
4155 GCC warning about overflow in a 32+64-bit port.
4156
47be4ab5
PE
4157 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4158
371cac43
PE
4159 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4160 Reported by Stefan Monnier in
4161 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4162 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4163 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4164
d01a7826
PE
4165 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4166 (EMACS_UINTPTR): Likewise, with uintptr_t.
4167
7fd47d5c
PE
4168 * lisp.h: Prefer 64-bit EMACS_INT if available.
4169 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4170 on 32-bit hosts that have 64-bit int, so that they can access
4171 large files.
122b0c86
PE
4172 However, temporarily disable this change unless the temporary
4173 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4174
8727937b
PE
4175 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4176
8ac068ac
PE
4177 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4178 This removes an assumption that EMACS_INT and long are the same
4179 width as pointers. The assumption is true for Emacs porting targets
4180 now, but we want to make other targets possible.
4181 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4182 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4183 In the rest of the code, change types of integers that hold casted
4184 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4185 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4186 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4187 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4188 No need to cast type when ORing.
4189 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4190 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4191 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4192 assume EMACS_INT is the same width as char *.
4193 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4194 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4195 Remove no-longer-needed casts.
4196 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4197 (xg_tool_bar_help_callback, xg_make_tool_item):
4198 Use EMACS_INTPTR to hold an integer
4199 that will be cast to void *; this can avoid a GCC warning
4200 if EMACS_INT is not the same width as void *.
4201 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4202 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4203 (current_message_1, set_message_1):
4204 Use a local to convert to proper width without a cast.
4205 * xmenu.c (dialog_selection_callback): Likewise.
4206
ede49d71
PE
4207 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4208 Also, don't assume VALBITS / RAND_BITS is less than 5,
4209 and don't rely on undefined behavior when shifting a 1 left into
4210 the sign bit.
4211 * lisp.h (get_random): Change signature to match.
4212
2f30ecd0
PE
4213 * lread.c (hash_string): Use size_t, not int, for hash computation.
4214 Normally we prefer signed values; but hashing is special, because
4215 it's better to use unsigned division on hash table sizes so that
4216 the remainder is nonnegative. Also, size_t is the natural width
4217 for hashing into memory. The previous code used 'int', which doesn't
4218 retain enough info to hash well into very large tables.
4219 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4220
2a866e7b
PE
4221 * dbusbind.c: Don't possibly lose pointer info when converting.
4222 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4223 Use XPNTR rather than XHASH, so that the high-order bits of
4224 the pointer aren't lost when converting through void *.
4225
51639eac
PE
4226 * eval.c (Fautoload): Don't double-shift a pointer.
4227
92394119
PE
4228 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4229
dbdb9a7c
JB
42302011-05-06 Juanma Barranquero <lekktu@gmail.com>
4231
4232 * gnutls.c (DEF_GNUTLS_FN):
4233 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4234
db7a0b4f
AS
42352011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4236
4237 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4238 marker. (Bug#8610)
4239
f7ff1b0f 42402011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4241
4242 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4243 New version that can reserve upto 2GB of heap space.
4244
f7ff1b0f 42452011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4246
4247 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4248
639c109b
TZ
42492011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4250
4251 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4252 `gnutls_certificate_set_x509_key_file'.
4253
d2127135
JB
42542011-05-05 Juanma Barranquero <lekktu@gmail.com>
4255
4256 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4257 Update dependencies.
4258
e968f4f3
JB
42592011-05-04 Juanma Barranquero <lekktu@gmail.com>
4260
4261 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4262 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4263 Remove unused parameter `fildes'.
4264 * process.c (read_process_output, send_process): Don't pass it.
4265
84d358f0
JB
42662011-05-04 Juanma Barranquero <lekktu@gmail.com>
4267
4268 Fix previous change: the library cache is defined in w32.c.
4269 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4270 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4271
0898ca10
JB
42722011-05-04 Juanma Barranquero <lekktu@gmail.com>
4273
4274 Implement dynamic loading of GnuTLS on Windows.
4275
4276 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4277 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4278 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4279 Declare.
4280
4281 * gnutls.c (Qgnutls_dll): Define.
4282 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4283 (gnutls_*): Declare function pointers.
4284 (init_gnutls_functions): New function to initialize function pointers.
4285 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4286 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4287 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4288 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4289 (emacs_gnutls_write, emacs_gnutls_read)
4290 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4291 (Fgnutls_available_p): New function.
4292 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4293 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4294 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4295
4296 * image.c: Include w32.h.
4297 (Vimage_type_cache): Delete.
4298 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4299 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4300 (w32_delayed_load): Move to w32.c.
4301
4302 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4303
4304 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4305 (w32_delayed_load): Move from image.c. When loading a library, record
4306 its filename in the :loaded-from property of the library id.
4307 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4308 Initialize and staticpro them.
4309 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4310
4311 * process.c: Include lisp.h before w32.h, not after.
4312 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4313 instead of gnutls_record_check_pending.
4314
4315 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4316
ff4de4aa
TZ
43172011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4318
4319 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4320 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4321 as passed in.
4322
abe95abb
JD
43232011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4324
4325 * xterm.c (x_set_frame_alpha): Do not set property on anything
4326 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4327
e16e55d4
JB
43282011-05-02 Juanma Barranquero <lekktu@gmail.com>
4329
4330 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4331
bafcf6a5
JB
43322011-05-02 Juanma Barranquero <lekktu@gmail.com>
4333
4334 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4335 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4336 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4337 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4338 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4339 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4340 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4341 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4342 (Qgnutls_bootprop_callbacks_verify): Make static.
4343
e7a6747f
AS
43442011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4345
19ed11ba
AS
4346 * callproc.c: Indentation fixup.
4347
e7a6747f 4348 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4349 (wait_for_termination, interruptible_wait_for_termination):
4350 Move after wait_for_termination_1.
e7a6747f 4351
1ef14cb4
LMI
43522011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4353
4354 * sysdep.c (interruptible_wait_for_termination): New function
4355 which is like wait_for_termination, but allows keyboard
4356 interruptions.
4357
4358 * callproc.c (Fcall_process): Add (:file "file") as an option for
4359 the STDOUT buffer.
4360 (Fcall_process_region): Ditto.
4361
330d880c
EZ
43622011-04-30 Eli Zaretskii <eliz@gnu.org>
4363
8db90b73
EZ
4364 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4365 rather than `XVECTOR (FOO)->size'.
4366
330d880c
EZ
4367 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4368 inttypes.h, as a gnulib replacement is used if it not available in
4369 system headers.
4370
15cbd324
EZ
43712011-04-21 Eli Zaretskii <eliz@gnu.org>
4372
4373 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4374 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4375 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4376
4377 * coding.c (coding_alloc_by_realloc): Error out if destination
4378 will grow beyond MOST_POSITIVE_FIXNUM.
4379 (decode_coding_emacs_mule): Abort if there isn't enough place in
4380 charbuf for the composition carryover bytes. Reserve an extra
4381 space for up to 2 characters produced in a loop.
4382 (decode_coding_iso_2022): Abort if there isn't enough place in
4383 charbuf for the composition carryover bytes.
4384
43852011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4386
ae940cca
EZ
4387 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4388 aborting when %lld or %lll format is passed.
4389 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4390 %llo or %llx format is passed. (Bug#8545)
4391
03ab8921
EZ
4392 * window.c (window_scroll_line_based): Use a marker instead of
4393 simple variables to record original value of point. (Bug#7952)
4394
afda1437
EZ
4395 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4396 produced by %s or %c overflows available buffer space. (Bug#8545)
4397
f76dee0c
PE
43982011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4399
4400 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4401 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4402
fdc5744d
JB
44032011-04-28 Juanma Barranquero <lekktu@gmail.com>
4404
4405 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4406
638f053a
JB
44072011-04-28 Juanma Barranquero <lekktu@gmail.com>
4408
4409 * keyboard.c (Qdelayed_warnings_hook): Define.
4410 (command_loop_1): Run `delayed-warnings-hook'
4411 if Vdelayed_warnings_list is non-nil.
4412 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4413 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4414
d178f871
EZ
44152011-04-28 Eli Zaretskii <eliz@gnu.org>
4416
4417 * doprnt.c (doprnt): Don't return value smaller than the buffer
4418 size if the message was truncated. (Bug#8545).
4419
b124fd93
JB
44202011-04-28 Juanma Barranquero <lekktu@gmail.com>
4421
4422 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4423 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4424
e810457d
PE
44252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4426
4427 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4428
ea51cceb
JB
44292011-04-27 Juanma Barranquero <lekktu@gmail.com>
4430
4431 * makefile.w32-in: Update dependencies.
4432
94dcfacf
EZ
44332011-04-27 Eli Zaretskii <eliz@gnu.org>
4434
4435 Improve `doprnt' and its usage. (Bug#8545)
4436 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4437 `format_end'. Remove support for %l as a conversion specifier.
4438 Don't use xrealloc. Improve diagnostics when the %l size modifier
4439 is used. Update the commentary.
4440
4441 * eval.c (verror): Simplify calculation of size_t.
4442
4443 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4444 messages.
4445
f61f41d7
PE
44462011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4447
4448 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4449 change.
4450
96fb4434
PE
44512011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4452
4453 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4454 This makes this file independent of the recent pseudovector change.
4455
671875da 44562011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4457
69e9b5a3
PE
4458 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4459
b5f869a7 4460 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4461 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4462 Remove unused local.
c8926152 4463 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4464
841a1577 4465 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4466 GCC 4.6.0 optimizes based on type-based alias analysis.
4467 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4468 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4469 != &v->size, and therefore "v->size = 1; b->size = 2; return
4470 v->size;" must therefore return 1. This assumption is incorrect
4471 for Emacs, since it type-puns struct Lisp_Vector * with many other
4472 types. To fix this problem, this patch adds a new type struct
f904488f 4473 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4474 and pseudovectors, and helps optimizing compilers not get fooled
4475 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4476 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4477 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4478 the size member.
eab3844f
PE
4479 (XSETPVECTYPE): Rewrite in terms of new macro.
4480 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4481 This is a bit clearer, and further avoids the possibility of
4482 undesirable aliasing.
4483 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4484 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4485 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4486 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4487 (ASIZE): Now uses header.size rather than size.
4488 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4489 to avoid the hassle of writing XVECTOR (foo)->header.size.
4490 (struct vectorlike_header): New type.
eab3844f
PE
4491 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4492 object, to help avoid aliasing.
4493 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4494 (SUBRP): Likewise, since Lisp_Subr is a special case.
4495 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4496 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4497 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4498 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4499 changed to be "header.size" and "header.next".
4500 * buffer.h (struct buffer): Likewise.
4501 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4502 * frame.h (struct frame): Likewise.
4503 * process.h (struct Lisp_Process): Likewise.
4504 * termhooks.h (struct terminal): Likewise.
4505 * window.c (struct save_window_data, struct saved_window): Likewise.
4506 * window.h (struct window): Likewise.
4507 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4508 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4509 * buffer.c (init_buffer_once): Likewise.
4510 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4511 special case.
4512 * process.c (Fformat_network_address): Use local var for size,
4513 for brevity.
4514
0df1eac5
PE
4515 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4516
847ab9d1 4517 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4518 * data.c (atof): Remove decl; no longer used or needed.
4519 (digit_to_number): Move to lread.c.
4520 (Fstring_to_number): Use new string_to_number function, to be
4521 consistent with how the Lisp reader treats infinities and NaNs.
4522 Do not assume that floating-point numbers represent EMACS_INT
4523 without losing information; this is not true on most 64-bit hosts.
4524 Avoid double-rounding errors, by insisting on integers when
4525 parsing non-base-10 numbers, as the documentation specifies.
4526 * lisp.h (string_to_number): New decl, replacing ...
4527 (isfloat_string): Remove.
bc0a5c13 4528 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4529 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4530 appears to have been a coding error. Similarly, do not accept
4531 strings like +-1e0 as floating point numbers. Do not report
4532 overflow for integer overflows unless the base is not 10 which
4533 means we have no simple and reliable way to continue.
4534 Break out the floating-point parsing into a new
4535 function string_to_number, so that Fstring_to_number parses
4536 floating point numbers consistently with the Lisp reader.
04f2d78b 4537 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4538 (E_CHAR, EXP_INT): Remove, replacing with ...
4539 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4540 (string_to_number): New function, replacing isfloat_string.
4541 This function checks for valid syntax and produces the resulting
4542 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4543 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4544 so that overflow for non-base-10 numbers is reported only when
4545 there's no portable and simple way to convert to floating point.
452f4150 4546
67769ffc
PE
4547 * textprop.c (set_text_properties_1): Rewrite for clarity,
4548 and to avoid GCC warning about integer overflow.
4549
c20db43f
PE
4550 * intervals.h (struct interval): Use EMACS_INT for members
4551 where EMACS_UINT might cause problems. See
4552 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4553 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4554 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4555 All uses changed.
37aa2f85
PE
4556 (offset_intervals): Tell GCC not to worry about length overflow
4557 when negating a negative length.
c20db43f 4558
2538aa2f
PE
4559 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4560 (overrun_check_free): Likewise.
4561
f2d3008d
PE
4562 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4563 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4564 word size.
4565
ec8df744
PE
4566 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4567 (gnutls_make_error): Rename local to avoid shadowing.
4568 (gnutls_emacs_global_deinit): ifdef out; not used.
4569 (Fgnutls_boot): Use const for pointer to readonly storage.
4570 Comment out unused local. Fix pointer signedness problems.
4571
640ee02d
PE
4572 * lread.c (openp): Don't stuff size_t into an 'int'.
4573 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4574 about possible signed overflow.
4575
6048fb2a
PE
4576 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4577 (GDK_KEY_g): Don't define if already defined.
4578 (xg_prepare_tooltip): Avoid pointer signedness problem.
4579 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4580
fa3c87e1
PE
4581 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4582 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4583
2172544b
PE
4584 * xfns.c (Fx_window_property): Simplify a bit,
4585 to make a bit faster and to avoid GCC 4.6.0 warning.
4586 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4587
9b821a21
PE
4588 * fns.c (internal_equal): Don't assume size_t fits in int.
4589
3c616cfa
PE
4590 * alloc.c (compact_small_strings): Tighten assertion a little.
4591
c2982e87
PE
4592 Replace pEd with more-general pI, and fix some printf arg casts.
4593 * lisp.h (pI): New macro, generalizing old pEd macro to other
4594 conversion specifiers. For example, use "...%"pI"d..." rather
4595 than "...%"pEd"...".
4596 (pEd): Remove. All uses replaced with similar uses of pI.
4597 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4598 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4599 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4600 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4601 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4602 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4603 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4604 64-bit hosts.
4605 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4606 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4607 * print.c (safe_debug_print, print_object): Likewise.
4608 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4609 to int.
6f04d126
PE
4610 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4611 avoiding the 0 flag, which is not portable.
c2982e87
PE
4612 * process.c (Fmake_network_process): Use pI to avoid cast.
4613 * region-cache.c (pp_cache): Likewise.
4614 * xdisp.c (decode_mode_spec): Likewise.
4615 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4616 behavior on 64-bit hosts with printf arg.
6f04d126 4617 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4618 (x_stop_queuing_selection_requests): Likewise.
4619 (x_get_window_property): Don't truncate byte count to an 'int'
4620 when tracing.
0b432f21 4621
5e073ec7
PE
4622 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4623 here, since it parses constructs like leading '-' and spaces,
4624 which are not wanted; and it overflows with large numbers.
4625 Instead, simply match F[0-9]+, which is what is wanted anyway.
4626
36372bf9
PE
4627 * alloc.c: Remove unportable assumptions about struct layout.
4628 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4629 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4630 (allocate_vectorlike, make_pure_vector): Use the new macros,
4631 plus offsetof, to remove unportable assumptions about struct layout.
4632 These assumptions hold on all porting targets that I know of, but
4633 they are not guaranteed, they're easy to remove, and removing them
4634 makes further changes easier.
4635
0b432f21
PE
4636 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4637 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4638 (string_overrun_cookie): Now const. Use initializers that
4639 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4640 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4641 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4642 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4643 multiple of sizeof (EMACS_INT); it need not be, if
4644 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4645 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4646
895009e1
JB
46472011-04-26 Juanma Barranquero <lekktu@gmail.com>
4648
4649 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4650
6a7a1b0b
TZ
46512011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4652
4653 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4654 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4655 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4656
841a1577 46572011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4658
4659 * lisp.h (Qdebug): List symbol.
895009e1 4660 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4661 * keyboard.c (debug-on-event): New variable.
4662 (handle_user_signal): Break into debugger when debug-on-event
4663 matches the current signal symbol.
4664
f2d3ba6f
DN
46652011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4666
4667 * alloc.c (check_sblock, check_string_bytes)
4668 (check_string_free_list): Convert to standard C.
4669
42ce4c63
TZ
46702011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4671
4672 * w32.c (emacs_gnutls_push): Fix typo.
4673
825cd63c
EZ
46742011-04-25 Eli Zaretskii <eliz@gnu.org>
4675
fb11d64d
EZ
4676 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4677 "cast to pointer from integer of different size".
4678
825cd63c
EZ
4679 Improve doprnt and its use in verror. (Bug#8545)
4680 * doprnt.c (doprnt): Document the set of format control sequences
4681 supported by the function. Use SAFE_ALLOCA instead of always
4682 using `alloca'.
4683
4684 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4685 is one byte too soon. Don't use xrealloc; instead xfree and
4686 xmalloc anew.
4687
e061a11b
TZ
46882011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4689
4690 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4691 callbacks stage.
4692
4693 * gnutls.c: Renamed global_initialized to
4694 gnutls_global_initialized. Added internals for the
4695 :verify-hostname-error, :verify-error, and :verify-flags
4696 parameters of `gnutls-boot' and documented those parameters in the
4697 docstring. Start callback support.
9173deec
JB
4698 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4699 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4700 on error. Return error code.
e061a11b
TZ
4701 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4702 (emacs_gnutls_read): Likewise.
4703 (Fgnutls_boot): Return handshake error code.
4704 (emacs_gnutls_handle_error): New function.
4705 (wsaerror_to_errno): Likewise.
4706
4707 * w32.h (emacs_gnutls_pull): Add prototype.
4708 (emacs_gnutls_push): Likewise.
4709
4710 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4711 (emacs_gnutls_push): Likewise.
4712
47132011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4714
4715 * process.c (wait_reading_process_output): Check if GnuTLS
4716 buffered some data internally if no FDs are set for TLS
4717 connections.
4718
4719 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4720 (LIBS): Link to USER_LIBS.
4721 ($(BLD)/gnutls.$(0)): New target.
4722
fa6996bc
EZ
47232011-04-24 Eli Zaretskii <eliz@gnu.org>
4724
eb35682e
EZ
4725 * xdisp.c (handle_single_display_spec): Rename the
4726 display_replaced_before_p argument into display_replaced_p, to
4727 make it consistent with the commentary. Fix typos in the
4728 commentary.
4729
e2ad650c
EZ
4730 * textprop.c (syms_of_textprop): Remove dead code.
4731 (copy_text_properties): Delete obsolete commentary about an
4732 interface that was deleted long ago. Fix typos in the description
4733 of arguments.
4734
1b2de274
EZ
4735 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4736 to changes in oldXMenu/XMenu.h from 2011-04-16.
4737 <menu_help_message, prev_menu_help_message>: Constify.
4738 (IT_menu_make_room): menu->help_text is now `const char **';
4739 adjust.
4740
4741 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4742 to changes in oldXMenu/XMenu.h from 2011-04-16.
4743 (struct XMenu): Declare `help_text' `const char **'.
4744
4745 * xfaces.c <Qunspecified>: Make extern again.
4746
4747 * syntax.c: Include sys/types.h before including regex.h, as
4748 required by Posix.
4749
762b15be
EZ
4750 * doc.c (get_doc_string): Improve the format passed to `error'.
4751
4752 * doprnt.c (doprnt): Improve commentary.
4753
4754 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4755
4756 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4757 them with etags.
4758
f1052e5d
EZ
4759 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4760 changes in globals.h immediately force recompilation.
762b15be
EZ
4761 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4762 $(CURDIR)/s/ms-w32.h.
4763 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4764
fa6996bc
EZ
4765 * character.c (Fchar_direction): Function deleted.
4766 (syms_of_character): Don't defsubr it.
4767 <char-direction-table>: Deleted.
4768
e6c3da20
EZ
47692011-04-23 Eli Zaretskii <eliz@gnu.org>
4770
4771 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4772 * doprnt.c: Include limits.h.
4773 (SIZE_MAX): New macro.
04f2d78b
CB
4774 (doprnt): Return a size_t value. 2nd arg is now size_t.
4775 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4776 Improve overflow protection. Support `l' modifier for integer
4777 conversions. Support %l conversion. Don't assume an EMACS_INT
4778 argument for integer conversions and for %c.
4779
4780 * lisp.h (doprnt): Restore prototype.
4781
4782 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4783 $(SRC)/character.h.
4784
4785 * Makefile.in (base_obj): Add back doprnt.o.
4786
4787 * deps.mk (doprnt.o): Add back prerequisites.
4788 (callint.o): Depend on character.h.
4789
4790 * eval.c (internal_lisp_condition_case): Include the handler
4791 representation in the error message.
4792 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4793 when breaking from the loop.
4794
4795 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4796
4797 * callint.c (Fcall_interactively): When displaying error message
4798 about invalid control letter, pass the character's codepoint, not
4799 a pointer to its multibyte form. Improve display of the character
4800 in octal and display also its hex code.
4801
4802 * character.c (char_string): Use %x to display the (unsigned)
4803 codepoint of an invalid character, to avoid displaying a bogus
4804 negative value.
4805
4806 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4807 `error', not SYMBOL_NAME itself.
4808
4809 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4810 character arguments to `error'.
4811
4812 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4813 to `error' in error message about FINAL_CHAR argument. Make sure
4814 FINAL_CHAR is a character, and use %c when it is passed as
4815 argument to `error'.
4816
4ffd0d6b 48172011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4818
4819 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4820
4821 * w32.c: Include <time.h>.
4822 (sys_localtime): New function.
4823
4ffd0d6b 48242011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4825
4826 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4827
4ffd0d6b 4828 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4829
4ffd0d6b 48302011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4831
4ffd0d6b
GM
4832 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4833 zombies (Bug#8467).
aac0c6e3 4834
04c56954
EZ
48352011-04-19 Eli Zaretskii <eliz@gnu.org>
4836
4837 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4838 gl_state.e_property when gl_state.object is Qt.
4839
4840 * insdel.c (make_gap_larger): Remove limitation of buffer size
4841 to <= INT_MAX.
4842
16a43933
CY
48432011-04-18 Chong Yidong <cyd@stupidchicken.com>
4844
4845 * xdisp.c (lookup_glyphless_char_display)
4846 (produce_glyphless_glyph): Handle cons cell entry in
4847 glyphless-char-display.
4848 (Vglyphless_char_display): Document it.
4849
4850 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4851 glyphless-char-display.
4852
4581706e
CY
48532011-04-17 Chong Yidong <cyd@stupidchicken.com>
4854
4855 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4856
4857 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4858
4859 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4860 definition for no-X builds.
4861
4887c6e2 48622011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4863
fd35b6f9
PE
4864 Static checks with GCC 4.6.0 and non-default toolkits.
4865
5c1ccb01
PE
4866 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4867
006c5daa
PE
4868 * process.c (keyboard_bit_set): Define only if SIGIO.
4869 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4870 (send_process): Repair possible setjmp clobbering.
4871
efc736d3
PE
4872 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4873
4e2fe2e6
PE
4874 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4875
f97334a2
PE
4876 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4877
4e75f29d
PE
4878 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4879 Define only if needed.
4880
90efadd1
PE
4881 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4882 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4883 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4884
3c647824
PE
4885 * dispextern.h (struct redisplay_interface): Rename param
4886 to avoid shadowing.
e264f262 4887 * termhooks.h (struct terminal): Likewise.
761383f4 4888 * xterm.c (xembed_send_message): Likewise.
3c647824 4889
b58c5c4a
PE
4890 * insdel.c (make_gap_smaller): Define only if
4891 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4892
cad59032
PE
4893 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4894 it.
4895
c339dc2e
PE
4896 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4897 so that we aren't warned about unused symbols.
4898
91a3e27b
PE
4899 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4900
399c71d3 4901 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4902
8ffc96f5
PE
4903 * xfns.c (x_real_positions): Mark locals as initialized.
4904
eef9bc79
PE
4905 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4906
098db9dd
PE
4907 * xterm.c: Fix problems found by static analysis with other toolkits.
4908 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4909 (x_dispatch_event): Declare static if USE_GTK, and
4910 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4911 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4912 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4913 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4914 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4915
eb18f6cc
PE
4916 * xmenu.c (menu_help_callback): Pointer type fixes.
4917 Use const pointers when pointing at readonly data. Avoid pointer
4918 signedness clashes.
4919 (FALSE): Remove unused macro.
4920 (update_frame_menubar): Remove unused decl.
4921
1fe72bf8
PE
4922 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4923
60d9e1db
PE
4924 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4925 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4926 (single_menu_item): Rename local to avoid shadowing.
4927
39261c26
PE
4928 * keyboard.c (make_lispy_event): Remove unused local var.
4929
018c5e19
PE
4930 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4931 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4932
63d2b86e
PE
4933 * bitmaps: Change bitmaps from unsigned char back to the X11
4934 compatible char. Avoid the old compiler warnings about
4935 out-of-range initializers by using, for example, '\xab' rather
4936 than 0xab.
4937
aefd87e1
PE
4938 * xgselect.c (xgselect_initialize): Check vs interface
4939 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4940
bf501fb9
PE
4941 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4942
e9829fdf
PE
4943 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4944 to read-only memory.
4945
1086c095
PE
4946 * fns.c (vector): Remove; this old hack is no longer needed.
4947
2baccd04 4948 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4949 Remove unused var.
dde42981 4950 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4951
72391843 4952 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4953
436c16df 4954 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4955 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4956 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4957
92bb796d 4958 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4959 (x_term_init): Remove local to avoid shadowing.
92bb796d 4960
764430a3 4961 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4962
4963 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4964 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4965
d1dfb56c
EZ
49662011-04-16 Eli Zaretskii <eliz@gnu.org>
4967
c4354cb4
EZ
4968 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4969
d1dfb56c
EZ
4970 Fix regex.c, syntax.c and friends for buffers > 2GB.
4971 * syntax.h (struct gl_state_s): Declare character position members
4972 EMACS_INT.
4973
4974 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4975
04f2d78b
CB
4976 * textprop.c (verify_interval_modification, interval_of):
4977 Declare arguments EMACS_INT.
d1dfb56c
EZ
4978
4979 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4980 EMACS_INT.
4981
4982 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4983
4984 * indent.c (Fvertical_motion): Local variable it_start is now
4985 EMACS_INT.
4986
4987 * regex.c (re_match, re_match_2, re_match_2_internal)
4988 (bcmp_translate, regcomp, regexec, print_double_string)
4989 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4990 (re_compile_pattern, re_exec): Declare arguments and local
4991 variables `size_t' and `ssize_t' and return values `regoff_t', as
4992 appropriate.
4993 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4994 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4995 <compile_stack_type>: `size' and `avail' are now `size_t'.
4996
4997 * regex.h <regoff_t>: Use ssize_t, not int.
4998 (re_search, re_search_2, re_match, re_match_2): Arguments that
4999 specify buffer/string position and length are now ssize_t and
5000 size_t. Return type is regoff_t.
5001
613052cd
BK
50022011-04-16 Ben Key <bkey76@gmail.com>
5003
5004 * nsfont.m: Fixed bugs in ns_get_family and
5005 ns_descriptor_to_entity that were caused by using free to
5006 deallocate memory blocks that were allocated by xmalloc (via
5007 xstrdup). This caused Emacs to crash when compiled with
5008 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5009 --enable-checking=xmallocoverrun). xfree is now used to
5010 deallocate these memory blocks.
5011
4170f62f 50122011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5013
71b41406
PE
5014 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5015
9587a89d
PE
5016 emacs_write: Accept and return EMACS_INT for sizes.
5017 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5018 et seq.
5019 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5020 Accept and return EMACS_INT.
5021 (emacs_gnutls_write): Return the number of bytes written on
5022 partial writes.
5023 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5024 (emacs_read, emacs_write): Remove check for negative size, as the
5025 Emacs source code has been audited now.
9587a89d
PE
5026 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5027 (emacs_read, emacs_write): Use it.
273a5f82
PE
5028 * process.c (send_process): Adjust to the new signatures of
5029 emacs_write and emacs_gnutls_write. Do not attempt to store
5030 a byte offset into an 'int'; it might overflow.
9587a89d 5031 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5032
3e047f51
PE
5033 * sound.c: Don't assume sizes fit in 'int'.
5034 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5035 Return EMACS_INT, not int.
3e047f51 5036 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5037 Accept EMACS_INT, not int.
5038 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5039 record read return values.
5040
cc39a9db
BK
50412011-04-15 Ben Key <bkey76@gmail.com>
5042
c9d0ec6d
JB
5043 * keyboard.c (Qundefined): Don't declare static since it is used
5044 in nsfns.m.
5045 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5046 static since they are used in nsfont.m.
cc39a9db 5047
6c60eb9f
SM
50482011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5049
5050 * process.c (Qprocessp): Don't declare static.
5051 * lisp.h (Qprocessp): Declare again.
5052
7990b61a
JB
50532011-04-15 Juanma Barranquero <lekktu@gmail.com>
5054
5055 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5056
5d4cb038
PE
50572011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5058
8bd7b830 5059 Improve C-level modularity by making more things 'static'.
cd64ea1d 5060
e3b27b31
PE
5061 Don't publish debugger-only interfaces to other modules.
5062 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5063 (verify_bytepos, count_markers): Move decls to the only modules
5064 that need them.
5065 * region-cache.h (pp_cache): Likewise.
5066 * window.h (check_all_windows): Likewise.
5067 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5068
5d4cb038
PE
5069 * sysdep.c (croak): Now static, if
5070 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5071 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5072
5073 * alloc.c (refill_memory_reserve): Now static if
5074 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5075 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5076
e87b6180
PE
5077 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5078 Define only if USE_LUCID.
5079
ac64929e
PE
5080 * xrdb.c (x_customization_string, x_rm_string): Now static.
5081
6f37259d
PE
5082 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5083 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5084
1683e3ab
PE
5085 * xdisp.c (draw_row_with_mouse_face): Now static.
5086 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5087
de9c2632
PE
5088 * window.h (check_all_windows): Mark externally visible.
5089
2b96acb7
PE
5090 * window.c (window_deletion_count): Now static.
5091
5092 * undo.c: Make symbols static if they're not exported.
5093 (last_undo_buffer, last_boundary_position, pending_boundary):
5094 Now static.
5095
50436f33
PE
5096 * textprop.c (interval_insert_behind_hooks): Now static.
5097 (interval_insert_in_front_hooks): Likewise.
5098
64520e5c
PE
5099 * term.c: Make symbols static if they're not exported.
5100 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5101 (max_frame_lines, tty_set_terminal_modes):
5102 (tty_reset_terminal_modes, tty_turn_off_highlight):
5103 (get_tty_terminal): Now static.
5104 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5105 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5106 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5107 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5108 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5109
1fa53021
PE
5110 * sysdep.c: Make symbols static if they're not exported.
5111 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5112 Now static.
5113 (sigprocmask_set, full_mask): Remove; unused.
5114 (wait_debugging): Mark as visible.
5115 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5116 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5117
d4b43b22
PE
5118 * syntax.c (syntax_temp): Define only if !__GNUC__.
5119
b7c513d0
PE
5120 * sound.c (current_sound_device, current_sound): Now static.
5121
989b29ad
PE
5122 * search.c (searchbufs, searchbuf_head): Now static.
5123
13a55a78
PE
5124 * scroll.c (scroll_cost): Remove; unused.
5125 * dispextern.h (scroll_cost): Remove decl.
5126
de68a1fc
PE
5127 * region-cache.h (pp_cache): Mark as externally visible.
5128
40ccffa6
PE
5129 * process.c: Make symbols static if they're not exported.
5130 (process_tick, update_tick, create_process, chan_process):
5131 (Vprocess_alist, proc_buffered_char, datagram_access):
5132 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5133 (deactivate_process): Mark defn as static, as well as decl.
5134 * lisp.h (create_process): Remove decl.
5135 * process.h (chan_process, Vprocess_alist): Remove decls.
5136
ad64fc97
PE
5137 * print.c: Make symbols static if they're not exported.
5138 (print_depth, new_backquote_output, being_printed, print_buffer):
5139 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5140 (print_interval, print_number_index, initial_stderr_stream):
5141 Now static.
5142 * lisp.h (Fprinc): Remove decl.
5143 (debug_output_compilation_hack): Mark as externally visible.
5144
adddb265
PE
5145 * sysdep.c (croak): Move decl from here to syssignal.h.
5146 * syssignal.h (croak): Put it here, so the API can be checked when
5147 'croak' is called from dissociate_if_controlling_tty.
5148
1717ede2
PE
5149 * minibuf.c: Make symbols static if they're not exported.
5150 (minibuf_save_list, choose_minibuf_frame): Now static.
5151 * lisp.h (choose_minibuf_frame): Remove decl.
5152
fa5fb2bc
PE
5153 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5154
1e3890d1
PE
5155 * lread.c: Make symbols static if they're not exported.
5156 (read_objects, initial_obarray, oblookup_last_bucket_number):
5157 Now static.
5158 (make_symbol): Remove; unused.
5159 * lisp.h (initial_obarray, make_symbol): Remove decls.
5160
8a1414fa
PE
5161 * keyboard.c: Make symbols static if they're not exported.
5162 (single_kboard, recent_keys_index, total_keys, recent_keys):
5163 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5164 (this_single_command_key_start, echoing, last_auto_save):
5165 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5166 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5167 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5168 (Vlispy_mouse_stem, double_click_count):
5169 Now static.
5170 (force_auto_save_soon): Define only if SIGDANGER.
5171 (ignore_mouse_drag_p): Now static if
5172 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5173 (print_help): Remove; unused.
5174 (stop_character, last_timer_event): Mark as externally visible.
5175 * keyboard.h (ignore_mouse_drag_p): Declare only if
5176 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5177 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5178 * lisp.h (echoing): Remove decl.
5179 (force_auto_save_soon): Declare only if SIGDANGER.
5180 * xdisp.c (redisplay_window): Simplify code, to make it more
5181 obvious that ignore_mouse_drag_p is not accessed if !defined
5182 USE_GTK && !defined HAVE_NS.
5183
93ea6e8f
PE
5184 * intervals.c: Make symbols static if they're not exported.
5185 (merge_properties_sticky, merge_interval_right, delete_interval):
5186 Now static.
5187 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5188
77382fcc
PE
5189 * insdel.c: Make symbols static if they're not exported.
5190 However, leave prepare_to_modify_buffer alone. It's never
5191 called from outside this function, but that appears to be a bug.
5192 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5193 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5194 (adjust_after_replace_noundo): Remove; unused.
5195 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5196 (signal_before_change): Remove decls.
77382fcc 5197
9306c32e
PE
5198 * indent.c (val_compute_motion, val_vmotion): Now static.
5199
cd44d2eb
PE
5200 * image.c: Make symbols static if they're not exported.
5201 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5202 if USE_GTK.
5203 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5204 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5205
ad9a7a06
PE
5206 * fringe.c (standard_bitmaps): Now static.
5207 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5208
81626931
PE
5209 * frame.c: Make symbols static if they're not exported.
5210 (x_report_frame_params, make_terminal_frame): Now static.
5211 (get_frame_param): Now static, unless HAVE_NS.
5212 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5213 (x_get_resource_string): Remove; not used.
5214 * frame.h (make_terminal_frame, x_report_frame_params):
5215 (x_get_resource_string); Remove decls.
5216 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5217 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5218
239f9db9
PE
5219 * font.c, fontset.c: Make symbols static if they're not exported.
5220 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5221 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5222 * font.c (font_close_object): Now static.
5223 * font.h (font_close_object): Remove.
5224 * fontset.c (FONTSET_OBJLIST): Remove.
5225 (free_realized_fontset) #if-0 the body, which does nothing.
5226 (face_suitable_for_char_p): #if-0, as it's never called.
5227 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5228 * xfaces.c (face_at_string_position):
5229 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5230 since 0 is always ASCII.
5231
dfcf3579
PE
5232 * fns.c (weak_hash_tables): Now static.
5233
5045092b
PE
5234 * fileio.c: Make symbols static if they're not exported.
5235 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5236 (Vwrite_region_annotation_buffers): Now static.
5237
57a96f5c
PE
5238 * eval.c: Make symbols static if they're not exported.
5239 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5240 * lisp.h (backtrace_list): Remove decl.
5241
35f08c38
PE
5242 * emacs.c: Make symbols static if they're not exported.
5243 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5244 (fatal_error_code, fatal_error_signal_hook, standard_args):
5245 Now static.
5246 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5247 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5248 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5249 * lisp.h (fatal_error_signal_hook): Remove decl.
5250 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5251
f44bd759
PE
5252 * editfns.c: Move a (normally-unused) function to its only use.
5253 * editfns.c, lisp.h (get_operating_system_release): Remove.
5254 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5255 worth the hassle of breaking this out.
5256
b532497d
PE
5257 * xterm.c: Make symbols static if they're not exported.
5258 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5259 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5260 (x_destroy_window, x_delete_display):
5261 Now static.
5262 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5263 (x_mouse_leave): Remove; unused.
5264 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5265 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5266 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5267 Remove decls.
5268 (x_mouse_leave): Declare only if WINDOWSNT.
5269 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5270 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5271 USE_X_TOOLKIT.
5272
1675728f
PE
5273 * ftxfont.c: Make symbols static if they're not exported.
5274 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5275 HAVE_FREETYPE.
5276 * font.h (ftxfont_driver): Likewise.
5277
e4cebfca
PE
5278 * xfns.c: Make symbols static if they're not exported.
5279 (x_last_font_name, x_display_info_for_name):
5280 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5281 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5282 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5283 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5284 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5285 (last_show_tip_args): Now static.
5286 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5287 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5288 (x_screen_planes): Remove; unused.
5289 * dispextern.h (x_screen_planes): Remove decl.
5290
5bf46f05
PE
5291 * dispnew.c: Make symbols static if they're not exported.
5292 * dispextern.h (redraw_garbaged_frames, scrolling):
5293 (increment_row_positions): Remove.
5294 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5295 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5296 Now static.
5297 (redraw_garbaged_frames): Remove; unused.
5298
435f4c28
PE
5299 * xfaces.c: Make symbols static if they're not exported.
5300 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5301 Remove decls.
5302 * xterm.h (defined_color): Remove decls.
5303 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5304 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5305 (menu_face_changed_default, defined_color, free_realized_face):
5306 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5307 (ascii_face_of_lisp_face): Remove; unused.
5308
8524aef3
PE
5309 * xdisp.c: Make symbols static if they're not exported.
5310 * dispextern.h (scratch_glyph_row, window_box_edges):
5311 (glyph_to_pixel_coords, set_cursor_from_row):
5312 (get_next_display_element, set_iterator_to_next):
5313 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5314 (show_mouse_face): Remove decls
5315 * frame.h (message_buf_print): Likewise.
5316 * lisp.h (pop_message, set_message, check_point_in_composition):
5317 Likewise.
5318 * xterm.h (set_vertical_scroll_bar): Likewise.
5319 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5320 (message_buf_print, scratch_glyph_row, displayed_buffer):
5321 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5322 (get_next_display_element, show_mouse_face, window_box_edges):
5323 (frame_to_window_pixel_xy, check_point_in_composition):
5324 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5325 (glyph_to_pixel_coords): Remove; unused.
5326
16390cd2
PE
5327 * dired.c (file_name_completion): Now static.
5328
5329 * dbusbind.c (xd_in_read_queued_messages): Now static.
5330
a25f4dfa
PE
5331 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5332 * data.c (circular_list_error): Remove.
5333
14a9c8df
PE
5334 * commands.h (last_point_position, last_point_position_buffer):
5335 (last_point_position_window): Remove decls.
5336 * keyboard.c: Make these variables static.
5337
04f2d78b
CB
5338 * coding.h (coding, code_convert_region, encode_coding_gap):
5339 Remove decls.
74ab6df5
PE
5340 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5341 (iso_code_class, detect_coding, code_convert_region): Now static.
5342 (encode_coding_gap): Remove; unused.
5343
38dfbee1
PE
5344 * chartab.c (chartab_chars, chartab_bits): Now static.
5345
a2cb4e63
PE
5346 * charset.h (charset_iso_8859_1): Remove decl.
5347 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5348 Now static.
5349
127198fd
PE
5350 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5351 * ccl.c (Vccl_program_table): Now static.
5352 (check_ccl_update): Remove; unused.
5353
d85b608f
PE
5354 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5355 * category.h: ... from here.
5356 * category.c (check_category_table, set_category_set): Now static.
5357
31cd66f3
PE
5358 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5359 * lisp.h: Remove these decls.
5360
c358e587
PE
5361 * buffer.c (buffer_count): Remove unused var.
5362
e78aecca
PE
5363 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5364 so that it's not optimized away.
5365 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5366 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5367 exported only to the debugger.
5368
e192d7d3 5369 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5370 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5371
92470028
PE
5372 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5373 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5374 was inaccessible from Lisp.
5375 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5376 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5377
244ed907
PE
5378 alloc.c: Import and export fewer symbols, and remove unused items.
5379 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5380 is defined.
5381 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5382 it's not optimized away by whole-program optimization.
5383 (message_enable_multibyte, free_misc): Remove.
5384 (catchlist, handlerlist, mark_backtrace):
5385 Declare only if BYTE_MARK_STACK.
5386 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5387 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5388 (message_enable_multibyte): Remove decl.
5389 (free_misc, interval_free_list, float_block, float_block_index):
5390 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5391 (cons_free_list, last_marked_index):
5392 Now static.
5393 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5394 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5395 (mark_backtrace): Define only if BYTE_MARK_STACK.
5396 * xdisp.c (message_enable_multibyte): Now static.
5397
61c2b50e 5398 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5399 This makes it easier for human readers (and static analyzers)
5400 to see whether these variables are used from other modules.
5401 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5402 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5403 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5404 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5405 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5406 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5407 * xmenu.c, xselect.c:
5408 Declare Q* vars static if they are not used in other modules.
5409 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5410 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5411 Remove decls of unexported vars.
5412 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5413
95c82688
PE
5414 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5415
16a97296
PE
5416 Make Emacs functions such as Fatom 'static' by default.
5417 This makes it easier for human readers (and static analyzers)
5418 to see whether these functions can be called from other modules.
5419 DEFUN now defines a static function. To make the function external
5420 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5421 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5422 (Finit_image_library):
16a97296
PE
5423 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5424 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5425 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5426 Remove decls, since these functions are now static.
5427 (Funintern, Fget_internal_run_time): New decls, since these functions
5428 were already external.
95c82688 5429
16a97296
PE
5430 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5431 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5432 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5433 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5434 * keyboard.c, keymap.c, lread.c:
5435 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5436 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5437 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5438 Mark functions with DEFUE instead of DEFUN,
5439 if they are used in other modules.
5440 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5441 decls for now-static functions.
5442 * buffer.h (Fdelete_overlay): Remove decl.
5443 * callproc.c (Fgetenv_internal): Mark as internal.
5444 * composite.c (Fremove_list_of_text_properties): Remove decl.
5445 (Fcomposition_get_gstring): New forward static decl.
5446 * composite.h (Fcomposite_get_gstring): Remove decl.
5447 * dired.c (Ffile_attributes): New forward static decl.
5448 * doc.c (Fdocumntation_property): New forward static decl.
5449 * eval.c (Ffetch_bytecode): New forward static decl.
5450 (Funintern): Remove extern decl; now in .h file where it belongs.
5451 * fileio.c (Fmake_symbolic_link): New forward static decl.
5452 * image.c (Finit_image_library): New forward static decl.
5453 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5454 * intervals.h (Fprevious_property_change):
5455 (Fremove_list_of_text_properties): Remove decls.
5456 * keyboard.c (Fthis_command_keys): Remove decl.
5457 (Fcommand_execute): New forward static decl.
5458 * keymap.c (Flookup_key): New forward static decl.
5459 (Fcopy_keymap): Now static.
5460 * keymap.h (Flookup_key): Remove decl.
5461 * process.c (Fget_process): New forward static decl.
5462 (Fprocess_datagram_address): Mark as internal.
5463 * syntax.c (Fsyntax_table_p): New forward static decl.
5464 (skip_chars): Remove duplicate decl.
5465 * textprop.c (Fprevious_property_change): New forward static decl.
5466 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5467 Now internal.
5468 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5469 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5470
785bbd42
PE
5471 * editfns.c (Fformat): Remove unreachable code.
5472
8b913b57
AS
54732011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5474
5475 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5476 change. (Bug#8496)
5477
a6744a35
EZ
54782011-04-13 Eli Zaretskii <eliz@gnu.org>
5479
5480 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5481 when at ZV. (Bug#8487)
5482
e7974947
AS
54832011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5484
baad03f0
AS
5485 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5486 (Bug#8437)
5487 * keyboard.c (parse_tool_bar_item): Likewise.
5488 * sound.c (sound_cleanup, alsa_close): Likewise.
5489 * termcap.c (tgetent): Likewise.
5490 * xfns.c (x_default_font_parameter): Likewise.
5491 * xsettings.c (read_and_apply_settings): Likewise.
5492
e7974947
AS
5493 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5494 (overrun_check_free): Protoize.
5495
28272684
PE
54962011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5497
5498 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5499 since callers should never pass a negative size.
5500 Change the signature to match that of plain 'read' and 'write'; see
5501 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5502 * lisp.h: Update prototypes of emacs_write and emacs_read.
5503
11997c76
EZ
55042011-04-11 Eli Zaretskii <eliz@gnu.org>
5505
5506 * xdisp.c (redisplay_window): Don't try to determine the character
5507 position of the scroll margin if the window start point w->startp
e896f03c 5508 is outside the buffer's accessible region. (Bug#8468)
11997c76 5509
8a2cbd72
EZ
55102011-04-10 Eli Zaretskii <eliz@gnu.org>
5511
5512 Fix write-region and its subroutines for buffers > 2GB.
5513 * fileio.c (a_write, e_write): Modify declaration of arguments and
5514 local variables to support buffers larger than 2GB.
5515 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5516
5517 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5518 argument, local variables, and return value.
5519
5520 * lisp.h: Update prototypes of emacs_write and emacs_read.
5521
5522 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5523
4073e537 55242011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5525
1ebfdcb6
PE
5526 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5527
b2ded58d
PE
5528 Fix more problems found by GCC 4.6.0's static checks.
5529
7d66342c
PE
5530 * xdisp.c (vmessage): Use a better test for character truncation.
5531
bbf47d44
PE
5532 * charset.c (load_charset_map): <, not <=, for optimization,
5533 and to avoid potential problems with integer overflow.
9248994d 5534 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5535 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5536 * editfns.c (Fformat): Likewise.
1e69125e 5537 * syntax.c (skip_chars): Likewise.
3befa583 5538
e3019616
PE
5539 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5540 This also lets GCC 4.6.0 generate slightly better loop code.
5541
becfa255
PE
5542 * callint.c (Fcall_interactively): <, not <=, for optimization.
5543 (Fcall_interactively): Count the number of arguments produced,
5544 not the number of arguments given. This is simpler and lets GCC
5545 4.6.0 generate slightly better code.
5546
dae0cd48
PE
5547 * ftfont.c: Distingish more carefully between FcChar8 and char.
5548 The previous code passed unsigned char * to a functions like
5549 strlen and xstrcasecmp that expect char *, which does not
5550 conform to the C standard.
5551 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5552 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5553 char * when the C standard requires it.
5554
76032d70
PE
5555 * keyboard.c (read_char): Remove unused var.
5556
eb3f1cc8
PE
5557 * eval.c: Port to Windows vsnprintf (Bug#8435).
5558 Include <limits.h>.
5559 (SIZE_MAX): Define if the headers do not.
5560 (verror): Do not give up if vsnprintf returns a negative count.
5561 Instead, grow the buffer. This ports to Windows vsnprintf, which
5562 does not conform to C99. Problem reported by Eli Zaretskii.
5563 Also, simplify the allocation scheme, by avoiding the need for
5564 calling realloc, and removing the ALLOCATED variable.
5565
70476b54
PE
5566 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5567
12020a9e
PE
5568 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5569 But keep the doprint source code for now, as we might revamp it
5570 and use it again (Bug#8435).
ea6c7ae6
PE
5571 * lisp.h (doprnt): Remove.
5572 * Makefile.in (base_obj): Remove doprnt.o.
5573 * deps.mk (doprnt.o): Remove.
5574
5fdb398c
PE
5575 error: Print 32- and 64-bit integers portably (Bug#8435).
5576 Without this change, on typical 64-bit hosts error ("...%d...", N)
5577 was used to print both 32- and 64-bit integers N, which relied on
5578 undefined behavior.
5579 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5580 New macro.
5581 * lisp.h (error, verror): Mark as printf-like functions.
5582 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5583 Report overflow in size calculations when allocating printf buffer.
5584 Do not truncate output string at its first null byte.
5585 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5586 Truncate the output at a character boundary, since vsnprintf does not
5587 do that.
5588 * charset.c (check_iso_charset_parameter): Convert internal
5589 character to string before calling 'error', since %c now has the
5590 printf meaning.
5591 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5592 overflow when computing char to be passed to 'error'. Do not
5593 pass Lisp_Object to 'error'; pass the integer instead.
5594 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5595 formatted with plain %d.
5596
b189fa66
PE
5597 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5598
bff87ef0
PE
5599 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5600
7e2cac20
PE
5601 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5602
ce4d90b5
PE
5603 * xterm.c (x_catch_errors): Remove duplicate declaration.
5604
266c9547
PE
5605 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5606
79c49ad2
PE
5607 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5608
368f4090
JM
56092011-04-10 Jim Meyering <meyering@redhat.com>
5610
5611 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5612 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5613 return ssize_t not "int", and use size_t as the buffer length.
5614 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5615 * gnutls.h: Update declarations.
5616 * process.c (read_process_output): Use ssize_t, to match.
5617 (send_process): Likewise.
5618
a32d4040
CY
56192011-04-09 Chong Yidong <cyd@stupidchicken.com>
5620
5621 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5622
8546720e 56232011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5624
04f2d78b
CB
5625 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5626 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5627
8546720e
GM
5628 * xterm.c (handle_one_xevent):
5629 * xmenu.c (create_and_show_popup_menu):
5630 * xselect.c (x_decline_selection_request)
5631 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5632
0a2f5c1a 56332011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5634
5635 Fix some uses of `int' instead of EMACS_INT.
5636 * search.c (string_match_1, fast_string_match)
5637 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5638 (scan_buffer, find_next_newline_no_quit)
5639 (find_before_next_newline, search_command, Freplace_match)
5640 (Fmatch_data): Make some `int' variables be EMACS_INT.
5641
5642 * xdisp.c (display_count_lines): 3rd argument and return value now
5643 EMACS_INT. All callers changed.
5644 (pint2hrstr): Last argument is now EMACS_INT.
5645
5646 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5647 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5648 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5649 (decode_coding_utf_16, decode_coding_emacs_mule)
5650 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5651 (decode_coding_ccl, decode_coding_charset)
5652 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5653 (decode_coding_iso_2022, decode_coding_emacs_mule)
5654 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5655 <char_offset, last_offset>: Declare EMACS_INT.
5656 (encode_coding_utf_8, encode_coding_utf_16)
5657 (encode_coding_emacs_mule, encode_invocation_designation)
5658 (encode_designation_at_bol, encode_coding_iso_2022)
5659 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5660 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5661 Declare EMACS_INT.
5662 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5663 (encode_invocation_designation): Last argument P_NCHARS is now
5664 EMACS_INT.
5665 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5666 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5667
5668 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5669 All users changed.
5670
5671 * ccl.c (Fccl_execute_on_string): Declare some variables
5672 EMACS_INT.
5673
8546720e 56742011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5675
5676 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5677
4e19a977
CS
56782011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5679
5680 * process.c (Fformat_network_address): Doc fix.
5681
87302331
R
56822011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5683
5684 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5685
cbb59342
CY
56862011-04-08 Chong Yidong <cyd@stupidchicken.com>
5687
5688 * keyboard.c (read_char): Call Lisp function help-form-show,
5689 instead of using internal_with_output_to_temp_buffer.
5690 (Qhelp_form_show): New var.
e0d38eeb 5691 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5692
5693 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5694
5695 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5696
e67a13ab
CY
56972011-04-06 Chong Yidong <cyd@stupidchicken.com>
5698
04f2d78b
CB
5699 * process.c (Flist_processes): Remove to Lisp.
5700 (list_processes_1): Delete.
e67a13ab 5701
973f782d
EZ
57022011-04-06 Eli Zaretskii <eliz@gnu.org>
5703
7c106b1e
EZ
5704 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5705
973f782d
EZ
5706 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5707
41cf7d1a 57082011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5709
ca23cc88
PE
5710 Fix more problems found by GCC 4.6.0's static checks.
5711
f390e2d5
PE
5712 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5713
42eea0d0
PE
5714 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5715
b69769da 5716 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5717
f9541e84
PE
5718 * xdisp.c (vmessage): Mark as a printf-like function.
5719
13841b55
PE
5720 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5721
c136c10f
PE
5722 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5723
5e2d4a30
PE
5724 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5725 printf-like functions.
5726 (tiff_load): Add casts to remove these marks before passing them
5727 to system-supplied API.
5728
583f48b9
PE
5729 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5730
b25d760e
PE
5731 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5732 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5733 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5734 directly, rather than having caller test rule sign. This avoids
5735 some unnecessary tests.
5736 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5737 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5738 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5739
bc7b6697 5740 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5741 (xfont_open): Avoid unnecessary tests.
bc7b6697 5742
27ccc379
PE
5743 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5744
dcd5c89a
PE
5745 * composite.h, composite.c (composition_gstring_put_cache):
5746 Use EMACS_INT, not int, for length.
5747
b13a45c6
PE
5748 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5749 breaking out part of COMPOSITION_DECODE_RULE.
5750 (COMPOSITION_DECODE_RULE): Use it.
5751 * composite.c (get_composition_id): Remove unused local vars,
5752 by using the new macro.
5753
1e792e4d
PE
5754 * textprop.c (set_text_properties_1): Change while to do-while,
5755 since the condition is always true at first.
5756
dc6c6455 5757 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5758 (interval_deletion_adjustment): Return unsigned value.
5759 All uses changed.
dc6c6455 5760
aba7731a
PE
5761 * process.c (list_processes_1, create_pty, read_process_output):
5762 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5763 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5764 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5765 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5766 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5767
fdfc4bf3
PE
5768 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5769
fca8fe46 5770 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5771 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5772
06a0259a 5773 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5774 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5775 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5776
e7b9e80f
PE
5777 * print.c (print_error_message): Avoid int overflow.
5778
56201685
PE
5779 * font.c (font_list_entities): Redo for clarity,
5780 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5781
78834453 5782 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5783 (font_score): Avoid potential overflow in diff calculation.
78834453 5784
0bc0b309 5785 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5786 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5787
e610eaca
PE
5788 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5789
b895abce
PE
5790 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5791 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5792 can always succeed if overflow has undefined behavior.
5793
1f1d9321 5794 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5795 (wordify): Omit three unnecessary tests.
1f1d9321 5796
c59478bc
PE
5797 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5798 All callers changed. This avoids the need for an unused var.
5799
79b73827
PE
5800 * casefiddle.c (casify_region): Remove var that is set but not used.
5801
a4db5dfe
PE
5802 * dired.c (file_name_completion): Remove var that is set but not used.
5803
43aae36e
PE
5804 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5805
2a47c44d 5806 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5807 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5808
a37c69bf
PE
5809 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5810 Check for integer overflow on size calculations.
5811
328ab8e7
PE
5812 * buffer.c (Fprevious_overlay_change): Remove var that is set
5813 but not used.
5814
e5a2a5cb
PE
5815 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5816 Remove vars that are set but not used.
8d84a6eb 5817 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5818 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5819
a60e5f68
PE
5820 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5821
f661cb61 5822 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5823 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5824
f0397f5a
PE
5825 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5826 that are set but not used.
5827
8664db06 5828 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5829 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5830
6abdaa4a
PE
5831 * xselect.c (x_get_local_selection, x_handle_property_notify):
5832 Remove vars that are set but not used.
5833
0ce7538d 5834 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5835 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5836
9ae848fc
PE
5837 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5838 Remove var that is set but not used.
0b918413
PE
5839 (scroll_bar_windows_size): Now size_t, not int.
5840 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5841 Check for overflow.
9ae848fc 5842
a5a62657
PE
5843 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5844 (map_tty_color) [!defined MSDOS]: Likewise.
5845
5c5cdd39
PE
5846 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5847
66ebf983
PE
5848 * coding.c: Remove vars that are set but not used.
5849 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5850 All callers changed.
5851 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5852 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5853 (decode_coding_charset): Remove vars that are set but not used.
5854
1be4d761
PE
5855 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5856 that is set but not used.
5857
47553fa8
PE
5858 * print.c (print_object): Remove var that is set but not used.
5859
1f7196bf 5860 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5861 The gnulib version avoids calling malloc in the usual case,
5862 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5863 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5864 * filelock.c (current_lock_owner): Likewise.
5865 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5866 * sysdep.c: Include allocator.h, careadlinkat.h.
5867 (emacs_no_realloc_allocator): New static constant.
5868 (emacs_readlink): New function.
fdb61804
PE
5869 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5870 ../lib/careadlinkat.h.
d1fdcab7 5871
f84c17c7
SM
58722011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5873
5874 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5875 first non-nil return value).
5876
ef3862ad
JD
58772011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5878
5879 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5880 if not defined (Bug#8403).
5881
376a7006
JB
58822011-04-02 Juanma Barranquero <lekktu@gmail.com>
5883
5884 * xdisp.c (display_count_lines): Remove parameter `start',
5885 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5886 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5887 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5888 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5889 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5890 and thereabouts. All callers changed.
5891 (get_per_char_metric): Remove parameter `f', unused since
5892 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5893
6ca3801d
JM
58942011-04-02 Jim Meyering <meyering@redhat.com>
5895
5896 do not dereference NULL upon failed strdup
5897 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5898 (ns_get_family): Likewise.
5899
d8e2b5ba
JB
59002011-04-02 Juanma Barranquero <lekktu@gmail.com>
5901
5902 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5903
8c74fcbd
JD
59042011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5905
5906 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5907 later (Bug#8403).
5908
7200d79c
SM
59092011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5910
03408648 5911 Add lexical binding.
7200d79c 5912
03408648
SM
5913 * window.c (Ftemp_output_buffer_show): New fun.
5914 (Fsave_window_excursion):
5915 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5916
5917 * lread.c (lisp_file_lexically_bound_p): New function.
5918 (Fload): Bind Qlexical_binding.
5919 (readevalloop): Remove `evalfun' arg.
5920 Bind Qinternal_interpreter_environment.
5921 (Feval_buffer): Bind Qlexical_binding.
5922 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5923 Mark as dynamic.
5924 (syms_of_lread): Declare `lexical-binding'.
5925
5926 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5927
5928 * keyboard.c (eval_dyn): New fun.
5929 (menu_item_eval_property): Use it.
ca105506
SM
5930
5931 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5932
03408648
SM
5933 * fns.c (concat, mapcar1): Accept byte-code-functions.
5934
5935 * eval.c (Fsetq): Handle lexical vars.
5936 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5937 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5938 (FletX, Flet): Obey lexical binding.
5939 (Fcommandp): Handle closures.
5940 (Feval): New `lexical' arg.
5941 (eval_sub): New function extracted from Feval. Use it almost
5942 everywhere where Feval was used. Look up vars in lexical env.
5943 Handle closures.
5944 (Ffunctionp): Move from subr.el.
5945 (Ffuncall): Handle closures.
5946 (apply_lambda): Remove `eval_flags'.
5947 (funcall_lambda): Handle closures and new byte-code-functions.
5948 (Fspecial_variable_p): New function.
5949 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5950 but without exporting it to Lisp.
23aba0ea 5951
23aba0ea 5952 * doc.c (Fdocumentation, store_function_docstring):
03408648 5953 * data.c (Finteractive_form): Handle closures.
23aba0ea 5954
03408648
SM
5955 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5956 interactive spec.
ba83908c 5957
04f2d78b
CB
5958 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5959 New byte-codes.
03408648
SM
5960 (exec_byte_code): New function extracted from Fbyte_code to handle new
5961 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5962
03408648 5963 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5964
03408648 5965 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5966
e2abce01
JB
59672011-03-31 Juanma Barranquero <lekktu@gmail.com>
5968
5969 * xdisp.c (redisplay_internal): Fix prototype.
5970
63696a73 59712011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5972
63696a73 5973 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5974 (try_scrolling): Use it when setting scroll_limit.
5975 Limit scrolling to 100 screen lines.
63696a73
EZ
5976 (redisplay_window): Even when falling back on "recentering",
5977 position point in the window according to scroll-conservatively,
5978 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5979
5980 (try_scrolling): When point is above the window, allow searching
5981 as far as scroll_max, or one screenful, to compute vertical
5982 distance from PT to the scroll margin position. This prevents
5983 try_scrolling from unnecessarily failing when
5984 scroll-conservatively is set to a value slightly larger than the
5985 window height. Clean up the case of PT below the margin at bottom
5986 of window: scroll_max can no longer be INT_MAX. When aggressive
5987 scrolling is in use, don't let point enter the opposite scroll
5988 margin as result of the scroll.
5989 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5990 threshold of 100 lines for never-recentering scrolling.
5991
e4cc2dfc
JB
59922011-03-31 Juanma Barranquero <lekktu@gmail.com>
5993
5994 * dispextern.h (move_it_by_lines):
5995 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5996 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5997 (message_log_check_duplicate): Remove parameters `prev_bol' and
5998 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5999 (redisplay_internal): Remove parameter `preserve_echo_area',
6000 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6001
6002 * indent.c (Fvertical_motion):
6003 * window.c (window_scroll_pixel_based, Frecenter):
6004 Don't pass `need_y_p' to `move_it_by_lines'.
6005
1c470562
SM
60062011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6007
44f230aa
SM
6008 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6009 steal a few bits to be more compact.
6010 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6011 Remove unneeded casts.
6012
1c470562
SM
6013 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6014
888adce9
ZK
60152011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6016
6017 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6018 binding" message (bug#7967).
6019
f838ed7b
PE
60202011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6021
77861b95
PE
6022 Fix more problems found by GCC 4.6.0's static checks.
6023
de6dbc14
PE
6024 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6025 Remove unused local var.
6026
f838ed7b
PE
6027 * editfns.c (Fmessage_box): Remove unused local var.
6028
792c7b2b
PE
6029 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6030 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6031 Omit unused local vars.
c499e557 6032 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6033 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6034 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6035 Omit unused local var.
6036
ba0165e1
PE
6037 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6038 Don't assume string length fits in int.
32ad8845 6039 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6040 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6041
3c59b4c9
PE
6042 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6043 instead of alloca (Bug#8344).
6044
a3eed478 6045 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6046 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6047
eb4d412d
PE
6048 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6049
1658b401
PE
6050 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6051 concerns.
6052
6053 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6054
6055 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6056
9a2c6e05
PE
6057 * keyboard.c (syms_of_keyboard): Use the same style as later
6058 in this function when indexing through an array. This also
6059 works around GCC bug 48267.
6060
03d0a109
PE
6061 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6062
44f730c8
PE
6063 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6064
fe75f926
PE
6065 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6066 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6067
ffa8c828
PE
6068 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6069 This avoids undefined behavior on integer overflow, and is a bit
6070 more convenient anyway since it is compared to a size_t variable.
6071
c5101a77
PE
6072 Variadic C functions now count arguments with size_t, not int.
6073 This avoids an unnecessary limitation on 64-bit machines, which
6074 caused (substring ...) to crash on large vectors (Bug#8344).
6075 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6076 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6077 All variadic functions and their callers changed accordingly.
c5101a77
PE
6078 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6079 * data.c (arith_driver, float_arith_driver): Likewise.
6080 * editfns.c (general_insert_function): Likewise.
6081 * eval.c (struct backtrace.nargs, interactive_p)
6082 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6083 (funcall_lambda, mark_backtrace): Likewise.
6084 * fns.c (concat): Likewise.
6085 * frame.c (x_set_frame_parameters): Likewise.
6086 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6087 0 if not found, not -1. All callers changed.
6088
dd3f25f7
PE
6089 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6090 (stack_copy_size): Now size_t, not int.
6091 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6092
461c2ab9
JB
60932011-03-28 Juanma Barranquero <lekktu@gmail.com>
6094
6095 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6096 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6097 All callers changed.
6098
6099 * lisp.h (multibyte_char_to_unibyte):
6100 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6101 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6102 * character.h (CHAR_TO_BYTE8):
6103 * cmds.c (internal_self_insert):
6104 * editfns.c (general_insert_function):
6105 * keymap.c (push_key_description):
6106 * search.c (Freplace_match):
6107 * xdisp.c (message_dolog, set_message_1): All callers changed.
6108
f6d62986
SM
61092011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6110
6111 * keyboard.c (safe_run_hook_funcall): New function.
6112 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6113 don't set the hook to nil, but remove the offending function instead.
6114 (Qcommand_hook_internal): Remove, unused.
6115 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6116 Vcommand_hook_internal.
6117
6118 * eval.c (enum run_hooks_condition): Remove.
6119 (funcall_nil, funcall_not): New functions.
6120 (run_hook_with_args): Call each function through a `funcall' argument.
6121 Remove `cond' argument, now redundant.
6122 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6123 (Frun_hook_with_args_until_failure): Adjust accordingly.
6124 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6125
1db5b1ad
JB
61262011-03-28 Juanma Barranquero <lekktu@gmail.com>
6127
6128 * dispextern.h (string_buffer_position): Remove declaration.
6129
6130 * print.c (strout): Remove parameter `multibyte', unused since
6131 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6132
6133 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6134 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6135 All callers changed.
6136
6137 * w32.c (_wsa_errlist): Use braces for struct initializers.
6138
6139 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6140 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6141 All callers changed.
6142 (string_buffer_position): Likewise. Also, make static (it's never
6143 used outside xdisp.c).
6144 (cursor_row_p): Remove parameter `w', unused since
6145 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6146 (decode_mode_spec): Remove parameter `precision', introduced during
6147 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6148 All callers changed.
6149
5ffb62aa
JD
61502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6151
6152 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6153
461c2ab9 61542011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6155
6156 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6157 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6158 (ns_update_auto_hide_menu_bar): New functions.
6159 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6160 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6161 ns_constrain_all_frames.
6162 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6163 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6164
5c380ffb
JD
61652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6166
6167 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6168
9af30bdf
GM
61692011-03-27 Glenn Morris <rgm@gnu.org>
6170
6171 * syssignal.h: Replace RETSIGTYPE with void.
6172 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6173 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6174 Replace SIGTYPE with void everywhere.
6175 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6176 * s/template.h (SIGTYPE): Remove commented out definition.
6177
e2abce01
JB
61782011-03-26 Eli Zaretskii <eliz@gnu.org>
6179
6180 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6181 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6182
f868cd8a
JB
61832011-03-26 Juanma Barranquero <lekktu@gmail.com>
6184
59eb0929
JB
6185 * w32.c (read_unc_volume): Use parameter `henum', instead of
6186 global variable `wget_enum_handle'.
6187
6188 * keymap.c (describe_vector): Remove parameters `indices' and
6189 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6190 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6191
f868cd8a
JB
6192 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6193
6194 * keyboard.c (timer_check): Remove parameter `do_it_now',
6195 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6196 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6197 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6198
6199 * keyboard.c (read_char):
6200 * w32menu.c (w32_menu_display_help):
6201 * xmenu.c (show_help_event, menu_help_callback):
6202 Adjust calls to `show_help_echo'.
6203
6204 * gtkutil.c (xg_maybe_add_timer):
6205 * keyboard.c (readable_events):
6206 * process.c (wait_reading_process_output):
6207 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6208
6209 * insdel.c (adjust_markers_gap_motion):
6210 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6211 (gap_left, gap_right): Don't call it.
6212
2ecf6fdb
CY
62132011-03-25 Chong Yidong <cyd@stupidchicken.com>
6214
6215 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6216 incurred during fontification.
6217
6b1f9ba4
JB
62182011-03-25 Juanma Barranquero <lekktu@gmail.com>
6219
6220 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6221 (DEFVAR_PER_BUFFER): Don't pass it.
6222
6223 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6224 (scrolling_window): Don't pass it.
6225
0f4a96b5
JB
62262011-03-25 Juanma Barranquero <lekktu@gmail.com>
6227
6228 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6229
6230 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6231 and `suffix'.
6232 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6233 of variables specific to SELinux and computation of `encoded_absname'.
6234
6235 * image.c (XPutPixel): Remove unused variable `height'.
6236
6237 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6238
6239 * unexw32.c (get_section_info): Remove unused variable `section'.
6240
6241 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6242 (system_process_attributes): Remove unused variable `sess'.
6243 (sys_read): Remove unused variable `err'.
6244
6245 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6246 (w32_wnd_proc): Remove unused variable `isdead'.
6247 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6248 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6249 (x_create_tip_frame): Remove unused variable `tem'.
6250
6251 * w32inevt.c (w32_console_read_socket):
6252 Remove unused variable `no_events'.
6253
6254 * w32term.c (x_draw_composite_glyph_string_foreground):
6255 Remove unused variable `width'.
6256
1149507c
JB
62572011-03-24 Juanma Barranquero <lekktu@gmail.com>
6258
6259 * w32term.c (x_set_glyph_string_clipping):
6260 Don't pass uninitialized region to CombineRgn.
6261
9c88f339
JB
62622011-03-23 Juanma Barranquero <lekktu@gmail.com>
6263
6264 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6265 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6266 (Fx_close_connection): Remove unused variable `i'.
6267
6268 * w32font.c (w32font_draw): Return number of glyphs.
6269 (w32font_open_internal): Remove unused variable `i'.
6270 (w32font_driver): Add missing initializer.
6271
6272 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6273 (fill_in_menu): Remove unused variable `items_added'.
6274
6275 * w32term.c (last_mouse_press_frame): Remove static global variable.
6276 (w32_clip_to_row): Remove unused variable `f'.
6277 (x_delete_terminal): Remove unused variable `i'.
6278
6279 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6280 (NOTHING): Remove unused static global variable.
6281 (uniscribe_check_otf): Remove unused variable `table'.
6282 (uniscribe_font_driver): Add missing initializers.
6283
dee091a3
JD
62842011-03-23 Julien Danjou <julien@danjou.info>
6285
6286 * term.c (Fsuspend_tty, Fresume_tty):
6287 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6288 * window.c (temp_output_buffer_show):
6289 * insdel.c (signal_before_change):
6290 * frame.c (Fhandle_switch_frame):
6291 * fileio.c (Fdo_auto_save):
6292 * emacs.c (Fkill_emacs):
6293 * editfns.c (save_excursion_restore):
6294 * cmds.c (internal_self_insert):
6295 * callint.c (Fcall_interactively):
6296 * buffer.c (Fkill_all_local_variables):
6297 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6298 Use Frun_hooks.
0f4a96b5 6299 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6300 unconditionnaly since it does the check itself.
6301
2c520ab5 63022011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6303
c9c49752
PE
6304 Fix more problems found by GCC 4.5.2's static checks.
6305
8abc3f12
PE
6306 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6307 the first time through the loop, since we know p0 < p1 then.
6308 This also avoids a gcc -Wstrict-overflow warning.
6309
a2d26660
PE
6310 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6311 leading to a memory leak, possible in functions like
6312 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6313 of objects (Bug#8318).
a2d26660 6314
916c72e9
PE
6315 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6316 that could (at least in theory) be that large.
6317
19ab8a18
PE
6318 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6319 This is less likely to overflow, and avoids undefined behavior if
6320 overflow does occur. All callers changed. Use strtoul to scan
6321 for the unsigned long integer.
b7cbbd6f
PE
6322 (pint2hrstr): Simplify and tune code slightly.
6323 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6324
f0641eff
PE
6325 * scroll.c (do_scrolling): Work around GCC bug 48228.
6326 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6327
7f650bb9
PE
6328 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6329 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6330 (validate_x_resource_name): Simplify count usage.
6331 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6332
37dd57d1
PE
6333 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6334 fail (Bug#8306).
81e56e61 6335
699979fc 6336 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6337
401bf9b4
PE
6338 * process.c (Fmake_network_process): Use socklen_t, not int,
6339 where POSIX says socklen_t is required in portable programs.
6340 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6341 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6342 (Fmake_network_process, server_accept_connection):
6343 (wait_reading_process_output, read_process_output):
6344 Likewise.
6345
b93aacde
PE
6346 * process.c: Rename or move locals to avoid shadowing.
6347 (list_processes_1, Fmake_network_process):
6348 (read_process_output_error_handler, exec_sentinel_error_handler):
6349 Rename or move locals.
4dc343ee 6350 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6351 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6352 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6353 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6354 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6355
af8a867c 6356 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6357 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6358 Include tparam.h instead, since it declares them.
af8a867c
PE
6359 * cm.h (PC): Remove extern decl; tparam.h now does this.
6360 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6361 * terminfo.c: Include tparam.h, to check interfaces.
6362 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6363 (tparam): Adjust signature to match interface in tparam.h;
6364 this removes some undefined behavior. Check that outstring and len
6365 are zero, which they always are with Emacs.
6366 * tparam.h (PC, BC, UP): New extern decls.
6367
0248044d 6368 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6369 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6370
8ff096c1 6371 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6372 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6373 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6374 (ftfont_list): Remove unused local.
49eaafba
PE
6375 (get_adstyle_property, ftfont_pattern_entity):
6376 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6377 Rename locals to avoid shadowing.
8ff096c1 6378
e2be39f6
PE
6379 * xfont.c (xfont_list_family): Mark var as initialized.
6380
c9735e30
PE
6381 * xml.c (make_dom): Now static.
6382
8f5201ae
PE
6383 * composite.c (composition_compute_stop_pos): Rename local to
6384 avoid shadowing.
b246f932
PE
6385 (composition_reseat_it): Remove unused locals.
6386 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6387 (composition_update_it): Mark var as initialized.
11b61122
PE
6388 (find_automatic_composition): Mark vars as initialized,
6389 with a FIXME (Bug#8290).
8f5201ae 6390
760fbc2c
PE
6391 character.h: Rename locals to avoid shadowing.
6392 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6393 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6394 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6395 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6396 to avoid shadowing.
6397
ff08eb85
PE
6398 * textprop.c (property_change_between_p): Remove; unused.
6399
fc7bf025
PE
6400 * intervals.c (interval_start_pos): Now static.
6401
235d7abc
PE
6402 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6403
44f230aa
SM
6404 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6405 Rename locals to avoid shadowing.
3e7d6594 6406
50060332
PE
6407 * sound.c (wav_play, au_play, Fplay_sound_internal):
6408 Fix pointer signedness.
d01f234b 6409 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6410 (wav_play): Initialize a variable to 0, to prevent undefined
6411 behavior (Bug#8278).
50060332 6412
c4fc4e30
PE
6413 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6414
918436ed
PE
6415 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6416
c939f91b
PE
6417 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6418 clobbering (Bug#8298).
b9c7f648
PE
6419 * sysdep.c (sys_subshell): Likewise.
6420 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6421
6bd8c144
PE
6422 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6423 This should get cleaned up, so that child_setup has the
6424 same signature on all platforms.
6425
7710357c 6426 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6427 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6428
c59da222
CY
64292011-03-22 Chong Yidong <cyd@stupidchicken.com>
6430
6431 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6432 not to be necessary, and produces flickering.
6433
66b87493
GM
64342011-03-20 Glenn Morris <rgm@gnu.org>
6435
6436 * config.in: Remove file.
6437
45b6f6d5
JB
64382011-03-20 Juanma Barranquero <lekktu@gmail.com>
6439
6440 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6441 are now in src/globals.h.
6442 (syms_of_minibuf): Remove spurious & from previous change.
6443
3ec03f7e
LL
64442011-03-20 Leo <sdl.web@gmail.com>
6445
6446 * minibuf.c (completing-read-function): New variable.
6447 (completing-read-default): Rename from completing-read.
6448 (completing-read): Call completing-read-function.
6449
b14e3e21
CY
64502011-03-19 Juanma Barranquero <lekktu@gmail.com>
6451
6452 * xfaces.c (Fx_load_color_file):
6453 Read color file from absolute filename (bug#8250).
6454
f2b726e6
JB
64552011-03-19 Juanma Barranquero <lekktu@gmail.com>
6456
6457 * makefile.w32-in: Update dependencies.
6458
09f6ff02
EZ
64592011-03-17 Eli Zaretskii <eliz@gnu.org>
6460
6461 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6462
29a6015a
PE
64632011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6464
a3a6c54e
PE
6465 Fix more problems found by GCC 4.5.2's static checks.
6466
b766f867
PE
6467 * process.c (make_serial_process_unwind, send_process_trap):
6468 (sigchld_handler): Now static.
6469
be02381c
PE
6470 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6471 That way, the code declares only the vars that it needs.
6472 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6473 * s/cygwin.h (PTY_ITERATION): Likewise.
6474 * s/darwin.h (PTY_ITERATION): Likewise.
6475 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6476
57048744
PE
6477 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6478 * process.c (allocate_pty): Don't declare stb unless it's needed.
6479
7914961c 6480 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6481 (CONSTANTLIM): Remove; unused.
6482 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6483 Define only if needed.
7914961c 6484
b3967b18
PE
6485 * unexelf.c (unexec): Name an expression,
6486 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6487 Use a different way to cause a compilation error if anyone uses
6488 n rather than nn, a way that does not involve shadowing.
73366a00 6489 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6490
29a6015a
PE
6491 * deps.mk (unexalpha.o): Remove; unused.
6492
43cfc33e 6493 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6494 * unexec.h: New file.
ce701a33
PE
6495 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6496 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6497 Depend on unexec.h.
6498 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6499 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6500 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6501 Change as necessary to match prototype in unexec.h.
ce701a33 6502
01f44d5a
PE
6503 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6504 shadowing.
4f63c6bb 6505 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6506
a6670b0b
PE
6507 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6508 Rename locals to avoid shadowing.
6509
cef2010d 6510 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6511 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6512
d4d7173a
PE
6513 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6514
f08b802a
PE
6515 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6516 warning when compiling print.c.
6517
3ddb0639
PE
6518 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6519 instead of using an uninitialized var.
5ad03b97 6520 (font_sort_entities): Mark var as initialized.
3ddb0639 6521
170a2692
PE
6522 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6523
e663c700
PE
6524 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6525 pointers to constants.
89bc529a 6526 (font_parse_fcname): Remove unused vars.
7b81e2d0 6527 (font_delete_unmatched): Now static.
ea838e10 6528 (font_get_spec): Remove; unused.
13a547c6
PE
6529 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6530 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6531 Rename or move locals to avoid shadowing.
e663c700 6532
2a80c887 6533 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6534 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6535
1384fa33 6536 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6537 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6538
8b2c52e9
PE
6539 * alloc.c (mark_backtrace): Move decl from here ...
6540 * lisp.h: ... to here, so that it can be checked.
6541
475545b5 6542 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6543 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6544 (lisp_indirect_variable): Name an expression,
6545 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6546 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6547
b1349114 6548 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6549 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6550 Use const pointer when appropriate.
b1349114 6551
a2928364
PE
6552 * lisp.h (get_system_name, get_operating_system_release):
6553 Move decls here, to check interfaces.
6554 * process.c (get_operating_system_release): Move decl to lisp.h.
6555 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6556 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6557 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6558 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6559 (Fformat_time_string, Fencode_time, Finsert_char):
6560 (Ftranslate_region_internal, Fformat):
6561 Rename or remove local vars to avoid shadowing.
9710023e 6562 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6563
a415e694
PE
6564 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6565 avoid shadowing.
6566
8ef4622d
PE
6567 * lisp.h (eassert): Check that the argument compiles, even if
6568 ENABLE_CHECKING is not defined.
6569
946f9a5b
PE
6570 * data.c (Findirect_variable): Name an expression, to avoid
6571 gcc -Wbad-function-cast warning.
112396d6 6572 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6573 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6574 (Fmake_variable_buffer_local, Fmake_local_variable):
6575 Mark variables as initialized.
52746918 6576 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6577
e5aab7e7 6578 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6579 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6580 Rename locals to avoid shadowing.
dff45157
PE
6581 (mark_stack): Move local variables into the #ifdef region where
6582 they're used.
7bc26fdb
PE
6583 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6584 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6585 needed otherwise.
6586 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6587 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6588 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6589
e5aab7e7
PE
6590 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6591 avoids undefined behavior in theory.
6592
4da60324
PE
6593 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6594
88043301
PE
6595 Use functions, not macros, for up- and down-casing (Bug#8254).
6596 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6597 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6598 to use the following functions instead of these macros.
6599 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6600 EMACS_INT, since callers assume the returned value fits in int.
6601 (upcase1): Likewise, for UPCASE_TABLE.
6602 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6603 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6604 the race-condition problem in the old DOWNCASE.
88043301 6605
19ed5445
PE
6606 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6607 Rename locals to avoid shadowing.
6608 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6609 (regex_compile, re_search_2, re_match_2_internal):
6610 Remove unused local vars.
952db0d7
PE
6611 (FREE_VAR): Rewrite so as not to use empty "else",
6612 which gcc can warn about.
da053e48 6613 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6614 (RETALLOC_IF): Define only if needed.
6615 (WORDCHAR_P): Likewise. This one is never needed, but is used
6616 only in a comment talking about a compiler bug, so put inside
6617 the #if 0 of that comment.
6618 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6619 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6620 Remove; unused.
19ed5445 6621
1f3561e4 6622 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6623 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6624 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6625
ded6f8f7
PE
6626 * search.c (simple_search): Remove unused var.
6627
dbd37a95
PE
6628 * dired.c (compile_pattern): Move decl from here ...
6629 * lisp.h: ... to here, so that it can be checked.
6630 (struct re_registers): New forward decl.
6631
7e47afad
PE
6632 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6633
85f24f61
PE
6634 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6635 All uses changed.
6636 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6637 Rename locals to avoid shadowing.
5671df8f 6638 (Fvertical_motion): Mark locals as initialized.
85f24f61 6639
181aa2be 6640 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6641 (casify_region): Mark local as initialized.
181aa2be 6642
930d429c
PE
6643 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6644
7082eac6
PE
6645 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6646 New macros, so that the caller can use some names other than
6647 gcpro1, gcpro2, etc.
6648 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6649 of the new macros.
6650 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6651 argument, for consistency with GCPRO2_VAR, etc: it is now the
6652 prefix of the variable, not the variable itself. All uses
6653 changed.
38b2c076
PE
6654 * dired.c (directory_files_internal, file_name_completion):
6655 Rename locals to avoid shadowing.
6656
15206ed9
PE
6657 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6658 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6659 dired.c's scmp function, had undefined behavior.
6660 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6661 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6662 * buffer.h: ... to here, because these macros use current_buffer,
6663 and the new implementation with inline functions needs to have
6664 current_buffer in scope now, rather than later when the macros
6665 are used.
6666 (downcase, upcase1): New static inline functions.
6667 (DOWNCASE, UPCASE1): Reimplement using these functions.
6668 This avoids undefined behavior in expressions like
6669 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6670 from race conditions in accessing the global variables
6671 case_temp1 and case_temp2.
6672 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6673 * lisp.h (case_temp1, case_temp2): Remove their decls.
6674 * character.h (ASCII_CHAR_P): Move from here ...
6675 * lisp.h: ... to here, so that the inline functions mentioned
6676 above can use them.
6677
4a6bea26
PE
6678 * dired.c (directory_files_internal_unwind): Now static.
6679
f14b7e14
PE
6680 * fileio.c (file_name_as_directory, directory_file_name):
6681 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6682 Now static.
2893f146
PE
6683 (file_name_as_directory): Use const pointers when appropriate.
6684 (Fexpand_file_name): Likewise. In particular, newdir might
6685 point at constant storage, so make it a const pointer.
fd4ead52 6686 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6687 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6688 signedness issues.
f839df0c
PE
6689 (Fset_file_times, Finsert_file_contents, auto_save_error):
6690 Rename locals to avoid shadowing.
f14b7e14 6691
5716756e 6692 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6693 (Ftry_completion, Fall_completions): Rename or remove locals
6694 to avoid shadowing.
5716756e 6695
b4c3046a
PE
6696 * marker.c (bytepos_to_charpos): Remove; unused.
6697
b45db522
PE
6698 * lisp.h (verify_bytepos, count_markers): New decls,
6699 so that gcc does not warn that these functions aren't declared.
6700
85876d07
PE
6701 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6702 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6703 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6704 (copy_text): Remove unused local var.
85876d07 6705
03d78a21 6706 * filelock.c (within_one_second): Now static.
b3dd38ab 6707 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6708
5df8f01b
PE
6709 * buffer.c (fix_overlays_before): Mark locals as initialized.
6710 (fix_start_end_in_overlays): Likewise. This function should be
6711 simplified by using pointers-to-pointers, but that's a different
6712 matter.
b1d876f1 6713 (switch_to_buffer_1): Now static.
8f54f30a
PE
6714 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6715 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6716
a70072c9 6717 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6718 Fix pointer signedness issue.
edced198
PE
6719 (sys_subshell): Mark local as volatile if checking for lint,
6720 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6721 (MAXPATHLEN): Define only if needed.
a70072c9 6722
a0977c44
PE
6723 * process.c (serial_open, serial_configure): Move decls from here ...
6724 * systty.h: ... to here, so that they can be checked.
6725
a884fdcc
PE
6726 * fns.c (get_random, seed_random): Move extern decls from here ...
6727 * lisp.h: ... to here, so that they can be checked.
6728
604efe86 6729 * sysdep.c (reset_io): Now static.
b8950c94 6730 (wait_for_termination_signal): Remove; unused.
604efe86 6731
38fc62d9
PE
6732 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6733 (copy_keymap_item, append_key, push_text_char_description):
6734 Now static.
1004a21a 6735 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6736 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6737 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6738 (describe_map_tree):
6739 Rename locals to avoid shadowing.
38fc62d9 6740
2f2650da
PE
6741 * keyboard.c: Declare functions static if they are not used elsewhere.
6742 (echo_char, echo_dash, cmd_error, top_level_2):
6743 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6744 (read_char, kbd_buffer_get_event, make_lispy_position):
6745 (make_lispy_event, make_lispy_movement, apply_modifiers):
6746 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6747 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6748 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6749 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6750 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6751
a053e86c 6752 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6753 (mark_kboards): Move decl here ...
6754 * alloc.c (mark_kboards): ... from here.
a053e86c 6755
4752793e
PE
6756 * lisp.h (force_auto_save_soon): New decl.
6757
74f10ca7 6758 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6759 (DEFINE_DUMMY_FUNCTION): New macro.
6760 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6761 Use it.
c03cd23f
PE
6762 (main): Add casts to avoid warnings
6763 if GCC considers string literals to be constants.
74f10ca7 6764
022e70d4
PE
6765 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6766
59d6fe83
PE
6767 * dbusbind.c: Pointer signedness fixes.
6768 (xd_signature, xd_append_arg, xd_initialize):
6769 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6770 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6771 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6772 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6773
78320123
PE
6774 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6775 if GCC considers string literals to be constants.
49cebcca 6776 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6777
35ac2a97
SM
67782011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6779
fb103ca9
SM
6780 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6781 (print_preprocess, print_object): New macro to fix last change.
6782
35ac2a97
SM
6783 * print.c (print_preprocess): Don't forget font objects.
6784
62973b41
JB
67852011-03-16 Juanma Barranquero <lekktu@gmail.com>
6786
6787 * emacs.c (USAGE3): Doc fixes.
6788
0e48bb22
AS
67892011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6790
6791 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6792 structure.
6793
7684e57b
JB
67942011-03-14 Juanma Barranquero <lekktu@gmail.com>
6795
6796 * lisp.h (VWindow_system, Qfile_name_history):
6797 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6798 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6799 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6800
6801 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6802 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6803
6804 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6805 * w32console.c (detect_input_pending, read_input_pending)
6806 (encode_terminal_code):
6807 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6808 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6809 (w32_system_caret_y, Qfile_name_history):
6810 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6811 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6812 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6813 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6814 * w32proc.c (Qlocal, report_file_error):
6815 * w32term.c (Vwindow_system, updating_frame):
6816 * w32uniscribe.c (initialized, uniscribe_font_driver):
6817 Remove unneeded extern declarations.
6818
2aa46d6c
CY
68192011-03-14 Chong Yidong <cyd@stupidchicken.com>
6820
c96bbc66 6821 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6822
cffc6f3b
CY
68232011-03-13 Chong Yidong <cyd@stupidchicken.com>
6824
6825 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6826 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6827 These macros can no longer be used for assignment.
6828
44f230aa
SM
6829 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6830 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6831 (record_buffer_markers, fetch_buffer_markers): New functions for
6832 recording and fetching special buffer markers.
6833 (set_buffer_internal_1, set_buffer_temp): Use them.
6834
6835 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6836
6837 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6838
6839 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6840 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6841
6842 * xdisp.c (hscroll_window_tree):
6843 (reconsider_clip_changes): Use PT instead of BUF_PT.
6844
d251f04b
EZ
68452011-03-13 Eli Zaretskii <eliz@gnu.org>
6846
6847 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6848 $(EMACS_ROOT)/lib/intprops.h.
6849
f0c77cd1
PE
68502011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6851
3eca4629
PE
6852 Fix more problems found by GCC 4.5.2's static checks.
6853
7c86ee98
PE
6854 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6855 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6856 (xg_free_frame_widgets): Make it clear that a local variable is
6857 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6858 (gdk_window_get_screen): Make it clear that this macro is needed
6859 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6860 (int_gtk_range_get_value): New function, which avoids a diagnostic
6861 from gcc -Wbad-function-cast.
6862 (xg_set_toolkit_scroll_bar_thumb): Use it.
6863 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6864 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6865 (get_utf8_string, xg_get_file_with_chooser):
6866 Rename locals to avoid shadowing.
6867 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6868
41729b81
PE
6869 * xgselect.c (xg_select): Remove unused var.
6870
f0c77cd1
PE
6871 * image.c (four_corners_best): Mark locals as initialized.
6872 (gif_load): Initialize transparent_p to zero (Bug#8238).
6873 Mark another local as initialized.
ec6cf4c6 6874 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6875
ce0ad53d 6876 * image.c (clear_image_cache): Now static.
d5d5a617 6877 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6878 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6879 (x_edge_detection): Remove unnecessary cast that
6880 gcc -Wbad-function-cast diagnoses.
2037898d 6881 (gif_load): Fix pointer signedness.
6ae141d6
PE
6882 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6883 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6884
33383987 68852011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6886
d32df629
PE
6887 Improve quality of tests for time stamp overflow.
6888 For example, without this patch (encode-time 0 0 0 1 1
6889 1152921504606846976) returns the obviously-bogus value (-948597
6890 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6891 reports time overflow. See
6892 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6893 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6894 * editfns.c: Include limits.h and intprops.h.
6895 (TIME_T_MIN, TIME_T_MAX): New macros.
6896 (time_overflow): Move earlier, to before first use.
6897 (hi_time, lo_time): New functions, for an accurate test for
6898 out-of-range times.
6899 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6900 (Fget_internal_run_time): Don't assume time_t fits in int.
6901 (make_time): Use list2 instead of Fcons twice.
6902 (Fdecode_time): More accurate test for out-of-range times.
6903 (check_tm_member): New function.
6904 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6905 (lisp_time_argument): Don't rely on undefined left-shift and
6906 right-shift behavior when checking for time stamp overflow.
8be6f318 6907
fe31d94c
PE
6908 * editfns.c (time_overflow): New function, refactoring common code.
6909 (Fformat_time_string, Fdecode_time, Fencode_time):
6910 (Fcurrent_time_string): Use it.
6911
8be6f318
PE
6912 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6913 * dired.c (make_time): Move to ...
6914 * editfns.c (make_time): ... here.
6915 * systime.h: Note the move.
6916
09d9db2c 69172011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6918
126bc0dc
YM
6919 * fringe.c (update_window_fringes): Remove unused variables.
6920
c47cbdfd
YM
6921 * unexmacosx.c (copy_data_segment): Also copy __got section.
6922 (Bug#8223)
6923
7ac80be9
EZ
69242011-03-12 Eli Zaretskii <eliz@gnu.org>
6925
c96bbc66 6926 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6927 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6928 Constify `char *' arguments and their references according to
6929 prototypes in tparam.h.
6930
ecb0f94d 6931 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6932
7ac80be9
EZ
6933 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6934 Adapt all references accordingly.
6935
6936 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6937
ef1fd07e
TT
69382011-03-11 Tom Tromey <tromey@redhat.com>
6939
6940 * buffer.c (syms_of_buffer): Remove obsolete comment.
6941
7ef4b50c
EZ
69422011-03-11 Eli Zaretskii <eliz@gnu.org>
6943
6944 * termhooks.h (encode_terminal_code): Declare prototype.
6945
6946 * msdos.c (encode_terminal_code): Don't declare prototype.
6947
6948 * term.c (encode_terminal_code): Now external again, used by
6949 w32console.c and msdos.c.
6950
44f230aa
SM
6951 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6952 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6953
4b1ec863 69542011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6955
1714f52b 6956 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6957
4b1ec863
PE
6958 * fringe.c (update_window_fringes): Mark locals as initialized
6959 (Bug#8227).
6960 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6961
524c7aa6
PE
6962 * alloc.c (mark_fringe_data): Move decl from here ...
6963 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6964 to check its interface.
6965 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6966
a5c0af81 6967 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6968 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6969 (fontset_font): Mark local as initialized.
a9a06e0b 6970 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6971
b4716021
PE
6972 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6973
811e9bac 6974 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6975 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6976 (x_own_selection, Fx_disown_selection_internal): Rename locals
6977 to avoid shadowing.
6978 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6979
7e3ab302
PE
6980 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6981 so that the caller can use some name other than gcpro1.
6982 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6983 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6984 (Fx_backspace_delete_keys_p):
6985 Use them to avoid shadowing, and rename vars to avoid shadowing.
6986 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6987 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6988 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6989 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6990 Remove unused locals.
7e3ab302
PE
6991 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6992 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6993 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6994 macros.
f78faa98 6995
e2b13473
PE
6996 * xterm.h (x_mouse_leave): New decl.
6997
77f23912
PE
6998 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6999 Remove unused functions.
cdf4ba58
PE
7000 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7001 (x_calc_absolute_position): Now static.
7411c686 7002 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7003 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7004 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7005 unless they are used.
38d0b34a
PE
7006 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7007 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7008 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7009 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7010 (x_error_catcher, x_connection_closed, x_error_handler):
7011 (x_error_quitter, xembed_send_message, x_iconify_frame):
7012 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7013 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7014 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7015
44f230aa
SM
7016 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7017 Rename or move locals to avoid shadowing.
6b463e58 7018 (tty_defined_color, merge_face_heights): Now static.
5967d051 7019 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7020 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7021 does not deduce is never used uninitialized.
73719eba
PE
7022 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7023 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7024
426994c3 7025 * terminal.c (store_terminal_param): Now static.
5489860b 7026
032f1620 7027 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7028 (set_frame_menubar): Remove unused local.
d4323972 7029 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7030 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7031 since they might point to immutable storage.
281585b0
PE
7032 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7033 since it's unused otherwise.
032f1620 7034
367c19e5 7035 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7036 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7037 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7038 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7039 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7040 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7041 does not deduce are never used uninitialized.
70739cbe 7042
07b48fa9
PE
7043 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7044
8868a238 7045 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7046 * window.c (window_loop, size_window):
7047 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7048
7e5cf297 7049 * window.c (display_buffer): Now static.
d6550a9f
PE
7050 (size_window): Mark variables that gcc -Wuninitialized
7051 does not deduce are never used uninitialized.
a586633d
PE
7052 * window.h (check_all_windows): New decl, to forestall
7053 gcc -Wmissing-prototypes diagnostic.
5b555da1 7054 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7055
f6095868
PE
7056 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7057 shadowing.
7058 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7059 Include <limits.h>.
7060 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7061 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7062 (load_charset_map): Mark variables that gcc -Wuninitialized
7063 does not deduce are never used uninitialized.
53df7c11 7064 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7065
f38b440c
PE
7066 * coding.c (coding_set_source, coding_set_destination):
7067 Use "else { /* comment */ }" rather than "else /* comment */;"
7068 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7069 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7070 a block, when the outer 'i' will do.
7071 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7072 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7073 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7074 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7075 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7076 Rename locals to avoid shadowing.
7077 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7078 * coding.c (emacs_mule_char, encode_invocation_designation):
7079 Now static, since they're not used elsewhere.
413bb2db 7080 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7081 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7082 (decode_coding_emacs_mule): Mark variables that gcc
7083 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7084 (detect_coding_iso_2022): Initialize a local variable that might
7085 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7086 this initialization is needed. (Bug#8211)
5f58e762
PE
7087 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7088 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7089 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7090 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7091 Remove unused macros.
f38b440c 7092
232b38b9 7093 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7094 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7095 * character.c (string_count_byte8): Likewise.
232b38b9 7096
fb90da1b
PE
7097 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7098 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7099
fb93dbc2
PE
7100 * chartab.c (copy_sub_char_table): Now static, since it's not used
7101 elsewhere.
5c156ace
PE
7102 (sub_char_table_ref_and_range, char_table_ref_and_range):
7103 Rename locals to avoid shadowing.
bbcd0949 7104 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7105
7d3b3862 7106 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7107 (BIDI_BOB): Remove unused macro.
7d3b3862 7108
6be7d3da
PE
7109 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7110 deduce are never used uninitialized.
c2ed9c8b 7111 * term.c (encode_terminal_code): Likewise.
6be7d3da 7112
75f8807f 7113 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7114
50938595
PE
7115 * tparam.h: New file.
7116 * term.c, tparam.h: Include it.
7117 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7118 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7119 Move these decls to tparam.h, and make them agree with what
7120 is actually in tparam.c. The previous trick of using incompatible
7121 decls in different modules does not conform to the C standard.
7122 All callers of tparam changed to use tparam's actual API.
7123 * tparam.c (tparam1, tparam, tgoto):
7124 Use const pointers where appropriate.
7125
fbceeba2
PE
7126 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7127 * cm.h (struct cm): Likewise.
7128 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7129 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7130 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7131 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7132 (turn_on_face, init_tty): Likewise.
7133 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7134
7f3f1250
PE
7135 * term.c (term_mouse_position): Rename local to avoid shadowing.
7136
e6ca6543
PE
7137 * alloc.c (mark_ttys): Move decl from here ...
7138 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7139
c40f8d15
AS
71402011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7141
7142 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7143
cfe0661d
JB
71442011-03-09 Juanma Barranquero <lekktu@gmail.com>
7145
7146 * search.c (compile_pattern_1): Remove argument regp, unused since
7147 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7148 (compile_pattern): Don't pass it.
7149
0afb4571
J
71502011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7151
7152 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7153 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7154 for ! HAVE_GTK3.
7155 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7156
7157 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7158
7159 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7160 gdk_window_get_screen, gdk_window_get_geometry,
7161 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7162 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7163 (xg_get_pixbuf_from_pixmap): New function.
7164 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7165 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7166 Call xg_get_pixbuf_from_pixmap instead of
7167 gdk_pixbuf_get_from_drawable.
7168 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7169 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7170 (xg_check_special_colors): Use GtkStyleContext and its functions
7171 for HAVE_GTK3.
7172 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7173 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7174 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7175 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7176 Call gtk_widget_get_preferred_size.
0afb4571
J
7177 (xg_frame_resized): gdk_window_get_geometry only takes 5
7178 parameters.
44f230aa
SM
7179 (xg_win_to_widget, xg_event_is_for_menubar):
7180 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7181 (xg_set_widget_bg): New function.
7182 (delete_cb): New function.
895009e1 7183 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7184 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7185 (xg_set_background_color): Call xg_set_widget_bg.
7186 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7187 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7188 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7189 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7190 if ! HAVE_GTK3.
7191 (update_frame_tool_bar): Call gtk_widget_hide.
7192 (xg_initialize): Use GDK_KEY_g.
7193
7194 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7195 if ! HAVE_GTK3
7196 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7197
7198 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7199 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7200 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7201
1c2cc4ef
JB
72022011-03-08 Juanma Barranquero <lekktu@gmail.com>
7203
7204 * w32xfns.c (select_palette): Check success of RealizePalette against
7205 GDI_ERROR, not zero.
7206
33383987 7207See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7208
7209;; Local Variables:
7210;; coding: utf-8
aac0c6e3
MR
7211;; End:
7212
33383987 7213 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7214
7215 This file is part of GNU Emacs.
7216
7217 GNU Emacs is free software: you can redistribute it and/or modify
7218 it under the terms of the GNU General Public License as published by
7219 the Free Software Foundation, either version 3 of the License, or
7220 (at your option) any later version.
7221
7222 GNU Emacs is distributed in the hope that it will be useful,
7223 but WITHOUT ANY WARRANTY; without even the implied warranty of
7224 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7225 GNU General Public License for more details.
7226
7227 You should have received a copy of the GNU General Public License
7228 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.