Followup to not using maybe_unify_char in processing buffers and strings.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
eedec3ee
EZ
12012-09-25 Eli Zaretskii <eliz@gnu.org>
2
3 * coding.c (CHAR_STRING_ADVANCE_NO_UNIFY): Make it an alias of
4 CHAR_STRING_ADVANCE.
5 (STRING_CHAR_ADVANCE_NO_UNIFY): Make it an alias of
6 STRING_CHAR_ADVANCE.
7
aa15c6bb
JB
82012-09-25 Juanma Barranquero <lekktu@gmail.com>
9
10 Move Vlibrary_cache to emacs.c and reset before dumping.
11
12 * lisp.h (reset_image_types): Declare.
13 [WINDOWSNT] (Vlibrary_cache): Declare.
14
15 * image.c (reset_image_types): New function.
16
17 * emacs.c [WINDOWSNT] (Vlibrary_cache): Move from w32.c.
18 (syms_of_emacs) [WINDOWSNT] <Vlibrary_cache>: Initialize and staticpro.
19 (Fdump_emacs): Reset Vlibrary_cache and image_types.
20
21 * w32.c (Vlibrary_cache): Do not define; moved to emacs.c
22 (globals_of_w32) <Vlibrary_cache>: Do not initialize.
23
24 * w32.h (Vlibrary_cache): Do not declare.
25
54d629be
EZ
262012-09-25 Eli Zaretskii <eliz@gnu.org>
27
16b22fef
EZ
28 * w32proc.c (sys_signal): Handle all signals defined by the
29 MS-Windows runtime, not just SIGCHLD. Actually install the signal
30 handlers for signals supported by Windows. Don't override
31 term_ntproc as the handler for SIGABRT.
32 (sigaction): Rewrite to call sys_signal instead of duplicating its
33 code.
34 (sys_kill): Improve commentary.
35
36 * w32.c (term_ntproc): Accept (and ignore) one argument, for
37 consistency with a signature of a signal handler. All callers
38 changed.
39 (init_ntproc): Accept an argument DUMPING. If dumping, don't
40 install term_ntproc as a signal handler for SIGABRT, as that
41 should be done by the dumped Emacs.
42
43 * w32.h (init_ntproc, term_ntproc): Adjust prototypes.
44
45 * w32select.c (term_w32select): Protect against repeated
46 invocation by setting clipboard_owner to NULL after calling
47 DestroyWindow.
48
49 * emacs.c (shut_down_emacs, main): Adapt the calls to init_ntproc
50 and term_ntproc to their modified signatures.
51
54d629be
EZ
52 * character.c (char_string, string_char): Remove calls to
53 MAYBE_UNIFY_CHAR. See the discussion starting at
54 http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00433.html
55 for the details.
56
59f7af81
CY
572012-09-25 Chong Yidong <cyd@gnu.org>
58
59 * xdisp.c (mode_line_inverse_video): Delete obsolete variable.
60
22e8cf4a
SM
612012-09-24 Stefan Monnier <monnier@iro.umontreal.ca>
62
63 * bytecode.c (exec_byte_code): Signal an error instead of aborting,
64 when encountering an unknown bytecode.
65
578098f3
PE
662012-09-24 Paul Eggert <eggert@cs.ucla.edu>
67
68 image.c, indent.c: Use bool for booleans.
69 * dispextern.h (struct image_type): Members valid_p, load, init
70 now return bool, not int. All uses changed.
71 * image.c: Omit unnecessary static decls.
72 (x_create_bitmap_mask, x_build_heuristic_mask):
73 Return void, not int, since callers don't care about the return value.
74 (x_create_bitmap_mask, define_image_type, valid_image_p)
75 (struct image_keyword, parse_image_spec, image_spec_value)
76 (check_image_size, image_background)
77 (image_background_transparent, x_clear_image_1)
78 (postprocess_image, lookup_image, x_check_image_size)
79 (x_create_x_image_and_pixmap, xbm_image_p)
80 (Create_Pixmap_From_Bitmap_Data, xbm_read_bitmap_data)
81 (xbm_load_image, xbm_file_p, xbm_load, xpm_lookup_color)
82 (init_xpm_functions, xpm_valid_color_symbols_p, xpm_image_p)
83 (xpm_load, xpm_load_image, lookup_rgb_color, lookup_pixel_color)
84 (x_to_xcolors, x_build_heuristic_mask, pbm_image_p, pbm_load)
85 (png_image_p, init_png_functions, png_load_body, png_load)
86 (jpeg_image_p, init_jpeg_functions, jpeg_load_body, jpeg_load)
87 (tiff_image_p, init_tiff_functions, tiff_load, gif_image_p)
88 (init_gif_functions, gif_load, imagemagick_image_p)
89 (imagemagick_load_image, imagemagick_load, svg_image_p)
90 (init_svg_functions, svg_load, svg_load_image, gs_image_p)
91 (gs_load):
92 * nsimage.m (ns_load_image):
93 * nsterm.m (ns_defined_color):
94 * xfaces.c (tty_lookup_color, tty_defined_color, defined_color):
95 * xfns.c (x_defined_color):
96 * xterm.c (x_alloc_lighter_color_for_widget)
97 (x_alloc_nearest_color_1, x_alloc_nearest_color)
98 (x_alloc_lighter_color):
99 * indent.c (disptab_matches_widthtab, current_column)
100 (scan_for_column, string_display_width, indented_beyond_p)
101 (compute_motion, vmotion, Fvertical_motion):
102 Use bool for booleans.
103
a5f2b6ec
CY
1042012-09-24 Chong Yidong <cyd@gnu.org>
105
106 * chartab.c (Fset_char_table_default): Obsolete function removed.
107
18e27ea8
PE
1082012-09-23 Paul Eggert <eggert@cs.ucla.edu>
109
afea8a8a
PE
110 Move pid_t related decls out of lisp.h.
111 * lisp.h, syswait.h (record_child_status_change, wait_for_termination)
112 (interruptible_wait_for_termination):
113 Move these decls from lisp.h to syswait.h, since they use pid_t.
114 Needed on FreeBSD; see Herbert J. Skuhra in
115 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00571.html>.
116 * callproc.c: Include syswait.h.
117
18e27ea8
PE
118 gnutls.c, gtkutil.c: Use bool for boolean.
119 * gnutls.c (gnutls_global_initialized, init_gnutls_functions)
120 (emacs_gnutls_handle_error):
121 * gtkutil.c (xg_check_special_colors, xg_prepare_tooltip)
122 (xg_hide_tooltip, xg_create_frame_widgets)
123 (create_dialog, xg_uses_old_file_dialog)
124 (xg_get_file_with_chooser, xg_get_file_with_selection)
125 (xg_get_file_name, xg_have_tear_offs, create_menus, xg_create_widget)
126 (xg_item_label_same_p, xg_update_menubar)
127 (xg_modify_menubar_widgets, xg_event_is_for_menubar)
128 (xg_ignore_gtk_scrollbar, xg_set_toolkit_scroll_bar_thumb)
129 (xg_event_is_for_scrollbar, xg_pack_tool_bar, xg_make_tool_item)
130 (is_box_type, xg_tool_item_stale_p, xg_update_tool_bar_sizes)
131 (update_frame_tool_bar, free_frame_tool_bar):
132 * gtkutil.c, w32term.c, xterm.c (x_wm_set_size_hint):
133 * nsmenu.m (ns_update_menubar):
134 * nsmenu.m, w32menu.c, xmenu.c (set_frame_menubar):
135 * xfns.c (Fx_show_tip) [USE_GTK]:
136 Use bool for boolean.
137 * gtkutil.c (xg_update_frame_menubar):
138 * xmenu.c (update_frame_menubar):
139 Return void, not int, since caller ignores return value.
140 * gtkutil.c (xg_change_toolbar_position):
141 Return void, not 1.
142
af0e9f75
JB
1432012-09-23 Juanma Barranquero <lekktu@gmail.com>
144
145 * makefile.w32-in (BLOCKINPUT_H): Remove.
146 (SYSSIGNAL_H): New macro.
147 ($(BLD)/alloc.$(O), $(BLD)/atimer.$(O), $(BLD)/buffer.$(O))
148 ($(BLD)/callproc.$(O), $(BLD)/data.$(O), $(BLD)/dired.$(O))
149 ($(BLD)/dispnew.$(O), $(BLD)/editfns.$(O), $(BLD)/emacs.$(O))
150 ($(BLD)/eval.$(O), $(BLD)/fileio.$(O), $(BLD)/floatfns.$(O))
151 ($(BLD)/fns.$(O), $(BLD)/fontset.$(O), $(BLD)/frame.$(O))
152 ($(BLD)/fringe.$(O), $(BLD)/image.$(O), $(BLD)/insdel.$(O))
153 ($(BLD)/keyboard.$(O), $(BLD)/keymap.$(O), $(BLD)/lread.$(O))
154 ($(BLD)/menu.$(O), $(BLD)/w32inevt.$(O), $(BLD)/w32proc.$(O))
155 ($(BLD)/print.$(O), $(BLD)/process.$(O), $(BLD)/ralloc.$(O))
156 ($(BLD)/search.$(O), $(BLD)/sound.$(O), $(BLD)/sysdep.$(O))
157 ($(BLD)/term.$(O), $(BLD)/window.$(O), $(BLD)/xdisp.$(O))
158 ($(BLD)/xfaces.$(O), $(BLD)/w32fns.$(O), $(BLD)/w32menu.$(O))
159 ($(BLD)/w32term.$(O), $(BLD)/w32select.$(O), $(BLD)/w32reg.$(O))
160 ($(BLD)/w32xfns.$(O)): Update dependencies.
161
5101529e
EZ
1622012-09-23 Eli Zaretskii <eliz@gnu.org>
163
164 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
165 fatal_error_backtrace.
166
167 * w32proc.c (sys_kill): Undo last change: don't do anything when
168 invoked to deliver SIGABRT to our own process. This is now
169 handled by emacs_raise.
170
2c3ee0ad
JB
1712012-09-23 Juanma Barranquero <lekktu@gmail.com>
172
173 * w32term.c (w32_read_socket): Remove leftover reference to
174 interrupt_input_pending.
175
62a1d661
PE
1762012-09-23 Paul Eggert <eggert@cs.ucla.edu>
177
178 Do not use SA_NODEFER.
179 Problem reported by Dani Moncayo in
180 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
181 * alloc.c (die):
182 * sysdep.c (emacs_abort): Do not reset signal handler.
183 * emacs.c (terminate_due_to_signal): Reset signal handler here.
184 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
185 wanted even on POSIXish hosts, and it doesn't work on Windows.
186
a0942b9a
JD
1872012-09-23 Jan Djärv <jan.h.d@swipnet.se>
188
189 * xterm.c (x_term_init): Call fixup_locale before and after calling
190 gtk_init (Bug#12392).
191
d07ff9db
CY
1922012-09-23 Chong Yidong <cyd@gnu.org>
193
194 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
195 Vdynamic_library_alist.
196
197 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
198 (Fgnutls_available_p): Caller changed.
199
200 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
201 (Flibxml_parse_xml_region): Likewise.
202
203 * dispextern.h (struct image_type): Remove arg from init function.
204
205 * image.c (Finit_image_library, lookup_image_type)
206 (define_image_type): Remove now-unneeded second arg.
207 (init_xpm_functions, init_png_functions, init_jpeg_functions)
208 (init_tiff_functions, init_gif_functions, init_svg_functions):
209 Arglist and w32_delayed_load calling convention changed.
210 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 211 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 212
4d7e6e51
PE
2132012-09-23 Paul Eggert <eggert@cs.ucla.edu>
214
215 Simplify and avoid signal-handling races (Bug#12471).
216 * alloc.c (die):
217 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
218 Avoid recursive loop if there's a fatal error in the function itself.
219 * atimer.c (pending_atimers):
220 * blockinput.h: Don't include "atimer.h"; no longer needed.
221 (interrupt_input_pending): Remove. All uses removed.
222 pending_signals now counts both atimers and ordinary interrupts.
223 This is less racy than having three separate pending-signal flags.
224 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
225 (input_blocked_p):
226 Rename from their upper-case counterparts BLOCK_INPUT,
227 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
228 INPUT_BLOCKED_P, and turn into functions. All uses changed.
229 This makes it easier to access volatile variables more accurately.
230 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
231 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
232 that's more reliable if the code is buggy and sets
233 interrupt_input_blocked to a negative value. All uses changed.
234 * atimer.c (deliver_alarm_signal):
235 Remove. No need to deliver this to the parent; any thread can
236 handle this signal now. All uses replaced by underlying handler.
237 * atimer.c (turn_on_atimers):
238 * dispnew.c (handle_window_change_signal):
239 * emacs.c (handle_danger_signal):
240 * keyboard.c (kbd_buffer_get_event):
241 Don't reestablish signal handler; not needed with sigaction.
242 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
243 (UNBLOCK_INPUT_TO):
244 Rework to avoid unnecessary accesses to volatile variables.
245 (UNBLOCK_INPUT_TO): Now a function.
246 (totally_unblock_input, unblock_input): New decls.
247 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
248 (init_data): Remove. Necessary stuff now done in init_signal.
249 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
250 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
251 (fatal_error_code): Remove; no longer needed.
252 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
253 it doesn't always backtrace. All uses changed. No need to reset
254 signal to default, since sigaction and/or die does that for us now.
255 Use emacs_raise (FOO), not kill (getpid (), FOO).
256 (main): Check more-accurately whether we're dumping.
257 Move fatal-error setup to sysdep.c
258 * floatfns.c: Do not include "syssignal.h"; no longer needed.
259 * gtkutil.c (xg_get_file_name, xg_get_font):
260 Remove no-longer-needed signal-mask manipulation.
261 * keyboard.c, process.c (POLL_FOR_INPUT):
262 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
263 * keyboard.c (read_avail_input): Remove.
264 All uses replaced by gobble_input.
265 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
266 (kbd_buffer_store_event_hold, gobble_input):
267 (record_asynch_buffer_change) [USABLE_SIGIO]:
268 (store_user_signal_events):
269 No need to mess with signal mask.
270 (gobble_input): If blocking input and there are terminals, simply
271 set pending_signals to 1 and return. All hooks changed to not
272 worry about whether input is blocked.
273 (process_pending_signals): Clear pending_signals before processing
274 them, in case a signal comes in while we're processing.
275 By convention callers now test pending_signals before calling us.
276 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
277 New functions, to support changes to blockinput.h.
278 (handle_input_available_signal): Now extern.
279 (reinvoke_input_signal): Remove. All uses replaced by
280 handle_async_input.
281 (quit_count): Now volatile, since a signal handler uses it.
282 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg. All
283 callers changed. Block SIGINT only if not already blocked.
284 Clear sigmask reliably, even if Fsignal returns, which it can.
285 Omit unnecessary accesses to volatile var.
286 (quit_throw_to_read_char): No need to restore sigmask.
287 * keyboard.c (gobble_input, handle_user_signal):
288 * process.c (wait_reading_process_output):
289 Call signal-handling code rather than killing ourselves.
290 * lisp.h: Include <float.h>, for...
291 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
292 (pending_signals): Now volatile.
293 (syms_of_data): Now const if IEEE floating point.
294 (handle_input_available_signal) [USABLE_SIGIO]:
295 (terminate_due_to_signal, record_child_status_change): New decls.
296 * process.c (create_process): Avoid disaster if memory is exhausted
297 while we're processing a vfork, by tightening the critical section
298 around the vfork.
299 (send_process_frame, process_sent_to, handle_pipe_signal)
300 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
301 ignores SIGPIPE.
302 (send_process): No need for setjmp/longjmp any more, since the
303 SIGPIPE stuff is now gone. Instead, report an error if errno
304 is EPIPE.
305 (record_child_status_change): Now extern. PID and W are now args.
306 Return void, not bool. All callers changed.
307 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
308 Remove. All uses removed. This bug should be fixed now in a
309 different way.
310 (wait_for_termination_1): Use waitpid rather than sigsuspend,
311 and record the child status change directly. This avoids the
312 need to futz with the signal mask.
313 (process_fatal_action): Move here from emacs.c.
314 (emacs_sigaction_flags): New function, containing
315 much of what used to be in emacs_sigaction_init.
316 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
317 caught by emacs, to make races less likely.
318 (deliver_process_signal): Rename from handle_on_main_thread.
319 All uses changed.
320 (BACKTRACE_LIMIT_MAX): Now at top level.
321 (thread_backtrace_buffer, threadback_backtrace_pointers):
322 New static vars.
323 (deliver_thread_signal, deliver_fatal_thread_signal):
324 New functions, for more-accurate delivery of thread-specific signals.
325 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
326 (deliver_arith_signal): Handle in this thread, not
327 in the main thread, since it's triggered by this thread.
328 (maybe_fatal_sig): New function.
329 (init_signals): New arg DUMPING so that we can be more accurate
330 about whether we're dumping. Caller changed.
331 Treat thread-specific signals differently from process-general signals.
332 Block all signals while handling fatal error; that's safer.
333 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
334 on IEEE hosts.
335 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
336 Ignore SIGPIPE unless batch.
337 (emacs_backtrace): Output backtrace for the appropriate thread,
338 which is not necessarily the main thread.
339 * syssignal.h: Include <stdbool.h>.
340 (emacs_raise): New macro.
341 * xterm.c (x_connection_signal): Remove; no longer needed
342 now that we use sigaction.
343 (x_connection_closed): No need to mess with sigmask now.
344 (x_initialize): No need to reset SIGPIPE handler here, since
345 init_signals does this for us now.
346
8f4635e9
JD
3472012-09-23 Jan Djärv <jan.h.d@swipnet.se>
348
349 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
350 background rect may be larger (Bug#12445).
351
3296976d
CY
3522012-09-23 Chong Yidong <cyd@gnu.org>
353
354 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
355
d41e491e
PE
3562012-09-22 Paul Eggert <eggert@cs.ucla.edu>
357
358 * .gdbinit: Just stop at fatal_error_backtrace.
359 See Stefan Monnier's request in
360 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
361 Remove no-longer-used query of system type.
362
c88b867f
CY
3632012-09-22 Chong Yidong <cyd@gnu.org>
364
365 * search.c (Freplace_match): Doc fix (Bug#12325).
366
367 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
368
369 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
370 (Fline_end_position): Doc fix.
371
372 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
373
bb4d86b4
CY
3742012-09-22 Chong Yidong <cyd@gnu.org>
375
376 * dispextern.h (struct image_type): Add new slot, storing a type
377 initialization function.
378
379 * image.c (define_image_type): Call the image initializer function
380 if it is defined. Arguments and return value changed.
381 (valid_image_p, make_image): Callers changed.
382 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
383 (gif_type, imagemagick_type, svg_type, gs_type): Add
384 initialization functions.
385 (Finit_image_library): Call lookup_image_type.
386 (CHECK_LIB_AVAILABLE): Macro deleted.
387 (lookup_image_type): Call define_image_type here, rather than via
388 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
389 (syms_of_image): Move define_image_type calls for xbm_type and
390 pbm_type to lookup_image_type.
391
df9685f3
EZ
3922012-09-22 Eli Zaretskii <eliz@gnu.org>
393
394 * keyboard.c (timer_check_2): Move calculation of 'timers' and
395 'idle_timers' from here ...
396 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
397 lists, to avoid infloops when the timer does something stupid,
398 like reinvoke itself with the same or smaller time-out.
399 (Bug#12447)
400
8e17c9ba
MR
4012012-09-22 Martin Rudalics <rudalics@gmx.at>
402
403 * window.c (Fsplit_window_internal): Handle only Qt value of
404 Vwindow_combination_limit separately.
405 (Qtemp_buffer_resize): New symbol.
406 (Vwindow_combination_limit): New default value. Rewrite
407 doc-string.
408
589bd69b
EZ
4092012-09-22 Eli Zaretskii <eliz@gnu.org>
410
411 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
412 the new overlay string. (Bug#10159)
413
01108e3f
PE
4142012-09-22 Paul Eggert <eggert@cs.ucla.edu>
415
416 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
417 or that fprintf is async-signal-safe. POSIX doesn't require
418 either assumption.
419
82f8cd94
CY
4202012-09-22 Chong Yidong <cyd@gnu.org>
421
422 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
423 (Bug#8207).
424
3cccbd87
KH
4252012-09-22 Kenichi Handa <handa@gnu.org>
426
427 * composite.c (composition_reseat_it): Handle the case that a
428 grapheme cluster is not covered by a single font (Bug#12352).
429
09c01941
CY
4302012-09-21 Chong Yidong <cyd@gnu.org>
431
432 * image.c (define_image_type): Avoid adding duplicate types to
433 image_types (Bug#12463). Suggested by Jörg Walter.
434
acfa068f 4352012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
436
437 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
438 (print_load_command_name): Add case LC_DATA_IN_CODE.
439 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
440
acfa068f 4412012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
442
443 * eval.c (Frun_hook_with_args_until_success)
444 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
445
acfa068f 4462012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
447
448 * fileio.c (Ffile_selinux_context): Only call freecon when
449 lgetfilecon succeeded.
450 (Fset_file_selinux_context): Likewise. (Bug#12444)
451
acfa068f 4522012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
453
454 * xdisp.c (try_window_reusing_current_matrix): Under bidi
455 reordering, locate the cursor by calling set_cursor_from_row; if
456 that fails, clear the desired glyph matrix before returning a
457 failure indication to the caller. Fixes leaving garbled display
458 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
459 (compute_stop_pos_backwards): Fix a typo that caused crashes while
460 scrolling through multibyte text.
aa36e4d2 461
e99f70c8
SM
4622012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
463
464 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
465 calling mark_vectorlike since that's the one that marks the window.
466 (mark_discard_killed_buffers): Mark the final cdr.
467 * window.h (struct window): Move prev/next_buffers to the
468 non-standard fields.
469 * window.c (make_window): Initialize prev/next_buffers manually.
470
f75beb47
PE
4712012-09-20 Paul Eggert <eggert@cs.ucla.edu>
472
473 Omit unused arg EXPECTED from socket hooks.
474 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
475 * nsterm.m (ns_term_init):
476 * termhooks.h (struct terminal.read_socket_hook):
477 * w32inevt.c (w32_console_read_socket):
478 * w32term.c (w32_read_socket):
479 * xterm.c (XTread_socket):
480 Omit unused arg EXPECTED. All callers changed.
481 (store_user_signal_events): Return void, not int, since callers no
482 longer care about the return value. All uses changed.
483
b019b76a
JB
4842012-09-20 Juanma Barranquero <lekktu@gmail.com>
485
486 * w32gui.h (XParseGeometry): Do not declare.
487
05642592
PE
4882012-09-19 Paul Eggert <eggert@cs.ucla.edu>
489
e4bce92a
PE
490 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
491 Ignore 'expected'. See Eli Zaretskii in
492 <http://bugs.gnu.org/12471#8> (last line).
493
05642592
PE
494 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
495 (XParseGeometry): Now static. Substitute extremal values for
496 values that are out of range.
497
e543ae91
JD
4982012-09-19 Jan Djärv <jan.h.d@swipnet.se>
499
500 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
501
502 * nsfns.m (XParseGeometry): Remove.
503 (Fx_create_frame): Call x_set_offset to correctly interpret
504 top_pos in geometry.
505
506 * frame.c (read_integer, XParseGeometry): Moved from w32xfns.c.
507 (Fx_parse_geometry): If there is a space in string, call
508 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
509
45ba16c7
EZ
5102012-09-17 Eli Zaretskii <eliz@gnu.org>
511
c8b9f1bc
EZ
512 * search.c (scan_buffer): Use character positions in calls to
513 region_cache_forward and region_cache_backward, not byte
514 positions. (Bug#12196)
515
b4c932a2
EZ
516 * w32term.c (w32_read_socket): Set pending_signals to 1, like
517 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
518
45ba16c7
EZ
519 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
520 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
521 emacs_blocked_malloc, now deleted.
522
eeceac93
PE
5232012-09-17 Paul Eggert <eggert@cs.ucla.edu>
524
525 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
526 The workaround was for improving performance on Solaris 2.4, but
527 is getting in the way now. Emacs will still work if someone is
528 still running Solaris 2.4 in a museum somewhere; Sun dropped
529 support for Solaris 2.4 in 2003.
530 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
531 * process.c (create_process) [HAVE_WORKING_VFORK]:
532 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
533 since Emacs no longer uses vfork on that platform.
534
78f83752
GM
5352012-09-17 Glenn Morris <rgm@gnu.org>
536
537 * emacs.c: Use COPYRIGHT.
538
634b8cac
PE
5392012-09-16 Paul Eggert <eggert@cs.ucla.edu>
540
0caaedb1
PE
541 Remove configure's --without-sync-input option (Bug#12450).
542 When auditing signal-handling in preparation for cleaning it up,
543 I found that SYNC_INPUT has race conditions and would be a real
544 pain to fix. Since it's an undocumented and deprecated
545 configure-time option, now seems like a good time to remove it.
546 Also see <http://bugs.gnu.org/11080#16>.
547 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
548 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
549 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
550 (malloc_hysteresis):
551 (check_depth) [XMALLOC_OVERRUN_CHECK]:
552 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
553 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
554 (dont_register_blocks, bytes_used_when_reconsidered)
555 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
556 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
557 [!SYSTEM_MALLOC && !SYNC_INPUT]:
558 Remove. All uses removed.
559 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
560 implementation, one that depends on whether the new macro
561 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
562 is defined.
563 * atimer.c (run_timers, handle_alarm_signal):
564 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
565 (handle_async_input, process_pending_signals)
566 (handle_input_available_signal, init_keyboard):
567 * nsterm.m (ns_read_socket):
568 * process.c (wait_reading_process_output):
569 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
570 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
571 (emacs_write):
572 * xterm.c (XTread_socket):
573 Assume SYNC_INPUT.
574 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
575 * eval.c (handling_signal): Remove. All uses removed.
576 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
577 All uses replaced with the SYNC_INPUT version.
578 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
579 Remove decls.
580 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
581 Now static.
582
634b8cac
PE
583 * font.c (Ffont_shape_gstring): Remove unused local.
584
83da1b55
GM
5852012-09-16 Glenn Morris <rgm@gnu.org>
586
518650a5
GM
587 * Makefile.in (clean): No longer run nextstep's clean.
588
83da1b55
GM
589 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
590 (ns_frag): Remove.
591 (ns-app): Move here from ns.mk, and simplify.
592 (clean): Simplify nextstep entry.
593 * ns.mk: Remove file.
594
85a43e2e
KH
5952012-09-17 Kenichi Handa <handa@gnu.org>
596
597 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
598 not covert the last few charactes.
599
ba13e616 6002012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
601
602 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
603 here, but just check the validity of glyphs in the glyph-string.
604
a8c729af
MR
6052012-09-16 Martin Rudalics <rudalics@gmx.at>
606
607 * window.c (Fwindow_parameter, Fset_window_parameter): Accept
608 any window as argument (Bug#12452).
609
c077c059
JD
6102012-09-16 Jan Djärv <jan.h.d@swipnet.se>
611
612 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
613 to ns_term_init to avoid memory leak.
614
615 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
616 explicit retain/release.
617 (ns_term_init): Only allow one display. Initialize outerpool and
618 ns_*_types.
619
39a57ad0
PE
6202012-09-15 Paul Eggert <eggert@cs.ucla.edu>
621
622 Port _setjmp fix to POSIXish hosts as well as Microsoft.
623 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
624 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
625 the Microsoft problem in a different way, by altering ../nt/config.nt.
626
7105c8cb
EZ
6272012-09-15 Eli Zaretskii <eliz@gnu.org>
628
629 * w32xfns.c:
630 * w32uniscribe.c:
631 * w32term.c:
632 * w32select.c:
633 * w32reg.c:
634 * w32proc.c:
635 * w32menu.c:
636 * w32inevt.c:
637 * w32heap.c:
638 * w32font.c:
639 * w32fns.c:
640 * w32console.c:
641 * w32.c:
642 * w16select.c: Remove inclusion of setjmp.h, as it is now included
643 by lisp.h. This completes removal of setjmp.h inclusion
644 erroneously announced in the previous commit. (Bug#12446)
645
646 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
647 more accurate.
648
649 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
650 not defined as a macro. The latter happens on MS-Windows.
651 (Bug#12446)
652
0328b6de
PE
6532012-09-15 Paul Eggert <eggert@cs.ucla.edu>
654
655 Port better to POSIX hosts lacking _setjmp (Bug#12446).
656 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 657 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
658 only reason for the instance was because "lisp.h" was included.
659 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
660 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
661 and _longjmp with the new symbols. Emacs already uses _setjmp if
662 available, so this change affects only POSIXish hosts that have
663 sigsetjmp but not _setjmp, such as some versions of Solaris and
664 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
665 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
666 (png_load_body) [HAVE_PNG]:
667 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
668 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
669 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
670 since PNG requires jmp_buf. This is the only exception to the
671 general rule that we now use sys_setjmp and sys_longjmp.
672 This exception is OK since this code does not change the signal
673 mask or longjmp out of a signal handler.
674
2af03429
PE
6752012-09-14 Paul Eggert <eggert@cs.ucla.edu>
676
677 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
678 Include "syssignal.h", for 'main_thread'.
679
2f294edf
DA
6802012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
681
682 Avoid out-of-range marker position (Bug#12426).
683 * insdel.c (replace_range, replace_range_2): Adjust
684 markers before overlays, as suggested by comments.
685 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
686 Remove redundant check before calling offset_intervals.
687
6b533e9c
MR
6882012-09-14 Martin Rudalics <rudalics@gmx.at>
689
690 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
691 current buffer (Bug#12387).
692
2a7931e3
JB
6932012-09-14 Juanma Barranquero <lekktu@gmail.com>
694
695 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
696
c18e885b
PE
6972012-09-13 Paul Eggert <eggert@cs.ucla.edu>
698
699 Use a more backwards-compatible timer format (Bug#12430).
700 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
701 vector element, not from the 4th, since PSECS is now at the end.
702 (Fcurrent_idle_time): Doc fix.
703
d59a1afb
DA
7042012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
705
706 Function to mark objects and remove killed buffers at once.
707 * alloc.c (discard_killed_buffers): Rename to ...
708 (mark_discard_killed buffers) ... new name. Add marking
709 of remaining objects. Fix comment. Adjust users.
710 (mark_object): Do not touch frame buffer lists here.
711 * frame.c (delete_frame): Reset frame buffer lists here.
712
5f0cb45a
PE
7132012-09-13 Paul Eggert <eggert@cs.ucla.edu>
714
8ea47e3a
PE
715 Better workaround for GNOME bug when --enable-gcc-warnings.
716 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
717 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
718 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
719
4a4bbad2
PE
720 Simplify SIGIO usage (Bug#12408).
721 The code that dealt with SIGIO was crufty and confusing, e.g., it
722 played tricks like "#undef SIGIO" but these tricks were not used
723 consistently. Simplify mostly by not #undeffing standard symbols,
724 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
725 or not as we please) rather than "defined SIGIO" (standard symbol
726 that we probably shouldn't #undef).
727 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
728 Modules that need it can include it.
729 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
730 * dispextern.h (ignore_sigio): New decl.
731 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
732 unconditionally, since it's now a no-op if !USABLE_SIGIO.
733 * emacs.c (shut_down_emacs):
734 * keyboard.c (kbd_buffer_store_event_hold):
735 Use ignore_sigio rather than invoking 'signal' directly.
736 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
737 for FIONREAD.
738 (FIONREAD, SIGIO): Do not #undef.
739 (tty_read_avail_input): Use #error rather than a syntax error.
740 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
741 for I_PIPE, used by SETUP_SLAVE_PTY.
742 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
743 * sysdep.c (croak): Remove; no longer needed. This bit of
744 temporary code, with Fred N. Fish's comment that it's temporary,
745 has been in Emacs since at least 1992!
746 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
747 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
748 * syssignal.h (croak): Remove decl.
749 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
750 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
751 now that we're termios-only.
752 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
753 * term.c (dissociate_if_controlling_tty): Use #error rather than
754 a run-time error.
755
5f0cb45a
PE
756 Work around GCC and GNOME bugs when --enable-gcc-warnings.
757 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
758 to work around GNOME bug 683906.
759 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
760 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
761 This works around GCC bug 54561.
762
40bce90b
PE
7632012-09-12 Paul Eggert <eggert@cs.ucla.edu>
764
765 More fixes for 'volatile' and setjmp/longjmp.
766 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
767 * image.c (struct png_load_context) [HAVE_PNG]: New type.
768 (png_load_body) [HAVE_PNG]:
769 (jpeg_load_body) [HAVE_JPEG]:
770 New function, with most of the old parent function's body.
771 (png_load) [HAVE_PNG]:
772 (jpeg_load) [HAVE_JPEG]:
773 Invoke the new function, to avoid longjmp munging our locals.
774 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
775 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
776 longjmp is passed 2, as the C standard doesn't guarantee this.
777 Instead, store the failure code into mgr->failure_code.
778
bfeae2cf
SM
7792012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
780
781 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
782 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
783 (syms_of_keyboard): Remove support for unread-command-char.
784
8099e36b
EZ
7852012-09-12 Eli Zaretskii <eliz@gnu.org>
786
787 * w32proc.c (sys_kill): If PID is our process ID and the signal is
788 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
789 violation. (Bug#12426)
790
92547ff9
PE
7912012-09-12 Paul Eggert <eggert@cs.ucla.edu>
792
793 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
794
45b82ad0
SM
7952012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
796
797 * eval.c: Add `inhibit-debugger'.
798 (Qinhibit_debugger): New symbol.
799 (call_debugger): Bind it instead of Qdebug_on_error.
800 (maybe_call_debugger): Test Vinhibit_debugger.
801 (syms_of_eval): Define inhibit-debugger.
802 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
803 (syms_of_xdisp): Remove inhibit-debug-on-message.
804
5779a1dc
PE
8052012-09-11 Paul Eggert <eggert@cs.ucla.edu>
806
50f2e553
PE
807 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
808 If a nonvolatile local variable is written before a _longjmp to
809 the frame containing the variable, and is read after the _longjmp,
810 the value read is indeterminate. Some local variables of type
811 'struct handler' and 'struct catchtag' are used in this way, so
812 mark each of their slots as volatile if the slot can be set before
813 _longjmp and read afterwards.
814 * lisp.h (struct handler): var and chosen_clause are now volatile.
815 (struct catchtag): val, next, and pdlcount are now volatile.
816
ae1d87e2
PE
817 * bidi.c (bidi_push_it, bidi_pop_it):
818 * fns.c (copy_hash_table):
819 * image.c (define_image_type):
820 * keyboard.c (kbd_buffer_store_event_hold):
821 * process.c (Fprocess_send_eof):
822 * xfaces.c (x_create_gc) [HAVE_NS]:
823 * xgselect.c (xg_select):
824 Prefer assignment to memcpy when either will do.
825
5779a1dc
PE
826 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
827 Use pointer-to-a-pointer to simplify and avoid a NILP check each
828 time an item is removed. No need to mark this function 'inline';
829 the compiler knows better than we do.
830
c4c9756b
JD
8312012-09-11 Jan Djärv <jan.h.d@swipnet.se>
832
833 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
834 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
835 to change_frame_size (Bug#12388).
836 (windowDidResize:): Pass YES to updateFrameSize.
837
838 * nsterm.h: Add delay parameter to updateFrameSize.
839
d73e321c
DA
8402012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
841
842 Discard killed buffers from deleted window and frame objects.
843 This reduces an amount of references to killed buffers and
844 helps GC to reclaim them faster.
845 * alloc.c (discard_killed_buffers): New function.
846 (mark_object): Use it for deleted windows and frames.
847 (mark_object): If symbol's value is set up for a killed buffer
848 or deleted frame, restore it's global binding.
849 * data.c (swap_in_global_binding): Add GC notice.
850 (swap_in_symval_forwarding): Use convenient set_blv_where.
851 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
852 * window.h: ... to here.
853
e578f381
DA
8542012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
855
856 Convenient macro to check whether the buffer is live.
857 * buffer.h (BUFFER_LIVE_P): New macro.
858 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
859 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
860
3057e615
YM
8612012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
862
863 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
864 composition cases (Bug#12364).
865
866 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
867 overhang of succeeding glyphs overlapping box cursor.
868
869 * w32term.c (x_draw_glyph_string): Likewise.
870
6fda35f2
PE
8712012-09-11 Paul Eggert <eggert@cs.ucla.edu>
872
c990426a
PE
873 Simplify, document, and port floating-point (Bug#12381).
874 The porting part of this patch fixes bugs on non-IEEE platforms
875 with frexp, ldexp, logb.
876 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
877 Now static.
878 * floatfns.c: Simplify discussion of functions that Emacs doesn't
879 support, by removing commented-out code and briefly listing the
880 C89 functions excluded. The commented-out stuff was confusing
881 maintenance, e.g., we thought we needed cbrt but it was commented out.
882 (logb): Remove decl; no longer needed.
883 (isfinite): New macro, if not already supplied.
884 (isnan): Don't replace any existing macro.
885 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
886 are present on all C89 platforms.
887 (Ffrexp): Do not special-case zero, as frexp does the right thing
888 for that case.
889 (Flogb): Do not use logb, as it doesn't have the desired meaning
890 on hosts that use non-base-2 floating point. Instead, stick with
891 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
892 frexp, to avoid getting an unspecified result.
893
6fda35f2
PE
894 * xdisp.c (Qinhibit_debug_on_message): Now static.
895
16130a58
JD
8962012-09-10 Jan Djärv <jan.h.d@swipnet.se>
897
898 * nsterm.m (ns_update_begin): Set clip path to whole view by using
899 NSBezierPath (Bug#12131).
900
d105a573
CY
9012012-09-10 Chong Yidong <cyd@gnu.org>
902
903 * fns.c (Fdelq, Fdelete): Doc fix.
904
ff55dfe8
PE
9052012-09-10 Paul Eggert <eggert@cs.ucla.edu>
906
907 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
908 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
909
e7032e7c
SM
9102012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
911
912 * lisp.h (make_lisp_ptr): New macro to replace XSET.
913 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
914 Use it.
915
e9957956
EZ
9162012-09-09 Eli Zaretskii <eliz@gnu.org>
917
aba05ce9
EZ
918 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
919 left fringe if the window has a left margin. This avoids leaving
920 traces of the cursor because its leftmost pixel is not drawn over.
921
e9957956
EZ
922 * dispnew.c (update_window_line): When the left margin area of a
923 screen line is updated, set the redraw_fringe_bitmaps_p flag of
924 that screen line. (Bug#12277)
925
f6196b87
PE
9262012-09-09 Paul Eggert <eggert@cs.ucla.edu>
927
928 Assume C89 or later for math functions (Bug#12381).
929 This simplifies the code, and makes it a bit smaller and faster,
930 and (most important) makes it easier to clean up signal handling
931 since we can stop worring about floating-point exceptions in
932 library code. That was a problem before C89, but the problem
933 went away many years ago on all practical Emacs targets.
934 * data.c, image.c, lread.c, print.c:
935 Don't include <math.h>; no longer needed.
936 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
937 might be autoconfigured, as that never happens.
938 * data.c (fmod):
939 * doprnt.c (DBL_MAX_10_EXP):
940 * print.c (DBL_DIG):
941 Remove. C89 or later always defines these.
942 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
943 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
944 (arith_error, domain_error, domain_error2):
945 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
946 no longer needed -- we simply return what C returns. All uses removed.
947 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
948 the wrapped code.
949 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
950 Remove. All uses expanded, as these macros are no longer used
951 more than once and are now more trouble than they're worth.
952 (Ftan): Use tan, not sin / cos.
953 (Flogb): Assume C89 frexp.
954 (fmod_float): Assume C89 fmod.
955 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
956 (init_floatfns): Remove. All uses removed.
957
9d7f1863
JD
9582012-09-08 Jan Djärv <jan.h.d@swipnet.se>
959
960 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
961 compositeToPoint for OSX < 10.6 (Bug#12390).
962
eabf0404
PE
9632012-09-08 Paul Eggert <eggert@cs.ucla.edu>
964
965 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
966 This produces more-accurate results.
967
0b3b1d23
JD
9682012-09-08 Jan Djärv <jan.h.d@swipnet.se>
969
970 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
971 changes (Bug#12088).
972
6dcef6ec
CY
9732012-09-08 Chong Yidong <cyd@gnu.org>
974
975 * syntax.c (Fstring_to_syntax): Doc fix.
976
aa7d57c5
JD
9772012-09-08 Jan Djärv <jan.h.d@swipnet.se>
978
979 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
980 in the internal border.
981 (x_set_window_size): Remove static variables and their usage.
982 (ns_redraw_scroll_bars): Fix NSTRACE arg.
983 (ns_after_update_window_line, ns_draw_fringe_bitmap): Remove
984 fringe/internal border adjustment (Bug#11052).
985 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
986 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
987 (ns_fix_rect_ibw): Remove.
988 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
989 (ns_dumpglyphs_box_or_relief): Ditto.
990 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
991 adjustment.
992 (ns_dumpglyphs_image): Ditto.
fc0c31f8 993 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
994 border adjustment.
995 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
996 their usage. Add fringe_extended_p and its use as in other terms.
997 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
998 scroll bar was removed.
999 (updateFrameSize): New function.
1000 (windowDidResize): Move code to updateFrameSize and call it.
1001
1002 * nsterm.h (EmacsView): Add updateFrameSize.
1003
1a5432bc
CY
10042012-09-07 Chong Yidong <cyd@gnu.org>
1005
b4f5313e
CY
1006 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
1007
1a5432bc
CY
1008 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
1009
1a4f1e9b
PE
10102012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1011
1012 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
1013 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
1014 Problem introduced when merging patches. Noted by Eli Zaretskii in
1015 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
1016 * floatfns.c: Comment fix.
1017 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
1018 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
1019 and anyway the declaration is harmless even if SIGDANGER is not defined.
1020 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
1021 defined BROKEN_FIONREAD). systty.h formerly did this, but other
1022 source files not surprisingly expected syssignal.h to define, or
1023 not define, SIGIO, and it's cleaner to do it that way, for consistency.
1024 Include <sys/ioctl.h>, for FIONREAD.
1025 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
1026 This eliminates a problem whereby other files mysteriously had
1027 to include "syssignal.h" before including "systty.h" if they
1028 wanted to use "#ifdef SIGIO".
1029
bc8000ff
EZ
10302012-09-07 Eli Zaretskii <eliz@gnu.org>
1031
3e6d6928
EZ
1032 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
1033
1034 * w32.c (sigemptyset): Empty the set.
1035 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
1036
bc8000ff
EZ
1037 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
1038
b4fa72f2
DA
10392012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
1040
1041 * alloc.c (mark_buffer): Revert unsafe marking optimization.
1042 (mark_object): Likewise for frame objects.
1043
30730c93
PE
10442012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1045
1046 * syssignal.h (handle_on_main_thread): Always declare,
1047 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
1048 This ports to platforms without HAVE_PTHREAD.
1049
2fe28299
PE
10502012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 Signal-handler cleanup (Bug#12327).
1053 Emacs's signal handlers were written in the old 4.2BSD style with
1054 sigblock and sigmask and so forth, and this led to some
1055 inefficiencies and confusion. Rewrite these to use
1056 pthread_sigmask etc. without copying signal sets around. Also,
1057 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
1058 'signal', and instead use functions that do not attempt to take
1059 over the system name space. This patch causes Emacs's text
1060 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
1061 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
1062 Do not include <signal.h> or "syssignal.h", as these
1063 modules do not use signals.
1064 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
1065 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
1066 Do not include <signal.h>, as "syssignal.h" does that for us now.
1067 * atimer.c (sigmask_atimers): New function.
1068 (block_atimers, unblock_atimers): New functions,
1069 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
1070 All uses replaced.
1071 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
1072 no longer needed here.
1073 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 1074 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
1075 * sysdep.c (struct save_signal): New member 'action', replacing
1076 old member 'handler'.
1077 (save_signal_handlers, restore_signal_handlers):
1078 Use sigaction instead of 'signal' to save and restore.
1079 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
1080 New function. All users of 'signal' modified to use set_sighandler
1081 if they're writeonly, and to use sys_signal if they're read+write.
1082 (emacs_sigaction_init, forwarded_signal): New functions.
1083 (sys_signal): Remove. All uses replaced by calls to sigaction
1084 and emacs_sigaction_init, or by direct calls to 'signal'.
1085 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
1086 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
1087 all uses replaced by pthread_sigmask etc. calls.
1088 * syssignal.h: Include <signal.h>.
1089 (emacs_sigaction_init, forwarded_signal): New decls.
1090 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
1091 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
1092 (sigmask, sys_sigmask): Remove; no longer needed.
1093 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
1094 (sigblock, sigunblock, sigfree):
1095 (sigsetmask) [!defined sigsetmask]:
1096 Remove. All uses replaced by pthread_sigmask.
1097 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
1098 no longer need to be replaced, and its typical old uses
1099 are now done via emacs_sigaction_init and sigaction.
1100 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
1101 (sys_sigdel): Remove; unused.
1102 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
1103
0216c128
EZ
11042012-09-06 Eli Zaretskii <eliz@gnu.org>
1105
1106 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
1107 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
1108
c752cfa9
DA
11092012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1110
1111 Explicitly mark buffer_defaults and buffer_local_symbols.
1112 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
1113 mark_local_symbols here.
1114 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
1115 since special buffers aren't marked here any more.
1116 (allocate_buffer): Chain new buffer with all_buffers here...
1117 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
1118 not here.
1119 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
1120 (syms_of_buffer): Remove staticpro of the above.
1121 (init_buffer_once): Set names for buffer_defaults and
1122 buffer_local_symbols.
1123
a864ef14
PE
11242012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1125
1126 Use bool for booleans in font-related modules.
1127 * font.c (font_intern_prop, font_style_to_value)
1128 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
1129 (generate_otf_features, font_check_otf_features, font_check_otf)
1130 (font_match_p, font_list_entities, font_at):
1131 * fontset.c (fontset_id_valid_p, reorder_font_vector
1132 (fontset_find_font, Fset_fontset_font)
1133 (face_suitable_for_char_p) [0]:
1134 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
1135 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
1136 (m17n_flt_initialized, ftfont_shape_by_flt):
1137 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
1138 * nsfont.m (nsfont_draw):
1139 * w32font.c (w32font_draw):
1140 * w32term.c (x_draw_glyphless_glyph_string_foreground):
1141 Use bool for booleans.
1142 * font.h: Adjust to above API changes.
1143 (struct font, struct font_driver, struct font_driver_list):
1144 Use bool for booleans.
1145 (struct font): Remove useless member encoding_type.
1146 All users removed.
1147 * fontset.c, xftfont.c: Omit unnecessary static decls.
1148
0699fc18
DA
11492012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1150
1151 * alloc.c (mark_object): Revert window marking code
1152 since it's unsafe for the Fset_window_configuration.
1153
20ef56db
PE
11542012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1155
2fe28299 1156 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
1157 Be more systematic about preserving errno whenever a signal
1158 handler returns, even if it's not in the main thread. Do this by
1159 renaming signal handlers to distinguish between signal delivery
1160 and signal handling. All uses changed.
1161 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
1162 * data.c (deliver_arith_signal): Rename from arith_error.
1163 * dispnew.c (deliver_window_change_signal): Rename from
1164 window_change_signal.
1165 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
1166 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
1167 * keyboard.c (deliver_input_available_signal): Rename from
1168 input_available_signal.
1169 (deliver_user_signal): Rename from handle_user_signal.
1170 (deliver_interrupt_signal): Rename from interrupt_signal.
1171 * process.c (deliver_pipe_signal): Rename from send_process_trap.
1172 (deliver_child_signal): Rename from sigchld_handler.
1173 * atimer.c (handle_alarm_signal):
1174 * data.c (handle_arith_signal):
1175 * dispnew.c (handle_window_change_signal):
1176 * emacs.c (handle_fatal_signal, handle_danger_signal):
1177 * keyboard.c (handle_input_available_signal):
1178 * keyboard.c (handle_user_signal, handle_interrupt_signal):
1179 * process.c (handle_pipe_signal, handle_child_signal):
1180 New functions, with the actual signal-handling code taken from the
1181 original respective signal handlers, sans the sporadic attempts to
1182 preserve errno, since that's now done by handle_on_main_thread.
1183 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
1184 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
1185 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1186 Move to sysdep.c.
1187 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1188 Move initialization of main_thread to sysdep.c's init_signals.
1189 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
1190 our usage, and simplifies the mainline code.
1191 (record_child_status_change): New static function, as a helper
1192 for handle_child_signal, and with most of the old child handler's
1193 contents.
1194 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
1195 (handle_child_signal): Use the above.
1196 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1197 Moved here from emacs.c.
1198 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
1199 code moved here from emacs.c's main function.
1200 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
1201 replacing the old SIGNAL_THREAD_CHECK. All uses changed. This
1202 lets callers save and restore errno properly.
1203
e3ccf108
DA
12042012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1205
1206 Remove redundant or unused things here and there.
1207 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
1208 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
1209 * editfns.c (Fcompare_buffer_substrings): Likewise.
1210 * frame.h (struct terminal, struct font_driver_list):
1211 Remove redundant declarations.
1212 * window.h (Qleft, Qright): Likewise.
1213
697e1e39
DA
12142012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1215
1216 Do not mark objects from deleted buffers, windows and frames.
1217 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
1218 (mark_object): Likewise for windows and frames.
1219
c1ca42ca
DA
12202012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1221
1222 * alloc.c (valid_lisp_object_p): Treat killed buffers,
1223 buffer_defaults and buffer_local_symbols as valid objects.
1224 Return special value to denote them.
1225
014d93be
PE
12262012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1227
f75d7a91
PE
1228 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
1229 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
1230 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
1231 (file_name_absolute_p, Fsubstitute_in_file_name):
1232 (check_executable, check_writable, Ffile_accessible_directory_p)
1233 (Fset_file_selinux_context, Fdefault_file_modes)
1234 (Finsert_file_contents, choose_write_coding_system)
1235 (Fwrite_region, build_annotations, a_write, e_write)
1236 (Fdo_auto_save):
1237 * filelock.c (boot_time_initialized, get_boot_time)
1238 (get_boot_time_1, lock_file_1, within_one_second):
1239 * floatfns.c (in_float):
1240 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
1241 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
1242 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
1243 * lisp.h (struct Lisp_Hash_Table.cmpfn):
1244 * window.c (compare_window_configurations):
1245 Use bool for booleans.
1246 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
1247 (Fdefault_file_modes): Now mode_t, not int, for modes.
1248 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
1249 (internal_delete_file): Now returns void, not a (boolean) int,
1250 since nobody was looking at the return value.
1251 * lisp.h, window.h: Adjust to above API changes.
1252
014d93be
PE
1253 * xdisp.c (set_message): Simplify and reindent last change.
1254
776f29e1
JB
12552012-09-05 Juanma Barranquero <lekktu@gmail.com>
1256
1257 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
1258
7f7e0167
LI
12592012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
1260
1261 * eval.c (call_debugger): Make the function non-static so that we
1262 can call it from set_message.
1263
1264 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
1265 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
1266
cf29dd84
PE
12672012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1268
1269 Give more-useful info on a fatal error (Bug#12328).
1270 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
1271 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
1272 of doing the work ourselves.
1273 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
1274 do most of the work.
1275 (fatal_error_backtrace): New function, taken from the guts
1276 of the old fatal_error_signal, but with a new option to output
1277 a backtrace.
1278 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
1279 info about the signal than just its number.
1280 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
1281 * sysdep.c: Include <execinfo.h>
1282 (emacs_backtrace): New function, taken partly from the previous
1283 code of the 'die' function.
1284 (emacs_abort): Call fatal_error_backtrace rather than abort.
1285
972debf2
SM
12862012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1287
1288 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
1289 eager (load-time) macro-expansion.
1290 * lisp.mk (lisp): Add macroexp.
1291
1088b922
PE
12922012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 Simplify redefinition of 'abort' (Bug#12316).
1295 Do not try to redefine the 'abort' function. Instead, redo
1296 the code so that it calls 'emacs_abort' rather than 'abort'.
1297 This removes the need for the NO_ABORT configure-time macro
1298 and makes it easier to change the abort code to do a backtrace.
1299 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
1300 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
1301 Remove; sysdep.c's emacs_abort now takes its place.
1302 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
1303 'abort' changed to use 'emacs_abort'.
1304 * msdos.c (dos_abort) [defined abort]: Remove; not used.
1305 (abort) [!defined abort]: Rename to ...
1306 (emacs_abort): ... new name.
1307 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
1308 the place of the old 'abort' in emacs.c.
1309 * w32.c, w32fns.c (abort): Do not #undef.
1310 * w32.c (emacs_abort): Rename from w32_abort.
1311
30934d33
EZ
13122012-09-04 Eli Zaretskii <eliz@gnu.org>
1313
1314 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
1315 offsets[j].dv, since the y axis of the screen coordinates points
1316 down, while the y axis of the font definition coordinates points
1317 up. This fixes display of Arabic diacritics such as KASRA and
1318 KASRATAN. (Bug#11860)
1319
af26b72c
PE
13202012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1321
1322 Be more systematic about _setjmp vs setjmp.
1323 * alloc.c (test_setjmp, mark_stack):
1324 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
1325 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
1326 (png_load, my_error_exit, jpeg_load):
1327 * process.c (send_process_trap, send_process):
1328 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
1329 The underscored versions are up to 30x faster on some hosts.
1330 Formerly, the code used setjmp+longjmp sometimes and
1331 _setjmp+_longjmp at other times, with no particular reason to
1332 prefer setjmp+longjmp.
1333
26d4541d
PE
13342012-09-03 Paul Eggert <eggert@cs.ucla.edu>
1335
d42f4f0f 1336 Fix minor problem found by static checking.
26d4541d 1337 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 1338
c5e28e39
MR
13392012-09-03 Martin Rudalics <rudalics@gmx.at>
1340
1341 * buffer.c (Fdelete_all_overlays): New function.
1342
3eab3ca9
CY
13432012-09-03 Chong Yidong <cyd@gnu.org>
1344
1345 * gtkutil.c: Add extern decl for Qxft.
1346
c04889f8
PE
13472012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1348
1882aa38
PE
1349 * emacs.c, eval.c: Use bool for boolean.
1350 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
1351 (malloc_using_checking) [DOUG_LEA_MALLOC]:
1352 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
1353 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
1354 (main, decode_env_path, Fdaemon_initialized):
1355 * eval.c (call_debugger, Finteractive_p, interactive_p):
1356 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
1357 (maybe_call_debugger, Fbacktrace):
1358 * process.c (read_process_output, exec_sentinel):
1359 Use bool for booleans.
1360 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
1361 All callers changed.
1362 * eval.c (interactive_p): Omit always-true boolean argument
1363 EXCLUDE_SUBRS_P. All callers changed.
1364 * dispextern.h, lisp.h: Reflect above API changes.
1365 * firstfile.c (dummy): Use the address of 'main', whose signature
1366 won't change, instead of the address of 'initialize', whose
1367 signature just changed from int to bool.
1368 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
1369 * msdos.c (fatal_error_in_progress): ... from here.
1370 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
1371 of incrementing it.
1372 (redisplay_internal, unwind_redisplay): Simply clear
1373 REDISPLAYING_P when unwinding, instead of saving its previous,
1374 always-false value and then restoring it.
1375
a411ac43
PE
1376 Clean up some extern decls.
1377 Mostly, this hoists extern decls out of .c files and into .h files.
1378 That way, we're more likely to catch errors if the interfaces change.
1379 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
1380 declare xg_mark_data.
1381 * dispextern.h (x_frame_parm_handlers):
1382 * font.h (Qxft):
1383 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
1384 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
1385 (Qultra_bold, Qoblique, Qitalic):
1386 Move extern decl here from .c file.
1387 * alloc.c (xg_mark_data) [USE_GTK]:
1388 * doc.c (Qclosure):
1389 * eval.c (Qlexical_binding):
1390 * fns.c (time) [!HAVE_UNISTD_H]:
1391 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
1392 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
1393 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
1394 * lread.c (Qinternal_interpreter_environment):
1395 * minibuf.c (Qbuffer):
1396 * process.c (QCfamily, QCfilter):
1397 * widget.c (free_frame_faces):
1398 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
1399 * xfont.c (x_clear_errors):
1400 * xterm.c (x_frame_parm_handlers):
1401 Remove now-redundant extern decls.
1402 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
1403 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
1404 Now static.
1405 * xfaces.c: Remove unnecessary static decls.
1406 * xterm.c (updating_frame): Remove decl of nonexistent object.
1407
c04889f8
PE
1408 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
1409 when building globals.h, as the objects that are not built on
1410 this host are not needed to compile C files on this host.
1411
8b339673
JD
14122012-09-02 Jan Djärv <jan.h.d@swipnet.se>
1413
1414 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
1415
1416 * frame.h: Add missing prototype for x_wm_set_size_hint.
1417
a08d4ba7
PE
14182012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1419
1420 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
1421 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
1422 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
1423 (Fsubstitute_command_keys):
1424 * editfns.c (region_limit, find_field, Fconstrain_to_field)
1425 (save_excursion_save, save_excursion_restore)
1426 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
1427 (format_time_string, general_insert_function)
1428 (make_buffer_string, make_buffer_string_both)
1429 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
1430 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
1431 (copy_text, insert_1, insert_1_both, insert_from_string)
1432 (insert_from_string_before_markers, insert_from_string_1)
1433 (insert_from_buffer, insert_from_buffer_1, replace_range)
1434 (replace_range_2, del_range_1, del_range_byte, del_range_both)
1435 (del_range_2, modify_region):
1436 * intervals.c (intervals_equal, balance_possible_root_interval)
1437 (adjust_intervals_for_insertion, merge_properties_sticky)
1438 (graft_intervals_into_buffer, lookup_char_property)
1439 (adjust_for_invis_intang, set_point_both)
1440 (get_property_and_range, compare_string_intervals)
1441 (set_intervals_multibyte_1, set_intervals_multibyte):
1442 * keyboard.c (decode_timer):
1443 Use bool for boolean.
1444 * intervals.h, lisp.h, systime.h: Reflect above API changes.
1445 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
1446
48c948de
CY
14472012-09-02 Chong Yidong <cyd@gnu.org>
1448
1449 * keymap.c (push_key_description): Print M-TAB as C-M-i
1450 (Bug#11758).
1451
6c49a40b
JB
14522012-09-02 Juanma Barranquero <lekktu@gmail.com>
1453
1454 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
1455 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
1456 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
1457 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
1458 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
1459 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
1460 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1461
4dfbd238
EZ
14622012-09-01 Eli Zaretskii <eliz@gnu.org>
1463
7e510e28
EZ
1464 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
1465 more than one grapheme cluster passed to the shaper: compute the
1466 offset adjustment values separately for each cluster. (Bug#11860)
1467
4dfbd238
EZ
1468 * image.c: Restore mistakenly removed inclusion of w32.h. Without
1469 it, GCC doesn't see prototypes of w32_delayed_load, and complains
1470 about implicit conversions from integer to pointer.
1471
86571ae0
DC
14722012-09-01 Daniel Colascione <dancol@dancol.org>
1473
1474 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
1475 system used too early.
1476
0e23ef9d
PE
14772012-09-01 Paul Eggert <eggert@cs.ucla.edu>
1478
1479 Better seed support for (random).
1480 * emacs.c (main): Call init_random.
1481 * fns.c (Frandom): Set the seed from a string argument, if given.
1482 Remove long-obsolete Gentzel cruft.
1483 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
1484 (init_random): New function.
1485
17a2cbbd
DC
14862012-09-01 Daniel Colascione <dancol@dancol.org>
1487
1488 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
1489 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
1490 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
1491 x_wm_set_size_hint, x_query_colors, x_real_positions,
1492 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
1493 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
1494 all of which have been moved to common code.
1495
1496 * xfaces.c: Include TERM_HEADER instead of listing all possible
1497 window-system headers.
1498
1499 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
1500 to match header.
1501
1502 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
1503 directly accessing frame internals.
1504
f18cbb28 1505 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
1506 globals_of_w32font.
1507
1508 * process.c: Include TERM_HEADER instead of listing all possible
1509 window-system headers.
1510
1511 * nsterm.h: Remove declarations now in frame.h. Define
1512 FRAME_X_SCREEN, FRAME_X_VISUAL.
1513
1514 * menu.c: Include TERM_HEADER instead of listing all possible
1515 window-system headers.
1516
1517 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
1518 window system.
1519
1520 * keyboard.c: Include TERM_HEADER instead of listing all possible
1521 window-system headers.
1522
1523 * image.c: Include TERM_HEADER instead of listing all possible
1524 window-system headers. Declare Vlibrary_cache when compiling for
1525 Windows.
1526
1527 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
1528 window system declarations.
1529
1530 * frame.h: Move common functions here: set_frame_menubar,
1531 x_set_window_size, x_sync, x_get_focus_frame,
1532 x_set_mouse_position, x_set_mouse_pixel_position,
1533 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
1534 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
1535 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
1536 x_activate_menubar, x_real_positions, x_bitmap_icon,
1537 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
1538 and x_query_colors.
1539
1540 * frame.c: Include TERM_HEADER instead of listing all possible
1541 window-system headers.
1542
1543 * font.c: Include TERM_HEADER instead of listing all possible
1544 window-system headers.
1545
1546 * emacs.c: Include TERM_HEADER.
1547
f18cbb28
EZ
1548 * dispnew.c: Include TERM_HEADER instead of listing all possible
1549 window-system headers.
17a2cbbd 1550
f18cbb28 1551 * ccl.h: Include character.h.
17a2cbbd
DC
1552
1553 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
1554 the current window system; include in list of objects to link into
1555 Emacs.
1556
c650a5de
DA
15572012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1558
1559 Remove mark_ttys function and fix tty_display_info initialization.
1560 * lisp.h (mark_ttys): Remove prototype.
1561 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
1562 to mark_ttys because all possible values of 'top_frame' slot are
1563 the frames which are reachable from Vframe_list.
1564 * term.c (mark_ttys): Remove.
1565 (init_tty): Safely initialize 'top_frame' slot with Qnil.
1566
4e0f6479
DA
15672012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1568
1569 Change struct frame bitfields from unsigned char to unsigned.
1570 * frame.h (struct frame): Change type of 'display_preempted',
1571 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
1572 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
1573 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
1574 bitfields from unsigned char to unsigned.
1575
8b96a52c
DA
15762012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1577
1578 Remove unused member of struct x_output and struct w32_output.
1579 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
1580 * w32term.h (struct w32_output): Likewise.
1581
b4444c8a
JD
15822012-08-30 Jan Djärv <jan.h.d@swipnet.se>
1583
1584 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
1585 does not become zero (Bug#12234).
1586
b98521db
PE
15872012-08-30 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
1590 for GCC 4.7.1 x86-64.
1591
31d02438
GM
15922012-08-30 Glenn Morris <rgm@gnu.org>
1593
1594 * lread.c (init_lread): For out-of-tree builds, only add the
1595 source directory's site-lisp dir to the load-path if it exists,
1596 consistent with in-tree builds. (Bug#12302)
1597
7f8941d8
JD
15982012-08-28 Jan Djärv <jan.h.d@swipnet.se>
1599
1600 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 1601 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
1602 (windowShouldClose:): Set window_closed.
1603 (dealloc): New member, free button_values.
fc0c31f8
JB
1604 (process_dialog:): Make member function. Remove window argument,
1605 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
1606 in button_values.
1607 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 1608 with tag. Remove return self, declare return value as void.
7f8941d8
JD
1609 (addString:row:): Remove return self, declare return value as void.
1610 (addSplit): Remove return self, declare return value as void.
1611 (clicked:): Remove return self, declare return value as void.
fc0c31f8 1612 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
1613 (initFromContents:isQuestion:): Adjust call to process_dialog.
1614 Code formatting change.
1615 (timeout_handler:): Set timer_fired to YES.
1616 (runDialogAt:): Set timer_fired to NO.
1617 Handle click on close button as quit.
1618
1619 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
1620 Add window_closed and button_values. Add void as return value for
1621 add(Button|String|Split). addButton takes int instead of Lisp_Object.
1622 Add process_dialog as new member.
1623
eada0861 16242012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 1625
eada0861
GM
1626 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
1627 is not one of the heaps we manage. (Bug#12242)
1628
16292012-08-28 Glenn Morris <rgm@gnu.org>
1630
1631 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
1632
457294dd
MR
16332012-08-28 Martin Rudalics <rudalics@gmx.at>
1634
1635 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
1636 auto-buffer-name window parameter. Install revision of reverted
1637 fix.
457294dd 1638
4f2daf31
DA
16392012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1640
1641 Do not allow to set major mode for a dead buffer.
1642 * buffer.c (Fset_buffer_major_mode): Signal an error
1643 if the buffer is dead.
1644 (Fother_buffer, other_buffer_safely): Remove redundant
1645 nested declaration.
1646
66322887
DA
16472012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1648
1649 Always use set_buffer_if_live to restore original buffer at unwind.
1650 * buffer.h (record_unwind_current_buffer): New function.
1651 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
1652 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
1653 * undo.c, window.c: Adjust users.
1654 * buffer.c (set_buffer_if_live): Fix comment.
1655
a3d794a1
DA
16562012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1657
1658 Fix usage of set_buffer_internal.
1659 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
1660 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
1661 * coding.c (decode_coding): Omit redundant test.
1662 * fileio.c (decide_coding_unwind): Likewise.
1663 * fns.c (secure_hash): Likewise.
1664 * insdel.c (modify_region): Likewise.
1665 * keyboard.c (command_loop_1): Likewise.
1666 * print.c (PRINTFINISH): Likewise.
1667 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
1668
59ea14cd
PE
16692012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1670
1671 * dispnew.c: Use bool for boolean.
1672 (frame_garbaged, display_completed, delayed_size_change)
1673 (fonts_changed_p, add_window_display_history)
1674 (add_frame_display_history, verify_row_hash)
1675 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
1676 (row_equal_p, realloc_glyph_pool)
1677 (allocate_matrices_for_frame_redisplay)
1678 (showing_window_margins_p)
1679 (adjust_frame_glyphs_for_frame_redisplay)
1680 (build_frame_matrix_from_leaf_window, make_current)
1681 (mirrored_line_dance, mirror_line_dance, update_frame)
1682 (update_window_tree, update_single_window)
1683 (check_current_matrix_flags, update_window, update_text_area)
1684 (update_window_line, set_window_update_flags, scrolling_window)
1685 (update_frame_1, scrolling, buffer_posn_from_coords)
1686 (do_pending_window_change, change_frame_size)
1687 (change_frame_size_1, sit_for):
1688 Use bool for boolean.
1689 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
1690 and remove last int (actually boolean) argument, which was always 0.
1691 All callers changed.
1692 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
1693 * dispextern.h (struct composition_it): Use bool for boolean.
1694 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
1695 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
1696 * dired.c (file_name_completion):
1697 Use bool for boolean. (This was missed in an earlier change.)
1698
95072a94
MR
16992012-08-27 Martin Rudalics <rudalics@gmx.at>
1700
1701 * window.c (Fset_window_configuration): Revert first part of
1702 last change.
1703
0f19feff
JD
17042012-08-27 Jan Djärv <jan.h.d@swipnet.se>
1705
1706 * nsterm.h (NSPanel): New class variable dialog_return.
1707
1708 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
1709 dialog_return.
1710 (windowShouldClose:): Use stop instead of stopModalWithCode.
1711 (clicked:): Ditto, and also set dialog_return (Bug#12258).
1712 (timeout_handler:): Use stop instead of abortModal. Send a dummy
1713 event.
1714 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
1715 modal loop returns.
1716
f10fe38f
PE
17172012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1718
de1339b0
PE
1719 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
1720 * composite.c (find_composition, composition_gstring_p)
1721 (composition_reseat_it, find_automatic_composition):
1722 * data.c (let_shadows_buffer_binding_p)
1723 (let_shadows_global_binding_p, set_internal, make_blv)
1724 (Fmake_variable_buffer_local, Fmake_local_variable)
1725 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
1726 (cons_to_signed, arith_driver):
1727 * dbusbind.c (xd_in_read_queued_messages):
1728 * dired.c (directory_files_internal, file_name_completion):
1729 Use bool for booleans.
1730 * dired.c (file_name_completion):
1731 * process.h (fd_callback):
1732 Omit int (actually boolean) argument. It wasn't being used.
1733 All uses changed.
1734 * composite.h, lisp.h: Reflect above API changes.
1735
f10fe38f
PE
1736 * cmds.c, coding.c: Use bool for booleans.
1737 * cmds.c (move_point, Fself_insert_command):
1738 * coding.h (struct composition status, struct coding_system):
1739 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
1740 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
1741 (emacs_mule_char, decode_coding_emacs_mule)
1742 (encode_coding_emacs_mule, detect_coding_iso_2022)
1743 (decode_coding_iso_2022, encode_invocation_designation)
1744 (encode_designation_at_bol, encode_coding_iso_2022)
1745 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
1746 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
1747 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
1748 (encode_coding_raw_text, detect_coding_charset)
1749 (decode_coding_charset, encode_coding_charset, detect_eol)
1750 (detect_coding, get_translation_table, produce_chars)
1751 (consume_chars, reused_workbuf_in_use)
1752 (make_conversion_work_buffer, code_conversion_save)
1753 (decode_coding_object, encode_coding_object)
1754 (detect_coding_system, char_encodable_p)
1755 (Funencodable_char_position, code_convert_region)
1756 (code_convert_string, code_convert_string_norecord)
1757 (Fset_coding_system_priority):
1758 * fileio.c (Finsert_file_contents):
1759 Use bool for booleans.
1760 * coding.h, lisp.h: Reflect above API changes.
1761 * coding.c: Remove unnecessary static function decls.
1762 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
1763 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
1764 not a boolean 'int', since callers never look at the return value.
1765 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
1766 * coding.h (decoding_buffer_size, encoding_buffer_size)
1767 (emacs_mule_string_char): Remove unused extern decls.
1768 (struct iso_2022_spec, struct coding_system):
1769 Use 'unsigned int : 1' for boolean fields, since there's more than one.
1770 (struct emacs_mule_spec): Remove unused field 'full_support'.
1771 All initializations removed.
1772 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
1773
5474c384
DA
17742012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1775
f10fe38f 1776 Fix spare memory change (Bug#12286).
5474c384
DA
1777 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
1778 (valid_lisp_object_p): Likewise.
1779
c4b6914d
MR
17802012-08-27 Martin Rudalics <rudalics@gmx.at>
1781
1782 * window.c (Fset_window_configuration): Record any window's old
1783 buffer if it's replaced (see Bug#8789). If the new current
1784 buffer doesn't appear in the selected window, go to its old
1785 point (Bug#12208).
1786
35aaa1ea
DA
17872012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1788
1789 Special MEM_TYPE_SPARE to denote reserved memory.
1790 * alloc.c (enum mem_type): New memory type.
1791 (refill_memory_reserve): Use new type for spare memory.
1792 This prevents live_cons_p and live_string_p from incorrect
1793 detection of uninitialized objects from spare memory as live.
1794
6af64513
PE
17952012-08-26 Paul Eggert <eggert@cs.ucla.edu>
1796
8b2e00a3
PE
1797 Spelling fixes.
1798 * Makefile.in (.PHONY): versioclean -> versionclean.
1799
b52d6985
PE
1800 Remove unused external symbols.
1801 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
1802 * window.c (Qwindow_valid_p, decode_valid_window):
1803 Now static, not extern.
1804 * data.c (Qinterval): Remove; unused.
1805 (syms_of_data): Do not define 'interval'.
1806 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
1807 * window.h (decode_valid_window):
1808 Remove decls.
1809
d5172d4f
PE
1810 * character.c, charset.c, chartab.c: Use bool for booleans.
1811 * character.c (lisp_string_width, string_count_byte8)
1812 (string_escape_byte8):
1813 * charset.c (charset_map_loaded, load_charset_map, read_hex):
1814 (load_charset_map_from_file, map_charset_chars)
1815 (Fdefine_charset_internal, define_charset_internal)
1816 (Fdeclare_equiv_charset, find_charsets_in_text)
1817 (Ffind_charset_region, char_charset, Fiso_charset):
1818 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
1819 (sub_char_table_set, sub_char_table_set_range)
1820 (char_table_set_range, optimize_sub_char_table)
1821 (map_sub_char_table):
1822 Use bool for boolean.
1823 * character.c (str_to_unibyte): Omit last boolean argument; it was
1824 always 0. All callers changed.
1825 * character.h, charset.h: Adjust to match previous changes.
1826 * character.h (char_printable_p): Remove decl of nonexistent function.
1827 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
1828 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
1829 are all boolean, so make them single-bit bitfields.
1830
6af64513
PE
1831 * lisp.h (ASET): Remove attempt to detect side effects.
1832 It was meant to be temporary and it often doesn't work,
1833 because when IDX has side effects the behavior of IDX==IDX
1834 is undefined. See Stefan Monnier in
1835 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
1836
e1f29348
BR
18372012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1838
1839 * lisp.h (functionp): New function (extracted from Ffunctionp).
1840 (FUNCTIONP): Use it.
1841 * eval.c (Ffunctionp): Use it.
1842
17c05d74
PE
18432012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1844
0f46bc75
PE
1845 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
1846 as that's faster and simpler than static storage. Don't bother
1847 with the g_main_context_query overhead if g_main_context_pending
1848 says no events are pending.
1849 (gfds, gfds_size): Remove these static vars.
1850 (xgselect_initialize): Remove; no longer needed.
1851 All uses and decls removed.
1852
ee4c0f69
PE
1853 * emacs.c (fatal_error_signal_hook): Remove.
1854 All uses removed. This leftover from old code was always 0.
1855
17c05d74
PE
1856 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
1857 * casefiddle.c (casify_object, casify_region):
1858 * casetab.c (set_case_table):
1859 * category.c, category.h (word_boundary_p):
1860 * category.h (CHAR_HAS_CATEGORY):
1861 Use bool for booleans, instead of int.
1862
391ceac5
EZ
18632012-08-25 Eli Zaretskii <eliz@gnu.org>
1864
1865 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
1866
2f221583
PE
18672012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1868
f4a681b0
PE
1869 On assertion failure, print backtrace if available.
1870 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
1871 (die) [ENABLE_CHECKING]: Print a backtrace if available.
1872 * Makefile.in (LIB_EXECINFO): New macro.
1873 (LIBES): Use it.
1874
2f221583
PE
1875 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
1876 * bytecode.c (exec_byte_code):
1877 * callint.c (check_mark, Fcall_interactively):
1878 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
1879 (getenv_internal, sync_process_alive, call_process_exited):
1880 * lisp.h (USE_SAFE_ALLOCA):
1881 Use bool for booleans, instead of int.
1882 * lisp.h, process.h: Adjust prototypes to match above changes.
1883 * callint.c (Fcall_interactively): Don't assume the mark's
1884 offset fits in 'int'.
1885
37ef52bb
PE
18862012-08-24 Paul Eggert <eggert@cs.ucla.edu>
1887
1888 * buffer.c, buffer.h: Use bool for boolean.
1889 * buffer.c (reset_buffer_local_variables)
1890 (buffer_lisp_local_variables, Fset_buffer_modified_p)
1891 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
1892 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
1893 (overlay_touches_p, overlay_strings, Foverlay_put)
1894 (report_overlay_modification, call_overlay_mod_hooks):
1895 (mmap_enlarge, mmap_set_vars):
1896 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
1897 Use bool for booleans, instead of int.
1898 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
1899 since the 1-or-0 return value is always ignored anyway.
1900 (mmap_initialized_p):
1901 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
1902 * buffer.h, lisp.h: Adjust prototypes to match above changes.
1903
2cc21167
PE
19042012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1905
1906 * bidi.c: Use bool for boolean.
1907 This is a bit more readable, and makes the text segment of bidi.o
1908 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
1909 Presumably it's faster too.
1910 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
1911 Now bool.
1912 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1913 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
1914 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
1915 (bidi_explicit_dir_char, bidi_level_of_next_char)
1916 (bidi_find_other_level_edge, bidi_move_to_visually_next):
1917 Use bool for booleans, instead of int.
1918 * dispextern.h (bidi_init_it, bidi_paragraph_init)
1919 (bidi_unshelve_cache): Adjust decls to match code.
1920
7db4ddf4
MR
19212012-08-23 Martin Rudalics <rudalics@gmx.at>
1922
1923 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
1924 argument.
1925
b1bb8011
PE
19262012-08-23 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
1929 * atimer.h: Include <stdbool.h>.
1930
ff687885
DN
19312012-08-22 Dan Nicolaescu <dann@gnu.org>
1932
1933 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
1934 compile time tests instead of run time tests on systems that do
1935 not use them.
1936 (FRAME_MAC_P): Remove leftover from deleted code.
1937 * frame.c (syms_of_frame): Remove leftover from deleted code.
1938
4ce7a138
JD
19392012-08-22 Jan Djärv <jan.h.d@swipnet.se>
1940
1941 * nsterm.m (insertText:): Don't clear modifiers if code is space.
1942
d733ec6d
PE
19432012-08-22 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
1946 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 1947 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
1948 (fontset_add): Return void, for FONTSET_ADD.
1949
d0d2d26f
PE
19502012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1951
fce31d69
PE
1952 * alloc.c: Use bool for booleans.
1953 (gc_in_progress, abort_on_gc)
1954 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1955 (dont_register_blocks) [GC_MALLOC_CHECK]:
1956 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
1957 (check_string_bytes, make_specified_string, memory_full)
1958 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
1959 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
1960 (mark_stack, valid_pointer_p, make_pure_string)
1961 (Fgarbage_collect, survives_gc_p, gc_sweep):
1962 Use bool for booleans, instead of int.
1963 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
1964 Remove unused local.
1965 * alloc.c (PURE_POINTER_P):
1966 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
1967 * editfns.c (Fformat):
1968 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
1969 (Fdo_auto_save):
1970 * fns.c (sweep_weak_table):
1971 * lisp.h (suppress_checking, push_message, survives_gc_p)
1972 (make_pure_string, gc_in_progress, abort_on_gc):
1973 * lread.c (readchar, read1):
1974 * print.c (Fprin1_to_string):
1975 * xdisp.c (push_message):
1976 Use bool for booleans affected directly or indirectly by
1977 alloc.c's changes.
1978
d0d2d26f
PE
1979 Make recently-introduced setters macros.
1980 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
1981 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
1982 (set_fontset_default, set_fontset_fallback): Rename from their
1983 upper-case counterparts, and make them functions rather than macros.
1984 This is more consistent with the other recently-introduced setters.
1985 These don't need to be inline, since they're local.
1986
d18e2bb6
JD
19872012-08-21 Jan Djärv <jan.h.d@swipnet.se>
1988
1989 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
1990 the loop (Bug#12247).
1991
1b9d9d16
PE
19922012-08-21 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 * lisp.h (vcopy): Use memcpy rather than our own loop.
1995 This fixes a performance regression introduced by the recent
1996 addition of vcopy. This means 'vcopy' will need to be modified
1997 for a copying collector, but that's OK. Also, tighten the
1998 checking in the assertion.
1999
b2f09701
EZ
20002012-08-21 Eli Zaretskii <eliz@gnu.org>
2001
2002 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
2003 components for RTL text (Bug#11860). Adjust X-OFFSET of each
2004 non-base glyph for the width of the base character, according to
e1f29348
BR
2005 what x_draw_composite_glyph_string_foreground expects.
2006 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
2007 expectations, to produce correct width of the composed character.
2008 Reverse the sign of the DU offset produced by ScriptPlace.
2009
9b994fed
PE
20102012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2011
2012 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
2013
086ca913
DA
20142012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2015
2016 Avoid direct writes to contents member of struct Lisp_Vector.
2017 * lisp.h (vcopy): New function to copy data into vector.
2018 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
2019 * fns.c (Ffillarray): Use ASET.
2020 * keyboard.c (timer_check_2): Use AREF and ASET.
2021 (append_tool_bar_item, Frecent_keys): Use vcopy.
2022 * lread.c (read_vector): Use ASET.
2023 * msdos.c (Frecent_doskeys): Use vcopy.
2024 * xface.c (Finternal_copy_lisp_face): Use vcopy.
2025 (Finternal_merge_in_global_face): Use ASET and vcopy.
2026 * xfont.c (xfont_list_pattern): Likewise.
2027
5481664a
MR
20282012-08-21 Martin Rudalics <rudalics@gmx.at>
2029
2030 * window.c (Fwindow_point): For the selected window always return
2031 the position of its buffer's point.
2032 (Fset_window_point): For the selected window always go in its
2033 buffer to the specified position.
2034
6d470bdd
DA
20352012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2036
2037 Setter macros for fontsets.
2038 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
2039 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
2040 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
2041 Adjust users.
2042
24564fe1
GM
20432012-08-20 Glenn Morris <rgm@gnu.org>
2044
2045 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2046 Don't assume that `ln -f' works.
2047
0a05a035
EZ
20482012-08-20 Eli Zaretskii <eliz@gnu.org>
2049
2050 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
2051 and later about non-assignments with no effect. See discussion at
2052 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
2053 details.
2054
e46f2325
DA
20552012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2056
2057 Inline setter functions for Lisp_Objects slots of struct specbinding.
2058 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
2059 Adjust users.
2060
734fbd86
MR
20612012-08-20 Martin Rudalics <rudalics@gmx.at>
2062
2063 * window.c (select_window): Always make selected window's buffer
2064 current.
2065
f1a95992
DA
20662012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2067
2068 Use AREF and ASET for docstrings of category tables.
2069 * category.h (CATEGORY_DOCSTRING): Use AREF.
2070 (SET_CATEGORY_DOCSTRING): Use ASET.
2071 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
2072
e83064be
DA
20732012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2074
2075 Inline setter functions for hash table members.
2076 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
2077 (set_hash_hash, set_hash_index): Rename with _slot suffix.
2078 (set_hash_key_and_value, set_hash_index, set_hash_next)
2079 (set_hash_hash): New functions.
2080 * charset.c, fns.c: Adjust users.
2081
4ce60d2e
DA
20822012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2083
2084 Inline getter and setter functions for per-buffer values.
2085 * buffer.h (per_buffer_default, set_per_buffer_default)
2086 (per_buffer_value, set_per_buffer_value): New functions.
2087 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
2088 * buffer.c, data.c: Adjust users.
2089
c06c9690
JB
20902012-08-20 Juanma Barranquero <lekktu@gmail.com>
2091
2092 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
2093
32bd4250
PE
20942012-08-19 Paul Eggert <eggert@cs.ucla.edu>
2095
bad03192 2096 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
2097 as gnulib does this if the system doesn't.
2098 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
2099 Remove declaration. MS-Windows declares it on stdlib.h which is
2100 included by conf_post.h.
b69a6d22
PE
2101 * emacs.c (environ) [DOUG_LEA_MALLOC]:
2102 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
2103 * vm-limit.c: Include <unistd.h>, for 'environ'.
2104
22d7feb2
PE
2105 * unexaix.c, unexcoff.c: Include "mem-limits.h".
2106 (start_of_data): Remove decl; mem-limits.h provides it.
2107
32bd4250
PE
2108 * xdisp.c (handle_invisible_prop): Make it a bit faster
2109 and avoid a gcc -Wmaybe-uninitialized diagnostic.
2110
450809af
CY
21112012-08-19 Chong Yidong <cyd@gnu.org>
2112
2113 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
2114 ends (Bug#3874).
2115
9e677988
AS
21162012-08-19 Andreas Schwab <schwab@linux-m68k.org>
2117
6b1319ce
AS
2118 * .gdbinit: Use call instead of set when calling a function in the
2119 inferior.
2120
9e677988
AS
2121 * data.c (set_internal): Don't use set_blv_found.
2122 (Fkill_local_variable): Likewise.
2123
d7191076
AA
21242012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
2125
2126 * nsfont.m (ns_ascii_average_width): Ensure the string
2127 ascii_printable is initialized with a null-terminated character
2128 array. Otherwise, it can contain undesired extra characters.
2129
e757f1c6
PE
21302012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2131
2132 port new setting code to Sun C 5.8 2005/10/13
2133 * chartab.c, lisp.h (char_table_set, char_table_set_range):
2134 Return void, not Lisp_Object. Otherwise, the compiler
2135 complains about (A?B:C) where B is void and C is Lisp_Object
2136 when compiling CHAR_TABLE_SET, due to the recent change to
2137 the API of sub_char_table_set_contents.
2138
a999ce26
CY
21392012-08-18 Chong Yidong <cyd@gnu.org>
2140
2141 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
2142 for the string case (Bug#3874).
2143
3f22b86f
PE
21442012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2145
39eb03f1
PE
2146 * buffer.h (BSET): Remove (Bug#12215).
2147 Replace all uses with calls to new setter functions.
2148 (bset_bidi_paragraph_direction, bset_case_canon_table)
2149 (bset_case_eqv_table, bset_directory, bset_display_count)
2150 (bset_display_time, bset_downcase_table)
2151 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
2152 (bset_last_selected_window, bset_local_var_alist)
2153 (bset_mark_active, bset_point_before_scroll, bset_read_only)
2154 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
2155 (bset_width_table):
2156 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
2157 (bset_auto_fill_function, bset_auto_save_file_format)
2158 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
2159 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
2160 (bset_cache_long_line_scans, bset_case_fold_search)
2161 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
2162 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
2163 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
2164 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
2165 (bset_header_line_format, bset_indicate_buffer_boundaries)
2166 (bset_indicate_empty_lines, bset_invisibility_spec)
2167 (bset_left_fringe_width, bset_major_mode, bset_mark)
2168 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
2169 (bset_name, bset_overwrite_mode, bset_pt_marker)
2170 (bset_right_fringe_width, bset_save_length)
2171 (bset_scroll_bar_width, bset_scroll_down_aggressively)
2172 (bset_scroll_up_aggressively, bset_selective_display)
2173 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
2174 (bset_word_wrap, bset_zv_marker):
2175 * category.c (bset_category_table):
2176 * syntax.c (bset_syntax_table):
2177 New setter functions.
2178
6a09a33b
PE
2179 * process.h (PSET): Remove (Bug#12215).
2180 Replace all uses with calls to new setter functions.
2181 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2182 (PROCESS_INLINE): New macro.
2183 (pset_childp): New setter function.
2184 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
2185 * process.c (PROCESS_INLINE):
2186 Define to EXTERN_INLINE, so that the corresponding functions
2187 are compiled into code.
2188 (pset_buffer, pset_command, pset_decode_coding_system)
2189 (pset_decoding_buf, pset_encode_coding_system)
2190 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
2191 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
2192 (pset_type, pset_write_queue): New setter functions.
2193
e8c17b81
PE
2194 * window.h (WSET): Remove (Bug#12215).
2195 Replace all uses with calls to new setter functions.
2196 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2197 (WINDOW_INLINE): New macro.
2198 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
2199 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
2200 (wset_total_lines, wset_vertical_scroll_bar)
2201 (wset_window_end_pos, wset_window_end_valid)
2202 (wset_window_end_vpos): New setter functions.
2203 * window.c (WINDOW_INLINE):
2204 Define to EXTERN_INLINE, so that the corresponding functions
2205 are compiled into code.
2206 (wset_combination_limit, wset_dedicated, wset_display_table)
2207 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
2208 (wset_new_normal, wset_new_total, wset_next_buffers)
2209 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
2210 (wset_prev_buffers, wset_right_fringe_width)
2211 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
2212 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
2213 (wset_window_parameters):
2214 * xdisp.c (wset_base_line_number, wset_base_line_pos)
2215 (wset_column_number_displayed, wset_region_showing):
2216 New setter functions.
2217
3f22b86f
PE
2218 * termhooks.h (TSET): Remove (Bug#12215).
2219 Replace all uses with calls to new setter functions.
2220 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2221 (TERMHOOKS_INLINE): New macro.
2222 (tset_charset_list, tset_selection_alist): New setter functions.
2223 * terminal.c (TERMHOOKS_INLINE):
2224 Define to EXTERN_INLINE, so that the corresponding functions
2225 are compiled into code.
2226 (tset_param_alist): New setter function.
2227
742af32f
PE
22282012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2229
15dbb4d6
PE
2230 * keyboard.h (KSET): Remove (Bug#12215).
2231 Replace all uses with calls to new setter functions.
2232 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2233 (KEYBOARD_INLINE): New macro.
2234 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
2235 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
2236 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
2237 New setter functions.
2238 * keyboard.c (KEYBOARD_INLINE):
2239 Define to EXTERN_INLINE, so that the corresponding functions
2240 are compiled into code.
2241 (kset_echo_string, kset_kbd_queue)
2242 (kset_keyboard_translate_table, kset_last_prefix_arg)
2243 (kset_last_repeatable_command, kset_local_function_key_map)
2244 (kset_overriding_terminal_local_map, kset_real_last_command)
2245 (kset_system_key_syms): New setter functions.
2246
f00af5b1
PE
2247 * frame.h (FSET): Remove (Bug#12215).
2248 Replace all uses with calls to new setter functions.
2249 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2250 (FRAME_INLINE): New macro.
2251 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
2252 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
2253 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
2254 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
2255 (fset_param_alist, fset_root_window, fset_scroll_bars)
2256 (fset_selected_window, fset_title, fset_tool_bar_items)
2257 (fset_tool_bar_position, fset_tool_bar_window): New functions.
2258 * frame.c (FRAME_INLINE):
2259 Define to EXTERN_INLINE, so that the corresponding functions
2260 are compiled into code.
2261 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
2262
0c94c8d6
PE
2263 A few more naming-convention fixes for getters and setters.
2264 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
2265 and rename from buffer_overlays_set_before.
2266 (set_buffer_overlays_after): Move here from buffer.h, and rename
2267 from buffer_overlays_set_after.
2268 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
2269 All uses changed.
2270 (set_buffer_intervals): Rename from buffer_set_intervals.
2271 * intervals.c (set_interval_object): Move here from intervals.h,
2272 and rename from interval_set_object.
2273 (set_interval_left): Move here from intervals.h, and rename from
2274 interval_set_left.
2275 (set_interval_right): Move here from intervals.h, and rename from
2276 interval_set_right.
2277 (copy_interval_parent): Move here from intervals.h, and rename from
2278 interval_copy_parent.
2279 * intervals.h (set_interval_parent): Rename from interval_set_parent.
2280 (set_interval_plist): Rename from interval_set_plist.
2281 Return void, not Lisp_Object, since no caller uses the result.
2282 * lisp.h (string_intervals): Rename from string_get_intervals.
2283 (set_string_intervals): Rename from string_set_intervals.
2284
34dabdb7
PE
2285 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
2286 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 2287 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
2288 All uses changed. See the end of
2289 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
2290
742af32f
PE
2291 * lisp.h (CSET): Remove (Bug#12215).
2292 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
2293 (set_char_table_purpose): New functions,
2294 replacing CSET. All uses changed. For example, replace
2295 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 2296 "set_char_table_parent (char_table, parent);".
742af32f
PE
2297 The old version was confusing because it used the same name
2298 'parent' for two different things.
2299
a04e2c62
DA
23002012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2301
2302 Functions to get and set Lisp_Object fields of buffer-local variables.
2303 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
2304 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
2305 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
2306 * data.c, eval.c, frame.c: Adjust users.
2307
383dcbf9
CY
23082012-08-17 Chong Yidong <cyd@gnu.org>
2309
2310 * xfaces.c (merge_face_vectors): If the target font specfies a
2311 font spec, make the font's attributes take precedence over
2312 directly-specified attributes.
2313 (merge_face_ref): Recognize :font.
2314
44386687
DA
23152012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2316
2317 Do not use memcpy for copying intervals.
2318 * intervals.c (reproduce_interval): New function.
2319 (reproduce_tree, reproduce_tree_obj): Use it.
2320 (reproduce_tree_obj): Remove prototype.
2321
927c7216
PE
23222012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2323
2324 * lisp.h (duration_to_sec_usec): Remove unused decl.
2325
93044f7b
AA
23262012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
2327
2328 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
2329 to an allocated instance of NSString, not to the class itself.
2330
9851e4a5
JB
23312012-08-17 Juanma Barranquero <lekktu@gmail.com>
2332
2333 * makefile.w32-in (C_CTYPE_H): New macro.
2334 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
2335 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
2336 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
2337
620f13b0
PE
23382012-08-16 Paul Eggert <eggert@cs.ucla.edu>
2339
2340 Use ASCII tests for character types.
2341 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
2342 * xfns.c, xterm.c:
2343 Don't include <ctype.h>; was not needed.
2344 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
2345 * sysdep.c, xfaces.c:
2346 Include <c-ctype.h> instead of <ctype.h>.
2347 * nsterm.m: Include <c-ctype.h>.
2348 * charset.c (read_hex):
2349 * doc.c (Fsnarf_documentation):
2350 * fileio.c (IS_DRIVE) [WINDOWSNT]:
2351 (DRIVE_LETTER) [DOS_NT]:
2352 (Ffile_name_directory, Fexpand_file_name)
2353 (Fsubstitute_in_file_name):
2354 * font.c (font_parse_xlfd, font_parse_fcname):
2355 * frame.c (x_set_font_backend):
2356 * gtkutil.c (xg_get_font):
2357 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
2358 * nsimage.m (hexchar):
2359 * nsterm.m (ns_xlfd_to_fontname):
2360 * sysdep.c (system_process_attributes):
2361 * xfaces.c (hash_string_case_insensitive):
2362 Use C-locale tests instead of locale-specific tests for character
2363 types, since we want the ASCII interpretation here, not the
2364 interpretation suitable for whatever happens to be the current locale.
2365
52162052
MR
23662012-08-16 Martin Rudalics <rudalics@gmx.at>
2367
2368 Consistently check windows for validity/liveness
2369 (Bug#11984, Bug#12025, Bug#12026).
2370 * lisp.h (CHECK_VALID_WINDOW): New macro.
2371 * window.c (decode_window): Rename to decode_live_window.
2372 (decode_valid_window, Fwindow_valid_p): New functions.
2373 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
2374 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
2375 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
2376 (Fwindow_prev_sibling, Fwindow_combination_limit)
2377 (Fset_window_combination_limit, Fwindow_use_time)
2378 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
2379 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
2380 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
2381 (Fwindow_hscroll, Fset_window_hscroll)
2382 (Fwindow_redisplay_end_trigger)
2383 (Fset_window_redisplay_end_trigger, Fwindow_edges)
2384 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
2385 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2386 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
2387 (Fwindow_end, Fset_window_point, Fset_window_start)
2388 (Fpos_visible_in_window_p, Fwindow_line_height)
2389 (Fwindow_dedicated_p, Fset_window_dedicated_p)
2390 (Fwindow_prev_buffers, Fset_window_prev_buffers)
2391 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
2392 (Fset_window_parameter, Fwindow_display_table)
2393 (Fset_window_display_table, Fdelete_other_windows_internal)
2394 (Fset_window_buffer, Fset_window_new_total)
2395 (Fset_window_new_normal, Fdelete_window_internal)
2396 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
2397 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
2398 (Fwindow_scroll_bars): Check whether argument window is a valid or
2399 live window. Update doc-strings.
2400 (syms_of_window): New symbol Qwindow_valid_p.
2401 * keyboard.c (Fposn_at_x_y): Check whether argument
2402 frame_or_window denotes a valid window.
2403
2751c80f
DA
24042012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2405
2406 Fix previous char table change.
2407 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
2408 * chartab.c (optimize_sub_char_table): Likewise.
2409
032a42c8
CY
24102012-08-16 Chong Yidong <cyd@gnu.org>
2411
a2d19368
CY
2412 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
2413
032a42c8
CY
2414 * xfont.c (xfont_open):
2415 * xftfont.c (xftfont_open): Set the font's max_width field.
2416
2417 * nsfont.m (nsfont_open): Similar to the Xft backend, set
2418 min_width to space_width and average_width to the average over
2419 printable ASCII characters.
2420 (ns_char_width): Code cleanup.
2421 (ns_ascii_average_width): New utility function.
2422
2423 * font.h (struct font): Update comments.
2424
a098c930
DA
24252012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2426
032a42c8 2427 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
2428 * lisp.h (CSET): New macro.
2429 (char_table_set_extras, char_table_set_contents)
2430 (sub_char_table_set_contents): New function.
2431 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
2432 * syntax.c: Adjust users.
2433
8be3a09c
SM
24342012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
2435
2436 * eval.c (eval_sub): Bind lexical-binding.
2437 * lread.c (Qlexical_binding): Make non-static.
2438
ac4845a6
JD
24392012-08-15 Jan Djärv <jan.h.d@swipnet.se>
2440
ddee6515
JD
2441 * nsmenu.m (popupSession): Remove.
2442 (pop_down_menu): Remove endModalSession.
2443 (timeout_handler:): New method.
2444 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
2445 Call runModalForWindow. Check timer_fired when it returns.
2446 If not set, cancel timer and break out of loop.
2447 Otherwise loop again, with a new timeout.
2448
2449 * nsterm.m: Include fcntl.h if present.
2450 (fd_entry, t_readfds, inNsSelect): Remove.
2451 (select_writefds, select_valid, select_timeout, selfds)
2452 (select_mutex, apploopnr): Add.
2453 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
2454 Otherwise call kbd_buffer_store_event.
2455 (ns_send_appdefined): Remove release of fd_entry.
2456 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
2457 Increment and decrement apploopnr.
2458 (ns_select): If no file descriptors, just do a NSTimer.
2459 Otherwise copy read/write masks and start select thread (fd_handler).
2460 Start main loop and wait for application defined event.
2461 Inform select thread to stop selecting after main loop is exited.
2462 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 2463 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
2464 (fd_handler:): Loop forever, wait for info from the main thread
2465 to either start or stop selecting. When select returns, send
2466 and appdefined event.
2467 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
2468 If not call kbd_buffer_store_event.
2469
2470 * nsterm.h (EmacsApp): fd_handler takes id argument.
2471 (EmacsDialogPanel): Add timer_fired and timeout_handler.
2472
ac4845a6
JD
2473 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
2474
eb424fe3
EZ
24752012-08-15 Eli Zaretskii <eliz@gnu.org>
2476
2477 * region-cache.c (move_cache_gap): Update gap_len using the actual
2478 growth of the boundaries array. Do not change cache_len.
2479 (Bug#12196)
2480
4e6a86c6
DA
24812012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2482
2483 Generalize and cleanup font subsystem checks.
2484 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
2485 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
2486 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 2487
5bf192ca
DA
24882012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2489
2490 * gtkutil.c (xg_get_font): Use pango_units_to_double.
2491
f2045622
CY
24922012-08-15 Chong Yidong <cyd@gnu.org>
2493
8be3a09c
SM
2494 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
2495 When using the new font chooser, use gtk_font_chooser_get_font_desc to
2496 extract the font descriptor instead of just the font name.
2497 In that case, return a font spec instead of a string.
f2045622
CY
2498 (x_last_font_name): Move to this file from xfns.c.
2499
2500 * xfns.c (Fx_select_font): The return value can also be a font
2501 spec. Move x_last_font_name management to gtkutil.c.
2502
2503 * xfaces.c: Make font weight and style symbols non-static.
2504
7f6feb56
SM
25052012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
2506
2507 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
2508 (bug#12117).
2509
fecbd8ff
SM
25102012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
2511
2512 * alloc.c (Fgarbage_collect): Use plural form consistently.
2513
9b8d5165
EZ
25142012-08-14 Eli Zaretskii <eliz@gnu.org>
2515
2516 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
2517 iteration through the command loop. Fixes a problem whereby mouse
2518 movements are ignored until the first mouse click.
2519
f5d9e83a
PE
25202012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2521
2522 Use bool, not int, for Lisp booleans.
2523 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
2524 makes Emacs a bit smaller and presumably a bit faster.
2525 * lisp.h: Include <stdbool.h>.
2526 (struct Lisp_Boolfwd, defvar_bool):
2527 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
2528 * regex.c [!emacs]: Include <stdbool.h>.
2529 (false, true): Remove; <stdbool.h> does this for us now.
2530
55802e4a
CY
25312012-08-14 Chong Yidong <cyd@gnu.org>
2532
4abcdac8
CY
2533 * character.c (Fcharacterp): Doc fix (Bug#12076).
2534
2535 * data.c (Findirect_variable): Doc fix (Bug#11040).
2536
55802e4a
CY
2537 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
2538
2539 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 2540 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 2541
8e99d072
BR
25422012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2543
2544 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
2545 (bug#12022).
2546
08908aca
MR
25472012-08-14 Martin Rudalics <rudalics@gmx.at>
2548
2549 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
2550 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
2551 * minibuf.c (choose_minibuf_frame, read_minibuf):
2552 * w32fns.c (x_create_tip_frame):
2553 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
2554 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
2555
56120d6f
PE
25562012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2557
2558 * intervals.c (offset_intervals): Remove obsolete comment.
2559
67b77c0b
AS
25602012-08-14 Andreas Schwab <schwab@linux-m68k.org>
2561
2562 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
2563
f48b82fd
GR
25642012-08-14 Gergely Risko <gergely@risko.hu>
2565
2566 * coding.c (decode_coding): Record buffer modification before
2567 disabling undo_list (Bug#11773).
2568
fd318b54
DA
25692012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2570
2571 Revert and cleanup some recent overlay changes.
2572 * buffer.h (enum overlay_type): Remove.
2573 (buffer_get_overlays, buffer_set_overlays): Likewise.
2574 (buffer_set_overlays_before, buffer_set_overlays_after):
2575 New function. Adjust users.
2576 (unchain_both): Add eassert.
2577
41a62dd9
DA
25782012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2579
2580 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
2581
5884c324
PE
25822012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2583
2584 * gtkutil.c (xg_mark_data): Don't assume C99.
2585
ca06f160
JD
25862012-08-13 Jan Djärv <jan.h.d@swipnet.se>
2587
2588 * gtkutil.c (xg_frame_tb_info): New struct.
2589 (TB_INFO_KEY): New define.
2590 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
2591 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
2592 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
2593 if not present.
2594 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 2595 is up to date. Otherwise store new data.
ca06f160
JD
2596 (free_frame_tool_bar): Free xg_frame_tb_info if present.
2597
7864a3f7
DA
25982012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2599
2600 Use KSET for write access to Lisp_Object members of struct kboard.
2601 * keyboard.h (KSET): New macro.
2602 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
2603 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
2604 * xterm.c: Adjust users.
2605
4c31be61
DA
26062012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2607
2608 Use BSET for write access to Lisp_Object members of struct buffer.
2609 * buffer.h (BSET): New macro.
2610 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
2611 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
2612 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
2613 * window.c, xdisp.c, xfns.c: Adjust users.
2614
14ae4239
BT
26152012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
2616
2617 * lread.c (syms_of_lread): Initialize Vlexical_binding.
2618
32bcadb4
JD
26192012-08-11 Jan Djärv <jan.h.d@swipnet.se>
2620
3d29b2ce 2621 * nsterm.m (not_in_argv): New function.
fc0c31f8 2622 (application:openFile, application:openTempFile:):
3d29b2ce
JD
2623 (application:openFileWithoutUI:, application:openFiles:): Open file
2624 if not_in_argv returns non-zero (bug#12171).
2625
32bcadb4 2626 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
2627 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
2628 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
2629 (xg_get_font_name): Use those functions/macros here.
2630 Reported by Frans Oilinki <moilinki@gmail.com>.
2631
9ff9402d 26322012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
2633
2634 * unexmacosx.c (copy_data_segment): Copy initialized data in
2635 statically linked libraries from input file rather than memory.
2636
db74a5fc
YM
2637 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
2638 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
2639 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
2640
25e65510
GM
26412012-08-10 Glenn Morris <rgm@gnu.org>
2642
2643 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
2644 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
2645
7961135c
DA
26462012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2647
2648 Fix last change to allow compilation with low optimization levels.
2649 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
2650 Reported by Jan Djärv <jan.h.d@swipnet.se>.
2651
42b3a444
DA
26522012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2653
2654 Use common inline syntax in intervals.h.
2655 * intervals.h (INTERVALS_INLINE): New macro.
2656 Change all users from LISP_INLINE.
2657
9fb0c957
DA
26582012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2659
2660 Define Qnone once for all platforms.
2661 * frame.c (Qnone): Define here.
2662 (syms_of_frame): DEFSYM it.
2663 * lisp.h (Qnone): New declaration.
2664 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
2665 * xfns.c: Remove duplication. Adjust users.
2666
65e8ee52
DA
26672012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2668
2669 Remove unused macros from intervals.h.
2670 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
2671 * intervals.c: Adjust comment.
2672
9b855fd6
EZ
26732012-08-10 Eli Zaretskii <eliz@gnu.org>
2674
2675 * w32fns.c <w32_unicode_gui>: New static variable.
2676 (globals_of_w32fns): Initialize it according to os_subtype.
2677 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
2678 testing os_subtype.
2679
39cb9e56 26802012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
2681 Eli Zaretskii <eliz@gnu.org>
2682
2683 Fix bug #10299 with Unicode characters sent by customized
2684 keyboards created by MSKLC.
2685 * w32fns.c (INIT_WINDOW_CLASS): New macro.
2686 (w32_init_class): Use it to initialize the Emacs class with either
2687 ANSI or Unicode API calls.
2688 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
2689 later.
2690 (w32_wnd_proc): If the character code sent by WM_CHAR or
2691 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
2692 original message. Call DefWindowProcW on NT and later.
2693
9374581a
GM
26942012-08-10 Glenn Morris <rgm@gnu.org>
2695
4b94e8cf
GM
2696 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
2697
9374581a
GM
2698 * lisp.h (DIRECTORY_SEP): Let configure set it.
2699
a2752828
DA
27002012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2701
2702 Use TSET for write access to Lisp_Object slots of struct terminal.
2703 * termhooks.h (TSET): New macro.
2704 * coding.c, terminal.c, xselect.c: Adjust users.
2705
cc92c454
SM
27062012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
2707
2708 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
2709 the failing expression, include them in the error message.
2710 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
2711 * lisp.h (internal_condition_case_n): Update declaration.
2712
4cb3e6b3
DA
27132012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2714
2715 Inline functions to examine and change buffer overlays.
2716 * buffer.c (unchain_both): New function.
2717 * buffer.h (buffer_get_overlays, buffer_set_overlays):
2718 (buffer_has_overlays): New function.
2719 (enum overlay_type): New enum.
2720 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
2721 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
2722
8707c1e5
DA
27232012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2724
2725 Inline functions to examine and change buffer intervals.
2726 * alloc.c (mark_interval_tree): Remove.
2727 (MARK_INTERVAL_TREE): Simplify.
2728 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
2729 * intervals.c (buffer_balance_intervals): New function.
2730 (graft_intervals_into_buffer): Adjust indentation.
2731 (set_intervals_multibyte): Simplify.
2732 * buffer.h (BUF_INTERVALS): Remove.
2733 (buffer_get_intervals, buffer_set_intervals): New function.
2734 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
2735 * intervals.c, textprop.c: Adjust users.
2736
ad8c997f
DA
27372012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2738
2739 Inline functions to examine and change string intervals.
2740 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
2741 (string_get_intervals, string_set_intervals): New function.
2742 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2743 * lread.c, print.c, textprop.c: Adjust users.
2744
32ac3a6b
GM
27452012-08-08 Glenn Morris <rgm@gnu.org>
2746
2747 * lisp.mk (lisp): Remove language/persian.elc.
2748
77c7bcb1
DA
27492012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2750
2751 Cleanup intervals.
2752 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
2753 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
2754 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
2755 Adjust comment. Move under #if 0.
77c7bcb1
DA
2756 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2757 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
2758
9c08a8d4
DA
27592012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2760
2761 Check total length of intervals with eassert.
2762 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
2763 * intervals.c: Change all users to eassert.
2764
26d16b35
EZ
27652012-08-07 Eli Zaretskii <eliz@gnu.org>
2766
14ae4239
BT
2767 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
2768 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
2769 INTERNAL_FIELD in Lisp_Cons.
2770
c644523b
DA
27712012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2772
2773 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
2774 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
2775 name since all xname users are fixed long time ago. Do not
2776 use INTERNAL_FIELD.
2777 (set_symbol_name, set_symbol_function, set_symbol_plist):
2778 (set_symbol_next, set_overlay_plist): New function.
2779 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
2780 (struct Lisp_Overlay): Likewise.
2781 (CVAR, MVAR, SVAR): Remove.
2782 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
2783 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
2784 * xterm.c: Adjust users.
2785 * .gdbinit: Change to use name field of struct Lisp_Symbol
2786 where appropriate.
2787
6a3d20cc
DA
27882012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2789
2790 Basic functions to set Lisp_Object and pointer slots of intervals.
2791 * intervals.h (interval_set_parent, interval_set_object):
2792 (interval_set_left, interval_set_right, interval_set_plist):
2793 (interval_copy_parent): New function.
2794 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
2795 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
2796 Adjust indentation.
6a3d20cc
DA
2797 (INTERVAL_SIZE): Remove. Adjust users.
2798 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
2799
4d2b044c
DA
28002012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2801
2802 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
2803 * process.h (PGET): Remove.
2804 (struct Lisp_Process): Do not use INTERNAL_FIELD.
2805 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2806
d3d50620
DA
28072012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2808
2809 Drop WGET and revert read access to Lisp_Objects slots of struct window.
2810 * window.h (WGET): Remove.
2811 (struct window): Do not use INTERNAL_FIELD.
2812 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2813 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2814 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2815 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2816 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2817 Adjust users.
2818
d10a51dc
CY
28192012-08-07 Chong Yidong <cyd@gnu.org>
2820
2821 * window.c (Fwindow_edges, Fwindow_pixel_edges)
2822 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
2823 (Fdelete_window_internal): Signal an error if the window is not on
2824 a live frame (Bug#12025).
2825
e69b0960
DA
28262012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2827
2828 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
2829 * frame.h (FGET): Remove.
2830 (struct frame): Do not use INTERNAL_FIELD.
2831 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2832 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2833 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2834 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2835
25a20a3a
JB
28362012-08-06 Juanma Barranquero <lekktu@gmail.com>
2837
2838 * w32.c: Silence compiler warnings.
2839 (map_w32_filename): Remove unused variable `is_fat'.
2840 (chase_symlinks): Add parentheses around expression.
2841
1c6f11f4
GM
28422012-08-06 Glenn Morris <rgm@gnu.org>
2843
1db4583a
GM
2844 * sysdep.c: Respect BROKEN_GETWD.
2845
1c6f11f4
GM
2846 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
2847 Let configure handle it.
2848 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
2849
2b90362b
DA
28502012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2851
2852 Use GCALIGNMENT where appropriate.
2853 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
2854 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
2855 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
2856
5f50daf2
EZ
28572012-08-06 Eli Zaretskii <eliz@gnu.org>
2858
14ae4239
BT
2859 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
2860 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 2861
cbcc7007
SM
28622012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
2863
2864 * buffer.h (struct buffer): Revert `indirections' to a simple int;
2865 that should be sufficient for everyone.
2866
4d365fa4
JD
28672012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2868
2869 * keyboard.c (timer_check_2): Add break so timer_check returns next
2870 timeout.
2871
dd86bd82
DA
28722012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2873
2874 Fix Windows build errors introduced after converting to WGET and WSET.
2875 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
2876 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2877
054e1668
JD
28782012-08-06 Jan Djärv <jan.h.d@swipnet.se>
2879
2880 * nsterm.m (ns_frame_rehighlight): Use FSET.
2881
2882 * nsmenu.m (ns_update_menubar): Use FSET.
2883
21238f11
DA
28842012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2885
2886 Separate read and write access to Lisp_Object slots of Lisp_Process.
2887 * process.h (PGET, PSET): New macros similar to AREF and ASET.
2888 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2889
077288cf
DA
28902012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2891
2892 Separate read and write access to Lisp_Object slots of struct window.
2893 * window.h (WGET, WSET): New macros similar to AREF and ASET.
2894 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2895 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2896 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2897 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2898 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2899 Adjust users.
2900
71688bd7
DA
29012012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2902
2903 Fix Windows build errors introduced after converting to FGET and FSET.
2904 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
2905 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
2906 (w32_judge_scroll_bars): Change to use FSET.
2907 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
2908
f99bac93
DA
29092012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2910
2911 Fix replacement typo.
2912 * window.c (replace_window): Set root_window instead of
2913 selected_window. This fixes a total window subsystem
2914 malfunction reported by Bastien Guerry <bzg@gnu.org>.
2915
8c2a0f2d
GM
29162012-08-06 Glenn Morris <rgm@gnu.org>
2917
2918 * lisp.mk (lisp): Add language/persian.elc.
2919
edd74c35
DA
29202012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2921
2922 Separate read and write access to Lisp_Object slots of struct frame.
2923 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
2924 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2925 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2926 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2927 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2928
8671676c
AS
29292012-08-05 Andreas Schwab <schwab@linux-m68k.org>
2930
2931 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
2932
663e2b3f
DA
29332012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
2934
2935 Generalize common compile-time constants.
2936 * lisp.h (header_size, bool_header_size, word_size): Now here.
2937 (struct Lisp_Vector): Add comment.
2938 (struct Lisp_Bool_Vector): Move up to define handy constants.
2939 (VECSIZE, PSEUDOVECSIZE): Simplify.
2940 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
2941 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
2942 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
2943 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
2944 * xfont.c, xmenu.c: Use word_size where appropriate.
2945
d32e47af
LM
29462012-08-05 Lawrence Mitchell <wence@gmx.li>
2947
2948 * search.c (Freplace_match): Treat \? in the replacement text
2949 literally (Bug#8161).
2950
e5d9c0d1
CY
29512012-08-05 Chong Yidong <cyd@gnu.org>
2952
2953 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
2954 * frame.c (Vdelete_frame_functions):
2955 * emacs.c (Vkill_emacs_hook): Doc fix.
2956
8da0576b
EZ
29572012-08-04 Eli Zaretskii <eliz@gnu.org>
2958
2959 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
2960 --with-x-toolkit=no builds.
2961 Reported by Carsten Mattner <carstenmattner@gmail.com>.
2962
02676e5d
CY
29632012-08-04 Chong Yidong <cyd@gnu.org>
2964
2965 * syntax.c (Fmodify_syntax_entry): Doc fix.
2966
97147da9
EZ
29672012-08-04 Eli Zaretskii <eliz@gnu.org>
2968
76151e2c
EZ
2969 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
2970 * w32.c (init_environment): Change the default values of many
2971 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
2972 them into environment when they were not already defined.
2973 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 2974 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
2975 (check_windows_init_file): Now external, not static.
2976 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
2977 called when Vload_path is already set up.
2978
2979 * w32.h (check_windows_init_file): Add prototype.
2980
2981 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
2982 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
2983 compatibility with Posix platforms.
2984 (main): Move the call to check_windows_init_file to here from
2985 w32.c.
2986 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
2987 any, in the DEFALT argument into the root of the Emacs build or
2988 installation tree, as appropriate.
2989
2990 * callproc.c (init_callproc_1): Call decode_env_path instead of
2991 doing its equivalent by hand.
2992 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
2993 the code that sets Vexec_path run on MS-Windows.
2994
2995 * lread.c (init_lread): Add comments to #ifdef's.
2996
97147da9
EZ
2997 * msdos.c (dos_set_window_size, IT_update_begin)
2998 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
2999 instead of direct references.
3000
185ee146
PE
30012012-08-04 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 Export DEFAULT_REHASH_* to GDB.
3004 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
3005 Now constants, not macros.
3006
8834c57a
PE
30072012-08-03 Paul Eggert <eggert@cs.ucla.edu>
3008
98c6f1e3
PE
3009 Remove unnecessary casts involving pointers.
3010 These casts are no longer needed now that we assume C89 or later,
3011 since they involve casting to or from void *.
3012 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
3013 (make_pure_float, make_pure_vector):
3014 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
3015 * macros.c (Fstart_kbd_macro):
3016 * menu.c (find_and_return_menu_selection):
3017 * minibuf.c (read_minibuf_noninteractive):
3018 * sysdep.c (closedir):
3019 * xdisp.c (x_produce_glyphs):
3020 * xfaces.c (compare_fonts_by_sort_order):
3021 * xfns.c (x_real_positions, select_visual):
3022 * xselect.c (x_stop_queuing_selection_requests)
3023 (x_get_window_property, x_get_window_property_as_lisp_data):
3024 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
3025 Remove unnecessary pointer casts.
3026 * alloc.c (record_xmalloc): New function.
3027 * lisp.h (record_xmalloc): New decl.
3028 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
3029 more like a function. This is because the pointer cast is not
3030 needed. All uses changed.
3031 * print.c (print_string, print_error_message): Avoid length recalc.
3032
8834c57a
PE
3033 Improve fix for macroexp crash with debugging (Bug#12118).
3034 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
3035 ARRAY_MARK_FLAG when checking subscripts, because ASET is
3036 not supposed to be invoked from the garbage collector.
3037 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
3038 (gc_aset): New function, which is like ASET but can be
3039 used in the garbage collector.
3040 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3041 (set_hash_index): Use it instead of ASET.
3042
6dad7178
EZ
30432012-08-03 Eli Zaretskii <eliz@gnu.org>
3044
3045 Support symlinks on latest versions of MS-Windows.
3046 * w32.c: Include winioctl.h and aclapi.h.
3047 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
3048 (revert_to_self): Forward declarations of static functions.
3049 <static BOOL g_b_init_get_security_info>:
3050 <g_b_init_create_symbolic_link>: New static flags.
3051 (globals_of_w32): Initialize them to zero.
3052 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
3053 (map_w32_filename): Improve commentary. Simplify switch.
3054 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
3055 headers (most versions of MinGW w32api don't).
3056 (get_security_info, create_symbolic_link)
3057 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
3058 New functions.
3059 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
3060 in the argument file name.
3061 (sys_access): Call unc_volume_file_attributes only if
3062 GetFileAttributes fails with network-related error codes.
3063 (sys_rename): Diagnose renaming of a symlink when the user doesn't
3064 have the required privileges.
14ae4239 3065 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
3066 get_file_security_desc.
3067 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
3068 with addition of handling of symlinks and support for 'lstat'.
3069 If possible, get file's attributes and security information by
6dad7178
EZ
3070 handle, not by name. Produce S_IFLNK bit for symlinks, when
3071 called from 'lstat'.
3072 (stat, lstat): New functions, call 'stat_worker'.
3073 (symlink, readlink, careadlinkat): Rewritten to create and resolve
3074 symlinks when the underlying filesystem supports them.
3075
f162bcc3
PE
30762012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3077
79ea6c20
PE
3078 Fix macroexp crash on Windows with debugging (Bug#12118).
3079 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
3080 checking subscripts; problem introduced with the recent
3081 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
3082 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
3083 since it's used in non-static inline functions now.
3084
c0ce93fd
PE
3085 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
3086 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 3087
f162bcc3
PE
3088 Use C99-style 'extern inline' if available.
3089 * buffer.h (BUFFER_INLINE):
3090 * category.h (CATEGORY_INLINE):
3091 * character.h (CHARACTER_INLINE):
3092 * charset.h (CHARSET_INLINE):
3093 * composite.h (COMPOSITE_INLINE):
3094 * dispextern.h (DISPEXTERN_INLINE):
3095 * lisp.h (LISP_INLINE):
3096 * systime.h (SYSTIME_INLINE):
3097 New macro, replacing 'static inline' in this header.
3098 * buffer.h, category.h, character.h, charset.h, composite.h:
3099 * dispextern.h, lisp.h, systime.h:
3100 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3101 * alloc.c (LISP_INLINE):
3102 * buffer.c (BUFFER_INLINE):
3103 * category.c (CATEGORY_INLINE):
3104 * character.c (CHARACTER_INLINE):
3105 * charset.c (CHARSET_INLINE):
3106 * composite.c (COMPOSITE_INLINE):
3107 * dispnew.c (DISPEXTERN_INLINE):
3108 * sysdep.c (SYSTIME_INLINE):
3109 Define to EXTERN_INLINE, so that the corresponding functions
3110 are compiled into code.
3111 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
3112 (INLINE_HEADER_END): New macros.
3113 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
3114 since it's used in non-static inline functions now.
a8333d03 3115 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 3116
837b365b
GM
31172012-08-02 Glenn Morris <rgm@gnu.org>
3118
d66b744d
GM
3119 * s/: Remove empty directory.
3120
837b365b
GM
3121 * s/ms-w32.h: Move to ../nt/inc.
3122 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
3123 Update for new ms-w32.h location.
3124
13294f95
PE
31252012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3126
3127 Port to Solaris 8.
3128 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
3129
90df0db3
GM
31302012-08-02 Glenn Morris <rgm@gnu.org>
3131
3132 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
3133 hard-coding the path separator.
3134
4939150c
PE
31352012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3136
3137 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
3138 This how ASET and AREF are supposed to work, and makes
3139 it easier to think about future improvements. See
3140 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
3141 * charset.h (set_charset_attr): New function.
3142 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
3143 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
3144 (aref_addr): New function. All uses of &AREF(...) changed.
3145 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3146 (set_hash_index): New functions. All lvalue-style uses of
3147 HASH_KEY etc. changed.
3148 * keyboard.c (set_prop): New function. All lvalue-style uses
3149 of PROP changed.
3150
947b2afd
AA
31512012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
3152
3153 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
3154 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
3155 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
3156 * nsfns.m (ns_set_name_as_filename): Likewise.
3157 * nsmenu.m (ns_update_menubar): Likewise.
3158 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
3159
4f5d0325
EZ
31602012-08-01 Eli Zaretskii <eliz@gnu.org>
3161
2008beae
EZ
3162 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
3163 Adapt to latest changes in field names of the corresponding Lisp
288479f6 3164 objects.
2008beae 3165
4f5d0325
EZ
3166 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
3167
fe3cc771
GM
31682012-08-01 Glenn Morris <rgm@gnu.org>
3169
3170 * s/msdos.h: Remove file.
3171 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
3172 * Makefile.in (S_FILE): Remove.
3173 (config_h): Remove S_FILE.
3174
c90acc54
JB
31752012-08-01 Juanma Barranquero <lekktu@gmail.com>
3176
3177 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
3178 Remove; moved to nt/config.nt.
3179
d8a05828
DA
31802012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3181
3182 Use INTERNAL_FIELD for conses and overlays.
3183 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
3184 Remove obsolete comment.
3185 (MVAR): New macro.
3186 (struct Lisp_Overlay): Use INTERNAL_FIELD.
3187 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
3188
8271d590
DA
31892012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3190
3191 Use INTERNAL_FIELD for symbols.
3192 * lisp.h (SVAR): New macro. Adjust users.
3193 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
3194 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
3195
3193acd2
DA
31962012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3197
3198 Use INTERNAL_FIELD for processes.
3199 * process.h (PVAR): New macro. Adjust style.
3200 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
3201 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
3202
3a45383a
DA
32032012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3204
3205 Use INTERNAL_FIELD for windows.
3206 * window.h (WVAR): New macro.
3207 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
3208 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3209 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3210 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
3211 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
3212 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3213
c1dbc63c
PE
32142012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3215
3216 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
3217
5c0c0e8a
GM
32182012-08-01 Glenn Morris <rgm@gnu.org>
3219
3220 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
3221 Move to configure.ac.
3222
552a99b4
JB
32232012-08-01 Juanma Barranquero <lekktu@gmail.com>
3224
3225 * makefile.w32-in (CONFIG_H): Update dependencies.
3226 (CONF_POST_H): New macro.
3227
3228 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
3229
8d8e2dfe
GM
32302012-07-31 Glenn Morris <rgm@gnu.org>
3231
bc96620a
GM
3232 * Makefile.in (S_FILE): No longer set by configure.
3233
476b1b2d
GM
3234 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
3235 is available.
3236 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
3237
b2c7a106
GM
3238 * process.h (NULL_DEVICE):
3239 * emacs.c (SEPCHAR):
3240 * editfns.c (USER_FULL_NAME): Let configure set them.
3241
d53d062a
GM
3242 * s/README, s/template.h: Remove files.
3243
4515017f
GM
3244 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
3245
8d8e2dfe
GM
3246 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
3247 Move to configure.ac.
3248
5b20b3cc
EZ
32492012-07-31 Eli Zaretskii <eliz@gnu.org>
3250
1e0afd9a
EZ
3251 * .gdbinit (xframe): Adapt to introduction of FVAR and the
3252 resulting renaming of 'struct frame' members.
3253
5b20b3cc
EZ
3254 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
3255
3256 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
3257 after introduction of FVAR.
3258
f1310128
JD
32592012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3260
79e721e0
JD
3261 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
3262
3263 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
3264 instead of compositeToPoint.
3265 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
3266
8d7c7eed 3267 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 3268
e34f7f79
DA
32692012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3270
3271 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
3272 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 3273 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
3274 (BVAR): Change to use INTERNAL_FIELD.
3275 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
3276 (KVAR): Change to use INTERNAL_FIELD.
3277 * frame.h (FVAR): New macro.
3278 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
3279 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
3280 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
3281 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
3282 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3283
c09bfb2f
DA
32842012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3285
3286 Miscellaneous fixes for non-default X toolkits.
3287 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
3288 * xterm.c (x_frame_of_widget): Remove redundant prototype.
3289 Move under #ifdef USE_LUCID.
3290 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
3291 definition and usage to avoid warnings.
3292
14c114ae
JD
32932012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3294
3295 * nsterm.m (openFiles): Fix previous checkin.
3296
3bd21e82
PE
32972012-07-31 Paul Eggert <eggert@cs.ucla.edu>
3298
3299 * indent.c (compute_motion): Remove unused local.
3300
c1529ded
GM
33012012-07-31 Glenn Morris <rgm@gnu.org>
3302
400d5621
GM
3303 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
3304
268e2432
GM
3305 * conf_post.h [USG5_4]:
3306 Move remaining contents of s/usg5-4-common.h here.
3307 * s/usg5-4-common.h: Remove file.
3308
7552f3ee
GM
3309 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
3310 * s/irix6-5.h: Remove file.
3311
6a381852
GM
3312 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
3313 * s/darwin.h: Remove file.
3314
c1529ded
GM
3315 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
3316 * s/hpux10-20.h: Remove file, which is now empty.
3317
b429a4ee
GM
33182012-07-30 Glenn Morris <rgm@gnu.org>
3319
3320 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
3321 * Makefile.in (config_h): Add conf_post.h.
3322 * makefile.w32-in (CONFIG_H): Add conf_post.h.
3323
adff3182
JD
33242012-07-30 Jan Djärv <jan.h.d@swipnet.se>
3325
3326 * nsterm.m (ns_do_open_file): New variable.
b9031d69 3327 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
3328 (openFile, openTempFile, openFileWithoutUI, openFiles):
3329 Open files only if ns_do_open_file.
adff3182 3330
c32af1e4
PE
33312012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3332
7393bcbb
PE
3333 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
3334 This no-op macro hasn't been needed for many years.
3335 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
3336
c32af1e4
PE
3337 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
3338 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
3339 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
3340 gdb_make_enums_visible.
3341 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
3342 (DIRECTORY_SEP): Now a constant, not a macro.
3343
302fc036
EZ
33442012-07-30 Eli Zaretskii <eliz@gnu.org>
3345
3346 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
3347 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
3348
3349 * w32term.c <w32_keyboard_codepage>: Renamed from
3350 keyboard_codepage and now external. All users changed.
3351
3352 * w32term.h: Add declaration of w32_keyboard_codepage.
3353
3354 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
3355 the codepage to translate keys to Unicode. If this argument is
3356 -1, use the value returned by GetConsoleCP. All callers changed.
3357
88fb40b4
PE
33582012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3359
0aee6912
PE
3360 Update .PHONY listings in makefiles.
3361 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
3362 bootstrap-clean, distclean, maintainer-clean, versioclean,
3363 extraclean, frc.
3364
88fb40b4
PE
3365 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
3366 This is a bit clearer. Fix some commentary typos.
3367
0a763bd1
GM
33682012-07-30 Glenn Morris <rgm@gnu.org>
3369
32bac6d6
GM
3370 * s/netbsd.h: Let configure include signal.h if needed.
3371 Remove file, which is now empty.
3372
b65e7c46
GM
3373 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
3374 Let configure set them.
3375 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
3376 No more need to undefine.
0a763bd1 3377
169304bd
AS
33782012-07-30 Andreas Schwab <schwab@linux-m68k.org>
3379
3380 * keymap.c (Fkey_description): Don't remove 0x80 bit from
3381 non-single-byte char when adding meta modifier. (Bug#12090)
3382
6cd7a139
DA
33832012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3384
3385 Convert safe_call to use variable number of arguments.
3386 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
3387 (safe_call2): Fix comment.
3388 * lisp.h (safe_call): Adjust prototype.
3389 * coding.c (encode_coding_object): Change to use safe_call2.
3390 * xfaces.c (merge_face_heights): Change to use safe_call1.
3391
d34d6ffc
GM
33922012-07-30 Glenn Morris <rgm@gnu.org>
3393
7b8a48e4 3394 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 3395 does that unconditionally. Remove file, which is now empty.
7b8a48e4 3396
d34d6ffc
GM
3397 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
3398 Remove empty files.
3399
03a660a6
PE
34002012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3401
3402 Export to GDB most of lisp.h's remaining object-like macros.
3403 * lisp.h (min, max): Move earlier, because they're used earlier now.
3404 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
3405 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
3406 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
3407 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
3408 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
3409 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
3410 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
3411 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
3412 Now constants, for GDB. They need not be macros.
3413 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
3414 Now constants, for GDB, as well as macros, for static initializers.
3415 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
3416 Move to after the definition of struct Lisp_Char_Table,
3417 since the former now needs that type defined.
3418 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
3419 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
3420 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
3421 New enums, for gdb_make_enums_visible.
3422 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 3423 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
3424 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
3425 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
3426 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
3427 enum maxargs, enum MAX_ALLOCA.
3428 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
3429 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
3430 no longer needed, now that they are done in lisp.h.
3431
e499d0ee
DA
34322012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3433
3434 Cleanup string bytes checking.
3435 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
3436 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
3437 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
3438 (check_sblock, compact_small_strings): Simplify.
3439
d5040d2d
PE
34402012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3441
3442 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
3443 These macros are confusing and no longer need to be defined, as
3444 the enum values now suffice. All uses replaced with definiens.
3445 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
3446
7f259ae6
JB
34472012-07-29 Juanma Barranquero <lekktu@gmail.com>
3448
3449 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
3450 ($(BLD)/w32console.$(O)): Update dependencies.
3451
7e63e0c3
DA
34522012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3453
3454 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
3455 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
3456 time. Adjust users.
3457 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
3458
ffd817eb
JD
34592012-07-29 Jan Djärv <jan.h.d@swipnet.se>
3460
3461 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
3462 setting sitelisp (Bug#12010).
3463
417a7a0e
EZ
34642012-07-29 Eli Zaretskii <eliz@gnu.org>
3465
14ae4239 3466 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
3467
3468 * w32heap.c (cache_system_info):
3469 * w32.c (sys_rename):
3470 * w32proc.c (find_child_console, sys_kill): All users changed.
3471
387d4d92
PE
34722012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3473
3474 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
3475
55a6cca6
EZ
34762012-07-29 Eli Zaretskii <eliz@gnu.org>
3477
3478 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
3479
dbcf001c
DA
34802012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3481
3482 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
3483 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
3484 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 3485
e2688e4a
DA
34862012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3487
3488 Generalize marker debugging code under MARKER_DEBUG and use eassert.
3489 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
3490 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
3491 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
3492 (replace_range, replace_range_2, del_range_2): Change to eassert.
3493 * marker.c (byte_char_debug_check): Adjust style.
3494
b46a6a83
PE
34952012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3496
3497 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
3498 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
3499 long-ago-commented-out code that talks about "WIN32".
3500 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
3501 All uses changed.
3502
e32a5799
PE
35032012-07-28 Paul Eggert <eggert@cs.ucla.edu>
3504
3505 Use Gnulib stdalign module (Bug#9772, Bug#9960).
3506 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
3507 Simplify by using alignof.
3508 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
3509 * lisp.h: Include <stdalign.h>.
3510 (GCALIGNMENT): New macro and constant.
3511 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
3512 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
3513 (stdalign): New macro, if not already defined.
3514
df81cd29
EZ
35152012-07-28 Eli Zaretskii <eliz@gnu.org>
3516
01bd1b0d
EZ
3517 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
3518 * w32inevt.c: Include w32inevt.h.
3519 (w32_read_console_input): New inline function, calls either
3520 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
3521 w32_console_unicode_input.
3522 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
3523 (w32_kbd_patch_key, key_event): Use the codepage returned by
3524 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
3525 (key_event): use uChar.UnicodeChar only if
3526 w32_console_unicode_input is non-zero.
3527
3528 * w32console.c: Include w32heap.h.
3529 <w32_console_unicode_input>: New global variable.
3530 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
3531 family of Windows, zero otherwise.
3532
3533 * w32inevt.h: Declare w32_console_unicode_input.
3534
df81cd29
EZ
3535 * xdisp.c (init_iterator): Don't reference tip_frame in a build
3536 --without-x. (Bug#11742)
3537
c20fdd9e
PE
35382012-07-27 Paul Eggert <eggert@cs.ucla.edu>
3539
3540 Adjust GDB to reflect pvec_type changes (Bug#12036).
3541 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
3542 2012-07-04 changes to pseudovector representation.
3543 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 3544
32770973 35452012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
3546
3547 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
3548 bus address.
3549 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
3550
3438fe21
EZ
35512012-07-27 Eli Zaretskii <eliz@gnu.org>
3552
bcfbc9de
EZ
3553 * alloc.c (listn): Fix the order the arguments are consed onto the
3554 list.
3555
3438fe21
EZ
3556 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
3557 enumeration constants, as PURE and HEAP are too general, and clash
3558 with other headers and sources, such as gmalloc.c and the
3559 MS-Windows system headers. All users changed.
3560
eeaea515
DA
35612012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3562
3563 Revert last save_excursion_save and save_excursion_restore changes.
3564 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
3565 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
3566
073c88c2
DA
35672012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3568
3569 Fix recently-introduced typos in Windows port.
3570 Reported by Martin Rudalics <rudalics@gmx.at>.
3571 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 3572 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 3573
4706125e
PE
35742012-07-27 Paul Eggert <eggert@cs.ucla.edu>
3575
3576 Improve GDB symbol export (Bug#12036).
3577 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
3578 arms of an 'if', not using conditional expressions; otherwise GDB
3579 complains about the types in the unevaluated arm when the argument
3580 is an integer literal.
3581 (xgetint): Simplify expression.
3582 * alloc.c (gdb_make_enums_visible): New constant. This ports to
3583 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
3584 Zaretskii in <http://bugs.gnu.org/12036#13>.
3585 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
3586 needed now that we have gdb_make_enums_visible.
3587 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
3588 (enum enum_USE_LSB_TAG):
3589 New enum types, packaging up enums that need to be exported to GDB.
3590
694b6c97
DA
35912012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3592
3593 Utility function to make a list from specified amount of objects.
3594 * lisp.h (enum constype): New datatype.
3595 (listn): New prototype.
3596 * alloc.c (listn): New function.
3597 (Fmemory_use_count, syms_of_alloc): Use it.
3598 * buffer.c (syms_of_buffer): Likewise.
3599 * callint.c (syms_of_callint): Likewise.
3600 * charset.c (define_charset_internal): Likewise.
3601 * coding.c (syms_of_coding): Likewise.
3602 * keymap.c (syms_of_keymap): Likewise.
3603 * search.c (syms_of_search): Likewise.
3604 * syntax.c (syms_of_syntax): Likewise.
3605 * w32.c (init_environment): Likewise.
3606 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
3607 * xdisp.c (syms_of_xdisp): Likewise.
3608 * xfns.c (syms_of_xfns): Likewise.
3609
6195f384
DA
36102012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3611
3612 Fast save_excursion_save and save_excursion_restore.
3613 * lisp.h (struct Lisp_Excursion): New data type.
3614 (PVEC_EXCURSION): New pseudovector type.
3615 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
3616 to deal with it. Adjust comments.
3617 (init_marker, attach_marker): New prototype.
3618 (unchain_marker): Adjust prototype.
3619 * marker.c (attach_marker): Change to global.
3620 (init_marker): New function.
3621 * alloc.c (Fmake_marker, build_marker): Use it.
3622 (build_marker): More easserts.
3623 (mark_object): Handle struct Lisp_Excursion.
3624 * editfns.c (save_excursion_save, save_excursion_restore):
3625 Reimplement to use struct Lisp_Excursion. Add comments.
3626
5eceb8fb
PE
36272012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3628
3629 Fix export of symbols to GDB (Bug#12036).
3630 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
3631 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
3632 emacs.c, as this is a more-suitable home. Had this been done earlier
3633 the fix for 12036 would have avoided some of the problems noted in
3634 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
3635 would have been more obvious.
562157c8
PE
3636 * emacs.c: Do not include <verify.h>; no longer needed.
3637 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
3638 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
3639 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
3640 Remove; now done in lisp.h.
3641 * lisp.h (PUBLISH_TO_GDB): New macro.
3642 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
3643 (DATA_SEG_BITS): Use it.
3644 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
3645 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
3646 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
3647 not be usable in #if. This simplifies things.
3648
d6749401
JB
36492012-07-26 Juanma Barranquero <lekktu@gmail.com>
3650
3651 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
3652
1781b9e9
PE
36532012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3654
d89518db 3655 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
3656 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
3657 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
3658 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
3659 Adjust to changes in lisp.h and emacs.c, by using
3660 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
3661 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
3662 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
3663 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
3664 instead of gdb_valbits.
3665 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
3666 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
3667 instead of gdb_array_mark_flag.
3668 (xboolvector): Get size from $->size, not $->header.size.
3669 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
3670 (xreload, hook-run, hookpost-run): Remove.
3671 * emacs.c: Include <verify.h>.
3672 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
3673 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
3674 Remove.
3675 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
3676 (gdb_USE_LSB_TAG): New enum constants.
3677 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
3678 Also define these as enum constants, so they're visible to GDB.
3679 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
3680 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
3681 as constants, so they're visible to GDB.
3682 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
3683 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
3684 Now enum constants, not macros, so they're visible to GDB.
3685 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
3686 more convenient now. All uses changed.
3687 (VALMASK) [USE_LSB_TAG]: Also define in this case.
3688 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
3689
3628596a
DA
36902012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
3691
3692 Explicitly free restriction data that are not needed anymore.
3693 * editfns.c (save_restriction_restore): Free restriction data.
3694
7abaf5cc
SM
36952012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
3696
3697 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
3698 add argument, tune behavior, and adjust all callers.
3699
71f88e00
PE
37002012-07-25 Paul Eggert <eggert@cs.ucla.edu>
3701
3702 Use typedef for EMACS_INT, EMACS_UINT.
3703 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
3704 than macros. This simplifies debugging in the usual case, since
3705 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
3706 and it allows expressions involving EMACS_INT casts.
3707 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
3708
57ec3034
JD
37092012-07-25 Jan Djärv <jan.h.d@swipnet.se>
3710
3711 * nsterm.m (ns_read_socket): Return early if there is a modal
3712 window (Bug#12043).
3713
8137e7b3
MR
37142012-07-25 Martin Rudalics <rudalics@gmx.at>
3715
3716 * frame.c (Fredirect_frame_focus): In doc-string don't mention
3717 that FOCUS-FRAME can be omitted.
3718
04e9897c
DA
37192012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
3720
3721 Adjust buffer text indirection counters at the end of Fkill_buffer.
3722 * buffer.c (Fkill_buffer): Adjust indirection counters when the
3723 buffer is definitely dead. This should really fix an issue reported
3724 by Christoph Scholtes again. (Bug#12007).
3725 (init_buffer_once): Initialize indirection counters of
3726 buffer_defaults and buffer_local_symbols (for sanity and safety).
3727
8a0484e1
EZ
37282012-07-24 Eli Zaretskii <eliz@gnu.org>
3729
3730 * xdisp.c (init_iterator): Don't compute dimensions of truncation
3731 and continuation glyphs on tooltip frames, leave them at zero.
3732 Avoids continued lines in tooltips. (Bug#11832)
3733
fa691a83
DA
37342012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
3735
3736 Simplify copy_overlay.
04e9897c 3737 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
3738 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
3739
436bc8e0
EZ
37402012-07-23 Eli Zaretskii <eliz@gnu.org>
3741
3742 * print.c (print_object): Don't crash when a frame's name is nil
3743 or invalid. (Bug#12025)
3744
3745 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
3746 it signals an error when a tooltip frame is being created.
3747
d7a7fda3
DA
37482012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
3749
3750 Cleanup miscellaneous objects allocation and initialization.
3751 * alloc.c (allocate_misc): Change to static. Add argument to
3752 specify the subtype. Adjust comment and users.
3753 (build_overlay): New function.
3754 * buffer.c (copy_overlays, Fmake_overlay): Use it.
3755 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
3756 (allocate_misc): Remove prototype.
3757 (build_overlay): Add prototype.
3758
37592012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
3760
3761 Swap buffer text indirection counters in Fbuffer_swap_text.
3762 * buffer.c (Fbuffer_swap_text): Swap indirections too.
3763 This avoids crash reported by Christoph Scholtes at
3764 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
3765
9d7fa573
JD
37662012-07-22 Jan Djärv <jan.h.d@swipnet.se>
3767
3768 * nsmenu.m (Popdown_data): New struct.
3769 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
3770 free Popdown_data.
3771 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
3772 (initWithContentRect): Make imgView and contentView non-static
3773 and autorelease them. Also autorelease img and matrix (Bug#12005).
3774 (dealloc): Remove (Bug#12005).
3775
0dd6d66d
DA
37762012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3777
3778 Adjust consing_since_gc when objects are explicitly freed.
3779 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
3780 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
3781 (free_cons, free_misc): Subtract object size from consing_since_gc.
3782
d36d71df
DA
37832012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3784
3785 Simplify and cleanup markers positioning code.
3786 * marker.c (attach_marker): More useful eassert.
3787 (live_buffer, set_marker_internal): New function.
3788 (Fset_marker, set_marker_restricted): Use set_marker_internal.
3789 (set_marker_both, set_marker_restricted_both): Use live_buffer.
3790
fb9ea40f
PE
37912012-07-22 Paul Eggert <eggert@cs.ucla.edu>
3792
3793 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
3794 as it's limited by the amount of memory, not by INT_MAX.
3795
2d5c5f7d
EZ
37962012-07-21 Eli Zaretskii <eliz@gnu.org>
3797
07fb592e
EZ
3798 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
3799 in special-event-map. See the discussion at
3800 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
3801 for the reasons.
3802
37a9eac8 3803 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
3804 info.dwItemData. Fixes crashes on 64-bit Windows.
3805 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 3806
c4328746
JD
38072012-07-21 Jan Djärv <jan.h.d@swipnet.se>
3808
fc0c31f8 3809 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 3810 (conversationIdentifier): Return value is NSInteger.
784051c4 3811 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 3812
6e5d1c12
CY
38132012-07-21 Chong Yidong <cyd@gnu.org>
3814
3815 * window.c (decode_any_window): Signal an error if the window is
3816 on a dead frame (Bug#11984).
3817
9928463d
DA
38182012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3819
3820 Add indirection counting to speed up Fkill_buffer.
3821 * buffer.h (struct buffer): New member.
3822 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
3823 (Fmake_indirect_buffer): Set indirection counter to -1, increment
3824 base buffer indirection counter.
3825 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
3826 (Fkill_buffer): Adjust indirection counters as needed, don't walk
3827 through buffer list if indirection counter is 0.
3828
f8643a6b
DA
38292012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3830
3831 Extend the value returned by Fgarbage_collect with heap statistics.
3832 * alloc.c (Qheap): New symbol.
3833 (syms_of_alloc): DEFSYM it.
3834 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
3835 (Fmemory_free): Remove.
3836 (syms_of_alloc): Don't defsubr it.
3837 * buffer.c (Fcompact_buffer): Remove.
3838 (syms_of_buffer): Don't defsubr it.
3839
dac616ff
DA
38402012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3841
3842 Make maybe_gc inline.
3843 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
3844 * lisp.h (consing_since_gc, gc_relative_threshold)
3845 (memory_full_cons_threshold): Revert declaration.
3846 (maybe_gc): Remove prototype, define as inline.
3847 * alloc.c: Remove old commented-out code.
3848 (consing_since_gc, gc_relative_threshold)
3849 (memory_full_cons_threshold): Revert to global.
3850 (maybe_gc): Remove.
3851
d7ea76b4
DA
38522012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3853
3854 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
3855 * lisp.h (build_unibyte_string): New function.
3856 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
3857 * sysdep.c, w32fns.c, xfns.c: Use it.
3858 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
3859 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
3860 Adjust users accordingly.
3861 * font.h (font_open_by_name): Adjust prototype.
3862
765e61e3
DA
38632012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3864
3865 Cleanup calls to Fgarbage_collect.
3866 * lisp.h (maybe_gc): New prototype.
3867 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3868 Remove declarations.
3869 * alloc.c (maybe_gc): New function.
3870 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
3871 Make them static.
3872 * bytecode.c (MAYBE_GC): Use maybe_gc.
3873 * eval.c (eval_sub, Ffuncall): Likewise.
3874 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
3875 to avoid dependency from auto-save feature.
3876
52b852c7
PE
38772012-07-19 Paul Eggert <eggert@cs.ucla.edu>
3878
3879 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
3880 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
3881 'for_each_per_buffer_object_at'.
3882 All uses changed. It's better to use upper-case for macros that
3883 cannot be implemented as functions, to give the reader a clue
3884 that they're special.
3885
5db81e33
SM
38862012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
3887
3888 * alloc.c (Fgarbage_collect): Tweak docstring.
3889
5b835e1d
DA
38902012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3891
3892 Tweak the value returned from Fgarbage_collect again.
3893 * alloc.c (Fgarbage_collect): New return value, as confirmed in
3894 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
3895 Adjust documentation.
3896 (total_vector_bytes): Rename to total_vector_slots, adjust
3897 accounting.
3898 (total_free_vector_bytes): Rename to total_free_vector_slots,
3899 adjust accounting.
3900 (Qstring_bytes, Qvector_slots): New symbols.
3901 (syms_of_alloc): DEFSYM them.
3902
9cd47b72
DA
39032012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3904
3905 Buffer compaction primitive which may be used from Lisp.
3906 * buffer.c (compact_buffer, Fcompact_buffer): New function.
3907 (syms_of_buffer): Register Fcompact_buffer.
3908 * alloc.c (Fgarbage_collect): Use compact_buffer.
3909 * buffer.h (compact_buffer): New prototype.
3910 (struct buffer_text): New member.
3911
d17337e5
DA
39122012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
3913
3914 New macro to iterate over all buffers, miscellaneous cleanups.
3915 * lisp.h (all_buffers): Remove declaration.
3916 * buffer.h (all_buffers): Add declaration, with comment.
3917 (for_each_buffer): New macro.
3918 * alloc.c (Fgarbage_collect, mark_object): Use it.
3919 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
3920 (init_buffer): Likewise.
3921 * data.c (Fset_default): Likewise.
3922 * coding.c (code_conversion_restore): Remove redundant check
3923 for dead buffer.
3924 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
3925
60cfd278
AS
39262012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3927
3928 Fix bug that created negative-length intervals.
3929 * intervals.c (merge_interval_right, merge_interval_left):
3930 Do not zero out this interval if it is absorbed by its children,
3931 as this interval's total length doesn't change in that case. See
3932 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
3933
d06714cb
PE
39342012-07-18 Paul Eggert <eggert@cs.ucla.edu>
3935
83713154
PE
3936 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
3937 when invoking (make-bool-vector N t) and N is a positive
3938 multiple of 8 -- the last 8 bits were mistakenly cleared.
3939
d06714cb
PE
3940 Remove some struct layout assumptions in bool vectors.
3941 * alloc.c (bool_header_size): New constant.
3942 (header_size, word_size): Move earlier, as they're now used earlier.
3943 Use 'word_size' in a few more places, where it's appropriate.
3944 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
3945 padding before the data member of a bool vector.
3946 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
3947 than doing the check by hand with an abort ().
3948
464d5a5e
SM
39492012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3950
5fbc0409
SM
3951 * eval.c (Fdefvar): Don't check constants since we only set the var if
3952 it's not yet defined anyway (bug#11904).
3953
464d5a5e
SM
3954 * lisp.h (last_undo_boundary): Declare new var.
3955 * keyboard.c (command_loop_1): Set it.
3956 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
3957 were auto-added by the command loop (bug#11774).
3958
8dc2e44a
AS
39592012-07-18 Andreas Schwab <schwab@linux-m68k.org>
3960
3961 * w32font.c (Qsymbol): Remove local definition.
3962 (syms_of_w32font): Don't DEFSYM it.
3963
169925ec
DA
39642012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3965
3966 Fix sweep_vectors to handle large bool vectors correctly.
3967 * alloc.c (sweep_vectors): Account total_vector_bytes for
3968 bool vectors larger than VBLOCK_BYTES_MAX.
3969
5fbfb018
CY
39702012-07-18 Chong Yidong <cyd@gnu.org>
3971
3972 * frame.c (x_set_frame_parameters): Revert bogus change introduced
3973 in 2012-05-25 commit by Paul Eggert (Bug#11738).
3974
3ab6e069
DA
39752012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
3976
3977 Return more descriptive data from Fgarbage_collect.
3978 Suggested by Stefan Monnier in
3979 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
3980 * alloc.c (bounded_number): New function.
3981 (total_buffers, total_vectors): New variable.
3982 (total_string_size): Rename to total_string_bytes, adjust users.
3983 (total_vector_size): Rename to total_vector_bytes, adjust users.
3984 (sweep_vectors): Account total_vectors and total_vector_bytes.
3985 (Fgarbage_collect): New return value. Adjust documentation.
3986 (gc_sweep): Account total_buffers.
3987 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
3988 (VECTOR_SIZE): Remove.
3989 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
3990 (Qinterval, Qmisc): New symbols.
3991 (syms_of_data): Initialize them.
3992 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
3993 (Qcons, Qbuffer): New declarations.
3994
6d02fe5b
PE
39952012-07-17 Paul Eggert <eggert@cs.ucla.edu>
3996
3997 * alloc.c (Fmemory_free): Account for memory-free's own storage.
3998 Round up, not down. Improve doc.
3999
b7ffe040
DA
40002012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4001
4002 Restore old code in allocate_string_data to avoid Faset breakage.
4003 Reported by Julien Danjou <julien@danjou.info> in
4004 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
4005 * alloc.c (allocate_string_data): Restore old code with minor
4006 adjustments, fix comment to explain this subtle issue.
4007
4dc7c8d5
SM
40082012-07-17 Eli Zaretskii <eliz@gnu.org>
4009
4010 Remove FILE_SYSTEM_CASE.
4011 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
4012
4013 * fileio.c (FILE_SYSTEM_CASE): Don't define.
4014 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
4015 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
4016 call-process-region passes it through expand-file-name.
4017
4018 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
4019
40202012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4021
4022 Fix crash when creating indirect buffer (Bug#11917)
4023 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
4024 Don't handle unbound variables specially if non-zero.
4025 (Fbuffer_local_variables): Pass zero.
4026 (clone_per_buffer_values): Pass non-zero.
4027
40282012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4029
4030 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
4031 to make the loop interruptible.
4032
40332012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4034
4035 * gnutls.c (emacs_gnutls_handshake): Only retry if
4036 GNUTLS_E_INTERRUPTED.
4037
cce7fefc
DA
40382012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4039
4040 Cleanup and convert miscellaneous checks to eassert.
4041 * alloc.c (mark_interval): Fix comment, partially rephrase
4042 old comment from intervals.h (see below).
4043 * intervals.c (find_interval, adjust_intervals_for_insertion)
4044 (delete_interval, adjust_intervals_for_deletion)
4045 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
4046 Convert to eassert.
4047 (adjust_intervals_for_insertion, make_new_interval):
4048 Remove obsolete and unused code.
4049 * intervals.h (struct interval): Remove obsolete comment.
4050 * textprotp.c (erase_properties): Remove unused code.
4051 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
4052 (Fremove_list_of_text_properties): Convert to eassert.
4053
9ea10cc3
CY
40542012-07-17 Chong Yidong <cyd@gnu.org>
4055
4056 * editfns.c (Finsert_char): Doc fix.
4057
3900d5de
DA
40582012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4059
4060 Fix previous change to make Fmemory_free always accurate.
4061 * alloc.c (make_interval): Update total_free_intervals.
4062 (make_float): Likewise for total_free_floats.
4063 (free_cons, Fcons): Likewise for total_free_conses.
4064 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
4065 Likewise for total_free_vector_bytes.
4066 (Fmake_symbol): Likewise for total_free_symbols.
4067 (bytes_free): Remove.
4068
7098646f
DA
40692012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4070
4071 Simple free memory accounting feature.
4072 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
4073 (sweep_vectors): Accumulate size of free vectors.
4074 (Fgarbage_collect): Setup bytes_free.
4075 (Fmemory_free): New function.
4076 (syms_of_alloc): Register it.
4077
22657b40
DA
40782012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4079
4080 Cleanup overlays checking.
4081 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
4082 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
4083 eassert and OVERLAYP.
4084 (sort_overlays): Change to use OVERLAYP.
4085
ddfc8813
RK
40862012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
4087
4088 * editfns.c (Finsert_char): Make it interactive, and make the
4089 second arg optional. Copy interactive spec and docstring from
4090 ucs-insert.
4091
7c26cf3c
PE
40922012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4093
4094 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
4095 Unlike the other wrapped functions, fabs has an unspecified
4096 effect on errno.
4097
5d127af9
JD
40982012-07-16 Jan Djärv <jan.h.d@swipnet.se>
4099
4100 * nsterm.m (keyDown): Interpret flags without left/right bits
4101 as the left key (Bug#11670).
4102
6a0dd1d7
DA
41032012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4104
4105 Remove empty and useless init functions.
4106 * lisp.h (init_character_once, init_fns, init_image)
4107 (init_filelock, init_sound): Remove prototype.
4108 * character.c (init_character_once): Remove.
4109 * filelock.c (init_filelock): Likewise.
4110 * fns.c (init_fns): Likewise.
4111 * image.c (init_image): Likewise.
4112 * sound.c (init_sound): Likewise.
4113 * emacs.c (main): Adjust accordingly.
4114
7a6136fd
DA
41152012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4116
4117 * gtkutil.h: Tiny cleanups.
4118 (use_old_gtk_file_dialog): Remove useless declaration.
4119 (xg_uses_old_file_dialog): Add suggested const attribute.
4120
ce811ad9
EZ
41212012-07-15 Eli Zaretskii <eliz@gnu.org>
4122
4123 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
4124 (bidi_paragraph_init): Use it to limit search forward for a strong
4125 directional character in abnormally large paragraphs full of
4126 neutral or weak characters. (Bug#11943)
4127
c9adfeaa
SF
41282012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
4129
4130 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
4131 the toolbar (Bug#9451).
4132 (xg_make_tool_item): Give the widget event box a transparent
4133 background.
4134
fff62aa9
DA
41352012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4136
4137 Cleanup basic allocation variables and functions.
4138 * alloc.c (ignore_warnings, init_intervals, init_float)
4139 (init_cons, init_symbol, init_marker): Remove.
4140 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
4141 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
4142 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
4143 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
4144 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
4145 (staticidx, init_alloc_once, init_strings, free_ablock):
4146 Remove redundant initialization.
4147 * fns.c (init_weak_hash_tables): Remove.
4148 * lisp.h (init_weak_hash_tables): Remove prototype.
4149
9730daca
DA
41502012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4151
4152 Use zero_vector where appropriate.
4153 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
4154 accordingly.
4155 * lisp.h (zero_vector): New declaration.
4156 * font.c (null_vector): Remove.
4157 (syms_of_font): Remove initialization and staticpro.
4158 (font_list_entities, font_find_for_lface): Change to use zero_vector.
4159 * keymap.c (Faccessible_keymaps): Likewise.
4160
2e2d2a13
LL
41612012-07-15 Leo Liu <sdl.web@gmail.com>
4162
4163 * fringe.c: Fix typo in comments.
4164
cd276f6e
LL
41652012-07-14 Leo Liu <sdl.web@gmail.com>
4166
4167 * fringe.c: Add a new bitmap exclamation-mark.
4168
5a1131d9
EZ
41692012-07-14 Eli Zaretskii <eliz@gnu.org>
4170
4171 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
4172
4173 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
4174 (HAVE_MENUS): Don't define, defined by editing config.in with
4175 msdos/sed2v2.inp.
4176 (GMALLOC_INHIBIT_VALLOC): Don't define.
4177 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
4178
22e983b7
JB
41792012-07-14 Juanma Barranquero <lekktu@gmail.com>
4180
4181 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
4182
5b3f250f
GM
41832012-07-14 Glenn Morris <rgm@gnu.org>
4184
4185 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
4186 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
4187 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
4188
33d63ff4
GM
41892012-07-13 Glenn Morris <rgm@gnu.org>
4190
5b633342
GM
4191 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
4192
33d63ff4
GM
4193 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
4194 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
4195
b55b9f85
JD
41962012-07-13 Jan Djärv <jan.h.d@swipnet.se>
4197
0dc8cf50
JD
4198 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
4199 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
4200 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
4201 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
4202 where appropriate.
4203 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
4204 as boolean expression.
4205 (x_set_window_size): Remove unused variable toolbar.
4206 (ns_get_color_default, ns_mod_to_lisp): Remove.
4207 (ns_mouse_position): Remove unused variables xchar and ychar.
4208 (ns_compute_glyph_string_overhangs): Remove unused variable face.
4209 (ns_set_vertical_scroll_bar): Remove unused variable count.
4210 (ns_delete_terminal): Remove unused variable i.
4211 (ns_term_init): Remove unused variables r, g and b.
4212 (mouseDown): Remove unused variable window.
4213 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
4214 (initFrameFromEmacs): Remove unused variable vbextra.
4215 (mouseEntered): Remove unused variables p and dpyinfo.
4216 (mouseExited): Remove unused variables p and r.
4217 (ns_define_frame_cursor, ns_clear_frame_area)
4218 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
4219 (menuDown): Assign [sender tag] to variable and cast the variable.
4220
4221 * nsterm.h (menuDown): Add id as type to argument sender.
4222 (ns_display_info_for_name): Add Lisp_Object argument.
4223 (ns_term_init): Add Lisp_Object argument.
4224 (ns_map_event_to_object): Add void argument.
4225 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
4226 prototype with arguments and only declare if __OBJC__.
4227 (nxatoms_of_nsselect): Add void argument.
4228 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
4229 (ns_alloc_autorelease_pool): Add void argument.
4230 (ns_release_autorelease_pool): Add void* argument.
4231 (ns_get_defaults_value): Add const char* argument.
4232
4233 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
4234 (initFromContents): Use SSDATA where appropriate.
4235 (ns_update_menubar): Add braces to ambigous if-else.
4236 (initWithTitle): Put () around assignment in if statement.
4237 (ns_menu_show): Remove unused variables window and keymap.
4238 (update_frame_tool_bar): Remove unused variable selected_p.
4239 (initWithContentRect): Remove unused variable this_cmd_name.
4240
4241 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
4242 appropriate.
4243 (setXBMColor): Remove unused variable len.
4244 (setPixmapData): Put () around assignment in loop statement.
4245
4246 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
4247 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
4248 where appropriate.
4249 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
4250 around assignment in loop statement.
4251 (nsfont_open): Remove unused variable i.
4252 (nsfont_open): Remove unused variable len.
4253 (nsfont_draw): Remove unused variable cs.
4254
4255 * nsfns.m (x_set_icon_name, ns_set_name_internal)
4256 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
4257 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
4258 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
4259 (Fns_font_name, Fns_perform_service)
4260 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
4261 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
4262 (ns_set_name): Remove unused variable view.
4263 (x_set_menu_bar_lines): Remove unused variable olines.
4264 (x_set_tool_bar_lines): Remove unused variable root_window.
4265 (Fns_list_colors): Put () around assignment in while statement.
4266 (Fns_perform_service): Remove unused variable len.
4267 (Fns_display_usable_bounds): Remove unused variable top.
4268 (syms_of_nsfns): Remove unused variable i.
4269
b55b9f85
JD
4270 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
4271 memcpy (Bug#11907).
4272
ed9265fc 42732012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
4274
4275 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
4276 and free it with DestroyExceptionInfo (Bug#11558).
4277
ef099b57
JB
42782012-07-13 Juanma Barranquero <lekktu@gmail.com>
4279
4280 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
4281 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
4282 Set here, not in nt/config.nt.
4283
ea814a5d
EZ
42842012-07-13 Eli Zaretskii <eliz@gnu.org>
4285
4286 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
4287 cursor overflow into the last glyph on display line when the right
4288 fringe is off. (Bug#11832)
4289
1a952767
PE
42902012-07-13 Paul Eggert <eggert@cs.ucla.edu>
4291
4292 * xdisp.c (produce_special_glyphs): Now static.
4293 * dispextern.h (produce_special_glyphs): Remove decl.
4294
983188fd
GM
42952012-07-13 Glenn Morris <rgm@gnu.org>
4296
8d7c7eed 4297 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
4298 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
4299
983188fd
GM
4300 * s/usg5-4-common.h (USG, USG5):
4301 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
4302 * s/sol2-6.h (SOLARIS2):
4303 * s/irix6-5.h (IRIX6_5):
4304 * s/hpux10-20.h (USG, USG5, HPUX):
4305 * s/gnu-linux.h (USG, GNU_LINUX):
4306 * s/freebsd.h (BSD_SYSTEM):
4307 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
4308 * s/cygwin.h (CYGWIN):
4309 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
4310 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
4311
d1e68667 43122012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
4313
4314 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 4315
6de0e799
GM
43162012-07-13 Glenn Morris <rgm@gnu.org>
4317
739ae010
GM
4318 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
4319
dbee5793
GM
4320 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
4321
6de0e799
GM
4322 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
4323 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
4324
b82da769
GM
43252012-07-12 Glenn Morris <rgm@gnu.org>
4326
4fae5a7a 4327 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
4328
4329 * process.c (init_process_emacs): Rename from init_process.
4330 The old name is also the name of a Mach system call.
4331 * lisp.h, emacs.c: Update for this name change.
4332 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
4333 longer needed.
4334
5a979817
EZ
43352012-07-12 Eli Zaretskii <eliz@gnu.org>
4336
4337 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
4338 memmove call that removes glyphs covered by the left truncation
4339 glyph. Improve commentary.
4340 (display_line): Fix display of continuation glyphs on GUI frames
4341 when the right fringe is turned off and variable-size fonts are
4342 used in the window. Move the code that appends a stretch glyph to
4343 produce_special_glyphs, so that it could be used for truncation
4344 and continuation glyphs alike.
4345 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
4346 glyph of a suitably computed width, to align the special glyphs at
4347 the window margin. Code moved from display_line. (Bug#11832)
4348
3e91a053
GM
43492012-07-12 Glenn Morris <rgm@gnu.org>
4350
ba9e4b84
GM
4351 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
4352
4353 * s/gnu-linux.h, s/hpux10-20.h:
4354 Do not unconditionally define HAVE_XRMSETDATABASE.
4355
3e91a053
GM
4356 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
4357
b300b1f4
PE
43582012-07-12 Paul Eggert <eggert@cs.ucla.edu>
4359
4360 Fix typos that broke OS X build.
4361 Reported by Randal L. Schwartz in
4362 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
4363 * nsterm.m (ns_timeout): Add missing local decl.
4364 (ns_get_color): snprintf -> sprintf, to fix typo.
4365
6e777848
GM
43662012-07-12 Glenn Morris <rgm@gnu.org>
4367
3f922c37
GM
4368 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
4369 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
4370 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
4371 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
4372
0ab7b23a
GM
4373 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
4374 Move PTY_OPEN to configure.
4375
6e777848
GM
4376 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4377 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
4378 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
4379
4a7edc24
DA
43802012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
4381
4382 Use empty_unibyte_string where applicable.
4383 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
4384 * lread.c (read1): Likewise.
4385 * xsettings.c (syms_of_xsettings): Likewise.
4386
308aab79
GM
43872012-07-12 Glenn Morris <rgm@gnu.org>
4388
42bd1719
GM
4389 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
4390 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
4391 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
4392 * s/hpux10-20.h (RUN_TIME_REMAP):
4393 * s/bsd-common.h (TABDLY): Move to configure.
4394
4395 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
4396
4397 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
4398
ea0bbd17 4399 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 4400 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
4401
4402 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 4403
308aab79
GM
4404 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
4405 * s/template.h: Move NARROWPROTO to configure.
4406
ee1cf5cf
GM
44072012-07-11 Glenn Morris <rgm@gnu.org>
4408
30fe9bf4
GM
4409 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
4410 unused since 2011-01-17 change to systty.h.
4411
ee1cf5cf
GM
4412 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
4413 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4414 Move HAVE_PTYS and HAVE_SOCKETS to configure.
4415
63e47e07
PE
44162012-07-11 Paul Eggert <eggert@cs.ucla.edu>
4417
4418 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
4419
c43fb4c3
GM
44202012-07-11 Glenn Morris <rgm@gnu.org>
4421
4422 * s/darwin.h, s/gnu-linux.h, s/template.h:
4423 Move INTERRUPT_INPUT to configure.
4424
e8df9267
DA
44252012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4426
4427 Minor adjustments to interning code.
4428 * lisp.h (intern, intern_c_string): Redefine as static inline
4429 wrappers for intern_1 and intern_c_string_1, respectively.
4430 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
4431 * lread.c (intern_1, intern_c_string_1, oblookup):
4432 Simplify Vobarray checking.
e8df9267
DA
4433 * font.c (font_intern_prop): Likewise. Adjust comment.
4434 * w32font.c (intern_font_name): Likewise.
4435
34348bd4
AS
44362012-07-11 Andreas Schwab <schwab@linux-m68k.org>
4437
d96a1e0c
AS
4438 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
4439
34348bd4
AS
4440 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
4441 of Fcar/Fcdr if possible.
4442 * font.c (check_otf_features): Likewise.
4443 * fontset.c (Fnew_fontset): Likewise.
4444 * gnutls.c (Fgnutls_boot): Likewise.
4445 * minibuf.c (read_minibuf): Likewise.
4446 * msdos.c (IT_set_frame_parameters): Likewise.
4447 * xmenu.c (Fx_popup_dialog): Likewise.
4448 * w32menu.c (Fx_popup_dialog): Likewise.
4449
c8add24e
GM
44502012-07-11 Glenn Morris <rgm@gnu.org>
4451
4b575b3c
GM
4452 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
4453 since nothing has defined it on these platforms.
4454
09f4e3b0
GM
4455 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
4456 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
4457
172bedef
GM
4458 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4459 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4460 Move CLASH_DETECTION to configure.
4461
249685df
GM
4462 * s/gnu.h: Remove file, which is now empty.
4463
c8add24e
GM
4464 * s/gnu.h, s/gnu-linux.h:
4465 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
4466
b41253a3
JW
44672012-07-11 John Wiegley <johnw@newartisans.com>
4468
4469 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
4470 function attribute, so we only use it if it exists in the
4471 compiler.
4472
d923b542
DA
44732012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4474
4475 Avoid call to strlen in fast_c_string_match_ignore_case.
4476 * search.c (fast_c_string_match_ignore_case): Change to use
4477 length argument. Adjust users accordingly.
4478 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
4479
5ebbef1d
PE
44802012-07-11 Paul Eggert <eggert@cs.ucla.edu>
4481
bb352260
PE
4482 Assume mkdir, rmdir.
4483 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
4484 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
4485
57054ddd
PE
4486 Assume rename.
4487 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
4488
b747d3f7
PE
4489 Assume perror.
4490 * s/hpux10-20.h (HAVE_PERROR): Remove.
4491 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
4492 Remove dummy definition, as this problem was obsolete long ago.
4493
5ebbef1d
PE
4494 Assume strerror.
4495 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
4496
984e7f30
DA
44972012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4498
4499 Avoid calls to strlen in font processing functions.
4500 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
4501 (font_open_by_name): Change to use length argument.
4502 Adjust users accordingly.
d923b542
DA
4503 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
4504 Adjust prototypes.
4505 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
4506 Change to return ptrdiff_t.
984e7f30
DA
4507 (xfont_list_pattern, xfont_match): Use length returned by
4508 xfont_decode_coding_xlfd.
4509 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
4510
20e94fdd
GM
45112012-07-11 Glenn Morris <rgm@gnu.org>
4512
9d596af3
GM
4513 * s/darwin.h, s/freebsd.h, s/netbsd.h:
4514 Move DONT_REOPEN_PTY to configure.
4515
20e94fdd
GM
4516 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
4517 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
4518
e99a530f
PE
45192012-07-10 Paul Eggert <eggert@cs.ucla.edu>
4520
22ffb973
PE
4521 Remove "#define unix" that is no longer needed (Bug#11905).
4522 * s/aix4-2.h (unix): Remove; no longer needed.
4523
e9a9ae03
PE
4524 EMACS_TIME simplification (Bug#11875).
4525 This replaces macros (which typically do not work in GDB)
4526 with functions, typedefs and enums, making the code easier to debug.
4527 The functional style also makes code easier to read and maintain.
4528 * systime.h: Include <sys/time.h> on all hosts, not just if
4529 WINDOWSNT, since 'struct timeval' is needed in general.
4530 (EMACS_TIME): Now a typedef, not a macro.
4531 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
4532 not macros.
4533 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
4534 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
4535 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
4536 (EMACS_TIME_LE): Now functions, not macros.
4537 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
4538 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
4539 which are not functions. All uses rewritten to use:
4540 (make_emacs_time): New function.
4541 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
4542 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
4543 not functions. All uses rewritten to use the following, respectively:
4544 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
4545 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 4546 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
4547 * fileio.c (Fcopy_file):
4548 * xterm.c (XTflash): Get the current time closer to when it's used.
4549 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
4550
ffacb126
PE
4551 * bytecode.c (targets): Suppress -Woverride-init warnings.
4552
e99a530f
PE
4553 Simplify by avoiding confusing use of strncpy etc.
4554 * doc.c (Fsnarf_documentation):
4555 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
4556 * frame.c (Fmake_terminal_frame):
4557 * gtkutil.c (get_utf8_string):
4558 * lread.c (openp):
4559 * nsmenu.m (ns_update_menubar):
4560 * regex.c (regerror):
4561 Prefer memcpy to strncpy and strncat when either will do.
4562 * fileio.c (Fsubstitute_in_file_name):
4563 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
4564 (menu_separator_name_p):
4565 * nsmenu.m (ns_update_menubar):
4566 Prefer memcmp to strncmp when either will do.
4567 * nsterm.m: Include <ftoastr.h>.
4568 (ns_get_color):
4569 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
4570 Prefer snprintf to strncpy.
4571 * nsterm.m (ns_term_init):
4572 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
4573 * nsterm.m (ns_term_init):
4574 Avoid the need for strncpy, by using build_string or
4575 make_unibyte_string directly. Use dtoastr, not snprintf.
4576 * process.c (Fmake_network_process): Diagnose service names that
4577 are too long, rather than silently truncating them or creating
4578 non-null-terminated names.
4579 (Fnetwork_interface_info): Likewise, for interface names.
4580 * sysdep.c (system_process_attributes) [GNU_LINUX]:
4581 Prefer sprintf to strncat.
4582 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
4583 Prefer vsnprintf to vsprintf + strncpy.
4584
c59592b3
GM
45852012-07-10 Glenn Morris <rgm@gnu.org>
4586
4587 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
4588 Clarify fallback case.
4589
7d7bbefd
DA
45902012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4591
4592 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
4593 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
4594 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 4595 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
4596 where argument type is known to be a Lisp_Cons.
4597
3a4c8000
TT
45982012-07-10 Tom Tromey <tromey@redhat.com>
4599
4600 * bytecode.c (BYTE_CODE_THREADED): New macro.
4601 (BYTE_CODES): New macro. Replaces all old byte-code defines.
4602 (enum byte_code_op): New type.
4603 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
4604 (exec_byte_code): Use them. Use token threading when applicable.
4605
2a0213a6
DA
46062012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4607
4608 Optimize pure C strings initialization.
4609 * lisp.h (make_pure_string): Fix prototype.
4610 (build_pure_c_string): New function, defined as static inline. This
4611 provides a better opportunity to optimize away calls to strlen when
4612 the function is called with compile-time constant argument.
4613 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
4614 argument, adjust users accordingly. Use build_pure_c_string where
4615 appropriate.
4616 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
4617 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
4618 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
4619
cb1caeaf
DA
46202012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4621
4622 Avoid calls to strlen in miscellaneous functions.
4623 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
4624 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
4625 * lread.c (openp): Likewise.
4626
c293e30c
DA
46272012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4628
4629 Avoid calls to strlen in path processing functions.
4630 * fileio.c (file_name_as_directory): Add comment. Change to add
4631 srclen argument and return the length of result. Adjust users
4632 accordingly.
4633 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
4634 swap 1st and 2nd arguments to obey the common convention.
4635 Adjust users accordingly.
c293e30c
DA
4636 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
4637
9e059e3f
GM
46382012-07-10 Glenn Morris <rgm@gnu.org>
4639
d02eb359
GM
4640 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
4641 Move PENDING_OUTPUT_COUNT definition to configure.
4642
882cf227
GM
4643 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
4644 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
4645 * s/gnu.h (DATA_START): Move definitions to configure.
4646
af6e839f
GM
4647 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
4648 We include usg5-4-common.h, which defines them both.
4649
40289a12
GM
4650 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
4651 O_RDONLY already includes it).
4652
9e059e3f
GM
4653 Stop ns builds setting the EMACSLOADPATH environment variable.
4654 * nsterm.m (ns_load_path): Rename from ns_init_paths.
4655 Now it does not set EMACSLOADPATH, just returns the load-path string.
4656 * nsterm.h: Update accordingly.
4657 * lread.c [HAVE_NS]: Include nsterm.h.
4658 (init_lread) [HAVE_NS]: Use ns_load_path.
4659 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
4660
7c4e8ec0
GM
46612012-07-09 Glenn Morris <rgm@gnu.org>
4662
d4f600ff
GM
4663 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
4664 since the included bsd-common.h does so.
4665
cbb31951
GM
4666 Stop ns builds setting the EMACSPATH environment variable.
4667 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
4668 (ns_init_paths): Do not set EMACSPATH.
4669 * nsterm.h (ns_exec_path): Add it.
4670 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
4671 Use ns_exec_path.
4672
7c4e8ec0
GM
4673 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
4674
26bccfae
PE
46752012-07-09 Paul Eggert <eggert@cs.ucla.edu>
4676
a0bee46f
PE
4677 * process.c (wait_reading_process_output): 'waitchannels' was unset
4678 when read_kbd || !NILP (wait_for_cell); fix this.
4679
5994c183
PE
4680 Add GCC-style 'const' attribute to functions that can use it.
4681 * character.h (char_resolve_modifier_mask):
4682 * keyboard.h (make_ctrl_char):
4683 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
4684 (init_character_once, next_almost_prime, init_fns, init_image)
4685 (flush_pending_output, init_sound):
4686 * mem-limits.h (start_of_data):
4687 * menu.h (finish_menu_items):
4688 Add ATTRIBUTE_CONST.
4689 * emacs.c (DEFINE_DUMMY_FUNCTION):
4690 Declare the dummy function with ATTRIBUTE_CONST.
4691 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
4692 Add decls with ATTRIBUTE_CONST.
4693
26bccfae
PE
4694 Minor improvements to make_formatted_string.
4695 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
4696 where int is good enough, as vsprintf returns an int.
4697 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
4698
a8290ec3
DA
46992012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4700
4701 Use make_formatted_string to avoid double length calculation.
4702 * lisp.h (make_formatted_string): New prototype.
4703 * alloc.c (make_formatted_string): New function.
4704 * buffer.c (Fgenerate_new_buffer_name): Use it.
4705 * dbus.c (syms_of_dbusbind): Likewise.
4706 * editfns.c (Fcurrent_time_zone): Likewise.
4707 * filelock.c (get_boot_time): Likewise.
4708 * frame.c (make_terminal_frame, set_term_frame_name)
4709 (x_report_frame_params): Likewise.
4710 * image.c (gs_load): Likewise.
4711 * minibuf.c (get_minibuffer): Likewise.
4712 * msdos.c (dos_set_window_size): Likewise.
4713 * process.c (make_process): Likewise.
4714 * xdisp.c (ensure_echo_area_buffers): Likewise.
4715 * xsettings.c (apply_xft_settings): Likewise.
4716
d01ba2f1
GM
47172012-07-09 Glenn Morris <rgm@gnu.org>
4718
4719 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
4720 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
4721 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
4722 * nsterm.h (ns_etc_directory): Add it.
4723 * callproc.c [HAVE_NS]: Include nsterm.h.
4724 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
4725
f1f924b6
DA
47262012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4727
4728 Move marker debugging code under MARKER_DEBUG.
4729 * marker.c (MARKER_DEBUG): Move marker debugging code under
4730 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
4731 for bootstrap with --enable-checking (~3x slowdown reported
4732 by Juanma Barranquero <lekktu@gmail.com>).
4733 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
4734
ab531b66
PE
47352012-07-08 Paul Eggert <eggert@cs.ucla.edu>
4736
4737 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
4738 See <http://bugs.gnu.org/11825#29>.
4739
c4b3bc8a
EZ
47402012-07-08 Eli Zaretskii <eliz@gnu.org>
4741
4742 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
4743 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
4744 (display_line): Add commentary about displaying truncation glyphs
4745 on GUI frames.
4746 (produce_special_glyphs): Move here from term.c.
4747
4748 * term.c (produce_special_glyphs): Move to xdisp.c.
4749
4750 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
4751 section.
c4b3bc8a 4752
b676b881
AS
47532012-07-07 Andreas Schwab <schwab@linux-m68k.org>
4754
f17c5273
AS
4755 * xdisp.c (display_line): Avoid warning about implicit declaration
4756 of FRAME_FONT.
4757
298819b9
AS
4758 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
4759
b676b881
AS
4760 * lisp.h: Remove empty conditional.
4761
6045c4fd
PE
47622012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4763
b3350bf9
PE
4764 * lread.c (load_path_check): Now static.
4765
6045c4fd
PE
4766 Fix some minor --with-ns problems found by static checking.
4767 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
4768 (x_set_font) [!HAVE_X_WINDOWS]:
4769 * image.c (xpm_load_image) [HAVE_NS]:
4770 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
4771 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
4772 Remove unused local.
4773 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
4774 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
4775 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
4776 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
4777 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
4778 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
4779 Fix pointer signedness problem.
4780 * xfaces.c (FRAME_X_FONT_TABLE):
4781 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
4782
929e7845
GM
47832012-07-07 Glenn Morris <rgm@gnu.org>
4784
4785 * lread.c (load_path_check): New function, split from init_lread.
4786 (init_lread): Reorganize. Motivation:
4787 If EMACSLOADPATH is set, check/warn about that rather than the
4788 defaults, which we are not going to use. Hence we can remove
4789 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
4790 Don't warn if site-lisp directories are missing.
4791 If not installed, start from a blank load-path, since
4792 PATH_LOADSEARCH refers to the eventual installation directories.
4793
58dd0aa4
EZ
47942012-07-07 Eli Zaretskii <eliz@gnu.org>
4795
4796 Support truncation and continuation glyphs on GUI frames, when
4797 fringes are disabled. (Bug#11832)
4798 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
4799 continuation glyphs even if on GUI frames.
4800 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
4801 or both, are absent.
4802 (start_display, move_it_in_display_line_to): Handle the case of a
4803 GUI frame without a fringe to display continuation or truncation
4804 glyphs.
4805 (insert_left_trunc_glyphs): Support GUI frames: make sure
4806 truncation glyphs overwrite enough glyphs from the current line to
4807 have sufficient space in pixels.
4808 (display_line): Support truncation and continuation glyphs on GUI
4809 frames. If some spare pixels are left on the line after inserting
4810 the truncation glyphs, fill that space with a stretch glyph of a
4811 suitably computed width.
4812
4813 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
4814 produce_glyphs, to support GUI sessions.
4815
31571fd7
PE
48162012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4817
5a16b9bc
PE
4818 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
4819
f3047c75
PE
4820 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
4821
31571fd7
PE
4822 Do not require float-time's arg to fit in time_t (Bug#11825).
4823 This works better on hosts where time_t is unsigned, and where
4824 float-time is applied to the (negative) difference between two times.
4825 * editfns.c (decode_time_components): Last arg is now double *,
4826 not int *, and means to store all the result as a double, without
4827 worrying about whether the seconds part fits in time_t.
4828 All callers changed.
4829 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
4830 All callers changed.
4831 (Ffloat_time): Do not fail merely because the specified time falls
4832 outside of time_t range.
4833
4516fbef
GM
48342012-07-07 Glenn Morris <rgm@gnu.org>
4835
4836 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
4837 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
4838 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
4839
07adc2c6
JB
48402012-07-07 Juanma Barranquero <lekktu@gmail.com>
4841
4842 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
4843 Update dependencies.
4844
4845 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
4846
fd573f31
PE
48472012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4848
fee5959d
PE
4849 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
4850 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
4851 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
4852 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
4853 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
4854 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
4855
fd573f31
PE
4856 * xfont.c (compare_font_names): Redo to omit the need for casts.
4857
ddadbc0e
AS
48582012-07-06 Andreas Schwab <schwab@linux-m68k.org>
4859
fca8d6b6
AS
4860 * xfns.c (Fx_change_window_property): Doc fix.
4861 * w32fns.c (Fx_change_window_property): Doc fix.
4862
ddadbc0e
AS
4863 * w32fns.c (Fx_window_property): Accept the same arguments as the
4864 X Windows version. Doc fix.
4865 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
4866
ed9265fc 48672012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
4868 Eli Zaretskii <eliz@gnu.org>
4869
4870 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
4871 Windows-specific code from nt/config.nt moved here.
4872 Obsolete settings removed.
4873
216ee680
PE
48742012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4875
4876 * process.c: Avoid unnecessary calls to gettime.
4877 (wait_reading_process_output): Don't get the time of day
4878 when gobbling data immediately and not waiting, as there's no need
4879 for it in that case. This removes a FIXME.
4880
bdd091e4
JD
48812012-07-06 Jan Djärv <jan.h.d@swipnet.se>
4882
4883 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
4884 is defined (Bug#11768).
4885
9d44f8ce
DA
48862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4887
4888 Fix marker debugging code.
4889 * marker.c (byte_char_debug_check): Do not perform the check
4890 if buffer is not multibyte.
090bd7cb
JB
4891 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4892 Call byte_char_debug_check with correct arguments.
9d44f8ce 4893
90fc4786
DA
48942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4895
4896 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
4897 * marker.c (byte_char_debug_check, count_markers):
4898 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
4899 (byte_debug_flag): Remove.
4900 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
4901 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
4902
7b7ae965
DA
49032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4904
4e57b342
DA
4905 Avoid code repetition in marker-related functions.
4906 * marker.c (attach_marker): New function.
4907 (Fset_marker, set_marker_restricted, set_marker_both)
4908 (set_marker_restricted_both): Use it.
4909 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
4910 Consistently rename charno to charpos.
4911 (marker_position): Add eassert.
4912 (marker_byte_position): Convert to eassert.
4913
49142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4915
4916 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 4917 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 4918 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 4919
657924ff
DA
49202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4921
4922 Introduce fast path for the widely used marker operation.
4923 * alloc.c (build_marker): New function.
4924 * lisp.h (build_marker): New prototype.
4925 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
4926 * composite.c (autocmp_chars): Likewise.
4927 * editfns.c (buildmark): Remove.
4928 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
4929 (save_restriction_save): Use build_marker.
4930 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
4931 * window.c (save_window_save): Likewise.
4932
041a49a6
DA
49332012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
4934
4935 Do not use Fdelete_overlay in delete_all_overlays
4936 to avoid redundant calls to unchain_overlay.
4937 * buffer.c (drop_overlay): New function.
4938 (delete_all_overlays, Fdelete_overlay): Use it.
4939 * minibuf.c (get_minibuffer): Fix comment.
4940
7dca65a4
PE
49412012-07-06 Paul Eggert <eggert@cs.ucla.edu>
4942
4943 Port to OpenBSD 5.1 amd64.
4944 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
4945 This is needed for OpenBSD, and should be harmless on all BSD systems.
4946 Also, include <sys/sysctl.h>, as it should be available on all
4947 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
4948 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
4949 use p_pid member, not kp_proc.pid.
4950
8eb876e2
GM
49512012-07-06 Glenn Morris <rgm@gnu.org>
4952
4953 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
4954
38182d90
PE
49552012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4956
4957 More xmalloc and related cleanup.
4958 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
4959 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
4960 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
4961 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
4962 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
4963 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
4964 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
4965 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
4966 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
4967 * xterm.c:
4968 Omit needless casts involving void * pointers and allocation.
4969 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
4970 as the former is more robust if P's type is changed.
4971 Prefer xzalloc to xmalloc + memset 0.
4972 Simplify malloc-or-realloc to realloc.
4973 Don't worry about xmalloc returning a null pointer.
4974 Prefer xstrdup to xmalloc + strcpy.
4975 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
4976 growing it.
4977 * keyboard.c (apply_modifiers_uncached): Prefer local array to
4978 alloca of a constant.
4979
6dd5a677
EZ
49802012-07-05 Eli Zaretskii <eliz@gnu.org>
4981
4982 * xdisp.c (display_line): Fix horizontal pixel coordinates when
4983 hscroll is larger than the line width. Fixes long and futile
4984 looping inside extend_face_to_end_of_line (on a TTY) producing
4985 glyphs that are not needed and thrown away.
4986
6b312f0f
DA
49872012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
4988
4989 * marker.c (set_marker_restricted_both): Simplify by using
4990 clip_to_bounds.
4991
f520ef9b
PE
49922012-07-05 Paul Eggert <eggert@cs.ucla.edu>
4993
4994 * editfns.c (region_limit): Simplify by using clip_to_bounds.
4995
383b7c95
JD
49962012-07-05 Jan Djärv <jan.h.d@swipnet.se>
4997
4998 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
4999 not defined (Bug#11768).
5000 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
5001 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
5002 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
5003 followed by gtk_box_set_homogeneous (Bug#11768).
5004 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
5005 (update_theme_scrollbar_width, xg_create_scroll_bar):
5006 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
5007 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
5008 (is_box_type): New function (Bug#11768).
5009 (xg_tool_item_stale_p): Call is_box_type.
5293d758 5010 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
5011 with default display (Bug#11768).
5012
d6e7bf45
EZ
50132012-07-05 Eli Zaretskii <eliz@gnu.org>
5014
5015 * xdisp.c (window_hscroll_limited): New function.
5016 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
5017 coordinates when window's hscroll is set to insanely large
5018 values. (Bug#11857)
5019
431391ec
JB
50202012-07-05 Juanma Barranquero <lekktu@gmail.com>
5021
5022 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
5023 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
5024
23f86fce
DA
50252012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5026
5027 Cleanup xmalloc.
5028 * lisp.h (xzalloc): New prototype. Omit needless casts.
5029 * alloc.c (xzalloc): New function. Omit needless casts.
5030 * charset.c: Omit needless casts. Convert all calls to
5031 xmalloc with following memset to xzalloc.
5032 * dispnew.c: Likewise.
5033 * fringe.c: Likewise.
5034 * image.c: Likewise.
5035 * sound.c: Likewise.
5036 * term.c: Likewise.
5037 * w32fns.c: Likewise.
5038 * w32font.c: Likewise.
5039 * w32term.c: Likewise.
5040 * xfaces.c: Likewise.
5041 * xfns.c: Likewise.
5042 * xterm.c: Likewise.
5043 * atimer.c: Omit needless casts.
5044 * buffer.c: Likewise.
5045 * callproc.c: Likewise.
5046 * ccl.c: Likewise.
5047 * coding.c: Likewise.
5048 * composite.c: Likewise.
5049 * doc.c: Likewise.
5050 * doprnt.c: Likewise.
5051 * editfns.c: Likewise.
5052 * emacs.c: Likewise.
5053 * eval.c: Likewise.
5054 * filelock.c: Likewise.
5055 * fns.c: Likewise.
5056 * gtkutil.c: Likewise.
5057 * keyboard.c: Likewise.
5058 * lisp.h: Likewise.
5059 * lread.c: Likewise.
5060 * minibuf.c: Likewise.
5061 * msdos.c: Likewise.
5062 * print.c: Likewise.
5063 * process.c: Likewise.
5064 * region-cache.c: Likewise.
5065 * search.c: Likewise.
5066 * sysdep.c: Likewise.
5067 * termcap.c: Likewise.
5068 * terminal.c: Likewise.
5069 * tparam.c: Likewise.
5070 * w16select.c: Likewise.
5071 * w32.c: Likewise.
5072 * w32reg.c: Likewise.
5073 * w32select.c: Likewise.
5074 * w32uniscribe.c: Likewise.
5075 * widget.c: Likewise.
5076 * xdisp.c: Likewise.
5077 * xmenu.c: Likewise.
5078 * xrdb.c: Likewise.
5079 * xselect.c: Likewise.
5080
0497dc44
PE
50812012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5082
5083 * fileio.c (time_error_value): Check the right error number.
5084 Problem reported by Troels Nielsen in
5085 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
5086
356e7178
PE
50872012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5088
4e71fd89
PE
5089 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
5090 This should be fixed in a better way; see Eli Zaretskii in
5091 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
5092 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
5093
f0941253
PE
5094 * fileio.c (time_error_value): Rename from special_mtime.
5095 The old name's problems were noted by Eli Zaretskii in
5096 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
5097
065c9eb4
PE
5098 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
5099 This variable's comment says Emacs needs at least one GDB-visible
5100 symbol of type enum pvec_type, to work around GDB problems.
5101 The symbol's value doesn't matter.
5102
356e7178
PE
5103 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
5104 that causes compilation to fail on pre-C99 compilers.
5105
ed9265fc 51062012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
5107
5108 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
5109 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
5110
3884d954
DA
51112012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5112
d209e2fb 5113 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
5114 headers for buffer_defaults and buffer_local_symbols.
5115 Reported by Juanma Barranquero <lekktu@gmail.com>.
5116
ee28be33
SM
51172012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5118
5119 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
5120 * lisp.h (enum pvec_type): Use fewer bits.
5121 (PSEUDOVECTOR_SIZE_BITS): New constant.
5122 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
5123 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
5124 change in pvec_type.
5125 (PSEUDOVECTOR_TYPEP): New macro.
5126 (TYPED_PSEUDOVECTORP): Use it.
5127 * fns.c (internal_equal): Adapt code to extract pvectype.
5128 * emacs.c (gdb_pvec_type): Update type.
5129 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
5130 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
5131 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
5132 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
5133 (sweep_vectors): Use it. Use local var `total_bytes' instead of
5134 abusing vector->header.next.nbytes.
5135 (live_vector_p): Use PVEC_TYPE.
5136 (mark_object): Adapt code to extract pvectype. Use switch.
5137
c7f2cd7f
PE
51382012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5139
5140 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
5141 Tighten new eassert a bit.
5142
8ce70ed2
DA
51432012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5144
5145 Fix compilation with --enable-gcc-warnings and -O1
5146 optimization level.
5147 * doprnt.c (doprnt): Change type of tem to int, initialize
5148 to avoid compiler warning. Add eassert.
5149 * search.c (simple_search): Initialize match_byte to avoid
5150 compiler warning. Add eassert.
5151
dea7f1e5
PE
51522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5153
24a212eb
PE
5154 Avoid weird behavior with large horizontal scrolls.
5155 Without this change, for example, large hscroll values would
5156 mess up Emacs's display on Fedora 15 x86, presumably due to
5157 overflows in int calculations in the display code.
5158 Also, if buffers had long lines, Emacs would freeze.
5159 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
5160 (set_window_hscroll): New function, containing the old guts of
5161 Fset_window_hscroll. Return the clipped value.
5162 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
5163 This avoids the need to check against PTRDIFF_MAX.
5164
dea7f1e5
PE
5165 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
5166
76046526
DA
51672012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5168
5169 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
5170
39adff0d
PE
51712012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5172
63807d47
PE
5173 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
5174 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
5175 since GCC 4.4.6 issues a bogus warning for them.
5176
39adff0d
PE
5177 Fix bugs in file timestamp newness comparisons.
5178 * fileio.c (Ffile_newer_than_file_p):
5179 * lread.c (Fload): Use full timestamp resolution of files,
5180 not just the 1-second resolution, so that files that are only
5181 slightly newer still count as newer.
5182 * fileio.c (Ffile_newer_than_file_p): Don't assume file
5183 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
5184
dbeed9a6
PE
51852012-07-03 Paul Eggert <eggert@cs.ucla.edu>
5186
5187 * fileio.c: Improve handling of file time marker. (Bug#11852)
5188 (special_mtime): New function.
5189 (Finsert_file_contents, Fverify_visited_file_modtime):
5190 Use it to set special mtime values consistently.
5191
636334d6
AS
51922012-07-03 Andreas Schwab <schwab@linux-m68k.org>
5193
5194 * fileio.c (Finsert_file_contents): Properly handle st_mtime
5195 marker for non-existing file. (Bug#11852)
5196
e2017fe2
GM
51972012-07-03 Glenn Morris <rgm@gnu.org>
5198
5199 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
5200 and did not make it into globals.h).
5201
404dbd37
TT
52022012-07-03 Tom Tromey <tromey@redhat.com>
5203
5204 * window.c (Fset_window_margins, Fset_window_fringes)
5205 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
5206 * textprop.c (Fprevious_property_change): No longer static.
5207 * syntax.c (Fsyntax_table_p): No longer static.
5208 * process.c (Fget_process, Fprocess_datagram_address): No longer
5209 static.
5210 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
5211 * keyboard.c (Fcommand_execute): No longer static.
5212 Remove EXFUN.
5213 * insdel.c (Fcombine_after_change_execute): No longer static.
5214 * image.c (Finit_image_library): No longer static.
5215 * fileio.c (Fmake_symbolic_link): No longer static.
5216 * eval.c (Ffetch_bytecode): No longer static.
5217 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
5218 * doc.c (Fdocumentation_property, Fsnarf_documentation):
5219 No longer static.
404dbd37
TT
5220 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
5221 static.
5222 * dired.c (Ffile_attributes): No longer static.
5223 * composite.c (Fcomposition_get_gstring): No longer static.
5224 * callproc.c (Fgetenv_internal): No longer static.
5225
5226 * ccl.h: Remove EXFUNs.
5227 * buffer.h: Remove EXFUNs.
5228 * dispextern.h: Remove EXFUNs.
5229 * intervals.h: Remove EXFUNs.
5230 * fontset.h: Remove EXFUN.
5231 * font.h: Remove EXFUNs.
5232 * dosfns.c (system_process_attributes): Remove EXFUN.
5233 * keymap.h: Remove EXFUNs.
5234 * lisp.h: Remove EXFUNs.
5235 * w32term.h: Remove EXFUNs.
5236 * window.h: Remove EXFUNs.
5237 * xsettings.h: Remove EXFUN.
5238 * xterm.h: Remove EXFUN.
5239
8e4fd1e1
GM
52402012-07-03 Glenn Morris <rgm@gnu.org>
5241
5242 * lisp.h (Frandom): Make it visible to C.
5243 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
5244 buffer for invisible buffers. (Bug#1229)
5245
ca95b3eb
DA
52462012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5247
5248 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
5249 values which aren't power of 2.
14ae4239
BT
5250 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
5251 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
5252 accordingly.
5253
7555c33f
SM
52542012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
5255
5256 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
5257
5258 * alloc.c (mark_object): Revert part of last patch to use `switch'.
5259
d12e8f5a
DA
52602012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5261
5262 * alloc.c (allocate_vector_block): Remove redundant
5263 calls to mallopt if DOUG_LEA_MALLOC is defined.
5264 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
5265 avoid calls to mallopt if zero_vector is returned.
5266
296094c3
DA
52672012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5268
5269 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
5270 is enabled, avoid dereferencing NULL current_sblock if
5271 running undumped.
5272
36429c89
DA
52732012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5274
5275 Cleanup basic buffer management.
5276 * buffer.h (struct buffer): Change layout to use generic vector
5277 marking code. Fix some comments. Change type of 'clip_changed'
5278 to bitfield. Remove unused #ifndef old.
5279 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
5280 (GET_OVERLAYS_AT): Fix indentation.
5281 (for_each_per_buffer_object_at): New macro.
5282 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
5283 (Fbuffer_local_variables): Use it.
5284 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
5285 * alloc.c (allocate_buffer): Adjust to match new layout of
5286 struct buffer. Fix comment.
5287 (mark_overlay): New function.
5288 (mark_buffer): Use it. Use mark_vectorlike to mark normal
5289 Lisp area of struct buffer.
5290 (mark_object): Use it. Adjust marking of misc objects
5291 and related comments.
5292
3b3e4cac
PE
52932012-07-02 Paul Eggert <eggert@cs.ucla.edu>
5294
5295 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
5296 wrapper that is not needed because the wrapped code is a no-op (zero
5297 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
5298 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
5299
cf5c0175
DA
53002012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
5301
5302 * alloc.c (mark_buffer): Simplify. Remove prototype.
5303 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 5304 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
5305 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
5306 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 5307
ca26824c
GM
53082012-06-30 Glenn Morris <rgm@gnu.org>
5309
2e4c5312
GM
5310 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
5311
ca26824c
GM
5312 * epaths.in (PATH_SITELOADSEARCH): New.
5313 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
5314 This is rather than relying on --enable-locallisppath elements
5315 having "site-lisp" in their names. (Bug#10208#25, 11658)
5316
0d23c240
EZ
53172012-06-30 Eli Zaretskii <eliz@gnu.org>
5318
c9240d7a
EZ
5319 * w32proc.c (sys_select): Accept and ignore one more argument.
5320
5321 * w32.c (emacs_gnutls_pull): Call select with one more argument.
5322
0d23c240 5323 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 5324 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
5325
5326 * sysdep.c: Don't include dos.h and dosfns.h.
5327
5328 * process.c (sys_select):
5329 * msdos.c (sys_select): Accept one more argument and ignore it.
5330
5331 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
5332 adapt data types and code to that.
5333
5334 * dosfns.c:
5335 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
5336 which clashes with the gnulib function of the same name.
5337
af5a5a98
AS
53382012-06-30 Andreas Schwab <schwab@linux-m68k.org>
5339
c5e4379c
AS
5340 * font.c (font_style_to_value, font_style_symbolic)
5341 (font_prop_validate_style): Add type checks for values in
5342 font_style_table.
5343
af5a5a98
AS
5344 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
5345 argument.
5346 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
5347 uses.
5348
8d38f461
EZ
53492012-06-29 Eli Zaretskii <eliz@gnu.org>
5350
2e5a6631
EZ
5351 * xdisp.c (try_window_id): Undo last change.
5352
8d38f461
EZ
5353 * w32.c (getwd): Adjust commentary about startup_dir.
5354 (init_environment): Always call sys_access, even in non-MSVC
5355 builds. Don't chdir to the directory of the Emacs executable.
5356 This undoes code from 1997 which was justified by the need to
5357 "avoid conflicts when removing and renaming directories". But its
5358 downside was that every relative file name was being interpreted
5359 relative to the directory of the Emacs executable, which can never
5360 be TRT. In particular, it broke sys_access when called with
5361 relative file names.
5362 (sys_access): Map GetLastError to errno.
5363
2af3565e
DA
53642012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5365
5366 * window.h (struct window): Change type of 'fringes_outside_margins'
5367 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 5368 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
5369 Adjust comment.
5370 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
5371 to ptrdiff_t.
5372
c8d3a25c 53732012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 5374
c8d3a25c
GM
5375 * gnutls.c (emacs_gnutls_handshake):
5376 Add QUIT to make the loop interruptible.
57570cd3 5377
c8d3a25c 53782012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 5379
c8d3a25c
GM
5380 * charset.c (init_charset): Make lack of etc/charsets fatal.
5381
3e984ee8
DA
53822012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5383
5384 * editfns.c (region_limit): Fix type mismatch.
5385
ef884f23
DA
53862012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5387
5388 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
5389 undefined. Convert from xassert to eassert.
5390 * nsmenu.m: Convert from xassert to eassert.
5391 * nsterm.m: Likewise.
5392
7d7e0027
SM
53932012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
5394
5395 * editfns.c (region_limit): Clip to narrowing (bug#11770).
5396
aa754e6a
PE
53972012-06-28 Paul Eggert <eggert@cs.ucla.edu>
5398
5399 Avoid integer overflow on scroll-left and scroll-right.
5400 * window.c (HSCROLL_MAX): New macro.
5401 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
5402 overflow when requested scroll falls outside ptrdiff_t range.
5403
80b00b08
DA
54042012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5405
5406 * window.h (struct window): Change type of 'hscroll',
5407 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
5408 'last_modified' and 'last_overlay_modified' to EMACS_INT.
5409 Adjust users accordingly.
5410 * xdisp.c (try_cursor_movement): Replace type check with eassert.
5411 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
5412 from EMACS_INT to ptrdiff_t.
5413 (make_window): Omit redundant initialization.
5414
62b2bcf6
JB
54152012-06-28 Juanma Barranquero <lekktu@gmail.com>
5416
5417 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
5418
45942c7d
DA
54192012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5420
5421 * window.h (struct window): Change type of 'use_time' and
5422 'sequence_number' from Lisp_Object to int.
5423 * frame.c (make_frame): Adjust users accordingly.
5424 * print.c (print_object): Likewise.
5425 * window.c (select_window, Fwindow_use_time, make_parent_window)
5426 (make_window): Likewise.
5427
e509cfa6
DA
54282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5429
5430 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
5431 enabled with --enable-checking=[all,glyphs] configure option.
5432 Fix GLYPH_DEBUG usage assuming that it may be undefined,
5433 adjust comments accordingly.
5434 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
5435 undefined, adjust comments accordingly.
5436 * image.c: Likewise.
5437 * scroll.c: Likewise.
5438 * w32fns.c: Likewise.
5439 * w32term.c: Likewise.
5440 * xdisp.c: Likewise.
5441 * xfaces.c: Likewise.
5442 * xfns.c: Likewise.
5443 * xterm.c: Likewise.
5444
a54e2c05
DA
54452012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5446
5447 Generalize run-time debugging checks.
5448 * dispextern.h (XASSERTS): Remove.
5449 * fontset.c (xassert): Remove.
5450 Convert from xassert to eassert.
5451 * alloc.c: Convert from xassert to eassert.
5452 * bidi.c: Likewise.
5453 * dispnew.c: Likewise.
5454 * fns.c: Likewise.
5455 * fringe.c: Likewise.
5456 * ftfont.c: Likewise.
5457 * gtkutil.c: Likewise.
5458 * image.c: Likewise.
5459 * keyboard.c: Likewise.
5460 * menu.c: Likewise.
5461 * process.c: Likewise.
5462 * scroll.c: Likewise.
5463 * sound.c: Likewise.
5464 * term.c: Likewise.
5465 * w32console.c: Likewise.
5466 * w32fns.c: Likewise.
5467 * w32term.c: Likewise.
5468 * window.c: Likewise.
5469 * xdisp.c: Likewise.
5470 * xfaces.c: Likewise.
5471 * xfns.c: Likewise.
5472 * xselect.c: Likewise.
5473 * xterm.c: Likewise.
5474
1ec4b7b2
SM
54752012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
5476
5477 * fns.c (maybe_resize_hash_table): Output message when growing the
5478 purify-hashtable.
5479
2014308a
DA
54802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5481
5482 * alloc.c (allocate_string_data): Remove dead code.
5483 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
5484 avoid GCC warning about unused macro.
5485
246155eb
DA
54862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5487
5488 * alloc.c (allocate_string): Omit intervals initialization.
5489 * alloc.c (make_uninit_multibyte_string): Initialize intervals
5490 as in make_pure_string and make_pure_c_string.
5491
43184b7b
DA
54922012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5493
d209e2fb 5494 * alloc.c (allocate_string): Fix last change.
43184b7b 5495
3fe6dd74
DA
54962012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5497
d209e2fb 5498 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
5499 to memset, add explicit initialization where appropriate.
5500
1ba6038a
GM
55012012-06-27 Glenn Morris <rgm@gnu.org>
5502
5503 * lisp.mk (lisp): Remove paths.elc.
5504
c89926a5
CY
55052012-06-27 Chong Yidong <cyd@gnu.org>
5506
5507 * doc.c (Fsubstitute_command_keys): Fix punctuation.
5508
ed6b3510
JW
55092012-06-26 John Wiegley <johnw@newartisans.com>
5510
1ec4b7b2 5511 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
5512 on Mac OS X Lion: __mod_init_func and __mod_term_func.
5513
ed6b3510
JW
5514 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
5515 when building with Clang.
5516
8edd4a2b
SM
55172012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
5518
5519 * eval.c (Fapply): Allow calling it with a single argument.
5520
f6f62d1b
EZ
55212012-06-26 Eli Zaretskii <eliz@gnu.org>
5522
5523 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
5524 _stricmp and _strnicmp.
5525 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
5526
62efea5e
DA
55272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5528
5529 * alloc.c (allocate_window): Zero out non-Lisp part of newly
5530 allocated window.
5531 (allocate_process): Likewise for new process.
8edd4a2b 5532 (allocate_terminal): Change to use offsetof.
62efea5e
DA
5533 (allocate_frame): Likewise.
5534 * frame.c (make_frame): Omit redundant initialization.
5535 * window.c (make_parent_window): Use memset.
5536 (make_window): Omit redundant initialization.
5537 * process.c (make_process): Omit redundant initialization.
5538 * terminal.c (create_terminal): Likewise.
5539
42997f4d
DA
55402012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5541
5542 * term.c (delete_tty): Remove redundant call to memset.
5543
1130ecfc
DA
55442012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5545
5546 * alloc.c: Remove build_string.
5547 * lisp.h: Define build_string as static inline. This provides
5548 a better opportunity to optimize away calls to strlen when the
5549 function is called with compile-time constant argument.
5550 * image.c (imagemagick_error): Convert to build_string.
5551 * w32proc.c (sys_spawnve): Likewise.
5552 * xterm.c (x_term_init): Likewise.
5553
cf38a720
PE
55542012-06-26 Paul Eggert <eggert@cs.ucla.edu>
5555
99027bdd
PE
5556 Use sprintf return value instead of invoking strlen on result.
5557 In the old days this wasn't portable, since some sprintf
5558 implementations returned char *. But they died out years ago and
5559 Emacs already assumes sprintf returns int.
5560 Similarly for float_to_string.
5561 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
5562 * ccl.c (ccl_driver):
5563 * character.c (string_escape_byte8):
5564 * data.c (Fnumber_to_string):
5565 * doprnt.c (doprnt):
5566 * print.c (print_object):
5567 * xdisp.c (message_dolog):
5568 * xfns.c (syms_of_xfns):
5569 Use sprintf or float_to_string result to avoid need to call strlen.
5570 * data.c (Fnumber_to_string):
5571 Use make_unibyte_string, since the string must be ASCII.
5572 * lisp.h, print.c (float_to_string): Now returns int length.
5573 * term.c (produce_glyphless_glyph):
5574 Use sprintf result rather than recomputing it.
5575
cf38a720
PE
5576 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
5577 * Makefile.in (ALL_CFLAGS):
5578 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
5579 * gmalloc.c, regex.c: Include <config.h> unconditionally.
5580
3511c784
DA
55812012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5582
0a08eb21 5583 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
5584 strcasecmp if available.
5585 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
5586
fb7da12e
AS
55872012-06-25 Andreas Schwab <schwab@linux-m68k.org>
5588
5589 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
5590 Avoid comma operator.
5591 * menu.c (push_submenu_start, push_submenu_end)
5592 (push_left_right_boundary, push_menu_pane): Likewise.
5593 * msdos.c (dos_rawgetc): Likewise.
5594
afa2ffd8
DA
55952012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5596
5597 * xfns.c (xic_create_fontsetname): Remove redundant calls
5598 to memset.
5599
b3b4476b
PE
56002012-06-25 Paul Eggert <eggert@cs.ucla.edu>
5601
4495ff38
PE
5602 * gtkutil.c (get_utf8_string): Remove redundant assignment.
5603 sprintf already null-terminates its output.
5604
b3b4476b
PE
5605 * xfns.c (x_window): Remove redundant cast.
5606
b00876c9
DA
56072012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5608
5609 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
5610 `const char *' to `char *' to avoid compiler warning.
5611
d188e26b
PE
56122012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5613
885d1d74
PE
5614 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
5615 instead of truncating it to 63 (admittedly a generous limit).
5616
d188e26b
PE
5617 * process.c: Fix spelling and caps in comments.
5618
e2f560b1
DN
56192012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
5620
e86db54b 5621 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
5622 * sysdep.c (setpgrp): Remove definition, not used in this file.
5623
7583a3a1
JB
56242012-06-24 Juanma Barranquero <lekktu@gmail.com>
5625
5626 * makefile.w32-in: Update dependencies.
5627
696056c2
EZ
56282012-06-24 Eli Zaretskii <eliz@gnu.org>
5629
5630 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
5631 (SYSTIME_H): Add nt/inc/sys/time.h.
5632
5633 * systime.h [WINDOWSNT]: Include sys/time.h.
5634
5635 * s/ms-w32.h (struct timespec): Definition moved from
5636 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
5637
845ca893
PE
56382012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5639
5640 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
5641 * buffer.h (buffer_slot_type_mismatch):
5642 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
5643 * eval.c (unwind_to_catch):
5644 * image.c (my_png_error, my_error_exit):
5645 * keyboard.c (quit_throw_to_read_char, user_error)
5646 (Fexit_recursive_edit, Fabort_recursive_edit):
5647 * lisp.h (die, args_out_of_range, args_out_of_range_3)
5648 (wrong_type_argument, buffer_overflow, __executable_start)
5649 (memory_full, buffer_memory_full, string_overflow, Fthrow)
5650 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
5651 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
5652 (fatal):
5653 (child_setup) [!DOS_NT]:
5654 * lread.c (end_of_file_error, invalid_syntax):
5655 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
5656 * puresize.h (pure_write_error):
5657 * search.c (matcher_overflow):
5658 * sound.c (sound_perror, alsa_sound_perror):
5659 * sysdep.c, syssignal.h (croak):
5660 * term.c (maybe_fatal, vfatal):
5661 * textprop.c (text_read_only):
5662 * undo.c (user_error):
5663 * unexmacosx.c (unexec_error):
5664 * xterm.c (x_ins_del_lines, x_delete_glyphs):
5665 Use _Noreturn rather than NO_RETURN.
5666 No need for separate decl merely because of _Noreturn.
5667 * sound.c (sound_warning, parse_sound):
5668 Remove unnecessary forward decls.
5669
f1dd8073
PE
56702012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5671
5672 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
5673 * lisp.h (WAIT_READING_MAX): New macro.
5674 * dispnew.c (Fsleep_for, sit_for):
5675 * keyboard.c (kbd_buffer_get_event):
5676 * process.c (Faccept_process_output):
5677 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
5678 This improves on the previous patch, which introduced a bug
5679 when time_t is unsigned and as wide as intmax_t.
5680 See <http://bugs.gnu.org/9000#51>.
5681
b82c1755
EZ
56822012-06-23 Eli Zaretskii <eliz@gnu.org>
5683
5684 * dispnew.c (sit_for, Fsleep_for):
5685 * keyboard.c (kbd_buffer_get_event):
5686 * process.c (Faccept_process_output): Avoid compiler warnings when
5687 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
5688
ca300656
JB
56892012-06-23 Juanma Barranquero <lekktu@gmail.com>
5690
049ec95b
JB
5691 * makefile.w32-in: Update dependencies.
5692
ca300656
JB
5693 * w32.c (ltime): Add return type and declare static.
5694 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
5695
db7b8d06
PE
56962012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5697
5698 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
5699 Privately reported by Herbert J. Skuhra.
5700 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
5701 All uses changed.
5702 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
5703 not make_lisp_timeval, when the argument is of type EMACS_TIME.
5704
0bd8297f
EZ
57052012-06-23 Eli Zaretskii <eliz@gnu.org>
5706
96512555
EZ
5707 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
5708 last argument of make_unibyte_string.
5709
0bd8297f
EZ
5710 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
5711 language ID in the event parameters.
5712
5713 * w32term.c (w32_read_socket): Put the new keyboard codepage into
5714 event.code, not the obscure "character set ID".
5715
63def6b6
CY
57162012-06-23 Chong Yidong <cyd@gnu.org>
5717
5718 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
5719
e8a02204
EZ
57202012-06-23 Eli Zaretskii <eliz@gnu.org>
5721
388cdec0
EZ
5722 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
5723 * w32.c (fdutimens): New function.
5724
5725 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
5726
5727 * s/ms-w32.h (pselect): Redirect to sys_select.
5728
5729 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
5730
e8a02204
EZ
5731 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
5732 in the logic of incrementing and decrementing the value of
5733 use_relocatable_buffers.
5734
d054f3fb
PE
57352012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5736
5737 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
5738 Privately reported by Herbert J. Skuhra.
5739 [__FreeBSD__]: Remove "*/" typo after "#include".
5740 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
5741 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
5742 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
5743 Don't assume EMACS_TIME and struct timeval are the same type.
5744
d35af63c
PE
57452012-06-22 Paul Eggert <eggert@cs.ucla.edu>
5746
5747 Support higher-resolution time stamps (Bug#9000).
5748 The time stamps are only nanosecond-resolution at the C level,
5749 since that's the best that any real-world system supports now.
5750 But they are picosecond-resolution at the Lisp level, as that's
5751 easy, and leaves room for future OS improvements.
5752
5753 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
5754 (LIBES): Use it.
5755
5756 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
5757 Don't get current time unless it's needed.
5758
5759 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
5760 now provides it if it's absent.
5761 (start_atimer): Port to higher-res time stamps.
5762 Check for time stamp overflow. Don't get current time more
5763 often than is needed.
5764
5765 * buffer.h (struct buffer): Buffer modtime now has high resolution.
5766 Include systime.h, not time.h.
5767 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
5768
5769 * dired.c: Include stat-time.h.
5770 (Ffile-attributes): File times now have higher resolution.
5771
5772 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
5773 (struct image): Timestamp now has higher resolution.
5774
5775 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
5776 has at least microseconds now. All uses removed.
5777 (update_frame, update_single_window, update_window, update_frame_1)
5778 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 5779 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
5780
5781 * editfns.c (time_overflow): Now extern.
5782 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
5783 (float-time, Fformat_time_string, Fcurrent_time_string)
5784 (Fcurrent_time_zone): Accept and generate higher-resolution
5785 time stamps.
5786 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
5787 (decode_time_components, lisp_seconds_argument): New functions.
5788 (make_time): Now static.
5789 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
5790 Report an error if the time is invalid, rather than having the caller
5791 do that.
5792
5793 * fileio.c: Include <stat-time.h>
5794 (Fcopy_file): Copy higher-resolution time stamps.
5795 Prefer to set the time stamp via a file descriptor if that works.
5796 (Fset_file_times, Finsert_file_contents, Fwrite_region)
5797 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
5798 (Fvisited_file_modtime, Fset_visited_file_modtime):
5799 Support higher-resolution time stamps.
5800
5801 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
5802
5803 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
5804
5805 * image.c (prepare_image_for_display, clear_image_cache)
5806 (lookup_image): Port to higer-resolution time stamps.
5807
5808 * keyboard.c (start_polling, bind_polling_period):
5809 Check for time stamp overflow.
5810 (read_char, kbd_buffer_get_event, timer_start_idle)
5811 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
5812 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
5813 Port to higher-resolution time stamps. Do not assume time_t is signed.
5814 (decode_timer): New function. Timers are now vectors of length 9,
5815 not 8, to accommodate the picosecond component.
5816 (timer_check_2): Use it.
5817
5818 * nsterm.m (select_timeout, timeval_subtract): Remove.
5819 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
5820 as they're a bit more accurate and handle overflow better.
5821 (ns_select): Change prototype to be compatible with pselect.
5822 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
5823 * nsterm.h (ns_select): Adjust prototype.
5824
5825 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
5826 us-resolution time stamps.
5827 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
5828
5829 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
5830
5831 * lisp.h (time_overflow): New decl.
5832 (wait_reading_process_output): First arg is now intmax_t, not int,
5833 to accommodate larger waits.
5834
5835 * process.h (struct Lisp_Process.read_output_delay):
5836 Now counts nanoseconds, not microseconds.
5837 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
5838 EMACS_HAS_USECS.
5839 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
5840 (wait_reading_process_output):
5841 Port to ns-resolution time stamps.
5842 (Faccept_process_output, wait_reading_process_output):
5843 Check for time stamp overflow. Do not assume time_t is signed.
5844 (select_wrapper): Remove; we now use pselect.
5845 (Fprocess_attributes): Now generates ns-resolution time stamps.
5846
5847 * sysdep.c: Include utimens.h. Don't include utime.h
5848 or worry about struct utimbuf; gnulib does that for us now.
5849 (gettimeofday): Remove; gnulib provides a substitute.
5850 (make_timeval): New function.
5851 (set_file_times): Now sets ns-resolution time stamps.
5852 New arg FD; all uses changed.
5853 (time_from_jiffies, ltime_from_jiffies, get_up_time)
5854 (system_process_attributes):
5855 Now returns ns-resolution time stamp. All uses changed.
5856 Check for time stamp overflow.
5857
5858 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
5859 provides a substitute now.
5860
5861 * systime.h: Include timespec.h rather than sys/time.h and time.h,
5862 since it guarantees struct timespec.
5863 (EMACS_TIME): Now struct timespec, so that we can support
5864 ns-resolution time stamps.
5865 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
5866 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
5867 (EMACS_USECS): Remove.
5868 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
5869 so multiply the arg by 1000 before storing it.
5870 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
5871 New macros.
5872 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
5873 Port to ns-resolution time stamps.
5874 (EMACS_TIME_NEG_P): Remove; replaced by....
5875 (EMACS_TIME_SIGN): New macro.
5876 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
5877 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
5878 (set_file_times, make_time, lisp_time_argument): Adjust signature.
5879 (make_timeval, make_lisp_time, decode_time_components): New decls.
5880 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
5881 that it mishandled time_t overflow. You can't compare by subtracting!
5882 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
5883 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
5884
5885 * term.c: Include <sys/time.h>.
5886 (timeval_to_Time): New function, for proper overflow wraparound.
5887 (term_mouse_position, term_mouse_click): Use it.
5888
5889 * undo.c (record_first_change): Support higher-resolution time stamps
5890 in the undo buffer.
5891 (Fprimitive_undo): Use them when restoring time stamps.
5892
5893 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
5894 (w32_get_internal_run_time):
5895 Port to higher-resolution Emacs time stamps.
5896 (ltime): Now accepts single 64-bit integer, as that's more convenient
5897 for callers.
5898
5899 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
5900
5901 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
5902 for compatibility with pselect. Support ns-resolution time stamps.
5903
5904 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
5905
5906 * xselect.c (wait_for_property_change, x_get_foreign_selection):
5907 Check for time stamp overflow, and support ns-resolution time stamps.
5908
5909 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
5910 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
5911 (timeval_subtract): Remove; no longer needed.
5912 (XTflash, XTring_bell, x_wait_for_event):
5913 Port to ns-resolution time stamps. Don't assume time_t is signed.
5914
b6a92dfe
CY
59152012-06-22 Chong Yidong <cyd@gnu.org>
5916
5917 * xdisp.c (x_consider_frame_title): Revert last change.
5918
d251c37c
EZ
59192012-06-22 Eli Zaretskii <eliz@gnu.org>
5920
5921 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
5922 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
5923 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
5924 staticidx goes up to 1597 out of 1600 = 0x640.)
5925
f10deafb
PE
59262012-06-20 Paul Eggert <eggert@cs.ucla.edu>
5927
5928 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
5929 Otherwise, the umask might be mistakenly 0 while handling input signals.
5930
ec6de1e2
SM
59312012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
5932
5933 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
5934
28be1ada
DA
59352012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
5936
5937 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
5938 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
5939 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
5940 access to `contents' member of Lisp_Vector objects with AREF and ASET
5941 where appropriate.
5942
c6bf3022
CY
59432012-06-19 Chong Yidong <cyd@gnu.org>
5944
5945 * frame.c (delete_frame): When selecting a frame on a different
5946 text terminal, do not alter the terminal's top-frame.
5947
5948 * xdisp.c (format_mode_line_unwind_data): Record the target
5949 frame's selected window and its terminal's top-frame.
5950 (unwind_format_mode_line): Restore them.
5951 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
5952 Callers changed.
5953 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
5954 since tty frames can be explicitly named.
5955 (prepare_menu_bars): Likewise.
5956
5957 * term.c (Ftty_top_frame): New function.
5958
defd4196
PE
59592012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5960
5961 Port byte-code-meter to modern targets.
5962 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
5963 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 5964 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
5965 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
5966 (METER_1, METER_2): Simplify.
5967
1053a871
SM
59682012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
5969
5970 * data.c (Fdefalias): Return `symbol' (bug#11686).
5971
b7e8d081
MR
59722012-06-18 Martin Rudalics <rudalics@gmx.at>
5973
5974 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
5975 gets killed during executing of this function (Bug#11665).
5976 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
5977 (Vkill_buffer_query_functions): In doc-string say that functions
5978 run by this hook should not change the current buffer.
5979
7ea2b339
PE
59802012-06-18 Paul Eggert <eggert@cs.ucla.edu>
5981
5982 Fix recently-introduced process.c problems found by static checking.
5983 * process.c (write_queue_push, write_queue_pop, send_process):
5984 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
5985 (write_queue_pop): Fix pointer signedness problem.
5986 (send_process): Remove unused local.
5987
96a313a1
CY
59882012-06-17 Chong Yidong <cyd@gnu.org>
5989
5990 * xdisp.c (redisplay_internal): No need to redisplay terminal
5991 frames that are not on top.
5992
20ca2e94
TN
59932012-06-17 Troels Nielsen <bn.troels@gmail.com>
5994
5995 * process.c (make_process): Initialize write_queue.
5996 (write_queue_push, write_queue_pop): New functions.
5997 (send_process): Use them to maintain correct ordering of process
5998 writes (Bug#10815).
5999
9a900ca9
PE
60002012-06-17 Paul Eggert <eggert@cs.ucla.edu>
6001
310fbfa8
PE
6002 * lisp.h (eassert): Assume C89 or later.
6003 This removes the need for CHECK.
6004 (CHECK): Remove. Its comments about always evaluating its
6005 argument were confusing, as 'eassert' typically does not evaluate
6006 its argument.
6007
27bb1ca4
PE
6008 * coding.c (produce_chars): Use ptrdiff_t, not int.
6009
9a900ca9
PE
6010 * xterm.c (x_draw_underwave): Check for integer overflow.
6011 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
6012
41b7f8bc 60132012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
6014
6015 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
6016 referenced (Bug#11583).
6017
9b0e3eba
AA
60182012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
6019
6020 Implement wave-style variant of underlining.
6021 * dispextern.h (face_underline_type): New enum.
6022 (face): Add field for underline type.
6023 * nsterm.m (ns_draw_underwave): New function.
6024 (ns_draw_text_decoration): Use it.
6025 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
6026 New functions.
6027 (x_draw_glyph_string): Use them.
6028 * xfaces.c (Qline, Qwave): New Lisp objects.
6029 (check_lface_attrs, merge_face_ref)
1053a871
SM
6030 (Finternal_set_lisp_face_attribute, realize_x_face):
6031 Handle wave-style underline face attributes.
9b0e3eba
AA
6032 * xterm.c (x_draw_underwave): New function.
6033 (x_draw_glyph_string): Use it.
6034
0fb52f11
JB
60352012-06-16 Juanma Barranquero <lekktu@gmail.com>
6036
6037 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
6038 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
6039 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
6040 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
6041 ($(BLD)/w32select.$(O)): Update dependencies.
6042
e5560ff7
AS
60432012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6044
6045 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
6046 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
6047 * character.c (_fetch_multibyte_char_p): Remove.
6048 * alloc.c: Include "character.h" before "buffer.h".
6049 * bidi.c: Likewise.
6050 * buffer.c: Likewise.
6051 * bytecode.c: Likewise.
6052 * callint.c: Likewise.
6053 * callproc.c: Likewise.
6054 * casefiddle.c: Likewise.
6055 * casetab.c: Likewise.
6056 * category.c: Likewise.
6057 * cmds.c: Likewise.
6058 * coding.c: Likewise.
6059 * composite.c: Likewise.
6060 * dired.c: Likewise.
6061 * dispnew.c: Likewise.
6062 * doc.c: Likewise.
6063 * dosfns.c: Likewise.
6064 * editfns.c: Likewise.
6065 * emacs.c: Likewise.
6066 * fileio.c: Likewise.
6067 * filelock.c: Likewise.
6068 * font.c: Likewise.
6069 * fontset.c: Likewise.
6070 * fringe.c: Likewise.
6071 * indent.c: Likewise.
6072 * insdel.c: Likewise.
6073 * intervals.c: Likewise.
6074 * keyboard.c: Likewise.
6075 * keymap.c: Likewise.
6076 * lread.c: Likewise.
6077 * macros.c: Likewise.
6078 * marker.c: Likewise.
6079 * minibuf.c: Likewise.
6080 * nsfns.m: Likewise.
6081 * nsmenu.m: Likewise.
6082 * print.c: Likewise.
6083 * process.c: Likewise.
6084 * regex.c: Likewise.
6085 * region-cache.c: Likewise.
6086 * search.c: Likewise.
6087 * syntax.c: Likewise.
6088 * term.c: Likewise.
6089 * textprop.c: Likewise.
6090 * undo.c: Likewise.
6091 * unexsol.c: Likewise.
6092 * w16select.c: Likewise.
6093 * w32fns.c: Likewise.
6094 * w32menu.c: Likewise.
6095 * window.c: Likewise.
6096 * xdisp.c: Likewise.
6097 * xfns.c: Likewise.
6098 * xmenu.c: Likewise.
6099 * xml.c: Likewise.
6100 * xselect.c: Likewise.
6101
2f07e6af
EZ
61022012-06-16 Eli Zaretskii <eliz@gnu.org>
6103
1053a871
SM
6104 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
6105 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 6106 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
6107 row.
6108 (handle_face_prop): Use chunk-relative overlay string index when
6109 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
6110 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
6111 the rightmost. (Bug#11720)
2f07e6af 6112
29b83cec
AS
61132012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6114
6115 * category.h (CHAR_HAS_CATEGORY): Define as inline.
6116 (CATEGORY_MEMBER): Enforce 1/0 value.
6117 * category.c (_temp_category_set): Remove.
6118
4c5501e9
EZ
61192012-06-16 Eli Zaretskii <eliz@gnu.org>
6120
6121 * window.c (Fdelete_other_windows_internal)
6122 (Fdelete_window_internal): Don't access frame's mouse highlight
6123 info of the initial frame. (Bug#11677)
6124
2b570124
PE
61252012-06-14 Paul Eggert <eggert@cs.ucla.edu>
6126
e93864f9
PE
6127 * .gdbinit (xgetint): Fix recently-introduced paren typo.
6128 Assume USE_2_TAGS_FOR_INTS.
6129 (xreload): Adjust $tagmask width to match recent lisp.h change.
6130
2b570124
PE
6131 Simplify lisp.h in minor ways that should not affect code.
6132 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
6133 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
6134 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
6135 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
6136 (INTTYPEBITS): New macro, for clarity.
6137 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
6138 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
6139 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
6140 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
6141 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
6142
81755f69
JB
61432012-06-13 Juanma Barranquero <lekktu@gmail.com>
6144
6145 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
6146
16192a57
GM
61472012-06-13 Glenn Morris <rgm@gnu.org>
6148
6149 * s/bsd-common.h (BSD4_3):
6150 * s/usg5-4-common.h (USG5_4): No longer define; unused.
6151
646b5f55
AS
61522012-06-13 Andreas Schwab <schwab@linux-m68k.org>
6153
6154 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
6155 instead of union.
6156 (XLI, XIL): Define.
1053a871
SM
6157 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
6158 Use them.
6159 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 6160 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 6161 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
6162 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
6163 * frame.c (delete_frame): Remove outdated comment.
6164 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
6165 USE_LISP_UNION_TYPE.
6166 (Fw32_unregister_hot_key): Likewise.
6167 (Fw32_toggle_lock_key): Likewise.
6168 * w32menu.c (add_menu_item): Likewise.
6169 (w32_menu_display_help): Use XIL instead of checking
6170 USE_LISP_UNION_TYPE.
6171 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
6172 (init_heap): Likewise.
6173 * w32term.c (w32_read_socket): Update comment.
6174
1d3823c9
GM
61752012-06-13 Glenn Morris <rgm@gnu.org>
6176
c62ff706
GM
6177 * s/usg5-4-common.h, src/s/unixware.h:
6178 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
6179
1d3823c9
GM
6180 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
6181
bfe3e0a2
PE
61822012-06-13 Paul Eggert <eggert@cs.ucla.edu>
6183
6184 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
6185 * alloc.c (make_number) [!defined make_number]:
6186 Remove, as lisp.h always defines this now.
6187 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
6188 (roundup_size): Verify that it is a power of 2.
6189 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
6190 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
6191 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
6192 -DUSE_LSB_TAG=0, to override the automatically-selected default.
6193 USE_LSB_TAG now is always defined to be either 0 or 1.
6194 All uses changed.
6195 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
6196 code works fine either way, and efficiency is not a concern here,
6197 as the union type is for debugging, not for production.
6198 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
6199 Use an inline function on all platforms when using the union type,
6200 since this is simpler and 'static inline' can be used portably
6201 within Emacs now.
6202 (LISP_INITIALLY_ZERO): New macro.
6203 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
6204 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
6205
45fa9c0f
GM
62062012-06-12 Glenn Morris <rgm@gnu.org>
6207
b4492cba
GM
6208 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
6209
6210 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 6211
45fa9c0f
GM
6212 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
6213 Move BROKEN_SIGIO to configure.
6214
6215 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
6216 Move NO_TERMIO to configure.
6217
0e25d334
CY
62182012-06-12 Chong Yidong <cyd@gnu.org>
6219
6220 * image.c (imagemagick_load_image): Use MagickFlattenImage if
6221 MagickMergeImageLayers is undefined. Use pixel pusher loop if
6222 MagickExportImagePixels is undefined.
6223
43682bb6
PE
62242012-06-12 Paul Eggert <eggert@cs.ucla.edu>
6225
6226 * image.c (imagemagick_load_image): Remove unused label.
6227
a9be7d2b
GM
62282012-06-11 Glenn Morris <rgm@gnu.org>
6229
6230 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
6231 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
6232 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
6233 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
6234
3017f87f
SM
62352012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
6236
6237 * alloc.c (make_byte_code): New function.
6238 (Fmake_byte_code): Use it. Don't purify here.
6239 * lread.c (read1): Use it as well to avoid extra allocation.
6240
1b9b4cf4
CY
62412012-06-11 Chong Yidong <cyd@gnu.org>
6242
6243 * image.c (imagemagick_load_image): Implement transparency.
6244
95988fcf
AS
62452012-06-10 Andreas Schwab <schwab@linux-m68k.org>
6246
6247 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
6248 account for preceding backslashes. (Bug#11663)
6249
cd4eb164
CY
62502012-06-09 Chong Yidong <cyd@gnu.org>
6251
6252 * term.c: Support italics in capable terminals (Bug#9652).
6253 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
6254 (turn_on_face): Output using TS_enter_italic_mode if available.
6255 Don't handle unused blinking and alt-charset cases.
6256 (turn_off_face): Handle italic case; discard unused tty_blinking_p
6257 and tty_alt_charset_p cases.
6258 (tty_capable_p, init_tty): Support italics.
6259
6260 * termchar.h (struct tty_display_info): Add field for italics.
6261 Remove unused blink field.
6262
6263 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
6264 Handle slant.
6265
6266 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
6267 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
6268 tty_alt_charset_p. Add tty_italic_p.
6269
ff88beb8
MA
62702012-06-09 Michael Albinus <michael.albinus@gmx.de>
6271
6272 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
6273 dbus_type_is_basic if available.
6274 (xd_extract_signed, xd_extract_unsigned): Rename from
6275 extract_signed and extract_unsigned, respectively. Adapt callers.
6276
44286096
CY
62772012-06-09 Chong Yidong <cyd@gnu.org>
6278
1682701f
CY
6279 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
6280
44286096
CY
6281 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
6282 case (Bug#9752).
6283
d86feb17
PE
62842012-06-08 Paul Eggert <eggert@cs.ucla.edu>
6285
6286 * xdisp.c (vmessage): Treat frame message as multibyte.
6287 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
6288 would generate the diagnostic "Making \302\247 buffer-local while
6289 let-bound!".
6290
d5c20fe8
EZ
62912012-06-08 Eli Zaretskii <eliz@gnu.org>
6292
6293 * dispnew.c (showing_window_margins_p): Undo last change, which
6294 was done due to an inadvertent commit.
6295 (adjust_frame_glyphs_for_frame_redisplay): Do call
6296 showing_window_margins_p.
6297
513749ee
SM
62982012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6299
6300 * eval.c (Fmake_var_non_special): New primitive.
6301 (syms_of_eval): Defsubr it.
6302 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
6303
d4a8f5c1
JB
63042012-06-08 Juanma Barranquero <lekktu@gmail.com>
6305
6306 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
6307 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
6308
8bbbc977
EZ
63092012-06-08 Eli Zaretskii <eliz@gnu.org>
6310
6311 * alloc.c (allocate_vectorlike): Fix last change.
6312
f3372c87
DA
63132012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
6314
6315 Block-based vector allocation of small vectors.
6316 * lisp.h (struct vectorlike_header): New field `nbytes',
6317 adjust comment accordingly.
6318 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 6319 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
6320 mark_maybe_pointer, valid_lisp_object_p) accordingly.
6321 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
6322 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
6323 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
6324 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
6325 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
6326 (roundup_size): New constant.
6327 (struct vector_block): New data type.
6328 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 6329 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
6330 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
6331 (sweep_vectors): New functions.
6332 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 6333 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
6334 or equal to VBLOCK_BYTES_MAX.
6335 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
6336 (init_alloc_once): Add call to init_vectors.
6337
4f18a4ed
SM
63382012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6339
6340 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
6341
86f158bc
PE
63422012-06-07 Paul Eggert <eggert@cs.ucla.edu>
6343
6344 * doprnt.c (doprnt): Truncate multibyte char correctly.
6345 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
6346 would mishandle a string argument "Xc" if X was a multibyte
6347 character of length 2: it would truncate after X's first byte
6348 rather than including all of X.
6349
c5cfcbe0
CY
63502012-06-06 Chong Yidong <cyd@gnu.org>
6351
6352 * buffer.c (word_wrap): Doc fix.
6353
c05cf390
PE
63542012-06-04 Paul Eggert <eggert@cs.ucla.edu>
6355
6356 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
6357
0c3461de
GM
63582012-06-03 Glenn Morris <rgm@gnu.org>
6359
6360 * xdisp.c (tool-bar-style): Doc fix.
6361
c71232db
UM
63622012-06-03 Ulrich Müller <ulm@gentoo.org>
6363
6364 * Makefile.in (PAXCTL): Define.
6365 (temacs$(EXEEXT)): Disable memory randomization for the temacs
6366 binary via PaX flags if the paxctl utility is available.
6367 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
6368 Restore PaX flags to their default. (Bug#11398)
6369
383f7350
CY
63702012-06-03 Chong Yidong <cyd@gnu.org>
6371
6372 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
6373 buffer (Bug#11226).
6374
5f2c76c6
CY
63752012-06-03 Chong Yidong <cyd@gnu.org>
6376
6377 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
6378 (note_mode_line_or_margin_highlight): If there is no help echo,
6379 use mode-line-default-help-echo. Handle the case where the mouse
6380 position is past the end of the mode line string.
6381
6382 * buffer.c (buffer_local_value_1): New function, split from
6383 Fbuffer_local_value; can return Qunbound.
6384 (Fbuffer_local_value): Use it.
6385 (Vmode_line_format): Docstring tweaks.
6386
773d47f6
PE
63872012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6388
6389 * sysdep.c (system_process_attributes): Improve comment.
6390
f2d6a3df
SM
63912012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
6392
6393 * keyboard.c: Export real-this-command to Elisp.
6394 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
6395 and DEFVAR it. Update all users.
6396
63810350
PE
63972012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6398
7bd5c1f4
PE
6399 * minibuf.c (Fassoc_string): Remove duplicate declaration.
6400
63810350
PE
6401 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
6402 Convert pctcpu and pctmem to Lisp float properly.
6403 Let the compiler fold better, as 100.0/0x8000 is exact.
6404
a2821611
AS
64052012-06-02 Andreas Schwab <schwab@linux-m68k.org>
6406
6407 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
6408 cons_block.
6409
5fceba1d
PE
64102012-06-01 Paul Eggert <eggert@cs.ucla.edu>
6411
6412 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
6413
c98ff5dd
DA
64142012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
6415
6416 For a 'struct window', replace some Lisp_Object fields to
6417 bitfields where appropriate, remove unused fields.
6418 * window.h (struct window): Remove unused 'last_mark_x' and
6419 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
6420 change it's type from Lisp_Object to bitfield.
6421 Change type of 'force_start', 'optional_new_start',
6422 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 6423 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 6424
ca34e0be
PE
64252012-05-31 Paul Eggert <eggert@cs.ucla.edu>
6426
6427 Pacify gcc -Wdouble-precision when using Xaw.
6428 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
6429 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
6430 Use 'float' consistently, rather than 'float' in most places
6431 and 'double' in a couple of places.
6432
efc00ab1 64332012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
6434
6435 * xdisp.c (handle_stop): Detect whether we have overlay strings
6436 loaded by testing it->current.overlay_string_index to be
6437 non-negative, instead of checking whether n_overlay_strings is
6438 positive. (Bug#11587)
6439
efc00ab1 64402012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
6441
6442 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
6443
6444 * doc.c (Fsubstitute_command_keys): Doc fix.
6445
efc00ab1 64462012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
6447
6448 * search.c (search_buffer): Remove calls to
6449 r_alloc_inhibit_buffer_relocation, as it is now called by
6450 maybe_unify_char, which was the cause of relocation of buffer text
6451 in bug#11519.
6452
efc00ab1 64532012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
6454
6455 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
6456 for the duration of call to load_charset, to avoid problems with
6457 callers of maybe_unify_char that access buffer text through C
6458 pointers.
6459
6460 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
6461 decrement the inhibition flag, instead of just setting or
6462 resetting it.
6463
ba93a187
PE
64642012-05-31 Paul Eggert <eggert@cs.ucla.edu>
6465
6466 Remove obsolete '#define static' cruft.
6467 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
6468 This #undef was "temporary" in 2000; it is no longer needed
6469 now that '#define static' has gone away.
6470 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
6471 (gray_bitmap_bits): Remove; no longer needed.
6472 All uses replaced with definiens.
6473 * xterm.c: Include "bitmaps/gray.xbm".
6474
9e4bf381
PE
64752012-05-30 Paul Eggert <eggert@cs.ucla.edu>
6476
6477 Clean up __executable_start, monstartup when --enable-profiling.
6478 The following changes affect the code only when profiling.
6479 * dispnew.c (__executable_start): Rename from safe_bcopy.
6480 Define only on platforms that need it.
6481 * emacs.c: Include <sys/gmon.h> when profiling.
6482 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
6483 (__executable_start): Remove decl, since lisp.h does it now.
6484 (safe_bcopy): Remove decl; no longer has that name.
6485 (main): Coalesce #if into single bit of code, for simplicity.
6486 Cast pointers to uintptr_t, since standard libraries want integers
6487 and not pointers.
6488 * lisp.h (__executable_start): New decl.
6489
32d72c2f
GM
64902012-05-31 Glenn Morris <rgm@gnu.org>
6491
6492 * image.c (Fimagemagick_types): Doc fix.
6493
baac5bc7
JM
64942012-05-30 Jim Meyering <meyering@redhat.com>
6495
6496 * callproc.c (Fcall_process_region): Include directory component
6497 in mkstemp error message (Bug#11586).
6498
72cb32cf
PE
64992012-05-30 Paul Eggert <eggert@cs.ucla.edu>
6500
6501 * alloc.c, lisp.h (make_pure_vector): Now static.
6502
61b108cc
SM
65032012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
6504
6505 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
6506 Move to byte-run.el.
6507 (Fautoload): Do the hash-doc more carefully.
6508 * data.c (Fdefalias): Purify definition, except for keymaps.
6509 (Qdefun): Move from eval.c.
6510 * lisp.h (Qdefun): Remove.
6511 * lread.c (read1): Tiny simplification.
6512
471fe23d
TN
65132012-05-29 Troels Nielsen <bn.troels@gmail.com>
6514
934f3f58 6515 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
6516 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
6517 Bug#9642, but explicitly check that the buffer the overlay would
6518 be moved to is live and rearrange lines to make sure that errors
6519 will not put the overlay in an inconsistent state.
6520 (Fdelete_overlay): Cosmetics.
6521
85d0efd1
EZ
65222012-05-28 Eli Zaretskii <eliz@gnu.org>
6523
6524 * w32term.c (my_bring_window_to_top): New function.
6525 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
6526 could be different from the original one.
6527 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
6528 (Bug#11513)
6529
6530 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
6531 by calling BringWindowToTop.
6532
6533 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
6534 (WM_EMACS_END): Increase by one.
6535
da92a98c
PE
65362012-05-28 Paul Eggert <eggert@cs.ucla.edu>
6537
6538 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
6539 This avoids undefined behavior that might cause the eassert
6540 to not catch an out-of-range value.
6541
74d1f848
JB
65422012-05-28 Juanma Barranquero <lekktu@gmail.com>
6543
6544 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
6545 Update dependencies.
6546
9e1a06fc
EZ
65472012-05-27 Eli Zaretskii <eliz@gnu.org>
6548
6549 * bidi.c (bidi_mirror_char): Fix last change.
6550
f3dd7312
AS
65512012-05-27 Andreas Schwab <schwab@linux-m68k.org>
6552
6553 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
6554 when referring to sectname field in printf format.
6555
81899c91
PE
65562012-05-27 Paul Eggert <eggert@cs.ucla.edu>
6557
57b81a9f
PE
6558 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
6559 Only r_alloc_inhibit_buffer_relocation needed to be added;
6560 the others were already declared.
6561
81899c91
PE
6562 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
6563 before checking whether it's out of range. Put the check inside
6564 eassert. See
6565 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
6566
33017faf 65672012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
6568
6569 * callproc.c (Fcall_process): Restore a line that was accidentally
6570 commented out in the 2011-02-13 change (bug#11547).
6571
33017faf 65722012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
6573
6574 * lisp.h [REL_ALLOC]: Add prototypes for external functions
6575 defined on ralloc.c.
6576
6577 * buffer.c [REL_ALLOC]: Remove prototypes of
6578 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
6579 they are now on lisp.h.
6580
6581 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
6582
6583 * search.c (search_buffer): Use it to inhibit relocation of buffer
6584 text while re_search_2 is doing its job, because re_search_2 is
6585 passed C pointers to buffer text. (Bug#11519)
6586
23415acf
EZ
6587 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
6588 Update value to 24.
6589
44e27368
EZ
6590 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
6591 state after an additional call to move_it_in_display_line_to, keep
6592 the values of it->max_ascent and it->max_descent found for the
6593 entire line.
6594 (pos_visible_p): Revert the comparison against bottom_y to what it
6595 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
6596 (Bug#11464)
6597
c1892f11
PE
65982012-05-26 Paul Eggert <eggert@cs.ucla.edu>
6599
6600 Fix coding-related core dumps with gcc -ftrapv.
6601 The code was computing A - B, where A and B are pointers, and B is
6602 random garbage. This can lead to core dumps on platforms that
6603 have special pointer registers, and it also leads to core dumps on
6604 x86-64 when compiled with gcc -ftrapv. The fix is to compute
6605 A - B only when B is initialized properly.
6606 * coding.c (coding_set_source, coding_set_destination): Return void.
6607 (coding_change_source, coding_change_destinations): New functions,
6608 with the old behaviors of coding_set_source and coding_set_destination.
6609 All callers that need an offset changed to use these new functions.
6610
eb7afdad
GM
66112012-05-26 Glenn Morris <rgm@gnu.org>
6612
6613 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
6614
f12fdf02
EZ
66152012-05-26 Eli Zaretskii <eliz@gnu.org>
6616
53a63be6 6617 Extend mouse support on W32 text-mode console.
61b108cc
SM
6618 * xdisp.c (draw_row_with_mouse_face):
6619 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 6620
eb3f6f01 6621 * w32console.c: Include window.h.
61b108cc
SM
6622 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
6623 New functions.
eb3f6f01
EZ
6624 (initialize_w32_display): Initialize mouse-highlight data.
6625
53a63be6
EZ
6626 * w32inevt.c: Include termchar.h and window.h.
6627 (do_mouse_event): Support mouse-autoselect-window. When the mouse
6628 moves, call note_mouse_highlight. If help_echo changed, call
6629 gen_help_event to produce help-echo message in the echo area.
6630 Call clear_mouse_face if mouse_face_hidden is set in the mouse
6631 highlight info.
6632
4cfd81f6
PE
66332012-05-26 Paul Eggert <eggert@cs.ucla.edu>
6634
6635 * lread.c (read1): Simplify slightly to avoid an overflow warning
6636 with GCC 4.7.0 on x86-64.
6637
4446092a
EZ
66382012-05-26 Eli Zaretskii <eliz@gnu.org>
6639
6640 * bidi.c (bidi_mirror_char): Revert last change: an int is
6641 definitely wide enough here.
6642
42b2a986 66432012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 6644
42b2a986 6645 Fix integer width and related bugs (Bug#9874).
eb106a49 6646 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
6647 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6648 (string_bytes, check_sblock, allocate_string_data):
6649 (compact_small_strings, Fmake_bool_vector, make_string)
6650 (make_unibyte_string, make_multibyte_string)
6651 (make_string_from_bytes, make_specified_string)
6652 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
6653 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
6654 (mark_vectorlike):
6655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6656 (allocate_pseudovector):
6657 Use int, not EMACS_INT, where int is wide enough.
6658 (inhibit_garbage_collection, Fgarbage_collect):
6659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6660 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
6661 int might not be wide enough.
6662 (bidi_cache_search, bidi_cache_find, bidi_init_it)
6663 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
6664 (bidi_at_paragraph_end, bidi_find_paragraph_start)
6665 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6666 (bidi_level_of_next_char, bidi_move_to_visually_next):
6667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6668 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
6669 (Fkill_buffer, Fset_buffer_major_mode)
6670 (advance_to_char_boundary, Fbuffer_swap_text)
6671 (Fset_buffer_multibyte, overlays_at, overlays_in)
6672 (overlay_touches_p, struct sortvec, record_overlay_string)
6673 (overlay_strings, recenter_overlay_lists)
6674 (adjust_overlays_for_insert, adjust_overlays_for_delete)
6675 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
6676 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
6677 (Foverlay_recenter, last_overlay_modification_hooks_used)
6678 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
6679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
6680 (validate_region): Omit unnecessary test for b <= e,
6681 since that's guaranteed by the previous test.
d311d28c
PE
6682 (adjust_overlays_for_delete): Avoid pos + length overflow.
6683 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
6684 (report_overlay_modification):
6685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6686 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
6687 Omit pointer cast, which isn't needed anyway, and doesn't work
6688 after the EMACS_INT -> ptrdiff_t change.
02481186 6689 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
6690 * buffer.h: Adjust decls to match defn changes elsewhere.
6691 (struct buffer_text, struct buffer):
6692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6693 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
6694 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
6695 not int, to avoid needless 32-bit limit on 64-bit hosts.
6696 (exec_byte_code): Use tighter memory-full test, one that checks
6697 for alloca overflow. Don't compute the address of the object just
6698 before an array, as that's not portable. Use EMACS_INT, not
6699 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
6700 * callint.c (Fcall_interactively):
6701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6702 * callproc.c (call_process_kill, Fcall_process):
6703 Don't assume pid_t fits into an Emacs fixnum.
6704 (call_process_cleanup, Fcall_process, child_setup):
6705 Don't assume pid_t fits into int.
6706 (call_process_cleanup, Fcall_process, delete_temp_file)
6707 (Fcall_process_region):
6708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6709 (Fcall_process): Simplify handling of volatile integers.
6710 Use int, not EMACS_INT, where int will do.
6711 * casefiddle.c (casify_object, casify_region, operate_on_word)
6712 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
6713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6714 (casify_object): Avoid integer overflow when overallocating buffer.
6715 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 6716 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
6717 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
6718 * category.h (CATEGORYP): Don't assume arg is nonnegative.
6719 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
6720 integers are now checked earlier. All uses replaced with XINT.
6721 (ccl_driver):
6722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6723 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
6724 (ccl_driver, Fregister_code_conversion_map):
6725 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
6726 (resolve_symbol_ccl_program): Check that vector header is in range.
6727 Always copy the vector, so that we can check its contents reliably
6728 now rather than having to recheck each instruction as it's being
6729 executed. Check that vector words fit in 'int'.
6730 (ccl_get_compiled_code, Fregister_ccl_program)
6731 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
6732 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
6733 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
6734 contents are in range.
6735 (Fccl_execute_on_string): Check that status is in range.
6736 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
6737 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
6738 Accept and return EMACS_INT, not int, because callers can pass values
6739 out of 'int' range.
6740 (c_string_width, strwidth, lisp_string_width, chars_in_text)
6741 (multibyte_chars_in_text, parse_str_as_multibyte)
6742 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
6743 (str_as_unibyte, str_to_unibyte, string_count_byte8)
6744 (string_escape_byte8, Fget_byte):
6745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 6746 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
6747 avoid mishandling large integers.
6748 * character.h: Adjust decls to match defn changes elsewhere.
6749 * charset.c (load_charset_map_from_file, find_charsets_in_text)
6750 (Ffind_charset_region):
6751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6752 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
6753 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 6754 Don't assume fixnum fits in int.
d311d28c
PE
6755 (load_charset_map_from_vector, Fmap_charset_chars):
6756 Remove now-unnecessary CHECK_NATNUMs.
6757 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
6758 Don't rely on undefined behavior with signed left shift overflow.
6759 Don't assume unsigned int fits into fixnum, or that fixnum fits
6760 into unsigned int. Don't require max_code to be a valid fixnum;
6761 that's not true for gb10830 4-byte on a 32-bit host. Allow
6762 invalid_code to be a cons, for the same reason. Require code_offset
6763 to be a character. Avoid int overflow if max_char is close
6764 to INT_MAX.
6765 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
6766 this is intended anyway and avoids some undefined behavior.
6767 (load_charset_map): Pass unsigned, not int, as 2nd arg of
6768 INDEX_TO_CODE_POINT, as that's what it expects.
6769 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
6770 * charset.h (DECODE_CHAR): Return int, not unsigned;
6771 this is what was intended anyway, and it avoids undefined behavior.
6772 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
6773 integer-overflow issues.
6774 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
6775 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
6776 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
6777 * chartab.c (Fmake_char_table, Fset_char_table_range)
6778 (uniprop_get_decoder, uniprop_get_encoder):
6779 Don't assume fixnum fits in int.
6780 * cmds.c (move_point): New function, that does the gist of
6781 Fforward_char and Fbackward_char, but does so while checking
6782 for integer overflow more accurately.
c96e5d6a 6783 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
6784 (Fforward_line, Fend_of_line, internal_self_insert)
6785 (internal_self_insert):
6786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6787 Fix a FIXME, by checking for integer overflow when calculating
6788 target_clm and actual_clm.
6789 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 6790 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
6791 (ASSURE_DESTINATION, coding_alloc_by_realloc)
6792 (coding_alloc_by_making_gap, alloc_destination)
6793 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
6794 (encode_coding_utf_16, detect_coding_emacs_mule)
6795 (decode_coding_emacs_mule, encode_coding_emacs_mule)
6796 (detect_coding_iso_2022, decode_coding_iso_2022)
6797 (encode_invocation_designation, encode_designation_at_bol)
6798 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6799 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
6800 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
6801 (encode_coding_ccl, encode_coding_raw_text)
6802 (detect_coding_charset, decode_coding_charset)
6803 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
6804 (produce_composition, produce_charset, produce_annotation)
6805 (decode_coding, handle_composition_annotation)
6806 (handle_charset_annotation, consume_chars, decode_coding_gap)
6807 (decode_coding_object, encode_coding_object, detect_coding_system)
6808 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
6809 (code_convert_region, code_convert_string)
8f50130c
PE
6810 (Fdefine_coding_system_internal)
6811 (coding_set_source, coding_set_destination):
d311d28c
PE
6812 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6813 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
6814 (Fdefine_coding_system_internal):
6815 Don't assume fixnums fit in int.
6816 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 6817 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
6818 (Funencodable_char_position, Fcheck_coding_systems_region)
6819 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 6820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 6821 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 6822 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 6823 Don't access memory outside of the args array.
d311d28c 6824 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
6825 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
6826 result of ENCODE_CHAR.
d311d28c
PE
6827 * coding.h: Adjust decls to match defn changes elsewhere.
6828 (struct coding_system):
6829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6830 * composite.c (get_composition_id, find_composition)
6831 (run_composition_function, update_compositions)
6832 (compose_text, composition_gstring_put_cache)
6833 (composition_gstring_p, composition_gstring_width)
6834 (fill_gstring_header, fill_gstring_body, autocmp_chars)
6835 (composition_compute_stop_pos, composition_reseat_it)
6836 (composition_update_it, struct position_record)
6837 (find_automatic_composition, composition_adjust_point)
6838 (Fcomposition_get_gstring, Ffind_composition_internal):
6839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6840 (update_compositions):
6841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6842 * composite.h: Adjust decls to match defn changes elsewhere.
6843 (struct composition):
6844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6845 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
6846 Do not attempt to compute the address of the object just before a
6847 buffer; this is not portable.
6848 (Faref, Faset):
6849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6850 (Faset): Use int, not EMACS_INT, where int is wide enough.
6851 (Fstring_to_number): Don't assume fixnums fit in int.
6852 (Frem): Don't assume arg is nonnegative.
6853 * dbusbind.c (xd_append_arg): Check for integers out of range.
6854 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 6855 (extract_signed, extract_unsigned): New functions.
243e0530
PE
6856 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
6857 (xd_get_connection_references): Return ptrdiff_t, not int.
6858 All uses changed.
6859 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
6860 (xd_read_message_1):
6861 Use int, not unsigned, where the dbus API uses int.
6862 (Fdbus_message_internal): Don't overflow mtype.
6863 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
6864 * dired.c (directory_files_internal, file_name_completion, scmp)
6865 (file_name_completion_stat):
6866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6867 (file_name_completion): Don't overflow matchcount.
6868 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
6869 * dispextern.h: Adjust decls to match defn changes elsewhere.
6870 (struct text_pos, struct glyph, struct bidi_saved_info)
6871 (struct bidi_string_data, struct bidi_it, struct composition_it)
6872 (struct it):
6873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6874 (struct display_pos, struct composition_it, struct it):
6875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6876 * dispnew.c (increment_matrix_positions)
6877 (increment_row_positions, mode_line_string)
6878 (marginal_area_string):
6879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 6880 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
6881 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6882 (duration_to_sec_usec): New function, to check for overflow better.
6883 (Fsleep_for, sit_for): Use it.
6884 * doc.c (get_doc_string, store_function_docstring):
6885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6886 (get_doc_string, Fsnarf_documentation):
6887 Use int, not EMACS_INT, where int is wide enough.
6888 (get_doc_string):
6889 Use SAFE_ALLOCA, not alloca.
6890 Check for overflow when converting EMACS_INT to off_t.
6891 * doprnt.c (doprnt):
6892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6893 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
6894 Don't assume uid_t fits into fixnum.
6895 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
6896 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
6897 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
6898 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
6899 (general_insert_function)
6900 (Finsert_char, make_buffer_string, make_buffer_string_both)
6901 (update_buffer_properties, Fbuffer_substring)
6902 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
6903 (Fsubst_char_in_region, check_translation)
6904 (Ftranslate_region_internal, save_restriction_restore, Fformat)
6905 (transpose_markers, Ftranspose_regions):
6906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6907 (clip_to_bounds): Move to lisp.h as an inline function).
6908 (Fconstrain_to_field): Don't assume integers are nonnegative.
6909 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
6910 (Fsubst_char_in_region, Fsave_restriction):
6911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6912 (Femacs_pid): Don't assume pid_t fits into fixnum.
6913 (lo_time): Use int, not EMACS_INT, when int suffices.
6914 (lisp_time_argument): Check for usec out of range.
6915 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
6916 (Fuser_login_name, Fuser_full_name): Signal an error
6917 if a uid argument is out of range, rather than relying on
6918 undefined behavior.
c8d5c857
PE
6919 (Fformat_time_string): Remove now-unnecessary check.
6920 lisp_time_argument checks for out-of-range usec now.
243e0530 6921 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
6922 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
6923 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
6924 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
6925 (init_cmdargs, Fdump_emacs):
6926 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6927 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
6928 the bottom (typically) 32 bits of the fixnum.
6929 * eval.c (specpdl_size, call_debugger):
6930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6931 (when_entered_debugger, Fbacktrace_debug):
6932 Don't assume fixnum can fit in int.
6933 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
6934 the object just before a buffer; this is not portable.
6935 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
6936 (grow_specpdl, unbind_to):
6937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6938 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
6939 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 6940 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
6941 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
6942 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
6943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6944 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
6945 (a_write, e_write):
6946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6947 (Fcopy_file, non_regular_nbytes, read_non_regular)
6948 (Finsert_file_contents):
6949 Use int, not EMACS_INT, where int is wide enough.
6950 (READ_BUF_SIZE): Verify that it fits in int.
6951 (Finsert_file_contents): Check that counts are in proper range,
6952 rather than assuming fixnums fit into ptrdiff_t etc.
6953 Don't assume fixnums fit into int.
125b3835 6954 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
6955 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
6956 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
6957 (string_char_to_byte, string_byte_to_char)
6958 (string_make_multibyte, string_to_multibyte)
6959 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
6960 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
6961 (substring_both, Fdelete, internal_equal, Ffillarray)
6962 (Fclear_string, mapcar1)
6963 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
6964 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
6965 (larger_vector, make_hash_table, maybe_resize_hash_table)
6966 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
6967 (Fmaphash, secure_hash):
6968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6969 (concat): Check for string index and length overflow.
6970 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
6971 (Frequire):
6972 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6973 (larger_vector): New API (vec, incr_min, size_max) replaces old
6974 one (vec, new_size, init). This catches size overflow.
6975 INIT was removed because it was always Qnil.
6976 All callers changed.
6977 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
6978 the upper bound on a hash table index size.
6979 (make_hash_table, maybe_resize_hash_table): Use it.
6980 (secure_hash): Computer start_byte and end_byte only after
6981 they're known to be in ptrdiff_t range.
6982 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
6983 (Ffont_get_glyphs, Ffont_at):
6984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6985 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
6986 (Flist_fonts, Fopen_font):
6987 Don't assume fixnum can fit in int.
6988 (check_gstring): Don't assume index can fit in int.
6989 (font_match_p): Check that fixnum is a character, not a nonnegative
6990 fixnum, since the later code needs to stuff it into an int.
6991 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
6992 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
6993 conversion overflow issues.
6994 (Fopen_font): Check for integer out of range.
6995 (Ffont_get_glyphs): Don't assume index can fit in int.
6996 * font.h: Adjust decls to match defn changes elsewhere.
6997 * fontset.c (reorder_font_vector): Redo score calculation to avoid
6998 integer overflow.
6999 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
7000 printmax_t, where ptrdiff_t is wide enough.
7001 (Finternal_char_font):
7002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7003 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
7004 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
7005 (Fset_frame_position, x_set_frame_parameters)
7006 (x_set_line_spacing, x_set_border_width)
7007 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
7008 Check that fixnums are in proper range for system types.
7009 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
7010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7011 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
7012 Use SAFE_ALLOCA_LISP, not alloca.
7013 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
7014 intptr_t is wide enough.
7015 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
7016 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
7017 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
7018 Check for fixnum out of range.
7019 * ftfont.c (ftfont_list): Don't assume index fits in int.
7020 Check that fixnums are in proper range for system types.
7021 (ftfont_shape_by_flt):
7022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
7023 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7024 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7025 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
7026 Check that fixnums are in proper range for system types.
7027 * gnutls.h: Adjust decls to match defn changes elsewhere.
7028 * gtkutil.c (xg_dialog_run):
7029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7030 (update_frame_tool_bar):
7031 Check that fixnums are in proper range for system types.
7032 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 7033 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
7034 * indent.c (last_known_column, last_known_column_point):
7035 (current_column_bol_cache):
7036 (skip_invisible, current_column, check_display_width):
7037 (check_display_width, scan_for_column, current_column_1)
7038 (Findent_to, Fcurrent_indentation, position_indentation)
7039 (indented_beyond_p, Fmove_to_column, compute_motion):
7040 (Fcompute_motion, Fvertical_motion):
7041 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7042 (last_known_column_modified): Use EMACS_INT, not int.
7043 (check_display_width):
7044 (Fcompute_motion):
7045 Check that fixnums and floats are in proper range for system types.
7046 (compute_motion): Don't assume index or fixnum fits in int.
7047 (compute_motion, Fcompute_motion):
7048 Use int, not EMACS_INT, when it is wide enough.
7049 (vmotion): Omit local var start_hpos that is always 0; that way
7050 we don't need to worry about overflow in expressions involving it.
7051 * indent.h: Adjust decls to match defn changes elsewhere.
7052 (struct position):
7053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7054 Use int, not EMACS_INT, where int is wide enough.
7055 Remove unused members ovstring_chars_done and tab_offset;
7056 all uses removed.
7057 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
7058 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
7059 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
7060 (make_gap, copy_text, insert, insert_and_inherit)
7061 (insert_before_markers, insert_before_markers_and_inherit)
7062 (insert_1, count_combining_before, count_combining_after)
7063 (insert_1_both, insert_from_string)
7064 (insert_from_string_before_markers, insert_from_string_1)
7065 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
7066 (adjust_after_replace, adjust_after_insert, replace_range)
7067 (replace_range_2, del_range, del_range_1, del_range_byte)
7068 (del_range_both, del_range_2, modify_region)
7069 (prepare_to_modify_buffer, signal_before_change)
7070 (signal_after_change, Fcombine_after_change_execute):
7071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7072 * intervals.c (traverse_intervals, rotate_right, rotate_left)
7073 (balance_an_interval, split_interval_right, split_interval_left)
7074 (find_interval, next_interval, update_interval)
7075 (adjust_intervals_for_insertion, delete_node, delete_interval)
7076 (interval_deletion_adjustment, adjust_intervals_for_deletion)
7077 (static_offset_intervals, offset_intervals)
7078 (merge_interval_right, merge_interval_left, make_new_interval)
7079 (graft_intervals_into_buffer, temp_set_point_both)
7080 (temp_set_point, set_point, adjust_for_invis_intang)
7081 (set_point_both, move_if_not_intangible, get_property_and_range)
7082 (get_local_map, copy_intervals, copy_intervals_to_string)
7083 (compare_string_intervals, set_intervals_multibyte_1):
7084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7085 * intervals.h: Adjust decls to match defn changes elsewhere.
7086 (struct interval):
7087 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7088 * keyboard.c (this_command_key_count, this_single_command_key_start)
7089 (before_command_key_count, before_command_echo_length, echo_now)
7090 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
7091 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
7092 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
7093 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
7094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7095 (last_non_minibuf_size, last_point_position, echo_truncate)
7096 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
7097 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
7098 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
7099 (stuff_buffered_input):
7100 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7101 (last_auto_save, command_loop_1, read_char):
7102 Use EMACS_INT, not int, to avoid integer overflow.
7103 (record_char): Avoid overflow in total_keys computation.
7104 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
7105 * keyboard.h: Adjust decls to match defn changes elsewhere.
7106 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
7107 (Fkey_description, Fdescribe_vector, Flookup_key):
7108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7109 (click_position): New function, to check that positions are in range.
7110 (Fcurrent_active_maps):
7111 (describe_command):
7112 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7113 (Faccessible_keymaps, Fkey_description):
7114 (preferred_sequence_p):
7115 Don't assume fixnum can fit into int.
7116 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
7117 Check for integer overflow in size calculations.
7118 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
7119 avoid mishandling large integers.
7120 * lisp.h: Adjust decls to match defn changes elsewhere.
7121 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
7122 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
7123 (struct Lisp_Marker):
7124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7125 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
7126 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
7127 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
7128 All callers changed.
7129 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
7130 Assume the arg has valid form, since it always does.
7131 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
7132 unsigned integer system type.
7133 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
7134 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
7135 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7136 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
7137 (duration_to_sec_usec): New decl.
7138 * lread.c (read_from_string_index, read_from_string_index_byte)
7139 (read_from_string_limit, readchar, unreadchar, openp)
7140 (read_internal_start, read1, oblookup):
7141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7142 (Fload, readevalloop, Feval_buffer, Feval_region):
7143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7144 (openp): Check for out-of-range argument to 'access'.
7145 (read1): Use int, not EMACS_INT, where int is wide enough.
7146 Don't assume fixnum fits into int.
6efdadfd 7147 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
7148 (read_filtered_event): Use duration_to_sec_usec
7149 to do proper overflow checking on durations.
d311d28c
PE
7150 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
7151 in size calculation.
7152 (Fexecute_kbd_macro):
7153 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7154 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
7155 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
7156 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
7157 (set_marker_both, set_marker_restricted_both, marker_position)
7158 (marker_byte_position, Fbuffer_has_markers_at):
7159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7160 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 7161 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
7162 It now merely ensures that the menu is large enough, without
7163 necessarily growing it, as this avoids some integer overflow issues.
7164 All callers changed.
7165 (keymap_panes, parse_single_submenu, Fx_popup_menu):
7166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7167 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
7168 Use SAFE_ALLOCA_LISP, not alloca.
7169 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
7170 to EMACS_INT. Check that fixnums are in proper range for system types.
7171 * minibuf.c (minibuf_prompt_width, string_to_object)
7172 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
7173 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
7174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7175 (get_minibuffer, read_minibuf_unwind):
7176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7177 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
7178 this simplifies overflow checking. All callers changed.
7179 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
7180 (Ftest_completion):
7181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7182 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
7183 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
7184 Check that fixnums are in proper range for system types.
7185 (Fx_create_frame, Fx_show_tip):
7186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7187 * nsfont.m (ns_findfonts, nsfont_list_family):
7188 Don't assume fixnum fits in long.
7189 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
7190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7191 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
7192 wide enough.
17fdb222 7193 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
7194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7195 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
7196 (PRINTDECLARE, PRINTPREPARE):
7197 (strout, print_string):
7198 (print, print_preprocess, print_check_string_charset_prop)
7199 (print_object):
7200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7201 (PRINTDECLARE):
7202 (temp_output_buffer_setup, Fprin1_to_string, print_object):
7203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7204 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 7205 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 7206 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
7207 (print_error_message): Use SAFE_ALLOCA, not alloca.
7208 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
7209 (print_depth, new_backquote_output, print_number_index):
7210 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
7211 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
7212 (Fset_process_window_size, Fformat_network_address)
7213 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 7214 (sigchld_handler):
d311d28c 7215 Check that fixnums are in proper range for system types.
d44287d4 7216 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
7217 Check for process-ids out of pid_t range rather than relying on
7218 undefined behavior.
e4d81efc 7219 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
7220 (Fformat_network_address, read_process_output, send_process)
7221 (Fprocess_send_region, status_notify):
7222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7223 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
7224 (wait_reading_process_output, read_process_output, exec_sentinel):
7225 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7226 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
7227 (Faccept_process_output): Use duration_to_sec_usec to do proper
7228 overflow checking on durations.
dde14581
PE
7229 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
7230 Don't assume pid_t fits in int.
02481186
PE
7231 * process.h (struct Lisp_Process): Members tick and update_tick
7232 are now of type EMACS_INT, not int.
b62b53e8
PE
7233 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
7234 configured --with-wide-int.
d311d28c
PE
7235 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
7236 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
7237 * search.c (looking_at_1, string_match_1):
7238 (fast_string_match, fast_c_string_match_ignore_case)
7239 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
7240 (scan_newline, find_before_next_newline, search_command)
7241 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
7242 (set_search_regs, wordify):
7243 (Freplace_match):
7244 (Fmatch_data):
7245 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7246 (string_match_1, search_buffer, set_search_regs):
7247 (Fmatch_data):
7248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7249 (wordify): Check for overflow in size calculation.
7250 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
7251 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
7252 Check that fixnums are in proper range for system types.
7253 * sound.c (struct sound_device)
7254 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
7255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7256 (Fplay_sound_internal):
7257 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 7258 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
7259 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
7260 (Fparse_partial_sexp):
7261 Don't assume fixnums can fit in int.
7262 (struct lisp_parse_state, find_start_pos, find_start_value)
7263 (find_start_value_byte, find_start_begv)
7264 (update_syntax_table, char_quoted, dec_bytepos)
7265 (find_defun_start, prev_char_comend_first, back_comment):
7266 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
7267 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
7268 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7269 (Finternal_describe_syntax_value): Check that match_lisp is a
7270 character, not an integer, since the code stuffs it into int.
7271 (scan_words, scan_sexps_forward):
7272 Check that fixnums are in proper range for system types.
7273 (Fforward_word):
7274 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7275 (scan_sexps_forward):
7276 Use CHARACTERP, not INTEGERP, since the value must fit into int.
7277 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
7278 * syntax.h: Adjust decls to match defn changes elsewhere.
7279 (struct gl_state_s):
7280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
7281 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
7282 MOST_POSITIVE_FIXNUM.
d311d28c
PE
7283 * sysdep.c (wait_for_termination_1, wait_for_termination)
7284 (interruptible_wait_for_termination, mkdir):
7285 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
7286 (emacs_read, emacs_write):
7287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
7288 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
7289 and double all fit in int.
d311d28c
PE
7290 * term.c (set_tty_color_mode):
7291 Check that fixnums are in proper range for system types.
7292 * termhooks.h (struct input_event):
7293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7294 * textprop.c (validate_interval_range, interval_of)
7295 (Fadd_text_properties, set_text_properties_1)
7296 (Fremove_text_properties, Fremove_list_of_text_properties)
7297 (Ftext_property_any, Ftext_property_not_all)
7298 (copy_text_properties, text_property_list, extend_property_ranges)
7299 (verify_interval_modification):
7300 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7301 (Fnext_single_char_property_change)
7302 (Fprevious_single_char_property_change):
7303 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
7304 (copy_text_properties):
7305 Check for integer overflow in index calculation.
d311d28c
PE
7306 * undo.c (last_boundary_position, record_point, record_insert)
7307 (record_delete, record_marker_adjustment, record_change)
7308 (record_property_change):
7309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7310 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
7311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7312 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7313 (Fx_hide_tip, Fx_file_dialog):
7314 * w32menu.c (set_frame_menubar):
7315 Use ptrdiff_t, not int, for consistency with rest of code.
7316 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
7317 (select_window, Fdelete_other_windows_internal)
7318 (window_scroll_pixel_based, window_scroll_line_based)
7319 (Frecenter, Fset_window_configuration):
7320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7321 (Fset_window_hscroll, run_window_configuration_change_hook)
7322 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 7323 (Fscroll_other_window, Frecenter):
d311d28c
PE
7324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7325 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
7326 Don't assume fixnum fits in int.
7327 (Fset_window_scroll_bars):
7328 Check that fixnums are in proper range for system types.
7329 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
7330 (string_pos, c_string_pos, number_of_chars, init_iterator)
7331 (in_ellipses_for_invisible_text_p, init_from_display_pos)
7332 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
7333 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
7334 (face_before_or_after_it_pos, handle_invisible_prop)
7335 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
7336 (display_prop_intangible_p, string_buffer_position_lim)
7337 (string_buffer_position, handle_composition_prop, load_overlay_strings)
7338 (get_overlay_strings_1, get_overlay_strings)
7339 (iterate_out_of_display_property, forward_to_next_line_start)
7340 (back_to_previous_visible_line_start, reseat, reseat_to_string)
7341 (get_next_display_element, set_iterator_to_next)
7342 (get_visually_first_element, compute_stop_pos_backwards)
7343 (handle_stop_backwards, next_element_from_buffer)
7344 (move_it_in_display_line_to, move_it_in_display_line)
7345 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7346 (add_to_log, message_dolog, message_log_check_duplicate)
7347 (message2, message2_nolog, message3, message3_nolog
7348 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
7349 (current_message_1, truncate_echo_area, truncate_message_1)
7350 (set_message, set_message_1, store_mode_line_noprop)
7351 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
7352 (text_outside_line_unchanged_p, check_point_in_composition)
7353 (reconsider_clip_changes)
7354 (redisplay_internal, set_cursor_from_row, try_scrolling)
7355 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
7356 (redisplay_window, find_last_unchanged_at_beg_row)
7357 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
7358 (trailing_whitespace_p, find_row_edges, display_line)
7359 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
7360 (display_mode_element, store_mode_line_string)
7361 (pint2str, pint2hrstr, decode_mode_spec)
7362 (display_count_lines, display_string, draw_glyphs)
7363 (x_produce_glyphs, x_insert_glyphs)
7364 (rows_from_pos_range, mouse_face_from_buffer_pos)
7365 (fast_find_string_pos, mouse_face_from_string_pos)
7366 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7367 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7368 (safe_call, init_from_display_pos, handle_fontified_prop)
7369 (handle_single_display_spec, load_overlay_strings)
7370 (with_echo_area_buffer, setup_echo_area_for_printing)
7371 (display_echo_area, echo_area_display)
7372 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
7373 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
7374 (redisplay_window, dump_glyph_row, display_mode_line)
7375 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 7376 (handle_display_spec, display_prop_string_p):
d311d28c
PE
7377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7378 (handle_single_display_spec, build_desired_tool_bar_string)
7379 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
7380 (get_specified_cursor_type):
7381 Check that fixnums are in proper range for system types.
7382 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
7383 (Flookup_image_map):
7384 Don't assume fixnums fit in int.
7385 (compare_overlay_entries):
7386 Avoid mishandling comparisons due to subtraction overflow.
7387 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
7388 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
7389 (handle_tool_bar_click):
7390 Use int, not unsigned, since we prefer signed and the signedness
7391 doesn't matter here.
7392 (get_next_display_element, next_element_from_display_vector):
7393 Use int, not EMACS_INT, when int is wide enough.
7394 (start_hourglass): Use duration_to_sec_usec to do proper
7395 overflow checking on durations.
7396 * xfaces.c (Fbitmap_spec_p):
7397 Check that fixnums are in proper range for system types.
7398 (compare_fonts_by_sort_order):
7399 Avoid mishandling comparisons due to subtraction overflow.
7400 (Fx_family_fonts, realize_basic_faces):
7401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7402 (Fx_family_fonts):
7403 Don't assume fixnum fits in int.
7404 Use SAFE_ALLOCA_LISP, not alloca.
7405 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
7406 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
7407 (face_at_buffer_position, face_for_overlay_string)
7408 (face_at_string_position):
7409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7410 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
7411 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
7412 (Fx_show_tip):
7413 Check that fixnums are in proper range for system types.
7414 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7415 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
7416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7417 (Fx_change_window_property): Don't assume fixnums fit in int.
7418 * xfont.c (xfont_chars_supported):
7419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7420 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
7421 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
7422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7423 * xml.c (parse_region):
7424 * xrdb.c (magic_file_p):
7425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7426 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
7427 (x_get_local_selection, x_reply_selection_request)
7428 (x_handle_selection_request, wait_for_property_change):
7429 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7430 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
7431 short is wide enough.
7432 (x_send_client_event): Don't assume fixnum fits in int.
7433 * xterm.c (x_x_to_emacs_modifiers):
7434 Don't assume EMACS_INT overflows nicely into int.
7435 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
7436 may come from Lisp.
7437 (handle_one_xevent): NATNUMP can eval its arg twice.
7438 (x_connection_closed):
7439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7440 * xterm.h: Adjust decls to match defn changes elsewhere.
7441 (struct scroll_bar): Use struct vectorlike_header
7442 rather than rolling our own approximation.
7443 (SCROLL_BAR_VEC_SIZE): Remove; not used.
7444
c6574eb5
GM
74452012-05-25 Glenn Morris <rgm@gnu.org>
7446
7447 * lisp.mk (lisp): Update for more files being compiled now.
7448
e8d32c7e
SM
74492012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
7450
48def666
SM
7451 * lread.c: Remove `read_pure' which makes no difference.
7452 (read_pure): Remove var.
7453 (unreadpure): Remove function.
7454 (readevalloop): Don't call read_list with -1 flag.
7455 (read1, read_vector): Don't test read_pure any more.
7456 (read_list): Simplify.
7457
e8d32c7e
SM
7458 * fileio.c, character.h: Minor style tweaks.
7459
4b2addb7
DA
74602012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
7461
7462 * window.h (clip_changed): Remove useless declaration.
7463
584461b2
JB
74642012-05-22 Juanma Barranquero <lekktu@gmail.com>
7465
7466 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
7467 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
7468
34374650
PE
74692012-05-22 Paul Eggert <eggert@cs.ucla.edu>
7470
7471 Remove src/m/*.
7472 This directory predates autoconf and is no longer needed nowadays.
7473 Move its few remaining bits of functionality to where they're needed.
7474 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
7475 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
7476 * m/template.h: Remove.
7477 * Makefile.in (M_FILE): Remove. All uses removed.
7478 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
7479 * lisp.h (USE_LSB_TAG):
7480 * mem-limits.h (EXCEEDS_LISP_PTR):
7481 Use VAL_MAX, not VALBITS, in #if.
7482 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
7483 (EMACS_UINT): Define unconditionally now.
7484 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
7485 (BITS_PER_EMACS_INT): New constants, replacing
7486 what used to be in config.h, but not useful in #if.
7487 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
7488 define them any more.
7489 (VAL_MAX): New macro.
7490 (VALMASK): Use it.
7491 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
7492 BITS_PER_EMACS_INT, in #if.
7493 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
7494 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
7495 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
7496 * s/ms-w32.h (DATA_START):
7497 Move here from removed file m/intel386.h.
7498 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
7499 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
7500
261cb4bb
PE
75012012-05-21 Paul Eggert <eggert@cs.ucla.edu>
7502
7503 Assume C89 or later.
7504 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
7505 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
7506 (xrealloc):
7507 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
7508 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
7509 * textprop.c, tparam.c (NULL): Remove.
7510 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
7511 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
7512 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
7513 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
7514 * xterm.c (input_signal_count): Assume volatile works.
7515
ff23cd9f
KB
75162012-05-21 Ken Brown <kbrown@cornell.edu>
7517
7518 * xgselect.c (xg_select): Fix first argument in call to 'select'
7519 (bug#11508).
7520
1b170bc6
KB
75212012-05-20 Ken Brown <kbrown@cornell.edu>
7522
7523 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 7524 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 7525
b2f4d39f
KB
75262012-05-19 Ken Brown <kbrown@cornell.edu>
7527
7528 * xfns.c (x_in_use): Remove `static' qualifier.
7529 * xterm.h (x_in_use): Declare.
7530 * xgselect.c: Include xterm.h.
7531 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
7532 and `display_arg' (bug#9754).
7533
003fdae2
PE
75342012-05-19 Paul Eggert <eggert@cs.ucla.edu>
7535
9232a6d9
PE
7536 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
7537
003fdae2
PE
7538 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
7539 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
7540
784b56e2
EZ
75412012-05-18 Eli Zaretskii <eliz@gnu.org>
7542
7543 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
7544
7545 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 7546 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
7547
7548 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
7549 reference to image_cache->refcount.
7550 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
7551
a0a79cde
JL
75522012-05-17 Juri Linkov <juri@jurta.org>
7553
7554 * search.c (Fword_search_regexp, Fword_search_backward)
7555 (Fword_search_forward, Fword_search_backward_lax)
7556 (Fword_search_forward_lax): Move functions to isearch.el
7557 (bug#10145, bug#11381).
7558
b0572523
PE
75592012-05-16 Paul Eggert <eggert@cs.ucla.edu>
7560
7561 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
7562
9660f5fc
SM
75632012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
7564
7565 * lread.c (init_obarray): Declare Qt and Qnil as special.
7566
4374de83
GM
75672012-05-14 Glenn Morris <rgm@gnu.org>
7568
7569 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 7570 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 7571
dc44c39a
PE
75722012-05-14 Paul Eggert <eggert@cs.ucla.edu>
7573
078c97cb
PE
7574 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
7575
dc44c39a
PE
7576 * unexaix.c: Port to more-recent AIX compilers.
7577 (report_error, report_error_1, make_hdr, copy_sym)
7578 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
7579 Make arguments const char *, not char *, to avoid violations of C
7580 standard and to fix some AIX warnings reported by Gilles Pion.
7581
e18afed7 75822012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
7583
7584 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
7585 already have overlays loaded.
7586 (handle_single_display_spec): Before returning without displaying
7587 fringe bitmap, synchronize the bidi iterator with the main display
7588 iterator, by calling iterate_out_of_display_property.
7589 (iterate_out_of_display_property): Detect buffer iteration by
7590 testing that it->string is a Lisp string.
7591 (get_next_display_element): When the current object is exhausted,
7592 and there's something on it->stack, call set_iterator_to_next to
7593 proceed with what's on the stack, instead of returning zero.
7594 (set_iterator_to_next): If called at the end of a Lisp string,
7595 proceed to consider_string_end without incrementing string
7596 position. Don't increment display vector index past the end of
7597 the display vector. (Bug#11417)
c8fb9dc6
EZ
7598 (pos_visible_p): Don't report a position visible when move_it_to
7599 stopped at the last line of window, which happens to be scanned
7600 backwards by the bidi iteration. (Bug#11464)
ac268e67 7601
e18afed7 76022012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
7603
7604 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
7605 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
7606 are on a TTY, and thus unable to display on the fringes.
7607 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
7608 so we need to signal to the caller that this is a "replacing"
7609 display spec. This fixes display when the spec is invalid or we
7610 are on a TTY.
7611
e18afed7 76122012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
7613
7614 * unexaix.c (make_hdr): Fix typo in prototype.
7615 This bug broke the build on AIX. Problem reported by Gilles Pion.
7616
9d0a235a
MA
76172012-05-14 Michael Albinus <michael.albinus@gmx.de>
7618
7619 * keyboard.c (kbd_buffer_get_event): Read special events also in
7620 batch mode. (Bug#11415)
7621
9e6b06ed
GM
76222012-05-12 Glenn Morris <rgm@gnu.org>
7623
7624 * ns.mk: Update for ns_appbindir no longer having trailing "/".
7625
c1a1d7a3
EZ
76262012-05-12 Eli Zaretskii <eliz@gnu.org>
7627
7628 * lisp.mk (lisp): Add newcomment.elc.
7629
3fe7cdc8
GM
76302012-05-12 Glenn Morris <rgm@gnu.org>
7631
7632 * Makefile.in (MKDIR_P): New, set by configure.
7633 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
7634
53f7d2c0
PE
76352012-05-11 Paul Eggert <eggert@cs.ucla.edu>
7636
7637 Remove unused function hourglass_started.
7638 * dispextern.h (hourglass_started):
7639 * w32fns.c (hourglass_started):
7640 * xdisp.c (hourglass_started): Remove.
7641
75aafb17
JB
76422012-05-10 Juanma Barranquero <lekktu@gmail.com>
7643
7644 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
7645 Update dependencies.
7646
12959e8e
PE
76472012-05-10 Paul Eggert <eggert@cs.ucla.edu>
7648
97107e2e
PE
7649 * xgselect.c (xg_select): Put maxfds+1 into a var.
7650 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
7651
12959e8e
PE
7652 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
7653
836d29b3
DA
76542012-05-10 Dave Abrahams <dave@boostpro.com>
7655
7656 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
7657 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
7658
5cb67954
MA
76592012-05-09 Michael Albinus <michael.albinus@gmx.de>
7660
7661 * dbusbind.c (xd_registered_buses): New internal Lisp object.
7662 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
7663 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
7664 Initialize xd_registered_buses.
7665
3478ec45
PE
76662012-05-09 Paul Eggert <eggert@cs.ucla.edu>
7667
b263a6b0
PE
7668 Untag more efficiently if USE_LSB_TAG.
7669 This is based on a proposal by YAMAMOTO Mitsuharu in
7670 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
7671 For an admittedly artificial (nth 8000 longlist) benchmark on
7672 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
7673 Emacs's overall text size by 1%.
7674 * lisp.h (XUNTAG): New macro.
7675 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
7676 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
7677 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
7678 * eval.c (Fautoload):
7679 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
7680 * frame.h (XFRAME): Use XUNTAG.
7681
3478ec45
PE
7682 Port recent dbusbind.c changes to 32-bit --with-wide-int.
7683 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
7684 Remove unportable assumptions about print widths of types like
7685 dbus_uint32_t.
7686 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
7687 intptr_t when converting between pointer and integer, to avoid GCC
7688 warnings about wrong width.
7689
666b903b 76902012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
7691
7692 * w32proc.c (new_child): Force Windows to reserve only 64KB of
7693 stack for each reader_thread, instead of defaulting to 8MB
7694 determined by the linker. This avoids failures in creating
7695 subprocesses on Windows 7, see the discussion in this thread:
7696 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
7697
b120cc17
JC
76982012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
7699
7700 Fix up display of the *Minibuf-0* buffer in the mini window.
7701 * keyboard.c (read_char): Don't clear the echo area if there's no
7702 message to clear.
7703 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 7704 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 7705
9a4b36f8
MA
77062012-05-07 Michael Albinus <michael.albinus@gmx.de>
7707
7708 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
7709 batch mode.
7710
e5f9458f
CY
77112012-05-06 Chong Yidong <cyd@gnu.org>
7712
7713 * lisp.mk (lisp): Update.
7714
eceeb5fc 77152012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
7716
7717 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
7718
71873e2b
SM
77192012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
7720
7721 * data.c (PUT_ERROR): New macro.
7722 (syms_of_data): Use it. Add new error type `user-error'.
7723 * undo.c (user_error): New function.
7724 (Fprimitive_undo): Use it.
7725 * print.c (print_error_message): Adjust print style for `user-error'.
7726 * keyboard.c (user_error): New function.
7727 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
7728
ab0fa4e4
PE
77292012-05-03 Paul Eggert <eggert@cs.ucla.edu>
7730
7731 Do not limit current-time-string to years 1000..9999.
7732 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
7733 (Fcurrent_time_string): Support any year that is supported by the
7734 underlying localtime representation. Don't use asctime, as it
7735 has undefined behavior for years outside the range -999..9999.
7736
7ed806a7
PE
77372012-05-02 Paul Eggert <eggert@cs.ucla.edu>
7738
7739 Fix race conditions involving setenv, gmtime, localtime, asctime.
7740 Without this fix, interrupts could mess up code that uses these
7741 nonreentrant functions, since setting TZ invalidates existing
7742 tm_zone or tzname values, and since most of these functions return
7743 pointers to static storage.
7744 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
7745 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
7746 Grow the critical sections to include not just invoking
7747 localtime/gmtime, but also accessing these functions' results
7748 including their tm_zone values if any, and any related TZ setting.
7749 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
7750 so that the struct tm is saved in the critical section.
7751 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
7752 motivated by the fact that memory allocation needs to be outside
7753 the critical section.
7754
0c16dfed
DA
77552012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
7756
7757 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
7758 with RESET_INTERVAL.
7759
7760 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7761 Remove duplicated buffer name initialization.
7762
3f83ace8
JM
77632012-05-02 Jim Meyering <jim@meyering.net>
7764
7765 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
7766
c7b8541e
JM
7767 * xfns.c (x_window): Use xstrdup (Bug#11375).
7768
90207a15 77692012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
7770
7771 * xdisp.c (pos_visible_p): If already at a newline from the
7772 display string before the 'while' loop, don't walk back the glyphs
7773 from it3.glyph_row. Solves assertion violation when the display
7774 string begins with a newline (egg.el). (Bug#11367)
7775
b593d6a9
AH
77762012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
7777
7778 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
7779 Move to simple.el.
7780
4737362e
GM
77812012-05-01 Glenn Morris <rgm@gnu.org>
7782
99cf43f9
GM
7783 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
7784 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
7785 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
7786 All were removed before 23.1.
7787
9311dcff
GM
7788 * dispnew.c: Remove HAVE_LIBNCURSES test;
7789 it is always true on relevant platforms.
7790
4d5c6349
GM
7791 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
7792 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
7793
4737362e
GM
7794 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
7795
74dd3a6b
AS
77962012-04-30 Andreas Schwab <schwab@linux-m68k.org>
7797
7798 * .gdbinit (xpr): Remove checks for no longer existing misc types.
7799 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
7800 Remove.
7801
13c379ee
PE
78022012-04-28 Paul Eggert <eggert@cs.ucla.edu>
7803
7804 Do not avoid creating empty evaporating overlays (Bug#9642).
7805 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
7806 That is, do not delete an evaporating overlay if it becomes
7807 empty after its bounds are adjusted to fit within its buffer.
7808 This fix caused other problems, and I'm reverting it until we get
7809 to the bottom of them.
7810
a8e7d6d7 78112012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
7812
7813 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
7814
a8e7d6d7 78152012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
7816
7817 * xdisp.c (pos_visible_p): If the window start position is beyond
7818 ZV, start the display from buffer beginning. Prevents assertion
7819 violation in init_iterator when the minibuffer window is scrolled
7820 via the scroll bar.
7821
7822 * window.c (window_scroll_pixel_based): Likewise.
7823
a8e7d6d7 78242012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
7825
7826 * keymap.c (where_is_internal): Doc fix (Bug#10872).
7827
a8e7d6d7 78282012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
7829
7830 * fileio.c (Fcopy_file, Fset_file_selinux_context):
7831 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
7832
a8e7d6d7 78332012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 7834
b593d6a9
AH
7835 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
7836 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 7837
1c6900d9
EZ
78382012-04-26 Eli Zaretskii <eliz@gnu.org>
7839
4c3fa1d9
EZ
7840 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
7841 display element, check also the underlying string or buffer
7842 character. (Bug#11341)
7843
1c6900d9
EZ
7844 * w32menu.c: Include w32heap.h.
7845 (add_menu_item): If the call to AppendMenuW (via
7846 unicode_append_menu) fails, disable Unicode menus only if we are
7847 running on Windows 9X/Me.
7848
42bf8205
AS
78492012-04-24 Andreas Schwab <schwab@linux-m68k.org>
7850
7851 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
7852 (xgetint): Add missing shift for LSB tags.
7853
b1bac16e
MR
78542012-04-24 Martin Rudalics <rudalics@gmx.at>
7855
7856 * keyboard.c (read_char): Don't wipe echo area for select window
7857 events: These might get delayed via `mouse-autoselect-window'
7858 (Bug#11304).
7859
d69621cc
JB
78602012-04-24 Juanma Barranquero <lekktu@gmail.com>
7861
7862 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
7863 manipulation of :loaded-from data.
7864
02fd101b
JB
78652012-04-23 Juanma Barranquero <lekktu@gmail.com>
7866
7867 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
7868 now a cons (bug#11311).
7869
888bec30
PE
78702012-04-23 Paul Eggert <eggert@cs.ucla.edu>
7871
89a438bd
PE
7872 Do not create empty overlays with the evaporate property (Bug#9642).
7873 * buffer.c (Fmove_overlay): Delete an evaporating overlay
7874 if it becomes empty after its bounds are adjusted to fit within
7875 its buffer. Without this fix, in a nonempty buffer (let ((o
7876 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
7877 yields an empty overlay that has the evaporate property, which is
7878 not supposed to happen.
7879
1068fe4d
PE
7880 Fix minor GTK3 problems found by static checking.
7881 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7882 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7883 (struct _EmacsFixedClass, emacs_fixed_get_type):
7884 Move decls here from emacsgtkfixed.h, since they needn't be public.
7885 (emacs_fixed_get_type): Now static.
7886 (emacs_fixed_class_init): Omit unused local.
7887 (emacs_fixed_child_type): Remove; unused.
7888 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
7889 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
7890 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
7891 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
7892 (EMACS_FIXED_GET_CLASS): Remove; unused.
7893 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
7894
888bec30
PE
7895 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
7896 Problem reported by Juanma Barranquero for Windows -Wunused-function.
7897
de85e130
PE
78982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7899
d0baac98 7900 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 7901 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
7902 (__malloc_size_t, __malloc_ptrdiff_t):
7903 Remove. All uses removed, replaced by the definiens if needed,
7904 since we can assume C89 or better now.
7905 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
7906 (protect_malloc_state, align, get_contiguous_space)
7907 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
7908 (malloc_atfork_handler_child, malloc_enable_thread)
7909 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
7910 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
7911 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
7912 (special_realloc, _realloc_internal_nolock, _realloc_internal)
7913 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
7914 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
7915 Define using prototypes, not old style.
7916 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
7917 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
7918 (align): Don't assume that signed integer overflow wraps around.
7919 Omit unused local var.
7920 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
7921 (_free_internal_nolock, memalign, mallochook, reallochook):
7922 Omit no-longer-needed casts.
7923 (valloc): Use getpagesize, not __getpagesize.
7924 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
7925 (struct hdr): The 'magic' member is now size_t, not unsigned long.
7926
de85e130
PE
7927 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
7928
dcbf5805
MA
79292012-04-22 Michael Albinus <michael.albinus@gmx.de>
7930
7931 Move functions from C to Lisp. Make non-blocking method calls
7932 the default. Implement further D-Bus standard interfaces.
7933
7934 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
7935 (QCdbus_request_name_allow_replacement)
7936 (QCdbus_request_name_replace_existing)
7937 (QCdbus_request_name_do_not_queue)
7938 (QCdbus_request_name_reply_primary_owner)
7939 (QCdbus_request_name_reply_in_queue)
7940 (QCdbus_request_name_reply_exists)
7941 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
7942 (QCdbus_registered_serial, QCdbus_registered_method)
7943 (QCdbus_registered_signal): New Lisp objects.
7944 (XD_DEBUG_MESSAGE): Use sizeof.
7945 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
7946 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
7947 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
7948 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
7949 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
7950 (xd_signature, xd_append_arg): Allow float for integer types.
7951 (xd_get_connection_references): New function.
b593d6a9
AH
7952 (xd_get_connection_address): Rename from xd_initialize.
7953 Return cached address.
dcbf5805
MA
7954 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
7955 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
7956 level.
7957 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 7958 Return number of refcounts.
dcbf5805
MA
7959 (Fdbus_get_unique_name): Make stronger parameter check.
7960 (Fdbus_message_internal): New defun.
7961 (Fdbus_call_method, Fdbus_call_method_asynchronously)
7962 (Fdbus_method_return_internal, Fdbus_method_error_internal)
7963 (Fdbus_send_signal, Fdbus_register_service)
7964 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
7965 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
7966 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
7967 (Vdbus_compiled_version, Vdbus_runtime_version)
7968 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
7969 (Vdbus_message_type_method_return, Vdbus_message_type_error)
7970 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
7971 (Vdbus_registered_buses, Vdbus_registered_objects_table):
7972 Adapt docstring.
dcbf5805 7973
52828e02
PE
79742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7975
da05bc4c
PE
7976 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
7977 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
7978 Do not assume ptrdiff_t is the same width as 'int'.
7979
52828e02
PE
7980 * alloc.c: Handle unusual debugging option combinations.
7981 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
7982 since the two debugging options are incompatible.
7983 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
7984 is defined.
7985 (mem_init, mem_insert, mem_insert_fixup):
7986 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
7987 (NEED_MEM_INSERT): Remove; no longer needed.
7988
f01769f9
LL
79892012-04-22 Leo Liu <sdl.web@gmail.com>
7990
7991 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
7992
5790543d
PE
79932012-04-22 Paul Eggert <eggert@cs.ucla.edu>
7994
7995 * sysdep.c [__FreeBSD__]: Minor cleanups.
7996 (list_system_processes, system_process_attributes) [__FreeBSD__]:
7997 Use Emacs indenting style more consistently. Avoid some casts.
7998 Use 'double' consistently rather than mixing 'float' and 'double'.
7999
b91b7e4d
EW
80002012-04-21 Eduard Wiebe <usenet@pusto.de>
8001
b593d6a9
AH
8002 * sysdep.c (list_system_processes, system_process_attributes):
8003 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 8004
6114eb15
AS
80052012-04-21 Andreas Schwab <schwab@linux-m68k.org>
8006
8007 * lisp.mk (lisp): Update.
8008
2f38dff7
PE
80092012-04-20 Paul Eggert <eggert@cs.ucla.edu>
8010
8011 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
8012 It is never used otherwise.
8013
4ae29f89
SM
80142012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
8015
8016 * print.c (print_preprocess): Only check print_depth if print-circle
8017 is nil.
8018 (print_object): Check for cycles even when print-circle is nil and
8019 print-gensym is t, but only check print_depth if print-circle is nil.
8020
f30d612a
CY
80212012-04-20 Chong Yidong <cyd@gnu.org>
8022
8023 * process.c (wait_reading_process_output): If EIO occurs on a pty,
8024 set the status to "failed" and ensure that sentinel is run.
8025
c07a4c0b 80262012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
8027
8028 * process.c (Fset_process_inherit_coding_system_flag)
8029 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 8030 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 8031
c07a4c0b 80322012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
8033
8034 * xdisp.c (string_buffer_position_lim): Limit starting position to
8035 BEGV.
8036 (set_cursor_from_row): If called for a mode-line or header-line
8037 row, return zero immediately.
8038 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
8039 farther than the first row after the header line, if any.
8040 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
8041 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
8042
c07a4c0b 80432012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8044
4ae29f89
SM
8045 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
8046 (bug#11238).
ad3a2b41 8047
c07a4c0b 80482012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 80492012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
8050
8051 configure: new option --enable-gcc-warnings (Bug#11207)
8052 * Makefile.in (C_WARNINGS_SWITCH): Remove.
8053 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
8054 (ALL_CFLAGS): Use new macros rather than old.
8055 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
8056 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
8057 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
8058 -Wunused-result, -Wunused-variable. This should go away once
8059 the Emacs and Gnulib regex code is merged.
8060 (xmalloc, xrealloc): Now static.
8061
aba027e8
PE
80622012-04-17 Paul Eggert <eggert@cs.ucla.edu>
8063
8064 * dired.c (Fsystem_groups): Remove unused local.
8065
e5a36063
GM
80662012-04-17 Glenn Morris <rgm@gnu.org>
8067
8068 * dired.c (Fsystem_users): Doc fix.
8069
316411f0
DA
80702012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
8071
8072 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
8073 (syms_of_dired): Add them.
8074
9426aba4
PE
80752012-04-16 Paul Eggert <eggert@cs.ucla.edu>
8076
b62a57be
PE
8077 Fix minor alloc.c problems found by static checking.
8078 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
8079 New extern decls, to avoid calling undeclared functions.
8080 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
8081 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
8082 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
8083 (NEED_MEM_INSERT): New macro.
8084 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 8085 Remove one incorrect comment and fix another.
b62a57be 8086
3539f31f
PE
8087 Fix minor ralloc.c problems found by static checking.
8088 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8089 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
8090 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
8091 (r_alloc_sbrk): Now static.
8092
a041960a
PE
8093 Improve ralloc.c interface checking.
8094 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8095 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
8096 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
8097 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
8098 [REL_ALLOC]: ... to here, to check interface.
8099 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
8100 Remove decls. This fixes an "It stinks!".
8101
9426aba4
PE
8102 * alloc.c (which_symbols): Fix alignment issue / type clash.
8103
d55c12ed
AS
81042012-04-15 Andreas Schwab <schwab@linux-m68k.org>
8105
8106 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
8107 (struct Lisp_Misc_Any): Likewise.
8108 (struct Lisp_Free): Likewise.
8109 * alloc.c (union aligned_Lisp_Symbol): Define.
8110 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
8111 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
8112 (union aligned_Lisp_Misc): Define.
8113 (MARKER_BLOCK_SIZE, struct marker_block): Use union
8114 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 8115 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 8116
b948ce8b
PE
81172012-04-14 Paul Eggert <eggert@cs.ucla.edu>
8118
8119 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
8120 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
8121 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
8122 * s/netbsd.h, s/sol2-6.h:
8123 Remove definition of GC_MARK_STACK, since the default now works.
8124 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
8125 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
8126 no longer the default.
8127 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
8128
35dc09a1 81292012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8130
35dc09a1
GM
8131 * lread.c (lisp_file_lexically_bound_p):
8132 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 8133
35dc09a1
GM
81342012-04-14 Eli Zaretskii <eliz@gnu.org>
8135
8136 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
8137 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
8138
81392012-04-14 Jan Djärv <jan.h.d@swipnet.se>
8140
8141 * nsterm.m (constrainFrameRect): Always constrain when there is only
8142 one screen (Bug#10962).
8143
bcd86815
KB
81442012-04-13 Ken Brown <kbrown@cornell.edu>
8145
8146 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
8147
c25df26e
RT
81482012-04-13 Reuben Thomas <rrt@sc3d.org>
8149
8150 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
8151
0fc59f1e
DC
81522012-04-11 Daniel Colascione <dancol@dancol.org>
8153
8154 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
8155 against is gone. It's better to use vfork now so that when Cygwin
8156 gains a new, working vfork, we use it automatically (bug#10398).
8157
de8c03dc
SM
81582012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8159
8160 * window.c (save_window_save): Obey window-point-insertion-type.
8161
2f097256
GM
81622012-04-11 Glenn Morris <rgm@gnu.org>
8163
8164 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
8165
453b951e
SM
81662012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8167
8168 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
8169
75f1671a 81702012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
8171
8172 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
8173 (force_quit_count): New var.
8174 (handle_interrupt): Use it.
8175
2a8ce227
JB
81762012-04-10 Juanma Barranquero <lekktu@gmail.com>
8177
8178 * w32.c (w32_delayed_load): Record the full path of the library
8179 being loaded (bug#10424).
8180
935396c0
GM
81812012-04-09 Glenn Morris <rgm@gnu.org>
8182
05920a43
GM
8183 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
8184 not just in the obarray, before snarfing them. (Bug#11036)
8185
935396c0
GM
8186 * Makefile.in ($(leimdir)/leim-list.el):
8187 Pass EMACS rather than BUILT_EMACS.
8188
a18ecafa
TZ
81892012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
8190
8191 * process.c (make_process):
8192 * process.h: Add integer `gnutls_handshakes_tried' member to
8193 process struct.
8194
6bbef4e5
JC
8195 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
8196 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
8197
8198 * gnutls.c (gnutls_log_function2i): Convenience log function.
8199 (emacs_gnutls_read): Use new log functions,
8200 `gnutls_handshakes_tried' process member, and
8201 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
8202 attempts per process (connection).
8203
b4d3bc10
CY
82042012-04-09 Chong Yidong <cyd@gnu.org>
8205
8206 * eval.c (Fuser_variable_p, user_variable_p_eh)
8207 (lisp_indirect_variable): Functions deleted.
8208 (Fdefvar): Caller changed.
8209
8210 * callint.c (Finteractive, Fcall_interactively):
8211 * minibuf.c (Fread_variable): Callers changed.
8212
70f4d973
EZ
82132012-04-09 Eli Zaretskii <eliz@gnu.org>
8214
8215 * xdisp.c (set_cursor_from_row): If the display string appears in
8216 the buffer at position that is closer to point than the position
8217 after the display string, display the cursor on the first glyph of
8218 the display string. Fixes cursor display when a 'display' text
8219 property immediately follows invisible text. (Bug#11094)
8220
cb3c2e3e
PE
82212012-04-09 Paul Eggert <eggert@cs.ucla.edu>
8222
8223 composite.c: use 'double' consistently
8224 * composite.c (get_composition_id): Use 'double' consistently
8225 instead of converting 'float' to 'double' and vice versa; this is
8226 easier to understand and avoids a GCC warning.
8227
fd06db5d
GM
82282012-04-09 Glenn Morris <rgm@gnu.org>
8229
50fe702a
GM
8230 * Makefile.in: Generate leim-list with bootstrap-emacs, in
8231 preparation for dumping it with emacs. (Bug#4789)
8232 (leimdir): New variable.
8233 ($(leimdir)/leim-list.el): New rule.
8234 (emacs$(EXEEXT)): Depend on leim-list.el.
8235
fd06db5d
GM
8236 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
8237 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
8238 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
8239
55c131ee
AS
82402012-04-08 Andreas Schwab <schwab@linux-m68k.org>
8241
8242 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
8243 proper alignment.
8244
9209588f
JB
82452012-04-07 Juanma Barranquero <lekktu@gmail.com>
8246
8247 * xml.c (init_libxml2_functions) [WINDOWSNT]:
8248 Remove unused local variable.
8249
e3fb2efb
PE
82502012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8251
8252 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
8253 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
8254 (mark_memory): Mark Lisp_Objects only if pointers might hide in
8255 objects, as mark_maybe_pointer will catch them otherwise.
8256 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
8257 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
8258
b5385551
PE
82592012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8260
8261 Fix typo that broke non-Windows builds.
8262 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
8263
9078ead6
EZ
82642012-04-07 Eli Zaretskii <eliz@gnu.org>
8265
8266 Support building on MS-Windows with libxml2.
8267
8268 * makefile.w32-in (OBJ2): Add xml.$(O).
8269 (GLOBAL_SOURCES): Add xml.c.
8270 ($(BLD)/xml.$(O)): New dependency list.
8271
8272 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
8273 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
8274 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
8275 [!WINDOWSNT]: New macros.
8276 (init_libxml2_functions, libxml2_loaded_p): New functions.
8277 (parse_region): Call fn_xmlCheckVersion instead of using the macro
8278 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
8279 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
8280 Calls xmlCleanupParser only if libxml2 was loaded (or statically
8281 linked in).
6bbef4e5
JC
8282 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
8283 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
8284 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
8285
8286 * emacs.c: Don't include libxml/parser.h.
8287 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
8288 xmlCleanupParser directly.
8289
8290 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
8291
3811fdf3
EZ
82922012-04-07 Eli Zaretskii <eliz@gnu.org>
8293
8294 * indent.c (Fvertical_motion): If there is a display string at
8295 point, use it.vpos to compute how many lines to backtrack after
8296 move_it_to point. (Bug#11133)
8297
2f8e16b2
EZ
82982012-04-06 Eli Zaretskii <eliz@gnu.org>
8299
8300 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
8301 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
8302 about subtle differences between FETCH_CHAR* and STRING_CHAR*
8303 macros related to unification of CJK characters. For the details,
8304 see the discussion following the message here:
8305 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
8306
3d439cd1
CY
83072012-04-04 Chong Yidong <cyd@gnu.org>
8308
8309 * keyboard.c (Vdelayed_warnings_list): Doc fix.
8310
8bc53d00
EZ
83112012-04-01 Eli Zaretskii <eliz@gnu.org>
8312
8313 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
8314 instead of alloca. (Bug#11138)
8315
3b0512a3
AS
83162012-04-01 Andreas Schwab <schwab@linux-m68k.org>
8317
8318 * w32menu.c (is_simple_dialog): Properly check lisp types.
8319 (Bug#11141)
8320
8427ddd2
EZ
83212012-03-31 Eli Zaretskii <eliz@gnu.org>
8322
979022ef
EZ
8323 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
8324 position we get to after a call to move_it_to fails the
8325 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
8326 only if we wind up in a string from display property. (Bug#11063)
8327
a6b1c7cc
EZ
8328 * window.c (Fdelete_other_windows_internal): Invalidate the row
8329 and column information about mouse highlight, so that redisplay
8330 restores it after reallocating the glyph matrices. (Bug#7464)
8331
8427ddd2
EZ
8332 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
8333 string comes from a `display' text property, use the buffer
8334 position of that property as if we actually saw that position in
8335 the row's glyphs.
697ba24b
EZ
8336 (move_it_by_lines): Remove the assertion that
8337 "it->current_x == 0 && it->hpos == 0" which can be legitimately
8338 violated when there's a before-string at the beginning of a line.
8339 (Bug#11063)
8427ddd2 8340
65a0a738
EZ
83412012-03-30 Eli Zaretskii <eliz@gnu.org>
8342
8343 * xdisp.c (append_space_for_newline): If the default face was
8344 remapped, use the remapped face for the appended newline.
8345 (extend_face_to_end_of_line): Use the remapped default face for
8346 extending the face to the end of the line.
8347 (display_line): Call extend_face_to_end_of_line when the default
8348 face was remapped. (Bug#11068)
8349
581355cc
EZ
83502012-03-29 Eli Zaretskii <eliz@gnu.org>
8351
8352 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
8353
e8fc049f
SM
83542012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8355
8356 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
8357
4fb9a543
GM
83582012-03-27 Glenn Morris <rgm@gnu.org>
8359
8360 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
8361 Doc fixes.
8362
679910f1
KH
83632012-03-26 Kenichi Handa <handa@m17n.org>
8364
8365 * dispextern.h (struct glyph): Fix previous change. Change the
8366 bit length of glyphless.ch to 25 (Bug#11082).
8367
90d49b7f
CY
83682012-03-26 Chong Yidong <cyd@gnu.org>
8369
8370 * keyboard.c (Vselection_inhibit_update_commands): New variable.
8371 (command_loop_1): Use it; inhibit selection update for
8372 handle-select-window too (Bug#8996).
8373
f514f6f0
FP
83742012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
8375
e8fc049f 8376 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 8377
bf43fa51
KH
83782012-03-25 Kenichi Handa <handa@m17n.org>
8379
8380 * dispextern.h (struct glyph): Change the bit length of
8381 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
8382
8a0c01dd
EZ
83832012-03-24 Eli Zaretskii <eliz@gnu.org>
8384
8385 * s/ms-w32.h (tzname): Include time.h before redirecting to
8386 _tzname. Fixes the MSVC build. (Bug#9960)
8387
7d1c3a76
AS
83882012-03-24 Andreas Schwab <schwab@linux-m68k.org>
8389
8ed79523
AS
8390 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
8391 characters.
8392
7d1c3a76
AS
8393 * xterm.c (XTread_socket): Only modify handling_signal if
8394 !SYNC_INPUT. (Bug#11080)
8395
e99a9b8b
EZ
83962012-03-23 Eli Zaretskii <eliz@gnu.org>
8397
8398 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
8399 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
8400 when fetching a multibyte character consumes more bytes than
8401 CHAR_BYTES returns, due to unification of CJK characters in
8402 string_char. (Bug#11073)
8403
5063c0e1
TN
84042012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
8405
8406 * process.c (wait_reading_process_output): Handle pty disconnect
8407 by refraining from sending oneself a SIGCHLD (bug#10933).
8408
9f851fbd
CY
84092012-03-22 Chong Yidong <cyd@gnu.org>
8410
8411 * dispextern.h (struct it): New member string_from_prefix_prop_p.
8412
5063c0e1 8413 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
8414 Mark string as coming from a prefix property.
8415 (handle_face_prop): Use default face for prefix strings (Bug#4281).
8416 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
8417
fb5b8aca
CY
84182012-03-21 Chong Yidong <cyd@gnu.org>
8419
8420 * xfaces.c (Vface_remapping_alist): Doc fix.
8421
62356a1b
EZ
84222012-03-20 Eli Zaretskii <eliz@gnu.org>
8423
8424 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
8425 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
8426 Doc fixes.
62356a1b 8427
025de85b
CY
84282012-03-20 Chong Yidong <cyd@gnu.org>
8429
8430 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
8431 to reflect default non-nil value of redisplay-dont-pause.
8432
4827f94e
KH
84332012-03-19 Kenichi Handa <handa@m17n.org>
8434
8435 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
8436 it fit in a valid range (Bug#11003).
8437
e50a24a2
EZ
84382012-03-18 Eli Zaretskii <eliz@gnu.org>
8439
8440 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
8441 that is not from display property, accept the row as a "cursor
8442 row" if one of the string's character has a non-nil `cursor'
8443 property. Fixes cursor positioning when there are newlines in
8444 overlay strings, e.g. in icomplete.el. (Bug#11035)
8445
9af5ed87
PE
84462012-03-12 Paul Eggert <eggert@cs.ucla.edu>
8447
8448 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
8449
d1f55f16
CY
84502012-03-12 Chong Yidong <cyd@gnu.org>
8451
8452 * eval.c (inhibit_lisp_code): Rename from
8453 inhibit_window_configuration_change_hook; move from window.c.
8454
8455 * xfns.c (unwind_create_frame_1, Fx_create_frame):
8456 * window.c (run_window_configuration_change_hook)
8457 (syms_of_window): Callers changed.
8458
66c5eebd
CY
84592012-03-11 Chong Yidong <cyd@gnu.org>
8460
413df973
CY
8461 * keymap.c (Fkey_description): Doc fix (Bug#9700).
8462
66c5eebd
CY
8463 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
8464
1de11f56
CY
84652012-03-10 Chong Yidong <cyd@gnu.org>
8466
8467 * frame.c (other_visible_frames): Don't assume the selected frame
8468 is visible (Bug#10955).
8469
cae07000
SM
84702012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
8471
8472 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
8473
89c94350
JD
84742012-03-08 Jan Djärv <jan.h.d@swipnet.se>
8475
8476 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
8477 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
8478 zero (Bug#10954).
8479
999dd333
GM
84802012-03-03 Glenn Morris <rgm@gnu.org>
8481
01a6dcc8 8482 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 8483
de0100f2
EZ
84842012-03-02 Eli Zaretskii <eliz@gnu.org>
8485
8486 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
8487 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
8488 (redisplay_window, next_element_from_string): Fix typos in
8489 comments.
3e441275
EZ
8490 (redisplay_window): Pass to move_it_vertically the margin in
8491 pixels, not in screen lines.
de0100f2 8492
96a72ee9
GM
84932012-03-02 Glenn Morris <rgm@gnu.org>
8494
8495 * buffer.c (buffer-list-update-hook): Doc fix.
8496
312508d7
EZ
84972012-02-29 Eli Zaretskii <eliz@gnu.org>
8498
8499 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
8500 push_it before setting up the iterator for the first overlay
8501 string, even if we have an empty string loaded.
8502 (next_overlay_string): If there's an empty string on the iterator
8503 stack, pop the stack. (Bug#10903)
8504
27f3c637
PE
85052012-02-25 Paul Eggert <eggert@cs.ucla.edu>
8506
8507 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
8508 Suggested by Stefan Monnier in
8509 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
8510 * alloc.c (widen_to_Lisp_Object): New static function.
8511 (mark_memory): Also mark Lisp_Objects by fetching pointer words
8512 and widening them to Lisp_Objects. This would work even if
8513 USE_LSB_TAG is defined and wide integers are used, which might
8514 happen in a future version of Emacs.
8515
3c9dfce6
CY
85162012-02-25 Chong Yidong <cyd@gnu.org>
8517
fa74b241
CY
8518 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
8519 Doc fix.
8520
3c9dfce6
CY
8521 * xselect.c (Fx_selection_exists_p): Doc fix.
8522 (x_clipboard_manager_save_all): Print an informative message
8523 before saving to clipboard manager.
8524
9486df08
CY
85252012-02-24 Chong Yidong <cyd@gnu.org>
8526
8527 * keyboard.c (process_special_events): Handle all X selection
8528 requests in kbd_buffer, not just the next one (Bug#8869).
8529
f01d3321
CY
85302012-02-23 Chong Yidong <cyd@gnu.org>
8531
8532 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
8533 call when setting menu-bar-lines and tool-bar-lines parameters.
8534 (unwind_create_frame_1): New helper function.
8535
8536 * window.c (inhibit_window_configuration_change_hook): New var.
8537 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 8538 (syms_of_window): Initialize it.
f01d3321 8539
86b847b6
CY
85402012-02-22 Chong Yidong <cyd@gnu.org>
8541
8542 * xterm.c (x_draw_image_relief): Add missing type check for
8543 Vtool_bar_button_margin (Bug#10743).
8544
a59225b1
CY
85452012-02-21 Chong Yidong <cyd@gnu.org>
8546
8547 * fileio.c (Vfile_name_handler_alist): Doc fix.
8548
8549 * buffer.c (Fget_file_buffer): Protect against invalid file
8550 handler return value.
8551
310f5bd4
PE
85522012-02-20 Paul Eggert <eggert@cs.ucla.edu>
8553
cb3a28cc
PE
8554 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
8555 when computing $valmask.
8556
310f5bd4
PE
8557 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
8558 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
8559 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
8560 It's useless in that case, and it can cause problems on hosts
8561 that allocate halves of EMACS_INT values separately.
8562 Reported by Dan Horák. Diagnosed by Andreas Schwab in
8563 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
8564 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
8565 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
8566 it avoids undefined behavior on hosts where shifting right by more
8567 than the word width has undefined behavior.
8568
2375c96a
CY
85692012-02-19 Chong Yidong <cyd@gnu.org>
8570
8571 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
8572 (Funhandled_file_name_directory, Ffile_name_as_directory)
8573 (Fdirectory_file_name, Fexpand_file_name)
8574 (Fsubstitute_in_file_name): Protect against invalid file handler
8575 return values (Bug#10845).
8576
3eb49e71
EZ
85772012-02-18 Eli Zaretskii <eliz@gnu.org>
8578
8579 * .gdbinit (pitx): Fix incorrect references to fields of the
8580 iterator stack.
8581
7b926f3f
CY
85822012-02-17 Chong Yidong <cyd@gnu.org>
8583
8584 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
8585
11273115
PE
85862012-02-15 Paul Eggert <eggert@cs.ucla.edu>
8587
8588 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
8589 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
8590
c3a70e2b
CY
85912012-02-15 Chong Yidong <cyd@gnu.org>
8592
8593 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
8594 marked as special. Also, starting docstrings with * is obsolete.
8595
0ca43699
AS
85962012-02-13 Andreas Schwab <schwab@linux-m68k.org>
8597
8598 * gnutls.c (emacs_gnutls_write): Fix last change.
8599
2e8f3c56
LI
86002012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
8601
8602 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
8603 send_process.
8604
af70074f
SM
86052012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
8606
8607 * keymap.c (Fsingle_key_description): Handle char ranges.
8608
95986d52
CY
86092012-02-12 Chong Yidong <cyd@gnu.org>
8610
afd83bd1
CY
8611 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
8612 as that creates a dangerous corner case.
8613
95986d52
CY
8614 * window.c (Fdelete_window_internal): Invalidate the mouse
8615 highlight (Bug#9904).
8616
bd7da63e
GM
86172012-02-12 Glenn Morris <rgm@gnu.org>
8618
8619 * xselect.c (Fx_own_selection_internal)
8620 (Fx_get_selection_internal, Fx_disown_selection_internal)
8621 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
8622 * nsselect.m (Fx_own_selection_internal)
8623 (Fx_disown_selection_internal, Fx_selection_exists_p)
8624 (Fx_selection_owner_p, Fx_get_selection_internal):
8625 Sync docs and argument specs with the xselect.c versions.
8626
77abcbc2
LI
86272012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
8628
8629 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
8630
90b671e2
EZ
86312012-02-11 Eli Zaretskii <eliz@gnu.org>
8632
1c0ca0b7
EZ
8633 * w32select.c (Fx_selection_exists_p): Sync doc string and
8634 argument list with xselect.c. (Bug#10783)
8635
8636 * w16select.c (Fx_selection_exists_p): Sync doc string and
8637 argument list with xselect.c. (Bug#10783)
90b671e2 8638
49241268
GM
86392012-02-10 Glenn Morris <rgm@gnu.org>
8640
8641 * fns.c (Fsecure_hash): Doc fix.
8642
f998bbe7 86432012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
8644
8645 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
8646
0992bd9c
CY
86472012-02-07 Chong Yidong <cyd@gnu.org>
8648
8649 * buffer.c (Fbuffer_local_variables)
8650 (buffer_lisp_local_variables): Handle unbound vars correctly;
8651 don't let Qunbound leak into Lisp.
8652
af008560
GM
86532012-02-07 Glenn Morris <rgm@gnu.org>
8654
dd605cc4
GM
8655 * image.c (Fimagemagick_types): Doc fix.
8656
af008560
GM
8657 * image.c (imagemagick-render-type): Change it from a lisp object
8658 to an integer. Move the doc here from the lisp manual.
8659 Treat all values not equal to 0 the same.
8660
1449fa1d
CY
86612012-02-06 Chong Yidong <cyd@gnu.org>
8662
8663 * doc.c (store_function_docstring): Avoid applying docstring of
8664 alias to base function (Bug#2603).
8665
3723ec07
AS
86662012-02-04 Andreas Schwab <schwab@linux-m68k.org>
8667
8668 * .gdbinit (pp1, pv1): Remove redundant defines.
8669 (pr): Use pp.
8670
79c1cc1e
CY
86712012-02-04 Chong Yidong <cyd@gnu.org>
8672
8673 * nsterm.m: Declare a global (Bug#10694).
8674
d7f29f8e
EZ
86752012-02-04 Eli Zaretskii <eliz@gnu.org>
8676
cae07000
SM
8677 * w32.c (get_emacs_configuration_options):
8678 Include --enable-checking, if specified, in the return value.
d7f29f8e 8679
3b95a6f9
MR
86802012-02-04 Martin Rudalics <rudalics@gmx.at>
8681
8682 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
8683 after rounding frame sizes. (Bug#9723)
8684
d6fa96a6
EZ
86852012-02-04 Eli Zaretskii <eliz@gnu.org>
8686
8687 * keyboard.c (adjust_point_for_property): Don't position point
8688 before BEGV. (Bug#10696)
8689
df0b2940
PE
86902012-02-03 Paul Eggert <eggert@cs.ucla.edu>
8691
8692 Handle overflow when computing char display width (Bug#9496).
8693 * character.c (char_width): Return EMACS_INT, not int.
8694 (char_width, c_string_width): Check for overflow when
8695 computing the width; this is possible now that individual
8696 characters can have unbounded width. Problem introduced
8697 by merge from Emacs 23 on 2012-01-19.
8698
6bee44d6
MA
86992012-02-02 Michael Albinus <michael.albinus@gmx.de>
8700
8701 * dbusbind.c (Fdbus_register_method): Mention the return value
8702 :ignore in the docstring.
8703
44f92739
GM
87042012-02-02 Glenn Morris <rgm@gnu.org>
8705
1b9f60cc
GM
8706 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
8707
44f92739
GM
8708 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8709 Unconditionally set to t. (Bug#10673)
8710 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8711 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
8712 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
8713
c5d3843c
KH
87142012-02-02 Kenichi Handa <handa@m17n.org>
8715
8716 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
8717 0, do not call append_composite_glyph.
8718
159462d4 87192012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
8720
8721 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
8722 NULL (Bug#6988).
8723 (x_produce_glyphs): If the component of a composition is a null
8724 string, set it->pixel_width to 1 to avoid zero-width glyph.
8725
78cef877
EZ
87262012-02-01 Eli Zaretskii <eliz@gnu.org>
8727
8728 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
8729 first 2 arguments are identical. This makes inserting large
8730 output from a subprocess an order of magnitude faster on
8731 MS-Windows, where all sbrk'ed memory is always contiguous.
8732
97897668
GM
87332012-01-31 Glenn Morris <rgm@gnu.org>
8734
8735 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 8736 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
8737 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
8738
31fd3586
GM
87392012-01-29 Glenn Morris <rgm@gnu.org>
8740
8741 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
8742
0e24a8b2
CY
87432012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
8744
8745 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
8746
cc0adcb0
CY
87472012-01-28 Chong Yidong <cyd@gnu.org>
8748
8749 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
8750
acc28cb9
CY
87512012-01-26 Chong Yidong <cyd@gnu.org>
8752
9c69cfb7
CY
8753 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
8754
acc28cb9
CY
8755 * search.c (Fsearch_forward, Fsearch_backward): Document negative
8756 repeat counts (Bug#10507).
8757
48da7392
GM
87582012-01-26 Glenn Morris <rgm@gnu.org>
8759
8760 * lread.c (syms_of_lread): Doc fix.
8761
14af5f7f
CY
87622012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
8763
8764 * coding.c (encode_designation_at_bol): Change return value to
8765 EMACS_INT.
8766
0b21c100
CY
87672012-01-25 Chong Yidong <cyd@gnu.org>
8768
8769 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
8770
3c2907f7
CY
87712012-01-21 Chong Yidong <cyd@gnu.org>
8772
8773 * floatfns.c (Fcopysign): Make the second argument non-optional,
8774 since nil is not allowed anyway.
8775
959ad23f
AS
87762012-01-21 Andreas Schwab <schwab@linux-m68k.org>
8777
8778 * process.c (read_process_output): Use p instead of XPROCESS (proc).
8779 (send_process): Likewise.
8780
34a02f46
MR
87812012-01-19 Martin Rudalics <rudalics@gmx.at>
8782
8783 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
8784 (Vwindow_persistent_parameters): Do not use Qstate.
8785 Rewrite doc-strings.
34a02f46 8786
1259009a 87872012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
8788
8789 * character.c (char_width): New function.
70d4fdf6
GM
8790 (Fchar_width, c_string_width, lisp_string_width):
8791 Use char_width (Bug#9496).
25ed9e61 8792
6a6ee00d
MR
87932012-01-16 Martin Rudalics <rudalics@gmx.at>
8794
8795 * window.c (Vwindow_persistent_parameters): New variable.
8796 (Fset_window_configuration, save_window_save): Handle persistent
8797 window parameters.
8798
c85efaf7
EZ
87992012-01-14 Eli Zaretskii <eliz@gnu.org>
8800
8801 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
8802 thrashing the stack of the thread. (Bug#9087)
8803
5944709e
PE
88042012-01-12 Paul Eggert <eggert@cs.ucla.edu>
8805
8806 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
8807
e71f5d99
EZ
88082012-01-11 Eli Zaretskii <eliz@gnu.org>
8809
8810 * xdisp.c (rows_from_pos_range): Handle the case where the
8811 highlight ends on a newline. (Bug#10464)
8812 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
8813 he end column for display of highlight that ends on a newline
8814 before a R2L line.
8815
ce316182
GM
88162012-01-11 Glenn Morris <rgm@gnu.org>
8817
8818 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
8819 from load-path also when installation-directory is nil. (Bug#10208)
8820
5b43da69
GM
88212012-01-10 Glenn Morris <rgm@gnu.org>
8822
74cc8ff9
GM
8823 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
8824
7d8d6e4e
GM
8825 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
8826 Update template values to be closer to their typical values these days.
5b43da69 8827
a0db8d43
EZ
88282012-01-09 Eli Zaretskii <eliz@gnu.org>
8829
8830 * xdisp.c (rows_from_pos_range): Accept additional argument
8831 DISP_STRING, and accept any glyph in a row whose object is that
8832 string as eligible for mouse highlight. Fixes mouse highlight of
8833 display strings from overlays. (Bug#10464)
8834
9a0115ab 88352012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 8836
b9110d6a 8837 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
8838 * fileio.c (auto_saving_dir_umask): New static var.
8839 (Fmake_directory_internal): Use it.
8840 (do_auto_save_make_dir): Set it, instead of invoking chmod after
8841 creating the directory. The old code temporarily assigns
8842 too-generous permissions to the directory.
8843 (do_auto_save_eh): Clear it.
b9110d6a 8844 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
8845 that the var is always cleared.
8846
6c1bd3f3
EZ
88472012-01-07 Eli Zaretskii <eliz@gnu.org>
8848
8849 * search.c (scan_buffer): Pass character positions to
8850 know_region_cache, not byte positions. (Bug#6540)
8851
069d2b50
L
88522012-01-07 LynX <_LynX@bk.ru> (tiny change)
8853
8854 * w32.c (sys_rename): Report EXDEV when rename of a directory
8855 fails because the target is on another logical disk. (Bug#10284)
8856
75bf0d33
DB
88572012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
8858
8859 * xterm.c (x_embed_request_focus): New function.
8860
8861 * xterm.h: Add prototype.
8862
8863 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
8864
1c6e5a32
GM
88652012-01-05 Glenn Morris <rgm@gnu.org>
8866
8867 * emacs.c (emacs_copyright): Update short copyright year to 2012.
8868
651e947e
EZ
88692012-01-01 Eli Zaretskii <eliz@gnu.org>
8870
8871 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
8872 Load gnutls_transport_set_lowat only if GnuTLS version is below
8873 2.11.1.
8874 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
8875 GnuTLS versions below 2.11.1.
8876
3778cdd8
AL
88772011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
8878
8879 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
8880 to the doc string advising against its use for altering the way
8881 windows are scrolled.
8882
0e5317f7
KH
88832011-12-28 Kenichi Handa <handa@m17n.org>
8884
8885 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
8886 coding-system ASCII compatible only when it does not produce BOM
8887 on encoding (Bug#10383).
8888
93d5ca1f
JD
88892011-12-26 Jan Djärv <jan.h.d@swipnet.se>
8890
8891 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
8892 can scroll.
8893 (create_and_show_popup_menu): Always use menu_position_func for
8894 Gtk3 (Bug#10361).
8895
ca22b785
AS
88962011-12-24 Andreas Schwab <schwab@linux-m68k.org>
8897
8898 * callint.c (Fcall_interactively): Don't truncate prompt string.
8899
d048e1e6
EZ
89002011-12-23 Eli Zaretskii <eliz@gnu.org>
8901
8902 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
8903 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 8904 resumed from there (after widening). (Bug#10360)
d048e1e6 8905
5ccaba1f
JD
89062011-12-22 Jan Djärv <jan.h.d@swipnet.se>
8907
8908 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
8909
204ee57f
JD
89102011-12-21 Jan Djärv <jan.h.d@swipnet.se>
8911
b81d40f0
JB
8912 * nsterm.m (x_free_frame_resources):
8913 Release f->output_data.ns->miniimage.
204ee57f
JD
8914 (ns_index_color): Fix indentation. Do not retain
8915 color_table->colors[i].
8916
8917 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
8918 before returning.
8919
8920 * nsfns.m (x_set_background_color): Assign return value from
8921 ns_index_color to face-background instead of NSColor*.
8922 (ns_implicitly_set_icon_type): Fix indentation.
8923 Change assignment in for loop to comparison.
8924
8925 * emacs.c (ns_pool): New variable.
8926 (main): Assign ns_pool.
8927 (Fkill_emacs): Call ns_release_autorelease_pool.
8928
8929 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
8930 autorelease fdesc, release fdAttrs and tdict.
8931 (ns_get_covering_families): Release charset.
8932 (ns_findfonts): Release NSFontDescriptor created with new.
8933 (ns_uni_to_glyphs): Fix indentation.
8934 (setString): Release attrStr before assigning new value.
8935
c803b2b7
JD
89362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
8937
678f4426
JD
8938 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
8939 and NS_IMPL_COCOA.
8940 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
8941 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
8942
cd394be1 89432011-12-18 David Reitter <reitter@cmu.edu>
678f4426 8944
5fecd5fc
JD
8945 * nsterm.m (ns_term_init): Subscribe for notifications
8946 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
8947 to method trackingNotification in EmacsMenu.
8948
8949 * nsmenu.m (trackingMenu): New variable.
3771cb17 8950 (trackingNotification): New method (from Aquamacs).
5fecd5fc 8951 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 8952 from Aquamacs (Bug#7030).
678f4426
JD
8953
89542011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 8955
c803b2b7
JD
8956 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
8957 (symbol_to_nsstring): Fix indentation.
8958 (ns_symbol_to_pb): New function.
cae07000
SM
8959 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
8960 (Fns_rotate_cut_buffers_internal): Remove.
8961 (Fns_store_selection_internal): Rename from
c803b2b7
JD
8962 Fns_store_cut_buffer_internal.
8963 (ns_get_foreign_selection, Fx_own_selection_internal)
8964 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
8965 (Fns_get_selection_internal, Fns_store_selection_internal):
8966 Use ns_symbol_to_pb and check if return value is nil.
8967 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
8968 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
8969 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
8970 renamed to Sns_store_selection_internal.
8971 (ns_handle_selection_request): Move code to Fx_own_selection_internal
8972 and remove this function.
8973 (ns_handle_selection_clear): Remove, never used.
8974 (Fx_own_selection_internal): Move code from ns_handle_selection_request
8975 here.
8976
e1b01a3a
KB
89772011-12-17 Ken Brown <kbrown@cornell.edu>
8978
8979 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
8980 GID is unknown (Bug#10257).
8981
2adb6e85
PE
89822011-12-17 Paul Eggert <eggert@cs.ucla.edu>
8983
8984 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
8985 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
8986 which caused a build failure on GNU/Linux IA-64. This problem was
8987 introduced by my 2011-10-07 patch.
8988
d1d7b339
JL
89892011-12-15 Juri Linkov <juri@jurta.org>
8990
8991 * image.c (imagemagick_error): New function. (Bug#10112)
8992 (imagemagick_load_image): Comment out `MagickSetResolution' call.
8993 Use `imagemagick_error' where ImageMagick functions return
8994 `MagickFalse'.
8995 (Fimagemagick_types): Add `Fnreverse' to return the list in the
8996 proper order.
8997
100d5755
KH
89982011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8999
9000 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
9001 fill background (Bug#8992).
9002
454592a6
MR
90032011-12-13 Martin Rudalics <rudalics@gmx.at>
9004
9005 * window.c (Vwindow_combination_resize)
9006 (Vwindow_combination_limit): Use t instead of non-nil in
9007 doc-strings.
61d4b438
MR
9008 (Vrecenter_redisplay): Add first sentence of doc-string on
9009 separate line.
53524d93 9010 (Frecenter): Fix doc-string typo.
454592a6 9011
3633e3aa
KH
90122011-12-11 Kenichi Handa <handa@m17n.org>
9013
9014 * coding.c (Funencodable_char_position): Pay attention to the
9015 buffer text relocation (Bug#9389).
9016
7b9d523a 90172011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 9018
7b9d523a
JD
9019 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
9020 gtk_init (Bug#10100).
9021
b73189c6
EZ
90222011-12-10 Eli Zaretskii <eliz@gnu.org>
9023
9024 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
9025 IT->string is nil. (Bug#10263)
9026
f7dfe5d6
JD
90272011-12-10 Jan Djärv <jan.h.d@swipnet.se>
9028
83faebb4
JD
9029 * nsterm.h (x_free_frame_resources): Declare.
9030
f7dfe5d6
JD
9031 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
9032 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
9033
9034 * nsterm.h (ns_get_defaults_value): Declare.
9035
9036 * nsterm.m (ns_default): Call ns_get_defaults_value.
9037
7cd4e72c
EZ
90382011-12-09 Eli Zaretskii <eliz@gnu.org>
9039
9040 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
9041 (Bug#10170)
9042
b34d7317
YM
90432011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9044
9045 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
9046 that where the value of an _OBJC_* symbol points to is in the .bss
9047 section (Bug#10240).
9048
76470ad1
KH
90492011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9050
9051 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 9052 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 9053
745fff94
KH
90542011-12-08 Kenichi Handa <handa@m17n.org>
9055
9056 * ftfont.c (get_adstyle_property): Fix previous change
9057 (Bug#10233).
9058
6e44397c
JB
90592011-12-07 Juanma Barranquero <lekktu@gmail.com>
9060
9061 * w32.c (init_environment): If no_site_lisp, remove site-lisp
9062 dirs from the default value of EMACSLOADPATH (bug#10208).
9063
7efa6272
GM
90642011-12-07 Glenn Morris <rgm@gnu.org>
9065
9066 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
9067 installation and source directories as well. (Bug#10208)
9068
f6fc4d87
CY
90692011-12-06 Chong Yidong <cyd@gnu.org>
9070
9071 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
9072
2bf26180
GM
90732011-12-06 Glenn Morris <rgm@gnu.org>
9074
9075 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
9076 as an error, not just -1. (Bug#10217)
9077
3a6ad4f0
CY
90782011-12-05 Chong Yidong <cyd@gnu.org>
9079
9080 * keyboard.c (process_special_events): New function.
9081 (swallow_events, Finput_pending_p): Use it (Bug#10195).
9082
75a3b399
PE
90832011-12-05 Paul Eggert <eggert@cs.ucla.edu>
9084
9085 * coding.c (encode_designation_at_bol): Don't use uninitialized
9086 local variable (Bug#9318).
9087
c3c9e25e
KH
90882011-12-05 Kenichi Handa <handa@m17n.org>
9089
9090 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
9091 return Qnil (Bug#8046, Bug#10193).
9092
5eb05ea3
KH
90932011-12-05 Kenichi Handa <handa@m17n.org>
9094
9095 * coding.c (encode_designation_at_bol): New args charbuf_end and
9096 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
9097 (coding_set_source): Return how many bytes coding->source was
9098 relocated.
9099 (coding_set_destination): Return how many bytes
9100 coding->destination was relocated.
9101 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 9102 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
9103
91042011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9105
9106 * coding.c (CODING_CHAR_CHARSET_P): New macro.
9107 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
9108 macro (Bug#9318).
9109
91102011-12-05 Andreas Schwab <schwab@linux-m68k.org>
9111
9112 The following changes are to fix Bug#9318.
9113
a79703f5 9114 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
9115 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
9116 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 9117 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 9118
7dbda6df
JB
91192011-12-05 Juanma Barranquero <lekktu@gmail.com>
9120
9121 * lisp.h (process_quit_flag): Fix external declaration.
9122
6d5eb5b0
SM
91232011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
9124
9125 Don't macro-inline non-performance-critical code.
9126 * eval.c (process_quit_flag): New function.
9127 * lisp.h (QUIT): Use it.
9128
a0c3fad0
JD
91292011-12-04 Jan Djärv <jan.h.d@swipnet.se>
9130
9131 * nsfns.m (get_geometry_from_preferences): New function.
9132 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
9133
6c07aac2
AS
91342011-12-04 Andreas Schwab <schwab@linux-m68k.org>
9135
9136 * emacs.c (Qkill_emacs): Define.
9137 (syms_of_emacs): Initialize it.
9138 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
9139 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
9140 (quit_throw_to_read_char): Add parameter `from_signal'.
9141 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
9142 * lisp.h (QUIT): Call Fkill_emacs if requested.
9143
c052ead4
JD
91442011-12-03 Jan Djärv <jan.h.d@swipnet.se>
9145
9146 * widget.c (update_wm_hints): Return if wmshell is null.
9147 (widget_update_wm_size_hints): New function.
9148
9149 * widget.h (widget_update_wm_size_hints): Declare.
9150
9151 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
9152 widget_update_wm_size_hints (Bug#10104).
9153
9e49252b
EZ
91542011-12-03 Eli Zaretskii <eliz@gnu.org>
9155
9156 * xdisp.c (handle_invisible_prop): If the invisible text ends just
9157 before a newline, prepare the bidi iterator for consuming the
9158 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 9159 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 9160
02b16839
JL
91612011-12-02 Juri Linkov <juri@jurta.org>
9162
9163 * search.c (Fword_search_regexp): New Lisp function created from
9164 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
9165 (Fword_search_backward, Fword_search_forward)
9166 (Fword_search_backward_lax, Fword_search_forward_lax):
9167 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
9168 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
9169
0068070e
SM
91702011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
9171
9172 * fileio.c (Finsert_file_contents): Move after-change-function call
9173 to before the "handled:" label, since all "goto handled" appear in
9174 cases where the *-change-functions have already been properly called
9175 (bug#10117).
9176
3360a3fc
AS
91772011-12-01 Andreas Schwab <schwab@linux-m68k.org>
9178
9179 * keyboard.c (interrupt_signal): Don't call kill-emacs when
9180 waiting for input. (Bug#10169)
9181
73d6c093
EZ
91822011-11-30 Eli Zaretskii <eliz@gnu.org>
9183
9184 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
9185 verifies glyph row's hash code--we have just reallocated the
9186 glyphs, so their contents can be complete garbage. (Bug#10164)
9187
febe6bea
JB
91882011-11-30 Juanma Barranquero <lekktu@gmail.com>
9189
9190 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
9191
801a4313
EZ
91922011-11-30 Eli Zaretskii <eliz@gnu.org>
9193
9194 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
9195 attributes are tested _before_ calling verify_row_hash, to protect
9196 against GCC re-ordering of the tests. (Bug#10164)
9197
2b56b87e
JD
91982011-11-29 Jan Djärv <jan.h.d@swipnet.se>
9199
9200 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
9201
9202 * xterm.c (handle_one_xevent): Only set async_visible and friends
9203 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 9204 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
9205 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
9206
dbf31225
PE
92072011-11-28 Paul Eggert <eggert@cs.ucla.edu>
9208
9209 Remove GCPRO-related macros that exist only to avoid shadowing locals.
9210 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
9211 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
9212 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9213 All uses changed to use GCPRO1 etc.
9214 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
9215 Revert to old implementation (i.e., before 2011-03-11).
9216
1305621b
YM
92172011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9218
9219 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
9220 of scroll runs so as to avoid assigning disabled bogus rows and
9221 unnecessary graphics copy operations.
9222
8c9afb46
EZ
92232011-11-27 Eli Zaretskii <eliz@gnu.org>
9224
9225 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
9226 (snprintf) [_MSC_VER]: Redirect to _snprintf.
9227 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
9228 (malloc, free, realloc, calloc): Redirect to e_* only when
9229 compiling Emacs.
9230
9231 * lisp.h (GCTYPEBITS): Move before first use.
9232 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
9233 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
9234 this macro definition.
9235
9236 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
9237 _MSC_VER.
9238
54e9e3bf
JD
92392011-11-27 Jan Djärv <jan.h.d@swipnet.se>
9240
6d5eb5b0
SM
9241 * gtkutil.c (xg_create_frame_widgets):
9242 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
9243 present with Gtk+ 2.0.
9244
83aca1cb
PE
92452011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9246
9247 * fileio.c (Finsert_file_contents): Undo previous change; see
9248 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9249
5b76caa4
PE
92502011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9251
9252 Rename locals to avoid shadowing.
9253 * fileio.c (Finsert_file_contents):
9254 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
9255 * process.c (wait_reading_process_output):
9256 Rename inner 'proc' to 'p' to avoid shadowing.
9257 Indent for consistency with usual Emacs style.
9258
8c535114
EZ
92592011-11-25 Eli Zaretskii <eliz@gnu.org>
9260
9261 * xdisp.c (redisplay_window): If cursor row is not fully visible
9262 after recentering, and scroll-conservatively is set to a large
9263 number, scroll window by a few more lines to make the cursor fully
9264 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
9265 (start_display): Don't move to the next line if the display should
9266 start at a newline that is part of a display vector or an overlay
9267 string. (Bug#10119)
8c535114 9268
fa4fdb5c
JL
92692011-11-24 Juri Linkov <juri@jurta.org>
9270
9271 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
9272 after the `MagickPingImage' call. (Bug#10112)
9273
90ec88df
CY
92742011-11-23 Chong Yidong <cyd@gnu.org>
9275
9276 * window.c (Fcoordinates_in_window_p): Accept only live windows.
9277
56e2e794
MR
92782011-11-23 Martin Rudalics <rudalics@gmx.at>
9279
9280 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
9281 making another buffer current. (Bug#10114)
9282
b6e64c41
GM
92832011-11-23 Glenn Morris <rgm@gnu.org>
9284
9285 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
9286
6b21de18
CY
92872011-11-23 Chong Yidong <cyd@gnu.org>
9288
9289 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
9290 using it (Bug#5984).
9291
b12cd789
EZ
92922011-11-22 Eli Zaretskii <eliz@gnu.org>
9293
9294 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
9295 and header-lines, as they don't have one computed for them.
9296 (Bug#10098)
9297
9298 * .gdbinit (prow): Make displayed values more self-explaining.
9299 Add row's hash code.
9300
261b6fd4
LMI
93012011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
9302
9303 * process.c (wait_reading_process_output): Fix asynchrounous
9304 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 9305 (wait_reading_process_output): Add comment and URL.
261b6fd4 9306
e7cfd277
JD
93072011-11-21 Jan Djärv <jan.h.d@swipnet.se>
9308
9309 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
9310
a9b9b7f5
CY
93112011-11-21 Chong Yidong <cyd@gnu.org>
9312
9313 * window.c (Fnext_window, Fprevious_window): Doc fix.
9314
b0d15b4f
SM
93152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9316
9317 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
9318
fe7a3057
JB
93192011-11-20 Juanma Barranquero <lekktu@gmail.com>
9320
9321 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
9322
d2999b1a
MR
93232011-11-20 Martin Rudalics <rudalics@gmx.at>
9324
9325 * window.c (Fset_window_combination_limit): Rename argument
9326 STATUS to LIMIT.
9327 (Vwindow_combination_limit): Remove "status" from doc-string.
9328
d5ff9cd0
AS
93292011-11-20 Andreas Schwab <schwab@linux-m68k.org>
9330
9331 * m/ibms390.h: Remove.
9332 * m/ibms390x.h: Don't include "ibms390.h".
9333
a5bb9bd3
SM
93342011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9335
9336 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
9337 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
9338
cd1181db
JB
93392011-11-20 Juanma Barranquero <lekktu@gmail.com>
9340
9341 * casetab.c (Fset_case_table):
9342 * charset.c (Fcharset_after): Fix typos.
9343
615a3b8d 93442011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 9345
17e845af
PE
9346 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
9347 Otherwise, valgrind does not work on some platforms.
9348 Problem reported by Andreas Schwab in
6a0bf43d
PE
9349 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
9350 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
9351 is set, removing the need for VIRT_ADDRESS_VARIES.
9352 (PURE_P): Use a more-efficient implementation that needs just one
9353 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
9354 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
9355 to 4 (xorl, subq, cmpq, setbe).
9356 * alloc.c (pure): Always extern now, since that's the
9357 VIRT_ADDR_VARIES behavior.
9358 (PURE_POINTER_P): Use a single comparison, not two, for
9359 consistency with the new puresize.h.
9360 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
9361 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
9362 Remove VIRT_ADDR_VARIES no longer needed.
9363
f8fe6f96
EZ
93642011-11-19 Eli Zaretskii <eliz@gnu.org>
9365
9366 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
9367 (erase_phys_cursor, update_window_cursor, show_mouse_face)
9368 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
9369 behave as if the cursor position were at the window margin.
9370
9371 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
9372 and the cursor position is out of bounds, behave as if the cursor
9373 position were at the window margin. (Bug#10075)
9374
df05a53c
CY
93752011-11-18 Chong Yidong <cyd@gnu.org>
9376
9377 * window.c (Fwindow_combination_limit): Make first argument
9378 non-optional, since it is meaningless for live windows like the
9379 selected window.
61ccba97 9380
2071918e
DA
93812011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
9382
9383 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
9384
b50a28de
SM
93852011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
9386
9387 * intervals.c: Fix grafting over the whole buffer (bug#10071).
9388 (graft_intervals_into_buffer): Simplify.
9389
015137db
EZ
93902011-11-18 Eli Zaretskii <eliz@gnu.org>
9391
9392 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
9393 hash values of the two rows.
9394 (copy_row_except_pointers): Preserve the used[] arrays and the
9395 hash values of the two rows. (Bug#10035)
68c95424 9396 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
9397
9398 * xdisp.c (row_hash): New function, body extracted from
9399 compute_line_metrics.
9400 (compute_line_metrics): Call row_hash, instead of computing the
9401 hash code inline.
9402
9403 * dispnew.c (verify_row_hash): Call row_hash for computing the
9404 hash code of a row, instead of duplicating code from xdisp.c.
9405
9406 * dispextern.h (row_hash): Add prototype.
9407
a2addb04
TH
94082011-11-18 Tassilo Horn <tassilo@member.fsf.org>
9409
9410 * frame.c (delete_frame): Don't delete the terminal when the last
9411 X frame is closed if emacs is built with GTK toolkit.
9412
df85d315
JB
94132011-11-17 Juanma Barranquero <lekktu@gmail.com>
9414
9415 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
9416
a0c2d0ae
MR
94172011-11-17 Martin Rudalics <rudalics@gmx.at>
9418
9419 * window.c (Vwindow_splits): Rename to
9420 Vwindow_combination_resize. Suggested by Juri Linkov.
9421 (Fsplit_window_internal): Use Vwindow_combination_resize instead
9422 of Vwindow_splits.
9423
58179cce
JB
94242011-11-16 Juanma Barranquero <lekktu@gmail.com>
9425
7877f373
JB
9426 * nsfns.m (Fns_font_name):
9427 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 9428
b6f67890
MR
94292011-11-16 Martin Rudalics <rudalics@gmx.at>
9430
9431 * window.h (window): Rename slot "nest" to "combination_limit".
9432 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
9433 (Fset_window_nest): Rename to Fset_window_combination_limit.
9434 (Vwindow_nest): Rename to Vwindow_combination_limit.
9435 (recombine_windows, make_parent_window, make_window)
9436 (Fsplit_window_internal, saved_window)
9437 (Fset_window_configuration, save_window_save): Rename all
9438 occurrences of window_nest to window_combination_limit.
9439
c7015153
JB
94402011-11-15 Juanma Barranquero <lekktu@gmail.com>
9441
9442 * image.c (imagemagick_load_image): Fix typo.
9443
322ad6ec
EZ
94442011-11-14 Eli Zaretskii <eliz@gnu.org>
9445
9446 * xdisp.c (display_line): Move the call to
9447 highlight_trailing_whitespace before the call to
9448 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
9449 faces of all the glyphs to compute ROW's hash value.
9450 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 9451
f067b8ec
JB
94522011-11-14 Juanma Barranquero <lekktu@gmail.com>
9453
9454 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
9455 just return (bug#10044).
9456
1e5b2111
EZ
94572011-11-12 Eli Zaretskii <eliz@gnu.org>
9458
7ef3cbd5
EZ
9459 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
9460 with user-defined heap size. Bump the default size of the temacs
9461 heap to 27MB, to avoid memory warning when running temacs.
9462 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
9463
1e5b2111
EZ
9464 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
9465 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
9466 (verify_row_hash) [XASSERTS]: New function.
9467 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
9468 that the hash value of glyph rows is correct.
1e5b2111 9469
89d61221
MR
94702011-11-12 Martin Rudalics <rudalics@gmx.at>
9471
9472 * window.h (window): Remove splits slot.
9473 * window.c (Fwindow_splits, Fset_window_splits): Remove.
9474 (Fdelete_other_windows_internal, make_parent_window)
9475 (make_window, Fsplit_window_internal, Fdelete_window_internal)
9476 (Fset_window_configuration, save_window_save): Don't deal with
9477 split status of windows.
9478 (saved_window): Remove splits slot.
9479 (Vwindow_splits): Rewrite doc-string.
9480
97f18cc8
JD
94812011-11-11 Jan Djärv <jan.h.d@swipnet.se>
9482
9483 * xfns.c (unwind_create_frame):
9484 * nsfns.m (unwind_create_frame):
9485 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
9486 Vframe_list (Bug#9999).
9487
22a648b4
DA
94882011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
9489
0b381c7e 9490 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 9491
659afede
KH
94922011-11-11 Kenichi Handa <handa@m17n.org>
9493
9494 * callproc.c (Fcall_process): Set the member dst_multibyte of
9495 process_coding.
9496
9ac0394b
KH
94972011-11-11 Johan Bockgård <bojohan@gnu.org>
9498
9499 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
9500 avoid a crash (bug#9496).
9501
2fbdc249
CY
95022011-11-09 Chong Yidong <cyd@gnu.org>
9503
9504 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
9505 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
9506
ac6b1f81
PE
95072011-11-08 Paul Eggert <eggert@cs.ucla.edu>
9508
9509 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
9510
09db192c
PE
95112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
9512
9513 Avoid some portability problems by eschewing 'extern inline' functions.
9514 The trivial performance wins aren't worth the portability hassles; see
9515 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
9516 et seq.
9517 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
9518 (window_box_width, window_box_left, window_box_left_offset)
9519 (window_box_right, window_box_right_offset): Undo previous change,
9520 by removing the "extern"s.
9521 * intervals.c (adjust_intervals_for_insertion)
9522 (adjust_intervals_for_deletion): Undo previous change,
9523 making these static again.
9524 (offset_intervals, temp_set_point_both, temp_set_point)
9525 (copy_intervals_to_string): No longer inline.
9526 * xdisp.c (window_text_bottom_y, window_box_width)
9527 (window_box_height, window_box_left_offset)
9528 (window_box_right_offset, window_box_left, window_box_right)
9529 (window_box): No longer inline.
9530
105216ed
CY
95312011-11-08 Chong Yidong <cyd@gnu.org>
9532
9533 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
9534 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
9535 Signal an error if not a live window.
105216ed
CY
9536 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
9537 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
9538
ae9e237f
JB
95392011-11-07 Juanma Barranquero <lekktu@gmail.com>
9540
9541 * lisp.h (syms_of_abbrev): Remove declaration.
9542 Reported by CHENG Gao <chenggao@royau.me>.
9543
c7aa8333
EZ
95442011-11-07 Eli Zaretskii <eliz@gnu.org>
9545
9546 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
9547 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
9548 of temacs in GUI mode.
9549
be7f5545
MR
95502011-11-07 Martin Rudalics <rudalics@gmx.at>
9551
9552 * window.h: Declare delete_all_child_windows instead of
9553 delete_all_subwindows.
9554 * window.c (Fwindow_nest, Fset_window_nest)
9555 (Fset_window_new_total, Fset_window_new_normal)
9556 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
9557 (delete_all_subwindows): Rename to delete_all_child_windows.
9558 (Fdelete_other_windows_internal, Fset_window_configuration):
9559 Call delete_all_child_windows instead of delete_all_subwindows.
9560 * frame.c (delete_frame): Call delete_all_child_windows instead
9561 of delete_all_subwindows.
9562
ca78dc43
PE
95632011-11-07 Paul Eggert <eggert@cs.ucla.edu>
9564
9565 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
9566 This is also needed for porting to any host where GC_MARK_STACK is
9567 not GC_MAKE_GCPROS_NOOPS.
9568 (which_symbols): Use it.
9569
a0241d01
KH
95702011-11-07 Kenichi Handa <handa@m17n.org>
9571
9572 * coding.c (coding_set_destination): Check coding->src_pos only
9573 when coding->src_object is a buffer (bug#9910).
9574
9575 * process.c (send_process): Set the member src_multibyte of coding
9576 to 0 (bug#9911) when sending a unibyte text.
9577
9578 * callproc.c (Fcall_process): Set the member src_multibyte of
9579 process_coding to 0 (bug#9912).
9580
a64bfdfa 95812011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
9582
9583 * xmenu.c (cleanup_widget_value_tree): New function.
9584 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
9585 calling free_menubar_widget_value_tree directly (Bug#9830).
9586
cb41b32a
PE
95872011-11-06 Paul Eggert <eggert@cs.ucla.edu>
9588
9589 Fix some portability problems with 'inline'.
9590 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
9591 (window_box_width, window_box_left, window_box_left_offset)
9592 (window_box_right, window_box_right_offset): Declare extern.
9593 Otherwise, these inline functions do not conform to C99 and
9594 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
9595 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
9596 * intervals.c (adjust_intervals_for_insertion)
9597 (adjust_intervals_for_deletion): Now extern, because otherwise the
9598 extern inline functions 'offset_intervals' couldn't refer to it.
9599 (static_offset_intervals): Remove.
9600 (offset_intervals): Rewrite using the old contents of
9601 static_offset_intervals. The old version didn't conform to C99
9602 because an extern inline function contained a reference to an
9603 identifier with static linkage.
9604
b7041366
AS
96052011-11-06 Andreas Schwab <schwab@linux-m68k.org>
9606
9607 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
9608 GC.
9609
88a37c4d
EZ
96102011-11-06 Eli Zaretskii <eliz@gnu.org>
9611
9612 * xdisp.c (init_iterator, reseat_to_string): Don't set the
9613 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
9614 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
9615 return Qleft_to_right.
9616
49745b39
CY
96172011-11-06 Chong Yidong <cyd@gnu.org>
9618
9619 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
9620 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
9621 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
9622 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
9623 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
9624 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
9625 (Fwindow_vscroll): Doc fix.
9626 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
9627 argument, since it makes no sense to pass a live window and for
9628 consistency with window-child.
9629
1f05cd82
CS
96302011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
9631
9632 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
9633 support MSVC.
9634
22610910
JR
96352011-11-05 Jason Rumney <jasonr@gnu.org>
9636
9637 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
9638 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
9639 fonts (Bug#6029).
9640 (add_font_entity_to_list): Fix logic errors in mixed boolean and
9641 bitwise arithmetic preventing use of unicode-sip and non-truetype
9642 opentype fonts.
9643
a06776b2
EZ
96442011-11-05 Eli Zaretskii <eliz@gnu.org>
9645
3ad924ba
EZ
9646 * s/ms-w32.h (fstat, stat, utime): Move redirections to
9647 "emacs"-only part.
9648
a06776b2
EZ
9649 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
9650 initialization code to keep similarity to xfns.c after changes
9651 from 2011-11-05.
9652
c9e7db78
JD
96532011-11-05 Jan Djärv <jan.h.d@swipnet.se>
9654
a97f8f3f
JD
9655 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
9656 (unwind_create_frame): New function (Bug#9943).
9657 (Fx_create_frame): Restructure code to be more similar to the one in
9658 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
9659 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
9660 Move terminal->reference_count++ just before making the frame official
9661 (Bug#9943).
9662
9663 * nsterm.m (x_free_frame_resources): New function.
9664 (x_destroy_window): Move code to x_free_frame_resources.
9665
c9e7db78 9666 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
9667 (Fx_create_frame, x_create_tip_frame):
9668 Move terminal->reference_count++ just before making the frame
75f1671a 9669 official. Move initialization of image_cache_refcount and
c9e7db78
JD
9670 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
9671
a6fc3b5c
EZ
96722011-11-05 Eli Zaretskii <eliz@gnu.org>
9673
9674 Support MSVC build with newer versions of Visual Studio.
9675 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
9676 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
9677 nt/gmake.defs.
9678
9679 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
9680 which are not supported by MSVC.
9681 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
9682 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
9683 bitfields.
9684 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
9685 types in bitfields.
9686 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
9687
9688 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
9689
58179cce 96902011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
9691
9692 Support MSVC build with newer versions of Visual Studio.
9693 * w32.c: Don't include w32api.h for MSVC.
9694 (init_environment) [_MSC_VER]: Call sys_access, not _access.
9695
9696 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
9697 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
9698 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
9699 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
9700 e_* cousins.
9701 (alloca) [_MSC_VER]: Define to _alloca.
9702
9703 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
9704
9705 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
9706
a58c13ed
EZ
97072011-11-04 Eli Zaretskii <eliz@gnu.org>
9708
9709 * xdisp.c (note_mouse_highlight): If either of
9710 previous/next-single-property-change returns nil, treat that as
9711 the beginning or the end of the buffer. (Bug#9955)
9712
fe0b6370
JD
97132011-11-04 Jan Djärv <jan.h.d@swipnet.se>
9714
a58c13ed 9715 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
9716 label is not null (Bug#9951).
9717 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
9718 may be NULL.
9719
89bd5ee1
EZ
97202011-11-04 Eli Zaretskii <eliz@gnu.org>
9721
9722 * window.c (Fwindow_body_size): Mention in the doc string that the
9723 return value is in frame's canonical units. (Bug#9949)
9724
84c3edb9
EZ
97252011-11-03 Eli Zaretskii <eliz@gnu.org>
9726
4e2fb5c7
EZ
9727 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
9728
84c3edb9 9729 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 9730 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 9731 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 9732
bc17a887
EZ
97332011-11-01 Eli Zaretskii <eliz@gnu.org>
9734
9735 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
9736 Don't stop backward scan on the continuation glyph, even though
9737 its CHARPOS is positive.
6d5eb5b0
SM
9738 (mouse_face_from_buffer_pos, note_mouse_highlight):
9739 Rename cover_string to disp_string.
bc17a887 9740
4ee88440
MR
97412011-11-01 Martin Rudalics <rudalics@gmx.at>
9742
9743 * window.c (temp_output_buffer_show): Don't use
9744 Vtemp_buffer_show_specifiers.
9745 (Vtemp_buffer_show_specifiers): Remove unused variable.
9746
c2ff3c02
EZ
97472011-10-30 Eli Zaretskii <eliz@gnu.org>
9748
9749 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
9750 past the beginning of the current glyph matrix.
9751
58179cce 97522011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
9753
9754 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
9755 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
9756 HAVE_GTK3 (Bug#9869).
b77a6a7f 9757
3b574623
JD
9758 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
9759 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
9760
b77a6a7f
JD
9761 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
9762
9763 * xterm.c: Declare x_handle_net_wm_state to return int.
9764 (handle_one_xevent): Check if we are iconified but don't have
9765 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
9766 (get_current_wm_state): Return non-zero if not hidden,
9767 check for _NET_WM_STATE_HIDDEN (Bug#9893).
9768 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
9769 (x_handle_net_wm_state): Return what get_current_wm_state returns.
9770 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
9771
196e41e4
PE
97722011-10-29 Paul Eggert <eggert@cs.ucla.edu>
9773
9774 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
9775 so that this new function doesn't get optimized away by a
9776 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
9777
021f2e1a
AS
97782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9779
9780 * frame.h (MOUSE_HL_INFO): Remove excess parens.
9781
8b058d44
EZ
97822011-10-29 Eli Zaretskii <eliz@gnu.org>
9783
9784 Fix the `xbytecode' command.
9785 * .gdbinit (xprintbytestr): New command.
b50a28de 9786 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
9787 (xbytecode): Print the byte-code string as well.
9788
4452fb80
EZ
97892011-10-29 Kim Storm <storm@cua.dk>
9790
8b058d44
EZ
9791 * alloc.c (which_symbols): New function.
9792
21b72067
AS
97932011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9794
9795 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
9796 line. (Bug#9903)
9797
83ed7b5c
GM
97982011-10-29 Glenn Morris <rgm@gnu.org>
9799
9800 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
9801 Not clear what it was for, and it causes various bugs. (Bug#9839)
9802
5a7a728b
EZ
98032011-10-28 Eli Zaretskii <eliz@gnu.org>
9804
9805 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
9806 possible random value that matches one of those tested as
9807 condition to clear the mouse face.
9808
d3d0842f
CY
98092011-10-28 Chong Yidong <cyd@gnu.org>
9810
9811 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
9812
31b39d13
DN
98132011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
9814
9815 * window.c (make_window): Initialize phys_cursor_on_p.
9816
9aba6043
SM
98172011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
9818
9819 * lisp.h (struct Lisp_Symbol): Update comments.
9820
c20992f4
JB
98212011-10-28 Juanma Barranquero <lekktu@gmail.com>
9822
9823 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
9824
db4f02f2
EZ
98252011-10-28 Eli Zaretskii <eliz@gnu.org>
9826
9827 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
9828 <oslsachem@gmail.com> for helping to debug this.
9829
9830 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
9831 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
9832 (g_b_init_get_glyph_outline_w): New static variables.
9833 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
9834 (GetGlyphOutlineW_Proc): New typedefs.
9835 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
9836 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
9837 New functions.
9838 (w32font_open_internal, compute_metrics):
9839 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
9840 instead of calling the "wide" APIs directly.
9841
9842 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
9843
9844 * w32.h (syms_of_w32font): Add prototype.
9845
87e68db4
JB
98462011-10-27 Juanma Barranquero <lekktu@gmail.com>
9847
9848 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
9849 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
9850 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
9851 (Fmove_to_window_line): Doc fix.
9852
435c1d67
CY
98532011-10-27 Chong Yidong <cyd@gnu.org>
9854
9855 * process.c (make_process): Set gnutls_state to NULL.
9856
9857 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
9858 non-NULL, regardless of GNUTLS_INITSTAGE.
9859 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
9860 an error. Set process slots as soon as we allocate them.
9861
9862 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
9863
9c6c6f49
CY
98642011-10-27 Chong Yidong <cyd@gnu.org>
9865
9aba6043
SM
9866 * gnutls.c (emacs_gnutls_deinit): New function.
9867 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
9868 (Fgnutls_deinit, Fgnutls_boot): Use it.
9869
9870 * process.c (make_process): Initialize GnuTLS credentials to NULL.
9871 (deactivate_process): Call emacs_gnutls_deinit.
9872
657d08d3
JB
98732011-10-27 Juanma Barranquero <lekktu@gmail.com>
9874
9875 * image.c (x_create_x_image_and_pixmap):
9876 * w32.c (sys_rename, w32_delayed_load):
9877 * w32font.c (fill_in_logfont):
9878 * w32reg.c (x_get_string_resource): Silence compiler warnings.
9879
5430d399
JB
98802011-10-26 Juanma Barranquero <lekktu@gmail.com>
9881
9882 * w32fns.c (w32_default_color_map): New function,
9883 extracted from Fw32_default_color_map.
a7ef684b 9884 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 9885
fe0055fa
PE
98862011-10-25 Paul Eggert <eggert@cs.ucla.edu>
9887
9888 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
9889
e6346438
SM
98902011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
9891
9892 * keyboard.c (test_undefined): New function (bug#9751).
9893 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
9894
e112cc37
ET
98952011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
9896
9897 * sysdep.c (init_sys_modes): Fix the check for the controlling
9898 terminal (Bug#6649).
9899
7b5d6677
EZ
99002011-10-20 Eli Zaretskii <eliz@gnu.org>
9901
9902 * dispextern.h (struct bidi_it): New member next_en_type.
9903
9904 * bidi.c (bidi_line_init): Initialize the next_en_type member.
9905 (bidi_resolve_explicit_1): When next_en_pos is valid for the
9906 current character, check also for next_en_type being WEAK_EN.
9907 (bidi_resolve_weak): Don't enter the expensive loop if the current
9908 position is before next_en_pos. Record the bidi type of the first
9909 non-ET, non-BN character we find, in addition to its position.
9910 (bidi_level_of_next_char): Invalidate next_en_type when
9911 next_en_pos is over-stepped.
9912
7da0b018
PE
99132011-10-20 Paul Eggert <eggert@cs.ucla.edu>
9914
9915 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
9916 * editfns.c: Rewrite current-time-zone so that it invokes
9917 the equivalent of (format-time-string "%Z") to get the time zone name.
9918 This fixes a bug when the time zone name contains characters that
9919 need converting from the system time locale to Emacs internal format.
9920 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
9921 that patch fixed format-time-string to do the conversion, but
9922 I forgot to fix current-time-zone.
9923 (format_time_string): New function, containing most of
9924 what Fformat_time_string used to contain.
9925 (Fformat_time_string): Rewrite in terms of format_time_string.
9926 This doesn't change this function's behavior.
9927 (current-time-zone): Rewrite to use format_time_string.
9928 This fixes the bug reported by Michael Schierl in
9929 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
9930 Jason Rumney's 2007-06-07 change worked around this bug, but
9931 didn't fix it.
9932 * systime.h (tzname, timezone): Remove no-longer-used declarations.
9933
8547b010
EZ
99342011-10-19 Eli Zaretskii <eliz@gnu.org>
9935
9936 * xdisp.c (start_display): If the character at POS is displayed
9937 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
9938 (try_window_reusing_current_matrix): If a line ends in a display
9939 vector or the next line starts in a display vector, continue
9940 redrawing the window even though the character position of
9941 start_row was reached.
8547b010
EZ
9942 (Bug#9771, part 2)
9943
4e948d15
CY
99442011-10-18 Chong Yidong <cyd@gnu.org>
9945
9946 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
9947 with nobreak-char-display too.
9948
4787455f
EZ
99492011-10-18 Eli Zaretskii <eliz@gnu.org>
9950
9951 Fix part 3 of bug#9771.
9952 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
9953 (bidi_resolve_neutral): Don't enter the expensive loop looking for
9954 non-neutral characters if the current character is a paragraph
9955 separator (a.k.a. Newline). This avoids running the same
9956 expensive loop twice, once when we consume the preceding newline
9957 and the other time when the line actually needs to be displayed.
9958 Avoid the loop when we see neutrals on the base embedding level
9959 following a character whose directionality is the same as the
9960 paragraph's. This avoids running the expensive loop when a line
9961 ends in a long sequence of neutrals, like control characters.
9962 Add assertion against STRONG_AL type. Slightly rearrange code
9963 that determines the type of a neutral given the first non-neutral
9964 that follows it.
9965 (bidi_level_of_next_char): Set next_en_pos to zero when
9966 invalidating its info.
9967
2c91f553
EZ
99682011-10-17 Eli Zaretskii <eliz@gnu.org>
9969
9970 * xdisp.c (push_display_prop): Determine whether to record string
9971 or buffer position by IT->string, not by IT->method. Allow
9972 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
9973 (move_it_vertically_backward): Don't look for character position
9974 immediately after the newline when in a continuation line.
9975 (Bug#9771, part 1)
2c91f553 9976
c7b08b0d
MR
99772011-10-15 Martin Rudalics <rudalics@gmx.at>
9978
9979 * window.c (coordinates_in_window): Rewrite and delabelize
9980 vertical border check. (Bug#5357) (Bug#9618)
9981
6b02f655
SM
99822011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
9983
9984 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
9985 errors in XSetWindowBorder (bug#9310).
9986
81d40c92
DA
99872011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
9988
9989 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
9990 avoid crash when xmalloc overrun checking is enabled.
9991
d4172c3b
EZ
99922011-10-13 Eli Zaretskii <eliz@gnu.org>
9993
9994 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
9995 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
9996 cursor motion with <left> and <right> arrow keys.
9997
9998 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
9999 some callers set that themselves.
10000
b00eea75
EZ
100012011-10-12 Eli Zaretskii <eliz@gnu.org>
10002
10003 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
10004 display string and the previous row comes from the same string and
10005 is empty. (Bug#9739) (Bug#9738)
10006
8fe012c4
SM
100072011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
10008
10009 * doc.c (get_doc_string): Encode file name (bug#9735).
10010
0074aef2
EZ
100112011-10-12 Eli Zaretskii <eliz@gnu.org>
10012
79beb178
EZ
10013 * bidi.c (bidi_level_of_next_char):
10014 * xdisp.c (get_visually_first_element): Remove old incorrect
10015 comments regarding the Unicode Line Separator character.
10016
0074aef2
EZ
10017 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
10018
6e4b3fbe
DA
100192011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
10020
10021 * alloc.c (Fgc_status): Do not access beyond zombies array
10022 boundary if nzombies > MAX_ZOMBIES.
10023 * alloc.c (dump_zombies): Add missing format specifier.
10024
0324f3af
PE
100252011-10-12 Paul Eggert <eggert@cs.ucla.edu>
10026
b5525cac
PE
10027 * xdisp.c (set_cursor_from_row): Simplify conditionals,
10028 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
10029
0324f3af
PE
10030 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
10031 Some packages use them to denote characters with modifiers.
10032
e9b5f888
AS
100332011-10-11 Andreas Schwab <schwab@linux-m68k.org>
10034
10035 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
10036 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
10037 matching a pp-number. Rename parameter var to var1.
10038
127827c0
SM
100392011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
10040
10041 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
10042
c8fd3bd0
GM
100432011-10-08 Glenn Morris <rgm@gnu.org>
10044
10045 * callint.c (Fcall_interactively): Give a more explicit error for the
10046 'c' case with a non-character input. (Bug#8479)
10047
352ec8ff
EZ
100482011-10-08 Eli Zaretskii <eliz@gnu.org>
10049
03669ccb
EZ
10050 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
10051 lines.
7061c986
EZ
10052 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
10053 lines that are hscrolled on the left.
03669ccb 10054
352ec8ff
EZ
10055 * dispnew.c (buffer_posn_from_coords): Account for a possible
10056 presence of header-line. (Bug#4426)
10057
a66cfb1c
SM
100582011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
10059
6b02f655
SM
10060 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
10061 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 10062
7c5ee88e
PE
100632011-10-07 Paul Eggert <eggert@cs.ucla.edu>
10064
10065 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
10066 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
10067 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
10068 this makes Emacs dump core during garbage collection on rare
10069 occasions. sizeof is obviously inferior to offsetof here, so
10070 stick with offsetof.
10071 (GC_POINTER_ALIGNMENT): New macro.
10072 (mark_memory): Omit 3rd (offset) arg; caller changed.
10073 Don't assume EMACS_INT alignment is the same as pointer alignment.
10074
df1bbe5b
SM
100752011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
10076
10077 * keyboard.c (read_key_sequence_remapped): New var.
10078 (read_key_sequence): Compute remapping in the right buffer.
10079 (command_loop_1): Use read_key_sequence's remapping directly.
10080
51553db6
SM
100812011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
10082
32c1fffd
SM
10083 * dired.c (file_name_completion): Don't expand file name.
10084 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
10085 before checking file name handler.
10086
51553db6
SM
10087 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
10088 they've been requested explicitly (bug#9591).
10089
b6bd1599 100902011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
10091
10092 * keymap.c (Fsingle_key_description): Use make_specified_string
10093 instead of build_string to build string from push_key_description.
10094 (Bug#5193)
10095
f701dc2a
PE
100962011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10097
4222c55d
PE
10098 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
10099 This fixes a Y2038 bug on 64-bit hosts.
10100 * buffer.c (reset_buffer):
10101 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
10102 (Fclear_buffer_auto_save_failure):
10103 Use 0, not -1, to represent an unset failure time, since time_t
10104 might not be signed.
10105
f701dc2a
PE
10106 Remove dependency on glibc malloc internals.
10107 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10108 Move back here from lisp.h, but with their new implementations.
10109 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10110 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
10111 * charset.c (charset_table_init): New static var.
10112 (syms_of_charset): Use it instead of xmalloc. This removes a
10113 dependency on glibc malloc internals. See Eli Zaretskii's comment in
10114 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
10115 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10116 Move back to alloc.c.
10117 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10118 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
10119
9ceebf39
JD
101202011-09-30 Jan Djärv <jan.h.d@swipnet.se>
10121
10122 * nsterm.m (windowDidResize): Call x_set_window_size only when
10123 ns_in_resize is true. Otherwise set pixelwidth/height and
10124 call change_frame_size (Bug#9628).
10125
cb993c58
PE
101262011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10127
3930c88b
PE
10128 Port --enable-checking=all to Fedora 14 x86-64.
10129 * charset.c (syms_of_charset): Also account for glibc malloc's
10130 internal overhead when calculating the initial malloc maximum.
10131
cb993c58
PE
10132 Port --enable-checking=all to Fedora 14 x86.
10133 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10134 Move to lisp.h.
10135 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
10136 (overrun_check_realloc, overrun_check_free):
10137 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
10138 That way, xmalloc returns a properly-aligned pointer even if
10139 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
10140 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
10141 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
10142 into account when calculating the initial malloc maximum.
10143 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10144 Move here from alloc.c, so that charset.c can use it too.
10145 Properly align; the old code wasn't right for common 32-bit hosts
10146 when configured with --enable-checking=all.
10147 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10148 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
10149
31bed486
EZ
101502011-09-29 Eli Zaretskii <eliz@gnu.org>
10151
04c70788 10152 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
10153 use EDOM.
10154
fbcaa2f3
EZ
101552011-09-28 Eli Zaretskii <eliz@gnu.org>
10156
10157 * xdisp.c (compute_display_string_end): If there's no display
10158 string at CHARPOS, return -1.
10159
10160 * bidi.c (bidi_fetch_char): When compute_display_string_end
10161 returns a negative value, treat the character as a normal
10162 character not covered by a display string. (Bug#9624)
10163
a239d4e9
JB
101642011-09-28 Juanma Barranquero <lekktu@gmail.com>
10165
10166 * lread.c (Fread_from_string): Fix typo in docstring.
10167
88652fd5
EZ
101682011-09-27 Eli Zaretskii <eliz@gnu.org>
10169
10170 * xdisp.c (handle_invisible_prop): If invisible text ends on a
10171 newline, reseat the iterator instead of bidi-iterating there one
10172 character at a time. (Bug#9610)
32c1fffd
SM
10173 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
10174 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 10175
ed497dd4
AS
101762011-09-27 Andreas Schwab <schwab@linux-m68k.org>
10177
10178 * lread.c (readevalloop): Use correct code for NBSP.
10179 (read1): Likewise. (Bug#9608)
10180
b2bf61aa
MA
101812011-09-25 Michael Albinus <michael.albinus@gmx.de>
10182
10183 * dbusbind.c (Fdbus_register_signal): When service is not
10184 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
10185
32bbb17c
GM
101862011-09-25 Glenn Morris <rgm@gnu.org>
10187
10188 * buffer.c (truncate-lines): Doc fix.
10189
94e0933e
CY
101902011-09-24 Chong Yidong <cyd@stupidchicken.com>
10191
10192 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
10193 (Fset_window_next_buffers): Doc fix.
10194
cddde921
GM
101952011-09-24 Glenn Morris <rgm@gnu.org>
10196
10197 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
10198
1260aef1
PE
101992011-09-24 Paul Eggert <eggert@cs.ucla.edu>
10200
25b4bfa0
PE
10201 Fix minor problems found by static checking.
10202 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
10203 * indent.c (Fvertical_motion): Fix == vs = typo.
10204
e3cbd34b
EZ
102052011-09-24 Eli Zaretskii <eliz@gnu.org>
10206
a66cfb1c
SM
10207 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
10208 Default value is now t. Doc fix.
6bf7006f 10209
e3cbd34b 10210 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 10211 logic when moving up, not only when moving down. Fix the
e3cbd34b 10212 confusing name and values of the it_overshoot_expected variable;
32c1fffd 10213 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
10214
10215 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
10216 CHARPOS is covered by a display string which includes newlines.
10217 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
10218 is covered by a display string with embedded newlines.
10219
a3de0cbd
MA
102202011-09-24 Michael Albinus <michael.albinus@gmx.de>
10221
10222 * dbusbind.c (Fdbus_register_signal): Add match rule to
10223 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
10224 (Fdbus_register_method, Vdbus_registered_objects_table):
10225 Fix docstring.
a3de0cbd 10226
b260039d
JM
102272011-09-24 Jim Meyering <meyering@redhat.com>
10228
32c1fffd 10229 do not ignore write error for any output size
b260039d
JM
10230 The previous change was incomplete.
10231 While it makes emacs --batch detect the vast majority of stdout
10232 write failures, errors were still ignored whenever the output size is
10233 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
10234 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
10235 && echo FAIL: ignored write error
10236 FAIL: ignored write error
10237 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
10238 && echo FAIL: ignored write error
10239 FAIL: ignored write error
10240 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
10241
8eca8a7c
AS
102422011-09-23 Andreas Schwab <schwab@linux-m68k.org>
10243
10244 * emacs.c (Fkill_emacs): In noninteractive mode exit
10245 non-successfully if a write error occurred on stdout. (Bug#9574)
10246
3341db62
EZ
102472011-09-21 Eli Zaretskii <eliz@gnu.org>
10248
10249 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
10250 the xassert test.
10251
10252 * dispextern.h (struct it): Update the comment documenting what
10253 can it->OBJECT be.
10254
8c203dbf
EZ
102552011-09-20 Eli Zaretskii <eliz@gnu.org>
10256
10257 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
10258 a display string, extend search for cursor position to end of row.
10259 (find_row_edges): If the row ends in a newline from a display
10260 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
10261 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
10262 (Fcurrent_bidi_paragraph_direction): Fix search for previous
10263 non-empty line. Fixes confusing cursor motion with arrow keys at
10264 the beginning of a line that starts with whitespace.
8c203dbf 10265
a4824228
LMI
102662011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10267
10268 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
10269 (bug#9493).
10270
33ed493b
CY
102712011-09-18 Chong Yidong <cyd@stupidchicken.com>
10272
10273 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
10274 boolean (Bug#9154).
10275
56cd55c8
EZ
102762011-09-18 Eli Zaretskii <eliz@gnu.org>
10277
10278 * xdisp.c (display_line): Record maximum and minimum buffer
10279 positions even if no glyphs were produced (e.g., by a zero-width
10280 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
10281 buffer positions that will be removed from the glyph row because
10282 they don't fit.
c02dcedf
EZ
10283 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
10284 column is beyond frame width: don't subtract 1 "pixel" when
10285 computing width of the stretch.
3e62b7e0
EZ
10286 (reseat_at_next_visible_line_start): Undo the change made on
10287 2011-09-17 that saved paragraph information and restored it after
10288 the call to `reseat'. (Bug#9545)
56cd55c8 10289
5ed99d36 102902011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
10291
10292 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
10293 and turn window cursor on if cleared (Bug#9415).
10294
5ed99d36 102952011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
10296
10297 * search.c (boyer_moore): Take unibyte characters from pattern
10298 literally. (Bug#9458)
10299
9bade7b2
EZ
103002011-09-18 Eli Zaretskii <eliz@gnu.org>
10301
10302 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
10303
e5e9d610
PE
103042011-09-18 Paul Eggert <eggert@cs.ucla.edu>
10305
87e4427a
PE
10306 Fix minor problem found by static checking.
10307 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
10308 initialized, to pacify gcc -Wuninitialized.
10309
e5e9d610
PE
10310 * fileio.c: Report proper errno when syscall falls.
10311 (Finsert_file_contents): Save and restore errno,
10312 so that report_file_error outputs the correct diagnostic.
10313 (Fwrite_region) [CLASH_DETECTION]: Likewise.
10314
a1674f0b
EZ
103152011-09-18 Eli Zaretskii <eliz@gnu.org>
10316
10317 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
10318
fbfb6dd4
EZ
103192011-09-17 Eli Zaretskii <eliz@gnu.org>
10320
10321 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
10322 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
10323
bb187662
EZ
103242011-09-17 Eli Zaretskii <eliz@gnu.org>
10325
1137e8b8 10326 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 10327 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
10328
10329 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
10330 (bidi_find_paragraph_start): Search back for paragraph beginning
10331 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
10332 (bidi_move_to_visually_next): Only trigger paragraph-related
10333 computations when the last character is a newline or at EOB, not
10334 just any NEUTRAL_B. (Bug#9470)
10335
bb187662
EZ
10336 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
10337 truncated lines if point is covered by a display string. (Bug#9524)
10338
2e621251
PE
103392011-09-16 Paul Eggert <eggert@cs.ucla.edu>
10340
10341 * xselect.c: Relax test for outgoing X longs (Bug#9498).
10342 (cons_to_x_long): New function.
10343 (lisp_data_to_selection_data): Use it. Correct the test for
10344 short-versus-long data; it was negated. Break out of vector
10345 loop, for efficiency, when a long datum is discovered.
10346
91a15bc6
SM
103472011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
10348
10349 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
10350
b41c3a35
EZ
103512011-09-16 Eli Zaretskii <eliz@gnu.org>
10352
10353 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
10354 GCC PR/17406) by declaring this function with external scope.
10355
7812ba2d
PE
103562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10357
10358 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
10359 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
10360
cf7edc2a
AS
103612011-09-15 Andreas Schwab <schwab@linux-m68k.org>
10362
10363 * editfns.c (Fformat): Correctly handle text properties on "%%".
10364
bd01620e
EZ
103652011-09-15 Eli Zaretskii <eliz@gnu.org>
10366
10367 * xterm.c (x_draw_composite_glyph_string_foreground):
10368 * w32term.c (x_draw_composite_glyph_string_foreground):
10369 * term.c (encode_terminal_code):
10370 * composite.c (composition_update_it, get_composition_id):
10371 * xdisp.c (get_next_display_element)
10372 (fill_composite_glyph_string): Add comments about special meaning
10373 of TAB characters in a composition.
10374
a02719a3
PE
103752011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10376
10377 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
10378 This occurs when processing a multibyte format.
10379 Problem reported by Wolfgang Jenker.
a02719a3 10380
72589a3c
JB
103812011-09-15 Johan Bockgård <bojohan@gnu.org>
10382
10383 * xdisp.c (try_cursor_movement): Only check for exact match if
10384 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
10385
1c14176c
PE
103862011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10387
10388 Remove unused external symbols.
10389 * dispextern.h (calc_pixel_width_or_height): Remove decl.
10390 * xdisp.c (calc_pixel_width_or_height): Now static.
10391 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
10392 * indent.c (check_display_width):
10393 * w32term.c: Fix comment to match code.
10394 * xterm.c, xterm.h (x_catching_errors): Remove.
10395
d2eea5b5
PE
103962011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10397
10398 * xselect.c: Use signed conversions more consistently (Bug#9498).
10399 (selection_data_to_lisp_data): Assume incoming selection data are
10400 signed integers, not unsigned. This is to be consistent with
10401 outgoing selection data, which was modified to use signed integers
10402 in as part of the fix to Bug#9196 in response to Jan D.'s comment
10403 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
10404 expects long, not unsigned long.
10405
46888499
EZ
104062011-09-14 Eli Zaretskii <eliz@gnu.org>
10407
10408 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
10409 computation of loop end. Reported by Johan Bockgård
10410 <bojohan@gnu.org>.
10411
ef8ef9fb
CY
104122011-09-13 Chong Yidong <cyd@stupidchicken.com>
10413
10414 * frame.c (Fother_visible_frames_p): Function deleted.
10415
fa819fed
EZ
104162011-09-12 Eli Zaretskii <eliz@gnu.org>
10417
10418 * indent.c (compute_motion): Process display vector front to back
10419 rather than the other way around. (Bug#2496)
10420
2ba8e008
SM
104212011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
10422
10423 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
10424
20f53c69
CY
104252011-09-11 Chong Yidong <cyd@stupidchicken.com>
10426
10427 * minibuf.c (Fread_from_minibuffer): Doc fix.
10428
d562d7a4
EZ
104292011-09-11 Eli Zaretskii <eliz@gnu.org>
10430
10431 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
10432 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
10433
1c4d7f3d
LMI
104342011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10435
10436 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
10437 value for non-existent files.
10438
b885bf36
EZ
104392011-09-11 Eli Zaretskii <eliz@gnu.org>
10440
10441 * fileio.c (Finsert_file_contents): If the file cannot be opened,
10442 set its "size" to -1. This will set the modtime_size field of
10443 the corresponding buffer to -1, which is what
10444 verify-visited-file-modtime expects for files that do not exist.
10445 (Bug#9139)
10446
6612f0bf
PE
104472011-09-11 Paul Eggert <eggert@cs.ucla.edu>
10448
10449 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
10450 here ...
10451 * lisp.h: ... from here. push_key_description is no longer
10452 defined in keyboard.c, so its declaration should not be in
10453 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
10454 logically belongs with push_key_description.
10455
dfb3f755
PE
104562011-09-10 Paul Eggert <eggert@cs.ucla.edu>
10457
10458 * buffer.h: Include <sys/types.h> instead of <time.h>.
10459 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
10460 Problem reported by Herbert J. Skuhra.
10461
3134906c
LMI
104622011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
10463
10464 * xml.c (parse_region): Make the parsing work for
10465 non-comment-starting XML files again (bug#9144).
10466
8d903f4e
AS
104672011-09-10 Andreas Schwab <schwab@linux-m68k.org>
10468
10469 * image.c (gif_load): Fix calculation of bottom and right corner.
10470 (Bug#9468)
10471
80ad64f4
EZ
104722011-09-10 Eli Zaretskii <eliz@gnu.org>
10473
10474 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
10475 redisplay in small windows.
10476
208a048d
EZ
104772011-09-09 Eli Zaretskii <eliz@gnu.org>
10478
10479 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
10480
9b1c252e
MR
104812011-09-08 Martin Rudalics <rudalics@gmx.at>
10482
10483 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
10484 Operate on live windows only.
10485
2949f33b
JB
104862011-09-08 Juanma Barranquero <lekktu@gmail.com>
10487
10488 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
10489
e08dcafd
EZ
104902011-09-07 Eli Zaretskii <eliz@gnu.org>
10491
10492 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
10493 only under bidi iteration.
10494
115b96bd
JD
104952011-09-07 Jan Djärv <jan.h.d@swipnet.se>
10496
10497 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
10498
c8199d0f
PE
104992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
10500
10501 isnan: Fix porting problem to Solaris 10 with bundled gcc.
10502 Without this fix, the command to link temacs failed due to an
10503 undefined symbol __builtin_isnan. This is because
10504 /usr/include/iso/math_c99.h #defines isnan(x) to
10505 __builtin_isnan(x), but the bundled gcc, which identifies itself
10506 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
10507 a __builtin_isnan.
10508 * floatfns.c (isnan): #undef, and then #define to a clone of
10509 what's in data.c.
10510 (Fisnan): Always define, since it's always available now.
10511 (syms_of_floatfns): Always define isnan at the Lisp level.
10512
e39b275c 105132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
10514
10515 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
10516
b2db44d9 105172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 10518
f4af5137 10519 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
10520 The previous code assumed that file offsets (off_t values) fit in
10521 EMACS_INT variables, which is not true on typical 32-bit hosts.
10522 The code messed up by falsely reporting buffer overflow in cases
10523 such as (insert-file-contents "big" nil 1 2) into an empty buffer
10524 when "big" contains more than 2**29 bytes, even though this
10525 inserts just one byte and does not overflow the buffer.
10526 (Finsert_file_contents): Store file offsets as off_t
10527 values, not as EMACS_INT values. Check for overflow when
10528 converting between EMACS_INT and off_t. When checking for
10529 buffer overflow or for overlap, take the offsets into account.
10530 Don't use EMACS_INT for small values where int suffices.
10531 When checking for overlap, fix a typo: ZV was used where
10532 ZV_BYTE was intended.
10533 (Fwrite_region): Don't assume off_t fits into 'long'.
10534 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
10535
ecfc0a49
MA
105362011-09-05 Michael Albinus <michael.albinus@gmx.de>
10537
10538 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
10539
6511acf2 105402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 10541
0999621a 10542 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
10543
10544 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 10545 (esprintf, exprintf, evxprintf): New functions.
62f19c19 10546 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 10547 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
10548 (modify_event_symbol): Do not assume that the length of
10549 name_alist_or_stem is safe to alloca and fits in int.
10550 (Fexecute_extended_command): Likewise for function name and binding.
10551 (Frecursion_depth): Wrap around reliably on integer overflow.
10552 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
10553 since some callers pass EMACS_INT values.
10554 (Fsingle_key_description): Don't crash if symbol name contains more
10555 than MAX_ALLOCA bytes.
10556 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
10557 (get_minibuffer): Arg is now EMACS_INT, not int.
10558 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 10559 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
10560 * window.h (command_loop_level, minibuf_level): Reflect API changes.
10561
2be7d702
PE
10562 * dbusbind.c (signature_cat): New function.
10563 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
10564 Do not overrun buffer; instead, report string overflow.
10565
9d1df220
PE
10566 * dispnew.c (add_window_display_history): Don't overrun buffer.
10567 Truncate instead; this is OK since it's just a log.
10568
33ef5c64
PE
10569 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
10570 even if the time zone offset is outlandishly large.
10571 Don't mishandle offset == INT_MIN.
10572
66c6fdd5
PE
10573 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
10574 when creating daemon; the previous buffer-overflow check was incorrect.
10575
d749b01b
PE
10576 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
10577 which has the guts of the old verror function.
10578
b5cd1905
PE
10579 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
10580 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
10581
6e1a67fb
PE
10582 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
10583 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 10584 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 10585 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
10586 length of string rather than counting it via multiple sprintfs;
10587 that's simpler and more reliable.
c21721cc
PE
10588 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
10589 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
10590 sprintf, in case result does not fit in int.
10591
c57b67fc
PE
10592 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
10593 (fontset_from_font): Print it.
10594
8a401434
PE
10595 * frame.c (tty_frame_count): Now printmax_t, not int.
10596 (make_terminal_frame, set_term_frame_name): Print it.
10597 (x_report_frame_params): In X, window IDs are unsigned long,
10598 not signed long, so print them as unsigned.
10599 (validate_x_resource_name): Check for implausibly long names,
10600 and don't assume name length fits in 'int'.
10601 (x_get_resource_string): Don't blindly alloca invocation name;
10602 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
10603 not fit in int.
10604
6e1a67fb
PE
10605 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
10606 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
10607 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
10608
0df02bf3
PE
10609 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
10610 Use esprintf, not sprintf, in case result does not fit in int.
10611
48e30793
PE
10612 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
10613 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
10614 it as a large positive number.
10615 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
10616 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
10617
a66ff6d8
PE
10618 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
10619 in case result does not fit in int.
10620
aca216ff
PE
10621 * print.c (float_to_string): Detect width overflow more reliably.
10622 (print_object): Make sprintf buffer a bit bigger, to avoid potential
10623 buffer overrun. Don't assume list length fits in 'int'. Treat
10624 print length of 0 as 0, not as infinity; to be consistent with other
10625 uses of print length in this function. Don't overflow print length
10626 index. Don't assume hash table size fits in 'long', or that
10627 vectorlike size fits in 'unsigned long'.
10628
31c286f7
PE
10629 * process.c (make_process): Use printmax_t, not int, to format
10630 process-name gensyms.
10631
55e5faa1
PE
10632 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
10633
80f2e268
PE
10634 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
10635 to avoid potential buffer overrun.
10636
670741ab
PE
10637 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
10638 if X resource line is longer than 512 bytes.
10639
b7163a50
PE
10640 * xfns.c (x_window): Make sprintf buffer a bit bigger
10641 to avoid potential buffer overrun.
10642
ae58ff1f
PE
10643 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
10644
c43c8a6a
PE
10645 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
10646
3f8236f4
PE
106472011-09-04 Paul Eggert <eggert@cs.ucla.edu>
10648
53e9fe90 10649 Integer overflow fixes for scrolling, etc.
6511acf2
PE
10650 Without these, Emacs silently mishandles large integers sometimes.
10651 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
10652 it were "C-u 1 M-x recenter" on a typical 64-bit host.
10653
6511acf2
PE
10654 * xdisp.c (try_window_id): Check Emacs fixnum range before
10655 converting to 'int'.
806add1d 10656
6511acf2 10657 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
10658 Check that an Emacs fixnum is in range before assigning it to 'int'.
10659 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
10660 values converted from Emacs fixnums.
10661 (Frecenter): Don't wrap around a line count if it is out of 'int'
10662 range; instead, treat it as an extreme value.
10663 (Fset_window_configuration, compare_window_configurations):
10664 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
10665
6511acf2
PE
10666 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
10667 that can exceed INT_MAX. Check that EMACS_INT value is in range
10668 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
10669 (match_limit): Don't assume that a fixnum can fit in 'int'.
10670
6511acf2 10671 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
10672 exceed INT_MAX.
10673
6511acf2 10674 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
10675 (Fvertical_motion): Don't wrap around LINES values that don't fit
10676 in 'int'. Instead, treat them as extreme values. This is good
10677 enough for windows, which can't have more than INT_MAX lines anyway.
10678
fcb901a7
LMI
106792011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10680
0f2f6b6d
LMI
10681 * Require libxml/parser.h to avoid compilation warning.
10682
fcb901a7
LMI
10683 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
10684
10685 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
10686 since this reportedly can destroy thread storage.
10687
6e20a0d4
CY
106882011-08-30 Chong Yidong <cyd@stupidchicken.com>
10689
10690 * syntax.c (find_defun_start): Update all cache variables if
10691 exiting early (Bug#9401).
10692
148ae00e
EZ
106932011-08-30 Eli Zaretskii <eliz@gnu.org>
10694
f6cfbd8f
EZ
10695 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
10696
148ae00e
EZ
10697 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
10698 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
10699 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
10700
10701 * term.c (tty_append_glyph): New function.
10702 (produce_stretch_glyph): Static function and its prototype deleted.
10703
a66cfb1c
SM
10704 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
10705 Add prototypes.
148ae00e 10706
c4a07a4c
PE
107072011-08-29 Paul Eggert <eggert@cs.ucla.edu>
10708
10709 * image.c (parse_image_spec): Check for nonnegative, not for positive,
10710 when checking :margin (Bug#9390).
10711 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 10712 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
10713 so that the name doesn't mislead. All uses changed.
10714
6bc8cd65
JB
107152011-08-28 Johan Bockgård <bojohan@gnu.org>
10716
10717 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
10718 set_tty_hooks.
10719
dca4927e
EZ
107202011-08-27 Eli Zaretskii <eliz@gnu.org>
10721
10722 * xdisp.c (move_it_to): Don't bail out early when reaching
10723 position beyond to_charpos, if we are scanning backwards.
10724 (move_it_vertically_backward): When DY == 0, make sure we get to
10725 the first character in the line after the newline.
10726
f2cad773
PE
107272011-08-27 Paul Eggert <eggert@cs.ucla.edu>
10728
10729 * ccl.c: Improve and simplify overflow checking (Bug#9196).
10730 (ccl_driver): Do not generate an out-of-range pointer.
10731 (Fccl_execute_on_string): Remove unnecessary check for
10732 integer overflow, noted by Stefan Monnier in
10733 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
10734 Remove a FIXME that didn't need fixing.
10735 Simplify the newly-introduced buffer reallocation code.
10736
0cae2cdb
JB
107372011-08-27 Juanma Barranquero <lekktu@gmail.com>
10738
10739 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
10740
5fc295a4 107412011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 10742
70c60eb2 10743 Integer and memory overflow issues (Bug#9196).
726e0ab1 10744
d31850da
PE
10745 * doc.c (get_doc_string): Rework so that
10746 get_doc_string_buffer_size is the actual buffer size, rather than
10747 being 1 less than the actual buffer size; this makes xpalloc more
10748 convenient.
10749
a69fbedb
PE
10750 * image.c (x_allocate_bitmap_record, cache_image):
10751 * xselect.c (Fx_register_dnd_atom):
10752 Simplify previous changes by using xpalloc.
10753
fe5c5d37
PE
10754 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
10755 since either will do and ptrdiff_t is convenient with xpalloc.
10756
0065d054
PE
10757 * charset.c (charset_table_size)
10758 (struct charset_sort_data.priority): Now ptrdiff_t.
10759 (charset_compare): Don't overflow if priorities differ greatly.
10760 (Fsort_charsets): Don't assume list length fits in int.
10761 Check for size-calculation overflow when allocating sort data.
10762 (syms_of_charset): Allocate an initial charset table that is
10763 just under 64 KiB, to avoid problems with glibc malloc and mmap.
10764
10765 * cmds.c (internal_self_insert): Check for size-calculation overflow.
10766
10767 * composite.h (struct composition.glyph_len): Now int, not unsigned.
10768 The actual value is always <= INT_MAX, and leaving it unsigned made
10769 overflow checking harder.
10770
10771 * dispextern.h (struct glyph_matrix.rows_allocated)
10772 (struct face_cache.size): Now ptrdiff_t, for convenience in use
10773 with xpalloc. The values are still always <= INT_MAX.
10774
10775 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
10776
10777 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
10778 (SAFE_NALLOCA): New macro.
10779
10780 * region-cache.c (struct boundary.pos, find_cache_boundary)
10781 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
10782 (set_cache_region, invalidate_region_cache)
10783 (revalidate_region_cache, know_region_cache, region_cache_forward)
10784 (region_cache_backward, pp_cache):
10785 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
10786 so that ptrdiff_t * can be passed to xpalloc.
10787 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
10788 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
10789 (pp_cache): Don't assume cache_len fits in int.
10790 * region-cache.h: Adjust extern decls to match.
10791
10792 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
10793 EMACS_INT, since either will do, for xpalloc.
10794
10795 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
10796 (xnmalloc, xnrealloc, xpalloc): New functions.
10797
726e0ab1
PE
10798 * bidi.c (bidi_shelve_header_size): New constant.
10799 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
10800 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
10801
51f30bc5 10802 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
10803 * buffer.c (overlays_at, overlays_in, record_overlay_string)
10804 (overlay_strings):
10805 Don't update size of array until after memory allocation succeeds,
10806 because xmalloc/xrealloc may not return.
0065d054
PE
10807 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
10808 now that we have proper integer overflow checking.
10809 (record_overlay_string, overlay_strings): Catch overflows when
10810 calculating size of overlay_str_buf.
726e0ab1 10811
0065d054
PE
10812 * callproc.c (Fcall_process): Check for size overflow when
10813 calculating size of args2.
10814 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
10815 Normally we prefer signed values, but sticking with ptrdiff_t would
10816 require adding more-complicated checks.
726e0ab1
PE
10817
10818 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
10819 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
10820 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 10821 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
10822
10823 * character.c (Fstring): Check for size-calculation overflow.
10824
10825 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
10826 unnecessary integer overflow. Check for size overflow.
10827 (encode_coding_object): Don't update size until xmalloc succeeds.
10828
10829 * composite.c (get_composition_id): Check for overflow in glyph
10830 length calculations.
10831
10832 Integer and memory overflow fixes for display code.
10833 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
10834 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
10835 (scrolling_window): Check for overflow in size calculations.
10836 (line_draw_cost, realloc_glyph_pool, add_row_entry):
10837 Don't assume glyph table len fits in int.
10838 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
10839 (row_table_size): Now ptrdiff_t, not int.
10840 (scrolling_window): Avoid overflow in size calculations.
10841 Don't update size until allocation succeeds.
10842 * fns.c (concat): Check for overflow in size calculations.
10843 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
10844 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
10845 (NEXT_ALMOST_PRIME_LIMIT): New constant.
10846
10847 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
10848 (get_doc_string): Check for size calculation overflow.
10849 Don't update size until allocation succeeds.
10850 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
10851 EMACS_INT, where ptrdiff_t will do.
10852 (Fsubstitute_command_keys): Check for string overflow.
10853
10854 * editfns.c (set_time_zone_rule): Don't assume environment length
10855 fits in int.
10856 (message_length): Now ptrdiff_t, not int.
10857 (Fmessage_box): Don't update size until allocation succeeds.
10858 Don't assume message length fits in int.
10859 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
10860
0065d054
PE
10861 * emacs.c (main): Do not reallocate argv, since there is a null at
10862 the end that can be overwritten, and this way there's no need to
10863 worry about size-calculation overflow.
10864 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
10865
10866 * eval.c (init_eval_once, grow_specpdl): Don't update size until
10867 alloc succeeds.
10868 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
10869
10870 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
10871 (x_set_scroll_bar_width, x_figure_window_size):
10872 Check for integer overflow.
10873 (x_set_alpha): Do not assume XINT fits in int.
10874
10875 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
10876 This is for the members text_lines, text_cols, total_lines, total_cols,
10877 where the system imposes an 'int' limit.
10878
10879 * fringe.c (Fdefine_fringe_bitmap):
10880 Don't update size until alloc works.
10881
10882 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
10883 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
10884
10885 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
10886 Check for size-calculation overflow.
10887 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
10888 do, as we prefer signed integers.
10889 (id_to_widget.max_size, id_to_widget.used)
10890 (xg_store_widget_in_map, xg_remove_widget_from_map)
10891 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
10892 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
10893 Use and return ptrdiff_t, not int.
10894 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
10895 * gtkutil.h: Change prototypes to match the above.
10896
10897 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
10898 are duplicate now that they've been promoted to lisp.h.
10899 (x_allocate_bitmap_record, x_alloc_image_color)
10900 (make_image_cache, cache_image, xpm_load):
10901 Don't update size until alloc is done.
10902 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
10903 (x_detect_edges):
3256efce 10904 Check for size calculation overflow.
726e0ab1
PE
10905 (ct_colors_allocated_max): New constant.
10906 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
10907 overflow.
3256efce 10908
726e0ab1
PE
10909 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
10910 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
10911 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
10912 Use ptrdiff_t, not int, to count maps.
10913 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
10914 calculations. Don't update size until allocation succeeds.
10915 Redo calculations to avoid overflow.
726e0ab1
PE
10916 * keyboard.h: Change prototypes to match the above.
10917
10918 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
10919 to count maps.
10920 (current_minor_maps): Check for size calculation overflow.
10921 * keymap.h: Change prototypes to match the above.
10922
10923 * lread.c (read1, init_obarray): Don't update size until alloc done.
10924
10925 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
10926 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
10927
726e0ab1
PE
10928 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
10929 Now ptrdiff_t, not int.
10930 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
10931 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
10932
10933 * process.c (Fnetwork_interface_list): Check for overflow
10934 in size calculation.
10935
10936 * region-cache.c (move_cache_gap): Check for size calculation overflow.
10937
10938 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
10939 overflow. Don't bother calling xmalloc when xrealloc will do.
10940
10941 * search.c (Freplace_match): Check for size calculation overflow.
10942 (Fset_match_data): Don't assume list lengths fit in 'int'.
10943
10944 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
10945 for command line length. Do not attempt to address one before the
10946 beginning of an array, as that's not portable.
10947
10948 * term.c (max_frame_lines): Remove; unused.
10949 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
10950 not int.
10951 (encode_terminal_code, calculate_costs): Check for size
10952 calculation overflow.
10953 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
10954 table lengths and related sizes. Don't update size until alloc
10955 done. Redo calculations to avoid overflow.
10956 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
10957
10958 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
10959 subtracting pointers.
10960 (gobble_line): Check for overflow more carefully. Don't update size
10961 until alloc done.
10962
10963 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
10964 Don't update size until alloc done.
10965 Redo size calculations to avoid overflow.
10966 Check for size calculation overflow.
0065d054 10967 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
10968
10969 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
10970 Use ptrdiff_t, not int, for sizes.
10971 (store_mode_line_noprop_char): Don't update size until alloc done.
10972
0065d054
PE
10973 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
10974 Use ptrdiff_t, not int, for sizes.
10975 (Finternal_make_lisp_face, cache_face):
10976 Check for size calculation overflow.
10977 (cache_face): Treat size calculation overflows as if they were
10978 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
10979
10980 * xfns.c (x_encode_text, x_set_name_internal)
10981 (Fx_change_window_property): Use ptrdiff_t, not int, to count
10982 sizes, since they can exceed INT_MAX in size. Check for size
10983 calculation overflow.
10984
0065d054
PE
10985 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
10986 (xg_select): Check for size calculation overflow.
726e0ab1
PE
10987 Don't update size until alloc done.
10988
0065d054 10989 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 10990 as sprintf is limited to int lengths.
1d526e2f 10991
252c5ee1
PE
10992 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
10993 (X_LONG_MIN): New macros.
864d7ce7
PE
10994 Use them to make the following changes clearer.
10995 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
10996 This change doesn't affect the value now, but it may help remind
10997 future maintainers not to raise the value too much later.
10998 (SELECTION_QUANTUM): Remove, replacing with ...
10999 (selection_quantum): ... new function, which avoids overflow.
11000 All uses changed.
11001 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
11002 assumption that selection length fits in 'int'.
11003 (x_reply_selection_request, x_handle_selection_request)
11004 (x_get_window_property, receive_incremental_selection)
11005 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
11006 (lisp_data_to_selection_data, clean_local_selection_data):
11007 Use ptrdiff_t, not int, to record length of selection.
11008 (x_reply_selection_request, x_get_window_property)
11009 (receive_incremental_selection, x_property_data_to_lisp):
11010 Redo calculations to avoid overflow.
11011 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 11012 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
11013 something.
11014 (x_get_window_property, receive_incremental_selection)
11015 (lisp_data_to_selection_data, x_property_data_to_lisp):
11016 Check for size-calculation overflow.
11017 (x_get_window_property, receive_incremental_selection)
11018 (lisp_data_to_selection_data, Fx_register_dnd_atom):
11019 Don't store size until memory allocation succeeds.
11020 (x_get_window_property): Plug memory leak on memory exhaustion.
11021 Don't double-block input; malloc is safe here. Don't assume 2**34
11022 - 4 fits in unsigned long. Add an xassert to check
11023 XGetWindowProperty overflow. Be more careful about overflow
11024 calculations, and distinguish size from memory overflow better.
11025 (receive_incremental_selection): When tracing, don't assume
11026 unsigned int is less than INT_MAX.
11027 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
11028 harmful) conversions of unsigned short to int.
11029 (lisp_data_to_selection_data): Don't assume that integers
11030 in the range -65535 through -1 fit in an X unsigned short.
11031 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
11032 result parameters unless successful. Rely on cons_to_unsigned
11033 to report problems with elements; the old code wasn't right anyway.
11034 (x_check_property_data): Check for int overflow; we cannot use
11035 a wider type due to X limits.
11036 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
11037
726e0ab1 11038 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 11039
0065d054
PE
11040 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
11041 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
11042 (x_color_cells): Don't store size until memory allocation succeeds.
11043 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 11044 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
11045 (x_term_init): Don't assume length fits in int (sprintf is limited
11046 to int size).
bc18e09d 11047
ebfa62c0
PE
11048 Use ptrdiff_t for composition IDs.
11049 * character.c (lisp_string_width):
11050 * composite.c (composition_table_size, n_compositions)
11051 (get_composition_id, composition_gstring_from_id):
11052 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
11053 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
11054 * window.c (Frecenter):
11055 Use ptrdiff_t, not int, for composition IDs.
11056 * composite.c (get_composition_id): Check for integer overflow.
11057 * composite.h: Adjust prototypes to match the above changes.
11058
d3411f89
PE
11059 Use ptrdiff_t for hash table indexes.
11060 * category.c (hash_get_category_set):
11061 * ccl.c (ccl_driver):
11062 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
11063 * coding.c (coding_system_charset_list, detect_coding_system):
11064 * coding.h (struct coding_system.id):
11065 * composite.c (get_composition_id, gstring_lookup_cache):
11066 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
11067 * image.c (xpm_get_color_table_h):
11068 * lisp.h (hash_lookup, hash_put):
11069 * minibuf.c (Ftest_completion):
11070 Use ptrdiff_t for hash table indexes, not int (which is too
11071 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
11072 32-bit --with-wide-int hosts).
11073
e097a6fa
PE
11074 * charset.c (Fdefine_charset_internal): Check for integer overflow.
11075 Add a FIXME comment about memory leaks.
11076 (syms_of_charset): Don't assume xmalloc returns.
11077
5637687f
PE
11078 Don't assume that stated character widths fit in int.
11079 * character.c (Fchar_width, c_string_width, lisp_string_width):
11080 * character.h (CHAR_WIDTH):
11081 * indent.c (MULTIBYTE_BYTES_WIDTH):
11082 Use sanitize_char_width to avoid undefined and/or bad behavior
11083 with outlandish widths.
a66cfb1c 11084 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
11085 now that we have two such functions. All uses changed.
11086 (sanitize_char_width): New inline function.
11087
a2271ba2
PE
11088 Don't assume that tab-width fits in int.
11089 * character.h (sanitize_width): New inline function.
11090 (SANE_TAB_WIDTH): New macro.
11091 (ASCII_CHAR_WIDTH): Use it.
11092 * indent.c (sane_tab_width): Remove. All uses replaced by
11093 SANE_TAB_WIDTH (current_buffer).
11094 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
11095
18c52557
PE
11096 * fileio.c: Integer overflow issues with file modes.
11097 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
11098
caeeedc1
PE
11099 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
11100 Remove unreachable code.
11101 (read_hex, load_charset_map_from_file): Check for integer overflow.
11102
6df6ae42 11103 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
11104 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
11105 (x_send_scroll_bar_event): Likewise. Check that the size does not
11106 exceed limits imposed by XClientMessageEvent, as well as the usual
11107 ptrdiff_t and size_t limits.
11108
b13995db
PE
11109 * keyboard.c: Overflow, signedness and related fixes.
11110 (make_lispy_movement): Use same integer type in forward decl
11111 that is used in the definition.
11112 (read_key_sequence, keyremap_step):
11113 Change bufsize argument back to int, undoing my 2011-03-30 change.
11114 We prefer signed types, and int is wide enough here.
11115 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
11116 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
11117 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
11118 length, not size_t. Use ptrdiff_t for index, not int.
11119 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
11120 possibility of integer overflow.
11121
13464394
PE
11122 Overflow, signedness and related fixes for images.
11123
11124 * dispextern.h (struct it.stack[0].u.image.image_id)
11125 (struct_it.image_id, struct image.id, struct image_cache.size)
11126 (struct image_cache.used, struct image_cache.ref_count):
11127 * gtkutil.c (update_frame_tool_bar):
11128 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
11129 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
11130 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
11131 * nsmenu.m (update_frame_tool_bar):
11132 * xdisp.c (calc_pixel_width_or_height):
11133 * xfns.c (image_cache_refcount):
11134 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
11135 on typical 64-bit hosts.
11136
11137 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11138 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
11139 Omit unnecessary casts to int.
11140 (parse_image_spec): Check that integers fall into 'int' range
11141 when the callers expect that.
11142 (image_ascent): Redo ascent calculation to avoid int overflow.
11143 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
11144 (lookup_image): Remove unnecessary tests.
11145 (xbm_image_p): Locals are now of int, not EMACS_INT,
11146 since parse_image_check makes sure they fit into int.
11147 (png_load, gif_load, svg_load_image):
11148 Prefer int to unsigned where either will do.
11149 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
11150 old tiff_error_handler and tiff_warning_handler.
11151 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
11152 stack buffer overflows. It uses only the features of vsnprintf
11153 that are common to both POSIX and native Microsoft.
11154 (tiff_error_handler, tiff_warning_handler): Use it.
11155 (tiff_load, gif_load, imagemagick_load_image):
11156 Don't assume :index value fits in 'int'.
11157 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
11158 (imagemagick_load_image): Check that crop parameters fit into
11159 the integer types that MagickCropImage accepts. Don't assume
11160 Vimagemagick_render_type has a nonnegative value. Don't assume
11161 size_t fits in 'long'.
11162 (gs_load): Use printmax_t to print the widest integers possible.
11163 Check for integer overflow when computing image height and width.
11164
c11821d4
EZ
111652011-08-26 Eli Zaretskii <eliz@gnu.org>
11166
11167 * xdisp.c (redisplay_window): Don't force window start if point
11168 will be invisible in the resulting window. (Bug#9324)
11169
0c95fcf7
EZ
111702011-08-25 Eli Zaretskii <eliz@gnu.org>
11171
11172 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
11173 the display spec is of the form `(space ...)'.
11174 (handle_display_spec): Return the value returned by
11175 handle_single_display_spec, not just 1 or zero.
11176 (handle_single_display_spec): If the display spec is of the form
11177 `(space ...)', and specifies display in the text area, return 2
11178 rather than 1.
fee65a97 11179 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
11180 accurately, and prefer exact match for point under bidi.
11181 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
11182
11183 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
11184 into disp_prop; all users changed.
11185
11186 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
11187 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
11188 for the text covered by the display property.
11189
e4ed06f1
CY
111902011-08-25 Chong Yidong <cyd@stupidchicken.com>
11191
11192 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
11193 Change return value to nil.
11194 (Frecord_buffer): Delete unused function.
11195
f67cdd7f
EZ
111962011-08-24 Eli Zaretskii <eliz@gnu.org>
11197
5980d4c6
EZ
11198 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
11199 buffers, return left-to-right.
8610fe8b
EZ
11200 (set_cursor_from_row): Consider candidate row a win if its glyph
11201 represents a newline and point is on that newline. Fixes cursor
11202 positioning on the newline at EOL of R2L text within L2R
11203 paragraph, and vice versa.
11204 (try_cursor_movement): Check continued rows, in addition to
11205 continuation rows. Fixes unwarranted scroll when point enters a
11206 continued line of R2L text within an L2R paragraph, or vice versa.
11207 (cursor_row_p): Consider the case of point being equal to
11208 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
11209 from the end of a short line to the beginning of a continued line
11210 of R2L text within L2R paragraph.
11211 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
11212 composed characters.
5980d4c6 11213
f67cdd7f
EZ
11214 * bidi.c (bidi_check_type): Use xassert.
11215 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
11216 members.
11217
bca633fb
EZ
112182011-08-23 Eli Zaretskii <eliz@gnu.org>
11219
11220 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
11221 a character.
11222
4a5885a7
CY
112232011-08-23 Chong Yidong <cyd@stupidchicken.com>
11224
11225 * nsfont.m (ns_otf_to_script): Fix typo.
11226
0902a04e
KH
112272011-08-22 Kenichi Handa <handa@m17n.org>
11228
11229 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
11230 extra slot even if the purpose is char-code-property-table.
11231
1a2e6670
EZ
112322011-08-23 Eli Zaretskii <eliz@gnu.org>
11233
8ddde651
EZ
11234 * xdisp.c (redisplay_window): When computing centering_position,
11235 account for the height of the header line. (Bug#8874)
11236
425cc014
EZ
11237 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
11238 instead of CHAR_TO_BYTE. Fixes a crash when a completion
11239 candidate is selected by the mouse, and that candidate has a
11240 composed character under the mouse.
11241
1a2e6670
EZ
11242 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
11243 coordinates reported by pos-visible-in-window-p for a composed
11244 character in column zero.
11245
8b76d6f8
SM
112462011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
11247
11248 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
11249
dac347dd
EZ
112502011-08-22 Eli Zaretskii <eliz@gnu.org>
11251
11252 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
11253 consider it a hit if to_charpos is anywhere in the range of the
11254 composed buffer positions.
11255
e013fb34
CY
112562011-08-22 Chong Yidong <cyd@stupidchicken.com>
11257
11258 * image.c (gif_load): Don't assume that each subimage has the same
11259 dimensions as the base image. Handle disposal method that is
11260 "undefined" by the gif spec (Bug#9335).
11261
bd1ba3e8
CY
112622011-08-20 Chong Yidong <cyd@stupidchicken.com>
11263
11264 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 11265 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 11266
54a1215b
EZ
112672011-08-19 Eli Zaretskii <eliz@gnu.org>
11268
823564e5
EZ
11269 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
11270 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
11271 from an Org mode buffer to a Speedbar frame.
11272
54a1215b
EZ
11273 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
11274 a composition, take its buffer position from IT->cmp_it.charpos.
11275 Fixes cursor positioning at the beginning of a line that begins
11276 with a composed character.
11277
9778ebcc
EZ
112782011-08-18 Eli Zaretskii <eliz@gnu.org>
11279
0be6ee06
EZ
11280 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
11281 character bidirectional type, use STRONG_L instead. Fixes crashes
11282 in a buffer produced by `describe-categories'.
11283
9778ebcc
EZ
11284 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
11285 members before the level stack, so they would be saved and
11286 restored when copying iterator state. Fixes incorrect reordering
11287 around TABs covered by display properties.
11288
156bffbe
AS
112892011-08-18 Andreas Schwab <schwab@linux-m68k.org>
11290
6b02f655 11291 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 11292
72ad093b
CY
112932011-08-17 Chong Yidong <cyd@stupidchicken.com>
11294
11295 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
11296 (internal_condition_case_2, internal_condition_case_n):
11297 Remove unnecessary aborts (Bug#9081).
72ad093b 11298
35774242
EZ
112992011-08-17 Eli Zaretskii <eliz@gnu.org>
11300
11301 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
11302 has no `load' handler, try opening the file locally. (Bug#9311)
11303
db76dd85
KB
113042011-08-16 Ken Brown <kbrown@cornell.edu>
11305
11306 * gmalloc.c: Expand comment.
11307
b215eee5
EZ
113082011-08-16 Eli Zaretskii <eliz@gnu.org>
11309
11310 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
11311 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
11312
a4579d33
KB
113132011-08-16 Ken Brown <kbrown@cornell.edu>
11314
11315 Fix memory allocation problems in Cygwin build (Bug#9273).
11316
11317 * unexcw.c ( __malloc_initialized): Declare external variable.
11318 (fixup_executable): Force the dumped emacs to reinitialize malloc.
11319
8b76d6f8
SM
11320 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
11321 New variables.
a4579d33
KB
11322 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
11323 dumped emacs.
11324 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
11325 in the static heap.
11326 [CYGWIN] (special_realloc): New function.
11327 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
11328 requests to realloc storage in the static heap.
11329
3ebec551
PE
113302011-08-15 Paul Eggert <eggert@cs.ucla.edu>
11331
11332 * bidi.c (bidi_initialize): Remove unused local.
11333
9fd8be00
EZ
113342011-08-15 Eli Zaretskii <eliz@gnu.org>
11335
6b02f655
SM
11336 * bidimirror.h:
11337 * biditype.h: Remove file.
11338 * makefile.w32-in ($(BLD)/bidi.$(O)):
11339 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
11340
11341 * dispextern.h: Fix a typo in the comment to bidi_type_t.
11342
11343 * chartab.c: Improve commentary for the uniprop_table API.
11344
32413314
EZ
11345 * bidi.c (bidi_paragraph_init): Support zero value of
11346 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
11347 (bidi_initialize): Use uniprop_table instead of including
11348 biditype.h and bidimirror.h.
32413314 11349
9fd8be00
EZ
11350 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
11351 coordinates of the iterator when restoring from ppos_it.
11352 (Bug#9296)
11353
5cf2b69b
KH
113542011-08-14 Kenichi Handa <handa@m17n.org>
11355
11356 * process.c (create_process): Call setup_process_coding_systems
72ad093b 11357 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 11358
daf17d00
EZ
113592011-08-14 Eli Zaretskii <eliz@gnu.org>
11360
11361 * xdisp.c (move_it_in_display_line_to): Don't invoke
11362 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
11363 ppos_it. Fixes vertical cursor motion when line beginning is
11364 covered by an image. (Bug#9296)
11365
08e3161a
JD
113662011-08-14 Jan Djärv <jan.h.d@swipnet.se>
11367
11368 * nsterm.h (ns_run_ascript): Declare.
11369 (NSAPP_DATA2_RUNASSCRIPT): Define.
11370
11371 * nsfns.m (as_script, as_result, as_status): New static variables.
11372 (ns_run_ascript): New function.
5e617bc2 11373 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
11374 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
11375 the event loop. Get status from as_status (Bug#7276).
11376
11377 * nsterm.m (sendEvent): If event is NSApplicationDefined and
11378 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
11379 the event loop (Bug#7276).
11380
a3720aa2
AS
113812011-08-14 Andreas Schwab <schwab@linux-m68k.org>
11382
11383 * gnutls.c (QCgnutls_bootprop_priority)
11384 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
11385 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
11386 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
11387 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
11388 (QCgnutls_bootprop_verify_hostname_error)
11389 (QCgnutls_bootprop_callbacks_verify): Rename from
11390 Qgnutls_bootprop_..., all uses changed.
11391
11392 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
11393 uses changed.
11394
0a0d27fb
PE
113952011-08-14 Paul Eggert <eggert@cs.ucla.edu>
11396
19d5c50c
PE
11397 * xfaces.c (Qframe_set_background_mode): Now static.
11398 * dispextern.h (Qframe_set_background_mode): Remove decl.
11399
0a0d27fb
PE
11400 * process.c (Fnetwork_interface_info): Declare local only if needed.
11401
377538cb
JD
114022011-08-13 Jan Djärv <jan.h.d@swipnet.se>
11403
11404 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
11405 (Fnetwork_interface_list): Allocate in increments of bytes instead
11406 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
11407 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
11408 sockaddr.
11409 (struct ifflag_def): notrailers is smart on OSX.
11410 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
11411 Get hardware address with getifaddrs if available.
11412
08fff70c
EZ
114132011-08-12 Eli Zaretskii <eliz@gnu.org>
11414
11415 * xdisp.c (iterate_out_of_display_property): xassert that
11416 IT->position is set to within IT->object's boundaries. Break from
11417 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
11418 when IT->position is set up wrongly due to some bug.
11419 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
11420 (push_display_prop): Allow GET_FROM_STRING as IT->method on
11421 entry. Force push_it to save on the stack the current
11422 buffer/string position, to be restored by pop_it. Fix flags in
11423 the iterator structure wrt the object coming from a display
11424 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
11425 properties. (Bug#9284)
11426
7be1c708 114272011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 11428
7be1c708
CY
11429 * fontset.c (fontset_get_font_group): Add proper type checks.
11430 (Bug#9172)
aac0c6e3 11431
7be1c708 114322011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 11433
7be1c708
CY
11434 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
11435 and LC_VERSION_MIN_MACOSX.
11436 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
11437 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 11438
97bb72a6
EZ
114392011-08-08 Eli Zaretskii <eliz@gnu.org>
11440
11441 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
11442 no-display-properties-and-no-overlays under bidi display.
11443 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 11444 properties and overlays.
97bb72a6 11445
d5617611
CY
114462011-08-08 Chong Yidong <cyd@stupidchicken.com>
11447
37e11a63
CY
11448 * editfns.c (Fset_time_zone_rule): Document relationship with the
11449 setenv function.
11450
d5617611
CY
11451 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
11452 the font entity extracted from the cache (Bug#8109).
11453
58872834
CY
114542011-08-07 Chong Yidong <cyd@stupidchicken.com>
11455
11456 * composite.c (autocmp_chars): Don't reset point. That is done by
11457 restore_point_unwind (Bug#5984).
11458
75bfc667
JL
114592011-08-07 Juri Linkov <juri@jurta.org>
11460
11461 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
11462 to show the arg `TIME' instead of `TIMEVAL'.
11463
d1410150
EZ
114642011-08-06 Eli Zaretskii <eliz@gnu.org>
11465
11466 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
11467 display property strides EOL and includes a newline, as in
11468 longlines-mode. (Bug#9254)
75b771e4
EZ
11469 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
11470 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
11471
11472 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
11473 is non-zero, even if the data buffer is NULL. Fixes a crash in
11474 vertical-motion with longlines-mode. (Bug#9254)
11475
35928349
EZ
114762011-08-05 Eli Zaretskii <eliz@gnu.org>
11477
ec7cc85b
EZ
11478 * bidi.c <bidi_cache_total_alloc>: Now static.
11479 (bidi_initialize): Initialize bidi_cache_total_alloc.
11480
8b76d6f8 11481 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
11482 cache. (Bug#9221)
11483
11484 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
11485 amount allocated this far in `bidi_cache_total_alloc'.
11486 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
11487 non-zero, only free the data buffer without restoring the cache
11488 contents. All callers changed.
11489
11490 * dispextern.h (bidi_unshelve_cache): Update prototype.
11491
11492 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
11493 (move_it_in_display_line, move_it_to)
11494 (move_it_vertically_backward, move_it_by_lines): Replace the call
11495 to xfree to an equivalent call to bidi_unshelve_cache.
11496 (move_it_in_display_line_to): Fix logic of returning
412b6358 11497 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 11498
e2e2423b
EZ
114992011-08-05 Eli Zaretskii <eliz@gnu.org>
11500
11501 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
11502 came from a string character with a `cursor' property. (Bug#9229)
11503
ae9e757a
JD
115042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
11505
11506 * Makefile.in (LIB_PTHREAD): New variable.
11507 (LIBES): Add LIB_PTHREAD (Bug#9216).
11508
11509 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
11510 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
11511
213bd7f2
AS
115122011-08-04 Andreas Schwab <schwab@linux-m68k.org>
11513
6b02f655 11514 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 11515
99aaf75f
JD
115162011-08-04 Jan Djärv <jan.h.d@swipnet.se>
11517
11518 * xterm.c (x_find_topmost_parent): New function.
11519 (x_set_frame_alpha): Find topmost parent window with
11520 x_find_topmost_parent and set the property there also (bug#9181).
11521 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
11522
c74e9d86
PE
115232011-08-04 Paul Eggert <eggert@cs.ucla.edu>
11524
11525 * callproc.c (Fcall_process): Avoid vfork clobbering
11526 the local vars buffer, coding_systems, current_dir.
11527
640c8776
SM
115282011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
11529
11530 * keymap.c (Fmake_composed_keymap): Move to subr.el.
11531
f26d0e4c
PE
115322011-08-03 Paul Eggert <eggert@cs.ucla.edu>
11533
8a10d76c
PE
11534 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
11535 so that it is not optimized away.
11536
f26d0e4c
PE
11537 * xdisp.c (compute_display_string_pos): Remove unused local.
11538
55439c61
EZ
115392011-08-02 Eli Zaretskii <eliz@gnu.org>
11540
11541 Fix slow cursor motion and scrolling in large buffers with
11542 selective display, like Org Mode buffers. (Bug#9218)
11543
11544 * dispextern.h (struct bidi_it): New member disp_prop_p.
11545
11546 * xdisp.c: Remove one-slot cache of display string positions.
11547 (compute_display_string_pos): Accept an additional argument
5e617bc2 11548 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
11549 for a display string or property. If found, set DISP_PROP_P
11550 non-zero.
11551
11552 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
11553 DISP_PROP_P, and pass it to compute_display_string_pos.
11554 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
11555 non-zero. All callers of bidi_fetch_char changed.
11556
fb33fa43
SM
115572011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
11558
11559 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
11560
b099e063
DM
115612010-12-03 Don March <don@ohspite.net>
11562
11563 * keymap.c (Fdefine_key): Fix non-prefix key error message when
11564 last character M-[char] is translated to ESC [char] (bug#7541).
11565
5cc7f7af
KH
115662011-08-02 Kenichi Handa <handa@m17n.org>
11567
d0fffa3f 11568 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
11569
11570 * chartab.c (uniprop_table): Make it non-static.
11571
525d5e6e
EZ
115722011-08-01 Eli Zaretskii <eliz@gnu.org>
11573
11574 * xdisp.c (forward_to_next_line_start): Accept additional argument
11575 BIDI_IT_PREV, and store into it the state of the bidi iterator had
11576 on the newline.
11577 (reseat_at_next_visible_line_start): Use the bidi iterator state
11578 returned by forward_to_next_line_start to restore the state of
11579 it->bidi_it after backing up to previous newline. (Bug#9212)
11580
31011111
AS
115812011-07-30 Andreas Schwab <schwab@linux-m68k.org>
11582
11583 * regex.c (re_comp): Protoize.
11584 (re_exec): Fix return type.
11585 (regexec): Fix type of `ret'. (Bug#9203)
11586
476371c4
PE
115872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11588
e5d76069
PE
11589 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
11590 This is needed if max-image-size is a floating-point number.
11591
9a79b20c
AS
115922011-07-28 Andreas Schwab <schwab@linux-m68k.org>
11593
11594 * print.c (print_object): Print empty symbol as ##.
11595
11596 * lread.c (read1): Read ## as empty symbol.
11597
d8c2fa78
AA
115982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
11599
11600 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
11601 setting frame foreground color (Bug#9175).
11602 (x_set_background_color): Likewise.
11603
ffe57a7a
AA
11604 * nsmenu.m (-setText): Size tooltip dimensions precisely to
11605 contents (Bug#9176).
11606 (EmacsTooltip -init): Remove bezels and add shadows to
11607 tooltip windows.
11608
bf3492a5
AA
11609 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
11610 or scroll bar (Bug#8470).
11611
d55e9c53
AA
11612 * nsfont.m (nsfont_open): Remove assignment to voffset and
11613 unnecessary vars hshink, expand, hd, full_height, min_height.
11614 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
11615
11616 * nsterm.h (nsfont_info): Remove voffset field.
11617
d8c2fa78 116182011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
11619
11620 Implement strike-through and overline on NextStep (Bug#8863).
11621
11622 * nsfont.m (nsfont_open): Use underline position provided by font,
11623 instead of hard-coded value of 2.
11624 (nsfont_draw): Call ns_draw_text_decoration instead.
11625
11626 * nsterm.h: Add declaration for ns_draw_text_decoration.
11627
11628 * nsterm.m (ns_draw_text_decoration): New function for drawing
11629 underline, overline, and strike-through.
11630 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
11631 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 11632 accommodate underlining, etc.
4843aac3 11633
4cc60b9b
EZ
116342011-07-28 Eli Zaretskii <eliz@gnu.org>
11635
bc7ece87
EZ
11636 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
11637 default.
4cc60b9b 11638
476371c4
PE
116392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11640
66606eea
PE
11641 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
11642 Without this fix, if a signal arrives just after memory fills up,
11643 'malloc' might be invoked reentrantly.
11644
476371c4
PE
11645 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
11646 In other words, assume that every image size is allowed, on non-X
11647 hosts. This assumption is probably wrong, but it lets Emacs compile.
11648
f3fcc40d
AS
116492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
11650
11651 * regex.c (re_iswctype): Convert return values to boolean.
11652
350c992f
EZ
116532011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
11654
11655 * xdisp.c (compute_display_string_pos): Don't use cached display
11656 string position if the buffer had its restriction changed.
11657 (Bug#9184)
11658
5266b4bb
PE
116592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11660
11661 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11662
2573a837 116632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 11664
41f55ccd 11665 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 11666
39e378da
PE
11667 * bidi.c: Integer size and overflow fixes.
11668 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
11669 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
11670 (bidi_cache_find_level_change, bidi_cache_ensure_space)
11671 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
11672 (bidi_find_other_level_edge):
11673 Use ptrdiff_t instead of EMACS_INT where either will do.
11674 This works better on 32-bit hosts configured --with-wide-int.
11675 (bidi_cache_ensure_space): Check for size-calculation overflow.
11676 Use % rather than repeated addition, for better worst-case speed.
11677 Don't set bidi_cache_size until after xrealloc returns, because it
11678 might not return.
11679 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
11680 (bidi_cache_ensure_space): Also check that the bidi cache size
11681 does not exceed that of the largest Lisp string or buffer. See Eli
11682 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 11683
5e927815
PE
11684 * alloc.c (__malloc_size_t): Remove.
11685 All uses replaced by size_t. See Andreas Schwab's note
11686 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
11687
ca4aa935
PE
11688 * image.c: Improve checking for integer overflow.
11689 (check_image_size): Assume that f is nonnull, since
11690 it is always nonnull in practice. This is one less thing to
11691 worry about when checking for integer overflow later.
11692 (x_check_image_size): New function, which checks for integer
11693 overflow issues inside X.
11694 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
11695 This removes the need for a memory_full check.
11696 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
11697 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
11698 (xbm_read_bitmap_data): Change locals back to 'int', since
11699 their values must fit in 'int'.
11700 (xpm_load_image, png_load, tiff_load):
11701 Invoke x_create_x_image_and_pixmap earlier,
11702 to avoid much needless work if the image is too large.
11703 (tiff_load): Treat overly large images as if
11704 x_create_x_image_and_pixmap failed, not as malloc failures.
11705 (gs_load): Use x_check_image_size.
11706
5f8f9cc2
PE
11707 * gtkutil.c: Omit integer casts.
11708 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
11709 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
11710
5adf60bc
PE
11711 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
11712
c8907a93
PE
11713 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
11714 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
11715 would wrongly return t on a 64-bit host.
11716
e3c25c68
PE
11717 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
11718 The plain *_OVERFLOW macros run afoul of GCC bug 49705
11719 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
11720 and therefore cause GCC to emit a bogus diagnostic in some cases.
11721
3f791afe
PE
11722 * image.c: Integer signedness and overflow and related fixes.
11723 This is not an exhaustive set of fixes, but it's time to
11724 record what I've got.
11725 (lookup_pixel_color, check_image_size): Remove redundant decls.
11726 (check_image_size): Don't assume that arbitrary EMACS_INT values
11727 fit in 'int', or that arbitrary 'double' values fit in 'int'.
11728 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
11729 (tiff_load, imagemagick_load_image):
11730 Check for overflow in size calculations.
11731 (x_create_x_image_and_pixmap): Remove unnecessary test for
11732 xmalloc returning NULL; that can't happen.
11733 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
11734 (xpm_color_bucket): Use better integer hashing function.
11735 (xpm_cache_color): Don't possibly over-allocate memory.
11736 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
11737 (gif_memory_source):
11738 Use ptrdiff_t, not int or size_t, to record sizes.
11739 (png_load): Don't assume values greater than 2**31 fit in 'int'.
11740 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
11741 either works, as we prefer signed integers.
11742 (tiff_read_from_memory, tiff_write_from_memory):
11743 Return tsize_t, not size_t, since that's what the TIFF API wants.
11744 (tiff_read_from_memory): Don't fail simply because the read would
11745 go past EOF; instead, return a short read.
11746 (tiff_load): Omit no-longer-needed casts.
11747 (Fimagemagick_types): Don't assume size fits into 'int'.
11748
3cc5a532
PE
11749 Improve hashing quality when configured --with-wide-int.
11750 * fns.c (hash_string): New function, taken from sxhash_string.
11751 Do not discard information about ASCII character case; this
11752 discarding is no longer needed.
11753 (sxhash-string): Use it. Change sig to match it. Caller changed.
11754 * lisp.h: Declare it.
11755 * lread.c (hash_string): Remove, since we now use fns.c's version.
11756 The fns.c version returns a wider integer if --with-wide-int is
11757 specified, so this should help the quality of the hashing a bit.
11758
b312a492
PE
11759 * emacs.c: Integer overflow minor fix.
11760 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
11761 Define only if GNU_LINUX.
11762 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
11763
dfd153ae
PE
11764 * dispnew.c: Integer signedness and overflow fixes.
11765 Remove unnecessary forward decls, that were a maintenance hassle.
11766 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
11767 All uses changed.
11768 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
11769 (scrolling_window): Use ptrdiff_t, not int, for byte count.
11770 (prepare_desired_row, line_draw_cost):
11771 Use int, not unsigned, where either works.
11772 (save_current_matrix, restore_current_matrix):
11773 Use ptrdiff_t, not size_t, where either works.
11774 (init_display): Check for overflow more accurately, and without
11775 relying on undefined behavior.
11776
a81d11a3
PE
11777 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
11778 Remove, replacing with the new symbols in lisp.h. All uses changed.
11779 * fileio.c (make_temp_name):
11780 * filelock.c (lock_file_1, lock_file):
11781 * xdisp.c (message_dolog):
11782 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
11783 Use pMd etc. instead.
11784 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
11785 replacing the pWIDE etc. symbols removed from editfns.c.
11786
3300e6fd
PE
11787 * keyboard.h (num_input_events): Now uintmax_t.
11788 This is (very slightly) less likely to mess up due to wraparound.
11789 All uses changed.
11790
fd05c7e9
PE
11791 * buffer.c: Integer signedness fixes.
11792 (alloc_buffer_text, enlarge_buffer_text):
11793 Use ptrdiff_t rather than size_t when either will do, as we prefer
11794 signed integers.
11795
903fe15d
PE
11796 * alloc.c: Integer signedness and overflow fixes.
11797 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
11798 (__malloc_size_t): Default to size_t, not to int.
11799 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
11800 (Fgarbage_collect, mark_object_loop_halt, mark_object):
11801 Prefer ptrdiff_t to size_t when either would do, as we prefer
11802 signed integers.
11803 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
11804 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
11805 Now const. Initialize with values that are in range even if char
11806 is signed.
11807 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
11808 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
11809 These functions do the right thing with sizes > 2**32.
11810 (check_depth): Now ptrdiff_t, not int.
11811 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
11812 Adjust to new way of storing sizes. Check for size overflow bugs
11813 in rest of code.
11814 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
11815 slightly wrong anyway, as it missed one instance of
11816 XMALLOC_OVERRUN_CHECK_OVERHEAD.
11817 (refill_memory_reserve): Omit needless cast to size_t.
11818 (mark_object_loop_halt): Mark as externally visible.
11819
ac82cc6a
PE
11820 * xselect.c: Integer signedness and overflow fixes.
11821 (Fx_register_dnd_atom, x_handle_dnd_message):
11822 Use ptrdiff_t, not size_t, since we prefer signed.
11823 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
11824 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
11825 x_dnd_atoms_size and x_dnd_atoms_length.
11826
c2d1e36d
PE
11827 * doprnt.c: Prefer signed to unsigned when either works.
11828 * eval.c (verror):
11829 * doprnt.c (doprnt):
11830 * lisp.h (doprnt):
11831 * xdisp.c (vmessage):
11832 Use ptrdiff_t, not size_t, when using or implementing doprnt,
11833 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
11834 prefer signed arithmetic to avoid comparison confusion.
11835 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
11836 but is a bit tricky.
11837
0e926e56
PE
11838 Assume freestanding C89 headers, string.h, stdlib.h.
11839 * data.c, doprnt.c, floatfns.c, print.c:
11840 Include float.h unconditionally.
11841 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
11842 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
11843 * regex.c: Likewise for stddef.h, string.h.
11844 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
11845 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
11846 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
11847 (STDC_HEADERS): Remove obsolete defines.
11848 * sysdep.c: Include limits.h unconditionally.
11849
9cfdb3ec
PE
11850 Assume support for memcmp, memcpy, memmove, memset.
11851 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
11852 * regex.c (memcmp, memcpy):
11853 Remove; we assume C89 now.
11854
11855 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
11856 (__malloc_safe_bcopy): Remove; no longer needed.
11857
cf950e6b 11858 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
11859 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
11860 well either way, and we prefer signed to unsigned.
11861
dbf38e02
LMI
118622011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
11863
11864 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
11865 closes the connection while we're reading (bug#9182).
11866
d6f0886c 118672011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 11868
d6f0886c
JD
11869 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
11870 are specified (Bug#9168).
24e0f6b1 11871
2eb1f9e6
PE
118722011-07-25 Paul Eggert <eggert@cs.ucla.edu>
11873
11874 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
11875 Found by GCC static checking and --with-wide-int on a 32-bit host.
11876
22381272 118772011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
11878
11879 * xdisp.c (compute_display_string_pos): Fix logic of caching
11880 previous display string position. Initialize cached_prev_pos to
11881 -1. Fixes slow-down at the beginning of a buffer.
11882
f25e39b4
EZ
118832011-07-24 Eli Zaretskii <eliz@gnu.org>
11884
11885 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
11886 for attrs[LFACE_FONTSET_INDEX].
11887
04c4b52e
PE
118882011-07-23 Paul Eggert <eggert@cs.ucla.edu>
11889
11890 * xml.c (parse_region): Remove unused local
11891 that was recently introduced.
11892
c1734fbd
EZ
118932011-07-23 Eli Zaretskii <eliz@gnu.org>
11894
be18c5a5
EZ
11895 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
11896 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
11897
c1734fbd
EZ
11898 * xdisp.c (move_it_in_display_line_to): Record the best matching
11899 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
11900 exit if none of the characters scanned was an exact match.
11901 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
11902 when exact match is impossible due to invisible text, and the
11903 lines are truncated.
11904
a258d627
JD
119052011-07-23 Jan Djärv <jan.h.d@swipnet.se>
11906
11907 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
11908 for OSX >= 10.7.
11909
b6d5a689
EZ
119102011-07-22 Eli Zaretskii <eliz@gnu.org>
11911
0f74f785
EZ
11912 Fix a significant slow-down of cursor motion with C-n, C-p,
11913 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
11914 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 11915 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
11916 (next_element_from_buffer): Call compute_stop_pos_backwards to
11917 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
11918 base_level_stop.
11919 (reseat): Don't look for prev_stop, as that could mean a very long
11920 run.
11921 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
11922 <cached_disp_overlay_modiff>: Cache for last found display string
11923 position.
551918c1 11924 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
11925 about the same buffer in the same area of character positions, and
11926 the buffer wasn't changed since the time the display string
11927 position was cached.
551918c1 11928
b2d0c91a
EZ
119292011-07-22 Eli Zaretskii <eliz@gnu.org>
11930
11931 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
11932 is an integer, which is important for empty lines. (Bug#9149)
11933
043604ee
CY
119342011-07-22 Chong Yidong <cyd@stupidchicken.com>
11935
11936 * frame.c (Fmodify_frame_parameters): In tty case, update the
11937 default face if necessary (Bug#4238).
11938
da4adb04
CY
119392011-07-21 Chong Yidong <cyd@stupidchicken.com>
11940
11941 * editfns.c (Fstring_to_char): No need to explain what a character
11942 is in the docstring (Bug#6576).
11943
9abd0532
LMI
119442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11945
11946 * xml.c (parse_region): Make sure we always return a tree.
11947
36881d16
HK
119482011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
11949
11950 * xml.c (parse_region): If a document contains only comments,
11951 return that, too.
11952
1e98674d
LMI
119532011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
11954
11955 * xml.c (make_dom): Return comments, too.
11956
590bd467
PE
119572011-07-19 Paul Eggert <eggert@cs.ucla.edu>
11958
11959 Port to OpenBSD.
11960 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
11961 and the surrounding thread.
11962 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
11963 rather than fgets, and retry after EINTR. Otherwise, 'emacs
11964 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
11965 timer goes off.
11966 * s/openbsd.h (BROKEN_SIGIO): Define.
11967 * unexelf.c (unexec) [__OpenBSD__]:
11968 Don't update the .mdebug section of the Alpha COFF symbol table.
11969
f41628b2
LMI
119702011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
11971
11972 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
11973 (bug#8460).
11974
b59b67c5
PE
119752011-07-18 Paul Eggert <eggert@cs.ucla.edu>
11976
15e3a074
PE
11977 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
11978 This fixes some race conditions on the permissions of any newly
11979 created file.
11980
41bed37d
PE
11981 * alloc.c (valid_pointer_p): Use pipe, not open.
11982 This fixes some permissions issues when debugging.
11983
b59b67c5
PE
11984 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
11985 If fchown fails to set both uid and gid, try to set just gid,
11986 as that is sometimes allowed. Adjust the file's mode to eliminate
11987 setuid or setgid bits that are inappropriate if fchown fails.
11988
925a6be7
SM
119892011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
11990
11991 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
11992 to compare Lisp_Objects.
11993 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
11994 global_gnutls_log_level, don't mistake it for a Lisp_Object.
11995 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
11996
52968808
AS
119972011-07-17 Andreas Schwab <schwab@linux-m68k.org>
11998
0a6a104b
AS
11999 * lread.c (read_integer): Unread even EOF character.
12000 (read1): Likewise. Properly record start position of symbol.
12001
52968808
AS
12002 * lread.c (read1): Read `#:' as empty uninterned symbol if no
12003 symbol character follows.
12004
9e381cdd
PE
120052011-07-17 Paul Eggert <eggert@cs.ucla.edu>
12006
12007 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
12008 This works around a problem with the previous change to Fcopy_file.
12009 Recent glibc declares fchown with __attribute__((warn_unused_result)),
12010 and without this change, GCC might complain about discarding
12011 fchown's return value.
12012
b5641435
JB
120132011-07-16 Juanma Barranquero <lekktu@gmail.com>
12014
12015 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
12016
a8031457
PE
120172011-07-16 Paul Eggert <eggert@cs.ucla.edu>
12018
12019 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
12020
dd889327
LMI
120212011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
12022
750c33f7
LMI
12023 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
12024 it's used from the C level.
12025
dd889327
LMI
12026 * process.c: Use the same condition for POLL_FOR_INPUT in both
12027 keyboard.c and process.c (bug#1858).
12028
87e86684
LM
120292011-07-09 Lawrence Mitchell <wence@gmx.li>
12030
12031 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
12032 (Fgnutls_boot): Use it.
12033
64348f40
AS
120342011-07-15 Andreas Schwab <schwab@linux-m68k.org>
12035
12036 * doc.c (Fsubstitute_command_keys): Revert last change.
12037
1d698799
LMI
120382011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
12039
f863868c
LMI
12040 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
12041 quotes the next character, and doesn't affect other longer
12042 sequences (bug#8935).
12043
1d698799
LMI
12044 * lread.c (syms_of_lread): Clarify that is isn't only
12045 `eval-buffer' and `eval-defun' that's affected by
12046 `lexical-binding' (bug#8460).
12047
aa4b6df6
EZ
120482011-07-15 Eli Zaretskii <eliz@gnu.org>
12049
12050 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 12051 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 12052
5d856da6
PE
120532011-07-14 Paul Eggert <eggert@cs.ucla.edu>
12054
ad6042bb
PE
12055 Fix minor problems found by static checking.
12056 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
12057 (elsz): Now a signed constant, not a size_t var. We prefer signed
12058 types to unsigned, to avoid integer comparison confusion. Without
12059 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
12060 "cannot optimize loop, the loop counter may overflow", a symptom
12061 of the confusion.
f00bbb22 12062 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
12063 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
12064
6468f31c
LMI
120652011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12066
49080b10
LMI
12067 * search.c (Fre_search_backward): Mention `case-fold-search' in
12068 all the re_search_* functions (bug#8138).
12069
6468f31c
LMI
12070 * keyboard.c (Fopen_dribble_file): Document when the file is
12071 closed (bug#8056).
12072
c965adc5
EZ
120732011-07-14 Eli Zaretskii <eliz@gnu.org>
12074
df9733bf
EZ
12075 * bidi.c (bidi_dump_cached_states): Fix format of displaying
12076 bidi_cache_idx.
12077
0bb23927
EZ
12078 Support bidi reordering of display and overlay strings.
12079 * xdisp.c (compute_display_string_pos)
12080 (compute_display_string_end): Accept additional argument STRING.
12081 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
12082 (reseat_to_string): Initialize bidi_it->string.s and
12083 bidi_it->string.schars.
12084 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
12085 NULL (avoids a crash in bidi_paragraph_init).
12086 Initialize itb.string.lstring.
0bb23927
EZ
12087 (init_iterator): Call bidi_init_it only of a valid
12088 buffer position was specified. Initialize paragraph_embedding to
12089 L2R.
12090 (reseat_to_string): Initialize the bidi iterator.
12091 (display_string): If we need to ignore text properties of
12092 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
12093 original value of -1 will not work with bidi.)
12094 (compute_display_string_pos): First arg is now struct
12095 `text_pos *'; all callers changed. Support display properties on
12096 Lisp strings.
12097 (compute_display_string_end): Support display properties on Lisp
12098 strings.
12099 (init_iterator, reseat_1, reseat_to_string): Initialize the
12100 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
12101 when iterating on a string not from display properties).
640c8776
SM
12102 (compute_display_string_pos, compute_display_string_end):
12103 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
12104 arrow keys.
12105 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
12106 base_level_stop; instead, set base_level_stop to BEGV.
12107 Fixes crashes in vertical-motion.
0bb23927
EZ
12108 (next_element_from_buffer): Improve commentary for when
12109 the iterator is before prev_stop.
12110 (init_iterator): Initialize bidi_p from the default value of
12111 bidi-display-reordering, not from buffer-local value. Use the
12112 buffer-local value only if initializing for buffer iteration.
12113 (handle_invisible_prop): Support invisible properties on strings
12114 that are being bidi-reordered.
12115 (set_iterator_to_next): Support bidi reordering of C strings and
12116 Lisp strings.
12117 (next_element_from_string): Support bidi reordering of Lisp
12118 strings.
12119 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
12120 (display_string): Support display of R2L glyph rows.
12121 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
12122 (init_iterator): Don't initialize it->bidi_p for strings
12123 here.
12124 (reseat_to_string): Initialize it->bidi_p for strings here.
12125 (next_element_from_string, next_element_from_c_string)
12126 (next_element_from_buffer): Add xassert's for correspondence
12127 between IT's object being iterated and it->bidi_it.string
12128 structure.
12129 (face_before_or_after_it_pos): Support bidi iteration.
12130 (next_element_from_c_string): Handle the case of the first string
12131 character that is not the first one in the visual order.
12132 (get_visually_first_element): New function, refactored from common
12133 parts of next_element_from_buffer, next_element_from_string, and
12134 next_element_from_c_string.
12135 (tool_bar_lines_needed, redisplay_tool_bar)
12136 (display_menu_bar): Force left-to-right direction. Add a FIXME
12137 comment for making that be controlled by a user option.
12138 (push_it, pop_it): Save and restore the state of the
12139 bidi iterator. Save and restore the bidi_p flag.
12140 (pop_it): Iterate out of display property for string iteration as
12141 well.
12142 (iterate_out_of_display_property): Support iteration over strings.
12143 (handle_single_display_spec): Set up it->bidi_it for iteration
12144 over a display string, and call bidi_init_it.
12145 (handle_single_display_spec, next_overlay_string)
12146 (get_overlay_strings_1, push_display_prop): Set up the bidi
12147 iterator for displaying display or overlay strings.
12148 (forward_to_next_line_start): Don't use the shortcut if
12149 bidi-iterating.
12150 (back_to_previous_visible_line_start): If handle_display_prop
12151 pushed the iterator stack, restore the internal state of the bidi
12152 iterator by calling bidi_pop_it same number of times.
12153 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
12154 and we are bidi-iterating, don't decrement the iterator position;
12155 instead, set the first_elt flag in the bidi iterator, to produce
12156 the same effect.
12157 (reseat_1): Remove redundant setting of string_from_display_prop_p.
12158 (push_display_prop): xassert that we are iterating a buffer.
12159 (push_it, pop_it): Save and restore paragraph_embedding member.
12160 (handle_single_display_spec, next_overlay_string)
12161 (get_overlay_strings_1, reseat_1, reseat_to_string)
12162 (push_display_prop): Set up the `unibyte' member of bidi_it.string
12163 correctly. Don't assume unibyte strings are not bidi-reordered.
12164 (compute_display_string_pos)
12165 (compute_display_string_end): Fix handling the case of C string.
12166 (push_it, pop_it): Save and restore from_disp_prop_p.
12167 (handle_single_display_spec, push_display_prop): Set the
12168 from_disp_prop_p flag.
12169 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
12170 (pop_it): Call iterate_out_of_display_property only if we are
12171 popping after iteration over a string that came from a display
12172 property. Fix a typo in popping stretch info. Add an assertion
12173 for verifying that the iterator position is in sync with the bidi
12174 iterator.
12175 (handle_single_display_spec, get_overlay_strings_1)
12176 (push_display_prop): Fix initialization of paragraph direction for
12177 string when that of the parent object is not yet determined.
12178 (reseat_1): Call bidi_init_it to resync the bidi
12179 iterator with IT's position. (Bug#7616)
12180 (find_row_edges): If ROW->start.pos gives position
12181 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
12182 (handle_stop, back_to_previous_visible_line_start, reseat_1):
12183 Reset the from_disp_prop_p flag.
12184 (SAVE_IT, RESTORE_IT): New macros.
12185 (pos_visible_p, face_before_or_after_it_pos)
12186 (back_to_previous_visible_line_start)
12187 (move_it_in_display_line_to, move_it_in_display_line)
12188 (move_it_to, move_it_vertically_backward, move_it_by_lines)
12189 (try_scrolling, redisplay_window, display_line): Use them when
12190 saving a temporary copy of the iterator and restoring it back.
12191 (back_to_previous_visible_line_start, reseat_1)
12192 (init_iterator): Empty the bidi cache "stack".
12193 (move_it_in_display_line_to): If iterator ended up at
12194 EOL, but we never saw any buffer positions smaller than
12195 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
12196 motion in bidi-reordered lines.
12197 (move_it_in_display_line_to): Record prev_method and prev_pos
12198 immediately before the call to set_iterator_to_next. Fixes cursor
12199 motion in bidi-reordered lines with stretch glyphs and strings
12200 displayed in margins. (Bug#8133) (Bug#8867)
12201 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
12202 TO_CHARPOS.
640c8776
SM
12203 (pos_visible_p): Support positions in bidi-reordered lines.
12204 Save and restore bidi cache.
0bb23927
EZ
12205
12206 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
12207 (bidi_paragraph_info): Delete unused struct.
12208 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
12209 (bidi_cache_start): New variable.
12210 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
12211 to zero.
12212 (bidi_cache_fetch_state, bidi_cache_search)
12213 (bidi_cache_find_level_change, bidi_cache_iterator_state)
12214 (bidi_cache_find, bidi_peek_at_next_level)
12215 (bidi_level_of_next_char, bidi_find_other_level_edge)
12216 (bidi_move_to_visually_next): Compare cache index with
12217 bidi_cache_start rather than with zero.
12218 (bidi_fetch_char): Accept new argument STRING; all callers
12219 changed. Support iteration over a string. Support strings with
12220 display properties. Support unibyte strings. Fix the type of
12221 `len' according to what STRING_CHAR_AND_LENGTH expects.
12222 (bidi_paragraph_init, bidi_resolve_explicit_1)
12223 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
12224 (bidi_level_of_next_char, bidi_move_to_visually_next):
12225 Support iteration over a string.
0bb23927
EZ
12226 (bidi_set_sor_type, bidi_resolve_explicit_1)
12227 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
12228 can now be zero (for strings); special values 0 and -1 were
12229 changed to -1 and -2, respectively.
12230 (bidi_char_at_pos): New function.
12231 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
12232 Call it instead of FETCH_MULTIBYTE_CHAR.
12233 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
12234 initialized to valid values.
12235 (bidi_init_it): Don't initialize charpos and bytepos with invalid
12236 values.
12237 (bidi_level_of_next_char): Allow the sentinel "position" to pass
12238 the test for valid cached positions. Fix the logic for looking up
12239 the sentinel state in the cache. GCPRO the Lisp string we are
12240 iterating.
12241 (bidi_push_it, bidi_pop_it): New functions.
12242 (bidi_initialize): Initialize the bidi cache start stack pointer.
12243 (bidi_cache_ensure_space): New function, refactored from part of
12244 bidi_cache_iterator_state. Don't assume the required size is just
12245 one BIDI_CACHE_CHUNK away.
12246 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
12247 (bidi_count_bytes, bidi_char_at_pos): New functions.
12248 (bidi_cache_search): Don't assume bidi_cache_last_idx is
12249 always valid if bidi_cache_idx is valid.
12250 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
12251 is valid if it's going to be used.
12252 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
12253 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
12254 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12255 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
12256 (bidi_find_other_level_edge, bidi_cache_start_stack):
12257 All variables related to cache indices are now EMACS_INT.
c965adc5 12258
0bb23927
EZ
12259 * dispextern.h (struct bidi_string_data): New structure.
12260 (struct bidi_it): New member `string'. Make flag members be 1-bit
12261 fields, and put them last in the struct.
640c8776
SM
12262 (compute_display_string_pos, compute_display_string_end):
12263 Update prototypes.
0bb23927
EZ
12264 (bidi_push_it, bidi_pop_it): Add prototypes.
12265 (struct iterator_stack_entry): New members bidi_p,
12266 paragraph_embedding, and from_disp_prop_p.
12267 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
12268 (bidi_shelve_cache, bidi_unshelve_cache):
12269 Declare prototypes.
0bb23927
EZ
12270
12271 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
12272 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
12273 and vector-like objects.
12274
12275 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
12276 cache around display iteration.
12277
12278 * window.c (Fwindow_end, window_scroll_pixel_based)
12279 (displayed_window_lines, Frecenter): Save and restore the bidi
12280 cache around display iteration.
12281
3bbd2265
LMI
122822011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12283
12284 * editfns.c (Fdelete_region): Clarify the use of the named
12285 parameters (bug#6788).
12286
adc47434
MR
122872011-07-14 Martin Rudalics <rudalics@gmx.at>
12288
12289 * indent.c (Fvertical_motion): Set and restore w->pointm when
12290 saving and restoring the window's buffer (Bug#9006).
12291
837c31f8
LMI
122922011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
12293
12294 * editfns.c (Fstring_to_char): Clarify just what is returned
12295 (bug#6576). Text by Eli Zaretskii.
12296
ac389d0c
JB
122972011-07-13 Juanma Barranquero <lekktu@gmail.com>
12298
12299 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
12300
0be0ce47
EZ
123012011-07-13 Eli Zaretskii <eliz@gnu.org>
12302
12303 * buffer.c (mmap_find): Fix a typo.
12304
cd18e7e3
JB
123052011-07-13 Johan Bockgård <bojohan@gnu.org>
12306
12307 Fix execution of x selection hooks.
12308 * xselect.c (Qx_lost_selection_functions)
12309 (Qx_sent_selection_functions): New vars.
12310 (syms_of_xselect): DEFSYM them.
12311 (x_handle_selection_request): Pass Qx_sent_selection_functions
12312 rather than Vx_sent_selection_functions to Frun_hook_with_args.
12313 (x_handle_selection_clear,x_clear_frame_selections):
12314 Pass Qx_lost_selection_functions rather than
12315 Vx_lost_selection_functions to Frun_hook_with_args.
12316
47ea7f44
PE
123172011-07-13 Paul Eggert <eggert@cs.ucla.edu>
12318
ac389d0c 12319 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
12320 The old code sometimes used this field without initializing it.
12321
47ea7f44
PE
12322 * alloc.c (gc_sweep): Don't read past end of array.
12323 In theory, the old code could also have corrupted Emacs internals,
12324 though it'd be very unlikely.
12325
bc985c87
AS
123262011-07-12 Andreas Schwab <schwab@linux-m68k.org>
12327
12328 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 12329 argument. (Bug#4026)
bc985c87 12330
0cf34688
LMI
123312011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
12332
b3dadd76
LMI
12333 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
12334 key" (bug#4257).
12335
0cf34688
LMI
12336 * window.c (Fset_window_start): Doc fix (bug#4199).
12337 (Fset_window_hscroll): Ditto.
12338
270768cd
PE
123392011-07-12 Paul Eggert <eggert@cs.ucla.edu>
12340
077e3dda 12341 Fix minor new problems caught by GCC 4.6.1.
270768cd 12342 * term.c (init_tty): Remove unused local.
490011a6 12343 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 12344 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 12345 not used otherwise.
270768cd 12346
b1f58454
CY
123472011-07-12 Chong Yidong <cyd@stupidchicken.com>
12348
12349 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
12350
22b9578d
LMI
123512011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
12352
6e70ab07
LMI
12353 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
12354 are the mini-buffer and the echo area (bug#3320).
12355
22b9578d
LMI
12356 * term.c (init_tty): Remove support for supdup, c10 and perq
12357 terminals, which are no longer supported (bug#1482).
12358
8974cc9f
JB
123592011-07-10 Johan Bockgård <bojohan@gnu.org>
12360
12361 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
12362
a560d974
JD
123632011-07-10 Jan Djärv <jan.h.d@swipnet.se>
12364
12365 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
12366 for non-popups (Bug#3642).
12367
1dae0f0a
AS
123682011-07-10 Andreas Schwab <schwab@linux-m68k.org>
12369
268c2c36 12370 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 12371 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
12372 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
12373 * cm.c (losecursor): Likewise.
1dae0f0a
AS
12374 * data.c (fmod): Likewise.
12375 * dispnew.c (swap_glyphs_in_rows): Likewise.
12376 * emacs.c (memory_warning_signal): Likewise.
12377 * floatfns.c (float_error): Likewise.
12378 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
12379 (otf_open, font_otf_capability, generate_otf_features)
12380 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
12381 Likewise.
12382 * image.c (pbm_read_file): Likewise.
12383 * indent.c (string_display_width): Likewise.
12384 * intervals.c (check_for_interval, search_for_interval)
12385 (inc_interval_count, count_intervals, root_interval)
12386 (adjust_intervals_for_insertion, make_new_interval): Likewise.
12387 * lread.c (defalias): Likewise.
268c2c36 12388 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
12389 * regex.c (set_image_of_range_1, set_image_of_range)
12390 (regex_grow_registers): Likewise.
12391 * sysdep.c (strerror): Likewise.
12392 * termcap.c (valid_filename_p, tprint, main): Likewise.
12393 * tparam.c (main): Likewise.
12394 * unexhp9k800.c (run_time_remap, save_data_space)
12395 (update_file_ptrs, read_header, write_header, calculate_checksum)
12396 (copy_file, copy_rest, display_header): Likewise.
12397 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
12398 Likewise.
12399 * xdisp.c (check_it): Likewise.
12400 * xfaces.c (register_color, unregister_color, unregister_colors):
12401 Likewise.
12402 * xfns.c (print_fontset_result): Likewise.
12403 * xrdb.c (member, fatal, main): Likewise.
12404
99033785
PE
124052011-07-10 Paul Eggert <eggert@cs.ucla.edu>
12406
12407 Fix minor problems found by static checking (Bug#9031).
12408 * chartab.c (char_table_set_range, map_sub_char_table):
12409 Remove unused locals.
12410 (uniprop_table): Now static.
12411 * composite.c (_work_char): Remove unused static var.
12412
9cb2ac56
JB
124132011-07-09 Juanma Barranquero <lekktu@gmail.com>
12414
12415 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
12416
f25661f0
JD
124172011-07-09 Jan Djärv <jan.h.d@swipnet.se>
12418
12419 * gtkutil.c (qttip_cb): Remove code without function.
12420
8278c4fe
EZ
124212011-07-09 Eli Zaretskii <eliz@gnu.org>
12422
12423 * w32.c (pthread_sigmask): New stub.
12424
1692ae2d 124252011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 12426
8a6ebd58 12427 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
12428 sigprocmask is portable only for single-threaded applications, and
12429 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
12430 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
12431 (LIBES): Use it.
12432 * callproc.c (Fcall_process):
12433 * process.c (create_process):
12434 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
12435 Use pthread_sigmask, not sigprocmask.
123403e4 12436
1b854618
JD
124372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12438
12439 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
12440 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
12441 wrong (Bug#8591).
12442
3fe4b549
JD
124432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12444
0ce7e563
JD
12445 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
12446 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
12447 (xg_hide_tooltip): Fix comment.
12448
3fe4b549
JD
12449 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
12450 in registerServicesMenuSendTypes.
12451 (validRequestorForSendType): Don't check ns_return_types.
12452
12453 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
12454 ns_return_type.
12455
5df75e47
JR
124562011-07-08 Jason Rumney <jasonr@gnu.org>
12457
22610910
JR
12458 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
12459 SH_SHOW for hidden windows (Bug#5482).
12460
5df75e47
JR
12461 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
12462 frame struct members of non-existent frames (Bug#6284).
12463
699c10bd
JD
124642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12465
4393663b
JD
12466 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
12467 variable firstTime not needed on OSX >= 10.6.
12468 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
12469 >= 10.5. Use setKnobProportion, setDoubleValue.
12470
12471 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
12472 (MAC_OS_X_VERSION_10_5): Define if not defined.
12473 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
12474 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
12475 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
12476
12477 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 12478 cString and lossyCString on OSX >= 10.4.
4393663b 12479
58179cce 12480 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
12481 sizeToFit on OSX >= 10.2.
12482
12483 * nsimage.m (allocInitFromFile): Don't use deprecated method
12484 bestRepresentationForDevice on OSX >= 10.6.
12485
12486 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
12487 to avoid warning.
12488
12489 * emacs.c: Declare unexec_init_emacs_zone.
12490
a63e0781
JD
12491 * nsgui.h: Fix compiler warning about gnulib redefining verify.
12492
699c10bd
JD
12493 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
12494
12495 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
12496 on svcsMenu (Bug#8842).
12497
12498 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
12499 ns_return_types.
12500 (Fns_list_services): Just return Qnil on 10.6, code not working there.
12501
12502 * nsterm.m (QUTF8_STRING): Declare.
12503 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
12504 (validRequestorForSendType): Return type is (id).
12505 Change indexOfObjectIdenticalTo to indexOfObject.
12506 Check if we have local selection before returning self (Bug#8842).
12507 (writeSelectionToPasteboard): Put local selection into paste board
12508 if we have a local selection (Bug#8842).
12509 (syms_of_nsterm): DEFSYM QUTF8_STRING.
12510
12511 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
12512 (ns_get_local_selection): Declare.
12513
54e10184
LMI
125142011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
12515
9888ff71
LMI
12516 * keymap.c (describe_map_tree): Don't insert a double newline at
12517 the end of the buffer (bug#1169) and return whether we inserted
12518 something.
12519
54e10184
LMI
12520 * callint.c (Fcall_interactively): Change "reading args" to
12521 "providing args" to try to clarify what it does (bug#1010).
12522
15fa4783
KH
125232011-07-07 Kenichi Handa <handa@m17n.org>
12524
12525 * composite.c (composition_compute_stop_pos): Ignore a static
12526 composition starting before CHARPOS (Bug#8915).
12527
12528 * xdisp.c (handle_composition_prop): Likewise.
12529
a8815b00
EZ
125302011-07-07 Eli Zaretskii <eliz@gnu.org>
12531
12532 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
12533 (Bug#9015)
12534
ef7b981d 125352011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
12536
12537 * character.h (unicode_category_t): New enum type.
12538
12539 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
12540 (Qchar_code_property_table): New variable.
12541 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
12542 (UNIPROP_COMPRESSED_FORM_P): New macros.
12543 (char_table_ascii): Uncompress the compressed values.
12544 (sub_char_table_ref): New arg is_uniprop. Callers changed.
12545 Uncompress the compressed values.
ac389d0c 12546 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
12547 (char_table_ref_and_range): Uncompress the compressed values.
12548 (sub_char_table_set): New arg is_uniprop. Callers changed.
12549 Uncompress the compressed values.
12550 (sub_char_table_set_range): Args changed. Callers changed.
12551 (char_table_set_range): Adjuted for the above change.
12552 (map_sub_char_table): Delete args default_val and parent. Add arg
12553 top. Give decoded values to a Lisp function.
640c8776 12554 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
12555 values to a Lisp function. Gcpro more variables.
12556 (uniprop_table_uncompress)
12557 (uniprop_decode_value_run_length): New functions.
12558 (uniprop_decoder, uniprop_decoder_count): New variables.
12559 (uniprop_get_decoder, uniprop_encode_value_character)
12560 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
12561 New functions.
12562 (uniprop_encoder, uniprop_encoder_count): New variables.
12563 (uniprop_get_encoder, uniprop_table)
12564 (Funicode_property_table_internal, Fget_unicode_property_internal)
12565 (Fput_unicode_property_internal): New functions.
12566 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
12567 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 12568 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
12569 char-code-property-alist.
12570
640c8776 12571 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
12572 Vunicode_category_table.
12573
640c8776 12574 * font.c (font_range): Adjust for the change of
c805dec0
KH
12575 Vunicode_category_table.
12576
76b397fb
DN
125772011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
12578
12579 * m/iris4d.h: Remove file, move contents ...
12580 * s/irix6-5.h: ... here.
12581
22b4128e
PE
125822011-07-06 Paul Eggert <eggert@cs.ucla.edu>
12583
12584 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
12585 * alloc.c (mark_buffer):
12586 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
12587 (clone_per_buffer_values): Don't assume that
22b4128e
PE
12588 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
12589 This isn't true in general, and it's particularly not true
12590 if Emacs is configured with --with-wide-int.
12591 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
12592 New macros, used in the buffer.c change.
12593
869795d6
JD
125942011-07-05 Jan Djärv <jan.h.d@swipnet.se>
12595
12596 * xsettings.c: Use both GConf and GSettings if both are available.
12597 (store_config_changed_event): Add comment.
12598 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
12599 (store_tool_bar_style_changed): New functions.
5e617bc2 12600 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
12601 (struct xsettings): Move font inside HAVE_XFT.
12602 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 12603 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 12604 Move inside HAVE_XFT.
640c8776 12605 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
12606 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
12607 also.
12608 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 12609 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 12610 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
12611 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
12612 (parse_settings): Move check for font inside HAVE_XFT.
12613 (read_settings, apply_xft_settings): Add comment.
12614 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
12615 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
12616 call store_font_name_changed.
12617 (xft_settings_event): Add comment.
12618 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
12619 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
12620 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
12621 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
12622 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
12623 (xsettings_get_system_font, xsettings_get_system_normal_font):
12624 Add comment.
869795d6 12625
d8ed26bd
PE
126262011-07-05 Paul Eggert <eggert@cs.ucla.edu>
12627
12628 Random fixes. E.g., (random) never returned negative values.
12629 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
12630 subseconds part to the entropy, as that's a bit more random.
12631 Prefer signed to unsigned, since the signedness doesn't matter and
12632 in general we prefer signed. When given a limit, use a
12633 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
12634 latter isn't right if USE_2_TAGS_FOR_INTS.
12635 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
12636 not 0..VALMASK. Don't discard "excess" bits that random () returns.
12637
cabf1cac
SM
126382011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
12639
12640 * textprop.c (text_property_stickiness):
12641 Obey Vtext_property_default_nonsticky.
12642 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
12643 * w32fns.c (syms_of_w32fns):
12644 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
12645
6e9b2be9
PE
126462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
12647
12648 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
12649 This is more efficient than Ffile_directory_p and avoids a minor race.
12650
90186c68
LMI
126512011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
12652
7c301272
LMI
12653 * buffer.c (Foverlay_put): Say what the return value is
12654 (bug#7835).
12655
c4f2d8d4
LMI
12656 * fileio.c (barf_or_query_if_file_exists): Check first if the file
12657 is a directory before asking whether to use the file name
12658 (bug#7564).
ad637907
LMI
12659 (barf_or_query_if_file_exists): Make the "File is a directory"
12660 error be more correct.
c4f2d8d4 12661
90186c68
LMI
12662 * fns.c (Frequire): Remove the mention of the .gz files, since
12663 that's installation-specific, but keep the mention of
12664 `get-load-suffixes'.
12665
da64016e
PE
126662011-07-04 Paul Eggert <eggert@cs.ucla.edu>
12667
12668 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
12669 Report string overflow if the output is too long.
12670
7d47b580
JB
126712011-07-04 Juanma Barranquero <lekktu@gmail.com>
12672
a555cb87
JB
12673 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
12674 (syms_of_gnutls): Remove duplicate DEFSYM for
12675 Qgnutls_bootprop_verify_hostname_error, an error for
12676 Qgnutls_bootprop_verify_error (which is no longer used).
12677
7d47b580
JB
12678 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
12679 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
12680 Also (re)move comments that are misplaced or no longer relevant.
12681
1e49bfab
LMI
126822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12683
12684 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
12685
1485f4c0
CY
126862011-07-03 Chong Yidong <cyd@stupidchicken.com>
12687
12688 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
12689 and background color parameters if they have been changed.
12690
a9ab721e
LMI
126912011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12692
12693 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
12694
cf7cff57
PE
126952011-07-03 Paul Eggert <eggert@cs.ucla.edu>
12696
2e13213d
PE
12697 * xsettings.c (SYSTEM_FONT): Define only when used.
12698 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
12699
cf7cff57
PE
12700 * keymap.c (access_keymap_1): Now static.
12701
7a8e04f7
CY
127022011-07-02 Chong Yidong <cyd@stupidchicken.com>
12703
12704 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
12705 leave any prefix arg for the up event (Bug#1586).
12706
61352f62
LMI
127072011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
12708
69bb1ef7
LMI
12709 * lread.c (syms_of_lread): Mention single symbols defined by
12710 `defvar' or `defconst' (bug#7154).
12711
61352f62 12712 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 12713 (Frequire): Mention get-load-suffixes.
61352f62 12714
28545e04
MR
127152011-07-02 Martin Rudalics <rudalics@gmx.at>
12716
12717 * window.h (window): Remove clone_number slot.
12718 * window.c (Fwindow_clone_number, Fset_window_clone_number):
12719 Remove.
12720 (make_parent_window, make_window, saved_window)
12721 (Fset_window_configuration, save_window_save): Don't deal with
12722 clone numbers.
12723 * buffer.c (Qclone_number): Remove declaration.
12724 (sort_overlays, overlay_strings): Don't deal with clone numbers.
12725
3349e122
SM
127262011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
12727
12728 Add multiple inheritance to keymaps.
12729 * keymap.c (Fmake_composed_keymap): New function.
12730 (Fset_keymap_parent): Simplify.
12731 (fix_submap_inheritance): Remove.
12732 (access_keymap_1): New function extracted from access_keymap to handle
12733 embedded parents and handle lists of maps.
12734 (access_keymap): Use it.
12735 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
12736 (Fcopy_keymap): Handle embedded parents.
12737 (Fcommand_remapping, define_as_prefix): Simplify.
12738 (Fkey_binding): Simplify.
12739 (syms_of_keymap): Move minibuffer-local-completion-map,
12740 minibuffer-local-filename-completion-map,
12741 minibuffer-local-must-match-map, and
12742 minibuffer-local-filename-must-match-map to Elisp.
12743 (syms_of_keymap): Defsubr make-composed-keymap.
12744 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
12745 (parse_menu_item): Trivial simplification.
12746
3279eb87
GM
127472011-07-01 Glenn Morris <rgm@gnu.org>
12748
12749 * Makefile.in (SETTINGS_LIBS): Fix typo.
12750
39cb9e56 127512011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
12752
12753 * coding.c (Fencode_coding_string): Record the last coding system
12754 used, as the function doc string says (bug#8738).
12755
0949d2b6
JD
127562011-07-01 Jan Djärv <jan.h.d@swipnet.se>
12757
12758 * xsettings.c (store_monospaced_changed): Take new font as arg and
12759 check for change against current_mono_font.
12760 (EMACS_TYPE_SETTINGS): Remove this and related defines.
12761 (emacs_settings_constructor, emacs_settings_get_property)
12762 (emacs_settings_set_property, emacs_settings_class_init)
12763 (emacs_settings_init, gsettings_obj): Remove.
12764 (something_changedCB): New function for HAVE_GSETTINGS.
12765 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
12766 with value as argument.
12767 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
12768 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 12769 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
12770 "changed".
12771
12772 * xgselect.c: Add defined (HAVE_GSETTINGS).
12773 (xgselect_initialize): Ditto.
12774
12775 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
12776 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
12777 xg_select.
12778
bbc6b304
PE
127792011-07-01 Paul Eggert <eggert@cs.ucla.edu>
12780
12781 * eval.c (struct backtrace): Simplify and port the data structure.
12782 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
12783 signed bit field, as this assumption is not portable and it makes
12784 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
12785 "char debug_on_exit : 1" as this is not portable either; instead,
12786 use the portable "unsigned int debug_on_exit : 1". Remove unused
12787 member evalargs. Remove obsolete comments about cc bombing out.
12788
9851bfc5
JD
127892011-06-30 Jan Djärv <jan.h.d@swipnet.se>
12790
51bb811f 12791 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
12792 Let HAVE_GSETTINGS override HAVE_GCONF.
12793 (store_monospaced_changed): New function.
12794 (EMACS_SETTINGS): A new type derived from GObject to handle
12795 GSettings notifications.
12796 (emacs_settings_constructor, emacs_settings_get_property)
12797 (emacs_settings_set_property, emacs_settings_class_init):
12798 New functions.
12799 (gsettings_client, gsettings_obj): New variables.
12800 (GSETTINGS_SCHEMA): New define.
12801 (something_changedCB): Call store_monospaced_changed.
12802 (init_gsettings): New function.
12803 (xsettings_initialize): Call init_gsettings.
12804 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
12805 to NULL.
12806
640c8776 12807 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
12808 GCONF_CFLAGS/LIBS.
12809
5386012d
MR
128102011-06-29 Martin Rudalics <rudalics@gmx.at>
12811
12812 * window.c (resize_root_window, grow_mini_window)
12813 (shrink_mini_window): Rename Qresize_root_window to
12814 Qwindow_resize_root_window and Qresize_root_window_vertically to
12815 Qwindow_resize_root_window_vertically.
12816
f13e0b08
PE
128172011-06-28 Paul Eggert <eggert@cs.ucla.edu>
12818
12819 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
12820
94515237
JB
128212011-06-27 Juanma Barranquero <lekktu@gmail.com>
12822
12823 * makefile.w32-in: Redesign dependencies so they reflect more
12824 clearly which files are directly included by each source file,
12825 and not through other includes.
12826
e43b6e43
MR
128272011-06-27 Martin Rudalics <rudalics@gmx.at>
12828
12829 * buffer.c (Qclone_number): Declare static and DEFSYM it.
12830 (sort_overlays, overlay_strings): When an overlay's clone number
12831 matches the window's clone number process the overlay even if
12832 the overlay's window property doesn't match the current window.
12833
d68443dc
MR
12834 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
12835 (Fwindow_hchild): Rename to Fwindow_left_child.
12836 (Fwindow_next): Rename to Fwindow_next_sibling.
12837 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
12838 (resize_window_check): Rename to window_resize_check.
12839 (resize_window_apply): Rename to window_resize_apply.
12840 (Fresize_window_apply): Rename to Fwindow_resize_apply.
12841 (Fdelete_other_windows_internal, resize_frame_windows)
12842 (Fsplit_window_internal, Fdelete_window_internal)
12843 (grow_mini_window, shrink_mini_window)
12844 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 12845
c7e73be5
JD
128462011-06-26 Jan Djärv <jan.h.d@swipnet.se>
12847
12848 * emacsgtkfixed.h: State that this is only used with Gtk+3.
12849 (emacs_fixed_set_min_size): Remove.
12850 (emacs_fixed_new): Take frame as argument.
12851
12852 * emacsgtkfixed.c: State that this is only used with Gtk+3.
12853 (_EmacsFixedPrivate): Remove minwidth/height.
12854 Add struct frame *f.
12855 (emacs_fixed_init): Initialize priv->f.
12856 (get_parent_class, emacs_fixed_set_min_size): Remove.
12857 (emacs_fixed_new): Set priv->f to argument.
12858 (emacs_fixed_get_preferred_width)
12859 (emacs_fixed_get_preferred_height): Use min_width/height from
12860 frames size_hint to set minimum and natural (Bug#8919).
12861 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
12862 and use min_width/height from frames size_hint to set
12863 min_width/height (Bug#8919).
12864
12865 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
12866 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
12867 Fix indentation.
c7e73be5 12868
cf99dcf8
EZ
128692011-06-26 Eli Zaretskii <eliz@gnu.org>
12870
12871 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
12872 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
12873 called at ZV.
12874
029529ac
CY
128752011-06-26 Chong Yidong <cyd@stupidchicken.com>
12876
12877 * process.c (wait_reading_process_output): Bypass select if
12878 waiting for a cell while ignoring keyboard input, and input is
12879 pending. Suggested by Jan Djärv (Bug#8869).
12880
7a7ef429
PE
128812011-06-25 Paul Eggert <eggert@cs.ucla.edu>
12882
12883 Use gnulib's dup2 module instead of rolling our own.
12884 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
12885
11fdef7d 128862011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
12887
12888 * dispnew.c (scrolling_window): Before scrolling, turn off a
12889 mouse-highlight in the window being scrolled.
12890
cd3520a4
JB
128912011-06-24 Juanma Barranquero <lekktu@gmail.com>
12892
12893 Move DEFSYM to lisp.h and use everywhere.
12894
12895 * character.h (DEFSYM): Move declaration...
12896 * lisp.h (DEFSYM): ...here.
12897
12898 * gnutls.c:
12899 * minibuf.c:
12900 * w32menu.c:
12901 * w32proc.c:
12902 * w32select.c: Don't include character.h.
12903
12904 * alloc.c (syms_of_alloc):
12905 * buffer.c (syms_of_buffer):
12906 * bytecode.c (syms_of_bytecode):
12907 * callint.c (syms_of_callint):
12908 * casefiddle.c (syms_of_casefiddle):
12909 * casetab.c (init_casetab_once):
12910 * category.c (init_category_once, syms_of_category):
12911 * ccl.c (syms_of_ccl):
12912 * cmds.c (syms_of_cmds):
12913 * composite.c (syms_of_composite):
12914 * dbusbind.c (syms_of_dbusbind):
12915 * dired.c (syms_of_dired):
12916 * dispnew.c (syms_of_display):
12917 * doc.c (syms_of_doc):
12918 * editfns.c (syms_of_editfns):
12919 * emacs.c (syms_of_emacs):
12920 * eval.c (syms_of_eval):
12921 * fileio.c (syms_of_fileio):
12922 * fns.c (syms_of_fns):
12923 * frame.c (syms_of_frame):
12924 * fringe.c (syms_of_fringe):
12925 * insdel.c (syms_of_insdel):
12926 * keymap.c (syms_of_keymap):
12927 * lread.c (init_obarray, syms_of_lread):
12928 * macros.c (syms_of_macros):
12929 * msdos.c (syms_of_msdos):
12930 * print.c (syms_of_print):
12931 * process.c (syms_of_process):
12932 * search.c (syms_of_search):
12933 * sound.c (syms_of_sound):
12934 * syntax.c (init_syntax_once, syms_of_syntax):
12935 * terminal.c (syms_of_terminal):
12936 * textprop.c (syms_of_textprop):
12937 * undo.c (syms_of_undo):
12938 * w32.c (globals_of_w32):
12939 * window.c (syms_of_window):
12940 * xdisp.c (syms_of_xdisp):
12941 * xfaces.c (syms_of_xfaces):
12942 * xfns.c (syms_of_xfns):
12943 * xmenu.c (syms_of_xmenu):
12944 * xsettings.c (syms_of_xsettings):
12945 * xterm.c (syms_of_xterm): Use DEFSYM.
12946
4228cf16
TZ
129472011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
12948
cd3520a4 12949 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 12950
7fcccf1e
PE
129512011-06-23 Paul Eggert <eggert@cs.ucla.edu>
12952
7efb4e0e
PE
12953 Integer and buffer overflow fixes (Bug#8873).
12954
ff5844ad
PE
12955 * print.c (printchar, strout): Check for string overflow.
12956 (PRINTPREPARE, printchar, strout):
12957 Don't set size unless allocation succeeds.
12958
90532f02
PE
12959 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
12960 for sizes. Check for string overflow more accurately.
12961 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
12962
6d84508d
PE
12963 * macros.c: Integer and buffer overflow fixes.
12964 * keyboard.h (struct keyboard.kbd_macro_bufsize):
12965 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
12966 Use ptrdiff_t, not int, for sizes.
12967 Don't increment bufsize until after realloc succeeds.
12968 Check for size-calculation overflow.
12969 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
12970
437b2cb4
PE
12971 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
12972
8b9ac8b4
PE
12973 * lread.c: Integer overflow fixes.
12974 (read_integer): Radix is now EMACS_INT, not int,
12975 to improve quality of diagnostics for out-of-range radices.
12976 Calculate buffer size correctly for out-of-range radices.
12977 (read1): Check for integer overflow in radices, and in
12978 read-circle numbers.
82cb60d3
PE
12979 (read_escape): Avoid int overflow.
12980 (Fload, openp, read_buffer_size, read1)
12981 (substitute_object_recurse, read_vector, read_list, map_obarray):
12982 Use ptrdiff_t, not int, for sizes.
12983 (read1): Use EMACS_INT, not int, for sizes.
20270765 12984 Check for size overflow.
8b9ac8b4 12985
7fcccf1e
PE
12986 * image.c (cache_image): Check for size arithmetic overflow.
12987
bfbbd7e7
PE
12988 * lread.c: Integer overflow issues.
12989 (saved_doc_string_size, saved_doc_string_length)
12990 (prev_saved_doc_string_size, prev_saved_doc_string_length):
12991 Now ptrdiff_t, not int.
12992 (read1): Don't assume doc string length fits in int. Check for
12993 out-of-range doc string lengths.
12994 (read_list): Don't assume file position fits in int.
39019e54 12995 (read_escape): Check for hex character overflow.
bfbbd7e7 12996
4e323265
LL
129972011-06-22 Leo Liu <sdl.web@gmail.com>
12998
12999 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
13000 Move to minibuffer.el.
13001
85fece3e
PE
130022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13003
20b84ce9 13004 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
13005 The following patches are for when GLYPH_DEBUG && !XASSERT.
13006 * dispextern.h (trace_redisplay_p, dump_glyph_string):
13007 * dispnew.c (flush_stdout):
13008 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
13009 Mark as externally visible.
13010 * dispnew.c (check_window_matrix_pointers): Now static.
13011 * dispnew.c (window_to_frame_vpos):
13012 * xfns.c (unwind_create_frame):
13013 * xterm.c (x_check_font): Remove unused local.
13014 * scroll.c (CHECK_BOUNDS):
13015 * xfaces.c (cache_fache): Rename local to avoid shadowing.
13016 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
13017 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
13018 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
13019 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
13020 Now static.
13021 (debug_method_add): Use va_list and vsprintf rather than relying
13022 on undefined behavior with wrong number of arguments.
13023 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
13024 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
13025 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
13026 since we're not interested in debugging glyphs with old libraries.
13027 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
13028 GCC 4.6.0's static checking.
13029
0766b489
PE
130302011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13031
31fd4b32
PE
13032 Integer overflow and signedness fixes (Bug#8873).
13033 A few related buffer overrun fixes, too.
13034
b79e8648
PE
13035 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
13036
0766b489
PE
13037 * dispextern.h (struct face.stipple):
13038 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
13039 (x_bitmap_mask, x_allocate_bitmap_record)
13040 (x_create_bitmap_from_data, x_create_bitmap_from_file)
13041 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
13042 (x_create_bitmap_from_xpm_data):
13043 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
13044 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
13045 (.bitmaps_last):
13046 * xfaces.c (load_pixmap):
13047 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
13048 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
13049 (.bitmaps_last, struct x_output.icon_bitmap):
13050 Use ptrdiff_t, not int, for bitmap indexes.
13051 (x_allocate_bitmap_record): Check for size overflow.
13052 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
13053
b081724f
PE
13054 Use ptrdiff_t, not int, for overlay counts.
13055 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
13056 * editfns.c (overlays_around, get_pos_property):
13057 * textprop.c (get_char_property_and_overlay):
13058 * xdisp.c (next_overlay_change, note_mouse_highlight):
13059 * xfaces.c (face_at_buffer_position):
21514da7
PE
13060 * buffer.c (OVERLAY_COUNT_MAX): New macro.
13061 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
13062 (Fnext_overlay_change, Fprevious_overlay_change)
13063 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 13064 Use ptrdiff_t, not int, for sizes.
21514da7 13065 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 13066
3de73e5e
PE
13067 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
13068
2606c57b
PE
13069 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
13070 (x_session_initialize): Do not assume string length fits in int.
13071
aaafe47a
PE
13072 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
13073 This is unlikely, but can occur if DPI is outlandish.
13074
2674ddc8 13075 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
13076 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
13077
28154962
PE
13078 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
13079 * xrdb.c (magic_file_p, search_magic_path):
13080 Omit last arg SUFFIX; it was always 0. All callers changed.
13081 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
13082
7de51af5
PE
13083 * xfont.c (xfont_match): Avoid need for strlen.
13084
25ed6cc3
PE
13085 * xfns.c: Don't assume strlen fits in int.
13086 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
13087
4eab31dd
PE
13088 * xdisp.c (message_log_check_duplicate): Return intmax_t,
13089 not unsigned long, as we prefer signed integers. All callers changed.
13090 Detect integer overflow in repeat count.
13091 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 13092 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 13093
171e2a58
PE
13094 * termcap.c: Don't assume sizes fit in int and never overflow.
13095 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
13096 (gobble_line): Check for size-calculation overflow.
13097
ad39faca 13098 * minibuf.c (Fread_buffer):
6e5bb2dc 13099 * lread.c (intern, intern_c_string):
74ca2eb3
PE
13100 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
13101 Don't assume string length fits in int.
13102
52c61c22 13103 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
13104 * gtkutil.c (style_changed_cb): Avoid need for strlen.
13105
b5b8c9e5
PE
13106 * font.c: Don't assume string length fits in int.
13107 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
13108 Use ptrdiff_t, not int.
ccd6111c
PE
13109 (font_intern_prop): Don't assume string length fits in int.
13110 Don't assume integer property fits in fixnum.
13111 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 13112
882f0d81 13113 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 13114 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
13115 Reformulate so as not to need the command string.
13116 Invoke gzip -cd rather than gunzip, as it's more portable.
13117 (lock_info_type, lock_file_1, lock_file):
13118 Don't assume pid_t and time_t fit in unsigned long.
13119 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
13120 (current_lock_owner): Prefer signed type for sizes.
13121 Use memcpy, not strncpy, where memcpy is what is really wanted.
13122 Don't assume (via atoi) that time_t and pid_t fit in int.
13123 Check for time_t and/or pid_t out of range, e.g., via a network share.
13124 Don't alloca where an auto var works fine.
13125
93f4cf88
PE
13126 * fileio.c: Fix some integer overflow issues.
13127 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
13128 Don't assume string length fits in int.
13129 (directory_file_name): Don't assume string length fits in long.
13130 (make_temp_name): Don't assume pid fits in int, or that its print
13131 length is less than 20.
13132
f3e92b69
PE
13133 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
13134
1bfdaf10
PE
13135 * coding.c (make_subsidiaries): Don't assume string length fits in int.
13136
35016e9a
PE
13137 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
13138
3d1e65a1
PE
13139 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
13140 We prefer signed integers, even for size calculations.
13141
0b963a93
PE
13142 * emacs.c: Don't assume string length fits in 'int'.
13143 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
13144 (main): Don't invoke strlen when not needed.
13145
573f4b54
PE
13146 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
13147 (XD_DEBUG_MESSAGE): Don't waste a byte.
13148
989f33ba
PE
13149 * callproc.c (getenv_internal_1, getenv_internal)
13150 (Fgetenv_internal):
965d34eb
PE
13151 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
13152
e4d29b33
PE
13153 * lread.c (invalid_syntax): Omit length argument.
13154 All uses changed. This doesn't fix a bug, but it simplifies the
13155 code away from its former Hollerith-constant appearance, and it's
13156 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 13157 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 13158
eb49b136
PE
13159 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
13160 This didn't break anything, but it didn't help either.
13161 It's confusing to put a bogus integer in a place where the actual
13162 value does not matter.
9f62aeb1 13163 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 13164 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 13165
15375a22
PE
13166 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
13167 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
13168 implementation.
b61cc01c
PE
13169 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
13170 We prefer signed types, and the value cannot exceed the EMACS_INT
13171 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
13172 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
13173 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
13174 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 13175
53b2623d
PE
13176 * indent.c (sane_tab_width): New function.
13177 (current_column, scan_for_column, Findent_to, position_indentation)
13178 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 13179 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 13180
51cab52b 13181 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 13182
f2ed8a70
PE
13183 * lisp.h (lint_assume): New macro.
13184 * composite.c (composition_gstring_put_cache):
13185 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
13186
abe80cc6
PE
13187 * editfns.c, insdel.c:
13188 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 13189
b02c740e
PE
13190 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
13191
ebc96716
PE
13192 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
13193
b4e50fa0 13194 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 13195 Use much-faster test for byte-length change.
311d5d7c 13196 Don't assume string byte-length fits in 'int'.
a4cf38e4 13197 Check that character arg fits in 'int'.
85461888 13198 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 13199
c0c1ee9f
PE
13200 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
13201
a498d7f4
PE
13202 * fns.c (concat): Catch string overflow earlier.
13203 Do not rely on integer wraparound.
13204
51cab52b
PE
13205 * dispextern.h (struct it.overlay_strings_charpos)
13206 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
13207 * xdisp.c (forward_to_next_line_start)
13208 (back_to_previous_visible_line_start)
13209 (reseat_at_next_visible_line_start, next_element_from_buffer):
13210 Don't arbitrarily truncate the value of 'selective' to int.
13211
76031fad
PE
13212 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
13213
5eb55db9
PE
13214 * composite.c: Don't truncate sizes to 'int'.
13215 (composition_gstring_p, composition_reseat_it)
13216 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
13217 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
13218 not EMACS_UINT, for indexes.
5eb55db9 13219
0703a717
PE
13220 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
13221
d6202519
PE
13222 * buffer.c: Include <verify.h>.
13223 (struct sortvec.priority, struct sortstr.priority):
8961a454 13224 Now EMACS_INT, not int.
c20998a7 13225 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
13226 (struct sortstr.size, record_overlay_string)
13227 (struct sortstrlist.size, struct sortlist.used):
13228 Don't truncate size to int.
13229 (record_overlay_string): Check for size-calculation overflow.
d6202519 13230 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 13231
d5a19415
JM
132322011-06-22 Jim Meyering <meyering@redhat.com>
13233
029529ac 13234 Don't leak an XBM-image-sized buffer
d5a19415
JM
13235 * image.c (xbm_load): Free the image buffer after using it.
13236
a9041e6c
PE
132372011-06-21 Paul Eggert <eggert@cs.ucla.edu>
13238
13239 Port to Sun C.
13240 * composite.c (find_automatic_composition): Omit needless 'return 0;'
13241 that Sun C diagnosed.
13242 * fns.c (secure_hash): Fix pointer signedness issue.
13243 * intervals.c (static_offset_intervals): New function.
13244 (offset_intervals): Use it.
13245
7f3f739f
LL
132462011-06-21 Leo Liu <sdl.web@gmail.com>
13247
13248 * deps.mk (fns.o):
13249 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
13250 sha512.h.
13251
13252 * fns.c (secure_hash): Rename from crypto_hash_function and change
13253 the first arg to accept symbols.
5b66d427 13254 (Fsecure_hash): New primitive.
7f3f739f
LL
13255 (syms_of_fns): New symbols.
13256
76147d94
DD
132572011-06-20 Deniz Dogan <deniz@dogan.se>
13258
13259 * process.c (Fset_process_buffer): Clarify return value in
13260 docstring.
13261
7d7d0045
CY
132622011-06-18 Chong Yidong <cyd@stupidchicken.com>
13263
13264 * dispnew.c (add_window_display_history): Use BVAR.
13265
13266 * xdisp.c (debug_method_add): Use BVAR.
13267 (check_window_end, dump_glyph_matrix, dump_glyph)
13268 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
13269
13270 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
13271 Likewise.
13272
13273 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
13274 check till after the cache is created in init_frame_faces.
13275
ff2bc410
SM
132762011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
13277
13278 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
13279
28177add
PE
132802011-06-16 Paul Eggert <eggert@cs.ucla.edu>
13281
dd3482fe
PE
13282 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
13283 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
13284 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
13285
393d71f3 13286 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
13287 * fileio.c (Finsert_file_contents):
13288 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
13289 Remove the old (too-loose) buffer overflow checks.
13290 They weren't needed, since make_gap checks for buffer overflow.
13291 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
13292 The old code merely checked for Emacs fixnum overflow, and relied
13293 on undefined (wraparound) behavior. The new code avoids undefined
13294 behavior, and also checks for ptrdiff_t and/or size_t overflow.
13295
2e6813b0 13296 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
13297 Tune. Don't use wider integers than needed. Don't use alloca.
13298 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 13299
599a9e4f
PE
13300 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
13301
99561444
PE
13302 * insdel.c, lisp.h (buffer_overflow): New function.
13303 (insert_from_buffer_1, replace_range, replace_range_2):
13304 * insdel.c (make_gap_larger):
13305 * editfns.c (Finsert_char):
13306 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
13307
28177add
PE
13308 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
13309
e69dafad
PE
133102011-06-15 Paul Eggert <eggert@cs.ucla.edu>
13311
4baa020d 13312 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 13313
b1c46f02
PE
13314 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
13315 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
13316
e69dafad
PE
13317 * fileio.c: Don't assume EMACS_INT fits in off_t.
13318 (emacs_lseek): New static function.
13319 (Finsert_file_contents, Fwrite_region): Use it.
13320 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
13321
566684ea
PE
13322 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
13323
e6966cd6
PE
13324 * fns.c: Don't overflow int when computing a list length.
13325 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
13326 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
13327 truncation on 64-bit hosts. Check for QUIT every
13328 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
13329 faster and is responsive enough.
13330 (Flength): Report an error instead of overflowing an integer.
13331 (Fsafe_length): Return a float if the value is not representable
13332 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 13333 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 13334 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 13335
dd0b0efb
PE
13336 * alloc.c: Check that resized vectors' lengths fit in fixnums.
13337 (header_size, word_size): New constants.
13338 (allocate_vectorlike): Don't check size overflow here.
13339 (allocate_vector): Check it here instead, since this is the only
13340 caller of allocate_vectorlike that could cause overflow.
13341 Check that the new vector's length is representable as a fixnum.
13342
86fe5cfe
PE
13343 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
13344 The previous code was bogus. For example, next_almost_prime (32)
13345 returned 39, which is undesirable as it is a multiple of 3; and
13346 next_almost_prime (24) returned 25, which is a multiple of 5 so
13347 why was the code bothering to check for multiples of 7?
13348
80e88859
PE
13349 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
13350
4a2f0ad6
PE
13351 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
13352
f66c7cf8
PE
13353 Variadic C functions now count arguments with ptrdiff_t.
13354 This partly undoes my 2011-03-30 change, which replaced int with size_t.
13355 Back then I didn't know that the Emacs coding style prefers signed int.
13356 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
13357 were being counted with int, which may truncate counts on 64-bit
13358 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
13359 * lisp.h (struct Lisp_Subr.function.aMANY)
13360 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
13361 Arg counts are now ptrdiff_t, not size_t.
13362 All variadic functions and their callers changed accordingly.
13363 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
13364 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
13365 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
13366 * callint.c (Fcall_interactively): Check arg count for overflow,
13367 to avoid potential buffer overrun. Use signed char, not 'int',
13368 for 'varies' array, so that we needn't bother to check its size
13369 calculation for overflow.
13370 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
13371 * eval.c (apply_lambda):
13372 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
13373 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
13374 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
13375
a1759b76
PE
13376 * callint.c (Fcall_interactively): Don't use index var as event count.
13377
d96be9fc
PE
13378 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
13379 * mem-limits.h (SIZE): Remove; no longer used.
13380
a690a978 13381 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 13382
578c21e6
PE
13383 Remove unnecessary casts.
13384 * xterm.c (x_term_init):
13385 * xfns.c (x_set_border_pixel):
13386 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
13387 These aren't needed now that we assume ANSI C.
13388
96f53c6c
PE
13389 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
13390 It's more likely to cause problems (due to unsigned overflow)
13391 than to cure them.
13392
83c77d31
PE
13393 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
13394
ee2079f1
PE
13395 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
13396
6da65536
PE
13397 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
13398
7147c4a4
PE
13399 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
13400
193e32d9
PE
13401 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
13402
e5533da6
PE
13403 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
13404
9910e595
PE
13405 GLYPH_CODE_FACE returns EMACS_INT, not int.
13406 * dispextern.h (merge_faces):
13407 * xfaces.c (merge_faces):
01103c44
PE
13408 * xdisp.c (get_next_display_element, next_element_from_display_vector):
13409 Don't assume EMACS_INT fits in int.
9910e595 13410
2638320e
PE
13411 * character.h (CHAR_VALID_P): Remove unused parameter.
13412 * fontset.c, lisp.h, xdisp.c: All uses changed.
13413
045eb8d9
PE
13414 * editfns.c (Ftranslate_region_internal): Omit redundant test.
13415
c1f134b5
PE
13416 * fns.c (concat): Minor tuning based on overflow analysis.
13417 This doesn't fix any bugs. Use int to hold character, instead
13418 of constantly refetching from Emacs object. Use XFASTINT, not
13419 XINT, for value known to be a character. Don't bother comparing
13420 a single byte to 0400, as it's always less.
13421
395fcb93 13422 * floatfns.c (Fexpt):
327eeec8
PE
13423 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
13424
abbd3d23
PE
13425 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
13426 for characters.
13427
684a03ef
PE
13428 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
13429
0fed43f3
PE
13430 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
13431 Without this fix, on a 64-bit host (aset S 0 4294967386) would
13432 incorrectly succeed when S was a string, because 4294967386 was
13433 truncated before it was used.
13434
8fd02eb7
PE
13435 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
13436 Otherwise, an out-of-range integer could cause undefined behavior
13437 on a 64-bit host.
13438
f8c86b69
PE
13439 * composite.c: Use int, not EMACS_INT, for characters.
13440 (fill_gstring_body, composition_compute_stop_pos): Use int, not
13441 EMACS_INT, for values that are known to be in character range.
13442 This doesn't fix any bugs but is the usual style inside Emacs and
13443 may generate better code on 32-bit machines.
13444
34206dd2
PE
13445 Make sure a 64-bit char is never passed to ENCODE_CHAR.
13446 This is for reasons similar to the recent CHAR_STRING fix.
13447 * charset.c (Fencode_char): Check that character arg is actually
13448 a character. Pass an int to ENCODE_CHAR.
13449 * charset.h (ENCODE_CHAR): Verify that the character argument is no
13450 wider than 'int', as a compile-time check to prevent future regressions
13451 in this area.
13452
c5958d4c 13453 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
13454
13455 Make sure a 64-bit char is never passed to CHAR_STRING.
13456 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
13457 by silently ignoring the top 32 bits, allowing some values
13458 that were far too large to be valid characters.
13459 * character.h: Include <verify.h>.
13460 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
13461 arguments are no wider than unsigned, as a compile-time check
13462 to prevent future regressions in this area.
13463 * data.c (Faset):
01103c44 13464 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
13465 (Fsubst_char_in_region):
13466 * fns.c (concat):
13467 * xdisp.c (decode_mode_spec_coding):
13468 Adjust to CHAR_STRING's new requirement.
13469 * editfns.c (Finsert_char, Fsubst_char_in_region):
13470 * fns.c (concat): Check that character args are actually
13471 characters. Without this test, these functions did the wrong
13472 thing with wildly out-of-range values on 64-bit hosts.
13473
d37ca623
PE
13474 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
13475 These casts should not be needed on 32-bit hosts, either.
13476 * keyboard.c (read_char):
13477 * lread.c (Fload): Remove casts to unsigned.
13478
ea204efb
PE
13479 * lisp.h (UNSIGNED_CMP): New macro.
13480 This fixes comparison bugs on 64-bit hosts.
13481 (ASCII_CHAR_P): Use it.
13482 * casefiddle.c (casify_object):
01103c44 13483 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
13484 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
13485 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
13486 * dispextern.h (FACE_FROM_ID):
13487 * keyboard.c (read_char): Use UNSIGNED_CMP.
13488
41cb286c
PE
13489 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
13490 not to EMACS_INT, to avoid GCC warning.
13491
4a1b9832
PE
13492 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
13493
55daad71
PE
13494 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
13495 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
13496 isn't needed on 32-bit machines.
8f95c75c 13497
01103c44
PE
13498 * buffer.c (Fgenerate_new_buffer_name):
13499 Use EMACS_INT for count, not int.
0ceccced 13500 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
13501
13502 * data.c (Qcompiled_function): Now static.
13503
c6f072e7
PE
13504 * window.c (window_body_lines): Now static.
13505
20ce5912
PE
13506 * image.c (gif_load): Rename local to avoid shadowing.
13507
9c4c5f81
PE
13508 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
13509 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
13510 * alloc.c (make_save_value): Integer argument is now of type
13511 ptrdiff_t, not int.
13512 (mark_object): Use ptrdiff_t, not int.
13513 * lisp.h (pD): New macro.
13514 * print.c (print_object): Use it.
13515
c0c5c8ae
PE
13516 * alloc.c: Use EMACS_INT, not int, to count objects.
13517 (total_conses, total_markers, total_symbols, total_vector_size)
13518 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
13519 (total_free_floats, total_floats, total_free_intervals)
13520 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
13521 Now EMACS_INT, not int. All uses changed.
13522 (Fgarbage_collect): Compute overall total using a double, so that
13523 integer overflow is less likely to be a problem. Check for overflow
13524 when converting back to an integer.
5a25e253
PE
13525 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
13526 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
13527 These were 'int' variables that could overflow on 64-bit hosts;
13528 they were never used, so remove them instead of repairing them.
211a0b2a 13529 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
13530 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
13531 Previously, this ceilinged at INT_MAX, but that doesn't work on
13532 64-bit machines.
e46bb31a 13533 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 13534
c78baabf 13535 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 13536 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
13537 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
13538 when a (possibly-narrower) signed value would do just as well.
13539 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 13540
c9d624c6
PE
13541 * alloc.c: Catch some string size overflows that we were missing.
13542 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
13543 for convenience in STRING_BYTES_MAX.
13544 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
13545 The definition here is exact; the one in lisp.h was approximate.
13546 (allocate_string_data): Check for string overflow. This catches
13547 some instances we weren't catching before. Also, it catches
13548 size_t overflow on (unusual) hosts where SIZE_MAX <= min
13549 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
13550 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 13551
c9d624c6
PE
13552 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
13553 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 13554 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 13555
353032ce
PE
13556 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
13557
2bccce07
PE
13558 * alloc.c (Fmake_string): Check for out-of-range init.
13559
0ac30604
SM
135602011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
13561
13562 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
13563
c195f2de
JD
135642011-06-14 Jan Djärv <jan.h.d@swipnet.se>
13565
13566 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
13567 xg_get_default_scrollbar_width.
13568
13569 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
13570 (int_gtk_range_get_value): Move to the scroll bar part of the file.
13571 (style_changed_cb): Call update_theme_scrollbar_width and call
13572 x_set_scroll_bar_default_width and xg_frame_set_char_size for
13573 all frames (Bug#8505).
13574 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
13575 Call gtk_window_set_resizable if HAVE_GTK3.
13576 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
13577 and height if HAVE_GTK3 (Bug#8505).
13578 (scroll_bar_width_for_theme): New variable.
13579 (update_theme_scrollbar_width): New function.
13580 (xg_get_default_scrollbar_width): Move code to
13581 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
13582 (xg_initialize): Call update_theme_scrollbar_width.
13583
13584 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
13585
13586 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
13587
e10ac9f1
MR
135882011-06-12 Martin Rudalics <rudalics@gmx.at>
13589
13590 * frame.c (make_frame): Call other_buffer_safely instead of
13591 other_buffer.
13592
13593 * window.c (temp_output_buffer_show): Call display_buffer with
13594 second argument Vtemp_buffer_show_specifiers and reset latter
13595 immediately after the call.
13596 (Vtemp_buffer_show_specifiers): New variable.
13597 (auto_window_vscroll_p, next_screen_context_lines)
13598 (Vscroll_preserve_screen_position): Remove leading asterisks from
13599 doc-strings.
13600
2d3c217e 136012011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 13602
7b7f97e8 13603 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
13604 * buffer.c (Qclone_number): Remove for now, as it's unused.
13605 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
13606 (record_buffer): Remove unused local.
13607 * frame.c (other_visible_frames, frame_buffer_list): Now static.
13608 (set_frame_buffer_list): Remove; unused.
13609 * frame.h (other_visible_frames): Remove decl.
13610 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
13611 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
13612 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
13613 if HAVE_GPM.
13614 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
13615 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
13616 Define only if HAVE_GPM.
13617 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
13618 (update_hints_inhibit): Remove; never set. All uses removed.
13619 * widgetprv.h (emacsFrameClassRec): Remove decl.
13620 * window.c (delete_deletable_window): Now returns void, since it
13621 wasn't returning anything.
13622 (compare_window_configurations): Remove unused locals.
13623 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
13624 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
13625 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
13626 the same widths as pointers. This follows up on the 2011-05-06 patch.
13627 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
13628 * xterm.h: Likewise.
13629 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
13630
1384b89e
JB
136312011-06-12 Juanma Barranquero <lekktu@gmail.com>
13632
13633 * makefile.w32-in: Update dependencies.
13634 (LISP_H): Add lib/intprops.h.
13635
1100a63c
CY
136362011-06-11 Chong Yidong <cyd@stupidchicken.com>
13637
13638 * image.c (gif_load): Add animation frame delay to the metadata.
13639 (syms_of_image): Use DEFSYM. New symbol `delay'.
13640
6198ccd0
MR
136412011-06-11 Martin Rudalics <rudalics@gmx.at>
13642
13643 * window.c (delete_deletable_window): Re-add.
13644 (Fset_window_configuration): Rewrite to handle dead buffers and
13645 consequently deletable windows.
13646 (window_tree, Fwindow_tree): Remove. Supply functionality in
13647 window.el.
13648 (compare_window_configurations): Simplify code.
13649
b6e3633c
AS
136502011-06-11 Andreas Schwab <schwab@linux-m68k.org>
13651
1ab0dee5
AS
13652 * image.c (imagemagick_load_image): Fix type mismatch.
13653 (Fimagemagick_types): Likewise.
13654
b6e3633c
AS
13655 * window.h (replace_buffer_in_windows): Declare.
13656
9397e56f
MR
136572011-06-11 Martin Rudalics <rudalics@gmx.at>
13658
13659 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
13660 Qclone_number. Remove external declaration of Qdelete_window.
13661 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
13662 code.
640c8776
SM
13663 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
13664 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
13665 (Fother_buffer): Rewrite doc-string. Major rewrite for new
13666 buffer list implementation.
13667 (other_buffer_safely): New function.
13668 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
13669 calls to replace_buffer_in_windows and
13670 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
13671 if allowed.
13672 (record_buffer): Inhibit quitting and rewrite using quittable
13673 functions. Run Qbuffer_list_update_hook if allowed.
13674 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
13675 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
13676 Move switch-to-buffer to window.el.
9397e56f
MR
13677 (bury-buffer): Move to window.el.
13678 (Vbuffer_list_update_hook): New variable.
13679
13680 * lisp.h (other_buffer_safely): Add prototype in buffer.c
13681 section.
13682
13683 * window.h (resize_frame_windows): Move up in code.
13684 (Fwindow_frame): Remove EXFUN.
13685 (replace_buffer_in_all_windows): Remove prototype.
13686 (replace_buffer_in_windows_safely): Add prototype.
13687
13688 * window.c: Declare Qdelete_window static again. Move down
13689 declaration of select_count.
13690 (Fnext_window, Fprevious_window): Rewrite doc-strings.
13691 (Fother_window): Move to window.el.
13692 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
13693 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
13694 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
13695 window.el.
13696 (replace_buffer_in_windows): Implement by calling
13697 Qreplace_buffer_in_windows.
13698 (replace_buffer_in_all_windows): Remove with some functionality
13699 moved into replace_buffer_in_windows_safely.
13700 (replace_buffer_in_windows_safely): New function.
13701 (select_window_norecord, select_frame_norecord): Move in front
13702 of run_window_configuration_change_hook. Remove now obsolete
13703 declarations.
640c8776
SM
13704 (Fset_window_buffer): Rewrite doc-string.
13705 Call Qrecord_window_buffer.
9397e56f
MR
13706 (keys_of_window): Move binding for other-window to window.el.
13707
b50691aa
CY
137082011-06-11 Chong Yidong <cyd@stupidchicken.com>
13709
13710 * dispextern.h (struct image): Replace data member, whose int_val
13711 and ptr_val fields were not used by anything, with a single
13712 lisp_val object.
13713
13714 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
13715 (gif_clear_image, gif_load, imagemagick_load_image)
13716 (gs_clear_image, gs_load): Callers changed.
13717
3f754b86
PE
137182011-06-10 Paul Eggert <eggert@cs.ucla.edu>
13719
cca69397
PE
13720 * buffer.h: Include <time.h>, for time_t.
13721 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
13722
109e28d0
PE
13723 Fix minor problems found by static checking.
13724
60737f02
PE
13725 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
13726
4b66faf3
PE
13727 Make identifiers static if they are not used in other modules.
13728 * data.c (Qcompiled_function, Qframe, Qvector):
13729 * image.c (QimageMagick, Qsvg):
13730 * minibuf.c (Qmetadata):
13731 * window.c (resize_window_check, resize_root_window): Now static.
13732 * window.h (resize_window_check, resize_root_window): Remove decls.
13733
109e28d0
PE
13734 * window.c (window_deletion_count, delete_deletable_window):
13735 Remove; unused.
46a4ce9e
PE
13736 (window_body_lines): Now static.
13737 (Fdelete_other_windows_internal): Mark vars as initialized.
13738 Make sure 'resize_failed' is initialized.
13739 (run_window_configuration_change_hook): Rename local to avoid shadowing.
13740 (resize_window_apply): Remove unused local.
13741 * window.h (delete_deletable_window): Remove decl.
13742
109e28d0 13743 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
13744 (imagemagick_load_image): Fix pointer signedness problem by changing
13745 last arg from unsigned char * to char *. All uses changed.
13746 Also, fix a local for similar reasons.
13747 Remove unused locals. Remove locals to avoid shadowing.
13748 (fn_rsvg_handle_free): Remove; unused.
13749 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 13750 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 13751
3f754b86
PE
13752 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
13753
2547adb1
CY
137542011-06-10 Chong Yidong <cyd@stupidchicken.com>
13755
13756 * image.c (gif_load): Fix omitted cast error introduced by
13757 2011-06-06 change.
13758
2c8e37d4
MR
137592011-06-10 Martin Rudalics <rudalics@gmx.at>
13760
13761 * window.h (resize_proportionally, orig_total_lines)
13762 (orig_top_line): Remove from window structure.
13763 (set_window_height, set_window_width, change_window_heights)
13764 (Fdelete_window): Remove prototypes.
13765 (resize_frame_windows): Remove duplicate declaration.
13766
440a42e3
EZ
137672011-06-10 Eli Zaretskii <eliz@gnu.org>
13768
13769 * window.h (resize_frame_windows, resize_window_check)
13770 (delete_deletable_window, resize_root_window)
13771 (resize_frame_windows): Declare prototypes.
13772
13773 * window.c (resize_window_apply): Make definition be "static" to
13774 match the prototype.
13775
562dd5e9
MR
137762011-06-10 Martin Rudalics <rudalics@gmx.at>
13777
13778 * window.c: Remove declarations of Qwindow_size_fixed,
13779 window_min_size_1, window_min_size_2, window_min_size,
13780 size_window, window_fixed_size_p, enlarge_window, delete_window.
13781 Remove static from declaration of Qdelete_window, it's
13782 temporarily needed by Fbury_buffer.
13783 (replace_window): Don't assign orig_top_line and
13784 orig_total_lines.
13785 (Fdelete_window, delete_window): Remove. Window deletion is
13786 handled by window.el.
640c8776
SM
13787 (window_loop): Remove DELETE_OTHER_WINDOWS case.
13788 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
13789 (Fdelete_other_windows): Remove. Deleting other windows is
13790 handled by window.el.
13791 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
13792 handled in window.el.
13793 (window_min_size_2, window_min_size_1, window_min_size): Remove.
13794 Window minimum sizes are handled in window.el.
13795 (shrink_windows, size_window, set_window_height)
13796 (set_window_width, change_window_heights, window_height)
13797 (window_width, CURBEG, CURSIZE, enlarge_window)
13798 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
13799 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
13800 handled in window.el.
13801 (make_dummy_parent): Rename to make_parent_window and give it a
13802 second argument horflag.
13803 (make_window): Don't set resize_proportionally any more.
13804 (Fsplit_window): Remove. Windows are split in window.el.
13805 (save_restore_action, save_restore_orig_size)
13806 (shrink_window_lowest_first, save_restore_orig_size): Remove.
13807 Resize mini windows in window.el.
13808 (grow_mini_window, shrink_mini_window): Implement by calling
13809 Qresize_root_window_vertically, resize_window_check and
13810 resize_window_apply.
640c8776
SM
13811 (saved_window, Fset_window_configuration, save_window_save):
13812 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
13813 resize_proportionally.
13814 (window_min_height, window_min_width): Move to window.el.
13815 (keys_of_window): Move bindings for delete-other-windows,
13816 split-window, delete-window and enlarge-window to window.el.
13817
13818 * buffer.c: Temporarily extern Qdelete_window.
13819 (Fbury_buffer): Temporarily call Qdelete_window instead of
13820 Fdelete_window (Fbury_buffer will move to window.el soon).
13821
13822 * frame.c (set_menu_bar_lines_1): Remove code handling
13823 orig_top_line and orig_total_lines.
13824
13825 * dispnew.c (adjust_frame_glyphs_initially): Don't use
13826 set_window_height but set heights directly.
13827 (change_frame_size_1): Use resize_frame_windows.
13828
13829 * xdisp.c (init_xdisp): Don't use set_window_height but set
13830 heights directly.
13831
640c8776
SM
13832 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
13833 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
13834 run_window_configuration_change_hook.
13835
13836 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
13837 instead of change_window_heights and run
13838 run_window_configuration_change_hook.
13839
1a13852e
MR
138402011-06-09 Martin Rudalics <rudalics@gmx.at>
13841
13842 * window.c (replace_window): Rename second argument REPLACEMENT to
13843 NEW. New third argument SETFLAG. Rewrite.
13844 (delete_window, make_dummy_parent): Call replace_window with
13845 third argument 1.
13846 (window_list_1): Move down in code.
13847 (run_window_configuration_change_hook): Move set_buffer part
13848 before select_frame_norecord part in order to unwind correctly.
13849 Rename count1 to count.
13850 (recombine_windows, delete_deletable_window, resize_root_window)
13851 (Fdelete_other_windows_internal)
13852 (Frun_window_configuration_change_hook, make_parent_window)
13853 (resize_window_check, resize_window_apply, Fresize_window_apply)
13854 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
13855 (Fdelete_window_internal, Fresize_mini_window_internal):
13856 New functions.
1a13852e
MR
13857 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
13858
f3d1777e
MR
138592011-06-08 Martin Rudalics <rudalics@gmx.at>
13860
496e208e
MR
13861 * window.h (window): Add some new members to window structure -
13862 normal_lines, normal_cols, new_total, new_normal, clone_number,
13863 splits, nest, prev_buffers, next_buffers.
13864 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 13865 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 13866
f3d1777e
MR
13867 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
13868 Remove.
496e208e
MR
13869 (make_dummy_parent): Set new members of windows structure.
13870 (make_window): Move down in code. Handle new members of window
13871 structure.
13872 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
13873 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
13874 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
13875 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
13876 (Fset_window_next_buffers, Fset_window_clone_number):
13877 New functions.
496e208e
MR
13878 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
13879 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
13880 Doc-string fixes.
13881 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
13882 Argument WINDOW can be now internal window too.
13883 (Fwindow_use_time): Move up in code.
13884 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
13885 Rewrite doc-string.
13886 (Fset_window_configuration, saved_window)
13887 (Fcurrent_window_configuration, save_window_save): Handle new
13888 members of window structure.
b9e809c2
MR
13889 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
13890 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
13891 (syms_of_window): New Lisp objects Qrecord_window_buffer,
13892 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
13893 Qget_mru_window, Qresize_root_window,
13894 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
13895 Qauto_buffer_name; staticpro them.
f3d1777e 13896
abde8f8c
MR
138972011-06-07 Martin Rudalics <rudalics@gmx.at>
13898
13899 * window.c (Fwindow_total_size, Fwindow_left_column)
13900 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
13901 (Fwindow_list_1): New functions.
13902 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
13903 (Fwindow_width, Fscroll_left, Fscroll_right):
13904 Use window_body_cols instead of window_box_text_cols.
13905 (delete_window, Fset_window_configuration):
13906 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
13907 (delete_all_subwindows): Take a window as argument and not a
13908 structure. Rewrite.
190b47e6
MR
13909 (window_loop): Remove handling of GET_LRU_WINDOW and
13910 GET_LARGEST_WINDOW.
13911 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
13912
13913 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
13914 window_box_text_cols. delete_all_subwindows now takes a
13915 Lisp_Object as argument.
abde8f8c 13916
640c8776
SM
13917 * indent.c (compute_motion, Fcompute_motion):
13918 Use window_body_cols instead of window_box_text_cols.
abde8f8c 13919
fa8a67e6
MR
13920 * frame.c (delete_frame): Call delete_all_subwindows with root
13921 window as argument.
13922
a54e3482
DC
139232011-06-07 Daniel Colascione <dan.colascione@gmail.com>
13924
13925 * fns.c (Fputhash): Document return value.
13926
60002bf5
CY
139272011-06-06 Chong Yidong <cyd@stupidchicken.com>
13928
13929 * image.c (gif_load): Implement gif89a spec "no disposal" method.
13930
0c671da6 139312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 13932
b862a52a 13933 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 13934
be44ca6c
PE
13935 Check for overflow when converting integer to cons and back.
13936 * charset.c (Fdefine_charset_internal, Fdecode_char):
13937 Use cons_to_unsigned to catch overflow.
13938 (Fencode_char): Use INTEGER_TO_CONS.
13939 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
13940 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
13941 * data.c (long_to_cons, cons_to_long): Remove.
13942 (cons_to_unsigned, cons_to_signed): New functions.
13943 These signal an error for invalid or out-of-range values.
13944 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
13945 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
13946 * font.c (Ffont_variation_glyphs):
13947 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
13948 * lisp.h: Include <intprops.h>.
13949 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
13950 (cons_to_signed, cons_to_unsigned): New decls.
13951 (long_to_cons, cons_to_long): Remove decls.
13952 * undo.c (record_first_change): Use INTEGER_TO_CONS.
13953 (Fprimitive_undo): Use CONS_TO_INTEGER.
13954 * xfns.c (Fx_window_property): Likewise.
13955 * xselect.c: Include <limits.h>.
13956 (x_own_selection, selection_data_to_lisp_data):
13957 Use INTEGER_TO_CONS.
13958 (x_handle_selection_request, x_handle_selection_clear)
13959 (x_get_foreign_selection, Fx_disown_selection_internal)
13960 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
13961 (lisp_data_to_selection_data): Use cons_to_unsigned.
13962 (x_fill_property_data): Use cons_to_signed.
13963 Report values out of range.
13964
d1f3d2af
PE
13965 Check for buffer and string overflow more precisely.
13966 * buffer.h (BUF_BYTES_MAX): New macro.
13967 * lisp.h (STRING_BYTES_MAX): New macro.
13968 * alloc.c (Fmake_string):
13969 * character.c (string_escape_byte8):
13970 * coding.c (coding_alloc_by_realloc):
13971 * doprnt.c (doprnt):
13972 * editfns.c (Fformat):
13973 * eval.c (verror):
13974 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
13975 since they may not be the same number.
13976 * editfns.c (Finsert_char):
13977 * fileio.c (Finsert_file_contents):
13978 Likewise for BUF_BYTES_MAX.
13979
dd52fcea
PE
13980 * image.c: Use ptrdiff_t, not int, for sizes.
13981 (slurp_file): Switch from int to ptrdiff_t.
13982 All uses changed.
13983 (slurp_file): Check that file size fits in both size_t (for
13984 malloc) and ptrdiff_t (for sanity and safety).
13985
7f9bbdbb
PE
13986 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
13987 if b->modtime has its maximal value.
13988
dfe18f82
PE
13989 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
13990
84acfcf0
PE
13991 Don't assume time_t can fit into int.
13992 * buffer.h (struct buffer.modtime): Now time_t, not int.
13993 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
13994 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
13995
ccd9a01a
PE
13996 Minor fixes for signed vs unsigned integers.
13997 * character.h (MAYBE_UNIFY_CHAR):
13998 * charset.c (maybe_unify_char):
13999 * keyboard.c (read_char, reorder_modifiers):
14000 XINT -> XFASTINT, since the integer must be nonnegative.
14001 * ftfont.c (ftfont_spec_pattern):
14002 * keymap.c (access_keymap, silly_event_symbol_error):
14003 XUINT -> XFASTINT, since the integer must be nonnegative.
14004 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
14005 since it makes no difference and we prefer signed.
14006 * keyboard.c (record_char): Use XUINT when all the neighbors do.
14007 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
14008 nonnegative.
14009
d6d100dd
SM
140102011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
14011
14012 * window.h (Fwindow_frame): Declare.
14013
2b6148e4
PE
140142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14015
14016 * alloc.c: Simplify handling of large-request failures (Bug#8800).
14017 (SPARE_MEMORY): Always define.
14018 (LARGE_REQUEST): Remove.
14019 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
14020
f230ecc9
MR
140212011-06-06 Martin Rudalics <rudalics@gmx.at>
14022
727e958e
MR
14023 * lisp.h: Move EXFUNS for Fframe_root_window,
14024 Fframe_first_window and Fset_frame_selected_window to window.h.
14025
14026 * window.h: Move EXFUNS for Fframe_root_window,
14027 Fframe_first_window and Fset_frame_selected_window here from
14028 lisp.h.
14029
14030 * frame.c (Fwindow_frame, Fframe_first_window)
14031 (Fframe_root_window, Fframe_selected_window)
14032 (Fset_frame_selected_window): Move to window.c.
14033 (Factive_minibuffer_window): Move to minibuf.c.
14034 (Fother_visible_frames_p): New function.
14035
14036 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
14037
f230ecc9
MR
14038 * window.c (decode_window, decode_any_window): Move up in code.
14039 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
14040 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
14041 (Fwindow_buffer): Move up and rewrite doc-string.
14042 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
14043 (Fwindow_prev): New functions.
727e958e
MR
14044 (Fwindow_frame): Move here from frame.c. Accept any window as
14045 argument.
14046 (Fframe_root_window, Fframe_first_window)
14047 (Fframe_selected_window): Move here from frame.c. Accept frame
14048 or arbitrary window as argument. Update doc-strings.
14049 (Fminibuffer_window): Move up in code.
14050 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
14051 (Fset_frame_selected_window): Move here from frame.c.
14052 Marginal rewrite.
727e958e
MR
14053 (Fselected_window, select_window, Fselect_window): Move up in
14054 code. Minor doc-string fixes.
f230ecc9 14055
4d09bcf6
PE
140562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14057
14058 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
14059 Do not assume that spare memory exists; that assumption is valid
14060 only if SYSTEM_MALLOC.
14061 (LARGE_REQUEST): New macro, so that the issue of large requests
14062 is separated from the issue of spare memory.
14063
810928a2
AS
140642011-06-05 Andreas Schwab <schwab@linux-m68k.org>
14065
172418ad
AS
14066 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
14067 format. (Bug#8806)
14068
43f862f7
AS
14069 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
14070
810928a2
AS
14071 * xfns.c (x_set_scroll_bar_default_width): Move declarations
14072 before statements.
14073
a059fe24
JD
140742011-06-05 Jan Djärv <jan.h.d@swipnet.se>
14075
14076 * gtkutil.c (xg_get_default_scrollbar_width): New function.
14077
14078 * gtkutil.h: Declare xg_get_default_scrollbar_width.
14079
14080 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
14081 min width by calling x_set_scroll_bar_default_width (Bug#8505).
14082
989bf368
JB
140832011-06-05 Juanma Barranquero <lekktu@gmail.com>
14084
14085 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
14086
4b80f674
CY
140872011-06-04 Chong Yidong <cyd@stupidchicken.com>
14088
14089 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
14090 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
14091 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
14092 New error handlers.
4b80f674
CY
14093 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
14094 Obey Vx_select_enable_clipboard_manager. Catch errors in
14095 x_clipboard_manager_save (Bug#8779).
14096 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 14097 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 14098
99a33b77 140992011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
14100
14101 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
14102
99a33b77 141032011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
14104
14105 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
14106 in the current matrix if keep_current_p is non-zero.
14107
8264569d
EZ
141082011-06-04 Eli Zaretskii <eliz@gnu.org>
14109
14110 * bidi.c (bidi_level_of_next_char): Fix last change.
14111
57f97249
EZ
141122011-06-03 Eli Zaretskii <eliz@gnu.org>
14113
fec2107c 14114 Support bidi reordering of text covered by display properties.
57f97249 14115
fec2107c
EZ
14116 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
14117 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
14118 (bidi_cache_search, bidi_cache_iterator_state)
14119 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
14120 (bidi_level_of_next_char, bidi_move_to_visually_next):
14121 Support character positions inside a run of characters covered by a
fec2107c
EZ
14122 display string.
14123 (bidi_paragraph_init, bidi_resolve_explicit_1)
14124 (bidi_level_of_next_char): Call bidi_fetch_char and
14125 bidi_fetch_char_advance instead of FETCH_CHAR and
14126 FETCH_CHAR_ADVANCE.
14127 (bidi_init_it): Initialize new members.
14128 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
14129 definitions.
14130 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
14131 instead of using explicit *_CHAR codes.
d6d100dd
SM
14132 (bidi_resolve_explicit, bidi_resolve_weak):
14133 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
14134 bidirectional text is supported only in multibyte buffers.
14135 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
14136 it to initialize the frame_window_p member of struct bidi_it.
14137 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
14138 (bidi_resolve_explicit, bidi_resolve_weak)
14139 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
14140 bidi_it->nchars is non-positive.
14141 (bidi_level_of_next_char): Don't try to lookup the cache for the
14142 next/previous character if nothing is cached there yet, or if we
14143 were just reseat()'ed to a new position.
c40e2fb2 14144
0e14fe90
EZ
14145 * xdisp.c (set_cursor_from_row): Set start and stop points
14146 according to the row's direction when priming the loop that looks
14147 for the glyph on which to display cursor.
14148 (single_display_spec_intangible_p): Function deleted.
14149 (display_prop_intangible_p): Reimplement to call
14150 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
14151 Accept 3 additional arguments needed by handle_display_spec.
14152 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
14153 values: lists, `(when COND...)' forms, etc.
14154 (single_display_spec_string_p): Support property values that are
14155 lists with the argument STRING its top-level element.
14156 (display_prop_string_p): Fix the condition for processing a
14157 property that is a list to be consistent with handle_display_spec.
fec2107c 14158 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
14159 last portion of handle_display_prop.
14160 (compute_display_string_pos): Accept additional argument
14161 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
14162 value of a `display' property is a "replacing spec".
14163 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
14164 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
14165 the display property, but just return a value indicating whether
14166 the display property will replace the characters it covers.
14167 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
14168 frame_window_p members of struct bidi_it.
d6d100dd
SM
14169 (compute_display_string_pos, compute_display_string_end):
14170 New functions.
fec2107c
EZ
14171 (push_it): Accept second argument POSITION, where pop_it should
14172 jump to continue iteration.
14173 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 14174
fec2107c
EZ
14175 * keyboard.c (adjust_point_for_property): Adjust the call to
14176 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
14177
14178 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
14179 (bidi_init_it): Update prototypes.
14180 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
14181 (compute_display_string_pos, compute_display_string_end):
14182 Declare prototypes.
fec2107c
EZ
14183 (struct bidi_it): New members nchars and disp_pos. ch_len is now
14184 EMACS_INT.
fc6f18ce 14185
40087514 141862011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 14187
57f53182
PE
14188 Malloc failure behavior now depends on size of allocation.
14189 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
14190 * lisp.h: Change signatures accordingly.
14191 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
14192 All callers changed. (Bug#8762)
14193
14194 * gnutls.c: Use Emacs's memory allocators.
14195 Without this change, the gnutls library would invoke malloc etc.
14196 directly, which causes problems on non-SYNC_INPUT hosts, and which
14197 runs afoul of improving memory_full behavior. (Bug#8761)
14198 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
14199 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
14200 xfree instead of the default malloc, realloc, free.
14201 (Fgnutls_boot): No need to check for memory allocation failure,
14202 since xmalloc does that for us.
14203
ac32cd99 14204 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
14205 * category.c (hash_get_category_set):
14206 * ccl.c (ccl_driver):
14207 * charset.c (Fdefine_charset_internal):
14208 * charset.h (struct charset.hash_index):
14209 * composite.c (get_composition_id, gstring_lookup_cache)
14210 (composition_gstring_put_cache):
14211 * composite.h (struct composition.hash_index):
14212 * dispextern.h (struct image.hash):
14213 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
14214 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
14215 (hashfn_equal, hashfn_user_defined, make_hash_table)
14216 (maybe_resize_hash_table, hash_lookup, hash_put)
14217 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
14218 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
14219 (Fsxhash, Fgethash, Fputhash, Fmaphash):
14220 * image.c (make_image, search_image_cache, lookup_image)
14221 (xpm_put_color_table_h):
14222 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 14223 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 14224 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 14225 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
14226 * alloc.c (allocate_vectorlike):
14227 Check for overflow in vector size calculations.
14228 * ccl.c (ccl_driver):
14229 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
14230 * fns.c, image.c: Remove unnecessary static decls that would otherwise
14231 need to be updated by these changes.
40087514
PE
14232 * fns.c (make_hash_table, maybe_resize_hash_table):
14233 Check for integer overflow with large hash tables.
0de4bb68
PE
14234 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
14235 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
14236 (SXHASH_REDUCE): New macro.
14237 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
14238 Use it instead of discarding useful hash info with large hash values.
14239 (sxhash_float): New function.
14240 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
14241 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
14242 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
14243 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
14244 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
14245 Adjust signatures to match updated version of code.
14246 (consing_since_gc): Now EMACS_INT, since a single hash table can
14247 use more than INT_MAX bytes.
14248
698d32e2
DN
142492011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
14250
14251 Make it possible to build with GCC-4.6+ -O2 -flto.
14252
14253 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
14254
fd6fa53f
SM
142552011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
14256
14257 * minibuf.c (get_minibuffer, read_minibuf_unwind):
14258 Call minibuffer-inactive-mode.
14259
864db017
JB
142602011-05-31 Juanma Barranquero <lekktu@gmail.com>
14261
14262 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
14263 Update dependencies.
14264
2ad0baf4
DN
142652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14266
14267 * data.c (init_data): Remove code for UTS, this system is not
14268 supported anymore.
14269
4fcc2638
DN
142702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14271
14272 Don't force ./temacs to start in terminal mode.
14273
14274 * frame.c (make_initial_frame): Initialize faces in all cases, not
14275 only when CANNOT_DUMP is defined.
14276 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
14277
c56e0fd5
DN
142782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14279
14280 * dispnew.c (add_window_display_history): Use const for the string
14281 pointer. Remove declaration, not needed.
14282
333d54da 142832011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 14284
55d4c1b2 14285 Use 'inline', not 'INLINE'.
333d54da 14286 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
14287 * alloc.c, fontset.c (INLINE): Remove.
14288 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
14289 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
14290 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
14291 * gmalloc.c (register_heapinfo): Use inline unconditionally.
14292 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
14293
738db178
DN
142942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14295
14296 Make it possible to run ./temacs.
14297
14298 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
14299 syms_of_callproc does the same thing. Remove test for
14300 "initialized", do it in the caller.
14301 * emacs.c (main): Avoid calling set_initial_environment when dumping.
14302
620c53a6
SM
143032011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
14304
14305 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
14306 (read_minibuf): Use get_minibuffer.
14307 (syms_of_minibuf): Use DEFSYM.
14308 (Qmetadata): New var.
14309 * data.c (Qbuffer): Don't make it static.
14310 (syms_of_data): Use DEFSYM.
14311
e003a292
PE
143122011-05-31 Paul Eggert <eggert@cs.ucla.edu>
14313
14314 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
14315 (CCL_CODE_MIN): New macro.
14316
ed008a6d
PE
143172011-05-30 Paul Eggert <eggert@cs.ucla.edu>
14318
3687c2ef
PE
14319 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
14320
ed008a6d
PE
14321 * eval.c (Qdebug): Now static.
14322 * lisp.h (Qdebug): Remove decl. This reverts a part of the
14323 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
14324 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
14325
d66c4c7c
CY
143262011-05-29 Chong Yidong <cyd@stupidchicken.com>
14327
14328 * image.c: Various fixes to ImageMagick code comments.
14329 (Fimagemagick_types): Doc fix.
14330
5fbc2025
PE
143312011-05-29 Paul Eggert <eggert@cs.ucla.edu>
14332
0196f88a
PE
14333 Minor fixes prompted by GCC 4.6.0 warnings.
14334
14335 * xselect.c (converted_selections, conversion_fail_tag): Now static.
14336
5fbc2025
PE
14337 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
14338 (x_clipboard_manager_save_all): Move extern decl to ...
14339 * xterm.h: ... here, so that it can be checked for consistency.
14340
1dd3c2d9
CY
143412011-05-29 Chong Yidong <cyd@stupidchicken.com>
14342
14343 * xselect.c (x_clipboard_manager_save_frame)
14344 (x_clipboard_manager_save_all): New functions.
14345 (Fx_clipboard_manager_save): Lisp function deleted.
14346
14347 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
14348 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
14349
14350 * xterm.h: Update prototype.
14351
5ba6571d
WX
143522011-05-28 William Xu <william.xwl@gmail.com>
14353
14354 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
14355 exiting (Bug#8239).
14356
3eaff834
JM
143572011-05-28 Jim Meyering <meyering@redhat.com>
14358
e1900994 14359 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
14360 * fns.c (to_uchar): Define.
14361 (crypto_hash_function): Use it to convert some newly-signed
14362 variables to unsigned, to avoid sign-extension bugs. For example,
14363 without this change, (md5 "truc") would evaluate to
14364 45723a2aff78ff4fff7fff1114760e62 rather than the expected
14365 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 14366 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 14367
0f6990a7
PE
143682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14369
14370 Integer overflow fixes.
c8a9ca5a 14371
08686060
PE
14372 * dbusbind.c: Serial number integer overflow fixes.
14373 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
14374 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
14375 to hold a serial number that is too large for a fixnum.
14376 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14377 Check for serial numbers out of range. Decode any serial number
59568bf0 14378 that was so large that it became a float. (Bug#8722)
08686060 14379
2d1fc3c7
PE
14380 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
14381 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14382 Use XFASTINT rather than XUINT when numbers are nonnegative.
14383 (xd_append_arg, Fdbus_method_return_internal):
14384 (Fdbus_method_error_internal): Likewise. Also, for unsigned
14385 arguments, check that Lisp number is nonnegative, rather than
59568bf0 14386 silently wrapping negative numbers around. (Bug#8722)
30217ff0 14387 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 14388 (Bug#8722)
2d1fc3c7 14389
c8a9ca5a
PE
14390 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
14391
519e1d69
PE
14392 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
14393
6df6ae42 14394 ccl: Add integer overflow checks.
30569699
PE
14395 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
14396 (IN_INT_RANGE): New macros.
14397 (ccl_driver): Use them to check for integer overflow when
14398 decoding a CCL program. Many of the new checks are whether XINT (x)
14399 fits in int; it doesn't always, on 64-bit hosts. The new version
14400 doesn't catch all possible integer overflows, but it's an
847044ea 14401 improvement. (Bug#8719)
30569699 14402
c11285dc
PE
14403 * alloc.c (make_event_array): Use XINT, not XUINT.
14404 There's no need for unsigned here.
14405
fdccd48e
PE
14406 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
14407 This follows up to the 2011-05-06 change that substituted uintptr_t
14408 for EMACS_INT. This case wasn't caught back then.
14409
37910ab2
PE
14410 Rework Fformat to avoid integer overflow issues.
14411 * editfns.c: Include <float.h> unconditionally, as it's everywhere
14412 now (part of C89). Include <verify.h>.
14413 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
14414 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
14415 (Fformat): Avoid the prepass trying to compute sizes; it was only
14416 approximate and thus did not catch overflow reliably. Instead, walk
14417 through the format just once, formatting and computing sizes as we go,
14418 checking for integer overflow at every step, and allocating a larger
14419 buffer as needed. Keep track separately whether the format is
14420 multibyte. Keep only the most-recently calculated precision, rather
14421 than them all. Record whether each argument has been converted to
14422 string. Use EMACS_INT, not int, for byte and char and arg counts.
14423 Support field widths and precisions larger than INT_MAX. Avoid
14424 sprintf's undefined behavior with conversion specifications such as %#d
14425 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
14426 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
14427 formatting out-of-range floating point numbers with int
9173deec 14428 formats. (Bug#8668)
37910ab2 14429
2e6578fb
PE
14430 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
14431
0ae6bdee
PE
14432 * data.c: Avoid integer truncation in expressions involving floats.
14433 * data.c: Include <intprops.h>.
14434 (arith_driver): When there's an integer overflow in an expression
14435 involving floating point, convert the integers to floating point
14436 so that the resulting value does not suffer from catastrophic
14437 integer truncation. For example, on a 64-bit host (* 4
14438 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
14439 Do not rely on undefined behavior after integer overflow.
14440
de883a70
PE
14441 merge count_size_as_multibyte, parse_str_to_multibyte
14442 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 14443 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
14444 Check for integer overflow.
14445 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
14446 since it's now a duplicate of the other. This is more of
14447 a character than a buffer op, so better that it's in character.c.
14448 * fns.c, print.c: Adjust to above changes.
14449
2ff916cb
PE
144502011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
14451
14452 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
14453
f1b54466
PE
144542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14455
fb1ac845
PE
14456 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
14457 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
14458 (x_clipboard_manager_save): Now static.
14459 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
14460
f1b54466
PE
14461 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
14462 (crypto_hash_function): Now static.
14463 Fix pointer signedness problems. Avoid unnecessary initializations.
14464
a9f737ee
CY
144652011-05-27 Chong Yidong <cyd@stupidchicken.com>
14466
14467 * termhooks.h (Vselection_alist): Make it terminal-local.
14468
14469 * terminal.c (create_terminal): Initialize it.
14470
14471 * xselect.c: Support for clipboard managers.
14472 (Vselection_alist): Move to termhooks.h as terminal-local var.
14473 (LOCAL_SELECTION): New macro.
14474 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
14475 (symbol_to_x_atom): Remove gratuitous arg.
14476 (x_handle_selection_request, lisp_data_to_selection_data)
14477 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
14478 (x_own_selection, x_get_local_selection, x_convert_selection):
14479 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
14480 (some_frame_on_display): Delete unused function.
14481 (Fx_own_selection_internal, Fx_get_selection_internal)
14482 (Fx_disown_selection_internal, Fx_selection_owner_p)
14483 (Fx_selection_exists_p): New optional frame arg.
14484 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
14485 (x_handle_selection_clear): Don't treat other terminals with the
14486 same keyboard specially. Use the terminal-local Vselection_alist.
14487 (x_clear_frame_selections): Use Frun_hook_with_args.
14488
14489 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
14490
14491 * xterm.h: Add support for those atoms.
14492
e067f0c1
CY
144932011-05-26 Chong Yidong <cyd@stupidchicken.com>
14494
14495 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
14496 (converted_selections, conversion_fail_tag): New global variables.
14497 (x_selection_request_lisp_error): Free the above.
14498 (x_get_local_selection): Remove unnecessary code.
14499 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
14500 of converted selections stored in converted_selections.
14501 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
14502 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
14503 (x_convert_selection): New function.
14504 (x_handle_selection_event): Simplify.
14505 (x_get_foreign_selection): Don't ignore incoming requests while
14506 waiting for an answer; this will fail when we implement
14507 SAVE_TARGETS, and seems unnecessary anyway.
14508 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
14509 (Vx_sent_selection_functions): Doc fix.
14510
0f4aebc0
LL
145112011-05-26 Leo Liu <sdl.web@gmail.com>
14512
14513 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
14514
e61124cd
YM
145152011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14516
14517 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
14518
14519 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
14520 for fringe update if it has periodic bitmap.
ac389d0c 14521 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
14522 and fringe_bitmap_periodic_p.
14523
14524 * fringe.c (get_fringe_bitmap_data): New function.
14525 (draw_fringe_bitmap_1, update_window_fringes): Use it.
14526 (update_window_fringes): Record periodicity of fringe bitmap in glyph
14527 row. Mark glyph row for fringe update if periodicity changed.
14528
14529 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
14530 for fringe update unless it has periodic bitmap.
14531
f16d9837
KH
145322011-05-25 Kenichi Handa <handa@m17n.org>
14533
14534 * xdisp.c (get_next_display_element): Set correct it->face_id for
14535 a static composition.
14536
e1b90ef6
LL
145372011-05-24 Leo Liu <sdl.web@gmail.com>
14538
14539 * deps.mk (fns.o):
14540 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
14541
14542 * fns.c (crypto_hash_function, Fsha1): New function.
14543 (Fmd5): Use crypto_hash_function.
14544 (syms_of_fns): Add Ssha1.
14545
7400048f
PE
145462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
14547
14548 * gnutls.c: Remove unused macros.
14549 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
14550 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
14551 Remove macros that are defined and never used.
14552 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
14553
abb71cf4
CY
145542011-05-22 Chong Yidong <cyd@stupidchicken.com>
14555
14556 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
14557 (Fx_get_selection_internal): Minor cleanup.
14558 (Fx_own_selection_internal): Rename arguments for consistency with
14559 select.el.
14560
6307db39
PE
145612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
14562
14563 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
14564
f3d4e0a4
CY
145652011-05-22 Chong Yidong <cyd@stupidchicken.com>
14566
14567 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
14568
4d8ade89
YM
145692011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14570
14571 * dispnew.c (scrolling_window): Don't exclude the case that the
14572 last enabled row in the desired matrix touches the bottom boundary.
14573
32078c8d
GM
145742011-05-21 Glenn Morris <rgm@gnu.org>
14575
14576 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
14577 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
14578 and add some more files.
32078c8d 14579
7285dc67
EZ
145802011-05-20 Eli Zaretskii <eliz@gnu.org>
14581
14582 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
14583 report_file_error introduced by the change from 2011-05-07.
14584
89d1bd22
PE
145852011-05-20 Paul Eggert <eggert@cs.ucla.edu>
14586
14587 * systime.h (Time): Define only if emacs is defined.
14588 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
14589 where the include path doesn't have X11/X.h by default. See
14590 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
14591
cd394be1 145922011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
14593
14594 * composite.c (find_automatic_composition): Fix previous change.
14595
b9704ad9
GM
145962011-05-20 Glenn Morris <rgm@gnu.org>
14597
14598 * lisp.mk: New file, split from Makefile.in.
14599 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
14600 (shortlisp): Remove.
14601 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
14602
4a720484
GM
146032011-05-19 Glenn Morris <rgm@gnu.org>
14604
14605 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
14606 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
14607 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
14608 (lisp): Set the order to that of loadup.el.
14609 (shortlisp): Make it a copy of $lisp.
14610 (SOME_MACHINE_LISP): Remove.
14611 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
14612 Use just $shortlisp, not $SOME_MACHINE_LISP too.
14613
a28d4396
KH
146142011-05-18 Kenichi Handa <handa@m17n.org>
14615
14616 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
14617 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
14618 (find_automatic_composition): Mostly rewrite for efficiency.
14619
a2b1fa8e
JB
146202011-05-18 Juanma Barranquero <lekktu@gmail.com>
14621
14622 * makefile.w32-in: Update dependencies.
14623
8e1f5610
CS
146242011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
14625
14626 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 14627 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 14628
7025ee00 146292011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 14630
cdfa6eab
PE
14631 Fix some integer overflow issues, such as string length overflow.
14632
06d6db33
PE
14633 * insdel.c (count_size_as_multibyte): Check for string overflow.
14634
2b4560a8
PE
14635 * character.c (lisp_string_width): Check for string overflow.
14636 Use EMACS_INT, not int, for string indexes and lengths; in
14637 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
14638 the resulting string length overflows an EMACS_INT; instead,
14639 report a string overflow if no precision given. When checking for
14640 precision exhaustion, use a check that cannot possibly have
14641 integer overflow. (Bug#8675)
14642 * character.h (lisp_string_width): Adjust to new signature.
14643
cb93f9be
PE
14644 * alloc.c (string_overflow): New function.
14645 (Fmake_string): Use it. This doesn't change behavior, but saves
14646 a few bytes and will simplify future changes.
14647 * character.c (string_escape_byte8): Likewise.
14648 * lisp.h (string_overflow): New decl.
14649
1a1f3366
PE
14650 Fixups, following up to the user-interface timestamp change.
14651 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
14652 for UI timestamps, instead of unsigned long.
9fbd6841
PE
14653 * msdos.c (mouse_get_pos): Likewise.
14654 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
14655 * w32gui.h (Time): Define by including "systime.h" rather than by
14656 declaring it ourselves. (Bug#8664)
14657
d4e3e4d3
PE
14658 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
14659 * image.c (clear_image_cache): Likewise.
14660
f6a24d19
PE
14661 * term.c (term_mouse_position): Don't assume time_t wraparound.
14662
08dc5ae6
PE
14663 Be more systematic about user-interface timestamps.
14664 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
14665 and sometimes 'EMACS_UINT', to represent these timestamps.
14666 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
14667 This makes the code easier to follow, and makes it easier to catch
14668 integer overflow bugs such as Bug#8664.
14669 * frame.c (Fmouse_position, Fmouse_pixel_position):
14670 Use Time, not unsigned long, for user-interface timestamps.
14671 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
14672 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
14673 * keyboard.h (last_event_timestamp): Likewise.
14674 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
14675 * menu.h (xmenu_show): Likewise.
14676 * term.c (term_mouse_position): Likewise.
14677 * termhooks.h (struct input_event.timestamp): Likewise.
14678 (struct terminal.mouse_position_hook): Likewise.
14679 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
14680 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
14681 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
14682 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
14683 what it was before.
14684 * menu.h, termhooks.h: Include "systime.h", for Time.
14685
8e55734a
PE
14686 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
14687 Don't assume that the difference between two unsigned long values
14688 can fit into an integer. At this point, we know button_down_time
14689 <= event->timestamp, so the difference must be nonnegative, so
14690 there's no need to cast the result if double-click-time is
14691 nonnegative, as it should be; check that it's nonnegative, just in
14692 case. This bug is triggered when events are more than 2**31 ms
86db42d2 14693 apart (about 25 days). (Bug#8664)
8e55734a 14694
841f1b75 14695 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 14696 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 14697
3e26f69c
PE
14698 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
14699 that always fit in int. Use a sentinel instead of a counter, to
14700 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
14701 * frame.h (struct frame): Use int for menu_bar_items_used
14702 instead of EMACS_INT, since it always fits in int.
3e26f69c 14703
5cc152c0
PE
14704 * menu.c (grow_menu_items): Check for int overflow.
14705
d89eb65e
PE
14706 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
14707
5235bd3e
PE
14708 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
14709 Before, the code was not consistent. These values cannot exceed
14710 2**31 - 1 so there's no need to make them unsigned.
14711 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
14712 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
14713 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
14714 as modifiers.
14715 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
14716
bc827e23
PE
14717 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
14718 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
14719 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
14720 presumably because the widths might not match.
14721
78eb494e
PE
14722 * window.c (size_window): Avoid needless test at loop start.
14723
04f2d78b
CB
147242011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
14725
14726 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
14727
d2fc7e3d 147282011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
14729
14730 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
14731
d2fc7e3d 147322011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
14733
14734 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
14735 `width' to `bar_area_x' and `bar_area_width', respectively.
14736 (x_scroll_run): Take account of fringe background extension.
14737
04f2d78b
CB
14738 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
14739 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
14740 `bar_area_width', respectively.
14741 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
14742 background extension.
14743
79b70037
GM
147442011-05-10 Jim Meyering <meyering@redhat.com>
14745
14746 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
14747
2f142cc5
JB
147482011-05-10 Juanma Barranquero <lekktu@gmail.com>
14749
14750 * image.c (Finit_image_library): Return t for built-in image types,
14751 like pbm and xbm. (Bug#8640)
14752
57679c86
AS
147532011-05-09 Andreas Schwab <schwab@linux-m68k.org>
14754
14755 * w32menu.c (set_frame_menubar): Fix submenu allocation.
14756
888c9e86
EZ
147572011-05-07 Eli Zaretskii <eliz@gnu.org>
14758
b0512a1d
EZ
14759 * w32console.c (Fset_screen_color): Doc fix.
14760 (Fget_screen_color): New function.
14761 (syms_of_ntterm): Defsubr it.
14762
7285dc67
EZ
14763 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
14764 unlink the temporary file if Fcall_process didn't create it in the
14765 first place.
14766 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
14767 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
14768 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
14769 cue to call_process_cleanup not to close that handle.
14770
4d3fcc8e
BK
147712011-05-07 Ben Key <bkey76@gmail.com>
14772
14773 * makefile.w32-in: The bootstrap-temacs rule now makes use of
14774 one of two shell specific rules, either bootstrap-temacs-CMD or
14775 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
14776 to the previous implementation of the bootstrap-temacs rule.
14777 The bootstrap-temacs-CMD rule is similar to the previous
14778 implementation of the bootstrap-temacs rule except that it
14779 makes use of the ESC_CFLAGS variable instead of the CFLAGS
14780 variable.
14781
14782 These changes, along with some changes to nt/configure.bat,
14783 nt/gmake.defs, and nt/nmake.defs, are required to extend my
14784 earlier fix to add support for --cflags and --ldflags options
14785 that include quotes so that it works whether make uses cmd or
14786 sh as the shell.
14787
b4289b64
MA
147882011-05-06 Michael Albinus <michael.albinus@gmx.de>
14789
14790 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
14791 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
14792 is a constant.
14793 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
14794 a string. Handle both cases.
14795 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
14796 (Fdbus_register_method): Use Qinvalid_function.
14797
af4c0e28
JB
147982011-05-06 Juanma Barranquero <lekktu@gmail.com>
14799
14800 * makefile.w32-in: Update dependencies.
14801 (LISP_H): Add inttypes.h and stdin.h.
14802 (PROCESS_H): Add unistd.h.
14803
c51453d9
EZ
148042011-05-06 Eli Zaretskii <eliz@gnu.org>
14805
14806 * lread.c: Include limits.h (fixes the MS-Windows build broken by
14807 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
14808
8ff0ac3c 148092011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 14810
4c4b566b
PE
14811 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
14812
aab2b9b5
PE
14813 * term.c (vfatal): Remove stray call to va_end.
14814 It's not needed and the C Standard doesn't allow it here anyway.
14815
c378da0b
PE
14816 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
14817 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
14818
288b08c7
PE
14819 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
14820 bytes.
14821
e3601888
PE
14822 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
14823
db6c0e74
PE
14824 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
14825
dd5963ea
PE
14826 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
14827
88c9450f
PE
14828 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
14829
2f9442b8
PE
14830 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
14831
c032b5f8
PE
14832 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
14833 * charset.c (Fdefine_charset_internal): Don't initialize
14834 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 14835 32-bit int (Bug#8600).
a108c10b
PE
14836
14837 * lread.c (read_integer): Be more consistent with string-to-number.
14838 Use string_to_number to do the actual conversion; this avoids
14839 rounding errors and fixes some other screwups. Without this fix,
14840 for example, #x1fffffffffffffff was misread as -2305843009213693952.
14841 (digit_to_number): Move earlier, for benefit of read_integer.
14842 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 14843 not a digit in any supported base. (Bug#8602)
a108c10b 14844
ad5f9eea
PE
14845 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
14846
aec1708a
PE
14847 * dispnew.c (scrolling_window): Return 1 if we scrolled,
14848 to match comment at start of function. This also removes a
14849 GCC warning about overflow in a 32+64-bit port.
14850
47be4ab5
PE
14851 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
14852
371cac43
PE
14853 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
14854 Reported by Stefan Monnier in
14855 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
14856 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14857 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 14858
d01a7826
PE
14859 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
14860 (EMACS_UINTPTR): Likewise, with uintptr_t.
14861
7fd47d5c
PE
14862 * lisp.h: Prefer 64-bit EMACS_INT if available.
14863 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
14864 on 32-bit hosts that have 64-bit int, so that they can access
14865 large files.
122b0c86
PE
14866 However, temporarily disable this change unless the temporary
14867 symbol WIDE_EMACS_INT is defined.
7fd47d5c 14868
8727937b
PE
14869 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
14870
8ac068ac
PE
14871 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
14872 This removes an assumption that EMACS_INT and long are the same
14873 width as pointers. The assumption is true for Emacs porting targets
14874 now, but we want to make other targets possible.
14875 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
14876 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
14877 In the rest of the code, change types of integers that hold casted
14878 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
14879 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
14880 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
14881 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
14882 No need to cast type when ORing.
14883 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
14884 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
14885 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
14886 assume EMACS_INT is the same width as char *.
14887 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
14888 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
14889 Remove no-longer-needed casts.
14890 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
14891 (xg_tool_bar_help_callback, xg_make_tool_item):
14892 Use EMACS_INTPTR to hold an integer
14893 that will be cast to void *; this can avoid a GCC warning
14894 if EMACS_INT is not the same width as void *.
14895 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
14896 * xdisp.c (display_echo_area_1, resize_mini_window_1):
14897 (current_message_1, set_message_1):
14898 Use a local to convert to proper width without a cast.
14899 * xmenu.c (dialog_selection_callback): Likewise.
14900
ede49d71
PE
14901 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
14902 Also, don't assume VALBITS / RAND_BITS is less than 5,
14903 and don't rely on undefined behavior when shifting a 1 left into
14904 the sign bit.
14905 * lisp.h (get_random): Change signature to match.
14906
2f30ecd0
PE
14907 * lread.c (hash_string): Use size_t, not int, for hash computation.
14908 Normally we prefer signed values; but hashing is special, because
14909 it's better to use unsigned division on hash table sizes so that
14910 the remainder is nonnegative. Also, size_t is the natural width
14911 for hashing into memory. The previous code used 'int', which doesn't
14912 retain enough info to hash well into very large tables.
14913 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
14914
2a866e7b
PE
14915 * dbusbind.c: Don't possibly lose pointer info when converting.
14916 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
14917 Use XPNTR rather than XHASH, so that the high-order bits of
14918 the pointer aren't lost when converting through void *.
14919
51639eac
PE
14920 * eval.c (Fautoload): Don't double-shift a pointer.
14921
92394119
PE
14922 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
14923
dbdb9a7c
JB
149242011-05-06 Juanma Barranquero <lekktu@gmail.com>
14925
14926 * gnutls.c (DEF_GNUTLS_FN):
14927 * image.c (DEF_IMGLIB_FN): Make function pointers static.
14928
db7a0b4f
AS
149292011-05-05 Andreas Schwab <schwab@linux-m68k.org>
14930
14931 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
14932 marker. (Bug#8610)
14933
cd394be1 149342011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
14935
14936 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
14937 New version that can reserve upto 2GB of heap space.
14938
f7ff1b0f 149392011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
14940
14941 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
14942
639c109b
TZ
149432011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
14944
14945 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
14946 `gnutls_certificate_set_x509_key_file'.
14947
d2127135
JB
149482011-05-05 Juanma Barranquero <lekktu@gmail.com>
14949
14950 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
14951 Update dependencies.
14952
e968f4f3
JB
149532011-05-04 Juanma Barranquero <lekktu@gmail.com>
14954
14955 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
14956 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
14957 Remove unused parameter `fildes'.
14958 * process.c (read_process_output, send_process): Don't pass it.
14959
84d358f0
JB
149602011-05-04 Juanma Barranquero <lekktu@gmail.com>
14961
14962 Fix previous change: the library cache is defined in w32.c.
14963 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
14964 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
14965
0898ca10
JB
149662011-05-04 Juanma Barranquero <lekktu@gmail.com>
14967
14968 Implement dynamic loading of GnuTLS on Windows.
14969
14970 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
14971 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
14972 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14973 Declare.
14974
14975 * gnutls.c (Qgnutls_dll): Define.
14976 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
14977 (gnutls_*): Declare function pointers.
14978 (init_gnutls_functions): New function to initialize function pointers.
14979 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
14980 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
14981 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
14982 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
14983 (emacs_gnutls_write, emacs_gnutls_read)
14984 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
14985 (Fgnutls_available_p): New function.
14986 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
14987 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
14988 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
14989
14990 * image.c: Include w32.h.
14991 (Vimage_type_cache): Delete.
14992 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
14993 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
14994 (w32_delayed_load): Move to w32.c.
14995
14996 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
14997
14998 * w32.c (QCloaded_from, Vlibrary_cache): Define.
14999 (w32_delayed_load): Move from image.c. When loading a library, record
15000 its filename in the :loaded-from property of the library id.
15001 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
15002 Initialize and staticpro them.
15003 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
15004
15005 * process.c: Include lisp.h before w32.h, not after.
15006 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
15007 instead of gnutls_record_check_pending.
15008
15009 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
15010
ff4de4aa
TZ
150112011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
15012
15013 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
15014 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
15015 as passed in.
15016
abe95abb
JD
150172011-05-03 Jan Djärv <jan.h.d@swipnet.se>
15018
15019 * xterm.c (x_set_frame_alpha): Do not set property on anything
15020 else than FRAME_X_OUTER_WINDOW (Bug#8608).
15021
e16e55d4
JB
150222011-05-02 Juanma Barranquero <lekktu@gmail.com>
15023
15024 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
15025
bafcf6a5
JB
150262011-05-02 Juanma Barranquero <lekktu@gmail.com>
15027
15028 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
15029 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
15030 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
15031 (gnutls_global_initialized, Qgnutls_bootprop_priority)
15032 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
15033 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
15034 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
15035 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
15036 (Qgnutls_bootprop_callbacks_verify): Make static.
15037
e7a6747f
AS
150382011-05-01 Andreas Schwab <schwab@linux-m68k.org>
15039
19ed11ba
AS
15040 * callproc.c: Indentation fixup.
15041
e7a6747f 15042 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
15043 (wait_for_termination, interruptible_wait_for_termination):
15044 Move after wait_for_termination_1.
e7a6747f 15045
1ef14cb4
LMI
150462011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
15047
15048 * sysdep.c (interruptible_wait_for_termination): New function
15049 which is like wait_for_termination, but allows keyboard
15050 interruptions.
15051
15052 * callproc.c (Fcall_process): Add (:file "file") as an option for
15053 the STDOUT buffer.
15054 (Fcall_process_region): Ditto.
15055
330d880c
EZ
150562011-04-30 Eli Zaretskii <eliz@gnu.org>
15057
8db90b73
EZ
15058 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
15059 rather than `XVECTOR (FOO)->size'.
15060
330d880c
EZ
15061 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
15062 inttypes.h, as a gnulib replacement is used if it not available in
15063 system headers.
15064
15cbd324
EZ
150652011-04-21 Eli Zaretskii <eliz@gnu.org>
15066
15067 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
15068 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
15069 of MOST_POSITIVE_FIXNUM. (Bug#8528)
15070
15071 * coding.c (coding_alloc_by_realloc): Error out if destination
15072 will grow beyond MOST_POSITIVE_FIXNUM.
15073 (decode_coding_emacs_mule): Abort if there isn't enough place in
15074 charbuf for the composition carryover bytes. Reserve an extra
15075 space for up to 2 characters produced in a loop.
15076 (decode_coding_iso_2022): Abort if there isn't enough place in
15077 charbuf for the composition carryover bytes.
15078
150792011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 15080
ae940cca
EZ
15081 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
15082 aborting when %lld or %lll format is passed.
15083 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
15084 %llo or %llx format is passed. (Bug#8545)
15085
03ab8921
EZ
15086 * window.c (window_scroll_line_based): Use a marker instead of
15087 simple variables to record original value of point. (Bug#7952)
15088
afda1437
EZ
15089 * doprnt.c (doprnt): Fix the case where a multibyte sequence
15090 produced by %s or %c overflows available buffer space. (Bug#8545)
15091
f76dee0c
PE
150922011-04-28 Paul Eggert <eggert@cs.ucla.edu>
15093
15094 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 15095 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 15096
fdc5744d
JB
150972011-04-28 Juanma Barranquero <lekktu@gmail.com>
15098
15099 * w32.c (init_environment): Warn about defaulting HOME to C:\.
15100
638f053a
JB
151012011-04-28 Juanma Barranquero <lekktu@gmail.com>
15102
15103 * keyboard.c (Qdelayed_warnings_hook): Define.
15104 (command_loop_1): Run `delayed-warnings-hook'
15105 if Vdelayed_warnings_list is non-nil.
15106 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
15107 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
15108
d178f871
EZ
151092011-04-28 Eli Zaretskii <eliz@gnu.org>
15110
15111 * doprnt.c (doprnt): Don't return value smaller than the buffer
15112 size if the message was truncated. (Bug#8545).
15113
b124fd93
JB
151142011-04-28 Juanma Barranquero <lekktu@gmail.com>
15115
15116 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
15117 (Fx_window_property): #if-0 the whole functions, not just the bodies.
15118
e810457d
PE
151192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15120
15121 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
15122
ea51cceb
JB
151232011-04-27 Juanma Barranquero <lekktu@gmail.com>
15124
15125 * makefile.w32-in: Update dependencies.
15126
94dcfacf
EZ
151272011-04-27 Eli Zaretskii <eliz@gnu.org>
15128
15129 Improve `doprnt' and its usage. (Bug#8545)
15130 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
15131 `format_end'. Remove support for %l as a conversion specifier.
15132 Don't use xrealloc. Improve diagnostics when the %l size modifier
15133 is used. Update the commentary.
15134
15135 * eval.c (verror): Simplify calculation of size_t.
15136
15137 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
15138 messages.
15139
f61f41d7
PE
151402011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
15141
15142 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
15143 change.
15144
96fb4434
PE
151452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15146
15147 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
15148 This makes this file independent of the recent pseudovector change.
15149
671875da 151502011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 15151
69e9b5a3
PE
15152 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
15153
b5f869a7 15154 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 15155 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 15156 Remove unused local.
c8926152 15157 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 15158
841a1577 15159 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
15160 GCC 4.6.0 optimizes based on type-based alias analysis.
15161 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
15162 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
15163 != &v->size, and therefore "v->size = 1; b->size = 2; return
15164 v->size;" must therefore return 1. This assumption is incorrect
15165 for Emacs, since it type-puns struct Lisp_Vector * with many other
15166 types. To fix this problem, this patch adds a new type struct
f904488f 15167 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
15168 and pseudovectors, and helps optimizing compilers not get fooled
15169 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
15170 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
15171 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
15172 the size member.
eab3844f
PE
15173 (XSETPVECTYPE): Rewrite in terms of new macro.
15174 (XSETPVECTYPESIZE): New macro, specifying both type and size.
15175 This is a bit clearer, and further avoids the possibility of
15176 undesirable aliasing.
15177 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 15178 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
15179 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
15180 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
15181 (ASIZE): Now uses header.size rather than size.
15182 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
15183 to avoid the hassle of writing XVECTOR (foo)->header.size.
15184 (struct vectorlike_header): New type.
eab3844f
PE
15185 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
15186 object, to help avoid aliasing.
15187 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
15188 (SUBRP): Likewise, since Lisp_Subr is a special case.
15189 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
15190 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
15191 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 15192 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
15193 changed to be "header.size" and "header.next".
15194 * buffer.h (struct buffer): Likewise.
15195 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
15196 * frame.h (struct frame): Likewise.
15197 * process.h (struct Lisp_Process): Likewise.
15198 * termhooks.h (struct terminal): Likewise.
15199 * window.c (struct save_window_data, struct saved_window): Likewise.
15200 * window.h (struct window): Likewise.
15201 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
15202 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
15203 * buffer.c (init_buffer_once): Likewise.
15204 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
15205 special case.
15206 * process.c (Fformat_network_address): Use local var for size,
15207 for brevity.
15208
0df1eac5
PE
15209 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
15210
847ab9d1 15211 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
15212 * data.c (atof): Remove decl; no longer used or needed.
15213 (digit_to_number): Move to lread.c.
15214 (Fstring_to_number): Use new string_to_number function, to be
15215 consistent with how the Lisp reader treats infinities and NaNs.
15216 Do not assume that floating-point numbers represent EMACS_INT
15217 without losing information; this is not true on most 64-bit hosts.
15218 Avoid double-rounding errors, by insisting on integers when
15219 parsing non-base-10 numbers, as the documentation specifies.
15220 * lisp.h (string_to_number): New decl, replacing ...
15221 (isfloat_string): Remove.
bc0a5c13 15222 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 15223 (read1): Do not accept +. and -. as integers; this
452f4150
PE
15224 appears to have been a coding error. Similarly, do not accept
15225 strings like +-1e0 as floating point numbers. Do not report
15226 overflow for integer overflows unless the base is not 10 which
15227 means we have no simple and reliable way to continue.
15228 Break out the floating-point parsing into a new
15229 function string_to_number, so that Fstring_to_number parses
15230 floating point numbers consistently with the Lisp reader.
04f2d78b 15231 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
15232 (E_CHAR, EXP_INT): Remove, replacing with ...
15233 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
15234 (string_to_number): New function, replacing isfloat_string.
15235 This function checks for valid syntax and produces the resulting
15236 Lisp float number too. Rework it so that string-to-number
bc0a5c13 15237 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
15238 so that overflow for non-base-10 numbers is reported only when
15239 there's no portable and simple way to convert to floating point.
452f4150 15240
67769ffc
PE
15241 * textprop.c (set_text_properties_1): Rewrite for clarity,
15242 and to avoid GCC warning about integer overflow.
15243
c20db43f
PE
15244 * intervals.h (struct interval): Use EMACS_INT for members
15245 where EMACS_UINT might cause problems. See
15246 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
15247 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
15248 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
15249 All uses changed.
37aa2f85
PE
15250 (offset_intervals): Tell GCC not to worry about length overflow
15251 when negating a negative length.
c20db43f 15252
2538aa2f
PE
15253 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
15254 (overrun_check_free): Likewise.
15255
f2d3008d
PE
15256 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
15257 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
15258 word size.
15259
ec8df744
PE
15260 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15261 (gnutls_make_error): Rename local to avoid shadowing.
15262 (gnutls_emacs_global_deinit): ifdef out; not used.
15263 (Fgnutls_boot): Use const for pointer to readonly storage.
15264 Comment out unused local. Fix pointer signedness problems.
15265
640ee02d
PE
15266 * lread.c (openp): Don't stuff size_t into an 'int'.
15267 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
15268 about possible signed overflow.
15269
6048fb2a
PE
15270 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15271 (GDK_KEY_g): Don't define if already defined.
15272 (xg_prepare_tooltip): Avoid pointer signedness problem.
15273 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
15274
fa3c87e1
PE
15275 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
15276 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
15277
2172544b
PE
15278 * xfns.c (Fx_window_property): Simplify a bit,
15279 to make a bit faster and to avoid GCC 4.6.0 warning.
15280 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
15281
9b821a21
PE
15282 * fns.c (internal_equal): Don't assume size_t fits in int.
15283
3c616cfa
PE
15284 * alloc.c (compact_small_strings): Tighten assertion a little.
15285
c2982e87
PE
15286 Replace pEd with more-general pI, and fix some printf arg casts.
15287 * lisp.h (pI): New macro, generalizing old pEd macro to other
15288 conversion specifiers. For example, use "...%"pI"d..." rather
15289 than "...%"pEd"...".
15290 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 15291 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
15292 * alloc.c (check_pure_size): Don't overflow by converting size to int.
15293 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
15294 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
15295 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
15296 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
15297 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
15298 64-bit hosts.
15299 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
15300 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
15301 * print.c (safe_debug_print, print_object): Likewise.
15302 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
15303 to int.
6f04d126
PE
15304 Use pI instead of if-then-else-abort. Use %p to avoid casts,
15305 avoiding the 0 flag, which is not portable.
c2982e87
PE
15306 * process.c (Fmake_network_process): Use pI to avoid cast.
15307 * region-cache.c (pp_cache): Likewise.
15308 * xdisp.c (decode_mode_spec): Likewise.
15309 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
15310 behavior on 64-bit hosts with printf arg.
6f04d126 15311 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
15312 (x_stop_queuing_selection_requests): Likewise.
15313 (x_get_window_property): Don't truncate byte count to an 'int'
15314 when tracing.
0b432f21 15315
5e073ec7
PE
15316 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
15317 here, since it parses constructs like leading '-' and spaces,
15318 which are not wanted; and it overflows with large numbers.
15319 Instead, simply match F[0-9]+, which is what is wanted anyway.
15320
36372bf9
PE
15321 * alloc.c: Remove unportable assumptions about struct layout.
15322 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
15323 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
15324 (allocate_vectorlike, make_pure_vector): Use the new macros,
15325 plus offsetof, to remove unportable assumptions about struct layout.
15326 These assumptions hold on all porting targets that I know of, but
15327 they are not guaranteed, they're easy to remove, and removing them
15328 makes further changes easier.
15329
0b432f21
PE
15330 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
15331 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
15332 (string_overrun_cookie): Now const. Use initializers that
15333 don't formally overflow signed char, to avoid warnings.
000098c1
PE
15334 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
15335 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
15336 (allocate_buffer): Don't assume sizeof (struct buffer) is a
15337 multiple of sizeof (EMACS_INT); it need not be, if
15338 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 15339 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 15340
895009e1
JB
153412011-04-26 Juanma Barranquero <lekktu@gmail.com>
15342
15343 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
15344
6a7a1b0b
TZ
153452011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
15346
15347 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 15348 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
15349 Reported by Paul Eggert <eggert@cs.ucla.edu>.
15350
841a1577 153512011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
15352
15353 * lisp.h (Qdebug): List symbol.
895009e1 15354 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
15355 * keyboard.c (debug-on-event): New variable.
15356 (handle_user_signal): Break into debugger when debug-on-event
15357 matches the current signal symbol.
15358
f2d3ba6f
DN
153592011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
15360
15361 * alloc.c (check_sblock, check_string_bytes)
15362 (check_string_free_list): Convert to standard C.
15363
42ce4c63
TZ
153642011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
15365
15366 * w32.c (emacs_gnutls_push): Fix typo.
15367
825cd63c
EZ
153682011-04-25 Eli Zaretskii <eliz@gnu.org>
15369
fb11d64d
EZ
15370 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
15371 "cast to pointer from integer of different size".
15372
825cd63c
EZ
15373 Improve doprnt and its use in verror. (Bug#8545)
15374 * doprnt.c (doprnt): Document the set of format control sequences
15375 supported by the function. Use SAFE_ALLOCA instead of always
15376 using `alloca'.
15377
15378 * eval.c (verror): Don't limit the buffer size at size_max-1, that
15379 is one byte too soon. Don't use xrealloc; instead xfree and
15380 xmalloc anew.
15381
e061a11b
TZ
153822011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
15383
15384 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
15385 callbacks stage.
15386
15387 * gnutls.c: Renamed global_initialized to
15388 gnutls_global_initialized. Added internals for the
15389 :verify-hostname-error, :verify-error, and :verify-flags
15390 parameters of `gnutls-boot' and documented those parameters in the
15391 docstring. Start callback support.
9173deec
JB
15392 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
15393 unless a fatal error occurred. Call gnutls_alert_send_appropriate
15394 on error. Return error code.
e061a11b
TZ
15395 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
15396 (emacs_gnutls_read): Likewise.
15397 (Fgnutls_boot): Return handshake error code.
15398 (emacs_gnutls_handle_error): New function.
15399 (wsaerror_to_errno): Likewise.
15400
15401 * w32.h (emacs_gnutls_pull): Add prototype.
15402 (emacs_gnutls_push): Likewise.
15403
15404 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
15405 (emacs_gnutls_push): Likewise.
15406
154072011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
15408
15409 * process.c (wait_reading_process_output): Check if GnuTLS
15410 buffered some data internally if no FDs are set for TLS
15411 connections.
15412
15413 * makefile.w32-in (OBJ2): Add gnutls.$(O).
15414 (LIBS): Link to USER_LIBS.
15415 ($(BLD)/gnutls.$(0)): New target.
15416
fa6996bc
EZ
154172011-04-24 Eli Zaretskii <eliz@gnu.org>
15418
eb35682e
EZ
15419 * xdisp.c (handle_single_display_spec): Rename the
15420 display_replaced_before_p argument into display_replaced_p, to
15421 make it consistent with the commentary. Fix typos in the
15422 commentary.
15423
e2ad650c
EZ
15424 * textprop.c (syms_of_textprop): Remove dead code.
15425 (copy_text_properties): Delete obsolete commentary about an
15426 interface that was deleted long ago. Fix typos in the description
15427 of arguments.
15428
1b2de274
EZ
15429 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
15430 to changes in oldXMenu/XMenu.h from 2011-04-16.
15431 <menu_help_message, prev_menu_help_message>: Constify.
15432 (IT_menu_make_room): menu->help_text is now `const char **';
15433 adjust.
15434
15435 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
15436 to changes in oldXMenu/XMenu.h from 2011-04-16.
15437 (struct XMenu): Declare `help_text' `const char **'.
15438
15439 * xfaces.c <Qunspecified>: Make extern again.
15440
15441 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 15442 required by POSIX.
1b2de274 15443
762b15be
EZ
15444 * doc.c (get_doc_string): Improve the format passed to `error'.
15445
15446 * doprnt.c (doprnt): Improve commentary.
15447
15448 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
15449
15450 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
15451 them with etags.
15452
f1052e5d
EZ
15453 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
15454 changes in globals.h immediately force recompilation.
762b15be
EZ
15455 (TAGS): Depend on $(CURDIR)/m/intel386.h and
15456 $(CURDIR)/s/ms-w32.h.
15457 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 15458
fa6996bc
EZ
15459 * character.c (Fchar_direction): Function deleted.
15460 (syms_of_character): Don't defsubr it.
15461 <char-direction-table>: Deleted.
15462
e6c3da20
EZ
154632011-04-23 Eli Zaretskii <eliz@gnu.org>
15464
15465 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
15466 * doprnt.c: Include limits.h.
15467 (SIZE_MAX): New macro.
04f2d78b
CB
15468 (doprnt): Return a size_t value. 2nd arg is now size_t.
15469 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
15470 Improve overflow protection. Support `l' modifier for integer
15471 conversions. Support %l conversion. Don't assume an EMACS_INT
15472 argument for integer conversions and for %c.
15473
15474 * lisp.h (doprnt): Restore prototype.
15475
15476 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
15477 $(SRC)/character.h.
15478
15479 * Makefile.in (base_obj): Add back doprnt.o.
15480
15481 * deps.mk (doprnt.o): Add back prerequisites.
15482 (callint.o): Depend on character.h.
15483
15484 * eval.c (internal_lisp_condition_case): Include the handler
15485 representation in the error message.
15486 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
15487 when breaking from the loop.
15488
15489 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
15490
15491 * callint.c (Fcall_interactively): When displaying error message
15492 about invalid control letter, pass the character's codepoint, not
15493 a pointer to its multibyte form. Improve display of the character
15494 in octal and display also its hex code.
15495
15496 * character.c (char_string): Use %x to display the (unsigned)
15497 codepoint of an invalid character, to avoid displaying a bogus
15498 negative value.
15499
15500 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
15501 `error', not SYMBOL_NAME itself.
15502
15503 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
15504 character arguments to `error'.
15505
15506 * charset.c (check_iso_charset_parameter): Fix incorrect argument
15507 to `error' in error message about FINAL_CHAR argument. Make sure
15508 FINAL_CHAR is a character, and use %c when it is passed as
15509 argument to `error'.
15510
4ffd0d6b 155112011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
15512
15513 * s/ms-w32.h (localtime): Redirect to sys_localtime.
15514
15515 * w32.c: Include <time.h>.
15516 (sys_localtime): New function.
15517
4ffd0d6b 155182011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
15519
15520 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
15521
4ffd0d6b 15522 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 15523
4ffd0d6b 155242011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 15525
4ffd0d6b
GM
15526 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
15527 zombies (Bug#8467).
aac0c6e3 15528
04c56954
EZ
155292011-04-19 Eli Zaretskii <eliz@gnu.org>
15530
15531 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
15532 gl_state.e_property when gl_state.object is Qt.
15533
15534 * insdel.c (make_gap_larger): Remove limitation of buffer size
15535 to <= INT_MAX.
15536
16a43933
CY
155372011-04-18 Chong Yidong <cyd@stupidchicken.com>
15538
15539 * xdisp.c (lookup_glyphless_char_display)
15540 (produce_glyphless_glyph): Handle cons cell entry in
15541 glyphless-char-display.
15542 (Vglyphless_char_display): Document it.
15543
15544 * term.c (produce_glyphless_glyph): Handle cons cell entry in
15545 glyphless-char-display.
15546
4581706e
CY
155472011-04-17 Chong Yidong <cyd@stupidchicken.com>
15548
15549 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
15550
15551 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
15552
15553 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
15554 definition for no-X builds.
15555
4887c6e2 155562011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 15557
fd35b6f9
PE
15558 Static checks with GCC 4.6.0 and non-default toolkits.
15559
5c1ccb01
PE
15560 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
15561
006c5daa
PE
15562 * process.c (keyboard_bit_set): Define only if SIGIO.
15563 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
15564 (send_process): Repair possible setjmp clobbering.
15565
efc736d3
PE
15566 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
15567
4e2fe2e6
PE
15568 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
15569
f97334a2
PE
15570 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
15571
4e75f29d
PE
15572 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
15573 Define only if needed.
15574
90efadd1
PE
15575 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
15576 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 15577 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 15578
3c647824
PE
15579 * dispextern.h (struct redisplay_interface): Rename param
15580 to avoid shadowing.
e264f262 15581 * termhooks.h (struct terminal): Likewise.
761383f4 15582 * xterm.c (xembed_send_message): Likewise.
3c647824 15583
b58c5c4a
PE
15584 * insdel.c (make_gap_smaller): Define only if
15585 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
15586
cad59032
PE
15587 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
15588 it.
15589
c339dc2e
PE
15590 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
15591 so that we aren't warned about unused symbols.
15592
91a3e27b
PE
15593 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
15594
399c71d3 15595 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 15596
8ffc96f5
PE
15597 * xfns.c (x_real_positions): Mark locals as initialized.
15598
eef9bc79
PE
15599 * xmenu.c (xmenu_show): Don't use uninitialized vars.
15600
098db9dd
PE
15601 * xterm.c: Fix problems found by static analysis with other toolkits.
15602 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
15603 (x_dispatch_event): Declare static if USE_GTK, and
15604 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 15605 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 15606 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
15607 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
15608 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 15609
eb18f6cc
PE
15610 * xmenu.c (menu_help_callback): Pointer type fixes.
15611 Use const pointers when pointing at readonly data. Avoid pointer
15612 signedness clashes.
15613 (FALSE): Remove unused macro.
15614 (update_frame_menubar): Remove unused decl.
15615
1fe72bf8
PE
15616 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
15617
60d9e1db
PE
15618 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
15619 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
15620 (single_menu_item): Rename local to avoid shadowing.
15621
39261c26
PE
15622 * keyboard.c (make_lispy_event): Remove unused local var.
15623
018c5e19
PE
15624 * frame.c, frame.h (x_get_resource_string): Bring this back, but
15625 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
15626
63d2b86e
PE
15627 * bitmaps: Change bitmaps from unsigned char back to the X11
15628 compatible char. Avoid the old compiler warnings about
15629 out-of-range initializers by using, for example, '\xab' rather
15630 than 0xab.
15631
aefd87e1
PE
15632 * xgselect.c (xgselect_initialize): Check vs interface
15633 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
15634
bf501fb9
PE
15635 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
15636
e9829fdf
PE
15637 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
15638 to read-only memory.
15639
1086c095
PE
15640 * fns.c (vector): Remove; this old hack is no longer needed.
15641
2baccd04 15642 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 15643 Remove unused var.
dde42981 15644 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 15645
72391843 15646 * xrdb.c (x_load_resources): Omit unused local.
3565b346 15647
436c16df 15648 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 15649 (x_window): Rename locals to avoid shadowing.
dc5ddd85 15650 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 15651
92bb796d 15652 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 15653 (x_term_init): Remove local to avoid shadowing.
92bb796d 15654
764430a3 15655 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
15656
15657 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
15658 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
15659
d1dfb56c
EZ
156602011-04-16 Eli Zaretskii <eliz@gnu.org>
15661
c4354cb4
EZ
15662 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
15663
d1dfb56c
EZ
15664 Fix regex.c, syntax.c and friends for buffers > 2GB.
15665 * syntax.h (struct gl_state_s): Declare character position members
15666 EMACS_INT.
15667
15668 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
15669
04f2d78b
CB
15670 * textprop.c (verify_interval_modification, interval_of):
15671 Declare arguments EMACS_INT.
d1dfb56c
EZ
15672
15673 * intervals.c (adjust_intervals_for_insertion): Declare arguments
15674 EMACS_INT.
15675
15676 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
15677
15678 * indent.c (Fvertical_motion): Local variable it_start is now
15679 EMACS_INT.
15680
15681 * regex.c (re_match, re_match_2, re_match_2_internal)
15682 (bcmp_translate, regcomp, regexec, print_double_string)
15683 (group_in_compile_stack, re_search, re_search_2, regex_compile)
15684 (re_compile_pattern, re_exec): Declare arguments and local
15685 variables `size_t' and `ssize_t' and return values `regoff_t', as
15686 appropriate.
15687 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
15688 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
15689 <compile_stack_type>: `size' and `avail' are now `size_t'.
15690
15691 * regex.h <regoff_t>: Use ssize_t, not int.
15692 (re_search, re_search_2, re_match, re_match_2): Arguments that
15693 specify buffer/string position and length are now ssize_t and
15694 size_t. Return type is regoff_t.
15695
613052cd
BK
156962011-04-16 Ben Key <bkey76@gmail.com>
15697
15698 * nsfont.m: Fixed bugs in ns_get_family and
15699 ns_descriptor_to_entity that were caused by using free to
15700 deallocate memory blocks that were allocated by xmalloc (via
15701 xstrdup). This caused Emacs to crash when compiled with
15702 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
15703 --enable-checking=xmallocoverrun). xfree is now used to
15704 deallocate these memory blocks.
15705
4170f62f 157062011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 15707
71b41406
PE
15708 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
15709
9587a89d
PE
15710 emacs_write: Accept and return EMACS_INT for sizes.
15711 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
15712 et seq.
15713 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
15714 Accept and return EMACS_INT.
15715 (emacs_gnutls_write): Return the number of bytes written on
15716 partial writes.
15717 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
15718 (emacs_read, emacs_write): Remove check for negative size, as the
15719 Emacs source code has been audited now.
9587a89d
PE
15720 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
15721 (emacs_read, emacs_write): Use it.
273a5f82
PE
15722 * process.c (send_process): Adjust to the new signatures of
15723 emacs_write and emacs_gnutls_write. Do not attempt to store
15724 a byte offset into an 'int'; it might overflow.
9587a89d 15725 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 15726
3e047f51
PE
15727 * sound.c: Don't assume sizes fit in 'int'.
15728 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 15729 Return EMACS_INT, not int.
3e047f51 15730 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
15731 Accept EMACS_INT, not int.
15732 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
15733 record read return values.
15734
cc39a9db
BK
157352011-04-15 Ben Key <bkey76@gmail.com>
15736
c9d0ec6d
JB
15737 * keyboard.c (Qundefined): Don't declare static since it is used
15738 in nsfns.m.
15739 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
15740 static since they are used in nsfont.m.
cc39a9db 15741
6c60eb9f
SM
157422011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
15743
15744 * process.c (Qprocessp): Don't declare static.
15745 * lisp.h (Qprocessp): Declare again.
15746
7990b61a
JB
157472011-04-15 Juanma Barranquero <lekktu@gmail.com>
15748
15749 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
15750
5d4cb038
PE
157512011-04-14 Paul Eggert <eggert@cs.ucla.edu>
15752
8bd7b830 15753 Improve C-level modularity by making more things 'static'.
cd64ea1d 15754
e3b27b31
PE
15755 Don't publish debugger-only interfaces to other modules.
15756 * lisp.h (safe_debug_print, debug_output_compilation_hack):
15757 (verify_bytepos, count_markers): Move decls to the only modules
15758 that need them.
15759 * region-cache.h (pp_cache): Likewise.
15760 * window.h (check_all_windows): Likewise.
15761 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
15762
5d4cb038
PE
15763 * sysdep.c (croak): Now static, if
15764 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
15765 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
15766
15767 * alloc.c (refill_memory_reserve): Now static if
15768 !defined REL_ALLOC || defined SYSTEM_MALLOC.
15769 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 15770
e87b6180
PE
15771 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
15772 Define only if USE_LUCID.
15773
ac64929e
PE
15774 * xrdb.c (x_customization_string, x_rm_string): Now static.
15775
6f37259d
PE
15776 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
15777 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
15778
1683e3ab
PE
15779 * xdisp.c (draw_row_with_mouse_face): Now static.
15780 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
15781
de9c2632
PE
15782 * window.h (check_all_windows): Mark externally visible.
15783
2b96acb7
PE
15784 * window.c (window_deletion_count): Now static.
15785
15786 * undo.c: Make symbols static if they're not exported.
15787 (last_undo_buffer, last_boundary_position, pending_boundary):
15788 Now static.
15789
50436f33
PE
15790 * textprop.c (interval_insert_behind_hooks): Now static.
15791 (interval_insert_in_front_hooks): Likewise.
15792
64520e5c
PE
15793 * term.c: Make symbols static if they're not exported.
15794 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
15795 (max_frame_lines, tty_set_terminal_modes):
15796 (tty_reset_terminal_modes, tty_turn_off_highlight):
15797 (get_tty_terminal): Now static.
15798 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
15799 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 15800 HAVE_WINDOW_SYSTEM.
64520e5c
PE
15801 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
15802 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
15803
1fa53021
PE
15804 * sysdep.c: Make symbols static if they're not exported.
15805 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
15806 Now static.
15807 (sigprocmask_set, full_mask): Remove; unused.
15808 (wait_debugging): Mark as visible.
15809 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
15810 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
15811
d4b43b22
PE
15812 * syntax.c (syntax_temp): Define only if !__GNUC__.
15813
b7c513d0
PE
15814 * sound.c (current_sound_device, current_sound): Now static.
15815
989b29ad
PE
15816 * search.c (searchbufs, searchbuf_head): Now static.
15817
13a55a78
PE
15818 * scroll.c (scroll_cost): Remove; unused.
15819 * dispextern.h (scroll_cost): Remove decl.
15820
de68a1fc
PE
15821 * region-cache.h (pp_cache): Mark as externally visible.
15822
40ccffa6
PE
15823 * process.c: Make symbols static if they're not exported.
15824 (process_tick, update_tick, create_process, chan_process):
15825 (Vprocess_alist, proc_buffered_char, datagram_access):
15826 (fd_callback_data, send_process_frame, process_sent_to): Now static.
15827 (deactivate_process): Mark defn as static, as well as decl.
15828 * lisp.h (create_process): Remove decl.
15829 * process.h (chan_process, Vprocess_alist): Remove decls.
15830
ad64fc97
PE
15831 * print.c: Make symbols static if they're not exported.
15832 (print_depth, new_backquote_output, being_printed, print_buffer):
15833 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
15834 (print_interval, print_number_index, initial_stderr_stream):
15835 Now static.
15836 * lisp.h (Fprinc): Remove decl.
15837 (debug_output_compilation_hack): Mark as externally visible.
15838
adddb265
PE
15839 * sysdep.c (croak): Move decl from here to syssignal.h.
15840 * syssignal.h (croak): Put it here, so the API can be checked when
15841 'croak' is called from dissociate_if_controlling_tty.
15842
1717ede2
PE
15843 * minibuf.c: Make symbols static if they're not exported.
15844 (minibuf_save_list, choose_minibuf_frame): Now static.
15845 * lisp.h (choose_minibuf_frame): Remove decl.
15846
fa5fb2bc
PE
15847 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
15848
1e3890d1
PE
15849 * lread.c: Make symbols static if they're not exported.
15850 (read_objects, initial_obarray, oblookup_last_bucket_number):
15851 Now static.
15852 (make_symbol): Remove; unused.
15853 * lisp.h (initial_obarray, make_symbol): Remove decls.
15854
8a1414fa
PE
15855 * keyboard.c: Make symbols static if they're not exported.
15856 (single_kboard, recent_keys_index, total_keys, recent_keys):
15857 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
15858 (this_single_command_key_start, echoing, last_auto_save):
15859 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
15860 (command_loop, echo_now, keyboard_init_hook, help_char_p):
15861 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
15862 (Vlispy_mouse_stem, double_click_count):
15863 Now static.
15864 (force_auto_save_soon): Define only if SIGDANGER.
15865 (ignore_mouse_drag_p): Now static if
15866 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
15867 (print_help): Remove; unused.
15868 (stop_character, last_timer_event): Mark as externally visible.
15869 * keyboard.h (ignore_mouse_drag_p): Declare only if
15870 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
15871 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
15872 * lisp.h (echoing): Remove decl.
15873 (force_auto_save_soon): Declare only if SIGDANGER.
15874 * xdisp.c (redisplay_window): Simplify code, to make it more
15875 obvious that ignore_mouse_drag_p is not accessed if !defined
15876 USE_GTK && !defined HAVE_NS.
15877
93ea6e8f
PE
15878 * intervals.c: Make symbols static if they're not exported.
15879 (merge_properties_sticky, merge_interval_right, delete_interval):
15880 Now static.
15881 * intervals.h (merge_interval_right, delete_interval): Remove decls.
15882
77382fcc
PE
15883 * insdel.c: Make symbols static if they're not exported.
15884 However, leave prepare_to_modify_buffer alone. It's never
15885 called from outside this function, but that appears to be a bug.
15886 (combine_after_change_list, combine_after_change_buffer):
4889fc82 15887 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
15888 (adjust_after_replace_noundo): Remove; unused.
15889 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 15890 (signal_before_change): Remove decls.
77382fcc 15891
9306c32e
PE
15892 * indent.c (val_compute_motion, val_vmotion): Now static.
15893
cd44d2eb
PE
15894 * image.c: Make symbols static if they're not exported.
15895 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
15896 if USE_GTK.
15897 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
15898 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
15899
ad9a7a06
PE
15900 * fringe.c (standard_bitmaps): Now static.
15901 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
15902
81626931
PE
15903 * frame.c: Make symbols static if they're not exported.
15904 (x_report_frame_params, make_terminal_frame): Now static.
15905 (get_frame_param): Now static, unless HAVE_NS.
15906 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
15907 (x_get_resource_string): Remove; not used.
15908 * frame.h (make_terminal_frame, x_report_frame_params):
15909 (x_get_resource_string); Remove decls.
15910 (x_fullscreen_adjust): Declare only if WINDOWSNT.
15911 * lisp.h (get_frame_param): Declare only if HAVE_NS.
15912
239f9db9
PE
15913 * font.c, fontset.c: Make symbols static if they're not exported.
15914 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
15915 (FACE_SUITABLE_FOR_CHAR_P): Use it.
15916 * font.c (font_close_object): Now static.
15917 * font.h (font_close_object): Remove.
15918 * fontset.c (FONTSET_OBJLIST): Remove.
15919 (free_realized_fontset) #if-0 the body, which does nothing.
15920 (face_suitable_for_char_p): #if-0, as it's never called.
15921 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
15922 * xfaces.c (face_at_string_position):
15923 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
15924 since 0 is always ASCII.
15925
dfcf3579
PE
15926 * fns.c (weak_hash_tables): Now static.
15927
5045092b
PE
15928 * fileio.c: Make symbols static if they're not exported.
15929 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
15930 (Vwrite_region_annotation_buffers): Now static.
15931
57a96f5c
PE
15932 * eval.c: Make symbols static if they're not exported.
15933 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
15934 * lisp.h (backtrace_list): Remove decl.
15935
35f08c38
PE
15936 * emacs.c: Make symbols static if they're not exported.
15937 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
15938 (fatal_error_code, fatal_error_signal_hook, standard_args):
15939 Now static.
15940 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
15941 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
15942 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
15943 * lisp.h (fatal_error_signal_hook): Remove decl.
15944 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
15945
f44bd759
PE
15946 * editfns.c: Move a (normally-unused) function to its only use.
15947 * editfns.c, lisp.h (get_operating_system_release): Remove.
15948 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
15949 worth the hassle of breaking this out.
15950
b532497d
PE
15951 * xterm.c: Make symbols static if they're not exported.
15952 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
15953 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
15954 (x_destroy_window, x_delete_display):
15955 Now static.
15956 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
15957 (x_mouse_leave): Remove; unused.
15958 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
15959 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
15960 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
15961 Remove decls.
15962 (x_mouse_leave): Declare only if WINDOWSNT.
15963 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
15964 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
15965 USE_X_TOOLKIT.
15966
1675728f
PE
15967 * ftxfont.c: Make symbols static if they're not exported.
15968 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
15969 HAVE_FREETYPE.
15970 * font.h (ftxfont_driver): Likewise.
15971
e4cebfca
PE
15972 * xfns.c: Make symbols static if they're not exported.
15973 (x_last_font_name, x_display_info_for_name):
15974 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
15975 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
15976 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
15977 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
15978 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
15979 (last_show_tip_args): Now static.
15980 (xic_defaut_fontset, xic_create_fontsetname): Define only if
15981 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
15982 (x_screen_planes): Remove; unused.
15983 * dispextern.h (x_screen_planes): Remove decl.
15984
5bf46f05
PE
15985 * dispnew.c: Make symbols static if they're not exported.
15986 * dispextern.h (redraw_garbaged_frames, scrolling):
15987 (increment_row_positions): Remove.
15988 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
15989 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
15990 Now static.
15991 (redraw_garbaged_frames): Remove; unused.
15992
435f4c28
PE
15993 * xfaces.c: Make symbols static if they're not exported.
15994 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
15995 Remove decls.
15996 * xterm.h (defined_color): Remove decls.
15997 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
15998 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
15999 (menu_face_changed_default, defined_color, free_realized_face):
16000 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
16001 (ascii_face_of_lisp_face): Remove; unused.
16002
8524aef3
PE
16003 * xdisp.c: Make symbols static if they're not exported.
16004 * dispextern.h (scratch_glyph_row, window_box_edges):
16005 (glyph_to_pixel_coords, set_cursor_from_row):
16006 (get_next_display_element, set_iterator_to_next):
16007 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
16008 (show_mouse_face): Remove decls
16009 * frame.h (message_buf_print): Likewise.
16010 * lisp.h (pop_message, set_message, check_point_in_composition):
16011 Likewise.
16012 * xterm.h (set_vertical_scroll_bar): Likewise.
16013 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
16014 (message_buf_print, scratch_glyph_row, displayed_buffer):
16015 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
16016 (get_next_display_element, show_mouse_face, window_box_edges):
16017 (frame_to_window_pixel_xy, check_point_in_composition):
16018 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
16019 (glyph_to_pixel_coords): Remove; unused.
16020
16390cd2
PE
16021 * dired.c (file_name_completion): Now static.
16022
16023 * dbusbind.c (xd_in_read_queued_messages): Now static.
16024
a25f4dfa
PE
16025 * lisp.h (circular_list_error, FOREACH): Remove; unused.
16026 * data.c (circular_list_error): Remove.
16027
14a9c8df
PE
16028 * commands.h (last_point_position, last_point_position_buffer):
16029 (last_point_position_window): Remove decls.
16030 * keyboard.c: Make these variables static.
16031
04f2d78b
CB
16032 * coding.h (coding, code_convert_region, encode_coding_gap):
16033 Remove decls.
74ab6df5
PE
16034 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
16035 (iso_code_class, detect_coding, code_convert_region): Now static.
16036 (encode_coding_gap): Remove; unused.
16037
38dfbee1
PE
16038 * chartab.c (chartab_chars, chartab_bits): Now static.
16039
a2cb4e63
PE
16040 * charset.h (charset_iso_8859_1): Remove decl.
16041 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
16042 Now static.
16043
127198fd
PE
16044 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
16045 * ccl.c (Vccl_program_table): Now static.
16046 (check_ccl_update): Remove; unused.
16047
d85b608f
PE
16048 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
16049 * category.h: ... from here.
16050 * category.c (check_category_table, set_category_set): Now static.
16051
31cd66f3
PE
16052 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
16053 * lisp.h: Remove these decls.
16054
c358e587
PE
16055 * buffer.c (buffer_count): Remove unused var.
16056
e78aecca
PE
16057 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
16058 so that it's not optimized away.
16059 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
16060 * dispextern.h (bidi_dump_cached_states): Remove, since it's
16061 exported only to the debugger.
16062
e192d7d3 16063 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 16064 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 16065
92470028
PE
16066 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
16067 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
16068 was inaccessible from Lisp.
16069 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
16070 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
16071
244ed907
PE
16072 alloc.c: Import and export fewer symbols, and remove unused items.
16073 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
16074 is defined.
16075 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
16076 it's not optimized away by whole-program optimization.
16077 (message_enable_multibyte, free_misc): Remove.
16078 (catchlist, handlerlist, mark_backtrace):
16079 Declare only if BYTE_MARK_STACK.
16080 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
16081 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
16082 (message_enable_multibyte): Remove decl.
16083 (free_misc, interval_free_list, float_block, float_block_index):
16084 (n_float_blocks, float_free_list, cons_block, cons_block_index):
16085 (cons_free_list, last_marked_index):
16086 Now static.
16087 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
16088 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
16089 (mark_backtrace): Define only if BYTE_MARK_STACK.
16090 * xdisp.c (message_enable_multibyte): Now static.
16091
61c2b50e 16092 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
16093 This makes it easier for human readers (and static analyzers)
16094 to see whether these variables are used from other modules.
16095 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
16096 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
16097 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
16098 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
16099 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
16100 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
16101 * xmenu.c, xselect.c:
16102 Declare Q* vars static if they are not used in other modules.
16103 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
16104 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
16105 Remove decls of unexported vars.
16106 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
16107
95c82688
PE
16108 * lisp.h (DEFINE_FUNC): Make sname 'static'.
16109
16a97296
PE
16110 Make Emacs functions such as Fatom 'static' by default.
16111 This makes it easier for human readers (and static analyzers)
16112 to see whether these functions can be called from other modules.
16113 DEFUN now defines a static function. To make the function external
16114 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
16115 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
16116 (Finit_image_library):
16a97296
PE
16117 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
16118 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
16119 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
16120 Remove decls, since these functions are now static.
16121 (Funintern, Fget_internal_run_time): New decls, since these functions
16122 were already external.
95c82688 16123
16a97296
PE
16124 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
16125 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
16126 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
16127 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
16128 * keyboard.c, keymap.c, lread.c:
16129 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
16130 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
16131 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
16132 Mark functions with DEFUE instead of DEFUN,
16133 if they are used in other modules.
16134 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
16135 decls for now-static functions.
16136 * buffer.h (Fdelete_overlay): Remove decl.
16137 * callproc.c (Fgetenv_internal): Mark as internal.
16138 * composite.c (Fremove_list_of_text_properties): Remove decl.
16139 (Fcomposition_get_gstring): New forward static decl.
16140 * composite.h (Fcomposite_get_gstring): Remove decl.
16141 * dired.c (Ffile_attributes): New forward static decl.
16142 * doc.c (Fdocumntation_property): New forward static decl.
16143 * eval.c (Ffetch_bytecode): New forward static decl.
16144 (Funintern): Remove extern decl; now in .h file where it belongs.
16145 * fileio.c (Fmake_symbolic_link): New forward static decl.
16146 * image.c (Finit_image_library): New forward static decl.
16147 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
16148 * intervals.h (Fprevious_property_change):
16149 (Fremove_list_of_text_properties): Remove decls.
16150 * keyboard.c (Fthis_command_keys): Remove decl.
16151 (Fcommand_execute): New forward static decl.
16152 * keymap.c (Flookup_key): New forward static decl.
16153 (Fcopy_keymap): Now static.
16154 * keymap.h (Flookup_key): Remove decl.
16155 * process.c (Fget_process): New forward static decl.
16156 (Fprocess_datagram_address): Mark as internal.
16157 * syntax.c (Fsyntax_table_p): New forward static decl.
16158 (skip_chars): Remove duplicate decl.
16159 * textprop.c (Fprevious_property_change): New forward static decl.
16160 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
16161 Now internal.
16162 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
16163 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
16164
785bbd42
PE
16165 * editfns.c (Fformat): Remove unreachable code.
16166
8b913b57
AS
161672011-04-14 Andreas Schwab <schwab@linux-m68k.org>
16168
16169 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
16170 change. (Bug#8496)
16171
a6744a35
EZ
161722011-04-13 Eli Zaretskii <eliz@gnu.org>
16173
16174 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
16175 when at ZV. (Bug#8487)
16176
e7974947
AS
161772011-04-12 Andreas Schwab <schwab@linux-m68k.org>
16178
baad03f0
AS
16179 * charset.c (Fclear_charset_maps): Use xfree instead of free.
16180 (Bug#8437)
16181 * keyboard.c (parse_tool_bar_item): Likewise.
16182 * sound.c (sound_cleanup, alsa_close): Likewise.
16183 * termcap.c (tgetent): Likewise.
16184 * xfns.c (x_default_font_parameter): Likewise.
16185 * xsettings.c (read_and_apply_settings): Likewise.
16186
e7974947
AS
16187 * alloc.c (overrun_check_malloc, overrun_check_realloc)
16188 (overrun_check_free): Protoize.
16189
28272684
PE
161902011-04-12 Paul Eggert <eggert@cs.ucla.edu>
16191
16192 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
16193 since callers should never pass a negative size.
16194 Change the signature to match that of plain 'read' and 'write'; see
16195 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
16196 * lisp.h: Update prototypes of emacs_write and emacs_read.
16197
11997c76
EZ
161982011-04-11 Eli Zaretskii <eliz@gnu.org>
16199
16200 * xdisp.c (redisplay_window): Don't try to determine the character
16201 position of the scroll margin if the window start point w->startp
e896f03c 16202 is outside the buffer's accessible region. (Bug#8468)
11997c76 16203
8a2cbd72
EZ
162042011-04-10 Eli Zaretskii <eliz@gnu.org>
16205
16206 Fix write-region and its subroutines for buffers > 2GB.
16207 * fileio.c (a_write, e_write): Modify declaration of arguments and
16208 local variables to support buffers larger than 2GB.
16209 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
16210
16211 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
16212 argument, local variables, and return value.
16213
16214 * lisp.h: Update prototypes of emacs_write and emacs_read.
16215
16216 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
16217
4073e537 162182011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 16219
1ebfdcb6
PE
16220 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
16221
b2ded58d
PE
16222 Fix more problems found by GCC 4.6.0's static checks.
16223
7d66342c
PE
16224 * xdisp.c (vmessage): Use a better test for character truncation.
16225
bbf47d44
PE
16226 * charset.c (load_charset_map): <, not <=, for optimization,
16227 and to avoid potential problems with integer overflow.
9248994d 16228 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 16229 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 16230 * editfns.c (Fformat): Likewise.
1e69125e 16231 * syntax.c (skip_chars): Likewise.
3befa583 16232
e3019616
PE
16233 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
16234 This also lets GCC 4.6.0 generate slightly better loop code.
16235
becfa255
PE
16236 * callint.c (Fcall_interactively): <, not <=, for optimization.
16237 (Fcall_interactively): Count the number of arguments produced,
16238 not the number of arguments given. This is simpler and lets GCC
16239 4.6.0 generate slightly better code.
16240
dae0cd48
PE
16241 * ftfont.c: Distingish more carefully between FcChar8 and char.
16242 The previous code passed unsigned char * to a functions like
16243 strlen and xstrcasecmp that expect char *, which does not
16244 conform to the C standard.
16245 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
16246 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
16247 char * when the C standard requires it.
16248
76032d70
PE
16249 * keyboard.c (read_char): Remove unused var.
16250
eb3f1cc8
PE
16251 * eval.c: Port to Windows vsnprintf (Bug#8435).
16252 Include <limits.h>.
16253 (SIZE_MAX): Define if the headers do not.
16254 (verror): Do not give up if vsnprintf returns a negative count.
16255 Instead, grow the buffer. This ports to Windows vsnprintf, which
16256 does not conform to C99. Problem reported by Eli Zaretskii.
16257 Also, simplify the allocation scheme, by avoiding the need for
16258 calling realloc, and removing the ALLOCATED variable.
16259
70476b54
PE
16260 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
16261
12020a9e
PE
16262 Remove invocations of doprnt, as Emacs now uses vsnprintf.
16263 But keep the doprint source code for now, as we might revamp it
16264 and use it again (Bug#8435).
ea6c7ae6
PE
16265 * lisp.h (doprnt): Remove.
16266 * Makefile.in (base_obj): Remove doprnt.o.
16267 * deps.mk (doprnt.o): Remove.
16268
5fdb398c
PE
16269 error: Print 32- and 64-bit integers portably (Bug#8435).
16270 Without this change, on typical 64-bit hosts error ("...%d...", N)
16271 was used to print both 32- and 64-bit integers N, which relied on
16272 undefined behavior.
61bdb816 16273 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
16274 * lisp.h (error, verror): Mark as printf-like functions.
16275 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
16276 Report overflow in size calculations when allocating printf buffer.
16277 Do not truncate output string at its first null byte.
16278 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
16279 Truncate the output at a character boundary, since vsnprintf does not
16280 do that.
16281 * charset.c (check_iso_charset_parameter): Convert internal
16282 character to string before calling 'error', since %c now has the
16283 printf meaning.
16284 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
16285 overflow when computing char to be passed to 'error'. Do not
16286 pass Lisp_Object to 'error'; pass the integer instead.
16287 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
16288 formatted with plain %d.
16289
b189fa66
PE
16290 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
16291
bff87ef0
PE
16292 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
16293
7e2cac20
PE
16294 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
16295
ce4d90b5
PE
16296 * xterm.c (x_catch_errors): Remove duplicate declaration.
16297
266c9547
PE
16298 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
16299
79c49ad2
PE
16300 * xdisp.c, lisp.h (message_nolog): Remove; unused.
16301
368f4090
JM
163022011-04-10 Jim Meyering <meyering@redhat.com>
16303
16304 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
16305 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
16306 return ssize_t not "int", and use size_t as the buffer length.
16307 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
16308 * gnutls.h: Update declarations.
16309 * process.c (read_process_output): Use ssize_t, to match.
16310 (send_process): Likewise.
16311
a32d4040
CY
163122011-04-09 Chong Yidong <cyd@stupidchicken.com>
16313
16314 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
16315
8546720e 163162011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 16317
04f2d78b
CB
16318 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
16319 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 16320
8546720e
GM
16321 * xterm.c (handle_one_xevent):
16322 * xmenu.c (create_and_show_popup_menu):
16323 * xselect.c (x_decline_selection_request)
16324 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 16325
0a2f5c1a 163262011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
16327
16328 Fix some uses of `int' instead of EMACS_INT.
16329 * search.c (string_match_1, fast_string_match)
16330 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
16331 (scan_buffer, find_next_newline_no_quit)
16332 (find_before_next_newline, search_command, Freplace_match)
16333 (Fmatch_data): Make some `int' variables be EMACS_INT.
16334
16335 * xdisp.c (display_count_lines): 3rd argument and return value now
16336 EMACS_INT. All callers changed.
16337 (pint2hrstr): Last argument is now EMACS_INT.
16338
16339 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
16340 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
16341 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
16342 (decode_coding_utf_16, decode_coding_emacs_mule)
16343 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
16344 (decode_coding_ccl, decode_coding_charset)
16345 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
16346 (decode_coding_iso_2022, decode_coding_emacs_mule)
16347 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
16348 <char_offset, last_offset>: Declare EMACS_INT.
16349 (encode_coding_utf_8, encode_coding_utf_16)
16350 (encode_coding_emacs_mule, encode_invocation_designation)
16351 (encode_designation_at_bol, encode_coding_iso_2022)
16352 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
16353 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
16354 Declare EMACS_INT.
16355 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
16356 (encode_invocation_designation): Last argument P_NCHARS is now
16357 EMACS_INT.
16358 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
16359 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
16360
16361 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
16362 All users changed.
16363
16364 * ccl.c (Fccl_execute_on_string): Declare some variables
16365 EMACS_INT.
16366
8546720e 163672011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
16368
16369 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
16370
4e19a977
CS
163712011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
16372
16373 * process.c (Fformat_network_address): Doc fix.
16374
87302331
R
163752011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
16376
ee7683eb 16377 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 16378
cbb59342
CY
163792011-04-08 Chong Yidong <cyd@stupidchicken.com>
16380
16381 * keyboard.c (read_char): Call Lisp function help-form-show,
16382 instead of using internal_with_output_to_temp_buffer.
16383 (Qhelp_form_show): New var.
e0d38eeb 16384 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
16385
16386 * print.c (internal_with_output_to_temp_buffer): Function deleted.
16387
16388 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
16389
e67a13ab
CY
163902011-04-06 Chong Yidong <cyd@stupidchicken.com>
16391
04f2d78b
CB
16392 * process.c (Flist_processes): Remove to Lisp.
16393 (list_processes_1): Delete.
e67a13ab 16394
973f782d
EZ
163952011-04-06 Eli Zaretskii <eliz@gnu.org>
16396
7c106b1e
EZ
16397 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
16398
973f782d
EZ
16399 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
16400
41cf7d1a 164012011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 16402
ca23cc88
PE
16403 Fix more problems found by GCC 4.6.0's static checks.
16404
f390e2d5
PE
16405 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
16406
42eea0d0
PE
16407 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
16408
b69769da 16409 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 16410
f9541e84
PE
16411 * xdisp.c (vmessage): Mark as a printf-like function.
16412
13841b55
PE
16413 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
16414
c136c10f
PE
16415 * sound.c (sound_warning): Don't crash if arg contains a printf format.
16416
5e2d4a30
PE
16417 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
16418 printf-like functions.
16419 (tiff_load): Add casts to remove these marks before passing them
16420 to system-supplied API.
16421
583f48b9
PE
16422 * eval.c (Fsignal): Remove excess argument to 'fatal'.
16423
b25d760e
PE
16424 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
16425 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
16426 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
16427 directly, rather than having caller test rule sign. This avoids
16428 some unnecessary tests.
16429 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
16430 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
16431 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 16432
bc7b6697 16433 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 16434 (xfont_open): Avoid unnecessary tests.
bc7b6697 16435
27ccc379
PE
16436 * composite.c (composition_gstring_put_cache): Use unsigned integer.
16437
dcd5c89a
PE
16438 * composite.h, composite.c (composition_gstring_put_cache):
16439 Use EMACS_INT, not int, for length.
16440
b13a45c6
PE
16441 * composite.h (COMPOSITION_DECODE_REFS): New macro,
16442 breaking out part of COMPOSITION_DECODE_RULE.
16443 (COMPOSITION_DECODE_RULE): Use it.
16444 * composite.c (get_composition_id): Remove unused local vars,
16445 by using the new macro.
16446
1e792e4d
PE
16447 * textprop.c (set_text_properties_1): Change while to do-while,
16448 since the condition is always true at first.
16449
dc6c6455 16450 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
16451 (interval_deletion_adjustment): Return unsigned value.
16452 All uses changed.
dc6c6455 16453
aba7731a
PE
16454 * process.c (list_processes_1, create_pty, read_process_output):
16455 (exec_sentinel): Remove vars that were set but not used.
afd4052b 16456 (create_pty): Remove unnecessary "volatile"s.
bc57d757 16457 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 16458 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 16459 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 16460
fdfc4bf3
PE
16461 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
16462
fca8fe46 16463 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 16464 (update_syntax_table): Use unsigned instead of int.
fca8fe46 16465
06a0259a 16466 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 16467 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 16468 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 16469
e7b9e80f
PE
16470 * print.c (print_error_message): Avoid int overflow.
16471
56201685
PE
16472 * font.c (font_list_entities): Redo for clarity,
16473 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
16474
78834453 16475 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 16476 (font_score): Avoid potential overflow in diff calculation.
78834453 16477
0bc0b309 16478 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 16479 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 16480
e610eaca
PE
16481 * eval.c (funcall_lambda): Rename local to avoid shadowing.
16482
b895abce
PE
16483 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
16484 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
16485 can always succeed if overflow has undefined behavior.
16486
1f1d9321 16487 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 16488 (wordify): Omit three unnecessary tests.
1f1d9321 16489
c59478bc
PE
16490 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
16491 All callers changed. This avoids the need for an unused var.
16492
79b73827
PE
16493 * casefiddle.c (casify_region): Remove var that is set but not used.
16494
a4db5dfe
PE
16495 * dired.c (file_name_completion): Remove var that is set but not used.
16496
43aae36e
PE
16497 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
16498
2a47c44d 16499 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 16500 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 16501
a37c69bf
PE
16502 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
16503 Check for integer overflow on size calculations.
16504
328ab8e7
PE
16505 * buffer.c (Fprevious_overlay_change): Remove var that is set
16506 but not used.
16507
e5a2a5cb
PE
16508 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
16509 Remove vars that are set but not used.
8d84a6eb 16510 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 16511 (timer_check_2): Mark vars as initialized.
e5a2a5cb 16512
a60e5f68
PE
16513 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
16514
f661cb61 16515 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 16516 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 16517
f0397f5a
PE
16518 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
16519 that are set but not used.
16520
8664db06 16521 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 16522 if XCreateBitmapFromData fails (Bug#8410).
8664db06 16523
6abdaa4a
PE
16524 * xselect.c (x_get_local_selection, x_handle_property_notify):
16525 Remove vars that are set but not used.
16526
0ce7538d 16527 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 16528 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 16529
9ae848fc
PE
16530 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
16531 Remove var that is set but not used.
0b918413
PE
16532 (scroll_bar_windows_size): Now size_t, not int.
16533 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
16534 Check for overflow.
9ae848fc 16535
a5a62657
PE
16536 * xfaces.c (realize_named_face): Remove vars that are set but not used.
16537 (map_tty_color) [!defined MSDOS]: Likewise.
16538
5c5cdd39
PE
16539 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
16540
66ebf983
PE
16541 * coding.c: Remove vars that are set but not used.
16542 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
16543 All callers changed.
16544 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
16545 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
16546 (decode_coding_charset): Remove vars that are set but not used.
16547
1be4d761
PE
16548 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
16549 that is set but not used.
16550
47553fa8
PE
16551 * print.c (print_object): Remove var that is set but not used.
16552
1f7196bf 16553 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
16554 The gnulib version avoids calling malloc in the usual case,
16555 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
16556 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
16557 * filelock.c (current_lock_owner): Likewise.
16558 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
16559 * sysdep.c: Include allocator.h, careadlinkat.h.
16560 (emacs_no_realloc_allocator): New static constant.
16561 (emacs_readlink): New function.
fdb61804
PE
16562 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
16563 ../lib/careadlinkat.h.
d1fdcab7 16564
f84c17c7
SM
165652011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
16566
16567 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
16568 first non-nil return value).
16569
ef3862ad
JD
165702011-04-03 Jan Djärv <jan.h.d@swipnet.se>
16571
16572 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
16573 if not defined (Bug#8403).
16574
376a7006
JB
165752011-04-02 Juanma Barranquero <lekktu@gmail.com>
16576
16577 * xdisp.c (display_count_lines): Remove parameter `start',
16578 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
16579 (get_char_face_and_encoding): Remove parameter `multibyte_p',
16580 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
16581 (fill_stretch_glyph_string): Remove parameters `row' and `area',
16582 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
16583 and thereabouts. All callers changed.
16584 (get_per_char_metric): Remove parameter `f', unused since
16585 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
16586
6ca3801d
JM
165872011-04-02 Jim Meyering <meyering@redhat.com>
16588
16589 do not dereference NULL upon failed strdup
16590 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
16591 (ns_get_family): Likewise.
16592
d8e2b5ba
JB
165932011-04-02 Juanma Barranquero <lekktu@gmail.com>
16594
16595 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
16596
8c74fcbd
JD
165972011-04-02 Jan Djärv <jan.h.d@swipnet.se>
16598
16599 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
16600 later (Bug#8403).
16601
7200d79c
SM
166022011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
16603
03408648 16604 Add lexical binding.
7200d79c 16605
03408648
SM
16606 * window.c (Ftemp_output_buffer_show): New fun.
16607 (Fsave_window_excursion):
16608 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
16609
16610 * lread.c (lisp_file_lexically_bound_p): New function.
16611 (Fload): Bind Qlexical_binding.
16612 (readevalloop): Remove `evalfun' arg.
16613 Bind Qinternal_interpreter_environment.
16614 (Feval_buffer): Bind Qlexical_binding.
16615 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
16616 Mark as dynamic.
16617 (syms_of_lread): Declare `lexical-binding'.
16618
16619 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
16620
16621 * keyboard.c (eval_dyn): New fun.
16622 (menu_item_eval_property): Use it.
ca105506
SM
16623
16624 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 16625
03408648
SM
16626 * fns.c (concat, mapcar1): Accept byte-code-functions.
16627
16628 * eval.c (Fsetq): Handle lexical vars.
16629 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
16630 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
16631 (FletX, Flet): Obey lexical binding.
16632 (Fcommandp): Handle closures.
16633 (Feval): New `lexical' arg.
16634 (eval_sub): New function extracted from Feval. Use it almost
16635 everywhere where Feval was used. Look up vars in lexical env.
16636 Handle closures.
16637 (Ffunctionp): Move from subr.el.
16638 (Ffuncall): Handle closures.
16639 (apply_lambda): Remove `eval_flags'.
16640 (funcall_lambda): Handle closures and new byte-code-functions.
16641 (Fspecial_variable_p): New function.
16642 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
16643 but without exporting it to Lisp.
23aba0ea 16644
23aba0ea 16645 * doc.c (Fdocumentation, store_function_docstring):
03408648 16646 * data.c (Finteractive_form): Handle closures.
23aba0ea 16647
03408648
SM
16648 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
16649 interactive spec.
ba83908c 16650
04f2d78b
CB
16651 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
16652 New byte-codes.
03408648
SM
16653 (exec_byte_code): New function extracted from Fbyte_code to handle new
16654 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 16655
03408648 16656 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 16657
03408648 16658 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 16659
e2abce01
JB
166602011-03-31 Juanma Barranquero <lekktu@gmail.com>
16661
16662 * xdisp.c (redisplay_internal): Fix prototype.
16663
63696a73 166642011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 16665
63696a73 16666 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
16667 (try_scrolling): Use it when setting scroll_limit.
16668 Limit scrolling to 100 screen lines.
63696a73
EZ
16669 (redisplay_window): Even when falling back on "recentering",
16670 position point in the window according to scroll-conservatively,
16671 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
16672
16673 (try_scrolling): When point is above the window, allow searching
16674 as far as scroll_max, or one screenful, to compute vertical
16675 distance from PT to the scroll margin position. This prevents
16676 try_scrolling from unnecessarily failing when
16677 scroll-conservatively is set to a value slightly larger than the
16678 window height. Clean up the case of PT below the margin at bottom
16679 of window: scroll_max can no longer be INT_MAX. When aggressive
16680 scrolling is in use, don't let point enter the opposite scroll
16681 margin as result of the scroll.
16682 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
16683 threshold of 100 lines for never-recentering scrolling.
16684
e4cc2dfc
JB
166852011-03-31 Juanma Barranquero <lekktu@gmail.com>
16686
16687 * dispextern.h (move_it_by_lines):
16688 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
16689 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
16690 (message_log_check_duplicate): Remove parameters `prev_bol' and
16691 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
16692 (redisplay_internal): Remove parameter `preserve_echo_area',
16693 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
16694
16695 * indent.c (Fvertical_motion):
16696 * window.c (window_scroll_pixel_based, Frecenter):
16697 Don't pass `need_y_p' to `move_it_by_lines'.
16698
1c470562
SM
166992011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
16700
44f230aa
SM
16701 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
16702 steal a few bits to be more compact.
16703 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
16704 Remove unneeded casts.
16705
1c470562
SM
16706 * bytecode.c (Fbyte_code): CAR and CDR can GC.
16707
888adce9
ZK
167082011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
16709
16710 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
16711 binding" message (bug#7967).
16712
f838ed7b
PE
167132011-03-30 Paul Eggert <eggert@cs.ucla.edu>
16714
77861b95
PE
16715 Fix more problems found by GCC 4.6.0's static checks.
16716
de6dbc14
PE
16717 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
16718 Remove unused local var.
16719
f838ed7b
PE
16720 * editfns.c (Fmessage_box): Remove unused local var.
16721
792c7b2b
PE
16722 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
16723 (note_mode_line_or_margin_highlight, note_mouse_highlight):
16724 Omit unused local vars.
c499e557 16725 * window.c (shrink_windows): Omit unused local var.
b01a1c29 16726 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
16727 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
16728 Omit unused local var.
16729
ba0165e1
PE
16730 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
16731 Don't assume string length fits in int.
32ad8845 16732 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 16733 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 16734
3c59b4c9
PE
16735 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
16736 instead of alloca (Bug#8344).
16737
a3eed478 16738 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 16739 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 16740
eb4d412d
PE
16741 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
16742
1658b401
PE
16743 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
16744 concerns.
16745
16746 * term.c (produce_glyphless_glyph): Remove unnecessary test.
16747
16748 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 16749
9a2c6e05
PE
16750 * keyboard.c (syms_of_keyboard): Use the same style as later
16751 in this function when indexing through an array. This also
16752 works around GCC bug 48267.
16753
03d0a109
PE
16754 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
16755
44f730c8
PE
16756 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
16757
fe75f926
PE
16758 * chartab.c (sub_char_table_ref_and_range): Redo for slight
16759 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
16760
ffa8c828
PE
16761 * keyboard.c, keyboard.h (num_input_events): Now size_t.
16762 This avoids undefined behavior on integer overflow, and is a bit
16763 more convenient anyway since it is compared to a size_t variable.
16764
c5101a77
PE
16765 Variadic C functions now count arguments with size_t, not int.
16766 This avoids an unnecessary limitation on 64-bit machines, which
16767 caused (substring ...) to crash on large vectors (Bug#8344).
16768 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
16769 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 16770 All variadic functions and their callers changed accordingly.
c5101a77
PE
16771 (struct gcpro.nvars): Now size_t, not int. All uses changed.
16772 * data.c (arith_driver, float_arith_driver): Likewise.
16773 * editfns.c (general_insert_function): Likewise.
16774 * eval.c (struct backtrace.nargs, interactive_p)
16775 (internal_condition_case_n, run_hook_with_args, apply_lambda)
16776 (funcall_lambda, mark_backtrace): Likewise.
16777 * fns.c (concat): Likewise.
16778 * frame.c (x_set_frame_parameters): Likewise.
16779 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
16780 0 if not found, not -1. All callers changed.
16781
dd3f25f7
PE
16782 * alloc.c (garbage_collect): Don't assume stack size fits in int.
16783 (stack_copy_size): Now size_t, not int.
16784 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
16785
461c2ab9
JB
167862011-03-28 Juanma Barranquero <lekktu@gmail.com>
16787
16788 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
16789 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16790 All callers changed.
16791
16792 * lisp.h (multibyte_char_to_unibyte):
16793 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
16794 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16795 * character.h (CHAR_TO_BYTE8):
16796 * cmds.c (internal_self_insert):
16797 * editfns.c (general_insert_function):
16798 * keymap.c (push_key_description):
16799 * search.c (Freplace_match):
16800 * xdisp.c (message_dolog, set_message_1): All callers changed.
16801
f6d62986
SM
168022011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
16803
16804 * keyboard.c (safe_run_hook_funcall): New function.
16805 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
16806 don't set the hook to nil, but remove the offending function instead.
16807 (Qcommand_hook_internal): Remove, unused.
16808 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
16809 Vcommand_hook_internal.
16810
16811 * eval.c (enum run_hooks_condition): Remove.
16812 (funcall_nil, funcall_not): New functions.
16813 (run_hook_with_args): Call each function through a `funcall' argument.
16814 Remove `cond' argument, now redundant.
16815 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
16816 (Frun_hook_with_args_until_failure): Adjust accordingly.
16817 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
16818
1db5b1ad
JB
168192011-03-28 Juanma Barranquero <lekktu@gmail.com>
16820
16821 * dispextern.h (string_buffer_position): Remove declaration.
16822
16823 * print.c (strout): Remove parameter `multibyte', unused since
16824 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
16825
16826 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
16827 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
16828 All callers changed.
16829
16830 * w32.c (_wsa_errlist): Use braces for struct initializers.
16831
16832 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
16833 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
16834 All callers changed.
16835 (string_buffer_position): Likewise. Also, make static (it's never
16836 used outside xdisp.c).
16837 (cursor_row_p): Remove parameter `w', unused since
16838 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
16839 (decode_mode_spec): Remove parameter `precision', introduced during
16840 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
16841 All callers changed.
16842
5ffb62aa
JD
168432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16844
16845 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
16846
461c2ab9 168472011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
16848
16849 * nsterm.m (ns_menu_bar_is_hidden): New variable.
16850 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
16851 (ns_update_auto_hide_menu_bar): New functions.
16852 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
16853 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
16854 ns_constrain_all_frames.
16855 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
16856 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
16857
5c380ffb
JD
168582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16859
16860 * nsmenu.m (runDialogAt): Remove argument to timer_check.
16861
9af30bdf
GM
168622011-03-27 Glenn Morris <rgm@gnu.org>
16863
16864 * syssignal.h: Replace RETSIGTYPE with void.
16865 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
16866 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
16867 Replace SIGTYPE with void everywhere.
16868 * s/usg5-4-common.h (SIGTYPE): Remove definition.
16869 * s/template.h (SIGTYPE): Remove commented out definition.
16870
e2abce01
JB
168712011-03-26 Eli Zaretskii <eliz@gnu.org>
16872
16873 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
16874 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
16875
f868cd8a
JB
168762011-03-26 Juanma Barranquero <lekktu@gmail.com>
16877
59eb0929
JB
16878 * w32.c (read_unc_volume): Use parameter `henum', instead of
16879 global variable `wget_enum_handle'.
16880
16881 * keymap.c (describe_vector): Remove parameters `indices' and
16882 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
16883 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
16884
f868cd8a
JB
16885 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
16886
16887 * keyboard.c (timer_check): Remove parameter `do_it_now',
16888 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
16889 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
16890 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
16891
16892 * keyboard.c (read_char):
16893 * w32menu.c (w32_menu_display_help):
16894 * xmenu.c (show_help_event, menu_help_callback):
16895 Adjust calls to `show_help_echo'.
16896
16897 * gtkutil.c (xg_maybe_add_timer):
16898 * keyboard.c (readable_events):
16899 * process.c (wait_reading_process_output):
16900 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
16901
16902 * insdel.c (adjust_markers_gap_motion):
16903 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
16904 (gap_left, gap_right): Don't call it.
16905
2ecf6fdb
CY
169062011-03-25 Chong Yidong <cyd@stupidchicken.com>
16907
16908 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
16909 incurred during fontification.
16910
6b1f9ba4
JB
169112011-03-25 Juanma Barranquero <lekktu@gmail.com>
16912
16913 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
16914 (DEFVAR_PER_BUFFER): Don't pass it.
16915
16916 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
16917 (scrolling_window): Don't pass it.
16918
0f4a96b5
JB
169192011-03-25 Juanma Barranquero <lekktu@gmail.com>
16920
16921 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
16922
16923 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
16924 and `suffix'.
16925 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
16926 of variables specific to SELinux and computation of `encoded_absname'.
16927
16928 * image.c (XPutPixel): Remove unused variable `height'.
16929
16930 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
16931
16932 * unexw32.c (get_section_info): Remove unused variable `section'.
16933
16934 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
16935 (system_process_attributes): Remove unused variable `sess'.
16936 (sys_read): Remove unused variable `err'.
16937
16938 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
16939 (w32_wnd_proc): Remove unused variable `isdead'.
16940 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
16941 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
16942 (x_create_tip_frame): Remove unused variable `tem'.
16943
16944 * w32inevt.c (w32_console_read_socket):
16945 Remove unused variable `no_events'.
16946
16947 * w32term.c (x_draw_composite_glyph_string_foreground):
16948 Remove unused variable `width'.
16949
1149507c
JB
169502011-03-24 Juanma Barranquero <lekktu@gmail.com>
16951
16952 * w32term.c (x_set_glyph_string_clipping):
16953 Don't pass uninitialized region to CombineRgn.
16954
9c88f339
JB
169552011-03-23 Juanma Barranquero <lekktu@gmail.com>
16956
16957 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
16958 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
16959 (Fx_close_connection): Remove unused variable `i'.
16960
16961 * w32font.c (w32font_draw): Return number of glyphs.
16962 (w32font_open_internal): Remove unused variable `i'.
16963 (w32font_driver): Add missing initializer.
16964
16965 * w32menu.c (utf8to16): Remove unused variable `utf16'.
16966 (fill_in_menu): Remove unused variable `items_added'.
16967
16968 * w32term.c (last_mouse_press_frame): Remove static global variable.
16969 (w32_clip_to_row): Remove unused variable `f'.
16970 (x_delete_terminal): Remove unused variable `i'.
16971
16972 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
16973 (NOTHING): Remove unused static global variable.
16974 (uniscribe_check_otf): Remove unused variable `table'.
16975 (uniscribe_font_driver): Add missing initializers.
16976
dee091a3
JD
169772011-03-23 Julien Danjou <julien@danjou.info>
16978
16979 * term.c (Fsuspend_tty, Fresume_tty):
16980 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
16981 * window.c (temp_output_buffer_show):
16982 * insdel.c (signal_before_change):
16983 * frame.c (Fhandle_switch_frame):
16984 * fileio.c (Fdo_auto_save):
16985 * emacs.c (Fkill_emacs):
16986 * editfns.c (save_excursion_restore):
16987 * cmds.c (internal_self_insert):
16988 * callint.c (Fcall_interactively):
16989 * buffer.c (Fkill_all_local_variables):
16990 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
16991 Use Frun_hooks.
0f4a96b5 16992 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 16993 unconditionally since it does the check itself.
dee091a3 16994
2c520ab5 169952011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 16996
c9c49752
PE
16997 Fix more problems found by GCC 4.5.2's static checks.
16998
8abc3f12
PE
16999 * coding.c (encode_coding_raw_text): Avoid unnecessary test
17000 the first time through the loop, since we know p0 < p1 then.
17001 This also avoids a gcc -Wstrict-overflow warning.
17002
a2d26660
PE
17003 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
17004 leading to a memory leak, possible in functions like
17005 load_charset_map_from_file that can allocate an unbounded number
b12ef411 17006 of objects (Bug#8318).
a2d26660 17007
916c72e9
PE
17008 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
17009 that could (at least in theory) be that large.
17010
19ab8a18
PE
17011 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
17012 This is less likely to overflow, and avoids undefined behavior if
17013 overflow does occur. All callers changed. Use strtoul to scan
17014 for the unsigned long integer.
b7cbbd6f
PE
17015 (pint2hrstr): Simplify and tune code slightly.
17016 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 17017
f0641eff
PE
17018 * scroll.c (do_scrolling): Work around GCC bug 48228.
17019 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
17020
7f650bb9
PE
17021 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
17022 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
17023 (validate_x_resource_name): Simplify count usage.
17024 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 17025
37dd57d1
PE
17026 * fileio.c (Fcopy_file): Report error if fchown or fchmod
17027 fail (Bug#8306).
81e56e61 17028
699979fc 17029 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 17030
401bf9b4
PE
17031 * process.c (Fmake_network_process): Use socklen_t, not int,
17032 where POSIX says socklen_t is required in portable programs.
17033 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 17034 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
17035 (Fmake_network_process, server_accept_connection):
17036 (wait_reading_process_output, read_process_output):
17037 Likewise.
17038
b93aacde
PE
17039 * process.c: Rename or move locals to avoid shadowing.
17040 (list_processes_1, Fmake_network_process):
17041 (read_process_output_error_handler, exec_sentinel_error_handler):
17042 Rename or move locals.
4dc343ee 17043 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 17044 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 17045 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 17046 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 17047 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 17048
af8a867c 17049 Make tparam.h and terminfo.c consistent.
44f230aa
SM
17050 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
17051 Include tparam.h instead, since it declares them.
af8a867c
PE
17052 * cm.h (PC): Remove extern decl; tparam.h now does this.
17053 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
17054 * terminfo.c: Include tparam.h, to check interfaces.
17055 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
17056 (tparam): Adjust signature to match interface in tparam.h;
17057 this removes some undefined behavior. Check that outstring and len
17058 are zero, which they always are with Emacs.
17059 * tparam.h (PC, BC, UP): New extern decls.
17060
0248044d 17061 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 17062 (xftfont_open): Rename locals to avoid shadowing.
0248044d 17063
8ff096c1 17064 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
17065 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
17066 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 17067 (ftfont_list): Remove unused local.
49eaafba
PE
17068 (get_adstyle_property, ftfont_pattern_entity):
17069 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
17070 Rename locals to avoid shadowing.
8ff096c1 17071
e2be39f6
PE
17072 * xfont.c (xfont_list_family): Mark var as initialized.
17073
c9735e30
PE
17074 * xml.c (make_dom): Now static.
17075
8f5201ae
PE
17076 * composite.c (composition_compute_stop_pos): Rename local to
17077 avoid shadowing.
b246f932
PE
17078 (composition_reseat_it): Remove unused locals.
17079 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 17080 (composition_update_it): Mark var as initialized.
11b61122
PE
17081 (find_automatic_composition): Mark vars as initialized,
17082 with a FIXME (Bug#8290).
8f5201ae 17083
760fbc2c
PE
17084 character.h: Rename locals to avoid shadowing.
17085 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
17086 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
17087 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
17088 (BUF_DEC_POS): Be more systematic about renaming local temporaries
17089 to avoid shadowing.
17090
ff08eb85
PE
17091 * textprop.c (property_change_between_p): Remove; unused.
17092
fc7bf025
PE
17093 * intervals.c (interval_start_pos): Now static.
17094
235d7abc
PE
17095 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
17096
44f230aa
SM
17097 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
17098 Rename locals to avoid shadowing.
3e7d6594 17099
50060332
PE
17100 * sound.c (wav_play, au_play, Fplay_sound_internal):
17101 Fix pointer signedness.
d01f234b 17102 (alsa_choose_format): Remove unused local var.
c83b8872
PE
17103 (wav_play): Initialize a variable to 0, to prevent undefined
17104 behavior (Bug#8278).
50060332 17105
c4fc4e30
PE
17106 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
17107
918436ed
PE
17108 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
17109
c939f91b
PE
17110 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
17111 clobbering (Bug#8298).
b9c7f648
PE
17112 * sysdep.c (sys_subshell): Likewise.
17113 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 17114
6bd8c144
PE
17115 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
17116 This should get cleaned up, so that child_setup has the
17117 same signature on all platforms.
17118
7710357c 17119 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 17120 (relocate_fd): Rename locals to avoid shadowing.
7710357c 17121
c59da222
CY
171222011-03-22 Chong Yidong <cyd@stupidchicken.com>
17123
17124 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
17125 not to be necessary, and produces flickering.
17126
66b87493
GM
171272011-03-20 Glenn Morris <rgm@gnu.org>
17128
17129 * config.in: Remove file.
17130
45b6f6d5
JB
171312011-03-20 Juanma Barranquero <lekktu@gmail.com>
17132
17133 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
17134 are now in src/globals.h.
17135 (syms_of_minibuf): Remove spurious & from previous change.
17136
cd394be1 171372011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
17138
17139 * minibuf.c (completing-read-function): New variable.
17140 (completing-read-default): Rename from completing-read.
17141 (completing-read): Call completing-read-function.
17142
b14e3e21
CY
171432011-03-19 Juanma Barranquero <lekktu@gmail.com>
17144
17145 * xfaces.c (Fx_load_color_file):
17146 Read color file from absolute filename (bug#8250).
17147
f2b726e6
JB
171482011-03-19 Juanma Barranquero <lekktu@gmail.com>
17149
17150 * makefile.w32-in: Update dependencies.
17151
09f6ff02
EZ
171522011-03-17 Eli Zaretskii <eliz@gnu.org>
17153
17154 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
17155
29a6015a
PE
171562011-03-17 Paul Eggert <eggert@cs.ucla.edu>
17157
a3a6c54e
PE
17158 Fix more problems found by GCC 4.5.2's static checks.
17159
b766f867
PE
17160 * process.c (make_serial_process_unwind, send_process_trap):
17161 (sigchld_handler): Now static.
17162
be02381c
PE
17163 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
17164 That way, the code declares only the vars that it needs.
17165 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
17166 * s/cygwin.h (PTY_ITERATION): Likewise.
17167 * s/darwin.h (PTY_ITERATION): Likewise.
17168 * s/gnu-linux.h (PTY_ITERATION): Likewise.
17169
57048744
PE
17170 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
17171 * process.c (allocate_pty): Don't declare stb unless it's needed.
17172
7914961c 17173 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
17174 (CONSTANTLIM): Remove; unused.
17175 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
17176 Define only if needed.
7914961c 17177
b3967b18
PE
17178 * unexelf.c (unexec): Name an expression,
17179 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
17180 Use a different way to cause a compilation error if anyone uses
17181 n rather than nn, a way that does not involve shadowing.
73366a00 17182 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 17183
29a6015a
PE
17184 * deps.mk (unexalpha.o): Remove; unused.
17185
43cfc33e 17186 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 17187 * unexec.h: New file.
ce701a33
PE
17188 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
17189 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
17190 Depend on unexec.h.
17191 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
17192 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
17193 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 17194 Change as necessary to match prototype in unexec.h.
ce701a33 17195
01f44d5a
PE
17196 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
17197 shadowing.
4f63c6bb 17198 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 17199
a6670b0b
PE
17200 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
17201 Rename locals to avoid shadowing.
17202
cef2010d 17203 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 17204 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 17205
d4d7173a
PE
17206 * print.c (Fredirect_debugging_output): Fix pointer signedess.
17207
f08b802a
PE
17208 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
17209 warning when compiling print.c.
17210
3ddb0639
PE
17211 * font.c (font_unparse_fcname): Abort in an "impossible" situation
17212 instead of using an uninitialized var.
5ad03b97 17213 (font_sort_entities): Mark var as initialized.
3ddb0639 17214
170a2692
PE
17215 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
17216
e663c700
PE
17217 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
17218 pointers to constants.
89bc529a 17219 (font_parse_fcname): Remove unused vars.
7b81e2d0 17220 (font_delete_unmatched): Now static.
ea838e10 17221 (font_get_spec): Remove; unused.
13a547c6
PE
17222 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
17223 (font_update_drivers, Ffont_get_glyphs, font_add_log):
17224 Rename or move locals to avoid shadowing.
e663c700 17225
2a80c887 17226 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 17227 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 17228
1384fa33 17229 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 17230 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 17231
8b2c52e9
PE
17232 * alloc.c (mark_backtrace): Move decl from here ...
17233 * lisp.h: ... to here, so that it can be checked.
17234
475545b5 17235 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 17236 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
17237 (lisp_indirect_variable): Name an expression,
17238 to avoid gcc -Wbad-function-cast warning.
1faed8ae 17239 (Fdefvar): Rename locals to avoid shadowing.
475545b5 17240
b1349114 17241 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 17242 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 17243 Use const pointer when appropriate.
b1349114 17244
a2928364
PE
17245 * lisp.h (get_system_name, get_operating_system_release):
17246 Move decls here, to check interfaces.
17247 * process.c (get_operating_system_release): Move decl to lisp.h.
17248 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
17249 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
17250 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
17251 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
17252 (Fformat_time_string, Fencode_time, Finsert_char):
17253 (Ftranslate_region_internal, Fformat):
17254 Rename or remove local vars to avoid shadowing.
9710023e 17255 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 17256
a415e694
PE
17257 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
17258 avoid shadowing.
17259
8ef4622d
PE
17260 * lisp.h (eassert): Check that the argument compiles, even if
17261 ENABLE_CHECKING is not defined.
17262
946f9a5b
PE
17263 * data.c (Findirect_variable): Name an expression, to avoid
17264 gcc -Wbad-function-cast warning.
112396d6 17265 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 17266 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
17267 (Fmake_variable_buffer_local, Fmake_local_variable):
17268 Mark variables as initialized.
52746918 17269 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 17270
e5aab7e7 17271 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
17272 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
17273 Rename locals to avoid shadowing.
dff45157
PE
17274 (mark_stack): Move local variables into the #ifdef region where
17275 they're used.
7bc26fdb
PE
17276 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
17277 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
17278 needed otherwise.
17279 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
17280 (GC_STRING_CHARS): Remove; not used.
d40d4be1 17281 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 17282
e5aab7e7
PE
17283 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
17284 avoids undefined behavior in theory.
17285
4da60324
PE
17286 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
17287
88043301
PE
17288 Use functions, not macros, for up- and down-casing (Bug#8254).
17289 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17290 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
17291 to use the following functions instead of these macros.
17292 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
17293 EMACS_INT, since callers assume the returned value fits in int.
17294 (upcase1): Likewise, for UPCASE_TABLE.
17295 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 17296 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 17297 the race-condition problem in the old DOWNCASE.
88043301 17298
19ed5445
PE
17299 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
17300 Rename locals to avoid shadowing.
17301 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
17302 (regex_compile, re_search_2, re_match_2_internal):
17303 Remove unused local vars.
952db0d7
PE
17304 (FREE_VAR): Rewrite so as not to use empty "else",
17305 which gcc can warn about.
da053e48 17306 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
17307 (RETALLOC_IF): Define only if needed.
17308 (WORDCHAR_P): Likewise. This one is never needed, but is used
17309 only in a comment talking about a compiler bug, so put inside
17310 the #if 0 of that comment.
17311 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
17312 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
17313 Remove; unused.
19ed5445 17314
1f3561e4 17315 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
17316 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
17317 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 17318
ded6f8f7
PE
17319 * search.c (simple_search): Remove unused var.
17320
dbd37a95
PE
17321 * dired.c (compile_pattern): Move decl from here ...
17322 * lisp.h: ... to here, so that it can be checked.
17323 (struct re_registers): New forward decl.
17324
7e47afad
PE
17325 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
17326
85f24f61
PE
17327 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
17328 All uses changed.
17329 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
17330 Rename locals to avoid shadowing.
5671df8f 17331 (Fvertical_motion): Mark locals as initialized.
85f24f61 17332
181aa2be 17333 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 17334 (casify_region): Mark local as initialized.
181aa2be 17335
930d429c
PE
17336 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
17337
7082eac6
PE
17338 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
17339 New macros, so that the caller can use some names other than
17340 gcpro1, gcpro2, etc.
17341 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
17342 of the new macros.
17343 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
17344 argument, for consistency with GCPRO2_VAR, etc: it is now the
17345 prefix of the variable, not the variable itself. All uses
17346 changed.
38b2c076
PE
17347 * dired.c (directory_files_internal, file_name_completion):
17348 Rename locals to avoid shadowing.
17349
15206ed9
PE
17350 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
17351 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
17352 dired.c's scmp function, had undefined behavior.
17353 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17354 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
17355 * buffer.h: ... to here, because these macros use current_buffer,
17356 and the new implementation with inline functions needs to have
17357 current_buffer in scope now, rather than later when the macros
17358 are used.
17359 (downcase, upcase1): New static inline functions.
17360 (DOWNCASE, UPCASE1): Reimplement using these functions.
17361 This avoids undefined behavior in expressions like
17362 DOWNCASE (x) == DOWNCASE (y), which previously suffered
17363 from race conditions in accessing the global variables
17364 case_temp1 and case_temp2.
17365 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
17366 * lisp.h (case_temp1, case_temp2): Remove their decls.
17367 * character.h (ASCII_CHAR_P): Move from here ...
17368 * lisp.h: ... to here, so that the inline functions mentioned
17369 above can use them.
17370
4a6bea26
PE
17371 * dired.c (directory_files_internal_unwind): Now static.
17372
f14b7e14
PE
17373 * fileio.c (file_name_as_directory, directory_file_name):
17374 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
17375 Now static.
2893f146
PE
17376 (file_name_as_directory): Use const pointers when appropriate.
17377 (Fexpand_file_name): Likewise. In particular, newdir might
17378 point at constant storage, so make it a const pointer.
fd4ead52 17379 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
17380 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
17381 signedness issues.
f839df0c
PE
17382 (Fset_file_times, Finsert_file_contents, auto_save_error):
17383 Rename locals to avoid shadowing.
f14b7e14 17384
5716756e 17385 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
17386 (Ftry_completion, Fall_completions): Rename or remove locals
17387 to avoid shadowing.
5716756e 17388
b4c3046a
PE
17389 * marker.c (bytepos_to_charpos): Remove; unused.
17390
b45db522
PE
17391 * lisp.h (verify_bytepos, count_markers): New decls,
17392 so that gcc does not warn that these functions aren't declared.
17393
85876d07
PE
17394 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
17395 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 17396 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 17397 (copy_text): Remove unused local var.
85876d07 17398
03d78a21 17399 * filelock.c (within_one_second): Now static.
b3dd38ab 17400 (lock_file_1): Rename local to avoid shadowing.
03d78a21 17401
5df8f01b
PE
17402 * buffer.c (fix_overlays_before): Mark locals as initialized.
17403 (fix_start_end_in_overlays): Likewise. This function should be
17404 simplified by using pointers-to-pointers, but that's a different
17405 matter.
b1d876f1 17406 (switch_to_buffer_1): Now static.
8f54f30a
PE
17407 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
17408 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 17409
a70072c9 17410 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 17411 Fix pointer signedness issue.
edced198
PE
17412 (sys_subshell): Mark local as volatile if checking for lint,
17413 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 17414 (MAXPATHLEN): Define only if needed.
a70072c9 17415
a0977c44
PE
17416 * process.c (serial_open, serial_configure): Move decls from here ...
17417 * systty.h: ... to here, so that they can be checked.
17418
a884fdcc
PE
17419 * fns.c (get_random, seed_random): Move extern decls from here ...
17420 * lisp.h: ... to here, so that they can be checked.
17421
604efe86 17422 * sysdep.c (reset_io): Now static.
b8950c94 17423 (wait_for_termination_signal): Remove; unused.
604efe86 17424
38fc62d9
PE
17425 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
17426 (copy_keymap_item, append_key, push_text_char_description):
17427 Now static.
1004a21a 17428 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 17429 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
17430 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
17431 (describe_map_tree):
17432 Rename locals to avoid shadowing.
38fc62d9 17433
2f2650da
PE
17434 * keyboard.c: Declare functions static if they are not used elsewhere.
17435 (echo_char, echo_dash, cmd_error, top_level_2):
17436 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
17437 (read_char, kbd_buffer_get_event, make_lispy_position):
17438 (make_lispy_event, make_lispy_movement, apply_modifiers):
17439 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
17440 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
17441 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 17442 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 17443 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 17444
a053e86c 17445 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
17446 (mark_kboards): Move decl here ...
17447 * alloc.c (mark_kboards): ... from here.
a053e86c 17448
4752793e
PE
17449 * lisp.h (force_auto_save_soon): New decl.
17450
74f10ca7 17451 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
17452 (DEFINE_DUMMY_FUNCTION): New macro.
17453 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
17454 Use it.
c03cd23f
PE
17455 (main): Add casts to avoid warnings
17456 if GCC considers string literals to be constants.
74f10ca7 17457
022e70d4
PE
17458 * lisp.h (fatal_error_signal): Add decl, since it's exported.
17459
59d6fe83
PE
17460 * dbusbind.c: Pointer signedness fixes.
17461 (xd_signature, xd_append_arg, xd_initialize):
17462 (Fdbus_call_method, Fdbus_call_method_asynchronously):
17463 (Fdbus_method_return_internal, Fdbus_method_error_internal):
17464 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
17465 (Fdbus_register_signal): Use SSDATA when the context wants char *.
17466
78320123
PE
17467 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
17468 if GCC considers string literals to be constants.
49cebcca 17469 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 17470
35ac2a97
SM
174712011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
17472
fb103ca9
SM
17473 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
17474 (print_preprocess, print_object): New macro to fix last change.
17475
35ac2a97
SM
17476 * print.c (print_preprocess): Don't forget font objects.
17477
62973b41
JB
174782011-03-16 Juanma Barranquero <lekktu@gmail.com>
17479
17480 * emacs.c (USAGE3): Doc fixes.
17481
0e48bb22
AS
174822011-03-15 Andreas Schwab <schwab@linux-m68k.org>
17483
17484 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
17485 structure.
17486
7684e57b
JB
174872011-03-14 Juanma Barranquero <lekktu@gmail.com>
17488
17489 * lisp.h (VWindow_system, Qfile_name_history):
17490 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
17491 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
17492 (w32_system_caret_x, w32_system_caret_y): Declare extern.
17493
17494 * w32select.c: Don't #include "keyboard.h".
c96bbc66 17495 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
17496
17497 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
17498 * w32console.c (detect_input_pending, read_input_pending)
17499 (encode_terminal_code):
17500 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
17501 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
17502 (w32_system_caret_y, Qfile_name_history):
17503 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
17504 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
17505 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
17506 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
17507 * w32proc.c (Qlocal, report_file_error):
17508 * w32term.c (Vwindow_system, updating_frame):
17509 * w32uniscribe.c (initialized, uniscribe_font_driver):
17510 Remove unneeded extern declarations.
17511
2aa46d6c
CY
175122011-03-14 Chong Yidong <cyd@stupidchicken.com>
17513
c96bbc66 17514 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 17515
cffc6f3b
CY
175162011-03-13 Chong Yidong <cyd@stupidchicken.com>
17517
17518 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
17519 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
17520 These macros can no longer be used for assignment.
17521
44f230aa
SM
17522 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
17523 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
17524 (record_buffer_markers, fetch_buffer_markers): New functions for
17525 recording and fetching special buffer markers.
17526 (set_buffer_internal_1, set_buffer_temp): Use them.
17527
17528 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
17529
17530 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
17531
17532 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
17533 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
17534
17535 * xdisp.c (hscroll_window_tree):
17536 (reconsider_clip_changes): Use PT instead of BUF_PT.
17537
d251f04b
EZ
175382011-03-13 Eli Zaretskii <eliz@gnu.org>
17539
17540 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
17541 $(EMACS_ROOT)/lib/intprops.h.
17542
f0c77cd1
PE
175432011-03-13 Paul Eggert <eggert@cs.ucla.edu>
17544
3eca4629
PE
17545 Fix more problems found by GCC 4.5.2's static checks.
17546
7c86ee98
PE
17547 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
17548 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
17549 (xg_free_frame_widgets): Make it clear that a local variable is
17550 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
17551 (gdk_window_get_screen): Make it clear that this macro is needed
17552 only if USE_GTK_TOOLTIP.
1e5524e7
PE
17553 (int_gtk_range_get_value): New function, which avoids a diagnostic
17554 from gcc -Wbad-function-cast.
17555 (xg_set_toolkit_scroll_bar_thumb): Use it.
17556 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
17557 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
17558 (get_utf8_string, xg_get_file_with_chooser):
17559 Rename locals to avoid shadowing.
17560 (create_dialog): Move locals to avoid shadowing.
7c86ee98 17561
41729b81
PE
17562 * xgselect.c (xg_select): Remove unused var.
17563
f0c77cd1
PE
17564 * image.c (four_corners_best): Mark locals as initialized.
17565 (gif_load): Initialize transparent_p to zero (Bug#8238).
17566 Mark another local as initialized.
ec6cf4c6 17567 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 17568
ce0ad53d 17569 * image.c (clear_image_cache): Now static.
d5d5a617 17570 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 17571 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
17572 (x_edge_detection): Remove unnecessary cast that
17573 gcc -Wbad-function-cast diagnoses.
2037898d 17574 (gif_load): Fix pointer signedness.
6ae141d6
PE
17575 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
17576 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 17577
33383987 175782011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 17579
d32df629
PE
17580 Improve quality of tests for time stamp overflow.
17581 For example, without this patch (encode-time 0 0 0 1 1
17582 1152921504606846976) returns the obviously-bogus value (-948597
17583 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
17584 reports time overflow. See
17585 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
17586 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
17587 * editfns.c: Include limits.h and intprops.h.
17588 (TIME_T_MIN, TIME_T_MAX): New macros.
17589 (time_overflow): Move earlier, to before first use.
17590 (hi_time, lo_time): New functions, for an accurate test for
17591 out-of-range times.
17592 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
17593 (Fget_internal_run_time): Don't assume time_t fits in int.
17594 (make_time): Use list2 instead of Fcons twice.
17595 (Fdecode_time): More accurate test for out-of-range times.
17596 (check_tm_member): New function.
17597 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
17598 (lisp_time_argument): Don't rely on undefined left-shift and
17599 right-shift behavior when checking for time stamp overflow.
8be6f318 17600
fe31d94c
PE
17601 * editfns.c (time_overflow): New function, refactoring common code.
17602 (Fformat_time_string, Fdecode_time, Fencode_time):
17603 (Fcurrent_time_string): Use it.
17604
8be6f318
PE
17605 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
17606 * dired.c (make_time): Move to ...
17607 * editfns.c (make_time): ... here.
17608 * systime.h: Note the move.
17609
09d9db2c 176102011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 17611
126bc0dc
YM
17612 * fringe.c (update_window_fringes): Remove unused variables.
17613
c47cbdfd
YM
17614 * unexmacosx.c (copy_data_segment): Also copy __got section.
17615 (Bug#8223)
17616
7ac80be9
EZ
176172011-03-12 Eli Zaretskii <eliz@gnu.org>
17618
c96bbc66 17619 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
17620 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
17621 Constify `char *' arguments and their references according to
17622 prototypes in tparam.h.
17623
ecb0f94d 17624 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 17625
7ac80be9
EZ
17626 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
17627 Adapt all references accordingly.
17628
17629 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
17630
ef1fd07e
TT
176312011-03-11 Tom Tromey <tromey@redhat.com>
17632
17633 * buffer.c (syms_of_buffer): Remove obsolete comment.
17634
7ef4b50c
EZ
176352011-03-11 Eli Zaretskii <eliz@gnu.org>
17636
17637 * termhooks.h (encode_terminal_code): Declare prototype.
17638
17639 * msdos.c (encode_terminal_code): Don't declare prototype.
17640
17641 * term.c (encode_terminal_code): Now external again, used by
17642 w32console.c and msdos.c.
17643
44f230aa
SM
17644 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
17645 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 17646
4b1ec863 176472011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 17648
1714f52b 17649 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 17650
4b1ec863
PE
17651 * fringe.c (update_window_fringes): Mark locals as initialized
17652 (Bug#8227).
17653 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 17654
524c7aa6
PE
17655 * alloc.c (mark_fringe_data): Move decl from here ...
17656 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
17657 to check its interface.
17658 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
17659
a5c0af81 17660 * fontset.c (free_realized_fontset): Now static.
7519b8cd 17661 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 17662 (fontset_font): Mark local as initialized.
a9a06e0b 17663 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 17664
b4716021
PE
17665 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
17666
811e9bac 17667 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 17668 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
17669 (x_own_selection, Fx_disown_selection_internal): Rename locals
17670 to avoid shadowing.
17671 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 17672
7e3ab302
PE
17673 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
17674 so that the caller can use some name other than gcpro1.
17675 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
17676 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
17677 (Fx_backspace_delete_keys_p):
17678 Use them to avoid shadowing, and rename vars to avoid shadowing.
17679 (x_decode_color, x_set_name, x_window): Now static.
6b437900 17680 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 17681 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
17682 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
17683 Remove unused locals.
7e3ab302
PE
17684 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
17685 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
17686 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
17687 macros.
f78faa98 17688
e2b13473
PE
17689 * xterm.h (x_mouse_leave): New decl.
17690
77f23912
PE
17691 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
17692 Remove unused functions.
cdf4ba58
PE
17693 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
17694 (x_calc_absolute_position): Now static.
7411c686 17695 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 17696 Don't declare local "event" unless it's used.
ed7bf3a5
PE
17697 (x_iconify_frame, x_free_frame_resources): Don't declare locals
17698 unless they are used.
38d0b34a
PE
17699 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
17700 (x_fatal_error_signal): Remove; not used.
a6067996
PE
17701 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
17702 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
17703 (x_error_catcher, x_connection_closed, x_error_handler):
17704 (x_error_quitter, xembed_send_message, x_iconify_frame):
17705 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 17706 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 17707 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 17708
44f230aa
SM
17709 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
17710 Rename or move locals to avoid shadowing.
6b463e58 17711 (tty_defined_color, merge_face_heights): Now static.
5967d051 17712 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
17713 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
17714 does not deduce is never used uninitialized.
73719eba
PE
17715 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
17716 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 17717
426994c3 17718 * terminal.c (store_terminal_param): Now static.
5489860b 17719
032f1620 17720 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 17721 (set_frame_menubar): Remove unused local.
d4323972 17722 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
17723 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
17724 since they might point to immutable storage.
281585b0
PE
17725 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
17726 since it's unused otherwise.
032f1620 17727
367c19e5 17728 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 17729 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
17730 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
17731 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 17732 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
17733 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
17734 does not deduce are never used uninitialized.
70739cbe 17735
07b48fa9
PE
17736 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
17737
8868a238 17738 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
17739 * window.c (window_loop, size_window):
17740 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 17741
7e5cf297 17742 * window.c (display_buffer): Now static.
d6550a9f
PE
17743 (size_window): Mark variables that gcc -Wuninitialized
17744 does not deduce are never used uninitialized.
a586633d
PE
17745 * window.h (check_all_windows): New decl, to forestall
17746 gcc -Wmissing-prototypes diagnostic.
5b555da1 17747 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 17748
f6095868
PE
17749 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
17750 shadowing.
17751 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
17752 Include <limits.h>.
17753 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
17754 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
17755 (load_charset_map): Mark variables that gcc -Wuninitialized
17756 does not deduce are never used uninitialized.
53df7c11 17757 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 17758
f38b440c
PE
17759 * coding.c (coding_set_source, coding_set_destination):
17760 Use "else { /* comment */ }" rather than "else /* comment */;"
17761 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
17762 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
17763 a block, when the outer 'i' will do.
17764 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
17765 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
17766 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
17767 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
17768 (Fdecode_sjis_char, Fdefine_coding_system_internal):
17769 Rename locals to avoid shadowing.
17770 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
17771 * coding.c (emacs_mule_char, encode_invocation_designation):
17772 Now static, since they're not used elsewhere.
413bb2db 17773 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 17774 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
17775 (decode_coding_emacs_mule): Mark variables that gcc
17776 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
17777 (detect_coding_iso_2022): Initialize a local variable that might
17778 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 17779 this initialization is needed. (Bug#8211)
5f58e762
PE
17780 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
17781 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
17782 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
17783 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
17784 Remove unused macros.
f38b440c 17785
232b38b9 17786 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 17787 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 17788 * character.c (string_count_byte8): Likewise.
232b38b9 17789
fb90da1b
PE
17790 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
17791 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
17792
fb93dbc2
PE
17793 * chartab.c (copy_sub_char_table): Now static, since it's not used
17794 elsewhere.
5c156ace
PE
17795 (sub_char_table_ref_and_range, char_table_ref_and_range):
17796 Rename locals to avoid shadowing.
bbcd0949 17797 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 17798
7d3b3862 17799 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 17800 (BIDI_BOB): Remove unused macro.
7d3b3862 17801
6be7d3da
PE
17802 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
17803 deduce are never used uninitialized.
c2ed9c8b 17804 * term.c (encode_terminal_code): Likewise.
6be7d3da 17805
75f8807f 17806 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 17807
50938595
PE
17808 * tparam.h: New file.
17809 * term.c, tparam.h: Include it.
17810 * deps.mk (term.o, tparam.o): Depend on tparam.h.
17811 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
17812 Move these decls to tparam.h, and make them agree with what
17813 is actually in tparam.c. The previous trick of using incompatible
17814 decls in different modules does not conform to the C standard.
17815 All callers of tparam changed to use tparam's actual API.
17816 * tparam.c (tparam1, tparam, tgoto):
17817 Use const pointers where appropriate.
17818
fbceeba2
PE
17819 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
17820 * cm.h (struct cm): Likewise.
17821 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
17822 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
17823 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
17824 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
17825 (turn_on_face, init_tty): Likewise.
17826 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 17827
7f3f1250
PE
17828 * term.c (term_mouse_position): Rename local to avoid shadowing.
17829
e6ca6543
PE
17830 * alloc.c (mark_ttys): Move decl from here ...
17831 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
17832
c40f8d15
AS
178332011-03-11 Andreas Schwab <schwab@linux-m68k.org>
17834
17835 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
17836
cfe0661d
JB
178372011-03-09 Juanma Barranquero <lekktu@gmail.com>
17838
17839 * search.c (compile_pattern_1): Remove argument regp, unused since
17840 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
17841 (compile_pattern): Don't pass it.
17842
0afb4571
J
178432011-03-08 Jan Djärv <jan.h.d@swipnet.se>
17844
17845 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
17846 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
17847 for ! HAVE_GTK3.
17848 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
17849
17850 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
17851
17852 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
17853 gdk_window_get_screen, gdk_window_get_geometry,
17854 gdk_x11_window_lookup_for_display and GDK_KEY_g.
17855 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
17856 (xg_get_pixbuf_from_pixmap): New function.
17857 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
17858 to Pixmap, take frame as parameter, remove GdkColormap parameter.
17859 Call xg_get_pixbuf_from_pixmap instead of
17860 gdk_pixbuf_get_from_drawable.
17861 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
17862 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
17863 (xg_check_special_colors): Use GtkStyleContext and its functions
17864 for HAVE_GTK3.
17865 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
17866 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
17867 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
17868 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
17869 Call gtk_widget_get_preferred_size.
0afb4571
J
17870 (xg_frame_resized): gdk_window_get_geometry only takes 5
17871 parameters.
44f230aa
SM
17872 (xg_win_to_widget, xg_event_is_for_menubar):
17873 Call gdk_x11_window_lookup_for_display.
0afb4571
J
17874 (xg_set_widget_bg): New function.
17875 (delete_cb): New function.
895009e1 17876 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 17877 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
17878 (xg_set_background_color): Call xg_set_widget_bg.
17879 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
17880 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
17881 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
17882 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
17883 if ! HAVE_GTK3.
17884 (update_frame_tool_bar): Call gtk_widget_hide.
17885 (xg_initialize): Use GDK_KEY_g.
17886
17887 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
17888 if ! HAVE_GTK3
17889 (x_session_initialize): Call gdk_x11_set_sm_client_id.
17890
17891 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
17892 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
17893 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
17894
1c2cc4ef
JB
178952011-03-08 Juanma Barranquero <lekktu@gmail.com>
17896
17897 * w32xfns.c (select_palette): Check success of RealizePalette against
17898 GDI_ERROR, not zero.
17899
33383987 17900See ChangeLog.11 for earlier changes.
aac0c6e3
MR
17901
17902;; Local Variables:
17903;; coding: utf-8
aac0c6e3
MR
17904;; End:
17905
2f097256 17906 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
17907
17908 This file is part of GNU Emacs.
17909
17910 GNU Emacs is free software: you can redistribute it and/or modify
17911 it under the terms of the GNU General Public License as published by
17912 the Free Software Foundation, either version 3 of the License, or
17913 (at your option) any later version.
17914
17915 GNU Emacs is distributed in the hope that it will be useful,
17916 but WITHOUT ANY WARRANTY; without even the implied warranty of
17917 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17918 GNU General Public License for more details.
17919
17920 You should have received a copy of the GNU General Public License
17921 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.