Auto-commit of loaddefs files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
322ad6ec
EZ
12011-11-14 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (display_line): Move the call to
4 highlight_trailing_whitespace before the call to
5 compute_line_metrics, since the latter needs to see the final
6 faces of all the glyphs to compute ROW's hash value. Fixes
7 assertion violations in row_equal_p. (Bug#10035)
8
f067b8ec
JB
92011-11-14 Juanma Barranquero <lekktu@gmail.com>
10
11 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
12 just return (bug#10044).
13
1e5b2111
EZ
142011-11-12 Eli Zaretskii <eliz@gnu.org>
15
7ef3cbd5
EZ
16 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
17 with user-defined heap size. Bump the default size of the temacs
18 heap to 27MB, to avoid memory warning when running temacs.
19 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
20
1e5b2111
EZ
21 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
22 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
23 (verify_row_hash) [XASSERTS]: New function.
24 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
25 that the hash value of glyph rows is correct.
1e5b2111 26
89d61221
MR
272011-11-12 Martin Rudalics <rudalics@gmx.at>
28
29 * window.h (window): Remove splits slot.
30 * window.c (Fwindow_splits, Fset_window_splits): Remove.
31 (Fdelete_other_windows_internal, make_parent_window)
32 (make_window, Fsplit_window_internal, Fdelete_window_internal)
33 (Fset_window_configuration, save_window_save): Don't deal with
34 split status of windows.
35 (saved_window): Remove splits slot.
36 (Vwindow_splits): Rewrite doc-string.
37
97f18cc8
JD
382011-11-11 Jan Djärv <jan.h.d@swipnet.se>
39
40 * xfns.c (unwind_create_frame):
41 * nsfns.m (unwind_create_frame):
42 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
43 Vframe_list (Bug#9999).
44
22a648b4
DA
452011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
46
0b381c7e 47 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 48
659afede
KH
492011-11-11 Kenichi Handa <handa@m17n.org>
50
51 * callproc.c (Fcall_process): Set the member dst_multibyte of
52 process_coding.
53
9ac0394b
KH
542011-11-11 Johan Bockgård <bojohan@gnu.org>
55
56 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
57 avoid a crash (bug#9496).
58
2fbdc249
CY
592011-11-09 Chong Yidong <cyd@gnu.org>
60
61 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
62 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
63
ac6b1f81
PE
642011-11-08 Paul Eggert <eggert@cs.ucla.edu>
65
66 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
67
09db192c
PE
682011-11-08 Paul Eggert <eggert@cs.ucla.edu>
69
70 Avoid some portability problems by eschewing 'extern inline' functions.
71 The trivial performance wins aren't worth the portability hassles; see
72 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
73 et seq.
74 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
75 (window_box_width, window_box_left, window_box_left_offset)
76 (window_box_right, window_box_right_offset): Undo previous change,
77 by removing the "extern"s.
78 * intervals.c (adjust_intervals_for_insertion)
79 (adjust_intervals_for_deletion): Undo previous change,
80 making these static again.
81 (offset_intervals, temp_set_point_both, temp_set_point)
82 (copy_intervals_to_string): No longer inline.
83 * xdisp.c (window_text_bottom_y, window_box_width)
84 (window_box_height, window_box_left_offset)
85 (window_box_right_offset, window_box_left, window_box_right)
86 (window_box): No longer inline.
87
105216ed
CY
882011-11-08 Chong Yidong <cyd@gnu.org>
89
90 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
91 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
92 an error if not a live window.
93 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
94 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
95
ae9e237f
JB
962011-11-07 Juanma Barranquero <lekktu@gmail.com>
97
98 * lisp.h (syms_of_abbrev): Remove declaration.
99 Reported by CHENG Gao <chenggao@royau.me>.
100
c7aa8333
EZ
1012011-11-07 Eli Zaretskii <eliz@gnu.org>
102
103 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
104 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
105 of temacs in GUI mode.
106
be7f5545
MR
1072011-11-07 Martin Rudalics <rudalics@gmx.at>
108
109 * window.h: Declare delete_all_child_windows instead of
110 delete_all_subwindows.
111 * window.c (Fwindow_nest, Fset_window_nest)
112 (Fset_window_new_total, Fset_window_new_normal)
113 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
114 (delete_all_subwindows): Rename to delete_all_child_windows.
115 (Fdelete_other_windows_internal, Fset_window_configuration):
116 Call delete_all_child_windows instead of delete_all_subwindows.
117 * frame.c (delete_frame): Call delete_all_child_windows instead
118 of delete_all_subwindows.
119
ca78dc43
PE
1202011-11-07 Paul Eggert <eggert@cs.ucla.edu>
121
122 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
123 This is also needed for porting to any host where GC_MARK_STACK is
124 not GC_MAKE_GCPROS_NOOPS.
125 (which_symbols): Use it.
126
a0241d01
KH
1272011-11-07 Kenichi Handa <handa@m17n.org>
128
129 * coding.c (coding_set_destination): Check coding->src_pos only
130 when coding->src_object is a buffer (bug#9910).
131
132 * process.c (send_process): Set the member src_multibyte of coding
133 to 0 (bug#9911) when sending a unibyte text.
134
135 * callproc.c (Fcall_process): Set the member src_multibyte of
136 process_coding to 0 (bug#9912).
137
a64bfdfa 1382011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
139
140 * xmenu.c (cleanup_widget_value_tree): New function.
141 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
142 calling free_menubar_widget_value_tree directly (Bug#9830).
143
cb41b32a
PE
1442011-11-06 Paul Eggert <eggert@cs.ucla.edu>
145
146 Fix some portability problems with 'inline'.
147 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
148 (window_box_width, window_box_left, window_box_left_offset)
149 (window_box_right, window_box_right_offset): Declare extern.
150 Otherwise, these inline functions do not conform to C99 and
151 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
152 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
153 * intervals.c (adjust_intervals_for_insertion)
154 (adjust_intervals_for_deletion): Now extern, because otherwise the
155 extern inline functions 'offset_intervals' couldn't refer to it.
156 (static_offset_intervals): Remove.
157 (offset_intervals): Rewrite using the old contents of
158 static_offset_intervals. The old version didn't conform to C99
159 because an extern inline function contained a reference to an
160 identifier with static linkage.
161
b7041366
AS
1622011-11-06 Andreas Schwab <schwab@linux-m68k.org>
163
164 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
165 GC.
166
88a37c4d
EZ
1672011-11-06 Eli Zaretskii <eliz@gnu.org>
168
169 * xdisp.c (init_iterator, reseat_to_string): Don't set the
170 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
171 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
172 return Qleft_to_right.
173
49745b39
CY
1742011-11-06 Chong Yidong <cyd@gnu.org>
175
176 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
177 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
178 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
179 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
180 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
181 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
182 (Fwindow_vscroll): Doc fix.
183 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
184 argument, since it makes no sense to pass a live window and for
185 consistency with window-child.
186
1f05cd82
CS
1872011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
188
189 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
190 support MSVC.
191
22610910
JR
1922011-11-05 Jason Rumney <jasonr@gnu.org>
193
194 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
195 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
196 fonts (Bug#6029).
197 (add_font_entity_to_list): Fix logic errors in mixed boolean and
198 bitwise arithmetic preventing use of unicode-sip and non-truetype
199 opentype fonts.
200
a06776b2
EZ
2012011-11-05 Eli Zaretskii <eliz@gnu.org>
202
3ad924ba
EZ
203 * s/ms-w32.h (fstat, stat, utime): Move redirections to
204 "emacs"-only part.
205
a06776b2
EZ
206 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
207 initialization code to keep similarity to xfns.c after changes
208 from 2011-11-05.
209
c9e7db78
JD
2102011-11-05 Jan Djärv <jan.h.d@swipnet.se>
211
a97f8f3f
JD
212 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
213 (unwind_create_frame): New function (Bug#9943).
214 (Fx_create_frame): Restructure code to be more similar to the one in
215 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
216 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
217 Move terminal->reference_count++ just before making the frame official
218 (Bug#9943).
219
220 * nsterm.m (x_free_frame_resources): New function.
221 (x_destroy_window): Move code to x_free_frame_resources.
222
c9e7db78
JD
223 * xfns.c (unwind_create_frame): Fix comment.
224 (Fx_create_frame, x_create_tip_frame): Move
225 terminal->reference_count++ just before making the frame
226 official. Move initialization of image_cache_refcount and
227 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
228
a6fc3b5c
EZ
2292011-11-05 Eli Zaretskii <eliz@gnu.org>
230
231 Support MSVC build with newer versions of Visual Studio.
232 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
233 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
234 nt/gmake.defs.
235
236 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
237 which are not supported by MSVC.
238 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
239 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
240 bitfields.
241 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
242 types in bitfields.
243 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
244
245 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
246
2472011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
248
249 Support MSVC build with newer versions of Visual Studio.
250 * w32.c: Don't include w32api.h for MSVC.
251 (init_environment) [_MSC_VER]: Call sys_access, not _access.
252
253 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
254 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
255 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
256 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
257 e_* cousins.
258 (alloca) [_MSC_VER]: Define to _alloca.
259
260 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
261
262 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
263
a58c13ed
EZ
2642011-11-04 Eli Zaretskii <eliz@gnu.org>
265
266 * xdisp.c (note_mouse_highlight): If either of
267 previous/next-single-property-change returns nil, treat that as
268 the beginning or the end of the buffer. (Bug#9955)
269
fe0b6370
JD
2702011-11-04 Jan Djärv <jan.h.d@swipnet.se>
271
a58c13ed 272 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
273 label is not null (Bug#9951).
274 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
275 may be NULL.
276
89bd5ee1
EZ
2772011-11-04 Eli Zaretskii <eliz@gnu.org>
278
279 * window.c (Fwindow_body_size): Mention in the doc string that the
280 return value is in frame's canonical units. (Bug#9949)
281
84c3edb9
EZ
2822011-11-03 Eli Zaretskii <eliz@gnu.org>
283
4e2fb5c7
EZ
284 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
285
84c3edb9 286 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 287 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 288 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 289
bc17a887
EZ
2902011-11-01 Eli Zaretskii <eliz@gnu.org>
291
292 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
293 Don't stop backward scan on the continuation glyph, even though
294 its CHARPOS is positive.
26b46e51
EZ
295 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
296 cover_string to disp_string.
bc17a887 297
4ee88440
MR
2982011-11-01 Martin Rudalics <rudalics@gmx.at>
299
300 * window.c (temp_output_buffer_show): Don't use
301 Vtemp_buffer_show_specifiers.
302 (Vtemp_buffer_show_specifiers): Remove unused variable.
303
c2ff3c02
EZ
3042011-10-30 Eli Zaretskii <eliz@gnu.org>
305
306 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
307 past the beginning of the current glyph matrix.
308
6e56383b
JD
3092011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
310
311 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
312 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
313 HAVE_GTK3 (Bug#9869).
b77a6a7f 314
3b574623
JD
315 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
316 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
317
b77a6a7f
JD
318 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
319
320 * xterm.c: Declare x_handle_net_wm_state to return int.
321 (handle_one_xevent): Check if we are iconified but don't have
322 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
323 (get_current_wm_state): Return non-zero if not hidden,
324 check for _NET_WM_STATE_HIDDEN (Bug#9893).
325 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
326 (x_handle_net_wm_state): Return what get_current_wm_state returns.
327 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
328
196e41e4
PE
3292011-10-29 Paul Eggert <eggert@cs.ucla.edu>
330
331 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
332 so that this new function doesn't get optimized away by a
333 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
334
021f2e1a
AS
3352011-10-29 Andreas Schwab <schwab@linux-m68k.org>
336
337 * frame.h (MOUSE_HL_INFO): Remove excess parens.
338
8b058d44
EZ
3392011-10-29 Eli Zaretskii <eliz@gnu.org>
340
341 Fix the `xbytecode' command.
342 * .gdbinit (xprintbytestr): New command.
343 (xwhichsymbols): Renamed from `which'; all callers changed.
344 (xbytecode): Print the byte-code string as well.
345
4452fb80
EZ
3462011-10-29 Kim Storm <storm@cua.dk>
347
8b058d44
EZ
348 * alloc.c (which_symbols): New function.
349
21b72067
AS
3502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
351
352 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
353 line. (Bug#9903)
354
83ed7b5c
GM
3552011-10-29 Glenn Morris <rgm@gnu.org>
356
357 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
358 Not clear what it was for, and it causes various bugs. (Bug#9839)
359
5a7a728b
EZ
3602011-10-28 Eli Zaretskii <eliz@gnu.org>
361
362 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
363 possible random value that matches one of those tested as
364 condition to clear the mouse face.
365
d3d0842f
CY
3662011-10-28 Chong Yidong <cyd@gnu.org>
367
368 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
369
31b39d13
DN
3702011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
371
372 * window.c (make_window): Initialize phys_cursor_on_p.
373
9aba6043
SM
3742011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
375
376 * lisp.h (struct Lisp_Symbol): Update comments.
377
c20992f4
JB
3782011-10-28 Juanma Barranquero <lekktu@gmail.com>
379
380 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
381
db4f02f2
EZ
3822011-10-28 Eli Zaretskii <eliz@gnu.org>
383
384 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
385 <oslsachem@gmail.com> for helping to debug this.
386
387 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
388 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
389 (g_b_init_get_glyph_outline_w): New static variables.
390 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
391 (GetGlyphOutlineW_Proc): New typedefs.
392 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
393 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
394 New functions.
395 (w32font_open_internal, compute_metrics):
396 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
397 instead of calling the "wide" APIs directly.
398
399 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
400
401 * w32.h (syms_of_w32font): Add prototype.
402
87e68db4
JB
4032011-10-27 Juanma Barranquero <lekktu@gmail.com>
404
405 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
406 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
407 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
408 (Fmove_to_window_line): Doc fix.
409
435c1d67
CY
4102011-10-27 Chong Yidong <cyd@gnu.org>
411
412 * process.c (make_process): Set gnutls_state to NULL.
413
414 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
415 non-NULL, regardless of GNUTLS_INITSTAGE.
416 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
417 an error. Set process slots as soon as we allocate them.
418
419 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
420
9c6c6f49
CY
4212011-10-27 Chong Yidong <cyd@gnu.org>
422
9aba6043
SM
423 * gnutls.c (emacs_gnutls_deinit): New function.
424 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
425 (Fgnutls_deinit, Fgnutls_boot): Use it.
426
427 * process.c (make_process): Initialize GnuTLS credentials to NULL.
428 (deactivate_process): Call emacs_gnutls_deinit.
429
657d08d3
JB
4302011-10-27 Juanma Barranquero <lekktu@gmail.com>
431
432 * image.c (x_create_x_image_and_pixmap):
433 * w32.c (sys_rename, w32_delayed_load):
434 * w32font.c (fill_in_logfont):
435 * w32reg.c (x_get_string_resource): Silence compiler warnings.
436
5430d399
JB
4372011-10-26 Juanma Barranquero <lekktu@gmail.com>
438
439 * w32fns.c (w32_default_color_map): New function,
440 extracted from Fw32_default_color_map.
a7ef684b 441 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 442
fe0055fa
PE
4432011-10-25 Paul Eggert <eggert@cs.ucla.edu>
444
445 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
446
e6346438
SM
4472011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
448
449 * keyboard.c (test_undefined): New function (bug#9751).
450 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
451
e112cc37
ET
4522011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
453
454 * sysdep.c (init_sys_modes): Fix the check for the controlling
455 terminal (Bug#6649).
456
7b5d6677
EZ
4572011-10-20 Eli Zaretskii <eliz@gnu.org>
458
459 * dispextern.h (struct bidi_it): New member next_en_type.
460
461 * bidi.c (bidi_line_init): Initialize the next_en_type member.
462 (bidi_resolve_explicit_1): When next_en_pos is valid for the
463 current character, check also for next_en_type being WEAK_EN.
464 (bidi_resolve_weak): Don't enter the expensive loop if the current
465 position is before next_en_pos. Record the bidi type of the first
466 non-ET, non-BN character we find, in addition to its position.
467 (bidi_level_of_next_char): Invalidate next_en_type when
468 next_en_pos is over-stepped.
469
7da0b018
PE
4702011-10-20 Paul Eggert <eggert@cs.ucla.edu>
471
472 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
473 * editfns.c: Rewrite current-time-zone so that it invokes
474 the equivalent of (format-time-string "%Z") to get the time zone name.
475 This fixes a bug when the time zone name contains characters that
476 need converting from the system time locale to Emacs internal format.
477 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
478 that patch fixed format-time-string to do the conversion, but
479 I forgot to fix current-time-zone.
480 (format_time_string): New function, containing most of
481 what Fformat_time_string used to contain.
482 (Fformat_time_string): Rewrite in terms of format_time_string.
483 This doesn't change this function's behavior.
484 (current-time-zone): Rewrite to use format_time_string.
485 This fixes the bug reported by Michael Schierl in
486 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
487 Jason Rumney's 2007-06-07 change worked around this bug, but
488 didn't fix it.
489 * systime.h (tzname, timezone): Remove no-longer-used declarations.
490
8547b010
EZ
4912011-10-19 Eli Zaretskii <eliz@gnu.org>
492
493 * xdisp.c (start_display): If the character at POS is displayed
494 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
495 (try_window_reusing_current_matrix): If a line ends in a display
496 vector or the next line starts in a display vector, continue
497 redrawing the window even though the character position of
498 start_row was reached.
8547b010
EZ
499 (Bug#9771, part 2)
500
4e948d15
CY
5012011-10-18 Chong Yidong <cyd@gnu.org>
502
503 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
504 with nobreak-char-display too.
505
4787455f
EZ
5062011-10-18 Eli Zaretskii <eliz@gnu.org>
507
508 Fix part 3 of bug#9771.
509 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
510 (bidi_resolve_neutral): Don't enter the expensive loop looking for
511 non-neutral characters if the current character is a paragraph
512 separator (a.k.a. Newline). This avoids running the same
513 expensive loop twice, once when we consume the preceding newline
514 and the other time when the line actually needs to be displayed.
515 Avoid the loop when we see neutrals on the base embedding level
516 following a character whose directionality is the same as the
517 paragraph's. This avoids running the expensive loop when a line
518 ends in a long sequence of neutrals, like control characters.
519 Add assertion against STRONG_AL type. Slightly rearrange code
520 that determines the type of a neutral given the first non-neutral
521 that follows it.
522 (bidi_level_of_next_char): Set next_en_pos to zero when
523 invalidating its info.
524
2c91f553
EZ
5252011-10-17 Eli Zaretskii <eliz@gnu.org>
526
527 * xdisp.c (push_display_prop): Determine whether to record string
528 or buffer position by IT->string, not by IT->method. Allow
529 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
530 (move_it_vertically_backward): Don't look for character position
531 immediately after the newline when in a continuation line.
532 (Bug#9771, part 1)
2c91f553 533
c7b08b0d
MR
5342011-10-15 Martin Rudalics <rudalics@gmx.at>
535
536 * window.c (coordinates_in_window): Rewrite and delabelize
537 vertical border check. (Bug#5357) (Bug#9618)
538
6b02f655
SM
5392011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
540
541 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
542 errors in XSetWindowBorder (bug#9310).
543
81d40c92
DA
5442011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
545
546 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
547 avoid crash when xmalloc overrun checking is enabled.
548
d4172c3b
EZ
5492011-10-13 Eli Zaretskii <eliz@gnu.org>
550
551 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
552 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
553 cursor motion with <left> and <right> arrow keys.
554
555 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
556 some callers set that themselves.
557
b00eea75
EZ
5582011-10-12 Eli Zaretskii <eliz@gnu.org>
559
560 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
561 display string and the previous row comes from the same string and
562 is empty. (Bug#9739) (Bug#9738)
563
8fe012c4
SM
5642011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
565
566 * doc.c (get_doc_string): Encode file name (bug#9735).
567
0074aef2
EZ
5682011-10-12 Eli Zaretskii <eliz@gnu.org>
569
79beb178
EZ
570 * bidi.c (bidi_level_of_next_char):
571 * xdisp.c (get_visually_first_element): Remove old incorrect
572 comments regarding the Unicode Line Separator character.
573
0074aef2
EZ
574 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
575
6e4b3fbe
DA
5762011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
577
578 * alloc.c (Fgc_status): Do not access beyond zombies array
579 boundary if nzombies > MAX_ZOMBIES.
580 * alloc.c (dump_zombies): Add missing format specifier.
581
0324f3af
PE
5822011-10-12 Paul Eggert <eggert@cs.ucla.edu>
583
b5525cac
PE
584 * xdisp.c (set_cursor_from_row): Simplify conditionals,
585 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
586
0324f3af
PE
587 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
588 Some packages use them to denote characters with modifiers.
589
e9b5f888
AS
5902011-10-11 Andreas Schwab <schwab@linux-m68k.org>
591
592 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
593 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
594 matching a pp-number. Rename parameter var to var1.
595
127827c0
SM
5962011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
597
598 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
599
c8fd3bd0
GM
6002011-10-08 Glenn Morris <rgm@gnu.org>
601
602 * callint.c (Fcall_interactively): Give a more explicit error for the
603 'c' case with a non-character input. (Bug#8479)
604
352ec8ff
EZ
6052011-10-08 Eli Zaretskii <eliz@gnu.org>
606
03669ccb
EZ
607 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
608 lines.
7061c986
EZ
609 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
610 lines that are hscrolled on the left.
03669ccb 611
352ec8ff
EZ
612 * dispnew.c (buffer_posn_from_coords): Account for a possible
613 presence of header-line. (Bug#4426)
614
a66cfb1c
SM
6152011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
616
6b02f655
SM
617 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
618 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 619
7c5ee88e
PE
6202011-10-07 Paul Eggert <eggert@cs.ucla.edu>
621
622 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
623 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
624 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
625 this makes Emacs dump core during garbage collection on rare
626 occasions. sizeof is obviously inferior to offsetof here, so
627 stick with offsetof.
628 (GC_POINTER_ALIGNMENT): New macro.
629 (mark_memory): Omit 3rd (offset) arg; caller changed.
630 Don't assume EMACS_INT alignment is the same as pointer alignment.
631
df1bbe5b
SM
6322011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
633
634 * keyboard.c (read_key_sequence_remapped): New var.
635 (read_key_sequence): Compute remapping in the right buffer.
636 (command_loop_1): Use read_key_sequence's remapping directly.
637
51553db6
SM
6382011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
639
32c1fffd
SM
640 * dired.c (file_name_completion): Don't expand file name.
641 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
642 before checking file name handler.
643
51553db6
SM
644 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
645 they've been requested explicitly (bug#9591).
646
b6bd1599 6472011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
648
649 * keymap.c (Fsingle_key_description): Use make_specified_string
650 instead of build_string to build string from push_key_description.
651 (Bug#5193)
652
f701dc2a
PE
6532011-09-30 Paul Eggert <eggert@cs.ucla.edu>
654
4222c55d
PE
655 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
656 This fixes a Y2038 bug on 64-bit hosts.
657 * buffer.c (reset_buffer):
658 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
659 (Fclear_buffer_auto_save_failure):
660 Use 0, not -1, to represent an unset failure time, since time_t
661 might not be signed.
662
f701dc2a
PE
663 Remove dependency on glibc malloc internals.
664 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
665 Move back here from lisp.h, but with their new implementations.
666 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
667 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
668 * charset.c (charset_table_init): New static var.
669 (syms_of_charset): Use it instead of xmalloc. This removes a
670 dependency on glibc malloc internals. See Eli Zaretskii's comment in
671 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
672 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
673 Move back to alloc.c.
674 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
675 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
676
9ceebf39
JD
6772011-09-30 Jan Djärv <jan.h.d@swipnet.se>
678
679 * nsterm.m (windowDidResize): Call x_set_window_size only when
680 ns_in_resize is true. Otherwise set pixelwidth/height and
681 call change_frame_size (Bug#9628).
682
cb993c58
PE
6832011-09-30 Paul Eggert <eggert@cs.ucla.edu>
684
3930c88b
PE
685 Port --enable-checking=all to Fedora 14 x86-64.
686 * charset.c (syms_of_charset): Also account for glibc malloc's
687 internal overhead when calculating the initial malloc maximum.
688
cb993c58
PE
689 Port --enable-checking=all to Fedora 14 x86.
690 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
691 Move to lisp.h.
692 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
693 (overrun_check_realloc, overrun_check_free):
694 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
695 That way, xmalloc returns a properly-aligned pointer even if
696 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
697 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
698 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
699 into account when calculating the initial malloc maximum.
700 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
701 Move here from alloc.c, so that charset.c can use it too.
702 Properly align; the old code wasn't right for common 32-bit hosts
703 when configured with --enable-checking=all.
704 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
705 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
706
31bed486
EZ
7072011-09-29 Eli Zaretskii <eliz@gnu.org>
708
04c70788 709 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
710 use EDOM.
711
fbcaa2f3
EZ
7122011-09-28 Eli Zaretskii <eliz@gnu.org>
713
714 * xdisp.c (compute_display_string_end): If there's no display
715 string at CHARPOS, return -1.
716
717 * bidi.c (bidi_fetch_char): When compute_display_string_end
718 returns a negative value, treat the character as a normal
719 character not covered by a display string. (Bug#9624)
720
a239d4e9
JB
7212011-09-28 Juanma Barranquero <lekktu@gmail.com>
722
723 * lread.c (Fread_from_string): Fix typo in docstring.
724
88652fd5
EZ
7252011-09-27 Eli Zaretskii <eliz@gnu.org>
726
727 * xdisp.c (handle_invisible_prop): If invisible text ends on a
728 newline, reseat the iterator instead of bidi-iterating there one
729 character at a time. (Bug#9610)
32c1fffd
SM
730 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
731 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 732
ed497dd4
AS
7332011-09-27 Andreas Schwab <schwab@linux-m68k.org>
734
735 * lread.c (readevalloop): Use correct code for NBSP.
736 (read1): Likewise. (Bug#9608)
737
b2bf61aa
MA
7382011-09-25 Michael Albinus <michael.albinus@gmx.de>
739
740 * dbusbind.c (Fdbus_register_signal): When service is not
741 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
742
32bbb17c
GM
7432011-09-25 Glenn Morris <rgm@gnu.org>
744
745 * buffer.c (truncate-lines): Doc fix.
746
94e0933e
CY
7472011-09-24 Chong Yidong <cyd@stupidchicken.com>
748
749 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
750 (Fset_window_next_buffers): Doc fix.
751
cddde921
GM
7522011-09-24 Glenn Morris <rgm@gnu.org>
753
754 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
755
1260aef1
PE
7562011-09-24 Paul Eggert <eggert@cs.ucla.edu>
757
25b4bfa0
PE
758 Fix minor problems found by static checking.
759 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
760 * indent.c (Fvertical_motion): Fix == vs = typo.
761
e3cbd34b
EZ
7622011-09-24 Eli Zaretskii <eliz@gnu.org>
763
a66cfb1c
SM
764 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
765 Default value is now t. Doc fix.
6bf7006f 766
e3cbd34b 767 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 768 logic when moving up, not only when moving down. Fix the
e3cbd34b 769 confusing name and values of the it_overshoot_expected variable;
32c1fffd 770 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
771
772 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
773 CHARPOS is covered by a display string which includes newlines.
774 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
775 is covered by a display string with embedded newlines.
776
a3de0cbd
MA
7772011-09-24 Michael Albinus <michael.albinus@gmx.de>
778
779 * dbusbind.c (Fdbus_register_signal): Add match rule to
780 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
781 (Fdbus_register_method, Vdbus_registered_objects_table):
782 Fix docstring.
a3de0cbd 783
b260039d
JM
7842011-09-24 Jim Meyering <meyering@redhat.com>
785
32c1fffd 786 do not ignore write error for any output size
b260039d
JM
787 The previous change was incomplete.
788 While it makes emacs --batch detect the vast majority of stdout
789 write failures, errors were still ignored whenever the output size is
790 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
791 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
792 && echo FAIL: ignored write error
793 FAIL: ignored write error
794 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
795 && echo FAIL: ignored write error
796 FAIL: ignored write error
797 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
798
8eca8a7c
AS
7992011-09-23 Andreas Schwab <schwab@linux-m68k.org>
800
801 * emacs.c (Fkill_emacs): In noninteractive mode exit
802 non-successfully if a write error occurred on stdout. (Bug#9574)
803
3341db62
EZ
8042011-09-21 Eli Zaretskii <eliz@gnu.org>
805
806 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
807 the xassert test.
808
809 * dispextern.h (struct it): Update the comment documenting what
810 can it->OBJECT be.
811
8c203dbf
EZ
8122011-09-20 Eli Zaretskii <eliz@gnu.org>
813
814 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
815 a display string, extend search for cursor position to end of row.
816 (find_row_edges): If the row ends in a newline from a display
817 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
818 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
819 (Fcurrent_bidi_paragraph_direction): Fix search for previous
820 non-empty line. Fixes confusing cursor motion with arrow keys at
821 the beginning of a line that starts with whitespace.
8c203dbf 822
a4824228
LMI
8232011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
824
825 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
826 (bug#9493).
827
33ed493b
CY
8282011-09-18 Chong Yidong <cyd@stupidchicken.com>
829
830 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
831 boolean (Bug#9154).
832
56cd55c8
EZ
8332011-09-18 Eli Zaretskii <eliz@gnu.org>
834
835 * xdisp.c (display_line): Record maximum and minimum buffer
836 positions even if no glyphs were produced (e.g., by a zero-width
837 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
838 buffer positions that will be removed from the glyph row because
839 they don't fit.
c02dcedf
EZ
840 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
841 column is beyond frame width: don't subtract 1 "pixel" when
842 computing width of the stretch.
3e62b7e0
EZ
843 (reseat_at_next_visible_line_start): Undo the change made on
844 2011-09-17 that saved paragraph information and restored it after
845 the call to `reseat'. (Bug#9545)
56cd55c8 846
5ed99d36 8472011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
848
849 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
850 and turn window cursor on if cleared (Bug#9415).
851
5ed99d36 8522011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
853
854 * search.c (boyer_moore): Take unibyte characters from pattern
855 literally. (Bug#9458)
856
9bade7b2
EZ
8572011-09-18 Eli Zaretskii <eliz@gnu.org>
858
859 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
860
e5e9d610
PE
8612011-09-18 Paul Eggert <eggert@cs.ucla.edu>
862
87e4427a
PE
863 Fix minor problem found by static checking.
864 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
865 initialized, to pacify gcc -Wuninitialized.
866
e5e9d610
PE
867 * fileio.c: Report proper errno when syscall falls.
868 (Finsert_file_contents): Save and restore errno,
869 so that report_file_error outputs the correct diagnostic.
870 (Fwrite_region) [CLASH_DETECTION]: Likewise.
871
a1674f0b
EZ
8722011-09-18 Eli Zaretskii <eliz@gnu.org>
873
874 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
875
fbfb6dd4
EZ
8762011-09-17 Eli Zaretskii <eliz@gnu.org>
877
878 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
879 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
880
bb187662
EZ
8812011-09-17 Eli Zaretskii <eliz@gnu.org>
882
1137e8b8 883 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 884 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
885
886 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
887 (bidi_find_paragraph_start): Search back for paragraph beginning
888 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
889 (bidi_move_to_visually_next): Only trigger paragraph-related
890 computations when the last character is a newline or at EOB, not
891 just any NEUTRAL_B. (Bug#9470)
892
bb187662
EZ
893 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
894 truncated lines if point is covered by a display string. (Bug#9524)
895
2e621251
PE
8962011-09-16 Paul Eggert <eggert@cs.ucla.edu>
897
898 * xselect.c: Relax test for outgoing X longs (Bug#9498).
899 (cons_to_x_long): New function.
900 (lisp_data_to_selection_data): Use it. Correct the test for
901 short-versus-long data; it was negated. Break out of vector
902 loop, for efficiency, when a long datum is discovered.
903
91a15bc6
SM
9042011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
905
906 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
907
b41c3a35
EZ
9082011-09-16 Eli Zaretskii <eliz@gnu.org>
909
910 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
911 GCC PR/17406) by declaring this function with external scope.
912
7812ba2d
PE
9132011-09-15 Paul Eggert <eggert@cs.ucla.edu>
914
915 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
916 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
917
cf7edc2a
AS
9182011-09-15 Andreas Schwab <schwab@linux-m68k.org>
919
920 * editfns.c (Fformat): Correctly handle text properties on "%%".
921
bd01620e
EZ
9222011-09-15 Eli Zaretskii <eliz@gnu.org>
923
924 * xterm.c (x_draw_composite_glyph_string_foreground):
925 * w32term.c (x_draw_composite_glyph_string_foreground):
926 * term.c (encode_terminal_code):
927 * composite.c (composition_update_it, get_composition_id):
928 * xdisp.c (get_next_display_element)
929 (fill_composite_glyph_string): Add comments about special meaning
930 of TAB characters in a composition.
931
a02719a3
PE
9322011-09-15 Paul Eggert <eggert@cs.ucla.edu>
933
934 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
935 This occurs when processing a multibyte format.
936 Problem reported by Wolfgang Jenker.
a02719a3 937
72589a3c
JB
9382011-09-15 Johan Bockgård <bojohan@gnu.org>
939
940 * xdisp.c (try_cursor_movement): Only check for exact match if
941 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
942
1c14176c
PE
9432011-09-14 Paul Eggert <eggert@cs.ucla.edu>
944
945 Remove unused external symbols.
946 * dispextern.h (calc_pixel_width_or_height): Remove decl.
947 * xdisp.c (calc_pixel_width_or_height): Now static.
948 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
949 * indent.c (check_display_width):
950 * w32term.c: Fix comment to match code.
951 * xterm.c, xterm.h (x_catching_errors): Remove.
952
d2eea5b5
PE
9532011-09-14 Paul Eggert <eggert@cs.ucla.edu>
954
955 * xselect.c: Use signed conversions more consistently (Bug#9498).
956 (selection_data_to_lisp_data): Assume incoming selection data are
957 signed integers, not unsigned. This is to be consistent with
958 outgoing selection data, which was modified to use signed integers
959 in as part of the fix to Bug#9196 in response to Jan D.'s comment
960 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
961 expects long, not unsigned long.
962
46888499
EZ
9632011-09-14 Eli Zaretskii <eliz@gnu.org>
964
965 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
966 computation of loop end. Reported by Johan Bockgård
967 <bojohan@gnu.org>.
968
ef8ef9fb
CY
9692011-09-13 Chong Yidong <cyd@stupidchicken.com>
970
971 * frame.c (Fother_visible_frames_p): Function deleted.
972
fa819fed
EZ
9732011-09-12 Eli Zaretskii <eliz@gnu.org>
974
975 * indent.c (compute_motion): Process display vector front to back
976 rather than the other way around. (Bug#2496)
977
2ba8e008
SM
9782011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
979
980 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
981
20f53c69
CY
9822011-09-11 Chong Yidong <cyd@stupidchicken.com>
983
984 * minibuf.c (Fread_from_minibuffer): Doc fix.
985
d562d7a4
EZ
9862011-09-11 Eli Zaretskii <eliz@gnu.org>
987
988 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
989 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
990
1c4d7f3d
LMI
9912011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
992
993 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
994 value for non-existent files.
995
b885bf36
EZ
9962011-09-11 Eli Zaretskii <eliz@gnu.org>
997
998 * fileio.c (Finsert_file_contents): If the file cannot be opened,
999 set its "size" to -1. This will set the modtime_size field of
1000 the corresponding buffer to -1, which is what
1001 verify-visited-file-modtime expects for files that do not exist.
1002 (Bug#9139)
1003
6612f0bf
PE
10042011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1005
1006 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1007 here ...
1008 * lisp.h: ... from here. push_key_description is no longer
1009 defined in keyboard.c, so its declaration should not be in
1010 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1011 logically belongs with push_key_description.
1012
dfb3f755
PE
10132011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1014
1015 * buffer.h: Include <sys/types.h> instead of <time.h>.
1016 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1017 Problem reported by Herbert J. Skuhra.
1018
3134906c
LMI
10192011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1020
1021 * xml.c (parse_region): Make the parsing work for
1022 non-comment-starting XML files again (bug#9144).
1023
8d903f4e
AS
10242011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1025
1026 * image.c (gif_load): Fix calculation of bottom and right corner.
1027 (Bug#9468)
1028
80ad64f4
EZ
10292011-09-10 Eli Zaretskii <eliz@gnu.org>
1030
1031 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1032 redisplay in small windows.
1033
208a048d
EZ
10342011-09-09 Eli Zaretskii <eliz@gnu.org>
1035
1036 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1037
9b1c252e
MR
10382011-09-08 Martin Rudalics <rudalics@gmx.at>
1039
1040 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1041 Operate on live windows only.
1042
2949f33b
JB
10432011-09-08 Juanma Barranquero <lekktu@gmail.com>
1044
1045 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1046
e08dcafd
EZ
10472011-09-07 Eli Zaretskii <eliz@gnu.org>
1048
1049 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1050 only under bidi iteration.
1051
115b96bd
JD
10522011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1053
1054 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1055
c8199d0f
PE
10562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1057
1058 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1059 Without this fix, the command to link temacs failed due to an
1060 undefined symbol __builtin_isnan. This is because
1061 /usr/include/iso/math_c99.h #defines isnan(x) to
1062 __builtin_isnan(x), but the bundled gcc, which identifies itself
1063 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1064 a __builtin_isnan.
1065 * floatfns.c (isnan): #undef, and then #define to a clone of
1066 what's in data.c.
1067 (Fisnan): Always define, since it's always available now.
1068 (syms_of_floatfns): Always define isnan at the Lisp level.
1069
e39b275c 10702011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1071
1072 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1073
b2db44d9 10742011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1075
f4af5137 1076 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1077 The previous code assumed that file offsets (off_t values) fit in
1078 EMACS_INT variables, which is not true on typical 32-bit hosts.
1079 The code messed up by falsely reporting buffer overflow in cases
1080 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1081 when "big" contains more than 2**29 bytes, even though this
1082 inserts just one byte and does not overflow the buffer.
1083 (Finsert_file_contents): Store file offsets as off_t
1084 values, not as EMACS_INT values. Check for overflow when
1085 converting between EMACS_INT and off_t. When checking for
1086 buffer overflow or for overlap, take the offsets into account.
1087 Don't use EMACS_INT for small values where int suffices.
1088 When checking for overlap, fix a typo: ZV was used where
1089 ZV_BYTE was intended.
1090 (Fwrite_region): Don't assume off_t fits into 'long'.
1091 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1092
ecfc0a49
MA
10932011-09-05 Michael Albinus <michael.albinus@gmx.de>
1094
1095 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1096
6511acf2 10972011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1098
0999621a 1099 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1100
1101 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1102 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1103 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1104 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1105 (modify_event_symbol): Do not assume that the length of
1106 name_alist_or_stem is safe to alloca and fits in int.
1107 (Fexecute_extended_command): Likewise for function name and binding.
1108 (Frecursion_depth): Wrap around reliably on integer overflow.
1109 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1110 since some callers pass EMACS_INT values.
1111 (Fsingle_key_description): Don't crash if symbol name contains more
1112 than MAX_ALLOCA bytes.
1113 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1114 (get_minibuffer): Arg is now EMACS_INT, not int.
1115 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1116 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1117 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1118
2be7d702
PE
1119 * dbusbind.c (signature_cat): New function.
1120 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1121 Do not overrun buffer; instead, report string overflow.
1122
9d1df220
PE
1123 * dispnew.c (add_window_display_history): Don't overrun buffer.
1124 Truncate instead; this is OK since it's just a log.
1125
33ef5c64
PE
1126 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1127 even if the time zone offset is outlandishly large.
1128 Don't mishandle offset == INT_MIN.
1129
66c6fdd5
PE
1130 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1131 when creating daemon; the previous buffer-overflow check was incorrect.
1132
d749b01b
PE
1133 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1134 which has the guts of the old verror function.
1135
b5cd1905
PE
1136 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1137 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1138
6e1a67fb
PE
1139 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1140 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1141 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1142 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1143 length of string rather than counting it via multiple sprintfs;
1144 that's simpler and more reliable.
c21721cc
PE
1145 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1146 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1147 sprintf, in case result does not fit in int.
1148
c57b67fc
PE
1149 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1150 (fontset_from_font): Print it.
1151
8a401434
PE
1152 * frame.c (tty_frame_count): Now printmax_t, not int.
1153 (make_terminal_frame, set_term_frame_name): Print it.
1154 (x_report_frame_params): In X, window IDs are unsigned long,
1155 not signed long, so print them as unsigned.
1156 (validate_x_resource_name): Check for implausibly long names,
1157 and don't assume name length fits in 'int'.
1158 (x_get_resource_string): Don't blindly alloca invocation name;
1159 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1160 not fit in int.
1161
6e1a67fb
PE
1162 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1163 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1164 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1165
0df02bf3
PE
1166 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1167 Use esprintf, not sprintf, in case result does not fit in int.
1168
48e30793
PE
1169 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1170 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1171 it as a large positive number.
1172 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1173 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1174
a66ff6d8
PE
1175 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1176 in case result does not fit in int.
1177
aca216ff
PE
1178 * print.c (float_to_string): Detect width overflow more reliably.
1179 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1180 buffer overrun. Don't assume list length fits in 'int'. Treat
1181 print length of 0 as 0, not as infinity; to be consistent with other
1182 uses of print length in this function. Don't overflow print length
1183 index. Don't assume hash table size fits in 'long', or that
1184 vectorlike size fits in 'unsigned long'.
1185
31c286f7
PE
1186 * process.c (make_process): Use printmax_t, not int, to format
1187 process-name gensyms.
1188
55e5faa1
PE
1189 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1190
80f2e268
PE
1191 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1192 to avoid potential buffer overrun.
1193
670741ab
PE
1194 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1195 if X resource line is longer than 512 bytes.
1196
b7163a50
PE
1197 * xfns.c (x_window): Make sprintf buffer a bit bigger
1198 to avoid potential buffer overrun.
1199
ae58ff1f
PE
1200 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1201
c43c8a6a
PE
1202 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1203
3f8236f4
PE
12042011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1205
53e9fe90 1206 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1207 Without these, Emacs silently mishandles large integers sometimes.
1208 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1209 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1210
6511acf2
PE
1211 * xdisp.c (try_window_id): Check Emacs fixnum range before
1212 converting to 'int'.
806add1d 1213
6511acf2 1214 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1215 Check that an Emacs fixnum is in range before assigning it to 'int'.
1216 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1217 values converted from Emacs fixnums.
1218 (Frecenter): Don't wrap around a line count if it is out of 'int'
1219 range; instead, treat it as an extreme value.
1220 (Fset_window_configuration, compare_window_configurations):
1221 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1222
6511acf2
PE
1223 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1224 that can exceed INT_MAX. Check that EMACS_INT value is in range
1225 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1226 (match_limit): Don't assume that a fixnum can fit in 'int'.
1227
6511acf2 1228 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1229 exceed INT_MAX.
1230
6511acf2 1231 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1232 (Fvertical_motion): Don't wrap around LINES values that don't fit
1233 in 'int'. Instead, treat them as extreme values. This is good
1234 enough for windows, which can't have more than INT_MAX lines anyway.
1235
fcb901a7
LMI
12362011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1237
0f2f6b6d
LMI
1238 * Require libxml/parser.h to avoid compilation warning.
1239
fcb901a7
LMI
1240 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1241
1242 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1243 since this reportedly can destroy thread storage.
1244
6e20a0d4
CY
12452011-08-30 Chong Yidong <cyd@stupidchicken.com>
1246
1247 * syntax.c (find_defun_start): Update all cache variables if
1248 exiting early (Bug#9401).
1249
148ae00e
EZ
12502011-08-30 Eli Zaretskii <eliz@gnu.org>
1251
f6cfbd8f
EZ
1252 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1253
148ae00e
EZ
1254 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1255 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1256 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1257
1258 * term.c (tty_append_glyph): New function.
1259 (produce_stretch_glyph): Static function and its prototype deleted.
1260
a66cfb1c
SM
1261 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1262 Add prototypes.
148ae00e 1263
c4a07a4c
PE
12642011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1265
1266 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1267 when checking :margin (Bug#9390).
1268 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1269 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1270 so that the name doesn't mislead. All uses changed.
1271
6bc8cd65
JB
12722011-08-28 Johan Bockgård <bojohan@gnu.org>
1273
1274 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1275 set_tty_hooks.
1276
dca4927e
EZ
12772011-08-27 Eli Zaretskii <eliz@gnu.org>
1278
1279 * xdisp.c (move_it_to): Don't bail out early when reaching
1280 position beyond to_charpos, if we are scanning backwards.
1281 (move_it_vertically_backward): When DY == 0, make sure we get to
1282 the first character in the line after the newline.
1283
f2cad773
PE
12842011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1287 (ccl_driver): Do not generate an out-of-range pointer.
1288 (Fccl_execute_on_string): Remove unnecessary check for
1289 integer overflow, noted by Stefan Monnier in
1290 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1291 Remove a FIXME that didn't need fixing.
1292 Simplify the newly-introduced buffer reallocation code.
1293
0cae2cdb
JB
12942011-08-27 Juanma Barranquero <lekktu@gmail.com>
1295
1296 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1297
5fc295a4 12982011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1299
70c60eb2 1300 Integer and memory overflow issues (Bug#9196).
726e0ab1 1301
d31850da
PE
1302 * doc.c (get_doc_string): Rework so that
1303 get_doc_string_buffer_size is the actual buffer size, rather than
1304 being 1 less than the actual buffer size; this makes xpalloc more
1305 convenient.
1306
a69fbedb
PE
1307 * image.c (x_allocate_bitmap_record, cache_image):
1308 * xselect.c (Fx_register_dnd_atom):
1309 Simplify previous changes by using xpalloc.
1310
fe5c5d37
PE
1311 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1312 since either will do and ptrdiff_t is convenient with xpalloc.
1313
0065d054
PE
1314 * charset.c (charset_table_size)
1315 (struct charset_sort_data.priority): Now ptrdiff_t.
1316 (charset_compare): Don't overflow if priorities differ greatly.
1317 (Fsort_charsets): Don't assume list length fits in int.
1318 Check for size-calculation overflow when allocating sort data.
1319 (syms_of_charset): Allocate an initial charset table that is
1320 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1321
1322 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1323
1324 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1325 The actual value is always <= INT_MAX, and leaving it unsigned made
1326 overflow checking harder.
1327
1328 * dispextern.h (struct glyph_matrix.rows_allocated)
1329 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1330 with xpalloc. The values are still always <= INT_MAX.
1331
1332 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1333
1334 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1335 (SAFE_NALLOCA): New macro.
1336
1337 * region-cache.c (struct boundary.pos, find_cache_boundary)
1338 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1339 (set_cache_region, invalidate_region_cache)
1340 (revalidate_region_cache, know_region_cache, region_cache_forward)
1341 (region_cache_backward, pp_cache):
1342 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1343 so that ptrdiff_t * can be passed to xpalloc.
1344 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1345 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1346 (pp_cache): Don't assume cache_len fits in int.
1347 * region-cache.h: Adjust extern decls to match.
1348
1349 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1350 EMACS_INT, since either will do, for xpalloc.
1351
1352 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1353 (xnmalloc, xnrealloc, xpalloc): New functions.
1354
726e0ab1
PE
1355 * bidi.c (bidi_shelve_header_size): New constant.
1356 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1357 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1358
51f30bc5 1359 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1360 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1361 (overlay_strings):
1362 Don't update size of array until after memory allocation succeeds,
1363 because xmalloc/xrealloc may not return.
0065d054
PE
1364 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1365 now that we have proper integer overflow checking.
1366 (record_overlay_string, overlay_strings): Catch overflows when
1367 calculating size of overlay_str_buf.
726e0ab1 1368
0065d054
PE
1369 * callproc.c (Fcall_process): Check for size overflow when
1370 calculating size of args2.
1371 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1372 Normally we prefer signed values, but sticking with ptrdiff_t would
1373 require adding more-complicated checks.
726e0ab1
PE
1374
1375 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1376 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1377 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1378 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1379
1380 * character.c (Fstring): Check for size-calculation overflow.
1381
1382 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1383 unnecessary integer overflow. Check for size overflow.
1384 (encode_coding_object): Don't update size until xmalloc succeeds.
1385
1386 * composite.c (get_composition_id): Check for overflow in glyph
1387 length calculations.
1388
1389 Integer and memory overflow fixes for display code.
1390 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1391 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1392 (scrolling_window): Check for overflow in size calculations.
1393 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1394 Don't assume glyph table len fits in int.
1395 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1396 (row_table_size): Now ptrdiff_t, not int.
1397 (scrolling_window): Avoid overflow in size calculations.
1398 Don't update size until allocation succeeds.
1399 * fns.c (concat): Check for overflow in size calculations.
1400 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1401 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1402 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1403
1404 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1405 (get_doc_string): Check for size calculation overflow.
1406 Don't update size until allocation succeeds.
1407 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1408 EMACS_INT, where ptrdiff_t will do.
1409 (Fsubstitute_command_keys): Check for string overflow.
1410
1411 * editfns.c (set_time_zone_rule): Don't assume environment length
1412 fits in int.
1413 (message_length): Now ptrdiff_t, not int.
1414 (Fmessage_box): Don't update size until allocation succeeds.
1415 Don't assume message length fits in int.
1416 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1417
0065d054
PE
1418 * emacs.c (main): Do not reallocate argv, since there is a null at
1419 the end that can be overwritten, and this way there's no need to
1420 worry about size-calculation overflow.
1421 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1422
1423 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1424 alloc succeeds.
1425 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1426
1427 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1428 (x_set_scroll_bar_width, x_figure_window_size):
1429 Check for integer overflow.
1430 (x_set_alpha): Do not assume XINT fits in int.
1431
1432 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1433 This is for the members text_lines, text_cols, total_lines, total_cols,
1434 where the system imposes an 'int' limit.
1435
1436 * fringe.c (Fdefine_fringe_bitmap):
1437 Don't update size until alloc works.
1438
1439 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1440 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1441
1442 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1443 Check for size-calculation overflow.
1444 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1445 do, as we prefer signed integers.
1446 (id_to_widget.max_size, id_to_widget.used)
1447 (xg_store_widget_in_map, xg_remove_widget_from_map)
1448 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1449 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1450 Use and return ptrdiff_t, not int.
1451 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1452 * gtkutil.h: Change prototypes to match the above.
1453
1454 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1455 are duplicate now that they've been promoted to lisp.h.
1456 (x_allocate_bitmap_record, x_alloc_image_color)
1457 (make_image_cache, cache_image, xpm_load):
1458 Don't update size until alloc is done.
1459 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1460 (x_detect_edges):
3256efce 1461 Check for size calculation overflow.
726e0ab1
PE
1462 (ct_colors_allocated_max): New constant.
1463 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1464 overflow.
3256efce 1465
726e0ab1
PE
1466 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1467 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1468 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1469 Use ptrdiff_t, not int, to count maps.
1470 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1471 calculations. Don't update size until allocation succeeds.
1472 Redo calculations to avoid overflow.
726e0ab1
PE
1473 * keyboard.h: Change prototypes to match the above.
1474
1475 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1476 to count maps.
1477 (current_minor_maps): Check for size calculation overflow.
1478 * keymap.h: Change prototypes to match the above.
1479
1480 * lread.c (read1, init_obarray): Don't update size until alloc done.
1481
1482 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1483 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1484
726e0ab1
PE
1485 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1486 Now ptrdiff_t, not int.
1487 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1488 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1489
1490 * process.c (Fnetwork_interface_list): Check for overflow
1491 in size calculation.
1492
1493 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1494
1495 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1496 overflow. Don't bother calling xmalloc when xrealloc will do.
1497
1498 * search.c (Freplace_match): Check for size calculation overflow.
1499 (Fset_match_data): Don't assume list lengths fit in 'int'.
1500
1501 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1502 for command line length. Do not attempt to address one before the
1503 beginning of an array, as that's not portable.
1504
1505 * term.c (max_frame_lines): Remove; unused.
1506 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1507 not int.
1508 (encode_terminal_code, calculate_costs): Check for size
1509 calculation overflow.
1510 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1511 table lengths and related sizes. Don't update size until alloc
1512 done. Redo calculations to avoid overflow.
1513 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1514
1515 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1516 subtracting pointers.
1517 (gobble_line): Check for overflow more carefully. Don't update size
1518 until alloc done.
1519
1520 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1521 Don't update size until alloc done.
1522 Redo size calculations to avoid overflow.
1523 Check for size calculation overflow.
0065d054 1524 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1525
1526 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1527 Use ptrdiff_t, not int, for sizes.
1528 (store_mode_line_noprop_char): Don't update size until alloc done.
1529
0065d054
PE
1530 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1531 Use ptrdiff_t, not int, for sizes.
1532 (Finternal_make_lisp_face, cache_face):
1533 Check for size calculation overflow.
1534 (cache_face): Treat size calculation overflows as if they were
1535 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1536
1537 * xfns.c (x_encode_text, x_set_name_internal)
1538 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1539 sizes, since they can exceed INT_MAX in size. Check for size
1540 calculation overflow.
1541
0065d054
PE
1542 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1543 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1544 Don't update size until alloc done.
1545
0065d054 1546 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1547 as sprintf is limited to int lengths.
1d526e2f 1548
252c5ee1
PE
1549 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1550 (X_LONG_MIN): New macros.
864d7ce7
PE
1551 Use them to make the following changes clearer.
1552 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1553 This change doesn't affect the value now, but it may help remind
1554 future maintainers not to raise the value too much later.
1555 (SELECTION_QUANTUM): Remove, replacing with ...
1556 (selection_quantum): ... new function, which avoids overflow.
1557 All uses changed.
1558 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1559 assumption that selection length fits in 'int'.
1560 (x_reply_selection_request, x_handle_selection_request)
1561 (x_get_window_property, receive_incremental_selection)
1562 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1563 (lisp_data_to_selection_data, clean_local_selection_data):
1564 Use ptrdiff_t, not int, to record length of selection.
1565 (x_reply_selection_request, x_get_window_property)
1566 (receive_incremental_selection, x_property_data_to_lisp):
1567 Redo calculations to avoid overflow.
1568 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1569 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1570 something.
1571 (x_get_window_property, receive_incremental_selection)
1572 (lisp_data_to_selection_data, x_property_data_to_lisp):
1573 Check for size-calculation overflow.
1574 (x_get_window_property, receive_incremental_selection)
1575 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1576 Don't store size until memory allocation succeeds.
1577 (x_get_window_property): Plug memory leak on memory exhaustion.
1578 Don't double-block input; malloc is safe here. Don't assume 2**34
1579 - 4 fits in unsigned long. Add an xassert to check
1580 XGetWindowProperty overflow. Be more careful about overflow
1581 calculations, and distinguish size from memory overflow better.
1582 (receive_incremental_selection): When tracing, don't assume
1583 unsigned int is less than INT_MAX.
1584 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1585 harmful) conversions of unsigned short to int.
1586 (lisp_data_to_selection_data): Don't assume that integers
1587 in the range -65535 through -1 fit in an X unsigned short.
1588 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1589 result parameters unless successful. Rely on cons_to_unsigned
1590 to report problems with elements; the old code wasn't right anyway.
1591 (x_check_property_data): Check for int overflow; we cannot use
1592 a wider type due to X limits.
1593 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1594
726e0ab1 1595 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1596
0065d054
PE
1597 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1598 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1599 (x_color_cells): Don't store size until memory allocation succeeds.
1600 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1601 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1602 (x_term_init): Don't assume length fits in int (sprintf is limited
1603 to int size).
bc18e09d 1604
ebfa62c0
PE
1605 Use ptrdiff_t for composition IDs.
1606 * character.c (lisp_string_width):
1607 * composite.c (composition_table_size, n_compositions)
1608 (get_composition_id, composition_gstring_from_id):
1609 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1610 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1611 * window.c (Frecenter):
1612 Use ptrdiff_t, not int, for composition IDs.
1613 * composite.c (get_composition_id): Check for integer overflow.
1614 * composite.h: Adjust prototypes to match the above changes.
1615
d3411f89
PE
1616 Use ptrdiff_t for hash table indexes.
1617 * category.c (hash_get_category_set):
1618 * ccl.c (ccl_driver):
1619 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1620 * coding.c (coding_system_charset_list, detect_coding_system):
1621 * coding.h (struct coding_system.id):
1622 * composite.c (get_composition_id, gstring_lookup_cache):
1623 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1624 * image.c (xpm_get_color_table_h):
1625 * lisp.h (hash_lookup, hash_put):
1626 * minibuf.c (Ftest_completion):
1627 Use ptrdiff_t for hash table indexes, not int (which is too
1628 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1629 32-bit --with-wide-int hosts).
1630
e097a6fa
PE
1631 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1632 Add a FIXME comment about memory leaks.
1633 (syms_of_charset): Don't assume xmalloc returns.
1634
5637687f
PE
1635 Don't assume that stated character widths fit in int.
1636 * character.c (Fchar_width, c_string_width, lisp_string_width):
1637 * character.h (CHAR_WIDTH):
1638 * indent.c (MULTIBYTE_BYTES_WIDTH):
1639 Use sanitize_char_width to avoid undefined and/or bad behavior
1640 with outlandish widths.
a66cfb1c 1641 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1642 now that we have two such functions. All uses changed.
1643 (sanitize_char_width): New inline function.
1644
a2271ba2
PE
1645 Don't assume that tab-width fits in int.
1646 * character.h (sanitize_width): New inline function.
1647 (SANE_TAB_WIDTH): New macro.
1648 (ASCII_CHAR_WIDTH): Use it.
1649 * indent.c (sane_tab_width): Remove. All uses replaced by
1650 SANE_TAB_WIDTH (current_buffer).
1651 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1652
18c52557
PE
1653 * fileio.c: Integer overflow issues with file modes.
1654 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1655
caeeedc1
PE
1656 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1657 Remove unreachable code.
1658 (read_hex, load_charset_map_from_file): Check for integer overflow.
1659
50849c52
PE
1660 * xterm.c: don't go over XClientMessageEvent limit
1661 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1662 (x_send_scroll_bar_event): Likewise. Check that the size does not
1663 exceed limits imposed by XClientMessageEvent, as well as the usual
1664 ptrdiff_t and size_t limits.
1665
b13995db
PE
1666 * keyboard.c: Overflow, signedness and related fixes.
1667 (make_lispy_movement): Use same integer type in forward decl
1668 that is used in the definition.
1669 (read_key_sequence, keyremap_step):
1670 Change bufsize argument back to int, undoing my 2011-03-30 change.
1671 We prefer signed types, and int is wide enough here.
1672 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1673 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1674 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1675 length, not size_t. Use ptrdiff_t for index, not int.
1676 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1677 possibility of integer overflow.
1678
13464394
PE
1679 Overflow, signedness and related fixes for images.
1680
1681 * dispextern.h (struct it.stack[0].u.image.image_id)
1682 (struct_it.image_id, struct image.id, struct image_cache.size)
1683 (struct image_cache.used, struct image_cache.ref_count):
1684 * gtkutil.c (update_frame_tool_bar):
1685 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1686 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1687 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1688 * nsmenu.m (update_frame_tool_bar):
1689 * xdisp.c (calc_pixel_width_or_height):
1690 * xfns.c (image_cache_refcount):
1691 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1692 on typical 64-bit hosts.
1693
1694 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1695 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1696 Omit unnecessary casts to int.
1697 (parse_image_spec): Check that integers fall into 'int' range
1698 when the callers expect that.
1699 (image_ascent): Redo ascent calculation to avoid int overflow.
1700 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1701 (lookup_image): Remove unnecessary tests.
1702 (xbm_image_p): Locals are now of int, not EMACS_INT,
1703 since parse_image_check makes sure they fit into int.
1704 (png_load, gif_load, svg_load_image):
1705 Prefer int to unsigned where either will do.
1706 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1707 old tiff_error_handler and tiff_warning_handler.
1708 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1709 stack buffer overflows. It uses only the features of vsnprintf
1710 that are common to both POSIX and native Microsoft.
1711 (tiff_error_handler, tiff_warning_handler): Use it.
1712 (tiff_load, gif_load, imagemagick_load_image):
1713 Don't assume :index value fits in 'int'.
1714 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1715 (imagemagick_load_image): Check that crop parameters fit into
1716 the integer types that MagickCropImage accepts. Don't assume
1717 Vimagemagick_render_type has a nonnegative value. Don't assume
1718 size_t fits in 'long'.
1719 (gs_load): Use printmax_t to print the widest integers possible.
1720 Check for integer overflow when computing image height and width.
1721
c11821d4
EZ
17222011-08-26 Eli Zaretskii <eliz@gnu.org>
1723
1724 * xdisp.c (redisplay_window): Don't force window start if point
1725 will be invisible in the resulting window. (Bug#9324)
1726
0c95fcf7
EZ
17272011-08-25 Eli Zaretskii <eliz@gnu.org>
1728
1729 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1730 the display spec is of the form `(space ...)'.
1731 (handle_display_spec): Return the value returned by
1732 handle_single_display_spec, not just 1 or zero.
1733 (handle_single_display_spec): If the display spec is of the form
1734 `(space ...)', and specifies display in the text area, return 2
1735 rather than 1.
fee65a97 1736 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1737 accurately, and prefer exact match for point under bidi.
1738 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1739
1740 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1741 into disp_prop; all users changed.
1742
1743 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1744 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1745 for the text covered by the display property.
1746
e4ed06f1
CY
17472011-08-25 Chong Yidong <cyd@stupidchicken.com>
1748
1749 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1750 Change return value to nil.
1751 (Frecord_buffer): Delete unused function.
1752
f67cdd7f
EZ
17532011-08-24 Eli Zaretskii <eliz@gnu.org>
1754
5980d4c6
EZ
1755 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1756 buffers, return left-to-right.
8610fe8b
EZ
1757 (set_cursor_from_row): Consider candidate row a win if its glyph
1758 represents a newline and point is on that newline. Fixes cursor
1759 positioning on the newline at EOL of R2L text within L2R
1760 paragraph, and vice versa.
1761 (try_cursor_movement): Check continued rows, in addition to
1762 continuation rows. Fixes unwarranted scroll when point enters a
1763 continued line of R2L text within an L2R paragraph, or vice versa.
1764 (cursor_row_p): Consider the case of point being equal to
1765 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1766 from the end of a short line to the beginning of a continued line
1767 of R2L text within L2R paragraph.
1768 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1769 composed characters.
5980d4c6 1770
f67cdd7f
EZ
1771 * bidi.c (bidi_check_type): Use xassert.
1772 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1773 members.
1774
bca633fb
EZ
17752011-08-23 Eli Zaretskii <eliz@gnu.org>
1776
1777 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1778 a character.
1779
4a5885a7
CY
17802011-08-23 Chong Yidong <cyd@stupidchicken.com>
1781
1782 * nsfont.m (ns_otf_to_script): Fix typo.
1783
0902a04e
KH
17842011-08-22 Kenichi Handa <handa@m17n.org>
1785
1786 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1787 extra slot even if the purpose is char-code-property-table.
1788
1a2e6670
EZ
17892011-08-23 Eli Zaretskii <eliz@gnu.org>
1790
8ddde651
EZ
1791 * xdisp.c (redisplay_window): When computing centering_position,
1792 account for the height of the header line. (Bug#8874)
1793
425cc014
EZ
1794 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1795 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1796 candidate is selected by the mouse, and that candidate has a
1797 composed character under the mouse.
1798
1a2e6670
EZ
1799 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1800 coordinates reported by pos-visible-in-window-p for a composed
1801 character in column zero.
1802
8b76d6f8
SM
18032011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1804
1805 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1806
dac347dd
EZ
18072011-08-22 Eli Zaretskii <eliz@gnu.org>
1808
1809 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1810 consider it a hit if to_charpos is anywhere in the range of the
1811 composed buffer positions.
1812
e013fb34
CY
18132011-08-22 Chong Yidong <cyd@stupidchicken.com>
1814
1815 * image.c (gif_load): Don't assume that each subimage has the same
1816 dimensions as the base image. Handle disposal method that is
1817 "undefined" by the gif spec (Bug#9335).
1818
bd1ba3e8
CY
18192011-08-20 Chong Yidong <cyd@stupidchicken.com>
1820
1821 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1822 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1823
54a1215b
EZ
18242011-08-19 Eli Zaretskii <eliz@gnu.org>
1825
823564e5
EZ
1826 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1827 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1828 from an Org mode buffer to a Speedbar frame.
1829
54a1215b
EZ
1830 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1831 a composition, take its buffer position from IT->cmp_it.charpos.
1832 Fixes cursor positioning at the beginning of a line that begins
1833 with a composed character.
1834
9778ebcc
EZ
18352011-08-18 Eli Zaretskii <eliz@gnu.org>
1836
0be6ee06
EZ
1837 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1838 character bidirectional type, use STRONG_L instead. Fixes crashes
1839 in a buffer produced by `describe-categories'.
1840
9778ebcc
EZ
1841 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1842 members before the level stack, so they would be saved and
1843 restored when copying iterator state. Fixes incorrect reordering
1844 around TABs covered by display properties.
1845
156bffbe
AS
18462011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1847
6b02f655 1848 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1849
72ad093b
CY
18502011-08-17 Chong Yidong <cyd@stupidchicken.com>
1851
1852 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1853 (internal_condition_case_2, internal_condition_case_n):
1854 Remove unnecessary aborts (Bug#9081).
72ad093b 1855
35774242
EZ
18562011-08-17 Eli Zaretskii <eliz@gnu.org>
1857
1858 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1859 has no `load' handler, try opening the file locally. (Bug#9311)
1860
db76dd85
KB
18612011-08-16 Ken Brown <kbrown@cornell.edu>
1862
1863 * gmalloc.c: Expand comment.
1864
b215eee5
EZ
18652011-08-16 Eli Zaretskii <eliz@gnu.org>
1866
1867 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1868 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1869
a4579d33
KB
18702011-08-16 Ken Brown <kbrown@cornell.edu>
1871
1872 Fix memory allocation problems in Cygwin build (Bug#9273).
1873
1874 * unexcw.c ( __malloc_initialized): Declare external variable.
1875 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1876
8b76d6f8
SM
1877 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1878 New variables.
a4579d33
KB
1879 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1880 dumped emacs.
1881 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1882 in the static heap.
1883 [CYGWIN] (special_realloc): New function.
1884 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1885 requests to realloc storage in the static heap.
1886
3ebec551
PE
18872011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1888
1889 * bidi.c (bidi_initialize): Remove unused local.
1890
9fd8be00
EZ
18912011-08-15 Eli Zaretskii <eliz@gnu.org>
1892
6b02f655
SM
1893 * bidimirror.h:
1894 * biditype.h: Remove file.
1895 * makefile.w32-in ($(BLD)/bidi.$(O)):
1896 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1897
1898 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1899
1900 * chartab.c: Improve commentary for the uniprop_table API.
1901
32413314
EZ
1902 * bidi.c (bidi_paragraph_init): Support zero value of
1903 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1904 (bidi_initialize): Use uniprop_table instead of including
1905 biditype.h and bidimirror.h.
32413314 1906
9fd8be00
EZ
1907 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1908 coordinates of the iterator when restoring from ppos_it.
1909 (Bug#9296)
1910
5cf2b69b
KH
19112011-08-14 Kenichi Handa <handa@m17n.org>
1912
1913 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1914 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1915
daf17d00
EZ
19162011-08-14 Eli Zaretskii <eliz@gnu.org>
1917
1918 * xdisp.c (move_it_in_display_line_to): Don't invoke
1919 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1920 ppos_it. Fixes vertical cursor motion when line beginning is
1921 covered by an image. (Bug#9296)
1922
08e3161a
JD
19232011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1924
1925 * nsterm.h (ns_run_ascript): Declare.
1926 (NSAPP_DATA2_RUNASSCRIPT): Define.
1927
1928 * nsfns.m (as_script, as_result, as_status): New static variables.
1929 (ns_run_ascript): New function.
5e617bc2 1930 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1931 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1932 the event loop. Get status from as_status (Bug#7276).
1933
1934 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1935 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1936 the event loop (Bug#7276).
1937
a3720aa2
AS
19382011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1939
1940 * gnutls.c (QCgnutls_bootprop_priority)
1941 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1942 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1943 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1944 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1945 (QCgnutls_bootprop_verify_hostname_error)
1946 (QCgnutls_bootprop_callbacks_verify): Rename from
1947 Qgnutls_bootprop_..., all uses changed.
1948
1949 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1950 uses changed.
1951
0a0d27fb
PE
19522011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1953
19d5c50c
PE
1954 * xfaces.c (Qframe_set_background_mode): Now static.
1955 * dispextern.h (Qframe_set_background_mode): Remove decl.
1956
0a0d27fb
PE
1957 * process.c (Fnetwork_interface_info): Declare local only if needed.
1958
377538cb
JD
19592011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1960
1961 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1962 (Fnetwork_interface_list): Allocate in increments of bytes instead
1963 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1964 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1965 sockaddr.
1966 (struct ifflag_def): notrailers is smart on OSX.
1967 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1968 Get hardware address with getifaddrs if available.
1969
08fff70c
EZ
19702011-08-12 Eli Zaretskii <eliz@gnu.org>
1971
1972 * xdisp.c (iterate_out_of_display_property): xassert that
1973 IT->position is set to within IT->object's boundaries. Break from
1974 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1975 when IT->position is set up wrongly due to some bug.
1976 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1977 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1978 entry. Force push_it to save on the stack the current
1979 buffer/string position, to be restored by pop_it. Fix flags in
1980 the iterator structure wrt the object coming from a display
1981 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1982 properties. (Bug#9284)
1983
7be1c708 19842011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1985
7be1c708
CY
1986 * fontset.c (fontset_get_font_group): Add proper type checks.
1987 (Bug#9172)
aac0c6e3 1988
7be1c708 19892011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1990
7be1c708
CY
1991 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1992 and LC_VERSION_MIN_MACOSX.
1993 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1994 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1995
97bb72a6
EZ
19962011-08-08 Eli Zaretskii <eliz@gnu.org>
1997
1998 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1999 no-display-properties-and-no-overlays under bidi display.
2000 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2001 properties and overlays.
97bb72a6 2002
d5617611
CY
20032011-08-08 Chong Yidong <cyd@stupidchicken.com>
2004
37e11a63
CY
2005 * editfns.c (Fset_time_zone_rule): Document relationship with the
2006 setenv function.
2007
d5617611
CY
2008 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2009 the font entity extracted from the cache (Bug#8109).
2010
58872834
CY
20112011-08-07 Chong Yidong <cyd@stupidchicken.com>
2012
2013 * composite.c (autocmp_chars): Don't reset point. That is done by
2014 restore_point_unwind (Bug#5984).
2015
75bfc667
JL
20162011-08-07 Juri Linkov <juri@jurta.org>
2017
2018 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2019 to show the arg `TIME' instead of `TIMEVAL'.
2020
d1410150
EZ
20212011-08-06 Eli Zaretskii <eliz@gnu.org>
2022
2023 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2024 display property strides EOL and includes a newline, as in
2025 longlines-mode. (Bug#9254)
75b771e4
EZ
2026 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2027 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2028
2029 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2030 is non-zero, even if the data buffer is NULL. Fixes a crash in
2031 vertical-motion with longlines-mode. (Bug#9254)
2032
35928349
EZ
20332011-08-05 Eli Zaretskii <eliz@gnu.org>
2034
ec7cc85b
EZ
2035 * bidi.c <bidi_cache_total_alloc>: Now static.
2036 (bidi_initialize): Initialize bidi_cache_total_alloc.
2037
8b76d6f8 2038 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2039 cache. (Bug#9221)
2040
2041 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2042 amount allocated this far in `bidi_cache_total_alloc'.
2043 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2044 non-zero, only free the data buffer without restoring the cache
2045 contents. All callers changed.
2046
2047 * dispextern.h (bidi_unshelve_cache): Update prototype.
2048
2049 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2050 (move_it_in_display_line, move_it_to)
2051 (move_it_vertically_backward, move_it_by_lines): Replace the call
2052 to xfree to an equivalent call to bidi_unshelve_cache.
2053 (move_it_in_display_line_to): Fix logic of returning
412b6358 2054 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2055
e2e2423b
EZ
20562011-08-05 Eli Zaretskii <eliz@gnu.org>
2057
2058 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2059 came from a string character with a `cursor' property. (Bug#9229)
2060
ae9e757a
JD
20612011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2062
2063 * Makefile.in (LIB_PTHREAD): New variable.
2064 (LIBES): Add LIB_PTHREAD (Bug#9216).
2065
2066 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2067 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2068
213bd7f2
AS
20692011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2070
6b02f655 2071 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2072
99aaf75f
JD
20732011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2074
2075 * xterm.c (x_find_topmost_parent): New function.
2076 (x_set_frame_alpha): Find topmost parent window with
2077 x_find_topmost_parent and set the property there also (bug#9181).
2078 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2079
c74e9d86
PE
20802011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2081
2082 * callproc.c (Fcall_process): Avoid vfork clobbering
2083 the local vars buffer, coding_systems, current_dir.
2084
640c8776
SM
20852011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2086
2087 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2088
f26d0e4c
PE
20892011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2090
8a10d76c
PE
2091 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2092 so that it is not optimized away.
2093
f26d0e4c
PE
2094 * xdisp.c (compute_display_string_pos): Remove unused local.
2095
55439c61
EZ
20962011-08-02 Eli Zaretskii <eliz@gnu.org>
2097
2098 Fix slow cursor motion and scrolling in large buffers with
2099 selective display, like Org Mode buffers. (Bug#9218)
2100
2101 * dispextern.h (struct bidi_it): New member disp_prop_p.
2102
2103 * xdisp.c: Remove one-slot cache of display string positions.
2104 (compute_display_string_pos): Accept an additional argument
5e617bc2 2105 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2106 for a display string or property. If found, set DISP_PROP_P
2107 non-zero.
2108
2109 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2110 DISP_PROP_P, and pass it to compute_display_string_pos.
2111 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2112 non-zero. All callers of bidi_fetch_char changed.
2113
fb33fa43
SM
21142011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2115
2116 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2117
b099e063
DM
21182010-12-03 Don March <don@ohspite.net>
2119
2120 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2121 last character M-[char] is translated to ESC [char] (bug#7541).
2122
5cc7f7af
KH
21232011-08-02 Kenichi Handa <handa@m17n.org>
2124
d0fffa3f 2125 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2126
2127 * chartab.c (uniprop_table): Make it non-static.
2128
525d5e6e
EZ
21292011-08-01 Eli Zaretskii <eliz@gnu.org>
2130
2131 * xdisp.c (forward_to_next_line_start): Accept additional argument
2132 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2133 on the newline.
2134 (reseat_at_next_visible_line_start): Use the bidi iterator state
2135 returned by forward_to_next_line_start to restore the state of
2136 it->bidi_it after backing up to previous newline. (Bug#9212)
2137
31011111
AS
21382011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2139
2140 * regex.c (re_comp): Protoize.
2141 (re_exec): Fix return type.
2142 (regexec): Fix type of `ret'. (Bug#9203)
2143
476371c4
PE
21442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2145
e5d76069
PE
2146 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2147 This is needed if max-image-size is a floating-point number.
2148
9a79b20c
AS
21492011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2150
2151 * print.c (print_object): Print empty symbol as ##.
2152
2153 * lread.c (read1): Read ## as empty symbol.
2154
d8c2fa78
AA
21552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2156
2157 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2158 setting frame foreground color (Bug#9175).
2159 (x_set_background_color): Likewise.
2160
ffe57a7a
AA
2161 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2162 contents (Bug#9176).
2163 (EmacsTooltip -init): Remove bezels and add shadows to
2164 tooltip windows.
2165
bf3492a5
AA
2166 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2167 or scroll bar (Bug#8470).
2168
d55e9c53
AA
2169 * nsfont.m (nsfont_open): Remove assignment to voffset and
2170 unnecessary vars hshink, expand, hd, full_height, min_height.
2171 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2172
2173 * nsterm.h (nsfont_info): Remove voffset field.
2174
d8c2fa78 21752011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2176
2177 Implement strike-through and overline on NextStep (Bug#8863).
2178
2179 * nsfont.m (nsfont_open): Use underline position provided by font,
2180 instead of hard-coded value of 2.
2181 (nsfont_draw): Call ns_draw_text_decoration instead.
2182
2183 * nsterm.h: Add declaration for ns_draw_text_decoration.
2184
2185 * nsterm.m (ns_draw_text_decoration): New function for drawing
2186 underline, overline, and strike-through.
2187 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2188 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2189 accommodate underlining, etc.
4843aac3 2190
4cc60b9b
EZ
21912011-07-28 Eli Zaretskii <eliz@gnu.org>
2192
bc7ece87
EZ
2193 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2194 default.
4cc60b9b 2195
476371c4
PE
21962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2197
66606eea
PE
2198 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2199 Without this fix, if a signal arrives just after memory fills up,
2200 'malloc' might be invoked reentrantly.
2201
476371c4
PE
2202 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2203 In other words, assume that every image size is allowed, on non-X
2204 hosts. This assumption is probably wrong, but it lets Emacs compile.
2205
f3fcc40d
AS
22062011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2207
2208 * regex.c (re_iswctype): Convert return values to boolean.
2209
350c992f
EZ
22102011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2211
2212 * xdisp.c (compute_display_string_pos): Don't use cached display
2213 string position if the buffer had its restriction changed.
2214 (Bug#9184)
2215
5266b4bb
PE
22162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2217
2218 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2219
2573a837 22202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2221
41f55ccd 2222 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2223
39e378da
PE
2224 * bidi.c: Integer size and overflow fixes.
2225 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2226 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2227 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2228 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2229 (bidi_find_other_level_edge):
2230 Use ptrdiff_t instead of EMACS_INT where either will do.
2231 This works better on 32-bit hosts configured --with-wide-int.
2232 (bidi_cache_ensure_space): Check for size-calculation overflow.
2233 Use % rather than repeated addition, for better worst-case speed.
2234 Don't set bidi_cache_size until after xrealloc returns, because it
2235 might not return.
2236 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2237 (bidi_cache_ensure_space): Also check that the bidi cache size
2238 does not exceed that of the largest Lisp string or buffer. See Eli
2239 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2240
5e927815
PE
2241 * alloc.c (__malloc_size_t): Remove.
2242 All uses replaced by size_t. See Andreas Schwab's note
2243 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2244
ca4aa935
PE
2245 * image.c: Improve checking for integer overflow.
2246 (check_image_size): Assume that f is nonnull, since
2247 it is always nonnull in practice. This is one less thing to
2248 worry about when checking for integer overflow later.
2249 (x_check_image_size): New function, which checks for integer
2250 overflow issues inside X.
2251 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2252 This removes the need for a memory_full check.
2253 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2254 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2255 (xbm_read_bitmap_data): Change locals back to 'int', since
2256 their values must fit in 'int'.
2257 (xpm_load_image, png_load, tiff_load):
2258 Invoke x_create_x_image_and_pixmap earlier,
2259 to avoid much needless work if the image is too large.
2260 (tiff_load): Treat overly large images as if
2261 x_create_x_image_and_pixmap failed, not as malloc failures.
2262 (gs_load): Use x_check_image_size.
2263
5f8f9cc2
PE
2264 * gtkutil.c: Omit integer casts.
2265 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2266 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2267
5adf60bc
PE
2268 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2269
c8907a93
PE
2270 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2271 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2272 would wrongly return t on a 64-bit host.
2273
e3c25c68
PE
2274 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2275 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2276 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2277 and therefore cause GCC to emit a bogus diagnostic in some cases.
2278
3f791afe
PE
2279 * image.c: Integer signedness and overflow and related fixes.
2280 This is not an exhaustive set of fixes, but it's time to
2281 record what I've got.
2282 (lookup_pixel_color, check_image_size): Remove redundant decls.
2283 (check_image_size): Don't assume that arbitrary EMACS_INT values
2284 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2285 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2286 (tiff_load, imagemagick_load_image):
2287 Check for overflow in size calculations.
2288 (x_create_x_image_and_pixmap): Remove unnecessary test for
2289 xmalloc returning NULL; that can't happen.
2290 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2291 (xpm_color_bucket): Use better integer hashing function.
2292 (xpm_cache_color): Don't possibly over-allocate memory.
2293 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2294 (gif_memory_source):
2295 Use ptrdiff_t, not int or size_t, to record sizes.
2296 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2297 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2298 either works, as we prefer signed integers.
2299 (tiff_read_from_memory, tiff_write_from_memory):
2300 Return tsize_t, not size_t, since that's what the TIFF API wants.
2301 (tiff_read_from_memory): Don't fail simply because the read would
2302 go past EOF; instead, return a short read.
2303 (tiff_load): Omit no-longer-needed casts.
2304 (Fimagemagick_types): Don't assume size fits into 'int'.
2305
3cc5a532
PE
2306 Improve hashing quality when configured --with-wide-int.
2307 * fns.c (hash_string): New function, taken from sxhash_string.
2308 Do not discard information about ASCII character case; this
2309 discarding is no longer needed.
2310 (sxhash-string): Use it. Change sig to match it. Caller changed.
2311 * lisp.h: Declare it.
2312 * lread.c (hash_string): Remove, since we now use fns.c's version.
2313 The fns.c version returns a wider integer if --with-wide-int is
2314 specified, so this should help the quality of the hashing a bit.
2315
b312a492
PE
2316 * emacs.c: Integer overflow minor fix.
2317 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2318 Define only if GNU_LINUX.
2319 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2320
dfd153ae
PE
2321 * dispnew.c: Integer signedness and overflow fixes.
2322 Remove unnecessary forward decls, that were a maintenance hassle.
2323 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2324 All uses changed.
2325 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2326 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2327 (prepare_desired_row, line_draw_cost):
2328 Use int, not unsigned, where either works.
2329 (save_current_matrix, restore_current_matrix):
2330 Use ptrdiff_t, not size_t, where either works.
2331 (init_display): Check for overflow more accurately, and without
2332 relying on undefined behavior.
2333
a81d11a3
PE
2334 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2335 Remove, replacing with the new symbols in lisp.h. All uses changed.
2336 * fileio.c (make_temp_name):
2337 * filelock.c (lock_file_1, lock_file):
2338 * xdisp.c (message_dolog):
2339 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2340 Use pMd etc. instead.
2341 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2342 replacing the pWIDE etc. symbols removed from editfns.c.
2343
3300e6fd
PE
2344 * keyboard.h (num_input_events): Now uintmax_t.
2345 This is (very slightly) less likely to mess up due to wraparound.
2346 All uses changed.
2347
fd05c7e9
PE
2348 * buffer.c: Integer signedness fixes.
2349 (alloc_buffer_text, enlarge_buffer_text):
2350 Use ptrdiff_t rather than size_t when either will do, as we prefer
2351 signed integers.
2352
903fe15d
PE
2353 * alloc.c: Integer signedness and overflow fixes.
2354 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2355 (__malloc_size_t): Default to size_t, not to int.
2356 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2357 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2358 Prefer ptrdiff_t to size_t when either would do, as we prefer
2359 signed integers.
2360 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2361 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2362 Now const. Initialize with values that are in range even if char
2363 is signed.
2364 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2365 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2366 These functions do the right thing with sizes > 2**32.
2367 (check_depth): Now ptrdiff_t, not int.
2368 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2369 Adjust to new way of storing sizes. Check for size overflow bugs
2370 in rest of code.
2371 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2372 slightly wrong anyway, as it missed one instance of
2373 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2374 (refill_memory_reserve): Omit needless cast to size_t.
2375 (mark_object_loop_halt): Mark as externally visible.
2376
ac82cc6a
PE
2377 * xselect.c: Integer signedness and overflow fixes.
2378 (Fx_register_dnd_atom, x_handle_dnd_message):
2379 Use ptrdiff_t, not size_t, since we prefer signed.
2380 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2381 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2382 x_dnd_atoms_size and x_dnd_atoms_length.
2383
c2d1e36d
PE
2384 * doprnt.c: Prefer signed to unsigned when either works.
2385 * eval.c (verror):
2386 * doprnt.c (doprnt):
2387 * lisp.h (doprnt):
2388 * xdisp.c (vmessage):
2389 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2390 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2391 prefer signed arithmetic to avoid comparison confusion.
2392 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2393 but is a bit tricky.
2394
0e926e56
PE
2395 Assume freestanding C89 headers, string.h, stdlib.h.
2396 * data.c, doprnt.c, floatfns.c, print.c:
2397 Include float.h unconditionally.
2398 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2399 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2400 * regex.c: Likewise for stddef.h, string.h.
2401 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2402 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2403 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2404 (STDC_HEADERS): Remove obsolete defines.
2405 * sysdep.c: Include limits.h unconditionally.
2406
9cfdb3ec
PE
2407 Assume support for memcmp, memcpy, memmove, memset.
2408 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2409 * regex.c (memcmp, memcpy):
2410 Remove; we assume C89 now.
2411
2412 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2413 (__malloc_safe_bcopy): Remove; no longer needed.
2414
cf950e6b 2415 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2416 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2417 well either way, and we prefer signed to unsigned.
2418
dbf38e02
LMI
24192011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2420
2421 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2422 closes the connection while we're reading (bug#9182).
2423
d6f0886c 24242011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2425
d6f0886c
JD
2426 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2427 are specified (Bug#9168).
24e0f6b1 2428
2eb1f9e6
PE
24292011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2430
2431 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2432 Found by GCC static checking and --with-wide-int on a 32-bit host.
2433
22381272 24342011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2435
2436 * xdisp.c (compute_display_string_pos): Fix logic of caching
2437 previous display string position. Initialize cached_prev_pos to
2438 -1. Fixes slow-down at the beginning of a buffer.
2439
f25e39b4
EZ
24402011-07-24 Eli Zaretskii <eliz@gnu.org>
2441
2442 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2443 for attrs[LFACE_FONTSET_INDEX].
2444
04c4b52e
PE
24452011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2446
2447 * xml.c (parse_region): Remove unused local
2448 that was recently introduced.
2449
c1734fbd
EZ
24502011-07-23 Eli Zaretskii <eliz@gnu.org>
2451
be18c5a5
EZ
2452 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2453 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2454
c1734fbd
EZ
2455 * xdisp.c (move_it_in_display_line_to): Record the best matching
2456 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2457 exit if none of the characters scanned was an exact match.
2458 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2459 when exact match is impossible due to invisible text, and the
2460 lines are truncated.
2461
a258d627
JD
24622011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2463
2464 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2465 for OSX >= 10.7.
2466
b6d5a689
EZ
24672011-07-22 Eli Zaretskii <eliz@gnu.org>
2468
0f74f785
EZ
2469 Fix a significant slow-down of cursor motion with C-n, C-p,
2470 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2471 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2472 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2473 (next_element_from_buffer): Call compute_stop_pos_backwards to
2474 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2475 base_level_stop.
2476 (reseat): Don't look for prev_stop, as that could mean a very long
2477 run.
2478 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2479 <cached_disp_overlay_modiff>: Cache for last found display string
2480 position.
551918c1 2481 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2482 about the same buffer in the same area of character positions, and
2483 the buffer wasn't changed since the time the display string
2484 position was cached.
551918c1 2485
b2d0c91a
EZ
24862011-07-22 Eli Zaretskii <eliz@gnu.org>
2487
2488 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2489 is an integer, which is important for empty lines. (Bug#9149)
2490
043604ee
CY
24912011-07-22 Chong Yidong <cyd@stupidchicken.com>
2492
2493 * frame.c (Fmodify_frame_parameters): In tty case, update the
2494 default face if necessary (Bug#4238).
2495
da4adb04
CY
24962011-07-21 Chong Yidong <cyd@stupidchicken.com>
2497
2498 * editfns.c (Fstring_to_char): No need to explain what a character
2499 is in the docstring (Bug#6576).
2500
9abd0532
LMI
25012011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2502
2503 * xml.c (parse_region): Make sure we always return a tree.
2504
36881d16
HK
25052011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2506
2507 * xml.c (parse_region): If a document contains only comments,
2508 return that, too.
2509
1e98674d
LMI
25102011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2511
2512 * xml.c (make_dom): Return comments, too.
2513
590bd467
PE
25142011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2515
2516 Port to OpenBSD.
2517 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2518 and the surrounding thread.
2519 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2520 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2521 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2522 timer goes off.
2523 * s/openbsd.h (BROKEN_SIGIO): Define.
2524 * unexelf.c (unexec) [__OpenBSD__]:
2525 Don't update the .mdebug section of the Alpha COFF symbol table.
2526
f41628b2
LMI
25272011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2528
2529 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2530 (bug#8460).
2531
b59b67c5
PE
25322011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2533
15e3a074
PE
2534 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2535 This fixes some race conditions on the permissions of any newly
2536 created file.
2537
41bed37d
PE
2538 * alloc.c (valid_pointer_p): Use pipe, not open.
2539 This fixes some permissions issues when debugging.
2540
b59b67c5
PE
2541 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2542 If fchown fails to set both uid and gid, try to set just gid,
2543 as that is sometimes allowed. Adjust the file's mode to eliminate
2544 setuid or setgid bits that are inappropriate if fchown fails.
2545
925a6be7
SM
25462011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2547
2548 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2549 to compare Lisp_Objects.
2550 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2551 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2552 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2553
52968808
AS
25542011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2555
0a6a104b
AS
2556 * lread.c (read_integer): Unread even EOF character.
2557 (read1): Likewise. Properly record start position of symbol.
2558
52968808
AS
2559 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2560 symbol character follows.
2561
9e381cdd
PE
25622011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2565 This works around a problem with the previous change to Fcopy_file.
2566 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2567 and without this change, GCC might complain about discarding
2568 fchown's return value.
2569
b5641435
JB
25702011-07-16 Juanma Barranquero <lekktu@gmail.com>
2571
2572 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2573
a8031457
PE
25742011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2575
2576 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2577
dd889327
LMI
25782011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2579
750c33f7
LMI
2580 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2581 it's used from the C level.
2582
dd889327
LMI
2583 * process.c: Use the same condition for POLL_FOR_INPUT in both
2584 keyboard.c and process.c (bug#1858).
2585
87e86684
LM
25862011-07-09 Lawrence Mitchell <wence@gmx.li>
2587
2588 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2589 (Fgnutls_boot): Use it.
2590
64348f40
AS
25912011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2592
2593 * doc.c (Fsubstitute_command_keys): Revert last change.
2594
1d698799
LMI
25952011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2596
f863868c
LMI
2597 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2598 quotes the next character, and doesn't affect other longer
2599 sequences (bug#8935).
2600
1d698799
LMI
2601 * lread.c (syms_of_lread): Clarify that is isn't only
2602 `eval-buffer' and `eval-defun' that's affected by
2603 `lexical-binding' (bug#8460).
2604
aa4b6df6
EZ
26052011-07-15 Eli Zaretskii <eliz@gnu.org>
2606
2607 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2608 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2609
5d856da6
PE
26102011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2611
ad6042bb
PE
2612 Fix minor problems found by static checking.
2613 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2614 (elsz): Now a signed constant, not a size_t var. We prefer signed
2615 types to unsigned, to avoid integer comparison confusion. Without
2616 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2617 "cannot optimize loop, the loop counter may overflow", a symptom
2618 of the confusion.
f00bbb22 2619 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2620 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2621
6468f31c
LMI
26222011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2623
49080b10
LMI
2624 * search.c (Fre_search_backward): Mention `case-fold-search' in
2625 all the re_search_* functions (bug#8138).
2626
6468f31c
LMI
2627 * keyboard.c (Fopen_dribble_file): Document when the file is
2628 closed (bug#8056).
2629
c965adc5
EZ
26302011-07-14 Eli Zaretskii <eliz@gnu.org>
2631
df9733bf
EZ
2632 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2633 bidi_cache_idx.
2634
0bb23927
EZ
2635 Support bidi reordering of display and overlay strings.
2636 * xdisp.c (compute_display_string_pos)
2637 (compute_display_string_end): Accept additional argument STRING.
2638 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2639 (reseat_to_string): Initialize bidi_it->string.s and
2640 bidi_it->string.schars.
2641 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2642 NULL (avoids a crash in bidi_paragraph_init).
2643 Initialize itb.string.lstring.
0bb23927
EZ
2644 (init_iterator): Call bidi_init_it only of a valid
2645 buffer position was specified. Initialize paragraph_embedding to
2646 L2R.
2647 (reseat_to_string): Initialize the bidi iterator.
2648 (display_string): If we need to ignore text properties of
2649 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2650 original value of -1 will not work with bidi.)
2651 (compute_display_string_pos): First arg is now struct
2652 `text_pos *'; all callers changed. Support display properties on
2653 Lisp strings.
2654 (compute_display_string_end): Support display properties on Lisp
2655 strings.
2656 (init_iterator, reseat_1, reseat_to_string): Initialize the
2657 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2658 when iterating on a string not from display properties).
640c8776
SM
2659 (compute_display_string_pos, compute_display_string_end):
2660 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2661 arrow keys.
2662 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2663 base_level_stop; instead, set base_level_stop to BEGV.
2664 Fixes crashes in vertical-motion.
0bb23927
EZ
2665 (next_element_from_buffer): Improve commentary for when
2666 the iterator is before prev_stop.
2667 (init_iterator): Initialize bidi_p from the default value of
2668 bidi-display-reordering, not from buffer-local value. Use the
2669 buffer-local value only if initializing for buffer iteration.
2670 (handle_invisible_prop): Support invisible properties on strings
2671 that are being bidi-reordered.
2672 (set_iterator_to_next): Support bidi reordering of C strings and
2673 Lisp strings.
2674 (next_element_from_string): Support bidi reordering of Lisp
2675 strings.
2676 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2677 (display_string): Support display of R2L glyph rows.
2678 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2679 (init_iterator): Don't initialize it->bidi_p for strings
2680 here.
2681 (reseat_to_string): Initialize it->bidi_p for strings here.
2682 (next_element_from_string, next_element_from_c_string)
2683 (next_element_from_buffer): Add xassert's for correspondence
2684 between IT's object being iterated and it->bidi_it.string
2685 structure.
2686 (face_before_or_after_it_pos): Support bidi iteration.
2687 (next_element_from_c_string): Handle the case of the first string
2688 character that is not the first one in the visual order.
2689 (get_visually_first_element): New function, refactored from common
2690 parts of next_element_from_buffer, next_element_from_string, and
2691 next_element_from_c_string.
2692 (tool_bar_lines_needed, redisplay_tool_bar)
2693 (display_menu_bar): Force left-to-right direction. Add a FIXME
2694 comment for making that be controlled by a user option.
2695 (push_it, pop_it): Save and restore the state of the
2696 bidi iterator. Save and restore the bidi_p flag.
2697 (pop_it): Iterate out of display property for string iteration as
2698 well.
2699 (iterate_out_of_display_property): Support iteration over strings.
2700 (handle_single_display_spec): Set up it->bidi_it for iteration
2701 over a display string, and call bidi_init_it.
2702 (handle_single_display_spec, next_overlay_string)
2703 (get_overlay_strings_1, push_display_prop): Set up the bidi
2704 iterator for displaying display or overlay strings.
2705 (forward_to_next_line_start): Don't use the shortcut if
2706 bidi-iterating.
2707 (back_to_previous_visible_line_start): If handle_display_prop
2708 pushed the iterator stack, restore the internal state of the bidi
2709 iterator by calling bidi_pop_it same number of times.
2710 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2711 and we are bidi-iterating, don't decrement the iterator position;
2712 instead, set the first_elt flag in the bidi iterator, to produce
2713 the same effect.
2714 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2715 (push_display_prop): xassert that we are iterating a buffer.
2716 (push_it, pop_it): Save and restore paragraph_embedding member.
2717 (handle_single_display_spec, next_overlay_string)
2718 (get_overlay_strings_1, reseat_1, reseat_to_string)
2719 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2720 correctly. Don't assume unibyte strings are not bidi-reordered.
2721 (compute_display_string_pos)
2722 (compute_display_string_end): Fix handling the case of C string.
2723 (push_it, pop_it): Save and restore from_disp_prop_p.
2724 (handle_single_display_spec, push_display_prop): Set the
2725 from_disp_prop_p flag.
2726 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2727 (pop_it): Call iterate_out_of_display_property only if we are
2728 popping after iteration over a string that came from a display
2729 property. Fix a typo in popping stretch info. Add an assertion
2730 for verifying that the iterator position is in sync with the bidi
2731 iterator.
2732 (handle_single_display_spec, get_overlay_strings_1)
2733 (push_display_prop): Fix initialization of paragraph direction for
2734 string when that of the parent object is not yet determined.
2735 (reseat_1): Call bidi_init_it to resync the bidi
2736 iterator with IT's position. (Bug#7616)
2737 (find_row_edges): If ROW->start.pos gives position
2738 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2739 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2740 Reset the from_disp_prop_p flag.
2741 (SAVE_IT, RESTORE_IT): New macros.
2742 (pos_visible_p, face_before_or_after_it_pos)
2743 (back_to_previous_visible_line_start)
2744 (move_it_in_display_line_to, move_it_in_display_line)
2745 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2746 (try_scrolling, redisplay_window, display_line): Use them when
2747 saving a temporary copy of the iterator and restoring it back.
2748 (back_to_previous_visible_line_start, reseat_1)
2749 (init_iterator): Empty the bidi cache "stack".
2750 (move_it_in_display_line_to): If iterator ended up at
2751 EOL, but we never saw any buffer positions smaller than
2752 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2753 motion in bidi-reordered lines.
2754 (move_it_in_display_line_to): Record prev_method and prev_pos
2755 immediately before the call to set_iterator_to_next. Fixes cursor
2756 motion in bidi-reordered lines with stretch glyphs and strings
2757 displayed in margins. (Bug#8133) (Bug#8867)
2758 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2759 TO_CHARPOS.
640c8776
SM
2760 (pos_visible_p): Support positions in bidi-reordered lines.
2761 Save and restore bidi cache.
0bb23927
EZ
2762
2763 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2764 (bidi_paragraph_info): Delete unused struct.
2765 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2766 (bidi_cache_start): New variable.
2767 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2768 to zero.
2769 (bidi_cache_fetch_state, bidi_cache_search)
2770 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2771 (bidi_cache_find, bidi_peek_at_next_level)
2772 (bidi_level_of_next_char, bidi_find_other_level_edge)
2773 (bidi_move_to_visually_next): Compare cache index with
2774 bidi_cache_start rather than with zero.
2775 (bidi_fetch_char): Accept new argument STRING; all callers
2776 changed. Support iteration over a string. Support strings with
2777 display properties. Support unibyte strings. Fix the type of
2778 `len' according to what STRING_CHAR_AND_LENGTH expects.
2779 (bidi_paragraph_init, bidi_resolve_explicit_1)
2780 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2781 (bidi_level_of_next_char, bidi_move_to_visually_next):
2782 Support iteration over a string.
0bb23927
EZ
2783 (bidi_set_sor_type, bidi_resolve_explicit_1)
2784 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2785 can now be zero (for strings); special values 0 and -1 were
2786 changed to -1 and -2, respectively.
2787 (bidi_char_at_pos): New function.
2788 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2789 Call it instead of FETCH_MULTIBYTE_CHAR.
2790 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2791 initialized to valid values.
2792 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2793 values.
2794 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2795 the test for valid cached positions. Fix the logic for looking up
2796 the sentinel state in the cache. GCPRO the Lisp string we are
2797 iterating.
2798 (bidi_push_it, bidi_pop_it): New functions.
2799 (bidi_initialize): Initialize the bidi cache start stack pointer.
2800 (bidi_cache_ensure_space): New function, refactored from part of
2801 bidi_cache_iterator_state. Don't assume the required size is just
2802 one BIDI_CACHE_CHUNK away.
2803 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2804 (bidi_count_bytes, bidi_char_at_pos): New functions.
2805 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2806 always valid if bidi_cache_idx is valid.
2807 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2808 is valid if it's going to be used.
2809 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2810 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2811 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2812 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2813 (bidi_find_other_level_edge, bidi_cache_start_stack):
2814 All variables related to cache indices are now EMACS_INT.
c965adc5 2815
0bb23927
EZ
2816 * dispextern.h (struct bidi_string_data): New structure.
2817 (struct bidi_it): New member `string'. Make flag members be 1-bit
2818 fields, and put them last in the struct.
640c8776
SM
2819 (compute_display_string_pos, compute_display_string_end):
2820 Update prototypes.
0bb23927
EZ
2821 (bidi_push_it, bidi_pop_it): Add prototypes.
2822 (struct iterator_stack_entry): New members bidi_p,
2823 paragraph_embedding, and from_disp_prop_p.
2824 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2825 (bidi_shelve_cache, bidi_unshelve_cache):
2826 Declare prototypes.
0bb23927
EZ
2827
2828 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2829 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2830 and vector-like objects.
2831
2832 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2833 cache around display iteration.
2834
2835 * window.c (Fwindow_end, window_scroll_pixel_based)
2836 (displayed_window_lines, Frecenter): Save and restore the bidi
2837 cache around display iteration.
2838
3bbd2265
LMI
28392011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2840
2841 * editfns.c (Fdelete_region): Clarify the use of the named
2842 parameters (bug#6788).
2843
adc47434
MR
28442011-07-14 Martin Rudalics <rudalics@gmx.at>
2845
2846 * indent.c (Fvertical_motion): Set and restore w->pointm when
2847 saving and restoring the window's buffer (Bug#9006).
2848
837c31f8
LMI
28492011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2850
2851 * editfns.c (Fstring_to_char): Clarify just what is returned
2852 (bug#6576). Text by Eli Zaretskii.
2853
ac389d0c
JB
28542011-07-13 Juanma Barranquero <lekktu@gmail.com>
2855
2856 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2857
0be0ce47
EZ
28582011-07-13 Eli Zaretskii <eliz@gnu.org>
2859
2860 * buffer.c (mmap_find): Fix a typo.
2861
cd18e7e3
JB
28622011-07-13 Johan Bockgård <bojohan@gnu.org>
2863
2864 Fix execution of x selection hooks.
2865 * xselect.c (Qx_lost_selection_functions)
2866 (Qx_sent_selection_functions): New vars.
2867 (syms_of_xselect): DEFSYM them.
2868 (x_handle_selection_request): Pass Qx_sent_selection_functions
2869 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2870 (x_handle_selection_clear,x_clear_frame_selections):
2871 Pass Qx_lost_selection_functions rather than
2872 Vx_lost_selection_functions to Frun_hook_with_args.
2873
47ea7f44
PE
28742011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2875
ac389d0c 2876 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2877 The old code sometimes used this field without initializing it.
2878
47ea7f44
PE
2879 * alloc.c (gc_sweep): Don't read past end of array.
2880 In theory, the old code could also have corrupted Emacs internals,
2881 though it'd be very unlikely.
2882
bc985c87
AS
28832011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2884
2885 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2886 argument. (Bug#4026)
bc985c87 2887
0cf34688
LMI
28882011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2889
b3dadd76
LMI
2890 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2891 key" (bug#4257).
2892
0cf34688
LMI
2893 * window.c (Fset_window_start): Doc fix (bug#4199).
2894 (Fset_window_hscroll): Ditto.
2895
270768cd
PE
28962011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2897
077e3dda 2898 Fix minor new problems caught by GCC 4.6.1.
270768cd 2899 * term.c (init_tty): Remove unused local.
490011a6 2900 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2901 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2902 not used otherwise.
270768cd 2903
b1f58454
CY
29042011-07-12 Chong Yidong <cyd@stupidchicken.com>
2905
2906 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2907
22b9578d
LMI
29082011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2909
6e70ab07
LMI
2910 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2911 are the mini-buffer and the echo area (bug#3320).
2912
22b9578d
LMI
2913 * term.c (init_tty): Remove support for supdup, c10 and perq
2914 terminals, which are no longer supported (bug#1482).
2915
8974cc9f
JB
29162011-07-10 Johan Bockgård <bojohan@gnu.org>
2917
2918 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2919
a560d974
JD
29202011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2921
2922 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2923 for non-popups (Bug#3642).
2924
1dae0f0a
AS
29252011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2926
268c2c36 2927 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2928 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2929 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2930 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2931 * data.c (fmod): Likewise.
2932 * dispnew.c (swap_glyphs_in_rows): Likewise.
2933 * emacs.c (memory_warning_signal): Likewise.
2934 * floatfns.c (float_error): Likewise.
2935 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2936 (otf_open, font_otf_capability, generate_otf_features)
2937 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2938 Likewise.
2939 * image.c (pbm_read_file): Likewise.
2940 * indent.c (string_display_width): Likewise.
2941 * intervals.c (check_for_interval, search_for_interval)
2942 (inc_interval_count, count_intervals, root_interval)
2943 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2944 * lread.c (defalias): Likewise.
268c2c36 2945 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2946 * regex.c (set_image_of_range_1, set_image_of_range)
2947 (regex_grow_registers): Likewise.
2948 * sysdep.c (strerror): Likewise.
2949 * termcap.c (valid_filename_p, tprint, main): Likewise.
2950 * tparam.c (main): Likewise.
2951 * unexhp9k800.c (run_time_remap, save_data_space)
2952 (update_file_ptrs, read_header, write_header, calculate_checksum)
2953 (copy_file, copy_rest, display_header): Likewise.
2954 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2955 Likewise.
2956 * xdisp.c (check_it): Likewise.
2957 * xfaces.c (register_color, unregister_color, unregister_colors):
2958 Likewise.
2959 * xfns.c (print_fontset_result): Likewise.
2960 * xrdb.c (member, fatal, main): Likewise.
2961
99033785
PE
29622011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2963
2964 Fix minor problems found by static checking (Bug#9031).
2965 * chartab.c (char_table_set_range, map_sub_char_table):
2966 Remove unused locals.
2967 (uniprop_table): Now static.
2968 * composite.c (_work_char): Remove unused static var.
2969
9cb2ac56
JB
29702011-07-09 Juanma Barranquero <lekktu@gmail.com>
2971
2972 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2973
f25661f0
JD
29742011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2975
2976 * gtkutil.c (qttip_cb): Remove code without function.
2977
8278c4fe
EZ
29782011-07-09 Eli Zaretskii <eliz@gnu.org>
2979
2980 * w32.c (pthread_sigmask): New stub.
2981
1692ae2d 29822011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2983
8a6ebd58 2984 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2985 sigprocmask is portable only for single-threaded applications, and
2986 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2987 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2988 (LIBES): Use it.
2989 * callproc.c (Fcall_process):
2990 * process.c (create_process):
2991 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2992 Use pthread_sigmask, not sigprocmask.
123403e4 2993
1b854618
JD
29942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2995
2996 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2997 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2998 wrong (Bug#8591).
2999
3fe4b549
JD
30002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3001
0ce7e563
JD
3002 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3003 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3004 (xg_hide_tooltip): Fix comment.
3005
3fe4b549
JD
3006 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3007 in registerServicesMenuSendTypes.
3008 (validRequestorForSendType): Don't check ns_return_types.
3009
3010 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3011 ns_return_type.
3012
5df75e47
JR
30132011-07-08 Jason Rumney <jasonr@gnu.org>
3014
22610910
JR
3015 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3016 SH_SHOW for hidden windows (Bug#5482).
3017
5df75e47
JR
3018 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3019 frame struct members of non-existent frames (Bug#6284).
3020
699c10bd
JD
30212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3022
4393663b
JD
3023 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3024 variable firstTime not needed on OSX >= 10.6.
3025 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3026 >= 10.5. Use setKnobProportion, setDoubleValue.
3027
3028 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3029 (MAC_OS_X_VERSION_10_5): Define if not defined.
3030 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3031 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3032 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3033
3034 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3035 cString and lossyCString on OSX >= 10.4
3036
3037 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3038 sizeToFit on OSX >= 10.2.
3039
3040 * nsimage.m (allocInitFromFile): Don't use deprecated method
3041 bestRepresentationForDevice on OSX >= 10.6.
3042
3043 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3044 to avoid warning.
3045
3046 * emacs.c: Declare unexec_init_emacs_zone.
3047
a63e0781
JD
3048 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3049
699c10bd
JD
3050 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3051
3052 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3053 on svcsMenu (Bug#8842).
3054
3055 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3056 ns_return_types.
3057 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3058
3059 * nsterm.m (QUTF8_STRING): Declare.
3060 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3061 (validRequestorForSendType): Return type is (id).
3062 Change indexOfObjectIdenticalTo to indexOfObject.
3063 Check if we have local selection before returning self (Bug#8842).
3064 (writeSelectionToPasteboard): Put local selection into paste board
3065 if we have a local selection (Bug#8842).
3066 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3067
3068 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3069 (ns_get_local_selection): Declare.
3070
54e10184
LMI
30712011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3072
9888ff71
LMI
3073 * keymap.c (describe_map_tree): Don't insert a double newline at
3074 the end of the buffer (bug#1169) and return whether we inserted
3075 something.
3076
54e10184
LMI
3077 * callint.c (Fcall_interactively): Change "reading args" to
3078 "providing args" to try to clarify what it does (bug#1010).
3079
15fa4783
KH
30802011-07-07 Kenichi Handa <handa@m17n.org>
3081
3082 * composite.c (composition_compute_stop_pos): Ignore a static
3083 composition starting before CHARPOS (Bug#8915).
3084
3085 * xdisp.c (handle_composition_prop): Likewise.
3086
a8815b00
EZ
30872011-07-07 Eli Zaretskii <eliz@gnu.org>
3088
3089 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3090 (Bug#9015)
3091
ef7b981d 30922011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3093
3094 * character.h (unicode_category_t): New enum type.
3095
3096 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3097 (Qchar_code_property_table): New variable.
3098 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3099 (UNIPROP_COMPRESSED_FORM_P): New macros.
3100 (char_table_ascii): Uncompress the compressed values.
3101 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3102 Uncompress the compressed values.
ac389d0c 3103 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3104 (char_table_ref_and_range): Uncompress the compressed values.
3105 (sub_char_table_set): New arg is_uniprop. Callers changed.
3106 Uncompress the compressed values.
3107 (sub_char_table_set_range): Args changed. Callers changed.
3108 (char_table_set_range): Adjuted for the above change.
3109 (map_sub_char_table): Delete args default_val and parent. Add arg
3110 top. Give decoded values to a Lisp function.
640c8776 3111 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3112 values to a Lisp function. Gcpro more variables.
3113 (uniprop_table_uncompress)
3114 (uniprop_decode_value_run_length): New functions.
3115 (uniprop_decoder, uniprop_decoder_count): New variables.
3116 (uniprop_get_decoder, uniprop_encode_value_character)
3117 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3118 New functions.
3119 (uniprop_encoder, uniprop_encoder_count): New variables.
3120 (uniprop_get_encoder, uniprop_table)
3121 (Funicode_property_table_internal, Fget_unicode_property_internal)
3122 (Fput_unicode_property_internal): New functions.
3123 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3124 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3125 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3126 char-code-property-alist.
3127
640c8776 3128 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3129 Vunicode_category_table.
3130
640c8776 3131 * font.c (font_range): Adjust for the change of
c805dec0
KH
3132 Vunicode_category_table.
3133
76b397fb
DN
31342011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3135
3136 * m/iris4d.h: Remove file, move contents ...
3137 * s/irix6-5.h: ... here.
3138
22b4128e
PE
31392011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3140
3141 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3142 * alloc.c (mark_buffer):
3143 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3144 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3145 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3146 This isn't true in general, and it's particularly not true
3147 if Emacs is configured with --with-wide-int.
3148 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3149 New macros, used in the buffer.c change.
3150
869795d6
JD
31512011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3152
3153 * xsettings.c: Use both GConf and GSettings if both are available.
3154 (store_config_changed_event): Add comment.
3155 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3156 (store_tool_bar_style_changed): New functions.
5e617bc2 3157 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3158 (struct xsettings): Move font inside HAVE_XFT.
3159 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3160 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3161 Move inside HAVE_XFT.
640c8776 3162 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3163 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3164 also.
3165 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3166 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3167 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3168 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3169 (parse_settings): Move check for font inside HAVE_XFT.
3170 (read_settings, apply_xft_settings): Add comment.
3171 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3172 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3173 call store_font_name_changed.
3174 (xft_settings_event): Add comment.
3175 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3176 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3177 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3178 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3179 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3180 (xsettings_get_system_font, xsettings_get_system_normal_font):
3181 Add comment.
869795d6 3182
d8ed26bd
PE
31832011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 Random fixes. E.g., (random) never returned negative values.
3186 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3187 subseconds part to the entropy, as that's a bit more random.
3188 Prefer signed to unsigned, since the signedness doesn't matter and
3189 in general we prefer signed. When given a limit, use a
3190 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3191 latter isn't right if USE_2_TAGS_FOR_INTS.
3192 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3193 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3194
cabf1cac
SM
31952011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3196
3197 * textprop.c (text_property_stickiness):
3198 Obey Vtext_property_default_nonsticky.
3199 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3200 * w32fns.c (syms_of_w32fns):
3201 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3202
6e9b2be9
PE
32032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3204
3205 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3206 This is more efficient than Ffile_directory_p and avoids a minor race.
3207
90186c68
LMI
32082011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3209
7c301272
LMI
3210 * buffer.c (Foverlay_put): Say what the return value is
3211 (bug#7835).
3212
c4f2d8d4
LMI
3213 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3214 is a directory before asking whether to use the file name
3215 (bug#7564).
ad637907
LMI
3216 (barf_or_query_if_file_exists): Make the "File is a directory"
3217 error be more correct.
c4f2d8d4 3218
90186c68
LMI
3219 * fns.c (Frequire): Remove the mention of the .gz files, since
3220 that's installation-specific, but keep the mention of
3221 `get-load-suffixes'.
3222
da64016e
PE
32232011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3224
3225 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3226 Report string overflow if the output is too long.
3227
7d47b580
JB
32282011-07-04 Juanma Barranquero <lekktu@gmail.com>
3229
a555cb87
JB
3230 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3231 (syms_of_gnutls): Remove duplicate DEFSYM for
3232 Qgnutls_bootprop_verify_hostname_error, an error for
3233 Qgnutls_bootprop_verify_error (which is no longer used).
3234
7d47b580
JB
3235 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3236 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3237 Also (re)move comments that are misplaced or no longer relevant.
3238
1e49bfab
LMI
32392011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3240
3241 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3242
1485f4c0
CY
32432011-07-03 Chong Yidong <cyd@stupidchicken.com>
3244
3245 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3246 and background color parameters if they have been changed.
3247
a9ab721e
LMI
32482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3249
3250 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3251
cf7cff57
PE
32522011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3253
2e13213d
PE
3254 * xsettings.c (SYSTEM_FONT): Define only when used.
3255 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3256
cf7cff57
PE
3257 * keymap.c (access_keymap_1): Now static.
3258
7a8e04f7
CY
32592011-07-02 Chong Yidong <cyd@stupidchicken.com>
3260
3261 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3262 leave any prefix arg for the up event (Bug#1586).
3263
61352f62
LMI
32642011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3265
69bb1ef7
LMI
3266 * lread.c (syms_of_lread): Mention single symbols defined by
3267 `defvar' or `defconst' (bug#7154).
3268
61352f62 3269 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3270 (Frequire): Mention get-load-suffixes.
61352f62 3271
28545e04
MR
32722011-07-02 Martin Rudalics <rudalics@gmx.at>
3273
3274 * window.h (window): Remove clone_number slot.
3275 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3276 Remove.
3277 (make_parent_window, make_window, saved_window)
3278 (Fset_window_configuration, save_window_save): Don't deal with
3279 clone numbers.
3280 * buffer.c (Qclone_number): Remove declaration.
3281 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3282
3349e122
SM
32832011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3284
3285 Add multiple inheritance to keymaps.
3286 * keymap.c (Fmake_composed_keymap): New function.
3287 (Fset_keymap_parent): Simplify.
3288 (fix_submap_inheritance): Remove.
3289 (access_keymap_1): New function extracted from access_keymap to handle
3290 embedded parents and handle lists of maps.
3291 (access_keymap): Use it.
3292 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3293 (Fcopy_keymap): Handle embedded parents.
3294 (Fcommand_remapping, define_as_prefix): Simplify.
3295 (Fkey_binding): Simplify.
3296 (syms_of_keymap): Move minibuffer-local-completion-map,
3297 minibuffer-local-filename-completion-map,
3298 minibuffer-local-must-match-map, and
3299 minibuffer-local-filename-must-match-map to Elisp.
3300 (syms_of_keymap): Defsubr make-composed-keymap.
3301 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3302 (parse_menu_item): Trivial simplification.
3303
3279eb87
GM
33042011-07-01 Glenn Morris <rgm@gnu.org>
3305
3306 * Makefile.in (SETTINGS_LIBS): Fix typo.
3307
4550efdf
KI
33082011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3309
3310 * coding.c (Fencode_coding_string): Record the last coding system
3311 used, as the function doc string says (bug#8738).
3312
0949d2b6
JD
33132011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3314
3315 * xsettings.c (store_monospaced_changed): Take new font as arg and
3316 check for change against current_mono_font.
3317 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3318 (emacs_settings_constructor, emacs_settings_get_property)
3319 (emacs_settings_set_property, emacs_settings_class_init)
3320 (emacs_settings_init, gsettings_obj): Remove.
3321 (something_changedCB): New function for HAVE_GSETTINGS.
3322 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3323 with value as argument.
3324 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3325 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3326 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3327 "changed".
3328
3329 * xgselect.c: Add defined (HAVE_GSETTINGS).
3330 (xgselect_initialize): Ditto.
3331
3332 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3333 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3334 xg_select.
3335
bbc6b304
PE
33362011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3337
3338 * eval.c (struct backtrace): Simplify and port the data structure.
3339 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3340 signed bit field, as this assumption is not portable and it makes
3341 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3342 "char debug_on_exit : 1" as this is not portable either; instead,
3343 use the portable "unsigned int debug_on_exit : 1". Remove unused
3344 member evalargs. Remove obsolete comments about cc bombing out.
3345
9851bfc5
JD
33462011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3347
51bb811f 3348 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3349 Let HAVE_GSETTINGS override HAVE_GCONF.
3350 (store_monospaced_changed): New function.
3351 (EMACS_SETTINGS): A new type derived from GObject to handle
3352 GSettings notifications.
3353 (emacs_settings_constructor, emacs_settings_get_property)
3354 (emacs_settings_set_property, emacs_settings_class_init):
3355 New functions.
3356 (gsettings_client, gsettings_obj): New variables.
3357 (GSETTINGS_SCHEMA): New define.
3358 (something_changedCB): Call store_monospaced_changed.
3359 (init_gsettings): New function.
3360 (xsettings_initialize): Call init_gsettings.
3361 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3362 to NULL.
3363
640c8776 3364 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3365 GCONF_CFLAGS/LIBS.
3366
5386012d
MR
33672011-06-29 Martin Rudalics <rudalics@gmx.at>
3368
3369 * window.c (resize_root_window, grow_mini_window)
3370 (shrink_mini_window): Rename Qresize_root_window to
3371 Qwindow_resize_root_window and Qresize_root_window_vertically to
3372 Qwindow_resize_root_window_vertically.
3373
f13e0b08
PE
33742011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3375
3376 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3377
94515237
JB
33782011-06-27 Juanma Barranquero <lekktu@gmail.com>
3379
3380 * makefile.w32-in: Redesign dependencies so they reflect more
3381 clearly which files are directly included by each source file,
3382 and not through other includes.
3383
e43b6e43
MR
33842011-06-27 Martin Rudalics <rudalics@gmx.at>
3385
3386 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3387 (sort_overlays, overlay_strings): When an overlay's clone number
3388 matches the window's clone number process the overlay even if
3389 the overlay's window property doesn't match the current window.
3390
d68443dc
MR
3391 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3392 (Fwindow_hchild): Rename to Fwindow_left_child.
3393 (Fwindow_next): Rename to Fwindow_next_sibling.
3394 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3395 (resize_window_check): Rename to window_resize_check.
3396 (resize_window_apply): Rename to window_resize_apply.
3397 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3398 (Fdelete_other_windows_internal, resize_frame_windows)
3399 (Fsplit_window_internal, Fdelete_window_internal)
3400 (grow_mini_window, shrink_mini_window)
3401 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3402
c7e73be5
JD
34032011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3404
3405 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3406 (emacs_fixed_set_min_size): Remove.
3407 (emacs_fixed_new): Take frame as argument.
3408
3409 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3410 (_EmacsFixedPrivate): Remove minwidth/height.
3411 Add struct frame *f.
3412 (emacs_fixed_init): Initialize priv->f.
3413 (get_parent_class, emacs_fixed_set_min_size): Remove.
3414 (emacs_fixed_new): Set priv->f to argument.
3415 (emacs_fixed_get_preferred_width)
3416 (emacs_fixed_get_preferred_height): Use min_width/height from
3417 frames size_hint to set minimum and natural (Bug#8919).
3418 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3419 and use min_width/height from frames size_hint to set
3420 min_width/height (Bug#8919).
3421
3422 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3423 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3424 Fix indentation.
c7e73be5 3425
cf99dcf8
EZ
34262011-06-26 Eli Zaretskii <eliz@gnu.org>
3427
3428 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3429 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3430 called at ZV.
3431
029529ac
CY
34322011-06-26 Chong Yidong <cyd@stupidchicken.com>
3433
3434 * process.c (wait_reading_process_output): Bypass select if
3435 waiting for a cell while ignoring keyboard input, and input is
3436 pending. Suggested by Jan Djärv (Bug#8869).
3437
7a7ef429
PE
34382011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3439
3440 Use gnulib's dup2 module instead of rolling our own.
3441 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3442
11fdef7d 34432011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3444
3445 * dispnew.c (scrolling_window): Before scrolling, turn off a
3446 mouse-highlight in the window being scrolled.
3447
cd3520a4
JB
34482011-06-24 Juanma Barranquero <lekktu@gmail.com>
3449
3450 Move DEFSYM to lisp.h and use everywhere.
3451
3452 * character.h (DEFSYM): Move declaration...
3453 * lisp.h (DEFSYM): ...here.
3454
3455 * gnutls.c:
3456 * minibuf.c:
3457 * w32menu.c:
3458 * w32proc.c:
3459 * w32select.c: Don't include character.h.
3460
3461 * alloc.c (syms_of_alloc):
3462 * buffer.c (syms_of_buffer):
3463 * bytecode.c (syms_of_bytecode):
3464 * callint.c (syms_of_callint):
3465 * casefiddle.c (syms_of_casefiddle):
3466 * casetab.c (init_casetab_once):
3467 * category.c (init_category_once, syms_of_category):
3468 * ccl.c (syms_of_ccl):
3469 * cmds.c (syms_of_cmds):
3470 * composite.c (syms_of_composite):
3471 * dbusbind.c (syms_of_dbusbind):
3472 * dired.c (syms_of_dired):
3473 * dispnew.c (syms_of_display):
3474 * doc.c (syms_of_doc):
3475 * editfns.c (syms_of_editfns):
3476 * emacs.c (syms_of_emacs):
3477 * eval.c (syms_of_eval):
3478 * fileio.c (syms_of_fileio):
3479 * fns.c (syms_of_fns):
3480 * frame.c (syms_of_frame):
3481 * fringe.c (syms_of_fringe):
3482 * insdel.c (syms_of_insdel):
3483 * keymap.c (syms_of_keymap):
3484 * lread.c (init_obarray, syms_of_lread):
3485 * macros.c (syms_of_macros):
3486 * msdos.c (syms_of_msdos):
3487 * print.c (syms_of_print):
3488 * process.c (syms_of_process):
3489 * search.c (syms_of_search):
3490 * sound.c (syms_of_sound):
3491 * syntax.c (init_syntax_once, syms_of_syntax):
3492 * terminal.c (syms_of_terminal):
3493 * textprop.c (syms_of_textprop):
3494 * undo.c (syms_of_undo):
3495 * w32.c (globals_of_w32):
3496 * window.c (syms_of_window):
3497 * xdisp.c (syms_of_xdisp):
3498 * xfaces.c (syms_of_xfaces):
3499 * xfns.c (syms_of_xfns):
3500 * xmenu.c (syms_of_xmenu):
3501 * xsettings.c (syms_of_xsettings):
3502 * xterm.c (syms_of_xterm): Use DEFSYM.
3503
4228cf16
TZ
35042011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3505
cd3520a4 3506 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3507
7fcccf1e
PE
35082011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3509
7efb4e0e
PE
3510 Integer and buffer overflow fixes (Bug#8873).
3511
ff5844ad
PE
3512 * print.c (printchar, strout): Check for string overflow.
3513 (PRINTPREPARE, printchar, strout):
3514 Don't set size unless allocation succeeds.
3515
90532f02
PE
3516 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3517 for sizes. Check for string overflow more accurately.
3518 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3519
6d84508d
PE
3520 * macros.c: Integer and buffer overflow fixes.
3521 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3522 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3523 Use ptrdiff_t, not int, for sizes.
3524 Don't increment bufsize until after realloc succeeds.
3525 Check for size-calculation overflow.
3526 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3527
437b2cb4
PE
3528 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3529
8b9ac8b4
PE
3530 * lread.c: Integer overflow fixes.
3531 (read_integer): Radix is now EMACS_INT, not int,
3532 to improve quality of diagnostics for out-of-range radices.
3533 Calculate buffer size correctly for out-of-range radices.
3534 (read1): Check for integer overflow in radices, and in
3535 read-circle numbers.
82cb60d3
PE
3536 (read_escape): Avoid int overflow.
3537 (Fload, openp, read_buffer_size, read1)
3538 (substitute_object_recurse, read_vector, read_list, map_obarray):
3539 Use ptrdiff_t, not int, for sizes.
3540 (read1): Use EMACS_INT, not int, for sizes.
20270765 3541 Check for size overflow.
8b9ac8b4 3542
7fcccf1e
PE
3543 * image.c (cache_image): Check for size arithmetic overflow.
3544
bfbbd7e7
PE
3545 * lread.c: Integer overflow issues.
3546 (saved_doc_string_size, saved_doc_string_length)
3547 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3548 Now ptrdiff_t, not int.
3549 (read1): Don't assume doc string length fits in int. Check for
3550 out-of-range doc string lengths.
3551 (read_list): Don't assume file position fits in int.
39019e54 3552 (read_escape): Check for hex character overflow.
bfbbd7e7 3553
4e323265
LL
35542011-06-22 Leo Liu <sdl.web@gmail.com>
3555
3556 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3557 Move to minibuffer.el.
3558
85fece3e
PE
35592011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3560
20b84ce9 3561 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3562 The following patches are for when GLYPH_DEBUG && !XASSERT.
3563 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3564 * dispnew.c (flush_stdout):
3565 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3566 Mark as externally visible.
3567 * dispnew.c (check_window_matrix_pointers): Now static.
3568 * dispnew.c (window_to_frame_vpos):
3569 * xfns.c (unwind_create_frame):
3570 * xterm.c (x_check_font): Remove unused local.
3571 * scroll.c (CHECK_BOUNDS):
3572 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3573 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3574 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3575 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3576 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3577 Now static.
3578 (debug_method_add): Use va_list and vsprintf rather than relying
3579 on undefined behavior with wrong number of arguments.
3580 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3581 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3582 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3583 since we're not interested in debugging glyphs with old libraries.
3584 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3585 GCC 4.6.0's static checking.
3586
0766b489
PE
35872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3588
31fd4b32
PE
3589 Integer overflow and signedness fixes (Bug#8873).
3590 A few related buffer overrun fixes, too.
3591
b79e8648
PE
3592 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3593
0766b489
PE
3594 * dispextern.h (struct face.stipple):
3595 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3596 (x_bitmap_mask, x_allocate_bitmap_record)
3597 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3598 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3599 (x_create_bitmap_from_xpm_data):
3600 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3601 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3602 (.bitmaps_last):
3603 * xfaces.c (load_pixmap):
3604 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3605 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3606 (.bitmaps_last, struct x_output.icon_bitmap):
3607 Use ptrdiff_t, not int, for bitmap indexes.
3608 (x_allocate_bitmap_record): Check for size overflow.
3609 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3610
b081724f
PE
3611 Use ptrdiff_t, not int, for overlay counts.
3612 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3613 * editfns.c (overlays_around, get_pos_property):
3614 * textprop.c (get_char_property_and_overlay):
3615 * xdisp.c (next_overlay_change, note_mouse_highlight):
3616 * xfaces.c (face_at_buffer_position):
21514da7
PE
3617 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3618 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3619 (Fnext_overlay_change, Fprevious_overlay_change)
3620 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3621 Use ptrdiff_t, not int, for sizes.
21514da7 3622 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3623
3de73e5e
PE
3624 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3625
2606c57b
PE
3626 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3627 (x_session_initialize): Do not assume string length fits in int.
3628
aaafe47a
PE
3629 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3630 This is unlikely, but can occur if DPI is outlandish.
3631
2674ddc8 3632 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3633 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3634
28154962
PE
3635 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3636 * xrdb.c (magic_file_p, search_magic_path):
3637 Omit last arg SUFFIX; it was always 0. All callers changed.
3638 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3639
7de51af5
PE
3640 * xfont.c (xfont_match): Avoid need for strlen.
3641
25ed6cc3
PE
3642 * xfns.c: Don't assume strlen fits in int.
3643 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3644
4eab31dd
PE
3645 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3646 not unsigned long, as we prefer signed integers. All callers changed.
3647 Detect integer overflow in repeat count.
3648 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3649 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3650
171e2a58
PE
3651 * termcap.c: Don't assume sizes fit in int and never overflow.
3652 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3653 (gobble_line): Check for size-calculation overflow.
3654
ad39faca 3655 * minibuf.c (Fread_buffer):
6e5bb2dc 3656 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3657 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3658 Don't assume string length fits in int.
3659
52c61c22 3660 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3661 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3662
b5b8c9e5
PE
3663 * font.c: Don't assume string length fits in int.
3664 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3665 Use ptrdiff_t, not int.
ccd6111c
PE
3666 (font_intern_prop): Don't assume string length fits in int.
3667 Don't assume integer property fits in fixnum.
3668 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3669
882f0d81 3670 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3671 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3672 Reformulate so as not to need the command string.
3673 Invoke gzip -cd rather than gunzip, as it's more portable.
3674 (lock_info_type, lock_file_1, lock_file):
3675 Don't assume pid_t and time_t fit in unsigned long.
3676 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3677 (current_lock_owner): Prefer signed type for sizes.
3678 Use memcpy, not strncpy, where memcpy is what is really wanted.
3679 Don't assume (via atoi) that time_t and pid_t fit in int.
3680 Check for time_t and/or pid_t out of range, e.g., via a network share.
3681 Don't alloca where an auto var works fine.
3682
93f4cf88
PE
3683 * fileio.c: Fix some integer overflow issues.
3684 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3685 Don't assume string length fits in int.
3686 (directory_file_name): Don't assume string length fits in long.
3687 (make_temp_name): Don't assume pid fits in int, or that its print
3688 length is less than 20.
3689
f3e92b69
PE
3690 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3691
1bfdaf10
PE
3692 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3693
35016e9a
PE
3694 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3695
3d1e65a1
PE
3696 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3697 We prefer signed integers, even for size calculations.
3698
0b963a93
PE
3699 * emacs.c: Don't assume string length fits in 'int'.
3700 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3701 (main): Don't invoke strlen when not needed.
3702
573f4b54
PE
3703 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3704 (XD_DEBUG_MESSAGE): Don't waste a byte.
3705
989f33ba
PE
3706 * callproc.c (getenv_internal_1, getenv_internal)
3707 (Fgetenv_internal):
965d34eb
PE
3708 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3709
e4d29b33
PE
3710 * lread.c (invalid_syntax): Omit length argument.
3711 All uses changed. This doesn't fix a bug, but it simplifies the
3712 code away from its former Hollerith-constant appearance, and it's
3713 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3714 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3715
eb49b136
PE
3716 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3717 This didn't break anything, but it didn't help either.
3718 It's confusing to put a bogus integer in a place where the actual
3719 value does not matter.
9f62aeb1 3720 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3721 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3722
15375a22
PE
3723 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3724 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3725 implementation.
b61cc01c
PE
3726 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3727 We prefer signed types, and the value cannot exceed the EMACS_INT
3728 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3729 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3730 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3731 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3732
53b2623d
PE
3733 * indent.c (sane_tab_width): New function.
3734 (current_column, scan_for_column, Findent_to, position_indentation)
3735 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3736 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3737
51cab52b 3738 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3739
f2ed8a70
PE
3740 * lisp.h (lint_assume): New macro.
3741 * composite.c (composition_gstring_put_cache):
3742 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3743
abe80cc6
PE
3744 * editfns.c, insdel.c:
3745 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3746
b02c740e
PE
3747 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3748
ebc96716
PE
3749 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3750
b4e50fa0 3751 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3752 Use much-faster test for byte-length change.
311d5d7c 3753 Don't assume string byte-length fits in 'int'.
a4cf38e4 3754 Check that character arg fits in 'int'.
85461888 3755 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3756
c0c1ee9f
PE
3757 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3758
a498d7f4
PE
3759 * fns.c (concat): Catch string overflow earlier.
3760 Do not rely on integer wraparound.
3761
51cab52b
PE
3762 * dispextern.h (struct it.overlay_strings_charpos)
3763 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3764 * xdisp.c (forward_to_next_line_start)
3765 (back_to_previous_visible_line_start)
3766 (reseat_at_next_visible_line_start, next_element_from_buffer):
3767 Don't arbitrarily truncate the value of 'selective' to int.
3768
76031fad
PE
3769 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3770
5eb55db9
PE
3771 * composite.c: Don't truncate sizes to 'int'.
3772 (composition_gstring_p, composition_reseat_it)
3773 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3774 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3775 not EMACS_UINT, for indexes.
5eb55db9 3776
0703a717
PE
3777 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3778
d6202519
PE
3779 * buffer.c: Include <verify.h>.
3780 (struct sortvec.priority, struct sortstr.priority):
8961a454 3781 Now EMACS_INT, not int.
c20998a7 3782 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3783 (struct sortstr.size, record_overlay_string)
3784 (struct sortstrlist.size, struct sortlist.used):
3785 Don't truncate size to int.
3786 (record_overlay_string): Check for size-calculation overflow.
d6202519 3787 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3788
d5a19415
JM
37892011-06-22 Jim Meyering <meyering@redhat.com>
3790
029529ac 3791 Don't leak an XBM-image-sized buffer
d5a19415
JM
3792 * image.c (xbm_load): Free the image buffer after using it.
3793
a9041e6c
PE
37942011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3795
3796 Port to Sun C.
3797 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3798 that Sun C diagnosed.
3799 * fns.c (secure_hash): Fix pointer signedness issue.
3800 * intervals.c (static_offset_intervals): New function.
3801 (offset_intervals): Use it.
3802
7f3f739f
LL
38032011-06-21 Leo Liu <sdl.web@gmail.com>
3804
3805 * deps.mk (fns.o):
3806 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3807 sha512.h.
3808
3809 * fns.c (secure_hash): Rename from crypto_hash_function and change
3810 the first arg to accept symbols.
5b66d427 3811 (Fsecure_hash): New primitive.
7f3f739f
LL
3812 (syms_of_fns): New symbols.
3813
76147d94
DD
38142011-06-20 Deniz Dogan <deniz@dogan.se>
3815
3816 * process.c (Fset_process_buffer): Clarify return value in
3817 docstring.
3818
7d7d0045
CY
38192011-06-18 Chong Yidong <cyd@stupidchicken.com>
3820
3821 * dispnew.c (add_window_display_history): Use BVAR.
3822
3823 * xdisp.c (debug_method_add): Use BVAR.
3824 (check_window_end, dump_glyph_matrix, dump_glyph)
3825 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3826
3827 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3828 Likewise.
3829
3830 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3831 check till after the cache is created in init_frame_faces.
3832
ff2bc410
SM
38332011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3834
3835 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3836
28177add
PE
38372011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3838
dd3482fe
PE
3839 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3840 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3841 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3842
393d71f3 3843 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3844 * fileio.c (Finsert_file_contents):
3845 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3846 Remove the old (too-loose) buffer overflow checks.
3847 They weren't needed, since make_gap checks for buffer overflow.
3848 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3849 The old code merely checked for Emacs fixnum overflow, and relied
3850 on undefined (wraparound) behavior. The new code avoids undefined
3851 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3852
2e6813b0 3853 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3854 Tune. Don't use wider integers than needed. Don't use alloca.
3855 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3856
599a9e4f
PE
3857 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3858
99561444
PE
3859 * insdel.c, lisp.h (buffer_overflow): New function.
3860 (insert_from_buffer_1, replace_range, replace_range_2):
3861 * insdel.c (make_gap_larger):
3862 * editfns.c (Finsert_char):
3863 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3864
28177add
PE
3865 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3866
e69dafad
PE
38672011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3868
a7af7fde 3869 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3870
b1c46f02
PE
3871 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3872 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3873
e69dafad
PE
3874 * fileio.c: Don't assume EMACS_INT fits in off_t.
3875 (emacs_lseek): New static function.
3876 (Finsert_file_contents, Fwrite_region): Use it.
3877 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3878
566684ea
PE
3879 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3880
e6966cd6
PE
3881 * fns.c: Don't overflow int when computing a list length.
3882 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3883 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3884 truncation on 64-bit hosts. Check for QUIT every
3885 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3886 faster and is responsive enough.
3887 (Flength): Report an error instead of overflowing an integer.
3888 (Fsafe_length): Return a float if the value is not representable
3889 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3890 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3891 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3892
dd0b0efb
PE
3893 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3894 (header_size, word_size): New constants.
3895 (allocate_vectorlike): Don't check size overflow here.
3896 (allocate_vector): Check it here instead, since this is the only
3897 caller of allocate_vectorlike that could cause overflow.
3898 Check that the new vector's length is representable as a fixnum.
3899
86fe5cfe
PE
3900 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3901 The previous code was bogus. For example, next_almost_prime (32)
3902 returned 39, which is undesirable as it is a multiple of 3; and
3903 next_almost_prime (24) returned 25, which is a multiple of 5 so
3904 why was the code bothering to check for multiples of 7?
3905
80e88859
PE
3906 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3907
4a2f0ad6
PE
3908 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3909
f66c7cf8
PE
3910 Variadic C functions now count arguments with ptrdiff_t.
3911 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3912 Back then I didn't know that the Emacs coding style prefers signed int.
3913 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3914 were being counted with int, which may truncate counts on 64-bit
3915 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3916 * lisp.h (struct Lisp_Subr.function.aMANY)
3917 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3918 Arg counts are now ptrdiff_t, not size_t.
3919 All variadic functions and their callers changed accordingly.
3920 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3921 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3922 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3923 * callint.c (Fcall_interactively): Check arg count for overflow,
3924 to avoid potential buffer overrun. Use signed char, not 'int',
3925 for 'varies' array, so that we needn't bother to check its size
3926 calculation for overflow.
3927 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3928 * eval.c (apply_lambda):
3929 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3930 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3931 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3932
a1759b76
PE
3933 * callint.c (Fcall_interactively): Don't use index var as event count.
3934
d96be9fc
PE
3935 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3936 * mem-limits.h (SIZE): Remove; no longer used.
3937
a690a978 3938 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3939
578c21e6
PE
3940 Remove unnecessary casts.
3941 * xterm.c (x_term_init):
3942 * xfns.c (x_set_border_pixel):
3943 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3944 These aren't needed now that we assume ANSI C.
3945
96f53c6c
PE
3946 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3947 It's more likely to cause problems (due to unsigned overflow)
3948 than to cure them.
3949
83c77d31
PE
3950 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3951
ee2079f1
PE
3952 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3953
6da65536
PE
3954 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3955
7147c4a4
PE
3956 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3957
193e32d9
PE
3958 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3959
e5533da6
PE
3960 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3961
9910e595
PE
3962 GLYPH_CODE_FACE returns EMACS_INT, not int.
3963 * dispextern.h (merge_faces):
3964 * xfaces.c (merge_faces):
01103c44
PE
3965 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3966 Don't assume EMACS_INT fits in int.
9910e595 3967
2638320e
PE
3968 * character.h (CHAR_VALID_P): Remove unused parameter.
3969 * fontset.c, lisp.h, xdisp.c: All uses changed.
3970
045eb8d9
PE
3971 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3972
c1f134b5
PE
3973 * fns.c (concat): Minor tuning based on overflow analysis.
3974 This doesn't fix any bugs. Use int to hold character, instead
3975 of constantly refetching from Emacs object. Use XFASTINT, not
3976 XINT, for value known to be a character. Don't bother comparing
3977 a single byte to 0400, as it's always less.
3978
395fcb93 3979 * floatfns.c (Fexpt):
327eeec8
PE
3980 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3981
abbd3d23
PE
3982 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3983 for characters.
3984
684a03ef
PE
3985 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3986
0fed43f3
PE
3987 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3988 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3989 incorrectly succeed when S was a string, because 4294967386 was
3990 truncated before it was used.
3991
8fd02eb7
PE
3992 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3993 Otherwise, an out-of-range integer could cause undefined behavior
3994 on a 64-bit host.
3995
f8c86b69
PE
3996 * composite.c: Use int, not EMACS_INT, for characters.
3997 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3998 EMACS_INT, for values that are known to be in character range.
3999 This doesn't fix any bugs but is the usual style inside Emacs and
4000 may generate better code on 32-bit machines.
4001
34206dd2
PE
4002 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4003 This is for reasons similar to the recent CHAR_STRING fix.
4004 * charset.c (Fencode_char): Check that character arg is actually
4005 a character. Pass an int to ENCODE_CHAR.
4006 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4007 wider than 'int', as a compile-time check to prevent future regressions
4008 in this area.
4009
c5958d4c 4010 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4011
4012 Make sure a 64-bit char is never passed to CHAR_STRING.
4013 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4014 by silently ignoring the top 32 bits, allowing some values
4015 that were far too large to be valid characters.
4016 * character.h: Include <verify.h>.
4017 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4018 arguments are no wider than unsigned, as a compile-time check
4019 to prevent future regressions in this area.
4020 * data.c (Faset):
01103c44 4021 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4022 (Fsubst_char_in_region):
4023 * fns.c (concat):
4024 * xdisp.c (decode_mode_spec_coding):
4025 Adjust to CHAR_STRING's new requirement.
4026 * editfns.c (Finsert_char, Fsubst_char_in_region):
4027 * fns.c (concat): Check that character args are actually
4028 characters. Without this test, these functions did the wrong
4029 thing with wildly out-of-range values on 64-bit hosts.
4030
d37ca623
PE
4031 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4032 These casts should not be needed on 32-bit hosts, either.
4033 * keyboard.c (read_char):
4034 * lread.c (Fload): Remove casts to unsigned.
4035
ea204efb
PE
4036 * lisp.h (UNSIGNED_CMP): New macro.
4037 This fixes comparison bugs on 64-bit hosts.
4038 (ASCII_CHAR_P): Use it.
4039 * casefiddle.c (casify_object):
01103c44 4040 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4041 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4042 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4043 * dispextern.h (FACE_FROM_ID):
4044 * keyboard.c (read_char): Use UNSIGNED_CMP.
4045
41cb286c
PE
4046 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4047 not to EMACS_INT, to avoid GCC warning.
4048
4a1b9832
PE
4049 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4050
55daad71
PE
4051 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4052 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4053 isn't needed on 32-bit machines.
8f95c75c 4054
01103c44
PE
4055 * buffer.c (Fgenerate_new_buffer_name):
4056 Use EMACS_INT for count, not int.
0ceccced 4057 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4058
4059 * data.c (Qcompiled_function): Now static.
4060
c6f072e7
PE
4061 * window.c (window_body_lines): Now static.
4062
20ce5912
PE
4063 * image.c (gif_load): Rename local to avoid shadowing.
4064
9c4c5f81
PE
4065 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4066 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4067 * alloc.c (make_save_value): Integer argument is now of type
4068 ptrdiff_t, not int.
4069 (mark_object): Use ptrdiff_t, not int.
4070 * lisp.h (pD): New macro.
4071 * print.c (print_object): Use it.
4072
c0c5c8ae
PE
4073 * alloc.c: Use EMACS_INT, not int, to count objects.
4074 (total_conses, total_markers, total_symbols, total_vector_size)
4075 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4076 (total_free_floats, total_floats, total_free_intervals)
4077 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4078 Now EMACS_INT, not int. All uses changed.
4079 (Fgarbage_collect): Compute overall total using a double, so that
4080 integer overflow is less likely to be a problem. Check for overflow
4081 when converting back to an integer.
5a25e253
PE
4082 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4083 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4084 These were 'int' variables that could overflow on 64-bit hosts;
4085 they were never used, so remove them instead of repairing them.
211a0b2a 4086 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4087 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4088 Previously, this ceilinged at INT_MAX, but that doesn't work on
4089 64-bit machines.
e46bb31a 4090 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4091
c78baabf 4092 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4093 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4094 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4095 when a (possibly-narrower) signed value would do just as well.
4096 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4097
c9d624c6
PE
4098 * alloc.c: Catch some string size overflows that we were missing.
4099 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4100 for convenience in STRING_BYTES_MAX.
4101 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4102 The definition here is exact; the one in lisp.h was approximate.
4103 (allocate_string_data): Check for string overflow. This catches
4104 some instances we weren't catching before. Also, it catches
4105 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4106 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4107 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4108
c9d624c6
PE
4109 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4110 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4111 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4112
353032ce
PE
4113 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4114
2bccce07
PE
4115 * alloc.c (Fmake_string): Check for out-of-range init.
4116
0ac30604
SM
41172011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4118
4119 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4120
c195f2de
JD
41212011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4122
4123 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4124 xg_get_default_scrollbar_width.
4125
4126 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4127 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4128 (style_changed_cb): Call update_theme_scrollbar_width and call
4129 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4130 all frames (Bug#8505).
4131 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4132 Call gtk_window_set_resizable if HAVE_GTK3.
4133 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4134 and height if HAVE_GTK3 (Bug#8505).
4135 (scroll_bar_width_for_theme): New variable.
4136 (update_theme_scrollbar_width): New function.
4137 (xg_get_default_scrollbar_width): Move code to
4138 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4139 (xg_initialize): Call update_theme_scrollbar_width.
4140
4141 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4142
4143 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4144
e10ac9f1
MR
41452011-06-12 Martin Rudalics <rudalics@gmx.at>
4146
4147 * frame.c (make_frame): Call other_buffer_safely instead of
4148 other_buffer.
4149
4150 * window.c (temp_output_buffer_show): Call display_buffer with
4151 second argument Vtemp_buffer_show_specifiers and reset latter
4152 immediately after the call.
4153 (Vtemp_buffer_show_specifiers): New variable.
4154 (auto_window_vscroll_p, next_screen_context_lines)
4155 (Vscroll_preserve_screen_position): Remove leading asterisks from
4156 doc-strings.
4157
2d3c217e 41582011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4159
7b7f97e8 4160 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4161 * buffer.c (Qclone_number): Remove for now, as it's unused.
4162 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4163 (record_buffer): Remove unused local.
4164 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4165 (set_frame_buffer_list): Remove; unused.
4166 * frame.h (other_visible_frames): Remove decl.
4167 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4168 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4169 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4170 if HAVE_GPM.
4171 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4172 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4173 Define only if HAVE_GPM.
4174 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4175 (update_hints_inhibit): Remove; never set. All uses removed.
4176 * widgetprv.h (emacsFrameClassRec): Remove decl.
4177 * window.c (delete_deletable_window): Now returns void, since it
4178 wasn't returning anything.
4179 (compare_window_configurations): Remove unused locals.
4180 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4181 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4182 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4183 the same widths as pointers. This follows up on the 2011-05-06 patch.
4184 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4185 * xterm.h: Likewise.
4186 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4187
1384b89e
JB
41882011-06-12 Juanma Barranquero <lekktu@gmail.com>
4189
4190 * makefile.w32-in: Update dependencies.
4191 (LISP_H): Add lib/intprops.h.
4192
1100a63c
CY
41932011-06-11 Chong Yidong <cyd@stupidchicken.com>
4194
4195 * image.c (gif_load): Add animation frame delay to the metadata.
4196 (syms_of_image): Use DEFSYM. New symbol `delay'.
4197
6198ccd0
MR
41982011-06-11 Martin Rudalics <rudalics@gmx.at>
4199
4200 * window.c (delete_deletable_window): Re-add.
4201 (Fset_window_configuration): Rewrite to handle dead buffers and
4202 consequently deletable windows.
4203 (window_tree, Fwindow_tree): Remove. Supply functionality in
4204 window.el.
4205 (compare_window_configurations): Simplify code.
4206
b6e3633c
AS
42072011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4208
1ab0dee5
AS
4209 * image.c (imagemagick_load_image): Fix type mismatch.
4210 (Fimagemagick_types): Likewise.
4211
b6e3633c
AS
4212 * window.h (replace_buffer_in_windows): Declare.
4213
9397e56f
MR
42142011-06-11 Martin Rudalics <rudalics@gmx.at>
4215
4216 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4217 Qclone_number. Remove external declaration of Qdelete_window.
4218 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4219 code.
640c8776
SM
4220 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4221 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4222 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4223 buffer list implementation.
4224 (other_buffer_safely): New function.
4225 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4226 calls to replace_buffer_in_windows and
4227 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4228 if allowed.
4229 (record_buffer): Inhibit quitting and rewrite using quittable
4230 functions. Run Qbuffer_list_update_hook if allowed.
4231 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4232 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4233 Move switch-to-buffer to window.el.
9397e56f
MR
4234 (bury-buffer): Move to window.el.
4235 (Vbuffer_list_update_hook): New variable.
4236
4237 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4238 section.
4239
4240 * window.h (resize_frame_windows): Move up in code.
4241 (Fwindow_frame): Remove EXFUN.
4242 (replace_buffer_in_all_windows): Remove prototype.
4243 (replace_buffer_in_windows_safely): Add prototype.
4244
4245 * window.c: Declare Qdelete_window static again. Move down
4246 declaration of select_count.
4247 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4248 (Fother_window): Move to window.el.
4249 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4250 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4251 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4252 window.el.
4253 (replace_buffer_in_windows): Implement by calling
4254 Qreplace_buffer_in_windows.
4255 (replace_buffer_in_all_windows): Remove with some functionality
4256 moved into replace_buffer_in_windows_safely.
4257 (replace_buffer_in_windows_safely): New function.
4258 (select_window_norecord, select_frame_norecord): Move in front
4259 of run_window_configuration_change_hook. Remove now obsolete
4260 declarations.
640c8776
SM
4261 (Fset_window_buffer): Rewrite doc-string.
4262 Call Qrecord_window_buffer.
9397e56f
MR
4263 (keys_of_window): Move binding for other-window to window.el.
4264
b50691aa
CY
42652011-06-11 Chong Yidong <cyd@stupidchicken.com>
4266
4267 * dispextern.h (struct image): Replace data member, whose int_val
4268 and ptr_val fields were not used by anything, with a single
4269 lisp_val object.
4270
4271 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4272 (gif_clear_image, gif_load, imagemagick_load_image)
4273 (gs_clear_image, gs_load): Callers changed.
4274
3f754b86
PE
42752011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4276
cca69397
PE
4277 * buffer.h: Include <time.h>, for time_t.
4278 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4279
109e28d0
PE
4280 Fix minor problems found by static checking.
4281
60737f02
PE
4282 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4283
4b66faf3
PE
4284 Make identifiers static if they are not used in other modules.
4285 * data.c (Qcompiled_function, Qframe, Qvector):
4286 * image.c (QimageMagick, Qsvg):
4287 * minibuf.c (Qmetadata):
4288 * window.c (resize_window_check, resize_root_window): Now static.
4289 * window.h (resize_window_check, resize_root_window): Remove decls.
4290
109e28d0
PE
4291 * window.c (window_deletion_count, delete_deletable_window):
4292 Remove; unused.
46a4ce9e
PE
4293 (window_body_lines): Now static.
4294 (Fdelete_other_windows_internal): Mark vars as initialized.
4295 Make sure 'resize_failed' is initialized.
4296 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4297 (resize_window_apply): Remove unused local.
4298 * window.h (delete_deletable_window): Remove decl.
4299
109e28d0 4300 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4301 (imagemagick_load_image): Fix pointer signedness problem by changing
4302 last arg from unsigned char * to char *. All uses changed.
4303 Also, fix a local for similar reasons.
4304 Remove unused locals. Remove locals to avoid shadowing.
4305 (fn_rsvg_handle_free): Remove; unused.
4306 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4307 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4308
3f754b86
PE
4309 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4310
2547adb1
CY
43112011-06-10 Chong Yidong <cyd@stupidchicken.com>
4312
4313 * image.c (gif_load): Fix omitted cast error introduced by
4314 2011-06-06 change.
4315
2c8e37d4
MR
43162011-06-10 Martin Rudalics <rudalics@gmx.at>
4317
4318 * window.h (resize_proportionally, orig_total_lines)
4319 (orig_top_line): Remove from window structure.
4320 (set_window_height, set_window_width, change_window_heights)
4321 (Fdelete_window): Remove prototypes.
4322 (resize_frame_windows): Remove duplicate declaration.
4323
440a42e3
EZ
43242011-06-10 Eli Zaretskii <eliz@gnu.org>
4325
4326 * window.h (resize_frame_windows, resize_window_check)
4327 (delete_deletable_window, resize_root_window)
4328 (resize_frame_windows): Declare prototypes.
4329
4330 * window.c (resize_window_apply): Make definition be "static" to
4331 match the prototype.
4332
562dd5e9
MR
43332011-06-10 Martin Rudalics <rudalics@gmx.at>
4334
4335 * window.c: Remove declarations of Qwindow_size_fixed,
4336 window_min_size_1, window_min_size_2, window_min_size,
4337 size_window, window_fixed_size_p, enlarge_window, delete_window.
4338 Remove static from declaration of Qdelete_window, it's
4339 temporarily needed by Fbury_buffer.
4340 (replace_window): Don't assign orig_top_line and
4341 orig_total_lines.
4342 (Fdelete_window, delete_window): Remove. Window deletion is
4343 handled by window.el.
640c8776
SM
4344 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4345 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4346 (Fdelete_other_windows): Remove. Deleting other windows is
4347 handled by window.el.
4348 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4349 handled in window.el.
4350 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4351 Window minimum sizes are handled in window.el.
4352 (shrink_windows, size_window, set_window_height)
4353 (set_window_width, change_window_heights, window_height)
4354 (window_width, CURBEG, CURSIZE, enlarge_window)
4355 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4356 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4357 handled in window.el.
4358 (make_dummy_parent): Rename to make_parent_window and give it a
4359 second argument horflag.
4360 (make_window): Don't set resize_proportionally any more.
4361 (Fsplit_window): Remove. Windows are split in window.el.
4362 (save_restore_action, save_restore_orig_size)
4363 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4364 Resize mini windows in window.el.
4365 (grow_mini_window, shrink_mini_window): Implement by calling
4366 Qresize_root_window_vertically, resize_window_check and
4367 resize_window_apply.
640c8776
SM
4368 (saved_window, Fset_window_configuration, save_window_save):
4369 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4370 resize_proportionally.
4371 (window_min_height, window_min_width): Move to window.el.
4372 (keys_of_window): Move bindings for delete-other-windows,
4373 split-window, delete-window and enlarge-window to window.el.
4374
4375 * buffer.c: Temporarily extern Qdelete_window.
4376 (Fbury_buffer): Temporarily call Qdelete_window instead of
4377 Fdelete_window (Fbury_buffer will move to window.el soon).
4378
4379 * frame.c (set_menu_bar_lines_1): Remove code handling
4380 orig_top_line and orig_total_lines.
4381
4382 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4383 set_window_height but set heights directly.
4384 (change_frame_size_1): Use resize_frame_windows.
4385
4386 * xdisp.c (init_xdisp): Don't use set_window_height but set
4387 heights directly.
4388
640c8776
SM
4389 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4390 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4391 run_window_configuration_change_hook.
4392
4393 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4394 instead of change_window_heights and run
4395 run_window_configuration_change_hook.
4396
1a13852e
MR
43972011-06-09 Martin Rudalics <rudalics@gmx.at>
4398
4399 * window.c (replace_window): Rename second argument REPLACEMENT to
4400 NEW. New third argument SETFLAG. Rewrite.
4401 (delete_window, make_dummy_parent): Call replace_window with
4402 third argument 1.
4403 (window_list_1): Move down in code.
4404 (run_window_configuration_change_hook): Move set_buffer part
4405 before select_frame_norecord part in order to unwind correctly.
4406 Rename count1 to count.
4407 (recombine_windows, delete_deletable_window, resize_root_window)
4408 (Fdelete_other_windows_internal)
4409 (Frun_window_configuration_change_hook, make_parent_window)
4410 (resize_window_check, resize_window_apply, Fresize_window_apply)
4411 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4412 (Fdelete_window_internal, Fresize_mini_window_internal):
4413 New functions.
1a13852e
MR
4414 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4415
f3d1777e
MR
44162011-06-08 Martin Rudalics <rudalics@gmx.at>
4417
496e208e
MR
4418 * window.h (window): Add some new members to window structure -
4419 normal_lines, normal_cols, new_total, new_normal, clone_number,
4420 splits, nest, prev_buffers, next_buffers.
4421 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4422 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4423
f3d1777e
MR
4424 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4425 Remove.
496e208e
MR
4426 (make_dummy_parent): Set new members of windows structure.
4427 (make_window): Move down in code. Handle new members of window
4428 structure.
4429 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4430 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4431 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4432 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4433 (Fset_window_next_buffers, Fset_window_clone_number):
4434 New functions.
496e208e
MR
4435 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4436 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4437 Doc-string fixes.
4438 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4439 Argument WINDOW can be now internal window too.
4440 (Fwindow_use_time): Move up in code.
4441 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4442 Rewrite doc-string.
4443 (Fset_window_configuration, saved_window)
4444 (Fcurrent_window_configuration, save_window_save): Handle new
4445 members of window structure.
b9e809c2
MR
4446 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4447 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4448 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4449 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4450 Qget_mru_window, Qresize_root_window,
4451 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4452 Qauto_buffer_name; staticpro them.
f3d1777e 4453
abde8f8c
MR
44542011-06-07 Martin Rudalics <rudalics@gmx.at>
4455
4456 * window.c (Fwindow_total_size, Fwindow_left_column)
4457 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4458 (Fwindow_list_1): New functions.
4459 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4460 (Fwindow_width, Fscroll_left, Fscroll_right):
4461 Use window_body_cols instead of window_box_text_cols.
4462 (delete_window, Fset_window_configuration):
4463 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4464 (delete_all_subwindows): Take a window as argument and not a
4465 structure. Rewrite.
190b47e6
MR
4466 (window_loop): Remove handling of GET_LRU_WINDOW and
4467 GET_LARGEST_WINDOW.
4468 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4469
4470 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4471 window_box_text_cols. delete_all_subwindows now takes a
4472 Lisp_Object as argument.
abde8f8c 4473
640c8776
SM
4474 * indent.c (compute_motion, Fcompute_motion):
4475 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4476
fa8a67e6
MR
4477 * frame.c (delete_frame): Call delete_all_subwindows with root
4478 window as argument.
4479
a54e3482
DC
44802011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4481
4482 * fns.c (Fputhash): Document return value.
4483
60002bf5
CY
44842011-06-06 Chong Yidong <cyd@stupidchicken.com>
4485
4486 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4487
0c671da6 44882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4489
b862a52a 4490 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4491
be44ca6c
PE
4492 Check for overflow when converting integer to cons and back.
4493 * charset.c (Fdefine_charset_internal, Fdecode_char):
4494 Use cons_to_unsigned to catch overflow.
4495 (Fencode_char): Use INTEGER_TO_CONS.
4496 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4497 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4498 * data.c (long_to_cons, cons_to_long): Remove.
4499 (cons_to_unsigned, cons_to_signed): New functions.
4500 These signal an error for invalid or out-of-range values.
4501 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4502 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4503 * font.c (Ffont_variation_glyphs):
4504 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4505 * lisp.h: Include <intprops.h>.
4506 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4507 (cons_to_signed, cons_to_unsigned): New decls.
4508 (long_to_cons, cons_to_long): Remove decls.
4509 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4510 (Fprimitive_undo): Use CONS_TO_INTEGER.
4511 * xfns.c (Fx_window_property): Likewise.
4512 * xselect.c: Include <limits.h>.
4513 (x_own_selection, selection_data_to_lisp_data):
4514 Use INTEGER_TO_CONS.
4515 (x_handle_selection_request, x_handle_selection_clear)
4516 (x_get_foreign_selection, Fx_disown_selection_internal)
4517 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4518 (lisp_data_to_selection_data): Use cons_to_unsigned.
4519 (x_fill_property_data): Use cons_to_signed.
4520 Report values out of range.
4521
d1f3d2af
PE
4522 Check for buffer and string overflow more precisely.
4523 * buffer.h (BUF_BYTES_MAX): New macro.
4524 * lisp.h (STRING_BYTES_MAX): New macro.
4525 * alloc.c (Fmake_string):
4526 * character.c (string_escape_byte8):
4527 * coding.c (coding_alloc_by_realloc):
4528 * doprnt.c (doprnt):
4529 * editfns.c (Fformat):
4530 * eval.c (verror):
4531 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4532 since they may not be the same number.
4533 * editfns.c (Finsert_char):
4534 * fileio.c (Finsert_file_contents):
4535 Likewise for BUF_BYTES_MAX.
4536
dd52fcea
PE
4537 * image.c: Use ptrdiff_t, not int, for sizes.
4538 (slurp_file): Switch from int to ptrdiff_t.
4539 All uses changed.
4540 (slurp_file): Check that file size fits in both size_t (for
4541 malloc) and ptrdiff_t (for sanity and safety).
4542
7f9bbdbb
PE
4543 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4544 if b->modtime has its maximal value.
4545
dfe18f82
PE
4546 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4547
84acfcf0
PE
4548 Don't assume time_t can fit into int.
4549 * buffer.h (struct buffer.modtime): Now time_t, not int.
4550 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4551 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4552
ccd9a01a
PE
4553 Minor fixes for signed vs unsigned integers.
4554 * character.h (MAYBE_UNIFY_CHAR):
4555 * charset.c (maybe_unify_char):
4556 * keyboard.c (read_char, reorder_modifiers):
4557 XINT -> XFASTINT, since the integer must be nonnegative.
4558 * ftfont.c (ftfont_spec_pattern):
4559 * keymap.c (access_keymap, silly_event_symbol_error):
4560 XUINT -> XFASTINT, since the integer must be nonnegative.
4561 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4562 since it makes no difference and we prefer signed.
4563 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4564 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4565 nonnegative.
4566
d6d100dd
SM
45672011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4568
4569 * window.h (Fwindow_frame): Declare.
4570
2b6148e4
PE
45712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4572
4573 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4574 (SPARE_MEMORY): Always define.
4575 (LARGE_REQUEST): Remove.
4576 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4577
f230ecc9
MR
45782011-06-06 Martin Rudalics <rudalics@gmx.at>
4579
727e958e
MR
4580 * lisp.h: Move EXFUNS for Fframe_root_window,
4581 Fframe_first_window and Fset_frame_selected_window to window.h.
4582
4583 * window.h: Move EXFUNS for Fframe_root_window,
4584 Fframe_first_window and Fset_frame_selected_window here from
4585 lisp.h.
4586
4587 * frame.c (Fwindow_frame, Fframe_first_window)
4588 (Fframe_root_window, Fframe_selected_window)
4589 (Fset_frame_selected_window): Move to window.c.
4590 (Factive_minibuffer_window): Move to minibuf.c.
4591 (Fother_visible_frames_p): New function.
4592
4593 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4594
f230ecc9
MR
4595 * window.c (decode_window, decode_any_window): Move up in code.
4596 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4597 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4598 (Fwindow_buffer): Move up and rewrite doc-string.
4599 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4600 (Fwindow_prev): New functions.
727e958e
MR
4601 (Fwindow_frame): Move here from frame.c. Accept any window as
4602 argument.
4603 (Fframe_root_window, Fframe_first_window)
4604 (Fframe_selected_window): Move here from frame.c. Accept frame
4605 or arbitrary window as argument. Update doc-strings.
4606 (Fminibuffer_window): Move up in code.
4607 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4608 (Fset_frame_selected_window): Move here from frame.c.
4609 Marginal rewrite.
727e958e
MR
4610 (Fselected_window, select_window, Fselect_window): Move up in
4611 code. Minor doc-string fixes.
f230ecc9 4612
4d09bcf6
PE
46132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4614
4615 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4616 Do not assume that spare memory exists; that assumption is valid
4617 only if SYSTEM_MALLOC.
4618 (LARGE_REQUEST): New macro, so that the issue of large requests
4619 is separated from the issue of spare memory.
4620
810928a2
AS
46212011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4622
172418ad
AS
4623 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4624 format. (Bug#8806)
4625
43f862f7
AS
4626 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4627
810928a2
AS
4628 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4629 before statements.
4630
a059fe24
JD
46312011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4632
4633 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4634
4635 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4636
4637 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4638 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4639
989bf368
JB
46402011-06-05 Juanma Barranquero <lekktu@gmail.com>
4641
4642 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4643
4b80f674
CY
46442011-06-04 Chong Yidong <cyd@stupidchicken.com>
4645
4646 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4647 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4648 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4649 New error handlers.
4b80f674
CY
4650 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4651 Obey Vx_select_enable_clipboard_manager. Catch errors in
4652 x_clipboard_manager_save (Bug#8779).
4653 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4654 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4655
99a33b77 46562011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4657
4658 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4659
99a33b77 46602011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4661
4662 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4663 in the current matrix if keep_current_p is non-zero.
4664
8264569d
EZ
46652011-06-04 Eli Zaretskii <eliz@gnu.org>
4666
4667 * bidi.c (bidi_level_of_next_char): Fix last change.
4668
57f97249
EZ
46692011-06-03 Eli Zaretskii <eliz@gnu.org>
4670
fec2107c 4671 Support bidi reordering of text covered by display properties.
57f97249 4672
fec2107c
EZ
4673 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4674 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4675 (bidi_cache_search, bidi_cache_iterator_state)
4676 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4677 (bidi_level_of_next_char, bidi_move_to_visually_next):
4678 Support character positions inside a run of characters covered by a
fec2107c
EZ
4679 display string.
4680 (bidi_paragraph_init, bidi_resolve_explicit_1)
4681 (bidi_level_of_next_char): Call bidi_fetch_char and
4682 bidi_fetch_char_advance instead of FETCH_CHAR and
4683 FETCH_CHAR_ADVANCE.
4684 (bidi_init_it): Initialize new members.
4685 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4686 definitions.
4687 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4688 instead of using explicit *_CHAR codes.
d6d100dd
SM
4689 (bidi_resolve_explicit, bidi_resolve_weak):
4690 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4691 bidirectional text is supported only in multibyte buffers.
4692 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4693 it to initialize the frame_window_p member of struct bidi_it.
4694 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4695 (bidi_resolve_explicit, bidi_resolve_weak)
4696 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4697 bidi_it->nchars is non-positive.
4698 (bidi_level_of_next_char): Don't try to lookup the cache for the
4699 next/previous character if nothing is cached there yet, or if we
4700 were just reseat()'ed to a new position.
c40e2fb2 4701
0e14fe90
EZ
4702 * xdisp.c (set_cursor_from_row): Set start and stop points
4703 according to the row's direction when priming the loop that looks
4704 for the glyph on which to display cursor.
4705 (single_display_spec_intangible_p): Function deleted.
4706 (display_prop_intangible_p): Reimplement to call
4707 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4708 Accept 3 additional arguments needed by handle_display_spec.
4709 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4710 values: lists, `(when COND...)' forms, etc.
4711 (single_display_spec_string_p): Support property values that are
4712 lists with the argument STRING its top-level element.
4713 (display_prop_string_p): Fix the condition for processing a
4714 property that is a list to be consistent with handle_display_spec.
fec2107c 4715 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4716 last portion of handle_display_prop.
4717 (compute_display_string_pos): Accept additional argument
4718 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4719 value of a `display' property is a "replacing spec".
4720 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4721 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4722 the display property, but just return a value indicating whether
4723 the display property will replace the characters it covers.
4724 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4725 frame_window_p members of struct bidi_it.
d6d100dd
SM
4726 (compute_display_string_pos, compute_display_string_end):
4727 New functions.
fec2107c
EZ
4728 (push_it): Accept second argument POSITION, where pop_it should
4729 jump to continue iteration.
4730 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4731
fec2107c
EZ
4732 * keyboard.c (adjust_point_for_property): Adjust the call to
4733 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4734
4735 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4736 (bidi_init_it): Update prototypes.
4737 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4738 (compute_display_string_pos, compute_display_string_end):
4739 Declare prototypes.
fec2107c
EZ
4740 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4741 EMACS_INT.
fc6f18ce 4742
40087514 47432011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4744
57f53182
PE
4745 Malloc failure behavior now depends on size of allocation.
4746 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4747 * lisp.h: Change signatures accordingly.
4748 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4749 All callers changed. (Bug#8762)
4750
4751 * gnutls.c: Use Emacs's memory allocators.
4752 Without this change, the gnutls library would invoke malloc etc.
4753 directly, which causes problems on non-SYNC_INPUT hosts, and which
4754 runs afoul of improving memory_full behavior. (Bug#8761)
4755 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4756 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4757 xfree instead of the default malloc, realloc, free.
4758 (Fgnutls_boot): No need to check for memory allocation failure,
4759 since xmalloc does that for us.
4760
ac32cd99 4761 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4762 * category.c (hash_get_category_set):
4763 * ccl.c (ccl_driver):
4764 * charset.c (Fdefine_charset_internal):
4765 * charset.h (struct charset.hash_index):
4766 * composite.c (get_composition_id, gstring_lookup_cache)
4767 (composition_gstring_put_cache):
4768 * composite.h (struct composition.hash_index):
4769 * dispextern.h (struct image.hash):
4770 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4771 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4772 (hashfn_equal, hashfn_user_defined, make_hash_table)
4773 (maybe_resize_hash_table, hash_lookup, hash_put)
4774 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4775 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4776 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4777 * image.c (make_image, search_image_cache, lookup_image)
4778 (xpm_put_color_table_h):
4779 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4780 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4781 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4782 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4783 * alloc.c (allocate_vectorlike):
4784 Check for overflow in vector size calculations.
4785 * ccl.c (ccl_driver):
4786 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4787 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4788 need to be updated by these changes.
40087514
PE
4789 * fns.c (make_hash_table, maybe_resize_hash_table):
4790 Check for integer overflow with large hash tables.
0de4bb68
PE
4791 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4792 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4793 (SXHASH_REDUCE): New macro.
4794 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4795 Use it instead of discarding useful hash info with large hash values.
4796 (sxhash_float): New function.
4797 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4798 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4799 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4800 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4801 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4802 Adjust signatures to match updated version of code.
4803 (consing_since_gc): Now EMACS_INT, since a single hash table can
4804 use more than INT_MAX bytes.
4805
698d32e2
DN
48062011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4807
4808 Make it possible to build with GCC-4.6+ -O2 -flto.
4809
4810 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4811
fd6fa53f
SM
48122011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4813
4814 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4815 Call minibuffer-inactive-mode.
4816
864db017
JB
48172011-05-31 Juanma Barranquero <lekktu@gmail.com>
4818
4819 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4820 Update dependencies.
4821
2ad0baf4
DN
48222011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4823
4824 * data.c (init_data): Remove code for UTS, this system is not
4825 supported anymore.
4826
4fcc2638
DN
48272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4828
4829 Don't force ./temacs to start in terminal mode.
4830
4831 * frame.c (make_initial_frame): Initialize faces in all cases, not
4832 only when CANNOT_DUMP is defined.
4833 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4834
c56e0fd5
DN
48352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4836
4837 * dispnew.c (add_window_display_history): Use const for the string
4838 pointer. Remove declaration, not needed.
4839
333d54da 48402011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4841
55d4c1b2 4842 Use 'inline', not 'INLINE'.
333d54da 4843 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4844 * alloc.c, fontset.c (INLINE): Remove.
4845 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4846 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4847 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4848 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4849 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4850
738db178
DN
48512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4852
4853 Make it possible to run ./temacs.
4854
4855 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4856 syms_of_callproc does the same thing. Remove test for
4857 "initialized", do it in the caller.
4858 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4859
620c53a6
SM
48602011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4861
4862 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4863 (read_minibuf): Use get_minibuffer.
4864 (syms_of_minibuf): Use DEFSYM.
4865 (Qmetadata): New var.
4866 * data.c (Qbuffer): Don't make it static.
4867 (syms_of_data): Use DEFSYM.
4868
e003a292
PE
48692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4870
4871 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4872 (CCL_CODE_MIN): New macro.
4873
ed008a6d
PE
48742011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4875
3687c2ef
PE
4876 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4877
ed008a6d
PE
4878 * eval.c (Qdebug): Now static.
4879 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4880 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4881 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4882
d66c4c7c
CY
48832011-05-29 Chong Yidong <cyd@stupidchicken.com>
4884
4885 * image.c: Various fixes to ImageMagick code comments.
4886 (Fimagemagick_types): Doc fix.
4887
5fbc2025
PE
48882011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4889
0196f88a
PE
4890 Minor fixes prompted by GCC 4.6.0 warnings.
4891
4892 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4893
5fbc2025
PE
4894 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4895 (x_clipboard_manager_save_all): Move extern decl to ...
4896 * xterm.h: ... here, so that it can be checked for consistency.
4897
1dd3c2d9
CY
48982011-05-29 Chong Yidong <cyd@stupidchicken.com>
4899
4900 * xselect.c (x_clipboard_manager_save_frame)
4901 (x_clipboard_manager_save_all): New functions.
4902 (Fx_clipboard_manager_save): Lisp function deleted.
4903
4904 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4905 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4906
4907 * xterm.h: Update prototype.
4908
5ba6571d
WX
49092011-05-28 William Xu <william.xwl@gmail.com>
4910
4911 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4912 exiting (Bug#8239).
4913
3eaff834
JM
49142011-05-28 Jim Meyering <meyering@redhat.com>
4915
e1900994 4916 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4917 * fns.c (to_uchar): Define.
4918 (crypto_hash_function): Use it to convert some newly-signed
4919 variables to unsigned, to avoid sign-extension bugs. For example,
4920 without this change, (md5 "truc") would evaluate to
4921 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4922 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4923 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4924
0f6990a7
PE
49252011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4926
4927 Integer overflow fixes.
c8a9ca5a 4928
08686060
PE
4929 * dbusbind.c: Serial number integer overflow fixes.
4930 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4931 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4932 to hold a serial number that is too large for a fixnum.
4933 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4934 Check for serial numbers out of range. Decode any serial number
59568bf0 4935 that was so large that it became a float. (Bug#8722)
08686060 4936
2d1fc3c7
PE
4937 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4938 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4939 Use XFASTINT rather than XUINT when numbers are nonnegative.
4940 (xd_append_arg, Fdbus_method_return_internal):
4941 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4942 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4943 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4944 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4945 (Bug#8722)
2d1fc3c7 4946
c8a9ca5a
PE
4947 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4948
519e1d69
PE
4949 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4950
30569699
PE
4951 ccl: add integer overflow checks
4952 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4953 (IN_INT_RANGE): New macros.
4954 (ccl_driver): Use them to check for integer overflow when
4955 decoding a CCL program. Many of the new checks are whether XINT (x)
4956 fits in int; it doesn't always, on 64-bit hosts. The new version
4957 doesn't catch all possible integer overflows, but it's an
847044ea 4958 improvement. (Bug#8719)
30569699 4959
c11285dc
PE
4960 * alloc.c (make_event_array): Use XINT, not XUINT.
4961 There's no need for unsigned here.
4962
fdccd48e
PE
4963 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4964 This follows up to the 2011-05-06 change that substituted uintptr_t
4965 for EMACS_INT. This case wasn't caught back then.
4966
37910ab2
PE
4967 Rework Fformat to avoid integer overflow issues.
4968 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4969 now (part of C89). Include <verify.h>.
4970 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4971 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4972 (Fformat): Avoid the prepass trying to compute sizes; it was only
4973 approximate and thus did not catch overflow reliably. Instead, walk
4974 through the format just once, formatting and computing sizes as we go,
4975 checking for integer overflow at every step, and allocating a larger
4976 buffer as needed. Keep track separately whether the format is
4977 multibyte. Keep only the most-recently calculated precision, rather
4978 than them all. Record whether each argument has been converted to
4979 string. Use EMACS_INT, not int, for byte and char and arg counts.
4980 Support field widths and precisions larger than INT_MAX. Avoid
4981 sprintf's undefined behavior with conversion specifications such as %#d
4982 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4983 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4984 formatting out-of-range floating point numbers with int
9173deec 4985 formats. (Bug#8668)
37910ab2 4986
2e6578fb
PE
4987 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4988
0ae6bdee
PE
4989 * data.c: Avoid integer truncation in expressions involving floats.
4990 * data.c: Include <intprops.h>.
4991 (arith_driver): When there's an integer overflow in an expression
4992 involving floating point, convert the integers to floating point
4993 so that the resulting value does not suffer from catastrophic
4994 integer truncation. For example, on a 64-bit host (* 4
4995 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4996 Do not rely on undefined behavior after integer overflow.
4997
de883a70
PE
4998 merge count_size_as_multibyte, parse_str_to_multibyte
4999 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5000 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5001 Check for integer overflow.
5002 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5003 since it's now a duplicate of the other. This is more of
5004 a character than a buffer op, so better that it's in character.c.
5005 * fns.c, print.c: Adjust to above changes.
5006
2ff916cb
PE
50072011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5008
5009 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5010
f1b54466
PE
50112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5012
fb1ac845
PE
5013 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5014 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5015 (x_clipboard_manager_save): Now static.
5016 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5017
f1b54466
PE
5018 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5019 (crypto_hash_function): Now static.
5020 Fix pointer signedness problems. Avoid unnecessary initializations.
5021
a9f737ee
CY
50222011-05-27 Chong Yidong <cyd@stupidchicken.com>
5023
5024 * termhooks.h (Vselection_alist): Make it terminal-local.
5025
5026 * terminal.c (create_terminal): Initialize it.
5027
5028 * xselect.c: Support for clipboard managers.
5029 (Vselection_alist): Move to termhooks.h as terminal-local var.
5030 (LOCAL_SELECTION): New macro.
5031 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5032 (symbol_to_x_atom): Remove gratuitous arg.
5033 (x_handle_selection_request, lisp_data_to_selection_data)
5034 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5035 (x_own_selection, x_get_local_selection, x_convert_selection):
5036 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5037 (some_frame_on_display): Delete unused function.
5038 (Fx_own_selection_internal, Fx_get_selection_internal)
5039 (Fx_disown_selection_internal, Fx_selection_owner_p)
5040 (Fx_selection_exists_p): New optional frame arg.
5041 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5042 (x_handle_selection_clear): Don't treat other terminals with the
5043 same keyboard specially. Use the terminal-local Vselection_alist.
5044 (x_clear_frame_selections): Use Frun_hook_with_args.
5045
5046 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5047
5048 * xterm.h: Add support for those atoms.
5049
e067f0c1
CY
50502011-05-26 Chong Yidong <cyd@stupidchicken.com>
5051
5052 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5053 (converted_selections, conversion_fail_tag): New global variables.
5054 (x_selection_request_lisp_error): Free the above.
5055 (x_get_local_selection): Remove unnecessary code.
5056 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5057 of converted selections stored in converted_selections.
5058 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5059 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5060 (x_convert_selection): New function.
5061 (x_handle_selection_event): Simplify.
5062 (x_get_foreign_selection): Don't ignore incoming requests while
5063 waiting for an answer; this will fail when we implement
5064 SAVE_TARGETS, and seems unnecessary anyway.
5065 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5066 (Vx_sent_selection_functions): Doc fix.
5067
0f4aebc0
LL
50682011-05-26 Leo Liu <sdl.web@gmail.com>
5069
5070 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5071
e61124cd
YM
50722011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5073
5074 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5075
5076 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5077 for fringe update if it has periodic bitmap.
ac389d0c 5078 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5079 and fringe_bitmap_periodic_p.
5080
5081 * fringe.c (get_fringe_bitmap_data): New function.
5082 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5083 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5084 row. Mark glyph row for fringe update if periodicity changed.
5085
5086 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5087 for fringe update unless it has periodic bitmap.
5088
f16d9837
KH
50892011-05-25 Kenichi Handa <handa@m17n.org>
5090
5091 * xdisp.c (get_next_display_element): Set correct it->face_id for
5092 a static composition.
5093
e1b90ef6
LL
50942011-05-24 Leo Liu <sdl.web@gmail.com>
5095
5096 * deps.mk (fns.o):
5097 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5098
5099 * fns.c (crypto_hash_function, Fsha1): New function.
5100 (Fmd5): Use crypto_hash_function.
5101 (syms_of_fns): Add Ssha1.
5102
7400048f
PE
51032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5104
5105 * gnutls.c: Remove unused macros.
5106 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5107 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5108 Remove macros that are defined and never used.
5109 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5110
abb71cf4
CY
51112011-05-22 Chong Yidong <cyd@stupidchicken.com>
5112
5113 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5114 (Fx_get_selection_internal): Minor cleanup.
5115 (Fx_own_selection_internal): Rename arguments for consistency with
5116 select.el.
5117
6307db39
PE
51182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5119
5120 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5121
f3d4e0a4
CY
51222011-05-22 Chong Yidong <cyd@stupidchicken.com>
5123
5124 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5125
4d8ade89
YM
51262011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5127
5128 * dispnew.c (scrolling_window): Don't exclude the case that the
5129 last enabled row in the desired matrix touches the bottom boundary.
5130
32078c8d
GM
51312011-05-21 Glenn Morris <rgm@gnu.org>
5132
5133 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5134 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5135 and add some more files.
32078c8d 5136
7285dc67
EZ
51372011-05-20 Eli Zaretskii <eliz@gnu.org>
5138
5139 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5140 report_file_error introduced by the change from 2011-05-07.
5141
89d1bd22
PE
51422011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5143
5144 * systime.h (Time): Define only if emacs is defined.
5145 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5146 where the include path doesn't have X11/X.h by default. See
5147 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5148
e23640bb 51492011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5150
5151 * composite.c (find_automatic_composition): Fix previous change.
5152
b9704ad9
GM
51532011-05-20 Glenn Morris <rgm@gnu.org>
5154
5155 * lisp.mk: New file, split from Makefile.in.
5156 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5157 (shortlisp): Remove.
5158 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5159
4a720484
GM
51602011-05-19 Glenn Morris <rgm@gnu.org>
5161
5162 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5163 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5164 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5165 (lisp): Set the order to that of loadup.el.
5166 (shortlisp): Make it a copy of $lisp.
5167 (SOME_MACHINE_LISP): Remove.
5168 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5169 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5170
a28d4396
KH
51712011-05-18 Kenichi Handa <handa@m17n.org>
5172
5173 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5174 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5175 (find_automatic_composition): Mostly rewrite for efficiency.
5176
a2b1fa8e
JB
51772011-05-18 Juanma Barranquero <lekktu@gmail.com>
5178
5179 * makefile.w32-in: Update dependencies.
5180
8e1f5610
CS
51812011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5182
5183 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5184 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5185
7025ee00 51862011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5187
cdfa6eab
PE
5188 Fix some integer overflow issues, such as string length overflow.
5189
06d6db33
PE
5190 * insdel.c (count_size_as_multibyte): Check for string overflow.
5191
2b4560a8
PE
5192 * character.c (lisp_string_width): Check for string overflow.
5193 Use EMACS_INT, not int, for string indexes and lengths; in
5194 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5195 the resulting string length overflows an EMACS_INT; instead,
5196 report a string overflow if no precision given. When checking for
5197 precision exhaustion, use a check that cannot possibly have
5198 integer overflow. (Bug#8675)
5199 * character.h (lisp_string_width): Adjust to new signature.
5200
cb93f9be
PE
5201 * alloc.c (string_overflow): New function.
5202 (Fmake_string): Use it. This doesn't change behavior, but saves
5203 a few bytes and will simplify future changes.
5204 * character.c (string_escape_byte8): Likewise.
5205 * lisp.h (string_overflow): New decl.
5206
1a1f3366
PE
5207 Fixups, following up to the user-interface timestamp change.
5208 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5209 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5210 * msdos.c (mouse_get_pos): Likewise.
5211 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5212 * w32gui.h (Time): Define by including "systime.h" rather than by
5213 declaring it ourselves. (Bug#8664)
5214
d4e3e4d3
PE
5215 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5216 * image.c (clear_image_cache): Likewise.
5217
f6a24d19
PE
5218 * term.c (term_mouse_position): Don't assume time_t wraparound.
5219
08dc5ae6
PE
5220 Be more systematic about user-interface timestamps.
5221 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5222 and sometimes 'EMACS_UINT', to represent these timestamps.
5223 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5224 This makes the code easier to follow, and makes it easier to catch
5225 integer overflow bugs such as Bug#8664.
5226 * frame.c (Fmouse_position, Fmouse_pixel_position):
5227 Use Time, not unsigned long, for user-interface timestamps.
5228 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5229 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5230 * keyboard.h (last_event_timestamp): Likewise.
5231 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5232 * menu.h (xmenu_show): Likewise.
5233 * term.c (term_mouse_position): Likewise.
5234 * termhooks.h (struct input_event.timestamp): Likewise.
5235 (struct terminal.mouse_position_hook): Likewise.
5236 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5237 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5238 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5239 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5240 what it was before.
5241 * menu.h, termhooks.h: Include "systime.h", for Time.
5242
8e55734a
PE
5243 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5244 Don't assume that the difference between two unsigned long values
5245 can fit into an integer. At this point, we know button_down_time
5246 <= event->timestamp, so the difference must be nonnegative, so
5247 there's no need to cast the result if double-click-time is
5248 nonnegative, as it should be; check that it's nonnegative, just in
5249 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5250 apart (about 25 days). (Bug#8664)
8e55734a 5251
841f1b75 5252 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5253 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5254
3e26f69c
PE
5255 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5256 that always fit in int. Use a sentinel instead of a counter, to
5257 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5258 * frame.h (struct frame): Use int for menu_bar_items_used
5259 instead of EMACS_INT, since it always fits in int.
3e26f69c 5260
5cc152c0
PE
5261 * menu.c (grow_menu_items): Check for int overflow.
5262
d89eb65e
PE
5263 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5264
5235bd3e
PE
5265 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5266 Before, the code was not consistent. These values cannot exceed
5267 2**31 - 1 so there's no need to make them unsigned.
5268 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5269 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5270 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5271 as modifiers.
5272 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5273
bc827e23
PE
5274 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5275 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5276 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5277 presumably because the widths might not match.
5278
78eb494e
PE
5279 * window.c (size_window): Avoid needless test at loop start.
5280
04f2d78b
CB
52812011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5282
5283 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5284
d2fc7e3d 52852011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5286
5287 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5288
d2fc7e3d 52892011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5290
5291 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5292 `width' to `bar_area_x' and `bar_area_width', respectively.
5293 (x_scroll_run): Take account of fringe background extension.
5294
04f2d78b
CB
5295 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5296 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5297 `bar_area_width', respectively.
5298 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5299 background extension.
5300
79b70037
GM
53012011-05-10 Jim Meyering <meyering@redhat.com>
5302
5303 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5304
2f142cc5
JB
53052011-05-10 Juanma Barranquero <lekktu@gmail.com>
5306
5307 * image.c (Finit_image_library): Return t for built-in image types,
5308 like pbm and xbm. (Bug#8640)
5309
57679c86
AS
53102011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5311
5312 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5313
888c9e86
EZ
53142011-05-07 Eli Zaretskii <eliz@gnu.org>
5315
b0512a1d
EZ
5316 * w32console.c (Fset_screen_color): Doc fix.
5317 (Fget_screen_color): New function.
5318 (syms_of_ntterm): Defsubr it.
5319
7285dc67
EZ
5320 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5321 unlink the temporary file if Fcall_process didn't create it in the
5322 first place.
5323 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5324 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5325 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5326 cue to call_process_cleanup not to close that handle.
5327
4d3fcc8e
BK
53282011-05-07 Ben Key <bkey76@gmail.com>
5329
5330 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5331 one of two shell specific rules, either bootstrap-temacs-CMD or
5332 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5333 to the previous implementation of the bootstrap-temacs rule.
5334 The bootstrap-temacs-CMD rule is similar to the previous
5335 implementation of the bootstrap-temacs rule except that it
5336 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5337 variable.
5338
5339 These changes, along with some changes to nt/configure.bat,
5340 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5341 earlier fix to add support for --cflags and --ldflags options
5342 that include quotes so that it works whether make uses cmd or
5343 sh as the shell.
5344
b4289b64
MA
53452011-05-06 Michael Albinus <michael.albinus@gmx.de>
5346
5347 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5348 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5349 is a constant.
5350 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5351 a string. Handle both cases.
5352 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5353 (Fdbus_register_method): Use Qinvalid_function.
5354
af4c0e28
JB
53552011-05-06 Juanma Barranquero <lekktu@gmail.com>
5356
5357 * makefile.w32-in: Update dependencies.
5358 (LISP_H): Add inttypes.h and stdin.h.
5359 (PROCESS_H): Add unistd.h.
5360
c51453d9
EZ
53612011-05-06 Eli Zaretskii <eliz@gnu.org>
5362
5363 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5364 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5365
8ff0ac3c 53662011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5367
4c4b566b
PE
5368 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5369
aab2b9b5
PE
5370 * term.c (vfatal): Remove stray call to va_end.
5371 It's not needed and the C Standard doesn't allow it here anyway.
5372
c378da0b
PE
5373 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5374 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5375
288b08c7
PE
5376 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5377 bytes.
5378
e3601888
PE
5379 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5380
db6c0e74
PE
5381 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5382
dd5963ea
PE
5383 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5384
88c9450f
PE
5385 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5386
2f9442b8
PE
5387 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5388
c032b5f8
PE
5389 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5390 * charset.c (Fdefine_charset_internal): Don't initialize
5391 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5392 32-bit int (Bug#8600).
a108c10b
PE
5393
5394 * lread.c (read_integer): Be more consistent with string-to-number.
5395 Use string_to_number to do the actual conversion; this avoids
5396 rounding errors and fixes some other screwups. Without this fix,
5397 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5398 (digit_to_number): Move earlier, for benefit of read_integer.
5399 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5400 not a digit in any supported base. (Bug#8602)
a108c10b 5401
ad5f9eea
PE
5402 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5403
aec1708a
PE
5404 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5405 to match comment at start of function. This also removes a
5406 GCC warning about overflow in a 32+64-bit port.
5407
47be4ab5
PE
5408 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5409
371cac43
PE
5410 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5411 Reported by Stefan Monnier in
5412 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5413 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5414 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5415
d01a7826
PE
5416 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5417 (EMACS_UINTPTR): Likewise, with uintptr_t.
5418
7fd47d5c
PE
5419 * lisp.h: Prefer 64-bit EMACS_INT if available.
5420 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5421 on 32-bit hosts that have 64-bit int, so that they can access
5422 large files.
122b0c86
PE
5423 However, temporarily disable this change unless the temporary
5424 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5425
8727937b
PE
5426 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5427
8ac068ac
PE
5428 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5429 This removes an assumption that EMACS_INT and long are the same
5430 width as pointers. The assumption is true for Emacs porting targets
5431 now, but we want to make other targets possible.
5432 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5433 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5434 In the rest of the code, change types of integers that hold casted
5435 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5436 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5437 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5438 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5439 No need to cast type when ORing.
5440 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5441 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5442 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5443 assume EMACS_INT is the same width as char *.
5444 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5445 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5446 Remove no-longer-needed casts.
5447 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5448 (xg_tool_bar_help_callback, xg_make_tool_item):
5449 Use EMACS_INTPTR to hold an integer
5450 that will be cast to void *; this can avoid a GCC warning
5451 if EMACS_INT is not the same width as void *.
5452 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5453 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5454 (current_message_1, set_message_1):
5455 Use a local to convert to proper width without a cast.
5456 * xmenu.c (dialog_selection_callback): Likewise.
5457
ede49d71
PE
5458 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5459 Also, don't assume VALBITS / RAND_BITS is less than 5,
5460 and don't rely on undefined behavior when shifting a 1 left into
5461 the sign bit.
5462 * lisp.h (get_random): Change signature to match.
5463
2f30ecd0
PE
5464 * lread.c (hash_string): Use size_t, not int, for hash computation.
5465 Normally we prefer signed values; but hashing is special, because
5466 it's better to use unsigned division on hash table sizes so that
5467 the remainder is nonnegative. Also, size_t is the natural width
5468 for hashing into memory. The previous code used 'int', which doesn't
5469 retain enough info to hash well into very large tables.
5470 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5471
2a866e7b
PE
5472 * dbusbind.c: Don't possibly lose pointer info when converting.
5473 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5474 Use XPNTR rather than XHASH, so that the high-order bits of
5475 the pointer aren't lost when converting through void *.
5476
51639eac
PE
5477 * eval.c (Fautoload): Don't double-shift a pointer.
5478
92394119
PE
5479 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5480
dbdb9a7c
JB
54812011-05-06 Juanma Barranquero <lekktu@gmail.com>
5482
5483 * gnutls.c (DEF_GNUTLS_FN):
5484 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5485
db7a0b4f
AS
54862011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5487
5488 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5489 marker. (Bug#8610)
5490
f7ff1b0f 54912011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5492
5493 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5494 New version that can reserve upto 2GB of heap space.
5495
f7ff1b0f 54962011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5497
5498 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5499
639c109b
TZ
55002011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5501
5502 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5503 `gnutls_certificate_set_x509_key_file'.
5504
d2127135
JB
55052011-05-05 Juanma Barranquero <lekktu@gmail.com>
5506
5507 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5508 Update dependencies.
5509
e968f4f3
JB
55102011-05-04 Juanma Barranquero <lekktu@gmail.com>
5511
5512 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5513 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5514 Remove unused parameter `fildes'.
5515 * process.c (read_process_output, send_process): Don't pass it.
5516
84d358f0
JB
55172011-05-04 Juanma Barranquero <lekktu@gmail.com>
5518
5519 Fix previous change: the library cache is defined in w32.c.
5520 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5521 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5522
0898ca10
JB
55232011-05-04 Juanma Barranquero <lekktu@gmail.com>
5524
5525 Implement dynamic loading of GnuTLS on Windows.
5526
5527 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5528 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5529 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5530 Declare.
5531
5532 * gnutls.c (Qgnutls_dll): Define.
5533 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5534 (gnutls_*): Declare function pointers.
5535 (init_gnutls_functions): New function to initialize function pointers.
5536 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5537 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5538 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5539 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5540 (emacs_gnutls_write, emacs_gnutls_read)
5541 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5542 (Fgnutls_available_p): New function.
5543 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5544 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5545 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5546
5547 * image.c: Include w32.h.
5548 (Vimage_type_cache): Delete.
5549 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5550 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5551 (w32_delayed_load): Move to w32.c.
5552
5553 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5554
5555 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5556 (w32_delayed_load): Move from image.c. When loading a library, record
5557 its filename in the :loaded-from property of the library id.
5558 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5559 Initialize and staticpro them.
5560 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5561
5562 * process.c: Include lisp.h before w32.h, not after.
5563 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5564 instead of gnutls_record_check_pending.
5565
5566 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5567
ff4de4aa
TZ
55682011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5569
5570 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5571 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5572 as passed in.
5573
abe95abb
JD
55742011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5575
5576 * xterm.c (x_set_frame_alpha): Do not set property on anything
5577 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5578
e16e55d4
JB
55792011-05-02 Juanma Barranquero <lekktu@gmail.com>
5580
5581 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5582
bafcf6a5
JB
55832011-05-02 Juanma Barranquero <lekktu@gmail.com>
5584
5585 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5586 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5587 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5588 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5589 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5590 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5591 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5592 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5593 (Qgnutls_bootprop_callbacks_verify): Make static.
5594
e7a6747f
AS
55952011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5596
19ed11ba
AS
5597 * callproc.c: Indentation fixup.
5598
e7a6747f 5599 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5600 (wait_for_termination, interruptible_wait_for_termination):
5601 Move after wait_for_termination_1.
e7a6747f 5602
1ef14cb4
LMI
56032011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5604
5605 * sysdep.c (interruptible_wait_for_termination): New function
5606 which is like wait_for_termination, but allows keyboard
5607 interruptions.
5608
5609 * callproc.c (Fcall_process): Add (:file "file") as an option for
5610 the STDOUT buffer.
5611 (Fcall_process_region): Ditto.
5612
330d880c
EZ
56132011-04-30 Eli Zaretskii <eliz@gnu.org>
5614
8db90b73
EZ
5615 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5616 rather than `XVECTOR (FOO)->size'.
5617
330d880c
EZ
5618 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5619 inttypes.h, as a gnulib replacement is used if it not available in
5620 system headers.
5621
15cbd324
EZ
56222011-04-21 Eli Zaretskii <eliz@gnu.org>
5623
5624 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5625 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5626 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5627
5628 * coding.c (coding_alloc_by_realloc): Error out if destination
5629 will grow beyond MOST_POSITIVE_FIXNUM.
5630 (decode_coding_emacs_mule): Abort if there isn't enough place in
5631 charbuf for the composition carryover bytes. Reserve an extra
5632 space for up to 2 characters produced in a loop.
5633 (decode_coding_iso_2022): Abort if there isn't enough place in
5634 charbuf for the composition carryover bytes.
5635
56362011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5637
ae940cca
EZ
5638 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5639 aborting when %lld or %lll format is passed.
5640 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5641 %llo or %llx format is passed. (Bug#8545)
5642
03ab8921
EZ
5643 * window.c (window_scroll_line_based): Use a marker instead of
5644 simple variables to record original value of point. (Bug#7952)
5645
afda1437
EZ
5646 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5647 produced by %s or %c overflows available buffer space. (Bug#8545)
5648
f76dee0c
PE
56492011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5650
5651 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5652 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5653
fdc5744d
JB
56542011-04-28 Juanma Barranquero <lekktu@gmail.com>
5655
5656 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5657
638f053a
JB
56582011-04-28 Juanma Barranquero <lekktu@gmail.com>
5659
5660 * keyboard.c (Qdelayed_warnings_hook): Define.
5661 (command_loop_1): Run `delayed-warnings-hook'
5662 if Vdelayed_warnings_list is non-nil.
5663 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5664 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5665
d178f871
EZ
56662011-04-28 Eli Zaretskii <eliz@gnu.org>
5667
5668 * doprnt.c (doprnt): Don't return value smaller than the buffer
5669 size if the message was truncated. (Bug#8545).
5670
b124fd93
JB
56712011-04-28 Juanma Barranquero <lekktu@gmail.com>
5672
5673 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5674 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5675
e810457d
PE
56762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5677
5678 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5679
ea51cceb
JB
56802011-04-27 Juanma Barranquero <lekktu@gmail.com>
5681
5682 * makefile.w32-in: Update dependencies.
5683
94dcfacf
EZ
56842011-04-27 Eli Zaretskii <eliz@gnu.org>
5685
5686 Improve `doprnt' and its usage. (Bug#8545)
5687 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5688 `format_end'. Remove support for %l as a conversion specifier.
5689 Don't use xrealloc. Improve diagnostics when the %l size modifier
5690 is used. Update the commentary.
5691
5692 * eval.c (verror): Simplify calculation of size_t.
5693
5694 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5695 messages.
5696
f61f41d7
PE
56972011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5698
5699 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5700 change.
5701
96fb4434
PE
57022011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5703
5704 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5705 This makes this file independent of the recent pseudovector change.
5706
671875da 57072011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5708
69e9b5a3
PE
5709 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5710
b5f869a7 5711 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5712 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5713 Remove unused local.
c8926152 5714 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5715
841a1577 5716 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5717 GCC 4.6.0 optimizes based on type-based alias analysis.
5718 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5719 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5720 != &v->size, and therefore "v->size = 1; b->size = 2; return
5721 v->size;" must therefore return 1. This assumption is incorrect
5722 for Emacs, since it type-puns struct Lisp_Vector * with many other
5723 types. To fix this problem, this patch adds a new type struct
f904488f 5724 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5725 and pseudovectors, and helps optimizing compilers not get fooled
5726 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5727 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5728 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5729 the size member.
eab3844f
PE
5730 (XSETPVECTYPE): Rewrite in terms of new macro.
5731 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5732 This is a bit clearer, and further avoids the possibility of
5733 undesirable aliasing.
5734 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5735 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5736 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5737 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5738 (ASIZE): Now uses header.size rather than size.
5739 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5740 to avoid the hassle of writing XVECTOR (foo)->header.size.
5741 (struct vectorlike_header): New type.
eab3844f
PE
5742 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5743 object, to help avoid aliasing.
5744 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5745 (SUBRP): Likewise, since Lisp_Subr is a special case.
5746 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5747 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5748 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5749 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5750 changed to be "header.size" and "header.next".
5751 * buffer.h (struct buffer): Likewise.
5752 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5753 * frame.h (struct frame): Likewise.
5754 * process.h (struct Lisp_Process): Likewise.
5755 * termhooks.h (struct terminal): Likewise.
5756 * window.c (struct save_window_data, struct saved_window): Likewise.
5757 * window.h (struct window): Likewise.
5758 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5759 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5760 * buffer.c (init_buffer_once): Likewise.
5761 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5762 special case.
5763 * process.c (Fformat_network_address): Use local var for size,
5764 for brevity.
5765
0df1eac5
PE
5766 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5767
847ab9d1 5768 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5769 * data.c (atof): Remove decl; no longer used or needed.
5770 (digit_to_number): Move to lread.c.
5771 (Fstring_to_number): Use new string_to_number function, to be
5772 consistent with how the Lisp reader treats infinities and NaNs.
5773 Do not assume that floating-point numbers represent EMACS_INT
5774 without losing information; this is not true on most 64-bit hosts.
5775 Avoid double-rounding errors, by insisting on integers when
5776 parsing non-base-10 numbers, as the documentation specifies.
5777 * lisp.h (string_to_number): New decl, replacing ...
5778 (isfloat_string): Remove.
bc0a5c13 5779 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5780 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5781 appears to have been a coding error. Similarly, do not accept
5782 strings like +-1e0 as floating point numbers. Do not report
5783 overflow for integer overflows unless the base is not 10 which
5784 means we have no simple and reliable way to continue.
5785 Break out the floating-point parsing into a new
5786 function string_to_number, so that Fstring_to_number parses
5787 floating point numbers consistently with the Lisp reader.
04f2d78b 5788 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5789 (E_CHAR, EXP_INT): Remove, replacing with ...
5790 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5791 (string_to_number): New function, replacing isfloat_string.
5792 This function checks for valid syntax and produces the resulting
5793 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5794 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5795 so that overflow for non-base-10 numbers is reported only when
5796 there's no portable and simple way to convert to floating point.
452f4150 5797
67769ffc
PE
5798 * textprop.c (set_text_properties_1): Rewrite for clarity,
5799 and to avoid GCC warning about integer overflow.
5800
c20db43f
PE
5801 * intervals.h (struct interval): Use EMACS_INT for members
5802 where EMACS_UINT might cause problems. See
5803 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5804 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5805 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5806 All uses changed.
37aa2f85
PE
5807 (offset_intervals): Tell GCC not to worry about length overflow
5808 when negating a negative length.
c20db43f 5809
2538aa2f
PE
5810 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5811 (overrun_check_free): Likewise.
5812
f2d3008d
PE
5813 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5814 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5815 word size.
5816
ec8df744
PE
5817 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5818 (gnutls_make_error): Rename local to avoid shadowing.
5819 (gnutls_emacs_global_deinit): ifdef out; not used.
5820 (Fgnutls_boot): Use const for pointer to readonly storage.
5821 Comment out unused local. Fix pointer signedness problems.
5822
640ee02d
PE
5823 * lread.c (openp): Don't stuff size_t into an 'int'.
5824 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5825 about possible signed overflow.
5826
6048fb2a
PE
5827 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5828 (GDK_KEY_g): Don't define if already defined.
5829 (xg_prepare_tooltip): Avoid pointer signedness problem.
5830 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5831
fa3c87e1
PE
5832 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5833 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5834
2172544b
PE
5835 * xfns.c (Fx_window_property): Simplify a bit,
5836 to make a bit faster and to avoid GCC 4.6.0 warning.
5837 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5838
9b821a21
PE
5839 * fns.c (internal_equal): Don't assume size_t fits in int.
5840
3c616cfa
PE
5841 * alloc.c (compact_small_strings): Tighten assertion a little.
5842
c2982e87
PE
5843 Replace pEd with more-general pI, and fix some printf arg casts.
5844 * lisp.h (pI): New macro, generalizing old pEd macro to other
5845 conversion specifiers. For example, use "...%"pI"d..." rather
5846 than "...%"pEd"...".
5847 (pEd): Remove. All uses replaced with similar uses of pI.
5848 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5849 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5850 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5851 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5852 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5853 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5854 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5855 64-bit hosts.
5856 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5857 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5858 * print.c (safe_debug_print, print_object): Likewise.
5859 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5860 to int.
6f04d126
PE
5861 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5862 avoiding the 0 flag, which is not portable.
c2982e87
PE
5863 * process.c (Fmake_network_process): Use pI to avoid cast.
5864 * region-cache.c (pp_cache): Likewise.
5865 * xdisp.c (decode_mode_spec): Likewise.
5866 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5867 behavior on 64-bit hosts with printf arg.
6f04d126 5868 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5869 (x_stop_queuing_selection_requests): Likewise.
5870 (x_get_window_property): Don't truncate byte count to an 'int'
5871 when tracing.
0b432f21 5872
5e073ec7
PE
5873 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5874 here, since it parses constructs like leading '-' and spaces,
5875 which are not wanted; and it overflows with large numbers.
5876 Instead, simply match F[0-9]+, which is what is wanted anyway.
5877
36372bf9
PE
5878 * alloc.c: Remove unportable assumptions about struct layout.
5879 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5880 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5881 (allocate_vectorlike, make_pure_vector): Use the new macros,
5882 plus offsetof, to remove unportable assumptions about struct layout.
5883 These assumptions hold on all porting targets that I know of, but
5884 they are not guaranteed, they're easy to remove, and removing them
5885 makes further changes easier.
5886
0b432f21
PE
5887 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5888 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5889 (string_overrun_cookie): Now const. Use initializers that
5890 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5891 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5892 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5893 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5894 multiple of sizeof (EMACS_INT); it need not be, if
5895 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5896 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5897
895009e1
JB
58982011-04-26 Juanma Barranquero <lekktu@gmail.com>
5899
5900 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5901
6a7a1b0b
TZ
59022011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5903
5904 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5905 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5906 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5907
841a1577 59082011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5909
5910 * lisp.h (Qdebug): List symbol.
895009e1 5911 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5912 * keyboard.c (debug-on-event): New variable.
5913 (handle_user_signal): Break into debugger when debug-on-event
5914 matches the current signal symbol.
5915
f2d3ba6f
DN
59162011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5917
5918 * alloc.c (check_sblock, check_string_bytes)
5919 (check_string_free_list): Convert to standard C.
5920
42ce4c63
TZ
59212011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5922
5923 * w32.c (emacs_gnutls_push): Fix typo.
5924
825cd63c
EZ
59252011-04-25 Eli Zaretskii <eliz@gnu.org>
5926
fb11d64d
EZ
5927 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5928 "cast to pointer from integer of different size".
5929
825cd63c
EZ
5930 Improve doprnt and its use in verror. (Bug#8545)
5931 * doprnt.c (doprnt): Document the set of format control sequences
5932 supported by the function. Use SAFE_ALLOCA instead of always
5933 using `alloca'.
5934
5935 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5936 is one byte too soon. Don't use xrealloc; instead xfree and
5937 xmalloc anew.
5938
e061a11b
TZ
59392011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5940
5941 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5942 callbacks stage.
5943
5944 * gnutls.c: Renamed global_initialized to
5945 gnutls_global_initialized. Added internals for the
5946 :verify-hostname-error, :verify-error, and :verify-flags
5947 parameters of `gnutls-boot' and documented those parameters in the
5948 docstring. Start callback support.
9173deec
JB
5949 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5950 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5951 on error. Return error code.
e061a11b
TZ
5952 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5953 (emacs_gnutls_read): Likewise.
5954 (Fgnutls_boot): Return handshake error code.
5955 (emacs_gnutls_handle_error): New function.
5956 (wsaerror_to_errno): Likewise.
5957
5958 * w32.h (emacs_gnutls_pull): Add prototype.
5959 (emacs_gnutls_push): Likewise.
5960
5961 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5962 (emacs_gnutls_push): Likewise.
5963
59642011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5965
5966 * process.c (wait_reading_process_output): Check if GnuTLS
5967 buffered some data internally if no FDs are set for TLS
5968 connections.
5969
5970 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5971 (LIBS): Link to USER_LIBS.
5972 ($(BLD)/gnutls.$(0)): New target.
5973
fa6996bc
EZ
59742011-04-24 Eli Zaretskii <eliz@gnu.org>
5975
eb35682e
EZ
5976 * xdisp.c (handle_single_display_spec): Rename the
5977 display_replaced_before_p argument into display_replaced_p, to
5978 make it consistent with the commentary. Fix typos in the
5979 commentary.
5980
e2ad650c
EZ
5981 * textprop.c (syms_of_textprop): Remove dead code.
5982 (copy_text_properties): Delete obsolete commentary about an
5983 interface that was deleted long ago. Fix typos in the description
5984 of arguments.
5985
1b2de274
EZ
5986 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5987 to changes in oldXMenu/XMenu.h from 2011-04-16.
5988 <menu_help_message, prev_menu_help_message>: Constify.
5989 (IT_menu_make_room): menu->help_text is now `const char **';
5990 adjust.
5991
5992 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5993 to changes in oldXMenu/XMenu.h from 2011-04-16.
5994 (struct XMenu): Declare `help_text' `const char **'.
5995
5996 * xfaces.c <Qunspecified>: Make extern again.
5997
5998 * syntax.c: Include sys/types.h before including regex.h, as
5999 required by Posix.
6000
762b15be
EZ
6001 * doc.c (get_doc_string): Improve the format passed to `error'.
6002
6003 * doprnt.c (doprnt): Improve commentary.
6004
6005 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6006
6007 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6008 them with etags.
6009
f1052e5d
EZ
6010 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6011 changes in globals.h immediately force recompilation.
762b15be
EZ
6012 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6013 $(CURDIR)/s/ms-w32.h.
6014 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6015
fa6996bc
EZ
6016 * character.c (Fchar_direction): Function deleted.
6017 (syms_of_character): Don't defsubr it.
6018 <char-direction-table>: Deleted.
6019
e6c3da20
EZ
60202011-04-23 Eli Zaretskii <eliz@gnu.org>
6021
6022 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6023 * doprnt.c: Include limits.h.
6024 (SIZE_MAX): New macro.
04f2d78b
CB
6025 (doprnt): Return a size_t value. 2nd arg is now size_t.
6026 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6027 Improve overflow protection. Support `l' modifier for integer
6028 conversions. Support %l conversion. Don't assume an EMACS_INT
6029 argument for integer conversions and for %c.
6030
6031 * lisp.h (doprnt): Restore prototype.
6032
6033 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6034 $(SRC)/character.h.
6035
6036 * Makefile.in (base_obj): Add back doprnt.o.
6037
6038 * deps.mk (doprnt.o): Add back prerequisites.
6039 (callint.o): Depend on character.h.
6040
6041 * eval.c (internal_lisp_condition_case): Include the handler
6042 representation in the error message.
6043 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6044 when breaking from the loop.
6045
6046 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6047
6048 * callint.c (Fcall_interactively): When displaying error message
6049 about invalid control letter, pass the character's codepoint, not
6050 a pointer to its multibyte form. Improve display of the character
6051 in octal and display also its hex code.
6052
6053 * character.c (char_string): Use %x to display the (unsigned)
6054 codepoint of an invalid character, to avoid displaying a bogus
6055 negative value.
6056
6057 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6058 `error', not SYMBOL_NAME itself.
6059
6060 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6061 character arguments to `error'.
6062
6063 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6064 to `error' in error message about FINAL_CHAR argument. Make sure
6065 FINAL_CHAR is a character, and use %c when it is passed as
6066 argument to `error'.
6067
4ffd0d6b 60682011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6069
6070 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6071
6072 * w32.c: Include <time.h>.
6073 (sys_localtime): New function.
6074
4ffd0d6b 60752011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6076
6077 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6078
4ffd0d6b 6079 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6080
4ffd0d6b 60812011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6082
4ffd0d6b
GM
6083 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6084 zombies (Bug#8467).
aac0c6e3 6085
04c56954
EZ
60862011-04-19 Eli Zaretskii <eliz@gnu.org>
6087
6088 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6089 gl_state.e_property when gl_state.object is Qt.
6090
6091 * insdel.c (make_gap_larger): Remove limitation of buffer size
6092 to <= INT_MAX.
6093
16a43933
CY
60942011-04-18 Chong Yidong <cyd@stupidchicken.com>
6095
6096 * xdisp.c (lookup_glyphless_char_display)
6097 (produce_glyphless_glyph): Handle cons cell entry in
6098 glyphless-char-display.
6099 (Vglyphless_char_display): Document it.
6100
6101 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6102 glyphless-char-display.
6103
4581706e
CY
61042011-04-17 Chong Yidong <cyd@stupidchicken.com>
6105
6106 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6107
6108 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6109
6110 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6111 definition for no-X builds.
6112
4887c6e2 61132011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6114
fd35b6f9
PE
6115 Static checks with GCC 4.6.0 and non-default toolkits.
6116
5c1ccb01
PE
6117 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6118
006c5daa
PE
6119 * process.c (keyboard_bit_set): Define only if SIGIO.
6120 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6121 (send_process): Repair possible setjmp clobbering.
6122
efc736d3
PE
6123 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6124
4e2fe2e6
PE
6125 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6126
f97334a2
PE
6127 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6128
4e75f29d
PE
6129 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6130 Define only if needed.
6131
90efadd1
PE
6132 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6133 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6134 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6135
3c647824
PE
6136 * dispextern.h (struct redisplay_interface): Rename param
6137 to avoid shadowing.
e264f262 6138 * termhooks.h (struct terminal): Likewise.
761383f4 6139 * xterm.c (xembed_send_message): Likewise.
3c647824 6140
b58c5c4a
PE
6141 * insdel.c (make_gap_smaller): Define only if
6142 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6143
cad59032
PE
6144 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6145 it.
6146
c339dc2e
PE
6147 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6148 so that we aren't warned about unused symbols.
6149
91a3e27b
PE
6150 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6151
399c71d3 6152 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6153
8ffc96f5
PE
6154 * xfns.c (x_real_positions): Mark locals as initialized.
6155
eef9bc79
PE
6156 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6157
098db9dd
PE
6158 * xterm.c: Fix problems found by static analysis with other toolkits.
6159 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6160 (x_dispatch_event): Declare static if USE_GTK, and
6161 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6162 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6163 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6164 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6165 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6166
eb18f6cc
PE
6167 * xmenu.c (menu_help_callback): Pointer type fixes.
6168 Use const pointers when pointing at readonly data. Avoid pointer
6169 signedness clashes.
6170 (FALSE): Remove unused macro.
6171 (update_frame_menubar): Remove unused decl.
6172
1fe72bf8
PE
6173 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6174
60d9e1db
PE
6175 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6176 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6177 (single_menu_item): Rename local to avoid shadowing.
6178
39261c26
PE
6179 * keyboard.c (make_lispy_event): Remove unused local var.
6180
018c5e19
PE
6181 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6182 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6183
63d2b86e
PE
6184 * bitmaps: Change bitmaps from unsigned char back to the X11
6185 compatible char. Avoid the old compiler warnings about
6186 out-of-range initializers by using, for example, '\xab' rather
6187 than 0xab.
6188
aefd87e1
PE
6189 * xgselect.c (xgselect_initialize): Check vs interface
6190 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6191
bf501fb9
PE
6192 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6193
e9829fdf
PE
6194 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6195 to read-only memory.
6196
1086c095
PE
6197 * fns.c (vector): Remove; this old hack is no longer needed.
6198
2baccd04 6199 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6200 Remove unused var.
dde42981 6201 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6202
72391843 6203 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6204
436c16df 6205 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6206 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6207 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6208
92bb796d 6209 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6210 (x_term_init): Remove local to avoid shadowing.
92bb796d 6211
764430a3 6212 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6213
6214 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6215 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6216
d1dfb56c
EZ
62172011-04-16 Eli Zaretskii <eliz@gnu.org>
6218
c4354cb4
EZ
6219 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6220
d1dfb56c
EZ
6221 Fix regex.c, syntax.c and friends for buffers > 2GB.
6222 * syntax.h (struct gl_state_s): Declare character position members
6223 EMACS_INT.
6224
6225 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6226
04f2d78b
CB
6227 * textprop.c (verify_interval_modification, interval_of):
6228 Declare arguments EMACS_INT.
d1dfb56c
EZ
6229
6230 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6231 EMACS_INT.
6232
6233 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6234
6235 * indent.c (Fvertical_motion): Local variable it_start is now
6236 EMACS_INT.
6237
6238 * regex.c (re_match, re_match_2, re_match_2_internal)
6239 (bcmp_translate, regcomp, regexec, print_double_string)
6240 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6241 (re_compile_pattern, re_exec): Declare arguments and local
6242 variables `size_t' and `ssize_t' and return values `regoff_t', as
6243 appropriate.
6244 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6245 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6246 <compile_stack_type>: `size' and `avail' are now `size_t'.
6247
6248 * regex.h <regoff_t>: Use ssize_t, not int.
6249 (re_search, re_search_2, re_match, re_match_2): Arguments that
6250 specify buffer/string position and length are now ssize_t and
6251 size_t. Return type is regoff_t.
6252
613052cd
BK
62532011-04-16 Ben Key <bkey76@gmail.com>
6254
6255 * nsfont.m: Fixed bugs in ns_get_family and
6256 ns_descriptor_to_entity that were caused by using free to
6257 deallocate memory blocks that were allocated by xmalloc (via
6258 xstrdup). This caused Emacs to crash when compiled with
6259 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6260 --enable-checking=xmallocoverrun). xfree is now used to
6261 deallocate these memory blocks.
6262
4170f62f 62632011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6264
71b41406
PE
6265 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6266
9587a89d
PE
6267 emacs_write: Accept and return EMACS_INT for sizes.
6268 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6269 et seq.
6270 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6271 Accept and return EMACS_INT.
6272 (emacs_gnutls_write): Return the number of bytes written on
6273 partial writes.
6274 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6275 (emacs_read, emacs_write): Remove check for negative size, as the
6276 Emacs source code has been audited now.
9587a89d
PE
6277 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6278 (emacs_read, emacs_write): Use it.
273a5f82
PE
6279 * process.c (send_process): Adjust to the new signatures of
6280 emacs_write and emacs_gnutls_write. Do not attempt to store
6281 a byte offset into an 'int'; it might overflow.
9587a89d 6282 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6283
3e047f51
PE
6284 * sound.c: Don't assume sizes fit in 'int'.
6285 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6286 Return EMACS_INT, not int.
3e047f51 6287 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6288 Accept EMACS_INT, not int.
6289 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6290 record read return values.
6291
cc39a9db
BK
62922011-04-15 Ben Key <bkey76@gmail.com>
6293
c9d0ec6d
JB
6294 * keyboard.c (Qundefined): Don't declare static since it is used
6295 in nsfns.m.
6296 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6297 static since they are used in nsfont.m.
cc39a9db 6298
6c60eb9f
SM
62992011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6300
6301 * process.c (Qprocessp): Don't declare static.
6302 * lisp.h (Qprocessp): Declare again.
6303
7990b61a
JB
63042011-04-15 Juanma Barranquero <lekktu@gmail.com>
6305
6306 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6307
5d4cb038
PE
63082011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6309
8bd7b830 6310 Improve C-level modularity by making more things 'static'.
cd64ea1d 6311
e3b27b31
PE
6312 Don't publish debugger-only interfaces to other modules.
6313 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6314 (verify_bytepos, count_markers): Move decls to the only modules
6315 that need them.
6316 * region-cache.h (pp_cache): Likewise.
6317 * window.h (check_all_windows): Likewise.
6318 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6319
5d4cb038
PE
6320 * sysdep.c (croak): Now static, if
6321 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6322 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6323
6324 * alloc.c (refill_memory_reserve): Now static if
6325 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6326 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6327
e87b6180
PE
6328 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6329 Define only if USE_LUCID.
6330
ac64929e
PE
6331 * xrdb.c (x_customization_string, x_rm_string): Now static.
6332
6f37259d
PE
6333 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6334 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6335
1683e3ab
PE
6336 * xdisp.c (draw_row_with_mouse_face): Now static.
6337 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6338
de9c2632
PE
6339 * window.h (check_all_windows): Mark externally visible.
6340
2b96acb7
PE
6341 * window.c (window_deletion_count): Now static.
6342
6343 * undo.c: Make symbols static if they're not exported.
6344 (last_undo_buffer, last_boundary_position, pending_boundary):
6345 Now static.
6346
50436f33
PE
6347 * textprop.c (interval_insert_behind_hooks): Now static.
6348 (interval_insert_in_front_hooks): Likewise.
6349
64520e5c
PE
6350 * term.c: Make symbols static if they're not exported.
6351 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6352 (max_frame_lines, tty_set_terminal_modes):
6353 (tty_reset_terminal_modes, tty_turn_off_highlight):
6354 (get_tty_terminal): Now static.
6355 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6356 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6357 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6358 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6359 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6360
1fa53021
PE
6361 * sysdep.c: Make symbols static if they're not exported.
6362 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6363 Now static.
6364 (sigprocmask_set, full_mask): Remove; unused.
6365 (wait_debugging): Mark as visible.
6366 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6367 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6368
d4b43b22
PE
6369 * syntax.c (syntax_temp): Define only if !__GNUC__.
6370
b7c513d0
PE
6371 * sound.c (current_sound_device, current_sound): Now static.
6372
989b29ad
PE
6373 * search.c (searchbufs, searchbuf_head): Now static.
6374
13a55a78
PE
6375 * scroll.c (scroll_cost): Remove; unused.
6376 * dispextern.h (scroll_cost): Remove decl.
6377
de68a1fc
PE
6378 * region-cache.h (pp_cache): Mark as externally visible.
6379
40ccffa6
PE
6380 * process.c: Make symbols static if they're not exported.
6381 (process_tick, update_tick, create_process, chan_process):
6382 (Vprocess_alist, proc_buffered_char, datagram_access):
6383 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6384 (deactivate_process): Mark defn as static, as well as decl.
6385 * lisp.h (create_process): Remove decl.
6386 * process.h (chan_process, Vprocess_alist): Remove decls.
6387
ad64fc97
PE
6388 * print.c: Make symbols static if they're not exported.
6389 (print_depth, new_backquote_output, being_printed, print_buffer):
6390 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6391 (print_interval, print_number_index, initial_stderr_stream):
6392 Now static.
6393 * lisp.h (Fprinc): Remove decl.
6394 (debug_output_compilation_hack): Mark as externally visible.
6395
adddb265
PE
6396 * sysdep.c (croak): Move decl from here to syssignal.h.
6397 * syssignal.h (croak): Put it here, so the API can be checked when
6398 'croak' is called from dissociate_if_controlling_tty.
6399
1717ede2
PE
6400 * minibuf.c: Make symbols static if they're not exported.
6401 (minibuf_save_list, choose_minibuf_frame): Now static.
6402 * lisp.h (choose_minibuf_frame): Remove decl.
6403
fa5fb2bc
PE
6404 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6405
1e3890d1
PE
6406 * lread.c: Make symbols static if they're not exported.
6407 (read_objects, initial_obarray, oblookup_last_bucket_number):
6408 Now static.
6409 (make_symbol): Remove; unused.
6410 * lisp.h (initial_obarray, make_symbol): Remove decls.
6411
8a1414fa
PE
6412 * keyboard.c: Make symbols static if they're not exported.
6413 (single_kboard, recent_keys_index, total_keys, recent_keys):
6414 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6415 (this_single_command_key_start, echoing, last_auto_save):
6416 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6417 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6418 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6419 (Vlispy_mouse_stem, double_click_count):
6420 Now static.
6421 (force_auto_save_soon): Define only if SIGDANGER.
6422 (ignore_mouse_drag_p): Now static if
6423 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6424 (print_help): Remove; unused.
6425 (stop_character, last_timer_event): Mark as externally visible.
6426 * keyboard.h (ignore_mouse_drag_p): Declare only if
6427 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6428 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6429 * lisp.h (echoing): Remove decl.
6430 (force_auto_save_soon): Declare only if SIGDANGER.
6431 * xdisp.c (redisplay_window): Simplify code, to make it more
6432 obvious that ignore_mouse_drag_p is not accessed if !defined
6433 USE_GTK && !defined HAVE_NS.
6434
93ea6e8f
PE
6435 * intervals.c: Make symbols static if they're not exported.
6436 (merge_properties_sticky, merge_interval_right, delete_interval):
6437 Now static.
6438 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6439
77382fcc
PE
6440 * insdel.c: Make symbols static if they're not exported.
6441 However, leave prepare_to_modify_buffer alone. It's never
6442 called from outside this function, but that appears to be a bug.
6443 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6444 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6445 (adjust_after_replace_noundo): Remove; unused.
6446 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6447 (signal_before_change): Remove decls.
77382fcc 6448
9306c32e
PE
6449 * indent.c (val_compute_motion, val_vmotion): Now static.
6450
cd44d2eb
PE
6451 * image.c: Make symbols static if they're not exported.
6452 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6453 if USE_GTK.
6454 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6455 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6456
ad9a7a06
PE
6457 * fringe.c (standard_bitmaps): Now static.
6458 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6459
81626931
PE
6460 * frame.c: Make symbols static if they're not exported.
6461 (x_report_frame_params, make_terminal_frame): Now static.
6462 (get_frame_param): Now static, unless HAVE_NS.
6463 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6464 (x_get_resource_string): Remove; not used.
6465 * frame.h (make_terminal_frame, x_report_frame_params):
6466 (x_get_resource_string); Remove decls.
6467 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6468 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6469
239f9db9
PE
6470 * font.c, fontset.c: Make symbols static if they're not exported.
6471 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6472 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6473 * font.c (font_close_object): Now static.
6474 * font.h (font_close_object): Remove.
6475 * fontset.c (FONTSET_OBJLIST): Remove.
6476 (free_realized_fontset) #if-0 the body, which does nothing.
6477 (face_suitable_for_char_p): #if-0, as it's never called.
6478 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6479 * xfaces.c (face_at_string_position):
6480 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6481 since 0 is always ASCII.
6482
dfcf3579
PE
6483 * fns.c (weak_hash_tables): Now static.
6484
5045092b
PE
6485 * fileio.c: Make symbols static if they're not exported.
6486 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6487 (Vwrite_region_annotation_buffers): Now static.
6488
57a96f5c
PE
6489 * eval.c: Make symbols static if they're not exported.
6490 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6491 * lisp.h (backtrace_list): Remove decl.
6492
35f08c38
PE
6493 * emacs.c: Make symbols static if they're not exported.
6494 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6495 (fatal_error_code, fatal_error_signal_hook, standard_args):
6496 Now static.
6497 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6498 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6499 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6500 * lisp.h (fatal_error_signal_hook): Remove decl.
6501 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6502
f44bd759
PE
6503 * editfns.c: Move a (normally-unused) function to its only use.
6504 * editfns.c, lisp.h (get_operating_system_release): Remove.
6505 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6506 worth the hassle of breaking this out.
6507
b532497d
PE
6508 * xterm.c: Make symbols static if they're not exported.
6509 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6510 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6511 (x_destroy_window, x_delete_display):
6512 Now static.
6513 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6514 (x_mouse_leave): Remove; unused.
6515 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6516 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6517 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6518 Remove decls.
6519 (x_mouse_leave): Declare only if WINDOWSNT.
6520 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6521 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6522 USE_X_TOOLKIT.
6523
1675728f
PE
6524 * ftxfont.c: Make symbols static if they're not exported.
6525 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6526 HAVE_FREETYPE.
6527 * font.h (ftxfont_driver): Likewise.
6528
e4cebfca
PE
6529 * xfns.c: Make symbols static if they're not exported.
6530 (x_last_font_name, x_display_info_for_name):
6531 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6532 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6533 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6534 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6535 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6536 (last_show_tip_args): Now static.
6537 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6538 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6539 (x_screen_planes): Remove; unused.
6540 * dispextern.h (x_screen_planes): Remove decl.
6541
5bf46f05
PE
6542 * dispnew.c: Make symbols static if they're not exported.
6543 * dispextern.h (redraw_garbaged_frames, scrolling):
6544 (increment_row_positions): Remove.
6545 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6546 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6547 Now static.
6548 (redraw_garbaged_frames): Remove; unused.
6549
435f4c28
PE
6550 * xfaces.c: Make symbols static if they're not exported.
6551 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6552 Remove decls.
6553 * xterm.h (defined_color): Remove decls.
6554 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6555 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6556 (menu_face_changed_default, defined_color, free_realized_face):
6557 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6558 (ascii_face_of_lisp_face): Remove; unused.
6559
8524aef3
PE
6560 * xdisp.c: Make symbols static if they're not exported.
6561 * dispextern.h (scratch_glyph_row, window_box_edges):
6562 (glyph_to_pixel_coords, set_cursor_from_row):
6563 (get_next_display_element, set_iterator_to_next):
6564 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6565 (show_mouse_face): Remove decls
6566 * frame.h (message_buf_print): Likewise.
6567 * lisp.h (pop_message, set_message, check_point_in_composition):
6568 Likewise.
6569 * xterm.h (set_vertical_scroll_bar): Likewise.
6570 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6571 (message_buf_print, scratch_glyph_row, displayed_buffer):
6572 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6573 (get_next_display_element, show_mouse_face, window_box_edges):
6574 (frame_to_window_pixel_xy, check_point_in_composition):
6575 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6576 (glyph_to_pixel_coords): Remove; unused.
6577
16390cd2
PE
6578 * dired.c (file_name_completion): Now static.
6579
6580 * dbusbind.c (xd_in_read_queued_messages): Now static.
6581
a25f4dfa
PE
6582 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6583 * data.c (circular_list_error): Remove.
6584
14a9c8df
PE
6585 * commands.h (last_point_position, last_point_position_buffer):
6586 (last_point_position_window): Remove decls.
6587 * keyboard.c: Make these variables static.
6588
04f2d78b
CB
6589 * coding.h (coding, code_convert_region, encode_coding_gap):
6590 Remove decls.
74ab6df5
PE
6591 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6592 (iso_code_class, detect_coding, code_convert_region): Now static.
6593 (encode_coding_gap): Remove; unused.
6594
38dfbee1
PE
6595 * chartab.c (chartab_chars, chartab_bits): Now static.
6596
a2cb4e63
PE
6597 * charset.h (charset_iso_8859_1): Remove decl.
6598 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6599 Now static.
6600
127198fd
PE
6601 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6602 * ccl.c (Vccl_program_table): Now static.
6603 (check_ccl_update): Remove; unused.
6604
d85b608f
PE
6605 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6606 * category.h: ... from here.
6607 * category.c (check_category_table, set_category_set): Now static.
6608
31cd66f3
PE
6609 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6610 * lisp.h: Remove these decls.
6611
c358e587
PE
6612 * buffer.c (buffer_count): Remove unused var.
6613
e78aecca
PE
6614 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6615 so that it's not optimized away.
6616 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6617 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6618 exported only to the debugger.
6619
e192d7d3 6620 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6621 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6622
92470028
PE
6623 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6624 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6625 was inaccessible from Lisp.
6626 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6627 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6628
244ed907
PE
6629 alloc.c: Import and export fewer symbols, and remove unused items.
6630 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6631 is defined.
6632 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6633 it's not optimized away by whole-program optimization.
6634 (message_enable_multibyte, free_misc): Remove.
6635 (catchlist, handlerlist, mark_backtrace):
6636 Declare only if BYTE_MARK_STACK.
6637 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6638 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6639 (message_enable_multibyte): Remove decl.
6640 (free_misc, interval_free_list, float_block, float_block_index):
6641 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6642 (cons_free_list, last_marked_index):
6643 Now static.
6644 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6645 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6646 (mark_backtrace): Define only if BYTE_MARK_STACK.
6647 * xdisp.c (message_enable_multibyte): Now static.
6648
61c2b50e 6649 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6650 This makes it easier for human readers (and static analyzers)
6651 to see whether these variables are used from other modules.
6652 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6653 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6654 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6655 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6656 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6657 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6658 * xmenu.c, xselect.c:
6659 Declare Q* vars static if they are not used in other modules.
6660 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6661 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6662 Remove decls of unexported vars.
6663 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6664
95c82688
PE
6665 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6666
16a97296
PE
6667 Make Emacs functions such as Fatom 'static' by default.
6668 This makes it easier for human readers (and static analyzers)
6669 to see whether these functions can be called from other modules.
6670 DEFUN now defines a static function. To make the function external
6671 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6672 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6673 (Finit_image_library):
16a97296
PE
6674 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6675 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6676 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6677 Remove decls, since these functions are now static.
6678 (Funintern, Fget_internal_run_time): New decls, since these functions
6679 were already external.
95c82688 6680
16a97296
PE
6681 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6682 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6683 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6684 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6685 * keyboard.c, keymap.c, lread.c:
6686 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6687 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6688 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6689 Mark functions with DEFUE instead of DEFUN,
6690 if they are used in other modules.
6691 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6692 decls for now-static functions.
6693 * buffer.h (Fdelete_overlay): Remove decl.
6694 * callproc.c (Fgetenv_internal): Mark as internal.
6695 * composite.c (Fremove_list_of_text_properties): Remove decl.
6696 (Fcomposition_get_gstring): New forward static decl.
6697 * composite.h (Fcomposite_get_gstring): Remove decl.
6698 * dired.c (Ffile_attributes): New forward static decl.
6699 * doc.c (Fdocumntation_property): New forward static decl.
6700 * eval.c (Ffetch_bytecode): New forward static decl.
6701 (Funintern): Remove extern decl; now in .h file where it belongs.
6702 * fileio.c (Fmake_symbolic_link): New forward static decl.
6703 * image.c (Finit_image_library): New forward static decl.
6704 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6705 * intervals.h (Fprevious_property_change):
6706 (Fremove_list_of_text_properties): Remove decls.
6707 * keyboard.c (Fthis_command_keys): Remove decl.
6708 (Fcommand_execute): New forward static decl.
6709 * keymap.c (Flookup_key): New forward static decl.
6710 (Fcopy_keymap): Now static.
6711 * keymap.h (Flookup_key): Remove decl.
6712 * process.c (Fget_process): New forward static decl.
6713 (Fprocess_datagram_address): Mark as internal.
6714 * syntax.c (Fsyntax_table_p): New forward static decl.
6715 (skip_chars): Remove duplicate decl.
6716 * textprop.c (Fprevious_property_change): New forward static decl.
6717 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6718 Now internal.
6719 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6720 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6721
785bbd42
PE
6722 * editfns.c (Fformat): Remove unreachable code.
6723
8b913b57
AS
67242011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6725
6726 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6727 change. (Bug#8496)
6728
a6744a35
EZ
67292011-04-13 Eli Zaretskii <eliz@gnu.org>
6730
6731 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6732 when at ZV. (Bug#8487)
6733
e7974947
AS
67342011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6735
baad03f0
AS
6736 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6737 (Bug#8437)
6738 * keyboard.c (parse_tool_bar_item): Likewise.
6739 * sound.c (sound_cleanup, alsa_close): Likewise.
6740 * termcap.c (tgetent): Likewise.
6741 * xfns.c (x_default_font_parameter): Likewise.
6742 * xsettings.c (read_and_apply_settings): Likewise.
6743
e7974947
AS
6744 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6745 (overrun_check_free): Protoize.
6746
28272684
PE
67472011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6748
6749 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6750 since callers should never pass a negative size.
6751 Change the signature to match that of plain 'read' and 'write'; see
6752 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6753 * lisp.h: Update prototypes of emacs_write and emacs_read.
6754
11997c76
EZ
67552011-04-11 Eli Zaretskii <eliz@gnu.org>
6756
6757 * xdisp.c (redisplay_window): Don't try to determine the character
6758 position of the scroll margin if the window start point w->startp
e896f03c 6759 is outside the buffer's accessible region. (Bug#8468)
11997c76 6760
8a2cbd72
EZ
67612011-04-10 Eli Zaretskii <eliz@gnu.org>
6762
6763 Fix write-region and its subroutines for buffers > 2GB.
6764 * fileio.c (a_write, e_write): Modify declaration of arguments and
6765 local variables to support buffers larger than 2GB.
6766 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6767
6768 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6769 argument, local variables, and return value.
6770
6771 * lisp.h: Update prototypes of emacs_write and emacs_read.
6772
6773 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6774
4073e537 67752011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6776
1ebfdcb6
PE
6777 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6778
b2ded58d
PE
6779 Fix more problems found by GCC 4.6.0's static checks.
6780
7d66342c
PE
6781 * xdisp.c (vmessage): Use a better test for character truncation.
6782
bbf47d44
PE
6783 * charset.c (load_charset_map): <, not <=, for optimization,
6784 and to avoid potential problems with integer overflow.
9248994d 6785 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6786 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6787 * editfns.c (Fformat): Likewise.
1e69125e 6788 * syntax.c (skip_chars): Likewise.
3befa583 6789
e3019616
PE
6790 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6791 This also lets GCC 4.6.0 generate slightly better loop code.
6792
becfa255
PE
6793 * callint.c (Fcall_interactively): <, not <=, for optimization.
6794 (Fcall_interactively): Count the number of arguments produced,
6795 not the number of arguments given. This is simpler and lets GCC
6796 4.6.0 generate slightly better code.
6797
dae0cd48
PE
6798 * ftfont.c: Distingish more carefully between FcChar8 and char.
6799 The previous code passed unsigned char * to a functions like
6800 strlen and xstrcasecmp that expect char *, which does not
6801 conform to the C standard.
6802 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6803 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6804 char * when the C standard requires it.
6805
76032d70
PE
6806 * keyboard.c (read_char): Remove unused var.
6807
eb3f1cc8
PE
6808 * eval.c: Port to Windows vsnprintf (Bug#8435).
6809 Include <limits.h>.
6810 (SIZE_MAX): Define if the headers do not.
6811 (verror): Do not give up if vsnprintf returns a negative count.
6812 Instead, grow the buffer. This ports to Windows vsnprintf, which
6813 does not conform to C99. Problem reported by Eli Zaretskii.
6814 Also, simplify the allocation scheme, by avoiding the need for
6815 calling realloc, and removing the ALLOCATED variable.
6816
70476b54
PE
6817 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6818
12020a9e
PE
6819 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6820 But keep the doprint source code for now, as we might revamp it
6821 and use it again (Bug#8435).
ea6c7ae6
PE
6822 * lisp.h (doprnt): Remove.
6823 * Makefile.in (base_obj): Remove doprnt.o.
6824 * deps.mk (doprnt.o): Remove.
6825
5fdb398c
PE
6826 error: Print 32- and 64-bit integers portably (Bug#8435).
6827 Without this change, on typical 64-bit hosts error ("...%d...", N)
6828 was used to print both 32- and 64-bit integers N, which relied on
6829 undefined behavior.
6830 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6831 New macro.
6832 * lisp.h (error, verror): Mark as printf-like functions.
6833 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6834 Report overflow in size calculations when allocating printf buffer.
6835 Do not truncate output string at its first null byte.
6836 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6837 Truncate the output at a character boundary, since vsnprintf does not
6838 do that.
6839 * charset.c (check_iso_charset_parameter): Convert internal
6840 character to string before calling 'error', since %c now has the
6841 printf meaning.
6842 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6843 overflow when computing char to be passed to 'error'. Do not
6844 pass Lisp_Object to 'error'; pass the integer instead.
6845 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6846 formatted with plain %d.
6847
b189fa66
PE
6848 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6849
bff87ef0
PE
6850 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6851
7e2cac20
PE
6852 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6853
ce4d90b5
PE
6854 * xterm.c (x_catch_errors): Remove duplicate declaration.
6855
266c9547
PE
6856 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6857
79c49ad2
PE
6858 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6859
368f4090
JM
68602011-04-10 Jim Meyering <meyering@redhat.com>
6861
6862 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6863 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6864 return ssize_t not "int", and use size_t as the buffer length.
6865 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6866 * gnutls.h: Update declarations.
6867 * process.c (read_process_output): Use ssize_t, to match.
6868 (send_process): Likewise.
6869
a32d4040
CY
68702011-04-09 Chong Yidong <cyd@stupidchicken.com>
6871
6872 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6873
8546720e 68742011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6875
04f2d78b
CB
6876 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6877 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6878
8546720e
GM
6879 * xterm.c (handle_one_xevent):
6880 * xmenu.c (create_and_show_popup_menu):
6881 * xselect.c (x_decline_selection_request)
6882 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6883
0a2f5c1a 68842011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6885
6886 Fix some uses of `int' instead of EMACS_INT.
6887 * search.c (string_match_1, fast_string_match)
6888 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6889 (scan_buffer, find_next_newline_no_quit)
6890 (find_before_next_newline, search_command, Freplace_match)
6891 (Fmatch_data): Make some `int' variables be EMACS_INT.
6892
6893 * xdisp.c (display_count_lines): 3rd argument and return value now
6894 EMACS_INT. All callers changed.
6895 (pint2hrstr): Last argument is now EMACS_INT.
6896
6897 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6898 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6899 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6900 (decode_coding_utf_16, decode_coding_emacs_mule)
6901 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6902 (decode_coding_ccl, decode_coding_charset)
6903 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6904 (decode_coding_iso_2022, decode_coding_emacs_mule)
6905 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6906 <char_offset, last_offset>: Declare EMACS_INT.
6907 (encode_coding_utf_8, encode_coding_utf_16)
6908 (encode_coding_emacs_mule, encode_invocation_designation)
6909 (encode_designation_at_bol, encode_coding_iso_2022)
6910 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6911 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6912 Declare EMACS_INT.
6913 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6914 (encode_invocation_designation): Last argument P_NCHARS is now
6915 EMACS_INT.
6916 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6917 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6918
6919 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6920 All users changed.
6921
6922 * ccl.c (Fccl_execute_on_string): Declare some variables
6923 EMACS_INT.
6924
8546720e 69252011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6926
6927 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6928
4e19a977
CS
69292011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6930
6931 * process.c (Fformat_network_address): Doc fix.
6932
87302331
R
69332011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6934
6935 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6936
cbb59342
CY
69372011-04-08 Chong Yidong <cyd@stupidchicken.com>
6938
6939 * keyboard.c (read_char): Call Lisp function help-form-show,
6940 instead of using internal_with_output_to_temp_buffer.
6941 (Qhelp_form_show): New var.
e0d38eeb 6942 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6943
6944 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6945
6946 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6947
e67a13ab
CY
69482011-04-06 Chong Yidong <cyd@stupidchicken.com>
6949
04f2d78b
CB
6950 * process.c (Flist_processes): Remove to Lisp.
6951 (list_processes_1): Delete.
e67a13ab 6952
973f782d
EZ
69532011-04-06 Eli Zaretskii <eliz@gnu.org>
6954
7c106b1e
EZ
6955 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6956
973f782d
EZ
6957 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6958
41cf7d1a 69592011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6960
ca23cc88
PE
6961 Fix more problems found by GCC 4.6.0's static checks.
6962
f390e2d5
PE
6963 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6964
42eea0d0
PE
6965 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6966
b69769da 6967 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6968
f9541e84
PE
6969 * xdisp.c (vmessage): Mark as a printf-like function.
6970
13841b55
PE
6971 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6972
c136c10f
PE
6973 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6974
5e2d4a30
PE
6975 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6976 printf-like functions.
6977 (tiff_load): Add casts to remove these marks before passing them
6978 to system-supplied API.
6979
583f48b9
PE
6980 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6981
b25d760e
PE
6982 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6983 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6984 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6985 directly, rather than having caller test rule sign. This avoids
6986 some unnecessary tests.
6987 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6988 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6989 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6990
bc7b6697 6991 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6992 (xfont_open): Avoid unnecessary tests.
bc7b6697 6993
27ccc379
PE
6994 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6995
dcd5c89a
PE
6996 * composite.h, composite.c (composition_gstring_put_cache):
6997 Use EMACS_INT, not int, for length.
6998
b13a45c6
PE
6999 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7000 breaking out part of COMPOSITION_DECODE_RULE.
7001 (COMPOSITION_DECODE_RULE): Use it.
7002 * composite.c (get_composition_id): Remove unused local vars,
7003 by using the new macro.
7004
1e792e4d
PE
7005 * textprop.c (set_text_properties_1): Change while to do-while,
7006 since the condition is always true at first.
7007
dc6c6455 7008 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7009 (interval_deletion_adjustment): Return unsigned value.
7010 All uses changed.
dc6c6455 7011
aba7731a
PE
7012 * process.c (list_processes_1, create_pty, read_process_output):
7013 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7014 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7015 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7016 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7017 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7018
fdfc4bf3
PE
7019 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7020
fca8fe46 7021 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7022 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7023
06a0259a 7024 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7025 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7026 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7027
e7b9e80f
PE
7028 * print.c (print_error_message): Avoid int overflow.
7029
56201685
PE
7030 * font.c (font_list_entities): Redo for clarity,
7031 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7032
78834453 7033 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7034 (font_score): Avoid potential overflow in diff calculation.
78834453 7035
0bc0b309 7036 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7037 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7038
e610eaca
PE
7039 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7040
b895abce
PE
7041 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7042 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7043 can always succeed if overflow has undefined behavior.
7044
1f1d9321 7045 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7046 (wordify): Omit three unnecessary tests.
1f1d9321 7047
c59478bc
PE
7048 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7049 All callers changed. This avoids the need for an unused var.
7050
79b73827
PE
7051 * casefiddle.c (casify_region): Remove var that is set but not used.
7052
a4db5dfe
PE
7053 * dired.c (file_name_completion): Remove var that is set but not used.
7054
43aae36e
PE
7055 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7056
2a47c44d 7057 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7058 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7059
a37c69bf
PE
7060 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7061 Check for integer overflow on size calculations.
7062
328ab8e7
PE
7063 * buffer.c (Fprevious_overlay_change): Remove var that is set
7064 but not used.
7065
e5a2a5cb
PE
7066 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7067 Remove vars that are set but not used.
8d84a6eb 7068 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7069 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7070
a60e5f68
PE
7071 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7072
f661cb61 7073 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7074 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7075
f0397f5a
PE
7076 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7077 that are set but not used.
7078
8664db06 7079 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7080 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7081
6abdaa4a
PE
7082 * xselect.c (x_get_local_selection, x_handle_property_notify):
7083 Remove vars that are set but not used.
7084
0ce7538d 7085 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7086 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7087
9ae848fc
PE
7088 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7089 Remove var that is set but not used.
0b918413
PE
7090 (scroll_bar_windows_size): Now size_t, not int.
7091 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7092 Check for overflow.
9ae848fc 7093
a5a62657
PE
7094 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7095 (map_tty_color) [!defined MSDOS]: Likewise.
7096
5c5cdd39
PE
7097 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7098
66ebf983
PE
7099 * coding.c: Remove vars that are set but not used.
7100 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7101 All callers changed.
7102 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7103 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7104 (decode_coding_charset): Remove vars that are set but not used.
7105
1be4d761
PE
7106 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7107 that is set but not used.
7108
47553fa8
PE
7109 * print.c (print_object): Remove var that is set but not used.
7110
1f7196bf 7111 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7112 The gnulib version avoids calling malloc in the usual case,
7113 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7114 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7115 * filelock.c (current_lock_owner): Likewise.
7116 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7117 * sysdep.c: Include allocator.h, careadlinkat.h.
7118 (emacs_no_realloc_allocator): New static constant.
7119 (emacs_readlink): New function.
fdb61804
PE
7120 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7121 ../lib/careadlinkat.h.
d1fdcab7 7122
f84c17c7
SM
71232011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7124
7125 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7126 first non-nil return value).
7127
ef3862ad
JD
71282011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7129
7130 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7131 if not defined (Bug#8403).
7132
376a7006
JB
71332011-04-02 Juanma Barranquero <lekktu@gmail.com>
7134
7135 * xdisp.c (display_count_lines): Remove parameter `start',
7136 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7137 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7138 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7139 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7140 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7141 and thereabouts. All callers changed.
7142 (get_per_char_metric): Remove parameter `f', unused since
7143 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7144
6ca3801d
JM
71452011-04-02 Jim Meyering <meyering@redhat.com>
7146
7147 do not dereference NULL upon failed strdup
7148 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7149 (ns_get_family): Likewise.
7150
d8e2b5ba
JB
71512011-04-02 Juanma Barranquero <lekktu@gmail.com>
7152
7153 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7154
8c74fcbd
JD
71552011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7156
7157 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7158 later (Bug#8403).
7159
7200d79c
SM
71602011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7161
03408648 7162 Add lexical binding.
7200d79c 7163
03408648
SM
7164 * window.c (Ftemp_output_buffer_show): New fun.
7165 (Fsave_window_excursion):
7166 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7167
7168 * lread.c (lisp_file_lexically_bound_p): New function.
7169 (Fload): Bind Qlexical_binding.
7170 (readevalloop): Remove `evalfun' arg.
7171 Bind Qinternal_interpreter_environment.
7172 (Feval_buffer): Bind Qlexical_binding.
7173 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7174 Mark as dynamic.
7175 (syms_of_lread): Declare `lexical-binding'.
7176
7177 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7178
7179 * keyboard.c (eval_dyn): New fun.
7180 (menu_item_eval_property): Use it.
ca105506
SM
7181
7182 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7183
03408648
SM
7184 * fns.c (concat, mapcar1): Accept byte-code-functions.
7185
7186 * eval.c (Fsetq): Handle lexical vars.
7187 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7188 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7189 (FletX, Flet): Obey lexical binding.
7190 (Fcommandp): Handle closures.
7191 (Feval): New `lexical' arg.
7192 (eval_sub): New function extracted from Feval. Use it almost
7193 everywhere where Feval was used. Look up vars in lexical env.
7194 Handle closures.
7195 (Ffunctionp): Move from subr.el.
7196 (Ffuncall): Handle closures.
7197 (apply_lambda): Remove `eval_flags'.
7198 (funcall_lambda): Handle closures and new byte-code-functions.
7199 (Fspecial_variable_p): New function.
7200 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7201 but without exporting it to Lisp.
23aba0ea 7202
23aba0ea 7203 * doc.c (Fdocumentation, store_function_docstring):
03408648 7204 * data.c (Finteractive_form): Handle closures.
23aba0ea 7205
03408648
SM
7206 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7207 interactive spec.
ba83908c 7208
04f2d78b
CB
7209 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7210 New byte-codes.
03408648
SM
7211 (exec_byte_code): New function extracted from Fbyte_code to handle new
7212 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7213
03408648 7214 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7215
03408648 7216 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7217
e2abce01
JB
72182011-03-31 Juanma Barranquero <lekktu@gmail.com>
7219
7220 * xdisp.c (redisplay_internal): Fix prototype.
7221
63696a73 72222011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7223
63696a73 7224 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7225 (try_scrolling): Use it when setting scroll_limit.
7226 Limit scrolling to 100 screen lines.
63696a73
EZ
7227 (redisplay_window): Even when falling back on "recentering",
7228 position point in the window according to scroll-conservatively,
7229 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7230
7231 (try_scrolling): When point is above the window, allow searching
7232 as far as scroll_max, or one screenful, to compute vertical
7233 distance from PT to the scroll margin position. This prevents
7234 try_scrolling from unnecessarily failing when
7235 scroll-conservatively is set to a value slightly larger than the
7236 window height. Clean up the case of PT below the margin at bottom
7237 of window: scroll_max can no longer be INT_MAX. When aggressive
7238 scrolling is in use, don't let point enter the opposite scroll
7239 margin as result of the scroll.
7240 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7241 threshold of 100 lines for never-recentering scrolling.
7242
e4cc2dfc
JB
72432011-03-31 Juanma Barranquero <lekktu@gmail.com>
7244
7245 * dispextern.h (move_it_by_lines):
7246 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7247 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7248 (message_log_check_duplicate): Remove parameters `prev_bol' and
7249 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7250 (redisplay_internal): Remove parameter `preserve_echo_area',
7251 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7252
7253 * indent.c (Fvertical_motion):
7254 * window.c (window_scroll_pixel_based, Frecenter):
7255 Don't pass `need_y_p' to `move_it_by_lines'.
7256
1c470562
SM
72572011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7258
44f230aa
SM
7259 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7260 steal a few bits to be more compact.
7261 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7262 Remove unneeded casts.
7263
1c470562
SM
7264 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7265
888adce9
ZK
72662011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7267
7268 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7269 binding" message (bug#7967).
7270
f838ed7b
PE
72712011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7272
77861b95
PE
7273 Fix more problems found by GCC 4.6.0's static checks.
7274
de6dbc14
PE
7275 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7276 Remove unused local var.
7277
f838ed7b
PE
7278 * editfns.c (Fmessage_box): Remove unused local var.
7279
792c7b2b
PE
7280 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7281 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7282 Omit unused local vars.
c499e557 7283 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7284 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7285 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7286 Omit unused local var.
7287
ba0165e1
PE
7288 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7289 Don't assume string length fits in int.
32ad8845 7290 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7291 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7292
3c59b4c9
PE
7293 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7294 instead of alloca (Bug#8344).
7295
a3eed478 7296 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7297 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7298
eb4d412d
PE
7299 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7300
1658b401
PE
7301 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7302 concerns.
7303
7304 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7305
7306 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7307
9a2c6e05
PE
7308 * keyboard.c (syms_of_keyboard): Use the same style as later
7309 in this function when indexing through an array. This also
7310 works around GCC bug 48267.
7311
03d0a109
PE
7312 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7313
44f730c8
PE
7314 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7315
fe75f926
PE
7316 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7317 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7318
ffa8c828
PE
7319 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7320 This avoids undefined behavior on integer overflow, and is a bit
7321 more convenient anyway since it is compared to a size_t variable.
7322
c5101a77
PE
7323 Variadic C functions now count arguments with size_t, not int.
7324 This avoids an unnecessary limitation on 64-bit machines, which
7325 caused (substring ...) to crash on large vectors (Bug#8344).
7326 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7327 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7328 All variadic functions and their callers changed accordingly.
c5101a77
PE
7329 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7330 * data.c (arith_driver, float_arith_driver): Likewise.
7331 * editfns.c (general_insert_function): Likewise.
7332 * eval.c (struct backtrace.nargs, interactive_p)
7333 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7334 (funcall_lambda, mark_backtrace): Likewise.
7335 * fns.c (concat): Likewise.
7336 * frame.c (x_set_frame_parameters): Likewise.
7337 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7338 0 if not found, not -1. All callers changed.
7339
dd3f25f7
PE
7340 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7341 (stack_copy_size): Now size_t, not int.
7342 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7343
461c2ab9
JB
73442011-03-28 Juanma Barranquero <lekktu@gmail.com>
7345
7346 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7347 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7348 All callers changed.
7349
7350 * lisp.h (multibyte_char_to_unibyte):
7351 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7352 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7353 * character.h (CHAR_TO_BYTE8):
7354 * cmds.c (internal_self_insert):
7355 * editfns.c (general_insert_function):
7356 * keymap.c (push_key_description):
7357 * search.c (Freplace_match):
7358 * xdisp.c (message_dolog, set_message_1): All callers changed.
7359
f6d62986
SM
73602011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7361
7362 * keyboard.c (safe_run_hook_funcall): New function.
7363 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7364 don't set the hook to nil, but remove the offending function instead.
7365 (Qcommand_hook_internal): Remove, unused.
7366 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7367 Vcommand_hook_internal.
7368
7369 * eval.c (enum run_hooks_condition): Remove.
7370 (funcall_nil, funcall_not): New functions.
7371 (run_hook_with_args): Call each function through a `funcall' argument.
7372 Remove `cond' argument, now redundant.
7373 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7374 (Frun_hook_with_args_until_failure): Adjust accordingly.
7375 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7376
1db5b1ad
JB
73772011-03-28 Juanma Barranquero <lekktu@gmail.com>
7378
7379 * dispextern.h (string_buffer_position): Remove declaration.
7380
7381 * print.c (strout): Remove parameter `multibyte', unused since
7382 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7383
7384 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7385 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7386 All callers changed.
7387
7388 * w32.c (_wsa_errlist): Use braces for struct initializers.
7389
7390 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7391 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7392 All callers changed.
7393 (string_buffer_position): Likewise. Also, make static (it's never
7394 used outside xdisp.c).
7395 (cursor_row_p): Remove parameter `w', unused since
7396 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7397 (decode_mode_spec): Remove parameter `precision', introduced during
7398 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7399 All callers changed.
7400
5ffb62aa
JD
74012011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7402
7403 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7404
461c2ab9 74052011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7406
7407 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7408 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7409 (ns_update_auto_hide_menu_bar): New functions.
7410 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7411 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7412 ns_constrain_all_frames.
7413 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7414 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7415
5c380ffb
JD
74162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7417
7418 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7419
9af30bdf
GM
74202011-03-27 Glenn Morris <rgm@gnu.org>
7421
7422 * syssignal.h: Replace RETSIGTYPE with void.
7423 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7424 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7425 Replace SIGTYPE with void everywhere.
7426 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7427 * s/template.h (SIGTYPE): Remove commented out definition.
7428
e2abce01
JB
74292011-03-26 Eli Zaretskii <eliz@gnu.org>
7430
7431 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7432 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7433
f868cd8a
JB
74342011-03-26 Juanma Barranquero <lekktu@gmail.com>
7435
59eb0929
JB
7436 * w32.c (read_unc_volume): Use parameter `henum', instead of
7437 global variable `wget_enum_handle'.
7438
7439 * keymap.c (describe_vector): Remove parameters `indices' and
7440 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7441 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7442
f868cd8a
JB
7443 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7444
7445 * keyboard.c (timer_check): Remove parameter `do_it_now',
7446 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7447 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7448 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7449
7450 * keyboard.c (read_char):
7451 * w32menu.c (w32_menu_display_help):
7452 * xmenu.c (show_help_event, menu_help_callback):
7453 Adjust calls to `show_help_echo'.
7454
7455 * gtkutil.c (xg_maybe_add_timer):
7456 * keyboard.c (readable_events):
7457 * process.c (wait_reading_process_output):
7458 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7459
7460 * insdel.c (adjust_markers_gap_motion):
7461 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7462 (gap_left, gap_right): Don't call it.
7463
2ecf6fdb
CY
74642011-03-25 Chong Yidong <cyd@stupidchicken.com>
7465
7466 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7467 incurred during fontification.
7468
6b1f9ba4
JB
74692011-03-25 Juanma Barranquero <lekktu@gmail.com>
7470
7471 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7472 (DEFVAR_PER_BUFFER): Don't pass it.
7473
7474 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7475 (scrolling_window): Don't pass it.
7476
0f4a96b5
JB
74772011-03-25 Juanma Barranquero <lekktu@gmail.com>
7478
7479 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7480
7481 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7482 and `suffix'.
7483 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7484 of variables specific to SELinux and computation of `encoded_absname'.
7485
7486 * image.c (XPutPixel): Remove unused variable `height'.
7487
7488 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7489
7490 * unexw32.c (get_section_info): Remove unused variable `section'.
7491
7492 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7493 (system_process_attributes): Remove unused variable `sess'.
7494 (sys_read): Remove unused variable `err'.
7495
7496 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7497 (w32_wnd_proc): Remove unused variable `isdead'.
7498 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7499 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7500 (x_create_tip_frame): Remove unused variable `tem'.
7501
7502 * w32inevt.c (w32_console_read_socket):
7503 Remove unused variable `no_events'.
7504
7505 * w32term.c (x_draw_composite_glyph_string_foreground):
7506 Remove unused variable `width'.
7507
1149507c
JB
75082011-03-24 Juanma Barranquero <lekktu@gmail.com>
7509
7510 * w32term.c (x_set_glyph_string_clipping):
7511 Don't pass uninitialized region to CombineRgn.
7512
9c88f339
JB
75132011-03-23 Juanma Barranquero <lekktu@gmail.com>
7514
7515 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7516 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7517 (Fx_close_connection): Remove unused variable `i'.
7518
7519 * w32font.c (w32font_draw): Return number of glyphs.
7520 (w32font_open_internal): Remove unused variable `i'.
7521 (w32font_driver): Add missing initializer.
7522
7523 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7524 (fill_in_menu): Remove unused variable `items_added'.
7525
7526 * w32term.c (last_mouse_press_frame): Remove static global variable.
7527 (w32_clip_to_row): Remove unused variable `f'.
7528 (x_delete_terminal): Remove unused variable `i'.
7529
7530 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7531 (NOTHING): Remove unused static global variable.
7532 (uniscribe_check_otf): Remove unused variable `table'.
7533 (uniscribe_font_driver): Add missing initializers.
7534
dee091a3
JD
75352011-03-23 Julien Danjou <julien@danjou.info>
7536
7537 * term.c (Fsuspend_tty, Fresume_tty):
7538 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7539 * window.c (temp_output_buffer_show):
7540 * insdel.c (signal_before_change):
7541 * frame.c (Fhandle_switch_frame):
7542 * fileio.c (Fdo_auto_save):
7543 * emacs.c (Fkill_emacs):
7544 * editfns.c (save_excursion_restore):
7545 * cmds.c (internal_self_insert):
7546 * callint.c (Fcall_interactively):
7547 * buffer.c (Fkill_all_local_variables):
7548 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7549 Use Frun_hooks.
0f4a96b5 7550 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7551 unconditionnaly since it does the check itself.
7552
2c520ab5 75532011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7554
c9c49752
PE
7555 Fix more problems found by GCC 4.5.2's static checks.
7556
8abc3f12
PE
7557 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7558 the first time through the loop, since we know p0 < p1 then.
7559 This also avoids a gcc -Wstrict-overflow warning.
7560
a2d26660
PE
7561 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7562 leading to a memory leak, possible in functions like
7563 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7564 of objects (Bug#8318).
a2d26660 7565
916c72e9
PE
7566 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7567 that could (at least in theory) be that large.
7568
19ab8a18
PE
7569 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7570 This is less likely to overflow, and avoids undefined behavior if
7571 overflow does occur. All callers changed. Use strtoul to scan
7572 for the unsigned long integer.
b7cbbd6f
PE
7573 (pint2hrstr): Simplify and tune code slightly.
7574 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7575
f0641eff
PE
7576 * scroll.c (do_scrolling): Work around GCC bug 48228.
7577 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7578
7f650bb9
PE
7579 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7580 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7581 (validate_x_resource_name): Simplify count usage.
7582 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7583
37dd57d1
PE
7584 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7585 fail (Bug#8306).
81e56e61 7586
699979fc 7587 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7588
401bf9b4
PE
7589 * process.c (Fmake_network_process): Use socklen_t, not int,
7590 where POSIX says socklen_t is required in portable programs.
7591 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7592 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7593 (Fmake_network_process, server_accept_connection):
7594 (wait_reading_process_output, read_process_output):
7595 Likewise.
7596
b93aacde
PE
7597 * process.c: Rename or move locals to avoid shadowing.
7598 (list_processes_1, Fmake_network_process):
7599 (read_process_output_error_handler, exec_sentinel_error_handler):
7600 Rename or move locals.
4dc343ee 7601 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7602 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7603 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7604 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7605 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7606
af8a867c 7607 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7608 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7609 Include tparam.h instead, since it declares them.
af8a867c
PE
7610 * cm.h (PC): Remove extern decl; tparam.h now does this.
7611 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7612 * terminfo.c: Include tparam.h, to check interfaces.
7613 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7614 (tparam): Adjust signature to match interface in tparam.h;
7615 this removes some undefined behavior. Check that outstring and len
7616 are zero, which they always are with Emacs.
7617 * tparam.h (PC, BC, UP): New extern decls.
7618
0248044d 7619 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7620 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7621
8ff096c1 7622 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7623 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7624 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7625 (ftfont_list): Remove unused local.
49eaafba
PE
7626 (get_adstyle_property, ftfont_pattern_entity):
7627 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7628 Rename locals to avoid shadowing.
8ff096c1 7629
e2be39f6
PE
7630 * xfont.c (xfont_list_family): Mark var as initialized.
7631
c9735e30
PE
7632 * xml.c (make_dom): Now static.
7633
8f5201ae
PE
7634 * composite.c (composition_compute_stop_pos): Rename local to
7635 avoid shadowing.
b246f932
PE
7636 (composition_reseat_it): Remove unused locals.
7637 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7638 (composition_update_it): Mark var as initialized.
11b61122
PE
7639 (find_automatic_composition): Mark vars as initialized,
7640 with a FIXME (Bug#8290).
8f5201ae 7641
760fbc2c
PE
7642 character.h: Rename locals to avoid shadowing.
7643 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7644 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7645 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7646 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7647 to avoid shadowing.
7648
ff08eb85
PE
7649 * textprop.c (property_change_between_p): Remove; unused.
7650
fc7bf025
PE
7651 * intervals.c (interval_start_pos): Now static.
7652
235d7abc
PE
7653 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7654
44f230aa
SM
7655 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7656 Rename locals to avoid shadowing.
3e7d6594 7657
50060332
PE
7658 * sound.c (wav_play, au_play, Fplay_sound_internal):
7659 Fix pointer signedness.
d01f234b 7660 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7661 (wav_play): Initialize a variable to 0, to prevent undefined
7662 behavior (Bug#8278).
50060332 7663
c4fc4e30
PE
7664 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7665
918436ed
PE
7666 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7667
c939f91b
PE
7668 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7669 clobbering (Bug#8298).
b9c7f648
PE
7670 * sysdep.c (sys_subshell): Likewise.
7671 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7672
6bd8c144
PE
7673 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7674 This should get cleaned up, so that child_setup has the
7675 same signature on all platforms.
7676
7710357c 7677 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7678 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7679
c59da222
CY
76802011-03-22 Chong Yidong <cyd@stupidchicken.com>
7681
7682 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7683 not to be necessary, and produces flickering.
7684
66b87493
GM
76852011-03-20 Glenn Morris <rgm@gnu.org>
7686
7687 * config.in: Remove file.
7688
45b6f6d5
JB
76892011-03-20 Juanma Barranquero <lekktu@gmail.com>
7690
7691 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7692 are now in src/globals.h.
7693 (syms_of_minibuf): Remove spurious & from previous change.
7694
3ec03f7e
LL
76952011-03-20 Leo <sdl.web@gmail.com>
7696
7697 * minibuf.c (completing-read-function): New variable.
7698 (completing-read-default): Rename from completing-read.
7699 (completing-read): Call completing-read-function.
7700
b14e3e21
CY
77012011-03-19 Juanma Barranquero <lekktu@gmail.com>
7702
7703 * xfaces.c (Fx_load_color_file):
7704 Read color file from absolute filename (bug#8250).
7705
f2b726e6
JB
77062011-03-19 Juanma Barranquero <lekktu@gmail.com>
7707
7708 * makefile.w32-in: Update dependencies.
7709
09f6ff02
EZ
77102011-03-17 Eli Zaretskii <eliz@gnu.org>
7711
7712 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7713
29a6015a
PE
77142011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7715
a3a6c54e
PE
7716 Fix more problems found by GCC 4.5.2's static checks.
7717
b766f867
PE
7718 * process.c (make_serial_process_unwind, send_process_trap):
7719 (sigchld_handler): Now static.
7720
be02381c
PE
7721 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7722 That way, the code declares only the vars that it needs.
7723 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7724 * s/cygwin.h (PTY_ITERATION): Likewise.
7725 * s/darwin.h (PTY_ITERATION): Likewise.
7726 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7727
57048744
PE
7728 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7729 * process.c (allocate_pty): Don't declare stb unless it's needed.
7730
7914961c 7731 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7732 (CONSTANTLIM): Remove; unused.
7733 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7734 Define only if needed.
7914961c 7735
b3967b18
PE
7736 * unexelf.c (unexec): Name an expression,
7737 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7738 Use a different way to cause a compilation error if anyone uses
7739 n rather than nn, a way that does not involve shadowing.
73366a00 7740 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7741
29a6015a
PE
7742 * deps.mk (unexalpha.o): Remove; unused.
7743
43cfc33e 7744 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7745 * unexec.h: New file.
ce701a33
PE
7746 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7747 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7748 Depend on unexec.h.
7749 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7750 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7751 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7752 Change as necessary to match prototype in unexec.h.
ce701a33 7753
01f44d5a
PE
7754 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7755 shadowing.
4f63c6bb 7756 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7757
a6670b0b
PE
7758 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7759 Rename locals to avoid shadowing.
7760
cef2010d 7761 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7762 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7763
d4d7173a
PE
7764 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7765
f08b802a
PE
7766 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7767 warning when compiling print.c.
7768
3ddb0639
PE
7769 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7770 instead of using an uninitialized var.
5ad03b97 7771 (font_sort_entities): Mark var as initialized.
3ddb0639 7772
170a2692
PE
7773 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7774
e663c700
PE
7775 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7776 pointers to constants.
89bc529a 7777 (font_parse_fcname): Remove unused vars.
7b81e2d0 7778 (font_delete_unmatched): Now static.
ea838e10 7779 (font_get_spec): Remove; unused.
13a547c6
PE
7780 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7781 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7782 Rename or move locals to avoid shadowing.
e663c700 7783
2a80c887 7784 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7785 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7786
1384fa33 7787 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7788 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7789
8b2c52e9
PE
7790 * alloc.c (mark_backtrace): Move decl from here ...
7791 * lisp.h: ... to here, so that it can be checked.
7792
475545b5 7793 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7794 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7795 (lisp_indirect_variable): Name an expression,
7796 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7797 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7798
b1349114 7799 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7800 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7801 Use const pointer when appropriate.
b1349114 7802
a2928364
PE
7803 * lisp.h (get_system_name, get_operating_system_release):
7804 Move decls here, to check interfaces.
7805 * process.c (get_operating_system_release): Move decl to lisp.h.
7806 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7807 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7808 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7809 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7810 (Fformat_time_string, Fencode_time, Finsert_char):
7811 (Ftranslate_region_internal, Fformat):
7812 Rename or remove local vars to avoid shadowing.
9710023e 7813 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7814
a415e694
PE
7815 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7816 avoid shadowing.
7817
8ef4622d
PE
7818 * lisp.h (eassert): Check that the argument compiles, even if
7819 ENABLE_CHECKING is not defined.
7820
946f9a5b
PE
7821 * data.c (Findirect_variable): Name an expression, to avoid
7822 gcc -Wbad-function-cast warning.
112396d6 7823 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7824 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7825 (Fmake_variable_buffer_local, Fmake_local_variable):
7826 Mark variables as initialized.
52746918 7827 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7828
e5aab7e7 7829 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7830 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7831 Rename locals to avoid shadowing.
dff45157
PE
7832 (mark_stack): Move local variables into the #ifdef region where
7833 they're used.
7bc26fdb
PE
7834 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7835 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7836 needed otherwise.
7837 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7838 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7839 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7840
e5aab7e7
PE
7841 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7842 avoids undefined behavior in theory.
7843
4da60324
PE
7844 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7845
88043301
PE
7846 Use functions, not macros, for up- and down-casing (Bug#8254).
7847 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7848 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7849 to use the following functions instead of these macros.
7850 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7851 EMACS_INT, since callers assume the returned value fits in int.
7852 (upcase1): Likewise, for UPCASE_TABLE.
7853 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7854 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7855 the race-condition problem in the old DOWNCASE.
88043301 7856
19ed5445
PE
7857 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7858 Rename locals to avoid shadowing.
7859 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7860 (regex_compile, re_search_2, re_match_2_internal):
7861 Remove unused local vars.
952db0d7
PE
7862 (FREE_VAR): Rewrite so as not to use empty "else",
7863 which gcc can warn about.
da053e48 7864 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7865 (RETALLOC_IF): Define only if needed.
7866 (WORDCHAR_P): Likewise. This one is never needed, but is used
7867 only in a comment talking about a compiler bug, so put inside
7868 the #if 0 of that comment.
7869 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7870 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7871 Remove; unused.
19ed5445 7872
1f3561e4 7873 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7874 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7875 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7876
ded6f8f7
PE
7877 * search.c (simple_search): Remove unused var.
7878
dbd37a95
PE
7879 * dired.c (compile_pattern): Move decl from here ...
7880 * lisp.h: ... to here, so that it can be checked.
7881 (struct re_registers): New forward decl.
7882
7e47afad
PE
7883 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7884
85f24f61
PE
7885 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7886 All uses changed.
7887 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7888 Rename locals to avoid shadowing.
5671df8f 7889 (Fvertical_motion): Mark locals as initialized.
85f24f61 7890
181aa2be 7891 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7892 (casify_region): Mark local as initialized.
181aa2be 7893
930d429c
PE
7894 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7895
7082eac6
PE
7896 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7897 New macros, so that the caller can use some names other than
7898 gcpro1, gcpro2, etc.
7899 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7900 of the new macros.
7901 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7902 argument, for consistency with GCPRO2_VAR, etc: it is now the
7903 prefix of the variable, not the variable itself. All uses
7904 changed.
38b2c076
PE
7905 * dired.c (directory_files_internal, file_name_completion):
7906 Rename locals to avoid shadowing.
7907
15206ed9
PE
7908 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7909 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7910 dired.c's scmp function, had undefined behavior.
7911 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7912 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7913 * buffer.h: ... to here, because these macros use current_buffer,
7914 and the new implementation with inline functions needs to have
7915 current_buffer in scope now, rather than later when the macros
7916 are used.
7917 (downcase, upcase1): New static inline functions.
7918 (DOWNCASE, UPCASE1): Reimplement using these functions.
7919 This avoids undefined behavior in expressions like
7920 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7921 from race conditions in accessing the global variables
7922 case_temp1 and case_temp2.
7923 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7924 * lisp.h (case_temp1, case_temp2): Remove their decls.
7925 * character.h (ASCII_CHAR_P): Move from here ...
7926 * lisp.h: ... to here, so that the inline functions mentioned
7927 above can use them.
7928
4a6bea26
PE
7929 * dired.c (directory_files_internal_unwind): Now static.
7930
f14b7e14
PE
7931 * fileio.c (file_name_as_directory, directory_file_name):
7932 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7933 Now static.
2893f146
PE
7934 (file_name_as_directory): Use const pointers when appropriate.
7935 (Fexpand_file_name): Likewise. In particular, newdir might
7936 point at constant storage, so make it a const pointer.
fd4ead52 7937 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7938 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7939 signedness issues.
f839df0c
PE
7940 (Fset_file_times, Finsert_file_contents, auto_save_error):
7941 Rename locals to avoid shadowing.
f14b7e14 7942
5716756e 7943 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7944 (Ftry_completion, Fall_completions): Rename or remove locals
7945 to avoid shadowing.
5716756e 7946
b4c3046a
PE
7947 * marker.c (bytepos_to_charpos): Remove; unused.
7948
b45db522
PE
7949 * lisp.h (verify_bytepos, count_markers): New decls,
7950 so that gcc does not warn that these functions aren't declared.
7951
85876d07
PE
7952 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7953 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7954 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7955 (copy_text): Remove unused local var.
85876d07 7956
03d78a21 7957 * filelock.c (within_one_second): Now static.
b3dd38ab 7958 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7959
5df8f01b
PE
7960 * buffer.c (fix_overlays_before): Mark locals as initialized.
7961 (fix_start_end_in_overlays): Likewise. This function should be
7962 simplified by using pointers-to-pointers, but that's a different
7963 matter.
b1d876f1 7964 (switch_to_buffer_1): Now static.
8f54f30a
PE
7965 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7966 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7967
a70072c9 7968 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7969 Fix pointer signedness issue.
edced198
PE
7970 (sys_subshell): Mark local as volatile if checking for lint,
7971 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7972 (MAXPATHLEN): Define only if needed.
a70072c9 7973
a0977c44
PE
7974 * process.c (serial_open, serial_configure): Move decls from here ...
7975 * systty.h: ... to here, so that they can be checked.
7976
a884fdcc
PE
7977 * fns.c (get_random, seed_random): Move extern decls from here ...
7978 * lisp.h: ... to here, so that they can be checked.
7979
604efe86 7980 * sysdep.c (reset_io): Now static.
b8950c94 7981 (wait_for_termination_signal): Remove; unused.
604efe86 7982
38fc62d9
PE
7983 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7984 (copy_keymap_item, append_key, push_text_char_description):
7985 Now static.
1004a21a 7986 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7987 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7988 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7989 (describe_map_tree):
7990 Rename locals to avoid shadowing.
38fc62d9 7991
2f2650da
PE
7992 * keyboard.c: Declare functions static if they are not used elsewhere.
7993 (echo_char, echo_dash, cmd_error, top_level_2):
7994 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7995 (read_char, kbd_buffer_get_event, make_lispy_position):
7996 (make_lispy_event, make_lispy_movement, apply_modifiers):
7997 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7998 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7999 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8000 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8001 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8002
a053e86c 8003 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8004 (mark_kboards): Move decl here ...
8005 * alloc.c (mark_kboards): ... from here.
a053e86c 8006
4752793e
PE
8007 * lisp.h (force_auto_save_soon): New decl.
8008
74f10ca7 8009 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8010 (DEFINE_DUMMY_FUNCTION): New macro.
8011 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8012 Use it.
c03cd23f
PE
8013 (main): Add casts to avoid warnings
8014 if GCC considers string literals to be constants.
74f10ca7 8015
022e70d4
PE
8016 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8017
59d6fe83
PE
8018 * dbusbind.c: Pointer signedness fixes.
8019 (xd_signature, xd_append_arg, xd_initialize):
8020 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8021 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8022 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8023 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8024
78320123
PE
8025 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8026 if GCC considers string literals to be constants.
49cebcca 8027 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8028
35ac2a97
SM
80292011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8030
fb103ca9
SM
8031 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8032 (print_preprocess, print_object): New macro to fix last change.
8033
35ac2a97
SM
8034 * print.c (print_preprocess): Don't forget font objects.
8035
62973b41
JB
80362011-03-16 Juanma Barranquero <lekktu@gmail.com>
8037
8038 * emacs.c (USAGE3): Doc fixes.
8039
0e48bb22
AS
80402011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8041
8042 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8043 structure.
8044
7684e57b
JB
80452011-03-14 Juanma Barranquero <lekktu@gmail.com>
8046
8047 * lisp.h (VWindow_system, Qfile_name_history):
8048 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8049 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8050 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8051
8052 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8053 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8054
8055 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8056 * w32console.c (detect_input_pending, read_input_pending)
8057 (encode_terminal_code):
8058 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8059 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8060 (w32_system_caret_y, Qfile_name_history):
8061 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8062 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8063 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8064 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8065 * w32proc.c (Qlocal, report_file_error):
8066 * w32term.c (Vwindow_system, updating_frame):
8067 * w32uniscribe.c (initialized, uniscribe_font_driver):
8068 Remove unneeded extern declarations.
8069
2aa46d6c
CY
80702011-03-14 Chong Yidong <cyd@stupidchicken.com>
8071
c96bbc66 8072 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8073
cffc6f3b
CY
80742011-03-13 Chong Yidong <cyd@stupidchicken.com>
8075
8076 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8077 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8078 These macros can no longer be used for assignment.
8079
44f230aa
SM
8080 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8081 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8082 (record_buffer_markers, fetch_buffer_markers): New functions for
8083 recording and fetching special buffer markers.
8084 (set_buffer_internal_1, set_buffer_temp): Use them.
8085
8086 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8087
8088 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8089
8090 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8091 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8092
8093 * xdisp.c (hscroll_window_tree):
8094 (reconsider_clip_changes): Use PT instead of BUF_PT.
8095
d251f04b
EZ
80962011-03-13 Eli Zaretskii <eliz@gnu.org>
8097
8098 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8099 $(EMACS_ROOT)/lib/intprops.h.
8100
f0c77cd1
PE
81012011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8102
3eca4629
PE
8103 Fix more problems found by GCC 4.5.2's static checks.
8104
7c86ee98
PE
8105 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8106 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8107 (xg_free_frame_widgets): Make it clear that a local variable is
8108 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8109 (gdk_window_get_screen): Make it clear that this macro is needed
8110 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8111 (int_gtk_range_get_value): New function, which avoids a diagnostic
8112 from gcc -Wbad-function-cast.
8113 (xg_set_toolkit_scroll_bar_thumb): Use it.
8114 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8115 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8116 (get_utf8_string, xg_get_file_with_chooser):
8117 Rename locals to avoid shadowing.
8118 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8119
41729b81
PE
8120 * xgselect.c (xg_select): Remove unused var.
8121
f0c77cd1
PE
8122 * image.c (four_corners_best): Mark locals as initialized.
8123 (gif_load): Initialize transparent_p to zero (Bug#8238).
8124 Mark another local as initialized.
ec6cf4c6 8125 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8126
ce0ad53d 8127 * image.c (clear_image_cache): Now static.
d5d5a617 8128 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8129 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8130 (x_edge_detection): Remove unnecessary cast that
8131 gcc -Wbad-function-cast diagnoses.
2037898d 8132 (gif_load): Fix pointer signedness.
6ae141d6
PE
8133 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8134 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8135
33383987 81362011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8137
d32df629
PE
8138 Improve quality of tests for time stamp overflow.
8139 For example, without this patch (encode-time 0 0 0 1 1
8140 1152921504606846976) returns the obviously-bogus value (-948597
8141 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8142 reports time overflow. See
8143 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8144 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8145 * editfns.c: Include limits.h and intprops.h.
8146 (TIME_T_MIN, TIME_T_MAX): New macros.
8147 (time_overflow): Move earlier, to before first use.
8148 (hi_time, lo_time): New functions, for an accurate test for
8149 out-of-range times.
8150 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8151 (Fget_internal_run_time): Don't assume time_t fits in int.
8152 (make_time): Use list2 instead of Fcons twice.
8153 (Fdecode_time): More accurate test for out-of-range times.
8154 (check_tm_member): New function.
8155 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8156 (lisp_time_argument): Don't rely on undefined left-shift and
8157 right-shift behavior when checking for time stamp overflow.
8be6f318 8158
fe31d94c
PE
8159 * editfns.c (time_overflow): New function, refactoring common code.
8160 (Fformat_time_string, Fdecode_time, Fencode_time):
8161 (Fcurrent_time_string): Use it.
8162
8be6f318
PE
8163 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8164 * dired.c (make_time): Move to ...
8165 * editfns.c (make_time): ... here.
8166 * systime.h: Note the move.
8167
09d9db2c 81682011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8169
126bc0dc
YM
8170 * fringe.c (update_window_fringes): Remove unused variables.
8171
c47cbdfd
YM
8172 * unexmacosx.c (copy_data_segment): Also copy __got section.
8173 (Bug#8223)
8174
7ac80be9
EZ
81752011-03-12 Eli Zaretskii <eliz@gnu.org>
8176
c96bbc66 8177 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8178 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8179 Constify `char *' arguments and their references according to
8180 prototypes in tparam.h.
8181
ecb0f94d 8182 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8183
7ac80be9
EZ
8184 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8185 Adapt all references accordingly.
8186
8187 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8188
ef1fd07e
TT
81892011-03-11 Tom Tromey <tromey@redhat.com>
8190
8191 * buffer.c (syms_of_buffer): Remove obsolete comment.
8192
7ef4b50c
EZ
81932011-03-11 Eli Zaretskii <eliz@gnu.org>
8194
8195 * termhooks.h (encode_terminal_code): Declare prototype.
8196
8197 * msdos.c (encode_terminal_code): Don't declare prototype.
8198
8199 * term.c (encode_terminal_code): Now external again, used by
8200 w32console.c and msdos.c.
8201
44f230aa
SM
8202 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8203 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8204
4b1ec863 82052011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8206
1714f52b 8207 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8208
4b1ec863
PE
8209 * fringe.c (update_window_fringes): Mark locals as initialized
8210 (Bug#8227).
8211 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8212
524c7aa6
PE
8213 * alloc.c (mark_fringe_data): Move decl from here ...
8214 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8215 to check its interface.
8216 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8217
a5c0af81 8218 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8219 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8220 (fontset_font): Mark local as initialized.
a9a06e0b 8221 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8222
b4716021
PE
8223 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8224
811e9bac 8225 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8226 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8227 (x_own_selection, Fx_disown_selection_internal): Rename locals
8228 to avoid shadowing.
8229 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8230
7e3ab302
PE
8231 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8232 so that the caller can use some name other than gcpro1.
8233 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8234 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8235 (Fx_backspace_delete_keys_p):
8236 Use them to avoid shadowing, and rename vars to avoid shadowing.
8237 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8238 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8239 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8240 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8241 Remove unused locals.
7e3ab302
PE
8242 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8243 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8244 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8245 macros.
f78faa98 8246
e2b13473
PE
8247 * xterm.h (x_mouse_leave): New decl.
8248
77f23912
PE
8249 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8250 Remove unused functions.
cdf4ba58
PE
8251 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8252 (x_calc_absolute_position): Now static.
7411c686 8253 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8254 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8255 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8256 unless they are used.
38d0b34a
PE
8257 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8258 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8259 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8260 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8261 (x_error_catcher, x_connection_closed, x_error_handler):
8262 (x_error_quitter, xembed_send_message, x_iconify_frame):
8263 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8264 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8265 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8266
44f230aa
SM
8267 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8268 Rename or move locals to avoid shadowing.
6b463e58 8269 (tty_defined_color, merge_face_heights): Now static.
5967d051 8270 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8271 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8272 does not deduce is never used uninitialized.
73719eba
PE
8273 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8274 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8275
426994c3 8276 * terminal.c (store_terminal_param): Now static.
5489860b 8277
032f1620 8278 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8279 (set_frame_menubar): Remove unused local.
d4323972 8280 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8281 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8282 since they might point to immutable storage.
281585b0
PE
8283 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8284 since it's unused otherwise.
032f1620 8285
367c19e5 8286 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8287 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8288 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8289 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8290 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8291 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8292 does not deduce are never used uninitialized.
70739cbe 8293
07b48fa9
PE
8294 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8295
8868a238 8296 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8297 * window.c (window_loop, size_window):
8298 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8299
7e5cf297 8300 * window.c (display_buffer): Now static.
d6550a9f
PE
8301 (size_window): Mark variables that gcc -Wuninitialized
8302 does not deduce are never used uninitialized.
a586633d
PE
8303 * window.h (check_all_windows): New decl, to forestall
8304 gcc -Wmissing-prototypes diagnostic.
5b555da1 8305 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8306
f6095868
PE
8307 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8308 shadowing.
8309 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8310 Include <limits.h>.
8311 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8312 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8313 (load_charset_map): Mark variables that gcc -Wuninitialized
8314 does not deduce are never used uninitialized.
53df7c11 8315 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8316
f38b440c
PE
8317 * coding.c (coding_set_source, coding_set_destination):
8318 Use "else { /* comment */ }" rather than "else /* comment */;"
8319 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8320 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8321 a block, when the outer 'i' will do.
8322 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8323 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8324 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8325 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8326 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8327 Rename locals to avoid shadowing.
8328 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8329 * coding.c (emacs_mule_char, encode_invocation_designation):
8330 Now static, since they're not used elsewhere.
413bb2db 8331 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8332 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8333 (decode_coding_emacs_mule): Mark variables that gcc
8334 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8335 (detect_coding_iso_2022): Initialize a local variable that might
8336 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8337 this initialization is needed. (Bug#8211)
5f58e762
PE
8338 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8339 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8340 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8341 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8342 Remove unused macros.
f38b440c 8343
232b38b9 8344 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8345 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8346 * character.c (string_count_byte8): Likewise.
232b38b9 8347
fb90da1b
PE
8348 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8349 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8350
fb93dbc2
PE
8351 * chartab.c (copy_sub_char_table): Now static, since it's not used
8352 elsewhere.
5c156ace
PE
8353 (sub_char_table_ref_and_range, char_table_ref_and_range):
8354 Rename locals to avoid shadowing.
bbcd0949 8355 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8356
7d3b3862 8357 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8358 (BIDI_BOB): Remove unused macro.
7d3b3862 8359
6be7d3da
PE
8360 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8361 deduce are never used uninitialized.
c2ed9c8b 8362 * term.c (encode_terminal_code): Likewise.
6be7d3da 8363
75f8807f 8364 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8365
50938595
PE
8366 * tparam.h: New file.
8367 * term.c, tparam.h: Include it.
8368 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8369 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8370 Move these decls to tparam.h, and make them agree with what
8371 is actually in tparam.c. The previous trick of using incompatible
8372 decls in different modules does not conform to the C standard.
8373 All callers of tparam changed to use tparam's actual API.
8374 * tparam.c (tparam1, tparam, tgoto):
8375 Use const pointers where appropriate.
8376
fbceeba2
PE
8377 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8378 * cm.h (struct cm): Likewise.
8379 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8380 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8381 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8382 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8383 (turn_on_face, init_tty): Likewise.
8384 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8385
7f3f1250
PE
8386 * term.c (term_mouse_position): Rename local to avoid shadowing.
8387
e6ca6543
PE
8388 * alloc.c (mark_ttys): Move decl from here ...
8389 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8390
c40f8d15
AS
83912011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8392
8393 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8394
cfe0661d
JB
83952011-03-09 Juanma Barranquero <lekktu@gmail.com>
8396
8397 * search.c (compile_pattern_1): Remove argument regp, unused since
8398 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8399 (compile_pattern): Don't pass it.
8400
0afb4571
J
84012011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8402
8403 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8404 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8405 for ! HAVE_GTK3.
8406 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8407
8408 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8409
8410 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8411 gdk_window_get_screen, gdk_window_get_geometry,
8412 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8413 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8414 (xg_get_pixbuf_from_pixmap): New function.
8415 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8416 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8417 Call xg_get_pixbuf_from_pixmap instead of
8418 gdk_pixbuf_get_from_drawable.
8419 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8420 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8421 (xg_check_special_colors): Use GtkStyleContext and its functions
8422 for HAVE_GTK3.
8423 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8424 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8425 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8426 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8427 Call gtk_widget_get_preferred_size.
0afb4571
J
8428 (xg_frame_resized): gdk_window_get_geometry only takes 5
8429 parameters.
44f230aa
SM
8430 (xg_win_to_widget, xg_event_is_for_menubar):
8431 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8432 (xg_set_widget_bg): New function.
8433 (delete_cb): New function.
895009e1 8434 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8435 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8436 (xg_set_background_color): Call xg_set_widget_bg.
8437 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8438 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8439 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8440 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8441 if ! HAVE_GTK3.
8442 (update_frame_tool_bar): Call gtk_widget_hide.
8443 (xg_initialize): Use GDK_KEY_g.
8444
8445 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8446 if ! HAVE_GTK3
8447 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8448
8449 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8450 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8451 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8452
1c2cc4ef
JB
84532011-03-08 Juanma Barranquero <lekktu@gmail.com>
8454
8455 * w32xfns.c (select_palette): Check success of RealizePalette against
8456 GDI_ERROR, not zero.
8457
33383987 8458See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8459
8460;; Local Variables:
8461;; coding: utf-8
aac0c6e3
MR
8462;; End:
8463
33383987 8464 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8465
8466 This file is part of GNU Emacs.
8467
8468 GNU Emacs is free software: you can redistribute it and/or modify
8469 it under the terms of the GNU General Public License as published by
8470 the Free Software Foundation, either version 3 of the License, or
8471 (at your option) any later version.
8472
8473 GNU Emacs is distributed in the hope that it will be useful,
8474 but WITHOUT ANY WARRANTY; without even the implied warranty of
8475 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8476 GNU General Public License for more details.
8477
8478 You should have received a copy of the GNU General Public License
8479 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.