Auto-commit of loaddefs files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
90ec88df
CY
12011-11-23 Chong Yidong <cyd@gnu.org>
2
3 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4
56e2e794
MR
52011-11-23 Martin Rudalics <rudalics@gmx.at>
6
7 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
8 making another buffer current. (Bug#10114)
9
b6e64c41
GM
102011-11-23 Glenn Morris <rgm@gnu.org>
11
12 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
13
6b21de18
CY
142011-11-23 Chong Yidong <cyd@gnu.org>
15
16 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
17 using it (Bug#5984).
18
b12cd789
EZ
192011-11-22 Eli Zaretskii <eliz@gnu.org>
20
21 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
22 and header-lines, as they don't have one computed for them.
23 (Bug#10098)
24
25 * .gdbinit (prow): Make displayed values more self-explaining.
26 Add row's hash code.
27
261b6fd4
LMI
282011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
29
30 * process.c (wait_reading_process_output): Fix asynchrounous
31 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 32 (wait_reading_process_output): Add comment and URL.
261b6fd4 33
e7cfd277
JD
342011-11-21 Jan Djärv <jan.h.d@swipnet.se>
35
36 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
37
a9b9b7f5
CY
382011-11-21 Chong Yidong <cyd@gnu.org>
39
40 * window.c (Fnext_window, Fprevious_window): Doc fix.
41
b0d15b4f
SM
422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
43
44 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
45
fe7a3057
JB
462011-11-20 Juanma Barranquero <lekktu@gmail.com>
47
48 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
49
d2999b1a
MR
502011-11-20 Martin Rudalics <rudalics@gmx.at>
51
52 * window.c (Fset_window_combination_limit): Rename argument
53 STATUS to LIMIT.
54 (Vwindow_combination_limit): Remove "status" from doc-string.
55
d5ff9cd0
AS
562011-11-20 Andreas Schwab <schwab@linux-m68k.org>
57
58 * m/ibms390.h: Remove.
59 * m/ibms390x.h: Don't include "ibms390.h".
60
a5bb9bd3
SM
612011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
62
63 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
64 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
65
cd1181db
JB
662011-11-20 Juanma Barranquero <lekktu@gmail.com>
67
68 * casetab.c (Fset_case_table):
69 * charset.c (Fcharset_after): Fix typos.
70
615a3b8d 712011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 72
17e845af
PE
73 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
74 Otherwise, valgrind does not work on some platforms.
75 Problem reported by Andreas Schwab in
6a0bf43d
PE
76 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
77 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
78 is set, removing the need for VIRT_ADDRESS_VARIES.
79 (PURE_P): Use a more-efficient implementation that needs just one
80 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
81 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
82 to 4 (xorl, subq, cmpq, setbe).
83 * alloc.c (pure): Always extern now, since that's the
84 VIRT_ADDR_VARIES behavior.
85 (PURE_POINTER_P): Use a single comparison, not two, for
86 consistency with the new puresize.h.
87 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
88 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
89 Remove VIRT_ADDR_VARIES no longer needed.
90
f8fe6f96
EZ
912011-11-19 Eli Zaretskii <eliz@gnu.org>
92
93 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
94 (erase_phys_cursor, update_window_cursor, show_mouse_face)
95 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
96 behave as if the cursor position were at the window margin.
97
98 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
99 and the cursor position is out of bounds, behave as if the cursor
100 position were at the window margin. (Bug#10075)
101
df05a53c
CY
1022011-11-18 Chong Yidong <cyd@gnu.org>
103
104 * window.c (Fwindow_combination_limit): Make first argument
105 non-optional, since it is meaningless for live windows like the
106 selected window.
107
2071918e
DA
1082011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
109
110 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
111
b50a28de
SM
1122011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
113
114 * intervals.c: Fix grafting over the whole buffer (bug#10071).
115 (graft_intervals_into_buffer): Simplify.
116
015137db
EZ
1172011-11-18 Eli Zaretskii <eliz@gnu.org>
118
119 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
120 hash values of the two rows.
121 (copy_row_except_pointers): Preserve the used[] arrays and the
122 hash values of the two rows. (Bug#10035)
68c95424 123 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
124
125 * xdisp.c (row_hash): New function, body extracted from
126 compute_line_metrics.
127 (compute_line_metrics): Call row_hash, instead of computing the
128 hash code inline.
129
130 * dispnew.c (verify_row_hash): Call row_hash for computing the
131 hash code of a row, instead of duplicating code from xdisp.c.
132
133 * dispextern.h (row_hash): Add prototype.
134
a2addb04
TH
1352011-11-18 Tassilo Horn <tassilo@member.fsf.org>
136
137 * frame.c (delete_frame): Don't delete the terminal when the last
138 X frame is closed if emacs is built with GTK toolkit.
139
df85d315
JB
1402011-11-17 Juanma Barranquero <lekktu@gmail.com>
141
142 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
143
a0c2d0ae
MR
1442011-11-17 Martin Rudalics <rudalics@gmx.at>
145
146 * window.c (Vwindow_splits): Rename to
147 Vwindow_combination_resize. Suggested by Juri Linkov.
148 (Fsplit_window_internal): Use Vwindow_combination_resize instead
149 of Vwindow_splits.
150
58179cce
JB
1512011-11-16 Juanma Barranquero <lekktu@gmail.com>
152
7877f373
JB
153 * nsfns.m (Fns_font_name):
154 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 155
b6f67890
MR
1562011-11-16 Martin Rudalics <rudalics@gmx.at>
157
158 * window.h (window): Rename slot "nest" to "combination_limit".
159 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
160 (Fset_window_nest): Rename to Fset_window_combination_limit.
161 (Vwindow_nest): Rename to Vwindow_combination_limit.
162 (recombine_windows, make_parent_window, make_window)
163 (Fsplit_window_internal, saved_window)
164 (Fset_window_configuration, save_window_save): Rename all
165 occurrences of window_nest to window_combination_limit.
166
c7015153
JB
1672011-11-15 Juanma Barranquero <lekktu@gmail.com>
168
169 * image.c (imagemagick_load_image): Fix typo.
170
322ad6ec
EZ
1712011-11-14 Eli Zaretskii <eliz@gnu.org>
172
173 * xdisp.c (display_line): Move the call to
174 highlight_trailing_whitespace before the call to
175 compute_line_metrics, since the latter needs to see the final
176 faces of all the glyphs to compute ROW's hash value. Fixes
177 assertion violations in row_equal_p. (Bug#10035)
178
f067b8ec
JB
1792011-11-14 Juanma Barranquero <lekktu@gmail.com>
180
181 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
182 just return (bug#10044).
183
1e5b2111
EZ
1842011-11-12 Eli Zaretskii <eliz@gnu.org>
185
7ef3cbd5
EZ
186 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
187 with user-defined heap size. Bump the default size of the temacs
188 heap to 27MB, to avoid memory warning when running temacs.
189 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
190
1e5b2111
EZ
191 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
192 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
193 (verify_row_hash) [XASSERTS]: New function.
194 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
195 that the hash value of glyph rows is correct.
1e5b2111 196
89d61221
MR
1972011-11-12 Martin Rudalics <rudalics@gmx.at>
198
199 * window.h (window): Remove splits slot.
200 * window.c (Fwindow_splits, Fset_window_splits): Remove.
201 (Fdelete_other_windows_internal, make_parent_window)
202 (make_window, Fsplit_window_internal, Fdelete_window_internal)
203 (Fset_window_configuration, save_window_save): Don't deal with
204 split status of windows.
205 (saved_window): Remove splits slot.
206 (Vwindow_splits): Rewrite doc-string.
207
97f18cc8
JD
2082011-11-11 Jan Djärv <jan.h.d@swipnet.se>
209
210 * xfns.c (unwind_create_frame):
211 * nsfns.m (unwind_create_frame):
212 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
213 Vframe_list (Bug#9999).
214
22a648b4
DA
2152011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
216
0b381c7e 217 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 218
659afede
KH
2192011-11-11 Kenichi Handa <handa@m17n.org>
220
221 * callproc.c (Fcall_process): Set the member dst_multibyte of
222 process_coding.
223
9ac0394b
KH
2242011-11-11 Johan Bockgård <bojohan@gnu.org>
225
226 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
227 avoid a crash (bug#9496).
228
2fbdc249
CY
2292011-11-09 Chong Yidong <cyd@gnu.org>
230
231 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
232 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
233
ac6b1f81
PE
2342011-11-08 Paul Eggert <eggert@cs.ucla.edu>
235
236 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
237
09db192c
PE
2382011-11-08 Paul Eggert <eggert@cs.ucla.edu>
239
240 Avoid some portability problems by eschewing 'extern inline' functions.
241 The trivial performance wins aren't worth the portability hassles; see
242 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
243 et seq.
244 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
245 (window_box_width, window_box_left, window_box_left_offset)
246 (window_box_right, window_box_right_offset): Undo previous change,
247 by removing the "extern"s.
248 * intervals.c (adjust_intervals_for_insertion)
249 (adjust_intervals_for_deletion): Undo previous change,
250 making these static again.
251 (offset_intervals, temp_set_point_both, temp_set_point)
252 (copy_intervals_to_string): No longer inline.
253 * xdisp.c (window_text_bottom_y, window_box_width)
254 (window_box_height, window_box_left_offset)
255 (window_box_right_offset, window_box_left, window_box_right)
256 (window_box): No longer inline.
257
105216ed
CY
2582011-11-08 Chong Yidong <cyd@gnu.org>
259
260 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
261 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
262 an error if not a live window.
263 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
264 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
265
ae9e237f
JB
2662011-11-07 Juanma Barranquero <lekktu@gmail.com>
267
268 * lisp.h (syms_of_abbrev): Remove declaration.
269 Reported by CHENG Gao <chenggao@royau.me>.
270
c7aa8333
EZ
2712011-11-07 Eli Zaretskii <eliz@gnu.org>
272
273 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
274 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
275 of temacs in GUI mode.
276
be7f5545
MR
2772011-11-07 Martin Rudalics <rudalics@gmx.at>
278
279 * window.h: Declare delete_all_child_windows instead of
280 delete_all_subwindows.
281 * window.c (Fwindow_nest, Fset_window_nest)
282 (Fset_window_new_total, Fset_window_new_normal)
283 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
284 (delete_all_subwindows): Rename to delete_all_child_windows.
285 (Fdelete_other_windows_internal, Fset_window_configuration):
286 Call delete_all_child_windows instead of delete_all_subwindows.
287 * frame.c (delete_frame): Call delete_all_child_windows instead
288 of delete_all_subwindows.
289
ca78dc43
PE
2902011-11-07 Paul Eggert <eggert@cs.ucla.edu>
291
292 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
293 This is also needed for porting to any host where GC_MARK_STACK is
294 not GC_MAKE_GCPROS_NOOPS.
295 (which_symbols): Use it.
296
a0241d01
KH
2972011-11-07 Kenichi Handa <handa@m17n.org>
298
299 * coding.c (coding_set_destination): Check coding->src_pos only
300 when coding->src_object is a buffer (bug#9910).
301
302 * process.c (send_process): Set the member src_multibyte of coding
303 to 0 (bug#9911) when sending a unibyte text.
304
305 * callproc.c (Fcall_process): Set the member src_multibyte of
306 process_coding to 0 (bug#9912).
307
a64bfdfa 3082011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
309
310 * xmenu.c (cleanup_widget_value_tree): New function.
311 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
312 calling free_menubar_widget_value_tree directly (Bug#9830).
313
cb41b32a
PE
3142011-11-06 Paul Eggert <eggert@cs.ucla.edu>
315
316 Fix some portability problems with 'inline'.
317 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
318 (window_box_width, window_box_left, window_box_left_offset)
319 (window_box_right, window_box_right_offset): Declare extern.
320 Otherwise, these inline functions do not conform to C99 and
321 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
322 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
323 * intervals.c (adjust_intervals_for_insertion)
324 (adjust_intervals_for_deletion): Now extern, because otherwise the
325 extern inline functions 'offset_intervals' couldn't refer to it.
326 (static_offset_intervals): Remove.
327 (offset_intervals): Rewrite using the old contents of
328 static_offset_intervals. The old version didn't conform to C99
329 because an extern inline function contained a reference to an
330 identifier with static linkage.
331
b7041366
AS
3322011-11-06 Andreas Schwab <schwab@linux-m68k.org>
333
334 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
335 GC.
336
88a37c4d
EZ
3372011-11-06 Eli Zaretskii <eliz@gnu.org>
338
339 * xdisp.c (init_iterator, reseat_to_string): Don't set the
340 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
341 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
342 return Qleft_to_right.
343
49745b39
CY
3442011-11-06 Chong Yidong <cyd@gnu.org>
345
346 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
347 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
348 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
349 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
350 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
351 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
352 (Fwindow_vscroll): Doc fix.
353 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
354 argument, since it makes no sense to pass a live window and for
355 consistency with window-child.
356
1f05cd82
CS
3572011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
358
359 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
360 support MSVC.
361
22610910
JR
3622011-11-05 Jason Rumney <jasonr@gnu.org>
363
364 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
365 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
366 fonts (Bug#6029).
367 (add_font_entity_to_list): Fix logic errors in mixed boolean and
368 bitwise arithmetic preventing use of unicode-sip and non-truetype
369 opentype fonts.
370
a06776b2
EZ
3712011-11-05 Eli Zaretskii <eliz@gnu.org>
372
3ad924ba
EZ
373 * s/ms-w32.h (fstat, stat, utime): Move redirections to
374 "emacs"-only part.
375
a06776b2
EZ
376 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
377 initialization code to keep similarity to xfns.c after changes
378 from 2011-11-05.
379
c9e7db78
JD
3802011-11-05 Jan Djärv <jan.h.d@swipnet.se>
381
a97f8f3f
JD
382 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
383 (unwind_create_frame): New function (Bug#9943).
384 (Fx_create_frame): Restructure code to be more similar to the one in
385 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
386 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
387 Move terminal->reference_count++ just before making the frame official
388 (Bug#9943).
389
390 * nsterm.m (x_free_frame_resources): New function.
391 (x_destroy_window): Move code to x_free_frame_resources.
392
c9e7db78
JD
393 * xfns.c (unwind_create_frame): Fix comment.
394 (Fx_create_frame, x_create_tip_frame): Move
395 terminal->reference_count++ just before making the frame
396 official. Move initialization of image_cache_refcount and
397 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
398
a6fc3b5c
EZ
3992011-11-05 Eli Zaretskii <eliz@gnu.org>
400
401 Support MSVC build with newer versions of Visual Studio.
402 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
403 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
404 nt/gmake.defs.
405
406 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
407 which are not supported by MSVC.
408 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
409 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
410 bitfields.
411 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
412 types in bitfields.
413 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
414
415 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
416
58179cce 4172011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
418
419 Support MSVC build with newer versions of Visual Studio.
420 * w32.c: Don't include w32api.h for MSVC.
421 (init_environment) [_MSC_VER]: Call sys_access, not _access.
422
423 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
424 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
425 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
426 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
427 e_* cousins.
428 (alloca) [_MSC_VER]: Define to _alloca.
429
430 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
431
432 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
433
a58c13ed
EZ
4342011-11-04 Eli Zaretskii <eliz@gnu.org>
435
436 * xdisp.c (note_mouse_highlight): If either of
437 previous/next-single-property-change returns nil, treat that as
438 the beginning or the end of the buffer. (Bug#9955)
439
fe0b6370
JD
4402011-11-04 Jan Djärv <jan.h.d@swipnet.se>
441
a58c13ed 442 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
443 label is not null (Bug#9951).
444 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
445 may be NULL.
446
89bd5ee1
EZ
4472011-11-04 Eli Zaretskii <eliz@gnu.org>
448
449 * window.c (Fwindow_body_size): Mention in the doc string that the
450 return value is in frame's canonical units. (Bug#9949)
451
84c3edb9
EZ
4522011-11-03 Eli Zaretskii <eliz@gnu.org>
453
4e2fb5c7
EZ
454 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
455
84c3edb9 456 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 457 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 458 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 459
bc17a887
EZ
4602011-11-01 Eli Zaretskii <eliz@gnu.org>
461
462 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
463 Don't stop backward scan on the continuation glyph, even though
464 its CHARPOS is positive.
26b46e51
EZ
465 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
466 cover_string to disp_string.
bc17a887 467
4ee88440
MR
4682011-11-01 Martin Rudalics <rudalics@gmx.at>
469
470 * window.c (temp_output_buffer_show): Don't use
471 Vtemp_buffer_show_specifiers.
472 (Vtemp_buffer_show_specifiers): Remove unused variable.
473
c2ff3c02
EZ
4742011-10-30 Eli Zaretskii <eliz@gnu.org>
475
476 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
477 past the beginning of the current glyph matrix.
478
58179cce 4792011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
480
481 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
482 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
483 HAVE_GTK3 (Bug#9869).
b77a6a7f 484
3b574623
JD
485 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
486 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
487
b77a6a7f
JD
488 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
489
490 * xterm.c: Declare x_handle_net_wm_state to return int.
491 (handle_one_xevent): Check if we are iconified but don't have
492 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
493 (get_current_wm_state): Return non-zero if not hidden,
494 check for _NET_WM_STATE_HIDDEN (Bug#9893).
495 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
496 (x_handle_net_wm_state): Return what get_current_wm_state returns.
497 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
498
196e41e4
PE
4992011-10-29 Paul Eggert <eggert@cs.ucla.edu>
500
501 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
502 so that this new function doesn't get optimized away by a
503 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
504
021f2e1a
AS
5052011-10-29 Andreas Schwab <schwab@linux-m68k.org>
506
507 * frame.h (MOUSE_HL_INFO): Remove excess parens.
508
8b058d44
EZ
5092011-10-29 Eli Zaretskii <eliz@gnu.org>
510
511 Fix the `xbytecode' command.
512 * .gdbinit (xprintbytestr): New command.
b50a28de 513 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
514 (xbytecode): Print the byte-code string as well.
515
4452fb80
EZ
5162011-10-29 Kim Storm <storm@cua.dk>
517
8b058d44
EZ
518 * alloc.c (which_symbols): New function.
519
21b72067
AS
5202011-10-29 Andreas Schwab <schwab@linux-m68k.org>
521
522 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
523 line. (Bug#9903)
524
83ed7b5c
GM
5252011-10-29 Glenn Morris <rgm@gnu.org>
526
527 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
528 Not clear what it was for, and it causes various bugs. (Bug#9839)
529
5a7a728b
EZ
5302011-10-28 Eli Zaretskii <eliz@gnu.org>
531
532 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
533 possible random value that matches one of those tested as
534 condition to clear the mouse face.
535
d3d0842f
CY
5362011-10-28 Chong Yidong <cyd@gnu.org>
537
538 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
539
31b39d13
DN
5402011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
541
542 * window.c (make_window): Initialize phys_cursor_on_p.
543
9aba6043
SM
5442011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
545
546 * lisp.h (struct Lisp_Symbol): Update comments.
547
c20992f4
JB
5482011-10-28 Juanma Barranquero <lekktu@gmail.com>
549
550 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
551
db4f02f2
EZ
5522011-10-28 Eli Zaretskii <eliz@gnu.org>
553
554 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
555 <oslsachem@gmail.com> for helping to debug this.
556
557 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
558 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
559 (g_b_init_get_glyph_outline_w): New static variables.
560 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
561 (GetGlyphOutlineW_Proc): New typedefs.
562 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
563 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
564 New functions.
565 (w32font_open_internal, compute_metrics):
566 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
567 instead of calling the "wide" APIs directly.
568
569 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
570
571 * w32.h (syms_of_w32font): Add prototype.
572
87e68db4
JB
5732011-10-27 Juanma Barranquero <lekktu@gmail.com>
574
575 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
576 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
577 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
578 (Fmove_to_window_line): Doc fix.
579
435c1d67
CY
5802011-10-27 Chong Yidong <cyd@gnu.org>
581
582 * process.c (make_process): Set gnutls_state to NULL.
583
584 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
585 non-NULL, regardless of GNUTLS_INITSTAGE.
586 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
587 an error. Set process slots as soon as we allocate them.
588
589 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
590
9c6c6f49
CY
5912011-10-27 Chong Yidong <cyd@gnu.org>
592
9aba6043
SM
593 * gnutls.c (emacs_gnutls_deinit): New function.
594 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
595 (Fgnutls_deinit, Fgnutls_boot): Use it.
596
597 * process.c (make_process): Initialize GnuTLS credentials to NULL.
598 (deactivate_process): Call emacs_gnutls_deinit.
599
657d08d3
JB
6002011-10-27 Juanma Barranquero <lekktu@gmail.com>
601
602 * image.c (x_create_x_image_and_pixmap):
603 * w32.c (sys_rename, w32_delayed_load):
604 * w32font.c (fill_in_logfont):
605 * w32reg.c (x_get_string_resource): Silence compiler warnings.
606
5430d399
JB
6072011-10-26 Juanma Barranquero <lekktu@gmail.com>
608
609 * w32fns.c (w32_default_color_map): New function,
610 extracted from Fw32_default_color_map.
a7ef684b 611 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 612
fe0055fa
PE
6132011-10-25 Paul Eggert <eggert@cs.ucla.edu>
614
615 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
616
e6346438
SM
6172011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
618
619 * keyboard.c (test_undefined): New function (bug#9751).
620 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
621
e112cc37
ET
6222011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
623
624 * sysdep.c (init_sys_modes): Fix the check for the controlling
625 terminal (Bug#6649).
626
7b5d6677
EZ
6272011-10-20 Eli Zaretskii <eliz@gnu.org>
628
629 * dispextern.h (struct bidi_it): New member next_en_type.
630
631 * bidi.c (bidi_line_init): Initialize the next_en_type member.
632 (bidi_resolve_explicit_1): When next_en_pos is valid for the
633 current character, check also for next_en_type being WEAK_EN.
634 (bidi_resolve_weak): Don't enter the expensive loop if the current
635 position is before next_en_pos. Record the bidi type of the first
636 non-ET, non-BN character we find, in addition to its position.
637 (bidi_level_of_next_char): Invalidate next_en_type when
638 next_en_pos is over-stepped.
639
7da0b018
PE
6402011-10-20 Paul Eggert <eggert@cs.ucla.edu>
641
642 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
643 * editfns.c: Rewrite current-time-zone so that it invokes
644 the equivalent of (format-time-string "%Z") to get the time zone name.
645 This fixes a bug when the time zone name contains characters that
646 need converting from the system time locale to Emacs internal format.
647 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
648 that patch fixed format-time-string to do the conversion, but
649 I forgot to fix current-time-zone.
650 (format_time_string): New function, containing most of
651 what Fformat_time_string used to contain.
652 (Fformat_time_string): Rewrite in terms of format_time_string.
653 This doesn't change this function's behavior.
654 (current-time-zone): Rewrite to use format_time_string.
655 This fixes the bug reported by Michael Schierl in
656 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
657 Jason Rumney's 2007-06-07 change worked around this bug, but
658 didn't fix it.
659 * systime.h (tzname, timezone): Remove no-longer-used declarations.
660
8547b010
EZ
6612011-10-19 Eli Zaretskii <eliz@gnu.org>
662
663 * xdisp.c (start_display): If the character at POS is displayed
664 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
665 (try_window_reusing_current_matrix): If a line ends in a display
666 vector or the next line starts in a display vector, continue
667 redrawing the window even though the character position of
668 start_row was reached.
8547b010
EZ
669 (Bug#9771, part 2)
670
4e948d15
CY
6712011-10-18 Chong Yidong <cyd@gnu.org>
672
673 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
674 with nobreak-char-display too.
675
4787455f
EZ
6762011-10-18 Eli Zaretskii <eliz@gnu.org>
677
678 Fix part 3 of bug#9771.
679 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
680 (bidi_resolve_neutral): Don't enter the expensive loop looking for
681 non-neutral characters if the current character is a paragraph
682 separator (a.k.a. Newline). This avoids running the same
683 expensive loop twice, once when we consume the preceding newline
684 and the other time when the line actually needs to be displayed.
685 Avoid the loop when we see neutrals on the base embedding level
686 following a character whose directionality is the same as the
687 paragraph's. This avoids running the expensive loop when a line
688 ends in a long sequence of neutrals, like control characters.
689 Add assertion against STRONG_AL type. Slightly rearrange code
690 that determines the type of a neutral given the first non-neutral
691 that follows it.
692 (bidi_level_of_next_char): Set next_en_pos to zero when
693 invalidating its info.
694
2c91f553
EZ
6952011-10-17 Eli Zaretskii <eliz@gnu.org>
696
697 * xdisp.c (push_display_prop): Determine whether to record string
698 or buffer position by IT->string, not by IT->method. Allow
699 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
700 (move_it_vertically_backward): Don't look for character position
701 immediately after the newline when in a continuation line.
702 (Bug#9771, part 1)
2c91f553 703
c7b08b0d
MR
7042011-10-15 Martin Rudalics <rudalics@gmx.at>
705
706 * window.c (coordinates_in_window): Rewrite and delabelize
707 vertical border check. (Bug#5357) (Bug#9618)
708
6b02f655
SM
7092011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
710
711 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
712 errors in XSetWindowBorder (bug#9310).
713
81d40c92
DA
7142011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
715
716 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
717 avoid crash when xmalloc overrun checking is enabled.
718
d4172c3b
EZ
7192011-10-13 Eli Zaretskii <eliz@gnu.org>
720
721 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
722 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
723 cursor motion with <left> and <right> arrow keys.
724
725 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
726 some callers set that themselves.
727
b00eea75
EZ
7282011-10-12 Eli Zaretskii <eliz@gnu.org>
729
730 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
731 display string and the previous row comes from the same string and
732 is empty. (Bug#9739) (Bug#9738)
733
8fe012c4
SM
7342011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
735
736 * doc.c (get_doc_string): Encode file name (bug#9735).
737
0074aef2
EZ
7382011-10-12 Eli Zaretskii <eliz@gnu.org>
739
79beb178
EZ
740 * bidi.c (bidi_level_of_next_char):
741 * xdisp.c (get_visually_first_element): Remove old incorrect
742 comments regarding the Unicode Line Separator character.
743
0074aef2
EZ
744 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
745
6e4b3fbe
DA
7462011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
747
748 * alloc.c (Fgc_status): Do not access beyond zombies array
749 boundary if nzombies > MAX_ZOMBIES.
750 * alloc.c (dump_zombies): Add missing format specifier.
751
0324f3af
PE
7522011-10-12 Paul Eggert <eggert@cs.ucla.edu>
753
b5525cac
PE
754 * xdisp.c (set_cursor_from_row): Simplify conditionals,
755 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
756
0324f3af
PE
757 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
758 Some packages use them to denote characters with modifiers.
759
e9b5f888
AS
7602011-10-11 Andreas Schwab <schwab@linux-m68k.org>
761
762 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
763 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
764 matching a pp-number. Rename parameter var to var1.
765
127827c0
SM
7662011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
767
768 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
769
c8fd3bd0
GM
7702011-10-08 Glenn Morris <rgm@gnu.org>
771
772 * callint.c (Fcall_interactively): Give a more explicit error for the
773 'c' case with a non-character input. (Bug#8479)
774
352ec8ff
EZ
7752011-10-08 Eli Zaretskii <eliz@gnu.org>
776
03669ccb
EZ
777 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
778 lines.
7061c986
EZ
779 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
780 lines that are hscrolled on the left.
03669ccb 781
352ec8ff
EZ
782 * dispnew.c (buffer_posn_from_coords): Account for a possible
783 presence of header-line. (Bug#4426)
784
a66cfb1c
SM
7852011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
786
6b02f655
SM
787 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
788 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 789
7c5ee88e
PE
7902011-10-07 Paul Eggert <eggert@cs.ucla.edu>
791
792 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
793 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
794 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
795 this makes Emacs dump core during garbage collection on rare
796 occasions. sizeof is obviously inferior to offsetof here, so
797 stick with offsetof.
798 (GC_POINTER_ALIGNMENT): New macro.
799 (mark_memory): Omit 3rd (offset) arg; caller changed.
800 Don't assume EMACS_INT alignment is the same as pointer alignment.
801
df1bbe5b
SM
8022011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
803
804 * keyboard.c (read_key_sequence_remapped): New var.
805 (read_key_sequence): Compute remapping in the right buffer.
806 (command_loop_1): Use read_key_sequence's remapping directly.
807
51553db6
SM
8082011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
809
32c1fffd
SM
810 * dired.c (file_name_completion): Don't expand file name.
811 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
812 before checking file name handler.
813
51553db6
SM
814 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
815 they've been requested explicitly (bug#9591).
816
b6bd1599 8172011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
818
819 * keymap.c (Fsingle_key_description): Use make_specified_string
820 instead of build_string to build string from push_key_description.
821 (Bug#5193)
822
f701dc2a
PE
8232011-09-30 Paul Eggert <eggert@cs.ucla.edu>
824
4222c55d
PE
825 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
826 This fixes a Y2038 bug on 64-bit hosts.
827 * buffer.c (reset_buffer):
828 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
829 (Fclear_buffer_auto_save_failure):
830 Use 0, not -1, to represent an unset failure time, since time_t
831 might not be signed.
832
f701dc2a
PE
833 Remove dependency on glibc malloc internals.
834 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
835 Move back here from lisp.h, but with their new implementations.
836 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
837 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
838 * charset.c (charset_table_init): New static var.
839 (syms_of_charset): Use it instead of xmalloc. This removes a
840 dependency on glibc malloc internals. See Eli Zaretskii's comment in
841 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
842 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
843 Move back to alloc.c.
844 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
845 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
846
9ceebf39
JD
8472011-09-30 Jan Djärv <jan.h.d@swipnet.se>
848
849 * nsterm.m (windowDidResize): Call x_set_window_size only when
850 ns_in_resize is true. Otherwise set pixelwidth/height and
851 call change_frame_size (Bug#9628).
852
cb993c58
PE
8532011-09-30 Paul Eggert <eggert@cs.ucla.edu>
854
3930c88b
PE
855 Port --enable-checking=all to Fedora 14 x86-64.
856 * charset.c (syms_of_charset): Also account for glibc malloc's
857 internal overhead when calculating the initial malloc maximum.
858
cb993c58
PE
859 Port --enable-checking=all to Fedora 14 x86.
860 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
861 Move to lisp.h.
862 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
863 (overrun_check_realloc, overrun_check_free):
864 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
865 That way, xmalloc returns a properly-aligned pointer even if
866 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
867 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
868 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
869 into account when calculating the initial malloc maximum.
870 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
871 Move here from alloc.c, so that charset.c can use it too.
872 Properly align; the old code wasn't right for common 32-bit hosts
873 when configured with --enable-checking=all.
874 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
875 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
876
31bed486
EZ
8772011-09-29 Eli Zaretskii <eliz@gnu.org>
878
04c70788 879 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
880 use EDOM.
881
fbcaa2f3
EZ
8822011-09-28 Eli Zaretskii <eliz@gnu.org>
883
884 * xdisp.c (compute_display_string_end): If there's no display
885 string at CHARPOS, return -1.
886
887 * bidi.c (bidi_fetch_char): When compute_display_string_end
888 returns a negative value, treat the character as a normal
889 character not covered by a display string. (Bug#9624)
890
a239d4e9
JB
8912011-09-28 Juanma Barranquero <lekktu@gmail.com>
892
893 * lread.c (Fread_from_string): Fix typo in docstring.
894
88652fd5
EZ
8952011-09-27 Eli Zaretskii <eliz@gnu.org>
896
897 * xdisp.c (handle_invisible_prop): If invisible text ends on a
898 newline, reseat the iterator instead of bidi-iterating there one
899 character at a time. (Bug#9610)
32c1fffd
SM
900 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
901 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 902
ed497dd4
AS
9032011-09-27 Andreas Schwab <schwab@linux-m68k.org>
904
905 * lread.c (readevalloop): Use correct code for NBSP.
906 (read1): Likewise. (Bug#9608)
907
b2bf61aa
MA
9082011-09-25 Michael Albinus <michael.albinus@gmx.de>
909
910 * dbusbind.c (Fdbus_register_signal): When service is not
911 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
912
32bbb17c
GM
9132011-09-25 Glenn Morris <rgm@gnu.org>
914
915 * buffer.c (truncate-lines): Doc fix.
916
94e0933e
CY
9172011-09-24 Chong Yidong <cyd@stupidchicken.com>
918
919 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
920 (Fset_window_next_buffers): Doc fix.
921
cddde921
GM
9222011-09-24 Glenn Morris <rgm@gnu.org>
923
924 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
925
1260aef1
PE
9262011-09-24 Paul Eggert <eggert@cs.ucla.edu>
927
25b4bfa0
PE
928 Fix minor problems found by static checking.
929 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
930 * indent.c (Fvertical_motion): Fix == vs = typo.
931
e3cbd34b
EZ
9322011-09-24 Eli Zaretskii <eliz@gnu.org>
933
a66cfb1c
SM
934 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
935 Default value is now t. Doc fix.
6bf7006f 936
e3cbd34b 937 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 938 logic when moving up, not only when moving down. Fix the
e3cbd34b 939 confusing name and values of the it_overshoot_expected variable;
32c1fffd 940 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
941
942 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
943 CHARPOS is covered by a display string which includes newlines.
944 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
945 is covered by a display string with embedded newlines.
946
a3de0cbd
MA
9472011-09-24 Michael Albinus <michael.albinus@gmx.de>
948
949 * dbusbind.c (Fdbus_register_signal): Add match rule to
950 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
951 (Fdbus_register_method, Vdbus_registered_objects_table):
952 Fix docstring.
a3de0cbd 953
b260039d
JM
9542011-09-24 Jim Meyering <meyering@redhat.com>
955
32c1fffd 956 do not ignore write error for any output size
b260039d
JM
957 The previous change was incomplete.
958 While it makes emacs --batch detect the vast majority of stdout
959 write failures, errors were still ignored whenever the output size is
960 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
961 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
962 && echo FAIL: ignored write error
963 FAIL: ignored write error
964 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
965 && echo FAIL: ignored write error
966 FAIL: ignored write error
967 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
968
8eca8a7c
AS
9692011-09-23 Andreas Schwab <schwab@linux-m68k.org>
970
971 * emacs.c (Fkill_emacs): In noninteractive mode exit
972 non-successfully if a write error occurred on stdout. (Bug#9574)
973
3341db62
EZ
9742011-09-21 Eli Zaretskii <eliz@gnu.org>
975
976 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
977 the xassert test.
978
979 * dispextern.h (struct it): Update the comment documenting what
980 can it->OBJECT be.
981
8c203dbf
EZ
9822011-09-20 Eli Zaretskii <eliz@gnu.org>
983
984 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
985 a display string, extend search for cursor position to end of row.
986 (find_row_edges): If the row ends in a newline from a display
987 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
988 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
989 (Fcurrent_bidi_paragraph_direction): Fix search for previous
990 non-empty line. Fixes confusing cursor motion with arrow keys at
991 the beginning of a line that starts with whitespace.
8c203dbf 992
a4824228
LMI
9932011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
994
995 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
996 (bug#9493).
997
33ed493b
CY
9982011-09-18 Chong Yidong <cyd@stupidchicken.com>
999
1000 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1001 boolean (Bug#9154).
1002
56cd55c8
EZ
10032011-09-18 Eli Zaretskii <eliz@gnu.org>
1004
1005 * xdisp.c (display_line): Record maximum and minimum buffer
1006 positions even if no glyphs were produced (e.g., by a zero-width
1007 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1008 buffer positions that will be removed from the glyph row because
1009 they don't fit.
c02dcedf
EZ
1010 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1011 column is beyond frame width: don't subtract 1 "pixel" when
1012 computing width of the stretch.
3e62b7e0
EZ
1013 (reseat_at_next_visible_line_start): Undo the change made on
1014 2011-09-17 that saved paragraph information and restored it after
1015 the call to `reseat'. (Bug#9545)
56cd55c8 1016
5ed99d36 10172011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1018
1019 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1020 and turn window cursor on if cleared (Bug#9415).
1021
5ed99d36 10222011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1023
1024 * search.c (boyer_moore): Take unibyte characters from pattern
1025 literally. (Bug#9458)
1026
9bade7b2
EZ
10272011-09-18 Eli Zaretskii <eliz@gnu.org>
1028
1029 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1030
e5e9d610
PE
10312011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1032
87e4427a
PE
1033 Fix minor problem found by static checking.
1034 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1035 initialized, to pacify gcc -Wuninitialized.
1036
e5e9d610
PE
1037 * fileio.c: Report proper errno when syscall falls.
1038 (Finsert_file_contents): Save and restore errno,
1039 so that report_file_error outputs the correct diagnostic.
1040 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1041
a1674f0b
EZ
10422011-09-18 Eli Zaretskii <eliz@gnu.org>
1043
1044 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1045
fbfb6dd4
EZ
10462011-09-17 Eli Zaretskii <eliz@gnu.org>
1047
1048 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1049 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1050
bb187662
EZ
10512011-09-17 Eli Zaretskii <eliz@gnu.org>
1052
1137e8b8 1053 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1054 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1055
1056 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1057 (bidi_find_paragraph_start): Search back for paragraph beginning
1058 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1059 (bidi_move_to_visually_next): Only trigger paragraph-related
1060 computations when the last character is a newline or at EOB, not
1061 just any NEUTRAL_B. (Bug#9470)
1062
bb187662
EZ
1063 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1064 truncated lines if point is covered by a display string. (Bug#9524)
1065
2e621251
PE
10662011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1067
1068 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1069 (cons_to_x_long): New function.
1070 (lisp_data_to_selection_data): Use it. Correct the test for
1071 short-versus-long data; it was negated. Break out of vector
1072 loop, for efficiency, when a long datum is discovered.
1073
91a15bc6
SM
10742011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1075
1076 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1077
b41c3a35
EZ
10782011-09-16 Eli Zaretskii <eliz@gnu.org>
1079
1080 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1081 GCC PR/17406) by declaring this function with external scope.
1082
7812ba2d
PE
10832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1084
1085 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1086 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1087
cf7edc2a
AS
10882011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1089
1090 * editfns.c (Fformat): Correctly handle text properties on "%%".
1091
bd01620e
EZ
10922011-09-15 Eli Zaretskii <eliz@gnu.org>
1093
1094 * xterm.c (x_draw_composite_glyph_string_foreground):
1095 * w32term.c (x_draw_composite_glyph_string_foreground):
1096 * term.c (encode_terminal_code):
1097 * composite.c (composition_update_it, get_composition_id):
1098 * xdisp.c (get_next_display_element)
1099 (fill_composite_glyph_string): Add comments about special meaning
1100 of TAB characters in a composition.
1101
a02719a3
PE
11022011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1103
1104 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1105 This occurs when processing a multibyte format.
1106 Problem reported by Wolfgang Jenker.
a02719a3 1107
72589a3c
JB
11082011-09-15 Johan Bockgård <bojohan@gnu.org>
1109
1110 * xdisp.c (try_cursor_movement): Only check for exact match if
1111 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1112
1c14176c
PE
11132011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1114
1115 Remove unused external symbols.
1116 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1117 * xdisp.c (calc_pixel_width_or_height): Now static.
1118 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1119 * indent.c (check_display_width):
1120 * w32term.c: Fix comment to match code.
1121 * xterm.c, xterm.h (x_catching_errors): Remove.
1122
d2eea5b5
PE
11232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1124
1125 * xselect.c: Use signed conversions more consistently (Bug#9498).
1126 (selection_data_to_lisp_data): Assume incoming selection data are
1127 signed integers, not unsigned. This is to be consistent with
1128 outgoing selection data, which was modified to use signed integers
1129 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1130 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1131 expects long, not unsigned long.
1132
46888499
EZ
11332011-09-14 Eli Zaretskii <eliz@gnu.org>
1134
1135 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1136 computation of loop end. Reported by Johan Bockgård
1137 <bojohan@gnu.org>.
1138
ef8ef9fb
CY
11392011-09-13 Chong Yidong <cyd@stupidchicken.com>
1140
1141 * frame.c (Fother_visible_frames_p): Function deleted.
1142
fa819fed
EZ
11432011-09-12 Eli Zaretskii <eliz@gnu.org>
1144
1145 * indent.c (compute_motion): Process display vector front to back
1146 rather than the other way around. (Bug#2496)
1147
2ba8e008
SM
11482011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1149
1150 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1151
20f53c69
CY
11522011-09-11 Chong Yidong <cyd@stupidchicken.com>
1153
1154 * minibuf.c (Fread_from_minibuffer): Doc fix.
1155
d562d7a4
EZ
11562011-09-11 Eli Zaretskii <eliz@gnu.org>
1157
1158 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1159 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1160
1c4d7f3d
LMI
11612011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1162
1163 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1164 value for non-existent files.
1165
b885bf36
EZ
11662011-09-11 Eli Zaretskii <eliz@gnu.org>
1167
1168 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1169 set its "size" to -1. This will set the modtime_size field of
1170 the corresponding buffer to -1, which is what
1171 verify-visited-file-modtime expects for files that do not exist.
1172 (Bug#9139)
1173
6612f0bf
PE
11742011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1175
1176 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1177 here ...
1178 * lisp.h: ... from here. push_key_description is no longer
1179 defined in keyboard.c, so its declaration should not be in
1180 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1181 logically belongs with push_key_description.
1182
dfb3f755
PE
11832011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 * buffer.h: Include <sys/types.h> instead of <time.h>.
1186 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1187 Problem reported by Herbert J. Skuhra.
1188
3134906c
LMI
11892011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1190
1191 * xml.c (parse_region): Make the parsing work for
1192 non-comment-starting XML files again (bug#9144).
1193
8d903f4e
AS
11942011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1195
1196 * image.c (gif_load): Fix calculation of bottom and right corner.
1197 (Bug#9468)
1198
80ad64f4
EZ
11992011-09-10 Eli Zaretskii <eliz@gnu.org>
1200
1201 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1202 redisplay in small windows.
1203
208a048d
EZ
12042011-09-09 Eli Zaretskii <eliz@gnu.org>
1205
1206 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1207
9b1c252e
MR
12082011-09-08 Martin Rudalics <rudalics@gmx.at>
1209
1210 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1211 Operate on live windows only.
1212
2949f33b
JB
12132011-09-08 Juanma Barranquero <lekktu@gmail.com>
1214
1215 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1216
e08dcafd
EZ
12172011-09-07 Eli Zaretskii <eliz@gnu.org>
1218
1219 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1220 only under bidi iteration.
1221
115b96bd
JD
12222011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1223
1224 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1225
c8199d0f
PE
12262011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1229 Without this fix, the command to link temacs failed due to an
1230 undefined symbol __builtin_isnan. This is because
1231 /usr/include/iso/math_c99.h #defines isnan(x) to
1232 __builtin_isnan(x), but the bundled gcc, which identifies itself
1233 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1234 a __builtin_isnan.
1235 * floatfns.c (isnan): #undef, and then #define to a clone of
1236 what's in data.c.
1237 (Fisnan): Always define, since it's always available now.
1238 (syms_of_floatfns): Always define isnan at the Lisp level.
1239
e39b275c 12402011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1241
1242 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1243
b2db44d9 12442011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1245
f4af5137 1246 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1247 The previous code assumed that file offsets (off_t values) fit in
1248 EMACS_INT variables, which is not true on typical 32-bit hosts.
1249 The code messed up by falsely reporting buffer overflow in cases
1250 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1251 when "big" contains more than 2**29 bytes, even though this
1252 inserts just one byte and does not overflow the buffer.
1253 (Finsert_file_contents): Store file offsets as off_t
1254 values, not as EMACS_INT values. Check for overflow when
1255 converting between EMACS_INT and off_t. When checking for
1256 buffer overflow or for overlap, take the offsets into account.
1257 Don't use EMACS_INT for small values where int suffices.
1258 When checking for overlap, fix a typo: ZV was used where
1259 ZV_BYTE was intended.
1260 (Fwrite_region): Don't assume off_t fits into 'long'.
1261 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1262
ecfc0a49
MA
12632011-09-05 Michael Albinus <michael.albinus@gmx.de>
1264
1265 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1266
6511acf2 12672011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1268
0999621a 1269 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1270
1271 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1272 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1273 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1274 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1275 (modify_event_symbol): Do not assume that the length of
1276 name_alist_or_stem is safe to alloca and fits in int.
1277 (Fexecute_extended_command): Likewise for function name and binding.
1278 (Frecursion_depth): Wrap around reliably on integer overflow.
1279 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1280 since some callers pass EMACS_INT values.
1281 (Fsingle_key_description): Don't crash if symbol name contains more
1282 than MAX_ALLOCA bytes.
1283 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1284 (get_minibuffer): Arg is now EMACS_INT, not int.
1285 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1286 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1287 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1288
2be7d702
PE
1289 * dbusbind.c (signature_cat): New function.
1290 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1291 Do not overrun buffer; instead, report string overflow.
1292
9d1df220
PE
1293 * dispnew.c (add_window_display_history): Don't overrun buffer.
1294 Truncate instead; this is OK since it's just a log.
1295
33ef5c64
PE
1296 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1297 even if the time zone offset is outlandishly large.
1298 Don't mishandle offset == INT_MIN.
1299
66c6fdd5
PE
1300 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1301 when creating daemon; the previous buffer-overflow check was incorrect.
1302
d749b01b
PE
1303 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1304 which has the guts of the old verror function.
1305
b5cd1905
PE
1306 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1307 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1308
6e1a67fb
PE
1309 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1310 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1311 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1312 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1313 length of string rather than counting it via multiple sprintfs;
1314 that's simpler and more reliable.
c21721cc
PE
1315 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1316 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1317 sprintf, in case result does not fit in int.
1318
c57b67fc
PE
1319 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1320 (fontset_from_font): Print it.
1321
8a401434
PE
1322 * frame.c (tty_frame_count): Now printmax_t, not int.
1323 (make_terminal_frame, set_term_frame_name): Print it.
1324 (x_report_frame_params): In X, window IDs are unsigned long,
1325 not signed long, so print them as unsigned.
1326 (validate_x_resource_name): Check for implausibly long names,
1327 and don't assume name length fits in 'int'.
1328 (x_get_resource_string): Don't blindly alloca invocation name;
1329 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1330 not fit in int.
1331
6e1a67fb
PE
1332 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1333 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1334 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1335
0df02bf3
PE
1336 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1337 Use esprintf, not sprintf, in case result does not fit in int.
1338
48e30793
PE
1339 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1340 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1341 it as a large positive number.
1342 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1343 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1344
a66ff6d8
PE
1345 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1346 in case result does not fit in int.
1347
aca216ff
PE
1348 * print.c (float_to_string): Detect width overflow more reliably.
1349 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1350 buffer overrun. Don't assume list length fits in 'int'. Treat
1351 print length of 0 as 0, not as infinity; to be consistent with other
1352 uses of print length in this function. Don't overflow print length
1353 index. Don't assume hash table size fits in 'long', or that
1354 vectorlike size fits in 'unsigned long'.
1355
31c286f7
PE
1356 * process.c (make_process): Use printmax_t, not int, to format
1357 process-name gensyms.
1358
55e5faa1
PE
1359 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1360
80f2e268
PE
1361 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1362 to avoid potential buffer overrun.
1363
670741ab
PE
1364 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1365 if X resource line is longer than 512 bytes.
1366
b7163a50
PE
1367 * xfns.c (x_window): Make sprintf buffer a bit bigger
1368 to avoid potential buffer overrun.
1369
ae58ff1f
PE
1370 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1371
c43c8a6a
PE
1372 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1373
3f8236f4
PE
13742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1375
53e9fe90 1376 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1377 Without these, Emacs silently mishandles large integers sometimes.
1378 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1379 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1380
6511acf2
PE
1381 * xdisp.c (try_window_id): Check Emacs fixnum range before
1382 converting to 'int'.
806add1d 1383
6511acf2 1384 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1385 Check that an Emacs fixnum is in range before assigning it to 'int'.
1386 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1387 values converted from Emacs fixnums.
1388 (Frecenter): Don't wrap around a line count if it is out of 'int'
1389 range; instead, treat it as an extreme value.
1390 (Fset_window_configuration, compare_window_configurations):
1391 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1392
6511acf2
PE
1393 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1394 that can exceed INT_MAX. Check that EMACS_INT value is in range
1395 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1396 (match_limit): Don't assume that a fixnum can fit in 'int'.
1397
6511acf2 1398 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1399 exceed INT_MAX.
1400
6511acf2 1401 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1402 (Fvertical_motion): Don't wrap around LINES values that don't fit
1403 in 'int'. Instead, treat them as extreme values. This is good
1404 enough for windows, which can't have more than INT_MAX lines anyway.
1405
fcb901a7
LMI
14062011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1407
0f2f6b6d
LMI
1408 * Require libxml/parser.h to avoid compilation warning.
1409
fcb901a7
LMI
1410 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1411
1412 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1413 since this reportedly can destroy thread storage.
1414
6e20a0d4
CY
14152011-08-30 Chong Yidong <cyd@stupidchicken.com>
1416
1417 * syntax.c (find_defun_start): Update all cache variables if
1418 exiting early (Bug#9401).
1419
148ae00e
EZ
14202011-08-30 Eli Zaretskii <eliz@gnu.org>
1421
f6cfbd8f
EZ
1422 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1423
148ae00e
EZ
1424 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1425 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1426 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1427
1428 * term.c (tty_append_glyph): New function.
1429 (produce_stretch_glyph): Static function and its prototype deleted.
1430
a66cfb1c
SM
1431 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1432 Add prototypes.
148ae00e 1433
c4a07a4c
PE
14342011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1437 when checking :margin (Bug#9390).
1438 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1439 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1440 so that the name doesn't mislead. All uses changed.
1441
6bc8cd65
JB
14422011-08-28 Johan Bockgård <bojohan@gnu.org>
1443
1444 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1445 set_tty_hooks.
1446
dca4927e
EZ
14472011-08-27 Eli Zaretskii <eliz@gnu.org>
1448
1449 * xdisp.c (move_it_to): Don't bail out early when reaching
1450 position beyond to_charpos, if we are scanning backwards.
1451 (move_it_vertically_backward): When DY == 0, make sure we get to
1452 the first character in the line after the newline.
1453
f2cad773
PE
14542011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1455
1456 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1457 (ccl_driver): Do not generate an out-of-range pointer.
1458 (Fccl_execute_on_string): Remove unnecessary check for
1459 integer overflow, noted by Stefan Monnier in
1460 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1461 Remove a FIXME that didn't need fixing.
1462 Simplify the newly-introduced buffer reallocation code.
1463
0cae2cdb
JB
14642011-08-27 Juanma Barranquero <lekktu@gmail.com>
1465
1466 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1467
5fc295a4 14682011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1469
70c60eb2 1470 Integer and memory overflow issues (Bug#9196).
726e0ab1 1471
d31850da
PE
1472 * doc.c (get_doc_string): Rework so that
1473 get_doc_string_buffer_size is the actual buffer size, rather than
1474 being 1 less than the actual buffer size; this makes xpalloc more
1475 convenient.
1476
a69fbedb
PE
1477 * image.c (x_allocate_bitmap_record, cache_image):
1478 * xselect.c (Fx_register_dnd_atom):
1479 Simplify previous changes by using xpalloc.
1480
fe5c5d37
PE
1481 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1482 since either will do and ptrdiff_t is convenient with xpalloc.
1483
0065d054
PE
1484 * charset.c (charset_table_size)
1485 (struct charset_sort_data.priority): Now ptrdiff_t.
1486 (charset_compare): Don't overflow if priorities differ greatly.
1487 (Fsort_charsets): Don't assume list length fits in int.
1488 Check for size-calculation overflow when allocating sort data.
1489 (syms_of_charset): Allocate an initial charset table that is
1490 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1491
1492 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1493
1494 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1495 The actual value is always <= INT_MAX, and leaving it unsigned made
1496 overflow checking harder.
1497
1498 * dispextern.h (struct glyph_matrix.rows_allocated)
1499 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1500 with xpalloc. The values are still always <= INT_MAX.
1501
1502 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1503
1504 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1505 (SAFE_NALLOCA): New macro.
1506
1507 * region-cache.c (struct boundary.pos, find_cache_boundary)
1508 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1509 (set_cache_region, invalidate_region_cache)
1510 (revalidate_region_cache, know_region_cache, region_cache_forward)
1511 (region_cache_backward, pp_cache):
1512 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1513 so that ptrdiff_t * can be passed to xpalloc.
1514 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1515 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1516 (pp_cache): Don't assume cache_len fits in int.
1517 * region-cache.h: Adjust extern decls to match.
1518
1519 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1520 EMACS_INT, since either will do, for xpalloc.
1521
1522 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1523 (xnmalloc, xnrealloc, xpalloc): New functions.
1524
726e0ab1
PE
1525 * bidi.c (bidi_shelve_header_size): New constant.
1526 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1527 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1528
51f30bc5 1529 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1530 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1531 (overlay_strings):
1532 Don't update size of array until after memory allocation succeeds,
1533 because xmalloc/xrealloc may not return.
0065d054
PE
1534 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1535 now that we have proper integer overflow checking.
1536 (record_overlay_string, overlay_strings): Catch overflows when
1537 calculating size of overlay_str_buf.
726e0ab1 1538
0065d054
PE
1539 * callproc.c (Fcall_process): Check for size overflow when
1540 calculating size of args2.
1541 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1542 Normally we prefer signed values, but sticking with ptrdiff_t would
1543 require adding more-complicated checks.
726e0ab1
PE
1544
1545 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1546 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1547 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1548 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1549
1550 * character.c (Fstring): Check for size-calculation overflow.
1551
1552 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1553 unnecessary integer overflow. Check for size overflow.
1554 (encode_coding_object): Don't update size until xmalloc succeeds.
1555
1556 * composite.c (get_composition_id): Check for overflow in glyph
1557 length calculations.
1558
1559 Integer and memory overflow fixes for display code.
1560 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1561 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1562 (scrolling_window): Check for overflow in size calculations.
1563 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1564 Don't assume glyph table len fits in int.
1565 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1566 (row_table_size): Now ptrdiff_t, not int.
1567 (scrolling_window): Avoid overflow in size calculations.
1568 Don't update size until allocation succeeds.
1569 * fns.c (concat): Check for overflow in size calculations.
1570 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1571 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1572 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1573
1574 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1575 (get_doc_string): Check for size calculation overflow.
1576 Don't update size until allocation succeeds.
1577 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1578 EMACS_INT, where ptrdiff_t will do.
1579 (Fsubstitute_command_keys): Check for string overflow.
1580
1581 * editfns.c (set_time_zone_rule): Don't assume environment length
1582 fits in int.
1583 (message_length): Now ptrdiff_t, not int.
1584 (Fmessage_box): Don't update size until allocation succeeds.
1585 Don't assume message length fits in int.
1586 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1587
0065d054
PE
1588 * emacs.c (main): Do not reallocate argv, since there is a null at
1589 the end that can be overwritten, and this way there's no need to
1590 worry about size-calculation overflow.
1591 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1592
1593 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1594 alloc succeeds.
1595 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1596
1597 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1598 (x_set_scroll_bar_width, x_figure_window_size):
1599 Check for integer overflow.
1600 (x_set_alpha): Do not assume XINT fits in int.
1601
1602 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1603 This is for the members text_lines, text_cols, total_lines, total_cols,
1604 where the system imposes an 'int' limit.
1605
1606 * fringe.c (Fdefine_fringe_bitmap):
1607 Don't update size until alloc works.
1608
1609 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1610 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1611
1612 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1613 Check for size-calculation overflow.
1614 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1615 do, as we prefer signed integers.
1616 (id_to_widget.max_size, id_to_widget.used)
1617 (xg_store_widget_in_map, xg_remove_widget_from_map)
1618 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1619 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1620 Use and return ptrdiff_t, not int.
1621 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1622 * gtkutil.h: Change prototypes to match the above.
1623
1624 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1625 are duplicate now that they've been promoted to lisp.h.
1626 (x_allocate_bitmap_record, x_alloc_image_color)
1627 (make_image_cache, cache_image, xpm_load):
1628 Don't update size until alloc is done.
1629 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1630 (x_detect_edges):
3256efce 1631 Check for size calculation overflow.
726e0ab1
PE
1632 (ct_colors_allocated_max): New constant.
1633 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1634 overflow.
3256efce 1635
726e0ab1
PE
1636 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1637 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1638 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1639 Use ptrdiff_t, not int, to count maps.
1640 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1641 calculations. Don't update size until allocation succeeds.
1642 Redo calculations to avoid overflow.
726e0ab1
PE
1643 * keyboard.h: Change prototypes to match the above.
1644
1645 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1646 to count maps.
1647 (current_minor_maps): Check for size calculation overflow.
1648 * keymap.h: Change prototypes to match the above.
1649
1650 * lread.c (read1, init_obarray): Don't update size until alloc done.
1651
1652 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1653 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1654
726e0ab1
PE
1655 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1656 Now ptrdiff_t, not int.
1657 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1658 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1659
1660 * process.c (Fnetwork_interface_list): Check for overflow
1661 in size calculation.
1662
1663 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1664
1665 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1666 overflow. Don't bother calling xmalloc when xrealloc will do.
1667
1668 * search.c (Freplace_match): Check for size calculation overflow.
1669 (Fset_match_data): Don't assume list lengths fit in 'int'.
1670
1671 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1672 for command line length. Do not attempt to address one before the
1673 beginning of an array, as that's not portable.
1674
1675 * term.c (max_frame_lines): Remove; unused.
1676 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1677 not int.
1678 (encode_terminal_code, calculate_costs): Check for size
1679 calculation overflow.
1680 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1681 table lengths and related sizes. Don't update size until alloc
1682 done. Redo calculations to avoid overflow.
1683 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1684
1685 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1686 subtracting pointers.
1687 (gobble_line): Check for overflow more carefully. Don't update size
1688 until alloc done.
1689
1690 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1691 Don't update size until alloc done.
1692 Redo size calculations to avoid overflow.
1693 Check for size calculation overflow.
0065d054 1694 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1695
1696 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1697 Use ptrdiff_t, not int, for sizes.
1698 (store_mode_line_noprop_char): Don't update size until alloc done.
1699
0065d054
PE
1700 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1701 Use ptrdiff_t, not int, for sizes.
1702 (Finternal_make_lisp_face, cache_face):
1703 Check for size calculation overflow.
1704 (cache_face): Treat size calculation overflows as if they were
1705 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1706
1707 * xfns.c (x_encode_text, x_set_name_internal)
1708 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1709 sizes, since they can exceed INT_MAX in size. Check for size
1710 calculation overflow.
1711
0065d054
PE
1712 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1713 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1714 Don't update size until alloc done.
1715
0065d054 1716 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1717 as sprintf is limited to int lengths.
1d526e2f 1718
252c5ee1
PE
1719 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1720 (X_LONG_MIN): New macros.
864d7ce7
PE
1721 Use them to make the following changes clearer.
1722 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1723 This change doesn't affect the value now, but it may help remind
1724 future maintainers not to raise the value too much later.
1725 (SELECTION_QUANTUM): Remove, replacing with ...
1726 (selection_quantum): ... new function, which avoids overflow.
1727 All uses changed.
1728 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1729 assumption that selection length fits in 'int'.
1730 (x_reply_selection_request, x_handle_selection_request)
1731 (x_get_window_property, receive_incremental_selection)
1732 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1733 (lisp_data_to_selection_data, clean_local_selection_data):
1734 Use ptrdiff_t, not int, to record length of selection.
1735 (x_reply_selection_request, x_get_window_property)
1736 (receive_incremental_selection, x_property_data_to_lisp):
1737 Redo calculations to avoid overflow.
1738 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1739 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1740 something.
1741 (x_get_window_property, receive_incremental_selection)
1742 (lisp_data_to_selection_data, x_property_data_to_lisp):
1743 Check for size-calculation overflow.
1744 (x_get_window_property, receive_incremental_selection)
1745 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1746 Don't store size until memory allocation succeeds.
1747 (x_get_window_property): Plug memory leak on memory exhaustion.
1748 Don't double-block input; malloc is safe here. Don't assume 2**34
1749 - 4 fits in unsigned long. Add an xassert to check
1750 XGetWindowProperty overflow. Be more careful about overflow
1751 calculations, and distinguish size from memory overflow better.
1752 (receive_incremental_selection): When tracing, don't assume
1753 unsigned int is less than INT_MAX.
1754 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1755 harmful) conversions of unsigned short to int.
1756 (lisp_data_to_selection_data): Don't assume that integers
1757 in the range -65535 through -1 fit in an X unsigned short.
1758 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1759 result parameters unless successful. Rely on cons_to_unsigned
1760 to report problems with elements; the old code wasn't right anyway.
1761 (x_check_property_data): Check for int overflow; we cannot use
1762 a wider type due to X limits.
1763 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1764
726e0ab1 1765 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1766
0065d054
PE
1767 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1768 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1769 (x_color_cells): Don't store size until memory allocation succeeds.
1770 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1771 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1772 (x_term_init): Don't assume length fits in int (sprintf is limited
1773 to int size).
bc18e09d 1774
ebfa62c0
PE
1775 Use ptrdiff_t for composition IDs.
1776 * character.c (lisp_string_width):
1777 * composite.c (composition_table_size, n_compositions)
1778 (get_composition_id, composition_gstring_from_id):
1779 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1780 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1781 * window.c (Frecenter):
1782 Use ptrdiff_t, not int, for composition IDs.
1783 * composite.c (get_composition_id): Check for integer overflow.
1784 * composite.h: Adjust prototypes to match the above changes.
1785
d3411f89
PE
1786 Use ptrdiff_t for hash table indexes.
1787 * category.c (hash_get_category_set):
1788 * ccl.c (ccl_driver):
1789 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1790 * coding.c (coding_system_charset_list, detect_coding_system):
1791 * coding.h (struct coding_system.id):
1792 * composite.c (get_composition_id, gstring_lookup_cache):
1793 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1794 * image.c (xpm_get_color_table_h):
1795 * lisp.h (hash_lookup, hash_put):
1796 * minibuf.c (Ftest_completion):
1797 Use ptrdiff_t for hash table indexes, not int (which is too
1798 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1799 32-bit --with-wide-int hosts).
1800
e097a6fa
PE
1801 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1802 Add a FIXME comment about memory leaks.
1803 (syms_of_charset): Don't assume xmalloc returns.
1804
5637687f
PE
1805 Don't assume that stated character widths fit in int.
1806 * character.c (Fchar_width, c_string_width, lisp_string_width):
1807 * character.h (CHAR_WIDTH):
1808 * indent.c (MULTIBYTE_BYTES_WIDTH):
1809 Use sanitize_char_width to avoid undefined and/or bad behavior
1810 with outlandish widths.
a66cfb1c 1811 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1812 now that we have two such functions. All uses changed.
1813 (sanitize_char_width): New inline function.
1814
a2271ba2
PE
1815 Don't assume that tab-width fits in int.
1816 * character.h (sanitize_width): New inline function.
1817 (SANE_TAB_WIDTH): New macro.
1818 (ASCII_CHAR_WIDTH): Use it.
1819 * indent.c (sane_tab_width): Remove. All uses replaced by
1820 SANE_TAB_WIDTH (current_buffer).
1821 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1822
18c52557
PE
1823 * fileio.c: Integer overflow issues with file modes.
1824 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1825
caeeedc1
PE
1826 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1827 Remove unreachable code.
1828 (read_hex, load_charset_map_from_file): Check for integer overflow.
1829
50849c52
PE
1830 * xterm.c: don't go over XClientMessageEvent limit
1831 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1832 (x_send_scroll_bar_event): Likewise. Check that the size does not
1833 exceed limits imposed by XClientMessageEvent, as well as the usual
1834 ptrdiff_t and size_t limits.
1835
b13995db
PE
1836 * keyboard.c: Overflow, signedness and related fixes.
1837 (make_lispy_movement): Use same integer type in forward decl
1838 that is used in the definition.
1839 (read_key_sequence, keyremap_step):
1840 Change bufsize argument back to int, undoing my 2011-03-30 change.
1841 We prefer signed types, and int is wide enough here.
1842 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1843 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1844 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1845 length, not size_t. Use ptrdiff_t for index, not int.
1846 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1847 possibility of integer overflow.
1848
13464394
PE
1849 Overflow, signedness and related fixes for images.
1850
1851 * dispextern.h (struct it.stack[0].u.image.image_id)
1852 (struct_it.image_id, struct image.id, struct image_cache.size)
1853 (struct image_cache.used, struct image_cache.ref_count):
1854 * gtkutil.c (update_frame_tool_bar):
1855 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1856 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1857 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1858 * nsmenu.m (update_frame_tool_bar):
1859 * xdisp.c (calc_pixel_width_or_height):
1860 * xfns.c (image_cache_refcount):
1861 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1862 on typical 64-bit hosts.
1863
1864 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1865 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1866 Omit unnecessary casts to int.
1867 (parse_image_spec): Check that integers fall into 'int' range
1868 when the callers expect that.
1869 (image_ascent): Redo ascent calculation to avoid int overflow.
1870 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1871 (lookup_image): Remove unnecessary tests.
1872 (xbm_image_p): Locals are now of int, not EMACS_INT,
1873 since parse_image_check makes sure they fit into int.
1874 (png_load, gif_load, svg_load_image):
1875 Prefer int to unsigned where either will do.
1876 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1877 old tiff_error_handler and tiff_warning_handler.
1878 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1879 stack buffer overflows. It uses only the features of vsnprintf
1880 that are common to both POSIX and native Microsoft.
1881 (tiff_error_handler, tiff_warning_handler): Use it.
1882 (tiff_load, gif_load, imagemagick_load_image):
1883 Don't assume :index value fits in 'int'.
1884 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1885 (imagemagick_load_image): Check that crop parameters fit into
1886 the integer types that MagickCropImage accepts. Don't assume
1887 Vimagemagick_render_type has a nonnegative value. Don't assume
1888 size_t fits in 'long'.
1889 (gs_load): Use printmax_t to print the widest integers possible.
1890 Check for integer overflow when computing image height and width.
1891
c11821d4
EZ
18922011-08-26 Eli Zaretskii <eliz@gnu.org>
1893
1894 * xdisp.c (redisplay_window): Don't force window start if point
1895 will be invisible in the resulting window. (Bug#9324)
1896
0c95fcf7
EZ
18972011-08-25 Eli Zaretskii <eliz@gnu.org>
1898
1899 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1900 the display spec is of the form `(space ...)'.
1901 (handle_display_spec): Return the value returned by
1902 handle_single_display_spec, not just 1 or zero.
1903 (handle_single_display_spec): If the display spec is of the form
1904 `(space ...)', and specifies display in the text area, return 2
1905 rather than 1.
fee65a97 1906 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1907 accurately, and prefer exact match for point under bidi.
1908 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1909
1910 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1911 into disp_prop; all users changed.
1912
1913 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1914 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1915 for the text covered by the display property.
1916
e4ed06f1
CY
19172011-08-25 Chong Yidong <cyd@stupidchicken.com>
1918
1919 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1920 Change return value to nil.
1921 (Frecord_buffer): Delete unused function.
1922
f67cdd7f
EZ
19232011-08-24 Eli Zaretskii <eliz@gnu.org>
1924
5980d4c6
EZ
1925 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1926 buffers, return left-to-right.
8610fe8b
EZ
1927 (set_cursor_from_row): Consider candidate row a win if its glyph
1928 represents a newline and point is on that newline. Fixes cursor
1929 positioning on the newline at EOL of R2L text within L2R
1930 paragraph, and vice versa.
1931 (try_cursor_movement): Check continued rows, in addition to
1932 continuation rows. Fixes unwarranted scroll when point enters a
1933 continued line of R2L text within an L2R paragraph, or vice versa.
1934 (cursor_row_p): Consider the case of point being equal to
1935 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1936 from the end of a short line to the beginning of a continued line
1937 of R2L text within L2R paragraph.
1938 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1939 composed characters.
5980d4c6 1940
f67cdd7f
EZ
1941 * bidi.c (bidi_check_type): Use xassert.
1942 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1943 members.
1944
bca633fb
EZ
19452011-08-23 Eli Zaretskii <eliz@gnu.org>
1946
1947 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1948 a character.
1949
4a5885a7
CY
19502011-08-23 Chong Yidong <cyd@stupidchicken.com>
1951
1952 * nsfont.m (ns_otf_to_script): Fix typo.
1953
0902a04e
KH
19542011-08-22 Kenichi Handa <handa@m17n.org>
1955
1956 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1957 extra slot even if the purpose is char-code-property-table.
1958
1a2e6670
EZ
19592011-08-23 Eli Zaretskii <eliz@gnu.org>
1960
8ddde651
EZ
1961 * xdisp.c (redisplay_window): When computing centering_position,
1962 account for the height of the header line. (Bug#8874)
1963
425cc014
EZ
1964 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1965 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1966 candidate is selected by the mouse, and that candidate has a
1967 composed character under the mouse.
1968
1a2e6670
EZ
1969 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1970 coordinates reported by pos-visible-in-window-p for a composed
1971 character in column zero.
1972
8b76d6f8
SM
19732011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1974
1975 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1976
dac347dd
EZ
19772011-08-22 Eli Zaretskii <eliz@gnu.org>
1978
1979 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1980 consider it a hit if to_charpos is anywhere in the range of the
1981 composed buffer positions.
1982
e013fb34
CY
19832011-08-22 Chong Yidong <cyd@stupidchicken.com>
1984
1985 * image.c (gif_load): Don't assume that each subimage has the same
1986 dimensions as the base image. Handle disposal method that is
1987 "undefined" by the gif spec (Bug#9335).
1988
bd1ba3e8
CY
19892011-08-20 Chong Yidong <cyd@stupidchicken.com>
1990
1991 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1992 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1993
54a1215b
EZ
19942011-08-19 Eli Zaretskii <eliz@gnu.org>
1995
823564e5
EZ
1996 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1997 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1998 from an Org mode buffer to a Speedbar frame.
1999
54a1215b
EZ
2000 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2001 a composition, take its buffer position from IT->cmp_it.charpos.
2002 Fixes cursor positioning at the beginning of a line that begins
2003 with a composed character.
2004
9778ebcc
EZ
20052011-08-18 Eli Zaretskii <eliz@gnu.org>
2006
0be6ee06
EZ
2007 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2008 character bidirectional type, use STRONG_L instead. Fixes crashes
2009 in a buffer produced by `describe-categories'.
2010
9778ebcc
EZ
2011 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2012 members before the level stack, so they would be saved and
2013 restored when copying iterator state. Fixes incorrect reordering
2014 around TABs covered by display properties.
2015
156bffbe
AS
20162011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2017
6b02f655 2018 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2019
72ad093b
CY
20202011-08-17 Chong Yidong <cyd@stupidchicken.com>
2021
2022 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2023 (internal_condition_case_2, internal_condition_case_n):
2024 Remove unnecessary aborts (Bug#9081).
72ad093b 2025
35774242
EZ
20262011-08-17 Eli Zaretskii <eliz@gnu.org>
2027
2028 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2029 has no `load' handler, try opening the file locally. (Bug#9311)
2030
db76dd85
KB
20312011-08-16 Ken Brown <kbrown@cornell.edu>
2032
2033 * gmalloc.c: Expand comment.
2034
b215eee5
EZ
20352011-08-16 Eli Zaretskii <eliz@gnu.org>
2036
2037 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2038 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2039
a4579d33
KB
20402011-08-16 Ken Brown <kbrown@cornell.edu>
2041
2042 Fix memory allocation problems in Cygwin build (Bug#9273).
2043
2044 * unexcw.c ( __malloc_initialized): Declare external variable.
2045 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2046
8b76d6f8
SM
2047 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2048 New variables.
a4579d33
KB
2049 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2050 dumped emacs.
2051 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2052 in the static heap.
2053 [CYGWIN] (special_realloc): New function.
2054 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2055 requests to realloc storage in the static heap.
2056
3ebec551
PE
20572011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2058
2059 * bidi.c (bidi_initialize): Remove unused local.
2060
9fd8be00
EZ
20612011-08-15 Eli Zaretskii <eliz@gnu.org>
2062
6b02f655
SM
2063 * bidimirror.h:
2064 * biditype.h: Remove file.
2065 * makefile.w32-in ($(BLD)/bidi.$(O)):
2066 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2067
2068 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2069
2070 * chartab.c: Improve commentary for the uniprop_table API.
2071
32413314
EZ
2072 * bidi.c (bidi_paragraph_init): Support zero value of
2073 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2074 (bidi_initialize): Use uniprop_table instead of including
2075 biditype.h and bidimirror.h.
32413314 2076
9fd8be00
EZ
2077 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2078 coordinates of the iterator when restoring from ppos_it.
2079 (Bug#9296)
2080
5cf2b69b
KH
20812011-08-14 Kenichi Handa <handa@m17n.org>
2082
2083 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2084 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2085
daf17d00
EZ
20862011-08-14 Eli Zaretskii <eliz@gnu.org>
2087
2088 * xdisp.c (move_it_in_display_line_to): Don't invoke
2089 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2090 ppos_it. Fixes vertical cursor motion when line beginning is
2091 covered by an image. (Bug#9296)
2092
08e3161a
JD
20932011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2094
2095 * nsterm.h (ns_run_ascript): Declare.
2096 (NSAPP_DATA2_RUNASSCRIPT): Define.
2097
2098 * nsfns.m (as_script, as_result, as_status): New static variables.
2099 (ns_run_ascript): New function.
5e617bc2 2100 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2101 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2102 the event loop. Get status from as_status (Bug#7276).
2103
2104 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2105 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2106 the event loop (Bug#7276).
2107
a3720aa2
AS
21082011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2109
2110 * gnutls.c (QCgnutls_bootprop_priority)
2111 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2112 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2113 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2114 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2115 (QCgnutls_bootprop_verify_hostname_error)
2116 (QCgnutls_bootprop_callbacks_verify): Rename from
2117 Qgnutls_bootprop_..., all uses changed.
2118
2119 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2120 uses changed.
2121
0a0d27fb
PE
21222011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2123
19d5c50c
PE
2124 * xfaces.c (Qframe_set_background_mode): Now static.
2125 * dispextern.h (Qframe_set_background_mode): Remove decl.
2126
0a0d27fb
PE
2127 * process.c (Fnetwork_interface_info): Declare local only if needed.
2128
377538cb
JD
21292011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2130
2131 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2132 (Fnetwork_interface_list): Allocate in increments of bytes instead
2133 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2134 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2135 sockaddr.
2136 (struct ifflag_def): notrailers is smart on OSX.
2137 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2138 Get hardware address with getifaddrs if available.
2139
08fff70c
EZ
21402011-08-12 Eli Zaretskii <eliz@gnu.org>
2141
2142 * xdisp.c (iterate_out_of_display_property): xassert that
2143 IT->position is set to within IT->object's boundaries. Break from
2144 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2145 when IT->position is set up wrongly due to some bug.
2146 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2147 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2148 entry. Force push_it to save on the stack the current
2149 buffer/string position, to be restored by pop_it. Fix flags in
2150 the iterator structure wrt the object coming from a display
2151 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2152 properties. (Bug#9284)
2153
7be1c708 21542011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2155
7be1c708
CY
2156 * fontset.c (fontset_get_font_group): Add proper type checks.
2157 (Bug#9172)
aac0c6e3 2158
7be1c708 21592011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2160
7be1c708
CY
2161 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2162 and LC_VERSION_MIN_MACOSX.
2163 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2164 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2165
97bb72a6
EZ
21662011-08-08 Eli Zaretskii <eliz@gnu.org>
2167
2168 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2169 no-display-properties-and-no-overlays under bidi display.
2170 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2171 properties and overlays.
97bb72a6 2172
d5617611
CY
21732011-08-08 Chong Yidong <cyd@stupidchicken.com>
2174
37e11a63
CY
2175 * editfns.c (Fset_time_zone_rule): Document relationship with the
2176 setenv function.
2177
d5617611
CY
2178 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2179 the font entity extracted from the cache (Bug#8109).
2180
58872834
CY
21812011-08-07 Chong Yidong <cyd@stupidchicken.com>
2182
2183 * composite.c (autocmp_chars): Don't reset point. That is done by
2184 restore_point_unwind (Bug#5984).
2185
75bfc667
JL
21862011-08-07 Juri Linkov <juri@jurta.org>
2187
2188 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2189 to show the arg `TIME' instead of `TIMEVAL'.
2190
d1410150
EZ
21912011-08-06 Eli Zaretskii <eliz@gnu.org>
2192
2193 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2194 display property strides EOL and includes a newline, as in
2195 longlines-mode. (Bug#9254)
75b771e4
EZ
2196 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2197 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2198
2199 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2200 is non-zero, even if the data buffer is NULL. Fixes a crash in
2201 vertical-motion with longlines-mode. (Bug#9254)
2202
35928349
EZ
22032011-08-05 Eli Zaretskii <eliz@gnu.org>
2204
ec7cc85b
EZ
2205 * bidi.c <bidi_cache_total_alloc>: Now static.
2206 (bidi_initialize): Initialize bidi_cache_total_alloc.
2207
8b76d6f8 2208 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2209 cache. (Bug#9221)
2210
2211 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2212 amount allocated this far in `bidi_cache_total_alloc'.
2213 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2214 non-zero, only free the data buffer without restoring the cache
2215 contents. All callers changed.
2216
2217 * dispextern.h (bidi_unshelve_cache): Update prototype.
2218
2219 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2220 (move_it_in_display_line, move_it_to)
2221 (move_it_vertically_backward, move_it_by_lines): Replace the call
2222 to xfree to an equivalent call to bidi_unshelve_cache.
2223 (move_it_in_display_line_to): Fix logic of returning
412b6358 2224 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2225
e2e2423b
EZ
22262011-08-05 Eli Zaretskii <eliz@gnu.org>
2227
2228 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2229 came from a string character with a `cursor' property. (Bug#9229)
2230
ae9e757a
JD
22312011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2232
2233 * Makefile.in (LIB_PTHREAD): New variable.
2234 (LIBES): Add LIB_PTHREAD (Bug#9216).
2235
2236 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2237 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2238
213bd7f2
AS
22392011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2240
6b02f655 2241 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2242
99aaf75f
JD
22432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2244
2245 * xterm.c (x_find_topmost_parent): New function.
2246 (x_set_frame_alpha): Find topmost parent window with
2247 x_find_topmost_parent and set the property there also (bug#9181).
2248 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2249
c74e9d86
PE
22502011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2251
2252 * callproc.c (Fcall_process): Avoid vfork clobbering
2253 the local vars buffer, coding_systems, current_dir.
2254
640c8776
SM
22552011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2256
2257 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2258
f26d0e4c
PE
22592011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2260
8a10d76c
PE
2261 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2262 so that it is not optimized away.
2263
f26d0e4c
PE
2264 * xdisp.c (compute_display_string_pos): Remove unused local.
2265
55439c61
EZ
22662011-08-02 Eli Zaretskii <eliz@gnu.org>
2267
2268 Fix slow cursor motion and scrolling in large buffers with
2269 selective display, like Org Mode buffers. (Bug#9218)
2270
2271 * dispextern.h (struct bidi_it): New member disp_prop_p.
2272
2273 * xdisp.c: Remove one-slot cache of display string positions.
2274 (compute_display_string_pos): Accept an additional argument
5e617bc2 2275 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2276 for a display string or property. If found, set DISP_PROP_P
2277 non-zero.
2278
2279 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2280 DISP_PROP_P, and pass it to compute_display_string_pos.
2281 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2282 non-zero. All callers of bidi_fetch_char changed.
2283
fb33fa43
SM
22842011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2285
2286 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2287
b099e063
DM
22882010-12-03 Don March <don@ohspite.net>
2289
2290 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2291 last character M-[char] is translated to ESC [char] (bug#7541).
2292
5cc7f7af
KH
22932011-08-02 Kenichi Handa <handa@m17n.org>
2294
d0fffa3f 2295 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2296
2297 * chartab.c (uniprop_table): Make it non-static.
2298
525d5e6e
EZ
22992011-08-01 Eli Zaretskii <eliz@gnu.org>
2300
2301 * xdisp.c (forward_to_next_line_start): Accept additional argument
2302 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2303 on the newline.
2304 (reseat_at_next_visible_line_start): Use the bidi iterator state
2305 returned by forward_to_next_line_start to restore the state of
2306 it->bidi_it after backing up to previous newline. (Bug#9212)
2307
31011111
AS
23082011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2309
2310 * regex.c (re_comp): Protoize.
2311 (re_exec): Fix return type.
2312 (regexec): Fix type of `ret'. (Bug#9203)
2313
476371c4
PE
23142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2315
e5d76069
PE
2316 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2317 This is needed if max-image-size is a floating-point number.
2318
9a79b20c
AS
23192011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2320
2321 * print.c (print_object): Print empty symbol as ##.
2322
2323 * lread.c (read1): Read ## as empty symbol.
2324
d8c2fa78
AA
23252011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2326
2327 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2328 setting frame foreground color (Bug#9175).
2329 (x_set_background_color): Likewise.
2330
ffe57a7a
AA
2331 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2332 contents (Bug#9176).
2333 (EmacsTooltip -init): Remove bezels and add shadows to
2334 tooltip windows.
2335
bf3492a5
AA
2336 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2337 or scroll bar (Bug#8470).
2338
d55e9c53
AA
2339 * nsfont.m (nsfont_open): Remove assignment to voffset and
2340 unnecessary vars hshink, expand, hd, full_height, min_height.
2341 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2342
2343 * nsterm.h (nsfont_info): Remove voffset field.
2344
d8c2fa78 23452011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2346
2347 Implement strike-through and overline on NextStep (Bug#8863).
2348
2349 * nsfont.m (nsfont_open): Use underline position provided by font,
2350 instead of hard-coded value of 2.
2351 (nsfont_draw): Call ns_draw_text_decoration instead.
2352
2353 * nsterm.h: Add declaration for ns_draw_text_decoration.
2354
2355 * nsterm.m (ns_draw_text_decoration): New function for drawing
2356 underline, overline, and strike-through.
2357 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2358 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2359 accommodate underlining, etc.
4843aac3 2360
4cc60b9b
EZ
23612011-07-28 Eli Zaretskii <eliz@gnu.org>
2362
bc7ece87
EZ
2363 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2364 default.
4cc60b9b 2365
476371c4
PE
23662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2367
66606eea
PE
2368 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2369 Without this fix, if a signal arrives just after memory fills up,
2370 'malloc' might be invoked reentrantly.
2371
476371c4
PE
2372 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2373 In other words, assume that every image size is allowed, on non-X
2374 hosts. This assumption is probably wrong, but it lets Emacs compile.
2375
f3fcc40d
AS
23762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2377
2378 * regex.c (re_iswctype): Convert return values to boolean.
2379
350c992f
EZ
23802011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2381
2382 * xdisp.c (compute_display_string_pos): Don't use cached display
2383 string position if the buffer had its restriction changed.
2384 (Bug#9184)
2385
5266b4bb
PE
23862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2387
2388 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2389
2573a837 23902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2391
41f55ccd 2392 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2393
39e378da
PE
2394 * bidi.c: Integer size and overflow fixes.
2395 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2396 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2397 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2398 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2399 (bidi_find_other_level_edge):
2400 Use ptrdiff_t instead of EMACS_INT where either will do.
2401 This works better on 32-bit hosts configured --with-wide-int.
2402 (bidi_cache_ensure_space): Check for size-calculation overflow.
2403 Use % rather than repeated addition, for better worst-case speed.
2404 Don't set bidi_cache_size until after xrealloc returns, because it
2405 might not return.
2406 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2407 (bidi_cache_ensure_space): Also check that the bidi cache size
2408 does not exceed that of the largest Lisp string or buffer. See Eli
2409 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2410
5e927815
PE
2411 * alloc.c (__malloc_size_t): Remove.
2412 All uses replaced by size_t. See Andreas Schwab's note
2413 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2414
ca4aa935
PE
2415 * image.c: Improve checking for integer overflow.
2416 (check_image_size): Assume that f is nonnull, since
2417 it is always nonnull in practice. This is one less thing to
2418 worry about when checking for integer overflow later.
2419 (x_check_image_size): New function, which checks for integer
2420 overflow issues inside X.
2421 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2422 This removes the need for a memory_full check.
2423 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2424 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2425 (xbm_read_bitmap_data): Change locals back to 'int', since
2426 their values must fit in 'int'.
2427 (xpm_load_image, png_load, tiff_load):
2428 Invoke x_create_x_image_and_pixmap earlier,
2429 to avoid much needless work if the image is too large.
2430 (tiff_load): Treat overly large images as if
2431 x_create_x_image_and_pixmap failed, not as malloc failures.
2432 (gs_load): Use x_check_image_size.
2433
5f8f9cc2
PE
2434 * gtkutil.c: Omit integer casts.
2435 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2436 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2437
5adf60bc
PE
2438 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2439
c8907a93
PE
2440 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2441 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2442 would wrongly return t on a 64-bit host.
2443
e3c25c68
PE
2444 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2445 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2446 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2447 and therefore cause GCC to emit a bogus diagnostic in some cases.
2448
3f791afe
PE
2449 * image.c: Integer signedness and overflow and related fixes.
2450 This is not an exhaustive set of fixes, but it's time to
2451 record what I've got.
2452 (lookup_pixel_color, check_image_size): Remove redundant decls.
2453 (check_image_size): Don't assume that arbitrary EMACS_INT values
2454 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2455 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2456 (tiff_load, imagemagick_load_image):
2457 Check for overflow in size calculations.
2458 (x_create_x_image_and_pixmap): Remove unnecessary test for
2459 xmalloc returning NULL; that can't happen.
2460 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2461 (xpm_color_bucket): Use better integer hashing function.
2462 (xpm_cache_color): Don't possibly over-allocate memory.
2463 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2464 (gif_memory_source):
2465 Use ptrdiff_t, not int or size_t, to record sizes.
2466 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2467 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2468 either works, as we prefer signed integers.
2469 (tiff_read_from_memory, tiff_write_from_memory):
2470 Return tsize_t, not size_t, since that's what the TIFF API wants.
2471 (tiff_read_from_memory): Don't fail simply because the read would
2472 go past EOF; instead, return a short read.
2473 (tiff_load): Omit no-longer-needed casts.
2474 (Fimagemagick_types): Don't assume size fits into 'int'.
2475
3cc5a532
PE
2476 Improve hashing quality when configured --with-wide-int.
2477 * fns.c (hash_string): New function, taken from sxhash_string.
2478 Do not discard information about ASCII character case; this
2479 discarding is no longer needed.
2480 (sxhash-string): Use it. Change sig to match it. Caller changed.
2481 * lisp.h: Declare it.
2482 * lread.c (hash_string): Remove, since we now use fns.c's version.
2483 The fns.c version returns a wider integer if --with-wide-int is
2484 specified, so this should help the quality of the hashing a bit.
2485
b312a492
PE
2486 * emacs.c: Integer overflow minor fix.
2487 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2488 Define only if GNU_LINUX.
2489 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2490
dfd153ae
PE
2491 * dispnew.c: Integer signedness and overflow fixes.
2492 Remove unnecessary forward decls, that were a maintenance hassle.
2493 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2494 All uses changed.
2495 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2496 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2497 (prepare_desired_row, line_draw_cost):
2498 Use int, not unsigned, where either works.
2499 (save_current_matrix, restore_current_matrix):
2500 Use ptrdiff_t, not size_t, where either works.
2501 (init_display): Check for overflow more accurately, and without
2502 relying on undefined behavior.
2503
a81d11a3
PE
2504 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2505 Remove, replacing with the new symbols in lisp.h. All uses changed.
2506 * fileio.c (make_temp_name):
2507 * filelock.c (lock_file_1, lock_file):
2508 * xdisp.c (message_dolog):
2509 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2510 Use pMd etc. instead.
2511 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2512 replacing the pWIDE etc. symbols removed from editfns.c.
2513
3300e6fd
PE
2514 * keyboard.h (num_input_events): Now uintmax_t.
2515 This is (very slightly) less likely to mess up due to wraparound.
2516 All uses changed.
2517
fd05c7e9
PE
2518 * buffer.c: Integer signedness fixes.
2519 (alloc_buffer_text, enlarge_buffer_text):
2520 Use ptrdiff_t rather than size_t when either will do, as we prefer
2521 signed integers.
2522
903fe15d
PE
2523 * alloc.c: Integer signedness and overflow fixes.
2524 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2525 (__malloc_size_t): Default to size_t, not to int.
2526 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2527 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2528 Prefer ptrdiff_t to size_t when either would do, as we prefer
2529 signed integers.
2530 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2531 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2532 Now const. Initialize with values that are in range even if char
2533 is signed.
2534 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2535 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2536 These functions do the right thing with sizes > 2**32.
2537 (check_depth): Now ptrdiff_t, not int.
2538 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2539 Adjust to new way of storing sizes. Check for size overflow bugs
2540 in rest of code.
2541 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2542 slightly wrong anyway, as it missed one instance of
2543 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2544 (refill_memory_reserve): Omit needless cast to size_t.
2545 (mark_object_loop_halt): Mark as externally visible.
2546
ac82cc6a
PE
2547 * xselect.c: Integer signedness and overflow fixes.
2548 (Fx_register_dnd_atom, x_handle_dnd_message):
2549 Use ptrdiff_t, not size_t, since we prefer signed.
2550 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2551 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2552 x_dnd_atoms_size and x_dnd_atoms_length.
2553
c2d1e36d
PE
2554 * doprnt.c: Prefer signed to unsigned when either works.
2555 * eval.c (verror):
2556 * doprnt.c (doprnt):
2557 * lisp.h (doprnt):
2558 * xdisp.c (vmessage):
2559 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2560 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2561 prefer signed arithmetic to avoid comparison confusion.
2562 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2563 but is a bit tricky.
2564
0e926e56
PE
2565 Assume freestanding C89 headers, string.h, stdlib.h.
2566 * data.c, doprnt.c, floatfns.c, print.c:
2567 Include float.h unconditionally.
2568 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2569 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2570 * regex.c: Likewise for stddef.h, string.h.
2571 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2572 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2573 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2574 (STDC_HEADERS): Remove obsolete defines.
2575 * sysdep.c: Include limits.h unconditionally.
2576
9cfdb3ec
PE
2577 Assume support for memcmp, memcpy, memmove, memset.
2578 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2579 * regex.c (memcmp, memcpy):
2580 Remove; we assume C89 now.
2581
2582 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2583 (__malloc_safe_bcopy): Remove; no longer needed.
2584
cf950e6b 2585 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2586 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2587 well either way, and we prefer signed to unsigned.
2588
dbf38e02
LMI
25892011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2590
2591 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2592 closes the connection while we're reading (bug#9182).
2593
d6f0886c 25942011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2595
d6f0886c
JD
2596 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2597 are specified (Bug#9168).
24e0f6b1 2598
2eb1f9e6
PE
25992011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2602 Found by GCC static checking and --with-wide-int on a 32-bit host.
2603
22381272 26042011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2605
2606 * xdisp.c (compute_display_string_pos): Fix logic of caching
2607 previous display string position. Initialize cached_prev_pos to
2608 -1. Fixes slow-down at the beginning of a buffer.
2609
f25e39b4
EZ
26102011-07-24 Eli Zaretskii <eliz@gnu.org>
2611
2612 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2613 for attrs[LFACE_FONTSET_INDEX].
2614
04c4b52e
PE
26152011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2616
2617 * xml.c (parse_region): Remove unused local
2618 that was recently introduced.
2619
c1734fbd
EZ
26202011-07-23 Eli Zaretskii <eliz@gnu.org>
2621
be18c5a5
EZ
2622 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2623 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2624
c1734fbd
EZ
2625 * xdisp.c (move_it_in_display_line_to): Record the best matching
2626 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2627 exit if none of the characters scanned was an exact match.
2628 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2629 when exact match is impossible due to invisible text, and the
2630 lines are truncated.
2631
a258d627
JD
26322011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2633
2634 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2635 for OSX >= 10.7.
2636
b6d5a689
EZ
26372011-07-22 Eli Zaretskii <eliz@gnu.org>
2638
0f74f785
EZ
2639 Fix a significant slow-down of cursor motion with C-n, C-p,
2640 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2641 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2642 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2643 (next_element_from_buffer): Call compute_stop_pos_backwards to
2644 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2645 base_level_stop.
2646 (reseat): Don't look for prev_stop, as that could mean a very long
2647 run.
2648 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2649 <cached_disp_overlay_modiff>: Cache for last found display string
2650 position.
551918c1 2651 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2652 about the same buffer in the same area of character positions, and
2653 the buffer wasn't changed since the time the display string
2654 position was cached.
551918c1 2655
b2d0c91a
EZ
26562011-07-22 Eli Zaretskii <eliz@gnu.org>
2657
2658 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2659 is an integer, which is important for empty lines. (Bug#9149)
2660
043604ee
CY
26612011-07-22 Chong Yidong <cyd@stupidchicken.com>
2662
2663 * frame.c (Fmodify_frame_parameters): In tty case, update the
2664 default face if necessary (Bug#4238).
2665
da4adb04
CY
26662011-07-21 Chong Yidong <cyd@stupidchicken.com>
2667
2668 * editfns.c (Fstring_to_char): No need to explain what a character
2669 is in the docstring (Bug#6576).
2670
9abd0532
LMI
26712011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2672
2673 * xml.c (parse_region): Make sure we always return a tree.
2674
36881d16
HK
26752011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2676
2677 * xml.c (parse_region): If a document contains only comments,
2678 return that, too.
2679
1e98674d
LMI
26802011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2681
2682 * xml.c (make_dom): Return comments, too.
2683
590bd467
PE
26842011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2685
2686 Port to OpenBSD.
2687 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2688 and the surrounding thread.
2689 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2690 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2691 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2692 timer goes off.
2693 * s/openbsd.h (BROKEN_SIGIO): Define.
2694 * unexelf.c (unexec) [__OpenBSD__]:
2695 Don't update the .mdebug section of the Alpha COFF symbol table.
2696
f41628b2
LMI
26972011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2698
2699 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2700 (bug#8460).
2701
b59b67c5
PE
27022011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2703
15e3a074
PE
2704 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2705 This fixes some race conditions on the permissions of any newly
2706 created file.
2707
41bed37d
PE
2708 * alloc.c (valid_pointer_p): Use pipe, not open.
2709 This fixes some permissions issues when debugging.
2710
b59b67c5
PE
2711 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2712 If fchown fails to set both uid and gid, try to set just gid,
2713 as that is sometimes allowed. Adjust the file's mode to eliminate
2714 setuid or setgid bits that are inappropriate if fchown fails.
2715
925a6be7
SM
27162011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2717
2718 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2719 to compare Lisp_Objects.
2720 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2721 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2722 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2723
52968808
AS
27242011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2725
0a6a104b
AS
2726 * lread.c (read_integer): Unread even EOF character.
2727 (read1): Likewise. Properly record start position of symbol.
2728
52968808
AS
2729 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2730 symbol character follows.
2731
9e381cdd
PE
27322011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2733
2734 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2735 This works around a problem with the previous change to Fcopy_file.
2736 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2737 and without this change, GCC might complain about discarding
2738 fchown's return value.
2739
b5641435
JB
27402011-07-16 Juanma Barranquero <lekktu@gmail.com>
2741
2742 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2743
a8031457
PE
27442011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2745
2746 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2747
dd889327
LMI
27482011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2749
750c33f7
LMI
2750 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2751 it's used from the C level.
2752
dd889327
LMI
2753 * process.c: Use the same condition for POLL_FOR_INPUT in both
2754 keyboard.c and process.c (bug#1858).
2755
87e86684
LM
27562011-07-09 Lawrence Mitchell <wence@gmx.li>
2757
2758 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2759 (Fgnutls_boot): Use it.
2760
64348f40
AS
27612011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2762
2763 * doc.c (Fsubstitute_command_keys): Revert last change.
2764
1d698799
LMI
27652011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2766
f863868c
LMI
2767 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2768 quotes the next character, and doesn't affect other longer
2769 sequences (bug#8935).
2770
1d698799
LMI
2771 * lread.c (syms_of_lread): Clarify that is isn't only
2772 `eval-buffer' and `eval-defun' that's affected by
2773 `lexical-binding' (bug#8460).
2774
aa4b6df6
EZ
27752011-07-15 Eli Zaretskii <eliz@gnu.org>
2776
2777 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2778 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2779
5d856da6
PE
27802011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2781
ad6042bb
PE
2782 Fix minor problems found by static checking.
2783 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2784 (elsz): Now a signed constant, not a size_t var. We prefer signed
2785 types to unsigned, to avoid integer comparison confusion. Without
2786 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2787 "cannot optimize loop, the loop counter may overflow", a symptom
2788 of the confusion.
f00bbb22 2789 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2790 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2791
6468f31c
LMI
27922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2793
49080b10
LMI
2794 * search.c (Fre_search_backward): Mention `case-fold-search' in
2795 all the re_search_* functions (bug#8138).
2796
6468f31c
LMI
2797 * keyboard.c (Fopen_dribble_file): Document when the file is
2798 closed (bug#8056).
2799
c965adc5
EZ
28002011-07-14 Eli Zaretskii <eliz@gnu.org>
2801
df9733bf
EZ
2802 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2803 bidi_cache_idx.
2804
0bb23927
EZ
2805 Support bidi reordering of display and overlay strings.
2806 * xdisp.c (compute_display_string_pos)
2807 (compute_display_string_end): Accept additional argument STRING.
2808 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2809 (reseat_to_string): Initialize bidi_it->string.s and
2810 bidi_it->string.schars.
2811 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2812 NULL (avoids a crash in bidi_paragraph_init).
2813 Initialize itb.string.lstring.
0bb23927
EZ
2814 (init_iterator): Call bidi_init_it only of a valid
2815 buffer position was specified. Initialize paragraph_embedding to
2816 L2R.
2817 (reseat_to_string): Initialize the bidi iterator.
2818 (display_string): If we need to ignore text properties of
2819 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2820 original value of -1 will not work with bidi.)
2821 (compute_display_string_pos): First arg is now struct
2822 `text_pos *'; all callers changed. Support display properties on
2823 Lisp strings.
2824 (compute_display_string_end): Support display properties on Lisp
2825 strings.
2826 (init_iterator, reseat_1, reseat_to_string): Initialize the
2827 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2828 when iterating on a string not from display properties).
640c8776
SM
2829 (compute_display_string_pos, compute_display_string_end):
2830 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2831 arrow keys.
2832 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2833 base_level_stop; instead, set base_level_stop to BEGV.
2834 Fixes crashes in vertical-motion.
0bb23927
EZ
2835 (next_element_from_buffer): Improve commentary for when
2836 the iterator is before prev_stop.
2837 (init_iterator): Initialize bidi_p from the default value of
2838 bidi-display-reordering, not from buffer-local value. Use the
2839 buffer-local value only if initializing for buffer iteration.
2840 (handle_invisible_prop): Support invisible properties on strings
2841 that are being bidi-reordered.
2842 (set_iterator_to_next): Support bidi reordering of C strings and
2843 Lisp strings.
2844 (next_element_from_string): Support bidi reordering of Lisp
2845 strings.
2846 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2847 (display_string): Support display of R2L glyph rows.
2848 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2849 (init_iterator): Don't initialize it->bidi_p for strings
2850 here.
2851 (reseat_to_string): Initialize it->bidi_p for strings here.
2852 (next_element_from_string, next_element_from_c_string)
2853 (next_element_from_buffer): Add xassert's for correspondence
2854 between IT's object being iterated and it->bidi_it.string
2855 structure.
2856 (face_before_or_after_it_pos): Support bidi iteration.
2857 (next_element_from_c_string): Handle the case of the first string
2858 character that is not the first one in the visual order.
2859 (get_visually_first_element): New function, refactored from common
2860 parts of next_element_from_buffer, next_element_from_string, and
2861 next_element_from_c_string.
2862 (tool_bar_lines_needed, redisplay_tool_bar)
2863 (display_menu_bar): Force left-to-right direction. Add a FIXME
2864 comment for making that be controlled by a user option.
2865 (push_it, pop_it): Save and restore the state of the
2866 bidi iterator. Save and restore the bidi_p flag.
2867 (pop_it): Iterate out of display property for string iteration as
2868 well.
2869 (iterate_out_of_display_property): Support iteration over strings.
2870 (handle_single_display_spec): Set up it->bidi_it for iteration
2871 over a display string, and call bidi_init_it.
2872 (handle_single_display_spec, next_overlay_string)
2873 (get_overlay_strings_1, push_display_prop): Set up the bidi
2874 iterator for displaying display or overlay strings.
2875 (forward_to_next_line_start): Don't use the shortcut if
2876 bidi-iterating.
2877 (back_to_previous_visible_line_start): If handle_display_prop
2878 pushed the iterator stack, restore the internal state of the bidi
2879 iterator by calling bidi_pop_it same number of times.
2880 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2881 and we are bidi-iterating, don't decrement the iterator position;
2882 instead, set the first_elt flag in the bidi iterator, to produce
2883 the same effect.
2884 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2885 (push_display_prop): xassert that we are iterating a buffer.
2886 (push_it, pop_it): Save and restore paragraph_embedding member.
2887 (handle_single_display_spec, next_overlay_string)
2888 (get_overlay_strings_1, reseat_1, reseat_to_string)
2889 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2890 correctly. Don't assume unibyte strings are not bidi-reordered.
2891 (compute_display_string_pos)
2892 (compute_display_string_end): Fix handling the case of C string.
2893 (push_it, pop_it): Save and restore from_disp_prop_p.
2894 (handle_single_display_spec, push_display_prop): Set the
2895 from_disp_prop_p flag.
2896 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2897 (pop_it): Call iterate_out_of_display_property only if we are
2898 popping after iteration over a string that came from a display
2899 property. Fix a typo in popping stretch info. Add an assertion
2900 for verifying that the iterator position is in sync with the bidi
2901 iterator.
2902 (handle_single_display_spec, get_overlay_strings_1)
2903 (push_display_prop): Fix initialization of paragraph direction for
2904 string when that of the parent object is not yet determined.
2905 (reseat_1): Call bidi_init_it to resync the bidi
2906 iterator with IT's position. (Bug#7616)
2907 (find_row_edges): If ROW->start.pos gives position
2908 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2909 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2910 Reset the from_disp_prop_p flag.
2911 (SAVE_IT, RESTORE_IT): New macros.
2912 (pos_visible_p, face_before_or_after_it_pos)
2913 (back_to_previous_visible_line_start)
2914 (move_it_in_display_line_to, move_it_in_display_line)
2915 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2916 (try_scrolling, redisplay_window, display_line): Use them when
2917 saving a temporary copy of the iterator and restoring it back.
2918 (back_to_previous_visible_line_start, reseat_1)
2919 (init_iterator): Empty the bidi cache "stack".
2920 (move_it_in_display_line_to): If iterator ended up at
2921 EOL, but we never saw any buffer positions smaller than
2922 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2923 motion in bidi-reordered lines.
2924 (move_it_in_display_line_to): Record prev_method and prev_pos
2925 immediately before the call to set_iterator_to_next. Fixes cursor
2926 motion in bidi-reordered lines with stretch glyphs and strings
2927 displayed in margins. (Bug#8133) (Bug#8867)
2928 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2929 TO_CHARPOS.
640c8776
SM
2930 (pos_visible_p): Support positions in bidi-reordered lines.
2931 Save and restore bidi cache.
0bb23927
EZ
2932
2933 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2934 (bidi_paragraph_info): Delete unused struct.
2935 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2936 (bidi_cache_start): New variable.
2937 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2938 to zero.
2939 (bidi_cache_fetch_state, bidi_cache_search)
2940 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2941 (bidi_cache_find, bidi_peek_at_next_level)
2942 (bidi_level_of_next_char, bidi_find_other_level_edge)
2943 (bidi_move_to_visually_next): Compare cache index with
2944 bidi_cache_start rather than with zero.
2945 (bidi_fetch_char): Accept new argument STRING; all callers
2946 changed. Support iteration over a string. Support strings with
2947 display properties. Support unibyte strings. Fix the type of
2948 `len' according to what STRING_CHAR_AND_LENGTH expects.
2949 (bidi_paragraph_init, bidi_resolve_explicit_1)
2950 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2951 (bidi_level_of_next_char, bidi_move_to_visually_next):
2952 Support iteration over a string.
0bb23927
EZ
2953 (bidi_set_sor_type, bidi_resolve_explicit_1)
2954 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2955 can now be zero (for strings); special values 0 and -1 were
2956 changed to -1 and -2, respectively.
2957 (bidi_char_at_pos): New function.
2958 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2959 Call it instead of FETCH_MULTIBYTE_CHAR.
2960 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2961 initialized to valid values.
2962 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2963 values.
2964 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2965 the test for valid cached positions. Fix the logic for looking up
2966 the sentinel state in the cache. GCPRO the Lisp string we are
2967 iterating.
2968 (bidi_push_it, bidi_pop_it): New functions.
2969 (bidi_initialize): Initialize the bidi cache start stack pointer.
2970 (bidi_cache_ensure_space): New function, refactored from part of
2971 bidi_cache_iterator_state. Don't assume the required size is just
2972 one BIDI_CACHE_CHUNK away.
2973 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2974 (bidi_count_bytes, bidi_char_at_pos): New functions.
2975 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2976 always valid if bidi_cache_idx is valid.
2977 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2978 is valid if it's going to be used.
2979 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2980 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2981 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2982 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2983 (bidi_find_other_level_edge, bidi_cache_start_stack):
2984 All variables related to cache indices are now EMACS_INT.
c965adc5 2985
0bb23927
EZ
2986 * dispextern.h (struct bidi_string_data): New structure.
2987 (struct bidi_it): New member `string'. Make flag members be 1-bit
2988 fields, and put them last in the struct.
640c8776
SM
2989 (compute_display_string_pos, compute_display_string_end):
2990 Update prototypes.
0bb23927
EZ
2991 (bidi_push_it, bidi_pop_it): Add prototypes.
2992 (struct iterator_stack_entry): New members bidi_p,
2993 paragraph_embedding, and from_disp_prop_p.
2994 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2995 (bidi_shelve_cache, bidi_unshelve_cache):
2996 Declare prototypes.
0bb23927
EZ
2997
2998 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2999 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3000 and vector-like objects.
3001
3002 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3003 cache around display iteration.
3004
3005 * window.c (Fwindow_end, window_scroll_pixel_based)
3006 (displayed_window_lines, Frecenter): Save and restore the bidi
3007 cache around display iteration.
3008
3bbd2265
LMI
30092011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3010
3011 * editfns.c (Fdelete_region): Clarify the use of the named
3012 parameters (bug#6788).
3013
adc47434
MR
30142011-07-14 Martin Rudalics <rudalics@gmx.at>
3015
3016 * indent.c (Fvertical_motion): Set and restore w->pointm when
3017 saving and restoring the window's buffer (Bug#9006).
3018
837c31f8
LMI
30192011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3020
3021 * editfns.c (Fstring_to_char): Clarify just what is returned
3022 (bug#6576). Text by Eli Zaretskii.
3023
ac389d0c
JB
30242011-07-13 Juanma Barranquero <lekktu@gmail.com>
3025
3026 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3027
0be0ce47
EZ
30282011-07-13 Eli Zaretskii <eliz@gnu.org>
3029
3030 * buffer.c (mmap_find): Fix a typo.
3031
cd18e7e3
JB
30322011-07-13 Johan Bockgård <bojohan@gnu.org>
3033
3034 Fix execution of x selection hooks.
3035 * xselect.c (Qx_lost_selection_functions)
3036 (Qx_sent_selection_functions): New vars.
3037 (syms_of_xselect): DEFSYM them.
3038 (x_handle_selection_request): Pass Qx_sent_selection_functions
3039 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3040 (x_handle_selection_clear,x_clear_frame_selections):
3041 Pass Qx_lost_selection_functions rather than
3042 Vx_lost_selection_functions to Frun_hook_with_args.
3043
47ea7f44
PE
30442011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3045
ac389d0c 3046 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3047 The old code sometimes used this field without initializing it.
3048
47ea7f44
PE
3049 * alloc.c (gc_sweep): Don't read past end of array.
3050 In theory, the old code could also have corrupted Emacs internals,
3051 though it'd be very unlikely.
3052
bc985c87
AS
30532011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3054
3055 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3056 argument. (Bug#4026)
bc985c87 3057
0cf34688
LMI
30582011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3059
b3dadd76
LMI
3060 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3061 key" (bug#4257).
3062
0cf34688
LMI
3063 * window.c (Fset_window_start): Doc fix (bug#4199).
3064 (Fset_window_hscroll): Ditto.
3065
270768cd
PE
30662011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3067
077e3dda 3068 Fix minor new problems caught by GCC 4.6.1.
270768cd 3069 * term.c (init_tty): Remove unused local.
490011a6 3070 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3071 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3072 not used otherwise.
270768cd 3073
b1f58454
CY
30742011-07-12 Chong Yidong <cyd@stupidchicken.com>
3075
3076 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3077
22b9578d
LMI
30782011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3079
6e70ab07
LMI
3080 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3081 are the mini-buffer and the echo area (bug#3320).
3082
22b9578d
LMI
3083 * term.c (init_tty): Remove support for supdup, c10 and perq
3084 terminals, which are no longer supported (bug#1482).
3085
8974cc9f
JB
30862011-07-10 Johan Bockgård <bojohan@gnu.org>
3087
3088 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3089
a560d974
JD
30902011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3091
3092 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3093 for non-popups (Bug#3642).
3094
1dae0f0a
AS
30952011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3096
268c2c36 3097 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3098 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3099 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3100 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3101 * data.c (fmod): Likewise.
3102 * dispnew.c (swap_glyphs_in_rows): Likewise.
3103 * emacs.c (memory_warning_signal): Likewise.
3104 * floatfns.c (float_error): Likewise.
3105 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3106 (otf_open, font_otf_capability, generate_otf_features)
3107 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3108 Likewise.
3109 * image.c (pbm_read_file): Likewise.
3110 * indent.c (string_display_width): Likewise.
3111 * intervals.c (check_for_interval, search_for_interval)
3112 (inc_interval_count, count_intervals, root_interval)
3113 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3114 * lread.c (defalias): Likewise.
268c2c36 3115 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3116 * regex.c (set_image_of_range_1, set_image_of_range)
3117 (regex_grow_registers): Likewise.
3118 * sysdep.c (strerror): Likewise.
3119 * termcap.c (valid_filename_p, tprint, main): Likewise.
3120 * tparam.c (main): Likewise.
3121 * unexhp9k800.c (run_time_remap, save_data_space)
3122 (update_file_ptrs, read_header, write_header, calculate_checksum)
3123 (copy_file, copy_rest, display_header): Likewise.
3124 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3125 Likewise.
3126 * xdisp.c (check_it): Likewise.
3127 * xfaces.c (register_color, unregister_color, unregister_colors):
3128 Likewise.
3129 * xfns.c (print_fontset_result): Likewise.
3130 * xrdb.c (member, fatal, main): Likewise.
3131
99033785
PE
31322011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3133
3134 Fix minor problems found by static checking (Bug#9031).
3135 * chartab.c (char_table_set_range, map_sub_char_table):
3136 Remove unused locals.
3137 (uniprop_table): Now static.
3138 * composite.c (_work_char): Remove unused static var.
3139
9cb2ac56
JB
31402011-07-09 Juanma Barranquero <lekktu@gmail.com>
3141
3142 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3143
f25661f0
JD
31442011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3145
3146 * gtkutil.c (qttip_cb): Remove code without function.
3147
8278c4fe
EZ
31482011-07-09 Eli Zaretskii <eliz@gnu.org>
3149
3150 * w32.c (pthread_sigmask): New stub.
3151
1692ae2d 31522011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3153
8a6ebd58 3154 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3155 sigprocmask is portable only for single-threaded applications, and
3156 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3157 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3158 (LIBES): Use it.
3159 * callproc.c (Fcall_process):
3160 * process.c (create_process):
3161 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3162 Use pthread_sigmask, not sigprocmask.
123403e4 3163
1b854618
JD
31642011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3165
3166 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3167 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3168 wrong (Bug#8591).
3169
3fe4b549
JD
31702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3171
0ce7e563
JD
3172 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3173 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3174 (xg_hide_tooltip): Fix comment.
3175
3fe4b549
JD
3176 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3177 in registerServicesMenuSendTypes.
3178 (validRequestorForSendType): Don't check ns_return_types.
3179
3180 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3181 ns_return_type.
3182
5df75e47
JR
31832011-07-08 Jason Rumney <jasonr@gnu.org>
3184
22610910
JR
3185 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3186 SH_SHOW for hidden windows (Bug#5482).
3187
5df75e47
JR
3188 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3189 frame struct members of non-existent frames (Bug#6284).
3190
699c10bd
JD
31912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3192
4393663b
JD
3193 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3194 variable firstTime not needed on OSX >= 10.6.
3195 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3196 >= 10.5. Use setKnobProportion, setDoubleValue.
3197
3198 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3199 (MAC_OS_X_VERSION_10_5): Define if not defined.
3200 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3201 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3202 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3203
3204 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3205 cString and lossyCString on OSX >= 10.4
3206
58179cce 3207 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3208 sizeToFit on OSX >= 10.2.
3209
3210 * nsimage.m (allocInitFromFile): Don't use deprecated method
3211 bestRepresentationForDevice on OSX >= 10.6.
3212
3213 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3214 to avoid warning.
3215
3216 * emacs.c: Declare unexec_init_emacs_zone.
3217
a63e0781
JD
3218 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3219
699c10bd
JD
3220 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3221
3222 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3223 on svcsMenu (Bug#8842).
3224
3225 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3226 ns_return_types.
3227 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3228
3229 * nsterm.m (QUTF8_STRING): Declare.
3230 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3231 (validRequestorForSendType): Return type is (id).
3232 Change indexOfObjectIdenticalTo to indexOfObject.
3233 Check if we have local selection before returning self (Bug#8842).
3234 (writeSelectionToPasteboard): Put local selection into paste board
3235 if we have a local selection (Bug#8842).
3236 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3237
3238 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3239 (ns_get_local_selection): Declare.
3240
54e10184
LMI
32412011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3242
9888ff71
LMI
3243 * keymap.c (describe_map_tree): Don't insert a double newline at
3244 the end of the buffer (bug#1169) and return whether we inserted
3245 something.
3246
54e10184
LMI
3247 * callint.c (Fcall_interactively): Change "reading args" to
3248 "providing args" to try to clarify what it does (bug#1010).
3249
15fa4783
KH
32502011-07-07 Kenichi Handa <handa@m17n.org>
3251
3252 * composite.c (composition_compute_stop_pos): Ignore a static
3253 composition starting before CHARPOS (Bug#8915).
3254
3255 * xdisp.c (handle_composition_prop): Likewise.
3256
a8815b00
EZ
32572011-07-07 Eli Zaretskii <eliz@gnu.org>
3258
3259 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3260 (Bug#9015)
3261
ef7b981d 32622011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3263
3264 * character.h (unicode_category_t): New enum type.
3265
3266 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3267 (Qchar_code_property_table): New variable.
3268 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3269 (UNIPROP_COMPRESSED_FORM_P): New macros.
3270 (char_table_ascii): Uncompress the compressed values.
3271 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3272 Uncompress the compressed values.
ac389d0c 3273 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3274 (char_table_ref_and_range): Uncompress the compressed values.
3275 (sub_char_table_set): New arg is_uniprop. Callers changed.
3276 Uncompress the compressed values.
3277 (sub_char_table_set_range): Args changed. Callers changed.
3278 (char_table_set_range): Adjuted for the above change.
3279 (map_sub_char_table): Delete args default_val and parent. Add arg
3280 top. Give decoded values to a Lisp function.
640c8776 3281 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3282 values to a Lisp function. Gcpro more variables.
3283 (uniprop_table_uncompress)
3284 (uniprop_decode_value_run_length): New functions.
3285 (uniprop_decoder, uniprop_decoder_count): New variables.
3286 (uniprop_get_decoder, uniprop_encode_value_character)
3287 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3288 New functions.
3289 (uniprop_encoder, uniprop_encoder_count): New variables.
3290 (uniprop_get_encoder, uniprop_table)
3291 (Funicode_property_table_internal, Fget_unicode_property_internal)
3292 (Fput_unicode_property_internal): New functions.
3293 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3294 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3295 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3296 char-code-property-alist.
3297
640c8776 3298 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3299 Vunicode_category_table.
3300
640c8776 3301 * font.c (font_range): Adjust for the change of
c805dec0
KH
3302 Vunicode_category_table.
3303
76b397fb
DN
33042011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3305
3306 * m/iris4d.h: Remove file, move contents ...
3307 * s/irix6-5.h: ... here.
3308
22b4128e
PE
33092011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3310
3311 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3312 * alloc.c (mark_buffer):
3313 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3314 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3315 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3316 This isn't true in general, and it's particularly not true
3317 if Emacs is configured with --with-wide-int.
3318 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3319 New macros, used in the buffer.c change.
3320
869795d6
JD
33212011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3322
3323 * xsettings.c: Use both GConf and GSettings if both are available.
3324 (store_config_changed_event): Add comment.
3325 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3326 (store_tool_bar_style_changed): New functions.
5e617bc2 3327 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3328 (struct xsettings): Move font inside HAVE_XFT.
3329 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3330 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3331 Move inside HAVE_XFT.
640c8776 3332 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3333 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3334 also.
3335 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3336 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3337 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3338 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3339 (parse_settings): Move check for font inside HAVE_XFT.
3340 (read_settings, apply_xft_settings): Add comment.
3341 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3342 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3343 call store_font_name_changed.
3344 (xft_settings_event): Add comment.
3345 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3346 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3347 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3348 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3349 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3350 (xsettings_get_system_font, xsettings_get_system_normal_font):
3351 Add comment.
869795d6 3352
d8ed26bd
PE
33532011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3354
3355 Random fixes. E.g., (random) never returned negative values.
3356 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3357 subseconds part to the entropy, as that's a bit more random.
3358 Prefer signed to unsigned, since the signedness doesn't matter and
3359 in general we prefer signed. When given a limit, use a
3360 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3361 latter isn't right if USE_2_TAGS_FOR_INTS.
3362 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3363 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3364
cabf1cac
SM
33652011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3366
3367 * textprop.c (text_property_stickiness):
3368 Obey Vtext_property_default_nonsticky.
3369 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3370 * w32fns.c (syms_of_w32fns):
3371 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3372
6e9b2be9
PE
33732011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3374
3375 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3376 This is more efficient than Ffile_directory_p and avoids a minor race.
3377
90186c68
LMI
33782011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3379
7c301272
LMI
3380 * buffer.c (Foverlay_put): Say what the return value is
3381 (bug#7835).
3382
c4f2d8d4
LMI
3383 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3384 is a directory before asking whether to use the file name
3385 (bug#7564).
ad637907
LMI
3386 (barf_or_query_if_file_exists): Make the "File is a directory"
3387 error be more correct.
c4f2d8d4 3388
90186c68
LMI
3389 * fns.c (Frequire): Remove the mention of the .gz files, since
3390 that's installation-specific, but keep the mention of
3391 `get-load-suffixes'.
3392
da64016e
PE
33932011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3394
3395 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3396 Report string overflow if the output is too long.
3397
7d47b580
JB
33982011-07-04 Juanma Barranquero <lekktu@gmail.com>
3399
a555cb87
JB
3400 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3401 (syms_of_gnutls): Remove duplicate DEFSYM for
3402 Qgnutls_bootprop_verify_hostname_error, an error for
3403 Qgnutls_bootprop_verify_error (which is no longer used).
3404
7d47b580
JB
3405 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3406 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3407 Also (re)move comments that are misplaced or no longer relevant.
3408
1e49bfab
LMI
34092011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3410
3411 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3412
1485f4c0
CY
34132011-07-03 Chong Yidong <cyd@stupidchicken.com>
3414
3415 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3416 and background color parameters if they have been changed.
3417
a9ab721e
LMI
34182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3419
3420 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3421
cf7cff57
PE
34222011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3423
2e13213d
PE
3424 * xsettings.c (SYSTEM_FONT): Define only when used.
3425 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3426
cf7cff57
PE
3427 * keymap.c (access_keymap_1): Now static.
3428
7a8e04f7
CY
34292011-07-02 Chong Yidong <cyd@stupidchicken.com>
3430
3431 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3432 leave any prefix arg for the up event (Bug#1586).
3433
61352f62
LMI
34342011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3435
69bb1ef7
LMI
3436 * lread.c (syms_of_lread): Mention single symbols defined by
3437 `defvar' or `defconst' (bug#7154).
3438
61352f62 3439 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3440 (Frequire): Mention get-load-suffixes.
61352f62 3441
28545e04
MR
34422011-07-02 Martin Rudalics <rudalics@gmx.at>
3443
3444 * window.h (window): Remove clone_number slot.
3445 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3446 Remove.
3447 (make_parent_window, make_window, saved_window)
3448 (Fset_window_configuration, save_window_save): Don't deal with
3449 clone numbers.
3450 * buffer.c (Qclone_number): Remove declaration.
3451 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3452
3349e122
SM
34532011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3454
3455 Add multiple inheritance to keymaps.
3456 * keymap.c (Fmake_composed_keymap): New function.
3457 (Fset_keymap_parent): Simplify.
3458 (fix_submap_inheritance): Remove.
3459 (access_keymap_1): New function extracted from access_keymap to handle
3460 embedded parents and handle lists of maps.
3461 (access_keymap): Use it.
3462 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3463 (Fcopy_keymap): Handle embedded parents.
3464 (Fcommand_remapping, define_as_prefix): Simplify.
3465 (Fkey_binding): Simplify.
3466 (syms_of_keymap): Move minibuffer-local-completion-map,
3467 minibuffer-local-filename-completion-map,
3468 minibuffer-local-must-match-map, and
3469 minibuffer-local-filename-must-match-map to Elisp.
3470 (syms_of_keymap): Defsubr make-composed-keymap.
3471 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3472 (parse_menu_item): Trivial simplification.
3473
3279eb87
GM
34742011-07-01 Glenn Morris <rgm@gnu.org>
3475
3476 * Makefile.in (SETTINGS_LIBS): Fix typo.
3477
4550efdf
KI
34782011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3479
3480 * coding.c (Fencode_coding_string): Record the last coding system
3481 used, as the function doc string says (bug#8738).
3482
0949d2b6
JD
34832011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3484
3485 * xsettings.c (store_monospaced_changed): Take new font as arg and
3486 check for change against current_mono_font.
3487 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3488 (emacs_settings_constructor, emacs_settings_get_property)
3489 (emacs_settings_set_property, emacs_settings_class_init)
3490 (emacs_settings_init, gsettings_obj): Remove.
3491 (something_changedCB): New function for HAVE_GSETTINGS.
3492 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3493 with value as argument.
3494 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3495 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3496 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3497 "changed".
3498
3499 * xgselect.c: Add defined (HAVE_GSETTINGS).
3500 (xgselect_initialize): Ditto.
3501
3502 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3503 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3504 xg_select.
3505
bbc6b304
PE
35062011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3507
3508 * eval.c (struct backtrace): Simplify and port the data structure.
3509 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3510 signed bit field, as this assumption is not portable and it makes
3511 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3512 "char debug_on_exit : 1" as this is not portable either; instead,
3513 use the portable "unsigned int debug_on_exit : 1". Remove unused
3514 member evalargs. Remove obsolete comments about cc bombing out.
3515
9851bfc5
JD
35162011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3517
51bb811f 3518 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3519 Let HAVE_GSETTINGS override HAVE_GCONF.
3520 (store_monospaced_changed): New function.
3521 (EMACS_SETTINGS): A new type derived from GObject to handle
3522 GSettings notifications.
3523 (emacs_settings_constructor, emacs_settings_get_property)
3524 (emacs_settings_set_property, emacs_settings_class_init):
3525 New functions.
3526 (gsettings_client, gsettings_obj): New variables.
3527 (GSETTINGS_SCHEMA): New define.
3528 (something_changedCB): Call store_monospaced_changed.
3529 (init_gsettings): New function.
3530 (xsettings_initialize): Call init_gsettings.
3531 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3532 to NULL.
3533
640c8776 3534 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3535 GCONF_CFLAGS/LIBS.
3536
5386012d
MR
35372011-06-29 Martin Rudalics <rudalics@gmx.at>
3538
3539 * window.c (resize_root_window, grow_mini_window)
3540 (shrink_mini_window): Rename Qresize_root_window to
3541 Qwindow_resize_root_window and Qresize_root_window_vertically to
3542 Qwindow_resize_root_window_vertically.
3543
f13e0b08
PE
35442011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3545
3546 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3547
94515237
JB
35482011-06-27 Juanma Barranquero <lekktu@gmail.com>
3549
3550 * makefile.w32-in: Redesign dependencies so they reflect more
3551 clearly which files are directly included by each source file,
3552 and not through other includes.
3553
e43b6e43
MR
35542011-06-27 Martin Rudalics <rudalics@gmx.at>
3555
3556 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3557 (sort_overlays, overlay_strings): When an overlay's clone number
3558 matches the window's clone number process the overlay even if
3559 the overlay's window property doesn't match the current window.
3560
d68443dc
MR
3561 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3562 (Fwindow_hchild): Rename to Fwindow_left_child.
3563 (Fwindow_next): Rename to Fwindow_next_sibling.
3564 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3565 (resize_window_check): Rename to window_resize_check.
3566 (resize_window_apply): Rename to window_resize_apply.
3567 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3568 (Fdelete_other_windows_internal, resize_frame_windows)
3569 (Fsplit_window_internal, Fdelete_window_internal)
3570 (grow_mini_window, shrink_mini_window)
3571 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3572
c7e73be5
JD
35732011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3574
3575 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3576 (emacs_fixed_set_min_size): Remove.
3577 (emacs_fixed_new): Take frame as argument.
3578
3579 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3580 (_EmacsFixedPrivate): Remove minwidth/height.
3581 Add struct frame *f.
3582 (emacs_fixed_init): Initialize priv->f.
3583 (get_parent_class, emacs_fixed_set_min_size): Remove.
3584 (emacs_fixed_new): Set priv->f to argument.
3585 (emacs_fixed_get_preferred_width)
3586 (emacs_fixed_get_preferred_height): Use min_width/height from
3587 frames size_hint to set minimum and natural (Bug#8919).
3588 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3589 and use min_width/height from frames size_hint to set
3590 min_width/height (Bug#8919).
3591
3592 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3593 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3594 Fix indentation.
c7e73be5 3595
cf99dcf8
EZ
35962011-06-26 Eli Zaretskii <eliz@gnu.org>
3597
3598 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3599 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3600 called at ZV.
3601
029529ac
CY
36022011-06-26 Chong Yidong <cyd@stupidchicken.com>
3603
3604 * process.c (wait_reading_process_output): Bypass select if
3605 waiting for a cell while ignoring keyboard input, and input is
3606 pending. Suggested by Jan Djärv (Bug#8869).
3607
7a7ef429
PE
36082011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3609
3610 Use gnulib's dup2 module instead of rolling our own.
3611 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3612
11fdef7d 36132011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3614
3615 * dispnew.c (scrolling_window): Before scrolling, turn off a
3616 mouse-highlight in the window being scrolled.
3617
cd3520a4
JB
36182011-06-24 Juanma Barranquero <lekktu@gmail.com>
3619
3620 Move DEFSYM to lisp.h and use everywhere.
3621
3622 * character.h (DEFSYM): Move declaration...
3623 * lisp.h (DEFSYM): ...here.
3624
3625 * gnutls.c:
3626 * minibuf.c:
3627 * w32menu.c:
3628 * w32proc.c:
3629 * w32select.c: Don't include character.h.
3630
3631 * alloc.c (syms_of_alloc):
3632 * buffer.c (syms_of_buffer):
3633 * bytecode.c (syms_of_bytecode):
3634 * callint.c (syms_of_callint):
3635 * casefiddle.c (syms_of_casefiddle):
3636 * casetab.c (init_casetab_once):
3637 * category.c (init_category_once, syms_of_category):
3638 * ccl.c (syms_of_ccl):
3639 * cmds.c (syms_of_cmds):
3640 * composite.c (syms_of_composite):
3641 * dbusbind.c (syms_of_dbusbind):
3642 * dired.c (syms_of_dired):
3643 * dispnew.c (syms_of_display):
3644 * doc.c (syms_of_doc):
3645 * editfns.c (syms_of_editfns):
3646 * emacs.c (syms_of_emacs):
3647 * eval.c (syms_of_eval):
3648 * fileio.c (syms_of_fileio):
3649 * fns.c (syms_of_fns):
3650 * frame.c (syms_of_frame):
3651 * fringe.c (syms_of_fringe):
3652 * insdel.c (syms_of_insdel):
3653 * keymap.c (syms_of_keymap):
3654 * lread.c (init_obarray, syms_of_lread):
3655 * macros.c (syms_of_macros):
3656 * msdos.c (syms_of_msdos):
3657 * print.c (syms_of_print):
3658 * process.c (syms_of_process):
3659 * search.c (syms_of_search):
3660 * sound.c (syms_of_sound):
3661 * syntax.c (init_syntax_once, syms_of_syntax):
3662 * terminal.c (syms_of_terminal):
3663 * textprop.c (syms_of_textprop):
3664 * undo.c (syms_of_undo):
3665 * w32.c (globals_of_w32):
3666 * window.c (syms_of_window):
3667 * xdisp.c (syms_of_xdisp):
3668 * xfaces.c (syms_of_xfaces):
3669 * xfns.c (syms_of_xfns):
3670 * xmenu.c (syms_of_xmenu):
3671 * xsettings.c (syms_of_xsettings):
3672 * xterm.c (syms_of_xterm): Use DEFSYM.
3673
4228cf16
TZ
36742011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3675
cd3520a4 3676 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3677
7fcccf1e
PE
36782011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3679
7efb4e0e
PE
3680 Integer and buffer overflow fixes (Bug#8873).
3681
ff5844ad
PE
3682 * print.c (printchar, strout): Check for string overflow.
3683 (PRINTPREPARE, printchar, strout):
3684 Don't set size unless allocation succeeds.
3685
90532f02
PE
3686 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3687 for sizes. Check for string overflow more accurately.
3688 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3689
6d84508d
PE
3690 * macros.c: Integer and buffer overflow fixes.
3691 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3692 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3693 Use ptrdiff_t, not int, for sizes.
3694 Don't increment bufsize until after realloc succeeds.
3695 Check for size-calculation overflow.
3696 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3697
437b2cb4
PE
3698 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3699
8b9ac8b4
PE
3700 * lread.c: Integer overflow fixes.
3701 (read_integer): Radix is now EMACS_INT, not int,
3702 to improve quality of diagnostics for out-of-range radices.
3703 Calculate buffer size correctly for out-of-range radices.
3704 (read1): Check for integer overflow in radices, and in
3705 read-circle numbers.
82cb60d3
PE
3706 (read_escape): Avoid int overflow.
3707 (Fload, openp, read_buffer_size, read1)
3708 (substitute_object_recurse, read_vector, read_list, map_obarray):
3709 Use ptrdiff_t, not int, for sizes.
3710 (read1): Use EMACS_INT, not int, for sizes.
20270765 3711 Check for size overflow.
8b9ac8b4 3712
7fcccf1e
PE
3713 * image.c (cache_image): Check for size arithmetic overflow.
3714
bfbbd7e7
PE
3715 * lread.c: Integer overflow issues.
3716 (saved_doc_string_size, saved_doc_string_length)
3717 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3718 Now ptrdiff_t, not int.
3719 (read1): Don't assume doc string length fits in int. Check for
3720 out-of-range doc string lengths.
3721 (read_list): Don't assume file position fits in int.
39019e54 3722 (read_escape): Check for hex character overflow.
bfbbd7e7 3723
4e323265
LL
37242011-06-22 Leo Liu <sdl.web@gmail.com>
3725
3726 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3727 Move to minibuffer.el.
3728
85fece3e
PE
37292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3730
20b84ce9 3731 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3732 The following patches are for when GLYPH_DEBUG && !XASSERT.
3733 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3734 * dispnew.c (flush_stdout):
3735 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3736 Mark as externally visible.
3737 * dispnew.c (check_window_matrix_pointers): Now static.
3738 * dispnew.c (window_to_frame_vpos):
3739 * xfns.c (unwind_create_frame):
3740 * xterm.c (x_check_font): Remove unused local.
3741 * scroll.c (CHECK_BOUNDS):
3742 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3743 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3744 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3745 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3746 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3747 Now static.
3748 (debug_method_add): Use va_list and vsprintf rather than relying
3749 on undefined behavior with wrong number of arguments.
3750 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3751 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3752 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3753 since we're not interested in debugging glyphs with old libraries.
3754 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3755 GCC 4.6.0's static checking.
3756
0766b489
PE
37572011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3758
31fd4b32
PE
3759 Integer overflow and signedness fixes (Bug#8873).
3760 A few related buffer overrun fixes, too.
3761
b79e8648
PE
3762 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3763
0766b489
PE
3764 * dispextern.h (struct face.stipple):
3765 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3766 (x_bitmap_mask, x_allocate_bitmap_record)
3767 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3768 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3769 (x_create_bitmap_from_xpm_data):
3770 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3771 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3772 (.bitmaps_last):
3773 * xfaces.c (load_pixmap):
3774 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3775 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3776 (.bitmaps_last, struct x_output.icon_bitmap):
3777 Use ptrdiff_t, not int, for bitmap indexes.
3778 (x_allocate_bitmap_record): Check for size overflow.
3779 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3780
b081724f
PE
3781 Use ptrdiff_t, not int, for overlay counts.
3782 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3783 * editfns.c (overlays_around, get_pos_property):
3784 * textprop.c (get_char_property_and_overlay):
3785 * xdisp.c (next_overlay_change, note_mouse_highlight):
3786 * xfaces.c (face_at_buffer_position):
21514da7
PE
3787 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3788 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3789 (Fnext_overlay_change, Fprevious_overlay_change)
3790 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3791 Use ptrdiff_t, not int, for sizes.
21514da7 3792 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3793
3de73e5e
PE
3794 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3795
2606c57b
PE
3796 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3797 (x_session_initialize): Do not assume string length fits in int.
3798
aaafe47a
PE
3799 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3800 This is unlikely, but can occur if DPI is outlandish.
3801
2674ddc8 3802 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3803 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3804
28154962
PE
3805 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3806 * xrdb.c (magic_file_p, search_magic_path):
3807 Omit last arg SUFFIX; it was always 0. All callers changed.
3808 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3809
7de51af5
PE
3810 * xfont.c (xfont_match): Avoid need for strlen.
3811
25ed6cc3
PE
3812 * xfns.c: Don't assume strlen fits in int.
3813 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3814
4eab31dd
PE
3815 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3816 not unsigned long, as we prefer signed integers. All callers changed.
3817 Detect integer overflow in repeat count.
3818 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3819 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3820
171e2a58
PE
3821 * termcap.c: Don't assume sizes fit in int and never overflow.
3822 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3823 (gobble_line): Check for size-calculation overflow.
3824
ad39faca 3825 * minibuf.c (Fread_buffer):
6e5bb2dc 3826 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3827 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3828 Don't assume string length fits in int.
3829
52c61c22 3830 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3831 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3832
b5b8c9e5
PE
3833 * font.c: Don't assume string length fits in int.
3834 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3835 Use ptrdiff_t, not int.
ccd6111c
PE
3836 (font_intern_prop): Don't assume string length fits in int.
3837 Don't assume integer property fits in fixnum.
3838 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3839
882f0d81 3840 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3841 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3842 Reformulate so as not to need the command string.
3843 Invoke gzip -cd rather than gunzip, as it's more portable.
3844 (lock_info_type, lock_file_1, lock_file):
3845 Don't assume pid_t and time_t fit in unsigned long.
3846 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3847 (current_lock_owner): Prefer signed type for sizes.
3848 Use memcpy, not strncpy, where memcpy is what is really wanted.
3849 Don't assume (via atoi) that time_t and pid_t fit in int.
3850 Check for time_t and/or pid_t out of range, e.g., via a network share.
3851 Don't alloca where an auto var works fine.
3852
93f4cf88
PE
3853 * fileio.c: Fix some integer overflow issues.
3854 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3855 Don't assume string length fits in int.
3856 (directory_file_name): Don't assume string length fits in long.
3857 (make_temp_name): Don't assume pid fits in int, or that its print
3858 length is less than 20.
3859
f3e92b69
PE
3860 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3861
1bfdaf10
PE
3862 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3863
35016e9a
PE
3864 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3865
3d1e65a1
PE
3866 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3867 We prefer signed integers, even for size calculations.
3868
0b963a93
PE
3869 * emacs.c: Don't assume string length fits in 'int'.
3870 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3871 (main): Don't invoke strlen when not needed.
3872
573f4b54
PE
3873 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3874 (XD_DEBUG_MESSAGE): Don't waste a byte.
3875
989f33ba
PE
3876 * callproc.c (getenv_internal_1, getenv_internal)
3877 (Fgetenv_internal):
965d34eb
PE
3878 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3879
e4d29b33
PE
3880 * lread.c (invalid_syntax): Omit length argument.
3881 All uses changed. This doesn't fix a bug, but it simplifies the
3882 code away from its former Hollerith-constant appearance, and it's
3883 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3884 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3885
eb49b136
PE
3886 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3887 This didn't break anything, but it didn't help either.
3888 It's confusing to put a bogus integer in a place where the actual
3889 value does not matter.
9f62aeb1 3890 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3891 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3892
15375a22
PE
3893 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3894 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3895 implementation.
b61cc01c
PE
3896 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3897 We prefer signed types, and the value cannot exceed the EMACS_INT
3898 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3899 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3900 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3901 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3902
53b2623d
PE
3903 * indent.c (sane_tab_width): New function.
3904 (current_column, scan_for_column, Findent_to, position_indentation)
3905 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3906 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3907
51cab52b 3908 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3909
f2ed8a70
PE
3910 * lisp.h (lint_assume): New macro.
3911 * composite.c (composition_gstring_put_cache):
3912 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3913
abe80cc6
PE
3914 * editfns.c, insdel.c:
3915 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3916
b02c740e
PE
3917 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3918
ebc96716
PE
3919 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3920
b4e50fa0 3921 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3922 Use much-faster test for byte-length change.
311d5d7c 3923 Don't assume string byte-length fits in 'int'.
a4cf38e4 3924 Check that character arg fits in 'int'.
85461888 3925 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3926
c0c1ee9f
PE
3927 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3928
a498d7f4
PE
3929 * fns.c (concat): Catch string overflow earlier.
3930 Do not rely on integer wraparound.
3931
51cab52b
PE
3932 * dispextern.h (struct it.overlay_strings_charpos)
3933 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3934 * xdisp.c (forward_to_next_line_start)
3935 (back_to_previous_visible_line_start)
3936 (reseat_at_next_visible_line_start, next_element_from_buffer):
3937 Don't arbitrarily truncate the value of 'selective' to int.
3938
76031fad
PE
3939 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3940
5eb55db9
PE
3941 * composite.c: Don't truncate sizes to 'int'.
3942 (composition_gstring_p, composition_reseat_it)
3943 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3944 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3945 not EMACS_UINT, for indexes.
5eb55db9 3946
0703a717
PE
3947 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3948
d6202519
PE
3949 * buffer.c: Include <verify.h>.
3950 (struct sortvec.priority, struct sortstr.priority):
8961a454 3951 Now EMACS_INT, not int.
c20998a7 3952 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3953 (struct sortstr.size, record_overlay_string)
3954 (struct sortstrlist.size, struct sortlist.used):
3955 Don't truncate size to int.
3956 (record_overlay_string): Check for size-calculation overflow.
d6202519 3957 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3958
d5a19415
JM
39592011-06-22 Jim Meyering <meyering@redhat.com>
3960
029529ac 3961 Don't leak an XBM-image-sized buffer
d5a19415
JM
3962 * image.c (xbm_load): Free the image buffer after using it.
3963
a9041e6c
PE
39642011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3965
3966 Port to Sun C.
3967 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3968 that Sun C diagnosed.
3969 * fns.c (secure_hash): Fix pointer signedness issue.
3970 * intervals.c (static_offset_intervals): New function.
3971 (offset_intervals): Use it.
3972
7f3f739f
LL
39732011-06-21 Leo Liu <sdl.web@gmail.com>
3974
3975 * deps.mk (fns.o):
3976 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3977 sha512.h.
3978
3979 * fns.c (secure_hash): Rename from crypto_hash_function and change
3980 the first arg to accept symbols.
5b66d427 3981 (Fsecure_hash): New primitive.
7f3f739f
LL
3982 (syms_of_fns): New symbols.
3983
76147d94
DD
39842011-06-20 Deniz Dogan <deniz@dogan.se>
3985
3986 * process.c (Fset_process_buffer): Clarify return value in
3987 docstring.
3988
7d7d0045
CY
39892011-06-18 Chong Yidong <cyd@stupidchicken.com>
3990
3991 * dispnew.c (add_window_display_history): Use BVAR.
3992
3993 * xdisp.c (debug_method_add): Use BVAR.
3994 (check_window_end, dump_glyph_matrix, dump_glyph)
3995 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3996
3997 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3998 Likewise.
3999
4000 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4001 check till after the cache is created in init_frame_faces.
4002
ff2bc410
SM
40032011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4004
4005 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4006
28177add
PE
40072011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4008
dd3482fe
PE
4009 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4010 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4011 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4012
393d71f3 4013 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4014 * fileio.c (Finsert_file_contents):
4015 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4016 Remove the old (too-loose) buffer overflow checks.
4017 They weren't needed, since make_gap checks for buffer overflow.
4018 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4019 The old code merely checked for Emacs fixnum overflow, and relied
4020 on undefined (wraparound) behavior. The new code avoids undefined
4021 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4022
2e6813b0 4023 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4024 Tune. Don't use wider integers than needed. Don't use alloca.
4025 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4026
599a9e4f
PE
4027 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4028
99561444
PE
4029 * insdel.c, lisp.h (buffer_overflow): New function.
4030 (insert_from_buffer_1, replace_range, replace_range_2):
4031 * insdel.c (make_gap_larger):
4032 * editfns.c (Finsert_char):
4033 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4034
28177add
PE
4035 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4036
e69dafad
PE
40372011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4038
a7af7fde 4039 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4040
b1c46f02
PE
4041 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4042 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4043
e69dafad
PE
4044 * fileio.c: Don't assume EMACS_INT fits in off_t.
4045 (emacs_lseek): New static function.
4046 (Finsert_file_contents, Fwrite_region): Use it.
4047 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4048
566684ea
PE
4049 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4050
e6966cd6
PE
4051 * fns.c: Don't overflow int when computing a list length.
4052 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4053 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4054 truncation on 64-bit hosts. Check for QUIT every
4055 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4056 faster and is responsive enough.
4057 (Flength): Report an error instead of overflowing an integer.
4058 (Fsafe_length): Return a float if the value is not representable
4059 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4060 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4061 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4062
dd0b0efb
PE
4063 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4064 (header_size, word_size): New constants.
4065 (allocate_vectorlike): Don't check size overflow here.
4066 (allocate_vector): Check it here instead, since this is the only
4067 caller of allocate_vectorlike that could cause overflow.
4068 Check that the new vector's length is representable as a fixnum.
4069
86fe5cfe
PE
4070 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4071 The previous code was bogus. For example, next_almost_prime (32)
4072 returned 39, which is undesirable as it is a multiple of 3; and
4073 next_almost_prime (24) returned 25, which is a multiple of 5 so
4074 why was the code bothering to check for multiples of 7?
4075
80e88859
PE
4076 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4077
4a2f0ad6
PE
4078 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4079
f66c7cf8
PE
4080 Variadic C functions now count arguments with ptrdiff_t.
4081 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4082 Back then I didn't know that the Emacs coding style prefers signed int.
4083 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4084 were being counted with int, which may truncate counts on 64-bit
4085 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4086 * lisp.h (struct Lisp_Subr.function.aMANY)
4087 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4088 Arg counts are now ptrdiff_t, not size_t.
4089 All variadic functions and their callers changed accordingly.
4090 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4091 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4092 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4093 * callint.c (Fcall_interactively): Check arg count for overflow,
4094 to avoid potential buffer overrun. Use signed char, not 'int',
4095 for 'varies' array, so that we needn't bother to check its size
4096 calculation for overflow.
4097 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4098 * eval.c (apply_lambda):
4099 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4100 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4101 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4102
a1759b76
PE
4103 * callint.c (Fcall_interactively): Don't use index var as event count.
4104
d96be9fc
PE
4105 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4106 * mem-limits.h (SIZE): Remove; no longer used.
4107
a690a978 4108 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4109
578c21e6
PE
4110 Remove unnecessary casts.
4111 * xterm.c (x_term_init):
4112 * xfns.c (x_set_border_pixel):
4113 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4114 These aren't needed now that we assume ANSI C.
4115
96f53c6c
PE
4116 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4117 It's more likely to cause problems (due to unsigned overflow)
4118 than to cure them.
4119
83c77d31
PE
4120 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4121
ee2079f1
PE
4122 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4123
6da65536
PE
4124 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4125
7147c4a4
PE
4126 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4127
193e32d9
PE
4128 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4129
e5533da6
PE
4130 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4131
9910e595
PE
4132 GLYPH_CODE_FACE returns EMACS_INT, not int.
4133 * dispextern.h (merge_faces):
4134 * xfaces.c (merge_faces):
01103c44
PE
4135 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4136 Don't assume EMACS_INT fits in int.
9910e595 4137
2638320e
PE
4138 * character.h (CHAR_VALID_P): Remove unused parameter.
4139 * fontset.c, lisp.h, xdisp.c: All uses changed.
4140
045eb8d9
PE
4141 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4142
c1f134b5
PE
4143 * fns.c (concat): Minor tuning based on overflow analysis.
4144 This doesn't fix any bugs. Use int to hold character, instead
4145 of constantly refetching from Emacs object. Use XFASTINT, not
4146 XINT, for value known to be a character. Don't bother comparing
4147 a single byte to 0400, as it's always less.
4148
395fcb93 4149 * floatfns.c (Fexpt):
327eeec8
PE
4150 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4151
abbd3d23
PE
4152 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4153 for characters.
4154
684a03ef
PE
4155 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4156
0fed43f3
PE
4157 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4158 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4159 incorrectly succeed when S was a string, because 4294967386 was
4160 truncated before it was used.
4161
8fd02eb7
PE
4162 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4163 Otherwise, an out-of-range integer could cause undefined behavior
4164 on a 64-bit host.
4165
f8c86b69
PE
4166 * composite.c: Use int, not EMACS_INT, for characters.
4167 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4168 EMACS_INT, for values that are known to be in character range.
4169 This doesn't fix any bugs but is the usual style inside Emacs and
4170 may generate better code on 32-bit machines.
4171
34206dd2
PE
4172 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4173 This is for reasons similar to the recent CHAR_STRING fix.
4174 * charset.c (Fencode_char): Check that character arg is actually
4175 a character. Pass an int to ENCODE_CHAR.
4176 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4177 wider than 'int', as a compile-time check to prevent future regressions
4178 in this area.
4179
c5958d4c 4180 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4181
4182 Make sure a 64-bit char is never passed to CHAR_STRING.
4183 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4184 by silently ignoring the top 32 bits, allowing some values
4185 that were far too large to be valid characters.
4186 * character.h: Include <verify.h>.
4187 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4188 arguments are no wider than unsigned, as a compile-time check
4189 to prevent future regressions in this area.
4190 * data.c (Faset):
01103c44 4191 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4192 (Fsubst_char_in_region):
4193 * fns.c (concat):
4194 * xdisp.c (decode_mode_spec_coding):
4195 Adjust to CHAR_STRING's new requirement.
4196 * editfns.c (Finsert_char, Fsubst_char_in_region):
4197 * fns.c (concat): Check that character args are actually
4198 characters. Without this test, these functions did the wrong
4199 thing with wildly out-of-range values on 64-bit hosts.
4200
d37ca623
PE
4201 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4202 These casts should not be needed on 32-bit hosts, either.
4203 * keyboard.c (read_char):
4204 * lread.c (Fload): Remove casts to unsigned.
4205
ea204efb
PE
4206 * lisp.h (UNSIGNED_CMP): New macro.
4207 This fixes comparison bugs on 64-bit hosts.
4208 (ASCII_CHAR_P): Use it.
4209 * casefiddle.c (casify_object):
01103c44 4210 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4211 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4212 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4213 * dispextern.h (FACE_FROM_ID):
4214 * keyboard.c (read_char): Use UNSIGNED_CMP.
4215
41cb286c
PE
4216 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4217 not to EMACS_INT, to avoid GCC warning.
4218
4a1b9832
PE
4219 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4220
55daad71
PE
4221 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4222 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4223 isn't needed on 32-bit machines.
8f95c75c 4224
01103c44
PE
4225 * buffer.c (Fgenerate_new_buffer_name):
4226 Use EMACS_INT for count, not int.
0ceccced 4227 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4228
4229 * data.c (Qcompiled_function): Now static.
4230
c6f072e7
PE
4231 * window.c (window_body_lines): Now static.
4232
20ce5912
PE
4233 * image.c (gif_load): Rename local to avoid shadowing.
4234
9c4c5f81
PE
4235 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4236 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4237 * alloc.c (make_save_value): Integer argument is now of type
4238 ptrdiff_t, not int.
4239 (mark_object): Use ptrdiff_t, not int.
4240 * lisp.h (pD): New macro.
4241 * print.c (print_object): Use it.
4242
c0c5c8ae
PE
4243 * alloc.c: Use EMACS_INT, not int, to count objects.
4244 (total_conses, total_markers, total_symbols, total_vector_size)
4245 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4246 (total_free_floats, total_floats, total_free_intervals)
4247 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4248 Now EMACS_INT, not int. All uses changed.
4249 (Fgarbage_collect): Compute overall total using a double, so that
4250 integer overflow is less likely to be a problem. Check for overflow
4251 when converting back to an integer.
5a25e253
PE
4252 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4253 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4254 These were 'int' variables that could overflow on 64-bit hosts;
4255 they were never used, so remove them instead of repairing them.
211a0b2a 4256 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4257 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4258 Previously, this ceilinged at INT_MAX, but that doesn't work on
4259 64-bit machines.
e46bb31a 4260 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4261
c78baabf 4262 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4263 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4264 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4265 when a (possibly-narrower) signed value would do just as well.
4266 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4267
c9d624c6
PE
4268 * alloc.c: Catch some string size overflows that we were missing.
4269 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4270 for convenience in STRING_BYTES_MAX.
4271 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4272 The definition here is exact; the one in lisp.h was approximate.
4273 (allocate_string_data): Check for string overflow. This catches
4274 some instances we weren't catching before. Also, it catches
4275 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4276 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4277 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4278
c9d624c6
PE
4279 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4280 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4281 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4282
353032ce
PE
4283 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4284
2bccce07
PE
4285 * alloc.c (Fmake_string): Check for out-of-range init.
4286
0ac30604
SM
42872011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4288
4289 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4290
c195f2de
JD
42912011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4292
4293 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4294 xg_get_default_scrollbar_width.
4295
4296 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4297 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4298 (style_changed_cb): Call update_theme_scrollbar_width and call
4299 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4300 all frames (Bug#8505).
4301 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4302 Call gtk_window_set_resizable if HAVE_GTK3.
4303 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4304 and height if HAVE_GTK3 (Bug#8505).
4305 (scroll_bar_width_for_theme): New variable.
4306 (update_theme_scrollbar_width): New function.
4307 (xg_get_default_scrollbar_width): Move code to
4308 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4309 (xg_initialize): Call update_theme_scrollbar_width.
4310
4311 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4312
4313 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4314
e10ac9f1
MR
43152011-06-12 Martin Rudalics <rudalics@gmx.at>
4316
4317 * frame.c (make_frame): Call other_buffer_safely instead of
4318 other_buffer.
4319
4320 * window.c (temp_output_buffer_show): Call display_buffer with
4321 second argument Vtemp_buffer_show_specifiers and reset latter
4322 immediately after the call.
4323 (Vtemp_buffer_show_specifiers): New variable.
4324 (auto_window_vscroll_p, next_screen_context_lines)
4325 (Vscroll_preserve_screen_position): Remove leading asterisks from
4326 doc-strings.
4327
2d3c217e 43282011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4329
7b7f97e8 4330 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4331 * buffer.c (Qclone_number): Remove for now, as it's unused.
4332 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4333 (record_buffer): Remove unused local.
4334 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4335 (set_frame_buffer_list): Remove; unused.
4336 * frame.h (other_visible_frames): Remove decl.
4337 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4338 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4339 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4340 if HAVE_GPM.
4341 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4342 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4343 Define only if HAVE_GPM.
4344 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4345 (update_hints_inhibit): Remove; never set. All uses removed.
4346 * widgetprv.h (emacsFrameClassRec): Remove decl.
4347 * window.c (delete_deletable_window): Now returns void, since it
4348 wasn't returning anything.
4349 (compare_window_configurations): Remove unused locals.
4350 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4351 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4352 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4353 the same widths as pointers. This follows up on the 2011-05-06 patch.
4354 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4355 * xterm.h: Likewise.
4356 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4357
1384b89e
JB
43582011-06-12 Juanma Barranquero <lekktu@gmail.com>
4359
4360 * makefile.w32-in: Update dependencies.
4361 (LISP_H): Add lib/intprops.h.
4362
1100a63c
CY
43632011-06-11 Chong Yidong <cyd@stupidchicken.com>
4364
4365 * image.c (gif_load): Add animation frame delay to the metadata.
4366 (syms_of_image): Use DEFSYM. New symbol `delay'.
4367
6198ccd0
MR
43682011-06-11 Martin Rudalics <rudalics@gmx.at>
4369
4370 * window.c (delete_deletable_window): Re-add.
4371 (Fset_window_configuration): Rewrite to handle dead buffers and
4372 consequently deletable windows.
4373 (window_tree, Fwindow_tree): Remove. Supply functionality in
4374 window.el.
4375 (compare_window_configurations): Simplify code.
4376
b6e3633c
AS
43772011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4378
1ab0dee5
AS
4379 * image.c (imagemagick_load_image): Fix type mismatch.
4380 (Fimagemagick_types): Likewise.
4381
b6e3633c
AS
4382 * window.h (replace_buffer_in_windows): Declare.
4383
9397e56f
MR
43842011-06-11 Martin Rudalics <rudalics@gmx.at>
4385
4386 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4387 Qclone_number. Remove external declaration of Qdelete_window.
4388 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4389 code.
640c8776
SM
4390 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4391 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4392 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4393 buffer list implementation.
4394 (other_buffer_safely): New function.
4395 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4396 calls to replace_buffer_in_windows and
4397 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4398 if allowed.
4399 (record_buffer): Inhibit quitting and rewrite using quittable
4400 functions. Run Qbuffer_list_update_hook if allowed.
4401 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4402 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4403 Move switch-to-buffer to window.el.
9397e56f
MR
4404 (bury-buffer): Move to window.el.
4405 (Vbuffer_list_update_hook): New variable.
4406
4407 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4408 section.
4409
4410 * window.h (resize_frame_windows): Move up in code.
4411 (Fwindow_frame): Remove EXFUN.
4412 (replace_buffer_in_all_windows): Remove prototype.
4413 (replace_buffer_in_windows_safely): Add prototype.
4414
4415 * window.c: Declare Qdelete_window static again. Move down
4416 declaration of select_count.
4417 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4418 (Fother_window): Move to window.el.
4419 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4420 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4421 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4422 window.el.
4423 (replace_buffer_in_windows): Implement by calling
4424 Qreplace_buffer_in_windows.
4425 (replace_buffer_in_all_windows): Remove with some functionality
4426 moved into replace_buffer_in_windows_safely.
4427 (replace_buffer_in_windows_safely): New function.
4428 (select_window_norecord, select_frame_norecord): Move in front
4429 of run_window_configuration_change_hook. Remove now obsolete
4430 declarations.
640c8776
SM
4431 (Fset_window_buffer): Rewrite doc-string.
4432 Call Qrecord_window_buffer.
9397e56f
MR
4433 (keys_of_window): Move binding for other-window to window.el.
4434
b50691aa
CY
44352011-06-11 Chong Yidong <cyd@stupidchicken.com>
4436
4437 * dispextern.h (struct image): Replace data member, whose int_val
4438 and ptr_val fields were not used by anything, with a single
4439 lisp_val object.
4440
4441 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4442 (gif_clear_image, gif_load, imagemagick_load_image)
4443 (gs_clear_image, gs_load): Callers changed.
4444
3f754b86
PE
44452011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4446
cca69397
PE
4447 * buffer.h: Include <time.h>, for time_t.
4448 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4449
109e28d0
PE
4450 Fix minor problems found by static checking.
4451
60737f02
PE
4452 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4453
4b66faf3
PE
4454 Make identifiers static if they are not used in other modules.
4455 * data.c (Qcompiled_function, Qframe, Qvector):
4456 * image.c (QimageMagick, Qsvg):
4457 * minibuf.c (Qmetadata):
4458 * window.c (resize_window_check, resize_root_window): Now static.
4459 * window.h (resize_window_check, resize_root_window): Remove decls.
4460
109e28d0
PE
4461 * window.c (window_deletion_count, delete_deletable_window):
4462 Remove; unused.
46a4ce9e
PE
4463 (window_body_lines): Now static.
4464 (Fdelete_other_windows_internal): Mark vars as initialized.
4465 Make sure 'resize_failed' is initialized.
4466 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4467 (resize_window_apply): Remove unused local.
4468 * window.h (delete_deletable_window): Remove decl.
4469
109e28d0 4470 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4471 (imagemagick_load_image): Fix pointer signedness problem by changing
4472 last arg from unsigned char * to char *. All uses changed.
4473 Also, fix a local for similar reasons.
4474 Remove unused locals. Remove locals to avoid shadowing.
4475 (fn_rsvg_handle_free): Remove; unused.
4476 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4477 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4478
3f754b86
PE
4479 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4480
2547adb1
CY
44812011-06-10 Chong Yidong <cyd@stupidchicken.com>
4482
4483 * image.c (gif_load): Fix omitted cast error introduced by
4484 2011-06-06 change.
4485
2c8e37d4
MR
44862011-06-10 Martin Rudalics <rudalics@gmx.at>
4487
4488 * window.h (resize_proportionally, orig_total_lines)
4489 (orig_top_line): Remove from window structure.
4490 (set_window_height, set_window_width, change_window_heights)
4491 (Fdelete_window): Remove prototypes.
4492 (resize_frame_windows): Remove duplicate declaration.
4493
440a42e3
EZ
44942011-06-10 Eli Zaretskii <eliz@gnu.org>
4495
4496 * window.h (resize_frame_windows, resize_window_check)
4497 (delete_deletable_window, resize_root_window)
4498 (resize_frame_windows): Declare prototypes.
4499
4500 * window.c (resize_window_apply): Make definition be "static" to
4501 match the prototype.
4502
562dd5e9
MR
45032011-06-10 Martin Rudalics <rudalics@gmx.at>
4504
4505 * window.c: Remove declarations of Qwindow_size_fixed,
4506 window_min_size_1, window_min_size_2, window_min_size,
4507 size_window, window_fixed_size_p, enlarge_window, delete_window.
4508 Remove static from declaration of Qdelete_window, it's
4509 temporarily needed by Fbury_buffer.
4510 (replace_window): Don't assign orig_top_line and
4511 orig_total_lines.
4512 (Fdelete_window, delete_window): Remove. Window deletion is
4513 handled by window.el.
640c8776
SM
4514 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4515 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4516 (Fdelete_other_windows): Remove. Deleting other windows is
4517 handled by window.el.
4518 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4519 handled in window.el.
4520 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4521 Window minimum sizes are handled in window.el.
4522 (shrink_windows, size_window, set_window_height)
4523 (set_window_width, change_window_heights, window_height)
4524 (window_width, CURBEG, CURSIZE, enlarge_window)
4525 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4526 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4527 handled in window.el.
4528 (make_dummy_parent): Rename to make_parent_window and give it a
4529 second argument horflag.
4530 (make_window): Don't set resize_proportionally any more.
4531 (Fsplit_window): Remove. Windows are split in window.el.
4532 (save_restore_action, save_restore_orig_size)
4533 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4534 Resize mini windows in window.el.
4535 (grow_mini_window, shrink_mini_window): Implement by calling
4536 Qresize_root_window_vertically, resize_window_check and
4537 resize_window_apply.
640c8776
SM
4538 (saved_window, Fset_window_configuration, save_window_save):
4539 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4540 resize_proportionally.
4541 (window_min_height, window_min_width): Move to window.el.
4542 (keys_of_window): Move bindings for delete-other-windows,
4543 split-window, delete-window and enlarge-window to window.el.
4544
4545 * buffer.c: Temporarily extern Qdelete_window.
4546 (Fbury_buffer): Temporarily call Qdelete_window instead of
4547 Fdelete_window (Fbury_buffer will move to window.el soon).
4548
4549 * frame.c (set_menu_bar_lines_1): Remove code handling
4550 orig_top_line and orig_total_lines.
4551
4552 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4553 set_window_height but set heights directly.
4554 (change_frame_size_1): Use resize_frame_windows.
4555
4556 * xdisp.c (init_xdisp): Don't use set_window_height but set
4557 heights directly.
4558
640c8776
SM
4559 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4560 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4561 run_window_configuration_change_hook.
4562
4563 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4564 instead of change_window_heights and run
4565 run_window_configuration_change_hook.
4566
1a13852e
MR
45672011-06-09 Martin Rudalics <rudalics@gmx.at>
4568
4569 * window.c (replace_window): Rename second argument REPLACEMENT to
4570 NEW. New third argument SETFLAG. Rewrite.
4571 (delete_window, make_dummy_parent): Call replace_window with
4572 third argument 1.
4573 (window_list_1): Move down in code.
4574 (run_window_configuration_change_hook): Move set_buffer part
4575 before select_frame_norecord part in order to unwind correctly.
4576 Rename count1 to count.
4577 (recombine_windows, delete_deletable_window, resize_root_window)
4578 (Fdelete_other_windows_internal)
4579 (Frun_window_configuration_change_hook, make_parent_window)
4580 (resize_window_check, resize_window_apply, Fresize_window_apply)
4581 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4582 (Fdelete_window_internal, Fresize_mini_window_internal):
4583 New functions.
1a13852e
MR
4584 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4585
f3d1777e
MR
45862011-06-08 Martin Rudalics <rudalics@gmx.at>
4587
496e208e
MR
4588 * window.h (window): Add some new members to window structure -
4589 normal_lines, normal_cols, new_total, new_normal, clone_number,
4590 splits, nest, prev_buffers, next_buffers.
4591 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4592 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4593
f3d1777e
MR
4594 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4595 Remove.
496e208e
MR
4596 (make_dummy_parent): Set new members of windows structure.
4597 (make_window): Move down in code. Handle new members of window
4598 structure.
4599 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4600 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4601 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4602 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4603 (Fset_window_next_buffers, Fset_window_clone_number):
4604 New functions.
496e208e
MR
4605 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4606 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4607 Doc-string fixes.
4608 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4609 Argument WINDOW can be now internal window too.
4610 (Fwindow_use_time): Move up in code.
4611 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4612 Rewrite doc-string.
4613 (Fset_window_configuration, saved_window)
4614 (Fcurrent_window_configuration, save_window_save): Handle new
4615 members of window structure.
b9e809c2
MR
4616 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4617 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4618 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4619 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4620 Qget_mru_window, Qresize_root_window,
4621 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4622 Qauto_buffer_name; staticpro them.
f3d1777e 4623
abde8f8c
MR
46242011-06-07 Martin Rudalics <rudalics@gmx.at>
4625
4626 * window.c (Fwindow_total_size, Fwindow_left_column)
4627 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4628 (Fwindow_list_1): New functions.
4629 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4630 (Fwindow_width, Fscroll_left, Fscroll_right):
4631 Use window_body_cols instead of window_box_text_cols.
4632 (delete_window, Fset_window_configuration):
4633 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4634 (delete_all_subwindows): Take a window as argument and not a
4635 structure. Rewrite.
190b47e6
MR
4636 (window_loop): Remove handling of GET_LRU_WINDOW and
4637 GET_LARGEST_WINDOW.
4638 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4639
4640 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4641 window_box_text_cols. delete_all_subwindows now takes a
4642 Lisp_Object as argument.
abde8f8c 4643
640c8776
SM
4644 * indent.c (compute_motion, Fcompute_motion):
4645 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4646
fa8a67e6
MR
4647 * frame.c (delete_frame): Call delete_all_subwindows with root
4648 window as argument.
4649
a54e3482
DC
46502011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4651
4652 * fns.c (Fputhash): Document return value.
4653
60002bf5
CY
46542011-06-06 Chong Yidong <cyd@stupidchicken.com>
4655
4656 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4657
0c671da6 46582011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4659
b862a52a 4660 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4661
be44ca6c
PE
4662 Check for overflow when converting integer to cons and back.
4663 * charset.c (Fdefine_charset_internal, Fdecode_char):
4664 Use cons_to_unsigned to catch overflow.
4665 (Fencode_char): Use INTEGER_TO_CONS.
4666 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4667 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4668 * data.c (long_to_cons, cons_to_long): Remove.
4669 (cons_to_unsigned, cons_to_signed): New functions.
4670 These signal an error for invalid or out-of-range values.
4671 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4672 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4673 * font.c (Ffont_variation_glyphs):
4674 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4675 * lisp.h: Include <intprops.h>.
4676 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4677 (cons_to_signed, cons_to_unsigned): New decls.
4678 (long_to_cons, cons_to_long): Remove decls.
4679 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4680 (Fprimitive_undo): Use CONS_TO_INTEGER.
4681 * xfns.c (Fx_window_property): Likewise.
4682 * xselect.c: Include <limits.h>.
4683 (x_own_selection, selection_data_to_lisp_data):
4684 Use INTEGER_TO_CONS.
4685 (x_handle_selection_request, x_handle_selection_clear)
4686 (x_get_foreign_selection, Fx_disown_selection_internal)
4687 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4688 (lisp_data_to_selection_data): Use cons_to_unsigned.
4689 (x_fill_property_data): Use cons_to_signed.
4690 Report values out of range.
4691
d1f3d2af
PE
4692 Check for buffer and string overflow more precisely.
4693 * buffer.h (BUF_BYTES_MAX): New macro.
4694 * lisp.h (STRING_BYTES_MAX): New macro.
4695 * alloc.c (Fmake_string):
4696 * character.c (string_escape_byte8):
4697 * coding.c (coding_alloc_by_realloc):
4698 * doprnt.c (doprnt):
4699 * editfns.c (Fformat):
4700 * eval.c (verror):
4701 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4702 since they may not be the same number.
4703 * editfns.c (Finsert_char):
4704 * fileio.c (Finsert_file_contents):
4705 Likewise for BUF_BYTES_MAX.
4706
dd52fcea
PE
4707 * image.c: Use ptrdiff_t, not int, for sizes.
4708 (slurp_file): Switch from int to ptrdiff_t.
4709 All uses changed.
4710 (slurp_file): Check that file size fits in both size_t (for
4711 malloc) and ptrdiff_t (for sanity and safety).
4712
7f9bbdbb
PE
4713 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4714 if b->modtime has its maximal value.
4715
dfe18f82
PE
4716 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4717
84acfcf0
PE
4718 Don't assume time_t can fit into int.
4719 * buffer.h (struct buffer.modtime): Now time_t, not int.
4720 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4721 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4722
ccd9a01a
PE
4723 Minor fixes for signed vs unsigned integers.
4724 * character.h (MAYBE_UNIFY_CHAR):
4725 * charset.c (maybe_unify_char):
4726 * keyboard.c (read_char, reorder_modifiers):
4727 XINT -> XFASTINT, since the integer must be nonnegative.
4728 * ftfont.c (ftfont_spec_pattern):
4729 * keymap.c (access_keymap, silly_event_symbol_error):
4730 XUINT -> XFASTINT, since the integer must be nonnegative.
4731 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4732 since it makes no difference and we prefer signed.
4733 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4734 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4735 nonnegative.
4736
d6d100dd
SM
47372011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4738
4739 * window.h (Fwindow_frame): Declare.
4740
2b6148e4
PE
47412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4742
4743 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4744 (SPARE_MEMORY): Always define.
4745 (LARGE_REQUEST): Remove.
4746 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4747
f230ecc9
MR
47482011-06-06 Martin Rudalics <rudalics@gmx.at>
4749
727e958e
MR
4750 * lisp.h: Move EXFUNS for Fframe_root_window,
4751 Fframe_first_window and Fset_frame_selected_window to window.h.
4752
4753 * window.h: Move EXFUNS for Fframe_root_window,
4754 Fframe_first_window and Fset_frame_selected_window here from
4755 lisp.h.
4756
4757 * frame.c (Fwindow_frame, Fframe_first_window)
4758 (Fframe_root_window, Fframe_selected_window)
4759 (Fset_frame_selected_window): Move to window.c.
4760 (Factive_minibuffer_window): Move to minibuf.c.
4761 (Fother_visible_frames_p): New function.
4762
4763 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4764
f230ecc9
MR
4765 * window.c (decode_window, decode_any_window): Move up in code.
4766 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4767 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4768 (Fwindow_buffer): Move up and rewrite doc-string.
4769 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4770 (Fwindow_prev): New functions.
727e958e
MR
4771 (Fwindow_frame): Move here from frame.c. Accept any window as
4772 argument.
4773 (Fframe_root_window, Fframe_first_window)
4774 (Fframe_selected_window): Move here from frame.c. Accept frame
4775 or arbitrary window as argument. Update doc-strings.
4776 (Fminibuffer_window): Move up in code.
4777 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4778 (Fset_frame_selected_window): Move here from frame.c.
4779 Marginal rewrite.
727e958e
MR
4780 (Fselected_window, select_window, Fselect_window): Move up in
4781 code. Minor doc-string fixes.
f230ecc9 4782
4d09bcf6
PE
47832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4784
4785 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4786 Do not assume that spare memory exists; that assumption is valid
4787 only if SYSTEM_MALLOC.
4788 (LARGE_REQUEST): New macro, so that the issue of large requests
4789 is separated from the issue of spare memory.
4790
810928a2
AS
47912011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4792
172418ad
AS
4793 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4794 format. (Bug#8806)
4795
43f862f7
AS
4796 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4797
810928a2
AS
4798 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4799 before statements.
4800
a059fe24
JD
48012011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4802
4803 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4804
4805 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4806
4807 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4808 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4809
989bf368
JB
48102011-06-05 Juanma Barranquero <lekktu@gmail.com>
4811
4812 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4813
4b80f674
CY
48142011-06-04 Chong Yidong <cyd@stupidchicken.com>
4815
4816 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4817 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4818 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4819 New error handlers.
4b80f674
CY
4820 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4821 Obey Vx_select_enable_clipboard_manager. Catch errors in
4822 x_clipboard_manager_save (Bug#8779).
4823 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4824 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4825
99a33b77 48262011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4827
4828 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4829
99a33b77 48302011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4831
4832 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4833 in the current matrix if keep_current_p is non-zero.
4834
8264569d
EZ
48352011-06-04 Eli Zaretskii <eliz@gnu.org>
4836
4837 * bidi.c (bidi_level_of_next_char): Fix last change.
4838
57f97249
EZ
48392011-06-03 Eli Zaretskii <eliz@gnu.org>
4840
fec2107c 4841 Support bidi reordering of text covered by display properties.
57f97249 4842
fec2107c
EZ
4843 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4844 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4845 (bidi_cache_search, bidi_cache_iterator_state)
4846 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4847 (bidi_level_of_next_char, bidi_move_to_visually_next):
4848 Support character positions inside a run of characters covered by a
fec2107c
EZ
4849 display string.
4850 (bidi_paragraph_init, bidi_resolve_explicit_1)
4851 (bidi_level_of_next_char): Call bidi_fetch_char and
4852 bidi_fetch_char_advance instead of FETCH_CHAR and
4853 FETCH_CHAR_ADVANCE.
4854 (bidi_init_it): Initialize new members.
4855 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4856 definitions.
4857 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4858 instead of using explicit *_CHAR codes.
d6d100dd
SM
4859 (bidi_resolve_explicit, bidi_resolve_weak):
4860 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4861 bidirectional text is supported only in multibyte buffers.
4862 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4863 it to initialize the frame_window_p member of struct bidi_it.
4864 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4865 (bidi_resolve_explicit, bidi_resolve_weak)
4866 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4867 bidi_it->nchars is non-positive.
4868 (bidi_level_of_next_char): Don't try to lookup the cache for the
4869 next/previous character if nothing is cached there yet, or if we
4870 were just reseat()'ed to a new position.
c40e2fb2 4871
0e14fe90
EZ
4872 * xdisp.c (set_cursor_from_row): Set start and stop points
4873 according to the row's direction when priming the loop that looks
4874 for the glyph on which to display cursor.
4875 (single_display_spec_intangible_p): Function deleted.
4876 (display_prop_intangible_p): Reimplement to call
4877 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4878 Accept 3 additional arguments needed by handle_display_spec.
4879 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4880 values: lists, `(when COND...)' forms, etc.
4881 (single_display_spec_string_p): Support property values that are
4882 lists with the argument STRING its top-level element.
4883 (display_prop_string_p): Fix the condition for processing a
4884 property that is a list to be consistent with handle_display_spec.
fec2107c 4885 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4886 last portion of handle_display_prop.
4887 (compute_display_string_pos): Accept additional argument
4888 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4889 value of a `display' property is a "replacing spec".
4890 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4891 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4892 the display property, but just return a value indicating whether
4893 the display property will replace the characters it covers.
4894 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4895 frame_window_p members of struct bidi_it.
d6d100dd
SM
4896 (compute_display_string_pos, compute_display_string_end):
4897 New functions.
fec2107c
EZ
4898 (push_it): Accept second argument POSITION, where pop_it should
4899 jump to continue iteration.
4900 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4901
fec2107c
EZ
4902 * keyboard.c (adjust_point_for_property): Adjust the call to
4903 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4904
4905 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4906 (bidi_init_it): Update prototypes.
4907 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4908 (compute_display_string_pos, compute_display_string_end):
4909 Declare prototypes.
fec2107c
EZ
4910 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4911 EMACS_INT.
fc6f18ce 4912
40087514 49132011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4914
57f53182
PE
4915 Malloc failure behavior now depends on size of allocation.
4916 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4917 * lisp.h: Change signatures accordingly.
4918 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4919 All callers changed. (Bug#8762)
4920
4921 * gnutls.c: Use Emacs's memory allocators.
4922 Without this change, the gnutls library would invoke malloc etc.
4923 directly, which causes problems on non-SYNC_INPUT hosts, and which
4924 runs afoul of improving memory_full behavior. (Bug#8761)
4925 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4926 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4927 xfree instead of the default malloc, realloc, free.
4928 (Fgnutls_boot): No need to check for memory allocation failure,
4929 since xmalloc does that for us.
4930
ac32cd99 4931 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4932 * category.c (hash_get_category_set):
4933 * ccl.c (ccl_driver):
4934 * charset.c (Fdefine_charset_internal):
4935 * charset.h (struct charset.hash_index):
4936 * composite.c (get_composition_id, gstring_lookup_cache)
4937 (composition_gstring_put_cache):
4938 * composite.h (struct composition.hash_index):
4939 * dispextern.h (struct image.hash):
4940 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4941 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4942 (hashfn_equal, hashfn_user_defined, make_hash_table)
4943 (maybe_resize_hash_table, hash_lookup, hash_put)
4944 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4945 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4946 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4947 * image.c (make_image, search_image_cache, lookup_image)
4948 (xpm_put_color_table_h):
4949 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4950 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4951 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4952 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4953 * alloc.c (allocate_vectorlike):
4954 Check for overflow in vector size calculations.
4955 * ccl.c (ccl_driver):
4956 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4957 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4958 need to be updated by these changes.
40087514
PE
4959 * fns.c (make_hash_table, maybe_resize_hash_table):
4960 Check for integer overflow with large hash tables.
0de4bb68
PE
4961 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4962 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4963 (SXHASH_REDUCE): New macro.
4964 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4965 Use it instead of discarding useful hash info with large hash values.
4966 (sxhash_float): New function.
4967 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4968 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4969 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4970 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4971 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4972 Adjust signatures to match updated version of code.
4973 (consing_since_gc): Now EMACS_INT, since a single hash table can
4974 use more than INT_MAX bytes.
4975
698d32e2
DN
49762011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4977
4978 Make it possible to build with GCC-4.6+ -O2 -flto.
4979
4980 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4981
fd6fa53f
SM
49822011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4983
4984 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4985 Call minibuffer-inactive-mode.
4986
864db017
JB
49872011-05-31 Juanma Barranquero <lekktu@gmail.com>
4988
4989 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4990 Update dependencies.
4991
2ad0baf4
DN
49922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4993
4994 * data.c (init_data): Remove code for UTS, this system is not
4995 supported anymore.
4996
4fcc2638
DN
49972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4998
4999 Don't force ./temacs to start in terminal mode.
5000
5001 * frame.c (make_initial_frame): Initialize faces in all cases, not
5002 only when CANNOT_DUMP is defined.
5003 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5004
c56e0fd5
DN
50052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5006
5007 * dispnew.c (add_window_display_history): Use const for the string
5008 pointer. Remove declaration, not needed.
5009
333d54da 50102011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5011
55d4c1b2 5012 Use 'inline', not 'INLINE'.
333d54da 5013 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5014 * alloc.c, fontset.c (INLINE): Remove.
5015 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5016 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5017 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5018 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5019 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5020
738db178
DN
50212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5022
5023 Make it possible to run ./temacs.
5024
5025 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5026 syms_of_callproc does the same thing. Remove test for
5027 "initialized", do it in the caller.
5028 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5029
620c53a6
SM
50302011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5031
5032 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5033 (read_minibuf): Use get_minibuffer.
5034 (syms_of_minibuf): Use DEFSYM.
5035 (Qmetadata): New var.
5036 * data.c (Qbuffer): Don't make it static.
5037 (syms_of_data): Use DEFSYM.
5038
e003a292
PE
50392011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5040
5041 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5042 (CCL_CODE_MIN): New macro.
5043
ed008a6d
PE
50442011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5045
3687c2ef
PE
5046 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5047
ed008a6d
PE
5048 * eval.c (Qdebug): Now static.
5049 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5050 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5051 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5052
d66c4c7c
CY
50532011-05-29 Chong Yidong <cyd@stupidchicken.com>
5054
5055 * image.c: Various fixes to ImageMagick code comments.
5056 (Fimagemagick_types): Doc fix.
5057
5fbc2025
PE
50582011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5059
0196f88a
PE
5060 Minor fixes prompted by GCC 4.6.0 warnings.
5061
5062 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5063
5fbc2025
PE
5064 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5065 (x_clipboard_manager_save_all): Move extern decl to ...
5066 * xterm.h: ... here, so that it can be checked for consistency.
5067
1dd3c2d9
CY
50682011-05-29 Chong Yidong <cyd@stupidchicken.com>
5069
5070 * xselect.c (x_clipboard_manager_save_frame)
5071 (x_clipboard_manager_save_all): New functions.
5072 (Fx_clipboard_manager_save): Lisp function deleted.
5073
5074 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5075 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5076
5077 * xterm.h: Update prototype.
5078
5ba6571d
WX
50792011-05-28 William Xu <william.xwl@gmail.com>
5080
5081 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5082 exiting (Bug#8239).
5083
3eaff834
JM
50842011-05-28 Jim Meyering <meyering@redhat.com>
5085
e1900994 5086 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5087 * fns.c (to_uchar): Define.
5088 (crypto_hash_function): Use it to convert some newly-signed
5089 variables to unsigned, to avoid sign-extension bugs. For example,
5090 without this change, (md5 "truc") would evaluate to
5091 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5092 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5093 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5094
0f6990a7
PE
50952011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5096
5097 Integer overflow fixes.
c8a9ca5a 5098
08686060
PE
5099 * dbusbind.c: Serial number integer overflow fixes.
5100 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5101 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5102 to hold a serial number that is too large for a fixnum.
5103 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5104 Check for serial numbers out of range. Decode any serial number
59568bf0 5105 that was so large that it became a float. (Bug#8722)
08686060 5106
2d1fc3c7
PE
5107 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5108 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5109 Use XFASTINT rather than XUINT when numbers are nonnegative.
5110 (xd_append_arg, Fdbus_method_return_internal):
5111 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5112 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5113 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5114 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5115 (Bug#8722)
2d1fc3c7 5116
c8a9ca5a
PE
5117 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5118
519e1d69
PE
5119 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5120
30569699
PE
5121 ccl: add integer overflow checks
5122 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5123 (IN_INT_RANGE): New macros.
5124 (ccl_driver): Use them to check for integer overflow when
5125 decoding a CCL program. Many of the new checks are whether XINT (x)
5126 fits in int; it doesn't always, on 64-bit hosts. The new version
5127 doesn't catch all possible integer overflows, but it's an
847044ea 5128 improvement. (Bug#8719)
30569699 5129
c11285dc
PE
5130 * alloc.c (make_event_array): Use XINT, not XUINT.
5131 There's no need for unsigned here.
5132
fdccd48e
PE
5133 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5134 This follows up to the 2011-05-06 change that substituted uintptr_t
5135 for EMACS_INT. This case wasn't caught back then.
5136
37910ab2
PE
5137 Rework Fformat to avoid integer overflow issues.
5138 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5139 now (part of C89). Include <verify.h>.
5140 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5141 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5142 (Fformat): Avoid the prepass trying to compute sizes; it was only
5143 approximate and thus did not catch overflow reliably. Instead, walk
5144 through the format just once, formatting and computing sizes as we go,
5145 checking for integer overflow at every step, and allocating a larger
5146 buffer as needed. Keep track separately whether the format is
5147 multibyte. Keep only the most-recently calculated precision, rather
5148 than them all. Record whether each argument has been converted to
5149 string. Use EMACS_INT, not int, for byte and char and arg counts.
5150 Support field widths and precisions larger than INT_MAX. Avoid
5151 sprintf's undefined behavior with conversion specifications such as %#d
5152 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5153 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5154 formatting out-of-range floating point numbers with int
9173deec 5155 formats. (Bug#8668)
37910ab2 5156
2e6578fb
PE
5157 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5158
0ae6bdee
PE
5159 * data.c: Avoid integer truncation in expressions involving floats.
5160 * data.c: Include <intprops.h>.
5161 (arith_driver): When there's an integer overflow in an expression
5162 involving floating point, convert the integers to floating point
5163 so that the resulting value does not suffer from catastrophic
5164 integer truncation. For example, on a 64-bit host (* 4
5165 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5166 Do not rely on undefined behavior after integer overflow.
5167
de883a70
PE
5168 merge count_size_as_multibyte, parse_str_to_multibyte
5169 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5170 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5171 Check for integer overflow.
5172 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5173 since it's now a duplicate of the other. This is more of
5174 a character than a buffer op, so better that it's in character.c.
5175 * fns.c, print.c: Adjust to above changes.
5176
2ff916cb
PE
51772011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5178
5179 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5180
f1b54466
PE
51812011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5182
fb1ac845
PE
5183 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5184 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5185 (x_clipboard_manager_save): Now static.
5186 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5187
f1b54466
PE
5188 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5189 (crypto_hash_function): Now static.
5190 Fix pointer signedness problems. Avoid unnecessary initializations.
5191
a9f737ee
CY
51922011-05-27 Chong Yidong <cyd@stupidchicken.com>
5193
5194 * termhooks.h (Vselection_alist): Make it terminal-local.
5195
5196 * terminal.c (create_terminal): Initialize it.
5197
5198 * xselect.c: Support for clipboard managers.
5199 (Vselection_alist): Move to termhooks.h as terminal-local var.
5200 (LOCAL_SELECTION): New macro.
5201 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5202 (symbol_to_x_atom): Remove gratuitous arg.
5203 (x_handle_selection_request, lisp_data_to_selection_data)
5204 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5205 (x_own_selection, x_get_local_selection, x_convert_selection):
5206 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5207 (some_frame_on_display): Delete unused function.
5208 (Fx_own_selection_internal, Fx_get_selection_internal)
5209 (Fx_disown_selection_internal, Fx_selection_owner_p)
5210 (Fx_selection_exists_p): New optional frame arg.
5211 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5212 (x_handle_selection_clear): Don't treat other terminals with the
5213 same keyboard specially. Use the terminal-local Vselection_alist.
5214 (x_clear_frame_selections): Use Frun_hook_with_args.
5215
5216 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5217
5218 * xterm.h: Add support for those atoms.
5219
e067f0c1
CY
52202011-05-26 Chong Yidong <cyd@stupidchicken.com>
5221
5222 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5223 (converted_selections, conversion_fail_tag): New global variables.
5224 (x_selection_request_lisp_error): Free the above.
5225 (x_get_local_selection): Remove unnecessary code.
5226 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5227 of converted selections stored in converted_selections.
5228 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5229 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5230 (x_convert_selection): New function.
5231 (x_handle_selection_event): Simplify.
5232 (x_get_foreign_selection): Don't ignore incoming requests while
5233 waiting for an answer; this will fail when we implement
5234 SAVE_TARGETS, and seems unnecessary anyway.
5235 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5236 (Vx_sent_selection_functions): Doc fix.
5237
0f4aebc0
LL
52382011-05-26 Leo Liu <sdl.web@gmail.com>
5239
5240 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5241
e61124cd
YM
52422011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5243
5244 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5245
5246 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5247 for fringe update if it has periodic bitmap.
ac389d0c 5248 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5249 and fringe_bitmap_periodic_p.
5250
5251 * fringe.c (get_fringe_bitmap_data): New function.
5252 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5253 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5254 row. Mark glyph row for fringe update if periodicity changed.
5255
5256 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5257 for fringe update unless it has periodic bitmap.
5258
f16d9837
KH
52592011-05-25 Kenichi Handa <handa@m17n.org>
5260
5261 * xdisp.c (get_next_display_element): Set correct it->face_id for
5262 a static composition.
5263
e1b90ef6
LL
52642011-05-24 Leo Liu <sdl.web@gmail.com>
5265
5266 * deps.mk (fns.o):
5267 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5268
5269 * fns.c (crypto_hash_function, Fsha1): New function.
5270 (Fmd5): Use crypto_hash_function.
5271 (syms_of_fns): Add Ssha1.
5272
7400048f
PE
52732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5274
5275 * gnutls.c: Remove unused macros.
5276 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5277 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5278 Remove macros that are defined and never used.
5279 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5280
abb71cf4
CY
52812011-05-22 Chong Yidong <cyd@stupidchicken.com>
5282
5283 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5284 (Fx_get_selection_internal): Minor cleanup.
5285 (Fx_own_selection_internal): Rename arguments for consistency with
5286 select.el.
5287
6307db39
PE
52882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5289
5290 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5291
f3d4e0a4
CY
52922011-05-22 Chong Yidong <cyd@stupidchicken.com>
5293
5294 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5295
4d8ade89
YM
52962011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5297
5298 * dispnew.c (scrolling_window): Don't exclude the case that the
5299 last enabled row in the desired matrix touches the bottom boundary.
5300
32078c8d
GM
53012011-05-21 Glenn Morris <rgm@gnu.org>
5302
5303 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5304 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5305 and add some more files.
32078c8d 5306
7285dc67
EZ
53072011-05-20 Eli Zaretskii <eliz@gnu.org>
5308
5309 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5310 report_file_error introduced by the change from 2011-05-07.
5311
89d1bd22
PE
53122011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5313
5314 * systime.h (Time): Define only if emacs is defined.
5315 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5316 where the include path doesn't have X11/X.h by default. See
5317 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5318
e23640bb 53192011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5320
5321 * composite.c (find_automatic_composition): Fix previous change.
5322
b9704ad9
GM
53232011-05-20 Glenn Morris <rgm@gnu.org>
5324
5325 * lisp.mk: New file, split from Makefile.in.
5326 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5327 (shortlisp): Remove.
5328 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5329
4a720484
GM
53302011-05-19 Glenn Morris <rgm@gnu.org>
5331
5332 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5333 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5334 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5335 (lisp): Set the order to that of loadup.el.
5336 (shortlisp): Make it a copy of $lisp.
5337 (SOME_MACHINE_LISP): Remove.
5338 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5339 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5340
a28d4396
KH
53412011-05-18 Kenichi Handa <handa@m17n.org>
5342
5343 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5344 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5345 (find_automatic_composition): Mostly rewrite for efficiency.
5346
a2b1fa8e
JB
53472011-05-18 Juanma Barranquero <lekktu@gmail.com>
5348
5349 * makefile.w32-in: Update dependencies.
5350
8e1f5610
CS
53512011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5352
5353 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5354 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5355
7025ee00 53562011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5357
cdfa6eab
PE
5358 Fix some integer overflow issues, such as string length overflow.
5359
06d6db33
PE
5360 * insdel.c (count_size_as_multibyte): Check for string overflow.
5361
2b4560a8
PE
5362 * character.c (lisp_string_width): Check for string overflow.
5363 Use EMACS_INT, not int, for string indexes and lengths; in
5364 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5365 the resulting string length overflows an EMACS_INT; instead,
5366 report a string overflow if no precision given. When checking for
5367 precision exhaustion, use a check that cannot possibly have
5368 integer overflow. (Bug#8675)
5369 * character.h (lisp_string_width): Adjust to new signature.
5370
cb93f9be
PE
5371 * alloc.c (string_overflow): New function.
5372 (Fmake_string): Use it. This doesn't change behavior, but saves
5373 a few bytes and will simplify future changes.
5374 * character.c (string_escape_byte8): Likewise.
5375 * lisp.h (string_overflow): New decl.
5376
1a1f3366
PE
5377 Fixups, following up to the user-interface timestamp change.
5378 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5379 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5380 * msdos.c (mouse_get_pos): Likewise.
5381 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5382 * w32gui.h (Time): Define by including "systime.h" rather than by
5383 declaring it ourselves. (Bug#8664)
5384
d4e3e4d3
PE
5385 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5386 * image.c (clear_image_cache): Likewise.
5387
f6a24d19
PE
5388 * term.c (term_mouse_position): Don't assume time_t wraparound.
5389
08dc5ae6
PE
5390 Be more systematic about user-interface timestamps.
5391 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5392 and sometimes 'EMACS_UINT', to represent these timestamps.
5393 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5394 This makes the code easier to follow, and makes it easier to catch
5395 integer overflow bugs such as Bug#8664.
5396 * frame.c (Fmouse_position, Fmouse_pixel_position):
5397 Use Time, not unsigned long, for user-interface timestamps.
5398 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5399 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5400 * keyboard.h (last_event_timestamp): Likewise.
5401 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5402 * menu.h (xmenu_show): Likewise.
5403 * term.c (term_mouse_position): Likewise.
5404 * termhooks.h (struct input_event.timestamp): Likewise.
5405 (struct terminal.mouse_position_hook): Likewise.
5406 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5407 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5408 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5409 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5410 what it was before.
5411 * menu.h, termhooks.h: Include "systime.h", for Time.
5412
8e55734a
PE
5413 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5414 Don't assume that the difference between two unsigned long values
5415 can fit into an integer. At this point, we know button_down_time
5416 <= event->timestamp, so the difference must be nonnegative, so
5417 there's no need to cast the result if double-click-time is
5418 nonnegative, as it should be; check that it's nonnegative, just in
5419 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5420 apart (about 25 days). (Bug#8664)
8e55734a 5421
841f1b75 5422 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5423 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5424
3e26f69c
PE
5425 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5426 that always fit in int. Use a sentinel instead of a counter, to
5427 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5428 * frame.h (struct frame): Use int for menu_bar_items_used
5429 instead of EMACS_INT, since it always fits in int.
3e26f69c 5430
5cc152c0
PE
5431 * menu.c (grow_menu_items): Check for int overflow.
5432
d89eb65e
PE
5433 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5434
5235bd3e
PE
5435 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5436 Before, the code was not consistent. These values cannot exceed
5437 2**31 - 1 so there's no need to make them unsigned.
5438 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5439 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5440 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5441 as modifiers.
5442 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5443
bc827e23
PE
5444 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5445 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5446 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5447 presumably because the widths might not match.
5448
78eb494e
PE
5449 * window.c (size_window): Avoid needless test at loop start.
5450
04f2d78b
CB
54512011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5452
5453 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5454
d2fc7e3d 54552011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5456
5457 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5458
d2fc7e3d 54592011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5460
5461 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5462 `width' to `bar_area_x' and `bar_area_width', respectively.
5463 (x_scroll_run): Take account of fringe background extension.
5464
04f2d78b
CB
5465 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5466 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5467 `bar_area_width', respectively.
5468 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5469 background extension.
5470
79b70037
GM
54712011-05-10 Jim Meyering <meyering@redhat.com>
5472
5473 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5474
2f142cc5
JB
54752011-05-10 Juanma Barranquero <lekktu@gmail.com>
5476
5477 * image.c (Finit_image_library): Return t for built-in image types,
5478 like pbm and xbm. (Bug#8640)
5479
57679c86
AS
54802011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5481
5482 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5483
888c9e86
EZ
54842011-05-07 Eli Zaretskii <eliz@gnu.org>
5485
b0512a1d
EZ
5486 * w32console.c (Fset_screen_color): Doc fix.
5487 (Fget_screen_color): New function.
5488 (syms_of_ntterm): Defsubr it.
5489
7285dc67
EZ
5490 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5491 unlink the temporary file if Fcall_process didn't create it in the
5492 first place.
5493 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5494 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5495 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5496 cue to call_process_cleanup not to close that handle.
5497
4d3fcc8e
BK
54982011-05-07 Ben Key <bkey76@gmail.com>
5499
5500 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5501 one of two shell specific rules, either bootstrap-temacs-CMD or
5502 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5503 to the previous implementation of the bootstrap-temacs rule.
5504 The bootstrap-temacs-CMD rule is similar to the previous
5505 implementation of the bootstrap-temacs rule except that it
5506 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5507 variable.
5508
5509 These changes, along with some changes to nt/configure.bat,
5510 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5511 earlier fix to add support for --cflags and --ldflags options
5512 that include quotes so that it works whether make uses cmd or
5513 sh as the shell.
5514
b4289b64
MA
55152011-05-06 Michael Albinus <michael.albinus@gmx.de>
5516
5517 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5518 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5519 is a constant.
5520 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5521 a string. Handle both cases.
5522 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5523 (Fdbus_register_method): Use Qinvalid_function.
5524
af4c0e28
JB
55252011-05-06 Juanma Barranquero <lekktu@gmail.com>
5526
5527 * makefile.w32-in: Update dependencies.
5528 (LISP_H): Add inttypes.h and stdin.h.
5529 (PROCESS_H): Add unistd.h.
5530
c51453d9
EZ
55312011-05-06 Eli Zaretskii <eliz@gnu.org>
5532
5533 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5534 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5535
8ff0ac3c 55362011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5537
4c4b566b
PE
5538 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5539
aab2b9b5
PE
5540 * term.c (vfatal): Remove stray call to va_end.
5541 It's not needed and the C Standard doesn't allow it here anyway.
5542
c378da0b
PE
5543 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5544 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5545
288b08c7
PE
5546 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5547 bytes.
5548
e3601888
PE
5549 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5550
db6c0e74
PE
5551 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5552
dd5963ea
PE
5553 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5554
88c9450f
PE
5555 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5556
2f9442b8
PE
5557 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5558
c032b5f8
PE
5559 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5560 * charset.c (Fdefine_charset_internal): Don't initialize
5561 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5562 32-bit int (Bug#8600).
a108c10b
PE
5563
5564 * lread.c (read_integer): Be more consistent with string-to-number.
5565 Use string_to_number to do the actual conversion; this avoids
5566 rounding errors and fixes some other screwups. Without this fix,
5567 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5568 (digit_to_number): Move earlier, for benefit of read_integer.
5569 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5570 not a digit in any supported base. (Bug#8602)
a108c10b 5571
ad5f9eea
PE
5572 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5573
aec1708a
PE
5574 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5575 to match comment at start of function. This also removes a
5576 GCC warning about overflow in a 32+64-bit port.
5577
47be4ab5
PE
5578 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5579
371cac43
PE
5580 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5581 Reported by Stefan Monnier in
5582 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5583 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5584 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5585
d01a7826
PE
5586 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5587 (EMACS_UINTPTR): Likewise, with uintptr_t.
5588
7fd47d5c
PE
5589 * lisp.h: Prefer 64-bit EMACS_INT if available.
5590 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5591 on 32-bit hosts that have 64-bit int, so that they can access
5592 large files.
122b0c86
PE
5593 However, temporarily disable this change unless the temporary
5594 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5595
8727937b
PE
5596 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5597
8ac068ac
PE
5598 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5599 This removes an assumption that EMACS_INT and long are the same
5600 width as pointers. The assumption is true for Emacs porting targets
5601 now, but we want to make other targets possible.
5602 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5603 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5604 In the rest of the code, change types of integers that hold casted
5605 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5606 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5607 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5608 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5609 No need to cast type when ORing.
5610 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5611 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5612 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5613 assume EMACS_INT is the same width as char *.
5614 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5615 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5616 Remove no-longer-needed casts.
5617 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5618 (xg_tool_bar_help_callback, xg_make_tool_item):
5619 Use EMACS_INTPTR to hold an integer
5620 that will be cast to void *; this can avoid a GCC warning
5621 if EMACS_INT is not the same width as void *.
5622 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5623 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5624 (current_message_1, set_message_1):
5625 Use a local to convert to proper width without a cast.
5626 * xmenu.c (dialog_selection_callback): Likewise.
5627
ede49d71
PE
5628 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5629 Also, don't assume VALBITS / RAND_BITS is less than 5,
5630 and don't rely on undefined behavior when shifting a 1 left into
5631 the sign bit.
5632 * lisp.h (get_random): Change signature to match.
5633
2f30ecd0
PE
5634 * lread.c (hash_string): Use size_t, not int, for hash computation.
5635 Normally we prefer signed values; but hashing is special, because
5636 it's better to use unsigned division on hash table sizes so that
5637 the remainder is nonnegative. Also, size_t is the natural width
5638 for hashing into memory. The previous code used 'int', which doesn't
5639 retain enough info to hash well into very large tables.
5640 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5641
2a866e7b
PE
5642 * dbusbind.c: Don't possibly lose pointer info when converting.
5643 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5644 Use XPNTR rather than XHASH, so that the high-order bits of
5645 the pointer aren't lost when converting through void *.
5646
51639eac
PE
5647 * eval.c (Fautoload): Don't double-shift a pointer.
5648
92394119
PE
5649 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5650
dbdb9a7c
JB
56512011-05-06 Juanma Barranquero <lekktu@gmail.com>
5652
5653 * gnutls.c (DEF_GNUTLS_FN):
5654 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5655
db7a0b4f
AS
56562011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5657
5658 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5659 marker. (Bug#8610)
5660
f7ff1b0f 56612011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5662
5663 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5664 New version that can reserve upto 2GB of heap space.
5665
f7ff1b0f 56662011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5667
5668 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5669
639c109b
TZ
56702011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5671
5672 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5673 `gnutls_certificate_set_x509_key_file'.
5674
d2127135
JB
56752011-05-05 Juanma Barranquero <lekktu@gmail.com>
5676
5677 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5678 Update dependencies.
5679
e968f4f3
JB
56802011-05-04 Juanma Barranquero <lekktu@gmail.com>
5681
5682 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5683 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5684 Remove unused parameter `fildes'.
5685 * process.c (read_process_output, send_process): Don't pass it.
5686
84d358f0
JB
56872011-05-04 Juanma Barranquero <lekktu@gmail.com>
5688
5689 Fix previous change: the library cache is defined in w32.c.
5690 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5691 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5692
0898ca10
JB
56932011-05-04 Juanma Barranquero <lekktu@gmail.com>
5694
5695 Implement dynamic loading of GnuTLS on Windows.
5696
5697 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5698 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5699 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5700 Declare.
5701
5702 * gnutls.c (Qgnutls_dll): Define.
5703 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5704 (gnutls_*): Declare function pointers.
5705 (init_gnutls_functions): New function to initialize function pointers.
5706 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5707 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5708 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5709 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5710 (emacs_gnutls_write, emacs_gnutls_read)
5711 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5712 (Fgnutls_available_p): New function.
5713 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5714 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5715 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5716
5717 * image.c: Include w32.h.
5718 (Vimage_type_cache): Delete.
5719 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5720 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5721 (w32_delayed_load): Move to w32.c.
5722
5723 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5724
5725 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5726 (w32_delayed_load): Move from image.c. When loading a library, record
5727 its filename in the :loaded-from property of the library id.
5728 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5729 Initialize and staticpro them.
5730 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5731
5732 * process.c: Include lisp.h before w32.h, not after.
5733 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5734 instead of gnutls_record_check_pending.
5735
5736 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5737
ff4de4aa
TZ
57382011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5739
5740 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5741 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5742 as passed in.
5743
abe95abb
JD
57442011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5745
5746 * xterm.c (x_set_frame_alpha): Do not set property on anything
5747 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5748
e16e55d4
JB
57492011-05-02 Juanma Barranquero <lekktu@gmail.com>
5750
5751 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5752
bafcf6a5
JB
57532011-05-02 Juanma Barranquero <lekktu@gmail.com>
5754
5755 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5756 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5757 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5758 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5759 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5760 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5761 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5762 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5763 (Qgnutls_bootprop_callbacks_verify): Make static.
5764
e7a6747f
AS
57652011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5766
19ed11ba
AS
5767 * callproc.c: Indentation fixup.
5768
e7a6747f 5769 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5770 (wait_for_termination, interruptible_wait_for_termination):
5771 Move after wait_for_termination_1.
e7a6747f 5772
1ef14cb4
LMI
57732011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5774
5775 * sysdep.c (interruptible_wait_for_termination): New function
5776 which is like wait_for_termination, but allows keyboard
5777 interruptions.
5778
5779 * callproc.c (Fcall_process): Add (:file "file") as an option for
5780 the STDOUT buffer.
5781 (Fcall_process_region): Ditto.
5782
330d880c
EZ
57832011-04-30 Eli Zaretskii <eliz@gnu.org>
5784
8db90b73
EZ
5785 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5786 rather than `XVECTOR (FOO)->size'.
5787
330d880c
EZ
5788 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5789 inttypes.h, as a gnulib replacement is used if it not available in
5790 system headers.
5791
15cbd324
EZ
57922011-04-21 Eli Zaretskii <eliz@gnu.org>
5793
5794 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5795 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5796 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5797
5798 * coding.c (coding_alloc_by_realloc): Error out if destination
5799 will grow beyond MOST_POSITIVE_FIXNUM.
5800 (decode_coding_emacs_mule): Abort if there isn't enough place in
5801 charbuf for the composition carryover bytes. Reserve an extra
5802 space for up to 2 characters produced in a loop.
5803 (decode_coding_iso_2022): Abort if there isn't enough place in
5804 charbuf for the composition carryover bytes.
5805
58062011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5807
ae940cca
EZ
5808 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5809 aborting when %lld or %lll format is passed.
5810 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5811 %llo or %llx format is passed. (Bug#8545)
5812
03ab8921
EZ
5813 * window.c (window_scroll_line_based): Use a marker instead of
5814 simple variables to record original value of point. (Bug#7952)
5815
afda1437
EZ
5816 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5817 produced by %s or %c overflows available buffer space. (Bug#8545)
5818
f76dee0c
PE
58192011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5820
5821 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5822 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5823
fdc5744d
JB
58242011-04-28 Juanma Barranquero <lekktu@gmail.com>
5825
5826 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5827
638f053a
JB
58282011-04-28 Juanma Barranquero <lekktu@gmail.com>
5829
5830 * keyboard.c (Qdelayed_warnings_hook): Define.
5831 (command_loop_1): Run `delayed-warnings-hook'
5832 if Vdelayed_warnings_list is non-nil.
5833 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5834 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5835
d178f871
EZ
58362011-04-28 Eli Zaretskii <eliz@gnu.org>
5837
5838 * doprnt.c (doprnt): Don't return value smaller than the buffer
5839 size if the message was truncated. (Bug#8545).
5840
b124fd93
JB
58412011-04-28 Juanma Barranquero <lekktu@gmail.com>
5842
5843 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5844 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5845
e810457d
PE
58462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5847
5848 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5849
ea51cceb
JB
58502011-04-27 Juanma Barranquero <lekktu@gmail.com>
5851
5852 * makefile.w32-in: Update dependencies.
5853
94dcfacf
EZ
58542011-04-27 Eli Zaretskii <eliz@gnu.org>
5855
5856 Improve `doprnt' and its usage. (Bug#8545)
5857 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5858 `format_end'. Remove support for %l as a conversion specifier.
5859 Don't use xrealloc. Improve diagnostics when the %l size modifier
5860 is used. Update the commentary.
5861
5862 * eval.c (verror): Simplify calculation of size_t.
5863
5864 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5865 messages.
5866
f61f41d7
PE
58672011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5868
5869 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5870 change.
5871
96fb4434
PE
58722011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5873
5874 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5875 This makes this file independent of the recent pseudovector change.
5876
671875da 58772011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5878
69e9b5a3
PE
5879 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5880
b5f869a7 5881 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5882 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5883 Remove unused local.
c8926152 5884 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5885
841a1577 5886 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5887 GCC 4.6.0 optimizes based on type-based alias analysis.
5888 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5889 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5890 != &v->size, and therefore "v->size = 1; b->size = 2; return
5891 v->size;" must therefore return 1. This assumption is incorrect
5892 for Emacs, since it type-puns struct Lisp_Vector * with many other
5893 types. To fix this problem, this patch adds a new type struct
f904488f 5894 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5895 and pseudovectors, and helps optimizing compilers not get fooled
5896 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5897 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5898 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5899 the size member.
eab3844f
PE
5900 (XSETPVECTYPE): Rewrite in terms of new macro.
5901 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5902 This is a bit clearer, and further avoids the possibility of
5903 undesirable aliasing.
5904 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5905 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5906 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5907 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5908 (ASIZE): Now uses header.size rather than size.
5909 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5910 to avoid the hassle of writing XVECTOR (foo)->header.size.
5911 (struct vectorlike_header): New type.
eab3844f
PE
5912 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5913 object, to help avoid aliasing.
5914 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5915 (SUBRP): Likewise, since Lisp_Subr is a special case.
5916 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5917 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5918 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5919 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5920 changed to be "header.size" and "header.next".
5921 * buffer.h (struct buffer): Likewise.
5922 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5923 * frame.h (struct frame): Likewise.
5924 * process.h (struct Lisp_Process): Likewise.
5925 * termhooks.h (struct terminal): Likewise.
5926 * window.c (struct save_window_data, struct saved_window): Likewise.
5927 * window.h (struct window): Likewise.
5928 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5929 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5930 * buffer.c (init_buffer_once): Likewise.
5931 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5932 special case.
5933 * process.c (Fformat_network_address): Use local var for size,
5934 for brevity.
5935
0df1eac5
PE
5936 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5937
847ab9d1 5938 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5939 * data.c (atof): Remove decl; no longer used or needed.
5940 (digit_to_number): Move to lread.c.
5941 (Fstring_to_number): Use new string_to_number function, to be
5942 consistent with how the Lisp reader treats infinities and NaNs.
5943 Do not assume that floating-point numbers represent EMACS_INT
5944 without losing information; this is not true on most 64-bit hosts.
5945 Avoid double-rounding errors, by insisting on integers when
5946 parsing non-base-10 numbers, as the documentation specifies.
5947 * lisp.h (string_to_number): New decl, replacing ...
5948 (isfloat_string): Remove.
bc0a5c13 5949 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5950 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5951 appears to have been a coding error. Similarly, do not accept
5952 strings like +-1e0 as floating point numbers. Do not report
5953 overflow for integer overflows unless the base is not 10 which
5954 means we have no simple and reliable way to continue.
5955 Break out the floating-point parsing into a new
5956 function string_to_number, so that Fstring_to_number parses
5957 floating point numbers consistently with the Lisp reader.
04f2d78b 5958 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5959 (E_CHAR, EXP_INT): Remove, replacing with ...
5960 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5961 (string_to_number): New function, replacing isfloat_string.
5962 This function checks for valid syntax and produces the resulting
5963 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5964 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5965 so that overflow for non-base-10 numbers is reported only when
5966 there's no portable and simple way to convert to floating point.
452f4150 5967
67769ffc
PE
5968 * textprop.c (set_text_properties_1): Rewrite for clarity,
5969 and to avoid GCC warning about integer overflow.
5970
c20db43f
PE
5971 * intervals.h (struct interval): Use EMACS_INT for members
5972 where EMACS_UINT might cause problems. See
5973 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5974 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5975 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5976 All uses changed.
37aa2f85
PE
5977 (offset_intervals): Tell GCC not to worry about length overflow
5978 when negating a negative length.
c20db43f 5979
2538aa2f
PE
5980 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5981 (overrun_check_free): Likewise.
5982
f2d3008d
PE
5983 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5984 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5985 word size.
5986
ec8df744
PE
5987 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5988 (gnutls_make_error): Rename local to avoid shadowing.
5989 (gnutls_emacs_global_deinit): ifdef out; not used.
5990 (Fgnutls_boot): Use const for pointer to readonly storage.
5991 Comment out unused local. Fix pointer signedness problems.
5992
640ee02d
PE
5993 * lread.c (openp): Don't stuff size_t into an 'int'.
5994 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5995 about possible signed overflow.
5996
6048fb2a
PE
5997 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5998 (GDK_KEY_g): Don't define if already defined.
5999 (xg_prepare_tooltip): Avoid pointer signedness problem.
6000 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6001
fa3c87e1
PE
6002 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6003 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6004
2172544b
PE
6005 * xfns.c (Fx_window_property): Simplify a bit,
6006 to make a bit faster and to avoid GCC 4.6.0 warning.
6007 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6008
9b821a21
PE
6009 * fns.c (internal_equal): Don't assume size_t fits in int.
6010
3c616cfa
PE
6011 * alloc.c (compact_small_strings): Tighten assertion a little.
6012
c2982e87
PE
6013 Replace pEd with more-general pI, and fix some printf arg casts.
6014 * lisp.h (pI): New macro, generalizing old pEd macro to other
6015 conversion specifiers. For example, use "...%"pI"d..." rather
6016 than "...%"pEd"...".
6017 (pEd): Remove. All uses replaced with similar uses of pI.
6018 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6019 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6020 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6021 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6022 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6023 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6024 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6025 64-bit hosts.
6026 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6027 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6028 * print.c (safe_debug_print, print_object): Likewise.
6029 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6030 to int.
6f04d126
PE
6031 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6032 avoiding the 0 flag, which is not portable.
c2982e87
PE
6033 * process.c (Fmake_network_process): Use pI to avoid cast.
6034 * region-cache.c (pp_cache): Likewise.
6035 * xdisp.c (decode_mode_spec): Likewise.
6036 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6037 behavior on 64-bit hosts with printf arg.
6f04d126 6038 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6039 (x_stop_queuing_selection_requests): Likewise.
6040 (x_get_window_property): Don't truncate byte count to an 'int'
6041 when tracing.
0b432f21 6042
5e073ec7
PE
6043 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6044 here, since it parses constructs like leading '-' and spaces,
6045 which are not wanted; and it overflows with large numbers.
6046 Instead, simply match F[0-9]+, which is what is wanted anyway.
6047
36372bf9
PE
6048 * alloc.c: Remove unportable assumptions about struct layout.
6049 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6050 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6051 (allocate_vectorlike, make_pure_vector): Use the new macros,
6052 plus offsetof, to remove unportable assumptions about struct layout.
6053 These assumptions hold on all porting targets that I know of, but
6054 they are not guaranteed, they're easy to remove, and removing them
6055 makes further changes easier.
6056
0b432f21
PE
6057 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6058 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6059 (string_overrun_cookie): Now const. Use initializers that
6060 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6061 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6062 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6063 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6064 multiple of sizeof (EMACS_INT); it need not be, if
6065 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6066 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6067
895009e1
JB
60682011-04-26 Juanma Barranquero <lekktu@gmail.com>
6069
6070 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6071
6a7a1b0b
TZ
60722011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6073
6074 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6075 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6076 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6077
841a1577 60782011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6079
6080 * lisp.h (Qdebug): List symbol.
895009e1 6081 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6082 * keyboard.c (debug-on-event): New variable.
6083 (handle_user_signal): Break into debugger when debug-on-event
6084 matches the current signal symbol.
6085
f2d3ba6f
DN
60862011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6087
6088 * alloc.c (check_sblock, check_string_bytes)
6089 (check_string_free_list): Convert to standard C.
6090
42ce4c63
TZ
60912011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6092
6093 * w32.c (emacs_gnutls_push): Fix typo.
6094
825cd63c
EZ
60952011-04-25 Eli Zaretskii <eliz@gnu.org>
6096
fb11d64d
EZ
6097 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6098 "cast to pointer from integer of different size".
6099
825cd63c
EZ
6100 Improve doprnt and its use in verror. (Bug#8545)
6101 * doprnt.c (doprnt): Document the set of format control sequences
6102 supported by the function. Use SAFE_ALLOCA instead of always
6103 using `alloca'.
6104
6105 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6106 is one byte too soon. Don't use xrealloc; instead xfree and
6107 xmalloc anew.
6108
e061a11b
TZ
61092011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6110
6111 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6112 callbacks stage.
6113
6114 * gnutls.c: Renamed global_initialized to
6115 gnutls_global_initialized. Added internals for the
6116 :verify-hostname-error, :verify-error, and :verify-flags
6117 parameters of `gnutls-boot' and documented those parameters in the
6118 docstring. Start callback support.
9173deec
JB
6119 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6120 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6121 on error. Return error code.
e061a11b
TZ
6122 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6123 (emacs_gnutls_read): Likewise.
6124 (Fgnutls_boot): Return handshake error code.
6125 (emacs_gnutls_handle_error): New function.
6126 (wsaerror_to_errno): Likewise.
6127
6128 * w32.h (emacs_gnutls_pull): Add prototype.
6129 (emacs_gnutls_push): Likewise.
6130
6131 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6132 (emacs_gnutls_push): Likewise.
6133
61342011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6135
6136 * process.c (wait_reading_process_output): Check if GnuTLS
6137 buffered some data internally if no FDs are set for TLS
6138 connections.
6139
6140 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6141 (LIBS): Link to USER_LIBS.
6142 ($(BLD)/gnutls.$(0)): New target.
6143
fa6996bc
EZ
61442011-04-24 Eli Zaretskii <eliz@gnu.org>
6145
eb35682e
EZ
6146 * xdisp.c (handle_single_display_spec): Rename the
6147 display_replaced_before_p argument into display_replaced_p, to
6148 make it consistent with the commentary. Fix typos in the
6149 commentary.
6150
e2ad650c
EZ
6151 * textprop.c (syms_of_textprop): Remove dead code.
6152 (copy_text_properties): Delete obsolete commentary about an
6153 interface that was deleted long ago. Fix typos in the description
6154 of arguments.
6155
1b2de274
EZ
6156 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6157 to changes in oldXMenu/XMenu.h from 2011-04-16.
6158 <menu_help_message, prev_menu_help_message>: Constify.
6159 (IT_menu_make_room): menu->help_text is now `const char **';
6160 adjust.
6161
6162 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6163 to changes in oldXMenu/XMenu.h from 2011-04-16.
6164 (struct XMenu): Declare `help_text' `const char **'.
6165
6166 * xfaces.c <Qunspecified>: Make extern again.
6167
6168 * syntax.c: Include sys/types.h before including regex.h, as
6169 required by Posix.
6170
762b15be
EZ
6171 * doc.c (get_doc_string): Improve the format passed to `error'.
6172
6173 * doprnt.c (doprnt): Improve commentary.
6174
6175 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6176
6177 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6178 them with etags.
6179
f1052e5d
EZ
6180 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6181 changes in globals.h immediately force recompilation.
762b15be
EZ
6182 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6183 $(CURDIR)/s/ms-w32.h.
6184 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6185
fa6996bc
EZ
6186 * character.c (Fchar_direction): Function deleted.
6187 (syms_of_character): Don't defsubr it.
6188 <char-direction-table>: Deleted.
6189
e6c3da20
EZ
61902011-04-23 Eli Zaretskii <eliz@gnu.org>
6191
6192 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6193 * doprnt.c: Include limits.h.
6194 (SIZE_MAX): New macro.
04f2d78b
CB
6195 (doprnt): Return a size_t value. 2nd arg is now size_t.
6196 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6197 Improve overflow protection. Support `l' modifier for integer
6198 conversions. Support %l conversion. Don't assume an EMACS_INT
6199 argument for integer conversions and for %c.
6200
6201 * lisp.h (doprnt): Restore prototype.
6202
6203 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6204 $(SRC)/character.h.
6205
6206 * Makefile.in (base_obj): Add back doprnt.o.
6207
6208 * deps.mk (doprnt.o): Add back prerequisites.
6209 (callint.o): Depend on character.h.
6210
6211 * eval.c (internal_lisp_condition_case): Include the handler
6212 representation in the error message.
6213 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6214 when breaking from the loop.
6215
6216 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6217
6218 * callint.c (Fcall_interactively): When displaying error message
6219 about invalid control letter, pass the character's codepoint, not
6220 a pointer to its multibyte form. Improve display of the character
6221 in octal and display also its hex code.
6222
6223 * character.c (char_string): Use %x to display the (unsigned)
6224 codepoint of an invalid character, to avoid displaying a bogus
6225 negative value.
6226
6227 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6228 `error', not SYMBOL_NAME itself.
6229
6230 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6231 character arguments to `error'.
6232
6233 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6234 to `error' in error message about FINAL_CHAR argument. Make sure
6235 FINAL_CHAR is a character, and use %c when it is passed as
6236 argument to `error'.
6237
4ffd0d6b 62382011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6239
6240 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6241
6242 * w32.c: Include <time.h>.
6243 (sys_localtime): New function.
6244
4ffd0d6b 62452011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6246
6247 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6248
4ffd0d6b 6249 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6250
4ffd0d6b 62512011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6252
4ffd0d6b
GM
6253 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6254 zombies (Bug#8467).
aac0c6e3 6255
04c56954
EZ
62562011-04-19 Eli Zaretskii <eliz@gnu.org>
6257
6258 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6259 gl_state.e_property when gl_state.object is Qt.
6260
6261 * insdel.c (make_gap_larger): Remove limitation of buffer size
6262 to <= INT_MAX.
6263
16a43933
CY
62642011-04-18 Chong Yidong <cyd@stupidchicken.com>
6265
6266 * xdisp.c (lookup_glyphless_char_display)
6267 (produce_glyphless_glyph): Handle cons cell entry in
6268 glyphless-char-display.
6269 (Vglyphless_char_display): Document it.
6270
6271 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6272 glyphless-char-display.
6273
4581706e
CY
62742011-04-17 Chong Yidong <cyd@stupidchicken.com>
6275
6276 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6277
6278 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6279
6280 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6281 definition for no-X builds.
6282
4887c6e2 62832011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6284
fd35b6f9
PE
6285 Static checks with GCC 4.6.0 and non-default toolkits.
6286
5c1ccb01
PE
6287 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6288
006c5daa
PE
6289 * process.c (keyboard_bit_set): Define only if SIGIO.
6290 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6291 (send_process): Repair possible setjmp clobbering.
6292
efc736d3
PE
6293 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6294
4e2fe2e6
PE
6295 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6296
f97334a2
PE
6297 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6298
4e75f29d
PE
6299 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6300 Define only if needed.
6301
90efadd1
PE
6302 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6303 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6304 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6305
3c647824
PE
6306 * dispextern.h (struct redisplay_interface): Rename param
6307 to avoid shadowing.
e264f262 6308 * termhooks.h (struct terminal): Likewise.
761383f4 6309 * xterm.c (xembed_send_message): Likewise.
3c647824 6310
b58c5c4a
PE
6311 * insdel.c (make_gap_smaller): Define only if
6312 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6313
cad59032
PE
6314 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6315 it.
6316
c339dc2e
PE
6317 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6318 so that we aren't warned about unused symbols.
6319
91a3e27b
PE
6320 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6321
399c71d3 6322 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6323
8ffc96f5
PE
6324 * xfns.c (x_real_positions): Mark locals as initialized.
6325
eef9bc79
PE
6326 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6327
098db9dd
PE
6328 * xterm.c: Fix problems found by static analysis with other toolkits.
6329 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6330 (x_dispatch_event): Declare static if USE_GTK, and
6331 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6332 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6333 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6334 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6335 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6336
eb18f6cc
PE
6337 * xmenu.c (menu_help_callback): Pointer type fixes.
6338 Use const pointers when pointing at readonly data. Avoid pointer
6339 signedness clashes.
6340 (FALSE): Remove unused macro.
6341 (update_frame_menubar): Remove unused decl.
6342
1fe72bf8
PE
6343 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6344
60d9e1db
PE
6345 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6346 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6347 (single_menu_item): Rename local to avoid shadowing.
6348
39261c26
PE
6349 * keyboard.c (make_lispy_event): Remove unused local var.
6350
018c5e19
PE
6351 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6352 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6353
63d2b86e
PE
6354 * bitmaps: Change bitmaps from unsigned char back to the X11
6355 compatible char. Avoid the old compiler warnings about
6356 out-of-range initializers by using, for example, '\xab' rather
6357 than 0xab.
6358
aefd87e1
PE
6359 * xgselect.c (xgselect_initialize): Check vs interface
6360 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6361
bf501fb9
PE
6362 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6363
e9829fdf
PE
6364 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6365 to read-only memory.
6366
1086c095
PE
6367 * fns.c (vector): Remove; this old hack is no longer needed.
6368
2baccd04 6369 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6370 Remove unused var.
dde42981 6371 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6372
72391843 6373 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6374
436c16df 6375 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6376 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6377 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6378
92bb796d 6379 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6380 (x_term_init): Remove local to avoid shadowing.
92bb796d 6381
764430a3 6382 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6383
6384 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6385 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6386
d1dfb56c
EZ
63872011-04-16 Eli Zaretskii <eliz@gnu.org>
6388
c4354cb4
EZ
6389 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6390
d1dfb56c
EZ
6391 Fix regex.c, syntax.c and friends for buffers > 2GB.
6392 * syntax.h (struct gl_state_s): Declare character position members
6393 EMACS_INT.
6394
6395 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6396
04f2d78b
CB
6397 * textprop.c (verify_interval_modification, interval_of):
6398 Declare arguments EMACS_INT.
d1dfb56c
EZ
6399
6400 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6401 EMACS_INT.
6402
6403 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6404
6405 * indent.c (Fvertical_motion): Local variable it_start is now
6406 EMACS_INT.
6407
6408 * regex.c (re_match, re_match_2, re_match_2_internal)
6409 (bcmp_translate, regcomp, regexec, print_double_string)
6410 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6411 (re_compile_pattern, re_exec): Declare arguments and local
6412 variables `size_t' and `ssize_t' and return values `regoff_t', as
6413 appropriate.
6414 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6415 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6416 <compile_stack_type>: `size' and `avail' are now `size_t'.
6417
6418 * regex.h <regoff_t>: Use ssize_t, not int.
6419 (re_search, re_search_2, re_match, re_match_2): Arguments that
6420 specify buffer/string position and length are now ssize_t and
6421 size_t. Return type is regoff_t.
6422
613052cd
BK
64232011-04-16 Ben Key <bkey76@gmail.com>
6424
6425 * nsfont.m: Fixed bugs in ns_get_family and
6426 ns_descriptor_to_entity that were caused by using free to
6427 deallocate memory blocks that were allocated by xmalloc (via
6428 xstrdup). This caused Emacs to crash when compiled with
6429 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6430 --enable-checking=xmallocoverrun). xfree is now used to
6431 deallocate these memory blocks.
6432
4170f62f 64332011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6434
71b41406
PE
6435 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6436
9587a89d
PE
6437 emacs_write: Accept and return EMACS_INT for sizes.
6438 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6439 et seq.
6440 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6441 Accept and return EMACS_INT.
6442 (emacs_gnutls_write): Return the number of bytes written on
6443 partial writes.
6444 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6445 (emacs_read, emacs_write): Remove check for negative size, as the
6446 Emacs source code has been audited now.
9587a89d
PE
6447 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6448 (emacs_read, emacs_write): Use it.
273a5f82
PE
6449 * process.c (send_process): Adjust to the new signatures of
6450 emacs_write and emacs_gnutls_write. Do not attempt to store
6451 a byte offset into an 'int'; it might overflow.
9587a89d 6452 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6453
3e047f51
PE
6454 * sound.c: Don't assume sizes fit in 'int'.
6455 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6456 Return EMACS_INT, not int.
3e047f51 6457 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6458 Accept EMACS_INT, not int.
6459 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6460 record read return values.
6461
cc39a9db
BK
64622011-04-15 Ben Key <bkey76@gmail.com>
6463
c9d0ec6d
JB
6464 * keyboard.c (Qundefined): Don't declare static since it is used
6465 in nsfns.m.
6466 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6467 static since they are used in nsfont.m.
cc39a9db 6468
6c60eb9f
SM
64692011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6470
6471 * process.c (Qprocessp): Don't declare static.
6472 * lisp.h (Qprocessp): Declare again.
6473
7990b61a
JB
64742011-04-15 Juanma Barranquero <lekktu@gmail.com>
6475
6476 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6477
5d4cb038
PE
64782011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6479
8bd7b830 6480 Improve C-level modularity by making more things 'static'.
cd64ea1d 6481
e3b27b31
PE
6482 Don't publish debugger-only interfaces to other modules.
6483 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6484 (verify_bytepos, count_markers): Move decls to the only modules
6485 that need them.
6486 * region-cache.h (pp_cache): Likewise.
6487 * window.h (check_all_windows): Likewise.
6488 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6489
5d4cb038
PE
6490 * sysdep.c (croak): Now static, if
6491 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6492 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6493
6494 * alloc.c (refill_memory_reserve): Now static if
6495 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6496 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6497
e87b6180
PE
6498 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6499 Define only if USE_LUCID.
6500
ac64929e
PE
6501 * xrdb.c (x_customization_string, x_rm_string): Now static.
6502
6f37259d
PE
6503 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6504 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6505
1683e3ab
PE
6506 * xdisp.c (draw_row_with_mouse_face): Now static.
6507 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6508
de9c2632
PE
6509 * window.h (check_all_windows): Mark externally visible.
6510
2b96acb7
PE
6511 * window.c (window_deletion_count): Now static.
6512
6513 * undo.c: Make symbols static if they're not exported.
6514 (last_undo_buffer, last_boundary_position, pending_boundary):
6515 Now static.
6516
50436f33
PE
6517 * textprop.c (interval_insert_behind_hooks): Now static.
6518 (interval_insert_in_front_hooks): Likewise.
6519
64520e5c
PE
6520 * term.c: Make symbols static if they're not exported.
6521 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6522 (max_frame_lines, tty_set_terminal_modes):
6523 (tty_reset_terminal_modes, tty_turn_off_highlight):
6524 (get_tty_terminal): Now static.
6525 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6526 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6527 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6528 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6529 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6530
1fa53021
PE
6531 * sysdep.c: Make symbols static if they're not exported.
6532 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6533 Now static.
6534 (sigprocmask_set, full_mask): Remove; unused.
6535 (wait_debugging): Mark as visible.
6536 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6537 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6538
d4b43b22
PE
6539 * syntax.c (syntax_temp): Define only if !__GNUC__.
6540
b7c513d0
PE
6541 * sound.c (current_sound_device, current_sound): Now static.
6542
989b29ad
PE
6543 * search.c (searchbufs, searchbuf_head): Now static.
6544
13a55a78
PE
6545 * scroll.c (scroll_cost): Remove; unused.
6546 * dispextern.h (scroll_cost): Remove decl.
6547
de68a1fc
PE
6548 * region-cache.h (pp_cache): Mark as externally visible.
6549
40ccffa6
PE
6550 * process.c: Make symbols static if they're not exported.
6551 (process_tick, update_tick, create_process, chan_process):
6552 (Vprocess_alist, proc_buffered_char, datagram_access):
6553 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6554 (deactivate_process): Mark defn as static, as well as decl.
6555 * lisp.h (create_process): Remove decl.
6556 * process.h (chan_process, Vprocess_alist): Remove decls.
6557
ad64fc97
PE
6558 * print.c: Make symbols static if they're not exported.
6559 (print_depth, new_backquote_output, being_printed, print_buffer):
6560 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6561 (print_interval, print_number_index, initial_stderr_stream):
6562 Now static.
6563 * lisp.h (Fprinc): Remove decl.
6564 (debug_output_compilation_hack): Mark as externally visible.
6565
adddb265
PE
6566 * sysdep.c (croak): Move decl from here to syssignal.h.
6567 * syssignal.h (croak): Put it here, so the API can be checked when
6568 'croak' is called from dissociate_if_controlling_tty.
6569
1717ede2
PE
6570 * minibuf.c: Make symbols static if they're not exported.
6571 (minibuf_save_list, choose_minibuf_frame): Now static.
6572 * lisp.h (choose_minibuf_frame): Remove decl.
6573
fa5fb2bc
PE
6574 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6575
1e3890d1
PE
6576 * lread.c: Make symbols static if they're not exported.
6577 (read_objects, initial_obarray, oblookup_last_bucket_number):
6578 Now static.
6579 (make_symbol): Remove; unused.
6580 * lisp.h (initial_obarray, make_symbol): Remove decls.
6581
8a1414fa
PE
6582 * keyboard.c: Make symbols static if they're not exported.
6583 (single_kboard, recent_keys_index, total_keys, recent_keys):
6584 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6585 (this_single_command_key_start, echoing, last_auto_save):
6586 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6587 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6588 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6589 (Vlispy_mouse_stem, double_click_count):
6590 Now static.
6591 (force_auto_save_soon): Define only if SIGDANGER.
6592 (ignore_mouse_drag_p): Now static if
6593 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6594 (print_help): Remove; unused.
6595 (stop_character, last_timer_event): Mark as externally visible.
6596 * keyboard.h (ignore_mouse_drag_p): Declare only if
6597 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6598 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6599 * lisp.h (echoing): Remove decl.
6600 (force_auto_save_soon): Declare only if SIGDANGER.
6601 * xdisp.c (redisplay_window): Simplify code, to make it more
6602 obvious that ignore_mouse_drag_p is not accessed if !defined
6603 USE_GTK && !defined HAVE_NS.
6604
93ea6e8f
PE
6605 * intervals.c: Make symbols static if they're not exported.
6606 (merge_properties_sticky, merge_interval_right, delete_interval):
6607 Now static.
6608 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6609
77382fcc
PE
6610 * insdel.c: Make symbols static if they're not exported.
6611 However, leave prepare_to_modify_buffer alone. It's never
6612 called from outside this function, but that appears to be a bug.
6613 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6614 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6615 (adjust_after_replace_noundo): Remove; unused.
6616 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6617 (signal_before_change): Remove decls.
77382fcc 6618
9306c32e
PE
6619 * indent.c (val_compute_motion, val_vmotion): Now static.
6620
cd44d2eb
PE
6621 * image.c: Make symbols static if they're not exported.
6622 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6623 if USE_GTK.
6624 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6625 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6626
ad9a7a06
PE
6627 * fringe.c (standard_bitmaps): Now static.
6628 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6629
81626931
PE
6630 * frame.c: Make symbols static if they're not exported.
6631 (x_report_frame_params, make_terminal_frame): Now static.
6632 (get_frame_param): Now static, unless HAVE_NS.
6633 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6634 (x_get_resource_string): Remove; not used.
6635 * frame.h (make_terminal_frame, x_report_frame_params):
6636 (x_get_resource_string); Remove decls.
6637 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6638 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6639
239f9db9
PE
6640 * font.c, fontset.c: Make symbols static if they're not exported.
6641 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6642 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6643 * font.c (font_close_object): Now static.
6644 * font.h (font_close_object): Remove.
6645 * fontset.c (FONTSET_OBJLIST): Remove.
6646 (free_realized_fontset) #if-0 the body, which does nothing.
6647 (face_suitable_for_char_p): #if-0, as it's never called.
6648 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6649 * xfaces.c (face_at_string_position):
6650 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6651 since 0 is always ASCII.
6652
dfcf3579
PE
6653 * fns.c (weak_hash_tables): Now static.
6654
5045092b
PE
6655 * fileio.c: Make symbols static if they're not exported.
6656 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6657 (Vwrite_region_annotation_buffers): Now static.
6658
57a96f5c
PE
6659 * eval.c: Make symbols static if they're not exported.
6660 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6661 * lisp.h (backtrace_list): Remove decl.
6662
35f08c38
PE
6663 * emacs.c: Make symbols static if they're not exported.
6664 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6665 (fatal_error_code, fatal_error_signal_hook, standard_args):
6666 Now static.
6667 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6668 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6669 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6670 * lisp.h (fatal_error_signal_hook): Remove decl.
6671 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6672
f44bd759
PE
6673 * editfns.c: Move a (normally-unused) function to its only use.
6674 * editfns.c, lisp.h (get_operating_system_release): Remove.
6675 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6676 worth the hassle of breaking this out.
6677
b532497d
PE
6678 * xterm.c: Make symbols static if they're not exported.
6679 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6680 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6681 (x_destroy_window, x_delete_display):
6682 Now static.
6683 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6684 (x_mouse_leave): Remove; unused.
6685 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6686 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6687 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6688 Remove decls.
6689 (x_mouse_leave): Declare only if WINDOWSNT.
6690 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6691 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6692 USE_X_TOOLKIT.
6693
1675728f
PE
6694 * ftxfont.c: Make symbols static if they're not exported.
6695 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6696 HAVE_FREETYPE.
6697 * font.h (ftxfont_driver): Likewise.
6698
e4cebfca
PE
6699 * xfns.c: Make symbols static if they're not exported.
6700 (x_last_font_name, x_display_info_for_name):
6701 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6702 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6703 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6704 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6705 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6706 (last_show_tip_args): Now static.
6707 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6708 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6709 (x_screen_planes): Remove; unused.
6710 * dispextern.h (x_screen_planes): Remove decl.
6711
5bf46f05
PE
6712 * dispnew.c: Make symbols static if they're not exported.
6713 * dispextern.h (redraw_garbaged_frames, scrolling):
6714 (increment_row_positions): Remove.
6715 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6716 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6717 Now static.
6718 (redraw_garbaged_frames): Remove; unused.
6719
435f4c28
PE
6720 * xfaces.c: Make symbols static if they're not exported.
6721 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6722 Remove decls.
6723 * xterm.h (defined_color): Remove decls.
6724 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6725 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6726 (menu_face_changed_default, defined_color, free_realized_face):
6727 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6728 (ascii_face_of_lisp_face): Remove; unused.
6729
8524aef3
PE
6730 * xdisp.c: Make symbols static if they're not exported.
6731 * dispextern.h (scratch_glyph_row, window_box_edges):
6732 (glyph_to_pixel_coords, set_cursor_from_row):
6733 (get_next_display_element, set_iterator_to_next):
6734 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6735 (show_mouse_face): Remove decls
6736 * frame.h (message_buf_print): Likewise.
6737 * lisp.h (pop_message, set_message, check_point_in_composition):
6738 Likewise.
6739 * xterm.h (set_vertical_scroll_bar): Likewise.
6740 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6741 (message_buf_print, scratch_glyph_row, displayed_buffer):
6742 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6743 (get_next_display_element, show_mouse_face, window_box_edges):
6744 (frame_to_window_pixel_xy, check_point_in_composition):
6745 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6746 (glyph_to_pixel_coords): Remove; unused.
6747
16390cd2
PE
6748 * dired.c (file_name_completion): Now static.
6749
6750 * dbusbind.c (xd_in_read_queued_messages): Now static.
6751
a25f4dfa
PE
6752 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6753 * data.c (circular_list_error): Remove.
6754
14a9c8df
PE
6755 * commands.h (last_point_position, last_point_position_buffer):
6756 (last_point_position_window): Remove decls.
6757 * keyboard.c: Make these variables static.
6758
04f2d78b
CB
6759 * coding.h (coding, code_convert_region, encode_coding_gap):
6760 Remove decls.
74ab6df5
PE
6761 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6762 (iso_code_class, detect_coding, code_convert_region): Now static.
6763 (encode_coding_gap): Remove; unused.
6764
38dfbee1
PE
6765 * chartab.c (chartab_chars, chartab_bits): Now static.
6766
a2cb4e63
PE
6767 * charset.h (charset_iso_8859_1): Remove decl.
6768 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6769 Now static.
6770
127198fd
PE
6771 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6772 * ccl.c (Vccl_program_table): Now static.
6773 (check_ccl_update): Remove; unused.
6774
d85b608f
PE
6775 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6776 * category.h: ... from here.
6777 * category.c (check_category_table, set_category_set): Now static.
6778
31cd66f3
PE
6779 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6780 * lisp.h: Remove these decls.
6781
c358e587
PE
6782 * buffer.c (buffer_count): Remove unused var.
6783
e78aecca
PE
6784 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6785 so that it's not optimized away.
6786 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6787 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6788 exported only to the debugger.
6789
e192d7d3 6790 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6791 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6792
92470028
PE
6793 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6794 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6795 was inaccessible from Lisp.
6796 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6797 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6798
244ed907
PE
6799 alloc.c: Import and export fewer symbols, and remove unused items.
6800 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6801 is defined.
6802 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6803 it's not optimized away by whole-program optimization.
6804 (message_enable_multibyte, free_misc): Remove.
6805 (catchlist, handlerlist, mark_backtrace):
6806 Declare only if BYTE_MARK_STACK.
6807 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6808 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6809 (message_enable_multibyte): Remove decl.
6810 (free_misc, interval_free_list, float_block, float_block_index):
6811 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6812 (cons_free_list, last_marked_index):
6813 Now static.
6814 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6815 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6816 (mark_backtrace): Define only if BYTE_MARK_STACK.
6817 * xdisp.c (message_enable_multibyte): Now static.
6818
61c2b50e 6819 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6820 This makes it easier for human readers (and static analyzers)
6821 to see whether these variables are used from other modules.
6822 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6823 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6824 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6825 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6826 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6827 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6828 * xmenu.c, xselect.c:
6829 Declare Q* vars static if they are not used in other modules.
6830 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6831 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6832 Remove decls of unexported vars.
6833 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6834
95c82688
PE
6835 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6836
16a97296
PE
6837 Make Emacs functions such as Fatom 'static' by default.
6838 This makes it easier for human readers (and static analyzers)
6839 to see whether these functions can be called from other modules.
6840 DEFUN now defines a static function. To make the function external
6841 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6842 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6843 (Finit_image_library):
16a97296
PE
6844 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6845 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6846 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6847 Remove decls, since these functions are now static.
6848 (Funintern, Fget_internal_run_time): New decls, since these functions
6849 were already external.
95c82688 6850
16a97296
PE
6851 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6852 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6853 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6854 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6855 * keyboard.c, keymap.c, lread.c:
6856 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6857 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6858 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6859 Mark functions with DEFUE instead of DEFUN,
6860 if they are used in other modules.
6861 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6862 decls for now-static functions.
6863 * buffer.h (Fdelete_overlay): Remove decl.
6864 * callproc.c (Fgetenv_internal): Mark as internal.
6865 * composite.c (Fremove_list_of_text_properties): Remove decl.
6866 (Fcomposition_get_gstring): New forward static decl.
6867 * composite.h (Fcomposite_get_gstring): Remove decl.
6868 * dired.c (Ffile_attributes): New forward static decl.
6869 * doc.c (Fdocumntation_property): New forward static decl.
6870 * eval.c (Ffetch_bytecode): New forward static decl.
6871 (Funintern): Remove extern decl; now in .h file where it belongs.
6872 * fileio.c (Fmake_symbolic_link): New forward static decl.
6873 * image.c (Finit_image_library): New forward static decl.
6874 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6875 * intervals.h (Fprevious_property_change):
6876 (Fremove_list_of_text_properties): Remove decls.
6877 * keyboard.c (Fthis_command_keys): Remove decl.
6878 (Fcommand_execute): New forward static decl.
6879 * keymap.c (Flookup_key): New forward static decl.
6880 (Fcopy_keymap): Now static.
6881 * keymap.h (Flookup_key): Remove decl.
6882 * process.c (Fget_process): New forward static decl.
6883 (Fprocess_datagram_address): Mark as internal.
6884 * syntax.c (Fsyntax_table_p): New forward static decl.
6885 (skip_chars): Remove duplicate decl.
6886 * textprop.c (Fprevious_property_change): New forward static decl.
6887 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6888 Now internal.
6889 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6890 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6891
785bbd42
PE
6892 * editfns.c (Fformat): Remove unreachable code.
6893
8b913b57
AS
68942011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6895
6896 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6897 change. (Bug#8496)
6898
a6744a35
EZ
68992011-04-13 Eli Zaretskii <eliz@gnu.org>
6900
6901 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6902 when at ZV. (Bug#8487)
6903
e7974947
AS
69042011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6905
baad03f0
AS
6906 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6907 (Bug#8437)
6908 * keyboard.c (parse_tool_bar_item): Likewise.
6909 * sound.c (sound_cleanup, alsa_close): Likewise.
6910 * termcap.c (tgetent): Likewise.
6911 * xfns.c (x_default_font_parameter): Likewise.
6912 * xsettings.c (read_and_apply_settings): Likewise.
6913
e7974947
AS
6914 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6915 (overrun_check_free): Protoize.
6916
28272684
PE
69172011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6918
6919 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6920 since callers should never pass a negative size.
6921 Change the signature to match that of plain 'read' and 'write'; see
6922 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6923 * lisp.h: Update prototypes of emacs_write and emacs_read.
6924
11997c76
EZ
69252011-04-11 Eli Zaretskii <eliz@gnu.org>
6926
6927 * xdisp.c (redisplay_window): Don't try to determine the character
6928 position of the scroll margin if the window start point w->startp
e896f03c 6929 is outside the buffer's accessible region. (Bug#8468)
11997c76 6930
8a2cbd72
EZ
69312011-04-10 Eli Zaretskii <eliz@gnu.org>
6932
6933 Fix write-region and its subroutines for buffers > 2GB.
6934 * fileio.c (a_write, e_write): Modify declaration of arguments and
6935 local variables to support buffers larger than 2GB.
6936 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6937
6938 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6939 argument, local variables, and return value.
6940
6941 * lisp.h: Update prototypes of emacs_write and emacs_read.
6942
6943 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6944
4073e537 69452011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6946
1ebfdcb6
PE
6947 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6948
b2ded58d
PE
6949 Fix more problems found by GCC 4.6.0's static checks.
6950
7d66342c
PE
6951 * xdisp.c (vmessage): Use a better test for character truncation.
6952
bbf47d44
PE
6953 * charset.c (load_charset_map): <, not <=, for optimization,
6954 and to avoid potential problems with integer overflow.
9248994d 6955 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6956 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6957 * editfns.c (Fformat): Likewise.
1e69125e 6958 * syntax.c (skip_chars): Likewise.
3befa583 6959
e3019616
PE
6960 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6961 This also lets GCC 4.6.0 generate slightly better loop code.
6962
becfa255
PE
6963 * callint.c (Fcall_interactively): <, not <=, for optimization.
6964 (Fcall_interactively): Count the number of arguments produced,
6965 not the number of arguments given. This is simpler and lets GCC
6966 4.6.0 generate slightly better code.
6967
dae0cd48
PE
6968 * ftfont.c: Distingish more carefully between FcChar8 and char.
6969 The previous code passed unsigned char * to a functions like
6970 strlen and xstrcasecmp that expect char *, which does not
6971 conform to the C standard.
6972 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6973 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6974 char * when the C standard requires it.
6975
76032d70
PE
6976 * keyboard.c (read_char): Remove unused var.
6977
eb3f1cc8
PE
6978 * eval.c: Port to Windows vsnprintf (Bug#8435).
6979 Include <limits.h>.
6980 (SIZE_MAX): Define if the headers do not.
6981 (verror): Do not give up if vsnprintf returns a negative count.
6982 Instead, grow the buffer. This ports to Windows vsnprintf, which
6983 does not conform to C99. Problem reported by Eli Zaretskii.
6984 Also, simplify the allocation scheme, by avoiding the need for
6985 calling realloc, and removing the ALLOCATED variable.
6986
70476b54
PE
6987 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6988
12020a9e
PE
6989 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6990 But keep the doprint source code for now, as we might revamp it
6991 and use it again (Bug#8435).
ea6c7ae6
PE
6992 * lisp.h (doprnt): Remove.
6993 * Makefile.in (base_obj): Remove doprnt.o.
6994 * deps.mk (doprnt.o): Remove.
6995
5fdb398c
PE
6996 error: Print 32- and 64-bit integers portably (Bug#8435).
6997 Without this change, on typical 64-bit hosts error ("...%d...", N)
6998 was used to print both 32- and 64-bit integers N, which relied on
6999 undefined behavior.
7000 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7001 New macro.
7002 * lisp.h (error, verror): Mark as printf-like functions.
7003 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7004 Report overflow in size calculations when allocating printf buffer.
7005 Do not truncate output string at its first null byte.
7006 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7007 Truncate the output at a character boundary, since vsnprintf does not
7008 do that.
7009 * charset.c (check_iso_charset_parameter): Convert internal
7010 character to string before calling 'error', since %c now has the
7011 printf meaning.
7012 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7013 overflow when computing char to be passed to 'error'. Do not
7014 pass Lisp_Object to 'error'; pass the integer instead.
7015 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7016 formatted with plain %d.
7017
b189fa66
PE
7018 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7019
bff87ef0
PE
7020 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7021
7e2cac20
PE
7022 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7023
ce4d90b5
PE
7024 * xterm.c (x_catch_errors): Remove duplicate declaration.
7025
266c9547
PE
7026 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7027
79c49ad2
PE
7028 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7029
368f4090
JM
70302011-04-10 Jim Meyering <meyering@redhat.com>
7031
7032 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7033 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7034 return ssize_t not "int", and use size_t as the buffer length.
7035 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7036 * gnutls.h: Update declarations.
7037 * process.c (read_process_output): Use ssize_t, to match.
7038 (send_process): Likewise.
7039
a32d4040
CY
70402011-04-09 Chong Yidong <cyd@stupidchicken.com>
7041
7042 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7043
8546720e 70442011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7045
04f2d78b
CB
7046 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7047 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7048
8546720e
GM
7049 * xterm.c (handle_one_xevent):
7050 * xmenu.c (create_and_show_popup_menu):
7051 * xselect.c (x_decline_selection_request)
7052 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7053
0a2f5c1a 70542011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7055
7056 Fix some uses of `int' instead of EMACS_INT.
7057 * search.c (string_match_1, fast_string_match)
7058 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7059 (scan_buffer, find_next_newline_no_quit)
7060 (find_before_next_newline, search_command, Freplace_match)
7061 (Fmatch_data): Make some `int' variables be EMACS_INT.
7062
7063 * xdisp.c (display_count_lines): 3rd argument and return value now
7064 EMACS_INT. All callers changed.
7065 (pint2hrstr): Last argument is now EMACS_INT.
7066
7067 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7068 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7069 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7070 (decode_coding_utf_16, decode_coding_emacs_mule)
7071 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7072 (decode_coding_ccl, decode_coding_charset)
7073 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7074 (decode_coding_iso_2022, decode_coding_emacs_mule)
7075 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7076 <char_offset, last_offset>: Declare EMACS_INT.
7077 (encode_coding_utf_8, encode_coding_utf_16)
7078 (encode_coding_emacs_mule, encode_invocation_designation)
7079 (encode_designation_at_bol, encode_coding_iso_2022)
7080 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7081 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7082 Declare EMACS_INT.
7083 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7084 (encode_invocation_designation): Last argument P_NCHARS is now
7085 EMACS_INT.
7086 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7087 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7088
7089 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7090 All users changed.
7091
7092 * ccl.c (Fccl_execute_on_string): Declare some variables
7093 EMACS_INT.
7094
8546720e 70952011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7096
7097 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7098
4e19a977
CS
70992011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7100
7101 * process.c (Fformat_network_address): Doc fix.
7102
87302331
R
71032011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7104
ee7683eb 7105 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7106
cbb59342
CY
71072011-04-08 Chong Yidong <cyd@stupidchicken.com>
7108
7109 * keyboard.c (read_char): Call Lisp function help-form-show,
7110 instead of using internal_with_output_to_temp_buffer.
7111 (Qhelp_form_show): New var.
e0d38eeb 7112 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7113
7114 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7115
7116 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7117
e67a13ab
CY
71182011-04-06 Chong Yidong <cyd@stupidchicken.com>
7119
04f2d78b
CB
7120 * process.c (Flist_processes): Remove to Lisp.
7121 (list_processes_1): Delete.
e67a13ab 7122
973f782d
EZ
71232011-04-06 Eli Zaretskii <eliz@gnu.org>
7124
7c106b1e
EZ
7125 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7126
973f782d
EZ
7127 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7128
41cf7d1a 71292011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7130
ca23cc88
PE
7131 Fix more problems found by GCC 4.6.0's static checks.
7132
f390e2d5
PE
7133 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7134
42eea0d0
PE
7135 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7136
b69769da 7137 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7138
f9541e84
PE
7139 * xdisp.c (vmessage): Mark as a printf-like function.
7140
13841b55
PE
7141 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7142
c136c10f
PE
7143 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7144
5e2d4a30
PE
7145 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7146 printf-like functions.
7147 (tiff_load): Add casts to remove these marks before passing them
7148 to system-supplied API.
7149
583f48b9
PE
7150 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7151
b25d760e
PE
7152 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7153 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7154 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7155 directly, rather than having caller test rule sign. This avoids
7156 some unnecessary tests.
7157 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7158 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7159 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7160
bc7b6697 7161 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7162 (xfont_open): Avoid unnecessary tests.
bc7b6697 7163
27ccc379
PE
7164 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7165
dcd5c89a
PE
7166 * composite.h, composite.c (composition_gstring_put_cache):
7167 Use EMACS_INT, not int, for length.
7168
b13a45c6
PE
7169 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7170 breaking out part of COMPOSITION_DECODE_RULE.
7171 (COMPOSITION_DECODE_RULE): Use it.
7172 * composite.c (get_composition_id): Remove unused local vars,
7173 by using the new macro.
7174
1e792e4d
PE
7175 * textprop.c (set_text_properties_1): Change while to do-while,
7176 since the condition is always true at first.
7177
dc6c6455 7178 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7179 (interval_deletion_adjustment): Return unsigned value.
7180 All uses changed.
dc6c6455 7181
aba7731a
PE
7182 * process.c (list_processes_1, create_pty, read_process_output):
7183 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7184 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7185 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7186 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7187 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7188
fdfc4bf3
PE
7189 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7190
fca8fe46 7191 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7192 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7193
06a0259a 7194 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7195 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7196 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7197
e7b9e80f
PE
7198 * print.c (print_error_message): Avoid int overflow.
7199
56201685
PE
7200 * font.c (font_list_entities): Redo for clarity,
7201 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7202
78834453 7203 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7204 (font_score): Avoid potential overflow in diff calculation.
78834453 7205
0bc0b309 7206 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7207 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7208
e610eaca
PE
7209 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7210
b895abce
PE
7211 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7212 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7213 can always succeed if overflow has undefined behavior.
7214
1f1d9321 7215 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7216 (wordify): Omit three unnecessary tests.
1f1d9321 7217
c59478bc
PE
7218 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7219 All callers changed. This avoids the need for an unused var.
7220
79b73827
PE
7221 * casefiddle.c (casify_region): Remove var that is set but not used.
7222
a4db5dfe
PE
7223 * dired.c (file_name_completion): Remove var that is set but not used.
7224
43aae36e
PE
7225 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7226
2a47c44d 7227 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7228 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7229
a37c69bf
PE
7230 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7231 Check for integer overflow on size calculations.
7232
328ab8e7
PE
7233 * buffer.c (Fprevious_overlay_change): Remove var that is set
7234 but not used.
7235
e5a2a5cb
PE
7236 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7237 Remove vars that are set but not used.
8d84a6eb 7238 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7239 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7240
a60e5f68
PE
7241 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7242
f661cb61 7243 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7244 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7245
f0397f5a
PE
7246 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7247 that are set but not used.
7248
8664db06 7249 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7250 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7251
6abdaa4a
PE
7252 * xselect.c (x_get_local_selection, x_handle_property_notify):
7253 Remove vars that are set but not used.
7254
0ce7538d 7255 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7256 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7257
9ae848fc
PE
7258 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7259 Remove var that is set but not used.
0b918413
PE
7260 (scroll_bar_windows_size): Now size_t, not int.
7261 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7262 Check for overflow.
9ae848fc 7263
a5a62657
PE
7264 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7265 (map_tty_color) [!defined MSDOS]: Likewise.
7266
5c5cdd39
PE
7267 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7268
66ebf983
PE
7269 * coding.c: Remove vars that are set but not used.
7270 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7271 All callers changed.
7272 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7273 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7274 (decode_coding_charset): Remove vars that are set but not used.
7275
1be4d761
PE
7276 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7277 that is set but not used.
7278
47553fa8
PE
7279 * print.c (print_object): Remove var that is set but not used.
7280
1f7196bf 7281 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7282 The gnulib version avoids calling malloc in the usual case,
7283 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7284 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7285 * filelock.c (current_lock_owner): Likewise.
7286 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7287 * sysdep.c: Include allocator.h, careadlinkat.h.
7288 (emacs_no_realloc_allocator): New static constant.
7289 (emacs_readlink): New function.
fdb61804
PE
7290 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7291 ../lib/careadlinkat.h.
d1fdcab7 7292
f84c17c7
SM
72932011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7294
7295 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7296 first non-nil return value).
7297
ef3862ad
JD
72982011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7299
7300 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7301 if not defined (Bug#8403).
7302
376a7006
JB
73032011-04-02 Juanma Barranquero <lekktu@gmail.com>
7304
7305 * xdisp.c (display_count_lines): Remove parameter `start',
7306 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7307 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7308 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7309 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7310 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7311 and thereabouts. All callers changed.
7312 (get_per_char_metric): Remove parameter `f', unused since
7313 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7314
6ca3801d
JM
73152011-04-02 Jim Meyering <meyering@redhat.com>
7316
7317 do not dereference NULL upon failed strdup
7318 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7319 (ns_get_family): Likewise.
7320
d8e2b5ba
JB
73212011-04-02 Juanma Barranquero <lekktu@gmail.com>
7322
7323 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7324
8c74fcbd
JD
73252011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7326
7327 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7328 later (Bug#8403).
7329
7200d79c
SM
73302011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7331
03408648 7332 Add lexical binding.
7200d79c 7333
03408648
SM
7334 * window.c (Ftemp_output_buffer_show): New fun.
7335 (Fsave_window_excursion):
7336 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7337
7338 * lread.c (lisp_file_lexically_bound_p): New function.
7339 (Fload): Bind Qlexical_binding.
7340 (readevalloop): Remove `evalfun' arg.
7341 Bind Qinternal_interpreter_environment.
7342 (Feval_buffer): Bind Qlexical_binding.
7343 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7344 Mark as dynamic.
7345 (syms_of_lread): Declare `lexical-binding'.
7346
7347 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7348
7349 * keyboard.c (eval_dyn): New fun.
7350 (menu_item_eval_property): Use it.
ca105506
SM
7351
7352 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7353
03408648
SM
7354 * fns.c (concat, mapcar1): Accept byte-code-functions.
7355
7356 * eval.c (Fsetq): Handle lexical vars.
7357 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7358 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7359 (FletX, Flet): Obey lexical binding.
7360 (Fcommandp): Handle closures.
7361 (Feval): New `lexical' arg.
7362 (eval_sub): New function extracted from Feval. Use it almost
7363 everywhere where Feval was used. Look up vars in lexical env.
7364 Handle closures.
7365 (Ffunctionp): Move from subr.el.
7366 (Ffuncall): Handle closures.
7367 (apply_lambda): Remove `eval_flags'.
7368 (funcall_lambda): Handle closures and new byte-code-functions.
7369 (Fspecial_variable_p): New function.
7370 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7371 but without exporting it to Lisp.
23aba0ea 7372
23aba0ea 7373 * doc.c (Fdocumentation, store_function_docstring):
03408648 7374 * data.c (Finteractive_form): Handle closures.
23aba0ea 7375
03408648
SM
7376 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7377 interactive spec.
ba83908c 7378
04f2d78b
CB
7379 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7380 New byte-codes.
03408648
SM
7381 (exec_byte_code): New function extracted from Fbyte_code to handle new
7382 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7383
03408648 7384 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7385
03408648 7386 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7387
e2abce01
JB
73882011-03-31 Juanma Barranquero <lekktu@gmail.com>
7389
7390 * xdisp.c (redisplay_internal): Fix prototype.
7391
63696a73 73922011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7393
63696a73 7394 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7395 (try_scrolling): Use it when setting scroll_limit.
7396 Limit scrolling to 100 screen lines.
63696a73
EZ
7397 (redisplay_window): Even when falling back on "recentering",
7398 position point in the window according to scroll-conservatively,
7399 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7400
7401 (try_scrolling): When point is above the window, allow searching
7402 as far as scroll_max, or one screenful, to compute vertical
7403 distance from PT to the scroll margin position. This prevents
7404 try_scrolling from unnecessarily failing when
7405 scroll-conservatively is set to a value slightly larger than the
7406 window height. Clean up the case of PT below the margin at bottom
7407 of window: scroll_max can no longer be INT_MAX. When aggressive
7408 scrolling is in use, don't let point enter the opposite scroll
7409 margin as result of the scroll.
7410 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7411 threshold of 100 lines for never-recentering scrolling.
7412
e4cc2dfc
JB
74132011-03-31 Juanma Barranquero <lekktu@gmail.com>
7414
7415 * dispextern.h (move_it_by_lines):
7416 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7417 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7418 (message_log_check_duplicate): Remove parameters `prev_bol' and
7419 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7420 (redisplay_internal): Remove parameter `preserve_echo_area',
7421 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7422
7423 * indent.c (Fvertical_motion):
7424 * window.c (window_scroll_pixel_based, Frecenter):
7425 Don't pass `need_y_p' to `move_it_by_lines'.
7426
1c470562
SM
74272011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7428
44f230aa
SM
7429 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7430 steal a few bits to be more compact.
7431 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7432 Remove unneeded casts.
7433
1c470562
SM
7434 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7435
888adce9
ZK
74362011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7437
7438 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7439 binding" message (bug#7967).
7440
f838ed7b
PE
74412011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7442
77861b95
PE
7443 Fix more problems found by GCC 4.6.0's static checks.
7444
de6dbc14
PE
7445 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7446 Remove unused local var.
7447
f838ed7b
PE
7448 * editfns.c (Fmessage_box): Remove unused local var.
7449
792c7b2b
PE
7450 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7451 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7452 Omit unused local vars.
c499e557 7453 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7454 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7455 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7456 Omit unused local var.
7457
ba0165e1
PE
7458 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7459 Don't assume string length fits in int.
32ad8845 7460 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7461 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7462
3c59b4c9
PE
7463 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7464 instead of alloca (Bug#8344).
7465
a3eed478 7466 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7467 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7468
eb4d412d
PE
7469 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7470
1658b401
PE
7471 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7472 concerns.
7473
7474 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7475
7476 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7477
9a2c6e05
PE
7478 * keyboard.c (syms_of_keyboard): Use the same style as later
7479 in this function when indexing through an array. This also
7480 works around GCC bug 48267.
7481
03d0a109
PE
7482 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7483
44f730c8
PE
7484 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7485
fe75f926
PE
7486 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7487 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7488
ffa8c828
PE
7489 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7490 This avoids undefined behavior on integer overflow, and is a bit
7491 more convenient anyway since it is compared to a size_t variable.
7492
c5101a77
PE
7493 Variadic C functions now count arguments with size_t, not int.
7494 This avoids an unnecessary limitation on 64-bit machines, which
7495 caused (substring ...) to crash on large vectors (Bug#8344).
7496 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7497 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7498 All variadic functions and their callers changed accordingly.
c5101a77
PE
7499 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7500 * data.c (arith_driver, float_arith_driver): Likewise.
7501 * editfns.c (general_insert_function): Likewise.
7502 * eval.c (struct backtrace.nargs, interactive_p)
7503 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7504 (funcall_lambda, mark_backtrace): Likewise.
7505 * fns.c (concat): Likewise.
7506 * frame.c (x_set_frame_parameters): Likewise.
7507 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7508 0 if not found, not -1. All callers changed.
7509
dd3f25f7
PE
7510 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7511 (stack_copy_size): Now size_t, not int.
7512 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7513
461c2ab9
JB
75142011-03-28 Juanma Barranquero <lekktu@gmail.com>
7515
7516 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7517 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7518 All callers changed.
7519
7520 * lisp.h (multibyte_char_to_unibyte):
7521 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7522 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7523 * character.h (CHAR_TO_BYTE8):
7524 * cmds.c (internal_self_insert):
7525 * editfns.c (general_insert_function):
7526 * keymap.c (push_key_description):
7527 * search.c (Freplace_match):
7528 * xdisp.c (message_dolog, set_message_1): All callers changed.
7529
f6d62986
SM
75302011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7531
7532 * keyboard.c (safe_run_hook_funcall): New function.
7533 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7534 don't set the hook to nil, but remove the offending function instead.
7535 (Qcommand_hook_internal): Remove, unused.
7536 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7537 Vcommand_hook_internal.
7538
7539 * eval.c (enum run_hooks_condition): Remove.
7540 (funcall_nil, funcall_not): New functions.
7541 (run_hook_with_args): Call each function through a `funcall' argument.
7542 Remove `cond' argument, now redundant.
7543 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7544 (Frun_hook_with_args_until_failure): Adjust accordingly.
7545 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7546
1db5b1ad
JB
75472011-03-28 Juanma Barranquero <lekktu@gmail.com>
7548
7549 * dispextern.h (string_buffer_position): Remove declaration.
7550
7551 * print.c (strout): Remove parameter `multibyte', unused since
7552 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7553
7554 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7555 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7556 All callers changed.
7557
7558 * w32.c (_wsa_errlist): Use braces for struct initializers.
7559
7560 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7561 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7562 All callers changed.
7563 (string_buffer_position): Likewise. Also, make static (it's never
7564 used outside xdisp.c).
7565 (cursor_row_p): Remove parameter `w', unused since
7566 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7567 (decode_mode_spec): Remove parameter `precision', introduced during
7568 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7569 All callers changed.
7570
5ffb62aa
JD
75712011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7572
7573 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7574
461c2ab9 75752011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7576
7577 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7578 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7579 (ns_update_auto_hide_menu_bar): New functions.
7580 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7581 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7582 ns_constrain_all_frames.
7583 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7584 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7585
5c380ffb
JD
75862011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7587
7588 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7589
9af30bdf
GM
75902011-03-27 Glenn Morris <rgm@gnu.org>
7591
7592 * syssignal.h: Replace RETSIGTYPE with void.
7593 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7594 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7595 Replace SIGTYPE with void everywhere.
7596 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7597 * s/template.h (SIGTYPE): Remove commented out definition.
7598
e2abce01
JB
75992011-03-26 Eli Zaretskii <eliz@gnu.org>
7600
7601 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7602 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7603
f868cd8a
JB
76042011-03-26 Juanma Barranquero <lekktu@gmail.com>
7605
59eb0929
JB
7606 * w32.c (read_unc_volume): Use parameter `henum', instead of
7607 global variable `wget_enum_handle'.
7608
7609 * keymap.c (describe_vector): Remove parameters `indices' and
7610 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7611 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7612
f868cd8a
JB
7613 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7614
7615 * keyboard.c (timer_check): Remove parameter `do_it_now',
7616 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7617 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7618 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7619
7620 * keyboard.c (read_char):
7621 * w32menu.c (w32_menu_display_help):
7622 * xmenu.c (show_help_event, menu_help_callback):
7623 Adjust calls to `show_help_echo'.
7624
7625 * gtkutil.c (xg_maybe_add_timer):
7626 * keyboard.c (readable_events):
7627 * process.c (wait_reading_process_output):
7628 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7629
7630 * insdel.c (adjust_markers_gap_motion):
7631 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7632 (gap_left, gap_right): Don't call it.
7633
2ecf6fdb
CY
76342011-03-25 Chong Yidong <cyd@stupidchicken.com>
7635
7636 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7637 incurred during fontification.
7638
6b1f9ba4
JB
76392011-03-25 Juanma Barranquero <lekktu@gmail.com>
7640
7641 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7642 (DEFVAR_PER_BUFFER): Don't pass it.
7643
7644 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7645 (scrolling_window): Don't pass it.
7646
0f4a96b5
JB
76472011-03-25 Juanma Barranquero <lekktu@gmail.com>
7648
7649 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7650
7651 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7652 and `suffix'.
7653 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7654 of variables specific to SELinux and computation of `encoded_absname'.
7655
7656 * image.c (XPutPixel): Remove unused variable `height'.
7657
7658 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7659
7660 * unexw32.c (get_section_info): Remove unused variable `section'.
7661
7662 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7663 (system_process_attributes): Remove unused variable `sess'.
7664 (sys_read): Remove unused variable `err'.
7665
7666 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7667 (w32_wnd_proc): Remove unused variable `isdead'.
7668 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7669 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7670 (x_create_tip_frame): Remove unused variable `tem'.
7671
7672 * w32inevt.c (w32_console_read_socket):
7673 Remove unused variable `no_events'.
7674
7675 * w32term.c (x_draw_composite_glyph_string_foreground):
7676 Remove unused variable `width'.
7677
1149507c
JB
76782011-03-24 Juanma Barranquero <lekktu@gmail.com>
7679
7680 * w32term.c (x_set_glyph_string_clipping):
7681 Don't pass uninitialized region to CombineRgn.
7682
9c88f339
JB
76832011-03-23 Juanma Barranquero <lekktu@gmail.com>
7684
7685 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7686 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7687 (Fx_close_connection): Remove unused variable `i'.
7688
7689 * w32font.c (w32font_draw): Return number of glyphs.
7690 (w32font_open_internal): Remove unused variable `i'.
7691 (w32font_driver): Add missing initializer.
7692
7693 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7694 (fill_in_menu): Remove unused variable `items_added'.
7695
7696 * w32term.c (last_mouse_press_frame): Remove static global variable.
7697 (w32_clip_to_row): Remove unused variable `f'.
7698 (x_delete_terminal): Remove unused variable `i'.
7699
7700 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7701 (NOTHING): Remove unused static global variable.
7702 (uniscribe_check_otf): Remove unused variable `table'.
7703 (uniscribe_font_driver): Add missing initializers.
7704
dee091a3
JD
77052011-03-23 Julien Danjou <julien@danjou.info>
7706
7707 * term.c (Fsuspend_tty, Fresume_tty):
7708 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7709 * window.c (temp_output_buffer_show):
7710 * insdel.c (signal_before_change):
7711 * frame.c (Fhandle_switch_frame):
7712 * fileio.c (Fdo_auto_save):
7713 * emacs.c (Fkill_emacs):
7714 * editfns.c (save_excursion_restore):
7715 * cmds.c (internal_self_insert):
7716 * callint.c (Fcall_interactively):
7717 * buffer.c (Fkill_all_local_variables):
7718 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7719 Use Frun_hooks.
0f4a96b5 7720 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7721 unconditionnaly since it does the check itself.
7722
2c520ab5 77232011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7724
c9c49752
PE
7725 Fix more problems found by GCC 4.5.2's static checks.
7726
8abc3f12
PE
7727 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7728 the first time through the loop, since we know p0 < p1 then.
7729 This also avoids a gcc -Wstrict-overflow warning.
7730
a2d26660
PE
7731 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7732 leading to a memory leak, possible in functions like
7733 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7734 of objects (Bug#8318).
a2d26660 7735
916c72e9
PE
7736 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7737 that could (at least in theory) be that large.
7738
19ab8a18
PE
7739 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7740 This is less likely to overflow, and avoids undefined behavior if
7741 overflow does occur. All callers changed. Use strtoul to scan
7742 for the unsigned long integer.
b7cbbd6f
PE
7743 (pint2hrstr): Simplify and tune code slightly.
7744 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7745
f0641eff
PE
7746 * scroll.c (do_scrolling): Work around GCC bug 48228.
7747 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7748
7f650bb9
PE
7749 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7750 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7751 (validate_x_resource_name): Simplify count usage.
7752 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7753
37dd57d1
PE
7754 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7755 fail (Bug#8306).
81e56e61 7756
699979fc 7757 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7758
401bf9b4
PE
7759 * process.c (Fmake_network_process): Use socklen_t, not int,
7760 where POSIX says socklen_t is required in portable programs.
7761 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7762 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7763 (Fmake_network_process, server_accept_connection):
7764 (wait_reading_process_output, read_process_output):
7765 Likewise.
7766
b93aacde
PE
7767 * process.c: Rename or move locals to avoid shadowing.
7768 (list_processes_1, Fmake_network_process):
7769 (read_process_output_error_handler, exec_sentinel_error_handler):
7770 Rename or move locals.
4dc343ee 7771 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7772 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7773 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7774 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7775 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7776
af8a867c 7777 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7778 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7779 Include tparam.h instead, since it declares them.
af8a867c
PE
7780 * cm.h (PC): Remove extern decl; tparam.h now does this.
7781 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7782 * terminfo.c: Include tparam.h, to check interfaces.
7783 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7784 (tparam): Adjust signature to match interface in tparam.h;
7785 this removes some undefined behavior. Check that outstring and len
7786 are zero, which they always are with Emacs.
7787 * tparam.h (PC, BC, UP): New extern decls.
7788
0248044d 7789 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7790 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7791
8ff096c1 7792 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7793 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7794 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7795 (ftfont_list): Remove unused local.
49eaafba
PE
7796 (get_adstyle_property, ftfont_pattern_entity):
7797 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7798 Rename locals to avoid shadowing.
8ff096c1 7799
e2be39f6
PE
7800 * xfont.c (xfont_list_family): Mark var as initialized.
7801
c9735e30
PE
7802 * xml.c (make_dom): Now static.
7803
8f5201ae
PE
7804 * composite.c (composition_compute_stop_pos): Rename local to
7805 avoid shadowing.
b246f932
PE
7806 (composition_reseat_it): Remove unused locals.
7807 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7808 (composition_update_it): Mark var as initialized.
11b61122
PE
7809 (find_automatic_composition): Mark vars as initialized,
7810 with a FIXME (Bug#8290).
8f5201ae 7811
760fbc2c
PE
7812 character.h: Rename locals to avoid shadowing.
7813 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7814 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7815 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7816 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7817 to avoid shadowing.
7818
ff08eb85
PE
7819 * textprop.c (property_change_between_p): Remove; unused.
7820
fc7bf025
PE
7821 * intervals.c (interval_start_pos): Now static.
7822
235d7abc
PE
7823 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7824
44f230aa
SM
7825 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7826 Rename locals to avoid shadowing.
3e7d6594 7827
50060332
PE
7828 * sound.c (wav_play, au_play, Fplay_sound_internal):
7829 Fix pointer signedness.
d01f234b 7830 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7831 (wav_play): Initialize a variable to 0, to prevent undefined
7832 behavior (Bug#8278).
50060332 7833
c4fc4e30
PE
7834 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7835
918436ed
PE
7836 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7837
c939f91b
PE
7838 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7839 clobbering (Bug#8298).
b9c7f648
PE
7840 * sysdep.c (sys_subshell): Likewise.
7841 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7842
6bd8c144
PE
7843 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7844 This should get cleaned up, so that child_setup has the
7845 same signature on all platforms.
7846
7710357c 7847 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7848 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7849
c59da222
CY
78502011-03-22 Chong Yidong <cyd@stupidchicken.com>
7851
7852 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7853 not to be necessary, and produces flickering.
7854
66b87493
GM
78552011-03-20 Glenn Morris <rgm@gnu.org>
7856
7857 * config.in: Remove file.
7858
45b6f6d5
JB
78592011-03-20 Juanma Barranquero <lekktu@gmail.com>
7860
7861 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7862 are now in src/globals.h.
7863 (syms_of_minibuf): Remove spurious & from previous change.
7864
3ec03f7e
LL
78652011-03-20 Leo <sdl.web@gmail.com>
7866
7867 * minibuf.c (completing-read-function): New variable.
7868 (completing-read-default): Rename from completing-read.
7869 (completing-read): Call completing-read-function.
7870
b14e3e21
CY
78712011-03-19 Juanma Barranquero <lekktu@gmail.com>
7872
7873 * xfaces.c (Fx_load_color_file):
7874 Read color file from absolute filename (bug#8250).
7875
f2b726e6
JB
78762011-03-19 Juanma Barranquero <lekktu@gmail.com>
7877
7878 * makefile.w32-in: Update dependencies.
7879
09f6ff02
EZ
78802011-03-17 Eli Zaretskii <eliz@gnu.org>
7881
7882 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7883
29a6015a
PE
78842011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7885
a3a6c54e
PE
7886 Fix more problems found by GCC 4.5.2's static checks.
7887
b766f867
PE
7888 * process.c (make_serial_process_unwind, send_process_trap):
7889 (sigchld_handler): Now static.
7890
be02381c
PE
7891 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7892 That way, the code declares only the vars that it needs.
7893 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7894 * s/cygwin.h (PTY_ITERATION): Likewise.
7895 * s/darwin.h (PTY_ITERATION): Likewise.
7896 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7897
57048744
PE
7898 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7899 * process.c (allocate_pty): Don't declare stb unless it's needed.
7900
7914961c 7901 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7902 (CONSTANTLIM): Remove; unused.
7903 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7904 Define only if needed.
7914961c 7905
b3967b18
PE
7906 * unexelf.c (unexec): Name an expression,
7907 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7908 Use a different way to cause a compilation error if anyone uses
7909 n rather than nn, a way that does not involve shadowing.
73366a00 7910 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7911
29a6015a
PE
7912 * deps.mk (unexalpha.o): Remove; unused.
7913
43cfc33e 7914 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7915 * unexec.h: New file.
ce701a33
PE
7916 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7917 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7918 Depend on unexec.h.
7919 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7920 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7921 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7922 Change as necessary to match prototype in unexec.h.
ce701a33 7923
01f44d5a
PE
7924 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7925 shadowing.
4f63c6bb 7926 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7927
a6670b0b
PE
7928 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7929 Rename locals to avoid shadowing.
7930
cef2010d 7931 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7932 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7933
d4d7173a
PE
7934 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7935
f08b802a
PE
7936 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7937 warning when compiling print.c.
7938
3ddb0639
PE
7939 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7940 instead of using an uninitialized var.
5ad03b97 7941 (font_sort_entities): Mark var as initialized.
3ddb0639 7942
170a2692
PE
7943 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7944
e663c700
PE
7945 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7946 pointers to constants.
89bc529a 7947 (font_parse_fcname): Remove unused vars.
7b81e2d0 7948 (font_delete_unmatched): Now static.
ea838e10 7949 (font_get_spec): Remove; unused.
13a547c6
PE
7950 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7951 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7952 Rename or move locals to avoid shadowing.
e663c700 7953
2a80c887 7954 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7955 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7956
1384fa33 7957 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7958 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7959
8b2c52e9
PE
7960 * alloc.c (mark_backtrace): Move decl from here ...
7961 * lisp.h: ... to here, so that it can be checked.
7962
475545b5 7963 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7964 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7965 (lisp_indirect_variable): Name an expression,
7966 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7967 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7968
b1349114 7969 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7970 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7971 Use const pointer when appropriate.
b1349114 7972
a2928364
PE
7973 * lisp.h (get_system_name, get_operating_system_release):
7974 Move decls here, to check interfaces.
7975 * process.c (get_operating_system_release): Move decl to lisp.h.
7976 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7977 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7978 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7979 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7980 (Fformat_time_string, Fencode_time, Finsert_char):
7981 (Ftranslate_region_internal, Fformat):
7982 Rename or remove local vars to avoid shadowing.
9710023e 7983 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7984
a415e694
PE
7985 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7986 avoid shadowing.
7987
8ef4622d
PE
7988 * lisp.h (eassert): Check that the argument compiles, even if
7989 ENABLE_CHECKING is not defined.
7990
946f9a5b
PE
7991 * data.c (Findirect_variable): Name an expression, to avoid
7992 gcc -Wbad-function-cast warning.
112396d6 7993 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7994 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7995 (Fmake_variable_buffer_local, Fmake_local_variable):
7996 Mark variables as initialized.
52746918 7997 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7998
e5aab7e7 7999 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8000 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8001 Rename locals to avoid shadowing.
dff45157
PE
8002 (mark_stack): Move local variables into the #ifdef region where
8003 they're used.
7bc26fdb
PE
8004 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8005 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8006 needed otherwise.
8007 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8008 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8009 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8010
e5aab7e7
PE
8011 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8012 avoids undefined behavior in theory.
8013
4da60324
PE
8014 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8015
88043301
PE
8016 Use functions, not macros, for up- and down-casing (Bug#8254).
8017 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8018 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8019 to use the following functions instead of these macros.
8020 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8021 EMACS_INT, since callers assume the returned value fits in int.
8022 (upcase1): Likewise, for UPCASE_TABLE.
8023 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8024 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8025 the race-condition problem in the old DOWNCASE.
88043301 8026
19ed5445
PE
8027 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8028 Rename locals to avoid shadowing.
8029 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8030 (regex_compile, re_search_2, re_match_2_internal):
8031 Remove unused local vars.
952db0d7
PE
8032 (FREE_VAR): Rewrite so as not to use empty "else",
8033 which gcc can warn about.
da053e48 8034 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8035 (RETALLOC_IF): Define only if needed.
8036 (WORDCHAR_P): Likewise. This one is never needed, but is used
8037 only in a comment talking about a compiler bug, so put inside
8038 the #if 0 of that comment.
8039 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8040 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8041 Remove; unused.
19ed5445 8042
1f3561e4 8043 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8044 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8045 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8046
ded6f8f7
PE
8047 * search.c (simple_search): Remove unused var.
8048
dbd37a95
PE
8049 * dired.c (compile_pattern): Move decl from here ...
8050 * lisp.h: ... to here, so that it can be checked.
8051 (struct re_registers): New forward decl.
8052
7e47afad
PE
8053 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8054
85f24f61
PE
8055 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8056 All uses changed.
8057 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8058 Rename locals to avoid shadowing.
5671df8f 8059 (Fvertical_motion): Mark locals as initialized.
85f24f61 8060
181aa2be 8061 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8062 (casify_region): Mark local as initialized.
181aa2be 8063
930d429c
PE
8064 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8065
7082eac6
PE
8066 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8067 New macros, so that the caller can use some names other than
8068 gcpro1, gcpro2, etc.
8069 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8070 of the new macros.
8071 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8072 argument, for consistency with GCPRO2_VAR, etc: it is now the
8073 prefix of the variable, not the variable itself. All uses
8074 changed.
38b2c076
PE
8075 * dired.c (directory_files_internal, file_name_completion):
8076 Rename locals to avoid shadowing.
8077
15206ed9
PE
8078 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8079 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8080 dired.c's scmp function, had undefined behavior.
8081 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8082 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8083 * buffer.h: ... to here, because these macros use current_buffer,
8084 and the new implementation with inline functions needs to have
8085 current_buffer in scope now, rather than later when the macros
8086 are used.
8087 (downcase, upcase1): New static inline functions.
8088 (DOWNCASE, UPCASE1): Reimplement using these functions.
8089 This avoids undefined behavior in expressions like
8090 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8091 from race conditions in accessing the global variables
8092 case_temp1 and case_temp2.
8093 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8094 * lisp.h (case_temp1, case_temp2): Remove their decls.
8095 * character.h (ASCII_CHAR_P): Move from here ...
8096 * lisp.h: ... to here, so that the inline functions mentioned
8097 above can use them.
8098
4a6bea26
PE
8099 * dired.c (directory_files_internal_unwind): Now static.
8100
f14b7e14
PE
8101 * fileio.c (file_name_as_directory, directory_file_name):
8102 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8103 Now static.
2893f146
PE
8104 (file_name_as_directory): Use const pointers when appropriate.
8105 (Fexpand_file_name): Likewise. In particular, newdir might
8106 point at constant storage, so make it a const pointer.
fd4ead52 8107 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8108 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8109 signedness issues.
f839df0c
PE
8110 (Fset_file_times, Finsert_file_contents, auto_save_error):
8111 Rename locals to avoid shadowing.
f14b7e14 8112
5716756e 8113 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8114 (Ftry_completion, Fall_completions): Rename or remove locals
8115 to avoid shadowing.
5716756e 8116
b4c3046a
PE
8117 * marker.c (bytepos_to_charpos): Remove; unused.
8118
b45db522
PE
8119 * lisp.h (verify_bytepos, count_markers): New decls,
8120 so that gcc does not warn that these functions aren't declared.
8121
85876d07
PE
8122 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8123 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8124 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8125 (copy_text): Remove unused local var.
85876d07 8126
03d78a21 8127 * filelock.c (within_one_second): Now static.
b3dd38ab 8128 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8129
5df8f01b
PE
8130 * buffer.c (fix_overlays_before): Mark locals as initialized.
8131 (fix_start_end_in_overlays): Likewise. This function should be
8132 simplified by using pointers-to-pointers, but that's a different
8133 matter.
b1d876f1 8134 (switch_to_buffer_1): Now static.
8f54f30a
PE
8135 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8136 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8137
a70072c9 8138 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8139 Fix pointer signedness issue.
edced198
PE
8140 (sys_subshell): Mark local as volatile if checking for lint,
8141 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8142 (MAXPATHLEN): Define only if needed.
a70072c9 8143
a0977c44
PE
8144 * process.c (serial_open, serial_configure): Move decls from here ...
8145 * systty.h: ... to here, so that they can be checked.
8146
a884fdcc
PE
8147 * fns.c (get_random, seed_random): Move extern decls from here ...
8148 * lisp.h: ... to here, so that they can be checked.
8149
604efe86 8150 * sysdep.c (reset_io): Now static.
b8950c94 8151 (wait_for_termination_signal): Remove; unused.
604efe86 8152
38fc62d9
PE
8153 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8154 (copy_keymap_item, append_key, push_text_char_description):
8155 Now static.
1004a21a 8156 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8157 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8158 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8159 (describe_map_tree):
8160 Rename locals to avoid shadowing.
38fc62d9 8161
2f2650da
PE
8162 * keyboard.c: Declare functions static if they are not used elsewhere.
8163 (echo_char, echo_dash, cmd_error, top_level_2):
8164 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8165 (read_char, kbd_buffer_get_event, make_lispy_position):
8166 (make_lispy_event, make_lispy_movement, apply_modifiers):
8167 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8168 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8169 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8170 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8171 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8172
a053e86c 8173 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8174 (mark_kboards): Move decl here ...
8175 * alloc.c (mark_kboards): ... from here.
a053e86c 8176
4752793e
PE
8177 * lisp.h (force_auto_save_soon): New decl.
8178
74f10ca7 8179 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8180 (DEFINE_DUMMY_FUNCTION): New macro.
8181 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8182 Use it.
c03cd23f
PE
8183 (main): Add casts to avoid warnings
8184 if GCC considers string literals to be constants.
74f10ca7 8185
022e70d4
PE
8186 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8187
59d6fe83
PE
8188 * dbusbind.c: Pointer signedness fixes.
8189 (xd_signature, xd_append_arg, xd_initialize):
8190 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8191 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8192 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8193 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8194
78320123
PE
8195 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8196 if GCC considers string literals to be constants.
49cebcca 8197 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8198
35ac2a97
SM
81992011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8200
fb103ca9
SM
8201 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8202 (print_preprocess, print_object): New macro to fix last change.
8203
35ac2a97
SM
8204 * print.c (print_preprocess): Don't forget font objects.
8205
62973b41
JB
82062011-03-16 Juanma Barranquero <lekktu@gmail.com>
8207
8208 * emacs.c (USAGE3): Doc fixes.
8209
0e48bb22
AS
82102011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8211
8212 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8213 structure.
8214
7684e57b
JB
82152011-03-14 Juanma Barranquero <lekktu@gmail.com>
8216
8217 * lisp.h (VWindow_system, Qfile_name_history):
8218 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8219 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8220 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8221
8222 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8223 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8224
8225 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8226 * w32console.c (detect_input_pending, read_input_pending)
8227 (encode_terminal_code):
8228 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8229 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8230 (w32_system_caret_y, Qfile_name_history):
8231 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8232 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8233 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8234 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8235 * w32proc.c (Qlocal, report_file_error):
8236 * w32term.c (Vwindow_system, updating_frame):
8237 * w32uniscribe.c (initialized, uniscribe_font_driver):
8238 Remove unneeded extern declarations.
8239
2aa46d6c
CY
82402011-03-14 Chong Yidong <cyd@stupidchicken.com>
8241
c96bbc66 8242 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8243
cffc6f3b
CY
82442011-03-13 Chong Yidong <cyd@stupidchicken.com>
8245
8246 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8247 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8248 These macros can no longer be used for assignment.
8249
44f230aa
SM
8250 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8251 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8252 (record_buffer_markers, fetch_buffer_markers): New functions for
8253 recording and fetching special buffer markers.
8254 (set_buffer_internal_1, set_buffer_temp): Use them.
8255
8256 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8257
8258 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8259
8260 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8261 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8262
8263 * xdisp.c (hscroll_window_tree):
8264 (reconsider_clip_changes): Use PT instead of BUF_PT.
8265
d251f04b
EZ
82662011-03-13 Eli Zaretskii <eliz@gnu.org>
8267
8268 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8269 $(EMACS_ROOT)/lib/intprops.h.
8270
f0c77cd1
PE
82712011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8272
3eca4629
PE
8273 Fix more problems found by GCC 4.5.2's static checks.
8274
7c86ee98
PE
8275 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8276 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8277 (xg_free_frame_widgets): Make it clear that a local variable is
8278 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8279 (gdk_window_get_screen): Make it clear that this macro is needed
8280 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8281 (int_gtk_range_get_value): New function, which avoids a diagnostic
8282 from gcc -Wbad-function-cast.
8283 (xg_set_toolkit_scroll_bar_thumb): Use it.
8284 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8285 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8286 (get_utf8_string, xg_get_file_with_chooser):
8287 Rename locals to avoid shadowing.
8288 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8289
41729b81
PE
8290 * xgselect.c (xg_select): Remove unused var.
8291
f0c77cd1
PE
8292 * image.c (four_corners_best): Mark locals as initialized.
8293 (gif_load): Initialize transparent_p to zero (Bug#8238).
8294 Mark another local as initialized.
ec6cf4c6 8295 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8296
ce0ad53d 8297 * image.c (clear_image_cache): Now static.
d5d5a617 8298 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8299 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8300 (x_edge_detection): Remove unnecessary cast that
8301 gcc -Wbad-function-cast diagnoses.
2037898d 8302 (gif_load): Fix pointer signedness.
6ae141d6
PE
8303 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8304 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8305
33383987 83062011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8307
d32df629
PE
8308 Improve quality of tests for time stamp overflow.
8309 For example, without this patch (encode-time 0 0 0 1 1
8310 1152921504606846976) returns the obviously-bogus value (-948597
8311 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8312 reports time overflow. See
8313 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8314 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8315 * editfns.c: Include limits.h and intprops.h.
8316 (TIME_T_MIN, TIME_T_MAX): New macros.
8317 (time_overflow): Move earlier, to before first use.
8318 (hi_time, lo_time): New functions, for an accurate test for
8319 out-of-range times.
8320 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8321 (Fget_internal_run_time): Don't assume time_t fits in int.
8322 (make_time): Use list2 instead of Fcons twice.
8323 (Fdecode_time): More accurate test for out-of-range times.
8324 (check_tm_member): New function.
8325 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8326 (lisp_time_argument): Don't rely on undefined left-shift and
8327 right-shift behavior when checking for time stamp overflow.
8be6f318 8328
fe31d94c
PE
8329 * editfns.c (time_overflow): New function, refactoring common code.
8330 (Fformat_time_string, Fdecode_time, Fencode_time):
8331 (Fcurrent_time_string): Use it.
8332
8be6f318
PE
8333 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8334 * dired.c (make_time): Move to ...
8335 * editfns.c (make_time): ... here.
8336 * systime.h: Note the move.
8337
09d9db2c 83382011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8339
126bc0dc
YM
8340 * fringe.c (update_window_fringes): Remove unused variables.
8341
c47cbdfd
YM
8342 * unexmacosx.c (copy_data_segment): Also copy __got section.
8343 (Bug#8223)
8344
7ac80be9
EZ
83452011-03-12 Eli Zaretskii <eliz@gnu.org>
8346
c96bbc66 8347 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8348 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8349 Constify `char *' arguments and their references according to
8350 prototypes in tparam.h.
8351
ecb0f94d 8352 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8353
7ac80be9
EZ
8354 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8355 Adapt all references accordingly.
8356
8357 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8358
ef1fd07e
TT
83592011-03-11 Tom Tromey <tromey@redhat.com>
8360
8361 * buffer.c (syms_of_buffer): Remove obsolete comment.
8362
7ef4b50c
EZ
83632011-03-11 Eli Zaretskii <eliz@gnu.org>
8364
8365 * termhooks.h (encode_terminal_code): Declare prototype.
8366
8367 * msdos.c (encode_terminal_code): Don't declare prototype.
8368
8369 * term.c (encode_terminal_code): Now external again, used by
8370 w32console.c and msdos.c.
8371
44f230aa
SM
8372 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8373 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8374
4b1ec863 83752011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8376
1714f52b 8377 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8378
4b1ec863
PE
8379 * fringe.c (update_window_fringes): Mark locals as initialized
8380 (Bug#8227).
8381 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8382
524c7aa6
PE
8383 * alloc.c (mark_fringe_data): Move decl from here ...
8384 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8385 to check its interface.
8386 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8387
a5c0af81 8388 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8389 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8390 (fontset_font): Mark local as initialized.
a9a06e0b 8391 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8392
b4716021
PE
8393 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8394
811e9bac 8395 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8396 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8397 (x_own_selection, Fx_disown_selection_internal): Rename locals
8398 to avoid shadowing.
8399 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8400
7e3ab302
PE
8401 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8402 so that the caller can use some name other than gcpro1.
8403 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8404 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8405 (Fx_backspace_delete_keys_p):
8406 Use them to avoid shadowing, and rename vars to avoid shadowing.
8407 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8408 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8409 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8410 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8411 Remove unused locals.
7e3ab302
PE
8412 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8413 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8414 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8415 macros.
f78faa98 8416
e2b13473
PE
8417 * xterm.h (x_mouse_leave): New decl.
8418
77f23912
PE
8419 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8420 Remove unused functions.
cdf4ba58
PE
8421 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8422 (x_calc_absolute_position): Now static.
7411c686 8423 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8424 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8425 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8426 unless they are used.
38d0b34a
PE
8427 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8428 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8429 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8430 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8431 (x_error_catcher, x_connection_closed, x_error_handler):
8432 (x_error_quitter, xembed_send_message, x_iconify_frame):
8433 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8434 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8435 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8436
44f230aa
SM
8437 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8438 Rename or move locals to avoid shadowing.
6b463e58 8439 (tty_defined_color, merge_face_heights): Now static.
5967d051 8440 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8441 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8442 does not deduce is never used uninitialized.
73719eba
PE
8443 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8444 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8445
426994c3 8446 * terminal.c (store_terminal_param): Now static.
5489860b 8447
032f1620 8448 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8449 (set_frame_menubar): Remove unused local.
d4323972 8450 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8451 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8452 since they might point to immutable storage.
281585b0
PE
8453 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8454 since it's unused otherwise.
032f1620 8455
367c19e5 8456 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8457 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8458 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8459 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8460 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8461 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8462 does not deduce are never used uninitialized.
70739cbe 8463
07b48fa9
PE
8464 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8465
8868a238 8466 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8467 * window.c (window_loop, size_window):
8468 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8469
7e5cf297 8470 * window.c (display_buffer): Now static.
d6550a9f
PE
8471 (size_window): Mark variables that gcc -Wuninitialized
8472 does not deduce are never used uninitialized.
a586633d
PE
8473 * window.h (check_all_windows): New decl, to forestall
8474 gcc -Wmissing-prototypes diagnostic.
5b555da1 8475 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8476
f6095868
PE
8477 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8478 shadowing.
8479 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8480 Include <limits.h>.
8481 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8482 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8483 (load_charset_map): Mark variables that gcc -Wuninitialized
8484 does not deduce are never used uninitialized.
53df7c11 8485 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8486
f38b440c
PE
8487 * coding.c (coding_set_source, coding_set_destination):
8488 Use "else { /* comment */ }" rather than "else /* comment */;"
8489 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8490 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8491 a block, when the outer 'i' will do.
8492 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8493 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8494 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8495 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8496 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8497 Rename locals to avoid shadowing.
8498 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8499 * coding.c (emacs_mule_char, encode_invocation_designation):
8500 Now static, since they're not used elsewhere.
413bb2db 8501 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8502 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8503 (decode_coding_emacs_mule): Mark variables that gcc
8504 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8505 (detect_coding_iso_2022): Initialize a local variable that might
8506 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8507 this initialization is needed. (Bug#8211)
5f58e762
PE
8508 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8509 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8510 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8511 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8512 Remove unused macros.
f38b440c 8513
232b38b9 8514 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8515 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8516 * character.c (string_count_byte8): Likewise.
232b38b9 8517
fb90da1b
PE
8518 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8519 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8520
fb93dbc2
PE
8521 * chartab.c (copy_sub_char_table): Now static, since it's not used
8522 elsewhere.
5c156ace
PE
8523 (sub_char_table_ref_and_range, char_table_ref_and_range):
8524 Rename locals to avoid shadowing.
bbcd0949 8525 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8526
7d3b3862 8527 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8528 (BIDI_BOB): Remove unused macro.
7d3b3862 8529
6be7d3da
PE
8530 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8531 deduce are never used uninitialized.
c2ed9c8b 8532 * term.c (encode_terminal_code): Likewise.
6be7d3da 8533
75f8807f 8534 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8535
50938595
PE
8536 * tparam.h: New file.
8537 * term.c, tparam.h: Include it.
8538 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8539 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8540 Move these decls to tparam.h, and make them agree with what
8541 is actually in tparam.c. The previous trick of using incompatible
8542 decls in different modules does not conform to the C standard.
8543 All callers of tparam changed to use tparam's actual API.
8544 * tparam.c (tparam1, tparam, tgoto):
8545 Use const pointers where appropriate.
8546
fbceeba2
PE
8547 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8548 * cm.h (struct cm): Likewise.
8549 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8550 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8551 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8552 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8553 (turn_on_face, init_tty): Likewise.
8554 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8555
7f3f1250
PE
8556 * term.c (term_mouse_position): Rename local to avoid shadowing.
8557
e6ca6543
PE
8558 * alloc.c (mark_ttys): Move decl from here ...
8559 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8560
c40f8d15
AS
85612011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8562
8563 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8564
cfe0661d
JB
85652011-03-09 Juanma Barranquero <lekktu@gmail.com>
8566
8567 * search.c (compile_pattern_1): Remove argument regp, unused since
8568 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8569 (compile_pattern): Don't pass it.
8570
0afb4571
J
85712011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8572
8573 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8574 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8575 for ! HAVE_GTK3.
8576 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8577
8578 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8579
8580 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8581 gdk_window_get_screen, gdk_window_get_geometry,
8582 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8583 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8584 (xg_get_pixbuf_from_pixmap): New function.
8585 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8586 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8587 Call xg_get_pixbuf_from_pixmap instead of
8588 gdk_pixbuf_get_from_drawable.
8589 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8590 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8591 (xg_check_special_colors): Use GtkStyleContext and its functions
8592 for HAVE_GTK3.
8593 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8594 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8595 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8596 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8597 Call gtk_widget_get_preferred_size.
0afb4571
J
8598 (xg_frame_resized): gdk_window_get_geometry only takes 5
8599 parameters.
44f230aa
SM
8600 (xg_win_to_widget, xg_event_is_for_menubar):
8601 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8602 (xg_set_widget_bg): New function.
8603 (delete_cb): New function.
895009e1 8604 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8605 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8606 (xg_set_background_color): Call xg_set_widget_bg.
8607 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8608 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8609 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8610 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8611 if ! HAVE_GTK3.
8612 (update_frame_tool_bar): Call gtk_widget_hide.
8613 (xg_initialize): Use GDK_KEY_g.
8614
8615 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8616 if ! HAVE_GTK3
8617 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8618
8619 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8620 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8621 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8622
1c2cc4ef
JB
86232011-03-08 Juanma Barranquero <lekktu@gmail.com>
8624
8625 * w32xfns.c (select_palette): Check success of RealizePalette against
8626 GDI_ERROR, not zero.
8627
33383987 8628See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8629
8630;; Local Variables:
8631;; coding: utf-8
aac0c6e3
MR
8632;; End:
8633
33383987 8634 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8635
8636 This file is part of GNU Emacs.
8637
8638 GNU Emacs is free software: you can redistribute it and/or modify
8639 it under the terms of the GNU General Public License as published by
8640 the Free Software Foundation, either version 3 of the License, or
8641 (at your option) any later version.
8642
8643 GNU Emacs is distributed in the hope that it will be useful,
8644 but WITHOUT ANY WARRANTY; without even the implied warranty of
8645 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8646 GNU General Public License for more details.
8647
8648 You should have received a copy of the GNU General Public License
8649 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.