* nsfns.m (get_geometry_from_preferences): New function.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a0c3fad0
JD
12011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsfns.m (get_geometry_from_preferences): New function.
4 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5
6c07aac2
AS
62011-12-04 Andreas Schwab <schwab@linux-m68k.org>
7
8 * emacs.c (Qkill_emacs): Define.
9 (syms_of_emacs): Initialize it.
10 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
11 Qquit_flag to `kill-emacs' instead.
12 (quit_throw_to_read_char): Add parameter `from_signal'. All
13 callers changed. Call Fkill_emacs if requested and safe.
14 * lisp.h (QUIT): Call Fkill_emacs if requested.
15
c052ead4
JD
162011-12-03 Jan Djärv <jan.h.d@swipnet.se>
17
18 * widget.c (update_wm_hints): Return if wmshell is null.
19 (widget_update_wm_size_hints): New function.
20
21 * widget.h (widget_update_wm_size_hints): Declare.
22
23 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
24 widget_update_wm_size_hints (Bug#10104).
25
9e49252b
EZ
262011-12-03 Eli Zaretskii <eliz@gnu.org>
27
28 * xdisp.c (handle_invisible_prop): If the invisible text ends just
29 before a newline, prepare the bidi iterator for consuming the
30 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 31 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 32
02b16839
JL
332011-12-02 Juri Linkov <juri@jurta.org>
34
35 * search.c (Fword_search_regexp): New Lisp function created from
36 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
37 (Fword_search_backward, Fword_search_forward)
38 (Fword_search_backward_lax, Fword_search_forward_lax):
39 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
40 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
41
0068070e
SM
422011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
43
44 * fileio.c (Finsert_file_contents): Move after-change-function call
45 to before the "handled:" label, since all "goto handled" appear in
46 cases where the *-change-functions have already been properly called
47 (bug#10117).
48
3360a3fc
AS
492011-12-01 Andreas Schwab <schwab@linux-m68k.org>
50
51 * keyboard.c (interrupt_signal): Don't call kill-emacs when
52 waiting for input. (Bug#10169)
53
73d6c093
EZ
542011-11-30 Eli Zaretskii <eliz@gnu.org>
55
56 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
57 verifies glyph row's hash code--we have just reallocated the
58 glyphs, so their contents can be complete garbage. (Bug#10164)
59
febe6bea
JB
602011-11-30 Juanma Barranquero <lekktu@gmail.com>
61
62 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
63
801a4313
EZ
642011-11-30 Eli Zaretskii <eliz@gnu.org>
65
66 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
67 attributes are tested _before_ calling verify_row_hash, to protect
68 against GCC re-ordering of the tests. (Bug#10164)
69
2b56b87e
JD
702011-11-29 Jan Djärv <jan.h.d@swipnet.se>
71
72 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
73
74 * xterm.c (handle_one_xevent): Only set async_visible and friends
75 if net_wm_state_hidden_seen is non-zero (Bug#10002)
76 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
77 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
78
dbf31225
PE
792011-11-28 Paul Eggert <eggert@cs.ucla.edu>
80
81 Remove GCPRO-related macros that exist only to avoid shadowing locals.
82 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
83 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
84 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
85 All uses changed to use GCPRO1 etc.
86 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
87 Revert to old implementation (i.e., before 2011-03-11).
88
1305621b
YM
892011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
90
91 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
92 of scroll runs so as to avoid assigning disabled bogus rows and
93 unnecessary graphics copy operations.
94
8c9afb46
EZ
952011-11-27 Eli Zaretskii <eliz@gnu.org>
96
97 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
98 (snprintf) [_MSC_VER]: Redirect to _snprintf.
99 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
100 (malloc, free, realloc, calloc): Redirect to e_* only when
101 compiling Emacs.
102
103 * lisp.h (GCTYPEBITS): Move before first use.
104 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
105 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
106 this macro definition.
107
108 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
109 _MSC_VER.
110
54e9e3bf
JD
1112011-11-27 Jan Djärv <jan.h.d@swipnet.se>
112
113 * gtkutil.c (xg_create_frame_widgets): Call
114 gtk_window_set_has_resize_grip (FALSE) if that function is
115 present with Gtk+ 2.0.
116
83aca1cb
PE
1172011-11-26 Paul Eggert <eggert@cs.ucla.edu>
118
119 * fileio.c (Finsert_file_contents): Undo previous change; see
120 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
121
5b76caa4
PE
1222011-11-26 Paul Eggert <eggert@cs.ucla.edu>
123
124 Rename locals to avoid shadowing.
125 * fileio.c (Finsert_file_contents):
126 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
127 * process.c (wait_reading_process_output):
128 Rename inner 'proc' to 'p' to avoid shadowing.
129 Indent for consistency with usual Emacs style.
130
8c535114
EZ
1312011-11-25 Eli Zaretskii <eliz@gnu.org>
132
133 * xdisp.c (redisplay_window): If cursor row is not fully visible
134 after recentering, and scroll-conservatively is set to a large
135 number, scroll window by a few more lines to make the cursor fully
136 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
137 (start_display): Don't move to the next line if the display should
138 start at a newline that is part of a display vector or an overlay
139 string. (Bug#10119)
8c535114 140
fa4fdb5c
JL
1412011-11-24 Juri Linkov <juri@jurta.org>
142
143 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
144 after the `MagickPingImage' call. (Bug#10112)
145
90ec88df
CY
1462011-11-23 Chong Yidong <cyd@gnu.org>
147
148 * window.c (Fcoordinates_in_window_p): Accept only live windows.
149
56e2e794
MR
1502011-11-23 Martin Rudalics <rudalics@gmx.at>
151
152 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
153 making another buffer current. (Bug#10114)
154
b6e64c41
GM
1552011-11-23 Glenn Morris <rgm@gnu.org>
156
157 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
158
6b21de18
CY
1592011-11-23 Chong Yidong <cyd@gnu.org>
160
161 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
162 using it (Bug#5984).
163
b12cd789
EZ
1642011-11-22 Eli Zaretskii <eliz@gnu.org>
165
166 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
167 and header-lines, as they don't have one computed for them.
168 (Bug#10098)
169
170 * .gdbinit (prow): Make displayed values more self-explaining.
171 Add row's hash code.
172
261b6fd4
LMI
1732011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
174
175 * process.c (wait_reading_process_output): Fix asynchrounous
176 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 177 (wait_reading_process_output): Add comment and URL.
261b6fd4 178
e7cfd277
JD
1792011-11-21 Jan Djärv <jan.h.d@swipnet.se>
180
181 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
182
a9b9b7f5
CY
1832011-11-21 Chong Yidong <cyd@gnu.org>
184
185 * window.c (Fnext_window, Fprevious_window): Doc fix.
186
b0d15b4f
SM
1872011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
188
189 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
190
fe7a3057
JB
1912011-11-20 Juanma Barranquero <lekktu@gmail.com>
192
193 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
194
d2999b1a
MR
1952011-11-20 Martin Rudalics <rudalics@gmx.at>
196
197 * window.c (Fset_window_combination_limit): Rename argument
198 STATUS to LIMIT.
199 (Vwindow_combination_limit): Remove "status" from doc-string.
200
d5ff9cd0
AS
2012011-11-20 Andreas Schwab <schwab@linux-m68k.org>
202
203 * m/ibms390.h: Remove.
204 * m/ibms390x.h: Don't include "ibms390.h".
205
a5bb9bd3
SM
2062011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
207
208 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
209 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
210
cd1181db
JB
2112011-11-20 Juanma Barranquero <lekktu@gmail.com>
212
213 * casetab.c (Fset_case_table):
214 * charset.c (Fcharset_after): Fix typos.
215
615a3b8d 2162011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 217
17e845af
PE
218 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
219 Otherwise, valgrind does not work on some platforms.
220 Problem reported by Andreas Schwab in
6a0bf43d
PE
221 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
222 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
223 is set, removing the need for VIRT_ADDRESS_VARIES.
224 (PURE_P): Use a more-efficient implementation that needs just one
225 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
226 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
227 to 4 (xorl, subq, cmpq, setbe).
228 * alloc.c (pure): Always extern now, since that's the
229 VIRT_ADDR_VARIES behavior.
230 (PURE_POINTER_P): Use a single comparison, not two, for
231 consistency with the new puresize.h.
232 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
233 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
234 Remove VIRT_ADDR_VARIES no longer needed.
235
f8fe6f96
EZ
2362011-11-19 Eli Zaretskii <eliz@gnu.org>
237
238 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
239 (erase_phys_cursor, update_window_cursor, show_mouse_face)
240 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
241 behave as if the cursor position were at the window margin.
242
243 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
244 and the cursor position is out of bounds, behave as if the cursor
245 position were at the window margin. (Bug#10075)
246
df05a53c
CY
2472011-11-18 Chong Yidong <cyd@gnu.org>
248
249 * window.c (Fwindow_combination_limit): Make first argument
250 non-optional, since it is meaningless for live windows like the
251 selected window.
252
2071918e
DA
2532011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
254
255 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
256
b50a28de
SM
2572011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
258
259 * intervals.c: Fix grafting over the whole buffer (bug#10071).
260 (graft_intervals_into_buffer): Simplify.
261
015137db
EZ
2622011-11-18 Eli Zaretskii <eliz@gnu.org>
263
264 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
265 hash values of the two rows.
266 (copy_row_except_pointers): Preserve the used[] arrays and the
267 hash values of the two rows. (Bug#10035)
68c95424 268 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
269
270 * xdisp.c (row_hash): New function, body extracted from
271 compute_line_metrics.
272 (compute_line_metrics): Call row_hash, instead of computing the
273 hash code inline.
274
275 * dispnew.c (verify_row_hash): Call row_hash for computing the
276 hash code of a row, instead of duplicating code from xdisp.c.
277
278 * dispextern.h (row_hash): Add prototype.
279
a2addb04
TH
2802011-11-18 Tassilo Horn <tassilo@member.fsf.org>
281
282 * frame.c (delete_frame): Don't delete the terminal when the last
283 X frame is closed if emacs is built with GTK toolkit.
284
df85d315
JB
2852011-11-17 Juanma Barranquero <lekktu@gmail.com>
286
287 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
288
a0c2d0ae
MR
2892011-11-17 Martin Rudalics <rudalics@gmx.at>
290
291 * window.c (Vwindow_splits): Rename to
292 Vwindow_combination_resize. Suggested by Juri Linkov.
293 (Fsplit_window_internal): Use Vwindow_combination_resize instead
294 of Vwindow_splits.
295
58179cce
JB
2962011-11-16 Juanma Barranquero <lekktu@gmail.com>
297
7877f373
JB
298 * nsfns.m (Fns_font_name):
299 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 300
b6f67890
MR
3012011-11-16 Martin Rudalics <rudalics@gmx.at>
302
303 * window.h (window): Rename slot "nest" to "combination_limit".
304 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
305 (Fset_window_nest): Rename to Fset_window_combination_limit.
306 (Vwindow_nest): Rename to Vwindow_combination_limit.
307 (recombine_windows, make_parent_window, make_window)
308 (Fsplit_window_internal, saved_window)
309 (Fset_window_configuration, save_window_save): Rename all
310 occurrences of window_nest to window_combination_limit.
311
c7015153
JB
3122011-11-15 Juanma Barranquero <lekktu@gmail.com>
313
314 * image.c (imagemagick_load_image): Fix typo.
315
322ad6ec
EZ
3162011-11-14 Eli Zaretskii <eliz@gnu.org>
317
318 * xdisp.c (display_line): Move the call to
319 highlight_trailing_whitespace before the call to
320 compute_line_metrics, since the latter needs to see the final
321 faces of all the glyphs to compute ROW's hash value. Fixes
322 assertion violations in row_equal_p. (Bug#10035)
323
f067b8ec
JB
3242011-11-14 Juanma Barranquero <lekktu@gmail.com>
325
326 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
327 just return (bug#10044).
328
1e5b2111
EZ
3292011-11-12 Eli Zaretskii <eliz@gnu.org>
330
7ef3cbd5
EZ
331 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
332 with user-defined heap size. Bump the default size of the temacs
333 heap to 27MB, to avoid memory warning when running temacs.
334 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
335
1e5b2111
EZ
336 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
337 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
338 (verify_row_hash) [XASSERTS]: New function.
339 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
340 that the hash value of glyph rows is correct.
1e5b2111 341
89d61221
MR
3422011-11-12 Martin Rudalics <rudalics@gmx.at>
343
344 * window.h (window): Remove splits slot.
345 * window.c (Fwindow_splits, Fset_window_splits): Remove.
346 (Fdelete_other_windows_internal, make_parent_window)
347 (make_window, Fsplit_window_internal, Fdelete_window_internal)
348 (Fset_window_configuration, save_window_save): Don't deal with
349 split status of windows.
350 (saved_window): Remove splits slot.
351 (Vwindow_splits): Rewrite doc-string.
352
97f18cc8
JD
3532011-11-11 Jan Djärv <jan.h.d@swipnet.se>
354
355 * xfns.c (unwind_create_frame):
356 * nsfns.m (unwind_create_frame):
357 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
358 Vframe_list (Bug#9999).
359
22a648b4
DA
3602011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
361
0b381c7e 362 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 363
659afede
KH
3642011-11-11 Kenichi Handa <handa@m17n.org>
365
366 * callproc.c (Fcall_process): Set the member dst_multibyte of
367 process_coding.
368
9ac0394b
KH
3692011-11-11 Johan Bockgård <bojohan@gnu.org>
370
371 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
372 avoid a crash (bug#9496).
373
2fbdc249
CY
3742011-11-09 Chong Yidong <cyd@gnu.org>
375
376 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
377 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
378
ac6b1f81
PE
3792011-11-08 Paul Eggert <eggert@cs.ucla.edu>
380
381 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
382
09db192c
PE
3832011-11-08 Paul Eggert <eggert@cs.ucla.edu>
384
385 Avoid some portability problems by eschewing 'extern inline' functions.
386 The trivial performance wins aren't worth the portability hassles; see
387 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
388 et seq.
389 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
390 (window_box_width, window_box_left, window_box_left_offset)
391 (window_box_right, window_box_right_offset): Undo previous change,
392 by removing the "extern"s.
393 * intervals.c (adjust_intervals_for_insertion)
394 (adjust_intervals_for_deletion): Undo previous change,
395 making these static again.
396 (offset_intervals, temp_set_point_both, temp_set_point)
397 (copy_intervals_to_string): No longer inline.
398 * xdisp.c (window_text_bottom_y, window_box_width)
399 (window_box_height, window_box_left_offset)
400 (window_box_right_offset, window_box_left, window_box_right)
401 (window_box): No longer inline.
402
105216ed
CY
4032011-11-08 Chong Yidong <cyd@gnu.org>
404
405 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
406 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
407 an error if not a live window.
408 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
409 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
410
ae9e237f
JB
4112011-11-07 Juanma Barranquero <lekktu@gmail.com>
412
413 * lisp.h (syms_of_abbrev): Remove declaration.
414 Reported by CHENG Gao <chenggao@royau.me>.
415
c7aa8333
EZ
4162011-11-07 Eli Zaretskii <eliz@gnu.org>
417
418 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
419 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
420 of temacs in GUI mode.
421
be7f5545
MR
4222011-11-07 Martin Rudalics <rudalics@gmx.at>
423
424 * window.h: Declare delete_all_child_windows instead of
425 delete_all_subwindows.
426 * window.c (Fwindow_nest, Fset_window_nest)
427 (Fset_window_new_total, Fset_window_new_normal)
428 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
429 (delete_all_subwindows): Rename to delete_all_child_windows.
430 (Fdelete_other_windows_internal, Fset_window_configuration):
431 Call delete_all_child_windows instead of delete_all_subwindows.
432 * frame.c (delete_frame): Call delete_all_child_windows instead
433 of delete_all_subwindows.
434
ca78dc43
PE
4352011-11-07 Paul Eggert <eggert@cs.ucla.edu>
436
437 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
438 This is also needed for porting to any host where GC_MARK_STACK is
439 not GC_MAKE_GCPROS_NOOPS.
440 (which_symbols): Use it.
441
a0241d01
KH
4422011-11-07 Kenichi Handa <handa@m17n.org>
443
444 * coding.c (coding_set_destination): Check coding->src_pos only
445 when coding->src_object is a buffer (bug#9910).
446
447 * process.c (send_process): Set the member src_multibyte of coding
448 to 0 (bug#9911) when sending a unibyte text.
449
450 * callproc.c (Fcall_process): Set the member src_multibyte of
451 process_coding to 0 (bug#9912).
452
a64bfdfa 4532011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
454
455 * xmenu.c (cleanup_widget_value_tree): New function.
456 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
457 calling free_menubar_widget_value_tree directly (Bug#9830).
458
cb41b32a
PE
4592011-11-06 Paul Eggert <eggert@cs.ucla.edu>
460
461 Fix some portability problems with 'inline'.
462 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
463 (window_box_width, window_box_left, window_box_left_offset)
464 (window_box_right, window_box_right_offset): Declare extern.
465 Otherwise, these inline functions do not conform to C99 and
466 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
467 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
468 * intervals.c (adjust_intervals_for_insertion)
469 (adjust_intervals_for_deletion): Now extern, because otherwise the
470 extern inline functions 'offset_intervals' couldn't refer to it.
471 (static_offset_intervals): Remove.
472 (offset_intervals): Rewrite using the old contents of
473 static_offset_intervals. The old version didn't conform to C99
474 because an extern inline function contained a reference to an
475 identifier with static linkage.
476
b7041366
AS
4772011-11-06 Andreas Schwab <schwab@linux-m68k.org>
478
479 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
480 GC.
481
88a37c4d
EZ
4822011-11-06 Eli Zaretskii <eliz@gnu.org>
483
484 * xdisp.c (init_iterator, reseat_to_string): Don't set the
485 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
486 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
487 return Qleft_to_right.
488
49745b39
CY
4892011-11-06 Chong Yidong <cyd@gnu.org>
490
491 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
492 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
493 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
494 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
495 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
496 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
497 (Fwindow_vscroll): Doc fix.
498 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
499 argument, since it makes no sense to pass a live window and for
500 consistency with window-child.
501
1f05cd82
CS
5022011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
503
504 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
505 support MSVC.
506
22610910
JR
5072011-11-05 Jason Rumney <jasonr@gnu.org>
508
509 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
510 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
511 fonts (Bug#6029).
512 (add_font_entity_to_list): Fix logic errors in mixed boolean and
513 bitwise arithmetic preventing use of unicode-sip and non-truetype
514 opentype fonts.
515
a06776b2
EZ
5162011-11-05 Eli Zaretskii <eliz@gnu.org>
517
3ad924ba
EZ
518 * s/ms-w32.h (fstat, stat, utime): Move redirections to
519 "emacs"-only part.
520
a06776b2
EZ
521 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
522 initialization code to keep similarity to xfns.c after changes
523 from 2011-11-05.
524
c9e7db78
JD
5252011-11-05 Jan Djärv <jan.h.d@swipnet.se>
526
a97f8f3f
JD
527 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
528 (unwind_create_frame): New function (Bug#9943).
529 (Fx_create_frame): Restructure code to be more similar to the one in
530 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
531 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
532 Move terminal->reference_count++ just before making the frame official
533 (Bug#9943).
534
535 * nsterm.m (x_free_frame_resources): New function.
536 (x_destroy_window): Move code to x_free_frame_resources.
537
c9e7db78
JD
538 * xfns.c (unwind_create_frame): Fix comment.
539 (Fx_create_frame, x_create_tip_frame): Move
540 terminal->reference_count++ just before making the frame
541 official. Move initialization of image_cache_refcount and
542 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
543
a6fc3b5c
EZ
5442011-11-05 Eli Zaretskii <eliz@gnu.org>
545
546 Support MSVC build with newer versions of Visual Studio.
547 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
548 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
549 nt/gmake.defs.
550
551 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
552 which are not supported by MSVC.
553 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
554 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
555 bitfields.
556 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
557 types in bitfields.
558 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
559
560 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
561
58179cce 5622011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
563
564 Support MSVC build with newer versions of Visual Studio.
565 * w32.c: Don't include w32api.h for MSVC.
566 (init_environment) [_MSC_VER]: Call sys_access, not _access.
567
568 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
569 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
570 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
571 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
572 e_* cousins.
573 (alloca) [_MSC_VER]: Define to _alloca.
574
575 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
576
577 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
578
a58c13ed
EZ
5792011-11-04 Eli Zaretskii <eliz@gnu.org>
580
581 * xdisp.c (note_mouse_highlight): If either of
582 previous/next-single-property-change returns nil, treat that as
583 the beginning or the end of the buffer. (Bug#9955)
584
fe0b6370
JD
5852011-11-04 Jan Djärv <jan.h.d@swipnet.se>
586
a58c13ed 587 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
588 label is not null (Bug#9951).
589 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
590 may be NULL.
591
89bd5ee1
EZ
5922011-11-04 Eli Zaretskii <eliz@gnu.org>
593
594 * window.c (Fwindow_body_size): Mention in the doc string that the
595 return value is in frame's canonical units. (Bug#9949)
596
84c3edb9
EZ
5972011-11-03 Eli Zaretskii <eliz@gnu.org>
598
4e2fb5c7
EZ
599 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
600
84c3edb9 601 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 602 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 603 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 604
bc17a887
EZ
6052011-11-01 Eli Zaretskii <eliz@gnu.org>
606
607 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
608 Don't stop backward scan on the continuation glyph, even though
609 its CHARPOS is positive.
26b46e51
EZ
610 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
611 cover_string to disp_string.
bc17a887 612
4ee88440
MR
6132011-11-01 Martin Rudalics <rudalics@gmx.at>
614
615 * window.c (temp_output_buffer_show): Don't use
616 Vtemp_buffer_show_specifiers.
617 (Vtemp_buffer_show_specifiers): Remove unused variable.
618
c2ff3c02
EZ
6192011-10-30 Eli Zaretskii <eliz@gnu.org>
620
621 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
622 past the beginning of the current glyph matrix.
623
58179cce 6242011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
625
626 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
627 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
628 HAVE_GTK3 (Bug#9869).
b77a6a7f 629
3b574623
JD
630 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
631 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
632
b77a6a7f
JD
633 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
634
635 * xterm.c: Declare x_handle_net_wm_state to return int.
636 (handle_one_xevent): Check if we are iconified but don't have
637 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
638 (get_current_wm_state): Return non-zero if not hidden,
639 check for _NET_WM_STATE_HIDDEN (Bug#9893).
640 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
641 (x_handle_net_wm_state): Return what get_current_wm_state returns.
642 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
643
196e41e4
PE
6442011-10-29 Paul Eggert <eggert@cs.ucla.edu>
645
646 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
647 so that this new function doesn't get optimized away by a
648 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
649
021f2e1a
AS
6502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
651
652 * frame.h (MOUSE_HL_INFO): Remove excess parens.
653
8b058d44
EZ
6542011-10-29 Eli Zaretskii <eliz@gnu.org>
655
656 Fix the `xbytecode' command.
657 * .gdbinit (xprintbytestr): New command.
b50a28de 658 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
659 (xbytecode): Print the byte-code string as well.
660
4452fb80
EZ
6612011-10-29 Kim Storm <storm@cua.dk>
662
8b058d44
EZ
663 * alloc.c (which_symbols): New function.
664
21b72067
AS
6652011-10-29 Andreas Schwab <schwab@linux-m68k.org>
666
667 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
668 line. (Bug#9903)
669
83ed7b5c
GM
6702011-10-29 Glenn Morris <rgm@gnu.org>
671
672 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
673 Not clear what it was for, and it causes various bugs. (Bug#9839)
674
5a7a728b
EZ
6752011-10-28 Eli Zaretskii <eliz@gnu.org>
676
677 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
678 possible random value that matches one of those tested as
679 condition to clear the mouse face.
680
d3d0842f
CY
6812011-10-28 Chong Yidong <cyd@gnu.org>
682
683 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
684
31b39d13
DN
6852011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
686
687 * window.c (make_window): Initialize phys_cursor_on_p.
688
9aba6043
SM
6892011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
690
691 * lisp.h (struct Lisp_Symbol): Update comments.
692
c20992f4
JB
6932011-10-28 Juanma Barranquero <lekktu@gmail.com>
694
695 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
696
db4f02f2
EZ
6972011-10-28 Eli Zaretskii <eliz@gnu.org>
698
699 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
700 <oslsachem@gmail.com> for helping to debug this.
701
702 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
703 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
704 (g_b_init_get_glyph_outline_w): New static variables.
705 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
706 (GetGlyphOutlineW_Proc): New typedefs.
707 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
708 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
709 New functions.
710 (w32font_open_internal, compute_metrics):
711 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
712 instead of calling the "wide" APIs directly.
713
714 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
715
716 * w32.h (syms_of_w32font): Add prototype.
717
87e68db4
JB
7182011-10-27 Juanma Barranquero <lekktu@gmail.com>
719
720 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
721 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
722 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
723 (Fmove_to_window_line): Doc fix.
724
435c1d67
CY
7252011-10-27 Chong Yidong <cyd@gnu.org>
726
727 * process.c (make_process): Set gnutls_state to NULL.
728
729 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
730 non-NULL, regardless of GNUTLS_INITSTAGE.
731 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
732 an error. Set process slots as soon as we allocate them.
733
734 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
735
9c6c6f49
CY
7362011-10-27 Chong Yidong <cyd@gnu.org>
737
9aba6043
SM
738 * gnutls.c (emacs_gnutls_deinit): New function.
739 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
740 (Fgnutls_deinit, Fgnutls_boot): Use it.
741
742 * process.c (make_process): Initialize GnuTLS credentials to NULL.
743 (deactivate_process): Call emacs_gnutls_deinit.
744
657d08d3
JB
7452011-10-27 Juanma Barranquero <lekktu@gmail.com>
746
747 * image.c (x_create_x_image_and_pixmap):
748 * w32.c (sys_rename, w32_delayed_load):
749 * w32font.c (fill_in_logfont):
750 * w32reg.c (x_get_string_resource): Silence compiler warnings.
751
5430d399
JB
7522011-10-26 Juanma Barranquero <lekktu@gmail.com>
753
754 * w32fns.c (w32_default_color_map): New function,
755 extracted from Fw32_default_color_map.
a7ef684b 756 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 757
fe0055fa
PE
7582011-10-25 Paul Eggert <eggert@cs.ucla.edu>
759
760 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
761
e6346438
SM
7622011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
763
764 * keyboard.c (test_undefined): New function (bug#9751).
765 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
766
e112cc37
ET
7672011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
768
769 * sysdep.c (init_sys_modes): Fix the check for the controlling
770 terminal (Bug#6649).
771
7b5d6677
EZ
7722011-10-20 Eli Zaretskii <eliz@gnu.org>
773
774 * dispextern.h (struct bidi_it): New member next_en_type.
775
776 * bidi.c (bidi_line_init): Initialize the next_en_type member.
777 (bidi_resolve_explicit_1): When next_en_pos is valid for the
778 current character, check also for next_en_type being WEAK_EN.
779 (bidi_resolve_weak): Don't enter the expensive loop if the current
780 position is before next_en_pos. Record the bidi type of the first
781 non-ET, non-BN character we find, in addition to its position.
782 (bidi_level_of_next_char): Invalidate next_en_type when
783 next_en_pos is over-stepped.
784
7da0b018
PE
7852011-10-20 Paul Eggert <eggert@cs.ucla.edu>
786
787 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
788 * editfns.c: Rewrite current-time-zone so that it invokes
789 the equivalent of (format-time-string "%Z") to get the time zone name.
790 This fixes a bug when the time zone name contains characters that
791 need converting from the system time locale to Emacs internal format.
792 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
793 that patch fixed format-time-string to do the conversion, but
794 I forgot to fix current-time-zone.
795 (format_time_string): New function, containing most of
796 what Fformat_time_string used to contain.
797 (Fformat_time_string): Rewrite in terms of format_time_string.
798 This doesn't change this function's behavior.
799 (current-time-zone): Rewrite to use format_time_string.
800 This fixes the bug reported by Michael Schierl in
801 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
802 Jason Rumney's 2007-06-07 change worked around this bug, but
803 didn't fix it.
804 * systime.h (tzname, timezone): Remove no-longer-used declarations.
805
8547b010
EZ
8062011-10-19 Eli Zaretskii <eliz@gnu.org>
807
808 * xdisp.c (start_display): If the character at POS is displayed
809 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
810 (try_window_reusing_current_matrix): If a line ends in a display
811 vector or the next line starts in a display vector, continue
812 redrawing the window even though the character position of
813 start_row was reached.
8547b010
EZ
814 (Bug#9771, part 2)
815
4e948d15
CY
8162011-10-18 Chong Yidong <cyd@gnu.org>
817
818 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
819 with nobreak-char-display too.
820
4787455f
EZ
8212011-10-18 Eli Zaretskii <eliz@gnu.org>
822
823 Fix part 3 of bug#9771.
824 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
825 (bidi_resolve_neutral): Don't enter the expensive loop looking for
826 non-neutral characters if the current character is a paragraph
827 separator (a.k.a. Newline). This avoids running the same
828 expensive loop twice, once when we consume the preceding newline
829 and the other time when the line actually needs to be displayed.
830 Avoid the loop when we see neutrals on the base embedding level
831 following a character whose directionality is the same as the
832 paragraph's. This avoids running the expensive loop when a line
833 ends in a long sequence of neutrals, like control characters.
834 Add assertion against STRONG_AL type. Slightly rearrange code
835 that determines the type of a neutral given the first non-neutral
836 that follows it.
837 (bidi_level_of_next_char): Set next_en_pos to zero when
838 invalidating its info.
839
2c91f553
EZ
8402011-10-17 Eli Zaretskii <eliz@gnu.org>
841
842 * xdisp.c (push_display_prop): Determine whether to record string
843 or buffer position by IT->string, not by IT->method. Allow
844 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
845 (move_it_vertically_backward): Don't look for character position
846 immediately after the newline when in a continuation line.
847 (Bug#9771, part 1)
2c91f553 848
c7b08b0d
MR
8492011-10-15 Martin Rudalics <rudalics@gmx.at>
850
851 * window.c (coordinates_in_window): Rewrite and delabelize
852 vertical border check. (Bug#5357) (Bug#9618)
853
6b02f655
SM
8542011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
855
856 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
857 errors in XSetWindowBorder (bug#9310).
858
81d40c92
DA
8592011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
860
861 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
862 avoid crash when xmalloc overrun checking is enabled.
863
d4172c3b
EZ
8642011-10-13 Eli Zaretskii <eliz@gnu.org>
865
866 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
867 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
868 cursor motion with <left> and <right> arrow keys.
869
870 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
871 some callers set that themselves.
872
b00eea75
EZ
8732011-10-12 Eli Zaretskii <eliz@gnu.org>
874
875 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
876 display string and the previous row comes from the same string and
877 is empty. (Bug#9739) (Bug#9738)
878
8fe012c4
SM
8792011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
880
881 * doc.c (get_doc_string): Encode file name (bug#9735).
882
0074aef2
EZ
8832011-10-12 Eli Zaretskii <eliz@gnu.org>
884
79beb178
EZ
885 * bidi.c (bidi_level_of_next_char):
886 * xdisp.c (get_visually_first_element): Remove old incorrect
887 comments regarding the Unicode Line Separator character.
888
0074aef2
EZ
889 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
890
6e4b3fbe
DA
8912011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
892
893 * alloc.c (Fgc_status): Do not access beyond zombies array
894 boundary if nzombies > MAX_ZOMBIES.
895 * alloc.c (dump_zombies): Add missing format specifier.
896
0324f3af
PE
8972011-10-12 Paul Eggert <eggert@cs.ucla.edu>
898
b5525cac
PE
899 * xdisp.c (set_cursor_from_row): Simplify conditionals,
900 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
901
0324f3af
PE
902 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
903 Some packages use them to denote characters with modifiers.
904
e9b5f888
AS
9052011-10-11 Andreas Schwab <schwab@linux-m68k.org>
906
907 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
908 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
909 matching a pp-number. Rename parameter var to var1.
910
127827c0
SM
9112011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
912
913 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
914
c8fd3bd0
GM
9152011-10-08 Glenn Morris <rgm@gnu.org>
916
917 * callint.c (Fcall_interactively): Give a more explicit error for the
918 'c' case with a non-character input. (Bug#8479)
919
352ec8ff
EZ
9202011-10-08 Eli Zaretskii <eliz@gnu.org>
921
03669ccb
EZ
922 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
923 lines.
7061c986
EZ
924 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
925 lines that are hscrolled on the left.
03669ccb 926
352ec8ff
EZ
927 * dispnew.c (buffer_posn_from_coords): Account for a possible
928 presence of header-line. (Bug#4426)
929
a66cfb1c
SM
9302011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
931
6b02f655
SM
932 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
933 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 934
7c5ee88e
PE
9352011-10-07 Paul Eggert <eggert@cs.ucla.edu>
936
937 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
938 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
939 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
940 this makes Emacs dump core during garbage collection on rare
941 occasions. sizeof is obviously inferior to offsetof here, so
942 stick with offsetof.
943 (GC_POINTER_ALIGNMENT): New macro.
944 (mark_memory): Omit 3rd (offset) arg; caller changed.
945 Don't assume EMACS_INT alignment is the same as pointer alignment.
946
df1bbe5b
SM
9472011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
948
949 * keyboard.c (read_key_sequence_remapped): New var.
950 (read_key_sequence): Compute remapping in the right buffer.
951 (command_loop_1): Use read_key_sequence's remapping directly.
952
51553db6
SM
9532011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
954
32c1fffd
SM
955 * dired.c (file_name_completion): Don't expand file name.
956 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
957 before checking file name handler.
958
51553db6
SM
959 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
960 they've been requested explicitly (bug#9591).
961
b6bd1599 9622011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
963
964 * keymap.c (Fsingle_key_description): Use make_specified_string
965 instead of build_string to build string from push_key_description.
966 (Bug#5193)
967
f701dc2a
PE
9682011-09-30 Paul Eggert <eggert@cs.ucla.edu>
969
4222c55d
PE
970 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
971 This fixes a Y2038 bug on 64-bit hosts.
972 * buffer.c (reset_buffer):
973 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
974 (Fclear_buffer_auto_save_failure):
975 Use 0, not -1, to represent an unset failure time, since time_t
976 might not be signed.
977
f701dc2a
PE
978 Remove dependency on glibc malloc internals.
979 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
980 Move back here from lisp.h, but with their new implementations.
981 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
982 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
983 * charset.c (charset_table_init): New static var.
984 (syms_of_charset): Use it instead of xmalloc. This removes a
985 dependency on glibc malloc internals. See Eli Zaretskii's comment in
986 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
987 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
988 Move back to alloc.c.
989 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
990 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
991
9ceebf39
JD
9922011-09-30 Jan Djärv <jan.h.d@swipnet.se>
993
994 * nsterm.m (windowDidResize): Call x_set_window_size only when
995 ns_in_resize is true. Otherwise set pixelwidth/height and
996 call change_frame_size (Bug#9628).
997
cb993c58
PE
9982011-09-30 Paul Eggert <eggert@cs.ucla.edu>
999
3930c88b
PE
1000 Port --enable-checking=all to Fedora 14 x86-64.
1001 * charset.c (syms_of_charset): Also account for glibc malloc's
1002 internal overhead when calculating the initial malloc maximum.
1003
cb993c58
PE
1004 Port --enable-checking=all to Fedora 14 x86.
1005 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1006 Move to lisp.h.
1007 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1008 (overrun_check_realloc, overrun_check_free):
1009 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1010 That way, xmalloc returns a properly-aligned pointer even if
1011 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1012 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1013 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1014 into account when calculating the initial malloc maximum.
1015 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1016 Move here from alloc.c, so that charset.c can use it too.
1017 Properly align; the old code wasn't right for common 32-bit hosts
1018 when configured with --enable-checking=all.
1019 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1020 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1021
31bed486
EZ
10222011-09-29 Eli Zaretskii <eliz@gnu.org>
1023
04c70788 1024 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1025 use EDOM.
1026
fbcaa2f3
EZ
10272011-09-28 Eli Zaretskii <eliz@gnu.org>
1028
1029 * xdisp.c (compute_display_string_end): If there's no display
1030 string at CHARPOS, return -1.
1031
1032 * bidi.c (bidi_fetch_char): When compute_display_string_end
1033 returns a negative value, treat the character as a normal
1034 character not covered by a display string. (Bug#9624)
1035
a239d4e9
JB
10362011-09-28 Juanma Barranquero <lekktu@gmail.com>
1037
1038 * lread.c (Fread_from_string): Fix typo in docstring.
1039
88652fd5
EZ
10402011-09-27 Eli Zaretskii <eliz@gnu.org>
1041
1042 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1043 newline, reseat the iterator instead of bidi-iterating there one
1044 character at a time. (Bug#9610)
32c1fffd
SM
1045 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1046 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1047
ed497dd4
AS
10482011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1049
1050 * lread.c (readevalloop): Use correct code for NBSP.
1051 (read1): Likewise. (Bug#9608)
1052
b2bf61aa
MA
10532011-09-25 Michael Albinus <michael.albinus@gmx.de>
1054
1055 * dbusbind.c (Fdbus_register_signal): When service is not
1056 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1057
32bbb17c
GM
10582011-09-25 Glenn Morris <rgm@gnu.org>
1059
1060 * buffer.c (truncate-lines): Doc fix.
1061
94e0933e
CY
10622011-09-24 Chong Yidong <cyd@stupidchicken.com>
1063
1064 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1065 (Fset_window_next_buffers): Doc fix.
1066
cddde921
GM
10672011-09-24 Glenn Morris <rgm@gnu.org>
1068
1069 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1070
1260aef1
PE
10712011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1072
25b4bfa0
PE
1073 Fix minor problems found by static checking.
1074 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1075 * indent.c (Fvertical_motion): Fix == vs = typo.
1076
e3cbd34b
EZ
10772011-09-24 Eli Zaretskii <eliz@gnu.org>
1078
a66cfb1c
SM
1079 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1080 Default value is now t. Doc fix.
6bf7006f 1081
e3cbd34b 1082 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1083 logic when moving up, not only when moving down. Fix the
e3cbd34b 1084 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1085 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1086
1087 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1088 CHARPOS is covered by a display string which includes newlines.
1089 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1090 is covered by a display string with embedded newlines.
1091
a3de0cbd
MA
10922011-09-24 Michael Albinus <michael.albinus@gmx.de>
1093
1094 * dbusbind.c (Fdbus_register_signal): Add match rule to
1095 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1096 (Fdbus_register_method, Vdbus_registered_objects_table):
1097 Fix docstring.
a3de0cbd 1098
b260039d
JM
10992011-09-24 Jim Meyering <meyering@redhat.com>
1100
32c1fffd 1101 do not ignore write error for any output size
b260039d
JM
1102 The previous change was incomplete.
1103 While it makes emacs --batch detect the vast majority of stdout
1104 write failures, errors were still ignored whenever the output size is
1105 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1106 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1107 && echo FAIL: ignored write error
1108 FAIL: ignored write error
1109 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1110 && echo FAIL: ignored write error
1111 FAIL: ignored write error
1112 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1113
8eca8a7c
AS
11142011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1115
1116 * emacs.c (Fkill_emacs): In noninteractive mode exit
1117 non-successfully if a write error occurred on stdout. (Bug#9574)
1118
3341db62
EZ
11192011-09-21 Eli Zaretskii <eliz@gnu.org>
1120
1121 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1122 the xassert test.
1123
1124 * dispextern.h (struct it): Update the comment documenting what
1125 can it->OBJECT be.
1126
8c203dbf
EZ
11272011-09-20 Eli Zaretskii <eliz@gnu.org>
1128
1129 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1130 a display string, extend search for cursor position to end of row.
1131 (find_row_edges): If the row ends in a newline from a display
1132 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1133 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1134 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1135 non-empty line. Fixes confusing cursor motion with arrow keys at
1136 the beginning of a line that starts with whitespace.
8c203dbf 1137
a4824228
LMI
11382011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1139
1140 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1141 (bug#9493).
1142
33ed493b
CY
11432011-09-18 Chong Yidong <cyd@stupidchicken.com>
1144
1145 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1146 boolean (Bug#9154).
1147
56cd55c8
EZ
11482011-09-18 Eli Zaretskii <eliz@gnu.org>
1149
1150 * xdisp.c (display_line): Record maximum and minimum buffer
1151 positions even if no glyphs were produced (e.g., by a zero-width
1152 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1153 buffer positions that will be removed from the glyph row because
1154 they don't fit.
c02dcedf
EZ
1155 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1156 column is beyond frame width: don't subtract 1 "pixel" when
1157 computing width of the stretch.
3e62b7e0
EZ
1158 (reseat_at_next_visible_line_start): Undo the change made on
1159 2011-09-17 that saved paragraph information and restored it after
1160 the call to `reseat'. (Bug#9545)
56cd55c8 1161
5ed99d36 11622011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1163
1164 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1165 and turn window cursor on if cleared (Bug#9415).
1166
5ed99d36 11672011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1168
1169 * search.c (boyer_moore): Take unibyte characters from pattern
1170 literally. (Bug#9458)
1171
9bade7b2
EZ
11722011-09-18 Eli Zaretskii <eliz@gnu.org>
1173
1174 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1175
e5e9d610
PE
11762011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1177
87e4427a
PE
1178 Fix minor problem found by static checking.
1179 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1180 initialized, to pacify gcc -Wuninitialized.
1181
e5e9d610
PE
1182 * fileio.c: Report proper errno when syscall falls.
1183 (Finsert_file_contents): Save and restore errno,
1184 so that report_file_error outputs the correct diagnostic.
1185 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1186
a1674f0b
EZ
11872011-09-18 Eli Zaretskii <eliz@gnu.org>
1188
1189 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1190
fbfb6dd4
EZ
11912011-09-17 Eli Zaretskii <eliz@gnu.org>
1192
1193 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1194 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1195
bb187662
EZ
11962011-09-17 Eli Zaretskii <eliz@gnu.org>
1197
1137e8b8 1198 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1199 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1200
1201 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1202 (bidi_find_paragraph_start): Search back for paragraph beginning
1203 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1204 (bidi_move_to_visually_next): Only trigger paragraph-related
1205 computations when the last character is a newline or at EOB, not
1206 just any NEUTRAL_B. (Bug#9470)
1207
bb187662
EZ
1208 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1209 truncated lines if point is covered by a display string. (Bug#9524)
1210
2e621251
PE
12112011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1212
1213 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1214 (cons_to_x_long): New function.
1215 (lisp_data_to_selection_data): Use it. Correct the test for
1216 short-versus-long data; it was negated. Break out of vector
1217 loop, for efficiency, when a long datum is discovered.
1218
91a15bc6
SM
12192011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1220
1221 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1222
b41c3a35
EZ
12232011-09-16 Eli Zaretskii <eliz@gnu.org>
1224
1225 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1226 GCC PR/17406) by declaring this function with external scope.
1227
7812ba2d
PE
12282011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1231 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1232
cf7edc2a
AS
12332011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1234
1235 * editfns.c (Fformat): Correctly handle text properties on "%%".
1236
bd01620e
EZ
12372011-09-15 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xterm.c (x_draw_composite_glyph_string_foreground):
1240 * w32term.c (x_draw_composite_glyph_string_foreground):
1241 * term.c (encode_terminal_code):
1242 * composite.c (composition_update_it, get_composition_id):
1243 * xdisp.c (get_next_display_element)
1244 (fill_composite_glyph_string): Add comments about special meaning
1245 of TAB characters in a composition.
1246
a02719a3
PE
12472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1250 This occurs when processing a multibyte format.
1251 Problem reported by Wolfgang Jenker.
a02719a3 1252
72589a3c
JB
12532011-09-15 Johan Bockgård <bojohan@gnu.org>
1254
1255 * xdisp.c (try_cursor_movement): Only check for exact match if
1256 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1257
1c14176c
PE
12582011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1259
1260 Remove unused external symbols.
1261 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1262 * xdisp.c (calc_pixel_width_or_height): Now static.
1263 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1264 * indent.c (check_display_width):
1265 * w32term.c: Fix comment to match code.
1266 * xterm.c, xterm.h (x_catching_errors): Remove.
1267
d2eea5b5
PE
12682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1269
1270 * xselect.c: Use signed conversions more consistently (Bug#9498).
1271 (selection_data_to_lisp_data): Assume incoming selection data are
1272 signed integers, not unsigned. This is to be consistent with
1273 outgoing selection data, which was modified to use signed integers
1274 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1275 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1276 expects long, not unsigned long.
1277
46888499
EZ
12782011-09-14 Eli Zaretskii <eliz@gnu.org>
1279
1280 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1281 computation of loop end. Reported by Johan Bockgård
1282 <bojohan@gnu.org>.
1283
ef8ef9fb
CY
12842011-09-13 Chong Yidong <cyd@stupidchicken.com>
1285
1286 * frame.c (Fother_visible_frames_p): Function deleted.
1287
fa819fed
EZ
12882011-09-12 Eli Zaretskii <eliz@gnu.org>
1289
1290 * indent.c (compute_motion): Process display vector front to back
1291 rather than the other way around. (Bug#2496)
1292
2ba8e008
SM
12932011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1294
1295 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1296
20f53c69
CY
12972011-09-11 Chong Yidong <cyd@stupidchicken.com>
1298
1299 * minibuf.c (Fread_from_minibuffer): Doc fix.
1300
d562d7a4
EZ
13012011-09-11 Eli Zaretskii <eliz@gnu.org>
1302
1303 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1304 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1305
1c4d7f3d
LMI
13062011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1307
1308 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1309 value for non-existent files.
1310
b885bf36
EZ
13112011-09-11 Eli Zaretskii <eliz@gnu.org>
1312
1313 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1314 set its "size" to -1. This will set the modtime_size field of
1315 the corresponding buffer to -1, which is what
1316 verify-visited-file-modtime expects for files that do not exist.
1317 (Bug#9139)
1318
6612f0bf
PE
13192011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1322 here ...
1323 * lisp.h: ... from here. push_key_description is no longer
1324 defined in keyboard.c, so its declaration should not be in
1325 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1326 logically belongs with push_key_description.
1327
dfb3f755
PE
13282011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1329
1330 * buffer.h: Include <sys/types.h> instead of <time.h>.
1331 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1332 Problem reported by Herbert J. Skuhra.
1333
3134906c
LMI
13342011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1335
1336 * xml.c (parse_region): Make the parsing work for
1337 non-comment-starting XML files again (bug#9144).
1338
8d903f4e
AS
13392011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1340
1341 * image.c (gif_load): Fix calculation of bottom and right corner.
1342 (Bug#9468)
1343
80ad64f4
EZ
13442011-09-10 Eli Zaretskii <eliz@gnu.org>
1345
1346 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1347 redisplay in small windows.
1348
208a048d
EZ
13492011-09-09 Eli Zaretskii <eliz@gnu.org>
1350
1351 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1352
9b1c252e
MR
13532011-09-08 Martin Rudalics <rudalics@gmx.at>
1354
1355 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1356 Operate on live windows only.
1357
2949f33b
JB
13582011-09-08 Juanma Barranquero <lekktu@gmail.com>
1359
1360 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1361
e08dcafd
EZ
13622011-09-07 Eli Zaretskii <eliz@gnu.org>
1363
1364 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1365 only under bidi iteration.
1366
115b96bd
JD
13672011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1368
1369 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1370
c8199d0f
PE
13712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1372
1373 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1374 Without this fix, the command to link temacs failed due to an
1375 undefined symbol __builtin_isnan. This is because
1376 /usr/include/iso/math_c99.h #defines isnan(x) to
1377 __builtin_isnan(x), but the bundled gcc, which identifies itself
1378 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1379 a __builtin_isnan.
1380 * floatfns.c (isnan): #undef, and then #define to a clone of
1381 what's in data.c.
1382 (Fisnan): Always define, since it's always available now.
1383 (syms_of_floatfns): Always define isnan at the Lisp level.
1384
e39b275c 13852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1386
1387 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1388
b2db44d9 13892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1390
f4af5137 1391 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1392 The previous code assumed that file offsets (off_t values) fit in
1393 EMACS_INT variables, which is not true on typical 32-bit hosts.
1394 The code messed up by falsely reporting buffer overflow in cases
1395 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1396 when "big" contains more than 2**29 bytes, even though this
1397 inserts just one byte and does not overflow the buffer.
1398 (Finsert_file_contents): Store file offsets as off_t
1399 values, not as EMACS_INT values. Check for overflow when
1400 converting between EMACS_INT and off_t. When checking for
1401 buffer overflow or for overlap, take the offsets into account.
1402 Don't use EMACS_INT for small values where int suffices.
1403 When checking for overlap, fix a typo: ZV was used where
1404 ZV_BYTE was intended.
1405 (Fwrite_region): Don't assume off_t fits into 'long'.
1406 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1407
ecfc0a49
MA
14082011-09-05 Michael Albinus <michael.albinus@gmx.de>
1409
1410 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1411
6511acf2 14122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1413
0999621a 1414 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1415
1416 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1417 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1418 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1419 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1420 (modify_event_symbol): Do not assume that the length of
1421 name_alist_or_stem is safe to alloca and fits in int.
1422 (Fexecute_extended_command): Likewise for function name and binding.
1423 (Frecursion_depth): Wrap around reliably on integer overflow.
1424 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1425 since some callers pass EMACS_INT values.
1426 (Fsingle_key_description): Don't crash if symbol name contains more
1427 than MAX_ALLOCA bytes.
1428 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1429 (get_minibuffer): Arg is now EMACS_INT, not int.
1430 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1431 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1432 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1433
2be7d702
PE
1434 * dbusbind.c (signature_cat): New function.
1435 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1436 Do not overrun buffer; instead, report string overflow.
1437
9d1df220
PE
1438 * dispnew.c (add_window_display_history): Don't overrun buffer.
1439 Truncate instead; this is OK since it's just a log.
1440
33ef5c64
PE
1441 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1442 even if the time zone offset is outlandishly large.
1443 Don't mishandle offset == INT_MIN.
1444
66c6fdd5
PE
1445 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1446 when creating daemon; the previous buffer-overflow check was incorrect.
1447
d749b01b
PE
1448 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1449 which has the guts of the old verror function.
1450
b5cd1905
PE
1451 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1452 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1453
6e1a67fb
PE
1454 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1455 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1456 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1457 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1458 length of string rather than counting it via multiple sprintfs;
1459 that's simpler and more reliable.
c21721cc
PE
1460 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1461 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1462 sprintf, in case result does not fit in int.
1463
c57b67fc
PE
1464 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1465 (fontset_from_font): Print it.
1466
8a401434
PE
1467 * frame.c (tty_frame_count): Now printmax_t, not int.
1468 (make_terminal_frame, set_term_frame_name): Print it.
1469 (x_report_frame_params): In X, window IDs are unsigned long,
1470 not signed long, so print them as unsigned.
1471 (validate_x_resource_name): Check for implausibly long names,
1472 and don't assume name length fits in 'int'.
1473 (x_get_resource_string): Don't blindly alloca invocation name;
1474 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1475 not fit in int.
1476
6e1a67fb
PE
1477 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1478 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1479 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1480
0df02bf3
PE
1481 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1482 Use esprintf, not sprintf, in case result does not fit in int.
1483
48e30793
PE
1484 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1485 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1486 it as a large positive number.
1487 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1488 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1489
a66ff6d8
PE
1490 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1491 in case result does not fit in int.
1492
aca216ff
PE
1493 * print.c (float_to_string): Detect width overflow more reliably.
1494 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1495 buffer overrun. Don't assume list length fits in 'int'. Treat
1496 print length of 0 as 0, not as infinity; to be consistent with other
1497 uses of print length in this function. Don't overflow print length
1498 index. Don't assume hash table size fits in 'long', or that
1499 vectorlike size fits in 'unsigned long'.
1500
31c286f7
PE
1501 * process.c (make_process): Use printmax_t, not int, to format
1502 process-name gensyms.
1503
55e5faa1
PE
1504 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1505
80f2e268
PE
1506 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1507 to avoid potential buffer overrun.
1508
670741ab
PE
1509 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1510 if X resource line is longer than 512 bytes.
1511
b7163a50
PE
1512 * xfns.c (x_window): Make sprintf buffer a bit bigger
1513 to avoid potential buffer overrun.
1514
ae58ff1f
PE
1515 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1516
c43c8a6a
PE
1517 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1518
3f8236f4
PE
15192011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1520
53e9fe90 1521 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1522 Without these, Emacs silently mishandles large integers sometimes.
1523 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1524 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1525
6511acf2
PE
1526 * xdisp.c (try_window_id): Check Emacs fixnum range before
1527 converting to 'int'.
806add1d 1528
6511acf2 1529 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1530 Check that an Emacs fixnum is in range before assigning it to 'int'.
1531 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1532 values converted from Emacs fixnums.
1533 (Frecenter): Don't wrap around a line count if it is out of 'int'
1534 range; instead, treat it as an extreme value.
1535 (Fset_window_configuration, compare_window_configurations):
1536 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1537
6511acf2
PE
1538 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1539 that can exceed INT_MAX. Check that EMACS_INT value is in range
1540 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1541 (match_limit): Don't assume that a fixnum can fit in 'int'.
1542
6511acf2 1543 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1544 exceed INT_MAX.
1545
6511acf2 1546 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1547 (Fvertical_motion): Don't wrap around LINES values that don't fit
1548 in 'int'. Instead, treat them as extreme values. This is good
1549 enough for windows, which can't have more than INT_MAX lines anyway.
1550
fcb901a7
LMI
15512011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1552
0f2f6b6d
LMI
1553 * Require libxml/parser.h to avoid compilation warning.
1554
fcb901a7
LMI
1555 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1556
1557 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1558 since this reportedly can destroy thread storage.
1559
6e20a0d4
CY
15602011-08-30 Chong Yidong <cyd@stupidchicken.com>
1561
1562 * syntax.c (find_defun_start): Update all cache variables if
1563 exiting early (Bug#9401).
1564
148ae00e
EZ
15652011-08-30 Eli Zaretskii <eliz@gnu.org>
1566
f6cfbd8f
EZ
1567 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1568
148ae00e
EZ
1569 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1570 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1571 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1572
1573 * term.c (tty_append_glyph): New function.
1574 (produce_stretch_glyph): Static function and its prototype deleted.
1575
a66cfb1c
SM
1576 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1577 Add prototypes.
148ae00e 1578
c4a07a4c
PE
15792011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1580
1581 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1582 when checking :margin (Bug#9390).
1583 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1584 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1585 so that the name doesn't mislead. All uses changed.
1586
6bc8cd65
JB
15872011-08-28 Johan Bockgård <bojohan@gnu.org>
1588
1589 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1590 set_tty_hooks.
1591
dca4927e
EZ
15922011-08-27 Eli Zaretskii <eliz@gnu.org>
1593
1594 * xdisp.c (move_it_to): Don't bail out early when reaching
1595 position beyond to_charpos, if we are scanning backwards.
1596 (move_it_vertically_backward): When DY == 0, make sure we get to
1597 the first character in the line after the newline.
1598
f2cad773
PE
15992011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1600
1601 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1602 (ccl_driver): Do not generate an out-of-range pointer.
1603 (Fccl_execute_on_string): Remove unnecessary check for
1604 integer overflow, noted by Stefan Monnier in
1605 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1606 Remove a FIXME that didn't need fixing.
1607 Simplify the newly-introduced buffer reallocation code.
1608
0cae2cdb
JB
16092011-08-27 Juanma Barranquero <lekktu@gmail.com>
1610
1611 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1612
5fc295a4 16132011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1614
70c60eb2 1615 Integer and memory overflow issues (Bug#9196).
726e0ab1 1616
d31850da
PE
1617 * doc.c (get_doc_string): Rework so that
1618 get_doc_string_buffer_size is the actual buffer size, rather than
1619 being 1 less than the actual buffer size; this makes xpalloc more
1620 convenient.
1621
a69fbedb
PE
1622 * image.c (x_allocate_bitmap_record, cache_image):
1623 * xselect.c (Fx_register_dnd_atom):
1624 Simplify previous changes by using xpalloc.
1625
fe5c5d37
PE
1626 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1627 since either will do and ptrdiff_t is convenient with xpalloc.
1628
0065d054
PE
1629 * charset.c (charset_table_size)
1630 (struct charset_sort_data.priority): Now ptrdiff_t.
1631 (charset_compare): Don't overflow if priorities differ greatly.
1632 (Fsort_charsets): Don't assume list length fits in int.
1633 Check for size-calculation overflow when allocating sort data.
1634 (syms_of_charset): Allocate an initial charset table that is
1635 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1636
1637 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1638
1639 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1640 The actual value is always <= INT_MAX, and leaving it unsigned made
1641 overflow checking harder.
1642
1643 * dispextern.h (struct glyph_matrix.rows_allocated)
1644 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1645 with xpalloc. The values are still always <= INT_MAX.
1646
1647 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1648
1649 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1650 (SAFE_NALLOCA): New macro.
1651
1652 * region-cache.c (struct boundary.pos, find_cache_boundary)
1653 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1654 (set_cache_region, invalidate_region_cache)
1655 (revalidate_region_cache, know_region_cache, region_cache_forward)
1656 (region_cache_backward, pp_cache):
1657 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1658 so that ptrdiff_t * can be passed to xpalloc.
1659 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1660 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1661 (pp_cache): Don't assume cache_len fits in int.
1662 * region-cache.h: Adjust extern decls to match.
1663
1664 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1665 EMACS_INT, since either will do, for xpalloc.
1666
1667 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1668 (xnmalloc, xnrealloc, xpalloc): New functions.
1669
726e0ab1
PE
1670 * bidi.c (bidi_shelve_header_size): New constant.
1671 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1672 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1673
51f30bc5 1674 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1675 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1676 (overlay_strings):
1677 Don't update size of array until after memory allocation succeeds,
1678 because xmalloc/xrealloc may not return.
0065d054
PE
1679 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1680 now that we have proper integer overflow checking.
1681 (record_overlay_string, overlay_strings): Catch overflows when
1682 calculating size of overlay_str_buf.
726e0ab1 1683
0065d054
PE
1684 * callproc.c (Fcall_process): Check for size overflow when
1685 calculating size of args2.
1686 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1687 Normally we prefer signed values, but sticking with ptrdiff_t would
1688 require adding more-complicated checks.
726e0ab1
PE
1689
1690 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1691 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1692 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1693 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1694
1695 * character.c (Fstring): Check for size-calculation overflow.
1696
1697 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1698 unnecessary integer overflow. Check for size overflow.
1699 (encode_coding_object): Don't update size until xmalloc succeeds.
1700
1701 * composite.c (get_composition_id): Check for overflow in glyph
1702 length calculations.
1703
1704 Integer and memory overflow fixes for display code.
1705 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1706 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1707 (scrolling_window): Check for overflow in size calculations.
1708 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1709 Don't assume glyph table len fits in int.
1710 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1711 (row_table_size): Now ptrdiff_t, not int.
1712 (scrolling_window): Avoid overflow in size calculations.
1713 Don't update size until allocation succeeds.
1714 * fns.c (concat): Check for overflow in size calculations.
1715 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1716 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1717 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1718
1719 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1720 (get_doc_string): Check for size calculation overflow.
1721 Don't update size until allocation succeeds.
1722 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1723 EMACS_INT, where ptrdiff_t will do.
1724 (Fsubstitute_command_keys): Check for string overflow.
1725
1726 * editfns.c (set_time_zone_rule): Don't assume environment length
1727 fits in int.
1728 (message_length): Now ptrdiff_t, not int.
1729 (Fmessage_box): Don't update size until allocation succeeds.
1730 Don't assume message length fits in int.
1731 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1732
0065d054
PE
1733 * emacs.c (main): Do not reallocate argv, since there is a null at
1734 the end that can be overwritten, and this way there's no need to
1735 worry about size-calculation overflow.
1736 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1737
1738 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1739 alloc succeeds.
1740 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1741
1742 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1743 (x_set_scroll_bar_width, x_figure_window_size):
1744 Check for integer overflow.
1745 (x_set_alpha): Do not assume XINT fits in int.
1746
1747 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1748 This is for the members text_lines, text_cols, total_lines, total_cols,
1749 where the system imposes an 'int' limit.
1750
1751 * fringe.c (Fdefine_fringe_bitmap):
1752 Don't update size until alloc works.
1753
1754 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1755 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1756
1757 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1758 Check for size-calculation overflow.
1759 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1760 do, as we prefer signed integers.
1761 (id_to_widget.max_size, id_to_widget.used)
1762 (xg_store_widget_in_map, xg_remove_widget_from_map)
1763 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1764 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1765 Use and return ptrdiff_t, not int.
1766 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1767 * gtkutil.h: Change prototypes to match the above.
1768
1769 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1770 are duplicate now that they've been promoted to lisp.h.
1771 (x_allocate_bitmap_record, x_alloc_image_color)
1772 (make_image_cache, cache_image, xpm_load):
1773 Don't update size until alloc is done.
1774 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1775 (x_detect_edges):
3256efce 1776 Check for size calculation overflow.
726e0ab1
PE
1777 (ct_colors_allocated_max): New constant.
1778 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1779 overflow.
3256efce 1780
726e0ab1
PE
1781 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1782 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1783 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1784 Use ptrdiff_t, not int, to count maps.
1785 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1786 calculations. Don't update size until allocation succeeds.
1787 Redo calculations to avoid overflow.
726e0ab1
PE
1788 * keyboard.h: Change prototypes to match the above.
1789
1790 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1791 to count maps.
1792 (current_minor_maps): Check for size calculation overflow.
1793 * keymap.h: Change prototypes to match the above.
1794
1795 * lread.c (read1, init_obarray): Don't update size until alloc done.
1796
1797 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1798 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1799
726e0ab1
PE
1800 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1801 Now ptrdiff_t, not int.
1802 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1803 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1804
1805 * process.c (Fnetwork_interface_list): Check for overflow
1806 in size calculation.
1807
1808 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1809
1810 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1811 overflow. Don't bother calling xmalloc when xrealloc will do.
1812
1813 * search.c (Freplace_match): Check for size calculation overflow.
1814 (Fset_match_data): Don't assume list lengths fit in 'int'.
1815
1816 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1817 for command line length. Do not attempt to address one before the
1818 beginning of an array, as that's not portable.
1819
1820 * term.c (max_frame_lines): Remove; unused.
1821 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1822 not int.
1823 (encode_terminal_code, calculate_costs): Check for size
1824 calculation overflow.
1825 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1826 table lengths and related sizes. Don't update size until alloc
1827 done. Redo calculations to avoid overflow.
1828 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1829
1830 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1831 subtracting pointers.
1832 (gobble_line): Check for overflow more carefully. Don't update size
1833 until alloc done.
1834
1835 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1836 Don't update size until alloc done.
1837 Redo size calculations to avoid overflow.
1838 Check for size calculation overflow.
0065d054 1839 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1840
1841 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1842 Use ptrdiff_t, not int, for sizes.
1843 (store_mode_line_noprop_char): Don't update size until alloc done.
1844
0065d054
PE
1845 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1846 Use ptrdiff_t, not int, for sizes.
1847 (Finternal_make_lisp_face, cache_face):
1848 Check for size calculation overflow.
1849 (cache_face): Treat size calculation overflows as if they were
1850 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1851
1852 * xfns.c (x_encode_text, x_set_name_internal)
1853 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1854 sizes, since they can exceed INT_MAX in size. Check for size
1855 calculation overflow.
1856
0065d054
PE
1857 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1858 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1859 Don't update size until alloc done.
1860
0065d054 1861 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1862 as sprintf is limited to int lengths.
1d526e2f 1863
252c5ee1
PE
1864 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1865 (X_LONG_MIN): New macros.
864d7ce7
PE
1866 Use them to make the following changes clearer.
1867 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1868 This change doesn't affect the value now, but it may help remind
1869 future maintainers not to raise the value too much later.
1870 (SELECTION_QUANTUM): Remove, replacing with ...
1871 (selection_quantum): ... new function, which avoids overflow.
1872 All uses changed.
1873 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1874 assumption that selection length fits in 'int'.
1875 (x_reply_selection_request, x_handle_selection_request)
1876 (x_get_window_property, receive_incremental_selection)
1877 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1878 (lisp_data_to_selection_data, clean_local_selection_data):
1879 Use ptrdiff_t, not int, to record length of selection.
1880 (x_reply_selection_request, x_get_window_property)
1881 (receive_incremental_selection, x_property_data_to_lisp):
1882 Redo calculations to avoid overflow.
1883 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1884 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1885 something.
1886 (x_get_window_property, receive_incremental_selection)
1887 (lisp_data_to_selection_data, x_property_data_to_lisp):
1888 Check for size-calculation overflow.
1889 (x_get_window_property, receive_incremental_selection)
1890 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1891 Don't store size until memory allocation succeeds.
1892 (x_get_window_property): Plug memory leak on memory exhaustion.
1893 Don't double-block input; malloc is safe here. Don't assume 2**34
1894 - 4 fits in unsigned long. Add an xassert to check
1895 XGetWindowProperty overflow. Be more careful about overflow
1896 calculations, and distinguish size from memory overflow better.
1897 (receive_incremental_selection): When tracing, don't assume
1898 unsigned int is less than INT_MAX.
1899 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1900 harmful) conversions of unsigned short to int.
1901 (lisp_data_to_selection_data): Don't assume that integers
1902 in the range -65535 through -1 fit in an X unsigned short.
1903 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1904 result parameters unless successful. Rely on cons_to_unsigned
1905 to report problems with elements; the old code wasn't right anyway.
1906 (x_check_property_data): Check for int overflow; we cannot use
1907 a wider type due to X limits.
1908 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1909
726e0ab1 1910 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1911
0065d054
PE
1912 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1913 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1914 (x_color_cells): Don't store size until memory allocation succeeds.
1915 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1916 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1917 (x_term_init): Don't assume length fits in int (sprintf is limited
1918 to int size).
bc18e09d 1919
ebfa62c0
PE
1920 Use ptrdiff_t for composition IDs.
1921 * character.c (lisp_string_width):
1922 * composite.c (composition_table_size, n_compositions)
1923 (get_composition_id, composition_gstring_from_id):
1924 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1925 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1926 * window.c (Frecenter):
1927 Use ptrdiff_t, not int, for composition IDs.
1928 * composite.c (get_composition_id): Check for integer overflow.
1929 * composite.h: Adjust prototypes to match the above changes.
1930
d3411f89
PE
1931 Use ptrdiff_t for hash table indexes.
1932 * category.c (hash_get_category_set):
1933 * ccl.c (ccl_driver):
1934 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1935 * coding.c (coding_system_charset_list, detect_coding_system):
1936 * coding.h (struct coding_system.id):
1937 * composite.c (get_composition_id, gstring_lookup_cache):
1938 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1939 * image.c (xpm_get_color_table_h):
1940 * lisp.h (hash_lookup, hash_put):
1941 * minibuf.c (Ftest_completion):
1942 Use ptrdiff_t for hash table indexes, not int (which is too
1943 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1944 32-bit --with-wide-int hosts).
1945
e097a6fa
PE
1946 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1947 Add a FIXME comment about memory leaks.
1948 (syms_of_charset): Don't assume xmalloc returns.
1949
5637687f
PE
1950 Don't assume that stated character widths fit in int.
1951 * character.c (Fchar_width, c_string_width, lisp_string_width):
1952 * character.h (CHAR_WIDTH):
1953 * indent.c (MULTIBYTE_BYTES_WIDTH):
1954 Use sanitize_char_width to avoid undefined and/or bad behavior
1955 with outlandish widths.
a66cfb1c 1956 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1957 now that we have two such functions. All uses changed.
1958 (sanitize_char_width): New inline function.
1959
a2271ba2
PE
1960 Don't assume that tab-width fits in int.
1961 * character.h (sanitize_width): New inline function.
1962 (SANE_TAB_WIDTH): New macro.
1963 (ASCII_CHAR_WIDTH): Use it.
1964 * indent.c (sane_tab_width): Remove. All uses replaced by
1965 SANE_TAB_WIDTH (current_buffer).
1966 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1967
18c52557
PE
1968 * fileio.c: Integer overflow issues with file modes.
1969 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1970
caeeedc1
PE
1971 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1972 Remove unreachable code.
1973 (read_hex, load_charset_map_from_file): Check for integer overflow.
1974
50849c52
PE
1975 * xterm.c: don't go over XClientMessageEvent limit
1976 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1977 (x_send_scroll_bar_event): Likewise. Check that the size does not
1978 exceed limits imposed by XClientMessageEvent, as well as the usual
1979 ptrdiff_t and size_t limits.
1980
b13995db
PE
1981 * keyboard.c: Overflow, signedness and related fixes.
1982 (make_lispy_movement): Use same integer type in forward decl
1983 that is used in the definition.
1984 (read_key_sequence, keyremap_step):
1985 Change bufsize argument back to int, undoing my 2011-03-30 change.
1986 We prefer signed types, and int is wide enough here.
1987 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1988 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1989 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1990 length, not size_t. Use ptrdiff_t for index, not int.
1991 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1992 possibility of integer overflow.
1993
13464394
PE
1994 Overflow, signedness and related fixes for images.
1995
1996 * dispextern.h (struct it.stack[0].u.image.image_id)
1997 (struct_it.image_id, struct image.id, struct image_cache.size)
1998 (struct image_cache.used, struct image_cache.ref_count):
1999 * gtkutil.c (update_frame_tool_bar):
2000 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2001 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2002 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2003 * nsmenu.m (update_frame_tool_bar):
2004 * xdisp.c (calc_pixel_width_or_height):
2005 * xfns.c (image_cache_refcount):
2006 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2007 on typical 64-bit hosts.
2008
2009 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2010 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2011 Omit unnecessary casts to int.
2012 (parse_image_spec): Check that integers fall into 'int' range
2013 when the callers expect that.
2014 (image_ascent): Redo ascent calculation to avoid int overflow.
2015 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2016 (lookup_image): Remove unnecessary tests.
2017 (xbm_image_p): Locals are now of int, not EMACS_INT,
2018 since parse_image_check makes sure they fit into int.
2019 (png_load, gif_load, svg_load_image):
2020 Prefer int to unsigned where either will do.
2021 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2022 old tiff_error_handler and tiff_warning_handler.
2023 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2024 stack buffer overflows. It uses only the features of vsnprintf
2025 that are common to both POSIX and native Microsoft.
2026 (tiff_error_handler, tiff_warning_handler): Use it.
2027 (tiff_load, gif_load, imagemagick_load_image):
2028 Don't assume :index value fits in 'int'.
2029 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2030 (imagemagick_load_image): Check that crop parameters fit into
2031 the integer types that MagickCropImage accepts. Don't assume
2032 Vimagemagick_render_type has a nonnegative value. Don't assume
2033 size_t fits in 'long'.
2034 (gs_load): Use printmax_t to print the widest integers possible.
2035 Check for integer overflow when computing image height and width.
2036
c11821d4
EZ
20372011-08-26 Eli Zaretskii <eliz@gnu.org>
2038
2039 * xdisp.c (redisplay_window): Don't force window start if point
2040 will be invisible in the resulting window. (Bug#9324)
2041
0c95fcf7
EZ
20422011-08-25 Eli Zaretskii <eliz@gnu.org>
2043
2044 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2045 the display spec is of the form `(space ...)'.
2046 (handle_display_spec): Return the value returned by
2047 handle_single_display_spec, not just 1 or zero.
2048 (handle_single_display_spec): If the display spec is of the form
2049 `(space ...)', and specifies display in the text area, return 2
2050 rather than 1.
fee65a97 2051 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2052 accurately, and prefer exact match for point under bidi.
2053 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2054
2055 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2056 into disp_prop; all users changed.
2057
2058 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2059 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2060 for the text covered by the display property.
2061
e4ed06f1
CY
20622011-08-25 Chong Yidong <cyd@stupidchicken.com>
2063
2064 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2065 Change return value to nil.
2066 (Frecord_buffer): Delete unused function.
2067
f67cdd7f
EZ
20682011-08-24 Eli Zaretskii <eliz@gnu.org>
2069
5980d4c6
EZ
2070 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2071 buffers, return left-to-right.
8610fe8b
EZ
2072 (set_cursor_from_row): Consider candidate row a win if its glyph
2073 represents a newline and point is on that newline. Fixes cursor
2074 positioning on the newline at EOL of R2L text within L2R
2075 paragraph, and vice versa.
2076 (try_cursor_movement): Check continued rows, in addition to
2077 continuation rows. Fixes unwarranted scroll when point enters a
2078 continued line of R2L text within an L2R paragraph, or vice versa.
2079 (cursor_row_p): Consider the case of point being equal to
2080 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2081 from the end of a short line to the beginning of a continued line
2082 of R2L text within L2R paragraph.
2083 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2084 composed characters.
5980d4c6 2085
f67cdd7f
EZ
2086 * bidi.c (bidi_check_type): Use xassert.
2087 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2088 members.
2089
bca633fb
EZ
20902011-08-23 Eli Zaretskii <eliz@gnu.org>
2091
2092 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2093 a character.
2094
4a5885a7
CY
20952011-08-23 Chong Yidong <cyd@stupidchicken.com>
2096
2097 * nsfont.m (ns_otf_to_script): Fix typo.
2098
0902a04e
KH
20992011-08-22 Kenichi Handa <handa@m17n.org>
2100
2101 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2102 extra slot even if the purpose is char-code-property-table.
2103
1a2e6670
EZ
21042011-08-23 Eli Zaretskii <eliz@gnu.org>
2105
8ddde651
EZ
2106 * xdisp.c (redisplay_window): When computing centering_position,
2107 account for the height of the header line. (Bug#8874)
2108
425cc014
EZ
2109 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2110 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2111 candidate is selected by the mouse, and that candidate has a
2112 composed character under the mouse.
2113
1a2e6670
EZ
2114 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2115 coordinates reported by pos-visible-in-window-p for a composed
2116 character in column zero.
2117
8b76d6f8
SM
21182011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2119
2120 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2121
dac347dd
EZ
21222011-08-22 Eli Zaretskii <eliz@gnu.org>
2123
2124 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2125 consider it a hit if to_charpos is anywhere in the range of the
2126 composed buffer positions.
2127
e013fb34
CY
21282011-08-22 Chong Yidong <cyd@stupidchicken.com>
2129
2130 * image.c (gif_load): Don't assume that each subimage has the same
2131 dimensions as the base image. Handle disposal method that is
2132 "undefined" by the gif spec (Bug#9335).
2133
bd1ba3e8
CY
21342011-08-20 Chong Yidong <cyd@stupidchicken.com>
2135
2136 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2137 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2138
54a1215b
EZ
21392011-08-19 Eli Zaretskii <eliz@gnu.org>
2140
823564e5
EZ
2141 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2142 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2143 from an Org mode buffer to a Speedbar frame.
2144
54a1215b
EZ
2145 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2146 a composition, take its buffer position from IT->cmp_it.charpos.
2147 Fixes cursor positioning at the beginning of a line that begins
2148 with a composed character.
2149
9778ebcc
EZ
21502011-08-18 Eli Zaretskii <eliz@gnu.org>
2151
0be6ee06
EZ
2152 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2153 character bidirectional type, use STRONG_L instead. Fixes crashes
2154 in a buffer produced by `describe-categories'.
2155
9778ebcc
EZ
2156 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2157 members before the level stack, so they would be saved and
2158 restored when copying iterator state. Fixes incorrect reordering
2159 around TABs covered by display properties.
2160
156bffbe
AS
21612011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2162
6b02f655 2163 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2164
72ad093b
CY
21652011-08-17 Chong Yidong <cyd@stupidchicken.com>
2166
2167 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2168 (internal_condition_case_2, internal_condition_case_n):
2169 Remove unnecessary aborts (Bug#9081).
72ad093b 2170
35774242
EZ
21712011-08-17 Eli Zaretskii <eliz@gnu.org>
2172
2173 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2174 has no `load' handler, try opening the file locally. (Bug#9311)
2175
db76dd85
KB
21762011-08-16 Ken Brown <kbrown@cornell.edu>
2177
2178 * gmalloc.c: Expand comment.
2179
b215eee5
EZ
21802011-08-16 Eli Zaretskii <eliz@gnu.org>
2181
2182 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2183 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2184
a4579d33
KB
21852011-08-16 Ken Brown <kbrown@cornell.edu>
2186
2187 Fix memory allocation problems in Cygwin build (Bug#9273).
2188
2189 * unexcw.c ( __malloc_initialized): Declare external variable.
2190 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2191
8b76d6f8
SM
2192 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2193 New variables.
a4579d33
KB
2194 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2195 dumped emacs.
2196 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2197 in the static heap.
2198 [CYGWIN] (special_realloc): New function.
2199 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2200 requests to realloc storage in the static heap.
2201
3ebec551
PE
22022011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 * bidi.c (bidi_initialize): Remove unused local.
2205
9fd8be00
EZ
22062011-08-15 Eli Zaretskii <eliz@gnu.org>
2207
6b02f655
SM
2208 * bidimirror.h:
2209 * biditype.h: Remove file.
2210 * makefile.w32-in ($(BLD)/bidi.$(O)):
2211 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2212
2213 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2214
2215 * chartab.c: Improve commentary for the uniprop_table API.
2216
32413314
EZ
2217 * bidi.c (bidi_paragraph_init): Support zero value of
2218 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2219 (bidi_initialize): Use uniprop_table instead of including
2220 biditype.h and bidimirror.h.
32413314 2221
9fd8be00
EZ
2222 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2223 coordinates of the iterator when restoring from ppos_it.
2224 (Bug#9296)
2225
5cf2b69b
KH
22262011-08-14 Kenichi Handa <handa@m17n.org>
2227
2228 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2229 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2230
daf17d00
EZ
22312011-08-14 Eli Zaretskii <eliz@gnu.org>
2232
2233 * xdisp.c (move_it_in_display_line_to): Don't invoke
2234 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2235 ppos_it. Fixes vertical cursor motion when line beginning is
2236 covered by an image. (Bug#9296)
2237
08e3161a
JD
22382011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2239
2240 * nsterm.h (ns_run_ascript): Declare.
2241 (NSAPP_DATA2_RUNASSCRIPT): Define.
2242
2243 * nsfns.m (as_script, as_result, as_status): New static variables.
2244 (ns_run_ascript): New function.
5e617bc2 2245 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2246 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2247 the event loop. Get status from as_status (Bug#7276).
2248
2249 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2250 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2251 the event loop (Bug#7276).
2252
a3720aa2
AS
22532011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2254
2255 * gnutls.c (QCgnutls_bootprop_priority)
2256 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2257 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2258 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2259 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2260 (QCgnutls_bootprop_verify_hostname_error)
2261 (QCgnutls_bootprop_callbacks_verify): Rename from
2262 Qgnutls_bootprop_..., all uses changed.
2263
2264 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2265 uses changed.
2266
0a0d27fb
PE
22672011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2268
19d5c50c
PE
2269 * xfaces.c (Qframe_set_background_mode): Now static.
2270 * dispextern.h (Qframe_set_background_mode): Remove decl.
2271
0a0d27fb
PE
2272 * process.c (Fnetwork_interface_info): Declare local only if needed.
2273
377538cb
JD
22742011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2275
2276 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2277 (Fnetwork_interface_list): Allocate in increments of bytes instead
2278 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2279 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2280 sockaddr.
2281 (struct ifflag_def): notrailers is smart on OSX.
2282 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2283 Get hardware address with getifaddrs if available.
2284
08fff70c
EZ
22852011-08-12 Eli Zaretskii <eliz@gnu.org>
2286
2287 * xdisp.c (iterate_out_of_display_property): xassert that
2288 IT->position is set to within IT->object's boundaries. Break from
2289 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2290 when IT->position is set up wrongly due to some bug.
2291 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2292 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2293 entry. Force push_it to save on the stack the current
2294 buffer/string position, to be restored by pop_it. Fix flags in
2295 the iterator structure wrt the object coming from a display
2296 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2297 properties. (Bug#9284)
2298
7be1c708 22992011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2300
7be1c708
CY
2301 * fontset.c (fontset_get_font_group): Add proper type checks.
2302 (Bug#9172)
aac0c6e3 2303
7be1c708 23042011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2305
7be1c708
CY
2306 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2307 and LC_VERSION_MIN_MACOSX.
2308 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2309 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2310
97bb72a6
EZ
23112011-08-08 Eli Zaretskii <eliz@gnu.org>
2312
2313 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2314 no-display-properties-and-no-overlays under bidi display.
2315 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2316 properties and overlays.
97bb72a6 2317
d5617611
CY
23182011-08-08 Chong Yidong <cyd@stupidchicken.com>
2319
37e11a63
CY
2320 * editfns.c (Fset_time_zone_rule): Document relationship with the
2321 setenv function.
2322
d5617611
CY
2323 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2324 the font entity extracted from the cache (Bug#8109).
2325
58872834
CY
23262011-08-07 Chong Yidong <cyd@stupidchicken.com>
2327
2328 * composite.c (autocmp_chars): Don't reset point. That is done by
2329 restore_point_unwind (Bug#5984).
2330
75bfc667
JL
23312011-08-07 Juri Linkov <juri@jurta.org>
2332
2333 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2334 to show the arg `TIME' instead of `TIMEVAL'.
2335
d1410150
EZ
23362011-08-06 Eli Zaretskii <eliz@gnu.org>
2337
2338 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2339 display property strides EOL and includes a newline, as in
2340 longlines-mode. (Bug#9254)
75b771e4
EZ
2341 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2342 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2343
2344 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2345 is non-zero, even if the data buffer is NULL. Fixes a crash in
2346 vertical-motion with longlines-mode. (Bug#9254)
2347
35928349
EZ
23482011-08-05 Eli Zaretskii <eliz@gnu.org>
2349
ec7cc85b
EZ
2350 * bidi.c <bidi_cache_total_alloc>: Now static.
2351 (bidi_initialize): Initialize bidi_cache_total_alloc.
2352
8b76d6f8 2353 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2354 cache. (Bug#9221)
2355
2356 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2357 amount allocated this far in `bidi_cache_total_alloc'.
2358 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2359 non-zero, only free the data buffer without restoring the cache
2360 contents. All callers changed.
2361
2362 * dispextern.h (bidi_unshelve_cache): Update prototype.
2363
2364 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2365 (move_it_in_display_line, move_it_to)
2366 (move_it_vertically_backward, move_it_by_lines): Replace the call
2367 to xfree to an equivalent call to bidi_unshelve_cache.
2368 (move_it_in_display_line_to): Fix logic of returning
412b6358 2369 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2370
e2e2423b
EZ
23712011-08-05 Eli Zaretskii <eliz@gnu.org>
2372
2373 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2374 came from a string character with a `cursor' property. (Bug#9229)
2375
ae9e757a
JD
23762011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2377
2378 * Makefile.in (LIB_PTHREAD): New variable.
2379 (LIBES): Add LIB_PTHREAD (Bug#9216).
2380
2381 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2382 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2383
213bd7f2
AS
23842011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2385
6b02f655 2386 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2387
99aaf75f
JD
23882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2389
2390 * xterm.c (x_find_topmost_parent): New function.
2391 (x_set_frame_alpha): Find topmost parent window with
2392 x_find_topmost_parent and set the property there also (bug#9181).
2393 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2394
c74e9d86
PE
23952011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 * callproc.c (Fcall_process): Avoid vfork clobbering
2398 the local vars buffer, coding_systems, current_dir.
2399
640c8776
SM
24002011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2401
2402 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2403
f26d0e4c
PE
24042011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2405
8a10d76c
PE
2406 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2407 so that it is not optimized away.
2408
f26d0e4c
PE
2409 * xdisp.c (compute_display_string_pos): Remove unused local.
2410
55439c61
EZ
24112011-08-02 Eli Zaretskii <eliz@gnu.org>
2412
2413 Fix slow cursor motion and scrolling in large buffers with
2414 selective display, like Org Mode buffers. (Bug#9218)
2415
2416 * dispextern.h (struct bidi_it): New member disp_prop_p.
2417
2418 * xdisp.c: Remove one-slot cache of display string positions.
2419 (compute_display_string_pos): Accept an additional argument
5e617bc2 2420 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2421 for a display string or property. If found, set DISP_PROP_P
2422 non-zero.
2423
2424 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2425 DISP_PROP_P, and pass it to compute_display_string_pos.
2426 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2427 non-zero. All callers of bidi_fetch_char changed.
2428
fb33fa43
SM
24292011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2430
2431 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2432
b099e063
DM
24332010-12-03 Don March <don@ohspite.net>
2434
2435 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2436 last character M-[char] is translated to ESC [char] (bug#7541).
2437
5cc7f7af
KH
24382011-08-02 Kenichi Handa <handa@m17n.org>
2439
d0fffa3f 2440 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2441
2442 * chartab.c (uniprop_table): Make it non-static.
2443
525d5e6e
EZ
24442011-08-01 Eli Zaretskii <eliz@gnu.org>
2445
2446 * xdisp.c (forward_to_next_line_start): Accept additional argument
2447 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2448 on the newline.
2449 (reseat_at_next_visible_line_start): Use the bidi iterator state
2450 returned by forward_to_next_line_start to restore the state of
2451 it->bidi_it after backing up to previous newline. (Bug#9212)
2452
31011111
AS
24532011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2454
2455 * regex.c (re_comp): Protoize.
2456 (re_exec): Fix return type.
2457 (regexec): Fix type of `ret'. (Bug#9203)
2458
476371c4
PE
24592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2460
e5d76069
PE
2461 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2462 This is needed if max-image-size is a floating-point number.
2463
9a79b20c
AS
24642011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2465
2466 * print.c (print_object): Print empty symbol as ##.
2467
2468 * lread.c (read1): Read ## as empty symbol.
2469
d8c2fa78
AA
24702011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2471
2472 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2473 setting frame foreground color (Bug#9175).
2474 (x_set_background_color): Likewise.
2475
ffe57a7a
AA
2476 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2477 contents (Bug#9176).
2478 (EmacsTooltip -init): Remove bezels and add shadows to
2479 tooltip windows.
2480
bf3492a5
AA
2481 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2482 or scroll bar (Bug#8470).
2483
d55e9c53
AA
2484 * nsfont.m (nsfont_open): Remove assignment to voffset and
2485 unnecessary vars hshink, expand, hd, full_height, min_height.
2486 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2487
2488 * nsterm.h (nsfont_info): Remove voffset field.
2489
d8c2fa78 24902011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2491
2492 Implement strike-through and overline on NextStep (Bug#8863).
2493
2494 * nsfont.m (nsfont_open): Use underline position provided by font,
2495 instead of hard-coded value of 2.
2496 (nsfont_draw): Call ns_draw_text_decoration instead.
2497
2498 * nsterm.h: Add declaration for ns_draw_text_decoration.
2499
2500 * nsterm.m (ns_draw_text_decoration): New function for drawing
2501 underline, overline, and strike-through.
2502 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2503 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2504 accommodate underlining, etc.
4843aac3 2505
4cc60b9b
EZ
25062011-07-28 Eli Zaretskii <eliz@gnu.org>
2507
bc7ece87
EZ
2508 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2509 default.
4cc60b9b 2510
476371c4
PE
25112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2512
66606eea
PE
2513 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2514 Without this fix, if a signal arrives just after memory fills up,
2515 'malloc' might be invoked reentrantly.
2516
476371c4
PE
2517 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2518 In other words, assume that every image size is allowed, on non-X
2519 hosts. This assumption is probably wrong, but it lets Emacs compile.
2520
f3fcc40d
AS
25212011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2522
2523 * regex.c (re_iswctype): Convert return values to boolean.
2524
350c992f
EZ
25252011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2526
2527 * xdisp.c (compute_display_string_pos): Don't use cached display
2528 string position if the buffer had its restriction changed.
2529 (Bug#9184)
2530
5266b4bb
PE
25312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2532
2533 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2534
2573a837 25352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2536
41f55ccd 2537 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2538
39e378da
PE
2539 * bidi.c: Integer size and overflow fixes.
2540 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2541 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2542 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2543 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2544 (bidi_find_other_level_edge):
2545 Use ptrdiff_t instead of EMACS_INT where either will do.
2546 This works better on 32-bit hosts configured --with-wide-int.
2547 (bidi_cache_ensure_space): Check for size-calculation overflow.
2548 Use % rather than repeated addition, for better worst-case speed.
2549 Don't set bidi_cache_size until after xrealloc returns, because it
2550 might not return.
2551 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2552 (bidi_cache_ensure_space): Also check that the bidi cache size
2553 does not exceed that of the largest Lisp string or buffer. See Eli
2554 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2555
5e927815
PE
2556 * alloc.c (__malloc_size_t): Remove.
2557 All uses replaced by size_t. See Andreas Schwab's note
2558 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2559
ca4aa935
PE
2560 * image.c: Improve checking for integer overflow.
2561 (check_image_size): Assume that f is nonnull, since
2562 it is always nonnull in practice. This is one less thing to
2563 worry about when checking for integer overflow later.
2564 (x_check_image_size): New function, which checks for integer
2565 overflow issues inside X.
2566 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2567 This removes the need for a memory_full check.
2568 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2569 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2570 (xbm_read_bitmap_data): Change locals back to 'int', since
2571 their values must fit in 'int'.
2572 (xpm_load_image, png_load, tiff_load):
2573 Invoke x_create_x_image_and_pixmap earlier,
2574 to avoid much needless work if the image is too large.
2575 (tiff_load): Treat overly large images as if
2576 x_create_x_image_and_pixmap failed, not as malloc failures.
2577 (gs_load): Use x_check_image_size.
2578
5f8f9cc2
PE
2579 * gtkutil.c: Omit integer casts.
2580 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2581 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2582
5adf60bc
PE
2583 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2584
c8907a93
PE
2585 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2586 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2587 would wrongly return t on a 64-bit host.
2588
e3c25c68
PE
2589 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2590 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2591 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2592 and therefore cause GCC to emit a bogus diagnostic in some cases.
2593
3f791afe
PE
2594 * image.c: Integer signedness and overflow and related fixes.
2595 This is not an exhaustive set of fixes, but it's time to
2596 record what I've got.
2597 (lookup_pixel_color, check_image_size): Remove redundant decls.
2598 (check_image_size): Don't assume that arbitrary EMACS_INT values
2599 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2600 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2601 (tiff_load, imagemagick_load_image):
2602 Check for overflow in size calculations.
2603 (x_create_x_image_and_pixmap): Remove unnecessary test for
2604 xmalloc returning NULL; that can't happen.
2605 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2606 (xpm_color_bucket): Use better integer hashing function.
2607 (xpm_cache_color): Don't possibly over-allocate memory.
2608 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2609 (gif_memory_source):
2610 Use ptrdiff_t, not int or size_t, to record sizes.
2611 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2612 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2613 either works, as we prefer signed integers.
2614 (tiff_read_from_memory, tiff_write_from_memory):
2615 Return tsize_t, not size_t, since that's what the TIFF API wants.
2616 (tiff_read_from_memory): Don't fail simply because the read would
2617 go past EOF; instead, return a short read.
2618 (tiff_load): Omit no-longer-needed casts.
2619 (Fimagemagick_types): Don't assume size fits into 'int'.
2620
3cc5a532
PE
2621 Improve hashing quality when configured --with-wide-int.
2622 * fns.c (hash_string): New function, taken from sxhash_string.
2623 Do not discard information about ASCII character case; this
2624 discarding is no longer needed.
2625 (sxhash-string): Use it. Change sig to match it. Caller changed.
2626 * lisp.h: Declare it.
2627 * lread.c (hash_string): Remove, since we now use fns.c's version.
2628 The fns.c version returns a wider integer if --with-wide-int is
2629 specified, so this should help the quality of the hashing a bit.
2630
b312a492
PE
2631 * emacs.c: Integer overflow minor fix.
2632 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2633 Define only if GNU_LINUX.
2634 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2635
dfd153ae
PE
2636 * dispnew.c: Integer signedness and overflow fixes.
2637 Remove unnecessary forward decls, that were a maintenance hassle.
2638 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2639 All uses changed.
2640 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2641 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2642 (prepare_desired_row, line_draw_cost):
2643 Use int, not unsigned, where either works.
2644 (save_current_matrix, restore_current_matrix):
2645 Use ptrdiff_t, not size_t, where either works.
2646 (init_display): Check for overflow more accurately, and without
2647 relying on undefined behavior.
2648
a81d11a3
PE
2649 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2650 Remove, replacing with the new symbols in lisp.h. All uses changed.
2651 * fileio.c (make_temp_name):
2652 * filelock.c (lock_file_1, lock_file):
2653 * xdisp.c (message_dolog):
2654 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2655 Use pMd etc. instead.
2656 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2657 replacing the pWIDE etc. symbols removed from editfns.c.
2658
3300e6fd
PE
2659 * keyboard.h (num_input_events): Now uintmax_t.
2660 This is (very slightly) less likely to mess up due to wraparound.
2661 All uses changed.
2662
fd05c7e9
PE
2663 * buffer.c: Integer signedness fixes.
2664 (alloc_buffer_text, enlarge_buffer_text):
2665 Use ptrdiff_t rather than size_t when either will do, as we prefer
2666 signed integers.
2667
903fe15d
PE
2668 * alloc.c: Integer signedness and overflow fixes.
2669 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2670 (__malloc_size_t): Default to size_t, not to int.
2671 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2672 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2673 Prefer ptrdiff_t to size_t when either would do, as we prefer
2674 signed integers.
2675 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2676 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2677 Now const. Initialize with values that are in range even if char
2678 is signed.
2679 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2680 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2681 These functions do the right thing with sizes > 2**32.
2682 (check_depth): Now ptrdiff_t, not int.
2683 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2684 Adjust to new way of storing sizes. Check for size overflow bugs
2685 in rest of code.
2686 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2687 slightly wrong anyway, as it missed one instance of
2688 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2689 (refill_memory_reserve): Omit needless cast to size_t.
2690 (mark_object_loop_halt): Mark as externally visible.
2691
ac82cc6a
PE
2692 * xselect.c: Integer signedness and overflow fixes.
2693 (Fx_register_dnd_atom, x_handle_dnd_message):
2694 Use ptrdiff_t, not size_t, since we prefer signed.
2695 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2696 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2697 x_dnd_atoms_size and x_dnd_atoms_length.
2698
c2d1e36d
PE
2699 * doprnt.c: Prefer signed to unsigned when either works.
2700 * eval.c (verror):
2701 * doprnt.c (doprnt):
2702 * lisp.h (doprnt):
2703 * xdisp.c (vmessage):
2704 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2705 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2706 prefer signed arithmetic to avoid comparison confusion.
2707 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2708 but is a bit tricky.
2709
0e926e56
PE
2710 Assume freestanding C89 headers, string.h, stdlib.h.
2711 * data.c, doprnt.c, floatfns.c, print.c:
2712 Include float.h unconditionally.
2713 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2714 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2715 * regex.c: Likewise for stddef.h, string.h.
2716 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2717 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2718 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2719 (STDC_HEADERS): Remove obsolete defines.
2720 * sysdep.c: Include limits.h unconditionally.
2721
9cfdb3ec
PE
2722 Assume support for memcmp, memcpy, memmove, memset.
2723 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2724 * regex.c (memcmp, memcpy):
2725 Remove; we assume C89 now.
2726
2727 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2728 (__malloc_safe_bcopy): Remove; no longer needed.
2729
cf950e6b 2730 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2731 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2732 well either way, and we prefer signed to unsigned.
2733
dbf38e02
LMI
27342011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2735
2736 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2737 closes the connection while we're reading (bug#9182).
2738
d6f0886c 27392011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2740
d6f0886c
JD
2741 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2742 are specified (Bug#9168).
24e0f6b1 2743
2eb1f9e6
PE
27442011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2745
2746 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2747 Found by GCC static checking and --with-wide-int on a 32-bit host.
2748
22381272 27492011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2750
2751 * xdisp.c (compute_display_string_pos): Fix logic of caching
2752 previous display string position. Initialize cached_prev_pos to
2753 -1. Fixes slow-down at the beginning of a buffer.
2754
f25e39b4
EZ
27552011-07-24 Eli Zaretskii <eliz@gnu.org>
2756
2757 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2758 for attrs[LFACE_FONTSET_INDEX].
2759
04c4b52e
PE
27602011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2761
2762 * xml.c (parse_region): Remove unused local
2763 that was recently introduced.
2764
c1734fbd
EZ
27652011-07-23 Eli Zaretskii <eliz@gnu.org>
2766
be18c5a5
EZ
2767 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2768 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2769
c1734fbd
EZ
2770 * xdisp.c (move_it_in_display_line_to): Record the best matching
2771 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2772 exit if none of the characters scanned was an exact match.
2773 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2774 when exact match is impossible due to invisible text, and the
2775 lines are truncated.
2776
a258d627
JD
27772011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2778
2779 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2780 for OSX >= 10.7.
2781
b6d5a689
EZ
27822011-07-22 Eli Zaretskii <eliz@gnu.org>
2783
0f74f785
EZ
2784 Fix a significant slow-down of cursor motion with C-n, C-p,
2785 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2786 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2787 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2788 (next_element_from_buffer): Call compute_stop_pos_backwards to
2789 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2790 base_level_stop.
2791 (reseat): Don't look for prev_stop, as that could mean a very long
2792 run.
2793 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2794 <cached_disp_overlay_modiff>: Cache for last found display string
2795 position.
551918c1 2796 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2797 about the same buffer in the same area of character positions, and
2798 the buffer wasn't changed since the time the display string
2799 position was cached.
551918c1 2800
b2d0c91a
EZ
28012011-07-22 Eli Zaretskii <eliz@gnu.org>
2802
2803 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2804 is an integer, which is important for empty lines. (Bug#9149)
2805
043604ee
CY
28062011-07-22 Chong Yidong <cyd@stupidchicken.com>
2807
2808 * frame.c (Fmodify_frame_parameters): In tty case, update the
2809 default face if necessary (Bug#4238).
2810
da4adb04
CY
28112011-07-21 Chong Yidong <cyd@stupidchicken.com>
2812
2813 * editfns.c (Fstring_to_char): No need to explain what a character
2814 is in the docstring (Bug#6576).
2815
9abd0532
LMI
28162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2817
2818 * xml.c (parse_region): Make sure we always return a tree.
2819
36881d16
HK
28202011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2821
2822 * xml.c (parse_region): If a document contains only comments,
2823 return that, too.
2824
1e98674d
LMI
28252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2826
2827 * xml.c (make_dom): Return comments, too.
2828
590bd467
PE
28292011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2830
2831 Port to OpenBSD.
2832 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2833 and the surrounding thread.
2834 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2835 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2836 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2837 timer goes off.
2838 * s/openbsd.h (BROKEN_SIGIO): Define.
2839 * unexelf.c (unexec) [__OpenBSD__]:
2840 Don't update the .mdebug section of the Alpha COFF symbol table.
2841
f41628b2
LMI
28422011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2843
2844 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2845 (bug#8460).
2846
b59b67c5
PE
28472011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2848
15e3a074
PE
2849 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2850 This fixes some race conditions on the permissions of any newly
2851 created file.
2852
41bed37d
PE
2853 * alloc.c (valid_pointer_p): Use pipe, not open.
2854 This fixes some permissions issues when debugging.
2855
b59b67c5
PE
2856 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2857 If fchown fails to set both uid and gid, try to set just gid,
2858 as that is sometimes allowed. Adjust the file's mode to eliminate
2859 setuid or setgid bits that are inappropriate if fchown fails.
2860
925a6be7
SM
28612011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2862
2863 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2864 to compare Lisp_Objects.
2865 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2866 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2867 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2868
52968808
AS
28692011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2870
0a6a104b
AS
2871 * lread.c (read_integer): Unread even EOF character.
2872 (read1): Likewise. Properly record start position of symbol.
2873
52968808
AS
2874 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2875 symbol character follows.
2876
9e381cdd
PE
28772011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2878
2879 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2880 This works around a problem with the previous change to Fcopy_file.
2881 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2882 and without this change, GCC might complain about discarding
2883 fchown's return value.
2884
b5641435
JB
28852011-07-16 Juanma Barranquero <lekktu@gmail.com>
2886
2887 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2888
a8031457
PE
28892011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2890
2891 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2892
dd889327
LMI
28932011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2894
750c33f7
LMI
2895 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2896 it's used from the C level.
2897
dd889327
LMI
2898 * process.c: Use the same condition for POLL_FOR_INPUT in both
2899 keyboard.c and process.c (bug#1858).
2900
87e86684
LM
29012011-07-09 Lawrence Mitchell <wence@gmx.li>
2902
2903 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2904 (Fgnutls_boot): Use it.
2905
64348f40
AS
29062011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2907
2908 * doc.c (Fsubstitute_command_keys): Revert last change.
2909
1d698799
LMI
29102011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2911
f863868c
LMI
2912 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2913 quotes the next character, and doesn't affect other longer
2914 sequences (bug#8935).
2915
1d698799
LMI
2916 * lread.c (syms_of_lread): Clarify that is isn't only
2917 `eval-buffer' and `eval-defun' that's affected by
2918 `lexical-binding' (bug#8460).
2919
aa4b6df6
EZ
29202011-07-15 Eli Zaretskii <eliz@gnu.org>
2921
2922 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2923 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2924
5d856da6
PE
29252011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2926
ad6042bb
PE
2927 Fix minor problems found by static checking.
2928 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2929 (elsz): Now a signed constant, not a size_t var. We prefer signed
2930 types to unsigned, to avoid integer comparison confusion. Without
2931 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2932 "cannot optimize loop, the loop counter may overflow", a symptom
2933 of the confusion.
f00bbb22 2934 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2935 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2936
6468f31c
LMI
29372011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2938
49080b10
LMI
2939 * search.c (Fre_search_backward): Mention `case-fold-search' in
2940 all the re_search_* functions (bug#8138).
2941
6468f31c
LMI
2942 * keyboard.c (Fopen_dribble_file): Document when the file is
2943 closed (bug#8056).
2944
c965adc5
EZ
29452011-07-14 Eli Zaretskii <eliz@gnu.org>
2946
df9733bf
EZ
2947 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2948 bidi_cache_idx.
2949
0bb23927
EZ
2950 Support bidi reordering of display and overlay strings.
2951 * xdisp.c (compute_display_string_pos)
2952 (compute_display_string_end): Accept additional argument STRING.
2953 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2954 (reseat_to_string): Initialize bidi_it->string.s and
2955 bidi_it->string.schars.
2956 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2957 NULL (avoids a crash in bidi_paragraph_init).
2958 Initialize itb.string.lstring.
0bb23927
EZ
2959 (init_iterator): Call bidi_init_it only of a valid
2960 buffer position was specified. Initialize paragraph_embedding to
2961 L2R.
2962 (reseat_to_string): Initialize the bidi iterator.
2963 (display_string): If we need to ignore text properties of
2964 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2965 original value of -1 will not work with bidi.)
2966 (compute_display_string_pos): First arg is now struct
2967 `text_pos *'; all callers changed. Support display properties on
2968 Lisp strings.
2969 (compute_display_string_end): Support display properties on Lisp
2970 strings.
2971 (init_iterator, reseat_1, reseat_to_string): Initialize the
2972 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2973 when iterating on a string not from display properties).
640c8776
SM
2974 (compute_display_string_pos, compute_display_string_end):
2975 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2976 arrow keys.
2977 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2978 base_level_stop; instead, set base_level_stop to BEGV.
2979 Fixes crashes in vertical-motion.
0bb23927
EZ
2980 (next_element_from_buffer): Improve commentary for when
2981 the iterator is before prev_stop.
2982 (init_iterator): Initialize bidi_p from the default value of
2983 bidi-display-reordering, not from buffer-local value. Use the
2984 buffer-local value only if initializing for buffer iteration.
2985 (handle_invisible_prop): Support invisible properties on strings
2986 that are being bidi-reordered.
2987 (set_iterator_to_next): Support bidi reordering of C strings and
2988 Lisp strings.
2989 (next_element_from_string): Support bidi reordering of Lisp
2990 strings.
2991 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2992 (display_string): Support display of R2L glyph rows.
2993 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2994 (init_iterator): Don't initialize it->bidi_p for strings
2995 here.
2996 (reseat_to_string): Initialize it->bidi_p for strings here.
2997 (next_element_from_string, next_element_from_c_string)
2998 (next_element_from_buffer): Add xassert's for correspondence
2999 between IT's object being iterated and it->bidi_it.string
3000 structure.
3001 (face_before_or_after_it_pos): Support bidi iteration.
3002 (next_element_from_c_string): Handle the case of the first string
3003 character that is not the first one in the visual order.
3004 (get_visually_first_element): New function, refactored from common
3005 parts of next_element_from_buffer, next_element_from_string, and
3006 next_element_from_c_string.
3007 (tool_bar_lines_needed, redisplay_tool_bar)
3008 (display_menu_bar): Force left-to-right direction. Add a FIXME
3009 comment for making that be controlled by a user option.
3010 (push_it, pop_it): Save and restore the state of the
3011 bidi iterator. Save and restore the bidi_p flag.
3012 (pop_it): Iterate out of display property for string iteration as
3013 well.
3014 (iterate_out_of_display_property): Support iteration over strings.
3015 (handle_single_display_spec): Set up it->bidi_it for iteration
3016 over a display string, and call bidi_init_it.
3017 (handle_single_display_spec, next_overlay_string)
3018 (get_overlay_strings_1, push_display_prop): Set up the bidi
3019 iterator for displaying display or overlay strings.
3020 (forward_to_next_line_start): Don't use the shortcut if
3021 bidi-iterating.
3022 (back_to_previous_visible_line_start): If handle_display_prop
3023 pushed the iterator stack, restore the internal state of the bidi
3024 iterator by calling bidi_pop_it same number of times.
3025 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3026 and we are bidi-iterating, don't decrement the iterator position;
3027 instead, set the first_elt flag in the bidi iterator, to produce
3028 the same effect.
3029 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3030 (push_display_prop): xassert that we are iterating a buffer.
3031 (push_it, pop_it): Save and restore paragraph_embedding member.
3032 (handle_single_display_spec, next_overlay_string)
3033 (get_overlay_strings_1, reseat_1, reseat_to_string)
3034 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3035 correctly. Don't assume unibyte strings are not bidi-reordered.
3036 (compute_display_string_pos)
3037 (compute_display_string_end): Fix handling the case of C string.
3038 (push_it, pop_it): Save and restore from_disp_prop_p.
3039 (handle_single_display_spec, push_display_prop): Set the
3040 from_disp_prop_p flag.
3041 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3042 (pop_it): Call iterate_out_of_display_property only if we are
3043 popping after iteration over a string that came from a display
3044 property. Fix a typo in popping stretch info. Add an assertion
3045 for verifying that the iterator position is in sync with the bidi
3046 iterator.
3047 (handle_single_display_spec, get_overlay_strings_1)
3048 (push_display_prop): Fix initialization of paragraph direction for
3049 string when that of the parent object is not yet determined.
3050 (reseat_1): Call bidi_init_it to resync the bidi
3051 iterator with IT's position. (Bug#7616)
3052 (find_row_edges): If ROW->start.pos gives position
3053 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3054 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3055 Reset the from_disp_prop_p flag.
3056 (SAVE_IT, RESTORE_IT): New macros.
3057 (pos_visible_p, face_before_or_after_it_pos)
3058 (back_to_previous_visible_line_start)
3059 (move_it_in_display_line_to, move_it_in_display_line)
3060 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3061 (try_scrolling, redisplay_window, display_line): Use them when
3062 saving a temporary copy of the iterator and restoring it back.
3063 (back_to_previous_visible_line_start, reseat_1)
3064 (init_iterator): Empty the bidi cache "stack".
3065 (move_it_in_display_line_to): If iterator ended up at
3066 EOL, but we never saw any buffer positions smaller than
3067 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3068 motion in bidi-reordered lines.
3069 (move_it_in_display_line_to): Record prev_method and prev_pos
3070 immediately before the call to set_iterator_to_next. Fixes cursor
3071 motion in bidi-reordered lines with stretch glyphs and strings
3072 displayed in margins. (Bug#8133) (Bug#8867)
3073 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3074 TO_CHARPOS.
640c8776
SM
3075 (pos_visible_p): Support positions in bidi-reordered lines.
3076 Save and restore bidi cache.
0bb23927
EZ
3077
3078 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3079 (bidi_paragraph_info): Delete unused struct.
3080 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3081 (bidi_cache_start): New variable.
3082 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3083 to zero.
3084 (bidi_cache_fetch_state, bidi_cache_search)
3085 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3086 (bidi_cache_find, bidi_peek_at_next_level)
3087 (bidi_level_of_next_char, bidi_find_other_level_edge)
3088 (bidi_move_to_visually_next): Compare cache index with
3089 bidi_cache_start rather than with zero.
3090 (bidi_fetch_char): Accept new argument STRING; all callers
3091 changed. Support iteration over a string. Support strings with
3092 display properties. Support unibyte strings. Fix the type of
3093 `len' according to what STRING_CHAR_AND_LENGTH expects.
3094 (bidi_paragraph_init, bidi_resolve_explicit_1)
3095 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3096 (bidi_level_of_next_char, bidi_move_to_visually_next):
3097 Support iteration over a string.
0bb23927
EZ
3098 (bidi_set_sor_type, bidi_resolve_explicit_1)
3099 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3100 can now be zero (for strings); special values 0 and -1 were
3101 changed to -1 and -2, respectively.
3102 (bidi_char_at_pos): New function.
3103 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3104 Call it instead of FETCH_MULTIBYTE_CHAR.
3105 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3106 initialized to valid values.
3107 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3108 values.
3109 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3110 the test for valid cached positions. Fix the logic for looking up
3111 the sentinel state in the cache. GCPRO the Lisp string we are
3112 iterating.
3113 (bidi_push_it, bidi_pop_it): New functions.
3114 (bidi_initialize): Initialize the bidi cache start stack pointer.
3115 (bidi_cache_ensure_space): New function, refactored from part of
3116 bidi_cache_iterator_state. Don't assume the required size is just
3117 one BIDI_CACHE_CHUNK away.
3118 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3119 (bidi_count_bytes, bidi_char_at_pos): New functions.
3120 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3121 always valid if bidi_cache_idx is valid.
3122 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3123 is valid if it's going to be used.
3124 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3125 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3126 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3127 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3128 (bidi_find_other_level_edge, bidi_cache_start_stack):
3129 All variables related to cache indices are now EMACS_INT.
c965adc5 3130
0bb23927
EZ
3131 * dispextern.h (struct bidi_string_data): New structure.
3132 (struct bidi_it): New member `string'. Make flag members be 1-bit
3133 fields, and put them last in the struct.
640c8776
SM
3134 (compute_display_string_pos, compute_display_string_end):
3135 Update prototypes.
0bb23927
EZ
3136 (bidi_push_it, bidi_pop_it): Add prototypes.
3137 (struct iterator_stack_entry): New members bidi_p,
3138 paragraph_embedding, and from_disp_prop_p.
3139 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3140 (bidi_shelve_cache, bidi_unshelve_cache):
3141 Declare prototypes.
0bb23927
EZ
3142
3143 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3144 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3145 and vector-like objects.
3146
3147 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3148 cache around display iteration.
3149
3150 * window.c (Fwindow_end, window_scroll_pixel_based)
3151 (displayed_window_lines, Frecenter): Save and restore the bidi
3152 cache around display iteration.
3153
3bbd2265
LMI
31542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3155
3156 * editfns.c (Fdelete_region): Clarify the use of the named
3157 parameters (bug#6788).
3158
adc47434
MR
31592011-07-14 Martin Rudalics <rudalics@gmx.at>
3160
3161 * indent.c (Fvertical_motion): Set and restore w->pointm when
3162 saving and restoring the window's buffer (Bug#9006).
3163
837c31f8
LMI
31642011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3165
3166 * editfns.c (Fstring_to_char): Clarify just what is returned
3167 (bug#6576). Text by Eli Zaretskii.
3168
ac389d0c
JB
31692011-07-13 Juanma Barranquero <lekktu@gmail.com>
3170
3171 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3172
0be0ce47
EZ
31732011-07-13 Eli Zaretskii <eliz@gnu.org>
3174
3175 * buffer.c (mmap_find): Fix a typo.
3176
cd18e7e3
JB
31772011-07-13 Johan Bockgård <bojohan@gnu.org>
3178
3179 Fix execution of x selection hooks.
3180 * xselect.c (Qx_lost_selection_functions)
3181 (Qx_sent_selection_functions): New vars.
3182 (syms_of_xselect): DEFSYM them.
3183 (x_handle_selection_request): Pass Qx_sent_selection_functions
3184 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3185 (x_handle_selection_clear,x_clear_frame_selections):
3186 Pass Qx_lost_selection_functions rather than
3187 Vx_lost_selection_functions to Frun_hook_with_args.
3188
47ea7f44
PE
31892011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3190
ac389d0c 3191 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3192 The old code sometimes used this field without initializing it.
3193
47ea7f44
PE
3194 * alloc.c (gc_sweep): Don't read past end of array.
3195 In theory, the old code could also have corrupted Emacs internals,
3196 though it'd be very unlikely.
3197
bc985c87
AS
31982011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3199
3200 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3201 argument. (Bug#4026)
bc985c87 3202
0cf34688
LMI
32032011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3204
b3dadd76
LMI
3205 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3206 key" (bug#4257).
3207
0cf34688
LMI
3208 * window.c (Fset_window_start): Doc fix (bug#4199).
3209 (Fset_window_hscroll): Ditto.
3210
270768cd
PE
32112011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3212
077e3dda 3213 Fix minor new problems caught by GCC 4.6.1.
270768cd 3214 * term.c (init_tty): Remove unused local.
490011a6 3215 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3216 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3217 not used otherwise.
270768cd 3218
b1f58454
CY
32192011-07-12 Chong Yidong <cyd@stupidchicken.com>
3220
3221 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3222
22b9578d
LMI
32232011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3224
6e70ab07
LMI
3225 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3226 are the mini-buffer and the echo area (bug#3320).
3227
22b9578d
LMI
3228 * term.c (init_tty): Remove support for supdup, c10 and perq
3229 terminals, which are no longer supported (bug#1482).
3230
8974cc9f
JB
32312011-07-10 Johan Bockgård <bojohan@gnu.org>
3232
3233 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3234
a560d974
JD
32352011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3236
3237 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3238 for non-popups (Bug#3642).
3239
1dae0f0a
AS
32402011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3241
268c2c36 3242 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3243 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3244 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3245 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3246 * data.c (fmod): Likewise.
3247 * dispnew.c (swap_glyphs_in_rows): Likewise.
3248 * emacs.c (memory_warning_signal): Likewise.
3249 * floatfns.c (float_error): Likewise.
3250 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3251 (otf_open, font_otf_capability, generate_otf_features)
3252 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3253 Likewise.
3254 * image.c (pbm_read_file): Likewise.
3255 * indent.c (string_display_width): Likewise.
3256 * intervals.c (check_for_interval, search_for_interval)
3257 (inc_interval_count, count_intervals, root_interval)
3258 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3259 * lread.c (defalias): Likewise.
268c2c36 3260 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3261 * regex.c (set_image_of_range_1, set_image_of_range)
3262 (regex_grow_registers): Likewise.
3263 * sysdep.c (strerror): Likewise.
3264 * termcap.c (valid_filename_p, tprint, main): Likewise.
3265 * tparam.c (main): Likewise.
3266 * unexhp9k800.c (run_time_remap, save_data_space)
3267 (update_file_ptrs, read_header, write_header, calculate_checksum)
3268 (copy_file, copy_rest, display_header): Likewise.
3269 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3270 Likewise.
3271 * xdisp.c (check_it): Likewise.
3272 * xfaces.c (register_color, unregister_color, unregister_colors):
3273 Likewise.
3274 * xfns.c (print_fontset_result): Likewise.
3275 * xrdb.c (member, fatal, main): Likewise.
3276
99033785
PE
32772011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3278
3279 Fix minor problems found by static checking (Bug#9031).
3280 * chartab.c (char_table_set_range, map_sub_char_table):
3281 Remove unused locals.
3282 (uniprop_table): Now static.
3283 * composite.c (_work_char): Remove unused static var.
3284
9cb2ac56
JB
32852011-07-09 Juanma Barranquero <lekktu@gmail.com>
3286
3287 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3288
f25661f0
JD
32892011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3290
3291 * gtkutil.c (qttip_cb): Remove code without function.
3292
8278c4fe
EZ
32932011-07-09 Eli Zaretskii <eliz@gnu.org>
3294
3295 * w32.c (pthread_sigmask): New stub.
3296
1692ae2d 32972011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3298
8a6ebd58 3299 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3300 sigprocmask is portable only for single-threaded applications, and
3301 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3302 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3303 (LIBES): Use it.
3304 * callproc.c (Fcall_process):
3305 * process.c (create_process):
3306 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3307 Use pthread_sigmask, not sigprocmask.
123403e4 3308
1b854618
JD
33092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3310
3311 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3312 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3313 wrong (Bug#8591).
3314
3fe4b549
JD
33152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3316
0ce7e563
JD
3317 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3318 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3319 (xg_hide_tooltip): Fix comment.
3320
3fe4b549
JD
3321 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3322 in registerServicesMenuSendTypes.
3323 (validRequestorForSendType): Don't check ns_return_types.
3324
3325 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3326 ns_return_type.
3327
5df75e47
JR
33282011-07-08 Jason Rumney <jasonr@gnu.org>
3329
22610910
JR
3330 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3331 SH_SHOW for hidden windows (Bug#5482).
3332
5df75e47
JR
3333 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3334 frame struct members of non-existent frames (Bug#6284).
3335
699c10bd
JD
33362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3337
4393663b
JD
3338 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3339 variable firstTime not needed on OSX >= 10.6.
3340 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3341 >= 10.5. Use setKnobProportion, setDoubleValue.
3342
3343 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3344 (MAC_OS_X_VERSION_10_5): Define if not defined.
3345 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3346 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3347 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3348
3349 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3350 cString and lossyCString on OSX >= 10.4
3351
58179cce 3352 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3353 sizeToFit on OSX >= 10.2.
3354
3355 * nsimage.m (allocInitFromFile): Don't use deprecated method
3356 bestRepresentationForDevice on OSX >= 10.6.
3357
3358 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3359 to avoid warning.
3360
3361 * emacs.c: Declare unexec_init_emacs_zone.
3362
a63e0781
JD
3363 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3364
699c10bd
JD
3365 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3366
3367 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3368 on svcsMenu (Bug#8842).
3369
3370 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3371 ns_return_types.
3372 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3373
3374 * nsterm.m (QUTF8_STRING): Declare.
3375 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3376 (validRequestorForSendType): Return type is (id).
3377 Change indexOfObjectIdenticalTo to indexOfObject.
3378 Check if we have local selection before returning self (Bug#8842).
3379 (writeSelectionToPasteboard): Put local selection into paste board
3380 if we have a local selection (Bug#8842).
3381 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3382
3383 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3384 (ns_get_local_selection): Declare.
3385
54e10184
LMI
33862011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3387
9888ff71
LMI
3388 * keymap.c (describe_map_tree): Don't insert a double newline at
3389 the end of the buffer (bug#1169) and return whether we inserted
3390 something.
3391
54e10184
LMI
3392 * callint.c (Fcall_interactively): Change "reading args" to
3393 "providing args" to try to clarify what it does (bug#1010).
3394
15fa4783
KH
33952011-07-07 Kenichi Handa <handa@m17n.org>
3396
3397 * composite.c (composition_compute_stop_pos): Ignore a static
3398 composition starting before CHARPOS (Bug#8915).
3399
3400 * xdisp.c (handle_composition_prop): Likewise.
3401
a8815b00
EZ
34022011-07-07 Eli Zaretskii <eliz@gnu.org>
3403
3404 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3405 (Bug#9015)
3406
ef7b981d 34072011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3408
3409 * character.h (unicode_category_t): New enum type.
3410
3411 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3412 (Qchar_code_property_table): New variable.
3413 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3414 (UNIPROP_COMPRESSED_FORM_P): New macros.
3415 (char_table_ascii): Uncompress the compressed values.
3416 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3417 Uncompress the compressed values.
ac389d0c 3418 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3419 (char_table_ref_and_range): Uncompress the compressed values.
3420 (sub_char_table_set): New arg is_uniprop. Callers changed.
3421 Uncompress the compressed values.
3422 (sub_char_table_set_range): Args changed. Callers changed.
3423 (char_table_set_range): Adjuted for the above change.
3424 (map_sub_char_table): Delete args default_val and parent. Add arg
3425 top. Give decoded values to a Lisp function.
640c8776 3426 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3427 values to a Lisp function. Gcpro more variables.
3428 (uniprop_table_uncompress)
3429 (uniprop_decode_value_run_length): New functions.
3430 (uniprop_decoder, uniprop_decoder_count): New variables.
3431 (uniprop_get_decoder, uniprop_encode_value_character)
3432 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3433 New functions.
3434 (uniprop_encoder, uniprop_encoder_count): New variables.
3435 (uniprop_get_encoder, uniprop_table)
3436 (Funicode_property_table_internal, Fget_unicode_property_internal)
3437 (Fput_unicode_property_internal): New functions.
3438 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3439 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3440 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3441 char-code-property-alist.
3442
640c8776 3443 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3444 Vunicode_category_table.
3445
640c8776 3446 * font.c (font_range): Adjust for the change of
c805dec0
KH
3447 Vunicode_category_table.
3448
76b397fb
DN
34492011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3450
3451 * m/iris4d.h: Remove file, move contents ...
3452 * s/irix6-5.h: ... here.
3453
22b4128e
PE
34542011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3455
3456 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3457 * alloc.c (mark_buffer):
3458 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3459 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3460 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3461 This isn't true in general, and it's particularly not true
3462 if Emacs is configured with --with-wide-int.
3463 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3464 New macros, used in the buffer.c change.
3465
869795d6
JD
34662011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3467
3468 * xsettings.c: Use both GConf and GSettings if both are available.
3469 (store_config_changed_event): Add comment.
3470 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3471 (store_tool_bar_style_changed): New functions.
5e617bc2 3472 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3473 (struct xsettings): Move font inside HAVE_XFT.
3474 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3475 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3476 Move inside HAVE_XFT.
640c8776 3477 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3478 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3479 also.
3480 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3481 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3482 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3483 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3484 (parse_settings): Move check for font inside HAVE_XFT.
3485 (read_settings, apply_xft_settings): Add comment.
3486 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3487 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3488 call store_font_name_changed.
3489 (xft_settings_event): Add comment.
3490 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3491 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3492 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3493 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3494 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3495 (xsettings_get_system_font, xsettings_get_system_normal_font):
3496 Add comment.
869795d6 3497
d8ed26bd
PE
34982011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3499
3500 Random fixes. E.g., (random) never returned negative values.
3501 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3502 subseconds part to the entropy, as that's a bit more random.
3503 Prefer signed to unsigned, since the signedness doesn't matter and
3504 in general we prefer signed. When given a limit, use a
3505 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3506 latter isn't right if USE_2_TAGS_FOR_INTS.
3507 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3508 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3509
cabf1cac
SM
35102011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3511
3512 * textprop.c (text_property_stickiness):
3513 Obey Vtext_property_default_nonsticky.
3514 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3515 * w32fns.c (syms_of_w32fns):
3516 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3517
6e9b2be9
PE
35182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3519
3520 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3521 This is more efficient than Ffile_directory_p and avoids a minor race.
3522
90186c68
LMI
35232011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3524
7c301272
LMI
3525 * buffer.c (Foverlay_put): Say what the return value is
3526 (bug#7835).
3527
c4f2d8d4
LMI
3528 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3529 is a directory before asking whether to use the file name
3530 (bug#7564).
ad637907
LMI
3531 (barf_or_query_if_file_exists): Make the "File is a directory"
3532 error be more correct.
c4f2d8d4 3533
90186c68
LMI
3534 * fns.c (Frequire): Remove the mention of the .gz files, since
3535 that's installation-specific, but keep the mention of
3536 `get-load-suffixes'.
3537
da64016e
PE
35382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3539
3540 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3541 Report string overflow if the output is too long.
3542
7d47b580
JB
35432011-07-04 Juanma Barranquero <lekktu@gmail.com>
3544
a555cb87
JB
3545 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3546 (syms_of_gnutls): Remove duplicate DEFSYM for
3547 Qgnutls_bootprop_verify_hostname_error, an error for
3548 Qgnutls_bootprop_verify_error (which is no longer used).
3549
7d47b580
JB
3550 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3551 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3552 Also (re)move comments that are misplaced or no longer relevant.
3553
1e49bfab
LMI
35542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3555
3556 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3557
1485f4c0
CY
35582011-07-03 Chong Yidong <cyd@stupidchicken.com>
3559
3560 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3561 and background color parameters if they have been changed.
3562
a9ab721e
LMI
35632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3564
3565 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3566
cf7cff57
PE
35672011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3568
2e13213d
PE
3569 * xsettings.c (SYSTEM_FONT): Define only when used.
3570 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3571
cf7cff57
PE
3572 * keymap.c (access_keymap_1): Now static.
3573
7a8e04f7
CY
35742011-07-02 Chong Yidong <cyd@stupidchicken.com>
3575
3576 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3577 leave any prefix arg for the up event (Bug#1586).
3578
61352f62
LMI
35792011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3580
69bb1ef7
LMI
3581 * lread.c (syms_of_lread): Mention single symbols defined by
3582 `defvar' or `defconst' (bug#7154).
3583
61352f62 3584 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3585 (Frequire): Mention get-load-suffixes.
61352f62 3586
28545e04
MR
35872011-07-02 Martin Rudalics <rudalics@gmx.at>
3588
3589 * window.h (window): Remove clone_number slot.
3590 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3591 Remove.
3592 (make_parent_window, make_window, saved_window)
3593 (Fset_window_configuration, save_window_save): Don't deal with
3594 clone numbers.
3595 * buffer.c (Qclone_number): Remove declaration.
3596 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3597
3349e122
SM
35982011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3599
3600 Add multiple inheritance to keymaps.
3601 * keymap.c (Fmake_composed_keymap): New function.
3602 (Fset_keymap_parent): Simplify.
3603 (fix_submap_inheritance): Remove.
3604 (access_keymap_1): New function extracted from access_keymap to handle
3605 embedded parents and handle lists of maps.
3606 (access_keymap): Use it.
3607 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3608 (Fcopy_keymap): Handle embedded parents.
3609 (Fcommand_remapping, define_as_prefix): Simplify.
3610 (Fkey_binding): Simplify.
3611 (syms_of_keymap): Move minibuffer-local-completion-map,
3612 minibuffer-local-filename-completion-map,
3613 minibuffer-local-must-match-map, and
3614 minibuffer-local-filename-must-match-map to Elisp.
3615 (syms_of_keymap): Defsubr make-composed-keymap.
3616 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3617 (parse_menu_item): Trivial simplification.
3618
3279eb87
GM
36192011-07-01 Glenn Morris <rgm@gnu.org>
3620
3621 * Makefile.in (SETTINGS_LIBS): Fix typo.
3622
4550efdf
KI
36232011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3624
3625 * coding.c (Fencode_coding_string): Record the last coding system
3626 used, as the function doc string says (bug#8738).
3627
0949d2b6
JD
36282011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3629
3630 * xsettings.c (store_monospaced_changed): Take new font as arg and
3631 check for change against current_mono_font.
3632 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3633 (emacs_settings_constructor, emacs_settings_get_property)
3634 (emacs_settings_set_property, emacs_settings_class_init)
3635 (emacs_settings_init, gsettings_obj): Remove.
3636 (something_changedCB): New function for HAVE_GSETTINGS.
3637 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3638 with value as argument.
3639 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3640 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3641 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3642 "changed".
3643
3644 * xgselect.c: Add defined (HAVE_GSETTINGS).
3645 (xgselect_initialize): Ditto.
3646
3647 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3648 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3649 xg_select.
3650
bbc6b304
PE
36512011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3652
3653 * eval.c (struct backtrace): Simplify and port the data structure.
3654 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3655 signed bit field, as this assumption is not portable and it makes
3656 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3657 "char debug_on_exit : 1" as this is not portable either; instead,
3658 use the portable "unsigned int debug_on_exit : 1". Remove unused
3659 member evalargs. Remove obsolete comments about cc bombing out.
3660
9851bfc5
JD
36612011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3662
51bb811f 3663 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3664 Let HAVE_GSETTINGS override HAVE_GCONF.
3665 (store_monospaced_changed): New function.
3666 (EMACS_SETTINGS): A new type derived from GObject to handle
3667 GSettings notifications.
3668 (emacs_settings_constructor, emacs_settings_get_property)
3669 (emacs_settings_set_property, emacs_settings_class_init):
3670 New functions.
3671 (gsettings_client, gsettings_obj): New variables.
3672 (GSETTINGS_SCHEMA): New define.
3673 (something_changedCB): Call store_monospaced_changed.
3674 (init_gsettings): New function.
3675 (xsettings_initialize): Call init_gsettings.
3676 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3677 to NULL.
3678
640c8776 3679 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3680 GCONF_CFLAGS/LIBS.
3681
5386012d
MR
36822011-06-29 Martin Rudalics <rudalics@gmx.at>
3683
3684 * window.c (resize_root_window, grow_mini_window)
3685 (shrink_mini_window): Rename Qresize_root_window to
3686 Qwindow_resize_root_window and Qresize_root_window_vertically to
3687 Qwindow_resize_root_window_vertically.
3688
f13e0b08
PE
36892011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3690
3691 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3692
94515237
JB
36932011-06-27 Juanma Barranquero <lekktu@gmail.com>
3694
3695 * makefile.w32-in: Redesign dependencies so they reflect more
3696 clearly which files are directly included by each source file,
3697 and not through other includes.
3698
e43b6e43
MR
36992011-06-27 Martin Rudalics <rudalics@gmx.at>
3700
3701 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3702 (sort_overlays, overlay_strings): When an overlay's clone number
3703 matches the window's clone number process the overlay even if
3704 the overlay's window property doesn't match the current window.
3705
d68443dc
MR
3706 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3707 (Fwindow_hchild): Rename to Fwindow_left_child.
3708 (Fwindow_next): Rename to Fwindow_next_sibling.
3709 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3710 (resize_window_check): Rename to window_resize_check.
3711 (resize_window_apply): Rename to window_resize_apply.
3712 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3713 (Fdelete_other_windows_internal, resize_frame_windows)
3714 (Fsplit_window_internal, Fdelete_window_internal)
3715 (grow_mini_window, shrink_mini_window)
3716 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3717
c7e73be5
JD
37182011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3719
3720 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3721 (emacs_fixed_set_min_size): Remove.
3722 (emacs_fixed_new): Take frame as argument.
3723
3724 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3725 (_EmacsFixedPrivate): Remove minwidth/height.
3726 Add struct frame *f.
3727 (emacs_fixed_init): Initialize priv->f.
3728 (get_parent_class, emacs_fixed_set_min_size): Remove.
3729 (emacs_fixed_new): Set priv->f to argument.
3730 (emacs_fixed_get_preferred_width)
3731 (emacs_fixed_get_preferred_height): Use min_width/height from
3732 frames size_hint to set minimum and natural (Bug#8919).
3733 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3734 and use min_width/height from frames size_hint to set
3735 min_width/height (Bug#8919).
3736
3737 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3738 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3739 Fix indentation.
c7e73be5 3740
cf99dcf8
EZ
37412011-06-26 Eli Zaretskii <eliz@gnu.org>
3742
3743 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3744 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3745 called at ZV.
3746
029529ac
CY
37472011-06-26 Chong Yidong <cyd@stupidchicken.com>
3748
3749 * process.c (wait_reading_process_output): Bypass select if
3750 waiting for a cell while ignoring keyboard input, and input is
3751 pending. Suggested by Jan Djärv (Bug#8869).
3752
7a7ef429
PE
37532011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3754
3755 Use gnulib's dup2 module instead of rolling our own.
3756 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3757
11fdef7d 37582011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3759
3760 * dispnew.c (scrolling_window): Before scrolling, turn off a
3761 mouse-highlight in the window being scrolled.
3762
cd3520a4
JB
37632011-06-24 Juanma Barranquero <lekktu@gmail.com>
3764
3765 Move DEFSYM to lisp.h and use everywhere.
3766
3767 * character.h (DEFSYM): Move declaration...
3768 * lisp.h (DEFSYM): ...here.
3769
3770 * gnutls.c:
3771 * minibuf.c:
3772 * w32menu.c:
3773 * w32proc.c:
3774 * w32select.c: Don't include character.h.
3775
3776 * alloc.c (syms_of_alloc):
3777 * buffer.c (syms_of_buffer):
3778 * bytecode.c (syms_of_bytecode):
3779 * callint.c (syms_of_callint):
3780 * casefiddle.c (syms_of_casefiddle):
3781 * casetab.c (init_casetab_once):
3782 * category.c (init_category_once, syms_of_category):
3783 * ccl.c (syms_of_ccl):
3784 * cmds.c (syms_of_cmds):
3785 * composite.c (syms_of_composite):
3786 * dbusbind.c (syms_of_dbusbind):
3787 * dired.c (syms_of_dired):
3788 * dispnew.c (syms_of_display):
3789 * doc.c (syms_of_doc):
3790 * editfns.c (syms_of_editfns):
3791 * emacs.c (syms_of_emacs):
3792 * eval.c (syms_of_eval):
3793 * fileio.c (syms_of_fileio):
3794 * fns.c (syms_of_fns):
3795 * frame.c (syms_of_frame):
3796 * fringe.c (syms_of_fringe):
3797 * insdel.c (syms_of_insdel):
3798 * keymap.c (syms_of_keymap):
3799 * lread.c (init_obarray, syms_of_lread):
3800 * macros.c (syms_of_macros):
3801 * msdos.c (syms_of_msdos):
3802 * print.c (syms_of_print):
3803 * process.c (syms_of_process):
3804 * search.c (syms_of_search):
3805 * sound.c (syms_of_sound):
3806 * syntax.c (init_syntax_once, syms_of_syntax):
3807 * terminal.c (syms_of_terminal):
3808 * textprop.c (syms_of_textprop):
3809 * undo.c (syms_of_undo):
3810 * w32.c (globals_of_w32):
3811 * window.c (syms_of_window):
3812 * xdisp.c (syms_of_xdisp):
3813 * xfaces.c (syms_of_xfaces):
3814 * xfns.c (syms_of_xfns):
3815 * xmenu.c (syms_of_xmenu):
3816 * xsettings.c (syms_of_xsettings):
3817 * xterm.c (syms_of_xterm): Use DEFSYM.
3818
4228cf16
TZ
38192011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3820
cd3520a4 3821 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3822
7fcccf1e
PE
38232011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3824
7efb4e0e
PE
3825 Integer and buffer overflow fixes (Bug#8873).
3826
ff5844ad
PE
3827 * print.c (printchar, strout): Check for string overflow.
3828 (PRINTPREPARE, printchar, strout):
3829 Don't set size unless allocation succeeds.
3830
90532f02
PE
3831 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3832 for sizes. Check for string overflow more accurately.
3833 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3834
6d84508d
PE
3835 * macros.c: Integer and buffer overflow fixes.
3836 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3837 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3838 Use ptrdiff_t, not int, for sizes.
3839 Don't increment bufsize until after realloc succeeds.
3840 Check for size-calculation overflow.
3841 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3842
437b2cb4
PE
3843 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3844
8b9ac8b4
PE
3845 * lread.c: Integer overflow fixes.
3846 (read_integer): Radix is now EMACS_INT, not int,
3847 to improve quality of diagnostics for out-of-range radices.
3848 Calculate buffer size correctly for out-of-range radices.
3849 (read1): Check for integer overflow in radices, and in
3850 read-circle numbers.
82cb60d3
PE
3851 (read_escape): Avoid int overflow.
3852 (Fload, openp, read_buffer_size, read1)
3853 (substitute_object_recurse, read_vector, read_list, map_obarray):
3854 Use ptrdiff_t, not int, for sizes.
3855 (read1): Use EMACS_INT, not int, for sizes.
20270765 3856 Check for size overflow.
8b9ac8b4 3857
7fcccf1e
PE
3858 * image.c (cache_image): Check for size arithmetic overflow.
3859
bfbbd7e7
PE
3860 * lread.c: Integer overflow issues.
3861 (saved_doc_string_size, saved_doc_string_length)
3862 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3863 Now ptrdiff_t, not int.
3864 (read1): Don't assume doc string length fits in int. Check for
3865 out-of-range doc string lengths.
3866 (read_list): Don't assume file position fits in int.
39019e54 3867 (read_escape): Check for hex character overflow.
bfbbd7e7 3868
4e323265
LL
38692011-06-22 Leo Liu <sdl.web@gmail.com>
3870
3871 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3872 Move to minibuffer.el.
3873
85fece3e
PE
38742011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3875
20b84ce9 3876 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3877 The following patches are for when GLYPH_DEBUG && !XASSERT.
3878 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3879 * dispnew.c (flush_stdout):
3880 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3881 Mark as externally visible.
3882 * dispnew.c (check_window_matrix_pointers): Now static.
3883 * dispnew.c (window_to_frame_vpos):
3884 * xfns.c (unwind_create_frame):
3885 * xterm.c (x_check_font): Remove unused local.
3886 * scroll.c (CHECK_BOUNDS):
3887 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3888 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3889 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3890 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3891 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3892 Now static.
3893 (debug_method_add): Use va_list and vsprintf rather than relying
3894 on undefined behavior with wrong number of arguments.
3895 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3896 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3897 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3898 since we're not interested in debugging glyphs with old libraries.
3899 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3900 GCC 4.6.0's static checking.
3901
0766b489
PE
39022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3903
31fd4b32
PE
3904 Integer overflow and signedness fixes (Bug#8873).
3905 A few related buffer overrun fixes, too.
3906
b79e8648
PE
3907 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3908
0766b489
PE
3909 * dispextern.h (struct face.stipple):
3910 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3911 (x_bitmap_mask, x_allocate_bitmap_record)
3912 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3913 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3914 (x_create_bitmap_from_xpm_data):
3915 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3916 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3917 (.bitmaps_last):
3918 * xfaces.c (load_pixmap):
3919 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3920 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3921 (.bitmaps_last, struct x_output.icon_bitmap):
3922 Use ptrdiff_t, not int, for bitmap indexes.
3923 (x_allocate_bitmap_record): Check for size overflow.
3924 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3925
b081724f
PE
3926 Use ptrdiff_t, not int, for overlay counts.
3927 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3928 * editfns.c (overlays_around, get_pos_property):
3929 * textprop.c (get_char_property_and_overlay):
3930 * xdisp.c (next_overlay_change, note_mouse_highlight):
3931 * xfaces.c (face_at_buffer_position):
21514da7
PE
3932 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3933 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3934 (Fnext_overlay_change, Fprevious_overlay_change)
3935 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3936 Use ptrdiff_t, not int, for sizes.
21514da7 3937 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3938
3de73e5e
PE
3939 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3940
2606c57b
PE
3941 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3942 (x_session_initialize): Do not assume string length fits in int.
3943
aaafe47a
PE
3944 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3945 This is unlikely, but can occur if DPI is outlandish.
3946
2674ddc8 3947 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3948 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3949
28154962
PE
3950 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3951 * xrdb.c (magic_file_p, search_magic_path):
3952 Omit last arg SUFFIX; it was always 0. All callers changed.
3953 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3954
7de51af5
PE
3955 * xfont.c (xfont_match): Avoid need for strlen.
3956
25ed6cc3
PE
3957 * xfns.c: Don't assume strlen fits in int.
3958 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3959
4eab31dd
PE
3960 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3961 not unsigned long, as we prefer signed integers. All callers changed.
3962 Detect integer overflow in repeat count.
3963 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3964 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3965
171e2a58
PE
3966 * termcap.c: Don't assume sizes fit in int and never overflow.
3967 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3968 (gobble_line): Check for size-calculation overflow.
3969
ad39faca 3970 * minibuf.c (Fread_buffer):
6e5bb2dc 3971 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3972 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3973 Don't assume string length fits in int.
3974
52c61c22 3975 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3976 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3977
b5b8c9e5
PE
3978 * font.c: Don't assume string length fits in int.
3979 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3980 Use ptrdiff_t, not int.
ccd6111c
PE
3981 (font_intern_prop): Don't assume string length fits in int.
3982 Don't assume integer property fits in fixnum.
3983 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3984
882f0d81 3985 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3986 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3987 Reformulate so as not to need the command string.
3988 Invoke gzip -cd rather than gunzip, as it's more portable.
3989 (lock_info_type, lock_file_1, lock_file):
3990 Don't assume pid_t and time_t fit in unsigned long.
3991 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3992 (current_lock_owner): Prefer signed type for sizes.
3993 Use memcpy, not strncpy, where memcpy is what is really wanted.
3994 Don't assume (via atoi) that time_t and pid_t fit in int.
3995 Check for time_t and/or pid_t out of range, e.g., via a network share.
3996 Don't alloca where an auto var works fine.
3997
93f4cf88
PE
3998 * fileio.c: Fix some integer overflow issues.
3999 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4000 Don't assume string length fits in int.
4001 (directory_file_name): Don't assume string length fits in long.
4002 (make_temp_name): Don't assume pid fits in int, or that its print
4003 length is less than 20.
4004
f3e92b69
PE
4005 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4006
1bfdaf10
PE
4007 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4008
35016e9a
PE
4009 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4010
3d1e65a1
PE
4011 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4012 We prefer signed integers, even for size calculations.
4013
0b963a93
PE
4014 * emacs.c: Don't assume string length fits in 'int'.
4015 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4016 (main): Don't invoke strlen when not needed.
4017
573f4b54
PE
4018 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4019 (XD_DEBUG_MESSAGE): Don't waste a byte.
4020
989f33ba
PE
4021 * callproc.c (getenv_internal_1, getenv_internal)
4022 (Fgetenv_internal):
965d34eb
PE
4023 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4024
e4d29b33
PE
4025 * lread.c (invalid_syntax): Omit length argument.
4026 All uses changed. This doesn't fix a bug, but it simplifies the
4027 code away from its former Hollerith-constant appearance, and it's
4028 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4029 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4030
eb49b136
PE
4031 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4032 This didn't break anything, but it didn't help either.
4033 It's confusing to put a bogus integer in a place where the actual
4034 value does not matter.
9f62aeb1 4035 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4036 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4037
15375a22
PE
4038 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4039 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4040 implementation.
b61cc01c
PE
4041 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4042 We prefer signed types, and the value cannot exceed the EMACS_INT
4043 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4044 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4045 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4046 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4047
53b2623d
PE
4048 * indent.c (sane_tab_width): New function.
4049 (current_column, scan_for_column, Findent_to, position_indentation)
4050 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4051 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4052
51cab52b 4053 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4054
f2ed8a70
PE
4055 * lisp.h (lint_assume): New macro.
4056 * composite.c (composition_gstring_put_cache):
4057 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4058
abe80cc6
PE
4059 * editfns.c, insdel.c:
4060 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4061
b02c740e
PE
4062 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4063
ebc96716
PE
4064 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4065
b4e50fa0 4066 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4067 Use much-faster test for byte-length change.
311d5d7c 4068 Don't assume string byte-length fits in 'int'.
a4cf38e4 4069 Check that character arg fits in 'int'.
85461888 4070 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4071
c0c1ee9f
PE
4072 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4073
a498d7f4
PE
4074 * fns.c (concat): Catch string overflow earlier.
4075 Do not rely on integer wraparound.
4076
51cab52b
PE
4077 * dispextern.h (struct it.overlay_strings_charpos)
4078 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4079 * xdisp.c (forward_to_next_line_start)
4080 (back_to_previous_visible_line_start)
4081 (reseat_at_next_visible_line_start, next_element_from_buffer):
4082 Don't arbitrarily truncate the value of 'selective' to int.
4083
76031fad
PE
4084 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4085
5eb55db9
PE
4086 * composite.c: Don't truncate sizes to 'int'.
4087 (composition_gstring_p, composition_reseat_it)
4088 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4089 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4090 not EMACS_UINT, for indexes.
5eb55db9 4091
0703a717
PE
4092 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4093
d6202519
PE
4094 * buffer.c: Include <verify.h>.
4095 (struct sortvec.priority, struct sortstr.priority):
8961a454 4096 Now EMACS_INT, not int.
c20998a7 4097 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4098 (struct sortstr.size, record_overlay_string)
4099 (struct sortstrlist.size, struct sortlist.used):
4100 Don't truncate size to int.
4101 (record_overlay_string): Check for size-calculation overflow.
d6202519 4102 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4103
d5a19415
JM
41042011-06-22 Jim Meyering <meyering@redhat.com>
4105
029529ac 4106 Don't leak an XBM-image-sized buffer
d5a19415
JM
4107 * image.c (xbm_load): Free the image buffer after using it.
4108
a9041e6c
PE
41092011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4110
4111 Port to Sun C.
4112 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4113 that Sun C diagnosed.
4114 * fns.c (secure_hash): Fix pointer signedness issue.
4115 * intervals.c (static_offset_intervals): New function.
4116 (offset_intervals): Use it.
4117
7f3f739f
LL
41182011-06-21 Leo Liu <sdl.web@gmail.com>
4119
4120 * deps.mk (fns.o):
4121 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4122 sha512.h.
4123
4124 * fns.c (secure_hash): Rename from crypto_hash_function and change
4125 the first arg to accept symbols.
5b66d427 4126 (Fsecure_hash): New primitive.
7f3f739f
LL
4127 (syms_of_fns): New symbols.
4128
76147d94
DD
41292011-06-20 Deniz Dogan <deniz@dogan.se>
4130
4131 * process.c (Fset_process_buffer): Clarify return value in
4132 docstring.
4133
7d7d0045
CY
41342011-06-18 Chong Yidong <cyd@stupidchicken.com>
4135
4136 * dispnew.c (add_window_display_history): Use BVAR.
4137
4138 * xdisp.c (debug_method_add): Use BVAR.
4139 (check_window_end, dump_glyph_matrix, dump_glyph)
4140 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4141
4142 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4143 Likewise.
4144
4145 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4146 check till after the cache is created in init_frame_faces.
4147
ff2bc410
SM
41482011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4149
4150 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4151
28177add
PE
41522011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4153
dd3482fe
PE
4154 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4155 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4156 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4157
393d71f3 4158 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4159 * fileio.c (Finsert_file_contents):
4160 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4161 Remove the old (too-loose) buffer overflow checks.
4162 They weren't needed, since make_gap checks for buffer overflow.
4163 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4164 The old code merely checked for Emacs fixnum overflow, and relied
4165 on undefined (wraparound) behavior. The new code avoids undefined
4166 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4167
2e6813b0 4168 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4169 Tune. Don't use wider integers than needed. Don't use alloca.
4170 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4171
599a9e4f
PE
4172 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4173
99561444
PE
4174 * insdel.c, lisp.h (buffer_overflow): New function.
4175 (insert_from_buffer_1, replace_range, replace_range_2):
4176 * insdel.c (make_gap_larger):
4177 * editfns.c (Finsert_char):
4178 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4179
28177add
PE
4180 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4181
e69dafad
PE
41822011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4183
a7af7fde 4184 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4185
b1c46f02
PE
4186 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4187 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4188
e69dafad
PE
4189 * fileio.c: Don't assume EMACS_INT fits in off_t.
4190 (emacs_lseek): New static function.
4191 (Finsert_file_contents, Fwrite_region): Use it.
4192 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4193
566684ea
PE
4194 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4195
e6966cd6
PE
4196 * fns.c: Don't overflow int when computing a list length.
4197 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4198 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4199 truncation on 64-bit hosts. Check for QUIT every
4200 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4201 faster and is responsive enough.
4202 (Flength): Report an error instead of overflowing an integer.
4203 (Fsafe_length): Return a float if the value is not representable
4204 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4205 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4206 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4207
dd0b0efb
PE
4208 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4209 (header_size, word_size): New constants.
4210 (allocate_vectorlike): Don't check size overflow here.
4211 (allocate_vector): Check it here instead, since this is the only
4212 caller of allocate_vectorlike that could cause overflow.
4213 Check that the new vector's length is representable as a fixnum.
4214
86fe5cfe
PE
4215 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4216 The previous code was bogus. For example, next_almost_prime (32)
4217 returned 39, which is undesirable as it is a multiple of 3; and
4218 next_almost_prime (24) returned 25, which is a multiple of 5 so
4219 why was the code bothering to check for multiples of 7?
4220
80e88859
PE
4221 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4222
4a2f0ad6
PE
4223 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4224
f66c7cf8
PE
4225 Variadic C functions now count arguments with ptrdiff_t.
4226 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4227 Back then I didn't know that the Emacs coding style prefers signed int.
4228 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4229 were being counted with int, which may truncate counts on 64-bit
4230 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4231 * lisp.h (struct Lisp_Subr.function.aMANY)
4232 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4233 Arg counts are now ptrdiff_t, not size_t.
4234 All variadic functions and their callers changed accordingly.
4235 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4236 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4237 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4238 * callint.c (Fcall_interactively): Check arg count for overflow,
4239 to avoid potential buffer overrun. Use signed char, not 'int',
4240 for 'varies' array, so that we needn't bother to check its size
4241 calculation for overflow.
4242 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4243 * eval.c (apply_lambda):
4244 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4245 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4246 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4247
a1759b76
PE
4248 * callint.c (Fcall_interactively): Don't use index var as event count.
4249
d96be9fc
PE
4250 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4251 * mem-limits.h (SIZE): Remove; no longer used.
4252
a690a978 4253 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4254
578c21e6
PE
4255 Remove unnecessary casts.
4256 * xterm.c (x_term_init):
4257 * xfns.c (x_set_border_pixel):
4258 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4259 These aren't needed now that we assume ANSI C.
4260
96f53c6c
PE
4261 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4262 It's more likely to cause problems (due to unsigned overflow)
4263 than to cure them.
4264
83c77d31
PE
4265 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4266
ee2079f1
PE
4267 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4268
6da65536
PE
4269 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4270
7147c4a4
PE
4271 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4272
193e32d9
PE
4273 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4274
e5533da6
PE
4275 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4276
9910e595
PE
4277 GLYPH_CODE_FACE returns EMACS_INT, not int.
4278 * dispextern.h (merge_faces):
4279 * xfaces.c (merge_faces):
01103c44
PE
4280 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4281 Don't assume EMACS_INT fits in int.
9910e595 4282
2638320e
PE
4283 * character.h (CHAR_VALID_P): Remove unused parameter.
4284 * fontset.c, lisp.h, xdisp.c: All uses changed.
4285
045eb8d9
PE
4286 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4287
c1f134b5
PE
4288 * fns.c (concat): Minor tuning based on overflow analysis.
4289 This doesn't fix any bugs. Use int to hold character, instead
4290 of constantly refetching from Emacs object. Use XFASTINT, not
4291 XINT, for value known to be a character. Don't bother comparing
4292 a single byte to 0400, as it's always less.
4293
395fcb93 4294 * floatfns.c (Fexpt):
327eeec8
PE
4295 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4296
abbd3d23
PE
4297 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4298 for characters.
4299
684a03ef
PE
4300 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4301
0fed43f3
PE
4302 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4303 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4304 incorrectly succeed when S was a string, because 4294967386 was
4305 truncated before it was used.
4306
8fd02eb7
PE
4307 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4308 Otherwise, an out-of-range integer could cause undefined behavior
4309 on a 64-bit host.
4310
f8c86b69
PE
4311 * composite.c: Use int, not EMACS_INT, for characters.
4312 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4313 EMACS_INT, for values that are known to be in character range.
4314 This doesn't fix any bugs but is the usual style inside Emacs and
4315 may generate better code on 32-bit machines.
4316
34206dd2
PE
4317 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4318 This is for reasons similar to the recent CHAR_STRING fix.
4319 * charset.c (Fencode_char): Check that character arg is actually
4320 a character. Pass an int to ENCODE_CHAR.
4321 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4322 wider than 'int', as a compile-time check to prevent future regressions
4323 in this area.
4324
c5958d4c 4325 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4326
4327 Make sure a 64-bit char is never passed to CHAR_STRING.
4328 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4329 by silently ignoring the top 32 bits, allowing some values
4330 that were far too large to be valid characters.
4331 * character.h: Include <verify.h>.
4332 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4333 arguments are no wider than unsigned, as a compile-time check
4334 to prevent future regressions in this area.
4335 * data.c (Faset):
01103c44 4336 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4337 (Fsubst_char_in_region):
4338 * fns.c (concat):
4339 * xdisp.c (decode_mode_spec_coding):
4340 Adjust to CHAR_STRING's new requirement.
4341 * editfns.c (Finsert_char, Fsubst_char_in_region):
4342 * fns.c (concat): Check that character args are actually
4343 characters. Without this test, these functions did the wrong
4344 thing with wildly out-of-range values on 64-bit hosts.
4345
d37ca623
PE
4346 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4347 These casts should not be needed on 32-bit hosts, either.
4348 * keyboard.c (read_char):
4349 * lread.c (Fload): Remove casts to unsigned.
4350
ea204efb
PE
4351 * lisp.h (UNSIGNED_CMP): New macro.
4352 This fixes comparison bugs on 64-bit hosts.
4353 (ASCII_CHAR_P): Use it.
4354 * casefiddle.c (casify_object):
01103c44 4355 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4356 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4357 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4358 * dispextern.h (FACE_FROM_ID):
4359 * keyboard.c (read_char): Use UNSIGNED_CMP.
4360
41cb286c
PE
4361 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4362 not to EMACS_INT, to avoid GCC warning.
4363
4a1b9832
PE
4364 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4365
55daad71
PE
4366 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4367 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4368 isn't needed on 32-bit machines.
8f95c75c 4369
01103c44
PE
4370 * buffer.c (Fgenerate_new_buffer_name):
4371 Use EMACS_INT for count, not int.
0ceccced 4372 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4373
4374 * data.c (Qcompiled_function): Now static.
4375
c6f072e7
PE
4376 * window.c (window_body_lines): Now static.
4377
20ce5912
PE
4378 * image.c (gif_load): Rename local to avoid shadowing.
4379
9c4c5f81
PE
4380 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4381 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4382 * alloc.c (make_save_value): Integer argument is now of type
4383 ptrdiff_t, not int.
4384 (mark_object): Use ptrdiff_t, not int.
4385 * lisp.h (pD): New macro.
4386 * print.c (print_object): Use it.
4387
c0c5c8ae
PE
4388 * alloc.c: Use EMACS_INT, not int, to count objects.
4389 (total_conses, total_markers, total_symbols, total_vector_size)
4390 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4391 (total_free_floats, total_floats, total_free_intervals)
4392 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4393 Now EMACS_INT, not int. All uses changed.
4394 (Fgarbage_collect): Compute overall total using a double, so that
4395 integer overflow is less likely to be a problem. Check for overflow
4396 when converting back to an integer.
5a25e253
PE
4397 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4398 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4399 These were 'int' variables that could overflow on 64-bit hosts;
4400 they were never used, so remove them instead of repairing them.
211a0b2a 4401 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4402 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4403 Previously, this ceilinged at INT_MAX, but that doesn't work on
4404 64-bit machines.
e46bb31a 4405 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4406
c78baabf 4407 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4408 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4409 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4410 when a (possibly-narrower) signed value would do just as well.
4411 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4412
c9d624c6
PE
4413 * alloc.c: Catch some string size overflows that we were missing.
4414 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4415 for convenience in STRING_BYTES_MAX.
4416 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4417 The definition here is exact; the one in lisp.h was approximate.
4418 (allocate_string_data): Check for string overflow. This catches
4419 some instances we weren't catching before. Also, it catches
4420 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4421 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4422 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4423
c9d624c6
PE
4424 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4425 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4426 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4427
353032ce
PE
4428 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4429
2bccce07
PE
4430 * alloc.c (Fmake_string): Check for out-of-range init.
4431
0ac30604
SM
44322011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4433
4434 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4435
c195f2de
JD
44362011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4437
4438 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4439 xg_get_default_scrollbar_width.
4440
4441 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4442 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4443 (style_changed_cb): Call update_theme_scrollbar_width and call
4444 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4445 all frames (Bug#8505).
4446 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4447 Call gtk_window_set_resizable if HAVE_GTK3.
4448 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4449 and height if HAVE_GTK3 (Bug#8505).
4450 (scroll_bar_width_for_theme): New variable.
4451 (update_theme_scrollbar_width): New function.
4452 (xg_get_default_scrollbar_width): Move code to
4453 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4454 (xg_initialize): Call update_theme_scrollbar_width.
4455
4456 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4457
4458 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4459
e10ac9f1
MR
44602011-06-12 Martin Rudalics <rudalics@gmx.at>
4461
4462 * frame.c (make_frame): Call other_buffer_safely instead of
4463 other_buffer.
4464
4465 * window.c (temp_output_buffer_show): Call display_buffer with
4466 second argument Vtemp_buffer_show_specifiers and reset latter
4467 immediately after the call.
4468 (Vtemp_buffer_show_specifiers): New variable.
4469 (auto_window_vscroll_p, next_screen_context_lines)
4470 (Vscroll_preserve_screen_position): Remove leading asterisks from
4471 doc-strings.
4472
2d3c217e 44732011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4474
7b7f97e8 4475 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4476 * buffer.c (Qclone_number): Remove for now, as it's unused.
4477 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4478 (record_buffer): Remove unused local.
4479 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4480 (set_frame_buffer_list): Remove; unused.
4481 * frame.h (other_visible_frames): Remove decl.
4482 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4483 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4484 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4485 if HAVE_GPM.
4486 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4487 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4488 Define only if HAVE_GPM.
4489 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4490 (update_hints_inhibit): Remove; never set. All uses removed.
4491 * widgetprv.h (emacsFrameClassRec): Remove decl.
4492 * window.c (delete_deletable_window): Now returns void, since it
4493 wasn't returning anything.
4494 (compare_window_configurations): Remove unused locals.
4495 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4496 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4497 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4498 the same widths as pointers. This follows up on the 2011-05-06 patch.
4499 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4500 * xterm.h: Likewise.
4501 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4502
1384b89e
JB
45032011-06-12 Juanma Barranquero <lekktu@gmail.com>
4504
4505 * makefile.w32-in: Update dependencies.
4506 (LISP_H): Add lib/intprops.h.
4507
1100a63c
CY
45082011-06-11 Chong Yidong <cyd@stupidchicken.com>
4509
4510 * image.c (gif_load): Add animation frame delay to the metadata.
4511 (syms_of_image): Use DEFSYM. New symbol `delay'.
4512
6198ccd0
MR
45132011-06-11 Martin Rudalics <rudalics@gmx.at>
4514
4515 * window.c (delete_deletable_window): Re-add.
4516 (Fset_window_configuration): Rewrite to handle dead buffers and
4517 consequently deletable windows.
4518 (window_tree, Fwindow_tree): Remove. Supply functionality in
4519 window.el.
4520 (compare_window_configurations): Simplify code.
4521
b6e3633c
AS
45222011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4523
1ab0dee5
AS
4524 * image.c (imagemagick_load_image): Fix type mismatch.
4525 (Fimagemagick_types): Likewise.
4526
b6e3633c
AS
4527 * window.h (replace_buffer_in_windows): Declare.
4528
9397e56f
MR
45292011-06-11 Martin Rudalics <rudalics@gmx.at>
4530
4531 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4532 Qclone_number. Remove external declaration of Qdelete_window.
4533 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4534 code.
640c8776
SM
4535 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4536 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4537 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4538 buffer list implementation.
4539 (other_buffer_safely): New function.
4540 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4541 calls to replace_buffer_in_windows and
4542 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4543 if allowed.
4544 (record_buffer): Inhibit quitting and rewrite using quittable
4545 functions. Run Qbuffer_list_update_hook if allowed.
4546 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4547 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4548 Move switch-to-buffer to window.el.
9397e56f
MR
4549 (bury-buffer): Move to window.el.
4550 (Vbuffer_list_update_hook): New variable.
4551
4552 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4553 section.
4554
4555 * window.h (resize_frame_windows): Move up in code.
4556 (Fwindow_frame): Remove EXFUN.
4557 (replace_buffer_in_all_windows): Remove prototype.
4558 (replace_buffer_in_windows_safely): Add prototype.
4559
4560 * window.c: Declare Qdelete_window static again. Move down
4561 declaration of select_count.
4562 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4563 (Fother_window): Move to window.el.
4564 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4565 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4566 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4567 window.el.
4568 (replace_buffer_in_windows): Implement by calling
4569 Qreplace_buffer_in_windows.
4570 (replace_buffer_in_all_windows): Remove with some functionality
4571 moved into replace_buffer_in_windows_safely.
4572 (replace_buffer_in_windows_safely): New function.
4573 (select_window_norecord, select_frame_norecord): Move in front
4574 of run_window_configuration_change_hook. Remove now obsolete
4575 declarations.
640c8776
SM
4576 (Fset_window_buffer): Rewrite doc-string.
4577 Call Qrecord_window_buffer.
9397e56f
MR
4578 (keys_of_window): Move binding for other-window to window.el.
4579
b50691aa
CY
45802011-06-11 Chong Yidong <cyd@stupidchicken.com>
4581
4582 * dispextern.h (struct image): Replace data member, whose int_val
4583 and ptr_val fields were not used by anything, with a single
4584 lisp_val object.
4585
4586 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4587 (gif_clear_image, gif_load, imagemagick_load_image)
4588 (gs_clear_image, gs_load): Callers changed.
4589
3f754b86
PE
45902011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4591
cca69397
PE
4592 * buffer.h: Include <time.h>, for time_t.
4593 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4594
109e28d0
PE
4595 Fix minor problems found by static checking.
4596
60737f02
PE
4597 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4598
4b66faf3
PE
4599 Make identifiers static if they are not used in other modules.
4600 * data.c (Qcompiled_function, Qframe, Qvector):
4601 * image.c (QimageMagick, Qsvg):
4602 * minibuf.c (Qmetadata):
4603 * window.c (resize_window_check, resize_root_window): Now static.
4604 * window.h (resize_window_check, resize_root_window): Remove decls.
4605
109e28d0
PE
4606 * window.c (window_deletion_count, delete_deletable_window):
4607 Remove; unused.
46a4ce9e
PE
4608 (window_body_lines): Now static.
4609 (Fdelete_other_windows_internal): Mark vars as initialized.
4610 Make sure 'resize_failed' is initialized.
4611 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4612 (resize_window_apply): Remove unused local.
4613 * window.h (delete_deletable_window): Remove decl.
4614
109e28d0 4615 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4616 (imagemagick_load_image): Fix pointer signedness problem by changing
4617 last arg from unsigned char * to char *. All uses changed.
4618 Also, fix a local for similar reasons.
4619 Remove unused locals. Remove locals to avoid shadowing.
4620 (fn_rsvg_handle_free): Remove; unused.
4621 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4622 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4623
3f754b86
PE
4624 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4625
2547adb1
CY
46262011-06-10 Chong Yidong <cyd@stupidchicken.com>
4627
4628 * image.c (gif_load): Fix omitted cast error introduced by
4629 2011-06-06 change.
4630
2c8e37d4
MR
46312011-06-10 Martin Rudalics <rudalics@gmx.at>
4632
4633 * window.h (resize_proportionally, orig_total_lines)
4634 (orig_top_line): Remove from window structure.
4635 (set_window_height, set_window_width, change_window_heights)
4636 (Fdelete_window): Remove prototypes.
4637 (resize_frame_windows): Remove duplicate declaration.
4638
440a42e3
EZ
46392011-06-10 Eli Zaretskii <eliz@gnu.org>
4640
4641 * window.h (resize_frame_windows, resize_window_check)
4642 (delete_deletable_window, resize_root_window)
4643 (resize_frame_windows): Declare prototypes.
4644
4645 * window.c (resize_window_apply): Make definition be "static" to
4646 match the prototype.
4647
562dd5e9
MR
46482011-06-10 Martin Rudalics <rudalics@gmx.at>
4649
4650 * window.c: Remove declarations of Qwindow_size_fixed,
4651 window_min_size_1, window_min_size_2, window_min_size,
4652 size_window, window_fixed_size_p, enlarge_window, delete_window.
4653 Remove static from declaration of Qdelete_window, it's
4654 temporarily needed by Fbury_buffer.
4655 (replace_window): Don't assign orig_top_line and
4656 orig_total_lines.
4657 (Fdelete_window, delete_window): Remove. Window deletion is
4658 handled by window.el.
640c8776
SM
4659 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4660 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4661 (Fdelete_other_windows): Remove. Deleting other windows is
4662 handled by window.el.
4663 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4664 handled in window.el.
4665 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4666 Window minimum sizes are handled in window.el.
4667 (shrink_windows, size_window, set_window_height)
4668 (set_window_width, change_window_heights, window_height)
4669 (window_width, CURBEG, CURSIZE, enlarge_window)
4670 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4671 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4672 handled in window.el.
4673 (make_dummy_parent): Rename to make_parent_window and give it a
4674 second argument horflag.
4675 (make_window): Don't set resize_proportionally any more.
4676 (Fsplit_window): Remove. Windows are split in window.el.
4677 (save_restore_action, save_restore_orig_size)
4678 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4679 Resize mini windows in window.el.
4680 (grow_mini_window, shrink_mini_window): Implement by calling
4681 Qresize_root_window_vertically, resize_window_check and
4682 resize_window_apply.
640c8776
SM
4683 (saved_window, Fset_window_configuration, save_window_save):
4684 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4685 resize_proportionally.
4686 (window_min_height, window_min_width): Move to window.el.
4687 (keys_of_window): Move bindings for delete-other-windows,
4688 split-window, delete-window and enlarge-window to window.el.
4689
4690 * buffer.c: Temporarily extern Qdelete_window.
4691 (Fbury_buffer): Temporarily call Qdelete_window instead of
4692 Fdelete_window (Fbury_buffer will move to window.el soon).
4693
4694 * frame.c (set_menu_bar_lines_1): Remove code handling
4695 orig_top_line and orig_total_lines.
4696
4697 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4698 set_window_height but set heights directly.
4699 (change_frame_size_1): Use resize_frame_windows.
4700
4701 * xdisp.c (init_xdisp): Don't use set_window_height but set
4702 heights directly.
4703
640c8776
SM
4704 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4705 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4706 run_window_configuration_change_hook.
4707
4708 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4709 instead of change_window_heights and run
4710 run_window_configuration_change_hook.
4711
1a13852e
MR
47122011-06-09 Martin Rudalics <rudalics@gmx.at>
4713
4714 * window.c (replace_window): Rename second argument REPLACEMENT to
4715 NEW. New third argument SETFLAG. Rewrite.
4716 (delete_window, make_dummy_parent): Call replace_window with
4717 third argument 1.
4718 (window_list_1): Move down in code.
4719 (run_window_configuration_change_hook): Move set_buffer part
4720 before select_frame_norecord part in order to unwind correctly.
4721 Rename count1 to count.
4722 (recombine_windows, delete_deletable_window, resize_root_window)
4723 (Fdelete_other_windows_internal)
4724 (Frun_window_configuration_change_hook, make_parent_window)
4725 (resize_window_check, resize_window_apply, Fresize_window_apply)
4726 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4727 (Fdelete_window_internal, Fresize_mini_window_internal):
4728 New functions.
1a13852e
MR
4729 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4730
f3d1777e
MR
47312011-06-08 Martin Rudalics <rudalics@gmx.at>
4732
496e208e
MR
4733 * window.h (window): Add some new members to window structure -
4734 normal_lines, normal_cols, new_total, new_normal, clone_number,
4735 splits, nest, prev_buffers, next_buffers.
4736 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4737 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4738
f3d1777e
MR
4739 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4740 Remove.
496e208e
MR
4741 (make_dummy_parent): Set new members of windows structure.
4742 (make_window): Move down in code. Handle new members of window
4743 structure.
4744 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4745 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4746 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4747 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4748 (Fset_window_next_buffers, Fset_window_clone_number):
4749 New functions.
496e208e
MR
4750 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4751 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4752 Doc-string fixes.
4753 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4754 Argument WINDOW can be now internal window too.
4755 (Fwindow_use_time): Move up in code.
4756 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4757 Rewrite doc-string.
4758 (Fset_window_configuration, saved_window)
4759 (Fcurrent_window_configuration, save_window_save): Handle new
4760 members of window structure.
b9e809c2
MR
4761 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4762 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4763 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4764 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4765 Qget_mru_window, Qresize_root_window,
4766 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4767 Qauto_buffer_name; staticpro them.
f3d1777e 4768
abde8f8c
MR
47692011-06-07 Martin Rudalics <rudalics@gmx.at>
4770
4771 * window.c (Fwindow_total_size, Fwindow_left_column)
4772 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4773 (Fwindow_list_1): New functions.
4774 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4775 (Fwindow_width, Fscroll_left, Fscroll_right):
4776 Use window_body_cols instead of window_box_text_cols.
4777 (delete_window, Fset_window_configuration):
4778 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4779 (delete_all_subwindows): Take a window as argument and not a
4780 structure. Rewrite.
190b47e6
MR
4781 (window_loop): Remove handling of GET_LRU_WINDOW and
4782 GET_LARGEST_WINDOW.
4783 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4784
4785 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4786 window_box_text_cols. delete_all_subwindows now takes a
4787 Lisp_Object as argument.
abde8f8c 4788
640c8776
SM
4789 * indent.c (compute_motion, Fcompute_motion):
4790 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4791
fa8a67e6
MR
4792 * frame.c (delete_frame): Call delete_all_subwindows with root
4793 window as argument.
4794
a54e3482
DC
47952011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4796
4797 * fns.c (Fputhash): Document return value.
4798
60002bf5
CY
47992011-06-06 Chong Yidong <cyd@stupidchicken.com>
4800
4801 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4802
0c671da6 48032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4804
b862a52a 4805 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4806
be44ca6c
PE
4807 Check for overflow when converting integer to cons and back.
4808 * charset.c (Fdefine_charset_internal, Fdecode_char):
4809 Use cons_to_unsigned to catch overflow.
4810 (Fencode_char): Use INTEGER_TO_CONS.
4811 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4812 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4813 * data.c (long_to_cons, cons_to_long): Remove.
4814 (cons_to_unsigned, cons_to_signed): New functions.
4815 These signal an error for invalid or out-of-range values.
4816 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4817 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4818 * font.c (Ffont_variation_glyphs):
4819 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4820 * lisp.h: Include <intprops.h>.
4821 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4822 (cons_to_signed, cons_to_unsigned): New decls.
4823 (long_to_cons, cons_to_long): Remove decls.
4824 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4825 (Fprimitive_undo): Use CONS_TO_INTEGER.
4826 * xfns.c (Fx_window_property): Likewise.
4827 * xselect.c: Include <limits.h>.
4828 (x_own_selection, selection_data_to_lisp_data):
4829 Use INTEGER_TO_CONS.
4830 (x_handle_selection_request, x_handle_selection_clear)
4831 (x_get_foreign_selection, Fx_disown_selection_internal)
4832 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4833 (lisp_data_to_selection_data): Use cons_to_unsigned.
4834 (x_fill_property_data): Use cons_to_signed.
4835 Report values out of range.
4836
d1f3d2af
PE
4837 Check for buffer and string overflow more precisely.
4838 * buffer.h (BUF_BYTES_MAX): New macro.
4839 * lisp.h (STRING_BYTES_MAX): New macro.
4840 * alloc.c (Fmake_string):
4841 * character.c (string_escape_byte8):
4842 * coding.c (coding_alloc_by_realloc):
4843 * doprnt.c (doprnt):
4844 * editfns.c (Fformat):
4845 * eval.c (verror):
4846 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4847 since they may not be the same number.
4848 * editfns.c (Finsert_char):
4849 * fileio.c (Finsert_file_contents):
4850 Likewise for BUF_BYTES_MAX.
4851
dd52fcea
PE
4852 * image.c: Use ptrdiff_t, not int, for sizes.
4853 (slurp_file): Switch from int to ptrdiff_t.
4854 All uses changed.
4855 (slurp_file): Check that file size fits in both size_t (for
4856 malloc) and ptrdiff_t (for sanity and safety).
4857
7f9bbdbb
PE
4858 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4859 if b->modtime has its maximal value.
4860
dfe18f82
PE
4861 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4862
84acfcf0
PE
4863 Don't assume time_t can fit into int.
4864 * buffer.h (struct buffer.modtime): Now time_t, not int.
4865 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4866 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4867
ccd9a01a
PE
4868 Minor fixes for signed vs unsigned integers.
4869 * character.h (MAYBE_UNIFY_CHAR):
4870 * charset.c (maybe_unify_char):
4871 * keyboard.c (read_char, reorder_modifiers):
4872 XINT -> XFASTINT, since the integer must be nonnegative.
4873 * ftfont.c (ftfont_spec_pattern):
4874 * keymap.c (access_keymap, silly_event_symbol_error):
4875 XUINT -> XFASTINT, since the integer must be nonnegative.
4876 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4877 since it makes no difference and we prefer signed.
4878 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4879 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4880 nonnegative.
4881
d6d100dd
SM
48822011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4883
4884 * window.h (Fwindow_frame): Declare.
4885
2b6148e4
PE
48862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4887
4888 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4889 (SPARE_MEMORY): Always define.
4890 (LARGE_REQUEST): Remove.
4891 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4892
f230ecc9
MR
48932011-06-06 Martin Rudalics <rudalics@gmx.at>
4894
727e958e
MR
4895 * lisp.h: Move EXFUNS for Fframe_root_window,
4896 Fframe_first_window and Fset_frame_selected_window to window.h.
4897
4898 * window.h: Move EXFUNS for Fframe_root_window,
4899 Fframe_first_window and Fset_frame_selected_window here from
4900 lisp.h.
4901
4902 * frame.c (Fwindow_frame, Fframe_first_window)
4903 (Fframe_root_window, Fframe_selected_window)
4904 (Fset_frame_selected_window): Move to window.c.
4905 (Factive_minibuffer_window): Move to minibuf.c.
4906 (Fother_visible_frames_p): New function.
4907
4908 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4909
f230ecc9
MR
4910 * window.c (decode_window, decode_any_window): Move up in code.
4911 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4912 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4913 (Fwindow_buffer): Move up and rewrite doc-string.
4914 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4915 (Fwindow_prev): New functions.
727e958e
MR
4916 (Fwindow_frame): Move here from frame.c. Accept any window as
4917 argument.
4918 (Fframe_root_window, Fframe_first_window)
4919 (Fframe_selected_window): Move here from frame.c. Accept frame
4920 or arbitrary window as argument. Update doc-strings.
4921 (Fminibuffer_window): Move up in code.
4922 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4923 (Fset_frame_selected_window): Move here from frame.c.
4924 Marginal rewrite.
727e958e
MR
4925 (Fselected_window, select_window, Fselect_window): Move up in
4926 code. Minor doc-string fixes.
f230ecc9 4927
4d09bcf6
PE
49282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4929
4930 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4931 Do not assume that spare memory exists; that assumption is valid
4932 only if SYSTEM_MALLOC.
4933 (LARGE_REQUEST): New macro, so that the issue of large requests
4934 is separated from the issue of spare memory.
4935
810928a2
AS
49362011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4937
172418ad
AS
4938 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4939 format. (Bug#8806)
4940
43f862f7
AS
4941 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4942
810928a2
AS
4943 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4944 before statements.
4945
a059fe24
JD
49462011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4947
4948 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4949
4950 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4951
4952 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4953 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4954
989bf368
JB
49552011-06-05 Juanma Barranquero <lekktu@gmail.com>
4956
4957 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4958
4b80f674
CY
49592011-06-04 Chong Yidong <cyd@stupidchicken.com>
4960
4961 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4962 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4963 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4964 New error handlers.
4b80f674
CY
4965 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4966 Obey Vx_select_enable_clipboard_manager. Catch errors in
4967 x_clipboard_manager_save (Bug#8779).
4968 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4969 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4970
99a33b77 49712011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4972
4973 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4974
99a33b77 49752011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4976
4977 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4978 in the current matrix if keep_current_p is non-zero.
4979
8264569d
EZ
49802011-06-04 Eli Zaretskii <eliz@gnu.org>
4981
4982 * bidi.c (bidi_level_of_next_char): Fix last change.
4983
57f97249
EZ
49842011-06-03 Eli Zaretskii <eliz@gnu.org>
4985
fec2107c 4986 Support bidi reordering of text covered by display properties.
57f97249 4987
fec2107c
EZ
4988 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4989 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4990 (bidi_cache_search, bidi_cache_iterator_state)
4991 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4992 (bidi_level_of_next_char, bidi_move_to_visually_next):
4993 Support character positions inside a run of characters covered by a
fec2107c
EZ
4994 display string.
4995 (bidi_paragraph_init, bidi_resolve_explicit_1)
4996 (bidi_level_of_next_char): Call bidi_fetch_char and
4997 bidi_fetch_char_advance instead of FETCH_CHAR and
4998 FETCH_CHAR_ADVANCE.
4999 (bidi_init_it): Initialize new members.
5000 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5001 definitions.
5002 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5003 instead of using explicit *_CHAR codes.
d6d100dd
SM
5004 (bidi_resolve_explicit, bidi_resolve_weak):
5005 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5006 bidirectional text is supported only in multibyte buffers.
5007 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5008 it to initialize the frame_window_p member of struct bidi_it.
5009 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5010 (bidi_resolve_explicit, bidi_resolve_weak)
5011 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5012 bidi_it->nchars is non-positive.
5013 (bidi_level_of_next_char): Don't try to lookup the cache for the
5014 next/previous character if nothing is cached there yet, or if we
5015 were just reseat()'ed to a new position.
c40e2fb2 5016
0e14fe90
EZ
5017 * xdisp.c (set_cursor_from_row): Set start and stop points
5018 according to the row's direction when priming the loop that looks
5019 for the glyph on which to display cursor.
5020 (single_display_spec_intangible_p): Function deleted.
5021 (display_prop_intangible_p): Reimplement to call
5022 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5023 Accept 3 additional arguments needed by handle_display_spec.
5024 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5025 values: lists, `(when COND...)' forms, etc.
5026 (single_display_spec_string_p): Support property values that are
5027 lists with the argument STRING its top-level element.
5028 (display_prop_string_p): Fix the condition for processing a
5029 property that is a list to be consistent with handle_display_spec.
fec2107c 5030 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5031 last portion of handle_display_prop.
5032 (compute_display_string_pos): Accept additional argument
5033 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5034 value of a `display' property is a "replacing spec".
5035 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5036 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5037 the display property, but just return a value indicating whether
5038 the display property will replace the characters it covers.
5039 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5040 frame_window_p members of struct bidi_it.
d6d100dd
SM
5041 (compute_display_string_pos, compute_display_string_end):
5042 New functions.
fec2107c
EZ
5043 (push_it): Accept second argument POSITION, where pop_it should
5044 jump to continue iteration.
5045 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5046
fec2107c
EZ
5047 * keyboard.c (adjust_point_for_property): Adjust the call to
5048 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5049
5050 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5051 (bidi_init_it): Update prototypes.
5052 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5053 (compute_display_string_pos, compute_display_string_end):
5054 Declare prototypes.
fec2107c
EZ
5055 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5056 EMACS_INT.
fc6f18ce 5057
40087514 50582011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5059
57f53182
PE
5060 Malloc failure behavior now depends on size of allocation.
5061 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5062 * lisp.h: Change signatures accordingly.
5063 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5064 All callers changed. (Bug#8762)
5065
5066 * gnutls.c: Use Emacs's memory allocators.
5067 Without this change, the gnutls library would invoke malloc etc.
5068 directly, which causes problems on non-SYNC_INPUT hosts, and which
5069 runs afoul of improving memory_full behavior. (Bug#8761)
5070 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5071 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5072 xfree instead of the default malloc, realloc, free.
5073 (Fgnutls_boot): No need to check for memory allocation failure,
5074 since xmalloc does that for us.
5075
ac32cd99 5076 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5077 * category.c (hash_get_category_set):
5078 * ccl.c (ccl_driver):
5079 * charset.c (Fdefine_charset_internal):
5080 * charset.h (struct charset.hash_index):
5081 * composite.c (get_composition_id, gstring_lookup_cache)
5082 (composition_gstring_put_cache):
5083 * composite.h (struct composition.hash_index):
5084 * dispextern.h (struct image.hash):
5085 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5086 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5087 (hashfn_equal, hashfn_user_defined, make_hash_table)
5088 (maybe_resize_hash_table, hash_lookup, hash_put)
5089 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5090 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5091 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5092 * image.c (make_image, search_image_cache, lookup_image)
5093 (xpm_put_color_table_h):
5094 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5095 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5096 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5097 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5098 * alloc.c (allocate_vectorlike):
5099 Check for overflow in vector size calculations.
5100 * ccl.c (ccl_driver):
5101 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5102 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5103 need to be updated by these changes.
40087514
PE
5104 * fns.c (make_hash_table, maybe_resize_hash_table):
5105 Check for integer overflow with large hash tables.
0de4bb68
PE
5106 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5107 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5108 (SXHASH_REDUCE): New macro.
5109 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5110 Use it instead of discarding useful hash info with large hash values.
5111 (sxhash_float): New function.
5112 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5113 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5114 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5115 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5116 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5117 Adjust signatures to match updated version of code.
5118 (consing_since_gc): Now EMACS_INT, since a single hash table can
5119 use more than INT_MAX bytes.
5120
698d32e2
DN
51212011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5122
5123 Make it possible to build with GCC-4.6+ -O2 -flto.
5124
5125 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5126
fd6fa53f
SM
51272011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5128
5129 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5130 Call minibuffer-inactive-mode.
5131
864db017
JB
51322011-05-31 Juanma Barranquero <lekktu@gmail.com>
5133
5134 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5135 Update dependencies.
5136
2ad0baf4
DN
51372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5138
5139 * data.c (init_data): Remove code for UTS, this system is not
5140 supported anymore.
5141
4fcc2638
DN
51422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5143
5144 Don't force ./temacs to start in terminal mode.
5145
5146 * frame.c (make_initial_frame): Initialize faces in all cases, not
5147 only when CANNOT_DUMP is defined.
5148 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5149
c56e0fd5
DN
51502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5151
5152 * dispnew.c (add_window_display_history): Use const for the string
5153 pointer. Remove declaration, not needed.
5154
333d54da 51552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5156
55d4c1b2 5157 Use 'inline', not 'INLINE'.
333d54da 5158 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5159 * alloc.c, fontset.c (INLINE): Remove.
5160 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5161 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5162 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5163 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5164 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5165
738db178
DN
51662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5167
5168 Make it possible to run ./temacs.
5169
5170 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5171 syms_of_callproc does the same thing. Remove test for
5172 "initialized", do it in the caller.
5173 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5174
620c53a6
SM
51752011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5176
5177 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5178 (read_minibuf): Use get_minibuffer.
5179 (syms_of_minibuf): Use DEFSYM.
5180 (Qmetadata): New var.
5181 * data.c (Qbuffer): Don't make it static.
5182 (syms_of_data): Use DEFSYM.
5183
e003a292
PE
51842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5185
5186 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5187 (CCL_CODE_MIN): New macro.
5188
ed008a6d
PE
51892011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5190
3687c2ef
PE
5191 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5192
ed008a6d
PE
5193 * eval.c (Qdebug): Now static.
5194 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5195 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5196 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5197
d66c4c7c
CY
51982011-05-29 Chong Yidong <cyd@stupidchicken.com>
5199
5200 * image.c: Various fixes to ImageMagick code comments.
5201 (Fimagemagick_types): Doc fix.
5202
5fbc2025
PE
52032011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5204
0196f88a
PE
5205 Minor fixes prompted by GCC 4.6.0 warnings.
5206
5207 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5208
5fbc2025
PE
5209 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5210 (x_clipboard_manager_save_all): Move extern decl to ...
5211 * xterm.h: ... here, so that it can be checked for consistency.
5212
1dd3c2d9
CY
52132011-05-29 Chong Yidong <cyd@stupidchicken.com>
5214
5215 * xselect.c (x_clipboard_manager_save_frame)
5216 (x_clipboard_manager_save_all): New functions.
5217 (Fx_clipboard_manager_save): Lisp function deleted.
5218
5219 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5220 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5221
5222 * xterm.h: Update prototype.
5223
5ba6571d
WX
52242011-05-28 William Xu <william.xwl@gmail.com>
5225
5226 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5227 exiting (Bug#8239).
5228
3eaff834
JM
52292011-05-28 Jim Meyering <meyering@redhat.com>
5230
e1900994 5231 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5232 * fns.c (to_uchar): Define.
5233 (crypto_hash_function): Use it to convert some newly-signed
5234 variables to unsigned, to avoid sign-extension bugs. For example,
5235 without this change, (md5 "truc") would evaluate to
5236 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5237 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5238 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5239
0f6990a7
PE
52402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5241
5242 Integer overflow fixes.
c8a9ca5a 5243
08686060
PE
5244 * dbusbind.c: Serial number integer overflow fixes.
5245 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5246 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5247 to hold a serial number that is too large for a fixnum.
5248 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5249 Check for serial numbers out of range. Decode any serial number
59568bf0 5250 that was so large that it became a float. (Bug#8722)
08686060 5251
2d1fc3c7
PE
5252 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5253 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5254 Use XFASTINT rather than XUINT when numbers are nonnegative.
5255 (xd_append_arg, Fdbus_method_return_internal):
5256 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5257 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5258 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5259 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5260 (Bug#8722)
2d1fc3c7 5261
c8a9ca5a
PE
5262 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5263
519e1d69
PE
5264 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5265
30569699
PE
5266 ccl: add integer overflow checks
5267 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5268 (IN_INT_RANGE): New macros.
5269 (ccl_driver): Use them to check for integer overflow when
5270 decoding a CCL program. Many of the new checks are whether XINT (x)
5271 fits in int; it doesn't always, on 64-bit hosts. The new version
5272 doesn't catch all possible integer overflows, but it's an
847044ea 5273 improvement. (Bug#8719)
30569699 5274
c11285dc
PE
5275 * alloc.c (make_event_array): Use XINT, not XUINT.
5276 There's no need for unsigned here.
5277
fdccd48e
PE
5278 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5279 This follows up to the 2011-05-06 change that substituted uintptr_t
5280 for EMACS_INT. This case wasn't caught back then.
5281
37910ab2
PE
5282 Rework Fformat to avoid integer overflow issues.
5283 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5284 now (part of C89). Include <verify.h>.
5285 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5286 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5287 (Fformat): Avoid the prepass trying to compute sizes; it was only
5288 approximate and thus did not catch overflow reliably. Instead, walk
5289 through the format just once, formatting and computing sizes as we go,
5290 checking for integer overflow at every step, and allocating a larger
5291 buffer as needed. Keep track separately whether the format is
5292 multibyte. Keep only the most-recently calculated precision, rather
5293 than them all. Record whether each argument has been converted to
5294 string. Use EMACS_INT, not int, for byte and char and arg counts.
5295 Support field widths and precisions larger than INT_MAX. Avoid
5296 sprintf's undefined behavior with conversion specifications such as %#d
5297 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5298 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5299 formatting out-of-range floating point numbers with int
9173deec 5300 formats. (Bug#8668)
37910ab2 5301
2e6578fb
PE
5302 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5303
0ae6bdee
PE
5304 * data.c: Avoid integer truncation in expressions involving floats.
5305 * data.c: Include <intprops.h>.
5306 (arith_driver): When there's an integer overflow in an expression
5307 involving floating point, convert the integers to floating point
5308 so that the resulting value does not suffer from catastrophic
5309 integer truncation. For example, on a 64-bit host (* 4
5310 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5311 Do not rely on undefined behavior after integer overflow.
5312
de883a70
PE
5313 merge count_size_as_multibyte, parse_str_to_multibyte
5314 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5315 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5316 Check for integer overflow.
5317 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5318 since it's now a duplicate of the other. This is more of
5319 a character than a buffer op, so better that it's in character.c.
5320 * fns.c, print.c: Adjust to above changes.
5321
2ff916cb
PE
53222011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5323
5324 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5325
f1b54466
PE
53262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5327
fb1ac845
PE
5328 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5329 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5330 (x_clipboard_manager_save): Now static.
5331 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5332
f1b54466
PE
5333 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5334 (crypto_hash_function): Now static.
5335 Fix pointer signedness problems. Avoid unnecessary initializations.
5336
a9f737ee
CY
53372011-05-27 Chong Yidong <cyd@stupidchicken.com>
5338
5339 * termhooks.h (Vselection_alist): Make it terminal-local.
5340
5341 * terminal.c (create_terminal): Initialize it.
5342
5343 * xselect.c: Support for clipboard managers.
5344 (Vselection_alist): Move to termhooks.h as terminal-local var.
5345 (LOCAL_SELECTION): New macro.
5346 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5347 (symbol_to_x_atom): Remove gratuitous arg.
5348 (x_handle_selection_request, lisp_data_to_selection_data)
5349 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5350 (x_own_selection, x_get_local_selection, x_convert_selection):
5351 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5352 (some_frame_on_display): Delete unused function.
5353 (Fx_own_selection_internal, Fx_get_selection_internal)
5354 (Fx_disown_selection_internal, Fx_selection_owner_p)
5355 (Fx_selection_exists_p): New optional frame arg.
5356 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5357 (x_handle_selection_clear): Don't treat other terminals with the
5358 same keyboard specially. Use the terminal-local Vselection_alist.
5359 (x_clear_frame_selections): Use Frun_hook_with_args.
5360
5361 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5362
5363 * xterm.h: Add support for those atoms.
5364
e067f0c1
CY
53652011-05-26 Chong Yidong <cyd@stupidchicken.com>
5366
5367 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5368 (converted_selections, conversion_fail_tag): New global variables.
5369 (x_selection_request_lisp_error): Free the above.
5370 (x_get_local_selection): Remove unnecessary code.
5371 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5372 of converted selections stored in converted_selections.
5373 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5374 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5375 (x_convert_selection): New function.
5376 (x_handle_selection_event): Simplify.
5377 (x_get_foreign_selection): Don't ignore incoming requests while
5378 waiting for an answer; this will fail when we implement
5379 SAVE_TARGETS, and seems unnecessary anyway.
5380 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5381 (Vx_sent_selection_functions): Doc fix.
5382
0f4aebc0
LL
53832011-05-26 Leo Liu <sdl.web@gmail.com>
5384
5385 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5386
e61124cd
YM
53872011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5388
5389 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5390
5391 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5392 for fringe update if it has periodic bitmap.
ac389d0c 5393 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5394 and fringe_bitmap_periodic_p.
5395
5396 * fringe.c (get_fringe_bitmap_data): New function.
5397 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5398 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5399 row. Mark glyph row for fringe update if periodicity changed.
5400
5401 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5402 for fringe update unless it has periodic bitmap.
5403
f16d9837
KH
54042011-05-25 Kenichi Handa <handa@m17n.org>
5405
5406 * xdisp.c (get_next_display_element): Set correct it->face_id for
5407 a static composition.
5408
e1b90ef6
LL
54092011-05-24 Leo Liu <sdl.web@gmail.com>
5410
5411 * deps.mk (fns.o):
5412 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5413
5414 * fns.c (crypto_hash_function, Fsha1): New function.
5415 (Fmd5): Use crypto_hash_function.
5416 (syms_of_fns): Add Ssha1.
5417
7400048f
PE
54182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5419
5420 * gnutls.c: Remove unused macros.
5421 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5422 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5423 Remove macros that are defined and never used.
5424 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5425
abb71cf4
CY
54262011-05-22 Chong Yidong <cyd@stupidchicken.com>
5427
5428 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5429 (Fx_get_selection_internal): Minor cleanup.
5430 (Fx_own_selection_internal): Rename arguments for consistency with
5431 select.el.
5432
6307db39
PE
54332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5434
5435 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5436
f3d4e0a4
CY
54372011-05-22 Chong Yidong <cyd@stupidchicken.com>
5438
5439 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5440
4d8ade89
YM
54412011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5442
5443 * dispnew.c (scrolling_window): Don't exclude the case that the
5444 last enabled row in the desired matrix touches the bottom boundary.
5445
32078c8d
GM
54462011-05-21 Glenn Morris <rgm@gnu.org>
5447
5448 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5449 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5450 and add some more files.
32078c8d 5451
7285dc67
EZ
54522011-05-20 Eli Zaretskii <eliz@gnu.org>
5453
5454 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5455 report_file_error introduced by the change from 2011-05-07.
5456
89d1bd22
PE
54572011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5458
5459 * systime.h (Time): Define only if emacs is defined.
5460 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5461 where the include path doesn't have X11/X.h by default. See
5462 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5463
e23640bb 54642011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5465
5466 * composite.c (find_automatic_composition): Fix previous change.
5467
b9704ad9
GM
54682011-05-20 Glenn Morris <rgm@gnu.org>
5469
5470 * lisp.mk: New file, split from Makefile.in.
5471 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5472 (shortlisp): Remove.
5473 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5474
4a720484
GM
54752011-05-19 Glenn Morris <rgm@gnu.org>
5476
5477 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5478 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5479 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5480 (lisp): Set the order to that of loadup.el.
5481 (shortlisp): Make it a copy of $lisp.
5482 (SOME_MACHINE_LISP): Remove.
5483 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5484 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5485
a28d4396
KH
54862011-05-18 Kenichi Handa <handa@m17n.org>
5487
5488 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5489 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5490 (find_automatic_composition): Mostly rewrite for efficiency.
5491
a2b1fa8e
JB
54922011-05-18 Juanma Barranquero <lekktu@gmail.com>
5493
5494 * makefile.w32-in: Update dependencies.
5495
8e1f5610
CS
54962011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5497
5498 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5499 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5500
7025ee00 55012011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5502
cdfa6eab
PE
5503 Fix some integer overflow issues, such as string length overflow.
5504
06d6db33
PE
5505 * insdel.c (count_size_as_multibyte): Check for string overflow.
5506
2b4560a8
PE
5507 * character.c (lisp_string_width): Check for string overflow.
5508 Use EMACS_INT, not int, for string indexes and lengths; in
5509 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5510 the resulting string length overflows an EMACS_INT; instead,
5511 report a string overflow if no precision given. When checking for
5512 precision exhaustion, use a check that cannot possibly have
5513 integer overflow. (Bug#8675)
5514 * character.h (lisp_string_width): Adjust to new signature.
5515
cb93f9be
PE
5516 * alloc.c (string_overflow): New function.
5517 (Fmake_string): Use it. This doesn't change behavior, but saves
5518 a few bytes and will simplify future changes.
5519 * character.c (string_escape_byte8): Likewise.
5520 * lisp.h (string_overflow): New decl.
5521
1a1f3366
PE
5522 Fixups, following up to the user-interface timestamp change.
5523 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5524 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5525 * msdos.c (mouse_get_pos): Likewise.
5526 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5527 * w32gui.h (Time): Define by including "systime.h" rather than by
5528 declaring it ourselves. (Bug#8664)
5529
d4e3e4d3
PE
5530 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5531 * image.c (clear_image_cache): Likewise.
5532
f6a24d19
PE
5533 * term.c (term_mouse_position): Don't assume time_t wraparound.
5534
08dc5ae6
PE
5535 Be more systematic about user-interface timestamps.
5536 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5537 and sometimes 'EMACS_UINT', to represent these timestamps.
5538 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5539 This makes the code easier to follow, and makes it easier to catch
5540 integer overflow bugs such as Bug#8664.
5541 * frame.c (Fmouse_position, Fmouse_pixel_position):
5542 Use Time, not unsigned long, for user-interface timestamps.
5543 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5544 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5545 * keyboard.h (last_event_timestamp): Likewise.
5546 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5547 * menu.h (xmenu_show): Likewise.
5548 * term.c (term_mouse_position): Likewise.
5549 * termhooks.h (struct input_event.timestamp): Likewise.
5550 (struct terminal.mouse_position_hook): Likewise.
5551 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5552 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5553 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5554 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5555 what it was before.
5556 * menu.h, termhooks.h: Include "systime.h", for Time.
5557
8e55734a
PE
5558 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5559 Don't assume that the difference between two unsigned long values
5560 can fit into an integer. At this point, we know button_down_time
5561 <= event->timestamp, so the difference must be nonnegative, so
5562 there's no need to cast the result if double-click-time is
5563 nonnegative, as it should be; check that it's nonnegative, just in
5564 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5565 apart (about 25 days). (Bug#8664)
8e55734a 5566
841f1b75 5567 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5568 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5569
3e26f69c
PE
5570 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5571 that always fit in int. Use a sentinel instead of a counter, to
5572 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5573 * frame.h (struct frame): Use int for menu_bar_items_used
5574 instead of EMACS_INT, since it always fits in int.
3e26f69c 5575
5cc152c0
PE
5576 * menu.c (grow_menu_items): Check for int overflow.
5577
d89eb65e
PE
5578 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5579
5235bd3e
PE
5580 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5581 Before, the code was not consistent. These values cannot exceed
5582 2**31 - 1 so there's no need to make them unsigned.
5583 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5584 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5585 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5586 as modifiers.
5587 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5588
bc827e23
PE
5589 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5590 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5591 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5592 presumably because the widths might not match.
5593
78eb494e
PE
5594 * window.c (size_window): Avoid needless test at loop start.
5595
04f2d78b
CB
55962011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5597
5598 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5599
d2fc7e3d 56002011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5601
5602 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5603
d2fc7e3d 56042011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5605
5606 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5607 `width' to `bar_area_x' and `bar_area_width', respectively.
5608 (x_scroll_run): Take account of fringe background extension.
5609
04f2d78b
CB
5610 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5611 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5612 `bar_area_width', respectively.
5613 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5614 background extension.
5615
79b70037
GM
56162011-05-10 Jim Meyering <meyering@redhat.com>
5617
5618 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5619
2f142cc5
JB
56202011-05-10 Juanma Barranquero <lekktu@gmail.com>
5621
5622 * image.c (Finit_image_library): Return t for built-in image types,
5623 like pbm and xbm. (Bug#8640)
5624
57679c86
AS
56252011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5626
5627 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5628
888c9e86
EZ
56292011-05-07 Eli Zaretskii <eliz@gnu.org>
5630
b0512a1d
EZ
5631 * w32console.c (Fset_screen_color): Doc fix.
5632 (Fget_screen_color): New function.
5633 (syms_of_ntterm): Defsubr it.
5634
7285dc67
EZ
5635 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5636 unlink the temporary file if Fcall_process didn't create it in the
5637 first place.
5638 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5639 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5640 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5641 cue to call_process_cleanup not to close that handle.
5642
4d3fcc8e
BK
56432011-05-07 Ben Key <bkey76@gmail.com>
5644
5645 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5646 one of two shell specific rules, either bootstrap-temacs-CMD or
5647 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5648 to the previous implementation of the bootstrap-temacs rule.
5649 The bootstrap-temacs-CMD rule is similar to the previous
5650 implementation of the bootstrap-temacs rule except that it
5651 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5652 variable.
5653
5654 These changes, along with some changes to nt/configure.bat,
5655 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5656 earlier fix to add support for --cflags and --ldflags options
5657 that include quotes so that it works whether make uses cmd or
5658 sh as the shell.
5659
b4289b64
MA
56602011-05-06 Michael Albinus <michael.albinus@gmx.de>
5661
5662 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5663 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5664 is a constant.
5665 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5666 a string. Handle both cases.
5667 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5668 (Fdbus_register_method): Use Qinvalid_function.
5669
af4c0e28
JB
56702011-05-06 Juanma Barranquero <lekktu@gmail.com>
5671
5672 * makefile.w32-in: Update dependencies.
5673 (LISP_H): Add inttypes.h and stdin.h.
5674 (PROCESS_H): Add unistd.h.
5675
c51453d9
EZ
56762011-05-06 Eli Zaretskii <eliz@gnu.org>
5677
5678 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5679 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5680
8ff0ac3c 56812011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5682
4c4b566b
PE
5683 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5684
aab2b9b5
PE
5685 * term.c (vfatal): Remove stray call to va_end.
5686 It's not needed and the C Standard doesn't allow it here anyway.
5687
c378da0b
PE
5688 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5689 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5690
288b08c7
PE
5691 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5692 bytes.
5693
e3601888
PE
5694 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5695
db6c0e74
PE
5696 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5697
dd5963ea
PE
5698 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5699
88c9450f
PE
5700 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5701
2f9442b8
PE
5702 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5703
c032b5f8
PE
5704 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5705 * charset.c (Fdefine_charset_internal): Don't initialize
5706 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5707 32-bit int (Bug#8600).
a108c10b
PE
5708
5709 * lread.c (read_integer): Be more consistent with string-to-number.
5710 Use string_to_number to do the actual conversion; this avoids
5711 rounding errors and fixes some other screwups. Without this fix,
5712 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5713 (digit_to_number): Move earlier, for benefit of read_integer.
5714 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5715 not a digit in any supported base. (Bug#8602)
a108c10b 5716
ad5f9eea
PE
5717 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5718
aec1708a
PE
5719 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5720 to match comment at start of function. This also removes a
5721 GCC warning about overflow in a 32+64-bit port.
5722
47be4ab5
PE
5723 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5724
371cac43
PE
5725 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5726 Reported by Stefan Monnier in
5727 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5728 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5729 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5730
d01a7826
PE
5731 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5732 (EMACS_UINTPTR): Likewise, with uintptr_t.
5733
7fd47d5c
PE
5734 * lisp.h: Prefer 64-bit EMACS_INT if available.
5735 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5736 on 32-bit hosts that have 64-bit int, so that they can access
5737 large files.
122b0c86
PE
5738 However, temporarily disable this change unless the temporary
5739 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5740
8727937b
PE
5741 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5742
8ac068ac
PE
5743 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5744 This removes an assumption that EMACS_INT and long are the same
5745 width as pointers. The assumption is true for Emacs porting targets
5746 now, but we want to make other targets possible.
5747 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5748 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5749 In the rest of the code, change types of integers that hold casted
5750 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5751 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5752 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5753 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5754 No need to cast type when ORing.
5755 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5756 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5757 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5758 assume EMACS_INT is the same width as char *.
5759 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5760 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5761 Remove no-longer-needed casts.
5762 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5763 (xg_tool_bar_help_callback, xg_make_tool_item):
5764 Use EMACS_INTPTR to hold an integer
5765 that will be cast to void *; this can avoid a GCC warning
5766 if EMACS_INT is not the same width as void *.
5767 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5768 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5769 (current_message_1, set_message_1):
5770 Use a local to convert to proper width without a cast.
5771 * xmenu.c (dialog_selection_callback): Likewise.
5772
ede49d71
PE
5773 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5774 Also, don't assume VALBITS / RAND_BITS is less than 5,
5775 and don't rely on undefined behavior when shifting a 1 left into
5776 the sign bit.
5777 * lisp.h (get_random): Change signature to match.
5778
2f30ecd0
PE
5779 * lread.c (hash_string): Use size_t, not int, for hash computation.
5780 Normally we prefer signed values; but hashing is special, because
5781 it's better to use unsigned division on hash table sizes so that
5782 the remainder is nonnegative. Also, size_t is the natural width
5783 for hashing into memory. The previous code used 'int', which doesn't
5784 retain enough info to hash well into very large tables.
5785 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5786
2a866e7b
PE
5787 * dbusbind.c: Don't possibly lose pointer info when converting.
5788 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5789 Use XPNTR rather than XHASH, so that the high-order bits of
5790 the pointer aren't lost when converting through void *.
5791
51639eac
PE
5792 * eval.c (Fautoload): Don't double-shift a pointer.
5793
92394119
PE
5794 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5795
dbdb9a7c
JB
57962011-05-06 Juanma Barranquero <lekktu@gmail.com>
5797
5798 * gnutls.c (DEF_GNUTLS_FN):
5799 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5800
db7a0b4f
AS
58012011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5802
5803 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5804 marker. (Bug#8610)
5805
f7ff1b0f 58062011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5807
5808 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5809 New version that can reserve upto 2GB of heap space.
5810
f7ff1b0f 58112011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5812
5813 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5814
639c109b
TZ
58152011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5816
5817 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5818 `gnutls_certificate_set_x509_key_file'.
5819
d2127135
JB
58202011-05-05 Juanma Barranquero <lekktu@gmail.com>
5821
5822 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5823 Update dependencies.
5824
e968f4f3
JB
58252011-05-04 Juanma Barranquero <lekktu@gmail.com>
5826
5827 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5828 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5829 Remove unused parameter `fildes'.
5830 * process.c (read_process_output, send_process): Don't pass it.
5831
84d358f0
JB
58322011-05-04 Juanma Barranquero <lekktu@gmail.com>
5833
5834 Fix previous change: the library cache is defined in w32.c.
5835 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5836 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5837
0898ca10
JB
58382011-05-04 Juanma Barranquero <lekktu@gmail.com>
5839
5840 Implement dynamic loading of GnuTLS on Windows.
5841
5842 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5843 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5844 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5845 Declare.
5846
5847 * gnutls.c (Qgnutls_dll): Define.
5848 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5849 (gnutls_*): Declare function pointers.
5850 (init_gnutls_functions): New function to initialize function pointers.
5851 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5852 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5853 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5854 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5855 (emacs_gnutls_write, emacs_gnutls_read)
5856 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5857 (Fgnutls_available_p): New function.
5858 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5859 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5860 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5861
5862 * image.c: Include w32.h.
5863 (Vimage_type_cache): Delete.
5864 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5865 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5866 (w32_delayed_load): Move to w32.c.
5867
5868 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5869
5870 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5871 (w32_delayed_load): Move from image.c. When loading a library, record
5872 its filename in the :loaded-from property of the library id.
5873 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5874 Initialize and staticpro them.
5875 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5876
5877 * process.c: Include lisp.h before w32.h, not after.
5878 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5879 instead of gnutls_record_check_pending.
5880
5881 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5882
ff4de4aa
TZ
58832011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5884
5885 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5886 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5887 as passed in.
5888
abe95abb
JD
58892011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5890
5891 * xterm.c (x_set_frame_alpha): Do not set property on anything
5892 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5893
e16e55d4
JB
58942011-05-02 Juanma Barranquero <lekktu@gmail.com>
5895
5896 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5897
bafcf6a5
JB
58982011-05-02 Juanma Barranquero <lekktu@gmail.com>
5899
5900 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5901 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5902 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5903 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5904 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5905 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5906 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5907 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5908 (Qgnutls_bootprop_callbacks_verify): Make static.
5909
e7a6747f
AS
59102011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5911
19ed11ba
AS
5912 * callproc.c: Indentation fixup.
5913
e7a6747f 5914 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5915 (wait_for_termination, interruptible_wait_for_termination):
5916 Move after wait_for_termination_1.
e7a6747f 5917
1ef14cb4
LMI
59182011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5919
5920 * sysdep.c (interruptible_wait_for_termination): New function
5921 which is like wait_for_termination, but allows keyboard
5922 interruptions.
5923
5924 * callproc.c (Fcall_process): Add (:file "file") as an option for
5925 the STDOUT buffer.
5926 (Fcall_process_region): Ditto.
5927
330d880c
EZ
59282011-04-30 Eli Zaretskii <eliz@gnu.org>
5929
8db90b73
EZ
5930 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5931 rather than `XVECTOR (FOO)->size'.
5932
330d880c
EZ
5933 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5934 inttypes.h, as a gnulib replacement is used if it not available in
5935 system headers.
5936
15cbd324
EZ
59372011-04-21 Eli Zaretskii <eliz@gnu.org>
5938
5939 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5940 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5941 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5942
5943 * coding.c (coding_alloc_by_realloc): Error out if destination
5944 will grow beyond MOST_POSITIVE_FIXNUM.
5945 (decode_coding_emacs_mule): Abort if there isn't enough place in
5946 charbuf for the composition carryover bytes. Reserve an extra
5947 space for up to 2 characters produced in a loop.
5948 (decode_coding_iso_2022): Abort if there isn't enough place in
5949 charbuf for the composition carryover bytes.
5950
59512011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5952
ae940cca
EZ
5953 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5954 aborting when %lld or %lll format is passed.
5955 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5956 %llo or %llx format is passed. (Bug#8545)
5957
03ab8921
EZ
5958 * window.c (window_scroll_line_based): Use a marker instead of
5959 simple variables to record original value of point. (Bug#7952)
5960
afda1437
EZ
5961 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5962 produced by %s or %c overflows available buffer space. (Bug#8545)
5963
f76dee0c
PE
59642011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5965
5966 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5967 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5968
fdc5744d
JB
59692011-04-28 Juanma Barranquero <lekktu@gmail.com>
5970
5971 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5972
638f053a
JB
59732011-04-28 Juanma Barranquero <lekktu@gmail.com>
5974
5975 * keyboard.c (Qdelayed_warnings_hook): Define.
5976 (command_loop_1): Run `delayed-warnings-hook'
5977 if Vdelayed_warnings_list is non-nil.
5978 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5979 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5980
d178f871
EZ
59812011-04-28 Eli Zaretskii <eliz@gnu.org>
5982
5983 * doprnt.c (doprnt): Don't return value smaller than the buffer
5984 size if the message was truncated. (Bug#8545).
5985
b124fd93
JB
59862011-04-28 Juanma Barranquero <lekktu@gmail.com>
5987
5988 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5989 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5990
e810457d
PE
59912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5992
5993 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5994
ea51cceb
JB
59952011-04-27 Juanma Barranquero <lekktu@gmail.com>
5996
5997 * makefile.w32-in: Update dependencies.
5998
94dcfacf
EZ
59992011-04-27 Eli Zaretskii <eliz@gnu.org>
6000
6001 Improve `doprnt' and its usage. (Bug#8545)
6002 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6003 `format_end'. Remove support for %l as a conversion specifier.
6004 Don't use xrealloc. Improve diagnostics when the %l size modifier
6005 is used. Update the commentary.
6006
6007 * eval.c (verror): Simplify calculation of size_t.
6008
6009 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6010 messages.
6011
f61f41d7
PE
60122011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6013
6014 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6015 change.
6016
96fb4434
PE
60172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6018
6019 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6020 This makes this file independent of the recent pseudovector change.
6021
671875da 60222011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6023
69e9b5a3
PE
6024 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6025
b5f869a7 6026 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6027 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6028 Remove unused local.
c8926152 6029 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6030
841a1577 6031 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6032 GCC 4.6.0 optimizes based on type-based alias analysis.
6033 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6034 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6035 != &v->size, and therefore "v->size = 1; b->size = 2; return
6036 v->size;" must therefore return 1. This assumption is incorrect
6037 for Emacs, since it type-puns struct Lisp_Vector * with many other
6038 types. To fix this problem, this patch adds a new type struct
f904488f 6039 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6040 and pseudovectors, and helps optimizing compilers not get fooled
6041 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6042 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6043 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6044 the size member.
eab3844f
PE
6045 (XSETPVECTYPE): Rewrite in terms of new macro.
6046 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6047 This is a bit clearer, and further avoids the possibility of
6048 undesirable aliasing.
6049 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6050 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6051 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6052 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6053 (ASIZE): Now uses header.size rather than size.
6054 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6055 to avoid the hassle of writing XVECTOR (foo)->header.size.
6056 (struct vectorlike_header): New type.
eab3844f
PE
6057 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6058 object, to help avoid aliasing.
6059 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6060 (SUBRP): Likewise, since Lisp_Subr is a special case.
6061 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6062 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6063 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6064 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6065 changed to be "header.size" and "header.next".
6066 * buffer.h (struct buffer): Likewise.
6067 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6068 * frame.h (struct frame): Likewise.
6069 * process.h (struct Lisp_Process): Likewise.
6070 * termhooks.h (struct terminal): Likewise.
6071 * window.c (struct save_window_data, struct saved_window): Likewise.
6072 * window.h (struct window): Likewise.
6073 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6074 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6075 * buffer.c (init_buffer_once): Likewise.
6076 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6077 special case.
6078 * process.c (Fformat_network_address): Use local var for size,
6079 for brevity.
6080
0df1eac5
PE
6081 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6082
847ab9d1 6083 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6084 * data.c (atof): Remove decl; no longer used or needed.
6085 (digit_to_number): Move to lread.c.
6086 (Fstring_to_number): Use new string_to_number function, to be
6087 consistent with how the Lisp reader treats infinities and NaNs.
6088 Do not assume that floating-point numbers represent EMACS_INT
6089 without losing information; this is not true on most 64-bit hosts.
6090 Avoid double-rounding errors, by insisting on integers when
6091 parsing non-base-10 numbers, as the documentation specifies.
6092 * lisp.h (string_to_number): New decl, replacing ...
6093 (isfloat_string): Remove.
bc0a5c13 6094 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6095 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6096 appears to have been a coding error. Similarly, do not accept
6097 strings like +-1e0 as floating point numbers. Do not report
6098 overflow for integer overflows unless the base is not 10 which
6099 means we have no simple and reliable way to continue.
6100 Break out the floating-point parsing into a new
6101 function string_to_number, so that Fstring_to_number parses
6102 floating point numbers consistently with the Lisp reader.
04f2d78b 6103 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6104 (E_CHAR, EXP_INT): Remove, replacing with ...
6105 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6106 (string_to_number): New function, replacing isfloat_string.
6107 This function checks for valid syntax and produces the resulting
6108 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6109 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6110 so that overflow for non-base-10 numbers is reported only when
6111 there's no portable and simple way to convert to floating point.
452f4150 6112
67769ffc
PE
6113 * textprop.c (set_text_properties_1): Rewrite for clarity,
6114 and to avoid GCC warning about integer overflow.
6115
c20db43f
PE
6116 * intervals.h (struct interval): Use EMACS_INT for members
6117 where EMACS_UINT might cause problems. See
6118 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6119 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6120 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6121 All uses changed.
37aa2f85
PE
6122 (offset_intervals): Tell GCC not to worry about length overflow
6123 when negating a negative length.
c20db43f 6124
2538aa2f
PE
6125 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6126 (overrun_check_free): Likewise.
6127
f2d3008d
PE
6128 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6129 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6130 word size.
6131
ec8df744
PE
6132 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6133 (gnutls_make_error): Rename local to avoid shadowing.
6134 (gnutls_emacs_global_deinit): ifdef out; not used.
6135 (Fgnutls_boot): Use const for pointer to readonly storage.
6136 Comment out unused local. Fix pointer signedness problems.
6137
640ee02d
PE
6138 * lread.c (openp): Don't stuff size_t into an 'int'.
6139 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6140 about possible signed overflow.
6141
6048fb2a
PE
6142 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6143 (GDK_KEY_g): Don't define if already defined.
6144 (xg_prepare_tooltip): Avoid pointer signedness problem.
6145 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6146
fa3c87e1
PE
6147 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6148 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6149
2172544b
PE
6150 * xfns.c (Fx_window_property): Simplify a bit,
6151 to make a bit faster and to avoid GCC 4.6.0 warning.
6152 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6153
9b821a21
PE
6154 * fns.c (internal_equal): Don't assume size_t fits in int.
6155
3c616cfa
PE
6156 * alloc.c (compact_small_strings): Tighten assertion a little.
6157
c2982e87
PE
6158 Replace pEd with more-general pI, and fix some printf arg casts.
6159 * lisp.h (pI): New macro, generalizing old pEd macro to other
6160 conversion specifiers. For example, use "...%"pI"d..." rather
6161 than "...%"pEd"...".
6162 (pEd): Remove. All uses replaced with similar uses of pI.
6163 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6164 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6165 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6166 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6167 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6168 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6169 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6170 64-bit hosts.
6171 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6172 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6173 * print.c (safe_debug_print, print_object): Likewise.
6174 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6175 to int.
6f04d126
PE
6176 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6177 avoiding the 0 flag, which is not portable.
c2982e87
PE
6178 * process.c (Fmake_network_process): Use pI to avoid cast.
6179 * region-cache.c (pp_cache): Likewise.
6180 * xdisp.c (decode_mode_spec): Likewise.
6181 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6182 behavior on 64-bit hosts with printf arg.
6f04d126 6183 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6184 (x_stop_queuing_selection_requests): Likewise.
6185 (x_get_window_property): Don't truncate byte count to an 'int'
6186 when tracing.
0b432f21 6187
5e073ec7
PE
6188 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6189 here, since it parses constructs like leading '-' and spaces,
6190 which are not wanted; and it overflows with large numbers.
6191 Instead, simply match F[0-9]+, which is what is wanted anyway.
6192
36372bf9
PE
6193 * alloc.c: Remove unportable assumptions about struct layout.
6194 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6195 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6196 (allocate_vectorlike, make_pure_vector): Use the new macros,
6197 plus offsetof, to remove unportable assumptions about struct layout.
6198 These assumptions hold on all porting targets that I know of, but
6199 they are not guaranteed, they're easy to remove, and removing them
6200 makes further changes easier.
6201
0b432f21
PE
6202 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6203 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6204 (string_overrun_cookie): Now const. Use initializers that
6205 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6206 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6207 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6208 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6209 multiple of sizeof (EMACS_INT); it need not be, if
6210 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6211 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6212
895009e1
JB
62132011-04-26 Juanma Barranquero <lekktu@gmail.com>
6214
6215 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6216
6a7a1b0b
TZ
62172011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6218
6219 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6220 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6221 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6222
841a1577 62232011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6224
6225 * lisp.h (Qdebug): List symbol.
895009e1 6226 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6227 * keyboard.c (debug-on-event): New variable.
6228 (handle_user_signal): Break into debugger when debug-on-event
6229 matches the current signal symbol.
6230
f2d3ba6f
DN
62312011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6232
6233 * alloc.c (check_sblock, check_string_bytes)
6234 (check_string_free_list): Convert to standard C.
6235
42ce4c63
TZ
62362011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6237
6238 * w32.c (emacs_gnutls_push): Fix typo.
6239
825cd63c
EZ
62402011-04-25 Eli Zaretskii <eliz@gnu.org>
6241
fb11d64d
EZ
6242 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6243 "cast to pointer from integer of different size".
6244
825cd63c
EZ
6245 Improve doprnt and its use in verror. (Bug#8545)
6246 * doprnt.c (doprnt): Document the set of format control sequences
6247 supported by the function. Use SAFE_ALLOCA instead of always
6248 using `alloca'.
6249
6250 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6251 is one byte too soon. Don't use xrealloc; instead xfree and
6252 xmalloc anew.
6253
e061a11b
TZ
62542011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6255
6256 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6257 callbacks stage.
6258
6259 * gnutls.c: Renamed global_initialized to
6260 gnutls_global_initialized. Added internals for the
6261 :verify-hostname-error, :verify-error, and :verify-flags
6262 parameters of `gnutls-boot' and documented those parameters in the
6263 docstring. Start callback support.
9173deec
JB
6264 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6265 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6266 on error. Return error code.
e061a11b
TZ
6267 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6268 (emacs_gnutls_read): Likewise.
6269 (Fgnutls_boot): Return handshake error code.
6270 (emacs_gnutls_handle_error): New function.
6271 (wsaerror_to_errno): Likewise.
6272
6273 * w32.h (emacs_gnutls_pull): Add prototype.
6274 (emacs_gnutls_push): Likewise.
6275
6276 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6277 (emacs_gnutls_push): Likewise.
6278
62792011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6280
6281 * process.c (wait_reading_process_output): Check if GnuTLS
6282 buffered some data internally if no FDs are set for TLS
6283 connections.
6284
6285 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6286 (LIBS): Link to USER_LIBS.
6287 ($(BLD)/gnutls.$(0)): New target.
6288
fa6996bc
EZ
62892011-04-24 Eli Zaretskii <eliz@gnu.org>
6290
eb35682e
EZ
6291 * xdisp.c (handle_single_display_spec): Rename the
6292 display_replaced_before_p argument into display_replaced_p, to
6293 make it consistent with the commentary. Fix typos in the
6294 commentary.
6295
e2ad650c
EZ
6296 * textprop.c (syms_of_textprop): Remove dead code.
6297 (copy_text_properties): Delete obsolete commentary about an
6298 interface that was deleted long ago. Fix typos in the description
6299 of arguments.
6300
1b2de274
EZ
6301 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6302 to changes in oldXMenu/XMenu.h from 2011-04-16.
6303 <menu_help_message, prev_menu_help_message>: Constify.
6304 (IT_menu_make_room): menu->help_text is now `const char **';
6305 adjust.
6306
6307 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6308 to changes in oldXMenu/XMenu.h from 2011-04-16.
6309 (struct XMenu): Declare `help_text' `const char **'.
6310
6311 * xfaces.c <Qunspecified>: Make extern again.
6312
6313 * syntax.c: Include sys/types.h before including regex.h, as
6314 required by Posix.
6315
762b15be
EZ
6316 * doc.c (get_doc_string): Improve the format passed to `error'.
6317
6318 * doprnt.c (doprnt): Improve commentary.
6319
6320 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6321
6322 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6323 them with etags.
6324
f1052e5d
EZ
6325 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6326 changes in globals.h immediately force recompilation.
762b15be
EZ
6327 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6328 $(CURDIR)/s/ms-w32.h.
6329 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6330
fa6996bc
EZ
6331 * character.c (Fchar_direction): Function deleted.
6332 (syms_of_character): Don't defsubr it.
6333 <char-direction-table>: Deleted.
6334
e6c3da20
EZ
63352011-04-23 Eli Zaretskii <eliz@gnu.org>
6336
6337 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6338 * doprnt.c: Include limits.h.
6339 (SIZE_MAX): New macro.
04f2d78b
CB
6340 (doprnt): Return a size_t value. 2nd arg is now size_t.
6341 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6342 Improve overflow protection. Support `l' modifier for integer
6343 conversions. Support %l conversion. Don't assume an EMACS_INT
6344 argument for integer conversions and for %c.
6345
6346 * lisp.h (doprnt): Restore prototype.
6347
6348 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6349 $(SRC)/character.h.
6350
6351 * Makefile.in (base_obj): Add back doprnt.o.
6352
6353 * deps.mk (doprnt.o): Add back prerequisites.
6354 (callint.o): Depend on character.h.
6355
6356 * eval.c (internal_lisp_condition_case): Include the handler
6357 representation in the error message.
6358 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6359 when breaking from the loop.
6360
6361 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6362
6363 * callint.c (Fcall_interactively): When displaying error message
6364 about invalid control letter, pass the character's codepoint, not
6365 a pointer to its multibyte form. Improve display of the character
6366 in octal and display also its hex code.
6367
6368 * character.c (char_string): Use %x to display the (unsigned)
6369 codepoint of an invalid character, to avoid displaying a bogus
6370 negative value.
6371
6372 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6373 `error', not SYMBOL_NAME itself.
6374
6375 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6376 character arguments to `error'.
6377
6378 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6379 to `error' in error message about FINAL_CHAR argument. Make sure
6380 FINAL_CHAR is a character, and use %c when it is passed as
6381 argument to `error'.
6382
4ffd0d6b 63832011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6384
6385 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6386
6387 * w32.c: Include <time.h>.
6388 (sys_localtime): New function.
6389
4ffd0d6b 63902011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6391
6392 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6393
4ffd0d6b 6394 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6395
4ffd0d6b 63962011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6397
4ffd0d6b
GM
6398 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6399 zombies (Bug#8467).
aac0c6e3 6400
04c56954
EZ
64012011-04-19 Eli Zaretskii <eliz@gnu.org>
6402
6403 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6404 gl_state.e_property when gl_state.object is Qt.
6405
6406 * insdel.c (make_gap_larger): Remove limitation of buffer size
6407 to <= INT_MAX.
6408
16a43933
CY
64092011-04-18 Chong Yidong <cyd@stupidchicken.com>
6410
6411 * xdisp.c (lookup_glyphless_char_display)
6412 (produce_glyphless_glyph): Handle cons cell entry in
6413 glyphless-char-display.
6414 (Vglyphless_char_display): Document it.
6415
6416 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6417 glyphless-char-display.
6418
4581706e
CY
64192011-04-17 Chong Yidong <cyd@stupidchicken.com>
6420
6421 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6422
6423 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6424
6425 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6426 definition for no-X builds.
6427
4887c6e2 64282011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6429
fd35b6f9
PE
6430 Static checks with GCC 4.6.0 and non-default toolkits.
6431
5c1ccb01
PE
6432 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6433
006c5daa
PE
6434 * process.c (keyboard_bit_set): Define only if SIGIO.
6435 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6436 (send_process): Repair possible setjmp clobbering.
6437
efc736d3
PE
6438 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6439
4e2fe2e6
PE
6440 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6441
f97334a2
PE
6442 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6443
4e75f29d
PE
6444 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6445 Define only if needed.
6446
90efadd1
PE
6447 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6448 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6449 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6450
3c647824
PE
6451 * dispextern.h (struct redisplay_interface): Rename param
6452 to avoid shadowing.
e264f262 6453 * termhooks.h (struct terminal): Likewise.
761383f4 6454 * xterm.c (xembed_send_message): Likewise.
3c647824 6455
b58c5c4a
PE
6456 * insdel.c (make_gap_smaller): Define only if
6457 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6458
cad59032
PE
6459 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6460 it.
6461
c339dc2e
PE
6462 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6463 so that we aren't warned about unused symbols.
6464
91a3e27b
PE
6465 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6466
399c71d3 6467 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6468
8ffc96f5
PE
6469 * xfns.c (x_real_positions): Mark locals as initialized.
6470
eef9bc79
PE
6471 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6472
098db9dd
PE
6473 * xterm.c: Fix problems found by static analysis with other toolkits.
6474 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6475 (x_dispatch_event): Declare static if USE_GTK, and
6476 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6477 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6478 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6479 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6480 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6481
eb18f6cc
PE
6482 * xmenu.c (menu_help_callback): Pointer type fixes.
6483 Use const pointers when pointing at readonly data. Avoid pointer
6484 signedness clashes.
6485 (FALSE): Remove unused macro.
6486 (update_frame_menubar): Remove unused decl.
6487
1fe72bf8
PE
6488 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6489
60d9e1db
PE
6490 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6491 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6492 (single_menu_item): Rename local to avoid shadowing.
6493
39261c26
PE
6494 * keyboard.c (make_lispy_event): Remove unused local var.
6495
018c5e19
PE
6496 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6497 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6498
63d2b86e
PE
6499 * bitmaps: Change bitmaps from unsigned char back to the X11
6500 compatible char. Avoid the old compiler warnings about
6501 out-of-range initializers by using, for example, '\xab' rather
6502 than 0xab.
6503
aefd87e1
PE
6504 * xgselect.c (xgselect_initialize): Check vs interface
6505 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6506
bf501fb9
PE
6507 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6508
e9829fdf
PE
6509 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6510 to read-only memory.
6511
1086c095
PE
6512 * fns.c (vector): Remove; this old hack is no longer needed.
6513
2baccd04 6514 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6515 Remove unused var.
dde42981 6516 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6517
72391843 6518 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6519
436c16df 6520 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6521 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6522 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6523
92bb796d 6524 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6525 (x_term_init): Remove local to avoid shadowing.
92bb796d 6526
764430a3 6527 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6528
6529 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6530 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6531
d1dfb56c
EZ
65322011-04-16 Eli Zaretskii <eliz@gnu.org>
6533
c4354cb4
EZ
6534 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6535
d1dfb56c
EZ
6536 Fix regex.c, syntax.c and friends for buffers > 2GB.
6537 * syntax.h (struct gl_state_s): Declare character position members
6538 EMACS_INT.
6539
6540 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6541
04f2d78b
CB
6542 * textprop.c (verify_interval_modification, interval_of):
6543 Declare arguments EMACS_INT.
d1dfb56c
EZ
6544
6545 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6546 EMACS_INT.
6547
6548 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6549
6550 * indent.c (Fvertical_motion): Local variable it_start is now
6551 EMACS_INT.
6552
6553 * regex.c (re_match, re_match_2, re_match_2_internal)
6554 (bcmp_translate, regcomp, regexec, print_double_string)
6555 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6556 (re_compile_pattern, re_exec): Declare arguments and local
6557 variables `size_t' and `ssize_t' and return values `regoff_t', as
6558 appropriate.
6559 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6560 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6561 <compile_stack_type>: `size' and `avail' are now `size_t'.
6562
6563 * regex.h <regoff_t>: Use ssize_t, not int.
6564 (re_search, re_search_2, re_match, re_match_2): Arguments that
6565 specify buffer/string position and length are now ssize_t and
6566 size_t. Return type is regoff_t.
6567
613052cd
BK
65682011-04-16 Ben Key <bkey76@gmail.com>
6569
6570 * nsfont.m: Fixed bugs in ns_get_family and
6571 ns_descriptor_to_entity that were caused by using free to
6572 deallocate memory blocks that were allocated by xmalloc (via
6573 xstrdup). This caused Emacs to crash when compiled with
6574 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6575 --enable-checking=xmallocoverrun). xfree is now used to
6576 deallocate these memory blocks.
6577
4170f62f 65782011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6579
71b41406
PE
6580 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6581
9587a89d
PE
6582 emacs_write: Accept and return EMACS_INT for sizes.
6583 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6584 et seq.
6585 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6586 Accept and return EMACS_INT.
6587 (emacs_gnutls_write): Return the number of bytes written on
6588 partial writes.
6589 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6590 (emacs_read, emacs_write): Remove check for negative size, as the
6591 Emacs source code has been audited now.
9587a89d
PE
6592 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6593 (emacs_read, emacs_write): Use it.
273a5f82
PE
6594 * process.c (send_process): Adjust to the new signatures of
6595 emacs_write and emacs_gnutls_write. Do not attempt to store
6596 a byte offset into an 'int'; it might overflow.
9587a89d 6597 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6598
3e047f51
PE
6599 * sound.c: Don't assume sizes fit in 'int'.
6600 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6601 Return EMACS_INT, not int.
3e047f51 6602 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6603 Accept EMACS_INT, not int.
6604 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6605 record read return values.
6606
cc39a9db
BK
66072011-04-15 Ben Key <bkey76@gmail.com>
6608
c9d0ec6d
JB
6609 * keyboard.c (Qundefined): Don't declare static since it is used
6610 in nsfns.m.
6611 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6612 static since they are used in nsfont.m.
cc39a9db 6613
6c60eb9f
SM
66142011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6615
6616 * process.c (Qprocessp): Don't declare static.
6617 * lisp.h (Qprocessp): Declare again.
6618
7990b61a
JB
66192011-04-15 Juanma Barranquero <lekktu@gmail.com>
6620
6621 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6622
5d4cb038
PE
66232011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6624
8bd7b830 6625 Improve C-level modularity by making more things 'static'.
cd64ea1d 6626
e3b27b31
PE
6627 Don't publish debugger-only interfaces to other modules.
6628 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6629 (verify_bytepos, count_markers): Move decls to the only modules
6630 that need them.
6631 * region-cache.h (pp_cache): Likewise.
6632 * window.h (check_all_windows): Likewise.
6633 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6634
5d4cb038
PE
6635 * sysdep.c (croak): Now static, if
6636 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6637 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6638
6639 * alloc.c (refill_memory_reserve): Now static if
6640 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6641 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6642
e87b6180
PE
6643 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6644 Define only if USE_LUCID.
6645
ac64929e
PE
6646 * xrdb.c (x_customization_string, x_rm_string): Now static.
6647
6f37259d
PE
6648 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6649 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6650
1683e3ab
PE
6651 * xdisp.c (draw_row_with_mouse_face): Now static.
6652 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6653
de9c2632
PE
6654 * window.h (check_all_windows): Mark externally visible.
6655
2b96acb7
PE
6656 * window.c (window_deletion_count): Now static.
6657
6658 * undo.c: Make symbols static if they're not exported.
6659 (last_undo_buffer, last_boundary_position, pending_boundary):
6660 Now static.
6661
50436f33
PE
6662 * textprop.c (interval_insert_behind_hooks): Now static.
6663 (interval_insert_in_front_hooks): Likewise.
6664
64520e5c
PE
6665 * term.c: Make symbols static if they're not exported.
6666 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6667 (max_frame_lines, tty_set_terminal_modes):
6668 (tty_reset_terminal_modes, tty_turn_off_highlight):
6669 (get_tty_terminal): Now static.
6670 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6671 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6672 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6673 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6674 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6675
1fa53021
PE
6676 * sysdep.c: Make symbols static if they're not exported.
6677 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6678 Now static.
6679 (sigprocmask_set, full_mask): Remove; unused.
6680 (wait_debugging): Mark as visible.
6681 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6682 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6683
d4b43b22
PE
6684 * syntax.c (syntax_temp): Define only if !__GNUC__.
6685
b7c513d0
PE
6686 * sound.c (current_sound_device, current_sound): Now static.
6687
989b29ad
PE
6688 * search.c (searchbufs, searchbuf_head): Now static.
6689
13a55a78
PE
6690 * scroll.c (scroll_cost): Remove; unused.
6691 * dispextern.h (scroll_cost): Remove decl.
6692
de68a1fc
PE
6693 * region-cache.h (pp_cache): Mark as externally visible.
6694
40ccffa6
PE
6695 * process.c: Make symbols static if they're not exported.
6696 (process_tick, update_tick, create_process, chan_process):
6697 (Vprocess_alist, proc_buffered_char, datagram_access):
6698 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6699 (deactivate_process): Mark defn as static, as well as decl.
6700 * lisp.h (create_process): Remove decl.
6701 * process.h (chan_process, Vprocess_alist): Remove decls.
6702
ad64fc97
PE
6703 * print.c: Make symbols static if they're not exported.
6704 (print_depth, new_backquote_output, being_printed, print_buffer):
6705 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6706 (print_interval, print_number_index, initial_stderr_stream):
6707 Now static.
6708 * lisp.h (Fprinc): Remove decl.
6709 (debug_output_compilation_hack): Mark as externally visible.
6710
adddb265
PE
6711 * sysdep.c (croak): Move decl from here to syssignal.h.
6712 * syssignal.h (croak): Put it here, so the API can be checked when
6713 'croak' is called from dissociate_if_controlling_tty.
6714
1717ede2
PE
6715 * minibuf.c: Make symbols static if they're not exported.
6716 (minibuf_save_list, choose_minibuf_frame): Now static.
6717 * lisp.h (choose_minibuf_frame): Remove decl.
6718
fa5fb2bc
PE
6719 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6720
1e3890d1
PE
6721 * lread.c: Make symbols static if they're not exported.
6722 (read_objects, initial_obarray, oblookup_last_bucket_number):
6723 Now static.
6724 (make_symbol): Remove; unused.
6725 * lisp.h (initial_obarray, make_symbol): Remove decls.
6726
8a1414fa
PE
6727 * keyboard.c: Make symbols static if they're not exported.
6728 (single_kboard, recent_keys_index, total_keys, recent_keys):
6729 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6730 (this_single_command_key_start, echoing, last_auto_save):
6731 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6732 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6733 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6734 (Vlispy_mouse_stem, double_click_count):
6735 Now static.
6736 (force_auto_save_soon): Define only if SIGDANGER.
6737 (ignore_mouse_drag_p): Now static if
6738 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6739 (print_help): Remove; unused.
6740 (stop_character, last_timer_event): Mark as externally visible.
6741 * keyboard.h (ignore_mouse_drag_p): Declare only if
6742 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6743 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6744 * lisp.h (echoing): Remove decl.
6745 (force_auto_save_soon): Declare only if SIGDANGER.
6746 * xdisp.c (redisplay_window): Simplify code, to make it more
6747 obvious that ignore_mouse_drag_p is not accessed if !defined
6748 USE_GTK && !defined HAVE_NS.
6749
93ea6e8f
PE
6750 * intervals.c: Make symbols static if they're not exported.
6751 (merge_properties_sticky, merge_interval_right, delete_interval):
6752 Now static.
6753 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6754
77382fcc
PE
6755 * insdel.c: Make symbols static if they're not exported.
6756 However, leave prepare_to_modify_buffer alone. It's never
6757 called from outside this function, but that appears to be a bug.
6758 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6759 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6760 (adjust_after_replace_noundo): Remove; unused.
6761 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6762 (signal_before_change): Remove decls.
77382fcc 6763
9306c32e
PE
6764 * indent.c (val_compute_motion, val_vmotion): Now static.
6765
cd44d2eb
PE
6766 * image.c: Make symbols static if they're not exported.
6767 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6768 if USE_GTK.
6769 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6770 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6771
ad9a7a06
PE
6772 * fringe.c (standard_bitmaps): Now static.
6773 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6774
81626931
PE
6775 * frame.c: Make symbols static if they're not exported.
6776 (x_report_frame_params, make_terminal_frame): Now static.
6777 (get_frame_param): Now static, unless HAVE_NS.
6778 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6779 (x_get_resource_string): Remove; not used.
6780 * frame.h (make_terminal_frame, x_report_frame_params):
6781 (x_get_resource_string); Remove decls.
6782 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6783 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6784
239f9db9
PE
6785 * font.c, fontset.c: Make symbols static if they're not exported.
6786 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6787 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6788 * font.c (font_close_object): Now static.
6789 * font.h (font_close_object): Remove.
6790 * fontset.c (FONTSET_OBJLIST): Remove.
6791 (free_realized_fontset) #if-0 the body, which does nothing.
6792 (face_suitable_for_char_p): #if-0, as it's never called.
6793 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6794 * xfaces.c (face_at_string_position):
6795 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6796 since 0 is always ASCII.
6797
dfcf3579
PE
6798 * fns.c (weak_hash_tables): Now static.
6799
5045092b
PE
6800 * fileio.c: Make symbols static if they're not exported.
6801 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6802 (Vwrite_region_annotation_buffers): Now static.
6803
57a96f5c
PE
6804 * eval.c: Make symbols static if they're not exported.
6805 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6806 * lisp.h (backtrace_list): Remove decl.
6807
35f08c38
PE
6808 * emacs.c: Make symbols static if they're not exported.
6809 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6810 (fatal_error_code, fatal_error_signal_hook, standard_args):
6811 Now static.
6812 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6813 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6814 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6815 * lisp.h (fatal_error_signal_hook): Remove decl.
6816 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6817
f44bd759
PE
6818 * editfns.c: Move a (normally-unused) function to its only use.
6819 * editfns.c, lisp.h (get_operating_system_release): Remove.
6820 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6821 worth the hassle of breaking this out.
6822
b532497d
PE
6823 * xterm.c: Make symbols static if they're not exported.
6824 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6825 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6826 (x_destroy_window, x_delete_display):
6827 Now static.
6828 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6829 (x_mouse_leave): Remove; unused.
6830 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6831 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6832 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6833 Remove decls.
6834 (x_mouse_leave): Declare only if WINDOWSNT.
6835 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6836 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6837 USE_X_TOOLKIT.
6838
1675728f
PE
6839 * ftxfont.c: Make symbols static if they're not exported.
6840 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6841 HAVE_FREETYPE.
6842 * font.h (ftxfont_driver): Likewise.
6843
e4cebfca
PE
6844 * xfns.c: Make symbols static if they're not exported.
6845 (x_last_font_name, x_display_info_for_name):
6846 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6847 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6848 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6849 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6850 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6851 (last_show_tip_args): Now static.
6852 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6853 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6854 (x_screen_planes): Remove; unused.
6855 * dispextern.h (x_screen_planes): Remove decl.
6856
5bf46f05
PE
6857 * dispnew.c: Make symbols static if they're not exported.
6858 * dispextern.h (redraw_garbaged_frames, scrolling):
6859 (increment_row_positions): Remove.
6860 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6861 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6862 Now static.
6863 (redraw_garbaged_frames): Remove; unused.
6864
435f4c28
PE
6865 * xfaces.c: Make symbols static if they're not exported.
6866 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6867 Remove decls.
6868 * xterm.h (defined_color): Remove decls.
6869 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6870 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6871 (menu_face_changed_default, defined_color, free_realized_face):
6872 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6873 (ascii_face_of_lisp_face): Remove; unused.
6874
8524aef3
PE
6875 * xdisp.c: Make symbols static if they're not exported.
6876 * dispextern.h (scratch_glyph_row, window_box_edges):
6877 (glyph_to_pixel_coords, set_cursor_from_row):
6878 (get_next_display_element, set_iterator_to_next):
6879 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6880 (show_mouse_face): Remove decls
6881 * frame.h (message_buf_print): Likewise.
6882 * lisp.h (pop_message, set_message, check_point_in_composition):
6883 Likewise.
6884 * xterm.h (set_vertical_scroll_bar): Likewise.
6885 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6886 (message_buf_print, scratch_glyph_row, displayed_buffer):
6887 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6888 (get_next_display_element, show_mouse_face, window_box_edges):
6889 (frame_to_window_pixel_xy, check_point_in_composition):
6890 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6891 (glyph_to_pixel_coords): Remove; unused.
6892
16390cd2
PE
6893 * dired.c (file_name_completion): Now static.
6894
6895 * dbusbind.c (xd_in_read_queued_messages): Now static.
6896
a25f4dfa
PE
6897 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6898 * data.c (circular_list_error): Remove.
6899
14a9c8df
PE
6900 * commands.h (last_point_position, last_point_position_buffer):
6901 (last_point_position_window): Remove decls.
6902 * keyboard.c: Make these variables static.
6903
04f2d78b
CB
6904 * coding.h (coding, code_convert_region, encode_coding_gap):
6905 Remove decls.
74ab6df5
PE
6906 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6907 (iso_code_class, detect_coding, code_convert_region): Now static.
6908 (encode_coding_gap): Remove; unused.
6909
38dfbee1
PE
6910 * chartab.c (chartab_chars, chartab_bits): Now static.
6911
a2cb4e63
PE
6912 * charset.h (charset_iso_8859_1): Remove decl.
6913 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6914 Now static.
6915
127198fd
PE
6916 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6917 * ccl.c (Vccl_program_table): Now static.
6918 (check_ccl_update): Remove; unused.
6919
d85b608f
PE
6920 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6921 * category.h: ... from here.
6922 * category.c (check_category_table, set_category_set): Now static.
6923
31cd66f3
PE
6924 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6925 * lisp.h: Remove these decls.
6926
c358e587
PE
6927 * buffer.c (buffer_count): Remove unused var.
6928
e78aecca
PE
6929 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6930 so that it's not optimized away.
6931 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6932 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6933 exported only to the debugger.
6934
e192d7d3 6935 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6936 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6937
92470028
PE
6938 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6939 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6940 was inaccessible from Lisp.
6941 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6942 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6943
244ed907
PE
6944 alloc.c: Import and export fewer symbols, and remove unused items.
6945 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6946 is defined.
6947 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6948 it's not optimized away by whole-program optimization.
6949 (message_enable_multibyte, free_misc): Remove.
6950 (catchlist, handlerlist, mark_backtrace):
6951 Declare only if BYTE_MARK_STACK.
6952 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6953 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6954 (message_enable_multibyte): Remove decl.
6955 (free_misc, interval_free_list, float_block, float_block_index):
6956 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6957 (cons_free_list, last_marked_index):
6958 Now static.
6959 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6960 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6961 (mark_backtrace): Define only if BYTE_MARK_STACK.
6962 * xdisp.c (message_enable_multibyte): Now static.
6963
61c2b50e 6964 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6965 This makes it easier for human readers (and static analyzers)
6966 to see whether these variables are used from other modules.
6967 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6968 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6969 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6970 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6971 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6972 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6973 * xmenu.c, xselect.c:
6974 Declare Q* vars static if they are not used in other modules.
6975 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6976 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6977 Remove decls of unexported vars.
6978 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6979
95c82688
PE
6980 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6981
16a97296
PE
6982 Make Emacs functions such as Fatom 'static' by default.
6983 This makes it easier for human readers (and static analyzers)
6984 to see whether these functions can be called from other modules.
6985 DEFUN now defines a static function. To make the function external
6986 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6987 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6988 (Finit_image_library):
16a97296
PE
6989 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6990 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6991 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6992 Remove decls, since these functions are now static.
6993 (Funintern, Fget_internal_run_time): New decls, since these functions
6994 were already external.
95c82688 6995
16a97296
PE
6996 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6997 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6998 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6999 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7000 * keyboard.c, keymap.c, lread.c:
7001 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7002 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7003 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7004 Mark functions with DEFUE instead of DEFUN,
7005 if they are used in other modules.
7006 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7007 decls for now-static functions.
7008 * buffer.h (Fdelete_overlay): Remove decl.
7009 * callproc.c (Fgetenv_internal): Mark as internal.
7010 * composite.c (Fremove_list_of_text_properties): Remove decl.
7011 (Fcomposition_get_gstring): New forward static decl.
7012 * composite.h (Fcomposite_get_gstring): Remove decl.
7013 * dired.c (Ffile_attributes): New forward static decl.
7014 * doc.c (Fdocumntation_property): New forward static decl.
7015 * eval.c (Ffetch_bytecode): New forward static decl.
7016 (Funintern): Remove extern decl; now in .h file where it belongs.
7017 * fileio.c (Fmake_symbolic_link): New forward static decl.
7018 * image.c (Finit_image_library): New forward static decl.
7019 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7020 * intervals.h (Fprevious_property_change):
7021 (Fremove_list_of_text_properties): Remove decls.
7022 * keyboard.c (Fthis_command_keys): Remove decl.
7023 (Fcommand_execute): New forward static decl.
7024 * keymap.c (Flookup_key): New forward static decl.
7025 (Fcopy_keymap): Now static.
7026 * keymap.h (Flookup_key): Remove decl.
7027 * process.c (Fget_process): New forward static decl.
7028 (Fprocess_datagram_address): Mark as internal.
7029 * syntax.c (Fsyntax_table_p): New forward static decl.
7030 (skip_chars): Remove duplicate decl.
7031 * textprop.c (Fprevious_property_change): New forward static decl.
7032 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7033 Now internal.
7034 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7035 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7036
785bbd42
PE
7037 * editfns.c (Fformat): Remove unreachable code.
7038
8b913b57
AS
70392011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7040
7041 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7042 change. (Bug#8496)
7043
a6744a35
EZ
70442011-04-13 Eli Zaretskii <eliz@gnu.org>
7045
7046 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7047 when at ZV. (Bug#8487)
7048
e7974947
AS
70492011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7050
baad03f0
AS
7051 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7052 (Bug#8437)
7053 * keyboard.c (parse_tool_bar_item): Likewise.
7054 * sound.c (sound_cleanup, alsa_close): Likewise.
7055 * termcap.c (tgetent): Likewise.
7056 * xfns.c (x_default_font_parameter): Likewise.
7057 * xsettings.c (read_and_apply_settings): Likewise.
7058
e7974947
AS
7059 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7060 (overrun_check_free): Protoize.
7061
28272684
PE
70622011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7063
7064 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7065 since callers should never pass a negative size.
7066 Change the signature to match that of plain 'read' and 'write'; see
7067 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7068 * lisp.h: Update prototypes of emacs_write and emacs_read.
7069
11997c76
EZ
70702011-04-11 Eli Zaretskii <eliz@gnu.org>
7071
7072 * xdisp.c (redisplay_window): Don't try to determine the character
7073 position of the scroll margin if the window start point w->startp
e896f03c 7074 is outside the buffer's accessible region. (Bug#8468)
11997c76 7075
8a2cbd72
EZ
70762011-04-10 Eli Zaretskii <eliz@gnu.org>
7077
7078 Fix write-region and its subroutines for buffers > 2GB.
7079 * fileio.c (a_write, e_write): Modify declaration of arguments and
7080 local variables to support buffers larger than 2GB.
7081 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7082
7083 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7084 argument, local variables, and return value.
7085
7086 * lisp.h: Update prototypes of emacs_write and emacs_read.
7087
7088 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7089
4073e537 70902011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7091
1ebfdcb6
PE
7092 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7093
b2ded58d
PE
7094 Fix more problems found by GCC 4.6.0's static checks.
7095
7d66342c
PE
7096 * xdisp.c (vmessage): Use a better test for character truncation.
7097
bbf47d44
PE
7098 * charset.c (load_charset_map): <, not <=, for optimization,
7099 and to avoid potential problems with integer overflow.
9248994d 7100 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7101 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7102 * editfns.c (Fformat): Likewise.
1e69125e 7103 * syntax.c (skip_chars): Likewise.
3befa583 7104
e3019616
PE
7105 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7106 This also lets GCC 4.6.0 generate slightly better loop code.
7107
becfa255
PE
7108 * callint.c (Fcall_interactively): <, not <=, for optimization.
7109 (Fcall_interactively): Count the number of arguments produced,
7110 not the number of arguments given. This is simpler and lets GCC
7111 4.6.0 generate slightly better code.
7112
dae0cd48
PE
7113 * ftfont.c: Distingish more carefully between FcChar8 and char.
7114 The previous code passed unsigned char * to a functions like
7115 strlen and xstrcasecmp that expect char *, which does not
7116 conform to the C standard.
7117 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7118 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7119 char * when the C standard requires it.
7120
76032d70
PE
7121 * keyboard.c (read_char): Remove unused var.
7122
eb3f1cc8
PE
7123 * eval.c: Port to Windows vsnprintf (Bug#8435).
7124 Include <limits.h>.
7125 (SIZE_MAX): Define if the headers do not.
7126 (verror): Do not give up if vsnprintf returns a negative count.
7127 Instead, grow the buffer. This ports to Windows vsnprintf, which
7128 does not conform to C99. Problem reported by Eli Zaretskii.
7129 Also, simplify the allocation scheme, by avoiding the need for
7130 calling realloc, and removing the ALLOCATED variable.
7131
70476b54
PE
7132 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7133
12020a9e
PE
7134 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7135 But keep the doprint source code for now, as we might revamp it
7136 and use it again (Bug#8435).
ea6c7ae6
PE
7137 * lisp.h (doprnt): Remove.
7138 * Makefile.in (base_obj): Remove doprnt.o.
7139 * deps.mk (doprnt.o): Remove.
7140
5fdb398c
PE
7141 error: Print 32- and 64-bit integers portably (Bug#8435).
7142 Without this change, on typical 64-bit hosts error ("...%d...", N)
7143 was used to print both 32- and 64-bit integers N, which relied on
7144 undefined behavior.
7145 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7146 New macro.
7147 * lisp.h (error, verror): Mark as printf-like functions.
7148 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7149 Report overflow in size calculations when allocating printf buffer.
7150 Do not truncate output string at its first null byte.
7151 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7152 Truncate the output at a character boundary, since vsnprintf does not
7153 do that.
7154 * charset.c (check_iso_charset_parameter): Convert internal
7155 character to string before calling 'error', since %c now has the
7156 printf meaning.
7157 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7158 overflow when computing char to be passed to 'error'. Do not
7159 pass Lisp_Object to 'error'; pass the integer instead.
7160 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7161 formatted with plain %d.
7162
b189fa66
PE
7163 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7164
bff87ef0
PE
7165 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7166
7e2cac20
PE
7167 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7168
ce4d90b5
PE
7169 * xterm.c (x_catch_errors): Remove duplicate declaration.
7170
266c9547
PE
7171 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7172
79c49ad2
PE
7173 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7174
368f4090
JM
71752011-04-10 Jim Meyering <meyering@redhat.com>
7176
7177 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7178 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7179 return ssize_t not "int", and use size_t as the buffer length.
7180 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7181 * gnutls.h: Update declarations.
7182 * process.c (read_process_output): Use ssize_t, to match.
7183 (send_process): Likewise.
7184
a32d4040
CY
71852011-04-09 Chong Yidong <cyd@stupidchicken.com>
7186
7187 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7188
8546720e 71892011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7190
04f2d78b
CB
7191 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7192 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7193
8546720e
GM
7194 * xterm.c (handle_one_xevent):
7195 * xmenu.c (create_and_show_popup_menu):
7196 * xselect.c (x_decline_selection_request)
7197 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7198
0a2f5c1a 71992011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7200
7201 Fix some uses of `int' instead of EMACS_INT.
7202 * search.c (string_match_1, fast_string_match)
7203 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7204 (scan_buffer, find_next_newline_no_quit)
7205 (find_before_next_newline, search_command, Freplace_match)
7206 (Fmatch_data): Make some `int' variables be EMACS_INT.
7207
7208 * xdisp.c (display_count_lines): 3rd argument and return value now
7209 EMACS_INT. All callers changed.
7210 (pint2hrstr): Last argument is now EMACS_INT.
7211
7212 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7213 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7214 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7215 (decode_coding_utf_16, decode_coding_emacs_mule)
7216 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7217 (decode_coding_ccl, decode_coding_charset)
7218 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7219 (decode_coding_iso_2022, decode_coding_emacs_mule)
7220 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7221 <char_offset, last_offset>: Declare EMACS_INT.
7222 (encode_coding_utf_8, encode_coding_utf_16)
7223 (encode_coding_emacs_mule, encode_invocation_designation)
7224 (encode_designation_at_bol, encode_coding_iso_2022)
7225 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7226 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7227 Declare EMACS_INT.
7228 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7229 (encode_invocation_designation): Last argument P_NCHARS is now
7230 EMACS_INT.
7231 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7232 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7233
7234 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7235 All users changed.
7236
7237 * ccl.c (Fccl_execute_on_string): Declare some variables
7238 EMACS_INT.
7239
8546720e 72402011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7241
7242 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7243
4e19a977
CS
72442011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7245
7246 * process.c (Fformat_network_address): Doc fix.
7247
87302331
R
72482011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7249
ee7683eb 7250 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7251
cbb59342
CY
72522011-04-08 Chong Yidong <cyd@stupidchicken.com>
7253
7254 * keyboard.c (read_char): Call Lisp function help-form-show,
7255 instead of using internal_with_output_to_temp_buffer.
7256 (Qhelp_form_show): New var.
e0d38eeb 7257 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7258
7259 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7260
7261 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7262
e67a13ab
CY
72632011-04-06 Chong Yidong <cyd@stupidchicken.com>
7264
04f2d78b
CB
7265 * process.c (Flist_processes): Remove to Lisp.
7266 (list_processes_1): Delete.
e67a13ab 7267
973f782d
EZ
72682011-04-06 Eli Zaretskii <eliz@gnu.org>
7269
7c106b1e
EZ
7270 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7271
973f782d
EZ
7272 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7273
41cf7d1a 72742011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7275
ca23cc88
PE
7276 Fix more problems found by GCC 4.6.0's static checks.
7277
f390e2d5
PE
7278 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7279
42eea0d0
PE
7280 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7281
b69769da 7282 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7283
f9541e84
PE
7284 * xdisp.c (vmessage): Mark as a printf-like function.
7285
13841b55
PE
7286 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7287
c136c10f
PE
7288 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7289
5e2d4a30
PE
7290 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7291 printf-like functions.
7292 (tiff_load): Add casts to remove these marks before passing them
7293 to system-supplied API.
7294
583f48b9
PE
7295 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7296
b25d760e
PE
7297 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7298 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7299 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7300 directly, rather than having caller test rule sign. This avoids
7301 some unnecessary tests.
7302 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7303 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7304 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7305
bc7b6697 7306 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7307 (xfont_open): Avoid unnecessary tests.
bc7b6697 7308
27ccc379
PE
7309 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7310
dcd5c89a
PE
7311 * composite.h, composite.c (composition_gstring_put_cache):
7312 Use EMACS_INT, not int, for length.
7313
b13a45c6
PE
7314 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7315 breaking out part of COMPOSITION_DECODE_RULE.
7316 (COMPOSITION_DECODE_RULE): Use it.
7317 * composite.c (get_composition_id): Remove unused local vars,
7318 by using the new macro.
7319
1e792e4d
PE
7320 * textprop.c (set_text_properties_1): Change while to do-while,
7321 since the condition is always true at first.
7322
dc6c6455 7323 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7324 (interval_deletion_adjustment): Return unsigned value.
7325 All uses changed.
dc6c6455 7326
aba7731a
PE
7327 * process.c (list_processes_1, create_pty, read_process_output):
7328 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7329 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7330 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7331 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7332 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7333
fdfc4bf3
PE
7334 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7335
fca8fe46 7336 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7337 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7338
06a0259a 7339 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7340 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7341 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7342
e7b9e80f
PE
7343 * print.c (print_error_message): Avoid int overflow.
7344
56201685
PE
7345 * font.c (font_list_entities): Redo for clarity,
7346 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7347
78834453 7348 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7349 (font_score): Avoid potential overflow in diff calculation.
78834453 7350
0bc0b309 7351 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7352 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7353
e610eaca
PE
7354 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7355
b895abce
PE
7356 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7357 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7358 can always succeed if overflow has undefined behavior.
7359
1f1d9321 7360 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7361 (wordify): Omit three unnecessary tests.
1f1d9321 7362
c59478bc
PE
7363 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7364 All callers changed. This avoids the need for an unused var.
7365
79b73827
PE
7366 * casefiddle.c (casify_region): Remove var that is set but not used.
7367
a4db5dfe
PE
7368 * dired.c (file_name_completion): Remove var that is set but not used.
7369
43aae36e
PE
7370 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7371
2a47c44d 7372 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7373 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7374
a37c69bf
PE
7375 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7376 Check for integer overflow on size calculations.
7377
328ab8e7
PE
7378 * buffer.c (Fprevious_overlay_change): Remove var that is set
7379 but not used.
7380
e5a2a5cb
PE
7381 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7382 Remove vars that are set but not used.
8d84a6eb 7383 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7384 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7385
a60e5f68
PE
7386 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7387
f661cb61 7388 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7389 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7390
f0397f5a
PE
7391 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7392 that are set but not used.
7393
8664db06 7394 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7395 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7396
6abdaa4a
PE
7397 * xselect.c (x_get_local_selection, x_handle_property_notify):
7398 Remove vars that are set but not used.
7399
0ce7538d 7400 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7401 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7402
9ae848fc
PE
7403 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7404 Remove var that is set but not used.
0b918413
PE
7405 (scroll_bar_windows_size): Now size_t, not int.
7406 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7407 Check for overflow.
9ae848fc 7408
a5a62657
PE
7409 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7410 (map_tty_color) [!defined MSDOS]: Likewise.
7411
5c5cdd39
PE
7412 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7413
66ebf983
PE
7414 * coding.c: Remove vars that are set but not used.
7415 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7416 All callers changed.
7417 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7418 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7419 (decode_coding_charset): Remove vars that are set but not used.
7420
1be4d761
PE
7421 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7422 that is set but not used.
7423
47553fa8
PE
7424 * print.c (print_object): Remove var that is set but not used.
7425
1f7196bf 7426 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7427 The gnulib version avoids calling malloc in the usual case,
7428 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7429 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7430 * filelock.c (current_lock_owner): Likewise.
7431 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7432 * sysdep.c: Include allocator.h, careadlinkat.h.
7433 (emacs_no_realloc_allocator): New static constant.
7434 (emacs_readlink): New function.
fdb61804
PE
7435 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7436 ../lib/careadlinkat.h.
d1fdcab7 7437
f84c17c7
SM
74382011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7439
7440 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7441 first non-nil return value).
7442
ef3862ad
JD
74432011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7444
7445 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7446 if not defined (Bug#8403).
7447
376a7006
JB
74482011-04-02 Juanma Barranquero <lekktu@gmail.com>
7449
7450 * xdisp.c (display_count_lines): Remove parameter `start',
7451 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7452 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7453 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7454 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7455 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7456 and thereabouts. All callers changed.
7457 (get_per_char_metric): Remove parameter `f', unused since
7458 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7459
6ca3801d
JM
74602011-04-02 Jim Meyering <meyering@redhat.com>
7461
7462 do not dereference NULL upon failed strdup
7463 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7464 (ns_get_family): Likewise.
7465
d8e2b5ba
JB
74662011-04-02 Juanma Barranquero <lekktu@gmail.com>
7467
7468 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7469
8c74fcbd
JD
74702011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7471
7472 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7473 later (Bug#8403).
7474
7200d79c
SM
74752011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7476
03408648 7477 Add lexical binding.
7200d79c 7478
03408648
SM
7479 * window.c (Ftemp_output_buffer_show): New fun.
7480 (Fsave_window_excursion):
7481 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7482
7483 * lread.c (lisp_file_lexically_bound_p): New function.
7484 (Fload): Bind Qlexical_binding.
7485 (readevalloop): Remove `evalfun' arg.
7486 Bind Qinternal_interpreter_environment.
7487 (Feval_buffer): Bind Qlexical_binding.
7488 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7489 Mark as dynamic.
7490 (syms_of_lread): Declare `lexical-binding'.
7491
7492 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7493
7494 * keyboard.c (eval_dyn): New fun.
7495 (menu_item_eval_property): Use it.
ca105506
SM
7496
7497 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7498
03408648
SM
7499 * fns.c (concat, mapcar1): Accept byte-code-functions.
7500
7501 * eval.c (Fsetq): Handle lexical vars.
7502 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7503 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7504 (FletX, Flet): Obey lexical binding.
7505 (Fcommandp): Handle closures.
7506 (Feval): New `lexical' arg.
7507 (eval_sub): New function extracted from Feval. Use it almost
7508 everywhere where Feval was used. Look up vars in lexical env.
7509 Handle closures.
7510 (Ffunctionp): Move from subr.el.
7511 (Ffuncall): Handle closures.
7512 (apply_lambda): Remove `eval_flags'.
7513 (funcall_lambda): Handle closures and new byte-code-functions.
7514 (Fspecial_variable_p): New function.
7515 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7516 but without exporting it to Lisp.
23aba0ea 7517
23aba0ea 7518 * doc.c (Fdocumentation, store_function_docstring):
03408648 7519 * data.c (Finteractive_form): Handle closures.
23aba0ea 7520
03408648
SM
7521 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7522 interactive spec.
ba83908c 7523
04f2d78b
CB
7524 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7525 New byte-codes.
03408648
SM
7526 (exec_byte_code): New function extracted from Fbyte_code to handle new
7527 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7528
03408648 7529 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7530
03408648 7531 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7532
e2abce01
JB
75332011-03-31 Juanma Barranquero <lekktu@gmail.com>
7534
7535 * xdisp.c (redisplay_internal): Fix prototype.
7536
63696a73 75372011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7538
63696a73 7539 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7540 (try_scrolling): Use it when setting scroll_limit.
7541 Limit scrolling to 100 screen lines.
63696a73
EZ
7542 (redisplay_window): Even when falling back on "recentering",
7543 position point in the window according to scroll-conservatively,
7544 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7545
7546 (try_scrolling): When point is above the window, allow searching
7547 as far as scroll_max, or one screenful, to compute vertical
7548 distance from PT to the scroll margin position. This prevents
7549 try_scrolling from unnecessarily failing when
7550 scroll-conservatively is set to a value slightly larger than the
7551 window height. Clean up the case of PT below the margin at bottom
7552 of window: scroll_max can no longer be INT_MAX. When aggressive
7553 scrolling is in use, don't let point enter the opposite scroll
7554 margin as result of the scroll.
7555 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7556 threshold of 100 lines for never-recentering scrolling.
7557
e4cc2dfc
JB
75582011-03-31 Juanma Barranquero <lekktu@gmail.com>
7559
7560 * dispextern.h (move_it_by_lines):
7561 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7562 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7563 (message_log_check_duplicate): Remove parameters `prev_bol' and
7564 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7565 (redisplay_internal): Remove parameter `preserve_echo_area',
7566 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7567
7568 * indent.c (Fvertical_motion):
7569 * window.c (window_scroll_pixel_based, Frecenter):
7570 Don't pass `need_y_p' to `move_it_by_lines'.
7571
1c470562
SM
75722011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7573
44f230aa
SM
7574 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7575 steal a few bits to be more compact.
7576 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7577 Remove unneeded casts.
7578
1c470562
SM
7579 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7580
888adce9
ZK
75812011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7582
7583 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7584 binding" message (bug#7967).
7585
f838ed7b
PE
75862011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7587
77861b95
PE
7588 Fix more problems found by GCC 4.6.0's static checks.
7589
de6dbc14
PE
7590 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7591 Remove unused local var.
7592
f838ed7b
PE
7593 * editfns.c (Fmessage_box): Remove unused local var.
7594
792c7b2b
PE
7595 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7596 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7597 Omit unused local vars.
c499e557 7598 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7599 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7600 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7601 Omit unused local var.
7602
ba0165e1
PE
7603 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7604 Don't assume string length fits in int.
32ad8845 7605 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7606 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7607
3c59b4c9
PE
7608 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7609 instead of alloca (Bug#8344).
7610
a3eed478 7611 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7612 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7613
eb4d412d
PE
7614 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7615
1658b401
PE
7616 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7617 concerns.
7618
7619 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7620
7621 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7622
9a2c6e05
PE
7623 * keyboard.c (syms_of_keyboard): Use the same style as later
7624 in this function when indexing through an array. This also
7625 works around GCC bug 48267.
7626
03d0a109
PE
7627 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7628
44f730c8
PE
7629 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7630
fe75f926
PE
7631 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7632 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7633
ffa8c828
PE
7634 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7635 This avoids undefined behavior on integer overflow, and is a bit
7636 more convenient anyway since it is compared to a size_t variable.
7637
c5101a77
PE
7638 Variadic C functions now count arguments with size_t, not int.
7639 This avoids an unnecessary limitation on 64-bit machines, which
7640 caused (substring ...) to crash on large vectors (Bug#8344).
7641 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7642 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7643 All variadic functions and their callers changed accordingly.
c5101a77
PE
7644 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7645 * data.c (arith_driver, float_arith_driver): Likewise.
7646 * editfns.c (general_insert_function): Likewise.
7647 * eval.c (struct backtrace.nargs, interactive_p)
7648 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7649 (funcall_lambda, mark_backtrace): Likewise.
7650 * fns.c (concat): Likewise.
7651 * frame.c (x_set_frame_parameters): Likewise.
7652 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7653 0 if not found, not -1. All callers changed.
7654
dd3f25f7
PE
7655 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7656 (stack_copy_size): Now size_t, not int.
7657 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7658
461c2ab9
JB
76592011-03-28 Juanma Barranquero <lekktu@gmail.com>
7660
7661 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7662 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7663 All callers changed.
7664
7665 * lisp.h (multibyte_char_to_unibyte):
7666 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7667 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7668 * character.h (CHAR_TO_BYTE8):
7669 * cmds.c (internal_self_insert):
7670 * editfns.c (general_insert_function):
7671 * keymap.c (push_key_description):
7672 * search.c (Freplace_match):
7673 * xdisp.c (message_dolog, set_message_1): All callers changed.
7674
f6d62986
SM
76752011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7676
7677 * keyboard.c (safe_run_hook_funcall): New function.
7678 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7679 don't set the hook to nil, but remove the offending function instead.
7680 (Qcommand_hook_internal): Remove, unused.
7681 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7682 Vcommand_hook_internal.
7683
7684 * eval.c (enum run_hooks_condition): Remove.
7685 (funcall_nil, funcall_not): New functions.
7686 (run_hook_with_args): Call each function through a `funcall' argument.
7687 Remove `cond' argument, now redundant.
7688 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7689 (Frun_hook_with_args_until_failure): Adjust accordingly.
7690 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7691
1db5b1ad
JB
76922011-03-28 Juanma Barranquero <lekktu@gmail.com>
7693
7694 * dispextern.h (string_buffer_position): Remove declaration.
7695
7696 * print.c (strout): Remove parameter `multibyte', unused since
7697 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7698
7699 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7700 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7701 All callers changed.
7702
7703 * w32.c (_wsa_errlist): Use braces for struct initializers.
7704
7705 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7706 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7707 All callers changed.
7708 (string_buffer_position): Likewise. Also, make static (it's never
7709 used outside xdisp.c).
7710 (cursor_row_p): Remove parameter `w', unused since
7711 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7712 (decode_mode_spec): Remove parameter `precision', introduced during
7713 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7714 All callers changed.
7715
5ffb62aa
JD
77162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7717
7718 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7719
461c2ab9 77202011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7721
7722 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7723 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7724 (ns_update_auto_hide_menu_bar): New functions.
7725 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7726 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7727 ns_constrain_all_frames.
7728 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7729 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7730
5c380ffb
JD
77312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7732
7733 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7734
9af30bdf
GM
77352011-03-27 Glenn Morris <rgm@gnu.org>
7736
7737 * syssignal.h: Replace RETSIGTYPE with void.
7738 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7739 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7740 Replace SIGTYPE with void everywhere.
7741 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7742 * s/template.h (SIGTYPE): Remove commented out definition.
7743
e2abce01
JB
77442011-03-26 Eli Zaretskii <eliz@gnu.org>
7745
7746 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7747 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7748
f868cd8a
JB
77492011-03-26 Juanma Barranquero <lekktu@gmail.com>
7750
59eb0929
JB
7751 * w32.c (read_unc_volume): Use parameter `henum', instead of
7752 global variable `wget_enum_handle'.
7753
7754 * keymap.c (describe_vector): Remove parameters `indices' and
7755 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7756 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7757
f868cd8a
JB
7758 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7759
7760 * keyboard.c (timer_check): Remove parameter `do_it_now',
7761 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7762 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7763 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7764
7765 * keyboard.c (read_char):
7766 * w32menu.c (w32_menu_display_help):
7767 * xmenu.c (show_help_event, menu_help_callback):
7768 Adjust calls to `show_help_echo'.
7769
7770 * gtkutil.c (xg_maybe_add_timer):
7771 * keyboard.c (readable_events):
7772 * process.c (wait_reading_process_output):
7773 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7774
7775 * insdel.c (adjust_markers_gap_motion):
7776 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7777 (gap_left, gap_right): Don't call it.
7778
2ecf6fdb
CY
77792011-03-25 Chong Yidong <cyd@stupidchicken.com>
7780
7781 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7782 incurred during fontification.
7783
6b1f9ba4
JB
77842011-03-25 Juanma Barranquero <lekktu@gmail.com>
7785
7786 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7787 (DEFVAR_PER_BUFFER): Don't pass it.
7788
7789 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7790 (scrolling_window): Don't pass it.
7791
0f4a96b5
JB
77922011-03-25 Juanma Barranquero <lekktu@gmail.com>
7793
7794 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7795
7796 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7797 and `suffix'.
7798 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7799 of variables specific to SELinux and computation of `encoded_absname'.
7800
7801 * image.c (XPutPixel): Remove unused variable `height'.
7802
7803 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7804
7805 * unexw32.c (get_section_info): Remove unused variable `section'.
7806
7807 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7808 (system_process_attributes): Remove unused variable `sess'.
7809 (sys_read): Remove unused variable `err'.
7810
7811 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7812 (w32_wnd_proc): Remove unused variable `isdead'.
7813 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7814 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7815 (x_create_tip_frame): Remove unused variable `tem'.
7816
7817 * w32inevt.c (w32_console_read_socket):
7818 Remove unused variable `no_events'.
7819
7820 * w32term.c (x_draw_composite_glyph_string_foreground):
7821 Remove unused variable `width'.
7822
1149507c
JB
78232011-03-24 Juanma Barranquero <lekktu@gmail.com>
7824
7825 * w32term.c (x_set_glyph_string_clipping):
7826 Don't pass uninitialized region to CombineRgn.
7827
9c88f339
JB
78282011-03-23 Juanma Barranquero <lekktu@gmail.com>
7829
7830 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7831 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7832 (Fx_close_connection): Remove unused variable `i'.
7833
7834 * w32font.c (w32font_draw): Return number of glyphs.
7835 (w32font_open_internal): Remove unused variable `i'.
7836 (w32font_driver): Add missing initializer.
7837
7838 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7839 (fill_in_menu): Remove unused variable `items_added'.
7840
7841 * w32term.c (last_mouse_press_frame): Remove static global variable.
7842 (w32_clip_to_row): Remove unused variable `f'.
7843 (x_delete_terminal): Remove unused variable `i'.
7844
7845 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7846 (NOTHING): Remove unused static global variable.
7847 (uniscribe_check_otf): Remove unused variable `table'.
7848 (uniscribe_font_driver): Add missing initializers.
7849
dee091a3
JD
78502011-03-23 Julien Danjou <julien@danjou.info>
7851
7852 * term.c (Fsuspend_tty, Fresume_tty):
7853 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7854 * window.c (temp_output_buffer_show):
7855 * insdel.c (signal_before_change):
7856 * frame.c (Fhandle_switch_frame):
7857 * fileio.c (Fdo_auto_save):
7858 * emacs.c (Fkill_emacs):
7859 * editfns.c (save_excursion_restore):
7860 * cmds.c (internal_self_insert):
7861 * callint.c (Fcall_interactively):
7862 * buffer.c (Fkill_all_local_variables):
7863 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7864 Use Frun_hooks.
0f4a96b5 7865 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7866 unconditionally since it does the check itself.
dee091a3 7867
2c520ab5 78682011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7869
c9c49752
PE
7870 Fix more problems found by GCC 4.5.2's static checks.
7871
8abc3f12
PE
7872 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7873 the first time through the loop, since we know p0 < p1 then.
7874 This also avoids a gcc -Wstrict-overflow warning.
7875
a2d26660
PE
7876 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7877 leading to a memory leak, possible in functions like
7878 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7879 of objects (Bug#8318).
a2d26660 7880
916c72e9
PE
7881 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7882 that could (at least in theory) be that large.
7883
19ab8a18
PE
7884 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7885 This is less likely to overflow, and avoids undefined behavior if
7886 overflow does occur. All callers changed. Use strtoul to scan
7887 for the unsigned long integer.
b7cbbd6f
PE
7888 (pint2hrstr): Simplify and tune code slightly.
7889 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7890
f0641eff
PE
7891 * scroll.c (do_scrolling): Work around GCC bug 48228.
7892 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7893
7f650bb9
PE
7894 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7895 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7896 (validate_x_resource_name): Simplify count usage.
7897 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7898
37dd57d1
PE
7899 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7900 fail (Bug#8306).
81e56e61 7901
699979fc 7902 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7903
401bf9b4
PE
7904 * process.c (Fmake_network_process): Use socklen_t, not int,
7905 where POSIX says socklen_t is required in portable programs.
7906 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7907 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7908 (Fmake_network_process, server_accept_connection):
7909 (wait_reading_process_output, read_process_output):
7910 Likewise.
7911
b93aacde
PE
7912 * process.c: Rename or move locals to avoid shadowing.
7913 (list_processes_1, Fmake_network_process):
7914 (read_process_output_error_handler, exec_sentinel_error_handler):
7915 Rename or move locals.
4dc343ee 7916 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7917 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7918 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7919 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7920 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7921
af8a867c 7922 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7923 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7924 Include tparam.h instead, since it declares them.
af8a867c
PE
7925 * cm.h (PC): Remove extern decl; tparam.h now does this.
7926 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7927 * terminfo.c: Include tparam.h, to check interfaces.
7928 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7929 (tparam): Adjust signature to match interface in tparam.h;
7930 this removes some undefined behavior. Check that outstring and len
7931 are zero, which they always are with Emacs.
7932 * tparam.h (PC, BC, UP): New extern decls.
7933
0248044d 7934 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7935 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7936
8ff096c1 7937 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7938 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7939 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7940 (ftfont_list): Remove unused local.
49eaafba
PE
7941 (get_adstyle_property, ftfont_pattern_entity):
7942 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7943 Rename locals to avoid shadowing.
8ff096c1 7944
e2be39f6
PE
7945 * xfont.c (xfont_list_family): Mark var as initialized.
7946
c9735e30
PE
7947 * xml.c (make_dom): Now static.
7948
8f5201ae
PE
7949 * composite.c (composition_compute_stop_pos): Rename local to
7950 avoid shadowing.
b246f932
PE
7951 (composition_reseat_it): Remove unused locals.
7952 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7953 (composition_update_it): Mark var as initialized.
11b61122
PE
7954 (find_automatic_composition): Mark vars as initialized,
7955 with a FIXME (Bug#8290).
8f5201ae 7956
760fbc2c
PE
7957 character.h: Rename locals to avoid shadowing.
7958 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7959 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7960 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7961 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7962 to avoid shadowing.
7963
ff08eb85
PE
7964 * textprop.c (property_change_between_p): Remove; unused.
7965
fc7bf025
PE
7966 * intervals.c (interval_start_pos): Now static.
7967
235d7abc
PE
7968 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7969
44f230aa
SM
7970 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7971 Rename locals to avoid shadowing.
3e7d6594 7972
50060332
PE
7973 * sound.c (wav_play, au_play, Fplay_sound_internal):
7974 Fix pointer signedness.
d01f234b 7975 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7976 (wav_play): Initialize a variable to 0, to prevent undefined
7977 behavior (Bug#8278).
50060332 7978
c4fc4e30
PE
7979 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7980
918436ed
PE
7981 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7982
c939f91b
PE
7983 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7984 clobbering (Bug#8298).
b9c7f648
PE
7985 * sysdep.c (sys_subshell): Likewise.
7986 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7987
6bd8c144
PE
7988 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7989 This should get cleaned up, so that child_setup has the
7990 same signature on all platforms.
7991
7710357c 7992 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7993 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7994
c59da222
CY
79952011-03-22 Chong Yidong <cyd@stupidchicken.com>
7996
7997 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7998 not to be necessary, and produces flickering.
7999
66b87493
GM
80002011-03-20 Glenn Morris <rgm@gnu.org>
8001
8002 * config.in: Remove file.
8003
45b6f6d5
JB
80042011-03-20 Juanma Barranquero <lekktu@gmail.com>
8005
8006 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8007 are now in src/globals.h.
8008 (syms_of_minibuf): Remove spurious & from previous change.
8009
3ec03f7e
LL
80102011-03-20 Leo <sdl.web@gmail.com>
8011
8012 * minibuf.c (completing-read-function): New variable.
8013 (completing-read-default): Rename from completing-read.
8014 (completing-read): Call completing-read-function.
8015
b14e3e21
CY
80162011-03-19 Juanma Barranquero <lekktu@gmail.com>
8017
8018 * xfaces.c (Fx_load_color_file):
8019 Read color file from absolute filename (bug#8250).
8020
f2b726e6
JB
80212011-03-19 Juanma Barranquero <lekktu@gmail.com>
8022
8023 * makefile.w32-in: Update dependencies.
8024
09f6ff02
EZ
80252011-03-17 Eli Zaretskii <eliz@gnu.org>
8026
8027 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8028
29a6015a
PE
80292011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8030
a3a6c54e
PE
8031 Fix more problems found by GCC 4.5.2's static checks.
8032
b766f867
PE
8033 * process.c (make_serial_process_unwind, send_process_trap):
8034 (sigchld_handler): Now static.
8035
be02381c
PE
8036 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8037 That way, the code declares only the vars that it needs.
8038 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8039 * s/cygwin.h (PTY_ITERATION): Likewise.
8040 * s/darwin.h (PTY_ITERATION): Likewise.
8041 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8042
57048744
PE
8043 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8044 * process.c (allocate_pty): Don't declare stb unless it's needed.
8045
7914961c 8046 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8047 (CONSTANTLIM): Remove; unused.
8048 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8049 Define only if needed.
7914961c 8050
b3967b18
PE
8051 * unexelf.c (unexec): Name an expression,
8052 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8053 Use a different way to cause a compilation error if anyone uses
8054 n rather than nn, a way that does not involve shadowing.
73366a00 8055 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8056
29a6015a
PE
8057 * deps.mk (unexalpha.o): Remove; unused.
8058
43cfc33e 8059 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8060 * unexec.h: New file.
ce701a33
PE
8061 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8062 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8063 Depend on unexec.h.
8064 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8065 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8066 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8067 Change as necessary to match prototype in unexec.h.
ce701a33 8068
01f44d5a
PE
8069 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8070 shadowing.
4f63c6bb 8071 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8072
a6670b0b
PE
8073 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8074 Rename locals to avoid shadowing.
8075
cef2010d 8076 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8077 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8078
d4d7173a
PE
8079 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8080
f08b802a
PE
8081 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8082 warning when compiling print.c.
8083
3ddb0639
PE
8084 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8085 instead of using an uninitialized var.
5ad03b97 8086 (font_sort_entities): Mark var as initialized.
3ddb0639 8087
170a2692
PE
8088 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8089
e663c700
PE
8090 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8091 pointers to constants.
89bc529a 8092 (font_parse_fcname): Remove unused vars.
7b81e2d0 8093 (font_delete_unmatched): Now static.
ea838e10 8094 (font_get_spec): Remove; unused.
13a547c6
PE
8095 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8096 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8097 Rename or move locals to avoid shadowing.
e663c700 8098
2a80c887 8099 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8100 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8101
1384fa33 8102 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8103 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8104
8b2c52e9
PE
8105 * alloc.c (mark_backtrace): Move decl from here ...
8106 * lisp.h: ... to here, so that it can be checked.
8107
475545b5 8108 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8109 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8110 (lisp_indirect_variable): Name an expression,
8111 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8112 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8113
b1349114 8114 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8115 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8116 Use const pointer when appropriate.
b1349114 8117
a2928364
PE
8118 * lisp.h (get_system_name, get_operating_system_release):
8119 Move decls here, to check interfaces.
8120 * process.c (get_operating_system_release): Move decl to lisp.h.
8121 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8122 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8123 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8124 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8125 (Fformat_time_string, Fencode_time, Finsert_char):
8126 (Ftranslate_region_internal, Fformat):
8127 Rename or remove local vars to avoid shadowing.
9710023e 8128 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8129
a415e694
PE
8130 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8131 avoid shadowing.
8132
8ef4622d
PE
8133 * lisp.h (eassert): Check that the argument compiles, even if
8134 ENABLE_CHECKING is not defined.
8135
946f9a5b
PE
8136 * data.c (Findirect_variable): Name an expression, to avoid
8137 gcc -Wbad-function-cast warning.
112396d6 8138 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8139 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8140 (Fmake_variable_buffer_local, Fmake_local_variable):
8141 Mark variables as initialized.
52746918 8142 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8143
e5aab7e7 8144 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8145 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8146 Rename locals to avoid shadowing.
dff45157
PE
8147 (mark_stack): Move local variables into the #ifdef region where
8148 they're used.
7bc26fdb
PE
8149 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8150 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8151 needed otherwise.
8152 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8153 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8154 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8155
e5aab7e7
PE
8156 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8157 avoids undefined behavior in theory.
8158
4da60324
PE
8159 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8160
88043301
PE
8161 Use functions, not macros, for up- and down-casing (Bug#8254).
8162 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8163 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8164 to use the following functions instead of these macros.
8165 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8166 EMACS_INT, since callers assume the returned value fits in int.
8167 (upcase1): Likewise, for UPCASE_TABLE.
8168 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8169 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8170 the race-condition problem in the old DOWNCASE.
88043301 8171
19ed5445
PE
8172 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8173 Rename locals to avoid shadowing.
8174 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8175 (regex_compile, re_search_2, re_match_2_internal):
8176 Remove unused local vars.
952db0d7
PE
8177 (FREE_VAR): Rewrite so as not to use empty "else",
8178 which gcc can warn about.
da053e48 8179 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8180 (RETALLOC_IF): Define only if needed.
8181 (WORDCHAR_P): Likewise. This one is never needed, but is used
8182 only in a comment talking about a compiler bug, so put inside
8183 the #if 0 of that comment.
8184 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8185 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8186 Remove; unused.
19ed5445 8187
1f3561e4 8188 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8189 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8190 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8191
ded6f8f7
PE
8192 * search.c (simple_search): Remove unused var.
8193
dbd37a95
PE
8194 * dired.c (compile_pattern): Move decl from here ...
8195 * lisp.h: ... to here, so that it can be checked.
8196 (struct re_registers): New forward decl.
8197
7e47afad
PE
8198 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8199
85f24f61
PE
8200 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8201 All uses changed.
8202 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8203 Rename locals to avoid shadowing.
5671df8f 8204 (Fvertical_motion): Mark locals as initialized.
85f24f61 8205
181aa2be 8206 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8207 (casify_region): Mark local as initialized.
181aa2be 8208
930d429c
PE
8209 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8210
7082eac6
PE
8211 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8212 New macros, so that the caller can use some names other than
8213 gcpro1, gcpro2, etc.
8214 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8215 of the new macros.
8216 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8217 argument, for consistency with GCPRO2_VAR, etc: it is now the
8218 prefix of the variable, not the variable itself. All uses
8219 changed.
38b2c076
PE
8220 * dired.c (directory_files_internal, file_name_completion):
8221 Rename locals to avoid shadowing.
8222
15206ed9
PE
8223 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8224 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8225 dired.c's scmp function, had undefined behavior.
8226 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8227 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8228 * buffer.h: ... to here, because these macros use current_buffer,
8229 and the new implementation with inline functions needs to have
8230 current_buffer in scope now, rather than later when the macros
8231 are used.
8232 (downcase, upcase1): New static inline functions.
8233 (DOWNCASE, UPCASE1): Reimplement using these functions.
8234 This avoids undefined behavior in expressions like
8235 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8236 from race conditions in accessing the global variables
8237 case_temp1 and case_temp2.
8238 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8239 * lisp.h (case_temp1, case_temp2): Remove their decls.
8240 * character.h (ASCII_CHAR_P): Move from here ...
8241 * lisp.h: ... to here, so that the inline functions mentioned
8242 above can use them.
8243
4a6bea26
PE
8244 * dired.c (directory_files_internal_unwind): Now static.
8245
f14b7e14
PE
8246 * fileio.c (file_name_as_directory, directory_file_name):
8247 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8248 Now static.
2893f146
PE
8249 (file_name_as_directory): Use const pointers when appropriate.
8250 (Fexpand_file_name): Likewise. In particular, newdir might
8251 point at constant storage, so make it a const pointer.
fd4ead52 8252 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8253 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8254 signedness issues.
f839df0c
PE
8255 (Fset_file_times, Finsert_file_contents, auto_save_error):
8256 Rename locals to avoid shadowing.
f14b7e14 8257
5716756e 8258 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8259 (Ftry_completion, Fall_completions): Rename or remove locals
8260 to avoid shadowing.
5716756e 8261
b4c3046a
PE
8262 * marker.c (bytepos_to_charpos): Remove; unused.
8263
b45db522
PE
8264 * lisp.h (verify_bytepos, count_markers): New decls,
8265 so that gcc does not warn that these functions aren't declared.
8266
85876d07
PE
8267 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8268 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8269 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8270 (copy_text): Remove unused local var.
85876d07 8271
03d78a21 8272 * filelock.c (within_one_second): Now static.
b3dd38ab 8273 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8274
5df8f01b
PE
8275 * buffer.c (fix_overlays_before): Mark locals as initialized.
8276 (fix_start_end_in_overlays): Likewise. This function should be
8277 simplified by using pointers-to-pointers, but that's a different
8278 matter.
b1d876f1 8279 (switch_to_buffer_1): Now static.
8f54f30a
PE
8280 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8281 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8282
a70072c9 8283 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8284 Fix pointer signedness issue.
edced198
PE
8285 (sys_subshell): Mark local as volatile if checking for lint,
8286 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8287 (MAXPATHLEN): Define only if needed.
a70072c9 8288
a0977c44
PE
8289 * process.c (serial_open, serial_configure): Move decls from here ...
8290 * systty.h: ... to here, so that they can be checked.
8291
a884fdcc
PE
8292 * fns.c (get_random, seed_random): Move extern decls from here ...
8293 * lisp.h: ... to here, so that they can be checked.
8294
604efe86 8295 * sysdep.c (reset_io): Now static.
b8950c94 8296 (wait_for_termination_signal): Remove; unused.
604efe86 8297
38fc62d9
PE
8298 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8299 (copy_keymap_item, append_key, push_text_char_description):
8300 Now static.
1004a21a 8301 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8302 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8303 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8304 (describe_map_tree):
8305 Rename locals to avoid shadowing.
38fc62d9 8306
2f2650da
PE
8307 * keyboard.c: Declare functions static if they are not used elsewhere.
8308 (echo_char, echo_dash, cmd_error, top_level_2):
8309 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8310 (read_char, kbd_buffer_get_event, make_lispy_position):
8311 (make_lispy_event, make_lispy_movement, apply_modifiers):
8312 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8313 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8314 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8315 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8316 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8317
a053e86c 8318 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8319 (mark_kboards): Move decl here ...
8320 * alloc.c (mark_kboards): ... from here.
a053e86c 8321
4752793e
PE
8322 * lisp.h (force_auto_save_soon): New decl.
8323
74f10ca7 8324 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8325 (DEFINE_DUMMY_FUNCTION): New macro.
8326 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8327 Use it.
c03cd23f
PE
8328 (main): Add casts to avoid warnings
8329 if GCC considers string literals to be constants.
74f10ca7 8330
022e70d4
PE
8331 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8332
59d6fe83
PE
8333 * dbusbind.c: Pointer signedness fixes.
8334 (xd_signature, xd_append_arg, xd_initialize):
8335 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8336 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8337 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8338 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8339
78320123
PE
8340 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8341 if GCC considers string literals to be constants.
49cebcca 8342 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8343
35ac2a97
SM
83442011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8345
fb103ca9
SM
8346 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8347 (print_preprocess, print_object): New macro to fix last change.
8348
35ac2a97
SM
8349 * print.c (print_preprocess): Don't forget font objects.
8350
62973b41
JB
83512011-03-16 Juanma Barranquero <lekktu@gmail.com>
8352
8353 * emacs.c (USAGE3): Doc fixes.
8354
0e48bb22
AS
83552011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8356
8357 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8358 structure.
8359
7684e57b
JB
83602011-03-14 Juanma Barranquero <lekktu@gmail.com>
8361
8362 * lisp.h (VWindow_system, Qfile_name_history):
8363 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8364 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8365 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8366
8367 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8368 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8369
8370 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8371 * w32console.c (detect_input_pending, read_input_pending)
8372 (encode_terminal_code):
8373 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8374 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8375 (w32_system_caret_y, Qfile_name_history):
8376 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8377 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8378 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8379 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8380 * w32proc.c (Qlocal, report_file_error):
8381 * w32term.c (Vwindow_system, updating_frame):
8382 * w32uniscribe.c (initialized, uniscribe_font_driver):
8383 Remove unneeded extern declarations.
8384
2aa46d6c
CY
83852011-03-14 Chong Yidong <cyd@stupidchicken.com>
8386
c96bbc66 8387 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8388
cffc6f3b
CY
83892011-03-13 Chong Yidong <cyd@stupidchicken.com>
8390
8391 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8392 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8393 These macros can no longer be used for assignment.
8394
44f230aa
SM
8395 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8396 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8397 (record_buffer_markers, fetch_buffer_markers): New functions for
8398 recording and fetching special buffer markers.
8399 (set_buffer_internal_1, set_buffer_temp): Use them.
8400
8401 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8402
8403 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8404
8405 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8406 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8407
8408 * xdisp.c (hscroll_window_tree):
8409 (reconsider_clip_changes): Use PT instead of BUF_PT.
8410
d251f04b
EZ
84112011-03-13 Eli Zaretskii <eliz@gnu.org>
8412
8413 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8414 $(EMACS_ROOT)/lib/intprops.h.
8415
f0c77cd1
PE
84162011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8417
3eca4629
PE
8418 Fix more problems found by GCC 4.5.2's static checks.
8419
7c86ee98
PE
8420 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8421 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8422 (xg_free_frame_widgets): Make it clear that a local variable is
8423 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8424 (gdk_window_get_screen): Make it clear that this macro is needed
8425 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8426 (int_gtk_range_get_value): New function, which avoids a diagnostic
8427 from gcc -Wbad-function-cast.
8428 (xg_set_toolkit_scroll_bar_thumb): Use it.
8429 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8430 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8431 (get_utf8_string, xg_get_file_with_chooser):
8432 Rename locals to avoid shadowing.
8433 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8434
41729b81
PE
8435 * xgselect.c (xg_select): Remove unused var.
8436
f0c77cd1
PE
8437 * image.c (four_corners_best): Mark locals as initialized.
8438 (gif_load): Initialize transparent_p to zero (Bug#8238).
8439 Mark another local as initialized.
ec6cf4c6 8440 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8441
ce0ad53d 8442 * image.c (clear_image_cache): Now static.
d5d5a617 8443 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8444 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8445 (x_edge_detection): Remove unnecessary cast that
8446 gcc -Wbad-function-cast diagnoses.
2037898d 8447 (gif_load): Fix pointer signedness.
6ae141d6
PE
8448 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8449 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8450
33383987 84512011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8452
d32df629
PE
8453 Improve quality of tests for time stamp overflow.
8454 For example, without this patch (encode-time 0 0 0 1 1
8455 1152921504606846976) returns the obviously-bogus value (-948597
8456 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8457 reports time overflow. See
8458 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8459 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8460 * editfns.c: Include limits.h and intprops.h.
8461 (TIME_T_MIN, TIME_T_MAX): New macros.
8462 (time_overflow): Move earlier, to before first use.
8463 (hi_time, lo_time): New functions, for an accurate test for
8464 out-of-range times.
8465 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8466 (Fget_internal_run_time): Don't assume time_t fits in int.
8467 (make_time): Use list2 instead of Fcons twice.
8468 (Fdecode_time): More accurate test for out-of-range times.
8469 (check_tm_member): New function.
8470 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8471 (lisp_time_argument): Don't rely on undefined left-shift and
8472 right-shift behavior when checking for time stamp overflow.
8be6f318 8473
fe31d94c
PE
8474 * editfns.c (time_overflow): New function, refactoring common code.
8475 (Fformat_time_string, Fdecode_time, Fencode_time):
8476 (Fcurrent_time_string): Use it.
8477
8be6f318
PE
8478 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8479 * dired.c (make_time): Move to ...
8480 * editfns.c (make_time): ... here.
8481 * systime.h: Note the move.
8482
09d9db2c 84832011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8484
126bc0dc
YM
8485 * fringe.c (update_window_fringes): Remove unused variables.
8486
c47cbdfd
YM
8487 * unexmacosx.c (copy_data_segment): Also copy __got section.
8488 (Bug#8223)
8489
7ac80be9
EZ
84902011-03-12 Eli Zaretskii <eliz@gnu.org>
8491
c96bbc66 8492 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8493 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8494 Constify `char *' arguments and their references according to
8495 prototypes in tparam.h.
8496
ecb0f94d 8497 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8498
7ac80be9
EZ
8499 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8500 Adapt all references accordingly.
8501
8502 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8503
ef1fd07e
TT
85042011-03-11 Tom Tromey <tromey@redhat.com>
8505
8506 * buffer.c (syms_of_buffer): Remove obsolete comment.
8507
7ef4b50c
EZ
85082011-03-11 Eli Zaretskii <eliz@gnu.org>
8509
8510 * termhooks.h (encode_terminal_code): Declare prototype.
8511
8512 * msdos.c (encode_terminal_code): Don't declare prototype.
8513
8514 * term.c (encode_terminal_code): Now external again, used by
8515 w32console.c and msdos.c.
8516
44f230aa
SM
8517 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8518 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8519
4b1ec863 85202011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8521
1714f52b 8522 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8523
4b1ec863
PE
8524 * fringe.c (update_window_fringes): Mark locals as initialized
8525 (Bug#8227).
8526 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8527
524c7aa6
PE
8528 * alloc.c (mark_fringe_data): Move decl from here ...
8529 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8530 to check its interface.
8531 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8532
a5c0af81 8533 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8534 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8535 (fontset_font): Mark local as initialized.
a9a06e0b 8536 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8537
b4716021
PE
8538 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8539
811e9bac 8540 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8541 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8542 (x_own_selection, Fx_disown_selection_internal): Rename locals
8543 to avoid shadowing.
8544 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8545
7e3ab302
PE
8546 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8547 so that the caller can use some name other than gcpro1.
8548 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8549 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8550 (Fx_backspace_delete_keys_p):
8551 Use them to avoid shadowing, and rename vars to avoid shadowing.
8552 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8553 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8554 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8555 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8556 Remove unused locals.
7e3ab302
PE
8557 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8558 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8559 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8560 macros.
f78faa98 8561
e2b13473
PE
8562 * xterm.h (x_mouse_leave): New decl.
8563
77f23912
PE
8564 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8565 Remove unused functions.
cdf4ba58
PE
8566 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8567 (x_calc_absolute_position): Now static.
7411c686 8568 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8569 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8570 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8571 unless they are used.
38d0b34a
PE
8572 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8573 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8574 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8575 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8576 (x_error_catcher, x_connection_closed, x_error_handler):
8577 (x_error_quitter, xembed_send_message, x_iconify_frame):
8578 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8579 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8580 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8581
44f230aa
SM
8582 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8583 Rename or move locals to avoid shadowing.
6b463e58 8584 (tty_defined_color, merge_face_heights): Now static.
5967d051 8585 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8586 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8587 does not deduce is never used uninitialized.
73719eba
PE
8588 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8589 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8590
426994c3 8591 * terminal.c (store_terminal_param): Now static.
5489860b 8592
032f1620 8593 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8594 (set_frame_menubar): Remove unused local.
d4323972 8595 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8596 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8597 since they might point to immutable storage.
281585b0
PE
8598 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8599 since it's unused otherwise.
032f1620 8600
367c19e5 8601 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8602 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8603 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8604 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8605 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8606 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8607 does not deduce are never used uninitialized.
70739cbe 8608
07b48fa9
PE
8609 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8610
8868a238 8611 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8612 * window.c (window_loop, size_window):
8613 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8614
7e5cf297 8615 * window.c (display_buffer): Now static.
d6550a9f
PE
8616 (size_window): Mark variables that gcc -Wuninitialized
8617 does not deduce are never used uninitialized.
a586633d
PE
8618 * window.h (check_all_windows): New decl, to forestall
8619 gcc -Wmissing-prototypes diagnostic.
5b555da1 8620 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8621
f6095868
PE
8622 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8623 shadowing.
8624 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8625 Include <limits.h>.
8626 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8627 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8628 (load_charset_map): Mark variables that gcc -Wuninitialized
8629 does not deduce are never used uninitialized.
53df7c11 8630 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8631
f38b440c
PE
8632 * coding.c (coding_set_source, coding_set_destination):
8633 Use "else { /* comment */ }" rather than "else /* comment */;"
8634 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8635 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8636 a block, when the outer 'i' will do.
8637 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8638 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8639 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8640 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8641 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8642 Rename locals to avoid shadowing.
8643 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8644 * coding.c (emacs_mule_char, encode_invocation_designation):
8645 Now static, since they're not used elsewhere.
413bb2db 8646 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8647 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8648 (decode_coding_emacs_mule): Mark variables that gcc
8649 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8650 (detect_coding_iso_2022): Initialize a local variable that might
8651 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8652 this initialization is needed. (Bug#8211)
5f58e762
PE
8653 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8654 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8655 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8656 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8657 Remove unused macros.
f38b440c 8658
232b38b9 8659 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8660 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8661 * character.c (string_count_byte8): Likewise.
232b38b9 8662
fb90da1b
PE
8663 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8664 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8665
fb93dbc2
PE
8666 * chartab.c (copy_sub_char_table): Now static, since it's not used
8667 elsewhere.
5c156ace
PE
8668 (sub_char_table_ref_and_range, char_table_ref_and_range):
8669 Rename locals to avoid shadowing.
bbcd0949 8670 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8671
7d3b3862 8672 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8673 (BIDI_BOB): Remove unused macro.
7d3b3862 8674
6be7d3da
PE
8675 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8676 deduce are never used uninitialized.
c2ed9c8b 8677 * term.c (encode_terminal_code): Likewise.
6be7d3da 8678
75f8807f 8679 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8680
50938595
PE
8681 * tparam.h: New file.
8682 * term.c, tparam.h: Include it.
8683 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8684 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8685 Move these decls to tparam.h, and make them agree with what
8686 is actually in tparam.c. The previous trick of using incompatible
8687 decls in different modules does not conform to the C standard.
8688 All callers of tparam changed to use tparam's actual API.
8689 * tparam.c (tparam1, tparam, tgoto):
8690 Use const pointers where appropriate.
8691
fbceeba2
PE
8692 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8693 * cm.h (struct cm): Likewise.
8694 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8695 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8696 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8697 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8698 (turn_on_face, init_tty): Likewise.
8699 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8700
7f3f1250
PE
8701 * term.c (term_mouse_position): Rename local to avoid shadowing.
8702
e6ca6543
PE
8703 * alloc.c (mark_ttys): Move decl from here ...
8704 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8705
c40f8d15
AS
87062011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8707
8708 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8709
cfe0661d
JB
87102011-03-09 Juanma Barranquero <lekktu@gmail.com>
8711
8712 * search.c (compile_pattern_1): Remove argument regp, unused since
8713 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8714 (compile_pattern): Don't pass it.
8715
0afb4571
J
87162011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8717
8718 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8719 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8720 for ! HAVE_GTK3.
8721 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8722
8723 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8724
8725 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8726 gdk_window_get_screen, gdk_window_get_geometry,
8727 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8728 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8729 (xg_get_pixbuf_from_pixmap): New function.
8730 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8731 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8732 Call xg_get_pixbuf_from_pixmap instead of
8733 gdk_pixbuf_get_from_drawable.
8734 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8735 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8736 (xg_check_special_colors): Use GtkStyleContext and its functions
8737 for HAVE_GTK3.
8738 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8739 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8740 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8741 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8742 Call gtk_widget_get_preferred_size.
0afb4571
J
8743 (xg_frame_resized): gdk_window_get_geometry only takes 5
8744 parameters.
44f230aa
SM
8745 (xg_win_to_widget, xg_event_is_for_menubar):
8746 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8747 (xg_set_widget_bg): New function.
8748 (delete_cb): New function.
895009e1 8749 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8750 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8751 (xg_set_background_color): Call xg_set_widget_bg.
8752 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8753 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8754 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8755 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8756 if ! HAVE_GTK3.
8757 (update_frame_tool_bar): Call gtk_widget_hide.
8758 (xg_initialize): Use GDK_KEY_g.
8759
8760 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8761 if ! HAVE_GTK3
8762 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8763
8764 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8765 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8766 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8767
1c2cc4ef
JB
87682011-03-08 Juanma Barranquero <lekktu@gmail.com>
8769
8770 * w32xfns.c (select_palette): Check success of RealizePalette against
8771 GDI_ERROR, not zero.
8772
33383987 8773See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8774
8775;; Local Variables:
8776;; coding: utf-8
aac0c6e3
MR
8777;; End:
8778
33383987 8779 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8780
8781 This file is part of GNU Emacs.
8782
8783 GNU Emacs is free software: you can redistribute it and/or modify
8784 it under the terms of the GNU General Public License as published by
8785 the Free Software Foundation, either version 3 of the License, or
8786 (at your option) any later version.
8787
8788 GNU Emacs is distributed in the hope that it will be useful,
8789 but WITHOUT ANY WARRANTY; without even the implied warranty of
8790 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8791 GNU General Public License for more details.
8792
8793 You should have received a copy of the GNU General Public License
8794 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.