Read msdog.texi
[bpt/emacs.git] / src / ChangeLog
CommitLineData
86b847b6
CY
12012-02-22 Chong Yidong <cyd@gnu.org>
2
3 * xterm.c (x_draw_image_relief): Add missing type check for
4 Vtool_bar_button_margin (Bug#10743).
5
a59225b1
CY
62012-02-21 Chong Yidong <cyd@gnu.org>
7
8 * fileio.c (Vfile_name_handler_alist): Doc fix.
9
10 * buffer.c (Fget_file_buffer): Protect against invalid file
11 handler return value.
12
310f5bd4
PE
132012-02-20 Paul Eggert <eggert@cs.ucla.edu>
14
cb3a28cc
PE
15 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
16 when computing $valmask.
17
310f5bd4
PE
18 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
19 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
20 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
21 It's useless in that case, and it can cause problems on hosts
22 that allocate halves of EMACS_INT values separately.
23 Reported by Dan Horák. Diagnosed by Andreas Schwab in
24 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
25 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
26 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
27 it avoids undefined behavior on hosts where shifting right by more
28 than the word width has undefined behavior.
29
2375c96a
CY
302012-02-19 Chong Yidong <cyd@gnu.org>
31
32 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
33 (Funhandled_file_name_directory, Ffile_name_as_directory)
34 (Fdirectory_file_name, Fexpand_file_name)
35 (Fsubstitute_in_file_name): Protect against invalid file handler
36 return values (Bug#10845).
37
3eb49e71
EZ
382012-02-18 Eli Zaretskii <eliz@gnu.org>
39
40 * .gdbinit (pitx): Fix incorrect references to fields of the
41 iterator stack.
42
7b926f3f
CY
432012-02-17 Chong Yidong <cyd@gnu.org>
44
45 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
46
11273115
PE
472012-02-15 Paul Eggert <eggert@cs.ucla.edu>
48
49 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
50 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
51
c3a70e2b
CY
522012-02-15 Chong Yidong <cyd@gnu.org>
53
54 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
55 marked as special. Also, starting docstrings with * is obsolete.
56
0ca43699
AS
572012-02-13 Andreas Schwab <schwab@linux-m68k.org>
58
59 * gnutls.c (emacs_gnutls_write): Fix last change.
60
2e8f3c56
LI
612012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
62
63 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
64 send_process.
65
af70074f
SM
662012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
67
68 * keymap.c (Fsingle_key_description): Handle char ranges.
69
95986d52
CY
702012-02-12 Chong Yidong <cyd@gnu.org>
71
afd83bd1
CY
72 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
73 as that creates a dangerous corner case.
74
95986d52
CY
75 * window.c (Fdelete_window_internal): Invalidate the mouse
76 highlight (Bug#9904).
77
bd7da63e
GM
782012-02-12 Glenn Morris <rgm@gnu.org>
79
80 * xselect.c (Fx_own_selection_internal)
81 (Fx_get_selection_internal, Fx_disown_selection_internal)
82 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
83 * nsselect.m (Fx_own_selection_internal)
84 (Fx_disown_selection_internal, Fx_selection_exists_p)
85 (Fx_selection_owner_p, Fx_get_selection_internal):
86 Sync docs and argument specs with the xselect.c versions.
87
77abcbc2
LI
882012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
89
90 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
91
90b671e2
EZ
922012-02-11 Eli Zaretskii <eliz@gnu.org>
93
1c0ca0b7
EZ
94 * w32select.c (Fx_selection_exists_p): Sync doc string and
95 argument list with xselect.c. (Bug#10783)
96
97 * w16select.c (Fx_selection_exists_p): Sync doc string and
98 argument list with xselect.c. (Bug#10783)
90b671e2 99
49241268
GM
1002012-02-10 Glenn Morris <rgm@gnu.org>
101
102 * fns.c (Fsecure_hash): Doc fix.
103
f998bbe7 1042012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
105
106 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
107
0992bd9c
CY
1082012-02-07 Chong Yidong <cyd@gnu.org>
109
110 * buffer.c (Fbuffer_local_variables)
111 (buffer_lisp_local_variables): Handle unbound vars correctly;
112 don't let Qunbound leak into Lisp.
113
af008560
GM
1142012-02-07 Glenn Morris <rgm@gnu.org>
115
dd605cc4
GM
116 * image.c (Fimagemagick_types): Doc fix.
117
af008560
GM
118 * image.c (imagemagick-render-type): Change it from a lisp object
119 to an integer. Move the doc here from the lisp manual.
120 Treat all values not equal to 0 the same.
121
1449fa1d
CY
1222012-02-06 Chong Yidong <cyd@gnu.org>
123
124 * doc.c (store_function_docstring): Avoid applying docstring of
125 alias to base function (Bug#2603).
126
3723ec07
AS
1272012-02-04 Andreas Schwab <schwab@linux-m68k.org>
128
129 * .gdbinit (pp1, pv1): Remove redundant defines.
130 (pr): Use pp.
131
79c1cc1e
CY
1322012-02-04 Chong Yidong <cyd@gnu.org>
133
134 * nsterm.m: Declare a global (Bug#10694).
135
d7f29f8e
EZ
1362012-02-04 Eli Zaretskii <eliz@gnu.org>
137
138 * w32.c (get_emacs_configuration_options): Include
139 --enable-checking, if specified, in the return value.
140
3b95a6f9
MR
1412012-02-04 Martin Rudalics <rudalics@gmx.at>
142
143 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
144 after rounding frame sizes. (Bug#9723)
145
d6fa96a6
EZ
1462012-02-04 Eli Zaretskii <eliz@gnu.org>
147
148 * keyboard.c (adjust_point_for_property): Don't position point
149 before BEGV. (Bug#10696)
150
df0b2940
PE
1512012-02-03 Paul Eggert <eggert@cs.ucla.edu>
152
153 Handle overflow when computing char display width (Bug#9496).
154 * character.c (char_width): Return EMACS_INT, not int.
155 (char_width, c_string_width): Check for overflow when
156 computing the width; this is possible now that individual
157 characters can have unbounded width. Problem introduced
158 by merge from Emacs 23 on 2012-01-19.
159
6bee44d6
MA
1602012-02-02 Michael Albinus <michael.albinus@gmx.de>
161
162 * dbusbind.c (Fdbus_register_method): Mention the return value
163 :ignore in the docstring.
164
44f92739
GM
1652012-02-02 Glenn Morris <rgm@gnu.org>
166
1b9f60cc
GM
167 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
168
44f92739
GM
169 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
170 Unconditionally set to t. (Bug#10673)
171 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
172 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
173 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
174
c5d3843c
KH
1752012-02-02 Kenichi Handa <handa@m17n.org>
176
177 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
178 0, do not call append_composite_glyph.
179
159462d4 1802012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
181
182 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
183 NULL (Bug#6988).
184 (x_produce_glyphs): If the component of a composition is a null
185 string, set it->pixel_width to 1 to avoid zero-width glyph.
186
78cef877
EZ
1872012-02-01 Eli Zaretskii <eliz@gnu.org>
188
189 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
190 first 2 arguments are identical. This makes inserting large
191 output from a subprocess an order of magnitude faster on
192 MS-Windows, where all sbrk'ed memory is always contiguous.
193
97897668
GM
1942012-01-31 Glenn Morris <rgm@gnu.org>
195
196 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 197 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
198 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
199
31fd3586
GM
2002012-01-29 Glenn Morris <rgm@gnu.org>
201
202 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
203
0e24a8b2
CY
2042012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
205
206 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
207
cc0adcb0
CY
2082012-01-28 Chong Yidong <cyd@gnu.org>
209
210 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
211
acc28cb9
CY
2122012-01-26 Chong Yidong <cyd@gnu.org>
213
9c69cfb7
CY
214 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
215
acc28cb9
CY
216 * search.c (Fsearch_forward, Fsearch_backward): Document negative
217 repeat counts (Bug#10507).
218
48da7392
GM
2192012-01-26 Glenn Morris <rgm@gnu.org>
220
221 * lread.c (syms_of_lread): Doc fix.
222
14af5f7f
CY
2232012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
224
225 * coding.c (encode_designation_at_bol): Change return value to
226 EMACS_INT.
227
0b21c100
CY
2282012-01-25 Chong Yidong <cyd@gnu.org>
229
230 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
231
3c2907f7
CY
2322012-01-21 Chong Yidong <cyd@gnu.org>
233
234 * floatfns.c (Fcopysign): Make the second argument non-optional,
235 since nil is not allowed anyway.
236
959ad23f
AS
2372012-01-21 Andreas Schwab <schwab@linux-m68k.org>
238
239 * process.c (read_process_output): Use p instead of XPROCESS (proc).
240 (send_process): Likewise.
241
34a02f46
MR
2422012-01-19 Martin Rudalics <rudalics@gmx.at>
243
244 * window.c (save_window_save, Fcurrent_window_configuration)
245 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
246 doc-strings.
247
1259009a 2482012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
249
250 * character.c (char_width): New function.
70d4fdf6
GM
251 (Fchar_width, c_string_width, lisp_string_width):
252 Use char_width (Bug#9496).
25ed9e61 253
6a6ee00d
MR
2542012-01-16 Martin Rudalics <rudalics@gmx.at>
255
256 * window.c (Vwindow_persistent_parameters): New variable.
257 (Fset_window_configuration, save_window_save): Handle persistent
258 window parameters.
259
c85efaf7
EZ
2602012-01-14 Eli Zaretskii <eliz@gnu.org>
261
262 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
263 thrashing the stack of the thread. (Bug#9087)
264
5944709e
PE
2652012-01-12 Paul Eggert <eggert@cs.ucla.edu>
266
267 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
268
e71f5d99
EZ
2692012-01-11 Eli Zaretskii <eliz@gnu.org>
270
271 * xdisp.c (rows_from_pos_range): Handle the case where the
272 highlight ends on a newline. (Bug#10464)
273 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
274 he end column for display of highlight that ends on a newline
275 before a R2L line.
276
ce316182
GM
2772012-01-11 Glenn Morris <rgm@gnu.org>
278
279 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
280 from load-path also when installation-directory is nil. (Bug#10208)
281
5b43da69
GM
2822012-01-10 Glenn Morris <rgm@gnu.org>
283
74cc8ff9
GM
284 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
285
7d8d6e4e
GM
286 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
287 Update template values to be closer to their typical values these days.
5b43da69 288
a0db8d43
EZ
2892012-01-09 Eli Zaretskii <eliz@gnu.org>
290
291 * xdisp.c (rows_from_pos_range): Accept additional argument
292 DISP_STRING, and accept any glyph in a row whose object is that
293 string as eligible for mouse highlight. Fixes mouse highlight of
294 display strings from overlays. (Bug#10464)
295
9a0115ab 2962012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 297
b9110d6a 298 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
299 * fileio.c (auto_saving_dir_umask): New static var.
300 (Fmake_directory_internal): Use it.
301 (do_auto_save_make_dir): Set it, instead of invoking chmod after
302 creating the directory. The old code temporarily assigns
303 too-generous permissions to the directory.
304 (do_auto_save_eh): Clear it.
b9110d6a 305 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
306 that the var is always cleared.
307
6c1bd3f3
EZ
3082012-01-07 Eli Zaretskii <eliz@gnu.org>
309
310 * search.c (scan_buffer): Pass character positions to
311 know_region_cache, not byte positions. (Bug#6540)
312
069d2b50
L
3132012-01-07 LynX <_LynX@bk.ru> (tiny change)
314
315 * w32.c (sys_rename): Report EXDEV when rename of a directory
316 fails because the target is on another logical disk. (Bug#10284)
317
75bf0d33
DB
3182012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
319
320 * xterm.c (x_embed_request_focus): New function.
321
322 * xterm.h: Add prototype.
323
324 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
325
1c6e5a32
GM
3262012-01-05 Glenn Morris <rgm@gnu.org>
327
328 * emacs.c (emacs_copyright): Update short copyright year to 2012.
329
651e947e
EZ
3302012-01-01 Eli Zaretskii <eliz@gnu.org>
331
332 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
333 Load gnutls_transport_set_lowat only if GnuTLS version is below
334 2.11.1.
335 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
336 GnuTLS versions below 2.11.1.
337
3778cdd8
AL
3382011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
339
340 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
341 to the doc string advising against its use for altering the way
342 windows are scrolled.
343
0e5317f7
KH
3442011-12-28 Kenichi Handa <handa@m17n.org>
345
346 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
347 coding-system ASCII compatible only when it does not produce BOM
348 on encoding (Bug#10383).
349
93d5ca1f
JD
3502011-12-26 Jan Djärv <jan.h.d@swipnet.se>
351
352 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
353 can scroll.
354 (create_and_show_popup_menu): Always use menu_position_func for
355 Gtk3 (Bug#10361).
356
ca22b785
AS
3572011-12-24 Andreas Schwab <schwab@linux-m68k.org>
358
359 * callint.c (Fcall_interactively): Don't truncate prompt string.
360
d048e1e6
EZ
3612011-12-23 Eli Zaretskii <eliz@gnu.org>
362
363 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
364 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 365 resumed from there (after widening). (Bug#10360)
d048e1e6 366
5ccaba1f
JD
3672011-12-22 Jan Djärv <jan.h.d@swipnet.se>
368
369 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
370
204ee57f
JD
3712011-12-21 Jan Djärv <jan.h.d@swipnet.se>
372
b81d40f0
JB
373 * nsterm.m (x_free_frame_resources):
374 Release f->output_data.ns->miniimage.
204ee57f
JD
375 (ns_index_color): Fix indentation. Do not retain
376 color_table->colors[i].
377
378 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
379 before returning.
380
381 * nsfns.m (x_set_background_color): Assign return value from
382 ns_index_color to face-background instead of NSColor*.
383 (ns_implicitly_set_icon_type): Fix indentation.
384 Change assignment in for loop to comparison.
385
386 * emacs.c (ns_pool): New variable.
387 (main): Assign ns_pool.
388 (Fkill_emacs): Call ns_release_autorelease_pool.
389
390 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
391 autorelease fdesc, release fdAttrs and tdict.
392 (ns_get_covering_families): Release charset.
393 (ns_findfonts): Release NSFontDescriptor created with new.
394 (ns_uni_to_glyphs): Fix indentation.
395 (setString): Release attrStr before assigning new value.
396
c803b2b7
JD
3972011-12-18 Jan Djärv <jan.h.d@swipnet.se>
398
678f4426
JD
399 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
400 and NS_IMPL_COCOA.
401 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
402 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
403
cd394be1 4042011-12-18 David Reitter <reitter@cmu.edu>
678f4426 405
5fecd5fc
JD
406 * nsterm.m (ns_term_init): Subscribe for notifications
407 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
408 to method trackingNotification in EmacsMenu.
409
410 * nsmenu.m (trackingMenu): New variable.
3771cb17 411 (trackingNotification): New method (from Aquamacs).
5fecd5fc 412 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 413 from Aquamacs (Bug#7030).
678f4426
JD
414
4152011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 416
c803b2b7
JD
417 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
418 (symbol_to_nsstring): Fix indentation.
419 (ns_symbol_to_pb): New function.
420 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
421 (Fns_rotate_cut_buffers_internal): Removed.
422 (Fns_store_selection_internal): Renamed from
423 Fns_store_cut_buffer_internal.
424 (ns_get_foreign_selection, Fx_own_selection_internal)
425 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
426 (Fns_get_selection_internal, Fns_store_selection_internal):
427 Use ns_symbol_to_pb and check if return value is nil.
428 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
429 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
430 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
431 renamed to Sns_store_selection_internal.
432 (ns_handle_selection_request): Move code to Fx_own_selection_internal
433 and remove this function.
434 (ns_handle_selection_clear): Remove, never used.
435 (Fx_own_selection_internal): Move code from ns_handle_selection_request
436 here.
437
e1b01a3a
KB
4382011-12-17 Ken Brown <kbrown@cornell.edu>
439
440 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
441 GID is unknown (Bug#10257).
442
2adb6e85
PE
4432011-12-17 Paul Eggert <eggert@cs.ucla.edu>
444
445 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
446 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
447 which caused a build failure on GNU/Linux IA-64. This problem was
448 introduced by my 2011-10-07 patch.
449
d1d7b339
JL
4502011-12-15 Juri Linkov <juri@jurta.org>
451
452 * image.c (imagemagick_error): New function. (Bug#10112)
453 (imagemagick_load_image): Comment out `MagickSetResolution' call.
454 Use `imagemagick_error' where ImageMagick functions return
455 `MagickFalse'.
456 (Fimagemagick_types): Add `Fnreverse' to return the list in the
457 proper order.
458
100d5755
KH
4592011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
460
461 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
462 fill background (Bug#8992).
463
454592a6
MR
4642011-12-13 Martin Rudalics <rudalics@gmx.at>
465
466 * window.c (Vwindow_combination_resize)
467 (Vwindow_combination_limit): Use t instead of non-nil in
468 doc-strings.
61d4b438
MR
469 (Vrecenter_redisplay): Add first sentence of doc-string on
470 separate line.
53524d93 471 (Frecenter): Fix doc-string typo.
454592a6 472
3633e3aa
KH
4732011-12-11 Kenichi Handa <handa@m17n.org>
474
475 * coding.c (Funencodable_char_position): Pay attention to the
476 buffer text relocation (Bug#9389).
477
7b9d523a
JD
4782011-12-10 Jan Djärv <jan.h.d@swipnet.se>
479
480 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
481 gtk_init (Bug#10100).
482
b73189c6
EZ
4832011-12-10 Eli Zaretskii <eliz@gnu.org>
484
485 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
486 IT->string is nil. (Bug#10263)
487
f7dfe5d6
JD
4882011-12-10 Jan Djärv <jan.h.d@swipnet.se>
489
83faebb4
JD
490 * nsterm.h (x_free_frame_resources): Declare.
491
f7dfe5d6
JD
492 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
493 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
494
495 * nsterm.h (ns_get_defaults_value): Declare.
496
497 * nsterm.m (ns_default): Call ns_get_defaults_value.
498
7cd4e72c
EZ
4992011-12-09 Eli Zaretskii <eliz@gnu.org>
500
501 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
502 (Bug#10170)
503
b34d7317
YM
5042011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
505
506 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
507 that where the value of an _OBJC_* symbol points to is in the .bss
508 section (Bug#10240).
509
76470ad1
KH
5102011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
511
512 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 513 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 514
745fff94
KH
5152011-12-08 Kenichi Handa <handa@m17n.org>
516
517 * ftfont.c (get_adstyle_property): Fix previous change
518 (Bug#10233).
519
6e44397c
JB
5202011-12-07 Juanma Barranquero <lekktu@gmail.com>
521
522 * w32.c (init_environment): If no_site_lisp, remove site-lisp
523 dirs from the default value of EMACSLOADPATH (bug#10208).
524
7efa6272
GM
5252011-12-07 Glenn Morris <rgm@gnu.org>
526
527 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
528 installation and source directories as well. (Bug#10208)
529
f6fc4d87
CY
5302011-12-06 Chong Yidong <cyd@gnu.org>
531
532 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
533
2bf26180
GM
5342011-12-06 Glenn Morris <rgm@gnu.org>
535
536 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
537 as an error, not just -1. (Bug#10217)
538
3a6ad4f0
CY
5392011-12-05 Chong Yidong <cyd@gnu.org>
540
541 * keyboard.c (process_special_events): New function.
542 (swallow_events, Finput_pending_p): Use it (Bug#10195).
543
75a3b399
PE
5442011-12-05 Paul Eggert <eggert@cs.ucla.edu>
545
546 * coding.c (encode_designation_at_bol): Don't use uninitialized
547 local variable (Bug#9318).
548
c3c9e25e
KH
5492011-12-05 Kenichi Handa <handa@m17n.org>
550
551 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
552 return Qnil (Bug#8046, Bug#10193).
553
5eb05ea3
KH
5542011-12-05 Kenichi Handa <handa@m17n.org>
555
556 * coding.c (encode_designation_at_bol): New args charbuf_end and
557 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
558 (coding_set_source): Return how many bytes coding->source was
559 relocated.
560 (coding_set_destination): Return how many bytes
561 coding->destination was relocated.
562 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
563 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
564
5652011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
566
567 * coding.c (CODING_CHAR_CHARSET_P): New macro.
568 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
569 macro (Bug#9318).
570
5712011-12-05 Andreas Schwab <schwab@linux-m68k.org>
572
573 The following changes are to fix Bug#9318.
574
a79703f5 575 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
576 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
577 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 578 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 579
7dbda6df
JB
5802011-12-05 Juanma Barranquero <lekktu@gmail.com>
581
582 * lisp.h (process_quit_flag): Fix external declaration.
583
6d5eb5b0
SM
5842011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
585
586 Don't macro-inline non-performance-critical code.
587 * eval.c (process_quit_flag): New function.
588 * lisp.h (QUIT): Use it.
589
a0c3fad0
JD
5902011-12-04 Jan Djärv <jan.h.d@swipnet.se>
591
592 * nsfns.m (get_geometry_from_preferences): New function.
593 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
594
6c07aac2
AS
5952011-12-04 Andreas Schwab <schwab@linux-m68k.org>
596
597 * emacs.c (Qkill_emacs): Define.
598 (syms_of_emacs): Initialize it.
599 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
600 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
601 (quit_throw_to_read_char): Add parameter `from_signal'.
602 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
603 * lisp.h (QUIT): Call Fkill_emacs if requested.
604
c052ead4
JD
6052011-12-03 Jan Djärv <jan.h.d@swipnet.se>
606
607 * widget.c (update_wm_hints): Return if wmshell is null.
608 (widget_update_wm_size_hints): New function.
609
610 * widget.h (widget_update_wm_size_hints): Declare.
611
612 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
613 widget_update_wm_size_hints (Bug#10104).
614
9e49252b
EZ
6152011-12-03 Eli Zaretskii <eliz@gnu.org>
616
617 * xdisp.c (handle_invisible_prop): If the invisible text ends just
618 before a newline, prepare the bidi iterator for consuming the
619 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 620 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 621
02b16839
JL
6222011-12-02 Juri Linkov <juri@jurta.org>
623
624 * search.c (Fword_search_regexp): New Lisp function created from
625 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
626 (Fword_search_backward, Fword_search_forward)
627 (Fword_search_backward_lax, Fword_search_forward_lax):
628 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
629 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
630
0068070e
SM
6312011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
632
633 * fileio.c (Finsert_file_contents): Move after-change-function call
634 to before the "handled:" label, since all "goto handled" appear in
635 cases where the *-change-functions have already been properly called
636 (bug#10117).
637
3360a3fc
AS
6382011-12-01 Andreas Schwab <schwab@linux-m68k.org>
639
640 * keyboard.c (interrupt_signal): Don't call kill-emacs when
641 waiting for input. (Bug#10169)
642
73d6c093
EZ
6432011-11-30 Eli Zaretskii <eliz@gnu.org>
644
645 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
646 verifies glyph row's hash code--we have just reallocated the
647 glyphs, so their contents can be complete garbage. (Bug#10164)
648
febe6bea
JB
6492011-11-30 Juanma Barranquero <lekktu@gmail.com>
650
651 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
652
801a4313
EZ
6532011-11-30 Eli Zaretskii <eliz@gnu.org>
654
655 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
656 attributes are tested _before_ calling verify_row_hash, to protect
657 against GCC re-ordering of the tests. (Bug#10164)
658
2b56b87e
JD
6592011-11-29 Jan Djärv <jan.h.d@swipnet.se>
660
661 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
662
663 * xterm.c (handle_one_xevent): Only set async_visible and friends
664 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 665 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
666 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
667
dbf31225
PE
6682011-11-28 Paul Eggert <eggert@cs.ucla.edu>
669
670 Remove GCPRO-related macros that exist only to avoid shadowing locals.
671 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
672 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
673 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
674 All uses changed to use GCPRO1 etc.
675 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
676 Revert to old implementation (i.e., before 2011-03-11).
677
1305621b
YM
6782011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
679
680 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
681 of scroll runs so as to avoid assigning disabled bogus rows and
682 unnecessary graphics copy operations.
683
8c9afb46
EZ
6842011-11-27 Eli Zaretskii <eliz@gnu.org>
685
686 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
687 (snprintf) [_MSC_VER]: Redirect to _snprintf.
688 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
689 (malloc, free, realloc, calloc): Redirect to e_* only when
690 compiling Emacs.
691
692 * lisp.h (GCTYPEBITS): Move before first use.
693 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
694 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
695 this macro definition.
696
697 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
698 _MSC_VER.
699
54e9e3bf
JD
7002011-11-27 Jan Djärv <jan.h.d@swipnet.se>
701
6d5eb5b0
SM
702 * gtkutil.c (xg_create_frame_widgets):
703 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
704 present with Gtk+ 2.0.
705
83aca1cb
PE
7062011-11-26 Paul Eggert <eggert@cs.ucla.edu>
707
708 * fileio.c (Finsert_file_contents): Undo previous change; see
709 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
710
5b76caa4
PE
7112011-11-26 Paul Eggert <eggert@cs.ucla.edu>
712
713 Rename locals to avoid shadowing.
714 * fileio.c (Finsert_file_contents):
715 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
716 * process.c (wait_reading_process_output):
717 Rename inner 'proc' to 'p' to avoid shadowing.
718 Indent for consistency with usual Emacs style.
719
8c535114
EZ
7202011-11-25 Eli Zaretskii <eliz@gnu.org>
721
722 * xdisp.c (redisplay_window): If cursor row is not fully visible
723 after recentering, and scroll-conservatively is set to a large
724 number, scroll window by a few more lines to make the cursor fully
725 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
726 (start_display): Don't move to the next line if the display should
727 start at a newline that is part of a display vector or an overlay
728 string. (Bug#10119)
8c535114 729
fa4fdb5c
JL
7302011-11-24 Juri Linkov <juri@jurta.org>
731
732 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
733 after the `MagickPingImage' call. (Bug#10112)
734
90ec88df
CY
7352011-11-23 Chong Yidong <cyd@gnu.org>
736
737 * window.c (Fcoordinates_in_window_p): Accept only live windows.
738
56e2e794
MR
7392011-11-23 Martin Rudalics <rudalics@gmx.at>
740
741 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
742 making another buffer current. (Bug#10114)
743
b6e64c41
GM
7442011-11-23 Glenn Morris <rgm@gnu.org>
745
746 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
747
6b21de18
CY
7482011-11-23 Chong Yidong <cyd@gnu.org>
749
750 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
751 using it (Bug#5984).
752
b12cd789
EZ
7532011-11-22 Eli Zaretskii <eliz@gnu.org>
754
755 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
756 and header-lines, as they don't have one computed for them.
757 (Bug#10098)
758
759 * .gdbinit (prow): Make displayed values more self-explaining.
760 Add row's hash code.
761
261b6fd4
LMI
7622011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
763
764 * process.c (wait_reading_process_output): Fix asynchrounous
765 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 766 (wait_reading_process_output): Add comment and URL.
261b6fd4 767
e7cfd277
JD
7682011-11-21 Jan Djärv <jan.h.d@swipnet.se>
769
770 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
771
a9b9b7f5
CY
7722011-11-21 Chong Yidong <cyd@gnu.org>
773
774 * window.c (Fnext_window, Fprevious_window): Doc fix.
775
b0d15b4f
SM
7762011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
777
778 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
779
fe7a3057
JB
7802011-11-20 Juanma Barranquero <lekktu@gmail.com>
781
782 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
783
d2999b1a
MR
7842011-11-20 Martin Rudalics <rudalics@gmx.at>
785
786 * window.c (Fset_window_combination_limit): Rename argument
787 STATUS to LIMIT.
788 (Vwindow_combination_limit): Remove "status" from doc-string.
789
d5ff9cd0
AS
7902011-11-20 Andreas Schwab <schwab@linux-m68k.org>
791
792 * m/ibms390.h: Remove.
793 * m/ibms390x.h: Don't include "ibms390.h".
794
a5bb9bd3
SM
7952011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
796
797 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
798 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
799
cd1181db
JB
8002011-11-20 Juanma Barranquero <lekktu@gmail.com>
801
802 * casetab.c (Fset_case_table):
803 * charset.c (Fcharset_after): Fix typos.
804
615a3b8d 8052011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 806
17e845af
PE
807 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
808 Otherwise, valgrind does not work on some platforms.
809 Problem reported by Andreas Schwab in
6a0bf43d
PE
810 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
811 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
812 is set, removing the need for VIRT_ADDRESS_VARIES.
813 (PURE_P): Use a more-efficient implementation that needs just one
814 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
815 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
816 to 4 (xorl, subq, cmpq, setbe).
817 * alloc.c (pure): Always extern now, since that's the
818 VIRT_ADDR_VARIES behavior.
819 (PURE_POINTER_P): Use a single comparison, not two, for
820 consistency with the new puresize.h.
821 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
822 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
823 Remove VIRT_ADDR_VARIES no longer needed.
824
f8fe6f96
EZ
8252011-11-19 Eli Zaretskii <eliz@gnu.org>
826
827 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
828 (erase_phys_cursor, update_window_cursor, show_mouse_face)
829 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
830 behave as if the cursor position were at the window margin.
831
832 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
833 and the cursor position is out of bounds, behave as if the cursor
834 position were at the window margin. (Bug#10075)
835
df05a53c
CY
8362011-11-18 Chong Yidong <cyd@gnu.org>
837
838 * window.c (Fwindow_combination_limit): Make first argument
839 non-optional, since it is meaningless for live windows like the
840 selected window.
841
2071918e
DA
8422011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
843
844 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
845
b50a28de
SM
8462011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
847
848 * intervals.c: Fix grafting over the whole buffer (bug#10071).
849 (graft_intervals_into_buffer): Simplify.
850
015137db
EZ
8512011-11-18 Eli Zaretskii <eliz@gnu.org>
852
853 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
854 hash values of the two rows.
855 (copy_row_except_pointers): Preserve the used[] arrays and the
856 hash values of the two rows. (Bug#10035)
68c95424 857 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
858
859 * xdisp.c (row_hash): New function, body extracted from
860 compute_line_metrics.
861 (compute_line_metrics): Call row_hash, instead of computing the
862 hash code inline.
863
864 * dispnew.c (verify_row_hash): Call row_hash for computing the
865 hash code of a row, instead of duplicating code from xdisp.c.
866
867 * dispextern.h (row_hash): Add prototype.
868
a2addb04
TH
8692011-11-18 Tassilo Horn <tassilo@member.fsf.org>
870
871 * frame.c (delete_frame): Don't delete the terminal when the last
872 X frame is closed if emacs is built with GTK toolkit.
873
df85d315
JB
8742011-11-17 Juanma Barranquero <lekktu@gmail.com>
875
876 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
877
a0c2d0ae
MR
8782011-11-17 Martin Rudalics <rudalics@gmx.at>
879
880 * window.c (Vwindow_splits): Rename to
881 Vwindow_combination_resize. Suggested by Juri Linkov.
882 (Fsplit_window_internal): Use Vwindow_combination_resize instead
883 of Vwindow_splits.
884
58179cce
JB
8852011-11-16 Juanma Barranquero <lekktu@gmail.com>
886
7877f373
JB
887 * nsfns.m (Fns_font_name):
888 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 889
b6f67890
MR
8902011-11-16 Martin Rudalics <rudalics@gmx.at>
891
892 * window.h (window): Rename slot "nest" to "combination_limit".
893 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
894 (Fset_window_nest): Rename to Fset_window_combination_limit.
895 (Vwindow_nest): Rename to Vwindow_combination_limit.
896 (recombine_windows, make_parent_window, make_window)
897 (Fsplit_window_internal, saved_window)
898 (Fset_window_configuration, save_window_save): Rename all
899 occurrences of window_nest to window_combination_limit.
900
c7015153
JB
9012011-11-15 Juanma Barranquero <lekktu@gmail.com>
902
903 * image.c (imagemagick_load_image): Fix typo.
904
322ad6ec
EZ
9052011-11-14 Eli Zaretskii <eliz@gnu.org>
906
907 * xdisp.c (display_line): Move the call to
908 highlight_trailing_whitespace before the call to
909 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
910 faces of all the glyphs to compute ROW's hash value.
911 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 912
f067b8ec
JB
9132011-11-14 Juanma Barranquero <lekktu@gmail.com>
914
915 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
916 just return (bug#10044).
917
1e5b2111
EZ
9182011-11-12 Eli Zaretskii <eliz@gnu.org>
919
7ef3cbd5
EZ
920 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
921 with user-defined heap size. Bump the default size of the temacs
922 heap to 27MB, to avoid memory warning when running temacs.
923 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
924
1e5b2111
EZ
925 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
926 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
927 (verify_row_hash) [XASSERTS]: New function.
928 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
929 that the hash value of glyph rows is correct.
1e5b2111 930
89d61221
MR
9312011-11-12 Martin Rudalics <rudalics@gmx.at>
932
933 * window.h (window): Remove splits slot.
934 * window.c (Fwindow_splits, Fset_window_splits): Remove.
935 (Fdelete_other_windows_internal, make_parent_window)
936 (make_window, Fsplit_window_internal, Fdelete_window_internal)
937 (Fset_window_configuration, save_window_save): Don't deal with
938 split status of windows.
939 (saved_window): Remove splits slot.
940 (Vwindow_splits): Rewrite doc-string.
941
97f18cc8
JD
9422011-11-11 Jan Djärv <jan.h.d@swipnet.se>
943
944 * xfns.c (unwind_create_frame):
945 * nsfns.m (unwind_create_frame):
946 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
947 Vframe_list (Bug#9999).
948
22a648b4
DA
9492011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
950
0b381c7e 951 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 952
659afede
KH
9532011-11-11 Kenichi Handa <handa@m17n.org>
954
955 * callproc.c (Fcall_process): Set the member dst_multibyte of
956 process_coding.
957
9ac0394b
KH
9582011-11-11 Johan Bockgård <bojohan@gnu.org>
959
960 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
961 avoid a crash (bug#9496).
962
2fbdc249
CY
9632011-11-09 Chong Yidong <cyd@gnu.org>
964
965 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
966 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
967
ac6b1f81
PE
9682011-11-08 Paul Eggert <eggert@cs.ucla.edu>
969
970 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
971
09db192c
PE
9722011-11-08 Paul Eggert <eggert@cs.ucla.edu>
973
974 Avoid some portability problems by eschewing 'extern inline' functions.
975 The trivial performance wins aren't worth the portability hassles; see
976 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
977 et seq.
978 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
979 (window_box_width, window_box_left, window_box_left_offset)
980 (window_box_right, window_box_right_offset): Undo previous change,
981 by removing the "extern"s.
982 * intervals.c (adjust_intervals_for_insertion)
983 (adjust_intervals_for_deletion): Undo previous change,
984 making these static again.
985 (offset_intervals, temp_set_point_both, temp_set_point)
986 (copy_intervals_to_string): No longer inline.
987 * xdisp.c (window_text_bottom_y, window_box_width)
988 (window_box_height, window_box_left_offset)
989 (window_box_right_offset, window_box_left, window_box_right)
990 (window_box): No longer inline.
991
105216ed
CY
9922011-11-08 Chong Yidong <cyd@gnu.org>
993
994 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
995 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
996 Signal an error if not a live window.
105216ed
CY
997 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
998 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
999
ae9e237f
JB
10002011-11-07 Juanma Barranquero <lekktu@gmail.com>
1001
1002 * lisp.h (syms_of_abbrev): Remove declaration.
1003 Reported by CHENG Gao <chenggao@royau.me>.
1004
c7aa8333
EZ
10052011-11-07 Eli Zaretskii <eliz@gnu.org>
1006
1007 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1008 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1009 of temacs in GUI mode.
1010
be7f5545
MR
10112011-11-07 Martin Rudalics <rudalics@gmx.at>
1012
1013 * window.h: Declare delete_all_child_windows instead of
1014 delete_all_subwindows.
1015 * window.c (Fwindow_nest, Fset_window_nest)
1016 (Fset_window_new_total, Fset_window_new_normal)
1017 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1018 (delete_all_subwindows): Rename to delete_all_child_windows.
1019 (Fdelete_other_windows_internal, Fset_window_configuration):
1020 Call delete_all_child_windows instead of delete_all_subwindows.
1021 * frame.c (delete_frame): Call delete_all_child_windows instead
1022 of delete_all_subwindows.
1023
ca78dc43
PE
10242011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1027 This is also needed for porting to any host where GC_MARK_STACK is
1028 not GC_MAKE_GCPROS_NOOPS.
1029 (which_symbols): Use it.
1030
a0241d01
KH
10312011-11-07 Kenichi Handa <handa@m17n.org>
1032
1033 * coding.c (coding_set_destination): Check coding->src_pos only
1034 when coding->src_object is a buffer (bug#9910).
1035
1036 * process.c (send_process): Set the member src_multibyte of coding
1037 to 0 (bug#9911) when sending a unibyte text.
1038
1039 * callproc.c (Fcall_process): Set the member src_multibyte of
1040 process_coding to 0 (bug#9912).
1041
a64bfdfa 10422011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1043
1044 * xmenu.c (cleanup_widget_value_tree): New function.
1045 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1046 calling free_menubar_widget_value_tree directly (Bug#9830).
1047
cb41b32a
PE
10482011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1049
1050 Fix some portability problems with 'inline'.
1051 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1052 (window_box_width, window_box_left, window_box_left_offset)
1053 (window_box_right, window_box_right_offset): Declare extern.
1054 Otherwise, these inline functions do not conform to C99 and
1055 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1056 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1057 * intervals.c (adjust_intervals_for_insertion)
1058 (adjust_intervals_for_deletion): Now extern, because otherwise the
1059 extern inline functions 'offset_intervals' couldn't refer to it.
1060 (static_offset_intervals): Remove.
1061 (offset_intervals): Rewrite using the old contents of
1062 static_offset_intervals. The old version didn't conform to C99
1063 because an extern inline function contained a reference to an
1064 identifier with static linkage.
1065
b7041366
AS
10662011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1067
1068 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1069 GC.
1070
88a37c4d
EZ
10712011-11-06 Eli Zaretskii <eliz@gnu.org>
1072
1073 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1074 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1075 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1076 return Qleft_to_right.
1077
49745b39
CY
10782011-11-06 Chong Yidong <cyd@gnu.org>
1079
1080 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1081 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1082 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1083 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1084 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1085 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1086 (Fwindow_vscroll): Doc fix.
1087 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1088 argument, since it makes no sense to pass a live window and for
1089 consistency with window-child.
1090
1f05cd82
CS
10912011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1092
1093 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1094 support MSVC.
1095
22610910
JR
10962011-11-05 Jason Rumney <jasonr@gnu.org>
1097
1098 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1099 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1100 fonts (Bug#6029).
1101 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1102 bitwise arithmetic preventing use of unicode-sip and non-truetype
1103 opentype fonts.
1104
a06776b2
EZ
11052011-11-05 Eli Zaretskii <eliz@gnu.org>
1106
3ad924ba
EZ
1107 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1108 "emacs"-only part.
1109
a06776b2
EZ
1110 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1111 initialization code to keep similarity to xfns.c after changes
1112 from 2011-11-05.
1113
c9e7db78
JD
11142011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1115
a97f8f3f
JD
1116 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1117 (unwind_create_frame): New function (Bug#9943).
1118 (Fx_create_frame): Restructure code to be more similar to the one in
1119 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1120 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1121 Move terminal->reference_count++ just before making the frame official
1122 (Bug#9943).
1123
1124 * nsterm.m (x_free_frame_resources): New function.
1125 (x_destroy_window): Move code to x_free_frame_resources.
1126
c9e7db78 1127 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1128 (Fx_create_frame, x_create_tip_frame):
1129 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1130 official. Move initialization of image_cache_refcount and
1131 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1132
a6fc3b5c
EZ
11332011-11-05 Eli Zaretskii <eliz@gnu.org>
1134
1135 Support MSVC build with newer versions of Visual Studio.
1136 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1137 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1138 nt/gmake.defs.
1139
1140 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1141 which are not supported by MSVC.
1142 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1143 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1144 bitfields.
1145 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1146 types in bitfields.
1147 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1148
1149 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1150
58179cce 11512011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1152
1153 Support MSVC build with newer versions of Visual Studio.
1154 * w32.c: Don't include w32api.h for MSVC.
1155 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1156
1157 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1158 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1159 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1160 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1161 e_* cousins.
1162 (alloca) [_MSC_VER]: Define to _alloca.
1163
1164 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1165
1166 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1167
a58c13ed
EZ
11682011-11-04 Eli Zaretskii <eliz@gnu.org>
1169
1170 * xdisp.c (note_mouse_highlight): If either of
1171 previous/next-single-property-change returns nil, treat that as
1172 the beginning or the end of the buffer. (Bug#9955)
1173
fe0b6370
JD
11742011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1175
a58c13ed 1176 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1177 label is not null (Bug#9951).
1178 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1179 may be NULL.
1180
89bd5ee1
EZ
11812011-11-04 Eli Zaretskii <eliz@gnu.org>
1182
1183 * window.c (Fwindow_body_size): Mention in the doc string that the
1184 return value is in frame's canonical units. (Bug#9949)
1185
84c3edb9
EZ
11862011-11-03 Eli Zaretskii <eliz@gnu.org>
1187
4e2fb5c7
EZ
1188 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1189
84c3edb9 1190 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1191 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1192 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1193
bc17a887
EZ
11942011-11-01 Eli Zaretskii <eliz@gnu.org>
1195
1196 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1197 Don't stop backward scan on the continuation glyph, even though
1198 its CHARPOS is positive.
6d5eb5b0
SM
1199 (mouse_face_from_buffer_pos, note_mouse_highlight):
1200 Rename cover_string to disp_string.
bc17a887 1201
4ee88440
MR
12022011-11-01 Martin Rudalics <rudalics@gmx.at>
1203
1204 * window.c (temp_output_buffer_show): Don't use
1205 Vtemp_buffer_show_specifiers.
1206 (Vtemp_buffer_show_specifiers): Remove unused variable.
1207
c2ff3c02
EZ
12082011-10-30 Eli Zaretskii <eliz@gnu.org>
1209
1210 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1211 past the beginning of the current glyph matrix.
1212
58179cce 12132011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1214
1215 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1216 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1217 HAVE_GTK3 (Bug#9869).
b77a6a7f 1218
3b574623
JD
1219 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1220 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1221
b77a6a7f
JD
1222 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1223
1224 * xterm.c: Declare x_handle_net_wm_state to return int.
1225 (handle_one_xevent): Check if we are iconified but don't have
1226 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1227 (get_current_wm_state): Return non-zero if not hidden,
1228 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1229 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1230 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1231 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1232
196e41e4
PE
12332011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1234
1235 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1236 so that this new function doesn't get optimized away by a
1237 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1238
021f2e1a
AS
12392011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1240
1241 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1242
8b058d44
EZ
12432011-10-29 Eli Zaretskii <eliz@gnu.org>
1244
1245 Fix the `xbytecode' command.
1246 * .gdbinit (xprintbytestr): New command.
b50a28de 1247 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1248 (xbytecode): Print the byte-code string as well.
1249
4452fb80
EZ
12502011-10-29 Kim Storm <storm@cua.dk>
1251
8b058d44
EZ
1252 * alloc.c (which_symbols): New function.
1253
21b72067
AS
12542011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1255
1256 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1257 line. (Bug#9903)
1258
83ed7b5c
GM
12592011-10-29 Glenn Morris <rgm@gnu.org>
1260
1261 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1262 Not clear what it was for, and it causes various bugs. (Bug#9839)
1263
5a7a728b
EZ
12642011-10-28 Eli Zaretskii <eliz@gnu.org>
1265
1266 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1267 possible random value that matches one of those tested as
1268 condition to clear the mouse face.
1269
d3d0842f
CY
12702011-10-28 Chong Yidong <cyd@gnu.org>
1271
1272 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1273
31b39d13
DN
12742011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1275
1276 * window.c (make_window): Initialize phys_cursor_on_p.
1277
9aba6043
SM
12782011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1279
1280 * lisp.h (struct Lisp_Symbol): Update comments.
1281
c20992f4
JB
12822011-10-28 Juanma Barranquero <lekktu@gmail.com>
1283
1284 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1285
db4f02f2
EZ
12862011-10-28 Eli Zaretskii <eliz@gnu.org>
1287
1288 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1289 <oslsachem@gmail.com> for helping to debug this.
1290
1291 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1292 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1293 (g_b_init_get_glyph_outline_w): New static variables.
1294 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1295 (GetGlyphOutlineW_Proc): New typedefs.
1296 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1297 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1298 New functions.
1299 (w32font_open_internal, compute_metrics):
1300 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1301 instead of calling the "wide" APIs directly.
1302
1303 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1304
1305 * w32.h (syms_of_w32font): Add prototype.
1306
87e68db4
JB
13072011-10-27 Juanma Barranquero <lekktu@gmail.com>
1308
1309 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1310 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1311 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1312 (Fmove_to_window_line): Doc fix.
1313
435c1d67
CY
13142011-10-27 Chong Yidong <cyd@gnu.org>
1315
1316 * process.c (make_process): Set gnutls_state to NULL.
1317
1318 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1319 non-NULL, regardless of GNUTLS_INITSTAGE.
1320 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1321 an error. Set process slots as soon as we allocate them.
1322
1323 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1324
9c6c6f49
CY
13252011-10-27 Chong Yidong <cyd@gnu.org>
1326
9aba6043
SM
1327 * gnutls.c (emacs_gnutls_deinit): New function.
1328 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1329 (Fgnutls_deinit, Fgnutls_boot): Use it.
1330
1331 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1332 (deactivate_process): Call emacs_gnutls_deinit.
1333
657d08d3
JB
13342011-10-27 Juanma Barranquero <lekktu@gmail.com>
1335
1336 * image.c (x_create_x_image_and_pixmap):
1337 * w32.c (sys_rename, w32_delayed_load):
1338 * w32font.c (fill_in_logfont):
1339 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1340
5430d399
JB
13412011-10-26 Juanma Barranquero <lekktu@gmail.com>
1342
1343 * w32fns.c (w32_default_color_map): New function,
1344 extracted from Fw32_default_color_map.
a7ef684b 1345 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1346
fe0055fa
PE
13472011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1348
1349 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1350
e6346438
SM
13512011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1352
1353 * keyboard.c (test_undefined): New function (bug#9751).
1354 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1355
e112cc37
ET
13562011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1357
1358 * sysdep.c (init_sys_modes): Fix the check for the controlling
1359 terminal (Bug#6649).
1360
7b5d6677
EZ
13612011-10-20 Eli Zaretskii <eliz@gnu.org>
1362
1363 * dispextern.h (struct bidi_it): New member next_en_type.
1364
1365 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1366 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1367 current character, check also for next_en_type being WEAK_EN.
1368 (bidi_resolve_weak): Don't enter the expensive loop if the current
1369 position is before next_en_pos. Record the bidi type of the first
1370 non-ET, non-BN character we find, in addition to its position.
1371 (bidi_level_of_next_char): Invalidate next_en_type when
1372 next_en_pos is over-stepped.
1373
7da0b018
PE
13742011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1377 * editfns.c: Rewrite current-time-zone so that it invokes
1378 the equivalent of (format-time-string "%Z") to get the time zone name.
1379 This fixes a bug when the time zone name contains characters that
1380 need converting from the system time locale to Emacs internal format.
1381 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1382 that patch fixed format-time-string to do the conversion, but
1383 I forgot to fix current-time-zone.
1384 (format_time_string): New function, containing most of
1385 what Fformat_time_string used to contain.
1386 (Fformat_time_string): Rewrite in terms of format_time_string.
1387 This doesn't change this function's behavior.
1388 (current-time-zone): Rewrite to use format_time_string.
1389 This fixes the bug reported by Michael Schierl in
1390 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1391 Jason Rumney's 2007-06-07 change worked around this bug, but
1392 didn't fix it.
1393 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1394
8547b010
EZ
13952011-10-19 Eli Zaretskii <eliz@gnu.org>
1396
1397 * xdisp.c (start_display): If the character at POS is displayed
1398 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1399 (try_window_reusing_current_matrix): If a line ends in a display
1400 vector or the next line starts in a display vector, continue
1401 redrawing the window even though the character position of
1402 start_row was reached.
8547b010
EZ
1403 (Bug#9771, part 2)
1404
4e948d15
CY
14052011-10-18 Chong Yidong <cyd@gnu.org>
1406
1407 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1408 with nobreak-char-display too.
1409
4787455f
EZ
14102011-10-18 Eli Zaretskii <eliz@gnu.org>
1411
1412 Fix part 3 of bug#9771.
1413 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1414 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1415 non-neutral characters if the current character is a paragraph
1416 separator (a.k.a. Newline). This avoids running the same
1417 expensive loop twice, once when we consume the preceding newline
1418 and the other time when the line actually needs to be displayed.
1419 Avoid the loop when we see neutrals on the base embedding level
1420 following a character whose directionality is the same as the
1421 paragraph's. This avoids running the expensive loop when a line
1422 ends in a long sequence of neutrals, like control characters.
1423 Add assertion against STRONG_AL type. Slightly rearrange code
1424 that determines the type of a neutral given the first non-neutral
1425 that follows it.
1426 (bidi_level_of_next_char): Set next_en_pos to zero when
1427 invalidating its info.
1428
2c91f553
EZ
14292011-10-17 Eli Zaretskii <eliz@gnu.org>
1430
1431 * xdisp.c (push_display_prop): Determine whether to record string
1432 or buffer position by IT->string, not by IT->method. Allow
1433 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1434 (move_it_vertically_backward): Don't look for character position
1435 immediately after the newline when in a continuation line.
1436 (Bug#9771, part 1)
2c91f553 1437
c7b08b0d
MR
14382011-10-15 Martin Rudalics <rudalics@gmx.at>
1439
1440 * window.c (coordinates_in_window): Rewrite and delabelize
1441 vertical border check. (Bug#5357) (Bug#9618)
1442
6b02f655
SM
14432011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1444
1445 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1446 errors in XSetWindowBorder (bug#9310).
1447
81d40c92
DA
14482011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1449
1450 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1451 avoid crash when xmalloc overrun checking is enabled.
1452
d4172c3b
EZ
14532011-10-13 Eli Zaretskii <eliz@gnu.org>
1454
1455 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1456 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1457 cursor motion with <left> and <right> arrow keys.
1458
1459 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1460 some callers set that themselves.
1461
b00eea75
EZ
14622011-10-12 Eli Zaretskii <eliz@gnu.org>
1463
1464 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1465 display string and the previous row comes from the same string and
1466 is empty. (Bug#9739) (Bug#9738)
1467
8fe012c4
SM
14682011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1469
1470 * doc.c (get_doc_string): Encode file name (bug#9735).
1471
0074aef2
EZ
14722011-10-12 Eli Zaretskii <eliz@gnu.org>
1473
79beb178
EZ
1474 * bidi.c (bidi_level_of_next_char):
1475 * xdisp.c (get_visually_first_element): Remove old incorrect
1476 comments regarding the Unicode Line Separator character.
1477
0074aef2
EZ
1478 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1479
6e4b3fbe
DA
14802011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1481
1482 * alloc.c (Fgc_status): Do not access beyond zombies array
1483 boundary if nzombies > MAX_ZOMBIES.
1484 * alloc.c (dump_zombies): Add missing format specifier.
1485
0324f3af
PE
14862011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1487
b5525cac
PE
1488 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1489 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1490
0324f3af
PE
1491 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1492 Some packages use them to denote characters with modifiers.
1493
e9b5f888
AS
14942011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1495
1496 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1497 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1498 matching a pp-number. Rename parameter var to var1.
1499
127827c0
SM
15002011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1501
1502 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1503
c8fd3bd0
GM
15042011-10-08 Glenn Morris <rgm@gnu.org>
1505
1506 * callint.c (Fcall_interactively): Give a more explicit error for the
1507 'c' case with a non-character input. (Bug#8479)
1508
352ec8ff
EZ
15092011-10-08 Eli Zaretskii <eliz@gnu.org>
1510
03669ccb
EZ
1511 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1512 lines.
7061c986
EZ
1513 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1514 lines that are hscrolled on the left.
03669ccb 1515
352ec8ff
EZ
1516 * dispnew.c (buffer_posn_from_coords): Account for a possible
1517 presence of header-line. (Bug#4426)
1518
a66cfb1c
SM
15192011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1520
6b02f655
SM
1521 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1522 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1523
7c5ee88e
PE
15242011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1525
1526 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1527 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1528 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1529 this makes Emacs dump core during garbage collection on rare
1530 occasions. sizeof is obviously inferior to offsetof here, so
1531 stick with offsetof.
1532 (GC_POINTER_ALIGNMENT): New macro.
1533 (mark_memory): Omit 3rd (offset) arg; caller changed.
1534 Don't assume EMACS_INT alignment is the same as pointer alignment.
1535
df1bbe5b
SM
15362011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1537
1538 * keyboard.c (read_key_sequence_remapped): New var.
1539 (read_key_sequence): Compute remapping in the right buffer.
1540 (command_loop_1): Use read_key_sequence's remapping directly.
1541
51553db6
SM
15422011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1543
32c1fffd
SM
1544 * dired.c (file_name_completion): Don't expand file name.
1545 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1546 before checking file name handler.
1547
51553db6
SM
1548 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1549 they've been requested explicitly (bug#9591).
1550
b6bd1599 15512011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1552
1553 * keymap.c (Fsingle_key_description): Use make_specified_string
1554 instead of build_string to build string from push_key_description.
1555 (Bug#5193)
1556
f701dc2a
PE
15572011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1558
4222c55d
PE
1559 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1560 This fixes a Y2038 bug on 64-bit hosts.
1561 * buffer.c (reset_buffer):
1562 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1563 (Fclear_buffer_auto_save_failure):
1564 Use 0, not -1, to represent an unset failure time, since time_t
1565 might not be signed.
1566
f701dc2a
PE
1567 Remove dependency on glibc malloc internals.
1568 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1569 Move back here from lisp.h, but with their new implementations.
1570 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1571 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1572 * charset.c (charset_table_init): New static var.
1573 (syms_of_charset): Use it instead of xmalloc. This removes a
1574 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1575 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1576 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1577 Move back to alloc.c.
1578 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1579 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1580
9ceebf39
JD
15812011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1582
1583 * nsterm.m (windowDidResize): Call x_set_window_size only when
1584 ns_in_resize is true. Otherwise set pixelwidth/height and
1585 call change_frame_size (Bug#9628).
1586
cb993c58
PE
15872011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1588
3930c88b
PE
1589 Port --enable-checking=all to Fedora 14 x86-64.
1590 * charset.c (syms_of_charset): Also account for glibc malloc's
1591 internal overhead when calculating the initial malloc maximum.
1592
cb993c58
PE
1593 Port --enable-checking=all to Fedora 14 x86.
1594 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1595 Move to lisp.h.
1596 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1597 (overrun_check_realloc, overrun_check_free):
1598 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1599 That way, xmalloc returns a properly-aligned pointer even if
1600 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1601 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1602 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1603 into account when calculating the initial malloc maximum.
1604 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1605 Move here from alloc.c, so that charset.c can use it too.
1606 Properly align; the old code wasn't right for common 32-bit hosts
1607 when configured with --enable-checking=all.
1608 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1609 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1610
31bed486
EZ
16112011-09-29 Eli Zaretskii <eliz@gnu.org>
1612
04c70788 1613 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1614 use EDOM.
1615
fbcaa2f3
EZ
16162011-09-28 Eli Zaretskii <eliz@gnu.org>
1617
1618 * xdisp.c (compute_display_string_end): If there's no display
1619 string at CHARPOS, return -1.
1620
1621 * bidi.c (bidi_fetch_char): When compute_display_string_end
1622 returns a negative value, treat the character as a normal
1623 character not covered by a display string. (Bug#9624)
1624
a239d4e9
JB
16252011-09-28 Juanma Barranquero <lekktu@gmail.com>
1626
1627 * lread.c (Fread_from_string): Fix typo in docstring.
1628
88652fd5
EZ
16292011-09-27 Eli Zaretskii <eliz@gnu.org>
1630
1631 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1632 newline, reseat the iterator instead of bidi-iterating there one
1633 character at a time. (Bug#9610)
32c1fffd
SM
1634 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1635 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1636
ed497dd4
AS
16372011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1638
1639 * lread.c (readevalloop): Use correct code for NBSP.
1640 (read1): Likewise. (Bug#9608)
1641
b2bf61aa
MA
16422011-09-25 Michael Albinus <michael.albinus@gmx.de>
1643
1644 * dbusbind.c (Fdbus_register_signal): When service is not
1645 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1646
32bbb17c
GM
16472011-09-25 Glenn Morris <rgm@gnu.org>
1648
1649 * buffer.c (truncate-lines): Doc fix.
1650
94e0933e
CY
16512011-09-24 Chong Yidong <cyd@stupidchicken.com>
1652
1653 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1654 (Fset_window_next_buffers): Doc fix.
1655
cddde921
GM
16562011-09-24 Glenn Morris <rgm@gnu.org>
1657
1658 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1659
1260aef1
PE
16602011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1661
25b4bfa0
PE
1662 Fix minor problems found by static checking.
1663 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1664 * indent.c (Fvertical_motion): Fix == vs = typo.
1665
e3cbd34b
EZ
16662011-09-24 Eli Zaretskii <eliz@gnu.org>
1667
a66cfb1c
SM
1668 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1669 Default value is now t. Doc fix.
6bf7006f 1670
e3cbd34b 1671 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1672 logic when moving up, not only when moving down. Fix the
e3cbd34b 1673 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1674 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1675
1676 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1677 CHARPOS is covered by a display string which includes newlines.
1678 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1679 is covered by a display string with embedded newlines.
1680
a3de0cbd
MA
16812011-09-24 Michael Albinus <michael.albinus@gmx.de>
1682
1683 * dbusbind.c (Fdbus_register_signal): Add match rule to
1684 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1685 (Fdbus_register_method, Vdbus_registered_objects_table):
1686 Fix docstring.
a3de0cbd 1687
b260039d
JM
16882011-09-24 Jim Meyering <meyering@redhat.com>
1689
32c1fffd 1690 do not ignore write error for any output size
b260039d
JM
1691 The previous change was incomplete.
1692 While it makes emacs --batch detect the vast majority of stdout
1693 write failures, errors were still ignored whenever the output size is
1694 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1695 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1696 && echo FAIL: ignored write error
1697 FAIL: ignored write error
1698 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1699 && echo FAIL: ignored write error
1700 FAIL: ignored write error
1701 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1702
8eca8a7c
AS
17032011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1704
1705 * emacs.c (Fkill_emacs): In noninteractive mode exit
1706 non-successfully if a write error occurred on stdout. (Bug#9574)
1707
3341db62
EZ
17082011-09-21 Eli Zaretskii <eliz@gnu.org>
1709
1710 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1711 the xassert test.
1712
1713 * dispextern.h (struct it): Update the comment documenting what
1714 can it->OBJECT be.
1715
8c203dbf
EZ
17162011-09-20 Eli Zaretskii <eliz@gnu.org>
1717
1718 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1719 a display string, extend search for cursor position to end of row.
1720 (find_row_edges): If the row ends in a newline from a display
1721 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1722 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1723 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1724 non-empty line. Fixes confusing cursor motion with arrow keys at
1725 the beginning of a line that starts with whitespace.
8c203dbf 1726
a4824228
LMI
17272011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1728
1729 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1730 (bug#9493).
1731
33ed493b
CY
17322011-09-18 Chong Yidong <cyd@stupidchicken.com>
1733
1734 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1735 boolean (Bug#9154).
1736
56cd55c8
EZ
17372011-09-18 Eli Zaretskii <eliz@gnu.org>
1738
1739 * xdisp.c (display_line): Record maximum and minimum buffer
1740 positions even if no glyphs were produced (e.g., by a zero-width
1741 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1742 buffer positions that will be removed from the glyph row because
1743 they don't fit.
c02dcedf
EZ
1744 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1745 column is beyond frame width: don't subtract 1 "pixel" when
1746 computing width of the stretch.
3e62b7e0
EZ
1747 (reseat_at_next_visible_line_start): Undo the change made on
1748 2011-09-17 that saved paragraph information and restored it after
1749 the call to `reseat'. (Bug#9545)
56cd55c8 1750
5ed99d36 17512011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1752
1753 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1754 and turn window cursor on if cleared (Bug#9415).
1755
5ed99d36 17562011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1757
1758 * search.c (boyer_moore): Take unibyte characters from pattern
1759 literally. (Bug#9458)
1760
9bade7b2
EZ
17612011-09-18 Eli Zaretskii <eliz@gnu.org>
1762
1763 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1764
e5e9d610
PE
17652011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1766
87e4427a
PE
1767 Fix minor problem found by static checking.
1768 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1769 initialized, to pacify gcc -Wuninitialized.
1770
e5e9d610
PE
1771 * fileio.c: Report proper errno when syscall falls.
1772 (Finsert_file_contents): Save and restore errno,
1773 so that report_file_error outputs the correct diagnostic.
1774 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1775
a1674f0b
EZ
17762011-09-18 Eli Zaretskii <eliz@gnu.org>
1777
1778 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1779
fbfb6dd4
EZ
17802011-09-17 Eli Zaretskii <eliz@gnu.org>
1781
1782 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1783 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1784
bb187662
EZ
17852011-09-17 Eli Zaretskii <eliz@gnu.org>
1786
1137e8b8 1787 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1788 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1789
1790 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1791 (bidi_find_paragraph_start): Search back for paragraph beginning
1792 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1793 (bidi_move_to_visually_next): Only trigger paragraph-related
1794 computations when the last character is a newline or at EOB, not
1795 just any NEUTRAL_B. (Bug#9470)
1796
bb187662
EZ
1797 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1798 truncated lines if point is covered by a display string. (Bug#9524)
1799
2e621251
PE
18002011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1801
1802 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1803 (cons_to_x_long): New function.
1804 (lisp_data_to_selection_data): Use it. Correct the test for
1805 short-versus-long data; it was negated. Break out of vector
1806 loop, for efficiency, when a long datum is discovered.
1807
91a15bc6
SM
18082011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1809
1810 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1811
b41c3a35
EZ
18122011-09-16 Eli Zaretskii <eliz@gnu.org>
1813
1814 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1815 GCC PR/17406) by declaring this function with external scope.
1816
7812ba2d
PE
18172011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1818
1819 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1820 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1821
cf7edc2a
AS
18222011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1823
1824 * editfns.c (Fformat): Correctly handle text properties on "%%".
1825
bd01620e
EZ
18262011-09-15 Eli Zaretskii <eliz@gnu.org>
1827
1828 * xterm.c (x_draw_composite_glyph_string_foreground):
1829 * w32term.c (x_draw_composite_glyph_string_foreground):
1830 * term.c (encode_terminal_code):
1831 * composite.c (composition_update_it, get_composition_id):
1832 * xdisp.c (get_next_display_element)
1833 (fill_composite_glyph_string): Add comments about special meaning
1834 of TAB characters in a composition.
1835
a02719a3
PE
18362011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1837
1838 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1839 This occurs when processing a multibyte format.
1840 Problem reported by Wolfgang Jenker.
a02719a3 1841
72589a3c
JB
18422011-09-15 Johan Bockgård <bojohan@gnu.org>
1843
1844 * xdisp.c (try_cursor_movement): Only check for exact match if
1845 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1846
1c14176c
PE
18472011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1848
1849 Remove unused external symbols.
1850 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1851 * xdisp.c (calc_pixel_width_or_height): Now static.
1852 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1853 * indent.c (check_display_width):
1854 * w32term.c: Fix comment to match code.
1855 * xterm.c, xterm.h (x_catching_errors): Remove.
1856
d2eea5b5
PE
18572011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 * xselect.c: Use signed conversions more consistently (Bug#9498).
1860 (selection_data_to_lisp_data): Assume incoming selection data are
1861 signed integers, not unsigned. This is to be consistent with
1862 outgoing selection data, which was modified to use signed integers
1863 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1864 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1865 expects long, not unsigned long.
1866
46888499
EZ
18672011-09-14 Eli Zaretskii <eliz@gnu.org>
1868
1869 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1870 computation of loop end. Reported by Johan Bockgård
1871 <bojohan@gnu.org>.
1872
ef8ef9fb
CY
18732011-09-13 Chong Yidong <cyd@stupidchicken.com>
1874
1875 * frame.c (Fother_visible_frames_p): Function deleted.
1876
fa819fed
EZ
18772011-09-12 Eli Zaretskii <eliz@gnu.org>
1878
1879 * indent.c (compute_motion): Process display vector front to back
1880 rather than the other way around. (Bug#2496)
1881
2ba8e008
SM
18822011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1883
1884 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1885
20f53c69
CY
18862011-09-11 Chong Yidong <cyd@stupidchicken.com>
1887
1888 * minibuf.c (Fread_from_minibuffer): Doc fix.
1889
d562d7a4
EZ
18902011-09-11 Eli Zaretskii <eliz@gnu.org>
1891
1892 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1893 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1894
1c4d7f3d
LMI
18952011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1896
1897 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1898 value for non-existent files.
1899
b885bf36
EZ
19002011-09-11 Eli Zaretskii <eliz@gnu.org>
1901
1902 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1903 set its "size" to -1. This will set the modtime_size field of
1904 the corresponding buffer to -1, which is what
1905 verify-visited-file-modtime expects for files that do not exist.
1906 (Bug#9139)
1907
6612f0bf
PE
19082011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1909
1910 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1911 here ...
1912 * lisp.h: ... from here. push_key_description is no longer
1913 defined in keyboard.c, so its declaration should not be in
1914 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1915 logically belongs with push_key_description.
1916
dfb3f755
PE
19172011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1918
1919 * buffer.h: Include <sys/types.h> instead of <time.h>.
1920 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1921 Problem reported by Herbert J. Skuhra.
1922
3134906c
LMI
19232011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1924
1925 * xml.c (parse_region): Make the parsing work for
1926 non-comment-starting XML files again (bug#9144).
1927
8d903f4e
AS
19282011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1929
1930 * image.c (gif_load): Fix calculation of bottom and right corner.
1931 (Bug#9468)
1932
80ad64f4
EZ
19332011-09-10 Eli Zaretskii <eliz@gnu.org>
1934
1935 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1936 redisplay in small windows.
1937
208a048d
EZ
19382011-09-09 Eli Zaretskii <eliz@gnu.org>
1939
1940 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1941
9b1c252e
MR
19422011-09-08 Martin Rudalics <rudalics@gmx.at>
1943
1944 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1945 Operate on live windows only.
1946
2949f33b
JB
19472011-09-08 Juanma Barranquero <lekktu@gmail.com>
1948
1949 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1950
e08dcafd
EZ
19512011-09-07 Eli Zaretskii <eliz@gnu.org>
1952
1953 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1954 only under bidi iteration.
1955
115b96bd
JD
19562011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1957
1958 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1959
c8199d0f
PE
19602011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1961
1962 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1963 Without this fix, the command to link temacs failed due to an
1964 undefined symbol __builtin_isnan. This is because
1965 /usr/include/iso/math_c99.h #defines isnan(x) to
1966 __builtin_isnan(x), but the bundled gcc, which identifies itself
1967 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1968 a __builtin_isnan.
1969 * floatfns.c (isnan): #undef, and then #define to a clone of
1970 what's in data.c.
1971 (Fisnan): Always define, since it's always available now.
1972 (syms_of_floatfns): Always define isnan at the Lisp level.
1973
e39b275c 19742011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1975
1976 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1977
b2db44d9 19782011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1979
f4af5137 1980 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1981 The previous code assumed that file offsets (off_t values) fit in
1982 EMACS_INT variables, which is not true on typical 32-bit hosts.
1983 The code messed up by falsely reporting buffer overflow in cases
1984 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1985 when "big" contains more than 2**29 bytes, even though this
1986 inserts just one byte and does not overflow the buffer.
1987 (Finsert_file_contents): Store file offsets as off_t
1988 values, not as EMACS_INT values. Check for overflow when
1989 converting between EMACS_INT and off_t. When checking for
1990 buffer overflow or for overlap, take the offsets into account.
1991 Don't use EMACS_INT for small values where int suffices.
1992 When checking for overlap, fix a typo: ZV was used where
1993 ZV_BYTE was intended.
1994 (Fwrite_region): Don't assume off_t fits into 'long'.
1995 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1996
ecfc0a49
MA
19972011-09-05 Michael Albinus <michael.albinus@gmx.de>
1998
1999 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2000
6511acf2 20012011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2002
0999621a 2003 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2004
2005 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2006 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2007 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2008 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2009 (modify_event_symbol): Do not assume that the length of
2010 name_alist_or_stem is safe to alloca and fits in int.
2011 (Fexecute_extended_command): Likewise for function name and binding.
2012 (Frecursion_depth): Wrap around reliably on integer overflow.
2013 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2014 since some callers pass EMACS_INT values.
2015 (Fsingle_key_description): Don't crash if symbol name contains more
2016 than MAX_ALLOCA bytes.
2017 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2018 (get_minibuffer): Arg is now EMACS_INT, not int.
2019 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2020 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2021 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2022
2be7d702
PE
2023 * dbusbind.c (signature_cat): New function.
2024 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2025 Do not overrun buffer; instead, report string overflow.
2026
9d1df220
PE
2027 * dispnew.c (add_window_display_history): Don't overrun buffer.
2028 Truncate instead; this is OK since it's just a log.
2029
33ef5c64
PE
2030 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2031 even if the time zone offset is outlandishly large.
2032 Don't mishandle offset == INT_MIN.
2033
66c6fdd5
PE
2034 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2035 when creating daemon; the previous buffer-overflow check was incorrect.
2036
d749b01b
PE
2037 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2038 which has the guts of the old verror function.
2039
b5cd1905
PE
2040 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2041 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2042
6e1a67fb
PE
2043 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2044 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2045 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2046 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2047 length of string rather than counting it via multiple sprintfs;
2048 that's simpler and more reliable.
c21721cc
PE
2049 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2050 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2051 sprintf, in case result does not fit in int.
2052
c57b67fc
PE
2053 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2054 (fontset_from_font): Print it.
2055
8a401434
PE
2056 * frame.c (tty_frame_count): Now printmax_t, not int.
2057 (make_terminal_frame, set_term_frame_name): Print it.
2058 (x_report_frame_params): In X, window IDs are unsigned long,
2059 not signed long, so print them as unsigned.
2060 (validate_x_resource_name): Check for implausibly long names,
2061 and don't assume name length fits in 'int'.
2062 (x_get_resource_string): Don't blindly alloca invocation name;
2063 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2064 not fit in int.
2065
6e1a67fb
PE
2066 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2067 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2068 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2069
0df02bf3
PE
2070 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2071 Use esprintf, not sprintf, in case result does not fit in int.
2072
48e30793
PE
2073 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2074 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2075 it as a large positive number.
2076 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2077 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2078
a66ff6d8
PE
2079 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2080 in case result does not fit in int.
2081
aca216ff
PE
2082 * print.c (float_to_string): Detect width overflow more reliably.
2083 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2084 buffer overrun. Don't assume list length fits in 'int'. Treat
2085 print length of 0 as 0, not as infinity; to be consistent with other
2086 uses of print length in this function. Don't overflow print length
2087 index. Don't assume hash table size fits in 'long', or that
2088 vectorlike size fits in 'unsigned long'.
2089
31c286f7
PE
2090 * process.c (make_process): Use printmax_t, not int, to format
2091 process-name gensyms.
2092
55e5faa1
PE
2093 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2094
80f2e268
PE
2095 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2096 to avoid potential buffer overrun.
2097
670741ab
PE
2098 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2099 if X resource line is longer than 512 bytes.
2100
b7163a50
PE
2101 * xfns.c (x_window): Make sprintf buffer a bit bigger
2102 to avoid potential buffer overrun.
2103
ae58ff1f
PE
2104 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2105
c43c8a6a
PE
2106 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2107
3f8236f4
PE
21082011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2109
53e9fe90 2110 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2111 Without these, Emacs silently mishandles large integers sometimes.
2112 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2113 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2114
6511acf2
PE
2115 * xdisp.c (try_window_id): Check Emacs fixnum range before
2116 converting to 'int'.
806add1d 2117
6511acf2 2118 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2119 Check that an Emacs fixnum is in range before assigning it to 'int'.
2120 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2121 values converted from Emacs fixnums.
2122 (Frecenter): Don't wrap around a line count if it is out of 'int'
2123 range; instead, treat it as an extreme value.
2124 (Fset_window_configuration, compare_window_configurations):
2125 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2126
6511acf2
PE
2127 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2128 that can exceed INT_MAX. Check that EMACS_INT value is in range
2129 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2130 (match_limit): Don't assume that a fixnum can fit in 'int'.
2131
6511acf2 2132 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2133 exceed INT_MAX.
2134
6511acf2 2135 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2136 (Fvertical_motion): Don't wrap around LINES values that don't fit
2137 in 'int'. Instead, treat them as extreme values. This is good
2138 enough for windows, which can't have more than INT_MAX lines anyway.
2139
fcb901a7
LMI
21402011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2141
0f2f6b6d
LMI
2142 * Require libxml/parser.h to avoid compilation warning.
2143
fcb901a7
LMI
2144 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2145
2146 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2147 since this reportedly can destroy thread storage.
2148
6e20a0d4
CY
21492011-08-30 Chong Yidong <cyd@stupidchicken.com>
2150
2151 * syntax.c (find_defun_start): Update all cache variables if
2152 exiting early (Bug#9401).
2153
148ae00e
EZ
21542011-08-30 Eli Zaretskii <eliz@gnu.org>
2155
f6cfbd8f
EZ
2156 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2157
148ae00e
EZ
2158 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2159 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2160 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2161
2162 * term.c (tty_append_glyph): New function.
2163 (produce_stretch_glyph): Static function and its prototype deleted.
2164
a66cfb1c
SM
2165 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2166 Add prototypes.
148ae00e 2167
c4a07a4c
PE
21682011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2169
2170 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2171 when checking :margin (Bug#9390).
2172 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2173 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2174 so that the name doesn't mislead. All uses changed.
2175
6bc8cd65
JB
21762011-08-28 Johan Bockgård <bojohan@gnu.org>
2177
2178 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2179 set_tty_hooks.
2180
dca4927e
EZ
21812011-08-27 Eli Zaretskii <eliz@gnu.org>
2182
2183 * xdisp.c (move_it_to): Don't bail out early when reaching
2184 position beyond to_charpos, if we are scanning backwards.
2185 (move_it_vertically_backward): When DY == 0, make sure we get to
2186 the first character in the line after the newline.
2187
f2cad773
PE
21882011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2189
2190 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2191 (ccl_driver): Do not generate an out-of-range pointer.
2192 (Fccl_execute_on_string): Remove unnecessary check for
2193 integer overflow, noted by Stefan Monnier in
2194 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2195 Remove a FIXME that didn't need fixing.
2196 Simplify the newly-introduced buffer reallocation code.
2197
0cae2cdb
JB
21982011-08-27 Juanma Barranquero <lekktu@gmail.com>
2199
2200 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2201
5fc295a4 22022011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2203
70c60eb2 2204 Integer and memory overflow issues (Bug#9196).
726e0ab1 2205
d31850da
PE
2206 * doc.c (get_doc_string): Rework so that
2207 get_doc_string_buffer_size is the actual buffer size, rather than
2208 being 1 less than the actual buffer size; this makes xpalloc more
2209 convenient.
2210
a69fbedb
PE
2211 * image.c (x_allocate_bitmap_record, cache_image):
2212 * xselect.c (Fx_register_dnd_atom):
2213 Simplify previous changes by using xpalloc.
2214
fe5c5d37
PE
2215 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2216 since either will do and ptrdiff_t is convenient with xpalloc.
2217
0065d054
PE
2218 * charset.c (charset_table_size)
2219 (struct charset_sort_data.priority): Now ptrdiff_t.
2220 (charset_compare): Don't overflow if priorities differ greatly.
2221 (Fsort_charsets): Don't assume list length fits in int.
2222 Check for size-calculation overflow when allocating sort data.
2223 (syms_of_charset): Allocate an initial charset table that is
2224 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2225
2226 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2227
2228 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2229 The actual value is always <= INT_MAX, and leaving it unsigned made
2230 overflow checking harder.
2231
2232 * dispextern.h (struct glyph_matrix.rows_allocated)
2233 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2234 with xpalloc. The values are still always <= INT_MAX.
2235
2236 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2237
2238 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2239 (SAFE_NALLOCA): New macro.
2240
2241 * region-cache.c (struct boundary.pos, find_cache_boundary)
2242 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2243 (set_cache_region, invalidate_region_cache)
2244 (revalidate_region_cache, know_region_cache, region_cache_forward)
2245 (region_cache_backward, pp_cache):
2246 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2247 so that ptrdiff_t * can be passed to xpalloc.
2248 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2249 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2250 (pp_cache): Don't assume cache_len fits in int.
2251 * region-cache.h: Adjust extern decls to match.
2252
2253 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2254 EMACS_INT, since either will do, for xpalloc.
2255
2256 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2257 (xnmalloc, xnrealloc, xpalloc): New functions.
2258
726e0ab1
PE
2259 * bidi.c (bidi_shelve_header_size): New constant.
2260 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2261 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2262
51f30bc5 2263 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2264 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2265 (overlay_strings):
2266 Don't update size of array until after memory allocation succeeds,
2267 because xmalloc/xrealloc may not return.
0065d054
PE
2268 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2269 now that we have proper integer overflow checking.
2270 (record_overlay_string, overlay_strings): Catch overflows when
2271 calculating size of overlay_str_buf.
726e0ab1 2272
0065d054
PE
2273 * callproc.c (Fcall_process): Check for size overflow when
2274 calculating size of args2.
2275 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2276 Normally we prefer signed values, but sticking with ptrdiff_t would
2277 require adding more-complicated checks.
726e0ab1
PE
2278
2279 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2280 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2281 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2282 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2283
2284 * character.c (Fstring): Check for size-calculation overflow.
2285
2286 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2287 unnecessary integer overflow. Check for size overflow.
2288 (encode_coding_object): Don't update size until xmalloc succeeds.
2289
2290 * composite.c (get_composition_id): Check for overflow in glyph
2291 length calculations.
2292
2293 Integer and memory overflow fixes for display code.
2294 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2295 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2296 (scrolling_window): Check for overflow in size calculations.
2297 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2298 Don't assume glyph table len fits in int.
2299 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2300 (row_table_size): Now ptrdiff_t, not int.
2301 (scrolling_window): Avoid overflow in size calculations.
2302 Don't update size until allocation succeeds.
2303 * fns.c (concat): Check for overflow in size calculations.
2304 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2305 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2306 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2307
2308 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2309 (get_doc_string): Check for size calculation overflow.
2310 Don't update size until allocation succeeds.
2311 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2312 EMACS_INT, where ptrdiff_t will do.
2313 (Fsubstitute_command_keys): Check for string overflow.
2314
2315 * editfns.c (set_time_zone_rule): Don't assume environment length
2316 fits in int.
2317 (message_length): Now ptrdiff_t, not int.
2318 (Fmessage_box): Don't update size until allocation succeeds.
2319 Don't assume message length fits in int.
2320 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2321
0065d054
PE
2322 * emacs.c (main): Do not reallocate argv, since there is a null at
2323 the end that can be overwritten, and this way there's no need to
2324 worry about size-calculation overflow.
2325 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2326
2327 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2328 alloc succeeds.
2329 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2330
2331 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2332 (x_set_scroll_bar_width, x_figure_window_size):
2333 Check for integer overflow.
2334 (x_set_alpha): Do not assume XINT fits in int.
2335
2336 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2337 This is for the members text_lines, text_cols, total_lines, total_cols,
2338 where the system imposes an 'int' limit.
2339
2340 * fringe.c (Fdefine_fringe_bitmap):
2341 Don't update size until alloc works.
2342
2343 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2344 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2345
2346 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2347 Check for size-calculation overflow.
2348 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2349 do, as we prefer signed integers.
2350 (id_to_widget.max_size, id_to_widget.used)
2351 (xg_store_widget_in_map, xg_remove_widget_from_map)
2352 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2353 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2354 Use and return ptrdiff_t, not int.
2355 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2356 * gtkutil.h: Change prototypes to match the above.
2357
2358 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2359 are duplicate now that they've been promoted to lisp.h.
2360 (x_allocate_bitmap_record, x_alloc_image_color)
2361 (make_image_cache, cache_image, xpm_load):
2362 Don't update size until alloc is done.
2363 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2364 (x_detect_edges):
3256efce 2365 Check for size calculation overflow.
726e0ab1
PE
2366 (ct_colors_allocated_max): New constant.
2367 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2368 overflow.
3256efce 2369
726e0ab1
PE
2370 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2371 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2372 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2373 Use ptrdiff_t, not int, to count maps.
2374 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2375 calculations. Don't update size until allocation succeeds.
2376 Redo calculations to avoid overflow.
726e0ab1
PE
2377 * keyboard.h: Change prototypes to match the above.
2378
2379 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2380 to count maps.
2381 (current_minor_maps): Check for size calculation overflow.
2382 * keymap.h: Change prototypes to match the above.
2383
2384 * lread.c (read1, init_obarray): Don't update size until alloc done.
2385
2386 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2387 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2388
726e0ab1
PE
2389 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2390 Now ptrdiff_t, not int.
2391 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2392 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2393
2394 * process.c (Fnetwork_interface_list): Check for overflow
2395 in size calculation.
2396
2397 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2398
2399 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2400 overflow. Don't bother calling xmalloc when xrealloc will do.
2401
2402 * search.c (Freplace_match): Check for size calculation overflow.
2403 (Fset_match_data): Don't assume list lengths fit in 'int'.
2404
2405 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2406 for command line length. Do not attempt to address one before the
2407 beginning of an array, as that's not portable.
2408
2409 * term.c (max_frame_lines): Remove; unused.
2410 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2411 not int.
2412 (encode_terminal_code, calculate_costs): Check for size
2413 calculation overflow.
2414 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2415 table lengths and related sizes. Don't update size until alloc
2416 done. Redo calculations to avoid overflow.
2417 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2418
2419 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2420 subtracting pointers.
2421 (gobble_line): Check for overflow more carefully. Don't update size
2422 until alloc done.
2423
2424 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2425 Don't update size until alloc done.
2426 Redo size calculations to avoid overflow.
2427 Check for size calculation overflow.
0065d054 2428 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2429
2430 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2431 Use ptrdiff_t, not int, for sizes.
2432 (store_mode_line_noprop_char): Don't update size until alloc done.
2433
0065d054
PE
2434 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2435 Use ptrdiff_t, not int, for sizes.
2436 (Finternal_make_lisp_face, cache_face):
2437 Check for size calculation overflow.
2438 (cache_face): Treat size calculation overflows as if they were
2439 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2440
2441 * xfns.c (x_encode_text, x_set_name_internal)
2442 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2443 sizes, since they can exceed INT_MAX in size. Check for size
2444 calculation overflow.
2445
0065d054
PE
2446 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2447 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2448 Don't update size until alloc done.
2449
0065d054 2450 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2451 as sprintf is limited to int lengths.
1d526e2f 2452
252c5ee1
PE
2453 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2454 (X_LONG_MIN): New macros.
864d7ce7
PE
2455 Use them to make the following changes clearer.
2456 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2457 This change doesn't affect the value now, but it may help remind
2458 future maintainers not to raise the value too much later.
2459 (SELECTION_QUANTUM): Remove, replacing with ...
2460 (selection_quantum): ... new function, which avoids overflow.
2461 All uses changed.
2462 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2463 assumption that selection length fits in 'int'.
2464 (x_reply_selection_request, x_handle_selection_request)
2465 (x_get_window_property, receive_incremental_selection)
2466 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2467 (lisp_data_to_selection_data, clean_local_selection_data):
2468 Use ptrdiff_t, not int, to record length of selection.
2469 (x_reply_selection_request, x_get_window_property)
2470 (receive_incremental_selection, x_property_data_to_lisp):
2471 Redo calculations to avoid overflow.
2472 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2473 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2474 something.
2475 (x_get_window_property, receive_incremental_selection)
2476 (lisp_data_to_selection_data, x_property_data_to_lisp):
2477 Check for size-calculation overflow.
2478 (x_get_window_property, receive_incremental_selection)
2479 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2480 Don't store size until memory allocation succeeds.
2481 (x_get_window_property): Plug memory leak on memory exhaustion.
2482 Don't double-block input; malloc is safe here. Don't assume 2**34
2483 - 4 fits in unsigned long. Add an xassert to check
2484 XGetWindowProperty overflow. Be more careful about overflow
2485 calculations, and distinguish size from memory overflow better.
2486 (receive_incremental_selection): When tracing, don't assume
2487 unsigned int is less than INT_MAX.
2488 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2489 harmful) conversions of unsigned short to int.
2490 (lisp_data_to_selection_data): Don't assume that integers
2491 in the range -65535 through -1 fit in an X unsigned short.
2492 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2493 result parameters unless successful. Rely on cons_to_unsigned
2494 to report problems with elements; the old code wasn't right anyway.
2495 (x_check_property_data): Check for int overflow; we cannot use
2496 a wider type due to X limits.
2497 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2498
726e0ab1 2499 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2500
0065d054
PE
2501 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2502 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2503 (x_color_cells): Don't store size until memory allocation succeeds.
2504 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2505 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2506 (x_term_init): Don't assume length fits in int (sprintf is limited
2507 to int size).
bc18e09d 2508
ebfa62c0
PE
2509 Use ptrdiff_t for composition IDs.
2510 * character.c (lisp_string_width):
2511 * composite.c (composition_table_size, n_compositions)
2512 (get_composition_id, composition_gstring_from_id):
2513 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2514 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2515 * window.c (Frecenter):
2516 Use ptrdiff_t, not int, for composition IDs.
2517 * composite.c (get_composition_id): Check for integer overflow.
2518 * composite.h: Adjust prototypes to match the above changes.
2519
d3411f89
PE
2520 Use ptrdiff_t for hash table indexes.
2521 * category.c (hash_get_category_set):
2522 * ccl.c (ccl_driver):
2523 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2524 * coding.c (coding_system_charset_list, detect_coding_system):
2525 * coding.h (struct coding_system.id):
2526 * composite.c (get_composition_id, gstring_lookup_cache):
2527 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2528 * image.c (xpm_get_color_table_h):
2529 * lisp.h (hash_lookup, hash_put):
2530 * minibuf.c (Ftest_completion):
2531 Use ptrdiff_t for hash table indexes, not int (which is too
2532 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2533 32-bit --with-wide-int hosts).
2534
e097a6fa
PE
2535 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2536 Add a FIXME comment about memory leaks.
2537 (syms_of_charset): Don't assume xmalloc returns.
2538
5637687f
PE
2539 Don't assume that stated character widths fit in int.
2540 * character.c (Fchar_width, c_string_width, lisp_string_width):
2541 * character.h (CHAR_WIDTH):
2542 * indent.c (MULTIBYTE_BYTES_WIDTH):
2543 Use sanitize_char_width to avoid undefined and/or bad behavior
2544 with outlandish widths.
a66cfb1c 2545 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2546 now that we have two such functions. All uses changed.
2547 (sanitize_char_width): New inline function.
2548
a2271ba2
PE
2549 Don't assume that tab-width fits in int.
2550 * character.h (sanitize_width): New inline function.
2551 (SANE_TAB_WIDTH): New macro.
2552 (ASCII_CHAR_WIDTH): Use it.
2553 * indent.c (sane_tab_width): Remove. All uses replaced by
2554 SANE_TAB_WIDTH (current_buffer).
2555 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2556
18c52557
PE
2557 * fileio.c: Integer overflow issues with file modes.
2558 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2559
caeeedc1
PE
2560 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2561 Remove unreachable code.
2562 (read_hex, load_charset_map_from_file): Check for integer overflow.
2563
6df6ae42 2564 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2565 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2566 (x_send_scroll_bar_event): Likewise. Check that the size does not
2567 exceed limits imposed by XClientMessageEvent, as well as the usual
2568 ptrdiff_t and size_t limits.
2569
b13995db
PE
2570 * keyboard.c: Overflow, signedness and related fixes.
2571 (make_lispy_movement): Use same integer type in forward decl
2572 that is used in the definition.
2573 (read_key_sequence, keyremap_step):
2574 Change bufsize argument back to int, undoing my 2011-03-30 change.
2575 We prefer signed types, and int is wide enough here.
2576 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2577 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2578 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2579 length, not size_t. Use ptrdiff_t for index, not int.
2580 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2581 possibility of integer overflow.
2582
13464394
PE
2583 Overflow, signedness and related fixes for images.
2584
2585 * dispextern.h (struct it.stack[0].u.image.image_id)
2586 (struct_it.image_id, struct image.id, struct image_cache.size)
2587 (struct image_cache.used, struct image_cache.ref_count):
2588 * gtkutil.c (update_frame_tool_bar):
2589 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2590 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2591 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2592 * nsmenu.m (update_frame_tool_bar):
2593 * xdisp.c (calc_pixel_width_or_height):
2594 * xfns.c (image_cache_refcount):
2595 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2596 on typical 64-bit hosts.
2597
2598 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2599 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2600 Omit unnecessary casts to int.
2601 (parse_image_spec): Check that integers fall into 'int' range
2602 when the callers expect that.
2603 (image_ascent): Redo ascent calculation to avoid int overflow.
2604 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2605 (lookup_image): Remove unnecessary tests.
2606 (xbm_image_p): Locals are now of int, not EMACS_INT,
2607 since parse_image_check makes sure they fit into int.
2608 (png_load, gif_load, svg_load_image):
2609 Prefer int to unsigned where either will do.
2610 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2611 old tiff_error_handler and tiff_warning_handler.
2612 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2613 stack buffer overflows. It uses only the features of vsnprintf
2614 that are common to both POSIX and native Microsoft.
2615 (tiff_error_handler, tiff_warning_handler): Use it.
2616 (tiff_load, gif_load, imagemagick_load_image):
2617 Don't assume :index value fits in 'int'.
2618 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2619 (imagemagick_load_image): Check that crop parameters fit into
2620 the integer types that MagickCropImage accepts. Don't assume
2621 Vimagemagick_render_type has a nonnegative value. Don't assume
2622 size_t fits in 'long'.
2623 (gs_load): Use printmax_t to print the widest integers possible.
2624 Check for integer overflow when computing image height and width.
2625
c11821d4
EZ
26262011-08-26 Eli Zaretskii <eliz@gnu.org>
2627
2628 * xdisp.c (redisplay_window): Don't force window start if point
2629 will be invisible in the resulting window. (Bug#9324)
2630
0c95fcf7
EZ
26312011-08-25 Eli Zaretskii <eliz@gnu.org>
2632
2633 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2634 the display spec is of the form `(space ...)'.
2635 (handle_display_spec): Return the value returned by
2636 handle_single_display_spec, not just 1 or zero.
2637 (handle_single_display_spec): If the display spec is of the form
2638 `(space ...)', and specifies display in the text area, return 2
2639 rather than 1.
fee65a97 2640 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2641 accurately, and prefer exact match for point under bidi.
2642 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2643
2644 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2645 into disp_prop; all users changed.
2646
2647 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2648 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2649 for the text covered by the display property.
2650
e4ed06f1
CY
26512011-08-25 Chong Yidong <cyd@stupidchicken.com>
2652
2653 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2654 Change return value to nil.
2655 (Frecord_buffer): Delete unused function.
2656
f67cdd7f
EZ
26572011-08-24 Eli Zaretskii <eliz@gnu.org>
2658
5980d4c6
EZ
2659 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2660 buffers, return left-to-right.
8610fe8b
EZ
2661 (set_cursor_from_row): Consider candidate row a win if its glyph
2662 represents a newline and point is on that newline. Fixes cursor
2663 positioning on the newline at EOL of R2L text within L2R
2664 paragraph, and vice versa.
2665 (try_cursor_movement): Check continued rows, in addition to
2666 continuation rows. Fixes unwarranted scroll when point enters a
2667 continued line of R2L text within an L2R paragraph, or vice versa.
2668 (cursor_row_p): Consider the case of point being equal to
2669 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2670 from the end of a short line to the beginning of a continued line
2671 of R2L text within L2R paragraph.
2672 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2673 composed characters.
5980d4c6 2674
f67cdd7f
EZ
2675 * bidi.c (bidi_check_type): Use xassert.
2676 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2677 members.
2678
bca633fb
EZ
26792011-08-23 Eli Zaretskii <eliz@gnu.org>
2680
2681 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2682 a character.
2683
4a5885a7
CY
26842011-08-23 Chong Yidong <cyd@stupidchicken.com>
2685
2686 * nsfont.m (ns_otf_to_script): Fix typo.
2687
0902a04e
KH
26882011-08-22 Kenichi Handa <handa@m17n.org>
2689
2690 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2691 extra slot even if the purpose is char-code-property-table.
2692
1a2e6670
EZ
26932011-08-23 Eli Zaretskii <eliz@gnu.org>
2694
8ddde651
EZ
2695 * xdisp.c (redisplay_window): When computing centering_position,
2696 account for the height of the header line. (Bug#8874)
2697
425cc014
EZ
2698 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2699 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2700 candidate is selected by the mouse, and that candidate has a
2701 composed character under the mouse.
2702
1a2e6670
EZ
2703 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2704 coordinates reported by pos-visible-in-window-p for a composed
2705 character in column zero.
2706
8b76d6f8
SM
27072011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2708
2709 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2710
dac347dd
EZ
27112011-08-22 Eli Zaretskii <eliz@gnu.org>
2712
2713 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2714 consider it a hit if to_charpos is anywhere in the range of the
2715 composed buffer positions.
2716
e013fb34
CY
27172011-08-22 Chong Yidong <cyd@stupidchicken.com>
2718
2719 * image.c (gif_load): Don't assume that each subimage has the same
2720 dimensions as the base image. Handle disposal method that is
2721 "undefined" by the gif spec (Bug#9335).
2722
bd1ba3e8
CY
27232011-08-20 Chong Yidong <cyd@stupidchicken.com>
2724
2725 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2726 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2727
54a1215b
EZ
27282011-08-19 Eli Zaretskii <eliz@gnu.org>
2729
823564e5
EZ
2730 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2731 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2732 from an Org mode buffer to a Speedbar frame.
2733
54a1215b
EZ
2734 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2735 a composition, take its buffer position from IT->cmp_it.charpos.
2736 Fixes cursor positioning at the beginning of a line that begins
2737 with a composed character.
2738
9778ebcc
EZ
27392011-08-18 Eli Zaretskii <eliz@gnu.org>
2740
0be6ee06
EZ
2741 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2742 character bidirectional type, use STRONG_L instead. Fixes crashes
2743 in a buffer produced by `describe-categories'.
2744
9778ebcc
EZ
2745 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2746 members before the level stack, so they would be saved and
2747 restored when copying iterator state. Fixes incorrect reordering
2748 around TABs covered by display properties.
2749
156bffbe
AS
27502011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2751
6b02f655 2752 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2753
72ad093b
CY
27542011-08-17 Chong Yidong <cyd@stupidchicken.com>
2755
2756 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2757 (internal_condition_case_2, internal_condition_case_n):
2758 Remove unnecessary aborts (Bug#9081).
72ad093b 2759
35774242
EZ
27602011-08-17 Eli Zaretskii <eliz@gnu.org>
2761
2762 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2763 has no `load' handler, try opening the file locally. (Bug#9311)
2764
db76dd85
KB
27652011-08-16 Ken Brown <kbrown@cornell.edu>
2766
2767 * gmalloc.c: Expand comment.
2768
b215eee5
EZ
27692011-08-16 Eli Zaretskii <eliz@gnu.org>
2770
2771 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2772 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2773
a4579d33
KB
27742011-08-16 Ken Brown <kbrown@cornell.edu>
2775
2776 Fix memory allocation problems in Cygwin build (Bug#9273).
2777
2778 * unexcw.c ( __malloc_initialized): Declare external variable.
2779 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2780
8b76d6f8
SM
2781 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2782 New variables.
a4579d33
KB
2783 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2784 dumped emacs.
2785 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2786 in the static heap.
2787 [CYGWIN] (special_realloc): New function.
2788 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2789 requests to realloc storage in the static heap.
2790
3ebec551
PE
27912011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2792
2793 * bidi.c (bidi_initialize): Remove unused local.
2794
9fd8be00
EZ
27952011-08-15 Eli Zaretskii <eliz@gnu.org>
2796
6b02f655
SM
2797 * bidimirror.h:
2798 * biditype.h: Remove file.
2799 * makefile.w32-in ($(BLD)/bidi.$(O)):
2800 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2801
2802 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2803
2804 * chartab.c: Improve commentary for the uniprop_table API.
2805
32413314
EZ
2806 * bidi.c (bidi_paragraph_init): Support zero value of
2807 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2808 (bidi_initialize): Use uniprop_table instead of including
2809 biditype.h and bidimirror.h.
32413314 2810
9fd8be00
EZ
2811 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2812 coordinates of the iterator when restoring from ppos_it.
2813 (Bug#9296)
2814
5cf2b69b
KH
28152011-08-14 Kenichi Handa <handa@m17n.org>
2816
2817 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2818 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2819
daf17d00
EZ
28202011-08-14 Eli Zaretskii <eliz@gnu.org>
2821
2822 * xdisp.c (move_it_in_display_line_to): Don't invoke
2823 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2824 ppos_it. Fixes vertical cursor motion when line beginning is
2825 covered by an image. (Bug#9296)
2826
08e3161a
JD
28272011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2828
2829 * nsterm.h (ns_run_ascript): Declare.
2830 (NSAPP_DATA2_RUNASSCRIPT): Define.
2831
2832 * nsfns.m (as_script, as_result, as_status): New static variables.
2833 (ns_run_ascript): New function.
5e617bc2 2834 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2835 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2836 the event loop. Get status from as_status (Bug#7276).
2837
2838 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2839 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2840 the event loop (Bug#7276).
2841
a3720aa2
AS
28422011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2843
2844 * gnutls.c (QCgnutls_bootprop_priority)
2845 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2846 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2847 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2848 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2849 (QCgnutls_bootprop_verify_hostname_error)
2850 (QCgnutls_bootprop_callbacks_verify): Rename from
2851 Qgnutls_bootprop_..., all uses changed.
2852
2853 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2854 uses changed.
2855
0a0d27fb
PE
28562011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2857
19d5c50c
PE
2858 * xfaces.c (Qframe_set_background_mode): Now static.
2859 * dispextern.h (Qframe_set_background_mode): Remove decl.
2860
0a0d27fb
PE
2861 * process.c (Fnetwork_interface_info): Declare local only if needed.
2862
377538cb
JD
28632011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2864
2865 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2866 (Fnetwork_interface_list): Allocate in increments of bytes instead
2867 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2868 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2869 sockaddr.
2870 (struct ifflag_def): notrailers is smart on OSX.
2871 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2872 Get hardware address with getifaddrs if available.
2873
08fff70c
EZ
28742011-08-12 Eli Zaretskii <eliz@gnu.org>
2875
2876 * xdisp.c (iterate_out_of_display_property): xassert that
2877 IT->position is set to within IT->object's boundaries. Break from
2878 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2879 when IT->position is set up wrongly due to some bug.
2880 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2881 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2882 entry. Force push_it to save on the stack the current
2883 buffer/string position, to be restored by pop_it. Fix flags in
2884 the iterator structure wrt the object coming from a display
2885 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2886 properties. (Bug#9284)
2887
7be1c708 28882011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2889
7be1c708
CY
2890 * fontset.c (fontset_get_font_group): Add proper type checks.
2891 (Bug#9172)
aac0c6e3 2892
7be1c708 28932011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2894
7be1c708
CY
2895 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2896 and LC_VERSION_MIN_MACOSX.
2897 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2898 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2899
97bb72a6
EZ
29002011-08-08 Eli Zaretskii <eliz@gnu.org>
2901
2902 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2903 no-display-properties-and-no-overlays under bidi display.
2904 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2905 properties and overlays.
97bb72a6 2906
d5617611
CY
29072011-08-08 Chong Yidong <cyd@stupidchicken.com>
2908
37e11a63
CY
2909 * editfns.c (Fset_time_zone_rule): Document relationship with the
2910 setenv function.
2911
d5617611
CY
2912 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2913 the font entity extracted from the cache (Bug#8109).
2914
58872834
CY
29152011-08-07 Chong Yidong <cyd@stupidchicken.com>
2916
2917 * composite.c (autocmp_chars): Don't reset point. That is done by
2918 restore_point_unwind (Bug#5984).
2919
75bfc667
JL
29202011-08-07 Juri Linkov <juri@jurta.org>
2921
2922 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2923 to show the arg `TIME' instead of `TIMEVAL'.
2924
d1410150
EZ
29252011-08-06 Eli Zaretskii <eliz@gnu.org>
2926
2927 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2928 display property strides EOL and includes a newline, as in
2929 longlines-mode. (Bug#9254)
75b771e4
EZ
2930 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2931 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2932
2933 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2934 is non-zero, even if the data buffer is NULL. Fixes a crash in
2935 vertical-motion with longlines-mode. (Bug#9254)
2936
35928349
EZ
29372011-08-05 Eli Zaretskii <eliz@gnu.org>
2938
ec7cc85b
EZ
2939 * bidi.c <bidi_cache_total_alloc>: Now static.
2940 (bidi_initialize): Initialize bidi_cache_total_alloc.
2941
8b76d6f8 2942 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2943 cache. (Bug#9221)
2944
2945 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2946 amount allocated this far in `bidi_cache_total_alloc'.
2947 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2948 non-zero, only free the data buffer without restoring the cache
2949 contents. All callers changed.
2950
2951 * dispextern.h (bidi_unshelve_cache): Update prototype.
2952
2953 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2954 (move_it_in_display_line, move_it_to)
2955 (move_it_vertically_backward, move_it_by_lines): Replace the call
2956 to xfree to an equivalent call to bidi_unshelve_cache.
2957 (move_it_in_display_line_to): Fix logic of returning
412b6358 2958 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2959
e2e2423b
EZ
29602011-08-05 Eli Zaretskii <eliz@gnu.org>
2961
2962 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2963 came from a string character with a `cursor' property. (Bug#9229)
2964
ae9e757a
JD
29652011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2966
2967 * Makefile.in (LIB_PTHREAD): New variable.
2968 (LIBES): Add LIB_PTHREAD (Bug#9216).
2969
2970 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2971 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2972
213bd7f2
AS
29732011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2974
6b02f655 2975 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2976
99aaf75f
JD
29772011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2978
2979 * xterm.c (x_find_topmost_parent): New function.
2980 (x_set_frame_alpha): Find topmost parent window with
2981 x_find_topmost_parent and set the property there also (bug#9181).
2982 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2983
c74e9d86
PE
29842011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2985
2986 * callproc.c (Fcall_process): Avoid vfork clobbering
2987 the local vars buffer, coding_systems, current_dir.
2988
640c8776
SM
29892011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2990
2991 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2992
f26d0e4c
PE
29932011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2994
8a10d76c
PE
2995 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2996 so that it is not optimized away.
2997
f26d0e4c
PE
2998 * xdisp.c (compute_display_string_pos): Remove unused local.
2999
55439c61
EZ
30002011-08-02 Eli Zaretskii <eliz@gnu.org>
3001
3002 Fix slow cursor motion and scrolling in large buffers with
3003 selective display, like Org Mode buffers. (Bug#9218)
3004
3005 * dispextern.h (struct bidi_it): New member disp_prop_p.
3006
3007 * xdisp.c: Remove one-slot cache of display string positions.
3008 (compute_display_string_pos): Accept an additional argument
5e617bc2 3009 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3010 for a display string or property. If found, set DISP_PROP_P
3011 non-zero.
3012
3013 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3014 DISP_PROP_P, and pass it to compute_display_string_pos.
3015 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3016 non-zero. All callers of bidi_fetch_char changed.
3017
fb33fa43
SM
30182011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3019
3020 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3021
b099e063
DM
30222010-12-03 Don March <don@ohspite.net>
3023
3024 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3025 last character M-[char] is translated to ESC [char] (bug#7541).
3026
5cc7f7af
KH
30272011-08-02 Kenichi Handa <handa@m17n.org>
3028
d0fffa3f 3029 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3030
3031 * chartab.c (uniprop_table): Make it non-static.
3032
525d5e6e
EZ
30332011-08-01 Eli Zaretskii <eliz@gnu.org>
3034
3035 * xdisp.c (forward_to_next_line_start): Accept additional argument
3036 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3037 on the newline.
3038 (reseat_at_next_visible_line_start): Use the bidi iterator state
3039 returned by forward_to_next_line_start to restore the state of
3040 it->bidi_it after backing up to previous newline. (Bug#9212)
3041
31011111
AS
30422011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3043
3044 * regex.c (re_comp): Protoize.
3045 (re_exec): Fix return type.
3046 (regexec): Fix type of `ret'. (Bug#9203)
3047
476371c4
PE
30482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3049
e5d76069
PE
3050 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3051 This is needed if max-image-size is a floating-point number.
3052
9a79b20c
AS
30532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3054
3055 * print.c (print_object): Print empty symbol as ##.
3056
3057 * lread.c (read1): Read ## as empty symbol.
3058
d8c2fa78
AA
30592011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3060
3061 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3062 setting frame foreground color (Bug#9175).
3063 (x_set_background_color): Likewise.
3064
ffe57a7a
AA
3065 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3066 contents (Bug#9176).
3067 (EmacsTooltip -init): Remove bezels and add shadows to
3068 tooltip windows.
3069
bf3492a5
AA
3070 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3071 or scroll bar (Bug#8470).
3072
d55e9c53
AA
3073 * nsfont.m (nsfont_open): Remove assignment to voffset and
3074 unnecessary vars hshink, expand, hd, full_height, min_height.
3075 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3076
3077 * nsterm.h (nsfont_info): Remove voffset field.
3078
d8c2fa78 30792011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3080
3081 Implement strike-through and overline on NextStep (Bug#8863).
3082
3083 * nsfont.m (nsfont_open): Use underline position provided by font,
3084 instead of hard-coded value of 2.
3085 (nsfont_draw): Call ns_draw_text_decoration instead.
3086
3087 * nsterm.h: Add declaration for ns_draw_text_decoration.
3088
3089 * nsterm.m (ns_draw_text_decoration): New function for drawing
3090 underline, overline, and strike-through.
3091 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3092 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3093 accommodate underlining, etc.
4843aac3 3094
4cc60b9b
EZ
30952011-07-28 Eli Zaretskii <eliz@gnu.org>
3096
bc7ece87
EZ
3097 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3098 default.
4cc60b9b 3099
476371c4
PE
31002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3101
66606eea
PE
3102 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3103 Without this fix, if a signal arrives just after memory fills up,
3104 'malloc' might be invoked reentrantly.
3105
476371c4
PE
3106 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3107 In other words, assume that every image size is allowed, on non-X
3108 hosts. This assumption is probably wrong, but it lets Emacs compile.
3109
f3fcc40d
AS
31102011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3111
3112 * regex.c (re_iswctype): Convert return values to boolean.
3113
350c992f
EZ
31142011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3115
3116 * xdisp.c (compute_display_string_pos): Don't use cached display
3117 string position if the buffer had its restriction changed.
3118 (Bug#9184)
3119
5266b4bb
PE
31202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3121
3122 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3123
2573a837 31242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3125
41f55ccd 3126 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3127
39e378da
PE
3128 * bidi.c: Integer size and overflow fixes.
3129 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3130 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3131 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3132 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3133 (bidi_find_other_level_edge):
3134 Use ptrdiff_t instead of EMACS_INT where either will do.
3135 This works better on 32-bit hosts configured --with-wide-int.
3136 (bidi_cache_ensure_space): Check for size-calculation overflow.
3137 Use % rather than repeated addition, for better worst-case speed.
3138 Don't set bidi_cache_size until after xrealloc returns, because it
3139 might not return.
3140 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3141 (bidi_cache_ensure_space): Also check that the bidi cache size
3142 does not exceed that of the largest Lisp string or buffer. See Eli
3143 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3144
5e927815
PE
3145 * alloc.c (__malloc_size_t): Remove.
3146 All uses replaced by size_t. See Andreas Schwab's note
3147 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3148
ca4aa935
PE
3149 * image.c: Improve checking for integer overflow.
3150 (check_image_size): Assume that f is nonnull, since
3151 it is always nonnull in practice. This is one less thing to
3152 worry about when checking for integer overflow later.
3153 (x_check_image_size): New function, which checks for integer
3154 overflow issues inside X.
3155 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3156 This removes the need for a memory_full check.
3157 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3158 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3159 (xbm_read_bitmap_data): Change locals back to 'int', since
3160 their values must fit in 'int'.
3161 (xpm_load_image, png_load, tiff_load):
3162 Invoke x_create_x_image_and_pixmap earlier,
3163 to avoid much needless work if the image is too large.
3164 (tiff_load): Treat overly large images as if
3165 x_create_x_image_and_pixmap failed, not as malloc failures.
3166 (gs_load): Use x_check_image_size.
3167
5f8f9cc2
PE
3168 * gtkutil.c: Omit integer casts.
3169 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3170 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3171
5adf60bc
PE
3172 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3173
c8907a93
PE
3174 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3175 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3176 would wrongly return t on a 64-bit host.
3177
e3c25c68
PE
3178 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3179 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3180 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3181 and therefore cause GCC to emit a bogus diagnostic in some cases.
3182
3f791afe
PE
3183 * image.c: Integer signedness and overflow and related fixes.
3184 This is not an exhaustive set of fixes, but it's time to
3185 record what I've got.
3186 (lookup_pixel_color, check_image_size): Remove redundant decls.
3187 (check_image_size): Don't assume that arbitrary EMACS_INT values
3188 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3189 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3190 (tiff_load, imagemagick_load_image):
3191 Check for overflow in size calculations.
3192 (x_create_x_image_and_pixmap): Remove unnecessary test for
3193 xmalloc returning NULL; that can't happen.
3194 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3195 (xpm_color_bucket): Use better integer hashing function.
3196 (xpm_cache_color): Don't possibly over-allocate memory.
3197 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3198 (gif_memory_source):
3199 Use ptrdiff_t, not int or size_t, to record sizes.
3200 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3201 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3202 either works, as we prefer signed integers.
3203 (tiff_read_from_memory, tiff_write_from_memory):
3204 Return tsize_t, not size_t, since that's what the TIFF API wants.
3205 (tiff_read_from_memory): Don't fail simply because the read would
3206 go past EOF; instead, return a short read.
3207 (tiff_load): Omit no-longer-needed casts.
3208 (Fimagemagick_types): Don't assume size fits into 'int'.
3209
3cc5a532
PE
3210 Improve hashing quality when configured --with-wide-int.
3211 * fns.c (hash_string): New function, taken from sxhash_string.
3212 Do not discard information about ASCII character case; this
3213 discarding is no longer needed.
3214 (sxhash-string): Use it. Change sig to match it. Caller changed.
3215 * lisp.h: Declare it.
3216 * lread.c (hash_string): Remove, since we now use fns.c's version.
3217 The fns.c version returns a wider integer if --with-wide-int is
3218 specified, so this should help the quality of the hashing a bit.
3219
b312a492
PE
3220 * emacs.c: Integer overflow minor fix.
3221 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3222 Define only if GNU_LINUX.
3223 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3224
dfd153ae
PE
3225 * dispnew.c: Integer signedness and overflow fixes.
3226 Remove unnecessary forward decls, that were a maintenance hassle.
3227 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3228 All uses changed.
3229 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3230 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3231 (prepare_desired_row, line_draw_cost):
3232 Use int, not unsigned, where either works.
3233 (save_current_matrix, restore_current_matrix):
3234 Use ptrdiff_t, not size_t, where either works.
3235 (init_display): Check for overflow more accurately, and without
3236 relying on undefined behavior.
3237
a81d11a3
PE
3238 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3239 Remove, replacing with the new symbols in lisp.h. All uses changed.
3240 * fileio.c (make_temp_name):
3241 * filelock.c (lock_file_1, lock_file):
3242 * xdisp.c (message_dolog):
3243 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3244 Use pMd etc. instead.
3245 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3246 replacing the pWIDE etc. symbols removed from editfns.c.
3247
3300e6fd
PE
3248 * keyboard.h (num_input_events): Now uintmax_t.
3249 This is (very slightly) less likely to mess up due to wraparound.
3250 All uses changed.
3251
fd05c7e9
PE
3252 * buffer.c: Integer signedness fixes.
3253 (alloc_buffer_text, enlarge_buffer_text):
3254 Use ptrdiff_t rather than size_t when either will do, as we prefer
3255 signed integers.
3256
903fe15d
PE
3257 * alloc.c: Integer signedness and overflow fixes.
3258 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3259 (__malloc_size_t): Default to size_t, not to int.
3260 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3261 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3262 Prefer ptrdiff_t to size_t when either would do, as we prefer
3263 signed integers.
3264 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3265 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3266 Now const. Initialize with values that are in range even if char
3267 is signed.
3268 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3269 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3270 These functions do the right thing with sizes > 2**32.
3271 (check_depth): Now ptrdiff_t, not int.
3272 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3273 Adjust to new way of storing sizes. Check for size overflow bugs
3274 in rest of code.
3275 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3276 slightly wrong anyway, as it missed one instance of
3277 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3278 (refill_memory_reserve): Omit needless cast to size_t.
3279 (mark_object_loop_halt): Mark as externally visible.
3280
ac82cc6a
PE
3281 * xselect.c: Integer signedness and overflow fixes.
3282 (Fx_register_dnd_atom, x_handle_dnd_message):
3283 Use ptrdiff_t, not size_t, since we prefer signed.
3284 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3285 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3286 x_dnd_atoms_size and x_dnd_atoms_length.
3287
c2d1e36d
PE
3288 * doprnt.c: Prefer signed to unsigned when either works.
3289 * eval.c (verror):
3290 * doprnt.c (doprnt):
3291 * lisp.h (doprnt):
3292 * xdisp.c (vmessage):
3293 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3294 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3295 prefer signed arithmetic to avoid comparison confusion.
3296 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3297 but is a bit tricky.
3298
0e926e56
PE
3299 Assume freestanding C89 headers, string.h, stdlib.h.
3300 * data.c, doprnt.c, floatfns.c, print.c:
3301 Include float.h unconditionally.
3302 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3303 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3304 * regex.c: Likewise for stddef.h, string.h.
3305 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3306 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3307 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3308 (STDC_HEADERS): Remove obsolete defines.
3309 * sysdep.c: Include limits.h unconditionally.
3310
9cfdb3ec
PE
3311 Assume support for memcmp, memcpy, memmove, memset.
3312 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3313 * regex.c (memcmp, memcpy):
3314 Remove; we assume C89 now.
3315
3316 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3317 (__malloc_safe_bcopy): Remove; no longer needed.
3318
cf950e6b 3319 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3320 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3321 well either way, and we prefer signed to unsigned.
3322
dbf38e02
LMI
33232011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3324
3325 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3326 closes the connection while we're reading (bug#9182).
3327
d6f0886c 33282011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3329
d6f0886c
JD
3330 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3331 are specified (Bug#9168).
24e0f6b1 3332
2eb1f9e6
PE
33332011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3334
3335 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3336 Found by GCC static checking and --with-wide-int on a 32-bit host.
3337
22381272 33382011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3339
3340 * xdisp.c (compute_display_string_pos): Fix logic of caching
3341 previous display string position. Initialize cached_prev_pos to
3342 -1. Fixes slow-down at the beginning of a buffer.
3343
f25e39b4
EZ
33442011-07-24 Eli Zaretskii <eliz@gnu.org>
3345
3346 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3347 for attrs[LFACE_FONTSET_INDEX].
3348
04c4b52e
PE
33492011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3350
3351 * xml.c (parse_region): Remove unused local
3352 that was recently introduced.
3353
c1734fbd
EZ
33542011-07-23 Eli Zaretskii <eliz@gnu.org>
3355
be18c5a5
EZ
3356 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3357 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3358
c1734fbd
EZ
3359 * xdisp.c (move_it_in_display_line_to): Record the best matching
3360 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3361 exit if none of the characters scanned was an exact match.
3362 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3363 when exact match is impossible due to invisible text, and the
3364 lines are truncated.
3365
a258d627
JD
33662011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3367
3368 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3369 for OSX >= 10.7.
3370
b6d5a689
EZ
33712011-07-22 Eli Zaretskii <eliz@gnu.org>
3372
0f74f785
EZ
3373 Fix a significant slow-down of cursor motion with C-n, C-p,
3374 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3375 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3376 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3377 (next_element_from_buffer): Call compute_stop_pos_backwards to
3378 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3379 base_level_stop.
3380 (reseat): Don't look for prev_stop, as that could mean a very long
3381 run.
3382 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3383 <cached_disp_overlay_modiff>: Cache for last found display string
3384 position.
551918c1 3385 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3386 about the same buffer in the same area of character positions, and
3387 the buffer wasn't changed since the time the display string
3388 position was cached.
551918c1 3389
b2d0c91a
EZ
33902011-07-22 Eli Zaretskii <eliz@gnu.org>
3391
3392 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3393 is an integer, which is important for empty lines. (Bug#9149)
3394
043604ee
CY
33952011-07-22 Chong Yidong <cyd@stupidchicken.com>
3396
3397 * frame.c (Fmodify_frame_parameters): In tty case, update the
3398 default face if necessary (Bug#4238).
3399
da4adb04
CY
34002011-07-21 Chong Yidong <cyd@stupidchicken.com>
3401
3402 * editfns.c (Fstring_to_char): No need to explain what a character
3403 is in the docstring (Bug#6576).
3404
9abd0532
LMI
34052011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3406
3407 * xml.c (parse_region): Make sure we always return a tree.
3408
36881d16
HK
34092011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3410
3411 * xml.c (parse_region): If a document contains only comments,
3412 return that, too.
3413
1e98674d
LMI
34142011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3415
3416 * xml.c (make_dom): Return comments, too.
3417
590bd467
PE
34182011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3419
3420 Port to OpenBSD.
3421 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3422 and the surrounding thread.
3423 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3424 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3425 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3426 timer goes off.
3427 * s/openbsd.h (BROKEN_SIGIO): Define.
3428 * unexelf.c (unexec) [__OpenBSD__]:
3429 Don't update the .mdebug section of the Alpha COFF symbol table.
3430
f41628b2
LMI
34312011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3432
3433 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3434 (bug#8460).
3435
b59b67c5
PE
34362011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3437
15e3a074
PE
3438 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3439 This fixes some race conditions on the permissions of any newly
3440 created file.
3441
41bed37d
PE
3442 * alloc.c (valid_pointer_p): Use pipe, not open.
3443 This fixes some permissions issues when debugging.
3444
b59b67c5
PE
3445 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3446 If fchown fails to set both uid and gid, try to set just gid,
3447 as that is sometimes allowed. Adjust the file's mode to eliminate
3448 setuid or setgid bits that are inappropriate if fchown fails.
3449
925a6be7
SM
34502011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3451
3452 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3453 to compare Lisp_Objects.
3454 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3455 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3456 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3457
52968808
AS
34582011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3459
0a6a104b
AS
3460 * lread.c (read_integer): Unread even EOF character.
3461 (read1): Likewise. Properly record start position of symbol.
3462
52968808
AS
3463 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3464 symbol character follows.
3465
9e381cdd
PE
34662011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3467
3468 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3469 This works around a problem with the previous change to Fcopy_file.
3470 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3471 and without this change, GCC might complain about discarding
3472 fchown's return value.
3473
b5641435
JB
34742011-07-16 Juanma Barranquero <lekktu@gmail.com>
3475
3476 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3477
a8031457
PE
34782011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3479
3480 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3481
dd889327
LMI
34822011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3483
750c33f7
LMI
3484 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3485 it's used from the C level.
3486
dd889327
LMI
3487 * process.c: Use the same condition for POLL_FOR_INPUT in both
3488 keyboard.c and process.c (bug#1858).
3489
87e86684
LM
34902011-07-09 Lawrence Mitchell <wence@gmx.li>
3491
3492 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3493 (Fgnutls_boot): Use it.
3494
64348f40
AS
34952011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3496
3497 * doc.c (Fsubstitute_command_keys): Revert last change.
3498
1d698799
LMI
34992011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3500
f863868c
LMI
3501 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3502 quotes the next character, and doesn't affect other longer
3503 sequences (bug#8935).
3504
1d698799
LMI
3505 * lread.c (syms_of_lread): Clarify that is isn't only
3506 `eval-buffer' and `eval-defun' that's affected by
3507 `lexical-binding' (bug#8460).
3508
aa4b6df6
EZ
35092011-07-15 Eli Zaretskii <eliz@gnu.org>
3510
3511 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3512 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3513
5d856da6
PE
35142011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3515
ad6042bb
PE
3516 Fix minor problems found by static checking.
3517 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3518 (elsz): Now a signed constant, not a size_t var. We prefer signed
3519 types to unsigned, to avoid integer comparison confusion. Without
3520 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3521 "cannot optimize loop, the loop counter may overflow", a symptom
3522 of the confusion.
f00bbb22 3523 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3524 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3525
6468f31c
LMI
35262011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3527
49080b10
LMI
3528 * search.c (Fre_search_backward): Mention `case-fold-search' in
3529 all the re_search_* functions (bug#8138).
3530
6468f31c
LMI
3531 * keyboard.c (Fopen_dribble_file): Document when the file is
3532 closed (bug#8056).
3533
c965adc5
EZ
35342011-07-14 Eli Zaretskii <eliz@gnu.org>
3535
df9733bf
EZ
3536 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3537 bidi_cache_idx.
3538
0bb23927
EZ
3539 Support bidi reordering of display and overlay strings.
3540 * xdisp.c (compute_display_string_pos)
3541 (compute_display_string_end): Accept additional argument STRING.
3542 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3543 (reseat_to_string): Initialize bidi_it->string.s and
3544 bidi_it->string.schars.
3545 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3546 NULL (avoids a crash in bidi_paragraph_init).
3547 Initialize itb.string.lstring.
0bb23927
EZ
3548 (init_iterator): Call bidi_init_it only of a valid
3549 buffer position was specified. Initialize paragraph_embedding to
3550 L2R.
3551 (reseat_to_string): Initialize the bidi iterator.
3552 (display_string): If we need to ignore text properties of
3553 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3554 original value of -1 will not work with bidi.)
3555 (compute_display_string_pos): First arg is now struct
3556 `text_pos *'; all callers changed. Support display properties on
3557 Lisp strings.
3558 (compute_display_string_end): Support display properties on Lisp
3559 strings.
3560 (init_iterator, reseat_1, reseat_to_string): Initialize the
3561 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3562 when iterating on a string not from display properties).
640c8776
SM
3563 (compute_display_string_pos, compute_display_string_end):
3564 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3565 arrow keys.
3566 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3567 base_level_stop; instead, set base_level_stop to BEGV.
3568 Fixes crashes in vertical-motion.
0bb23927
EZ
3569 (next_element_from_buffer): Improve commentary for when
3570 the iterator is before prev_stop.
3571 (init_iterator): Initialize bidi_p from the default value of
3572 bidi-display-reordering, not from buffer-local value. Use the
3573 buffer-local value only if initializing for buffer iteration.
3574 (handle_invisible_prop): Support invisible properties on strings
3575 that are being bidi-reordered.
3576 (set_iterator_to_next): Support bidi reordering of C strings and
3577 Lisp strings.
3578 (next_element_from_string): Support bidi reordering of Lisp
3579 strings.
3580 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3581 (display_string): Support display of R2L glyph rows.
3582 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3583 (init_iterator): Don't initialize it->bidi_p for strings
3584 here.
3585 (reseat_to_string): Initialize it->bidi_p for strings here.
3586 (next_element_from_string, next_element_from_c_string)
3587 (next_element_from_buffer): Add xassert's for correspondence
3588 between IT's object being iterated and it->bidi_it.string
3589 structure.
3590 (face_before_or_after_it_pos): Support bidi iteration.
3591 (next_element_from_c_string): Handle the case of the first string
3592 character that is not the first one in the visual order.
3593 (get_visually_first_element): New function, refactored from common
3594 parts of next_element_from_buffer, next_element_from_string, and
3595 next_element_from_c_string.
3596 (tool_bar_lines_needed, redisplay_tool_bar)
3597 (display_menu_bar): Force left-to-right direction. Add a FIXME
3598 comment for making that be controlled by a user option.
3599 (push_it, pop_it): Save and restore the state of the
3600 bidi iterator. Save and restore the bidi_p flag.
3601 (pop_it): Iterate out of display property for string iteration as
3602 well.
3603 (iterate_out_of_display_property): Support iteration over strings.
3604 (handle_single_display_spec): Set up it->bidi_it for iteration
3605 over a display string, and call bidi_init_it.
3606 (handle_single_display_spec, next_overlay_string)
3607 (get_overlay_strings_1, push_display_prop): Set up the bidi
3608 iterator for displaying display or overlay strings.
3609 (forward_to_next_line_start): Don't use the shortcut if
3610 bidi-iterating.
3611 (back_to_previous_visible_line_start): If handle_display_prop
3612 pushed the iterator stack, restore the internal state of the bidi
3613 iterator by calling bidi_pop_it same number of times.
3614 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3615 and we are bidi-iterating, don't decrement the iterator position;
3616 instead, set the first_elt flag in the bidi iterator, to produce
3617 the same effect.
3618 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3619 (push_display_prop): xassert that we are iterating a buffer.
3620 (push_it, pop_it): Save and restore paragraph_embedding member.
3621 (handle_single_display_spec, next_overlay_string)
3622 (get_overlay_strings_1, reseat_1, reseat_to_string)
3623 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3624 correctly. Don't assume unibyte strings are not bidi-reordered.
3625 (compute_display_string_pos)
3626 (compute_display_string_end): Fix handling the case of C string.
3627 (push_it, pop_it): Save and restore from_disp_prop_p.
3628 (handle_single_display_spec, push_display_prop): Set the
3629 from_disp_prop_p flag.
3630 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3631 (pop_it): Call iterate_out_of_display_property only if we are
3632 popping after iteration over a string that came from a display
3633 property. Fix a typo in popping stretch info. Add an assertion
3634 for verifying that the iterator position is in sync with the bidi
3635 iterator.
3636 (handle_single_display_spec, get_overlay_strings_1)
3637 (push_display_prop): Fix initialization of paragraph direction for
3638 string when that of the parent object is not yet determined.
3639 (reseat_1): Call bidi_init_it to resync the bidi
3640 iterator with IT's position. (Bug#7616)
3641 (find_row_edges): If ROW->start.pos gives position
3642 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3643 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3644 Reset the from_disp_prop_p flag.
3645 (SAVE_IT, RESTORE_IT): New macros.
3646 (pos_visible_p, face_before_or_after_it_pos)
3647 (back_to_previous_visible_line_start)
3648 (move_it_in_display_line_to, move_it_in_display_line)
3649 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3650 (try_scrolling, redisplay_window, display_line): Use them when
3651 saving a temporary copy of the iterator and restoring it back.
3652 (back_to_previous_visible_line_start, reseat_1)
3653 (init_iterator): Empty the bidi cache "stack".
3654 (move_it_in_display_line_to): If iterator ended up at
3655 EOL, but we never saw any buffer positions smaller than
3656 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3657 motion in bidi-reordered lines.
3658 (move_it_in_display_line_to): Record prev_method and prev_pos
3659 immediately before the call to set_iterator_to_next. Fixes cursor
3660 motion in bidi-reordered lines with stretch glyphs and strings
3661 displayed in margins. (Bug#8133) (Bug#8867)
3662 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3663 TO_CHARPOS.
640c8776
SM
3664 (pos_visible_p): Support positions in bidi-reordered lines.
3665 Save and restore bidi cache.
0bb23927
EZ
3666
3667 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3668 (bidi_paragraph_info): Delete unused struct.
3669 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3670 (bidi_cache_start): New variable.
3671 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3672 to zero.
3673 (bidi_cache_fetch_state, bidi_cache_search)
3674 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3675 (bidi_cache_find, bidi_peek_at_next_level)
3676 (bidi_level_of_next_char, bidi_find_other_level_edge)
3677 (bidi_move_to_visually_next): Compare cache index with
3678 bidi_cache_start rather than with zero.
3679 (bidi_fetch_char): Accept new argument STRING; all callers
3680 changed. Support iteration over a string. Support strings with
3681 display properties. Support unibyte strings. Fix the type of
3682 `len' according to what STRING_CHAR_AND_LENGTH expects.
3683 (bidi_paragraph_init, bidi_resolve_explicit_1)
3684 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3685 (bidi_level_of_next_char, bidi_move_to_visually_next):
3686 Support iteration over a string.
0bb23927
EZ
3687 (bidi_set_sor_type, bidi_resolve_explicit_1)
3688 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3689 can now be zero (for strings); special values 0 and -1 were
3690 changed to -1 and -2, respectively.
3691 (bidi_char_at_pos): New function.
3692 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3693 Call it instead of FETCH_MULTIBYTE_CHAR.
3694 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3695 initialized to valid values.
3696 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3697 values.
3698 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3699 the test for valid cached positions. Fix the logic for looking up
3700 the sentinel state in the cache. GCPRO the Lisp string we are
3701 iterating.
3702 (bidi_push_it, bidi_pop_it): New functions.
3703 (bidi_initialize): Initialize the bidi cache start stack pointer.
3704 (bidi_cache_ensure_space): New function, refactored from part of
3705 bidi_cache_iterator_state. Don't assume the required size is just
3706 one BIDI_CACHE_CHUNK away.
3707 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3708 (bidi_count_bytes, bidi_char_at_pos): New functions.
3709 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3710 always valid if bidi_cache_idx is valid.
3711 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3712 is valid if it's going to be used.
3713 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3714 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3715 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3716 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3717 (bidi_find_other_level_edge, bidi_cache_start_stack):
3718 All variables related to cache indices are now EMACS_INT.
c965adc5 3719
0bb23927
EZ
3720 * dispextern.h (struct bidi_string_data): New structure.
3721 (struct bidi_it): New member `string'. Make flag members be 1-bit
3722 fields, and put them last in the struct.
640c8776
SM
3723 (compute_display_string_pos, compute_display_string_end):
3724 Update prototypes.
0bb23927
EZ
3725 (bidi_push_it, bidi_pop_it): Add prototypes.
3726 (struct iterator_stack_entry): New members bidi_p,
3727 paragraph_embedding, and from_disp_prop_p.
3728 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3729 (bidi_shelve_cache, bidi_unshelve_cache):
3730 Declare prototypes.
0bb23927
EZ
3731
3732 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3733 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3734 and vector-like objects.
3735
3736 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3737 cache around display iteration.
3738
3739 * window.c (Fwindow_end, window_scroll_pixel_based)
3740 (displayed_window_lines, Frecenter): Save and restore the bidi
3741 cache around display iteration.
3742
3bbd2265
LMI
37432011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3744
3745 * editfns.c (Fdelete_region): Clarify the use of the named
3746 parameters (bug#6788).
3747
adc47434
MR
37482011-07-14 Martin Rudalics <rudalics@gmx.at>
3749
3750 * indent.c (Fvertical_motion): Set and restore w->pointm when
3751 saving and restoring the window's buffer (Bug#9006).
3752
837c31f8
LMI
37532011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3754
3755 * editfns.c (Fstring_to_char): Clarify just what is returned
3756 (bug#6576). Text by Eli Zaretskii.
3757
ac389d0c
JB
37582011-07-13 Juanma Barranquero <lekktu@gmail.com>
3759
3760 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3761
0be0ce47
EZ
37622011-07-13 Eli Zaretskii <eliz@gnu.org>
3763
3764 * buffer.c (mmap_find): Fix a typo.
3765
cd18e7e3
JB
37662011-07-13 Johan Bockgård <bojohan@gnu.org>
3767
3768 Fix execution of x selection hooks.
3769 * xselect.c (Qx_lost_selection_functions)
3770 (Qx_sent_selection_functions): New vars.
3771 (syms_of_xselect): DEFSYM them.
3772 (x_handle_selection_request): Pass Qx_sent_selection_functions
3773 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3774 (x_handle_selection_clear,x_clear_frame_selections):
3775 Pass Qx_lost_selection_functions rather than
3776 Vx_lost_selection_functions to Frun_hook_with_args.
3777
47ea7f44
PE
37782011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3779
ac389d0c 3780 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3781 The old code sometimes used this field without initializing it.
3782
47ea7f44
PE
3783 * alloc.c (gc_sweep): Don't read past end of array.
3784 In theory, the old code could also have corrupted Emacs internals,
3785 though it'd be very unlikely.
3786
bc985c87
AS
37872011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3788
3789 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3790 argument. (Bug#4026)
bc985c87 3791
0cf34688
LMI
37922011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3793
b3dadd76
LMI
3794 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3795 key" (bug#4257).
3796
0cf34688
LMI
3797 * window.c (Fset_window_start): Doc fix (bug#4199).
3798 (Fset_window_hscroll): Ditto.
3799
270768cd
PE
38002011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3801
077e3dda 3802 Fix minor new problems caught by GCC 4.6.1.
270768cd 3803 * term.c (init_tty): Remove unused local.
490011a6 3804 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3805 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3806 not used otherwise.
270768cd 3807
b1f58454
CY
38082011-07-12 Chong Yidong <cyd@stupidchicken.com>
3809
3810 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3811
22b9578d
LMI
38122011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3813
6e70ab07
LMI
3814 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3815 are the mini-buffer and the echo area (bug#3320).
3816
22b9578d
LMI
3817 * term.c (init_tty): Remove support for supdup, c10 and perq
3818 terminals, which are no longer supported (bug#1482).
3819
8974cc9f
JB
38202011-07-10 Johan Bockgård <bojohan@gnu.org>
3821
3822 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3823
a560d974
JD
38242011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3825
3826 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3827 for non-popups (Bug#3642).
3828
1dae0f0a
AS
38292011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3830
268c2c36 3831 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3832 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3833 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3834 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3835 * data.c (fmod): Likewise.
3836 * dispnew.c (swap_glyphs_in_rows): Likewise.
3837 * emacs.c (memory_warning_signal): Likewise.
3838 * floatfns.c (float_error): Likewise.
3839 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3840 (otf_open, font_otf_capability, generate_otf_features)
3841 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3842 Likewise.
3843 * image.c (pbm_read_file): Likewise.
3844 * indent.c (string_display_width): Likewise.
3845 * intervals.c (check_for_interval, search_for_interval)
3846 (inc_interval_count, count_intervals, root_interval)
3847 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3848 * lread.c (defalias): Likewise.
268c2c36 3849 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3850 * regex.c (set_image_of_range_1, set_image_of_range)
3851 (regex_grow_registers): Likewise.
3852 * sysdep.c (strerror): Likewise.
3853 * termcap.c (valid_filename_p, tprint, main): Likewise.
3854 * tparam.c (main): Likewise.
3855 * unexhp9k800.c (run_time_remap, save_data_space)
3856 (update_file_ptrs, read_header, write_header, calculate_checksum)
3857 (copy_file, copy_rest, display_header): Likewise.
3858 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3859 Likewise.
3860 * xdisp.c (check_it): Likewise.
3861 * xfaces.c (register_color, unregister_color, unregister_colors):
3862 Likewise.
3863 * xfns.c (print_fontset_result): Likewise.
3864 * xrdb.c (member, fatal, main): Likewise.
3865
99033785
PE
38662011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3867
3868 Fix minor problems found by static checking (Bug#9031).
3869 * chartab.c (char_table_set_range, map_sub_char_table):
3870 Remove unused locals.
3871 (uniprop_table): Now static.
3872 * composite.c (_work_char): Remove unused static var.
3873
9cb2ac56
JB
38742011-07-09 Juanma Barranquero <lekktu@gmail.com>
3875
3876 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3877
f25661f0
JD
38782011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3879
3880 * gtkutil.c (qttip_cb): Remove code without function.
3881
8278c4fe
EZ
38822011-07-09 Eli Zaretskii <eliz@gnu.org>
3883
3884 * w32.c (pthread_sigmask): New stub.
3885
1692ae2d 38862011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3887
8a6ebd58 3888 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3889 sigprocmask is portable only for single-threaded applications, and
3890 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3891 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3892 (LIBES): Use it.
3893 * callproc.c (Fcall_process):
3894 * process.c (create_process):
3895 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3896 Use pthread_sigmask, not sigprocmask.
123403e4 3897
1b854618
JD
38982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3899
3900 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3901 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3902 wrong (Bug#8591).
3903
3fe4b549
JD
39042011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3905
0ce7e563
JD
3906 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3907 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3908 (xg_hide_tooltip): Fix comment.
3909
3fe4b549
JD
3910 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3911 in registerServicesMenuSendTypes.
3912 (validRequestorForSendType): Don't check ns_return_types.
3913
3914 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3915 ns_return_type.
3916
5df75e47
JR
39172011-07-08 Jason Rumney <jasonr@gnu.org>
3918
22610910
JR
3919 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3920 SH_SHOW for hidden windows (Bug#5482).
3921
5df75e47
JR
3922 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3923 frame struct members of non-existent frames (Bug#6284).
3924
699c10bd
JD
39252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3926
4393663b
JD
3927 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3928 variable firstTime not needed on OSX >= 10.6.
3929 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3930 >= 10.5. Use setKnobProportion, setDoubleValue.
3931
3932 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3933 (MAC_OS_X_VERSION_10_5): Define if not defined.
3934 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3935 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3936 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3937
3938 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3939 cString and lossyCString on OSX >= 10.4
3940
58179cce 3941 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3942 sizeToFit on OSX >= 10.2.
3943
3944 * nsimage.m (allocInitFromFile): Don't use deprecated method
3945 bestRepresentationForDevice on OSX >= 10.6.
3946
3947 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3948 to avoid warning.
3949
3950 * emacs.c: Declare unexec_init_emacs_zone.
3951
a63e0781
JD
3952 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3953
699c10bd
JD
3954 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3955
3956 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3957 on svcsMenu (Bug#8842).
3958
3959 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3960 ns_return_types.
3961 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3962
3963 * nsterm.m (QUTF8_STRING): Declare.
3964 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3965 (validRequestorForSendType): Return type is (id).
3966 Change indexOfObjectIdenticalTo to indexOfObject.
3967 Check if we have local selection before returning self (Bug#8842).
3968 (writeSelectionToPasteboard): Put local selection into paste board
3969 if we have a local selection (Bug#8842).
3970 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3971
3972 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3973 (ns_get_local_selection): Declare.
3974
54e10184
LMI
39752011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3976
9888ff71
LMI
3977 * keymap.c (describe_map_tree): Don't insert a double newline at
3978 the end of the buffer (bug#1169) and return whether we inserted
3979 something.
3980
54e10184
LMI
3981 * callint.c (Fcall_interactively): Change "reading args" to
3982 "providing args" to try to clarify what it does (bug#1010).
3983
15fa4783
KH
39842011-07-07 Kenichi Handa <handa@m17n.org>
3985
3986 * composite.c (composition_compute_stop_pos): Ignore a static
3987 composition starting before CHARPOS (Bug#8915).
3988
3989 * xdisp.c (handle_composition_prop): Likewise.
3990
a8815b00
EZ
39912011-07-07 Eli Zaretskii <eliz@gnu.org>
3992
3993 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3994 (Bug#9015)
3995
ef7b981d 39962011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3997
3998 * character.h (unicode_category_t): New enum type.
3999
4000 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4001 (Qchar_code_property_table): New variable.
4002 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4003 (UNIPROP_COMPRESSED_FORM_P): New macros.
4004 (char_table_ascii): Uncompress the compressed values.
4005 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4006 Uncompress the compressed values.
ac389d0c 4007 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4008 (char_table_ref_and_range): Uncompress the compressed values.
4009 (sub_char_table_set): New arg is_uniprop. Callers changed.
4010 Uncompress the compressed values.
4011 (sub_char_table_set_range): Args changed. Callers changed.
4012 (char_table_set_range): Adjuted for the above change.
4013 (map_sub_char_table): Delete args default_val and parent. Add arg
4014 top. Give decoded values to a Lisp function.
640c8776 4015 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4016 values to a Lisp function. Gcpro more variables.
4017 (uniprop_table_uncompress)
4018 (uniprop_decode_value_run_length): New functions.
4019 (uniprop_decoder, uniprop_decoder_count): New variables.
4020 (uniprop_get_decoder, uniprop_encode_value_character)
4021 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4022 New functions.
4023 (uniprop_encoder, uniprop_encoder_count): New variables.
4024 (uniprop_get_encoder, uniprop_table)
4025 (Funicode_property_table_internal, Fget_unicode_property_internal)
4026 (Fput_unicode_property_internal): New functions.
4027 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4028 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4029 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4030 char-code-property-alist.
4031
640c8776 4032 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4033 Vunicode_category_table.
4034
640c8776 4035 * font.c (font_range): Adjust for the change of
c805dec0
KH
4036 Vunicode_category_table.
4037
76b397fb
DN
40382011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4039
4040 * m/iris4d.h: Remove file, move contents ...
4041 * s/irix6-5.h: ... here.
4042
22b4128e
PE
40432011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4044
4045 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4046 * alloc.c (mark_buffer):
4047 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4048 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4049 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4050 This isn't true in general, and it's particularly not true
4051 if Emacs is configured with --with-wide-int.
4052 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4053 New macros, used in the buffer.c change.
4054
869795d6
JD
40552011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4056
4057 * xsettings.c: Use both GConf and GSettings if both are available.
4058 (store_config_changed_event): Add comment.
4059 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4060 (store_tool_bar_style_changed): New functions.
5e617bc2 4061 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4062 (struct xsettings): Move font inside HAVE_XFT.
4063 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4064 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4065 Move inside HAVE_XFT.
640c8776 4066 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4067 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4068 also.
4069 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4070 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4071 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4072 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4073 (parse_settings): Move check for font inside HAVE_XFT.
4074 (read_settings, apply_xft_settings): Add comment.
4075 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4076 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4077 call store_font_name_changed.
4078 (xft_settings_event): Add comment.
4079 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4080 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4081 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4082 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4083 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4084 (xsettings_get_system_font, xsettings_get_system_normal_font):
4085 Add comment.
869795d6 4086
d8ed26bd
PE
40872011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4088
4089 Random fixes. E.g., (random) never returned negative values.
4090 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4091 subseconds part to the entropy, as that's a bit more random.
4092 Prefer signed to unsigned, since the signedness doesn't matter and
4093 in general we prefer signed. When given a limit, use a
4094 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4095 latter isn't right if USE_2_TAGS_FOR_INTS.
4096 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4097 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4098
cabf1cac
SM
40992011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4100
4101 * textprop.c (text_property_stickiness):
4102 Obey Vtext_property_default_nonsticky.
4103 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4104 * w32fns.c (syms_of_w32fns):
4105 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4106
6e9b2be9
PE
41072011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4108
4109 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4110 This is more efficient than Ffile_directory_p and avoids a minor race.
4111
90186c68
LMI
41122011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4113
7c301272
LMI
4114 * buffer.c (Foverlay_put): Say what the return value is
4115 (bug#7835).
4116
c4f2d8d4
LMI
4117 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4118 is a directory before asking whether to use the file name
4119 (bug#7564).
ad637907
LMI
4120 (barf_or_query_if_file_exists): Make the "File is a directory"
4121 error be more correct.
c4f2d8d4 4122
90186c68
LMI
4123 * fns.c (Frequire): Remove the mention of the .gz files, since
4124 that's installation-specific, but keep the mention of
4125 `get-load-suffixes'.
4126
da64016e
PE
41272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4128
4129 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4130 Report string overflow if the output is too long.
4131
7d47b580
JB
41322011-07-04 Juanma Barranquero <lekktu@gmail.com>
4133
a555cb87
JB
4134 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4135 (syms_of_gnutls): Remove duplicate DEFSYM for
4136 Qgnutls_bootprop_verify_hostname_error, an error for
4137 Qgnutls_bootprop_verify_error (which is no longer used).
4138
7d47b580
JB
4139 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4140 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4141 Also (re)move comments that are misplaced or no longer relevant.
4142
1e49bfab
LMI
41432011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4144
4145 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4146
1485f4c0
CY
41472011-07-03 Chong Yidong <cyd@stupidchicken.com>
4148
4149 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4150 and background color parameters if they have been changed.
4151
a9ab721e
LMI
41522011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4153
4154 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4155
cf7cff57
PE
41562011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4157
2e13213d
PE
4158 * xsettings.c (SYSTEM_FONT): Define only when used.
4159 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4160
cf7cff57
PE
4161 * keymap.c (access_keymap_1): Now static.
4162
7a8e04f7
CY
41632011-07-02 Chong Yidong <cyd@stupidchicken.com>
4164
4165 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4166 leave any prefix arg for the up event (Bug#1586).
4167
61352f62
LMI
41682011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4169
69bb1ef7
LMI
4170 * lread.c (syms_of_lread): Mention single symbols defined by
4171 `defvar' or `defconst' (bug#7154).
4172
61352f62 4173 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4174 (Frequire): Mention get-load-suffixes.
61352f62 4175
28545e04
MR
41762011-07-02 Martin Rudalics <rudalics@gmx.at>
4177
4178 * window.h (window): Remove clone_number slot.
4179 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4180 Remove.
4181 (make_parent_window, make_window, saved_window)
4182 (Fset_window_configuration, save_window_save): Don't deal with
4183 clone numbers.
4184 * buffer.c (Qclone_number): Remove declaration.
4185 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4186
3349e122
SM
41872011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4188
4189 Add multiple inheritance to keymaps.
4190 * keymap.c (Fmake_composed_keymap): New function.
4191 (Fset_keymap_parent): Simplify.
4192 (fix_submap_inheritance): Remove.
4193 (access_keymap_1): New function extracted from access_keymap to handle
4194 embedded parents and handle lists of maps.
4195 (access_keymap): Use it.
4196 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4197 (Fcopy_keymap): Handle embedded parents.
4198 (Fcommand_remapping, define_as_prefix): Simplify.
4199 (Fkey_binding): Simplify.
4200 (syms_of_keymap): Move minibuffer-local-completion-map,
4201 minibuffer-local-filename-completion-map,
4202 minibuffer-local-must-match-map, and
4203 minibuffer-local-filename-must-match-map to Elisp.
4204 (syms_of_keymap): Defsubr make-composed-keymap.
4205 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4206 (parse_menu_item): Trivial simplification.
4207
3279eb87
GM
42082011-07-01 Glenn Morris <rgm@gnu.org>
4209
4210 * Makefile.in (SETTINGS_LIBS): Fix typo.
4211
4550efdf
KI
42122011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4213
4214 * coding.c (Fencode_coding_string): Record the last coding system
4215 used, as the function doc string says (bug#8738).
4216
0949d2b6
JD
42172011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4218
4219 * xsettings.c (store_monospaced_changed): Take new font as arg and
4220 check for change against current_mono_font.
4221 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4222 (emacs_settings_constructor, emacs_settings_get_property)
4223 (emacs_settings_set_property, emacs_settings_class_init)
4224 (emacs_settings_init, gsettings_obj): Remove.
4225 (something_changedCB): New function for HAVE_GSETTINGS.
4226 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4227 with value as argument.
4228 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4229 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4230 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4231 "changed".
4232
4233 * xgselect.c: Add defined (HAVE_GSETTINGS).
4234 (xgselect_initialize): Ditto.
4235
4236 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4237 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4238 xg_select.
4239
bbc6b304
PE
42402011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4241
4242 * eval.c (struct backtrace): Simplify and port the data structure.
4243 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4244 signed bit field, as this assumption is not portable and it makes
4245 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4246 "char debug_on_exit : 1" as this is not portable either; instead,
4247 use the portable "unsigned int debug_on_exit : 1". Remove unused
4248 member evalargs. Remove obsolete comments about cc bombing out.
4249
9851bfc5
JD
42502011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4251
51bb811f 4252 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4253 Let HAVE_GSETTINGS override HAVE_GCONF.
4254 (store_monospaced_changed): New function.
4255 (EMACS_SETTINGS): A new type derived from GObject to handle
4256 GSettings notifications.
4257 (emacs_settings_constructor, emacs_settings_get_property)
4258 (emacs_settings_set_property, emacs_settings_class_init):
4259 New functions.
4260 (gsettings_client, gsettings_obj): New variables.
4261 (GSETTINGS_SCHEMA): New define.
4262 (something_changedCB): Call store_monospaced_changed.
4263 (init_gsettings): New function.
4264 (xsettings_initialize): Call init_gsettings.
4265 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4266 to NULL.
4267
640c8776 4268 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4269 GCONF_CFLAGS/LIBS.
4270
5386012d
MR
42712011-06-29 Martin Rudalics <rudalics@gmx.at>
4272
4273 * window.c (resize_root_window, grow_mini_window)
4274 (shrink_mini_window): Rename Qresize_root_window to
4275 Qwindow_resize_root_window and Qresize_root_window_vertically to
4276 Qwindow_resize_root_window_vertically.
4277
f13e0b08
PE
42782011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4279
4280 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4281
94515237
JB
42822011-06-27 Juanma Barranquero <lekktu@gmail.com>
4283
4284 * makefile.w32-in: Redesign dependencies so they reflect more
4285 clearly which files are directly included by each source file,
4286 and not through other includes.
4287
e43b6e43
MR
42882011-06-27 Martin Rudalics <rudalics@gmx.at>
4289
4290 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4291 (sort_overlays, overlay_strings): When an overlay's clone number
4292 matches the window's clone number process the overlay even if
4293 the overlay's window property doesn't match the current window.
4294
d68443dc
MR
4295 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4296 (Fwindow_hchild): Rename to Fwindow_left_child.
4297 (Fwindow_next): Rename to Fwindow_next_sibling.
4298 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4299 (resize_window_check): Rename to window_resize_check.
4300 (resize_window_apply): Rename to window_resize_apply.
4301 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4302 (Fdelete_other_windows_internal, resize_frame_windows)
4303 (Fsplit_window_internal, Fdelete_window_internal)
4304 (grow_mini_window, shrink_mini_window)
4305 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4306
c7e73be5
JD
43072011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4308
4309 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4310 (emacs_fixed_set_min_size): Remove.
4311 (emacs_fixed_new): Take frame as argument.
4312
4313 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4314 (_EmacsFixedPrivate): Remove minwidth/height.
4315 Add struct frame *f.
4316 (emacs_fixed_init): Initialize priv->f.
4317 (get_parent_class, emacs_fixed_set_min_size): Remove.
4318 (emacs_fixed_new): Set priv->f to argument.
4319 (emacs_fixed_get_preferred_width)
4320 (emacs_fixed_get_preferred_height): Use min_width/height from
4321 frames size_hint to set minimum and natural (Bug#8919).
4322 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4323 and use min_width/height from frames size_hint to set
4324 min_width/height (Bug#8919).
4325
4326 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4327 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4328 Fix indentation.
c7e73be5 4329
cf99dcf8
EZ
43302011-06-26 Eli Zaretskii <eliz@gnu.org>
4331
4332 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4333 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4334 called at ZV.
4335
029529ac
CY
43362011-06-26 Chong Yidong <cyd@stupidchicken.com>
4337
4338 * process.c (wait_reading_process_output): Bypass select if
4339 waiting for a cell while ignoring keyboard input, and input is
4340 pending. Suggested by Jan Djärv (Bug#8869).
4341
7a7ef429
PE
43422011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4343
4344 Use gnulib's dup2 module instead of rolling our own.
4345 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4346
11fdef7d 43472011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4348
4349 * dispnew.c (scrolling_window): Before scrolling, turn off a
4350 mouse-highlight in the window being scrolled.
4351
cd3520a4
JB
43522011-06-24 Juanma Barranquero <lekktu@gmail.com>
4353
4354 Move DEFSYM to lisp.h and use everywhere.
4355
4356 * character.h (DEFSYM): Move declaration...
4357 * lisp.h (DEFSYM): ...here.
4358
4359 * gnutls.c:
4360 * minibuf.c:
4361 * w32menu.c:
4362 * w32proc.c:
4363 * w32select.c: Don't include character.h.
4364
4365 * alloc.c (syms_of_alloc):
4366 * buffer.c (syms_of_buffer):
4367 * bytecode.c (syms_of_bytecode):
4368 * callint.c (syms_of_callint):
4369 * casefiddle.c (syms_of_casefiddle):
4370 * casetab.c (init_casetab_once):
4371 * category.c (init_category_once, syms_of_category):
4372 * ccl.c (syms_of_ccl):
4373 * cmds.c (syms_of_cmds):
4374 * composite.c (syms_of_composite):
4375 * dbusbind.c (syms_of_dbusbind):
4376 * dired.c (syms_of_dired):
4377 * dispnew.c (syms_of_display):
4378 * doc.c (syms_of_doc):
4379 * editfns.c (syms_of_editfns):
4380 * emacs.c (syms_of_emacs):
4381 * eval.c (syms_of_eval):
4382 * fileio.c (syms_of_fileio):
4383 * fns.c (syms_of_fns):
4384 * frame.c (syms_of_frame):
4385 * fringe.c (syms_of_fringe):
4386 * insdel.c (syms_of_insdel):
4387 * keymap.c (syms_of_keymap):
4388 * lread.c (init_obarray, syms_of_lread):
4389 * macros.c (syms_of_macros):
4390 * msdos.c (syms_of_msdos):
4391 * print.c (syms_of_print):
4392 * process.c (syms_of_process):
4393 * search.c (syms_of_search):
4394 * sound.c (syms_of_sound):
4395 * syntax.c (init_syntax_once, syms_of_syntax):
4396 * terminal.c (syms_of_terminal):
4397 * textprop.c (syms_of_textprop):
4398 * undo.c (syms_of_undo):
4399 * w32.c (globals_of_w32):
4400 * window.c (syms_of_window):
4401 * xdisp.c (syms_of_xdisp):
4402 * xfaces.c (syms_of_xfaces):
4403 * xfns.c (syms_of_xfns):
4404 * xmenu.c (syms_of_xmenu):
4405 * xsettings.c (syms_of_xsettings):
4406 * xterm.c (syms_of_xterm): Use DEFSYM.
4407
4228cf16
TZ
44082011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4409
cd3520a4 4410 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4411
7fcccf1e
PE
44122011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4413
7efb4e0e
PE
4414 Integer and buffer overflow fixes (Bug#8873).
4415
ff5844ad
PE
4416 * print.c (printchar, strout): Check for string overflow.
4417 (PRINTPREPARE, printchar, strout):
4418 Don't set size unless allocation succeeds.
4419
90532f02
PE
4420 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4421 for sizes. Check for string overflow more accurately.
4422 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4423
6d84508d
PE
4424 * macros.c: Integer and buffer overflow fixes.
4425 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4426 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4427 Use ptrdiff_t, not int, for sizes.
4428 Don't increment bufsize until after realloc succeeds.
4429 Check for size-calculation overflow.
4430 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4431
437b2cb4
PE
4432 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4433
8b9ac8b4
PE
4434 * lread.c: Integer overflow fixes.
4435 (read_integer): Radix is now EMACS_INT, not int,
4436 to improve quality of diagnostics for out-of-range radices.
4437 Calculate buffer size correctly for out-of-range radices.
4438 (read1): Check for integer overflow in radices, and in
4439 read-circle numbers.
82cb60d3
PE
4440 (read_escape): Avoid int overflow.
4441 (Fload, openp, read_buffer_size, read1)
4442 (substitute_object_recurse, read_vector, read_list, map_obarray):
4443 Use ptrdiff_t, not int, for sizes.
4444 (read1): Use EMACS_INT, not int, for sizes.
20270765 4445 Check for size overflow.
8b9ac8b4 4446
7fcccf1e
PE
4447 * image.c (cache_image): Check for size arithmetic overflow.
4448
bfbbd7e7
PE
4449 * lread.c: Integer overflow issues.
4450 (saved_doc_string_size, saved_doc_string_length)
4451 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4452 Now ptrdiff_t, not int.
4453 (read1): Don't assume doc string length fits in int. Check for
4454 out-of-range doc string lengths.
4455 (read_list): Don't assume file position fits in int.
39019e54 4456 (read_escape): Check for hex character overflow.
bfbbd7e7 4457
4e323265
LL
44582011-06-22 Leo Liu <sdl.web@gmail.com>
4459
4460 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4461 Move to minibuffer.el.
4462
85fece3e
PE
44632011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4464
20b84ce9 4465 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4466 The following patches are for when GLYPH_DEBUG && !XASSERT.
4467 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4468 * dispnew.c (flush_stdout):
4469 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4470 Mark as externally visible.
4471 * dispnew.c (check_window_matrix_pointers): Now static.
4472 * dispnew.c (window_to_frame_vpos):
4473 * xfns.c (unwind_create_frame):
4474 * xterm.c (x_check_font): Remove unused local.
4475 * scroll.c (CHECK_BOUNDS):
4476 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4477 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4478 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4479 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4480 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4481 Now static.
4482 (debug_method_add): Use va_list and vsprintf rather than relying
4483 on undefined behavior with wrong number of arguments.
4484 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4485 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4486 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4487 since we're not interested in debugging glyphs with old libraries.
4488 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4489 GCC 4.6.0's static checking.
4490
0766b489
PE
44912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4492
31fd4b32
PE
4493 Integer overflow and signedness fixes (Bug#8873).
4494 A few related buffer overrun fixes, too.
4495
b79e8648
PE
4496 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4497
0766b489
PE
4498 * dispextern.h (struct face.stipple):
4499 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4500 (x_bitmap_mask, x_allocate_bitmap_record)
4501 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4502 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4503 (x_create_bitmap_from_xpm_data):
4504 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4505 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4506 (.bitmaps_last):
4507 * xfaces.c (load_pixmap):
4508 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4509 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4510 (.bitmaps_last, struct x_output.icon_bitmap):
4511 Use ptrdiff_t, not int, for bitmap indexes.
4512 (x_allocate_bitmap_record): Check for size overflow.
4513 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4514
b081724f
PE
4515 Use ptrdiff_t, not int, for overlay counts.
4516 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4517 * editfns.c (overlays_around, get_pos_property):
4518 * textprop.c (get_char_property_and_overlay):
4519 * xdisp.c (next_overlay_change, note_mouse_highlight):
4520 * xfaces.c (face_at_buffer_position):
21514da7
PE
4521 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4522 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4523 (Fnext_overlay_change, Fprevious_overlay_change)
4524 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4525 Use ptrdiff_t, not int, for sizes.
21514da7 4526 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4527
3de73e5e
PE
4528 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4529
2606c57b
PE
4530 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4531 (x_session_initialize): Do not assume string length fits in int.
4532
aaafe47a
PE
4533 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4534 This is unlikely, but can occur if DPI is outlandish.
4535
2674ddc8 4536 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4537 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4538
28154962
PE
4539 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4540 * xrdb.c (magic_file_p, search_magic_path):
4541 Omit last arg SUFFIX; it was always 0. All callers changed.
4542 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4543
7de51af5
PE
4544 * xfont.c (xfont_match): Avoid need for strlen.
4545
25ed6cc3
PE
4546 * xfns.c: Don't assume strlen fits in int.
4547 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4548
4eab31dd
PE
4549 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4550 not unsigned long, as we prefer signed integers. All callers changed.
4551 Detect integer overflow in repeat count.
4552 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4553 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4554
171e2a58
PE
4555 * termcap.c: Don't assume sizes fit in int and never overflow.
4556 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4557 (gobble_line): Check for size-calculation overflow.
4558
ad39faca 4559 * minibuf.c (Fread_buffer):
6e5bb2dc 4560 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4561 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4562 Don't assume string length fits in int.
4563
52c61c22 4564 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4565 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4566
b5b8c9e5
PE
4567 * font.c: Don't assume string length fits in int.
4568 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4569 Use ptrdiff_t, not int.
ccd6111c
PE
4570 (font_intern_prop): Don't assume string length fits in int.
4571 Don't assume integer property fits in fixnum.
4572 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4573
882f0d81 4574 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4575 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4576 Reformulate so as not to need the command string.
4577 Invoke gzip -cd rather than gunzip, as it's more portable.
4578 (lock_info_type, lock_file_1, lock_file):
4579 Don't assume pid_t and time_t fit in unsigned long.
4580 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4581 (current_lock_owner): Prefer signed type for sizes.
4582 Use memcpy, not strncpy, where memcpy is what is really wanted.
4583 Don't assume (via atoi) that time_t and pid_t fit in int.
4584 Check for time_t and/or pid_t out of range, e.g., via a network share.
4585 Don't alloca where an auto var works fine.
4586
93f4cf88
PE
4587 * fileio.c: Fix some integer overflow issues.
4588 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4589 Don't assume string length fits in int.
4590 (directory_file_name): Don't assume string length fits in long.
4591 (make_temp_name): Don't assume pid fits in int, or that its print
4592 length is less than 20.
4593
f3e92b69
PE
4594 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4595
1bfdaf10
PE
4596 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4597
35016e9a
PE
4598 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4599
3d1e65a1
PE
4600 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4601 We prefer signed integers, even for size calculations.
4602
0b963a93
PE
4603 * emacs.c: Don't assume string length fits in 'int'.
4604 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4605 (main): Don't invoke strlen when not needed.
4606
573f4b54
PE
4607 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4608 (XD_DEBUG_MESSAGE): Don't waste a byte.
4609
989f33ba
PE
4610 * callproc.c (getenv_internal_1, getenv_internal)
4611 (Fgetenv_internal):
965d34eb
PE
4612 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4613
e4d29b33
PE
4614 * lread.c (invalid_syntax): Omit length argument.
4615 All uses changed. This doesn't fix a bug, but it simplifies the
4616 code away from its former Hollerith-constant appearance, and it's
4617 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4618 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4619
eb49b136
PE
4620 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4621 This didn't break anything, but it didn't help either.
4622 It's confusing to put a bogus integer in a place where the actual
4623 value does not matter.
9f62aeb1 4624 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4625 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4626
15375a22
PE
4627 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4628 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4629 implementation.
b61cc01c
PE
4630 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4631 We prefer signed types, and the value cannot exceed the EMACS_INT
4632 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4633 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4634 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4635 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4636
53b2623d
PE
4637 * indent.c (sane_tab_width): New function.
4638 (current_column, scan_for_column, Findent_to, position_indentation)
4639 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4640 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4641
51cab52b 4642 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4643
f2ed8a70
PE
4644 * lisp.h (lint_assume): New macro.
4645 * composite.c (composition_gstring_put_cache):
4646 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4647
abe80cc6
PE
4648 * editfns.c, insdel.c:
4649 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4650
b02c740e
PE
4651 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4652
ebc96716
PE
4653 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4654
b4e50fa0 4655 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4656 Use much-faster test for byte-length change.
311d5d7c 4657 Don't assume string byte-length fits in 'int'.
a4cf38e4 4658 Check that character arg fits in 'int'.
85461888 4659 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4660
c0c1ee9f
PE
4661 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4662
a498d7f4
PE
4663 * fns.c (concat): Catch string overflow earlier.
4664 Do not rely on integer wraparound.
4665
51cab52b
PE
4666 * dispextern.h (struct it.overlay_strings_charpos)
4667 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4668 * xdisp.c (forward_to_next_line_start)
4669 (back_to_previous_visible_line_start)
4670 (reseat_at_next_visible_line_start, next_element_from_buffer):
4671 Don't arbitrarily truncate the value of 'selective' to int.
4672
76031fad
PE
4673 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4674
5eb55db9
PE
4675 * composite.c: Don't truncate sizes to 'int'.
4676 (composition_gstring_p, composition_reseat_it)
4677 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4678 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4679 not EMACS_UINT, for indexes.
5eb55db9 4680
0703a717
PE
4681 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4682
d6202519
PE
4683 * buffer.c: Include <verify.h>.
4684 (struct sortvec.priority, struct sortstr.priority):
8961a454 4685 Now EMACS_INT, not int.
c20998a7 4686 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4687 (struct sortstr.size, record_overlay_string)
4688 (struct sortstrlist.size, struct sortlist.used):
4689 Don't truncate size to int.
4690 (record_overlay_string): Check for size-calculation overflow.
d6202519 4691 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4692
d5a19415
JM
46932011-06-22 Jim Meyering <meyering@redhat.com>
4694
029529ac 4695 Don't leak an XBM-image-sized buffer
d5a19415
JM
4696 * image.c (xbm_load): Free the image buffer after using it.
4697
a9041e6c
PE
46982011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4699
4700 Port to Sun C.
4701 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4702 that Sun C diagnosed.
4703 * fns.c (secure_hash): Fix pointer signedness issue.
4704 * intervals.c (static_offset_intervals): New function.
4705 (offset_intervals): Use it.
4706
7f3f739f
LL
47072011-06-21 Leo Liu <sdl.web@gmail.com>
4708
4709 * deps.mk (fns.o):
4710 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4711 sha512.h.
4712
4713 * fns.c (secure_hash): Rename from crypto_hash_function and change
4714 the first arg to accept symbols.
5b66d427 4715 (Fsecure_hash): New primitive.
7f3f739f
LL
4716 (syms_of_fns): New symbols.
4717
76147d94
DD
47182011-06-20 Deniz Dogan <deniz@dogan.se>
4719
4720 * process.c (Fset_process_buffer): Clarify return value in
4721 docstring.
4722
7d7d0045
CY
47232011-06-18 Chong Yidong <cyd@stupidchicken.com>
4724
4725 * dispnew.c (add_window_display_history): Use BVAR.
4726
4727 * xdisp.c (debug_method_add): Use BVAR.
4728 (check_window_end, dump_glyph_matrix, dump_glyph)
4729 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4730
4731 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4732 Likewise.
4733
4734 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4735 check till after the cache is created in init_frame_faces.
4736
ff2bc410
SM
47372011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4738
4739 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4740
28177add
PE
47412011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4742
dd3482fe
PE
4743 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4744 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4745 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4746
393d71f3 4747 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4748 * fileio.c (Finsert_file_contents):
4749 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4750 Remove the old (too-loose) buffer overflow checks.
4751 They weren't needed, since make_gap checks for buffer overflow.
4752 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4753 The old code merely checked for Emacs fixnum overflow, and relied
4754 on undefined (wraparound) behavior. The new code avoids undefined
4755 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4756
2e6813b0 4757 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4758 Tune. Don't use wider integers than needed. Don't use alloca.
4759 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4760
599a9e4f
PE
4761 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4762
99561444
PE
4763 * insdel.c, lisp.h (buffer_overflow): New function.
4764 (insert_from_buffer_1, replace_range, replace_range_2):
4765 * insdel.c (make_gap_larger):
4766 * editfns.c (Finsert_char):
4767 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4768
28177add
PE
4769 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4770
e69dafad
PE
47712011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4772
4baa020d 4773 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4774
b1c46f02
PE
4775 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4776 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4777
e69dafad
PE
4778 * fileio.c: Don't assume EMACS_INT fits in off_t.
4779 (emacs_lseek): New static function.
4780 (Finsert_file_contents, Fwrite_region): Use it.
4781 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4782
566684ea
PE
4783 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4784
e6966cd6
PE
4785 * fns.c: Don't overflow int when computing a list length.
4786 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4787 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4788 truncation on 64-bit hosts. Check for QUIT every
4789 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4790 faster and is responsive enough.
4791 (Flength): Report an error instead of overflowing an integer.
4792 (Fsafe_length): Return a float if the value is not representable
4793 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4794 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4795 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4796
dd0b0efb
PE
4797 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4798 (header_size, word_size): New constants.
4799 (allocate_vectorlike): Don't check size overflow here.
4800 (allocate_vector): Check it here instead, since this is the only
4801 caller of allocate_vectorlike that could cause overflow.
4802 Check that the new vector's length is representable as a fixnum.
4803
86fe5cfe
PE
4804 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4805 The previous code was bogus. For example, next_almost_prime (32)
4806 returned 39, which is undesirable as it is a multiple of 3; and
4807 next_almost_prime (24) returned 25, which is a multiple of 5 so
4808 why was the code bothering to check for multiples of 7?
4809
80e88859
PE
4810 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4811
4a2f0ad6
PE
4812 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4813
f66c7cf8
PE
4814 Variadic C functions now count arguments with ptrdiff_t.
4815 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4816 Back then I didn't know that the Emacs coding style prefers signed int.
4817 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4818 were being counted with int, which may truncate counts on 64-bit
4819 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4820 * lisp.h (struct Lisp_Subr.function.aMANY)
4821 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4822 Arg counts are now ptrdiff_t, not size_t.
4823 All variadic functions and their callers changed accordingly.
4824 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4825 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4826 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4827 * callint.c (Fcall_interactively): Check arg count for overflow,
4828 to avoid potential buffer overrun. Use signed char, not 'int',
4829 for 'varies' array, so that we needn't bother to check its size
4830 calculation for overflow.
4831 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4832 * eval.c (apply_lambda):
4833 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4834 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4835 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4836
a1759b76
PE
4837 * callint.c (Fcall_interactively): Don't use index var as event count.
4838
d96be9fc
PE
4839 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4840 * mem-limits.h (SIZE): Remove; no longer used.
4841
a690a978 4842 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4843
578c21e6
PE
4844 Remove unnecessary casts.
4845 * xterm.c (x_term_init):
4846 * xfns.c (x_set_border_pixel):
4847 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4848 These aren't needed now that we assume ANSI C.
4849
96f53c6c
PE
4850 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4851 It's more likely to cause problems (due to unsigned overflow)
4852 than to cure them.
4853
83c77d31
PE
4854 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4855
ee2079f1
PE
4856 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4857
6da65536
PE
4858 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4859
7147c4a4
PE
4860 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4861
193e32d9
PE
4862 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4863
e5533da6
PE
4864 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4865
9910e595
PE
4866 GLYPH_CODE_FACE returns EMACS_INT, not int.
4867 * dispextern.h (merge_faces):
4868 * xfaces.c (merge_faces):
01103c44
PE
4869 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4870 Don't assume EMACS_INT fits in int.
9910e595 4871
2638320e
PE
4872 * character.h (CHAR_VALID_P): Remove unused parameter.
4873 * fontset.c, lisp.h, xdisp.c: All uses changed.
4874
045eb8d9
PE
4875 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4876
c1f134b5
PE
4877 * fns.c (concat): Minor tuning based on overflow analysis.
4878 This doesn't fix any bugs. Use int to hold character, instead
4879 of constantly refetching from Emacs object. Use XFASTINT, not
4880 XINT, for value known to be a character. Don't bother comparing
4881 a single byte to 0400, as it's always less.
4882
395fcb93 4883 * floatfns.c (Fexpt):
327eeec8
PE
4884 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4885
abbd3d23
PE
4886 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4887 for characters.
4888
684a03ef
PE
4889 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4890
0fed43f3
PE
4891 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4892 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4893 incorrectly succeed when S was a string, because 4294967386 was
4894 truncated before it was used.
4895
8fd02eb7
PE
4896 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4897 Otherwise, an out-of-range integer could cause undefined behavior
4898 on a 64-bit host.
4899
f8c86b69
PE
4900 * composite.c: Use int, not EMACS_INT, for characters.
4901 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4902 EMACS_INT, for values that are known to be in character range.
4903 This doesn't fix any bugs but is the usual style inside Emacs and
4904 may generate better code on 32-bit machines.
4905
34206dd2
PE
4906 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4907 This is for reasons similar to the recent CHAR_STRING fix.
4908 * charset.c (Fencode_char): Check that character arg is actually
4909 a character. Pass an int to ENCODE_CHAR.
4910 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4911 wider than 'int', as a compile-time check to prevent future regressions
4912 in this area.
4913
c5958d4c 4914 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4915
4916 Make sure a 64-bit char is never passed to CHAR_STRING.
4917 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4918 by silently ignoring the top 32 bits, allowing some values
4919 that were far too large to be valid characters.
4920 * character.h: Include <verify.h>.
4921 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4922 arguments are no wider than unsigned, as a compile-time check
4923 to prevent future regressions in this area.
4924 * data.c (Faset):
01103c44 4925 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4926 (Fsubst_char_in_region):
4927 * fns.c (concat):
4928 * xdisp.c (decode_mode_spec_coding):
4929 Adjust to CHAR_STRING's new requirement.
4930 * editfns.c (Finsert_char, Fsubst_char_in_region):
4931 * fns.c (concat): Check that character args are actually
4932 characters. Without this test, these functions did the wrong
4933 thing with wildly out-of-range values on 64-bit hosts.
4934
d37ca623
PE
4935 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4936 These casts should not be needed on 32-bit hosts, either.
4937 * keyboard.c (read_char):
4938 * lread.c (Fload): Remove casts to unsigned.
4939
ea204efb
PE
4940 * lisp.h (UNSIGNED_CMP): New macro.
4941 This fixes comparison bugs on 64-bit hosts.
4942 (ASCII_CHAR_P): Use it.
4943 * casefiddle.c (casify_object):
01103c44 4944 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4945 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4946 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4947 * dispextern.h (FACE_FROM_ID):
4948 * keyboard.c (read_char): Use UNSIGNED_CMP.
4949
41cb286c
PE
4950 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4951 not to EMACS_INT, to avoid GCC warning.
4952
4a1b9832
PE
4953 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4954
55daad71
PE
4955 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4956 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4957 isn't needed on 32-bit machines.
8f95c75c 4958
01103c44
PE
4959 * buffer.c (Fgenerate_new_buffer_name):
4960 Use EMACS_INT for count, not int.
0ceccced 4961 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4962
4963 * data.c (Qcompiled_function): Now static.
4964
c6f072e7
PE
4965 * window.c (window_body_lines): Now static.
4966
20ce5912
PE
4967 * image.c (gif_load): Rename local to avoid shadowing.
4968
9c4c5f81
PE
4969 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4970 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4971 * alloc.c (make_save_value): Integer argument is now of type
4972 ptrdiff_t, not int.
4973 (mark_object): Use ptrdiff_t, not int.
4974 * lisp.h (pD): New macro.
4975 * print.c (print_object): Use it.
4976
c0c5c8ae
PE
4977 * alloc.c: Use EMACS_INT, not int, to count objects.
4978 (total_conses, total_markers, total_symbols, total_vector_size)
4979 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4980 (total_free_floats, total_floats, total_free_intervals)
4981 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4982 Now EMACS_INT, not int. All uses changed.
4983 (Fgarbage_collect): Compute overall total using a double, so that
4984 integer overflow is less likely to be a problem. Check for overflow
4985 when converting back to an integer.
5a25e253
PE
4986 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4987 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4988 These were 'int' variables that could overflow on 64-bit hosts;
4989 they were never used, so remove them instead of repairing them.
211a0b2a 4990 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4991 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4992 Previously, this ceilinged at INT_MAX, but that doesn't work on
4993 64-bit machines.
e46bb31a 4994 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4995
c78baabf 4996 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4997 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4998 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4999 when a (possibly-narrower) signed value would do just as well.
5000 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5001
c9d624c6
PE
5002 * alloc.c: Catch some string size overflows that we were missing.
5003 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5004 for convenience in STRING_BYTES_MAX.
5005 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5006 The definition here is exact; the one in lisp.h was approximate.
5007 (allocate_string_data): Check for string overflow. This catches
5008 some instances we weren't catching before. Also, it catches
5009 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5010 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5011 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5012
c9d624c6
PE
5013 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5014 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5015 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5016
353032ce
PE
5017 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5018
2bccce07
PE
5019 * alloc.c (Fmake_string): Check for out-of-range init.
5020
0ac30604
SM
50212011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5022
5023 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5024
c195f2de
JD
50252011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5026
5027 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5028 xg_get_default_scrollbar_width.
5029
5030 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5031 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5032 (style_changed_cb): Call update_theme_scrollbar_width and call
5033 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5034 all frames (Bug#8505).
5035 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5036 Call gtk_window_set_resizable if HAVE_GTK3.
5037 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5038 and height if HAVE_GTK3 (Bug#8505).
5039 (scroll_bar_width_for_theme): New variable.
5040 (update_theme_scrollbar_width): New function.
5041 (xg_get_default_scrollbar_width): Move code to
5042 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5043 (xg_initialize): Call update_theme_scrollbar_width.
5044
5045 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5046
5047 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5048
e10ac9f1
MR
50492011-06-12 Martin Rudalics <rudalics@gmx.at>
5050
5051 * frame.c (make_frame): Call other_buffer_safely instead of
5052 other_buffer.
5053
5054 * window.c (temp_output_buffer_show): Call display_buffer with
5055 second argument Vtemp_buffer_show_specifiers and reset latter
5056 immediately after the call.
5057 (Vtemp_buffer_show_specifiers): New variable.
5058 (auto_window_vscroll_p, next_screen_context_lines)
5059 (Vscroll_preserve_screen_position): Remove leading asterisks from
5060 doc-strings.
5061
2d3c217e 50622011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5063
7b7f97e8 5064 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5065 * buffer.c (Qclone_number): Remove for now, as it's unused.
5066 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5067 (record_buffer): Remove unused local.
5068 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5069 (set_frame_buffer_list): Remove; unused.
5070 * frame.h (other_visible_frames): Remove decl.
5071 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5072 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5073 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5074 if HAVE_GPM.
5075 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5076 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5077 Define only if HAVE_GPM.
5078 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5079 (update_hints_inhibit): Remove; never set. All uses removed.
5080 * widgetprv.h (emacsFrameClassRec): Remove decl.
5081 * window.c (delete_deletable_window): Now returns void, since it
5082 wasn't returning anything.
5083 (compare_window_configurations): Remove unused locals.
5084 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5085 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5086 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5087 the same widths as pointers. This follows up on the 2011-05-06 patch.
5088 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5089 * xterm.h: Likewise.
5090 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5091
1384b89e
JB
50922011-06-12 Juanma Barranquero <lekktu@gmail.com>
5093
5094 * makefile.w32-in: Update dependencies.
5095 (LISP_H): Add lib/intprops.h.
5096
1100a63c
CY
50972011-06-11 Chong Yidong <cyd@stupidchicken.com>
5098
5099 * image.c (gif_load): Add animation frame delay to the metadata.
5100 (syms_of_image): Use DEFSYM. New symbol `delay'.
5101
6198ccd0
MR
51022011-06-11 Martin Rudalics <rudalics@gmx.at>
5103
5104 * window.c (delete_deletable_window): Re-add.
5105 (Fset_window_configuration): Rewrite to handle dead buffers and
5106 consequently deletable windows.
5107 (window_tree, Fwindow_tree): Remove. Supply functionality in
5108 window.el.
5109 (compare_window_configurations): Simplify code.
5110
b6e3633c
AS
51112011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5112
1ab0dee5
AS
5113 * image.c (imagemagick_load_image): Fix type mismatch.
5114 (Fimagemagick_types): Likewise.
5115
b6e3633c
AS
5116 * window.h (replace_buffer_in_windows): Declare.
5117
9397e56f
MR
51182011-06-11 Martin Rudalics <rudalics@gmx.at>
5119
5120 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5121 Qclone_number. Remove external declaration of Qdelete_window.
5122 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5123 code.
640c8776
SM
5124 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5125 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5126 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5127 buffer list implementation.
5128 (other_buffer_safely): New function.
5129 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5130 calls to replace_buffer_in_windows and
5131 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5132 if allowed.
5133 (record_buffer): Inhibit quitting and rewrite using quittable
5134 functions. Run Qbuffer_list_update_hook if allowed.
5135 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5136 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5137 Move switch-to-buffer to window.el.
9397e56f
MR
5138 (bury-buffer): Move to window.el.
5139 (Vbuffer_list_update_hook): New variable.
5140
5141 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5142 section.
5143
5144 * window.h (resize_frame_windows): Move up in code.
5145 (Fwindow_frame): Remove EXFUN.
5146 (replace_buffer_in_all_windows): Remove prototype.
5147 (replace_buffer_in_windows_safely): Add prototype.
5148
5149 * window.c: Declare Qdelete_window static again. Move down
5150 declaration of select_count.
5151 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5152 (Fother_window): Move to window.el.
5153 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5154 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5155 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5156 window.el.
5157 (replace_buffer_in_windows): Implement by calling
5158 Qreplace_buffer_in_windows.
5159 (replace_buffer_in_all_windows): Remove with some functionality
5160 moved into replace_buffer_in_windows_safely.
5161 (replace_buffer_in_windows_safely): New function.
5162 (select_window_norecord, select_frame_norecord): Move in front
5163 of run_window_configuration_change_hook. Remove now obsolete
5164 declarations.
640c8776
SM
5165 (Fset_window_buffer): Rewrite doc-string.
5166 Call Qrecord_window_buffer.
9397e56f
MR
5167 (keys_of_window): Move binding for other-window to window.el.
5168
b50691aa
CY
51692011-06-11 Chong Yidong <cyd@stupidchicken.com>
5170
5171 * dispextern.h (struct image): Replace data member, whose int_val
5172 and ptr_val fields were not used by anything, with a single
5173 lisp_val object.
5174
5175 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5176 (gif_clear_image, gif_load, imagemagick_load_image)
5177 (gs_clear_image, gs_load): Callers changed.
5178
3f754b86
PE
51792011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5180
cca69397
PE
5181 * buffer.h: Include <time.h>, for time_t.
5182 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5183
109e28d0
PE
5184 Fix minor problems found by static checking.
5185
60737f02
PE
5186 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5187
4b66faf3
PE
5188 Make identifiers static if they are not used in other modules.
5189 * data.c (Qcompiled_function, Qframe, Qvector):
5190 * image.c (QimageMagick, Qsvg):
5191 * minibuf.c (Qmetadata):
5192 * window.c (resize_window_check, resize_root_window): Now static.
5193 * window.h (resize_window_check, resize_root_window): Remove decls.
5194
109e28d0
PE
5195 * window.c (window_deletion_count, delete_deletable_window):
5196 Remove; unused.
46a4ce9e
PE
5197 (window_body_lines): Now static.
5198 (Fdelete_other_windows_internal): Mark vars as initialized.
5199 Make sure 'resize_failed' is initialized.
5200 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5201 (resize_window_apply): Remove unused local.
5202 * window.h (delete_deletable_window): Remove decl.
5203
109e28d0 5204 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5205 (imagemagick_load_image): Fix pointer signedness problem by changing
5206 last arg from unsigned char * to char *. All uses changed.
5207 Also, fix a local for similar reasons.
5208 Remove unused locals. Remove locals to avoid shadowing.
5209 (fn_rsvg_handle_free): Remove; unused.
5210 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5211 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5212
3f754b86
PE
5213 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5214
2547adb1
CY
52152011-06-10 Chong Yidong <cyd@stupidchicken.com>
5216
5217 * image.c (gif_load): Fix omitted cast error introduced by
5218 2011-06-06 change.
5219
2c8e37d4
MR
52202011-06-10 Martin Rudalics <rudalics@gmx.at>
5221
5222 * window.h (resize_proportionally, orig_total_lines)
5223 (orig_top_line): Remove from window structure.
5224 (set_window_height, set_window_width, change_window_heights)
5225 (Fdelete_window): Remove prototypes.
5226 (resize_frame_windows): Remove duplicate declaration.
5227
440a42e3
EZ
52282011-06-10 Eli Zaretskii <eliz@gnu.org>
5229
5230 * window.h (resize_frame_windows, resize_window_check)
5231 (delete_deletable_window, resize_root_window)
5232 (resize_frame_windows): Declare prototypes.
5233
5234 * window.c (resize_window_apply): Make definition be "static" to
5235 match the prototype.
5236
562dd5e9
MR
52372011-06-10 Martin Rudalics <rudalics@gmx.at>
5238
5239 * window.c: Remove declarations of Qwindow_size_fixed,
5240 window_min_size_1, window_min_size_2, window_min_size,
5241 size_window, window_fixed_size_p, enlarge_window, delete_window.
5242 Remove static from declaration of Qdelete_window, it's
5243 temporarily needed by Fbury_buffer.
5244 (replace_window): Don't assign orig_top_line and
5245 orig_total_lines.
5246 (Fdelete_window, delete_window): Remove. Window deletion is
5247 handled by window.el.
640c8776
SM
5248 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5249 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5250 (Fdelete_other_windows): Remove. Deleting other windows is
5251 handled by window.el.
5252 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5253 handled in window.el.
5254 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5255 Window minimum sizes are handled in window.el.
5256 (shrink_windows, size_window, set_window_height)
5257 (set_window_width, change_window_heights, window_height)
5258 (window_width, CURBEG, CURSIZE, enlarge_window)
5259 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5260 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5261 handled in window.el.
5262 (make_dummy_parent): Rename to make_parent_window and give it a
5263 second argument horflag.
5264 (make_window): Don't set resize_proportionally any more.
5265 (Fsplit_window): Remove. Windows are split in window.el.
5266 (save_restore_action, save_restore_orig_size)
5267 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5268 Resize mini windows in window.el.
5269 (grow_mini_window, shrink_mini_window): Implement by calling
5270 Qresize_root_window_vertically, resize_window_check and
5271 resize_window_apply.
640c8776
SM
5272 (saved_window, Fset_window_configuration, save_window_save):
5273 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5274 resize_proportionally.
5275 (window_min_height, window_min_width): Move to window.el.
5276 (keys_of_window): Move bindings for delete-other-windows,
5277 split-window, delete-window and enlarge-window to window.el.
5278
5279 * buffer.c: Temporarily extern Qdelete_window.
5280 (Fbury_buffer): Temporarily call Qdelete_window instead of
5281 Fdelete_window (Fbury_buffer will move to window.el soon).
5282
5283 * frame.c (set_menu_bar_lines_1): Remove code handling
5284 orig_top_line and orig_total_lines.
5285
5286 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5287 set_window_height but set heights directly.
5288 (change_frame_size_1): Use resize_frame_windows.
5289
5290 * xdisp.c (init_xdisp): Don't use set_window_height but set
5291 heights directly.
5292
640c8776
SM
5293 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5294 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5295 run_window_configuration_change_hook.
5296
5297 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5298 instead of change_window_heights and run
5299 run_window_configuration_change_hook.
5300
1a13852e
MR
53012011-06-09 Martin Rudalics <rudalics@gmx.at>
5302
5303 * window.c (replace_window): Rename second argument REPLACEMENT to
5304 NEW. New third argument SETFLAG. Rewrite.
5305 (delete_window, make_dummy_parent): Call replace_window with
5306 third argument 1.
5307 (window_list_1): Move down in code.
5308 (run_window_configuration_change_hook): Move set_buffer part
5309 before select_frame_norecord part in order to unwind correctly.
5310 Rename count1 to count.
5311 (recombine_windows, delete_deletable_window, resize_root_window)
5312 (Fdelete_other_windows_internal)
5313 (Frun_window_configuration_change_hook, make_parent_window)
5314 (resize_window_check, resize_window_apply, Fresize_window_apply)
5315 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5316 (Fdelete_window_internal, Fresize_mini_window_internal):
5317 New functions.
1a13852e
MR
5318 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5319
f3d1777e
MR
53202011-06-08 Martin Rudalics <rudalics@gmx.at>
5321
496e208e
MR
5322 * window.h (window): Add some new members to window structure -
5323 normal_lines, normal_cols, new_total, new_normal, clone_number,
5324 splits, nest, prev_buffers, next_buffers.
5325 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5326 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5327
f3d1777e
MR
5328 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5329 Remove.
496e208e
MR
5330 (make_dummy_parent): Set new members of windows structure.
5331 (make_window): Move down in code. Handle new members of window
5332 structure.
5333 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5334 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5335 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5336 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5337 (Fset_window_next_buffers, Fset_window_clone_number):
5338 New functions.
496e208e
MR
5339 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5340 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5341 Doc-string fixes.
5342 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5343 Argument WINDOW can be now internal window too.
5344 (Fwindow_use_time): Move up in code.
5345 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5346 Rewrite doc-string.
5347 (Fset_window_configuration, saved_window)
5348 (Fcurrent_window_configuration, save_window_save): Handle new
5349 members of window structure.
b9e809c2
MR
5350 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5351 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5352 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5353 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5354 Qget_mru_window, Qresize_root_window,
5355 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5356 Qauto_buffer_name; staticpro them.
f3d1777e 5357
abde8f8c
MR
53582011-06-07 Martin Rudalics <rudalics@gmx.at>
5359
5360 * window.c (Fwindow_total_size, Fwindow_left_column)
5361 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5362 (Fwindow_list_1): New functions.
5363 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5364 (Fwindow_width, Fscroll_left, Fscroll_right):
5365 Use window_body_cols instead of window_box_text_cols.
5366 (delete_window, Fset_window_configuration):
5367 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5368 (delete_all_subwindows): Take a window as argument and not a
5369 structure. Rewrite.
190b47e6
MR
5370 (window_loop): Remove handling of GET_LRU_WINDOW and
5371 GET_LARGEST_WINDOW.
5372 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5373
5374 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5375 window_box_text_cols. delete_all_subwindows now takes a
5376 Lisp_Object as argument.
abde8f8c 5377
640c8776
SM
5378 * indent.c (compute_motion, Fcompute_motion):
5379 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5380
fa8a67e6
MR
5381 * frame.c (delete_frame): Call delete_all_subwindows with root
5382 window as argument.
5383
a54e3482
DC
53842011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5385
5386 * fns.c (Fputhash): Document return value.
5387
60002bf5
CY
53882011-06-06 Chong Yidong <cyd@stupidchicken.com>
5389
5390 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5391
0c671da6 53922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5393
b862a52a 5394 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5395
be44ca6c
PE
5396 Check for overflow when converting integer to cons and back.
5397 * charset.c (Fdefine_charset_internal, Fdecode_char):
5398 Use cons_to_unsigned to catch overflow.
5399 (Fencode_char): Use INTEGER_TO_CONS.
5400 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5401 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5402 * data.c (long_to_cons, cons_to_long): Remove.
5403 (cons_to_unsigned, cons_to_signed): New functions.
5404 These signal an error for invalid or out-of-range values.
5405 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5406 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5407 * font.c (Ffont_variation_glyphs):
5408 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5409 * lisp.h: Include <intprops.h>.
5410 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5411 (cons_to_signed, cons_to_unsigned): New decls.
5412 (long_to_cons, cons_to_long): Remove decls.
5413 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5414 (Fprimitive_undo): Use CONS_TO_INTEGER.
5415 * xfns.c (Fx_window_property): Likewise.
5416 * xselect.c: Include <limits.h>.
5417 (x_own_selection, selection_data_to_lisp_data):
5418 Use INTEGER_TO_CONS.
5419 (x_handle_selection_request, x_handle_selection_clear)
5420 (x_get_foreign_selection, Fx_disown_selection_internal)
5421 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5422 (lisp_data_to_selection_data): Use cons_to_unsigned.
5423 (x_fill_property_data): Use cons_to_signed.
5424 Report values out of range.
5425
d1f3d2af
PE
5426 Check for buffer and string overflow more precisely.
5427 * buffer.h (BUF_BYTES_MAX): New macro.
5428 * lisp.h (STRING_BYTES_MAX): New macro.
5429 * alloc.c (Fmake_string):
5430 * character.c (string_escape_byte8):
5431 * coding.c (coding_alloc_by_realloc):
5432 * doprnt.c (doprnt):
5433 * editfns.c (Fformat):
5434 * eval.c (verror):
5435 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5436 since they may not be the same number.
5437 * editfns.c (Finsert_char):
5438 * fileio.c (Finsert_file_contents):
5439 Likewise for BUF_BYTES_MAX.
5440
dd52fcea
PE
5441 * image.c: Use ptrdiff_t, not int, for sizes.
5442 (slurp_file): Switch from int to ptrdiff_t.
5443 All uses changed.
5444 (slurp_file): Check that file size fits in both size_t (for
5445 malloc) and ptrdiff_t (for sanity and safety).
5446
7f9bbdbb
PE
5447 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5448 if b->modtime has its maximal value.
5449
dfe18f82
PE
5450 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5451
84acfcf0
PE
5452 Don't assume time_t can fit into int.
5453 * buffer.h (struct buffer.modtime): Now time_t, not int.
5454 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5455 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5456
ccd9a01a
PE
5457 Minor fixes for signed vs unsigned integers.
5458 * character.h (MAYBE_UNIFY_CHAR):
5459 * charset.c (maybe_unify_char):
5460 * keyboard.c (read_char, reorder_modifiers):
5461 XINT -> XFASTINT, since the integer must be nonnegative.
5462 * ftfont.c (ftfont_spec_pattern):
5463 * keymap.c (access_keymap, silly_event_symbol_error):
5464 XUINT -> XFASTINT, since the integer must be nonnegative.
5465 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5466 since it makes no difference and we prefer signed.
5467 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5468 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5469 nonnegative.
5470
d6d100dd
SM
54712011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5472
5473 * window.h (Fwindow_frame): Declare.
5474
2b6148e4
PE
54752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5476
5477 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5478 (SPARE_MEMORY): Always define.
5479 (LARGE_REQUEST): Remove.
5480 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5481
f230ecc9
MR
54822011-06-06 Martin Rudalics <rudalics@gmx.at>
5483
727e958e
MR
5484 * lisp.h: Move EXFUNS for Fframe_root_window,
5485 Fframe_first_window and Fset_frame_selected_window to window.h.
5486
5487 * window.h: Move EXFUNS for Fframe_root_window,
5488 Fframe_first_window and Fset_frame_selected_window here from
5489 lisp.h.
5490
5491 * frame.c (Fwindow_frame, Fframe_first_window)
5492 (Fframe_root_window, Fframe_selected_window)
5493 (Fset_frame_selected_window): Move to window.c.
5494 (Factive_minibuffer_window): Move to minibuf.c.
5495 (Fother_visible_frames_p): New function.
5496
5497 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5498
f230ecc9
MR
5499 * window.c (decode_window, decode_any_window): Move up in code.
5500 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5501 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5502 (Fwindow_buffer): Move up and rewrite doc-string.
5503 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5504 (Fwindow_prev): New functions.
727e958e
MR
5505 (Fwindow_frame): Move here from frame.c. Accept any window as
5506 argument.
5507 (Fframe_root_window, Fframe_first_window)
5508 (Fframe_selected_window): Move here from frame.c. Accept frame
5509 or arbitrary window as argument. Update doc-strings.
5510 (Fminibuffer_window): Move up in code.
5511 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5512 (Fset_frame_selected_window): Move here from frame.c.
5513 Marginal rewrite.
727e958e
MR
5514 (Fselected_window, select_window, Fselect_window): Move up in
5515 code. Minor doc-string fixes.
f230ecc9 5516
4d09bcf6
PE
55172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5518
5519 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5520 Do not assume that spare memory exists; that assumption is valid
5521 only if SYSTEM_MALLOC.
5522 (LARGE_REQUEST): New macro, so that the issue of large requests
5523 is separated from the issue of spare memory.
5524
810928a2
AS
55252011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5526
172418ad
AS
5527 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5528 format. (Bug#8806)
5529
43f862f7
AS
5530 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5531
810928a2
AS
5532 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5533 before statements.
5534
a059fe24
JD
55352011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5536
5537 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5538
5539 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5540
5541 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5542 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5543
989bf368
JB
55442011-06-05 Juanma Barranquero <lekktu@gmail.com>
5545
5546 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5547
4b80f674
CY
55482011-06-04 Chong Yidong <cyd@stupidchicken.com>
5549
5550 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5551 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5552 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5553 New error handlers.
4b80f674
CY
5554 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5555 Obey Vx_select_enable_clipboard_manager. Catch errors in
5556 x_clipboard_manager_save (Bug#8779).
5557 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5558 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5559
99a33b77 55602011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5561
5562 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5563
99a33b77 55642011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5565
5566 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5567 in the current matrix if keep_current_p is non-zero.
5568
8264569d
EZ
55692011-06-04 Eli Zaretskii <eliz@gnu.org>
5570
5571 * bidi.c (bidi_level_of_next_char): Fix last change.
5572
57f97249
EZ
55732011-06-03 Eli Zaretskii <eliz@gnu.org>
5574
fec2107c 5575 Support bidi reordering of text covered by display properties.
57f97249 5576
fec2107c
EZ
5577 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5578 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5579 (bidi_cache_search, bidi_cache_iterator_state)
5580 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5581 (bidi_level_of_next_char, bidi_move_to_visually_next):
5582 Support character positions inside a run of characters covered by a
fec2107c
EZ
5583 display string.
5584 (bidi_paragraph_init, bidi_resolve_explicit_1)
5585 (bidi_level_of_next_char): Call bidi_fetch_char and
5586 bidi_fetch_char_advance instead of FETCH_CHAR and
5587 FETCH_CHAR_ADVANCE.
5588 (bidi_init_it): Initialize new members.
5589 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5590 definitions.
5591 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5592 instead of using explicit *_CHAR codes.
d6d100dd
SM
5593 (bidi_resolve_explicit, bidi_resolve_weak):
5594 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5595 bidirectional text is supported only in multibyte buffers.
5596 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5597 it to initialize the frame_window_p member of struct bidi_it.
5598 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5599 (bidi_resolve_explicit, bidi_resolve_weak)
5600 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5601 bidi_it->nchars is non-positive.
5602 (bidi_level_of_next_char): Don't try to lookup the cache for the
5603 next/previous character if nothing is cached there yet, or if we
5604 were just reseat()'ed to a new position.
c40e2fb2 5605
0e14fe90
EZ
5606 * xdisp.c (set_cursor_from_row): Set start and stop points
5607 according to the row's direction when priming the loop that looks
5608 for the glyph on which to display cursor.
5609 (single_display_spec_intangible_p): Function deleted.
5610 (display_prop_intangible_p): Reimplement to call
5611 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5612 Accept 3 additional arguments needed by handle_display_spec.
5613 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5614 values: lists, `(when COND...)' forms, etc.
5615 (single_display_spec_string_p): Support property values that are
5616 lists with the argument STRING its top-level element.
5617 (display_prop_string_p): Fix the condition for processing a
5618 property that is a list to be consistent with handle_display_spec.
fec2107c 5619 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5620 last portion of handle_display_prop.
5621 (compute_display_string_pos): Accept additional argument
5622 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5623 value of a `display' property is a "replacing spec".
5624 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5625 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5626 the display property, but just return a value indicating whether
5627 the display property will replace the characters it covers.
5628 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5629 frame_window_p members of struct bidi_it.
d6d100dd
SM
5630 (compute_display_string_pos, compute_display_string_end):
5631 New functions.
fec2107c
EZ
5632 (push_it): Accept second argument POSITION, where pop_it should
5633 jump to continue iteration.
5634 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5635
fec2107c
EZ
5636 * keyboard.c (adjust_point_for_property): Adjust the call to
5637 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5638
5639 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5640 (bidi_init_it): Update prototypes.
5641 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5642 (compute_display_string_pos, compute_display_string_end):
5643 Declare prototypes.
fec2107c
EZ
5644 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5645 EMACS_INT.
fc6f18ce 5646
40087514 56472011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5648
57f53182
PE
5649 Malloc failure behavior now depends on size of allocation.
5650 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5651 * lisp.h: Change signatures accordingly.
5652 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5653 All callers changed. (Bug#8762)
5654
5655 * gnutls.c: Use Emacs's memory allocators.
5656 Without this change, the gnutls library would invoke malloc etc.
5657 directly, which causes problems on non-SYNC_INPUT hosts, and which
5658 runs afoul of improving memory_full behavior. (Bug#8761)
5659 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5660 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5661 xfree instead of the default malloc, realloc, free.
5662 (Fgnutls_boot): No need to check for memory allocation failure,
5663 since xmalloc does that for us.
5664
ac32cd99 5665 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5666 * category.c (hash_get_category_set):
5667 * ccl.c (ccl_driver):
5668 * charset.c (Fdefine_charset_internal):
5669 * charset.h (struct charset.hash_index):
5670 * composite.c (get_composition_id, gstring_lookup_cache)
5671 (composition_gstring_put_cache):
5672 * composite.h (struct composition.hash_index):
5673 * dispextern.h (struct image.hash):
5674 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5675 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5676 (hashfn_equal, hashfn_user_defined, make_hash_table)
5677 (maybe_resize_hash_table, hash_lookup, hash_put)
5678 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5679 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5680 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5681 * image.c (make_image, search_image_cache, lookup_image)
5682 (xpm_put_color_table_h):
5683 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5684 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5685 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5686 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5687 * alloc.c (allocate_vectorlike):
5688 Check for overflow in vector size calculations.
5689 * ccl.c (ccl_driver):
5690 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5691 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5692 need to be updated by these changes.
40087514
PE
5693 * fns.c (make_hash_table, maybe_resize_hash_table):
5694 Check for integer overflow with large hash tables.
0de4bb68
PE
5695 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5696 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5697 (SXHASH_REDUCE): New macro.
5698 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5699 Use it instead of discarding useful hash info with large hash values.
5700 (sxhash_float): New function.
5701 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5702 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5703 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5704 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5705 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5706 Adjust signatures to match updated version of code.
5707 (consing_since_gc): Now EMACS_INT, since a single hash table can
5708 use more than INT_MAX bytes.
5709
698d32e2
DN
57102011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5711
5712 Make it possible to build with GCC-4.6+ -O2 -flto.
5713
5714 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5715
fd6fa53f
SM
57162011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5717
5718 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5719 Call minibuffer-inactive-mode.
5720
864db017
JB
57212011-05-31 Juanma Barranquero <lekktu@gmail.com>
5722
5723 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5724 Update dependencies.
5725
2ad0baf4
DN
57262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5727
5728 * data.c (init_data): Remove code for UTS, this system is not
5729 supported anymore.
5730
4fcc2638
DN
57312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5732
5733 Don't force ./temacs to start in terminal mode.
5734
5735 * frame.c (make_initial_frame): Initialize faces in all cases, not
5736 only when CANNOT_DUMP is defined.
5737 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5738
c56e0fd5
DN
57392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5740
5741 * dispnew.c (add_window_display_history): Use const for the string
5742 pointer. Remove declaration, not needed.
5743
333d54da 57442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5745
55d4c1b2 5746 Use 'inline', not 'INLINE'.
333d54da 5747 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5748 * alloc.c, fontset.c (INLINE): Remove.
5749 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5750 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5751 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5752 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5753 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5754
738db178
DN
57552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5756
5757 Make it possible to run ./temacs.
5758
5759 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5760 syms_of_callproc does the same thing. Remove test for
5761 "initialized", do it in the caller.
5762 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5763
620c53a6
SM
57642011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5765
5766 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5767 (read_minibuf): Use get_minibuffer.
5768 (syms_of_minibuf): Use DEFSYM.
5769 (Qmetadata): New var.
5770 * data.c (Qbuffer): Don't make it static.
5771 (syms_of_data): Use DEFSYM.
5772
e003a292
PE
57732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5774
5775 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5776 (CCL_CODE_MIN): New macro.
5777
ed008a6d
PE
57782011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5779
3687c2ef
PE
5780 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5781
ed008a6d
PE
5782 * eval.c (Qdebug): Now static.
5783 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5784 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5785 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5786
d66c4c7c
CY
57872011-05-29 Chong Yidong <cyd@stupidchicken.com>
5788
5789 * image.c: Various fixes to ImageMagick code comments.
5790 (Fimagemagick_types): Doc fix.
5791
5fbc2025
PE
57922011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5793
0196f88a
PE
5794 Minor fixes prompted by GCC 4.6.0 warnings.
5795
5796 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5797
5fbc2025
PE
5798 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5799 (x_clipboard_manager_save_all): Move extern decl to ...
5800 * xterm.h: ... here, so that it can be checked for consistency.
5801
1dd3c2d9
CY
58022011-05-29 Chong Yidong <cyd@stupidchicken.com>
5803
5804 * xselect.c (x_clipboard_manager_save_frame)
5805 (x_clipboard_manager_save_all): New functions.
5806 (Fx_clipboard_manager_save): Lisp function deleted.
5807
5808 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5809 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5810
5811 * xterm.h: Update prototype.
5812
5ba6571d
WX
58132011-05-28 William Xu <william.xwl@gmail.com>
5814
5815 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5816 exiting (Bug#8239).
5817
3eaff834
JM
58182011-05-28 Jim Meyering <meyering@redhat.com>
5819
e1900994 5820 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5821 * fns.c (to_uchar): Define.
5822 (crypto_hash_function): Use it to convert some newly-signed
5823 variables to unsigned, to avoid sign-extension bugs. For example,
5824 without this change, (md5 "truc") would evaluate to
5825 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5826 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5827 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5828
0f6990a7
PE
58292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5830
5831 Integer overflow fixes.
c8a9ca5a 5832
08686060
PE
5833 * dbusbind.c: Serial number integer overflow fixes.
5834 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5835 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5836 to hold a serial number that is too large for a fixnum.
5837 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5838 Check for serial numbers out of range. Decode any serial number
59568bf0 5839 that was so large that it became a float. (Bug#8722)
08686060 5840
2d1fc3c7
PE
5841 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5842 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5843 Use XFASTINT rather than XUINT when numbers are nonnegative.
5844 (xd_append_arg, Fdbus_method_return_internal):
5845 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5846 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5847 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5848 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5849 (Bug#8722)
2d1fc3c7 5850
c8a9ca5a
PE
5851 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5852
519e1d69
PE
5853 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5854
6df6ae42 5855 ccl: Add integer overflow checks.
30569699
PE
5856 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5857 (IN_INT_RANGE): New macros.
5858 (ccl_driver): Use them to check for integer overflow when
5859 decoding a CCL program. Many of the new checks are whether XINT (x)
5860 fits in int; it doesn't always, on 64-bit hosts. The new version
5861 doesn't catch all possible integer overflows, but it's an
847044ea 5862 improvement. (Bug#8719)
30569699 5863
c11285dc
PE
5864 * alloc.c (make_event_array): Use XINT, not XUINT.
5865 There's no need for unsigned here.
5866
fdccd48e
PE
5867 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5868 This follows up to the 2011-05-06 change that substituted uintptr_t
5869 for EMACS_INT. This case wasn't caught back then.
5870
37910ab2
PE
5871 Rework Fformat to avoid integer overflow issues.
5872 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5873 now (part of C89). Include <verify.h>.
5874 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5875 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5876 (Fformat): Avoid the prepass trying to compute sizes; it was only
5877 approximate and thus did not catch overflow reliably. Instead, walk
5878 through the format just once, formatting and computing sizes as we go,
5879 checking for integer overflow at every step, and allocating a larger
5880 buffer as needed. Keep track separately whether the format is
5881 multibyte. Keep only the most-recently calculated precision, rather
5882 than them all. Record whether each argument has been converted to
5883 string. Use EMACS_INT, not int, for byte and char and arg counts.
5884 Support field widths and precisions larger than INT_MAX. Avoid
5885 sprintf's undefined behavior with conversion specifications such as %#d
5886 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5887 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5888 formatting out-of-range floating point numbers with int
9173deec 5889 formats. (Bug#8668)
37910ab2 5890
2e6578fb
PE
5891 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5892
0ae6bdee
PE
5893 * data.c: Avoid integer truncation in expressions involving floats.
5894 * data.c: Include <intprops.h>.
5895 (arith_driver): When there's an integer overflow in an expression
5896 involving floating point, convert the integers to floating point
5897 so that the resulting value does not suffer from catastrophic
5898 integer truncation. For example, on a 64-bit host (* 4
5899 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5900 Do not rely on undefined behavior after integer overflow.
5901
de883a70
PE
5902 merge count_size_as_multibyte, parse_str_to_multibyte
5903 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5904 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5905 Check for integer overflow.
5906 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5907 since it's now a duplicate of the other. This is more of
5908 a character than a buffer op, so better that it's in character.c.
5909 * fns.c, print.c: Adjust to above changes.
5910
2ff916cb
PE
59112011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5912
5913 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5914
f1b54466
PE
59152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5916
fb1ac845
PE
5917 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5918 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5919 (x_clipboard_manager_save): Now static.
5920 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5921
f1b54466
PE
5922 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5923 (crypto_hash_function): Now static.
5924 Fix pointer signedness problems. Avoid unnecessary initializations.
5925
a9f737ee
CY
59262011-05-27 Chong Yidong <cyd@stupidchicken.com>
5927
5928 * termhooks.h (Vselection_alist): Make it terminal-local.
5929
5930 * terminal.c (create_terminal): Initialize it.
5931
5932 * xselect.c: Support for clipboard managers.
5933 (Vselection_alist): Move to termhooks.h as terminal-local var.
5934 (LOCAL_SELECTION): New macro.
5935 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5936 (symbol_to_x_atom): Remove gratuitous arg.
5937 (x_handle_selection_request, lisp_data_to_selection_data)
5938 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5939 (x_own_selection, x_get_local_selection, x_convert_selection):
5940 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5941 (some_frame_on_display): Delete unused function.
5942 (Fx_own_selection_internal, Fx_get_selection_internal)
5943 (Fx_disown_selection_internal, Fx_selection_owner_p)
5944 (Fx_selection_exists_p): New optional frame arg.
5945 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5946 (x_handle_selection_clear): Don't treat other terminals with the
5947 same keyboard specially. Use the terminal-local Vselection_alist.
5948 (x_clear_frame_selections): Use Frun_hook_with_args.
5949
5950 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5951
5952 * xterm.h: Add support for those atoms.
5953
e067f0c1
CY
59542011-05-26 Chong Yidong <cyd@stupidchicken.com>
5955
5956 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5957 (converted_selections, conversion_fail_tag): New global variables.
5958 (x_selection_request_lisp_error): Free the above.
5959 (x_get_local_selection): Remove unnecessary code.
5960 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5961 of converted selections stored in converted_selections.
5962 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5963 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5964 (x_convert_selection): New function.
5965 (x_handle_selection_event): Simplify.
5966 (x_get_foreign_selection): Don't ignore incoming requests while
5967 waiting for an answer; this will fail when we implement
5968 SAVE_TARGETS, and seems unnecessary anyway.
5969 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5970 (Vx_sent_selection_functions): Doc fix.
5971
0f4aebc0
LL
59722011-05-26 Leo Liu <sdl.web@gmail.com>
5973
5974 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5975
e61124cd
YM
59762011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5977
5978 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5979
5980 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5981 for fringe update if it has periodic bitmap.
ac389d0c 5982 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5983 and fringe_bitmap_periodic_p.
5984
5985 * fringe.c (get_fringe_bitmap_data): New function.
5986 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5987 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5988 row. Mark glyph row for fringe update if periodicity changed.
5989
5990 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5991 for fringe update unless it has periodic bitmap.
5992
f16d9837
KH
59932011-05-25 Kenichi Handa <handa@m17n.org>
5994
5995 * xdisp.c (get_next_display_element): Set correct it->face_id for
5996 a static composition.
5997
e1b90ef6
LL
59982011-05-24 Leo Liu <sdl.web@gmail.com>
5999
6000 * deps.mk (fns.o):
6001 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6002
6003 * fns.c (crypto_hash_function, Fsha1): New function.
6004 (Fmd5): Use crypto_hash_function.
6005 (syms_of_fns): Add Ssha1.
6006
7400048f
PE
60072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6008
6009 * gnutls.c: Remove unused macros.
6010 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6011 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6012 Remove macros that are defined and never used.
6013 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6014
abb71cf4
CY
60152011-05-22 Chong Yidong <cyd@stupidchicken.com>
6016
6017 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6018 (Fx_get_selection_internal): Minor cleanup.
6019 (Fx_own_selection_internal): Rename arguments for consistency with
6020 select.el.
6021
6307db39
PE
60222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6023
6024 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6025
f3d4e0a4
CY
60262011-05-22 Chong Yidong <cyd@stupidchicken.com>
6027
6028 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6029
4d8ade89
YM
60302011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6031
6032 * dispnew.c (scrolling_window): Don't exclude the case that the
6033 last enabled row in the desired matrix touches the bottom boundary.
6034
32078c8d
GM
60352011-05-21 Glenn Morris <rgm@gnu.org>
6036
6037 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6038 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6039 and add some more files.
32078c8d 6040
7285dc67
EZ
60412011-05-20 Eli Zaretskii <eliz@gnu.org>
6042
6043 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6044 report_file_error introduced by the change from 2011-05-07.
6045
89d1bd22
PE
60462011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6047
6048 * systime.h (Time): Define only if emacs is defined.
6049 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6050 where the include path doesn't have X11/X.h by default. See
6051 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6052
cd394be1 60532011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6054
6055 * composite.c (find_automatic_composition): Fix previous change.
6056
b9704ad9
GM
60572011-05-20 Glenn Morris <rgm@gnu.org>
6058
6059 * lisp.mk: New file, split from Makefile.in.
6060 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6061 (shortlisp): Remove.
6062 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6063
4a720484
GM
60642011-05-19 Glenn Morris <rgm@gnu.org>
6065
6066 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6067 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6068 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6069 (lisp): Set the order to that of loadup.el.
6070 (shortlisp): Make it a copy of $lisp.
6071 (SOME_MACHINE_LISP): Remove.
6072 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6073 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6074
a28d4396
KH
60752011-05-18 Kenichi Handa <handa@m17n.org>
6076
6077 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6078 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6079 (find_automatic_composition): Mostly rewrite for efficiency.
6080
a2b1fa8e
JB
60812011-05-18 Juanma Barranquero <lekktu@gmail.com>
6082
6083 * makefile.w32-in: Update dependencies.
6084
8e1f5610
CS
60852011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6086
6087 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6088 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6089
7025ee00 60902011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6091
cdfa6eab
PE
6092 Fix some integer overflow issues, such as string length overflow.
6093
06d6db33
PE
6094 * insdel.c (count_size_as_multibyte): Check for string overflow.
6095
2b4560a8
PE
6096 * character.c (lisp_string_width): Check for string overflow.
6097 Use EMACS_INT, not int, for string indexes and lengths; in
6098 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6099 the resulting string length overflows an EMACS_INT; instead,
6100 report a string overflow if no precision given. When checking for
6101 precision exhaustion, use a check that cannot possibly have
6102 integer overflow. (Bug#8675)
6103 * character.h (lisp_string_width): Adjust to new signature.
6104
cb93f9be
PE
6105 * alloc.c (string_overflow): New function.
6106 (Fmake_string): Use it. This doesn't change behavior, but saves
6107 a few bytes and will simplify future changes.
6108 * character.c (string_escape_byte8): Likewise.
6109 * lisp.h (string_overflow): New decl.
6110
1a1f3366
PE
6111 Fixups, following up to the user-interface timestamp change.
6112 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6113 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6114 * msdos.c (mouse_get_pos): Likewise.
6115 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6116 * w32gui.h (Time): Define by including "systime.h" rather than by
6117 declaring it ourselves. (Bug#8664)
6118
d4e3e4d3
PE
6119 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6120 * image.c (clear_image_cache): Likewise.
6121
f6a24d19
PE
6122 * term.c (term_mouse_position): Don't assume time_t wraparound.
6123
08dc5ae6
PE
6124 Be more systematic about user-interface timestamps.
6125 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6126 and sometimes 'EMACS_UINT', to represent these timestamps.
6127 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6128 This makes the code easier to follow, and makes it easier to catch
6129 integer overflow bugs such as Bug#8664.
6130 * frame.c (Fmouse_position, Fmouse_pixel_position):
6131 Use Time, not unsigned long, for user-interface timestamps.
6132 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6133 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6134 * keyboard.h (last_event_timestamp): Likewise.
6135 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6136 * menu.h (xmenu_show): Likewise.
6137 * term.c (term_mouse_position): Likewise.
6138 * termhooks.h (struct input_event.timestamp): Likewise.
6139 (struct terminal.mouse_position_hook): Likewise.
6140 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6141 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6142 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6143 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6144 what it was before.
6145 * menu.h, termhooks.h: Include "systime.h", for Time.
6146
8e55734a
PE
6147 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6148 Don't assume that the difference between two unsigned long values
6149 can fit into an integer. At this point, we know button_down_time
6150 <= event->timestamp, so the difference must be nonnegative, so
6151 there's no need to cast the result if double-click-time is
6152 nonnegative, as it should be; check that it's nonnegative, just in
6153 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6154 apart (about 25 days). (Bug#8664)
8e55734a 6155
841f1b75 6156 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6157 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6158
3e26f69c
PE
6159 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6160 that always fit in int. Use a sentinel instead of a counter, to
6161 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6162 * frame.h (struct frame): Use int for menu_bar_items_used
6163 instead of EMACS_INT, since it always fits in int.
3e26f69c 6164
5cc152c0
PE
6165 * menu.c (grow_menu_items): Check for int overflow.
6166
d89eb65e
PE
6167 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6168
5235bd3e
PE
6169 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6170 Before, the code was not consistent. These values cannot exceed
6171 2**31 - 1 so there's no need to make them unsigned.
6172 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6173 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6174 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6175 as modifiers.
6176 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6177
bc827e23
PE
6178 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6179 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6180 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6181 presumably because the widths might not match.
6182
78eb494e
PE
6183 * window.c (size_window): Avoid needless test at loop start.
6184
04f2d78b
CB
61852011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6186
6187 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6188
d2fc7e3d 61892011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6190
6191 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6192
d2fc7e3d 61932011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6194
6195 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6196 `width' to `bar_area_x' and `bar_area_width', respectively.
6197 (x_scroll_run): Take account of fringe background extension.
6198
04f2d78b
CB
6199 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6200 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6201 `bar_area_width', respectively.
6202 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6203 background extension.
6204
79b70037
GM
62052011-05-10 Jim Meyering <meyering@redhat.com>
6206
6207 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6208
2f142cc5
JB
62092011-05-10 Juanma Barranquero <lekktu@gmail.com>
6210
6211 * image.c (Finit_image_library): Return t for built-in image types,
6212 like pbm and xbm. (Bug#8640)
6213
57679c86
AS
62142011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6215
6216 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6217
888c9e86
EZ
62182011-05-07 Eli Zaretskii <eliz@gnu.org>
6219
b0512a1d
EZ
6220 * w32console.c (Fset_screen_color): Doc fix.
6221 (Fget_screen_color): New function.
6222 (syms_of_ntterm): Defsubr it.
6223
7285dc67
EZ
6224 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6225 unlink the temporary file if Fcall_process didn't create it in the
6226 first place.
6227 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6228 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6229 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6230 cue to call_process_cleanup not to close that handle.
6231
4d3fcc8e
BK
62322011-05-07 Ben Key <bkey76@gmail.com>
6233
6234 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6235 one of two shell specific rules, either bootstrap-temacs-CMD or
6236 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6237 to the previous implementation of the bootstrap-temacs rule.
6238 The bootstrap-temacs-CMD rule is similar to the previous
6239 implementation of the bootstrap-temacs rule except that it
6240 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6241 variable.
6242
6243 These changes, along with some changes to nt/configure.bat,
6244 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6245 earlier fix to add support for --cflags and --ldflags options
6246 that include quotes so that it works whether make uses cmd or
6247 sh as the shell.
6248
b4289b64
MA
62492011-05-06 Michael Albinus <michael.albinus@gmx.de>
6250
6251 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6252 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6253 is a constant.
6254 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6255 a string. Handle both cases.
6256 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6257 (Fdbus_register_method): Use Qinvalid_function.
6258
af4c0e28
JB
62592011-05-06 Juanma Barranquero <lekktu@gmail.com>
6260
6261 * makefile.w32-in: Update dependencies.
6262 (LISP_H): Add inttypes.h and stdin.h.
6263 (PROCESS_H): Add unistd.h.
6264
c51453d9
EZ
62652011-05-06 Eli Zaretskii <eliz@gnu.org>
6266
6267 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6268 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6269
8ff0ac3c 62702011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6271
4c4b566b
PE
6272 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6273
aab2b9b5
PE
6274 * term.c (vfatal): Remove stray call to va_end.
6275 It's not needed and the C Standard doesn't allow it here anyway.
6276
c378da0b
PE
6277 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6278 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6279
288b08c7
PE
6280 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6281 bytes.
6282
e3601888
PE
6283 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6284
db6c0e74
PE
6285 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6286
dd5963ea
PE
6287 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6288
88c9450f
PE
6289 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6290
2f9442b8
PE
6291 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6292
c032b5f8
PE
6293 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6294 * charset.c (Fdefine_charset_internal): Don't initialize
6295 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6296 32-bit int (Bug#8600).
a108c10b
PE
6297
6298 * lread.c (read_integer): Be more consistent with string-to-number.
6299 Use string_to_number to do the actual conversion; this avoids
6300 rounding errors and fixes some other screwups. Without this fix,
6301 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6302 (digit_to_number): Move earlier, for benefit of read_integer.
6303 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6304 not a digit in any supported base. (Bug#8602)
a108c10b 6305
ad5f9eea
PE
6306 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6307
aec1708a
PE
6308 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6309 to match comment at start of function. This also removes a
6310 GCC warning about overflow in a 32+64-bit port.
6311
47be4ab5
PE
6312 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6313
371cac43
PE
6314 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6315 Reported by Stefan Monnier in
6316 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6317 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6318 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6319
d01a7826
PE
6320 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6321 (EMACS_UINTPTR): Likewise, with uintptr_t.
6322
7fd47d5c
PE
6323 * lisp.h: Prefer 64-bit EMACS_INT if available.
6324 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6325 on 32-bit hosts that have 64-bit int, so that they can access
6326 large files.
122b0c86
PE
6327 However, temporarily disable this change unless the temporary
6328 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6329
8727937b
PE
6330 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6331
8ac068ac
PE
6332 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6333 This removes an assumption that EMACS_INT and long are the same
6334 width as pointers. The assumption is true for Emacs porting targets
6335 now, but we want to make other targets possible.
6336 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6337 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6338 In the rest of the code, change types of integers that hold casted
6339 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6340 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6341 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6342 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6343 No need to cast type when ORing.
6344 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6345 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6346 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6347 assume EMACS_INT is the same width as char *.
6348 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6349 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6350 Remove no-longer-needed casts.
6351 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6352 (xg_tool_bar_help_callback, xg_make_tool_item):
6353 Use EMACS_INTPTR to hold an integer
6354 that will be cast to void *; this can avoid a GCC warning
6355 if EMACS_INT is not the same width as void *.
6356 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6357 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6358 (current_message_1, set_message_1):
6359 Use a local to convert to proper width without a cast.
6360 * xmenu.c (dialog_selection_callback): Likewise.
6361
ede49d71
PE
6362 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6363 Also, don't assume VALBITS / RAND_BITS is less than 5,
6364 and don't rely on undefined behavior when shifting a 1 left into
6365 the sign bit.
6366 * lisp.h (get_random): Change signature to match.
6367
2f30ecd0
PE
6368 * lread.c (hash_string): Use size_t, not int, for hash computation.
6369 Normally we prefer signed values; but hashing is special, because
6370 it's better to use unsigned division on hash table sizes so that
6371 the remainder is nonnegative. Also, size_t is the natural width
6372 for hashing into memory. The previous code used 'int', which doesn't
6373 retain enough info to hash well into very large tables.
6374 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6375
2a866e7b
PE
6376 * dbusbind.c: Don't possibly lose pointer info when converting.
6377 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6378 Use XPNTR rather than XHASH, so that the high-order bits of
6379 the pointer aren't lost when converting through void *.
6380
51639eac
PE
6381 * eval.c (Fautoload): Don't double-shift a pointer.
6382
92394119
PE
6383 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6384
dbdb9a7c
JB
63852011-05-06 Juanma Barranquero <lekktu@gmail.com>
6386
6387 * gnutls.c (DEF_GNUTLS_FN):
6388 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6389
db7a0b4f
AS
63902011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6391
6392 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6393 marker. (Bug#8610)
6394
cd394be1 63952011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6396
6397 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6398 New version that can reserve upto 2GB of heap space.
6399
f7ff1b0f 64002011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6401
6402 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6403
639c109b
TZ
64042011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6405
6406 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6407 `gnutls_certificate_set_x509_key_file'.
6408
d2127135
JB
64092011-05-05 Juanma Barranquero <lekktu@gmail.com>
6410
6411 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6412 Update dependencies.
6413
e968f4f3
JB
64142011-05-04 Juanma Barranquero <lekktu@gmail.com>
6415
6416 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6417 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6418 Remove unused parameter `fildes'.
6419 * process.c (read_process_output, send_process): Don't pass it.
6420
84d358f0
JB
64212011-05-04 Juanma Barranquero <lekktu@gmail.com>
6422
6423 Fix previous change: the library cache is defined in w32.c.
6424 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6425 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6426
0898ca10
JB
64272011-05-04 Juanma Barranquero <lekktu@gmail.com>
6428
6429 Implement dynamic loading of GnuTLS on Windows.
6430
6431 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6432 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6433 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6434 Declare.
6435
6436 * gnutls.c (Qgnutls_dll): Define.
6437 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6438 (gnutls_*): Declare function pointers.
6439 (init_gnutls_functions): New function to initialize function pointers.
6440 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6441 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6442 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6443 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6444 (emacs_gnutls_write, emacs_gnutls_read)
6445 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6446 (Fgnutls_available_p): New function.
6447 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6448 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6449 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6450
6451 * image.c: Include w32.h.
6452 (Vimage_type_cache): Delete.
6453 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6454 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6455 (w32_delayed_load): Move to w32.c.
6456
6457 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6458
6459 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6460 (w32_delayed_load): Move from image.c. When loading a library, record
6461 its filename in the :loaded-from property of the library id.
6462 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6463 Initialize and staticpro them.
6464 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6465
6466 * process.c: Include lisp.h before w32.h, not after.
6467 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6468 instead of gnutls_record_check_pending.
6469
6470 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6471
ff4de4aa
TZ
64722011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6473
6474 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6475 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6476 as passed in.
6477
abe95abb
JD
64782011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6479
6480 * xterm.c (x_set_frame_alpha): Do not set property on anything
6481 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6482
e16e55d4
JB
64832011-05-02 Juanma Barranquero <lekktu@gmail.com>
6484
6485 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6486
bafcf6a5
JB
64872011-05-02 Juanma Barranquero <lekktu@gmail.com>
6488
6489 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6490 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6491 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6492 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6493 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6494 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6495 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6496 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6497 (Qgnutls_bootprop_callbacks_verify): Make static.
6498
e7a6747f
AS
64992011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6500
19ed11ba
AS
6501 * callproc.c: Indentation fixup.
6502
e7a6747f 6503 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6504 (wait_for_termination, interruptible_wait_for_termination):
6505 Move after wait_for_termination_1.
e7a6747f 6506
1ef14cb4
LMI
65072011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6508
6509 * sysdep.c (interruptible_wait_for_termination): New function
6510 which is like wait_for_termination, but allows keyboard
6511 interruptions.
6512
6513 * callproc.c (Fcall_process): Add (:file "file") as an option for
6514 the STDOUT buffer.
6515 (Fcall_process_region): Ditto.
6516
330d880c
EZ
65172011-04-30 Eli Zaretskii <eliz@gnu.org>
6518
8db90b73
EZ
6519 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6520 rather than `XVECTOR (FOO)->size'.
6521
330d880c
EZ
6522 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6523 inttypes.h, as a gnulib replacement is used if it not available in
6524 system headers.
6525
15cbd324
EZ
65262011-04-21 Eli Zaretskii <eliz@gnu.org>
6527
6528 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6529 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6530 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6531
6532 * coding.c (coding_alloc_by_realloc): Error out if destination
6533 will grow beyond MOST_POSITIVE_FIXNUM.
6534 (decode_coding_emacs_mule): Abort if there isn't enough place in
6535 charbuf for the composition carryover bytes. Reserve an extra
6536 space for up to 2 characters produced in a loop.
6537 (decode_coding_iso_2022): Abort if there isn't enough place in
6538 charbuf for the composition carryover bytes.
6539
65402011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6541
ae940cca
EZ
6542 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6543 aborting when %lld or %lll format is passed.
6544 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6545 %llo or %llx format is passed. (Bug#8545)
6546
03ab8921
EZ
6547 * window.c (window_scroll_line_based): Use a marker instead of
6548 simple variables to record original value of point. (Bug#7952)
6549
afda1437
EZ
6550 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6551 produced by %s or %c overflows available buffer space. (Bug#8545)
6552
f76dee0c
PE
65532011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6554
6555 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6556 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6557
fdc5744d
JB
65582011-04-28 Juanma Barranquero <lekktu@gmail.com>
6559
6560 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6561
638f053a
JB
65622011-04-28 Juanma Barranquero <lekktu@gmail.com>
6563
6564 * keyboard.c (Qdelayed_warnings_hook): Define.
6565 (command_loop_1): Run `delayed-warnings-hook'
6566 if Vdelayed_warnings_list is non-nil.
6567 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6568 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6569
d178f871
EZ
65702011-04-28 Eli Zaretskii <eliz@gnu.org>
6571
6572 * doprnt.c (doprnt): Don't return value smaller than the buffer
6573 size if the message was truncated. (Bug#8545).
6574
b124fd93
JB
65752011-04-28 Juanma Barranquero <lekktu@gmail.com>
6576
6577 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6578 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6579
e810457d
PE
65802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6581
6582 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6583
ea51cceb
JB
65842011-04-27 Juanma Barranquero <lekktu@gmail.com>
6585
6586 * makefile.w32-in: Update dependencies.
6587
94dcfacf
EZ
65882011-04-27 Eli Zaretskii <eliz@gnu.org>
6589
6590 Improve `doprnt' and its usage. (Bug#8545)
6591 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6592 `format_end'. Remove support for %l as a conversion specifier.
6593 Don't use xrealloc. Improve diagnostics when the %l size modifier
6594 is used. Update the commentary.
6595
6596 * eval.c (verror): Simplify calculation of size_t.
6597
6598 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6599 messages.
6600
f61f41d7
PE
66012011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6602
6603 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6604 change.
6605
96fb4434
PE
66062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6607
6608 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6609 This makes this file independent of the recent pseudovector change.
6610
671875da 66112011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6612
69e9b5a3
PE
6613 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6614
b5f869a7 6615 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6616 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6617 Remove unused local.
c8926152 6618 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6619
841a1577 6620 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6621 GCC 4.6.0 optimizes based on type-based alias analysis.
6622 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6623 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6624 != &v->size, and therefore "v->size = 1; b->size = 2; return
6625 v->size;" must therefore return 1. This assumption is incorrect
6626 for Emacs, since it type-puns struct Lisp_Vector * with many other
6627 types. To fix this problem, this patch adds a new type struct
f904488f 6628 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6629 and pseudovectors, and helps optimizing compilers not get fooled
6630 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6631 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6632 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6633 the size member.
eab3844f
PE
6634 (XSETPVECTYPE): Rewrite in terms of new macro.
6635 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6636 This is a bit clearer, and further avoids the possibility of
6637 undesirable aliasing.
6638 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6639 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6640 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6641 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6642 (ASIZE): Now uses header.size rather than size.
6643 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6644 to avoid the hassle of writing XVECTOR (foo)->header.size.
6645 (struct vectorlike_header): New type.
eab3844f
PE
6646 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6647 object, to help avoid aliasing.
6648 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6649 (SUBRP): Likewise, since Lisp_Subr is a special case.
6650 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6651 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6652 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6653 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6654 changed to be "header.size" and "header.next".
6655 * buffer.h (struct buffer): Likewise.
6656 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6657 * frame.h (struct frame): Likewise.
6658 * process.h (struct Lisp_Process): Likewise.
6659 * termhooks.h (struct terminal): Likewise.
6660 * window.c (struct save_window_data, struct saved_window): Likewise.
6661 * window.h (struct window): Likewise.
6662 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6663 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6664 * buffer.c (init_buffer_once): Likewise.
6665 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6666 special case.
6667 * process.c (Fformat_network_address): Use local var for size,
6668 for brevity.
6669
0df1eac5
PE
6670 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6671
847ab9d1 6672 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6673 * data.c (atof): Remove decl; no longer used or needed.
6674 (digit_to_number): Move to lread.c.
6675 (Fstring_to_number): Use new string_to_number function, to be
6676 consistent with how the Lisp reader treats infinities and NaNs.
6677 Do not assume that floating-point numbers represent EMACS_INT
6678 without losing information; this is not true on most 64-bit hosts.
6679 Avoid double-rounding errors, by insisting on integers when
6680 parsing non-base-10 numbers, as the documentation specifies.
6681 * lisp.h (string_to_number): New decl, replacing ...
6682 (isfloat_string): Remove.
bc0a5c13 6683 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6684 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6685 appears to have been a coding error. Similarly, do not accept
6686 strings like +-1e0 as floating point numbers. Do not report
6687 overflow for integer overflows unless the base is not 10 which
6688 means we have no simple and reliable way to continue.
6689 Break out the floating-point parsing into a new
6690 function string_to_number, so that Fstring_to_number parses
6691 floating point numbers consistently with the Lisp reader.
04f2d78b 6692 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6693 (E_CHAR, EXP_INT): Remove, replacing with ...
6694 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6695 (string_to_number): New function, replacing isfloat_string.
6696 This function checks for valid syntax and produces the resulting
6697 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6698 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6699 so that overflow for non-base-10 numbers is reported only when
6700 there's no portable and simple way to convert to floating point.
452f4150 6701
67769ffc
PE
6702 * textprop.c (set_text_properties_1): Rewrite for clarity,
6703 and to avoid GCC warning about integer overflow.
6704
c20db43f
PE
6705 * intervals.h (struct interval): Use EMACS_INT for members
6706 where EMACS_UINT might cause problems. See
6707 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6708 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6709 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6710 All uses changed.
37aa2f85
PE
6711 (offset_intervals): Tell GCC not to worry about length overflow
6712 when negating a negative length.
c20db43f 6713
2538aa2f
PE
6714 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6715 (overrun_check_free): Likewise.
6716
f2d3008d
PE
6717 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6718 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6719 word size.
6720
ec8df744
PE
6721 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6722 (gnutls_make_error): Rename local to avoid shadowing.
6723 (gnutls_emacs_global_deinit): ifdef out; not used.
6724 (Fgnutls_boot): Use const for pointer to readonly storage.
6725 Comment out unused local. Fix pointer signedness problems.
6726
640ee02d
PE
6727 * lread.c (openp): Don't stuff size_t into an 'int'.
6728 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6729 about possible signed overflow.
6730
6048fb2a
PE
6731 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6732 (GDK_KEY_g): Don't define if already defined.
6733 (xg_prepare_tooltip): Avoid pointer signedness problem.
6734 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6735
fa3c87e1
PE
6736 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6737 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6738
2172544b
PE
6739 * xfns.c (Fx_window_property): Simplify a bit,
6740 to make a bit faster and to avoid GCC 4.6.0 warning.
6741 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6742
9b821a21
PE
6743 * fns.c (internal_equal): Don't assume size_t fits in int.
6744
3c616cfa
PE
6745 * alloc.c (compact_small_strings): Tighten assertion a little.
6746
c2982e87
PE
6747 Replace pEd with more-general pI, and fix some printf arg casts.
6748 * lisp.h (pI): New macro, generalizing old pEd macro to other
6749 conversion specifiers. For example, use "...%"pI"d..." rather
6750 than "...%"pEd"...".
6751 (pEd): Remove. All uses replaced with similar uses of pI.
6752 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6753 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6754 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6755 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6756 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6757 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6758 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6759 64-bit hosts.
6760 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6761 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6762 * print.c (safe_debug_print, print_object): Likewise.
6763 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6764 to int.
6f04d126
PE
6765 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6766 avoiding the 0 flag, which is not portable.
c2982e87
PE
6767 * process.c (Fmake_network_process): Use pI to avoid cast.
6768 * region-cache.c (pp_cache): Likewise.
6769 * xdisp.c (decode_mode_spec): Likewise.
6770 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6771 behavior on 64-bit hosts with printf arg.
6f04d126 6772 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6773 (x_stop_queuing_selection_requests): Likewise.
6774 (x_get_window_property): Don't truncate byte count to an 'int'
6775 when tracing.
0b432f21 6776
5e073ec7
PE
6777 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6778 here, since it parses constructs like leading '-' and spaces,
6779 which are not wanted; and it overflows with large numbers.
6780 Instead, simply match F[0-9]+, which is what is wanted anyway.
6781
36372bf9
PE
6782 * alloc.c: Remove unportable assumptions about struct layout.
6783 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6784 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6785 (allocate_vectorlike, make_pure_vector): Use the new macros,
6786 plus offsetof, to remove unportable assumptions about struct layout.
6787 These assumptions hold on all porting targets that I know of, but
6788 they are not guaranteed, they're easy to remove, and removing them
6789 makes further changes easier.
6790
0b432f21
PE
6791 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6792 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6793 (string_overrun_cookie): Now const. Use initializers that
6794 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6795 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6796 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6797 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6798 multiple of sizeof (EMACS_INT); it need not be, if
6799 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6800 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6801
895009e1
JB
68022011-04-26 Juanma Barranquero <lekktu@gmail.com>
6803
6804 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6805
6a7a1b0b
TZ
68062011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6807
6808 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6809 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6810 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6811
841a1577 68122011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6813
6814 * lisp.h (Qdebug): List symbol.
895009e1 6815 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6816 * keyboard.c (debug-on-event): New variable.
6817 (handle_user_signal): Break into debugger when debug-on-event
6818 matches the current signal symbol.
6819
f2d3ba6f
DN
68202011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6821
6822 * alloc.c (check_sblock, check_string_bytes)
6823 (check_string_free_list): Convert to standard C.
6824
42ce4c63
TZ
68252011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6826
6827 * w32.c (emacs_gnutls_push): Fix typo.
6828
825cd63c
EZ
68292011-04-25 Eli Zaretskii <eliz@gnu.org>
6830
fb11d64d
EZ
6831 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6832 "cast to pointer from integer of different size".
6833
825cd63c
EZ
6834 Improve doprnt and its use in verror. (Bug#8545)
6835 * doprnt.c (doprnt): Document the set of format control sequences
6836 supported by the function. Use SAFE_ALLOCA instead of always
6837 using `alloca'.
6838
6839 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6840 is one byte too soon. Don't use xrealloc; instead xfree and
6841 xmalloc anew.
6842
e061a11b
TZ
68432011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6844
6845 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6846 callbacks stage.
6847
6848 * gnutls.c: Renamed global_initialized to
6849 gnutls_global_initialized. Added internals for the
6850 :verify-hostname-error, :verify-error, and :verify-flags
6851 parameters of `gnutls-boot' and documented those parameters in the
6852 docstring. Start callback support.
9173deec
JB
6853 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6854 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6855 on error. Return error code.
e061a11b
TZ
6856 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6857 (emacs_gnutls_read): Likewise.
6858 (Fgnutls_boot): Return handshake error code.
6859 (emacs_gnutls_handle_error): New function.
6860 (wsaerror_to_errno): Likewise.
6861
6862 * w32.h (emacs_gnutls_pull): Add prototype.
6863 (emacs_gnutls_push): Likewise.
6864
6865 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6866 (emacs_gnutls_push): Likewise.
6867
68682011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6869
6870 * process.c (wait_reading_process_output): Check if GnuTLS
6871 buffered some data internally if no FDs are set for TLS
6872 connections.
6873
6874 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6875 (LIBS): Link to USER_LIBS.
6876 ($(BLD)/gnutls.$(0)): New target.
6877
fa6996bc
EZ
68782011-04-24 Eli Zaretskii <eliz@gnu.org>
6879
eb35682e
EZ
6880 * xdisp.c (handle_single_display_spec): Rename the
6881 display_replaced_before_p argument into display_replaced_p, to
6882 make it consistent with the commentary. Fix typos in the
6883 commentary.
6884
e2ad650c
EZ
6885 * textprop.c (syms_of_textprop): Remove dead code.
6886 (copy_text_properties): Delete obsolete commentary about an
6887 interface that was deleted long ago. Fix typos in the description
6888 of arguments.
6889
1b2de274
EZ
6890 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6891 to changes in oldXMenu/XMenu.h from 2011-04-16.
6892 <menu_help_message, prev_menu_help_message>: Constify.
6893 (IT_menu_make_room): menu->help_text is now `const char **';
6894 adjust.
6895
6896 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6897 to changes in oldXMenu/XMenu.h from 2011-04-16.
6898 (struct XMenu): Declare `help_text' `const char **'.
6899
6900 * xfaces.c <Qunspecified>: Make extern again.
6901
6902 * syntax.c: Include sys/types.h before including regex.h, as
6903 required by Posix.
6904
762b15be
EZ
6905 * doc.c (get_doc_string): Improve the format passed to `error'.
6906
6907 * doprnt.c (doprnt): Improve commentary.
6908
6909 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6910
6911 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6912 them with etags.
6913
f1052e5d
EZ
6914 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6915 changes in globals.h immediately force recompilation.
762b15be
EZ
6916 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6917 $(CURDIR)/s/ms-w32.h.
6918 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6919
fa6996bc
EZ
6920 * character.c (Fchar_direction): Function deleted.
6921 (syms_of_character): Don't defsubr it.
6922 <char-direction-table>: Deleted.
6923
e6c3da20
EZ
69242011-04-23 Eli Zaretskii <eliz@gnu.org>
6925
6926 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6927 * doprnt.c: Include limits.h.
6928 (SIZE_MAX): New macro.
04f2d78b
CB
6929 (doprnt): Return a size_t value. 2nd arg is now size_t.
6930 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6931 Improve overflow protection. Support `l' modifier for integer
6932 conversions. Support %l conversion. Don't assume an EMACS_INT
6933 argument for integer conversions and for %c.
6934
6935 * lisp.h (doprnt): Restore prototype.
6936
6937 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6938 $(SRC)/character.h.
6939
6940 * Makefile.in (base_obj): Add back doprnt.o.
6941
6942 * deps.mk (doprnt.o): Add back prerequisites.
6943 (callint.o): Depend on character.h.
6944
6945 * eval.c (internal_lisp_condition_case): Include the handler
6946 representation in the error message.
6947 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6948 when breaking from the loop.
6949
6950 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6951
6952 * callint.c (Fcall_interactively): When displaying error message
6953 about invalid control letter, pass the character's codepoint, not
6954 a pointer to its multibyte form. Improve display of the character
6955 in octal and display also its hex code.
6956
6957 * character.c (char_string): Use %x to display the (unsigned)
6958 codepoint of an invalid character, to avoid displaying a bogus
6959 negative value.
6960
6961 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6962 `error', not SYMBOL_NAME itself.
6963
6964 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6965 character arguments to `error'.
6966
6967 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6968 to `error' in error message about FINAL_CHAR argument. Make sure
6969 FINAL_CHAR is a character, and use %c when it is passed as
6970 argument to `error'.
6971
4ffd0d6b 69722011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6973
6974 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6975
6976 * w32.c: Include <time.h>.
6977 (sys_localtime): New function.
6978
4ffd0d6b 69792011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6980
6981 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6982
4ffd0d6b 6983 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6984
4ffd0d6b 69852011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6986
4ffd0d6b
GM
6987 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6988 zombies (Bug#8467).
aac0c6e3 6989
04c56954
EZ
69902011-04-19 Eli Zaretskii <eliz@gnu.org>
6991
6992 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6993 gl_state.e_property when gl_state.object is Qt.
6994
6995 * insdel.c (make_gap_larger): Remove limitation of buffer size
6996 to <= INT_MAX.
6997
16a43933
CY
69982011-04-18 Chong Yidong <cyd@stupidchicken.com>
6999
7000 * xdisp.c (lookup_glyphless_char_display)
7001 (produce_glyphless_glyph): Handle cons cell entry in
7002 glyphless-char-display.
7003 (Vglyphless_char_display): Document it.
7004
7005 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7006 glyphless-char-display.
7007
4581706e
CY
70082011-04-17 Chong Yidong <cyd@stupidchicken.com>
7009
7010 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7011
7012 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7013
7014 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7015 definition for no-X builds.
7016
4887c6e2 70172011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7018
fd35b6f9
PE
7019 Static checks with GCC 4.6.0 and non-default toolkits.
7020
5c1ccb01
PE
7021 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7022
006c5daa
PE
7023 * process.c (keyboard_bit_set): Define only if SIGIO.
7024 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7025 (send_process): Repair possible setjmp clobbering.
7026
efc736d3
PE
7027 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7028
4e2fe2e6
PE
7029 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7030
f97334a2
PE
7031 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7032
4e75f29d
PE
7033 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7034 Define only if needed.
7035
90efadd1
PE
7036 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7037 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7038 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7039
3c647824
PE
7040 * dispextern.h (struct redisplay_interface): Rename param
7041 to avoid shadowing.
e264f262 7042 * termhooks.h (struct terminal): Likewise.
761383f4 7043 * xterm.c (xembed_send_message): Likewise.
3c647824 7044
b58c5c4a
PE
7045 * insdel.c (make_gap_smaller): Define only if
7046 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7047
cad59032
PE
7048 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7049 it.
7050
c339dc2e
PE
7051 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7052 so that we aren't warned about unused symbols.
7053
91a3e27b
PE
7054 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7055
399c71d3 7056 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7057
8ffc96f5
PE
7058 * xfns.c (x_real_positions): Mark locals as initialized.
7059
eef9bc79
PE
7060 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7061
098db9dd
PE
7062 * xterm.c: Fix problems found by static analysis with other toolkits.
7063 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7064 (x_dispatch_event): Declare static if USE_GTK, and
7065 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7066 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7067 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7068 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7069 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7070
eb18f6cc
PE
7071 * xmenu.c (menu_help_callback): Pointer type fixes.
7072 Use const pointers when pointing at readonly data. Avoid pointer
7073 signedness clashes.
7074 (FALSE): Remove unused macro.
7075 (update_frame_menubar): Remove unused decl.
7076
1fe72bf8
PE
7077 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7078
60d9e1db
PE
7079 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7080 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7081 (single_menu_item): Rename local to avoid shadowing.
7082
39261c26
PE
7083 * keyboard.c (make_lispy_event): Remove unused local var.
7084
018c5e19
PE
7085 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7086 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7087
63d2b86e
PE
7088 * bitmaps: Change bitmaps from unsigned char back to the X11
7089 compatible char. Avoid the old compiler warnings about
7090 out-of-range initializers by using, for example, '\xab' rather
7091 than 0xab.
7092
aefd87e1
PE
7093 * xgselect.c (xgselect_initialize): Check vs interface
7094 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7095
bf501fb9
PE
7096 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7097
e9829fdf
PE
7098 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7099 to read-only memory.
7100
1086c095
PE
7101 * fns.c (vector): Remove; this old hack is no longer needed.
7102
2baccd04 7103 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7104 Remove unused var.
dde42981 7105 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7106
72391843 7107 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7108
436c16df 7109 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7110 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7111 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7112
92bb796d 7113 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7114 (x_term_init): Remove local to avoid shadowing.
92bb796d 7115
764430a3 7116 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7117
7118 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7119 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7120
d1dfb56c
EZ
71212011-04-16 Eli Zaretskii <eliz@gnu.org>
7122
c4354cb4
EZ
7123 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7124
d1dfb56c
EZ
7125 Fix regex.c, syntax.c and friends for buffers > 2GB.
7126 * syntax.h (struct gl_state_s): Declare character position members
7127 EMACS_INT.
7128
7129 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7130
04f2d78b
CB
7131 * textprop.c (verify_interval_modification, interval_of):
7132 Declare arguments EMACS_INT.
d1dfb56c
EZ
7133
7134 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7135 EMACS_INT.
7136
7137 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7138
7139 * indent.c (Fvertical_motion): Local variable it_start is now
7140 EMACS_INT.
7141
7142 * regex.c (re_match, re_match_2, re_match_2_internal)
7143 (bcmp_translate, regcomp, regexec, print_double_string)
7144 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7145 (re_compile_pattern, re_exec): Declare arguments and local
7146 variables `size_t' and `ssize_t' and return values `regoff_t', as
7147 appropriate.
7148 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7149 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7150 <compile_stack_type>: `size' and `avail' are now `size_t'.
7151
7152 * regex.h <regoff_t>: Use ssize_t, not int.
7153 (re_search, re_search_2, re_match, re_match_2): Arguments that
7154 specify buffer/string position and length are now ssize_t and
7155 size_t. Return type is regoff_t.
7156
613052cd
BK
71572011-04-16 Ben Key <bkey76@gmail.com>
7158
7159 * nsfont.m: Fixed bugs in ns_get_family and
7160 ns_descriptor_to_entity that were caused by using free to
7161 deallocate memory blocks that were allocated by xmalloc (via
7162 xstrdup). This caused Emacs to crash when compiled with
7163 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7164 --enable-checking=xmallocoverrun). xfree is now used to
7165 deallocate these memory blocks.
7166
4170f62f 71672011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7168
71b41406
PE
7169 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7170
9587a89d
PE
7171 emacs_write: Accept and return EMACS_INT for sizes.
7172 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7173 et seq.
7174 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7175 Accept and return EMACS_INT.
7176 (emacs_gnutls_write): Return the number of bytes written on
7177 partial writes.
7178 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7179 (emacs_read, emacs_write): Remove check for negative size, as the
7180 Emacs source code has been audited now.
9587a89d
PE
7181 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7182 (emacs_read, emacs_write): Use it.
273a5f82
PE
7183 * process.c (send_process): Adjust to the new signatures of
7184 emacs_write and emacs_gnutls_write. Do not attempt to store
7185 a byte offset into an 'int'; it might overflow.
9587a89d 7186 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7187
3e047f51
PE
7188 * sound.c: Don't assume sizes fit in 'int'.
7189 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7190 Return EMACS_INT, not int.
3e047f51 7191 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7192 Accept EMACS_INT, not int.
7193 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7194 record read return values.
7195
cc39a9db
BK
71962011-04-15 Ben Key <bkey76@gmail.com>
7197
c9d0ec6d
JB
7198 * keyboard.c (Qundefined): Don't declare static since it is used
7199 in nsfns.m.
7200 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7201 static since they are used in nsfont.m.
cc39a9db 7202
6c60eb9f
SM
72032011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7204
7205 * process.c (Qprocessp): Don't declare static.
7206 * lisp.h (Qprocessp): Declare again.
7207
7990b61a
JB
72082011-04-15 Juanma Barranquero <lekktu@gmail.com>
7209
7210 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7211
5d4cb038
PE
72122011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7213
8bd7b830 7214 Improve C-level modularity by making more things 'static'.
cd64ea1d 7215
e3b27b31
PE
7216 Don't publish debugger-only interfaces to other modules.
7217 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7218 (verify_bytepos, count_markers): Move decls to the only modules
7219 that need them.
7220 * region-cache.h (pp_cache): Likewise.
7221 * window.h (check_all_windows): Likewise.
7222 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7223
5d4cb038
PE
7224 * sysdep.c (croak): Now static, if
7225 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7226 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7227
7228 * alloc.c (refill_memory_reserve): Now static if
7229 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7230 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7231
e87b6180
PE
7232 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7233 Define only if USE_LUCID.
7234
ac64929e
PE
7235 * xrdb.c (x_customization_string, x_rm_string): Now static.
7236
6f37259d
PE
7237 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7238 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7239
1683e3ab
PE
7240 * xdisp.c (draw_row_with_mouse_face): Now static.
7241 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7242
de9c2632
PE
7243 * window.h (check_all_windows): Mark externally visible.
7244
2b96acb7
PE
7245 * window.c (window_deletion_count): Now static.
7246
7247 * undo.c: Make symbols static if they're not exported.
7248 (last_undo_buffer, last_boundary_position, pending_boundary):
7249 Now static.
7250
50436f33
PE
7251 * textprop.c (interval_insert_behind_hooks): Now static.
7252 (interval_insert_in_front_hooks): Likewise.
7253
64520e5c
PE
7254 * term.c: Make symbols static if they're not exported.
7255 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7256 (max_frame_lines, tty_set_terminal_modes):
7257 (tty_reset_terminal_modes, tty_turn_off_highlight):
7258 (get_tty_terminal): Now static.
7259 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7260 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7261 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7262 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7263 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7264
1fa53021
PE
7265 * sysdep.c: Make symbols static if they're not exported.
7266 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7267 Now static.
7268 (sigprocmask_set, full_mask): Remove; unused.
7269 (wait_debugging): Mark as visible.
7270 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7271 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7272
d4b43b22
PE
7273 * syntax.c (syntax_temp): Define only if !__GNUC__.
7274
b7c513d0
PE
7275 * sound.c (current_sound_device, current_sound): Now static.
7276
989b29ad
PE
7277 * search.c (searchbufs, searchbuf_head): Now static.
7278
13a55a78
PE
7279 * scroll.c (scroll_cost): Remove; unused.
7280 * dispextern.h (scroll_cost): Remove decl.
7281
de68a1fc
PE
7282 * region-cache.h (pp_cache): Mark as externally visible.
7283
40ccffa6
PE
7284 * process.c: Make symbols static if they're not exported.
7285 (process_tick, update_tick, create_process, chan_process):
7286 (Vprocess_alist, proc_buffered_char, datagram_access):
7287 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7288 (deactivate_process): Mark defn as static, as well as decl.
7289 * lisp.h (create_process): Remove decl.
7290 * process.h (chan_process, Vprocess_alist): Remove decls.
7291
ad64fc97
PE
7292 * print.c: Make symbols static if they're not exported.
7293 (print_depth, new_backquote_output, being_printed, print_buffer):
7294 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7295 (print_interval, print_number_index, initial_stderr_stream):
7296 Now static.
7297 * lisp.h (Fprinc): Remove decl.
7298 (debug_output_compilation_hack): Mark as externally visible.
7299
adddb265
PE
7300 * sysdep.c (croak): Move decl from here to syssignal.h.
7301 * syssignal.h (croak): Put it here, so the API can be checked when
7302 'croak' is called from dissociate_if_controlling_tty.
7303
1717ede2
PE
7304 * minibuf.c: Make symbols static if they're not exported.
7305 (minibuf_save_list, choose_minibuf_frame): Now static.
7306 * lisp.h (choose_minibuf_frame): Remove decl.
7307
fa5fb2bc
PE
7308 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7309
1e3890d1
PE
7310 * lread.c: Make symbols static if they're not exported.
7311 (read_objects, initial_obarray, oblookup_last_bucket_number):
7312 Now static.
7313 (make_symbol): Remove; unused.
7314 * lisp.h (initial_obarray, make_symbol): Remove decls.
7315
8a1414fa
PE
7316 * keyboard.c: Make symbols static if they're not exported.
7317 (single_kboard, recent_keys_index, total_keys, recent_keys):
7318 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7319 (this_single_command_key_start, echoing, last_auto_save):
7320 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7321 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7322 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7323 (Vlispy_mouse_stem, double_click_count):
7324 Now static.
7325 (force_auto_save_soon): Define only if SIGDANGER.
7326 (ignore_mouse_drag_p): Now static if
7327 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7328 (print_help): Remove; unused.
7329 (stop_character, last_timer_event): Mark as externally visible.
7330 * keyboard.h (ignore_mouse_drag_p): Declare only if
7331 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7332 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7333 * lisp.h (echoing): Remove decl.
7334 (force_auto_save_soon): Declare only if SIGDANGER.
7335 * xdisp.c (redisplay_window): Simplify code, to make it more
7336 obvious that ignore_mouse_drag_p is not accessed if !defined
7337 USE_GTK && !defined HAVE_NS.
7338
93ea6e8f
PE
7339 * intervals.c: Make symbols static if they're not exported.
7340 (merge_properties_sticky, merge_interval_right, delete_interval):
7341 Now static.
7342 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7343
77382fcc
PE
7344 * insdel.c: Make symbols static if they're not exported.
7345 However, leave prepare_to_modify_buffer alone. It's never
7346 called from outside this function, but that appears to be a bug.
7347 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7348 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7349 (adjust_after_replace_noundo): Remove; unused.
7350 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7351 (signal_before_change): Remove decls.
77382fcc 7352
9306c32e
PE
7353 * indent.c (val_compute_motion, val_vmotion): Now static.
7354
cd44d2eb
PE
7355 * image.c: Make symbols static if they're not exported.
7356 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7357 if USE_GTK.
7358 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7359 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7360
ad9a7a06
PE
7361 * fringe.c (standard_bitmaps): Now static.
7362 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7363
81626931
PE
7364 * frame.c: Make symbols static if they're not exported.
7365 (x_report_frame_params, make_terminal_frame): Now static.
7366 (get_frame_param): Now static, unless HAVE_NS.
7367 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7368 (x_get_resource_string): Remove; not used.
7369 * frame.h (make_terminal_frame, x_report_frame_params):
7370 (x_get_resource_string); Remove decls.
7371 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7372 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7373
239f9db9
PE
7374 * font.c, fontset.c: Make symbols static if they're not exported.
7375 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7376 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7377 * font.c (font_close_object): Now static.
7378 * font.h (font_close_object): Remove.
7379 * fontset.c (FONTSET_OBJLIST): Remove.
7380 (free_realized_fontset) #if-0 the body, which does nothing.
7381 (face_suitable_for_char_p): #if-0, as it's never called.
7382 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7383 * xfaces.c (face_at_string_position):
7384 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7385 since 0 is always ASCII.
7386
dfcf3579
PE
7387 * fns.c (weak_hash_tables): Now static.
7388
5045092b
PE
7389 * fileio.c: Make symbols static if they're not exported.
7390 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7391 (Vwrite_region_annotation_buffers): Now static.
7392
57a96f5c
PE
7393 * eval.c: Make symbols static if they're not exported.
7394 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7395 * lisp.h (backtrace_list): Remove decl.
7396
35f08c38
PE
7397 * emacs.c: Make symbols static if they're not exported.
7398 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7399 (fatal_error_code, fatal_error_signal_hook, standard_args):
7400 Now static.
7401 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7402 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7403 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7404 * lisp.h (fatal_error_signal_hook): Remove decl.
7405 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7406
f44bd759
PE
7407 * editfns.c: Move a (normally-unused) function to its only use.
7408 * editfns.c, lisp.h (get_operating_system_release): Remove.
7409 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7410 worth the hassle of breaking this out.
7411
b532497d
PE
7412 * xterm.c: Make symbols static if they're not exported.
7413 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7414 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7415 (x_destroy_window, x_delete_display):
7416 Now static.
7417 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7418 (x_mouse_leave): Remove; unused.
7419 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7420 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7421 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7422 Remove decls.
7423 (x_mouse_leave): Declare only if WINDOWSNT.
7424 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7425 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7426 USE_X_TOOLKIT.
7427
1675728f
PE
7428 * ftxfont.c: Make symbols static if they're not exported.
7429 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7430 HAVE_FREETYPE.
7431 * font.h (ftxfont_driver): Likewise.
7432
e4cebfca
PE
7433 * xfns.c: Make symbols static if they're not exported.
7434 (x_last_font_name, x_display_info_for_name):
7435 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7436 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7437 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7438 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7439 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7440 (last_show_tip_args): Now static.
7441 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7442 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7443 (x_screen_planes): Remove; unused.
7444 * dispextern.h (x_screen_planes): Remove decl.
7445
5bf46f05
PE
7446 * dispnew.c: Make symbols static if they're not exported.
7447 * dispextern.h (redraw_garbaged_frames, scrolling):
7448 (increment_row_positions): Remove.
7449 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7450 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7451 Now static.
7452 (redraw_garbaged_frames): Remove; unused.
7453
435f4c28
PE
7454 * xfaces.c: Make symbols static if they're not exported.
7455 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7456 Remove decls.
7457 * xterm.h (defined_color): Remove decls.
7458 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7459 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7460 (menu_face_changed_default, defined_color, free_realized_face):
7461 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7462 (ascii_face_of_lisp_face): Remove; unused.
7463
8524aef3
PE
7464 * xdisp.c: Make symbols static if they're not exported.
7465 * dispextern.h (scratch_glyph_row, window_box_edges):
7466 (glyph_to_pixel_coords, set_cursor_from_row):
7467 (get_next_display_element, set_iterator_to_next):
7468 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7469 (show_mouse_face): Remove decls
7470 * frame.h (message_buf_print): Likewise.
7471 * lisp.h (pop_message, set_message, check_point_in_composition):
7472 Likewise.
7473 * xterm.h (set_vertical_scroll_bar): Likewise.
7474 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7475 (message_buf_print, scratch_glyph_row, displayed_buffer):
7476 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7477 (get_next_display_element, show_mouse_face, window_box_edges):
7478 (frame_to_window_pixel_xy, check_point_in_composition):
7479 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7480 (glyph_to_pixel_coords): Remove; unused.
7481
16390cd2
PE
7482 * dired.c (file_name_completion): Now static.
7483
7484 * dbusbind.c (xd_in_read_queued_messages): Now static.
7485
a25f4dfa
PE
7486 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7487 * data.c (circular_list_error): Remove.
7488
14a9c8df
PE
7489 * commands.h (last_point_position, last_point_position_buffer):
7490 (last_point_position_window): Remove decls.
7491 * keyboard.c: Make these variables static.
7492
04f2d78b
CB
7493 * coding.h (coding, code_convert_region, encode_coding_gap):
7494 Remove decls.
74ab6df5
PE
7495 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7496 (iso_code_class, detect_coding, code_convert_region): Now static.
7497 (encode_coding_gap): Remove; unused.
7498
38dfbee1
PE
7499 * chartab.c (chartab_chars, chartab_bits): Now static.
7500
a2cb4e63
PE
7501 * charset.h (charset_iso_8859_1): Remove decl.
7502 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7503 Now static.
7504
127198fd
PE
7505 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7506 * ccl.c (Vccl_program_table): Now static.
7507 (check_ccl_update): Remove; unused.
7508
d85b608f
PE
7509 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7510 * category.h: ... from here.
7511 * category.c (check_category_table, set_category_set): Now static.
7512
31cd66f3
PE
7513 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7514 * lisp.h: Remove these decls.
7515
c358e587
PE
7516 * buffer.c (buffer_count): Remove unused var.
7517
e78aecca
PE
7518 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7519 so that it's not optimized away.
7520 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7521 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7522 exported only to the debugger.
7523
e192d7d3 7524 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7525 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7526
92470028
PE
7527 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7528 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7529 was inaccessible from Lisp.
7530 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7531 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7532
244ed907
PE
7533 alloc.c: Import and export fewer symbols, and remove unused items.
7534 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7535 is defined.
7536 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7537 it's not optimized away by whole-program optimization.
7538 (message_enable_multibyte, free_misc): Remove.
7539 (catchlist, handlerlist, mark_backtrace):
7540 Declare only if BYTE_MARK_STACK.
7541 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7542 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7543 (message_enable_multibyte): Remove decl.
7544 (free_misc, interval_free_list, float_block, float_block_index):
7545 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7546 (cons_free_list, last_marked_index):
7547 Now static.
7548 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7549 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7550 (mark_backtrace): Define only if BYTE_MARK_STACK.
7551 * xdisp.c (message_enable_multibyte): Now static.
7552
61c2b50e 7553 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7554 This makes it easier for human readers (and static analyzers)
7555 to see whether these variables are used from other modules.
7556 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7557 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7558 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7559 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7560 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7561 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7562 * xmenu.c, xselect.c:
7563 Declare Q* vars static if they are not used in other modules.
7564 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7565 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7566 Remove decls of unexported vars.
7567 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7568
95c82688
PE
7569 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7570
16a97296
PE
7571 Make Emacs functions such as Fatom 'static' by default.
7572 This makes it easier for human readers (and static analyzers)
7573 to see whether these functions can be called from other modules.
7574 DEFUN now defines a static function. To make the function external
7575 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7576 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7577 (Finit_image_library):
16a97296
PE
7578 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7579 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7580 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7581 Remove decls, since these functions are now static.
7582 (Funintern, Fget_internal_run_time): New decls, since these functions
7583 were already external.
95c82688 7584
16a97296
PE
7585 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7586 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7587 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7588 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7589 * keyboard.c, keymap.c, lread.c:
7590 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7591 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7592 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7593 Mark functions with DEFUE instead of DEFUN,
7594 if they are used in other modules.
7595 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7596 decls for now-static functions.
7597 * buffer.h (Fdelete_overlay): Remove decl.
7598 * callproc.c (Fgetenv_internal): Mark as internal.
7599 * composite.c (Fremove_list_of_text_properties): Remove decl.
7600 (Fcomposition_get_gstring): New forward static decl.
7601 * composite.h (Fcomposite_get_gstring): Remove decl.
7602 * dired.c (Ffile_attributes): New forward static decl.
7603 * doc.c (Fdocumntation_property): New forward static decl.
7604 * eval.c (Ffetch_bytecode): New forward static decl.
7605 (Funintern): Remove extern decl; now in .h file where it belongs.
7606 * fileio.c (Fmake_symbolic_link): New forward static decl.
7607 * image.c (Finit_image_library): New forward static decl.
7608 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7609 * intervals.h (Fprevious_property_change):
7610 (Fremove_list_of_text_properties): Remove decls.
7611 * keyboard.c (Fthis_command_keys): Remove decl.
7612 (Fcommand_execute): New forward static decl.
7613 * keymap.c (Flookup_key): New forward static decl.
7614 (Fcopy_keymap): Now static.
7615 * keymap.h (Flookup_key): Remove decl.
7616 * process.c (Fget_process): New forward static decl.
7617 (Fprocess_datagram_address): Mark as internal.
7618 * syntax.c (Fsyntax_table_p): New forward static decl.
7619 (skip_chars): Remove duplicate decl.
7620 * textprop.c (Fprevious_property_change): New forward static decl.
7621 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7622 Now internal.
7623 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7624 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7625
785bbd42
PE
7626 * editfns.c (Fformat): Remove unreachable code.
7627
8b913b57
AS
76282011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7629
7630 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7631 change. (Bug#8496)
7632
a6744a35
EZ
76332011-04-13 Eli Zaretskii <eliz@gnu.org>
7634
7635 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7636 when at ZV. (Bug#8487)
7637
e7974947
AS
76382011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7639
baad03f0
AS
7640 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7641 (Bug#8437)
7642 * keyboard.c (parse_tool_bar_item): Likewise.
7643 * sound.c (sound_cleanup, alsa_close): Likewise.
7644 * termcap.c (tgetent): Likewise.
7645 * xfns.c (x_default_font_parameter): Likewise.
7646 * xsettings.c (read_and_apply_settings): Likewise.
7647
e7974947
AS
7648 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7649 (overrun_check_free): Protoize.
7650
28272684
PE
76512011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7652
7653 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7654 since callers should never pass a negative size.
7655 Change the signature to match that of plain 'read' and 'write'; see
7656 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7657 * lisp.h: Update prototypes of emacs_write and emacs_read.
7658
11997c76
EZ
76592011-04-11 Eli Zaretskii <eliz@gnu.org>
7660
7661 * xdisp.c (redisplay_window): Don't try to determine the character
7662 position of the scroll margin if the window start point w->startp
e896f03c 7663 is outside the buffer's accessible region. (Bug#8468)
11997c76 7664
8a2cbd72
EZ
76652011-04-10 Eli Zaretskii <eliz@gnu.org>
7666
7667 Fix write-region and its subroutines for buffers > 2GB.
7668 * fileio.c (a_write, e_write): Modify declaration of arguments and
7669 local variables to support buffers larger than 2GB.
7670 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7671
7672 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7673 argument, local variables, and return value.
7674
7675 * lisp.h: Update prototypes of emacs_write and emacs_read.
7676
7677 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7678
4073e537 76792011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7680
1ebfdcb6
PE
7681 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7682
b2ded58d
PE
7683 Fix more problems found by GCC 4.6.0's static checks.
7684
7d66342c
PE
7685 * xdisp.c (vmessage): Use a better test for character truncation.
7686
bbf47d44
PE
7687 * charset.c (load_charset_map): <, not <=, for optimization,
7688 and to avoid potential problems with integer overflow.
9248994d 7689 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7690 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7691 * editfns.c (Fformat): Likewise.
1e69125e 7692 * syntax.c (skip_chars): Likewise.
3befa583 7693
e3019616
PE
7694 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7695 This also lets GCC 4.6.0 generate slightly better loop code.
7696
becfa255
PE
7697 * callint.c (Fcall_interactively): <, not <=, for optimization.
7698 (Fcall_interactively): Count the number of arguments produced,
7699 not the number of arguments given. This is simpler and lets GCC
7700 4.6.0 generate slightly better code.
7701
dae0cd48
PE
7702 * ftfont.c: Distingish more carefully between FcChar8 and char.
7703 The previous code passed unsigned char * to a functions like
7704 strlen and xstrcasecmp that expect char *, which does not
7705 conform to the C standard.
7706 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7707 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7708 char * when the C standard requires it.
7709
76032d70
PE
7710 * keyboard.c (read_char): Remove unused var.
7711
eb3f1cc8
PE
7712 * eval.c: Port to Windows vsnprintf (Bug#8435).
7713 Include <limits.h>.
7714 (SIZE_MAX): Define if the headers do not.
7715 (verror): Do not give up if vsnprintf returns a negative count.
7716 Instead, grow the buffer. This ports to Windows vsnprintf, which
7717 does not conform to C99. Problem reported by Eli Zaretskii.
7718 Also, simplify the allocation scheme, by avoiding the need for
7719 calling realloc, and removing the ALLOCATED variable.
7720
70476b54
PE
7721 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7722
12020a9e
PE
7723 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7724 But keep the doprint source code for now, as we might revamp it
7725 and use it again (Bug#8435).
ea6c7ae6
PE
7726 * lisp.h (doprnt): Remove.
7727 * Makefile.in (base_obj): Remove doprnt.o.
7728 * deps.mk (doprnt.o): Remove.
7729
5fdb398c
PE
7730 error: Print 32- and 64-bit integers portably (Bug#8435).
7731 Without this change, on typical 64-bit hosts error ("...%d...", N)
7732 was used to print both 32- and 64-bit integers N, which relied on
7733 undefined behavior.
7734 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7735 New macro.
7736 * lisp.h (error, verror): Mark as printf-like functions.
7737 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7738 Report overflow in size calculations when allocating printf buffer.
7739 Do not truncate output string at its first null byte.
7740 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7741 Truncate the output at a character boundary, since vsnprintf does not
7742 do that.
7743 * charset.c (check_iso_charset_parameter): Convert internal
7744 character to string before calling 'error', since %c now has the
7745 printf meaning.
7746 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7747 overflow when computing char to be passed to 'error'. Do not
7748 pass Lisp_Object to 'error'; pass the integer instead.
7749 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7750 formatted with plain %d.
7751
b189fa66
PE
7752 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7753
bff87ef0
PE
7754 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7755
7e2cac20
PE
7756 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7757
ce4d90b5
PE
7758 * xterm.c (x_catch_errors): Remove duplicate declaration.
7759
266c9547
PE
7760 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7761
79c49ad2
PE
7762 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7763
368f4090
JM
77642011-04-10 Jim Meyering <meyering@redhat.com>
7765
7766 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7767 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7768 return ssize_t not "int", and use size_t as the buffer length.
7769 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7770 * gnutls.h: Update declarations.
7771 * process.c (read_process_output): Use ssize_t, to match.
7772 (send_process): Likewise.
7773
a32d4040
CY
77742011-04-09 Chong Yidong <cyd@stupidchicken.com>
7775
7776 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7777
8546720e 77782011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7779
04f2d78b
CB
7780 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7781 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7782
8546720e
GM
7783 * xterm.c (handle_one_xevent):
7784 * xmenu.c (create_and_show_popup_menu):
7785 * xselect.c (x_decline_selection_request)
7786 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7787
0a2f5c1a 77882011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7789
7790 Fix some uses of `int' instead of EMACS_INT.
7791 * search.c (string_match_1, fast_string_match)
7792 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7793 (scan_buffer, find_next_newline_no_quit)
7794 (find_before_next_newline, search_command, Freplace_match)
7795 (Fmatch_data): Make some `int' variables be EMACS_INT.
7796
7797 * xdisp.c (display_count_lines): 3rd argument and return value now
7798 EMACS_INT. All callers changed.
7799 (pint2hrstr): Last argument is now EMACS_INT.
7800
7801 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7802 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7803 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7804 (decode_coding_utf_16, decode_coding_emacs_mule)
7805 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7806 (decode_coding_ccl, decode_coding_charset)
7807 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7808 (decode_coding_iso_2022, decode_coding_emacs_mule)
7809 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7810 <char_offset, last_offset>: Declare EMACS_INT.
7811 (encode_coding_utf_8, encode_coding_utf_16)
7812 (encode_coding_emacs_mule, encode_invocation_designation)
7813 (encode_designation_at_bol, encode_coding_iso_2022)
7814 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7815 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7816 Declare EMACS_INT.
7817 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7818 (encode_invocation_designation): Last argument P_NCHARS is now
7819 EMACS_INT.
7820 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7821 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7822
7823 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7824 All users changed.
7825
7826 * ccl.c (Fccl_execute_on_string): Declare some variables
7827 EMACS_INT.
7828
8546720e 78292011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7830
7831 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7832
4e19a977
CS
78332011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7834
7835 * process.c (Fformat_network_address): Doc fix.
7836
87302331
R
78372011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7838
ee7683eb 7839 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7840
cbb59342
CY
78412011-04-08 Chong Yidong <cyd@stupidchicken.com>
7842
7843 * keyboard.c (read_char): Call Lisp function help-form-show,
7844 instead of using internal_with_output_to_temp_buffer.
7845 (Qhelp_form_show): New var.
e0d38eeb 7846 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7847
7848 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7849
7850 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7851
e67a13ab
CY
78522011-04-06 Chong Yidong <cyd@stupidchicken.com>
7853
04f2d78b
CB
7854 * process.c (Flist_processes): Remove to Lisp.
7855 (list_processes_1): Delete.
e67a13ab 7856
973f782d
EZ
78572011-04-06 Eli Zaretskii <eliz@gnu.org>
7858
7c106b1e
EZ
7859 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7860
973f782d
EZ
7861 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7862
41cf7d1a 78632011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7864
ca23cc88
PE
7865 Fix more problems found by GCC 4.6.0's static checks.
7866
f390e2d5
PE
7867 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7868
42eea0d0
PE
7869 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7870
b69769da 7871 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7872
f9541e84
PE
7873 * xdisp.c (vmessage): Mark as a printf-like function.
7874
13841b55
PE
7875 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7876
c136c10f
PE
7877 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7878
5e2d4a30
PE
7879 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7880 printf-like functions.
7881 (tiff_load): Add casts to remove these marks before passing them
7882 to system-supplied API.
7883
583f48b9
PE
7884 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7885
b25d760e
PE
7886 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7887 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7888 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7889 directly, rather than having caller test rule sign. This avoids
7890 some unnecessary tests.
7891 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7892 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7893 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7894
bc7b6697 7895 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7896 (xfont_open): Avoid unnecessary tests.
bc7b6697 7897
27ccc379
PE
7898 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7899
dcd5c89a
PE
7900 * composite.h, composite.c (composition_gstring_put_cache):
7901 Use EMACS_INT, not int, for length.
7902
b13a45c6
PE
7903 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7904 breaking out part of COMPOSITION_DECODE_RULE.
7905 (COMPOSITION_DECODE_RULE): Use it.
7906 * composite.c (get_composition_id): Remove unused local vars,
7907 by using the new macro.
7908
1e792e4d
PE
7909 * textprop.c (set_text_properties_1): Change while to do-while,
7910 since the condition is always true at first.
7911
dc6c6455 7912 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7913 (interval_deletion_adjustment): Return unsigned value.
7914 All uses changed.
dc6c6455 7915
aba7731a
PE
7916 * process.c (list_processes_1, create_pty, read_process_output):
7917 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7918 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7919 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7920 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7921 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7922
fdfc4bf3
PE
7923 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7924
fca8fe46 7925 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7926 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7927
06a0259a 7928 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7929 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7930 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7931
e7b9e80f
PE
7932 * print.c (print_error_message): Avoid int overflow.
7933
56201685
PE
7934 * font.c (font_list_entities): Redo for clarity,
7935 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7936
78834453 7937 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7938 (font_score): Avoid potential overflow in diff calculation.
78834453 7939
0bc0b309 7940 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7941 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7942
e610eaca
PE
7943 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7944
b895abce
PE
7945 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7946 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7947 can always succeed if overflow has undefined behavior.
7948
1f1d9321 7949 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7950 (wordify): Omit three unnecessary tests.
1f1d9321 7951
c59478bc
PE
7952 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7953 All callers changed. This avoids the need for an unused var.
7954
79b73827
PE
7955 * casefiddle.c (casify_region): Remove var that is set but not used.
7956
a4db5dfe
PE
7957 * dired.c (file_name_completion): Remove var that is set but not used.
7958
43aae36e
PE
7959 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7960
2a47c44d 7961 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7962 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7963
a37c69bf
PE
7964 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7965 Check for integer overflow on size calculations.
7966
328ab8e7
PE
7967 * buffer.c (Fprevious_overlay_change): Remove var that is set
7968 but not used.
7969
e5a2a5cb
PE
7970 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7971 Remove vars that are set but not used.
8d84a6eb 7972 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7973 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7974
a60e5f68
PE
7975 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7976
f661cb61 7977 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7978 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7979
f0397f5a
PE
7980 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7981 that are set but not used.
7982
8664db06 7983 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7984 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7985
6abdaa4a
PE
7986 * xselect.c (x_get_local_selection, x_handle_property_notify):
7987 Remove vars that are set but not used.
7988
0ce7538d 7989 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7990 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7991
9ae848fc
PE
7992 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7993 Remove var that is set but not used.
0b918413
PE
7994 (scroll_bar_windows_size): Now size_t, not int.
7995 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7996 Check for overflow.
9ae848fc 7997
a5a62657
PE
7998 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7999 (map_tty_color) [!defined MSDOS]: Likewise.
8000
5c5cdd39
PE
8001 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8002
66ebf983
PE
8003 * coding.c: Remove vars that are set but not used.
8004 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8005 All callers changed.
8006 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8007 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8008 (decode_coding_charset): Remove vars that are set but not used.
8009
1be4d761
PE
8010 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8011 that is set but not used.
8012
47553fa8
PE
8013 * print.c (print_object): Remove var that is set but not used.
8014
1f7196bf 8015 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8016 The gnulib version avoids calling malloc in the usual case,
8017 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8018 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8019 * filelock.c (current_lock_owner): Likewise.
8020 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8021 * sysdep.c: Include allocator.h, careadlinkat.h.
8022 (emacs_no_realloc_allocator): New static constant.
8023 (emacs_readlink): New function.
fdb61804
PE
8024 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8025 ../lib/careadlinkat.h.
d1fdcab7 8026
f84c17c7
SM
80272011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8028
8029 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8030 first non-nil return value).
8031
ef3862ad
JD
80322011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8033
8034 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8035 if not defined (Bug#8403).
8036
376a7006
JB
80372011-04-02 Juanma Barranquero <lekktu@gmail.com>
8038
8039 * xdisp.c (display_count_lines): Remove parameter `start',
8040 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8041 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8042 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8043 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8044 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8045 and thereabouts. All callers changed.
8046 (get_per_char_metric): Remove parameter `f', unused since
8047 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8048
6ca3801d
JM
80492011-04-02 Jim Meyering <meyering@redhat.com>
8050
8051 do not dereference NULL upon failed strdup
8052 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8053 (ns_get_family): Likewise.
8054
d8e2b5ba
JB
80552011-04-02 Juanma Barranquero <lekktu@gmail.com>
8056
8057 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8058
8c74fcbd
JD
80592011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8060
8061 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8062 later (Bug#8403).
8063
7200d79c
SM
80642011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8065
03408648 8066 Add lexical binding.
7200d79c 8067
03408648
SM
8068 * window.c (Ftemp_output_buffer_show): New fun.
8069 (Fsave_window_excursion):
8070 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8071
8072 * lread.c (lisp_file_lexically_bound_p): New function.
8073 (Fload): Bind Qlexical_binding.
8074 (readevalloop): Remove `evalfun' arg.
8075 Bind Qinternal_interpreter_environment.
8076 (Feval_buffer): Bind Qlexical_binding.
8077 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8078 Mark as dynamic.
8079 (syms_of_lread): Declare `lexical-binding'.
8080
8081 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8082
8083 * keyboard.c (eval_dyn): New fun.
8084 (menu_item_eval_property): Use it.
ca105506
SM
8085
8086 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8087
03408648
SM
8088 * fns.c (concat, mapcar1): Accept byte-code-functions.
8089
8090 * eval.c (Fsetq): Handle lexical vars.
8091 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8092 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8093 (FletX, Flet): Obey lexical binding.
8094 (Fcommandp): Handle closures.
8095 (Feval): New `lexical' arg.
8096 (eval_sub): New function extracted from Feval. Use it almost
8097 everywhere where Feval was used. Look up vars in lexical env.
8098 Handle closures.
8099 (Ffunctionp): Move from subr.el.
8100 (Ffuncall): Handle closures.
8101 (apply_lambda): Remove `eval_flags'.
8102 (funcall_lambda): Handle closures and new byte-code-functions.
8103 (Fspecial_variable_p): New function.
8104 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8105 but without exporting it to Lisp.
23aba0ea 8106
23aba0ea 8107 * doc.c (Fdocumentation, store_function_docstring):
03408648 8108 * data.c (Finteractive_form): Handle closures.
23aba0ea 8109
03408648
SM
8110 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8111 interactive spec.
ba83908c 8112
04f2d78b
CB
8113 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8114 New byte-codes.
03408648
SM
8115 (exec_byte_code): New function extracted from Fbyte_code to handle new
8116 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8117
03408648 8118 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8119
03408648 8120 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8121
e2abce01
JB
81222011-03-31 Juanma Barranquero <lekktu@gmail.com>
8123
8124 * xdisp.c (redisplay_internal): Fix prototype.
8125
63696a73 81262011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8127
63696a73 8128 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8129 (try_scrolling): Use it when setting scroll_limit.
8130 Limit scrolling to 100 screen lines.
63696a73
EZ
8131 (redisplay_window): Even when falling back on "recentering",
8132 position point in the window according to scroll-conservatively,
8133 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8134
8135 (try_scrolling): When point is above the window, allow searching
8136 as far as scroll_max, or one screenful, to compute vertical
8137 distance from PT to the scroll margin position. This prevents
8138 try_scrolling from unnecessarily failing when
8139 scroll-conservatively is set to a value slightly larger than the
8140 window height. Clean up the case of PT below the margin at bottom
8141 of window: scroll_max can no longer be INT_MAX. When aggressive
8142 scrolling is in use, don't let point enter the opposite scroll
8143 margin as result of the scroll.
8144 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8145 threshold of 100 lines for never-recentering scrolling.
8146
e4cc2dfc
JB
81472011-03-31 Juanma Barranquero <lekktu@gmail.com>
8148
8149 * dispextern.h (move_it_by_lines):
8150 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8151 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8152 (message_log_check_duplicate): Remove parameters `prev_bol' and
8153 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8154 (redisplay_internal): Remove parameter `preserve_echo_area',
8155 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8156
8157 * indent.c (Fvertical_motion):
8158 * window.c (window_scroll_pixel_based, Frecenter):
8159 Don't pass `need_y_p' to `move_it_by_lines'.
8160
1c470562
SM
81612011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8162
44f230aa
SM
8163 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8164 steal a few bits to be more compact.
8165 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8166 Remove unneeded casts.
8167
1c470562
SM
8168 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8169
888adce9
ZK
81702011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8171
8172 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8173 binding" message (bug#7967).
8174
f838ed7b
PE
81752011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8176
77861b95
PE
8177 Fix more problems found by GCC 4.6.0's static checks.
8178
de6dbc14
PE
8179 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8180 Remove unused local var.
8181
f838ed7b
PE
8182 * editfns.c (Fmessage_box): Remove unused local var.
8183
792c7b2b
PE
8184 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8185 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8186 Omit unused local vars.
c499e557 8187 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8188 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8189 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8190 Omit unused local var.
8191
ba0165e1
PE
8192 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8193 Don't assume string length fits in int.
32ad8845 8194 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8195 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8196
3c59b4c9
PE
8197 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8198 instead of alloca (Bug#8344).
8199
a3eed478 8200 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8201 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8202
eb4d412d
PE
8203 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8204
1658b401
PE
8205 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8206 concerns.
8207
8208 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8209
8210 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8211
9a2c6e05
PE
8212 * keyboard.c (syms_of_keyboard): Use the same style as later
8213 in this function when indexing through an array. This also
8214 works around GCC bug 48267.
8215
03d0a109
PE
8216 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8217
44f730c8
PE
8218 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8219
fe75f926
PE
8220 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8221 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8222
ffa8c828
PE
8223 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8224 This avoids undefined behavior on integer overflow, and is a bit
8225 more convenient anyway since it is compared to a size_t variable.
8226
c5101a77
PE
8227 Variadic C functions now count arguments with size_t, not int.
8228 This avoids an unnecessary limitation on 64-bit machines, which
8229 caused (substring ...) to crash on large vectors (Bug#8344).
8230 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8231 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8232 All variadic functions and their callers changed accordingly.
c5101a77
PE
8233 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8234 * data.c (arith_driver, float_arith_driver): Likewise.
8235 * editfns.c (general_insert_function): Likewise.
8236 * eval.c (struct backtrace.nargs, interactive_p)
8237 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8238 (funcall_lambda, mark_backtrace): Likewise.
8239 * fns.c (concat): Likewise.
8240 * frame.c (x_set_frame_parameters): Likewise.
8241 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8242 0 if not found, not -1. All callers changed.
8243
dd3f25f7
PE
8244 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8245 (stack_copy_size): Now size_t, not int.
8246 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8247
461c2ab9
JB
82482011-03-28 Juanma Barranquero <lekktu@gmail.com>
8249
8250 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8251 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8252 All callers changed.
8253
8254 * lisp.h (multibyte_char_to_unibyte):
8255 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8256 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8257 * character.h (CHAR_TO_BYTE8):
8258 * cmds.c (internal_self_insert):
8259 * editfns.c (general_insert_function):
8260 * keymap.c (push_key_description):
8261 * search.c (Freplace_match):
8262 * xdisp.c (message_dolog, set_message_1): All callers changed.
8263
f6d62986
SM
82642011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8265
8266 * keyboard.c (safe_run_hook_funcall): New function.
8267 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8268 don't set the hook to nil, but remove the offending function instead.
8269 (Qcommand_hook_internal): Remove, unused.
8270 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8271 Vcommand_hook_internal.
8272
8273 * eval.c (enum run_hooks_condition): Remove.
8274 (funcall_nil, funcall_not): New functions.
8275 (run_hook_with_args): Call each function through a `funcall' argument.
8276 Remove `cond' argument, now redundant.
8277 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8278 (Frun_hook_with_args_until_failure): Adjust accordingly.
8279 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8280
1db5b1ad
JB
82812011-03-28 Juanma Barranquero <lekktu@gmail.com>
8282
8283 * dispextern.h (string_buffer_position): Remove declaration.
8284
8285 * print.c (strout): Remove parameter `multibyte', unused since
8286 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8287
8288 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8289 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8290 All callers changed.
8291
8292 * w32.c (_wsa_errlist): Use braces for struct initializers.
8293
8294 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8295 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8296 All callers changed.
8297 (string_buffer_position): Likewise. Also, make static (it's never
8298 used outside xdisp.c).
8299 (cursor_row_p): Remove parameter `w', unused since
8300 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8301 (decode_mode_spec): Remove parameter `precision', introduced during
8302 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8303 All callers changed.
8304
5ffb62aa
JD
83052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8306
8307 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8308
461c2ab9 83092011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8310
8311 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8312 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8313 (ns_update_auto_hide_menu_bar): New functions.
8314 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8315 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8316 ns_constrain_all_frames.
8317 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8318 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8319
5c380ffb
JD
83202011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8321
8322 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8323
9af30bdf
GM
83242011-03-27 Glenn Morris <rgm@gnu.org>
8325
8326 * syssignal.h: Replace RETSIGTYPE with void.
8327 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8328 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8329 Replace SIGTYPE with void everywhere.
8330 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8331 * s/template.h (SIGTYPE): Remove commented out definition.
8332
e2abce01
JB
83332011-03-26 Eli Zaretskii <eliz@gnu.org>
8334
8335 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8336 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8337
f868cd8a
JB
83382011-03-26 Juanma Barranquero <lekktu@gmail.com>
8339
59eb0929
JB
8340 * w32.c (read_unc_volume): Use parameter `henum', instead of
8341 global variable `wget_enum_handle'.
8342
8343 * keymap.c (describe_vector): Remove parameters `indices' and
8344 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8345 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8346
f868cd8a
JB
8347 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8348
8349 * keyboard.c (timer_check): Remove parameter `do_it_now',
8350 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8351 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8352 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8353
8354 * keyboard.c (read_char):
8355 * w32menu.c (w32_menu_display_help):
8356 * xmenu.c (show_help_event, menu_help_callback):
8357 Adjust calls to `show_help_echo'.
8358
8359 * gtkutil.c (xg_maybe_add_timer):
8360 * keyboard.c (readable_events):
8361 * process.c (wait_reading_process_output):
8362 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8363
8364 * insdel.c (adjust_markers_gap_motion):
8365 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8366 (gap_left, gap_right): Don't call it.
8367
2ecf6fdb
CY
83682011-03-25 Chong Yidong <cyd@stupidchicken.com>
8369
8370 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8371 incurred during fontification.
8372
6b1f9ba4
JB
83732011-03-25 Juanma Barranquero <lekktu@gmail.com>
8374
8375 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8376 (DEFVAR_PER_BUFFER): Don't pass it.
8377
8378 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8379 (scrolling_window): Don't pass it.
8380
0f4a96b5
JB
83812011-03-25 Juanma Barranquero <lekktu@gmail.com>
8382
8383 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8384
8385 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8386 and `suffix'.
8387 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8388 of variables specific to SELinux and computation of `encoded_absname'.
8389
8390 * image.c (XPutPixel): Remove unused variable `height'.
8391
8392 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8393
8394 * unexw32.c (get_section_info): Remove unused variable `section'.
8395
8396 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8397 (system_process_attributes): Remove unused variable `sess'.
8398 (sys_read): Remove unused variable `err'.
8399
8400 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8401 (w32_wnd_proc): Remove unused variable `isdead'.
8402 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8403 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8404 (x_create_tip_frame): Remove unused variable `tem'.
8405
8406 * w32inevt.c (w32_console_read_socket):
8407 Remove unused variable `no_events'.
8408
8409 * w32term.c (x_draw_composite_glyph_string_foreground):
8410 Remove unused variable `width'.
8411
1149507c
JB
84122011-03-24 Juanma Barranquero <lekktu@gmail.com>
8413
8414 * w32term.c (x_set_glyph_string_clipping):
8415 Don't pass uninitialized region to CombineRgn.
8416
9c88f339
JB
84172011-03-23 Juanma Barranquero <lekktu@gmail.com>
8418
8419 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8420 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8421 (Fx_close_connection): Remove unused variable `i'.
8422
8423 * w32font.c (w32font_draw): Return number of glyphs.
8424 (w32font_open_internal): Remove unused variable `i'.
8425 (w32font_driver): Add missing initializer.
8426
8427 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8428 (fill_in_menu): Remove unused variable `items_added'.
8429
8430 * w32term.c (last_mouse_press_frame): Remove static global variable.
8431 (w32_clip_to_row): Remove unused variable `f'.
8432 (x_delete_terminal): Remove unused variable `i'.
8433
8434 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8435 (NOTHING): Remove unused static global variable.
8436 (uniscribe_check_otf): Remove unused variable `table'.
8437 (uniscribe_font_driver): Add missing initializers.
8438
dee091a3
JD
84392011-03-23 Julien Danjou <julien@danjou.info>
8440
8441 * term.c (Fsuspend_tty, Fresume_tty):
8442 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8443 * window.c (temp_output_buffer_show):
8444 * insdel.c (signal_before_change):
8445 * frame.c (Fhandle_switch_frame):
8446 * fileio.c (Fdo_auto_save):
8447 * emacs.c (Fkill_emacs):
8448 * editfns.c (save_excursion_restore):
8449 * cmds.c (internal_self_insert):
8450 * callint.c (Fcall_interactively):
8451 * buffer.c (Fkill_all_local_variables):
8452 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8453 Use Frun_hooks.
0f4a96b5 8454 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8455 unconditionally since it does the check itself.
dee091a3 8456
2c520ab5 84572011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8458
c9c49752
PE
8459 Fix more problems found by GCC 4.5.2's static checks.
8460
8abc3f12
PE
8461 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8462 the first time through the loop, since we know p0 < p1 then.
8463 This also avoids a gcc -Wstrict-overflow warning.
8464
a2d26660
PE
8465 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8466 leading to a memory leak, possible in functions like
8467 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8468 of objects (Bug#8318).
a2d26660 8469
916c72e9
PE
8470 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8471 that could (at least in theory) be that large.
8472
19ab8a18
PE
8473 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8474 This is less likely to overflow, and avoids undefined behavior if
8475 overflow does occur. All callers changed. Use strtoul to scan
8476 for the unsigned long integer.
b7cbbd6f
PE
8477 (pint2hrstr): Simplify and tune code slightly.
8478 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8479
f0641eff
PE
8480 * scroll.c (do_scrolling): Work around GCC bug 48228.
8481 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8482
7f650bb9
PE
8483 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8484 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8485 (validate_x_resource_name): Simplify count usage.
8486 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8487
37dd57d1
PE
8488 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8489 fail (Bug#8306).
81e56e61 8490
699979fc 8491 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8492
401bf9b4
PE
8493 * process.c (Fmake_network_process): Use socklen_t, not int,
8494 where POSIX says socklen_t is required in portable programs.
8495 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8496 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8497 (Fmake_network_process, server_accept_connection):
8498 (wait_reading_process_output, read_process_output):
8499 Likewise.
8500
b93aacde
PE
8501 * process.c: Rename or move locals to avoid shadowing.
8502 (list_processes_1, Fmake_network_process):
8503 (read_process_output_error_handler, exec_sentinel_error_handler):
8504 Rename or move locals.
4dc343ee 8505 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8506 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8507 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8508 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8509 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8510
af8a867c 8511 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8512 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8513 Include tparam.h instead, since it declares them.
af8a867c
PE
8514 * cm.h (PC): Remove extern decl; tparam.h now does this.
8515 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8516 * terminfo.c: Include tparam.h, to check interfaces.
8517 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8518 (tparam): Adjust signature to match interface in tparam.h;
8519 this removes some undefined behavior. Check that outstring and len
8520 are zero, which they always are with Emacs.
8521 * tparam.h (PC, BC, UP): New extern decls.
8522
0248044d 8523 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8524 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8525
8ff096c1 8526 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8527 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8528 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8529 (ftfont_list): Remove unused local.
49eaafba
PE
8530 (get_adstyle_property, ftfont_pattern_entity):
8531 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8532 Rename locals to avoid shadowing.
8ff096c1 8533
e2be39f6
PE
8534 * xfont.c (xfont_list_family): Mark var as initialized.
8535
c9735e30
PE
8536 * xml.c (make_dom): Now static.
8537
8f5201ae
PE
8538 * composite.c (composition_compute_stop_pos): Rename local to
8539 avoid shadowing.
b246f932
PE
8540 (composition_reseat_it): Remove unused locals.
8541 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8542 (composition_update_it): Mark var as initialized.
11b61122
PE
8543 (find_automatic_composition): Mark vars as initialized,
8544 with a FIXME (Bug#8290).
8f5201ae 8545
760fbc2c
PE
8546 character.h: Rename locals to avoid shadowing.
8547 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8548 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8549 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8550 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8551 to avoid shadowing.
8552
ff08eb85
PE
8553 * textprop.c (property_change_between_p): Remove; unused.
8554
fc7bf025
PE
8555 * intervals.c (interval_start_pos): Now static.
8556
235d7abc
PE
8557 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8558
44f230aa
SM
8559 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8560 Rename locals to avoid shadowing.
3e7d6594 8561
50060332
PE
8562 * sound.c (wav_play, au_play, Fplay_sound_internal):
8563 Fix pointer signedness.
d01f234b 8564 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8565 (wav_play): Initialize a variable to 0, to prevent undefined
8566 behavior (Bug#8278).
50060332 8567
c4fc4e30
PE
8568 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8569
918436ed
PE
8570 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8571
c939f91b
PE
8572 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8573 clobbering (Bug#8298).
b9c7f648
PE
8574 * sysdep.c (sys_subshell): Likewise.
8575 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8576
6bd8c144
PE
8577 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8578 This should get cleaned up, so that child_setup has the
8579 same signature on all platforms.
8580
7710357c 8581 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8582 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8583
c59da222
CY
85842011-03-22 Chong Yidong <cyd@stupidchicken.com>
8585
8586 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8587 not to be necessary, and produces flickering.
8588
66b87493
GM
85892011-03-20 Glenn Morris <rgm@gnu.org>
8590
8591 * config.in: Remove file.
8592
45b6f6d5
JB
85932011-03-20 Juanma Barranquero <lekktu@gmail.com>
8594
8595 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8596 are now in src/globals.h.
8597 (syms_of_minibuf): Remove spurious & from previous change.
8598
cd394be1 85992011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8600
8601 * minibuf.c (completing-read-function): New variable.
8602 (completing-read-default): Rename from completing-read.
8603 (completing-read): Call completing-read-function.
8604
b14e3e21
CY
86052011-03-19 Juanma Barranquero <lekktu@gmail.com>
8606
8607 * xfaces.c (Fx_load_color_file):
8608 Read color file from absolute filename (bug#8250).
8609
f2b726e6
JB
86102011-03-19 Juanma Barranquero <lekktu@gmail.com>
8611
8612 * makefile.w32-in: Update dependencies.
8613
09f6ff02
EZ
86142011-03-17 Eli Zaretskii <eliz@gnu.org>
8615
8616 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8617
29a6015a
PE
86182011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8619
a3a6c54e
PE
8620 Fix more problems found by GCC 4.5.2's static checks.
8621
b766f867
PE
8622 * process.c (make_serial_process_unwind, send_process_trap):
8623 (sigchld_handler): Now static.
8624
be02381c
PE
8625 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8626 That way, the code declares only the vars that it needs.
8627 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8628 * s/cygwin.h (PTY_ITERATION): Likewise.
8629 * s/darwin.h (PTY_ITERATION): Likewise.
8630 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8631
57048744
PE
8632 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8633 * process.c (allocate_pty): Don't declare stb unless it's needed.
8634
7914961c 8635 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8636 (CONSTANTLIM): Remove; unused.
8637 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8638 Define only if needed.
7914961c 8639
b3967b18
PE
8640 * unexelf.c (unexec): Name an expression,
8641 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8642 Use a different way to cause a compilation error if anyone uses
8643 n rather than nn, a way that does not involve shadowing.
73366a00 8644 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8645
29a6015a
PE
8646 * deps.mk (unexalpha.o): Remove; unused.
8647
43cfc33e 8648 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8649 * unexec.h: New file.
ce701a33
PE
8650 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8651 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8652 Depend on unexec.h.
8653 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8654 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8655 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8656 Change as necessary to match prototype in unexec.h.
ce701a33 8657
01f44d5a
PE
8658 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8659 shadowing.
4f63c6bb 8660 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8661
a6670b0b
PE
8662 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8663 Rename locals to avoid shadowing.
8664
cef2010d 8665 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8666 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8667
d4d7173a
PE
8668 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8669
f08b802a
PE
8670 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8671 warning when compiling print.c.
8672
3ddb0639
PE
8673 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8674 instead of using an uninitialized var.
5ad03b97 8675 (font_sort_entities): Mark var as initialized.
3ddb0639 8676
170a2692
PE
8677 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8678
e663c700
PE
8679 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8680 pointers to constants.
89bc529a 8681 (font_parse_fcname): Remove unused vars.
7b81e2d0 8682 (font_delete_unmatched): Now static.
ea838e10 8683 (font_get_spec): Remove; unused.
13a547c6
PE
8684 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8685 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8686 Rename or move locals to avoid shadowing.
e663c700 8687
2a80c887 8688 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8689 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8690
1384fa33 8691 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8692 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8693
8b2c52e9
PE
8694 * alloc.c (mark_backtrace): Move decl from here ...
8695 * lisp.h: ... to here, so that it can be checked.
8696
475545b5 8697 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8698 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8699 (lisp_indirect_variable): Name an expression,
8700 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8701 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8702
b1349114 8703 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8704 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8705 Use const pointer when appropriate.
b1349114 8706
a2928364
PE
8707 * lisp.h (get_system_name, get_operating_system_release):
8708 Move decls here, to check interfaces.
8709 * process.c (get_operating_system_release): Move decl to lisp.h.
8710 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8711 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8712 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8713 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8714 (Fformat_time_string, Fencode_time, Finsert_char):
8715 (Ftranslate_region_internal, Fformat):
8716 Rename or remove local vars to avoid shadowing.
9710023e 8717 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8718
a415e694
PE
8719 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8720 avoid shadowing.
8721
8ef4622d
PE
8722 * lisp.h (eassert): Check that the argument compiles, even if
8723 ENABLE_CHECKING is not defined.
8724
946f9a5b
PE
8725 * data.c (Findirect_variable): Name an expression, to avoid
8726 gcc -Wbad-function-cast warning.
112396d6 8727 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8728 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8729 (Fmake_variable_buffer_local, Fmake_local_variable):
8730 Mark variables as initialized.
52746918 8731 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8732
e5aab7e7 8733 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8734 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8735 Rename locals to avoid shadowing.
dff45157
PE
8736 (mark_stack): Move local variables into the #ifdef region where
8737 they're used.
7bc26fdb
PE
8738 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8739 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8740 needed otherwise.
8741 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8742 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8743 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8744
e5aab7e7
PE
8745 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8746 avoids undefined behavior in theory.
8747
4da60324
PE
8748 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8749
88043301
PE
8750 Use functions, not macros, for up- and down-casing (Bug#8254).
8751 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8752 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8753 to use the following functions instead of these macros.
8754 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8755 EMACS_INT, since callers assume the returned value fits in int.
8756 (upcase1): Likewise, for UPCASE_TABLE.
8757 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8758 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8759 the race-condition problem in the old DOWNCASE.
88043301 8760
19ed5445
PE
8761 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8762 Rename locals to avoid shadowing.
8763 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8764 (regex_compile, re_search_2, re_match_2_internal):
8765 Remove unused local vars.
952db0d7
PE
8766 (FREE_VAR): Rewrite so as not to use empty "else",
8767 which gcc can warn about.
da053e48 8768 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8769 (RETALLOC_IF): Define only if needed.
8770 (WORDCHAR_P): Likewise. This one is never needed, but is used
8771 only in a comment talking about a compiler bug, so put inside
8772 the #if 0 of that comment.
8773 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8774 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8775 Remove; unused.
19ed5445 8776
1f3561e4 8777 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8778 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8779 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8780
ded6f8f7
PE
8781 * search.c (simple_search): Remove unused var.
8782
dbd37a95
PE
8783 * dired.c (compile_pattern): Move decl from here ...
8784 * lisp.h: ... to here, so that it can be checked.
8785 (struct re_registers): New forward decl.
8786
7e47afad
PE
8787 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8788
85f24f61
PE
8789 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8790 All uses changed.
8791 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8792 Rename locals to avoid shadowing.
5671df8f 8793 (Fvertical_motion): Mark locals as initialized.
85f24f61 8794
181aa2be 8795 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8796 (casify_region): Mark local as initialized.
181aa2be 8797
930d429c
PE
8798 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8799
7082eac6
PE
8800 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8801 New macros, so that the caller can use some names other than
8802 gcpro1, gcpro2, etc.
8803 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8804 of the new macros.
8805 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8806 argument, for consistency with GCPRO2_VAR, etc: it is now the
8807 prefix of the variable, not the variable itself. All uses
8808 changed.
38b2c076
PE
8809 * dired.c (directory_files_internal, file_name_completion):
8810 Rename locals to avoid shadowing.
8811
15206ed9
PE
8812 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8813 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8814 dired.c's scmp function, had undefined behavior.
8815 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8816 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8817 * buffer.h: ... to here, because these macros use current_buffer,
8818 and the new implementation with inline functions needs to have
8819 current_buffer in scope now, rather than later when the macros
8820 are used.
8821 (downcase, upcase1): New static inline functions.
8822 (DOWNCASE, UPCASE1): Reimplement using these functions.
8823 This avoids undefined behavior in expressions like
8824 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8825 from race conditions in accessing the global variables
8826 case_temp1 and case_temp2.
8827 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8828 * lisp.h (case_temp1, case_temp2): Remove their decls.
8829 * character.h (ASCII_CHAR_P): Move from here ...
8830 * lisp.h: ... to here, so that the inline functions mentioned
8831 above can use them.
8832
4a6bea26
PE
8833 * dired.c (directory_files_internal_unwind): Now static.
8834
f14b7e14
PE
8835 * fileio.c (file_name_as_directory, directory_file_name):
8836 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8837 Now static.
2893f146
PE
8838 (file_name_as_directory): Use const pointers when appropriate.
8839 (Fexpand_file_name): Likewise. In particular, newdir might
8840 point at constant storage, so make it a const pointer.
fd4ead52 8841 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8842 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8843 signedness issues.
f839df0c
PE
8844 (Fset_file_times, Finsert_file_contents, auto_save_error):
8845 Rename locals to avoid shadowing.
f14b7e14 8846
5716756e 8847 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8848 (Ftry_completion, Fall_completions): Rename or remove locals
8849 to avoid shadowing.
5716756e 8850
b4c3046a
PE
8851 * marker.c (bytepos_to_charpos): Remove; unused.
8852
b45db522
PE
8853 * lisp.h (verify_bytepos, count_markers): New decls,
8854 so that gcc does not warn that these functions aren't declared.
8855
85876d07
PE
8856 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8857 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8858 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8859 (copy_text): Remove unused local var.
85876d07 8860
03d78a21 8861 * filelock.c (within_one_second): Now static.
b3dd38ab 8862 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8863
5df8f01b
PE
8864 * buffer.c (fix_overlays_before): Mark locals as initialized.
8865 (fix_start_end_in_overlays): Likewise. This function should be
8866 simplified by using pointers-to-pointers, but that's a different
8867 matter.
b1d876f1 8868 (switch_to_buffer_1): Now static.
8f54f30a
PE
8869 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8870 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8871
a70072c9 8872 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8873 Fix pointer signedness issue.
edced198
PE
8874 (sys_subshell): Mark local as volatile if checking for lint,
8875 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8876 (MAXPATHLEN): Define only if needed.
a70072c9 8877
a0977c44
PE
8878 * process.c (serial_open, serial_configure): Move decls from here ...
8879 * systty.h: ... to here, so that they can be checked.
8880
a884fdcc
PE
8881 * fns.c (get_random, seed_random): Move extern decls from here ...
8882 * lisp.h: ... to here, so that they can be checked.
8883
604efe86 8884 * sysdep.c (reset_io): Now static.
b8950c94 8885 (wait_for_termination_signal): Remove; unused.
604efe86 8886
38fc62d9
PE
8887 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8888 (copy_keymap_item, append_key, push_text_char_description):
8889 Now static.
1004a21a 8890 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8891 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8892 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8893 (describe_map_tree):
8894 Rename locals to avoid shadowing.
38fc62d9 8895
2f2650da
PE
8896 * keyboard.c: Declare functions static if they are not used elsewhere.
8897 (echo_char, echo_dash, cmd_error, top_level_2):
8898 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8899 (read_char, kbd_buffer_get_event, make_lispy_position):
8900 (make_lispy_event, make_lispy_movement, apply_modifiers):
8901 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8902 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8903 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8904 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8905 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8906
a053e86c 8907 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8908 (mark_kboards): Move decl here ...
8909 * alloc.c (mark_kboards): ... from here.
a053e86c 8910
4752793e
PE
8911 * lisp.h (force_auto_save_soon): New decl.
8912
74f10ca7 8913 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8914 (DEFINE_DUMMY_FUNCTION): New macro.
8915 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8916 Use it.
c03cd23f
PE
8917 (main): Add casts to avoid warnings
8918 if GCC considers string literals to be constants.
74f10ca7 8919
022e70d4
PE
8920 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8921
59d6fe83
PE
8922 * dbusbind.c: Pointer signedness fixes.
8923 (xd_signature, xd_append_arg, xd_initialize):
8924 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8925 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8926 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8927 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8928
78320123
PE
8929 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8930 if GCC considers string literals to be constants.
49cebcca 8931 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8932
35ac2a97
SM
89332011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8934
fb103ca9
SM
8935 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8936 (print_preprocess, print_object): New macro to fix last change.
8937
35ac2a97
SM
8938 * print.c (print_preprocess): Don't forget font objects.
8939
62973b41
JB
89402011-03-16 Juanma Barranquero <lekktu@gmail.com>
8941
8942 * emacs.c (USAGE3): Doc fixes.
8943
0e48bb22
AS
89442011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8945
8946 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8947 structure.
8948
7684e57b
JB
89492011-03-14 Juanma Barranquero <lekktu@gmail.com>
8950
8951 * lisp.h (VWindow_system, Qfile_name_history):
8952 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8953 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8954 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8955
8956 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8957 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8958
8959 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8960 * w32console.c (detect_input_pending, read_input_pending)
8961 (encode_terminal_code):
8962 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8963 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8964 (w32_system_caret_y, Qfile_name_history):
8965 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8966 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8967 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8968 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8969 * w32proc.c (Qlocal, report_file_error):
8970 * w32term.c (Vwindow_system, updating_frame):
8971 * w32uniscribe.c (initialized, uniscribe_font_driver):
8972 Remove unneeded extern declarations.
8973
2aa46d6c
CY
89742011-03-14 Chong Yidong <cyd@stupidchicken.com>
8975
c96bbc66 8976 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8977
cffc6f3b
CY
89782011-03-13 Chong Yidong <cyd@stupidchicken.com>
8979
8980 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8981 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8982 These macros can no longer be used for assignment.
8983
44f230aa
SM
8984 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8985 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8986 (record_buffer_markers, fetch_buffer_markers): New functions for
8987 recording and fetching special buffer markers.
8988 (set_buffer_internal_1, set_buffer_temp): Use them.
8989
8990 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8991
8992 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8993
8994 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8995 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8996
8997 * xdisp.c (hscroll_window_tree):
8998 (reconsider_clip_changes): Use PT instead of BUF_PT.
8999
d251f04b
EZ
90002011-03-13 Eli Zaretskii <eliz@gnu.org>
9001
9002 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9003 $(EMACS_ROOT)/lib/intprops.h.
9004
f0c77cd1
PE
90052011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9006
3eca4629
PE
9007 Fix more problems found by GCC 4.5.2's static checks.
9008
7c86ee98
PE
9009 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9010 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9011 (xg_free_frame_widgets): Make it clear that a local variable is
9012 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9013 (gdk_window_get_screen): Make it clear that this macro is needed
9014 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9015 (int_gtk_range_get_value): New function, which avoids a diagnostic
9016 from gcc -Wbad-function-cast.
9017 (xg_set_toolkit_scroll_bar_thumb): Use it.
9018 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9019 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9020 (get_utf8_string, xg_get_file_with_chooser):
9021 Rename locals to avoid shadowing.
9022 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9023
41729b81
PE
9024 * xgselect.c (xg_select): Remove unused var.
9025
f0c77cd1
PE
9026 * image.c (four_corners_best): Mark locals as initialized.
9027 (gif_load): Initialize transparent_p to zero (Bug#8238).
9028 Mark another local as initialized.
ec6cf4c6 9029 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9030
ce0ad53d 9031 * image.c (clear_image_cache): Now static.
d5d5a617 9032 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9033 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9034 (x_edge_detection): Remove unnecessary cast that
9035 gcc -Wbad-function-cast diagnoses.
2037898d 9036 (gif_load): Fix pointer signedness.
6ae141d6
PE
9037 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9038 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9039
33383987 90402011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9041
d32df629
PE
9042 Improve quality of tests for time stamp overflow.
9043 For example, without this patch (encode-time 0 0 0 1 1
9044 1152921504606846976) returns the obviously-bogus value (-948597
9045 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9046 reports time overflow. See
9047 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9048 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9049 * editfns.c: Include limits.h and intprops.h.
9050 (TIME_T_MIN, TIME_T_MAX): New macros.
9051 (time_overflow): Move earlier, to before first use.
9052 (hi_time, lo_time): New functions, for an accurate test for
9053 out-of-range times.
9054 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9055 (Fget_internal_run_time): Don't assume time_t fits in int.
9056 (make_time): Use list2 instead of Fcons twice.
9057 (Fdecode_time): More accurate test for out-of-range times.
9058 (check_tm_member): New function.
9059 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9060 (lisp_time_argument): Don't rely on undefined left-shift and
9061 right-shift behavior when checking for time stamp overflow.
8be6f318 9062
fe31d94c
PE
9063 * editfns.c (time_overflow): New function, refactoring common code.
9064 (Fformat_time_string, Fdecode_time, Fencode_time):
9065 (Fcurrent_time_string): Use it.
9066
8be6f318
PE
9067 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9068 * dired.c (make_time): Move to ...
9069 * editfns.c (make_time): ... here.
9070 * systime.h: Note the move.
9071
09d9db2c 90722011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9073
126bc0dc
YM
9074 * fringe.c (update_window_fringes): Remove unused variables.
9075
c47cbdfd
YM
9076 * unexmacosx.c (copy_data_segment): Also copy __got section.
9077 (Bug#8223)
9078
7ac80be9
EZ
90792011-03-12 Eli Zaretskii <eliz@gnu.org>
9080
c96bbc66 9081 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9082 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9083 Constify `char *' arguments and their references according to
9084 prototypes in tparam.h.
9085
ecb0f94d 9086 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9087
7ac80be9
EZ
9088 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9089 Adapt all references accordingly.
9090
9091 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9092
ef1fd07e
TT
90932011-03-11 Tom Tromey <tromey@redhat.com>
9094
9095 * buffer.c (syms_of_buffer): Remove obsolete comment.
9096
7ef4b50c
EZ
90972011-03-11 Eli Zaretskii <eliz@gnu.org>
9098
9099 * termhooks.h (encode_terminal_code): Declare prototype.
9100
9101 * msdos.c (encode_terminal_code): Don't declare prototype.
9102
9103 * term.c (encode_terminal_code): Now external again, used by
9104 w32console.c and msdos.c.
9105
44f230aa
SM
9106 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9107 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9108
4b1ec863 91092011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9110
1714f52b 9111 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9112
4b1ec863
PE
9113 * fringe.c (update_window_fringes): Mark locals as initialized
9114 (Bug#8227).
9115 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9116
524c7aa6
PE
9117 * alloc.c (mark_fringe_data): Move decl from here ...
9118 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9119 to check its interface.
9120 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9121
a5c0af81 9122 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9123 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9124 (fontset_font): Mark local as initialized.
a9a06e0b 9125 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9126
b4716021
PE
9127 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9128
811e9bac 9129 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9130 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9131 (x_own_selection, Fx_disown_selection_internal): Rename locals
9132 to avoid shadowing.
9133 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9134
7e3ab302
PE
9135 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9136 so that the caller can use some name other than gcpro1.
9137 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9138 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9139 (Fx_backspace_delete_keys_p):
9140 Use them to avoid shadowing, and rename vars to avoid shadowing.
9141 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9142 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9143 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9144 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9145 Remove unused locals.
7e3ab302
PE
9146 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9147 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9148 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9149 macros.
f78faa98 9150
e2b13473
PE
9151 * xterm.h (x_mouse_leave): New decl.
9152
77f23912
PE
9153 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9154 Remove unused functions.
cdf4ba58
PE
9155 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9156 (x_calc_absolute_position): Now static.
7411c686 9157 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9158 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9159 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9160 unless they are used.
38d0b34a
PE
9161 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9162 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9163 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9164 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9165 (x_error_catcher, x_connection_closed, x_error_handler):
9166 (x_error_quitter, xembed_send_message, x_iconify_frame):
9167 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9168 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9169 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9170
44f230aa
SM
9171 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9172 Rename or move locals to avoid shadowing.
6b463e58 9173 (tty_defined_color, merge_face_heights): Now static.
5967d051 9174 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9175 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9176 does not deduce is never used uninitialized.
73719eba
PE
9177 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9178 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9179
426994c3 9180 * terminal.c (store_terminal_param): Now static.
5489860b 9181
032f1620 9182 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9183 (set_frame_menubar): Remove unused local.
d4323972 9184 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9185 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9186 since they might point to immutable storage.
281585b0
PE
9187 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9188 since it's unused otherwise.
032f1620 9189
367c19e5 9190 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9191 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9192 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9193 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9194 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9195 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9196 does not deduce are never used uninitialized.
70739cbe 9197
07b48fa9
PE
9198 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9199
8868a238 9200 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9201 * window.c (window_loop, size_window):
9202 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9203
7e5cf297 9204 * window.c (display_buffer): Now static.
d6550a9f
PE
9205 (size_window): Mark variables that gcc -Wuninitialized
9206 does not deduce are never used uninitialized.
a586633d
PE
9207 * window.h (check_all_windows): New decl, to forestall
9208 gcc -Wmissing-prototypes diagnostic.
5b555da1 9209 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9210
f6095868
PE
9211 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9212 shadowing.
9213 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9214 Include <limits.h>.
9215 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9216 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9217 (load_charset_map): Mark variables that gcc -Wuninitialized
9218 does not deduce are never used uninitialized.
53df7c11 9219 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9220
f38b440c
PE
9221 * coding.c (coding_set_source, coding_set_destination):
9222 Use "else { /* comment */ }" rather than "else /* comment */;"
9223 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9224 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9225 a block, when the outer 'i' will do.
9226 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9227 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9228 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9229 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9230 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9231 Rename locals to avoid shadowing.
9232 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9233 * coding.c (emacs_mule_char, encode_invocation_designation):
9234 Now static, since they're not used elsewhere.
413bb2db 9235 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9236 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9237 (decode_coding_emacs_mule): Mark variables that gcc
9238 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9239 (detect_coding_iso_2022): Initialize a local variable that might
9240 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9241 this initialization is needed. (Bug#8211)
5f58e762
PE
9242 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9243 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9244 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9245 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9246 Remove unused macros.
f38b440c 9247
232b38b9 9248 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9249 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9250 * character.c (string_count_byte8): Likewise.
232b38b9 9251
fb90da1b
PE
9252 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9253 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9254
fb93dbc2
PE
9255 * chartab.c (copy_sub_char_table): Now static, since it's not used
9256 elsewhere.
5c156ace
PE
9257 (sub_char_table_ref_and_range, char_table_ref_and_range):
9258 Rename locals to avoid shadowing.
bbcd0949 9259 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9260
7d3b3862 9261 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9262 (BIDI_BOB): Remove unused macro.
7d3b3862 9263
6be7d3da
PE
9264 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9265 deduce are never used uninitialized.
c2ed9c8b 9266 * term.c (encode_terminal_code): Likewise.
6be7d3da 9267
75f8807f 9268 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9269
50938595
PE
9270 * tparam.h: New file.
9271 * term.c, tparam.h: Include it.
9272 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9273 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9274 Move these decls to tparam.h, and make them agree with what
9275 is actually in tparam.c. The previous trick of using incompatible
9276 decls in different modules does not conform to the C standard.
9277 All callers of tparam changed to use tparam's actual API.
9278 * tparam.c (tparam1, tparam, tgoto):
9279 Use const pointers where appropriate.
9280
fbceeba2
PE
9281 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9282 * cm.h (struct cm): Likewise.
9283 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9284 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9285 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9286 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9287 (turn_on_face, init_tty): Likewise.
9288 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9289
7f3f1250
PE
9290 * term.c (term_mouse_position): Rename local to avoid shadowing.
9291
e6ca6543
PE
9292 * alloc.c (mark_ttys): Move decl from here ...
9293 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9294
c40f8d15
AS
92952011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9296
9297 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9298
cfe0661d
JB
92992011-03-09 Juanma Barranquero <lekktu@gmail.com>
9300
9301 * search.c (compile_pattern_1): Remove argument regp, unused since
9302 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9303 (compile_pattern): Don't pass it.
9304
0afb4571
J
93052011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9306
9307 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9308 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9309 for ! HAVE_GTK3.
9310 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9311
9312 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9313
9314 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9315 gdk_window_get_screen, gdk_window_get_geometry,
9316 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9317 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9318 (xg_get_pixbuf_from_pixmap): New function.
9319 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9320 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9321 Call xg_get_pixbuf_from_pixmap instead of
9322 gdk_pixbuf_get_from_drawable.
9323 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9324 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9325 (xg_check_special_colors): Use GtkStyleContext and its functions
9326 for HAVE_GTK3.
9327 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9328 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9329 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9330 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9331 Call gtk_widget_get_preferred_size.
0afb4571
J
9332 (xg_frame_resized): gdk_window_get_geometry only takes 5
9333 parameters.
44f230aa
SM
9334 (xg_win_to_widget, xg_event_is_for_menubar):
9335 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9336 (xg_set_widget_bg): New function.
9337 (delete_cb): New function.
895009e1 9338 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9339 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9340 (xg_set_background_color): Call xg_set_widget_bg.
9341 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9342 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9343 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9344 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9345 if ! HAVE_GTK3.
9346 (update_frame_tool_bar): Call gtk_widget_hide.
9347 (xg_initialize): Use GDK_KEY_g.
9348
9349 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9350 if ! HAVE_GTK3
9351 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9352
9353 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9354 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9355 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9356
1c2cc4ef
JB
93572011-03-08 Juanma Barranquero <lekktu@gmail.com>
9358
9359 * w32xfns.c (select_palette): Check success of RealizePalette against
9360 GDI_ERROR, not zero.
9361
33383987 9362See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9363
9364;; Local Variables:
9365;; coding: utf-8
aac0c6e3
MR
9366;; End:
9367
acaf905b 9368 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9369
9370 This file is part of GNU Emacs.
9371
9372 GNU Emacs is free software: you can redistribute it and/or modify
9373 it under the terms of the GNU General Public License as published by
9374 the Free Software Foundation, either version 3 of the License, or
9375 (at your option) any later version.
9376
9377 GNU Emacs is distributed in the hope that it will be useful,
9378 but WITHOUT ANY WARRANTY; without even the implied warranty of
9379 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9380 GNU General Public License for more details.
9381
9382 You should have received a copy of the GNU General Public License
9383 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.