Improve port of struct timespec to MS-Windows.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
696056c2
EZ
12012-06-24 Eli Zaretskii <eliz@gnu.org>
2
3 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
4 (SYSTIME_H): Add nt/inc/sys/time.h.
5
6 * systime.h [WINDOWSNT]: Include sys/time.h.
7
8 * s/ms-w32.h (struct timespec): Definition moved from
9 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
10
f1dd8073
PE
112012-06-24 Paul Eggert <eggert@cs.ucla.edu>
12
13 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
14 * lisp.h (WAIT_READING_MAX): New macro.
15 * dispnew.c (Fsleep_for, sit_for):
16 * keyboard.c (kbd_buffer_get_event):
17 * process.c (Faccept_process_output):
18 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
19 This improves on the previous patch, which introduced a bug
20 when time_t is unsigned and as wide as intmax_t.
21 See <http://bugs.gnu.org/9000#51>.
22
b82c1755
EZ
232012-06-23 Eli Zaretskii <eliz@gnu.org>
24
25 * dispnew.c (sit_for, Fsleep_for):
26 * keyboard.c (kbd_buffer_get_event):
27 * process.c (Faccept_process_output): Avoid compiler warnings when
28 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
29
ca300656
JB
302012-06-23 Juanma Barranquero <lekktu@gmail.com>
31
049ec95b
JB
32 * makefile.w32-in: Update dependencies.
33
ca300656
JB
34 * w32.c (ltime): Add return type and declare static.
35 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
36
db7b8d06
PE
372012-06-23 Paul Eggert <eggert@cs.ucla.edu>
38
39 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
40 Privately reported by Herbert J. Skuhra.
41 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
42 All uses changed.
43 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
44 not make_lisp_timeval, when the argument is of type EMACS_TIME.
45
0bd8297f
EZ
462012-06-23 Eli Zaretskii <eliz@gnu.org>
47
96512555
EZ
48 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
49 last argument of make_unibyte_string.
50
0bd8297f
EZ
51 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
52 language ID in the event parameters.
53
54 * w32term.c (w32_read_socket): Put the new keyboard codepage into
55 event.code, not the obscure "character set ID".
56
63def6b6
CY
572012-06-23 Chong Yidong <cyd@gnu.org>
58
59 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
60
e8a02204
EZ
612012-06-23 Eli Zaretskii <eliz@gnu.org>
62
388cdec0
EZ
63 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
64 * w32.c (fdutimens): New function.
65
66 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
67
68 * s/ms-w32.h (pselect): Redirect to sys_select.
69
70 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
71
e8a02204
EZ
72 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
73 in the logic of incrementing and decrementing the value of
74 use_relocatable_buffers.
75
d054f3fb
PE
762012-06-23 Paul Eggert <eggert@cs.ucla.edu>
77
78 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
79 Privately reported by Herbert J. Skuhra.
80 [__FreeBSD__]: Remove "*/" typo after "#include".
81 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
82 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
83 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
84 Don't assume EMACS_TIME and struct timeval are the same type.
85
d35af63c
PE
862012-06-22 Paul Eggert <eggert@cs.ucla.edu>
87
88 Support higher-resolution time stamps (Bug#9000).
89 The time stamps are only nanosecond-resolution at the C level,
90 since that's the best that any real-world system supports now.
91 But they are picosecond-resolution at the Lisp level, as that's
92 easy, and leaves room for future OS improvements.
93
94 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
95 (LIBES): Use it.
96
97 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
98 Don't get current time unless it's needed.
99
100 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
101 now provides it if it's absent.
102 (start_atimer): Port to higher-res time stamps.
103 Check for time stamp overflow. Don't get current time more
104 often than is needed.
105
106 * buffer.h (struct buffer): Buffer modtime now has high resolution.
107 Include systime.h, not time.h.
108 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
109
110 * dired.c: Include stat-time.h.
111 (Ffile-attributes): File times now have higher resolution.
112
113 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
114 (struct image): Timestamp now has higher resolution.
115
116 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
117 has at least microseconds now. All uses removed.
118 (update_frame, update_single_window, update_window, update_frame_1)
119 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
120
121 * editfns.c (time_overflow): Now extern.
122 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
123 (float-time, Fformat_time_string, Fcurrent_time_string)
124 (Fcurrent_time_zone): Accept and generate higher-resolution
125 time stamps.
126 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
127 (decode_time_components, lisp_seconds_argument): New functions.
128 (make_time): Now static.
129 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
130 Report an error if the time is invalid, rather than having the caller
131 do that.
132
133 * fileio.c: Include <stat-time.h>
134 (Fcopy_file): Copy higher-resolution time stamps.
135 Prefer to set the time stamp via a file descriptor if that works.
136 (Fset_file_times, Finsert_file_contents, Fwrite_region)
137 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
138 (Fvisited_file_modtime, Fset_visited_file_modtime):
139 Support higher-resolution time stamps.
140
141 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
142
143 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
144
145 * image.c (prepare_image_for_display, clear_image_cache)
146 (lookup_image): Port to higer-resolution time stamps.
147
148 * keyboard.c (start_polling, bind_polling_period):
149 Check for time stamp overflow.
150 (read_char, kbd_buffer_get_event, timer_start_idle)
151 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
152 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
153 Port to higher-resolution time stamps. Do not assume time_t is signed.
154 (decode_timer): New function. Timers are now vectors of length 9,
155 not 8, to accommodate the picosecond component.
156 (timer_check_2): Use it.
157
158 * nsterm.m (select_timeout, timeval_subtract): Remove.
159 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
160 as they're a bit more accurate and handle overflow better.
161 (ns_select): Change prototype to be compatible with pselect.
162 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
163 * nsterm.h (ns_select): Adjust prototype.
164
165 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
166 us-resolution time stamps.
167 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
168
169 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
170
171 * lisp.h (time_overflow): New decl.
172 (wait_reading_process_output): First arg is now intmax_t, not int,
173 to accommodate larger waits.
174
175 * process.h (struct Lisp_Process.read_output_delay):
176 Now counts nanoseconds, not microseconds.
177 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
178 EMACS_HAS_USECS.
179 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
180 (wait_reading_process_output):
181 Port to ns-resolution time stamps.
182 (Faccept_process_output, wait_reading_process_output):
183 Check for time stamp overflow. Do not assume time_t is signed.
184 (select_wrapper): Remove; we now use pselect.
185 (Fprocess_attributes): Now generates ns-resolution time stamps.
186
187 * sysdep.c: Include utimens.h. Don't include utime.h
188 or worry about struct utimbuf; gnulib does that for us now.
189 (gettimeofday): Remove; gnulib provides a substitute.
190 (make_timeval): New function.
191 (set_file_times): Now sets ns-resolution time stamps.
192 New arg FD; all uses changed.
193 (time_from_jiffies, ltime_from_jiffies, get_up_time)
194 (system_process_attributes):
195 Now returns ns-resolution time stamp. All uses changed.
196 Check for time stamp overflow.
197
198 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
199 provides a substitute now.
200
201 * systime.h: Include timespec.h rather than sys/time.h and time.h,
202 since it guarantees struct timespec.
203 (EMACS_TIME): Now struct timespec, so that we can support
204 ns-resolution time stamps.
205 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
206 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
207 (EMACS_USECS): Remove.
208 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
209 so multiply the arg by 1000 before storing it.
210 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
211 New macros.
212 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
213 Port to ns-resolution time stamps.
214 (EMACS_TIME_NEG_P): Remove; replaced by....
215 (EMACS_TIME_SIGN): New macro.
216 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
217 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
218 (set_file_times, make_time, lisp_time_argument): Adjust signature.
219 (make_timeval, make_lisp_time, decode_time_components): New decls.
220 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
221 that it mishandled time_t overflow. You can't compare by subtracting!
222 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
223 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
224
225 * term.c: Include <sys/time.h>.
226 (timeval_to_Time): New function, for proper overflow wraparound.
227 (term_mouse_position, term_mouse_click): Use it.
228
229 * undo.c (record_first_change): Support higher-resolution time stamps
230 in the undo buffer.
231 (Fprimitive_undo): Use them when restoring time stamps.
232
233 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
234 (w32_get_internal_run_time):
235 Port to higher-resolution Emacs time stamps.
236 (ltime): Now accepts single 64-bit integer, as that's more convenient
237 for callers.
238
239 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
240
241 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
242 for compatibility with pselect. Support ns-resolution time stamps.
243
244 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
245
246 * xselect.c (wait_for_property_change, x_get_foreign_selection):
247 Check for time stamp overflow, and support ns-resolution time stamps.
248
249 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
250 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
251 (timeval_subtract): Remove; no longer needed.
252 (XTflash, XTring_bell, x_wait_for_event):
253 Port to ns-resolution time stamps. Don't assume time_t is signed.
254
b6a92dfe
CY
2552012-06-22 Chong Yidong <cyd@gnu.org>
256
257 * xdisp.c (x_consider_frame_title): Revert last change.
258
d251c37c
EZ
2592012-06-22 Eli Zaretskii <eliz@gnu.org>
260
261 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
262 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
263 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
264 staticidx goes up to 1597 out of 1600 = 0x640.)
265
f10deafb
PE
2662012-06-20 Paul Eggert <eggert@cs.ucla.edu>
267
268 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
269 Otherwise, the umask might be mistakenly 0 while handling input signals.
270
ec6de1e2
SM
2712012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
272
273 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
274
28be1ada
DA
2752012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
276
277 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
278 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
279 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
280 access to `contents' member of Lisp_Vector objects with AREF and ASET
281 where appropriate.
282
c6bf3022
CY
2832012-06-19 Chong Yidong <cyd@gnu.org>
284
285 * frame.c (delete_frame): When selecting a frame on a different
286 text terminal, do not alter the terminal's top-frame.
287
288 * xdisp.c (format_mode_line_unwind_data): Record the target
289 frame's selected window and its terminal's top-frame.
290 (unwind_format_mode_line): Restore them.
291 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
292 Callers changed.
293 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
294 since tty frames can be explicitly named.
295 (prepare_menu_bars): Likewise.
296
297 * term.c (Ftty_top_frame): New function.
298
defd4196
PE
2992012-06-18 Paul Eggert <eggert@cs.ucla.edu>
300
301 Port byte-code-meter to modern targets.
302 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
303 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 304 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
305 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
306 (METER_1, METER_2): Simplify.
307
1053a871
SM
3082012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
309
310 * data.c (Fdefalias): Return `symbol' (bug#11686).
311
b7e8d081
MR
3122012-06-18 Martin Rudalics <rudalics@gmx.at>
313
314 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
315 gets killed during executing of this function (Bug#11665).
316 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
317 (Vkill_buffer_query_functions): In doc-string say that functions
318 run by this hook should not change the current buffer.
319
7ea2b339
PE
3202012-06-18 Paul Eggert <eggert@cs.ucla.edu>
321
322 Fix recently-introduced process.c problems found by static checking.
323 * process.c (write_queue_push, write_queue_pop, send_process):
324 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
325 (write_queue_pop): Fix pointer signedness problem.
326 (send_process): Remove unused local.
327
96a313a1
CY
3282012-06-17 Chong Yidong <cyd@gnu.org>
329
330 * xdisp.c (redisplay_internal): No need to redisplay terminal
331 frames that are not on top.
332
20ca2e94
TN
3332012-06-17 Troels Nielsen <bn.troels@gmail.com>
334
335 * process.c (make_process): Initialize write_queue.
336 (write_queue_push, write_queue_pop): New functions.
337 (send_process): Use them to maintain correct ordering of process
338 writes (Bug#10815).
339
9a900ca9
PE
3402012-06-17 Paul Eggert <eggert@cs.ucla.edu>
341
310fbfa8
PE
342 * lisp.h (eassert): Assume C89 or later.
343 This removes the need for CHECK.
344 (CHECK): Remove. Its comments about always evaluating its
345 argument were confusing, as 'eassert' typically does not evaluate
346 its argument.
347
27bb1ca4
PE
348 * coding.c (produce_chars): Use ptrdiff_t, not int.
349
9a900ca9
PE
350 * xterm.c (x_draw_underwave): Check for integer overflow.
351 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
352
41b7f8bc 3532012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
354
355 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
356 referenced (Bug#11583).
357
9b0e3eba
AA
3582012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
359
360 Implement wave-style variant of underlining.
361 * dispextern.h (face_underline_type): New enum.
362 (face): Add field for underline type.
363 * nsterm.m (ns_draw_underwave): New function.
364 (ns_draw_text_decoration): Use it.
365 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
366 New functions.
367 (x_draw_glyph_string): Use them.
368 * xfaces.c (Qline, Qwave): New Lisp objects.
369 (check_lface_attrs, merge_face_ref)
1053a871
SM
370 (Finternal_set_lisp_face_attribute, realize_x_face):
371 Handle wave-style underline face attributes.
9b0e3eba
AA
372 * xterm.c (x_draw_underwave): New function.
373 (x_draw_glyph_string): Use it.
374
0fb52f11
JB
3752012-06-16 Juanma Barranquero <lekktu@gmail.com>
376
377 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
378 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
379 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
380 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
381 ($(BLD)/w32select.$(O)): Update dependencies.
382
e5560ff7
AS
3832012-06-16 Andreas Schwab <schwab@linux-m68k.org>
384
385 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
386 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
387 * character.c (_fetch_multibyte_char_p): Remove.
388 * alloc.c: Include "character.h" before "buffer.h".
389 * bidi.c: Likewise.
390 * buffer.c: Likewise.
391 * bytecode.c: Likewise.
392 * callint.c: Likewise.
393 * callproc.c: Likewise.
394 * casefiddle.c: Likewise.
395 * casetab.c: Likewise.
396 * category.c: Likewise.
397 * cmds.c: Likewise.
398 * coding.c: Likewise.
399 * composite.c: Likewise.
400 * dired.c: Likewise.
401 * dispnew.c: Likewise.
402 * doc.c: Likewise.
403 * dosfns.c: Likewise.
404 * editfns.c: Likewise.
405 * emacs.c: Likewise.
406 * fileio.c: Likewise.
407 * filelock.c: Likewise.
408 * font.c: Likewise.
409 * fontset.c: Likewise.
410 * fringe.c: Likewise.
411 * indent.c: Likewise.
412 * insdel.c: Likewise.
413 * intervals.c: Likewise.
414 * keyboard.c: Likewise.
415 * keymap.c: Likewise.
416 * lread.c: Likewise.
417 * macros.c: Likewise.
418 * marker.c: Likewise.
419 * minibuf.c: Likewise.
420 * nsfns.m: Likewise.
421 * nsmenu.m: Likewise.
422 * print.c: Likewise.
423 * process.c: Likewise.
424 * regex.c: Likewise.
425 * region-cache.c: Likewise.
426 * search.c: Likewise.
427 * syntax.c: Likewise.
428 * term.c: Likewise.
429 * textprop.c: Likewise.
430 * undo.c: Likewise.
431 * unexsol.c: Likewise.
432 * w16select.c: Likewise.
433 * w32fns.c: Likewise.
434 * w32menu.c: Likewise.
435 * window.c: Likewise.
436 * xdisp.c: Likewise.
437 * xfns.c: Likewise.
438 * xmenu.c: Likewise.
439 * xml.c: Likewise.
440 * xselect.c: Likewise.
441
2f07e6af
EZ
4422012-06-16 Eli Zaretskii <eliz@gnu.org>
443
1053a871
SM
444 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
445 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 446 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
447 row.
448 (handle_face_prop): Use chunk-relative overlay string index when
449 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
450 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
451 the rightmost. (Bug#11720)
2f07e6af 452
29b83cec
AS
4532012-06-16 Andreas Schwab <schwab@linux-m68k.org>
454
455 * category.h (CHAR_HAS_CATEGORY): Define as inline.
456 (CATEGORY_MEMBER): Enforce 1/0 value.
457 * category.c (_temp_category_set): Remove.
458
4c5501e9
EZ
4592012-06-16 Eli Zaretskii <eliz@gnu.org>
460
461 * window.c (Fdelete_other_windows_internal)
462 (Fdelete_window_internal): Don't access frame's mouse highlight
463 info of the initial frame. (Bug#11677)
464
2b570124
PE
4652012-06-14 Paul Eggert <eggert@cs.ucla.edu>
466
e93864f9
PE
467 * .gdbinit (xgetint): Fix recently-introduced paren typo.
468 Assume USE_2_TAGS_FOR_INTS.
469 (xreload): Adjust $tagmask width to match recent lisp.h change.
470
2b570124
PE
471 Simplify lisp.h in minor ways that should not affect code.
472 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
473 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
474 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
475 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
476 (INTTYPEBITS): New macro, for clarity.
477 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
478 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
479 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
480 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
481 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
482
81755f69
JB
4832012-06-13 Juanma Barranquero <lekktu@gmail.com>
484
485 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
486
16192a57
GM
4872012-06-13 Glenn Morris <rgm@gnu.org>
488
489 * s/bsd-common.h (BSD4_3):
490 * s/usg5-4-common.h (USG5_4): No longer define; unused.
491
646b5f55
AS
4922012-06-13 Andreas Schwab <schwab@linux-m68k.org>
493
494 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
495 instead of union.
496 (XLI, XIL): Define.
1053a871
SM
497 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
498 Use them.
499 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 500 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 501 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
502 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
503 * frame.c (delete_frame): Remove outdated comment.
504 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
505 USE_LISP_UNION_TYPE.
506 (Fw32_unregister_hot_key): Likewise.
507 (Fw32_toggle_lock_key): Likewise.
508 * w32menu.c (add_menu_item): Likewise.
509 (w32_menu_display_help): Use XIL instead of checking
510 USE_LISP_UNION_TYPE.
511 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
512 (init_heap): Likewise.
513 * w32term.c (w32_read_socket): Update comment.
514
1d3823c9
GM
5152012-06-13 Glenn Morris <rgm@gnu.org>
516
c62ff706
GM
517 * s/usg5-4-common.h, src/s/unixware.h:
518 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
519
1d3823c9
GM
520 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
521
bfe3e0a2
PE
5222012-06-13 Paul Eggert <eggert@cs.ucla.edu>
523
524 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
525 * alloc.c (make_number) [!defined make_number]:
526 Remove, as lisp.h always defines this now.
527 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
528 (roundup_size): Verify that it is a power of 2.
529 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
530 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
531 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
532 -DUSE_LSB_TAG=0, to override the automatically-selected default.
533 USE_LSB_TAG now is always defined to be either 0 or 1.
534 All uses changed.
535 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
536 code works fine either way, and efficiency is not a concern here,
537 as the union type is for debugging, not for production.
538 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
539 Use an inline function on all platforms when using the union type,
540 since this is simpler and 'static inline' can be used portably
541 within Emacs now.
542 (LISP_INITIALLY_ZERO): New macro.
543 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
544 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
545
45fa9c0f
GM
5462012-06-12 Glenn Morris <rgm@gnu.org>
547
b4492cba
GM
548 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
549
550 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 551
45fa9c0f
GM
552 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
553 Move BROKEN_SIGIO to configure.
554
555 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
556 Move NO_TERMIO to configure.
557
0e25d334
CY
5582012-06-12 Chong Yidong <cyd@gnu.org>
559
560 * image.c (imagemagick_load_image): Use MagickFlattenImage if
561 MagickMergeImageLayers is undefined. Use pixel pusher loop if
562 MagickExportImagePixels is undefined.
563
43682bb6
PE
5642012-06-12 Paul Eggert <eggert@cs.ucla.edu>
565
566 * image.c (imagemagick_load_image): Remove unused label.
567
a9be7d2b
GM
5682012-06-11 Glenn Morris <rgm@gnu.org>
569
570 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
571 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
572 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
573 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
574
3017f87f
SM
5752012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
576
577 * alloc.c (make_byte_code): New function.
578 (Fmake_byte_code): Use it. Don't purify here.
579 * lread.c (read1): Use it as well to avoid extra allocation.
580
1b9b4cf4
CY
5812012-06-11 Chong Yidong <cyd@gnu.org>
582
583 * image.c (imagemagick_load_image): Implement transparency.
584
95988fcf
AS
5852012-06-10 Andreas Schwab <schwab@linux-m68k.org>
586
587 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
588 account for preceding backslashes. (Bug#11663)
589
cd4eb164
CY
5902012-06-09 Chong Yidong <cyd@gnu.org>
591
592 * term.c: Support italics in capable terminals (Bug#9652).
593 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
594 (turn_on_face): Output using TS_enter_italic_mode if available.
595 Don't handle unused blinking and alt-charset cases.
596 (turn_off_face): Handle italic case; discard unused tty_blinking_p
597 and tty_alt_charset_p cases.
598 (tty_capable_p, init_tty): Support italics.
599
600 * termchar.h (struct tty_display_info): Add field for italics.
601 Remove unused blink field.
602
603 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
604 Handle slant.
605
606 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
607 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
608 tty_alt_charset_p. Add tty_italic_p.
609
ff88beb8
MA
6102012-06-09 Michael Albinus <michael.albinus@gmx.de>
611
612 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
613 dbus_type_is_basic if available.
614 (xd_extract_signed, xd_extract_unsigned): Rename from
615 extract_signed and extract_unsigned, respectively. Adapt callers.
616
44286096
CY
6172012-06-09 Chong Yidong <cyd@gnu.org>
618
1682701f
CY
619 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
620
44286096
CY
621 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
622 case (Bug#9752).
623
d86feb17
PE
6242012-06-08 Paul Eggert <eggert@cs.ucla.edu>
625
626 * xdisp.c (vmessage): Treat frame message as multibyte.
627 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
628 would generate the diagnostic "Making \302\247 buffer-local while
629 let-bound!".
630
d5c20fe8
EZ
6312012-06-08 Eli Zaretskii <eliz@gnu.org>
632
633 * dispnew.c (showing_window_margins_p): Undo last change, which
634 was done due to an inadvertent commit.
635 (adjust_frame_glyphs_for_frame_redisplay): Do call
636 showing_window_margins_p.
637
513749ee
SM
6382012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
639
640 * eval.c (Fmake_var_non_special): New primitive.
641 (syms_of_eval): Defsubr it.
642 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
643
d4a8f5c1
JB
6442012-06-08 Juanma Barranquero <lekktu@gmail.com>
645
646 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
647 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
648
8bbbc977
EZ
6492012-06-08 Eli Zaretskii <eliz@gnu.org>
650
651 * alloc.c (allocate_vectorlike): Fix last change.
652
f3372c87
DA
6532012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
654
655 Block-based vector allocation of small vectors.
656 * lisp.h (struct vectorlike_header): New field `nbytes',
657 adjust comment accordingly.
658 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
659 to denote vector blocks. Adjust users (live_vector_p,
660 mark_maybe_pointer, valid_lisp_object_p) accordingly.
661 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
662 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
663 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
664 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
665 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
666 (roundup_size): New constant.
667 (struct vector_block): New data type.
668 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 669 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
670 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
671 (sweep_vectors): New functions.
672 (allocate_vectorlike): Return `zero_vector' as the only vector of
673 0 items. Allocate new vector from block if vector size is less than
674 or equal to VBLOCK_BYTES_MAX.
675 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
676 (init_alloc_once): Add call to init_vectors.
677
4f18a4ed
SM
6782012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
679
680 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
681
86f158bc
PE
6822012-06-07 Paul Eggert <eggert@cs.ucla.edu>
683
684 * doprnt.c (doprnt): Truncate multibyte char correctly.
685 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
686 would mishandle a string argument "Xc" if X was a multibyte
687 character of length 2: it would truncate after X's first byte
688 rather than including all of X.
689
c5cfcbe0
CY
6902012-06-06 Chong Yidong <cyd@gnu.org>
691
692 * buffer.c (word_wrap): Doc fix.
693
c05cf390
PE
6942012-06-04 Paul Eggert <eggert@cs.ucla.edu>
695
696 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
697
0c3461de
GM
6982012-06-03 Glenn Morris <rgm@gnu.org>
699
700 * xdisp.c (tool-bar-style): Doc fix.
701
c71232db
UM
7022012-06-03 Ulrich Müller <ulm@gentoo.org>
703
704 * Makefile.in (PAXCTL): Define.
705 (temacs$(EXEEXT)): Disable memory randomization for the temacs
706 binary via PaX flags if the paxctl utility is available.
707 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
708 Restore PaX flags to their default. (Bug#11398)
709
383f7350
CY
7102012-06-03 Chong Yidong <cyd@gnu.org>
711
712 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
713 buffer (Bug#11226).
714
5f2c76c6
CY
7152012-06-03 Chong Yidong <cyd@gnu.org>
716
717 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
718 (note_mode_line_or_margin_highlight): If there is no help echo,
719 use mode-line-default-help-echo. Handle the case where the mouse
720 position is past the end of the mode line string.
721
722 * buffer.c (buffer_local_value_1): New function, split from
723 Fbuffer_local_value; can return Qunbound.
724 (Fbuffer_local_value): Use it.
725 (Vmode_line_format): Docstring tweaks.
726
773d47f6
PE
7272012-06-02 Paul Eggert <eggert@cs.ucla.edu>
728
729 * sysdep.c (system_process_attributes): Improve comment.
730
f2d6a3df
SM
7312012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
732
733 * keyboard.c: Export real-this-command to Elisp.
734 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
735 and DEFVAR it. Update all users.
736
63810350
PE
7372012-06-02 Paul Eggert <eggert@cs.ucla.edu>
738
7bd5c1f4
PE
739 * minibuf.c (Fassoc_string): Remove duplicate declaration.
740
63810350
PE
741 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
742 Convert pctcpu and pctmem to Lisp float properly.
743 Let the compiler fold better, as 100.0/0x8000 is exact.
744
a2821611
AS
7452012-06-02 Andreas Schwab <schwab@linux-m68k.org>
746
747 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
748 cons_block.
749
5fceba1d
PE
7502012-06-01 Paul Eggert <eggert@cs.ucla.edu>
751
752 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
753
c98ff5dd
DA
7542012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
755
756 For a 'struct window', replace some Lisp_Object fields to
757 bitfields where appropriate, remove unused fields.
758 * window.h (struct window): Remove unused 'last_mark_x' and
759 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
760 change it's type from Lisp_Object to bitfield.
761 Change type of 'force_start', 'optional_new_start',
762 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
763 fields from Lisp_Object to bitfield. Adjust users accordingly.
764
ca34e0be
PE
7652012-05-31 Paul Eggert <eggert@cs.ucla.edu>
766
767 Pacify gcc -Wdouble-precision when using Xaw.
768 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
769 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
770 Use 'float' consistently, rather than 'float' in most places
771 and 'double' in a couple of places.
772
efc00ab1 7732012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
774
775 * xdisp.c (handle_stop): Detect whether we have overlay strings
776 loaded by testing it->current.overlay_string_index to be
777 non-negative, instead of checking whether n_overlay_strings is
778 positive. (Bug#11587)
779
efc00ab1 7802012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
781
782 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
783
784 * doc.c (Fsubstitute_command_keys): Doc fix.
785
efc00ab1 7862012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
787
788 * search.c (search_buffer): Remove calls to
789 r_alloc_inhibit_buffer_relocation, as it is now called by
790 maybe_unify_char, which was the cause of relocation of buffer text
791 in bug#11519.
792
efc00ab1 7932012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
794
795 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
796 for the duration of call to load_charset, to avoid problems with
797 callers of maybe_unify_char that access buffer text through C
798 pointers.
799
800 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
801 decrement the inhibition flag, instead of just setting or
802 resetting it.
803
ba93a187
PE
8042012-05-31 Paul Eggert <eggert@cs.ucla.edu>
805
806 Remove obsolete '#define static' cruft.
807 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
808 This #undef was "temporary" in 2000; it is no longer needed
809 now that '#define static' has gone away.
810 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
811 (gray_bitmap_bits): Remove; no longer needed.
812 All uses replaced with definiens.
813 * xterm.c: Include "bitmaps/gray.xbm".
814
9e4bf381
PE
8152012-05-30 Paul Eggert <eggert@cs.ucla.edu>
816
817 Clean up __executable_start, monstartup when --enable-profiling.
818 The following changes affect the code only when profiling.
819 * dispnew.c (__executable_start): Rename from safe_bcopy.
820 Define only on platforms that need it.
821 * emacs.c: Include <sys/gmon.h> when profiling.
822 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
823 (__executable_start): Remove decl, since lisp.h does it now.
824 (safe_bcopy): Remove decl; no longer has that name.
825 (main): Coalesce #if into single bit of code, for simplicity.
826 Cast pointers to uintptr_t, since standard libraries want integers
827 and not pointers.
828 * lisp.h (__executable_start): New decl.
829
32d72c2f
GM
8302012-05-31 Glenn Morris <rgm@gnu.org>
831
832 * image.c (Fimagemagick_types): Doc fix.
833
baac5bc7
JM
8342012-05-30 Jim Meyering <meyering@redhat.com>
835
836 * callproc.c (Fcall_process_region): Include directory component
837 in mkstemp error message (Bug#11586).
838
72cb32cf
PE
8392012-05-30 Paul Eggert <eggert@cs.ucla.edu>
840
841 * alloc.c, lisp.h (make_pure_vector): Now static.
842
61b108cc
SM
8432012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
844
845 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
846 Move to byte-run.el.
847 (Fautoload): Do the hash-doc more carefully.
848 * data.c (Fdefalias): Purify definition, except for keymaps.
849 (Qdefun): Move from eval.c.
850 * lisp.h (Qdefun): Remove.
851 * lread.c (read1): Tiny simplification.
852
471fe23d
TN
8532012-05-29 Troels Nielsen <bn.troels@gmail.com>
854
934f3f58 855 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
856 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
857 Bug#9642, but explicitly check that the buffer the overlay would
858 be moved to is live and rearrange lines to make sure that errors
859 will not put the overlay in an inconsistent state.
860 (Fdelete_overlay): Cosmetics.
861
85d0efd1
EZ
8622012-05-28 Eli Zaretskii <eliz@gnu.org>
863
864 * w32term.c (my_bring_window_to_top): New function.
865 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
866 could be different from the original one.
867 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
868 (Bug#11513)
869
870 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
871 by calling BringWindowToTop.
872
873 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
874 (WM_EMACS_END): Increase by one.
875
da92a98c
PE
8762012-05-28 Paul Eggert <eggert@cs.ucla.edu>
877
878 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
879 This avoids undefined behavior that might cause the eassert
880 to not catch an out-of-range value.
881
74d1f848
JB
8822012-05-28 Juanma Barranquero <lekktu@gmail.com>
883
884 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
885 Update dependencies.
886
9e1a06fc
EZ
8872012-05-27 Eli Zaretskii <eliz@gnu.org>
888
889 * bidi.c (bidi_mirror_char): Fix last change.
890
f3dd7312
AS
8912012-05-27 Andreas Schwab <schwab@linux-m68k.org>
892
893 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
894 when referring to sectname field in printf format.
895
81899c91
PE
8962012-05-27 Paul Eggert <eggert@cs.ucla.edu>
897
57b81a9f
PE
898 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
899 Only r_alloc_inhibit_buffer_relocation needed to be added;
900 the others were already declared.
901
81899c91
PE
902 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
903 before checking whether it's out of range. Put the check inside
904 eassert. See
905 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
906
33017faf 9072012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
908
909 * callproc.c (Fcall_process): Restore a line that was accidentally
910 commented out in the 2011-02-13 change (bug#11547).
911
33017faf 9122012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
913
914 * lisp.h [REL_ALLOC]: Add prototypes for external functions
915 defined on ralloc.c.
916
917 * buffer.c [REL_ALLOC]: Remove prototypes of
918 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
919 they are now on lisp.h.
920
921 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
922
923 * search.c (search_buffer): Use it to inhibit relocation of buffer
924 text while re_search_2 is doing its job, because re_search_2 is
925 passed C pointers to buffer text. (Bug#11519)
926
23415acf
EZ
927 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
928 Update value to 24.
929
44e27368
EZ
930 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
931 state after an additional call to move_it_in_display_line_to, keep
932 the values of it->max_ascent and it->max_descent found for the
933 entire line.
934 (pos_visible_p): Revert the comparison against bottom_y to what it
935 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
936 (Bug#11464)
937
c1892f11
PE
9382012-05-26 Paul Eggert <eggert@cs.ucla.edu>
939
940 Fix coding-related core dumps with gcc -ftrapv.
941 The code was computing A - B, where A and B are pointers, and B is
942 random garbage. This can lead to core dumps on platforms that
943 have special pointer registers, and it also leads to core dumps on
944 x86-64 when compiled with gcc -ftrapv. The fix is to compute
945 A - B only when B is initialized properly.
946 * coding.c (coding_set_source, coding_set_destination): Return void.
947 (coding_change_source, coding_change_destinations): New functions,
948 with the old behaviors of coding_set_source and coding_set_destination.
949 All callers that need an offset changed to use these new functions.
950
eb7afdad
GM
9512012-05-26 Glenn Morris <rgm@gnu.org>
952
953 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
954
f12fdf02
EZ
9552012-05-26 Eli Zaretskii <eliz@gnu.org>
956
53a63be6 957 Extend mouse support on W32 text-mode console.
61b108cc
SM
958 * xdisp.c (draw_row_with_mouse_face):
959 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 960
eb3f6f01 961 * w32console.c: Include window.h.
61b108cc
SM
962 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
963 New functions.
eb3f6f01
EZ
964 (initialize_w32_display): Initialize mouse-highlight data.
965
53a63be6
EZ
966 * w32inevt.c: Include termchar.h and window.h.
967 (do_mouse_event): Support mouse-autoselect-window. When the mouse
968 moves, call note_mouse_highlight. If help_echo changed, call
969 gen_help_event to produce help-echo message in the echo area.
970 Call clear_mouse_face if mouse_face_hidden is set in the mouse
971 highlight info.
972
4cfd81f6
PE
9732012-05-26 Paul Eggert <eggert@cs.ucla.edu>
974
975 * lread.c (read1): Simplify slightly to avoid an overflow warning
976 with GCC 4.7.0 on x86-64.
977
4446092a
EZ
9782012-05-26 Eli Zaretskii <eliz@gnu.org>
979
980 * bidi.c (bidi_mirror_char): Revert last change: an int is
981 definitely wide enough here.
982
42b2a986 9832012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 984
42b2a986 985 Fix integer width and related bugs (Bug#9874).
eb106a49 986 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
987 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
988 (string_bytes, check_sblock, allocate_string_data):
989 (compact_small_strings, Fmake_bool_vector, make_string)
990 (make_unibyte_string, make_multibyte_string)
991 (make_string_from_bytes, make_specified_string)
992 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
993 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
994 (mark_vectorlike):
995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
996 (allocate_pseudovector):
997 Use int, not EMACS_INT, where int is wide enough.
998 (inhibit_garbage_collection, Fgarbage_collect):
999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1000 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1001 int might not be wide enough.
1002 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1003 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1004 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1005 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1006 (bidi_level_of_next_char, bidi_move_to_visually_next):
1007 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1008 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1009 (Fkill_buffer, Fset_buffer_major_mode)
1010 (advance_to_char_boundary, Fbuffer_swap_text)
1011 (Fset_buffer_multibyte, overlays_at, overlays_in)
1012 (overlay_touches_p, struct sortvec, record_overlay_string)
1013 (overlay_strings, recenter_overlay_lists)
1014 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1015 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1016 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1017 (Foverlay_recenter, last_overlay_modification_hooks_used)
1018 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1019 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1020 (validate_region): Omit unnecessary test for b <= e,
1021 since that's guaranteed by the previous test.
d311d28c
PE
1022 (adjust_overlays_for_delete): Avoid pos + length overflow.
1023 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1024 (report_overlay_modification):
1025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1026 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1027 Omit pointer cast, which isn't needed anyway, and doesn't work
1028 after the EMACS_INT -> ptrdiff_t change.
02481186 1029 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1030 * buffer.h: Adjust decls to match defn changes elsewhere.
1031 (struct buffer_text, struct buffer):
1032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1033 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1034 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1035 not int, to avoid needless 32-bit limit on 64-bit hosts.
1036 (exec_byte_code): Use tighter memory-full test, one that checks
1037 for alloca overflow. Don't compute the address of the object just
1038 before an array, as that's not portable. Use EMACS_INT, not
1039 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1040 * callint.c (Fcall_interactively):
1041 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1042 * callproc.c (call_process_kill, Fcall_process):
1043 Don't assume pid_t fits into an Emacs fixnum.
1044 (call_process_cleanup, Fcall_process, child_setup):
1045 Don't assume pid_t fits into int.
1046 (call_process_cleanup, Fcall_process, delete_temp_file)
1047 (Fcall_process_region):
1048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1049 (Fcall_process): Simplify handling of volatile integers.
1050 Use int, not EMACS_INT, where int will do.
1051 * casefiddle.c (casify_object, casify_region, operate_on_word)
1052 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1054 (casify_object): Avoid integer overflow when overallocating buffer.
1055 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1056 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1057 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1058 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1059 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1060 integers are now checked earlier. All uses replaced with XINT.
1061 (ccl_driver):
1062 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1063 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1064 (ccl_driver, Fregister_code_conversion_map):
1065 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1066 (resolve_symbol_ccl_program): Check that vector header is in range.
1067 Always copy the vector, so that we can check its contents reliably
1068 now rather than having to recheck each instruction as it's being
1069 executed. Check that vector words fit in 'int'.
1070 (ccl_get_compiled_code, Fregister_ccl_program)
1071 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1072 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1073 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1074 contents are in range.
1075 (Fccl_execute_on_string): Check that status is in range.
1076 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1077 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1078 Accept and return EMACS_INT, not int, because callers can pass values
1079 out of 'int' range.
1080 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1081 (multibyte_chars_in_text, parse_str_as_multibyte)
1082 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1083 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1084 (string_escape_byte8, Fget_byte):
1085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1086 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1087 avoid mishandling large integers.
1088 * character.h: Adjust decls to match defn changes elsewhere.
1089 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1090 (Ffind_charset_region):
1091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1092 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1093 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1094 Don't assume fixnum fits in int.
d311d28c
PE
1095 (load_charset_map_from_vector, Fmap_charset_chars):
1096 Remove now-unnecessary CHECK_NATNUMs.
1097 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1098 Don't rely on undefined behavior with signed left shift overflow.
1099 Don't assume unsigned int fits into fixnum, or that fixnum fits
1100 into unsigned int. Don't require max_code to be a valid fixnum;
1101 that's not true for gb10830 4-byte on a 32-bit host. Allow
1102 invalid_code to be a cons, for the same reason. Require code_offset
1103 to be a character. Avoid int overflow if max_char is close
1104 to INT_MAX.
1105 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1106 this is intended anyway and avoids some undefined behavior.
1107 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1108 INDEX_TO_CODE_POINT, as that's what it expects.
1109 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1110 * charset.h (DECODE_CHAR): Return int, not unsigned;
1111 this is what was intended anyway, and it avoids undefined behavior.
1112 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1113 integer-overflow issues.
1114 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1115 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1116 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1117 * chartab.c (Fmake_char_table, Fset_char_table_range)
1118 (uniprop_get_decoder, uniprop_get_encoder):
1119 Don't assume fixnum fits in int.
1120 * cmds.c (move_point): New function, that does the gist of
1121 Fforward_char and Fbackward_char, but does so while checking
1122 for integer overflow more accurately.
c96e5d6a 1123 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1124 (Fforward_line, Fend_of_line, internal_self_insert)
1125 (internal_self_insert):
1126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1127 Fix a FIXME, by checking for integer overflow when calculating
1128 target_clm and actual_clm.
1129 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1130 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1131 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1132 (coding_alloc_by_making_gap, alloc_destination)
1133 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1134 (encode_coding_utf_16, detect_coding_emacs_mule)
1135 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1136 (detect_coding_iso_2022, decode_coding_iso_2022)
1137 (encode_invocation_designation, encode_designation_at_bol)
1138 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1139 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1140 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1141 (encode_coding_ccl, encode_coding_raw_text)
1142 (detect_coding_charset, decode_coding_charset)
1143 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1144 (produce_composition, produce_charset, produce_annotation)
1145 (decode_coding, handle_composition_annotation)
1146 (handle_charset_annotation, consume_chars, decode_coding_gap)
1147 (decode_coding_object, encode_coding_object, detect_coding_system)
1148 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1149 (code_convert_region, code_convert_string)
8f50130c
PE
1150 (Fdefine_coding_system_internal)
1151 (coding_set_source, coding_set_destination):
d311d28c
PE
1152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1153 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1154 (Fdefine_coding_system_internal):
1155 Don't assume fixnums fit in int.
1156 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1157 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1158 (Funencodable_char_position, Fcheck_coding_systems_region)
1159 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1161 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1162 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1163 Don't access memory outside of the args array.
d311d28c 1164 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1165 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1166 result of ENCODE_CHAR.
d311d28c
PE
1167 * coding.h: Adjust decls to match defn changes elsewhere.
1168 (struct coding_system):
1169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1170 * composite.c (get_composition_id, find_composition)
1171 (run_composition_function, update_compositions)
1172 (compose_text, composition_gstring_put_cache)
1173 (composition_gstring_p, composition_gstring_width)
1174 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1175 (composition_compute_stop_pos, composition_reseat_it)
1176 (composition_update_it, struct position_record)
1177 (find_automatic_composition, composition_adjust_point)
1178 (Fcomposition_get_gstring, Ffind_composition_internal):
1179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1180 (update_compositions):
1181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1182 * composite.h: Adjust decls to match defn changes elsewhere.
1183 (struct composition):
1184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1185 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1186 Do not attempt to compute the address of the object just before a
1187 buffer; this is not portable.
1188 (Faref, Faset):
1189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1190 (Faset): Use int, not EMACS_INT, where int is wide enough.
1191 (Fstring_to_number): Don't assume fixnums fit in int.
1192 (Frem): Don't assume arg is nonnegative.
1193 * dbusbind.c (xd_append_arg): Check for integers out of range.
1194 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1195 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1196 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1197 (xd_get_connection_references): Return ptrdiff_t, not int.
1198 All uses changed.
1199 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1200 (xd_read_message_1):
1201 Use int, not unsigned, where the dbus API uses int.
1202 (Fdbus_message_internal): Don't overflow mtype.
1203 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1204 * dired.c (directory_files_internal, file_name_completion, scmp)
1205 (file_name_completion_stat):
1206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1207 (file_name_completion): Don't overflow matchcount.
1208 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1209 * dispextern.h: Adjust decls to match defn changes elsewhere.
1210 (struct text_pos, struct glyph, struct bidi_saved_info)
1211 (struct bidi_string_data, struct bidi_it, struct composition_it)
1212 (struct it):
1213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1214 (struct display_pos, struct composition_it, struct it):
1215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1216 * dispnew.c (increment_matrix_positions)
1217 (increment_row_positions, mode_line_string)
1218 (marginal_area_string):
1219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1220 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1222 (duration_to_sec_usec): New function, to check for overflow better.
1223 (Fsleep_for, sit_for): Use it.
1224 * doc.c (get_doc_string, store_function_docstring):
1225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1226 (get_doc_string, Fsnarf_documentation):
1227 Use int, not EMACS_INT, where int is wide enough.
1228 (get_doc_string):
1229 Use SAFE_ALLOCA, not alloca.
1230 Check for overflow when converting EMACS_INT to off_t.
1231 * doprnt.c (doprnt):
1232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1233 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1234 Don't assume uid_t fits into fixnum.
1235 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1236 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1237 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1238 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1239 (general_insert_function)
1240 (Finsert_char, make_buffer_string, make_buffer_string_both)
1241 (update_buffer_properties, Fbuffer_substring)
1242 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1243 (Fsubst_char_in_region, check_translation)
1244 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1245 (transpose_markers, Ftranspose_regions):
1246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1247 (clip_to_bounds): Move to lisp.h as an inline function).
1248 (Fconstrain_to_field): Don't assume integers are nonnegative.
1249 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1250 (Fsubst_char_in_region, Fsave_restriction):
1251 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1252 (Femacs_pid): Don't assume pid_t fits into fixnum.
1253 (lo_time): Use int, not EMACS_INT, when int suffices.
1254 (lisp_time_argument): Check for usec out of range.
1255 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1256 (Fuser_login_name, Fuser_full_name): Signal an error
1257 if a uid argument is out of range, rather than relying on
1258 undefined behavior.
c8d5c857
PE
1259 (Fformat_time_string): Remove now-unnecessary check.
1260 lisp_time_argument checks for out-of-range usec now.
243e0530 1261 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1262 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1263 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1264 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1265 (init_cmdargs, Fdump_emacs):
1266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1267 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1268 the bottom (typically) 32 bits of the fixnum.
1269 * eval.c (specpdl_size, call_debugger):
1270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1271 (when_entered_debugger, Fbacktrace_debug):
1272 Don't assume fixnum can fit in int.
1273 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1274 the object just before a buffer; this is not portable.
1275 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1276 (grow_specpdl, unbind_to):
1277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1278 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1279 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1280 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1281 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1282 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1283 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1284 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1285 (a_write, e_write):
1286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1287 (Fcopy_file, non_regular_nbytes, read_non_regular)
1288 (Finsert_file_contents):
1289 Use int, not EMACS_INT, where int is wide enough.
1290 (READ_BUF_SIZE): Verify that it fits in int.
1291 (Finsert_file_contents): Check that counts are in proper range,
1292 rather than assuming fixnums fit into ptrdiff_t etc.
1293 Don't assume fixnums fit into int.
125b3835 1294 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1295 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1296 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1297 (string_char_to_byte, string_byte_to_char)
1298 (string_make_multibyte, string_to_multibyte)
1299 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1300 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1301 (substring_both, Fdelete, internal_equal, Ffillarray)
1302 (Fclear_string, mapcar1)
1303 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1304 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1305 (larger_vector, make_hash_table, maybe_resize_hash_table)
1306 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1307 (Fmaphash, secure_hash):
1308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1309 (concat): Check for string index and length overflow.
1310 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1311 (Frequire):
1312 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1313 (larger_vector): New API (vec, incr_min, size_max) replaces old
1314 one (vec, new_size, init). This catches size overflow.
1315 INIT was removed because it was always Qnil.
1316 All callers changed.
1317 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1318 the upper bound on a hash table index size.
1319 (make_hash_table, maybe_resize_hash_table): Use it.
1320 (secure_hash): Computer start_byte and end_byte only after
1321 they're known to be in ptrdiff_t range.
1322 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1323 (Ffont_get_glyphs, Ffont_at):
1324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1325 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1326 (Flist_fonts, Fopen_font):
1327 Don't assume fixnum can fit in int.
1328 (check_gstring): Don't assume index can fit in int.
1329 (font_match_p): Check that fixnum is a character, not a nonnegative
1330 fixnum, since the later code needs to stuff it into an int.
1331 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1332 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1333 conversion overflow issues.
1334 (Fopen_font): Check for integer out of range.
1335 (Ffont_get_glyphs): Don't assume index can fit in int.
1336 * font.h: Adjust decls to match defn changes elsewhere.
1337 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1338 integer overflow.
1339 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1340 printmax_t, where ptrdiff_t is wide enough.
1341 (Finternal_char_font):
1342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1343 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1344 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1345 (Fset_frame_position, x_set_frame_parameters)
1346 (x_set_line_spacing, x_set_border_width)
1347 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1348 Check that fixnums are in proper range for system types.
1349 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1351 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1352 Use SAFE_ALLOCA_LISP, not alloca.
1353 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1354 intptr_t is wide enough.
1355 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1356 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1357 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1358 Check for fixnum out of range.
1359 * ftfont.c (ftfont_list): Don't assume index fits in int.
1360 Check that fixnums are in proper range for system types.
1361 (ftfont_shape_by_flt):
1362 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1363 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1365 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1366 Check that fixnums are in proper range for system types.
1367 * gnutls.h: Adjust decls to match defn changes elsewhere.
1368 * gtkutil.c (xg_dialog_run):
1369 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1370 (update_frame_tool_bar):
1371 Check that fixnums are in proper range for system types.
1372 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1373 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1374 * indent.c (last_known_column, last_known_column_point):
1375 (current_column_bol_cache):
1376 (skip_invisible, current_column, check_display_width):
1377 (check_display_width, scan_for_column, current_column_1)
1378 (Findent_to, Fcurrent_indentation, position_indentation)
1379 (indented_beyond_p, Fmove_to_column, compute_motion):
1380 (Fcompute_motion, Fvertical_motion):
1381 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1382 (last_known_column_modified): Use EMACS_INT, not int.
1383 (check_display_width):
1384 (Fcompute_motion):
1385 Check that fixnums and floats are in proper range for system types.
1386 (compute_motion): Don't assume index or fixnum fits in int.
1387 (compute_motion, Fcompute_motion):
1388 Use int, not EMACS_INT, when it is wide enough.
1389 (vmotion): Omit local var start_hpos that is always 0; that way
1390 we don't need to worry about overflow in expressions involving it.
1391 * indent.h: Adjust decls to match defn changes elsewhere.
1392 (struct position):
1393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1394 Use int, not EMACS_INT, where int is wide enough.
1395 Remove unused members ovstring_chars_done and tab_offset;
1396 all uses removed.
1397 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1398 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1399 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1400 (make_gap, copy_text, insert, insert_and_inherit)
1401 (insert_before_markers, insert_before_markers_and_inherit)
1402 (insert_1, count_combining_before, count_combining_after)
1403 (insert_1_both, insert_from_string)
1404 (insert_from_string_before_markers, insert_from_string_1)
1405 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1406 (adjust_after_replace, adjust_after_insert, replace_range)
1407 (replace_range_2, del_range, del_range_1, del_range_byte)
1408 (del_range_both, del_range_2, modify_region)
1409 (prepare_to_modify_buffer, signal_before_change)
1410 (signal_after_change, Fcombine_after_change_execute):
1411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1412 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1413 (balance_an_interval, split_interval_right, split_interval_left)
1414 (find_interval, next_interval, update_interval)
1415 (adjust_intervals_for_insertion, delete_node, delete_interval)
1416 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1417 (static_offset_intervals, offset_intervals)
1418 (merge_interval_right, merge_interval_left, make_new_interval)
1419 (graft_intervals_into_buffer, temp_set_point_both)
1420 (temp_set_point, set_point, adjust_for_invis_intang)
1421 (set_point_both, move_if_not_intangible, get_property_and_range)
1422 (get_local_map, copy_intervals, copy_intervals_to_string)
1423 (compare_string_intervals, set_intervals_multibyte_1):
1424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1425 * intervals.h: Adjust decls to match defn changes elsewhere.
1426 (struct interval):
1427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1428 * keyboard.c (this_command_key_count, this_single_command_key_start)
1429 (before_command_key_count, before_command_echo_length, echo_now)
1430 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1431 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1432 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1433 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1435 (last_non_minibuf_size, last_point_position, echo_truncate)
1436 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1437 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1438 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1439 (stuff_buffered_input):
1440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1441 (last_auto_save, command_loop_1, read_char):
1442 Use EMACS_INT, not int, to avoid integer overflow.
1443 (record_char): Avoid overflow in total_keys computation.
1444 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1445 * keyboard.h: Adjust decls to match defn changes elsewhere.
1446 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1447 (Fkey_description, Fdescribe_vector, Flookup_key):
1448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1449 (click_position): New function, to check that positions are in range.
1450 (Fcurrent_active_maps):
1451 (describe_command):
1452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1453 (Faccessible_keymaps, Fkey_description):
1454 (preferred_sequence_p):
1455 Don't assume fixnum can fit into int.
1456 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1457 Check for integer overflow in size calculations.
1458 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1459 avoid mishandling large integers.
1460 * lisp.h: Adjust decls to match defn changes elsewhere.
1461 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1462 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1463 (struct Lisp_Marker):
1464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1465 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1466 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1467 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1468 All callers changed.
1469 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1470 Assume the arg has valid form, since it always does.
1471 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1472 unsigned integer system type.
1473 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1474 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1475 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1476 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1477 (duration_to_sec_usec): New decl.
1478 * lread.c (read_from_string_index, read_from_string_index_byte)
1479 (read_from_string_limit, readchar, unreadchar, openp)
1480 (read_internal_start, read1, oblookup):
1481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1482 (Fload, readevalloop, Feval_buffer, Feval_region):
1483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1484 (openp): Check for out-of-range argument to 'access'.
1485 (read1): Use int, not EMACS_INT, where int is wide enough.
1486 Don't assume fixnum fits into int.
6efdadfd 1487 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1488 (read_filtered_event): Use duration_to_sec_usec
1489 to do proper overflow checking on durations.
d311d28c
PE
1490 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1491 in size calculation.
1492 (Fexecute_kbd_macro):
1493 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1494 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1495 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1496 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1497 (set_marker_both, set_marker_restricted_both, marker_position)
1498 (marker_byte_position, Fbuffer_has_markers_at):
1499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1500 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1501 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1502 It now merely ensures that the menu is large enough, without
1503 necessarily growing it, as this avoids some integer overflow issues.
1504 All callers changed.
1505 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1507 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1508 Use SAFE_ALLOCA_LISP, not alloca.
1509 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1510 to EMACS_INT. Check that fixnums are in proper range for system types.
1511 * minibuf.c (minibuf_prompt_width, string_to_object)
1512 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1513 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1515 (get_minibuffer, read_minibuf_unwind):
1516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1517 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1518 this simplifies overflow checking. All callers changed.
1519 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1520 (Ftest_completion):
1521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1522 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1523 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1524 Check that fixnums are in proper range for system types.
1525 (Fx_create_frame, Fx_show_tip):
1526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1527 * nsfont.m (ns_findfonts, nsfont_list_family):
1528 Don't assume fixnum fits in long.
1529 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1531 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1532 wide enough.
17fdb222 1533 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1534 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1535 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1536 (PRINTDECLARE, PRINTPREPARE):
1537 (strout, print_string):
1538 (print, print_preprocess, print_check_string_charset_prop)
1539 (print_object):
1540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1541 (PRINTDECLARE):
1542 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1544 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1545 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1546 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1547 (print_error_message): Use SAFE_ALLOCA, not alloca.
1548 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1549 (print_depth, new_backquote_output, print_number_index):
1550 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1551 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1552 (Fset_process_window_size, Fformat_network_address)
1553 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1554 (sigchld_handler):
d311d28c 1555 Check that fixnums are in proper range for system types.
d44287d4 1556 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1557 Check for process-ids out of pid_t range rather than relying on
1558 undefined behavior.
e4d81efc 1559 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1560 (Fformat_network_address, read_process_output, send_process)
1561 (Fprocess_send_region, status_notify):
1562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1563 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1564 (wait_reading_process_output, read_process_output, exec_sentinel):
1565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1566 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1567 (Faccept_process_output): Use duration_to_sec_usec to do proper
1568 overflow checking on durations.
dde14581
PE
1569 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1570 Don't assume pid_t fits in int.
02481186
PE
1571 * process.h (struct Lisp_Process): Members tick and update_tick
1572 are now of type EMACS_INT, not int.
b62b53e8
PE
1573 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1574 configured --with-wide-int.
d311d28c
PE
1575 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1576 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1577 * search.c (looking_at_1, string_match_1):
1578 (fast_string_match, fast_c_string_match_ignore_case)
1579 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1580 (scan_newline, find_before_next_newline, search_command)
1581 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1582 (set_search_regs, wordify):
1583 (Freplace_match):
1584 (Fmatch_data):
1585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1586 (string_match_1, search_buffer, set_search_regs):
1587 (Fmatch_data):
1588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1589 (wordify): Check for overflow in size calculation.
1590 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1591 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1592 Check that fixnums are in proper range for system types.
1593 * sound.c (struct sound_device)
1594 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1596 (Fplay_sound_internal):
1597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1598 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1599 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1600 (Fparse_partial_sexp):
1601 Don't assume fixnums can fit in int.
1602 (struct lisp_parse_state, find_start_pos, find_start_value)
1603 (find_start_value_byte, find_start_begv)
1604 (update_syntax_table, char_quoted, dec_bytepos)
1605 (find_defun_start, prev_char_comend_first, back_comment):
1606 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1607 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1609 (Finternal_describe_syntax_value): Check that match_lisp is a
1610 character, not an integer, since the code stuffs it into int.
1611 (scan_words, scan_sexps_forward):
1612 Check that fixnums are in proper range for system types.
1613 (Fforward_word):
1614 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1615 (scan_sexps_forward):
1616 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1617 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1618 * syntax.h: Adjust decls to match defn changes elsewhere.
1619 (struct gl_state_s):
1620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1621 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1622 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1623 * sysdep.c (wait_for_termination_1, wait_for_termination)
1624 (interruptible_wait_for_termination, mkdir):
1625 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1626 (emacs_read, emacs_write):
1627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1628 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1629 and double all fit in int.
d311d28c
PE
1630 * term.c (set_tty_color_mode):
1631 Check that fixnums are in proper range for system types.
1632 * termhooks.h (struct input_event):
1633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1634 * textprop.c (validate_interval_range, interval_of)
1635 (Fadd_text_properties, set_text_properties_1)
1636 (Fremove_text_properties, Fremove_list_of_text_properties)
1637 (Ftext_property_any, Ftext_property_not_all)
1638 (copy_text_properties, text_property_list, extend_property_ranges)
1639 (verify_interval_modification):
1640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1641 (Fnext_single_char_property_change)
1642 (Fprevious_single_char_property_change):
1643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1644 (copy_text_properties):
1645 Check for integer overflow in index calculation.
d311d28c
PE
1646 * undo.c (last_boundary_position, record_point, record_insert)
1647 (record_delete, record_marker_adjustment, record_change)
1648 (record_property_change):
1649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1650 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1652 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1653 (Fx_hide_tip, Fx_file_dialog):
1654 * w32menu.c (set_frame_menubar):
1655 Use ptrdiff_t, not int, for consistency with rest of code.
1656 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1657 (select_window, Fdelete_other_windows_internal)
1658 (window_scroll_pixel_based, window_scroll_line_based)
1659 (Frecenter, Fset_window_configuration):
1660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1661 (Fset_window_hscroll, run_window_configuration_change_hook)
1662 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1663 (Fscroll_other_window, Frecenter):
d311d28c
PE
1664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1665 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1666 Don't assume fixnum fits in int.
1667 (Fset_window_scroll_bars):
1668 Check that fixnums are in proper range for system types.
1669 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1670 (string_pos, c_string_pos, number_of_chars, init_iterator)
1671 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1672 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1673 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1674 (face_before_or_after_it_pos, handle_invisible_prop)
1675 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1676 (display_prop_intangible_p, string_buffer_position_lim)
1677 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1678 (get_overlay_strings_1, get_overlay_strings)
1679 (iterate_out_of_display_property, forward_to_next_line_start)
1680 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1681 (get_next_display_element, set_iterator_to_next)
1682 (get_visually_first_element, compute_stop_pos_backwards)
1683 (handle_stop_backwards, next_element_from_buffer)
1684 (move_it_in_display_line_to, move_it_in_display_line)
1685 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1686 (add_to_log, message_dolog, message_log_check_duplicate)
1687 (message2, message2_nolog, message3, message3_nolog
1688 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1689 (current_message_1, truncate_echo_area, truncate_message_1)
1690 (set_message, set_message_1, store_mode_line_noprop)
1691 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1692 (text_outside_line_unchanged_p, check_point_in_composition)
1693 (reconsider_clip_changes)
1694 (redisplay_internal, set_cursor_from_row, try_scrolling)
1695 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1696 (redisplay_window, find_last_unchanged_at_beg_row)
1697 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1698 (trailing_whitespace_p, find_row_edges, display_line)
1699 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1700 (display_mode_element, store_mode_line_string)
1701 (pint2str, pint2hrstr, decode_mode_spec)
1702 (display_count_lines, display_string, draw_glyphs)
1703 (x_produce_glyphs, x_insert_glyphs)
1704 (rows_from_pos_range, mouse_face_from_buffer_pos)
1705 (fast_find_string_pos, mouse_face_from_string_pos)
1706 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1708 (safe_call, init_from_display_pos, handle_fontified_prop)
1709 (handle_single_display_spec, load_overlay_strings)
1710 (with_echo_area_buffer, setup_echo_area_for_printing)
1711 (display_echo_area, echo_area_display)
1712 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1713 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1714 (redisplay_window, dump_glyph_row, display_mode_line)
1715 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1716 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1718 (handle_single_display_spec, build_desired_tool_bar_string)
1719 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1720 (get_specified_cursor_type):
1721 Check that fixnums are in proper range for system types.
1722 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1723 (Flookup_image_map):
1724 Don't assume fixnums fit in int.
1725 (compare_overlay_entries):
1726 Avoid mishandling comparisons due to subtraction overflow.
1727 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1728 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1729 (handle_tool_bar_click):
1730 Use int, not unsigned, since we prefer signed and the signedness
1731 doesn't matter here.
1732 (get_next_display_element, next_element_from_display_vector):
1733 Use int, not EMACS_INT, when int is wide enough.
1734 (start_hourglass): Use duration_to_sec_usec to do proper
1735 overflow checking on durations.
1736 * xfaces.c (Fbitmap_spec_p):
1737 Check that fixnums are in proper range for system types.
1738 (compare_fonts_by_sort_order):
1739 Avoid mishandling comparisons due to subtraction overflow.
1740 (Fx_family_fonts, realize_basic_faces):
1741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1742 (Fx_family_fonts):
1743 Don't assume fixnum fits in int.
1744 Use SAFE_ALLOCA_LISP, not alloca.
1745 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1746 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1747 (face_at_buffer_position, face_for_overlay_string)
1748 (face_at_string_position):
1749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1750 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1751 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1752 (Fx_show_tip):
1753 Check that fixnums are in proper range for system types.
1754 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1755 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1757 (Fx_change_window_property): Don't assume fixnums fit in int.
1758 * xfont.c (xfont_chars_supported):
1759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1760 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1761 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1763 * xml.c (parse_region):
1764 * xrdb.c (magic_file_p):
1765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1766 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1767 (x_get_local_selection, x_reply_selection_request)
1768 (x_handle_selection_request, wait_for_property_change):
1769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1770 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1771 short is wide enough.
1772 (x_send_client_event): Don't assume fixnum fits in int.
1773 * xterm.c (x_x_to_emacs_modifiers):
1774 Don't assume EMACS_INT overflows nicely into int.
1775 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1776 may come from Lisp.
1777 (handle_one_xevent): NATNUMP can eval its arg twice.
1778 (x_connection_closed):
1779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1780 * xterm.h: Adjust decls to match defn changes elsewhere.
1781 (struct scroll_bar): Use struct vectorlike_header
1782 rather than rolling our own approximation.
1783 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1784
c6574eb5
GM
17852012-05-25 Glenn Morris <rgm@gnu.org>
1786
1787 * lisp.mk (lisp): Update for more files being compiled now.
1788
e8d32c7e
SM
17892012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1790
48def666
SM
1791 * lread.c: Remove `read_pure' which makes no difference.
1792 (read_pure): Remove var.
1793 (unreadpure): Remove function.
1794 (readevalloop): Don't call read_list with -1 flag.
1795 (read1, read_vector): Don't test read_pure any more.
1796 (read_list): Simplify.
1797
e8d32c7e
SM
1798 * fileio.c, character.h: Minor style tweaks.
1799
4b2addb7
DA
18002012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1801
1802 * window.h (clip_changed): Remove useless declaration.
1803
584461b2
JB
18042012-05-22 Juanma Barranquero <lekktu@gmail.com>
1805
1806 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1807 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1808
34374650
PE
18092012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 Remove src/m/*.
1812 This directory predates autoconf and is no longer needed nowadays.
1813 Move its few remaining bits of functionality to where they're needed.
1814 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1815 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1816 * m/template.h: Remove.
1817 * Makefile.in (M_FILE): Remove. All uses removed.
1818 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1819 * lisp.h (USE_LSB_TAG):
1820 * mem-limits.h (EXCEEDS_LISP_PTR):
1821 Use VAL_MAX, not VALBITS, in #if.
1822 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1823 (EMACS_UINT): Define unconditionally now.
1824 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1825 (BITS_PER_EMACS_INT): New constants, replacing
1826 what used to be in config.h, but not useful in #if.
1827 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1828 define them any more.
1829 (VAL_MAX): New macro.
1830 (VALMASK): Use it.
1831 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1832 BITS_PER_EMACS_INT, in #if.
1833 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1834 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1835 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1836 * s/ms-w32.h (DATA_START):
1837 Move here from removed file m/intel386.h.
1838 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1839 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1840
261cb4bb
PE
18412012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1842
1843 Assume C89 or later.
1844 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1845 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1846 (xrealloc):
1847 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1848 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1849 * textprop.c, tparam.c (NULL): Remove.
1850 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1851 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1852 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1853 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1854 * xterm.c (input_signal_count): Assume volatile works.
1855
ff23cd9f
KB
18562012-05-21 Ken Brown <kbrown@cornell.edu>
1857
1858 * xgselect.c (xg_select): Fix first argument in call to 'select'
1859 (bug#11508).
1860
1b170bc6
KB
18612012-05-20 Ken Brown <kbrown@cornell.edu>
1862
1863 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1864 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1865
b2f4d39f
KB
18662012-05-19 Ken Brown <kbrown@cornell.edu>
1867
1868 * xfns.c (x_in_use): Remove `static' qualifier.
1869 * xterm.h (x_in_use): Declare.
1870 * xgselect.c: Include xterm.h.
1871 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1872 and `display_arg' (bug#9754).
1873
003fdae2
PE
18742012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1875
9232a6d9
PE
1876 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1877
003fdae2
PE
1878 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1879 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1880
784b56e2
EZ
18812012-05-18 Eli Zaretskii <eliz@gnu.org>
1882
1883 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1884
1885 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1886 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1887
1888 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1889 reference to image_cache->refcount.
1890 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1891
a0a79cde
JL
18922012-05-17 Juri Linkov <juri@jurta.org>
1893
1894 * search.c (Fword_search_regexp, Fword_search_backward)
1895 (Fword_search_forward, Fword_search_backward_lax)
1896 (Fword_search_forward_lax): Move functions to isearch.el
1897 (bug#10145, bug#11381).
1898
b0572523
PE
18992012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1900
1901 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1902
9660f5fc
SM
19032012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1904
1905 * lread.c (init_obarray): Declare Qt and Qnil as special.
1906
4374de83
GM
19072012-05-14 Glenn Morris <rgm@gnu.org>
1908
1909 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1910 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1911
dc44c39a
PE
19122012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1913
078c97cb
PE
1914 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1915
dc44c39a
PE
1916 * unexaix.c: Port to more-recent AIX compilers.
1917 (report_error, report_error_1, make_hdr, copy_sym)
1918 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1919 Make arguments const char *, not char *, to avoid violations of C
1920 standard and to fix some AIX warnings reported by Gilles Pion.
1921
e18afed7 19222012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1923
1924 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1925 already have overlays loaded.
1926 (handle_single_display_spec): Before returning without displaying
1927 fringe bitmap, synchronize the bidi iterator with the main display
1928 iterator, by calling iterate_out_of_display_property.
1929 (iterate_out_of_display_property): Detect buffer iteration by
1930 testing that it->string is a Lisp string.
1931 (get_next_display_element): When the current object is exhausted,
1932 and there's something on it->stack, call set_iterator_to_next to
1933 proceed with what's on the stack, instead of returning zero.
1934 (set_iterator_to_next): If called at the end of a Lisp string,
1935 proceed to consider_string_end without incrementing string
1936 position. Don't increment display vector index past the end of
1937 the display vector. (Bug#11417)
c8fb9dc6
EZ
1938 (pos_visible_p): Don't report a position visible when move_it_to
1939 stopped at the last line of window, which happens to be scanned
1940 backwards by the bidi iteration. (Bug#11464)
ac268e67 1941
e18afed7 19422012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1943
1944 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1945 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1946 are on a TTY, and thus unable to display on the fringes.
1947 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1948 so we need to signal to the caller that this is a "replacing"
1949 display spec. This fixes display when the spec is invalid or we
1950 are on a TTY.
1951
e18afed7 19522012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1953
1954 * unexaix.c (make_hdr): Fix typo in prototype.
1955 This bug broke the build on AIX. Problem reported by Gilles Pion.
1956
9d0a235a
MA
19572012-05-14 Michael Albinus <michael.albinus@gmx.de>
1958
1959 * keyboard.c (kbd_buffer_get_event): Read special events also in
1960 batch mode. (Bug#11415)
1961
9e6b06ed
GM
19622012-05-12 Glenn Morris <rgm@gnu.org>
1963
1964 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1965
c1a1d7a3
EZ
19662012-05-12 Eli Zaretskii <eliz@gnu.org>
1967
1968 * lisp.mk (lisp): Add newcomment.elc.
1969
3fe7cdc8
GM
19702012-05-12 Glenn Morris <rgm@gnu.org>
1971
1972 * Makefile.in (MKDIR_P): New, set by configure.
1973 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1974
53f7d2c0
PE
19752012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 Remove unused function hourglass_started.
1978 * dispextern.h (hourglass_started):
1979 * w32fns.c (hourglass_started):
1980 * xdisp.c (hourglass_started): Remove.
1981
75aafb17
JB
19822012-05-10 Juanma Barranquero <lekktu@gmail.com>
1983
1984 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1985 Update dependencies.
1986
12959e8e
PE
19872012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1988
97107e2e
PE
1989 * xgselect.c (xg_select): Put maxfds+1 into a var.
1990 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1991
12959e8e
PE
1992 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1993
836d29b3
DA
19942012-05-10 Dave Abrahams <dave@boostpro.com>
1995
1996 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1997 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1998
5cb67954
MA
19992012-05-09 Michael Albinus <michael.albinus@gmx.de>
2000
2001 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2002 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2003 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2004 Initialize xd_registered_buses.
2005
3478ec45
PE
20062012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2007
b263a6b0
PE
2008 Untag more efficiently if USE_LSB_TAG.
2009 This is based on a proposal by YAMAMOTO Mitsuharu in
2010 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2011 For an admittedly artificial (nth 8000 longlist) benchmark on
2012 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2013 Emacs's overall text size by 1%.
2014 * lisp.h (XUNTAG): New macro.
2015 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2016 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2017 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2018 * eval.c (Fautoload):
2019 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2020 * frame.h (XFRAME): Use XUNTAG.
2021
3478ec45
PE
2022 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2023 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2024 Remove unportable assumptions about print widths of types like
2025 dbus_uint32_t.
2026 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2027 intptr_t when converting between pointer and integer, to avoid GCC
2028 warnings about wrong width.
2029
666b903b 20302012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2031
2032 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2033 stack for each reader_thread, instead of defaulting to 8MB
2034 determined by the linker. This avoids failures in creating
2035 subprocesses on Windows 7, see the discussion in this thread:
2036 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2037
b120cc17
JC
20382012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2039
2040 Fix up display of the *Minibuf-0* buffer in the mini window.
2041 * keyboard.c (read_char): Don't clear the echo area if there's no
2042 message to clear.
2043 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2044 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2045
9a4b36f8
MA
20462012-05-07 Michael Albinus <michael.albinus@gmx.de>
2047
2048 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2049 batch mode.
2050
e5f9458f
CY
20512012-05-06 Chong Yidong <cyd@gnu.org>
2052
2053 * lisp.mk (lisp): Update.
2054
eceeb5fc 20552012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2056
2057 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2058
71873e2b
SM
20592012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2060
2061 * data.c (PUT_ERROR): New macro.
2062 (syms_of_data): Use it. Add new error type `user-error'.
2063 * undo.c (user_error): New function.
2064 (Fprimitive_undo): Use it.
2065 * print.c (print_error_message): Adjust print style for `user-error'.
2066 * keyboard.c (user_error): New function.
2067 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2068
ab0fa4e4
PE
20692012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2070
2071 Do not limit current-time-string to years 1000..9999.
2072 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2073 (Fcurrent_time_string): Support any year that is supported by the
2074 underlying localtime representation. Don't use asctime, as it
2075 has undefined behavior for years outside the range -999..9999.
2076
7ed806a7
PE
20772012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2078
2079 Fix race conditions involving setenv, gmtime, localtime, asctime.
2080 Without this fix, interrupts could mess up code that uses these
2081 nonreentrant functions, since setting TZ invalidates existing
2082 tm_zone or tzname values, and since most of these functions return
2083 pointers to static storage.
2084 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2085 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2086 Grow the critical sections to include not just invoking
2087 localtime/gmtime, but also accessing these functions' results
2088 including their tm_zone values if any, and any related TZ setting.
2089 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2090 so that the struct tm is saved in the critical section.
2091 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2092 motivated by the fact that memory allocation needs to be outside
2093 the critical section.
2094
0c16dfed
DA
20952012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2096
2097 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2098 with RESET_INTERVAL.
2099
2100 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2101 Remove duplicated buffer name initialization.
2102
3f83ace8
JM
21032012-05-02 Jim Meyering <jim@meyering.net>
2104
2105 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2106
c7b8541e
JM
2107 * xfns.c (x_window): Use xstrdup (Bug#11375).
2108
90207a15 21092012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2110
2111 * xdisp.c (pos_visible_p): If already at a newline from the
2112 display string before the 'while' loop, don't walk back the glyphs
2113 from it3.glyph_row. Solves assertion violation when the display
2114 string begins with a newline (egg.el). (Bug#11367)
2115
b593d6a9
AH
21162012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2117
2118 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2119 Move to simple.el.
2120
4737362e
GM
21212012-05-01 Glenn Morris <rgm@gnu.org>
2122
99cf43f9
GM
2123 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2124 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2125 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2126 All were removed before 23.1.
2127
9311dcff
GM
2128 * dispnew.c: Remove HAVE_LIBNCURSES test;
2129 it is always true on relevant platforms.
2130
4d5c6349
GM
2131 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2132 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2133
4737362e
GM
2134 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2135
74dd3a6b
AS
21362012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2137
2138 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2139 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2140 Remove.
2141
13c379ee
PE
21422012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2143
2144 Do not avoid creating empty evaporating overlays (Bug#9642).
2145 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2146 That is, do not delete an evaporating overlay if it becomes
2147 empty after its bounds are adjusted to fit within its buffer.
2148 This fix caused other problems, and I'm reverting it until we get
2149 to the bottom of them.
2150
a8e7d6d7 21512012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2152
2153 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2154
a8e7d6d7 21552012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2156
2157 * xdisp.c (pos_visible_p): If the window start position is beyond
2158 ZV, start the display from buffer beginning. Prevents assertion
2159 violation in init_iterator when the minibuffer window is scrolled
2160 via the scroll bar.
2161
2162 * window.c (window_scroll_pixel_based): Likewise.
2163
a8e7d6d7 21642012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2165
2166 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2167
a8e7d6d7 21682012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2169
2170 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2171 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2172
a8e7d6d7 21732012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2174
b593d6a9
AH
2175 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2176 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2177
1c6900d9
EZ
21782012-04-26 Eli Zaretskii <eliz@gnu.org>
2179
4c3fa1d9
EZ
2180 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2181 display element, check also the underlying string or buffer
2182 character. (Bug#11341)
2183
1c6900d9
EZ
2184 * w32menu.c: Include w32heap.h.
2185 (add_menu_item): If the call to AppendMenuW (via
2186 unicode_append_menu) fails, disable Unicode menus only if we are
2187 running on Windows 9X/Me.
2188
42bf8205
AS
21892012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2190
2191 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2192 (xgetint): Add missing shift for LSB tags.
2193
b1bac16e
MR
21942012-04-24 Martin Rudalics <rudalics@gmx.at>
2195
2196 * keyboard.c (read_char): Don't wipe echo area for select window
2197 events: These might get delayed via `mouse-autoselect-window'
2198 (Bug#11304).
2199
d69621cc
JB
22002012-04-24 Juanma Barranquero <lekktu@gmail.com>
2201
2202 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2203 manipulation of :loaded-from data.
2204
02fd101b
JB
22052012-04-23 Juanma Barranquero <lekktu@gmail.com>
2206
2207 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2208 now a cons (bug#11311).
2209
888bec30
PE
22102012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2211
89a438bd
PE
2212 Do not create empty overlays with the evaporate property (Bug#9642).
2213 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2214 if it becomes empty after its bounds are adjusted to fit within
2215 its buffer. Without this fix, in a nonempty buffer (let ((o
2216 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2217 yields an empty overlay that has the evaporate property, which is
2218 not supposed to happen.
2219
1068fe4d
PE
2220 Fix minor GTK3 problems found by static checking.
2221 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2222 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2223 (struct _EmacsFixedClass, emacs_fixed_get_type):
2224 Move decls here from emacsgtkfixed.h, since they needn't be public.
2225 (emacs_fixed_get_type): Now static.
2226 (emacs_fixed_class_init): Omit unused local.
2227 (emacs_fixed_child_type): Remove; unused.
2228 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2229 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2230 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2231 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2232 (EMACS_FIXED_GET_CLASS): Remove; unused.
2233 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2234
888bec30
PE
2235 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2236 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2237
de85e130
PE
22382012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2239
d0baac98 2240 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2241 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2242 (__malloc_size_t, __malloc_ptrdiff_t):
2243 Remove. All uses removed, replaced by the definiens if needed,
2244 since we can assume C89 or better now.
2245 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2246 (protect_malloc_state, align, get_contiguous_space)
2247 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2248 (malloc_atfork_handler_child, malloc_enable_thread)
2249 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2250 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2251 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2252 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2253 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2254 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2255 Define using prototypes, not old style.
2256 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2257 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2258 (align): Don't assume that signed integer overflow wraps around.
2259 Omit unused local var.
2260 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2261 (_free_internal_nolock, memalign, mallochook, reallochook):
2262 Omit no-longer-needed casts.
2263 (valloc): Use getpagesize, not __getpagesize.
2264 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2265 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2266
de85e130
PE
2267 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2268
dcbf5805
MA
22692012-04-22 Michael Albinus <michael.albinus@gmx.de>
2270
2271 Move functions from C to Lisp. Make non-blocking method calls
2272 the default. Implement further D-Bus standard interfaces.
2273
2274 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2275 (QCdbus_request_name_allow_replacement)
2276 (QCdbus_request_name_replace_existing)
2277 (QCdbus_request_name_do_not_queue)
2278 (QCdbus_request_name_reply_primary_owner)
2279 (QCdbus_request_name_reply_in_queue)
2280 (QCdbus_request_name_reply_exists)
2281 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2282 (QCdbus_registered_serial, QCdbus_registered_method)
2283 (QCdbus_registered_signal): New Lisp objects.
2284 (XD_DEBUG_MESSAGE): Use sizeof.
2285 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2286 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2287 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2288 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2289 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2290 (xd_signature, xd_append_arg): Allow float for integer types.
2291 (xd_get_connection_references): New function.
b593d6a9
AH
2292 (xd_get_connection_address): Rename from xd_initialize.
2293 Return cached address.
dcbf5805
MA
2294 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2295 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2296 level.
2297 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2298 Return number of refcounts.
dcbf5805
MA
2299 (Fdbus_get_unique_name): Make stronger parameter check.
2300 (Fdbus_message_internal): New defun.
2301 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2302 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2303 (Fdbus_send_signal, Fdbus_register_service)
2304 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2305 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2306 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2307 (Vdbus_compiled_version, Vdbus_runtime_version)
2308 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2309 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2310 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2311 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2312 Adapt docstring.
dcbf5805 2313
52828e02
PE
23142012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2315
da05bc4c
PE
2316 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2317 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2318 Do not assume ptrdiff_t is the same width as 'int'.
2319
52828e02
PE
2320 * alloc.c: Handle unusual debugging option combinations.
2321 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2322 since the two debugging options are incompatible.
2323 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2324 is defined.
2325 (mem_init, mem_insert, mem_insert_fixup):
2326 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2327 (NEED_MEM_INSERT): Remove; no longer needed.
2328
f01769f9
LL
23292012-04-22 Leo Liu <sdl.web@gmail.com>
2330
2331 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2332
5790543d
PE
23332012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2334
2335 * sysdep.c [__FreeBSD__]: Minor cleanups.
2336 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2337 Use Emacs indenting style more consistently. Avoid some casts.
2338 Use 'double' consistently rather than mixing 'float' and 'double'.
2339
b91b7e4d
EW
23402012-04-21 Eduard Wiebe <usenet@pusto.de>
2341
b593d6a9
AH
2342 * sysdep.c (list_system_processes, system_process_attributes):
2343 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2344
6114eb15
AS
23452012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2346
2347 * lisp.mk (lisp): Update.
2348
2f38dff7
PE
23492012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2350
2351 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2352 It is never used otherwise.
2353
4ae29f89
SM
23542012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2355
2356 * print.c (print_preprocess): Only check print_depth if print-circle
2357 is nil.
2358 (print_object): Check for cycles even when print-circle is nil and
2359 print-gensym is t, but only check print_depth if print-circle is nil.
2360
f30d612a
CY
23612012-04-20 Chong Yidong <cyd@gnu.org>
2362
2363 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2364 set the status to "failed" and ensure that sentinel is run.
2365
c07a4c0b 23662012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2367
2368 * process.c (Fset_process_inherit_coding_system_flag)
2369 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2370 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2371
c07a4c0b 23722012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2373
2374 * xdisp.c (string_buffer_position_lim): Limit starting position to
2375 BEGV.
2376 (set_cursor_from_row): If called for a mode-line or header-line
2377 row, return zero immediately.
2378 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2379 farther than the first row after the header line, if any.
2380 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2381 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2382
c07a4c0b 23832012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2384
4ae29f89
SM
2385 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2386 (bug#11238).
ad3a2b41 2387
c07a4c0b 23882012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 23892012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2390
2391 configure: new option --enable-gcc-warnings (Bug#11207)
2392 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2393 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2394 (ALL_CFLAGS): Use new macros rather than old.
2395 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2396 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2397 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2398 -Wunused-result, -Wunused-variable. This should go away once
2399 the Emacs and Gnulib regex code is merged.
2400 (xmalloc, xrealloc): Now static.
2401
aba027e8
PE
24022012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2403
2404 * dired.c (Fsystem_groups): Remove unused local.
2405
e5a36063
GM
24062012-04-17 Glenn Morris <rgm@gnu.org>
2407
2408 * dired.c (Fsystem_users): Doc fix.
2409
316411f0
DA
24102012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2411
2412 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2413 (syms_of_dired): Add them.
2414
9426aba4
PE
24152012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2416
b62a57be
PE
2417 Fix minor alloc.c problems found by static checking.
2418 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2419 New extern decls, to avoid calling undeclared functions.
2420 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2421 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2422 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2423 (NEED_MEM_INSERT): New macro.
2424 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2425 Remove one incorrect comment and fix another.
b62a57be 2426
3539f31f
PE
2427 Fix minor ralloc.c problems found by static checking.
2428 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2429 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2430 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2431 (r_alloc_sbrk): Now static.
2432
a041960a
PE
2433 Improve ralloc.c interface checking.
2434 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2435 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2436 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2437 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2438 [REL_ALLOC]: ... to here, to check interface.
2439 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2440 Remove decls. This fixes an "It stinks!".
2441
9426aba4
PE
2442 * alloc.c (which_symbols): Fix alignment issue / type clash.
2443
d55c12ed
AS
24442012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2445
2446 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2447 (struct Lisp_Misc_Any): Likewise.
2448 (struct Lisp_Free): Likewise.
2449 * alloc.c (union aligned_Lisp_Symbol): Define.
2450 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2451 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2452 (union aligned_Lisp_Misc): Define.
2453 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2454 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2455 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2456
b948ce8b
PE
24572012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2458
2459 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2460 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2461 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2462 * s/netbsd.h, s/sol2-6.h:
2463 Remove definition of GC_MARK_STACK, since the default now works.
2464 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2465 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2466 no longer the default.
2467 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2468
35dc09a1 24692012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2470
35dc09a1
GM
2471 * lread.c (lisp_file_lexically_bound_p):
2472 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2473
35dc09a1
GM
24742012-04-14 Eli Zaretskii <eliz@gnu.org>
2475
2476 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2477 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2478
24792012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2480
2481 * nsterm.m (constrainFrameRect): Always constrain when there is only
2482 one screen (Bug#10962).
2483
bcd86815
KB
24842012-04-13 Ken Brown <kbrown@cornell.edu>
2485
2486 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2487
c25df26e
RT
24882012-04-13 Reuben Thomas <rrt@sc3d.org>
2489
2490 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2491
0fc59f1e
DC
24922012-04-11 Daniel Colascione <dancol@dancol.org>
2493
2494 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2495 against is gone. It's better to use vfork now so that when Cygwin
2496 gains a new, working vfork, we use it automatically (bug#10398).
2497
de8c03dc
SM
24982012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2499
2500 * window.c (save_window_save): Obey window-point-insertion-type.
2501
2f097256
GM
25022012-04-11 Glenn Morris <rgm@gnu.org>
2503
2504 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2505
453b951e
SM
25062012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2507
2508 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2509
75f1671a 25102012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2511
2512 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2513 (force_quit_count): New var.
2514 (handle_interrupt): Use it.
2515
2a8ce227
JB
25162012-04-10 Juanma Barranquero <lekktu@gmail.com>
2517
2518 * w32.c (w32_delayed_load): Record the full path of the library
2519 being loaded (bug#10424).
2520
935396c0
GM
25212012-04-09 Glenn Morris <rgm@gnu.org>
2522
05920a43
GM
2523 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2524 not just in the obarray, before snarfing them. (Bug#11036)
2525
935396c0
GM
2526 * Makefile.in ($(leimdir)/leim-list.el):
2527 Pass EMACS rather than BUILT_EMACS.
2528
a18ecafa
TZ
25292012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2530
2531 * process.c (make_process):
2532 * process.h: Add integer `gnutls_handshakes_tried' member to
2533 process struct.
2534
6bbef4e5
JC
2535 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2536 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2537
2538 * gnutls.c (gnutls_log_function2i): Convenience log function.
2539 (emacs_gnutls_read): Use new log functions,
2540 `gnutls_handshakes_tried' process member, and
2541 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2542 attempts per process (connection).
2543
b4d3bc10
CY
25442012-04-09 Chong Yidong <cyd@gnu.org>
2545
2546 * eval.c (Fuser_variable_p, user_variable_p_eh)
2547 (lisp_indirect_variable): Functions deleted.
2548 (Fdefvar): Caller changed.
2549
2550 * callint.c (Finteractive, Fcall_interactively):
2551 * minibuf.c (Fread_variable): Callers changed.
2552
70f4d973
EZ
25532012-04-09 Eli Zaretskii <eliz@gnu.org>
2554
2555 * xdisp.c (set_cursor_from_row): If the display string appears in
2556 the buffer at position that is closer to point than the position
2557 after the display string, display the cursor on the first glyph of
2558 the display string. Fixes cursor display when a 'display' text
2559 property immediately follows invisible text. (Bug#11094)
2560
cb3c2e3e
PE
25612012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2562
2563 composite.c: use 'double' consistently
2564 * composite.c (get_composition_id): Use 'double' consistently
2565 instead of converting 'float' to 'double' and vice versa; this is
2566 easier to understand and avoids a GCC warning.
2567
fd06db5d
GM
25682012-04-09 Glenn Morris <rgm@gnu.org>
2569
50fe702a
GM
2570 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2571 preparation for dumping it with emacs. (Bug#4789)
2572 (leimdir): New variable.
2573 ($(leimdir)/leim-list.el): New rule.
2574 (emacs$(EXEEXT)): Depend on leim-list.el.
2575
fd06db5d
GM
2576 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2577 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2578 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2579
55c131ee
AS
25802012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2581
2582 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2583 proper alignment.
2584
9209588f
JB
25852012-04-07 Juanma Barranquero <lekktu@gmail.com>
2586
2587 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2588 Remove unused local variable.
2589
e3fb2efb
PE
25902012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2593 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2594 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2595 objects, as mark_maybe_pointer will catch them otherwise.
2596 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2597 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2598
b5385551
PE
25992012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 Fix typo that broke non-Windows builds.
2602 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2603
9078ead6
EZ
26042012-04-07 Eli Zaretskii <eliz@gnu.org>
2605
2606 Support building on MS-Windows with libxml2.
2607
2608 * makefile.w32-in (OBJ2): Add xml.$(O).
2609 (GLOBAL_SOURCES): Add xml.c.
2610 ($(BLD)/xml.$(O)): New dependency list.
2611
2612 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2613 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2614 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2615 [!WINDOWSNT]: New macros.
2616 (init_libxml2_functions, libxml2_loaded_p): New functions.
2617 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2618 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2619 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2620 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2621 linked in).
6bbef4e5
JC
2622 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2623 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2624 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2625
2626 * emacs.c: Don't include libxml/parser.h.
2627 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2628 xmlCleanupParser directly.
2629
2630 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2631
3811fdf3
EZ
26322012-04-07 Eli Zaretskii <eliz@gnu.org>
2633
2634 * indent.c (Fvertical_motion): If there is a display string at
2635 point, use it.vpos to compute how many lines to backtrack after
2636 move_it_to point. (Bug#11133)
2637
2f8e16b2
EZ
26382012-04-06 Eli Zaretskii <eliz@gnu.org>
2639
2640 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2641 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2642 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2643 macros related to unification of CJK characters. For the details,
2644 see the discussion following the message here:
2645 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2646
3d439cd1
CY
26472012-04-04 Chong Yidong <cyd@gnu.org>
2648
2649 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2650
8bc53d00
EZ
26512012-04-01 Eli Zaretskii <eliz@gnu.org>
2652
2653 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2654 instead of alloca. (Bug#11138)
2655
3b0512a3
AS
26562012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2657
2658 * w32menu.c (is_simple_dialog): Properly check lisp types.
2659 (Bug#11141)
2660
8427ddd2
EZ
26612012-03-31 Eli Zaretskii <eliz@gnu.org>
2662
979022ef
EZ
2663 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2664 position we get to after a call to move_it_to fails the
2665 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2666 only if we wind up in a string from display property. (Bug#11063)
2667
a6b1c7cc
EZ
2668 * window.c (Fdelete_other_windows_internal): Invalidate the row
2669 and column information about mouse highlight, so that redisplay
2670 restores it after reallocating the glyph matrices. (Bug#7464)
2671
8427ddd2
EZ
2672 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2673 string comes from a `display' text property, use the buffer
2674 position of that property as if we actually saw that position in
2675 the row's glyphs.
697ba24b
EZ
2676 (move_it_by_lines): Remove the assertion that
2677 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2678 violated when there's a before-string at the beginning of a line.
2679 (Bug#11063)
8427ddd2 2680
65a0a738
EZ
26812012-03-30 Eli Zaretskii <eliz@gnu.org>
2682
2683 * xdisp.c (append_space_for_newline): If the default face was
2684 remapped, use the remapped face for the appended newline.
2685 (extend_face_to_end_of_line): Use the remapped default face for
2686 extending the face to the end of the line.
2687 (display_line): Call extend_face_to_end_of_line when the default
2688 face was remapped. (Bug#11068)
2689
581355cc
EZ
26902012-03-29 Eli Zaretskii <eliz@gnu.org>
2691
2692 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2693
e8fc049f
SM
26942012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2695
2696 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2697
4fb9a543
GM
26982012-03-27 Glenn Morris <rgm@gnu.org>
2699
2700 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2701 Doc fixes.
2702
679910f1
KH
27032012-03-26 Kenichi Handa <handa@m17n.org>
2704
2705 * dispextern.h (struct glyph): Fix previous change. Change the
2706 bit length of glyphless.ch to 25 (Bug#11082).
2707
90d49b7f
CY
27082012-03-26 Chong Yidong <cyd@gnu.org>
2709
2710 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2711 (command_loop_1): Use it; inhibit selection update for
2712 handle-select-window too (Bug#8996).
2713
f514f6f0
FP
27142012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2715
e8fc049f 2716 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2717
bf43fa51
KH
27182012-03-25 Kenichi Handa <handa@m17n.org>
2719
2720 * dispextern.h (struct glyph): Change the bit length of
2721 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2722
8a0c01dd
EZ
27232012-03-24 Eli Zaretskii <eliz@gnu.org>
2724
2725 * s/ms-w32.h (tzname): Include time.h before redirecting to
2726 _tzname. Fixes the MSVC build. (Bug#9960)
2727
7d1c3a76
AS
27282012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2729
8ed79523
AS
2730 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2731 characters.
2732
7d1c3a76
AS
2733 * xterm.c (XTread_socket): Only modify handling_signal if
2734 !SYNC_INPUT. (Bug#11080)
2735
e99a9b8b
EZ
27362012-03-23 Eli Zaretskii <eliz@gnu.org>
2737
2738 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2739 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2740 when fetching a multibyte character consumes more bytes than
2741 CHAR_BYTES returns, due to unification of CJK characters in
2742 string_char. (Bug#11073)
2743
5063c0e1
TN
27442012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2745
2746 * process.c (wait_reading_process_output): Handle pty disconnect
2747 by refraining from sending oneself a SIGCHLD (bug#10933).
2748
9f851fbd
CY
27492012-03-22 Chong Yidong <cyd@gnu.org>
2750
2751 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2752
5063c0e1 2753 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2754 Mark string as coming from a prefix property.
2755 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2756 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2757
fb5b8aca
CY
27582012-03-21 Chong Yidong <cyd@gnu.org>
2759
2760 * xfaces.c (Vface_remapping_alist): Doc fix.
2761
62356a1b
EZ
27622012-03-20 Eli Zaretskii <eliz@gnu.org>
2763
2764 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2765 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2766 Doc fixes.
62356a1b 2767
025de85b
CY
27682012-03-20 Chong Yidong <cyd@gnu.org>
2769
2770 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2771 to reflect default non-nil value of redisplay-dont-pause.
2772
4827f94e
KH
27732012-03-19 Kenichi Handa <handa@m17n.org>
2774
2775 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2776 it fit in a valid range (Bug#11003).
2777
e50a24a2
EZ
27782012-03-18 Eli Zaretskii <eliz@gnu.org>
2779
2780 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2781 that is not from display property, accept the row as a "cursor
2782 row" if one of the string's character has a non-nil `cursor'
2783 property. Fixes cursor positioning when there are newlines in
2784 overlay strings, e.g. in icomplete.el. (Bug#11035)
2785
9af5ed87
PE
27862012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2787
2788 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2789
d1f55f16
CY
27902012-03-12 Chong Yidong <cyd@gnu.org>
2791
2792 * eval.c (inhibit_lisp_code): Rename from
2793 inhibit_window_configuration_change_hook; move from window.c.
2794
2795 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2796 * window.c (run_window_configuration_change_hook)
2797 (syms_of_window): Callers changed.
2798
66c5eebd
CY
27992012-03-11 Chong Yidong <cyd@gnu.org>
2800
413df973
CY
2801 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2802
66c5eebd
CY
2803 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2804
1de11f56
CY
28052012-03-10 Chong Yidong <cyd@gnu.org>
2806
2807 * frame.c (other_visible_frames): Don't assume the selected frame
2808 is visible (Bug#10955).
2809
cae07000
SM
28102012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2811
2812 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2813
89c94350
JD
28142012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2815
2816 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2817 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2818 zero (Bug#10954).
2819
999dd333
GM
28202012-03-03 Glenn Morris <rgm@gnu.org>
2821
01a6dcc8 2822 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2823
de0100f2
EZ
28242012-03-02 Eli Zaretskii <eliz@gnu.org>
2825
2826 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2827 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2828 (redisplay_window, next_element_from_string): Fix typos in
2829 comments.
3e441275
EZ
2830 (redisplay_window): Pass to move_it_vertically the margin in
2831 pixels, not in screen lines.
de0100f2 2832
96a72ee9
GM
28332012-03-02 Glenn Morris <rgm@gnu.org>
2834
2835 * buffer.c (buffer-list-update-hook): Doc fix.
2836
312508d7
EZ
28372012-02-29 Eli Zaretskii <eliz@gnu.org>
2838
2839 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2840 push_it before setting up the iterator for the first overlay
2841 string, even if we have an empty string loaded.
2842 (next_overlay_string): If there's an empty string on the iterator
2843 stack, pop the stack. (Bug#10903)
2844
27f3c637
PE
28452012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2846
2847 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2848 Suggested by Stefan Monnier in
2849 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2850 * alloc.c (widen_to_Lisp_Object): New static function.
2851 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2852 and widening them to Lisp_Objects. This would work even if
2853 USE_LSB_TAG is defined and wide integers are used, which might
2854 happen in a future version of Emacs.
2855
3c9dfce6
CY
28562012-02-25 Chong Yidong <cyd@gnu.org>
2857
fa74b241
CY
2858 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2859 Doc fix.
2860
3c9dfce6
CY
2861 * xselect.c (Fx_selection_exists_p): Doc fix.
2862 (x_clipboard_manager_save_all): Print an informative message
2863 before saving to clipboard manager.
2864
9486df08
CY
28652012-02-24 Chong Yidong <cyd@gnu.org>
2866
2867 * keyboard.c (process_special_events): Handle all X selection
2868 requests in kbd_buffer, not just the next one (Bug#8869).
2869
f01d3321
CY
28702012-02-23 Chong Yidong <cyd@gnu.org>
2871
2872 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2873 call when setting menu-bar-lines and tool-bar-lines parameters.
2874 (unwind_create_frame_1): New helper function.
2875
2876 * window.c (inhibit_window_configuration_change_hook): New var.
2877 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2878 (syms_of_window): Initialize it.
f01d3321 2879
86b847b6
CY
28802012-02-22 Chong Yidong <cyd@gnu.org>
2881
2882 * xterm.c (x_draw_image_relief): Add missing type check for
2883 Vtool_bar_button_margin (Bug#10743).
2884
a59225b1
CY
28852012-02-21 Chong Yidong <cyd@gnu.org>
2886
2887 * fileio.c (Vfile_name_handler_alist): Doc fix.
2888
2889 * buffer.c (Fget_file_buffer): Protect against invalid file
2890 handler return value.
2891
310f5bd4
PE
28922012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2893
cb3a28cc
PE
2894 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2895 when computing $valmask.
2896
310f5bd4
PE
2897 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2898 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2899 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2900 It's useless in that case, and it can cause problems on hosts
2901 that allocate halves of EMACS_INT values separately.
2902 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2903 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2904 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2905 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2906 it avoids undefined behavior on hosts where shifting right by more
2907 than the word width has undefined behavior.
2908
2375c96a
CY
29092012-02-19 Chong Yidong <cyd@gnu.org>
2910
2911 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2912 (Funhandled_file_name_directory, Ffile_name_as_directory)
2913 (Fdirectory_file_name, Fexpand_file_name)
2914 (Fsubstitute_in_file_name): Protect against invalid file handler
2915 return values (Bug#10845).
2916
3eb49e71
EZ
29172012-02-18 Eli Zaretskii <eliz@gnu.org>
2918
2919 * .gdbinit (pitx): Fix incorrect references to fields of the
2920 iterator stack.
2921
7b926f3f
CY
29222012-02-17 Chong Yidong <cyd@gnu.org>
2923
2924 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2925
11273115
PE
29262012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2927
2928 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2929 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2930
c3a70e2b
CY
29312012-02-15 Chong Yidong <cyd@gnu.org>
2932
2933 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2934 marked as special. Also, starting docstrings with * is obsolete.
2935
0ca43699
AS
29362012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2937
2938 * gnutls.c (emacs_gnutls_write): Fix last change.
2939
2e8f3c56
LI
29402012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2941
2942 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2943 send_process.
2944
af70074f
SM
29452012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2946
2947 * keymap.c (Fsingle_key_description): Handle char ranges.
2948
95986d52
CY
29492012-02-12 Chong Yidong <cyd@gnu.org>
2950
afd83bd1
CY
2951 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2952 as that creates a dangerous corner case.
2953
95986d52
CY
2954 * window.c (Fdelete_window_internal): Invalidate the mouse
2955 highlight (Bug#9904).
2956
bd7da63e
GM
29572012-02-12 Glenn Morris <rgm@gnu.org>
2958
2959 * xselect.c (Fx_own_selection_internal)
2960 (Fx_get_selection_internal, Fx_disown_selection_internal)
2961 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2962 * nsselect.m (Fx_own_selection_internal)
2963 (Fx_disown_selection_internal, Fx_selection_exists_p)
2964 (Fx_selection_owner_p, Fx_get_selection_internal):
2965 Sync docs and argument specs with the xselect.c versions.
2966
77abcbc2
LI
29672012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2968
2969 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2970
90b671e2
EZ
29712012-02-11 Eli Zaretskii <eliz@gnu.org>
2972
1c0ca0b7
EZ
2973 * w32select.c (Fx_selection_exists_p): Sync doc string and
2974 argument list with xselect.c. (Bug#10783)
2975
2976 * w16select.c (Fx_selection_exists_p): Sync doc string and
2977 argument list with xselect.c. (Bug#10783)
90b671e2 2978
49241268
GM
29792012-02-10 Glenn Morris <rgm@gnu.org>
2980
2981 * fns.c (Fsecure_hash): Doc fix.
2982
f998bbe7 29832012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2984
2985 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2986
0992bd9c
CY
29872012-02-07 Chong Yidong <cyd@gnu.org>
2988
2989 * buffer.c (Fbuffer_local_variables)
2990 (buffer_lisp_local_variables): Handle unbound vars correctly;
2991 don't let Qunbound leak into Lisp.
2992
af008560
GM
29932012-02-07 Glenn Morris <rgm@gnu.org>
2994
dd605cc4
GM
2995 * image.c (Fimagemagick_types): Doc fix.
2996
af008560
GM
2997 * image.c (imagemagick-render-type): Change it from a lisp object
2998 to an integer. Move the doc here from the lisp manual.
2999 Treat all values not equal to 0 the same.
3000
1449fa1d
CY
30012012-02-06 Chong Yidong <cyd@gnu.org>
3002
3003 * doc.c (store_function_docstring): Avoid applying docstring of
3004 alias to base function (Bug#2603).
3005
3723ec07
AS
30062012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3007
3008 * .gdbinit (pp1, pv1): Remove redundant defines.
3009 (pr): Use pp.
3010
79c1cc1e
CY
30112012-02-04 Chong Yidong <cyd@gnu.org>
3012
3013 * nsterm.m: Declare a global (Bug#10694).
3014
d7f29f8e
EZ
30152012-02-04 Eli Zaretskii <eliz@gnu.org>
3016
cae07000
SM
3017 * w32.c (get_emacs_configuration_options):
3018 Include --enable-checking, if specified, in the return value.
d7f29f8e 3019
3b95a6f9
MR
30202012-02-04 Martin Rudalics <rudalics@gmx.at>
3021
3022 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3023 after rounding frame sizes. (Bug#9723)
3024
d6fa96a6
EZ
30252012-02-04 Eli Zaretskii <eliz@gnu.org>
3026
3027 * keyboard.c (adjust_point_for_property): Don't position point
3028 before BEGV. (Bug#10696)
3029
df0b2940
PE
30302012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3031
3032 Handle overflow when computing char display width (Bug#9496).
3033 * character.c (char_width): Return EMACS_INT, not int.
3034 (char_width, c_string_width): Check for overflow when
3035 computing the width; this is possible now that individual
3036 characters can have unbounded width. Problem introduced
3037 by merge from Emacs 23 on 2012-01-19.
3038
6bee44d6
MA
30392012-02-02 Michael Albinus <michael.albinus@gmx.de>
3040
3041 * dbusbind.c (Fdbus_register_method): Mention the return value
3042 :ignore in the docstring.
3043
44f92739
GM
30442012-02-02 Glenn Morris <rgm@gnu.org>
3045
1b9f60cc
GM
3046 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3047
44f92739
GM
3048 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3049 Unconditionally set to t. (Bug#10673)
3050 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3051 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3052 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3053
c5d3843c
KH
30542012-02-02 Kenichi Handa <handa@m17n.org>
3055
3056 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3057 0, do not call append_composite_glyph.
3058
159462d4 30592012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3060
3061 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3062 NULL (Bug#6988).
3063 (x_produce_glyphs): If the component of a composition is a null
3064 string, set it->pixel_width to 1 to avoid zero-width glyph.
3065
78cef877
EZ
30662012-02-01 Eli Zaretskii <eliz@gnu.org>
3067
3068 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3069 first 2 arguments are identical. This makes inserting large
3070 output from a subprocess an order of magnitude faster on
3071 MS-Windows, where all sbrk'ed memory is always contiguous.
3072
97897668
GM
30732012-01-31 Glenn Morris <rgm@gnu.org>
3074
3075 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3076 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3077 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3078
31fd3586
GM
30792012-01-29 Glenn Morris <rgm@gnu.org>
3080
3081 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3082
0e24a8b2
CY
30832012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3084
3085 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3086
cc0adcb0
CY
30872012-01-28 Chong Yidong <cyd@gnu.org>
3088
3089 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3090
acc28cb9
CY
30912012-01-26 Chong Yidong <cyd@gnu.org>
3092
9c69cfb7
CY
3093 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3094
acc28cb9
CY
3095 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3096 repeat counts (Bug#10507).
3097
48da7392
GM
30982012-01-26 Glenn Morris <rgm@gnu.org>
3099
3100 * lread.c (syms_of_lread): Doc fix.
3101
14af5f7f
CY
31022012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3103
3104 * coding.c (encode_designation_at_bol): Change return value to
3105 EMACS_INT.
3106
0b21c100
CY
31072012-01-25 Chong Yidong <cyd@gnu.org>
3108
3109 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3110
3c2907f7
CY
31112012-01-21 Chong Yidong <cyd@gnu.org>
3112
3113 * floatfns.c (Fcopysign): Make the second argument non-optional,
3114 since nil is not allowed anyway.
3115
959ad23f
AS
31162012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3117
3118 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3119 (send_process): Likewise.
3120
34a02f46
MR
31212012-01-19 Martin Rudalics <rudalics@gmx.at>
3122
3123 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3124 (Vwindow_persistent_parameters): Do not use Qstate.
3125 Rewrite doc-strings.
34a02f46 3126
1259009a 31272012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3128
3129 * character.c (char_width): New function.
70d4fdf6
GM
3130 (Fchar_width, c_string_width, lisp_string_width):
3131 Use char_width (Bug#9496).
25ed9e61 3132
6a6ee00d
MR
31332012-01-16 Martin Rudalics <rudalics@gmx.at>
3134
3135 * window.c (Vwindow_persistent_parameters): New variable.
3136 (Fset_window_configuration, save_window_save): Handle persistent
3137 window parameters.
3138
c85efaf7
EZ
31392012-01-14 Eli Zaretskii <eliz@gnu.org>
3140
3141 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3142 thrashing the stack of the thread. (Bug#9087)
3143
5944709e
PE
31442012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3145
3146 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3147
e71f5d99
EZ
31482012-01-11 Eli Zaretskii <eliz@gnu.org>
3149
3150 * xdisp.c (rows_from_pos_range): Handle the case where the
3151 highlight ends on a newline. (Bug#10464)
3152 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3153 he end column for display of highlight that ends on a newline
3154 before a R2L line.
3155
ce316182
GM
31562012-01-11 Glenn Morris <rgm@gnu.org>
3157
3158 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3159 from load-path also when installation-directory is nil. (Bug#10208)
3160
5b43da69
GM
31612012-01-10 Glenn Morris <rgm@gnu.org>
3162
74cc8ff9
GM
3163 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3164
7d8d6e4e
GM
3165 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3166 Update template values to be closer to their typical values these days.
5b43da69 3167
a0db8d43
EZ
31682012-01-09 Eli Zaretskii <eliz@gnu.org>
3169
3170 * xdisp.c (rows_from_pos_range): Accept additional argument
3171 DISP_STRING, and accept any glyph in a row whose object is that
3172 string as eligible for mouse highlight. Fixes mouse highlight of
3173 display strings from overlays. (Bug#10464)
3174
9a0115ab 31752012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3176
b9110d6a 3177 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3178 * fileio.c (auto_saving_dir_umask): New static var.
3179 (Fmake_directory_internal): Use it.
3180 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3181 creating the directory. The old code temporarily assigns
3182 too-generous permissions to the directory.
3183 (do_auto_save_eh): Clear it.
b9110d6a 3184 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3185 that the var is always cleared.
3186
6c1bd3f3
EZ
31872012-01-07 Eli Zaretskii <eliz@gnu.org>
3188
3189 * search.c (scan_buffer): Pass character positions to
3190 know_region_cache, not byte positions. (Bug#6540)
3191
069d2b50
L
31922012-01-07 LynX <_LynX@bk.ru> (tiny change)
3193
3194 * w32.c (sys_rename): Report EXDEV when rename of a directory
3195 fails because the target is on another logical disk. (Bug#10284)
3196
75bf0d33
DB
31972012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3198
3199 * xterm.c (x_embed_request_focus): New function.
3200
3201 * xterm.h: Add prototype.
3202
3203 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3204
1c6e5a32
GM
32052012-01-05 Glenn Morris <rgm@gnu.org>
3206
3207 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3208
651e947e
EZ
32092012-01-01 Eli Zaretskii <eliz@gnu.org>
3210
3211 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3212 Load gnutls_transport_set_lowat only if GnuTLS version is below
3213 2.11.1.
3214 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3215 GnuTLS versions below 2.11.1.
3216
3778cdd8
AL
32172011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3218
3219 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3220 to the doc string advising against its use for altering the way
3221 windows are scrolled.
3222
0e5317f7
KH
32232011-12-28 Kenichi Handa <handa@m17n.org>
3224
3225 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3226 coding-system ASCII compatible only when it does not produce BOM
3227 on encoding (Bug#10383).
3228
93d5ca1f
JD
32292011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3230
3231 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3232 can scroll.
3233 (create_and_show_popup_menu): Always use menu_position_func for
3234 Gtk3 (Bug#10361).
3235
ca22b785
AS
32362011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3237
3238 * callint.c (Fcall_interactively): Don't truncate prompt string.
3239
d048e1e6
EZ
32402011-12-23 Eli Zaretskii <eliz@gnu.org>
3241
3242 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3243 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3244 resumed from there (after widening). (Bug#10360)
d048e1e6 3245
5ccaba1f
JD
32462011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3247
3248 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3249
204ee57f
JD
32502011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3251
b81d40f0
JB
3252 * nsterm.m (x_free_frame_resources):
3253 Release f->output_data.ns->miniimage.
204ee57f
JD
3254 (ns_index_color): Fix indentation. Do not retain
3255 color_table->colors[i].
3256
3257 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3258 before returning.
3259
3260 * nsfns.m (x_set_background_color): Assign return value from
3261 ns_index_color to face-background instead of NSColor*.
3262 (ns_implicitly_set_icon_type): Fix indentation.
3263 Change assignment in for loop to comparison.
3264
3265 * emacs.c (ns_pool): New variable.
3266 (main): Assign ns_pool.
3267 (Fkill_emacs): Call ns_release_autorelease_pool.
3268
3269 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3270 autorelease fdesc, release fdAttrs and tdict.
3271 (ns_get_covering_families): Release charset.
3272 (ns_findfonts): Release NSFontDescriptor created with new.
3273 (ns_uni_to_glyphs): Fix indentation.
3274 (setString): Release attrStr before assigning new value.
3275
c803b2b7
JD
32762011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3277
678f4426
JD
3278 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3279 and NS_IMPL_COCOA.
3280 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3281 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3282
cd394be1 32832011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3284
5fecd5fc
JD
3285 * nsterm.m (ns_term_init): Subscribe for notifications
3286 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3287 to method trackingNotification in EmacsMenu.
3288
3289 * nsmenu.m (trackingMenu): New variable.
3771cb17 3290 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3291 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3292 from Aquamacs (Bug#7030).
678f4426
JD
3293
32942011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3295
c803b2b7
JD
3296 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3297 (symbol_to_nsstring): Fix indentation.
3298 (ns_symbol_to_pb): New function.
cae07000
SM
3299 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3300 (Fns_rotate_cut_buffers_internal): Remove.
3301 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3302 Fns_store_cut_buffer_internal.
3303 (ns_get_foreign_selection, Fx_own_selection_internal)
3304 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3305 (Fns_get_selection_internal, Fns_store_selection_internal):
3306 Use ns_symbol_to_pb and check if return value is nil.
3307 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3308 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3309 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3310 renamed to Sns_store_selection_internal.
3311 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3312 and remove this function.
3313 (ns_handle_selection_clear): Remove, never used.
3314 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3315 here.
3316
e1b01a3a
KB
33172011-12-17 Ken Brown <kbrown@cornell.edu>
3318
3319 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3320 GID is unknown (Bug#10257).
3321
2adb6e85
PE
33222011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3323
3324 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3325 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3326 which caused a build failure on GNU/Linux IA-64. This problem was
3327 introduced by my 2011-10-07 patch.
3328
d1d7b339
JL
33292011-12-15 Juri Linkov <juri@jurta.org>
3330
3331 * image.c (imagemagick_error): New function. (Bug#10112)
3332 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3333 Use `imagemagick_error' where ImageMagick functions return
3334 `MagickFalse'.
3335 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3336 proper order.
3337
100d5755
KH
33382011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3339
3340 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3341 fill background (Bug#8992).
3342
454592a6
MR
33432011-12-13 Martin Rudalics <rudalics@gmx.at>
3344
3345 * window.c (Vwindow_combination_resize)
3346 (Vwindow_combination_limit): Use t instead of non-nil in
3347 doc-strings.
61d4b438
MR
3348 (Vrecenter_redisplay): Add first sentence of doc-string on
3349 separate line.
53524d93 3350 (Frecenter): Fix doc-string typo.
454592a6 3351
3633e3aa
KH
33522011-12-11 Kenichi Handa <handa@m17n.org>
3353
3354 * coding.c (Funencodable_char_position): Pay attention to the
3355 buffer text relocation (Bug#9389).
3356
7b9d523a 33572011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3358
7b9d523a
JD
3359 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3360 gtk_init (Bug#10100).
3361
b73189c6
EZ
33622011-12-10 Eli Zaretskii <eliz@gnu.org>
3363
3364 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3365 IT->string is nil. (Bug#10263)
3366
f7dfe5d6
JD
33672011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3368
83faebb4
JD
3369 * nsterm.h (x_free_frame_resources): Declare.
3370
f7dfe5d6
JD
3371 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3372 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3373
3374 * nsterm.h (ns_get_defaults_value): Declare.
3375
3376 * nsterm.m (ns_default): Call ns_get_defaults_value.
3377
7cd4e72c
EZ
33782011-12-09 Eli Zaretskii <eliz@gnu.org>
3379
3380 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3381 (Bug#10170)
3382
b34d7317
YM
33832011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3384
3385 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3386 that where the value of an _OBJC_* symbol points to is in the .bss
3387 section (Bug#10240).
3388
76470ad1
KH
33892011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3390
3391 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3392 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3393
745fff94
KH
33942011-12-08 Kenichi Handa <handa@m17n.org>
3395
3396 * ftfont.c (get_adstyle_property): Fix previous change
3397 (Bug#10233).
3398
6e44397c
JB
33992011-12-07 Juanma Barranquero <lekktu@gmail.com>
3400
3401 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3402 dirs from the default value of EMACSLOADPATH (bug#10208).
3403
7efa6272
GM
34042011-12-07 Glenn Morris <rgm@gnu.org>
3405
3406 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3407 installation and source directories as well. (Bug#10208)
3408
f6fc4d87
CY
34092011-12-06 Chong Yidong <cyd@gnu.org>
3410
3411 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3412
2bf26180
GM
34132011-12-06 Glenn Morris <rgm@gnu.org>
3414
3415 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3416 as an error, not just -1. (Bug#10217)
3417
3a6ad4f0
CY
34182011-12-05 Chong Yidong <cyd@gnu.org>
3419
3420 * keyboard.c (process_special_events): New function.
3421 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3422
75a3b399
PE
34232011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3424
3425 * coding.c (encode_designation_at_bol): Don't use uninitialized
3426 local variable (Bug#9318).
3427
c3c9e25e
KH
34282011-12-05 Kenichi Handa <handa@m17n.org>
3429
3430 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3431 return Qnil (Bug#8046, Bug#10193).
3432
5eb05ea3
KH
34332011-12-05 Kenichi Handa <handa@m17n.org>
3434
3435 * coding.c (encode_designation_at_bol): New args charbuf_end and
3436 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3437 (coding_set_source): Return how many bytes coding->source was
3438 relocated.
3439 (coding_set_destination): Return how many bytes
3440 coding->destination was relocated.
3441 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3442 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3443
34442011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3445
3446 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3447 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3448 macro (Bug#9318).
3449
34502011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3451
3452 The following changes are to fix Bug#9318.
3453
a79703f5 3454 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3455 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3456 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3457 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3458
7dbda6df
JB
34592011-12-05 Juanma Barranquero <lekktu@gmail.com>
3460
3461 * lisp.h (process_quit_flag): Fix external declaration.
3462
6d5eb5b0
SM
34632011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3464
3465 Don't macro-inline non-performance-critical code.
3466 * eval.c (process_quit_flag): New function.
3467 * lisp.h (QUIT): Use it.
3468
a0c3fad0
JD
34692011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3470
3471 * nsfns.m (get_geometry_from_preferences): New function.
3472 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3473
6c07aac2
AS
34742011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3475
3476 * emacs.c (Qkill_emacs): Define.
3477 (syms_of_emacs): Initialize it.
3478 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3479 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3480 (quit_throw_to_read_char): Add parameter `from_signal'.
3481 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3482 * lisp.h (QUIT): Call Fkill_emacs if requested.
3483
c052ead4
JD
34842011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3485
3486 * widget.c (update_wm_hints): Return if wmshell is null.
3487 (widget_update_wm_size_hints): New function.
3488
3489 * widget.h (widget_update_wm_size_hints): Declare.
3490
3491 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3492 widget_update_wm_size_hints (Bug#10104).
3493
9e49252b
EZ
34942011-12-03 Eli Zaretskii <eliz@gnu.org>
3495
3496 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3497 before a newline, prepare the bidi iterator for consuming the
3498 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3499 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3500
02b16839
JL
35012011-12-02 Juri Linkov <juri@jurta.org>
3502
3503 * search.c (Fword_search_regexp): New Lisp function created from
3504 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3505 (Fword_search_backward, Fword_search_forward)
3506 (Fword_search_backward_lax, Fword_search_forward_lax):
3507 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3508 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3509
0068070e
SM
35102011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3511
3512 * fileio.c (Finsert_file_contents): Move after-change-function call
3513 to before the "handled:" label, since all "goto handled" appear in
3514 cases where the *-change-functions have already been properly called
3515 (bug#10117).
3516
3360a3fc
AS
35172011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3518
3519 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3520 waiting for input. (Bug#10169)
3521
73d6c093
EZ
35222011-11-30 Eli Zaretskii <eliz@gnu.org>
3523
3524 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3525 verifies glyph row's hash code--we have just reallocated the
3526 glyphs, so their contents can be complete garbage. (Bug#10164)
3527
febe6bea
JB
35282011-11-30 Juanma Barranquero <lekktu@gmail.com>
3529
3530 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3531
801a4313
EZ
35322011-11-30 Eli Zaretskii <eliz@gnu.org>
3533
3534 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3535 attributes are tested _before_ calling verify_row_hash, to protect
3536 against GCC re-ordering of the tests. (Bug#10164)
3537
2b56b87e
JD
35382011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3539
3540 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3541
3542 * xterm.c (handle_one_xevent): Only set async_visible and friends
3543 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3544 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3545 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3546
dbf31225
PE
35472011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3548
3549 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3550 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3551 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3552 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3553 All uses changed to use GCPRO1 etc.
3554 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3555 Revert to old implementation (i.e., before 2011-03-11).
3556
1305621b
YM
35572011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3558
3559 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3560 of scroll runs so as to avoid assigning disabled bogus rows and
3561 unnecessary graphics copy operations.
3562
8c9afb46
EZ
35632011-11-27 Eli Zaretskii <eliz@gnu.org>
3564
3565 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3566 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3567 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3568 (malloc, free, realloc, calloc): Redirect to e_* only when
3569 compiling Emacs.
3570
3571 * lisp.h (GCTYPEBITS): Move before first use.
3572 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3573 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3574 this macro definition.
3575
3576 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3577 _MSC_VER.
3578
54e9e3bf
JD
35792011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3580
6d5eb5b0
SM
3581 * gtkutil.c (xg_create_frame_widgets):
3582 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3583 present with Gtk+ 2.0.
3584
83aca1cb
PE
35852011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3586
3587 * fileio.c (Finsert_file_contents): Undo previous change; see
3588 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3589
5b76caa4
PE
35902011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3591
3592 Rename locals to avoid shadowing.
3593 * fileio.c (Finsert_file_contents):
3594 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3595 * process.c (wait_reading_process_output):
3596 Rename inner 'proc' to 'p' to avoid shadowing.
3597 Indent for consistency with usual Emacs style.
3598
8c535114
EZ
35992011-11-25 Eli Zaretskii <eliz@gnu.org>
3600
3601 * xdisp.c (redisplay_window): If cursor row is not fully visible
3602 after recentering, and scroll-conservatively is set to a large
3603 number, scroll window by a few more lines to make the cursor fully
3604 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3605 (start_display): Don't move to the next line if the display should
3606 start at a newline that is part of a display vector or an overlay
3607 string. (Bug#10119)
8c535114 3608
fa4fdb5c
JL
36092011-11-24 Juri Linkov <juri@jurta.org>
3610
3611 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3612 after the `MagickPingImage' call. (Bug#10112)
3613
90ec88df
CY
36142011-11-23 Chong Yidong <cyd@gnu.org>
3615
3616 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3617
56e2e794
MR
36182011-11-23 Martin Rudalics <rudalics@gmx.at>
3619
3620 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3621 making another buffer current. (Bug#10114)
3622
b6e64c41
GM
36232011-11-23 Glenn Morris <rgm@gnu.org>
3624
3625 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3626
6b21de18
CY
36272011-11-23 Chong Yidong <cyd@gnu.org>
3628
3629 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3630 using it (Bug#5984).
3631
b12cd789
EZ
36322011-11-22 Eli Zaretskii <eliz@gnu.org>
3633
3634 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3635 and header-lines, as they don't have one computed for them.
3636 (Bug#10098)
3637
3638 * .gdbinit (prow): Make displayed values more self-explaining.
3639 Add row's hash code.
3640
261b6fd4
LMI
36412011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3642
3643 * process.c (wait_reading_process_output): Fix asynchrounous
3644 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3645 (wait_reading_process_output): Add comment and URL.
261b6fd4 3646
e7cfd277
JD
36472011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3648
3649 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3650
a9b9b7f5
CY
36512011-11-21 Chong Yidong <cyd@gnu.org>
3652
3653 * window.c (Fnext_window, Fprevious_window): Doc fix.
3654
b0d15b4f
SM
36552011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3656
3657 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3658
fe7a3057
JB
36592011-11-20 Juanma Barranquero <lekktu@gmail.com>
3660
3661 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3662
d2999b1a
MR
36632011-11-20 Martin Rudalics <rudalics@gmx.at>
3664
3665 * window.c (Fset_window_combination_limit): Rename argument
3666 STATUS to LIMIT.
3667 (Vwindow_combination_limit): Remove "status" from doc-string.
3668
d5ff9cd0
AS
36692011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3670
3671 * m/ibms390.h: Remove.
3672 * m/ibms390x.h: Don't include "ibms390.h".
3673
a5bb9bd3
SM
36742011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3675
3676 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3677 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3678
cd1181db
JB
36792011-11-20 Juanma Barranquero <lekktu@gmail.com>
3680
3681 * casetab.c (Fset_case_table):
3682 * charset.c (Fcharset_after): Fix typos.
3683
615a3b8d 36842011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3685
17e845af
PE
3686 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3687 Otherwise, valgrind does not work on some platforms.
3688 Problem reported by Andreas Schwab in
6a0bf43d
PE
3689 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3690 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3691 is set, removing the need for VIRT_ADDRESS_VARIES.
3692 (PURE_P): Use a more-efficient implementation that needs just one
3693 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3694 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3695 to 4 (xorl, subq, cmpq, setbe).
3696 * alloc.c (pure): Always extern now, since that's the
3697 VIRT_ADDR_VARIES behavior.
3698 (PURE_POINTER_P): Use a single comparison, not two, for
3699 consistency with the new puresize.h.
3700 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3701 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3702 Remove VIRT_ADDR_VARIES no longer needed.
3703
f8fe6f96
EZ
37042011-11-19 Eli Zaretskii <eliz@gnu.org>
3705
3706 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3707 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3708 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3709 behave as if the cursor position were at the window margin.
3710
3711 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3712 and the cursor position is out of bounds, behave as if the cursor
3713 position were at the window margin. (Bug#10075)
3714
df05a53c
CY
37152011-11-18 Chong Yidong <cyd@gnu.org>
3716
3717 * window.c (Fwindow_combination_limit): Make first argument
3718 non-optional, since it is meaningless for live windows like the
3719 selected window.
61ccba97 3720
2071918e
DA
37212011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3722
3723 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3724
b50a28de
SM
37252011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3726
3727 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3728 (graft_intervals_into_buffer): Simplify.
3729
015137db
EZ
37302011-11-18 Eli Zaretskii <eliz@gnu.org>
3731
3732 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3733 hash values of the two rows.
3734 (copy_row_except_pointers): Preserve the used[] arrays and the
3735 hash values of the two rows. (Bug#10035)
68c95424 3736 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3737
3738 * xdisp.c (row_hash): New function, body extracted from
3739 compute_line_metrics.
3740 (compute_line_metrics): Call row_hash, instead of computing the
3741 hash code inline.
3742
3743 * dispnew.c (verify_row_hash): Call row_hash for computing the
3744 hash code of a row, instead of duplicating code from xdisp.c.
3745
3746 * dispextern.h (row_hash): Add prototype.
3747
a2addb04
TH
37482011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3749
3750 * frame.c (delete_frame): Don't delete the terminal when the last
3751 X frame is closed if emacs is built with GTK toolkit.
3752
df85d315
JB
37532011-11-17 Juanma Barranquero <lekktu@gmail.com>
3754
3755 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3756
a0c2d0ae
MR
37572011-11-17 Martin Rudalics <rudalics@gmx.at>
3758
3759 * window.c (Vwindow_splits): Rename to
3760 Vwindow_combination_resize. Suggested by Juri Linkov.
3761 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3762 of Vwindow_splits.
3763
58179cce
JB
37642011-11-16 Juanma Barranquero <lekktu@gmail.com>
3765
7877f373
JB
3766 * nsfns.m (Fns_font_name):
3767 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3768
b6f67890
MR
37692011-11-16 Martin Rudalics <rudalics@gmx.at>
3770
3771 * window.h (window): Rename slot "nest" to "combination_limit".
3772 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3773 (Fset_window_nest): Rename to Fset_window_combination_limit.
3774 (Vwindow_nest): Rename to Vwindow_combination_limit.
3775 (recombine_windows, make_parent_window, make_window)
3776 (Fsplit_window_internal, saved_window)
3777 (Fset_window_configuration, save_window_save): Rename all
3778 occurrences of window_nest to window_combination_limit.
3779
c7015153
JB
37802011-11-15 Juanma Barranquero <lekktu@gmail.com>
3781
3782 * image.c (imagemagick_load_image): Fix typo.
3783
322ad6ec
EZ
37842011-11-14 Eli Zaretskii <eliz@gnu.org>
3785
3786 * xdisp.c (display_line): Move the call to
3787 highlight_trailing_whitespace before the call to
3788 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3789 faces of all the glyphs to compute ROW's hash value.
3790 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3791
f067b8ec
JB
37922011-11-14 Juanma Barranquero <lekktu@gmail.com>
3793
3794 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3795 just return (bug#10044).
3796
1e5b2111
EZ
37972011-11-12 Eli Zaretskii <eliz@gnu.org>
3798
7ef3cbd5
EZ
3799 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3800 with user-defined heap size. Bump the default size of the temacs
3801 heap to 27MB, to avoid memory warning when running temacs.
3802 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3803
1e5b2111
EZ
3804 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3805 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3806 (verify_row_hash) [XASSERTS]: New function.
3807 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3808 that the hash value of glyph rows is correct.
1e5b2111 3809
89d61221
MR
38102011-11-12 Martin Rudalics <rudalics@gmx.at>
3811
3812 * window.h (window): Remove splits slot.
3813 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3814 (Fdelete_other_windows_internal, make_parent_window)
3815 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3816 (Fset_window_configuration, save_window_save): Don't deal with
3817 split status of windows.
3818 (saved_window): Remove splits slot.
3819 (Vwindow_splits): Rewrite doc-string.
3820
97f18cc8
JD
38212011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3822
3823 * xfns.c (unwind_create_frame):
3824 * nsfns.m (unwind_create_frame):
3825 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3826 Vframe_list (Bug#9999).
3827
22a648b4
DA
38282011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3829
0b381c7e 3830 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3831
659afede
KH
38322011-11-11 Kenichi Handa <handa@m17n.org>
3833
3834 * callproc.c (Fcall_process): Set the member dst_multibyte of
3835 process_coding.
3836
9ac0394b
KH
38372011-11-11 Johan Bockgård <bojohan@gnu.org>
3838
3839 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3840 avoid a crash (bug#9496).
3841
2fbdc249
CY
38422011-11-09 Chong Yidong <cyd@gnu.org>
3843
3844 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3845 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3846
ac6b1f81
PE
38472011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3848
3849 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3850
09db192c
PE
38512011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3852
3853 Avoid some portability problems by eschewing 'extern inline' functions.
3854 The trivial performance wins aren't worth the portability hassles; see
3855 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3856 et seq.
3857 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3858 (window_box_width, window_box_left, window_box_left_offset)
3859 (window_box_right, window_box_right_offset): Undo previous change,
3860 by removing the "extern"s.
3861 * intervals.c (adjust_intervals_for_insertion)
3862 (adjust_intervals_for_deletion): Undo previous change,
3863 making these static again.
3864 (offset_intervals, temp_set_point_both, temp_set_point)
3865 (copy_intervals_to_string): No longer inline.
3866 * xdisp.c (window_text_bottom_y, window_box_width)
3867 (window_box_height, window_box_left_offset)
3868 (window_box_right_offset, window_box_left, window_box_right)
3869 (window_box): No longer inline.
3870
105216ed
CY
38712011-11-08 Chong Yidong <cyd@gnu.org>
3872
3873 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3874 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3875 Signal an error if not a live window.
105216ed
CY
3876 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3877 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3878
ae9e237f
JB
38792011-11-07 Juanma Barranquero <lekktu@gmail.com>
3880
3881 * lisp.h (syms_of_abbrev): Remove declaration.
3882 Reported by CHENG Gao <chenggao@royau.me>.
3883
c7aa8333
EZ
38842011-11-07 Eli Zaretskii <eliz@gnu.org>
3885
3886 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3887 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3888 of temacs in GUI mode.
3889
be7f5545
MR
38902011-11-07 Martin Rudalics <rudalics@gmx.at>
3891
3892 * window.h: Declare delete_all_child_windows instead of
3893 delete_all_subwindows.
3894 * window.c (Fwindow_nest, Fset_window_nest)
3895 (Fset_window_new_total, Fset_window_new_normal)
3896 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3897 (delete_all_subwindows): Rename to delete_all_child_windows.
3898 (Fdelete_other_windows_internal, Fset_window_configuration):
3899 Call delete_all_child_windows instead of delete_all_subwindows.
3900 * frame.c (delete_frame): Call delete_all_child_windows instead
3901 of delete_all_subwindows.
3902
ca78dc43
PE
39032011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3904
3905 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3906 This is also needed for porting to any host where GC_MARK_STACK is
3907 not GC_MAKE_GCPROS_NOOPS.
3908 (which_symbols): Use it.
3909
a0241d01
KH
39102011-11-07 Kenichi Handa <handa@m17n.org>
3911
3912 * coding.c (coding_set_destination): Check coding->src_pos only
3913 when coding->src_object is a buffer (bug#9910).
3914
3915 * process.c (send_process): Set the member src_multibyte of coding
3916 to 0 (bug#9911) when sending a unibyte text.
3917
3918 * callproc.c (Fcall_process): Set the member src_multibyte of
3919 process_coding to 0 (bug#9912).
3920
a64bfdfa 39212011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3922
3923 * xmenu.c (cleanup_widget_value_tree): New function.
3924 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3925 calling free_menubar_widget_value_tree directly (Bug#9830).
3926
cb41b32a
PE
39272011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3928
3929 Fix some portability problems with 'inline'.
3930 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3931 (window_box_width, window_box_left, window_box_left_offset)
3932 (window_box_right, window_box_right_offset): Declare extern.
3933 Otherwise, these inline functions do not conform to C99 and
3934 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3935 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3936 * intervals.c (adjust_intervals_for_insertion)
3937 (adjust_intervals_for_deletion): Now extern, because otherwise the
3938 extern inline functions 'offset_intervals' couldn't refer to it.
3939 (static_offset_intervals): Remove.
3940 (offset_intervals): Rewrite using the old contents of
3941 static_offset_intervals. The old version didn't conform to C99
3942 because an extern inline function contained a reference to an
3943 identifier with static linkage.
3944
b7041366
AS
39452011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3946
3947 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3948 GC.
3949
88a37c4d
EZ
39502011-11-06 Eli Zaretskii <eliz@gnu.org>
3951
3952 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3953 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3954 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3955 return Qleft_to_right.
3956
49745b39
CY
39572011-11-06 Chong Yidong <cyd@gnu.org>
3958
3959 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3960 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3961 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3962 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3963 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3964 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3965 (Fwindow_vscroll): Doc fix.
3966 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3967 argument, since it makes no sense to pass a live window and for
3968 consistency with window-child.
3969
1f05cd82
CS
39702011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3971
3972 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3973 support MSVC.
3974
22610910
JR
39752011-11-05 Jason Rumney <jasonr@gnu.org>
3976
3977 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3978 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3979 fonts (Bug#6029).
3980 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3981 bitwise arithmetic preventing use of unicode-sip and non-truetype
3982 opentype fonts.
3983
a06776b2
EZ
39842011-11-05 Eli Zaretskii <eliz@gnu.org>
3985
3ad924ba
EZ
3986 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3987 "emacs"-only part.
3988
a06776b2
EZ
3989 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3990 initialization code to keep similarity to xfns.c after changes
3991 from 2011-11-05.
3992
c9e7db78
JD
39932011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3994
a97f8f3f
JD
3995 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3996 (unwind_create_frame): New function (Bug#9943).
3997 (Fx_create_frame): Restructure code to be more similar to the one in
3998 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3999 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4000 Move terminal->reference_count++ just before making the frame official
4001 (Bug#9943).
4002
4003 * nsterm.m (x_free_frame_resources): New function.
4004 (x_destroy_window): Move code to x_free_frame_resources.
4005
c9e7db78 4006 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4007 (Fx_create_frame, x_create_tip_frame):
4008 Move terminal->reference_count++ just before making the frame
75f1671a 4009 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4010 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4011
a6fc3b5c
EZ
40122011-11-05 Eli Zaretskii <eliz@gnu.org>
4013
4014 Support MSVC build with newer versions of Visual Studio.
4015 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4016 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4017 nt/gmake.defs.
4018
4019 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4020 which are not supported by MSVC.
4021 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4022 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4023 bitfields.
4024 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4025 types in bitfields.
4026 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4027
4028 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4029
58179cce 40302011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4031
4032 Support MSVC build with newer versions of Visual Studio.
4033 * w32.c: Don't include w32api.h for MSVC.
4034 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4035
4036 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4037 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4038 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4039 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4040 e_* cousins.
4041 (alloca) [_MSC_VER]: Define to _alloca.
4042
4043 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4044
4045 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4046
a58c13ed
EZ
40472011-11-04 Eli Zaretskii <eliz@gnu.org>
4048
4049 * xdisp.c (note_mouse_highlight): If either of
4050 previous/next-single-property-change returns nil, treat that as
4051 the beginning or the end of the buffer. (Bug#9955)
4052
fe0b6370
JD
40532011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4054
a58c13ed 4055 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4056 label is not null (Bug#9951).
4057 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4058 may be NULL.
4059
89bd5ee1
EZ
40602011-11-04 Eli Zaretskii <eliz@gnu.org>
4061
4062 * window.c (Fwindow_body_size): Mention in the doc string that the
4063 return value is in frame's canonical units. (Bug#9949)
4064
84c3edb9
EZ
40652011-11-03 Eli Zaretskii <eliz@gnu.org>
4066
4e2fb5c7
EZ
4067 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4068
84c3edb9 4069 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4070 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4071 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4072
bc17a887
EZ
40732011-11-01 Eli Zaretskii <eliz@gnu.org>
4074
4075 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4076 Don't stop backward scan on the continuation glyph, even though
4077 its CHARPOS is positive.
6d5eb5b0
SM
4078 (mouse_face_from_buffer_pos, note_mouse_highlight):
4079 Rename cover_string to disp_string.
bc17a887 4080
4ee88440
MR
40812011-11-01 Martin Rudalics <rudalics@gmx.at>
4082
4083 * window.c (temp_output_buffer_show): Don't use
4084 Vtemp_buffer_show_specifiers.
4085 (Vtemp_buffer_show_specifiers): Remove unused variable.
4086
c2ff3c02
EZ
40872011-10-30 Eli Zaretskii <eliz@gnu.org>
4088
4089 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4090 past the beginning of the current glyph matrix.
4091
58179cce 40922011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4093
4094 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4095 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4096 HAVE_GTK3 (Bug#9869).
b77a6a7f 4097
3b574623
JD
4098 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4099 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4100
b77a6a7f
JD
4101 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4102
4103 * xterm.c: Declare x_handle_net_wm_state to return int.
4104 (handle_one_xevent): Check if we are iconified but don't have
4105 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4106 (get_current_wm_state): Return non-zero if not hidden,
4107 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4108 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4109 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4110 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4111
196e41e4
PE
41122011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4113
4114 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4115 so that this new function doesn't get optimized away by a
4116 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4117
021f2e1a
AS
41182011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4119
4120 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4121
8b058d44
EZ
41222011-10-29 Eli Zaretskii <eliz@gnu.org>
4123
4124 Fix the `xbytecode' command.
4125 * .gdbinit (xprintbytestr): New command.
b50a28de 4126 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4127 (xbytecode): Print the byte-code string as well.
4128
4452fb80
EZ
41292011-10-29 Kim Storm <storm@cua.dk>
4130
8b058d44
EZ
4131 * alloc.c (which_symbols): New function.
4132
21b72067
AS
41332011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4134
4135 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4136 line. (Bug#9903)
4137
83ed7b5c
GM
41382011-10-29 Glenn Morris <rgm@gnu.org>
4139
4140 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4141 Not clear what it was for, and it causes various bugs. (Bug#9839)
4142
5a7a728b
EZ
41432011-10-28 Eli Zaretskii <eliz@gnu.org>
4144
4145 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4146 possible random value that matches one of those tested as
4147 condition to clear the mouse face.
4148
d3d0842f
CY
41492011-10-28 Chong Yidong <cyd@gnu.org>
4150
4151 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4152
31b39d13
DN
41532011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4154
4155 * window.c (make_window): Initialize phys_cursor_on_p.
4156
9aba6043
SM
41572011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4158
4159 * lisp.h (struct Lisp_Symbol): Update comments.
4160
c20992f4
JB
41612011-10-28 Juanma Barranquero <lekktu@gmail.com>
4162
4163 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4164
db4f02f2
EZ
41652011-10-28 Eli Zaretskii <eliz@gnu.org>
4166
4167 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4168 <oslsachem@gmail.com> for helping to debug this.
4169
4170 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4171 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4172 (g_b_init_get_glyph_outline_w): New static variables.
4173 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4174 (GetGlyphOutlineW_Proc): New typedefs.
4175 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4176 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4177 New functions.
4178 (w32font_open_internal, compute_metrics):
4179 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4180 instead of calling the "wide" APIs directly.
4181
4182 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4183
4184 * w32.h (syms_of_w32font): Add prototype.
4185
87e68db4
JB
41862011-10-27 Juanma Barranquero <lekktu@gmail.com>
4187
4188 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4189 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4190 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4191 (Fmove_to_window_line): Doc fix.
4192
435c1d67
CY
41932011-10-27 Chong Yidong <cyd@gnu.org>
4194
4195 * process.c (make_process): Set gnutls_state to NULL.
4196
4197 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4198 non-NULL, regardless of GNUTLS_INITSTAGE.
4199 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4200 an error. Set process slots as soon as we allocate them.
4201
4202 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4203
9c6c6f49
CY
42042011-10-27 Chong Yidong <cyd@gnu.org>
4205
9aba6043
SM
4206 * gnutls.c (emacs_gnutls_deinit): New function.
4207 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4208 (Fgnutls_deinit, Fgnutls_boot): Use it.
4209
4210 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4211 (deactivate_process): Call emacs_gnutls_deinit.
4212
657d08d3
JB
42132011-10-27 Juanma Barranquero <lekktu@gmail.com>
4214
4215 * image.c (x_create_x_image_and_pixmap):
4216 * w32.c (sys_rename, w32_delayed_load):
4217 * w32font.c (fill_in_logfont):
4218 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4219
5430d399
JB
42202011-10-26 Juanma Barranquero <lekktu@gmail.com>
4221
4222 * w32fns.c (w32_default_color_map): New function,
4223 extracted from Fw32_default_color_map.
a7ef684b 4224 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4225
fe0055fa
PE
42262011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4227
4228 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4229
e6346438
SM
42302011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4231
4232 * keyboard.c (test_undefined): New function (bug#9751).
4233 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4234
e112cc37
ET
42352011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4236
4237 * sysdep.c (init_sys_modes): Fix the check for the controlling
4238 terminal (Bug#6649).
4239
7b5d6677
EZ
42402011-10-20 Eli Zaretskii <eliz@gnu.org>
4241
4242 * dispextern.h (struct bidi_it): New member next_en_type.
4243
4244 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4245 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4246 current character, check also for next_en_type being WEAK_EN.
4247 (bidi_resolve_weak): Don't enter the expensive loop if the current
4248 position is before next_en_pos. Record the bidi type of the first
4249 non-ET, non-BN character we find, in addition to its position.
4250 (bidi_level_of_next_char): Invalidate next_en_type when
4251 next_en_pos is over-stepped.
4252
7da0b018
PE
42532011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4254
4255 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4256 * editfns.c: Rewrite current-time-zone so that it invokes
4257 the equivalent of (format-time-string "%Z") to get the time zone name.
4258 This fixes a bug when the time zone name contains characters that
4259 need converting from the system time locale to Emacs internal format.
4260 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4261 that patch fixed format-time-string to do the conversion, but
4262 I forgot to fix current-time-zone.
4263 (format_time_string): New function, containing most of
4264 what Fformat_time_string used to contain.
4265 (Fformat_time_string): Rewrite in terms of format_time_string.
4266 This doesn't change this function's behavior.
4267 (current-time-zone): Rewrite to use format_time_string.
4268 This fixes the bug reported by Michael Schierl in
4269 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4270 Jason Rumney's 2007-06-07 change worked around this bug, but
4271 didn't fix it.
4272 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4273
8547b010
EZ
42742011-10-19 Eli Zaretskii <eliz@gnu.org>
4275
4276 * xdisp.c (start_display): If the character at POS is displayed
4277 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4278 (try_window_reusing_current_matrix): If a line ends in a display
4279 vector or the next line starts in a display vector, continue
4280 redrawing the window even though the character position of
4281 start_row was reached.
8547b010
EZ
4282 (Bug#9771, part 2)
4283
4e948d15
CY
42842011-10-18 Chong Yidong <cyd@gnu.org>
4285
4286 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4287 with nobreak-char-display too.
4288
4787455f
EZ
42892011-10-18 Eli Zaretskii <eliz@gnu.org>
4290
4291 Fix part 3 of bug#9771.
4292 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4293 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4294 non-neutral characters if the current character is a paragraph
4295 separator (a.k.a. Newline). This avoids running the same
4296 expensive loop twice, once when we consume the preceding newline
4297 and the other time when the line actually needs to be displayed.
4298 Avoid the loop when we see neutrals on the base embedding level
4299 following a character whose directionality is the same as the
4300 paragraph's. This avoids running the expensive loop when a line
4301 ends in a long sequence of neutrals, like control characters.
4302 Add assertion against STRONG_AL type. Slightly rearrange code
4303 that determines the type of a neutral given the first non-neutral
4304 that follows it.
4305 (bidi_level_of_next_char): Set next_en_pos to zero when
4306 invalidating its info.
4307
2c91f553
EZ
43082011-10-17 Eli Zaretskii <eliz@gnu.org>
4309
4310 * xdisp.c (push_display_prop): Determine whether to record string
4311 or buffer position by IT->string, not by IT->method. Allow
4312 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4313 (move_it_vertically_backward): Don't look for character position
4314 immediately after the newline when in a continuation line.
4315 (Bug#9771, part 1)
2c91f553 4316
c7b08b0d
MR
43172011-10-15 Martin Rudalics <rudalics@gmx.at>
4318
4319 * window.c (coordinates_in_window): Rewrite and delabelize
4320 vertical border check. (Bug#5357) (Bug#9618)
4321
6b02f655
SM
43222011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4323
4324 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4325 errors in XSetWindowBorder (bug#9310).
4326
81d40c92
DA
43272011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4328
4329 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4330 avoid crash when xmalloc overrun checking is enabled.
4331
d4172c3b
EZ
43322011-10-13 Eli Zaretskii <eliz@gnu.org>
4333
4334 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4335 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4336 cursor motion with <left> and <right> arrow keys.
4337
4338 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4339 some callers set that themselves.
4340
b00eea75
EZ
43412011-10-12 Eli Zaretskii <eliz@gnu.org>
4342
4343 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4344 display string and the previous row comes from the same string and
4345 is empty. (Bug#9739) (Bug#9738)
4346
8fe012c4
SM
43472011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4348
4349 * doc.c (get_doc_string): Encode file name (bug#9735).
4350
0074aef2
EZ
43512011-10-12 Eli Zaretskii <eliz@gnu.org>
4352
79beb178
EZ
4353 * bidi.c (bidi_level_of_next_char):
4354 * xdisp.c (get_visually_first_element): Remove old incorrect
4355 comments regarding the Unicode Line Separator character.
4356
0074aef2
EZ
4357 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4358
6e4b3fbe
DA
43592011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4360
4361 * alloc.c (Fgc_status): Do not access beyond zombies array
4362 boundary if nzombies > MAX_ZOMBIES.
4363 * alloc.c (dump_zombies): Add missing format specifier.
4364
0324f3af
PE
43652011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4366
b5525cac
PE
4367 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4368 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4369
0324f3af
PE
4370 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4371 Some packages use them to denote characters with modifiers.
4372
e9b5f888
AS
43732011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4374
4375 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4376 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4377 matching a pp-number. Rename parameter var to var1.
4378
127827c0
SM
43792011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4380
4381 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4382
c8fd3bd0
GM
43832011-10-08 Glenn Morris <rgm@gnu.org>
4384
4385 * callint.c (Fcall_interactively): Give a more explicit error for the
4386 'c' case with a non-character input. (Bug#8479)
4387
352ec8ff
EZ
43882011-10-08 Eli Zaretskii <eliz@gnu.org>
4389
03669ccb
EZ
4390 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4391 lines.
7061c986
EZ
4392 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4393 lines that are hscrolled on the left.
03669ccb 4394
352ec8ff
EZ
4395 * dispnew.c (buffer_posn_from_coords): Account for a possible
4396 presence of header-line. (Bug#4426)
4397
a66cfb1c
SM
43982011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4399
6b02f655
SM
4400 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4401 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4402
7c5ee88e
PE
44032011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4404
4405 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4406 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4407 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4408 this makes Emacs dump core during garbage collection on rare
4409 occasions. sizeof is obviously inferior to offsetof here, so
4410 stick with offsetof.
4411 (GC_POINTER_ALIGNMENT): New macro.
4412 (mark_memory): Omit 3rd (offset) arg; caller changed.
4413 Don't assume EMACS_INT alignment is the same as pointer alignment.
4414
df1bbe5b
SM
44152011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4416
4417 * keyboard.c (read_key_sequence_remapped): New var.
4418 (read_key_sequence): Compute remapping in the right buffer.
4419 (command_loop_1): Use read_key_sequence's remapping directly.
4420
51553db6
SM
44212011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4422
32c1fffd
SM
4423 * dired.c (file_name_completion): Don't expand file name.
4424 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4425 before checking file name handler.
4426
51553db6
SM
4427 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4428 they've been requested explicitly (bug#9591).
4429
b6bd1599 44302011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4431
4432 * keymap.c (Fsingle_key_description): Use make_specified_string
4433 instead of build_string to build string from push_key_description.
4434 (Bug#5193)
4435
f701dc2a
PE
44362011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4437
4222c55d
PE
4438 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4439 This fixes a Y2038 bug on 64-bit hosts.
4440 * buffer.c (reset_buffer):
4441 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4442 (Fclear_buffer_auto_save_failure):
4443 Use 0, not -1, to represent an unset failure time, since time_t
4444 might not be signed.
4445
f701dc2a
PE
4446 Remove dependency on glibc malloc internals.
4447 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4448 Move back here from lisp.h, but with their new implementations.
4449 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4450 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4451 * charset.c (charset_table_init): New static var.
4452 (syms_of_charset): Use it instead of xmalloc. This removes a
4453 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4454 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4455 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4456 Move back to alloc.c.
4457 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4458 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4459
9ceebf39
JD
44602011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4461
4462 * nsterm.m (windowDidResize): Call x_set_window_size only when
4463 ns_in_resize is true. Otherwise set pixelwidth/height and
4464 call change_frame_size (Bug#9628).
4465
cb993c58
PE
44662011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4467
3930c88b
PE
4468 Port --enable-checking=all to Fedora 14 x86-64.
4469 * charset.c (syms_of_charset): Also account for glibc malloc's
4470 internal overhead when calculating the initial malloc maximum.
4471
cb993c58
PE
4472 Port --enable-checking=all to Fedora 14 x86.
4473 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4474 Move to lisp.h.
4475 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4476 (overrun_check_realloc, overrun_check_free):
4477 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4478 That way, xmalloc returns a properly-aligned pointer even if
4479 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4480 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4481 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4482 into account when calculating the initial malloc maximum.
4483 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4484 Move here from alloc.c, so that charset.c can use it too.
4485 Properly align; the old code wasn't right for common 32-bit hosts
4486 when configured with --enable-checking=all.
4487 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4488 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4489
31bed486
EZ
44902011-09-29 Eli Zaretskii <eliz@gnu.org>
4491
04c70788 4492 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4493 use EDOM.
4494
fbcaa2f3
EZ
44952011-09-28 Eli Zaretskii <eliz@gnu.org>
4496
4497 * xdisp.c (compute_display_string_end): If there's no display
4498 string at CHARPOS, return -1.
4499
4500 * bidi.c (bidi_fetch_char): When compute_display_string_end
4501 returns a negative value, treat the character as a normal
4502 character not covered by a display string. (Bug#9624)
4503
a239d4e9
JB
45042011-09-28 Juanma Barranquero <lekktu@gmail.com>
4505
4506 * lread.c (Fread_from_string): Fix typo in docstring.
4507
88652fd5
EZ
45082011-09-27 Eli Zaretskii <eliz@gnu.org>
4509
4510 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4511 newline, reseat the iterator instead of bidi-iterating there one
4512 character at a time. (Bug#9610)
32c1fffd
SM
4513 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4514 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4515
ed497dd4
AS
45162011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4517
4518 * lread.c (readevalloop): Use correct code for NBSP.
4519 (read1): Likewise. (Bug#9608)
4520
b2bf61aa
MA
45212011-09-25 Michael Albinus <michael.albinus@gmx.de>
4522
4523 * dbusbind.c (Fdbus_register_signal): When service is not
4524 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4525
32bbb17c
GM
45262011-09-25 Glenn Morris <rgm@gnu.org>
4527
4528 * buffer.c (truncate-lines): Doc fix.
4529
94e0933e
CY
45302011-09-24 Chong Yidong <cyd@stupidchicken.com>
4531
4532 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4533 (Fset_window_next_buffers): Doc fix.
4534
cddde921
GM
45352011-09-24 Glenn Morris <rgm@gnu.org>
4536
4537 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4538
1260aef1
PE
45392011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4540
25b4bfa0
PE
4541 Fix minor problems found by static checking.
4542 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4543 * indent.c (Fvertical_motion): Fix == vs = typo.
4544
e3cbd34b
EZ
45452011-09-24 Eli Zaretskii <eliz@gnu.org>
4546
a66cfb1c
SM
4547 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4548 Default value is now t. Doc fix.
6bf7006f 4549
e3cbd34b 4550 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4551 logic when moving up, not only when moving down. Fix the
e3cbd34b 4552 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4553 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4554
4555 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4556 CHARPOS is covered by a display string which includes newlines.
4557 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4558 is covered by a display string with embedded newlines.
4559
a3de0cbd
MA
45602011-09-24 Michael Albinus <michael.albinus@gmx.de>
4561
4562 * dbusbind.c (Fdbus_register_signal): Add match rule to
4563 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4564 (Fdbus_register_method, Vdbus_registered_objects_table):
4565 Fix docstring.
a3de0cbd 4566
b260039d
JM
45672011-09-24 Jim Meyering <meyering@redhat.com>
4568
32c1fffd 4569 do not ignore write error for any output size
b260039d
JM
4570 The previous change was incomplete.
4571 While it makes emacs --batch detect the vast majority of stdout
4572 write failures, errors were still ignored whenever the output size is
4573 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4574 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4575 && echo FAIL: ignored write error
4576 FAIL: ignored write error
4577 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4578 && echo FAIL: ignored write error
4579 FAIL: ignored write error
4580 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4581
8eca8a7c
AS
45822011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4583
4584 * emacs.c (Fkill_emacs): In noninteractive mode exit
4585 non-successfully if a write error occurred on stdout. (Bug#9574)
4586
3341db62
EZ
45872011-09-21 Eli Zaretskii <eliz@gnu.org>
4588
4589 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4590 the xassert test.
4591
4592 * dispextern.h (struct it): Update the comment documenting what
4593 can it->OBJECT be.
4594
8c203dbf
EZ
45952011-09-20 Eli Zaretskii <eliz@gnu.org>
4596
4597 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4598 a display string, extend search for cursor position to end of row.
4599 (find_row_edges): If the row ends in a newline from a display
4600 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4601 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4602 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4603 non-empty line. Fixes confusing cursor motion with arrow keys at
4604 the beginning of a line that starts with whitespace.
8c203dbf 4605
a4824228
LMI
46062011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4607
4608 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4609 (bug#9493).
4610
33ed493b
CY
46112011-09-18 Chong Yidong <cyd@stupidchicken.com>
4612
4613 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4614 boolean (Bug#9154).
4615
56cd55c8
EZ
46162011-09-18 Eli Zaretskii <eliz@gnu.org>
4617
4618 * xdisp.c (display_line): Record maximum and minimum buffer
4619 positions even if no glyphs were produced (e.g., by a zero-width
4620 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4621 buffer positions that will be removed from the glyph row because
4622 they don't fit.
c02dcedf
EZ
4623 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4624 column is beyond frame width: don't subtract 1 "pixel" when
4625 computing width of the stretch.
3e62b7e0
EZ
4626 (reseat_at_next_visible_line_start): Undo the change made on
4627 2011-09-17 that saved paragraph information and restored it after
4628 the call to `reseat'. (Bug#9545)
56cd55c8 4629
5ed99d36 46302011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4631
4632 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4633 and turn window cursor on if cleared (Bug#9415).
4634
5ed99d36 46352011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4636
4637 * search.c (boyer_moore): Take unibyte characters from pattern
4638 literally. (Bug#9458)
4639
9bade7b2
EZ
46402011-09-18 Eli Zaretskii <eliz@gnu.org>
4641
4642 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4643
e5e9d610
PE
46442011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4645
87e4427a
PE
4646 Fix minor problem found by static checking.
4647 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4648 initialized, to pacify gcc -Wuninitialized.
4649
e5e9d610
PE
4650 * fileio.c: Report proper errno when syscall falls.
4651 (Finsert_file_contents): Save and restore errno,
4652 so that report_file_error outputs the correct diagnostic.
4653 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4654
a1674f0b
EZ
46552011-09-18 Eli Zaretskii <eliz@gnu.org>
4656
4657 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4658
fbfb6dd4
EZ
46592011-09-17 Eli Zaretskii <eliz@gnu.org>
4660
4661 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4662 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4663
bb187662
EZ
46642011-09-17 Eli Zaretskii <eliz@gnu.org>
4665
1137e8b8 4666 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4667 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4668
4669 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4670 (bidi_find_paragraph_start): Search back for paragraph beginning
4671 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4672 (bidi_move_to_visually_next): Only trigger paragraph-related
4673 computations when the last character is a newline or at EOB, not
4674 just any NEUTRAL_B. (Bug#9470)
4675
bb187662
EZ
4676 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4677 truncated lines if point is covered by a display string. (Bug#9524)
4678
2e621251
PE
46792011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4680
4681 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4682 (cons_to_x_long): New function.
4683 (lisp_data_to_selection_data): Use it. Correct the test for
4684 short-versus-long data; it was negated. Break out of vector
4685 loop, for efficiency, when a long datum is discovered.
4686
91a15bc6
SM
46872011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4688
4689 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4690
b41c3a35
EZ
46912011-09-16 Eli Zaretskii <eliz@gnu.org>
4692
4693 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4694 GCC PR/17406) by declaring this function with external scope.
4695
7812ba2d
PE
46962011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4697
4698 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4699 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4700
cf7edc2a
AS
47012011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4702
4703 * editfns.c (Fformat): Correctly handle text properties on "%%".
4704
bd01620e
EZ
47052011-09-15 Eli Zaretskii <eliz@gnu.org>
4706
4707 * xterm.c (x_draw_composite_glyph_string_foreground):
4708 * w32term.c (x_draw_composite_glyph_string_foreground):
4709 * term.c (encode_terminal_code):
4710 * composite.c (composition_update_it, get_composition_id):
4711 * xdisp.c (get_next_display_element)
4712 (fill_composite_glyph_string): Add comments about special meaning
4713 of TAB characters in a composition.
4714
a02719a3
PE
47152011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4716
4717 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4718 This occurs when processing a multibyte format.
4719 Problem reported by Wolfgang Jenker.
a02719a3 4720
72589a3c
JB
47212011-09-15 Johan Bockgård <bojohan@gnu.org>
4722
4723 * xdisp.c (try_cursor_movement): Only check for exact match if
4724 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4725
1c14176c
PE
47262011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4727
4728 Remove unused external symbols.
4729 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4730 * xdisp.c (calc_pixel_width_or_height): Now static.
4731 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4732 * indent.c (check_display_width):
4733 * w32term.c: Fix comment to match code.
4734 * xterm.c, xterm.h (x_catching_errors): Remove.
4735
d2eea5b5
PE
47362011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4737
4738 * xselect.c: Use signed conversions more consistently (Bug#9498).
4739 (selection_data_to_lisp_data): Assume incoming selection data are
4740 signed integers, not unsigned. This is to be consistent with
4741 outgoing selection data, which was modified to use signed integers
4742 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4743 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4744 expects long, not unsigned long.
4745
46888499
EZ
47462011-09-14 Eli Zaretskii <eliz@gnu.org>
4747
4748 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4749 computation of loop end. Reported by Johan Bockgård
4750 <bojohan@gnu.org>.
4751
ef8ef9fb
CY
47522011-09-13 Chong Yidong <cyd@stupidchicken.com>
4753
4754 * frame.c (Fother_visible_frames_p): Function deleted.
4755
fa819fed
EZ
47562011-09-12 Eli Zaretskii <eliz@gnu.org>
4757
4758 * indent.c (compute_motion): Process display vector front to back
4759 rather than the other way around. (Bug#2496)
4760
2ba8e008
SM
47612011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4762
4763 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4764
20f53c69
CY
47652011-09-11 Chong Yidong <cyd@stupidchicken.com>
4766
4767 * minibuf.c (Fread_from_minibuffer): Doc fix.
4768
d562d7a4
EZ
47692011-09-11 Eli Zaretskii <eliz@gnu.org>
4770
4771 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4772 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4773
1c4d7f3d
LMI
47742011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4775
4776 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4777 value for non-existent files.
4778
b885bf36
EZ
47792011-09-11 Eli Zaretskii <eliz@gnu.org>
4780
4781 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4782 set its "size" to -1. This will set the modtime_size field of
4783 the corresponding buffer to -1, which is what
4784 verify-visited-file-modtime expects for files that do not exist.
4785 (Bug#9139)
4786
6612f0bf
PE
47872011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4788
4789 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4790 here ...
4791 * lisp.h: ... from here. push_key_description is no longer
4792 defined in keyboard.c, so its declaration should not be in
4793 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4794 logically belongs with push_key_description.
4795
dfb3f755
PE
47962011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4797
4798 * buffer.h: Include <sys/types.h> instead of <time.h>.
4799 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4800 Problem reported by Herbert J. Skuhra.
4801
3134906c
LMI
48022011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4803
4804 * xml.c (parse_region): Make the parsing work for
4805 non-comment-starting XML files again (bug#9144).
4806
8d903f4e
AS
48072011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4808
4809 * image.c (gif_load): Fix calculation of bottom and right corner.
4810 (Bug#9468)
4811
80ad64f4
EZ
48122011-09-10 Eli Zaretskii <eliz@gnu.org>
4813
4814 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4815 redisplay in small windows.
4816
208a048d
EZ
48172011-09-09 Eli Zaretskii <eliz@gnu.org>
4818
4819 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4820
9b1c252e
MR
48212011-09-08 Martin Rudalics <rudalics@gmx.at>
4822
4823 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4824 Operate on live windows only.
4825
2949f33b
JB
48262011-09-08 Juanma Barranquero <lekktu@gmail.com>
4827
4828 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4829
e08dcafd
EZ
48302011-09-07 Eli Zaretskii <eliz@gnu.org>
4831
4832 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4833 only under bidi iteration.
4834
115b96bd
JD
48352011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4836
4837 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4838
c8199d0f
PE
48392011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4840
4841 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4842 Without this fix, the command to link temacs failed due to an
4843 undefined symbol __builtin_isnan. This is because
4844 /usr/include/iso/math_c99.h #defines isnan(x) to
4845 __builtin_isnan(x), but the bundled gcc, which identifies itself
4846 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4847 a __builtin_isnan.
4848 * floatfns.c (isnan): #undef, and then #define to a clone of
4849 what's in data.c.
4850 (Fisnan): Always define, since it's always available now.
4851 (syms_of_floatfns): Always define isnan at the Lisp level.
4852
e39b275c 48532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4854
4855 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4856
b2db44d9 48572011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4858
f4af5137 4859 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4860 The previous code assumed that file offsets (off_t values) fit in
4861 EMACS_INT variables, which is not true on typical 32-bit hosts.
4862 The code messed up by falsely reporting buffer overflow in cases
4863 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4864 when "big" contains more than 2**29 bytes, even though this
4865 inserts just one byte and does not overflow the buffer.
4866 (Finsert_file_contents): Store file offsets as off_t
4867 values, not as EMACS_INT values. Check for overflow when
4868 converting between EMACS_INT and off_t. When checking for
4869 buffer overflow or for overlap, take the offsets into account.
4870 Don't use EMACS_INT for small values where int suffices.
4871 When checking for overlap, fix a typo: ZV was used where
4872 ZV_BYTE was intended.
4873 (Fwrite_region): Don't assume off_t fits into 'long'.
4874 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4875
ecfc0a49
MA
48762011-09-05 Michael Albinus <michael.albinus@gmx.de>
4877
4878 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4879
6511acf2 48802011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4881
0999621a 4882 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4883
4884 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4885 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4886 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4887 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4888 (modify_event_symbol): Do not assume that the length of
4889 name_alist_or_stem is safe to alloca and fits in int.
4890 (Fexecute_extended_command): Likewise for function name and binding.
4891 (Frecursion_depth): Wrap around reliably on integer overflow.
4892 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4893 since some callers pass EMACS_INT values.
4894 (Fsingle_key_description): Don't crash if symbol name contains more
4895 than MAX_ALLOCA bytes.
4896 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4897 (get_minibuffer): Arg is now EMACS_INT, not int.
4898 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4899 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4900 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4901
2be7d702
PE
4902 * dbusbind.c (signature_cat): New function.
4903 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4904 Do not overrun buffer; instead, report string overflow.
4905
9d1df220
PE
4906 * dispnew.c (add_window_display_history): Don't overrun buffer.
4907 Truncate instead; this is OK since it's just a log.
4908
33ef5c64
PE
4909 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4910 even if the time zone offset is outlandishly large.
4911 Don't mishandle offset == INT_MIN.
4912
66c6fdd5
PE
4913 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4914 when creating daemon; the previous buffer-overflow check was incorrect.
4915
d749b01b
PE
4916 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4917 which has the guts of the old verror function.
4918
b5cd1905
PE
4919 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4920 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4921
6e1a67fb
PE
4922 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4923 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4924 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4925 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4926 length of string rather than counting it via multiple sprintfs;
4927 that's simpler and more reliable.
c21721cc
PE
4928 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4929 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4930 sprintf, in case result does not fit in int.
4931
c57b67fc
PE
4932 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4933 (fontset_from_font): Print it.
4934
8a401434
PE
4935 * frame.c (tty_frame_count): Now printmax_t, not int.
4936 (make_terminal_frame, set_term_frame_name): Print it.
4937 (x_report_frame_params): In X, window IDs are unsigned long,
4938 not signed long, so print them as unsigned.
4939 (validate_x_resource_name): Check for implausibly long names,
4940 and don't assume name length fits in 'int'.
4941 (x_get_resource_string): Don't blindly alloca invocation name;
4942 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4943 not fit in int.
4944
6e1a67fb
PE
4945 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4946 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4947 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4948
0df02bf3
PE
4949 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4950 Use esprintf, not sprintf, in case result does not fit in int.
4951
48e30793
PE
4952 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4953 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4954 it as a large positive number.
4955 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4956 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4957
a66ff6d8
PE
4958 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4959 in case result does not fit in int.
4960
aca216ff
PE
4961 * print.c (float_to_string): Detect width overflow more reliably.
4962 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4963 buffer overrun. Don't assume list length fits in 'int'. Treat
4964 print length of 0 as 0, not as infinity; to be consistent with other
4965 uses of print length in this function. Don't overflow print length
4966 index. Don't assume hash table size fits in 'long', or that
4967 vectorlike size fits in 'unsigned long'.
4968
31c286f7
PE
4969 * process.c (make_process): Use printmax_t, not int, to format
4970 process-name gensyms.
4971
55e5faa1
PE
4972 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4973
80f2e268
PE
4974 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4975 to avoid potential buffer overrun.
4976
670741ab
PE
4977 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4978 if X resource line is longer than 512 bytes.
4979
b7163a50
PE
4980 * xfns.c (x_window): Make sprintf buffer a bit bigger
4981 to avoid potential buffer overrun.
4982
ae58ff1f
PE
4983 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4984
c43c8a6a
PE
4985 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4986
3f8236f4
PE
49872011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4988
53e9fe90 4989 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4990 Without these, Emacs silently mishandles large integers sometimes.
4991 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4992 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4993
6511acf2
PE
4994 * xdisp.c (try_window_id): Check Emacs fixnum range before
4995 converting to 'int'.
806add1d 4996
6511acf2 4997 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4998 Check that an Emacs fixnum is in range before assigning it to 'int'.
4999 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5000 values converted from Emacs fixnums.
5001 (Frecenter): Don't wrap around a line count if it is out of 'int'
5002 range; instead, treat it as an extreme value.
5003 (Fset_window_configuration, compare_window_configurations):
5004 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5005
6511acf2
PE
5006 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5007 that can exceed INT_MAX. Check that EMACS_INT value is in range
5008 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5009 (match_limit): Don't assume that a fixnum can fit in 'int'.
5010
6511acf2 5011 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5012 exceed INT_MAX.
5013
6511acf2 5014 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5015 (Fvertical_motion): Don't wrap around LINES values that don't fit
5016 in 'int'. Instead, treat them as extreme values. This is good
5017 enough for windows, which can't have more than INT_MAX lines anyway.
5018
fcb901a7
LMI
50192011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5020
0f2f6b6d
LMI
5021 * Require libxml/parser.h to avoid compilation warning.
5022
fcb901a7
LMI
5023 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5024
5025 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5026 since this reportedly can destroy thread storage.
5027
6e20a0d4
CY
50282011-08-30 Chong Yidong <cyd@stupidchicken.com>
5029
5030 * syntax.c (find_defun_start): Update all cache variables if
5031 exiting early (Bug#9401).
5032
148ae00e
EZ
50332011-08-30 Eli Zaretskii <eliz@gnu.org>
5034
f6cfbd8f
EZ
5035 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5036
148ae00e
EZ
5037 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5038 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5039 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5040
5041 * term.c (tty_append_glyph): New function.
5042 (produce_stretch_glyph): Static function and its prototype deleted.
5043
a66cfb1c
SM
5044 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5045 Add prototypes.
148ae00e 5046
c4a07a4c
PE
50472011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5048
5049 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5050 when checking :margin (Bug#9390).
5051 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5052 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5053 so that the name doesn't mislead. All uses changed.
5054
6bc8cd65
JB
50552011-08-28 Johan Bockgård <bojohan@gnu.org>
5056
5057 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5058 set_tty_hooks.
5059
dca4927e
EZ
50602011-08-27 Eli Zaretskii <eliz@gnu.org>
5061
5062 * xdisp.c (move_it_to): Don't bail out early when reaching
5063 position beyond to_charpos, if we are scanning backwards.
5064 (move_it_vertically_backward): When DY == 0, make sure we get to
5065 the first character in the line after the newline.
5066
f2cad773
PE
50672011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5068
5069 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5070 (ccl_driver): Do not generate an out-of-range pointer.
5071 (Fccl_execute_on_string): Remove unnecessary check for
5072 integer overflow, noted by Stefan Monnier in
5073 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5074 Remove a FIXME that didn't need fixing.
5075 Simplify the newly-introduced buffer reallocation code.
5076
0cae2cdb
JB
50772011-08-27 Juanma Barranquero <lekktu@gmail.com>
5078
5079 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5080
5fc295a4 50812011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5082
70c60eb2 5083 Integer and memory overflow issues (Bug#9196).
726e0ab1 5084
d31850da
PE
5085 * doc.c (get_doc_string): Rework so that
5086 get_doc_string_buffer_size is the actual buffer size, rather than
5087 being 1 less than the actual buffer size; this makes xpalloc more
5088 convenient.
5089
a69fbedb
PE
5090 * image.c (x_allocate_bitmap_record, cache_image):
5091 * xselect.c (Fx_register_dnd_atom):
5092 Simplify previous changes by using xpalloc.
5093
fe5c5d37
PE
5094 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5095 since either will do and ptrdiff_t is convenient with xpalloc.
5096
0065d054
PE
5097 * charset.c (charset_table_size)
5098 (struct charset_sort_data.priority): Now ptrdiff_t.
5099 (charset_compare): Don't overflow if priorities differ greatly.
5100 (Fsort_charsets): Don't assume list length fits in int.
5101 Check for size-calculation overflow when allocating sort data.
5102 (syms_of_charset): Allocate an initial charset table that is
5103 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5104
5105 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5106
5107 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5108 The actual value is always <= INT_MAX, and leaving it unsigned made
5109 overflow checking harder.
5110
5111 * dispextern.h (struct glyph_matrix.rows_allocated)
5112 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5113 with xpalloc. The values are still always <= INT_MAX.
5114
5115 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5116
5117 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5118 (SAFE_NALLOCA): New macro.
5119
5120 * region-cache.c (struct boundary.pos, find_cache_boundary)
5121 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5122 (set_cache_region, invalidate_region_cache)
5123 (revalidate_region_cache, know_region_cache, region_cache_forward)
5124 (region_cache_backward, pp_cache):
5125 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5126 so that ptrdiff_t * can be passed to xpalloc.
5127 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5128 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5129 (pp_cache): Don't assume cache_len fits in int.
5130 * region-cache.h: Adjust extern decls to match.
5131
5132 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5133 EMACS_INT, since either will do, for xpalloc.
5134
5135 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5136 (xnmalloc, xnrealloc, xpalloc): New functions.
5137
726e0ab1
PE
5138 * bidi.c (bidi_shelve_header_size): New constant.
5139 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5140 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5141
51f30bc5 5142 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5143 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5144 (overlay_strings):
5145 Don't update size of array until after memory allocation succeeds,
5146 because xmalloc/xrealloc may not return.
0065d054
PE
5147 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5148 now that we have proper integer overflow checking.
5149 (record_overlay_string, overlay_strings): Catch overflows when
5150 calculating size of overlay_str_buf.
726e0ab1 5151
0065d054
PE
5152 * callproc.c (Fcall_process): Check for size overflow when
5153 calculating size of args2.
5154 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5155 Normally we prefer signed values, but sticking with ptrdiff_t would
5156 require adding more-complicated checks.
726e0ab1
PE
5157
5158 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5159 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5160 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5161 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5162
5163 * character.c (Fstring): Check for size-calculation overflow.
5164
5165 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5166 unnecessary integer overflow. Check for size overflow.
5167 (encode_coding_object): Don't update size until xmalloc succeeds.
5168
5169 * composite.c (get_composition_id): Check for overflow in glyph
5170 length calculations.
5171
5172 Integer and memory overflow fixes for display code.
5173 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5174 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5175 (scrolling_window): Check for overflow in size calculations.
5176 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5177 Don't assume glyph table len fits in int.
5178 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5179 (row_table_size): Now ptrdiff_t, not int.
5180 (scrolling_window): Avoid overflow in size calculations.
5181 Don't update size until allocation succeeds.
5182 * fns.c (concat): Check for overflow in size calculations.
5183 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5184 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5185 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5186
5187 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5188 (get_doc_string): Check for size calculation overflow.
5189 Don't update size until allocation succeeds.
5190 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5191 EMACS_INT, where ptrdiff_t will do.
5192 (Fsubstitute_command_keys): Check for string overflow.
5193
5194 * editfns.c (set_time_zone_rule): Don't assume environment length
5195 fits in int.
5196 (message_length): Now ptrdiff_t, not int.
5197 (Fmessage_box): Don't update size until allocation succeeds.
5198 Don't assume message length fits in int.
5199 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5200
0065d054
PE
5201 * emacs.c (main): Do not reallocate argv, since there is a null at
5202 the end that can be overwritten, and this way there's no need to
5203 worry about size-calculation overflow.
5204 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5205
5206 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5207 alloc succeeds.
5208 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5209
5210 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5211 (x_set_scroll_bar_width, x_figure_window_size):
5212 Check for integer overflow.
5213 (x_set_alpha): Do not assume XINT fits in int.
5214
5215 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5216 This is for the members text_lines, text_cols, total_lines, total_cols,
5217 where the system imposes an 'int' limit.
5218
5219 * fringe.c (Fdefine_fringe_bitmap):
5220 Don't update size until alloc works.
5221
5222 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5223 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5224
5225 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5226 Check for size-calculation overflow.
5227 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5228 do, as we prefer signed integers.
5229 (id_to_widget.max_size, id_to_widget.used)
5230 (xg_store_widget_in_map, xg_remove_widget_from_map)
5231 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5232 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5233 Use and return ptrdiff_t, not int.
5234 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5235 * gtkutil.h: Change prototypes to match the above.
5236
5237 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5238 are duplicate now that they've been promoted to lisp.h.
5239 (x_allocate_bitmap_record, x_alloc_image_color)
5240 (make_image_cache, cache_image, xpm_load):
5241 Don't update size until alloc is done.
5242 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5243 (x_detect_edges):
3256efce 5244 Check for size calculation overflow.
726e0ab1
PE
5245 (ct_colors_allocated_max): New constant.
5246 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5247 overflow.
3256efce 5248
726e0ab1
PE
5249 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5250 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5251 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5252 Use ptrdiff_t, not int, to count maps.
5253 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5254 calculations. Don't update size until allocation succeeds.
5255 Redo calculations to avoid overflow.
726e0ab1
PE
5256 * keyboard.h: Change prototypes to match the above.
5257
5258 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5259 to count maps.
5260 (current_minor_maps): Check for size calculation overflow.
5261 * keymap.h: Change prototypes to match the above.
5262
5263 * lread.c (read1, init_obarray): Don't update size until alloc done.
5264
5265 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5266 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5267
726e0ab1
PE
5268 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5269 Now ptrdiff_t, not int.
5270 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5271 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5272
5273 * process.c (Fnetwork_interface_list): Check for overflow
5274 in size calculation.
5275
5276 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5277
5278 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5279 overflow. Don't bother calling xmalloc when xrealloc will do.
5280
5281 * search.c (Freplace_match): Check for size calculation overflow.
5282 (Fset_match_data): Don't assume list lengths fit in 'int'.
5283
5284 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5285 for command line length. Do not attempt to address one before the
5286 beginning of an array, as that's not portable.
5287
5288 * term.c (max_frame_lines): Remove; unused.
5289 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5290 not int.
5291 (encode_terminal_code, calculate_costs): Check for size
5292 calculation overflow.
5293 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5294 table lengths and related sizes. Don't update size until alloc
5295 done. Redo calculations to avoid overflow.
5296 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5297
5298 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5299 subtracting pointers.
5300 (gobble_line): Check for overflow more carefully. Don't update size
5301 until alloc done.
5302
5303 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5304 Don't update size until alloc done.
5305 Redo size calculations to avoid overflow.
5306 Check for size calculation overflow.
0065d054 5307 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5308
5309 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5310 Use ptrdiff_t, not int, for sizes.
5311 (store_mode_line_noprop_char): Don't update size until alloc done.
5312
0065d054
PE
5313 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5314 Use ptrdiff_t, not int, for sizes.
5315 (Finternal_make_lisp_face, cache_face):
5316 Check for size calculation overflow.
5317 (cache_face): Treat size calculation overflows as if they were
5318 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5319
5320 * xfns.c (x_encode_text, x_set_name_internal)
5321 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5322 sizes, since they can exceed INT_MAX in size. Check for size
5323 calculation overflow.
5324
0065d054
PE
5325 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5326 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5327 Don't update size until alloc done.
5328
0065d054 5329 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5330 as sprintf is limited to int lengths.
1d526e2f 5331
252c5ee1
PE
5332 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5333 (X_LONG_MIN): New macros.
864d7ce7
PE
5334 Use them to make the following changes clearer.
5335 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5336 This change doesn't affect the value now, but it may help remind
5337 future maintainers not to raise the value too much later.
5338 (SELECTION_QUANTUM): Remove, replacing with ...
5339 (selection_quantum): ... new function, which avoids overflow.
5340 All uses changed.
5341 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5342 assumption that selection length fits in 'int'.
5343 (x_reply_selection_request, x_handle_selection_request)
5344 (x_get_window_property, receive_incremental_selection)
5345 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5346 (lisp_data_to_selection_data, clean_local_selection_data):
5347 Use ptrdiff_t, not int, to record length of selection.
5348 (x_reply_selection_request, x_get_window_property)
5349 (receive_incremental_selection, x_property_data_to_lisp):
5350 Redo calculations to avoid overflow.
5351 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5352 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5353 something.
5354 (x_get_window_property, receive_incremental_selection)
5355 (lisp_data_to_selection_data, x_property_data_to_lisp):
5356 Check for size-calculation overflow.
5357 (x_get_window_property, receive_incremental_selection)
5358 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5359 Don't store size until memory allocation succeeds.
5360 (x_get_window_property): Plug memory leak on memory exhaustion.
5361 Don't double-block input; malloc is safe here. Don't assume 2**34
5362 - 4 fits in unsigned long. Add an xassert to check
5363 XGetWindowProperty overflow. Be more careful about overflow
5364 calculations, and distinguish size from memory overflow better.
5365 (receive_incremental_selection): When tracing, don't assume
5366 unsigned int is less than INT_MAX.
5367 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5368 harmful) conversions of unsigned short to int.
5369 (lisp_data_to_selection_data): Don't assume that integers
5370 in the range -65535 through -1 fit in an X unsigned short.
5371 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5372 result parameters unless successful. Rely on cons_to_unsigned
5373 to report problems with elements; the old code wasn't right anyway.
5374 (x_check_property_data): Check for int overflow; we cannot use
5375 a wider type due to X limits.
5376 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5377
726e0ab1 5378 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5379
0065d054
PE
5380 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5381 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5382 (x_color_cells): Don't store size until memory allocation succeeds.
5383 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5384 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5385 (x_term_init): Don't assume length fits in int (sprintf is limited
5386 to int size).
bc18e09d 5387
ebfa62c0
PE
5388 Use ptrdiff_t for composition IDs.
5389 * character.c (lisp_string_width):
5390 * composite.c (composition_table_size, n_compositions)
5391 (get_composition_id, composition_gstring_from_id):
5392 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5393 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5394 * window.c (Frecenter):
5395 Use ptrdiff_t, not int, for composition IDs.
5396 * composite.c (get_composition_id): Check for integer overflow.
5397 * composite.h: Adjust prototypes to match the above changes.
5398
d3411f89
PE
5399 Use ptrdiff_t for hash table indexes.
5400 * category.c (hash_get_category_set):
5401 * ccl.c (ccl_driver):
5402 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5403 * coding.c (coding_system_charset_list, detect_coding_system):
5404 * coding.h (struct coding_system.id):
5405 * composite.c (get_composition_id, gstring_lookup_cache):
5406 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5407 * image.c (xpm_get_color_table_h):
5408 * lisp.h (hash_lookup, hash_put):
5409 * minibuf.c (Ftest_completion):
5410 Use ptrdiff_t for hash table indexes, not int (which is too
5411 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5412 32-bit --with-wide-int hosts).
5413
e097a6fa
PE
5414 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5415 Add a FIXME comment about memory leaks.
5416 (syms_of_charset): Don't assume xmalloc returns.
5417
5637687f
PE
5418 Don't assume that stated character widths fit in int.
5419 * character.c (Fchar_width, c_string_width, lisp_string_width):
5420 * character.h (CHAR_WIDTH):
5421 * indent.c (MULTIBYTE_BYTES_WIDTH):
5422 Use sanitize_char_width to avoid undefined and/or bad behavior
5423 with outlandish widths.
a66cfb1c 5424 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5425 now that we have two such functions. All uses changed.
5426 (sanitize_char_width): New inline function.
5427
a2271ba2
PE
5428 Don't assume that tab-width fits in int.
5429 * character.h (sanitize_width): New inline function.
5430 (SANE_TAB_WIDTH): New macro.
5431 (ASCII_CHAR_WIDTH): Use it.
5432 * indent.c (sane_tab_width): Remove. All uses replaced by
5433 SANE_TAB_WIDTH (current_buffer).
5434 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5435
18c52557
PE
5436 * fileio.c: Integer overflow issues with file modes.
5437 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5438
caeeedc1
PE
5439 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5440 Remove unreachable code.
5441 (read_hex, load_charset_map_from_file): Check for integer overflow.
5442
6df6ae42 5443 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5444 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5445 (x_send_scroll_bar_event): Likewise. Check that the size does not
5446 exceed limits imposed by XClientMessageEvent, as well as the usual
5447 ptrdiff_t and size_t limits.
5448
b13995db
PE
5449 * keyboard.c: Overflow, signedness and related fixes.
5450 (make_lispy_movement): Use same integer type in forward decl
5451 that is used in the definition.
5452 (read_key_sequence, keyremap_step):
5453 Change bufsize argument back to int, undoing my 2011-03-30 change.
5454 We prefer signed types, and int is wide enough here.
5455 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5456 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5457 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5458 length, not size_t. Use ptrdiff_t for index, not int.
5459 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5460 possibility of integer overflow.
5461
13464394
PE
5462 Overflow, signedness and related fixes for images.
5463
5464 * dispextern.h (struct it.stack[0].u.image.image_id)
5465 (struct_it.image_id, struct image.id, struct image_cache.size)
5466 (struct image_cache.used, struct image_cache.ref_count):
5467 * gtkutil.c (update_frame_tool_bar):
5468 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5469 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5470 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5471 * nsmenu.m (update_frame_tool_bar):
5472 * xdisp.c (calc_pixel_width_or_height):
5473 * xfns.c (image_cache_refcount):
5474 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5475 on typical 64-bit hosts.
5476
5477 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5478 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5479 Omit unnecessary casts to int.
5480 (parse_image_spec): Check that integers fall into 'int' range
5481 when the callers expect that.
5482 (image_ascent): Redo ascent calculation to avoid int overflow.
5483 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5484 (lookup_image): Remove unnecessary tests.
5485 (xbm_image_p): Locals are now of int, not EMACS_INT,
5486 since parse_image_check makes sure they fit into int.
5487 (png_load, gif_load, svg_load_image):
5488 Prefer int to unsigned where either will do.
5489 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5490 old tiff_error_handler and tiff_warning_handler.
5491 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5492 stack buffer overflows. It uses only the features of vsnprintf
5493 that are common to both POSIX and native Microsoft.
5494 (tiff_error_handler, tiff_warning_handler): Use it.
5495 (tiff_load, gif_load, imagemagick_load_image):
5496 Don't assume :index value fits in 'int'.
5497 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5498 (imagemagick_load_image): Check that crop parameters fit into
5499 the integer types that MagickCropImage accepts. Don't assume
5500 Vimagemagick_render_type has a nonnegative value. Don't assume
5501 size_t fits in 'long'.
5502 (gs_load): Use printmax_t to print the widest integers possible.
5503 Check for integer overflow when computing image height and width.
5504
c11821d4
EZ
55052011-08-26 Eli Zaretskii <eliz@gnu.org>
5506
5507 * xdisp.c (redisplay_window): Don't force window start if point
5508 will be invisible in the resulting window. (Bug#9324)
5509
0c95fcf7
EZ
55102011-08-25 Eli Zaretskii <eliz@gnu.org>
5511
5512 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5513 the display spec is of the form `(space ...)'.
5514 (handle_display_spec): Return the value returned by
5515 handle_single_display_spec, not just 1 or zero.
5516 (handle_single_display_spec): If the display spec is of the form
5517 `(space ...)', and specifies display in the text area, return 2
5518 rather than 1.
fee65a97 5519 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5520 accurately, and prefer exact match for point under bidi.
5521 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5522
5523 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5524 into disp_prop; all users changed.
5525
5526 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5527 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5528 for the text covered by the display property.
5529
e4ed06f1
CY
55302011-08-25 Chong Yidong <cyd@stupidchicken.com>
5531
5532 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5533 Change return value to nil.
5534 (Frecord_buffer): Delete unused function.
5535
f67cdd7f
EZ
55362011-08-24 Eli Zaretskii <eliz@gnu.org>
5537
5980d4c6
EZ
5538 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5539 buffers, return left-to-right.
8610fe8b
EZ
5540 (set_cursor_from_row): Consider candidate row a win if its glyph
5541 represents a newline and point is on that newline. Fixes cursor
5542 positioning on the newline at EOL of R2L text within L2R
5543 paragraph, and vice versa.
5544 (try_cursor_movement): Check continued rows, in addition to
5545 continuation rows. Fixes unwarranted scroll when point enters a
5546 continued line of R2L text within an L2R paragraph, or vice versa.
5547 (cursor_row_p): Consider the case of point being equal to
5548 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5549 from the end of a short line to the beginning of a continued line
5550 of R2L text within L2R paragraph.
5551 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5552 composed characters.
5980d4c6 5553
f67cdd7f
EZ
5554 * bidi.c (bidi_check_type): Use xassert.
5555 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5556 members.
5557
bca633fb
EZ
55582011-08-23 Eli Zaretskii <eliz@gnu.org>
5559
5560 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5561 a character.
5562
4a5885a7
CY
55632011-08-23 Chong Yidong <cyd@stupidchicken.com>
5564
5565 * nsfont.m (ns_otf_to_script): Fix typo.
5566
0902a04e
KH
55672011-08-22 Kenichi Handa <handa@m17n.org>
5568
5569 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5570 extra slot even if the purpose is char-code-property-table.
5571
1a2e6670
EZ
55722011-08-23 Eli Zaretskii <eliz@gnu.org>
5573
8ddde651
EZ
5574 * xdisp.c (redisplay_window): When computing centering_position,
5575 account for the height of the header line. (Bug#8874)
5576
425cc014
EZ
5577 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5578 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5579 candidate is selected by the mouse, and that candidate has a
5580 composed character under the mouse.
5581
1a2e6670
EZ
5582 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5583 coordinates reported by pos-visible-in-window-p for a composed
5584 character in column zero.
5585
8b76d6f8
SM
55862011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5587
5588 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5589
dac347dd
EZ
55902011-08-22 Eli Zaretskii <eliz@gnu.org>
5591
5592 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5593 consider it a hit if to_charpos is anywhere in the range of the
5594 composed buffer positions.
5595
e013fb34
CY
55962011-08-22 Chong Yidong <cyd@stupidchicken.com>
5597
5598 * image.c (gif_load): Don't assume that each subimage has the same
5599 dimensions as the base image. Handle disposal method that is
5600 "undefined" by the gif spec (Bug#9335).
5601
bd1ba3e8
CY
56022011-08-20 Chong Yidong <cyd@stupidchicken.com>
5603
5604 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5605 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5606
54a1215b
EZ
56072011-08-19 Eli Zaretskii <eliz@gnu.org>
5608
823564e5
EZ
5609 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5610 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5611 from an Org mode buffer to a Speedbar frame.
5612
54a1215b
EZ
5613 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5614 a composition, take its buffer position from IT->cmp_it.charpos.
5615 Fixes cursor positioning at the beginning of a line that begins
5616 with a composed character.
5617
9778ebcc
EZ
56182011-08-18 Eli Zaretskii <eliz@gnu.org>
5619
0be6ee06
EZ
5620 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5621 character bidirectional type, use STRONG_L instead. Fixes crashes
5622 in a buffer produced by `describe-categories'.
5623
9778ebcc
EZ
5624 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5625 members before the level stack, so they would be saved and
5626 restored when copying iterator state. Fixes incorrect reordering
5627 around TABs covered by display properties.
5628
156bffbe
AS
56292011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5630
6b02f655 5631 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5632
72ad093b
CY
56332011-08-17 Chong Yidong <cyd@stupidchicken.com>
5634
5635 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5636 (internal_condition_case_2, internal_condition_case_n):
5637 Remove unnecessary aborts (Bug#9081).
72ad093b 5638
35774242
EZ
56392011-08-17 Eli Zaretskii <eliz@gnu.org>
5640
5641 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5642 has no `load' handler, try opening the file locally. (Bug#9311)
5643
db76dd85
KB
56442011-08-16 Ken Brown <kbrown@cornell.edu>
5645
5646 * gmalloc.c: Expand comment.
5647
b215eee5
EZ
56482011-08-16 Eli Zaretskii <eliz@gnu.org>
5649
5650 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5651 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5652
a4579d33
KB
56532011-08-16 Ken Brown <kbrown@cornell.edu>
5654
5655 Fix memory allocation problems in Cygwin build (Bug#9273).
5656
5657 * unexcw.c ( __malloc_initialized): Declare external variable.
5658 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5659
8b76d6f8
SM
5660 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5661 New variables.
a4579d33
KB
5662 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5663 dumped emacs.
5664 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5665 in the static heap.
5666 [CYGWIN] (special_realloc): New function.
5667 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5668 requests to realloc storage in the static heap.
5669
3ebec551
PE
56702011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5671
5672 * bidi.c (bidi_initialize): Remove unused local.
5673
9fd8be00
EZ
56742011-08-15 Eli Zaretskii <eliz@gnu.org>
5675
6b02f655
SM
5676 * bidimirror.h:
5677 * biditype.h: Remove file.
5678 * makefile.w32-in ($(BLD)/bidi.$(O)):
5679 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5680
5681 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5682
5683 * chartab.c: Improve commentary for the uniprop_table API.
5684
32413314
EZ
5685 * bidi.c (bidi_paragraph_init): Support zero value of
5686 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5687 (bidi_initialize): Use uniprop_table instead of including
5688 biditype.h and bidimirror.h.
32413314 5689
9fd8be00
EZ
5690 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5691 coordinates of the iterator when restoring from ppos_it.
5692 (Bug#9296)
5693
5cf2b69b
KH
56942011-08-14 Kenichi Handa <handa@m17n.org>
5695
5696 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5697 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5698
daf17d00
EZ
56992011-08-14 Eli Zaretskii <eliz@gnu.org>
5700
5701 * xdisp.c (move_it_in_display_line_to): Don't invoke
5702 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5703 ppos_it. Fixes vertical cursor motion when line beginning is
5704 covered by an image. (Bug#9296)
5705
08e3161a
JD
57062011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5707
5708 * nsterm.h (ns_run_ascript): Declare.
5709 (NSAPP_DATA2_RUNASSCRIPT): Define.
5710
5711 * nsfns.m (as_script, as_result, as_status): New static variables.
5712 (ns_run_ascript): New function.
5e617bc2 5713 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5714 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5715 the event loop. Get status from as_status (Bug#7276).
5716
5717 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5718 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5719 the event loop (Bug#7276).
5720
a3720aa2
AS
57212011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5722
5723 * gnutls.c (QCgnutls_bootprop_priority)
5724 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5725 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5726 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5727 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5728 (QCgnutls_bootprop_verify_hostname_error)
5729 (QCgnutls_bootprop_callbacks_verify): Rename from
5730 Qgnutls_bootprop_..., all uses changed.
5731
5732 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5733 uses changed.
5734
0a0d27fb
PE
57352011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5736
19d5c50c
PE
5737 * xfaces.c (Qframe_set_background_mode): Now static.
5738 * dispextern.h (Qframe_set_background_mode): Remove decl.
5739
0a0d27fb
PE
5740 * process.c (Fnetwork_interface_info): Declare local only if needed.
5741
377538cb
JD
57422011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5743
5744 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5745 (Fnetwork_interface_list): Allocate in increments of bytes instead
5746 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5747 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5748 sockaddr.
5749 (struct ifflag_def): notrailers is smart on OSX.
5750 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5751 Get hardware address with getifaddrs if available.
5752
08fff70c
EZ
57532011-08-12 Eli Zaretskii <eliz@gnu.org>
5754
5755 * xdisp.c (iterate_out_of_display_property): xassert that
5756 IT->position is set to within IT->object's boundaries. Break from
5757 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5758 when IT->position is set up wrongly due to some bug.
5759 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5760 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5761 entry. Force push_it to save on the stack the current
5762 buffer/string position, to be restored by pop_it. Fix flags in
5763 the iterator structure wrt the object coming from a display
5764 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5765 properties. (Bug#9284)
5766
7be1c708 57672011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5768
7be1c708
CY
5769 * fontset.c (fontset_get_font_group): Add proper type checks.
5770 (Bug#9172)
aac0c6e3 5771
7be1c708 57722011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5773
7be1c708
CY
5774 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5775 and LC_VERSION_MIN_MACOSX.
5776 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5777 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5778
97bb72a6
EZ
57792011-08-08 Eli Zaretskii <eliz@gnu.org>
5780
5781 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5782 no-display-properties-and-no-overlays under bidi display.
5783 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5784 properties and overlays.
97bb72a6 5785
d5617611
CY
57862011-08-08 Chong Yidong <cyd@stupidchicken.com>
5787
37e11a63
CY
5788 * editfns.c (Fset_time_zone_rule): Document relationship with the
5789 setenv function.
5790
d5617611
CY
5791 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5792 the font entity extracted from the cache (Bug#8109).
5793
58872834
CY
57942011-08-07 Chong Yidong <cyd@stupidchicken.com>
5795
5796 * composite.c (autocmp_chars): Don't reset point. That is done by
5797 restore_point_unwind (Bug#5984).
5798
75bfc667
JL
57992011-08-07 Juri Linkov <juri@jurta.org>
5800
5801 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5802 to show the arg `TIME' instead of `TIMEVAL'.
5803
d1410150
EZ
58042011-08-06 Eli Zaretskii <eliz@gnu.org>
5805
5806 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5807 display property strides EOL and includes a newline, as in
5808 longlines-mode. (Bug#9254)
75b771e4
EZ
5809 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5810 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5811
5812 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5813 is non-zero, even if the data buffer is NULL. Fixes a crash in
5814 vertical-motion with longlines-mode. (Bug#9254)
5815
35928349
EZ
58162011-08-05 Eli Zaretskii <eliz@gnu.org>
5817
ec7cc85b
EZ
5818 * bidi.c <bidi_cache_total_alloc>: Now static.
5819 (bidi_initialize): Initialize bidi_cache_total_alloc.
5820
8b76d6f8 5821 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5822 cache. (Bug#9221)
5823
5824 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5825 amount allocated this far in `bidi_cache_total_alloc'.
5826 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5827 non-zero, only free the data buffer without restoring the cache
5828 contents. All callers changed.
5829
5830 * dispextern.h (bidi_unshelve_cache): Update prototype.
5831
5832 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5833 (move_it_in_display_line, move_it_to)
5834 (move_it_vertically_backward, move_it_by_lines): Replace the call
5835 to xfree to an equivalent call to bidi_unshelve_cache.
5836 (move_it_in_display_line_to): Fix logic of returning
412b6358 5837 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5838
e2e2423b
EZ
58392011-08-05 Eli Zaretskii <eliz@gnu.org>
5840
5841 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5842 came from a string character with a `cursor' property. (Bug#9229)
5843
ae9e757a
JD
58442011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5845
5846 * Makefile.in (LIB_PTHREAD): New variable.
5847 (LIBES): Add LIB_PTHREAD (Bug#9216).
5848
5849 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5850 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5851
213bd7f2
AS
58522011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5853
6b02f655 5854 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5855
99aaf75f
JD
58562011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5857
5858 * xterm.c (x_find_topmost_parent): New function.
5859 (x_set_frame_alpha): Find topmost parent window with
5860 x_find_topmost_parent and set the property there also (bug#9181).
5861 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5862
c74e9d86
PE
58632011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5864
5865 * callproc.c (Fcall_process): Avoid vfork clobbering
5866 the local vars buffer, coding_systems, current_dir.
5867
640c8776
SM
58682011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5869
5870 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5871
f26d0e4c
PE
58722011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5873
8a10d76c
PE
5874 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5875 so that it is not optimized away.
5876
f26d0e4c
PE
5877 * xdisp.c (compute_display_string_pos): Remove unused local.
5878
55439c61
EZ
58792011-08-02 Eli Zaretskii <eliz@gnu.org>
5880
5881 Fix slow cursor motion and scrolling in large buffers with
5882 selective display, like Org Mode buffers. (Bug#9218)
5883
5884 * dispextern.h (struct bidi_it): New member disp_prop_p.
5885
5886 * xdisp.c: Remove one-slot cache of display string positions.
5887 (compute_display_string_pos): Accept an additional argument
5e617bc2 5888 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5889 for a display string or property. If found, set DISP_PROP_P
5890 non-zero.
5891
5892 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5893 DISP_PROP_P, and pass it to compute_display_string_pos.
5894 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5895 non-zero. All callers of bidi_fetch_char changed.
5896
fb33fa43
SM
58972011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5898
5899 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5900
b099e063
DM
59012010-12-03 Don March <don@ohspite.net>
5902
5903 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5904 last character M-[char] is translated to ESC [char] (bug#7541).
5905
5cc7f7af
KH
59062011-08-02 Kenichi Handa <handa@m17n.org>
5907
d0fffa3f 5908 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5909
5910 * chartab.c (uniprop_table): Make it non-static.
5911
525d5e6e
EZ
59122011-08-01 Eli Zaretskii <eliz@gnu.org>
5913
5914 * xdisp.c (forward_to_next_line_start): Accept additional argument
5915 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5916 on the newline.
5917 (reseat_at_next_visible_line_start): Use the bidi iterator state
5918 returned by forward_to_next_line_start to restore the state of
5919 it->bidi_it after backing up to previous newline. (Bug#9212)
5920
31011111
AS
59212011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5922
5923 * regex.c (re_comp): Protoize.
5924 (re_exec): Fix return type.
5925 (regexec): Fix type of `ret'. (Bug#9203)
5926
476371c4
PE
59272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5928
e5d76069
PE
5929 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5930 This is needed if max-image-size is a floating-point number.
5931
9a79b20c
AS
59322011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5933
5934 * print.c (print_object): Print empty symbol as ##.
5935
5936 * lread.c (read1): Read ## as empty symbol.
5937
d8c2fa78
AA
59382011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5939
5940 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5941 setting frame foreground color (Bug#9175).
5942 (x_set_background_color): Likewise.
5943
ffe57a7a
AA
5944 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5945 contents (Bug#9176).
5946 (EmacsTooltip -init): Remove bezels and add shadows to
5947 tooltip windows.
5948
bf3492a5
AA
5949 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5950 or scroll bar (Bug#8470).
5951
d55e9c53
AA
5952 * nsfont.m (nsfont_open): Remove assignment to voffset and
5953 unnecessary vars hshink, expand, hd, full_height, min_height.
5954 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5955
5956 * nsterm.h (nsfont_info): Remove voffset field.
5957
d8c2fa78 59582011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5959
5960 Implement strike-through and overline on NextStep (Bug#8863).
5961
5962 * nsfont.m (nsfont_open): Use underline position provided by font,
5963 instead of hard-coded value of 2.
5964 (nsfont_draw): Call ns_draw_text_decoration instead.
5965
5966 * nsterm.h: Add declaration for ns_draw_text_decoration.
5967
5968 * nsterm.m (ns_draw_text_decoration): New function for drawing
5969 underline, overline, and strike-through.
5970 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5971 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5972 accommodate underlining, etc.
4843aac3 5973
4cc60b9b
EZ
59742011-07-28 Eli Zaretskii <eliz@gnu.org>
5975
bc7ece87
EZ
5976 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5977 default.
4cc60b9b 5978
476371c4
PE
59792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5980
66606eea
PE
5981 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5982 Without this fix, if a signal arrives just after memory fills up,
5983 'malloc' might be invoked reentrantly.
5984
476371c4
PE
5985 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5986 In other words, assume that every image size is allowed, on non-X
5987 hosts. This assumption is probably wrong, but it lets Emacs compile.
5988
f3fcc40d
AS
59892011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5990
5991 * regex.c (re_iswctype): Convert return values to boolean.
5992
350c992f
EZ
59932011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5994
5995 * xdisp.c (compute_display_string_pos): Don't use cached display
5996 string position if the buffer had its restriction changed.
5997 (Bug#9184)
5998
5266b4bb
PE
59992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6000
6001 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6002
2573a837 60032011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6004
41f55ccd 6005 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6006
39e378da
PE
6007 * bidi.c: Integer size and overflow fixes.
6008 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6009 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6010 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6011 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6012 (bidi_find_other_level_edge):
6013 Use ptrdiff_t instead of EMACS_INT where either will do.
6014 This works better on 32-bit hosts configured --with-wide-int.
6015 (bidi_cache_ensure_space): Check for size-calculation overflow.
6016 Use % rather than repeated addition, for better worst-case speed.
6017 Don't set bidi_cache_size until after xrealloc returns, because it
6018 might not return.
6019 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6020 (bidi_cache_ensure_space): Also check that the bidi cache size
6021 does not exceed that of the largest Lisp string or buffer. See Eli
6022 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6023
5e927815
PE
6024 * alloc.c (__malloc_size_t): Remove.
6025 All uses replaced by size_t. See Andreas Schwab's note
6026 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6027
ca4aa935
PE
6028 * image.c: Improve checking for integer overflow.
6029 (check_image_size): Assume that f is nonnull, since
6030 it is always nonnull in practice. This is one less thing to
6031 worry about when checking for integer overflow later.
6032 (x_check_image_size): New function, which checks for integer
6033 overflow issues inside X.
6034 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6035 This removes the need for a memory_full check.
6036 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6037 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6038 (xbm_read_bitmap_data): Change locals back to 'int', since
6039 their values must fit in 'int'.
6040 (xpm_load_image, png_load, tiff_load):
6041 Invoke x_create_x_image_and_pixmap earlier,
6042 to avoid much needless work if the image is too large.
6043 (tiff_load): Treat overly large images as if
6044 x_create_x_image_and_pixmap failed, not as malloc failures.
6045 (gs_load): Use x_check_image_size.
6046
5f8f9cc2
PE
6047 * gtkutil.c: Omit integer casts.
6048 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6049 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6050
5adf60bc
PE
6051 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6052
c8907a93
PE
6053 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6054 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6055 would wrongly return t on a 64-bit host.
6056
e3c25c68
PE
6057 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6058 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6059 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6060 and therefore cause GCC to emit a bogus diagnostic in some cases.
6061
3f791afe
PE
6062 * image.c: Integer signedness and overflow and related fixes.
6063 This is not an exhaustive set of fixes, but it's time to
6064 record what I've got.
6065 (lookup_pixel_color, check_image_size): Remove redundant decls.
6066 (check_image_size): Don't assume that arbitrary EMACS_INT values
6067 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6068 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6069 (tiff_load, imagemagick_load_image):
6070 Check for overflow in size calculations.
6071 (x_create_x_image_and_pixmap): Remove unnecessary test for
6072 xmalloc returning NULL; that can't happen.
6073 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6074 (xpm_color_bucket): Use better integer hashing function.
6075 (xpm_cache_color): Don't possibly over-allocate memory.
6076 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6077 (gif_memory_source):
6078 Use ptrdiff_t, not int or size_t, to record sizes.
6079 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6080 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6081 either works, as we prefer signed integers.
6082 (tiff_read_from_memory, tiff_write_from_memory):
6083 Return tsize_t, not size_t, since that's what the TIFF API wants.
6084 (tiff_read_from_memory): Don't fail simply because the read would
6085 go past EOF; instead, return a short read.
6086 (tiff_load): Omit no-longer-needed casts.
6087 (Fimagemagick_types): Don't assume size fits into 'int'.
6088
3cc5a532
PE
6089 Improve hashing quality when configured --with-wide-int.
6090 * fns.c (hash_string): New function, taken from sxhash_string.
6091 Do not discard information about ASCII character case; this
6092 discarding is no longer needed.
6093 (sxhash-string): Use it. Change sig to match it. Caller changed.
6094 * lisp.h: Declare it.
6095 * lread.c (hash_string): Remove, since we now use fns.c's version.
6096 The fns.c version returns a wider integer if --with-wide-int is
6097 specified, so this should help the quality of the hashing a bit.
6098
b312a492
PE
6099 * emacs.c: Integer overflow minor fix.
6100 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6101 Define only if GNU_LINUX.
6102 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6103
dfd153ae
PE
6104 * dispnew.c: Integer signedness and overflow fixes.
6105 Remove unnecessary forward decls, that were a maintenance hassle.
6106 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6107 All uses changed.
6108 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6109 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6110 (prepare_desired_row, line_draw_cost):
6111 Use int, not unsigned, where either works.
6112 (save_current_matrix, restore_current_matrix):
6113 Use ptrdiff_t, not size_t, where either works.
6114 (init_display): Check for overflow more accurately, and without
6115 relying on undefined behavior.
6116
a81d11a3
PE
6117 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6118 Remove, replacing with the new symbols in lisp.h. All uses changed.
6119 * fileio.c (make_temp_name):
6120 * filelock.c (lock_file_1, lock_file):
6121 * xdisp.c (message_dolog):
6122 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6123 Use pMd etc. instead.
6124 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6125 replacing the pWIDE etc. symbols removed from editfns.c.
6126
3300e6fd
PE
6127 * keyboard.h (num_input_events): Now uintmax_t.
6128 This is (very slightly) less likely to mess up due to wraparound.
6129 All uses changed.
6130
fd05c7e9
PE
6131 * buffer.c: Integer signedness fixes.
6132 (alloc_buffer_text, enlarge_buffer_text):
6133 Use ptrdiff_t rather than size_t when either will do, as we prefer
6134 signed integers.
6135
903fe15d
PE
6136 * alloc.c: Integer signedness and overflow fixes.
6137 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6138 (__malloc_size_t): Default to size_t, not to int.
6139 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6140 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6141 Prefer ptrdiff_t to size_t when either would do, as we prefer
6142 signed integers.
6143 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6144 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6145 Now const. Initialize with values that are in range even if char
6146 is signed.
6147 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6148 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6149 These functions do the right thing with sizes > 2**32.
6150 (check_depth): Now ptrdiff_t, not int.
6151 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6152 Adjust to new way of storing sizes. Check for size overflow bugs
6153 in rest of code.
6154 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6155 slightly wrong anyway, as it missed one instance of
6156 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6157 (refill_memory_reserve): Omit needless cast to size_t.
6158 (mark_object_loop_halt): Mark as externally visible.
6159
ac82cc6a
PE
6160 * xselect.c: Integer signedness and overflow fixes.
6161 (Fx_register_dnd_atom, x_handle_dnd_message):
6162 Use ptrdiff_t, not size_t, since we prefer signed.
6163 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6164 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6165 x_dnd_atoms_size and x_dnd_atoms_length.
6166
c2d1e36d
PE
6167 * doprnt.c: Prefer signed to unsigned when either works.
6168 * eval.c (verror):
6169 * doprnt.c (doprnt):
6170 * lisp.h (doprnt):
6171 * xdisp.c (vmessage):
6172 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6173 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6174 prefer signed arithmetic to avoid comparison confusion.
6175 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6176 but is a bit tricky.
6177
0e926e56
PE
6178 Assume freestanding C89 headers, string.h, stdlib.h.
6179 * data.c, doprnt.c, floatfns.c, print.c:
6180 Include float.h unconditionally.
6181 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6182 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6183 * regex.c: Likewise for stddef.h, string.h.
6184 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6185 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6186 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6187 (STDC_HEADERS): Remove obsolete defines.
6188 * sysdep.c: Include limits.h unconditionally.
6189
9cfdb3ec
PE
6190 Assume support for memcmp, memcpy, memmove, memset.
6191 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6192 * regex.c (memcmp, memcpy):
6193 Remove; we assume C89 now.
6194
6195 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6196 (__malloc_safe_bcopy): Remove; no longer needed.
6197
cf950e6b 6198 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6199 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6200 well either way, and we prefer signed to unsigned.
6201
dbf38e02
LMI
62022011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6203
6204 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6205 closes the connection while we're reading (bug#9182).
6206
d6f0886c 62072011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6208
d6f0886c
JD
6209 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6210 are specified (Bug#9168).
24e0f6b1 6211
2eb1f9e6
PE
62122011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6213
6214 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6215 Found by GCC static checking and --with-wide-int on a 32-bit host.
6216
22381272 62172011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6218
6219 * xdisp.c (compute_display_string_pos): Fix logic of caching
6220 previous display string position. Initialize cached_prev_pos to
6221 -1. Fixes slow-down at the beginning of a buffer.
6222
f25e39b4
EZ
62232011-07-24 Eli Zaretskii <eliz@gnu.org>
6224
6225 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6226 for attrs[LFACE_FONTSET_INDEX].
6227
04c4b52e
PE
62282011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6229
6230 * xml.c (parse_region): Remove unused local
6231 that was recently introduced.
6232
c1734fbd
EZ
62332011-07-23 Eli Zaretskii <eliz@gnu.org>
6234
be18c5a5
EZ
6235 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6236 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6237
c1734fbd
EZ
6238 * xdisp.c (move_it_in_display_line_to): Record the best matching
6239 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6240 exit if none of the characters scanned was an exact match.
6241 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6242 when exact match is impossible due to invisible text, and the
6243 lines are truncated.
6244
a258d627
JD
62452011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6246
6247 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6248 for OSX >= 10.7.
6249
b6d5a689
EZ
62502011-07-22 Eli Zaretskii <eliz@gnu.org>
6251
0f74f785
EZ
6252 Fix a significant slow-down of cursor motion with C-n, C-p,
6253 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6254 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6255 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6256 (next_element_from_buffer): Call compute_stop_pos_backwards to
6257 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6258 base_level_stop.
6259 (reseat): Don't look for prev_stop, as that could mean a very long
6260 run.
6261 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6262 <cached_disp_overlay_modiff>: Cache for last found display string
6263 position.
551918c1 6264 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6265 about the same buffer in the same area of character positions, and
6266 the buffer wasn't changed since the time the display string
6267 position was cached.
551918c1 6268
b2d0c91a
EZ
62692011-07-22 Eli Zaretskii <eliz@gnu.org>
6270
6271 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6272 is an integer, which is important for empty lines. (Bug#9149)
6273
043604ee
CY
62742011-07-22 Chong Yidong <cyd@stupidchicken.com>
6275
6276 * frame.c (Fmodify_frame_parameters): In tty case, update the
6277 default face if necessary (Bug#4238).
6278
da4adb04
CY
62792011-07-21 Chong Yidong <cyd@stupidchicken.com>
6280
6281 * editfns.c (Fstring_to_char): No need to explain what a character
6282 is in the docstring (Bug#6576).
6283
9abd0532
LMI
62842011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6285
6286 * xml.c (parse_region): Make sure we always return a tree.
6287
36881d16
HK
62882011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6289
6290 * xml.c (parse_region): If a document contains only comments,
6291 return that, too.
6292
1e98674d
LMI
62932011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6294
6295 * xml.c (make_dom): Return comments, too.
6296
590bd467
PE
62972011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6298
6299 Port to OpenBSD.
6300 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6301 and the surrounding thread.
6302 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6303 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6304 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6305 timer goes off.
6306 * s/openbsd.h (BROKEN_SIGIO): Define.
6307 * unexelf.c (unexec) [__OpenBSD__]:
6308 Don't update the .mdebug section of the Alpha COFF symbol table.
6309
f41628b2
LMI
63102011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6311
6312 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6313 (bug#8460).
6314
b59b67c5
PE
63152011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6316
15e3a074
PE
6317 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6318 This fixes some race conditions on the permissions of any newly
6319 created file.
6320
41bed37d
PE
6321 * alloc.c (valid_pointer_p): Use pipe, not open.
6322 This fixes some permissions issues when debugging.
6323
b59b67c5
PE
6324 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6325 If fchown fails to set both uid and gid, try to set just gid,
6326 as that is sometimes allowed. Adjust the file's mode to eliminate
6327 setuid or setgid bits that are inappropriate if fchown fails.
6328
925a6be7
SM
63292011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6330
6331 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6332 to compare Lisp_Objects.
6333 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6334 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6335 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6336
52968808
AS
63372011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6338
0a6a104b
AS
6339 * lread.c (read_integer): Unread even EOF character.
6340 (read1): Likewise. Properly record start position of symbol.
6341
52968808
AS
6342 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6343 symbol character follows.
6344
9e381cdd
PE
63452011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6346
6347 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6348 This works around a problem with the previous change to Fcopy_file.
6349 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6350 and without this change, GCC might complain about discarding
6351 fchown's return value.
6352
b5641435
JB
63532011-07-16 Juanma Barranquero <lekktu@gmail.com>
6354
6355 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6356
a8031457
PE
63572011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6358
6359 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6360
dd889327
LMI
63612011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6362
750c33f7
LMI
6363 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6364 it's used from the C level.
6365
dd889327
LMI
6366 * process.c: Use the same condition for POLL_FOR_INPUT in both
6367 keyboard.c and process.c (bug#1858).
6368
87e86684
LM
63692011-07-09 Lawrence Mitchell <wence@gmx.li>
6370
6371 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6372 (Fgnutls_boot): Use it.
6373
64348f40
AS
63742011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6375
6376 * doc.c (Fsubstitute_command_keys): Revert last change.
6377
1d698799
LMI
63782011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6379
f863868c
LMI
6380 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6381 quotes the next character, and doesn't affect other longer
6382 sequences (bug#8935).
6383
1d698799
LMI
6384 * lread.c (syms_of_lread): Clarify that is isn't only
6385 `eval-buffer' and `eval-defun' that's affected by
6386 `lexical-binding' (bug#8460).
6387
aa4b6df6
EZ
63882011-07-15 Eli Zaretskii <eliz@gnu.org>
6389
6390 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6391 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6392
5d856da6
PE
63932011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6394
ad6042bb
PE
6395 Fix minor problems found by static checking.
6396 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6397 (elsz): Now a signed constant, not a size_t var. We prefer signed
6398 types to unsigned, to avoid integer comparison confusion. Without
6399 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6400 "cannot optimize loop, the loop counter may overflow", a symptom
6401 of the confusion.
f00bbb22 6402 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6403 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6404
6468f31c
LMI
64052011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6406
49080b10
LMI
6407 * search.c (Fre_search_backward): Mention `case-fold-search' in
6408 all the re_search_* functions (bug#8138).
6409
6468f31c
LMI
6410 * keyboard.c (Fopen_dribble_file): Document when the file is
6411 closed (bug#8056).
6412
c965adc5
EZ
64132011-07-14 Eli Zaretskii <eliz@gnu.org>
6414
df9733bf
EZ
6415 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6416 bidi_cache_idx.
6417
0bb23927
EZ
6418 Support bidi reordering of display and overlay strings.
6419 * xdisp.c (compute_display_string_pos)
6420 (compute_display_string_end): Accept additional argument STRING.
6421 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6422 (reseat_to_string): Initialize bidi_it->string.s and
6423 bidi_it->string.schars.
6424 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6425 NULL (avoids a crash in bidi_paragraph_init).
6426 Initialize itb.string.lstring.
0bb23927
EZ
6427 (init_iterator): Call bidi_init_it only of a valid
6428 buffer position was specified. Initialize paragraph_embedding to
6429 L2R.
6430 (reseat_to_string): Initialize the bidi iterator.
6431 (display_string): If we need to ignore text properties of
6432 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6433 original value of -1 will not work with bidi.)
6434 (compute_display_string_pos): First arg is now struct
6435 `text_pos *'; all callers changed. Support display properties on
6436 Lisp strings.
6437 (compute_display_string_end): Support display properties on Lisp
6438 strings.
6439 (init_iterator, reseat_1, reseat_to_string): Initialize the
6440 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6441 when iterating on a string not from display properties).
640c8776
SM
6442 (compute_display_string_pos, compute_display_string_end):
6443 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6444 arrow keys.
6445 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6446 base_level_stop; instead, set base_level_stop to BEGV.
6447 Fixes crashes in vertical-motion.
0bb23927
EZ
6448 (next_element_from_buffer): Improve commentary for when
6449 the iterator is before prev_stop.
6450 (init_iterator): Initialize bidi_p from the default value of
6451 bidi-display-reordering, not from buffer-local value. Use the
6452 buffer-local value only if initializing for buffer iteration.
6453 (handle_invisible_prop): Support invisible properties on strings
6454 that are being bidi-reordered.
6455 (set_iterator_to_next): Support bidi reordering of C strings and
6456 Lisp strings.
6457 (next_element_from_string): Support bidi reordering of Lisp
6458 strings.
6459 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6460 (display_string): Support display of R2L glyph rows.
6461 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6462 (init_iterator): Don't initialize it->bidi_p for strings
6463 here.
6464 (reseat_to_string): Initialize it->bidi_p for strings here.
6465 (next_element_from_string, next_element_from_c_string)
6466 (next_element_from_buffer): Add xassert's for correspondence
6467 between IT's object being iterated and it->bidi_it.string
6468 structure.
6469 (face_before_or_after_it_pos): Support bidi iteration.
6470 (next_element_from_c_string): Handle the case of the first string
6471 character that is not the first one in the visual order.
6472 (get_visually_first_element): New function, refactored from common
6473 parts of next_element_from_buffer, next_element_from_string, and
6474 next_element_from_c_string.
6475 (tool_bar_lines_needed, redisplay_tool_bar)
6476 (display_menu_bar): Force left-to-right direction. Add a FIXME
6477 comment for making that be controlled by a user option.
6478 (push_it, pop_it): Save and restore the state of the
6479 bidi iterator. Save and restore the bidi_p flag.
6480 (pop_it): Iterate out of display property for string iteration as
6481 well.
6482 (iterate_out_of_display_property): Support iteration over strings.
6483 (handle_single_display_spec): Set up it->bidi_it for iteration
6484 over a display string, and call bidi_init_it.
6485 (handle_single_display_spec, next_overlay_string)
6486 (get_overlay_strings_1, push_display_prop): Set up the bidi
6487 iterator for displaying display or overlay strings.
6488 (forward_to_next_line_start): Don't use the shortcut if
6489 bidi-iterating.
6490 (back_to_previous_visible_line_start): If handle_display_prop
6491 pushed the iterator stack, restore the internal state of the bidi
6492 iterator by calling bidi_pop_it same number of times.
6493 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6494 and we are bidi-iterating, don't decrement the iterator position;
6495 instead, set the first_elt flag in the bidi iterator, to produce
6496 the same effect.
6497 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6498 (push_display_prop): xassert that we are iterating a buffer.
6499 (push_it, pop_it): Save and restore paragraph_embedding member.
6500 (handle_single_display_spec, next_overlay_string)
6501 (get_overlay_strings_1, reseat_1, reseat_to_string)
6502 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6503 correctly. Don't assume unibyte strings are not bidi-reordered.
6504 (compute_display_string_pos)
6505 (compute_display_string_end): Fix handling the case of C string.
6506 (push_it, pop_it): Save and restore from_disp_prop_p.
6507 (handle_single_display_spec, push_display_prop): Set the
6508 from_disp_prop_p flag.
6509 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6510 (pop_it): Call iterate_out_of_display_property only if we are
6511 popping after iteration over a string that came from a display
6512 property. Fix a typo in popping stretch info. Add an assertion
6513 for verifying that the iterator position is in sync with the bidi
6514 iterator.
6515 (handle_single_display_spec, get_overlay_strings_1)
6516 (push_display_prop): Fix initialization of paragraph direction for
6517 string when that of the parent object is not yet determined.
6518 (reseat_1): Call bidi_init_it to resync the bidi
6519 iterator with IT's position. (Bug#7616)
6520 (find_row_edges): If ROW->start.pos gives position
6521 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6522 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6523 Reset the from_disp_prop_p flag.
6524 (SAVE_IT, RESTORE_IT): New macros.
6525 (pos_visible_p, face_before_or_after_it_pos)
6526 (back_to_previous_visible_line_start)
6527 (move_it_in_display_line_to, move_it_in_display_line)
6528 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6529 (try_scrolling, redisplay_window, display_line): Use them when
6530 saving a temporary copy of the iterator and restoring it back.
6531 (back_to_previous_visible_line_start, reseat_1)
6532 (init_iterator): Empty the bidi cache "stack".
6533 (move_it_in_display_line_to): If iterator ended up at
6534 EOL, but we never saw any buffer positions smaller than
6535 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6536 motion in bidi-reordered lines.
6537 (move_it_in_display_line_to): Record prev_method and prev_pos
6538 immediately before the call to set_iterator_to_next. Fixes cursor
6539 motion in bidi-reordered lines with stretch glyphs and strings
6540 displayed in margins. (Bug#8133) (Bug#8867)
6541 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6542 TO_CHARPOS.
640c8776
SM
6543 (pos_visible_p): Support positions in bidi-reordered lines.
6544 Save and restore bidi cache.
0bb23927
EZ
6545
6546 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6547 (bidi_paragraph_info): Delete unused struct.
6548 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6549 (bidi_cache_start): New variable.
6550 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6551 to zero.
6552 (bidi_cache_fetch_state, bidi_cache_search)
6553 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6554 (bidi_cache_find, bidi_peek_at_next_level)
6555 (bidi_level_of_next_char, bidi_find_other_level_edge)
6556 (bidi_move_to_visually_next): Compare cache index with
6557 bidi_cache_start rather than with zero.
6558 (bidi_fetch_char): Accept new argument STRING; all callers
6559 changed. Support iteration over a string. Support strings with
6560 display properties. Support unibyte strings. Fix the type of
6561 `len' according to what STRING_CHAR_AND_LENGTH expects.
6562 (bidi_paragraph_init, bidi_resolve_explicit_1)
6563 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6564 (bidi_level_of_next_char, bidi_move_to_visually_next):
6565 Support iteration over a string.
0bb23927
EZ
6566 (bidi_set_sor_type, bidi_resolve_explicit_1)
6567 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6568 can now be zero (for strings); special values 0 and -1 were
6569 changed to -1 and -2, respectively.
6570 (bidi_char_at_pos): New function.
6571 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6572 Call it instead of FETCH_MULTIBYTE_CHAR.
6573 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6574 initialized to valid values.
6575 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6576 values.
6577 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6578 the test for valid cached positions. Fix the logic for looking up
6579 the sentinel state in the cache. GCPRO the Lisp string we are
6580 iterating.
6581 (bidi_push_it, bidi_pop_it): New functions.
6582 (bidi_initialize): Initialize the bidi cache start stack pointer.
6583 (bidi_cache_ensure_space): New function, refactored from part of
6584 bidi_cache_iterator_state. Don't assume the required size is just
6585 one BIDI_CACHE_CHUNK away.
6586 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6587 (bidi_count_bytes, bidi_char_at_pos): New functions.
6588 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6589 always valid if bidi_cache_idx is valid.
6590 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6591 is valid if it's going to be used.
6592 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6593 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6594 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6595 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6596 (bidi_find_other_level_edge, bidi_cache_start_stack):
6597 All variables related to cache indices are now EMACS_INT.
c965adc5 6598
0bb23927
EZ
6599 * dispextern.h (struct bidi_string_data): New structure.
6600 (struct bidi_it): New member `string'. Make flag members be 1-bit
6601 fields, and put them last in the struct.
640c8776
SM
6602 (compute_display_string_pos, compute_display_string_end):
6603 Update prototypes.
0bb23927
EZ
6604 (bidi_push_it, bidi_pop_it): Add prototypes.
6605 (struct iterator_stack_entry): New members bidi_p,
6606 paragraph_embedding, and from_disp_prop_p.
6607 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6608 (bidi_shelve_cache, bidi_unshelve_cache):
6609 Declare prototypes.
0bb23927
EZ
6610
6611 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6612 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6613 and vector-like objects.
6614
6615 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6616 cache around display iteration.
6617
6618 * window.c (Fwindow_end, window_scroll_pixel_based)
6619 (displayed_window_lines, Frecenter): Save and restore the bidi
6620 cache around display iteration.
6621
3bbd2265
LMI
66222011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6623
6624 * editfns.c (Fdelete_region): Clarify the use of the named
6625 parameters (bug#6788).
6626
adc47434
MR
66272011-07-14 Martin Rudalics <rudalics@gmx.at>
6628
6629 * indent.c (Fvertical_motion): Set and restore w->pointm when
6630 saving and restoring the window's buffer (Bug#9006).
6631
837c31f8
LMI
66322011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6633
6634 * editfns.c (Fstring_to_char): Clarify just what is returned
6635 (bug#6576). Text by Eli Zaretskii.
6636
ac389d0c
JB
66372011-07-13 Juanma Barranquero <lekktu@gmail.com>
6638
6639 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6640
0be0ce47
EZ
66412011-07-13 Eli Zaretskii <eliz@gnu.org>
6642
6643 * buffer.c (mmap_find): Fix a typo.
6644
cd18e7e3
JB
66452011-07-13 Johan Bockgård <bojohan@gnu.org>
6646
6647 Fix execution of x selection hooks.
6648 * xselect.c (Qx_lost_selection_functions)
6649 (Qx_sent_selection_functions): New vars.
6650 (syms_of_xselect): DEFSYM them.
6651 (x_handle_selection_request): Pass Qx_sent_selection_functions
6652 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6653 (x_handle_selection_clear,x_clear_frame_selections):
6654 Pass Qx_lost_selection_functions rather than
6655 Vx_lost_selection_functions to Frun_hook_with_args.
6656
47ea7f44
PE
66572011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6658
ac389d0c 6659 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6660 The old code sometimes used this field without initializing it.
6661
47ea7f44
PE
6662 * alloc.c (gc_sweep): Don't read past end of array.
6663 In theory, the old code could also have corrupted Emacs internals,
6664 though it'd be very unlikely.
6665
bc985c87
AS
66662011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6667
6668 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6669 argument. (Bug#4026)
bc985c87 6670
0cf34688
LMI
66712011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6672
b3dadd76
LMI
6673 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6674 key" (bug#4257).
6675
0cf34688
LMI
6676 * window.c (Fset_window_start): Doc fix (bug#4199).
6677 (Fset_window_hscroll): Ditto.
6678
270768cd
PE
66792011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6680
077e3dda 6681 Fix minor new problems caught by GCC 4.6.1.
270768cd 6682 * term.c (init_tty): Remove unused local.
490011a6 6683 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6684 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6685 not used otherwise.
270768cd 6686
b1f58454
CY
66872011-07-12 Chong Yidong <cyd@stupidchicken.com>
6688
6689 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6690
22b9578d
LMI
66912011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6692
6e70ab07
LMI
6693 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6694 are the mini-buffer and the echo area (bug#3320).
6695
22b9578d
LMI
6696 * term.c (init_tty): Remove support for supdup, c10 and perq
6697 terminals, which are no longer supported (bug#1482).
6698
8974cc9f
JB
66992011-07-10 Johan Bockgård <bojohan@gnu.org>
6700
6701 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6702
a560d974
JD
67032011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6704
6705 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6706 for non-popups (Bug#3642).
6707
1dae0f0a
AS
67082011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6709
268c2c36 6710 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6711 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6712 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6713 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6714 * data.c (fmod): Likewise.
6715 * dispnew.c (swap_glyphs_in_rows): Likewise.
6716 * emacs.c (memory_warning_signal): Likewise.
6717 * floatfns.c (float_error): Likewise.
6718 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6719 (otf_open, font_otf_capability, generate_otf_features)
6720 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6721 Likewise.
6722 * image.c (pbm_read_file): Likewise.
6723 * indent.c (string_display_width): Likewise.
6724 * intervals.c (check_for_interval, search_for_interval)
6725 (inc_interval_count, count_intervals, root_interval)
6726 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6727 * lread.c (defalias): Likewise.
268c2c36 6728 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6729 * regex.c (set_image_of_range_1, set_image_of_range)
6730 (regex_grow_registers): Likewise.
6731 * sysdep.c (strerror): Likewise.
6732 * termcap.c (valid_filename_p, tprint, main): Likewise.
6733 * tparam.c (main): Likewise.
6734 * unexhp9k800.c (run_time_remap, save_data_space)
6735 (update_file_ptrs, read_header, write_header, calculate_checksum)
6736 (copy_file, copy_rest, display_header): Likewise.
6737 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6738 Likewise.
6739 * xdisp.c (check_it): Likewise.
6740 * xfaces.c (register_color, unregister_color, unregister_colors):
6741 Likewise.
6742 * xfns.c (print_fontset_result): Likewise.
6743 * xrdb.c (member, fatal, main): Likewise.
6744
99033785
PE
67452011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6746
6747 Fix minor problems found by static checking (Bug#9031).
6748 * chartab.c (char_table_set_range, map_sub_char_table):
6749 Remove unused locals.
6750 (uniprop_table): Now static.
6751 * composite.c (_work_char): Remove unused static var.
6752
9cb2ac56
JB
67532011-07-09 Juanma Barranquero <lekktu@gmail.com>
6754
6755 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6756
f25661f0
JD
67572011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6758
6759 * gtkutil.c (qttip_cb): Remove code without function.
6760
8278c4fe
EZ
67612011-07-09 Eli Zaretskii <eliz@gnu.org>
6762
6763 * w32.c (pthread_sigmask): New stub.
6764
1692ae2d 67652011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6766
8a6ebd58 6767 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6768 sigprocmask is portable only for single-threaded applications, and
6769 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6770 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6771 (LIBES): Use it.
6772 * callproc.c (Fcall_process):
6773 * process.c (create_process):
6774 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6775 Use pthread_sigmask, not sigprocmask.
123403e4 6776
1b854618
JD
67772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6778
6779 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6780 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6781 wrong (Bug#8591).
6782
3fe4b549
JD
67832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6784
0ce7e563
JD
6785 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6786 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6787 (xg_hide_tooltip): Fix comment.
6788
3fe4b549
JD
6789 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6790 in registerServicesMenuSendTypes.
6791 (validRequestorForSendType): Don't check ns_return_types.
6792
6793 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6794 ns_return_type.
6795
5df75e47
JR
67962011-07-08 Jason Rumney <jasonr@gnu.org>
6797
22610910
JR
6798 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6799 SH_SHOW for hidden windows (Bug#5482).
6800
5df75e47
JR
6801 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6802 frame struct members of non-existent frames (Bug#6284).
6803
699c10bd
JD
68042011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6805
4393663b
JD
6806 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6807 variable firstTime not needed on OSX >= 10.6.
6808 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6809 >= 10.5. Use setKnobProportion, setDoubleValue.
6810
6811 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6812 (MAC_OS_X_VERSION_10_5): Define if not defined.
6813 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6814 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6815 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6816
6817 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6818 cString and lossyCString on OSX >= 10.4
6819
58179cce 6820 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6821 sizeToFit on OSX >= 10.2.
6822
6823 * nsimage.m (allocInitFromFile): Don't use deprecated method
6824 bestRepresentationForDevice on OSX >= 10.6.
6825
6826 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6827 to avoid warning.
6828
6829 * emacs.c: Declare unexec_init_emacs_zone.
6830
a63e0781
JD
6831 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6832
699c10bd
JD
6833 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6834
6835 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6836 on svcsMenu (Bug#8842).
6837
6838 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6839 ns_return_types.
6840 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6841
6842 * nsterm.m (QUTF8_STRING): Declare.
6843 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6844 (validRequestorForSendType): Return type is (id).
6845 Change indexOfObjectIdenticalTo to indexOfObject.
6846 Check if we have local selection before returning self (Bug#8842).
6847 (writeSelectionToPasteboard): Put local selection into paste board
6848 if we have a local selection (Bug#8842).
6849 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6850
6851 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6852 (ns_get_local_selection): Declare.
6853
54e10184
LMI
68542011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6855
9888ff71
LMI
6856 * keymap.c (describe_map_tree): Don't insert a double newline at
6857 the end of the buffer (bug#1169) and return whether we inserted
6858 something.
6859
54e10184
LMI
6860 * callint.c (Fcall_interactively): Change "reading args" to
6861 "providing args" to try to clarify what it does (bug#1010).
6862
15fa4783
KH
68632011-07-07 Kenichi Handa <handa@m17n.org>
6864
6865 * composite.c (composition_compute_stop_pos): Ignore a static
6866 composition starting before CHARPOS (Bug#8915).
6867
6868 * xdisp.c (handle_composition_prop): Likewise.
6869
a8815b00
EZ
68702011-07-07 Eli Zaretskii <eliz@gnu.org>
6871
6872 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6873 (Bug#9015)
6874
ef7b981d 68752011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6876
6877 * character.h (unicode_category_t): New enum type.
6878
6879 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6880 (Qchar_code_property_table): New variable.
6881 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6882 (UNIPROP_COMPRESSED_FORM_P): New macros.
6883 (char_table_ascii): Uncompress the compressed values.
6884 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6885 Uncompress the compressed values.
ac389d0c 6886 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6887 (char_table_ref_and_range): Uncompress the compressed values.
6888 (sub_char_table_set): New arg is_uniprop. Callers changed.
6889 Uncompress the compressed values.
6890 (sub_char_table_set_range): Args changed. Callers changed.
6891 (char_table_set_range): Adjuted for the above change.
6892 (map_sub_char_table): Delete args default_val and parent. Add arg
6893 top. Give decoded values to a Lisp function.
640c8776 6894 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6895 values to a Lisp function. Gcpro more variables.
6896 (uniprop_table_uncompress)
6897 (uniprop_decode_value_run_length): New functions.
6898 (uniprop_decoder, uniprop_decoder_count): New variables.
6899 (uniprop_get_decoder, uniprop_encode_value_character)
6900 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6901 New functions.
6902 (uniprop_encoder, uniprop_encoder_count): New variables.
6903 (uniprop_get_encoder, uniprop_table)
6904 (Funicode_property_table_internal, Fget_unicode_property_internal)
6905 (Fput_unicode_property_internal): New functions.
6906 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6907 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6908 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6909 char-code-property-alist.
6910
640c8776 6911 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6912 Vunicode_category_table.
6913
640c8776 6914 * font.c (font_range): Adjust for the change of
c805dec0
KH
6915 Vunicode_category_table.
6916
76b397fb
DN
69172011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6918
6919 * m/iris4d.h: Remove file, move contents ...
6920 * s/irix6-5.h: ... here.
6921
22b4128e
PE
69222011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6923
6924 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6925 * alloc.c (mark_buffer):
6926 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6927 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6928 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6929 This isn't true in general, and it's particularly not true
6930 if Emacs is configured with --with-wide-int.
6931 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6932 New macros, used in the buffer.c change.
6933
869795d6
JD
69342011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6935
6936 * xsettings.c: Use both GConf and GSettings if both are available.
6937 (store_config_changed_event): Add comment.
6938 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6939 (store_tool_bar_style_changed): New functions.
5e617bc2 6940 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6941 (struct xsettings): Move font inside HAVE_XFT.
6942 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6943 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6944 Move inside HAVE_XFT.
640c8776 6945 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6946 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6947 also.
6948 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6949 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6950 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6951 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6952 (parse_settings): Move check for font inside HAVE_XFT.
6953 (read_settings, apply_xft_settings): Add comment.
6954 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6955 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6956 call store_font_name_changed.
6957 (xft_settings_event): Add comment.
6958 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6959 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6960 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6961 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6962 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6963 (xsettings_get_system_font, xsettings_get_system_normal_font):
6964 Add comment.
869795d6 6965
d8ed26bd
PE
69662011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6967
6968 Random fixes. E.g., (random) never returned negative values.
6969 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6970 subseconds part to the entropy, as that's a bit more random.
6971 Prefer signed to unsigned, since the signedness doesn't matter and
6972 in general we prefer signed. When given a limit, use a
6973 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6974 latter isn't right if USE_2_TAGS_FOR_INTS.
6975 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6976 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6977
cabf1cac
SM
69782011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6979
6980 * textprop.c (text_property_stickiness):
6981 Obey Vtext_property_default_nonsticky.
6982 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6983 * w32fns.c (syms_of_w32fns):
6984 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6985
6e9b2be9
PE
69862011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6987
6988 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6989 This is more efficient than Ffile_directory_p and avoids a minor race.
6990
90186c68
LMI
69912011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6992
7c301272
LMI
6993 * buffer.c (Foverlay_put): Say what the return value is
6994 (bug#7835).
6995
c4f2d8d4
LMI
6996 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6997 is a directory before asking whether to use the file name
6998 (bug#7564).
ad637907
LMI
6999 (barf_or_query_if_file_exists): Make the "File is a directory"
7000 error be more correct.
c4f2d8d4 7001
90186c68
LMI
7002 * fns.c (Frequire): Remove the mention of the .gz files, since
7003 that's installation-specific, but keep the mention of
7004 `get-load-suffixes'.
7005
da64016e
PE
70062011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7007
7008 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7009 Report string overflow if the output is too long.
7010
7d47b580
JB
70112011-07-04 Juanma Barranquero <lekktu@gmail.com>
7012
a555cb87
JB
7013 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7014 (syms_of_gnutls): Remove duplicate DEFSYM for
7015 Qgnutls_bootprop_verify_hostname_error, an error for
7016 Qgnutls_bootprop_verify_error (which is no longer used).
7017
7d47b580
JB
7018 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7019 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7020 Also (re)move comments that are misplaced or no longer relevant.
7021
1e49bfab
LMI
70222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7023
7024 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7025
1485f4c0
CY
70262011-07-03 Chong Yidong <cyd@stupidchicken.com>
7027
7028 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7029 and background color parameters if they have been changed.
7030
a9ab721e
LMI
70312011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7032
7033 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7034
cf7cff57
PE
70352011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7036
2e13213d
PE
7037 * xsettings.c (SYSTEM_FONT): Define only when used.
7038 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7039
cf7cff57
PE
7040 * keymap.c (access_keymap_1): Now static.
7041
7a8e04f7
CY
70422011-07-02 Chong Yidong <cyd@stupidchicken.com>
7043
7044 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7045 leave any prefix arg for the up event (Bug#1586).
7046
61352f62
LMI
70472011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7048
69bb1ef7
LMI
7049 * lread.c (syms_of_lread): Mention single symbols defined by
7050 `defvar' or `defconst' (bug#7154).
7051
61352f62 7052 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7053 (Frequire): Mention get-load-suffixes.
61352f62 7054
28545e04
MR
70552011-07-02 Martin Rudalics <rudalics@gmx.at>
7056
7057 * window.h (window): Remove clone_number slot.
7058 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7059 Remove.
7060 (make_parent_window, make_window, saved_window)
7061 (Fset_window_configuration, save_window_save): Don't deal with
7062 clone numbers.
7063 * buffer.c (Qclone_number): Remove declaration.
7064 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7065
3349e122
SM
70662011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7067
7068 Add multiple inheritance to keymaps.
7069 * keymap.c (Fmake_composed_keymap): New function.
7070 (Fset_keymap_parent): Simplify.
7071 (fix_submap_inheritance): Remove.
7072 (access_keymap_1): New function extracted from access_keymap to handle
7073 embedded parents and handle lists of maps.
7074 (access_keymap): Use it.
7075 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7076 (Fcopy_keymap): Handle embedded parents.
7077 (Fcommand_remapping, define_as_prefix): Simplify.
7078 (Fkey_binding): Simplify.
7079 (syms_of_keymap): Move minibuffer-local-completion-map,
7080 minibuffer-local-filename-completion-map,
7081 minibuffer-local-must-match-map, and
7082 minibuffer-local-filename-must-match-map to Elisp.
7083 (syms_of_keymap): Defsubr make-composed-keymap.
7084 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7085 (parse_menu_item): Trivial simplification.
7086
3279eb87
GM
70872011-07-01 Glenn Morris <rgm@gnu.org>
7088
7089 * Makefile.in (SETTINGS_LIBS): Fix typo.
7090
4550efdf
KI
70912011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7092
7093 * coding.c (Fencode_coding_string): Record the last coding system
7094 used, as the function doc string says (bug#8738).
7095
0949d2b6
JD
70962011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7097
7098 * xsettings.c (store_monospaced_changed): Take new font as arg and
7099 check for change against current_mono_font.
7100 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7101 (emacs_settings_constructor, emacs_settings_get_property)
7102 (emacs_settings_set_property, emacs_settings_class_init)
7103 (emacs_settings_init, gsettings_obj): Remove.
7104 (something_changedCB): New function for HAVE_GSETTINGS.
7105 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7106 with value as argument.
7107 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7108 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7109 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7110 "changed".
7111
7112 * xgselect.c: Add defined (HAVE_GSETTINGS).
7113 (xgselect_initialize): Ditto.
7114
7115 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7116 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7117 xg_select.
7118
bbc6b304
PE
71192011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7120
7121 * eval.c (struct backtrace): Simplify and port the data structure.
7122 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7123 signed bit field, as this assumption is not portable and it makes
7124 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7125 "char debug_on_exit : 1" as this is not portable either; instead,
7126 use the portable "unsigned int debug_on_exit : 1". Remove unused
7127 member evalargs. Remove obsolete comments about cc bombing out.
7128
9851bfc5
JD
71292011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7130
51bb811f 7131 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7132 Let HAVE_GSETTINGS override HAVE_GCONF.
7133 (store_monospaced_changed): New function.
7134 (EMACS_SETTINGS): A new type derived from GObject to handle
7135 GSettings notifications.
7136 (emacs_settings_constructor, emacs_settings_get_property)
7137 (emacs_settings_set_property, emacs_settings_class_init):
7138 New functions.
7139 (gsettings_client, gsettings_obj): New variables.
7140 (GSETTINGS_SCHEMA): New define.
7141 (something_changedCB): Call store_monospaced_changed.
7142 (init_gsettings): New function.
7143 (xsettings_initialize): Call init_gsettings.
7144 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7145 to NULL.
7146
640c8776 7147 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7148 GCONF_CFLAGS/LIBS.
7149
5386012d
MR
71502011-06-29 Martin Rudalics <rudalics@gmx.at>
7151
7152 * window.c (resize_root_window, grow_mini_window)
7153 (shrink_mini_window): Rename Qresize_root_window to
7154 Qwindow_resize_root_window and Qresize_root_window_vertically to
7155 Qwindow_resize_root_window_vertically.
7156
f13e0b08
PE
71572011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7158
7159 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7160
94515237
JB
71612011-06-27 Juanma Barranquero <lekktu@gmail.com>
7162
7163 * makefile.w32-in: Redesign dependencies so they reflect more
7164 clearly which files are directly included by each source file,
7165 and not through other includes.
7166
e43b6e43
MR
71672011-06-27 Martin Rudalics <rudalics@gmx.at>
7168
7169 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7170 (sort_overlays, overlay_strings): When an overlay's clone number
7171 matches the window's clone number process the overlay even if
7172 the overlay's window property doesn't match the current window.
7173
d68443dc
MR
7174 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7175 (Fwindow_hchild): Rename to Fwindow_left_child.
7176 (Fwindow_next): Rename to Fwindow_next_sibling.
7177 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7178 (resize_window_check): Rename to window_resize_check.
7179 (resize_window_apply): Rename to window_resize_apply.
7180 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7181 (Fdelete_other_windows_internal, resize_frame_windows)
7182 (Fsplit_window_internal, Fdelete_window_internal)
7183 (grow_mini_window, shrink_mini_window)
7184 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7185
c7e73be5
JD
71862011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7187
7188 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7189 (emacs_fixed_set_min_size): Remove.
7190 (emacs_fixed_new): Take frame as argument.
7191
7192 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7193 (_EmacsFixedPrivate): Remove minwidth/height.
7194 Add struct frame *f.
7195 (emacs_fixed_init): Initialize priv->f.
7196 (get_parent_class, emacs_fixed_set_min_size): Remove.
7197 (emacs_fixed_new): Set priv->f to argument.
7198 (emacs_fixed_get_preferred_width)
7199 (emacs_fixed_get_preferred_height): Use min_width/height from
7200 frames size_hint to set minimum and natural (Bug#8919).
7201 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7202 and use min_width/height from frames size_hint to set
7203 min_width/height (Bug#8919).
7204
7205 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7206 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7207 Fix indentation.
c7e73be5 7208
cf99dcf8
EZ
72092011-06-26 Eli Zaretskii <eliz@gnu.org>
7210
7211 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7212 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7213 called at ZV.
7214
029529ac
CY
72152011-06-26 Chong Yidong <cyd@stupidchicken.com>
7216
7217 * process.c (wait_reading_process_output): Bypass select if
7218 waiting for a cell while ignoring keyboard input, and input is
7219 pending. Suggested by Jan Djärv (Bug#8869).
7220
7a7ef429
PE
72212011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7222
7223 Use gnulib's dup2 module instead of rolling our own.
7224 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7225
11fdef7d 72262011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7227
7228 * dispnew.c (scrolling_window): Before scrolling, turn off a
7229 mouse-highlight in the window being scrolled.
7230
cd3520a4
JB
72312011-06-24 Juanma Barranquero <lekktu@gmail.com>
7232
7233 Move DEFSYM to lisp.h and use everywhere.
7234
7235 * character.h (DEFSYM): Move declaration...
7236 * lisp.h (DEFSYM): ...here.
7237
7238 * gnutls.c:
7239 * minibuf.c:
7240 * w32menu.c:
7241 * w32proc.c:
7242 * w32select.c: Don't include character.h.
7243
7244 * alloc.c (syms_of_alloc):
7245 * buffer.c (syms_of_buffer):
7246 * bytecode.c (syms_of_bytecode):
7247 * callint.c (syms_of_callint):
7248 * casefiddle.c (syms_of_casefiddle):
7249 * casetab.c (init_casetab_once):
7250 * category.c (init_category_once, syms_of_category):
7251 * ccl.c (syms_of_ccl):
7252 * cmds.c (syms_of_cmds):
7253 * composite.c (syms_of_composite):
7254 * dbusbind.c (syms_of_dbusbind):
7255 * dired.c (syms_of_dired):
7256 * dispnew.c (syms_of_display):
7257 * doc.c (syms_of_doc):
7258 * editfns.c (syms_of_editfns):
7259 * emacs.c (syms_of_emacs):
7260 * eval.c (syms_of_eval):
7261 * fileio.c (syms_of_fileio):
7262 * fns.c (syms_of_fns):
7263 * frame.c (syms_of_frame):
7264 * fringe.c (syms_of_fringe):
7265 * insdel.c (syms_of_insdel):
7266 * keymap.c (syms_of_keymap):
7267 * lread.c (init_obarray, syms_of_lread):
7268 * macros.c (syms_of_macros):
7269 * msdos.c (syms_of_msdos):
7270 * print.c (syms_of_print):
7271 * process.c (syms_of_process):
7272 * search.c (syms_of_search):
7273 * sound.c (syms_of_sound):
7274 * syntax.c (init_syntax_once, syms_of_syntax):
7275 * terminal.c (syms_of_terminal):
7276 * textprop.c (syms_of_textprop):
7277 * undo.c (syms_of_undo):
7278 * w32.c (globals_of_w32):
7279 * window.c (syms_of_window):
7280 * xdisp.c (syms_of_xdisp):
7281 * xfaces.c (syms_of_xfaces):
7282 * xfns.c (syms_of_xfns):
7283 * xmenu.c (syms_of_xmenu):
7284 * xsettings.c (syms_of_xsettings):
7285 * xterm.c (syms_of_xterm): Use DEFSYM.
7286
4228cf16
TZ
72872011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7288
cd3520a4 7289 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7290
7fcccf1e
PE
72912011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7292
7efb4e0e
PE
7293 Integer and buffer overflow fixes (Bug#8873).
7294
ff5844ad
PE
7295 * print.c (printchar, strout): Check for string overflow.
7296 (PRINTPREPARE, printchar, strout):
7297 Don't set size unless allocation succeeds.
7298
90532f02
PE
7299 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7300 for sizes. Check for string overflow more accurately.
7301 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7302
6d84508d
PE
7303 * macros.c: Integer and buffer overflow fixes.
7304 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7305 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7306 Use ptrdiff_t, not int, for sizes.
7307 Don't increment bufsize until after realloc succeeds.
7308 Check for size-calculation overflow.
7309 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7310
437b2cb4
PE
7311 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7312
8b9ac8b4
PE
7313 * lread.c: Integer overflow fixes.
7314 (read_integer): Radix is now EMACS_INT, not int,
7315 to improve quality of diagnostics for out-of-range radices.
7316 Calculate buffer size correctly for out-of-range radices.
7317 (read1): Check for integer overflow in radices, and in
7318 read-circle numbers.
82cb60d3
PE
7319 (read_escape): Avoid int overflow.
7320 (Fload, openp, read_buffer_size, read1)
7321 (substitute_object_recurse, read_vector, read_list, map_obarray):
7322 Use ptrdiff_t, not int, for sizes.
7323 (read1): Use EMACS_INT, not int, for sizes.
20270765 7324 Check for size overflow.
8b9ac8b4 7325
7fcccf1e
PE
7326 * image.c (cache_image): Check for size arithmetic overflow.
7327
bfbbd7e7
PE
7328 * lread.c: Integer overflow issues.
7329 (saved_doc_string_size, saved_doc_string_length)
7330 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7331 Now ptrdiff_t, not int.
7332 (read1): Don't assume doc string length fits in int. Check for
7333 out-of-range doc string lengths.
7334 (read_list): Don't assume file position fits in int.
39019e54 7335 (read_escape): Check for hex character overflow.
bfbbd7e7 7336
4e323265
LL
73372011-06-22 Leo Liu <sdl.web@gmail.com>
7338
7339 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7340 Move to minibuffer.el.
7341
85fece3e
PE
73422011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7343
20b84ce9 7344 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7345 The following patches are for when GLYPH_DEBUG && !XASSERT.
7346 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7347 * dispnew.c (flush_stdout):
7348 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7349 Mark as externally visible.
7350 * dispnew.c (check_window_matrix_pointers): Now static.
7351 * dispnew.c (window_to_frame_vpos):
7352 * xfns.c (unwind_create_frame):
7353 * xterm.c (x_check_font): Remove unused local.
7354 * scroll.c (CHECK_BOUNDS):
7355 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7356 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7357 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7358 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7359 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7360 Now static.
7361 (debug_method_add): Use va_list and vsprintf rather than relying
7362 on undefined behavior with wrong number of arguments.
7363 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7364 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7365 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7366 since we're not interested in debugging glyphs with old libraries.
7367 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7368 GCC 4.6.0's static checking.
7369
0766b489
PE
73702011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7371
31fd4b32
PE
7372 Integer overflow and signedness fixes (Bug#8873).
7373 A few related buffer overrun fixes, too.
7374
b79e8648
PE
7375 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7376
0766b489
PE
7377 * dispextern.h (struct face.stipple):
7378 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7379 (x_bitmap_mask, x_allocate_bitmap_record)
7380 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7381 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7382 (x_create_bitmap_from_xpm_data):
7383 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7384 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7385 (.bitmaps_last):
7386 * xfaces.c (load_pixmap):
7387 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7388 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7389 (.bitmaps_last, struct x_output.icon_bitmap):
7390 Use ptrdiff_t, not int, for bitmap indexes.
7391 (x_allocate_bitmap_record): Check for size overflow.
7392 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7393
b081724f
PE
7394 Use ptrdiff_t, not int, for overlay counts.
7395 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7396 * editfns.c (overlays_around, get_pos_property):
7397 * textprop.c (get_char_property_and_overlay):
7398 * xdisp.c (next_overlay_change, note_mouse_highlight):
7399 * xfaces.c (face_at_buffer_position):
21514da7
PE
7400 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7401 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7402 (Fnext_overlay_change, Fprevious_overlay_change)
7403 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7404 Use ptrdiff_t, not int, for sizes.
21514da7 7405 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7406
3de73e5e
PE
7407 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7408
2606c57b
PE
7409 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7410 (x_session_initialize): Do not assume string length fits in int.
7411
aaafe47a
PE
7412 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7413 This is unlikely, but can occur if DPI is outlandish.
7414
2674ddc8 7415 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7416 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7417
28154962
PE
7418 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7419 * xrdb.c (magic_file_p, search_magic_path):
7420 Omit last arg SUFFIX; it was always 0. All callers changed.
7421 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7422
7de51af5
PE
7423 * xfont.c (xfont_match): Avoid need for strlen.
7424
25ed6cc3
PE
7425 * xfns.c: Don't assume strlen fits in int.
7426 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7427
4eab31dd
PE
7428 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7429 not unsigned long, as we prefer signed integers. All callers changed.
7430 Detect integer overflow in repeat count.
7431 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7432 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7433
171e2a58
PE
7434 * termcap.c: Don't assume sizes fit in int and never overflow.
7435 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7436 (gobble_line): Check for size-calculation overflow.
7437
ad39faca 7438 * minibuf.c (Fread_buffer):
6e5bb2dc 7439 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7440 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7441 Don't assume string length fits in int.
7442
52c61c22 7443 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7444 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7445
b5b8c9e5
PE
7446 * font.c: Don't assume string length fits in int.
7447 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7448 Use ptrdiff_t, not int.
ccd6111c
PE
7449 (font_intern_prop): Don't assume string length fits in int.
7450 Don't assume integer property fits in fixnum.
7451 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7452
882f0d81 7453 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7454 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7455 Reformulate so as not to need the command string.
7456 Invoke gzip -cd rather than gunzip, as it's more portable.
7457 (lock_info_type, lock_file_1, lock_file):
7458 Don't assume pid_t and time_t fit in unsigned long.
7459 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7460 (current_lock_owner): Prefer signed type for sizes.
7461 Use memcpy, not strncpy, where memcpy is what is really wanted.
7462 Don't assume (via atoi) that time_t and pid_t fit in int.
7463 Check for time_t and/or pid_t out of range, e.g., via a network share.
7464 Don't alloca where an auto var works fine.
7465
93f4cf88
PE
7466 * fileio.c: Fix some integer overflow issues.
7467 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7468 Don't assume string length fits in int.
7469 (directory_file_name): Don't assume string length fits in long.
7470 (make_temp_name): Don't assume pid fits in int, or that its print
7471 length is less than 20.
7472
f3e92b69
PE
7473 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7474
1bfdaf10
PE
7475 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7476
35016e9a
PE
7477 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7478
3d1e65a1
PE
7479 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7480 We prefer signed integers, even for size calculations.
7481
0b963a93
PE
7482 * emacs.c: Don't assume string length fits in 'int'.
7483 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7484 (main): Don't invoke strlen when not needed.
7485
573f4b54
PE
7486 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7487 (XD_DEBUG_MESSAGE): Don't waste a byte.
7488
989f33ba
PE
7489 * callproc.c (getenv_internal_1, getenv_internal)
7490 (Fgetenv_internal):
965d34eb
PE
7491 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7492
e4d29b33
PE
7493 * lread.c (invalid_syntax): Omit length argument.
7494 All uses changed. This doesn't fix a bug, but it simplifies the
7495 code away from its former Hollerith-constant appearance, and it's
7496 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7497 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7498
eb49b136
PE
7499 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7500 This didn't break anything, but it didn't help either.
7501 It's confusing to put a bogus integer in a place where the actual
7502 value does not matter.
9f62aeb1 7503 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7504 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7505
15375a22
PE
7506 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7507 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7508 implementation.
b61cc01c
PE
7509 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7510 We prefer signed types, and the value cannot exceed the EMACS_INT
7511 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7512 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7513 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7514 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7515
53b2623d
PE
7516 * indent.c (sane_tab_width): New function.
7517 (current_column, scan_for_column, Findent_to, position_indentation)
7518 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7519 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7520
51cab52b 7521 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7522
f2ed8a70
PE
7523 * lisp.h (lint_assume): New macro.
7524 * composite.c (composition_gstring_put_cache):
7525 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7526
abe80cc6
PE
7527 * editfns.c, insdel.c:
7528 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7529
b02c740e
PE
7530 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7531
ebc96716
PE
7532 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7533
b4e50fa0 7534 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7535 Use much-faster test for byte-length change.
311d5d7c 7536 Don't assume string byte-length fits in 'int'.
a4cf38e4 7537 Check that character arg fits in 'int'.
85461888 7538 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7539
c0c1ee9f
PE
7540 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7541
a498d7f4
PE
7542 * fns.c (concat): Catch string overflow earlier.
7543 Do not rely on integer wraparound.
7544
51cab52b
PE
7545 * dispextern.h (struct it.overlay_strings_charpos)
7546 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7547 * xdisp.c (forward_to_next_line_start)
7548 (back_to_previous_visible_line_start)
7549 (reseat_at_next_visible_line_start, next_element_from_buffer):
7550 Don't arbitrarily truncate the value of 'selective' to int.
7551
76031fad
PE
7552 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7553
5eb55db9
PE
7554 * composite.c: Don't truncate sizes to 'int'.
7555 (composition_gstring_p, composition_reseat_it)
7556 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7557 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7558 not EMACS_UINT, for indexes.
5eb55db9 7559
0703a717
PE
7560 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7561
d6202519
PE
7562 * buffer.c: Include <verify.h>.
7563 (struct sortvec.priority, struct sortstr.priority):
8961a454 7564 Now EMACS_INT, not int.
c20998a7 7565 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7566 (struct sortstr.size, record_overlay_string)
7567 (struct sortstrlist.size, struct sortlist.used):
7568 Don't truncate size to int.
7569 (record_overlay_string): Check for size-calculation overflow.
d6202519 7570 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7571
d5a19415
JM
75722011-06-22 Jim Meyering <meyering@redhat.com>
7573
029529ac 7574 Don't leak an XBM-image-sized buffer
d5a19415
JM
7575 * image.c (xbm_load): Free the image buffer after using it.
7576
a9041e6c
PE
75772011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7578
7579 Port to Sun C.
7580 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7581 that Sun C diagnosed.
7582 * fns.c (secure_hash): Fix pointer signedness issue.
7583 * intervals.c (static_offset_intervals): New function.
7584 (offset_intervals): Use it.
7585
7f3f739f
LL
75862011-06-21 Leo Liu <sdl.web@gmail.com>
7587
7588 * deps.mk (fns.o):
7589 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7590 sha512.h.
7591
7592 * fns.c (secure_hash): Rename from crypto_hash_function and change
7593 the first arg to accept symbols.
5b66d427 7594 (Fsecure_hash): New primitive.
7f3f739f
LL
7595 (syms_of_fns): New symbols.
7596
76147d94
DD
75972011-06-20 Deniz Dogan <deniz@dogan.se>
7598
7599 * process.c (Fset_process_buffer): Clarify return value in
7600 docstring.
7601
7d7d0045
CY
76022011-06-18 Chong Yidong <cyd@stupidchicken.com>
7603
7604 * dispnew.c (add_window_display_history): Use BVAR.
7605
7606 * xdisp.c (debug_method_add): Use BVAR.
7607 (check_window_end, dump_glyph_matrix, dump_glyph)
7608 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7609
7610 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7611 Likewise.
7612
7613 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7614 check till after the cache is created in init_frame_faces.
7615
ff2bc410
SM
76162011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7617
7618 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7619
28177add
PE
76202011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7621
dd3482fe
PE
7622 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7623 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7624 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7625
393d71f3 7626 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7627 * fileio.c (Finsert_file_contents):
7628 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7629 Remove the old (too-loose) buffer overflow checks.
7630 They weren't needed, since make_gap checks for buffer overflow.
7631 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7632 The old code merely checked for Emacs fixnum overflow, and relied
7633 on undefined (wraparound) behavior. The new code avoids undefined
7634 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7635
2e6813b0 7636 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7637 Tune. Don't use wider integers than needed. Don't use alloca.
7638 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7639
599a9e4f
PE
7640 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7641
99561444
PE
7642 * insdel.c, lisp.h (buffer_overflow): New function.
7643 (insert_from_buffer_1, replace_range, replace_range_2):
7644 * insdel.c (make_gap_larger):
7645 * editfns.c (Finsert_char):
7646 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7647
28177add
PE
7648 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7649
e69dafad
PE
76502011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7651
4baa020d 7652 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7653
b1c46f02
PE
7654 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7655 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7656
e69dafad
PE
7657 * fileio.c: Don't assume EMACS_INT fits in off_t.
7658 (emacs_lseek): New static function.
7659 (Finsert_file_contents, Fwrite_region): Use it.
7660 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7661
566684ea
PE
7662 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7663
e6966cd6
PE
7664 * fns.c: Don't overflow int when computing a list length.
7665 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7666 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7667 truncation on 64-bit hosts. Check for QUIT every
7668 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7669 faster and is responsive enough.
7670 (Flength): Report an error instead of overflowing an integer.
7671 (Fsafe_length): Return a float if the value is not representable
7672 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7673 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7674 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7675
dd0b0efb
PE
7676 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7677 (header_size, word_size): New constants.
7678 (allocate_vectorlike): Don't check size overflow here.
7679 (allocate_vector): Check it here instead, since this is the only
7680 caller of allocate_vectorlike that could cause overflow.
7681 Check that the new vector's length is representable as a fixnum.
7682
86fe5cfe
PE
7683 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7684 The previous code was bogus. For example, next_almost_prime (32)
7685 returned 39, which is undesirable as it is a multiple of 3; and
7686 next_almost_prime (24) returned 25, which is a multiple of 5 so
7687 why was the code bothering to check for multiples of 7?
7688
80e88859
PE
7689 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7690
4a2f0ad6
PE
7691 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7692
f66c7cf8
PE
7693 Variadic C functions now count arguments with ptrdiff_t.
7694 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7695 Back then I didn't know that the Emacs coding style prefers signed int.
7696 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7697 were being counted with int, which may truncate counts on 64-bit
7698 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7699 * lisp.h (struct Lisp_Subr.function.aMANY)
7700 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7701 Arg counts are now ptrdiff_t, not size_t.
7702 All variadic functions and their callers changed accordingly.
7703 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7704 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7705 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7706 * callint.c (Fcall_interactively): Check arg count for overflow,
7707 to avoid potential buffer overrun. Use signed char, not 'int',
7708 for 'varies' array, so that we needn't bother to check its size
7709 calculation for overflow.
7710 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7711 * eval.c (apply_lambda):
7712 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7713 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7714 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7715
a1759b76
PE
7716 * callint.c (Fcall_interactively): Don't use index var as event count.
7717
d96be9fc
PE
7718 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7719 * mem-limits.h (SIZE): Remove; no longer used.
7720
a690a978 7721 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7722
578c21e6
PE
7723 Remove unnecessary casts.
7724 * xterm.c (x_term_init):
7725 * xfns.c (x_set_border_pixel):
7726 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7727 These aren't needed now that we assume ANSI C.
7728
96f53c6c
PE
7729 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7730 It's more likely to cause problems (due to unsigned overflow)
7731 than to cure them.
7732
83c77d31
PE
7733 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7734
ee2079f1
PE
7735 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7736
6da65536
PE
7737 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7738
7147c4a4
PE
7739 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7740
193e32d9
PE
7741 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7742
e5533da6
PE
7743 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7744
9910e595
PE
7745 GLYPH_CODE_FACE returns EMACS_INT, not int.
7746 * dispextern.h (merge_faces):
7747 * xfaces.c (merge_faces):
01103c44
PE
7748 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7749 Don't assume EMACS_INT fits in int.
9910e595 7750
2638320e
PE
7751 * character.h (CHAR_VALID_P): Remove unused parameter.
7752 * fontset.c, lisp.h, xdisp.c: All uses changed.
7753
045eb8d9
PE
7754 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7755
c1f134b5
PE
7756 * fns.c (concat): Minor tuning based on overflow analysis.
7757 This doesn't fix any bugs. Use int to hold character, instead
7758 of constantly refetching from Emacs object. Use XFASTINT, not
7759 XINT, for value known to be a character. Don't bother comparing
7760 a single byte to 0400, as it's always less.
7761
395fcb93 7762 * floatfns.c (Fexpt):
327eeec8
PE
7763 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7764
abbd3d23
PE
7765 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7766 for characters.
7767
684a03ef
PE
7768 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7769
0fed43f3
PE
7770 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7771 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7772 incorrectly succeed when S was a string, because 4294967386 was
7773 truncated before it was used.
7774
8fd02eb7
PE
7775 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7776 Otherwise, an out-of-range integer could cause undefined behavior
7777 on a 64-bit host.
7778
f8c86b69
PE
7779 * composite.c: Use int, not EMACS_INT, for characters.
7780 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7781 EMACS_INT, for values that are known to be in character range.
7782 This doesn't fix any bugs but is the usual style inside Emacs and
7783 may generate better code on 32-bit machines.
7784
34206dd2
PE
7785 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7786 This is for reasons similar to the recent CHAR_STRING fix.
7787 * charset.c (Fencode_char): Check that character arg is actually
7788 a character. Pass an int to ENCODE_CHAR.
7789 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7790 wider than 'int', as a compile-time check to prevent future regressions
7791 in this area.
7792
c5958d4c 7793 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7794
7795 Make sure a 64-bit char is never passed to CHAR_STRING.
7796 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7797 by silently ignoring the top 32 bits, allowing some values
7798 that were far too large to be valid characters.
7799 * character.h: Include <verify.h>.
7800 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7801 arguments are no wider than unsigned, as a compile-time check
7802 to prevent future regressions in this area.
7803 * data.c (Faset):
01103c44 7804 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7805 (Fsubst_char_in_region):
7806 * fns.c (concat):
7807 * xdisp.c (decode_mode_spec_coding):
7808 Adjust to CHAR_STRING's new requirement.
7809 * editfns.c (Finsert_char, Fsubst_char_in_region):
7810 * fns.c (concat): Check that character args are actually
7811 characters. Without this test, these functions did the wrong
7812 thing with wildly out-of-range values on 64-bit hosts.
7813
d37ca623
PE
7814 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7815 These casts should not be needed on 32-bit hosts, either.
7816 * keyboard.c (read_char):
7817 * lread.c (Fload): Remove casts to unsigned.
7818
ea204efb
PE
7819 * lisp.h (UNSIGNED_CMP): New macro.
7820 This fixes comparison bugs on 64-bit hosts.
7821 (ASCII_CHAR_P): Use it.
7822 * casefiddle.c (casify_object):
01103c44 7823 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7824 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7825 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7826 * dispextern.h (FACE_FROM_ID):
7827 * keyboard.c (read_char): Use UNSIGNED_CMP.
7828
41cb286c
PE
7829 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7830 not to EMACS_INT, to avoid GCC warning.
7831
4a1b9832
PE
7832 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7833
55daad71
PE
7834 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7835 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7836 isn't needed on 32-bit machines.
8f95c75c 7837
01103c44
PE
7838 * buffer.c (Fgenerate_new_buffer_name):
7839 Use EMACS_INT for count, not int.
0ceccced 7840 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7841
7842 * data.c (Qcompiled_function): Now static.
7843
c6f072e7
PE
7844 * window.c (window_body_lines): Now static.
7845
20ce5912
PE
7846 * image.c (gif_load): Rename local to avoid shadowing.
7847
9c4c5f81
PE
7848 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7849 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7850 * alloc.c (make_save_value): Integer argument is now of type
7851 ptrdiff_t, not int.
7852 (mark_object): Use ptrdiff_t, not int.
7853 * lisp.h (pD): New macro.
7854 * print.c (print_object): Use it.
7855
c0c5c8ae
PE
7856 * alloc.c: Use EMACS_INT, not int, to count objects.
7857 (total_conses, total_markers, total_symbols, total_vector_size)
7858 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7859 (total_free_floats, total_floats, total_free_intervals)
7860 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7861 Now EMACS_INT, not int. All uses changed.
7862 (Fgarbage_collect): Compute overall total using a double, so that
7863 integer overflow is less likely to be a problem. Check for overflow
7864 when converting back to an integer.
5a25e253
PE
7865 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7866 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7867 These were 'int' variables that could overflow on 64-bit hosts;
7868 they were never used, so remove them instead of repairing them.
211a0b2a 7869 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7870 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7871 Previously, this ceilinged at INT_MAX, but that doesn't work on
7872 64-bit machines.
e46bb31a 7873 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7874
c78baabf 7875 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7876 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7877 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7878 when a (possibly-narrower) signed value would do just as well.
7879 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7880
c9d624c6
PE
7881 * alloc.c: Catch some string size overflows that we were missing.
7882 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7883 for convenience in STRING_BYTES_MAX.
7884 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7885 The definition here is exact; the one in lisp.h was approximate.
7886 (allocate_string_data): Check for string overflow. This catches
7887 some instances we weren't catching before. Also, it catches
7888 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7889 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7890 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7891
c9d624c6
PE
7892 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7893 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7894 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7895
353032ce
PE
7896 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7897
2bccce07
PE
7898 * alloc.c (Fmake_string): Check for out-of-range init.
7899
0ac30604
SM
79002011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7901
7902 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7903
c195f2de
JD
79042011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7905
7906 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7907 xg_get_default_scrollbar_width.
7908
7909 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7910 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7911 (style_changed_cb): Call update_theme_scrollbar_width and call
7912 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7913 all frames (Bug#8505).
7914 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7915 Call gtk_window_set_resizable if HAVE_GTK3.
7916 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7917 and height if HAVE_GTK3 (Bug#8505).
7918 (scroll_bar_width_for_theme): New variable.
7919 (update_theme_scrollbar_width): New function.
7920 (xg_get_default_scrollbar_width): Move code to
7921 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7922 (xg_initialize): Call update_theme_scrollbar_width.
7923
7924 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7925
7926 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7927
e10ac9f1
MR
79282011-06-12 Martin Rudalics <rudalics@gmx.at>
7929
7930 * frame.c (make_frame): Call other_buffer_safely instead of
7931 other_buffer.
7932
7933 * window.c (temp_output_buffer_show): Call display_buffer with
7934 second argument Vtemp_buffer_show_specifiers and reset latter
7935 immediately after the call.
7936 (Vtemp_buffer_show_specifiers): New variable.
7937 (auto_window_vscroll_p, next_screen_context_lines)
7938 (Vscroll_preserve_screen_position): Remove leading asterisks from
7939 doc-strings.
7940
2d3c217e 79412011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7942
7b7f97e8 7943 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7944 * buffer.c (Qclone_number): Remove for now, as it's unused.
7945 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7946 (record_buffer): Remove unused local.
7947 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7948 (set_frame_buffer_list): Remove; unused.
7949 * frame.h (other_visible_frames): Remove decl.
7950 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7951 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7952 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7953 if HAVE_GPM.
7954 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7955 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7956 Define only if HAVE_GPM.
7957 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7958 (update_hints_inhibit): Remove; never set. All uses removed.
7959 * widgetprv.h (emacsFrameClassRec): Remove decl.
7960 * window.c (delete_deletable_window): Now returns void, since it
7961 wasn't returning anything.
7962 (compare_window_configurations): Remove unused locals.
7963 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7964 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7965 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7966 the same widths as pointers. This follows up on the 2011-05-06 patch.
7967 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7968 * xterm.h: Likewise.
7969 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7970
1384b89e
JB
79712011-06-12 Juanma Barranquero <lekktu@gmail.com>
7972
7973 * makefile.w32-in: Update dependencies.
7974 (LISP_H): Add lib/intprops.h.
7975
1100a63c
CY
79762011-06-11 Chong Yidong <cyd@stupidchicken.com>
7977
7978 * image.c (gif_load): Add animation frame delay to the metadata.
7979 (syms_of_image): Use DEFSYM. New symbol `delay'.
7980
6198ccd0
MR
79812011-06-11 Martin Rudalics <rudalics@gmx.at>
7982
7983 * window.c (delete_deletable_window): Re-add.
7984 (Fset_window_configuration): Rewrite to handle dead buffers and
7985 consequently deletable windows.
7986 (window_tree, Fwindow_tree): Remove. Supply functionality in
7987 window.el.
7988 (compare_window_configurations): Simplify code.
7989
b6e3633c
AS
79902011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7991
1ab0dee5
AS
7992 * image.c (imagemagick_load_image): Fix type mismatch.
7993 (Fimagemagick_types): Likewise.
7994
b6e3633c
AS
7995 * window.h (replace_buffer_in_windows): Declare.
7996
9397e56f
MR
79972011-06-11 Martin Rudalics <rudalics@gmx.at>
7998
7999 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8000 Qclone_number. Remove external declaration of Qdelete_window.
8001 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8002 code.
640c8776
SM
8003 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8004 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8005 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8006 buffer list implementation.
8007 (other_buffer_safely): New function.
8008 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8009 calls to replace_buffer_in_windows and
8010 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8011 if allowed.
8012 (record_buffer): Inhibit quitting and rewrite using quittable
8013 functions. Run Qbuffer_list_update_hook if allowed.
8014 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8015 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8016 Move switch-to-buffer to window.el.
9397e56f
MR
8017 (bury-buffer): Move to window.el.
8018 (Vbuffer_list_update_hook): New variable.
8019
8020 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8021 section.
8022
8023 * window.h (resize_frame_windows): Move up in code.
8024 (Fwindow_frame): Remove EXFUN.
8025 (replace_buffer_in_all_windows): Remove prototype.
8026 (replace_buffer_in_windows_safely): Add prototype.
8027
8028 * window.c: Declare Qdelete_window static again. Move down
8029 declaration of select_count.
8030 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8031 (Fother_window): Move to window.el.
8032 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8033 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8034 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8035 window.el.
8036 (replace_buffer_in_windows): Implement by calling
8037 Qreplace_buffer_in_windows.
8038 (replace_buffer_in_all_windows): Remove with some functionality
8039 moved into replace_buffer_in_windows_safely.
8040 (replace_buffer_in_windows_safely): New function.
8041 (select_window_norecord, select_frame_norecord): Move in front
8042 of run_window_configuration_change_hook. Remove now obsolete
8043 declarations.
640c8776
SM
8044 (Fset_window_buffer): Rewrite doc-string.
8045 Call Qrecord_window_buffer.
9397e56f
MR
8046 (keys_of_window): Move binding for other-window to window.el.
8047
b50691aa
CY
80482011-06-11 Chong Yidong <cyd@stupidchicken.com>
8049
8050 * dispextern.h (struct image): Replace data member, whose int_val
8051 and ptr_val fields were not used by anything, with a single
8052 lisp_val object.
8053
8054 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8055 (gif_clear_image, gif_load, imagemagick_load_image)
8056 (gs_clear_image, gs_load): Callers changed.
8057
3f754b86
PE
80582011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8059
cca69397
PE
8060 * buffer.h: Include <time.h>, for time_t.
8061 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8062
109e28d0
PE
8063 Fix minor problems found by static checking.
8064
60737f02
PE
8065 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8066
4b66faf3
PE
8067 Make identifiers static if they are not used in other modules.
8068 * data.c (Qcompiled_function, Qframe, Qvector):
8069 * image.c (QimageMagick, Qsvg):
8070 * minibuf.c (Qmetadata):
8071 * window.c (resize_window_check, resize_root_window): Now static.
8072 * window.h (resize_window_check, resize_root_window): Remove decls.
8073
109e28d0
PE
8074 * window.c (window_deletion_count, delete_deletable_window):
8075 Remove; unused.
46a4ce9e
PE
8076 (window_body_lines): Now static.
8077 (Fdelete_other_windows_internal): Mark vars as initialized.
8078 Make sure 'resize_failed' is initialized.
8079 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8080 (resize_window_apply): Remove unused local.
8081 * window.h (delete_deletable_window): Remove decl.
8082
109e28d0 8083 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8084 (imagemagick_load_image): Fix pointer signedness problem by changing
8085 last arg from unsigned char * to char *. All uses changed.
8086 Also, fix a local for similar reasons.
8087 Remove unused locals. Remove locals to avoid shadowing.
8088 (fn_rsvg_handle_free): Remove; unused.
8089 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8090 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8091
3f754b86
PE
8092 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8093
2547adb1
CY
80942011-06-10 Chong Yidong <cyd@stupidchicken.com>
8095
8096 * image.c (gif_load): Fix omitted cast error introduced by
8097 2011-06-06 change.
8098
2c8e37d4
MR
80992011-06-10 Martin Rudalics <rudalics@gmx.at>
8100
8101 * window.h (resize_proportionally, orig_total_lines)
8102 (orig_top_line): Remove from window structure.
8103 (set_window_height, set_window_width, change_window_heights)
8104 (Fdelete_window): Remove prototypes.
8105 (resize_frame_windows): Remove duplicate declaration.
8106
440a42e3
EZ
81072011-06-10 Eli Zaretskii <eliz@gnu.org>
8108
8109 * window.h (resize_frame_windows, resize_window_check)
8110 (delete_deletable_window, resize_root_window)
8111 (resize_frame_windows): Declare prototypes.
8112
8113 * window.c (resize_window_apply): Make definition be "static" to
8114 match the prototype.
8115
562dd5e9
MR
81162011-06-10 Martin Rudalics <rudalics@gmx.at>
8117
8118 * window.c: Remove declarations of Qwindow_size_fixed,
8119 window_min_size_1, window_min_size_2, window_min_size,
8120 size_window, window_fixed_size_p, enlarge_window, delete_window.
8121 Remove static from declaration of Qdelete_window, it's
8122 temporarily needed by Fbury_buffer.
8123 (replace_window): Don't assign orig_top_line and
8124 orig_total_lines.
8125 (Fdelete_window, delete_window): Remove. Window deletion is
8126 handled by window.el.
640c8776
SM
8127 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8128 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8129 (Fdelete_other_windows): Remove. Deleting other windows is
8130 handled by window.el.
8131 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8132 handled in window.el.
8133 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8134 Window minimum sizes are handled in window.el.
8135 (shrink_windows, size_window, set_window_height)
8136 (set_window_width, change_window_heights, window_height)
8137 (window_width, CURBEG, CURSIZE, enlarge_window)
8138 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8139 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8140 handled in window.el.
8141 (make_dummy_parent): Rename to make_parent_window and give it a
8142 second argument horflag.
8143 (make_window): Don't set resize_proportionally any more.
8144 (Fsplit_window): Remove. Windows are split in window.el.
8145 (save_restore_action, save_restore_orig_size)
8146 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8147 Resize mini windows in window.el.
8148 (grow_mini_window, shrink_mini_window): Implement by calling
8149 Qresize_root_window_vertically, resize_window_check and
8150 resize_window_apply.
640c8776
SM
8151 (saved_window, Fset_window_configuration, save_window_save):
8152 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8153 resize_proportionally.
8154 (window_min_height, window_min_width): Move to window.el.
8155 (keys_of_window): Move bindings for delete-other-windows,
8156 split-window, delete-window and enlarge-window to window.el.
8157
8158 * buffer.c: Temporarily extern Qdelete_window.
8159 (Fbury_buffer): Temporarily call Qdelete_window instead of
8160 Fdelete_window (Fbury_buffer will move to window.el soon).
8161
8162 * frame.c (set_menu_bar_lines_1): Remove code handling
8163 orig_top_line and orig_total_lines.
8164
8165 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8166 set_window_height but set heights directly.
8167 (change_frame_size_1): Use resize_frame_windows.
8168
8169 * xdisp.c (init_xdisp): Don't use set_window_height but set
8170 heights directly.
8171
640c8776
SM
8172 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8173 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8174 run_window_configuration_change_hook.
8175
8176 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8177 instead of change_window_heights and run
8178 run_window_configuration_change_hook.
8179
1a13852e
MR
81802011-06-09 Martin Rudalics <rudalics@gmx.at>
8181
8182 * window.c (replace_window): Rename second argument REPLACEMENT to
8183 NEW. New third argument SETFLAG. Rewrite.
8184 (delete_window, make_dummy_parent): Call replace_window with
8185 third argument 1.
8186 (window_list_1): Move down in code.
8187 (run_window_configuration_change_hook): Move set_buffer part
8188 before select_frame_norecord part in order to unwind correctly.
8189 Rename count1 to count.
8190 (recombine_windows, delete_deletable_window, resize_root_window)
8191 (Fdelete_other_windows_internal)
8192 (Frun_window_configuration_change_hook, make_parent_window)
8193 (resize_window_check, resize_window_apply, Fresize_window_apply)
8194 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8195 (Fdelete_window_internal, Fresize_mini_window_internal):
8196 New functions.
1a13852e
MR
8197 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8198
f3d1777e
MR
81992011-06-08 Martin Rudalics <rudalics@gmx.at>
8200
496e208e
MR
8201 * window.h (window): Add some new members to window structure -
8202 normal_lines, normal_cols, new_total, new_normal, clone_number,
8203 splits, nest, prev_buffers, next_buffers.
8204 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8205 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8206
f3d1777e
MR
8207 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8208 Remove.
496e208e
MR
8209 (make_dummy_parent): Set new members of windows structure.
8210 (make_window): Move down in code. Handle new members of window
8211 structure.
8212 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8213 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8214 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8215 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8216 (Fset_window_next_buffers, Fset_window_clone_number):
8217 New functions.
496e208e
MR
8218 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8219 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8220 Doc-string fixes.
8221 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8222 Argument WINDOW can be now internal window too.
8223 (Fwindow_use_time): Move up in code.
8224 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8225 Rewrite doc-string.
8226 (Fset_window_configuration, saved_window)
8227 (Fcurrent_window_configuration, save_window_save): Handle new
8228 members of window structure.
b9e809c2
MR
8229 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8230 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8231 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8232 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8233 Qget_mru_window, Qresize_root_window,
8234 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8235 Qauto_buffer_name; staticpro them.
f3d1777e 8236
abde8f8c
MR
82372011-06-07 Martin Rudalics <rudalics@gmx.at>
8238
8239 * window.c (Fwindow_total_size, Fwindow_left_column)
8240 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8241 (Fwindow_list_1): New functions.
8242 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8243 (Fwindow_width, Fscroll_left, Fscroll_right):
8244 Use window_body_cols instead of window_box_text_cols.
8245 (delete_window, Fset_window_configuration):
8246 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8247 (delete_all_subwindows): Take a window as argument and not a
8248 structure. Rewrite.
190b47e6
MR
8249 (window_loop): Remove handling of GET_LRU_WINDOW and
8250 GET_LARGEST_WINDOW.
8251 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8252
8253 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8254 window_box_text_cols. delete_all_subwindows now takes a
8255 Lisp_Object as argument.
abde8f8c 8256
640c8776
SM
8257 * indent.c (compute_motion, Fcompute_motion):
8258 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8259
fa8a67e6
MR
8260 * frame.c (delete_frame): Call delete_all_subwindows with root
8261 window as argument.
8262
a54e3482
DC
82632011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8264
8265 * fns.c (Fputhash): Document return value.
8266
60002bf5
CY
82672011-06-06 Chong Yidong <cyd@stupidchicken.com>
8268
8269 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8270
0c671da6 82712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8272
b862a52a 8273 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8274
be44ca6c
PE
8275 Check for overflow when converting integer to cons and back.
8276 * charset.c (Fdefine_charset_internal, Fdecode_char):
8277 Use cons_to_unsigned to catch overflow.
8278 (Fencode_char): Use INTEGER_TO_CONS.
8279 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8280 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8281 * data.c (long_to_cons, cons_to_long): Remove.
8282 (cons_to_unsigned, cons_to_signed): New functions.
8283 These signal an error for invalid or out-of-range values.
8284 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8285 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8286 * font.c (Ffont_variation_glyphs):
8287 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8288 * lisp.h: Include <intprops.h>.
8289 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8290 (cons_to_signed, cons_to_unsigned): New decls.
8291 (long_to_cons, cons_to_long): Remove decls.
8292 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8293 (Fprimitive_undo): Use CONS_TO_INTEGER.
8294 * xfns.c (Fx_window_property): Likewise.
8295 * xselect.c: Include <limits.h>.
8296 (x_own_selection, selection_data_to_lisp_data):
8297 Use INTEGER_TO_CONS.
8298 (x_handle_selection_request, x_handle_selection_clear)
8299 (x_get_foreign_selection, Fx_disown_selection_internal)
8300 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8301 (lisp_data_to_selection_data): Use cons_to_unsigned.
8302 (x_fill_property_data): Use cons_to_signed.
8303 Report values out of range.
8304
d1f3d2af
PE
8305 Check for buffer and string overflow more precisely.
8306 * buffer.h (BUF_BYTES_MAX): New macro.
8307 * lisp.h (STRING_BYTES_MAX): New macro.
8308 * alloc.c (Fmake_string):
8309 * character.c (string_escape_byte8):
8310 * coding.c (coding_alloc_by_realloc):
8311 * doprnt.c (doprnt):
8312 * editfns.c (Fformat):
8313 * eval.c (verror):
8314 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8315 since they may not be the same number.
8316 * editfns.c (Finsert_char):
8317 * fileio.c (Finsert_file_contents):
8318 Likewise for BUF_BYTES_MAX.
8319
dd52fcea
PE
8320 * image.c: Use ptrdiff_t, not int, for sizes.
8321 (slurp_file): Switch from int to ptrdiff_t.
8322 All uses changed.
8323 (slurp_file): Check that file size fits in both size_t (for
8324 malloc) and ptrdiff_t (for sanity and safety).
8325
7f9bbdbb
PE
8326 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8327 if b->modtime has its maximal value.
8328
dfe18f82
PE
8329 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8330
84acfcf0
PE
8331 Don't assume time_t can fit into int.
8332 * buffer.h (struct buffer.modtime): Now time_t, not int.
8333 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8334 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8335
ccd9a01a
PE
8336 Minor fixes for signed vs unsigned integers.
8337 * character.h (MAYBE_UNIFY_CHAR):
8338 * charset.c (maybe_unify_char):
8339 * keyboard.c (read_char, reorder_modifiers):
8340 XINT -> XFASTINT, since the integer must be nonnegative.
8341 * ftfont.c (ftfont_spec_pattern):
8342 * keymap.c (access_keymap, silly_event_symbol_error):
8343 XUINT -> XFASTINT, since the integer must be nonnegative.
8344 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8345 since it makes no difference and we prefer signed.
8346 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8347 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8348 nonnegative.
8349
d6d100dd
SM
83502011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8351
8352 * window.h (Fwindow_frame): Declare.
8353
2b6148e4
PE
83542011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8355
8356 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8357 (SPARE_MEMORY): Always define.
8358 (LARGE_REQUEST): Remove.
8359 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8360
f230ecc9
MR
83612011-06-06 Martin Rudalics <rudalics@gmx.at>
8362
727e958e
MR
8363 * lisp.h: Move EXFUNS for Fframe_root_window,
8364 Fframe_first_window and Fset_frame_selected_window to window.h.
8365
8366 * window.h: Move EXFUNS for Fframe_root_window,
8367 Fframe_first_window and Fset_frame_selected_window here from
8368 lisp.h.
8369
8370 * frame.c (Fwindow_frame, Fframe_first_window)
8371 (Fframe_root_window, Fframe_selected_window)
8372 (Fset_frame_selected_window): Move to window.c.
8373 (Factive_minibuffer_window): Move to minibuf.c.
8374 (Fother_visible_frames_p): New function.
8375
8376 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8377
f230ecc9
MR
8378 * window.c (decode_window, decode_any_window): Move up in code.
8379 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8380 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8381 (Fwindow_buffer): Move up and rewrite doc-string.
8382 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8383 (Fwindow_prev): New functions.
727e958e
MR
8384 (Fwindow_frame): Move here from frame.c. Accept any window as
8385 argument.
8386 (Fframe_root_window, Fframe_first_window)
8387 (Fframe_selected_window): Move here from frame.c. Accept frame
8388 or arbitrary window as argument. Update doc-strings.
8389 (Fminibuffer_window): Move up in code.
8390 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8391 (Fset_frame_selected_window): Move here from frame.c.
8392 Marginal rewrite.
727e958e
MR
8393 (Fselected_window, select_window, Fselect_window): Move up in
8394 code. Minor doc-string fixes.
f230ecc9 8395
4d09bcf6
PE
83962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8397
8398 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8399 Do not assume that spare memory exists; that assumption is valid
8400 only if SYSTEM_MALLOC.
8401 (LARGE_REQUEST): New macro, so that the issue of large requests
8402 is separated from the issue of spare memory.
8403
810928a2
AS
84042011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8405
172418ad
AS
8406 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8407 format. (Bug#8806)
8408
43f862f7
AS
8409 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8410
810928a2
AS
8411 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8412 before statements.
8413
a059fe24
JD
84142011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8415
8416 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8417
8418 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8419
8420 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8421 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8422
989bf368
JB
84232011-06-05 Juanma Barranquero <lekktu@gmail.com>
8424
8425 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8426
4b80f674
CY
84272011-06-04 Chong Yidong <cyd@stupidchicken.com>
8428
8429 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8430 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8431 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8432 New error handlers.
4b80f674
CY
8433 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8434 Obey Vx_select_enable_clipboard_manager. Catch errors in
8435 x_clipboard_manager_save (Bug#8779).
8436 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8437 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8438
99a33b77 84392011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8440
8441 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8442
99a33b77 84432011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8444
8445 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8446 in the current matrix if keep_current_p is non-zero.
8447
8264569d
EZ
84482011-06-04 Eli Zaretskii <eliz@gnu.org>
8449
8450 * bidi.c (bidi_level_of_next_char): Fix last change.
8451
57f97249
EZ
84522011-06-03 Eli Zaretskii <eliz@gnu.org>
8453
fec2107c 8454 Support bidi reordering of text covered by display properties.
57f97249 8455
fec2107c
EZ
8456 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8457 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8458 (bidi_cache_search, bidi_cache_iterator_state)
8459 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8460 (bidi_level_of_next_char, bidi_move_to_visually_next):
8461 Support character positions inside a run of characters covered by a
fec2107c
EZ
8462 display string.
8463 (bidi_paragraph_init, bidi_resolve_explicit_1)
8464 (bidi_level_of_next_char): Call bidi_fetch_char and
8465 bidi_fetch_char_advance instead of FETCH_CHAR and
8466 FETCH_CHAR_ADVANCE.
8467 (bidi_init_it): Initialize new members.
8468 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8469 definitions.
8470 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8471 instead of using explicit *_CHAR codes.
d6d100dd
SM
8472 (bidi_resolve_explicit, bidi_resolve_weak):
8473 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8474 bidirectional text is supported only in multibyte buffers.
8475 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8476 it to initialize the frame_window_p member of struct bidi_it.
8477 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8478 (bidi_resolve_explicit, bidi_resolve_weak)
8479 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8480 bidi_it->nchars is non-positive.
8481 (bidi_level_of_next_char): Don't try to lookup the cache for the
8482 next/previous character if nothing is cached there yet, or if we
8483 were just reseat()'ed to a new position.
c40e2fb2 8484
0e14fe90
EZ
8485 * xdisp.c (set_cursor_from_row): Set start and stop points
8486 according to the row's direction when priming the loop that looks
8487 for the glyph on which to display cursor.
8488 (single_display_spec_intangible_p): Function deleted.
8489 (display_prop_intangible_p): Reimplement to call
8490 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8491 Accept 3 additional arguments needed by handle_display_spec.
8492 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8493 values: lists, `(when COND...)' forms, etc.
8494 (single_display_spec_string_p): Support property values that are
8495 lists with the argument STRING its top-level element.
8496 (display_prop_string_p): Fix the condition for processing a
8497 property that is a list to be consistent with handle_display_spec.
fec2107c 8498 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8499 last portion of handle_display_prop.
8500 (compute_display_string_pos): Accept additional argument
8501 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8502 value of a `display' property is a "replacing spec".
8503 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8504 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8505 the display property, but just return a value indicating whether
8506 the display property will replace the characters it covers.
8507 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8508 frame_window_p members of struct bidi_it.
d6d100dd
SM
8509 (compute_display_string_pos, compute_display_string_end):
8510 New functions.
fec2107c
EZ
8511 (push_it): Accept second argument POSITION, where pop_it should
8512 jump to continue iteration.
8513 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8514
fec2107c
EZ
8515 * keyboard.c (adjust_point_for_property): Adjust the call to
8516 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8517
8518 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8519 (bidi_init_it): Update prototypes.
8520 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8521 (compute_display_string_pos, compute_display_string_end):
8522 Declare prototypes.
fec2107c
EZ
8523 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8524 EMACS_INT.
fc6f18ce 8525
40087514 85262011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8527
57f53182
PE
8528 Malloc failure behavior now depends on size of allocation.
8529 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8530 * lisp.h: Change signatures accordingly.
8531 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8532 All callers changed. (Bug#8762)
8533
8534 * gnutls.c: Use Emacs's memory allocators.
8535 Without this change, the gnutls library would invoke malloc etc.
8536 directly, which causes problems on non-SYNC_INPUT hosts, and which
8537 runs afoul of improving memory_full behavior. (Bug#8761)
8538 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8539 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8540 xfree instead of the default malloc, realloc, free.
8541 (Fgnutls_boot): No need to check for memory allocation failure,
8542 since xmalloc does that for us.
8543
ac32cd99 8544 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8545 * category.c (hash_get_category_set):
8546 * ccl.c (ccl_driver):
8547 * charset.c (Fdefine_charset_internal):
8548 * charset.h (struct charset.hash_index):
8549 * composite.c (get_composition_id, gstring_lookup_cache)
8550 (composition_gstring_put_cache):
8551 * composite.h (struct composition.hash_index):
8552 * dispextern.h (struct image.hash):
8553 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8554 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8555 (hashfn_equal, hashfn_user_defined, make_hash_table)
8556 (maybe_resize_hash_table, hash_lookup, hash_put)
8557 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8558 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8559 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8560 * image.c (make_image, search_image_cache, lookup_image)
8561 (xpm_put_color_table_h):
8562 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8563 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8564 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8565 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8566 * alloc.c (allocate_vectorlike):
8567 Check for overflow in vector size calculations.
8568 * ccl.c (ccl_driver):
8569 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8570 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8571 need to be updated by these changes.
40087514
PE
8572 * fns.c (make_hash_table, maybe_resize_hash_table):
8573 Check for integer overflow with large hash tables.
0de4bb68
PE
8574 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8575 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8576 (SXHASH_REDUCE): New macro.
8577 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8578 Use it instead of discarding useful hash info with large hash values.
8579 (sxhash_float): New function.
8580 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8581 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8582 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8583 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8584 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8585 Adjust signatures to match updated version of code.
8586 (consing_since_gc): Now EMACS_INT, since a single hash table can
8587 use more than INT_MAX bytes.
8588
698d32e2
DN
85892011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8590
8591 Make it possible to build with GCC-4.6+ -O2 -flto.
8592
8593 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8594
fd6fa53f
SM
85952011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8596
8597 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8598 Call minibuffer-inactive-mode.
8599
864db017
JB
86002011-05-31 Juanma Barranquero <lekktu@gmail.com>
8601
8602 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8603 Update dependencies.
8604
2ad0baf4
DN
86052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8606
8607 * data.c (init_data): Remove code for UTS, this system is not
8608 supported anymore.
8609
4fcc2638
DN
86102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8611
8612 Don't force ./temacs to start in terminal mode.
8613
8614 * frame.c (make_initial_frame): Initialize faces in all cases, not
8615 only when CANNOT_DUMP is defined.
8616 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8617
c56e0fd5
DN
86182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8619
8620 * dispnew.c (add_window_display_history): Use const for the string
8621 pointer. Remove declaration, not needed.
8622
333d54da 86232011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8624
55d4c1b2 8625 Use 'inline', not 'INLINE'.
333d54da 8626 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8627 * alloc.c, fontset.c (INLINE): Remove.
8628 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8629 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8630 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8631 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8632 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8633
738db178
DN
86342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8635
8636 Make it possible to run ./temacs.
8637
8638 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8639 syms_of_callproc does the same thing. Remove test for
8640 "initialized", do it in the caller.
8641 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8642
620c53a6
SM
86432011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8644
8645 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8646 (read_minibuf): Use get_minibuffer.
8647 (syms_of_minibuf): Use DEFSYM.
8648 (Qmetadata): New var.
8649 * data.c (Qbuffer): Don't make it static.
8650 (syms_of_data): Use DEFSYM.
8651
e003a292
PE
86522011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8653
8654 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8655 (CCL_CODE_MIN): New macro.
8656
ed008a6d
PE
86572011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8658
3687c2ef
PE
8659 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8660
ed008a6d
PE
8661 * eval.c (Qdebug): Now static.
8662 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8663 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8664 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8665
d66c4c7c
CY
86662011-05-29 Chong Yidong <cyd@stupidchicken.com>
8667
8668 * image.c: Various fixes to ImageMagick code comments.
8669 (Fimagemagick_types): Doc fix.
8670
5fbc2025
PE
86712011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8672
0196f88a
PE
8673 Minor fixes prompted by GCC 4.6.0 warnings.
8674
8675 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8676
5fbc2025
PE
8677 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8678 (x_clipboard_manager_save_all): Move extern decl to ...
8679 * xterm.h: ... here, so that it can be checked for consistency.
8680
1dd3c2d9
CY
86812011-05-29 Chong Yidong <cyd@stupidchicken.com>
8682
8683 * xselect.c (x_clipboard_manager_save_frame)
8684 (x_clipboard_manager_save_all): New functions.
8685 (Fx_clipboard_manager_save): Lisp function deleted.
8686
8687 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8688 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8689
8690 * xterm.h: Update prototype.
8691
5ba6571d
WX
86922011-05-28 William Xu <william.xwl@gmail.com>
8693
8694 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8695 exiting (Bug#8239).
8696
3eaff834
JM
86972011-05-28 Jim Meyering <meyering@redhat.com>
8698
e1900994 8699 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8700 * fns.c (to_uchar): Define.
8701 (crypto_hash_function): Use it to convert some newly-signed
8702 variables to unsigned, to avoid sign-extension bugs. For example,
8703 without this change, (md5 "truc") would evaluate to
8704 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8705 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8706 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8707
0f6990a7
PE
87082011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8709
8710 Integer overflow fixes.
c8a9ca5a 8711
08686060
PE
8712 * dbusbind.c: Serial number integer overflow fixes.
8713 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8714 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8715 to hold a serial number that is too large for a fixnum.
8716 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8717 Check for serial numbers out of range. Decode any serial number
59568bf0 8718 that was so large that it became a float. (Bug#8722)
08686060 8719
2d1fc3c7
PE
8720 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8721 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8722 Use XFASTINT rather than XUINT when numbers are nonnegative.
8723 (xd_append_arg, Fdbus_method_return_internal):
8724 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8725 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8726 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8727 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8728 (Bug#8722)
2d1fc3c7 8729
c8a9ca5a
PE
8730 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8731
519e1d69
PE
8732 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8733
6df6ae42 8734 ccl: Add integer overflow checks.
30569699
PE
8735 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8736 (IN_INT_RANGE): New macros.
8737 (ccl_driver): Use them to check for integer overflow when
8738 decoding a CCL program. Many of the new checks are whether XINT (x)
8739 fits in int; it doesn't always, on 64-bit hosts. The new version
8740 doesn't catch all possible integer overflows, but it's an
847044ea 8741 improvement. (Bug#8719)
30569699 8742
c11285dc
PE
8743 * alloc.c (make_event_array): Use XINT, not XUINT.
8744 There's no need for unsigned here.
8745
fdccd48e
PE
8746 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8747 This follows up to the 2011-05-06 change that substituted uintptr_t
8748 for EMACS_INT. This case wasn't caught back then.
8749
37910ab2
PE
8750 Rework Fformat to avoid integer overflow issues.
8751 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8752 now (part of C89). Include <verify.h>.
8753 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8754 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8755 (Fformat): Avoid the prepass trying to compute sizes; it was only
8756 approximate and thus did not catch overflow reliably. Instead, walk
8757 through the format just once, formatting and computing sizes as we go,
8758 checking for integer overflow at every step, and allocating a larger
8759 buffer as needed. Keep track separately whether the format is
8760 multibyte. Keep only the most-recently calculated precision, rather
8761 than them all. Record whether each argument has been converted to
8762 string. Use EMACS_INT, not int, for byte and char and arg counts.
8763 Support field widths and precisions larger than INT_MAX. Avoid
8764 sprintf's undefined behavior with conversion specifications such as %#d
8765 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8766 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8767 formatting out-of-range floating point numbers with int
9173deec 8768 formats. (Bug#8668)
37910ab2 8769
2e6578fb
PE
8770 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8771
0ae6bdee
PE
8772 * data.c: Avoid integer truncation in expressions involving floats.
8773 * data.c: Include <intprops.h>.
8774 (arith_driver): When there's an integer overflow in an expression
8775 involving floating point, convert the integers to floating point
8776 so that the resulting value does not suffer from catastrophic
8777 integer truncation. For example, on a 64-bit host (* 4
8778 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8779 Do not rely on undefined behavior after integer overflow.
8780
de883a70
PE
8781 merge count_size_as_multibyte, parse_str_to_multibyte
8782 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8783 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8784 Check for integer overflow.
8785 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8786 since it's now a duplicate of the other. This is more of
8787 a character than a buffer op, so better that it's in character.c.
8788 * fns.c, print.c: Adjust to above changes.
8789
2ff916cb
PE
87902011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8791
8792 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8793
f1b54466
PE
87942011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8795
fb1ac845
PE
8796 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8797 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8798 (x_clipboard_manager_save): Now static.
8799 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8800
f1b54466
PE
8801 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8802 (crypto_hash_function): Now static.
8803 Fix pointer signedness problems. Avoid unnecessary initializations.
8804
a9f737ee
CY
88052011-05-27 Chong Yidong <cyd@stupidchicken.com>
8806
8807 * termhooks.h (Vselection_alist): Make it terminal-local.
8808
8809 * terminal.c (create_terminal): Initialize it.
8810
8811 * xselect.c: Support for clipboard managers.
8812 (Vselection_alist): Move to termhooks.h as terminal-local var.
8813 (LOCAL_SELECTION): New macro.
8814 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8815 (symbol_to_x_atom): Remove gratuitous arg.
8816 (x_handle_selection_request, lisp_data_to_selection_data)
8817 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8818 (x_own_selection, x_get_local_selection, x_convert_selection):
8819 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8820 (some_frame_on_display): Delete unused function.
8821 (Fx_own_selection_internal, Fx_get_selection_internal)
8822 (Fx_disown_selection_internal, Fx_selection_owner_p)
8823 (Fx_selection_exists_p): New optional frame arg.
8824 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8825 (x_handle_selection_clear): Don't treat other terminals with the
8826 same keyboard specially. Use the terminal-local Vselection_alist.
8827 (x_clear_frame_selections): Use Frun_hook_with_args.
8828
8829 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8830
8831 * xterm.h: Add support for those atoms.
8832
e067f0c1
CY
88332011-05-26 Chong Yidong <cyd@stupidchicken.com>
8834
8835 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8836 (converted_selections, conversion_fail_tag): New global variables.
8837 (x_selection_request_lisp_error): Free the above.
8838 (x_get_local_selection): Remove unnecessary code.
8839 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8840 of converted selections stored in converted_selections.
8841 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8842 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8843 (x_convert_selection): New function.
8844 (x_handle_selection_event): Simplify.
8845 (x_get_foreign_selection): Don't ignore incoming requests while
8846 waiting for an answer; this will fail when we implement
8847 SAVE_TARGETS, and seems unnecessary anyway.
8848 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8849 (Vx_sent_selection_functions): Doc fix.
8850
0f4aebc0
LL
88512011-05-26 Leo Liu <sdl.web@gmail.com>
8852
8853 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8854
e61124cd
YM
88552011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8856
8857 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8858
8859 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8860 for fringe update if it has periodic bitmap.
ac389d0c 8861 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8862 and fringe_bitmap_periodic_p.
8863
8864 * fringe.c (get_fringe_bitmap_data): New function.
8865 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8866 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8867 row. Mark glyph row for fringe update if periodicity changed.
8868
8869 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8870 for fringe update unless it has periodic bitmap.
8871
f16d9837
KH
88722011-05-25 Kenichi Handa <handa@m17n.org>
8873
8874 * xdisp.c (get_next_display_element): Set correct it->face_id for
8875 a static composition.
8876
e1b90ef6
LL
88772011-05-24 Leo Liu <sdl.web@gmail.com>
8878
8879 * deps.mk (fns.o):
8880 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8881
8882 * fns.c (crypto_hash_function, Fsha1): New function.
8883 (Fmd5): Use crypto_hash_function.
8884 (syms_of_fns): Add Ssha1.
8885
7400048f
PE
88862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8887
8888 * gnutls.c: Remove unused macros.
8889 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8890 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8891 Remove macros that are defined and never used.
8892 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8893
abb71cf4
CY
88942011-05-22 Chong Yidong <cyd@stupidchicken.com>
8895
8896 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8897 (Fx_get_selection_internal): Minor cleanup.
8898 (Fx_own_selection_internal): Rename arguments for consistency with
8899 select.el.
8900
6307db39
PE
89012011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8902
8903 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8904
f3d4e0a4
CY
89052011-05-22 Chong Yidong <cyd@stupidchicken.com>
8906
8907 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8908
4d8ade89
YM
89092011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8910
8911 * dispnew.c (scrolling_window): Don't exclude the case that the
8912 last enabled row in the desired matrix touches the bottom boundary.
8913
32078c8d
GM
89142011-05-21 Glenn Morris <rgm@gnu.org>
8915
8916 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8917 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8918 and add some more files.
32078c8d 8919
7285dc67
EZ
89202011-05-20 Eli Zaretskii <eliz@gnu.org>
8921
8922 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8923 report_file_error introduced by the change from 2011-05-07.
8924
89d1bd22
PE
89252011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8926
8927 * systime.h (Time): Define only if emacs is defined.
8928 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8929 where the include path doesn't have X11/X.h by default. See
8930 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8931
cd394be1 89322011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8933
8934 * composite.c (find_automatic_composition): Fix previous change.
8935
b9704ad9
GM
89362011-05-20 Glenn Morris <rgm@gnu.org>
8937
8938 * lisp.mk: New file, split from Makefile.in.
8939 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8940 (shortlisp): Remove.
8941 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8942
4a720484
GM
89432011-05-19 Glenn Morris <rgm@gnu.org>
8944
8945 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8946 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8947 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8948 (lisp): Set the order to that of loadup.el.
8949 (shortlisp): Make it a copy of $lisp.
8950 (SOME_MACHINE_LISP): Remove.
8951 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8952 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8953
a28d4396
KH
89542011-05-18 Kenichi Handa <handa@m17n.org>
8955
8956 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8957 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8958 (find_automatic_composition): Mostly rewrite for efficiency.
8959
a2b1fa8e
JB
89602011-05-18 Juanma Barranquero <lekktu@gmail.com>
8961
8962 * makefile.w32-in: Update dependencies.
8963
8e1f5610
CS
89642011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8965
8966 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8967 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8968
7025ee00 89692011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8970
cdfa6eab
PE
8971 Fix some integer overflow issues, such as string length overflow.
8972
06d6db33
PE
8973 * insdel.c (count_size_as_multibyte): Check for string overflow.
8974
2b4560a8
PE
8975 * character.c (lisp_string_width): Check for string overflow.
8976 Use EMACS_INT, not int, for string indexes and lengths; in
8977 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8978 the resulting string length overflows an EMACS_INT; instead,
8979 report a string overflow if no precision given. When checking for
8980 precision exhaustion, use a check that cannot possibly have
8981 integer overflow. (Bug#8675)
8982 * character.h (lisp_string_width): Adjust to new signature.
8983
cb93f9be
PE
8984 * alloc.c (string_overflow): New function.
8985 (Fmake_string): Use it. This doesn't change behavior, but saves
8986 a few bytes and will simplify future changes.
8987 * character.c (string_escape_byte8): Likewise.
8988 * lisp.h (string_overflow): New decl.
8989
1a1f3366
PE
8990 Fixups, following up to the user-interface timestamp change.
8991 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8992 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8993 * msdos.c (mouse_get_pos): Likewise.
8994 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8995 * w32gui.h (Time): Define by including "systime.h" rather than by
8996 declaring it ourselves. (Bug#8664)
8997
d4e3e4d3
PE
8998 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8999 * image.c (clear_image_cache): Likewise.
9000
f6a24d19
PE
9001 * term.c (term_mouse_position): Don't assume time_t wraparound.
9002
08dc5ae6
PE
9003 Be more systematic about user-interface timestamps.
9004 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9005 and sometimes 'EMACS_UINT', to represent these timestamps.
9006 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9007 This makes the code easier to follow, and makes it easier to catch
9008 integer overflow bugs such as Bug#8664.
9009 * frame.c (Fmouse_position, Fmouse_pixel_position):
9010 Use Time, not unsigned long, for user-interface timestamps.
9011 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9012 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9013 * keyboard.h (last_event_timestamp): Likewise.
9014 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9015 * menu.h (xmenu_show): Likewise.
9016 * term.c (term_mouse_position): Likewise.
9017 * termhooks.h (struct input_event.timestamp): Likewise.
9018 (struct terminal.mouse_position_hook): Likewise.
9019 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9020 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9021 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9022 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9023 what it was before.
9024 * menu.h, termhooks.h: Include "systime.h", for Time.
9025
8e55734a
PE
9026 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9027 Don't assume that the difference between two unsigned long values
9028 can fit into an integer. At this point, we know button_down_time
9029 <= event->timestamp, so the difference must be nonnegative, so
9030 there's no need to cast the result if double-click-time is
9031 nonnegative, as it should be; check that it's nonnegative, just in
9032 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9033 apart (about 25 days). (Bug#8664)
8e55734a 9034
841f1b75 9035 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9036 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9037
3e26f69c
PE
9038 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9039 that always fit in int. Use a sentinel instead of a counter, to
9040 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9041 * frame.h (struct frame): Use int for menu_bar_items_used
9042 instead of EMACS_INT, since it always fits in int.
3e26f69c 9043
5cc152c0
PE
9044 * menu.c (grow_menu_items): Check for int overflow.
9045
d89eb65e
PE
9046 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9047
5235bd3e
PE
9048 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9049 Before, the code was not consistent. These values cannot exceed
9050 2**31 - 1 so there's no need to make them unsigned.
9051 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9052 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9053 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9054 as modifiers.
9055 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9056
bc827e23
PE
9057 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9058 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9059 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9060 presumably because the widths might not match.
9061
78eb494e
PE
9062 * window.c (size_window): Avoid needless test at loop start.
9063
04f2d78b
CB
90642011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9065
9066 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9067
d2fc7e3d 90682011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9069
9070 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9071
d2fc7e3d 90722011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9073
9074 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9075 `width' to `bar_area_x' and `bar_area_width', respectively.
9076 (x_scroll_run): Take account of fringe background extension.
9077
04f2d78b
CB
9078 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9079 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9080 `bar_area_width', respectively.
9081 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9082 background extension.
9083
79b70037
GM
90842011-05-10 Jim Meyering <meyering@redhat.com>
9085
9086 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9087
2f142cc5
JB
90882011-05-10 Juanma Barranquero <lekktu@gmail.com>
9089
9090 * image.c (Finit_image_library): Return t for built-in image types,
9091 like pbm and xbm. (Bug#8640)
9092
57679c86
AS
90932011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9094
9095 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9096
888c9e86
EZ
90972011-05-07 Eli Zaretskii <eliz@gnu.org>
9098
b0512a1d
EZ
9099 * w32console.c (Fset_screen_color): Doc fix.
9100 (Fget_screen_color): New function.
9101 (syms_of_ntterm): Defsubr it.
9102
7285dc67
EZ
9103 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9104 unlink the temporary file if Fcall_process didn't create it in the
9105 first place.
9106 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9107 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9108 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9109 cue to call_process_cleanup not to close that handle.
9110
4d3fcc8e
BK
91112011-05-07 Ben Key <bkey76@gmail.com>
9112
9113 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9114 one of two shell specific rules, either bootstrap-temacs-CMD or
9115 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9116 to the previous implementation of the bootstrap-temacs rule.
9117 The bootstrap-temacs-CMD rule is similar to the previous
9118 implementation of the bootstrap-temacs rule except that it
9119 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9120 variable.
9121
9122 These changes, along with some changes to nt/configure.bat,
9123 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9124 earlier fix to add support for --cflags and --ldflags options
9125 that include quotes so that it works whether make uses cmd or
9126 sh as the shell.
9127
b4289b64
MA
91282011-05-06 Michael Albinus <michael.albinus@gmx.de>
9129
9130 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9131 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9132 is a constant.
9133 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9134 a string. Handle both cases.
9135 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9136 (Fdbus_register_method): Use Qinvalid_function.
9137
af4c0e28
JB
91382011-05-06 Juanma Barranquero <lekktu@gmail.com>
9139
9140 * makefile.w32-in: Update dependencies.
9141 (LISP_H): Add inttypes.h and stdin.h.
9142 (PROCESS_H): Add unistd.h.
9143
c51453d9
EZ
91442011-05-06 Eli Zaretskii <eliz@gnu.org>
9145
9146 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9147 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9148
8ff0ac3c 91492011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9150
4c4b566b
PE
9151 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9152
aab2b9b5
PE
9153 * term.c (vfatal): Remove stray call to va_end.
9154 It's not needed and the C Standard doesn't allow it here anyway.
9155
c378da0b
PE
9156 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9157 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9158
288b08c7
PE
9159 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9160 bytes.
9161
e3601888
PE
9162 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9163
db6c0e74
PE
9164 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9165
dd5963ea
PE
9166 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9167
88c9450f
PE
9168 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9169
2f9442b8
PE
9170 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9171
c032b5f8
PE
9172 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9173 * charset.c (Fdefine_charset_internal): Don't initialize
9174 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9175 32-bit int (Bug#8600).
a108c10b
PE
9176
9177 * lread.c (read_integer): Be more consistent with string-to-number.
9178 Use string_to_number to do the actual conversion; this avoids
9179 rounding errors and fixes some other screwups. Without this fix,
9180 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9181 (digit_to_number): Move earlier, for benefit of read_integer.
9182 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9183 not a digit in any supported base. (Bug#8602)
a108c10b 9184
ad5f9eea
PE
9185 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9186
aec1708a
PE
9187 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9188 to match comment at start of function. This also removes a
9189 GCC warning about overflow in a 32+64-bit port.
9190
47be4ab5
PE
9191 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9192
371cac43
PE
9193 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9194 Reported by Stefan Monnier in
9195 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9196 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9197 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9198
d01a7826
PE
9199 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9200 (EMACS_UINTPTR): Likewise, with uintptr_t.
9201
7fd47d5c
PE
9202 * lisp.h: Prefer 64-bit EMACS_INT if available.
9203 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9204 on 32-bit hosts that have 64-bit int, so that they can access
9205 large files.
122b0c86
PE
9206 However, temporarily disable this change unless the temporary
9207 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9208
8727937b
PE
9209 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9210
8ac068ac
PE
9211 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9212 This removes an assumption that EMACS_INT and long are the same
9213 width as pointers. The assumption is true for Emacs porting targets
9214 now, but we want to make other targets possible.
9215 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9216 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9217 In the rest of the code, change types of integers that hold casted
9218 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9219 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9220 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9221 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9222 No need to cast type when ORing.
9223 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9224 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9225 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9226 assume EMACS_INT is the same width as char *.
9227 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9228 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9229 Remove no-longer-needed casts.
9230 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9231 (xg_tool_bar_help_callback, xg_make_tool_item):
9232 Use EMACS_INTPTR to hold an integer
9233 that will be cast to void *; this can avoid a GCC warning
9234 if EMACS_INT is not the same width as void *.
9235 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9236 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9237 (current_message_1, set_message_1):
9238 Use a local to convert to proper width without a cast.
9239 * xmenu.c (dialog_selection_callback): Likewise.
9240
ede49d71
PE
9241 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9242 Also, don't assume VALBITS / RAND_BITS is less than 5,
9243 and don't rely on undefined behavior when shifting a 1 left into
9244 the sign bit.
9245 * lisp.h (get_random): Change signature to match.
9246
2f30ecd0
PE
9247 * lread.c (hash_string): Use size_t, not int, for hash computation.
9248 Normally we prefer signed values; but hashing is special, because
9249 it's better to use unsigned division on hash table sizes so that
9250 the remainder is nonnegative. Also, size_t is the natural width
9251 for hashing into memory. The previous code used 'int', which doesn't
9252 retain enough info to hash well into very large tables.
9253 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9254
2a866e7b
PE
9255 * dbusbind.c: Don't possibly lose pointer info when converting.
9256 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9257 Use XPNTR rather than XHASH, so that the high-order bits of
9258 the pointer aren't lost when converting through void *.
9259
51639eac
PE
9260 * eval.c (Fautoload): Don't double-shift a pointer.
9261
92394119
PE
9262 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9263
dbdb9a7c
JB
92642011-05-06 Juanma Barranquero <lekktu@gmail.com>
9265
9266 * gnutls.c (DEF_GNUTLS_FN):
9267 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9268
db7a0b4f
AS
92692011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9270
9271 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9272 marker. (Bug#8610)
9273
cd394be1 92742011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9275
9276 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9277 New version that can reserve upto 2GB of heap space.
9278
f7ff1b0f 92792011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9280
9281 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9282
639c109b
TZ
92832011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9284
9285 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9286 `gnutls_certificate_set_x509_key_file'.
9287
d2127135
JB
92882011-05-05 Juanma Barranquero <lekktu@gmail.com>
9289
9290 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9291 Update dependencies.
9292
e968f4f3
JB
92932011-05-04 Juanma Barranquero <lekktu@gmail.com>
9294
9295 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9296 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9297 Remove unused parameter `fildes'.
9298 * process.c (read_process_output, send_process): Don't pass it.
9299
84d358f0
JB
93002011-05-04 Juanma Barranquero <lekktu@gmail.com>
9301
9302 Fix previous change: the library cache is defined in w32.c.
9303 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9304 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9305
0898ca10
JB
93062011-05-04 Juanma Barranquero <lekktu@gmail.com>
9307
9308 Implement dynamic loading of GnuTLS on Windows.
9309
9310 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9311 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9312 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9313 Declare.
9314
9315 * gnutls.c (Qgnutls_dll): Define.
9316 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9317 (gnutls_*): Declare function pointers.
9318 (init_gnutls_functions): New function to initialize function pointers.
9319 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9320 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9321 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9322 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9323 (emacs_gnutls_write, emacs_gnutls_read)
9324 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9325 (Fgnutls_available_p): New function.
9326 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9327 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9328 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9329
9330 * image.c: Include w32.h.
9331 (Vimage_type_cache): Delete.
9332 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9333 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9334 (w32_delayed_load): Move to w32.c.
9335
9336 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9337
9338 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9339 (w32_delayed_load): Move from image.c. When loading a library, record
9340 its filename in the :loaded-from property of the library id.
9341 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9342 Initialize and staticpro them.
9343 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9344
9345 * process.c: Include lisp.h before w32.h, not after.
9346 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9347 instead of gnutls_record_check_pending.
9348
9349 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9350
ff4de4aa
TZ
93512011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9352
9353 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9354 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9355 as passed in.
9356
abe95abb
JD
93572011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9358
9359 * xterm.c (x_set_frame_alpha): Do not set property on anything
9360 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9361
e16e55d4
JB
93622011-05-02 Juanma Barranquero <lekktu@gmail.com>
9363
9364 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9365
bafcf6a5
JB
93662011-05-02 Juanma Barranquero <lekktu@gmail.com>
9367
9368 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9369 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9370 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9371 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9372 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9373 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9374 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9375 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9376 (Qgnutls_bootprop_callbacks_verify): Make static.
9377
e7a6747f
AS
93782011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9379
19ed11ba
AS
9380 * callproc.c: Indentation fixup.
9381
e7a6747f 9382 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9383 (wait_for_termination, interruptible_wait_for_termination):
9384 Move after wait_for_termination_1.
e7a6747f 9385
1ef14cb4
LMI
93862011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9387
9388 * sysdep.c (interruptible_wait_for_termination): New function
9389 which is like wait_for_termination, but allows keyboard
9390 interruptions.
9391
9392 * callproc.c (Fcall_process): Add (:file "file") as an option for
9393 the STDOUT buffer.
9394 (Fcall_process_region): Ditto.
9395
330d880c
EZ
93962011-04-30 Eli Zaretskii <eliz@gnu.org>
9397
8db90b73
EZ
9398 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9399 rather than `XVECTOR (FOO)->size'.
9400
330d880c
EZ
9401 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9402 inttypes.h, as a gnulib replacement is used if it not available in
9403 system headers.
9404
15cbd324
EZ
94052011-04-21 Eli Zaretskii <eliz@gnu.org>
9406
9407 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9408 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9409 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9410
9411 * coding.c (coding_alloc_by_realloc): Error out if destination
9412 will grow beyond MOST_POSITIVE_FIXNUM.
9413 (decode_coding_emacs_mule): Abort if there isn't enough place in
9414 charbuf for the composition carryover bytes. Reserve an extra
9415 space for up to 2 characters produced in a loop.
9416 (decode_coding_iso_2022): Abort if there isn't enough place in
9417 charbuf for the composition carryover bytes.
9418
94192011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9420
ae940cca
EZ
9421 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9422 aborting when %lld or %lll format is passed.
9423 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9424 %llo or %llx format is passed. (Bug#8545)
9425
03ab8921
EZ
9426 * window.c (window_scroll_line_based): Use a marker instead of
9427 simple variables to record original value of point. (Bug#7952)
9428
afda1437
EZ
9429 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9430 produced by %s or %c overflows available buffer space. (Bug#8545)
9431
f76dee0c
PE
94322011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9433
9434 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9435 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9436
fdc5744d
JB
94372011-04-28 Juanma Barranquero <lekktu@gmail.com>
9438
9439 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9440
638f053a
JB
94412011-04-28 Juanma Barranquero <lekktu@gmail.com>
9442
9443 * keyboard.c (Qdelayed_warnings_hook): Define.
9444 (command_loop_1): Run `delayed-warnings-hook'
9445 if Vdelayed_warnings_list is non-nil.
9446 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9447 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9448
d178f871
EZ
94492011-04-28 Eli Zaretskii <eliz@gnu.org>
9450
9451 * doprnt.c (doprnt): Don't return value smaller than the buffer
9452 size if the message was truncated. (Bug#8545).
9453
b124fd93
JB
94542011-04-28 Juanma Barranquero <lekktu@gmail.com>
9455
9456 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9457 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9458
e810457d
PE
94592011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9460
9461 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9462
ea51cceb
JB
94632011-04-27 Juanma Barranquero <lekktu@gmail.com>
9464
9465 * makefile.w32-in: Update dependencies.
9466
94dcfacf
EZ
94672011-04-27 Eli Zaretskii <eliz@gnu.org>
9468
9469 Improve `doprnt' and its usage. (Bug#8545)
9470 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9471 `format_end'. Remove support for %l as a conversion specifier.
9472 Don't use xrealloc. Improve diagnostics when the %l size modifier
9473 is used. Update the commentary.
9474
9475 * eval.c (verror): Simplify calculation of size_t.
9476
9477 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9478 messages.
9479
f61f41d7
PE
94802011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9481
9482 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9483 change.
9484
96fb4434
PE
94852011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9486
9487 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9488 This makes this file independent of the recent pseudovector change.
9489
671875da 94902011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9491
69e9b5a3
PE
9492 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9493
b5f869a7 9494 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9495 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9496 Remove unused local.
c8926152 9497 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9498
841a1577 9499 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9500 GCC 4.6.0 optimizes based on type-based alias analysis.
9501 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9502 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9503 != &v->size, and therefore "v->size = 1; b->size = 2; return
9504 v->size;" must therefore return 1. This assumption is incorrect
9505 for Emacs, since it type-puns struct Lisp_Vector * with many other
9506 types. To fix this problem, this patch adds a new type struct
f904488f 9507 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9508 and pseudovectors, and helps optimizing compilers not get fooled
9509 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9510 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9511 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9512 the size member.
eab3844f
PE
9513 (XSETPVECTYPE): Rewrite in terms of new macro.
9514 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9515 This is a bit clearer, and further avoids the possibility of
9516 undesirable aliasing.
9517 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9518 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9519 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9520 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9521 (ASIZE): Now uses header.size rather than size.
9522 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9523 to avoid the hassle of writing XVECTOR (foo)->header.size.
9524 (struct vectorlike_header): New type.
eab3844f
PE
9525 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9526 object, to help avoid aliasing.
9527 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9528 (SUBRP): Likewise, since Lisp_Subr is a special case.
9529 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9530 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9531 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9532 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9533 changed to be "header.size" and "header.next".
9534 * buffer.h (struct buffer): Likewise.
9535 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9536 * frame.h (struct frame): Likewise.
9537 * process.h (struct Lisp_Process): Likewise.
9538 * termhooks.h (struct terminal): Likewise.
9539 * window.c (struct save_window_data, struct saved_window): Likewise.
9540 * window.h (struct window): Likewise.
9541 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9542 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9543 * buffer.c (init_buffer_once): Likewise.
9544 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9545 special case.
9546 * process.c (Fformat_network_address): Use local var for size,
9547 for brevity.
9548
0df1eac5
PE
9549 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9550
847ab9d1 9551 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9552 * data.c (atof): Remove decl; no longer used or needed.
9553 (digit_to_number): Move to lread.c.
9554 (Fstring_to_number): Use new string_to_number function, to be
9555 consistent with how the Lisp reader treats infinities and NaNs.
9556 Do not assume that floating-point numbers represent EMACS_INT
9557 without losing information; this is not true on most 64-bit hosts.
9558 Avoid double-rounding errors, by insisting on integers when
9559 parsing non-base-10 numbers, as the documentation specifies.
9560 * lisp.h (string_to_number): New decl, replacing ...
9561 (isfloat_string): Remove.
bc0a5c13 9562 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9563 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9564 appears to have been a coding error. Similarly, do not accept
9565 strings like +-1e0 as floating point numbers. Do not report
9566 overflow for integer overflows unless the base is not 10 which
9567 means we have no simple and reliable way to continue.
9568 Break out the floating-point parsing into a new
9569 function string_to_number, so that Fstring_to_number parses
9570 floating point numbers consistently with the Lisp reader.
04f2d78b 9571 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9572 (E_CHAR, EXP_INT): Remove, replacing with ...
9573 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9574 (string_to_number): New function, replacing isfloat_string.
9575 This function checks for valid syntax and produces the resulting
9576 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9577 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9578 so that overflow for non-base-10 numbers is reported only when
9579 there's no portable and simple way to convert to floating point.
452f4150 9580
67769ffc
PE
9581 * textprop.c (set_text_properties_1): Rewrite for clarity,
9582 and to avoid GCC warning about integer overflow.
9583
c20db43f
PE
9584 * intervals.h (struct interval): Use EMACS_INT for members
9585 where EMACS_UINT might cause problems. See
9586 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9587 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9588 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9589 All uses changed.
37aa2f85
PE
9590 (offset_intervals): Tell GCC not to worry about length overflow
9591 when negating a negative length.
c20db43f 9592
2538aa2f
PE
9593 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9594 (overrun_check_free): Likewise.
9595
f2d3008d
PE
9596 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9597 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9598 word size.
9599
ec8df744
PE
9600 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9601 (gnutls_make_error): Rename local to avoid shadowing.
9602 (gnutls_emacs_global_deinit): ifdef out; not used.
9603 (Fgnutls_boot): Use const for pointer to readonly storage.
9604 Comment out unused local. Fix pointer signedness problems.
9605
640ee02d
PE
9606 * lread.c (openp): Don't stuff size_t into an 'int'.
9607 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9608 about possible signed overflow.
9609
6048fb2a
PE
9610 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9611 (GDK_KEY_g): Don't define if already defined.
9612 (xg_prepare_tooltip): Avoid pointer signedness problem.
9613 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9614
fa3c87e1
PE
9615 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9616 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9617
2172544b
PE
9618 * xfns.c (Fx_window_property): Simplify a bit,
9619 to make a bit faster and to avoid GCC 4.6.0 warning.
9620 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9621
9b821a21
PE
9622 * fns.c (internal_equal): Don't assume size_t fits in int.
9623
3c616cfa
PE
9624 * alloc.c (compact_small_strings): Tighten assertion a little.
9625
c2982e87
PE
9626 Replace pEd with more-general pI, and fix some printf arg casts.
9627 * lisp.h (pI): New macro, generalizing old pEd macro to other
9628 conversion specifiers. For example, use "...%"pI"d..." rather
9629 than "...%"pEd"...".
9630 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9631 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9632 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9633 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9634 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9635 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9636 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9637 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9638 64-bit hosts.
9639 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9640 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9641 * print.c (safe_debug_print, print_object): Likewise.
9642 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9643 to int.
6f04d126
PE
9644 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9645 avoiding the 0 flag, which is not portable.
c2982e87
PE
9646 * process.c (Fmake_network_process): Use pI to avoid cast.
9647 * region-cache.c (pp_cache): Likewise.
9648 * xdisp.c (decode_mode_spec): Likewise.
9649 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9650 behavior on 64-bit hosts with printf arg.
6f04d126 9651 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9652 (x_stop_queuing_selection_requests): Likewise.
9653 (x_get_window_property): Don't truncate byte count to an 'int'
9654 when tracing.
0b432f21 9655
5e073ec7
PE
9656 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9657 here, since it parses constructs like leading '-' and spaces,
9658 which are not wanted; and it overflows with large numbers.
9659 Instead, simply match F[0-9]+, which is what is wanted anyway.
9660
36372bf9
PE
9661 * alloc.c: Remove unportable assumptions about struct layout.
9662 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9663 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9664 (allocate_vectorlike, make_pure_vector): Use the new macros,
9665 plus offsetof, to remove unportable assumptions about struct layout.
9666 These assumptions hold on all porting targets that I know of, but
9667 they are not guaranteed, they're easy to remove, and removing them
9668 makes further changes easier.
9669
0b432f21
PE
9670 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9671 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9672 (string_overrun_cookie): Now const. Use initializers that
9673 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9674 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9675 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9676 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9677 multiple of sizeof (EMACS_INT); it need not be, if
9678 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9679 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9680
895009e1
JB
96812011-04-26 Juanma Barranquero <lekktu@gmail.com>
9682
9683 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9684
6a7a1b0b
TZ
96852011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9686
9687 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9688 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9689 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9690
841a1577 96912011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9692
9693 * lisp.h (Qdebug): List symbol.
895009e1 9694 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9695 * keyboard.c (debug-on-event): New variable.
9696 (handle_user_signal): Break into debugger when debug-on-event
9697 matches the current signal symbol.
9698
f2d3ba6f
DN
96992011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9700
9701 * alloc.c (check_sblock, check_string_bytes)
9702 (check_string_free_list): Convert to standard C.
9703
42ce4c63
TZ
97042011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9705
9706 * w32.c (emacs_gnutls_push): Fix typo.
9707
825cd63c
EZ
97082011-04-25 Eli Zaretskii <eliz@gnu.org>
9709
fb11d64d
EZ
9710 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9711 "cast to pointer from integer of different size".
9712
825cd63c
EZ
9713 Improve doprnt and its use in verror. (Bug#8545)
9714 * doprnt.c (doprnt): Document the set of format control sequences
9715 supported by the function. Use SAFE_ALLOCA instead of always
9716 using `alloca'.
9717
9718 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9719 is one byte too soon. Don't use xrealloc; instead xfree and
9720 xmalloc anew.
9721
e061a11b
TZ
97222011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9723
9724 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9725 callbacks stage.
9726
9727 * gnutls.c: Renamed global_initialized to
9728 gnutls_global_initialized. Added internals for the
9729 :verify-hostname-error, :verify-error, and :verify-flags
9730 parameters of `gnutls-boot' and documented those parameters in the
9731 docstring. Start callback support.
9173deec
JB
9732 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9733 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9734 on error. Return error code.
e061a11b
TZ
9735 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9736 (emacs_gnutls_read): Likewise.
9737 (Fgnutls_boot): Return handshake error code.
9738 (emacs_gnutls_handle_error): New function.
9739 (wsaerror_to_errno): Likewise.
9740
9741 * w32.h (emacs_gnutls_pull): Add prototype.
9742 (emacs_gnutls_push): Likewise.
9743
9744 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9745 (emacs_gnutls_push): Likewise.
9746
97472011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9748
9749 * process.c (wait_reading_process_output): Check if GnuTLS
9750 buffered some data internally if no FDs are set for TLS
9751 connections.
9752
9753 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9754 (LIBS): Link to USER_LIBS.
9755 ($(BLD)/gnutls.$(0)): New target.
9756
fa6996bc
EZ
97572011-04-24 Eli Zaretskii <eliz@gnu.org>
9758
eb35682e
EZ
9759 * xdisp.c (handle_single_display_spec): Rename the
9760 display_replaced_before_p argument into display_replaced_p, to
9761 make it consistent with the commentary. Fix typos in the
9762 commentary.
9763
e2ad650c
EZ
9764 * textprop.c (syms_of_textprop): Remove dead code.
9765 (copy_text_properties): Delete obsolete commentary about an
9766 interface that was deleted long ago. Fix typos in the description
9767 of arguments.
9768
1b2de274
EZ
9769 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9770 to changes in oldXMenu/XMenu.h from 2011-04-16.
9771 <menu_help_message, prev_menu_help_message>: Constify.
9772 (IT_menu_make_room): menu->help_text is now `const char **';
9773 adjust.
9774
9775 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9776 to changes in oldXMenu/XMenu.h from 2011-04-16.
9777 (struct XMenu): Declare `help_text' `const char **'.
9778
9779 * xfaces.c <Qunspecified>: Make extern again.
9780
9781 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9782 required by POSIX.
1b2de274 9783
762b15be
EZ
9784 * doc.c (get_doc_string): Improve the format passed to `error'.
9785
9786 * doprnt.c (doprnt): Improve commentary.
9787
9788 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9789
9790 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9791 them with etags.
9792
f1052e5d
EZ
9793 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9794 changes in globals.h immediately force recompilation.
762b15be
EZ
9795 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9796 $(CURDIR)/s/ms-w32.h.
9797 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9798
fa6996bc
EZ
9799 * character.c (Fchar_direction): Function deleted.
9800 (syms_of_character): Don't defsubr it.
9801 <char-direction-table>: Deleted.
9802
e6c3da20
EZ
98032011-04-23 Eli Zaretskii <eliz@gnu.org>
9804
9805 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9806 * doprnt.c: Include limits.h.
9807 (SIZE_MAX): New macro.
04f2d78b
CB
9808 (doprnt): Return a size_t value. 2nd arg is now size_t.
9809 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9810 Improve overflow protection. Support `l' modifier for integer
9811 conversions. Support %l conversion. Don't assume an EMACS_INT
9812 argument for integer conversions and for %c.
9813
9814 * lisp.h (doprnt): Restore prototype.
9815
9816 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9817 $(SRC)/character.h.
9818
9819 * Makefile.in (base_obj): Add back doprnt.o.
9820
9821 * deps.mk (doprnt.o): Add back prerequisites.
9822 (callint.o): Depend on character.h.
9823
9824 * eval.c (internal_lisp_condition_case): Include the handler
9825 representation in the error message.
9826 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9827 when breaking from the loop.
9828
9829 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9830
9831 * callint.c (Fcall_interactively): When displaying error message
9832 about invalid control letter, pass the character's codepoint, not
9833 a pointer to its multibyte form. Improve display of the character
9834 in octal and display also its hex code.
9835
9836 * character.c (char_string): Use %x to display the (unsigned)
9837 codepoint of an invalid character, to avoid displaying a bogus
9838 negative value.
9839
9840 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9841 `error', not SYMBOL_NAME itself.
9842
9843 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9844 character arguments to `error'.
9845
9846 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9847 to `error' in error message about FINAL_CHAR argument. Make sure
9848 FINAL_CHAR is a character, and use %c when it is passed as
9849 argument to `error'.
9850
4ffd0d6b 98512011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9852
9853 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9854
9855 * w32.c: Include <time.h>.
9856 (sys_localtime): New function.
9857
4ffd0d6b 98582011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9859
9860 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9861
4ffd0d6b 9862 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9863
4ffd0d6b 98642011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9865
4ffd0d6b
GM
9866 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9867 zombies (Bug#8467).
aac0c6e3 9868
04c56954
EZ
98692011-04-19 Eli Zaretskii <eliz@gnu.org>
9870
9871 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9872 gl_state.e_property when gl_state.object is Qt.
9873
9874 * insdel.c (make_gap_larger): Remove limitation of buffer size
9875 to <= INT_MAX.
9876
16a43933
CY
98772011-04-18 Chong Yidong <cyd@stupidchicken.com>
9878
9879 * xdisp.c (lookup_glyphless_char_display)
9880 (produce_glyphless_glyph): Handle cons cell entry in
9881 glyphless-char-display.
9882 (Vglyphless_char_display): Document it.
9883
9884 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9885 glyphless-char-display.
9886
4581706e
CY
98872011-04-17 Chong Yidong <cyd@stupidchicken.com>
9888
9889 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9890
9891 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9892
9893 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9894 definition for no-X builds.
9895
4887c6e2 98962011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9897
fd35b6f9
PE
9898 Static checks with GCC 4.6.0 and non-default toolkits.
9899
5c1ccb01
PE
9900 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9901
006c5daa
PE
9902 * process.c (keyboard_bit_set): Define only if SIGIO.
9903 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9904 (send_process): Repair possible setjmp clobbering.
9905
efc736d3
PE
9906 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9907
4e2fe2e6
PE
9908 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9909
f97334a2
PE
9910 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9911
4e75f29d
PE
9912 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9913 Define only if needed.
9914
90efadd1
PE
9915 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9916 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9917 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9918
3c647824
PE
9919 * dispextern.h (struct redisplay_interface): Rename param
9920 to avoid shadowing.
e264f262 9921 * termhooks.h (struct terminal): Likewise.
761383f4 9922 * xterm.c (xembed_send_message): Likewise.
3c647824 9923
b58c5c4a
PE
9924 * insdel.c (make_gap_smaller): Define only if
9925 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9926
cad59032
PE
9927 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9928 it.
9929
c339dc2e
PE
9930 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9931 so that we aren't warned about unused symbols.
9932
91a3e27b
PE
9933 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9934
399c71d3 9935 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9936
8ffc96f5
PE
9937 * xfns.c (x_real_positions): Mark locals as initialized.
9938
eef9bc79
PE
9939 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9940
098db9dd
PE
9941 * xterm.c: Fix problems found by static analysis with other toolkits.
9942 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9943 (x_dispatch_event): Declare static if USE_GTK, and
9944 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9945 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9946 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9947 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9948 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9949
eb18f6cc
PE
9950 * xmenu.c (menu_help_callback): Pointer type fixes.
9951 Use const pointers when pointing at readonly data. Avoid pointer
9952 signedness clashes.
9953 (FALSE): Remove unused macro.
9954 (update_frame_menubar): Remove unused decl.
9955
1fe72bf8
PE
9956 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9957
60d9e1db
PE
9958 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9959 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9960 (single_menu_item): Rename local to avoid shadowing.
9961
39261c26
PE
9962 * keyboard.c (make_lispy_event): Remove unused local var.
9963
018c5e19
PE
9964 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9965 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9966
63d2b86e
PE
9967 * bitmaps: Change bitmaps from unsigned char back to the X11
9968 compatible char. Avoid the old compiler warnings about
9969 out-of-range initializers by using, for example, '\xab' rather
9970 than 0xab.
9971
aefd87e1
PE
9972 * xgselect.c (xgselect_initialize): Check vs interface
9973 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9974
bf501fb9
PE
9975 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9976
e9829fdf
PE
9977 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9978 to read-only memory.
9979
1086c095
PE
9980 * fns.c (vector): Remove; this old hack is no longer needed.
9981
2baccd04 9982 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9983 Remove unused var.
dde42981 9984 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9985
72391843 9986 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9987
436c16df 9988 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9989 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9990 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9991
92bb796d 9992 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9993 (x_term_init): Remove local to avoid shadowing.
92bb796d 9994
764430a3 9995 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9996
9997 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9998 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9999
d1dfb56c
EZ
100002011-04-16 Eli Zaretskii <eliz@gnu.org>
10001
c4354cb4
EZ
10002 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10003
d1dfb56c
EZ
10004 Fix regex.c, syntax.c and friends for buffers > 2GB.
10005 * syntax.h (struct gl_state_s): Declare character position members
10006 EMACS_INT.
10007
10008 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10009
04f2d78b
CB
10010 * textprop.c (verify_interval_modification, interval_of):
10011 Declare arguments EMACS_INT.
d1dfb56c
EZ
10012
10013 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10014 EMACS_INT.
10015
10016 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10017
10018 * indent.c (Fvertical_motion): Local variable it_start is now
10019 EMACS_INT.
10020
10021 * regex.c (re_match, re_match_2, re_match_2_internal)
10022 (bcmp_translate, regcomp, regexec, print_double_string)
10023 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10024 (re_compile_pattern, re_exec): Declare arguments and local
10025 variables `size_t' and `ssize_t' and return values `regoff_t', as
10026 appropriate.
10027 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10028 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10029 <compile_stack_type>: `size' and `avail' are now `size_t'.
10030
10031 * regex.h <regoff_t>: Use ssize_t, not int.
10032 (re_search, re_search_2, re_match, re_match_2): Arguments that
10033 specify buffer/string position and length are now ssize_t and
10034 size_t. Return type is regoff_t.
10035
613052cd
BK
100362011-04-16 Ben Key <bkey76@gmail.com>
10037
10038 * nsfont.m: Fixed bugs in ns_get_family and
10039 ns_descriptor_to_entity that were caused by using free to
10040 deallocate memory blocks that were allocated by xmalloc (via
10041 xstrdup). This caused Emacs to crash when compiled with
10042 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10043 --enable-checking=xmallocoverrun). xfree is now used to
10044 deallocate these memory blocks.
10045
4170f62f 100462011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10047
71b41406
PE
10048 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10049
9587a89d
PE
10050 emacs_write: Accept and return EMACS_INT for sizes.
10051 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10052 et seq.
10053 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10054 Accept and return EMACS_INT.
10055 (emacs_gnutls_write): Return the number of bytes written on
10056 partial writes.
10057 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10058 (emacs_read, emacs_write): Remove check for negative size, as the
10059 Emacs source code has been audited now.
9587a89d
PE
10060 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10061 (emacs_read, emacs_write): Use it.
273a5f82
PE
10062 * process.c (send_process): Adjust to the new signatures of
10063 emacs_write and emacs_gnutls_write. Do not attempt to store
10064 a byte offset into an 'int'; it might overflow.
9587a89d 10065 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10066
3e047f51
PE
10067 * sound.c: Don't assume sizes fit in 'int'.
10068 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10069 Return EMACS_INT, not int.
3e047f51 10070 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10071 Accept EMACS_INT, not int.
10072 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10073 record read return values.
10074
cc39a9db
BK
100752011-04-15 Ben Key <bkey76@gmail.com>
10076
c9d0ec6d
JB
10077 * keyboard.c (Qundefined): Don't declare static since it is used
10078 in nsfns.m.
10079 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10080 static since they are used in nsfont.m.
cc39a9db 10081
6c60eb9f
SM
100822011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10083
10084 * process.c (Qprocessp): Don't declare static.
10085 * lisp.h (Qprocessp): Declare again.
10086
7990b61a
JB
100872011-04-15 Juanma Barranquero <lekktu@gmail.com>
10088
10089 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10090
5d4cb038
PE
100912011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10092
8bd7b830 10093 Improve C-level modularity by making more things 'static'.
cd64ea1d 10094
e3b27b31
PE
10095 Don't publish debugger-only interfaces to other modules.
10096 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10097 (verify_bytepos, count_markers): Move decls to the only modules
10098 that need them.
10099 * region-cache.h (pp_cache): Likewise.
10100 * window.h (check_all_windows): Likewise.
10101 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10102
5d4cb038
PE
10103 * sysdep.c (croak): Now static, if
10104 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10105 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10106
10107 * alloc.c (refill_memory_reserve): Now static if
10108 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10109 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10110
e87b6180
PE
10111 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10112 Define only if USE_LUCID.
10113
ac64929e
PE
10114 * xrdb.c (x_customization_string, x_rm_string): Now static.
10115
6f37259d
PE
10116 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10117 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10118
1683e3ab
PE
10119 * xdisp.c (draw_row_with_mouse_face): Now static.
10120 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10121
de9c2632
PE
10122 * window.h (check_all_windows): Mark externally visible.
10123
2b96acb7
PE
10124 * window.c (window_deletion_count): Now static.
10125
10126 * undo.c: Make symbols static if they're not exported.
10127 (last_undo_buffer, last_boundary_position, pending_boundary):
10128 Now static.
10129
50436f33
PE
10130 * textprop.c (interval_insert_behind_hooks): Now static.
10131 (interval_insert_in_front_hooks): Likewise.
10132
64520e5c
PE
10133 * term.c: Make symbols static if they're not exported.
10134 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10135 (max_frame_lines, tty_set_terminal_modes):
10136 (tty_reset_terminal_modes, tty_turn_off_highlight):
10137 (get_tty_terminal): Now static.
10138 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10139 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10140 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10141 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10142 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10143
1fa53021
PE
10144 * sysdep.c: Make symbols static if they're not exported.
10145 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10146 Now static.
10147 (sigprocmask_set, full_mask): Remove; unused.
10148 (wait_debugging): Mark as visible.
10149 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10150 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10151
d4b43b22
PE
10152 * syntax.c (syntax_temp): Define only if !__GNUC__.
10153
b7c513d0
PE
10154 * sound.c (current_sound_device, current_sound): Now static.
10155
989b29ad
PE
10156 * search.c (searchbufs, searchbuf_head): Now static.
10157
13a55a78
PE
10158 * scroll.c (scroll_cost): Remove; unused.
10159 * dispextern.h (scroll_cost): Remove decl.
10160
de68a1fc
PE
10161 * region-cache.h (pp_cache): Mark as externally visible.
10162
40ccffa6
PE
10163 * process.c: Make symbols static if they're not exported.
10164 (process_tick, update_tick, create_process, chan_process):
10165 (Vprocess_alist, proc_buffered_char, datagram_access):
10166 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10167 (deactivate_process): Mark defn as static, as well as decl.
10168 * lisp.h (create_process): Remove decl.
10169 * process.h (chan_process, Vprocess_alist): Remove decls.
10170
ad64fc97
PE
10171 * print.c: Make symbols static if they're not exported.
10172 (print_depth, new_backquote_output, being_printed, print_buffer):
10173 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10174 (print_interval, print_number_index, initial_stderr_stream):
10175 Now static.
10176 * lisp.h (Fprinc): Remove decl.
10177 (debug_output_compilation_hack): Mark as externally visible.
10178
adddb265
PE
10179 * sysdep.c (croak): Move decl from here to syssignal.h.
10180 * syssignal.h (croak): Put it here, so the API can be checked when
10181 'croak' is called from dissociate_if_controlling_tty.
10182
1717ede2
PE
10183 * minibuf.c: Make symbols static if they're not exported.
10184 (minibuf_save_list, choose_minibuf_frame): Now static.
10185 * lisp.h (choose_minibuf_frame): Remove decl.
10186
fa5fb2bc
PE
10187 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10188
1e3890d1
PE
10189 * lread.c: Make symbols static if they're not exported.
10190 (read_objects, initial_obarray, oblookup_last_bucket_number):
10191 Now static.
10192 (make_symbol): Remove; unused.
10193 * lisp.h (initial_obarray, make_symbol): Remove decls.
10194
8a1414fa
PE
10195 * keyboard.c: Make symbols static if they're not exported.
10196 (single_kboard, recent_keys_index, total_keys, recent_keys):
10197 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10198 (this_single_command_key_start, echoing, last_auto_save):
10199 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10200 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10201 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10202 (Vlispy_mouse_stem, double_click_count):
10203 Now static.
10204 (force_auto_save_soon): Define only if SIGDANGER.
10205 (ignore_mouse_drag_p): Now static if
10206 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10207 (print_help): Remove; unused.
10208 (stop_character, last_timer_event): Mark as externally visible.
10209 * keyboard.h (ignore_mouse_drag_p): Declare only if
10210 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10211 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10212 * lisp.h (echoing): Remove decl.
10213 (force_auto_save_soon): Declare only if SIGDANGER.
10214 * xdisp.c (redisplay_window): Simplify code, to make it more
10215 obvious that ignore_mouse_drag_p is not accessed if !defined
10216 USE_GTK && !defined HAVE_NS.
10217
93ea6e8f
PE
10218 * intervals.c: Make symbols static if they're not exported.
10219 (merge_properties_sticky, merge_interval_right, delete_interval):
10220 Now static.
10221 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10222
77382fcc
PE
10223 * insdel.c: Make symbols static if they're not exported.
10224 However, leave prepare_to_modify_buffer alone. It's never
10225 called from outside this function, but that appears to be a bug.
10226 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10227 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10228 (adjust_after_replace_noundo): Remove; unused.
10229 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10230 (signal_before_change): Remove decls.
77382fcc 10231
9306c32e
PE
10232 * indent.c (val_compute_motion, val_vmotion): Now static.
10233
cd44d2eb
PE
10234 * image.c: Make symbols static if they're not exported.
10235 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10236 if USE_GTK.
10237 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10238 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10239
ad9a7a06
PE
10240 * fringe.c (standard_bitmaps): Now static.
10241 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10242
81626931
PE
10243 * frame.c: Make symbols static if they're not exported.
10244 (x_report_frame_params, make_terminal_frame): Now static.
10245 (get_frame_param): Now static, unless HAVE_NS.
10246 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10247 (x_get_resource_string): Remove; not used.
10248 * frame.h (make_terminal_frame, x_report_frame_params):
10249 (x_get_resource_string); Remove decls.
10250 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10251 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10252
239f9db9
PE
10253 * font.c, fontset.c: Make symbols static if they're not exported.
10254 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10255 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10256 * font.c (font_close_object): Now static.
10257 * font.h (font_close_object): Remove.
10258 * fontset.c (FONTSET_OBJLIST): Remove.
10259 (free_realized_fontset) #if-0 the body, which does nothing.
10260 (face_suitable_for_char_p): #if-0, as it's never called.
10261 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10262 * xfaces.c (face_at_string_position):
10263 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10264 since 0 is always ASCII.
10265
dfcf3579
PE
10266 * fns.c (weak_hash_tables): Now static.
10267
5045092b
PE
10268 * fileio.c: Make symbols static if they're not exported.
10269 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10270 (Vwrite_region_annotation_buffers): Now static.
10271
57a96f5c
PE
10272 * eval.c: Make symbols static if they're not exported.
10273 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10274 * lisp.h (backtrace_list): Remove decl.
10275
35f08c38
PE
10276 * emacs.c: Make symbols static if they're not exported.
10277 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10278 (fatal_error_code, fatal_error_signal_hook, standard_args):
10279 Now static.
10280 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10281 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10282 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10283 * lisp.h (fatal_error_signal_hook): Remove decl.
10284 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10285
f44bd759
PE
10286 * editfns.c: Move a (normally-unused) function to its only use.
10287 * editfns.c, lisp.h (get_operating_system_release): Remove.
10288 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10289 worth the hassle of breaking this out.
10290
b532497d
PE
10291 * xterm.c: Make symbols static if they're not exported.
10292 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10293 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10294 (x_destroy_window, x_delete_display):
10295 Now static.
10296 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10297 (x_mouse_leave): Remove; unused.
10298 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10299 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10300 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10301 Remove decls.
10302 (x_mouse_leave): Declare only if WINDOWSNT.
10303 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10304 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10305 USE_X_TOOLKIT.
10306
1675728f
PE
10307 * ftxfont.c: Make symbols static if they're not exported.
10308 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10309 HAVE_FREETYPE.
10310 * font.h (ftxfont_driver): Likewise.
10311
e4cebfca
PE
10312 * xfns.c: Make symbols static if they're not exported.
10313 (x_last_font_name, x_display_info_for_name):
10314 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10315 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10316 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10317 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10318 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10319 (last_show_tip_args): Now static.
10320 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10321 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10322 (x_screen_planes): Remove; unused.
10323 * dispextern.h (x_screen_planes): Remove decl.
10324
5bf46f05
PE
10325 * dispnew.c: Make symbols static if they're not exported.
10326 * dispextern.h (redraw_garbaged_frames, scrolling):
10327 (increment_row_positions): Remove.
10328 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10329 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10330 Now static.
10331 (redraw_garbaged_frames): Remove; unused.
10332
435f4c28
PE
10333 * xfaces.c: Make symbols static if they're not exported.
10334 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10335 Remove decls.
10336 * xterm.h (defined_color): Remove decls.
10337 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10338 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10339 (menu_face_changed_default, defined_color, free_realized_face):
10340 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10341 (ascii_face_of_lisp_face): Remove; unused.
10342
8524aef3
PE
10343 * xdisp.c: Make symbols static if they're not exported.
10344 * dispextern.h (scratch_glyph_row, window_box_edges):
10345 (glyph_to_pixel_coords, set_cursor_from_row):
10346 (get_next_display_element, set_iterator_to_next):
10347 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10348 (show_mouse_face): Remove decls
10349 * frame.h (message_buf_print): Likewise.
10350 * lisp.h (pop_message, set_message, check_point_in_composition):
10351 Likewise.
10352 * xterm.h (set_vertical_scroll_bar): Likewise.
10353 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10354 (message_buf_print, scratch_glyph_row, displayed_buffer):
10355 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10356 (get_next_display_element, show_mouse_face, window_box_edges):
10357 (frame_to_window_pixel_xy, check_point_in_composition):
10358 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10359 (glyph_to_pixel_coords): Remove; unused.
10360
16390cd2
PE
10361 * dired.c (file_name_completion): Now static.
10362
10363 * dbusbind.c (xd_in_read_queued_messages): Now static.
10364
a25f4dfa
PE
10365 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10366 * data.c (circular_list_error): Remove.
10367
14a9c8df
PE
10368 * commands.h (last_point_position, last_point_position_buffer):
10369 (last_point_position_window): Remove decls.
10370 * keyboard.c: Make these variables static.
10371
04f2d78b
CB
10372 * coding.h (coding, code_convert_region, encode_coding_gap):
10373 Remove decls.
74ab6df5
PE
10374 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10375 (iso_code_class, detect_coding, code_convert_region): Now static.
10376 (encode_coding_gap): Remove; unused.
10377
38dfbee1
PE
10378 * chartab.c (chartab_chars, chartab_bits): Now static.
10379
a2cb4e63
PE
10380 * charset.h (charset_iso_8859_1): Remove decl.
10381 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10382 Now static.
10383
127198fd
PE
10384 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10385 * ccl.c (Vccl_program_table): Now static.
10386 (check_ccl_update): Remove; unused.
10387
d85b608f
PE
10388 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10389 * category.h: ... from here.
10390 * category.c (check_category_table, set_category_set): Now static.
10391
31cd66f3
PE
10392 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10393 * lisp.h: Remove these decls.
10394
c358e587
PE
10395 * buffer.c (buffer_count): Remove unused var.
10396
e78aecca
PE
10397 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10398 so that it's not optimized away.
10399 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10400 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10401 exported only to the debugger.
10402
e192d7d3 10403 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10404 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10405
92470028
PE
10406 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10407 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10408 was inaccessible from Lisp.
10409 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10410 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10411
244ed907
PE
10412 alloc.c: Import and export fewer symbols, and remove unused items.
10413 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10414 is defined.
10415 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10416 it's not optimized away by whole-program optimization.
10417 (message_enable_multibyte, free_misc): Remove.
10418 (catchlist, handlerlist, mark_backtrace):
10419 Declare only if BYTE_MARK_STACK.
10420 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10421 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10422 (message_enable_multibyte): Remove decl.
10423 (free_misc, interval_free_list, float_block, float_block_index):
10424 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10425 (cons_free_list, last_marked_index):
10426 Now static.
10427 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10428 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10429 (mark_backtrace): Define only if BYTE_MARK_STACK.
10430 * xdisp.c (message_enable_multibyte): Now static.
10431
61c2b50e 10432 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10433 This makes it easier for human readers (and static analyzers)
10434 to see whether these variables are used from other modules.
10435 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10436 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10437 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10438 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10439 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10440 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10441 * xmenu.c, xselect.c:
10442 Declare Q* vars static if they are not used in other modules.
10443 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10444 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10445 Remove decls of unexported vars.
10446 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10447
95c82688
PE
10448 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10449
16a97296
PE
10450 Make Emacs functions such as Fatom 'static' by default.
10451 This makes it easier for human readers (and static analyzers)
10452 to see whether these functions can be called from other modules.
10453 DEFUN now defines a static function. To make the function external
10454 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10455 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10456 (Finit_image_library):
16a97296
PE
10457 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10458 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10459 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10460 Remove decls, since these functions are now static.
10461 (Funintern, Fget_internal_run_time): New decls, since these functions
10462 were already external.
95c82688 10463
16a97296
PE
10464 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10465 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10466 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10467 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10468 * keyboard.c, keymap.c, lread.c:
10469 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10470 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10471 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10472 Mark functions with DEFUE instead of DEFUN,
10473 if they are used in other modules.
10474 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10475 decls for now-static functions.
10476 * buffer.h (Fdelete_overlay): Remove decl.
10477 * callproc.c (Fgetenv_internal): Mark as internal.
10478 * composite.c (Fremove_list_of_text_properties): Remove decl.
10479 (Fcomposition_get_gstring): New forward static decl.
10480 * composite.h (Fcomposite_get_gstring): Remove decl.
10481 * dired.c (Ffile_attributes): New forward static decl.
10482 * doc.c (Fdocumntation_property): New forward static decl.
10483 * eval.c (Ffetch_bytecode): New forward static decl.
10484 (Funintern): Remove extern decl; now in .h file where it belongs.
10485 * fileio.c (Fmake_symbolic_link): New forward static decl.
10486 * image.c (Finit_image_library): New forward static decl.
10487 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10488 * intervals.h (Fprevious_property_change):
10489 (Fremove_list_of_text_properties): Remove decls.
10490 * keyboard.c (Fthis_command_keys): Remove decl.
10491 (Fcommand_execute): New forward static decl.
10492 * keymap.c (Flookup_key): New forward static decl.
10493 (Fcopy_keymap): Now static.
10494 * keymap.h (Flookup_key): Remove decl.
10495 * process.c (Fget_process): New forward static decl.
10496 (Fprocess_datagram_address): Mark as internal.
10497 * syntax.c (Fsyntax_table_p): New forward static decl.
10498 (skip_chars): Remove duplicate decl.
10499 * textprop.c (Fprevious_property_change): New forward static decl.
10500 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10501 Now internal.
10502 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10503 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10504
785bbd42
PE
10505 * editfns.c (Fformat): Remove unreachable code.
10506
8b913b57
AS
105072011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10508
10509 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10510 change. (Bug#8496)
10511
a6744a35
EZ
105122011-04-13 Eli Zaretskii <eliz@gnu.org>
10513
10514 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10515 when at ZV. (Bug#8487)
10516
e7974947
AS
105172011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10518
baad03f0
AS
10519 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10520 (Bug#8437)
10521 * keyboard.c (parse_tool_bar_item): Likewise.
10522 * sound.c (sound_cleanup, alsa_close): Likewise.
10523 * termcap.c (tgetent): Likewise.
10524 * xfns.c (x_default_font_parameter): Likewise.
10525 * xsettings.c (read_and_apply_settings): Likewise.
10526
e7974947
AS
10527 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10528 (overrun_check_free): Protoize.
10529
28272684
PE
105302011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10531
10532 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10533 since callers should never pass a negative size.
10534 Change the signature to match that of plain 'read' and 'write'; see
10535 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10536 * lisp.h: Update prototypes of emacs_write and emacs_read.
10537
11997c76
EZ
105382011-04-11 Eli Zaretskii <eliz@gnu.org>
10539
10540 * xdisp.c (redisplay_window): Don't try to determine the character
10541 position of the scroll margin if the window start point w->startp
e896f03c 10542 is outside the buffer's accessible region. (Bug#8468)
11997c76 10543
8a2cbd72
EZ
105442011-04-10 Eli Zaretskii <eliz@gnu.org>
10545
10546 Fix write-region and its subroutines for buffers > 2GB.
10547 * fileio.c (a_write, e_write): Modify declaration of arguments and
10548 local variables to support buffers larger than 2GB.
10549 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10550
10551 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10552 argument, local variables, and return value.
10553
10554 * lisp.h: Update prototypes of emacs_write and emacs_read.
10555
10556 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10557
4073e537 105582011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10559
1ebfdcb6
PE
10560 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10561
b2ded58d
PE
10562 Fix more problems found by GCC 4.6.0's static checks.
10563
7d66342c
PE
10564 * xdisp.c (vmessage): Use a better test for character truncation.
10565
bbf47d44
PE
10566 * charset.c (load_charset_map): <, not <=, for optimization,
10567 and to avoid potential problems with integer overflow.
9248994d 10568 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10569 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10570 * editfns.c (Fformat): Likewise.
1e69125e 10571 * syntax.c (skip_chars): Likewise.
3befa583 10572
e3019616
PE
10573 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10574 This also lets GCC 4.6.0 generate slightly better loop code.
10575
becfa255
PE
10576 * callint.c (Fcall_interactively): <, not <=, for optimization.
10577 (Fcall_interactively): Count the number of arguments produced,
10578 not the number of arguments given. This is simpler and lets GCC
10579 4.6.0 generate slightly better code.
10580
dae0cd48
PE
10581 * ftfont.c: Distingish more carefully between FcChar8 and char.
10582 The previous code passed unsigned char * to a functions like
10583 strlen and xstrcasecmp that expect char *, which does not
10584 conform to the C standard.
10585 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10586 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10587 char * when the C standard requires it.
10588
76032d70
PE
10589 * keyboard.c (read_char): Remove unused var.
10590
eb3f1cc8
PE
10591 * eval.c: Port to Windows vsnprintf (Bug#8435).
10592 Include <limits.h>.
10593 (SIZE_MAX): Define if the headers do not.
10594 (verror): Do not give up if vsnprintf returns a negative count.
10595 Instead, grow the buffer. This ports to Windows vsnprintf, which
10596 does not conform to C99. Problem reported by Eli Zaretskii.
10597 Also, simplify the allocation scheme, by avoiding the need for
10598 calling realloc, and removing the ALLOCATED variable.
10599
70476b54
PE
10600 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10601
12020a9e
PE
10602 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10603 But keep the doprint source code for now, as we might revamp it
10604 and use it again (Bug#8435).
ea6c7ae6
PE
10605 * lisp.h (doprnt): Remove.
10606 * Makefile.in (base_obj): Remove doprnt.o.
10607 * deps.mk (doprnt.o): Remove.
10608
5fdb398c
PE
10609 error: Print 32- and 64-bit integers portably (Bug#8435).
10610 Without this change, on typical 64-bit hosts error ("...%d...", N)
10611 was used to print both 32- and 64-bit integers N, which relied on
10612 undefined behavior.
61bdb816 10613 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10614 * lisp.h (error, verror): Mark as printf-like functions.
10615 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10616 Report overflow in size calculations when allocating printf buffer.
10617 Do not truncate output string at its first null byte.
10618 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10619 Truncate the output at a character boundary, since vsnprintf does not
10620 do that.
10621 * charset.c (check_iso_charset_parameter): Convert internal
10622 character to string before calling 'error', since %c now has the
10623 printf meaning.
10624 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10625 overflow when computing char to be passed to 'error'. Do not
10626 pass Lisp_Object to 'error'; pass the integer instead.
10627 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10628 formatted with plain %d.
10629
b189fa66
PE
10630 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10631
bff87ef0
PE
10632 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10633
7e2cac20
PE
10634 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10635
ce4d90b5
PE
10636 * xterm.c (x_catch_errors): Remove duplicate declaration.
10637
266c9547
PE
10638 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10639
79c49ad2
PE
10640 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10641
368f4090
JM
106422011-04-10 Jim Meyering <meyering@redhat.com>
10643
10644 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10645 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10646 return ssize_t not "int", and use size_t as the buffer length.
10647 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10648 * gnutls.h: Update declarations.
10649 * process.c (read_process_output): Use ssize_t, to match.
10650 (send_process): Likewise.
10651
a32d4040
CY
106522011-04-09 Chong Yidong <cyd@stupidchicken.com>
10653
10654 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10655
8546720e 106562011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10657
04f2d78b
CB
10658 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10659 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10660
8546720e
GM
10661 * xterm.c (handle_one_xevent):
10662 * xmenu.c (create_and_show_popup_menu):
10663 * xselect.c (x_decline_selection_request)
10664 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10665
0a2f5c1a 106662011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10667
10668 Fix some uses of `int' instead of EMACS_INT.
10669 * search.c (string_match_1, fast_string_match)
10670 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10671 (scan_buffer, find_next_newline_no_quit)
10672 (find_before_next_newline, search_command, Freplace_match)
10673 (Fmatch_data): Make some `int' variables be EMACS_INT.
10674
10675 * xdisp.c (display_count_lines): 3rd argument and return value now
10676 EMACS_INT. All callers changed.
10677 (pint2hrstr): Last argument is now EMACS_INT.
10678
10679 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10680 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10681 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10682 (decode_coding_utf_16, decode_coding_emacs_mule)
10683 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10684 (decode_coding_ccl, decode_coding_charset)
10685 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10686 (decode_coding_iso_2022, decode_coding_emacs_mule)
10687 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10688 <char_offset, last_offset>: Declare EMACS_INT.
10689 (encode_coding_utf_8, encode_coding_utf_16)
10690 (encode_coding_emacs_mule, encode_invocation_designation)
10691 (encode_designation_at_bol, encode_coding_iso_2022)
10692 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10693 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10694 Declare EMACS_INT.
10695 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10696 (encode_invocation_designation): Last argument P_NCHARS is now
10697 EMACS_INT.
10698 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10699 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10700
10701 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10702 All users changed.
10703
10704 * ccl.c (Fccl_execute_on_string): Declare some variables
10705 EMACS_INT.
10706
8546720e 107072011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10708
10709 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10710
4e19a977
CS
107112011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10712
10713 * process.c (Fformat_network_address): Doc fix.
10714
87302331
R
107152011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10716
ee7683eb 10717 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10718
cbb59342
CY
107192011-04-08 Chong Yidong <cyd@stupidchicken.com>
10720
10721 * keyboard.c (read_char): Call Lisp function help-form-show,
10722 instead of using internal_with_output_to_temp_buffer.
10723 (Qhelp_form_show): New var.
e0d38eeb 10724 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10725
10726 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10727
10728 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10729
e67a13ab
CY
107302011-04-06 Chong Yidong <cyd@stupidchicken.com>
10731
04f2d78b
CB
10732 * process.c (Flist_processes): Remove to Lisp.
10733 (list_processes_1): Delete.
e67a13ab 10734
973f782d
EZ
107352011-04-06 Eli Zaretskii <eliz@gnu.org>
10736
7c106b1e
EZ
10737 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10738
973f782d
EZ
10739 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10740
41cf7d1a 107412011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10742
ca23cc88
PE
10743 Fix more problems found by GCC 4.6.0's static checks.
10744
f390e2d5
PE
10745 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10746
42eea0d0
PE
10747 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10748
b69769da 10749 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10750
f9541e84
PE
10751 * xdisp.c (vmessage): Mark as a printf-like function.
10752
13841b55
PE
10753 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10754
c136c10f
PE
10755 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10756
5e2d4a30
PE
10757 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10758 printf-like functions.
10759 (tiff_load): Add casts to remove these marks before passing them
10760 to system-supplied API.
10761
583f48b9
PE
10762 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10763
b25d760e
PE
10764 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10765 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10766 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10767 directly, rather than having caller test rule sign. This avoids
10768 some unnecessary tests.
10769 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10770 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10771 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10772
bc7b6697 10773 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10774 (xfont_open): Avoid unnecessary tests.
bc7b6697 10775
27ccc379
PE
10776 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10777
dcd5c89a
PE
10778 * composite.h, composite.c (composition_gstring_put_cache):
10779 Use EMACS_INT, not int, for length.
10780
b13a45c6
PE
10781 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10782 breaking out part of COMPOSITION_DECODE_RULE.
10783 (COMPOSITION_DECODE_RULE): Use it.
10784 * composite.c (get_composition_id): Remove unused local vars,
10785 by using the new macro.
10786
1e792e4d
PE
10787 * textprop.c (set_text_properties_1): Change while to do-while,
10788 since the condition is always true at first.
10789
dc6c6455 10790 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10791 (interval_deletion_adjustment): Return unsigned value.
10792 All uses changed.
dc6c6455 10793
aba7731a
PE
10794 * process.c (list_processes_1, create_pty, read_process_output):
10795 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10796 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10797 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10798 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10799 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10800
fdfc4bf3
PE
10801 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10802
fca8fe46 10803 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10804 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10805
06a0259a 10806 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10807 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10808 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10809
e7b9e80f
PE
10810 * print.c (print_error_message): Avoid int overflow.
10811
56201685
PE
10812 * font.c (font_list_entities): Redo for clarity,
10813 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10814
78834453 10815 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10816 (font_score): Avoid potential overflow in diff calculation.
78834453 10817
0bc0b309 10818 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10819 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10820
e610eaca
PE
10821 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10822
b895abce
PE
10823 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10824 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10825 can always succeed if overflow has undefined behavior.
10826
1f1d9321 10827 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10828 (wordify): Omit three unnecessary tests.
1f1d9321 10829
c59478bc
PE
10830 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10831 All callers changed. This avoids the need for an unused var.
10832
79b73827
PE
10833 * casefiddle.c (casify_region): Remove var that is set but not used.
10834
a4db5dfe
PE
10835 * dired.c (file_name_completion): Remove var that is set but not used.
10836
43aae36e
PE
10837 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10838
2a47c44d 10839 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10840 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10841
a37c69bf
PE
10842 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10843 Check for integer overflow on size calculations.
10844
328ab8e7
PE
10845 * buffer.c (Fprevious_overlay_change): Remove var that is set
10846 but not used.
10847
e5a2a5cb
PE
10848 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10849 Remove vars that are set but not used.
8d84a6eb 10850 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10851 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10852
a60e5f68
PE
10853 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10854
f661cb61 10855 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10856 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10857
f0397f5a
PE
10858 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10859 that are set but not used.
10860
8664db06 10861 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10862 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10863
6abdaa4a
PE
10864 * xselect.c (x_get_local_selection, x_handle_property_notify):
10865 Remove vars that are set but not used.
10866
0ce7538d 10867 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10868 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10869
9ae848fc
PE
10870 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10871 Remove var that is set but not used.
0b918413
PE
10872 (scroll_bar_windows_size): Now size_t, not int.
10873 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10874 Check for overflow.
9ae848fc 10875
a5a62657
PE
10876 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10877 (map_tty_color) [!defined MSDOS]: Likewise.
10878
5c5cdd39
PE
10879 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10880
66ebf983
PE
10881 * coding.c: Remove vars that are set but not used.
10882 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10883 All callers changed.
10884 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10885 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10886 (decode_coding_charset): Remove vars that are set but not used.
10887
1be4d761
PE
10888 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10889 that is set but not used.
10890
47553fa8
PE
10891 * print.c (print_object): Remove var that is set but not used.
10892
1f7196bf 10893 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10894 The gnulib version avoids calling malloc in the usual case,
10895 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10896 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10897 * filelock.c (current_lock_owner): Likewise.
10898 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10899 * sysdep.c: Include allocator.h, careadlinkat.h.
10900 (emacs_no_realloc_allocator): New static constant.
10901 (emacs_readlink): New function.
fdb61804
PE
10902 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10903 ../lib/careadlinkat.h.
d1fdcab7 10904
f84c17c7
SM
109052011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10906
10907 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10908 first non-nil return value).
10909
ef3862ad
JD
109102011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10911
10912 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10913 if not defined (Bug#8403).
10914
376a7006
JB
109152011-04-02 Juanma Barranquero <lekktu@gmail.com>
10916
10917 * xdisp.c (display_count_lines): Remove parameter `start',
10918 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10919 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10920 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10921 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10922 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10923 and thereabouts. All callers changed.
10924 (get_per_char_metric): Remove parameter `f', unused since
10925 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10926
6ca3801d
JM
109272011-04-02 Jim Meyering <meyering@redhat.com>
10928
10929 do not dereference NULL upon failed strdup
10930 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10931 (ns_get_family): Likewise.
10932
d8e2b5ba
JB
109332011-04-02 Juanma Barranquero <lekktu@gmail.com>
10934
10935 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10936
8c74fcbd
JD
109372011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10938
10939 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10940 later (Bug#8403).
10941
7200d79c
SM
109422011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10943
03408648 10944 Add lexical binding.
7200d79c 10945
03408648
SM
10946 * window.c (Ftemp_output_buffer_show): New fun.
10947 (Fsave_window_excursion):
10948 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10949
10950 * lread.c (lisp_file_lexically_bound_p): New function.
10951 (Fload): Bind Qlexical_binding.
10952 (readevalloop): Remove `evalfun' arg.
10953 Bind Qinternal_interpreter_environment.
10954 (Feval_buffer): Bind Qlexical_binding.
10955 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10956 Mark as dynamic.
10957 (syms_of_lread): Declare `lexical-binding'.
10958
10959 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10960
10961 * keyboard.c (eval_dyn): New fun.
10962 (menu_item_eval_property): Use it.
ca105506
SM
10963
10964 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10965
03408648
SM
10966 * fns.c (concat, mapcar1): Accept byte-code-functions.
10967
10968 * eval.c (Fsetq): Handle lexical vars.
10969 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10970 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10971 (FletX, Flet): Obey lexical binding.
10972 (Fcommandp): Handle closures.
10973 (Feval): New `lexical' arg.
10974 (eval_sub): New function extracted from Feval. Use it almost
10975 everywhere where Feval was used. Look up vars in lexical env.
10976 Handle closures.
10977 (Ffunctionp): Move from subr.el.
10978 (Ffuncall): Handle closures.
10979 (apply_lambda): Remove `eval_flags'.
10980 (funcall_lambda): Handle closures and new byte-code-functions.
10981 (Fspecial_variable_p): New function.
10982 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10983 but without exporting it to Lisp.
23aba0ea 10984
23aba0ea 10985 * doc.c (Fdocumentation, store_function_docstring):
03408648 10986 * data.c (Finteractive_form): Handle closures.
23aba0ea 10987
03408648
SM
10988 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10989 interactive spec.
ba83908c 10990
04f2d78b
CB
10991 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10992 New byte-codes.
03408648
SM
10993 (exec_byte_code): New function extracted from Fbyte_code to handle new
10994 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10995
03408648 10996 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10997
03408648 10998 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10999
e2abce01
JB
110002011-03-31 Juanma Barranquero <lekktu@gmail.com>
11001
11002 * xdisp.c (redisplay_internal): Fix prototype.
11003
63696a73 110042011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11005
63696a73 11006 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11007 (try_scrolling): Use it when setting scroll_limit.
11008 Limit scrolling to 100 screen lines.
63696a73
EZ
11009 (redisplay_window): Even when falling back on "recentering",
11010 position point in the window according to scroll-conservatively,
11011 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11012
11013 (try_scrolling): When point is above the window, allow searching
11014 as far as scroll_max, or one screenful, to compute vertical
11015 distance from PT to the scroll margin position. This prevents
11016 try_scrolling from unnecessarily failing when
11017 scroll-conservatively is set to a value slightly larger than the
11018 window height. Clean up the case of PT below the margin at bottom
11019 of window: scroll_max can no longer be INT_MAX. When aggressive
11020 scrolling is in use, don't let point enter the opposite scroll
11021 margin as result of the scroll.
11022 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11023 threshold of 100 lines for never-recentering scrolling.
11024
e4cc2dfc
JB
110252011-03-31 Juanma Barranquero <lekktu@gmail.com>
11026
11027 * dispextern.h (move_it_by_lines):
11028 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11029 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11030 (message_log_check_duplicate): Remove parameters `prev_bol' and
11031 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11032 (redisplay_internal): Remove parameter `preserve_echo_area',
11033 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11034
11035 * indent.c (Fvertical_motion):
11036 * window.c (window_scroll_pixel_based, Frecenter):
11037 Don't pass `need_y_p' to `move_it_by_lines'.
11038
1c470562
SM
110392011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11040
44f230aa
SM
11041 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11042 steal a few bits to be more compact.
11043 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11044 Remove unneeded casts.
11045
1c470562
SM
11046 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11047
888adce9
ZK
110482011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11049
11050 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11051 binding" message (bug#7967).
11052
f838ed7b
PE
110532011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11054
77861b95
PE
11055 Fix more problems found by GCC 4.6.0's static checks.
11056
de6dbc14
PE
11057 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11058 Remove unused local var.
11059
f838ed7b
PE
11060 * editfns.c (Fmessage_box): Remove unused local var.
11061
792c7b2b
PE
11062 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11063 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11064 Omit unused local vars.
c499e557 11065 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11066 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11067 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11068 Omit unused local var.
11069
ba0165e1
PE
11070 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11071 Don't assume string length fits in int.
32ad8845 11072 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11073 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11074
3c59b4c9
PE
11075 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11076 instead of alloca (Bug#8344).
11077
a3eed478 11078 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11079 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11080
eb4d412d
PE
11081 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11082
1658b401
PE
11083 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11084 concerns.
11085
11086 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11087
11088 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11089
9a2c6e05
PE
11090 * keyboard.c (syms_of_keyboard): Use the same style as later
11091 in this function when indexing through an array. This also
11092 works around GCC bug 48267.
11093
03d0a109
PE
11094 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11095
44f730c8
PE
11096 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11097
fe75f926
PE
11098 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11099 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11100
ffa8c828
PE
11101 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11102 This avoids undefined behavior on integer overflow, and is a bit
11103 more convenient anyway since it is compared to a size_t variable.
11104
c5101a77
PE
11105 Variadic C functions now count arguments with size_t, not int.
11106 This avoids an unnecessary limitation on 64-bit machines, which
11107 caused (substring ...) to crash on large vectors (Bug#8344).
11108 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11109 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11110 All variadic functions and their callers changed accordingly.
c5101a77
PE
11111 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11112 * data.c (arith_driver, float_arith_driver): Likewise.
11113 * editfns.c (general_insert_function): Likewise.
11114 * eval.c (struct backtrace.nargs, interactive_p)
11115 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11116 (funcall_lambda, mark_backtrace): Likewise.
11117 * fns.c (concat): Likewise.
11118 * frame.c (x_set_frame_parameters): Likewise.
11119 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11120 0 if not found, not -1. All callers changed.
11121
dd3f25f7
PE
11122 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11123 (stack_copy_size): Now size_t, not int.
11124 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11125
461c2ab9
JB
111262011-03-28 Juanma Barranquero <lekktu@gmail.com>
11127
11128 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11129 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11130 All callers changed.
11131
11132 * lisp.h (multibyte_char_to_unibyte):
11133 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11134 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11135 * character.h (CHAR_TO_BYTE8):
11136 * cmds.c (internal_self_insert):
11137 * editfns.c (general_insert_function):
11138 * keymap.c (push_key_description):
11139 * search.c (Freplace_match):
11140 * xdisp.c (message_dolog, set_message_1): All callers changed.
11141
f6d62986
SM
111422011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11143
11144 * keyboard.c (safe_run_hook_funcall): New function.
11145 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11146 don't set the hook to nil, but remove the offending function instead.
11147 (Qcommand_hook_internal): Remove, unused.
11148 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11149 Vcommand_hook_internal.
11150
11151 * eval.c (enum run_hooks_condition): Remove.
11152 (funcall_nil, funcall_not): New functions.
11153 (run_hook_with_args): Call each function through a `funcall' argument.
11154 Remove `cond' argument, now redundant.
11155 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11156 (Frun_hook_with_args_until_failure): Adjust accordingly.
11157 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11158
1db5b1ad
JB
111592011-03-28 Juanma Barranquero <lekktu@gmail.com>
11160
11161 * dispextern.h (string_buffer_position): Remove declaration.
11162
11163 * print.c (strout): Remove parameter `multibyte', unused since
11164 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11165
11166 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11167 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11168 All callers changed.
11169
11170 * w32.c (_wsa_errlist): Use braces for struct initializers.
11171
11172 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11173 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11174 All callers changed.
11175 (string_buffer_position): Likewise. Also, make static (it's never
11176 used outside xdisp.c).
11177 (cursor_row_p): Remove parameter `w', unused since
11178 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11179 (decode_mode_spec): Remove parameter `precision', introduced during
11180 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11181 All callers changed.
11182
5ffb62aa
JD
111832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11184
11185 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11186
461c2ab9 111872011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11188
11189 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11190 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11191 (ns_update_auto_hide_menu_bar): New functions.
11192 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11193 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11194 ns_constrain_all_frames.
11195 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11196 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11197
5c380ffb
JD
111982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11199
11200 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11201
9af30bdf
GM
112022011-03-27 Glenn Morris <rgm@gnu.org>
11203
11204 * syssignal.h: Replace RETSIGTYPE with void.
11205 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11206 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11207 Replace SIGTYPE with void everywhere.
11208 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11209 * s/template.h (SIGTYPE): Remove commented out definition.
11210
e2abce01
JB
112112011-03-26 Eli Zaretskii <eliz@gnu.org>
11212
11213 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11214 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11215
f868cd8a
JB
112162011-03-26 Juanma Barranquero <lekktu@gmail.com>
11217
59eb0929
JB
11218 * w32.c (read_unc_volume): Use parameter `henum', instead of
11219 global variable `wget_enum_handle'.
11220
11221 * keymap.c (describe_vector): Remove parameters `indices' and
11222 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11223 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11224
f868cd8a
JB
11225 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11226
11227 * keyboard.c (timer_check): Remove parameter `do_it_now',
11228 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11229 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11230 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11231
11232 * keyboard.c (read_char):
11233 * w32menu.c (w32_menu_display_help):
11234 * xmenu.c (show_help_event, menu_help_callback):
11235 Adjust calls to `show_help_echo'.
11236
11237 * gtkutil.c (xg_maybe_add_timer):
11238 * keyboard.c (readable_events):
11239 * process.c (wait_reading_process_output):
11240 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11241
11242 * insdel.c (adjust_markers_gap_motion):
11243 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11244 (gap_left, gap_right): Don't call it.
11245
2ecf6fdb
CY
112462011-03-25 Chong Yidong <cyd@stupidchicken.com>
11247
11248 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11249 incurred during fontification.
11250
6b1f9ba4
JB
112512011-03-25 Juanma Barranquero <lekktu@gmail.com>
11252
11253 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11254 (DEFVAR_PER_BUFFER): Don't pass it.
11255
11256 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11257 (scrolling_window): Don't pass it.
11258
0f4a96b5
JB
112592011-03-25 Juanma Barranquero <lekktu@gmail.com>
11260
11261 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11262
11263 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11264 and `suffix'.
11265 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11266 of variables specific to SELinux and computation of `encoded_absname'.
11267
11268 * image.c (XPutPixel): Remove unused variable `height'.
11269
11270 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11271
11272 * unexw32.c (get_section_info): Remove unused variable `section'.
11273
11274 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11275 (system_process_attributes): Remove unused variable `sess'.
11276 (sys_read): Remove unused variable `err'.
11277
11278 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11279 (w32_wnd_proc): Remove unused variable `isdead'.
11280 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11281 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11282 (x_create_tip_frame): Remove unused variable `tem'.
11283
11284 * w32inevt.c (w32_console_read_socket):
11285 Remove unused variable `no_events'.
11286
11287 * w32term.c (x_draw_composite_glyph_string_foreground):
11288 Remove unused variable `width'.
11289
1149507c
JB
112902011-03-24 Juanma Barranquero <lekktu@gmail.com>
11291
11292 * w32term.c (x_set_glyph_string_clipping):
11293 Don't pass uninitialized region to CombineRgn.
11294
9c88f339
JB
112952011-03-23 Juanma Barranquero <lekktu@gmail.com>
11296
11297 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11298 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11299 (Fx_close_connection): Remove unused variable `i'.
11300
11301 * w32font.c (w32font_draw): Return number of glyphs.
11302 (w32font_open_internal): Remove unused variable `i'.
11303 (w32font_driver): Add missing initializer.
11304
11305 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11306 (fill_in_menu): Remove unused variable `items_added'.
11307
11308 * w32term.c (last_mouse_press_frame): Remove static global variable.
11309 (w32_clip_to_row): Remove unused variable `f'.
11310 (x_delete_terminal): Remove unused variable `i'.
11311
11312 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11313 (NOTHING): Remove unused static global variable.
11314 (uniscribe_check_otf): Remove unused variable `table'.
11315 (uniscribe_font_driver): Add missing initializers.
11316
dee091a3
JD
113172011-03-23 Julien Danjou <julien@danjou.info>
11318
11319 * term.c (Fsuspend_tty, Fresume_tty):
11320 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11321 * window.c (temp_output_buffer_show):
11322 * insdel.c (signal_before_change):
11323 * frame.c (Fhandle_switch_frame):
11324 * fileio.c (Fdo_auto_save):
11325 * emacs.c (Fkill_emacs):
11326 * editfns.c (save_excursion_restore):
11327 * cmds.c (internal_self_insert):
11328 * callint.c (Fcall_interactively):
11329 * buffer.c (Fkill_all_local_variables):
11330 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11331 Use Frun_hooks.
0f4a96b5 11332 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11333 unconditionally since it does the check itself.
dee091a3 11334
2c520ab5 113352011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11336
c9c49752
PE
11337 Fix more problems found by GCC 4.5.2's static checks.
11338
8abc3f12
PE
11339 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11340 the first time through the loop, since we know p0 < p1 then.
11341 This also avoids a gcc -Wstrict-overflow warning.
11342
a2d26660
PE
11343 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11344 leading to a memory leak, possible in functions like
11345 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11346 of objects (Bug#8318).
a2d26660 11347
916c72e9
PE
11348 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11349 that could (at least in theory) be that large.
11350
19ab8a18
PE
11351 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11352 This is less likely to overflow, and avoids undefined behavior if
11353 overflow does occur. All callers changed. Use strtoul to scan
11354 for the unsigned long integer.
b7cbbd6f
PE
11355 (pint2hrstr): Simplify and tune code slightly.
11356 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11357
f0641eff
PE
11358 * scroll.c (do_scrolling): Work around GCC bug 48228.
11359 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11360
7f650bb9
PE
11361 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11362 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11363 (validate_x_resource_name): Simplify count usage.
11364 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11365
37dd57d1
PE
11366 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11367 fail (Bug#8306).
81e56e61 11368
699979fc 11369 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11370
401bf9b4
PE
11371 * process.c (Fmake_network_process): Use socklen_t, not int,
11372 where POSIX says socklen_t is required in portable programs.
11373 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11374 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11375 (Fmake_network_process, server_accept_connection):
11376 (wait_reading_process_output, read_process_output):
11377 Likewise.
11378
b93aacde
PE
11379 * process.c: Rename or move locals to avoid shadowing.
11380 (list_processes_1, Fmake_network_process):
11381 (read_process_output_error_handler, exec_sentinel_error_handler):
11382 Rename or move locals.
4dc343ee 11383 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11384 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11385 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11386 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11387 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11388
af8a867c 11389 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11390 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11391 Include tparam.h instead, since it declares them.
af8a867c
PE
11392 * cm.h (PC): Remove extern decl; tparam.h now does this.
11393 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11394 * terminfo.c: Include tparam.h, to check interfaces.
11395 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11396 (tparam): Adjust signature to match interface in tparam.h;
11397 this removes some undefined behavior. Check that outstring and len
11398 are zero, which they always are with Emacs.
11399 * tparam.h (PC, BC, UP): New extern decls.
11400
0248044d 11401 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11402 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11403
8ff096c1 11404 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11405 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11406 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11407 (ftfont_list): Remove unused local.
49eaafba
PE
11408 (get_adstyle_property, ftfont_pattern_entity):
11409 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11410 Rename locals to avoid shadowing.
8ff096c1 11411
e2be39f6
PE
11412 * xfont.c (xfont_list_family): Mark var as initialized.
11413
c9735e30
PE
11414 * xml.c (make_dom): Now static.
11415
8f5201ae
PE
11416 * composite.c (composition_compute_stop_pos): Rename local to
11417 avoid shadowing.
b246f932
PE
11418 (composition_reseat_it): Remove unused locals.
11419 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11420 (composition_update_it): Mark var as initialized.
11b61122
PE
11421 (find_automatic_composition): Mark vars as initialized,
11422 with a FIXME (Bug#8290).
8f5201ae 11423
760fbc2c
PE
11424 character.h: Rename locals to avoid shadowing.
11425 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11426 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11427 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11428 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11429 to avoid shadowing.
11430
ff08eb85
PE
11431 * textprop.c (property_change_between_p): Remove; unused.
11432
fc7bf025
PE
11433 * intervals.c (interval_start_pos): Now static.
11434
235d7abc
PE
11435 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11436
44f230aa
SM
11437 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11438 Rename locals to avoid shadowing.
3e7d6594 11439
50060332
PE
11440 * sound.c (wav_play, au_play, Fplay_sound_internal):
11441 Fix pointer signedness.
d01f234b 11442 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11443 (wav_play): Initialize a variable to 0, to prevent undefined
11444 behavior (Bug#8278).
50060332 11445
c4fc4e30
PE
11446 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11447
918436ed
PE
11448 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11449
c939f91b
PE
11450 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11451 clobbering (Bug#8298).
b9c7f648
PE
11452 * sysdep.c (sys_subshell): Likewise.
11453 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11454
6bd8c144
PE
11455 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11456 This should get cleaned up, so that child_setup has the
11457 same signature on all platforms.
11458
7710357c 11459 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11460 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11461
c59da222
CY
114622011-03-22 Chong Yidong <cyd@stupidchicken.com>
11463
11464 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11465 not to be necessary, and produces flickering.
11466
66b87493
GM
114672011-03-20 Glenn Morris <rgm@gnu.org>
11468
11469 * config.in: Remove file.
11470
45b6f6d5
JB
114712011-03-20 Juanma Barranquero <lekktu@gmail.com>
11472
11473 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11474 are now in src/globals.h.
11475 (syms_of_minibuf): Remove spurious & from previous change.
11476
cd394be1 114772011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11478
11479 * minibuf.c (completing-read-function): New variable.
11480 (completing-read-default): Rename from completing-read.
11481 (completing-read): Call completing-read-function.
11482
b14e3e21
CY
114832011-03-19 Juanma Barranquero <lekktu@gmail.com>
11484
11485 * xfaces.c (Fx_load_color_file):
11486 Read color file from absolute filename (bug#8250).
11487
f2b726e6
JB
114882011-03-19 Juanma Barranquero <lekktu@gmail.com>
11489
11490 * makefile.w32-in: Update dependencies.
11491
09f6ff02
EZ
114922011-03-17 Eli Zaretskii <eliz@gnu.org>
11493
11494 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11495
29a6015a
PE
114962011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11497
a3a6c54e
PE
11498 Fix more problems found by GCC 4.5.2's static checks.
11499
b766f867
PE
11500 * process.c (make_serial_process_unwind, send_process_trap):
11501 (sigchld_handler): Now static.
11502
be02381c
PE
11503 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11504 That way, the code declares only the vars that it needs.
11505 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11506 * s/cygwin.h (PTY_ITERATION): Likewise.
11507 * s/darwin.h (PTY_ITERATION): Likewise.
11508 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11509
57048744
PE
11510 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11511 * process.c (allocate_pty): Don't declare stb unless it's needed.
11512
7914961c 11513 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11514 (CONSTANTLIM): Remove; unused.
11515 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11516 Define only if needed.
7914961c 11517
b3967b18
PE
11518 * unexelf.c (unexec): Name an expression,
11519 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11520 Use a different way to cause a compilation error if anyone uses
11521 n rather than nn, a way that does not involve shadowing.
73366a00 11522 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11523
29a6015a
PE
11524 * deps.mk (unexalpha.o): Remove; unused.
11525
43cfc33e 11526 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11527 * unexec.h: New file.
ce701a33
PE
11528 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11529 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11530 Depend on unexec.h.
11531 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11532 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11533 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11534 Change as necessary to match prototype in unexec.h.
ce701a33 11535
01f44d5a
PE
11536 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11537 shadowing.
4f63c6bb 11538 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11539
a6670b0b
PE
11540 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11541 Rename locals to avoid shadowing.
11542
cef2010d 11543 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11544 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11545
d4d7173a
PE
11546 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11547
f08b802a
PE
11548 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11549 warning when compiling print.c.
11550
3ddb0639
PE
11551 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11552 instead of using an uninitialized var.
5ad03b97 11553 (font_sort_entities): Mark var as initialized.
3ddb0639 11554
170a2692
PE
11555 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11556
e663c700
PE
11557 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11558 pointers to constants.
89bc529a 11559 (font_parse_fcname): Remove unused vars.
7b81e2d0 11560 (font_delete_unmatched): Now static.
ea838e10 11561 (font_get_spec): Remove; unused.
13a547c6
PE
11562 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11563 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11564 Rename or move locals to avoid shadowing.
e663c700 11565
2a80c887 11566 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11567 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11568
1384fa33 11569 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11570 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11571
8b2c52e9
PE
11572 * alloc.c (mark_backtrace): Move decl from here ...
11573 * lisp.h: ... to here, so that it can be checked.
11574
475545b5 11575 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11576 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11577 (lisp_indirect_variable): Name an expression,
11578 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11579 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11580
b1349114 11581 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11582 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11583 Use const pointer when appropriate.
b1349114 11584
a2928364
PE
11585 * lisp.h (get_system_name, get_operating_system_release):
11586 Move decls here, to check interfaces.
11587 * process.c (get_operating_system_release): Move decl to lisp.h.
11588 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11589 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11590 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11591 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11592 (Fformat_time_string, Fencode_time, Finsert_char):
11593 (Ftranslate_region_internal, Fformat):
11594 Rename or remove local vars to avoid shadowing.
9710023e 11595 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11596
a415e694
PE
11597 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11598 avoid shadowing.
11599
8ef4622d
PE
11600 * lisp.h (eassert): Check that the argument compiles, even if
11601 ENABLE_CHECKING is not defined.
11602
946f9a5b
PE
11603 * data.c (Findirect_variable): Name an expression, to avoid
11604 gcc -Wbad-function-cast warning.
112396d6 11605 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11606 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11607 (Fmake_variable_buffer_local, Fmake_local_variable):
11608 Mark variables as initialized.
52746918 11609 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11610
e5aab7e7 11611 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11612 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11613 Rename locals to avoid shadowing.
dff45157
PE
11614 (mark_stack): Move local variables into the #ifdef region where
11615 they're used.
7bc26fdb
PE
11616 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11617 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11618 needed otherwise.
11619 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11620 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11621 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11622
e5aab7e7
PE
11623 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11624 avoids undefined behavior in theory.
11625
4da60324
PE
11626 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11627
88043301
PE
11628 Use functions, not macros, for up- and down-casing (Bug#8254).
11629 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11630 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11631 to use the following functions instead of these macros.
11632 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11633 EMACS_INT, since callers assume the returned value fits in int.
11634 (upcase1): Likewise, for UPCASE_TABLE.
11635 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11636 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11637 the race-condition problem in the old DOWNCASE.
88043301 11638
19ed5445
PE
11639 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11640 Rename locals to avoid shadowing.
11641 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11642 (regex_compile, re_search_2, re_match_2_internal):
11643 Remove unused local vars.
952db0d7
PE
11644 (FREE_VAR): Rewrite so as not to use empty "else",
11645 which gcc can warn about.
da053e48 11646 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11647 (RETALLOC_IF): Define only if needed.
11648 (WORDCHAR_P): Likewise. This one is never needed, but is used
11649 only in a comment talking about a compiler bug, so put inside
11650 the #if 0 of that comment.
11651 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11652 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11653 Remove; unused.
19ed5445 11654
1f3561e4 11655 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11656 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11657 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11658
ded6f8f7
PE
11659 * search.c (simple_search): Remove unused var.
11660
dbd37a95
PE
11661 * dired.c (compile_pattern): Move decl from here ...
11662 * lisp.h: ... to here, so that it can be checked.
11663 (struct re_registers): New forward decl.
11664
7e47afad
PE
11665 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11666
85f24f61
PE
11667 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11668 All uses changed.
11669 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11670 Rename locals to avoid shadowing.
5671df8f 11671 (Fvertical_motion): Mark locals as initialized.
85f24f61 11672
181aa2be 11673 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11674 (casify_region): Mark local as initialized.
181aa2be 11675
930d429c
PE
11676 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11677
7082eac6
PE
11678 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11679 New macros, so that the caller can use some names other than
11680 gcpro1, gcpro2, etc.
11681 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11682 of the new macros.
11683 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11684 argument, for consistency with GCPRO2_VAR, etc: it is now the
11685 prefix of the variable, not the variable itself. All uses
11686 changed.
38b2c076
PE
11687 * dired.c (directory_files_internal, file_name_completion):
11688 Rename locals to avoid shadowing.
11689
15206ed9
PE
11690 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11691 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11692 dired.c's scmp function, had undefined behavior.
11693 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11694 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11695 * buffer.h: ... to here, because these macros use current_buffer,
11696 and the new implementation with inline functions needs to have
11697 current_buffer in scope now, rather than later when the macros
11698 are used.
11699 (downcase, upcase1): New static inline functions.
11700 (DOWNCASE, UPCASE1): Reimplement using these functions.
11701 This avoids undefined behavior in expressions like
11702 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11703 from race conditions in accessing the global variables
11704 case_temp1 and case_temp2.
11705 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11706 * lisp.h (case_temp1, case_temp2): Remove their decls.
11707 * character.h (ASCII_CHAR_P): Move from here ...
11708 * lisp.h: ... to here, so that the inline functions mentioned
11709 above can use them.
11710
4a6bea26
PE
11711 * dired.c (directory_files_internal_unwind): Now static.
11712
f14b7e14
PE
11713 * fileio.c (file_name_as_directory, directory_file_name):
11714 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11715 Now static.
2893f146
PE
11716 (file_name_as_directory): Use const pointers when appropriate.
11717 (Fexpand_file_name): Likewise. In particular, newdir might
11718 point at constant storage, so make it a const pointer.
fd4ead52 11719 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11720 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11721 signedness issues.
f839df0c
PE
11722 (Fset_file_times, Finsert_file_contents, auto_save_error):
11723 Rename locals to avoid shadowing.
f14b7e14 11724
5716756e 11725 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11726 (Ftry_completion, Fall_completions): Rename or remove locals
11727 to avoid shadowing.
5716756e 11728
b4c3046a
PE
11729 * marker.c (bytepos_to_charpos): Remove; unused.
11730
b45db522
PE
11731 * lisp.h (verify_bytepos, count_markers): New decls,
11732 so that gcc does not warn that these functions aren't declared.
11733
85876d07
PE
11734 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11735 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11736 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11737 (copy_text): Remove unused local var.
85876d07 11738
03d78a21 11739 * filelock.c (within_one_second): Now static.
b3dd38ab 11740 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11741
5df8f01b
PE
11742 * buffer.c (fix_overlays_before): Mark locals as initialized.
11743 (fix_start_end_in_overlays): Likewise. This function should be
11744 simplified by using pointers-to-pointers, but that's a different
11745 matter.
b1d876f1 11746 (switch_to_buffer_1): Now static.
8f54f30a
PE
11747 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11748 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11749
a70072c9 11750 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11751 Fix pointer signedness issue.
edced198
PE
11752 (sys_subshell): Mark local as volatile if checking for lint,
11753 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11754 (MAXPATHLEN): Define only if needed.
a70072c9 11755
a0977c44
PE
11756 * process.c (serial_open, serial_configure): Move decls from here ...
11757 * systty.h: ... to here, so that they can be checked.
11758
a884fdcc
PE
11759 * fns.c (get_random, seed_random): Move extern decls from here ...
11760 * lisp.h: ... to here, so that they can be checked.
11761
604efe86 11762 * sysdep.c (reset_io): Now static.
b8950c94 11763 (wait_for_termination_signal): Remove; unused.
604efe86 11764
38fc62d9
PE
11765 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11766 (copy_keymap_item, append_key, push_text_char_description):
11767 Now static.
1004a21a 11768 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11769 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11770 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11771 (describe_map_tree):
11772 Rename locals to avoid shadowing.
38fc62d9 11773
2f2650da
PE
11774 * keyboard.c: Declare functions static if they are not used elsewhere.
11775 (echo_char, echo_dash, cmd_error, top_level_2):
11776 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11777 (read_char, kbd_buffer_get_event, make_lispy_position):
11778 (make_lispy_event, make_lispy_movement, apply_modifiers):
11779 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11780 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11781 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11782 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11783 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11784
a053e86c 11785 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11786 (mark_kboards): Move decl here ...
11787 * alloc.c (mark_kboards): ... from here.
a053e86c 11788
4752793e
PE
11789 * lisp.h (force_auto_save_soon): New decl.
11790
74f10ca7 11791 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11792 (DEFINE_DUMMY_FUNCTION): New macro.
11793 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11794 Use it.
c03cd23f
PE
11795 (main): Add casts to avoid warnings
11796 if GCC considers string literals to be constants.
74f10ca7 11797
022e70d4
PE
11798 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11799
59d6fe83
PE
11800 * dbusbind.c: Pointer signedness fixes.
11801 (xd_signature, xd_append_arg, xd_initialize):
11802 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11803 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11804 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11805 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11806
78320123
PE
11807 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11808 if GCC considers string literals to be constants.
49cebcca 11809 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11810
35ac2a97
SM
118112011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11812
fb103ca9
SM
11813 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11814 (print_preprocess, print_object): New macro to fix last change.
11815
35ac2a97
SM
11816 * print.c (print_preprocess): Don't forget font objects.
11817
62973b41
JB
118182011-03-16 Juanma Barranquero <lekktu@gmail.com>
11819
11820 * emacs.c (USAGE3): Doc fixes.
11821
0e48bb22
AS
118222011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11823
11824 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11825 structure.
11826
7684e57b
JB
118272011-03-14 Juanma Barranquero <lekktu@gmail.com>
11828
11829 * lisp.h (VWindow_system, Qfile_name_history):
11830 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11831 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11832 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11833
11834 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11835 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11836
11837 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11838 * w32console.c (detect_input_pending, read_input_pending)
11839 (encode_terminal_code):
11840 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11841 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11842 (w32_system_caret_y, Qfile_name_history):
11843 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11844 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11845 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11846 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11847 * w32proc.c (Qlocal, report_file_error):
11848 * w32term.c (Vwindow_system, updating_frame):
11849 * w32uniscribe.c (initialized, uniscribe_font_driver):
11850 Remove unneeded extern declarations.
11851
2aa46d6c
CY
118522011-03-14 Chong Yidong <cyd@stupidchicken.com>
11853
c96bbc66 11854 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11855
cffc6f3b
CY
118562011-03-13 Chong Yidong <cyd@stupidchicken.com>
11857
11858 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11859 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11860 These macros can no longer be used for assignment.
11861
44f230aa
SM
11862 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11863 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11864 (record_buffer_markers, fetch_buffer_markers): New functions for
11865 recording and fetching special buffer markers.
11866 (set_buffer_internal_1, set_buffer_temp): Use them.
11867
11868 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11869
11870 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11871
11872 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11873 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11874
11875 * xdisp.c (hscroll_window_tree):
11876 (reconsider_clip_changes): Use PT instead of BUF_PT.
11877
d251f04b
EZ
118782011-03-13 Eli Zaretskii <eliz@gnu.org>
11879
11880 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11881 $(EMACS_ROOT)/lib/intprops.h.
11882
f0c77cd1
PE
118832011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11884
3eca4629
PE
11885 Fix more problems found by GCC 4.5.2's static checks.
11886
7c86ee98
PE
11887 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11888 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11889 (xg_free_frame_widgets): Make it clear that a local variable is
11890 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11891 (gdk_window_get_screen): Make it clear that this macro is needed
11892 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11893 (int_gtk_range_get_value): New function, which avoids a diagnostic
11894 from gcc -Wbad-function-cast.
11895 (xg_set_toolkit_scroll_bar_thumb): Use it.
11896 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11897 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11898 (get_utf8_string, xg_get_file_with_chooser):
11899 Rename locals to avoid shadowing.
11900 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11901
41729b81
PE
11902 * xgselect.c (xg_select): Remove unused var.
11903
f0c77cd1
PE
11904 * image.c (four_corners_best): Mark locals as initialized.
11905 (gif_load): Initialize transparent_p to zero (Bug#8238).
11906 Mark another local as initialized.
ec6cf4c6 11907 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11908
ce0ad53d 11909 * image.c (clear_image_cache): Now static.
d5d5a617 11910 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11911 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11912 (x_edge_detection): Remove unnecessary cast that
11913 gcc -Wbad-function-cast diagnoses.
2037898d 11914 (gif_load): Fix pointer signedness.
6ae141d6
PE
11915 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11916 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11917
33383987 119182011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11919
d32df629
PE
11920 Improve quality of tests for time stamp overflow.
11921 For example, without this patch (encode-time 0 0 0 1 1
11922 1152921504606846976) returns the obviously-bogus value (-948597
11923 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11924 reports time overflow. See
11925 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11926 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11927 * editfns.c: Include limits.h and intprops.h.
11928 (TIME_T_MIN, TIME_T_MAX): New macros.
11929 (time_overflow): Move earlier, to before first use.
11930 (hi_time, lo_time): New functions, for an accurate test for
11931 out-of-range times.
11932 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11933 (Fget_internal_run_time): Don't assume time_t fits in int.
11934 (make_time): Use list2 instead of Fcons twice.
11935 (Fdecode_time): More accurate test for out-of-range times.
11936 (check_tm_member): New function.
11937 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11938 (lisp_time_argument): Don't rely on undefined left-shift and
11939 right-shift behavior when checking for time stamp overflow.
8be6f318 11940
fe31d94c
PE
11941 * editfns.c (time_overflow): New function, refactoring common code.
11942 (Fformat_time_string, Fdecode_time, Fencode_time):
11943 (Fcurrent_time_string): Use it.
11944
8be6f318
PE
11945 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11946 * dired.c (make_time): Move to ...
11947 * editfns.c (make_time): ... here.
11948 * systime.h: Note the move.
11949
09d9db2c 119502011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11951
126bc0dc
YM
11952 * fringe.c (update_window_fringes): Remove unused variables.
11953
c47cbdfd
YM
11954 * unexmacosx.c (copy_data_segment): Also copy __got section.
11955 (Bug#8223)
11956
7ac80be9
EZ
119572011-03-12 Eli Zaretskii <eliz@gnu.org>
11958
c96bbc66 11959 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11960 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11961 Constify `char *' arguments and their references according to
11962 prototypes in tparam.h.
11963
ecb0f94d 11964 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11965
7ac80be9
EZ
11966 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11967 Adapt all references accordingly.
11968
11969 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11970
ef1fd07e
TT
119712011-03-11 Tom Tromey <tromey@redhat.com>
11972
11973 * buffer.c (syms_of_buffer): Remove obsolete comment.
11974
7ef4b50c
EZ
119752011-03-11 Eli Zaretskii <eliz@gnu.org>
11976
11977 * termhooks.h (encode_terminal_code): Declare prototype.
11978
11979 * msdos.c (encode_terminal_code): Don't declare prototype.
11980
11981 * term.c (encode_terminal_code): Now external again, used by
11982 w32console.c and msdos.c.
11983
44f230aa
SM
11984 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11985 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11986
4b1ec863 119872011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11988
1714f52b 11989 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11990
4b1ec863
PE
11991 * fringe.c (update_window_fringes): Mark locals as initialized
11992 (Bug#8227).
11993 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11994
524c7aa6
PE
11995 * alloc.c (mark_fringe_data): Move decl from here ...
11996 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11997 to check its interface.
11998 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11999
a5c0af81 12000 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12001 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12002 (fontset_font): Mark local as initialized.
a9a06e0b 12003 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12004
b4716021
PE
12005 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12006
811e9bac 12007 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12008 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12009 (x_own_selection, Fx_disown_selection_internal): Rename locals
12010 to avoid shadowing.
12011 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12012
7e3ab302
PE
12013 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12014 so that the caller can use some name other than gcpro1.
12015 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12016 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12017 (Fx_backspace_delete_keys_p):
12018 Use them to avoid shadowing, and rename vars to avoid shadowing.
12019 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12020 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12021 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12022 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12023 Remove unused locals.
7e3ab302
PE
12024 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12025 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12026 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12027 macros.
f78faa98 12028
e2b13473
PE
12029 * xterm.h (x_mouse_leave): New decl.
12030
77f23912
PE
12031 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12032 Remove unused functions.
cdf4ba58
PE
12033 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12034 (x_calc_absolute_position): Now static.
7411c686 12035 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12036 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12037 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12038 unless they are used.
38d0b34a
PE
12039 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12040 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12041 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12042 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12043 (x_error_catcher, x_connection_closed, x_error_handler):
12044 (x_error_quitter, xembed_send_message, x_iconify_frame):
12045 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12046 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12047 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12048
44f230aa
SM
12049 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12050 Rename or move locals to avoid shadowing.
6b463e58 12051 (tty_defined_color, merge_face_heights): Now static.
5967d051 12052 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12053 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12054 does not deduce is never used uninitialized.
73719eba
PE
12055 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12056 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12057
426994c3 12058 * terminal.c (store_terminal_param): Now static.
5489860b 12059
032f1620 12060 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12061 (set_frame_menubar): Remove unused local.
d4323972 12062 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12063 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12064 since they might point to immutable storage.
281585b0
PE
12065 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12066 since it's unused otherwise.
032f1620 12067
367c19e5 12068 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12069 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12070 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12071 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12072 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12073 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12074 does not deduce are never used uninitialized.
70739cbe 12075
07b48fa9
PE
12076 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12077
8868a238 12078 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12079 * window.c (window_loop, size_window):
12080 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12081
7e5cf297 12082 * window.c (display_buffer): Now static.
d6550a9f
PE
12083 (size_window): Mark variables that gcc -Wuninitialized
12084 does not deduce are never used uninitialized.
a586633d
PE
12085 * window.h (check_all_windows): New decl, to forestall
12086 gcc -Wmissing-prototypes diagnostic.
5b555da1 12087 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12088
f6095868
PE
12089 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12090 shadowing.
12091 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12092 Include <limits.h>.
12093 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12094 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12095 (load_charset_map): Mark variables that gcc -Wuninitialized
12096 does not deduce are never used uninitialized.
53df7c11 12097 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12098
f38b440c
PE
12099 * coding.c (coding_set_source, coding_set_destination):
12100 Use "else { /* comment */ }" rather than "else /* comment */;"
12101 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12102 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12103 a block, when the outer 'i' will do.
12104 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12105 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12106 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12107 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12108 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12109 Rename locals to avoid shadowing.
12110 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12111 * coding.c (emacs_mule_char, encode_invocation_designation):
12112 Now static, since they're not used elsewhere.
413bb2db 12113 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12114 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12115 (decode_coding_emacs_mule): Mark variables that gcc
12116 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12117 (detect_coding_iso_2022): Initialize a local variable that might
12118 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12119 this initialization is needed. (Bug#8211)
5f58e762
PE
12120 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12121 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12122 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12123 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12124 Remove unused macros.
f38b440c 12125
232b38b9 12126 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12127 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12128 * character.c (string_count_byte8): Likewise.
232b38b9 12129
fb90da1b
PE
12130 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12131 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12132
fb93dbc2
PE
12133 * chartab.c (copy_sub_char_table): Now static, since it's not used
12134 elsewhere.
5c156ace
PE
12135 (sub_char_table_ref_and_range, char_table_ref_and_range):
12136 Rename locals to avoid shadowing.
bbcd0949 12137 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12138
7d3b3862 12139 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12140 (BIDI_BOB): Remove unused macro.
7d3b3862 12141
6be7d3da
PE
12142 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12143 deduce are never used uninitialized.
c2ed9c8b 12144 * term.c (encode_terminal_code): Likewise.
6be7d3da 12145
75f8807f 12146 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12147
50938595
PE
12148 * tparam.h: New file.
12149 * term.c, tparam.h: Include it.
12150 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12151 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12152 Move these decls to tparam.h, and make them agree with what
12153 is actually in tparam.c. The previous trick of using incompatible
12154 decls in different modules does not conform to the C standard.
12155 All callers of tparam changed to use tparam's actual API.
12156 * tparam.c (tparam1, tparam, tgoto):
12157 Use const pointers where appropriate.
12158
fbceeba2
PE
12159 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12160 * cm.h (struct cm): Likewise.
12161 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12162 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12163 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12164 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12165 (turn_on_face, init_tty): Likewise.
12166 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12167
7f3f1250
PE
12168 * term.c (term_mouse_position): Rename local to avoid shadowing.
12169
e6ca6543
PE
12170 * alloc.c (mark_ttys): Move decl from here ...
12171 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12172
c40f8d15
AS
121732011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12174
12175 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12176
cfe0661d
JB
121772011-03-09 Juanma Barranquero <lekktu@gmail.com>
12178
12179 * search.c (compile_pattern_1): Remove argument regp, unused since
12180 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12181 (compile_pattern): Don't pass it.
12182
0afb4571
J
121832011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12184
12185 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12186 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12187 for ! HAVE_GTK3.
12188 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12189
12190 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12191
12192 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12193 gdk_window_get_screen, gdk_window_get_geometry,
12194 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12195 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12196 (xg_get_pixbuf_from_pixmap): New function.
12197 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12198 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12199 Call xg_get_pixbuf_from_pixmap instead of
12200 gdk_pixbuf_get_from_drawable.
12201 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12202 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12203 (xg_check_special_colors): Use GtkStyleContext and its functions
12204 for HAVE_GTK3.
12205 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12206 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12207 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12208 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12209 Call gtk_widget_get_preferred_size.
0afb4571
J
12210 (xg_frame_resized): gdk_window_get_geometry only takes 5
12211 parameters.
44f230aa
SM
12212 (xg_win_to_widget, xg_event_is_for_menubar):
12213 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12214 (xg_set_widget_bg): New function.
12215 (delete_cb): New function.
895009e1 12216 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12217 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12218 (xg_set_background_color): Call xg_set_widget_bg.
12219 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12220 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12221 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12222 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12223 if ! HAVE_GTK3.
12224 (update_frame_tool_bar): Call gtk_widget_hide.
12225 (xg_initialize): Use GDK_KEY_g.
12226
12227 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12228 if ! HAVE_GTK3
12229 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12230
12231 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12232 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12233 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12234
1c2cc4ef
JB
122352011-03-08 Juanma Barranquero <lekktu@gmail.com>
12236
12237 * w32xfns.c (select_palette): Check success of RealizePalette against
12238 GDI_ERROR, not zero.
12239
33383987 12240See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12241
12242;; Local Variables:
12243;; coding: utf-8
aac0c6e3
MR
12244;; End:
12245
2f097256 12246 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12247
12248 This file is part of GNU Emacs.
12249
12250 GNU Emacs is free software: you can redistribute it and/or modify
12251 it under the terms of the GNU General Public License as published by
12252 the Free Software Foundation, either version 3 of the License, or
12253 (at your option) any later version.
12254
12255 GNU Emacs is distributed in the hope that it will be useful,
12256 but WITHOUT ANY WARRANTY; without even the implied warranty of
12257 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12258 GNU General Public License for more details.
12259
12260 You should have received a copy of the GNU General Public License
12261 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.