Auto-commit of loaddefs files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b6f67890
MR
12011-11-16 Martin Rudalics <rudalics@gmx.at>
2
3 * window.h (window): Rename slot "nest" to "combination_limit".
4 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5 (Fset_window_nest): Rename to Fset_window_combination_limit.
6 (Vwindow_nest): Rename to Vwindow_combination_limit.
7 (recombine_windows, make_parent_window, make_window)
8 (Fsplit_window_internal, saved_window)
9 (Fset_window_configuration, save_window_save): Rename all
10 occurrences of window_nest to window_combination_limit.
11
c7015153
JB
122011-11-15 Juanma Barranquero <lekktu@gmail.com>
13
14 * image.c (imagemagick_load_image): Fix typo.
15
322ad6ec
EZ
162011-11-14 Eli Zaretskii <eliz@gnu.org>
17
18 * xdisp.c (display_line): Move the call to
19 highlight_trailing_whitespace before the call to
20 compute_line_metrics, since the latter needs to see the final
21 faces of all the glyphs to compute ROW's hash value. Fixes
22 assertion violations in row_equal_p. (Bug#10035)
23
f067b8ec
JB
242011-11-14 Juanma Barranquero <lekktu@gmail.com>
25
26 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
27 just return (bug#10044).
28
1e5b2111
EZ
292011-11-12 Eli Zaretskii <eliz@gnu.org>
30
7ef3cbd5
EZ
31 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
32 with user-defined heap size. Bump the default size of the temacs
33 heap to 27MB, to avoid memory warning when running temacs.
34 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
35
1e5b2111
EZ
36 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
37 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
38 (verify_row_hash) [XASSERTS]: New function.
39 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
40 that the hash value of glyph rows is correct.
1e5b2111 41
89d61221
MR
422011-11-12 Martin Rudalics <rudalics@gmx.at>
43
44 * window.h (window): Remove splits slot.
45 * window.c (Fwindow_splits, Fset_window_splits): Remove.
46 (Fdelete_other_windows_internal, make_parent_window)
47 (make_window, Fsplit_window_internal, Fdelete_window_internal)
48 (Fset_window_configuration, save_window_save): Don't deal with
49 split status of windows.
50 (saved_window): Remove splits slot.
51 (Vwindow_splits): Rewrite doc-string.
52
97f18cc8
JD
532011-11-11 Jan Djärv <jan.h.d@swipnet.se>
54
55 * xfns.c (unwind_create_frame):
56 * nsfns.m (unwind_create_frame):
57 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
58 Vframe_list (Bug#9999).
59
22a648b4
DA
602011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
61
0b381c7e 62 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 63
659afede
KH
642011-11-11 Kenichi Handa <handa@m17n.org>
65
66 * callproc.c (Fcall_process): Set the member dst_multibyte of
67 process_coding.
68
9ac0394b
KH
692011-11-11 Johan Bockgård <bojohan@gnu.org>
70
71 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
72 avoid a crash (bug#9496).
73
2fbdc249
CY
742011-11-09 Chong Yidong <cyd@gnu.org>
75
76 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
77 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
78
ac6b1f81
PE
792011-11-08 Paul Eggert <eggert@cs.ucla.edu>
80
81 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
82
09db192c
PE
832011-11-08 Paul Eggert <eggert@cs.ucla.edu>
84
85 Avoid some portability problems by eschewing 'extern inline' functions.
86 The trivial performance wins aren't worth the portability hassles; see
87 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
88 et seq.
89 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
90 (window_box_width, window_box_left, window_box_left_offset)
91 (window_box_right, window_box_right_offset): Undo previous change,
92 by removing the "extern"s.
93 * intervals.c (adjust_intervals_for_insertion)
94 (adjust_intervals_for_deletion): Undo previous change,
95 making these static again.
96 (offset_intervals, temp_set_point_both, temp_set_point)
97 (copy_intervals_to_string): No longer inline.
98 * xdisp.c (window_text_bottom_y, window_box_width)
99 (window_box_height, window_box_left_offset)
100 (window_box_right_offset, window_box_left, window_box_right)
101 (window_box): No longer inline.
102
105216ed
CY
1032011-11-08 Chong Yidong <cyd@gnu.org>
104
105 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
106 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
107 an error if not a live window.
108 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
109 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
110
ae9e237f
JB
1112011-11-07 Juanma Barranquero <lekktu@gmail.com>
112
113 * lisp.h (syms_of_abbrev): Remove declaration.
114 Reported by CHENG Gao <chenggao@royau.me>.
115
c7aa8333
EZ
1162011-11-07 Eli Zaretskii <eliz@gnu.org>
117
118 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
119 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
120 of temacs in GUI mode.
121
be7f5545
MR
1222011-11-07 Martin Rudalics <rudalics@gmx.at>
123
124 * window.h: Declare delete_all_child_windows instead of
125 delete_all_subwindows.
126 * window.c (Fwindow_nest, Fset_window_nest)
127 (Fset_window_new_total, Fset_window_new_normal)
128 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
129 (delete_all_subwindows): Rename to delete_all_child_windows.
130 (Fdelete_other_windows_internal, Fset_window_configuration):
131 Call delete_all_child_windows instead of delete_all_subwindows.
132 * frame.c (delete_frame): Call delete_all_child_windows instead
133 of delete_all_subwindows.
134
ca78dc43
PE
1352011-11-07 Paul Eggert <eggert@cs.ucla.edu>
136
137 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
138 This is also needed for porting to any host where GC_MARK_STACK is
139 not GC_MAKE_GCPROS_NOOPS.
140 (which_symbols): Use it.
141
a0241d01
KH
1422011-11-07 Kenichi Handa <handa@m17n.org>
143
144 * coding.c (coding_set_destination): Check coding->src_pos only
145 when coding->src_object is a buffer (bug#9910).
146
147 * process.c (send_process): Set the member src_multibyte of coding
148 to 0 (bug#9911) when sending a unibyte text.
149
150 * callproc.c (Fcall_process): Set the member src_multibyte of
151 process_coding to 0 (bug#9912).
152
a64bfdfa 1532011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
154
155 * xmenu.c (cleanup_widget_value_tree): New function.
156 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
157 calling free_menubar_widget_value_tree directly (Bug#9830).
158
cb41b32a
PE
1592011-11-06 Paul Eggert <eggert@cs.ucla.edu>
160
161 Fix some portability problems with 'inline'.
162 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
163 (window_box_width, window_box_left, window_box_left_offset)
164 (window_box_right, window_box_right_offset): Declare extern.
165 Otherwise, these inline functions do not conform to C99 and
166 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
167 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
168 * intervals.c (adjust_intervals_for_insertion)
169 (adjust_intervals_for_deletion): Now extern, because otherwise the
170 extern inline functions 'offset_intervals' couldn't refer to it.
171 (static_offset_intervals): Remove.
172 (offset_intervals): Rewrite using the old contents of
173 static_offset_intervals. The old version didn't conform to C99
174 because an extern inline function contained a reference to an
175 identifier with static linkage.
176
b7041366
AS
1772011-11-06 Andreas Schwab <schwab@linux-m68k.org>
178
179 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
180 GC.
181
88a37c4d
EZ
1822011-11-06 Eli Zaretskii <eliz@gnu.org>
183
184 * xdisp.c (init_iterator, reseat_to_string): Don't set the
185 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
186 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
187 return Qleft_to_right.
188
49745b39
CY
1892011-11-06 Chong Yidong <cyd@gnu.org>
190
191 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
192 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
193 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
194 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
195 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
196 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
197 (Fwindow_vscroll): Doc fix.
198 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
199 argument, since it makes no sense to pass a live window and for
200 consistency with window-child.
201
1f05cd82
CS
2022011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
203
204 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
205 support MSVC.
206
22610910
JR
2072011-11-05 Jason Rumney <jasonr@gnu.org>
208
209 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
210 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
211 fonts (Bug#6029).
212 (add_font_entity_to_list): Fix logic errors in mixed boolean and
213 bitwise arithmetic preventing use of unicode-sip and non-truetype
214 opentype fonts.
215
a06776b2
EZ
2162011-11-05 Eli Zaretskii <eliz@gnu.org>
217
3ad924ba
EZ
218 * s/ms-w32.h (fstat, stat, utime): Move redirections to
219 "emacs"-only part.
220
a06776b2
EZ
221 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
222 initialization code to keep similarity to xfns.c after changes
223 from 2011-11-05.
224
c9e7db78
JD
2252011-11-05 Jan Djärv <jan.h.d@swipnet.se>
226
a97f8f3f
JD
227 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
228 (unwind_create_frame): New function (Bug#9943).
229 (Fx_create_frame): Restructure code to be more similar to the one in
230 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
231 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
232 Move terminal->reference_count++ just before making the frame official
233 (Bug#9943).
234
235 * nsterm.m (x_free_frame_resources): New function.
236 (x_destroy_window): Move code to x_free_frame_resources.
237
c9e7db78
JD
238 * xfns.c (unwind_create_frame): Fix comment.
239 (Fx_create_frame, x_create_tip_frame): Move
240 terminal->reference_count++ just before making the frame
241 official. Move initialization of image_cache_refcount and
242 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
243
a6fc3b5c
EZ
2442011-11-05 Eli Zaretskii <eliz@gnu.org>
245
246 Support MSVC build with newer versions of Visual Studio.
247 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
248 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
249 nt/gmake.defs.
250
251 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
252 which are not supported by MSVC.
253 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
254 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
255 bitfields.
256 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
257 types in bitfields.
258 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
259
260 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
261
2622011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
263
264 Support MSVC build with newer versions of Visual Studio.
265 * w32.c: Don't include w32api.h for MSVC.
266 (init_environment) [_MSC_VER]: Call sys_access, not _access.
267
268 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
269 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
270 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
271 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
272 e_* cousins.
273 (alloca) [_MSC_VER]: Define to _alloca.
274
275 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
276
277 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
278
a58c13ed
EZ
2792011-11-04 Eli Zaretskii <eliz@gnu.org>
280
281 * xdisp.c (note_mouse_highlight): If either of
282 previous/next-single-property-change returns nil, treat that as
283 the beginning or the end of the buffer. (Bug#9955)
284
fe0b6370
JD
2852011-11-04 Jan Djärv <jan.h.d@swipnet.se>
286
a58c13ed 287 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
288 label is not null (Bug#9951).
289 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
290 may be NULL.
291
89bd5ee1
EZ
2922011-11-04 Eli Zaretskii <eliz@gnu.org>
293
294 * window.c (Fwindow_body_size): Mention in the doc string that the
295 return value is in frame's canonical units. (Bug#9949)
296
84c3edb9
EZ
2972011-11-03 Eli Zaretskii <eliz@gnu.org>
298
4e2fb5c7
EZ
299 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
300
84c3edb9 301 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 302 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 303 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 304
bc17a887
EZ
3052011-11-01 Eli Zaretskii <eliz@gnu.org>
306
307 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
308 Don't stop backward scan on the continuation glyph, even though
309 its CHARPOS is positive.
26b46e51
EZ
310 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
311 cover_string to disp_string.
bc17a887 312
4ee88440
MR
3132011-11-01 Martin Rudalics <rudalics@gmx.at>
314
315 * window.c (temp_output_buffer_show): Don't use
316 Vtemp_buffer_show_specifiers.
317 (Vtemp_buffer_show_specifiers): Remove unused variable.
318
c2ff3c02
EZ
3192011-10-30 Eli Zaretskii <eliz@gnu.org>
320
321 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
322 past the beginning of the current glyph matrix.
323
6e56383b
JD
3242011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
325
326 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
327 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
328 HAVE_GTK3 (Bug#9869).
b77a6a7f 329
3b574623
JD
330 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
331 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
332
b77a6a7f
JD
333 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
334
335 * xterm.c: Declare x_handle_net_wm_state to return int.
336 (handle_one_xevent): Check if we are iconified but don't have
337 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
338 (get_current_wm_state): Return non-zero if not hidden,
339 check for _NET_WM_STATE_HIDDEN (Bug#9893).
340 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
341 (x_handle_net_wm_state): Return what get_current_wm_state returns.
342 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
343
196e41e4
PE
3442011-10-29 Paul Eggert <eggert@cs.ucla.edu>
345
346 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
347 so that this new function doesn't get optimized away by a
348 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
349
021f2e1a
AS
3502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
351
352 * frame.h (MOUSE_HL_INFO): Remove excess parens.
353
8b058d44
EZ
3542011-10-29 Eli Zaretskii <eliz@gnu.org>
355
356 Fix the `xbytecode' command.
357 * .gdbinit (xprintbytestr): New command.
358 (xwhichsymbols): Renamed from `which'; all callers changed.
359 (xbytecode): Print the byte-code string as well.
360
4452fb80
EZ
3612011-10-29 Kim Storm <storm@cua.dk>
362
8b058d44
EZ
363 * alloc.c (which_symbols): New function.
364
21b72067
AS
3652011-10-29 Andreas Schwab <schwab@linux-m68k.org>
366
367 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
368 line. (Bug#9903)
369
83ed7b5c
GM
3702011-10-29 Glenn Morris <rgm@gnu.org>
371
372 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
373 Not clear what it was for, and it causes various bugs. (Bug#9839)
374
5a7a728b
EZ
3752011-10-28 Eli Zaretskii <eliz@gnu.org>
376
377 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
378 possible random value that matches one of those tested as
379 condition to clear the mouse face.
380
d3d0842f
CY
3812011-10-28 Chong Yidong <cyd@gnu.org>
382
383 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
384
31b39d13
DN
3852011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
386
387 * window.c (make_window): Initialize phys_cursor_on_p.
388
9aba6043
SM
3892011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
390
391 * lisp.h (struct Lisp_Symbol): Update comments.
392
c20992f4
JB
3932011-10-28 Juanma Barranquero <lekktu@gmail.com>
394
395 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
396
db4f02f2
EZ
3972011-10-28 Eli Zaretskii <eliz@gnu.org>
398
399 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
400 <oslsachem@gmail.com> for helping to debug this.
401
402 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
403 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
404 (g_b_init_get_glyph_outline_w): New static variables.
405 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
406 (GetGlyphOutlineW_Proc): New typedefs.
407 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
408 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
409 New functions.
410 (w32font_open_internal, compute_metrics):
411 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
412 instead of calling the "wide" APIs directly.
413
414 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
415
416 * w32.h (syms_of_w32font): Add prototype.
417
87e68db4
JB
4182011-10-27 Juanma Barranquero <lekktu@gmail.com>
419
420 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
421 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
422 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
423 (Fmove_to_window_line): Doc fix.
424
435c1d67
CY
4252011-10-27 Chong Yidong <cyd@gnu.org>
426
427 * process.c (make_process): Set gnutls_state to NULL.
428
429 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
430 non-NULL, regardless of GNUTLS_INITSTAGE.
431 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
432 an error. Set process slots as soon as we allocate them.
433
434 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
435
9c6c6f49
CY
4362011-10-27 Chong Yidong <cyd@gnu.org>
437
9aba6043
SM
438 * gnutls.c (emacs_gnutls_deinit): New function.
439 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
440 (Fgnutls_deinit, Fgnutls_boot): Use it.
441
442 * process.c (make_process): Initialize GnuTLS credentials to NULL.
443 (deactivate_process): Call emacs_gnutls_deinit.
444
657d08d3
JB
4452011-10-27 Juanma Barranquero <lekktu@gmail.com>
446
447 * image.c (x_create_x_image_and_pixmap):
448 * w32.c (sys_rename, w32_delayed_load):
449 * w32font.c (fill_in_logfont):
450 * w32reg.c (x_get_string_resource): Silence compiler warnings.
451
5430d399
JB
4522011-10-26 Juanma Barranquero <lekktu@gmail.com>
453
454 * w32fns.c (w32_default_color_map): New function,
455 extracted from Fw32_default_color_map.
a7ef684b 456 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 457
fe0055fa
PE
4582011-10-25 Paul Eggert <eggert@cs.ucla.edu>
459
460 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
461
e6346438
SM
4622011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
463
464 * keyboard.c (test_undefined): New function (bug#9751).
465 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
466
e112cc37
ET
4672011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
468
469 * sysdep.c (init_sys_modes): Fix the check for the controlling
470 terminal (Bug#6649).
471
7b5d6677
EZ
4722011-10-20 Eli Zaretskii <eliz@gnu.org>
473
474 * dispextern.h (struct bidi_it): New member next_en_type.
475
476 * bidi.c (bidi_line_init): Initialize the next_en_type member.
477 (bidi_resolve_explicit_1): When next_en_pos is valid for the
478 current character, check also for next_en_type being WEAK_EN.
479 (bidi_resolve_weak): Don't enter the expensive loop if the current
480 position is before next_en_pos. Record the bidi type of the first
481 non-ET, non-BN character we find, in addition to its position.
482 (bidi_level_of_next_char): Invalidate next_en_type when
483 next_en_pos is over-stepped.
484
7da0b018
PE
4852011-10-20 Paul Eggert <eggert@cs.ucla.edu>
486
487 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
488 * editfns.c: Rewrite current-time-zone so that it invokes
489 the equivalent of (format-time-string "%Z") to get the time zone name.
490 This fixes a bug when the time zone name contains characters that
491 need converting from the system time locale to Emacs internal format.
492 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
493 that patch fixed format-time-string to do the conversion, but
494 I forgot to fix current-time-zone.
495 (format_time_string): New function, containing most of
496 what Fformat_time_string used to contain.
497 (Fformat_time_string): Rewrite in terms of format_time_string.
498 This doesn't change this function's behavior.
499 (current-time-zone): Rewrite to use format_time_string.
500 This fixes the bug reported by Michael Schierl in
501 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
502 Jason Rumney's 2007-06-07 change worked around this bug, but
503 didn't fix it.
504 * systime.h (tzname, timezone): Remove no-longer-used declarations.
505
8547b010
EZ
5062011-10-19 Eli Zaretskii <eliz@gnu.org>
507
508 * xdisp.c (start_display): If the character at POS is displayed
509 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
510 (try_window_reusing_current_matrix): If a line ends in a display
511 vector or the next line starts in a display vector, continue
512 redrawing the window even though the character position of
513 start_row was reached.
8547b010
EZ
514 (Bug#9771, part 2)
515
4e948d15
CY
5162011-10-18 Chong Yidong <cyd@gnu.org>
517
518 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
519 with nobreak-char-display too.
520
4787455f
EZ
5212011-10-18 Eli Zaretskii <eliz@gnu.org>
522
523 Fix part 3 of bug#9771.
524 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
525 (bidi_resolve_neutral): Don't enter the expensive loop looking for
526 non-neutral characters if the current character is a paragraph
527 separator (a.k.a. Newline). This avoids running the same
528 expensive loop twice, once when we consume the preceding newline
529 and the other time when the line actually needs to be displayed.
530 Avoid the loop when we see neutrals on the base embedding level
531 following a character whose directionality is the same as the
532 paragraph's. This avoids running the expensive loop when a line
533 ends in a long sequence of neutrals, like control characters.
534 Add assertion against STRONG_AL type. Slightly rearrange code
535 that determines the type of a neutral given the first non-neutral
536 that follows it.
537 (bidi_level_of_next_char): Set next_en_pos to zero when
538 invalidating its info.
539
2c91f553
EZ
5402011-10-17 Eli Zaretskii <eliz@gnu.org>
541
542 * xdisp.c (push_display_prop): Determine whether to record string
543 or buffer position by IT->string, not by IT->method. Allow
544 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
545 (move_it_vertically_backward): Don't look for character position
546 immediately after the newline when in a continuation line.
547 (Bug#9771, part 1)
2c91f553 548
c7b08b0d
MR
5492011-10-15 Martin Rudalics <rudalics@gmx.at>
550
551 * window.c (coordinates_in_window): Rewrite and delabelize
552 vertical border check. (Bug#5357) (Bug#9618)
553
6b02f655
SM
5542011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
555
556 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
557 errors in XSetWindowBorder (bug#9310).
558
81d40c92
DA
5592011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
560
561 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
562 avoid crash when xmalloc overrun checking is enabled.
563
d4172c3b
EZ
5642011-10-13 Eli Zaretskii <eliz@gnu.org>
565
566 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
567 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
568 cursor motion with <left> and <right> arrow keys.
569
570 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
571 some callers set that themselves.
572
b00eea75
EZ
5732011-10-12 Eli Zaretskii <eliz@gnu.org>
574
575 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
576 display string and the previous row comes from the same string and
577 is empty. (Bug#9739) (Bug#9738)
578
8fe012c4
SM
5792011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
580
581 * doc.c (get_doc_string): Encode file name (bug#9735).
582
0074aef2
EZ
5832011-10-12 Eli Zaretskii <eliz@gnu.org>
584
79beb178
EZ
585 * bidi.c (bidi_level_of_next_char):
586 * xdisp.c (get_visually_first_element): Remove old incorrect
587 comments regarding the Unicode Line Separator character.
588
0074aef2
EZ
589 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
590
6e4b3fbe
DA
5912011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
592
593 * alloc.c (Fgc_status): Do not access beyond zombies array
594 boundary if nzombies > MAX_ZOMBIES.
595 * alloc.c (dump_zombies): Add missing format specifier.
596
0324f3af
PE
5972011-10-12 Paul Eggert <eggert@cs.ucla.edu>
598
b5525cac
PE
599 * xdisp.c (set_cursor_from_row): Simplify conditionals,
600 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
601
0324f3af
PE
602 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
603 Some packages use them to denote characters with modifiers.
604
e9b5f888
AS
6052011-10-11 Andreas Schwab <schwab@linux-m68k.org>
606
607 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
608 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
609 matching a pp-number. Rename parameter var to var1.
610
127827c0
SM
6112011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
612
613 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
614
c8fd3bd0
GM
6152011-10-08 Glenn Morris <rgm@gnu.org>
616
617 * callint.c (Fcall_interactively): Give a more explicit error for the
618 'c' case with a non-character input. (Bug#8479)
619
352ec8ff
EZ
6202011-10-08 Eli Zaretskii <eliz@gnu.org>
621
03669ccb
EZ
622 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
623 lines.
7061c986
EZ
624 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
625 lines that are hscrolled on the left.
03669ccb 626
352ec8ff
EZ
627 * dispnew.c (buffer_posn_from_coords): Account for a possible
628 presence of header-line. (Bug#4426)
629
a66cfb1c
SM
6302011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
631
6b02f655
SM
632 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
633 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 634
7c5ee88e
PE
6352011-10-07 Paul Eggert <eggert@cs.ucla.edu>
636
637 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
638 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
639 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
640 this makes Emacs dump core during garbage collection on rare
641 occasions. sizeof is obviously inferior to offsetof here, so
642 stick with offsetof.
643 (GC_POINTER_ALIGNMENT): New macro.
644 (mark_memory): Omit 3rd (offset) arg; caller changed.
645 Don't assume EMACS_INT alignment is the same as pointer alignment.
646
df1bbe5b
SM
6472011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
648
649 * keyboard.c (read_key_sequence_remapped): New var.
650 (read_key_sequence): Compute remapping in the right buffer.
651 (command_loop_1): Use read_key_sequence's remapping directly.
652
51553db6
SM
6532011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
654
32c1fffd
SM
655 * dired.c (file_name_completion): Don't expand file name.
656 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
657 before checking file name handler.
658
51553db6
SM
659 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
660 they've been requested explicitly (bug#9591).
661
b6bd1599 6622011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
663
664 * keymap.c (Fsingle_key_description): Use make_specified_string
665 instead of build_string to build string from push_key_description.
666 (Bug#5193)
667
f701dc2a
PE
6682011-09-30 Paul Eggert <eggert@cs.ucla.edu>
669
4222c55d
PE
670 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
671 This fixes a Y2038 bug on 64-bit hosts.
672 * buffer.c (reset_buffer):
673 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
674 (Fclear_buffer_auto_save_failure):
675 Use 0, not -1, to represent an unset failure time, since time_t
676 might not be signed.
677
f701dc2a
PE
678 Remove dependency on glibc malloc internals.
679 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
680 Move back here from lisp.h, but with their new implementations.
681 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
682 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
683 * charset.c (charset_table_init): New static var.
684 (syms_of_charset): Use it instead of xmalloc. This removes a
685 dependency on glibc malloc internals. See Eli Zaretskii's comment in
686 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
687 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
688 Move back to alloc.c.
689 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
690 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
691
9ceebf39
JD
6922011-09-30 Jan Djärv <jan.h.d@swipnet.se>
693
694 * nsterm.m (windowDidResize): Call x_set_window_size only when
695 ns_in_resize is true. Otherwise set pixelwidth/height and
696 call change_frame_size (Bug#9628).
697
cb993c58
PE
6982011-09-30 Paul Eggert <eggert@cs.ucla.edu>
699
3930c88b
PE
700 Port --enable-checking=all to Fedora 14 x86-64.
701 * charset.c (syms_of_charset): Also account for glibc malloc's
702 internal overhead when calculating the initial malloc maximum.
703
cb993c58
PE
704 Port --enable-checking=all to Fedora 14 x86.
705 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
706 Move to lisp.h.
707 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
708 (overrun_check_realloc, overrun_check_free):
709 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
710 That way, xmalloc returns a properly-aligned pointer even if
711 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
712 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
713 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
714 into account when calculating the initial malloc maximum.
715 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
716 Move here from alloc.c, so that charset.c can use it too.
717 Properly align; the old code wasn't right for common 32-bit hosts
718 when configured with --enable-checking=all.
719 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
720 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
721
31bed486
EZ
7222011-09-29 Eli Zaretskii <eliz@gnu.org>
723
04c70788 724 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
725 use EDOM.
726
fbcaa2f3
EZ
7272011-09-28 Eli Zaretskii <eliz@gnu.org>
728
729 * xdisp.c (compute_display_string_end): If there's no display
730 string at CHARPOS, return -1.
731
732 * bidi.c (bidi_fetch_char): When compute_display_string_end
733 returns a negative value, treat the character as a normal
734 character not covered by a display string. (Bug#9624)
735
a239d4e9
JB
7362011-09-28 Juanma Barranquero <lekktu@gmail.com>
737
738 * lread.c (Fread_from_string): Fix typo in docstring.
739
88652fd5
EZ
7402011-09-27 Eli Zaretskii <eliz@gnu.org>
741
742 * xdisp.c (handle_invisible_prop): If invisible text ends on a
743 newline, reseat the iterator instead of bidi-iterating there one
744 character at a time. (Bug#9610)
32c1fffd
SM
745 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
746 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 747
ed497dd4
AS
7482011-09-27 Andreas Schwab <schwab@linux-m68k.org>
749
750 * lread.c (readevalloop): Use correct code for NBSP.
751 (read1): Likewise. (Bug#9608)
752
b2bf61aa
MA
7532011-09-25 Michael Albinus <michael.albinus@gmx.de>
754
755 * dbusbind.c (Fdbus_register_signal): When service is not
756 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
757
32bbb17c
GM
7582011-09-25 Glenn Morris <rgm@gnu.org>
759
760 * buffer.c (truncate-lines): Doc fix.
761
94e0933e
CY
7622011-09-24 Chong Yidong <cyd@stupidchicken.com>
763
764 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
765 (Fset_window_next_buffers): Doc fix.
766
cddde921
GM
7672011-09-24 Glenn Morris <rgm@gnu.org>
768
769 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
770
1260aef1
PE
7712011-09-24 Paul Eggert <eggert@cs.ucla.edu>
772
25b4bfa0
PE
773 Fix minor problems found by static checking.
774 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
775 * indent.c (Fvertical_motion): Fix == vs = typo.
776
e3cbd34b
EZ
7772011-09-24 Eli Zaretskii <eliz@gnu.org>
778
a66cfb1c
SM
779 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
780 Default value is now t. Doc fix.
6bf7006f 781
e3cbd34b 782 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 783 logic when moving up, not only when moving down. Fix the
e3cbd34b 784 confusing name and values of the it_overshoot_expected variable;
32c1fffd 785 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
786
787 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
788 CHARPOS is covered by a display string which includes newlines.
789 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
790 is covered by a display string with embedded newlines.
791
a3de0cbd
MA
7922011-09-24 Michael Albinus <michael.albinus@gmx.de>
793
794 * dbusbind.c (Fdbus_register_signal): Add match rule to
795 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
796 (Fdbus_register_method, Vdbus_registered_objects_table):
797 Fix docstring.
a3de0cbd 798
b260039d
JM
7992011-09-24 Jim Meyering <meyering@redhat.com>
800
32c1fffd 801 do not ignore write error for any output size
b260039d
JM
802 The previous change was incomplete.
803 While it makes emacs --batch detect the vast majority of stdout
804 write failures, errors were still ignored whenever the output size is
805 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
806 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
807 && echo FAIL: ignored write error
808 FAIL: ignored write error
809 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
810 && echo FAIL: ignored write error
811 FAIL: ignored write error
812 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
813
8eca8a7c
AS
8142011-09-23 Andreas Schwab <schwab@linux-m68k.org>
815
816 * emacs.c (Fkill_emacs): In noninteractive mode exit
817 non-successfully if a write error occurred on stdout. (Bug#9574)
818
3341db62
EZ
8192011-09-21 Eli Zaretskii <eliz@gnu.org>
820
821 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
822 the xassert test.
823
824 * dispextern.h (struct it): Update the comment documenting what
825 can it->OBJECT be.
826
8c203dbf
EZ
8272011-09-20 Eli Zaretskii <eliz@gnu.org>
828
829 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
830 a display string, extend search for cursor position to end of row.
831 (find_row_edges): If the row ends in a newline from a display
832 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
833 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
834 (Fcurrent_bidi_paragraph_direction): Fix search for previous
835 non-empty line. Fixes confusing cursor motion with arrow keys at
836 the beginning of a line that starts with whitespace.
8c203dbf 837
a4824228
LMI
8382011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
839
840 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
841 (bug#9493).
842
33ed493b
CY
8432011-09-18 Chong Yidong <cyd@stupidchicken.com>
844
845 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
846 boolean (Bug#9154).
847
56cd55c8
EZ
8482011-09-18 Eli Zaretskii <eliz@gnu.org>
849
850 * xdisp.c (display_line): Record maximum and minimum buffer
851 positions even if no glyphs were produced (e.g., by a zero-width
852 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
853 buffer positions that will be removed from the glyph row because
854 they don't fit.
c02dcedf
EZ
855 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
856 column is beyond frame width: don't subtract 1 "pixel" when
857 computing width of the stretch.
3e62b7e0
EZ
858 (reseat_at_next_visible_line_start): Undo the change made on
859 2011-09-17 that saved paragraph information and restored it after
860 the call to `reseat'. (Bug#9545)
56cd55c8 861
5ed99d36 8622011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
863
864 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
865 and turn window cursor on if cleared (Bug#9415).
866
5ed99d36 8672011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
868
869 * search.c (boyer_moore): Take unibyte characters from pattern
870 literally. (Bug#9458)
871
9bade7b2
EZ
8722011-09-18 Eli Zaretskii <eliz@gnu.org>
873
874 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
875
e5e9d610
PE
8762011-09-18 Paul Eggert <eggert@cs.ucla.edu>
877
87e4427a
PE
878 Fix minor problem found by static checking.
879 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
880 initialized, to pacify gcc -Wuninitialized.
881
e5e9d610
PE
882 * fileio.c: Report proper errno when syscall falls.
883 (Finsert_file_contents): Save and restore errno,
884 so that report_file_error outputs the correct diagnostic.
885 (Fwrite_region) [CLASH_DETECTION]: Likewise.
886
a1674f0b
EZ
8872011-09-18 Eli Zaretskii <eliz@gnu.org>
888
889 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
890
fbfb6dd4
EZ
8912011-09-17 Eli Zaretskii <eliz@gnu.org>
892
893 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
894 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
895
bb187662
EZ
8962011-09-17 Eli Zaretskii <eliz@gnu.org>
897
1137e8b8 898 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 899 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
900
901 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
902 (bidi_find_paragraph_start): Search back for paragraph beginning
903 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
904 (bidi_move_to_visually_next): Only trigger paragraph-related
905 computations when the last character is a newline or at EOB, not
906 just any NEUTRAL_B. (Bug#9470)
907
bb187662
EZ
908 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
909 truncated lines if point is covered by a display string. (Bug#9524)
910
2e621251
PE
9112011-09-16 Paul Eggert <eggert@cs.ucla.edu>
912
913 * xselect.c: Relax test for outgoing X longs (Bug#9498).
914 (cons_to_x_long): New function.
915 (lisp_data_to_selection_data): Use it. Correct the test for
916 short-versus-long data; it was negated. Break out of vector
917 loop, for efficiency, when a long datum is discovered.
918
91a15bc6
SM
9192011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
920
921 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
922
b41c3a35
EZ
9232011-09-16 Eli Zaretskii <eliz@gnu.org>
924
925 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
926 GCC PR/17406) by declaring this function with external scope.
927
7812ba2d
PE
9282011-09-15 Paul Eggert <eggert@cs.ucla.edu>
929
930 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
931 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
932
cf7edc2a
AS
9332011-09-15 Andreas Schwab <schwab@linux-m68k.org>
934
935 * editfns.c (Fformat): Correctly handle text properties on "%%".
936
bd01620e
EZ
9372011-09-15 Eli Zaretskii <eliz@gnu.org>
938
939 * xterm.c (x_draw_composite_glyph_string_foreground):
940 * w32term.c (x_draw_composite_glyph_string_foreground):
941 * term.c (encode_terminal_code):
942 * composite.c (composition_update_it, get_composition_id):
943 * xdisp.c (get_next_display_element)
944 (fill_composite_glyph_string): Add comments about special meaning
945 of TAB characters in a composition.
946
a02719a3
PE
9472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
948
949 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
950 This occurs when processing a multibyte format.
951 Problem reported by Wolfgang Jenker.
a02719a3 952
72589a3c
JB
9532011-09-15 Johan Bockgård <bojohan@gnu.org>
954
955 * xdisp.c (try_cursor_movement): Only check for exact match if
956 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
957
1c14176c
PE
9582011-09-14 Paul Eggert <eggert@cs.ucla.edu>
959
960 Remove unused external symbols.
961 * dispextern.h (calc_pixel_width_or_height): Remove decl.
962 * xdisp.c (calc_pixel_width_or_height): Now static.
963 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
964 * indent.c (check_display_width):
965 * w32term.c: Fix comment to match code.
966 * xterm.c, xterm.h (x_catching_errors): Remove.
967
d2eea5b5
PE
9682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
969
970 * xselect.c: Use signed conversions more consistently (Bug#9498).
971 (selection_data_to_lisp_data): Assume incoming selection data are
972 signed integers, not unsigned. This is to be consistent with
973 outgoing selection data, which was modified to use signed integers
974 in as part of the fix to Bug#9196 in response to Jan D.'s comment
975 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
976 expects long, not unsigned long.
977
46888499
EZ
9782011-09-14 Eli Zaretskii <eliz@gnu.org>
979
980 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
981 computation of loop end. Reported by Johan Bockgård
982 <bojohan@gnu.org>.
983
ef8ef9fb
CY
9842011-09-13 Chong Yidong <cyd@stupidchicken.com>
985
986 * frame.c (Fother_visible_frames_p): Function deleted.
987
fa819fed
EZ
9882011-09-12 Eli Zaretskii <eliz@gnu.org>
989
990 * indent.c (compute_motion): Process display vector front to back
991 rather than the other way around. (Bug#2496)
992
2ba8e008
SM
9932011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
994
995 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
996
20f53c69
CY
9972011-09-11 Chong Yidong <cyd@stupidchicken.com>
998
999 * minibuf.c (Fread_from_minibuffer): Doc fix.
1000
d562d7a4
EZ
10012011-09-11 Eli Zaretskii <eliz@gnu.org>
1002
1003 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1004 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1005
1c4d7f3d
LMI
10062011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1007
1008 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1009 value for non-existent files.
1010
b885bf36
EZ
10112011-09-11 Eli Zaretskii <eliz@gnu.org>
1012
1013 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1014 set its "size" to -1. This will set the modtime_size field of
1015 the corresponding buffer to -1, which is what
1016 verify-visited-file-modtime expects for files that do not exist.
1017 (Bug#9139)
1018
6612f0bf
PE
10192011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1022 here ...
1023 * lisp.h: ... from here. push_key_description is no longer
1024 defined in keyboard.c, so its declaration should not be in
1025 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1026 logically belongs with push_key_description.
1027
dfb3f755
PE
10282011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1029
1030 * buffer.h: Include <sys/types.h> instead of <time.h>.
1031 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1032 Problem reported by Herbert J. Skuhra.
1033
3134906c
LMI
10342011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1035
1036 * xml.c (parse_region): Make the parsing work for
1037 non-comment-starting XML files again (bug#9144).
1038
8d903f4e
AS
10392011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1040
1041 * image.c (gif_load): Fix calculation of bottom and right corner.
1042 (Bug#9468)
1043
80ad64f4
EZ
10442011-09-10 Eli Zaretskii <eliz@gnu.org>
1045
1046 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1047 redisplay in small windows.
1048
208a048d
EZ
10492011-09-09 Eli Zaretskii <eliz@gnu.org>
1050
1051 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1052
9b1c252e
MR
10532011-09-08 Martin Rudalics <rudalics@gmx.at>
1054
1055 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1056 Operate on live windows only.
1057
2949f33b
JB
10582011-09-08 Juanma Barranquero <lekktu@gmail.com>
1059
1060 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1061
e08dcafd
EZ
10622011-09-07 Eli Zaretskii <eliz@gnu.org>
1063
1064 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1065 only under bidi iteration.
1066
115b96bd
JD
10672011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1068
1069 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1070
c8199d0f
PE
10712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1074 Without this fix, the command to link temacs failed due to an
1075 undefined symbol __builtin_isnan. This is because
1076 /usr/include/iso/math_c99.h #defines isnan(x) to
1077 __builtin_isnan(x), but the bundled gcc, which identifies itself
1078 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1079 a __builtin_isnan.
1080 * floatfns.c (isnan): #undef, and then #define to a clone of
1081 what's in data.c.
1082 (Fisnan): Always define, since it's always available now.
1083 (syms_of_floatfns): Always define isnan at the Lisp level.
1084
e39b275c 10852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1086
1087 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1088
b2db44d9 10892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1090
f4af5137 1091 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1092 The previous code assumed that file offsets (off_t values) fit in
1093 EMACS_INT variables, which is not true on typical 32-bit hosts.
1094 The code messed up by falsely reporting buffer overflow in cases
1095 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1096 when "big" contains more than 2**29 bytes, even though this
1097 inserts just one byte and does not overflow the buffer.
1098 (Finsert_file_contents): Store file offsets as off_t
1099 values, not as EMACS_INT values. Check for overflow when
1100 converting between EMACS_INT and off_t. When checking for
1101 buffer overflow or for overlap, take the offsets into account.
1102 Don't use EMACS_INT for small values where int suffices.
1103 When checking for overlap, fix a typo: ZV was used where
1104 ZV_BYTE was intended.
1105 (Fwrite_region): Don't assume off_t fits into 'long'.
1106 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1107
ecfc0a49
MA
11082011-09-05 Michael Albinus <michael.albinus@gmx.de>
1109
1110 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1111
6511acf2 11122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1113
0999621a 1114 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1115
1116 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1117 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1118 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1119 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1120 (modify_event_symbol): Do not assume that the length of
1121 name_alist_or_stem is safe to alloca and fits in int.
1122 (Fexecute_extended_command): Likewise for function name and binding.
1123 (Frecursion_depth): Wrap around reliably on integer overflow.
1124 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1125 since some callers pass EMACS_INT values.
1126 (Fsingle_key_description): Don't crash if symbol name contains more
1127 than MAX_ALLOCA bytes.
1128 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1129 (get_minibuffer): Arg is now EMACS_INT, not int.
1130 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1131 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1132 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1133
2be7d702
PE
1134 * dbusbind.c (signature_cat): New function.
1135 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1136 Do not overrun buffer; instead, report string overflow.
1137
9d1df220
PE
1138 * dispnew.c (add_window_display_history): Don't overrun buffer.
1139 Truncate instead; this is OK since it's just a log.
1140
33ef5c64
PE
1141 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1142 even if the time zone offset is outlandishly large.
1143 Don't mishandle offset == INT_MIN.
1144
66c6fdd5
PE
1145 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1146 when creating daemon; the previous buffer-overflow check was incorrect.
1147
d749b01b
PE
1148 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1149 which has the guts of the old verror function.
1150
b5cd1905
PE
1151 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1152 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1153
6e1a67fb
PE
1154 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1155 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1156 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1157 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1158 length of string rather than counting it via multiple sprintfs;
1159 that's simpler and more reliable.
c21721cc
PE
1160 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1161 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1162 sprintf, in case result does not fit in int.
1163
c57b67fc
PE
1164 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1165 (fontset_from_font): Print it.
1166
8a401434
PE
1167 * frame.c (tty_frame_count): Now printmax_t, not int.
1168 (make_terminal_frame, set_term_frame_name): Print it.
1169 (x_report_frame_params): In X, window IDs are unsigned long,
1170 not signed long, so print them as unsigned.
1171 (validate_x_resource_name): Check for implausibly long names,
1172 and don't assume name length fits in 'int'.
1173 (x_get_resource_string): Don't blindly alloca invocation name;
1174 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1175 not fit in int.
1176
6e1a67fb
PE
1177 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1178 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1179 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1180
0df02bf3
PE
1181 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1182 Use esprintf, not sprintf, in case result does not fit in int.
1183
48e30793
PE
1184 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1185 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1186 it as a large positive number.
1187 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1188 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1189
a66ff6d8
PE
1190 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1191 in case result does not fit in int.
1192
aca216ff
PE
1193 * print.c (float_to_string): Detect width overflow more reliably.
1194 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1195 buffer overrun. Don't assume list length fits in 'int'. Treat
1196 print length of 0 as 0, not as infinity; to be consistent with other
1197 uses of print length in this function. Don't overflow print length
1198 index. Don't assume hash table size fits in 'long', or that
1199 vectorlike size fits in 'unsigned long'.
1200
31c286f7
PE
1201 * process.c (make_process): Use printmax_t, not int, to format
1202 process-name gensyms.
1203
55e5faa1
PE
1204 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1205
80f2e268
PE
1206 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1207 to avoid potential buffer overrun.
1208
670741ab
PE
1209 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1210 if X resource line is longer than 512 bytes.
1211
b7163a50
PE
1212 * xfns.c (x_window): Make sprintf buffer a bit bigger
1213 to avoid potential buffer overrun.
1214
ae58ff1f
PE
1215 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1216
c43c8a6a
PE
1217 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1218
3f8236f4
PE
12192011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1220
53e9fe90 1221 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1222 Without these, Emacs silently mishandles large integers sometimes.
1223 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1224 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1225
6511acf2
PE
1226 * xdisp.c (try_window_id): Check Emacs fixnum range before
1227 converting to 'int'.
806add1d 1228
6511acf2 1229 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1230 Check that an Emacs fixnum is in range before assigning it to 'int'.
1231 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1232 values converted from Emacs fixnums.
1233 (Frecenter): Don't wrap around a line count if it is out of 'int'
1234 range; instead, treat it as an extreme value.
1235 (Fset_window_configuration, compare_window_configurations):
1236 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1237
6511acf2
PE
1238 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1239 that can exceed INT_MAX. Check that EMACS_INT value is in range
1240 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1241 (match_limit): Don't assume that a fixnum can fit in 'int'.
1242
6511acf2 1243 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1244 exceed INT_MAX.
1245
6511acf2 1246 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1247 (Fvertical_motion): Don't wrap around LINES values that don't fit
1248 in 'int'. Instead, treat them as extreme values. This is good
1249 enough for windows, which can't have more than INT_MAX lines anyway.
1250
fcb901a7
LMI
12512011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1252
0f2f6b6d
LMI
1253 * Require libxml/parser.h to avoid compilation warning.
1254
fcb901a7
LMI
1255 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1256
1257 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1258 since this reportedly can destroy thread storage.
1259
6e20a0d4
CY
12602011-08-30 Chong Yidong <cyd@stupidchicken.com>
1261
1262 * syntax.c (find_defun_start): Update all cache variables if
1263 exiting early (Bug#9401).
1264
148ae00e
EZ
12652011-08-30 Eli Zaretskii <eliz@gnu.org>
1266
f6cfbd8f
EZ
1267 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1268
148ae00e
EZ
1269 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1270 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1271 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1272
1273 * term.c (tty_append_glyph): New function.
1274 (produce_stretch_glyph): Static function and its prototype deleted.
1275
a66cfb1c
SM
1276 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1277 Add prototypes.
148ae00e 1278
c4a07a4c
PE
12792011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1280
1281 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1282 when checking :margin (Bug#9390).
1283 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1284 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1285 so that the name doesn't mislead. All uses changed.
1286
6bc8cd65
JB
12872011-08-28 Johan Bockgård <bojohan@gnu.org>
1288
1289 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1290 set_tty_hooks.
1291
dca4927e
EZ
12922011-08-27 Eli Zaretskii <eliz@gnu.org>
1293
1294 * xdisp.c (move_it_to): Don't bail out early when reaching
1295 position beyond to_charpos, if we are scanning backwards.
1296 (move_it_vertically_backward): When DY == 0, make sure we get to
1297 the first character in the line after the newline.
1298
f2cad773
PE
12992011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1300
1301 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1302 (ccl_driver): Do not generate an out-of-range pointer.
1303 (Fccl_execute_on_string): Remove unnecessary check for
1304 integer overflow, noted by Stefan Monnier in
1305 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1306 Remove a FIXME that didn't need fixing.
1307 Simplify the newly-introduced buffer reallocation code.
1308
0cae2cdb
JB
13092011-08-27 Juanma Barranquero <lekktu@gmail.com>
1310
1311 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1312
5fc295a4 13132011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1314
70c60eb2 1315 Integer and memory overflow issues (Bug#9196).
726e0ab1 1316
d31850da
PE
1317 * doc.c (get_doc_string): Rework so that
1318 get_doc_string_buffer_size is the actual buffer size, rather than
1319 being 1 less than the actual buffer size; this makes xpalloc more
1320 convenient.
1321
a69fbedb
PE
1322 * image.c (x_allocate_bitmap_record, cache_image):
1323 * xselect.c (Fx_register_dnd_atom):
1324 Simplify previous changes by using xpalloc.
1325
fe5c5d37
PE
1326 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1327 since either will do and ptrdiff_t is convenient with xpalloc.
1328
0065d054
PE
1329 * charset.c (charset_table_size)
1330 (struct charset_sort_data.priority): Now ptrdiff_t.
1331 (charset_compare): Don't overflow if priorities differ greatly.
1332 (Fsort_charsets): Don't assume list length fits in int.
1333 Check for size-calculation overflow when allocating sort data.
1334 (syms_of_charset): Allocate an initial charset table that is
1335 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1336
1337 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1338
1339 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1340 The actual value is always <= INT_MAX, and leaving it unsigned made
1341 overflow checking harder.
1342
1343 * dispextern.h (struct glyph_matrix.rows_allocated)
1344 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1345 with xpalloc. The values are still always <= INT_MAX.
1346
1347 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1348
1349 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1350 (SAFE_NALLOCA): New macro.
1351
1352 * region-cache.c (struct boundary.pos, find_cache_boundary)
1353 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1354 (set_cache_region, invalidate_region_cache)
1355 (revalidate_region_cache, know_region_cache, region_cache_forward)
1356 (region_cache_backward, pp_cache):
1357 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1358 so that ptrdiff_t * can be passed to xpalloc.
1359 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1360 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1361 (pp_cache): Don't assume cache_len fits in int.
1362 * region-cache.h: Adjust extern decls to match.
1363
1364 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1365 EMACS_INT, since either will do, for xpalloc.
1366
1367 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1368 (xnmalloc, xnrealloc, xpalloc): New functions.
1369
726e0ab1
PE
1370 * bidi.c (bidi_shelve_header_size): New constant.
1371 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1372 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1373
51f30bc5 1374 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1375 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1376 (overlay_strings):
1377 Don't update size of array until after memory allocation succeeds,
1378 because xmalloc/xrealloc may not return.
0065d054
PE
1379 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1380 now that we have proper integer overflow checking.
1381 (record_overlay_string, overlay_strings): Catch overflows when
1382 calculating size of overlay_str_buf.
726e0ab1 1383
0065d054
PE
1384 * callproc.c (Fcall_process): Check for size overflow when
1385 calculating size of args2.
1386 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1387 Normally we prefer signed values, but sticking with ptrdiff_t would
1388 require adding more-complicated checks.
726e0ab1
PE
1389
1390 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1391 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1392 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1393 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1394
1395 * character.c (Fstring): Check for size-calculation overflow.
1396
1397 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1398 unnecessary integer overflow. Check for size overflow.
1399 (encode_coding_object): Don't update size until xmalloc succeeds.
1400
1401 * composite.c (get_composition_id): Check for overflow in glyph
1402 length calculations.
1403
1404 Integer and memory overflow fixes for display code.
1405 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1406 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1407 (scrolling_window): Check for overflow in size calculations.
1408 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1409 Don't assume glyph table len fits in int.
1410 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1411 (row_table_size): Now ptrdiff_t, not int.
1412 (scrolling_window): Avoid overflow in size calculations.
1413 Don't update size until allocation succeeds.
1414 * fns.c (concat): Check for overflow in size calculations.
1415 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1416 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1417 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1418
1419 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1420 (get_doc_string): Check for size calculation overflow.
1421 Don't update size until allocation succeeds.
1422 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1423 EMACS_INT, where ptrdiff_t will do.
1424 (Fsubstitute_command_keys): Check for string overflow.
1425
1426 * editfns.c (set_time_zone_rule): Don't assume environment length
1427 fits in int.
1428 (message_length): Now ptrdiff_t, not int.
1429 (Fmessage_box): Don't update size until allocation succeeds.
1430 Don't assume message length fits in int.
1431 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1432
0065d054
PE
1433 * emacs.c (main): Do not reallocate argv, since there is a null at
1434 the end that can be overwritten, and this way there's no need to
1435 worry about size-calculation overflow.
1436 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1437
1438 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1439 alloc succeeds.
1440 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1441
1442 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1443 (x_set_scroll_bar_width, x_figure_window_size):
1444 Check for integer overflow.
1445 (x_set_alpha): Do not assume XINT fits in int.
1446
1447 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1448 This is for the members text_lines, text_cols, total_lines, total_cols,
1449 where the system imposes an 'int' limit.
1450
1451 * fringe.c (Fdefine_fringe_bitmap):
1452 Don't update size until alloc works.
1453
1454 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1455 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1456
1457 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1458 Check for size-calculation overflow.
1459 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1460 do, as we prefer signed integers.
1461 (id_to_widget.max_size, id_to_widget.used)
1462 (xg_store_widget_in_map, xg_remove_widget_from_map)
1463 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1464 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1465 Use and return ptrdiff_t, not int.
1466 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1467 * gtkutil.h: Change prototypes to match the above.
1468
1469 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1470 are duplicate now that they've been promoted to lisp.h.
1471 (x_allocate_bitmap_record, x_alloc_image_color)
1472 (make_image_cache, cache_image, xpm_load):
1473 Don't update size until alloc is done.
1474 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1475 (x_detect_edges):
3256efce 1476 Check for size calculation overflow.
726e0ab1
PE
1477 (ct_colors_allocated_max): New constant.
1478 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1479 overflow.
3256efce 1480
726e0ab1
PE
1481 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1482 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1483 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1484 Use ptrdiff_t, not int, to count maps.
1485 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1486 calculations. Don't update size until allocation succeeds.
1487 Redo calculations to avoid overflow.
726e0ab1
PE
1488 * keyboard.h: Change prototypes to match the above.
1489
1490 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1491 to count maps.
1492 (current_minor_maps): Check for size calculation overflow.
1493 * keymap.h: Change prototypes to match the above.
1494
1495 * lread.c (read1, init_obarray): Don't update size until alloc done.
1496
1497 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1498 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1499
726e0ab1
PE
1500 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1501 Now ptrdiff_t, not int.
1502 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1503 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1504
1505 * process.c (Fnetwork_interface_list): Check for overflow
1506 in size calculation.
1507
1508 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1509
1510 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1511 overflow. Don't bother calling xmalloc when xrealloc will do.
1512
1513 * search.c (Freplace_match): Check for size calculation overflow.
1514 (Fset_match_data): Don't assume list lengths fit in 'int'.
1515
1516 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1517 for command line length. Do not attempt to address one before the
1518 beginning of an array, as that's not portable.
1519
1520 * term.c (max_frame_lines): Remove; unused.
1521 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1522 not int.
1523 (encode_terminal_code, calculate_costs): Check for size
1524 calculation overflow.
1525 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1526 table lengths and related sizes. Don't update size until alloc
1527 done. Redo calculations to avoid overflow.
1528 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1529
1530 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1531 subtracting pointers.
1532 (gobble_line): Check for overflow more carefully. Don't update size
1533 until alloc done.
1534
1535 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1536 Don't update size until alloc done.
1537 Redo size calculations to avoid overflow.
1538 Check for size calculation overflow.
0065d054 1539 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1540
1541 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1542 Use ptrdiff_t, not int, for sizes.
1543 (store_mode_line_noprop_char): Don't update size until alloc done.
1544
0065d054
PE
1545 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1546 Use ptrdiff_t, not int, for sizes.
1547 (Finternal_make_lisp_face, cache_face):
1548 Check for size calculation overflow.
1549 (cache_face): Treat size calculation overflows as if they were
1550 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1551
1552 * xfns.c (x_encode_text, x_set_name_internal)
1553 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1554 sizes, since they can exceed INT_MAX in size. Check for size
1555 calculation overflow.
1556
0065d054
PE
1557 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1558 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1559 Don't update size until alloc done.
1560
0065d054 1561 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1562 as sprintf is limited to int lengths.
1d526e2f 1563
252c5ee1
PE
1564 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1565 (X_LONG_MIN): New macros.
864d7ce7
PE
1566 Use them to make the following changes clearer.
1567 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1568 This change doesn't affect the value now, but it may help remind
1569 future maintainers not to raise the value too much later.
1570 (SELECTION_QUANTUM): Remove, replacing with ...
1571 (selection_quantum): ... new function, which avoids overflow.
1572 All uses changed.
1573 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1574 assumption that selection length fits in 'int'.
1575 (x_reply_selection_request, x_handle_selection_request)
1576 (x_get_window_property, receive_incremental_selection)
1577 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1578 (lisp_data_to_selection_data, clean_local_selection_data):
1579 Use ptrdiff_t, not int, to record length of selection.
1580 (x_reply_selection_request, x_get_window_property)
1581 (receive_incremental_selection, x_property_data_to_lisp):
1582 Redo calculations to avoid overflow.
1583 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1584 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1585 something.
1586 (x_get_window_property, receive_incremental_selection)
1587 (lisp_data_to_selection_data, x_property_data_to_lisp):
1588 Check for size-calculation overflow.
1589 (x_get_window_property, receive_incremental_selection)
1590 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1591 Don't store size until memory allocation succeeds.
1592 (x_get_window_property): Plug memory leak on memory exhaustion.
1593 Don't double-block input; malloc is safe here. Don't assume 2**34
1594 - 4 fits in unsigned long. Add an xassert to check
1595 XGetWindowProperty overflow. Be more careful about overflow
1596 calculations, and distinguish size from memory overflow better.
1597 (receive_incremental_selection): When tracing, don't assume
1598 unsigned int is less than INT_MAX.
1599 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1600 harmful) conversions of unsigned short to int.
1601 (lisp_data_to_selection_data): Don't assume that integers
1602 in the range -65535 through -1 fit in an X unsigned short.
1603 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1604 result parameters unless successful. Rely on cons_to_unsigned
1605 to report problems with elements; the old code wasn't right anyway.
1606 (x_check_property_data): Check for int overflow; we cannot use
1607 a wider type due to X limits.
1608 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1609
726e0ab1 1610 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1611
0065d054
PE
1612 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1613 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1614 (x_color_cells): Don't store size until memory allocation succeeds.
1615 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1616 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1617 (x_term_init): Don't assume length fits in int (sprintf is limited
1618 to int size).
bc18e09d 1619
ebfa62c0
PE
1620 Use ptrdiff_t for composition IDs.
1621 * character.c (lisp_string_width):
1622 * composite.c (composition_table_size, n_compositions)
1623 (get_composition_id, composition_gstring_from_id):
1624 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1625 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1626 * window.c (Frecenter):
1627 Use ptrdiff_t, not int, for composition IDs.
1628 * composite.c (get_composition_id): Check for integer overflow.
1629 * composite.h: Adjust prototypes to match the above changes.
1630
d3411f89
PE
1631 Use ptrdiff_t for hash table indexes.
1632 * category.c (hash_get_category_set):
1633 * ccl.c (ccl_driver):
1634 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1635 * coding.c (coding_system_charset_list, detect_coding_system):
1636 * coding.h (struct coding_system.id):
1637 * composite.c (get_composition_id, gstring_lookup_cache):
1638 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1639 * image.c (xpm_get_color_table_h):
1640 * lisp.h (hash_lookup, hash_put):
1641 * minibuf.c (Ftest_completion):
1642 Use ptrdiff_t for hash table indexes, not int (which is too
1643 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1644 32-bit --with-wide-int hosts).
1645
e097a6fa
PE
1646 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1647 Add a FIXME comment about memory leaks.
1648 (syms_of_charset): Don't assume xmalloc returns.
1649
5637687f
PE
1650 Don't assume that stated character widths fit in int.
1651 * character.c (Fchar_width, c_string_width, lisp_string_width):
1652 * character.h (CHAR_WIDTH):
1653 * indent.c (MULTIBYTE_BYTES_WIDTH):
1654 Use sanitize_char_width to avoid undefined and/or bad behavior
1655 with outlandish widths.
a66cfb1c 1656 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1657 now that we have two such functions. All uses changed.
1658 (sanitize_char_width): New inline function.
1659
a2271ba2
PE
1660 Don't assume that tab-width fits in int.
1661 * character.h (sanitize_width): New inline function.
1662 (SANE_TAB_WIDTH): New macro.
1663 (ASCII_CHAR_WIDTH): Use it.
1664 * indent.c (sane_tab_width): Remove. All uses replaced by
1665 SANE_TAB_WIDTH (current_buffer).
1666 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1667
18c52557
PE
1668 * fileio.c: Integer overflow issues with file modes.
1669 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1670
caeeedc1
PE
1671 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1672 Remove unreachable code.
1673 (read_hex, load_charset_map_from_file): Check for integer overflow.
1674
50849c52
PE
1675 * xterm.c: don't go over XClientMessageEvent limit
1676 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1677 (x_send_scroll_bar_event): Likewise. Check that the size does not
1678 exceed limits imposed by XClientMessageEvent, as well as the usual
1679 ptrdiff_t and size_t limits.
1680
b13995db
PE
1681 * keyboard.c: Overflow, signedness and related fixes.
1682 (make_lispy_movement): Use same integer type in forward decl
1683 that is used in the definition.
1684 (read_key_sequence, keyremap_step):
1685 Change bufsize argument back to int, undoing my 2011-03-30 change.
1686 We prefer signed types, and int is wide enough here.
1687 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1688 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1689 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1690 length, not size_t. Use ptrdiff_t for index, not int.
1691 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1692 possibility of integer overflow.
1693
13464394
PE
1694 Overflow, signedness and related fixes for images.
1695
1696 * dispextern.h (struct it.stack[0].u.image.image_id)
1697 (struct_it.image_id, struct image.id, struct image_cache.size)
1698 (struct image_cache.used, struct image_cache.ref_count):
1699 * gtkutil.c (update_frame_tool_bar):
1700 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1701 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1702 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1703 * nsmenu.m (update_frame_tool_bar):
1704 * xdisp.c (calc_pixel_width_or_height):
1705 * xfns.c (image_cache_refcount):
1706 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1707 on typical 64-bit hosts.
1708
1709 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1710 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1711 Omit unnecessary casts to int.
1712 (parse_image_spec): Check that integers fall into 'int' range
1713 when the callers expect that.
1714 (image_ascent): Redo ascent calculation to avoid int overflow.
1715 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1716 (lookup_image): Remove unnecessary tests.
1717 (xbm_image_p): Locals are now of int, not EMACS_INT,
1718 since parse_image_check makes sure they fit into int.
1719 (png_load, gif_load, svg_load_image):
1720 Prefer int to unsigned where either will do.
1721 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1722 old tiff_error_handler and tiff_warning_handler.
1723 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1724 stack buffer overflows. It uses only the features of vsnprintf
1725 that are common to both POSIX and native Microsoft.
1726 (tiff_error_handler, tiff_warning_handler): Use it.
1727 (tiff_load, gif_load, imagemagick_load_image):
1728 Don't assume :index value fits in 'int'.
1729 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1730 (imagemagick_load_image): Check that crop parameters fit into
1731 the integer types that MagickCropImage accepts. Don't assume
1732 Vimagemagick_render_type has a nonnegative value. Don't assume
1733 size_t fits in 'long'.
1734 (gs_load): Use printmax_t to print the widest integers possible.
1735 Check for integer overflow when computing image height and width.
1736
c11821d4
EZ
17372011-08-26 Eli Zaretskii <eliz@gnu.org>
1738
1739 * xdisp.c (redisplay_window): Don't force window start if point
1740 will be invisible in the resulting window. (Bug#9324)
1741
0c95fcf7
EZ
17422011-08-25 Eli Zaretskii <eliz@gnu.org>
1743
1744 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1745 the display spec is of the form `(space ...)'.
1746 (handle_display_spec): Return the value returned by
1747 handle_single_display_spec, not just 1 or zero.
1748 (handle_single_display_spec): If the display spec is of the form
1749 `(space ...)', and specifies display in the text area, return 2
1750 rather than 1.
fee65a97 1751 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1752 accurately, and prefer exact match for point under bidi.
1753 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1754
1755 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1756 into disp_prop; all users changed.
1757
1758 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1759 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1760 for the text covered by the display property.
1761
e4ed06f1
CY
17622011-08-25 Chong Yidong <cyd@stupidchicken.com>
1763
1764 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1765 Change return value to nil.
1766 (Frecord_buffer): Delete unused function.
1767
f67cdd7f
EZ
17682011-08-24 Eli Zaretskii <eliz@gnu.org>
1769
5980d4c6
EZ
1770 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1771 buffers, return left-to-right.
8610fe8b
EZ
1772 (set_cursor_from_row): Consider candidate row a win if its glyph
1773 represents a newline and point is on that newline. Fixes cursor
1774 positioning on the newline at EOL of R2L text within L2R
1775 paragraph, and vice versa.
1776 (try_cursor_movement): Check continued rows, in addition to
1777 continuation rows. Fixes unwarranted scroll when point enters a
1778 continued line of R2L text within an L2R paragraph, or vice versa.
1779 (cursor_row_p): Consider the case of point being equal to
1780 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1781 from the end of a short line to the beginning of a continued line
1782 of R2L text within L2R paragraph.
1783 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1784 composed characters.
5980d4c6 1785
f67cdd7f
EZ
1786 * bidi.c (bidi_check_type): Use xassert.
1787 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1788 members.
1789
bca633fb
EZ
17902011-08-23 Eli Zaretskii <eliz@gnu.org>
1791
1792 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1793 a character.
1794
4a5885a7
CY
17952011-08-23 Chong Yidong <cyd@stupidchicken.com>
1796
1797 * nsfont.m (ns_otf_to_script): Fix typo.
1798
0902a04e
KH
17992011-08-22 Kenichi Handa <handa@m17n.org>
1800
1801 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1802 extra slot even if the purpose is char-code-property-table.
1803
1a2e6670
EZ
18042011-08-23 Eli Zaretskii <eliz@gnu.org>
1805
8ddde651
EZ
1806 * xdisp.c (redisplay_window): When computing centering_position,
1807 account for the height of the header line. (Bug#8874)
1808
425cc014
EZ
1809 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1810 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1811 candidate is selected by the mouse, and that candidate has a
1812 composed character under the mouse.
1813
1a2e6670
EZ
1814 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1815 coordinates reported by pos-visible-in-window-p for a composed
1816 character in column zero.
1817
8b76d6f8
SM
18182011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1819
1820 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1821
dac347dd
EZ
18222011-08-22 Eli Zaretskii <eliz@gnu.org>
1823
1824 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1825 consider it a hit if to_charpos is anywhere in the range of the
1826 composed buffer positions.
1827
e013fb34
CY
18282011-08-22 Chong Yidong <cyd@stupidchicken.com>
1829
1830 * image.c (gif_load): Don't assume that each subimage has the same
1831 dimensions as the base image. Handle disposal method that is
1832 "undefined" by the gif spec (Bug#9335).
1833
bd1ba3e8
CY
18342011-08-20 Chong Yidong <cyd@stupidchicken.com>
1835
1836 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1837 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1838
54a1215b
EZ
18392011-08-19 Eli Zaretskii <eliz@gnu.org>
1840
823564e5
EZ
1841 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1842 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1843 from an Org mode buffer to a Speedbar frame.
1844
54a1215b
EZ
1845 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1846 a composition, take its buffer position from IT->cmp_it.charpos.
1847 Fixes cursor positioning at the beginning of a line that begins
1848 with a composed character.
1849
9778ebcc
EZ
18502011-08-18 Eli Zaretskii <eliz@gnu.org>
1851
0be6ee06
EZ
1852 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1853 character bidirectional type, use STRONG_L instead. Fixes crashes
1854 in a buffer produced by `describe-categories'.
1855
9778ebcc
EZ
1856 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1857 members before the level stack, so they would be saved and
1858 restored when copying iterator state. Fixes incorrect reordering
1859 around TABs covered by display properties.
1860
156bffbe
AS
18612011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1862
6b02f655 1863 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1864
72ad093b
CY
18652011-08-17 Chong Yidong <cyd@stupidchicken.com>
1866
1867 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1868 (internal_condition_case_2, internal_condition_case_n):
1869 Remove unnecessary aborts (Bug#9081).
72ad093b 1870
35774242
EZ
18712011-08-17 Eli Zaretskii <eliz@gnu.org>
1872
1873 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1874 has no `load' handler, try opening the file locally. (Bug#9311)
1875
db76dd85
KB
18762011-08-16 Ken Brown <kbrown@cornell.edu>
1877
1878 * gmalloc.c: Expand comment.
1879
b215eee5
EZ
18802011-08-16 Eli Zaretskii <eliz@gnu.org>
1881
1882 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1883 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1884
a4579d33
KB
18852011-08-16 Ken Brown <kbrown@cornell.edu>
1886
1887 Fix memory allocation problems in Cygwin build (Bug#9273).
1888
1889 * unexcw.c ( __malloc_initialized): Declare external variable.
1890 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1891
8b76d6f8
SM
1892 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1893 New variables.
a4579d33
KB
1894 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1895 dumped emacs.
1896 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1897 in the static heap.
1898 [CYGWIN] (special_realloc): New function.
1899 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1900 requests to realloc storage in the static heap.
1901
3ebec551
PE
19022011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * bidi.c (bidi_initialize): Remove unused local.
1905
9fd8be00
EZ
19062011-08-15 Eli Zaretskii <eliz@gnu.org>
1907
6b02f655
SM
1908 * bidimirror.h:
1909 * biditype.h: Remove file.
1910 * makefile.w32-in ($(BLD)/bidi.$(O)):
1911 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1912
1913 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1914
1915 * chartab.c: Improve commentary for the uniprop_table API.
1916
32413314
EZ
1917 * bidi.c (bidi_paragraph_init): Support zero value of
1918 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1919 (bidi_initialize): Use uniprop_table instead of including
1920 biditype.h and bidimirror.h.
32413314 1921
9fd8be00
EZ
1922 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1923 coordinates of the iterator when restoring from ppos_it.
1924 (Bug#9296)
1925
5cf2b69b
KH
19262011-08-14 Kenichi Handa <handa@m17n.org>
1927
1928 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1929 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1930
daf17d00
EZ
19312011-08-14 Eli Zaretskii <eliz@gnu.org>
1932
1933 * xdisp.c (move_it_in_display_line_to): Don't invoke
1934 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1935 ppos_it. Fixes vertical cursor motion when line beginning is
1936 covered by an image. (Bug#9296)
1937
08e3161a
JD
19382011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1939
1940 * nsterm.h (ns_run_ascript): Declare.
1941 (NSAPP_DATA2_RUNASSCRIPT): Define.
1942
1943 * nsfns.m (as_script, as_result, as_status): New static variables.
1944 (ns_run_ascript): New function.
5e617bc2 1945 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1946 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1947 the event loop. Get status from as_status (Bug#7276).
1948
1949 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1950 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1951 the event loop (Bug#7276).
1952
a3720aa2
AS
19532011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1954
1955 * gnutls.c (QCgnutls_bootprop_priority)
1956 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1957 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1958 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1959 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1960 (QCgnutls_bootprop_verify_hostname_error)
1961 (QCgnutls_bootprop_callbacks_verify): Rename from
1962 Qgnutls_bootprop_..., all uses changed.
1963
1964 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1965 uses changed.
1966
0a0d27fb
PE
19672011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1968
19d5c50c
PE
1969 * xfaces.c (Qframe_set_background_mode): Now static.
1970 * dispextern.h (Qframe_set_background_mode): Remove decl.
1971
0a0d27fb
PE
1972 * process.c (Fnetwork_interface_info): Declare local only if needed.
1973
377538cb
JD
19742011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1975
1976 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1977 (Fnetwork_interface_list): Allocate in increments of bytes instead
1978 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1979 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1980 sockaddr.
1981 (struct ifflag_def): notrailers is smart on OSX.
1982 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1983 Get hardware address with getifaddrs if available.
1984
08fff70c
EZ
19852011-08-12 Eli Zaretskii <eliz@gnu.org>
1986
1987 * xdisp.c (iterate_out_of_display_property): xassert that
1988 IT->position is set to within IT->object's boundaries. Break from
1989 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1990 when IT->position is set up wrongly due to some bug.
1991 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1992 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1993 entry. Force push_it to save on the stack the current
1994 buffer/string position, to be restored by pop_it. Fix flags in
1995 the iterator structure wrt the object coming from a display
1996 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1997 properties. (Bug#9284)
1998
7be1c708 19992011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2000
7be1c708
CY
2001 * fontset.c (fontset_get_font_group): Add proper type checks.
2002 (Bug#9172)
aac0c6e3 2003
7be1c708 20042011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2005
7be1c708
CY
2006 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2007 and LC_VERSION_MIN_MACOSX.
2008 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2009 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2010
97bb72a6
EZ
20112011-08-08 Eli Zaretskii <eliz@gnu.org>
2012
2013 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2014 no-display-properties-and-no-overlays under bidi display.
2015 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2016 properties and overlays.
97bb72a6 2017
d5617611
CY
20182011-08-08 Chong Yidong <cyd@stupidchicken.com>
2019
37e11a63
CY
2020 * editfns.c (Fset_time_zone_rule): Document relationship with the
2021 setenv function.
2022
d5617611
CY
2023 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2024 the font entity extracted from the cache (Bug#8109).
2025
58872834
CY
20262011-08-07 Chong Yidong <cyd@stupidchicken.com>
2027
2028 * composite.c (autocmp_chars): Don't reset point. That is done by
2029 restore_point_unwind (Bug#5984).
2030
75bfc667
JL
20312011-08-07 Juri Linkov <juri@jurta.org>
2032
2033 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2034 to show the arg `TIME' instead of `TIMEVAL'.
2035
d1410150
EZ
20362011-08-06 Eli Zaretskii <eliz@gnu.org>
2037
2038 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2039 display property strides EOL and includes a newline, as in
2040 longlines-mode. (Bug#9254)
75b771e4
EZ
2041 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2042 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2043
2044 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2045 is non-zero, even if the data buffer is NULL. Fixes a crash in
2046 vertical-motion with longlines-mode. (Bug#9254)
2047
35928349
EZ
20482011-08-05 Eli Zaretskii <eliz@gnu.org>
2049
ec7cc85b
EZ
2050 * bidi.c <bidi_cache_total_alloc>: Now static.
2051 (bidi_initialize): Initialize bidi_cache_total_alloc.
2052
8b76d6f8 2053 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2054 cache. (Bug#9221)
2055
2056 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2057 amount allocated this far in `bidi_cache_total_alloc'.
2058 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2059 non-zero, only free the data buffer without restoring the cache
2060 contents. All callers changed.
2061
2062 * dispextern.h (bidi_unshelve_cache): Update prototype.
2063
2064 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2065 (move_it_in_display_line, move_it_to)
2066 (move_it_vertically_backward, move_it_by_lines): Replace the call
2067 to xfree to an equivalent call to bidi_unshelve_cache.
2068 (move_it_in_display_line_to): Fix logic of returning
412b6358 2069 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2070
e2e2423b
EZ
20712011-08-05 Eli Zaretskii <eliz@gnu.org>
2072
2073 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2074 came from a string character with a `cursor' property. (Bug#9229)
2075
ae9e757a
JD
20762011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2077
2078 * Makefile.in (LIB_PTHREAD): New variable.
2079 (LIBES): Add LIB_PTHREAD (Bug#9216).
2080
2081 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2082 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2083
213bd7f2
AS
20842011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2085
6b02f655 2086 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2087
99aaf75f
JD
20882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2089
2090 * xterm.c (x_find_topmost_parent): New function.
2091 (x_set_frame_alpha): Find topmost parent window with
2092 x_find_topmost_parent and set the property there also (bug#9181).
2093 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2094
c74e9d86
PE
20952011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2096
2097 * callproc.c (Fcall_process): Avoid vfork clobbering
2098 the local vars buffer, coding_systems, current_dir.
2099
640c8776
SM
21002011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2101
2102 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2103
f26d0e4c
PE
21042011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2105
8a10d76c
PE
2106 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2107 so that it is not optimized away.
2108
f26d0e4c
PE
2109 * xdisp.c (compute_display_string_pos): Remove unused local.
2110
55439c61
EZ
21112011-08-02 Eli Zaretskii <eliz@gnu.org>
2112
2113 Fix slow cursor motion and scrolling in large buffers with
2114 selective display, like Org Mode buffers. (Bug#9218)
2115
2116 * dispextern.h (struct bidi_it): New member disp_prop_p.
2117
2118 * xdisp.c: Remove one-slot cache of display string positions.
2119 (compute_display_string_pos): Accept an additional argument
5e617bc2 2120 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2121 for a display string or property. If found, set DISP_PROP_P
2122 non-zero.
2123
2124 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2125 DISP_PROP_P, and pass it to compute_display_string_pos.
2126 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2127 non-zero. All callers of bidi_fetch_char changed.
2128
fb33fa43
SM
21292011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2130
2131 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2132
b099e063
DM
21332010-12-03 Don March <don@ohspite.net>
2134
2135 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2136 last character M-[char] is translated to ESC [char] (bug#7541).
2137
5cc7f7af
KH
21382011-08-02 Kenichi Handa <handa@m17n.org>
2139
d0fffa3f 2140 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2141
2142 * chartab.c (uniprop_table): Make it non-static.
2143
525d5e6e
EZ
21442011-08-01 Eli Zaretskii <eliz@gnu.org>
2145
2146 * xdisp.c (forward_to_next_line_start): Accept additional argument
2147 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2148 on the newline.
2149 (reseat_at_next_visible_line_start): Use the bidi iterator state
2150 returned by forward_to_next_line_start to restore the state of
2151 it->bidi_it after backing up to previous newline. (Bug#9212)
2152
31011111
AS
21532011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2154
2155 * regex.c (re_comp): Protoize.
2156 (re_exec): Fix return type.
2157 (regexec): Fix type of `ret'. (Bug#9203)
2158
476371c4
PE
21592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2160
e5d76069
PE
2161 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2162 This is needed if max-image-size is a floating-point number.
2163
9a79b20c
AS
21642011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2165
2166 * print.c (print_object): Print empty symbol as ##.
2167
2168 * lread.c (read1): Read ## as empty symbol.
2169
d8c2fa78
AA
21702011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2171
2172 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2173 setting frame foreground color (Bug#9175).
2174 (x_set_background_color): Likewise.
2175
ffe57a7a
AA
2176 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2177 contents (Bug#9176).
2178 (EmacsTooltip -init): Remove bezels and add shadows to
2179 tooltip windows.
2180
bf3492a5
AA
2181 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2182 or scroll bar (Bug#8470).
2183
d55e9c53
AA
2184 * nsfont.m (nsfont_open): Remove assignment to voffset and
2185 unnecessary vars hshink, expand, hd, full_height, min_height.
2186 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2187
2188 * nsterm.h (nsfont_info): Remove voffset field.
2189
d8c2fa78 21902011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2191
2192 Implement strike-through and overline on NextStep (Bug#8863).
2193
2194 * nsfont.m (nsfont_open): Use underline position provided by font,
2195 instead of hard-coded value of 2.
2196 (nsfont_draw): Call ns_draw_text_decoration instead.
2197
2198 * nsterm.h: Add declaration for ns_draw_text_decoration.
2199
2200 * nsterm.m (ns_draw_text_decoration): New function for drawing
2201 underline, overline, and strike-through.
2202 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2203 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2204 accommodate underlining, etc.
4843aac3 2205
4cc60b9b
EZ
22062011-07-28 Eli Zaretskii <eliz@gnu.org>
2207
bc7ece87
EZ
2208 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2209 default.
4cc60b9b 2210
476371c4
PE
22112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2212
66606eea
PE
2213 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2214 Without this fix, if a signal arrives just after memory fills up,
2215 'malloc' might be invoked reentrantly.
2216
476371c4
PE
2217 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2218 In other words, assume that every image size is allowed, on non-X
2219 hosts. This assumption is probably wrong, but it lets Emacs compile.
2220
f3fcc40d
AS
22212011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2222
2223 * regex.c (re_iswctype): Convert return values to boolean.
2224
350c992f
EZ
22252011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2226
2227 * xdisp.c (compute_display_string_pos): Don't use cached display
2228 string position if the buffer had its restriction changed.
2229 (Bug#9184)
2230
5266b4bb
PE
22312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2234
2573a837 22352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2236
41f55ccd 2237 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2238
39e378da
PE
2239 * bidi.c: Integer size and overflow fixes.
2240 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2241 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2242 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2243 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2244 (bidi_find_other_level_edge):
2245 Use ptrdiff_t instead of EMACS_INT where either will do.
2246 This works better on 32-bit hosts configured --with-wide-int.
2247 (bidi_cache_ensure_space): Check for size-calculation overflow.
2248 Use % rather than repeated addition, for better worst-case speed.
2249 Don't set bidi_cache_size until after xrealloc returns, because it
2250 might not return.
2251 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2252 (bidi_cache_ensure_space): Also check that the bidi cache size
2253 does not exceed that of the largest Lisp string or buffer. See Eli
2254 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2255
5e927815
PE
2256 * alloc.c (__malloc_size_t): Remove.
2257 All uses replaced by size_t. See Andreas Schwab's note
2258 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2259
ca4aa935
PE
2260 * image.c: Improve checking for integer overflow.
2261 (check_image_size): Assume that f is nonnull, since
2262 it is always nonnull in practice. This is one less thing to
2263 worry about when checking for integer overflow later.
2264 (x_check_image_size): New function, which checks for integer
2265 overflow issues inside X.
2266 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2267 This removes the need for a memory_full check.
2268 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2269 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2270 (xbm_read_bitmap_data): Change locals back to 'int', since
2271 their values must fit in 'int'.
2272 (xpm_load_image, png_load, tiff_load):
2273 Invoke x_create_x_image_and_pixmap earlier,
2274 to avoid much needless work if the image is too large.
2275 (tiff_load): Treat overly large images as if
2276 x_create_x_image_and_pixmap failed, not as malloc failures.
2277 (gs_load): Use x_check_image_size.
2278
5f8f9cc2
PE
2279 * gtkutil.c: Omit integer casts.
2280 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2281 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2282
5adf60bc
PE
2283 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2284
c8907a93
PE
2285 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2286 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2287 would wrongly return t on a 64-bit host.
2288
e3c25c68
PE
2289 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2290 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2291 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2292 and therefore cause GCC to emit a bogus diagnostic in some cases.
2293
3f791afe
PE
2294 * image.c: Integer signedness and overflow and related fixes.
2295 This is not an exhaustive set of fixes, but it's time to
2296 record what I've got.
2297 (lookup_pixel_color, check_image_size): Remove redundant decls.
2298 (check_image_size): Don't assume that arbitrary EMACS_INT values
2299 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2300 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2301 (tiff_load, imagemagick_load_image):
2302 Check for overflow in size calculations.
2303 (x_create_x_image_and_pixmap): Remove unnecessary test for
2304 xmalloc returning NULL; that can't happen.
2305 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2306 (xpm_color_bucket): Use better integer hashing function.
2307 (xpm_cache_color): Don't possibly over-allocate memory.
2308 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2309 (gif_memory_source):
2310 Use ptrdiff_t, not int or size_t, to record sizes.
2311 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2312 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2313 either works, as we prefer signed integers.
2314 (tiff_read_from_memory, tiff_write_from_memory):
2315 Return tsize_t, not size_t, since that's what the TIFF API wants.
2316 (tiff_read_from_memory): Don't fail simply because the read would
2317 go past EOF; instead, return a short read.
2318 (tiff_load): Omit no-longer-needed casts.
2319 (Fimagemagick_types): Don't assume size fits into 'int'.
2320
3cc5a532
PE
2321 Improve hashing quality when configured --with-wide-int.
2322 * fns.c (hash_string): New function, taken from sxhash_string.
2323 Do not discard information about ASCII character case; this
2324 discarding is no longer needed.
2325 (sxhash-string): Use it. Change sig to match it. Caller changed.
2326 * lisp.h: Declare it.
2327 * lread.c (hash_string): Remove, since we now use fns.c's version.
2328 The fns.c version returns a wider integer if --with-wide-int is
2329 specified, so this should help the quality of the hashing a bit.
2330
b312a492
PE
2331 * emacs.c: Integer overflow minor fix.
2332 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2333 Define only if GNU_LINUX.
2334 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2335
dfd153ae
PE
2336 * dispnew.c: Integer signedness and overflow fixes.
2337 Remove unnecessary forward decls, that were a maintenance hassle.
2338 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2339 All uses changed.
2340 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2341 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2342 (prepare_desired_row, line_draw_cost):
2343 Use int, not unsigned, where either works.
2344 (save_current_matrix, restore_current_matrix):
2345 Use ptrdiff_t, not size_t, where either works.
2346 (init_display): Check for overflow more accurately, and without
2347 relying on undefined behavior.
2348
a81d11a3
PE
2349 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2350 Remove, replacing with the new symbols in lisp.h. All uses changed.
2351 * fileio.c (make_temp_name):
2352 * filelock.c (lock_file_1, lock_file):
2353 * xdisp.c (message_dolog):
2354 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2355 Use pMd etc. instead.
2356 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2357 replacing the pWIDE etc. symbols removed from editfns.c.
2358
3300e6fd
PE
2359 * keyboard.h (num_input_events): Now uintmax_t.
2360 This is (very slightly) less likely to mess up due to wraparound.
2361 All uses changed.
2362
fd05c7e9
PE
2363 * buffer.c: Integer signedness fixes.
2364 (alloc_buffer_text, enlarge_buffer_text):
2365 Use ptrdiff_t rather than size_t when either will do, as we prefer
2366 signed integers.
2367
903fe15d
PE
2368 * alloc.c: Integer signedness and overflow fixes.
2369 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2370 (__malloc_size_t): Default to size_t, not to int.
2371 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2372 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2373 Prefer ptrdiff_t to size_t when either would do, as we prefer
2374 signed integers.
2375 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2376 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2377 Now const. Initialize with values that are in range even if char
2378 is signed.
2379 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2380 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2381 These functions do the right thing with sizes > 2**32.
2382 (check_depth): Now ptrdiff_t, not int.
2383 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2384 Adjust to new way of storing sizes. Check for size overflow bugs
2385 in rest of code.
2386 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2387 slightly wrong anyway, as it missed one instance of
2388 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2389 (refill_memory_reserve): Omit needless cast to size_t.
2390 (mark_object_loop_halt): Mark as externally visible.
2391
ac82cc6a
PE
2392 * xselect.c: Integer signedness and overflow fixes.
2393 (Fx_register_dnd_atom, x_handle_dnd_message):
2394 Use ptrdiff_t, not size_t, since we prefer signed.
2395 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2396 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2397 x_dnd_atoms_size and x_dnd_atoms_length.
2398
c2d1e36d
PE
2399 * doprnt.c: Prefer signed to unsigned when either works.
2400 * eval.c (verror):
2401 * doprnt.c (doprnt):
2402 * lisp.h (doprnt):
2403 * xdisp.c (vmessage):
2404 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2405 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2406 prefer signed arithmetic to avoid comparison confusion.
2407 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2408 but is a bit tricky.
2409
0e926e56
PE
2410 Assume freestanding C89 headers, string.h, stdlib.h.
2411 * data.c, doprnt.c, floatfns.c, print.c:
2412 Include float.h unconditionally.
2413 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2414 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2415 * regex.c: Likewise for stddef.h, string.h.
2416 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2417 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2418 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2419 (STDC_HEADERS): Remove obsolete defines.
2420 * sysdep.c: Include limits.h unconditionally.
2421
9cfdb3ec
PE
2422 Assume support for memcmp, memcpy, memmove, memset.
2423 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2424 * regex.c (memcmp, memcpy):
2425 Remove; we assume C89 now.
2426
2427 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2428 (__malloc_safe_bcopy): Remove; no longer needed.
2429
cf950e6b 2430 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2431 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2432 well either way, and we prefer signed to unsigned.
2433
dbf38e02
LMI
24342011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2435
2436 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2437 closes the connection while we're reading (bug#9182).
2438
d6f0886c 24392011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2440
d6f0886c
JD
2441 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2442 are specified (Bug#9168).
24e0f6b1 2443
2eb1f9e6
PE
24442011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2445
2446 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2447 Found by GCC static checking and --with-wide-int on a 32-bit host.
2448
22381272 24492011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2450
2451 * xdisp.c (compute_display_string_pos): Fix logic of caching
2452 previous display string position. Initialize cached_prev_pos to
2453 -1. Fixes slow-down at the beginning of a buffer.
2454
f25e39b4
EZ
24552011-07-24 Eli Zaretskii <eliz@gnu.org>
2456
2457 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2458 for attrs[LFACE_FONTSET_INDEX].
2459
04c4b52e
PE
24602011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2461
2462 * xml.c (parse_region): Remove unused local
2463 that was recently introduced.
2464
c1734fbd
EZ
24652011-07-23 Eli Zaretskii <eliz@gnu.org>
2466
be18c5a5
EZ
2467 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2468 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2469
c1734fbd
EZ
2470 * xdisp.c (move_it_in_display_line_to): Record the best matching
2471 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2472 exit if none of the characters scanned was an exact match.
2473 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2474 when exact match is impossible due to invisible text, and the
2475 lines are truncated.
2476
a258d627
JD
24772011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2478
2479 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2480 for OSX >= 10.7.
2481
b6d5a689
EZ
24822011-07-22 Eli Zaretskii <eliz@gnu.org>
2483
0f74f785
EZ
2484 Fix a significant slow-down of cursor motion with C-n, C-p,
2485 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2486 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2487 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2488 (next_element_from_buffer): Call compute_stop_pos_backwards to
2489 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2490 base_level_stop.
2491 (reseat): Don't look for prev_stop, as that could mean a very long
2492 run.
2493 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2494 <cached_disp_overlay_modiff>: Cache for last found display string
2495 position.
551918c1 2496 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2497 about the same buffer in the same area of character positions, and
2498 the buffer wasn't changed since the time the display string
2499 position was cached.
551918c1 2500
b2d0c91a
EZ
25012011-07-22 Eli Zaretskii <eliz@gnu.org>
2502
2503 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2504 is an integer, which is important for empty lines. (Bug#9149)
2505
043604ee
CY
25062011-07-22 Chong Yidong <cyd@stupidchicken.com>
2507
2508 * frame.c (Fmodify_frame_parameters): In tty case, update the
2509 default face if necessary (Bug#4238).
2510
da4adb04
CY
25112011-07-21 Chong Yidong <cyd@stupidchicken.com>
2512
2513 * editfns.c (Fstring_to_char): No need to explain what a character
2514 is in the docstring (Bug#6576).
2515
9abd0532
LMI
25162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2517
2518 * xml.c (parse_region): Make sure we always return a tree.
2519
36881d16
HK
25202011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2521
2522 * xml.c (parse_region): If a document contains only comments,
2523 return that, too.
2524
1e98674d
LMI
25252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2526
2527 * xml.c (make_dom): Return comments, too.
2528
590bd467
PE
25292011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2530
2531 Port to OpenBSD.
2532 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2533 and the surrounding thread.
2534 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2535 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2536 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2537 timer goes off.
2538 * s/openbsd.h (BROKEN_SIGIO): Define.
2539 * unexelf.c (unexec) [__OpenBSD__]:
2540 Don't update the .mdebug section of the Alpha COFF symbol table.
2541
f41628b2
LMI
25422011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2543
2544 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2545 (bug#8460).
2546
b59b67c5
PE
25472011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2548
15e3a074
PE
2549 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2550 This fixes some race conditions on the permissions of any newly
2551 created file.
2552
41bed37d
PE
2553 * alloc.c (valid_pointer_p): Use pipe, not open.
2554 This fixes some permissions issues when debugging.
2555
b59b67c5
PE
2556 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2557 If fchown fails to set both uid and gid, try to set just gid,
2558 as that is sometimes allowed. Adjust the file's mode to eliminate
2559 setuid or setgid bits that are inappropriate if fchown fails.
2560
925a6be7
SM
25612011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2562
2563 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2564 to compare Lisp_Objects.
2565 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2566 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2567 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2568
52968808
AS
25692011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2570
0a6a104b
AS
2571 * lread.c (read_integer): Unread even EOF character.
2572 (read1): Likewise. Properly record start position of symbol.
2573
52968808
AS
2574 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2575 symbol character follows.
2576
9e381cdd
PE
25772011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2578
2579 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2580 This works around a problem with the previous change to Fcopy_file.
2581 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2582 and without this change, GCC might complain about discarding
2583 fchown's return value.
2584
b5641435
JB
25852011-07-16 Juanma Barranquero <lekktu@gmail.com>
2586
2587 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2588
a8031457
PE
25892011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2590
2591 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2592
dd889327
LMI
25932011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2594
750c33f7
LMI
2595 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2596 it's used from the C level.
2597
dd889327
LMI
2598 * process.c: Use the same condition for POLL_FOR_INPUT in both
2599 keyboard.c and process.c (bug#1858).
2600
87e86684
LM
26012011-07-09 Lawrence Mitchell <wence@gmx.li>
2602
2603 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2604 (Fgnutls_boot): Use it.
2605
64348f40
AS
26062011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2607
2608 * doc.c (Fsubstitute_command_keys): Revert last change.
2609
1d698799
LMI
26102011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2611
f863868c
LMI
2612 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2613 quotes the next character, and doesn't affect other longer
2614 sequences (bug#8935).
2615
1d698799
LMI
2616 * lread.c (syms_of_lread): Clarify that is isn't only
2617 `eval-buffer' and `eval-defun' that's affected by
2618 `lexical-binding' (bug#8460).
2619
aa4b6df6
EZ
26202011-07-15 Eli Zaretskii <eliz@gnu.org>
2621
2622 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2623 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2624
5d856da6
PE
26252011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2626
ad6042bb
PE
2627 Fix minor problems found by static checking.
2628 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2629 (elsz): Now a signed constant, not a size_t var. We prefer signed
2630 types to unsigned, to avoid integer comparison confusion. Without
2631 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2632 "cannot optimize loop, the loop counter may overflow", a symptom
2633 of the confusion.
f00bbb22 2634 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2635 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2636
6468f31c
LMI
26372011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2638
49080b10
LMI
2639 * search.c (Fre_search_backward): Mention `case-fold-search' in
2640 all the re_search_* functions (bug#8138).
2641
6468f31c
LMI
2642 * keyboard.c (Fopen_dribble_file): Document when the file is
2643 closed (bug#8056).
2644
c965adc5
EZ
26452011-07-14 Eli Zaretskii <eliz@gnu.org>
2646
df9733bf
EZ
2647 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2648 bidi_cache_idx.
2649
0bb23927
EZ
2650 Support bidi reordering of display and overlay strings.
2651 * xdisp.c (compute_display_string_pos)
2652 (compute_display_string_end): Accept additional argument STRING.
2653 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2654 (reseat_to_string): Initialize bidi_it->string.s and
2655 bidi_it->string.schars.
2656 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2657 NULL (avoids a crash in bidi_paragraph_init).
2658 Initialize itb.string.lstring.
0bb23927
EZ
2659 (init_iterator): Call bidi_init_it only of a valid
2660 buffer position was specified. Initialize paragraph_embedding to
2661 L2R.
2662 (reseat_to_string): Initialize the bidi iterator.
2663 (display_string): If we need to ignore text properties of
2664 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2665 original value of -1 will not work with bidi.)
2666 (compute_display_string_pos): First arg is now struct
2667 `text_pos *'; all callers changed. Support display properties on
2668 Lisp strings.
2669 (compute_display_string_end): Support display properties on Lisp
2670 strings.
2671 (init_iterator, reseat_1, reseat_to_string): Initialize the
2672 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2673 when iterating on a string not from display properties).
640c8776
SM
2674 (compute_display_string_pos, compute_display_string_end):
2675 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2676 arrow keys.
2677 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2678 base_level_stop; instead, set base_level_stop to BEGV.
2679 Fixes crashes in vertical-motion.
0bb23927
EZ
2680 (next_element_from_buffer): Improve commentary for when
2681 the iterator is before prev_stop.
2682 (init_iterator): Initialize bidi_p from the default value of
2683 bidi-display-reordering, not from buffer-local value. Use the
2684 buffer-local value only if initializing for buffer iteration.
2685 (handle_invisible_prop): Support invisible properties on strings
2686 that are being bidi-reordered.
2687 (set_iterator_to_next): Support bidi reordering of C strings and
2688 Lisp strings.
2689 (next_element_from_string): Support bidi reordering of Lisp
2690 strings.
2691 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2692 (display_string): Support display of R2L glyph rows.
2693 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2694 (init_iterator): Don't initialize it->bidi_p for strings
2695 here.
2696 (reseat_to_string): Initialize it->bidi_p for strings here.
2697 (next_element_from_string, next_element_from_c_string)
2698 (next_element_from_buffer): Add xassert's for correspondence
2699 between IT's object being iterated and it->bidi_it.string
2700 structure.
2701 (face_before_or_after_it_pos): Support bidi iteration.
2702 (next_element_from_c_string): Handle the case of the first string
2703 character that is not the first one in the visual order.
2704 (get_visually_first_element): New function, refactored from common
2705 parts of next_element_from_buffer, next_element_from_string, and
2706 next_element_from_c_string.
2707 (tool_bar_lines_needed, redisplay_tool_bar)
2708 (display_menu_bar): Force left-to-right direction. Add a FIXME
2709 comment for making that be controlled by a user option.
2710 (push_it, pop_it): Save and restore the state of the
2711 bidi iterator. Save and restore the bidi_p flag.
2712 (pop_it): Iterate out of display property for string iteration as
2713 well.
2714 (iterate_out_of_display_property): Support iteration over strings.
2715 (handle_single_display_spec): Set up it->bidi_it for iteration
2716 over a display string, and call bidi_init_it.
2717 (handle_single_display_spec, next_overlay_string)
2718 (get_overlay_strings_1, push_display_prop): Set up the bidi
2719 iterator for displaying display or overlay strings.
2720 (forward_to_next_line_start): Don't use the shortcut if
2721 bidi-iterating.
2722 (back_to_previous_visible_line_start): If handle_display_prop
2723 pushed the iterator stack, restore the internal state of the bidi
2724 iterator by calling bidi_pop_it same number of times.
2725 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2726 and we are bidi-iterating, don't decrement the iterator position;
2727 instead, set the first_elt flag in the bidi iterator, to produce
2728 the same effect.
2729 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2730 (push_display_prop): xassert that we are iterating a buffer.
2731 (push_it, pop_it): Save and restore paragraph_embedding member.
2732 (handle_single_display_spec, next_overlay_string)
2733 (get_overlay_strings_1, reseat_1, reseat_to_string)
2734 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2735 correctly. Don't assume unibyte strings are not bidi-reordered.
2736 (compute_display_string_pos)
2737 (compute_display_string_end): Fix handling the case of C string.
2738 (push_it, pop_it): Save and restore from_disp_prop_p.
2739 (handle_single_display_spec, push_display_prop): Set the
2740 from_disp_prop_p flag.
2741 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2742 (pop_it): Call iterate_out_of_display_property only if we are
2743 popping after iteration over a string that came from a display
2744 property. Fix a typo in popping stretch info. Add an assertion
2745 for verifying that the iterator position is in sync with the bidi
2746 iterator.
2747 (handle_single_display_spec, get_overlay_strings_1)
2748 (push_display_prop): Fix initialization of paragraph direction for
2749 string when that of the parent object is not yet determined.
2750 (reseat_1): Call bidi_init_it to resync the bidi
2751 iterator with IT's position. (Bug#7616)
2752 (find_row_edges): If ROW->start.pos gives position
2753 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2754 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2755 Reset the from_disp_prop_p flag.
2756 (SAVE_IT, RESTORE_IT): New macros.
2757 (pos_visible_p, face_before_or_after_it_pos)
2758 (back_to_previous_visible_line_start)
2759 (move_it_in_display_line_to, move_it_in_display_line)
2760 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2761 (try_scrolling, redisplay_window, display_line): Use them when
2762 saving a temporary copy of the iterator and restoring it back.
2763 (back_to_previous_visible_line_start, reseat_1)
2764 (init_iterator): Empty the bidi cache "stack".
2765 (move_it_in_display_line_to): If iterator ended up at
2766 EOL, but we never saw any buffer positions smaller than
2767 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2768 motion in bidi-reordered lines.
2769 (move_it_in_display_line_to): Record prev_method and prev_pos
2770 immediately before the call to set_iterator_to_next. Fixes cursor
2771 motion in bidi-reordered lines with stretch glyphs and strings
2772 displayed in margins. (Bug#8133) (Bug#8867)
2773 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2774 TO_CHARPOS.
640c8776
SM
2775 (pos_visible_p): Support positions in bidi-reordered lines.
2776 Save and restore bidi cache.
0bb23927
EZ
2777
2778 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2779 (bidi_paragraph_info): Delete unused struct.
2780 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2781 (bidi_cache_start): New variable.
2782 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2783 to zero.
2784 (bidi_cache_fetch_state, bidi_cache_search)
2785 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2786 (bidi_cache_find, bidi_peek_at_next_level)
2787 (bidi_level_of_next_char, bidi_find_other_level_edge)
2788 (bidi_move_to_visually_next): Compare cache index with
2789 bidi_cache_start rather than with zero.
2790 (bidi_fetch_char): Accept new argument STRING; all callers
2791 changed. Support iteration over a string. Support strings with
2792 display properties. Support unibyte strings. Fix the type of
2793 `len' according to what STRING_CHAR_AND_LENGTH expects.
2794 (bidi_paragraph_init, bidi_resolve_explicit_1)
2795 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2796 (bidi_level_of_next_char, bidi_move_to_visually_next):
2797 Support iteration over a string.
0bb23927
EZ
2798 (bidi_set_sor_type, bidi_resolve_explicit_1)
2799 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2800 can now be zero (for strings); special values 0 and -1 were
2801 changed to -1 and -2, respectively.
2802 (bidi_char_at_pos): New function.
2803 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2804 Call it instead of FETCH_MULTIBYTE_CHAR.
2805 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2806 initialized to valid values.
2807 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2808 values.
2809 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2810 the test for valid cached positions. Fix the logic for looking up
2811 the sentinel state in the cache. GCPRO the Lisp string we are
2812 iterating.
2813 (bidi_push_it, bidi_pop_it): New functions.
2814 (bidi_initialize): Initialize the bidi cache start stack pointer.
2815 (bidi_cache_ensure_space): New function, refactored from part of
2816 bidi_cache_iterator_state. Don't assume the required size is just
2817 one BIDI_CACHE_CHUNK away.
2818 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2819 (bidi_count_bytes, bidi_char_at_pos): New functions.
2820 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2821 always valid if bidi_cache_idx is valid.
2822 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2823 is valid if it's going to be used.
2824 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2825 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2826 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2827 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2828 (bidi_find_other_level_edge, bidi_cache_start_stack):
2829 All variables related to cache indices are now EMACS_INT.
c965adc5 2830
0bb23927
EZ
2831 * dispextern.h (struct bidi_string_data): New structure.
2832 (struct bidi_it): New member `string'. Make flag members be 1-bit
2833 fields, and put them last in the struct.
640c8776
SM
2834 (compute_display_string_pos, compute_display_string_end):
2835 Update prototypes.
0bb23927
EZ
2836 (bidi_push_it, bidi_pop_it): Add prototypes.
2837 (struct iterator_stack_entry): New members bidi_p,
2838 paragraph_embedding, and from_disp_prop_p.
2839 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2840 (bidi_shelve_cache, bidi_unshelve_cache):
2841 Declare prototypes.
0bb23927
EZ
2842
2843 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2844 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2845 and vector-like objects.
2846
2847 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2848 cache around display iteration.
2849
2850 * window.c (Fwindow_end, window_scroll_pixel_based)
2851 (displayed_window_lines, Frecenter): Save and restore the bidi
2852 cache around display iteration.
2853
3bbd2265
LMI
28542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2855
2856 * editfns.c (Fdelete_region): Clarify the use of the named
2857 parameters (bug#6788).
2858
adc47434
MR
28592011-07-14 Martin Rudalics <rudalics@gmx.at>
2860
2861 * indent.c (Fvertical_motion): Set and restore w->pointm when
2862 saving and restoring the window's buffer (Bug#9006).
2863
837c31f8
LMI
28642011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2865
2866 * editfns.c (Fstring_to_char): Clarify just what is returned
2867 (bug#6576). Text by Eli Zaretskii.
2868
ac389d0c
JB
28692011-07-13 Juanma Barranquero <lekktu@gmail.com>
2870
2871 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2872
0be0ce47
EZ
28732011-07-13 Eli Zaretskii <eliz@gnu.org>
2874
2875 * buffer.c (mmap_find): Fix a typo.
2876
cd18e7e3
JB
28772011-07-13 Johan Bockgård <bojohan@gnu.org>
2878
2879 Fix execution of x selection hooks.
2880 * xselect.c (Qx_lost_selection_functions)
2881 (Qx_sent_selection_functions): New vars.
2882 (syms_of_xselect): DEFSYM them.
2883 (x_handle_selection_request): Pass Qx_sent_selection_functions
2884 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2885 (x_handle_selection_clear,x_clear_frame_selections):
2886 Pass Qx_lost_selection_functions rather than
2887 Vx_lost_selection_functions to Frun_hook_with_args.
2888
47ea7f44
PE
28892011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2890
ac389d0c 2891 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2892 The old code sometimes used this field without initializing it.
2893
47ea7f44
PE
2894 * alloc.c (gc_sweep): Don't read past end of array.
2895 In theory, the old code could also have corrupted Emacs internals,
2896 though it'd be very unlikely.
2897
bc985c87
AS
28982011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2899
2900 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2901 argument. (Bug#4026)
bc985c87 2902
0cf34688
LMI
29032011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2904
b3dadd76
LMI
2905 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2906 key" (bug#4257).
2907
0cf34688
LMI
2908 * window.c (Fset_window_start): Doc fix (bug#4199).
2909 (Fset_window_hscroll): Ditto.
2910
270768cd
PE
29112011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2912
077e3dda 2913 Fix minor new problems caught by GCC 4.6.1.
270768cd 2914 * term.c (init_tty): Remove unused local.
490011a6 2915 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2916 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2917 not used otherwise.
270768cd 2918
b1f58454
CY
29192011-07-12 Chong Yidong <cyd@stupidchicken.com>
2920
2921 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2922
22b9578d
LMI
29232011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2924
6e70ab07
LMI
2925 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2926 are the mini-buffer and the echo area (bug#3320).
2927
22b9578d
LMI
2928 * term.c (init_tty): Remove support for supdup, c10 and perq
2929 terminals, which are no longer supported (bug#1482).
2930
8974cc9f
JB
29312011-07-10 Johan Bockgård <bojohan@gnu.org>
2932
2933 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2934
a560d974
JD
29352011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2936
2937 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2938 for non-popups (Bug#3642).
2939
1dae0f0a
AS
29402011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2941
268c2c36 2942 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2943 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2944 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2945 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2946 * data.c (fmod): Likewise.
2947 * dispnew.c (swap_glyphs_in_rows): Likewise.
2948 * emacs.c (memory_warning_signal): Likewise.
2949 * floatfns.c (float_error): Likewise.
2950 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2951 (otf_open, font_otf_capability, generate_otf_features)
2952 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2953 Likewise.
2954 * image.c (pbm_read_file): Likewise.
2955 * indent.c (string_display_width): Likewise.
2956 * intervals.c (check_for_interval, search_for_interval)
2957 (inc_interval_count, count_intervals, root_interval)
2958 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2959 * lread.c (defalias): Likewise.
268c2c36 2960 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2961 * regex.c (set_image_of_range_1, set_image_of_range)
2962 (regex_grow_registers): Likewise.
2963 * sysdep.c (strerror): Likewise.
2964 * termcap.c (valid_filename_p, tprint, main): Likewise.
2965 * tparam.c (main): Likewise.
2966 * unexhp9k800.c (run_time_remap, save_data_space)
2967 (update_file_ptrs, read_header, write_header, calculate_checksum)
2968 (copy_file, copy_rest, display_header): Likewise.
2969 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2970 Likewise.
2971 * xdisp.c (check_it): Likewise.
2972 * xfaces.c (register_color, unregister_color, unregister_colors):
2973 Likewise.
2974 * xfns.c (print_fontset_result): Likewise.
2975 * xrdb.c (member, fatal, main): Likewise.
2976
99033785
PE
29772011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2978
2979 Fix minor problems found by static checking (Bug#9031).
2980 * chartab.c (char_table_set_range, map_sub_char_table):
2981 Remove unused locals.
2982 (uniprop_table): Now static.
2983 * composite.c (_work_char): Remove unused static var.
2984
9cb2ac56
JB
29852011-07-09 Juanma Barranquero <lekktu@gmail.com>
2986
2987 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2988
f25661f0
JD
29892011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2990
2991 * gtkutil.c (qttip_cb): Remove code without function.
2992
8278c4fe
EZ
29932011-07-09 Eli Zaretskii <eliz@gnu.org>
2994
2995 * w32.c (pthread_sigmask): New stub.
2996
1692ae2d 29972011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2998
8a6ebd58 2999 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3000 sigprocmask is portable only for single-threaded applications, and
3001 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3002 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3003 (LIBES): Use it.
3004 * callproc.c (Fcall_process):
3005 * process.c (create_process):
3006 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3007 Use pthread_sigmask, not sigprocmask.
123403e4 3008
1b854618
JD
30092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3010
3011 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3012 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3013 wrong (Bug#8591).
3014
3fe4b549
JD
30152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3016
0ce7e563
JD
3017 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3018 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3019 (xg_hide_tooltip): Fix comment.
3020
3fe4b549
JD
3021 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3022 in registerServicesMenuSendTypes.
3023 (validRequestorForSendType): Don't check ns_return_types.
3024
3025 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3026 ns_return_type.
3027
5df75e47
JR
30282011-07-08 Jason Rumney <jasonr@gnu.org>
3029
22610910
JR
3030 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3031 SH_SHOW for hidden windows (Bug#5482).
3032
5df75e47
JR
3033 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3034 frame struct members of non-existent frames (Bug#6284).
3035
699c10bd
JD
30362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3037
4393663b
JD
3038 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3039 variable firstTime not needed on OSX >= 10.6.
3040 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3041 >= 10.5. Use setKnobProportion, setDoubleValue.
3042
3043 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3044 (MAC_OS_X_VERSION_10_5): Define if not defined.
3045 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3046 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3047 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3048
3049 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3050 cString and lossyCString on OSX >= 10.4
3051
3052 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3053 sizeToFit on OSX >= 10.2.
3054
3055 * nsimage.m (allocInitFromFile): Don't use deprecated method
3056 bestRepresentationForDevice on OSX >= 10.6.
3057
3058 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3059 to avoid warning.
3060
3061 * emacs.c: Declare unexec_init_emacs_zone.
3062
a63e0781
JD
3063 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3064
699c10bd
JD
3065 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3066
3067 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3068 on svcsMenu (Bug#8842).
3069
3070 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3071 ns_return_types.
3072 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3073
3074 * nsterm.m (QUTF8_STRING): Declare.
3075 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3076 (validRequestorForSendType): Return type is (id).
3077 Change indexOfObjectIdenticalTo to indexOfObject.
3078 Check if we have local selection before returning self (Bug#8842).
3079 (writeSelectionToPasteboard): Put local selection into paste board
3080 if we have a local selection (Bug#8842).
3081 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3082
3083 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3084 (ns_get_local_selection): Declare.
3085
54e10184
LMI
30862011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3087
9888ff71
LMI
3088 * keymap.c (describe_map_tree): Don't insert a double newline at
3089 the end of the buffer (bug#1169) and return whether we inserted
3090 something.
3091
54e10184
LMI
3092 * callint.c (Fcall_interactively): Change "reading args" to
3093 "providing args" to try to clarify what it does (bug#1010).
3094
15fa4783
KH
30952011-07-07 Kenichi Handa <handa@m17n.org>
3096
3097 * composite.c (composition_compute_stop_pos): Ignore a static
3098 composition starting before CHARPOS (Bug#8915).
3099
3100 * xdisp.c (handle_composition_prop): Likewise.
3101
a8815b00
EZ
31022011-07-07 Eli Zaretskii <eliz@gnu.org>
3103
3104 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3105 (Bug#9015)
3106
ef7b981d 31072011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3108
3109 * character.h (unicode_category_t): New enum type.
3110
3111 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3112 (Qchar_code_property_table): New variable.
3113 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3114 (UNIPROP_COMPRESSED_FORM_P): New macros.
3115 (char_table_ascii): Uncompress the compressed values.
3116 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3117 Uncompress the compressed values.
ac389d0c 3118 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3119 (char_table_ref_and_range): Uncompress the compressed values.
3120 (sub_char_table_set): New arg is_uniprop. Callers changed.
3121 Uncompress the compressed values.
3122 (sub_char_table_set_range): Args changed. Callers changed.
3123 (char_table_set_range): Adjuted for the above change.
3124 (map_sub_char_table): Delete args default_val and parent. Add arg
3125 top. Give decoded values to a Lisp function.
640c8776 3126 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3127 values to a Lisp function. Gcpro more variables.
3128 (uniprop_table_uncompress)
3129 (uniprop_decode_value_run_length): New functions.
3130 (uniprop_decoder, uniprop_decoder_count): New variables.
3131 (uniprop_get_decoder, uniprop_encode_value_character)
3132 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3133 New functions.
3134 (uniprop_encoder, uniprop_encoder_count): New variables.
3135 (uniprop_get_encoder, uniprop_table)
3136 (Funicode_property_table_internal, Fget_unicode_property_internal)
3137 (Fput_unicode_property_internal): New functions.
3138 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3139 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3140 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3141 char-code-property-alist.
3142
640c8776 3143 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3144 Vunicode_category_table.
3145
640c8776 3146 * font.c (font_range): Adjust for the change of
c805dec0
KH
3147 Vunicode_category_table.
3148
76b397fb
DN
31492011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3150
3151 * m/iris4d.h: Remove file, move contents ...
3152 * s/irix6-5.h: ... here.
3153
22b4128e
PE
31542011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3157 * alloc.c (mark_buffer):
3158 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3159 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3160 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3161 This isn't true in general, and it's particularly not true
3162 if Emacs is configured with --with-wide-int.
3163 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3164 New macros, used in the buffer.c change.
3165
869795d6
JD
31662011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3167
3168 * xsettings.c: Use both GConf and GSettings if both are available.
3169 (store_config_changed_event): Add comment.
3170 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3171 (store_tool_bar_style_changed): New functions.
5e617bc2 3172 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3173 (struct xsettings): Move font inside HAVE_XFT.
3174 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3175 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3176 Move inside HAVE_XFT.
640c8776 3177 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3178 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3179 also.
3180 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3181 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3182 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3183 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3184 (parse_settings): Move check for font inside HAVE_XFT.
3185 (read_settings, apply_xft_settings): Add comment.
3186 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3187 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3188 call store_font_name_changed.
3189 (xft_settings_event): Add comment.
3190 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3191 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3192 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3193 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3194 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3195 (xsettings_get_system_font, xsettings_get_system_normal_font):
3196 Add comment.
869795d6 3197
d8ed26bd
PE
31982011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3199
3200 Random fixes. E.g., (random) never returned negative values.
3201 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3202 subseconds part to the entropy, as that's a bit more random.
3203 Prefer signed to unsigned, since the signedness doesn't matter and
3204 in general we prefer signed. When given a limit, use a
3205 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3206 latter isn't right if USE_2_TAGS_FOR_INTS.
3207 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3208 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3209
cabf1cac
SM
32102011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3211
3212 * textprop.c (text_property_stickiness):
3213 Obey Vtext_property_default_nonsticky.
3214 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3215 * w32fns.c (syms_of_w32fns):
3216 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3217
6e9b2be9
PE
32182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3219
3220 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3221 This is more efficient than Ffile_directory_p and avoids a minor race.
3222
90186c68
LMI
32232011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3224
7c301272
LMI
3225 * buffer.c (Foverlay_put): Say what the return value is
3226 (bug#7835).
3227
c4f2d8d4
LMI
3228 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3229 is a directory before asking whether to use the file name
3230 (bug#7564).
ad637907
LMI
3231 (barf_or_query_if_file_exists): Make the "File is a directory"
3232 error be more correct.
c4f2d8d4 3233
90186c68
LMI
3234 * fns.c (Frequire): Remove the mention of the .gz files, since
3235 that's installation-specific, but keep the mention of
3236 `get-load-suffixes'.
3237
da64016e
PE
32382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3239
3240 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3241 Report string overflow if the output is too long.
3242
7d47b580
JB
32432011-07-04 Juanma Barranquero <lekktu@gmail.com>
3244
a555cb87
JB
3245 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3246 (syms_of_gnutls): Remove duplicate DEFSYM for
3247 Qgnutls_bootprop_verify_hostname_error, an error for
3248 Qgnutls_bootprop_verify_error (which is no longer used).
3249
7d47b580
JB
3250 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3251 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3252 Also (re)move comments that are misplaced or no longer relevant.
3253
1e49bfab
LMI
32542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3255
3256 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3257
1485f4c0
CY
32582011-07-03 Chong Yidong <cyd@stupidchicken.com>
3259
3260 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3261 and background color parameters if they have been changed.
3262
a9ab721e
LMI
32632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3264
3265 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3266
cf7cff57
PE
32672011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3268
2e13213d
PE
3269 * xsettings.c (SYSTEM_FONT): Define only when used.
3270 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3271
cf7cff57
PE
3272 * keymap.c (access_keymap_1): Now static.
3273
7a8e04f7
CY
32742011-07-02 Chong Yidong <cyd@stupidchicken.com>
3275
3276 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3277 leave any prefix arg for the up event (Bug#1586).
3278
61352f62
LMI
32792011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3280
69bb1ef7
LMI
3281 * lread.c (syms_of_lread): Mention single symbols defined by
3282 `defvar' or `defconst' (bug#7154).
3283
61352f62 3284 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3285 (Frequire): Mention get-load-suffixes.
61352f62 3286
28545e04
MR
32872011-07-02 Martin Rudalics <rudalics@gmx.at>
3288
3289 * window.h (window): Remove clone_number slot.
3290 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3291 Remove.
3292 (make_parent_window, make_window, saved_window)
3293 (Fset_window_configuration, save_window_save): Don't deal with
3294 clone numbers.
3295 * buffer.c (Qclone_number): Remove declaration.
3296 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3297
3349e122
SM
32982011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3299
3300 Add multiple inheritance to keymaps.
3301 * keymap.c (Fmake_composed_keymap): New function.
3302 (Fset_keymap_parent): Simplify.
3303 (fix_submap_inheritance): Remove.
3304 (access_keymap_1): New function extracted from access_keymap to handle
3305 embedded parents and handle lists of maps.
3306 (access_keymap): Use it.
3307 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3308 (Fcopy_keymap): Handle embedded parents.
3309 (Fcommand_remapping, define_as_prefix): Simplify.
3310 (Fkey_binding): Simplify.
3311 (syms_of_keymap): Move minibuffer-local-completion-map,
3312 minibuffer-local-filename-completion-map,
3313 minibuffer-local-must-match-map, and
3314 minibuffer-local-filename-must-match-map to Elisp.
3315 (syms_of_keymap): Defsubr make-composed-keymap.
3316 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3317 (parse_menu_item): Trivial simplification.
3318
3279eb87
GM
33192011-07-01 Glenn Morris <rgm@gnu.org>
3320
3321 * Makefile.in (SETTINGS_LIBS): Fix typo.
3322
4550efdf
KI
33232011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3324
3325 * coding.c (Fencode_coding_string): Record the last coding system
3326 used, as the function doc string says (bug#8738).
3327
0949d2b6
JD
33282011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3329
3330 * xsettings.c (store_monospaced_changed): Take new font as arg and
3331 check for change against current_mono_font.
3332 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3333 (emacs_settings_constructor, emacs_settings_get_property)
3334 (emacs_settings_set_property, emacs_settings_class_init)
3335 (emacs_settings_init, gsettings_obj): Remove.
3336 (something_changedCB): New function for HAVE_GSETTINGS.
3337 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3338 with value as argument.
3339 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3340 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3341 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3342 "changed".
3343
3344 * xgselect.c: Add defined (HAVE_GSETTINGS).
3345 (xgselect_initialize): Ditto.
3346
3347 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3348 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3349 xg_select.
3350
bbc6b304
PE
33512011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3352
3353 * eval.c (struct backtrace): Simplify and port the data structure.
3354 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3355 signed bit field, as this assumption is not portable and it makes
3356 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3357 "char debug_on_exit : 1" as this is not portable either; instead,
3358 use the portable "unsigned int debug_on_exit : 1". Remove unused
3359 member evalargs. Remove obsolete comments about cc bombing out.
3360
9851bfc5
JD
33612011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3362
51bb811f 3363 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3364 Let HAVE_GSETTINGS override HAVE_GCONF.
3365 (store_monospaced_changed): New function.
3366 (EMACS_SETTINGS): A new type derived from GObject to handle
3367 GSettings notifications.
3368 (emacs_settings_constructor, emacs_settings_get_property)
3369 (emacs_settings_set_property, emacs_settings_class_init):
3370 New functions.
3371 (gsettings_client, gsettings_obj): New variables.
3372 (GSETTINGS_SCHEMA): New define.
3373 (something_changedCB): Call store_monospaced_changed.
3374 (init_gsettings): New function.
3375 (xsettings_initialize): Call init_gsettings.
3376 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3377 to NULL.
3378
640c8776 3379 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3380 GCONF_CFLAGS/LIBS.
3381
5386012d
MR
33822011-06-29 Martin Rudalics <rudalics@gmx.at>
3383
3384 * window.c (resize_root_window, grow_mini_window)
3385 (shrink_mini_window): Rename Qresize_root_window to
3386 Qwindow_resize_root_window and Qresize_root_window_vertically to
3387 Qwindow_resize_root_window_vertically.
3388
f13e0b08
PE
33892011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3390
3391 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3392
94515237
JB
33932011-06-27 Juanma Barranquero <lekktu@gmail.com>
3394
3395 * makefile.w32-in: Redesign dependencies so they reflect more
3396 clearly which files are directly included by each source file,
3397 and not through other includes.
3398
e43b6e43
MR
33992011-06-27 Martin Rudalics <rudalics@gmx.at>
3400
3401 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3402 (sort_overlays, overlay_strings): When an overlay's clone number
3403 matches the window's clone number process the overlay even if
3404 the overlay's window property doesn't match the current window.
3405
d68443dc
MR
3406 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3407 (Fwindow_hchild): Rename to Fwindow_left_child.
3408 (Fwindow_next): Rename to Fwindow_next_sibling.
3409 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3410 (resize_window_check): Rename to window_resize_check.
3411 (resize_window_apply): Rename to window_resize_apply.
3412 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3413 (Fdelete_other_windows_internal, resize_frame_windows)
3414 (Fsplit_window_internal, Fdelete_window_internal)
3415 (grow_mini_window, shrink_mini_window)
3416 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3417
c7e73be5
JD
34182011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3419
3420 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3421 (emacs_fixed_set_min_size): Remove.
3422 (emacs_fixed_new): Take frame as argument.
3423
3424 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3425 (_EmacsFixedPrivate): Remove minwidth/height.
3426 Add struct frame *f.
3427 (emacs_fixed_init): Initialize priv->f.
3428 (get_parent_class, emacs_fixed_set_min_size): Remove.
3429 (emacs_fixed_new): Set priv->f to argument.
3430 (emacs_fixed_get_preferred_width)
3431 (emacs_fixed_get_preferred_height): Use min_width/height from
3432 frames size_hint to set minimum and natural (Bug#8919).
3433 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3434 and use min_width/height from frames size_hint to set
3435 min_width/height (Bug#8919).
3436
3437 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3438 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3439 Fix indentation.
c7e73be5 3440
cf99dcf8
EZ
34412011-06-26 Eli Zaretskii <eliz@gnu.org>
3442
3443 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3444 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3445 called at ZV.
3446
029529ac
CY
34472011-06-26 Chong Yidong <cyd@stupidchicken.com>
3448
3449 * process.c (wait_reading_process_output): Bypass select if
3450 waiting for a cell while ignoring keyboard input, and input is
3451 pending. Suggested by Jan Djärv (Bug#8869).
3452
7a7ef429
PE
34532011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3454
3455 Use gnulib's dup2 module instead of rolling our own.
3456 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3457
11fdef7d 34582011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3459
3460 * dispnew.c (scrolling_window): Before scrolling, turn off a
3461 mouse-highlight in the window being scrolled.
3462
cd3520a4
JB
34632011-06-24 Juanma Barranquero <lekktu@gmail.com>
3464
3465 Move DEFSYM to lisp.h and use everywhere.
3466
3467 * character.h (DEFSYM): Move declaration...
3468 * lisp.h (DEFSYM): ...here.
3469
3470 * gnutls.c:
3471 * minibuf.c:
3472 * w32menu.c:
3473 * w32proc.c:
3474 * w32select.c: Don't include character.h.
3475
3476 * alloc.c (syms_of_alloc):
3477 * buffer.c (syms_of_buffer):
3478 * bytecode.c (syms_of_bytecode):
3479 * callint.c (syms_of_callint):
3480 * casefiddle.c (syms_of_casefiddle):
3481 * casetab.c (init_casetab_once):
3482 * category.c (init_category_once, syms_of_category):
3483 * ccl.c (syms_of_ccl):
3484 * cmds.c (syms_of_cmds):
3485 * composite.c (syms_of_composite):
3486 * dbusbind.c (syms_of_dbusbind):
3487 * dired.c (syms_of_dired):
3488 * dispnew.c (syms_of_display):
3489 * doc.c (syms_of_doc):
3490 * editfns.c (syms_of_editfns):
3491 * emacs.c (syms_of_emacs):
3492 * eval.c (syms_of_eval):
3493 * fileio.c (syms_of_fileio):
3494 * fns.c (syms_of_fns):
3495 * frame.c (syms_of_frame):
3496 * fringe.c (syms_of_fringe):
3497 * insdel.c (syms_of_insdel):
3498 * keymap.c (syms_of_keymap):
3499 * lread.c (init_obarray, syms_of_lread):
3500 * macros.c (syms_of_macros):
3501 * msdos.c (syms_of_msdos):
3502 * print.c (syms_of_print):
3503 * process.c (syms_of_process):
3504 * search.c (syms_of_search):
3505 * sound.c (syms_of_sound):
3506 * syntax.c (init_syntax_once, syms_of_syntax):
3507 * terminal.c (syms_of_terminal):
3508 * textprop.c (syms_of_textprop):
3509 * undo.c (syms_of_undo):
3510 * w32.c (globals_of_w32):
3511 * window.c (syms_of_window):
3512 * xdisp.c (syms_of_xdisp):
3513 * xfaces.c (syms_of_xfaces):
3514 * xfns.c (syms_of_xfns):
3515 * xmenu.c (syms_of_xmenu):
3516 * xsettings.c (syms_of_xsettings):
3517 * xterm.c (syms_of_xterm): Use DEFSYM.
3518
4228cf16
TZ
35192011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3520
cd3520a4 3521 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3522
7fcccf1e
PE
35232011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3524
7efb4e0e
PE
3525 Integer and buffer overflow fixes (Bug#8873).
3526
ff5844ad
PE
3527 * print.c (printchar, strout): Check for string overflow.
3528 (PRINTPREPARE, printchar, strout):
3529 Don't set size unless allocation succeeds.
3530
90532f02
PE
3531 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3532 for sizes. Check for string overflow more accurately.
3533 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3534
6d84508d
PE
3535 * macros.c: Integer and buffer overflow fixes.
3536 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3537 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3538 Use ptrdiff_t, not int, for sizes.
3539 Don't increment bufsize until after realloc succeeds.
3540 Check for size-calculation overflow.
3541 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3542
437b2cb4
PE
3543 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3544
8b9ac8b4
PE
3545 * lread.c: Integer overflow fixes.
3546 (read_integer): Radix is now EMACS_INT, not int,
3547 to improve quality of diagnostics for out-of-range radices.
3548 Calculate buffer size correctly for out-of-range radices.
3549 (read1): Check for integer overflow in radices, and in
3550 read-circle numbers.
82cb60d3
PE
3551 (read_escape): Avoid int overflow.
3552 (Fload, openp, read_buffer_size, read1)
3553 (substitute_object_recurse, read_vector, read_list, map_obarray):
3554 Use ptrdiff_t, not int, for sizes.
3555 (read1): Use EMACS_INT, not int, for sizes.
20270765 3556 Check for size overflow.
8b9ac8b4 3557
7fcccf1e
PE
3558 * image.c (cache_image): Check for size arithmetic overflow.
3559
bfbbd7e7
PE
3560 * lread.c: Integer overflow issues.
3561 (saved_doc_string_size, saved_doc_string_length)
3562 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3563 Now ptrdiff_t, not int.
3564 (read1): Don't assume doc string length fits in int. Check for
3565 out-of-range doc string lengths.
3566 (read_list): Don't assume file position fits in int.
39019e54 3567 (read_escape): Check for hex character overflow.
bfbbd7e7 3568
4e323265
LL
35692011-06-22 Leo Liu <sdl.web@gmail.com>
3570
3571 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3572 Move to minibuffer.el.
3573
85fece3e
PE
35742011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3575
20b84ce9 3576 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3577 The following patches are for when GLYPH_DEBUG && !XASSERT.
3578 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3579 * dispnew.c (flush_stdout):
3580 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3581 Mark as externally visible.
3582 * dispnew.c (check_window_matrix_pointers): Now static.
3583 * dispnew.c (window_to_frame_vpos):
3584 * xfns.c (unwind_create_frame):
3585 * xterm.c (x_check_font): Remove unused local.
3586 * scroll.c (CHECK_BOUNDS):
3587 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3588 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3589 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3590 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3591 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3592 Now static.
3593 (debug_method_add): Use va_list and vsprintf rather than relying
3594 on undefined behavior with wrong number of arguments.
3595 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3596 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3597 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3598 since we're not interested in debugging glyphs with old libraries.
3599 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3600 GCC 4.6.0's static checking.
3601
0766b489
PE
36022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3603
31fd4b32
PE
3604 Integer overflow and signedness fixes (Bug#8873).
3605 A few related buffer overrun fixes, too.
3606
b79e8648
PE
3607 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3608
0766b489
PE
3609 * dispextern.h (struct face.stipple):
3610 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3611 (x_bitmap_mask, x_allocate_bitmap_record)
3612 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3613 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3614 (x_create_bitmap_from_xpm_data):
3615 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3616 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3617 (.bitmaps_last):
3618 * xfaces.c (load_pixmap):
3619 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3620 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3621 (.bitmaps_last, struct x_output.icon_bitmap):
3622 Use ptrdiff_t, not int, for bitmap indexes.
3623 (x_allocate_bitmap_record): Check for size overflow.
3624 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3625
b081724f
PE
3626 Use ptrdiff_t, not int, for overlay counts.
3627 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3628 * editfns.c (overlays_around, get_pos_property):
3629 * textprop.c (get_char_property_and_overlay):
3630 * xdisp.c (next_overlay_change, note_mouse_highlight):
3631 * xfaces.c (face_at_buffer_position):
21514da7
PE
3632 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3633 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3634 (Fnext_overlay_change, Fprevious_overlay_change)
3635 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3636 Use ptrdiff_t, not int, for sizes.
21514da7 3637 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3638
3de73e5e
PE
3639 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3640
2606c57b
PE
3641 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3642 (x_session_initialize): Do not assume string length fits in int.
3643
aaafe47a
PE
3644 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3645 This is unlikely, but can occur if DPI is outlandish.
3646
2674ddc8 3647 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3648 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3649
28154962
PE
3650 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3651 * xrdb.c (magic_file_p, search_magic_path):
3652 Omit last arg SUFFIX; it was always 0. All callers changed.
3653 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3654
7de51af5
PE
3655 * xfont.c (xfont_match): Avoid need for strlen.
3656
25ed6cc3
PE
3657 * xfns.c: Don't assume strlen fits in int.
3658 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3659
4eab31dd
PE
3660 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3661 not unsigned long, as we prefer signed integers. All callers changed.
3662 Detect integer overflow in repeat count.
3663 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3664 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3665
171e2a58
PE
3666 * termcap.c: Don't assume sizes fit in int and never overflow.
3667 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3668 (gobble_line): Check for size-calculation overflow.
3669
ad39faca 3670 * minibuf.c (Fread_buffer):
6e5bb2dc 3671 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3672 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3673 Don't assume string length fits in int.
3674
52c61c22 3675 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3676 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3677
b5b8c9e5
PE
3678 * font.c: Don't assume string length fits in int.
3679 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3680 Use ptrdiff_t, not int.
ccd6111c
PE
3681 (font_intern_prop): Don't assume string length fits in int.
3682 Don't assume integer property fits in fixnum.
3683 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3684
882f0d81 3685 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3686 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3687 Reformulate so as not to need the command string.
3688 Invoke gzip -cd rather than gunzip, as it's more portable.
3689 (lock_info_type, lock_file_1, lock_file):
3690 Don't assume pid_t and time_t fit in unsigned long.
3691 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3692 (current_lock_owner): Prefer signed type for sizes.
3693 Use memcpy, not strncpy, where memcpy is what is really wanted.
3694 Don't assume (via atoi) that time_t and pid_t fit in int.
3695 Check for time_t and/or pid_t out of range, e.g., via a network share.
3696 Don't alloca where an auto var works fine.
3697
93f4cf88
PE
3698 * fileio.c: Fix some integer overflow issues.
3699 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3700 Don't assume string length fits in int.
3701 (directory_file_name): Don't assume string length fits in long.
3702 (make_temp_name): Don't assume pid fits in int, or that its print
3703 length is less than 20.
3704
f3e92b69
PE
3705 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3706
1bfdaf10
PE
3707 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3708
35016e9a
PE
3709 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3710
3d1e65a1
PE
3711 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3712 We prefer signed integers, even for size calculations.
3713
0b963a93
PE
3714 * emacs.c: Don't assume string length fits in 'int'.
3715 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3716 (main): Don't invoke strlen when not needed.
3717
573f4b54
PE
3718 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3719 (XD_DEBUG_MESSAGE): Don't waste a byte.
3720
989f33ba
PE
3721 * callproc.c (getenv_internal_1, getenv_internal)
3722 (Fgetenv_internal):
965d34eb
PE
3723 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3724
e4d29b33
PE
3725 * lread.c (invalid_syntax): Omit length argument.
3726 All uses changed. This doesn't fix a bug, but it simplifies the
3727 code away from its former Hollerith-constant appearance, and it's
3728 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3729 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3730
eb49b136
PE
3731 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3732 This didn't break anything, but it didn't help either.
3733 It's confusing to put a bogus integer in a place where the actual
3734 value does not matter.
9f62aeb1 3735 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3736 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3737
15375a22
PE
3738 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3739 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3740 implementation.
b61cc01c
PE
3741 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3742 We prefer signed types, and the value cannot exceed the EMACS_INT
3743 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3744 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3745 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3746 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3747
53b2623d
PE
3748 * indent.c (sane_tab_width): New function.
3749 (current_column, scan_for_column, Findent_to, position_indentation)
3750 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3751 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3752
51cab52b 3753 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3754
f2ed8a70
PE
3755 * lisp.h (lint_assume): New macro.
3756 * composite.c (composition_gstring_put_cache):
3757 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3758
abe80cc6
PE
3759 * editfns.c, insdel.c:
3760 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3761
b02c740e
PE
3762 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3763
ebc96716
PE
3764 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3765
b4e50fa0 3766 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3767 Use much-faster test for byte-length change.
311d5d7c 3768 Don't assume string byte-length fits in 'int'.
a4cf38e4 3769 Check that character arg fits in 'int'.
85461888 3770 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3771
c0c1ee9f
PE
3772 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3773
a498d7f4
PE
3774 * fns.c (concat): Catch string overflow earlier.
3775 Do not rely on integer wraparound.
3776
51cab52b
PE
3777 * dispextern.h (struct it.overlay_strings_charpos)
3778 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3779 * xdisp.c (forward_to_next_line_start)
3780 (back_to_previous_visible_line_start)
3781 (reseat_at_next_visible_line_start, next_element_from_buffer):
3782 Don't arbitrarily truncate the value of 'selective' to int.
3783
76031fad
PE
3784 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3785
5eb55db9
PE
3786 * composite.c: Don't truncate sizes to 'int'.
3787 (composition_gstring_p, composition_reseat_it)
3788 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3789 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3790 not EMACS_UINT, for indexes.
5eb55db9 3791
0703a717
PE
3792 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3793
d6202519
PE
3794 * buffer.c: Include <verify.h>.
3795 (struct sortvec.priority, struct sortstr.priority):
8961a454 3796 Now EMACS_INT, not int.
c20998a7 3797 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3798 (struct sortstr.size, record_overlay_string)
3799 (struct sortstrlist.size, struct sortlist.used):
3800 Don't truncate size to int.
3801 (record_overlay_string): Check for size-calculation overflow.
d6202519 3802 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3803
d5a19415
JM
38042011-06-22 Jim Meyering <meyering@redhat.com>
3805
029529ac 3806 Don't leak an XBM-image-sized buffer
d5a19415
JM
3807 * image.c (xbm_load): Free the image buffer after using it.
3808
a9041e6c
PE
38092011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3810
3811 Port to Sun C.
3812 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3813 that Sun C diagnosed.
3814 * fns.c (secure_hash): Fix pointer signedness issue.
3815 * intervals.c (static_offset_intervals): New function.
3816 (offset_intervals): Use it.
3817
7f3f739f
LL
38182011-06-21 Leo Liu <sdl.web@gmail.com>
3819
3820 * deps.mk (fns.o):
3821 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3822 sha512.h.
3823
3824 * fns.c (secure_hash): Rename from crypto_hash_function and change
3825 the first arg to accept symbols.
5b66d427 3826 (Fsecure_hash): New primitive.
7f3f739f
LL
3827 (syms_of_fns): New symbols.
3828
76147d94
DD
38292011-06-20 Deniz Dogan <deniz@dogan.se>
3830
3831 * process.c (Fset_process_buffer): Clarify return value in
3832 docstring.
3833
7d7d0045
CY
38342011-06-18 Chong Yidong <cyd@stupidchicken.com>
3835
3836 * dispnew.c (add_window_display_history): Use BVAR.
3837
3838 * xdisp.c (debug_method_add): Use BVAR.
3839 (check_window_end, dump_glyph_matrix, dump_glyph)
3840 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3841
3842 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3843 Likewise.
3844
3845 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3846 check till after the cache is created in init_frame_faces.
3847
ff2bc410
SM
38482011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3849
3850 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3851
28177add
PE
38522011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3853
dd3482fe
PE
3854 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3855 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3856 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3857
393d71f3 3858 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3859 * fileio.c (Finsert_file_contents):
3860 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3861 Remove the old (too-loose) buffer overflow checks.
3862 They weren't needed, since make_gap checks for buffer overflow.
3863 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3864 The old code merely checked for Emacs fixnum overflow, and relied
3865 on undefined (wraparound) behavior. The new code avoids undefined
3866 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3867
2e6813b0 3868 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3869 Tune. Don't use wider integers than needed. Don't use alloca.
3870 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3871
599a9e4f
PE
3872 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3873
99561444
PE
3874 * insdel.c, lisp.h (buffer_overflow): New function.
3875 (insert_from_buffer_1, replace_range, replace_range_2):
3876 * insdel.c (make_gap_larger):
3877 * editfns.c (Finsert_char):
3878 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3879
28177add
PE
3880 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3881
e69dafad
PE
38822011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3883
a7af7fde 3884 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3885
b1c46f02
PE
3886 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3887 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3888
e69dafad
PE
3889 * fileio.c: Don't assume EMACS_INT fits in off_t.
3890 (emacs_lseek): New static function.
3891 (Finsert_file_contents, Fwrite_region): Use it.
3892 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3893
566684ea
PE
3894 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3895
e6966cd6
PE
3896 * fns.c: Don't overflow int when computing a list length.
3897 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3898 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3899 truncation on 64-bit hosts. Check for QUIT every
3900 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3901 faster and is responsive enough.
3902 (Flength): Report an error instead of overflowing an integer.
3903 (Fsafe_length): Return a float if the value is not representable
3904 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3905 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3906 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3907
dd0b0efb
PE
3908 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3909 (header_size, word_size): New constants.
3910 (allocate_vectorlike): Don't check size overflow here.
3911 (allocate_vector): Check it here instead, since this is the only
3912 caller of allocate_vectorlike that could cause overflow.
3913 Check that the new vector's length is representable as a fixnum.
3914
86fe5cfe
PE
3915 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3916 The previous code was bogus. For example, next_almost_prime (32)
3917 returned 39, which is undesirable as it is a multiple of 3; and
3918 next_almost_prime (24) returned 25, which is a multiple of 5 so
3919 why was the code bothering to check for multiples of 7?
3920
80e88859
PE
3921 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3922
4a2f0ad6
PE
3923 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3924
f66c7cf8
PE
3925 Variadic C functions now count arguments with ptrdiff_t.
3926 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3927 Back then I didn't know that the Emacs coding style prefers signed int.
3928 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3929 were being counted with int, which may truncate counts on 64-bit
3930 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3931 * lisp.h (struct Lisp_Subr.function.aMANY)
3932 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3933 Arg counts are now ptrdiff_t, not size_t.
3934 All variadic functions and their callers changed accordingly.
3935 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3936 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3937 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3938 * callint.c (Fcall_interactively): Check arg count for overflow,
3939 to avoid potential buffer overrun. Use signed char, not 'int',
3940 for 'varies' array, so that we needn't bother to check its size
3941 calculation for overflow.
3942 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3943 * eval.c (apply_lambda):
3944 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3945 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3946 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3947
a1759b76
PE
3948 * callint.c (Fcall_interactively): Don't use index var as event count.
3949
d96be9fc
PE
3950 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3951 * mem-limits.h (SIZE): Remove; no longer used.
3952
a690a978 3953 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3954
578c21e6
PE
3955 Remove unnecessary casts.
3956 * xterm.c (x_term_init):
3957 * xfns.c (x_set_border_pixel):
3958 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3959 These aren't needed now that we assume ANSI C.
3960
96f53c6c
PE
3961 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3962 It's more likely to cause problems (due to unsigned overflow)
3963 than to cure them.
3964
83c77d31
PE
3965 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3966
ee2079f1
PE
3967 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3968
6da65536
PE
3969 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3970
7147c4a4
PE
3971 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3972
193e32d9
PE
3973 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3974
e5533da6
PE
3975 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3976
9910e595
PE
3977 GLYPH_CODE_FACE returns EMACS_INT, not int.
3978 * dispextern.h (merge_faces):
3979 * xfaces.c (merge_faces):
01103c44
PE
3980 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3981 Don't assume EMACS_INT fits in int.
9910e595 3982
2638320e
PE
3983 * character.h (CHAR_VALID_P): Remove unused parameter.
3984 * fontset.c, lisp.h, xdisp.c: All uses changed.
3985
045eb8d9
PE
3986 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3987
c1f134b5
PE
3988 * fns.c (concat): Minor tuning based on overflow analysis.
3989 This doesn't fix any bugs. Use int to hold character, instead
3990 of constantly refetching from Emacs object. Use XFASTINT, not
3991 XINT, for value known to be a character. Don't bother comparing
3992 a single byte to 0400, as it's always less.
3993
395fcb93 3994 * floatfns.c (Fexpt):
327eeec8
PE
3995 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3996
abbd3d23
PE
3997 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3998 for characters.
3999
684a03ef
PE
4000 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4001
0fed43f3
PE
4002 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4003 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4004 incorrectly succeed when S was a string, because 4294967386 was
4005 truncated before it was used.
4006
8fd02eb7
PE
4007 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4008 Otherwise, an out-of-range integer could cause undefined behavior
4009 on a 64-bit host.
4010
f8c86b69
PE
4011 * composite.c: Use int, not EMACS_INT, for characters.
4012 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4013 EMACS_INT, for values that are known to be in character range.
4014 This doesn't fix any bugs but is the usual style inside Emacs and
4015 may generate better code on 32-bit machines.
4016
34206dd2
PE
4017 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4018 This is for reasons similar to the recent CHAR_STRING fix.
4019 * charset.c (Fencode_char): Check that character arg is actually
4020 a character. Pass an int to ENCODE_CHAR.
4021 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4022 wider than 'int', as a compile-time check to prevent future regressions
4023 in this area.
4024
c5958d4c 4025 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4026
4027 Make sure a 64-bit char is never passed to CHAR_STRING.
4028 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4029 by silently ignoring the top 32 bits, allowing some values
4030 that were far too large to be valid characters.
4031 * character.h: Include <verify.h>.
4032 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4033 arguments are no wider than unsigned, as a compile-time check
4034 to prevent future regressions in this area.
4035 * data.c (Faset):
01103c44 4036 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4037 (Fsubst_char_in_region):
4038 * fns.c (concat):
4039 * xdisp.c (decode_mode_spec_coding):
4040 Adjust to CHAR_STRING's new requirement.
4041 * editfns.c (Finsert_char, Fsubst_char_in_region):
4042 * fns.c (concat): Check that character args are actually
4043 characters. Without this test, these functions did the wrong
4044 thing with wildly out-of-range values on 64-bit hosts.
4045
d37ca623
PE
4046 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4047 These casts should not be needed on 32-bit hosts, either.
4048 * keyboard.c (read_char):
4049 * lread.c (Fload): Remove casts to unsigned.
4050
ea204efb
PE
4051 * lisp.h (UNSIGNED_CMP): New macro.
4052 This fixes comparison bugs on 64-bit hosts.
4053 (ASCII_CHAR_P): Use it.
4054 * casefiddle.c (casify_object):
01103c44 4055 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4056 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4057 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4058 * dispextern.h (FACE_FROM_ID):
4059 * keyboard.c (read_char): Use UNSIGNED_CMP.
4060
41cb286c
PE
4061 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4062 not to EMACS_INT, to avoid GCC warning.
4063
4a1b9832
PE
4064 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4065
55daad71
PE
4066 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4067 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4068 isn't needed on 32-bit machines.
8f95c75c 4069
01103c44
PE
4070 * buffer.c (Fgenerate_new_buffer_name):
4071 Use EMACS_INT for count, not int.
0ceccced 4072 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4073
4074 * data.c (Qcompiled_function): Now static.
4075
c6f072e7
PE
4076 * window.c (window_body_lines): Now static.
4077
20ce5912
PE
4078 * image.c (gif_load): Rename local to avoid shadowing.
4079
9c4c5f81
PE
4080 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4081 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4082 * alloc.c (make_save_value): Integer argument is now of type
4083 ptrdiff_t, not int.
4084 (mark_object): Use ptrdiff_t, not int.
4085 * lisp.h (pD): New macro.
4086 * print.c (print_object): Use it.
4087
c0c5c8ae
PE
4088 * alloc.c: Use EMACS_INT, not int, to count objects.
4089 (total_conses, total_markers, total_symbols, total_vector_size)
4090 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4091 (total_free_floats, total_floats, total_free_intervals)
4092 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4093 Now EMACS_INT, not int. All uses changed.
4094 (Fgarbage_collect): Compute overall total using a double, so that
4095 integer overflow is less likely to be a problem. Check for overflow
4096 when converting back to an integer.
5a25e253
PE
4097 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4098 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4099 These were 'int' variables that could overflow on 64-bit hosts;
4100 they were never used, so remove them instead of repairing them.
211a0b2a 4101 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4102 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4103 Previously, this ceilinged at INT_MAX, but that doesn't work on
4104 64-bit machines.
e46bb31a 4105 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4106
c78baabf 4107 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4108 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4109 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4110 when a (possibly-narrower) signed value would do just as well.
4111 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4112
c9d624c6
PE
4113 * alloc.c: Catch some string size overflows that we were missing.
4114 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4115 for convenience in STRING_BYTES_MAX.
4116 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4117 The definition here is exact; the one in lisp.h was approximate.
4118 (allocate_string_data): Check for string overflow. This catches
4119 some instances we weren't catching before. Also, it catches
4120 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4121 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4122 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4123
c9d624c6
PE
4124 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4125 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4126 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4127
353032ce
PE
4128 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4129
2bccce07
PE
4130 * alloc.c (Fmake_string): Check for out-of-range init.
4131
0ac30604
SM
41322011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4133
4134 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4135
c195f2de
JD
41362011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4137
4138 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4139 xg_get_default_scrollbar_width.
4140
4141 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4142 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4143 (style_changed_cb): Call update_theme_scrollbar_width and call
4144 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4145 all frames (Bug#8505).
4146 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4147 Call gtk_window_set_resizable if HAVE_GTK3.
4148 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4149 and height if HAVE_GTK3 (Bug#8505).
4150 (scroll_bar_width_for_theme): New variable.
4151 (update_theme_scrollbar_width): New function.
4152 (xg_get_default_scrollbar_width): Move code to
4153 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4154 (xg_initialize): Call update_theme_scrollbar_width.
4155
4156 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4157
4158 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4159
e10ac9f1
MR
41602011-06-12 Martin Rudalics <rudalics@gmx.at>
4161
4162 * frame.c (make_frame): Call other_buffer_safely instead of
4163 other_buffer.
4164
4165 * window.c (temp_output_buffer_show): Call display_buffer with
4166 second argument Vtemp_buffer_show_specifiers and reset latter
4167 immediately after the call.
4168 (Vtemp_buffer_show_specifiers): New variable.
4169 (auto_window_vscroll_p, next_screen_context_lines)
4170 (Vscroll_preserve_screen_position): Remove leading asterisks from
4171 doc-strings.
4172
2d3c217e 41732011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4174
7b7f97e8 4175 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4176 * buffer.c (Qclone_number): Remove for now, as it's unused.
4177 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4178 (record_buffer): Remove unused local.
4179 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4180 (set_frame_buffer_list): Remove; unused.
4181 * frame.h (other_visible_frames): Remove decl.
4182 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4183 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4184 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4185 if HAVE_GPM.
4186 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4187 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4188 Define only if HAVE_GPM.
4189 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4190 (update_hints_inhibit): Remove; never set. All uses removed.
4191 * widgetprv.h (emacsFrameClassRec): Remove decl.
4192 * window.c (delete_deletable_window): Now returns void, since it
4193 wasn't returning anything.
4194 (compare_window_configurations): Remove unused locals.
4195 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4196 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4197 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4198 the same widths as pointers. This follows up on the 2011-05-06 patch.
4199 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4200 * xterm.h: Likewise.
4201 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4202
1384b89e
JB
42032011-06-12 Juanma Barranquero <lekktu@gmail.com>
4204
4205 * makefile.w32-in: Update dependencies.
4206 (LISP_H): Add lib/intprops.h.
4207
1100a63c
CY
42082011-06-11 Chong Yidong <cyd@stupidchicken.com>
4209
4210 * image.c (gif_load): Add animation frame delay to the metadata.
4211 (syms_of_image): Use DEFSYM. New symbol `delay'.
4212
6198ccd0
MR
42132011-06-11 Martin Rudalics <rudalics@gmx.at>
4214
4215 * window.c (delete_deletable_window): Re-add.
4216 (Fset_window_configuration): Rewrite to handle dead buffers and
4217 consequently deletable windows.
4218 (window_tree, Fwindow_tree): Remove. Supply functionality in
4219 window.el.
4220 (compare_window_configurations): Simplify code.
4221
b6e3633c
AS
42222011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4223
1ab0dee5
AS
4224 * image.c (imagemagick_load_image): Fix type mismatch.
4225 (Fimagemagick_types): Likewise.
4226
b6e3633c
AS
4227 * window.h (replace_buffer_in_windows): Declare.
4228
9397e56f
MR
42292011-06-11 Martin Rudalics <rudalics@gmx.at>
4230
4231 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4232 Qclone_number. Remove external declaration of Qdelete_window.
4233 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4234 code.
640c8776
SM
4235 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4236 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4237 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4238 buffer list implementation.
4239 (other_buffer_safely): New function.
4240 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4241 calls to replace_buffer_in_windows and
4242 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4243 if allowed.
4244 (record_buffer): Inhibit quitting and rewrite using quittable
4245 functions. Run Qbuffer_list_update_hook if allowed.
4246 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4247 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4248 Move switch-to-buffer to window.el.
9397e56f
MR
4249 (bury-buffer): Move to window.el.
4250 (Vbuffer_list_update_hook): New variable.
4251
4252 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4253 section.
4254
4255 * window.h (resize_frame_windows): Move up in code.
4256 (Fwindow_frame): Remove EXFUN.
4257 (replace_buffer_in_all_windows): Remove prototype.
4258 (replace_buffer_in_windows_safely): Add prototype.
4259
4260 * window.c: Declare Qdelete_window static again. Move down
4261 declaration of select_count.
4262 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4263 (Fother_window): Move to window.el.
4264 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4265 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4266 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4267 window.el.
4268 (replace_buffer_in_windows): Implement by calling
4269 Qreplace_buffer_in_windows.
4270 (replace_buffer_in_all_windows): Remove with some functionality
4271 moved into replace_buffer_in_windows_safely.
4272 (replace_buffer_in_windows_safely): New function.
4273 (select_window_norecord, select_frame_norecord): Move in front
4274 of run_window_configuration_change_hook. Remove now obsolete
4275 declarations.
640c8776
SM
4276 (Fset_window_buffer): Rewrite doc-string.
4277 Call Qrecord_window_buffer.
9397e56f
MR
4278 (keys_of_window): Move binding for other-window to window.el.
4279
b50691aa
CY
42802011-06-11 Chong Yidong <cyd@stupidchicken.com>
4281
4282 * dispextern.h (struct image): Replace data member, whose int_val
4283 and ptr_val fields were not used by anything, with a single
4284 lisp_val object.
4285
4286 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4287 (gif_clear_image, gif_load, imagemagick_load_image)
4288 (gs_clear_image, gs_load): Callers changed.
4289
3f754b86
PE
42902011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4291
cca69397
PE
4292 * buffer.h: Include <time.h>, for time_t.
4293 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4294
109e28d0
PE
4295 Fix minor problems found by static checking.
4296
60737f02
PE
4297 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4298
4b66faf3
PE
4299 Make identifiers static if they are not used in other modules.
4300 * data.c (Qcompiled_function, Qframe, Qvector):
4301 * image.c (QimageMagick, Qsvg):
4302 * minibuf.c (Qmetadata):
4303 * window.c (resize_window_check, resize_root_window): Now static.
4304 * window.h (resize_window_check, resize_root_window): Remove decls.
4305
109e28d0
PE
4306 * window.c (window_deletion_count, delete_deletable_window):
4307 Remove; unused.
46a4ce9e
PE
4308 (window_body_lines): Now static.
4309 (Fdelete_other_windows_internal): Mark vars as initialized.
4310 Make sure 'resize_failed' is initialized.
4311 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4312 (resize_window_apply): Remove unused local.
4313 * window.h (delete_deletable_window): Remove decl.
4314
109e28d0 4315 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4316 (imagemagick_load_image): Fix pointer signedness problem by changing
4317 last arg from unsigned char * to char *. All uses changed.
4318 Also, fix a local for similar reasons.
4319 Remove unused locals. Remove locals to avoid shadowing.
4320 (fn_rsvg_handle_free): Remove; unused.
4321 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4322 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4323
3f754b86
PE
4324 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4325
2547adb1
CY
43262011-06-10 Chong Yidong <cyd@stupidchicken.com>
4327
4328 * image.c (gif_load): Fix omitted cast error introduced by
4329 2011-06-06 change.
4330
2c8e37d4
MR
43312011-06-10 Martin Rudalics <rudalics@gmx.at>
4332
4333 * window.h (resize_proportionally, orig_total_lines)
4334 (orig_top_line): Remove from window structure.
4335 (set_window_height, set_window_width, change_window_heights)
4336 (Fdelete_window): Remove prototypes.
4337 (resize_frame_windows): Remove duplicate declaration.
4338
440a42e3
EZ
43392011-06-10 Eli Zaretskii <eliz@gnu.org>
4340
4341 * window.h (resize_frame_windows, resize_window_check)
4342 (delete_deletable_window, resize_root_window)
4343 (resize_frame_windows): Declare prototypes.
4344
4345 * window.c (resize_window_apply): Make definition be "static" to
4346 match the prototype.
4347
562dd5e9
MR
43482011-06-10 Martin Rudalics <rudalics@gmx.at>
4349
4350 * window.c: Remove declarations of Qwindow_size_fixed,
4351 window_min_size_1, window_min_size_2, window_min_size,
4352 size_window, window_fixed_size_p, enlarge_window, delete_window.
4353 Remove static from declaration of Qdelete_window, it's
4354 temporarily needed by Fbury_buffer.
4355 (replace_window): Don't assign orig_top_line and
4356 orig_total_lines.
4357 (Fdelete_window, delete_window): Remove. Window deletion is
4358 handled by window.el.
640c8776
SM
4359 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4360 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4361 (Fdelete_other_windows): Remove. Deleting other windows is
4362 handled by window.el.
4363 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4364 handled in window.el.
4365 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4366 Window minimum sizes are handled in window.el.
4367 (shrink_windows, size_window, set_window_height)
4368 (set_window_width, change_window_heights, window_height)
4369 (window_width, CURBEG, CURSIZE, enlarge_window)
4370 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4371 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4372 handled in window.el.
4373 (make_dummy_parent): Rename to make_parent_window and give it a
4374 second argument horflag.
4375 (make_window): Don't set resize_proportionally any more.
4376 (Fsplit_window): Remove. Windows are split in window.el.
4377 (save_restore_action, save_restore_orig_size)
4378 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4379 Resize mini windows in window.el.
4380 (grow_mini_window, shrink_mini_window): Implement by calling
4381 Qresize_root_window_vertically, resize_window_check and
4382 resize_window_apply.
640c8776
SM
4383 (saved_window, Fset_window_configuration, save_window_save):
4384 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4385 resize_proportionally.
4386 (window_min_height, window_min_width): Move to window.el.
4387 (keys_of_window): Move bindings for delete-other-windows,
4388 split-window, delete-window and enlarge-window to window.el.
4389
4390 * buffer.c: Temporarily extern Qdelete_window.
4391 (Fbury_buffer): Temporarily call Qdelete_window instead of
4392 Fdelete_window (Fbury_buffer will move to window.el soon).
4393
4394 * frame.c (set_menu_bar_lines_1): Remove code handling
4395 orig_top_line and orig_total_lines.
4396
4397 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4398 set_window_height but set heights directly.
4399 (change_frame_size_1): Use resize_frame_windows.
4400
4401 * xdisp.c (init_xdisp): Don't use set_window_height but set
4402 heights directly.
4403
640c8776
SM
4404 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4405 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4406 run_window_configuration_change_hook.
4407
4408 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4409 instead of change_window_heights and run
4410 run_window_configuration_change_hook.
4411
1a13852e
MR
44122011-06-09 Martin Rudalics <rudalics@gmx.at>
4413
4414 * window.c (replace_window): Rename second argument REPLACEMENT to
4415 NEW. New third argument SETFLAG. Rewrite.
4416 (delete_window, make_dummy_parent): Call replace_window with
4417 third argument 1.
4418 (window_list_1): Move down in code.
4419 (run_window_configuration_change_hook): Move set_buffer part
4420 before select_frame_norecord part in order to unwind correctly.
4421 Rename count1 to count.
4422 (recombine_windows, delete_deletable_window, resize_root_window)
4423 (Fdelete_other_windows_internal)
4424 (Frun_window_configuration_change_hook, make_parent_window)
4425 (resize_window_check, resize_window_apply, Fresize_window_apply)
4426 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4427 (Fdelete_window_internal, Fresize_mini_window_internal):
4428 New functions.
1a13852e
MR
4429 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4430
f3d1777e
MR
44312011-06-08 Martin Rudalics <rudalics@gmx.at>
4432
496e208e
MR
4433 * window.h (window): Add some new members to window structure -
4434 normal_lines, normal_cols, new_total, new_normal, clone_number,
4435 splits, nest, prev_buffers, next_buffers.
4436 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4437 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4438
f3d1777e
MR
4439 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4440 Remove.
496e208e
MR
4441 (make_dummy_parent): Set new members of windows structure.
4442 (make_window): Move down in code. Handle new members of window
4443 structure.
4444 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4445 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4446 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4447 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4448 (Fset_window_next_buffers, Fset_window_clone_number):
4449 New functions.
496e208e
MR
4450 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4451 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4452 Doc-string fixes.
4453 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4454 Argument WINDOW can be now internal window too.
4455 (Fwindow_use_time): Move up in code.
4456 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4457 Rewrite doc-string.
4458 (Fset_window_configuration, saved_window)
4459 (Fcurrent_window_configuration, save_window_save): Handle new
4460 members of window structure.
b9e809c2
MR
4461 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4462 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4463 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4464 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4465 Qget_mru_window, Qresize_root_window,
4466 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4467 Qauto_buffer_name; staticpro them.
f3d1777e 4468
abde8f8c
MR
44692011-06-07 Martin Rudalics <rudalics@gmx.at>
4470
4471 * window.c (Fwindow_total_size, Fwindow_left_column)
4472 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4473 (Fwindow_list_1): New functions.
4474 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4475 (Fwindow_width, Fscroll_left, Fscroll_right):
4476 Use window_body_cols instead of window_box_text_cols.
4477 (delete_window, Fset_window_configuration):
4478 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4479 (delete_all_subwindows): Take a window as argument and not a
4480 structure. Rewrite.
190b47e6
MR
4481 (window_loop): Remove handling of GET_LRU_WINDOW and
4482 GET_LARGEST_WINDOW.
4483 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4484
4485 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4486 window_box_text_cols. delete_all_subwindows now takes a
4487 Lisp_Object as argument.
abde8f8c 4488
640c8776
SM
4489 * indent.c (compute_motion, Fcompute_motion):
4490 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4491
fa8a67e6
MR
4492 * frame.c (delete_frame): Call delete_all_subwindows with root
4493 window as argument.
4494
a54e3482
DC
44952011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4496
4497 * fns.c (Fputhash): Document return value.
4498
60002bf5
CY
44992011-06-06 Chong Yidong <cyd@stupidchicken.com>
4500
4501 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4502
0c671da6 45032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4504
b862a52a 4505 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4506
be44ca6c
PE
4507 Check for overflow when converting integer to cons and back.
4508 * charset.c (Fdefine_charset_internal, Fdecode_char):
4509 Use cons_to_unsigned to catch overflow.
4510 (Fencode_char): Use INTEGER_TO_CONS.
4511 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4512 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4513 * data.c (long_to_cons, cons_to_long): Remove.
4514 (cons_to_unsigned, cons_to_signed): New functions.
4515 These signal an error for invalid or out-of-range values.
4516 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4517 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4518 * font.c (Ffont_variation_glyphs):
4519 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4520 * lisp.h: Include <intprops.h>.
4521 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4522 (cons_to_signed, cons_to_unsigned): New decls.
4523 (long_to_cons, cons_to_long): Remove decls.
4524 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4525 (Fprimitive_undo): Use CONS_TO_INTEGER.
4526 * xfns.c (Fx_window_property): Likewise.
4527 * xselect.c: Include <limits.h>.
4528 (x_own_selection, selection_data_to_lisp_data):
4529 Use INTEGER_TO_CONS.
4530 (x_handle_selection_request, x_handle_selection_clear)
4531 (x_get_foreign_selection, Fx_disown_selection_internal)
4532 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4533 (lisp_data_to_selection_data): Use cons_to_unsigned.
4534 (x_fill_property_data): Use cons_to_signed.
4535 Report values out of range.
4536
d1f3d2af
PE
4537 Check for buffer and string overflow more precisely.
4538 * buffer.h (BUF_BYTES_MAX): New macro.
4539 * lisp.h (STRING_BYTES_MAX): New macro.
4540 * alloc.c (Fmake_string):
4541 * character.c (string_escape_byte8):
4542 * coding.c (coding_alloc_by_realloc):
4543 * doprnt.c (doprnt):
4544 * editfns.c (Fformat):
4545 * eval.c (verror):
4546 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4547 since they may not be the same number.
4548 * editfns.c (Finsert_char):
4549 * fileio.c (Finsert_file_contents):
4550 Likewise for BUF_BYTES_MAX.
4551
dd52fcea
PE
4552 * image.c: Use ptrdiff_t, not int, for sizes.
4553 (slurp_file): Switch from int to ptrdiff_t.
4554 All uses changed.
4555 (slurp_file): Check that file size fits in both size_t (for
4556 malloc) and ptrdiff_t (for sanity and safety).
4557
7f9bbdbb
PE
4558 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4559 if b->modtime has its maximal value.
4560
dfe18f82
PE
4561 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4562
84acfcf0
PE
4563 Don't assume time_t can fit into int.
4564 * buffer.h (struct buffer.modtime): Now time_t, not int.
4565 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4566 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4567
ccd9a01a
PE
4568 Minor fixes for signed vs unsigned integers.
4569 * character.h (MAYBE_UNIFY_CHAR):
4570 * charset.c (maybe_unify_char):
4571 * keyboard.c (read_char, reorder_modifiers):
4572 XINT -> XFASTINT, since the integer must be nonnegative.
4573 * ftfont.c (ftfont_spec_pattern):
4574 * keymap.c (access_keymap, silly_event_symbol_error):
4575 XUINT -> XFASTINT, since the integer must be nonnegative.
4576 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4577 since it makes no difference and we prefer signed.
4578 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4579 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4580 nonnegative.
4581
d6d100dd
SM
45822011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4583
4584 * window.h (Fwindow_frame): Declare.
4585
2b6148e4
PE
45862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4587
4588 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4589 (SPARE_MEMORY): Always define.
4590 (LARGE_REQUEST): Remove.
4591 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4592
f230ecc9
MR
45932011-06-06 Martin Rudalics <rudalics@gmx.at>
4594
727e958e
MR
4595 * lisp.h: Move EXFUNS for Fframe_root_window,
4596 Fframe_first_window and Fset_frame_selected_window to window.h.
4597
4598 * window.h: Move EXFUNS for Fframe_root_window,
4599 Fframe_first_window and Fset_frame_selected_window here from
4600 lisp.h.
4601
4602 * frame.c (Fwindow_frame, Fframe_first_window)
4603 (Fframe_root_window, Fframe_selected_window)
4604 (Fset_frame_selected_window): Move to window.c.
4605 (Factive_minibuffer_window): Move to minibuf.c.
4606 (Fother_visible_frames_p): New function.
4607
4608 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4609
f230ecc9
MR
4610 * window.c (decode_window, decode_any_window): Move up in code.
4611 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4612 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4613 (Fwindow_buffer): Move up and rewrite doc-string.
4614 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4615 (Fwindow_prev): New functions.
727e958e
MR
4616 (Fwindow_frame): Move here from frame.c. Accept any window as
4617 argument.
4618 (Fframe_root_window, Fframe_first_window)
4619 (Fframe_selected_window): Move here from frame.c. Accept frame
4620 or arbitrary window as argument. Update doc-strings.
4621 (Fminibuffer_window): Move up in code.
4622 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4623 (Fset_frame_selected_window): Move here from frame.c.
4624 Marginal rewrite.
727e958e
MR
4625 (Fselected_window, select_window, Fselect_window): Move up in
4626 code. Minor doc-string fixes.
f230ecc9 4627
4d09bcf6
PE
46282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4629
4630 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4631 Do not assume that spare memory exists; that assumption is valid
4632 only if SYSTEM_MALLOC.
4633 (LARGE_REQUEST): New macro, so that the issue of large requests
4634 is separated from the issue of spare memory.
4635
810928a2
AS
46362011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4637
172418ad
AS
4638 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4639 format. (Bug#8806)
4640
43f862f7
AS
4641 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4642
810928a2
AS
4643 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4644 before statements.
4645
a059fe24
JD
46462011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4647
4648 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4649
4650 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4651
4652 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4653 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4654
989bf368
JB
46552011-06-05 Juanma Barranquero <lekktu@gmail.com>
4656
4657 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4658
4b80f674
CY
46592011-06-04 Chong Yidong <cyd@stupidchicken.com>
4660
4661 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4662 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4663 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4664 New error handlers.
4b80f674
CY
4665 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4666 Obey Vx_select_enable_clipboard_manager. Catch errors in
4667 x_clipboard_manager_save (Bug#8779).
4668 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4669 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4670
99a33b77 46712011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4672
4673 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4674
99a33b77 46752011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4676
4677 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4678 in the current matrix if keep_current_p is non-zero.
4679
8264569d
EZ
46802011-06-04 Eli Zaretskii <eliz@gnu.org>
4681
4682 * bidi.c (bidi_level_of_next_char): Fix last change.
4683
57f97249
EZ
46842011-06-03 Eli Zaretskii <eliz@gnu.org>
4685
fec2107c 4686 Support bidi reordering of text covered by display properties.
57f97249 4687
fec2107c
EZ
4688 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4689 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4690 (bidi_cache_search, bidi_cache_iterator_state)
4691 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4692 (bidi_level_of_next_char, bidi_move_to_visually_next):
4693 Support character positions inside a run of characters covered by a
fec2107c
EZ
4694 display string.
4695 (bidi_paragraph_init, bidi_resolve_explicit_1)
4696 (bidi_level_of_next_char): Call bidi_fetch_char and
4697 bidi_fetch_char_advance instead of FETCH_CHAR and
4698 FETCH_CHAR_ADVANCE.
4699 (bidi_init_it): Initialize new members.
4700 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4701 definitions.
4702 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4703 instead of using explicit *_CHAR codes.
d6d100dd
SM
4704 (bidi_resolve_explicit, bidi_resolve_weak):
4705 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4706 bidirectional text is supported only in multibyte buffers.
4707 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4708 it to initialize the frame_window_p member of struct bidi_it.
4709 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4710 (bidi_resolve_explicit, bidi_resolve_weak)
4711 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4712 bidi_it->nchars is non-positive.
4713 (bidi_level_of_next_char): Don't try to lookup the cache for the
4714 next/previous character if nothing is cached there yet, or if we
4715 were just reseat()'ed to a new position.
c40e2fb2 4716
0e14fe90
EZ
4717 * xdisp.c (set_cursor_from_row): Set start and stop points
4718 according to the row's direction when priming the loop that looks
4719 for the glyph on which to display cursor.
4720 (single_display_spec_intangible_p): Function deleted.
4721 (display_prop_intangible_p): Reimplement to call
4722 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4723 Accept 3 additional arguments needed by handle_display_spec.
4724 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4725 values: lists, `(when COND...)' forms, etc.
4726 (single_display_spec_string_p): Support property values that are
4727 lists with the argument STRING its top-level element.
4728 (display_prop_string_p): Fix the condition for processing a
4729 property that is a list to be consistent with handle_display_spec.
fec2107c 4730 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4731 last portion of handle_display_prop.
4732 (compute_display_string_pos): Accept additional argument
4733 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4734 value of a `display' property is a "replacing spec".
4735 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4736 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4737 the display property, but just return a value indicating whether
4738 the display property will replace the characters it covers.
4739 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4740 frame_window_p members of struct bidi_it.
d6d100dd
SM
4741 (compute_display_string_pos, compute_display_string_end):
4742 New functions.
fec2107c
EZ
4743 (push_it): Accept second argument POSITION, where pop_it should
4744 jump to continue iteration.
4745 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4746
fec2107c
EZ
4747 * keyboard.c (adjust_point_for_property): Adjust the call to
4748 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4749
4750 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4751 (bidi_init_it): Update prototypes.
4752 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4753 (compute_display_string_pos, compute_display_string_end):
4754 Declare prototypes.
fec2107c
EZ
4755 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4756 EMACS_INT.
fc6f18ce 4757
40087514 47582011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4759
57f53182
PE
4760 Malloc failure behavior now depends on size of allocation.
4761 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4762 * lisp.h: Change signatures accordingly.
4763 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4764 All callers changed. (Bug#8762)
4765
4766 * gnutls.c: Use Emacs's memory allocators.
4767 Without this change, the gnutls library would invoke malloc etc.
4768 directly, which causes problems on non-SYNC_INPUT hosts, and which
4769 runs afoul of improving memory_full behavior. (Bug#8761)
4770 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4771 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4772 xfree instead of the default malloc, realloc, free.
4773 (Fgnutls_boot): No need to check for memory allocation failure,
4774 since xmalloc does that for us.
4775
ac32cd99 4776 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4777 * category.c (hash_get_category_set):
4778 * ccl.c (ccl_driver):
4779 * charset.c (Fdefine_charset_internal):
4780 * charset.h (struct charset.hash_index):
4781 * composite.c (get_composition_id, gstring_lookup_cache)
4782 (composition_gstring_put_cache):
4783 * composite.h (struct composition.hash_index):
4784 * dispextern.h (struct image.hash):
4785 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4786 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4787 (hashfn_equal, hashfn_user_defined, make_hash_table)
4788 (maybe_resize_hash_table, hash_lookup, hash_put)
4789 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4790 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4791 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4792 * image.c (make_image, search_image_cache, lookup_image)
4793 (xpm_put_color_table_h):
4794 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4795 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4796 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4797 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4798 * alloc.c (allocate_vectorlike):
4799 Check for overflow in vector size calculations.
4800 * ccl.c (ccl_driver):
4801 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4802 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4803 need to be updated by these changes.
40087514
PE
4804 * fns.c (make_hash_table, maybe_resize_hash_table):
4805 Check for integer overflow with large hash tables.
0de4bb68
PE
4806 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4807 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4808 (SXHASH_REDUCE): New macro.
4809 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4810 Use it instead of discarding useful hash info with large hash values.
4811 (sxhash_float): New function.
4812 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4813 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4814 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4815 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4816 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4817 Adjust signatures to match updated version of code.
4818 (consing_since_gc): Now EMACS_INT, since a single hash table can
4819 use more than INT_MAX bytes.
4820
698d32e2
DN
48212011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4822
4823 Make it possible to build with GCC-4.6+ -O2 -flto.
4824
4825 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4826
fd6fa53f
SM
48272011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4828
4829 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4830 Call minibuffer-inactive-mode.
4831
864db017
JB
48322011-05-31 Juanma Barranquero <lekktu@gmail.com>
4833
4834 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4835 Update dependencies.
4836
2ad0baf4
DN
48372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4838
4839 * data.c (init_data): Remove code for UTS, this system is not
4840 supported anymore.
4841
4fcc2638
DN
48422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4843
4844 Don't force ./temacs to start in terminal mode.
4845
4846 * frame.c (make_initial_frame): Initialize faces in all cases, not
4847 only when CANNOT_DUMP is defined.
4848 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4849
c56e0fd5
DN
48502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4851
4852 * dispnew.c (add_window_display_history): Use const for the string
4853 pointer. Remove declaration, not needed.
4854
333d54da 48552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4856
55d4c1b2 4857 Use 'inline', not 'INLINE'.
333d54da 4858 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4859 * alloc.c, fontset.c (INLINE): Remove.
4860 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4861 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4862 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4863 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4864 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4865
738db178
DN
48662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4867
4868 Make it possible to run ./temacs.
4869
4870 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4871 syms_of_callproc does the same thing. Remove test for
4872 "initialized", do it in the caller.
4873 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4874
620c53a6
SM
48752011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4876
4877 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4878 (read_minibuf): Use get_minibuffer.
4879 (syms_of_minibuf): Use DEFSYM.
4880 (Qmetadata): New var.
4881 * data.c (Qbuffer): Don't make it static.
4882 (syms_of_data): Use DEFSYM.
4883
e003a292
PE
48842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4885
4886 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4887 (CCL_CODE_MIN): New macro.
4888
ed008a6d
PE
48892011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4890
3687c2ef
PE
4891 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4892
ed008a6d
PE
4893 * eval.c (Qdebug): Now static.
4894 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4895 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4896 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4897
d66c4c7c
CY
48982011-05-29 Chong Yidong <cyd@stupidchicken.com>
4899
4900 * image.c: Various fixes to ImageMagick code comments.
4901 (Fimagemagick_types): Doc fix.
4902
5fbc2025
PE
49032011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4904
0196f88a
PE
4905 Minor fixes prompted by GCC 4.6.0 warnings.
4906
4907 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4908
5fbc2025
PE
4909 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4910 (x_clipboard_manager_save_all): Move extern decl to ...
4911 * xterm.h: ... here, so that it can be checked for consistency.
4912
1dd3c2d9
CY
49132011-05-29 Chong Yidong <cyd@stupidchicken.com>
4914
4915 * xselect.c (x_clipboard_manager_save_frame)
4916 (x_clipboard_manager_save_all): New functions.
4917 (Fx_clipboard_manager_save): Lisp function deleted.
4918
4919 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4920 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4921
4922 * xterm.h: Update prototype.
4923
5ba6571d
WX
49242011-05-28 William Xu <william.xwl@gmail.com>
4925
4926 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4927 exiting (Bug#8239).
4928
3eaff834
JM
49292011-05-28 Jim Meyering <meyering@redhat.com>
4930
e1900994 4931 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4932 * fns.c (to_uchar): Define.
4933 (crypto_hash_function): Use it to convert some newly-signed
4934 variables to unsigned, to avoid sign-extension bugs. For example,
4935 without this change, (md5 "truc") would evaluate to
4936 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4937 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4938 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4939
0f6990a7
PE
49402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4941
4942 Integer overflow fixes.
c8a9ca5a 4943
08686060
PE
4944 * dbusbind.c: Serial number integer overflow fixes.
4945 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4946 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4947 to hold a serial number that is too large for a fixnum.
4948 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4949 Check for serial numbers out of range. Decode any serial number
59568bf0 4950 that was so large that it became a float. (Bug#8722)
08686060 4951
2d1fc3c7
PE
4952 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4953 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4954 Use XFASTINT rather than XUINT when numbers are nonnegative.
4955 (xd_append_arg, Fdbus_method_return_internal):
4956 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4957 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4958 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4959 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4960 (Bug#8722)
2d1fc3c7 4961
c8a9ca5a
PE
4962 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4963
519e1d69
PE
4964 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4965
30569699
PE
4966 ccl: add integer overflow checks
4967 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4968 (IN_INT_RANGE): New macros.
4969 (ccl_driver): Use them to check for integer overflow when
4970 decoding a CCL program. Many of the new checks are whether XINT (x)
4971 fits in int; it doesn't always, on 64-bit hosts. The new version
4972 doesn't catch all possible integer overflows, but it's an
847044ea 4973 improvement. (Bug#8719)
30569699 4974
c11285dc
PE
4975 * alloc.c (make_event_array): Use XINT, not XUINT.
4976 There's no need for unsigned here.
4977
fdccd48e
PE
4978 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4979 This follows up to the 2011-05-06 change that substituted uintptr_t
4980 for EMACS_INT. This case wasn't caught back then.
4981
37910ab2
PE
4982 Rework Fformat to avoid integer overflow issues.
4983 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4984 now (part of C89). Include <verify.h>.
4985 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4986 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4987 (Fformat): Avoid the prepass trying to compute sizes; it was only
4988 approximate and thus did not catch overflow reliably. Instead, walk
4989 through the format just once, formatting and computing sizes as we go,
4990 checking for integer overflow at every step, and allocating a larger
4991 buffer as needed. Keep track separately whether the format is
4992 multibyte. Keep only the most-recently calculated precision, rather
4993 than them all. Record whether each argument has been converted to
4994 string. Use EMACS_INT, not int, for byte and char and arg counts.
4995 Support field widths and precisions larger than INT_MAX. Avoid
4996 sprintf's undefined behavior with conversion specifications such as %#d
4997 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4998 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4999 formatting out-of-range floating point numbers with int
9173deec 5000 formats. (Bug#8668)
37910ab2 5001
2e6578fb
PE
5002 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5003
0ae6bdee
PE
5004 * data.c: Avoid integer truncation in expressions involving floats.
5005 * data.c: Include <intprops.h>.
5006 (arith_driver): When there's an integer overflow in an expression
5007 involving floating point, convert the integers to floating point
5008 so that the resulting value does not suffer from catastrophic
5009 integer truncation. For example, on a 64-bit host (* 4
5010 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5011 Do not rely on undefined behavior after integer overflow.
5012
de883a70
PE
5013 merge count_size_as_multibyte, parse_str_to_multibyte
5014 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5015 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5016 Check for integer overflow.
5017 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5018 since it's now a duplicate of the other. This is more of
5019 a character than a buffer op, so better that it's in character.c.
5020 * fns.c, print.c: Adjust to above changes.
5021
2ff916cb
PE
50222011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5023
5024 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5025
f1b54466
PE
50262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5027
fb1ac845
PE
5028 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5029 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5030 (x_clipboard_manager_save): Now static.
5031 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5032
f1b54466
PE
5033 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5034 (crypto_hash_function): Now static.
5035 Fix pointer signedness problems. Avoid unnecessary initializations.
5036
a9f737ee
CY
50372011-05-27 Chong Yidong <cyd@stupidchicken.com>
5038
5039 * termhooks.h (Vselection_alist): Make it terminal-local.
5040
5041 * terminal.c (create_terminal): Initialize it.
5042
5043 * xselect.c: Support for clipboard managers.
5044 (Vselection_alist): Move to termhooks.h as terminal-local var.
5045 (LOCAL_SELECTION): New macro.
5046 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5047 (symbol_to_x_atom): Remove gratuitous arg.
5048 (x_handle_selection_request, lisp_data_to_selection_data)
5049 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5050 (x_own_selection, x_get_local_selection, x_convert_selection):
5051 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5052 (some_frame_on_display): Delete unused function.
5053 (Fx_own_selection_internal, Fx_get_selection_internal)
5054 (Fx_disown_selection_internal, Fx_selection_owner_p)
5055 (Fx_selection_exists_p): New optional frame arg.
5056 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5057 (x_handle_selection_clear): Don't treat other terminals with the
5058 same keyboard specially. Use the terminal-local Vselection_alist.
5059 (x_clear_frame_selections): Use Frun_hook_with_args.
5060
5061 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5062
5063 * xterm.h: Add support for those atoms.
5064
e067f0c1
CY
50652011-05-26 Chong Yidong <cyd@stupidchicken.com>
5066
5067 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5068 (converted_selections, conversion_fail_tag): New global variables.
5069 (x_selection_request_lisp_error): Free the above.
5070 (x_get_local_selection): Remove unnecessary code.
5071 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5072 of converted selections stored in converted_selections.
5073 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5074 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5075 (x_convert_selection): New function.
5076 (x_handle_selection_event): Simplify.
5077 (x_get_foreign_selection): Don't ignore incoming requests while
5078 waiting for an answer; this will fail when we implement
5079 SAVE_TARGETS, and seems unnecessary anyway.
5080 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5081 (Vx_sent_selection_functions): Doc fix.
5082
0f4aebc0
LL
50832011-05-26 Leo Liu <sdl.web@gmail.com>
5084
5085 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5086
e61124cd
YM
50872011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5088
5089 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5090
5091 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5092 for fringe update if it has periodic bitmap.
ac389d0c 5093 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5094 and fringe_bitmap_periodic_p.
5095
5096 * fringe.c (get_fringe_bitmap_data): New function.
5097 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5098 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5099 row. Mark glyph row for fringe update if periodicity changed.
5100
5101 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5102 for fringe update unless it has periodic bitmap.
5103
f16d9837
KH
51042011-05-25 Kenichi Handa <handa@m17n.org>
5105
5106 * xdisp.c (get_next_display_element): Set correct it->face_id for
5107 a static composition.
5108
e1b90ef6
LL
51092011-05-24 Leo Liu <sdl.web@gmail.com>
5110
5111 * deps.mk (fns.o):
5112 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5113
5114 * fns.c (crypto_hash_function, Fsha1): New function.
5115 (Fmd5): Use crypto_hash_function.
5116 (syms_of_fns): Add Ssha1.
5117
7400048f
PE
51182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5119
5120 * gnutls.c: Remove unused macros.
5121 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5122 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5123 Remove macros that are defined and never used.
5124 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5125
abb71cf4
CY
51262011-05-22 Chong Yidong <cyd@stupidchicken.com>
5127
5128 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5129 (Fx_get_selection_internal): Minor cleanup.
5130 (Fx_own_selection_internal): Rename arguments for consistency with
5131 select.el.
5132
6307db39
PE
51332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5134
5135 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5136
f3d4e0a4
CY
51372011-05-22 Chong Yidong <cyd@stupidchicken.com>
5138
5139 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5140
4d8ade89
YM
51412011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5142
5143 * dispnew.c (scrolling_window): Don't exclude the case that the
5144 last enabled row in the desired matrix touches the bottom boundary.
5145
32078c8d
GM
51462011-05-21 Glenn Morris <rgm@gnu.org>
5147
5148 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5149 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5150 and add some more files.
32078c8d 5151
7285dc67
EZ
51522011-05-20 Eli Zaretskii <eliz@gnu.org>
5153
5154 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5155 report_file_error introduced by the change from 2011-05-07.
5156
89d1bd22
PE
51572011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5158
5159 * systime.h (Time): Define only if emacs is defined.
5160 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5161 where the include path doesn't have X11/X.h by default. See
5162 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5163
e23640bb 51642011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5165
5166 * composite.c (find_automatic_composition): Fix previous change.
5167
b9704ad9
GM
51682011-05-20 Glenn Morris <rgm@gnu.org>
5169
5170 * lisp.mk: New file, split from Makefile.in.
5171 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5172 (shortlisp): Remove.
5173 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5174
4a720484
GM
51752011-05-19 Glenn Morris <rgm@gnu.org>
5176
5177 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5178 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5179 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5180 (lisp): Set the order to that of loadup.el.
5181 (shortlisp): Make it a copy of $lisp.
5182 (SOME_MACHINE_LISP): Remove.
5183 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5184 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5185
a28d4396
KH
51862011-05-18 Kenichi Handa <handa@m17n.org>
5187
5188 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5189 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5190 (find_automatic_composition): Mostly rewrite for efficiency.
5191
a2b1fa8e
JB
51922011-05-18 Juanma Barranquero <lekktu@gmail.com>
5193
5194 * makefile.w32-in: Update dependencies.
5195
8e1f5610
CS
51962011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5197
5198 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5199 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5200
7025ee00 52012011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5202
cdfa6eab
PE
5203 Fix some integer overflow issues, such as string length overflow.
5204
06d6db33
PE
5205 * insdel.c (count_size_as_multibyte): Check for string overflow.
5206
2b4560a8
PE
5207 * character.c (lisp_string_width): Check for string overflow.
5208 Use EMACS_INT, not int, for string indexes and lengths; in
5209 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5210 the resulting string length overflows an EMACS_INT; instead,
5211 report a string overflow if no precision given. When checking for
5212 precision exhaustion, use a check that cannot possibly have
5213 integer overflow. (Bug#8675)
5214 * character.h (lisp_string_width): Adjust to new signature.
5215
cb93f9be
PE
5216 * alloc.c (string_overflow): New function.
5217 (Fmake_string): Use it. This doesn't change behavior, but saves
5218 a few bytes and will simplify future changes.
5219 * character.c (string_escape_byte8): Likewise.
5220 * lisp.h (string_overflow): New decl.
5221
1a1f3366
PE
5222 Fixups, following up to the user-interface timestamp change.
5223 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5224 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5225 * msdos.c (mouse_get_pos): Likewise.
5226 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5227 * w32gui.h (Time): Define by including "systime.h" rather than by
5228 declaring it ourselves. (Bug#8664)
5229
d4e3e4d3
PE
5230 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5231 * image.c (clear_image_cache): Likewise.
5232
f6a24d19
PE
5233 * term.c (term_mouse_position): Don't assume time_t wraparound.
5234
08dc5ae6
PE
5235 Be more systematic about user-interface timestamps.
5236 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5237 and sometimes 'EMACS_UINT', to represent these timestamps.
5238 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5239 This makes the code easier to follow, and makes it easier to catch
5240 integer overflow bugs such as Bug#8664.
5241 * frame.c (Fmouse_position, Fmouse_pixel_position):
5242 Use Time, not unsigned long, for user-interface timestamps.
5243 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5244 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5245 * keyboard.h (last_event_timestamp): Likewise.
5246 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5247 * menu.h (xmenu_show): Likewise.
5248 * term.c (term_mouse_position): Likewise.
5249 * termhooks.h (struct input_event.timestamp): Likewise.
5250 (struct terminal.mouse_position_hook): Likewise.
5251 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5252 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5253 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5254 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5255 what it was before.
5256 * menu.h, termhooks.h: Include "systime.h", for Time.
5257
8e55734a
PE
5258 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5259 Don't assume that the difference between two unsigned long values
5260 can fit into an integer. At this point, we know button_down_time
5261 <= event->timestamp, so the difference must be nonnegative, so
5262 there's no need to cast the result if double-click-time is
5263 nonnegative, as it should be; check that it's nonnegative, just in
5264 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5265 apart (about 25 days). (Bug#8664)
8e55734a 5266
841f1b75 5267 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5268 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5269
3e26f69c
PE
5270 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5271 that always fit in int. Use a sentinel instead of a counter, to
5272 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5273 * frame.h (struct frame): Use int for menu_bar_items_used
5274 instead of EMACS_INT, since it always fits in int.
3e26f69c 5275
5cc152c0
PE
5276 * menu.c (grow_menu_items): Check for int overflow.
5277
d89eb65e
PE
5278 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5279
5235bd3e
PE
5280 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5281 Before, the code was not consistent. These values cannot exceed
5282 2**31 - 1 so there's no need to make them unsigned.
5283 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5284 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5285 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5286 as modifiers.
5287 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5288
bc827e23
PE
5289 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5290 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5291 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5292 presumably because the widths might not match.
5293
78eb494e
PE
5294 * window.c (size_window): Avoid needless test at loop start.
5295
04f2d78b
CB
52962011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5297
5298 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5299
d2fc7e3d 53002011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5301
5302 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5303
d2fc7e3d 53042011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5305
5306 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5307 `width' to `bar_area_x' and `bar_area_width', respectively.
5308 (x_scroll_run): Take account of fringe background extension.
5309
04f2d78b
CB
5310 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5311 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5312 `bar_area_width', respectively.
5313 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5314 background extension.
5315
79b70037
GM
53162011-05-10 Jim Meyering <meyering@redhat.com>
5317
5318 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5319
2f142cc5
JB
53202011-05-10 Juanma Barranquero <lekktu@gmail.com>
5321
5322 * image.c (Finit_image_library): Return t for built-in image types,
5323 like pbm and xbm. (Bug#8640)
5324
57679c86
AS
53252011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5326
5327 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5328
888c9e86
EZ
53292011-05-07 Eli Zaretskii <eliz@gnu.org>
5330
b0512a1d
EZ
5331 * w32console.c (Fset_screen_color): Doc fix.
5332 (Fget_screen_color): New function.
5333 (syms_of_ntterm): Defsubr it.
5334
7285dc67
EZ
5335 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5336 unlink the temporary file if Fcall_process didn't create it in the
5337 first place.
5338 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5339 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5340 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5341 cue to call_process_cleanup not to close that handle.
5342
4d3fcc8e
BK
53432011-05-07 Ben Key <bkey76@gmail.com>
5344
5345 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5346 one of two shell specific rules, either bootstrap-temacs-CMD or
5347 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5348 to the previous implementation of the bootstrap-temacs rule.
5349 The bootstrap-temacs-CMD rule is similar to the previous
5350 implementation of the bootstrap-temacs rule except that it
5351 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5352 variable.
5353
5354 These changes, along with some changes to nt/configure.bat,
5355 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5356 earlier fix to add support for --cflags and --ldflags options
5357 that include quotes so that it works whether make uses cmd or
5358 sh as the shell.
5359
b4289b64
MA
53602011-05-06 Michael Albinus <michael.albinus@gmx.de>
5361
5362 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5363 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5364 is a constant.
5365 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5366 a string. Handle both cases.
5367 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5368 (Fdbus_register_method): Use Qinvalid_function.
5369
af4c0e28
JB
53702011-05-06 Juanma Barranquero <lekktu@gmail.com>
5371
5372 * makefile.w32-in: Update dependencies.
5373 (LISP_H): Add inttypes.h and stdin.h.
5374 (PROCESS_H): Add unistd.h.
5375
c51453d9
EZ
53762011-05-06 Eli Zaretskii <eliz@gnu.org>
5377
5378 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5379 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5380
8ff0ac3c 53812011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5382
4c4b566b
PE
5383 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5384
aab2b9b5
PE
5385 * term.c (vfatal): Remove stray call to va_end.
5386 It's not needed and the C Standard doesn't allow it here anyway.
5387
c378da0b
PE
5388 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5389 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5390
288b08c7
PE
5391 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5392 bytes.
5393
e3601888
PE
5394 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5395
db6c0e74
PE
5396 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5397
dd5963ea
PE
5398 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5399
88c9450f
PE
5400 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5401
2f9442b8
PE
5402 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5403
c032b5f8
PE
5404 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5405 * charset.c (Fdefine_charset_internal): Don't initialize
5406 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5407 32-bit int (Bug#8600).
a108c10b
PE
5408
5409 * lread.c (read_integer): Be more consistent with string-to-number.
5410 Use string_to_number to do the actual conversion; this avoids
5411 rounding errors and fixes some other screwups. Without this fix,
5412 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5413 (digit_to_number): Move earlier, for benefit of read_integer.
5414 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5415 not a digit in any supported base. (Bug#8602)
a108c10b 5416
ad5f9eea
PE
5417 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5418
aec1708a
PE
5419 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5420 to match comment at start of function. This also removes a
5421 GCC warning about overflow in a 32+64-bit port.
5422
47be4ab5
PE
5423 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5424
371cac43
PE
5425 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5426 Reported by Stefan Monnier in
5427 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5428 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5429 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5430
d01a7826
PE
5431 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5432 (EMACS_UINTPTR): Likewise, with uintptr_t.
5433
7fd47d5c
PE
5434 * lisp.h: Prefer 64-bit EMACS_INT if available.
5435 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5436 on 32-bit hosts that have 64-bit int, so that they can access
5437 large files.
122b0c86
PE
5438 However, temporarily disable this change unless the temporary
5439 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5440
8727937b
PE
5441 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5442
8ac068ac
PE
5443 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5444 This removes an assumption that EMACS_INT and long are the same
5445 width as pointers. The assumption is true for Emacs porting targets
5446 now, but we want to make other targets possible.
5447 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5448 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5449 In the rest of the code, change types of integers that hold casted
5450 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5451 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5452 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5453 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5454 No need to cast type when ORing.
5455 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5456 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5457 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5458 assume EMACS_INT is the same width as char *.
5459 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5460 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5461 Remove no-longer-needed casts.
5462 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5463 (xg_tool_bar_help_callback, xg_make_tool_item):
5464 Use EMACS_INTPTR to hold an integer
5465 that will be cast to void *; this can avoid a GCC warning
5466 if EMACS_INT is not the same width as void *.
5467 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5468 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5469 (current_message_1, set_message_1):
5470 Use a local to convert to proper width without a cast.
5471 * xmenu.c (dialog_selection_callback): Likewise.
5472
ede49d71
PE
5473 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5474 Also, don't assume VALBITS / RAND_BITS is less than 5,
5475 and don't rely on undefined behavior when shifting a 1 left into
5476 the sign bit.
5477 * lisp.h (get_random): Change signature to match.
5478
2f30ecd0
PE
5479 * lread.c (hash_string): Use size_t, not int, for hash computation.
5480 Normally we prefer signed values; but hashing is special, because
5481 it's better to use unsigned division on hash table sizes so that
5482 the remainder is nonnegative. Also, size_t is the natural width
5483 for hashing into memory. The previous code used 'int', which doesn't
5484 retain enough info to hash well into very large tables.
5485 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5486
2a866e7b
PE
5487 * dbusbind.c: Don't possibly lose pointer info when converting.
5488 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5489 Use XPNTR rather than XHASH, so that the high-order bits of
5490 the pointer aren't lost when converting through void *.
5491
51639eac
PE
5492 * eval.c (Fautoload): Don't double-shift a pointer.
5493
92394119
PE
5494 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5495
dbdb9a7c
JB
54962011-05-06 Juanma Barranquero <lekktu@gmail.com>
5497
5498 * gnutls.c (DEF_GNUTLS_FN):
5499 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5500
db7a0b4f
AS
55012011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5502
5503 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5504 marker. (Bug#8610)
5505
f7ff1b0f 55062011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5507
5508 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5509 New version that can reserve upto 2GB of heap space.
5510
f7ff1b0f 55112011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5512
5513 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5514
639c109b
TZ
55152011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5516
5517 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5518 `gnutls_certificate_set_x509_key_file'.
5519
d2127135
JB
55202011-05-05 Juanma Barranquero <lekktu@gmail.com>
5521
5522 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5523 Update dependencies.
5524
e968f4f3
JB
55252011-05-04 Juanma Barranquero <lekktu@gmail.com>
5526
5527 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5528 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5529 Remove unused parameter `fildes'.
5530 * process.c (read_process_output, send_process): Don't pass it.
5531
84d358f0
JB
55322011-05-04 Juanma Barranquero <lekktu@gmail.com>
5533
5534 Fix previous change: the library cache is defined in w32.c.
5535 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5536 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5537
0898ca10
JB
55382011-05-04 Juanma Barranquero <lekktu@gmail.com>
5539
5540 Implement dynamic loading of GnuTLS on Windows.
5541
5542 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5543 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5544 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5545 Declare.
5546
5547 * gnutls.c (Qgnutls_dll): Define.
5548 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5549 (gnutls_*): Declare function pointers.
5550 (init_gnutls_functions): New function to initialize function pointers.
5551 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5552 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5553 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5554 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5555 (emacs_gnutls_write, emacs_gnutls_read)
5556 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5557 (Fgnutls_available_p): New function.
5558 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5559 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5560 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5561
5562 * image.c: Include w32.h.
5563 (Vimage_type_cache): Delete.
5564 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5565 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5566 (w32_delayed_load): Move to w32.c.
5567
5568 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5569
5570 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5571 (w32_delayed_load): Move from image.c. When loading a library, record
5572 its filename in the :loaded-from property of the library id.
5573 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5574 Initialize and staticpro them.
5575 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5576
5577 * process.c: Include lisp.h before w32.h, not after.
5578 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5579 instead of gnutls_record_check_pending.
5580
5581 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5582
ff4de4aa
TZ
55832011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5584
5585 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5586 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5587 as passed in.
5588
abe95abb
JD
55892011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5590
5591 * xterm.c (x_set_frame_alpha): Do not set property on anything
5592 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5593
e16e55d4
JB
55942011-05-02 Juanma Barranquero <lekktu@gmail.com>
5595
5596 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5597
bafcf6a5
JB
55982011-05-02 Juanma Barranquero <lekktu@gmail.com>
5599
5600 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5601 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5602 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5603 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5604 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5605 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5606 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5607 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5608 (Qgnutls_bootprop_callbacks_verify): Make static.
5609
e7a6747f
AS
56102011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5611
19ed11ba
AS
5612 * callproc.c: Indentation fixup.
5613
e7a6747f 5614 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5615 (wait_for_termination, interruptible_wait_for_termination):
5616 Move after wait_for_termination_1.
e7a6747f 5617
1ef14cb4
LMI
56182011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5619
5620 * sysdep.c (interruptible_wait_for_termination): New function
5621 which is like wait_for_termination, but allows keyboard
5622 interruptions.
5623
5624 * callproc.c (Fcall_process): Add (:file "file") as an option for
5625 the STDOUT buffer.
5626 (Fcall_process_region): Ditto.
5627
330d880c
EZ
56282011-04-30 Eli Zaretskii <eliz@gnu.org>
5629
8db90b73
EZ
5630 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5631 rather than `XVECTOR (FOO)->size'.
5632
330d880c
EZ
5633 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5634 inttypes.h, as a gnulib replacement is used if it not available in
5635 system headers.
5636
15cbd324
EZ
56372011-04-21 Eli Zaretskii <eliz@gnu.org>
5638
5639 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5640 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5641 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5642
5643 * coding.c (coding_alloc_by_realloc): Error out if destination
5644 will grow beyond MOST_POSITIVE_FIXNUM.
5645 (decode_coding_emacs_mule): Abort if there isn't enough place in
5646 charbuf for the composition carryover bytes. Reserve an extra
5647 space for up to 2 characters produced in a loop.
5648 (decode_coding_iso_2022): Abort if there isn't enough place in
5649 charbuf for the composition carryover bytes.
5650
56512011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5652
ae940cca
EZ
5653 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5654 aborting when %lld or %lll format is passed.
5655 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5656 %llo or %llx format is passed. (Bug#8545)
5657
03ab8921
EZ
5658 * window.c (window_scroll_line_based): Use a marker instead of
5659 simple variables to record original value of point. (Bug#7952)
5660
afda1437
EZ
5661 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5662 produced by %s or %c overflows available buffer space. (Bug#8545)
5663
f76dee0c
PE
56642011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5665
5666 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5667 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5668
fdc5744d
JB
56692011-04-28 Juanma Barranquero <lekktu@gmail.com>
5670
5671 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5672
638f053a
JB
56732011-04-28 Juanma Barranquero <lekktu@gmail.com>
5674
5675 * keyboard.c (Qdelayed_warnings_hook): Define.
5676 (command_loop_1): Run `delayed-warnings-hook'
5677 if Vdelayed_warnings_list is non-nil.
5678 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5679 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5680
d178f871
EZ
56812011-04-28 Eli Zaretskii <eliz@gnu.org>
5682
5683 * doprnt.c (doprnt): Don't return value smaller than the buffer
5684 size if the message was truncated. (Bug#8545).
5685
b124fd93
JB
56862011-04-28 Juanma Barranquero <lekktu@gmail.com>
5687
5688 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5689 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5690
e810457d
PE
56912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5692
5693 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5694
ea51cceb
JB
56952011-04-27 Juanma Barranquero <lekktu@gmail.com>
5696
5697 * makefile.w32-in: Update dependencies.
5698
94dcfacf
EZ
56992011-04-27 Eli Zaretskii <eliz@gnu.org>
5700
5701 Improve `doprnt' and its usage. (Bug#8545)
5702 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5703 `format_end'. Remove support for %l as a conversion specifier.
5704 Don't use xrealloc. Improve diagnostics when the %l size modifier
5705 is used. Update the commentary.
5706
5707 * eval.c (verror): Simplify calculation of size_t.
5708
5709 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5710 messages.
5711
f61f41d7
PE
57122011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5713
5714 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5715 change.
5716
96fb4434
PE
57172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5718
5719 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5720 This makes this file independent of the recent pseudovector change.
5721
671875da 57222011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5723
69e9b5a3
PE
5724 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5725
b5f869a7 5726 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5727 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5728 Remove unused local.
c8926152 5729 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5730
841a1577 5731 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5732 GCC 4.6.0 optimizes based on type-based alias analysis.
5733 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5734 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5735 != &v->size, and therefore "v->size = 1; b->size = 2; return
5736 v->size;" must therefore return 1. This assumption is incorrect
5737 for Emacs, since it type-puns struct Lisp_Vector * with many other
5738 types. To fix this problem, this patch adds a new type struct
f904488f 5739 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5740 and pseudovectors, and helps optimizing compilers not get fooled
5741 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5742 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5743 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5744 the size member.
eab3844f
PE
5745 (XSETPVECTYPE): Rewrite in terms of new macro.
5746 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5747 This is a bit clearer, and further avoids the possibility of
5748 undesirable aliasing.
5749 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5750 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5751 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5752 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5753 (ASIZE): Now uses header.size rather than size.
5754 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5755 to avoid the hassle of writing XVECTOR (foo)->header.size.
5756 (struct vectorlike_header): New type.
eab3844f
PE
5757 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5758 object, to help avoid aliasing.
5759 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5760 (SUBRP): Likewise, since Lisp_Subr is a special case.
5761 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5762 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5763 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5764 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5765 changed to be "header.size" and "header.next".
5766 * buffer.h (struct buffer): Likewise.
5767 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5768 * frame.h (struct frame): Likewise.
5769 * process.h (struct Lisp_Process): Likewise.
5770 * termhooks.h (struct terminal): Likewise.
5771 * window.c (struct save_window_data, struct saved_window): Likewise.
5772 * window.h (struct window): Likewise.
5773 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5774 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5775 * buffer.c (init_buffer_once): Likewise.
5776 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5777 special case.
5778 * process.c (Fformat_network_address): Use local var for size,
5779 for brevity.
5780
0df1eac5
PE
5781 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5782
847ab9d1 5783 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5784 * data.c (atof): Remove decl; no longer used or needed.
5785 (digit_to_number): Move to lread.c.
5786 (Fstring_to_number): Use new string_to_number function, to be
5787 consistent with how the Lisp reader treats infinities and NaNs.
5788 Do not assume that floating-point numbers represent EMACS_INT
5789 without losing information; this is not true on most 64-bit hosts.
5790 Avoid double-rounding errors, by insisting on integers when
5791 parsing non-base-10 numbers, as the documentation specifies.
5792 * lisp.h (string_to_number): New decl, replacing ...
5793 (isfloat_string): Remove.
bc0a5c13 5794 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5795 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5796 appears to have been a coding error. Similarly, do not accept
5797 strings like +-1e0 as floating point numbers. Do not report
5798 overflow for integer overflows unless the base is not 10 which
5799 means we have no simple and reliable way to continue.
5800 Break out the floating-point parsing into a new
5801 function string_to_number, so that Fstring_to_number parses
5802 floating point numbers consistently with the Lisp reader.
04f2d78b 5803 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5804 (E_CHAR, EXP_INT): Remove, replacing with ...
5805 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5806 (string_to_number): New function, replacing isfloat_string.
5807 This function checks for valid syntax and produces the resulting
5808 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5809 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5810 so that overflow for non-base-10 numbers is reported only when
5811 there's no portable and simple way to convert to floating point.
452f4150 5812
67769ffc
PE
5813 * textprop.c (set_text_properties_1): Rewrite for clarity,
5814 and to avoid GCC warning about integer overflow.
5815
c20db43f
PE
5816 * intervals.h (struct interval): Use EMACS_INT for members
5817 where EMACS_UINT might cause problems. See
5818 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5819 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5820 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5821 All uses changed.
37aa2f85
PE
5822 (offset_intervals): Tell GCC not to worry about length overflow
5823 when negating a negative length.
c20db43f 5824
2538aa2f
PE
5825 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5826 (overrun_check_free): Likewise.
5827
f2d3008d
PE
5828 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5829 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5830 word size.
5831
ec8df744
PE
5832 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5833 (gnutls_make_error): Rename local to avoid shadowing.
5834 (gnutls_emacs_global_deinit): ifdef out; not used.
5835 (Fgnutls_boot): Use const for pointer to readonly storage.
5836 Comment out unused local. Fix pointer signedness problems.
5837
640ee02d
PE
5838 * lread.c (openp): Don't stuff size_t into an 'int'.
5839 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5840 about possible signed overflow.
5841
6048fb2a
PE
5842 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5843 (GDK_KEY_g): Don't define if already defined.
5844 (xg_prepare_tooltip): Avoid pointer signedness problem.
5845 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5846
fa3c87e1
PE
5847 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5848 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5849
2172544b
PE
5850 * xfns.c (Fx_window_property): Simplify a bit,
5851 to make a bit faster and to avoid GCC 4.6.0 warning.
5852 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5853
9b821a21
PE
5854 * fns.c (internal_equal): Don't assume size_t fits in int.
5855
3c616cfa
PE
5856 * alloc.c (compact_small_strings): Tighten assertion a little.
5857
c2982e87
PE
5858 Replace pEd with more-general pI, and fix some printf arg casts.
5859 * lisp.h (pI): New macro, generalizing old pEd macro to other
5860 conversion specifiers. For example, use "...%"pI"d..." rather
5861 than "...%"pEd"...".
5862 (pEd): Remove. All uses replaced with similar uses of pI.
5863 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5864 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5865 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5866 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5867 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5868 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5869 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5870 64-bit hosts.
5871 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5872 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5873 * print.c (safe_debug_print, print_object): Likewise.
5874 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5875 to int.
6f04d126
PE
5876 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5877 avoiding the 0 flag, which is not portable.
c2982e87
PE
5878 * process.c (Fmake_network_process): Use pI to avoid cast.
5879 * region-cache.c (pp_cache): Likewise.
5880 * xdisp.c (decode_mode_spec): Likewise.
5881 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5882 behavior on 64-bit hosts with printf arg.
6f04d126 5883 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5884 (x_stop_queuing_selection_requests): Likewise.
5885 (x_get_window_property): Don't truncate byte count to an 'int'
5886 when tracing.
0b432f21 5887
5e073ec7
PE
5888 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5889 here, since it parses constructs like leading '-' and spaces,
5890 which are not wanted; and it overflows with large numbers.
5891 Instead, simply match F[0-9]+, which is what is wanted anyway.
5892
36372bf9
PE
5893 * alloc.c: Remove unportable assumptions about struct layout.
5894 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5895 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5896 (allocate_vectorlike, make_pure_vector): Use the new macros,
5897 plus offsetof, to remove unportable assumptions about struct layout.
5898 These assumptions hold on all porting targets that I know of, but
5899 they are not guaranteed, they're easy to remove, and removing them
5900 makes further changes easier.
5901
0b432f21
PE
5902 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5903 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5904 (string_overrun_cookie): Now const. Use initializers that
5905 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5906 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5907 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5908 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5909 multiple of sizeof (EMACS_INT); it need not be, if
5910 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5911 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5912
895009e1
JB
59132011-04-26 Juanma Barranquero <lekktu@gmail.com>
5914
5915 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5916
6a7a1b0b
TZ
59172011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5918
5919 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5920 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5921 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5922
841a1577 59232011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5924
5925 * lisp.h (Qdebug): List symbol.
895009e1 5926 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5927 * keyboard.c (debug-on-event): New variable.
5928 (handle_user_signal): Break into debugger when debug-on-event
5929 matches the current signal symbol.
5930
f2d3ba6f
DN
59312011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5932
5933 * alloc.c (check_sblock, check_string_bytes)
5934 (check_string_free_list): Convert to standard C.
5935
42ce4c63
TZ
59362011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5937
5938 * w32.c (emacs_gnutls_push): Fix typo.
5939
825cd63c
EZ
59402011-04-25 Eli Zaretskii <eliz@gnu.org>
5941
fb11d64d
EZ
5942 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5943 "cast to pointer from integer of different size".
5944
825cd63c
EZ
5945 Improve doprnt and its use in verror. (Bug#8545)
5946 * doprnt.c (doprnt): Document the set of format control sequences
5947 supported by the function. Use SAFE_ALLOCA instead of always
5948 using `alloca'.
5949
5950 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5951 is one byte too soon. Don't use xrealloc; instead xfree and
5952 xmalloc anew.
5953
e061a11b
TZ
59542011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5955
5956 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5957 callbacks stage.
5958
5959 * gnutls.c: Renamed global_initialized to
5960 gnutls_global_initialized. Added internals for the
5961 :verify-hostname-error, :verify-error, and :verify-flags
5962 parameters of `gnutls-boot' and documented those parameters in the
5963 docstring. Start callback support.
9173deec
JB
5964 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5965 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5966 on error. Return error code.
e061a11b
TZ
5967 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5968 (emacs_gnutls_read): Likewise.
5969 (Fgnutls_boot): Return handshake error code.
5970 (emacs_gnutls_handle_error): New function.
5971 (wsaerror_to_errno): Likewise.
5972
5973 * w32.h (emacs_gnutls_pull): Add prototype.
5974 (emacs_gnutls_push): Likewise.
5975
5976 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5977 (emacs_gnutls_push): Likewise.
5978
59792011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5980
5981 * process.c (wait_reading_process_output): Check if GnuTLS
5982 buffered some data internally if no FDs are set for TLS
5983 connections.
5984
5985 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5986 (LIBS): Link to USER_LIBS.
5987 ($(BLD)/gnutls.$(0)): New target.
5988
fa6996bc
EZ
59892011-04-24 Eli Zaretskii <eliz@gnu.org>
5990
eb35682e
EZ
5991 * xdisp.c (handle_single_display_spec): Rename the
5992 display_replaced_before_p argument into display_replaced_p, to
5993 make it consistent with the commentary. Fix typos in the
5994 commentary.
5995
e2ad650c
EZ
5996 * textprop.c (syms_of_textprop): Remove dead code.
5997 (copy_text_properties): Delete obsolete commentary about an
5998 interface that was deleted long ago. Fix typos in the description
5999 of arguments.
6000
1b2de274
EZ
6001 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6002 to changes in oldXMenu/XMenu.h from 2011-04-16.
6003 <menu_help_message, prev_menu_help_message>: Constify.
6004 (IT_menu_make_room): menu->help_text is now `const char **';
6005 adjust.
6006
6007 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6008 to changes in oldXMenu/XMenu.h from 2011-04-16.
6009 (struct XMenu): Declare `help_text' `const char **'.
6010
6011 * xfaces.c <Qunspecified>: Make extern again.
6012
6013 * syntax.c: Include sys/types.h before including regex.h, as
6014 required by Posix.
6015
762b15be
EZ
6016 * doc.c (get_doc_string): Improve the format passed to `error'.
6017
6018 * doprnt.c (doprnt): Improve commentary.
6019
6020 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6021
6022 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6023 them with etags.
6024
f1052e5d
EZ
6025 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6026 changes in globals.h immediately force recompilation.
762b15be
EZ
6027 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6028 $(CURDIR)/s/ms-w32.h.
6029 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6030
fa6996bc
EZ
6031 * character.c (Fchar_direction): Function deleted.
6032 (syms_of_character): Don't defsubr it.
6033 <char-direction-table>: Deleted.
6034
e6c3da20
EZ
60352011-04-23 Eli Zaretskii <eliz@gnu.org>
6036
6037 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6038 * doprnt.c: Include limits.h.
6039 (SIZE_MAX): New macro.
04f2d78b
CB
6040 (doprnt): Return a size_t value. 2nd arg is now size_t.
6041 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6042 Improve overflow protection. Support `l' modifier for integer
6043 conversions. Support %l conversion. Don't assume an EMACS_INT
6044 argument for integer conversions and for %c.
6045
6046 * lisp.h (doprnt): Restore prototype.
6047
6048 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6049 $(SRC)/character.h.
6050
6051 * Makefile.in (base_obj): Add back doprnt.o.
6052
6053 * deps.mk (doprnt.o): Add back prerequisites.
6054 (callint.o): Depend on character.h.
6055
6056 * eval.c (internal_lisp_condition_case): Include the handler
6057 representation in the error message.
6058 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6059 when breaking from the loop.
6060
6061 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6062
6063 * callint.c (Fcall_interactively): When displaying error message
6064 about invalid control letter, pass the character's codepoint, not
6065 a pointer to its multibyte form. Improve display of the character
6066 in octal and display also its hex code.
6067
6068 * character.c (char_string): Use %x to display the (unsigned)
6069 codepoint of an invalid character, to avoid displaying a bogus
6070 negative value.
6071
6072 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6073 `error', not SYMBOL_NAME itself.
6074
6075 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6076 character arguments to `error'.
6077
6078 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6079 to `error' in error message about FINAL_CHAR argument. Make sure
6080 FINAL_CHAR is a character, and use %c when it is passed as
6081 argument to `error'.
6082
4ffd0d6b 60832011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6084
6085 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6086
6087 * w32.c: Include <time.h>.
6088 (sys_localtime): New function.
6089
4ffd0d6b 60902011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6091
6092 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6093
4ffd0d6b 6094 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6095
4ffd0d6b 60962011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6097
4ffd0d6b
GM
6098 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6099 zombies (Bug#8467).
aac0c6e3 6100
04c56954
EZ
61012011-04-19 Eli Zaretskii <eliz@gnu.org>
6102
6103 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6104 gl_state.e_property when gl_state.object is Qt.
6105
6106 * insdel.c (make_gap_larger): Remove limitation of buffer size
6107 to <= INT_MAX.
6108
16a43933
CY
61092011-04-18 Chong Yidong <cyd@stupidchicken.com>
6110
6111 * xdisp.c (lookup_glyphless_char_display)
6112 (produce_glyphless_glyph): Handle cons cell entry in
6113 glyphless-char-display.
6114 (Vglyphless_char_display): Document it.
6115
6116 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6117 glyphless-char-display.
6118
4581706e
CY
61192011-04-17 Chong Yidong <cyd@stupidchicken.com>
6120
6121 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6122
6123 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6124
6125 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6126 definition for no-X builds.
6127
4887c6e2 61282011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6129
fd35b6f9
PE
6130 Static checks with GCC 4.6.0 and non-default toolkits.
6131
5c1ccb01
PE
6132 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6133
006c5daa
PE
6134 * process.c (keyboard_bit_set): Define only if SIGIO.
6135 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6136 (send_process): Repair possible setjmp clobbering.
6137
efc736d3
PE
6138 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6139
4e2fe2e6
PE
6140 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6141
f97334a2
PE
6142 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6143
4e75f29d
PE
6144 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6145 Define only if needed.
6146
90efadd1
PE
6147 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6148 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6149 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6150
3c647824
PE
6151 * dispextern.h (struct redisplay_interface): Rename param
6152 to avoid shadowing.
e264f262 6153 * termhooks.h (struct terminal): Likewise.
761383f4 6154 * xterm.c (xembed_send_message): Likewise.
3c647824 6155
b58c5c4a
PE
6156 * insdel.c (make_gap_smaller): Define only if
6157 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6158
cad59032
PE
6159 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6160 it.
6161
c339dc2e
PE
6162 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6163 so that we aren't warned about unused symbols.
6164
91a3e27b
PE
6165 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6166
399c71d3 6167 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6168
8ffc96f5
PE
6169 * xfns.c (x_real_positions): Mark locals as initialized.
6170
eef9bc79
PE
6171 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6172
098db9dd
PE
6173 * xterm.c: Fix problems found by static analysis with other toolkits.
6174 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6175 (x_dispatch_event): Declare static if USE_GTK, and
6176 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6177 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6178 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6179 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6180 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6181
eb18f6cc
PE
6182 * xmenu.c (menu_help_callback): Pointer type fixes.
6183 Use const pointers when pointing at readonly data. Avoid pointer
6184 signedness clashes.
6185 (FALSE): Remove unused macro.
6186 (update_frame_menubar): Remove unused decl.
6187
1fe72bf8
PE
6188 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6189
60d9e1db
PE
6190 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6191 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6192 (single_menu_item): Rename local to avoid shadowing.
6193
39261c26
PE
6194 * keyboard.c (make_lispy_event): Remove unused local var.
6195
018c5e19
PE
6196 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6197 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6198
63d2b86e
PE
6199 * bitmaps: Change bitmaps from unsigned char back to the X11
6200 compatible char. Avoid the old compiler warnings about
6201 out-of-range initializers by using, for example, '\xab' rather
6202 than 0xab.
6203
aefd87e1
PE
6204 * xgselect.c (xgselect_initialize): Check vs interface
6205 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6206
bf501fb9
PE
6207 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6208
e9829fdf
PE
6209 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6210 to read-only memory.
6211
1086c095
PE
6212 * fns.c (vector): Remove; this old hack is no longer needed.
6213
2baccd04 6214 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6215 Remove unused var.
dde42981 6216 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6217
72391843 6218 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6219
436c16df 6220 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6221 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6222 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6223
92bb796d 6224 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6225 (x_term_init): Remove local to avoid shadowing.
92bb796d 6226
764430a3 6227 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6228
6229 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6230 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6231
d1dfb56c
EZ
62322011-04-16 Eli Zaretskii <eliz@gnu.org>
6233
c4354cb4
EZ
6234 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6235
d1dfb56c
EZ
6236 Fix regex.c, syntax.c and friends for buffers > 2GB.
6237 * syntax.h (struct gl_state_s): Declare character position members
6238 EMACS_INT.
6239
6240 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6241
04f2d78b
CB
6242 * textprop.c (verify_interval_modification, interval_of):
6243 Declare arguments EMACS_INT.
d1dfb56c
EZ
6244
6245 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6246 EMACS_INT.
6247
6248 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6249
6250 * indent.c (Fvertical_motion): Local variable it_start is now
6251 EMACS_INT.
6252
6253 * regex.c (re_match, re_match_2, re_match_2_internal)
6254 (bcmp_translate, regcomp, regexec, print_double_string)
6255 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6256 (re_compile_pattern, re_exec): Declare arguments and local
6257 variables `size_t' and `ssize_t' and return values `regoff_t', as
6258 appropriate.
6259 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6260 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6261 <compile_stack_type>: `size' and `avail' are now `size_t'.
6262
6263 * regex.h <regoff_t>: Use ssize_t, not int.
6264 (re_search, re_search_2, re_match, re_match_2): Arguments that
6265 specify buffer/string position and length are now ssize_t and
6266 size_t. Return type is regoff_t.
6267
613052cd
BK
62682011-04-16 Ben Key <bkey76@gmail.com>
6269
6270 * nsfont.m: Fixed bugs in ns_get_family and
6271 ns_descriptor_to_entity that were caused by using free to
6272 deallocate memory blocks that were allocated by xmalloc (via
6273 xstrdup). This caused Emacs to crash when compiled with
6274 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6275 --enable-checking=xmallocoverrun). xfree is now used to
6276 deallocate these memory blocks.
6277
4170f62f 62782011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6279
71b41406
PE
6280 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6281
9587a89d
PE
6282 emacs_write: Accept and return EMACS_INT for sizes.
6283 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6284 et seq.
6285 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6286 Accept and return EMACS_INT.
6287 (emacs_gnutls_write): Return the number of bytes written on
6288 partial writes.
6289 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6290 (emacs_read, emacs_write): Remove check for negative size, as the
6291 Emacs source code has been audited now.
9587a89d
PE
6292 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6293 (emacs_read, emacs_write): Use it.
273a5f82
PE
6294 * process.c (send_process): Adjust to the new signatures of
6295 emacs_write and emacs_gnutls_write. Do not attempt to store
6296 a byte offset into an 'int'; it might overflow.
9587a89d 6297 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6298
3e047f51
PE
6299 * sound.c: Don't assume sizes fit in 'int'.
6300 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6301 Return EMACS_INT, not int.
3e047f51 6302 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6303 Accept EMACS_INT, not int.
6304 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6305 record read return values.
6306
cc39a9db
BK
63072011-04-15 Ben Key <bkey76@gmail.com>
6308
c9d0ec6d
JB
6309 * keyboard.c (Qundefined): Don't declare static since it is used
6310 in nsfns.m.
6311 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6312 static since they are used in nsfont.m.
cc39a9db 6313
6c60eb9f
SM
63142011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6315
6316 * process.c (Qprocessp): Don't declare static.
6317 * lisp.h (Qprocessp): Declare again.
6318
7990b61a
JB
63192011-04-15 Juanma Barranquero <lekktu@gmail.com>
6320
6321 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6322
5d4cb038
PE
63232011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6324
8bd7b830 6325 Improve C-level modularity by making more things 'static'.
cd64ea1d 6326
e3b27b31
PE
6327 Don't publish debugger-only interfaces to other modules.
6328 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6329 (verify_bytepos, count_markers): Move decls to the only modules
6330 that need them.
6331 * region-cache.h (pp_cache): Likewise.
6332 * window.h (check_all_windows): Likewise.
6333 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6334
5d4cb038
PE
6335 * sysdep.c (croak): Now static, if
6336 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6337 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6338
6339 * alloc.c (refill_memory_reserve): Now static if
6340 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6341 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6342
e87b6180
PE
6343 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6344 Define only if USE_LUCID.
6345
ac64929e
PE
6346 * xrdb.c (x_customization_string, x_rm_string): Now static.
6347
6f37259d
PE
6348 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6349 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6350
1683e3ab
PE
6351 * xdisp.c (draw_row_with_mouse_face): Now static.
6352 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6353
de9c2632
PE
6354 * window.h (check_all_windows): Mark externally visible.
6355
2b96acb7
PE
6356 * window.c (window_deletion_count): Now static.
6357
6358 * undo.c: Make symbols static if they're not exported.
6359 (last_undo_buffer, last_boundary_position, pending_boundary):
6360 Now static.
6361
50436f33
PE
6362 * textprop.c (interval_insert_behind_hooks): Now static.
6363 (interval_insert_in_front_hooks): Likewise.
6364
64520e5c
PE
6365 * term.c: Make symbols static if they're not exported.
6366 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6367 (max_frame_lines, tty_set_terminal_modes):
6368 (tty_reset_terminal_modes, tty_turn_off_highlight):
6369 (get_tty_terminal): Now static.
6370 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6371 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6372 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6373 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6374 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6375
1fa53021
PE
6376 * sysdep.c: Make symbols static if they're not exported.
6377 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6378 Now static.
6379 (sigprocmask_set, full_mask): Remove; unused.
6380 (wait_debugging): Mark as visible.
6381 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6382 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6383
d4b43b22
PE
6384 * syntax.c (syntax_temp): Define only if !__GNUC__.
6385
b7c513d0
PE
6386 * sound.c (current_sound_device, current_sound): Now static.
6387
989b29ad
PE
6388 * search.c (searchbufs, searchbuf_head): Now static.
6389
13a55a78
PE
6390 * scroll.c (scroll_cost): Remove; unused.
6391 * dispextern.h (scroll_cost): Remove decl.
6392
de68a1fc
PE
6393 * region-cache.h (pp_cache): Mark as externally visible.
6394
40ccffa6
PE
6395 * process.c: Make symbols static if they're not exported.
6396 (process_tick, update_tick, create_process, chan_process):
6397 (Vprocess_alist, proc_buffered_char, datagram_access):
6398 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6399 (deactivate_process): Mark defn as static, as well as decl.
6400 * lisp.h (create_process): Remove decl.
6401 * process.h (chan_process, Vprocess_alist): Remove decls.
6402
ad64fc97
PE
6403 * print.c: Make symbols static if they're not exported.
6404 (print_depth, new_backquote_output, being_printed, print_buffer):
6405 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6406 (print_interval, print_number_index, initial_stderr_stream):
6407 Now static.
6408 * lisp.h (Fprinc): Remove decl.
6409 (debug_output_compilation_hack): Mark as externally visible.
6410
adddb265
PE
6411 * sysdep.c (croak): Move decl from here to syssignal.h.
6412 * syssignal.h (croak): Put it here, so the API can be checked when
6413 'croak' is called from dissociate_if_controlling_tty.
6414
1717ede2
PE
6415 * minibuf.c: Make symbols static if they're not exported.
6416 (minibuf_save_list, choose_minibuf_frame): Now static.
6417 * lisp.h (choose_minibuf_frame): Remove decl.
6418
fa5fb2bc
PE
6419 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6420
1e3890d1
PE
6421 * lread.c: Make symbols static if they're not exported.
6422 (read_objects, initial_obarray, oblookup_last_bucket_number):
6423 Now static.
6424 (make_symbol): Remove; unused.
6425 * lisp.h (initial_obarray, make_symbol): Remove decls.
6426
8a1414fa
PE
6427 * keyboard.c: Make symbols static if they're not exported.
6428 (single_kboard, recent_keys_index, total_keys, recent_keys):
6429 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6430 (this_single_command_key_start, echoing, last_auto_save):
6431 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6432 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6433 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6434 (Vlispy_mouse_stem, double_click_count):
6435 Now static.
6436 (force_auto_save_soon): Define only if SIGDANGER.
6437 (ignore_mouse_drag_p): Now static if
6438 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6439 (print_help): Remove; unused.
6440 (stop_character, last_timer_event): Mark as externally visible.
6441 * keyboard.h (ignore_mouse_drag_p): Declare only if
6442 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6443 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6444 * lisp.h (echoing): Remove decl.
6445 (force_auto_save_soon): Declare only if SIGDANGER.
6446 * xdisp.c (redisplay_window): Simplify code, to make it more
6447 obvious that ignore_mouse_drag_p is not accessed if !defined
6448 USE_GTK && !defined HAVE_NS.
6449
93ea6e8f
PE
6450 * intervals.c: Make symbols static if they're not exported.
6451 (merge_properties_sticky, merge_interval_right, delete_interval):
6452 Now static.
6453 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6454
77382fcc
PE
6455 * insdel.c: Make symbols static if they're not exported.
6456 However, leave prepare_to_modify_buffer alone. It's never
6457 called from outside this function, but that appears to be a bug.
6458 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6459 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6460 (adjust_after_replace_noundo): Remove; unused.
6461 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6462 (signal_before_change): Remove decls.
77382fcc 6463
9306c32e
PE
6464 * indent.c (val_compute_motion, val_vmotion): Now static.
6465
cd44d2eb
PE
6466 * image.c: Make symbols static if they're not exported.
6467 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6468 if USE_GTK.
6469 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6470 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6471
ad9a7a06
PE
6472 * fringe.c (standard_bitmaps): Now static.
6473 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6474
81626931
PE
6475 * frame.c: Make symbols static if they're not exported.
6476 (x_report_frame_params, make_terminal_frame): Now static.
6477 (get_frame_param): Now static, unless HAVE_NS.
6478 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6479 (x_get_resource_string): Remove; not used.
6480 * frame.h (make_terminal_frame, x_report_frame_params):
6481 (x_get_resource_string); Remove decls.
6482 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6483 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6484
239f9db9
PE
6485 * font.c, fontset.c: Make symbols static if they're not exported.
6486 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6487 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6488 * font.c (font_close_object): Now static.
6489 * font.h (font_close_object): Remove.
6490 * fontset.c (FONTSET_OBJLIST): Remove.
6491 (free_realized_fontset) #if-0 the body, which does nothing.
6492 (face_suitable_for_char_p): #if-0, as it's never called.
6493 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6494 * xfaces.c (face_at_string_position):
6495 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6496 since 0 is always ASCII.
6497
dfcf3579
PE
6498 * fns.c (weak_hash_tables): Now static.
6499
5045092b
PE
6500 * fileio.c: Make symbols static if they're not exported.
6501 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6502 (Vwrite_region_annotation_buffers): Now static.
6503
57a96f5c
PE
6504 * eval.c: Make symbols static if they're not exported.
6505 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6506 * lisp.h (backtrace_list): Remove decl.
6507
35f08c38
PE
6508 * emacs.c: Make symbols static if they're not exported.
6509 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6510 (fatal_error_code, fatal_error_signal_hook, standard_args):
6511 Now static.
6512 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6513 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6514 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6515 * lisp.h (fatal_error_signal_hook): Remove decl.
6516 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6517
f44bd759
PE
6518 * editfns.c: Move a (normally-unused) function to its only use.
6519 * editfns.c, lisp.h (get_operating_system_release): Remove.
6520 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6521 worth the hassle of breaking this out.
6522
b532497d
PE
6523 * xterm.c: Make symbols static if they're not exported.
6524 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6525 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6526 (x_destroy_window, x_delete_display):
6527 Now static.
6528 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6529 (x_mouse_leave): Remove; unused.
6530 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6531 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6532 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6533 Remove decls.
6534 (x_mouse_leave): Declare only if WINDOWSNT.
6535 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6536 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6537 USE_X_TOOLKIT.
6538
1675728f
PE
6539 * ftxfont.c: Make symbols static if they're not exported.
6540 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6541 HAVE_FREETYPE.
6542 * font.h (ftxfont_driver): Likewise.
6543
e4cebfca
PE
6544 * xfns.c: Make symbols static if they're not exported.
6545 (x_last_font_name, x_display_info_for_name):
6546 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6547 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6548 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6549 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6550 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6551 (last_show_tip_args): Now static.
6552 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6553 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6554 (x_screen_planes): Remove; unused.
6555 * dispextern.h (x_screen_planes): Remove decl.
6556
5bf46f05
PE
6557 * dispnew.c: Make symbols static if they're not exported.
6558 * dispextern.h (redraw_garbaged_frames, scrolling):
6559 (increment_row_positions): Remove.
6560 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6561 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6562 Now static.
6563 (redraw_garbaged_frames): Remove; unused.
6564
435f4c28
PE
6565 * xfaces.c: Make symbols static if they're not exported.
6566 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6567 Remove decls.
6568 * xterm.h (defined_color): Remove decls.
6569 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6570 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6571 (menu_face_changed_default, defined_color, free_realized_face):
6572 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6573 (ascii_face_of_lisp_face): Remove; unused.
6574
8524aef3
PE
6575 * xdisp.c: Make symbols static if they're not exported.
6576 * dispextern.h (scratch_glyph_row, window_box_edges):
6577 (glyph_to_pixel_coords, set_cursor_from_row):
6578 (get_next_display_element, set_iterator_to_next):
6579 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6580 (show_mouse_face): Remove decls
6581 * frame.h (message_buf_print): Likewise.
6582 * lisp.h (pop_message, set_message, check_point_in_composition):
6583 Likewise.
6584 * xterm.h (set_vertical_scroll_bar): Likewise.
6585 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6586 (message_buf_print, scratch_glyph_row, displayed_buffer):
6587 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6588 (get_next_display_element, show_mouse_face, window_box_edges):
6589 (frame_to_window_pixel_xy, check_point_in_composition):
6590 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6591 (glyph_to_pixel_coords): Remove; unused.
6592
16390cd2
PE
6593 * dired.c (file_name_completion): Now static.
6594
6595 * dbusbind.c (xd_in_read_queued_messages): Now static.
6596
a25f4dfa
PE
6597 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6598 * data.c (circular_list_error): Remove.
6599
14a9c8df
PE
6600 * commands.h (last_point_position, last_point_position_buffer):
6601 (last_point_position_window): Remove decls.
6602 * keyboard.c: Make these variables static.
6603
04f2d78b
CB
6604 * coding.h (coding, code_convert_region, encode_coding_gap):
6605 Remove decls.
74ab6df5
PE
6606 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6607 (iso_code_class, detect_coding, code_convert_region): Now static.
6608 (encode_coding_gap): Remove; unused.
6609
38dfbee1
PE
6610 * chartab.c (chartab_chars, chartab_bits): Now static.
6611
a2cb4e63
PE
6612 * charset.h (charset_iso_8859_1): Remove decl.
6613 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6614 Now static.
6615
127198fd
PE
6616 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6617 * ccl.c (Vccl_program_table): Now static.
6618 (check_ccl_update): Remove; unused.
6619
d85b608f
PE
6620 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6621 * category.h: ... from here.
6622 * category.c (check_category_table, set_category_set): Now static.
6623
31cd66f3
PE
6624 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6625 * lisp.h: Remove these decls.
6626
c358e587
PE
6627 * buffer.c (buffer_count): Remove unused var.
6628
e78aecca
PE
6629 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6630 so that it's not optimized away.
6631 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6632 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6633 exported only to the debugger.
6634
e192d7d3 6635 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6636 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6637
92470028
PE
6638 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6639 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6640 was inaccessible from Lisp.
6641 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6642 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6643
244ed907
PE
6644 alloc.c: Import and export fewer symbols, and remove unused items.
6645 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6646 is defined.
6647 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6648 it's not optimized away by whole-program optimization.
6649 (message_enable_multibyte, free_misc): Remove.
6650 (catchlist, handlerlist, mark_backtrace):
6651 Declare only if BYTE_MARK_STACK.
6652 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6653 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6654 (message_enable_multibyte): Remove decl.
6655 (free_misc, interval_free_list, float_block, float_block_index):
6656 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6657 (cons_free_list, last_marked_index):
6658 Now static.
6659 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6660 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6661 (mark_backtrace): Define only if BYTE_MARK_STACK.
6662 * xdisp.c (message_enable_multibyte): Now static.
6663
61c2b50e 6664 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6665 This makes it easier for human readers (and static analyzers)
6666 to see whether these variables are used from other modules.
6667 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6668 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6669 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6670 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6671 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6672 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6673 * xmenu.c, xselect.c:
6674 Declare Q* vars static if they are not used in other modules.
6675 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6676 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6677 Remove decls of unexported vars.
6678 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6679
95c82688
PE
6680 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6681
16a97296
PE
6682 Make Emacs functions such as Fatom 'static' by default.
6683 This makes it easier for human readers (and static analyzers)
6684 to see whether these functions can be called from other modules.
6685 DEFUN now defines a static function. To make the function external
6686 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6687 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6688 (Finit_image_library):
16a97296
PE
6689 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6690 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6691 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6692 Remove decls, since these functions are now static.
6693 (Funintern, Fget_internal_run_time): New decls, since these functions
6694 were already external.
95c82688 6695
16a97296
PE
6696 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6697 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6698 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6699 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6700 * keyboard.c, keymap.c, lread.c:
6701 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6702 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6703 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6704 Mark functions with DEFUE instead of DEFUN,
6705 if they are used in other modules.
6706 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6707 decls for now-static functions.
6708 * buffer.h (Fdelete_overlay): Remove decl.
6709 * callproc.c (Fgetenv_internal): Mark as internal.
6710 * composite.c (Fremove_list_of_text_properties): Remove decl.
6711 (Fcomposition_get_gstring): New forward static decl.
6712 * composite.h (Fcomposite_get_gstring): Remove decl.
6713 * dired.c (Ffile_attributes): New forward static decl.
6714 * doc.c (Fdocumntation_property): New forward static decl.
6715 * eval.c (Ffetch_bytecode): New forward static decl.
6716 (Funintern): Remove extern decl; now in .h file where it belongs.
6717 * fileio.c (Fmake_symbolic_link): New forward static decl.
6718 * image.c (Finit_image_library): New forward static decl.
6719 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6720 * intervals.h (Fprevious_property_change):
6721 (Fremove_list_of_text_properties): Remove decls.
6722 * keyboard.c (Fthis_command_keys): Remove decl.
6723 (Fcommand_execute): New forward static decl.
6724 * keymap.c (Flookup_key): New forward static decl.
6725 (Fcopy_keymap): Now static.
6726 * keymap.h (Flookup_key): Remove decl.
6727 * process.c (Fget_process): New forward static decl.
6728 (Fprocess_datagram_address): Mark as internal.
6729 * syntax.c (Fsyntax_table_p): New forward static decl.
6730 (skip_chars): Remove duplicate decl.
6731 * textprop.c (Fprevious_property_change): New forward static decl.
6732 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6733 Now internal.
6734 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6735 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6736
785bbd42
PE
6737 * editfns.c (Fformat): Remove unreachable code.
6738
8b913b57
AS
67392011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6740
6741 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6742 change. (Bug#8496)
6743
a6744a35
EZ
67442011-04-13 Eli Zaretskii <eliz@gnu.org>
6745
6746 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6747 when at ZV. (Bug#8487)
6748
e7974947
AS
67492011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6750
baad03f0
AS
6751 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6752 (Bug#8437)
6753 * keyboard.c (parse_tool_bar_item): Likewise.
6754 * sound.c (sound_cleanup, alsa_close): Likewise.
6755 * termcap.c (tgetent): Likewise.
6756 * xfns.c (x_default_font_parameter): Likewise.
6757 * xsettings.c (read_and_apply_settings): Likewise.
6758
e7974947
AS
6759 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6760 (overrun_check_free): Protoize.
6761
28272684
PE
67622011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6763
6764 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6765 since callers should never pass a negative size.
6766 Change the signature to match that of plain 'read' and 'write'; see
6767 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6768 * lisp.h: Update prototypes of emacs_write and emacs_read.
6769
11997c76
EZ
67702011-04-11 Eli Zaretskii <eliz@gnu.org>
6771
6772 * xdisp.c (redisplay_window): Don't try to determine the character
6773 position of the scroll margin if the window start point w->startp
e896f03c 6774 is outside the buffer's accessible region. (Bug#8468)
11997c76 6775
8a2cbd72
EZ
67762011-04-10 Eli Zaretskii <eliz@gnu.org>
6777
6778 Fix write-region and its subroutines for buffers > 2GB.
6779 * fileio.c (a_write, e_write): Modify declaration of arguments and
6780 local variables to support buffers larger than 2GB.
6781 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6782
6783 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6784 argument, local variables, and return value.
6785
6786 * lisp.h: Update prototypes of emacs_write and emacs_read.
6787
6788 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6789
4073e537 67902011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6791
1ebfdcb6
PE
6792 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6793
b2ded58d
PE
6794 Fix more problems found by GCC 4.6.0's static checks.
6795
7d66342c
PE
6796 * xdisp.c (vmessage): Use a better test for character truncation.
6797
bbf47d44
PE
6798 * charset.c (load_charset_map): <, not <=, for optimization,
6799 and to avoid potential problems with integer overflow.
9248994d 6800 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6801 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6802 * editfns.c (Fformat): Likewise.
1e69125e 6803 * syntax.c (skip_chars): Likewise.
3befa583 6804
e3019616
PE
6805 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6806 This also lets GCC 4.6.0 generate slightly better loop code.
6807
becfa255
PE
6808 * callint.c (Fcall_interactively): <, not <=, for optimization.
6809 (Fcall_interactively): Count the number of arguments produced,
6810 not the number of arguments given. This is simpler and lets GCC
6811 4.6.0 generate slightly better code.
6812
dae0cd48
PE
6813 * ftfont.c: Distingish more carefully between FcChar8 and char.
6814 The previous code passed unsigned char * to a functions like
6815 strlen and xstrcasecmp that expect char *, which does not
6816 conform to the C standard.
6817 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6818 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6819 char * when the C standard requires it.
6820
76032d70
PE
6821 * keyboard.c (read_char): Remove unused var.
6822
eb3f1cc8
PE
6823 * eval.c: Port to Windows vsnprintf (Bug#8435).
6824 Include <limits.h>.
6825 (SIZE_MAX): Define if the headers do not.
6826 (verror): Do not give up if vsnprintf returns a negative count.
6827 Instead, grow the buffer. This ports to Windows vsnprintf, which
6828 does not conform to C99. Problem reported by Eli Zaretskii.
6829 Also, simplify the allocation scheme, by avoiding the need for
6830 calling realloc, and removing the ALLOCATED variable.
6831
70476b54
PE
6832 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6833
12020a9e
PE
6834 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6835 But keep the doprint source code for now, as we might revamp it
6836 and use it again (Bug#8435).
ea6c7ae6
PE
6837 * lisp.h (doprnt): Remove.
6838 * Makefile.in (base_obj): Remove doprnt.o.
6839 * deps.mk (doprnt.o): Remove.
6840
5fdb398c
PE
6841 error: Print 32- and 64-bit integers portably (Bug#8435).
6842 Without this change, on typical 64-bit hosts error ("...%d...", N)
6843 was used to print both 32- and 64-bit integers N, which relied on
6844 undefined behavior.
6845 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6846 New macro.
6847 * lisp.h (error, verror): Mark as printf-like functions.
6848 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6849 Report overflow in size calculations when allocating printf buffer.
6850 Do not truncate output string at its first null byte.
6851 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6852 Truncate the output at a character boundary, since vsnprintf does not
6853 do that.
6854 * charset.c (check_iso_charset_parameter): Convert internal
6855 character to string before calling 'error', since %c now has the
6856 printf meaning.
6857 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6858 overflow when computing char to be passed to 'error'. Do not
6859 pass Lisp_Object to 'error'; pass the integer instead.
6860 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6861 formatted with plain %d.
6862
b189fa66
PE
6863 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6864
bff87ef0
PE
6865 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6866
7e2cac20
PE
6867 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6868
ce4d90b5
PE
6869 * xterm.c (x_catch_errors): Remove duplicate declaration.
6870
266c9547
PE
6871 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6872
79c49ad2
PE
6873 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6874
368f4090
JM
68752011-04-10 Jim Meyering <meyering@redhat.com>
6876
6877 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6878 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6879 return ssize_t not "int", and use size_t as the buffer length.
6880 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6881 * gnutls.h: Update declarations.
6882 * process.c (read_process_output): Use ssize_t, to match.
6883 (send_process): Likewise.
6884
a32d4040
CY
68852011-04-09 Chong Yidong <cyd@stupidchicken.com>
6886
6887 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6888
8546720e 68892011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6890
04f2d78b
CB
6891 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6892 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6893
8546720e
GM
6894 * xterm.c (handle_one_xevent):
6895 * xmenu.c (create_and_show_popup_menu):
6896 * xselect.c (x_decline_selection_request)
6897 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6898
0a2f5c1a 68992011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6900
6901 Fix some uses of `int' instead of EMACS_INT.
6902 * search.c (string_match_1, fast_string_match)
6903 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6904 (scan_buffer, find_next_newline_no_quit)
6905 (find_before_next_newline, search_command, Freplace_match)
6906 (Fmatch_data): Make some `int' variables be EMACS_INT.
6907
6908 * xdisp.c (display_count_lines): 3rd argument and return value now
6909 EMACS_INT. All callers changed.
6910 (pint2hrstr): Last argument is now EMACS_INT.
6911
6912 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6913 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6914 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6915 (decode_coding_utf_16, decode_coding_emacs_mule)
6916 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6917 (decode_coding_ccl, decode_coding_charset)
6918 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6919 (decode_coding_iso_2022, decode_coding_emacs_mule)
6920 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6921 <char_offset, last_offset>: Declare EMACS_INT.
6922 (encode_coding_utf_8, encode_coding_utf_16)
6923 (encode_coding_emacs_mule, encode_invocation_designation)
6924 (encode_designation_at_bol, encode_coding_iso_2022)
6925 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6926 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6927 Declare EMACS_INT.
6928 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6929 (encode_invocation_designation): Last argument P_NCHARS is now
6930 EMACS_INT.
6931 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6932 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6933
6934 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6935 All users changed.
6936
6937 * ccl.c (Fccl_execute_on_string): Declare some variables
6938 EMACS_INT.
6939
8546720e 69402011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6941
6942 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6943
4e19a977
CS
69442011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6945
6946 * process.c (Fformat_network_address): Doc fix.
6947
87302331
R
69482011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6949
6950 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6951
cbb59342
CY
69522011-04-08 Chong Yidong <cyd@stupidchicken.com>
6953
6954 * keyboard.c (read_char): Call Lisp function help-form-show,
6955 instead of using internal_with_output_to_temp_buffer.
6956 (Qhelp_form_show): New var.
e0d38eeb 6957 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6958
6959 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6960
6961 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6962
e67a13ab
CY
69632011-04-06 Chong Yidong <cyd@stupidchicken.com>
6964
04f2d78b
CB
6965 * process.c (Flist_processes): Remove to Lisp.
6966 (list_processes_1): Delete.
e67a13ab 6967
973f782d
EZ
69682011-04-06 Eli Zaretskii <eliz@gnu.org>
6969
7c106b1e
EZ
6970 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6971
973f782d
EZ
6972 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6973
41cf7d1a 69742011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6975
ca23cc88
PE
6976 Fix more problems found by GCC 4.6.0's static checks.
6977
f390e2d5
PE
6978 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6979
42eea0d0
PE
6980 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6981
b69769da 6982 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6983
f9541e84
PE
6984 * xdisp.c (vmessage): Mark as a printf-like function.
6985
13841b55
PE
6986 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6987
c136c10f
PE
6988 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6989
5e2d4a30
PE
6990 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6991 printf-like functions.
6992 (tiff_load): Add casts to remove these marks before passing them
6993 to system-supplied API.
6994
583f48b9
PE
6995 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6996
b25d760e
PE
6997 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6998 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6999 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7000 directly, rather than having caller test rule sign. This avoids
7001 some unnecessary tests.
7002 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7003 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7004 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7005
bc7b6697 7006 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7007 (xfont_open): Avoid unnecessary tests.
bc7b6697 7008
27ccc379
PE
7009 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7010
dcd5c89a
PE
7011 * composite.h, composite.c (composition_gstring_put_cache):
7012 Use EMACS_INT, not int, for length.
7013
b13a45c6
PE
7014 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7015 breaking out part of COMPOSITION_DECODE_RULE.
7016 (COMPOSITION_DECODE_RULE): Use it.
7017 * composite.c (get_composition_id): Remove unused local vars,
7018 by using the new macro.
7019
1e792e4d
PE
7020 * textprop.c (set_text_properties_1): Change while to do-while,
7021 since the condition is always true at first.
7022
dc6c6455 7023 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7024 (interval_deletion_adjustment): Return unsigned value.
7025 All uses changed.
dc6c6455 7026
aba7731a
PE
7027 * process.c (list_processes_1, create_pty, read_process_output):
7028 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7029 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7030 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7031 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7032 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7033
fdfc4bf3
PE
7034 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7035
fca8fe46 7036 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7037 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7038
06a0259a 7039 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7040 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7041 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7042
e7b9e80f
PE
7043 * print.c (print_error_message): Avoid int overflow.
7044
56201685
PE
7045 * font.c (font_list_entities): Redo for clarity,
7046 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7047
78834453 7048 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7049 (font_score): Avoid potential overflow in diff calculation.
78834453 7050
0bc0b309 7051 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7052 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7053
e610eaca
PE
7054 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7055
b895abce
PE
7056 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7057 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7058 can always succeed if overflow has undefined behavior.
7059
1f1d9321 7060 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7061 (wordify): Omit three unnecessary tests.
1f1d9321 7062
c59478bc
PE
7063 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7064 All callers changed. This avoids the need for an unused var.
7065
79b73827
PE
7066 * casefiddle.c (casify_region): Remove var that is set but not used.
7067
a4db5dfe
PE
7068 * dired.c (file_name_completion): Remove var that is set but not used.
7069
43aae36e
PE
7070 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7071
2a47c44d 7072 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7073 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7074
a37c69bf
PE
7075 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7076 Check for integer overflow on size calculations.
7077
328ab8e7
PE
7078 * buffer.c (Fprevious_overlay_change): Remove var that is set
7079 but not used.
7080
e5a2a5cb
PE
7081 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7082 Remove vars that are set but not used.
8d84a6eb 7083 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7084 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7085
a60e5f68
PE
7086 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7087
f661cb61 7088 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7089 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7090
f0397f5a
PE
7091 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7092 that are set but not used.
7093
8664db06 7094 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7095 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7096
6abdaa4a
PE
7097 * xselect.c (x_get_local_selection, x_handle_property_notify):
7098 Remove vars that are set but not used.
7099
0ce7538d 7100 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7101 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7102
9ae848fc
PE
7103 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7104 Remove var that is set but not used.
0b918413
PE
7105 (scroll_bar_windows_size): Now size_t, not int.
7106 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7107 Check for overflow.
9ae848fc 7108
a5a62657
PE
7109 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7110 (map_tty_color) [!defined MSDOS]: Likewise.
7111
5c5cdd39
PE
7112 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7113
66ebf983
PE
7114 * coding.c: Remove vars that are set but not used.
7115 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7116 All callers changed.
7117 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7118 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7119 (decode_coding_charset): Remove vars that are set but not used.
7120
1be4d761
PE
7121 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7122 that is set but not used.
7123
47553fa8
PE
7124 * print.c (print_object): Remove var that is set but not used.
7125
1f7196bf 7126 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7127 The gnulib version avoids calling malloc in the usual case,
7128 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7129 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7130 * filelock.c (current_lock_owner): Likewise.
7131 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7132 * sysdep.c: Include allocator.h, careadlinkat.h.
7133 (emacs_no_realloc_allocator): New static constant.
7134 (emacs_readlink): New function.
fdb61804
PE
7135 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7136 ../lib/careadlinkat.h.
d1fdcab7 7137
f84c17c7
SM
71382011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7139
7140 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7141 first non-nil return value).
7142
ef3862ad
JD
71432011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7144
7145 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7146 if not defined (Bug#8403).
7147
376a7006
JB
71482011-04-02 Juanma Barranquero <lekktu@gmail.com>
7149
7150 * xdisp.c (display_count_lines): Remove parameter `start',
7151 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7152 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7153 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7154 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7155 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7156 and thereabouts. All callers changed.
7157 (get_per_char_metric): Remove parameter `f', unused since
7158 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7159
6ca3801d
JM
71602011-04-02 Jim Meyering <meyering@redhat.com>
7161
7162 do not dereference NULL upon failed strdup
7163 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7164 (ns_get_family): Likewise.
7165
d8e2b5ba
JB
71662011-04-02 Juanma Barranquero <lekktu@gmail.com>
7167
7168 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7169
8c74fcbd
JD
71702011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7171
7172 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7173 later (Bug#8403).
7174
7200d79c
SM
71752011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7176
03408648 7177 Add lexical binding.
7200d79c 7178
03408648
SM
7179 * window.c (Ftemp_output_buffer_show): New fun.
7180 (Fsave_window_excursion):
7181 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7182
7183 * lread.c (lisp_file_lexically_bound_p): New function.
7184 (Fload): Bind Qlexical_binding.
7185 (readevalloop): Remove `evalfun' arg.
7186 Bind Qinternal_interpreter_environment.
7187 (Feval_buffer): Bind Qlexical_binding.
7188 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7189 Mark as dynamic.
7190 (syms_of_lread): Declare `lexical-binding'.
7191
7192 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7193
7194 * keyboard.c (eval_dyn): New fun.
7195 (menu_item_eval_property): Use it.
ca105506
SM
7196
7197 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7198
03408648
SM
7199 * fns.c (concat, mapcar1): Accept byte-code-functions.
7200
7201 * eval.c (Fsetq): Handle lexical vars.
7202 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7203 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7204 (FletX, Flet): Obey lexical binding.
7205 (Fcommandp): Handle closures.
7206 (Feval): New `lexical' arg.
7207 (eval_sub): New function extracted from Feval. Use it almost
7208 everywhere where Feval was used. Look up vars in lexical env.
7209 Handle closures.
7210 (Ffunctionp): Move from subr.el.
7211 (Ffuncall): Handle closures.
7212 (apply_lambda): Remove `eval_flags'.
7213 (funcall_lambda): Handle closures and new byte-code-functions.
7214 (Fspecial_variable_p): New function.
7215 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7216 but without exporting it to Lisp.
23aba0ea 7217
23aba0ea 7218 * doc.c (Fdocumentation, store_function_docstring):
03408648 7219 * data.c (Finteractive_form): Handle closures.
23aba0ea 7220
03408648
SM
7221 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7222 interactive spec.
ba83908c 7223
04f2d78b
CB
7224 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7225 New byte-codes.
03408648
SM
7226 (exec_byte_code): New function extracted from Fbyte_code to handle new
7227 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7228
03408648 7229 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7230
03408648 7231 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7232
e2abce01
JB
72332011-03-31 Juanma Barranquero <lekktu@gmail.com>
7234
7235 * xdisp.c (redisplay_internal): Fix prototype.
7236
63696a73 72372011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7238
63696a73 7239 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7240 (try_scrolling): Use it when setting scroll_limit.
7241 Limit scrolling to 100 screen lines.
63696a73
EZ
7242 (redisplay_window): Even when falling back on "recentering",
7243 position point in the window according to scroll-conservatively,
7244 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7245
7246 (try_scrolling): When point is above the window, allow searching
7247 as far as scroll_max, or one screenful, to compute vertical
7248 distance from PT to the scroll margin position. This prevents
7249 try_scrolling from unnecessarily failing when
7250 scroll-conservatively is set to a value slightly larger than the
7251 window height. Clean up the case of PT below the margin at bottom
7252 of window: scroll_max can no longer be INT_MAX. When aggressive
7253 scrolling is in use, don't let point enter the opposite scroll
7254 margin as result of the scroll.
7255 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7256 threshold of 100 lines for never-recentering scrolling.
7257
e4cc2dfc
JB
72582011-03-31 Juanma Barranquero <lekktu@gmail.com>
7259
7260 * dispextern.h (move_it_by_lines):
7261 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7262 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7263 (message_log_check_duplicate): Remove parameters `prev_bol' and
7264 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7265 (redisplay_internal): Remove parameter `preserve_echo_area',
7266 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7267
7268 * indent.c (Fvertical_motion):
7269 * window.c (window_scroll_pixel_based, Frecenter):
7270 Don't pass `need_y_p' to `move_it_by_lines'.
7271
1c470562
SM
72722011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7273
44f230aa
SM
7274 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7275 steal a few bits to be more compact.
7276 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7277 Remove unneeded casts.
7278
1c470562
SM
7279 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7280
888adce9
ZK
72812011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7282
7283 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7284 binding" message (bug#7967).
7285
f838ed7b
PE
72862011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7287
77861b95
PE
7288 Fix more problems found by GCC 4.6.0's static checks.
7289
de6dbc14
PE
7290 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7291 Remove unused local var.
7292
f838ed7b
PE
7293 * editfns.c (Fmessage_box): Remove unused local var.
7294
792c7b2b
PE
7295 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7296 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7297 Omit unused local vars.
c499e557 7298 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7299 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7300 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7301 Omit unused local var.
7302
ba0165e1
PE
7303 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7304 Don't assume string length fits in int.
32ad8845 7305 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7306 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7307
3c59b4c9
PE
7308 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7309 instead of alloca (Bug#8344).
7310
a3eed478 7311 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7312 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7313
eb4d412d
PE
7314 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7315
1658b401
PE
7316 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7317 concerns.
7318
7319 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7320
7321 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7322
9a2c6e05
PE
7323 * keyboard.c (syms_of_keyboard): Use the same style as later
7324 in this function when indexing through an array. This also
7325 works around GCC bug 48267.
7326
03d0a109
PE
7327 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7328
44f730c8
PE
7329 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7330
fe75f926
PE
7331 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7332 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7333
ffa8c828
PE
7334 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7335 This avoids undefined behavior on integer overflow, and is a bit
7336 more convenient anyway since it is compared to a size_t variable.
7337
c5101a77
PE
7338 Variadic C functions now count arguments with size_t, not int.
7339 This avoids an unnecessary limitation on 64-bit machines, which
7340 caused (substring ...) to crash on large vectors (Bug#8344).
7341 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7342 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7343 All variadic functions and their callers changed accordingly.
c5101a77
PE
7344 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7345 * data.c (arith_driver, float_arith_driver): Likewise.
7346 * editfns.c (general_insert_function): Likewise.
7347 * eval.c (struct backtrace.nargs, interactive_p)
7348 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7349 (funcall_lambda, mark_backtrace): Likewise.
7350 * fns.c (concat): Likewise.
7351 * frame.c (x_set_frame_parameters): Likewise.
7352 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7353 0 if not found, not -1. All callers changed.
7354
dd3f25f7
PE
7355 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7356 (stack_copy_size): Now size_t, not int.
7357 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7358
461c2ab9
JB
73592011-03-28 Juanma Barranquero <lekktu@gmail.com>
7360
7361 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7362 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7363 All callers changed.
7364
7365 * lisp.h (multibyte_char_to_unibyte):
7366 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7367 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7368 * character.h (CHAR_TO_BYTE8):
7369 * cmds.c (internal_self_insert):
7370 * editfns.c (general_insert_function):
7371 * keymap.c (push_key_description):
7372 * search.c (Freplace_match):
7373 * xdisp.c (message_dolog, set_message_1): All callers changed.
7374
f6d62986
SM
73752011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7376
7377 * keyboard.c (safe_run_hook_funcall): New function.
7378 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7379 don't set the hook to nil, but remove the offending function instead.
7380 (Qcommand_hook_internal): Remove, unused.
7381 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7382 Vcommand_hook_internal.
7383
7384 * eval.c (enum run_hooks_condition): Remove.
7385 (funcall_nil, funcall_not): New functions.
7386 (run_hook_with_args): Call each function through a `funcall' argument.
7387 Remove `cond' argument, now redundant.
7388 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7389 (Frun_hook_with_args_until_failure): Adjust accordingly.
7390 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7391
1db5b1ad
JB
73922011-03-28 Juanma Barranquero <lekktu@gmail.com>
7393
7394 * dispextern.h (string_buffer_position): Remove declaration.
7395
7396 * print.c (strout): Remove parameter `multibyte', unused since
7397 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7398
7399 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7400 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7401 All callers changed.
7402
7403 * w32.c (_wsa_errlist): Use braces for struct initializers.
7404
7405 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7406 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7407 All callers changed.
7408 (string_buffer_position): Likewise. Also, make static (it's never
7409 used outside xdisp.c).
7410 (cursor_row_p): Remove parameter `w', unused since
7411 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7412 (decode_mode_spec): Remove parameter `precision', introduced during
7413 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7414 All callers changed.
7415
5ffb62aa
JD
74162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7417
7418 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7419
461c2ab9 74202011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7421
7422 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7423 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7424 (ns_update_auto_hide_menu_bar): New functions.
7425 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7426 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7427 ns_constrain_all_frames.
7428 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7429 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7430
5c380ffb
JD
74312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7432
7433 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7434
9af30bdf
GM
74352011-03-27 Glenn Morris <rgm@gnu.org>
7436
7437 * syssignal.h: Replace RETSIGTYPE with void.
7438 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7439 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7440 Replace SIGTYPE with void everywhere.
7441 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7442 * s/template.h (SIGTYPE): Remove commented out definition.
7443
e2abce01
JB
74442011-03-26 Eli Zaretskii <eliz@gnu.org>
7445
7446 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7447 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7448
f868cd8a
JB
74492011-03-26 Juanma Barranquero <lekktu@gmail.com>
7450
59eb0929
JB
7451 * w32.c (read_unc_volume): Use parameter `henum', instead of
7452 global variable `wget_enum_handle'.
7453
7454 * keymap.c (describe_vector): Remove parameters `indices' and
7455 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7456 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7457
f868cd8a
JB
7458 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7459
7460 * keyboard.c (timer_check): Remove parameter `do_it_now',
7461 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7462 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7463 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7464
7465 * keyboard.c (read_char):
7466 * w32menu.c (w32_menu_display_help):
7467 * xmenu.c (show_help_event, menu_help_callback):
7468 Adjust calls to `show_help_echo'.
7469
7470 * gtkutil.c (xg_maybe_add_timer):
7471 * keyboard.c (readable_events):
7472 * process.c (wait_reading_process_output):
7473 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7474
7475 * insdel.c (adjust_markers_gap_motion):
7476 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7477 (gap_left, gap_right): Don't call it.
7478
2ecf6fdb
CY
74792011-03-25 Chong Yidong <cyd@stupidchicken.com>
7480
7481 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7482 incurred during fontification.
7483
6b1f9ba4
JB
74842011-03-25 Juanma Barranquero <lekktu@gmail.com>
7485
7486 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7487 (DEFVAR_PER_BUFFER): Don't pass it.
7488
7489 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7490 (scrolling_window): Don't pass it.
7491
0f4a96b5
JB
74922011-03-25 Juanma Barranquero <lekktu@gmail.com>
7493
7494 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7495
7496 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7497 and `suffix'.
7498 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7499 of variables specific to SELinux and computation of `encoded_absname'.
7500
7501 * image.c (XPutPixel): Remove unused variable `height'.
7502
7503 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7504
7505 * unexw32.c (get_section_info): Remove unused variable `section'.
7506
7507 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7508 (system_process_attributes): Remove unused variable `sess'.
7509 (sys_read): Remove unused variable `err'.
7510
7511 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7512 (w32_wnd_proc): Remove unused variable `isdead'.
7513 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7514 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7515 (x_create_tip_frame): Remove unused variable `tem'.
7516
7517 * w32inevt.c (w32_console_read_socket):
7518 Remove unused variable `no_events'.
7519
7520 * w32term.c (x_draw_composite_glyph_string_foreground):
7521 Remove unused variable `width'.
7522
1149507c
JB
75232011-03-24 Juanma Barranquero <lekktu@gmail.com>
7524
7525 * w32term.c (x_set_glyph_string_clipping):
7526 Don't pass uninitialized region to CombineRgn.
7527
9c88f339
JB
75282011-03-23 Juanma Barranquero <lekktu@gmail.com>
7529
7530 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7531 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7532 (Fx_close_connection): Remove unused variable `i'.
7533
7534 * w32font.c (w32font_draw): Return number of glyphs.
7535 (w32font_open_internal): Remove unused variable `i'.
7536 (w32font_driver): Add missing initializer.
7537
7538 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7539 (fill_in_menu): Remove unused variable `items_added'.
7540
7541 * w32term.c (last_mouse_press_frame): Remove static global variable.
7542 (w32_clip_to_row): Remove unused variable `f'.
7543 (x_delete_terminal): Remove unused variable `i'.
7544
7545 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7546 (NOTHING): Remove unused static global variable.
7547 (uniscribe_check_otf): Remove unused variable `table'.
7548 (uniscribe_font_driver): Add missing initializers.
7549
dee091a3
JD
75502011-03-23 Julien Danjou <julien@danjou.info>
7551
7552 * term.c (Fsuspend_tty, Fresume_tty):
7553 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7554 * window.c (temp_output_buffer_show):
7555 * insdel.c (signal_before_change):
7556 * frame.c (Fhandle_switch_frame):
7557 * fileio.c (Fdo_auto_save):
7558 * emacs.c (Fkill_emacs):
7559 * editfns.c (save_excursion_restore):
7560 * cmds.c (internal_self_insert):
7561 * callint.c (Fcall_interactively):
7562 * buffer.c (Fkill_all_local_variables):
7563 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7564 Use Frun_hooks.
0f4a96b5 7565 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7566 unconditionnaly since it does the check itself.
7567
2c520ab5 75682011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7569
c9c49752
PE
7570 Fix more problems found by GCC 4.5.2's static checks.
7571
8abc3f12
PE
7572 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7573 the first time through the loop, since we know p0 < p1 then.
7574 This also avoids a gcc -Wstrict-overflow warning.
7575
a2d26660
PE
7576 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7577 leading to a memory leak, possible in functions like
7578 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7579 of objects (Bug#8318).
a2d26660 7580
916c72e9
PE
7581 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7582 that could (at least in theory) be that large.
7583
19ab8a18
PE
7584 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7585 This is less likely to overflow, and avoids undefined behavior if
7586 overflow does occur. All callers changed. Use strtoul to scan
7587 for the unsigned long integer.
b7cbbd6f
PE
7588 (pint2hrstr): Simplify and tune code slightly.
7589 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7590
f0641eff
PE
7591 * scroll.c (do_scrolling): Work around GCC bug 48228.
7592 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7593
7f650bb9
PE
7594 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7595 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7596 (validate_x_resource_name): Simplify count usage.
7597 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7598
37dd57d1
PE
7599 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7600 fail (Bug#8306).
81e56e61 7601
699979fc 7602 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7603
401bf9b4
PE
7604 * process.c (Fmake_network_process): Use socklen_t, not int,
7605 where POSIX says socklen_t is required in portable programs.
7606 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7607 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7608 (Fmake_network_process, server_accept_connection):
7609 (wait_reading_process_output, read_process_output):
7610 Likewise.
7611
b93aacde
PE
7612 * process.c: Rename or move locals to avoid shadowing.
7613 (list_processes_1, Fmake_network_process):
7614 (read_process_output_error_handler, exec_sentinel_error_handler):
7615 Rename or move locals.
4dc343ee 7616 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7617 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7618 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7619 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7620 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7621
af8a867c 7622 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7623 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7624 Include tparam.h instead, since it declares them.
af8a867c
PE
7625 * cm.h (PC): Remove extern decl; tparam.h now does this.
7626 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7627 * terminfo.c: Include tparam.h, to check interfaces.
7628 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7629 (tparam): Adjust signature to match interface in tparam.h;
7630 this removes some undefined behavior. Check that outstring and len
7631 are zero, which they always are with Emacs.
7632 * tparam.h (PC, BC, UP): New extern decls.
7633
0248044d 7634 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7635 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7636
8ff096c1 7637 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7638 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7639 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7640 (ftfont_list): Remove unused local.
49eaafba
PE
7641 (get_adstyle_property, ftfont_pattern_entity):
7642 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7643 Rename locals to avoid shadowing.
8ff096c1 7644
e2be39f6
PE
7645 * xfont.c (xfont_list_family): Mark var as initialized.
7646
c9735e30
PE
7647 * xml.c (make_dom): Now static.
7648
8f5201ae
PE
7649 * composite.c (composition_compute_stop_pos): Rename local to
7650 avoid shadowing.
b246f932
PE
7651 (composition_reseat_it): Remove unused locals.
7652 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7653 (composition_update_it): Mark var as initialized.
11b61122
PE
7654 (find_automatic_composition): Mark vars as initialized,
7655 with a FIXME (Bug#8290).
8f5201ae 7656
760fbc2c
PE
7657 character.h: Rename locals to avoid shadowing.
7658 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7659 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7660 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7661 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7662 to avoid shadowing.
7663
ff08eb85
PE
7664 * textprop.c (property_change_between_p): Remove; unused.
7665
fc7bf025
PE
7666 * intervals.c (interval_start_pos): Now static.
7667
235d7abc
PE
7668 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7669
44f230aa
SM
7670 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7671 Rename locals to avoid shadowing.
3e7d6594 7672
50060332
PE
7673 * sound.c (wav_play, au_play, Fplay_sound_internal):
7674 Fix pointer signedness.
d01f234b 7675 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7676 (wav_play): Initialize a variable to 0, to prevent undefined
7677 behavior (Bug#8278).
50060332 7678
c4fc4e30
PE
7679 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7680
918436ed
PE
7681 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7682
c939f91b
PE
7683 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7684 clobbering (Bug#8298).
b9c7f648
PE
7685 * sysdep.c (sys_subshell): Likewise.
7686 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7687
6bd8c144
PE
7688 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7689 This should get cleaned up, so that child_setup has the
7690 same signature on all platforms.
7691
7710357c 7692 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7693 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7694
c59da222
CY
76952011-03-22 Chong Yidong <cyd@stupidchicken.com>
7696
7697 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7698 not to be necessary, and produces flickering.
7699
66b87493
GM
77002011-03-20 Glenn Morris <rgm@gnu.org>
7701
7702 * config.in: Remove file.
7703
45b6f6d5
JB
77042011-03-20 Juanma Barranquero <lekktu@gmail.com>
7705
7706 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7707 are now in src/globals.h.
7708 (syms_of_minibuf): Remove spurious & from previous change.
7709
3ec03f7e
LL
77102011-03-20 Leo <sdl.web@gmail.com>
7711
7712 * minibuf.c (completing-read-function): New variable.
7713 (completing-read-default): Rename from completing-read.
7714 (completing-read): Call completing-read-function.
7715
b14e3e21
CY
77162011-03-19 Juanma Barranquero <lekktu@gmail.com>
7717
7718 * xfaces.c (Fx_load_color_file):
7719 Read color file from absolute filename (bug#8250).
7720
f2b726e6
JB
77212011-03-19 Juanma Barranquero <lekktu@gmail.com>
7722
7723 * makefile.w32-in: Update dependencies.
7724
09f6ff02
EZ
77252011-03-17 Eli Zaretskii <eliz@gnu.org>
7726
7727 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7728
29a6015a
PE
77292011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7730
a3a6c54e
PE
7731 Fix more problems found by GCC 4.5.2's static checks.
7732
b766f867
PE
7733 * process.c (make_serial_process_unwind, send_process_trap):
7734 (sigchld_handler): Now static.
7735
be02381c
PE
7736 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7737 That way, the code declares only the vars that it needs.
7738 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7739 * s/cygwin.h (PTY_ITERATION): Likewise.
7740 * s/darwin.h (PTY_ITERATION): Likewise.
7741 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7742
57048744
PE
7743 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7744 * process.c (allocate_pty): Don't declare stb unless it's needed.
7745
7914961c 7746 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7747 (CONSTANTLIM): Remove; unused.
7748 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7749 Define only if needed.
7914961c 7750
b3967b18
PE
7751 * unexelf.c (unexec): Name an expression,
7752 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7753 Use a different way to cause a compilation error if anyone uses
7754 n rather than nn, a way that does not involve shadowing.
73366a00 7755 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7756
29a6015a
PE
7757 * deps.mk (unexalpha.o): Remove; unused.
7758
43cfc33e 7759 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7760 * unexec.h: New file.
ce701a33
PE
7761 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7762 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7763 Depend on unexec.h.
7764 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7765 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7766 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7767 Change as necessary to match prototype in unexec.h.
ce701a33 7768
01f44d5a
PE
7769 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7770 shadowing.
4f63c6bb 7771 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7772
a6670b0b
PE
7773 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7774 Rename locals to avoid shadowing.
7775
cef2010d 7776 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7777 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7778
d4d7173a
PE
7779 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7780
f08b802a
PE
7781 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7782 warning when compiling print.c.
7783
3ddb0639
PE
7784 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7785 instead of using an uninitialized var.
5ad03b97 7786 (font_sort_entities): Mark var as initialized.
3ddb0639 7787
170a2692
PE
7788 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7789
e663c700
PE
7790 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7791 pointers to constants.
89bc529a 7792 (font_parse_fcname): Remove unused vars.
7b81e2d0 7793 (font_delete_unmatched): Now static.
ea838e10 7794 (font_get_spec): Remove; unused.
13a547c6
PE
7795 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7796 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7797 Rename or move locals to avoid shadowing.
e663c700 7798
2a80c887 7799 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7800 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7801
1384fa33 7802 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7803 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7804
8b2c52e9
PE
7805 * alloc.c (mark_backtrace): Move decl from here ...
7806 * lisp.h: ... to here, so that it can be checked.
7807
475545b5 7808 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7809 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7810 (lisp_indirect_variable): Name an expression,
7811 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7812 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7813
b1349114 7814 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7815 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7816 Use const pointer when appropriate.
b1349114 7817
a2928364
PE
7818 * lisp.h (get_system_name, get_operating_system_release):
7819 Move decls here, to check interfaces.
7820 * process.c (get_operating_system_release): Move decl to lisp.h.
7821 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7822 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7823 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7824 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7825 (Fformat_time_string, Fencode_time, Finsert_char):
7826 (Ftranslate_region_internal, Fformat):
7827 Rename or remove local vars to avoid shadowing.
9710023e 7828 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7829
a415e694
PE
7830 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7831 avoid shadowing.
7832
8ef4622d
PE
7833 * lisp.h (eassert): Check that the argument compiles, even if
7834 ENABLE_CHECKING is not defined.
7835
946f9a5b
PE
7836 * data.c (Findirect_variable): Name an expression, to avoid
7837 gcc -Wbad-function-cast warning.
112396d6 7838 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7839 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7840 (Fmake_variable_buffer_local, Fmake_local_variable):
7841 Mark variables as initialized.
52746918 7842 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7843
e5aab7e7 7844 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7845 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7846 Rename locals to avoid shadowing.
dff45157
PE
7847 (mark_stack): Move local variables into the #ifdef region where
7848 they're used.
7bc26fdb
PE
7849 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7850 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7851 needed otherwise.
7852 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7853 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7854 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7855
e5aab7e7
PE
7856 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7857 avoids undefined behavior in theory.
7858
4da60324
PE
7859 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7860
88043301
PE
7861 Use functions, not macros, for up- and down-casing (Bug#8254).
7862 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7863 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7864 to use the following functions instead of these macros.
7865 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7866 EMACS_INT, since callers assume the returned value fits in int.
7867 (upcase1): Likewise, for UPCASE_TABLE.
7868 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7869 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7870 the race-condition problem in the old DOWNCASE.
88043301 7871
19ed5445
PE
7872 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7873 Rename locals to avoid shadowing.
7874 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7875 (regex_compile, re_search_2, re_match_2_internal):
7876 Remove unused local vars.
952db0d7
PE
7877 (FREE_VAR): Rewrite so as not to use empty "else",
7878 which gcc can warn about.
da053e48 7879 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7880 (RETALLOC_IF): Define only if needed.
7881 (WORDCHAR_P): Likewise. This one is never needed, but is used
7882 only in a comment talking about a compiler bug, so put inside
7883 the #if 0 of that comment.
7884 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7885 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7886 Remove; unused.
19ed5445 7887
1f3561e4 7888 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7889 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7890 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7891
ded6f8f7
PE
7892 * search.c (simple_search): Remove unused var.
7893
dbd37a95
PE
7894 * dired.c (compile_pattern): Move decl from here ...
7895 * lisp.h: ... to here, so that it can be checked.
7896 (struct re_registers): New forward decl.
7897
7e47afad
PE
7898 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7899
85f24f61
PE
7900 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7901 All uses changed.
7902 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7903 Rename locals to avoid shadowing.
5671df8f 7904 (Fvertical_motion): Mark locals as initialized.
85f24f61 7905
181aa2be 7906 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7907 (casify_region): Mark local as initialized.
181aa2be 7908
930d429c
PE
7909 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7910
7082eac6
PE
7911 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7912 New macros, so that the caller can use some names other than
7913 gcpro1, gcpro2, etc.
7914 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7915 of the new macros.
7916 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7917 argument, for consistency with GCPRO2_VAR, etc: it is now the
7918 prefix of the variable, not the variable itself. All uses
7919 changed.
38b2c076
PE
7920 * dired.c (directory_files_internal, file_name_completion):
7921 Rename locals to avoid shadowing.
7922
15206ed9
PE
7923 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7924 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7925 dired.c's scmp function, had undefined behavior.
7926 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7927 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7928 * buffer.h: ... to here, because these macros use current_buffer,
7929 and the new implementation with inline functions needs to have
7930 current_buffer in scope now, rather than later when the macros
7931 are used.
7932 (downcase, upcase1): New static inline functions.
7933 (DOWNCASE, UPCASE1): Reimplement using these functions.
7934 This avoids undefined behavior in expressions like
7935 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7936 from race conditions in accessing the global variables
7937 case_temp1 and case_temp2.
7938 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7939 * lisp.h (case_temp1, case_temp2): Remove their decls.
7940 * character.h (ASCII_CHAR_P): Move from here ...
7941 * lisp.h: ... to here, so that the inline functions mentioned
7942 above can use them.
7943
4a6bea26
PE
7944 * dired.c (directory_files_internal_unwind): Now static.
7945
f14b7e14
PE
7946 * fileio.c (file_name_as_directory, directory_file_name):
7947 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7948 Now static.
2893f146
PE
7949 (file_name_as_directory): Use const pointers when appropriate.
7950 (Fexpand_file_name): Likewise. In particular, newdir might
7951 point at constant storage, so make it a const pointer.
fd4ead52 7952 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7953 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7954 signedness issues.
f839df0c
PE
7955 (Fset_file_times, Finsert_file_contents, auto_save_error):
7956 Rename locals to avoid shadowing.
f14b7e14 7957
5716756e 7958 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7959 (Ftry_completion, Fall_completions): Rename or remove locals
7960 to avoid shadowing.
5716756e 7961
b4c3046a
PE
7962 * marker.c (bytepos_to_charpos): Remove; unused.
7963
b45db522
PE
7964 * lisp.h (verify_bytepos, count_markers): New decls,
7965 so that gcc does not warn that these functions aren't declared.
7966
85876d07
PE
7967 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7968 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7969 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7970 (copy_text): Remove unused local var.
85876d07 7971
03d78a21 7972 * filelock.c (within_one_second): Now static.
b3dd38ab 7973 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7974
5df8f01b
PE
7975 * buffer.c (fix_overlays_before): Mark locals as initialized.
7976 (fix_start_end_in_overlays): Likewise. This function should be
7977 simplified by using pointers-to-pointers, but that's a different
7978 matter.
b1d876f1 7979 (switch_to_buffer_1): Now static.
8f54f30a
PE
7980 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7981 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7982
a70072c9 7983 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7984 Fix pointer signedness issue.
edced198
PE
7985 (sys_subshell): Mark local as volatile if checking for lint,
7986 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7987 (MAXPATHLEN): Define only if needed.
a70072c9 7988
a0977c44
PE
7989 * process.c (serial_open, serial_configure): Move decls from here ...
7990 * systty.h: ... to here, so that they can be checked.
7991
a884fdcc
PE
7992 * fns.c (get_random, seed_random): Move extern decls from here ...
7993 * lisp.h: ... to here, so that they can be checked.
7994
604efe86 7995 * sysdep.c (reset_io): Now static.
b8950c94 7996 (wait_for_termination_signal): Remove; unused.
604efe86 7997
38fc62d9
PE
7998 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7999 (copy_keymap_item, append_key, push_text_char_description):
8000 Now static.
1004a21a 8001 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8002 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8003 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8004 (describe_map_tree):
8005 Rename locals to avoid shadowing.
38fc62d9 8006
2f2650da
PE
8007 * keyboard.c: Declare functions static if they are not used elsewhere.
8008 (echo_char, echo_dash, cmd_error, top_level_2):
8009 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8010 (read_char, kbd_buffer_get_event, make_lispy_position):
8011 (make_lispy_event, make_lispy_movement, apply_modifiers):
8012 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8013 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8014 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8015 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8016 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8017
a053e86c 8018 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8019 (mark_kboards): Move decl here ...
8020 * alloc.c (mark_kboards): ... from here.
a053e86c 8021
4752793e
PE
8022 * lisp.h (force_auto_save_soon): New decl.
8023
74f10ca7 8024 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8025 (DEFINE_DUMMY_FUNCTION): New macro.
8026 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8027 Use it.
c03cd23f
PE
8028 (main): Add casts to avoid warnings
8029 if GCC considers string literals to be constants.
74f10ca7 8030
022e70d4
PE
8031 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8032
59d6fe83
PE
8033 * dbusbind.c: Pointer signedness fixes.
8034 (xd_signature, xd_append_arg, xd_initialize):
8035 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8036 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8037 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8038 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8039
78320123
PE
8040 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8041 if GCC considers string literals to be constants.
49cebcca 8042 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8043
35ac2a97
SM
80442011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8045
fb103ca9
SM
8046 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8047 (print_preprocess, print_object): New macro to fix last change.
8048
35ac2a97
SM
8049 * print.c (print_preprocess): Don't forget font objects.
8050
62973b41
JB
80512011-03-16 Juanma Barranquero <lekktu@gmail.com>
8052
8053 * emacs.c (USAGE3): Doc fixes.
8054
0e48bb22
AS
80552011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8056
8057 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8058 structure.
8059
7684e57b
JB
80602011-03-14 Juanma Barranquero <lekktu@gmail.com>
8061
8062 * lisp.h (VWindow_system, Qfile_name_history):
8063 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8064 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8065 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8066
8067 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8068 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8069
8070 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8071 * w32console.c (detect_input_pending, read_input_pending)
8072 (encode_terminal_code):
8073 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8074 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8075 (w32_system_caret_y, Qfile_name_history):
8076 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8077 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8078 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8079 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8080 * w32proc.c (Qlocal, report_file_error):
8081 * w32term.c (Vwindow_system, updating_frame):
8082 * w32uniscribe.c (initialized, uniscribe_font_driver):
8083 Remove unneeded extern declarations.
8084
2aa46d6c
CY
80852011-03-14 Chong Yidong <cyd@stupidchicken.com>
8086
c96bbc66 8087 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8088
cffc6f3b
CY
80892011-03-13 Chong Yidong <cyd@stupidchicken.com>
8090
8091 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8092 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8093 These macros can no longer be used for assignment.
8094
44f230aa
SM
8095 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8096 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8097 (record_buffer_markers, fetch_buffer_markers): New functions for
8098 recording and fetching special buffer markers.
8099 (set_buffer_internal_1, set_buffer_temp): Use them.
8100
8101 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8102
8103 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8104
8105 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8106 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8107
8108 * xdisp.c (hscroll_window_tree):
8109 (reconsider_clip_changes): Use PT instead of BUF_PT.
8110
d251f04b
EZ
81112011-03-13 Eli Zaretskii <eliz@gnu.org>
8112
8113 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8114 $(EMACS_ROOT)/lib/intprops.h.
8115
f0c77cd1
PE
81162011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8117
3eca4629
PE
8118 Fix more problems found by GCC 4.5.2's static checks.
8119
7c86ee98
PE
8120 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8121 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8122 (xg_free_frame_widgets): Make it clear that a local variable is
8123 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8124 (gdk_window_get_screen): Make it clear that this macro is needed
8125 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8126 (int_gtk_range_get_value): New function, which avoids a diagnostic
8127 from gcc -Wbad-function-cast.
8128 (xg_set_toolkit_scroll_bar_thumb): Use it.
8129 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8130 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8131 (get_utf8_string, xg_get_file_with_chooser):
8132 Rename locals to avoid shadowing.
8133 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8134
41729b81
PE
8135 * xgselect.c (xg_select): Remove unused var.
8136
f0c77cd1
PE
8137 * image.c (four_corners_best): Mark locals as initialized.
8138 (gif_load): Initialize transparent_p to zero (Bug#8238).
8139 Mark another local as initialized.
ec6cf4c6 8140 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8141
ce0ad53d 8142 * image.c (clear_image_cache): Now static.
d5d5a617 8143 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8144 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8145 (x_edge_detection): Remove unnecessary cast that
8146 gcc -Wbad-function-cast diagnoses.
2037898d 8147 (gif_load): Fix pointer signedness.
6ae141d6
PE
8148 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8149 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8150
33383987 81512011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8152
d32df629
PE
8153 Improve quality of tests for time stamp overflow.
8154 For example, without this patch (encode-time 0 0 0 1 1
8155 1152921504606846976) returns the obviously-bogus value (-948597
8156 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8157 reports time overflow. See
8158 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8159 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8160 * editfns.c: Include limits.h and intprops.h.
8161 (TIME_T_MIN, TIME_T_MAX): New macros.
8162 (time_overflow): Move earlier, to before first use.
8163 (hi_time, lo_time): New functions, for an accurate test for
8164 out-of-range times.
8165 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8166 (Fget_internal_run_time): Don't assume time_t fits in int.
8167 (make_time): Use list2 instead of Fcons twice.
8168 (Fdecode_time): More accurate test for out-of-range times.
8169 (check_tm_member): New function.
8170 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8171 (lisp_time_argument): Don't rely on undefined left-shift and
8172 right-shift behavior when checking for time stamp overflow.
8be6f318 8173
fe31d94c
PE
8174 * editfns.c (time_overflow): New function, refactoring common code.
8175 (Fformat_time_string, Fdecode_time, Fencode_time):
8176 (Fcurrent_time_string): Use it.
8177
8be6f318
PE
8178 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8179 * dired.c (make_time): Move to ...
8180 * editfns.c (make_time): ... here.
8181 * systime.h: Note the move.
8182
09d9db2c 81832011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8184
126bc0dc
YM
8185 * fringe.c (update_window_fringes): Remove unused variables.
8186
c47cbdfd
YM
8187 * unexmacosx.c (copy_data_segment): Also copy __got section.
8188 (Bug#8223)
8189
7ac80be9
EZ
81902011-03-12 Eli Zaretskii <eliz@gnu.org>
8191
c96bbc66 8192 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8193 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8194 Constify `char *' arguments and their references according to
8195 prototypes in tparam.h.
8196
ecb0f94d 8197 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8198
7ac80be9
EZ
8199 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8200 Adapt all references accordingly.
8201
8202 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8203
ef1fd07e
TT
82042011-03-11 Tom Tromey <tromey@redhat.com>
8205
8206 * buffer.c (syms_of_buffer): Remove obsolete comment.
8207
7ef4b50c
EZ
82082011-03-11 Eli Zaretskii <eliz@gnu.org>
8209
8210 * termhooks.h (encode_terminal_code): Declare prototype.
8211
8212 * msdos.c (encode_terminal_code): Don't declare prototype.
8213
8214 * term.c (encode_terminal_code): Now external again, used by
8215 w32console.c and msdos.c.
8216
44f230aa
SM
8217 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8218 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8219
4b1ec863 82202011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8221
1714f52b 8222 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8223
4b1ec863
PE
8224 * fringe.c (update_window_fringes): Mark locals as initialized
8225 (Bug#8227).
8226 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8227
524c7aa6
PE
8228 * alloc.c (mark_fringe_data): Move decl from here ...
8229 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8230 to check its interface.
8231 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8232
a5c0af81 8233 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8234 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8235 (fontset_font): Mark local as initialized.
a9a06e0b 8236 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8237
b4716021
PE
8238 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8239
811e9bac 8240 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8241 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8242 (x_own_selection, Fx_disown_selection_internal): Rename locals
8243 to avoid shadowing.
8244 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8245
7e3ab302
PE
8246 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8247 so that the caller can use some name other than gcpro1.
8248 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8249 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8250 (Fx_backspace_delete_keys_p):
8251 Use them to avoid shadowing, and rename vars to avoid shadowing.
8252 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8253 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8254 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8255 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8256 Remove unused locals.
7e3ab302
PE
8257 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8258 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8259 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8260 macros.
f78faa98 8261
e2b13473
PE
8262 * xterm.h (x_mouse_leave): New decl.
8263
77f23912
PE
8264 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8265 Remove unused functions.
cdf4ba58
PE
8266 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8267 (x_calc_absolute_position): Now static.
7411c686 8268 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8269 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8270 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8271 unless they are used.
38d0b34a
PE
8272 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8273 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8274 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8275 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8276 (x_error_catcher, x_connection_closed, x_error_handler):
8277 (x_error_quitter, xembed_send_message, x_iconify_frame):
8278 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8279 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8280 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8281
44f230aa
SM
8282 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8283 Rename or move locals to avoid shadowing.
6b463e58 8284 (tty_defined_color, merge_face_heights): Now static.
5967d051 8285 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8286 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8287 does not deduce is never used uninitialized.
73719eba
PE
8288 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8289 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8290
426994c3 8291 * terminal.c (store_terminal_param): Now static.
5489860b 8292
032f1620 8293 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8294 (set_frame_menubar): Remove unused local.
d4323972 8295 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8296 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8297 since they might point to immutable storage.
281585b0
PE
8298 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8299 since it's unused otherwise.
032f1620 8300
367c19e5 8301 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8302 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8303 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8304 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8305 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8306 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8307 does not deduce are never used uninitialized.
70739cbe 8308
07b48fa9
PE
8309 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8310
8868a238 8311 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8312 * window.c (window_loop, size_window):
8313 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8314
7e5cf297 8315 * window.c (display_buffer): Now static.
d6550a9f
PE
8316 (size_window): Mark variables that gcc -Wuninitialized
8317 does not deduce are never used uninitialized.
a586633d
PE
8318 * window.h (check_all_windows): New decl, to forestall
8319 gcc -Wmissing-prototypes diagnostic.
5b555da1 8320 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8321
f6095868
PE
8322 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8323 shadowing.
8324 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8325 Include <limits.h>.
8326 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8327 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8328 (load_charset_map): Mark variables that gcc -Wuninitialized
8329 does not deduce are never used uninitialized.
53df7c11 8330 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8331
f38b440c
PE
8332 * coding.c (coding_set_source, coding_set_destination):
8333 Use "else { /* comment */ }" rather than "else /* comment */;"
8334 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8335 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8336 a block, when the outer 'i' will do.
8337 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8338 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8339 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8340 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8341 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8342 Rename locals to avoid shadowing.
8343 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8344 * coding.c (emacs_mule_char, encode_invocation_designation):
8345 Now static, since they're not used elsewhere.
413bb2db 8346 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8347 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8348 (decode_coding_emacs_mule): Mark variables that gcc
8349 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8350 (detect_coding_iso_2022): Initialize a local variable that might
8351 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8352 this initialization is needed. (Bug#8211)
5f58e762
PE
8353 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8354 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8355 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8356 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8357 Remove unused macros.
f38b440c 8358
232b38b9 8359 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8360 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8361 * character.c (string_count_byte8): Likewise.
232b38b9 8362
fb90da1b
PE
8363 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8364 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8365
fb93dbc2
PE
8366 * chartab.c (copy_sub_char_table): Now static, since it's not used
8367 elsewhere.
5c156ace
PE
8368 (sub_char_table_ref_and_range, char_table_ref_and_range):
8369 Rename locals to avoid shadowing.
bbcd0949 8370 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8371
7d3b3862 8372 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8373 (BIDI_BOB): Remove unused macro.
7d3b3862 8374
6be7d3da
PE
8375 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8376 deduce are never used uninitialized.
c2ed9c8b 8377 * term.c (encode_terminal_code): Likewise.
6be7d3da 8378
75f8807f 8379 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8380
50938595
PE
8381 * tparam.h: New file.
8382 * term.c, tparam.h: Include it.
8383 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8384 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8385 Move these decls to tparam.h, and make them agree with what
8386 is actually in tparam.c. The previous trick of using incompatible
8387 decls in different modules does not conform to the C standard.
8388 All callers of tparam changed to use tparam's actual API.
8389 * tparam.c (tparam1, tparam, tgoto):
8390 Use const pointers where appropriate.
8391
fbceeba2
PE
8392 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8393 * cm.h (struct cm): Likewise.
8394 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8395 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8396 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8397 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8398 (turn_on_face, init_tty): Likewise.
8399 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8400
7f3f1250
PE
8401 * term.c (term_mouse_position): Rename local to avoid shadowing.
8402
e6ca6543
PE
8403 * alloc.c (mark_ttys): Move decl from here ...
8404 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8405
c40f8d15
AS
84062011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8407
8408 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8409
cfe0661d
JB
84102011-03-09 Juanma Barranquero <lekktu@gmail.com>
8411
8412 * search.c (compile_pattern_1): Remove argument regp, unused since
8413 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8414 (compile_pattern): Don't pass it.
8415
0afb4571
J
84162011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8417
8418 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8419 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8420 for ! HAVE_GTK3.
8421 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8422
8423 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8424
8425 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8426 gdk_window_get_screen, gdk_window_get_geometry,
8427 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8428 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8429 (xg_get_pixbuf_from_pixmap): New function.
8430 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8431 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8432 Call xg_get_pixbuf_from_pixmap instead of
8433 gdk_pixbuf_get_from_drawable.
8434 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8435 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8436 (xg_check_special_colors): Use GtkStyleContext and its functions
8437 for HAVE_GTK3.
8438 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8439 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8440 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8441 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8442 Call gtk_widget_get_preferred_size.
0afb4571
J
8443 (xg_frame_resized): gdk_window_get_geometry only takes 5
8444 parameters.
44f230aa
SM
8445 (xg_win_to_widget, xg_event_is_for_menubar):
8446 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8447 (xg_set_widget_bg): New function.
8448 (delete_cb): New function.
895009e1 8449 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8450 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8451 (xg_set_background_color): Call xg_set_widget_bg.
8452 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8453 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8454 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8455 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8456 if ! HAVE_GTK3.
8457 (update_frame_tool_bar): Call gtk_widget_hide.
8458 (xg_initialize): Use GDK_KEY_g.
8459
8460 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8461 if ! HAVE_GTK3
8462 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8463
8464 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8465 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8466 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8467
1c2cc4ef
JB
84682011-03-08 Juanma Barranquero <lekktu@gmail.com>
8469
8470 * w32xfns.c (select_palette): Check success of RealizePalette against
8471 GDI_ERROR, not zero.
8472
33383987 8473See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8474
8475;; Local Variables:
8476;; coding: utf-8
aac0c6e3
MR
8477;; End:
8478
33383987 8479 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8480
8481 This file is part of GNU Emacs.
8482
8483 GNU Emacs is free software: you can redistribute it and/or modify
8484 it under the terms of the GNU General Public License as published by
8485 the Free Software Foundation, either version 3 of the License, or
8486 (at your option) any later version.
8487
8488 GNU Emacs is distributed in the hope that it will be useful,
8489 but WITHOUT ANY WARRANTY; without even the implied warranty of
8490 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8491 GNU General Public License for more details.
8492
8493 You should have received a copy of the GNU General Public License
8494 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.