* xfns.c (x_window): Rename locals to avoid shadowing.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
436c16df 3 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4 (x_window): Rename locals to avoid shadowing.
436c16df 5
92bb796d 6 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7 (x_term_init): Remove local to avoid shadowing.
92bb796d 8
764430a3 9 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10
11 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13
4170f62f 142011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 15
71b41406
PE
16 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
17
9587a89d
PE
18 emacs_write: Accept and return EMACS_INT for sizes.
19 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
20 et seq.
21 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
22 Accept and return EMACS_INT.
23 (emacs_gnutls_write): Return the number of bytes written on
24 partial writes.
25 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
26 (emacs_read, emacs_write): Remove check for negative size, as the
27 Emacs source code has been audited now.
9587a89d
PE
28 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
29 (emacs_read, emacs_write): Use it.
273a5f82
PE
30 * process.c (send_process): Adjust to the new signatures of
31 emacs_write and emacs_gnutls_write. Do not attempt to store
32 a byte offset into an 'int'; it might overflow.
9587a89d 33 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 34
3e047f51
PE
35 * sound.c: Don't assume sizes fit in 'int'.
36 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 37 Return EMACS_INT, not int.
3e047f51 38 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
39 Accept EMACS_INT, not int.
40 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
41 record read return values.
42
cc39a9db
BK
432011-04-15 Ben Key <bkey76@gmail.com>
44
45 * keyboard.c (Qundefined): Don't declare static since it is
46 used in nsfns.m.
47 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
48 declare static since they are used in nsfont.m.
49
6c60eb9f
SM
502011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
51
52 * process.c (Qprocessp): Don't declare static.
53 * lisp.h (Qprocessp): Declare again.
54
7990b61a
JB
552011-04-15 Juanma Barranquero <lekktu@gmail.com>
56
57 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
58
5d4cb038
PE
592011-04-14 Paul Eggert <eggert@cs.ucla.edu>
60
8bd7b830 61 Improve C-level modularity by making more things 'static'.
cd64ea1d 62
e3b27b31
PE
63 Don't publish debugger-only interfaces to other modules.
64 * lisp.h (safe_debug_print, debug_output_compilation_hack):
65 (verify_bytepos, count_markers): Move decls to the only modules
66 that need them.
67 * region-cache.h (pp_cache): Likewise.
68 * window.h (check_all_windows): Likewise.
69 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
70
5d4cb038
PE
71 * sysdep.c (croak): Now static, if
72 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
73 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
74
75 * alloc.c (refill_memory_reserve): Now static if
76 !defined REL_ALLOC || defined SYSTEM_MALLOC.
77 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 78
e87b6180
PE
79 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
80 Define only if USE_LUCID.
81
ac64929e
PE
82 * xrdb.c (x_customization_string, x_rm_string): Now static.
83
6f37259d
PE
84 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
85 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
86
1683e3ab
PE
87 * xdisp.c (draw_row_with_mouse_face): Now static.
88 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
89
de9c2632
PE
90 * window.h (check_all_windows): Mark externally visible.
91
2b96acb7
PE
92 * window.c (window_deletion_count): Now static.
93
94 * undo.c: Make symbols static if they're not exported.
95 (last_undo_buffer, last_boundary_position, pending_boundary):
96 Now static.
97
50436f33
PE
98 * textprop.c (interval_insert_behind_hooks): Now static.
99 (interval_insert_in_front_hooks): Likewise.
100
64520e5c
PE
101 * term.c: Make symbols static if they're not exported.
102 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
103 (max_frame_lines, tty_set_terminal_modes):
104 (tty_reset_terminal_modes, tty_turn_off_highlight):
105 (get_tty_terminal): Now static.
106 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
107 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 108 HAVE_WINDOW_SYSTEM.
64520e5c
PE
109 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
110 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
111
1fa53021
PE
112 * sysdep.c: Make symbols static if they're not exported.
113 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
114 Now static.
115 (sigprocmask_set, full_mask): Remove; unused.
116 (wait_debugging): Mark as visible.
117 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
118 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
119
d4b43b22
PE
120 * syntax.c (syntax_temp): Define only if !__GNUC__.
121
b7c513d0
PE
122 * sound.c (current_sound_device, current_sound): Now static.
123
989b29ad
PE
124 * search.c (searchbufs, searchbuf_head): Now static.
125
13a55a78
PE
126 * scroll.c (scroll_cost): Remove; unused.
127 * dispextern.h (scroll_cost): Remove decl.
128
de68a1fc
PE
129 * region-cache.h (pp_cache): Mark as externally visible.
130
40ccffa6
PE
131 * process.c: Make symbols static if they're not exported.
132 (process_tick, update_tick, create_process, chan_process):
133 (Vprocess_alist, proc_buffered_char, datagram_access):
134 (fd_callback_data, send_process_frame, process_sent_to): Now static.
135 (deactivate_process): Mark defn as static, as well as decl.
136 * lisp.h (create_process): Remove decl.
137 * process.h (chan_process, Vprocess_alist): Remove decls.
138
ad64fc97
PE
139 * print.c: Make symbols static if they're not exported.
140 (print_depth, new_backquote_output, being_printed, print_buffer):
141 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
142 (print_interval, print_number_index, initial_stderr_stream):
143 Now static.
144 * lisp.h (Fprinc): Remove decl.
145 (debug_output_compilation_hack): Mark as externally visible.
146
adddb265
PE
147 * sysdep.c (croak): Move decl from here to syssignal.h.
148 * syssignal.h (croak): Put it here, so the API can be checked when
149 'croak' is called from dissociate_if_controlling_tty.
150
1717ede2
PE
151 * minibuf.c: Make symbols static if they're not exported.
152 (minibuf_save_list, choose_minibuf_frame): Now static.
153 * lisp.h (choose_minibuf_frame): Remove decl.
154
fa5fb2bc
PE
155 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
156
1e3890d1
PE
157 * lread.c: Make symbols static if they're not exported.
158 (read_objects, initial_obarray, oblookup_last_bucket_number):
159 Now static.
160 (make_symbol): Remove; unused.
161 * lisp.h (initial_obarray, make_symbol): Remove decls.
162
8a1414fa
PE
163 * keyboard.c: Make symbols static if they're not exported.
164 (single_kboard, recent_keys_index, total_keys, recent_keys):
165 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
166 (this_single_command_key_start, echoing, last_auto_save):
167 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
168 (command_loop, echo_now, keyboard_init_hook, help_char_p):
169 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
170 (Vlispy_mouse_stem, double_click_count):
171 Now static.
172 (force_auto_save_soon): Define only if SIGDANGER.
173 (ignore_mouse_drag_p): Now static if
174 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
175 (print_help): Remove; unused.
176 (stop_character, last_timer_event): Mark as externally visible.
177 * keyboard.h (ignore_mouse_drag_p): Declare only if
178 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
179 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
180 * lisp.h (echoing): Remove decl.
181 (force_auto_save_soon): Declare only if SIGDANGER.
182 * xdisp.c (redisplay_window): Simplify code, to make it more
183 obvious that ignore_mouse_drag_p is not accessed if !defined
184 USE_GTK && !defined HAVE_NS.
185
93ea6e8f
PE
186 * intervals.c: Make symbols static if they're not exported.
187 (merge_properties_sticky, merge_interval_right, delete_interval):
188 Now static.
189 * intervals.h (merge_interval_right, delete_interval): Remove decls.
190
77382fcc
PE
191 * insdel.c: Make symbols static if they're not exported.
192 However, leave prepare_to_modify_buffer alone. It's never
193 called from outside this function, but that appears to be a bug.
194 (combine_after_change_list, combine_after_change_buffer):
4889fc82 195 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
196 (adjust_after_replace_noundo): Remove; unused.
197 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 198 (signal_before_change): Remove decls.
77382fcc 199
9306c32e
PE
200 * indent.c (val_compute_motion, val_vmotion): Now static.
201
cd44d2eb
PE
202 * image.c: Make symbols static if they're not exported.
203 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
204 if USE_GTK.
205 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
206 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
207
ad9a7a06
PE
208 * fringe.c (standard_bitmaps): Now static.
209 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
210
81626931
PE
211 * frame.c: Make symbols static if they're not exported.
212 (x_report_frame_params, make_terminal_frame): Now static.
213 (get_frame_param): Now static, unless HAVE_NS.
214 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
215 (x_get_resource_string): Remove; not used.
216 * frame.h (make_terminal_frame, x_report_frame_params):
217 (x_get_resource_string); Remove decls.
218 (x_fullscreen_adjust): Declare only if WINDOWSNT.
219 * lisp.h (get_frame_param): Declare only if HAVE_NS.
220
239f9db9
PE
221 * font.c, fontset.c: Make symbols static if they're not exported.
222 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
223 (FACE_SUITABLE_FOR_CHAR_P): Use it.
224 * font.c (font_close_object): Now static.
225 * font.h (font_close_object): Remove.
226 * fontset.c (FONTSET_OBJLIST): Remove.
227 (free_realized_fontset) #if-0 the body, which does nothing.
228 (face_suitable_for_char_p): #if-0, as it's never called.
229 * fontset.h (face_suitable_for_char_p): Remove decl.
230 * xfaces.c (face_at_string_position): Use
231 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
232 since 0 is always ASCII.
233
dfcf3579
PE
234 * fns.c (weak_hash_tables): Now static.
235
5045092b
PE
236 * fileio.c: Make symbols static if they're not exported.
237 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
238 (Vwrite_region_annotation_buffers): Now static.
239
57a96f5c
PE
240 * eval.c: Make symbols static if they're not exported.
241 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
242 * lisp.h (backtrace_list): Remove decl.
243
35f08c38
PE
244 * emacs.c: Make symbols static if they're not exported.
245 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
246 (fatal_error_code, fatal_error_signal_hook, standard_args):
247 Now static.
248 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
249 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
250 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
251 * lisp.h (fatal_error_signal_hook): Remove decl.
252 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
253
f44bd759
PE
254 * editfns.c: Move a (normally-unused) function to its only use.
255 * editfns.c, lisp.h (get_operating_system_release): Remove.
256 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
257 worth the hassle of breaking this out.
258
b532497d
PE
259 * xterm.c: Make symbols static if they're not exported.
260 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
261 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
262 (x_destroy_window, x_delete_display):
263 Now static.
264 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
265 (x_mouse_leave): Remove; unused.
266 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
267 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
268 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
269 Remove decls.
270 (x_mouse_leave): Declare only if WINDOWSNT.
271 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
272 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
273 USE_X_TOOLKIT.
274
1675728f
PE
275 * ftxfont.c: Make symbols static if they're not exported.
276 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
277 HAVE_FREETYPE.
278 * font.h (ftxfont_driver): Likewise.
279
e4cebfca
PE
280 * xfns.c: Make symbols static if they're not exported.
281 (x_last_font_name, x_display_info_for_name):
282 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
283 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
284 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
285 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
286 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
287 (last_show_tip_args): Now static.
288 (xic_defaut_fontset, xic_create_fontsetname): Define only if
289 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
290 (x_screen_planes): Remove; unused.
291 * dispextern.h (x_screen_planes): Remove decl.
292
5bf46f05
PE
293 * dispnew.c: Make symbols static if they're not exported.
294 * dispextern.h (redraw_garbaged_frames, scrolling):
295 (increment_row_positions): Remove.
296 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
297 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
298 Now static.
299 (redraw_garbaged_frames): Remove; unused.
300
435f4c28
PE
301 * xfaces.c: Make symbols static if they're not exported.
302 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
303 Remove decls.
304 * xterm.h (defined_color): Remove decls.
305 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
306 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
307 (menu_face_changed_default, defined_color, free_realized_face):
308 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
309 (ascii_face_of_lisp_face): Remove; unused.
310
8524aef3
PE
311 * xdisp.c: Make symbols static if they're not exported.
312 * dispextern.h (scratch_glyph_row, window_box_edges):
313 (glyph_to_pixel_coords, set_cursor_from_row):
314 (get_next_display_element, set_iterator_to_next):
315 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
316 (show_mouse_face): Remove decls
317 * frame.h (message_buf_print): Likewise.
318 * lisp.h (pop_message, set_message, check_point_in_composition):
319 Likewise.
320 * xterm.h (set_vertical_scroll_bar): Likewise.
321 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
322 (message_buf_print, scratch_glyph_row, displayed_buffer):
323 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
324 (get_next_display_element, show_mouse_face, window_box_edges):
325 (frame_to_window_pixel_xy, check_point_in_composition):
326 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
327 (glyph_to_pixel_coords): Remove; unused.
328
16390cd2
PE
329 * dired.c (file_name_completion): Now static.
330
331 * dbusbind.c (xd_in_read_queued_messages): Now static.
332
a25f4dfa
PE
333 * lisp.h (circular_list_error, FOREACH): Remove; unused.
334 * data.c (circular_list_error): Remove.
335
14a9c8df
PE
336 * commands.h (last_point_position, last_point_position_buffer):
337 (last_point_position_window): Remove decls.
338 * keyboard.c: Make these variables static.
339
74ab6df5
PE
340 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
341 decls.
342 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
343 (iso_code_class, detect_coding, code_convert_region): Now static.
344 (encode_coding_gap): Remove; unused.
345
38dfbee1
PE
346 * chartab.c (chartab_chars, chartab_bits): Now static.
347
a2cb4e63
PE
348 * charset.h (charset_iso_8859_1): Remove decl.
349 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
350 Now static.
351
127198fd
PE
352 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
353 * ccl.c (Vccl_program_table): Now static.
354 (check_ccl_update): Remove; unused.
355
d85b608f
PE
356 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
357 * category.h: ... from here.
358 * category.c (check_category_table, set_category_set): Now static.
359
31cd66f3
PE
360 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
361 * lisp.h: Remove these decls.
362
c358e587
PE
363 * buffer.c (buffer_count): Remove unused var.
364
e78aecca
PE
365 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
366 so that it's not optimized away.
367 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
368 * dispextern.h (bidi_dump_cached_states): Remove, since it's
369 exported only to the debugger.
370
e192d7d3
PE
371 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
372 * atimer.h (run_all_atimers): Removed; not exported.
373
92470028
PE
374 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
375 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
376 was inaccessible from Lisp.
377 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
378 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
379
244ed907
PE
380 alloc.c: Import and export fewer symbols, and remove unused items.
381 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
382 is defined.
383 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
384 it's not optimized away by whole-program optimization.
385 (message_enable_multibyte, free_misc): Remove.
386 (catchlist, handlerlist, mark_backtrace):
387 Declare only if BYTE_MARK_STACK.
388 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
389 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
390 (message_enable_multibyte): Remove decl.
391 (free_misc, interval_free_list, float_block, float_block_index):
392 (n_float_blocks, float_free_list, cons_block, cons_block_index):
393 (cons_free_list, last_marked_index):
394 Now static.
395 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
396 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
397 (mark_backtrace): Define only if BYTE_MARK_STACK.
398 * xdisp.c (message_enable_multibyte): Now static.
399
955cbe7b
PE
400 Declare Lisp_Object Q* variables to be 'static' if not exproted.
401 This makes it easier for human readers (and static analyzers)
402 to see whether these variables are used from other modules.
403 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
404 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
405 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
406 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
407 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
408 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
409 * xmenu.c, xselect.c:
410 Declare Q* vars static if they are not used in other modules.
411 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
412 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
413 Remove decls of unexported vars.
414 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
415
95c82688
PE
416 * lisp.h (DEFINE_FUNC): Make sname 'static'.
417
16a97296
PE
418 Make Emacs functions such as Fatom 'static' by default.
419 This makes it easier for human readers (and static analyzers)
420 to see whether these functions can be called from other modules.
421 DEFUN now defines a static function. To make the function external
422 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
423 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
424 (Finit_image_library):
16a97296
PE
425 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
426 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
427 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
428 Remove decls, since these functions are now static.
429 (Funintern, Fget_internal_run_time): New decls, since these functions
430 were already external.
95c82688 431
16a97296
PE
432 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
433 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
434 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
435 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
436 * keyboard.c, keymap.c, lread.c:
437 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
438 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
439 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
440 Mark functions with DEFUE instead of DEFUN,
441 if they are used in other modules.
442 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
443 decls for now-static functions.
444 * buffer.h (Fdelete_overlay): Remove decl.
445 * callproc.c (Fgetenv_internal): Mark as internal.
446 * composite.c (Fremove_list_of_text_properties): Remove decl.
447 (Fcomposition_get_gstring): New forward static decl.
448 * composite.h (Fcomposite_get_gstring): Remove decl.
449 * dired.c (Ffile_attributes): New forward static decl.
450 * doc.c (Fdocumntation_property): New forward static decl.
451 * eval.c (Ffetch_bytecode): New forward static decl.
452 (Funintern): Remove extern decl; now in .h file where it belongs.
453 * fileio.c (Fmake_symbolic_link): New forward static decl.
454 * image.c (Finit_image_library): New forward static decl.
455 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
456 * intervals.h (Fprevious_property_change):
457 (Fremove_list_of_text_properties): Remove decls.
458 * keyboard.c (Fthis_command_keys): Remove decl.
459 (Fcommand_execute): New forward static decl.
460 * keymap.c (Flookup_key): New forward static decl.
461 (Fcopy_keymap): Now static.
462 * keymap.h (Flookup_key): Remove decl.
463 * process.c (Fget_process): New forward static decl.
464 (Fprocess_datagram_address): Mark as internal.
465 * syntax.c (Fsyntax_table_p): New forward static decl.
466 (skip_chars): Remove duplicate decl.
467 * textprop.c (Fprevious_property_change): New forward static decl.
468 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
469 Now internal.
470 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
471 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
472
785bbd42
PE
473 * editfns.c (Fformat): Remove unreachable code.
474
8b913b57
AS
4752011-04-14 Andreas Schwab <schwab@linux-m68k.org>
476
477 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
478 change. (Bug#8496)
479
a6744a35
EZ
4802011-04-13 Eli Zaretskii <eliz@gnu.org>
481
482 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
483 when at ZV. (Bug#8487)
484
e7974947
AS
4852011-04-12 Andreas Schwab <schwab@linux-m68k.org>
486
baad03f0
AS
487 * charset.c (Fclear_charset_maps): Use xfree instead of free.
488 (Bug#8437)
489 * keyboard.c (parse_tool_bar_item): Likewise.
490 * sound.c (sound_cleanup, alsa_close): Likewise.
491 * termcap.c (tgetent): Likewise.
492 * xfns.c (x_default_font_parameter): Likewise.
493 * xsettings.c (read_and_apply_settings): Likewise.
494
e7974947
AS
495 * alloc.c (overrun_check_malloc, overrun_check_realloc)
496 (overrun_check_free): Protoize.
497
28272684
PE
4982011-04-12 Paul Eggert <eggert@cs.ucla.edu>
499
500 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
501 since callers should never pass a negative size.
502 Change the signature to match that of plain 'read' and 'write'; see
503 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
504 * lisp.h: Update prototypes of emacs_write and emacs_read.
505
11997c76
EZ
5062011-04-11 Eli Zaretskii <eliz@gnu.org>
507
508 * xdisp.c (redisplay_window): Don't try to determine the character
509 position of the scroll margin if the window start point w->startp
e896f03c 510 is outside the buffer's accessible region. (Bug#8468)
11997c76 511
8a2cbd72
EZ
5122011-04-10 Eli Zaretskii <eliz@gnu.org>
513
514 Fix write-region and its subroutines for buffers > 2GB.
515 * fileio.c (a_write, e_write): Modify declaration of arguments and
516 local variables to support buffers larger than 2GB.
517 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
518
519 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
520 argument, local variables, and return value.
521
522 * lisp.h: Update prototypes of emacs_write and emacs_read.
523
524 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
525
4073e537 5262011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 527
1ebfdcb6
PE
528 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
529
b2ded58d
PE
530 Fix more problems found by GCC 4.6.0's static checks.
531
7d66342c
PE
532 * xdisp.c (vmessage): Use a better test for character truncation.
533
bbf47d44
PE
534 * charset.c (load_charset_map): <, not <=, for optimization,
535 and to avoid potential problems with integer overflow.
9248994d 536 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 537 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 538 * editfns.c (Fformat): Likewise.
1e69125e 539 * syntax.c (skip_chars): Likewise.
3befa583 540
e3019616
PE
541 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
542 This also lets GCC 4.6.0 generate slightly better loop code.
543
becfa255
PE
544 * callint.c (Fcall_interactively): <, not <=, for optimization.
545 (Fcall_interactively): Count the number of arguments produced,
546 not the number of arguments given. This is simpler and lets GCC
547 4.6.0 generate slightly better code.
548
dae0cd48
PE
549 * ftfont.c: Distingish more carefully between FcChar8 and char.
550 The previous code passed unsigned char * to a functions like
551 strlen and xstrcasecmp that expect char *, which does not
552 conform to the C standard.
553 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
554 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
555 char * when the C standard requires it.
556
76032d70
PE
557 * keyboard.c (read_char): Remove unused var.
558
eb3f1cc8
PE
559 * eval.c: Port to Windows vsnprintf (Bug#8435).
560 Include <limits.h>.
561 (SIZE_MAX): Define if the headers do not.
562 (verror): Do not give up if vsnprintf returns a negative count.
563 Instead, grow the buffer. This ports to Windows vsnprintf, which
564 does not conform to C99. Problem reported by Eli Zaretskii.
565 Also, simplify the allocation scheme, by avoiding the need for
566 calling realloc, and removing the ALLOCATED variable.
567
70476b54
PE
568 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
569
12020a9e
PE
570 Remove invocations of doprnt, as Emacs now uses vsnprintf.
571 But keep the doprint source code for now, as we might revamp it
572 and use it again (Bug#8435).
ea6c7ae6
PE
573 * lisp.h (doprnt): Remove.
574 * Makefile.in (base_obj): Remove doprnt.o.
575 * deps.mk (doprnt.o): Remove.
576
5fdb398c
PE
577 error: Print 32- and 64-bit integers portably (Bug#8435).
578 Without this change, on typical 64-bit hosts error ("...%d...", N)
579 was used to print both 32- and 64-bit integers N, which relied on
580 undefined behavior.
581 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
582 New macro.
583 * lisp.h (error, verror): Mark as printf-like functions.
584 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
585 Report overflow in size calculations when allocating printf buffer.
586 Do not truncate output string at its first null byte.
587 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
588 Truncate the output at a character boundary, since vsnprintf does not
589 do that.
590 * charset.c (check_iso_charset_parameter): Convert internal
591 character to string before calling 'error', since %c now has the
592 printf meaning.
593 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
594 overflow when computing char to be passed to 'error'. Do not
595 pass Lisp_Object to 'error'; pass the integer instead.
596 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
597 formatted with plain %d.
598
b189fa66
PE
599 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
600
bff87ef0
PE
601 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
602
7e2cac20
PE
603 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
604
ce4d90b5
PE
605 * xterm.c (x_catch_errors): Remove duplicate declaration.
606
266c9547
PE
607 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
608
79c49ad2
PE
609 * xdisp.c, lisp.h (message_nolog): Remove; unused.
610
368f4090
JM
6112011-04-10 Jim Meyering <meyering@redhat.com>
612
613 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
614 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
615 return ssize_t not "int", and use size_t as the buffer length.
616 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
617 * gnutls.h: Update declarations.
618 * process.c (read_process_output): Use ssize_t, to match.
619 (send_process): Likewise.
620
a32d4040
CY
6212011-04-09 Chong Yidong <cyd@stupidchicken.com>
622
623 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
624
8546720e 6252011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 626
8546720e
GM
627 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
628 unsigned char, to match FcChar8 type definition.
aac0c6e3 629
8546720e
GM
630 * xterm.c (handle_one_xevent):
631 * xmenu.c (create_and_show_popup_menu):
632 * xselect.c (x_decline_selection_request)
633 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 634
0a2f5c1a 6352011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
636
637 Fix some uses of `int' instead of EMACS_INT.
638 * search.c (string_match_1, fast_string_match)
639 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
640 (scan_buffer, find_next_newline_no_quit)
641 (find_before_next_newline, search_command, Freplace_match)
642 (Fmatch_data): Make some `int' variables be EMACS_INT.
643
644 * xdisp.c (display_count_lines): 3rd argument and return value now
645 EMACS_INT. All callers changed.
646 (pint2hrstr): Last argument is now EMACS_INT.
647
648 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
649 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
650 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
651 (decode_coding_utf_16, decode_coding_emacs_mule)
652 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
653 (decode_coding_ccl, decode_coding_charset)
654 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
655 (decode_coding_iso_2022, decode_coding_emacs_mule)
656 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
657 <char_offset, last_offset>: Declare EMACS_INT.
658 (encode_coding_utf_8, encode_coding_utf_16)
659 (encode_coding_emacs_mule, encode_invocation_designation)
660 (encode_designation_at_bol, encode_coding_iso_2022)
661 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
662 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
663 Declare EMACS_INT.
664 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
665 (encode_invocation_designation): Last argument P_NCHARS is now
666 EMACS_INT.
667 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
668 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
669
670 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
671 All users changed.
672
673 * ccl.c (Fccl_execute_on_string): Declare some variables
674 EMACS_INT.
675
8546720e 6762011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
677
678 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
679
4e19a977
CS
6802011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
681
682 * process.c (Fformat_network_address): Doc fix.
683
87302331
R
6842011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
685
686 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
687
cbb59342
CY
6882011-04-08 Chong Yidong <cyd@stupidchicken.com>
689
690 * keyboard.c (read_char): Call Lisp function help-form-show,
691 instead of using internal_with_output_to_temp_buffer.
692 (Qhelp_form_show): New var.
e0d38eeb 693 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
694
695 * print.c (internal_with_output_to_temp_buffer): Function deleted.
696
697 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
698
e67a13ab
CY
6992011-04-06 Chong Yidong <cyd@stupidchicken.com>
700
701 * process.c (Flist_processes): Removed to Lisp.
702 (list_processes_1): Deleted.
703
973f782d
EZ
7042011-04-06 Eli Zaretskii <eliz@gnu.org>
705
7c106b1e
EZ
706 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
707
973f782d
EZ
708 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
709
41cf7d1a 7102011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 711
ca23cc88
PE
712 Fix more problems found by GCC 4.6.0's static checks.
713
f390e2d5
PE
714 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
715
42eea0d0
PE
716 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
717
b69769da 718 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 719
f9541e84
PE
720 * xdisp.c (vmessage): Mark as a printf-like function.
721
13841b55
PE
722 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
723
c136c10f
PE
724 * sound.c (sound_warning): Don't crash if arg contains a printf format.
725
5e2d4a30
PE
726 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
727 printf-like functions.
728 (tiff_load): Add casts to remove these marks before passing them
729 to system-supplied API.
730
583f48b9
PE
731 * eval.c (Fsignal): Remove excess argument to 'fatal'.
732
b25d760e
PE
733 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
734 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
735 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
736 directly, rather than having caller test rule sign. This avoids
737 some unnecessary tests.
738 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
739 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
740 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 741
bc7b6697 742 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 743 (xfont_open): Avoid unnecessary tests.
bc7b6697 744
27ccc379
PE
745 * composite.c (composition_gstring_put_cache): Use unsigned integer.
746
dcd5c89a
PE
747 * composite.h, composite.c (composition_gstring_put_cache):
748 Use EMACS_INT, not int, for length.
749
b13a45c6
PE
750 * composite.h (COMPOSITION_DECODE_REFS): New macro,
751 breaking out part of COMPOSITION_DECODE_RULE.
752 (COMPOSITION_DECODE_RULE): Use it.
753 * composite.c (get_composition_id): Remove unused local vars,
754 by using the new macro.
755
1e792e4d
PE
756 * textprop.c (set_text_properties_1): Change while to do-while,
757 since the condition is always true at first.
758
dc6c6455 759 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
760 (interval_deletion_adjustment): Return unsigned value.
761 All uses changed.
dc6c6455 762
aba7731a
PE
763 * process.c (list_processes_1, create_pty, read_process_output):
764 (exec_sentinel): Remove vars that were set but not used.
afd4052b 765 (create_pty): Remove unnecessary "volatile"s.
bc57d757 766 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 767 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 768 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 769
fdfc4bf3
PE
770 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
771
fca8fe46 772 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 773 (update_syntax_table): Use unsigned instead of int.
fca8fe46 774
06a0259a 775 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 776 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 777 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 778
e7b9e80f
PE
779 * print.c (print_error_message): Avoid int overflow.
780
56201685
PE
781 * font.c (font_list_entities): Redo for clarity,
782 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
783
78834453 784 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 785 (font_score): Avoid potential overflow in diff calculation.
78834453 786
0bc0b309 787 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 788 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 789
e610eaca
PE
790 * eval.c (funcall_lambda): Rename local to avoid shadowing.
791
b895abce
PE
792 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
793 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
794 can always succeed if overflow has undefined behavior.
795
1f1d9321 796 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 797 (wordify): Omit three unnecessary tests.
1f1d9321 798
c59478bc
PE
799 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
800 All callers changed. This avoids the need for an unused var.
801
79b73827
PE
802 * casefiddle.c (casify_region): Remove var that is set but not used.
803
a4db5dfe
PE
804 * dired.c (file_name_completion): Remove var that is set but not used.
805
43aae36e
PE
806 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
807
2a47c44d 808 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 809 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 810
a37c69bf
PE
811 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
812 Check for integer overflow on size calculations.
813
328ab8e7
PE
814 * buffer.c (Fprevious_overlay_change): Remove var that is set
815 but not used.
816
e5a2a5cb
PE
817 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
818 Remove vars that are set but not used.
8d84a6eb 819 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 820 (timer_check_2): Mark vars as initialized.
e5a2a5cb 821
a60e5f68
PE
822 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
823
f661cb61 824 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 825 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 826
f0397f5a
PE
827 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
828 that are set but not used.
829
8664db06 830 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 831 if XCreateBitmapFromData fails (Bug#8410).
8664db06 832
6abdaa4a
PE
833 * xselect.c (x_get_local_selection, x_handle_property_notify):
834 Remove vars that are set but not used.
835
0ce7538d 836 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 837 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 838
9ae848fc
PE
839 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
840 Remove var that is set but not used.
0b918413
PE
841 (scroll_bar_windows_size): Now size_t, not int.
842 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
843 Check for overflow.
9ae848fc 844
a5a62657
PE
845 * xfaces.c (realize_named_face): Remove vars that are set but not used.
846 (map_tty_color) [!defined MSDOS]: Likewise.
847
5c5cdd39
PE
848 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
849
66ebf983
PE
850 * coding.c: Remove vars that are set but not used.
851 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
852 All callers changed.
853 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
854 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
855 (decode_coding_charset): Remove vars that are set but not used.
856
1be4d761
PE
857 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
858 that is set but not used.
859
47553fa8
PE
860 * print.c (print_object): Remove var that is set but not used.
861
1f7196bf 862 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
863 The gnulib version avoids calling malloc in the usual case,
864 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
865 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
866 * filelock.c (current_lock_owner): Likewise.
867 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
868 * sysdep.c: Include allocator.h, careadlinkat.h.
869 (emacs_no_realloc_allocator): New static constant.
870 (emacs_readlink): New function.
fdb61804
PE
871 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
872 ../lib/careadlinkat.h.
d1fdcab7 873
f84c17c7
SM
8742011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
875
876 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
877 first non-nil return value).
878
ef3862ad
JD
8792011-04-03 Jan Djärv <jan.h.d@swipnet.se>
880
881 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
882 if not defined (Bug#8403).
883
376a7006
JB
8842011-04-02 Juanma Barranquero <lekktu@gmail.com>
885
886 * xdisp.c (display_count_lines): Remove parameter `start',
887 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
888 (get_char_face_and_encoding): Remove parameter `multibyte_p',
889 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
890 (fill_stretch_glyph_string): Remove parameters `row' and `area',
891 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
892 and thereabouts. All callers changed.
893 (get_per_char_metric): Remove parameter `f', unused since
894 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
895
6ca3801d
JM
8962011-04-02 Jim Meyering <meyering@redhat.com>
897
898 do not dereference NULL upon failed strdup
899 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
900 (ns_get_family): Likewise.
901
d8e2b5ba
JB
9022011-04-02 Juanma Barranquero <lekktu@gmail.com>
903
904 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
905
8c74fcbd
JD
9062011-04-02 Jan Djärv <jan.h.d@swipnet.se>
907
908 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
909 later (Bug#8403).
910
7200d79c
SM
9112011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
912
03408648 913 Add lexical binding.
7200d79c 914
03408648
SM
915 * window.c (Ftemp_output_buffer_show): New fun.
916 (Fsave_window_excursion):
917 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
918
919 * lread.c (lisp_file_lexically_bound_p): New function.
920 (Fload): Bind Qlexical_binding.
921 (readevalloop): Remove `evalfun' arg.
922 Bind Qinternal_interpreter_environment.
923 (Feval_buffer): Bind Qlexical_binding.
924 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
925 Mark as dynamic.
926 (syms_of_lread): Declare `lexical-binding'.
927
928 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
929
930 * keyboard.c (eval_dyn): New fun.
931 (menu_item_eval_property): Use it.
ca105506
SM
932
933 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 934
03408648
SM
935 * fns.c (concat, mapcar1): Accept byte-code-functions.
936
937 * eval.c (Fsetq): Handle lexical vars.
938 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
939 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
940 (FletX, Flet): Obey lexical binding.
941 (Fcommandp): Handle closures.
942 (Feval): New `lexical' arg.
943 (eval_sub): New function extracted from Feval. Use it almost
944 everywhere where Feval was used. Look up vars in lexical env.
945 Handle closures.
946 (Ffunctionp): Move from subr.el.
947 (Ffuncall): Handle closures.
948 (apply_lambda): Remove `eval_flags'.
949 (funcall_lambda): Handle closures and new byte-code-functions.
950 (Fspecial_variable_p): New function.
951 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
952 but without exporting it to Lisp.
23aba0ea 953
23aba0ea 954 * doc.c (Fdocumentation, store_function_docstring):
03408648 955 * data.c (Finteractive_form): Handle closures.
23aba0ea 956
03408648
SM
957 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
958 interactive spec.
ba83908c 959
03408648
SM
960 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
961 byte-codes.
962 (exec_byte_code): New function extracted from Fbyte_code to handle new
963 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 964
03408648 965 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 966
03408648 967 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 968
e2abce01
JB
9692011-03-31 Juanma Barranquero <lekktu@gmail.com>
970
971 * xdisp.c (redisplay_internal): Fix prototype.
972
63696a73 9732011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 974
63696a73
EZ
975 * xdisp.c (SCROLL_LIMIT): New macro.
976 (try_scrolling): Use it when setting scroll_limit. Limit
977 scrolling to 100 screen lines.
978 (redisplay_window): Even when falling back on "recentering",
979 position point in the window according to scroll-conservatively,
980 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
981
982 (try_scrolling): When point is above the window, allow searching
983 as far as scroll_max, or one screenful, to compute vertical
984 distance from PT to the scroll margin position. This prevents
985 try_scrolling from unnecessarily failing when
986 scroll-conservatively is set to a value slightly larger than the
987 window height. Clean up the case of PT below the margin at bottom
988 of window: scroll_max can no longer be INT_MAX. When aggressive
989 scrolling is in use, don't let point enter the opposite scroll
990 margin as result of the scroll.
991 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
992 threshold of 100 lines for never-recentering scrolling.
993
e4cc2dfc
JB
9942011-03-31 Juanma Barranquero <lekktu@gmail.com>
995
996 * dispextern.h (move_it_by_lines):
997 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
998 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
999 (message_log_check_duplicate): Remove parameters `prev_bol' and
1000 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1001 (redisplay_internal): Remove parameter `preserve_echo_area',
1002 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1003
1004 * indent.c (Fvertical_motion):
1005 * window.c (window_scroll_pixel_based, Frecenter):
1006 Don't pass `need_y_p' to `move_it_by_lines'.
1007
1c470562
SM
10082011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1009
44f230aa
SM
1010 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1011 steal a few bits to be more compact.
1012 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1013 Remove unneeded casts.
1014
1c470562
SM
1015 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1016
888adce9
ZK
10172011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1018
1019 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1020 binding" message (bug#7967).
1021
f838ed7b
PE
10222011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1023
77861b95
PE
1024 Fix more problems found by GCC 4.6.0's static checks.
1025
de6dbc14
PE
1026 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1027 Remove unused local var.
1028
f838ed7b
PE
1029 * editfns.c (Fmessage_box): Remove unused local var.
1030
792c7b2b
PE
1031 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1032 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1033 Omit unused local vars.
c499e557 1034 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1035 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1036 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1037 Omit unused local var.
1038
ba0165e1
PE
1039 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1040 Don't assume string length fits in int.
32ad8845 1041 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1042 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1043
3c59b4c9
PE
1044 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1045 instead of alloca (Bug#8344).
1046
a3eed478 1047 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1048 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1049
eb4d412d
PE
1050 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1051
1658b401
PE
1052 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1053 concerns.
1054
1055 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1056
1057 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1058
9a2c6e05
PE
1059 * keyboard.c (syms_of_keyboard): Use the same style as later
1060 in this function when indexing through an array. This also
1061 works around GCC bug 48267.
1062
03d0a109
PE
1063 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1064
44f730c8
PE
1065 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1066
fe75f926
PE
1067 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1068 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1069
ffa8c828
PE
1070 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1071 This avoids undefined behavior on integer overflow, and is a bit
1072 more convenient anyway since it is compared to a size_t variable.
1073
c5101a77
PE
1074 Variadic C functions now count arguments with size_t, not int.
1075 This avoids an unnecessary limitation on 64-bit machines, which
1076 caused (substring ...) to crash on large vectors (Bug#8344).
1077 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1078 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1079 All variadic functions and their callers changed accordingly.
c5101a77
PE
1080 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1081 * data.c (arith_driver, float_arith_driver): Likewise.
1082 * editfns.c (general_insert_function): Likewise.
1083 * eval.c (struct backtrace.nargs, interactive_p)
1084 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1085 (funcall_lambda, mark_backtrace): Likewise.
1086 * fns.c (concat): Likewise.
1087 * frame.c (x_set_frame_parameters): Likewise.
1088 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1089 0 if not found, not -1. All callers changed.
1090
dd3f25f7
PE
1091 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1092 (stack_copy_size): Now size_t, not int.
1093 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1094
461c2ab9
JB
10952011-03-28 Juanma Barranquero <lekktu@gmail.com>
1096
1097 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1098 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1099 All callers changed.
1100
1101 * lisp.h (multibyte_char_to_unibyte):
1102 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1103 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1104 * character.h (CHAR_TO_BYTE8):
1105 * cmds.c (internal_self_insert):
1106 * editfns.c (general_insert_function):
1107 * keymap.c (push_key_description):
1108 * search.c (Freplace_match):
1109 * xdisp.c (message_dolog, set_message_1): All callers changed.
1110
f6d62986
SM
11112011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1112
1113 * keyboard.c (safe_run_hook_funcall): New function.
1114 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1115 don't set the hook to nil, but remove the offending function instead.
1116 (Qcommand_hook_internal): Remove, unused.
1117 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1118 Vcommand_hook_internal.
1119
1120 * eval.c (enum run_hooks_condition): Remove.
1121 (funcall_nil, funcall_not): New functions.
1122 (run_hook_with_args): Call each function through a `funcall' argument.
1123 Remove `cond' argument, now redundant.
1124 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1125 (Frun_hook_with_args_until_failure): Adjust accordingly.
1126 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1127
1db5b1ad
JB
11282011-03-28 Juanma Barranquero <lekktu@gmail.com>
1129
1130 * dispextern.h (string_buffer_position): Remove declaration.
1131
1132 * print.c (strout): Remove parameter `multibyte', unused since
1133 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1134
1135 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1136 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1137 All callers changed.
1138
1139 * w32.c (_wsa_errlist): Use braces for struct initializers.
1140
1141 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1142 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1143 All callers changed.
1144 (string_buffer_position): Likewise. Also, make static (it's never
1145 used outside xdisp.c).
1146 (cursor_row_p): Remove parameter `w', unused since
1147 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1148 (decode_mode_spec): Remove parameter `precision', introduced during
1149 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1150 All callers changed.
1151
5ffb62aa
JD
11522011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1153
1154 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1155
461c2ab9 11562011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1157
1158 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1159 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1160 (ns_update_auto_hide_menu_bar): New functions.
1161 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1162 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1163 ns_constrain_all_frames.
1164 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1165 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1166
5c380ffb
JD
11672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1168
1169 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1170
9af30bdf
GM
11712011-03-27 Glenn Morris <rgm@gnu.org>
1172
1173 * syssignal.h: Replace RETSIGTYPE with void.
1174 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1175 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1176 Replace SIGTYPE with void everywhere.
1177 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1178 * s/template.h (SIGTYPE): Remove commented out definition.
1179
e2abce01
JB
11802011-03-26 Eli Zaretskii <eliz@gnu.org>
1181
1182 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1183 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1184
f868cd8a
JB
11852011-03-26 Juanma Barranquero <lekktu@gmail.com>
1186
59eb0929
JB
1187 * w32.c (read_unc_volume): Use parameter `henum', instead of
1188 global variable `wget_enum_handle'.
1189
1190 * keymap.c (describe_vector): Remove parameters `indices' and
1191 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1192 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1193
f868cd8a
JB
1194 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1195
1196 * keyboard.c (timer_check): Remove parameter `do_it_now',
1197 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1198 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1199 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1200
1201 * keyboard.c (read_char):
1202 * w32menu.c (w32_menu_display_help):
1203 * xmenu.c (show_help_event, menu_help_callback):
1204 Adjust calls to `show_help_echo'.
1205
1206 * gtkutil.c (xg_maybe_add_timer):
1207 * keyboard.c (readable_events):
1208 * process.c (wait_reading_process_output):
1209 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1210
1211 * insdel.c (adjust_markers_gap_motion):
1212 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1213 (gap_left, gap_right): Don't call it.
1214
2ecf6fdb
CY
12152011-03-25 Chong Yidong <cyd@stupidchicken.com>
1216
1217 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1218 incurred during fontification.
1219
6b1f9ba4
JB
12202011-03-25 Juanma Barranquero <lekktu@gmail.com>
1221
1222 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1223 (DEFVAR_PER_BUFFER): Don't pass it.
1224
1225 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1226 (scrolling_window): Don't pass it.
1227
0f4a96b5
JB
12282011-03-25 Juanma Barranquero <lekktu@gmail.com>
1229
1230 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1231
1232 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1233 and `suffix'.
1234 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1235 of variables specific to SELinux and computation of `encoded_absname'.
1236
1237 * image.c (XPutPixel): Remove unused variable `height'.
1238
1239 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1240
1241 * unexw32.c (get_section_info): Remove unused variable `section'.
1242
1243 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1244 (system_process_attributes): Remove unused variable `sess'.
1245 (sys_read): Remove unused variable `err'.
1246
1247 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1248 (w32_wnd_proc): Remove unused variable `isdead'.
1249 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1250 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1251 (x_create_tip_frame): Remove unused variable `tem'.
1252
1253 * w32inevt.c (w32_console_read_socket):
1254 Remove unused variable `no_events'.
1255
1256 * w32term.c (x_draw_composite_glyph_string_foreground):
1257 Remove unused variable `width'.
1258
1149507c
JB
12592011-03-24 Juanma Barranquero <lekktu@gmail.com>
1260
1261 * w32term.c (x_set_glyph_string_clipping):
1262 Don't pass uninitialized region to CombineRgn.
1263
9c88f339
JB
12642011-03-23 Juanma Barranquero <lekktu@gmail.com>
1265
1266 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1267 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1268 (Fx_close_connection): Remove unused variable `i'.
1269
1270 * w32font.c (w32font_draw): Return number of glyphs.
1271 (w32font_open_internal): Remove unused variable `i'.
1272 (w32font_driver): Add missing initializer.
1273
1274 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1275 (fill_in_menu): Remove unused variable `items_added'.
1276
1277 * w32term.c (last_mouse_press_frame): Remove static global variable.
1278 (w32_clip_to_row): Remove unused variable `f'.
1279 (x_delete_terminal): Remove unused variable `i'.
1280
1281 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1282 (NOTHING): Remove unused static global variable.
1283 (uniscribe_check_otf): Remove unused variable `table'.
1284 (uniscribe_font_driver): Add missing initializers.
1285
dee091a3
JD
12862011-03-23 Julien Danjou <julien@danjou.info>
1287
1288 * term.c (Fsuspend_tty, Fresume_tty):
1289 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1290 * window.c (temp_output_buffer_show):
1291 * insdel.c (signal_before_change):
1292 * frame.c (Fhandle_switch_frame):
1293 * fileio.c (Fdo_auto_save):
1294 * emacs.c (Fkill_emacs):
1295 * editfns.c (save_excursion_restore):
1296 * cmds.c (internal_self_insert):
1297 * callint.c (Fcall_interactively):
1298 * buffer.c (Fkill_all_local_variables):
1299 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1300 Use Frun_hooks.
0f4a96b5 1301 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1302 unconditionnaly since it does the check itself.
1303
2c520ab5 13042011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1305
c9c49752
PE
1306 Fix more problems found by GCC 4.5.2's static checks.
1307
8abc3f12
PE
1308 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1309 the first time through the loop, since we know p0 < p1 then.
1310 This also avoids a gcc -Wstrict-overflow warning.
1311
a2d26660
PE
1312 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1313 leading to a memory leak, possible in functions like
1314 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1315 of objects (Bug#8318).
a2d26660 1316
916c72e9
PE
1317 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1318 that could (at least in theory) be that large.
1319
19ab8a18
PE
1320 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1321 This is less likely to overflow, and avoids undefined behavior if
1322 overflow does occur. All callers changed. Use strtoul to scan
1323 for the unsigned long integer.
b7cbbd6f
PE
1324 (pint2hrstr): Simplify and tune code slightly.
1325 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1326
f0641eff
PE
1327 * scroll.c (do_scrolling): Work around GCC bug 48228.
1328 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1329
7f650bb9
PE
1330 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1331 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1332 (validate_x_resource_name): Simplify count usage.
1333 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1334
37dd57d1
PE
1335 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1336 fail (Bug#8306).
81e56e61 1337
699979fc 1338 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1339
401bf9b4
PE
1340 * process.c (Fmake_network_process): Use socklen_t, not int,
1341 where POSIX says socklen_t is required in portable programs.
1342 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1343 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1344 (Fmake_network_process, server_accept_connection):
1345 (wait_reading_process_output, read_process_output):
1346 Likewise.
1347
b93aacde
PE
1348 * process.c: Rename or move locals to avoid shadowing.
1349 (list_processes_1, Fmake_network_process):
1350 (read_process_output_error_handler, exec_sentinel_error_handler):
1351 Rename or move locals.
4dc343ee 1352 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1353 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1354 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1355 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1356 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1357
af8a867c 1358 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1359 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1360 Include tparam.h instead, since it declares them.
af8a867c
PE
1361 * cm.h (PC): Remove extern decl; tparam.h now does this.
1362 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1363 * terminfo.c: Include tparam.h, to check interfaces.
1364 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1365 (tparam): Adjust signature to match interface in tparam.h;
1366 this removes some undefined behavior. Check that outstring and len
1367 are zero, which they always are with Emacs.
1368 * tparam.h (PC, BC, UP): New extern decls.
1369
0248044d 1370 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1371 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1372
8ff096c1 1373 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1374 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1375 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1376 (ftfont_list): Remove unused local.
49eaafba
PE
1377 (get_adstyle_property, ftfont_pattern_entity):
1378 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1379 Rename locals to avoid shadowing.
8ff096c1 1380
e2be39f6
PE
1381 * xfont.c (xfont_list_family): Mark var as initialized.
1382
c9735e30
PE
1383 * xml.c (make_dom): Now static.
1384
8f5201ae
PE
1385 * composite.c (composition_compute_stop_pos): Rename local to
1386 avoid shadowing.
b246f932
PE
1387 (composition_reseat_it): Remove unused locals.
1388 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1389 (composition_update_it): Mark var as initialized.
11b61122
PE
1390 (find_automatic_composition): Mark vars as initialized,
1391 with a FIXME (Bug#8290).
8f5201ae 1392
760fbc2c
PE
1393 character.h: Rename locals to avoid shadowing.
1394 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1395 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1396 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1397 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1398 to avoid shadowing.
1399
ff08eb85
PE
1400 * textprop.c (property_change_between_p): Remove; unused.
1401
fc7bf025
PE
1402 * intervals.c (interval_start_pos): Now static.
1403
235d7abc
PE
1404 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1405
44f230aa
SM
1406 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1407 Rename locals to avoid shadowing.
3e7d6594 1408
50060332
PE
1409 * sound.c (wav_play, au_play, Fplay_sound_internal):
1410 Fix pointer signedness.
d01f234b 1411 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1412 (wav_play): Initialize a variable to 0, to prevent undefined
1413 behavior (Bug#8278).
50060332 1414
c4fc4e30
PE
1415 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1416
918436ed
PE
1417 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1418
c939f91b
PE
1419 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1420 clobbering (Bug#8298).
b9c7f648
PE
1421 * sysdep.c (sys_subshell): Likewise.
1422 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1423
6bd8c144
PE
1424 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1425 This should get cleaned up, so that child_setup has the
1426 same signature on all platforms.
1427
7710357c 1428 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1429 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1430
c59da222
CY
14312011-03-22 Chong Yidong <cyd@stupidchicken.com>
1432
1433 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1434 not to be necessary, and produces flickering.
1435
66b87493
GM
14362011-03-20 Glenn Morris <rgm@gnu.org>
1437
1438 * config.in: Remove file.
1439
45b6f6d5
JB
14402011-03-20 Juanma Barranquero <lekktu@gmail.com>
1441
1442 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1443 are now in src/globals.h.
1444 (syms_of_minibuf): Remove spurious & from previous change.
1445
3ec03f7e
LL
14462011-03-20 Leo <sdl.web@gmail.com>
1447
1448 * minibuf.c (completing-read-function): New variable.
1449 (completing-read-default): Rename from completing-read.
1450 (completing-read): Call completing-read-function.
1451
b14e3e21
CY
14522011-03-19 Juanma Barranquero <lekktu@gmail.com>
1453
1454 * xfaces.c (Fx_load_color_file):
1455 Read color file from absolute filename (bug#8250).
1456
f2b726e6
JB
14572011-03-19 Juanma Barranquero <lekktu@gmail.com>
1458
1459 * makefile.w32-in: Update dependencies.
1460
09f6ff02
EZ
14612011-03-17 Eli Zaretskii <eliz@gnu.org>
1462
1463 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1464
29a6015a
PE
14652011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1466
a3a6c54e
PE
1467 Fix more problems found by GCC 4.5.2's static checks.
1468
b766f867
PE
1469 * process.c (make_serial_process_unwind, send_process_trap):
1470 (sigchld_handler): Now static.
1471
be02381c
PE
1472 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1473 That way, the code declares only the vars that it needs.
1474 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1475 * s/cygwin.h (PTY_ITERATION): Likewise.
1476 * s/darwin.h (PTY_ITERATION): Likewise.
1477 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1478
57048744
PE
1479 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1480 * process.c (allocate_pty): Don't declare stb unless it's needed.
1481
7914961c 1482 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1483 (CONSTANTLIM): Remove; unused.
1484 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1485 Define only if needed.
7914961c 1486
b3967b18
PE
1487 * unexelf.c (unexec): Name an expression,
1488 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1489 Use a different way to cause a compilation error if anyone uses
1490 n rather than nn, a way that does not involve shadowing.
73366a00 1491 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1492
29a6015a
PE
1493 * deps.mk (unexalpha.o): Remove; unused.
1494
43cfc33e 1495 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1496 * unexec.h: New file.
ce701a33
PE
1497 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1498 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1499 Depend on unexec.h.
1500 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1501 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1502 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1503 Change as necessary to match prototype in unexec.h.
ce701a33 1504
01f44d5a
PE
1505 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1506 shadowing.
4f63c6bb 1507 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1508
a6670b0b
PE
1509 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1510 Rename locals to avoid shadowing.
1511
cef2010d 1512 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1513 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1514
d4d7173a
PE
1515 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1516
f08b802a
PE
1517 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1518 warning when compiling print.c.
1519
3ddb0639
PE
1520 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1521 instead of using an uninitialized var.
5ad03b97 1522 (font_sort_entities): Mark var as initialized.
3ddb0639 1523
170a2692
PE
1524 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1525
e663c700
PE
1526 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1527 pointers to constants.
89bc529a 1528 (font_parse_fcname): Remove unused vars.
7b81e2d0 1529 (font_delete_unmatched): Now static.
ea838e10 1530 (font_get_spec): Remove; unused.
13a547c6
PE
1531 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1532 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1533 Rename or move locals to avoid shadowing.
e663c700 1534
2a80c887 1535 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1536 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1537
1384fa33 1538 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1539 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1540
8b2c52e9
PE
1541 * alloc.c (mark_backtrace): Move decl from here ...
1542 * lisp.h: ... to here, so that it can be checked.
1543
475545b5 1544 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1545 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1546 (lisp_indirect_variable): Name an expression,
1547 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1548 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1549
b1349114 1550 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1551 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1552 Use const pointer when appropriate.
b1349114 1553
a2928364
PE
1554 * lisp.h (get_system_name, get_operating_system_release):
1555 Move decls here, to check interfaces.
1556 * process.c (get_operating_system_release): Move decl to lisp.h.
1557 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1558 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1559 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1560 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1561 (Fformat_time_string, Fencode_time, Finsert_char):
1562 (Ftranslate_region_internal, Fformat):
1563 Rename or remove local vars to avoid shadowing.
9710023e 1564 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1565
a415e694
PE
1566 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1567 avoid shadowing.
1568
8ef4622d
PE
1569 * lisp.h (eassert): Check that the argument compiles, even if
1570 ENABLE_CHECKING is not defined.
1571
946f9a5b
PE
1572 * data.c (Findirect_variable): Name an expression, to avoid
1573 gcc -Wbad-function-cast warning.
112396d6 1574 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1575 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1576 (Fmake_variable_buffer_local, Fmake_local_variable):
1577 Mark variables as initialized.
52746918 1578 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1579
e5aab7e7 1580 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1581 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1582 Rename locals to avoid shadowing.
dff45157
PE
1583 (mark_stack): Move local variables into the #ifdef region where
1584 they're used.
7bc26fdb
PE
1585 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1586 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1587 needed otherwise.
1588 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1589 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1590 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1591
e5aab7e7
PE
1592 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1593 avoids undefined behavior in theory.
1594
4da60324
PE
1595 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1596
88043301
PE
1597 Use functions, not macros, for up- and down-casing (Bug#8254).
1598 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1599 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1600 to use the following functions instead of these macros.
1601 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1602 EMACS_INT, since callers assume the returned value fits in int.
1603 (upcase1): Likewise, for UPCASE_TABLE.
1604 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1605 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1606 the race-condition problem in the old DOWNCASE.
88043301 1607
19ed5445
PE
1608 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1609 Rename locals to avoid shadowing.
1610 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1611 (regex_compile, re_search_2, re_match_2_internal):
1612 Remove unused local vars.
952db0d7
PE
1613 (FREE_VAR): Rewrite so as not to use empty "else",
1614 which gcc can warn about.
da053e48 1615 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1616 (RETALLOC_IF): Define only if needed.
1617 (WORDCHAR_P): Likewise. This one is never needed, but is used
1618 only in a comment talking about a compiler bug, so put inside
1619 the #if 0 of that comment.
1620 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1621 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1622 Remove; unused.
19ed5445 1623
1f3561e4 1624 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1625 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1626 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1627
ded6f8f7
PE
1628 * search.c (simple_search): Remove unused var.
1629
dbd37a95
PE
1630 * dired.c (compile_pattern): Move decl from here ...
1631 * lisp.h: ... to here, so that it can be checked.
1632 (struct re_registers): New forward decl.
1633
7e47afad
PE
1634 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1635
85f24f61
PE
1636 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1637 All uses changed.
1638 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1639 Rename locals to avoid shadowing.
5671df8f 1640 (Fvertical_motion): Mark locals as initialized.
85f24f61 1641
181aa2be 1642 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1643 (casify_region): Mark local as initialized.
181aa2be 1644
930d429c
PE
1645 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1646
7082eac6
PE
1647 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1648 New macros, so that the caller can use some names other than
1649 gcpro1, gcpro2, etc.
1650 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1651 of the new macros.
1652 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1653 argument, for consistency with GCPRO2_VAR, etc: it is now the
1654 prefix of the variable, not the variable itself. All uses
1655 changed.
38b2c076
PE
1656 * dired.c (directory_files_internal, file_name_completion):
1657 Rename locals to avoid shadowing.
1658
15206ed9
PE
1659 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1660 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1661 dired.c's scmp function, had undefined behavior.
1662 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1663 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1664 * buffer.h: ... to here, because these macros use current_buffer,
1665 and the new implementation with inline functions needs to have
1666 current_buffer in scope now, rather than later when the macros
1667 are used.
1668 (downcase, upcase1): New static inline functions.
1669 (DOWNCASE, UPCASE1): Reimplement using these functions.
1670 This avoids undefined behavior in expressions like
1671 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1672 from race conditions in accessing the global variables
1673 case_temp1 and case_temp2.
1674 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1675 * lisp.h (case_temp1, case_temp2): Remove their decls.
1676 * character.h (ASCII_CHAR_P): Move from here ...
1677 * lisp.h: ... to here, so that the inline functions mentioned
1678 above can use them.
1679
4a6bea26
PE
1680 * dired.c (directory_files_internal_unwind): Now static.
1681
f14b7e14
PE
1682 * fileio.c (file_name_as_directory, directory_file_name):
1683 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1684 Now static.
2893f146
PE
1685 (file_name_as_directory): Use const pointers when appropriate.
1686 (Fexpand_file_name): Likewise. In particular, newdir might
1687 point at constant storage, so make it a const pointer.
fd4ead52 1688 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1689 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1690 signedness issues.
f839df0c
PE
1691 (Fset_file_times, Finsert_file_contents, auto_save_error):
1692 Rename locals to avoid shadowing.
f14b7e14 1693
5716756e 1694 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1695 (Ftry_completion, Fall_completions): Rename or remove locals
1696 to avoid shadowing.
5716756e 1697
b4c3046a
PE
1698 * marker.c (bytepos_to_charpos): Remove; unused.
1699
b45db522
PE
1700 * lisp.h (verify_bytepos, count_markers): New decls,
1701 so that gcc does not warn that these functions aren't declared.
1702
85876d07
PE
1703 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1704 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1705 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1706 (copy_text): Remove unused local var.
85876d07 1707
03d78a21 1708 * filelock.c (within_one_second): Now static.
b3dd38ab 1709 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1710
5df8f01b
PE
1711 * buffer.c (fix_overlays_before): Mark locals as initialized.
1712 (fix_start_end_in_overlays): Likewise. This function should be
1713 simplified by using pointers-to-pointers, but that's a different
1714 matter.
b1d876f1 1715 (switch_to_buffer_1): Now static.
8f54f30a
PE
1716 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1717 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1718
a70072c9 1719 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1720 Fix pointer signedness issue.
edced198
PE
1721 (sys_subshell): Mark local as volatile if checking for lint,
1722 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1723 (MAXPATHLEN): Define only if needed.
a70072c9 1724
a0977c44
PE
1725 * process.c (serial_open, serial_configure): Move decls from here ...
1726 * systty.h: ... to here, so that they can be checked.
1727
a884fdcc
PE
1728 * fns.c (get_random, seed_random): Move extern decls from here ...
1729 * lisp.h: ... to here, so that they can be checked.
1730
604efe86 1731 * sysdep.c (reset_io): Now static.
b8950c94 1732 (wait_for_termination_signal): Remove; unused.
604efe86 1733
38fc62d9
PE
1734 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1735 (copy_keymap_item, append_key, push_text_char_description):
1736 Now static.
1004a21a 1737 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1738 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1739 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1740 (describe_map_tree):
1741 Rename locals to avoid shadowing.
38fc62d9 1742
2f2650da
PE
1743 * keyboard.c: Declare functions static if they are not used elsewhere.
1744 (echo_char, echo_dash, cmd_error, top_level_2):
1745 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1746 (read_char, kbd_buffer_get_event, make_lispy_position):
1747 (make_lispy_event, make_lispy_movement, apply_modifiers):
1748 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1749 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1750 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1751 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1752 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1753
a053e86c 1754 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1755 (mark_kboards): Move decl here ...
1756 * alloc.c (mark_kboards): ... from here.
a053e86c 1757
4752793e
PE
1758 * lisp.h (force_auto_save_soon): New decl.
1759
74f10ca7 1760 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1761 (DEFINE_DUMMY_FUNCTION): New macro.
1762 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1763 Use it.
c03cd23f
PE
1764 (main): Add casts to avoid warnings
1765 if GCC considers string literals to be constants.
74f10ca7 1766
022e70d4
PE
1767 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1768
59d6fe83
PE
1769 * dbusbind.c: Pointer signedness fixes.
1770 (xd_signature, xd_append_arg, xd_initialize):
1771 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1772 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1773 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1774 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1775
78320123
PE
1776 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1777 if GCC considers string literals to be constants.
49cebcca 1778 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1779
35ac2a97
SM
17802011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1781
fb103ca9
SM
1782 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1783 (print_preprocess, print_object): New macro to fix last change.
1784
35ac2a97
SM
1785 * print.c (print_preprocess): Don't forget font objects.
1786
62973b41
JB
17872011-03-16 Juanma Barranquero <lekktu@gmail.com>
1788
1789 * emacs.c (USAGE3): Doc fixes.
1790
0e48bb22
AS
17912011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1792
1793 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1794 structure.
1795
7684e57b
JB
17962011-03-14 Juanma Barranquero <lekktu@gmail.com>
1797
1798 * lisp.h (VWindow_system, Qfile_name_history):
1799 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1800 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1801 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1802
1803 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1804 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1805
1806 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1807 * w32console.c (detect_input_pending, read_input_pending)
1808 (encode_terminal_code):
1809 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1810 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1811 (w32_system_caret_y, Qfile_name_history):
1812 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1813 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1814 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1815 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1816 * w32proc.c (Qlocal, report_file_error):
1817 * w32term.c (Vwindow_system, updating_frame):
1818 * w32uniscribe.c (initialized, uniscribe_font_driver):
1819 Remove unneeded extern declarations.
1820
2aa46d6c
CY
18212011-03-14 Chong Yidong <cyd@stupidchicken.com>
1822
c96bbc66 1823 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1824
cffc6f3b
CY
18252011-03-13 Chong Yidong <cyd@stupidchicken.com>
1826
1827 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1828 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1829 These macros can no longer be used for assignment.
1830
44f230aa
SM
1831 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1832 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1833 (record_buffer_markers, fetch_buffer_markers): New functions for
1834 recording and fetching special buffer markers.
1835 (set_buffer_internal_1, set_buffer_temp): Use them.
1836
1837 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1838
1839 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1840
1841 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1842 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1843
1844 * xdisp.c (hscroll_window_tree):
1845 (reconsider_clip_changes): Use PT instead of BUF_PT.
1846
d251f04b
EZ
18472011-03-13 Eli Zaretskii <eliz@gnu.org>
1848
1849 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1850 $(EMACS_ROOT)/lib/intprops.h.
1851
f0c77cd1
PE
18522011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1853
3eca4629
PE
1854 Fix more problems found by GCC 4.5.2's static checks.
1855
7c86ee98
PE
1856 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1857 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1858 (xg_free_frame_widgets): Make it clear that a local variable is
1859 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1860 (gdk_window_get_screen): Make it clear that this macro is needed
1861 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1862 (int_gtk_range_get_value): New function, which avoids a diagnostic
1863 from gcc -Wbad-function-cast.
1864 (xg_set_toolkit_scroll_bar_thumb): Use it.
1865 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1866 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1867 (get_utf8_string, xg_get_file_with_chooser):
1868 Rename locals to avoid shadowing.
1869 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1870
41729b81
PE
1871 * xgselect.c (xg_select): Remove unused var.
1872
f0c77cd1
PE
1873 * image.c (four_corners_best): Mark locals as initialized.
1874 (gif_load): Initialize transparent_p to zero (Bug#8238).
1875 Mark another local as initialized.
ec6cf4c6 1876 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1877
ce0ad53d 1878 * image.c (clear_image_cache): Now static.
d5d5a617 1879 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1880 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1881 (x_edge_detection): Remove unnecessary cast that
1882 gcc -Wbad-function-cast diagnoses.
2037898d 1883 (gif_load): Fix pointer signedness.
6ae141d6
PE
1884 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1885 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1886
33383987 18872011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1888
d32df629
PE
1889 Improve quality of tests for time stamp overflow.
1890 For example, without this patch (encode-time 0 0 0 1 1
1891 1152921504606846976) returns the obviously-bogus value (-948597
1892 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1893 reports time overflow. See
1894 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1895 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1896 * editfns.c: Include limits.h and intprops.h.
1897 (TIME_T_MIN, TIME_T_MAX): New macros.
1898 (time_overflow): Move earlier, to before first use.
1899 (hi_time, lo_time): New functions, for an accurate test for
1900 out-of-range times.
1901 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1902 (Fget_internal_run_time): Don't assume time_t fits in int.
1903 (make_time): Use list2 instead of Fcons twice.
1904 (Fdecode_time): More accurate test for out-of-range times.
1905 (check_tm_member): New function.
1906 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1907 (lisp_time_argument): Don't rely on undefined left-shift and
1908 right-shift behavior when checking for time stamp overflow.
8be6f318 1909
fe31d94c
PE
1910 * editfns.c (time_overflow): New function, refactoring common code.
1911 (Fformat_time_string, Fdecode_time, Fencode_time):
1912 (Fcurrent_time_string): Use it.
1913
8be6f318
PE
1914 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1915 * dired.c (make_time): Move to ...
1916 * editfns.c (make_time): ... here.
1917 * systime.h: Note the move.
1918
09d9db2c 19192011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1920
126bc0dc
YM
1921 * fringe.c (update_window_fringes): Remove unused variables.
1922
c47cbdfd
YM
1923 * unexmacosx.c (copy_data_segment): Also copy __got section.
1924 (Bug#8223)
1925
7ac80be9
EZ
19262011-03-12 Eli Zaretskii <eliz@gnu.org>
1927
c96bbc66 1928 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1929 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1930 Constify `char *' arguments and their references according to
1931 prototypes in tparam.h.
1932
ecb0f94d 1933 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1934
7ac80be9
EZ
1935 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1936 Adapt all references accordingly.
1937
1938 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1939
ef1fd07e
TT
19402011-03-11 Tom Tromey <tromey@redhat.com>
1941
1942 * buffer.c (syms_of_buffer): Remove obsolete comment.
1943
7ef4b50c
EZ
19442011-03-11 Eli Zaretskii <eliz@gnu.org>
1945
1946 * termhooks.h (encode_terminal_code): Declare prototype.
1947
1948 * msdos.c (encode_terminal_code): Don't declare prototype.
1949
1950 * term.c (encode_terminal_code): Now external again, used by
1951 w32console.c and msdos.c.
1952
44f230aa
SM
1953 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1954 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1955
4b1ec863 19562011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1957
1714f52b 1958 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1959
4b1ec863
PE
1960 * fringe.c (update_window_fringes): Mark locals as initialized
1961 (Bug#8227).
1962 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1963
524c7aa6
PE
1964 * alloc.c (mark_fringe_data): Move decl from here ...
1965 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1966 to check its interface.
1967 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1968
a5c0af81 1969 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1970 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1971 (fontset_font): Mark local as initialized.
a9a06e0b 1972 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1973
b4716021
PE
1974 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1975
811e9bac 1976 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1977 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1978 (x_own_selection, Fx_disown_selection_internal): Rename locals
1979 to avoid shadowing.
1980 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1981
7e3ab302
PE
1982 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1983 so that the caller can use some name other than gcpro1.
1984 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1985 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1986 (Fx_backspace_delete_keys_p):
1987 Use them to avoid shadowing, and rename vars to avoid shadowing.
1988 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1989 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1990 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1991 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1992 Remove unused locals.
7e3ab302
PE
1993 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1994 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1995 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1996 macros.
f78faa98 1997
e2b13473
PE
1998 * xterm.h (x_mouse_leave): New decl.
1999
77f23912
PE
2000 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2001 Remove unused functions.
cdf4ba58
PE
2002 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2003 (x_calc_absolute_position): Now static.
7411c686 2004 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2005 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2006 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2007 unless they are used.
38d0b34a
PE
2008 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2009 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2010 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2011 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2012 (x_error_catcher, x_connection_closed, x_error_handler):
2013 (x_error_quitter, xembed_send_message, x_iconify_frame):
2014 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2015 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2016 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2017
44f230aa
SM
2018 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2019 Rename or move locals to avoid shadowing.
6b463e58 2020 (tty_defined_color, merge_face_heights): Now static.
5967d051 2021 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2022 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2023 does not deduce is never used uninitialized.
73719eba
PE
2024 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2025 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2026
426994c3 2027 * terminal.c (store_terminal_param): Now static.
5489860b 2028
032f1620 2029 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2030 (set_frame_menubar): Remove unused local.
d4323972 2031 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2032 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2033 since they might point to immutable storage.
281585b0
PE
2034 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2035 since it's unused otherwise.
032f1620 2036
367c19e5 2037 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2038 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2039 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2040 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2041 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2042 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2043 does not deduce are never used uninitialized.
70739cbe 2044
07b48fa9
PE
2045 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2046
8868a238 2047 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2048 * window.c (window_loop, size_window):
2049 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2050
7e5cf297 2051 * window.c (display_buffer): Now static.
d6550a9f
PE
2052 (size_window): Mark variables that gcc -Wuninitialized
2053 does not deduce are never used uninitialized.
a586633d
PE
2054 * window.h (check_all_windows): New decl, to forestall
2055 gcc -Wmissing-prototypes diagnostic.
5b555da1 2056 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2057
f6095868
PE
2058 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2059 shadowing.
2060 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2061 Include <limits.h>.
2062 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2063 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2064 (load_charset_map): Mark variables that gcc -Wuninitialized
2065 does not deduce are never used uninitialized.
53df7c11 2066 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2067
f38b440c
PE
2068 * coding.c (coding_set_source, coding_set_destination):
2069 Use "else { /* comment */ }" rather than "else /* comment */;"
2070 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2071 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2072 a block, when the outer 'i' will do.
2073 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2074 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2075 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2076 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2077 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2078 Rename locals to avoid shadowing.
2079 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2080 * coding.c (emacs_mule_char, encode_invocation_designation):
2081 Now static, since they're not used elsewhere.
413bb2db 2082 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2083 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2084 (decode_coding_emacs_mule): Mark variables that gcc
2085 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2086 (detect_coding_iso_2022): Initialize a local variable that might
2087 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2088 this initialization is needed. (Bug#8211)
5f58e762
PE
2089 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2090 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2091 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2092 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2093 Remove unused macros.
f38b440c 2094
232b38b9 2095 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2096 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2097 * character.c (string_count_byte8): Likewise.
232b38b9 2098
fb90da1b
PE
2099 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2100 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2101
fb93dbc2
PE
2102 * chartab.c (copy_sub_char_table): Now static, since it's not used
2103 elsewhere.
5c156ace
PE
2104 (sub_char_table_ref_and_range, char_table_ref_and_range):
2105 Rename locals to avoid shadowing.
bbcd0949 2106 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2107
7d3b3862 2108 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2109 (BIDI_BOB): Remove unused macro.
7d3b3862 2110
6be7d3da
PE
2111 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2112 deduce are never used uninitialized.
c2ed9c8b 2113 * term.c (encode_terminal_code): Likewise.
6be7d3da 2114
75f8807f 2115 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2116
50938595
PE
2117 * tparam.h: New file.
2118 * term.c, tparam.h: Include it.
2119 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2120 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2121 Move these decls to tparam.h, and make them agree with what
2122 is actually in tparam.c. The previous trick of using incompatible
2123 decls in different modules does not conform to the C standard.
2124 All callers of tparam changed to use tparam's actual API.
2125 * tparam.c (tparam1, tparam, tgoto):
2126 Use const pointers where appropriate.
2127
fbceeba2
PE
2128 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2129 * cm.h (struct cm): Likewise.
2130 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2131 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2132 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2133 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2134 (turn_on_face, init_tty): Likewise.
2135 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2136
7f3f1250
PE
2137 * term.c (term_mouse_position): Rename local to avoid shadowing.
2138
e6ca6543
PE
2139 * alloc.c (mark_ttys): Move decl from here ...
2140 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2141
c40f8d15
AS
21422011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2143
2144 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2145
cfe0661d
JB
21462011-03-09 Juanma Barranquero <lekktu@gmail.com>
2147
2148 * search.c (compile_pattern_1): Remove argument regp, unused since
2149 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2150 (compile_pattern): Don't pass it.
2151
0afb4571
J
21522011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2153
2154 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2155 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2156 for ! HAVE_GTK3.
2157 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2158
2159 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2160
2161 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2162 gdk_window_get_screen, gdk_window_get_geometry,
2163 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2164 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2165 (xg_get_pixbuf_from_pixmap): New function.
2166 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2167 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2168 Call xg_get_pixbuf_from_pixmap instead of
2169 gdk_pixbuf_get_from_drawable.
2170 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2171 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2172 (xg_check_special_colors): Use GtkStyleContext and its functions
2173 for HAVE_GTK3.
2174 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2175 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2176 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2177 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2178 Call gtk_widget_get_preferred_size.
0afb4571
J
2179 (xg_frame_resized): gdk_window_get_geometry only takes 5
2180 parameters.
44f230aa
SM
2181 (xg_win_to_widget, xg_event_is_for_menubar):
2182 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2183 (xg_set_widget_bg): New function.
2184 (delete_cb): New function.
2185 (xg_create_frame_widgets): connect delete-event to delete_cb.
2186 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2187 (xg_set_background_color): Call xg_set_widget_bg.
2188 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2189 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2190 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2191 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2192 if ! HAVE_GTK3.
2193 (update_frame_tool_bar): Call gtk_widget_hide.
2194 (xg_initialize): Use GDK_KEY_g.
2195
2196 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2197 if ! HAVE_GTK3
2198 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2199
2200 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2201 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2202 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2203
1c2cc4ef
JB
22042011-03-08 Juanma Barranquero <lekktu@gmail.com>
2205
2206 * w32xfns.c (select_palette): Check success of RealizePalette against
2207 GDI_ERROR, not zero.
2208
33383987 2209See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2210
2211;; Local Variables:
2212;; coding: utf-8
aac0c6e3
MR
2213;; End:
2214
33383987 2215 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2216
2217 This file is part of GNU Emacs.
2218
2219 GNU Emacs is free software: you can redistribute it and/or modify
2220 it under the terms of the GNU General Public License as published by
2221 the Free Software Foundation, either version 3 of the License, or
2222 (at your option) any later version.
2223
2224 GNU Emacs is distributed in the hope that it will be useful,
2225 but WITHOUT ANY WARRANTY; without even the implied warranty of
2226 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2227 GNU General Public License for more details.
2228
2229 You should have received a copy of the GNU General Public License
2230 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.