nndraft.el (nndraft-update-unread-articles): New function.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1e49bfab
LMI
12011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4
1485f4c0
CY
52011-07-03 Chong Yidong <cyd@stupidchicken.com>
6
7 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8 and background color parameters if they have been changed.
9
a9ab721e
LMI
102011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11
12 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
13
cf7cff57
PE
142011-07-03 Paul Eggert <eggert@cs.ucla.edu>
15
2e13213d
PE
16 * xsettings.c (SYSTEM_FONT): Define only when used.
17 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
18
cf7cff57
PE
19 * keymap.c (access_keymap_1): Now static.
20
7a8e04f7
CY
212011-07-02 Chong Yidong <cyd@stupidchicken.com>
22
23 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
24 leave any prefix arg for the up event (Bug#1586).
25
61352f62
LMI
262011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
27
69bb1ef7
LMI
28 * lread.c (syms_of_lread): Mention single symbols defined by
29 `defvar' or `defconst' (bug#7154).
30
61352f62 31 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 32 (Frequire): Mention get-load-suffixes.
61352f62 33
28545e04
MR
342011-07-02 Martin Rudalics <rudalics@gmx.at>
35
36 * window.h (window): Remove clone_number slot.
37 * window.c (Fwindow_clone_number, Fset_window_clone_number):
38 Remove.
39 (make_parent_window, make_window, saved_window)
40 (Fset_window_configuration, save_window_save): Don't deal with
41 clone numbers.
42 * buffer.c (Qclone_number): Remove declaration.
43 (sort_overlays, overlay_strings): Don't deal with clone numbers.
44
3349e122
SM
452011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
46
47 Add multiple inheritance to keymaps.
48 * keymap.c (Fmake_composed_keymap): New function.
49 (Fset_keymap_parent): Simplify.
50 (fix_submap_inheritance): Remove.
51 (access_keymap_1): New function extracted from access_keymap to handle
52 embedded parents and handle lists of maps.
53 (access_keymap): Use it.
54 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
55 (Fcopy_keymap): Handle embedded parents.
56 (Fcommand_remapping, define_as_prefix): Simplify.
57 (Fkey_binding): Simplify.
58 (syms_of_keymap): Move minibuffer-local-completion-map,
59 minibuffer-local-filename-completion-map,
60 minibuffer-local-must-match-map, and
61 minibuffer-local-filename-must-match-map to Elisp.
62 (syms_of_keymap): Defsubr make-composed-keymap.
63 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
64 (parse_menu_item): Trivial simplification.
65
3279eb87
GM
662011-07-01 Glenn Morris <rgm@gnu.org>
67
68 * Makefile.in (SETTINGS_LIBS): Fix typo.
69
4550efdf
KI
702011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
71
72 * coding.c (Fencode_coding_string): Record the last coding system
73 used, as the function doc string says (bug#8738).
74
0949d2b6
JD
752011-07-01 Jan Djärv <jan.h.d@swipnet.se>
76
77 * xsettings.c (store_monospaced_changed): Take new font as arg and
78 check for change against current_mono_font.
79 (EMACS_TYPE_SETTINGS): Remove this and related defines.
80 (emacs_settings_constructor, emacs_settings_get_property)
81 (emacs_settings_set_property, emacs_settings_class_init)
82 (emacs_settings_init, gsettings_obj): Remove.
83 (something_changedCB): New function for HAVE_GSETTINGS.
84 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
85 with value as argument.
86 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
87 g_settings_new (Bug#8967). Do not create gsettings_obj.
88 Remove calls to g_settings_bind. Connect something_changedCB to
89 "changed".
90
91 * xgselect.c: Add defined (HAVE_GSETTINGS).
92 (xgselect_initialize): Ditto.
93
94 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
95 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
96 xg_select.
97
bbc6b304
PE
982011-07-01 Paul Eggert <eggert@cs.ucla.edu>
99
100 * eval.c (struct backtrace): Simplify and port the data structure.
101 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
102 signed bit field, as this assumption is not portable and it makes
103 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
104 "char debug_on_exit : 1" as this is not portable either; instead,
105 use the portable "unsigned int debug_on_exit : 1". Remove unused
106 member evalargs. Remove obsolete comments about cc bombing out.
107
9851bfc5
JD
1082011-06-30 Jan Djärv <jan.h.d@swipnet.se>
109
51bb811f 110 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
111 Let HAVE_GSETTINGS override HAVE_GCONF.
112 (store_monospaced_changed): New function.
113 (EMACS_SETTINGS): A new type derived from GObject to handle
114 GSettings notifications.
115 (emacs_settings_constructor, emacs_settings_get_property)
116 (emacs_settings_set_property, emacs_settings_class_init):
117 New functions.
118 (gsettings_client, gsettings_obj): New variables.
119 (GSETTINGS_SCHEMA): New define.
120 (something_changedCB): Call store_monospaced_changed.
121 (init_gsettings): New function.
122 (xsettings_initialize): Call init_gsettings.
123 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
124 to NULL.
125
126 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
127 GCONF_CFLAGS/LIBS.
128
5386012d
MR
1292011-06-29 Martin Rudalics <rudalics@gmx.at>
130
131 * window.c (resize_root_window, grow_mini_window)
132 (shrink_mini_window): Rename Qresize_root_window to
133 Qwindow_resize_root_window and Qresize_root_window_vertically to
134 Qwindow_resize_root_window_vertically.
135
f13e0b08
PE
1362011-06-28 Paul Eggert <eggert@cs.ucla.edu>
137
138 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
139
94515237
JB
1402011-06-27 Juanma Barranquero <lekktu@gmail.com>
141
142 * makefile.w32-in: Redesign dependencies so they reflect more
143 clearly which files are directly included by each source file,
144 and not through other includes.
145
e43b6e43
MR
1462011-06-27 Martin Rudalics <rudalics@gmx.at>
147
148 * buffer.c (Qclone_number): Declare static and DEFSYM it.
149 (sort_overlays, overlay_strings): When an overlay's clone number
150 matches the window's clone number process the overlay even if
151 the overlay's window property doesn't match the current window.
152
d68443dc
MR
153 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
154 (Fwindow_hchild): Rename to Fwindow_left_child.
155 (Fwindow_next): Rename to Fwindow_next_sibling.
156 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
157 (resize_window_check): Rename to window_resize_check.
158 (resize_window_apply): Rename to window_resize_apply.
159 (Fresize_window_apply): Rename to Fwindow_resize_apply.
160 (Fdelete_other_windows_internal, resize_frame_windows)
161 (Fsplit_window_internal, Fdelete_window_internal)
162 (grow_mini_window, shrink_mini_window)
163 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 164
c7e73be5
JD
1652011-06-26 Jan Djärv <jan.h.d@swipnet.se>
166
167 * emacsgtkfixed.h: State that this is only used with Gtk+3.
168 (emacs_fixed_set_min_size): Remove.
169 (emacs_fixed_new): Take frame as argument.
170
171 * emacsgtkfixed.c: State that this is only used with Gtk+3.
172 (_EmacsFixedPrivate): Remove minwidth/height.
173 Add struct frame *f.
174 (emacs_fixed_init): Initialize priv->f.
175 (get_parent_class, emacs_fixed_set_min_size): Remove.
176 (emacs_fixed_new): Set priv->f to argument.
177 (emacs_fixed_get_preferred_width)
178 (emacs_fixed_get_preferred_height): Use min_width/height from
179 frames size_hint to set minimum and natural (Bug#8919).
180 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
181 and use min_width/height from frames size_hint to set
182 min_width/height (Bug#8919).
183
184 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
185 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
186 indentation.
187
cf99dcf8
EZ
1882011-06-26 Eli Zaretskii <eliz@gnu.org>
189
190 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
191 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
192 called at ZV.
193
029529ac
CY
1942011-06-26 Chong Yidong <cyd@stupidchicken.com>
195
196 * process.c (wait_reading_process_output): Bypass select if
197 waiting for a cell while ignoring keyboard input, and input is
198 pending. Suggested by Jan Djärv (Bug#8869).
199
7a7ef429
PE
2002011-06-25 Paul Eggert <eggert@cs.ucla.edu>
201
202 Use gnulib's dup2 module instead of rolling our own.
203 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
204
11fdef7d 2052011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
206
207 * dispnew.c (scrolling_window): Before scrolling, turn off a
208 mouse-highlight in the window being scrolled.
209
cd3520a4
JB
2102011-06-24 Juanma Barranquero <lekktu@gmail.com>
211
212 Move DEFSYM to lisp.h and use everywhere.
213
214 * character.h (DEFSYM): Move declaration...
215 * lisp.h (DEFSYM): ...here.
216
217 * gnutls.c:
218 * minibuf.c:
219 * w32menu.c:
220 * w32proc.c:
221 * w32select.c: Don't include character.h.
222
223 * alloc.c (syms_of_alloc):
224 * buffer.c (syms_of_buffer):
225 * bytecode.c (syms_of_bytecode):
226 * callint.c (syms_of_callint):
227 * casefiddle.c (syms_of_casefiddle):
228 * casetab.c (init_casetab_once):
229 * category.c (init_category_once, syms_of_category):
230 * ccl.c (syms_of_ccl):
231 * cmds.c (syms_of_cmds):
232 * composite.c (syms_of_composite):
233 * dbusbind.c (syms_of_dbusbind):
234 * dired.c (syms_of_dired):
235 * dispnew.c (syms_of_display):
236 * doc.c (syms_of_doc):
237 * editfns.c (syms_of_editfns):
238 * emacs.c (syms_of_emacs):
239 * eval.c (syms_of_eval):
240 * fileio.c (syms_of_fileio):
241 * fns.c (syms_of_fns):
242 * frame.c (syms_of_frame):
243 * fringe.c (syms_of_fringe):
244 * insdel.c (syms_of_insdel):
245 * keymap.c (syms_of_keymap):
246 * lread.c (init_obarray, syms_of_lread):
247 * macros.c (syms_of_macros):
248 * msdos.c (syms_of_msdos):
249 * print.c (syms_of_print):
250 * process.c (syms_of_process):
251 * search.c (syms_of_search):
252 * sound.c (syms_of_sound):
253 * syntax.c (init_syntax_once, syms_of_syntax):
254 * terminal.c (syms_of_terminal):
255 * textprop.c (syms_of_textprop):
256 * undo.c (syms_of_undo):
257 * w32.c (globals_of_w32):
258 * window.c (syms_of_window):
259 * xdisp.c (syms_of_xdisp):
260 * xfaces.c (syms_of_xfaces):
261 * xfns.c (syms_of_xfns):
262 * xmenu.c (syms_of_xmenu):
263 * xsettings.c (syms_of_xsettings):
264 * xterm.c (syms_of_xterm): Use DEFSYM.
265
4228cf16
TZ
2662011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
267
cd3520a4 268 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 269
7fcccf1e
PE
2702011-06-23 Paul Eggert <eggert@cs.ucla.edu>
271
7efb4e0e
PE
272 Integer and buffer overflow fixes (Bug#8873).
273
ff5844ad
PE
274 * print.c (printchar, strout): Check for string overflow.
275 (PRINTPREPARE, printchar, strout):
276 Don't set size unless allocation succeeds.
277
90532f02
PE
278 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
279 for sizes. Check for string overflow more accurately.
280 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
281
6d84508d
PE
282 * macros.c: Integer and buffer overflow fixes.
283 * keyboard.h (struct keyboard.kbd_macro_bufsize):
284 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
285 Use ptrdiff_t, not int, for sizes.
286 Don't increment bufsize until after realloc succeeds.
287 Check for size-calculation overflow.
288 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
289
437b2cb4
PE
290 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
291
8b9ac8b4
PE
292 * lread.c: Integer overflow fixes.
293 (read_integer): Radix is now EMACS_INT, not int,
294 to improve quality of diagnostics for out-of-range radices.
295 Calculate buffer size correctly for out-of-range radices.
296 (read1): Check for integer overflow in radices, and in
297 read-circle numbers.
82cb60d3
PE
298 (read_escape): Avoid int overflow.
299 (Fload, openp, read_buffer_size, read1)
300 (substitute_object_recurse, read_vector, read_list, map_obarray):
301 Use ptrdiff_t, not int, for sizes.
302 (read1): Use EMACS_INT, not int, for sizes.
20270765 303 Check for size overflow.
8b9ac8b4 304
7fcccf1e
PE
305 * image.c (cache_image): Check for size arithmetic overflow.
306
bfbbd7e7
PE
307 * lread.c: Integer overflow issues.
308 (saved_doc_string_size, saved_doc_string_length)
309 (prev_saved_doc_string_size, prev_saved_doc_string_length):
310 Now ptrdiff_t, not int.
311 (read1): Don't assume doc string length fits in int. Check for
312 out-of-range doc string lengths.
313 (read_list): Don't assume file position fits in int.
39019e54 314 (read_escape): Check for hex character overflow.
bfbbd7e7 315
4e323265
LL
3162011-06-22 Leo Liu <sdl.web@gmail.com>
317
318 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
319 Move to minibuffer.el.
320
85fece3e
PE
3212011-06-22 Paul Eggert <eggert@cs.ucla.edu>
322
20b84ce9 323 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
324 The following patches are for when GLYPH_DEBUG && !XASSERT.
325 * dispextern.h (trace_redisplay_p, dump_glyph_string):
326 * dispnew.c (flush_stdout):
327 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
328 Mark as externally visible.
329 * dispnew.c (check_window_matrix_pointers): Now static.
330 * dispnew.c (window_to_frame_vpos):
331 * xfns.c (unwind_create_frame):
332 * xterm.c (x_check_font): Remove unused local.
333 * scroll.c (CHECK_BOUNDS):
334 * xfaces.c (cache_fache): Rename local to avoid shadowing.
335 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
336 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
337 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
338 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
339 Now static.
340 (debug_method_add): Use va_list and vsprintf rather than relying
341 on undefined behavior with wrong number of arguments.
342 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
343 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
344 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
345 since we're not interested in debugging glyphs with old libraries.
346 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
347 GCC 4.6.0's static checking.
348
0766b489
PE
3492011-06-22 Paul Eggert <eggert@cs.ucla.edu>
350
31fd4b32
PE
351 Integer overflow and signedness fixes (Bug#8873).
352 A few related buffer overrun fixes, too.
353
b79e8648
PE
354 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
355
0766b489
PE
356 * dispextern.h (struct face.stipple):
357 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
358 (x_bitmap_mask, x_allocate_bitmap_record)
359 (x_create_bitmap_from_data, x_create_bitmap_from_file)
360 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
361 (x_create_bitmap_from_xpm_data):
362 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
363 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
364 (.bitmaps_last):
365 * xfaces.c (load_pixmap):
366 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
367 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
368 (.bitmaps_last, struct x_output.icon_bitmap):
369 Use ptrdiff_t, not int, for bitmap indexes.
370 (x_allocate_bitmap_record): Check for size overflow.
371 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
372
b081724f
PE
373 Use ptrdiff_t, not int, for overlay counts.
374 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
375 * editfns.c (overlays_around, get_pos_property):
376 * textprop.c (get_char_property_and_overlay):
377 * xdisp.c (next_overlay_change, note_mouse_highlight):
378 * xfaces.c (face_at_buffer_position):
21514da7
PE
379 * buffer.c (OVERLAY_COUNT_MAX): New macro.
380 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
381 (Fnext_overlay_change, Fprevious_overlay_change)
382 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 383 Use ptrdiff_t, not int, for sizes.
21514da7 384 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 385
3de73e5e
PE
386 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
387
2606c57b
PE
388 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
389 (x_session_initialize): Do not assume string length fits in int.
390
aaafe47a
PE
391 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
392 This is unlikely, but can occur if DPI is outlandish.
393
2674ddc8 394 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
395 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
396
28154962
PE
397 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
398 * xrdb.c (magic_file_p, search_magic_path):
399 Omit last arg SUFFIX; it was always 0. All callers changed.
400 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
401
7de51af5
PE
402 * xfont.c (xfont_match): Avoid need for strlen.
403
25ed6cc3
PE
404 * xfns.c: Don't assume strlen fits in int.
405 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
406
4eab31dd
PE
407 * xdisp.c (message_log_check_duplicate): Return intmax_t,
408 not unsigned long, as we prefer signed integers. All callers changed.
409 Detect integer overflow in repeat count.
410 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 411 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 412
171e2a58
PE
413 * termcap.c: Don't assume sizes fit in int and never overflow.
414 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
415 (gobble_line): Check for size-calculation overflow.
416
ad39faca 417 * minibuf.c (Fread_buffer):
6e5bb2dc 418 * lread.c (intern, intern_c_string):
74ca2eb3
PE
419 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
420 Don't assume string length fits in int.
421
52c61c22 422 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
423 * gtkutil.c (style_changed_cb): Avoid need for strlen.
424
b5b8c9e5
PE
425 * font.c: Don't assume string length fits in int.
426 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
427 Use ptrdiff_t, not int.
ccd6111c
PE
428 (font_intern_prop): Don't assume string length fits in int.
429 Don't assume integer property fits in fixnum.
430 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 431
882f0d81 432 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 433 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
434 Reformulate so as not to need the command string.
435 Invoke gzip -cd rather than gunzip, as it's more portable.
436 (lock_info_type, lock_file_1, lock_file):
437 Don't assume pid_t and time_t fit in unsigned long.
438 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
439 (current_lock_owner): Prefer signed type for sizes.
440 Use memcpy, not strncpy, where memcpy is what is really wanted.
441 Don't assume (via atoi) that time_t and pid_t fit in int.
442 Check for time_t and/or pid_t out of range, e.g., via a network share.
443 Don't alloca where an auto var works fine.
444
93f4cf88
PE
445 * fileio.c: Fix some integer overflow issues.
446 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
447 Don't assume string length fits in int.
448 (directory_file_name): Don't assume string length fits in long.
449 (make_temp_name): Don't assume pid fits in int, or that its print
450 length is less than 20.
451
f3e92b69
PE
452 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
453
1bfdaf10
PE
454 * coding.c (make_subsidiaries): Don't assume string length fits in int.
455
35016e9a
PE
456 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
457
3d1e65a1
PE
458 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
459 We prefer signed integers, even for size calculations.
460
0b963a93
PE
461 * emacs.c: Don't assume string length fits in 'int'.
462 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
463 (main): Don't invoke strlen when not needed.
464
573f4b54
PE
465 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
466 (XD_DEBUG_MESSAGE): Don't waste a byte.
467
989f33ba
PE
468 * callproc.c (getenv_internal_1, getenv_internal)
469 (Fgetenv_internal):
965d34eb
PE
470 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
471
e4d29b33
PE
472 * lread.c (invalid_syntax): Omit length argument.
473 All uses changed. This doesn't fix a bug, but it simplifies the
474 code away from its former Hollerith-constant appearance, and it's
475 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 476 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 477
eb49b136
PE
478 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
479 This didn't break anything, but it didn't help either.
480 It's confusing to put a bogus integer in a place where the actual
481 value does not matter.
9f62aeb1 482 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 483 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 484
15375a22
PE
485 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
486 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
487 implementation.
b61cc01c
PE
488 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
489 We prefer signed types, and the value cannot exceed the EMACS_INT
490 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
491 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
492 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
493 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 494
53b2623d
PE
495 * indent.c (sane_tab_width): New function.
496 (current_column, scan_for_column, Findent_to, position_indentation)
497 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 498 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 499
51cab52b 500 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 501
f2ed8a70
PE
502 * lisp.h (lint_assume): New macro.
503 * composite.c (composition_gstring_put_cache):
504 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
505
abe80cc6
PE
506 * editfns.c, insdel.c:
507 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 508
b02c740e
PE
509 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
510
ebc96716
PE
511 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
512
b4e50fa0 513 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 514 Use much-faster test for byte-length change.
311d5d7c 515 Don't assume string byte-length fits in 'int'.
a4cf38e4 516 Check that character arg fits in 'int'.
85461888 517 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 518
c0c1ee9f
PE
519 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
520
a498d7f4
PE
521 * fns.c (concat): Catch string overflow earlier.
522 Do not rely on integer wraparound.
523
51cab52b
PE
524 * dispextern.h (struct it.overlay_strings_charpos)
525 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
526 * xdisp.c (forward_to_next_line_start)
527 (back_to_previous_visible_line_start)
528 (reseat_at_next_visible_line_start, next_element_from_buffer):
529 Don't arbitrarily truncate the value of 'selective' to int.
530
76031fad
PE
531 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
532
5eb55db9
PE
533 * composite.c: Don't truncate sizes to 'int'.
534 (composition_gstring_p, composition_reseat_it)
535 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
536 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
537 not EMACS_UINT, for indexes.
5eb55db9 538
0703a717
PE
539 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
540
d6202519
PE
541 * buffer.c: Include <verify.h>.
542 (struct sortvec.priority, struct sortstr.priority):
8961a454 543 Now EMACS_INT, not int.
c20998a7 544 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
545 (struct sortstr.size, record_overlay_string)
546 (struct sortstrlist.size, struct sortlist.used):
547 Don't truncate size to int.
548 (record_overlay_string): Check for size-calculation overflow.
d6202519 549 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 550
d5a19415
JM
5512011-06-22 Jim Meyering <meyering@redhat.com>
552
029529ac 553 Don't leak an XBM-image-sized buffer
d5a19415
JM
554 * image.c (xbm_load): Free the image buffer after using it.
555
a9041e6c
PE
5562011-06-21 Paul Eggert <eggert@cs.ucla.edu>
557
558 Port to Sun C.
559 * composite.c (find_automatic_composition): Omit needless 'return 0;'
560 that Sun C diagnosed.
561 * fns.c (secure_hash): Fix pointer signedness issue.
562 * intervals.c (static_offset_intervals): New function.
563 (offset_intervals): Use it.
564
7f3f739f
LL
5652011-06-21 Leo Liu <sdl.web@gmail.com>
566
567 * deps.mk (fns.o):
568 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
569 sha512.h.
570
571 * fns.c (secure_hash): Rename from crypto_hash_function and change
572 the first arg to accept symbols.
5b66d427 573 (Fsecure_hash): New primitive.
7f3f739f
LL
574 (syms_of_fns): New symbols.
575
76147d94
DD
5762011-06-20 Deniz Dogan <deniz@dogan.se>
577
578 * process.c (Fset_process_buffer): Clarify return value in
579 docstring.
580
7d7d0045
CY
5812011-06-18 Chong Yidong <cyd@stupidchicken.com>
582
583 * dispnew.c (add_window_display_history): Use BVAR.
584
585 * xdisp.c (debug_method_add): Use BVAR.
586 (check_window_end, dump_glyph_matrix, dump_glyph)
587 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
588
589 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
590 Likewise.
591
592 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
593 check till after the cache is created in init_frame_faces.
594
ff2bc410
SM
5952011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
596
597 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
598
28177add
PE
5992011-06-16 Paul Eggert <eggert@cs.ucla.edu>
600
dd3482fe
PE
601 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
602 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
603 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
604
393d71f3 605 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
606 * fileio.c (Finsert_file_contents):
607 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
608 Remove the old (too-loose) buffer overflow checks.
609 They weren't needed, since make_gap checks for buffer overflow.
610 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
611 The old code merely checked for Emacs fixnum overflow, and relied
612 on undefined (wraparound) behavior. The new code avoids undefined
613 behavior, and also checks for ptrdiff_t and/or size_t overflow.
614
2e6813b0 615 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
616 Tune. Don't use wider integers than needed. Don't use alloca.
617 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 618
599a9e4f
PE
619 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
620
99561444
PE
621 * insdel.c, lisp.h (buffer_overflow): New function.
622 (insert_from_buffer_1, replace_range, replace_range_2):
623 * insdel.c (make_gap_larger):
624 * editfns.c (Finsert_char):
625 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
626
28177add
PE
627 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
628
e69dafad
PE
6292011-06-15 Paul Eggert <eggert@cs.ucla.edu>
630
a7af7fde 631 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 632
b1c46f02
PE
633 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
634 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
635
e69dafad
PE
636 * fileio.c: Don't assume EMACS_INT fits in off_t.
637 (emacs_lseek): New static function.
638 (Finsert_file_contents, Fwrite_region): Use it.
639 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
640
566684ea
PE
641 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
642
e6966cd6
PE
643 * fns.c: Don't overflow int when computing a list length.
644 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
645 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
646 truncation on 64-bit hosts. Check for QUIT every
647 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
648 faster and is responsive enough.
649 (Flength): Report an error instead of overflowing an integer.
650 (Fsafe_length): Return a float if the value is not representable
651 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 652 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 653 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 654
dd0b0efb
PE
655 * alloc.c: Check that resized vectors' lengths fit in fixnums.
656 (header_size, word_size): New constants.
657 (allocate_vectorlike): Don't check size overflow here.
658 (allocate_vector): Check it here instead, since this is the only
659 caller of allocate_vectorlike that could cause overflow.
660 Check that the new vector's length is representable as a fixnum.
661
86fe5cfe
PE
662 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
663 The previous code was bogus. For example, next_almost_prime (32)
664 returned 39, which is undesirable as it is a multiple of 3; and
665 next_almost_prime (24) returned 25, which is a multiple of 5 so
666 why was the code bothering to check for multiples of 7?
667
80e88859
PE
668 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
669
4a2f0ad6
PE
670 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
671
f66c7cf8
PE
672 Variadic C functions now count arguments with ptrdiff_t.
673 This partly undoes my 2011-03-30 change, which replaced int with size_t.
674 Back then I didn't know that the Emacs coding style prefers signed int.
675 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
676 were being counted with int, which may truncate counts on 64-bit
677 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
678 * lisp.h (struct Lisp_Subr.function.aMANY)
679 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
680 Arg counts are now ptrdiff_t, not size_t.
681 All variadic functions and their callers changed accordingly.
682 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
683 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
684 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
685 * callint.c (Fcall_interactively): Check arg count for overflow,
686 to avoid potential buffer overrun. Use signed char, not 'int',
687 for 'varies' array, so that we needn't bother to check its size
688 calculation for overflow.
689 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
690 * eval.c (apply_lambda):
691 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
692 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
693 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
694
a1759b76
PE
695 * callint.c (Fcall_interactively): Don't use index var as event count.
696
d96be9fc
PE
697 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
698 * mem-limits.h (SIZE): Remove; no longer used.
699
a690a978 700 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 701
578c21e6
PE
702 Remove unnecessary casts.
703 * xterm.c (x_term_init):
704 * xfns.c (x_set_border_pixel):
705 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
706 These aren't needed now that we assume ANSI C.
707
96f53c6c
PE
708 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
709 It's more likely to cause problems (due to unsigned overflow)
710 than to cure them.
711
83c77d31
PE
712 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
713
ee2079f1
PE
714 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
715
6da65536
PE
716 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
717
7147c4a4
PE
718 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
719
193e32d9
PE
720 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
721
e5533da6
PE
722 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
723
9910e595
PE
724 GLYPH_CODE_FACE returns EMACS_INT, not int.
725 * dispextern.h (merge_faces):
726 * xfaces.c (merge_faces):
01103c44
PE
727 * xdisp.c (get_next_display_element, next_element_from_display_vector):
728 Don't assume EMACS_INT fits in int.
9910e595 729
2638320e
PE
730 * character.h (CHAR_VALID_P): Remove unused parameter.
731 * fontset.c, lisp.h, xdisp.c: All uses changed.
732
045eb8d9
PE
733 * editfns.c (Ftranslate_region_internal): Omit redundant test.
734
c1f134b5
PE
735 * fns.c (concat): Minor tuning based on overflow analysis.
736 This doesn't fix any bugs. Use int to hold character, instead
737 of constantly refetching from Emacs object. Use XFASTINT, not
738 XINT, for value known to be a character. Don't bother comparing
739 a single byte to 0400, as it's always less.
740
395fcb93 741 * floatfns.c (Fexpt):
327eeec8
PE
742 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
743
abbd3d23
PE
744 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
745 for characters.
746
684a03ef
PE
747 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
748
0fed43f3
PE
749 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
750 Without this fix, on a 64-bit host (aset S 0 4294967386) would
751 incorrectly succeed when S was a string, because 4294967386 was
752 truncated before it was used.
753
8fd02eb7
PE
754 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
755 Otherwise, an out-of-range integer could cause undefined behavior
756 on a 64-bit host.
757
f8c86b69
PE
758 * composite.c: Use int, not EMACS_INT, for characters.
759 (fill_gstring_body, composition_compute_stop_pos): Use int, not
760 EMACS_INT, for values that are known to be in character range.
761 This doesn't fix any bugs but is the usual style inside Emacs and
762 may generate better code on 32-bit machines.
763
34206dd2
PE
764 Make sure a 64-bit char is never passed to ENCODE_CHAR.
765 This is for reasons similar to the recent CHAR_STRING fix.
766 * charset.c (Fencode_char): Check that character arg is actually
767 a character. Pass an int to ENCODE_CHAR.
768 * charset.h (ENCODE_CHAR): Verify that the character argument is no
769 wider than 'int', as a compile-time check to prevent future regressions
770 in this area.
771
c5958d4c 772 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
773
774 Make sure a 64-bit char is never passed to CHAR_STRING.
775 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
776 by silently ignoring the top 32 bits, allowing some values
777 that were far too large to be valid characters.
778 * character.h: Include <verify.h>.
779 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
780 arguments are no wider than unsigned, as a compile-time check
781 to prevent future regressions in this area.
782 * data.c (Faset):
01103c44 783 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
784 (Fsubst_char_in_region):
785 * fns.c (concat):
786 * xdisp.c (decode_mode_spec_coding):
787 Adjust to CHAR_STRING's new requirement.
788 * editfns.c (Finsert_char, Fsubst_char_in_region):
789 * fns.c (concat): Check that character args are actually
790 characters. Without this test, these functions did the wrong
791 thing with wildly out-of-range values on 64-bit hosts.
792
d37ca623
PE
793 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
794 These casts should not be needed on 32-bit hosts, either.
795 * keyboard.c (read_char):
796 * lread.c (Fload): Remove casts to unsigned.
797
ea204efb
PE
798 * lisp.h (UNSIGNED_CMP): New macro.
799 This fixes comparison bugs on 64-bit hosts.
800 (ASCII_CHAR_P): Use it.
801 * casefiddle.c (casify_object):
01103c44 802 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
803 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
804 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
805 * dispextern.h (FACE_FROM_ID):
806 * keyboard.c (read_char): Use UNSIGNED_CMP.
807
41cb286c
PE
808 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
809 not to EMACS_INT, to avoid GCC warning.
810
4a1b9832
PE
811 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
812
55daad71
PE
813 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
814 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
815 isn't needed on 32-bit machines.
8f95c75c 816
01103c44
PE
817 * buffer.c (Fgenerate_new_buffer_name):
818 Use EMACS_INT for count, not int.
0ceccced 819 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
820
821 * data.c (Qcompiled_function): Now static.
822
c6f072e7
PE
823 * window.c (window_body_lines): Now static.
824
20ce5912
PE
825 * image.c (gif_load): Rename local to avoid shadowing.
826
9c4c5f81
PE
827 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
828 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
829 * alloc.c (make_save_value): Integer argument is now of type
830 ptrdiff_t, not int.
831 (mark_object): Use ptrdiff_t, not int.
832 * lisp.h (pD): New macro.
833 * print.c (print_object): Use it.
834
c0c5c8ae
PE
835 * alloc.c: Use EMACS_INT, not int, to count objects.
836 (total_conses, total_markers, total_symbols, total_vector_size)
837 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
838 (total_free_floats, total_floats, total_free_intervals)
839 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
840 Now EMACS_INT, not int. All uses changed.
841 (Fgarbage_collect): Compute overall total using a double, so that
842 integer overflow is less likely to be a problem. Check for overflow
843 when converting back to an integer.
5a25e253
PE
844 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
845 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
846 These were 'int' variables that could overflow on 64-bit hosts;
847 they were never used, so remove them instead of repairing them.
211a0b2a 848 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
849 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
850 Previously, this ceilinged at INT_MAX, but that doesn't work on
851 64-bit machines.
e46bb31a 852 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 853
c78baabf 854 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 855 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
856 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
857 when a (possibly-narrower) signed value would do just as well.
858 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 859
c9d624c6
PE
860 * alloc.c: Catch some string size overflows that we were missing.
861 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
862 for convenience in STRING_BYTES_MAX.
863 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
864 The definition here is exact; the one in lisp.h was approximate.
865 (allocate_string_data): Check for string overflow. This catches
866 some instances we weren't catching before. Also, it catches
867 size_t overflow on (unusual) hosts where SIZE_MAX <= min
868 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
869 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 870
c9d624c6
PE
871 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
872 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
873 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
874
353032ce
PE
875 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
876
2bccce07
PE
877 * alloc.c (Fmake_string): Check for out-of-range init.
878
0ac30604
SM
8792011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
880
881 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
882
c195f2de
JD
8832011-06-14 Jan Djärv <jan.h.d@swipnet.se>
884
885 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
886 xg_get_default_scrollbar_width.
887
888 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
889 (int_gtk_range_get_value): Move to the scroll bar part of the file.
890 (style_changed_cb): Call update_theme_scrollbar_width and call
891 x_set_scroll_bar_default_width and xg_frame_set_char_size for
892 all frames (Bug#8505).
893 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
894 Call gtk_window_set_resizable if HAVE_GTK3.
895 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
896 and height if HAVE_GTK3 (Bug#8505).
897 (scroll_bar_width_for_theme): New variable.
898 (update_theme_scrollbar_width): New function.
899 (xg_get_default_scrollbar_width): Move code to
900 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
901 (xg_initialize): Call update_theme_scrollbar_width.
902
903 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
904
905 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
906
e10ac9f1
MR
9072011-06-12 Martin Rudalics <rudalics@gmx.at>
908
909 * frame.c (make_frame): Call other_buffer_safely instead of
910 other_buffer.
911
912 * window.c (temp_output_buffer_show): Call display_buffer with
913 second argument Vtemp_buffer_show_specifiers and reset latter
914 immediately after the call.
915 (Vtemp_buffer_show_specifiers): New variable.
916 (auto_window_vscroll_p, next_screen_context_lines)
917 (Vscroll_preserve_screen_position): Remove leading asterisks from
918 doc-strings.
919
2d3c217e 9202011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 921
7b7f97e8 922 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
923 * buffer.c (Qclone_number): Remove for now, as it's unused.
924 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
925 (record_buffer): Remove unused local.
926 * frame.c (other_visible_frames, frame_buffer_list): Now static.
927 (set_frame_buffer_list): Remove; unused.
928 * frame.h (other_visible_frames): Remove decl.
929 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
930 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
931 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
932 if HAVE_GPM.
933 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
934 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
935 Define only if HAVE_GPM.
936 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
937 (update_hints_inhibit): Remove; never set. All uses removed.
938 * widgetprv.h (emacsFrameClassRec): Remove decl.
939 * window.c (delete_deletable_window): Now returns void, since it
940 wasn't returning anything.
941 (compare_window_configurations): Remove unused locals.
942 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
943 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
944 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
945 the same widths as pointers. This follows up on the 2011-05-06 patch.
946 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
947 * xterm.h: Likewise.
948 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
949
1384b89e
JB
9502011-06-12 Juanma Barranquero <lekktu@gmail.com>
951
952 * makefile.w32-in: Update dependencies.
953 (LISP_H): Add lib/intprops.h.
954
1100a63c
CY
9552011-06-11 Chong Yidong <cyd@stupidchicken.com>
956
957 * image.c (gif_load): Add animation frame delay to the metadata.
958 (syms_of_image): Use DEFSYM. New symbol `delay'.
959
6198ccd0
MR
9602011-06-11 Martin Rudalics <rudalics@gmx.at>
961
962 * window.c (delete_deletable_window): Re-add.
963 (Fset_window_configuration): Rewrite to handle dead buffers and
964 consequently deletable windows.
965 (window_tree, Fwindow_tree): Remove. Supply functionality in
966 window.el.
967 (compare_window_configurations): Simplify code.
968
b6e3633c
AS
9692011-06-11 Andreas Schwab <schwab@linux-m68k.org>
970
1ab0dee5
AS
971 * image.c (imagemagick_load_image): Fix type mismatch.
972 (Fimagemagick_types): Likewise.
973
b6e3633c
AS
974 * window.h (replace_buffer_in_windows): Declare.
975
9397e56f
MR
9762011-06-11 Martin Rudalics <rudalics@gmx.at>
977
978 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
979 Qclone_number. Remove external declaration of Qdelete_window.
980 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
981 code.
982 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
983 Qbuffer_list_update_hook if allowed.
984 (Fother_buffer): Rewrite doc-string. Major rewrite for new
985 buffer list implementation.
986 (other_buffer_safely): New function.
987 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
988 calls to replace_buffer_in_windows and
989 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
990 if allowed.
991 (record_buffer): Inhibit quitting and rewrite using quittable
992 functions. Run Qbuffer_list_update_hook if allowed.
993 (Frecord_buffer, Funrecord_buffer): New functions.
994 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
995 switch-to-buffer to window.el.
996 (bury-buffer): Move to window.el.
997 (Vbuffer_list_update_hook): New variable.
998
999 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1000 section.
1001
1002 * window.h (resize_frame_windows): Move up in code.
1003 (Fwindow_frame): Remove EXFUN.
1004 (replace_buffer_in_all_windows): Remove prototype.
1005 (replace_buffer_in_windows_safely): Add prototype.
1006
1007 * window.c: Declare Qdelete_window static again. Move down
1008 declaration of select_count.
1009 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1010 (Fother_window): Move to window.el.
1011 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1012 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1013 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1014 window.el.
1015 (replace_buffer_in_windows): Implement by calling
1016 Qreplace_buffer_in_windows.
1017 (replace_buffer_in_all_windows): Remove with some functionality
1018 moved into replace_buffer_in_windows_safely.
1019 (replace_buffer_in_windows_safely): New function.
1020 (select_window_norecord, select_frame_norecord): Move in front
1021 of run_window_configuration_change_hook. Remove now obsolete
1022 declarations.
1023 (Fset_window_buffer): Rewrite doc-string. Call
1024 Qrecord_window_buffer.
1025 (keys_of_window): Move binding for other-window to window.el.
1026
b50691aa
CY
10272011-06-11 Chong Yidong <cyd@stupidchicken.com>
1028
1029 * dispextern.h (struct image): Replace data member, whose int_val
1030 and ptr_val fields were not used by anything, with a single
1031 lisp_val object.
1032
1033 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1034 (gif_clear_image, gif_load, imagemagick_load_image)
1035 (gs_clear_image, gs_load): Callers changed.
1036
3f754b86
PE
10372011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1038
cca69397
PE
1039 * buffer.h: Include <time.h>, for time_t.
1040 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1041
109e28d0
PE
1042 Fix minor problems found by static checking.
1043
60737f02
PE
1044 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1045
4b66faf3
PE
1046 Make identifiers static if they are not used in other modules.
1047 * data.c (Qcompiled_function, Qframe, Qvector):
1048 * image.c (QimageMagick, Qsvg):
1049 * minibuf.c (Qmetadata):
1050 * window.c (resize_window_check, resize_root_window): Now static.
1051 * window.h (resize_window_check, resize_root_window): Remove decls.
1052
109e28d0
PE
1053 * window.c (window_deletion_count, delete_deletable_window):
1054 Remove; unused.
46a4ce9e
PE
1055 (window_body_lines): Now static.
1056 (Fdelete_other_windows_internal): Mark vars as initialized.
1057 Make sure 'resize_failed' is initialized.
1058 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1059 (resize_window_apply): Remove unused local.
1060 * window.h (delete_deletable_window): Remove decl.
1061
109e28d0 1062 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1063 (imagemagick_load_image): Fix pointer signedness problem by changing
1064 last arg from unsigned char * to char *. All uses changed.
1065 Also, fix a local for similar reasons.
1066 Remove unused locals. Remove locals to avoid shadowing.
1067 (fn_rsvg_handle_free): Remove; unused.
1068 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1069 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1070
3f754b86
PE
1071 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1072
2547adb1
CY
10732011-06-10 Chong Yidong <cyd@stupidchicken.com>
1074
1075 * image.c (gif_load): Fix omitted cast error introduced by
1076 2011-06-06 change.
1077
2c8e37d4
MR
10782011-06-10 Martin Rudalics <rudalics@gmx.at>
1079
1080 * window.h (resize_proportionally, orig_total_lines)
1081 (orig_top_line): Remove from window structure.
1082 (set_window_height, set_window_width, change_window_heights)
1083 (Fdelete_window): Remove prototypes.
1084 (resize_frame_windows): Remove duplicate declaration.
1085
440a42e3
EZ
10862011-06-10 Eli Zaretskii <eliz@gnu.org>
1087
1088 * window.h (resize_frame_windows, resize_window_check)
1089 (delete_deletable_window, resize_root_window)
1090 (resize_frame_windows): Declare prototypes.
1091
1092 * window.c (resize_window_apply): Make definition be "static" to
1093 match the prototype.
1094
562dd5e9
MR
10952011-06-10 Martin Rudalics <rudalics@gmx.at>
1096
1097 * window.c: Remove declarations of Qwindow_size_fixed,
1098 window_min_size_1, window_min_size_2, window_min_size,
1099 size_window, window_fixed_size_p, enlarge_window, delete_window.
1100 Remove static from declaration of Qdelete_window, it's
1101 temporarily needed by Fbury_buffer.
1102 (replace_window): Don't assign orig_top_line and
1103 orig_total_lines.
1104 (Fdelete_window, delete_window): Remove. Window deletion is
1105 handled by window.el.
1106 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1107 Fdelete_window calls with calls to Qdelete_window.
1108 (Fdelete_other_windows): Remove. Deleting other windows is
1109 handled by window.el.
1110 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1111 handled in window.el.
1112 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1113 Window minimum sizes are handled in window.el.
1114 (shrink_windows, size_window, set_window_height)
1115 (set_window_width, change_window_heights, window_height)
1116 (window_width, CURBEG, CURSIZE, enlarge_window)
1117 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1118 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1119 handled in window.el.
1120 (make_dummy_parent): Rename to make_parent_window and give it a
1121 second argument horflag.
1122 (make_window): Don't set resize_proportionally any more.
1123 (Fsplit_window): Remove. Windows are split in window.el.
1124 (save_restore_action, save_restore_orig_size)
1125 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1126 Resize mini windows in window.el.
1127 (grow_mini_window, shrink_mini_window): Implement by calling
1128 Qresize_root_window_vertically, resize_window_check and
1129 resize_window_apply.
1130 (saved_window, Fset_window_configuration, save_window_save): Do
1131 not handle orig_top_line, orig_total_lines, and
1132 resize_proportionally.
1133 (window_min_height, window_min_width): Move to window.el.
1134 (keys_of_window): Move bindings for delete-other-windows,
1135 split-window, delete-window and enlarge-window to window.el.
1136
1137 * buffer.c: Temporarily extern Qdelete_window.
1138 (Fbury_buffer): Temporarily call Qdelete_window instead of
1139 Fdelete_window (Fbury_buffer will move to window.el soon).
1140
1141 * frame.c (set_menu_bar_lines_1): Remove code handling
1142 orig_top_line and orig_total_lines.
1143
1144 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1145 set_window_height but set heights directly.
1146 (change_frame_size_1): Use resize_frame_windows.
1147
1148 * xdisp.c (init_xdisp): Don't use set_window_height but set
1149 heights directly.
1150
1151 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1152 resize_frame_windows instead of change_window_heights and run
1153 run_window_configuration_change_hook.
1154
1155 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1156 instead of change_window_heights and run
1157 run_window_configuration_change_hook.
1158
1a13852e
MR
11592011-06-09 Martin Rudalics <rudalics@gmx.at>
1160
1161 * window.c (replace_window): Rename second argument REPLACEMENT to
1162 NEW. New third argument SETFLAG. Rewrite.
1163 (delete_window, make_dummy_parent): Call replace_window with
1164 third argument 1.
1165 (window_list_1): Move down in code.
1166 (run_window_configuration_change_hook): Move set_buffer part
1167 before select_frame_norecord part in order to unwind correctly.
1168 Rename count1 to count.
1169 (recombine_windows, delete_deletable_window, resize_root_window)
1170 (Fdelete_other_windows_internal)
1171 (Frun_window_configuration_change_hook, make_parent_window)
1172 (resize_window_check, resize_window_apply, Fresize_window_apply)
1173 (resize_frame_windows, Fsplit_window_internal)
1174 (Fdelete_window_internal, Fresize_mini_window_internal): New
1175 functions.
1176 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1177
f3d1777e
MR
11782011-06-08 Martin Rudalics <rudalics@gmx.at>
1179
496e208e
MR
1180 * window.h (window): Add some new members to window structure -
1181 normal_lines, normal_cols, new_total, new_normal, clone_number,
1182 splits, nest, prev_buffers, next_buffers.
1183 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1184 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1185
f3d1777e
MR
1186 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1187 Remove.
496e208e
MR
1188 (make_dummy_parent): Set new members of windows structure.
1189 (make_window): Move down in code. Handle new members of window
1190 structure.
1191 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1192 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1193 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1194 (Fset_window_prev_buffers, Fwindow_next_buffers)
1195 (Fset_window_next_buffers, Fset_window_clone_number): New
1196 functions.
1197 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1198 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1199 Doc-string fixes.
1200 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1201 Argument WINDOW can be now internal window too.
1202 (Fwindow_use_time): Move up in code.
1203 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1204 Rewrite doc-string.
1205 (Fset_window_configuration, saved_window)
1206 (Fcurrent_window_configuration, save_window_save): Handle new
1207 members of window structure.
b9e809c2
MR
1208 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1209 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1210 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1211 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1212 Qget_mru_window, Qresize_root_window,
1213 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1214 Qauto_buffer_name; staticpro them.
f3d1777e 1215
abde8f8c
MR
12162011-06-07 Martin Rudalics <rudalics@gmx.at>
1217
1218 * window.c (Fwindow_total_size, Fwindow_left_column)
1219 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1220 (Fwindow_list_1): New functions.
1221 (window_box_text_cols): Replace with window_body_cols.
1222 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1223 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1224 (delete_window, Fset_window_configuration): Call
1225 delete_all_subwindows with window as argument.
1226 (delete_all_subwindows): Take a window as argument and not a
1227 structure. Rewrite.
190b47e6
MR
1228 (window_loop): Remove handling of GET_LRU_WINDOW and
1229 GET_LARGEST_WINDOW.
1230 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1231
1232 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1233 window_box_text_cols. delete_all_subwindows now takes a
1234 Lisp_Object as argument.
abde8f8c
MR
1235
1236 * indent.c (compute_motion, Fcompute_motion): Use
1237 window_body_cols instead of window_box_text_cols.
1238
fa8a67e6
MR
1239 * frame.c (delete_frame): Call delete_all_subwindows with root
1240 window as argument.
1241
a54e3482
DC
12422011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1243
1244 * fns.c (Fputhash): Document return value.
1245
60002bf5
CY
12462011-06-06 Chong Yidong <cyd@stupidchicken.com>
1247
1248 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1249
0c671da6 12502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1251
b862a52a 1252 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1253
be44ca6c
PE
1254 Check for overflow when converting integer to cons and back.
1255 * charset.c (Fdefine_charset_internal, Fdecode_char):
1256 Use cons_to_unsigned to catch overflow.
1257 (Fencode_char): Use INTEGER_TO_CONS.
1258 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1259 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1260 * data.c (long_to_cons, cons_to_long): Remove.
1261 (cons_to_unsigned, cons_to_signed): New functions.
1262 These signal an error for invalid or out-of-range values.
1263 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1264 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1265 * font.c (Ffont_variation_glyphs):
1266 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1267 * lisp.h: Include <intprops.h>.
1268 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1269 (cons_to_signed, cons_to_unsigned): New decls.
1270 (long_to_cons, cons_to_long): Remove decls.
1271 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1272 (Fprimitive_undo): Use CONS_TO_INTEGER.
1273 * xfns.c (Fx_window_property): Likewise.
1274 * xselect.c: Include <limits.h>.
1275 (x_own_selection, selection_data_to_lisp_data):
1276 Use INTEGER_TO_CONS.
1277 (x_handle_selection_request, x_handle_selection_clear)
1278 (x_get_foreign_selection, Fx_disown_selection_internal)
1279 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1280 (lisp_data_to_selection_data): Use cons_to_unsigned.
1281 (x_fill_property_data): Use cons_to_signed.
1282 Report values out of range.
1283
d1f3d2af
PE
1284 Check for buffer and string overflow more precisely.
1285 * buffer.h (BUF_BYTES_MAX): New macro.
1286 * lisp.h (STRING_BYTES_MAX): New macro.
1287 * alloc.c (Fmake_string):
1288 * character.c (string_escape_byte8):
1289 * coding.c (coding_alloc_by_realloc):
1290 * doprnt.c (doprnt):
1291 * editfns.c (Fformat):
1292 * eval.c (verror):
1293 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1294 since they may not be the same number.
1295 * editfns.c (Finsert_char):
1296 * fileio.c (Finsert_file_contents):
1297 Likewise for BUF_BYTES_MAX.
1298
dd52fcea
PE
1299 * image.c: Use ptrdiff_t, not int, for sizes.
1300 (slurp_file): Switch from int to ptrdiff_t.
1301 All uses changed.
1302 (slurp_file): Check that file size fits in both size_t (for
1303 malloc) and ptrdiff_t (for sanity and safety).
1304
7f9bbdbb
PE
1305 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1306 if b->modtime has its maximal value.
1307
dfe18f82
PE
1308 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1309
84acfcf0
PE
1310 Don't assume time_t can fit into int.
1311 * buffer.h (struct buffer.modtime): Now time_t, not int.
1312 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1313 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1314
ccd9a01a
PE
1315 Minor fixes for signed vs unsigned integers.
1316 * character.h (MAYBE_UNIFY_CHAR):
1317 * charset.c (maybe_unify_char):
1318 * keyboard.c (read_char, reorder_modifiers):
1319 XINT -> XFASTINT, since the integer must be nonnegative.
1320 * ftfont.c (ftfont_spec_pattern):
1321 * keymap.c (access_keymap, silly_event_symbol_error):
1322 XUINT -> XFASTINT, since the integer must be nonnegative.
1323 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1324 since it makes no difference and we prefer signed.
1325 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1326 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1327 nonnegative.
1328
d6d100dd
SM
13292011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1330
1331 * window.h (Fwindow_frame): Declare.
1332
2b6148e4
PE
13332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1334
1335 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1336 (SPARE_MEMORY): Always define.
1337 (LARGE_REQUEST): Remove.
1338 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1339
f230ecc9
MR
13402011-06-06 Martin Rudalics <rudalics@gmx.at>
1341
727e958e
MR
1342 * lisp.h: Move EXFUNS for Fframe_root_window,
1343 Fframe_first_window and Fset_frame_selected_window to window.h.
1344
1345 * window.h: Move EXFUNS for Fframe_root_window,
1346 Fframe_first_window and Fset_frame_selected_window here from
1347 lisp.h.
1348
1349 * frame.c (Fwindow_frame, Fframe_first_window)
1350 (Fframe_root_window, Fframe_selected_window)
1351 (Fset_frame_selected_window): Move to window.c.
1352 (Factive_minibuffer_window): Move to minibuf.c.
1353 (Fother_visible_frames_p): New function.
1354
1355 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1356
f230ecc9
MR
1357 * window.c (decode_window, decode_any_window): Move up in code.
1358 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1359 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1360 (Fwindow_buffer): Move up and rewrite doc-string.
1361 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1362 (Fwindow_prev): New functions.
727e958e
MR
1363 (Fwindow_frame): Move here from frame.c. Accept any window as
1364 argument.
1365 (Fframe_root_window, Fframe_first_window)
1366 (Fframe_selected_window): Move here from frame.c. Accept frame
1367 or arbitrary window as argument. Update doc-strings.
1368 (Fminibuffer_window): Move up in code.
1369 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1370 (Fset_frame_selected_window): Move here from frame.c.
1371 Marginal rewrite.
727e958e
MR
1372 (Fselected_window, select_window, Fselect_window): Move up in
1373 code. Minor doc-string fixes.
f230ecc9 1374
4d09bcf6
PE
13752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1376
1377 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1378 Do not assume that spare memory exists; that assumption is valid
1379 only if SYSTEM_MALLOC.
1380 (LARGE_REQUEST): New macro, so that the issue of large requests
1381 is separated from the issue of spare memory.
1382
810928a2
AS
13832011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1384
172418ad
AS
1385 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1386 format. (Bug#8806)
1387
43f862f7
AS
1388 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1389
810928a2
AS
1390 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1391 before statements.
1392
a059fe24
JD
13932011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1394
1395 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1396
1397 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1398
1399 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1400 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1401
989bf368
JB
14022011-06-05 Juanma Barranquero <lekktu@gmail.com>
1403
1404 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1405
4b80f674
CY
14062011-06-04 Chong Yidong <cyd@stupidchicken.com>
1407
1408 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1409 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1410 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1411 New error handlers.
4b80f674
CY
1412 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1413 Obey Vx_select_enable_clipboard_manager. Catch errors in
1414 x_clipboard_manager_save (Bug#8779).
1415 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1416 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1417
99a33b77 14182011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1419
1420 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1421
99a33b77 14222011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1423
1424 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1425 in the current matrix if keep_current_p is non-zero.
1426
8264569d
EZ
14272011-06-04 Eli Zaretskii <eliz@gnu.org>
1428
1429 * bidi.c (bidi_level_of_next_char): Fix last change.
1430
57f97249
EZ
14312011-06-03 Eli Zaretskii <eliz@gnu.org>
1432
fec2107c 1433 Support bidi reordering of text covered by display properties.
57f97249 1434
fec2107c
EZ
1435 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1436 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1437 (bidi_cache_search, bidi_cache_iterator_state)
1438 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1439 (bidi_level_of_next_char, bidi_move_to_visually_next):
1440 Support character positions inside a run of characters covered by a
fec2107c
EZ
1441 display string.
1442 (bidi_paragraph_init, bidi_resolve_explicit_1)
1443 (bidi_level_of_next_char): Call bidi_fetch_char and
1444 bidi_fetch_char_advance instead of FETCH_CHAR and
1445 FETCH_CHAR_ADVANCE.
1446 (bidi_init_it): Initialize new members.
1447 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1448 definitions.
1449 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1450 instead of using explicit *_CHAR codes.
d6d100dd
SM
1451 (bidi_resolve_explicit, bidi_resolve_weak):
1452 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1453 bidirectional text is supported only in multibyte buffers.
1454 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1455 it to initialize the frame_window_p member of struct bidi_it.
1456 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1457 (bidi_resolve_explicit, bidi_resolve_weak)
1458 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1459 bidi_it->nchars is non-positive.
1460 (bidi_level_of_next_char): Don't try to lookup the cache for the
1461 next/previous character if nothing is cached there yet, or if we
1462 were just reseat()'ed to a new position.
c40e2fb2 1463
0e14fe90
EZ
1464 * xdisp.c (set_cursor_from_row): Set start and stop points
1465 according to the row's direction when priming the loop that looks
1466 for the glyph on which to display cursor.
1467 (single_display_spec_intangible_p): Function deleted.
1468 (display_prop_intangible_p): Reimplement to call
1469 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1470 Accept 3 additional arguments needed by handle_display_spec.
1471 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1472 values: lists, `(when COND...)' forms, etc.
1473 (single_display_spec_string_p): Support property values that are
1474 lists with the argument STRING its top-level element.
1475 (display_prop_string_p): Fix the condition for processing a
1476 property that is a list to be consistent with handle_display_spec.
fec2107c 1477 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1478 last portion of handle_display_prop.
1479 (compute_display_string_pos): Accept additional argument
1480 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1481 value of a `display' property is a "replacing spec".
1482 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1483 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1484 the display property, but just return a value indicating whether
1485 the display property will replace the characters it covers.
1486 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1487 frame_window_p members of struct bidi_it.
d6d100dd
SM
1488 (compute_display_string_pos, compute_display_string_end):
1489 New functions.
fec2107c
EZ
1490 (push_it): Accept second argument POSITION, where pop_it should
1491 jump to continue iteration.
1492 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1493
fec2107c
EZ
1494 * keyboard.c (adjust_point_for_property): Adjust the call to
1495 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1496
1497 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1498 (bidi_init_it): Update prototypes.
1499 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1500 (compute_display_string_pos, compute_display_string_end):
1501 Declare prototypes.
fec2107c
EZ
1502 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1503 EMACS_INT.
fc6f18ce 1504
40087514 15052011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1506
57f53182
PE
1507 Malloc failure behavior now depends on size of allocation.
1508 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1509 * lisp.h: Change signatures accordingly.
1510 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1511 All callers changed. (Bug#8762)
1512
1513 * gnutls.c: Use Emacs's memory allocators.
1514 Without this change, the gnutls library would invoke malloc etc.
1515 directly, which causes problems on non-SYNC_INPUT hosts, and which
1516 runs afoul of improving memory_full behavior. (Bug#8761)
1517 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1518 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1519 xfree instead of the default malloc, realloc, free.
1520 (Fgnutls_boot): No need to check for memory allocation failure,
1521 since xmalloc does that for us.
1522
ac32cd99 1523 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1524 * category.c (hash_get_category_set):
1525 * ccl.c (ccl_driver):
1526 * charset.c (Fdefine_charset_internal):
1527 * charset.h (struct charset.hash_index):
1528 * composite.c (get_composition_id, gstring_lookup_cache)
1529 (composition_gstring_put_cache):
1530 * composite.h (struct composition.hash_index):
1531 * dispextern.h (struct image.hash):
1532 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1533 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1534 (hashfn_equal, hashfn_user_defined, make_hash_table)
1535 (maybe_resize_hash_table, hash_lookup, hash_put)
1536 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1537 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1538 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1539 * image.c (make_image, search_image_cache, lookup_image)
1540 (xpm_put_color_table_h):
1541 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1542 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1543 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1544 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1545 * alloc.c (allocate_vectorlike):
1546 Check for overflow in vector size calculations.
1547 * ccl.c (ccl_driver):
1548 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1549 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1550 need to be updated by these changes.
40087514
PE
1551 * fns.c (make_hash_table, maybe_resize_hash_table):
1552 Check for integer overflow with large hash tables.
0de4bb68
PE
1553 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1554 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1555 (SXHASH_REDUCE): New macro.
1556 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1557 Use it instead of discarding useful hash info with large hash values.
1558 (sxhash_float): New function.
1559 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1560 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1561 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1562 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1563 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1564 Adjust signatures to match updated version of code.
1565 (consing_since_gc): Now EMACS_INT, since a single hash table can
1566 use more than INT_MAX bytes.
1567
698d32e2
DN
15682011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1569
1570 Make it possible to build with GCC-4.6+ -O2 -flto.
1571
1572 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1573
fd6fa53f
SM
15742011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1575
1576 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1577 Call minibuffer-inactive-mode.
1578
864db017
JB
15792011-05-31 Juanma Barranquero <lekktu@gmail.com>
1580
1581 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1582 Update dependencies.
1583
2ad0baf4
DN
15842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1585
1586 * data.c (init_data): Remove code for UTS, this system is not
1587 supported anymore.
1588
4fcc2638
DN
15892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1590
1591 Don't force ./temacs to start in terminal mode.
1592
1593 * frame.c (make_initial_frame): Initialize faces in all cases, not
1594 only when CANNOT_DUMP is defined.
1595 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1596
c56e0fd5
DN
15972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1598
1599 * dispnew.c (add_window_display_history): Use const for the string
1600 pointer. Remove declaration, not needed.
1601
333d54da 16022011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1603
55d4c1b2 1604 Use 'inline', not 'INLINE'.
333d54da 1605 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1606 * alloc.c, fontset.c (INLINE): Remove.
1607 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1608 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1609 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1610 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1611 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1612
738db178
DN
16132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1614
1615 Make it possible to run ./temacs.
1616
1617 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1618 syms_of_callproc does the same thing. Remove test for
1619 "initialized", do it in the caller.
1620 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1621
620c53a6
SM
16222011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1623
1624 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1625 (read_minibuf): Use get_minibuffer.
1626 (syms_of_minibuf): Use DEFSYM.
1627 (Qmetadata): New var.
1628 * data.c (Qbuffer): Don't make it static.
1629 (syms_of_data): Use DEFSYM.
1630
e003a292
PE
16312011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1632
1633 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1634 (CCL_CODE_MIN): New macro.
1635
ed008a6d
PE
16362011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1637
3687c2ef
PE
1638 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1639
ed008a6d
PE
1640 * eval.c (Qdebug): Now static.
1641 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1642 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1643 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1644
d66c4c7c
CY
16452011-05-29 Chong Yidong <cyd@stupidchicken.com>
1646
1647 * image.c: Various fixes to ImageMagick code comments.
1648 (Fimagemagick_types): Doc fix.
1649
5fbc2025
PE
16502011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1651
0196f88a
PE
1652 Minor fixes prompted by GCC 4.6.0 warnings.
1653
1654 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1655
5fbc2025
PE
1656 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1657 (x_clipboard_manager_save_all): Move extern decl to ...
1658 * xterm.h: ... here, so that it can be checked for consistency.
1659
1dd3c2d9
CY
16602011-05-29 Chong Yidong <cyd@stupidchicken.com>
1661
1662 * xselect.c (x_clipboard_manager_save_frame)
1663 (x_clipboard_manager_save_all): New functions.
1664 (Fx_clipboard_manager_save): Lisp function deleted.
1665
1666 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1667 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1668
1669 * xterm.h: Update prototype.
1670
5ba6571d
WX
16712011-05-28 William Xu <william.xwl@gmail.com>
1672
1673 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1674 exiting (Bug#8239).
1675
3eaff834
JM
16762011-05-28 Jim Meyering <meyering@redhat.com>
1677
e1900994 1678 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1679 * fns.c (to_uchar): Define.
1680 (crypto_hash_function): Use it to convert some newly-signed
1681 variables to unsigned, to avoid sign-extension bugs. For example,
1682 without this change, (md5 "truc") would evaluate to
1683 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1684 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1685 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1686
0f6990a7
PE
16872011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1688
1689 Integer overflow fixes.
c8a9ca5a 1690
08686060
PE
1691 * dbusbind.c: Serial number integer overflow fixes.
1692 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1693 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1694 to hold a serial number that is too large for a fixnum.
1695 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1696 Check for serial numbers out of range. Decode any serial number
59568bf0 1697 that was so large that it became a float. (Bug#8722)
08686060 1698
2d1fc3c7
PE
1699 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1700 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1701 Use XFASTINT rather than XUINT when numbers are nonnegative.
1702 (xd_append_arg, Fdbus_method_return_internal):
1703 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1704 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1705 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1706 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1707 (Bug#8722)
2d1fc3c7 1708
c8a9ca5a
PE
1709 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1710
519e1d69
PE
1711 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1712
30569699
PE
1713 ccl: add integer overflow checks
1714 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1715 (IN_INT_RANGE): New macros.
1716 (ccl_driver): Use them to check for integer overflow when
1717 decoding a CCL program. Many of the new checks are whether XINT (x)
1718 fits in int; it doesn't always, on 64-bit hosts. The new version
1719 doesn't catch all possible integer overflows, but it's an
847044ea 1720 improvement. (Bug#8719)
30569699 1721
c11285dc
PE
1722 * alloc.c (make_event_array): Use XINT, not XUINT.
1723 There's no need for unsigned here.
1724
fdccd48e
PE
1725 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1726 This follows up to the 2011-05-06 change that substituted uintptr_t
1727 for EMACS_INT. This case wasn't caught back then.
1728
37910ab2
PE
1729 Rework Fformat to avoid integer overflow issues.
1730 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1731 now (part of C89). Include <verify.h>.
1732 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1733 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1734 (Fformat): Avoid the prepass trying to compute sizes; it was only
1735 approximate and thus did not catch overflow reliably. Instead, walk
1736 through the format just once, formatting and computing sizes as we go,
1737 checking for integer overflow at every step, and allocating a larger
1738 buffer as needed. Keep track separately whether the format is
1739 multibyte. Keep only the most-recently calculated precision, rather
1740 than them all. Record whether each argument has been converted to
1741 string. Use EMACS_INT, not int, for byte and char and arg counts.
1742 Support field widths and precisions larger than INT_MAX. Avoid
1743 sprintf's undefined behavior with conversion specifications such as %#d
1744 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1745 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1746 formatting out-of-range floating point numbers with int
1747 formats. (Bug#8668)
1748
2e6578fb
PE
1749 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1750
0ae6bdee
PE
1751 * data.c: Avoid integer truncation in expressions involving floats.
1752 * data.c: Include <intprops.h>.
1753 (arith_driver): When there's an integer overflow in an expression
1754 involving floating point, convert the integers to floating point
1755 so that the resulting value does not suffer from catastrophic
1756 integer truncation. For example, on a 64-bit host (* 4
1757 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1758 Do not rely on undefined behavior after integer overflow.
1759
de883a70
PE
1760 merge count_size_as_multibyte, parse_str_to_multibyte
1761 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1762 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1763 Check for integer overflow.
1764 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1765 since it's now a duplicate of the other. This is more of
1766 a character than a buffer op, so better that it's in character.c.
1767 * fns.c, print.c: Adjust to above changes.
1768
2ff916cb
PE
17692011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1770
1771 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1772
f1b54466
PE
17732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1774
fb1ac845
PE
1775 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1776 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1777 (x_clipboard_manager_save): Now static.
1778 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1779
f1b54466
PE
1780 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1781 (crypto_hash_function): Now static.
1782 Fix pointer signedness problems. Avoid unnecessary initializations.
1783
a9f737ee
CY
17842011-05-27 Chong Yidong <cyd@stupidchicken.com>
1785
1786 * termhooks.h (Vselection_alist): Make it terminal-local.
1787
1788 * terminal.c (create_terminal): Initialize it.
1789
1790 * xselect.c: Support for clipboard managers.
1791 (Vselection_alist): Move to termhooks.h as terminal-local var.
1792 (LOCAL_SELECTION): New macro.
1793 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1794 (symbol_to_x_atom): Remove gratuitous arg.
1795 (x_handle_selection_request, lisp_data_to_selection_data)
1796 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1797 (x_own_selection, x_get_local_selection, x_convert_selection):
1798 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1799 (some_frame_on_display): Delete unused function.
1800 (Fx_own_selection_internal, Fx_get_selection_internal)
1801 (Fx_disown_selection_internal, Fx_selection_owner_p)
1802 (Fx_selection_exists_p): New optional frame arg.
1803 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1804 (x_handle_selection_clear): Don't treat other terminals with the
1805 same keyboard specially. Use the terminal-local Vselection_alist.
1806 (x_clear_frame_selections): Use Frun_hook_with_args.
1807
1808 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1809
1810 * xterm.h: Add support for those atoms.
1811
e067f0c1
CY
18122011-05-26 Chong Yidong <cyd@stupidchicken.com>
1813
1814 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1815 (converted_selections, conversion_fail_tag): New global variables.
1816 (x_selection_request_lisp_error): Free the above.
1817 (x_get_local_selection): Remove unnecessary code.
1818 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1819 of converted selections stored in converted_selections.
1820 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1821 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1822 (x_convert_selection): New function.
1823 (x_handle_selection_event): Simplify.
1824 (x_get_foreign_selection): Don't ignore incoming requests while
1825 waiting for an answer; this will fail when we implement
1826 SAVE_TARGETS, and seems unnecessary anyway.
1827 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1828 (Vx_sent_selection_functions): Doc fix.
1829
0f4aebc0
LL
18302011-05-26 Leo Liu <sdl.web@gmail.com>
1831
1832 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1833
e61124cd
YM
18342011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1835
1836 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1837
1838 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1839 for fringe update if it has periodic bitmap.
1840 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1841 and fringe_bitmap_periodic_p.
1842
1843 * fringe.c (get_fringe_bitmap_data): New function.
1844 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1845 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1846 row. Mark glyph row for fringe update if periodicity changed.
1847
1848 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1849 for fringe update unless it has periodic bitmap.
1850
f16d9837
KH
18512011-05-25 Kenichi Handa <handa@m17n.org>
1852
1853 * xdisp.c (get_next_display_element): Set correct it->face_id for
1854 a static composition.
1855
e1b90ef6
LL
18562011-05-24 Leo Liu <sdl.web@gmail.com>
1857
1858 * deps.mk (fns.o):
1859 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1860
1861 * fns.c (crypto_hash_function, Fsha1): New function.
1862 (Fmd5): Use crypto_hash_function.
1863 (syms_of_fns): Add Ssha1.
1864
7400048f
PE
18652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 * gnutls.c: Remove unused macros.
1868 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1869 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1870 Remove macros that are defined and never used.
1871 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1872
abb71cf4
CY
18732011-05-22 Chong Yidong <cyd@stupidchicken.com>
1874
1875 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1876 (Fx_get_selection_internal): Minor cleanup.
1877 (Fx_own_selection_internal): Rename arguments for consistency with
1878 select.el.
1879
6307db39
PE
18802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1881
1882 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1883
f3d4e0a4
CY
18842011-05-22 Chong Yidong <cyd@stupidchicken.com>
1885
1886 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1887
4d8ade89
YM
18882011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1889
1890 * dispnew.c (scrolling_window): Don't exclude the case that the
1891 last enabled row in the desired matrix touches the bottom boundary.
1892
32078c8d
GM
18932011-05-21 Glenn Morris <rgm@gnu.org>
1894
1895 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1896 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1897 and add some more files.
32078c8d 1898
7285dc67
EZ
18992011-05-20 Eli Zaretskii <eliz@gnu.org>
1900
1901 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1902 report_file_error introduced by the change from 2011-05-07.
1903
89d1bd22
PE
19042011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1905
1906 * systime.h (Time): Define only if emacs is defined.
1907 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1908 where the include path doesn't have X11/X.h by default. See
1909 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1910
e23640bb 19112011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1912
1913 * composite.c (find_automatic_composition): Fix previous change.
1914
b9704ad9
GM
19152011-05-20 Glenn Morris <rgm@gnu.org>
1916
1917 * lisp.mk: New file, split from Makefile.in.
1918 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1919 (shortlisp): Remove.
1920 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1921
4a720484
GM
19222011-05-19 Glenn Morris <rgm@gnu.org>
1923
1924 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1925 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1926 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1927 (lisp): Set the order to that of loadup.el.
1928 (shortlisp): Make it a copy of $lisp.
1929 (SOME_MACHINE_LISP): Remove.
1930 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1931 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1932
a28d4396
KH
19332011-05-18 Kenichi Handa <handa@m17n.org>
1934
1935 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1936 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1937 (find_automatic_composition): Mostly rewrite for efficiency.
1938
a2b1fa8e
JB
19392011-05-18 Juanma Barranquero <lekktu@gmail.com>
1940
1941 * makefile.w32-in: Update dependencies.
1942
8e1f5610
CS
19432011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1944
1945 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1946 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1947
7025ee00 19482011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1949
cdfa6eab
PE
1950 Fix some integer overflow issues, such as string length overflow.
1951
06d6db33
PE
1952 * insdel.c (count_size_as_multibyte): Check for string overflow.
1953
2b4560a8
PE
1954 * character.c (lisp_string_width): Check for string overflow.
1955 Use EMACS_INT, not int, for string indexes and lengths; in
1956 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1957 the resulting string length overflows an EMACS_INT; instead,
1958 report a string overflow if no precision given. When checking for
1959 precision exhaustion, use a check that cannot possibly have
1960 integer overflow. (Bug#8675)
1961 * character.h (lisp_string_width): Adjust to new signature.
1962
cb93f9be
PE
1963 * alloc.c (string_overflow): New function.
1964 (Fmake_string): Use it. This doesn't change behavior, but saves
1965 a few bytes and will simplify future changes.
1966 * character.c (string_escape_byte8): Likewise.
1967 * lisp.h (string_overflow): New decl.
1968
1a1f3366
PE
1969 Fixups, following up to the user-interface timestamp change.
1970 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1971 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1972 * msdos.c (mouse_get_pos): Likewise.
1973 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1974 * w32gui.h (Time): Define by including "systime.h" rather than by
1975 declaring it ourselves. (Bug#8664)
1976
d4e3e4d3
PE
1977 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1978 * image.c (clear_image_cache): Likewise.
1979
f6a24d19
PE
1980 * term.c (term_mouse_position): Don't assume time_t wraparound.
1981
08dc5ae6
PE
1982 Be more systematic about user-interface timestamps.
1983 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1984 and sometimes 'EMACS_UINT', to represent these timestamps.
1985 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1986 This makes the code easier to follow, and makes it easier to catch
1987 integer overflow bugs such as Bug#8664.
1988 * frame.c (Fmouse_position, Fmouse_pixel_position):
1989 Use Time, not unsigned long, for user-interface timestamps.
1990 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1991 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1992 * keyboard.h (last_event_timestamp): Likewise.
1993 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1994 * menu.h (xmenu_show): Likewise.
1995 * term.c (term_mouse_position): Likewise.
1996 * termhooks.h (struct input_event.timestamp): Likewise.
1997 (struct terminal.mouse_position_hook): Likewise.
1998 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1999 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2000 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2001 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2002 what it was before.
2003 * menu.h, termhooks.h: Include "systime.h", for Time.
2004
8e55734a
PE
2005 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2006 Don't assume that the difference between two unsigned long values
2007 can fit into an integer. At this point, we know button_down_time
2008 <= event->timestamp, so the difference must be nonnegative, so
2009 there's no need to cast the result if double-click-time is
2010 nonnegative, as it should be; check that it's nonnegative, just in
2011 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2012 apart (about 25 days). (Bug#8664)
8e55734a 2013
841f1b75 2014 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2015 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2016
3e26f69c
PE
2017 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2018 that always fit in int. Use a sentinel instead of a counter, to
2019 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2020 * frame.h (struct frame): Use int for menu_bar_items_used
2021 instead of EMACS_INT, since it always fits in int.
3e26f69c 2022
5cc152c0
PE
2023 * menu.c (grow_menu_items): Check for int overflow.
2024
d89eb65e
PE
2025 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2026
5235bd3e
PE
2027 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2028 Before, the code was not consistent. These values cannot exceed
2029 2**31 - 1 so there's no need to make them unsigned.
2030 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2031 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2032 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2033 as modifiers.
2034 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2035
bc827e23
PE
2036 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2037 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2038 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2039 presumably because the widths might not match.
2040
78eb494e
PE
2041 * window.c (size_window): Avoid needless test at loop start.
2042
04f2d78b
CB
20432011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2044
2045 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2046
d2fc7e3d 20472011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2048
2049 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2050
d2fc7e3d 20512011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2052
2053 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2054 `width' to `bar_area_x' and `bar_area_width', respectively.
2055 (x_scroll_run): Take account of fringe background extension.
2056
04f2d78b
CB
2057 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2058 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2059 `bar_area_width', respectively.
2060 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2061 background extension.
2062
79b70037
GM
20632011-05-10 Jim Meyering <meyering@redhat.com>
2064
2065 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2066
2f142cc5
JB
20672011-05-10 Juanma Barranquero <lekktu@gmail.com>
2068
2069 * image.c (Finit_image_library): Return t for built-in image types,
2070 like pbm and xbm. (Bug#8640)
2071
57679c86
AS
20722011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2073
2074 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2075
888c9e86
EZ
20762011-05-07 Eli Zaretskii <eliz@gnu.org>
2077
b0512a1d
EZ
2078 * w32console.c (Fset_screen_color): Doc fix.
2079 (Fget_screen_color): New function.
2080 (syms_of_ntterm): Defsubr it.
2081
7285dc67
EZ
2082 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2083 unlink the temporary file if Fcall_process didn't create it in the
2084 first place.
2085 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2086 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2087 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2088 cue to call_process_cleanup not to close that handle.
2089
4d3fcc8e
BK
20902011-05-07 Ben Key <bkey76@gmail.com>
2091
2092 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2093 one of two shell specific rules, either bootstrap-temacs-CMD or
2094 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2095 to the previous implementation of the bootstrap-temacs rule.
2096 The bootstrap-temacs-CMD rule is similar to the previous
2097 implementation of the bootstrap-temacs rule except that it
2098 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2099 variable.
2100
2101 These changes, along with some changes to nt/configure.bat,
2102 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2103 earlier fix to add support for --cflags and --ldflags options
2104 that include quotes so that it works whether make uses cmd or
2105 sh as the shell.
2106
b4289b64
MA
21072011-05-06 Michael Albinus <michael.albinus@gmx.de>
2108
2109 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2110 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2111 is a constant.
2112 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2113 a string. Handle both cases.
2114 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2115 (Fdbus_register_method): Use Qinvalid_function.
2116
af4c0e28
JB
21172011-05-06 Juanma Barranquero <lekktu@gmail.com>
2118
2119 * makefile.w32-in: Update dependencies.
2120 (LISP_H): Add inttypes.h and stdin.h.
2121 (PROCESS_H): Add unistd.h.
2122
c51453d9
EZ
21232011-05-06 Eli Zaretskii <eliz@gnu.org>
2124
2125 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2126 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2127
8ff0ac3c 21282011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2129
4c4b566b
PE
2130 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2131
aab2b9b5
PE
2132 * term.c (vfatal): Remove stray call to va_end.
2133 It's not needed and the C Standard doesn't allow it here anyway.
2134
c378da0b
PE
2135 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2136 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2137
288b08c7
PE
2138 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2139 bytes.
2140
e3601888
PE
2141 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2142
db6c0e74
PE
2143 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2144
dd5963ea
PE
2145 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2146
88c9450f
PE
2147 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2148
2f9442b8
PE
2149 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2150
c032b5f8
PE
2151 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2152 * charset.c (Fdefine_charset_internal): Don't initialize
2153 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2154 32-bit int (Bug#8600).
a108c10b
PE
2155
2156 * lread.c (read_integer): Be more consistent with string-to-number.
2157 Use string_to_number to do the actual conversion; this avoids
2158 rounding errors and fixes some other screwups. Without this fix,
2159 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2160 (digit_to_number): Move earlier, for benefit of read_integer.
2161 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2162 not a digit in any supported base. (Bug#8602)
a108c10b 2163
ad5f9eea
PE
2164 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2165
aec1708a
PE
2166 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2167 to match comment at start of function. This also removes a
2168 GCC warning about overflow in a 32+64-bit port.
2169
47be4ab5
PE
2170 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2171
371cac43
PE
2172 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2173 Reported by Stefan Monnier in
2174 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2175 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2176 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2177
d01a7826
PE
2178 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2179 (EMACS_UINTPTR): Likewise, with uintptr_t.
2180
7fd47d5c
PE
2181 * lisp.h: Prefer 64-bit EMACS_INT if available.
2182 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2183 on 32-bit hosts that have 64-bit int, so that they can access
2184 large files.
122b0c86
PE
2185 However, temporarily disable this change unless the temporary
2186 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2187
8727937b
PE
2188 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2189
8ac068ac
PE
2190 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2191 This removes an assumption that EMACS_INT and long are the same
2192 width as pointers. The assumption is true for Emacs porting targets
2193 now, but we want to make other targets possible.
2194 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2195 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2196 In the rest of the code, change types of integers that hold casted
2197 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2198 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2199 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2200 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2201 No need to cast type when ORing.
2202 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2203 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2204 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2205 assume EMACS_INT is the same width as char *.
2206 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2207 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2208 Remove no-longer-needed casts.
2209 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2210 (xg_tool_bar_help_callback, xg_make_tool_item):
2211 Use EMACS_INTPTR to hold an integer
2212 that will be cast to void *; this can avoid a GCC warning
2213 if EMACS_INT is not the same width as void *.
2214 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2215 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2216 (current_message_1, set_message_1):
2217 Use a local to convert to proper width without a cast.
2218 * xmenu.c (dialog_selection_callback): Likewise.
2219
ede49d71
PE
2220 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2221 Also, don't assume VALBITS / RAND_BITS is less than 5,
2222 and don't rely on undefined behavior when shifting a 1 left into
2223 the sign bit.
2224 * lisp.h (get_random): Change signature to match.
2225
2f30ecd0
PE
2226 * lread.c (hash_string): Use size_t, not int, for hash computation.
2227 Normally we prefer signed values; but hashing is special, because
2228 it's better to use unsigned division on hash table sizes so that
2229 the remainder is nonnegative. Also, size_t is the natural width
2230 for hashing into memory. The previous code used 'int', which doesn't
2231 retain enough info to hash well into very large tables.
2232 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2233
2a866e7b
PE
2234 * dbusbind.c: Don't possibly lose pointer info when converting.
2235 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2236 Use XPNTR rather than XHASH, so that the high-order bits of
2237 the pointer aren't lost when converting through void *.
2238
51639eac
PE
2239 * eval.c (Fautoload): Don't double-shift a pointer.
2240
92394119
PE
2241 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2242
dbdb9a7c
JB
22432011-05-06 Juanma Barranquero <lekktu@gmail.com>
2244
2245 * gnutls.c (DEF_GNUTLS_FN):
2246 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2247
db7a0b4f
AS
22482011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2249
2250 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2251 marker. (Bug#8610)
2252
f7ff1b0f 22532011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2254
2255 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2256 New version that can reserve upto 2GB of heap space.
2257
f7ff1b0f 22582011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2259
2260 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2261
639c109b
TZ
22622011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2263
2264 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2265 `gnutls_certificate_set_x509_key_file'.
2266
d2127135
JB
22672011-05-05 Juanma Barranquero <lekktu@gmail.com>
2268
2269 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2270 Update dependencies.
2271
e968f4f3
JB
22722011-05-04 Juanma Barranquero <lekktu@gmail.com>
2273
2274 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2275 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2276 Remove unused parameter `fildes'.
2277 * process.c (read_process_output, send_process): Don't pass it.
2278
84d358f0
JB
22792011-05-04 Juanma Barranquero <lekktu@gmail.com>
2280
2281 Fix previous change: the library cache is defined in w32.c.
2282 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2283 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2284
0898ca10
JB
22852011-05-04 Juanma Barranquero <lekktu@gmail.com>
2286
2287 Implement dynamic loading of GnuTLS on Windows.
2288
2289 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2290 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2291 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2292 Declare.
2293
2294 * gnutls.c (Qgnutls_dll): Define.
2295 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2296 (gnutls_*): Declare function pointers.
2297 (init_gnutls_functions): New function to initialize function pointers.
2298 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2299 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2300 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2301 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2302 (emacs_gnutls_write, emacs_gnutls_read)
2303 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2304 (Fgnutls_available_p): New function.
2305 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2306 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2307 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2308
2309 * image.c: Include w32.h.
2310 (Vimage_type_cache): Delete.
2311 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2312 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2313 (w32_delayed_load): Move to w32.c.
2314
2315 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2316
2317 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2318 (w32_delayed_load): Move from image.c. When loading a library, record
2319 its filename in the :loaded-from property of the library id.
2320 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2321 Initialize and staticpro them.
2322 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2323
2324 * process.c: Include lisp.h before w32.h, not after.
2325 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2326 instead of gnutls_record_check_pending.
2327
2328 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2329
ff4de4aa
TZ
23302011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2331
2332 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2333 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2334 as passed in.
2335
abe95abb
JD
23362011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2337
2338 * xterm.c (x_set_frame_alpha): Do not set property on anything
2339 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2340
e16e55d4
JB
23412011-05-02 Juanma Barranquero <lekktu@gmail.com>
2342
2343 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2344
bafcf6a5
JB
23452011-05-02 Juanma Barranquero <lekktu@gmail.com>
2346
2347 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2348 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2349 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2350 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2351 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2352 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2353 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2354 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2355 (Qgnutls_bootprop_callbacks_verify): Make static.
2356
e7a6747f
AS
23572011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2358
19ed11ba
AS
2359 * callproc.c: Indentation fixup.
2360
e7a6747f 2361 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2362 (wait_for_termination, interruptible_wait_for_termination):
2363 Move after wait_for_termination_1.
e7a6747f 2364
1ef14cb4
LMI
23652011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2366
2367 * sysdep.c (interruptible_wait_for_termination): New function
2368 which is like wait_for_termination, but allows keyboard
2369 interruptions.
2370
2371 * callproc.c (Fcall_process): Add (:file "file") as an option for
2372 the STDOUT buffer.
2373 (Fcall_process_region): Ditto.
2374
330d880c
EZ
23752011-04-30 Eli Zaretskii <eliz@gnu.org>
2376
8db90b73
EZ
2377 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2378 rather than `XVECTOR (FOO)->size'.
2379
330d880c
EZ
2380 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2381 inttypes.h, as a gnulib replacement is used if it not available in
2382 system headers.
2383
15cbd324
EZ
23842011-04-21 Eli Zaretskii <eliz@gnu.org>
2385
2386 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2387 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2388 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2389
2390 * coding.c (coding_alloc_by_realloc): Error out if destination
2391 will grow beyond MOST_POSITIVE_FIXNUM.
2392 (decode_coding_emacs_mule): Abort if there isn't enough place in
2393 charbuf for the composition carryover bytes. Reserve an extra
2394 space for up to 2 characters produced in a loop.
2395 (decode_coding_iso_2022): Abort if there isn't enough place in
2396 charbuf for the composition carryover bytes.
2397
23982011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2399
ae940cca
EZ
2400 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2401 aborting when %lld or %lll format is passed.
2402 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2403 %llo or %llx format is passed. (Bug#8545)
2404
03ab8921
EZ
2405 * window.c (window_scroll_line_based): Use a marker instead of
2406 simple variables to record original value of point. (Bug#7952)
2407
afda1437
EZ
2408 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2409 produced by %s or %c overflows available buffer space. (Bug#8545)
2410
f76dee0c
PE
24112011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2412
2413 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2414 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2415
fdc5744d
JB
24162011-04-28 Juanma Barranquero <lekktu@gmail.com>
2417
2418 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2419
638f053a
JB
24202011-04-28 Juanma Barranquero <lekktu@gmail.com>
2421
2422 * keyboard.c (Qdelayed_warnings_hook): Define.
2423 (command_loop_1): Run `delayed-warnings-hook'
2424 if Vdelayed_warnings_list is non-nil.
2425 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2426 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2427
d178f871
EZ
24282011-04-28 Eli Zaretskii <eliz@gnu.org>
2429
2430 * doprnt.c (doprnt): Don't return value smaller than the buffer
2431 size if the message was truncated. (Bug#8545).
2432
b124fd93
JB
24332011-04-28 Juanma Barranquero <lekktu@gmail.com>
2434
2435 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2436 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2437
e810457d
PE
24382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2439
2440 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2441
ea51cceb
JB
24422011-04-27 Juanma Barranquero <lekktu@gmail.com>
2443
2444 * makefile.w32-in: Update dependencies.
2445
94dcfacf
EZ
24462011-04-27 Eli Zaretskii <eliz@gnu.org>
2447
2448 Improve `doprnt' and its usage. (Bug#8545)
2449 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2450 `format_end'. Remove support for %l as a conversion specifier.
2451 Don't use xrealloc. Improve diagnostics when the %l size modifier
2452 is used. Update the commentary.
2453
2454 * eval.c (verror): Simplify calculation of size_t.
2455
2456 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2457 messages.
2458
f61f41d7
PE
24592011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2460
2461 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2462 change.
2463
96fb4434
PE
24642011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2465
2466 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2467 This makes this file independent of the recent pseudovector change.
2468
671875da 24692011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2470
69e9b5a3
PE
2471 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2472
b5f869a7 2473 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2474 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2475 Remove unused local.
c8926152 2476 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2477
841a1577 2478 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2479 GCC 4.6.0 optimizes based on type-based alias analysis.
2480 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2481 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2482 != &v->size, and therefore "v->size = 1; b->size = 2; return
2483 v->size;" must therefore return 1. This assumption is incorrect
2484 for Emacs, since it type-puns struct Lisp_Vector * with many other
2485 types. To fix this problem, this patch adds a new type struct
f904488f 2486 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2487 and pseudovectors, and helps optimizing compilers not get fooled
2488 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2489 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2490 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2491 the size member.
eab3844f
PE
2492 (XSETPVECTYPE): Rewrite in terms of new macro.
2493 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2494 This is a bit clearer, and further avoids the possibility of
2495 undesirable aliasing.
2496 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2497 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2498 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2499 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2500 (ASIZE): Now uses header.size rather than size.
2501 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2502 to avoid the hassle of writing XVECTOR (foo)->header.size.
2503 (struct vectorlike_header): New type.
eab3844f
PE
2504 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2505 object, to help avoid aliasing.
2506 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2507 (SUBRP): Likewise, since Lisp_Subr is a special case.
2508 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2509 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2510 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2511 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2512 changed to be "header.size" and "header.next".
2513 * buffer.h (struct buffer): Likewise.
2514 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2515 * frame.h (struct frame): Likewise.
2516 * process.h (struct Lisp_Process): Likewise.
2517 * termhooks.h (struct terminal): Likewise.
2518 * window.c (struct save_window_data, struct saved_window): Likewise.
2519 * window.h (struct window): Likewise.
2520 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2521 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2522 * buffer.c (init_buffer_once): Likewise.
2523 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2524 special case.
2525 * process.c (Fformat_network_address): Use local var for size,
2526 for brevity.
2527
0df1eac5
PE
2528 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2529
847ab9d1 2530 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2531 * data.c (atof): Remove decl; no longer used or needed.
2532 (digit_to_number): Move to lread.c.
2533 (Fstring_to_number): Use new string_to_number function, to be
2534 consistent with how the Lisp reader treats infinities and NaNs.
2535 Do not assume that floating-point numbers represent EMACS_INT
2536 without losing information; this is not true on most 64-bit hosts.
2537 Avoid double-rounding errors, by insisting on integers when
2538 parsing non-base-10 numbers, as the documentation specifies.
2539 * lisp.h (string_to_number): New decl, replacing ...
2540 (isfloat_string): Remove.
bc0a5c13 2541 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2542 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2543 appears to have been a coding error. Similarly, do not accept
2544 strings like +-1e0 as floating point numbers. Do not report
2545 overflow for integer overflows unless the base is not 10 which
2546 means we have no simple and reliable way to continue.
2547 Break out the floating-point parsing into a new
2548 function string_to_number, so that Fstring_to_number parses
2549 floating point numbers consistently with the Lisp reader.
04f2d78b 2550 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2551 (E_CHAR, EXP_INT): Remove, replacing with ...
2552 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2553 (string_to_number): New function, replacing isfloat_string.
2554 This function checks for valid syntax and produces the resulting
2555 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2556 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2557 so that overflow for non-base-10 numbers is reported only when
2558 there's no portable and simple way to convert to floating point.
452f4150 2559
67769ffc
PE
2560 * textprop.c (set_text_properties_1): Rewrite for clarity,
2561 and to avoid GCC warning about integer overflow.
2562
c20db43f
PE
2563 * intervals.h (struct interval): Use EMACS_INT for members
2564 where EMACS_UINT might cause problems. See
2565 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2566 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2567 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2568 All uses changed.
37aa2f85
PE
2569 (offset_intervals): Tell GCC not to worry about length overflow
2570 when negating a negative length.
c20db43f 2571
2538aa2f
PE
2572 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2573 (overrun_check_free): Likewise.
2574
f2d3008d
PE
2575 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2576 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2577 word size.
2578
ec8df744
PE
2579 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2580 (gnutls_make_error): Rename local to avoid shadowing.
2581 (gnutls_emacs_global_deinit): ifdef out; not used.
2582 (Fgnutls_boot): Use const for pointer to readonly storage.
2583 Comment out unused local. Fix pointer signedness problems.
2584
640ee02d
PE
2585 * lread.c (openp): Don't stuff size_t into an 'int'.
2586 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2587 about possible signed overflow.
2588
6048fb2a
PE
2589 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2590 (GDK_KEY_g): Don't define if already defined.
2591 (xg_prepare_tooltip): Avoid pointer signedness problem.
2592 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2593
fa3c87e1
PE
2594 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2595 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2596
2172544b
PE
2597 * xfns.c (Fx_window_property): Simplify a bit,
2598 to make a bit faster and to avoid GCC 4.6.0 warning.
2599 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2600
9b821a21
PE
2601 * fns.c (internal_equal): Don't assume size_t fits in int.
2602
3c616cfa
PE
2603 * alloc.c (compact_small_strings): Tighten assertion a little.
2604
c2982e87
PE
2605 Replace pEd with more-general pI, and fix some printf arg casts.
2606 * lisp.h (pI): New macro, generalizing old pEd macro to other
2607 conversion specifiers. For example, use "...%"pI"d..." rather
2608 than "...%"pEd"...".
2609 (pEd): Remove. All uses replaced with similar uses of pI.
2610 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2611 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2612 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2613 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2614 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2615 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2616 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2617 64-bit hosts.
2618 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2619 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2620 * print.c (safe_debug_print, print_object): Likewise.
2621 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2622 to int.
6f04d126
PE
2623 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2624 avoiding the 0 flag, which is not portable.
c2982e87
PE
2625 * process.c (Fmake_network_process): Use pI to avoid cast.
2626 * region-cache.c (pp_cache): Likewise.
2627 * xdisp.c (decode_mode_spec): Likewise.
2628 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2629 behavior on 64-bit hosts with printf arg.
6f04d126 2630 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2631 (x_stop_queuing_selection_requests): Likewise.
2632 (x_get_window_property): Don't truncate byte count to an 'int'
2633 when tracing.
0b432f21 2634
5e073ec7
PE
2635 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2636 here, since it parses constructs like leading '-' and spaces,
2637 which are not wanted; and it overflows with large numbers.
2638 Instead, simply match F[0-9]+, which is what is wanted anyway.
2639
36372bf9
PE
2640 * alloc.c: Remove unportable assumptions about struct layout.
2641 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2642 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2643 (allocate_vectorlike, make_pure_vector): Use the new macros,
2644 plus offsetof, to remove unportable assumptions about struct layout.
2645 These assumptions hold on all porting targets that I know of, but
2646 they are not guaranteed, they're easy to remove, and removing them
2647 makes further changes easier.
2648
0b432f21
PE
2649 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2650 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2651 (string_overrun_cookie): Now const. Use initializers that
2652 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2653 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2654 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2655 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2656 multiple of sizeof (EMACS_INT); it need not be, if
2657 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2658 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2659
895009e1
JB
26602011-04-26 Juanma Barranquero <lekktu@gmail.com>
2661
2662 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2663
6a7a1b0b
TZ
26642011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2665
2666 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2667 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2668 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2669
841a1577 26702011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2671
2672 * lisp.h (Qdebug): List symbol.
895009e1 2673 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2674 * keyboard.c (debug-on-event): New variable.
2675 (handle_user_signal): Break into debugger when debug-on-event
2676 matches the current signal symbol.
2677
f2d3ba6f
DN
26782011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2679
2680 * alloc.c (check_sblock, check_string_bytes)
2681 (check_string_free_list): Convert to standard C.
2682
42ce4c63
TZ
26832011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2684
2685 * w32.c (emacs_gnutls_push): Fix typo.
2686
825cd63c
EZ
26872011-04-25 Eli Zaretskii <eliz@gnu.org>
2688
fb11d64d
EZ
2689 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2690 "cast to pointer from integer of different size".
2691
825cd63c
EZ
2692 Improve doprnt and its use in verror. (Bug#8545)
2693 * doprnt.c (doprnt): Document the set of format control sequences
2694 supported by the function. Use SAFE_ALLOCA instead of always
2695 using `alloca'.
2696
2697 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2698 is one byte too soon. Don't use xrealloc; instead xfree and
2699 xmalloc anew.
2700
e061a11b
TZ
27012011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2702
2703 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2704 callbacks stage.
2705
2706 * gnutls.c: Renamed global_initialized to
2707 gnutls_global_initialized. Added internals for the
2708 :verify-hostname-error, :verify-error, and :verify-flags
2709 parameters of `gnutls-boot' and documented those parameters in the
2710 docstring. Start callback support.
2711 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2712 unless a fatal error occured. Call gnutls_alert_send_appropriate
2713 on error. Return error code.
2714 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2715 (emacs_gnutls_read): Likewise.
2716 (Fgnutls_boot): Return handshake error code.
2717 (emacs_gnutls_handle_error): New function.
2718 (wsaerror_to_errno): Likewise.
2719
2720 * w32.h (emacs_gnutls_pull): Add prototype.
2721 (emacs_gnutls_push): Likewise.
2722
2723 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2724 (emacs_gnutls_push): Likewise.
2725
27262011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2727
2728 * process.c (wait_reading_process_output): Check if GnuTLS
2729 buffered some data internally if no FDs are set for TLS
2730 connections.
2731
2732 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2733 (LIBS): Link to USER_LIBS.
2734 ($(BLD)/gnutls.$(0)): New target.
2735
fa6996bc
EZ
27362011-04-24 Eli Zaretskii <eliz@gnu.org>
2737
eb35682e
EZ
2738 * xdisp.c (handle_single_display_spec): Rename the
2739 display_replaced_before_p argument into display_replaced_p, to
2740 make it consistent with the commentary. Fix typos in the
2741 commentary.
2742
e2ad650c
EZ
2743 * textprop.c (syms_of_textprop): Remove dead code.
2744 (copy_text_properties): Delete obsolete commentary about an
2745 interface that was deleted long ago. Fix typos in the description
2746 of arguments.
2747
1b2de274
EZ
2748 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2749 to changes in oldXMenu/XMenu.h from 2011-04-16.
2750 <menu_help_message, prev_menu_help_message>: Constify.
2751 (IT_menu_make_room): menu->help_text is now `const char **';
2752 adjust.
2753
2754 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2755 to changes in oldXMenu/XMenu.h from 2011-04-16.
2756 (struct XMenu): Declare `help_text' `const char **'.
2757
2758 * xfaces.c <Qunspecified>: Make extern again.
2759
2760 * syntax.c: Include sys/types.h before including regex.h, as
2761 required by Posix.
2762
762b15be
EZ
2763 * doc.c (get_doc_string): Improve the format passed to `error'.
2764
2765 * doprnt.c (doprnt): Improve commentary.
2766
2767 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2768
2769 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2770 them with etags.
2771
f1052e5d
EZ
2772 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2773 changes in globals.h immediately force recompilation.
762b15be
EZ
2774 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2775 $(CURDIR)/s/ms-w32.h.
2776 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2777
fa6996bc
EZ
2778 * character.c (Fchar_direction): Function deleted.
2779 (syms_of_character): Don't defsubr it.
2780 <char-direction-table>: Deleted.
2781
e6c3da20
EZ
27822011-04-23 Eli Zaretskii <eliz@gnu.org>
2783
2784 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2785 * doprnt.c: Include limits.h.
2786 (SIZE_MAX): New macro.
04f2d78b
CB
2787 (doprnt): Return a size_t value. 2nd arg is now size_t.
2788 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2789 Improve overflow protection. Support `l' modifier for integer
2790 conversions. Support %l conversion. Don't assume an EMACS_INT
2791 argument for integer conversions and for %c.
2792
2793 * lisp.h (doprnt): Restore prototype.
2794
2795 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2796 $(SRC)/character.h.
2797
2798 * Makefile.in (base_obj): Add back doprnt.o.
2799
2800 * deps.mk (doprnt.o): Add back prerequisites.
2801 (callint.o): Depend on character.h.
2802
2803 * eval.c (internal_lisp_condition_case): Include the handler
2804 representation in the error message.
2805 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2806 when breaking from the loop.
2807
2808 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2809
2810 * callint.c (Fcall_interactively): When displaying error message
2811 about invalid control letter, pass the character's codepoint, not
2812 a pointer to its multibyte form. Improve display of the character
2813 in octal and display also its hex code.
2814
2815 * character.c (char_string): Use %x to display the (unsigned)
2816 codepoint of an invalid character, to avoid displaying a bogus
2817 negative value.
2818
2819 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2820 `error', not SYMBOL_NAME itself.
2821
2822 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2823 character arguments to `error'.
2824
2825 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2826 to `error' in error message about FINAL_CHAR argument. Make sure
2827 FINAL_CHAR is a character, and use %c when it is passed as
2828 argument to `error'.
2829
4ffd0d6b 28302011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2831
2832 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2833
2834 * w32.c: Include <time.h>.
2835 (sys_localtime): New function.
2836
4ffd0d6b 28372011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2838
2839 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2840
4ffd0d6b 2841 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2842
4ffd0d6b 28432011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2844
4ffd0d6b
GM
2845 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2846 zombies (Bug#8467).
aac0c6e3 2847
04c56954
EZ
28482011-04-19 Eli Zaretskii <eliz@gnu.org>
2849
2850 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2851 gl_state.e_property when gl_state.object is Qt.
2852
2853 * insdel.c (make_gap_larger): Remove limitation of buffer size
2854 to <= INT_MAX.
2855
16a43933
CY
28562011-04-18 Chong Yidong <cyd@stupidchicken.com>
2857
2858 * xdisp.c (lookup_glyphless_char_display)
2859 (produce_glyphless_glyph): Handle cons cell entry in
2860 glyphless-char-display.
2861 (Vglyphless_char_display): Document it.
2862
2863 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2864 glyphless-char-display.
2865
4581706e
CY
28662011-04-17 Chong Yidong <cyd@stupidchicken.com>
2867
2868 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2869
2870 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2871
2872 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2873 definition for no-X builds.
2874
4887c6e2 28752011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2876
fd35b6f9
PE
2877 Static checks with GCC 4.6.0 and non-default toolkits.
2878
5c1ccb01
PE
2879 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2880
006c5daa
PE
2881 * process.c (keyboard_bit_set): Define only if SIGIO.
2882 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2883 (send_process): Repair possible setjmp clobbering.
2884
efc736d3
PE
2885 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2886
4e2fe2e6
PE
2887 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2888
f97334a2
PE
2889 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2890
4e75f29d
PE
2891 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2892 Define only if needed.
2893
90efadd1
PE
2894 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2895 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2896 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2897
3c647824
PE
2898 * dispextern.h (struct redisplay_interface): Rename param
2899 to avoid shadowing.
e264f262 2900 * termhooks.h (struct terminal): Likewise.
761383f4 2901 * xterm.c (xembed_send_message): Likewise.
3c647824 2902
b58c5c4a
PE
2903 * insdel.c (make_gap_smaller): Define only if
2904 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2905
cad59032
PE
2906 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2907 it.
2908
c339dc2e
PE
2909 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2910 so that we aren't warned about unused symbols.
2911
91a3e27b
PE
2912 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2913
399c71d3 2914 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2915
8ffc96f5
PE
2916 * xfns.c (x_real_positions): Mark locals as initialized.
2917
eef9bc79
PE
2918 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2919
098db9dd
PE
2920 * xterm.c: Fix problems found by static analysis with other toolkits.
2921 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2922 (x_dispatch_event): Declare static if USE_GTK, and
2923 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2924 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2925 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2926 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2927 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2928
eb18f6cc
PE
2929 * xmenu.c (menu_help_callback): Pointer type fixes.
2930 Use const pointers when pointing at readonly data. Avoid pointer
2931 signedness clashes.
2932 (FALSE): Remove unused macro.
2933 (update_frame_menubar): Remove unused decl.
2934
1fe72bf8
PE
2935 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2936
60d9e1db
PE
2937 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2938 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2939 (single_menu_item): Rename local to avoid shadowing.
2940
39261c26
PE
2941 * keyboard.c (make_lispy_event): Remove unused local var.
2942
018c5e19
PE
2943 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2944 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2945
63d2b86e
PE
2946 * bitmaps: Change bitmaps from unsigned char back to the X11
2947 compatible char. Avoid the old compiler warnings about
2948 out-of-range initializers by using, for example, '\xab' rather
2949 than 0xab.
2950
aefd87e1
PE
2951 * xgselect.c (xgselect_initialize): Check vs interface
2952 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2953
bf501fb9
PE
2954 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2955
e9829fdf
PE
2956 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2957 to read-only memory.
2958
1086c095
PE
2959 * fns.c (vector): Remove; this old hack is no longer needed.
2960
2baccd04 2961 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2962 Remove unused var.
dde42981 2963 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2964
72391843 2965 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2966
436c16df 2967 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2968 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2969 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2970
92bb796d 2971 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2972 (x_term_init): Remove local to avoid shadowing.
92bb796d 2973
764430a3 2974 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2975
2976 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2977 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2978
d1dfb56c
EZ
29792011-04-16 Eli Zaretskii <eliz@gnu.org>
2980
c4354cb4
EZ
2981 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2982
d1dfb56c
EZ
2983 Fix regex.c, syntax.c and friends for buffers > 2GB.
2984 * syntax.h (struct gl_state_s): Declare character position members
2985 EMACS_INT.
2986
2987 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2988
04f2d78b
CB
2989 * textprop.c (verify_interval_modification, interval_of):
2990 Declare arguments EMACS_INT.
d1dfb56c
EZ
2991
2992 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2993 EMACS_INT.
2994
2995 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2996
2997 * indent.c (Fvertical_motion): Local variable it_start is now
2998 EMACS_INT.
2999
3000 * regex.c (re_match, re_match_2, re_match_2_internal)
3001 (bcmp_translate, regcomp, regexec, print_double_string)
3002 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3003 (re_compile_pattern, re_exec): Declare arguments and local
3004 variables `size_t' and `ssize_t' and return values `regoff_t', as
3005 appropriate.
3006 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3007 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3008 <compile_stack_type>: `size' and `avail' are now `size_t'.
3009
3010 * regex.h <regoff_t>: Use ssize_t, not int.
3011 (re_search, re_search_2, re_match, re_match_2): Arguments that
3012 specify buffer/string position and length are now ssize_t and
3013 size_t. Return type is regoff_t.
3014
613052cd
BK
30152011-04-16 Ben Key <bkey76@gmail.com>
3016
3017 * nsfont.m: Fixed bugs in ns_get_family and
3018 ns_descriptor_to_entity that were caused by using free to
3019 deallocate memory blocks that were allocated by xmalloc (via
3020 xstrdup). This caused Emacs to crash when compiled with
3021 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3022 --enable-checking=xmallocoverrun). xfree is now used to
3023 deallocate these memory blocks.
3024
4170f62f 30252011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3026
71b41406
PE
3027 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3028
9587a89d
PE
3029 emacs_write: Accept and return EMACS_INT for sizes.
3030 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3031 et seq.
3032 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3033 Accept and return EMACS_INT.
3034 (emacs_gnutls_write): Return the number of bytes written on
3035 partial writes.
3036 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3037 (emacs_read, emacs_write): Remove check for negative size, as the
3038 Emacs source code has been audited now.
9587a89d
PE
3039 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3040 (emacs_read, emacs_write): Use it.
273a5f82
PE
3041 * process.c (send_process): Adjust to the new signatures of
3042 emacs_write and emacs_gnutls_write. Do not attempt to store
3043 a byte offset into an 'int'; it might overflow.
9587a89d 3044 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3045
3e047f51
PE
3046 * sound.c: Don't assume sizes fit in 'int'.
3047 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3048 Return EMACS_INT, not int.
3e047f51 3049 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3050 Accept EMACS_INT, not int.
3051 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3052 record read return values.
3053
cc39a9db
BK
30542011-04-15 Ben Key <bkey76@gmail.com>
3055
c9d0ec6d
JB
3056 * keyboard.c (Qundefined): Don't declare static since it is used
3057 in nsfns.m.
3058 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3059 static since they are used in nsfont.m.
cc39a9db 3060
6c60eb9f
SM
30612011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3062
3063 * process.c (Qprocessp): Don't declare static.
3064 * lisp.h (Qprocessp): Declare again.
3065
7990b61a
JB
30662011-04-15 Juanma Barranquero <lekktu@gmail.com>
3067
3068 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3069
5d4cb038
PE
30702011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3071
8bd7b830 3072 Improve C-level modularity by making more things 'static'.
cd64ea1d 3073
e3b27b31
PE
3074 Don't publish debugger-only interfaces to other modules.
3075 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3076 (verify_bytepos, count_markers): Move decls to the only modules
3077 that need them.
3078 * region-cache.h (pp_cache): Likewise.
3079 * window.h (check_all_windows): Likewise.
3080 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3081
5d4cb038
PE
3082 * sysdep.c (croak): Now static, if
3083 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3084 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3085
3086 * alloc.c (refill_memory_reserve): Now static if
3087 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3088 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3089
e87b6180
PE
3090 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3091 Define only if USE_LUCID.
3092
ac64929e
PE
3093 * xrdb.c (x_customization_string, x_rm_string): Now static.
3094
6f37259d
PE
3095 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3096 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3097
1683e3ab
PE
3098 * xdisp.c (draw_row_with_mouse_face): Now static.
3099 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3100
de9c2632
PE
3101 * window.h (check_all_windows): Mark externally visible.
3102
2b96acb7
PE
3103 * window.c (window_deletion_count): Now static.
3104
3105 * undo.c: Make symbols static if they're not exported.
3106 (last_undo_buffer, last_boundary_position, pending_boundary):
3107 Now static.
3108
50436f33
PE
3109 * textprop.c (interval_insert_behind_hooks): Now static.
3110 (interval_insert_in_front_hooks): Likewise.
3111
64520e5c
PE
3112 * term.c: Make symbols static if they're not exported.
3113 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3114 (max_frame_lines, tty_set_terminal_modes):
3115 (tty_reset_terminal_modes, tty_turn_off_highlight):
3116 (get_tty_terminal): Now static.
3117 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3118 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3119 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3120 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3121 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3122
1fa53021
PE
3123 * sysdep.c: Make symbols static if they're not exported.
3124 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3125 Now static.
3126 (sigprocmask_set, full_mask): Remove; unused.
3127 (wait_debugging): Mark as visible.
3128 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3129 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3130
d4b43b22
PE
3131 * syntax.c (syntax_temp): Define only if !__GNUC__.
3132
b7c513d0
PE
3133 * sound.c (current_sound_device, current_sound): Now static.
3134
989b29ad
PE
3135 * search.c (searchbufs, searchbuf_head): Now static.
3136
13a55a78
PE
3137 * scroll.c (scroll_cost): Remove; unused.
3138 * dispextern.h (scroll_cost): Remove decl.
3139
de68a1fc
PE
3140 * region-cache.h (pp_cache): Mark as externally visible.
3141
40ccffa6
PE
3142 * process.c: Make symbols static if they're not exported.
3143 (process_tick, update_tick, create_process, chan_process):
3144 (Vprocess_alist, proc_buffered_char, datagram_access):
3145 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3146 (deactivate_process): Mark defn as static, as well as decl.
3147 * lisp.h (create_process): Remove decl.
3148 * process.h (chan_process, Vprocess_alist): Remove decls.
3149
ad64fc97
PE
3150 * print.c: Make symbols static if they're not exported.
3151 (print_depth, new_backquote_output, being_printed, print_buffer):
3152 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3153 (print_interval, print_number_index, initial_stderr_stream):
3154 Now static.
3155 * lisp.h (Fprinc): Remove decl.
3156 (debug_output_compilation_hack): Mark as externally visible.
3157
adddb265
PE
3158 * sysdep.c (croak): Move decl from here to syssignal.h.
3159 * syssignal.h (croak): Put it here, so the API can be checked when
3160 'croak' is called from dissociate_if_controlling_tty.
3161
1717ede2
PE
3162 * minibuf.c: Make symbols static if they're not exported.
3163 (minibuf_save_list, choose_minibuf_frame): Now static.
3164 * lisp.h (choose_minibuf_frame): Remove decl.
3165
fa5fb2bc
PE
3166 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3167
1e3890d1
PE
3168 * lread.c: Make symbols static if they're not exported.
3169 (read_objects, initial_obarray, oblookup_last_bucket_number):
3170 Now static.
3171 (make_symbol): Remove; unused.
3172 * lisp.h (initial_obarray, make_symbol): Remove decls.
3173
8a1414fa
PE
3174 * keyboard.c: Make symbols static if they're not exported.
3175 (single_kboard, recent_keys_index, total_keys, recent_keys):
3176 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3177 (this_single_command_key_start, echoing, last_auto_save):
3178 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3179 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3180 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3181 (Vlispy_mouse_stem, double_click_count):
3182 Now static.
3183 (force_auto_save_soon): Define only if SIGDANGER.
3184 (ignore_mouse_drag_p): Now static if
3185 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3186 (print_help): Remove; unused.
3187 (stop_character, last_timer_event): Mark as externally visible.
3188 * keyboard.h (ignore_mouse_drag_p): Declare only if
3189 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3190 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3191 * lisp.h (echoing): Remove decl.
3192 (force_auto_save_soon): Declare only if SIGDANGER.
3193 * xdisp.c (redisplay_window): Simplify code, to make it more
3194 obvious that ignore_mouse_drag_p is not accessed if !defined
3195 USE_GTK && !defined HAVE_NS.
3196
93ea6e8f
PE
3197 * intervals.c: Make symbols static if they're not exported.
3198 (merge_properties_sticky, merge_interval_right, delete_interval):
3199 Now static.
3200 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3201
77382fcc
PE
3202 * insdel.c: Make symbols static if they're not exported.
3203 However, leave prepare_to_modify_buffer alone. It's never
3204 called from outside this function, but that appears to be a bug.
3205 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3206 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3207 (adjust_after_replace_noundo): Remove; unused.
3208 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3209 (signal_before_change): Remove decls.
77382fcc 3210
9306c32e
PE
3211 * indent.c (val_compute_motion, val_vmotion): Now static.
3212
cd44d2eb
PE
3213 * image.c: Make symbols static if they're not exported.
3214 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3215 if USE_GTK.
3216 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3217 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3218
ad9a7a06
PE
3219 * fringe.c (standard_bitmaps): Now static.
3220 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3221
81626931
PE
3222 * frame.c: Make symbols static if they're not exported.
3223 (x_report_frame_params, make_terminal_frame): Now static.
3224 (get_frame_param): Now static, unless HAVE_NS.
3225 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3226 (x_get_resource_string): Remove; not used.
3227 * frame.h (make_terminal_frame, x_report_frame_params):
3228 (x_get_resource_string); Remove decls.
3229 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3230 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3231
239f9db9
PE
3232 * font.c, fontset.c: Make symbols static if they're not exported.
3233 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3234 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3235 * font.c (font_close_object): Now static.
3236 * font.h (font_close_object): Remove.
3237 * fontset.c (FONTSET_OBJLIST): Remove.
3238 (free_realized_fontset) #if-0 the body, which does nothing.
3239 (face_suitable_for_char_p): #if-0, as it's never called.
3240 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3241 * xfaces.c (face_at_string_position):
3242 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3243 since 0 is always ASCII.
3244
dfcf3579
PE
3245 * fns.c (weak_hash_tables): Now static.
3246
5045092b
PE
3247 * fileio.c: Make symbols static if they're not exported.
3248 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3249 (Vwrite_region_annotation_buffers): Now static.
3250
57a96f5c
PE
3251 * eval.c: Make symbols static if they're not exported.
3252 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3253 * lisp.h (backtrace_list): Remove decl.
3254
35f08c38
PE
3255 * emacs.c: Make symbols static if they're not exported.
3256 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3257 (fatal_error_code, fatal_error_signal_hook, standard_args):
3258 Now static.
3259 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3260 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3261 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3262 * lisp.h (fatal_error_signal_hook): Remove decl.
3263 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3264
f44bd759
PE
3265 * editfns.c: Move a (normally-unused) function to its only use.
3266 * editfns.c, lisp.h (get_operating_system_release): Remove.
3267 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3268 worth the hassle of breaking this out.
3269
b532497d
PE
3270 * xterm.c: Make symbols static if they're not exported.
3271 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3272 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3273 (x_destroy_window, x_delete_display):
3274 Now static.
3275 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3276 (x_mouse_leave): Remove; unused.
3277 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3278 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3279 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3280 Remove decls.
3281 (x_mouse_leave): Declare only if WINDOWSNT.
3282 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3283 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3284 USE_X_TOOLKIT.
3285
1675728f
PE
3286 * ftxfont.c: Make symbols static if they're not exported.
3287 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3288 HAVE_FREETYPE.
3289 * font.h (ftxfont_driver): Likewise.
3290
e4cebfca
PE
3291 * xfns.c: Make symbols static if they're not exported.
3292 (x_last_font_name, x_display_info_for_name):
3293 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3294 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3295 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3296 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3297 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3298 (last_show_tip_args): Now static.
3299 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3300 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3301 (x_screen_planes): Remove; unused.
3302 * dispextern.h (x_screen_planes): Remove decl.
3303
5bf46f05
PE
3304 * dispnew.c: Make symbols static if they're not exported.
3305 * dispextern.h (redraw_garbaged_frames, scrolling):
3306 (increment_row_positions): Remove.
3307 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3308 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3309 Now static.
3310 (redraw_garbaged_frames): Remove; unused.
3311
435f4c28
PE
3312 * xfaces.c: Make symbols static if they're not exported.
3313 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3314 Remove decls.
3315 * xterm.h (defined_color): Remove decls.
3316 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3317 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3318 (menu_face_changed_default, defined_color, free_realized_face):
3319 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3320 (ascii_face_of_lisp_face): Remove; unused.
3321
8524aef3
PE
3322 * xdisp.c: Make symbols static if they're not exported.
3323 * dispextern.h (scratch_glyph_row, window_box_edges):
3324 (glyph_to_pixel_coords, set_cursor_from_row):
3325 (get_next_display_element, set_iterator_to_next):
3326 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3327 (show_mouse_face): Remove decls
3328 * frame.h (message_buf_print): Likewise.
3329 * lisp.h (pop_message, set_message, check_point_in_composition):
3330 Likewise.
3331 * xterm.h (set_vertical_scroll_bar): Likewise.
3332 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3333 (message_buf_print, scratch_glyph_row, displayed_buffer):
3334 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3335 (get_next_display_element, show_mouse_face, window_box_edges):
3336 (frame_to_window_pixel_xy, check_point_in_composition):
3337 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3338 (glyph_to_pixel_coords): Remove; unused.
3339
16390cd2
PE
3340 * dired.c (file_name_completion): Now static.
3341
3342 * dbusbind.c (xd_in_read_queued_messages): Now static.
3343
a25f4dfa
PE
3344 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3345 * data.c (circular_list_error): Remove.
3346
14a9c8df
PE
3347 * commands.h (last_point_position, last_point_position_buffer):
3348 (last_point_position_window): Remove decls.
3349 * keyboard.c: Make these variables static.
3350
04f2d78b
CB
3351 * coding.h (coding, code_convert_region, encode_coding_gap):
3352 Remove decls.
74ab6df5
PE
3353 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3354 (iso_code_class, detect_coding, code_convert_region): Now static.
3355 (encode_coding_gap): Remove; unused.
3356
38dfbee1
PE
3357 * chartab.c (chartab_chars, chartab_bits): Now static.
3358
a2cb4e63
PE
3359 * charset.h (charset_iso_8859_1): Remove decl.
3360 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3361 Now static.
3362
127198fd
PE
3363 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3364 * ccl.c (Vccl_program_table): Now static.
3365 (check_ccl_update): Remove; unused.
3366
d85b608f
PE
3367 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3368 * category.h: ... from here.
3369 * category.c (check_category_table, set_category_set): Now static.
3370
31cd66f3
PE
3371 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3372 * lisp.h: Remove these decls.
3373
c358e587
PE
3374 * buffer.c (buffer_count): Remove unused var.
3375
e78aecca
PE
3376 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3377 so that it's not optimized away.
3378 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3379 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3380 exported only to the debugger.
3381
e192d7d3 3382 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3383 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3384
92470028
PE
3385 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3386 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3387 was inaccessible from Lisp.
3388 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3389 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3390
244ed907
PE
3391 alloc.c: Import and export fewer symbols, and remove unused items.
3392 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3393 is defined.
3394 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3395 it's not optimized away by whole-program optimization.
3396 (message_enable_multibyte, free_misc): Remove.
3397 (catchlist, handlerlist, mark_backtrace):
3398 Declare only if BYTE_MARK_STACK.
3399 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3400 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3401 (message_enable_multibyte): Remove decl.
3402 (free_misc, interval_free_list, float_block, float_block_index):
3403 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3404 (cons_free_list, last_marked_index):
3405 Now static.
3406 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3407 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3408 (mark_backtrace): Define only if BYTE_MARK_STACK.
3409 * xdisp.c (message_enable_multibyte): Now static.
3410
61c2b50e 3411 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3412 This makes it easier for human readers (and static analyzers)
3413 to see whether these variables are used from other modules.
3414 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3415 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3416 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3417 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3418 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3419 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3420 * xmenu.c, xselect.c:
3421 Declare Q* vars static if they are not used in other modules.
3422 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3423 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3424 Remove decls of unexported vars.
3425 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3426
95c82688
PE
3427 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3428
16a97296
PE
3429 Make Emacs functions such as Fatom 'static' by default.
3430 This makes it easier for human readers (and static analyzers)
3431 to see whether these functions can be called from other modules.
3432 DEFUN now defines a static function. To make the function external
3433 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3434 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3435 (Finit_image_library):
16a97296
PE
3436 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3437 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3438 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3439 Remove decls, since these functions are now static.
3440 (Funintern, Fget_internal_run_time): New decls, since these functions
3441 were already external.
95c82688 3442
16a97296
PE
3443 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3444 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3445 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3446 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3447 * keyboard.c, keymap.c, lread.c:
3448 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3449 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3450 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3451 Mark functions with DEFUE instead of DEFUN,
3452 if they are used in other modules.
3453 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3454 decls for now-static functions.
3455 * buffer.h (Fdelete_overlay): Remove decl.
3456 * callproc.c (Fgetenv_internal): Mark as internal.
3457 * composite.c (Fremove_list_of_text_properties): Remove decl.
3458 (Fcomposition_get_gstring): New forward static decl.
3459 * composite.h (Fcomposite_get_gstring): Remove decl.
3460 * dired.c (Ffile_attributes): New forward static decl.
3461 * doc.c (Fdocumntation_property): New forward static decl.
3462 * eval.c (Ffetch_bytecode): New forward static decl.
3463 (Funintern): Remove extern decl; now in .h file where it belongs.
3464 * fileio.c (Fmake_symbolic_link): New forward static decl.
3465 * image.c (Finit_image_library): New forward static decl.
3466 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3467 * intervals.h (Fprevious_property_change):
3468 (Fremove_list_of_text_properties): Remove decls.
3469 * keyboard.c (Fthis_command_keys): Remove decl.
3470 (Fcommand_execute): New forward static decl.
3471 * keymap.c (Flookup_key): New forward static decl.
3472 (Fcopy_keymap): Now static.
3473 * keymap.h (Flookup_key): Remove decl.
3474 * process.c (Fget_process): New forward static decl.
3475 (Fprocess_datagram_address): Mark as internal.
3476 * syntax.c (Fsyntax_table_p): New forward static decl.
3477 (skip_chars): Remove duplicate decl.
3478 * textprop.c (Fprevious_property_change): New forward static decl.
3479 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3480 Now internal.
3481 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3482 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3483
785bbd42
PE
3484 * editfns.c (Fformat): Remove unreachable code.
3485
8b913b57
AS
34862011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3487
3488 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3489 change. (Bug#8496)
3490
a6744a35
EZ
34912011-04-13 Eli Zaretskii <eliz@gnu.org>
3492
3493 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3494 when at ZV. (Bug#8487)
3495
e7974947
AS
34962011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3497
baad03f0
AS
3498 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3499 (Bug#8437)
3500 * keyboard.c (parse_tool_bar_item): Likewise.
3501 * sound.c (sound_cleanup, alsa_close): Likewise.
3502 * termcap.c (tgetent): Likewise.
3503 * xfns.c (x_default_font_parameter): Likewise.
3504 * xsettings.c (read_and_apply_settings): Likewise.
3505
e7974947
AS
3506 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3507 (overrun_check_free): Protoize.
3508
28272684
PE
35092011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3510
3511 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3512 since callers should never pass a negative size.
3513 Change the signature to match that of plain 'read' and 'write'; see
3514 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3515 * lisp.h: Update prototypes of emacs_write and emacs_read.
3516
11997c76
EZ
35172011-04-11 Eli Zaretskii <eliz@gnu.org>
3518
3519 * xdisp.c (redisplay_window): Don't try to determine the character
3520 position of the scroll margin if the window start point w->startp
e896f03c 3521 is outside the buffer's accessible region. (Bug#8468)
11997c76 3522
8a2cbd72
EZ
35232011-04-10 Eli Zaretskii <eliz@gnu.org>
3524
3525 Fix write-region and its subroutines for buffers > 2GB.
3526 * fileio.c (a_write, e_write): Modify declaration of arguments and
3527 local variables to support buffers larger than 2GB.
3528 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3529
3530 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3531 argument, local variables, and return value.
3532
3533 * lisp.h: Update prototypes of emacs_write and emacs_read.
3534
3535 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3536
4073e537 35372011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3538
1ebfdcb6
PE
3539 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3540
b2ded58d
PE
3541 Fix more problems found by GCC 4.6.0's static checks.
3542
7d66342c
PE
3543 * xdisp.c (vmessage): Use a better test for character truncation.
3544
bbf47d44
PE
3545 * charset.c (load_charset_map): <, not <=, for optimization,
3546 and to avoid potential problems with integer overflow.
9248994d 3547 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3548 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3549 * editfns.c (Fformat): Likewise.
1e69125e 3550 * syntax.c (skip_chars): Likewise.
3befa583 3551
e3019616
PE
3552 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3553 This also lets GCC 4.6.0 generate slightly better loop code.
3554
becfa255
PE
3555 * callint.c (Fcall_interactively): <, not <=, for optimization.
3556 (Fcall_interactively): Count the number of arguments produced,
3557 not the number of arguments given. This is simpler and lets GCC
3558 4.6.0 generate slightly better code.
3559
dae0cd48
PE
3560 * ftfont.c: Distingish more carefully between FcChar8 and char.
3561 The previous code passed unsigned char * to a functions like
3562 strlen and xstrcasecmp that expect char *, which does not
3563 conform to the C standard.
3564 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3565 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3566 char * when the C standard requires it.
3567
76032d70
PE
3568 * keyboard.c (read_char): Remove unused var.
3569
eb3f1cc8
PE
3570 * eval.c: Port to Windows vsnprintf (Bug#8435).
3571 Include <limits.h>.
3572 (SIZE_MAX): Define if the headers do not.
3573 (verror): Do not give up if vsnprintf returns a negative count.
3574 Instead, grow the buffer. This ports to Windows vsnprintf, which
3575 does not conform to C99. Problem reported by Eli Zaretskii.
3576 Also, simplify the allocation scheme, by avoiding the need for
3577 calling realloc, and removing the ALLOCATED variable.
3578
70476b54
PE
3579 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3580
12020a9e
PE
3581 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3582 But keep the doprint source code for now, as we might revamp it
3583 and use it again (Bug#8435).
ea6c7ae6
PE
3584 * lisp.h (doprnt): Remove.
3585 * Makefile.in (base_obj): Remove doprnt.o.
3586 * deps.mk (doprnt.o): Remove.
3587
5fdb398c
PE
3588 error: Print 32- and 64-bit integers portably (Bug#8435).
3589 Without this change, on typical 64-bit hosts error ("...%d...", N)
3590 was used to print both 32- and 64-bit integers N, which relied on
3591 undefined behavior.
3592 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3593 New macro.
3594 * lisp.h (error, verror): Mark as printf-like functions.
3595 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3596 Report overflow in size calculations when allocating printf buffer.
3597 Do not truncate output string at its first null byte.
3598 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3599 Truncate the output at a character boundary, since vsnprintf does not
3600 do that.
3601 * charset.c (check_iso_charset_parameter): Convert internal
3602 character to string before calling 'error', since %c now has the
3603 printf meaning.
3604 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3605 overflow when computing char to be passed to 'error'. Do not
3606 pass Lisp_Object to 'error'; pass the integer instead.
3607 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3608 formatted with plain %d.
3609
b189fa66
PE
3610 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3611
bff87ef0
PE
3612 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3613
7e2cac20
PE
3614 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3615
ce4d90b5
PE
3616 * xterm.c (x_catch_errors): Remove duplicate declaration.
3617
266c9547
PE
3618 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3619
79c49ad2
PE
3620 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3621
368f4090
JM
36222011-04-10 Jim Meyering <meyering@redhat.com>
3623
3624 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3625 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3626 return ssize_t not "int", and use size_t as the buffer length.
3627 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3628 * gnutls.h: Update declarations.
3629 * process.c (read_process_output): Use ssize_t, to match.
3630 (send_process): Likewise.
3631
a32d4040
CY
36322011-04-09 Chong Yidong <cyd@stupidchicken.com>
3633
3634 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3635
8546720e 36362011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3637
04f2d78b
CB
3638 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3639 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3640
8546720e
GM
3641 * xterm.c (handle_one_xevent):
3642 * xmenu.c (create_and_show_popup_menu):
3643 * xselect.c (x_decline_selection_request)
3644 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3645
0a2f5c1a 36462011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3647
3648 Fix some uses of `int' instead of EMACS_INT.
3649 * search.c (string_match_1, fast_string_match)
3650 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3651 (scan_buffer, find_next_newline_no_quit)
3652 (find_before_next_newline, search_command, Freplace_match)
3653 (Fmatch_data): Make some `int' variables be EMACS_INT.
3654
3655 * xdisp.c (display_count_lines): 3rd argument and return value now
3656 EMACS_INT. All callers changed.
3657 (pint2hrstr): Last argument is now EMACS_INT.
3658
3659 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3660 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3661 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3662 (decode_coding_utf_16, decode_coding_emacs_mule)
3663 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3664 (decode_coding_ccl, decode_coding_charset)
3665 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3666 (decode_coding_iso_2022, decode_coding_emacs_mule)
3667 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3668 <char_offset, last_offset>: Declare EMACS_INT.
3669 (encode_coding_utf_8, encode_coding_utf_16)
3670 (encode_coding_emacs_mule, encode_invocation_designation)
3671 (encode_designation_at_bol, encode_coding_iso_2022)
3672 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3673 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3674 Declare EMACS_INT.
3675 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3676 (encode_invocation_designation): Last argument P_NCHARS is now
3677 EMACS_INT.
3678 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3679 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3680
3681 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3682 All users changed.
3683
3684 * ccl.c (Fccl_execute_on_string): Declare some variables
3685 EMACS_INT.
3686
8546720e 36872011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3688
3689 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3690
4e19a977
CS
36912011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3692
3693 * process.c (Fformat_network_address): Doc fix.
3694
87302331
R
36952011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3696
3697 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3698
cbb59342
CY
36992011-04-08 Chong Yidong <cyd@stupidchicken.com>
3700
3701 * keyboard.c (read_char): Call Lisp function help-form-show,
3702 instead of using internal_with_output_to_temp_buffer.
3703 (Qhelp_form_show): New var.
e0d38eeb 3704 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3705
3706 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3707
3708 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3709
e67a13ab
CY
37102011-04-06 Chong Yidong <cyd@stupidchicken.com>
3711
04f2d78b
CB
3712 * process.c (Flist_processes): Remove to Lisp.
3713 (list_processes_1): Delete.
e67a13ab 3714
973f782d
EZ
37152011-04-06 Eli Zaretskii <eliz@gnu.org>
3716
7c106b1e
EZ
3717 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3718
973f782d
EZ
3719 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3720
41cf7d1a 37212011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3722
ca23cc88
PE
3723 Fix more problems found by GCC 4.6.0's static checks.
3724
f390e2d5
PE
3725 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3726
42eea0d0
PE
3727 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3728
b69769da 3729 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3730
f9541e84
PE
3731 * xdisp.c (vmessage): Mark as a printf-like function.
3732
13841b55
PE
3733 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3734
c136c10f
PE
3735 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3736
5e2d4a30
PE
3737 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3738 printf-like functions.
3739 (tiff_load): Add casts to remove these marks before passing them
3740 to system-supplied API.
3741
583f48b9
PE
3742 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3743
b25d760e
PE
3744 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3745 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3746 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3747 directly, rather than having caller test rule sign. This avoids
3748 some unnecessary tests.
3749 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3750 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3751 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3752
bc7b6697 3753 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3754 (xfont_open): Avoid unnecessary tests.
bc7b6697 3755
27ccc379
PE
3756 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3757
dcd5c89a
PE
3758 * composite.h, composite.c (composition_gstring_put_cache):
3759 Use EMACS_INT, not int, for length.
3760
b13a45c6
PE
3761 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3762 breaking out part of COMPOSITION_DECODE_RULE.
3763 (COMPOSITION_DECODE_RULE): Use it.
3764 * composite.c (get_composition_id): Remove unused local vars,
3765 by using the new macro.
3766
1e792e4d
PE
3767 * textprop.c (set_text_properties_1): Change while to do-while,
3768 since the condition is always true at first.
3769
dc6c6455 3770 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3771 (interval_deletion_adjustment): Return unsigned value.
3772 All uses changed.
dc6c6455 3773
aba7731a
PE
3774 * process.c (list_processes_1, create_pty, read_process_output):
3775 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3776 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3777 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3778 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3779 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3780
fdfc4bf3
PE
3781 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3782
fca8fe46 3783 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3784 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3785
06a0259a 3786 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3787 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3788 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3789
e7b9e80f
PE
3790 * print.c (print_error_message): Avoid int overflow.
3791
56201685
PE
3792 * font.c (font_list_entities): Redo for clarity,
3793 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3794
78834453 3795 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3796 (font_score): Avoid potential overflow in diff calculation.
78834453 3797
0bc0b309 3798 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3799 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3800
e610eaca
PE
3801 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3802
b895abce
PE
3803 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3804 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3805 can always succeed if overflow has undefined behavior.
3806
1f1d9321 3807 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3808 (wordify): Omit three unnecessary tests.
1f1d9321 3809
c59478bc
PE
3810 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3811 All callers changed. This avoids the need for an unused var.
3812
79b73827
PE
3813 * casefiddle.c (casify_region): Remove var that is set but not used.
3814
a4db5dfe
PE
3815 * dired.c (file_name_completion): Remove var that is set but not used.
3816
43aae36e
PE
3817 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3818
2a47c44d 3819 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3820 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3821
a37c69bf
PE
3822 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3823 Check for integer overflow on size calculations.
3824
328ab8e7
PE
3825 * buffer.c (Fprevious_overlay_change): Remove var that is set
3826 but not used.
3827
e5a2a5cb
PE
3828 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3829 Remove vars that are set but not used.
8d84a6eb 3830 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3831 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3832
a60e5f68
PE
3833 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3834
f661cb61 3835 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3836 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3837
f0397f5a
PE
3838 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3839 that are set but not used.
3840
8664db06 3841 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3842 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3843
6abdaa4a
PE
3844 * xselect.c (x_get_local_selection, x_handle_property_notify):
3845 Remove vars that are set but not used.
3846
0ce7538d 3847 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3848 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3849
9ae848fc
PE
3850 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3851 Remove var that is set but not used.
0b918413
PE
3852 (scroll_bar_windows_size): Now size_t, not int.
3853 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3854 Check for overflow.
9ae848fc 3855
a5a62657
PE
3856 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3857 (map_tty_color) [!defined MSDOS]: Likewise.
3858
5c5cdd39
PE
3859 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3860
66ebf983
PE
3861 * coding.c: Remove vars that are set but not used.
3862 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3863 All callers changed.
3864 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3865 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3866 (decode_coding_charset): Remove vars that are set but not used.
3867
1be4d761
PE
3868 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3869 that is set but not used.
3870
47553fa8
PE
3871 * print.c (print_object): Remove var that is set but not used.
3872
1f7196bf 3873 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3874 The gnulib version avoids calling malloc in the usual case,
3875 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3876 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3877 * filelock.c (current_lock_owner): Likewise.
3878 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3879 * sysdep.c: Include allocator.h, careadlinkat.h.
3880 (emacs_no_realloc_allocator): New static constant.
3881 (emacs_readlink): New function.
fdb61804
PE
3882 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3883 ../lib/careadlinkat.h.
d1fdcab7 3884
f84c17c7
SM
38852011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3886
3887 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3888 first non-nil return value).
3889
ef3862ad
JD
38902011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3891
3892 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3893 if not defined (Bug#8403).
3894
376a7006
JB
38952011-04-02 Juanma Barranquero <lekktu@gmail.com>
3896
3897 * xdisp.c (display_count_lines): Remove parameter `start',
3898 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3899 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3900 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3901 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3902 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3903 and thereabouts. All callers changed.
3904 (get_per_char_metric): Remove parameter `f', unused since
3905 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3906
6ca3801d
JM
39072011-04-02 Jim Meyering <meyering@redhat.com>
3908
3909 do not dereference NULL upon failed strdup
3910 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3911 (ns_get_family): Likewise.
3912
d8e2b5ba
JB
39132011-04-02 Juanma Barranquero <lekktu@gmail.com>
3914
3915 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3916
8c74fcbd
JD
39172011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3918
3919 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3920 later (Bug#8403).
3921
7200d79c
SM
39222011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3923
03408648 3924 Add lexical binding.
7200d79c 3925
03408648
SM
3926 * window.c (Ftemp_output_buffer_show): New fun.
3927 (Fsave_window_excursion):
3928 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3929
3930 * lread.c (lisp_file_lexically_bound_p): New function.
3931 (Fload): Bind Qlexical_binding.
3932 (readevalloop): Remove `evalfun' arg.
3933 Bind Qinternal_interpreter_environment.
3934 (Feval_buffer): Bind Qlexical_binding.
3935 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3936 Mark as dynamic.
3937 (syms_of_lread): Declare `lexical-binding'.
3938
3939 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3940
3941 * keyboard.c (eval_dyn): New fun.
3942 (menu_item_eval_property): Use it.
ca105506
SM
3943
3944 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3945
03408648
SM
3946 * fns.c (concat, mapcar1): Accept byte-code-functions.
3947
3948 * eval.c (Fsetq): Handle lexical vars.
3949 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3950 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3951 (FletX, Flet): Obey lexical binding.
3952 (Fcommandp): Handle closures.
3953 (Feval): New `lexical' arg.
3954 (eval_sub): New function extracted from Feval. Use it almost
3955 everywhere where Feval was used. Look up vars in lexical env.
3956 Handle closures.
3957 (Ffunctionp): Move from subr.el.
3958 (Ffuncall): Handle closures.
3959 (apply_lambda): Remove `eval_flags'.
3960 (funcall_lambda): Handle closures and new byte-code-functions.
3961 (Fspecial_variable_p): New function.
3962 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3963 but without exporting it to Lisp.
23aba0ea 3964
23aba0ea 3965 * doc.c (Fdocumentation, store_function_docstring):
03408648 3966 * data.c (Finteractive_form): Handle closures.
23aba0ea 3967
03408648
SM
3968 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3969 interactive spec.
ba83908c 3970
04f2d78b
CB
3971 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3972 New byte-codes.
03408648
SM
3973 (exec_byte_code): New function extracted from Fbyte_code to handle new
3974 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3975
03408648 3976 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3977
03408648 3978 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3979
e2abce01
JB
39802011-03-31 Juanma Barranquero <lekktu@gmail.com>
3981
3982 * xdisp.c (redisplay_internal): Fix prototype.
3983
63696a73 39842011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3985
63696a73 3986 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3987 (try_scrolling): Use it when setting scroll_limit.
3988 Limit scrolling to 100 screen lines.
63696a73
EZ
3989 (redisplay_window): Even when falling back on "recentering",
3990 position point in the window according to scroll-conservatively,
3991 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3992
3993 (try_scrolling): When point is above the window, allow searching
3994 as far as scroll_max, or one screenful, to compute vertical
3995 distance from PT to the scroll margin position. This prevents
3996 try_scrolling from unnecessarily failing when
3997 scroll-conservatively is set to a value slightly larger than the
3998 window height. Clean up the case of PT below the margin at bottom
3999 of window: scroll_max can no longer be INT_MAX. When aggressive
4000 scrolling is in use, don't let point enter the opposite scroll
4001 margin as result of the scroll.
4002 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4003 threshold of 100 lines for never-recentering scrolling.
4004
e4cc2dfc
JB
40052011-03-31 Juanma Barranquero <lekktu@gmail.com>
4006
4007 * dispextern.h (move_it_by_lines):
4008 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4009 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4010 (message_log_check_duplicate): Remove parameters `prev_bol' and
4011 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4012 (redisplay_internal): Remove parameter `preserve_echo_area',
4013 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4014
4015 * indent.c (Fvertical_motion):
4016 * window.c (window_scroll_pixel_based, Frecenter):
4017 Don't pass `need_y_p' to `move_it_by_lines'.
4018
1c470562
SM
40192011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4020
44f230aa
SM
4021 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4022 steal a few bits to be more compact.
4023 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4024 Remove unneeded casts.
4025
1c470562
SM
4026 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4027
888adce9
ZK
40282011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4029
4030 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4031 binding" message (bug#7967).
4032
f838ed7b
PE
40332011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4034
77861b95
PE
4035 Fix more problems found by GCC 4.6.0's static checks.
4036
de6dbc14
PE
4037 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4038 Remove unused local var.
4039
f838ed7b
PE
4040 * editfns.c (Fmessage_box): Remove unused local var.
4041
792c7b2b
PE
4042 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4043 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4044 Omit unused local vars.
c499e557 4045 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4046 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4047 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4048 Omit unused local var.
4049
ba0165e1
PE
4050 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4051 Don't assume string length fits in int.
32ad8845 4052 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4053 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4054
3c59b4c9
PE
4055 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4056 instead of alloca (Bug#8344).
4057
a3eed478 4058 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4059 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4060
eb4d412d
PE
4061 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4062
1658b401
PE
4063 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4064 concerns.
4065
4066 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4067
4068 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4069
9a2c6e05
PE
4070 * keyboard.c (syms_of_keyboard): Use the same style as later
4071 in this function when indexing through an array. This also
4072 works around GCC bug 48267.
4073
03d0a109
PE
4074 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4075
44f730c8
PE
4076 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4077
fe75f926
PE
4078 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4079 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4080
ffa8c828
PE
4081 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4082 This avoids undefined behavior on integer overflow, and is a bit
4083 more convenient anyway since it is compared to a size_t variable.
4084
c5101a77
PE
4085 Variadic C functions now count arguments with size_t, not int.
4086 This avoids an unnecessary limitation on 64-bit machines, which
4087 caused (substring ...) to crash on large vectors (Bug#8344).
4088 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4089 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4090 All variadic functions and their callers changed accordingly.
c5101a77
PE
4091 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4092 * data.c (arith_driver, float_arith_driver): Likewise.
4093 * editfns.c (general_insert_function): Likewise.
4094 * eval.c (struct backtrace.nargs, interactive_p)
4095 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4096 (funcall_lambda, mark_backtrace): Likewise.
4097 * fns.c (concat): Likewise.
4098 * frame.c (x_set_frame_parameters): Likewise.
4099 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4100 0 if not found, not -1. All callers changed.
4101
dd3f25f7
PE
4102 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4103 (stack_copy_size): Now size_t, not int.
4104 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4105
461c2ab9
JB
41062011-03-28 Juanma Barranquero <lekktu@gmail.com>
4107
4108 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4109 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4110 All callers changed.
4111
4112 * lisp.h (multibyte_char_to_unibyte):
4113 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4114 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4115 * character.h (CHAR_TO_BYTE8):
4116 * cmds.c (internal_self_insert):
4117 * editfns.c (general_insert_function):
4118 * keymap.c (push_key_description):
4119 * search.c (Freplace_match):
4120 * xdisp.c (message_dolog, set_message_1): All callers changed.
4121
f6d62986
SM
41222011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4123
4124 * keyboard.c (safe_run_hook_funcall): New function.
4125 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4126 don't set the hook to nil, but remove the offending function instead.
4127 (Qcommand_hook_internal): Remove, unused.
4128 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4129 Vcommand_hook_internal.
4130
4131 * eval.c (enum run_hooks_condition): Remove.
4132 (funcall_nil, funcall_not): New functions.
4133 (run_hook_with_args): Call each function through a `funcall' argument.
4134 Remove `cond' argument, now redundant.
4135 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4136 (Frun_hook_with_args_until_failure): Adjust accordingly.
4137 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4138
1db5b1ad
JB
41392011-03-28 Juanma Barranquero <lekktu@gmail.com>
4140
4141 * dispextern.h (string_buffer_position): Remove declaration.
4142
4143 * print.c (strout): Remove parameter `multibyte', unused since
4144 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4145
4146 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4147 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4148 All callers changed.
4149
4150 * w32.c (_wsa_errlist): Use braces for struct initializers.
4151
4152 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4153 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4154 All callers changed.
4155 (string_buffer_position): Likewise. Also, make static (it's never
4156 used outside xdisp.c).
4157 (cursor_row_p): Remove parameter `w', unused since
4158 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4159 (decode_mode_spec): Remove parameter `precision', introduced during
4160 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4161 All callers changed.
4162
5ffb62aa
JD
41632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4164
4165 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4166
461c2ab9 41672011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4168
4169 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4170 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4171 (ns_update_auto_hide_menu_bar): New functions.
4172 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4173 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4174 ns_constrain_all_frames.
4175 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4176 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4177
5c380ffb
JD
41782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4179
4180 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4181
9af30bdf
GM
41822011-03-27 Glenn Morris <rgm@gnu.org>
4183
4184 * syssignal.h: Replace RETSIGTYPE with void.
4185 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4186 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4187 Replace SIGTYPE with void everywhere.
4188 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4189 * s/template.h (SIGTYPE): Remove commented out definition.
4190
e2abce01
JB
41912011-03-26 Eli Zaretskii <eliz@gnu.org>
4192
4193 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4194 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4195
f868cd8a
JB
41962011-03-26 Juanma Barranquero <lekktu@gmail.com>
4197
59eb0929
JB
4198 * w32.c (read_unc_volume): Use parameter `henum', instead of
4199 global variable `wget_enum_handle'.
4200
4201 * keymap.c (describe_vector): Remove parameters `indices' and
4202 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4203 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4204
f868cd8a
JB
4205 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4206
4207 * keyboard.c (timer_check): Remove parameter `do_it_now',
4208 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4209 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4210 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4211
4212 * keyboard.c (read_char):
4213 * w32menu.c (w32_menu_display_help):
4214 * xmenu.c (show_help_event, menu_help_callback):
4215 Adjust calls to `show_help_echo'.
4216
4217 * gtkutil.c (xg_maybe_add_timer):
4218 * keyboard.c (readable_events):
4219 * process.c (wait_reading_process_output):
4220 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4221
4222 * insdel.c (adjust_markers_gap_motion):
4223 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4224 (gap_left, gap_right): Don't call it.
4225
2ecf6fdb
CY
42262011-03-25 Chong Yidong <cyd@stupidchicken.com>
4227
4228 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4229 incurred during fontification.
4230
6b1f9ba4
JB
42312011-03-25 Juanma Barranquero <lekktu@gmail.com>
4232
4233 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4234 (DEFVAR_PER_BUFFER): Don't pass it.
4235
4236 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4237 (scrolling_window): Don't pass it.
4238
0f4a96b5
JB
42392011-03-25 Juanma Barranquero <lekktu@gmail.com>
4240
4241 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4242
4243 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4244 and `suffix'.
4245 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4246 of variables specific to SELinux and computation of `encoded_absname'.
4247
4248 * image.c (XPutPixel): Remove unused variable `height'.
4249
4250 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4251
4252 * unexw32.c (get_section_info): Remove unused variable `section'.
4253
4254 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4255 (system_process_attributes): Remove unused variable `sess'.
4256 (sys_read): Remove unused variable `err'.
4257
4258 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4259 (w32_wnd_proc): Remove unused variable `isdead'.
4260 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4261 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4262 (x_create_tip_frame): Remove unused variable `tem'.
4263
4264 * w32inevt.c (w32_console_read_socket):
4265 Remove unused variable `no_events'.
4266
4267 * w32term.c (x_draw_composite_glyph_string_foreground):
4268 Remove unused variable `width'.
4269
1149507c
JB
42702011-03-24 Juanma Barranquero <lekktu@gmail.com>
4271
4272 * w32term.c (x_set_glyph_string_clipping):
4273 Don't pass uninitialized region to CombineRgn.
4274
9c88f339
JB
42752011-03-23 Juanma Barranquero <lekktu@gmail.com>
4276
4277 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4278 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4279 (Fx_close_connection): Remove unused variable `i'.
4280
4281 * w32font.c (w32font_draw): Return number of glyphs.
4282 (w32font_open_internal): Remove unused variable `i'.
4283 (w32font_driver): Add missing initializer.
4284
4285 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4286 (fill_in_menu): Remove unused variable `items_added'.
4287
4288 * w32term.c (last_mouse_press_frame): Remove static global variable.
4289 (w32_clip_to_row): Remove unused variable `f'.
4290 (x_delete_terminal): Remove unused variable `i'.
4291
4292 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4293 (NOTHING): Remove unused static global variable.
4294 (uniscribe_check_otf): Remove unused variable `table'.
4295 (uniscribe_font_driver): Add missing initializers.
4296
dee091a3
JD
42972011-03-23 Julien Danjou <julien@danjou.info>
4298
4299 * term.c (Fsuspend_tty, Fresume_tty):
4300 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4301 * window.c (temp_output_buffer_show):
4302 * insdel.c (signal_before_change):
4303 * frame.c (Fhandle_switch_frame):
4304 * fileio.c (Fdo_auto_save):
4305 * emacs.c (Fkill_emacs):
4306 * editfns.c (save_excursion_restore):
4307 * cmds.c (internal_self_insert):
4308 * callint.c (Fcall_interactively):
4309 * buffer.c (Fkill_all_local_variables):
4310 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4311 Use Frun_hooks.
0f4a96b5 4312 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4313 unconditionnaly since it does the check itself.
4314
2c520ab5 43152011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4316
c9c49752
PE
4317 Fix more problems found by GCC 4.5.2's static checks.
4318
8abc3f12
PE
4319 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4320 the first time through the loop, since we know p0 < p1 then.
4321 This also avoids a gcc -Wstrict-overflow warning.
4322
a2d26660
PE
4323 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4324 leading to a memory leak, possible in functions like
4325 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4326 of objects (Bug#8318).
a2d26660 4327
916c72e9
PE
4328 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4329 that could (at least in theory) be that large.
4330
19ab8a18
PE
4331 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4332 This is less likely to overflow, and avoids undefined behavior if
4333 overflow does occur. All callers changed. Use strtoul to scan
4334 for the unsigned long integer.
b7cbbd6f
PE
4335 (pint2hrstr): Simplify and tune code slightly.
4336 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4337
f0641eff
PE
4338 * scroll.c (do_scrolling): Work around GCC bug 48228.
4339 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4340
7f650bb9
PE
4341 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4342 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4343 (validate_x_resource_name): Simplify count usage.
4344 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4345
37dd57d1
PE
4346 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4347 fail (Bug#8306).
81e56e61 4348
699979fc 4349 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4350
401bf9b4
PE
4351 * process.c (Fmake_network_process): Use socklen_t, not int,
4352 where POSIX says socklen_t is required in portable programs.
4353 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4354 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4355 (Fmake_network_process, server_accept_connection):
4356 (wait_reading_process_output, read_process_output):
4357 Likewise.
4358
b93aacde
PE
4359 * process.c: Rename or move locals to avoid shadowing.
4360 (list_processes_1, Fmake_network_process):
4361 (read_process_output_error_handler, exec_sentinel_error_handler):
4362 Rename or move locals.
4dc343ee 4363 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4364 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4365 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4366 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4367 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4368
af8a867c 4369 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4370 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4371 Include tparam.h instead, since it declares them.
af8a867c
PE
4372 * cm.h (PC): Remove extern decl; tparam.h now does this.
4373 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4374 * terminfo.c: Include tparam.h, to check interfaces.
4375 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4376 (tparam): Adjust signature to match interface in tparam.h;
4377 this removes some undefined behavior. Check that outstring and len
4378 are zero, which they always are with Emacs.
4379 * tparam.h (PC, BC, UP): New extern decls.
4380
0248044d 4381 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4382 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4383
8ff096c1 4384 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4385 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4386 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4387 (ftfont_list): Remove unused local.
49eaafba
PE
4388 (get_adstyle_property, ftfont_pattern_entity):
4389 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4390 Rename locals to avoid shadowing.
8ff096c1 4391
e2be39f6
PE
4392 * xfont.c (xfont_list_family): Mark var as initialized.
4393
c9735e30
PE
4394 * xml.c (make_dom): Now static.
4395
8f5201ae
PE
4396 * composite.c (composition_compute_stop_pos): Rename local to
4397 avoid shadowing.
b246f932
PE
4398 (composition_reseat_it): Remove unused locals.
4399 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4400 (composition_update_it): Mark var as initialized.
11b61122
PE
4401 (find_automatic_composition): Mark vars as initialized,
4402 with a FIXME (Bug#8290).
8f5201ae 4403
760fbc2c
PE
4404 character.h: Rename locals to avoid shadowing.
4405 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4406 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4407 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4408 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4409 to avoid shadowing.
4410
ff08eb85
PE
4411 * textprop.c (property_change_between_p): Remove; unused.
4412
fc7bf025
PE
4413 * intervals.c (interval_start_pos): Now static.
4414
235d7abc
PE
4415 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4416
44f230aa
SM
4417 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4418 Rename locals to avoid shadowing.
3e7d6594 4419
50060332
PE
4420 * sound.c (wav_play, au_play, Fplay_sound_internal):
4421 Fix pointer signedness.
d01f234b 4422 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4423 (wav_play): Initialize a variable to 0, to prevent undefined
4424 behavior (Bug#8278).
50060332 4425
c4fc4e30
PE
4426 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4427
918436ed
PE
4428 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4429
c939f91b
PE
4430 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4431 clobbering (Bug#8298).
b9c7f648
PE
4432 * sysdep.c (sys_subshell): Likewise.
4433 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4434
6bd8c144
PE
4435 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4436 This should get cleaned up, so that child_setup has the
4437 same signature on all platforms.
4438
7710357c 4439 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4440 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4441
c59da222
CY
44422011-03-22 Chong Yidong <cyd@stupidchicken.com>
4443
4444 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4445 not to be necessary, and produces flickering.
4446
66b87493
GM
44472011-03-20 Glenn Morris <rgm@gnu.org>
4448
4449 * config.in: Remove file.
4450
45b6f6d5
JB
44512011-03-20 Juanma Barranquero <lekktu@gmail.com>
4452
4453 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4454 are now in src/globals.h.
4455 (syms_of_minibuf): Remove spurious & from previous change.
4456
3ec03f7e
LL
44572011-03-20 Leo <sdl.web@gmail.com>
4458
4459 * minibuf.c (completing-read-function): New variable.
4460 (completing-read-default): Rename from completing-read.
4461 (completing-read): Call completing-read-function.
4462
b14e3e21
CY
44632011-03-19 Juanma Barranquero <lekktu@gmail.com>
4464
4465 * xfaces.c (Fx_load_color_file):
4466 Read color file from absolute filename (bug#8250).
4467
f2b726e6
JB
44682011-03-19 Juanma Barranquero <lekktu@gmail.com>
4469
4470 * makefile.w32-in: Update dependencies.
4471
09f6ff02
EZ
44722011-03-17 Eli Zaretskii <eliz@gnu.org>
4473
4474 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4475
29a6015a
PE
44762011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4477
a3a6c54e
PE
4478 Fix more problems found by GCC 4.5.2's static checks.
4479
b766f867
PE
4480 * process.c (make_serial_process_unwind, send_process_trap):
4481 (sigchld_handler): Now static.
4482
be02381c
PE
4483 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4484 That way, the code declares only the vars that it needs.
4485 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4486 * s/cygwin.h (PTY_ITERATION): Likewise.
4487 * s/darwin.h (PTY_ITERATION): Likewise.
4488 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4489
57048744
PE
4490 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4491 * process.c (allocate_pty): Don't declare stb unless it's needed.
4492
7914961c 4493 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4494 (CONSTANTLIM): Remove; unused.
4495 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4496 Define only if needed.
7914961c 4497
b3967b18
PE
4498 * unexelf.c (unexec): Name an expression,
4499 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4500 Use a different way to cause a compilation error if anyone uses
4501 n rather than nn, a way that does not involve shadowing.
73366a00 4502 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4503
29a6015a
PE
4504 * deps.mk (unexalpha.o): Remove; unused.
4505
43cfc33e 4506 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4507 * unexec.h: New file.
ce701a33
PE
4508 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4509 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4510 Depend on unexec.h.
4511 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4512 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4513 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4514 Change as necessary to match prototype in unexec.h.
ce701a33 4515
01f44d5a
PE
4516 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4517 shadowing.
4f63c6bb 4518 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4519
a6670b0b
PE
4520 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4521 Rename locals to avoid shadowing.
4522
cef2010d 4523 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4524 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4525
d4d7173a
PE
4526 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4527
f08b802a
PE
4528 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4529 warning when compiling print.c.
4530
3ddb0639
PE
4531 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4532 instead of using an uninitialized var.
5ad03b97 4533 (font_sort_entities): Mark var as initialized.
3ddb0639 4534
170a2692
PE
4535 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4536
e663c700
PE
4537 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4538 pointers to constants.
89bc529a 4539 (font_parse_fcname): Remove unused vars.
7b81e2d0 4540 (font_delete_unmatched): Now static.
ea838e10 4541 (font_get_spec): Remove; unused.
13a547c6
PE
4542 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4543 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4544 Rename or move locals to avoid shadowing.
e663c700 4545
2a80c887 4546 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4547 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4548
1384fa33 4549 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4550 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4551
8b2c52e9
PE
4552 * alloc.c (mark_backtrace): Move decl from here ...
4553 * lisp.h: ... to here, so that it can be checked.
4554
475545b5 4555 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4556 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4557 (lisp_indirect_variable): Name an expression,
4558 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4559 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4560
b1349114 4561 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4562 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4563 Use const pointer when appropriate.
b1349114 4564
a2928364
PE
4565 * lisp.h (get_system_name, get_operating_system_release):
4566 Move decls here, to check interfaces.
4567 * process.c (get_operating_system_release): Move decl to lisp.h.
4568 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4569 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4570 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4571 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4572 (Fformat_time_string, Fencode_time, Finsert_char):
4573 (Ftranslate_region_internal, Fformat):
4574 Rename or remove local vars to avoid shadowing.
9710023e 4575 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4576
a415e694
PE
4577 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4578 avoid shadowing.
4579
8ef4622d
PE
4580 * lisp.h (eassert): Check that the argument compiles, even if
4581 ENABLE_CHECKING is not defined.
4582
946f9a5b
PE
4583 * data.c (Findirect_variable): Name an expression, to avoid
4584 gcc -Wbad-function-cast warning.
112396d6 4585 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4586 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4587 (Fmake_variable_buffer_local, Fmake_local_variable):
4588 Mark variables as initialized.
52746918 4589 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4590
e5aab7e7 4591 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4592 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4593 Rename locals to avoid shadowing.
dff45157
PE
4594 (mark_stack): Move local variables into the #ifdef region where
4595 they're used.
7bc26fdb
PE
4596 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4597 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4598 needed otherwise.
4599 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4600 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4601 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4602
e5aab7e7
PE
4603 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4604 avoids undefined behavior in theory.
4605
4da60324
PE
4606 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4607
88043301
PE
4608 Use functions, not macros, for up- and down-casing (Bug#8254).
4609 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4610 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4611 to use the following functions instead of these macros.
4612 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4613 EMACS_INT, since callers assume the returned value fits in int.
4614 (upcase1): Likewise, for UPCASE_TABLE.
4615 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4616 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4617 the race-condition problem in the old DOWNCASE.
88043301 4618
19ed5445
PE
4619 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4620 Rename locals to avoid shadowing.
4621 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4622 (regex_compile, re_search_2, re_match_2_internal):
4623 Remove unused local vars.
952db0d7
PE
4624 (FREE_VAR): Rewrite so as not to use empty "else",
4625 which gcc can warn about.
da053e48 4626 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4627 (RETALLOC_IF): Define only if needed.
4628 (WORDCHAR_P): Likewise. This one is never needed, but is used
4629 only in a comment talking about a compiler bug, so put inside
4630 the #if 0 of that comment.
4631 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4632 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4633 Remove; unused.
19ed5445 4634
1f3561e4 4635 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4636 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4637 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4638
ded6f8f7
PE
4639 * search.c (simple_search): Remove unused var.
4640
dbd37a95
PE
4641 * dired.c (compile_pattern): Move decl from here ...
4642 * lisp.h: ... to here, so that it can be checked.
4643 (struct re_registers): New forward decl.
4644
7e47afad
PE
4645 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4646
85f24f61
PE
4647 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4648 All uses changed.
4649 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4650 Rename locals to avoid shadowing.
5671df8f 4651 (Fvertical_motion): Mark locals as initialized.
85f24f61 4652
181aa2be 4653 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4654 (casify_region): Mark local as initialized.
181aa2be 4655
930d429c
PE
4656 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4657
7082eac6
PE
4658 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4659 New macros, so that the caller can use some names other than
4660 gcpro1, gcpro2, etc.
4661 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4662 of the new macros.
4663 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4664 argument, for consistency with GCPRO2_VAR, etc: it is now the
4665 prefix of the variable, not the variable itself. All uses
4666 changed.
38b2c076
PE
4667 * dired.c (directory_files_internal, file_name_completion):
4668 Rename locals to avoid shadowing.
4669
15206ed9
PE
4670 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4671 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4672 dired.c's scmp function, had undefined behavior.
4673 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4674 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4675 * buffer.h: ... to here, because these macros use current_buffer,
4676 and the new implementation with inline functions needs to have
4677 current_buffer in scope now, rather than later when the macros
4678 are used.
4679 (downcase, upcase1): New static inline functions.
4680 (DOWNCASE, UPCASE1): Reimplement using these functions.
4681 This avoids undefined behavior in expressions like
4682 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4683 from race conditions in accessing the global variables
4684 case_temp1 and case_temp2.
4685 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4686 * lisp.h (case_temp1, case_temp2): Remove their decls.
4687 * character.h (ASCII_CHAR_P): Move from here ...
4688 * lisp.h: ... to here, so that the inline functions mentioned
4689 above can use them.
4690
4a6bea26
PE
4691 * dired.c (directory_files_internal_unwind): Now static.
4692
f14b7e14
PE
4693 * fileio.c (file_name_as_directory, directory_file_name):
4694 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4695 Now static.
2893f146
PE
4696 (file_name_as_directory): Use const pointers when appropriate.
4697 (Fexpand_file_name): Likewise. In particular, newdir might
4698 point at constant storage, so make it a const pointer.
fd4ead52 4699 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4700 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4701 signedness issues.
f839df0c
PE
4702 (Fset_file_times, Finsert_file_contents, auto_save_error):
4703 Rename locals to avoid shadowing.
f14b7e14 4704
5716756e 4705 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4706 (Ftry_completion, Fall_completions): Rename or remove locals
4707 to avoid shadowing.
5716756e 4708
b4c3046a
PE
4709 * marker.c (bytepos_to_charpos): Remove; unused.
4710
b45db522
PE
4711 * lisp.h (verify_bytepos, count_markers): New decls,
4712 so that gcc does not warn that these functions aren't declared.
4713
85876d07
PE
4714 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4715 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4716 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4717 (copy_text): Remove unused local var.
85876d07 4718
03d78a21 4719 * filelock.c (within_one_second): Now static.
b3dd38ab 4720 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4721
5df8f01b
PE
4722 * buffer.c (fix_overlays_before): Mark locals as initialized.
4723 (fix_start_end_in_overlays): Likewise. This function should be
4724 simplified by using pointers-to-pointers, but that's a different
4725 matter.
b1d876f1 4726 (switch_to_buffer_1): Now static.
8f54f30a
PE
4727 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4728 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4729
a70072c9 4730 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4731 Fix pointer signedness issue.
edced198
PE
4732 (sys_subshell): Mark local as volatile if checking for lint,
4733 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4734 (MAXPATHLEN): Define only if needed.
a70072c9 4735
a0977c44
PE
4736 * process.c (serial_open, serial_configure): Move decls from here ...
4737 * systty.h: ... to here, so that they can be checked.
4738
a884fdcc
PE
4739 * fns.c (get_random, seed_random): Move extern decls from here ...
4740 * lisp.h: ... to here, so that they can be checked.
4741
604efe86 4742 * sysdep.c (reset_io): Now static.
b8950c94 4743 (wait_for_termination_signal): Remove; unused.
604efe86 4744
38fc62d9
PE
4745 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4746 (copy_keymap_item, append_key, push_text_char_description):
4747 Now static.
1004a21a 4748 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4749 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4750 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4751 (describe_map_tree):
4752 Rename locals to avoid shadowing.
38fc62d9 4753
2f2650da
PE
4754 * keyboard.c: Declare functions static if they are not used elsewhere.
4755 (echo_char, echo_dash, cmd_error, top_level_2):
4756 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4757 (read_char, kbd_buffer_get_event, make_lispy_position):
4758 (make_lispy_event, make_lispy_movement, apply_modifiers):
4759 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4760 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4761 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4762 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4763 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4764
a053e86c 4765 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4766 (mark_kboards): Move decl here ...
4767 * alloc.c (mark_kboards): ... from here.
a053e86c 4768
4752793e
PE
4769 * lisp.h (force_auto_save_soon): New decl.
4770
74f10ca7 4771 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4772 (DEFINE_DUMMY_FUNCTION): New macro.
4773 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4774 Use it.
c03cd23f
PE
4775 (main): Add casts to avoid warnings
4776 if GCC considers string literals to be constants.
74f10ca7 4777
022e70d4
PE
4778 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4779
59d6fe83
PE
4780 * dbusbind.c: Pointer signedness fixes.
4781 (xd_signature, xd_append_arg, xd_initialize):
4782 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4783 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4784 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4785 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4786
78320123
PE
4787 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4788 if GCC considers string literals to be constants.
49cebcca 4789 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4790
35ac2a97
SM
47912011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4792
fb103ca9
SM
4793 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4794 (print_preprocess, print_object): New macro to fix last change.
4795
35ac2a97
SM
4796 * print.c (print_preprocess): Don't forget font objects.
4797
62973b41
JB
47982011-03-16 Juanma Barranquero <lekktu@gmail.com>
4799
4800 * emacs.c (USAGE3): Doc fixes.
4801
0e48bb22
AS
48022011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4803
4804 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4805 structure.
4806
7684e57b
JB
48072011-03-14 Juanma Barranquero <lekktu@gmail.com>
4808
4809 * lisp.h (VWindow_system, Qfile_name_history):
4810 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4811 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4812 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4813
4814 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4815 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4816
4817 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4818 * w32console.c (detect_input_pending, read_input_pending)
4819 (encode_terminal_code):
4820 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4821 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4822 (w32_system_caret_y, Qfile_name_history):
4823 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4824 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4825 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4826 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4827 * w32proc.c (Qlocal, report_file_error):
4828 * w32term.c (Vwindow_system, updating_frame):
4829 * w32uniscribe.c (initialized, uniscribe_font_driver):
4830 Remove unneeded extern declarations.
4831
2aa46d6c
CY
48322011-03-14 Chong Yidong <cyd@stupidchicken.com>
4833
c96bbc66 4834 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4835
cffc6f3b
CY
48362011-03-13 Chong Yidong <cyd@stupidchicken.com>
4837
4838 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4839 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4840 These macros can no longer be used for assignment.
4841
44f230aa
SM
4842 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4843 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4844 (record_buffer_markers, fetch_buffer_markers): New functions for
4845 recording and fetching special buffer markers.
4846 (set_buffer_internal_1, set_buffer_temp): Use them.
4847
4848 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4849
4850 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4851
4852 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4853 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4854
4855 * xdisp.c (hscroll_window_tree):
4856 (reconsider_clip_changes): Use PT instead of BUF_PT.
4857
d251f04b
EZ
48582011-03-13 Eli Zaretskii <eliz@gnu.org>
4859
4860 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4861 $(EMACS_ROOT)/lib/intprops.h.
4862
f0c77cd1
PE
48632011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4864
3eca4629
PE
4865 Fix more problems found by GCC 4.5.2's static checks.
4866
7c86ee98
PE
4867 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4868 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4869 (xg_free_frame_widgets): Make it clear that a local variable is
4870 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4871 (gdk_window_get_screen): Make it clear that this macro is needed
4872 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4873 (int_gtk_range_get_value): New function, which avoids a diagnostic
4874 from gcc -Wbad-function-cast.
4875 (xg_set_toolkit_scroll_bar_thumb): Use it.
4876 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4877 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4878 (get_utf8_string, xg_get_file_with_chooser):
4879 Rename locals to avoid shadowing.
4880 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4881
41729b81
PE
4882 * xgselect.c (xg_select): Remove unused var.
4883
f0c77cd1
PE
4884 * image.c (four_corners_best): Mark locals as initialized.
4885 (gif_load): Initialize transparent_p to zero (Bug#8238).
4886 Mark another local as initialized.
ec6cf4c6 4887 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4888
ce0ad53d 4889 * image.c (clear_image_cache): Now static.
d5d5a617 4890 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4891 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4892 (x_edge_detection): Remove unnecessary cast that
4893 gcc -Wbad-function-cast diagnoses.
2037898d 4894 (gif_load): Fix pointer signedness.
6ae141d6
PE
4895 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4896 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4897
33383987 48982011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4899
d32df629
PE
4900 Improve quality of tests for time stamp overflow.
4901 For example, without this patch (encode-time 0 0 0 1 1
4902 1152921504606846976) returns the obviously-bogus value (-948597
4903 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4904 reports time overflow. See
4905 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4906 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4907 * editfns.c: Include limits.h and intprops.h.
4908 (TIME_T_MIN, TIME_T_MAX): New macros.
4909 (time_overflow): Move earlier, to before first use.
4910 (hi_time, lo_time): New functions, for an accurate test for
4911 out-of-range times.
4912 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4913 (Fget_internal_run_time): Don't assume time_t fits in int.
4914 (make_time): Use list2 instead of Fcons twice.
4915 (Fdecode_time): More accurate test for out-of-range times.
4916 (check_tm_member): New function.
4917 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4918 (lisp_time_argument): Don't rely on undefined left-shift and
4919 right-shift behavior when checking for time stamp overflow.
8be6f318 4920
fe31d94c
PE
4921 * editfns.c (time_overflow): New function, refactoring common code.
4922 (Fformat_time_string, Fdecode_time, Fencode_time):
4923 (Fcurrent_time_string): Use it.
4924
8be6f318
PE
4925 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4926 * dired.c (make_time): Move to ...
4927 * editfns.c (make_time): ... here.
4928 * systime.h: Note the move.
4929
09d9db2c 49302011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4931
126bc0dc
YM
4932 * fringe.c (update_window_fringes): Remove unused variables.
4933
c47cbdfd
YM
4934 * unexmacosx.c (copy_data_segment): Also copy __got section.
4935 (Bug#8223)
4936
7ac80be9
EZ
49372011-03-12 Eli Zaretskii <eliz@gnu.org>
4938
c96bbc66 4939 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4940 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4941 Constify `char *' arguments and their references according to
4942 prototypes in tparam.h.
4943
ecb0f94d 4944 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4945
7ac80be9
EZ
4946 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4947 Adapt all references accordingly.
4948
4949 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4950
ef1fd07e
TT
49512011-03-11 Tom Tromey <tromey@redhat.com>
4952
4953 * buffer.c (syms_of_buffer): Remove obsolete comment.
4954
7ef4b50c
EZ
49552011-03-11 Eli Zaretskii <eliz@gnu.org>
4956
4957 * termhooks.h (encode_terminal_code): Declare prototype.
4958
4959 * msdos.c (encode_terminal_code): Don't declare prototype.
4960
4961 * term.c (encode_terminal_code): Now external again, used by
4962 w32console.c and msdos.c.
4963
44f230aa
SM
4964 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4965 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4966
4b1ec863 49672011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4968
1714f52b 4969 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4970
4b1ec863
PE
4971 * fringe.c (update_window_fringes): Mark locals as initialized
4972 (Bug#8227).
4973 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4974
524c7aa6
PE
4975 * alloc.c (mark_fringe_data): Move decl from here ...
4976 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4977 to check its interface.
4978 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4979
a5c0af81 4980 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4981 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4982 (fontset_font): Mark local as initialized.
a9a06e0b 4983 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4984
b4716021
PE
4985 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4986
811e9bac 4987 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4988 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4989 (x_own_selection, Fx_disown_selection_internal): Rename locals
4990 to avoid shadowing.
4991 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4992
7e3ab302
PE
4993 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4994 so that the caller can use some name other than gcpro1.
4995 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4996 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4997 (Fx_backspace_delete_keys_p):
4998 Use them to avoid shadowing, and rename vars to avoid shadowing.
4999 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5000 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5001 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5002 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5003 Remove unused locals.
7e3ab302
PE
5004 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5005 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5006 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5007 macros.
f78faa98 5008
e2b13473
PE
5009 * xterm.h (x_mouse_leave): New decl.
5010
77f23912
PE
5011 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5012 Remove unused functions.
cdf4ba58
PE
5013 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5014 (x_calc_absolute_position): Now static.
7411c686 5015 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5016 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5017 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5018 unless they are used.
38d0b34a
PE
5019 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5020 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5021 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5022 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5023 (x_error_catcher, x_connection_closed, x_error_handler):
5024 (x_error_quitter, xembed_send_message, x_iconify_frame):
5025 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5026 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5027 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5028
44f230aa
SM
5029 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5030 Rename or move locals to avoid shadowing.
6b463e58 5031 (tty_defined_color, merge_face_heights): Now static.
5967d051 5032 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5033 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5034 does not deduce is never used uninitialized.
73719eba
PE
5035 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5036 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5037
426994c3 5038 * terminal.c (store_terminal_param): Now static.
5489860b 5039
032f1620 5040 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5041 (set_frame_menubar): Remove unused local.
d4323972 5042 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5043 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5044 since they might point to immutable storage.
281585b0
PE
5045 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5046 since it's unused otherwise.
032f1620 5047
367c19e5 5048 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5049 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5050 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5051 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5052 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5053 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5054 does not deduce are never used uninitialized.
70739cbe 5055
07b48fa9
PE
5056 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5057
8868a238 5058 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5059 * window.c (window_loop, size_window):
5060 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5061
7e5cf297 5062 * window.c (display_buffer): Now static.
d6550a9f
PE
5063 (size_window): Mark variables that gcc -Wuninitialized
5064 does not deduce are never used uninitialized.
a586633d
PE
5065 * window.h (check_all_windows): New decl, to forestall
5066 gcc -Wmissing-prototypes diagnostic.
5b555da1 5067 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5068
f6095868
PE
5069 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5070 shadowing.
5071 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5072 Include <limits.h>.
5073 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5074 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5075 (load_charset_map): Mark variables that gcc -Wuninitialized
5076 does not deduce are never used uninitialized.
53df7c11 5077 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5078
f38b440c
PE
5079 * coding.c (coding_set_source, coding_set_destination):
5080 Use "else { /* comment */ }" rather than "else /* comment */;"
5081 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5082 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5083 a block, when the outer 'i' will do.
5084 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5085 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5086 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5087 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5088 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5089 Rename locals to avoid shadowing.
5090 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5091 * coding.c (emacs_mule_char, encode_invocation_designation):
5092 Now static, since they're not used elsewhere.
413bb2db 5093 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5094 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5095 (decode_coding_emacs_mule): Mark variables that gcc
5096 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5097 (detect_coding_iso_2022): Initialize a local variable that might
5098 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5099 this initialization is needed. (Bug#8211)
5f58e762
PE
5100 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5101 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5102 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5103 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5104 Remove unused macros.
f38b440c 5105
232b38b9 5106 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5107 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5108 * character.c (string_count_byte8): Likewise.
232b38b9 5109
fb90da1b
PE
5110 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5111 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5112
fb93dbc2
PE
5113 * chartab.c (copy_sub_char_table): Now static, since it's not used
5114 elsewhere.
5c156ace
PE
5115 (sub_char_table_ref_and_range, char_table_ref_and_range):
5116 Rename locals to avoid shadowing.
bbcd0949 5117 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5118
7d3b3862 5119 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5120 (BIDI_BOB): Remove unused macro.
7d3b3862 5121
6be7d3da
PE
5122 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5123 deduce are never used uninitialized.
c2ed9c8b 5124 * term.c (encode_terminal_code): Likewise.
6be7d3da 5125
75f8807f 5126 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5127
50938595
PE
5128 * tparam.h: New file.
5129 * term.c, tparam.h: Include it.
5130 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5131 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5132 Move these decls to tparam.h, and make them agree with what
5133 is actually in tparam.c. The previous trick of using incompatible
5134 decls in different modules does not conform to the C standard.
5135 All callers of tparam changed to use tparam's actual API.
5136 * tparam.c (tparam1, tparam, tgoto):
5137 Use const pointers where appropriate.
5138
fbceeba2
PE
5139 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5140 * cm.h (struct cm): Likewise.
5141 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5142 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5143 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5144 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5145 (turn_on_face, init_tty): Likewise.
5146 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5147
7f3f1250
PE
5148 * term.c (term_mouse_position): Rename local to avoid shadowing.
5149
e6ca6543
PE
5150 * alloc.c (mark_ttys): Move decl from here ...
5151 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5152
c40f8d15
AS
51532011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5154
5155 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5156
cfe0661d
JB
51572011-03-09 Juanma Barranquero <lekktu@gmail.com>
5158
5159 * search.c (compile_pattern_1): Remove argument regp, unused since
5160 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5161 (compile_pattern): Don't pass it.
5162
0afb4571
J
51632011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5164
5165 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5166 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5167 for ! HAVE_GTK3.
5168 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5169
5170 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5171
5172 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5173 gdk_window_get_screen, gdk_window_get_geometry,
5174 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5175 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5176 (xg_get_pixbuf_from_pixmap): New function.
5177 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5178 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5179 Call xg_get_pixbuf_from_pixmap instead of
5180 gdk_pixbuf_get_from_drawable.
5181 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5182 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5183 (xg_check_special_colors): Use GtkStyleContext and its functions
5184 for HAVE_GTK3.
5185 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5186 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5187 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5188 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5189 Call gtk_widget_get_preferred_size.
0afb4571
J
5190 (xg_frame_resized): gdk_window_get_geometry only takes 5
5191 parameters.
44f230aa
SM
5192 (xg_win_to_widget, xg_event_is_for_menubar):
5193 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5194 (xg_set_widget_bg): New function.
5195 (delete_cb): New function.
895009e1 5196 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5197 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5198 (xg_set_background_color): Call xg_set_widget_bg.
5199 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5200 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5201 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5202 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5203 if ! HAVE_GTK3.
5204 (update_frame_tool_bar): Call gtk_widget_hide.
5205 (xg_initialize): Use GDK_KEY_g.
5206
5207 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5208 if ! HAVE_GTK3
5209 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5210
5211 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5212 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5213 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5214
1c2cc4ef
JB
52152011-03-08 Juanma Barranquero <lekktu@gmail.com>
5216
5217 * w32xfns.c (select_palette): Check success of RealizePalette against
5218 GDI_ERROR, not zero.
5219
33383987 5220See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5221
5222;; Local Variables:
5223;; coding: utf-8
aac0c6e3
MR
5224;; End:
5225
33383987 5226 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5227
5228 This file is part of GNU Emacs.
5229
5230 GNU Emacs is free software: you can redistribute it and/or modify
5231 it under the terms of the GNU General Public License as published by
5232 the Free Software Foundation, either version 3 of the License, or
5233 (at your option) any later version.
5234
5235 GNU Emacs is distributed in the hope that it will be useful,
5236 but WITHOUT ANY WARRANTY; without even the implied warranty of
5237 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5238 GNU General Public License for more details.
5239
5240 You should have received a copy of the GNU General Public License
5241 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.