* macros.c: Integer and buffer overflow fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7fcccf1e
PE
12011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2
6d84508d
PE
3 * macros.c: Integer and buffer overflow fixes.
4 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6 Use ptrdiff_t, not int, for sizes.
7 Don't increment bufsize until after realloc succeeds.
8 Check for size-calculation overflow.
9 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10
437b2cb4
PE
11 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
12
8b9ac8b4
PE
13 * lread.c: Integer overflow fixes.
14 (read_integer): Radix is now EMACS_INT, not int,
15 to improve quality of diagnostics for out-of-range radices.
16 Calculate buffer size correctly for out-of-range radices.
17 (read1): Check for integer overflow in radices, and in
18 read-circle numbers.
82cb60d3
PE
19 (read_escape): Avoid int overflow.
20 (Fload, openp, read_buffer_size, read1)
21 (substitute_object_recurse, read_vector, read_list, map_obarray):
22 Use ptrdiff_t, not int, for sizes.
23 (read1): Use EMACS_INT, not int, for sizes.
20270765 24 Check for size overflow.
8b9ac8b4 25
7fcccf1e
PE
26 * image.c (cache_image): Check for size arithmetic overflow.
27
85fece3e
PE
282011-06-22 Paul Eggert <eggert@cs.ucla.edu>
29
bfbbd7e7
PE
30 * lread.c: Integer overflow issues.
31 (saved_doc_string_size, saved_doc_string_length)
32 (prev_saved_doc_string_size, prev_saved_doc_string_length):
33 Now ptrdiff_t, not int.
34 (read1): Don't assume doc string length fits in int. Check for
35 out-of-range doc string lengths.
36 (read_list): Don't assume file position fits in int.
39019e54 37 (read_escape): Check for hex character overflow.
bfbbd7e7 38
20b84ce9 39 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
40 The following patches are for when GLYPH_DEBUG && !XASSERT.
41 * dispextern.h (trace_redisplay_p, dump_glyph_string):
42 * dispnew.c (flush_stdout):
43 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
44 Mark as externally visible.
45 * dispnew.c (check_window_matrix_pointers): Now static.
46 * dispnew.c (window_to_frame_vpos):
47 * xfns.c (unwind_create_frame):
48 * xterm.c (x_check_font): Remove unused local.
49 * scroll.c (CHECK_BOUNDS):
50 * xfaces.c (cache_fache): Rename local to avoid shadowing.
51 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
52 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
53 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
54 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
55 Now static.
56 (debug_method_add): Use va_list and vsprintf rather than relying
57 on undefined behavior with wrong number of arguments.
58 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
59 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
60 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
61 since we're not interested in debugging glyphs with old libraries.
62 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
63 GCC 4.6.0's static checking.
64
0766b489
PE
652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
66
31fd4b32
PE
67 Integer overflow and signedness fixes (Bug#8873).
68 A few related buffer overrun fixes, too.
69
b79e8648
PE
70 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
71
0766b489
PE
72 * dispextern.h (struct face.stipple):
73 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
74 (x_bitmap_mask, x_allocate_bitmap_record)
75 (x_create_bitmap_from_data, x_create_bitmap_from_file)
76 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
77 (x_create_bitmap_from_xpm_data):
78 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
79 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
80 (.bitmaps_last):
81 * xfaces.c (load_pixmap):
82 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
83 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
84 (.bitmaps_last, struct x_output.icon_bitmap):
85 Use ptrdiff_t, not int, for bitmap indexes.
86 (x_allocate_bitmap_record): Check for size overflow.
87 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
88
b081724f
PE
89 Use ptrdiff_t, not int, for overlay counts.
90 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
91 * editfns.c (overlays_around, get_pos_property):
92 * textprop.c (get_char_property_and_overlay):
93 * xdisp.c (next_overlay_change, note_mouse_highlight):
94 * xfaces.c (face_at_buffer_position):
21514da7
PE
95 * buffer.c (OVERLAY_COUNT_MAX): New macro.
96 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
97 (Fnext_overlay_change, Fprevious_overlay_change)
98 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 99 Use ptrdiff_t, not int, for sizes.
21514da7 100 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 101
3de73e5e
PE
102 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
103
2606c57b
PE
104 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
105 (x_session_initialize): Do not assume string length fits in int.
106
aaafe47a
PE
107 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
108 This is unlikely, but can occur if DPI is outlandish.
109
2674ddc8 110 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
111 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
112
28154962
PE
113 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
114 * xrdb.c (magic_file_p, search_magic_path):
115 Omit last arg SUFFIX; it was always 0. All callers changed.
116 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
117
7de51af5
PE
118 * xfont.c (xfont_match): Avoid need for strlen.
119
25ed6cc3
PE
120 * xfns.c: Don't assume strlen fits in int.
121 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
122
4eab31dd
PE
123 * xdisp.c (message_log_check_duplicate): Return intmax_t,
124 not unsigned long, as we prefer signed integers. All callers changed.
125 Detect integer overflow in repeat count.
126 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 127 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 128
171e2a58
PE
129 * termcap.c: Don't assume sizes fit in int and never overflow.
130 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
131 (gobble_line): Check for size-calculation overflow.
132
ad39faca 133 * minibuf.c (Fread_buffer):
6e5bb2dc 134 * lread.c (intern, intern_c_string):
74ca2eb3
PE
135 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
136 Don't assume string length fits in int.
137
52c61c22 138 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
139 * gtkutil.c (style_changed_cb): Avoid need for strlen.
140
b5b8c9e5
PE
141 * font.c: Don't assume string length fits in int.
142 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
143 Use ptrdiff_t, not int.
ccd6111c
PE
144 (font_intern_prop): Don't assume string length fits in int.
145 Don't assume integer property fits in fixnum.
146 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 147
882f0d81 148 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 149 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
150 Reformulate so as not to need the command string.
151 Invoke gzip -cd rather than gunzip, as it's more portable.
152 (lock_info_type, lock_file_1, lock_file):
153 Don't assume pid_t and time_t fit in unsigned long.
154 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
155 (current_lock_owner): Prefer signed type for sizes.
156 Use memcpy, not strncpy, where memcpy is what is really wanted.
157 Don't assume (via atoi) that time_t and pid_t fit in int.
158 Check for time_t and/or pid_t out of range, e.g., via a network share.
159 Don't alloca where an auto var works fine.
160
93f4cf88
PE
161 * fileio.c: Fix some integer overflow issues.
162 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
163 Don't assume string length fits in int.
164 (directory_file_name): Don't assume string length fits in long.
165 (make_temp_name): Don't assume pid fits in int, or that its print
166 length is less than 20.
167
f3e92b69
PE
168 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
169
1bfdaf10
PE
170 * coding.c (make_subsidiaries): Don't assume string length fits in int.
171
35016e9a
PE
172 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
173
3d1e65a1
PE
174 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
175 We prefer signed integers, even for size calculations.
176
0b963a93
PE
177 * emacs.c: Don't assume string length fits in 'int'.
178 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
179 (main): Don't invoke strlen when not needed.
180
573f4b54
PE
181 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
182 (XD_DEBUG_MESSAGE): Don't waste a byte.
183
989f33ba
PE
184 * callproc.c (getenv_internal_1, getenv_internal)
185 (Fgetenv_internal):
965d34eb
PE
186 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
187
e4d29b33
PE
188 * lread.c (invalid_syntax): Omit length argument.
189 All uses changed. This doesn't fix a bug, but it simplifies the
190 code away from its former Hollerith-constant appearance, and it's
191 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 192 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 193
eb49b136
PE
194 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
195 This didn't break anything, but it didn't help either.
196 It's confusing to put a bogus integer in a place where the actual
197 value does not matter.
9f62aeb1 198 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 199 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 200
15375a22
PE
201 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
202 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
203 implementation.
b61cc01c
PE
204 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
205 We prefer signed types, and the value cannot exceed the EMACS_INT
206 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
207 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
208 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
209 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 210
53b2623d
PE
211 * indent.c (sane_tab_width): New function.
212 (current_column, scan_for_column, Findent_to, position_indentation)
213 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 214 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 215
51cab52b 216 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 217
f2ed8a70
PE
218 * lisp.h (lint_assume): New macro.
219 * composite.c (composition_gstring_put_cache):
220 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
221
abe80cc6
PE
222 * editfns.c, insdel.c:
223 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 224
b02c740e
PE
225 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
226
ebc96716
PE
227 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
228
b4e50fa0 229 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 230 Use much-faster test for byte-length change.
311d5d7c 231 Don't assume string byte-length fits in 'int'.
a4cf38e4 232 Check that character arg fits in 'int'.
85461888 233 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 234
c0c1ee9f
PE
235 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
236
a498d7f4
PE
237 * fns.c (concat): Catch string overflow earlier.
238 Do not rely on integer wraparound.
239
51cab52b
PE
240 * dispextern.h (struct it.overlay_strings_charpos)
241 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
242 * xdisp.c (forward_to_next_line_start)
243 (back_to_previous_visible_line_start)
244 (reseat_at_next_visible_line_start, next_element_from_buffer):
245 Don't arbitrarily truncate the value of 'selective' to int.
246
76031fad
PE
247 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
248
5eb55db9
PE
249 * composite.c: Don't truncate sizes to 'int'.
250 (composition_gstring_p, composition_reseat_it)
251 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
252 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
253 not EMACS_UINT, for indexes.
5eb55db9 254
0703a717
PE
255 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
256
d6202519
PE
257 * buffer.c: Include <verify.h>.
258 (struct sortvec.priority, struct sortstr.priority):
8961a454 259 Now EMACS_INT, not int.
c20998a7 260 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
261 (struct sortstr.size, record_overlay_string)
262 (struct sortstrlist.size, struct sortlist.used):
263 Don't truncate size to int.
264 (record_overlay_string): Check for size-calculation overflow.
d6202519 265 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 266
d5a19415
JM
2672011-06-22 Jim Meyering <meyering@redhat.com>
268
269 don't leak an XBM-image-sized buffer
270 * image.c (xbm_load): Free the image buffer after using it.
271
a9041e6c
PE
2722011-06-21 Paul Eggert <eggert@cs.ucla.edu>
273
274 Port to Sun C.
275 * composite.c (find_automatic_composition): Omit needless 'return 0;'
276 that Sun C diagnosed.
277 * fns.c (secure_hash): Fix pointer signedness issue.
278 * intervals.c (static_offset_intervals): New function.
279 (offset_intervals): Use it.
280
7f3f739f
LL
2812011-06-21 Leo Liu <sdl.web@gmail.com>
282
283 * deps.mk (fns.o):
284 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
285 sha512.h.
286
287 * fns.c (secure_hash): Rename from crypto_hash_function and change
288 the first arg to accept symbols.
289 (Fsecure_hash): New primtive.
290 (syms_of_fns): New symbols.
291
76147d94
DD
2922011-06-20 Deniz Dogan <deniz@dogan.se>
293
294 * process.c (Fset_process_buffer): Clarify return value in
295 docstring.
296
7d7d0045
CY
2972011-06-18 Chong Yidong <cyd@stupidchicken.com>
298
299 * dispnew.c (add_window_display_history): Use BVAR.
300
301 * xdisp.c (debug_method_add): Use BVAR.
302 (check_window_end, dump_glyph_matrix, dump_glyph)
303 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
304
305 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
306 Likewise.
307
308 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
309 check till after the cache is created in init_frame_faces.
310
ff2bc410
SM
3112011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
312
313 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
314
28177add
PE
3152011-06-16 Paul Eggert <eggert@cs.ucla.edu>
316
dd3482fe
PE
317 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
318 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
319 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
320
393d71f3 321 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
322 * fileio.c (Finsert_file_contents):
323 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
324 Remove the old (too-loose) buffer overflow checks.
325 They weren't needed, since make_gap checks for buffer overflow.
326 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
327 The old code merely checked for Emacs fixnum overflow, and relied
328 on undefined (wraparound) behavior. The new code avoids undefined
329 behavior, and also checks for ptrdiff_t and/or size_t overflow.
330
2e6813b0 331 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
332 Tune. Don't use wider integers than needed. Don't use alloca.
333 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 334
599a9e4f
PE
335 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
336
99561444
PE
337 * insdel.c, lisp.h (buffer_overflow): New function.
338 (insert_from_buffer_1, replace_range, replace_range_2):
339 * insdel.c (make_gap_larger):
340 * editfns.c (Finsert_char):
341 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
342
28177add
PE
343 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
344
e69dafad
PE
3452011-06-15 Paul Eggert <eggert@cs.ucla.edu>
346
a7af7fde 347 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 348
b1c46f02
PE
349 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
350 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
351
e69dafad
PE
352 * fileio.c: Don't assume EMACS_INT fits in off_t.
353 (emacs_lseek): New static function.
354 (Finsert_file_contents, Fwrite_region): Use it.
355 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
356
566684ea
PE
357 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
358
e6966cd6
PE
359 * fns.c: Don't overflow int when computing a list length.
360 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
361 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
362 truncation on 64-bit hosts. Check for QUIT every
363 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
364 faster and is responsive enough.
365 (Flength): Report an error instead of overflowing an integer.
366 (Fsafe_length): Return a float if the value is not representable
367 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 368 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 369 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 370
dd0b0efb
PE
371 * alloc.c: Check that resized vectors' lengths fit in fixnums.
372 (header_size, word_size): New constants.
373 (allocate_vectorlike): Don't check size overflow here.
374 (allocate_vector): Check it here instead, since this is the only
375 caller of allocate_vectorlike that could cause overflow.
376 Check that the new vector's length is representable as a fixnum.
377
86fe5cfe
PE
378 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
379 The previous code was bogus. For example, next_almost_prime (32)
380 returned 39, which is undesirable as it is a multiple of 3; and
381 next_almost_prime (24) returned 25, which is a multiple of 5 so
382 why was the code bothering to check for multiples of 7?
383
80e88859
PE
384 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
385
4a2f0ad6
PE
386 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
387
f66c7cf8
PE
388 Variadic C functions now count arguments with ptrdiff_t.
389 This partly undoes my 2011-03-30 change, which replaced int with size_t.
390 Back then I didn't know that the Emacs coding style prefers signed int.
391 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
392 were being counted with int, which may truncate counts on 64-bit
393 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
394 * lisp.h (struct Lisp_Subr.function.aMANY)
395 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
396 Arg counts are now ptrdiff_t, not size_t.
397 All variadic functions and their callers changed accordingly.
398 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
399 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
400 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
401 * callint.c (Fcall_interactively): Check arg count for overflow,
402 to avoid potential buffer overrun. Use signed char, not 'int',
403 for 'varies' array, so that we needn't bother to check its size
404 calculation for overflow.
405 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
406 * eval.c (apply_lambda):
407 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
408 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
409 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
410
a1759b76
PE
411 * callint.c (Fcall_interactively): Don't use index var as event count.
412
d96be9fc
PE
413 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
414 * mem-limits.h (SIZE): Remove; no longer used.
415
a690a978 416 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 417
578c21e6
PE
418 Remove unnecessary casts.
419 * xterm.c (x_term_init):
420 * xfns.c (x_set_border_pixel):
421 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
422 These aren't needed now that we assume ANSI C.
423
96f53c6c
PE
424 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
425 It's more likely to cause problems (due to unsigned overflow)
426 than to cure them.
427
83c77d31
PE
428 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
429
ee2079f1
PE
430 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
431
6da65536
PE
432 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
433
7147c4a4
PE
434 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
435
193e32d9
PE
436 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
437
e5533da6
PE
438 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
439
9910e595
PE
440 GLYPH_CODE_FACE returns EMACS_INT, not int.
441 * dispextern.h (merge_faces):
442 * xfaces.c (merge_faces):
01103c44
PE
443 * xdisp.c (get_next_display_element, next_element_from_display_vector):
444 Don't assume EMACS_INT fits in int.
9910e595 445
2638320e
PE
446 * character.h (CHAR_VALID_P): Remove unused parameter.
447 * fontset.c, lisp.h, xdisp.c: All uses changed.
448
045eb8d9
PE
449 * editfns.c (Ftranslate_region_internal): Omit redundant test.
450
c1f134b5
PE
451 * fns.c (concat): Minor tuning based on overflow analysis.
452 This doesn't fix any bugs. Use int to hold character, instead
453 of constantly refetching from Emacs object. Use XFASTINT, not
454 XINT, for value known to be a character. Don't bother comparing
455 a single byte to 0400, as it's always less.
456
395fcb93 457 * floatfns.c (Fexpt):
327eeec8
PE
458 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
459
abbd3d23
PE
460 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
461 for characters.
462
684a03ef
PE
463 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
464
0fed43f3
PE
465 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
466 Without this fix, on a 64-bit host (aset S 0 4294967386) would
467 incorrectly succeed when S was a string, because 4294967386 was
468 truncated before it was used.
469
8fd02eb7
PE
470 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
471 Otherwise, an out-of-range integer could cause undefined behavior
472 on a 64-bit host.
473
f8c86b69
PE
474 * composite.c: Use int, not EMACS_INT, for characters.
475 (fill_gstring_body, composition_compute_stop_pos): Use int, not
476 EMACS_INT, for values that are known to be in character range.
477 This doesn't fix any bugs but is the usual style inside Emacs and
478 may generate better code on 32-bit machines.
479
34206dd2
PE
480 Make sure a 64-bit char is never passed to ENCODE_CHAR.
481 This is for reasons similar to the recent CHAR_STRING fix.
482 * charset.c (Fencode_char): Check that character arg is actually
483 a character. Pass an int to ENCODE_CHAR.
484 * charset.h (ENCODE_CHAR): Verify that the character argument is no
485 wider than 'int', as a compile-time check to prevent future regressions
486 in this area.
487
c5958d4c 488 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
489
490 Make sure a 64-bit char is never passed to CHAR_STRING.
491 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
492 by silently ignoring the top 32 bits, allowing some values
493 that were far too large to be valid characters.
494 * character.h: Include <verify.h>.
495 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
496 arguments are no wider than unsigned, as a compile-time check
497 to prevent future regressions in this area.
498 * data.c (Faset):
01103c44 499 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
500 (Fsubst_char_in_region):
501 * fns.c (concat):
502 * xdisp.c (decode_mode_spec_coding):
503 Adjust to CHAR_STRING's new requirement.
504 * editfns.c (Finsert_char, Fsubst_char_in_region):
505 * fns.c (concat): Check that character args are actually
506 characters. Without this test, these functions did the wrong
507 thing with wildly out-of-range values on 64-bit hosts.
508
d37ca623
PE
509 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
510 These casts should not be needed on 32-bit hosts, either.
511 * keyboard.c (read_char):
512 * lread.c (Fload): Remove casts to unsigned.
513
ea204efb
PE
514 * lisp.h (UNSIGNED_CMP): New macro.
515 This fixes comparison bugs on 64-bit hosts.
516 (ASCII_CHAR_P): Use it.
517 * casefiddle.c (casify_object):
01103c44 518 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
519 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
520 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
521 * dispextern.h (FACE_FROM_ID):
522 * keyboard.c (read_char): Use UNSIGNED_CMP.
523
41cb286c
PE
524 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
525 not to EMACS_INT, to avoid GCC warning.
526
4a1b9832
PE
527 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
528
55daad71
PE
529 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
530 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
531 isn't needed on 32-bit machines.
8f95c75c 532
01103c44
PE
533 * buffer.c (Fgenerate_new_buffer_name):
534 Use EMACS_INT for count, not int.
0ceccced 535 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
536
537 * data.c (Qcompiled_function): Now static.
538
c6f072e7
PE
539 * window.c (window_body_lines): Now static.
540
20ce5912
PE
541 * image.c (gif_load): Rename local to avoid shadowing.
542
9c4c5f81
PE
543 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
544 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
545 * alloc.c (make_save_value): Integer argument is now of type
546 ptrdiff_t, not int.
547 (mark_object): Use ptrdiff_t, not int.
548 * lisp.h (pD): New macro.
549 * print.c (print_object): Use it.
550
c0c5c8ae
PE
551 * alloc.c: Use EMACS_INT, not int, to count objects.
552 (total_conses, total_markers, total_symbols, total_vector_size)
553 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
554 (total_free_floats, total_floats, total_free_intervals)
555 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
556 Now EMACS_INT, not int. All uses changed.
557 (Fgarbage_collect): Compute overall total using a double, so that
558 integer overflow is less likely to be a problem. Check for overflow
559 when converting back to an integer.
5a25e253
PE
560 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
561 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
562 These were 'int' variables that could overflow on 64-bit hosts;
563 they were never used, so remove them instead of repairing them.
211a0b2a 564 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
565 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
566 Previously, this ceilinged at INT_MAX, but that doesn't work on
567 64-bit machines.
e46bb31a 568 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 569
c78baabf 570 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 571 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
572 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
573 when a (possibly-narrower) signed value would do just as well.
574 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 575
c9d624c6
PE
576 * alloc.c: Catch some string size overflows that we were missing.
577 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
578 for convenience in STRING_BYTES_MAX.
579 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
580 The definition here is exact; the one in lisp.h was approximate.
581 (allocate_string_data): Check for string overflow. This catches
582 some instances we weren't catching before. Also, it catches
583 size_t overflow on (unusual) hosts where SIZE_MAX <= min
584 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
585 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 586
c9d624c6
PE
587 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
588 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
589 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
590
353032ce
PE
591 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
592
2bccce07
PE
593 * alloc.c (Fmake_string): Check for out-of-range init.
594
0ac30604
SM
5952011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
596
597 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
598
c195f2de
JD
5992011-06-14 Jan Djärv <jan.h.d@swipnet.se>
600
601 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
602 xg_get_default_scrollbar_width.
603
604 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
605 (int_gtk_range_get_value): Move to the scroll bar part of the file.
606 (style_changed_cb): Call update_theme_scrollbar_width and call
607 x_set_scroll_bar_default_width and xg_frame_set_char_size for
608 all frames (Bug#8505).
609 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
610 Call gtk_window_set_resizable if HAVE_GTK3.
611 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
612 and height if HAVE_GTK3 (Bug#8505).
613 (scroll_bar_width_for_theme): New variable.
614 (update_theme_scrollbar_width): New function.
615 (xg_get_default_scrollbar_width): Move code to
616 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
617 (xg_initialize): Call update_theme_scrollbar_width.
618
619 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
620
621 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
622
e10ac9f1
MR
6232011-06-12 Martin Rudalics <rudalics@gmx.at>
624
625 * frame.c (make_frame): Call other_buffer_safely instead of
626 other_buffer.
627
628 * window.c (temp_output_buffer_show): Call display_buffer with
629 second argument Vtemp_buffer_show_specifiers and reset latter
630 immediately after the call.
631 (Vtemp_buffer_show_specifiers): New variable.
632 (auto_window_vscroll_p, next_screen_context_lines)
633 (Vscroll_preserve_screen_position): Remove leading asterisks from
634 doc-strings.
635
2d3c217e 6362011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 637
7b7f97e8 638 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
639 * buffer.c (Qclone_number): Remove for now, as it's unused.
640 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
641 (record_buffer): Remove unused local.
642 * frame.c (other_visible_frames, frame_buffer_list): Now static.
643 (set_frame_buffer_list): Remove; unused.
644 * frame.h (other_visible_frames): Remove decl.
645 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
646 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
647 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
648 if HAVE_GPM.
649 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
650 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
651 Define only if HAVE_GPM.
652 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
653 (update_hints_inhibit): Remove; never set. All uses removed.
654 * widgetprv.h (emacsFrameClassRec): Remove decl.
655 * window.c (delete_deletable_window): Now returns void, since it
656 wasn't returning anything.
657 (compare_window_configurations): Remove unused locals.
658 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
659 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
660 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
661 the same widths as pointers. This follows up on the 2011-05-06 patch.
662 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
663 * xterm.h: Likewise.
664 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
665
1384b89e
JB
6662011-06-12 Juanma Barranquero <lekktu@gmail.com>
667
668 * makefile.w32-in: Update dependencies.
669 (LISP_H): Add lib/intprops.h.
670
1100a63c
CY
6712011-06-11 Chong Yidong <cyd@stupidchicken.com>
672
673 * image.c (gif_load): Add animation frame delay to the metadata.
674 (syms_of_image): Use DEFSYM. New symbol `delay'.
675
6198ccd0
MR
6762011-06-11 Martin Rudalics <rudalics@gmx.at>
677
678 * window.c (delete_deletable_window): Re-add.
679 (Fset_window_configuration): Rewrite to handle dead buffers and
680 consequently deletable windows.
681 (window_tree, Fwindow_tree): Remove. Supply functionality in
682 window.el.
683 (compare_window_configurations): Simplify code.
684
b6e3633c
AS
6852011-06-11 Andreas Schwab <schwab@linux-m68k.org>
686
1ab0dee5
AS
687 * image.c (imagemagick_load_image): Fix type mismatch.
688 (Fimagemagick_types): Likewise.
689
b6e3633c
AS
690 * window.h (replace_buffer_in_windows): Declare.
691
9397e56f
MR
6922011-06-11 Martin Rudalics <rudalics@gmx.at>
693
694 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
695 Qclone_number. Remove external declaration of Qdelete_window.
696 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
697 code.
698 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
699 Qbuffer_list_update_hook if allowed.
700 (Fother_buffer): Rewrite doc-string. Major rewrite for new
701 buffer list implementation.
702 (other_buffer_safely): New function.
703 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
704 calls to replace_buffer_in_windows and
705 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
706 if allowed.
707 (record_buffer): Inhibit quitting and rewrite using quittable
708 functions. Run Qbuffer_list_update_hook if allowed.
709 (Frecord_buffer, Funrecord_buffer): New functions.
710 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
711 switch-to-buffer to window.el.
712 (bury-buffer): Move to window.el.
713 (Vbuffer_list_update_hook): New variable.
714
715 * lisp.h (other_buffer_safely): Add prototype in buffer.c
716 section.
717
718 * window.h (resize_frame_windows): Move up in code.
719 (Fwindow_frame): Remove EXFUN.
720 (replace_buffer_in_all_windows): Remove prototype.
721 (replace_buffer_in_windows_safely): Add prototype.
722
723 * window.c: Declare Qdelete_window static again. Move down
724 declaration of select_count.
725 (Fnext_window, Fprevious_window): Rewrite doc-strings.
726 (Fother_window): Move to window.el.
727 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
728 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
729 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
730 window.el.
731 (replace_buffer_in_windows): Implement by calling
732 Qreplace_buffer_in_windows.
733 (replace_buffer_in_all_windows): Remove with some functionality
734 moved into replace_buffer_in_windows_safely.
735 (replace_buffer_in_windows_safely): New function.
736 (select_window_norecord, select_frame_norecord): Move in front
737 of run_window_configuration_change_hook. Remove now obsolete
738 declarations.
739 (Fset_window_buffer): Rewrite doc-string. Call
740 Qrecord_window_buffer.
741 (keys_of_window): Move binding for other-window to window.el.
742
b50691aa
CY
7432011-06-11 Chong Yidong <cyd@stupidchicken.com>
744
745 * dispextern.h (struct image): Replace data member, whose int_val
746 and ptr_val fields were not used by anything, with a single
747 lisp_val object.
748
749 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
750 (gif_clear_image, gif_load, imagemagick_load_image)
751 (gs_clear_image, gs_load): Callers changed.
752
3f754b86
PE
7532011-06-10 Paul Eggert <eggert@cs.ucla.edu>
754
cca69397
PE
755 * buffer.h: Include <time.h>, for time_t.
756 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
757
109e28d0
PE
758 Fix minor problems found by static checking.
759
60737f02
PE
760 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
761
4b66faf3
PE
762 Make identifiers static if they are not used in other modules.
763 * data.c (Qcompiled_function, Qframe, Qvector):
764 * image.c (QimageMagick, Qsvg):
765 * minibuf.c (Qmetadata):
766 * window.c (resize_window_check, resize_root_window): Now static.
767 * window.h (resize_window_check, resize_root_window): Remove decls.
768
109e28d0
PE
769 * window.c (window_deletion_count, delete_deletable_window):
770 Remove; unused.
46a4ce9e
PE
771 (window_body_lines): Now static.
772 (Fdelete_other_windows_internal): Mark vars as initialized.
773 Make sure 'resize_failed' is initialized.
774 (run_window_configuration_change_hook): Rename local to avoid shadowing.
775 (resize_window_apply): Remove unused local.
776 * window.h (delete_deletable_window): Remove decl.
777
109e28d0 778 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
779 (imagemagick_load_image): Fix pointer signedness problem by changing
780 last arg from unsigned char * to char *. All uses changed.
781 Also, fix a local for similar reasons.
782 Remove unused locals. Remove locals to avoid shadowing.
783 (fn_rsvg_handle_free): Remove; unused.
784 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 785 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 786
3f754b86
PE
787 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
788
2547adb1
CY
7892011-06-10 Chong Yidong <cyd@stupidchicken.com>
790
791 * image.c (gif_load): Fix omitted cast error introduced by
792 2011-06-06 change.
793
2c8e37d4
MR
7942011-06-10 Martin Rudalics <rudalics@gmx.at>
795
796 * window.h (resize_proportionally, orig_total_lines)
797 (orig_top_line): Remove from window structure.
798 (set_window_height, set_window_width, change_window_heights)
799 (Fdelete_window): Remove prototypes.
800 (resize_frame_windows): Remove duplicate declaration.
801
440a42e3
EZ
8022011-06-10 Eli Zaretskii <eliz@gnu.org>
803
804 * window.h (resize_frame_windows, resize_window_check)
805 (delete_deletable_window, resize_root_window)
806 (resize_frame_windows): Declare prototypes.
807
808 * window.c (resize_window_apply): Make definition be "static" to
809 match the prototype.
810
562dd5e9
MR
8112011-06-10 Martin Rudalics <rudalics@gmx.at>
812
813 * window.c: Remove declarations of Qwindow_size_fixed,
814 window_min_size_1, window_min_size_2, window_min_size,
815 size_window, window_fixed_size_p, enlarge_window, delete_window.
816 Remove static from declaration of Qdelete_window, it's
817 temporarily needed by Fbury_buffer.
818 (replace_window): Don't assign orig_top_line and
819 orig_total_lines.
820 (Fdelete_window, delete_window): Remove. Window deletion is
821 handled by window.el.
822 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
823 Fdelete_window calls with calls to Qdelete_window.
824 (Fdelete_other_windows): Remove. Deleting other windows is
825 handled by window.el.
826 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
827 handled in window.el.
828 (window_min_size_2, window_min_size_1, window_min_size): Remove.
829 Window minimum sizes are handled in window.el.
830 (shrink_windows, size_window, set_window_height)
831 (set_window_width, change_window_heights, window_height)
832 (window_width, CURBEG, CURSIZE, enlarge_window)
833 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
834 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
835 handled in window.el.
836 (make_dummy_parent): Rename to make_parent_window and give it a
837 second argument horflag.
838 (make_window): Don't set resize_proportionally any more.
839 (Fsplit_window): Remove. Windows are split in window.el.
840 (save_restore_action, save_restore_orig_size)
841 (shrink_window_lowest_first, save_restore_orig_size): Remove.
842 Resize mini windows in window.el.
843 (grow_mini_window, shrink_mini_window): Implement by calling
844 Qresize_root_window_vertically, resize_window_check and
845 resize_window_apply.
846 (saved_window, Fset_window_configuration, save_window_save): Do
847 not handle orig_top_line, orig_total_lines, and
848 resize_proportionally.
849 (window_min_height, window_min_width): Move to window.el.
850 (keys_of_window): Move bindings for delete-other-windows,
851 split-window, delete-window and enlarge-window to window.el.
852
853 * buffer.c: Temporarily extern Qdelete_window.
854 (Fbury_buffer): Temporarily call Qdelete_window instead of
855 Fdelete_window (Fbury_buffer will move to window.el soon).
856
857 * frame.c (set_menu_bar_lines_1): Remove code handling
858 orig_top_line and orig_total_lines.
859
860 * dispnew.c (adjust_frame_glyphs_initially): Don't use
861 set_window_height but set heights directly.
862 (change_frame_size_1): Use resize_frame_windows.
863
864 * xdisp.c (init_xdisp): Don't use set_window_height but set
865 heights directly.
866
867 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
868 resize_frame_windows instead of change_window_heights and run
869 run_window_configuration_change_hook.
870
871 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
872 instead of change_window_heights and run
873 run_window_configuration_change_hook.
874
1a13852e
MR
8752011-06-09 Martin Rudalics <rudalics@gmx.at>
876
877 * window.c (replace_window): Rename second argument REPLACEMENT to
878 NEW. New third argument SETFLAG. Rewrite.
879 (delete_window, make_dummy_parent): Call replace_window with
880 third argument 1.
881 (window_list_1): Move down in code.
882 (run_window_configuration_change_hook): Move set_buffer part
883 before select_frame_norecord part in order to unwind correctly.
884 Rename count1 to count.
885 (recombine_windows, delete_deletable_window, resize_root_window)
886 (Fdelete_other_windows_internal)
887 (Frun_window_configuration_change_hook, make_parent_window)
888 (resize_window_check, resize_window_apply, Fresize_window_apply)
889 (resize_frame_windows, Fsplit_window_internal)
890 (Fdelete_window_internal, Fresize_mini_window_internal): New
891 functions.
892 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
893
f3d1777e
MR
8942011-06-08 Martin Rudalics <rudalics@gmx.at>
895
496e208e
MR
896 * window.h (window): Add some new members to window structure -
897 normal_lines, normal_cols, new_total, new_normal, clone_number,
898 splits, nest, prev_buffers, next_buffers.
899 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 900 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 901
f3d1777e
MR
902 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
903 Remove.
496e208e
MR
904 (make_dummy_parent): Set new members of windows structure.
905 (make_window): Move down in code. Handle new members of window
906 structure.
907 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
908 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
909 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
910 (Fset_window_prev_buffers, Fwindow_next_buffers)
911 (Fset_window_next_buffers, Fset_window_clone_number): New
912 functions.
913 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
914 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
915 Doc-string fixes.
916 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
917 Argument WINDOW can be now internal window too.
918 (Fwindow_use_time): Move up in code.
919 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
920 Rewrite doc-string.
921 (Fset_window_configuration, saved_window)
922 (Fcurrent_window_configuration, save_window_save): Handle new
923 members of window structure.
b9e809c2
MR
924 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
925 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
926 (syms_of_window): New Lisp objects Qrecord_window_buffer,
927 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
928 Qget_mru_window, Qresize_root_window,
929 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
930 Qauto_buffer_name; staticpro them.
f3d1777e 931
abde8f8c
MR
9322011-06-07 Martin Rudalics <rudalics@gmx.at>
933
934 * window.c (Fwindow_total_size, Fwindow_left_column)
935 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
936 (Fwindow_list_1): New functions.
937 (window_box_text_cols): Replace with window_body_cols.
938 (Fwindow_width, Fscroll_left, Fscroll_right): Use
939 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
940 (delete_window, Fset_window_configuration): Call
941 delete_all_subwindows with window as argument.
942 (delete_all_subwindows): Take a window as argument and not a
943 structure. Rewrite.
190b47e6
MR
944 (window_loop): Remove handling of GET_LRU_WINDOW and
945 GET_LARGEST_WINDOW.
946 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
947
948 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
949 window_box_text_cols. delete_all_subwindows now takes a
950 Lisp_Object as argument.
abde8f8c
MR
951
952 * indent.c (compute_motion, Fcompute_motion): Use
953 window_body_cols instead of window_box_text_cols.
954
fa8a67e6
MR
955 * frame.c (delete_frame): Call delete_all_subwindows with root
956 window as argument.
957
a54e3482
DC
9582011-06-07 Daniel Colascione <dan.colascione@gmail.com>
959
960 * fns.c (Fputhash): Document return value.
961
60002bf5
CY
9622011-06-06 Chong Yidong <cyd@stupidchicken.com>
963
964 * image.c (gif_load): Implement gif89a spec "no disposal" method.
965
0c671da6 9662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 967
b862a52a 968 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 969
be44ca6c
PE
970 Check for overflow when converting integer to cons and back.
971 * charset.c (Fdefine_charset_internal, Fdecode_char):
972 Use cons_to_unsigned to catch overflow.
973 (Fencode_char): Use INTEGER_TO_CONS.
974 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
975 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
976 * data.c (long_to_cons, cons_to_long): Remove.
977 (cons_to_unsigned, cons_to_signed): New functions.
978 These signal an error for invalid or out-of-range values.
979 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
980 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
981 * font.c (Ffont_variation_glyphs):
982 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
983 * lisp.h: Include <intprops.h>.
984 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
985 (cons_to_signed, cons_to_unsigned): New decls.
986 (long_to_cons, cons_to_long): Remove decls.
987 * undo.c (record_first_change): Use INTEGER_TO_CONS.
988 (Fprimitive_undo): Use CONS_TO_INTEGER.
989 * xfns.c (Fx_window_property): Likewise.
990 * xselect.c: Include <limits.h>.
991 (x_own_selection, selection_data_to_lisp_data):
992 Use INTEGER_TO_CONS.
993 (x_handle_selection_request, x_handle_selection_clear)
994 (x_get_foreign_selection, Fx_disown_selection_internal)
995 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
996 (lisp_data_to_selection_data): Use cons_to_unsigned.
997 (x_fill_property_data): Use cons_to_signed.
998 Report values out of range.
999
d1f3d2af
PE
1000 Check for buffer and string overflow more precisely.
1001 * buffer.h (BUF_BYTES_MAX): New macro.
1002 * lisp.h (STRING_BYTES_MAX): New macro.
1003 * alloc.c (Fmake_string):
1004 * character.c (string_escape_byte8):
1005 * coding.c (coding_alloc_by_realloc):
1006 * doprnt.c (doprnt):
1007 * editfns.c (Fformat):
1008 * eval.c (verror):
1009 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1010 since they may not be the same number.
1011 * editfns.c (Finsert_char):
1012 * fileio.c (Finsert_file_contents):
1013 Likewise for BUF_BYTES_MAX.
1014
dd52fcea
PE
1015 * image.c: Use ptrdiff_t, not int, for sizes.
1016 (slurp_file): Switch from int to ptrdiff_t.
1017 All uses changed.
1018 (slurp_file): Check that file size fits in both size_t (for
1019 malloc) and ptrdiff_t (for sanity and safety).
1020
7f9bbdbb
PE
1021 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1022 if b->modtime has its maximal value.
1023
dfe18f82
PE
1024 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1025
84acfcf0
PE
1026 Don't assume time_t can fit into int.
1027 * buffer.h (struct buffer.modtime): Now time_t, not int.
1028 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1029 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1030
ccd9a01a
PE
1031 Minor fixes for signed vs unsigned integers.
1032 * character.h (MAYBE_UNIFY_CHAR):
1033 * charset.c (maybe_unify_char):
1034 * keyboard.c (read_char, reorder_modifiers):
1035 XINT -> XFASTINT, since the integer must be nonnegative.
1036 * ftfont.c (ftfont_spec_pattern):
1037 * keymap.c (access_keymap, silly_event_symbol_error):
1038 XUINT -> XFASTINT, since the integer must be nonnegative.
1039 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1040 since it makes no difference and we prefer signed.
1041 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1042 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1043 nonnegative.
1044
d6d100dd
SM
10452011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1046
1047 * window.h (Fwindow_frame): Declare.
1048
2b6148e4
PE
10492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1050
1051 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1052 (SPARE_MEMORY): Always define.
1053 (LARGE_REQUEST): Remove.
1054 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1055
f230ecc9
MR
10562011-06-06 Martin Rudalics <rudalics@gmx.at>
1057
727e958e
MR
1058 * lisp.h: Move EXFUNS for Fframe_root_window,
1059 Fframe_first_window and Fset_frame_selected_window to window.h.
1060
1061 * window.h: Move EXFUNS for Fframe_root_window,
1062 Fframe_first_window and Fset_frame_selected_window here from
1063 lisp.h.
1064
1065 * frame.c (Fwindow_frame, Fframe_first_window)
1066 (Fframe_root_window, Fframe_selected_window)
1067 (Fset_frame_selected_window): Move to window.c.
1068 (Factive_minibuffer_window): Move to minibuf.c.
1069 (Fother_visible_frames_p): New function.
1070
1071 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1072
f230ecc9
MR
1073 * window.c (decode_window, decode_any_window): Move up in code.
1074 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1075 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1076 (Fwindow_buffer): Move up and rewrite doc-string.
1077 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1078 (Fwindow_prev): New functions.
727e958e
MR
1079 (Fwindow_frame): Move here from frame.c. Accept any window as
1080 argument.
1081 (Fframe_root_window, Fframe_first_window)
1082 (Fframe_selected_window): Move here from frame.c. Accept frame
1083 or arbitrary window as argument. Update doc-strings.
1084 (Fminibuffer_window): Move up in code.
1085 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1086 (Fset_frame_selected_window): Move here from frame.c.
1087 Marginal rewrite.
727e958e
MR
1088 (Fselected_window, select_window, Fselect_window): Move up in
1089 code. Minor doc-string fixes.
f230ecc9 1090
4d09bcf6
PE
10912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1092
1093 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1094 Do not assume that spare memory exists; that assumption is valid
1095 only if SYSTEM_MALLOC.
1096 (LARGE_REQUEST): New macro, so that the issue of large requests
1097 is separated from the issue of spare memory.
1098
810928a2
AS
10992011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1100
172418ad
AS
1101 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1102 format. (Bug#8806)
1103
43f862f7
AS
1104 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1105
810928a2
AS
1106 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1107 before statements.
1108
a059fe24
JD
11092011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1110
1111 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1112
1113 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1114
1115 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1116 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1117
989bf368
JB
11182011-06-05 Juanma Barranquero <lekktu@gmail.com>
1119
1120 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1121
4b80f674
CY
11222011-06-04 Chong Yidong <cyd@stupidchicken.com>
1123
1124 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1125 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1126 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1127 New error handlers.
4b80f674
CY
1128 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1129 Obey Vx_select_enable_clipboard_manager. Catch errors in
1130 x_clipboard_manager_save (Bug#8779).
1131 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1132 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1133
99a33b77 11342011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1135
1136 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1137
99a33b77 11382011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1139
1140 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1141 in the current matrix if keep_current_p is non-zero.
1142
8264569d
EZ
11432011-06-04 Eli Zaretskii <eliz@gnu.org>
1144
1145 * bidi.c (bidi_level_of_next_char): Fix last change.
1146
57f97249
EZ
11472011-06-03 Eli Zaretskii <eliz@gnu.org>
1148
fec2107c 1149 Support bidi reordering of text covered by display properties.
57f97249 1150
fec2107c
EZ
1151 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1152 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1153 (bidi_cache_search, bidi_cache_iterator_state)
1154 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1155 (bidi_level_of_next_char, bidi_move_to_visually_next):
1156 Support character positions inside a run of characters covered by a
fec2107c
EZ
1157 display string.
1158 (bidi_paragraph_init, bidi_resolve_explicit_1)
1159 (bidi_level_of_next_char): Call bidi_fetch_char and
1160 bidi_fetch_char_advance instead of FETCH_CHAR and
1161 FETCH_CHAR_ADVANCE.
1162 (bidi_init_it): Initialize new members.
1163 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1164 definitions.
1165 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1166 instead of using explicit *_CHAR codes.
d6d100dd
SM
1167 (bidi_resolve_explicit, bidi_resolve_weak):
1168 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1169 bidirectional text is supported only in multibyte buffers.
1170 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1171 it to initialize the frame_window_p member of struct bidi_it.
1172 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1173 (bidi_resolve_explicit, bidi_resolve_weak)
1174 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1175 bidi_it->nchars is non-positive.
1176 (bidi_level_of_next_char): Don't try to lookup the cache for the
1177 next/previous character if nothing is cached there yet, or if we
1178 were just reseat()'ed to a new position.
c40e2fb2 1179
0e14fe90
EZ
1180 * xdisp.c (set_cursor_from_row): Set start and stop points
1181 according to the row's direction when priming the loop that looks
1182 for the glyph on which to display cursor.
1183 (single_display_spec_intangible_p): Function deleted.
1184 (display_prop_intangible_p): Reimplement to call
1185 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1186 Accept 3 additional arguments needed by handle_display_spec.
1187 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1188 values: lists, `(when COND...)' forms, etc.
1189 (single_display_spec_string_p): Support property values that are
1190 lists with the argument STRING its top-level element.
1191 (display_prop_string_p): Fix the condition for processing a
1192 property that is a list to be consistent with handle_display_spec.
fec2107c 1193 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1194 last portion of handle_display_prop.
1195 (compute_display_string_pos): Accept additional argument
1196 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1197 value of a `display' property is a "replacing spec".
1198 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1199 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1200 the display property, but just return a value indicating whether
1201 the display property will replace the characters it covers.
1202 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1203 frame_window_p members of struct bidi_it.
d6d100dd
SM
1204 (compute_display_string_pos, compute_display_string_end):
1205 New functions.
fec2107c
EZ
1206 (push_it): Accept second argument POSITION, where pop_it should
1207 jump to continue iteration.
1208 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1209
fec2107c
EZ
1210 * keyboard.c (adjust_point_for_property): Adjust the call to
1211 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1212
1213 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1214 (bidi_init_it): Update prototypes.
1215 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1216 (compute_display_string_pos, compute_display_string_end):
1217 Declare prototypes.
fec2107c
EZ
1218 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1219 EMACS_INT.
fc6f18ce 1220
40087514 12212011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1222
57f53182
PE
1223 Malloc failure behavior now depends on size of allocation.
1224 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1225 * lisp.h: Change signatures accordingly.
1226 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1227 All callers changed. (Bug#8762)
1228
1229 * gnutls.c: Use Emacs's memory allocators.
1230 Without this change, the gnutls library would invoke malloc etc.
1231 directly, which causes problems on non-SYNC_INPUT hosts, and which
1232 runs afoul of improving memory_full behavior. (Bug#8761)
1233 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1234 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1235 xfree instead of the default malloc, realloc, free.
1236 (Fgnutls_boot): No need to check for memory allocation failure,
1237 since xmalloc does that for us.
1238
ac32cd99 1239 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1240 * category.c (hash_get_category_set):
1241 * ccl.c (ccl_driver):
1242 * charset.c (Fdefine_charset_internal):
1243 * charset.h (struct charset.hash_index):
1244 * composite.c (get_composition_id, gstring_lookup_cache)
1245 (composition_gstring_put_cache):
1246 * composite.h (struct composition.hash_index):
1247 * dispextern.h (struct image.hash):
1248 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1249 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1250 (hashfn_equal, hashfn_user_defined, make_hash_table)
1251 (maybe_resize_hash_table, hash_lookup, hash_put)
1252 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1253 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1254 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1255 * image.c (make_image, search_image_cache, lookup_image)
1256 (xpm_put_color_table_h):
1257 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1258 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1259 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1260 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1261 * alloc.c (allocate_vectorlike):
1262 Check for overflow in vector size calculations.
1263 * ccl.c (ccl_driver):
1264 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1265 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1266 need to be updated by these changes.
40087514
PE
1267 * fns.c (make_hash_table, maybe_resize_hash_table):
1268 Check for integer overflow with large hash tables.
0de4bb68
PE
1269 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1270 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1271 (SXHASH_REDUCE): New macro.
1272 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1273 Use it instead of discarding useful hash info with large hash values.
1274 (sxhash_float): New function.
1275 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1276 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1277 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1278 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1279 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1280 Adjust signatures to match updated version of code.
1281 (consing_since_gc): Now EMACS_INT, since a single hash table can
1282 use more than INT_MAX bytes.
1283
698d32e2
DN
12842011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1285
1286 Make it possible to build with GCC-4.6+ -O2 -flto.
1287
1288 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1289
fd6fa53f
SM
12902011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1291
1292 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1293 Call minibuffer-inactive-mode.
1294
864db017
JB
12952011-05-31 Juanma Barranquero <lekktu@gmail.com>
1296
1297 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1298 Update dependencies.
1299
2ad0baf4
DN
13002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1301
1302 * data.c (init_data): Remove code for UTS, this system is not
1303 supported anymore.
1304
4fcc2638
DN
13052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1306
1307 Don't force ./temacs to start in terminal mode.
1308
1309 * frame.c (make_initial_frame): Initialize faces in all cases, not
1310 only when CANNOT_DUMP is defined.
1311 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1312
c56e0fd5
DN
13132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1314
1315 * dispnew.c (add_window_display_history): Use const for the string
1316 pointer. Remove declaration, not needed.
1317
333d54da 13182011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1319
55d4c1b2 1320 Use 'inline', not 'INLINE'.
333d54da 1321 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1322 * alloc.c, fontset.c (INLINE): Remove.
1323 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1324 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1325 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1326 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1327 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1328
738db178
DN
13292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1330
1331 Make it possible to run ./temacs.
1332
1333 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1334 syms_of_callproc does the same thing. Remove test for
1335 "initialized", do it in the caller.
1336 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1337
620c53a6
SM
13382011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1339
1340 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1341 (read_minibuf): Use get_minibuffer.
1342 (syms_of_minibuf): Use DEFSYM.
1343 (Qmetadata): New var.
1344 * data.c (Qbuffer): Don't make it static.
1345 (syms_of_data): Use DEFSYM.
1346
e003a292
PE
13472011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1348
1349 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1350 (CCL_CODE_MIN): New macro.
1351
ed008a6d
PE
13522011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1353
3687c2ef
PE
1354 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1355
ed008a6d
PE
1356 * eval.c (Qdebug): Now static.
1357 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1358 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1359 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1360
d66c4c7c
CY
13612011-05-29 Chong Yidong <cyd@stupidchicken.com>
1362
1363 * image.c: Various fixes to ImageMagick code comments.
1364 (Fimagemagick_types): Doc fix.
1365
5fbc2025
PE
13662011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1367
0196f88a
PE
1368 Minor fixes prompted by GCC 4.6.0 warnings.
1369
1370 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1371
5fbc2025
PE
1372 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1373 (x_clipboard_manager_save_all): Move extern decl to ...
1374 * xterm.h: ... here, so that it can be checked for consistency.
1375
1dd3c2d9
CY
13762011-05-29 Chong Yidong <cyd@stupidchicken.com>
1377
1378 * xselect.c (x_clipboard_manager_save_frame)
1379 (x_clipboard_manager_save_all): New functions.
1380 (Fx_clipboard_manager_save): Lisp function deleted.
1381
1382 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1383 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1384
1385 * xterm.h: Update prototype.
1386
5ba6571d
WX
13872011-05-28 William Xu <william.xwl@gmail.com>
1388
1389 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1390 exiting (Bug#8239).
1391
3eaff834
JM
13922011-05-28 Jim Meyering <meyering@redhat.com>
1393
e1900994 1394 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1395 * fns.c (to_uchar): Define.
1396 (crypto_hash_function): Use it to convert some newly-signed
1397 variables to unsigned, to avoid sign-extension bugs. For example,
1398 without this change, (md5 "truc") would evaluate to
1399 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1400 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1401 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1402
0f6990a7
PE
14032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1404
1405 Integer overflow fixes.
c8a9ca5a 1406
08686060
PE
1407 * dbusbind.c: Serial number integer overflow fixes.
1408 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1409 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1410 to hold a serial number that is too large for a fixnum.
1411 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1412 Check for serial numbers out of range. Decode any serial number
59568bf0 1413 that was so large that it became a float. (Bug#8722)
08686060 1414
2d1fc3c7
PE
1415 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1416 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1417 Use XFASTINT rather than XUINT when numbers are nonnegative.
1418 (xd_append_arg, Fdbus_method_return_internal):
1419 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1420 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1421 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1422 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1423 (Bug#8722)
2d1fc3c7 1424
c8a9ca5a
PE
1425 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1426
519e1d69
PE
1427 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1428
30569699
PE
1429 ccl: add integer overflow checks
1430 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1431 (IN_INT_RANGE): New macros.
1432 (ccl_driver): Use them to check for integer overflow when
1433 decoding a CCL program. Many of the new checks are whether XINT (x)
1434 fits in int; it doesn't always, on 64-bit hosts. The new version
1435 doesn't catch all possible integer overflows, but it's an
847044ea 1436 improvement. (Bug#8719)
30569699 1437
c11285dc
PE
1438 * alloc.c (make_event_array): Use XINT, not XUINT.
1439 There's no need for unsigned here.
1440
fdccd48e
PE
1441 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1442 This follows up to the 2011-05-06 change that substituted uintptr_t
1443 for EMACS_INT. This case wasn't caught back then.
1444
37910ab2
PE
1445 Rework Fformat to avoid integer overflow issues.
1446 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1447 now (part of C89). Include <verify.h>.
1448 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1449 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1450 (Fformat): Avoid the prepass trying to compute sizes; it was only
1451 approximate and thus did not catch overflow reliably. Instead, walk
1452 through the format just once, formatting and computing sizes as we go,
1453 checking for integer overflow at every step, and allocating a larger
1454 buffer as needed. Keep track separately whether the format is
1455 multibyte. Keep only the most-recently calculated precision, rather
1456 than them all. Record whether each argument has been converted to
1457 string. Use EMACS_INT, not int, for byte and char and arg counts.
1458 Support field widths and precisions larger than INT_MAX. Avoid
1459 sprintf's undefined behavior with conversion specifications such as %#d
1460 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1461 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1462 formatting out-of-range floating point numbers with int
1463 formats. (Bug#8668)
1464
2e6578fb
PE
1465 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1466
0ae6bdee
PE
1467 * data.c: Avoid integer truncation in expressions involving floats.
1468 * data.c: Include <intprops.h>.
1469 (arith_driver): When there's an integer overflow in an expression
1470 involving floating point, convert the integers to floating point
1471 so that the resulting value does not suffer from catastrophic
1472 integer truncation. For example, on a 64-bit host (* 4
1473 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1474 Do not rely on undefined behavior after integer overflow.
1475
de883a70
PE
1476 merge count_size_as_multibyte, parse_str_to_multibyte
1477 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1478 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1479 Check for integer overflow.
1480 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1481 since it's now a duplicate of the other. This is more of
1482 a character than a buffer op, so better that it's in character.c.
1483 * fns.c, print.c: Adjust to above changes.
1484
2ff916cb
PE
14852011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1486
1487 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1488
f1b54466
PE
14892011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1490
fb1ac845
PE
1491 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1492 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1493 (x_clipboard_manager_save): Now static.
1494 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1495
f1b54466
PE
1496 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1497 (crypto_hash_function): Now static.
1498 Fix pointer signedness problems. Avoid unnecessary initializations.
1499
a9f737ee
CY
15002011-05-27 Chong Yidong <cyd@stupidchicken.com>
1501
1502 * termhooks.h (Vselection_alist): Make it terminal-local.
1503
1504 * terminal.c (create_terminal): Initialize it.
1505
1506 * xselect.c: Support for clipboard managers.
1507 (Vselection_alist): Move to termhooks.h as terminal-local var.
1508 (LOCAL_SELECTION): New macro.
1509 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1510 (symbol_to_x_atom): Remove gratuitous arg.
1511 (x_handle_selection_request, lisp_data_to_selection_data)
1512 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1513 (x_own_selection, x_get_local_selection, x_convert_selection):
1514 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1515 (some_frame_on_display): Delete unused function.
1516 (Fx_own_selection_internal, Fx_get_selection_internal)
1517 (Fx_disown_selection_internal, Fx_selection_owner_p)
1518 (Fx_selection_exists_p): New optional frame arg.
1519 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1520 (x_handle_selection_clear): Don't treat other terminals with the
1521 same keyboard specially. Use the terminal-local Vselection_alist.
1522 (x_clear_frame_selections): Use Frun_hook_with_args.
1523
1524 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1525
1526 * xterm.h: Add support for those atoms.
1527
e067f0c1
CY
15282011-05-26 Chong Yidong <cyd@stupidchicken.com>
1529
1530 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1531 (converted_selections, conversion_fail_tag): New global variables.
1532 (x_selection_request_lisp_error): Free the above.
1533 (x_get_local_selection): Remove unnecessary code.
1534 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1535 of converted selections stored in converted_selections.
1536 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1537 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1538 (x_convert_selection): New function.
1539 (x_handle_selection_event): Simplify.
1540 (x_get_foreign_selection): Don't ignore incoming requests while
1541 waiting for an answer; this will fail when we implement
1542 SAVE_TARGETS, and seems unnecessary anyway.
1543 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1544 (Vx_sent_selection_functions): Doc fix.
1545
0f4aebc0
LL
15462011-05-26 Leo Liu <sdl.web@gmail.com>
1547
1548 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1549
e61124cd
YM
15502011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1551
1552 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1553
1554 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1555 for fringe update if it has periodic bitmap.
1556 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1557 and fringe_bitmap_periodic_p.
1558
1559 * fringe.c (get_fringe_bitmap_data): New function.
1560 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1561 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1562 row. Mark glyph row for fringe update if periodicity changed.
1563
1564 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1565 for fringe update unless it has periodic bitmap.
1566
f16d9837
KH
15672011-05-25 Kenichi Handa <handa@m17n.org>
1568
1569 * xdisp.c (get_next_display_element): Set correct it->face_id for
1570 a static composition.
1571
e1b90ef6
LL
15722011-05-24 Leo Liu <sdl.web@gmail.com>
1573
1574 * deps.mk (fns.o):
1575 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1576
1577 * fns.c (crypto_hash_function, Fsha1): New function.
1578 (Fmd5): Use crypto_hash_function.
1579 (syms_of_fns): Add Ssha1.
1580
7400048f
PE
15812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1582
1583 * gnutls.c: Remove unused macros.
1584 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1585 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1586 Remove macros that are defined and never used.
1587 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1588
abb71cf4
CY
15892011-05-22 Chong Yidong <cyd@stupidchicken.com>
1590
1591 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1592 (Fx_get_selection_internal): Minor cleanup.
1593 (Fx_own_selection_internal): Rename arguments for consistency with
1594 select.el.
1595
6307db39
PE
15962011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1597
1598 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1599
f3d4e0a4
CY
16002011-05-22 Chong Yidong <cyd@stupidchicken.com>
1601
1602 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1603
4d8ade89
YM
16042011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1605
1606 * dispnew.c (scrolling_window): Don't exclude the case that the
1607 last enabled row in the desired matrix touches the bottom boundary.
1608
32078c8d
GM
16092011-05-21 Glenn Morris <rgm@gnu.org>
1610
1611 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1612 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1613 and add some more files.
32078c8d 1614
7285dc67
EZ
16152011-05-20 Eli Zaretskii <eliz@gnu.org>
1616
1617 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1618 report_file_error introduced by the change from 2011-05-07.
1619
89d1bd22
PE
16202011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1621
1622 * systime.h (Time): Define only if emacs is defined.
1623 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1624 where the include path doesn't have X11/X.h by default. See
1625 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1626
e23640bb 16272011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1628
1629 * composite.c (find_automatic_composition): Fix previous change.
1630
b9704ad9
GM
16312011-05-20 Glenn Morris <rgm@gnu.org>
1632
1633 * lisp.mk: New file, split from Makefile.in.
1634 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1635 (shortlisp): Remove.
1636 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1637
4a720484
GM
16382011-05-19 Glenn Morris <rgm@gnu.org>
1639
1640 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1641 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1642 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1643 (lisp): Set the order to that of loadup.el.
1644 (shortlisp): Make it a copy of $lisp.
1645 (SOME_MACHINE_LISP): Remove.
1646 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1647 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1648
a28d4396
KH
16492011-05-18 Kenichi Handa <handa@m17n.org>
1650
1651 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1652 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1653 (find_automatic_composition): Mostly rewrite for efficiency.
1654
a2b1fa8e
JB
16552011-05-18 Juanma Barranquero <lekktu@gmail.com>
1656
1657 * makefile.w32-in: Update dependencies.
1658
8e1f5610
CS
16592011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1660
1661 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1662 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1663
7025ee00 16642011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1665
cdfa6eab
PE
1666 Fix some integer overflow issues, such as string length overflow.
1667
06d6db33
PE
1668 * insdel.c (count_size_as_multibyte): Check for string overflow.
1669
2b4560a8
PE
1670 * character.c (lisp_string_width): Check for string overflow.
1671 Use EMACS_INT, not int, for string indexes and lengths; in
1672 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1673 the resulting string length overflows an EMACS_INT; instead,
1674 report a string overflow if no precision given. When checking for
1675 precision exhaustion, use a check that cannot possibly have
1676 integer overflow. (Bug#8675)
1677 * character.h (lisp_string_width): Adjust to new signature.
1678
cb93f9be
PE
1679 * alloc.c (string_overflow): New function.
1680 (Fmake_string): Use it. This doesn't change behavior, but saves
1681 a few bytes and will simplify future changes.
1682 * character.c (string_escape_byte8): Likewise.
1683 * lisp.h (string_overflow): New decl.
1684
1a1f3366
PE
1685 Fixups, following up to the user-interface timestamp change.
1686 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1687 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1688 * msdos.c (mouse_get_pos): Likewise.
1689 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1690 * w32gui.h (Time): Define by including "systime.h" rather than by
1691 declaring it ourselves. (Bug#8664)
1692
d4e3e4d3
PE
1693 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1694 * image.c (clear_image_cache): Likewise.
1695
f6a24d19
PE
1696 * term.c (term_mouse_position): Don't assume time_t wraparound.
1697
08dc5ae6
PE
1698 Be more systematic about user-interface timestamps.
1699 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1700 and sometimes 'EMACS_UINT', to represent these timestamps.
1701 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1702 This makes the code easier to follow, and makes it easier to catch
1703 integer overflow bugs such as Bug#8664.
1704 * frame.c (Fmouse_position, Fmouse_pixel_position):
1705 Use Time, not unsigned long, for user-interface timestamps.
1706 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1707 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1708 * keyboard.h (last_event_timestamp): Likewise.
1709 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1710 * menu.h (xmenu_show): Likewise.
1711 * term.c (term_mouse_position): Likewise.
1712 * termhooks.h (struct input_event.timestamp): Likewise.
1713 (struct terminal.mouse_position_hook): Likewise.
1714 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1715 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1716 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1717 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1718 what it was before.
1719 * menu.h, termhooks.h: Include "systime.h", for Time.
1720
8e55734a
PE
1721 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1722 Don't assume that the difference between two unsigned long values
1723 can fit into an integer. At this point, we know button_down_time
1724 <= event->timestamp, so the difference must be nonnegative, so
1725 there's no need to cast the result if double-click-time is
1726 nonnegative, as it should be; check that it's nonnegative, just in
1727 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1728 apart (about 25 days). (Bug#8664)
8e55734a 1729
841f1b75 1730 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1731 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1732
3e26f69c
PE
1733 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1734 that always fit in int. Use a sentinel instead of a counter, to
1735 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1736 * frame.h (struct frame): Use int for menu_bar_items_used
1737 instead of EMACS_INT, since it always fits in int.
3e26f69c 1738
5cc152c0
PE
1739 * menu.c (grow_menu_items): Check for int overflow.
1740
d89eb65e
PE
1741 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1742
5235bd3e
PE
1743 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1744 Before, the code was not consistent. These values cannot exceed
1745 2**31 - 1 so there's no need to make them unsigned.
1746 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1747 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1748 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1749 as modifiers.
1750 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1751
bc827e23
PE
1752 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1753 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1754 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1755 presumably because the widths might not match.
1756
78eb494e
PE
1757 * window.c (size_window): Avoid needless test at loop start.
1758
04f2d78b
CB
17592011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1760
1761 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1762
d2fc7e3d 17632011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1764
1765 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1766
d2fc7e3d 17672011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1768
1769 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1770 `width' to `bar_area_x' and `bar_area_width', respectively.
1771 (x_scroll_run): Take account of fringe background extension.
1772
04f2d78b
CB
1773 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1774 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1775 `bar_area_width', respectively.
1776 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1777 background extension.
1778
79b70037
GM
17792011-05-10 Jim Meyering <meyering@redhat.com>
1780
1781 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1782
2f142cc5
JB
17832011-05-10 Juanma Barranquero <lekktu@gmail.com>
1784
1785 * image.c (Finit_image_library): Return t for built-in image types,
1786 like pbm and xbm. (Bug#8640)
1787
57679c86
AS
17882011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1789
1790 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1791
888c9e86
EZ
17922011-05-07 Eli Zaretskii <eliz@gnu.org>
1793
b0512a1d
EZ
1794 * w32console.c (Fset_screen_color): Doc fix.
1795 (Fget_screen_color): New function.
1796 (syms_of_ntterm): Defsubr it.
1797
7285dc67
EZ
1798 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1799 unlink the temporary file if Fcall_process didn't create it in the
1800 first place.
1801 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1802 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1803 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1804 cue to call_process_cleanup not to close that handle.
1805
4d3fcc8e
BK
18062011-05-07 Ben Key <bkey76@gmail.com>
1807
1808 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1809 one of two shell specific rules, either bootstrap-temacs-CMD or
1810 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1811 to the previous implementation of the bootstrap-temacs rule.
1812 The bootstrap-temacs-CMD rule is similar to the previous
1813 implementation of the bootstrap-temacs rule except that it
1814 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1815 variable.
1816
1817 These changes, along with some changes to nt/configure.bat,
1818 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1819 earlier fix to add support for --cflags and --ldflags options
1820 that include quotes so that it works whether make uses cmd or
1821 sh as the shell.
1822
b4289b64
MA
18232011-05-06 Michael Albinus <michael.albinus@gmx.de>
1824
1825 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1826 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1827 is a constant.
1828 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1829 a string. Handle both cases.
1830 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1831 (Fdbus_register_method): Use Qinvalid_function.
1832
af4c0e28
JB
18332011-05-06 Juanma Barranquero <lekktu@gmail.com>
1834
1835 * makefile.w32-in: Update dependencies.
1836 (LISP_H): Add inttypes.h and stdin.h.
1837 (PROCESS_H): Add unistd.h.
1838
c51453d9
EZ
18392011-05-06 Eli Zaretskii <eliz@gnu.org>
1840
1841 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1842 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1843
8ff0ac3c 18442011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1845
4c4b566b
PE
1846 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1847
aab2b9b5
PE
1848 * term.c (vfatal): Remove stray call to va_end.
1849 It's not needed and the C Standard doesn't allow it here anyway.
1850
c378da0b
PE
1851 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1852 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1853
288b08c7
PE
1854 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1855 bytes.
1856
e3601888
PE
1857 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1858
db6c0e74
PE
1859 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1860
dd5963ea
PE
1861 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1862
88c9450f
PE
1863 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1864
2f9442b8
PE
1865 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1866
c032b5f8
PE
1867 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1868 * charset.c (Fdefine_charset_internal): Don't initialize
1869 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1870 32-bit int (Bug#8600).
a108c10b
PE
1871
1872 * lread.c (read_integer): Be more consistent with string-to-number.
1873 Use string_to_number to do the actual conversion; this avoids
1874 rounding errors and fixes some other screwups. Without this fix,
1875 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1876 (digit_to_number): Move earlier, for benefit of read_integer.
1877 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1878 not a digit in any supported base. (Bug#8602)
a108c10b 1879
ad5f9eea
PE
1880 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1881
aec1708a
PE
1882 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1883 to match comment at start of function. This also removes a
1884 GCC warning about overflow in a 32+64-bit port.
1885
47be4ab5
PE
1886 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1887
371cac43
PE
1888 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1889 Reported by Stefan Monnier in
1890 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1891 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1892 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1893
d01a7826
PE
1894 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1895 (EMACS_UINTPTR): Likewise, with uintptr_t.
1896
7fd47d5c
PE
1897 * lisp.h: Prefer 64-bit EMACS_INT if available.
1898 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1899 on 32-bit hosts that have 64-bit int, so that they can access
1900 large files.
122b0c86
PE
1901 However, temporarily disable this change unless the temporary
1902 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1903
8727937b
PE
1904 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1905
8ac068ac
PE
1906 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1907 This removes an assumption that EMACS_INT and long are the same
1908 width as pointers. The assumption is true for Emacs porting targets
1909 now, but we want to make other targets possible.
1910 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1911 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1912 In the rest of the code, change types of integers that hold casted
1913 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1914 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1915 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1916 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1917 No need to cast type when ORing.
1918 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1919 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1920 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1921 assume EMACS_INT is the same width as char *.
1922 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1923 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1924 Remove no-longer-needed casts.
1925 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1926 (xg_tool_bar_help_callback, xg_make_tool_item):
1927 Use EMACS_INTPTR to hold an integer
1928 that will be cast to void *; this can avoid a GCC warning
1929 if EMACS_INT is not the same width as void *.
1930 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1931 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1932 (current_message_1, set_message_1):
1933 Use a local to convert to proper width without a cast.
1934 * xmenu.c (dialog_selection_callback): Likewise.
1935
ede49d71
PE
1936 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1937 Also, don't assume VALBITS / RAND_BITS is less than 5,
1938 and don't rely on undefined behavior when shifting a 1 left into
1939 the sign bit.
1940 * lisp.h (get_random): Change signature to match.
1941
2f30ecd0
PE
1942 * lread.c (hash_string): Use size_t, not int, for hash computation.
1943 Normally we prefer signed values; but hashing is special, because
1944 it's better to use unsigned division on hash table sizes so that
1945 the remainder is nonnegative. Also, size_t is the natural width
1946 for hashing into memory. The previous code used 'int', which doesn't
1947 retain enough info to hash well into very large tables.
1948 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1949
2a866e7b
PE
1950 * dbusbind.c: Don't possibly lose pointer info when converting.
1951 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1952 Use XPNTR rather than XHASH, so that the high-order bits of
1953 the pointer aren't lost when converting through void *.
1954
51639eac
PE
1955 * eval.c (Fautoload): Don't double-shift a pointer.
1956
92394119
PE
1957 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1958
dbdb9a7c
JB
19592011-05-06 Juanma Barranquero <lekktu@gmail.com>
1960
1961 * gnutls.c (DEF_GNUTLS_FN):
1962 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1963
db7a0b4f
AS
19642011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1965
1966 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1967 marker. (Bug#8610)
1968
f7ff1b0f 19692011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1970
1971 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1972 New version that can reserve upto 2GB of heap space.
1973
f7ff1b0f 19742011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1975
1976 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1977
639c109b
TZ
19782011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1979
1980 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1981 `gnutls_certificate_set_x509_key_file'.
1982
d2127135
JB
19832011-05-05 Juanma Barranquero <lekktu@gmail.com>
1984
1985 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1986 Update dependencies.
1987
e968f4f3
JB
19882011-05-04 Juanma Barranquero <lekktu@gmail.com>
1989
1990 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1991 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1992 Remove unused parameter `fildes'.
1993 * process.c (read_process_output, send_process): Don't pass it.
1994
84d358f0
JB
19952011-05-04 Juanma Barranquero <lekktu@gmail.com>
1996
1997 Fix previous change: the library cache is defined in w32.c.
1998 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1999 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2000
0898ca10
JB
20012011-05-04 Juanma Barranquero <lekktu@gmail.com>
2002
2003 Implement dynamic loading of GnuTLS on Windows.
2004
2005 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2006 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2007 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2008 Declare.
2009
2010 * gnutls.c (Qgnutls_dll): Define.
2011 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2012 (gnutls_*): Declare function pointers.
2013 (init_gnutls_functions): New function to initialize function pointers.
2014 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2015 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2016 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2017 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2018 (emacs_gnutls_write, emacs_gnutls_read)
2019 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2020 (Fgnutls_available_p): New function.
2021 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2022 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2023 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2024
2025 * image.c: Include w32.h.
2026 (Vimage_type_cache): Delete.
2027 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2028 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2029 (w32_delayed_load): Move to w32.c.
2030
2031 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2032
2033 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2034 (w32_delayed_load): Move from image.c. When loading a library, record
2035 its filename in the :loaded-from property of the library id.
2036 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2037 Initialize and staticpro them.
2038 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2039
2040 * process.c: Include lisp.h before w32.h, not after.
2041 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2042 instead of gnutls_record_check_pending.
2043
2044 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2045
ff4de4aa
TZ
20462011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2047
2048 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2049 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2050 as passed in.
2051
abe95abb
JD
20522011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2053
2054 * xterm.c (x_set_frame_alpha): Do not set property on anything
2055 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2056
e16e55d4
JB
20572011-05-02 Juanma Barranquero <lekktu@gmail.com>
2058
2059 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2060
bafcf6a5
JB
20612011-05-02 Juanma Barranquero <lekktu@gmail.com>
2062
2063 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2064 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2065 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2066 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2067 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2068 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2069 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2070 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2071 (Qgnutls_bootprop_callbacks_verify): Make static.
2072
e7a6747f
AS
20732011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2074
19ed11ba
AS
2075 * callproc.c: Indentation fixup.
2076
e7a6747f 2077 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2078 (wait_for_termination, interruptible_wait_for_termination):
2079 Move after wait_for_termination_1.
e7a6747f 2080
1ef14cb4
LMI
20812011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2082
2083 * sysdep.c (interruptible_wait_for_termination): New function
2084 which is like wait_for_termination, but allows keyboard
2085 interruptions.
2086
2087 * callproc.c (Fcall_process): Add (:file "file") as an option for
2088 the STDOUT buffer.
2089 (Fcall_process_region): Ditto.
2090
330d880c
EZ
20912011-04-30 Eli Zaretskii <eliz@gnu.org>
2092
8db90b73
EZ
2093 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2094 rather than `XVECTOR (FOO)->size'.
2095
330d880c
EZ
2096 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2097 inttypes.h, as a gnulib replacement is used if it not available in
2098 system headers.
2099
15cbd324
EZ
21002011-04-21 Eli Zaretskii <eliz@gnu.org>
2101
2102 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2103 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2104 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2105
2106 * coding.c (coding_alloc_by_realloc): Error out if destination
2107 will grow beyond MOST_POSITIVE_FIXNUM.
2108 (decode_coding_emacs_mule): Abort if there isn't enough place in
2109 charbuf for the composition carryover bytes. Reserve an extra
2110 space for up to 2 characters produced in a loop.
2111 (decode_coding_iso_2022): Abort if there isn't enough place in
2112 charbuf for the composition carryover bytes.
2113
21142011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2115
ae940cca
EZ
2116 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2117 aborting when %lld or %lll format is passed.
2118 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2119 %llo or %llx format is passed. (Bug#8545)
2120
03ab8921
EZ
2121 * window.c (window_scroll_line_based): Use a marker instead of
2122 simple variables to record original value of point. (Bug#7952)
2123
afda1437
EZ
2124 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2125 produced by %s or %c overflows available buffer space. (Bug#8545)
2126
f76dee0c
PE
21272011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2128
2129 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2130 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2131
fdc5744d
JB
21322011-04-28 Juanma Barranquero <lekktu@gmail.com>
2133
2134 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2135
638f053a
JB
21362011-04-28 Juanma Barranquero <lekktu@gmail.com>
2137
2138 * keyboard.c (Qdelayed_warnings_hook): Define.
2139 (command_loop_1): Run `delayed-warnings-hook'
2140 if Vdelayed_warnings_list is non-nil.
2141 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2142 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2143
d178f871
EZ
21442011-04-28 Eli Zaretskii <eliz@gnu.org>
2145
2146 * doprnt.c (doprnt): Don't return value smaller than the buffer
2147 size if the message was truncated. (Bug#8545).
2148
b124fd93
JB
21492011-04-28 Juanma Barranquero <lekktu@gmail.com>
2150
2151 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2152 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2153
e810457d
PE
21542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2157
ea51cceb
JB
21582011-04-27 Juanma Barranquero <lekktu@gmail.com>
2159
2160 * makefile.w32-in: Update dependencies.
2161
94dcfacf
EZ
21622011-04-27 Eli Zaretskii <eliz@gnu.org>
2163
2164 Improve `doprnt' and its usage. (Bug#8545)
2165 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2166 `format_end'. Remove support for %l as a conversion specifier.
2167 Don't use xrealloc. Improve diagnostics when the %l size modifier
2168 is used. Update the commentary.
2169
2170 * eval.c (verror): Simplify calculation of size_t.
2171
2172 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2173 messages.
2174
f61f41d7
PE
21752011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2176
2177 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2178 change.
2179
96fb4434
PE
21802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2181
2182 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2183 This makes this file independent of the recent pseudovector change.
2184
671875da 21852011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2186
69e9b5a3
PE
2187 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2188
b5f869a7 2189 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2190 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2191 Remove unused local.
c8926152 2192 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2193
841a1577 2194 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2195 GCC 4.6.0 optimizes based on type-based alias analysis.
2196 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2197 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2198 != &v->size, and therefore "v->size = 1; b->size = 2; return
2199 v->size;" must therefore return 1. This assumption is incorrect
2200 for Emacs, since it type-puns struct Lisp_Vector * with many other
2201 types. To fix this problem, this patch adds a new type struct
f904488f 2202 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2203 and pseudovectors, and helps optimizing compilers not get fooled
2204 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2205 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2206 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2207 the size member.
eab3844f
PE
2208 (XSETPVECTYPE): Rewrite in terms of new macro.
2209 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2210 This is a bit clearer, and further avoids the possibility of
2211 undesirable aliasing.
2212 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2213 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2214 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2215 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2216 (ASIZE): Now uses header.size rather than size.
2217 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2218 to avoid the hassle of writing XVECTOR (foo)->header.size.
2219 (struct vectorlike_header): New type.
eab3844f
PE
2220 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2221 object, to help avoid aliasing.
2222 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2223 (SUBRP): Likewise, since Lisp_Subr is a special case.
2224 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2225 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2226 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2227 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2228 changed to be "header.size" and "header.next".
2229 * buffer.h (struct buffer): Likewise.
2230 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2231 * frame.h (struct frame): Likewise.
2232 * process.h (struct Lisp_Process): Likewise.
2233 * termhooks.h (struct terminal): Likewise.
2234 * window.c (struct save_window_data, struct saved_window): Likewise.
2235 * window.h (struct window): Likewise.
2236 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2237 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2238 * buffer.c (init_buffer_once): Likewise.
2239 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2240 special case.
2241 * process.c (Fformat_network_address): Use local var for size,
2242 for brevity.
2243
0df1eac5
PE
2244 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2245
847ab9d1 2246 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2247 * data.c (atof): Remove decl; no longer used or needed.
2248 (digit_to_number): Move to lread.c.
2249 (Fstring_to_number): Use new string_to_number function, to be
2250 consistent with how the Lisp reader treats infinities and NaNs.
2251 Do not assume that floating-point numbers represent EMACS_INT
2252 without losing information; this is not true on most 64-bit hosts.
2253 Avoid double-rounding errors, by insisting on integers when
2254 parsing non-base-10 numbers, as the documentation specifies.
2255 * lisp.h (string_to_number): New decl, replacing ...
2256 (isfloat_string): Remove.
bc0a5c13 2257 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2258 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2259 appears to have been a coding error. Similarly, do not accept
2260 strings like +-1e0 as floating point numbers. Do not report
2261 overflow for integer overflows unless the base is not 10 which
2262 means we have no simple and reliable way to continue.
2263 Break out the floating-point parsing into a new
2264 function string_to_number, so that Fstring_to_number parses
2265 floating point numbers consistently with the Lisp reader.
04f2d78b 2266 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2267 (E_CHAR, EXP_INT): Remove, replacing with ...
2268 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2269 (string_to_number): New function, replacing isfloat_string.
2270 This function checks for valid syntax and produces the resulting
2271 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2272 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2273 so that overflow for non-base-10 numbers is reported only when
2274 there's no portable and simple way to convert to floating point.
452f4150 2275
67769ffc
PE
2276 * textprop.c (set_text_properties_1): Rewrite for clarity,
2277 and to avoid GCC warning about integer overflow.
2278
c20db43f
PE
2279 * intervals.h (struct interval): Use EMACS_INT for members
2280 where EMACS_UINT might cause problems. See
2281 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2282 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2283 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2284 All uses changed.
37aa2f85
PE
2285 (offset_intervals): Tell GCC not to worry about length overflow
2286 when negating a negative length.
c20db43f 2287
2538aa2f
PE
2288 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2289 (overrun_check_free): Likewise.
2290
f2d3008d
PE
2291 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2292 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2293 word size.
2294
ec8df744
PE
2295 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2296 (gnutls_make_error): Rename local to avoid shadowing.
2297 (gnutls_emacs_global_deinit): ifdef out; not used.
2298 (Fgnutls_boot): Use const for pointer to readonly storage.
2299 Comment out unused local. Fix pointer signedness problems.
2300
640ee02d
PE
2301 * lread.c (openp): Don't stuff size_t into an 'int'.
2302 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2303 about possible signed overflow.
2304
6048fb2a
PE
2305 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2306 (GDK_KEY_g): Don't define if already defined.
2307 (xg_prepare_tooltip): Avoid pointer signedness problem.
2308 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2309
fa3c87e1
PE
2310 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2311 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2312
2172544b
PE
2313 * xfns.c (Fx_window_property): Simplify a bit,
2314 to make a bit faster and to avoid GCC 4.6.0 warning.
2315 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2316
9b821a21
PE
2317 * fns.c (internal_equal): Don't assume size_t fits in int.
2318
3c616cfa
PE
2319 * alloc.c (compact_small_strings): Tighten assertion a little.
2320
c2982e87
PE
2321 Replace pEd with more-general pI, and fix some printf arg casts.
2322 * lisp.h (pI): New macro, generalizing old pEd macro to other
2323 conversion specifiers. For example, use "...%"pI"d..." rather
2324 than "...%"pEd"...".
2325 (pEd): Remove. All uses replaced with similar uses of pI.
2326 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2327 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2328 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2329 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2330 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2331 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2332 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2333 64-bit hosts.
2334 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2335 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2336 * print.c (safe_debug_print, print_object): Likewise.
2337 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2338 to int.
6f04d126
PE
2339 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2340 avoiding the 0 flag, which is not portable.
c2982e87
PE
2341 * process.c (Fmake_network_process): Use pI to avoid cast.
2342 * region-cache.c (pp_cache): Likewise.
2343 * xdisp.c (decode_mode_spec): Likewise.
2344 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2345 behavior on 64-bit hosts with printf arg.
6f04d126 2346 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2347 (x_stop_queuing_selection_requests): Likewise.
2348 (x_get_window_property): Don't truncate byte count to an 'int'
2349 when tracing.
0b432f21 2350
5e073ec7
PE
2351 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2352 here, since it parses constructs like leading '-' and spaces,
2353 which are not wanted; and it overflows with large numbers.
2354 Instead, simply match F[0-9]+, which is what is wanted anyway.
2355
36372bf9
PE
2356 * alloc.c: Remove unportable assumptions about struct layout.
2357 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2358 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2359 (allocate_vectorlike, make_pure_vector): Use the new macros,
2360 plus offsetof, to remove unportable assumptions about struct layout.
2361 These assumptions hold on all porting targets that I know of, but
2362 they are not guaranteed, they're easy to remove, and removing them
2363 makes further changes easier.
2364
0b432f21
PE
2365 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2366 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2367 (string_overrun_cookie): Now const. Use initializers that
2368 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2369 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2370 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2371 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2372 multiple of sizeof (EMACS_INT); it need not be, if
2373 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2374 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2375
895009e1
JB
23762011-04-26 Juanma Barranquero <lekktu@gmail.com>
2377
2378 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2379
6a7a1b0b
TZ
23802011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2381
2382 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2383 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2384 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2385
841a1577 23862011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2387
2388 * lisp.h (Qdebug): List symbol.
895009e1 2389 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2390 * keyboard.c (debug-on-event): New variable.
2391 (handle_user_signal): Break into debugger when debug-on-event
2392 matches the current signal symbol.
2393
f2d3ba6f
DN
23942011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2395
2396 * alloc.c (check_sblock, check_string_bytes)
2397 (check_string_free_list): Convert to standard C.
2398
42ce4c63
TZ
23992011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2400
2401 * w32.c (emacs_gnutls_push): Fix typo.
2402
825cd63c
EZ
24032011-04-25 Eli Zaretskii <eliz@gnu.org>
2404
fb11d64d
EZ
2405 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2406 "cast to pointer from integer of different size".
2407
825cd63c
EZ
2408 Improve doprnt and its use in verror. (Bug#8545)
2409 * doprnt.c (doprnt): Document the set of format control sequences
2410 supported by the function. Use SAFE_ALLOCA instead of always
2411 using `alloca'.
2412
2413 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2414 is one byte too soon. Don't use xrealloc; instead xfree and
2415 xmalloc anew.
2416
e061a11b
TZ
24172011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2418
2419 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2420 callbacks stage.
2421
2422 * gnutls.c: Renamed global_initialized to
2423 gnutls_global_initialized. Added internals for the
2424 :verify-hostname-error, :verify-error, and :verify-flags
2425 parameters of `gnutls-boot' and documented those parameters in the
2426 docstring. Start callback support.
2427 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2428 unless a fatal error occured. Call gnutls_alert_send_appropriate
2429 on error. Return error code.
2430 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2431 (emacs_gnutls_read): Likewise.
2432 (Fgnutls_boot): Return handshake error code.
2433 (emacs_gnutls_handle_error): New function.
2434 (wsaerror_to_errno): Likewise.
2435
2436 * w32.h (emacs_gnutls_pull): Add prototype.
2437 (emacs_gnutls_push): Likewise.
2438
2439 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2440 (emacs_gnutls_push): Likewise.
2441
24422011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2443
2444 * process.c (wait_reading_process_output): Check if GnuTLS
2445 buffered some data internally if no FDs are set for TLS
2446 connections.
2447
2448 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2449 (LIBS): Link to USER_LIBS.
2450 ($(BLD)/gnutls.$(0)): New target.
2451
fa6996bc
EZ
24522011-04-24 Eli Zaretskii <eliz@gnu.org>
2453
eb35682e
EZ
2454 * xdisp.c (handle_single_display_spec): Rename the
2455 display_replaced_before_p argument into display_replaced_p, to
2456 make it consistent with the commentary. Fix typos in the
2457 commentary.
2458
e2ad650c
EZ
2459 * textprop.c (syms_of_textprop): Remove dead code.
2460 (copy_text_properties): Delete obsolete commentary about an
2461 interface that was deleted long ago. Fix typos in the description
2462 of arguments.
2463
1b2de274
EZ
2464 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2465 to changes in oldXMenu/XMenu.h from 2011-04-16.
2466 <menu_help_message, prev_menu_help_message>: Constify.
2467 (IT_menu_make_room): menu->help_text is now `const char **';
2468 adjust.
2469
2470 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2471 to changes in oldXMenu/XMenu.h from 2011-04-16.
2472 (struct XMenu): Declare `help_text' `const char **'.
2473
2474 * xfaces.c <Qunspecified>: Make extern again.
2475
2476 * syntax.c: Include sys/types.h before including regex.h, as
2477 required by Posix.
2478
762b15be
EZ
2479 * doc.c (get_doc_string): Improve the format passed to `error'.
2480
2481 * doprnt.c (doprnt): Improve commentary.
2482
2483 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2484
2485 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2486 them with etags.
2487
f1052e5d
EZ
2488 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2489 changes in globals.h immediately force recompilation.
762b15be
EZ
2490 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2491 $(CURDIR)/s/ms-w32.h.
2492 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2493
fa6996bc
EZ
2494 * character.c (Fchar_direction): Function deleted.
2495 (syms_of_character): Don't defsubr it.
2496 <char-direction-table>: Deleted.
2497
e6c3da20
EZ
24982011-04-23 Eli Zaretskii <eliz@gnu.org>
2499
2500 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2501 * doprnt.c: Include limits.h.
2502 (SIZE_MAX): New macro.
04f2d78b
CB
2503 (doprnt): Return a size_t value. 2nd arg is now size_t.
2504 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2505 Improve overflow protection. Support `l' modifier for integer
2506 conversions. Support %l conversion. Don't assume an EMACS_INT
2507 argument for integer conversions and for %c.
2508
2509 * lisp.h (doprnt): Restore prototype.
2510
2511 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2512 $(SRC)/character.h.
2513
2514 * Makefile.in (base_obj): Add back doprnt.o.
2515
2516 * deps.mk (doprnt.o): Add back prerequisites.
2517 (callint.o): Depend on character.h.
2518
2519 * eval.c (internal_lisp_condition_case): Include the handler
2520 representation in the error message.
2521 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2522 when breaking from the loop.
2523
2524 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2525
2526 * callint.c (Fcall_interactively): When displaying error message
2527 about invalid control letter, pass the character's codepoint, not
2528 a pointer to its multibyte form. Improve display of the character
2529 in octal and display also its hex code.
2530
2531 * character.c (char_string): Use %x to display the (unsigned)
2532 codepoint of an invalid character, to avoid displaying a bogus
2533 negative value.
2534
2535 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2536 `error', not SYMBOL_NAME itself.
2537
2538 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2539 character arguments to `error'.
2540
2541 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2542 to `error' in error message about FINAL_CHAR argument. Make sure
2543 FINAL_CHAR is a character, and use %c when it is passed as
2544 argument to `error'.
2545
4ffd0d6b 25462011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2547
2548 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2549
2550 * w32.c: Include <time.h>.
2551 (sys_localtime): New function.
2552
4ffd0d6b 25532011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2554
2555 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2556
4ffd0d6b 2557 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2558
4ffd0d6b 25592011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2560
4ffd0d6b
GM
2561 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2562 zombies (Bug#8467).
aac0c6e3 2563
04c56954
EZ
25642011-04-19 Eli Zaretskii <eliz@gnu.org>
2565
2566 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2567 gl_state.e_property when gl_state.object is Qt.
2568
2569 * insdel.c (make_gap_larger): Remove limitation of buffer size
2570 to <= INT_MAX.
2571
16a43933
CY
25722011-04-18 Chong Yidong <cyd@stupidchicken.com>
2573
2574 * xdisp.c (lookup_glyphless_char_display)
2575 (produce_glyphless_glyph): Handle cons cell entry in
2576 glyphless-char-display.
2577 (Vglyphless_char_display): Document it.
2578
2579 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2580 glyphless-char-display.
2581
4581706e
CY
25822011-04-17 Chong Yidong <cyd@stupidchicken.com>
2583
2584 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2585
2586 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2587
2588 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2589 definition for no-X builds.
2590
4887c6e2 25912011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2592
fd35b6f9
PE
2593 Static checks with GCC 4.6.0 and non-default toolkits.
2594
5c1ccb01
PE
2595 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2596
006c5daa
PE
2597 * process.c (keyboard_bit_set): Define only if SIGIO.
2598 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2599 (send_process): Repair possible setjmp clobbering.
2600
efc736d3
PE
2601 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2602
4e2fe2e6
PE
2603 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2604
f97334a2
PE
2605 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2606
4e75f29d
PE
2607 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2608 Define only if needed.
2609
90efadd1
PE
2610 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2611 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2612 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2613
3c647824
PE
2614 * dispextern.h (struct redisplay_interface): Rename param
2615 to avoid shadowing.
e264f262 2616 * termhooks.h (struct terminal): Likewise.
761383f4 2617 * xterm.c (xembed_send_message): Likewise.
3c647824 2618
b58c5c4a
PE
2619 * insdel.c (make_gap_smaller): Define only if
2620 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2621
cad59032
PE
2622 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2623 it.
2624
c339dc2e
PE
2625 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2626 so that we aren't warned about unused symbols.
2627
91a3e27b
PE
2628 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2629
399c71d3 2630 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2631
8ffc96f5
PE
2632 * xfns.c (x_real_positions): Mark locals as initialized.
2633
eef9bc79
PE
2634 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2635
098db9dd
PE
2636 * xterm.c: Fix problems found by static analysis with other toolkits.
2637 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2638 (x_dispatch_event): Declare static if USE_GTK, and
2639 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2640 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2641 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2642 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2643 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2644
eb18f6cc
PE
2645 * xmenu.c (menu_help_callback): Pointer type fixes.
2646 Use const pointers when pointing at readonly data. Avoid pointer
2647 signedness clashes.
2648 (FALSE): Remove unused macro.
2649 (update_frame_menubar): Remove unused decl.
2650
1fe72bf8
PE
2651 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2652
60d9e1db
PE
2653 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2654 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2655 (single_menu_item): Rename local to avoid shadowing.
2656
39261c26
PE
2657 * keyboard.c (make_lispy_event): Remove unused local var.
2658
018c5e19
PE
2659 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2660 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2661
63d2b86e
PE
2662 * bitmaps: Change bitmaps from unsigned char back to the X11
2663 compatible char. Avoid the old compiler warnings about
2664 out-of-range initializers by using, for example, '\xab' rather
2665 than 0xab.
2666
aefd87e1
PE
2667 * xgselect.c (xgselect_initialize): Check vs interface
2668 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2669
bf501fb9
PE
2670 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2671
e9829fdf
PE
2672 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2673 to read-only memory.
2674
1086c095
PE
2675 * fns.c (vector): Remove; this old hack is no longer needed.
2676
2baccd04 2677 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2678 Remove unused var.
dde42981 2679 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2680
72391843 2681 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2682
436c16df 2683 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2684 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2685 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2686
92bb796d 2687 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2688 (x_term_init): Remove local to avoid shadowing.
92bb796d 2689
764430a3 2690 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2691
2692 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2693 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2694
d1dfb56c
EZ
26952011-04-16 Eli Zaretskii <eliz@gnu.org>
2696
c4354cb4
EZ
2697 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2698
d1dfb56c
EZ
2699 Fix regex.c, syntax.c and friends for buffers > 2GB.
2700 * syntax.h (struct gl_state_s): Declare character position members
2701 EMACS_INT.
2702
2703 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2704
04f2d78b
CB
2705 * textprop.c (verify_interval_modification, interval_of):
2706 Declare arguments EMACS_INT.
d1dfb56c
EZ
2707
2708 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2709 EMACS_INT.
2710
2711 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2712
2713 * indent.c (Fvertical_motion): Local variable it_start is now
2714 EMACS_INT.
2715
2716 * regex.c (re_match, re_match_2, re_match_2_internal)
2717 (bcmp_translate, regcomp, regexec, print_double_string)
2718 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2719 (re_compile_pattern, re_exec): Declare arguments and local
2720 variables `size_t' and `ssize_t' and return values `regoff_t', as
2721 appropriate.
2722 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2723 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2724 <compile_stack_type>: `size' and `avail' are now `size_t'.
2725
2726 * regex.h <regoff_t>: Use ssize_t, not int.
2727 (re_search, re_search_2, re_match, re_match_2): Arguments that
2728 specify buffer/string position and length are now ssize_t and
2729 size_t. Return type is regoff_t.
2730
613052cd
BK
27312011-04-16 Ben Key <bkey76@gmail.com>
2732
2733 * nsfont.m: Fixed bugs in ns_get_family and
2734 ns_descriptor_to_entity that were caused by using free to
2735 deallocate memory blocks that were allocated by xmalloc (via
2736 xstrdup). This caused Emacs to crash when compiled with
2737 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2738 --enable-checking=xmallocoverrun). xfree is now used to
2739 deallocate these memory blocks.
2740
4170f62f 27412011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2742
71b41406
PE
2743 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2744
9587a89d
PE
2745 emacs_write: Accept and return EMACS_INT for sizes.
2746 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2747 et seq.
2748 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2749 Accept and return EMACS_INT.
2750 (emacs_gnutls_write): Return the number of bytes written on
2751 partial writes.
2752 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2753 (emacs_read, emacs_write): Remove check for negative size, as the
2754 Emacs source code has been audited now.
9587a89d
PE
2755 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2756 (emacs_read, emacs_write): Use it.
273a5f82
PE
2757 * process.c (send_process): Adjust to the new signatures of
2758 emacs_write and emacs_gnutls_write. Do not attempt to store
2759 a byte offset into an 'int'; it might overflow.
9587a89d 2760 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2761
3e047f51
PE
2762 * sound.c: Don't assume sizes fit in 'int'.
2763 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2764 Return EMACS_INT, not int.
3e047f51 2765 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2766 Accept EMACS_INT, not int.
2767 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2768 record read return values.
2769
cc39a9db
BK
27702011-04-15 Ben Key <bkey76@gmail.com>
2771
c9d0ec6d
JB
2772 * keyboard.c (Qundefined): Don't declare static since it is used
2773 in nsfns.m.
2774 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2775 static since they are used in nsfont.m.
cc39a9db 2776
6c60eb9f
SM
27772011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2778
2779 * process.c (Qprocessp): Don't declare static.
2780 * lisp.h (Qprocessp): Declare again.
2781
7990b61a
JB
27822011-04-15 Juanma Barranquero <lekktu@gmail.com>
2783
2784 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2785
5d4cb038
PE
27862011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2787
8bd7b830 2788 Improve C-level modularity by making more things 'static'.
cd64ea1d 2789
e3b27b31
PE
2790 Don't publish debugger-only interfaces to other modules.
2791 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2792 (verify_bytepos, count_markers): Move decls to the only modules
2793 that need them.
2794 * region-cache.h (pp_cache): Likewise.
2795 * window.h (check_all_windows): Likewise.
2796 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2797
5d4cb038
PE
2798 * sysdep.c (croak): Now static, if
2799 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2800 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2801
2802 * alloc.c (refill_memory_reserve): Now static if
2803 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2804 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2805
e87b6180
PE
2806 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2807 Define only if USE_LUCID.
2808
ac64929e
PE
2809 * xrdb.c (x_customization_string, x_rm_string): Now static.
2810
6f37259d
PE
2811 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2812 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2813
1683e3ab
PE
2814 * xdisp.c (draw_row_with_mouse_face): Now static.
2815 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2816
de9c2632
PE
2817 * window.h (check_all_windows): Mark externally visible.
2818
2b96acb7
PE
2819 * window.c (window_deletion_count): Now static.
2820
2821 * undo.c: Make symbols static if they're not exported.
2822 (last_undo_buffer, last_boundary_position, pending_boundary):
2823 Now static.
2824
50436f33
PE
2825 * textprop.c (interval_insert_behind_hooks): Now static.
2826 (interval_insert_in_front_hooks): Likewise.
2827
64520e5c
PE
2828 * term.c: Make symbols static if they're not exported.
2829 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2830 (max_frame_lines, tty_set_terminal_modes):
2831 (tty_reset_terminal_modes, tty_turn_off_highlight):
2832 (get_tty_terminal): Now static.
2833 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2834 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2835 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2836 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2837 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2838
1fa53021
PE
2839 * sysdep.c: Make symbols static if they're not exported.
2840 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2841 Now static.
2842 (sigprocmask_set, full_mask): Remove; unused.
2843 (wait_debugging): Mark as visible.
2844 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2845 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2846
d4b43b22
PE
2847 * syntax.c (syntax_temp): Define only if !__GNUC__.
2848
b7c513d0
PE
2849 * sound.c (current_sound_device, current_sound): Now static.
2850
989b29ad
PE
2851 * search.c (searchbufs, searchbuf_head): Now static.
2852
13a55a78
PE
2853 * scroll.c (scroll_cost): Remove; unused.
2854 * dispextern.h (scroll_cost): Remove decl.
2855
de68a1fc
PE
2856 * region-cache.h (pp_cache): Mark as externally visible.
2857
40ccffa6
PE
2858 * process.c: Make symbols static if they're not exported.
2859 (process_tick, update_tick, create_process, chan_process):
2860 (Vprocess_alist, proc_buffered_char, datagram_access):
2861 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2862 (deactivate_process): Mark defn as static, as well as decl.
2863 * lisp.h (create_process): Remove decl.
2864 * process.h (chan_process, Vprocess_alist): Remove decls.
2865
ad64fc97
PE
2866 * print.c: Make symbols static if they're not exported.
2867 (print_depth, new_backquote_output, being_printed, print_buffer):
2868 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2869 (print_interval, print_number_index, initial_stderr_stream):
2870 Now static.
2871 * lisp.h (Fprinc): Remove decl.
2872 (debug_output_compilation_hack): Mark as externally visible.
2873
adddb265
PE
2874 * sysdep.c (croak): Move decl from here to syssignal.h.
2875 * syssignal.h (croak): Put it here, so the API can be checked when
2876 'croak' is called from dissociate_if_controlling_tty.
2877
1717ede2
PE
2878 * minibuf.c: Make symbols static if they're not exported.
2879 (minibuf_save_list, choose_minibuf_frame): Now static.
2880 * lisp.h (choose_minibuf_frame): Remove decl.
2881
fa5fb2bc
PE
2882 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2883
1e3890d1
PE
2884 * lread.c: Make symbols static if they're not exported.
2885 (read_objects, initial_obarray, oblookup_last_bucket_number):
2886 Now static.
2887 (make_symbol): Remove; unused.
2888 * lisp.h (initial_obarray, make_symbol): Remove decls.
2889
8a1414fa
PE
2890 * keyboard.c: Make symbols static if they're not exported.
2891 (single_kboard, recent_keys_index, total_keys, recent_keys):
2892 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2893 (this_single_command_key_start, echoing, last_auto_save):
2894 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2895 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2896 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2897 (Vlispy_mouse_stem, double_click_count):
2898 Now static.
2899 (force_auto_save_soon): Define only if SIGDANGER.
2900 (ignore_mouse_drag_p): Now static if
2901 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2902 (print_help): Remove; unused.
2903 (stop_character, last_timer_event): Mark as externally visible.
2904 * keyboard.h (ignore_mouse_drag_p): Declare only if
2905 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2906 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2907 * lisp.h (echoing): Remove decl.
2908 (force_auto_save_soon): Declare only if SIGDANGER.
2909 * xdisp.c (redisplay_window): Simplify code, to make it more
2910 obvious that ignore_mouse_drag_p is not accessed if !defined
2911 USE_GTK && !defined HAVE_NS.
2912
93ea6e8f
PE
2913 * intervals.c: Make symbols static if they're not exported.
2914 (merge_properties_sticky, merge_interval_right, delete_interval):
2915 Now static.
2916 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2917
77382fcc
PE
2918 * insdel.c: Make symbols static if they're not exported.
2919 However, leave prepare_to_modify_buffer alone. It's never
2920 called from outside this function, but that appears to be a bug.
2921 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2922 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2923 (adjust_after_replace_noundo): Remove; unused.
2924 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2925 (signal_before_change): Remove decls.
77382fcc 2926
9306c32e
PE
2927 * indent.c (val_compute_motion, val_vmotion): Now static.
2928
cd44d2eb
PE
2929 * image.c: Make symbols static if they're not exported.
2930 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2931 if USE_GTK.
2932 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2933 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2934
ad9a7a06
PE
2935 * fringe.c (standard_bitmaps): Now static.
2936 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2937
81626931
PE
2938 * frame.c: Make symbols static if they're not exported.
2939 (x_report_frame_params, make_terminal_frame): Now static.
2940 (get_frame_param): Now static, unless HAVE_NS.
2941 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2942 (x_get_resource_string): Remove; not used.
2943 * frame.h (make_terminal_frame, x_report_frame_params):
2944 (x_get_resource_string); Remove decls.
2945 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2946 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2947
239f9db9
PE
2948 * font.c, fontset.c: Make symbols static if they're not exported.
2949 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2950 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2951 * font.c (font_close_object): Now static.
2952 * font.h (font_close_object): Remove.
2953 * fontset.c (FONTSET_OBJLIST): Remove.
2954 (free_realized_fontset) #if-0 the body, which does nothing.
2955 (face_suitable_for_char_p): #if-0, as it's never called.
2956 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2957 * xfaces.c (face_at_string_position):
2958 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2959 since 0 is always ASCII.
2960
dfcf3579
PE
2961 * fns.c (weak_hash_tables): Now static.
2962
5045092b
PE
2963 * fileio.c: Make symbols static if they're not exported.
2964 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2965 (Vwrite_region_annotation_buffers): Now static.
2966
57a96f5c
PE
2967 * eval.c: Make symbols static if they're not exported.
2968 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2969 * lisp.h (backtrace_list): Remove decl.
2970
35f08c38
PE
2971 * emacs.c: Make symbols static if they're not exported.
2972 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2973 (fatal_error_code, fatal_error_signal_hook, standard_args):
2974 Now static.
2975 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2976 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2977 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2978 * lisp.h (fatal_error_signal_hook): Remove decl.
2979 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2980
f44bd759
PE
2981 * editfns.c: Move a (normally-unused) function to its only use.
2982 * editfns.c, lisp.h (get_operating_system_release): Remove.
2983 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2984 worth the hassle of breaking this out.
2985
b532497d
PE
2986 * xterm.c: Make symbols static if they're not exported.
2987 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2988 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2989 (x_destroy_window, x_delete_display):
2990 Now static.
2991 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2992 (x_mouse_leave): Remove; unused.
2993 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2994 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2995 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2996 Remove decls.
2997 (x_mouse_leave): Declare only if WINDOWSNT.
2998 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2999 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3000 USE_X_TOOLKIT.
3001
1675728f
PE
3002 * ftxfont.c: Make symbols static if they're not exported.
3003 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3004 HAVE_FREETYPE.
3005 * font.h (ftxfont_driver): Likewise.
3006
e4cebfca
PE
3007 * xfns.c: Make symbols static if they're not exported.
3008 (x_last_font_name, x_display_info_for_name):
3009 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3010 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3011 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3012 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3013 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3014 (last_show_tip_args): Now static.
3015 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3016 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3017 (x_screen_planes): Remove; unused.
3018 * dispextern.h (x_screen_planes): Remove decl.
3019
5bf46f05
PE
3020 * dispnew.c: Make symbols static if they're not exported.
3021 * dispextern.h (redraw_garbaged_frames, scrolling):
3022 (increment_row_positions): Remove.
3023 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3024 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3025 Now static.
3026 (redraw_garbaged_frames): Remove; unused.
3027
435f4c28
PE
3028 * xfaces.c: Make symbols static if they're not exported.
3029 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3030 Remove decls.
3031 * xterm.h (defined_color): Remove decls.
3032 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3033 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3034 (menu_face_changed_default, defined_color, free_realized_face):
3035 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3036 (ascii_face_of_lisp_face): Remove; unused.
3037
8524aef3
PE
3038 * xdisp.c: Make symbols static if they're not exported.
3039 * dispextern.h (scratch_glyph_row, window_box_edges):
3040 (glyph_to_pixel_coords, set_cursor_from_row):
3041 (get_next_display_element, set_iterator_to_next):
3042 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3043 (show_mouse_face): Remove decls
3044 * frame.h (message_buf_print): Likewise.
3045 * lisp.h (pop_message, set_message, check_point_in_composition):
3046 Likewise.
3047 * xterm.h (set_vertical_scroll_bar): Likewise.
3048 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3049 (message_buf_print, scratch_glyph_row, displayed_buffer):
3050 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3051 (get_next_display_element, show_mouse_face, window_box_edges):
3052 (frame_to_window_pixel_xy, check_point_in_composition):
3053 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3054 (glyph_to_pixel_coords): Remove; unused.
3055
16390cd2
PE
3056 * dired.c (file_name_completion): Now static.
3057
3058 * dbusbind.c (xd_in_read_queued_messages): Now static.
3059
a25f4dfa
PE
3060 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3061 * data.c (circular_list_error): Remove.
3062
14a9c8df
PE
3063 * commands.h (last_point_position, last_point_position_buffer):
3064 (last_point_position_window): Remove decls.
3065 * keyboard.c: Make these variables static.
3066
04f2d78b
CB
3067 * coding.h (coding, code_convert_region, encode_coding_gap):
3068 Remove decls.
74ab6df5
PE
3069 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3070 (iso_code_class, detect_coding, code_convert_region): Now static.
3071 (encode_coding_gap): Remove; unused.
3072
38dfbee1
PE
3073 * chartab.c (chartab_chars, chartab_bits): Now static.
3074
a2cb4e63
PE
3075 * charset.h (charset_iso_8859_1): Remove decl.
3076 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3077 Now static.
3078
127198fd
PE
3079 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3080 * ccl.c (Vccl_program_table): Now static.
3081 (check_ccl_update): Remove; unused.
3082
d85b608f
PE
3083 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3084 * category.h: ... from here.
3085 * category.c (check_category_table, set_category_set): Now static.
3086
31cd66f3
PE
3087 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3088 * lisp.h: Remove these decls.
3089
c358e587
PE
3090 * buffer.c (buffer_count): Remove unused var.
3091
e78aecca
PE
3092 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3093 so that it's not optimized away.
3094 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3095 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3096 exported only to the debugger.
3097
e192d7d3 3098 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3099 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3100
92470028
PE
3101 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3102 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3103 was inaccessible from Lisp.
3104 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3105 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3106
244ed907
PE
3107 alloc.c: Import and export fewer symbols, and remove unused items.
3108 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3109 is defined.
3110 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3111 it's not optimized away by whole-program optimization.
3112 (message_enable_multibyte, free_misc): Remove.
3113 (catchlist, handlerlist, mark_backtrace):
3114 Declare only if BYTE_MARK_STACK.
3115 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3116 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3117 (message_enable_multibyte): Remove decl.
3118 (free_misc, interval_free_list, float_block, float_block_index):
3119 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3120 (cons_free_list, last_marked_index):
3121 Now static.
3122 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3123 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3124 (mark_backtrace): Define only if BYTE_MARK_STACK.
3125 * xdisp.c (message_enable_multibyte): Now static.
3126
61c2b50e 3127 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3128 This makes it easier for human readers (and static analyzers)
3129 to see whether these variables are used from other modules.
3130 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3131 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3132 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3133 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3134 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3135 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3136 * xmenu.c, xselect.c:
3137 Declare Q* vars static if they are not used in other modules.
3138 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3139 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3140 Remove decls of unexported vars.
3141 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3142
95c82688
PE
3143 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3144
16a97296
PE
3145 Make Emacs functions such as Fatom 'static' by default.
3146 This makes it easier for human readers (and static analyzers)
3147 to see whether these functions can be called from other modules.
3148 DEFUN now defines a static function. To make the function external
3149 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3150 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3151 (Finit_image_library):
16a97296
PE
3152 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3153 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3154 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3155 Remove decls, since these functions are now static.
3156 (Funintern, Fget_internal_run_time): New decls, since these functions
3157 were already external.
95c82688 3158
16a97296
PE
3159 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3160 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3161 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3162 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3163 * keyboard.c, keymap.c, lread.c:
3164 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3165 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3166 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3167 Mark functions with DEFUE instead of DEFUN,
3168 if they are used in other modules.
3169 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3170 decls for now-static functions.
3171 * buffer.h (Fdelete_overlay): Remove decl.
3172 * callproc.c (Fgetenv_internal): Mark as internal.
3173 * composite.c (Fremove_list_of_text_properties): Remove decl.
3174 (Fcomposition_get_gstring): New forward static decl.
3175 * composite.h (Fcomposite_get_gstring): Remove decl.
3176 * dired.c (Ffile_attributes): New forward static decl.
3177 * doc.c (Fdocumntation_property): New forward static decl.
3178 * eval.c (Ffetch_bytecode): New forward static decl.
3179 (Funintern): Remove extern decl; now in .h file where it belongs.
3180 * fileio.c (Fmake_symbolic_link): New forward static decl.
3181 * image.c (Finit_image_library): New forward static decl.
3182 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3183 * intervals.h (Fprevious_property_change):
3184 (Fremove_list_of_text_properties): Remove decls.
3185 * keyboard.c (Fthis_command_keys): Remove decl.
3186 (Fcommand_execute): New forward static decl.
3187 * keymap.c (Flookup_key): New forward static decl.
3188 (Fcopy_keymap): Now static.
3189 * keymap.h (Flookup_key): Remove decl.
3190 * process.c (Fget_process): New forward static decl.
3191 (Fprocess_datagram_address): Mark as internal.
3192 * syntax.c (Fsyntax_table_p): New forward static decl.
3193 (skip_chars): Remove duplicate decl.
3194 * textprop.c (Fprevious_property_change): New forward static decl.
3195 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3196 Now internal.
3197 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3198 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3199
785bbd42
PE
3200 * editfns.c (Fformat): Remove unreachable code.
3201
8b913b57
AS
32022011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3203
3204 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3205 change. (Bug#8496)
3206
a6744a35
EZ
32072011-04-13 Eli Zaretskii <eliz@gnu.org>
3208
3209 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3210 when at ZV. (Bug#8487)
3211
e7974947
AS
32122011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3213
baad03f0
AS
3214 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3215 (Bug#8437)
3216 * keyboard.c (parse_tool_bar_item): Likewise.
3217 * sound.c (sound_cleanup, alsa_close): Likewise.
3218 * termcap.c (tgetent): Likewise.
3219 * xfns.c (x_default_font_parameter): Likewise.
3220 * xsettings.c (read_and_apply_settings): Likewise.
3221
e7974947
AS
3222 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3223 (overrun_check_free): Protoize.
3224
28272684
PE
32252011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3226
3227 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3228 since callers should never pass a negative size.
3229 Change the signature to match that of plain 'read' and 'write'; see
3230 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3231 * lisp.h: Update prototypes of emacs_write and emacs_read.
3232
11997c76
EZ
32332011-04-11 Eli Zaretskii <eliz@gnu.org>
3234
3235 * xdisp.c (redisplay_window): Don't try to determine the character
3236 position of the scroll margin if the window start point w->startp
e896f03c 3237 is outside the buffer's accessible region. (Bug#8468)
11997c76 3238
8a2cbd72
EZ
32392011-04-10 Eli Zaretskii <eliz@gnu.org>
3240
3241 Fix write-region and its subroutines for buffers > 2GB.
3242 * fileio.c (a_write, e_write): Modify declaration of arguments and
3243 local variables to support buffers larger than 2GB.
3244 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3245
3246 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3247 argument, local variables, and return value.
3248
3249 * lisp.h: Update prototypes of emacs_write and emacs_read.
3250
3251 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3252
4073e537 32532011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3254
1ebfdcb6
PE
3255 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3256
b2ded58d
PE
3257 Fix more problems found by GCC 4.6.0's static checks.
3258
7d66342c
PE
3259 * xdisp.c (vmessage): Use a better test for character truncation.
3260
bbf47d44
PE
3261 * charset.c (load_charset_map): <, not <=, for optimization,
3262 and to avoid potential problems with integer overflow.
9248994d 3263 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3264 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3265 * editfns.c (Fformat): Likewise.
1e69125e 3266 * syntax.c (skip_chars): Likewise.
3befa583 3267
e3019616
PE
3268 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3269 This also lets GCC 4.6.0 generate slightly better loop code.
3270
becfa255
PE
3271 * callint.c (Fcall_interactively): <, not <=, for optimization.
3272 (Fcall_interactively): Count the number of arguments produced,
3273 not the number of arguments given. This is simpler and lets GCC
3274 4.6.0 generate slightly better code.
3275
dae0cd48
PE
3276 * ftfont.c: Distingish more carefully between FcChar8 and char.
3277 The previous code passed unsigned char * to a functions like
3278 strlen and xstrcasecmp that expect char *, which does not
3279 conform to the C standard.
3280 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3281 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3282 char * when the C standard requires it.
3283
76032d70
PE
3284 * keyboard.c (read_char): Remove unused var.
3285
eb3f1cc8
PE
3286 * eval.c: Port to Windows vsnprintf (Bug#8435).
3287 Include <limits.h>.
3288 (SIZE_MAX): Define if the headers do not.
3289 (verror): Do not give up if vsnprintf returns a negative count.
3290 Instead, grow the buffer. This ports to Windows vsnprintf, which
3291 does not conform to C99. Problem reported by Eli Zaretskii.
3292 Also, simplify the allocation scheme, by avoiding the need for
3293 calling realloc, and removing the ALLOCATED variable.
3294
70476b54
PE
3295 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3296
12020a9e
PE
3297 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3298 But keep the doprint source code for now, as we might revamp it
3299 and use it again (Bug#8435).
ea6c7ae6
PE
3300 * lisp.h (doprnt): Remove.
3301 * Makefile.in (base_obj): Remove doprnt.o.
3302 * deps.mk (doprnt.o): Remove.
3303
5fdb398c
PE
3304 error: Print 32- and 64-bit integers portably (Bug#8435).
3305 Without this change, on typical 64-bit hosts error ("...%d...", N)
3306 was used to print both 32- and 64-bit integers N, which relied on
3307 undefined behavior.
3308 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3309 New macro.
3310 * lisp.h (error, verror): Mark as printf-like functions.
3311 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3312 Report overflow in size calculations when allocating printf buffer.
3313 Do not truncate output string at its first null byte.
3314 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3315 Truncate the output at a character boundary, since vsnprintf does not
3316 do that.
3317 * charset.c (check_iso_charset_parameter): Convert internal
3318 character to string before calling 'error', since %c now has the
3319 printf meaning.
3320 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3321 overflow when computing char to be passed to 'error'. Do not
3322 pass Lisp_Object to 'error'; pass the integer instead.
3323 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3324 formatted with plain %d.
3325
b189fa66
PE
3326 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3327
bff87ef0
PE
3328 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3329
7e2cac20
PE
3330 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3331
ce4d90b5
PE
3332 * xterm.c (x_catch_errors): Remove duplicate declaration.
3333
266c9547
PE
3334 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3335
79c49ad2
PE
3336 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3337
368f4090
JM
33382011-04-10 Jim Meyering <meyering@redhat.com>
3339
3340 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3341 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3342 return ssize_t not "int", and use size_t as the buffer length.
3343 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3344 * gnutls.h: Update declarations.
3345 * process.c (read_process_output): Use ssize_t, to match.
3346 (send_process): Likewise.
3347
a32d4040
CY
33482011-04-09 Chong Yidong <cyd@stupidchicken.com>
3349
3350 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3351
8546720e 33522011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3353
04f2d78b
CB
3354 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3355 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3356
8546720e
GM
3357 * xterm.c (handle_one_xevent):
3358 * xmenu.c (create_and_show_popup_menu):
3359 * xselect.c (x_decline_selection_request)
3360 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3361
0a2f5c1a 33622011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3363
3364 Fix some uses of `int' instead of EMACS_INT.
3365 * search.c (string_match_1, fast_string_match)
3366 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3367 (scan_buffer, find_next_newline_no_quit)
3368 (find_before_next_newline, search_command, Freplace_match)
3369 (Fmatch_data): Make some `int' variables be EMACS_INT.
3370
3371 * xdisp.c (display_count_lines): 3rd argument and return value now
3372 EMACS_INT. All callers changed.
3373 (pint2hrstr): Last argument is now EMACS_INT.
3374
3375 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3376 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3377 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3378 (decode_coding_utf_16, decode_coding_emacs_mule)
3379 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3380 (decode_coding_ccl, decode_coding_charset)
3381 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3382 (decode_coding_iso_2022, decode_coding_emacs_mule)
3383 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3384 <char_offset, last_offset>: Declare EMACS_INT.
3385 (encode_coding_utf_8, encode_coding_utf_16)
3386 (encode_coding_emacs_mule, encode_invocation_designation)
3387 (encode_designation_at_bol, encode_coding_iso_2022)
3388 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3389 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3390 Declare EMACS_INT.
3391 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3392 (encode_invocation_designation): Last argument P_NCHARS is now
3393 EMACS_INT.
3394 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3395 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3396
3397 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3398 All users changed.
3399
3400 * ccl.c (Fccl_execute_on_string): Declare some variables
3401 EMACS_INT.
3402
8546720e 34032011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3404
3405 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3406
4e19a977
CS
34072011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3408
3409 * process.c (Fformat_network_address): Doc fix.
3410
87302331
R
34112011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3412
3413 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3414
cbb59342
CY
34152011-04-08 Chong Yidong <cyd@stupidchicken.com>
3416
3417 * keyboard.c (read_char): Call Lisp function help-form-show,
3418 instead of using internal_with_output_to_temp_buffer.
3419 (Qhelp_form_show): New var.
e0d38eeb 3420 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3421
3422 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3423
3424 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3425
e67a13ab
CY
34262011-04-06 Chong Yidong <cyd@stupidchicken.com>
3427
04f2d78b
CB
3428 * process.c (Flist_processes): Remove to Lisp.
3429 (list_processes_1): Delete.
e67a13ab 3430
973f782d
EZ
34312011-04-06 Eli Zaretskii <eliz@gnu.org>
3432
7c106b1e
EZ
3433 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3434
973f782d
EZ
3435 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3436
41cf7d1a 34372011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3438
ca23cc88
PE
3439 Fix more problems found by GCC 4.6.0's static checks.
3440
f390e2d5
PE
3441 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3442
42eea0d0
PE
3443 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3444
b69769da 3445 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3446
f9541e84
PE
3447 * xdisp.c (vmessage): Mark as a printf-like function.
3448
13841b55
PE
3449 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3450
c136c10f
PE
3451 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3452
5e2d4a30
PE
3453 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3454 printf-like functions.
3455 (tiff_load): Add casts to remove these marks before passing them
3456 to system-supplied API.
3457
583f48b9
PE
3458 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3459
b25d760e
PE
3460 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3461 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3462 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3463 directly, rather than having caller test rule sign. This avoids
3464 some unnecessary tests.
3465 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3466 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3467 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3468
bc7b6697 3469 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3470 (xfont_open): Avoid unnecessary tests.
bc7b6697 3471
27ccc379
PE
3472 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3473
dcd5c89a
PE
3474 * composite.h, composite.c (composition_gstring_put_cache):
3475 Use EMACS_INT, not int, for length.
3476
b13a45c6
PE
3477 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3478 breaking out part of COMPOSITION_DECODE_RULE.
3479 (COMPOSITION_DECODE_RULE): Use it.
3480 * composite.c (get_composition_id): Remove unused local vars,
3481 by using the new macro.
3482
1e792e4d
PE
3483 * textprop.c (set_text_properties_1): Change while to do-while,
3484 since the condition is always true at first.
3485
dc6c6455 3486 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3487 (interval_deletion_adjustment): Return unsigned value.
3488 All uses changed.
dc6c6455 3489
aba7731a
PE
3490 * process.c (list_processes_1, create_pty, read_process_output):
3491 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3492 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3493 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3494 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3495 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3496
fdfc4bf3
PE
3497 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3498
fca8fe46 3499 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3500 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3501
06a0259a 3502 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3503 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3504 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3505
e7b9e80f
PE
3506 * print.c (print_error_message): Avoid int overflow.
3507
56201685
PE
3508 * font.c (font_list_entities): Redo for clarity,
3509 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3510
78834453 3511 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3512 (font_score): Avoid potential overflow in diff calculation.
78834453 3513
0bc0b309 3514 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3515 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3516
e610eaca
PE
3517 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3518
b895abce
PE
3519 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3520 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3521 can always succeed if overflow has undefined behavior.
3522
1f1d9321 3523 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3524 (wordify): Omit three unnecessary tests.
1f1d9321 3525
c59478bc
PE
3526 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3527 All callers changed. This avoids the need for an unused var.
3528
79b73827
PE
3529 * casefiddle.c (casify_region): Remove var that is set but not used.
3530
a4db5dfe
PE
3531 * dired.c (file_name_completion): Remove var that is set but not used.
3532
43aae36e
PE
3533 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3534
2a47c44d 3535 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3536 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3537
a37c69bf
PE
3538 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3539 Check for integer overflow on size calculations.
3540
328ab8e7
PE
3541 * buffer.c (Fprevious_overlay_change): Remove var that is set
3542 but not used.
3543
e5a2a5cb
PE
3544 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3545 Remove vars that are set but not used.
8d84a6eb 3546 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3547 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3548
a60e5f68
PE
3549 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3550
f661cb61 3551 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3552 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3553
f0397f5a
PE
3554 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3555 that are set but not used.
3556
8664db06 3557 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3558 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3559
6abdaa4a
PE
3560 * xselect.c (x_get_local_selection, x_handle_property_notify):
3561 Remove vars that are set but not used.
3562
0ce7538d 3563 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3564 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3565
9ae848fc
PE
3566 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3567 Remove var that is set but not used.
0b918413
PE
3568 (scroll_bar_windows_size): Now size_t, not int.
3569 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3570 Check for overflow.
9ae848fc 3571
a5a62657
PE
3572 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3573 (map_tty_color) [!defined MSDOS]: Likewise.
3574
5c5cdd39
PE
3575 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3576
66ebf983
PE
3577 * coding.c: Remove vars that are set but not used.
3578 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3579 All callers changed.
3580 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3581 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3582 (decode_coding_charset): Remove vars that are set but not used.
3583
1be4d761
PE
3584 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3585 that is set but not used.
3586
47553fa8
PE
3587 * print.c (print_object): Remove var that is set but not used.
3588
1f7196bf 3589 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3590 The gnulib version avoids calling malloc in the usual case,
3591 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3592 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3593 * filelock.c (current_lock_owner): Likewise.
3594 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3595 * sysdep.c: Include allocator.h, careadlinkat.h.
3596 (emacs_no_realloc_allocator): New static constant.
3597 (emacs_readlink): New function.
fdb61804
PE
3598 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3599 ../lib/careadlinkat.h.
d1fdcab7 3600
f84c17c7
SM
36012011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3602
3603 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3604 first non-nil return value).
3605
ef3862ad
JD
36062011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3607
3608 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3609 if not defined (Bug#8403).
3610
376a7006
JB
36112011-04-02 Juanma Barranquero <lekktu@gmail.com>
3612
3613 * xdisp.c (display_count_lines): Remove parameter `start',
3614 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3615 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3616 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3617 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3618 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3619 and thereabouts. All callers changed.
3620 (get_per_char_metric): Remove parameter `f', unused since
3621 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3622
6ca3801d
JM
36232011-04-02 Jim Meyering <meyering@redhat.com>
3624
3625 do not dereference NULL upon failed strdup
3626 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3627 (ns_get_family): Likewise.
3628
d8e2b5ba
JB
36292011-04-02 Juanma Barranquero <lekktu@gmail.com>
3630
3631 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3632
8c74fcbd
JD
36332011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3634
3635 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3636 later (Bug#8403).
3637
7200d79c
SM
36382011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3639
03408648 3640 Add lexical binding.
7200d79c 3641
03408648
SM
3642 * window.c (Ftemp_output_buffer_show): New fun.
3643 (Fsave_window_excursion):
3644 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3645
3646 * lread.c (lisp_file_lexically_bound_p): New function.
3647 (Fload): Bind Qlexical_binding.
3648 (readevalloop): Remove `evalfun' arg.
3649 Bind Qinternal_interpreter_environment.
3650 (Feval_buffer): Bind Qlexical_binding.
3651 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3652 Mark as dynamic.
3653 (syms_of_lread): Declare `lexical-binding'.
3654
3655 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3656
3657 * keyboard.c (eval_dyn): New fun.
3658 (menu_item_eval_property): Use it.
ca105506
SM
3659
3660 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3661
03408648
SM
3662 * fns.c (concat, mapcar1): Accept byte-code-functions.
3663
3664 * eval.c (Fsetq): Handle lexical vars.
3665 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3666 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3667 (FletX, Flet): Obey lexical binding.
3668 (Fcommandp): Handle closures.
3669 (Feval): New `lexical' arg.
3670 (eval_sub): New function extracted from Feval. Use it almost
3671 everywhere where Feval was used. Look up vars in lexical env.
3672 Handle closures.
3673 (Ffunctionp): Move from subr.el.
3674 (Ffuncall): Handle closures.
3675 (apply_lambda): Remove `eval_flags'.
3676 (funcall_lambda): Handle closures and new byte-code-functions.
3677 (Fspecial_variable_p): New function.
3678 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3679 but without exporting it to Lisp.
23aba0ea 3680
23aba0ea 3681 * doc.c (Fdocumentation, store_function_docstring):
03408648 3682 * data.c (Finteractive_form): Handle closures.
23aba0ea 3683
03408648
SM
3684 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3685 interactive spec.
ba83908c 3686
04f2d78b
CB
3687 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3688 New byte-codes.
03408648
SM
3689 (exec_byte_code): New function extracted from Fbyte_code to handle new
3690 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3691
03408648 3692 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3693
03408648 3694 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3695
e2abce01
JB
36962011-03-31 Juanma Barranquero <lekktu@gmail.com>
3697
3698 * xdisp.c (redisplay_internal): Fix prototype.
3699
63696a73 37002011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3701
63696a73 3702 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3703 (try_scrolling): Use it when setting scroll_limit.
3704 Limit scrolling to 100 screen lines.
63696a73
EZ
3705 (redisplay_window): Even when falling back on "recentering",
3706 position point in the window according to scroll-conservatively,
3707 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3708
3709 (try_scrolling): When point is above the window, allow searching
3710 as far as scroll_max, or one screenful, to compute vertical
3711 distance from PT to the scroll margin position. This prevents
3712 try_scrolling from unnecessarily failing when
3713 scroll-conservatively is set to a value slightly larger than the
3714 window height. Clean up the case of PT below the margin at bottom
3715 of window: scroll_max can no longer be INT_MAX. When aggressive
3716 scrolling is in use, don't let point enter the opposite scroll
3717 margin as result of the scroll.
3718 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3719 threshold of 100 lines for never-recentering scrolling.
3720
e4cc2dfc
JB
37212011-03-31 Juanma Barranquero <lekktu@gmail.com>
3722
3723 * dispextern.h (move_it_by_lines):
3724 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3725 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3726 (message_log_check_duplicate): Remove parameters `prev_bol' and
3727 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3728 (redisplay_internal): Remove parameter `preserve_echo_area',
3729 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3730
3731 * indent.c (Fvertical_motion):
3732 * window.c (window_scroll_pixel_based, Frecenter):
3733 Don't pass `need_y_p' to `move_it_by_lines'.
3734
1c470562
SM
37352011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3736
44f230aa
SM
3737 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3738 steal a few bits to be more compact.
3739 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3740 Remove unneeded casts.
3741
1c470562
SM
3742 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3743
888adce9
ZK
37442011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3745
3746 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3747 binding" message (bug#7967).
3748
f838ed7b
PE
37492011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3750
77861b95
PE
3751 Fix more problems found by GCC 4.6.0's static checks.
3752
de6dbc14
PE
3753 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3754 Remove unused local var.
3755
f838ed7b
PE
3756 * editfns.c (Fmessage_box): Remove unused local var.
3757
792c7b2b
PE
3758 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3759 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3760 Omit unused local vars.
c499e557 3761 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3762 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3763 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3764 Omit unused local var.
3765
ba0165e1
PE
3766 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3767 Don't assume string length fits in int.
32ad8845 3768 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3769 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3770
3c59b4c9
PE
3771 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3772 instead of alloca (Bug#8344).
3773
a3eed478 3774 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3775 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3776
eb4d412d
PE
3777 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3778
1658b401
PE
3779 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3780 concerns.
3781
3782 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3783
3784 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3785
9a2c6e05
PE
3786 * keyboard.c (syms_of_keyboard): Use the same style as later
3787 in this function when indexing through an array. This also
3788 works around GCC bug 48267.
3789
03d0a109
PE
3790 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3791
44f730c8
PE
3792 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3793
fe75f926
PE
3794 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3795 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3796
ffa8c828
PE
3797 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3798 This avoids undefined behavior on integer overflow, and is a bit
3799 more convenient anyway since it is compared to a size_t variable.
3800
c5101a77
PE
3801 Variadic C functions now count arguments with size_t, not int.
3802 This avoids an unnecessary limitation on 64-bit machines, which
3803 caused (substring ...) to crash on large vectors (Bug#8344).
3804 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3805 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3806 All variadic functions and their callers changed accordingly.
c5101a77
PE
3807 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3808 * data.c (arith_driver, float_arith_driver): Likewise.
3809 * editfns.c (general_insert_function): Likewise.
3810 * eval.c (struct backtrace.nargs, interactive_p)
3811 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3812 (funcall_lambda, mark_backtrace): Likewise.
3813 * fns.c (concat): Likewise.
3814 * frame.c (x_set_frame_parameters): Likewise.
3815 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3816 0 if not found, not -1. All callers changed.
3817
dd3f25f7
PE
3818 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3819 (stack_copy_size): Now size_t, not int.
3820 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3821
461c2ab9
JB
38222011-03-28 Juanma Barranquero <lekktu@gmail.com>
3823
3824 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3825 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3826 All callers changed.
3827
3828 * lisp.h (multibyte_char_to_unibyte):
3829 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3830 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3831 * character.h (CHAR_TO_BYTE8):
3832 * cmds.c (internal_self_insert):
3833 * editfns.c (general_insert_function):
3834 * keymap.c (push_key_description):
3835 * search.c (Freplace_match):
3836 * xdisp.c (message_dolog, set_message_1): All callers changed.
3837
f6d62986
SM
38382011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3839
3840 * keyboard.c (safe_run_hook_funcall): New function.
3841 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3842 don't set the hook to nil, but remove the offending function instead.
3843 (Qcommand_hook_internal): Remove, unused.
3844 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3845 Vcommand_hook_internal.
3846
3847 * eval.c (enum run_hooks_condition): Remove.
3848 (funcall_nil, funcall_not): New functions.
3849 (run_hook_with_args): Call each function through a `funcall' argument.
3850 Remove `cond' argument, now redundant.
3851 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3852 (Frun_hook_with_args_until_failure): Adjust accordingly.
3853 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3854
1db5b1ad
JB
38552011-03-28 Juanma Barranquero <lekktu@gmail.com>
3856
3857 * dispextern.h (string_buffer_position): Remove declaration.
3858
3859 * print.c (strout): Remove parameter `multibyte', unused since
3860 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3861
3862 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3863 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3864 All callers changed.
3865
3866 * w32.c (_wsa_errlist): Use braces for struct initializers.
3867
3868 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3869 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3870 All callers changed.
3871 (string_buffer_position): Likewise. Also, make static (it's never
3872 used outside xdisp.c).
3873 (cursor_row_p): Remove parameter `w', unused since
3874 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3875 (decode_mode_spec): Remove parameter `precision', introduced during
3876 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3877 All callers changed.
3878
5ffb62aa
JD
38792011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3880
3881 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3882
461c2ab9 38832011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3884
3885 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3886 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3887 (ns_update_auto_hide_menu_bar): New functions.
3888 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3889 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3890 ns_constrain_all_frames.
3891 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3892 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3893
5c380ffb
JD
38942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3895
3896 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3897
9af30bdf
GM
38982011-03-27 Glenn Morris <rgm@gnu.org>
3899
3900 * syssignal.h: Replace RETSIGTYPE with void.
3901 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3902 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3903 Replace SIGTYPE with void everywhere.
3904 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3905 * s/template.h (SIGTYPE): Remove commented out definition.
3906
e2abce01
JB
39072011-03-26 Eli Zaretskii <eliz@gnu.org>
3908
3909 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3910 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3911
f868cd8a
JB
39122011-03-26 Juanma Barranquero <lekktu@gmail.com>
3913
59eb0929
JB
3914 * w32.c (read_unc_volume): Use parameter `henum', instead of
3915 global variable `wget_enum_handle'.
3916
3917 * keymap.c (describe_vector): Remove parameters `indices' and
3918 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3919 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3920
f868cd8a
JB
3921 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3922
3923 * keyboard.c (timer_check): Remove parameter `do_it_now',
3924 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3925 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3926 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3927
3928 * keyboard.c (read_char):
3929 * w32menu.c (w32_menu_display_help):
3930 * xmenu.c (show_help_event, menu_help_callback):
3931 Adjust calls to `show_help_echo'.
3932
3933 * gtkutil.c (xg_maybe_add_timer):
3934 * keyboard.c (readable_events):
3935 * process.c (wait_reading_process_output):
3936 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3937
3938 * insdel.c (adjust_markers_gap_motion):
3939 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3940 (gap_left, gap_right): Don't call it.
3941
2ecf6fdb
CY
39422011-03-25 Chong Yidong <cyd@stupidchicken.com>
3943
3944 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3945 incurred during fontification.
3946
6b1f9ba4
JB
39472011-03-25 Juanma Barranquero <lekktu@gmail.com>
3948
3949 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3950 (DEFVAR_PER_BUFFER): Don't pass it.
3951
3952 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3953 (scrolling_window): Don't pass it.
3954
0f4a96b5
JB
39552011-03-25 Juanma Barranquero <lekktu@gmail.com>
3956
3957 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3958
3959 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3960 and `suffix'.
3961 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3962 of variables specific to SELinux and computation of `encoded_absname'.
3963
3964 * image.c (XPutPixel): Remove unused variable `height'.
3965
3966 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3967
3968 * unexw32.c (get_section_info): Remove unused variable `section'.
3969
3970 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3971 (system_process_attributes): Remove unused variable `sess'.
3972 (sys_read): Remove unused variable `err'.
3973
3974 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3975 (w32_wnd_proc): Remove unused variable `isdead'.
3976 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3977 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3978 (x_create_tip_frame): Remove unused variable `tem'.
3979
3980 * w32inevt.c (w32_console_read_socket):
3981 Remove unused variable `no_events'.
3982
3983 * w32term.c (x_draw_composite_glyph_string_foreground):
3984 Remove unused variable `width'.
3985
1149507c
JB
39862011-03-24 Juanma Barranquero <lekktu@gmail.com>
3987
3988 * w32term.c (x_set_glyph_string_clipping):
3989 Don't pass uninitialized region to CombineRgn.
3990
9c88f339
JB
39912011-03-23 Juanma Barranquero <lekktu@gmail.com>
3992
3993 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3994 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3995 (Fx_close_connection): Remove unused variable `i'.
3996
3997 * w32font.c (w32font_draw): Return number of glyphs.
3998 (w32font_open_internal): Remove unused variable `i'.
3999 (w32font_driver): Add missing initializer.
4000
4001 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4002 (fill_in_menu): Remove unused variable `items_added'.
4003
4004 * w32term.c (last_mouse_press_frame): Remove static global variable.
4005 (w32_clip_to_row): Remove unused variable `f'.
4006 (x_delete_terminal): Remove unused variable `i'.
4007
4008 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4009 (NOTHING): Remove unused static global variable.
4010 (uniscribe_check_otf): Remove unused variable `table'.
4011 (uniscribe_font_driver): Add missing initializers.
4012
dee091a3
JD
40132011-03-23 Julien Danjou <julien@danjou.info>
4014
4015 * term.c (Fsuspend_tty, Fresume_tty):
4016 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4017 * window.c (temp_output_buffer_show):
4018 * insdel.c (signal_before_change):
4019 * frame.c (Fhandle_switch_frame):
4020 * fileio.c (Fdo_auto_save):
4021 * emacs.c (Fkill_emacs):
4022 * editfns.c (save_excursion_restore):
4023 * cmds.c (internal_self_insert):
4024 * callint.c (Fcall_interactively):
4025 * buffer.c (Fkill_all_local_variables):
4026 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4027 Use Frun_hooks.
0f4a96b5 4028 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4029 unconditionnaly since it does the check itself.
4030
2c520ab5 40312011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4032
c9c49752
PE
4033 Fix more problems found by GCC 4.5.2's static checks.
4034
8abc3f12
PE
4035 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4036 the first time through the loop, since we know p0 < p1 then.
4037 This also avoids a gcc -Wstrict-overflow warning.
4038
a2d26660
PE
4039 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4040 leading to a memory leak, possible in functions like
4041 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4042 of objects (Bug#8318).
a2d26660 4043
916c72e9
PE
4044 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4045 that could (at least in theory) be that large.
4046
19ab8a18
PE
4047 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4048 This is less likely to overflow, and avoids undefined behavior if
4049 overflow does occur. All callers changed. Use strtoul to scan
4050 for the unsigned long integer.
b7cbbd6f
PE
4051 (pint2hrstr): Simplify and tune code slightly.
4052 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4053
f0641eff
PE
4054 * scroll.c (do_scrolling): Work around GCC bug 48228.
4055 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4056
7f650bb9
PE
4057 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4058 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4059 (validate_x_resource_name): Simplify count usage.
4060 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4061
37dd57d1
PE
4062 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4063 fail (Bug#8306).
81e56e61 4064
699979fc 4065 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4066
401bf9b4
PE
4067 * process.c (Fmake_network_process): Use socklen_t, not int,
4068 where POSIX says socklen_t is required in portable programs.
4069 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4070 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4071 (Fmake_network_process, server_accept_connection):
4072 (wait_reading_process_output, read_process_output):
4073 Likewise.
4074
b93aacde
PE
4075 * process.c: Rename or move locals to avoid shadowing.
4076 (list_processes_1, Fmake_network_process):
4077 (read_process_output_error_handler, exec_sentinel_error_handler):
4078 Rename or move locals.
4dc343ee 4079 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4080 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4081 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4082 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4083 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4084
af8a867c 4085 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4086 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4087 Include tparam.h instead, since it declares them.
af8a867c
PE
4088 * cm.h (PC): Remove extern decl; tparam.h now does this.
4089 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4090 * terminfo.c: Include tparam.h, to check interfaces.
4091 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4092 (tparam): Adjust signature to match interface in tparam.h;
4093 this removes some undefined behavior. Check that outstring and len
4094 are zero, which they always are with Emacs.
4095 * tparam.h (PC, BC, UP): New extern decls.
4096
0248044d 4097 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4098 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4099
8ff096c1 4100 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4101 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4102 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4103 (ftfont_list): Remove unused local.
49eaafba
PE
4104 (get_adstyle_property, ftfont_pattern_entity):
4105 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4106 Rename locals to avoid shadowing.
8ff096c1 4107
e2be39f6
PE
4108 * xfont.c (xfont_list_family): Mark var as initialized.
4109
c9735e30
PE
4110 * xml.c (make_dom): Now static.
4111
8f5201ae
PE
4112 * composite.c (composition_compute_stop_pos): Rename local to
4113 avoid shadowing.
b246f932
PE
4114 (composition_reseat_it): Remove unused locals.
4115 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4116 (composition_update_it): Mark var as initialized.
11b61122
PE
4117 (find_automatic_composition): Mark vars as initialized,
4118 with a FIXME (Bug#8290).
8f5201ae 4119
760fbc2c
PE
4120 character.h: Rename locals to avoid shadowing.
4121 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4122 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4123 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4124 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4125 to avoid shadowing.
4126
ff08eb85
PE
4127 * textprop.c (property_change_between_p): Remove; unused.
4128
fc7bf025
PE
4129 * intervals.c (interval_start_pos): Now static.
4130
235d7abc
PE
4131 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4132
44f230aa
SM
4133 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4134 Rename locals to avoid shadowing.
3e7d6594 4135
50060332
PE
4136 * sound.c (wav_play, au_play, Fplay_sound_internal):
4137 Fix pointer signedness.
d01f234b 4138 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4139 (wav_play): Initialize a variable to 0, to prevent undefined
4140 behavior (Bug#8278).
50060332 4141
c4fc4e30
PE
4142 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4143
918436ed
PE
4144 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4145
c939f91b
PE
4146 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4147 clobbering (Bug#8298).
b9c7f648
PE
4148 * sysdep.c (sys_subshell): Likewise.
4149 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4150
6bd8c144
PE
4151 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4152 This should get cleaned up, so that child_setup has the
4153 same signature on all platforms.
4154
7710357c 4155 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4156 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4157
c59da222
CY
41582011-03-22 Chong Yidong <cyd@stupidchicken.com>
4159
4160 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4161 not to be necessary, and produces flickering.
4162
66b87493
GM
41632011-03-20 Glenn Morris <rgm@gnu.org>
4164
4165 * config.in: Remove file.
4166
45b6f6d5
JB
41672011-03-20 Juanma Barranquero <lekktu@gmail.com>
4168
4169 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4170 are now in src/globals.h.
4171 (syms_of_minibuf): Remove spurious & from previous change.
4172
3ec03f7e
LL
41732011-03-20 Leo <sdl.web@gmail.com>
4174
4175 * minibuf.c (completing-read-function): New variable.
4176 (completing-read-default): Rename from completing-read.
4177 (completing-read): Call completing-read-function.
4178
b14e3e21
CY
41792011-03-19 Juanma Barranquero <lekktu@gmail.com>
4180
4181 * xfaces.c (Fx_load_color_file):
4182 Read color file from absolute filename (bug#8250).
4183
f2b726e6
JB
41842011-03-19 Juanma Barranquero <lekktu@gmail.com>
4185
4186 * makefile.w32-in: Update dependencies.
4187
09f6ff02
EZ
41882011-03-17 Eli Zaretskii <eliz@gnu.org>
4189
4190 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4191
29a6015a
PE
41922011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4193
a3a6c54e
PE
4194 Fix more problems found by GCC 4.5.2's static checks.
4195
b766f867
PE
4196 * process.c (make_serial_process_unwind, send_process_trap):
4197 (sigchld_handler): Now static.
4198
be02381c
PE
4199 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4200 That way, the code declares only the vars that it needs.
4201 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4202 * s/cygwin.h (PTY_ITERATION): Likewise.
4203 * s/darwin.h (PTY_ITERATION): Likewise.
4204 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4205
57048744
PE
4206 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4207 * process.c (allocate_pty): Don't declare stb unless it's needed.
4208
7914961c 4209 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4210 (CONSTANTLIM): Remove; unused.
4211 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4212 Define only if needed.
7914961c 4213
b3967b18
PE
4214 * unexelf.c (unexec): Name an expression,
4215 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4216 Use a different way to cause a compilation error if anyone uses
4217 n rather than nn, a way that does not involve shadowing.
73366a00 4218 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4219
29a6015a
PE
4220 * deps.mk (unexalpha.o): Remove; unused.
4221
43cfc33e 4222 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4223 * unexec.h: New file.
ce701a33
PE
4224 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4225 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4226 Depend on unexec.h.
4227 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4228 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4229 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4230 Change as necessary to match prototype in unexec.h.
ce701a33 4231
01f44d5a
PE
4232 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4233 shadowing.
4f63c6bb 4234 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4235
a6670b0b
PE
4236 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4237 Rename locals to avoid shadowing.
4238
cef2010d 4239 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4240 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4241
d4d7173a
PE
4242 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4243
f08b802a
PE
4244 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4245 warning when compiling print.c.
4246
3ddb0639
PE
4247 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4248 instead of using an uninitialized var.
5ad03b97 4249 (font_sort_entities): Mark var as initialized.
3ddb0639 4250
170a2692
PE
4251 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4252
e663c700
PE
4253 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4254 pointers to constants.
89bc529a 4255 (font_parse_fcname): Remove unused vars.
7b81e2d0 4256 (font_delete_unmatched): Now static.
ea838e10 4257 (font_get_spec): Remove; unused.
13a547c6
PE
4258 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4259 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4260 Rename or move locals to avoid shadowing.
e663c700 4261
2a80c887 4262 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4263 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4264
1384fa33 4265 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4266 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4267
8b2c52e9
PE
4268 * alloc.c (mark_backtrace): Move decl from here ...
4269 * lisp.h: ... to here, so that it can be checked.
4270
475545b5 4271 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4272 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4273 (lisp_indirect_variable): Name an expression,
4274 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4275 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4276
b1349114 4277 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4278 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4279 Use const pointer when appropriate.
b1349114 4280
a2928364
PE
4281 * lisp.h (get_system_name, get_operating_system_release):
4282 Move decls here, to check interfaces.
4283 * process.c (get_operating_system_release): Move decl to lisp.h.
4284 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4285 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4286 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4287 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4288 (Fformat_time_string, Fencode_time, Finsert_char):
4289 (Ftranslate_region_internal, Fformat):
4290 Rename or remove local vars to avoid shadowing.
9710023e 4291 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4292
a415e694
PE
4293 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4294 avoid shadowing.
4295
8ef4622d
PE
4296 * lisp.h (eassert): Check that the argument compiles, even if
4297 ENABLE_CHECKING is not defined.
4298
946f9a5b
PE
4299 * data.c (Findirect_variable): Name an expression, to avoid
4300 gcc -Wbad-function-cast warning.
112396d6 4301 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4302 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4303 (Fmake_variable_buffer_local, Fmake_local_variable):
4304 Mark variables as initialized.
52746918 4305 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4306
e5aab7e7 4307 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4308 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4309 Rename locals to avoid shadowing.
dff45157
PE
4310 (mark_stack): Move local variables into the #ifdef region where
4311 they're used.
7bc26fdb
PE
4312 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4313 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4314 needed otherwise.
4315 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4316 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4317 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4318
e5aab7e7
PE
4319 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4320 avoids undefined behavior in theory.
4321
4da60324
PE
4322 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4323
88043301
PE
4324 Use functions, not macros, for up- and down-casing (Bug#8254).
4325 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4326 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4327 to use the following functions instead of these macros.
4328 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4329 EMACS_INT, since callers assume the returned value fits in int.
4330 (upcase1): Likewise, for UPCASE_TABLE.
4331 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4332 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4333 the race-condition problem in the old DOWNCASE.
88043301 4334
19ed5445
PE
4335 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4336 Rename locals to avoid shadowing.
4337 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4338 (regex_compile, re_search_2, re_match_2_internal):
4339 Remove unused local vars.
952db0d7
PE
4340 (FREE_VAR): Rewrite so as not to use empty "else",
4341 which gcc can warn about.
da053e48 4342 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4343 (RETALLOC_IF): Define only if needed.
4344 (WORDCHAR_P): Likewise. This one is never needed, but is used
4345 only in a comment talking about a compiler bug, so put inside
4346 the #if 0 of that comment.
4347 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4348 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4349 Remove; unused.
19ed5445 4350
1f3561e4 4351 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4352 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4353 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4354
ded6f8f7
PE
4355 * search.c (simple_search): Remove unused var.
4356
dbd37a95
PE
4357 * dired.c (compile_pattern): Move decl from here ...
4358 * lisp.h: ... to here, so that it can be checked.
4359 (struct re_registers): New forward decl.
4360
7e47afad
PE
4361 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4362
85f24f61
PE
4363 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4364 All uses changed.
4365 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4366 Rename locals to avoid shadowing.
5671df8f 4367 (Fvertical_motion): Mark locals as initialized.
85f24f61 4368
181aa2be 4369 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4370 (casify_region): Mark local as initialized.
181aa2be 4371
930d429c
PE
4372 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4373
7082eac6
PE
4374 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4375 New macros, so that the caller can use some names other than
4376 gcpro1, gcpro2, etc.
4377 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4378 of the new macros.
4379 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4380 argument, for consistency with GCPRO2_VAR, etc: it is now the
4381 prefix of the variable, not the variable itself. All uses
4382 changed.
38b2c076
PE
4383 * dired.c (directory_files_internal, file_name_completion):
4384 Rename locals to avoid shadowing.
4385
15206ed9
PE
4386 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4387 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4388 dired.c's scmp function, had undefined behavior.
4389 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4390 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4391 * buffer.h: ... to here, because these macros use current_buffer,
4392 and the new implementation with inline functions needs to have
4393 current_buffer in scope now, rather than later when the macros
4394 are used.
4395 (downcase, upcase1): New static inline functions.
4396 (DOWNCASE, UPCASE1): Reimplement using these functions.
4397 This avoids undefined behavior in expressions like
4398 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4399 from race conditions in accessing the global variables
4400 case_temp1 and case_temp2.
4401 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4402 * lisp.h (case_temp1, case_temp2): Remove their decls.
4403 * character.h (ASCII_CHAR_P): Move from here ...
4404 * lisp.h: ... to here, so that the inline functions mentioned
4405 above can use them.
4406
4a6bea26
PE
4407 * dired.c (directory_files_internal_unwind): Now static.
4408
f14b7e14
PE
4409 * fileio.c (file_name_as_directory, directory_file_name):
4410 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4411 Now static.
2893f146
PE
4412 (file_name_as_directory): Use const pointers when appropriate.
4413 (Fexpand_file_name): Likewise. In particular, newdir might
4414 point at constant storage, so make it a const pointer.
fd4ead52 4415 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4416 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4417 signedness issues.
f839df0c
PE
4418 (Fset_file_times, Finsert_file_contents, auto_save_error):
4419 Rename locals to avoid shadowing.
f14b7e14 4420
5716756e 4421 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4422 (Ftry_completion, Fall_completions): Rename or remove locals
4423 to avoid shadowing.
5716756e 4424
b4c3046a
PE
4425 * marker.c (bytepos_to_charpos): Remove; unused.
4426
b45db522
PE
4427 * lisp.h (verify_bytepos, count_markers): New decls,
4428 so that gcc does not warn that these functions aren't declared.
4429
85876d07
PE
4430 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4431 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4432 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4433 (copy_text): Remove unused local var.
85876d07 4434
03d78a21 4435 * filelock.c (within_one_second): Now static.
b3dd38ab 4436 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4437
5df8f01b
PE
4438 * buffer.c (fix_overlays_before): Mark locals as initialized.
4439 (fix_start_end_in_overlays): Likewise. This function should be
4440 simplified by using pointers-to-pointers, but that's a different
4441 matter.
b1d876f1 4442 (switch_to_buffer_1): Now static.
8f54f30a
PE
4443 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4444 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4445
a70072c9 4446 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4447 Fix pointer signedness issue.
edced198
PE
4448 (sys_subshell): Mark local as volatile if checking for lint,
4449 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4450 (MAXPATHLEN): Define only if needed.
a70072c9 4451
a0977c44
PE
4452 * process.c (serial_open, serial_configure): Move decls from here ...
4453 * systty.h: ... to here, so that they can be checked.
4454
a884fdcc
PE
4455 * fns.c (get_random, seed_random): Move extern decls from here ...
4456 * lisp.h: ... to here, so that they can be checked.
4457
604efe86 4458 * sysdep.c (reset_io): Now static.
b8950c94 4459 (wait_for_termination_signal): Remove; unused.
604efe86 4460
38fc62d9
PE
4461 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4462 (copy_keymap_item, append_key, push_text_char_description):
4463 Now static.
1004a21a 4464 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4465 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4466 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4467 (describe_map_tree):
4468 Rename locals to avoid shadowing.
38fc62d9 4469
2f2650da
PE
4470 * keyboard.c: Declare functions static if they are not used elsewhere.
4471 (echo_char, echo_dash, cmd_error, top_level_2):
4472 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4473 (read_char, kbd_buffer_get_event, make_lispy_position):
4474 (make_lispy_event, make_lispy_movement, apply_modifiers):
4475 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4476 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4477 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4478 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4479 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4480
a053e86c 4481 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4482 (mark_kboards): Move decl here ...
4483 * alloc.c (mark_kboards): ... from here.
a053e86c 4484
4752793e
PE
4485 * lisp.h (force_auto_save_soon): New decl.
4486
74f10ca7 4487 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4488 (DEFINE_DUMMY_FUNCTION): New macro.
4489 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4490 Use it.
c03cd23f
PE
4491 (main): Add casts to avoid warnings
4492 if GCC considers string literals to be constants.
74f10ca7 4493
022e70d4
PE
4494 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4495
59d6fe83
PE
4496 * dbusbind.c: Pointer signedness fixes.
4497 (xd_signature, xd_append_arg, xd_initialize):
4498 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4499 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4500 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4501 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4502
78320123
PE
4503 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4504 if GCC considers string literals to be constants.
49cebcca 4505 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4506
35ac2a97
SM
45072011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4508
fb103ca9
SM
4509 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4510 (print_preprocess, print_object): New macro to fix last change.
4511
35ac2a97
SM
4512 * print.c (print_preprocess): Don't forget font objects.
4513
62973b41
JB
45142011-03-16 Juanma Barranquero <lekktu@gmail.com>
4515
4516 * emacs.c (USAGE3): Doc fixes.
4517
0e48bb22
AS
45182011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4519
4520 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4521 structure.
4522
7684e57b
JB
45232011-03-14 Juanma Barranquero <lekktu@gmail.com>
4524
4525 * lisp.h (VWindow_system, Qfile_name_history):
4526 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4527 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4528 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4529
4530 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4531 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4532
4533 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4534 * w32console.c (detect_input_pending, read_input_pending)
4535 (encode_terminal_code):
4536 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4537 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4538 (w32_system_caret_y, Qfile_name_history):
4539 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4540 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4541 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4542 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4543 * w32proc.c (Qlocal, report_file_error):
4544 * w32term.c (Vwindow_system, updating_frame):
4545 * w32uniscribe.c (initialized, uniscribe_font_driver):
4546 Remove unneeded extern declarations.
4547
2aa46d6c
CY
45482011-03-14 Chong Yidong <cyd@stupidchicken.com>
4549
c96bbc66 4550 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4551
cffc6f3b
CY
45522011-03-13 Chong Yidong <cyd@stupidchicken.com>
4553
4554 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4555 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4556 These macros can no longer be used for assignment.
4557
44f230aa
SM
4558 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4559 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4560 (record_buffer_markers, fetch_buffer_markers): New functions for
4561 recording and fetching special buffer markers.
4562 (set_buffer_internal_1, set_buffer_temp): Use them.
4563
4564 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4565
4566 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4567
4568 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4569 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4570
4571 * xdisp.c (hscroll_window_tree):
4572 (reconsider_clip_changes): Use PT instead of BUF_PT.
4573
d251f04b
EZ
45742011-03-13 Eli Zaretskii <eliz@gnu.org>
4575
4576 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4577 $(EMACS_ROOT)/lib/intprops.h.
4578
f0c77cd1
PE
45792011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4580
3eca4629
PE
4581 Fix more problems found by GCC 4.5.2's static checks.
4582
7c86ee98
PE
4583 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4584 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4585 (xg_free_frame_widgets): Make it clear that a local variable is
4586 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4587 (gdk_window_get_screen): Make it clear that this macro is needed
4588 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4589 (int_gtk_range_get_value): New function, which avoids a diagnostic
4590 from gcc -Wbad-function-cast.
4591 (xg_set_toolkit_scroll_bar_thumb): Use it.
4592 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4593 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4594 (get_utf8_string, xg_get_file_with_chooser):
4595 Rename locals to avoid shadowing.
4596 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4597
41729b81
PE
4598 * xgselect.c (xg_select): Remove unused var.
4599
f0c77cd1
PE
4600 * image.c (four_corners_best): Mark locals as initialized.
4601 (gif_load): Initialize transparent_p to zero (Bug#8238).
4602 Mark another local as initialized.
ec6cf4c6 4603 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4604
ce0ad53d 4605 * image.c (clear_image_cache): Now static.
d5d5a617 4606 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4607 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4608 (x_edge_detection): Remove unnecessary cast that
4609 gcc -Wbad-function-cast diagnoses.
2037898d 4610 (gif_load): Fix pointer signedness.
6ae141d6
PE
4611 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4612 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4613
33383987 46142011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4615
d32df629
PE
4616 Improve quality of tests for time stamp overflow.
4617 For example, without this patch (encode-time 0 0 0 1 1
4618 1152921504606846976) returns the obviously-bogus value (-948597
4619 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4620 reports time overflow. See
4621 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4622 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4623 * editfns.c: Include limits.h and intprops.h.
4624 (TIME_T_MIN, TIME_T_MAX): New macros.
4625 (time_overflow): Move earlier, to before first use.
4626 (hi_time, lo_time): New functions, for an accurate test for
4627 out-of-range times.
4628 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4629 (Fget_internal_run_time): Don't assume time_t fits in int.
4630 (make_time): Use list2 instead of Fcons twice.
4631 (Fdecode_time): More accurate test for out-of-range times.
4632 (check_tm_member): New function.
4633 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4634 (lisp_time_argument): Don't rely on undefined left-shift and
4635 right-shift behavior when checking for time stamp overflow.
8be6f318 4636
fe31d94c
PE
4637 * editfns.c (time_overflow): New function, refactoring common code.
4638 (Fformat_time_string, Fdecode_time, Fencode_time):
4639 (Fcurrent_time_string): Use it.
4640
8be6f318
PE
4641 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4642 * dired.c (make_time): Move to ...
4643 * editfns.c (make_time): ... here.
4644 * systime.h: Note the move.
4645
09d9db2c 46462011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4647
126bc0dc
YM
4648 * fringe.c (update_window_fringes): Remove unused variables.
4649
c47cbdfd
YM
4650 * unexmacosx.c (copy_data_segment): Also copy __got section.
4651 (Bug#8223)
4652
7ac80be9
EZ
46532011-03-12 Eli Zaretskii <eliz@gnu.org>
4654
c96bbc66 4655 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4656 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4657 Constify `char *' arguments and their references according to
4658 prototypes in tparam.h.
4659
ecb0f94d 4660 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4661
7ac80be9
EZ
4662 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4663 Adapt all references accordingly.
4664
4665 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4666
ef1fd07e
TT
46672011-03-11 Tom Tromey <tromey@redhat.com>
4668
4669 * buffer.c (syms_of_buffer): Remove obsolete comment.
4670
7ef4b50c
EZ
46712011-03-11 Eli Zaretskii <eliz@gnu.org>
4672
4673 * termhooks.h (encode_terminal_code): Declare prototype.
4674
4675 * msdos.c (encode_terminal_code): Don't declare prototype.
4676
4677 * term.c (encode_terminal_code): Now external again, used by
4678 w32console.c and msdos.c.
4679
44f230aa
SM
4680 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4681 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4682
4b1ec863 46832011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4684
1714f52b 4685 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4686
4b1ec863
PE
4687 * fringe.c (update_window_fringes): Mark locals as initialized
4688 (Bug#8227).
4689 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4690
524c7aa6
PE
4691 * alloc.c (mark_fringe_data): Move decl from here ...
4692 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4693 to check its interface.
4694 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4695
a5c0af81 4696 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4697 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4698 (fontset_font): Mark local as initialized.
a9a06e0b 4699 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4700
b4716021
PE
4701 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4702
811e9bac 4703 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4704 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4705 (x_own_selection, Fx_disown_selection_internal): Rename locals
4706 to avoid shadowing.
4707 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4708
7e3ab302
PE
4709 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4710 so that the caller can use some name other than gcpro1.
4711 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4712 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4713 (Fx_backspace_delete_keys_p):
4714 Use them to avoid shadowing, and rename vars to avoid shadowing.
4715 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4716 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4717 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4718 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4719 Remove unused locals.
7e3ab302
PE
4720 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4721 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4722 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4723 macros.
f78faa98 4724
e2b13473
PE
4725 * xterm.h (x_mouse_leave): New decl.
4726
77f23912
PE
4727 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4728 Remove unused functions.
cdf4ba58
PE
4729 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4730 (x_calc_absolute_position): Now static.
7411c686 4731 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4732 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4733 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4734 unless they are used.
38d0b34a
PE
4735 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4736 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4737 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4738 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4739 (x_error_catcher, x_connection_closed, x_error_handler):
4740 (x_error_quitter, xembed_send_message, x_iconify_frame):
4741 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4742 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4743 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4744
44f230aa
SM
4745 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4746 Rename or move locals to avoid shadowing.
6b463e58 4747 (tty_defined_color, merge_face_heights): Now static.
5967d051 4748 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4749 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4750 does not deduce is never used uninitialized.
73719eba
PE
4751 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4752 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4753
426994c3 4754 * terminal.c (store_terminal_param): Now static.
5489860b 4755
032f1620 4756 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4757 (set_frame_menubar): Remove unused local.
d4323972 4758 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4759 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4760 since they might point to immutable storage.
281585b0
PE
4761 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4762 since it's unused otherwise.
032f1620 4763
367c19e5 4764 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4765 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4766 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4767 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4768 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4769 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4770 does not deduce are never used uninitialized.
70739cbe 4771
07b48fa9
PE
4772 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4773
8868a238 4774 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4775 * window.c (window_loop, size_window):
4776 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4777
7e5cf297 4778 * window.c (display_buffer): Now static.
d6550a9f
PE
4779 (size_window): Mark variables that gcc -Wuninitialized
4780 does not deduce are never used uninitialized.
a586633d
PE
4781 * window.h (check_all_windows): New decl, to forestall
4782 gcc -Wmissing-prototypes diagnostic.
5b555da1 4783 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4784
f6095868
PE
4785 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4786 shadowing.
4787 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4788 Include <limits.h>.
4789 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4790 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4791 (load_charset_map): Mark variables that gcc -Wuninitialized
4792 does not deduce are never used uninitialized.
53df7c11 4793 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4794
f38b440c
PE
4795 * coding.c (coding_set_source, coding_set_destination):
4796 Use "else { /* comment */ }" rather than "else /* comment */;"
4797 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4798 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4799 a block, when the outer 'i' will do.
4800 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4801 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4802 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4803 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4804 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4805 Rename locals to avoid shadowing.
4806 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4807 * coding.c (emacs_mule_char, encode_invocation_designation):
4808 Now static, since they're not used elsewhere.
413bb2db 4809 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4810 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4811 (decode_coding_emacs_mule): Mark variables that gcc
4812 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4813 (detect_coding_iso_2022): Initialize a local variable that might
4814 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4815 this initialization is needed. (Bug#8211)
5f58e762
PE
4816 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4817 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4818 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4819 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4820 Remove unused macros.
f38b440c 4821
232b38b9 4822 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4823 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4824 * character.c (string_count_byte8): Likewise.
232b38b9 4825
fb90da1b
PE
4826 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4827 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4828
fb93dbc2
PE
4829 * chartab.c (copy_sub_char_table): Now static, since it's not used
4830 elsewhere.
5c156ace
PE
4831 (sub_char_table_ref_and_range, char_table_ref_and_range):
4832 Rename locals to avoid shadowing.
bbcd0949 4833 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4834
7d3b3862 4835 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4836 (BIDI_BOB): Remove unused macro.
7d3b3862 4837
6be7d3da
PE
4838 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4839 deduce are never used uninitialized.
c2ed9c8b 4840 * term.c (encode_terminal_code): Likewise.
6be7d3da 4841
75f8807f 4842 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4843
50938595
PE
4844 * tparam.h: New file.
4845 * term.c, tparam.h: Include it.
4846 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4847 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4848 Move these decls to tparam.h, and make them agree with what
4849 is actually in tparam.c. The previous trick of using incompatible
4850 decls in different modules does not conform to the C standard.
4851 All callers of tparam changed to use tparam's actual API.
4852 * tparam.c (tparam1, tparam, tgoto):
4853 Use const pointers where appropriate.
4854
fbceeba2
PE
4855 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4856 * cm.h (struct cm): Likewise.
4857 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4858 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4859 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4860 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4861 (turn_on_face, init_tty): Likewise.
4862 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4863
7f3f1250
PE
4864 * term.c (term_mouse_position): Rename local to avoid shadowing.
4865
e6ca6543
PE
4866 * alloc.c (mark_ttys): Move decl from here ...
4867 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4868
c40f8d15
AS
48692011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4870
4871 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4872
cfe0661d
JB
48732011-03-09 Juanma Barranquero <lekktu@gmail.com>
4874
4875 * search.c (compile_pattern_1): Remove argument regp, unused since
4876 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4877 (compile_pattern): Don't pass it.
4878
0afb4571
J
48792011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4880
4881 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4882 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4883 for ! HAVE_GTK3.
4884 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4885
4886 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4887
4888 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4889 gdk_window_get_screen, gdk_window_get_geometry,
4890 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4891 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4892 (xg_get_pixbuf_from_pixmap): New function.
4893 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4894 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4895 Call xg_get_pixbuf_from_pixmap instead of
4896 gdk_pixbuf_get_from_drawable.
4897 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4898 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4899 (xg_check_special_colors): Use GtkStyleContext and its functions
4900 for HAVE_GTK3.
4901 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4902 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4903 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4904 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4905 Call gtk_widget_get_preferred_size.
0afb4571
J
4906 (xg_frame_resized): gdk_window_get_geometry only takes 5
4907 parameters.
44f230aa
SM
4908 (xg_win_to_widget, xg_event_is_for_menubar):
4909 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4910 (xg_set_widget_bg): New function.
4911 (delete_cb): New function.
895009e1 4912 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4913 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4914 (xg_set_background_color): Call xg_set_widget_bg.
4915 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4916 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4917 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4918 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4919 if ! HAVE_GTK3.
4920 (update_frame_tool_bar): Call gtk_widget_hide.
4921 (xg_initialize): Use GDK_KEY_g.
4922
4923 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4924 if ! HAVE_GTK3
4925 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4926
4927 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4928 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4929 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4930
1c2cc4ef
JB
49312011-03-08 Juanma Barranquero <lekktu@gmail.com>
4932
4933 * w32xfns.c (select_palette): Check success of RealizePalette against
4934 GDI_ERROR, not zero.
4935
33383987 4936See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4937
4938;; Local Variables:
4939;; coding: utf-8
aac0c6e3
MR
4940;; End:
4941
33383987 4942 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4943
4944 This file is part of GNU Emacs.
4945
4946 GNU Emacs is free software: you can redistribute it and/or modify
4947 it under the terms of the GNU General Public License as published by
4948 the Free Software Foundation, either version 3 of the License, or
4949 (at your option) any later version.
4950
4951 GNU Emacs is distributed in the hope that it will be useful,
4952 but WITHOUT ANY WARRANTY; without even the implied warranty of
4953 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4954 GNU General Public License for more details.
4955
4956 You should have received a copy of the GNU General Public License
4957 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.