merge trunk
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5eb05ea3
KH
12011-12-05 Kenichi Handa <handa@m17n.org>
2
3 * coding.c (encode_designation_at_bol): New args charbuf_end and
4 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5 (coding_set_source): Return how many bytes coding->source was
6 relocated.
7 (coding_set_destination): Return how many bytes
8 coding->destination was relocated.
9 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
10 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
11
122011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
13
14 * coding.c (CODING_CHAR_CHARSET_P): New macro.
15 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
16 macro (Bug#9318).
17
182011-12-05 Andreas Schwab <schwab@linux-m68k.org>
19
20 The following changes are to fix Bug#9318.
21
a79703f5 22 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
23 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
24 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 25 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 26
7dbda6df
JB
272011-12-05 Juanma Barranquero <lekktu@gmail.com>
28
29 * lisp.h (process_quit_flag): Fix external declaration.
30
6d5eb5b0
SM
312011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
32
33 Don't macro-inline non-performance-critical code.
34 * eval.c (process_quit_flag): New function.
35 * lisp.h (QUIT): Use it.
36
a0c3fad0
JD
372011-12-04 Jan Djärv <jan.h.d@swipnet.se>
38
39 * nsfns.m (get_geometry_from_preferences): New function.
40 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
41
6c07aac2
AS
422011-12-04 Andreas Schwab <schwab@linux-m68k.org>
43
44 * emacs.c (Qkill_emacs): Define.
45 (syms_of_emacs): Initialize it.
46 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
47 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
48 (quit_throw_to_read_char): Add parameter `from_signal'.
49 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
50 * lisp.h (QUIT): Call Fkill_emacs if requested.
51
c052ead4
JD
522011-12-03 Jan Djärv <jan.h.d@swipnet.se>
53
54 * widget.c (update_wm_hints): Return if wmshell is null.
55 (widget_update_wm_size_hints): New function.
56
57 * widget.h (widget_update_wm_size_hints): Declare.
58
59 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
60 widget_update_wm_size_hints (Bug#10104).
61
9e49252b
EZ
622011-12-03 Eli Zaretskii <eliz@gnu.org>
63
64 * xdisp.c (handle_invisible_prop): If the invisible text ends just
65 before a newline, prepare the bidi iterator for consuming the
66 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 67 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 68
02b16839
JL
692011-12-02 Juri Linkov <juri@jurta.org>
70
71 * search.c (Fword_search_regexp): New Lisp function created from
72 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
73 (Fword_search_backward, Fword_search_forward)
74 (Fword_search_backward_lax, Fword_search_forward_lax):
75 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
76 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
77
0068070e
SM
782011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
79
80 * fileio.c (Finsert_file_contents): Move after-change-function call
81 to before the "handled:" label, since all "goto handled" appear in
82 cases where the *-change-functions have already been properly called
83 (bug#10117).
84
3360a3fc
AS
852011-12-01 Andreas Schwab <schwab@linux-m68k.org>
86
87 * keyboard.c (interrupt_signal): Don't call kill-emacs when
88 waiting for input. (Bug#10169)
89
73d6c093
EZ
902011-11-30 Eli Zaretskii <eliz@gnu.org>
91
92 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
93 verifies glyph row's hash code--we have just reallocated the
94 glyphs, so their contents can be complete garbage. (Bug#10164)
95
febe6bea
JB
962011-11-30 Juanma Barranquero <lekktu@gmail.com>
97
98 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
99
801a4313
EZ
1002011-11-30 Eli Zaretskii <eliz@gnu.org>
101
102 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
103 attributes are tested _before_ calling verify_row_hash, to protect
104 against GCC re-ordering of the tests. (Bug#10164)
105
2b56b87e
JD
1062011-11-29 Jan Djärv <jan.h.d@swipnet.se>
107
108 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
109
110 * xterm.c (handle_one_xevent): Only set async_visible and friends
111 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 112 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
113 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
114
dbf31225
PE
1152011-11-28 Paul Eggert <eggert@cs.ucla.edu>
116
117 Remove GCPRO-related macros that exist only to avoid shadowing locals.
118 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
119 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
120 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
121 All uses changed to use GCPRO1 etc.
122 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
123 Revert to old implementation (i.e., before 2011-03-11).
124
1305621b
YM
1252011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
126
127 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
128 of scroll runs so as to avoid assigning disabled bogus rows and
129 unnecessary graphics copy operations.
130
8c9afb46
EZ
1312011-11-27 Eli Zaretskii <eliz@gnu.org>
132
133 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
134 (snprintf) [_MSC_VER]: Redirect to _snprintf.
135 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
136 (malloc, free, realloc, calloc): Redirect to e_* only when
137 compiling Emacs.
138
139 * lisp.h (GCTYPEBITS): Move before first use.
140 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
141 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
142 this macro definition.
143
144 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
145 _MSC_VER.
146
54e9e3bf
JD
1472011-11-27 Jan Djärv <jan.h.d@swipnet.se>
148
6d5eb5b0
SM
149 * gtkutil.c (xg_create_frame_widgets):
150 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
151 present with Gtk+ 2.0.
152
83aca1cb
PE
1532011-11-26 Paul Eggert <eggert@cs.ucla.edu>
154
155 * fileio.c (Finsert_file_contents): Undo previous change; see
156 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
157
5b76caa4
PE
1582011-11-26 Paul Eggert <eggert@cs.ucla.edu>
159
160 Rename locals to avoid shadowing.
161 * fileio.c (Finsert_file_contents):
162 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
163 * process.c (wait_reading_process_output):
164 Rename inner 'proc' to 'p' to avoid shadowing.
165 Indent for consistency with usual Emacs style.
166
8c535114
EZ
1672011-11-25 Eli Zaretskii <eliz@gnu.org>
168
169 * xdisp.c (redisplay_window): If cursor row is not fully visible
170 after recentering, and scroll-conservatively is set to a large
171 number, scroll window by a few more lines to make the cursor fully
172 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
173 (start_display): Don't move to the next line if the display should
174 start at a newline that is part of a display vector or an overlay
175 string. (Bug#10119)
8c535114 176
fa4fdb5c
JL
1772011-11-24 Juri Linkov <juri@jurta.org>
178
179 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
180 after the `MagickPingImage' call. (Bug#10112)
181
90ec88df
CY
1822011-11-23 Chong Yidong <cyd@gnu.org>
183
184 * window.c (Fcoordinates_in_window_p): Accept only live windows.
185
56e2e794
MR
1862011-11-23 Martin Rudalics <rudalics@gmx.at>
187
188 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
189 making another buffer current. (Bug#10114)
190
b6e64c41
GM
1912011-11-23 Glenn Morris <rgm@gnu.org>
192
193 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
194
6b21de18
CY
1952011-11-23 Chong Yidong <cyd@gnu.org>
196
197 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
198 using it (Bug#5984).
199
b12cd789
EZ
2002011-11-22 Eli Zaretskii <eliz@gnu.org>
201
202 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
203 and header-lines, as they don't have one computed for them.
204 (Bug#10098)
205
206 * .gdbinit (prow): Make displayed values more self-explaining.
207 Add row's hash code.
208
261b6fd4
LMI
2092011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
210
211 * process.c (wait_reading_process_output): Fix asynchrounous
212 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 213 (wait_reading_process_output): Add comment and URL.
261b6fd4 214
e7cfd277
JD
2152011-11-21 Jan Djärv <jan.h.d@swipnet.se>
216
217 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
218
a9b9b7f5
CY
2192011-11-21 Chong Yidong <cyd@gnu.org>
220
221 * window.c (Fnext_window, Fprevious_window): Doc fix.
222
b0d15b4f
SM
2232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
224
225 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
226
fe7a3057
JB
2272011-11-20 Juanma Barranquero <lekktu@gmail.com>
228
229 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
230
d2999b1a
MR
2312011-11-20 Martin Rudalics <rudalics@gmx.at>
232
233 * window.c (Fset_window_combination_limit): Rename argument
234 STATUS to LIMIT.
235 (Vwindow_combination_limit): Remove "status" from doc-string.
236
d5ff9cd0
AS
2372011-11-20 Andreas Schwab <schwab@linux-m68k.org>
238
239 * m/ibms390.h: Remove.
240 * m/ibms390x.h: Don't include "ibms390.h".
241
a5bb9bd3
SM
2422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
243
244 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
245 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
246
cd1181db
JB
2472011-11-20 Juanma Barranquero <lekktu@gmail.com>
248
249 * casetab.c (Fset_case_table):
250 * charset.c (Fcharset_after): Fix typos.
251
615a3b8d 2522011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 253
17e845af
PE
254 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
255 Otherwise, valgrind does not work on some platforms.
256 Problem reported by Andreas Schwab in
6a0bf43d
PE
257 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
258 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
259 is set, removing the need for VIRT_ADDRESS_VARIES.
260 (PURE_P): Use a more-efficient implementation that needs just one
261 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
262 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
263 to 4 (xorl, subq, cmpq, setbe).
264 * alloc.c (pure): Always extern now, since that's the
265 VIRT_ADDR_VARIES behavior.
266 (PURE_POINTER_P): Use a single comparison, not two, for
267 consistency with the new puresize.h.
268 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
269 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
270 Remove VIRT_ADDR_VARIES no longer needed.
271
f8fe6f96
EZ
2722011-11-19 Eli Zaretskii <eliz@gnu.org>
273
274 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
275 (erase_phys_cursor, update_window_cursor, show_mouse_face)
276 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
277 behave as if the cursor position were at the window margin.
278
279 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
280 and the cursor position is out of bounds, behave as if the cursor
281 position were at the window margin. (Bug#10075)
282
df05a53c
CY
2832011-11-18 Chong Yidong <cyd@gnu.org>
284
285 * window.c (Fwindow_combination_limit): Make first argument
286 non-optional, since it is meaningless for live windows like the
287 selected window.
288
2071918e
DA
2892011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
290
291 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
292
b50a28de
SM
2932011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
294
295 * intervals.c: Fix grafting over the whole buffer (bug#10071).
296 (graft_intervals_into_buffer): Simplify.
297
015137db
EZ
2982011-11-18 Eli Zaretskii <eliz@gnu.org>
299
300 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
301 hash values of the two rows.
302 (copy_row_except_pointers): Preserve the used[] arrays and the
303 hash values of the two rows. (Bug#10035)
68c95424 304 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
305
306 * xdisp.c (row_hash): New function, body extracted from
307 compute_line_metrics.
308 (compute_line_metrics): Call row_hash, instead of computing the
309 hash code inline.
310
311 * dispnew.c (verify_row_hash): Call row_hash for computing the
312 hash code of a row, instead of duplicating code from xdisp.c.
313
314 * dispextern.h (row_hash): Add prototype.
315
a2addb04
TH
3162011-11-18 Tassilo Horn <tassilo@member.fsf.org>
317
318 * frame.c (delete_frame): Don't delete the terminal when the last
319 X frame is closed if emacs is built with GTK toolkit.
320
df85d315
JB
3212011-11-17 Juanma Barranquero <lekktu@gmail.com>
322
323 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
324
a0c2d0ae
MR
3252011-11-17 Martin Rudalics <rudalics@gmx.at>
326
327 * window.c (Vwindow_splits): Rename to
328 Vwindow_combination_resize. Suggested by Juri Linkov.
329 (Fsplit_window_internal): Use Vwindow_combination_resize instead
330 of Vwindow_splits.
331
58179cce
JB
3322011-11-16 Juanma Barranquero <lekktu@gmail.com>
333
7877f373
JB
334 * nsfns.m (Fns_font_name):
335 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 336
b6f67890
MR
3372011-11-16 Martin Rudalics <rudalics@gmx.at>
338
339 * window.h (window): Rename slot "nest" to "combination_limit".
340 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
341 (Fset_window_nest): Rename to Fset_window_combination_limit.
342 (Vwindow_nest): Rename to Vwindow_combination_limit.
343 (recombine_windows, make_parent_window, make_window)
344 (Fsplit_window_internal, saved_window)
345 (Fset_window_configuration, save_window_save): Rename all
346 occurrences of window_nest to window_combination_limit.
347
c7015153
JB
3482011-11-15 Juanma Barranquero <lekktu@gmail.com>
349
350 * image.c (imagemagick_load_image): Fix typo.
351
322ad6ec
EZ
3522011-11-14 Eli Zaretskii <eliz@gnu.org>
353
354 * xdisp.c (display_line): Move the call to
355 highlight_trailing_whitespace before the call to
356 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
357 faces of all the glyphs to compute ROW's hash value.
358 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 359
f067b8ec
JB
3602011-11-14 Juanma Barranquero <lekktu@gmail.com>
361
362 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
363 just return (bug#10044).
364
1e5b2111
EZ
3652011-11-12 Eli Zaretskii <eliz@gnu.org>
366
7ef3cbd5
EZ
367 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
368 with user-defined heap size. Bump the default size of the temacs
369 heap to 27MB, to avoid memory warning when running temacs.
370 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
371
1e5b2111
EZ
372 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
373 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
374 (verify_row_hash) [XASSERTS]: New function.
375 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
376 that the hash value of glyph rows is correct.
1e5b2111 377
89d61221
MR
3782011-11-12 Martin Rudalics <rudalics@gmx.at>
379
380 * window.h (window): Remove splits slot.
381 * window.c (Fwindow_splits, Fset_window_splits): Remove.
382 (Fdelete_other_windows_internal, make_parent_window)
383 (make_window, Fsplit_window_internal, Fdelete_window_internal)
384 (Fset_window_configuration, save_window_save): Don't deal with
385 split status of windows.
386 (saved_window): Remove splits slot.
387 (Vwindow_splits): Rewrite doc-string.
388
97f18cc8
JD
3892011-11-11 Jan Djärv <jan.h.d@swipnet.se>
390
391 * xfns.c (unwind_create_frame):
392 * nsfns.m (unwind_create_frame):
393 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
394 Vframe_list (Bug#9999).
395
22a648b4
DA
3962011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
397
0b381c7e 398 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 399
659afede
KH
4002011-11-11 Kenichi Handa <handa@m17n.org>
401
402 * callproc.c (Fcall_process): Set the member dst_multibyte of
403 process_coding.
404
9ac0394b
KH
4052011-11-11 Johan Bockgård <bojohan@gnu.org>
406
407 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
408 avoid a crash (bug#9496).
409
2fbdc249
CY
4102011-11-09 Chong Yidong <cyd@gnu.org>
411
412 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
413 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
414
ac6b1f81
PE
4152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
416
417 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
418
09db192c
PE
4192011-11-08 Paul Eggert <eggert@cs.ucla.edu>
420
421 Avoid some portability problems by eschewing 'extern inline' functions.
422 The trivial performance wins aren't worth the portability hassles; see
423 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
424 et seq.
425 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
426 (window_box_width, window_box_left, window_box_left_offset)
427 (window_box_right, window_box_right_offset): Undo previous change,
428 by removing the "extern"s.
429 * intervals.c (adjust_intervals_for_insertion)
430 (adjust_intervals_for_deletion): Undo previous change,
431 making these static again.
432 (offset_intervals, temp_set_point_both, temp_set_point)
433 (copy_intervals_to_string): No longer inline.
434 * xdisp.c (window_text_bottom_y, window_box_width)
435 (window_box_height, window_box_left_offset)
436 (window_box_right_offset, window_box_left, window_box_right)
437 (window_box): No longer inline.
438
105216ed
CY
4392011-11-08 Chong Yidong <cyd@gnu.org>
440
441 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
442 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
443 Signal an error if not a live window.
105216ed
CY
444 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
445 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
446
ae9e237f
JB
4472011-11-07 Juanma Barranquero <lekktu@gmail.com>
448
449 * lisp.h (syms_of_abbrev): Remove declaration.
450 Reported by CHENG Gao <chenggao@royau.me>.
451
c7aa8333
EZ
4522011-11-07 Eli Zaretskii <eliz@gnu.org>
453
454 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
455 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
456 of temacs in GUI mode.
457
be7f5545
MR
4582011-11-07 Martin Rudalics <rudalics@gmx.at>
459
460 * window.h: Declare delete_all_child_windows instead of
461 delete_all_subwindows.
462 * window.c (Fwindow_nest, Fset_window_nest)
463 (Fset_window_new_total, Fset_window_new_normal)
464 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
465 (delete_all_subwindows): Rename to delete_all_child_windows.
466 (Fdelete_other_windows_internal, Fset_window_configuration):
467 Call delete_all_child_windows instead of delete_all_subwindows.
468 * frame.c (delete_frame): Call delete_all_child_windows instead
469 of delete_all_subwindows.
470
ca78dc43
PE
4712011-11-07 Paul Eggert <eggert@cs.ucla.edu>
472
473 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
474 This is also needed for porting to any host where GC_MARK_STACK is
475 not GC_MAKE_GCPROS_NOOPS.
476 (which_symbols): Use it.
477
a0241d01
KH
4782011-11-07 Kenichi Handa <handa@m17n.org>
479
480 * coding.c (coding_set_destination): Check coding->src_pos only
481 when coding->src_object is a buffer (bug#9910).
482
483 * process.c (send_process): Set the member src_multibyte of coding
484 to 0 (bug#9911) when sending a unibyte text.
485
486 * callproc.c (Fcall_process): Set the member src_multibyte of
487 process_coding to 0 (bug#9912).
488
a64bfdfa 4892011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
490
491 * xmenu.c (cleanup_widget_value_tree): New function.
492 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
493 calling free_menubar_widget_value_tree directly (Bug#9830).
494
cb41b32a
PE
4952011-11-06 Paul Eggert <eggert@cs.ucla.edu>
496
497 Fix some portability problems with 'inline'.
498 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
499 (window_box_width, window_box_left, window_box_left_offset)
500 (window_box_right, window_box_right_offset): Declare extern.
501 Otherwise, these inline functions do not conform to C99 and
502 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
503 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
504 * intervals.c (adjust_intervals_for_insertion)
505 (adjust_intervals_for_deletion): Now extern, because otherwise the
506 extern inline functions 'offset_intervals' couldn't refer to it.
507 (static_offset_intervals): Remove.
508 (offset_intervals): Rewrite using the old contents of
509 static_offset_intervals. The old version didn't conform to C99
510 because an extern inline function contained a reference to an
511 identifier with static linkage.
512
b7041366
AS
5132011-11-06 Andreas Schwab <schwab@linux-m68k.org>
514
515 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
516 GC.
517
88a37c4d
EZ
5182011-11-06 Eli Zaretskii <eliz@gnu.org>
519
520 * xdisp.c (init_iterator, reseat_to_string): Don't set the
521 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
522 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
523 return Qleft_to_right.
524
49745b39
CY
5252011-11-06 Chong Yidong <cyd@gnu.org>
526
527 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
528 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
529 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
530 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
531 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
532 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
533 (Fwindow_vscroll): Doc fix.
534 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
535 argument, since it makes no sense to pass a live window and for
536 consistency with window-child.
537
1f05cd82
CS
5382011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
539
540 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
541 support MSVC.
542
22610910
JR
5432011-11-05 Jason Rumney <jasonr@gnu.org>
544
545 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
546 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
547 fonts (Bug#6029).
548 (add_font_entity_to_list): Fix logic errors in mixed boolean and
549 bitwise arithmetic preventing use of unicode-sip and non-truetype
550 opentype fonts.
551
a06776b2
EZ
5522011-11-05 Eli Zaretskii <eliz@gnu.org>
553
3ad924ba
EZ
554 * s/ms-w32.h (fstat, stat, utime): Move redirections to
555 "emacs"-only part.
556
a06776b2
EZ
557 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
558 initialization code to keep similarity to xfns.c after changes
559 from 2011-11-05.
560
c9e7db78
JD
5612011-11-05 Jan Djärv <jan.h.d@swipnet.se>
562
a97f8f3f
JD
563 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
564 (unwind_create_frame): New function (Bug#9943).
565 (Fx_create_frame): Restructure code to be more similar to the one in
566 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
567 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
568 Move terminal->reference_count++ just before making the frame official
569 (Bug#9943).
570
571 * nsterm.m (x_free_frame_resources): New function.
572 (x_destroy_window): Move code to x_free_frame_resources.
573
c9e7db78 574 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
575 (Fx_create_frame, x_create_tip_frame):
576 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
577 official. Move initialization of image_cache_refcount and
578 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
579
a6fc3b5c
EZ
5802011-11-05 Eli Zaretskii <eliz@gnu.org>
581
582 Support MSVC build with newer versions of Visual Studio.
583 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
584 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
585 nt/gmake.defs.
586
587 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
588 which are not supported by MSVC.
589 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
590 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
591 bitfields.
592 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
593 types in bitfields.
594 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
595
596 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
597
58179cce 5982011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
599
600 Support MSVC build with newer versions of Visual Studio.
601 * w32.c: Don't include w32api.h for MSVC.
602 (init_environment) [_MSC_VER]: Call sys_access, not _access.
603
604 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
605 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
606 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
607 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
608 e_* cousins.
609 (alloca) [_MSC_VER]: Define to _alloca.
610
611 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
612
613 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
614
a58c13ed
EZ
6152011-11-04 Eli Zaretskii <eliz@gnu.org>
616
617 * xdisp.c (note_mouse_highlight): If either of
618 previous/next-single-property-change returns nil, treat that as
619 the beginning or the end of the buffer. (Bug#9955)
620
fe0b6370
JD
6212011-11-04 Jan Djärv <jan.h.d@swipnet.se>
622
a58c13ed 623 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
624 label is not null (Bug#9951).
625 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
626 may be NULL.
627
89bd5ee1
EZ
6282011-11-04 Eli Zaretskii <eliz@gnu.org>
629
630 * window.c (Fwindow_body_size): Mention in the doc string that the
631 return value is in frame's canonical units. (Bug#9949)
632
84c3edb9
EZ
6332011-11-03 Eli Zaretskii <eliz@gnu.org>
634
4e2fb5c7
EZ
635 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
636
84c3edb9 637 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 638 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 639 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 640
bc17a887
EZ
6412011-11-01 Eli Zaretskii <eliz@gnu.org>
642
643 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
644 Don't stop backward scan on the continuation glyph, even though
645 its CHARPOS is positive.
6d5eb5b0
SM
646 (mouse_face_from_buffer_pos, note_mouse_highlight):
647 Rename cover_string to disp_string.
bc17a887 648
4ee88440
MR
6492011-11-01 Martin Rudalics <rudalics@gmx.at>
650
651 * window.c (temp_output_buffer_show): Don't use
652 Vtemp_buffer_show_specifiers.
653 (Vtemp_buffer_show_specifiers): Remove unused variable.
654
c2ff3c02
EZ
6552011-10-30 Eli Zaretskii <eliz@gnu.org>
656
657 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
658 past the beginning of the current glyph matrix.
659
58179cce 6602011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
661
662 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
663 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
664 HAVE_GTK3 (Bug#9869).
b77a6a7f 665
3b574623
JD
666 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
667 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
668
b77a6a7f
JD
669 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
670
671 * xterm.c: Declare x_handle_net_wm_state to return int.
672 (handle_one_xevent): Check if we are iconified but don't have
673 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
674 (get_current_wm_state): Return non-zero if not hidden,
675 check for _NET_WM_STATE_HIDDEN (Bug#9893).
676 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
677 (x_handle_net_wm_state): Return what get_current_wm_state returns.
678 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
679
196e41e4
PE
6802011-10-29 Paul Eggert <eggert@cs.ucla.edu>
681
682 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
683 so that this new function doesn't get optimized away by a
684 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
685
021f2e1a
AS
6862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
687
688 * frame.h (MOUSE_HL_INFO): Remove excess parens.
689
8b058d44
EZ
6902011-10-29 Eli Zaretskii <eliz@gnu.org>
691
692 Fix the `xbytecode' command.
693 * .gdbinit (xprintbytestr): New command.
b50a28de 694 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
695 (xbytecode): Print the byte-code string as well.
696
4452fb80
EZ
6972011-10-29 Kim Storm <storm@cua.dk>
698
8b058d44
EZ
699 * alloc.c (which_symbols): New function.
700
21b72067
AS
7012011-10-29 Andreas Schwab <schwab@linux-m68k.org>
702
703 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
704 line. (Bug#9903)
705
83ed7b5c
GM
7062011-10-29 Glenn Morris <rgm@gnu.org>
707
708 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
709 Not clear what it was for, and it causes various bugs. (Bug#9839)
710
5a7a728b
EZ
7112011-10-28 Eli Zaretskii <eliz@gnu.org>
712
713 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
714 possible random value that matches one of those tested as
715 condition to clear the mouse face.
716
d3d0842f
CY
7172011-10-28 Chong Yidong <cyd@gnu.org>
718
719 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
720
31b39d13
DN
7212011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
722
723 * window.c (make_window): Initialize phys_cursor_on_p.
724
9aba6043
SM
7252011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
726
727 * lisp.h (struct Lisp_Symbol): Update comments.
728
c20992f4
JB
7292011-10-28 Juanma Barranquero <lekktu@gmail.com>
730
731 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
732
db4f02f2
EZ
7332011-10-28 Eli Zaretskii <eliz@gnu.org>
734
735 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
736 <oslsachem@gmail.com> for helping to debug this.
737
738 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
739 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
740 (g_b_init_get_glyph_outline_w): New static variables.
741 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
742 (GetGlyphOutlineW_Proc): New typedefs.
743 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
744 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
745 New functions.
746 (w32font_open_internal, compute_metrics):
747 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
748 instead of calling the "wide" APIs directly.
749
750 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
751
752 * w32.h (syms_of_w32font): Add prototype.
753
87e68db4
JB
7542011-10-27 Juanma Barranquero <lekktu@gmail.com>
755
756 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
757 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
758 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
759 (Fmove_to_window_line): Doc fix.
760
435c1d67
CY
7612011-10-27 Chong Yidong <cyd@gnu.org>
762
763 * process.c (make_process): Set gnutls_state to NULL.
764
765 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
766 non-NULL, regardless of GNUTLS_INITSTAGE.
767 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
768 an error. Set process slots as soon as we allocate them.
769
770 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
771
9c6c6f49
CY
7722011-10-27 Chong Yidong <cyd@gnu.org>
773
9aba6043
SM
774 * gnutls.c (emacs_gnutls_deinit): New function.
775 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
776 (Fgnutls_deinit, Fgnutls_boot): Use it.
777
778 * process.c (make_process): Initialize GnuTLS credentials to NULL.
779 (deactivate_process): Call emacs_gnutls_deinit.
780
657d08d3
JB
7812011-10-27 Juanma Barranquero <lekktu@gmail.com>
782
783 * image.c (x_create_x_image_and_pixmap):
784 * w32.c (sys_rename, w32_delayed_load):
785 * w32font.c (fill_in_logfont):
786 * w32reg.c (x_get_string_resource): Silence compiler warnings.
787
5430d399
JB
7882011-10-26 Juanma Barranquero <lekktu@gmail.com>
789
790 * w32fns.c (w32_default_color_map): New function,
791 extracted from Fw32_default_color_map.
a7ef684b 792 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 793
fe0055fa
PE
7942011-10-25 Paul Eggert <eggert@cs.ucla.edu>
795
796 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
797
e6346438
SM
7982011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
799
800 * keyboard.c (test_undefined): New function (bug#9751).
801 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
802
e112cc37
ET
8032011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
804
805 * sysdep.c (init_sys_modes): Fix the check for the controlling
806 terminal (Bug#6649).
807
7b5d6677
EZ
8082011-10-20 Eli Zaretskii <eliz@gnu.org>
809
810 * dispextern.h (struct bidi_it): New member next_en_type.
811
812 * bidi.c (bidi_line_init): Initialize the next_en_type member.
813 (bidi_resolve_explicit_1): When next_en_pos is valid for the
814 current character, check also for next_en_type being WEAK_EN.
815 (bidi_resolve_weak): Don't enter the expensive loop if the current
816 position is before next_en_pos. Record the bidi type of the first
817 non-ET, non-BN character we find, in addition to its position.
818 (bidi_level_of_next_char): Invalidate next_en_type when
819 next_en_pos is over-stepped.
820
7da0b018
PE
8212011-10-20 Paul Eggert <eggert@cs.ucla.edu>
822
823 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
824 * editfns.c: Rewrite current-time-zone so that it invokes
825 the equivalent of (format-time-string "%Z") to get the time zone name.
826 This fixes a bug when the time zone name contains characters that
827 need converting from the system time locale to Emacs internal format.
828 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
829 that patch fixed format-time-string to do the conversion, but
830 I forgot to fix current-time-zone.
831 (format_time_string): New function, containing most of
832 what Fformat_time_string used to contain.
833 (Fformat_time_string): Rewrite in terms of format_time_string.
834 This doesn't change this function's behavior.
835 (current-time-zone): Rewrite to use format_time_string.
836 This fixes the bug reported by Michael Schierl in
837 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
838 Jason Rumney's 2007-06-07 change worked around this bug, but
839 didn't fix it.
840 * systime.h (tzname, timezone): Remove no-longer-used declarations.
841
8547b010
EZ
8422011-10-19 Eli Zaretskii <eliz@gnu.org>
843
844 * xdisp.c (start_display): If the character at POS is displayed
845 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
846 (try_window_reusing_current_matrix): If a line ends in a display
847 vector or the next line starts in a display vector, continue
848 redrawing the window even though the character position of
849 start_row was reached.
8547b010
EZ
850 (Bug#9771, part 2)
851
4e948d15
CY
8522011-10-18 Chong Yidong <cyd@gnu.org>
853
854 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
855 with nobreak-char-display too.
856
4787455f
EZ
8572011-10-18 Eli Zaretskii <eliz@gnu.org>
858
859 Fix part 3 of bug#9771.
860 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
861 (bidi_resolve_neutral): Don't enter the expensive loop looking for
862 non-neutral characters if the current character is a paragraph
863 separator (a.k.a. Newline). This avoids running the same
864 expensive loop twice, once when we consume the preceding newline
865 and the other time when the line actually needs to be displayed.
866 Avoid the loop when we see neutrals on the base embedding level
867 following a character whose directionality is the same as the
868 paragraph's. This avoids running the expensive loop when a line
869 ends in a long sequence of neutrals, like control characters.
870 Add assertion against STRONG_AL type. Slightly rearrange code
871 that determines the type of a neutral given the first non-neutral
872 that follows it.
873 (bidi_level_of_next_char): Set next_en_pos to zero when
874 invalidating its info.
875
2c91f553
EZ
8762011-10-17 Eli Zaretskii <eliz@gnu.org>
877
878 * xdisp.c (push_display_prop): Determine whether to record string
879 or buffer position by IT->string, not by IT->method. Allow
880 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
881 (move_it_vertically_backward): Don't look for character position
882 immediately after the newline when in a continuation line.
883 (Bug#9771, part 1)
2c91f553 884
c7b08b0d
MR
8852011-10-15 Martin Rudalics <rudalics@gmx.at>
886
887 * window.c (coordinates_in_window): Rewrite and delabelize
888 vertical border check. (Bug#5357) (Bug#9618)
889
6b02f655
SM
8902011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
891
892 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
893 errors in XSetWindowBorder (bug#9310).
894
81d40c92
DA
8952011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
896
897 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
898 avoid crash when xmalloc overrun checking is enabled.
899
d4172c3b
EZ
9002011-10-13 Eli Zaretskii <eliz@gnu.org>
901
902 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
903 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
904 cursor motion with <left> and <right> arrow keys.
905
906 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
907 some callers set that themselves.
908
b00eea75
EZ
9092011-10-12 Eli Zaretskii <eliz@gnu.org>
910
911 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
912 display string and the previous row comes from the same string and
913 is empty. (Bug#9739) (Bug#9738)
914
8fe012c4
SM
9152011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
916
917 * doc.c (get_doc_string): Encode file name (bug#9735).
918
0074aef2
EZ
9192011-10-12 Eli Zaretskii <eliz@gnu.org>
920
79beb178
EZ
921 * bidi.c (bidi_level_of_next_char):
922 * xdisp.c (get_visually_first_element): Remove old incorrect
923 comments regarding the Unicode Line Separator character.
924
0074aef2
EZ
925 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
926
6e4b3fbe
DA
9272011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
928
929 * alloc.c (Fgc_status): Do not access beyond zombies array
930 boundary if nzombies > MAX_ZOMBIES.
931 * alloc.c (dump_zombies): Add missing format specifier.
932
0324f3af
PE
9332011-10-12 Paul Eggert <eggert@cs.ucla.edu>
934
b5525cac
PE
935 * xdisp.c (set_cursor_from_row): Simplify conditionals,
936 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
937
0324f3af
PE
938 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
939 Some packages use them to denote characters with modifiers.
940
e9b5f888
AS
9412011-10-11 Andreas Schwab <schwab@linux-m68k.org>
942
943 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
944 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
945 matching a pp-number. Rename parameter var to var1.
946
127827c0
SM
9472011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
948
949 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
950
c8fd3bd0
GM
9512011-10-08 Glenn Morris <rgm@gnu.org>
952
953 * callint.c (Fcall_interactively): Give a more explicit error for the
954 'c' case with a non-character input. (Bug#8479)
955
352ec8ff
EZ
9562011-10-08 Eli Zaretskii <eliz@gnu.org>
957
03669ccb
EZ
958 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
959 lines.
7061c986
EZ
960 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
961 lines that are hscrolled on the left.
03669ccb 962
352ec8ff
EZ
963 * dispnew.c (buffer_posn_from_coords): Account for a possible
964 presence of header-line. (Bug#4426)
965
a66cfb1c
SM
9662011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
967
6b02f655
SM
968 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
969 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 970
7c5ee88e
PE
9712011-10-07 Paul Eggert <eggert@cs.ucla.edu>
972
973 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
974 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
975 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
976 this makes Emacs dump core during garbage collection on rare
977 occasions. sizeof is obviously inferior to offsetof here, so
978 stick with offsetof.
979 (GC_POINTER_ALIGNMENT): New macro.
980 (mark_memory): Omit 3rd (offset) arg; caller changed.
981 Don't assume EMACS_INT alignment is the same as pointer alignment.
982
df1bbe5b
SM
9832011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
984
985 * keyboard.c (read_key_sequence_remapped): New var.
986 (read_key_sequence): Compute remapping in the right buffer.
987 (command_loop_1): Use read_key_sequence's remapping directly.
988
51553db6
SM
9892011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
990
32c1fffd
SM
991 * dired.c (file_name_completion): Don't expand file name.
992 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
993 before checking file name handler.
994
51553db6
SM
995 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
996 they've been requested explicitly (bug#9591).
997
b6bd1599 9982011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
999
1000 * keymap.c (Fsingle_key_description): Use make_specified_string
1001 instead of build_string to build string from push_key_description.
1002 (Bug#5193)
1003
f701dc2a
PE
10042011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1005
4222c55d
PE
1006 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1007 This fixes a Y2038 bug on 64-bit hosts.
1008 * buffer.c (reset_buffer):
1009 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1010 (Fclear_buffer_auto_save_failure):
1011 Use 0, not -1, to represent an unset failure time, since time_t
1012 might not be signed.
1013
f701dc2a
PE
1014 Remove dependency on glibc malloc internals.
1015 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1016 Move back here from lisp.h, but with their new implementations.
1017 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1018 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1019 * charset.c (charset_table_init): New static var.
1020 (syms_of_charset): Use it instead of xmalloc. This removes a
1021 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1022 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1023 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1024 Move back to alloc.c.
1025 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1026 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1027
9ceebf39
JD
10282011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1029
1030 * nsterm.m (windowDidResize): Call x_set_window_size only when
1031 ns_in_resize is true. Otherwise set pixelwidth/height and
1032 call change_frame_size (Bug#9628).
1033
cb993c58
PE
10342011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1035
3930c88b
PE
1036 Port --enable-checking=all to Fedora 14 x86-64.
1037 * charset.c (syms_of_charset): Also account for glibc malloc's
1038 internal overhead when calculating the initial malloc maximum.
1039
cb993c58
PE
1040 Port --enable-checking=all to Fedora 14 x86.
1041 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1042 Move to lisp.h.
1043 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1044 (overrun_check_realloc, overrun_check_free):
1045 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1046 That way, xmalloc returns a properly-aligned pointer even if
1047 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1048 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1049 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1050 into account when calculating the initial malloc maximum.
1051 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1052 Move here from alloc.c, so that charset.c can use it too.
1053 Properly align; the old code wasn't right for common 32-bit hosts
1054 when configured with --enable-checking=all.
1055 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1056 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1057
31bed486
EZ
10582011-09-29 Eli Zaretskii <eliz@gnu.org>
1059
04c70788 1060 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1061 use EDOM.
1062
fbcaa2f3
EZ
10632011-09-28 Eli Zaretskii <eliz@gnu.org>
1064
1065 * xdisp.c (compute_display_string_end): If there's no display
1066 string at CHARPOS, return -1.
1067
1068 * bidi.c (bidi_fetch_char): When compute_display_string_end
1069 returns a negative value, treat the character as a normal
1070 character not covered by a display string. (Bug#9624)
1071
a239d4e9
JB
10722011-09-28 Juanma Barranquero <lekktu@gmail.com>
1073
1074 * lread.c (Fread_from_string): Fix typo in docstring.
1075
88652fd5
EZ
10762011-09-27 Eli Zaretskii <eliz@gnu.org>
1077
1078 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1079 newline, reseat the iterator instead of bidi-iterating there one
1080 character at a time. (Bug#9610)
32c1fffd
SM
1081 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1082 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1083
ed497dd4
AS
10842011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1085
1086 * lread.c (readevalloop): Use correct code for NBSP.
1087 (read1): Likewise. (Bug#9608)
1088
b2bf61aa
MA
10892011-09-25 Michael Albinus <michael.albinus@gmx.de>
1090
1091 * dbusbind.c (Fdbus_register_signal): When service is not
1092 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1093
32bbb17c
GM
10942011-09-25 Glenn Morris <rgm@gnu.org>
1095
1096 * buffer.c (truncate-lines): Doc fix.
1097
94e0933e
CY
10982011-09-24 Chong Yidong <cyd@stupidchicken.com>
1099
1100 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1101 (Fset_window_next_buffers): Doc fix.
1102
cddde921
GM
11032011-09-24 Glenn Morris <rgm@gnu.org>
1104
1105 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1106
1260aef1
PE
11072011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1108
25b4bfa0
PE
1109 Fix minor problems found by static checking.
1110 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1111 * indent.c (Fvertical_motion): Fix == vs = typo.
1112
e3cbd34b
EZ
11132011-09-24 Eli Zaretskii <eliz@gnu.org>
1114
a66cfb1c
SM
1115 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1116 Default value is now t. Doc fix.
6bf7006f 1117
e3cbd34b 1118 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1119 logic when moving up, not only when moving down. Fix the
e3cbd34b 1120 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1121 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1122
1123 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1124 CHARPOS is covered by a display string which includes newlines.
1125 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1126 is covered by a display string with embedded newlines.
1127
a3de0cbd
MA
11282011-09-24 Michael Albinus <michael.albinus@gmx.de>
1129
1130 * dbusbind.c (Fdbus_register_signal): Add match rule to
1131 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1132 (Fdbus_register_method, Vdbus_registered_objects_table):
1133 Fix docstring.
a3de0cbd 1134
b260039d
JM
11352011-09-24 Jim Meyering <meyering@redhat.com>
1136
32c1fffd 1137 do not ignore write error for any output size
b260039d
JM
1138 The previous change was incomplete.
1139 While it makes emacs --batch detect the vast majority of stdout
1140 write failures, errors were still ignored whenever the output size is
1141 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1142 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1143 && echo FAIL: ignored write error
1144 FAIL: ignored write error
1145 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1146 && echo FAIL: ignored write error
1147 FAIL: ignored write error
1148 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1149
8eca8a7c
AS
11502011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1151
1152 * emacs.c (Fkill_emacs): In noninteractive mode exit
1153 non-successfully if a write error occurred on stdout. (Bug#9574)
1154
3341db62
EZ
11552011-09-21 Eli Zaretskii <eliz@gnu.org>
1156
1157 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1158 the xassert test.
1159
1160 * dispextern.h (struct it): Update the comment documenting what
1161 can it->OBJECT be.
1162
8c203dbf
EZ
11632011-09-20 Eli Zaretskii <eliz@gnu.org>
1164
1165 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1166 a display string, extend search for cursor position to end of row.
1167 (find_row_edges): If the row ends in a newline from a display
1168 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1169 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1170 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1171 non-empty line. Fixes confusing cursor motion with arrow keys at
1172 the beginning of a line that starts with whitespace.
8c203dbf 1173
a4824228
LMI
11742011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1175
1176 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1177 (bug#9493).
1178
33ed493b
CY
11792011-09-18 Chong Yidong <cyd@stupidchicken.com>
1180
1181 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1182 boolean (Bug#9154).
1183
56cd55c8
EZ
11842011-09-18 Eli Zaretskii <eliz@gnu.org>
1185
1186 * xdisp.c (display_line): Record maximum and minimum buffer
1187 positions even if no glyphs were produced (e.g., by a zero-width
1188 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1189 buffer positions that will be removed from the glyph row because
1190 they don't fit.
c02dcedf
EZ
1191 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1192 column is beyond frame width: don't subtract 1 "pixel" when
1193 computing width of the stretch.
3e62b7e0
EZ
1194 (reseat_at_next_visible_line_start): Undo the change made on
1195 2011-09-17 that saved paragraph information and restored it after
1196 the call to `reseat'. (Bug#9545)
56cd55c8 1197
5ed99d36 11982011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1199
1200 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1201 and turn window cursor on if cleared (Bug#9415).
1202
5ed99d36 12032011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1204
1205 * search.c (boyer_moore): Take unibyte characters from pattern
1206 literally. (Bug#9458)
1207
9bade7b2
EZ
12082011-09-18 Eli Zaretskii <eliz@gnu.org>
1209
1210 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1211
e5e9d610
PE
12122011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1213
87e4427a
PE
1214 Fix minor problem found by static checking.
1215 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1216 initialized, to pacify gcc -Wuninitialized.
1217
e5e9d610
PE
1218 * fileio.c: Report proper errno when syscall falls.
1219 (Finsert_file_contents): Save and restore errno,
1220 so that report_file_error outputs the correct diagnostic.
1221 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1222
a1674f0b
EZ
12232011-09-18 Eli Zaretskii <eliz@gnu.org>
1224
1225 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1226
fbfb6dd4
EZ
12272011-09-17 Eli Zaretskii <eliz@gnu.org>
1228
1229 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1230 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1231
bb187662
EZ
12322011-09-17 Eli Zaretskii <eliz@gnu.org>
1233
1137e8b8 1234 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1235 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1236
1237 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1238 (bidi_find_paragraph_start): Search back for paragraph beginning
1239 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1240 (bidi_move_to_visually_next): Only trigger paragraph-related
1241 computations when the last character is a newline or at EOB, not
1242 just any NEUTRAL_B. (Bug#9470)
1243
bb187662
EZ
1244 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1245 truncated lines if point is covered by a display string. (Bug#9524)
1246
2e621251
PE
12472011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1248
1249 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1250 (cons_to_x_long): New function.
1251 (lisp_data_to_selection_data): Use it. Correct the test for
1252 short-versus-long data; it was negated. Break out of vector
1253 loop, for efficiency, when a long datum is discovered.
1254
91a15bc6
SM
12552011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1256
1257 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1258
b41c3a35
EZ
12592011-09-16 Eli Zaretskii <eliz@gnu.org>
1260
1261 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1262 GCC PR/17406) by declaring this function with external scope.
1263
7812ba2d
PE
12642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1265
1266 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1267 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1268
cf7edc2a
AS
12692011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1270
1271 * editfns.c (Fformat): Correctly handle text properties on "%%".
1272
bd01620e
EZ
12732011-09-15 Eli Zaretskii <eliz@gnu.org>
1274
1275 * xterm.c (x_draw_composite_glyph_string_foreground):
1276 * w32term.c (x_draw_composite_glyph_string_foreground):
1277 * term.c (encode_terminal_code):
1278 * composite.c (composition_update_it, get_composition_id):
1279 * xdisp.c (get_next_display_element)
1280 (fill_composite_glyph_string): Add comments about special meaning
1281 of TAB characters in a composition.
1282
a02719a3
PE
12832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1284
1285 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1286 This occurs when processing a multibyte format.
1287 Problem reported by Wolfgang Jenker.
a02719a3 1288
72589a3c
JB
12892011-09-15 Johan Bockgård <bojohan@gnu.org>
1290
1291 * xdisp.c (try_cursor_movement): Only check for exact match if
1292 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1293
1c14176c
PE
12942011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 Remove unused external symbols.
1297 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1298 * xdisp.c (calc_pixel_width_or_height): Now static.
1299 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1300 * indent.c (check_display_width):
1301 * w32term.c: Fix comment to match code.
1302 * xterm.c, xterm.h (x_catching_errors): Remove.
1303
d2eea5b5
PE
13042011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 * xselect.c: Use signed conversions more consistently (Bug#9498).
1307 (selection_data_to_lisp_data): Assume incoming selection data are
1308 signed integers, not unsigned. This is to be consistent with
1309 outgoing selection data, which was modified to use signed integers
1310 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1311 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1312 expects long, not unsigned long.
1313
46888499
EZ
13142011-09-14 Eli Zaretskii <eliz@gnu.org>
1315
1316 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1317 computation of loop end. Reported by Johan Bockgård
1318 <bojohan@gnu.org>.
1319
ef8ef9fb
CY
13202011-09-13 Chong Yidong <cyd@stupidchicken.com>
1321
1322 * frame.c (Fother_visible_frames_p): Function deleted.
1323
fa819fed
EZ
13242011-09-12 Eli Zaretskii <eliz@gnu.org>
1325
1326 * indent.c (compute_motion): Process display vector front to back
1327 rather than the other way around. (Bug#2496)
1328
2ba8e008
SM
13292011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1330
1331 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1332
20f53c69
CY
13332011-09-11 Chong Yidong <cyd@stupidchicken.com>
1334
1335 * minibuf.c (Fread_from_minibuffer): Doc fix.
1336
d562d7a4
EZ
13372011-09-11 Eli Zaretskii <eliz@gnu.org>
1338
1339 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1340 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1341
1c4d7f3d
LMI
13422011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1343
1344 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1345 value for non-existent files.
1346
b885bf36
EZ
13472011-09-11 Eli Zaretskii <eliz@gnu.org>
1348
1349 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1350 set its "size" to -1. This will set the modtime_size field of
1351 the corresponding buffer to -1, which is what
1352 verify-visited-file-modtime expects for files that do not exist.
1353 (Bug#9139)
1354
6612f0bf
PE
13552011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1356
1357 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1358 here ...
1359 * lisp.h: ... from here. push_key_description is no longer
1360 defined in keyboard.c, so its declaration should not be in
1361 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1362 logically belongs with push_key_description.
1363
dfb3f755
PE
13642011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 * buffer.h: Include <sys/types.h> instead of <time.h>.
1367 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1368 Problem reported by Herbert J. Skuhra.
1369
3134906c
LMI
13702011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1371
1372 * xml.c (parse_region): Make the parsing work for
1373 non-comment-starting XML files again (bug#9144).
1374
8d903f4e
AS
13752011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1376
1377 * image.c (gif_load): Fix calculation of bottom and right corner.
1378 (Bug#9468)
1379
80ad64f4
EZ
13802011-09-10 Eli Zaretskii <eliz@gnu.org>
1381
1382 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1383 redisplay in small windows.
1384
208a048d
EZ
13852011-09-09 Eli Zaretskii <eliz@gnu.org>
1386
1387 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1388
9b1c252e
MR
13892011-09-08 Martin Rudalics <rudalics@gmx.at>
1390
1391 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1392 Operate on live windows only.
1393
2949f33b
JB
13942011-09-08 Juanma Barranquero <lekktu@gmail.com>
1395
1396 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1397
e08dcafd
EZ
13982011-09-07 Eli Zaretskii <eliz@gnu.org>
1399
1400 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1401 only under bidi iteration.
1402
115b96bd
JD
14032011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1404
1405 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1406
c8199d0f
PE
14072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1408
1409 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1410 Without this fix, the command to link temacs failed due to an
1411 undefined symbol __builtin_isnan. This is because
1412 /usr/include/iso/math_c99.h #defines isnan(x) to
1413 __builtin_isnan(x), but the bundled gcc, which identifies itself
1414 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1415 a __builtin_isnan.
1416 * floatfns.c (isnan): #undef, and then #define to a clone of
1417 what's in data.c.
1418 (Fisnan): Always define, since it's always available now.
1419 (syms_of_floatfns): Always define isnan at the Lisp level.
1420
e39b275c 14212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1422
1423 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1424
b2db44d9 14252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1426
f4af5137 1427 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1428 The previous code assumed that file offsets (off_t values) fit in
1429 EMACS_INT variables, which is not true on typical 32-bit hosts.
1430 The code messed up by falsely reporting buffer overflow in cases
1431 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1432 when "big" contains more than 2**29 bytes, even though this
1433 inserts just one byte and does not overflow the buffer.
1434 (Finsert_file_contents): Store file offsets as off_t
1435 values, not as EMACS_INT values. Check for overflow when
1436 converting between EMACS_INT and off_t. When checking for
1437 buffer overflow or for overlap, take the offsets into account.
1438 Don't use EMACS_INT for small values where int suffices.
1439 When checking for overlap, fix a typo: ZV was used where
1440 ZV_BYTE was intended.
1441 (Fwrite_region): Don't assume off_t fits into 'long'.
1442 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1443
ecfc0a49
MA
14442011-09-05 Michael Albinus <michael.albinus@gmx.de>
1445
1446 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1447
6511acf2 14482011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1449
0999621a 1450 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1451
1452 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1453 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1454 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1455 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1456 (modify_event_symbol): Do not assume that the length of
1457 name_alist_or_stem is safe to alloca and fits in int.
1458 (Fexecute_extended_command): Likewise for function name and binding.
1459 (Frecursion_depth): Wrap around reliably on integer overflow.
1460 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1461 since some callers pass EMACS_INT values.
1462 (Fsingle_key_description): Don't crash if symbol name contains more
1463 than MAX_ALLOCA bytes.
1464 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1465 (get_minibuffer): Arg is now EMACS_INT, not int.
1466 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1467 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1468 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1469
2be7d702
PE
1470 * dbusbind.c (signature_cat): New function.
1471 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1472 Do not overrun buffer; instead, report string overflow.
1473
9d1df220
PE
1474 * dispnew.c (add_window_display_history): Don't overrun buffer.
1475 Truncate instead; this is OK since it's just a log.
1476
33ef5c64
PE
1477 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1478 even if the time zone offset is outlandishly large.
1479 Don't mishandle offset == INT_MIN.
1480
66c6fdd5
PE
1481 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1482 when creating daemon; the previous buffer-overflow check was incorrect.
1483
d749b01b
PE
1484 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1485 which has the guts of the old verror function.
1486
b5cd1905
PE
1487 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1488 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1489
6e1a67fb
PE
1490 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1491 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1492 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1493 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1494 length of string rather than counting it via multiple sprintfs;
1495 that's simpler and more reliable.
c21721cc
PE
1496 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1497 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1498 sprintf, in case result does not fit in int.
1499
c57b67fc
PE
1500 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1501 (fontset_from_font): Print it.
1502
8a401434
PE
1503 * frame.c (tty_frame_count): Now printmax_t, not int.
1504 (make_terminal_frame, set_term_frame_name): Print it.
1505 (x_report_frame_params): In X, window IDs are unsigned long,
1506 not signed long, so print them as unsigned.
1507 (validate_x_resource_name): Check for implausibly long names,
1508 and don't assume name length fits in 'int'.
1509 (x_get_resource_string): Don't blindly alloca invocation name;
1510 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1511 not fit in int.
1512
6e1a67fb
PE
1513 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1514 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1515 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1516
0df02bf3
PE
1517 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1518 Use esprintf, not sprintf, in case result does not fit in int.
1519
48e30793
PE
1520 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1521 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1522 it as a large positive number.
1523 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1524 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1525
a66ff6d8
PE
1526 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1527 in case result does not fit in int.
1528
aca216ff
PE
1529 * print.c (float_to_string): Detect width overflow more reliably.
1530 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1531 buffer overrun. Don't assume list length fits in 'int'. Treat
1532 print length of 0 as 0, not as infinity; to be consistent with other
1533 uses of print length in this function. Don't overflow print length
1534 index. Don't assume hash table size fits in 'long', or that
1535 vectorlike size fits in 'unsigned long'.
1536
31c286f7
PE
1537 * process.c (make_process): Use printmax_t, not int, to format
1538 process-name gensyms.
1539
55e5faa1
PE
1540 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1541
80f2e268
PE
1542 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1543 to avoid potential buffer overrun.
1544
670741ab
PE
1545 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1546 if X resource line is longer than 512 bytes.
1547
b7163a50
PE
1548 * xfns.c (x_window): Make sprintf buffer a bit bigger
1549 to avoid potential buffer overrun.
1550
ae58ff1f
PE
1551 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1552
c43c8a6a
PE
1553 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1554
3f8236f4
PE
15552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1556
53e9fe90 1557 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1558 Without these, Emacs silently mishandles large integers sometimes.
1559 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1560 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1561
6511acf2
PE
1562 * xdisp.c (try_window_id): Check Emacs fixnum range before
1563 converting to 'int'.
806add1d 1564
6511acf2 1565 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1566 Check that an Emacs fixnum is in range before assigning it to 'int'.
1567 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1568 values converted from Emacs fixnums.
1569 (Frecenter): Don't wrap around a line count if it is out of 'int'
1570 range; instead, treat it as an extreme value.
1571 (Fset_window_configuration, compare_window_configurations):
1572 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1573
6511acf2
PE
1574 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1575 that can exceed INT_MAX. Check that EMACS_INT value is in range
1576 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1577 (match_limit): Don't assume that a fixnum can fit in 'int'.
1578
6511acf2 1579 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1580 exceed INT_MAX.
1581
6511acf2 1582 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1583 (Fvertical_motion): Don't wrap around LINES values that don't fit
1584 in 'int'. Instead, treat them as extreme values. This is good
1585 enough for windows, which can't have more than INT_MAX lines anyway.
1586
fcb901a7
LMI
15872011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1588
0f2f6b6d
LMI
1589 * Require libxml/parser.h to avoid compilation warning.
1590
fcb901a7
LMI
1591 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1592
1593 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1594 since this reportedly can destroy thread storage.
1595
6e20a0d4
CY
15962011-08-30 Chong Yidong <cyd@stupidchicken.com>
1597
1598 * syntax.c (find_defun_start): Update all cache variables if
1599 exiting early (Bug#9401).
1600
148ae00e
EZ
16012011-08-30 Eli Zaretskii <eliz@gnu.org>
1602
f6cfbd8f
EZ
1603 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1604
148ae00e
EZ
1605 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1606 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1607 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1608
1609 * term.c (tty_append_glyph): New function.
1610 (produce_stretch_glyph): Static function and its prototype deleted.
1611
a66cfb1c
SM
1612 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1613 Add prototypes.
148ae00e 1614
c4a07a4c
PE
16152011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1616
1617 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1618 when checking :margin (Bug#9390).
1619 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1620 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1621 so that the name doesn't mislead. All uses changed.
1622
6bc8cd65
JB
16232011-08-28 Johan Bockgård <bojohan@gnu.org>
1624
1625 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1626 set_tty_hooks.
1627
dca4927e
EZ
16282011-08-27 Eli Zaretskii <eliz@gnu.org>
1629
1630 * xdisp.c (move_it_to): Don't bail out early when reaching
1631 position beyond to_charpos, if we are scanning backwards.
1632 (move_it_vertically_backward): When DY == 0, make sure we get to
1633 the first character in the line after the newline.
1634
f2cad773
PE
16352011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1636
1637 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1638 (ccl_driver): Do not generate an out-of-range pointer.
1639 (Fccl_execute_on_string): Remove unnecessary check for
1640 integer overflow, noted by Stefan Monnier in
1641 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1642 Remove a FIXME that didn't need fixing.
1643 Simplify the newly-introduced buffer reallocation code.
1644
0cae2cdb
JB
16452011-08-27 Juanma Barranquero <lekktu@gmail.com>
1646
1647 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1648
5fc295a4 16492011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1650
70c60eb2 1651 Integer and memory overflow issues (Bug#9196).
726e0ab1 1652
d31850da
PE
1653 * doc.c (get_doc_string): Rework so that
1654 get_doc_string_buffer_size is the actual buffer size, rather than
1655 being 1 less than the actual buffer size; this makes xpalloc more
1656 convenient.
1657
a69fbedb
PE
1658 * image.c (x_allocate_bitmap_record, cache_image):
1659 * xselect.c (Fx_register_dnd_atom):
1660 Simplify previous changes by using xpalloc.
1661
fe5c5d37
PE
1662 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1663 since either will do and ptrdiff_t is convenient with xpalloc.
1664
0065d054
PE
1665 * charset.c (charset_table_size)
1666 (struct charset_sort_data.priority): Now ptrdiff_t.
1667 (charset_compare): Don't overflow if priorities differ greatly.
1668 (Fsort_charsets): Don't assume list length fits in int.
1669 Check for size-calculation overflow when allocating sort data.
1670 (syms_of_charset): Allocate an initial charset table that is
1671 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1672
1673 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1674
1675 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1676 The actual value is always <= INT_MAX, and leaving it unsigned made
1677 overflow checking harder.
1678
1679 * dispextern.h (struct glyph_matrix.rows_allocated)
1680 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1681 with xpalloc. The values are still always <= INT_MAX.
1682
1683 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1684
1685 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1686 (SAFE_NALLOCA): New macro.
1687
1688 * region-cache.c (struct boundary.pos, find_cache_boundary)
1689 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1690 (set_cache_region, invalidate_region_cache)
1691 (revalidate_region_cache, know_region_cache, region_cache_forward)
1692 (region_cache_backward, pp_cache):
1693 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1694 so that ptrdiff_t * can be passed to xpalloc.
1695 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1696 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1697 (pp_cache): Don't assume cache_len fits in int.
1698 * region-cache.h: Adjust extern decls to match.
1699
1700 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1701 EMACS_INT, since either will do, for xpalloc.
1702
1703 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1704 (xnmalloc, xnrealloc, xpalloc): New functions.
1705
726e0ab1
PE
1706 * bidi.c (bidi_shelve_header_size): New constant.
1707 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1708 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1709
51f30bc5 1710 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1711 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1712 (overlay_strings):
1713 Don't update size of array until after memory allocation succeeds,
1714 because xmalloc/xrealloc may not return.
0065d054
PE
1715 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1716 now that we have proper integer overflow checking.
1717 (record_overlay_string, overlay_strings): Catch overflows when
1718 calculating size of overlay_str_buf.
726e0ab1 1719
0065d054
PE
1720 * callproc.c (Fcall_process): Check for size overflow when
1721 calculating size of args2.
1722 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1723 Normally we prefer signed values, but sticking with ptrdiff_t would
1724 require adding more-complicated checks.
726e0ab1
PE
1725
1726 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1727 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1728 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1729 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1730
1731 * character.c (Fstring): Check for size-calculation overflow.
1732
1733 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1734 unnecessary integer overflow. Check for size overflow.
1735 (encode_coding_object): Don't update size until xmalloc succeeds.
1736
1737 * composite.c (get_composition_id): Check for overflow in glyph
1738 length calculations.
1739
1740 Integer and memory overflow fixes for display code.
1741 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1742 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1743 (scrolling_window): Check for overflow in size calculations.
1744 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1745 Don't assume glyph table len fits in int.
1746 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1747 (row_table_size): Now ptrdiff_t, not int.
1748 (scrolling_window): Avoid overflow in size calculations.
1749 Don't update size until allocation succeeds.
1750 * fns.c (concat): Check for overflow in size calculations.
1751 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1752 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1753 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1754
1755 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1756 (get_doc_string): Check for size calculation overflow.
1757 Don't update size until allocation succeeds.
1758 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1759 EMACS_INT, where ptrdiff_t will do.
1760 (Fsubstitute_command_keys): Check for string overflow.
1761
1762 * editfns.c (set_time_zone_rule): Don't assume environment length
1763 fits in int.
1764 (message_length): Now ptrdiff_t, not int.
1765 (Fmessage_box): Don't update size until allocation succeeds.
1766 Don't assume message length fits in int.
1767 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1768
0065d054
PE
1769 * emacs.c (main): Do not reallocate argv, since there is a null at
1770 the end that can be overwritten, and this way there's no need to
1771 worry about size-calculation overflow.
1772 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1773
1774 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1775 alloc succeeds.
1776 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1777
1778 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1779 (x_set_scroll_bar_width, x_figure_window_size):
1780 Check for integer overflow.
1781 (x_set_alpha): Do not assume XINT fits in int.
1782
1783 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1784 This is for the members text_lines, text_cols, total_lines, total_cols,
1785 where the system imposes an 'int' limit.
1786
1787 * fringe.c (Fdefine_fringe_bitmap):
1788 Don't update size until alloc works.
1789
1790 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1791 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1792
1793 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1794 Check for size-calculation overflow.
1795 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1796 do, as we prefer signed integers.
1797 (id_to_widget.max_size, id_to_widget.used)
1798 (xg_store_widget_in_map, xg_remove_widget_from_map)
1799 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1800 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1801 Use and return ptrdiff_t, not int.
1802 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1803 * gtkutil.h: Change prototypes to match the above.
1804
1805 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1806 are duplicate now that they've been promoted to lisp.h.
1807 (x_allocate_bitmap_record, x_alloc_image_color)
1808 (make_image_cache, cache_image, xpm_load):
1809 Don't update size until alloc is done.
1810 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1811 (x_detect_edges):
3256efce 1812 Check for size calculation overflow.
726e0ab1
PE
1813 (ct_colors_allocated_max): New constant.
1814 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1815 overflow.
3256efce 1816
726e0ab1
PE
1817 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1818 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1819 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1820 Use ptrdiff_t, not int, to count maps.
1821 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1822 calculations. Don't update size until allocation succeeds.
1823 Redo calculations to avoid overflow.
726e0ab1
PE
1824 * keyboard.h: Change prototypes to match the above.
1825
1826 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1827 to count maps.
1828 (current_minor_maps): Check for size calculation overflow.
1829 * keymap.h: Change prototypes to match the above.
1830
1831 * lread.c (read1, init_obarray): Don't update size until alloc done.
1832
1833 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1834 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1835
726e0ab1
PE
1836 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1837 Now ptrdiff_t, not int.
1838 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1839 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1840
1841 * process.c (Fnetwork_interface_list): Check for overflow
1842 in size calculation.
1843
1844 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1845
1846 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1847 overflow. Don't bother calling xmalloc when xrealloc will do.
1848
1849 * search.c (Freplace_match): Check for size calculation overflow.
1850 (Fset_match_data): Don't assume list lengths fit in 'int'.
1851
1852 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1853 for command line length. Do not attempt to address one before the
1854 beginning of an array, as that's not portable.
1855
1856 * term.c (max_frame_lines): Remove; unused.
1857 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1858 not int.
1859 (encode_terminal_code, calculate_costs): Check for size
1860 calculation overflow.
1861 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1862 table lengths and related sizes. Don't update size until alloc
1863 done. Redo calculations to avoid overflow.
1864 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1865
1866 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1867 subtracting pointers.
1868 (gobble_line): Check for overflow more carefully. Don't update size
1869 until alloc done.
1870
1871 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1872 Don't update size until alloc done.
1873 Redo size calculations to avoid overflow.
1874 Check for size calculation overflow.
0065d054 1875 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1876
1877 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1878 Use ptrdiff_t, not int, for sizes.
1879 (store_mode_line_noprop_char): Don't update size until alloc done.
1880
0065d054
PE
1881 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1882 Use ptrdiff_t, not int, for sizes.
1883 (Finternal_make_lisp_face, cache_face):
1884 Check for size calculation overflow.
1885 (cache_face): Treat size calculation overflows as if they were
1886 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1887
1888 * xfns.c (x_encode_text, x_set_name_internal)
1889 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1890 sizes, since they can exceed INT_MAX in size. Check for size
1891 calculation overflow.
1892
0065d054
PE
1893 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1894 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1895 Don't update size until alloc done.
1896
0065d054 1897 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1898 as sprintf is limited to int lengths.
1d526e2f 1899
252c5ee1
PE
1900 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1901 (X_LONG_MIN): New macros.
864d7ce7
PE
1902 Use them to make the following changes clearer.
1903 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1904 This change doesn't affect the value now, but it may help remind
1905 future maintainers not to raise the value too much later.
1906 (SELECTION_QUANTUM): Remove, replacing with ...
1907 (selection_quantum): ... new function, which avoids overflow.
1908 All uses changed.
1909 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1910 assumption that selection length fits in 'int'.
1911 (x_reply_selection_request, x_handle_selection_request)
1912 (x_get_window_property, receive_incremental_selection)
1913 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1914 (lisp_data_to_selection_data, clean_local_selection_data):
1915 Use ptrdiff_t, not int, to record length of selection.
1916 (x_reply_selection_request, x_get_window_property)
1917 (receive_incremental_selection, x_property_data_to_lisp):
1918 Redo calculations to avoid overflow.
1919 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1920 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1921 something.
1922 (x_get_window_property, receive_incremental_selection)
1923 (lisp_data_to_selection_data, x_property_data_to_lisp):
1924 Check for size-calculation overflow.
1925 (x_get_window_property, receive_incremental_selection)
1926 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1927 Don't store size until memory allocation succeeds.
1928 (x_get_window_property): Plug memory leak on memory exhaustion.
1929 Don't double-block input; malloc is safe here. Don't assume 2**34
1930 - 4 fits in unsigned long. Add an xassert to check
1931 XGetWindowProperty overflow. Be more careful about overflow
1932 calculations, and distinguish size from memory overflow better.
1933 (receive_incremental_selection): When tracing, don't assume
1934 unsigned int is less than INT_MAX.
1935 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1936 harmful) conversions of unsigned short to int.
1937 (lisp_data_to_selection_data): Don't assume that integers
1938 in the range -65535 through -1 fit in an X unsigned short.
1939 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1940 result parameters unless successful. Rely on cons_to_unsigned
1941 to report problems with elements; the old code wasn't right anyway.
1942 (x_check_property_data): Check for int overflow; we cannot use
1943 a wider type due to X limits.
1944 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1945
726e0ab1 1946 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1947
0065d054
PE
1948 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1949 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1950 (x_color_cells): Don't store size until memory allocation succeeds.
1951 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1952 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1953 (x_term_init): Don't assume length fits in int (sprintf is limited
1954 to int size).
bc18e09d 1955
ebfa62c0
PE
1956 Use ptrdiff_t for composition IDs.
1957 * character.c (lisp_string_width):
1958 * composite.c (composition_table_size, n_compositions)
1959 (get_composition_id, composition_gstring_from_id):
1960 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1961 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1962 * window.c (Frecenter):
1963 Use ptrdiff_t, not int, for composition IDs.
1964 * composite.c (get_composition_id): Check for integer overflow.
1965 * composite.h: Adjust prototypes to match the above changes.
1966
d3411f89
PE
1967 Use ptrdiff_t for hash table indexes.
1968 * category.c (hash_get_category_set):
1969 * ccl.c (ccl_driver):
1970 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1971 * coding.c (coding_system_charset_list, detect_coding_system):
1972 * coding.h (struct coding_system.id):
1973 * composite.c (get_composition_id, gstring_lookup_cache):
1974 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1975 * image.c (xpm_get_color_table_h):
1976 * lisp.h (hash_lookup, hash_put):
1977 * minibuf.c (Ftest_completion):
1978 Use ptrdiff_t for hash table indexes, not int (which is too
1979 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1980 32-bit --with-wide-int hosts).
1981
e097a6fa
PE
1982 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1983 Add a FIXME comment about memory leaks.
1984 (syms_of_charset): Don't assume xmalloc returns.
1985
5637687f
PE
1986 Don't assume that stated character widths fit in int.
1987 * character.c (Fchar_width, c_string_width, lisp_string_width):
1988 * character.h (CHAR_WIDTH):
1989 * indent.c (MULTIBYTE_BYTES_WIDTH):
1990 Use sanitize_char_width to avoid undefined and/or bad behavior
1991 with outlandish widths.
a66cfb1c 1992 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1993 now that we have two such functions. All uses changed.
1994 (sanitize_char_width): New inline function.
1995
a2271ba2
PE
1996 Don't assume that tab-width fits in int.
1997 * character.h (sanitize_width): New inline function.
1998 (SANE_TAB_WIDTH): New macro.
1999 (ASCII_CHAR_WIDTH): Use it.
2000 * indent.c (sane_tab_width): Remove. All uses replaced by
2001 SANE_TAB_WIDTH (current_buffer).
2002 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2003
18c52557
PE
2004 * fileio.c: Integer overflow issues with file modes.
2005 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2006
caeeedc1
PE
2007 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2008 Remove unreachable code.
2009 (read_hex, load_charset_map_from_file): Check for integer overflow.
2010
50849c52
PE
2011 * xterm.c: don't go over XClientMessageEvent limit
2012 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2013 (x_send_scroll_bar_event): Likewise. Check that the size does not
2014 exceed limits imposed by XClientMessageEvent, as well as the usual
2015 ptrdiff_t and size_t limits.
2016
b13995db
PE
2017 * keyboard.c: Overflow, signedness and related fixes.
2018 (make_lispy_movement): Use same integer type in forward decl
2019 that is used in the definition.
2020 (read_key_sequence, keyremap_step):
2021 Change bufsize argument back to int, undoing my 2011-03-30 change.
2022 We prefer signed types, and int is wide enough here.
2023 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2024 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2025 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2026 length, not size_t. Use ptrdiff_t for index, not int.
2027 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2028 possibility of integer overflow.
2029
13464394
PE
2030 Overflow, signedness and related fixes for images.
2031
2032 * dispextern.h (struct it.stack[0].u.image.image_id)
2033 (struct_it.image_id, struct image.id, struct image_cache.size)
2034 (struct image_cache.used, struct image_cache.ref_count):
2035 * gtkutil.c (update_frame_tool_bar):
2036 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2037 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2038 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2039 * nsmenu.m (update_frame_tool_bar):
2040 * xdisp.c (calc_pixel_width_or_height):
2041 * xfns.c (image_cache_refcount):
2042 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2043 on typical 64-bit hosts.
2044
2045 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2046 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2047 Omit unnecessary casts to int.
2048 (parse_image_spec): Check that integers fall into 'int' range
2049 when the callers expect that.
2050 (image_ascent): Redo ascent calculation to avoid int overflow.
2051 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2052 (lookup_image): Remove unnecessary tests.
2053 (xbm_image_p): Locals are now of int, not EMACS_INT,
2054 since parse_image_check makes sure they fit into int.
2055 (png_load, gif_load, svg_load_image):
2056 Prefer int to unsigned where either will do.
2057 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2058 old tiff_error_handler and tiff_warning_handler.
2059 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2060 stack buffer overflows. It uses only the features of vsnprintf
2061 that are common to both POSIX and native Microsoft.
2062 (tiff_error_handler, tiff_warning_handler): Use it.
2063 (tiff_load, gif_load, imagemagick_load_image):
2064 Don't assume :index value fits in 'int'.
2065 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2066 (imagemagick_load_image): Check that crop parameters fit into
2067 the integer types that MagickCropImage accepts. Don't assume
2068 Vimagemagick_render_type has a nonnegative value. Don't assume
2069 size_t fits in 'long'.
2070 (gs_load): Use printmax_t to print the widest integers possible.
2071 Check for integer overflow when computing image height and width.
2072
c11821d4
EZ
20732011-08-26 Eli Zaretskii <eliz@gnu.org>
2074
2075 * xdisp.c (redisplay_window): Don't force window start if point
2076 will be invisible in the resulting window. (Bug#9324)
2077
0c95fcf7
EZ
20782011-08-25 Eli Zaretskii <eliz@gnu.org>
2079
2080 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2081 the display spec is of the form `(space ...)'.
2082 (handle_display_spec): Return the value returned by
2083 handle_single_display_spec, not just 1 or zero.
2084 (handle_single_display_spec): If the display spec is of the form
2085 `(space ...)', and specifies display in the text area, return 2
2086 rather than 1.
fee65a97 2087 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2088 accurately, and prefer exact match for point under bidi.
2089 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2090
2091 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2092 into disp_prop; all users changed.
2093
2094 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2095 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2096 for the text covered by the display property.
2097
e4ed06f1
CY
20982011-08-25 Chong Yidong <cyd@stupidchicken.com>
2099
2100 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2101 Change return value to nil.
2102 (Frecord_buffer): Delete unused function.
2103
f67cdd7f
EZ
21042011-08-24 Eli Zaretskii <eliz@gnu.org>
2105
5980d4c6
EZ
2106 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2107 buffers, return left-to-right.
8610fe8b
EZ
2108 (set_cursor_from_row): Consider candidate row a win if its glyph
2109 represents a newline and point is on that newline. Fixes cursor
2110 positioning on the newline at EOL of R2L text within L2R
2111 paragraph, and vice versa.
2112 (try_cursor_movement): Check continued rows, in addition to
2113 continuation rows. Fixes unwarranted scroll when point enters a
2114 continued line of R2L text within an L2R paragraph, or vice versa.
2115 (cursor_row_p): Consider the case of point being equal to
2116 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2117 from the end of a short line to the beginning of a continued line
2118 of R2L text within L2R paragraph.
2119 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2120 composed characters.
5980d4c6 2121
f67cdd7f
EZ
2122 * bidi.c (bidi_check_type): Use xassert.
2123 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2124 members.
2125
bca633fb
EZ
21262011-08-23 Eli Zaretskii <eliz@gnu.org>
2127
2128 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2129 a character.
2130
4a5885a7
CY
21312011-08-23 Chong Yidong <cyd@stupidchicken.com>
2132
2133 * nsfont.m (ns_otf_to_script): Fix typo.
2134
0902a04e
KH
21352011-08-22 Kenichi Handa <handa@m17n.org>
2136
2137 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2138 extra slot even if the purpose is char-code-property-table.
2139
1a2e6670
EZ
21402011-08-23 Eli Zaretskii <eliz@gnu.org>
2141
8ddde651
EZ
2142 * xdisp.c (redisplay_window): When computing centering_position,
2143 account for the height of the header line. (Bug#8874)
2144
425cc014
EZ
2145 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2146 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2147 candidate is selected by the mouse, and that candidate has a
2148 composed character under the mouse.
2149
1a2e6670
EZ
2150 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2151 coordinates reported by pos-visible-in-window-p for a composed
2152 character in column zero.
2153
8b76d6f8
SM
21542011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2155
2156 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2157
dac347dd
EZ
21582011-08-22 Eli Zaretskii <eliz@gnu.org>
2159
2160 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2161 consider it a hit if to_charpos is anywhere in the range of the
2162 composed buffer positions.
2163
e013fb34
CY
21642011-08-22 Chong Yidong <cyd@stupidchicken.com>
2165
2166 * image.c (gif_load): Don't assume that each subimage has the same
2167 dimensions as the base image. Handle disposal method that is
2168 "undefined" by the gif spec (Bug#9335).
2169
bd1ba3e8
CY
21702011-08-20 Chong Yidong <cyd@stupidchicken.com>
2171
2172 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2173 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2174
54a1215b
EZ
21752011-08-19 Eli Zaretskii <eliz@gnu.org>
2176
823564e5
EZ
2177 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2178 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2179 from an Org mode buffer to a Speedbar frame.
2180
54a1215b
EZ
2181 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2182 a composition, take its buffer position from IT->cmp_it.charpos.
2183 Fixes cursor positioning at the beginning of a line that begins
2184 with a composed character.
2185
9778ebcc
EZ
21862011-08-18 Eli Zaretskii <eliz@gnu.org>
2187
0be6ee06
EZ
2188 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2189 character bidirectional type, use STRONG_L instead. Fixes crashes
2190 in a buffer produced by `describe-categories'.
2191
9778ebcc
EZ
2192 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2193 members before the level stack, so they would be saved and
2194 restored when copying iterator state. Fixes incorrect reordering
2195 around TABs covered by display properties.
2196
156bffbe
AS
21972011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2198
6b02f655 2199 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2200
72ad093b
CY
22012011-08-17 Chong Yidong <cyd@stupidchicken.com>
2202
2203 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2204 (internal_condition_case_2, internal_condition_case_n):
2205 Remove unnecessary aborts (Bug#9081).
72ad093b 2206
35774242
EZ
22072011-08-17 Eli Zaretskii <eliz@gnu.org>
2208
2209 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2210 has no `load' handler, try opening the file locally. (Bug#9311)
2211
db76dd85
KB
22122011-08-16 Ken Brown <kbrown@cornell.edu>
2213
2214 * gmalloc.c: Expand comment.
2215
b215eee5
EZ
22162011-08-16 Eli Zaretskii <eliz@gnu.org>
2217
2218 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2219 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2220
a4579d33
KB
22212011-08-16 Ken Brown <kbrown@cornell.edu>
2222
2223 Fix memory allocation problems in Cygwin build (Bug#9273).
2224
2225 * unexcw.c ( __malloc_initialized): Declare external variable.
2226 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2227
8b76d6f8
SM
2228 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2229 New variables.
a4579d33
KB
2230 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2231 dumped emacs.
2232 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2233 in the static heap.
2234 [CYGWIN] (special_realloc): New function.
2235 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2236 requests to realloc storage in the static heap.
2237
3ebec551
PE
22382011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2239
2240 * bidi.c (bidi_initialize): Remove unused local.
2241
9fd8be00
EZ
22422011-08-15 Eli Zaretskii <eliz@gnu.org>
2243
6b02f655
SM
2244 * bidimirror.h:
2245 * biditype.h: Remove file.
2246 * makefile.w32-in ($(BLD)/bidi.$(O)):
2247 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2248
2249 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2250
2251 * chartab.c: Improve commentary for the uniprop_table API.
2252
32413314
EZ
2253 * bidi.c (bidi_paragraph_init): Support zero value of
2254 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2255 (bidi_initialize): Use uniprop_table instead of including
2256 biditype.h and bidimirror.h.
32413314 2257
9fd8be00
EZ
2258 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2259 coordinates of the iterator when restoring from ppos_it.
2260 (Bug#9296)
2261
5cf2b69b
KH
22622011-08-14 Kenichi Handa <handa@m17n.org>
2263
2264 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2265 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2266
daf17d00
EZ
22672011-08-14 Eli Zaretskii <eliz@gnu.org>
2268
2269 * xdisp.c (move_it_in_display_line_to): Don't invoke
2270 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2271 ppos_it. Fixes vertical cursor motion when line beginning is
2272 covered by an image. (Bug#9296)
2273
08e3161a
JD
22742011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2275
2276 * nsterm.h (ns_run_ascript): Declare.
2277 (NSAPP_DATA2_RUNASSCRIPT): Define.
2278
2279 * nsfns.m (as_script, as_result, as_status): New static variables.
2280 (ns_run_ascript): New function.
5e617bc2 2281 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2282 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2283 the event loop. Get status from as_status (Bug#7276).
2284
2285 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2286 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2287 the event loop (Bug#7276).
2288
a3720aa2
AS
22892011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2290
2291 * gnutls.c (QCgnutls_bootprop_priority)
2292 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2293 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2294 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2295 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2296 (QCgnutls_bootprop_verify_hostname_error)
2297 (QCgnutls_bootprop_callbacks_verify): Rename from
2298 Qgnutls_bootprop_..., all uses changed.
2299
2300 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2301 uses changed.
2302
0a0d27fb
PE
23032011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2304
19d5c50c
PE
2305 * xfaces.c (Qframe_set_background_mode): Now static.
2306 * dispextern.h (Qframe_set_background_mode): Remove decl.
2307
0a0d27fb
PE
2308 * process.c (Fnetwork_interface_info): Declare local only if needed.
2309
377538cb
JD
23102011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2311
2312 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2313 (Fnetwork_interface_list): Allocate in increments of bytes instead
2314 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2315 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2316 sockaddr.
2317 (struct ifflag_def): notrailers is smart on OSX.
2318 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2319 Get hardware address with getifaddrs if available.
2320
08fff70c
EZ
23212011-08-12 Eli Zaretskii <eliz@gnu.org>
2322
2323 * xdisp.c (iterate_out_of_display_property): xassert that
2324 IT->position is set to within IT->object's boundaries. Break from
2325 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2326 when IT->position is set up wrongly due to some bug.
2327 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2328 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2329 entry. Force push_it to save on the stack the current
2330 buffer/string position, to be restored by pop_it. Fix flags in
2331 the iterator structure wrt the object coming from a display
2332 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2333 properties. (Bug#9284)
2334
7be1c708 23352011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2336
7be1c708
CY
2337 * fontset.c (fontset_get_font_group): Add proper type checks.
2338 (Bug#9172)
aac0c6e3 2339
7be1c708 23402011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2341
7be1c708
CY
2342 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2343 and LC_VERSION_MIN_MACOSX.
2344 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2345 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2346
97bb72a6
EZ
23472011-08-08 Eli Zaretskii <eliz@gnu.org>
2348
2349 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2350 no-display-properties-and-no-overlays under bidi display.
2351 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2352 properties and overlays.
97bb72a6 2353
d5617611
CY
23542011-08-08 Chong Yidong <cyd@stupidchicken.com>
2355
37e11a63
CY
2356 * editfns.c (Fset_time_zone_rule): Document relationship with the
2357 setenv function.
2358
d5617611
CY
2359 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2360 the font entity extracted from the cache (Bug#8109).
2361
58872834
CY
23622011-08-07 Chong Yidong <cyd@stupidchicken.com>
2363
2364 * composite.c (autocmp_chars): Don't reset point. That is done by
2365 restore_point_unwind (Bug#5984).
2366
75bfc667
JL
23672011-08-07 Juri Linkov <juri@jurta.org>
2368
2369 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2370 to show the arg `TIME' instead of `TIMEVAL'.
2371
d1410150
EZ
23722011-08-06 Eli Zaretskii <eliz@gnu.org>
2373
2374 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2375 display property strides EOL and includes a newline, as in
2376 longlines-mode. (Bug#9254)
75b771e4
EZ
2377 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2378 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2379
2380 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2381 is non-zero, even if the data buffer is NULL. Fixes a crash in
2382 vertical-motion with longlines-mode. (Bug#9254)
2383
35928349
EZ
23842011-08-05 Eli Zaretskii <eliz@gnu.org>
2385
ec7cc85b
EZ
2386 * bidi.c <bidi_cache_total_alloc>: Now static.
2387 (bidi_initialize): Initialize bidi_cache_total_alloc.
2388
8b76d6f8 2389 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2390 cache. (Bug#9221)
2391
2392 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2393 amount allocated this far in `bidi_cache_total_alloc'.
2394 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2395 non-zero, only free the data buffer without restoring the cache
2396 contents. All callers changed.
2397
2398 * dispextern.h (bidi_unshelve_cache): Update prototype.
2399
2400 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2401 (move_it_in_display_line, move_it_to)
2402 (move_it_vertically_backward, move_it_by_lines): Replace the call
2403 to xfree to an equivalent call to bidi_unshelve_cache.
2404 (move_it_in_display_line_to): Fix logic of returning
412b6358 2405 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2406
e2e2423b
EZ
24072011-08-05 Eli Zaretskii <eliz@gnu.org>
2408
2409 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2410 came from a string character with a `cursor' property. (Bug#9229)
2411
ae9e757a
JD
24122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2413
2414 * Makefile.in (LIB_PTHREAD): New variable.
2415 (LIBES): Add LIB_PTHREAD (Bug#9216).
2416
2417 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2418 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2419
213bd7f2
AS
24202011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2421
6b02f655 2422 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2423
99aaf75f
JD
24242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2425
2426 * xterm.c (x_find_topmost_parent): New function.
2427 (x_set_frame_alpha): Find topmost parent window with
2428 x_find_topmost_parent and set the property there also (bug#9181).
2429 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2430
c74e9d86
PE
24312011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2432
2433 * callproc.c (Fcall_process): Avoid vfork clobbering
2434 the local vars buffer, coding_systems, current_dir.
2435
640c8776
SM
24362011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2437
2438 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2439
f26d0e4c
PE
24402011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2441
8a10d76c
PE
2442 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2443 so that it is not optimized away.
2444
f26d0e4c
PE
2445 * xdisp.c (compute_display_string_pos): Remove unused local.
2446
55439c61
EZ
24472011-08-02 Eli Zaretskii <eliz@gnu.org>
2448
2449 Fix slow cursor motion and scrolling in large buffers with
2450 selective display, like Org Mode buffers. (Bug#9218)
2451
2452 * dispextern.h (struct bidi_it): New member disp_prop_p.
2453
2454 * xdisp.c: Remove one-slot cache of display string positions.
2455 (compute_display_string_pos): Accept an additional argument
5e617bc2 2456 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2457 for a display string or property. If found, set DISP_PROP_P
2458 non-zero.
2459
2460 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2461 DISP_PROP_P, and pass it to compute_display_string_pos.
2462 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2463 non-zero. All callers of bidi_fetch_char changed.
2464
fb33fa43
SM
24652011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2466
2467 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2468
b099e063
DM
24692010-12-03 Don March <don@ohspite.net>
2470
2471 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2472 last character M-[char] is translated to ESC [char] (bug#7541).
2473
5cc7f7af
KH
24742011-08-02 Kenichi Handa <handa@m17n.org>
2475
d0fffa3f 2476 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2477
2478 * chartab.c (uniprop_table): Make it non-static.
2479
525d5e6e
EZ
24802011-08-01 Eli Zaretskii <eliz@gnu.org>
2481
2482 * xdisp.c (forward_to_next_line_start): Accept additional argument
2483 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2484 on the newline.
2485 (reseat_at_next_visible_line_start): Use the bidi iterator state
2486 returned by forward_to_next_line_start to restore the state of
2487 it->bidi_it after backing up to previous newline. (Bug#9212)
2488
31011111
AS
24892011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2490
2491 * regex.c (re_comp): Protoize.
2492 (re_exec): Fix return type.
2493 (regexec): Fix type of `ret'. (Bug#9203)
2494
476371c4
PE
24952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2496
e5d76069
PE
2497 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2498 This is needed if max-image-size is a floating-point number.
2499
9a79b20c
AS
25002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2501
2502 * print.c (print_object): Print empty symbol as ##.
2503
2504 * lread.c (read1): Read ## as empty symbol.
2505
d8c2fa78
AA
25062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2507
2508 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2509 setting frame foreground color (Bug#9175).
2510 (x_set_background_color): Likewise.
2511
ffe57a7a
AA
2512 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2513 contents (Bug#9176).
2514 (EmacsTooltip -init): Remove bezels and add shadows to
2515 tooltip windows.
2516
bf3492a5
AA
2517 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2518 or scroll bar (Bug#8470).
2519
d55e9c53
AA
2520 * nsfont.m (nsfont_open): Remove assignment to voffset and
2521 unnecessary vars hshink, expand, hd, full_height, min_height.
2522 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2523
2524 * nsterm.h (nsfont_info): Remove voffset field.
2525
d8c2fa78 25262011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2527
2528 Implement strike-through and overline on NextStep (Bug#8863).
2529
2530 * nsfont.m (nsfont_open): Use underline position provided by font,
2531 instead of hard-coded value of 2.
2532 (nsfont_draw): Call ns_draw_text_decoration instead.
2533
2534 * nsterm.h: Add declaration for ns_draw_text_decoration.
2535
2536 * nsterm.m (ns_draw_text_decoration): New function for drawing
2537 underline, overline, and strike-through.
2538 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2539 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2540 accommodate underlining, etc.
4843aac3 2541
4cc60b9b
EZ
25422011-07-28 Eli Zaretskii <eliz@gnu.org>
2543
bc7ece87
EZ
2544 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2545 default.
4cc60b9b 2546
476371c4
PE
25472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2548
66606eea
PE
2549 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2550 Without this fix, if a signal arrives just after memory fills up,
2551 'malloc' might be invoked reentrantly.
2552
476371c4
PE
2553 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2554 In other words, assume that every image size is allowed, on non-X
2555 hosts. This assumption is probably wrong, but it lets Emacs compile.
2556
f3fcc40d
AS
25572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2558
2559 * regex.c (re_iswctype): Convert return values to boolean.
2560
350c992f
EZ
25612011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2562
2563 * xdisp.c (compute_display_string_pos): Don't use cached display
2564 string position if the buffer had its restriction changed.
2565 (Bug#9184)
2566
5266b4bb
PE
25672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2568
2569 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2570
2573a837 25712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2572
41f55ccd 2573 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2574
39e378da
PE
2575 * bidi.c: Integer size and overflow fixes.
2576 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2577 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2578 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2579 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2580 (bidi_find_other_level_edge):
2581 Use ptrdiff_t instead of EMACS_INT where either will do.
2582 This works better on 32-bit hosts configured --with-wide-int.
2583 (bidi_cache_ensure_space): Check for size-calculation overflow.
2584 Use % rather than repeated addition, for better worst-case speed.
2585 Don't set bidi_cache_size until after xrealloc returns, because it
2586 might not return.
2587 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2588 (bidi_cache_ensure_space): Also check that the bidi cache size
2589 does not exceed that of the largest Lisp string or buffer. See Eli
2590 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2591
5e927815
PE
2592 * alloc.c (__malloc_size_t): Remove.
2593 All uses replaced by size_t. See Andreas Schwab's note
2594 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2595
ca4aa935
PE
2596 * image.c: Improve checking for integer overflow.
2597 (check_image_size): Assume that f is nonnull, since
2598 it is always nonnull in practice. This is one less thing to
2599 worry about when checking for integer overflow later.
2600 (x_check_image_size): New function, which checks for integer
2601 overflow issues inside X.
2602 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2603 This removes the need for a memory_full check.
2604 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2605 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2606 (xbm_read_bitmap_data): Change locals back to 'int', since
2607 their values must fit in 'int'.
2608 (xpm_load_image, png_load, tiff_load):
2609 Invoke x_create_x_image_and_pixmap earlier,
2610 to avoid much needless work if the image is too large.
2611 (tiff_load): Treat overly large images as if
2612 x_create_x_image_and_pixmap failed, not as malloc failures.
2613 (gs_load): Use x_check_image_size.
2614
5f8f9cc2
PE
2615 * gtkutil.c: Omit integer casts.
2616 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2617 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2618
5adf60bc
PE
2619 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2620
c8907a93
PE
2621 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2622 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2623 would wrongly return t on a 64-bit host.
2624
e3c25c68
PE
2625 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2626 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2627 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2628 and therefore cause GCC to emit a bogus diagnostic in some cases.
2629
3f791afe
PE
2630 * image.c: Integer signedness and overflow and related fixes.
2631 This is not an exhaustive set of fixes, but it's time to
2632 record what I've got.
2633 (lookup_pixel_color, check_image_size): Remove redundant decls.
2634 (check_image_size): Don't assume that arbitrary EMACS_INT values
2635 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2636 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2637 (tiff_load, imagemagick_load_image):
2638 Check for overflow in size calculations.
2639 (x_create_x_image_and_pixmap): Remove unnecessary test for
2640 xmalloc returning NULL; that can't happen.
2641 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2642 (xpm_color_bucket): Use better integer hashing function.
2643 (xpm_cache_color): Don't possibly over-allocate memory.
2644 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2645 (gif_memory_source):
2646 Use ptrdiff_t, not int or size_t, to record sizes.
2647 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2648 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2649 either works, as we prefer signed integers.
2650 (tiff_read_from_memory, tiff_write_from_memory):
2651 Return tsize_t, not size_t, since that's what the TIFF API wants.
2652 (tiff_read_from_memory): Don't fail simply because the read would
2653 go past EOF; instead, return a short read.
2654 (tiff_load): Omit no-longer-needed casts.
2655 (Fimagemagick_types): Don't assume size fits into 'int'.
2656
3cc5a532
PE
2657 Improve hashing quality when configured --with-wide-int.
2658 * fns.c (hash_string): New function, taken from sxhash_string.
2659 Do not discard information about ASCII character case; this
2660 discarding is no longer needed.
2661 (sxhash-string): Use it. Change sig to match it. Caller changed.
2662 * lisp.h: Declare it.
2663 * lread.c (hash_string): Remove, since we now use fns.c's version.
2664 The fns.c version returns a wider integer if --with-wide-int is
2665 specified, so this should help the quality of the hashing a bit.
2666
b312a492
PE
2667 * emacs.c: Integer overflow minor fix.
2668 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2669 Define only if GNU_LINUX.
2670 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2671
dfd153ae
PE
2672 * dispnew.c: Integer signedness and overflow fixes.
2673 Remove unnecessary forward decls, that were a maintenance hassle.
2674 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2675 All uses changed.
2676 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2677 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2678 (prepare_desired_row, line_draw_cost):
2679 Use int, not unsigned, where either works.
2680 (save_current_matrix, restore_current_matrix):
2681 Use ptrdiff_t, not size_t, where either works.
2682 (init_display): Check for overflow more accurately, and without
2683 relying on undefined behavior.
2684
a81d11a3
PE
2685 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2686 Remove, replacing with the new symbols in lisp.h. All uses changed.
2687 * fileio.c (make_temp_name):
2688 * filelock.c (lock_file_1, lock_file):
2689 * xdisp.c (message_dolog):
2690 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2691 Use pMd etc. instead.
2692 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2693 replacing the pWIDE etc. symbols removed from editfns.c.
2694
3300e6fd
PE
2695 * keyboard.h (num_input_events): Now uintmax_t.
2696 This is (very slightly) less likely to mess up due to wraparound.
2697 All uses changed.
2698
fd05c7e9
PE
2699 * buffer.c: Integer signedness fixes.
2700 (alloc_buffer_text, enlarge_buffer_text):
2701 Use ptrdiff_t rather than size_t when either will do, as we prefer
2702 signed integers.
2703
903fe15d
PE
2704 * alloc.c: Integer signedness and overflow fixes.
2705 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2706 (__malloc_size_t): Default to size_t, not to int.
2707 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2708 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2709 Prefer ptrdiff_t to size_t when either would do, as we prefer
2710 signed integers.
2711 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2712 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2713 Now const. Initialize with values that are in range even if char
2714 is signed.
2715 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2716 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2717 These functions do the right thing with sizes > 2**32.
2718 (check_depth): Now ptrdiff_t, not int.
2719 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2720 Adjust to new way of storing sizes. Check for size overflow bugs
2721 in rest of code.
2722 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2723 slightly wrong anyway, as it missed one instance of
2724 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2725 (refill_memory_reserve): Omit needless cast to size_t.
2726 (mark_object_loop_halt): Mark as externally visible.
2727
ac82cc6a
PE
2728 * xselect.c: Integer signedness and overflow fixes.
2729 (Fx_register_dnd_atom, x_handle_dnd_message):
2730 Use ptrdiff_t, not size_t, since we prefer signed.
2731 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2732 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2733 x_dnd_atoms_size and x_dnd_atoms_length.
2734
c2d1e36d
PE
2735 * doprnt.c: Prefer signed to unsigned when either works.
2736 * eval.c (verror):
2737 * doprnt.c (doprnt):
2738 * lisp.h (doprnt):
2739 * xdisp.c (vmessage):
2740 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2741 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2742 prefer signed arithmetic to avoid comparison confusion.
2743 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2744 but is a bit tricky.
2745
0e926e56
PE
2746 Assume freestanding C89 headers, string.h, stdlib.h.
2747 * data.c, doprnt.c, floatfns.c, print.c:
2748 Include float.h unconditionally.
2749 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2750 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2751 * regex.c: Likewise for stddef.h, string.h.
2752 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2753 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2754 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2755 (STDC_HEADERS): Remove obsolete defines.
2756 * sysdep.c: Include limits.h unconditionally.
2757
9cfdb3ec
PE
2758 Assume support for memcmp, memcpy, memmove, memset.
2759 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2760 * regex.c (memcmp, memcpy):
2761 Remove; we assume C89 now.
2762
2763 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2764 (__malloc_safe_bcopy): Remove; no longer needed.
2765
cf950e6b 2766 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2767 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2768 well either way, and we prefer signed to unsigned.
2769
dbf38e02
LMI
27702011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2771
2772 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2773 closes the connection while we're reading (bug#9182).
2774
d6f0886c 27752011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2776
d6f0886c
JD
2777 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2778 are specified (Bug#9168).
24e0f6b1 2779
2eb1f9e6
PE
27802011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2781
2782 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2783 Found by GCC static checking and --with-wide-int on a 32-bit host.
2784
22381272 27852011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2786
2787 * xdisp.c (compute_display_string_pos): Fix logic of caching
2788 previous display string position. Initialize cached_prev_pos to
2789 -1. Fixes slow-down at the beginning of a buffer.
2790
f25e39b4
EZ
27912011-07-24 Eli Zaretskii <eliz@gnu.org>
2792
2793 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2794 for attrs[LFACE_FONTSET_INDEX].
2795
04c4b52e
PE
27962011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2797
2798 * xml.c (parse_region): Remove unused local
2799 that was recently introduced.
2800
c1734fbd
EZ
28012011-07-23 Eli Zaretskii <eliz@gnu.org>
2802
be18c5a5
EZ
2803 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2804 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2805
c1734fbd
EZ
2806 * xdisp.c (move_it_in_display_line_to): Record the best matching
2807 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2808 exit if none of the characters scanned was an exact match.
2809 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2810 when exact match is impossible due to invisible text, and the
2811 lines are truncated.
2812
a258d627
JD
28132011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2814
2815 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2816 for OSX >= 10.7.
2817
b6d5a689
EZ
28182011-07-22 Eli Zaretskii <eliz@gnu.org>
2819
0f74f785
EZ
2820 Fix a significant slow-down of cursor motion with C-n, C-p,
2821 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2822 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2823 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2824 (next_element_from_buffer): Call compute_stop_pos_backwards to
2825 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2826 base_level_stop.
2827 (reseat): Don't look for prev_stop, as that could mean a very long
2828 run.
2829 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2830 <cached_disp_overlay_modiff>: Cache for last found display string
2831 position.
551918c1 2832 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2833 about the same buffer in the same area of character positions, and
2834 the buffer wasn't changed since the time the display string
2835 position was cached.
551918c1 2836
b2d0c91a
EZ
28372011-07-22 Eli Zaretskii <eliz@gnu.org>
2838
2839 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2840 is an integer, which is important for empty lines. (Bug#9149)
2841
043604ee
CY
28422011-07-22 Chong Yidong <cyd@stupidchicken.com>
2843
2844 * frame.c (Fmodify_frame_parameters): In tty case, update the
2845 default face if necessary (Bug#4238).
2846
da4adb04
CY
28472011-07-21 Chong Yidong <cyd@stupidchicken.com>
2848
2849 * editfns.c (Fstring_to_char): No need to explain what a character
2850 is in the docstring (Bug#6576).
2851
9abd0532
LMI
28522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2853
2854 * xml.c (parse_region): Make sure we always return a tree.
2855
36881d16
HK
28562011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2857
2858 * xml.c (parse_region): If a document contains only comments,
2859 return that, too.
2860
1e98674d
LMI
28612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2862
2863 * xml.c (make_dom): Return comments, too.
2864
590bd467
PE
28652011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2866
2867 Port to OpenBSD.
2868 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2869 and the surrounding thread.
2870 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2871 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2872 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2873 timer goes off.
2874 * s/openbsd.h (BROKEN_SIGIO): Define.
2875 * unexelf.c (unexec) [__OpenBSD__]:
2876 Don't update the .mdebug section of the Alpha COFF symbol table.
2877
f41628b2
LMI
28782011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2879
2880 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2881 (bug#8460).
2882
b59b67c5
PE
28832011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2884
15e3a074
PE
2885 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2886 This fixes some race conditions on the permissions of any newly
2887 created file.
2888
41bed37d
PE
2889 * alloc.c (valid_pointer_p): Use pipe, not open.
2890 This fixes some permissions issues when debugging.
2891
b59b67c5
PE
2892 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2893 If fchown fails to set both uid and gid, try to set just gid,
2894 as that is sometimes allowed. Adjust the file's mode to eliminate
2895 setuid or setgid bits that are inappropriate if fchown fails.
2896
925a6be7
SM
28972011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2898
2899 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2900 to compare Lisp_Objects.
2901 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2902 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2903 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2904
52968808
AS
29052011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2906
0a6a104b
AS
2907 * lread.c (read_integer): Unread even EOF character.
2908 (read1): Likewise. Properly record start position of symbol.
2909
52968808
AS
2910 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2911 symbol character follows.
2912
9e381cdd
PE
29132011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2914
2915 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2916 This works around a problem with the previous change to Fcopy_file.
2917 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2918 and without this change, GCC might complain about discarding
2919 fchown's return value.
2920
b5641435
JB
29212011-07-16 Juanma Barranquero <lekktu@gmail.com>
2922
2923 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2924
a8031457
PE
29252011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2926
2927 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2928
dd889327
LMI
29292011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2930
750c33f7
LMI
2931 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2932 it's used from the C level.
2933
dd889327
LMI
2934 * process.c: Use the same condition for POLL_FOR_INPUT in both
2935 keyboard.c and process.c (bug#1858).
2936
87e86684
LM
29372011-07-09 Lawrence Mitchell <wence@gmx.li>
2938
2939 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2940 (Fgnutls_boot): Use it.
2941
64348f40
AS
29422011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2943
2944 * doc.c (Fsubstitute_command_keys): Revert last change.
2945
1d698799
LMI
29462011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2947
f863868c
LMI
2948 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2949 quotes the next character, and doesn't affect other longer
2950 sequences (bug#8935).
2951
1d698799
LMI
2952 * lread.c (syms_of_lread): Clarify that is isn't only
2953 `eval-buffer' and `eval-defun' that's affected by
2954 `lexical-binding' (bug#8460).
2955
aa4b6df6
EZ
29562011-07-15 Eli Zaretskii <eliz@gnu.org>
2957
2958 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2959 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2960
5d856da6
PE
29612011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2962
ad6042bb
PE
2963 Fix minor problems found by static checking.
2964 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2965 (elsz): Now a signed constant, not a size_t var. We prefer signed
2966 types to unsigned, to avoid integer comparison confusion. Without
2967 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2968 "cannot optimize loop, the loop counter may overflow", a symptom
2969 of the confusion.
f00bbb22 2970 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2971 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2972
6468f31c
LMI
29732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2974
49080b10
LMI
2975 * search.c (Fre_search_backward): Mention `case-fold-search' in
2976 all the re_search_* functions (bug#8138).
2977
6468f31c
LMI
2978 * keyboard.c (Fopen_dribble_file): Document when the file is
2979 closed (bug#8056).
2980
c965adc5
EZ
29812011-07-14 Eli Zaretskii <eliz@gnu.org>
2982
df9733bf
EZ
2983 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2984 bidi_cache_idx.
2985
0bb23927
EZ
2986 Support bidi reordering of display and overlay strings.
2987 * xdisp.c (compute_display_string_pos)
2988 (compute_display_string_end): Accept additional argument STRING.
2989 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2990 (reseat_to_string): Initialize bidi_it->string.s and
2991 bidi_it->string.schars.
2992 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2993 NULL (avoids a crash in bidi_paragraph_init).
2994 Initialize itb.string.lstring.
0bb23927
EZ
2995 (init_iterator): Call bidi_init_it only of a valid
2996 buffer position was specified. Initialize paragraph_embedding to
2997 L2R.
2998 (reseat_to_string): Initialize the bidi iterator.
2999 (display_string): If we need to ignore text properties of
3000 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3001 original value of -1 will not work with bidi.)
3002 (compute_display_string_pos): First arg is now struct
3003 `text_pos *'; all callers changed. Support display properties on
3004 Lisp strings.
3005 (compute_display_string_end): Support display properties on Lisp
3006 strings.
3007 (init_iterator, reseat_1, reseat_to_string): Initialize the
3008 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3009 when iterating on a string not from display properties).
640c8776
SM
3010 (compute_display_string_pos, compute_display_string_end):
3011 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3012 arrow keys.
3013 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3014 base_level_stop; instead, set base_level_stop to BEGV.
3015 Fixes crashes in vertical-motion.
0bb23927
EZ
3016 (next_element_from_buffer): Improve commentary for when
3017 the iterator is before prev_stop.
3018 (init_iterator): Initialize bidi_p from the default value of
3019 bidi-display-reordering, not from buffer-local value. Use the
3020 buffer-local value only if initializing for buffer iteration.
3021 (handle_invisible_prop): Support invisible properties on strings
3022 that are being bidi-reordered.
3023 (set_iterator_to_next): Support bidi reordering of C strings and
3024 Lisp strings.
3025 (next_element_from_string): Support bidi reordering of Lisp
3026 strings.
3027 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3028 (display_string): Support display of R2L glyph rows.
3029 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3030 (init_iterator): Don't initialize it->bidi_p for strings
3031 here.
3032 (reseat_to_string): Initialize it->bidi_p for strings here.
3033 (next_element_from_string, next_element_from_c_string)
3034 (next_element_from_buffer): Add xassert's for correspondence
3035 between IT's object being iterated and it->bidi_it.string
3036 structure.
3037 (face_before_or_after_it_pos): Support bidi iteration.
3038 (next_element_from_c_string): Handle the case of the first string
3039 character that is not the first one in the visual order.
3040 (get_visually_first_element): New function, refactored from common
3041 parts of next_element_from_buffer, next_element_from_string, and
3042 next_element_from_c_string.
3043 (tool_bar_lines_needed, redisplay_tool_bar)
3044 (display_menu_bar): Force left-to-right direction. Add a FIXME
3045 comment for making that be controlled by a user option.
3046 (push_it, pop_it): Save and restore the state of the
3047 bidi iterator. Save and restore the bidi_p flag.
3048 (pop_it): Iterate out of display property for string iteration as
3049 well.
3050 (iterate_out_of_display_property): Support iteration over strings.
3051 (handle_single_display_spec): Set up it->bidi_it for iteration
3052 over a display string, and call bidi_init_it.
3053 (handle_single_display_spec, next_overlay_string)
3054 (get_overlay_strings_1, push_display_prop): Set up the bidi
3055 iterator for displaying display or overlay strings.
3056 (forward_to_next_line_start): Don't use the shortcut if
3057 bidi-iterating.
3058 (back_to_previous_visible_line_start): If handle_display_prop
3059 pushed the iterator stack, restore the internal state of the bidi
3060 iterator by calling bidi_pop_it same number of times.
3061 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3062 and we are bidi-iterating, don't decrement the iterator position;
3063 instead, set the first_elt flag in the bidi iterator, to produce
3064 the same effect.
3065 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3066 (push_display_prop): xassert that we are iterating a buffer.
3067 (push_it, pop_it): Save and restore paragraph_embedding member.
3068 (handle_single_display_spec, next_overlay_string)
3069 (get_overlay_strings_1, reseat_1, reseat_to_string)
3070 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3071 correctly. Don't assume unibyte strings are not bidi-reordered.
3072 (compute_display_string_pos)
3073 (compute_display_string_end): Fix handling the case of C string.
3074 (push_it, pop_it): Save and restore from_disp_prop_p.
3075 (handle_single_display_spec, push_display_prop): Set the
3076 from_disp_prop_p flag.
3077 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3078 (pop_it): Call iterate_out_of_display_property only if we are
3079 popping after iteration over a string that came from a display
3080 property. Fix a typo in popping stretch info. Add an assertion
3081 for verifying that the iterator position is in sync with the bidi
3082 iterator.
3083 (handle_single_display_spec, get_overlay_strings_1)
3084 (push_display_prop): Fix initialization of paragraph direction for
3085 string when that of the parent object is not yet determined.
3086 (reseat_1): Call bidi_init_it to resync the bidi
3087 iterator with IT's position. (Bug#7616)
3088 (find_row_edges): If ROW->start.pos gives position
3089 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3090 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3091 Reset the from_disp_prop_p flag.
3092 (SAVE_IT, RESTORE_IT): New macros.
3093 (pos_visible_p, face_before_or_after_it_pos)
3094 (back_to_previous_visible_line_start)
3095 (move_it_in_display_line_to, move_it_in_display_line)
3096 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3097 (try_scrolling, redisplay_window, display_line): Use them when
3098 saving a temporary copy of the iterator and restoring it back.
3099 (back_to_previous_visible_line_start, reseat_1)
3100 (init_iterator): Empty the bidi cache "stack".
3101 (move_it_in_display_line_to): If iterator ended up at
3102 EOL, but we never saw any buffer positions smaller than
3103 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3104 motion in bidi-reordered lines.
3105 (move_it_in_display_line_to): Record prev_method and prev_pos
3106 immediately before the call to set_iterator_to_next. Fixes cursor
3107 motion in bidi-reordered lines with stretch glyphs and strings
3108 displayed in margins. (Bug#8133) (Bug#8867)
3109 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3110 TO_CHARPOS.
640c8776
SM
3111 (pos_visible_p): Support positions in bidi-reordered lines.
3112 Save and restore bidi cache.
0bb23927
EZ
3113
3114 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3115 (bidi_paragraph_info): Delete unused struct.
3116 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3117 (bidi_cache_start): New variable.
3118 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3119 to zero.
3120 (bidi_cache_fetch_state, bidi_cache_search)
3121 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3122 (bidi_cache_find, bidi_peek_at_next_level)
3123 (bidi_level_of_next_char, bidi_find_other_level_edge)
3124 (bidi_move_to_visually_next): Compare cache index with
3125 bidi_cache_start rather than with zero.
3126 (bidi_fetch_char): Accept new argument STRING; all callers
3127 changed. Support iteration over a string. Support strings with
3128 display properties. Support unibyte strings. Fix the type of
3129 `len' according to what STRING_CHAR_AND_LENGTH expects.
3130 (bidi_paragraph_init, bidi_resolve_explicit_1)
3131 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3132 (bidi_level_of_next_char, bidi_move_to_visually_next):
3133 Support iteration over a string.
0bb23927
EZ
3134 (bidi_set_sor_type, bidi_resolve_explicit_1)
3135 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3136 can now be zero (for strings); special values 0 and -1 were
3137 changed to -1 and -2, respectively.
3138 (bidi_char_at_pos): New function.
3139 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3140 Call it instead of FETCH_MULTIBYTE_CHAR.
3141 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3142 initialized to valid values.
3143 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3144 values.
3145 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3146 the test for valid cached positions. Fix the logic for looking up
3147 the sentinel state in the cache. GCPRO the Lisp string we are
3148 iterating.
3149 (bidi_push_it, bidi_pop_it): New functions.
3150 (bidi_initialize): Initialize the bidi cache start stack pointer.
3151 (bidi_cache_ensure_space): New function, refactored from part of
3152 bidi_cache_iterator_state. Don't assume the required size is just
3153 one BIDI_CACHE_CHUNK away.
3154 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3155 (bidi_count_bytes, bidi_char_at_pos): New functions.
3156 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3157 always valid if bidi_cache_idx is valid.
3158 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3159 is valid if it's going to be used.
3160 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3161 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3162 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3163 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3164 (bidi_find_other_level_edge, bidi_cache_start_stack):
3165 All variables related to cache indices are now EMACS_INT.
c965adc5 3166
0bb23927
EZ
3167 * dispextern.h (struct bidi_string_data): New structure.
3168 (struct bidi_it): New member `string'. Make flag members be 1-bit
3169 fields, and put them last in the struct.
640c8776
SM
3170 (compute_display_string_pos, compute_display_string_end):
3171 Update prototypes.
0bb23927
EZ
3172 (bidi_push_it, bidi_pop_it): Add prototypes.
3173 (struct iterator_stack_entry): New members bidi_p,
3174 paragraph_embedding, and from_disp_prop_p.
3175 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3176 (bidi_shelve_cache, bidi_unshelve_cache):
3177 Declare prototypes.
0bb23927
EZ
3178
3179 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3180 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3181 and vector-like objects.
3182
3183 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3184 cache around display iteration.
3185
3186 * window.c (Fwindow_end, window_scroll_pixel_based)
3187 (displayed_window_lines, Frecenter): Save and restore the bidi
3188 cache around display iteration.
3189
3bbd2265
LMI
31902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3191
3192 * editfns.c (Fdelete_region): Clarify the use of the named
3193 parameters (bug#6788).
3194
adc47434
MR
31952011-07-14 Martin Rudalics <rudalics@gmx.at>
3196
3197 * indent.c (Fvertical_motion): Set and restore w->pointm when
3198 saving and restoring the window's buffer (Bug#9006).
3199
837c31f8
LMI
32002011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3201
3202 * editfns.c (Fstring_to_char): Clarify just what is returned
3203 (bug#6576). Text by Eli Zaretskii.
3204
ac389d0c
JB
32052011-07-13 Juanma Barranquero <lekktu@gmail.com>
3206
3207 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3208
0be0ce47
EZ
32092011-07-13 Eli Zaretskii <eliz@gnu.org>
3210
3211 * buffer.c (mmap_find): Fix a typo.
3212
cd18e7e3
JB
32132011-07-13 Johan Bockgård <bojohan@gnu.org>
3214
3215 Fix execution of x selection hooks.
3216 * xselect.c (Qx_lost_selection_functions)
3217 (Qx_sent_selection_functions): New vars.
3218 (syms_of_xselect): DEFSYM them.
3219 (x_handle_selection_request): Pass Qx_sent_selection_functions
3220 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3221 (x_handle_selection_clear,x_clear_frame_selections):
3222 Pass Qx_lost_selection_functions rather than
3223 Vx_lost_selection_functions to Frun_hook_with_args.
3224
47ea7f44
PE
32252011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3226
ac389d0c 3227 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3228 The old code sometimes used this field without initializing it.
3229
47ea7f44
PE
3230 * alloc.c (gc_sweep): Don't read past end of array.
3231 In theory, the old code could also have corrupted Emacs internals,
3232 though it'd be very unlikely.
3233
bc985c87
AS
32342011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3235
3236 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3237 argument. (Bug#4026)
bc985c87 3238
0cf34688
LMI
32392011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3240
b3dadd76
LMI
3241 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3242 key" (bug#4257).
3243
0cf34688
LMI
3244 * window.c (Fset_window_start): Doc fix (bug#4199).
3245 (Fset_window_hscroll): Ditto.
3246
270768cd
PE
32472011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3248
077e3dda 3249 Fix minor new problems caught by GCC 4.6.1.
270768cd 3250 * term.c (init_tty): Remove unused local.
490011a6 3251 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3252 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3253 not used otherwise.
270768cd 3254
b1f58454
CY
32552011-07-12 Chong Yidong <cyd@stupidchicken.com>
3256
3257 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3258
22b9578d
LMI
32592011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3260
6e70ab07
LMI
3261 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3262 are the mini-buffer and the echo area (bug#3320).
3263
22b9578d
LMI
3264 * term.c (init_tty): Remove support for supdup, c10 and perq
3265 terminals, which are no longer supported (bug#1482).
3266
8974cc9f
JB
32672011-07-10 Johan Bockgård <bojohan@gnu.org>
3268
3269 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3270
a560d974
JD
32712011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3272
3273 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3274 for non-popups (Bug#3642).
3275
1dae0f0a
AS
32762011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3277
268c2c36 3278 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3279 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3280 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3281 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3282 * data.c (fmod): Likewise.
3283 * dispnew.c (swap_glyphs_in_rows): Likewise.
3284 * emacs.c (memory_warning_signal): Likewise.
3285 * floatfns.c (float_error): Likewise.
3286 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3287 (otf_open, font_otf_capability, generate_otf_features)
3288 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3289 Likewise.
3290 * image.c (pbm_read_file): Likewise.
3291 * indent.c (string_display_width): Likewise.
3292 * intervals.c (check_for_interval, search_for_interval)
3293 (inc_interval_count, count_intervals, root_interval)
3294 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3295 * lread.c (defalias): Likewise.
268c2c36 3296 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3297 * regex.c (set_image_of_range_1, set_image_of_range)
3298 (regex_grow_registers): Likewise.
3299 * sysdep.c (strerror): Likewise.
3300 * termcap.c (valid_filename_p, tprint, main): Likewise.
3301 * tparam.c (main): Likewise.
3302 * unexhp9k800.c (run_time_remap, save_data_space)
3303 (update_file_ptrs, read_header, write_header, calculate_checksum)
3304 (copy_file, copy_rest, display_header): Likewise.
3305 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3306 Likewise.
3307 * xdisp.c (check_it): Likewise.
3308 * xfaces.c (register_color, unregister_color, unregister_colors):
3309 Likewise.
3310 * xfns.c (print_fontset_result): Likewise.
3311 * xrdb.c (member, fatal, main): Likewise.
3312
99033785
PE
33132011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3314
3315 Fix minor problems found by static checking (Bug#9031).
3316 * chartab.c (char_table_set_range, map_sub_char_table):
3317 Remove unused locals.
3318 (uniprop_table): Now static.
3319 * composite.c (_work_char): Remove unused static var.
3320
9cb2ac56
JB
33212011-07-09 Juanma Barranquero <lekktu@gmail.com>
3322
3323 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3324
f25661f0
JD
33252011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3326
3327 * gtkutil.c (qttip_cb): Remove code without function.
3328
8278c4fe
EZ
33292011-07-09 Eli Zaretskii <eliz@gnu.org>
3330
3331 * w32.c (pthread_sigmask): New stub.
3332
1692ae2d 33332011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3334
8a6ebd58 3335 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3336 sigprocmask is portable only for single-threaded applications, and
3337 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3338 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3339 (LIBES): Use it.
3340 * callproc.c (Fcall_process):
3341 * process.c (create_process):
3342 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3343 Use pthread_sigmask, not sigprocmask.
123403e4 3344
1b854618
JD
33452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3346
3347 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3348 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3349 wrong (Bug#8591).
3350
3fe4b549
JD
33512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3352
0ce7e563
JD
3353 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3354 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3355 (xg_hide_tooltip): Fix comment.
3356
3fe4b549
JD
3357 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3358 in registerServicesMenuSendTypes.
3359 (validRequestorForSendType): Don't check ns_return_types.
3360
3361 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3362 ns_return_type.
3363
5df75e47
JR
33642011-07-08 Jason Rumney <jasonr@gnu.org>
3365
22610910
JR
3366 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3367 SH_SHOW for hidden windows (Bug#5482).
3368
5df75e47
JR
3369 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3370 frame struct members of non-existent frames (Bug#6284).
3371
699c10bd
JD
33722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3373
4393663b
JD
3374 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3375 variable firstTime not needed on OSX >= 10.6.
3376 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3377 >= 10.5. Use setKnobProportion, setDoubleValue.
3378
3379 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3380 (MAC_OS_X_VERSION_10_5): Define if not defined.
3381 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3382 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3383 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3384
3385 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3386 cString and lossyCString on OSX >= 10.4
3387
58179cce 3388 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3389 sizeToFit on OSX >= 10.2.
3390
3391 * nsimage.m (allocInitFromFile): Don't use deprecated method
3392 bestRepresentationForDevice on OSX >= 10.6.
3393
3394 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3395 to avoid warning.
3396
3397 * emacs.c: Declare unexec_init_emacs_zone.
3398
a63e0781
JD
3399 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3400
699c10bd
JD
3401 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3402
3403 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3404 on svcsMenu (Bug#8842).
3405
3406 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3407 ns_return_types.
3408 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3409
3410 * nsterm.m (QUTF8_STRING): Declare.
3411 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3412 (validRequestorForSendType): Return type is (id).
3413 Change indexOfObjectIdenticalTo to indexOfObject.
3414 Check if we have local selection before returning self (Bug#8842).
3415 (writeSelectionToPasteboard): Put local selection into paste board
3416 if we have a local selection (Bug#8842).
3417 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3418
3419 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3420 (ns_get_local_selection): Declare.
3421
54e10184
LMI
34222011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3423
9888ff71
LMI
3424 * keymap.c (describe_map_tree): Don't insert a double newline at
3425 the end of the buffer (bug#1169) and return whether we inserted
3426 something.
3427
54e10184
LMI
3428 * callint.c (Fcall_interactively): Change "reading args" to
3429 "providing args" to try to clarify what it does (bug#1010).
3430
15fa4783
KH
34312011-07-07 Kenichi Handa <handa@m17n.org>
3432
3433 * composite.c (composition_compute_stop_pos): Ignore a static
3434 composition starting before CHARPOS (Bug#8915).
3435
3436 * xdisp.c (handle_composition_prop): Likewise.
3437
a8815b00
EZ
34382011-07-07 Eli Zaretskii <eliz@gnu.org>
3439
3440 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3441 (Bug#9015)
3442
ef7b981d 34432011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3444
3445 * character.h (unicode_category_t): New enum type.
3446
3447 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3448 (Qchar_code_property_table): New variable.
3449 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3450 (UNIPROP_COMPRESSED_FORM_P): New macros.
3451 (char_table_ascii): Uncompress the compressed values.
3452 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3453 Uncompress the compressed values.
ac389d0c 3454 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3455 (char_table_ref_and_range): Uncompress the compressed values.
3456 (sub_char_table_set): New arg is_uniprop. Callers changed.
3457 Uncompress the compressed values.
3458 (sub_char_table_set_range): Args changed. Callers changed.
3459 (char_table_set_range): Adjuted for the above change.
3460 (map_sub_char_table): Delete args default_val and parent. Add arg
3461 top. Give decoded values to a Lisp function.
640c8776 3462 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3463 values to a Lisp function. Gcpro more variables.
3464 (uniprop_table_uncompress)
3465 (uniprop_decode_value_run_length): New functions.
3466 (uniprop_decoder, uniprop_decoder_count): New variables.
3467 (uniprop_get_decoder, uniprop_encode_value_character)
3468 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3469 New functions.
3470 (uniprop_encoder, uniprop_encoder_count): New variables.
3471 (uniprop_get_encoder, uniprop_table)
3472 (Funicode_property_table_internal, Fget_unicode_property_internal)
3473 (Fput_unicode_property_internal): New functions.
3474 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3475 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3476 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3477 char-code-property-alist.
3478
640c8776 3479 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3480 Vunicode_category_table.
3481
640c8776 3482 * font.c (font_range): Adjust for the change of
c805dec0
KH
3483 Vunicode_category_table.
3484
76b397fb
DN
34852011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3486
3487 * m/iris4d.h: Remove file, move contents ...
3488 * s/irix6-5.h: ... here.
3489
22b4128e
PE
34902011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3491
3492 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3493 * alloc.c (mark_buffer):
3494 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3495 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3496 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3497 This isn't true in general, and it's particularly not true
3498 if Emacs is configured with --with-wide-int.
3499 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3500 New macros, used in the buffer.c change.
3501
869795d6
JD
35022011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3503
3504 * xsettings.c: Use both GConf and GSettings if both are available.
3505 (store_config_changed_event): Add comment.
3506 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3507 (store_tool_bar_style_changed): New functions.
5e617bc2 3508 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3509 (struct xsettings): Move font inside HAVE_XFT.
3510 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3511 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3512 Move inside HAVE_XFT.
640c8776 3513 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3514 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3515 also.
3516 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3517 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3518 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3519 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3520 (parse_settings): Move check for font inside HAVE_XFT.
3521 (read_settings, apply_xft_settings): Add comment.
3522 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3523 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3524 call store_font_name_changed.
3525 (xft_settings_event): Add comment.
3526 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3527 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3528 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3529 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3530 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3531 (xsettings_get_system_font, xsettings_get_system_normal_font):
3532 Add comment.
869795d6 3533
d8ed26bd
PE
35342011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3535
3536 Random fixes. E.g., (random) never returned negative values.
3537 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3538 subseconds part to the entropy, as that's a bit more random.
3539 Prefer signed to unsigned, since the signedness doesn't matter and
3540 in general we prefer signed. When given a limit, use a
3541 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3542 latter isn't right if USE_2_TAGS_FOR_INTS.
3543 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3544 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3545
cabf1cac
SM
35462011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3547
3548 * textprop.c (text_property_stickiness):
3549 Obey Vtext_property_default_nonsticky.
3550 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3551 * w32fns.c (syms_of_w32fns):
3552 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3553
6e9b2be9
PE
35542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3555
3556 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3557 This is more efficient than Ffile_directory_p and avoids a minor race.
3558
90186c68
LMI
35592011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3560
7c301272
LMI
3561 * buffer.c (Foverlay_put): Say what the return value is
3562 (bug#7835).
3563
c4f2d8d4
LMI
3564 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3565 is a directory before asking whether to use the file name
3566 (bug#7564).
ad637907
LMI
3567 (barf_or_query_if_file_exists): Make the "File is a directory"
3568 error be more correct.
c4f2d8d4 3569
90186c68
LMI
3570 * fns.c (Frequire): Remove the mention of the .gz files, since
3571 that's installation-specific, but keep the mention of
3572 `get-load-suffixes'.
3573
da64016e
PE
35742011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3575
3576 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3577 Report string overflow if the output is too long.
3578
7d47b580
JB
35792011-07-04 Juanma Barranquero <lekktu@gmail.com>
3580
a555cb87
JB
3581 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3582 (syms_of_gnutls): Remove duplicate DEFSYM for
3583 Qgnutls_bootprop_verify_hostname_error, an error for
3584 Qgnutls_bootprop_verify_error (which is no longer used).
3585
7d47b580
JB
3586 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3587 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3588 Also (re)move comments that are misplaced or no longer relevant.
3589
1e49bfab
LMI
35902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3591
3592 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3593
1485f4c0
CY
35942011-07-03 Chong Yidong <cyd@stupidchicken.com>
3595
3596 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3597 and background color parameters if they have been changed.
3598
a9ab721e
LMI
35992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3600
3601 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3602
cf7cff57
PE
36032011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3604
2e13213d
PE
3605 * xsettings.c (SYSTEM_FONT): Define only when used.
3606 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3607
cf7cff57
PE
3608 * keymap.c (access_keymap_1): Now static.
3609
7a8e04f7
CY
36102011-07-02 Chong Yidong <cyd@stupidchicken.com>
3611
3612 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3613 leave any prefix arg for the up event (Bug#1586).
3614
61352f62
LMI
36152011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3616
69bb1ef7
LMI
3617 * lread.c (syms_of_lread): Mention single symbols defined by
3618 `defvar' or `defconst' (bug#7154).
3619
61352f62 3620 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3621 (Frequire): Mention get-load-suffixes.
61352f62 3622
28545e04
MR
36232011-07-02 Martin Rudalics <rudalics@gmx.at>
3624
3625 * window.h (window): Remove clone_number slot.
3626 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3627 Remove.
3628 (make_parent_window, make_window, saved_window)
3629 (Fset_window_configuration, save_window_save): Don't deal with
3630 clone numbers.
3631 * buffer.c (Qclone_number): Remove declaration.
3632 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3633
3349e122
SM
36342011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3635
3636 Add multiple inheritance to keymaps.
3637 * keymap.c (Fmake_composed_keymap): New function.
3638 (Fset_keymap_parent): Simplify.
3639 (fix_submap_inheritance): Remove.
3640 (access_keymap_1): New function extracted from access_keymap to handle
3641 embedded parents and handle lists of maps.
3642 (access_keymap): Use it.
3643 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3644 (Fcopy_keymap): Handle embedded parents.
3645 (Fcommand_remapping, define_as_prefix): Simplify.
3646 (Fkey_binding): Simplify.
3647 (syms_of_keymap): Move minibuffer-local-completion-map,
3648 minibuffer-local-filename-completion-map,
3649 minibuffer-local-must-match-map, and
3650 minibuffer-local-filename-must-match-map to Elisp.
3651 (syms_of_keymap): Defsubr make-composed-keymap.
3652 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3653 (parse_menu_item): Trivial simplification.
3654
3279eb87
GM
36552011-07-01 Glenn Morris <rgm@gnu.org>
3656
3657 * Makefile.in (SETTINGS_LIBS): Fix typo.
3658
4550efdf
KI
36592011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3660
3661 * coding.c (Fencode_coding_string): Record the last coding system
3662 used, as the function doc string says (bug#8738).
3663
0949d2b6
JD
36642011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3665
3666 * xsettings.c (store_monospaced_changed): Take new font as arg and
3667 check for change against current_mono_font.
3668 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3669 (emacs_settings_constructor, emacs_settings_get_property)
3670 (emacs_settings_set_property, emacs_settings_class_init)
3671 (emacs_settings_init, gsettings_obj): Remove.
3672 (something_changedCB): New function for HAVE_GSETTINGS.
3673 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3674 with value as argument.
3675 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3676 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3677 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3678 "changed".
3679
3680 * xgselect.c: Add defined (HAVE_GSETTINGS).
3681 (xgselect_initialize): Ditto.
3682
3683 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3684 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3685 xg_select.
3686
bbc6b304
PE
36872011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3688
3689 * eval.c (struct backtrace): Simplify and port the data structure.
3690 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3691 signed bit field, as this assumption is not portable and it makes
3692 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3693 "char debug_on_exit : 1" as this is not portable either; instead,
3694 use the portable "unsigned int debug_on_exit : 1". Remove unused
3695 member evalargs. Remove obsolete comments about cc bombing out.
3696
9851bfc5
JD
36972011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3698
51bb811f 3699 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3700 Let HAVE_GSETTINGS override HAVE_GCONF.
3701 (store_monospaced_changed): New function.
3702 (EMACS_SETTINGS): A new type derived from GObject to handle
3703 GSettings notifications.
3704 (emacs_settings_constructor, emacs_settings_get_property)
3705 (emacs_settings_set_property, emacs_settings_class_init):
3706 New functions.
3707 (gsettings_client, gsettings_obj): New variables.
3708 (GSETTINGS_SCHEMA): New define.
3709 (something_changedCB): Call store_monospaced_changed.
3710 (init_gsettings): New function.
3711 (xsettings_initialize): Call init_gsettings.
3712 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3713 to NULL.
3714
640c8776 3715 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3716 GCONF_CFLAGS/LIBS.
3717
5386012d
MR
37182011-06-29 Martin Rudalics <rudalics@gmx.at>
3719
3720 * window.c (resize_root_window, grow_mini_window)
3721 (shrink_mini_window): Rename Qresize_root_window to
3722 Qwindow_resize_root_window and Qresize_root_window_vertically to
3723 Qwindow_resize_root_window_vertically.
3724
f13e0b08
PE
37252011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3726
3727 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3728
94515237
JB
37292011-06-27 Juanma Barranquero <lekktu@gmail.com>
3730
3731 * makefile.w32-in: Redesign dependencies so they reflect more
3732 clearly which files are directly included by each source file,
3733 and not through other includes.
3734
e43b6e43
MR
37352011-06-27 Martin Rudalics <rudalics@gmx.at>
3736
3737 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3738 (sort_overlays, overlay_strings): When an overlay's clone number
3739 matches the window's clone number process the overlay even if
3740 the overlay's window property doesn't match the current window.
3741
d68443dc
MR
3742 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3743 (Fwindow_hchild): Rename to Fwindow_left_child.
3744 (Fwindow_next): Rename to Fwindow_next_sibling.
3745 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3746 (resize_window_check): Rename to window_resize_check.
3747 (resize_window_apply): Rename to window_resize_apply.
3748 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3749 (Fdelete_other_windows_internal, resize_frame_windows)
3750 (Fsplit_window_internal, Fdelete_window_internal)
3751 (grow_mini_window, shrink_mini_window)
3752 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3753
c7e73be5
JD
37542011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3755
3756 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3757 (emacs_fixed_set_min_size): Remove.
3758 (emacs_fixed_new): Take frame as argument.
3759
3760 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3761 (_EmacsFixedPrivate): Remove minwidth/height.
3762 Add struct frame *f.
3763 (emacs_fixed_init): Initialize priv->f.
3764 (get_parent_class, emacs_fixed_set_min_size): Remove.
3765 (emacs_fixed_new): Set priv->f to argument.
3766 (emacs_fixed_get_preferred_width)
3767 (emacs_fixed_get_preferred_height): Use min_width/height from
3768 frames size_hint to set minimum and natural (Bug#8919).
3769 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3770 and use min_width/height from frames size_hint to set
3771 min_width/height (Bug#8919).
3772
3773 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3774 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3775 Fix indentation.
c7e73be5 3776
cf99dcf8
EZ
37772011-06-26 Eli Zaretskii <eliz@gnu.org>
3778
3779 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3780 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3781 called at ZV.
3782
029529ac
CY
37832011-06-26 Chong Yidong <cyd@stupidchicken.com>
3784
3785 * process.c (wait_reading_process_output): Bypass select if
3786 waiting for a cell while ignoring keyboard input, and input is
3787 pending. Suggested by Jan Djärv (Bug#8869).
3788
7a7ef429
PE
37892011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3790
3791 Use gnulib's dup2 module instead of rolling our own.
3792 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3793
11fdef7d 37942011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3795
3796 * dispnew.c (scrolling_window): Before scrolling, turn off a
3797 mouse-highlight in the window being scrolled.
3798
cd3520a4
JB
37992011-06-24 Juanma Barranquero <lekktu@gmail.com>
3800
3801 Move DEFSYM to lisp.h and use everywhere.
3802
3803 * character.h (DEFSYM): Move declaration...
3804 * lisp.h (DEFSYM): ...here.
3805
3806 * gnutls.c:
3807 * minibuf.c:
3808 * w32menu.c:
3809 * w32proc.c:
3810 * w32select.c: Don't include character.h.
3811
3812 * alloc.c (syms_of_alloc):
3813 * buffer.c (syms_of_buffer):
3814 * bytecode.c (syms_of_bytecode):
3815 * callint.c (syms_of_callint):
3816 * casefiddle.c (syms_of_casefiddle):
3817 * casetab.c (init_casetab_once):
3818 * category.c (init_category_once, syms_of_category):
3819 * ccl.c (syms_of_ccl):
3820 * cmds.c (syms_of_cmds):
3821 * composite.c (syms_of_composite):
3822 * dbusbind.c (syms_of_dbusbind):
3823 * dired.c (syms_of_dired):
3824 * dispnew.c (syms_of_display):
3825 * doc.c (syms_of_doc):
3826 * editfns.c (syms_of_editfns):
3827 * emacs.c (syms_of_emacs):
3828 * eval.c (syms_of_eval):
3829 * fileio.c (syms_of_fileio):
3830 * fns.c (syms_of_fns):
3831 * frame.c (syms_of_frame):
3832 * fringe.c (syms_of_fringe):
3833 * insdel.c (syms_of_insdel):
3834 * keymap.c (syms_of_keymap):
3835 * lread.c (init_obarray, syms_of_lread):
3836 * macros.c (syms_of_macros):
3837 * msdos.c (syms_of_msdos):
3838 * print.c (syms_of_print):
3839 * process.c (syms_of_process):
3840 * search.c (syms_of_search):
3841 * sound.c (syms_of_sound):
3842 * syntax.c (init_syntax_once, syms_of_syntax):
3843 * terminal.c (syms_of_terminal):
3844 * textprop.c (syms_of_textprop):
3845 * undo.c (syms_of_undo):
3846 * w32.c (globals_of_w32):
3847 * window.c (syms_of_window):
3848 * xdisp.c (syms_of_xdisp):
3849 * xfaces.c (syms_of_xfaces):
3850 * xfns.c (syms_of_xfns):
3851 * xmenu.c (syms_of_xmenu):
3852 * xsettings.c (syms_of_xsettings):
3853 * xterm.c (syms_of_xterm): Use DEFSYM.
3854
4228cf16
TZ
38552011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3856
cd3520a4 3857 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3858
7fcccf1e
PE
38592011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3860
7efb4e0e
PE
3861 Integer and buffer overflow fixes (Bug#8873).
3862
ff5844ad
PE
3863 * print.c (printchar, strout): Check for string overflow.
3864 (PRINTPREPARE, printchar, strout):
3865 Don't set size unless allocation succeeds.
3866
90532f02
PE
3867 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3868 for sizes. Check for string overflow more accurately.
3869 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3870
6d84508d
PE
3871 * macros.c: Integer and buffer overflow fixes.
3872 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3873 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3874 Use ptrdiff_t, not int, for sizes.
3875 Don't increment bufsize until after realloc succeeds.
3876 Check for size-calculation overflow.
3877 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3878
437b2cb4
PE
3879 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3880
8b9ac8b4
PE
3881 * lread.c: Integer overflow fixes.
3882 (read_integer): Radix is now EMACS_INT, not int,
3883 to improve quality of diagnostics for out-of-range radices.
3884 Calculate buffer size correctly for out-of-range radices.
3885 (read1): Check for integer overflow in radices, and in
3886 read-circle numbers.
82cb60d3
PE
3887 (read_escape): Avoid int overflow.
3888 (Fload, openp, read_buffer_size, read1)
3889 (substitute_object_recurse, read_vector, read_list, map_obarray):
3890 Use ptrdiff_t, not int, for sizes.
3891 (read1): Use EMACS_INT, not int, for sizes.
20270765 3892 Check for size overflow.
8b9ac8b4 3893
7fcccf1e
PE
3894 * image.c (cache_image): Check for size arithmetic overflow.
3895
bfbbd7e7
PE
3896 * lread.c: Integer overflow issues.
3897 (saved_doc_string_size, saved_doc_string_length)
3898 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3899 Now ptrdiff_t, not int.
3900 (read1): Don't assume doc string length fits in int. Check for
3901 out-of-range doc string lengths.
3902 (read_list): Don't assume file position fits in int.
39019e54 3903 (read_escape): Check for hex character overflow.
bfbbd7e7 3904
4e323265
LL
39052011-06-22 Leo Liu <sdl.web@gmail.com>
3906
3907 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3908 Move to minibuffer.el.
3909
85fece3e
PE
39102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3911
20b84ce9 3912 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3913 The following patches are for when GLYPH_DEBUG && !XASSERT.
3914 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3915 * dispnew.c (flush_stdout):
3916 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3917 Mark as externally visible.
3918 * dispnew.c (check_window_matrix_pointers): Now static.
3919 * dispnew.c (window_to_frame_vpos):
3920 * xfns.c (unwind_create_frame):
3921 * xterm.c (x_check_font): Remove unused local.
3922 * scroll.c (CHECK_BOUNDS):
3923 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3924 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3925 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3926 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3927 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3928 Now static.
3929 (debug_method_add): Use va_list and vsprintf rather than relying
3930 on undefined behavior with wrong number of arguments.
3931 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3932 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3933 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3934 since we're not interested in debugging glyphs with old libraries.
3935 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3936 GCC 4.6.0's static checking.
3937
0766b489
PE
39382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3939
31fd4b32
PE
3940 Integer overflow and signedness fixes (Bug#8873).
3941 A few related buffer overrun fixes, too.
3942
b79e8648
PE
3943 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3944
0766b489
PE
3945 * dispextern.h (struct face.stipple):
3946 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3947 (x_bitmap_mask, x_allocate_bitmap_record)
3948 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3949 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3950 (x_create_bitmap_from_xpm_data):
3951 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3952 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3953 (.bitmaps_last):
3954 * xfaces.c (load_pixmap):
3955 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3956 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3957 (.bitmaps_last, struct x_output.icon_bitmap):
3958 Use ptrdiff_t, not int, for bitmap indexes.
3959 (x_allocate_bitmap_record): Check for size overflow.
3960 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3961
b081724f
PE
3962 Use ptrdiff_t, not int, for overlay counts.
3963 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3964 * editfns.c (overlays_around, get_pos_property):
3965 * textprop.c (get_char_property_and_overlay):
3966 * xdisp.c (next_overlay_change, note_mouse_highlight):
3967 * xfaces.c (face_at_buffer_position):
21514da7
PE
3968 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3969 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3970 (Fnext_overlay_change, Fprevious_overlay_change)
3971 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3972 Use ptrdiff_t, not int, for sizes.
21514da7 3973 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3974
3de73e5e
PE
3975 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3976
2606c57b
PE
3977 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3978 (x_session_initialize): Do not assume string length fits in int.
3979
aaafe47a
PE
3980 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3981 This is unlikely, but can occur if DPI is outlandish.
3982
2674ddc8 3983 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3984 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3985
28154962
PE
3986 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3987 * xrdb.c (magic_file_p, search_magic_path):
3988 Omit last arg SUFFIX; it was always 0. All callers changed.
3989 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3990
7de51af5
PE
3991 * xfont.c (xfont_match): Avoid need for strlen.
3992
25ed6cc3
PE
3993 * xfns.c: Don't assume strlen fits in int.
3994 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3995
4eab31dd
PE
3996 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3997 not unsigned long, as we prefer signed integers. All callers changed.
3998 Detect integer overflow in repeat count.
3999 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4000 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4001
171e2a58
PE
4002 * termcap.c: Don't assume sizes fit in int and never overflow.
4003 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4004 (gobble_line): Check for size-calculation overflow.
4005
ad39faca 4006 * minibuf.c (Fread_buffer):
6e5bb2dc 4007 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4008 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4009 Don't assume string length fits in int.
4010
52c61c22 4011 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4012 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4013
b5b8c9e5
PE
4014 * font.c: Don't assume string length fits in int.
4015 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4016 Use ptrdiff_t, not int.
ccd6111c
PE
4017 (font_intern_prop): Don't assume string length fits in int.
4018 Don't assume integer property fits in fixnum.
4019 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4020
882f0d81 4021 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4022 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4023 Reformulate so as not to need the command string.
4024 Invoke gzip -cd rather than gunzip, as it's more portable.
4025 (lock_info_type, lock_file_1, lock_file):
4026 Don't assume pid_t and time_t fit in unsigned long.
4027 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4028 (current_lock_owner): Prefer signed type for sizes.
4029 Use memcpy, not strncpy, where memcpy is what is really wanted.
4030 Don't assume (via atoi) that time_t and pid_t fit in int.
4031 Check for time_t and/or pid_t out of range, e.g., via a network share.
4032 Don't alloca where an auto var works fine.
4033
93f4cf88
PE
4034 * fileio.c: Fix some integer overflow issues.
4035 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4036 Don't assume string length fits in int.
4037 (directory_file_name): Don't assume string length fits in long.
4038 (make_temp_name): Don't assume pid fits in int, or that its print
4039 length is less than 20.
4040
f3e92b69
PE
4041 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4042
1bfdaf10
PE
4043 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4044
35016e9a
PE
4045 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4046
3d1e65a1
PE
4047 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4048 We prefer signed integers, even for size calculations.
4049
0b963a93
PE
4050 * emacs.c: Don't assume string length fits in 'int'.
4051 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4052 (main): Don't invoke strlen when not needed.
4053
573f4b54
PE
4054 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4055 (XD_DEBUG_MESSAGE): Don't waste a byte.
4056
989f33ba
PE
4057 * callproc.c (getenv_internal_1, getenv_internal)
4058 (Fgetenv_internal):
965d34eb
PE
4059 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4060
e4d29b33
PE
4061 * lread.c (invalid_syntax): Omit length argument.
4062 All uses changed. This doesn't fix a bug, but it simplifies the
4063 code away from its former Hollerith-constant appearance, and it's
4064 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4065 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4066
eb49b136
PE
4067 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4068 This didn't break anything, but it didn't help either.
4069 It's confusing to put a bogus integer in a place where the actual
4070 value does not matter.
9f62aeb1 4071 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4072 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4073
15375a22
PE
4074 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4075 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4076 implementation.
b61cc01c
PE
4077 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4078 We prefer signed types, and the value cannot exceed the EMACS_INT
4079 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4080 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4081 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4082 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4083
53b2623d
PE
4084 * indent.c (sane_tab_width): New function.
4085 (current_column, scan_for_column, Findent_to, position_indentation)
4086 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4087 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4088
51cab52b 4089 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4090
f2ed8a70
PE
4091 * lisp.h (lint_assume): New macro.
4092 * composite.c (composition_gstring_put_cache):
4093 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4094
abe80cc6
PE
4095 * editfns.c, insdel.c:
4096 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4097
b02c740e
PE
4098 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4099
ebc96716
PE
4100 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4101
b4e50fa0 4102 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4103 Use much-faster test for byte-length change.
311d5d7c 4104 Don't assume string byte-length fits in 'int'.
a4cf38e4 4105 Check that character arg fits in 'int'.
85461888 4106 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4107
c0c1ee9f
PE
4108 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4109
a498d7f4
PE
4110 * fns.c (concat): Catch string overflow earlier.
4111 Do not rely on integer wraparound.
4112
51cab52b
PE
4113 * dispextern.h (struct it.overlay_strings_charpos)
4114 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4115 * xdisp.c (forward_to_next_line_start)
4116 (back_to_previous_visible_line_start)
4117 (reseat_at_next_visible_line_start, next_element_from_buffer):
4118 Don't arbitrarily truncate the value of 'selective' to int.
4119
76031fad
PE
4120 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4121
5eb55db9
PE
4122 * composite.c: Don't truncate sizes to 'int'.
4123 (composition_gstring_p, composition_reseat_it)
4124 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4125 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4126 not EMACS_UINT, for indexes.
5eb55db9 4127
0703a717
PE
4128 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4129
d6202519
PE
4130 * buffer.c: Include <verify.h>.
4131 (struct sortvec.priority, struct sortstr.priority):
8961a454 4132 Now EMACS_INT, not int.
c20998a7 4133 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4134 (struct sortstr.size, record_overlay_string)
4135 (struct sortstrlist.size, struct sortlist.used):
4136 Don't truncate size to int.
4137 (record_overlay_string): Check for size-calculation overflow.
d6202519 4138 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4139
d5a19415
JM
41402011-06-22 Jim Meyering <meyering@redhat.com>
4141
029529ac 4142 Don't leak an XBM-image-sized buffer
d5a19415
JM
4143 * image.c (xbm_load): Free the image buffer after using it.
4144
a9041e6c
PE
41452011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4146
4147 Port to Sun C.
4148 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4149 that Sun C diagnosed.
4150 * fns.c (secure_hash): Fix pointer signedness issue.
4151 * intervals.c (static_offset_intervals): New function.
4152 (offset_intervals): Use it.
4153
7f3f739f
LL
41542011-06-21 Leo Liu <sdl.web@gmail.com>
4155
4156 * deps.mk (fns.o):
4157 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4158 sha512.h.
4159
4160 * fns.c (secure_hash): Rename from crypto_hash_function and change
4161 the first arg to accept symbols.
5b66d427 4162 (Fsecure_hash): New primitive.
7f3f739f
LL
4163 (syms_of_fns): New symbols.
4164
76147d94
DD
41652011-06-20 Deniz Dogan <deniz@dogan.se>
4166
4167 * process.c (Fset_process_buffer): Clarify return value in
4168 docstring.
4169
7d7d0045
CY
41702011-06-18 Chong Yidong <cyd@stupidchicken.com>
4171
4172 * dispnew.c (add_window_display_history): Use BVAR.
4173
4174 * xdisp.c (debug_method_add): Use BVAR.
4175 (check_window_end, dump_glyph_matrix, dump_glyph)
4176 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4177
4178 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4179 Likewise.
4180
4181 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4182 check till after the cache is created in init_frame_faces.
4183
ff2bc410
SM
41842011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4185
4186 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4187
28177add
PE
41882011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4189
dd3482fe
PE
4190 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4191 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4192 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4193
393d71f3 4194 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4195 * fileio.c (Finsert_file_contents):
4196 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4197 Remove the old (too-loose) buffer overflow checks.
4198 They weren't needed, since make_gap checks for buffer overflow.
4199 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4200 The old code merely checked for Emacs fixnum overflow, and relied
4201 on undefined (wraparound) behavior. The new code avoids undefined
4202 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4203
2e6813b0 4204 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4205 Tune. Don't use wider integers than needed. Don't use alloca.
4206 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4207
599a9e4f
PE
4208 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4209
99561444
PE
4210 * insdel.c, lisp.h (buffer_overflow): New function.
4211 (insert_from_buffer_1, replace_range, replace_range_2):
4212 * insdel.c (make_gap_larger):
4213 * editfns.c (Finsert_char):
4214 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4215
28177add
PE
4216 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4217
e69dafad
PE
42182011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4219
a7af7fde 4220 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4221
b1c46f02
PE
4222 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4223 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4224
e69dafad
PE
4225 * fileio.c: Don't assume EMACS_INT fits in off_t.
4226 (emacs_lseek): New static function.
4227 (Finsert_file_contents, Fwrite_region): Use it.
4228 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4229
566684ea
PE
4230 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4231
e6966cd6
PE
4232 * fns.c: Don't overflow int when computing a list length.
4233 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4234 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4235 truncation on 64-bit hosts. Check for QUIT every
4236 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4237 faster and is responsive enough.
4238 (Flength): Report an error instead of overflowing an integer.
4239 (Fsafe_length): Return a float if the value is not representable
4240 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4241 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4242 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4243
dd0b0efb
PE
4244 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4245 (header_size, word_size): New constants.
4246 (allocate_vectorlike): Don't check size overflow here.
4247 (allocate_vector): Check it here instead, since this is the only
4248 caller of allocate_vectorlike that could cause overflow.
4249 Check that the new vector's length is representable as a fixnum.
4250
86fe5cfe
PE
4251 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4252 The previous code was bogus. For example, next_almost_prime (32)
4253 returned 39, which is undesirable as it is a multiple of 3; and
4254 next_almost_prime (24) returned 25, which is a multiple of 5 so
4255 why was the code bothering to check for multiples of 7?
4256
80e88859
PE
4257 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4258
4a2f0ad6
PE
4259 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4260
f66c7cf8
PE
4261 Variadic C functions now count arguments with ptrdiff_t.
4262 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4263 Back then I didn't know that the Emacs coding style prefers signed int.
4264 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4265 were being counted with int, which may truncate counts on 64-bit
4266 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4267 * lisp.h (struct Lisp_Subr.function.aMANY)
4268 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4269 Arg counts are now ptrdiff_t, not size_t.
4270 All variadic functions and their callers changed accordingly.
4271 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4272 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4273 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4274 * callint.c (Fcall_interactively): Check arg count for overflow,
4275 to avoid potential buffer overrun. Use signed char, not 'int',
4276 for 'varies' array, so that we needn't bother to check its size
4277 calculation for overflow.
4278 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4279 * eval.c (apply_lambda):
4280 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4281 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4282 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4283
a1759b76
PE
4284 * callint.c (Fcall_interactively): Don't use index var as event count.
4285
d96be9fc
PE
4286 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4287 * mem-limits.h (SIZE): Remove; no longer used.
4288
a690a978 4289 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4290
578c21e6
PE
4291 Remove unnecessary casts.
4292 * xterm.c (x_term_init):
4293 * xfns.c (x_set_border_pixel):
4294 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4295 These aren't needed now that we assume ANSI C.
4296
96f53c6c
PE
4297 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4298 It's more likely to cause problems (due to unsigned overflow)
4299 than to cure them.
4300
83c77d31
PE
4301 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4302
ee2079f1
PE
4303 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4304
6da65536
PE
4305 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4306
7147c4a4
PE
4307 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4308
193e32d9
PE
4309 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4310
e5533da6
PE
4311 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4312
9910e595
PE
4313 GLYPH_CODE_FACE returns EMACS_INT, not int.
4314 * dispextern.h (merge_faces):
4315 * xfaces.c (merge_faces):
01103c44
PE
4316 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4317 Don't assume EMACS_INT fits in int.
9910e595 4318
2638320e
PE
4319 * character.h (CHAR_VALID_P): Remove unused parameter.
4320 * fontset.c, lisp.h, xdisp.c: All uses changed.
4321
045eb8d9
PE
4322 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4323
c1f134b5
PE
4324 * fns.c (concat): Minor tuning based on overflow analysis.
4325 This doesn't fix any bugs. Use int to hold character, instead
4326 of constantly refetching from Emacs object. Use XFASTINT, not
4327 XINT, for value known to be a character. Don't bother comparing
4328 a single byte to 0400, as it's always less.
4329
395fcb93 4330 * floatfns.c (Fexpt):
327eeec8
PE
4331 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4332
abbd3d23
PE
4333 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4334 for characters.
4335
684a03ef
PE
4336 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4337
0fed43f3
PE
4338 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4339 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4340 incorrectly succeed when S was a string, because 4294967386 was
4341 truncated before it was used.
4342
8fd02eb7
PE
4343 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4344 Otherwise, an out-of-range integer could cause undefined behavior
4345 on a 64-bit host.
4346
f8c86b69
PE
4347 * composite.c: Use int, not EMACS_INT, for characters.
4348 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4349 EMACS_INT, for values that are known to be in character range.
4350 This doesn't fix any bugs but is the usual style inside Emacs and
4351 may generate better code on 32-bit machines.
4352
34206dd2
PE
4353 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4354 This is for reasons similar to the recent CHAR_STRING fix.
4355 * charset.c (Fencode_char): Check that character arg is actually
4356 a character. Pass an int to ENCODE_CHAR.
4357 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4358 wider than 'int', as a compile-time check to prevent future regressions
4359 in this area.
4360
c5958d4c 4361 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4362
4363 Make sure a 64-bit char is never passed to CHAR_STRING.
4364 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4365 by silently ignoring the top 32 bits, allowing some values
4366 that were far too large to be valid characters.
4367 * character.h: Include <verify.h>.
4368 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4369 arguments are no wider than unsigned, as a compile-time check
4370 to prevent future regressions in this area.
4371 * data.c (Faset):
01103c44 4372 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4373 (Fsubst_char_in_region):
4374 * fns.c (concat):
4375 * xdisp.c (decode_mode_spec_coding):
4376 Adjust to CHAR_STRING's new requirement.
4377 * editfns.c (Finsert_char, Fsubst_char_in_region):
4378 * fns.c (concat): Check that character args are actually
4379 characters. Without this test, these functions did the wrong
4380 thing with wildly out-of-range values on 64-bit hosts.
4381
d37ca623
PE
4382 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4383 These casts should not be needed on 32-bit hosts, either.
4384 * keyboard.c (read_char):
4385 * lread.c (Fload): Remove casts to unsigned.
4386
ea204efb
PE
4387 * lisp.h (UNSIGNED_CMP): New macro.
4388 This fixes comparison bugs on 64-bit hosts.
4389 (ASCII_CHAR_P): Use it.
4390 * casefiddle.c (casify_object):
01103c44 4391 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4392 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4393 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4394 * dispextern.h (FACE_FROM_ID):
4395 * keyboard.c (read_char): Use UNSIGNED_CMP.
4396
41cb286c
PE
4397 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4398 not to EMACS_INT, to avoid GCC warning.
4399
4a1b9832
PE
4400 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4401
55daad71
PE
4402 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4403 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4404 isn't needed on 32-bit machines.
8f95c75c 4405
01103c44
PE
4406 * buffer.c (Fgenerate_new_buffer_name):
4407 Use EMACS_INT for count, not int.
0ceccced 4408 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4409
4410 * data.c (Qcompiled_function): Now static.
4411
c6f072e7
PE
4412 * window.c (window_body_lines): Now static.
4413
20ce5912
PE
4414 * image.c (gif_load): Rename local to avoid shadowing.
4415
9c4c5f81
PE
4416 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4417 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4418 * alloc.c (make_save_value): Integer argument is now of type
4419 ptrdiff_t, not int.
4420 (mark_object): Use ptrdiff_t, not int.
4421 * lisp.h (pD): New macro.
4422 * print.c (print_object): Use it.
4423
c0c5c8ae
PE
4424 * alloc.c: Use EMACS_INT, not int, to count objects.
4425 (total_conses, total_markers, total_symbols, total_vector_size)
4426 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4427 (total_free_floats, total_floats, total_free_intervals)
4428 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4429 Now EMACS_INT, not int. All uses changed.
4430 (Fgarbage_collect): Compute overall total using a double, so that
4431 integer overflow is less likely to be a problem. Check for overflow
4432 when converting back to an integer.
5a25e253
PE
4433 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4434 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4435 These were 'int' variables that could overflow on 64-bit hosts;
4436 they were never used, so remove them instead of repairing them.
211a0b2a 4437 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4438 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4439 Previously, this ceilinged at INT_MAX, but that doesn't work on
4440 64-bit machines.
e46bb31a 4441 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4442
c78baabf 4443 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4444 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4445 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4446 when a (possibly-narrower) signed value would do just as well.
4447 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4448
c9d624c6
PE
4449 * alloc.c: Catch some string size overflows that we were missing.
4450 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4451 for convenience in STRING_BYTES_MAX.
4452 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4453 The definition here is exact; the one in lisp.h was approximate.
4454 (allocate_string_data): Check for string overflow. This catches
4455 some instances we weren't catching before. Also, it catches
4456 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4457 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4458 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4459
c9d624c6
PE
4460 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4461 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4462 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4463
353032ce
PE
4464 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4465
2bccce07
PE
4466 * alloc.c (Fmake_string): Check for out-of-range init.
4467
0ac30604
SM
44682011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4469
4470 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4471
c195f2de
JD
44722011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4473
4474 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4475 xg_get_default_scrollbar_width.
4476
4477 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4478 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4479 (style_changed_cb): Call update_theme_scrollbar_width and call
4480 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4481 all frames (Bug#8505).
4482 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4483 Call gtk_window_set_resizable if HAVE_GTK3.
4484 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4485 and height if HAVE_GTK3 (Bug#8505).
4486 (scroll_bar_width_for_theme): New variable.
4487 (update_theme_scrollbar_width): New function.
4488 (xg_get_default_scrollbar_width): Move code to
4489 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4490 (xg_initialize): Call update_theme_scrollbar_width.
4491
4492 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4493
4494 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4495
e10ac9f1
MR
44962011-06-12 Martin Rudalics <rudalics@gmx.at>
4497
4498 * frame.c (make_frame): Call other_buffer_safely instead of
4499 other_buffer.
4500
4501 * window.c (temp_output_buffer_show): Call display_buffer with
4502 second argument Vtemp_buffer_show_specifiers and reset latter
4503 immediately after the call.
4504 (Vtemp_buffer_show_specifiers): New variable.
4505 (auto_window_vscroll_p, next_screen_context_lines)
4506 (Vscroll_preserve_screen_position): Remove leading asterisks from
4507 doc-strings.
4508
2d3c217e 45092011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4510
7b7f97e8 4511 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4512 * buffer.c (Qclone_number): Remove for now, as it's unused.
4513 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4514 (record_buffer): Remove unused local.
4515 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4516 (set_frame_buffer_list): Remove; unused.
4517 * frame.h (other_visible_frames): Remove decl.
4518 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4519 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4520 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4521 if HAVE_GPM.
4522 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4523 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4524 Define only if HAVE_GPM.
4525 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4526 (update_hints_inhibit): Remove; never set. All uses removed.
4527 * widgetprv.h (emacsFrameClassRec): Remove decl.
4528 * window.c (delete_deletable_window): Now returns void, since it
4529 wasn't returning anything.
4530 (compare_window_configurations): Remove unused locals.
4531 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4532 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4533 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4534 the same widths as pointers. This follows up on the 2011-05-06 patch.
4535 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4536 * xterm.h: Likewise.
4537 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4538
1384b89e
JB
45392011-06-12 Juanma Barranquero <lekktu@gmail.com>
4540
4541 * makefile.w32-in: Update dependencies.
4542 (LISP_H): Add lib/intprops.h.
4543
1100a63c
CY
45442011-06-11 Chong Yidong <cyd@stupidchicken.com>
4545
4546 * image.c (gif_load): Add animation frame delay to the metadata.
4547 (syms_of_image): Use DEFSYM. New symbol `delay'.
4548
6198ccd0
MR
45492011-06-11 Martin Rudalics <rudalics@gmx.at>
4550
4551 * window.c (delete_deletable_window): Re-add.
4552 (Fset_window_configuration): Rewrite to handle dead buffers and
4553 consequently deletable windows.
4554 (window_tree, Fwindow_tree): Remove. Supply functionality in
4555 window.el.
4556 (compare_window_configurations): Simplify code.
4557
b6e3633c
AS
45582011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4559
1ab0dee5
AS
4560 * image.c (imagemagick_load_image): Fix type mismatch.
4561 (Fimagemagick_types): Likewise.
4562
b6e3633c
AS
4563 * window.h (replace_buffer_in_windows): Declare.
4564
9397e56f
MR
45652011-06-11 Martin Rudalics <rudalics@gmx.at>
4566
4567 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4568 Qclone_number. Remove external declaration of Qdelete_window.
4569 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4570 code.
640c8776
SM
4571 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4572 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4573 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4574 buffer list implementation.
4575 (other_buffer_safely): New function.
4576 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4577 calls to replace_buffer_in_windows and
4578 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4579 if allowed.
4580 (record_buffer): Inhibit quitting and rewrite using quittable
4581 functions. Run Qbuffer_list_update_hook if allowed.
4582 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4583 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4584 Move switch-to-buffer to window.el.
9397e56f
MR
4585 (bury-buffer): Move to window.el.
4586 (Vbuffer_list_update_hook): New variable.
4587
4588 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4589 section.
4590
4591 * window.h (resize_frame_windows): Move up in code.
4592 (Fwindow_frame): Remove EXFUN.
4593 (replace_buffer_in_all_windows): Remove prototype.
4594 (replace_buffer_in_windows_safely): Add prototype.
4595
4596 * window.c: Declare Qdelete_window static again. Move down
4597 declaration of select_count.
4598 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4599 (Fother_window): Move to window.el.
4600 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4601 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4602 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4603 window.el.
4604 (replace_buffer_in_windows): Implement by calling
4605 Qreplace_buffer_in_windows.
4606 (replace_buffer_in_all_windows): Remove with some functionality
4607 moved into replace_buffer_in_windows_safely.
4608 (replace_buffer_in_windows_safely): New function.
4609 (select_window_norecord, select_frame_norecord): Move in front
4610 of run_window_configuration_change_hook. Remove now obsolete
4611 declarations.
640c8776
SM
4612 (Fset_window_buffer): Rewrite doc-string.
4613 Call Qrecord_window_buffer.
9397e56f
MR
4614 (keys_of_window): Move binding for other-window to window.el.
4615
b50691aa
CY
46162011-06-11 Chong Yidong <cyd@stupidchicken.com>
4617
4618 * dispextern.h (struct image): Replace data member, whose int_val
4619 and ptr_val fields were not used by anything, with a single
4620 lisp_val object.
4621
4622 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4623 (gif_clear_image, gif_load, imagemagick_load_image)
4624 (gs_clear_image, gs_load): Callers changed.
4625
3f754b86
PE
46262011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4627
cca69397
PE
4628 * buffer.h: Include <time.h>, for time_t.
4629 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4630
109e28d0
PE
4631 Fix minor problems found by static checking.
4632
60737f02
PE
4633 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4634
4b66faf3
PE
4635 Make identifiers static if they are not used in other modules.
4636 * data.c (Qcompiled_function, Qframe, Qvector):
4637 * image.c (QimageMagick, Qsvg):
4638 * minibuf.c (Qmetadata):
4639 * window.c (resize_window_check, resize_root_window): Now static.
4640 * window.h (resize_window_check, resize_root_window): Remove decls.
4641
109e28d0
PE
4642 * window.c (window_deletion_count, delete_deletable_window):
4643 Remove; unused.
46a4ce9e
PE
4644 (window_body_lines): Now static.
4645 (Fdelete_other_windows_internal): Mark vars as initialized.
4646 Make sure 'resize_failed' is initialized.
4647 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4648 (resize_window_apply): Remove unused local.
4649 * window.h (delete_deletable_window): Remove decl.
4650
109e28d0 4651 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4652 (imagemagick_load_image): Fix pointer signedness problem by changing
4653 last arg from unsigned char * to char *. All uses changed.
4654 Also, fix a local for similar reasons.
4655 Remove unused locals. Remove locals to avoid shadowing.
4656 (fn_rsvg_handle_free): Remove; unused.
4657 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4658 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4659
3f754b86
PE
4660 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4661
2547adb1
CY
46622011-06-10 Chong Yidong <cyd@stupidchicken.com>
4663
4664 * image.c (gif_load): Fix omitted cast error introduced by
4665 2011-06-06 change.
4666
2c8e37d4
MR
46672011-06-10 Martin Rudalics <rudalics@gmx.at>
4668
4669 * window.h (resize_proportionally, orig_total_lines)
4670 (orig_top_line): Remove from window structure.
4671 (set_window_height, set_window_width, change_window_heights)
4672 (Fdelete_window): Remove prototypes.
4673 (resize_frame_windows): Remove duplicate declaration.
4674
440a42e3
EZ
46752011-06-10 Eli Zaretskii <eliz@gnu.org>
4676
4677 * window.h (resize_frame_windows, resize_window_check)
4678 (delete_deletable_window, resize_root_window)
4679 (resize_frame_windows): Declare prototypes.
4680
4681 * window.c (resize_window_apply): Make definition be "static" to
4682 match the prototype.
4683
562dd5e9
MR
46842011-06-10 Martin Rudalics <rudalics@gmx.at>
4685
4686 * window.c: Remove declarations of Qwindow_size_fixed,
4687 window_min_size_1, window_min_size_2, window_min_size,
4688 size_window, window_fixed_size_p, enlarge_window, delete_window.
4689 Remove static from declaration of Qdelete_window, it's
4690 temporarily needed by Fbury_buffer.
4691 (replace_window): Don't assign orig_top_line and
4692 orig_total_lines.
4693 (Fdelete_window, delete_window): Remove. Window deletion is
4694 handled by window.el.
640c8776
SM
4695 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4696 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4697 (Fdelete_other_windows): Remove. Deleting other windows is
4698 handled by window.el.
4699 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4700 handled in window.el.
4701 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4702 Window minimum sizes are handled in window.el.
4703 (shrink_windows, size_window, set_window_height)
4704 (set_window_width, change_window_heights, window_height)
4705 (window_width, CURBEG, CURSIZE, enlarge_window)
4706 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4707 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4708 handled in window.el.
4709 (make_dummy_parent): Rename to make_parent_window and give it a
4710 second argument horflag.
4711 (make_window): Don't set resize_proportionally any more.
4712 (Fsplit_window): Remove. Windows are split in window.el.
4713 (save_restore_action, save_restore_orig_size)
4714 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4715 Resize mini windows in window.el.
4716 (grow_mini_window, shrink_mini_window): Implement by calling
4717 Qresize_root_window_vertically, resize_window_check and
4718 resize_window_apply.
640c8776
SM
4719 (saved_window, Fset_window_configuration, save_window_save):
4720 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4721 resize_proportionally.
4722 (window_min_height, window_min_width): Move to window.el.
4723 (keys_of_window): Move bindings for delete-other-windows,
4724 split-window, delete-window and enlarge-window to window.el.
4725
4726 * buffer.c: Temporarily extern Qdelete_window.
4727 (Fbury_buffer): Temporarily call Qdelete_window instead of
4728 Fdelete_window (Fbury_buffer will move to window.el soon).
4729
4730 * frame.c (set_menu_bar_lines_1): Remove code handling
4731 orig_top_line and orig_total_lines.
4732
4733 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4734 set_window_height but set heights directly.
4735 (change_frame_size_1): Use resize_frame_windows.
4736
4737 * xdisp.c (init_xdisp): Don't use set_window_height but set
4738 heights directly.
4739
640c8776
SM
4740 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4741 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4742 run_window_configuration_change_hook.
4743
4744 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4745 instead of change_window_heights and run
4746 run_window_configuration_change_hook.
4747
1a13852e
MR
47482011-06-09 Martin Rudalics <rudalics@gmx.at>
4749
4750 * window.c (replace_window): Rename second argument REPLACEMENT to
4751 NEW. New third argument SETFLAG. Rewrite.
4752 (delete_window, make_dummy_parent): Call replace_window with
4753 third argument 1.
4754 (window_list_1): Move down in code.
4755 (run_window_configuration_change_hook): Move set_buffer part
4756 before select_frame_norecord part in order to unwind correctly.
4757 Rename count1 to count.
4758 (recombine_windows, delete_deletable_window, resize_root_window)
4759 (Fdelete_other_windows_internal)
4760 (Frun_window_configuration_change_hook, make_parent_window)
4761 (resize_window_check, resize_window_apply, Fresize_window_apply)
4762 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4763 (Fdelete_window_internal, Fresize_mini_window_internal):
4764 New functions.
1a13852e
MR
4765 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4766
f3d1777e
MR
47672011-06-08 Martin Rudalics <rudalics@gmx.at>
4768
496e208e
MR
4769 * window.h (window): Add some new members to window structure -
4770 normal_lines, normal_cols, new_total, new_normal, clone_number,
4771 splits, nest, prev_buffers, next_buffers.
4772 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4773 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4774
f3d1777e
MR
4775 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4776 Remove.
496e208e
MR
4777 (make_dummy_parent): Set new members of windows structure.
4778 (make_window): Move down in code. Handle new members of window
4779 structure.
4780 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4781 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4782 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4783 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4784 (Fset_window_next_buffers, Fset_window_clone_number):
4785 New functions.
496e208e
MR
4786 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4787 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4788 Doc-string fixes.
4789 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4790 Argument WINDOW can be now internal window too.
4791 (Fwindow_use_time): Move up in code.
4792 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4793 Rewrite doc-string.
4794 (Fset_window_configuration, saved_window)
4795 (Fcurrent_window_configuration, save_window_save): Handle new
4796 members of window structure.
b9e809c2
MR
4797 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4798 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4799 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4800 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4801 Qget_mru_window, Qresize_root_window,
4802 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4803 Qauto_buffer_name; staticpro them.
f3d1777e 4804
abde8f8c
MR
48052011-06-07 Martin Rudalics <rudalics@gmx.at>
4806
4807 * window.c (Fwindow_total_size, Fwindow_left_column)
4808 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4809 (Fwindow_list_1): New functions.
4810 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4811 (Fwindow_width, Fscroll_left, Fscroll_right):
4812 Use window_body_cols instead of window_box_text_cols.
4813 (delete_window, Fset_window_configuration):
4814 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4815 (delete_all_subwindows): Take a window as argument and not a
4816 structure. Rewrite.
190b47e6
MR
4817 (window_loop): Remove handling of GET_LRU_WINDOW and
4818 GET_LARGEST_WINDOW.
4819 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4820
4821 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4822 window_box_text_cols. delete_all_subwindows now takes a
4823 Lisp_Object as argument.
abde8f8c 4824
640c8776
SM
4825 * indent.c (compute_motion, Fcompute_motion):
4826 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4827
fa8a67e6
MR
4828 * frame.c (delete_frame): Call delete_all_subwindows with root
4829 window as argument.
4830
a54e3482
DC
48312011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4832
4833 * fns.c (Fputhash): Document return value.
4834
60002bf5
CY
48352011-06-06 Chong Yidong <cyd@stupidchicken.com>
4836
4837 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4838
0c671da6 48392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4840
b862a52a 4841 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4842
be44ca6c
PE
4843 Check for overflow when converting integer to cons and back.
4844 * charset.c (Fdefine_charset_internal, Fdecode_char):
4845 Use cons_to_unsigned to catch overflow.
4846 (Fencode_char): Use INTEGER_TO_CONS.
4847 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4848 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4849 * data.c (long_to_cons, cons_to_long): Remove.
4850 (cons_to_unsigned, cons_to_signed): New functions.
4851 These signal an error for invalid or out-of-range values.
4852 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4853 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4854 * font.c (Ffont_variation_glyphs):
4855 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4856 * lisp.h: Include <intprops.h>.
4857 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4858 (cons_to_signed, cons_to_unsigned): New decls.
4859 (long_to_cons, cons_to_long): Remove decls.
4860 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4861 (Fprimitive_undo): Use CONS_TO_INTEGER.
4862 * xfns.c (Fx_window_property): Likewise.
4863 * xselect.c: Include <limits.h>.
4864 (x_own_selection, selection_data_to_lisp_data):
4865 Use INTEGER_TO_CONS.
4866 (x_handle_selection_request, x_handle_selection_clear)
4867 (x_get_foreign_selection, Fx_disown_selection_internal)
4868 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4869 (lisp_data_to_selection_data): Use cons_to_unsigned.
4870 (x_fill_property_data): Use cons_to_signed.
4871 Report values out of range.
4872
d1f3d2af
PE
4873 Check for buffer and string overflow more precisely.
4874 * buffer.h (BUF_BYTES_MAX): New macro.
4875 * lisp.h (STRING_BYTES_MAX): New macro.
4876 * alloc.c (Fmake_string):
4877 * character.c (string_escape_byte8):
4878 * coding.c (coding_alloc_by_realloc):
4879 * doprnt.c (doprnt):
4880 * editfns.c (Fformat):
4881 * eval.c (verror):
4882 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4883 since they may not be the same number.
4884 * editfns.c (Finsert_char):
4885 * fileio.c (Finsert_file_contents):
4886 Likewise for BUF_BYTES_MAX.
4887
dd52fcea
PE
4888 * image.c: Use ptrdiff_t, not int, for sizes.
4889 (slurp_file): Switch from int to ptrdiff_t.
4890 All uses changed.
4891 (slurp_file): Check that file size fits in both size_t (for
4892 malloc) and ptrdiff_t (for sanity and safety).
4893
7f9bbdbb
PE
4894 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4895 if b->modtime has its maximal value.
4896
dfe18f82
PE
4897 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4898
84acfcf0
PE
4899 Don't assume time_t can fit into int.
4900 * buffer.h (struct buffer.modtime): Now time_t, not int.
4901 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4902 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4903
ccd9a01a
PE
4904 Minor fixes for signed vs unsigned integers.
4905 * character.h (MAYBE_UNIFY_CHAR):
4906 * charset.c (maybe_unify_char):
4907 * keyboard.c (read_char, reorder_modifiers):
4908 XINT -> XFASTINT, since the integer must be nonnegative.
4909 * ftfont.c (ftfont_spec_pattern):
4910 * keymap.c (access_keymap, silly_event_symbol_error):
4911 XUINT -> XFASTINT, since the integer must be nonnegative.
4912 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4913 since it makes no difference and we prefer signed.
4914 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4915 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4916 nonnegative.
4917
d6d100dd
SM
49182011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4919
4920 * window.h (Fwindow_frame): Declare.
4921
2b6148e4
PE
49222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4923
4924 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4925 (SPARE_MEMORY): Always define.
4926 (LARGE_REQUEST): Remove.
4927 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4928
f230ecc9
MR
49292011-06-06 Martin Rudalics <rudalics@gmx.at>
4930
727e958e
MR
4931 * lisp.h: Move EXFUNS for Fframe_root_window,
4932 Fframe_first_window and Fset_frame_selected_window to window.h.
4933
4934 * window.h: Move EXFUNS for Fframe_root_window,
4935 Fframe_first_window and Fset_frame_selected_window here from
4936 lisp.h.
4937
4938 * frame.c (Fwindow_frame, Fframe_first_window)
4939 (Fframe_root_window, Fframe_selected_window)
4940 (Fset_frame_selected_window): Move to window.c.
4941 (Factive_minibuffer_window): Move to minibuf.c.
4942 (Fother_visible_frames_p): New function.
4943
4944 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4945
f230ecc9
MR
4946 * window.c (decode_window, decode_any_window): Move up in code.
4947 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4948 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4949 (Fwindow_buffer): Move up and rewrite doc-string.
4950 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4951 (Fwindow_prev): New functions.
727e958e
MR
4952 (Fwindow_frame): Move here from frame.c. Accept any window as
4953 argument.
4954 (Fframe_root_window, Fframe_first_window)
4955 (Fframe_selected_window): Move here from frame.c. Accept frame
4956 or arbitrary window as argument. Update doc-strings.
4957 (Fminibuffer_window): Move up in code.
4958 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4959 (Fset_frame_selected_window): Move here from frame.c.
4960 Marginal rewrite.
727e958e
MR
4961 (Fselected_window, select_window, Fselect_window): Move up in
4962 code. Minor doc-string fixes.
f230ecc9 4963
4d09bcf6
PE
49642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4965
4966 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4967 Do not assume that spare memory exists; that assumption is valid
4968 only if SYSTEM_MALLOC.
4969 (LARGE_REQUEST): New macro, so that the issue of large requests
4970 is separated from the issue of spare memory.
4971
810928a2
AS
49722011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4973
172418ad
AS
4974 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4975 format. (Bug#8806)
4976
43f862f7
AS
4977 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4978
810928a2
AS
4979 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4980 before statements.
4981
a059fe24
JD
49822011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4983
4984 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4985
4986 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4987
4988 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4989 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4990
989bf368
JB
49912011-06-05 Juanma Barranquero <lekktu@gmail.com>
4992
4993 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4994
4b80f674
CY
49952011-06-04 Chong Yidong <cyd@stupidchicken.com>
4996
4997 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4998 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4999 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5000 New error handlers.
4b80f674
CY
5001 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5002 Obey Vx_select_enable_clipboard_manager. Catch errors in
5003 x_clipboard_manager_save (Bug#8779).
5004 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5005 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5006
99a33b77 50072011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5008
5009 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5010
99a33b77 50112011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5012
5013 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5014 in the current matrix if keep_current_p is non-zero.
5015
8264569d
EZ
50162011-06-04 Eli Zaretskii <eliz@gnu.org>
5017
5018 * bidi.c (bidi_level_of_next_char): Fix last change.
5019
57f97249
EZ
50202011-06-03 Eli Zaretskii <eliz@gnu.org>
5021
fec2107c 5022 Support bidi reordering of text covered by display properties.
57f97249 5023
fec2107c
EZ
5024 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5025 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5026 (bidi_cache_search, bidi_cache_iterator_state)
5027 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5028 (bidi_level_of_next_char, bidi_move_to_visually_next):
5029 Support character positions inside a run of characters covered by a
fec2107c
EZ
5030 display string.
5031 (bidi_paragraph_init, bidi_resolve_explicit_1)
5032 (bidi_level_of_next_char): Call bidi_fetch_char and
5033 bidi_fetch_char_advance instead of FETCH_CHAR and
5034 FETCH_CHAR_ADVANCE.
5035 (bidi_init_it): Initialize new members.
5036 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5037 definitions.
5038 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5039 instead of using explicit *_CHAR codes.
d6d100dd
SM
5040 (bidi_resolve_explicit, bidi_resolve_weak):
5041 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5042 bidirectional text is supported only in multibyte buffers.
5043 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5044 it to initialize the frame_window_p member of struct bidi_it.
5045 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5046 (bidi_resolve_explicit, bidi_resolve_weak)
5047 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5048 bidi_it->nchars is non-positive.
5049 (bidi_level_of_next_char): Don't try to lookup the cache for the
5050 next/previous character if nothing is cached there yet, or if we
5051 were just reseat()'ed to a new position.
c40e2fb2 5052
0e14fe90
EZ
5053 * xdisp.c (set_cursor_from_row): Set start and stop points
5054 according to the row's direction when priming the loop that looks
5055 for the glyph on which to display cursor.
5056 (single_display_spec_intangible_p): Function deleted.
5057 (display_prop_intangible_p): Reimplement to call
5058 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5059 Accept 3 additional arguments needed by handle_display_spec.
5060 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5061 values: lists, `(when COND...)' forms, etc.
5062 (single_display_spec_string_p): Support property values that are
5063 lists with the argument STRING its top-level element.
5064 (display_prop_string_p): Fix the condition for processing a
5065 property that is a list to be consistent with handle_display_spec.
fec2107c 5066 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5067 last portion of handle_display_prop.
5068 (compute_display_string_pos): Accept additional argument
5069 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5070 value of a `display' property is a "replacing spec".
5071 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5072 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5073 the display property, but just return a value indicating whether
5074 the display property will replace the characters it covers.
5075 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5076 frame_window_p members of struct bidi_it.
d6d100dd
SM
5077 (compute_display_string_pos, compute_display_string_end):
5078 New functions.
fec2107c
EZ
5079 (push_it): Accept second argument POSITION, where pop_it should
5080 jump to continue iteration.
5081 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5082
fec2107c
EZ
5083 * keyboard.c (adjust_point_for_property): Adjust the call to
5084 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5085
5086 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5087 (bidi_init_it): Update prototypes.
5088 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5089 (compute_display_string_pos, compute_display_string_end):
5090 Declare prototypes.
fec2107c
EZ
5091 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5092 EMACS_INT.
fc6f18ce 5093
40087514 50942011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5095
57f53182
PE
5096 Malloc failure behavior now depends on size of allocation.
5097 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5098 * lisp.h: Change signatures accordingly.
5099 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5100 All callers changed. (Bug#8762)
5101
5102 * gnutls.c: Use Emacs's memory allocators.
5103 Without this change, the gnutls library would invoke malloc etc.
5104 directly, which causes problems on non-SYNC_INPUT hosts, and which
5105 runs afoul of improving memory_full behavior. (Bug#8761)
5106 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5107 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5108 xfree instead of the default malloc, realloc, free.
5109 (Fgnutls_boot): No need to check for memory allocation failure,
5110 since xmalloc does that for us.
5111
ac32cd99 5112 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5113 * category.c (hash_get_category_set):
5114 * ccl.c (ccl_driver):
5115 * charset.c (Fdefine_charset_internal):
5116 * charset.h (struct charset.hash_index):
5117 * composite.c (get_composition_id, gstring_lookup_cache)
5118 (composition_gstring_put_cache):
5119 * composite.h (struct composition.hash_index):
5120 * dispextern.h (struct image.hash):
5121 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5122 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5123 (hashfn_equal, hashfn_user_defined, make_hash_table)
5124 (maybe_resize_hash_table, hash_lookup, hash_put)
5125 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5126 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5127 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5128 * image.c (make_image, search_image_cache, lookup_image)
5129 (xpm_put_color_table_h):
5130 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5131 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5132 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5133 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5134 * alloc.c (allocate_vectorlike):
5135 Check for overflow in vector size calculations.
5136 * ccl.c (ccl_driver):
5137 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5138 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5139 need to be updated by these changes.
40087514
PE
5140 * fns.c (make_hash_table, maybe_resize_hash_table):
5141 Check for integer overflow with large hash tables.
0de4bb68
PE
5142 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5143 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5144 (SXHASH_REDUCE): New macro.
5145 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5146 Use it instead of discarding useful hash info with large hash values.
5147 (sxhash_float): New function.
5148 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5149 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5150 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5151 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5152 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5153 Adjust signatures to match updated version of code.
5154 (consing_since_gc): Now EMACS_INT, since a single hash table can
5155 use more than INT_MAX bytes.
5156
698d32e2
DN
51572011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5158
5159 Make it possible to build with GCC-4.6+ -O2 -flto.
5160
5161 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5162
fd6fa53f
SM
51632011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5164
5165 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5166 Call minibuffer-inactive-mode.
5167
864db017
JB
51682011-05-31 Juanma Barranquero <lekktu@gmail.com>
5169
5170 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5171 Update dependencies.
5172
2ad0baf4
DN
51732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5174
5175 * data.c (init_data): Remove code for UTS, this system is not
5176 supported anymore.
5177
4fcc2638
DN
51782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5179
5180 Don't force ./temacs to start in terminal mode.
5181
5182 * frame.c (make_initial_frame): Initialize faces in all cases, not
5183 only when CANNOT_DUMP is defined.
5184 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5185
c56e0fd5
DN
51862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5187
5188 * dispnew.c (add_window_display_history): Use const for the string
5189 pointer. Remove declaration, not needed.
5190
333d54da 51912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5192
55d4c1b2 5193 Use 'inline', not 'INLINE'.
333d54da 5194 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5195 * alloc.c, fontset.c (INLINE): Remove.
5196 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5197 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5198 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5199 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5200 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5201
738db178
DN
52022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5203
5204 Make it possible to run ./temacs.
5205
5206 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5207 syms_of_callproc does the same thing. Remove test for
5208 "initialized", do it in the caller.
5209 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5210
620c53a6
SM
52112011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5212
5213 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5214 (read_minibuf): Use get_minibuffer.
5215 (syms_of_minibuf): Use DEFSYM.
5216 (Qmetadata): New var.
5217 * data.c (Qbuffer): Don't make it static.
5218 (syms_of_data): Use DEFSYM.
5219
e003a292
PE
52202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5221
5222 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5223 (CCL_CODE_MIN): New macro.
5224
ed008a6d
PE
52252011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5226
3687c2ef
PE
5227 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5228
ed008a6d
PE
5229 * eval.c (Qdebug): Now static.
5230 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5231 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5232 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5233
d66c4c7c
CY
52342011-05-29 Chong Yidong <cyd@stupidchicken.com>
5235
5236 * image.c: Various fixes to ImageMagick code comments.
5237 (Fimagemagick_types): Doc fix.
5238
5fbc2025
PE
52392011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5240
0196f88a
PE
5241 Minor fixes prompted by GCC 4.6.0 warnings.
5242
5243 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5244
5fbc2025
PE
5245 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5246 (x_clipboard_manager_save_all): Move extern decl to ...
5247 * xterm.h: ... here, so that it can be checked for consistency.
5248
1dd3c2d9
CY
52492011-05-29 Chong Yidong <cyd@stupidchicken.com>
5250
5251 * xselect.c (x_clipboard_manager_save_frame)
5252 (x_clipboard_manager_save_all): New functions.
5253 (Fx_clipboard_manager_save): Lisp function deleted.
5254
5255 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5256 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5257
5258 * xterm.h: Update prototype.
5259
5ba6571d
WX
52602011-05-28 William Xu <william.xwl@gmail.com>
5261
5262 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5263 exiting (Bug#8239).
5264
3eaff834
JM
52652011-05-28 Jim Meyering <meyering@redhat.com>
5266
e1900994 5267 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5268 * fns.c (to_uchar): Define.
5269 (crypto_hash_function): Use it to convert some newly-signed
5270 variables to unsigned, to avoid sign-extension bugs. For example,
5271 without this change, (md5 "truc") would evaluate to
5272 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5273 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5274 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5275
0f6990a7
PE
52762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5277
5278 Integer overflow fixes.
c8a9ca5a 5279
08686060
PE
5280 * dbusbind.c: Serial number integer overflow fixes.
5281 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5282 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5283 to hold a serial number that is too large for a fixnum.
5284 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5285 Check for serial numbers out of range. Decode any serial number
59568bf0 5286 that was so large that it became a float. (Bug#8722)
08686060 5287
2d1fc3c7
PE
5288 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5289 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5290 Use XFASTINT rather than XUINT when numbers are nonnegative.
5291 (xd_append_arg, Fdbus_method_return_internal):
5292 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5293 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5294 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5295 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5296 (Bug#8722)
2d1fc3c7 5297
c8a9ca5a
PE
5298 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5299
519e1d69
PE
5300 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5301
30569699
PE
5302 ccl: add integer overflow checks
5303 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5304 (IN_INT_RANGE): New macros.
5305 (ccl_driver): Use them to check for integer overflow when
5306 decoding a CCL program. Many of the new checks are whether XINT (x)
5307 fits in int; it doesn't always, on 64-bit hosts. The new version
5308 doesn't catch all possible integer overflows, but it's an
847044ea 5309 improvement. (Bug#8719)
30569699 5310
c11285dc
PE
5311 * alloc.c (make_event_array): Use XINT, not XUINT.
5312 There's no need for unsigned here.
5313
fdccd48e
PE
5314 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5315 This follows up to the 2011-05-06 change that substituted uintptr_t
5316 for EMACS_INT. This case wasn't caught back then.
5317
37910ab2
PE
5318 Rework Fformat to avoid integer overflow issues.
5319 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5320 now (part of C89). Include <verify.h>.
5321 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5322 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5323 (Fformat): Avoid the prepass trying to compute sizes; it was only
5324 approximate and thus did not catch overflow reliably. Instead, walk
5325 through the format just once, formatting and computing sizes as we go,
5326 checking for integer overflow at every step, and allocating a larger
5327 buffer as needed. Keep track separately whether the format is
5328 multibyte. Keep only the most-recently calculated precision, rather
5329 than them all. Record whether each argument has been converted to
5330 string. Use EMACS_INT, not int, for byte and char and arg counts.
5331 Support field widths and precisions larger than INT_MAX. Avoid
5332 sprintf's undefined behavior with conversion specifications such as %#d
5333 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5334 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5335 formatting out-of-range floating point numbers with int
9173deec 5336 formats. (Bug#8668)
37910ab2 5337
2e6578fb
PE
5338 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5339
0ae6bdee
PE
5340 * data.c: Avoid integer truncation in expressions involving floats.
5341 * data.c: Include <intprops.h>.
5342 (arith_driver): When there's an integer overflow in an expression
5343 involving floating point, convert the integers to floating point
5344 so that the resulting value does not suffer from catastrophic
5345 integer truncation. For example, on a 64-bit host (* 4
5346 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5347 Do not rely on undefined behavior after integer overflow.
5348
de883a70
PE
5349 merge count_size_as_multibyte, parse_str_to_multibyte
5350 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5351 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5352 Check for integer overflow.
5353 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5354 since it's now a duplicate of the other. This is more of
5355 a character than a buffer op, so better that it's in character.c.
5356 * fns.c, print.c: Adjust to above changes.
5357
2ff916cb
PE
53582011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5359
5360 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5361
f1b54466
PE
53622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5363
fb1ac845
PE
5364 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5365 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5366 (x_clipboard_manager_save): Now static.
5367 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5368
f1b54466
PE
5369 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5370 (crypto_hash_function): Now static.
5371 Fix pointer signedness problems. Avoid unnecessary initializations.
5372
a9f737ee
CY
53732011-05-27 Chong Yidong <cyd@stupidchicken.com>
5374
5375 * termhooks.h (Vselection_alist): Make it terminal-local.
5376
5377 * terminal.c (create_terminal): Initialize it.
5378
5379 * xselect.c: Support for clipboard managers.
5380 (Vselection_alist): Move to termhooks.h as terminal-local var.
5381 (LOCAL_SELECTION): New macro.
5382 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5383 (symbol_to_x_atom): Remove gratuitous arg.
5384 (x_handle_selection_request, lisp_data_to_selection_data)
5385 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5386 (x_own_selection, x_get_local_selection, x_convert_selection):
5387 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5388 (some_frame_on_display): Delete unused function.
5389 (Fx_own_selection_internal, Fx_get_selection_internal)
5390 (Fx_disown_selection_internal, Fx_selection_owner_p)
5391 (Fx_selection_exists_p): New optional frame arg.
5392 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5393 (x_handle_selection_clear): Don't treat other terminals with the
5394 same keyboard specially. Use the terminal-local Vselection_alist.
5395 (x_clear_frame_selections): Use Frun_hook_with_args.
5396
5397 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5398
5399 * xterm.h: Add support for those atoms.
5400
e067f0c1
CY
54012011-05-26 Chong Yidong <cyd@stupidchicken.com>
5402
5403 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5404 (converted_selections, conversion_fail_tag): New global variables.
5405 (x_selection_request_lisp_error): Free the above.
5406 (x_get_local_selection): Remove unnecessary code.
5407 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5408 of converted selections stored in converted_selections.
5409 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5410 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5411 (x_convert_selection): New function.
5412 (x_handle_selection_event): Simplify.
5413 (x_get_foreign_selection): Don't ignore incoming requests while
5414 waiting for an answer; this will fail when we implement
5415 SAVE_TARGETS, and seems unnecessary anyway.
5416 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5417 (Vx_sent_selection_functions): Doc fix.
5418
0f4aebc0
LL
54192011-05-26 Leo Liu <sdl.web@gmail.com>
5420
5421 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5422
e61124cd
YM
54232011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5424
5425 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5426
5427 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5428 for fringe update if it has periodic bitmap.
ac389d0c 5429 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5430 and fringe_bitmap_periodic_p.
5431
5432 * fringe.c (get_fringe_bitmap_data): New function.
5433 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5434 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5435 row. Mark glyph row for fringe update if periodicity changed.
5436
5437 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5438 for fringe update unless it has periodic bitmap.
5439
f16d9837
KH
54402011-05-25 Kenichi Handa <handa@m17n.org>
5441
5442 * xdisp.c (get_next_display_element): Set correct it->face_id for
5443 a static composition.
5444
e1b90ef6
LL
54452011-05-24 Leo Liu <sdl.web@gmail.com>
5446
5447 * deps.mk (fns.o):
5448 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5449
5450 * fns.c (crypto_hash_function, Fsha1): New function.
5451 (Fmd5): Use crypto_hash_function.
5452 (syms_of_fns): Add Ssha1.
5453
7400048f
PE
54542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5455
5456 * gnutls.c: Remove unused macros.
5457 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5458 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5459 Remove macros that are defined and never used.
5460 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5461
abb71cf4
CY
54622011-05-22 Chong Yidong <cyd@stupidchicken.com>
5463
5464 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5465 (Fx_get_selection_internal): Minor cleanup.
5466 (Fx_own_selection_internal): Rename arguments for consistency with
5467 select.el.
5468
6307db39
PE
54692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5470
5471 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5472
f3d4e0a4
CY
54732011-05-22 Chong Yidong <cyd@stupidchicken.com>
5474
5475 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5476
4d8ade89
YM
54772011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5478
5479 * dispnew.c (scrolling_window): Don't exclude the case that the
5480 last enabled row in the desired matrix touches the bottom boundary.
5481
32078c8d
GM
54822011-05-21 Glenn Morris <rgm@gnu.org>
5483
5484 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5485 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5486 and add some more files.
32078c8d 5487
7285dc67
EZ
54882011-05-20 Eli Zaretskii <eliz@gnu.org>
5489
5490 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5491 report_file_error introduced by the change from 2011-05-07.
5492
89d1bd22
PE
54932011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5494
5495 * systime.h (Time): Define only if emacs is defined.
5496 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5497 where the include path doesn't have X11/X.h by default. See
5498 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5499
e23640bb 55002011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5501
5502 * composite.c (find_automatic_composition): Fix previous change.
5503
b9704ad9
GM
55042011-05-20 Glenn Morris <rgm@gnu.org>
5505
5506 * lisp.mk: New file, split from Makefile.in.
5507 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5508 (shortlisp): Remove.
5509 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5510
4a720484
GM
55112011-05-19 Glenn Morris <rgm@gnu.org>
5512
5513 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5514 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5515 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5516 (lisp): Set the order to that of loadup.el.
5517 (shortlisp): Make it a copy of $lisp.
5518 (SOME_MACHINE_LISP): Remove.
5519 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5520 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5521
a28d4396
KH
55222011-05-18 Kenichi Handa <handa@m17n.org>
5523
5524 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5525 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5526 (find_automatic_composition): Mostly rewrite for efficiency.
5527
a2b1fa8e
JB
55282011-05-18 Juanma Barranquero <lekktu@gmail.com>
5529
5530 * makefile.w32-in: Update dependencies.
5531
8e1f5610
CS
55322011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5533
5534 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5535 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5536
7025ee00 55372011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5538
cdfa6eab
PE
5539 Fix some integer overflow issues, such as string length overflow.
5540
06d6db33
PE
5541 * insdel.c (count_size_as_multibyte): Check for string overflow.
5542
2b4560a8
PE
5543 * character.c (lisp_string_width): Check for string overflow.
5544 Use EMACS_INT, not int, for string indexes and lengths; in
5545 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5546 the resulting string length overflows an EMACS_INT; instead,
5547 report a string overflow if no precision given. When checking for
5548 precision exhaustion, use a check that cannot possibly have
5549 integer overflow. (Bug#8675)
5550 * character.h (lisp_string_width): Adjust to new signature.
5551
cb93f9be
PE
5552 * alloc.c (string_overflow): New function.
5553 (Fmake_string): Use it. This doesn't change behavior, but saves
5554 a few bytes and will simplify future changes.
5555 * character.c (string_escape_byte8): Likewise.
5556 * lisp.h (string_overflow): New decl.
5557
1a1f3366
PE
5558 Fixups, following up to the user-interface timestamp change.
5559 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5560 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5561 * msdos.c (mouse_get_pos): Likewise.
5562 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5563 * w32gui.h (Time): Define by including "systime.h" rather than by
5564 declaring it ourselves. (Bug#8664)
5565
d4e3e4d3
PE
5566 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5567 * image.c (clear_image_cache): Likewise.
5568
f6a24d19
PE
5569 * term.c (term_mouse_position): Don't assume time_t wraparound.
5570
08dc5ae6
PE
5571 Be more systematic about user-interface timestamps.
5572 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5573 and sometimes 'EMACS_UINT', to represent these timestamps.
5574 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5575 This makes the code easier to follow, and makes it easier to catch
5576 integer overflow bugs such as Bug#8664.
5577 * frame.c (Fmouse_position, Fmouse_pixel_position):
5578 Use Time, not unsigned long, for user-interface timestamps.
5579 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5580 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5581 * keyboard.h (last_event_timestamp): Likewise.
5582 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5583 * menu.h (xmenu_show): Likewise.
5584 * term.c (term_mouse_position): Likewise.
5585 * termhooks.h (struct input_event.timestamp): Likewise.
5586 (struct terminal.mouse_position_hook): Likewise.
5587 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5588 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5589 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5590 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5591 what it was before.
5592 * menu.h, termhooks.h: Include "systime.h", for Time.
5593
8e55734a
PE
5594 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5595 Don't assume that the difference between two unsigned long values
5596 can fit into an integer. At this point, we know button_down_time
5597 <= event->timestamp, so the difference must be nonnegative, so
5598 there's no need to cast the result if double-click-time is
5599 nonnegative, as it should be; check that it's nonnegative, just in
5600 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5601 apart (about 25 days). (Bug#8664)
8e55734a 5602
841f1b75 5603 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5604 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5605
3e26f69c
PE
5606 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5607 that always fit in int. Use a sentinel instead of a counter, to
5608 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5609 * frame.h (struct frame): Use int for menu_bar_items_used
5610 instead of EMACS_INT, since it always fits in int.
3e26f69c 5611
5cc152c0
PE
5612 * menu.c (grow_menu_items): Check for int overflow.
5613
d89eb65e
PE
5614 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5615
5235bd3e
PE
5616 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5617 Before, the code was not consistent. These values cannot exceed
5618 2**31 - 1 so there's no need to make them unsigned.
5619 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5620 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5621 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5622 as modifiers.
5623 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5624
bc827e23
PE
5625 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5626 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5627 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5628 presumably because the widths might not match.
5629
78eb494e
PE
5630 * window.c (size_window): Avoid needless test at loop start.
5631
04f2d78b
CB
56322011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5633
5634 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5635
d2fc7e3d 56362011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5637
5638 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5639
d2fc7e3d 56402011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5641
5642 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5643 `width' to `bar_area_x' and `bar_area_width', respectively.
5644 (x_scroll_run): Take account of fringe background extension.
5645
04f2d78b
CB
5646 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5647 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5648 `bar_area_width', respectively.
5649 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5650 background extension.
5651
79b70037
GM
56522011-05-10 Jim Meyering <meyering@redhat.com>
5653
5654 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5655
2f142cc5
JB
56562011-05-10 Juanma Barranquero <lekktu@gmail.com>
5657
5658 * image.c (Finit_image_library): Return t for built-in image types,
5659 like pbm and xbm. (Bug#8640)
5660
57679c86
AS
56612011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5662
5663 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5664
888c9e86
EZ
56652011-05-07 Eli Zaretskii <eliz@gnu.org>
5666
b0512a1d
EZ
5667 * w32console.c (Fset_screen_color): Doc fix.
5668 (Fget_screen_color): New function.
5669 (syms_of_ntterm): Defsubr it.
5670
7285dc67
EZ
5671 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5672 unlink the temporary file if Fcall_process didn't create it in the
5673 first place.
5674 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5675 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5676 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5677 cue to call_process_cleanup not to close that handle.
5678
4d3fcc8e
BK
56792011-05-07 Ben Key <bkey76@gmail.com>
5680
5681 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5682 one of two shell specific rules, either bootstrap-temacs-CMD or
5683 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5684 to the previous implementation of the bootstrap-temacs rule.
5685 The bootstrap-temacs-CMD rule is similar to the previous
5686 implementation of the bootstrap-temacs rule except that it
5687 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5688 variable.
5689
5690 These changes, along with some changes to nt/configure.bat,
5691 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5692 earlier fix to add support for --cflags and --ldflags options
5693 that include quotes so that it works whether make uses cmd or
5694 sh as the shell.
5695
b4289b64
MA
56962011-05-06 Michael Albinus <michael.albinus@gmx.de>
5697
5698 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5699 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5700 is a constant.
5701 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5702 a string. Handle both cases.
5703 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5704 (Fdbus_register_method): Use Qinvalid_function.
5705
af4c0e28
JB
57062011-05-06 Juanma Barranquero <lekktu@gmail.com>
5707
5708 * makefile.w32-in: Update dependencies.
5709 (LISP_H): Add inttypes.h and stdin.h.
5710 (PROCESS_H): Add unistd.h.
5711
c51453d9
EZ
57122011-05-06 Eli Zaretskii <eliz@gnu.org>
5713
5714 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5715 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5716
8ff0ac3c 57172011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5718
4c4b566b
PE
5719 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5720
aab2b9b5
PE
5721 * term.c (vfatal): Remove stray call to va_end.
5722 It's not needed and the C Standard doesn't allow it here anyway.
5723
c378da0b
PE
5724 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5725 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5726
288b08c7
PE
5727 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5728 bytes.
5729
e3601888
PE
5730 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5731
db6c0e74
PE
5732 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5733
dd5963ea
PE
5734 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5735
88c9450f
PE
5736 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5737
2f9442b8
PE
5738 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5739
c032b5f8
PE
5740 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5741 * charset.c (Fdefine_charset_internal): Don't initialize
5742 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5743 32-bit int (Bug#8600).
a108c10b
PE
5744
5745 * lread.c (read_integer): Be more consistent with string-to-number.
5746 Use string_to_number to do the actual conversion; this avoids
5747 rounding errors and fixes some other screwups. Without this fix,
5748 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5749 (digit_to_number): Move earlier, for benefit of read_integer.
5750 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5751 not a digit in any supported base. (Bug#8602)
a108c10b 5752
ad5f9eea
PE
5753 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5754
aec1708a
PE
5755 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5756 to match comment at start of function. This also removes a
5757 GCC warning about overflow in a 32+64-bit port.
5758
47be4ab5
PE
5759 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5760
371cac43
PE
5761 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5762 Reported by Stefan Monnier in
5763 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5764 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5765 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5766
d01a7826
PE
5767 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5768 (EMACS_UINTPTR): Likewise, with uintptr_t.
5769
7fd47d5c
PE
5770 * lisp.h: Prefer 64-bit EMACS_INT if available.
5771 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5772 on 32-bit hosts that have 64-bit int, so that they can access
5773 large files.
122b0c86
PE
5774 However, temporarily disable this change unless the temporary
5775 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5776
8727937b
PE
5777 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5778
8ac068ac
PE
5779 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5780 This removes an assumption that EMACS_INT and long are the same
5781 width as pointers. The assumption is true for Emacs porting targets
5782 now, but we want to make other targets possible.
5783 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5784 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5785 In the rest of the code, change types of integers that hold casted
5786 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5787 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5788 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5789 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5790 No need to cast type when ORing.
5791 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5792 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5793 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5794 assume EMACS_INT is the same width as char *.
5795 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5796 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5797 Remove no-longer-needed casts.
5798 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5799 (xg_tool_bar_help_callback, xg_make_tool_item):
5800 Use EMACS_INTPTR to hold an integer
5801 that will be cast to void *; this can avoid a GCC warning
5802 if EMACS_INT is not the same width as void *.
5803 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5804 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5805 (current_message_1, set_message_1):
5806 Use a local to convert to proper width without a cast.
5807 * xmenu.c (dialog_selection_callback): Likewise.
5808
ede49d71
PE
5809 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5810 Also, don't assume VALBITS / RAND_BITS is less than 5,
5811 and don't rely on undefined behavior when shifting a 1 left into
5812 the sign bit.
5813 * lisp.h (get_random): Change signature to match.
5814
2f30ecd0
PE
5815 * lread.c (hash_string): Use size_t, not int, for hash computation.
5816 Normally we prefer signed values; but hashing is special, because
5817 it's better to use unsigned division on hash table sizes so that
5818 the remainder is nonnegative. Also, size_t is the natural width
5819 for hashing into memory. The previous code used 'int', which doesn't
5820 retain enough info to hash well into very large tables.
5821 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5822
2a866e7b
PE
5823 * dbusbind.c: Don't possibly lose pointer info when converting.
5824 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5825 Use XPNTR rather than XHASH, so that the high-order bits of
5826 the pointer aren't lost when converting through void *.
5827
51639eac
PE
5828 * eval.c (Fautoload): Don't double-shift a pointer.
5829
92394119
PE
5830 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5831
dbdb9a7c
JB
58322011-05-06 Juanma Barranquero <lekktu@gmail.com>
5833
5834 * gnutls.c (DEF_GNUTLS_FN):
5835 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5836
db7a0b4f
AS
58372011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5838
5839 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5840 marker. (Bug#8610)
5841
f7ff1b0f 58422011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5843
5844 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5845 New version that can reserve upto 2GB of heap space.
5846
f7ff1b0f 58472011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5848
5849 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5850
639c109b
TZ
58512011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5852
5853 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5854 `gnutls_certificate_set_x509_key_file'.
5855
d2127135
JB
58562011-05-05 Juanma Barranquero <lekktu@gmail.com>
5857
5858 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5859 Update dependencies.
5860
e968f4f3
JB
58612011-05-04 Juanma Barranquero <lekktu@gmail.com>
5862
5863 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5864 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5865 Remove unused parameter `fildes'.
5866 * process.c (read_process_output, send_process): Don't pass it.
5867
84d358f0
JB
58682011-05-04 Juanma Barranquero <lekktu@gmail.com>
5869
5870 Fix previous change: the library cache is defined in w32.c.
5871 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5872 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5873
0898ca10
JB
58742011-05-04 Juanma Barranquero <lekktu@gmail.com>
5875
5876 Implement dynamic loading of GnuTLS on Windows.
5877
5878 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5879 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5880 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5881 Declare.
5882
5883 * gnutls.c (Qgnutls_dll): Define.
5884 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5885 (gnutls_*): Declare function pointers.
5886 (init_gnutls_functions): New function to initialize function pointers.
5887 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5888 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5889 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5890 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5891 (emacs_gnutls_write, emacs_gnutls_read)
5892 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5893 (Fgnutls_available_p): New function.
5894 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5895 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5896 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5897
5898 * image.c: Include w32.h.
5899 (Vimage_type_cache): Delete.
5900 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5901 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5902 (w32_delayed_load): Move to w32.c.
5903
5904 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5905
5906 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5907 (w32_delayed_load): Move from image.c. When loading a library, record
5908 its filename in the :loaded-from property of the library id.
5909 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5910 Initialize and staticpro them.
5911 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5912
5913 * process.c: Include lisp.h before w32.h, not after.
5914 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5915 instead of gnutls_record_check_pending.
5916
5917 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5918
ff4de4aa
TZ
59192011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5920
5921 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5922 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5923 as passed in.
5924
abe95abb
JD
59252011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5926
5927 * xterm.c (x_set_frame_alpha): Do not set property on anything
5928 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5929
e16e55d4
JB
59302011-05-02 Juanma Barranquero <lekktu@gmail.com>
5931
5932 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5933
bafcf6a5
JB
59342011-05-02 Juanma Barranquero <lekktu@gmail.com>
5935
5936 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5937 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5938 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5939 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5940 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5941 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5942 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5943 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5944 (Qgnutls_bootprop_callbacks_verify): Make static.
5945
e7a6747f
AS
59462011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5947
19ed11ba
AS
5948 * callproc.c: Indentation fixup.
5949
e7a6747f 5950 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5951 (wait_for_termination, interruptible_wait_for_termination):
5952 Move after wait_for_termination_1.
e7a6747f 5953
1ef14cb4
LMI
59542011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5955
5956 * sysdep.c (interruptible_wait_for_termination): New function
5957 which is like wait_for_termination, but allows keyboard
5958 interruptions.
5959
5960 * callproc.c (Fcall_process): Add (:file "file") as an option for
5961 the STDOUT buffer.
5962 (Fcall_process_region): Ditto.
5963
330d880c
EZ
59642011-04-30 Eli Zaretskii <eliz@gnu.org>
5965
8db90b73
EZ
5966 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5967 rather than `XVECTOR (FOO)->size'.
5968
330d880c
EZ
5969 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5970 inttypes.h, as a gnulib replacement is used if it not available in
5971 system headers.
5972
15cbd324
EZ
59732011-04-21 Eli Zaretskii <eliz@gnu.org>
5974
5975 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5976 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5977 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5978
5979 * coding.c (coding_alloc_by_realloc): Error out if destination
5980 will grow beyond MOST_POSITIVE_FIXNUM.
5981 (decode_coding_emacs_mule): Abort if there isn't enough place in
5982 charbuf for the composition carryover bytes. Reserve an extra
5983 space for up to 2 characters produced in a loop.
5984 (decode_coding_iso_2022): Abort if there isn't enough place in
5985 charbuf for the composition carryover bytes.
5986
59872011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5988
ae940cca
EZ
5989 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5990 aborting when %lld or %lll format is passed.
5991 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5992 %llo or %llx format is passed. (Bug#8545)
5993
03ab8921
EZ
5994 * window.c (window_scroll_line_based): Use a marker instead of
5995 simple variables to record original value of point. (Bug#7952)
5996
afda1437
EZ
5997 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5998 produced by %s or %c overflows available buffer space. (Bug#8545)
5999
f76dee0c
PE
60002011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6001
6002 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6003 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6004
fdc5744d
JB
60052011-04-28 Juanma Barranquero <lekktu@gmail.com>
6006
6007 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6008
638f053a
JB
60092011-04-28 Juanma Barranquero <lekktu@gmail.com>
6010
6011 * keyboard.c (Qdelayed_warnings_hook): Define.
6012 (command_loop_1): Run `delayed-warnings-hook'
6013 if Vdelayed_warnings_list is non-nil.
6014 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6015 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6016
d178f871
EZ
60172011-04-28 Eli Zaretskii <eliz@gnu.org>
6018
6019 * doprnt.c (doprnt): Don't return value smaller than the buffer
6020 size if the message was truncated. (Bug#8545).
6021
b124fd93
JB
60222011-04-28 Juanma Barranquero <lekktu@gmail.com>
6023
6024 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6025 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6026
e810457d
PE
60272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6028
6029 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6030
ea51cceb
JB
60312011-04-27 Juanma Barranquero <lekktu@gmail.com>
6032
6033 * makefile.w32-in: Update dependencies.
6034
94dcfacf
EZ
60352011-04-27 Eli Zaretskii <eliz@gnu.org>
6036
6037 Improve `doprnt' and its usage. (Bug#8545)
6038 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6039 `format_end'. Remove support for %l as a conversion specifier.
6040 Don't use xrealloc. Improve diagnostics when the %l size modifier
6041 is used. Update the commentary.
6042
6043 * eval.c (verror): Simplify calculation of size_t.
6044
6045 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6046 messages.
6047
f61f41d7
PE
60482011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6049
6050 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6051 change.
6052
96fb4434
PE
60532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6054
6055 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6056 This makes this file independent of the recent pseudovector change.
6057
671875da 60582011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6059
69e9b5a3
PE
6060 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6061
b5f869a7 6062 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6063 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6064 Remove unused local.
c8926152 6065 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6066
841a1577 6067 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6068 GCC 4.6.0 optimizes based on type-based alias analysis.
6069 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6070 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6071 != &v->size, and therefore "v->size = 1; b->size = 2; return
6072 v->size;" must therefore return 1. This assumption is incorrect
6073 for Emacs, since it type-puns struct Lisp_Vector * with many other
6074 types. To fix this problem, this patch adds a new type struct
f904488f 6075 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6076 and pseudovectors, and helps optimizing compilers not get fooled
6077 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6078 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6079 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6080 the size member.
eab3844f
PE
6081 (XSETPVECTYPE): Rewrite in terms of new macro.
6082 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6083 This is a bit clearer, and further avoids the possibility of
6084 undesirable aliasing.
6085 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6086 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6087 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6088 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6089 (ASIZE): Now uses header.size rather than size.
6090 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6091 to avoid the hassle of writing XVECTOR (foo)->header.size.
6092 (struct vectorlike_header): New type.
eab3844f
PE
6093 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6094 object, to help avoid aliasing.
6095 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6096 (SUBRP): Likewise, since Lisp_Subr is a special case.
6097 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6098 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6099 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6100 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6101 changed to be "header.size" and "header.next".
6102 * buffer.h (struct buffer): Likewise.
6103 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6104 * frame.h (struct frame): Likewise.
6105 * process.h (struct Lisp_Process): Likewise.
6106 * termhooks.h (struct terminal): Likewise.
6107 * window.c (struct save_window_data, struct saved_window): Likewise.
6108 * window.h (struct window): Likewise.
6109 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6110 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6111 * buffer.c (init_buffer_once): Likewise.
6112 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6113 special case.
6114 * process.c (Fformat_network_address): Use local var for size,
6115 for brevity.
6116
0df1eac5
PE
6117 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6118
847ab9d1 6119 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6120 * data.c (atof): Remove decl; no longer used or needed.
6121 (digit_to_number): Move to lread.c.
6122 (Fstring_to_number): Use new string_to_number function, to be
6123 consistent with how the Lisp reader treats infinities and NaNs.
6124 Do not assume that floating-point numbers represent EMACS_INT
6125 without losing information; this is not true on most 64-bit hosts.
6126 Avoid double-rounding errors, by insisting on integers when
6127 parsing non-base-10 numbers, as the documentation specifies.
6128 * lisp.h (string_to_number): New decl, replacing ...
6129 (isfloat_string): Remove.
bc0a5c13 6130 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6131 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6132 appears to have been a coding error. Similarly, do not accept
6133 strings like +-1e0 as floating point numbers. Do not report
6134 overflow for integer overflows unless the base is not 10 which
6135 means we have no simple and reliable way to continue.
6136 Break out the floating-point parsing into a new
6137 function string_to_number, so that Fstring_to_number parses
6138 floating point numbers consistently with the Lisp reader.
04f2d78b 6139 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6140 (E_CHAR, EXP_INT): Remove, replacing with ...
6141 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6142 (string_to_number): New function, replacing isfloat_string.
6143 This function checks for valid syntax and produces the resulting
6144 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6145 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6146 so that overflow for non-base-10 numbers is reported only when
6147 there's no portable and simple way to convert to floating point.
452f4150 6148
67769ffc
PE
6149 * textprop.c (set_text_properties_1): Rewrite for clarity,
6150 and to avoid GCC warning about integer overflow.
6151
c20db43f
PE
6152 * intervals.h (struct interval): Use EMACS_INT for members
6153 where EMACS_UINT might cause problems. See
6154 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6155 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6156 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6157 All uses changed.
37aa2f85
PE
6158 (offset_intervals): Tell GCC not to worry about length overflow
6159 when negating a negative length.
c20db43f 6160
2538aa2f
PE
6161 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6162 (overrun_check_free): Likewise.
6163
f2d3008d
PE
6164 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6165 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6166 word size.
6167
ec8df744
PE
6168 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6169 (gnutls_make_error): Rename local to avoid shadowing.
6170 (gnutls_emacs_global_deinit): ifdef out; not used.
6171 (Fgnutls_boot): Use const for pointer to readonly storage.
6172 Comment out unused local. Fix pointer signedness problems.
6173
640ee02d
PE
6174 * lread.c (openp): Don't stuff size_t into an 'int'.
6175 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6176 about possible signed overflow.
6177
6048fb2a
PE
6178 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6179 (GDK_KEY_g): Don't define if already defined.
6180 (xg_prepare_tooltip): Avoid pointer signedness problem.
6181 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6182
fa3c87e1
PE
6183 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6184 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6185
2172544b
PE
6186 * xfns.c (Fx_window_property): Simplify a bit,
6187 to make a bit faster and to avoid GCC 4.6.0 warning.
6188 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6189
9b821a21
PE
6190 * fns.c (internal_equal): Don't assume size_t fits in int.
6191
3c616cfa
PE
6192 * alloc.c (compact_small_strings): Tighten assertion a little.
6193
c2982e87
PE
6194 Replace pEd with more-general pI, and fix some printf arg casts.
6195 * lisp.h (pI): New macro, generalizing old pEd macro to other
6196 conversion specifiers. For example, use "...%"pI"d..." rather
6197 than "...%"pEd"...".
6198 (pEd): Remove. All uses replaced with similar uses of pI.
6199 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6200 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6201 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6202 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6203 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6204 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6205 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6206 64-bit hosts.
6207 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6208 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6209 * print.c (safe_debug_print, print_object): Likewise.
6210 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6211 to int.
6f04d126
PE
6212 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6213 avoiding the 0 flag, which is not portable.
c2982e87
PE
6214 * process.c (Fmake_network_process): Use pI to avoid cast.
6215 * region-cache.c (pp_cache): Likewise.
6216 * xdisp.c (decode_mode_spec): Likewise.
6217 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6218 behavior on 64-bit hosts with printf arg.
6f04d126 6219 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6220 (x_stop_queuing_selection_requests): Likewise.
6221 (x_get_window_property): Don't truncate byte count to an 'int'
6222 when tracing.
0b432f21 6223
5e073ec7
PE
6224 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6225 here, since it parses constructs like leading '-' and spaces,
6226 which are not wanted; and it overflows with large numbers.
6227 Instead, simply match F[0-9]+, which is what is wanted anyway.
6228
36372bf9
PE
6229 * alloc.c: Remove unportable assumptions about struct layout.
6230 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6231 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6232 (allocate_vectorlike, make_pure_vector): Use the new macros,
6233 plus offsetof, to remove unportable assumptions about struct layout.
6234 These assumptions hold on all porting targets that I know of, but
6235 they are not guaranteed, they're easy to remove, and removing them
6236 makes further changes easier.
6237
0b432f21
PE
6238 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6239 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6240 (string_overrun_cookie): Now const. Use initializers that
6241 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6242 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6243 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6244 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6245 multiple of sizeof (EMACS_INT); it need not be, if
6246 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6247 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6248
895009e1
JB
62492011-04-26 Juanma Barranquero <lekktu@gmail.com>
6250
6251 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6252
6a7a1b0b
TZ
62532011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6254
6255 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6256 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6257 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6258
841a1577 62592011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6260
6261 * lisp.h (Qdebug): List symbol.
895009e1 6262 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6263 * keyboard.c (debug-on-event): New variable.
6264 (handle_user_signal): Break into debugger when debug-on-event
6265 matches the current signal symbol.
6266
f2d3ba6f
DN
62672011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6268
6269 * alloc.c (check_sblock, check_string_bytes)
6270 (check_string_free_list): Convert to standard C.
6271
42ce4c63
TZ
62722011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6273
6274 * w32.c (emacs_gnutls_push): Fix typo.
6275
825cd63c
EZ
62762011-04-25 Eli Zaretskii <eliz@gnu.org>
6277
fb11d64d
EZ
6278 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6279 "cast to pointer from integer of different size".
6280
825cd63c
EZ
6281 Improve doprnt and its use in verror. (Bug#8545)
6282 * doprnt.c (doprnt): Document the set of format control sequences
6283 supported by the function. Use SAFE_ALLOCA instead of always
6284 using `alloca'.
6285
6286 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6287 is one byte too soon. Don't use xrealloc; instead xfree and
6288 xmalloc anew.
6289
e061a11b
TZ
62902011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6291
6292 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6293 callbacks stage.
6294
6295 * gnutls.c: Renamed global_initialized to
6296 gnutls_global_initialized. Added internals for the
6297 :verify-hostname-error, :verify-error, and :verify-flags
6298 parameters of `gnutls-boot' and documented those parameters in the
6299 docstring. Start callback support.
9173deec
JB
6300 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6301 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6302 on error. Return error code.
e061a11b
TZ
6303 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6304 (emacs_gnutls_read): Likewise.
6305 (Fgnutls_boot): Return handshake error code.
6306 (emacs_gnutls_handle_error): New function.
6307 (wsaerror_to_errno): Likewise.
6308
6309 * w32.h (emacs_gnutls_pull): Add prototype.
6310 (emacs_gnutls_push): Likewise.
6311
6312 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6313 (emacs_gnutls_push): Likewise.
6314
63152011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6316
6317 * process.c (wait_reading_process_output): Check if GnuTLS
6318 buffered some data internally if no FDs are set for TLS
6319 connections.
6320
6321 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6322 (LIBS): Link to USER_LIBS.
6323 ($(BLD)/gnutls.$(0)): New target.
6324
fa6996bc
EZ
63252011-04-24 Eli Zaretskii <eliz@gnu.org>
6326
eb35682e
EZ
6327 * xdisp.c (handle_single_display_spec): Rename the
6328 display_replaced_before_p argument into display_replaced_p, to
6329 make it consistent with the commentary. Fix typos in the
6330 commentary.
6331
e2ad650c
EZ
6332 * textprop.c (syms_of_textprop): Remove dead code.
6333 (copy_text_properties): Delete obsolete commentary about an
6334 interface that was deleted long ago. Fix typos in the description
6335 of arguments.
6336
1b2de274
EZ
6337 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6338 to changes in oldXMenu/XMenu.h from 2011-04-16.
6339 <menu_help_message, prev_menu_help_message>: Constify.
6340 (IT_menu_make_room): menu->help_text is now `const char **';
6341 adjust.
6342
6343 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6344 to changes in oldXMenu/XMenu.h from 2011-04-16.
6345 (struct XMenu): Declare `help_text' `const char **'.
6346
6347 * xfaces.c <Qunspecified>: Make extern again.
6348
6349 * syntax.c: Include sys/types.h before including regex.h, as
6350 required by Posix.
6351
762b15be
EZ
6352 * doc.c (get_doc_string): Improve the format passed to `error'.
6353
6354 * doprnt.c (doprnt): Improve commentary.
6355
6356 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6357
6358 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6359 them with etags.
6360
f1052e5d
EZ
6361 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6362 changes in globals.h immediately force recompilation.
762b15be
EZ
6363 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6364 $(CURDIR)/s/ms-w32.h.
6365 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6366
fa6996bc
EZ
6367 * character.c (Fchar_direction): Function deleted.
6368 (syms_of_character): Don't defsubr it.
6369 <char-direction-table>: Deleted.
6370
e6c3da20
EZ
63712011-04-23 Eli Zaretskii <eliz@gnu.org>
6372
6373 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6374 * doprnt.c: Include limits.h.
6375 (SIZE_MAX): New macro.
04f2d78b
CB
6376 (doprnt): Return a size_t value. 2nd arg is now size_t.
6377 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6378 Improve overflow protection. Support `l' modifier for integer
6379 conversions. Support %l conversion. Don't assume an EMACS_INT
6380 argument for integer conversions and for %c.
6381
6382 * lisp.h (doprnt): Restore prototype.
6383
6384 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6385 $(SRC)/character.h.
6386
6387 * Makefile.in (base_obj): Add back doprnt.o.
6388
6389 * deps.mk (doprnt.o): Add back prerequisites.
6390 (callint.o): Depend on character.h.
6391
6392 * eval.c (internal_lisp_condition_case): Include the handler
6393 representation in the error message.
6394 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6395 when breaking from the loop.
6396
6397 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6398
6399 * callint.c (Fcall_interactively): When displaying error message
6400 about invalid control letter, pass the character's codepoint, not
6401 a pointer to its multibyte form. Improve display of the character
6402 in octal and display also its hex code.
6403
6404 * character.c (char_string): Use %x to display the (unsigned)
6405 codepoint of an invalid character, to avoid displaying a bogus
6406 negative value.
6407
6408 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6409 `error', not SYMBOL_NAME itself.
6410
6411 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6412 character arguments to `error'.
6413
6414 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6415 to `error' in error message about FINAL_CHAR argument. Make sure
6416 FINAL_CHAR is a character, and use %c when it is passed as
6417 argument to `error'.
6418
4ffd0d6b 64192011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6420
6421 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6422
6423 * w32.c: Include <time.h>.
6424 (sys_localtime): New function.
6425
4ffd0d6b 64262011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6427
6428 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6429
4ffd0d6b 6430 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6431
4ffd0d6b 64322011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6433
4ffd0d6b
GM
6434 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6435 zombies (Bug#8467).
aac0c6e3 6436
04c56954
EZ
64372011-04-19 Eli Zaretskii <eliz@gnu.org>
6438
6439 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6440 gl_state.e_property when gl_state.object is Qt.
6441
6442 * insdel.c (make_gap_larger): Remove limitation of buffer size
6443 to <= INT_MAX.
6444
16a43933
CY
64452011-04-18 Chong Yidong <cyd@stupidchicken.com>
6446
6447 * xdisp.c (lookup_glyphless_char_display)
6448 (produce_glyphless_glyph): Handle cons cell entry in
6449 glyphless-char-display.
6450 (Vglyphless_char_display): Document it.
6451
6452 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6453 glyphless-char-display.
6454
4581706e
CY
64552011-04-17 Chong Yidong <cyd@stupidchicken.com>
6456
6457 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6458
6459 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6460
6461 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6462 definition for no-X builds.
6463
4887c6e2 64642011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6465
fd35b6f9
PE
6466 Static checks with GCC 4.6.0 and non-default toolkits.
6467
5c1ccb01
PE
6468 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6469
006c5daa
PE
6470 * process.c (keyboard_bit_set): Define only if SIGIO.
6471 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6472 (send_process): Repair possible setjmp clobbering.
6473
efc736d3
PE
6474 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6475
4e2fe2e6
PE
6476 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6477
f97334a2
PE
6478 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6479
4e75f29d
PE
6480 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6481 Define only if needed.
6482
90efadd1
PE
6483 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6484 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6485 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6486
3c647824
PE
6487 * dispextern.h (struct redisplay_interface): Rename param
6488 to avoid shadowing.
e264f262 6489 * termhooks.h (struct terminal): Likewise.
761383f4 6490 * xterm.c (xembed_send_message): Likewise.
3c647824 6491
b58c5c4a
PE
6492 * insdel.c (make_gap_smaller): Define only if
6493 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6494
cad59032
PE
6495 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6496 it.
6497
c339dc2e
PE
6498 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6499 so that we aren't warned about unused symbols.
6500
91a3e27b
PE
6501 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6502
399c71d3 6503 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6504
8ffc96f5
PE
6505 * xfns.c (x_real_positions): Mark locals as initialized.
6506
eef9bc79
PE
6507 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6508
098db9dd
PE
6509 * xterm.c: Fix problems found by static analysis with other toolkits.
6510 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6511 (x_dispatch_event): Declare static if USE_GTK, and
6512 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6513 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6514 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6515 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6516 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6517
eb18f6cc
PE
6518 * xmenu.c (menu_help_callback): Pointer type fixes.
6519 Use const pointers when pointing at readonly data. Avoid pointer
6520 signedness clashes.
6521 (FALSE): Remove unused macro.
6522 (update_frame_menubar): Remove unused decl.
6523
1fe72bf8
PE
6524 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6525
60d9e1db
PE
6526 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6527 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6528 (single_menu_item): Rename local to avoid shadowing.
6529
39261c26
PE
6530 * keyboard.c (make_lispy_event): Remove unused local var.
6531
018c5e19
PE
6532 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6533 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6534
63d2b86e
PE
6535 * bitmaps: Change bitmaps from unsigned char back to the X11
6536 compatible char. Avoid the old compiler warnings about
6537 out-of-range initializers by using, for example, '\xab' rather
6538 than 0xab.
6539
aefd87e1
PE
6540 * xgselect.c (xgselect_initialize): Check vs interface
6541 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6542
bf501fb9
PE
6543 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6544
e9829fdf
PE
6545 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6546 to read-only memory.
6547
1086c095
PE
6548 * fns.c (vector): Remove; this old hack is no longer needed.
6549
2baccd04 6550 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6551 Remove unused var.
dde42981 6552 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6553
72391843 6554 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6555
436c16df 6556 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6557 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6558 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6559
92bb796d 6560 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6561 (x_term_init): Remove local to avoid shadowing.
92bb796d 6562
764430a3 6563 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6564
6565 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6566 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6567
d1dfb56c
EZ
65682011-04-16 Eli Zaretskii <eliz@gnu.org>
6569
c4354cb4
EZ
6570 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6571
d1dfb56c
EZ
6572 Fix regex.c, syntax.c and friends for buffers > 2GB.
6573 * syntax.h (struct gl_state_s): Declare character position members
6574 EMACS_INT.
6575
6576 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6577
04f2d78b
CB
6578 * textprop.c (verify_interval_modification, interval_of):
6579 Declare arguments EMACS_INT.
d1dfb56c
EZ
6580
6581 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6582 EMACS_INT.
6583
6584 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6585
6586 * indent.c (Fvertical_motion): Local variable it_start is now
6587 EMACS_INT.
6588
6589 * regex.c (re_match, re_match_2, re_match_2_internal)
6590 (bcmp_translate, regcomp, regexec, print_double_string)
6591 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6592 (re_compile_pattern, re_exec): Declare arguments and local
6593 variables `size_t' and `ssize_t' and return values `regoff_t', as
6594 appropriate.
6595 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6596 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6597 <compile_stack_type>: `size' and `avail' are now `size_t'.
6598
6599 * regex.h <regoff_t>: Use ssize_t, not int.
6600 (re_search, re_search_2, re_match, re_match_2): Arguments that
6601 specify buffer/string position and length are now ssize_t and
6602 size_t. Return type is regoff_t.
6603
613052cd
BK
66042011-04-16 Ben Key <bkey76@gmail.com>
6605
6606 * nsfont.m: Fixed bugs in ns_get_family and
6607 ns_descriptor_to_entity that were caused by using free to
6608 deallocate memory blocks that were allocated by xmalloc (via
6609 xstrdup). This caused Emacs to crash when compiled with
6610 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6611 --enable-checking=xmallocoverrun). xfree is now used to
6612 deallocate these memory blocks.
6613
4170f62f 66142011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6615
71b41406
PE
6616 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6617
9587a89d
PE
6618 emacs_write: Accept and return EMACS_INT for sizes.
6619 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6620 et seq.
6621 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6622 Accept and return EMACS_INT.
6623 (emacs_gnutls_write): Return the number of bytes written on
6624 partial writes.
6625 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6626 (emacs_read, emacs_write): Remove check for negative size, as the
6627 Emacs source code has been audited now.
9587a89d
PE
6628 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6629 (emacs_read, emacs_write): Use it.
273a5f82
PE
6630 * process.c (send_process): Adjust to the new signatures of
6631 emacs_write and emacs_gnutls_write. Do not attempt to store
6632 a byte offset into an 'int'; it might overflow.
9587a89d 6633 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6634
3e047f51
PE
6635 * sound.c: Don't assume sizes fit in 'int'.
6636 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6637 Return EMACS_INT, not int.
3e047f51 6638 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6639 Accept EMACS_INT, not int.
6640 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6641 record read return values.
6642
cc39a9db
BK
66432011-04-15 Ben Key <bkey76@gmail.com>
6644
c9d0ec6d
JB
6645 * keyboard.c (Qundefined): Don't declare static since it is used
6646 in nsfns.m.
6647 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6648 static since they are used in nsfont.m.
cc39a9db 6649
6c60eb9f
SM
66502011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6651
6652 * process.c (Qprocessp): Don't declare static.
6653 * lisp.h (Qprocessp): Declare again.
6654
7990b61a
JB
66552011-04-15 Juanma Barranquero <lekktu@gmail.com>
6656
6657 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6658
5d4cb038
PE
66592011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6660
8bd7b830 6661 Improve C-level modularity by making more things 'static'.
cd64ea1d 6662
e3b27b31
PE
6663 Don't publish debugger-only interfaces to other modules.
6664 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6665 (verify_bytepos, count_markers): Move decls to the only modules
6666 that need them.
6667 * region-cache.h (pp_cache): Likewise.
6668 * window.h (check_all_windows): Likewise.
6669 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6670
5d4cb038
PE
6671 * sysdep.c (croak): Now static, if
6672 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6673 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6674
6675 * alloc.c (refill_memory_reserve): Now static if
6676 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6677 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6678
e87b6180
PE
6679 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6680 Define only if USE_LUCID.
6681
ac64929e
PE
6682 * xrdb.c (x_customization_string, x_rm_string): Now static.
6683
6f37259d
PE
6684 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6685 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6686
1683e3ab
PE
6687 * xdisp.c (draw_row_with_mouse_face): Now static.
6688 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6689
de9c2632
PE
6690 * window.h (check_all_windows): Mark externally visible.
6691
2b96acb7
PE
6692 * window.c (window_deletion_count): Now static.
6693
6694 * undo.c: Make symbols static if they're not exported.
6695 (last_undo_buffer, last_boundary_position, pending_boundary):
6696 Now static.
6697
50436f33
PE
6698 * textprop.c (interval_insert_behind_hooks): Now static.
6699 (interval_insert_in_front_hooks): Likewise.
6700
64520e5c
PE
6701 * term.c: Make symbols static if they're not exported.
6702 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6703 (max_frame_lines, tty_set_terminal_modes):
6704 (tty_reset_terminal_modes, tty_turn_off_highlight):
6705 (get_tty_terminal): Now static.
6706 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6707 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6708 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6709 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6710 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6711
1fa53021
PE
6712 * sysdep.c: Make symbols static if they're not exported.
6713 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6714 Now static.
6715 (sigprocmask_set, full_mask): Remove; unused.
6716 (wait_debugging): Mark as visible.
6717 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6718 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6719
d4b43b22
PE
6720 * syntax.c (syntax_temp): Define only if !__GNUC__.
6721
b7c513d0
PE
6722 * sound.c (current_sound_device, current_sound): Now static.
6723
989b29ad
PE
6724 * search.c (searchbufs, searchbuf_head): Now static.
6725
13a55a78
PE
6726 * scroll.c (scroll_cost): Remove; unused.
6727 * dispextern.h (scroll_cost): Remove decl.
6728
de68a1fc
PE
6729 * region-cache.h (pp_cache): Mark as externally visible.
6730
40ccffa6
PE
6731 * process.c: Make symbols static if they're not exported.
6732 (process_tick, update_tick, create_process, chan_process):
6733 (Vprocess_alist, proc_buffered_char, datagram_access):
6734 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6735 (deactivate_process): Mark defn as static, as well as decl.
6736 * lisp.h (create_process): Remove decl.
6737 * process.h (chan_process, Vprocess_alist): Remove decls.
6738
ad64fc97
PE
6739 * print.c: Make symbols static if they're not exported.
6740 (print_depth, new_backquote_output, being_printed, print_buffer):
6741 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6742 (print_interval, print_number_index, initial_stderr_stream):
6743 Now static.
6744 * lisp.h (Fprinc): Remove decl.
6745 (debug_output_compilation_hack): Mark as externally visible.
6746
adddb265
PE
6747 * sysdep.c (croak): Move decl from here to syssignal.h.
6748 * syssignal.h (croak): Put it here, so the API can be checked when
6749 'croak' is called from dissociate_if_controlling_tty.
6750
1717ede2
PE
6751 * minibuf.c: Make symbols static if they're not exported.
6752 (minibuf_save_list, choose_minibuf_frame): Now static.
6753 * lisp.h (choose_minibuf_frame): Remove decl.
6754
fa5fb2bc
PE
6755 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6756
1e3890d1
PE
6757 * lread.c: Make symbols static if they're not exported.
6758 (read_objects, initial_obarray, oblookup_last_bucket_number):
6759 Now static.
6760 (make_symbol): Remove; unused.
6761 * lisp.h (initial_obarray, make_symbol): Remove decls.
6762
8a1414fa
PE
6763 * keyboard.c: Make symbols static if they're not exported.
6764 (single_kboard, recent_keys_index, total_keys, recent_keys):
6765 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6766 (this_single_command_key_start, echoing, last_auto_save):
6767 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6768 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6769 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6770 (Vlispy_mouse_stem, double_click_count):
6771 Now static.
6772 (force_auto_save_soon): Define only if SIGDANGER.
6773 (ignore_mouse_drag_p): Now static if
6774 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6775 (print_help): Remove; unused.
6776 (stop_character, last_timer_event): Mark as externally visible.
6777 * keyboard.h (ignore_mouse_drag_p): Declare only if
6778 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6779 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6780 * lisp.h (echoing): Remove decl.
6781 (force_auto_save_soon): Declare only if SIGDANGER.
6782 * xdisp.c (redisplay_window): Simplify code, to make it more
6783 obvious that ignore_mouse_drag_p is not accessed if !defined
6784 USE_GTK && !defined HAVE_NS.
6785
93ea6e8f
PE
6786 * intervals.c: Make symbols static if they're not exported.
6787 (merge_properties_sticky, merge_interval_right, delete_interval):
6788 Now static.
6789 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6790
77382fcc
PE
6791 * insdel.c: Make symbols static if they're not exported.
6792 However, leave prepare_to_modify_buffer alone. It's never
6793 called from outside this function, but that appears to be a bug.
6794 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6795 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6796 (adjust_after_replace_noundo): Remove; unused.
6797 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6798 (signal_before_change): Remove decls.
77382fcc 6799
9306c32e
PE
6800 * indent.c (val_compute_motion, val_vmotion): Now static.
6801
cd44d2eb
PE
6802 * image.c: Make symbols static if they're not exported.
6803 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6804 if USE_GTK.
6805 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6806 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6807
ad9a7a06
PE
6808 * fringe.c (standard_bitmaps): Now static.
6809 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6810
81626931
PE
6811 * frame.c: Make symbols static if they're not exported.
6812 (x_report_frame_params, make_terminal_frame): Now static.
6813 (get_frame_param): Now static, unless HAVE_NS.
6814 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6815 (x_get_resource_string): Remove; not used.
6816 * frame.h (make_terminal_frame, x_report_frame_params):
6817 (x_get_resource_string); Remove decls.
6818 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6819 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6820
239f9db9
PE
6821 * font.c, fontset.c: Make symbols static if they're not exported.
6822 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6823 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6824 * font.c (font_close_object): Now static.
6825 * font.h (font_close_object): Remove.
6826 * fontset.c (FONTSET_OBJLIST): Remove.
6827 (free_realized_fontset) #if-0 the body, which does nothing.
6828 (face_suitable_for_char_p): #if-0, as it's never called.
6829 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6830 * xfaces.c (face_at_string_position):
6831 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6832 since 0 is always ASCII.
6833
dfcf3579
PE
6834 * fns.c (weak_hash_tables): Now static.
6835
5045092b
PE
6836 * fileio.c: Make symbols static if they're not exported.
6837 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6838 (Vwrite_region_annotation_buffers): Now static.
6839
57a96f5c
PE
6840 * eval.c: Make symbols static if they're not exported.
6841 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6842 * lisp.h (backtrace_list): Remove decl.
6843
35f08c38
PE
6844 * emacs.c: Make symbols static if they're not exported.
6845 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6846 (fatal_error_code, fatal_error_signal_hook, standard_args):
6847 Now static.
6848 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6849 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6850 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6851 * lisp.h (fatal_error_signal_hook): Remove decl.
6852 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6853
f44bd759
PE
6854 * editfns.c: Move a (normally-unused) function to its only use.
6855 * editfns.c, lisp.h (get_operating_system_release): Remove.
6856 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6857 worth the hassle of breaking this out.
6858
b532497d
PE
6859 * xterm.c: Make symbols static if they're not exported.
6860 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6861 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6862 (x_destroy_window, x_delete_display):
6863 Now static.
6864 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6865 (x_mouse_leave): Remove; unused.
6866 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6867 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6868 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6869 Remove decls.
6870 (x_mouse_leave): Declare only if WINDOWSNT.
6871 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6872 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6873 USE_X_TOOLKIT.
6874
1675728f
PE
6875 * ftxfont.c: Make symbols static if they're not exported.
6876 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6877 HAVE_FREETYPE.
6878 * font.h (ftxfont_driver): Likewise.
6879
e4cebfca
PE
6880 * xfns.c: Make symbols static if they're not exported.
6881 (x_last_font_name, x_display_info_for_name):
6882 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6883 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6884 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6885 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6886 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6887 (last_show_tip_args): Now static.
6888 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6889 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6890 (x_screen_planes): Remove; unused.
6891 * dispextern.h (x_screen_planes): Remove decl.
6892
5bf46f05
PE
6893 * dispnew.c: Make symbols static if they're not exported.
6894 * dispextern.h (redraw_garbaged_frames, scrolling):
6895 (increment_row_positions): Remove.
6896 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6897 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6898 Now static.
6899 (redraw_garbaged_frames): Remove; unused.
6900
435f4c28
PE
6901 * xfaces.c: Make symbols static if they're not exported.
6902 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6903 Remove decls.
6904 * xterm.h (defined_color): Remove decls.
6905 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6906 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6907 (menu_face_changed_default, defined_color, free_realized_face):
6908 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6909 (ascii_face_of_lisp_face): Remove; unused.
6910
8524aef3
PE
6911 * xdisp.c: Make symbols static if they're not exported.
6912 * dispextern.h (scratch_glyph_row, window_box_edges):
6913 (glyph_to_pixel_coords, set_cursor_from_row):
6914 (get_next_display_element, set_iterator_to_next):
6915 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6916 (show_mouse_face): Remove decls
6917 * frame.h (message_buf_print): Likewise.
6918 * lisp.h (pop_message, set_message, check_point_in_composition):
6919 Likewise.
6920 * xterm.h (set_vertical_scroll_bar): Likewise.
6921 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6922 (message_buf_print, scratch_glyph_row, displayed_buffer):
6923 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6924 (get_next_display_element, show_mouse_face, window_box_edges):
6925 (frame_to_window_pixel_xy, check_point_in_composition):
6926 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6927 (glyph_to_pixel_coords): Remove; unused.
6928
16390cd2
PE
6929 * dired.c (file_name_completion): Now static.
6930
6931 * dbusbind.c (xd_in_read_queued_messages): Now static.
6932
a25f4dfa
PE
6933 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6934 * data.c (circular_list_error): Remove.
6935
14a9c8df
PE
6936 * commands.h (last_point_position, last_point_position_buffer):
6937 (last_point_position_window): Remove decls.
6938 * keyboard.c: Make these variables static.
6939
04f2d78b
CB
6940 * coding.h (coding, code_convert_region, encode_coding_gap):
6941 Remove decls.
74ab6df5
PE
6942 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6943 (iso_code_class, detect_coding, code_convert_region): Now static.
6944 (encode_coding_gap): Remove; unused.
6945
38dfbee1
PE
6946 * chartab.c (chartab_chars, chartab_bits): Now static.
6947
a2cb4e63
PE
6948 * charset.h (charset_iso_8859_1): Remove decl.
6949 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6950 Now static.
6951
127198fd
PE
6952 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6953 * ccl.c (Vccl_program_table): Now static.
6954 (check_ccl_update): Remove; unused.
6955
d85b608f
PE
6956 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6957 * category.h: ... from here.
6958 * category.c (check_category_table, set_category_set): Now static.
6959
31cd66f3
PE
6960 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6961 * lisp.h: Remove these decls.
6962
c358e587
PE
6963 * buffer.c (buffer_count): Remove unused var.
6964
e78aecca
PE
6965 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6966 so that it's not optimized away.
6967 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6968 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6969 exported only to the debugger.
6970
e192d7d3 6971 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6972 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6973
92470028
PE
6974 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6975 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6976 was inaccessible from Lisp.
6977 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6978 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6979
244ed907
PE
6980 alloc.c: Import and export fewer symbols, and remove unused items.
6981 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6982 is defined.
6983 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6984 it's not optimized away by whole-program optimization.
6985 (message_enable_multibyte, free_misc): Remove.
6986 (catchlist, handlerlist, mark_backtrace):
6987 Declare only if BYTE_MARK_STACK.
6988 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6989 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6990 (message_enable_multibyte): Remove decl.
6991 (free_misc, interval_free_list, float_block, float_block_index):
6992 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6993 (cons_free_list, last_marked_index):
6994 Now static.
6995 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6996 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6997 (mark_backtrace): Define only if BYTE_MARK_STACK.
6998 * xdisp.c (message_enable_multibyte): Now static.
6999
61c2b50e 7000 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7001 This makes it easier for human readers (and static analyzers)
7002 to see whether these variables are used from other modules.
7003 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7004 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7005 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7006 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7007 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7008 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7009 * xmenu.c, xselect.c:
7010 Declare Q* vars static if they are not used in other modules.
7011 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7012 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7013 Remove decls of unexported vars.
7014 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7015
95c82688
PE
7016 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7017
16a97296
PE
7018 Make Emacs functions such as Fatom 'static' by default.
7019 This makes it easier for human readers (and static analyzers)
7020 to see whether these functions can be called from other modules.
7021 DEFUN now defines a static function. To make the function external
7022 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7023 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7024 (Finit_image_library):
16a97296
PE
7025 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7026 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7027 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7028 Remove decls, since these functions are now static.
7029 (Funintern, Fget_internal_run_time): New decls, since these functions
7030 were already external.
95c82688 7031
16a97296
PE
7032 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7033 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7034 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7035 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7036 * keyboard.c, keymap.c, lread.c:
7037 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7038 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7039 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7040 Mark functions with DEFUE instead of DEFUN,
7041 if they are used in other modules.
7042 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7043 decls for now-static functions.
7044 * buffer.h (Fdelete_overlay): Remove decl.
7045 * callproc.c (Fgetenv_internal): Mark as internal.
7046 * composite.c (Fremove_list_of_text_properties): Remove decl.
7047 (Fcomposition_get_gstring): New forward static decl.
7048 * composite.h (Fcomposite_get_gstring): Remove decl.
7049 * dired.c (Ffile_attributes): New forward static decl.
7050 * doc.c (Fdocumntation_property): New forward static decl.
7051 * eval.c (Ffetch_bytecode): New forward static decl.
7052 (Funintern): Remove extern decl; now in .h file where it belongs.
7053 * fileio.c (Fmake_symbolic_link): New forward static decl.
7054 * image.c (Finit_image_library): New forward static decl.
7055 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7056 * intervals.h (Fprevious_property_change):
7057 (Fremove_list_of_text_properties): Remove decls.
7058 * keyboard.c (Fthis_command_keys): Remove decl.
7059 (Fcommand_execute): New forward static decl.
7060 * keymap.c (Flookup_key): New forward static decl.
7061 (Fcopy_keymap): Now static.
7062 * keymap.h (Flookup_key): Remove decl.
7063 * process.c (Fget_process): New forward static decl.
7064 (Fprocess_datagram_address): Mark as internal.
7065 * syntax.c (Fsyntax_table_p): New forward static decl.
7066 (skip_chars): Remove duplicate decl.
7067 * textprop.c (Fprevious_property_change): New forward static decl.
7068 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7069 Now internal.
7070 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7071 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7072
785bbd42
PE
7073 * editfns.c (Fformat): Remove unreachable code.
7074
8b913b57
AS
70752011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7076
7077 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7078 change. (Bug#8496)
7079
a6744a35
EZ
70802011-04-13 Eli Zaretskii <eliz@gnu.org>
7081
7082 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7083 when at ZV. (Bug#8487)
7084
e7974947
AS
70852011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7086
baad03f0
AS
7087 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7088 (Bug#8437)
7089 * keyboard.c (parse_tool_bar_item): Likewise.
7090 * sound.c (sound_cleanup, alsa_close): Likewise.
7091 * termcap.c (tgetent): Likewise.
7092 * xfns.c (x_default_font_parameter): Likewise.
7093 * xsettings.c (read_and_apply_settings): Likewise.
7094
e7974947
AS
7095 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7096 (overrun_check_free): Protoize.
7097
28272684
PE
70982011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7099
7100 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7101 since callers should never pass a negative size.
7102 Change the signature to match that of plain 'read' and 'write'; see
7103 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7104 * lisp.h: Update prototypes of emacs_write and emacs_read.
7105
11997c76
EZ
71062011-04-11 Eli Zaretskii <eliz@gnu.org>
7107
7108 * xdisp.c (redisplay_window): Don't try to determine the character
7109 position of the scroll margin if the window start point w->startp
e896f03c 7110 is outside the buffer's accessible region. (Bug#8468)
11997c76 7111
8a2cbd72
EZ
71122011-04-10 Eli Zaretskii <eliz@gnu.org>
7113
7114 Fix write-region and its subroutines for buffers > 2GB.
7115 * fileio.c (a_write, e_write): Modify declaration of arguments and
7116 local variables to support buffers larger than 2GB.
7117 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7118
7119 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7120 argument, local variables, and return value.
7121
7122 * lisp.h: Update prototypes of emacs_write and emacs_read.
7123
7124 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7125
4073e537 71262011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7127
1ebfdcb6
PE
7128 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7129
b2ded58d
PE
7130 Fix more problems found by GCC 4.6.0's static checks.
7131
7d66342c
PE
7132 * xdisp.c (vmessage): Use a better test for character truncation.
7133
bbf47d44
PE
7134 * charset.c (load_charset_map): <, not <=, for optimization,
7135 and to avoid potential problems with integer overflow.
9248994d 7136 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7137 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7138 * editfns.c (Fformat): Likewise.
1e69125e 7139 * syntax.c (skip_chars): Likewise.
3befa583 7140
e3019616
PE
7141 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7142 This also lets GCC 4.6.0 generate slightly better loop code.
7143
becfa255
PE
7144 * callint.c (Fcall_interactively): <, not <=, for optimization.
7145 (Fcall_interactively): Count the number of arguments produced,
7146 not the number of arguments given. This is simpler and lets GCC
7147 4.6.0 generate slightly better code.
7148
dae0cd48
PE
7149 * ftfont.c: Distingish more carefully between FcChar8 and char.
7150 The previous code passed unsigned char * to a functions like
7151 strlen and xstrcasecmp that expect char *, which does not
7152 conform to the C standard.
7153 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7154 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7155 char * when the C standard requires it.
7156
76032d70
PE
7157 * keyboard.c (read_char): Remove unused var.
7158
eb3f1cc8
PE
7159 * eval.c: Port to Windows vsnprintf (Bug#8435).
7160 Include <limits.h>.
7161 (SIZE_MAX): Define if the headers do not.
7162 (verror): Do not give up if vsnprintf returns a negative count.
7163 Instead, grow the buffer. This ports to Windows vsnprintf, which
7164 does not conform to C99. Problem reported by Eli Zaretskii.
7165 Also, simplify the allocation scheme, by avoiding the need for
7166 calling realloc, and removing the ALLOCATED variable.
7167
70476b54
PE
7168 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7169
12020a9e
PE
7170 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7171 But keep the doprint source code for now, as we might revamp it
7172 and use it again (Bug#8435).
ea6c7ae6
PE
7173 * lisp.h (doprnt): Remove.
7174 * Makefile.in (base_obj): Remove doprnt.o.
7175 * deps.mk (doprnt.o): Remove.
7176
5fdb398c
PE
7177 error: Print 32- and 64-bit integers portably (Bug#8435).
7178 Without this change, on typical 64-bit hosts error ("...%d...", N)
7179 was used to print both 32- and 64-bit integers N, which relied on
7180 undefined behavior.
7181 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7182 New macro.
7183 * lisp.h (error, verror): Mark as printf-like functions.
7184 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7185 Report overflow in size calculations when allocating printf buffer.
7186 Do not truncate output string at its first null byte.
7187 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7188 Truncate the output at a character boundary, since vsnprintf does not
7189 do that.
7190 * charset.c (check_iso_charset_parameter): Convert internal
7191 character to string before calling 'error', since %c now has the
7192 printf meaning.
7193 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7194 overflow when computing char to be passed to 'error'. Do not
7195 pass Lisp_Object to 'error'; pass the integer instead.
7196 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7197 formatted with plain %d.
7198
b189fa66
PE
7199 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7200
bff87ef0
PE
7201 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7202
7e2cac20
PE
7203 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7204
ce4d90b5
PE
7205 * xterm.c (x_catch_errors): Remove duplicate declaration.
7206
266c9547
PE
7207 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7208
79c49ad2
PE
7209 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7210
368f4090
JM
72112011-04-10 Jim Meyering <meyering@redhat.com>
7212
7213 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7214 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7215 return ssize_t not "int", and use size_t as the buffer length.
7216 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7217 * gnutls.h: Update declarations.
7218 * process.c (read_process_output): Use ssize_t, to match.
7219 (send_process): Likewise.
7220
a32d4040
CY
72212011-04-09 Chong Yidong <cyd@stupidchicken.com>
7222
7223 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7224
8546720e 72252011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7226
04f2d78b
CB
7227 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7228 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7229
8546720e
GM
7230 * xterm.c (handle_one_xevent):
7231 * xmenu.c (create_and_show_popup_menu):
7232 * xselect.c (x_decline_selection_request)
7233 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7234
0a2f5c1a 72352011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7236
7237 Fix some uses of `int' instead of EMACS_INT.
7238 * search.c (string_match_1, fast_string_match)
7239 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7240 (scan_buffer, find_next_newline_no_quit)
7241 (find_before_next_newline, search_command, Freplace_match)
7242 (Fmatch_data): Make some `int' variables be EMACS_INT.
7243
7244 * xdisp.c (display_count_lines): 3rd argument and return value now
7245 EMACS_INT. All callers changed.
7246 (pint2hrstr): Last argument is now EMACS_INT.
7247
7248 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7249 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7250 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7251 (decode_coding_utf_16, decode_coding_emacs_mule)
7252 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7253 (decode_coding_ccl, decode_coding_charset)
7254 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7255 (decode_coding_iso_2022, decode_coding_emacs_mule)
7256 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7257 <char_offset, last_offset>: Declare EMACS_INT.
7258 (encode_coding_utf_8, encode_coding_utf_16)
7259 (encode_coding_emacs_mule, encode_invocation_designation)
7260 (encode_designation_at_bol, encode_coding_iso_2022)
7261 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7262 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7263 Declare EMACS_INT.
7264 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7265 (encode_invocation_designation): Last argument P_NCHARS is now
7266 EMACS_INT.
7267 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7268 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7269
7270 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7271 All users changed.
7272
7273 * ccl.c (Fccl_execute_on_string): Declare some variables
7274 EMACS_INT.
7275
8546720e 72762011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7277
7278 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7279
4e19a977
CS
72802011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7281
7282 * process.c (Fformat_network_address): Doc fix.
7283
87302331
R
72842011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7285
ee7683eb 7286 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7287
cbb59342
CY
72882011-04-08 Chong Yidong <cyd@stupidchicken.com>
7289
7290 * keyboard.c (read_char): Call Lisp function help-form-show,
7291 instead of using internal_with_output_to_temp_buffer.
7292 (Qhelp_form_show): New var.
e0d38eeb 7293 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7294
7295 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7296
7297 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7298
e67a13ab
CY
72992011-04-06 Chong Yidong <cyd@stupidchicken.com>
7300
04f2d78b
CB
7301 * process.c (Flist_processes): Remove to Lisp.
7302 (list_processes_1): Delete.
e67a13ab 7303
973f782d
EZ
73042011-04-06 Eli Zaretskii <eliz@gnu.org>
7305
7c106b1e
EZ
7306 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7307
973f782d
EZ
7308 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7309
41cf7d1a 73102011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7311
ca23cc88
PE
7312 Fix more problems found by GCC 4.6.0's static checks.
7313
f390e2d5
PE
7314 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7315
42eea0d0
PE
7316 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7317
b69769da 7318 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7319
f9541e84
PE
7320 * xdisp.c (vmessage): Mark as a printf-like function.
7321
13841b55
PE
7322 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7323
c136c10f
PE
7324 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7325
5e2d4a30
PE
7326 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7327 printf-like functions.
7328 (tiff_load): Add casts to remove these marks before passing them
7329 to system-supplied API.
7330
583f48b9
PE
7331 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7332
b25d760e
PE
7333 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7334 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7335 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7336 directly, rather than having caller test rule sign. This avoids
7337 some unnecessary tests.
7338 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7339 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7340 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7341
bc7b6697 7342 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7343 (xfont_open): Avoid unnecessary tests.
bc7b6697 7344
27ccc379
PE
7345 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7346
dcd5c89a
PE
7347 * composite.h, composite.c (composition_gstring_put_cache):
7348 Use EMACS_INT, not int, for length.
7349
b13a45c6
PE
7350 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7351 breaking out part of COMPOSITION_DECODE_RULE.
7352 (COMPOSITION_DECODE_RULE): Use it.
7353 * composite.c (get_composition_id): Remove unused local vars,
7354 by using the new macro.
7355
1e792e4d
PE
7356 * textprop.c (set_text_properties_1): Change while to do-while,
7357 since the condition is always true at first.
7358
dc6c6455 7359 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7360 (interval_deletion_adjustment): Return unsigned value.
7361 All uses changed.
dc6c6455 7362
aba7731a
PE
7363 * process.c (list_processes_1, create_pty, read_process_output):
7364 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7365 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7366 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7367 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7368 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7369
fdfc4bf3
PE
7370 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7371
fca8fe46 7372 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7373 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7374
06a0259a 7375 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7376 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7377 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7378
e7b9e80f
PE
7379 * print.c (print_error_message): Avoid int overflow.
7380
56201685
PE
7381 * font.c (font_list_entities): Redo for clarity,
7382 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7383
78834453 7384 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7385 (font_score): Avoid potential overflow in diff calculation.
78834453 7386
0bc0b309 7387 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7388 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7389
e610eaca
PE
7390 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7391
b895abce
PE
7392 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7393 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7394 can always succeed if overflow has undefined behavior.
7395
1f1d9321 7396 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7397 (wordify): Omit three unnecessary tests.
1f1d9321 7398
c59478bc
PE
7399 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7400 All callers changed. This avoids the need for an unused var.
7401
79b73827
PE
7402 * casefiddle.c (casify_region): Remove var that is set but not used.
7403
a4db5dfe
PE
7404 * dired.c (file_name_completion): Remove var that is set but not used.
7405
43aae36e
PE
7406 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7407
2a47c44d 7408 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7409 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7410
a37c69bf
PE
7411 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7412 Check for integer overflow on size calculations.
7413
328ab8e7
PE
7414 * buffer.c (Fprevious_overlay_change): Remove var that is set
7415 but not used.
7416
e5a2a5cb
PE
7417 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7418 Remove vars that are set but not used.
8d84a6eb 7419 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7420 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7421
a60e5f68
PE
7422 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7423
f661cb61 7424 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7425 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7426
f0397f5a
PE
7427 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7428 that are set but not used.
7429
8664db06 7430 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7431 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7432
6abdaa4a
PE
7433 * xselect.c (x_get_local_selection, x_handle_property_notify):
7434 Remove vars that are set but not used.
7435
0ce7538d 7436 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7437 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7438
9ae848fc
PE
7439 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7440 Remove var that is set but not used.
0b918413
PE
7441 (scroll_bar_windows_size): Now size_t, not int.
7442 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7443 Check for overflow.
9ae848fc 7444
a5a62657
PE
7445 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7446 (map_tty_color) [!defined MSDOS]: Likewise.
7447
5c5cdd39
PE
7448 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7449
66ebf983
PE
7450 * coding.c: Remove vars that are set but not used.
7451 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7452 All callers changed.
7453 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7454 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7455 (decode_coding_charset): Remove vars that are set but not used.
7456
1be4d761
PE
7457 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7458 that is set but not used.
7459
47553fa8
PE
7460 * print.c (print_object): Remove var that is set but not used.
7461
1f7196bf 7462 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7463 The gnulib version avoids calling malloc in the usual case,
7464 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7465 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7466 * filelock.c (current_lock_owner): Likewise.
7467 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7468 * sysdep.c: Include allocator.h, careadlinkat.h.
7469 (emacs_no_realloc_allocator): New static constant.
7470 (emacs_readlink): New function.
fdb61804
PE
7471 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7472 ../lib/careadlinkat.h.
d1fdcab7 7473
f84c17c7
SM
74742011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7475
7476 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7477 first non-nil return value).
7478
ef3862ad
JD
74792011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7480
7481 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7482 if not defined (Bug#8403).
7483
376a7006
JB
74842011-04-02 Juanma Barranquero <lekktu@gmail.com>
7485
7486 * xdisp.c (display_count_lines): Remove parameter `start',
7487 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7488 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7489 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7490 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7491 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7492 and thereabouts. All callers changed.
7493 (get_per_char_metric): Remove parameter `f', unused since
7494 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7495
6ca3801d
JM
74962011-04-02 Jim Meyering <meyering@redhat.com>
7497
7498 do not dereference NULL upon failed strdup
7499 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7500 (ns_get_family): Likewise.
7501
d8e2b5ba
JB
75022011-04-02 Juanma Barranquero <lekktu@gmail.com>
7503
7504 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7505
8c74fcbd
JD
75062011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7507
7508 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7509 later (Bug#8403).
7510
7200d79c
SM
75112011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7512
03408648 7513 Add lexical binding.
7200d79c 7514
03408648
SM
7515 * window.c (Ftemp_output_buffer_show): New fun.
7516 (Fsave_window_excursion):
7517 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7518
7519 * lread.c (lisp_file_lexically_bound_p): New function.
7520 (Fload): Bind Qlexical_binding.
7521 (readevalloop): Remove `evalfun' arg.
7522 Bind Qinternal_interpreter_environment.
7523 (Feval_buffer): Bind Qlexical_binding.
7524 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7525 Mark as dynamic.
7526 (syms_of_lread): Declare `lexical-binding'.
7527
7528 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7529
7530 * keyboard.c (eval_dyn): New fun.
7531 (menu_item_eval_property): Use it.
ca105506
SM
7532
7533 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7534
03408648
SM
7535 * fns.c (concat, mapcar1): Accept byte-code-functions.
7536
7537 * eval.c (Fsetq): Handle lexical vars.
7538 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7539 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7540 (FletX, Flet): Obey lexical binding.
7541 (Fcommandp): Handle closures.
7542 (Feval): New `lexical' arg.
7543 (eval_sub): New function extracted from Feval. Use it almost
7544 everywhere where Feval was used. Look up vars in lexical env.
7545 Handle closures.
7546 (Ffunctionp): Move from subr.el.
7547 (Ffuncall): Handle closures.
7548 (apply_lambda): Remove `eval_flags'.
7549 (funcall_lambda): Handle closures and new byte-code-functions.
7550 (Fspecial_variable_p): New function.
7551 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7552 but without exporting it to Lisp.
23aba0ea 7553
23aba0ea 7554 * doc.c (Fdocumentation, store_function_docstring):
03408648 7555 * data.c (Finteractive_form): Handle closures.
23aba0ea 7556
03408648
SM
7557 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7558 interactive spec.
ba83908c 7559
04f2d78b
CB
7560 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7561 New byte-codes.
03408648
SM
7562 (exec_byte_code): New function extracted from Fbyte_code to handle new
7563 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7564
03408648 7565 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7566
03408648 7567 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7568
e2abce01
JB
75692011-03-31 Juanma Barranquero <lekktu@gmail.com>
7570
7571 * xdisp.c (redisplay_internal): Fix prototype.
7572
63696a73 75732011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7574
63696a73 7575 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7576 (try_scrolling): Use it when setting scroll_limit.
7577 Limit scrolling to 100 screen lines.
63696a73
EZ
7578 (redisplay_window): Even when falling back on "recentering",
7579 position point in the window according to scroll-conservatively,
7580 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7581
7582 (try_scrolling): When point is above the window, allow searching
7583 as far as scroll_max, or one screenful, to compute vertical
7584 distance from PT to the scroll margin position. This prevents
7585 try_scrolling from unnecessarily failing when
7586 scroll-conservatively is set to a value slightly larger than the
7587 window height. Clean up the case of PT below the margin at bottom
7588 of window: scroll_max can no longer be INT_MAX. When aggressive
7589 scrolling is in use, don't let point enter the opposite scroll
7590 margin as result of the scroll.
7591 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7592 threshold of 100 lines for never-recentering scrolling.
7593
e4cc2dfc
JB
75942011-03-31 Juanma Barranquero <lekktu@gmail.com>
7595
7596 * dispextern.h (move_it_by_lines):
7597 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7598 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7599 (message_log_check_duplicate): Remove parameters `prev_bol' and
7600 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7601 (redisplay_internal): Remove parameter `preserve_echo_area',
7602 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7603
7604 * indent.c (Fvertical_motion):
7605 * window.c (window_scroll_pixel_based, Frecenter):
7606 Don't pass `need_y_p' to `move_it_by_lines'.
7607
1c470562
SM
76082011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7609
44f230aa
SM
7610 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7611 steal a few bits to be more compact.
7612 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7613 Remove unneeded casts.
7614
1c470562
SM
7615 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7616
888adce9
ZK
76172011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7618
7619 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7620 binding" message (bug#7967).
7621
f838ed7b
PE
76222011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7623
77861b95
PE
7624 Fix more problems found by GCC 4.6.0's static checks.
7625
de6dbc14
PE
7626 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7627 Remove unused local var.
7628
f838ed7b
PE
7629 * editfns.c (Fmessage_box): Remove unused local var.
7630
792c7b2b
PE
7631 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7632 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7633 Omit unused local vars.
c499e557 7634 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7635 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7636 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7637 Omit unused local var.
7638
ba0165e1
PE
7639 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7640 Don't assume string length fits in int.
32ad8845 7641 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7642 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7643
3c59b4c9
PE
7644 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7645 instead of alloca (Bug#8344).
7646
a3eed478 7647 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7648 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7649
eb4d412d
PE
7650 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7651
1658b401
PE
7652 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7653 concerns.
7654
7655 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7656
7657 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7658
9a2c6e05
PE
7659 * keyboard.c (syms_of_keyboard): Use the same style as later
7660 in this function when indexing through an array. This also
7661 works around GCC bug 48267.
7662
03d0a109
PE
7663 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7664
44f730c8
PE
7665 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7666
fe75f926
PE
7667 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7668 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7669
ffa8c828
PE
7670 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7671 This avoids undefined behavior on integer overflow, and is a bit
7672 more convenient anyway since it is compared to a size_t variable.
7673
c5101a77
PE
7674 Variadic C functions now count arguments with size_t, not int.
7675 This avoids an unnecessary limitation on 64-bit machines, which
7676 caused (substring ...) to crash on large vectors (Bug#8344).
7677 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7678 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7679 All variadic functions and their callers changed accordingly.
c5101a77
PE
7680 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7681 * data.c (arith_driver, float_arith_driver): Likewise.
7682 * editfns.c (general_insert_function): Likewise.
7683 * eval.c (struct backtrace.nargs, interactive_p)
7684 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7685 (funcall_lambda, mark_backtrace): Likewise.
7686 * fns.c (concat): Likewise.
7687 * frame.c (x_set_frame_parameters): Likewise.
7688 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7689 0 if not found, not -1. All callers changed.
7690
dd3f25f7
PE
7691 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7692 (stack_copy_size): Now size_t, not int.
7693 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7694
461c2ab9
JB
76952011-03-28 Juanma Barranquero <lekktu@gmail.com>
7696
7697 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7698 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7699 All callers changed.
7700
7701 * lisp.h (multibyte_char_to_unibyte):
7702 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7703 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7704 * character.h (CHAR_TO_BYTE8):
7705 * cmds.c (internal_self_insert):
7706 * editfns.c (general_insert_function):
7707 * keymap.c (push_key_description):
7708 * search.c (Freplace_match):
7709 * xdisp.c (message_dolog, set_message_1): All callers changed.
7710
f6d62986
SM
77112011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7712
7713 * keyboard.c (safe_run_hook_funcall): New function.
7714 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7715 don't set the hook to nil, but remove the offending function instead.
7716 (Qcommand_hook_internal): Remove, unused.
7717 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7718 Vcommand_hook_internal.
7719
7720 * eval.c (enum run_hooks_condition): Remove.
7721 (funcall_nil, funcall_not): New functions.
7722 (run_hook_with_args): Call each function through a `funcall' argument.
7723 Remove `cond' argument, now redundant.
7724 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7725 (Frun_hook_with_args_until_failure): Adjust accordingly.
7726 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7727
1db5b1ad
JB
77282011-03-28 Juanma Barranquero <lekktu@gmail.com>
7729
7730 * dispextern.h (string_buffer_position): Remove declaration.
7731
7732 * print.c (strout): Remove parameter `multibyte', unused since
7733 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7734
7735 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7736 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7737 All callers changed.
7738
7739 * w32.c (_wsa_errlist): Use braces for struct initializers.
7740
7741 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7742 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7743 All callers changed.
7744 (string_buffer_position): Likewise. Also, make static (it's never
7745 used outside xdisp.c).
7746 (cursor_row_p): Remove parameter `w', unused since
7747 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7748 (decode_mode_spec): Remove parameter `precision', introduced during
7749 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7750 All callers changed.
7751
5ffb62aa
JD
77522011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7753
7754 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7755
461c2ab9 77562011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7757
7758 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7759 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7760 (ns_update_auto_hide_menu_bar): New functions.
7761 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7762 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7763 ns_constrain_all_frames.
7764 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7765 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7766
5c380ffb
JD
77672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7768
7769 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7770
9af30bdf
GM
77712011-03-27 Glenn Morris <rgm@gnu.org>
7772
7773 * syssignal.h: Replace RETSIGTYPE with void.
7774 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7775 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7776 Replace SIGTYPE with void everywhere.
7777 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7778 * s/template.h (SIGTYPE): Remove commented out definition.
7779
e2abce01
JB
77802011-03-26 Eli Zaretskii <eliz@gnu.org>
7781
7782 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7783 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7784
f868cd8a
JB
77852011-03-26 Juanma Barranquero <lekktu@gmail.com>
7786
59eb0929
JB
7787 * w32.c (read_unc_volume): Use parameter `henum', instead of
7788 global variable `wget_enum_handle'.
7789
7790 * keymap.c (describe_vector): Remove parameters `indices' and
7791 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7792 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7793
f868cd8a
JB
7794 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7795
7796 * keyboard.c (timer_check): Remove parameter `do_it_now',
7797 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7798 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7799 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7800
7801 * keyboard.c (read_char):
7802 * w32menu.c (w32_menu_display_help):
7803 * xmenu.c (show_help_event, menu_help_callback):
7804 Adjust calls to `show_help_echo'.
7805
7806 * gtkutil.c (xg_maybe_add_timer):
7807 * keyboard.c (readable_events):
7808 * process.c (wait_reading_process_output):
7809 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7810
7811 * insdel.c (adjust_markers_gap_motion):
7812 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7813 (gap_left, gap_right): Don't call it.
7814
2ecf6fdb
CY
78152011-03-25 Chong Yidong <cyd@stupidchicken.com>
7816
7817 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7818 incurred during fontification.
7819
6b1f9ba4
JB
78202011-03-25 Juanma Barranquero <lekktu@gmail.com>
7821
7822 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7823 (DEFVAR_PER_BUFFER): Don't pass it.
7824
7825 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7826 (scrolling_window): Don't pass it.
7827
0f4a96b5
JB
78282011-03-25 Juanma Barranquero <lekktu@gmail.com>
7829
7830 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7831
7832 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7833 and `suffix'.
7834 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7835 of variables specific to SELinux and computation of `encoded_absname'.
7836
7837 * image.c (XPutPixel): Remove unused variable `height'.
7838
7839 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7840
7841 * unexw32.c (get_section_info): Remove unused variable `section'.
7842
7843 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7844 (system_process_attributes): Remove unused variable `sess'.
7845 (sys_read): Remove unused variable `err'.
7846
7847 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7848 (w32_wnd_proc): Remove unused variable `isdead'.
7849 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7850 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7851 (x_create_tip_frame): Remove unused variable `tem'.
7852
7853 * w32inevt.c (w32_console_read_socket):
7854 Remove unused variable `no_events'.
7855
7856 * w32term.c (x_draw_composite_glyph_string_foreground):
7857 Remove unused variable `width'.
7858
1149507c
JB
78592011-03-24 Juanma Barranquero <lekktu@gmail.com>
7860
7861 * w32term.c (x_set_glyph_string_clipping):
7862 Don't pass uninitialized region to CombineRgn.
7863
9c88f339
JB
78642011-03-23 Juanma Barranquero <lekktu@gmail.com>
7865
7866 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7867 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7868 (Fx_close_connection): Remove unused variable `i'.
7869
7870 * w32font.c (w32font_draw): Return number of glyphs.
7871 (w32font_open_internal): Remove unused variable `i'.
7872 (w32font_driver): Add missing initializer.
7873
7874 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7875 (fill_in_menu): Remove unused variable `items_added'.
7876
7877 * w32term.c (last_mouse_press_frame): Remove static global variable.
7878 (w32_clip_to_row): Remove unused variable `f'.
7879 (x_delete_terminal): Remove unused variable `i'.
7880
7881 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7882 (NOTHING): Remove unused static global variable.
7883 (uniscribe_check_otf): Remove unused variable `table'.
7884 (uniscribe_font_driver): Add missing initializers.
7885
dee091a3
JD
78862011-03-23 Julien Danjou <julien@danjou.info>
7887
7888 * term.c (Fsuspend_tty, Fresume_tty):
7889 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7890 * window.c (temp_output_buffer_show):
7891 * insdel.c (signal_before_change):
7892 * frame.c (Fhandle_switch_frame):
7893 * fileio.c (Fdo_auto_save):
7894 * emacs.c (Fkill_emacs):
7895 * editfns.c (save_excursion_restore):
7896 * cmds.c (internal_self_insert):
7897 * callint.c (Fcall_interactively):
7898 * buffer.c (Fkill_all_local_variables):
7899 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7900 Use Frun_hooks.
0f4a96b5 7901 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7902 unconditionally since it does the check itself.
dee091a3 7903
2c520ab5 79042011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7905
c9c49752
PE
7906 Fix more problems found by GCC 4.5.2's static checks.
7907
8abc3f12
PE
7908 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7909 the first time through the loop, since we know p0 < p1 then.
7910 This also avoids a gcc -Wstrict-overflow warning.
7911
a2d26660
PE
7912 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7913 leading to a memory leak, possible in functions like
7914 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7915 of objects (Bug#8318).
a2d26660 7916
916c72e9
PE
7917 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7918 that could (at least in theory) be that large.
7919
19ab8a18
PE
7920 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7921 This is less likely to overflow, and avoids undefined behavior if
7922 overflow does occur. All callers changed. Use strtoul to scan
7923 for the unsigned long integer.
b7cbbd6f
PE
7924 (pint2hrstr): Simplify and tune code slightly.
7925 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7926
f0641eff
PE
7927 * scroll.c (do_scrolling): Work around GCC bug 48228.
7928 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7929
7f650bb9
PE
7930 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7931 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7932 (validate_x_resource_name): Simplify count usage.
7933 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7934
37dd57d1
PE
7935 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7936 fail (Bug#8306).
81e56e61 7937
699979fc 7938 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7939
401bf9b4
PE
7940 * process.c (Fmake_network_process): Use socklen_t, not int,
7941 where POSIX says socklen_t is required in portable programs.
7942 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7943 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7944 (Fmake_network_process, server_accept_connection):
7945 (wait_reading_process_output, read_process_output):
7946 Likewise.
7947
b93aacde
PE
7948 * process.c: Rename or move locals to avoid shadowing.
7949 (list_processes_1, Fmake_network_process):
7950 (read_process_output_error_handler, exec_sentinel_error_handler):
7951 Rename or move locals.
4dc343ee 7952 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7953 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7954 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7955 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7956 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7957
af8a867c 7958 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7959 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7960 Include tparam.h instead, since it declares them.
af8a867c
PE
7961 * cm.h (PC): Remove extern decl; tparam.h now does this.
7962 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7963 * terminfo.c: Include tparam.h, to check interfaces.
7964 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7965 (tparam): Adjust signature to match interface in tparam.h;
7966 this removes some undefined behavior. Check that outstring and len
7967 are zero, which they always are with Emacs.
7968 * tparam.h (PC, BC, UP): New extern decls.
7969
0248044d 7970 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7971 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7972
8ff096c1 7973 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7974 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7975 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7976 (ftfont_list): Remove unused local.
49eaafba
PE
7977 (get_adstyle_property, ftfont_pattern_entity):
7978 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7979 Rename locals to avoid shadowing.
8ff096c1 7980
e2be39f6
PE
7981 * xfont.c (xfont_list_family): Mark var as initialized.
7982
c9735e30
PE
7983 * xml.c (make_dom): Now static.
7984
8f5201ae
PE
7985 * composite.c (composition_compute_stop_pos): Rename local to
7986 avoid shadowing.
b246f932
PE
7987 (composition_reseat_it): Remove unused locals.
7988 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7989 (composition_update_it): Mark var as initialized.
11b61122
PE
7990 (find_automatic_composition): Mark vars as initialized,
7991 with a FIXME (Bug#8290).
8f5201ae 7992
760fbc2c
PE
7993 character.h: Rename locals to avoid shadowing.
7994 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7995 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7996 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7997 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7998 to avoid shadowing.
7999
ff08eb85
PE
8000 * textprop.c (property_change_between_p): Remove; unused.
8001
fc7bf025
PE
8002 * intervals.c (interval_start_pos): Now static.
8003
235d7abc
PE
8004 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8005
44f230aa
SM
8006 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8007 Rename locals to avoid shadowing.
3e7d6594 8008
50060332
PE
8009 * sound.c (wav_play, au_play, Fplay_sound_internal):
8010 Fix pointer signedness.
d01f234b 8011 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8012 (wav_play): Initialize a variable to 0, to prevent undefined
8013 behavior (Bug#8278).
50060332 8014
c4fc4e30
PE
8015 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8016
918436ed
PE
8017 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8018
c939f91b
PE
8019 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8020 clobbering (Bug#8298).
b9c7f648
PE
8021 * sysdep.c (sys_subshell): Likewise.
8022 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8023
6bd8c144
PE
8024 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8025 This should get cleaned up, so that child_setup has the
8026 same signature on all platforms.
8027
7710357c 8028 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8029 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8030
c59da222
CY
80312011-03-22 Chong Yidong <cyd@stupidchicken.com>
8032
8033 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8034 not to be necessary, and produces flickering.
8035
66b87493
GM
80362011-03-20 Glenn Morris <rgm@gnu.org>
8037
8038 * config.in: Remove file.
8039
45b6f6d5
JB
80402011-03-20 Juanma Barranquero <lekktu@gmail.com>
8041
8042 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8043 are now in src/globals.h.
8044 (syms_of_minibuf): Remove spurious & from previous change.
8045
3ec03f7e
LL
80462011-03-20 Leo <sdl.web@gmail.com>
8047
8048 * minibuf.c (completing-read-function): New variable.
8049 (completing-read-default): Rename from completing-read.
8050 (completing-read): Call completing-read-function.
8051
b14e3e21
CY
80522011-03-19 Juanma Barranquero <lekktu@gmail.com>
8053
8054 * xfaces.c (Fx_load_color_file):
8055 Read color file from absolute filename (bug#8250).
8056
f2b726e6
JB
80572011-03-19 Juanma Barranquero <lekktu@gmail.com>
8058
8059 * makefile.w32-in: Update dependencies.
8060
09f6ff02
EZ
80612011-03-17 Eli Zaretskii <eliz@gnu.org>
8062
8063 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8064
29a6015a
PE
80652011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8066
a3a6c54e
PE
8067 Fix more problems found by GCC 4.5.2's static checks.
8068
b766f867
PE
8069 * process.c (make_serial_process_unwind, send_process_trap):
8070 (sigchld_handler): Now static.
8071
be02381c
PE
8072 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8073 That way, the code declares only the vars that it needs.
8074 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8075 * s/cygwin.h (PTY_ITERATION): Likewise.
8076 * s/darwin.h (PTY_ITERATION): Likewise.
8077 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8078
57048744
PE
8079 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8080 * process.c (allocate_pty): Don't declare stb unless it's needed.
8081
7914961c 8082 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8083 (CONSTANTLIM): Remove; unused.
8084 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8085 Define only if needed.
7914961c 8086
b3967b18
PE
8087 * unexelf.c (unexec): Name an expression,
8088 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8089 Use a different way to cause a compilation error if anyone uses
8090 n rather than nn, a way that does not involve shadowing.
73366a00 8091 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8092
29a6015a
PE
8093 * deps.mk (unexalpha.o): Remove; unused.
8094
43cfc33e 8095 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8096 * unexec.h: New file.
ce701a33
PE
8097 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8098 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8099 Depend on unexec.h.
8100 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8101 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8102 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8103 Change as necessary to match prototype in unexec.h.
ce701a33 8104
01f44d5a
PE
8105 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8106 shadowing.
4f63c6bb 8107 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8108
a6670b0b
PE
8109 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8110 Rename locals to avoid shadowing.
8111
cef2010d 8112 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8113 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8114
d4d7173a
PE
8115 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8116
f08b802a
PE
8117 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8118 warning when compiling print.c.
8119
3ddb0639
PE
8120 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8121 instead of using an uninitialized var.
5ad03b97 8122 (font_sort_entities): Mark var as initialized.
3ddb0639 8123
170a2692
PE
8124 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8125
e663c700
PE
8126 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8127 pointers to constants.
89bc529a 8128 (font_parse_fcname): Remove unused vars.
7b81e2d0 8129 (font_delete_unmatched): Now static.
ea838e10 8130 (font_get_spec): Remove; unused.
13a547c6
PE
8131 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8132 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8133 Rename or move locals to avoid shadowing.
e663c700 8134
2a80c887 8135 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8136 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8137
1384fa33 8138 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8139 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8140
8b2c52e9
PE
8141 * alloc.c (mark_backtrace): Move decl from here ...
8142 * lisp.h: ... to here, so that it can be checked.
8143
475545b5 8144 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8145 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8146 (lisp_indirect_variable): Name an expression,
8147 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8148 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8149
b1349114 8150 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8151 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8152 Use const pointer when appropriate.
b1349114 8153
a2928364
PE
8154 * lisp.h (get_system_name, get_operating_system_release):
8155 Move decls here, to check interfaces.
8156 * process.c (get_operating_system_release): Move decl to lisp.h.
8157 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8158 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8159 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8160 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8161 (Fformat_time_string, Fencode_time, Finsert_char):
8162 (Ftranslate_region_internal, Fformat):
8163 Rename or remove local vars to avoid shadowing.
9710023e 8164 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8165
a415e694
PE
8166 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8167 avoid shadowing.
8168
8ef4622d
PE
8169 * lisp.h (eassert): Check that the argument compiles, even if
8170 ENABLE_CHECKING is not defined.
8171
946f9a5b
PE
8172 * data.c (Findirect_variable): Name an expression, to avoid
8173 gcc -Wbad-function-cast warning.
112396d6 8174 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8175 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8176 (Fmake_variable_buffer_local, Fmake_local_variable):
8177 Mark variables as initialized.
52746918 8178 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8179
e5aab7e7 8180 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8181 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8182 Rename locals to avoid shadowing.
dff45157
PE
8183 (mark_stack): Move local variables into the #ifdef region where
8184 they're used.
7bc26fdb
PE
8185 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8186 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8187 needed otherwise.
8188 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8189 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8190 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8191
e5aab7e7
PE
8192 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8193 avoids undefined behavior in theory.
8194
4da60324
PE
8195 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8196
88043301
PE
8197 Use functions, not macros, for up- and down-casing (Bug#8254).
8198 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8199 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8200 to use the following functions instead of these macros.
8201 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8202 EMACS_INT, since callers assume the returned value fits in int.
8203 (upcase1): Likewise, for UPCASE_TABLE.
8204 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8205 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8206 the race-condition problem in the old DOWNCASE.
88043301 8207
19ed5445
PE
8208 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8209 Rename locals to avoid shadowing.
8210 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8211 (regex_compile, re_search_2, re_match_2_internal):
8212 Remove unused local vars.
952db0d7
PE
8213 (FREE_VAR): Rewrite so as not to use empty "else",
8214 which gcc can warn about.
da053e48 8215 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8216 (RETALLOC_IF): Define only if needed.
8217 (WORDCHAR_P): Likewise. This one is never needed, but is used
8218 only in a comment talking about a compiler bug, so put inside
8219 the #if 0 of that comment.
8220 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8221 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8222 Remove; unused.
19ed5445 8223
1f3561e4 8224 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8225 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8226 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8227
ded6f8f7
PE
8228 * search.c (simple_search): Remove unused var.
8229
dbd37a95
PE
8230 * dired.c (compile_pattern): Move decl from here ...
8231 * lisp.h: ... to here, so that it can be checked.
8232 (struct re_registers): New forward decl.
8233
7e47afad
PE
8234 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8235
85f24f61
PE
8236 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8237 All uses changed.
8238 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8239 Rename locals to avoid shadowing.
5671df8f 8240 (Fvertical_motion): Mark locals as initialized.
85f24f61 8241
181aa2be 8242 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8243 (casify_region): Mark local as initialized.
181aa2be 8244
930d429c
PE
8245 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8246
7082eac6
PE
8247 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8248 New macros, so that the caller can use some names other than
8249 gcpro1, gcpro2, etc.
8250 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8251 of the new macros.
8252 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8253 argument, for consistency with GCPRO2_VAR, etc: it is now the
8254 prefix of the variable, not the variable itself. All uses
8255 changed.
38b2c076
PE
8256 * dired.c (directory_files_internal, file_name_completion):
8257 Rename locals to avoid shadowing.
8258
15206ed9
PE
8259 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8260 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8261 dired.c's scmp function, had undefined behavior.
8262 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8263 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8264 * buffer.h: ... to here, because these macros use current_buffer,
8265 and the new implementation with inline functions needs to have
8266 current_buffer in scope now, rather than later when the macros
8267 are used.
8268 (downcase, upcase1): New static inline functions.
8269 (DOWNCASE, UPCASE1): Reimplement using these functions.
8270 This avoids undefined behavior in expressions like
8271 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8272 from race conditions in accessing the global variables
8273 case_temp1 and case_temp2.
8274 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8275 * lisp.h (case_temp1, case_temp2): Remove their decls.
8276 * character.h (ASCII_CHAR_P): Move from here ...
8277 * lisp.h: ... to here, so that the inline functions mentioned
8278 above can use them.
8279
4a6bea26
PE
8280 * dired.c (directory_files_internal_unwind): Now static.
8281
f14b7e14
PE
8282 * fileio.c (file_name_as_directory, directory_file_name):
8283 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8284 Now static.
2893f146
PE
8285 (file_name_as_directory): Use const pointers when appropriate.
8286 (Fexpand_file_name): Likewise. In particular, newdir might
8287 point at constant storage, so make it a const pointer.
fd4ead52 8288 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8289 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8290 signedness issues.
f839df0c
PE
8291 (Fset_file_times, Finsert_file_contents, auto_save_error):
8292 Rename locals to avoid shadowing.
f14b7e14 8293
5716756e 8294 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8295 (Ftry_completion, Fall_completions): Rename or remove locals
8296 to avoid shadowing.
5716756e 8297
b4c3046a
PE
8298 * marker.c (bytepos_to_charpos): Remove; unused.
8299
b45db522
PE
8300 * lisp.h (verify_bytepos, count_markers): New decls,
8301 so that gcc does not warn that these functions aren't declared.
8302
85876d07
PE
8303 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8304 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8305 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8306 (copy_text): Remove unused local var.
85876d07 8307
03d78a21 8308 * filelock.c (within_one_second): Now static.
b3dd38ab 8309 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8310
5df8f01b
PE
8311 * buffer.c (fix_overlays_before): Mark locals as initialized.
8312 (fix_start_end_in_overlays): Likewise. This function should be
8313 simplified by using pointers-to-pointers, but that's a different
8314 matter.
b1d876f1 8315 (switch_to_buffer_1): Now static.
8f54f30a
PE
8316 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8317 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8318
a70072c9 8319 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8320 Fix pointer signedness issue.
edced198
PE
8321 (sys_subshell): Mark local as volatile if checking for lint,
8322 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8323 (MAXPATHLEN): Define only if needed.
a70072c9 8324
a0977c44
PE
8325 * process.c (serial_open, serial_configure): Move decls from here ...
8326 * systty.h: ... to here, so that they can be checked.
8327
a884fdcc
PE
8328 * fns.c (get_random, seed_random): Move extern decls from here ...
8329 * lisp.h: ... to here, so that they can be checked.
8330
604efe86 8331 * sysdep.c (reset_io): Now static.
b8950c94 8332 (wait_for_termination_signal): Remove; unused.
604efe86 8333
38fc62d9
PE
8334 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8335 (copy_keymap_item, append_key, push_text_char_description):
8336 Now static.
1004a21a 8337 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8338 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8339 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8340 (describe_map_tree):
8341 Rename locals to avoid shadowing.
38fc62d9 8342
2f2650da
PE
8343 * keyboard.c: Declare functions static if they are not used elsewhere.
8344 (echo_char, echo_dash, cmd_error, top_level_2):
8345 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8346 (read_char, kbd_buffer_get_event, make_lispy_position):
8347 (make_lispy_event, make_lispy_movement, apply_modifiers):
8348 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8349 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8350 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8351 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8352 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8353
a053e86c 8354 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8355 (mark_kboards): Move decl here ...
8356 * alloc.c (mark_kboards): ... from here.
a053e86c 8357
4752793e
PE
8358 * lisp.h (force_auto_save_soon): New decl.
8359
74f10ca7 8360 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8361 (DEFINE_DUMMY_FUNCTION): New macro.
8362 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8363 Use it.
c03cd23f
PE
8364 (main): Add casts to avoid warnings
8365 if GCC considers string literals to be constants.
74f10ca7 8366
022e70d4
PE
8367 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8368
59d6fe83
PE
8369 * dbusbind.c: Pointer signedness fixes.
8370 (xd_signature, xd_append_arg, xd_initialize):
8371 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8372 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8373 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8374 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8375
78320123
PE
8376 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8377 if GCC considers string literals to be constants.
49cebcca 8378 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8379
35ac2a97
SM
83802011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8381
fb103ca9
SM
8382 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8383 (print_preprocess, print_object): New macro to fix last change.
8384
35ac2a97
SM
8385 * print.c (print_preprocess): Don't forget font objects.
8386
62973b41
JB
83872011-03-16 Juanma Barranquero <lekktu@gmail.com>
8388
8389 * emacs.c (USAGE3): Doc fixes.
8390
0e48bb22
AS
83912011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8392
8393 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8394 structure.
8395
7684e57b
JB
83962011-03-14 Juanma Barranquero <lekktu@gmail.com>
8397
8398 * lisp.h (VWindow_system, Qfile_name_history):
8399 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8400 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8401 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8402
8403 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8404 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8405
8406 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8407 * w32console.c (detect_input_pending, read_input_pending)
8408 (encode_terminal_code):
8409 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8410 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8411 (w32_system_caret_y, Qfile_name_history):
8412 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8413 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8414 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8415 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8416 * w32proc.c (Qlocal, report_file_error):
8417 * w32term.c (Vwindow_system, updating_frame):
8418 * w32uniscribe.c (initialized, uniscribe_font_driver):
8419 Remove unneeded extern declarations.
8420
2aa46d6c
CY
84212011-03-14 Chong Yidong <cyd@stupidchicken.com>
8422
c96bbc66 8423 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8424
cffc6f3b
CY
84252011-03-13 Chong Yidong <cyd@stupidchicken.com>
8426
8427 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8428 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8429 These macros can no longer be used for assignment.
8430
44f230aa
SM
8431 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8432 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8433 (record_buffer_markers, fetch_buffer_markers): New functions for
8434 recording and fetching special buffer markers.
8435 (set_buffer_internal_1, set_buffer_temp): Use them.
8436
8437 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8438
8439 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8440
8441 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8442 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8443
8444 * xdisp.c (hscroll_window_tree):
8445 (reconsider_clip_changes): Use PT instead of BUF_PT.
8446
d251f04b
EZ
84472011-03-13 Eli Zaretskii <eliz@gnu.org>
8448
8449 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8450 $(EMACS_ROOT)/lib/intprops.h.
8451
f0c77cd1
PE
84522011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8453
3eca4629
PE
8454 Fix more problems found by GCC 4.5.2's static checks.
8455
7c86ee98
PE
8456 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8457 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8458 (xg_free_frame_widgets): Make it clear that a local variable is
8459 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8460 (gdk_window_get_screen): Make it clear that this macro is needed
8461 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8462 (int_gtk_range_get_value): New function, which avoids a diagnostic
8463 from gcc -Wbad-function-cast.
8464 (xg_set_toolkit_scroll_bar_thumb): Use it.
8465 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8466 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8467 (get_utf8_string, xg_get_file_with_chooser):
8468 Rename locals to avoid shadowing.
8469 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8470
41729b81
PE
8471 * xgselect.c (xg_select): Remove unused var.
8472
f0c77cd1
PE
8473 * image.c (four_corners_best): Mark locals as initialized.
8474 (gif_load): Initialize transparent_p to zero (Bug#8238).
8475 Mark another local as initialized.
ec6cf4c6 8476 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8477
ce0ad53d 8478 * image.c (clear_image_cache): Now static.
d5d5a617 8479 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8480 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8481 (x_edge_detection): Remove unnecessary cast that
8482 gcc -Wbad-function-cast diagnoses.
2037898d 8483 (gif_load): Fix pointer signedness.
6ae141d6
PE
8484 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8485 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8486
33383987 84872011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8488
d32df629
PE
8489 Improve quality of tests for time stamp overflow.
8490 For example, without this patch (encode-time 0 0 0 1 1
8491 1152921504606846976) returns the obviously-bogus value (-948597
8492 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8493 reports time overflow. See
8494 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8495 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8496 * editfns.c: Include limits.h and intprops.h.
8497 (TIME_T_MIN, TIME_T_MAX): New macros.
8498 (time_overflow): Move earlier, to before first use.
8499 (hi_time, lo_time): New functions, for an accurate test for
8500 out-of-range times.
8501 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8502 (Fget_internal_run_time): Don't assume time_t fits in int.
8503 (make_time): Use list2 instead of Fcons twice.
8504 (Fdecode_time): More accurate test for out-of-range times.
8505 (check_tm_member): New function.
8506 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8507 (lisp_time_argument): Don't rely on undefined left-shift and
8508 right-shift behavior when checking for time stamp overflow.
8be6f318 8509
fe31d94c
PE
8510 * editfns.c (time_overflow): New function, refactoring common code.
8511 (Fformat_time_string, Fdecode_time, Fencode_time):
8512 (Fcurrent_time_string): Use it.
8513
8be6f318
PE
8514 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8515 * dired.c (make_time): Move to ...
8516 * editfns.c (make_time): ... here.
8517 * systime.h: Note the move.
8518
09d9db2c 85192011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8520
126bc0dc
YM
8521 * fringe.c (update_window_fringes): Remove unused variables.
8522
c47cbdfd
YM
8523 * unexmacosx.c (copy_data_segment): Also copy __got section.
8524 (Bug#8223)
8525
7ac80be9
EZ
85262011-03-12 Eli Zaretskii <eliz@gnu.org>
8527
c96bbc66 8528 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8529 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8530 Constify `char *' arguments and their references according to
8531 prototypes in tparam.h.
8532
ecb0f94d 8533 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8534
7ac80be9
EZ
8535 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8536 Adapt all references accordingly.
8537
8538 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8539
ef1fd07e
TT
85402011-03-11 Tom Tromey <tromey@redhat.com>
8541
8542 * buffer.c (syms_of_buffer): Remove obsolete comment.
8543
7ef4b50c
EZ
85442011-03-11 Eli Zaretskii <eliz@gnu.org>
8545
8546 * termhooks.h (encode_terminal_code): Declare prototype.
8547
8548 * msdos.c (encode_terminal_code): Don't declare prototype.
8549
8550 * term.c (encode_terminal_code): Now external again, used by
8551 w32console.c and msdos.c.
8552
44f230aa
SM
8553 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8554 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8555
4b1ec863 85562011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8557
1714f52b 8558 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8559
4b1ec863
PE
8560 * fringe.c (update_window_fringes): Mark locals as initialized
8561 (Bug#8227).
8562 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8563
524c7aa6
PE
8564 * alloc.c (mark_fringe_data): Move decl from here ...
8565 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8566 to check its interface.
8567 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8568
a5c0af81 8569 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8570 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8571 (fontset_font): Mark local as initialized.
a9a06e0b 8572 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8573
b4716021
PE
8574 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8575
811e9bac 8576 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8577 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8578 (x_own_selection, Fx_disown_selection_internal): Rename locals
8579 to avoid shadowing.
8580 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8581
7e3ab302
PE
8582 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8583 so that the caller can use some name other than gcpro1.
8584 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8585 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8586 (Fx_backspace_delete_keys_p):
8587 Use them to avoid shadowing, and rename vars to avoid shadowing.
8588 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8589 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8590 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8591 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8592 Remove unused locals.
7e3ab302
PE
8593 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8594 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8595 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8596 macros.
f78faa98 8597
e2b13473
PE
8598 * xterm.h (x_mouse_leave): New decl.
8599
77f23912
PE
8600 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8601 Remove unused functions.
cdf4ba58
PE
8602 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8603 (x_calc_absolute_position): Now static.
7411c686 8604 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8605 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8606 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8607 unless they are used.
38d0b34a
PE
8608 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8609 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8610 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8611 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8612 (x_error_catcher, x_connection_closed, x_error_handler):
8613 (x_error_quitter, xembed_send_message, x_iconify_frame):
8614 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8615 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8616 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8617
44f230aa
SM
8618 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8619 Rename or move locals to avoid shadowing.
6b463e58 8620 (tty_defined_color, merge_face_heights): Now static.
5967d051 8621 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8622 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8623 does not deduce is never used uninitialized.
73719eba
PE
8624 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8625 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8626
426994c3 8627 * terminal.c (store_terminal_param): Now static.
5489860b 8628
032f1620 8629 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8630 (set_frame_menubar): Remove unused local.
d4323972 8631 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8632 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8633 since they might point to immutable storage.
281585b0
PE
8634 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8635 since it's unused otherwise.
032f1620 8636
367c19e5 8637 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8638 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8639 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8640 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8641 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8642 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8643 does not deduce are never used uninitialized.
70739cbe 8644
07b48fa9
PE
8645 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8646
8868a238 8647 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8648 * window.c (window_loop, size_window):
8649 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8650
7e5cf297 8651 * window.c (display_buffer): Now static.
d6550a9f
PE
8652 (size_window): Mark variables that gcc -Wuninitialized
8653 does not deduce are never used uninitialized.
a586633d
PE
8654 * window.h (check_all_windows): New decl, to forestall
8655 gcc -Wmissing-prototypes diagnostic.
5b555da1 8656 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8657
f6095868
PE
8658 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8659 shadowing.
8660 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8661 Include <limits.h>.
8662 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8663 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8664 (load_charset_map): Mark variables that gcc -Wuninitialized
8665 does not deduce are never used uninitialized.
53df7c11 8666 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8667
f38b440c
PE
8668 * coding.c (coding_set_source, coding_set_destination):
8669 Use "else { /* comment */ }" rather than "else /* comment */;"
8670 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8671 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8672 a block, when the outer 'i' will do.
8673 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8674 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8675 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8676 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8677 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8678 Rename locals to avoid shadowing.
8679 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8680 * coding.c (emacs_mule_char, encode_invocation_designation):
8681 Now static, since they're not used elsewhere.
413bb2db 8682 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8683 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8684 (decode_coding_emacs_mule): Mark variables that gcc
8685 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8686 (detect_coding_iso_2022): Initialize a local variable that might
8687 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8688 this initialization is needed. (Bug#8211)
5f58e762
PE
8689 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8690 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8691 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8692 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8693 Remove unused macros.
f38b440c 8694
232b38b9 8695 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8696 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8697 * character.c (string_count_byte8): Likewise.
232b38b9 8698
fb90da1b
PE
8699 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8700 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8701
fb93dbc2
PE
8702 * chartab.c (copy_sub_char_table): Now static, since it's not used
8703 elsewhere.
5c156ace
PE
8704 (sub_char_table_ref_and_range, char_table_ref_and_range):
8705 Rename locals to avoid shadowing.
bbcd0949 8706 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8707
7d3b3862 8708 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8709 (BIDI_BOB): Remove unused macro.
7d3b3862 8710
6be7d3da
PE
8711 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8712 deduce are never used uninitialized.
c2ed9c8b 8713 * term.c (encode_terminal_code): Likewise.
6be7d3da 8714
75f8807f 8715 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8716
50938595
PE
8717 * tparam.h: New file.
8718 * term.c, tparam.h: Include it.
8719 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8720 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8721 Move these decls to tparam.h, and make them agree with what
8722 is actually in tparam.c. The previous trick of using incompatible
8723 decls in different modules does not conform to the C standard.
8724 All callers of tparam changed to use tparam's actual API.
8725 * tparam.c (tparam1, tparam, tgoto):
8726 Use const pointers where appropriate.
8727
fbceeba2
PE
8728 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8729 * cm.h (struct cm): Likewise.
8730 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8731 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8732 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8733 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8734 (turn_on_face, init_tty): Likewise.
8735 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8736
7f3f1250
PE
8737 * term.c (term_mouse_position): Rename local to avoid shadowing.
8738
e6ca6543
PE
8739 * alloc.c (mark_ttys): Move decl from here ...
8740 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8741
c40f8d15
AS
87422011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8743
8744 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8745
cfe0661d
JB
87462011-03-09 Juanma Barranquero <lekktu@gmail.com>
8747
8748 * search.c (compile_pattern_1): Remove argument regp, unused since
8749 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8750 (compile_pattern): Don't pass it.
8751
0afb4571
J
87522011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8753
8754 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8755 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8756 for ! HAVE_GTK3.
8757 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8758
8759 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8760
8761 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8762 gdk_window_get_screen, gdk_window_get_geometry,
8763 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8764 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8765 (xg_get_pixbuf_from_pixmap): New function.
8766 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8767 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8768 Call xg_get_pixbuf_from_pixmap instead of
8769 gdk_pixbuf_get_from_drawable.
8770 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8771 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8772 (xg_check_special_colors): Use GtkStyleContext and its functions
8773 for HAVE_GTK3.
8774 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8775 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8776 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8777 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8778 Call gtk_widget_get_preferred_size.
0afb4571
J
8779 (xg_frame_resized): gdk_window_get_geometry only takes 5
8780 parameters.
44f230aa
SM
8781 (xg_win_to_widget, xg_event_is_for_menubar):
8782 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8783 (xg_set_widget_bg): New function.
8784 (delete_cb): New function.
895009e1 8785 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8786 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8787 (xg_set_background_color): Call xg_set_widget_bg.
8788 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8789 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8790 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8791 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8792 if ! HAVE_GTK3.
8793 (update_frame_tool_bar): Call gtk_widget_hide.
8794 (xg_initialize): Use GDK_KEY_g.
8795
8796 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8797 if ! HAVE_GTK3
8798 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8799
8800 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8801 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8802 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8803
1c2cc4ef
JB
88042011-03-08 Juanma Barranquero <lekktu@gmail.com>
8805
8806 * w32xfns.c (select_palette): Check success of RealizePalette against
8807 GDI_ERROR, not zero.
8808
33383987 8809See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8810
8811;; Local Variables:
8812;; coding: utf-8
aac0c6e3
MR
8813;; End:
8814
33383987 8815 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8816
8817 This file is part of GNU Emacs.
8818
8819 GNU Emacs is free software: you can redistribute it and/or modify
8820 it under the terms of the GNU General Public License as published by
8821 the Free Software Foundation, either version 3 of the License, or
8822 (at your option) any later version.
8823
8824 GNU Emacs is distributed in the hope that it will be useful,
8825 but WITHOUT ANY WARRANTY; without even the implied warranty of
8826 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8827 GNU General Public License for more details.
8828
8829 You should have received a copy of the GNU General Public License
8830 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.