Avoid a crash in mouse-highlight of Speedbar frames.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
54a1215b
EZ
12011-08-19 Eli Zaretskii <eliz@gnu.org>
2
823564e5
EZ
3 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5 from an Org mode buffer to a Speedbar frame.
6
54a1215b
EZ
7 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8 a composition, take its buffer position from IT->cmp_it.charpos.
9 Fixes cursor positioning at the beginning of a line that begins
10 with a composed character.
11
9778ebcc
EZ
122011-08-18 Eli Zaretskii <eliz@gnu.org>
13
0be6ee06
EZ
14 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
15 character bidirectional type, use STRONG_L instead. Fixes crashes
16 in a buffer produced by `describe-categories'.
17
9778ebcc
EZ
18 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
19 members before the level stack, so they would be saved and
20 restored when copying iterator state. Fixes incorrect reordering
21 around TABs covered by display properties.
22
156bffbe
AS
232011-08-18 Andreas Schwab <schwab@linux-m68k.org>
24
25 * process.c (Fnetwork_interface_list): Correctly determine buffer
26 size.
27
72ad093b
CY
282011-08-17 Chong Yidong <cyd@stupidchicken.com>
29
30 * eval.c (internal_condition_case, internal_condition_case_1)
31 (internal_condition_case_2, internal_condition_case_n): Remove
32 unnecessary aborts (Bug#9081).
33
35774242
EZ
342011-08-17 Eli Zaretskii <eliz@gnu.org>
35
36 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
37 has no `load' handler, try opening the file locally. (Bug#9311)
38
db76dd85
KB
392011-08-16 Ken Brown <kbrown@cornell.edu>
40
41 * gmalloc.c: Expand comment.
42
b215eee5
EZ
432011-08-16 Eli Zaretskii <eliz@gnu.org>
44
45 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
46 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
47
a4579d33
KB
482011-08-16 Ken Brown <kbrown@cornell.edu>
49
50 Fix memory allocation problems in Cygwin build (Bug#9273).
51
52 * unexcw.c ( __malloc_initialized): Declare external variable.
53 (fixup_executable): Force the dumped emacs to reinitialize malloc.
54
55 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo): New
56 variables.
57 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
58 dumped emacs.
59 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
60 in the static heap.
61 [CYGWIN] (special_realloc): New function.
62 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
63 requests to realloc storage in the static heap.
64
3ebec551
PE
652011-08-15 Paul Eggert <eggert@cs.ucla.edu>
66
67 * bidi.c (bidi_initialize): Remove unused local.
68
9fd8be00
EZ
692011-08-15 Eli Zaretskii <eliz@gnu.org>
70
474a8465
EZ
71 * biditype.h: File removed.
72
73 * bidimirror.h: File removed.
74
75 * deps.mk (bidi.o): Remove biditype.h and
76 bidimirror.h.
77
78 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
79 bidimirror.h.
80
81 * dispextern.h: Fix a typo in the comment to bidi_type_t.
82
83 * chartab.c: Improve commentary for the uniprop_table API.
84
32413314
EZ
85 * bidi.c (bidi_paragraph_init): Support zero value of
86 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
87 (bidi_initialize): Use uniprop_table instead of including
88 biditype.h and bidimirror.h.
32413314 89
9fd8be00
EZ
90 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
91 coordinates of the iterator when restoring from ppos_it.
92 (Bug#9296)
93
5cf2b69b
KH
942011-08-14 Kenichi Handa <handa@m17n.org>
95
96 * process.c (create_process): Call setup_process_coding_systems
72ad093b 97 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 98
daf17d00
EZ
992011-08-14 Eli Zaretskii <eliz@gnu.org>
100
101 * xdisp.c (move_it_in_display_line_to): Don't invoke
102 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
103 ppos_it. Fixes vertical cursor motion when line beginning is
104 covered by an image. (Bug#9296)
105
08e3161a
JD
1062011-08-14 Jan Djärv <jan.h.d@swipnet.se>
107
108 * nsterm.h (ns_run_ascript): Declare.
109 (NSAPP_DATA2_RUNASSCRIPT): Define.
110
111 * nsfns.m (as_script, as_result, as_status): New static variables.
112 (ns_run_ascript): New function.
113 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
114 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
115 the event loop. Get status from as_status (Bug#7276).
116
117 * nsterm.m (sendEvent): If event is NSApplicationDefined and
118 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
119 the event loop (Bug#7276).
120
a3720aa2
AS
1212011-08-14 Andreas Schwab <schwab@linux-m68k.org>
122
123 * gnutls.c (QCgnutls_bootprop_priority)
124 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
125 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
126 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
127 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
128 (QCgnutls_bootprop_verify_hostname_error)
129 (QCgnutls_bootprop_callbacks_verify): Rename from
130 Qgnutls_bootprop_..., all uses changed.
131
132 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
133 uses changed.
134
0a0d27fb
PE
1352011-08-14 Paul Eggert <eggert@cs.ucla.edu>
136
19d5c50c
PE
137 * xfaces.c (Qframe_set_background_mode): Now static.
138 * dispextern.h (Qframe_set_background_mode): Remove decl.
139
0a0d27fb
PE
140 * process.c (Fnetwork_interface_info): Declare local only if needed.
141
377538cb
JD
1422011-08-13 Jan Djärv <jan.h.d@swipnet.se>
143
144 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
145 (Fnetwork_interface_list): Allocate in increments of bytes instead
146 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
147 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
148 sockaddr.
149 (struct ifflag_def): notrailers is smart on OSX.
150 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
151 Get hardware address with getifaddrs if available.
152
08fff70c
EZ
1532011-08-12 Eli Zaretskii <eliz@gnu.org>
154
155 * xdisp.c (iterate_out_of_display_property): xassert that
156 IT->position is set to within IT->object's boundaries. Break from
157 the loop as soon as EOB is reached; avoids infloops in redisplay
158 when IT->position is set up wrongly due to some bug. Set
159 IT->current to match the bidi iterator unconditionally.
160 (push_display_prop): Allow GET_FROM_STRING as IT->method on
161 entry. Force push_it to save on the stack the current
162 buffer/string position, to be restored by pop_it. Fix flags in
163 the iterator structure wrt the object coming from a display
164 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
165 properties. (Bug#9284)
166
7be1c708 1672011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 168
7be1c708
CY
169 * fontset.c (fontset_get_font_group): Add proper type checks.
170 (Bug#9172)
aac0c6e3 171
7be1c708 1722011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 173
7be1c708
CY
174 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
175 and LC_VERSION_MIN_MACOSX.
176 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
177 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 178
97bb72a6
EZ
1792011-08-08 Eli Zaretskii <eliz@gnu.org>
180
181 * xdisp.c (forward_to_next_line_start): Allow to use the
757664a4
EZ
182 no-display-properties-and-no-overlays under bidi display. Set
183 disp_pos in the bidi iterator to avoid searches for display
184 properties and overlays.
97bb72a6 185
d5617611
CY
1862011-08-08 Chong Yidong <cyd@stupidchicken.com>
187
37e11a63
CY
188 * editfns.c (Fset_time_zone_rule): Document relationship with the
189 setenv function.
190
d5617611
CY
191 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
192 the font entity extracted from the cache (Bug#8109).
193
58872834
CY
1942011-08-07 Chong Yidong <cyd@stupidchicken.com>
195
196 * composite.c (autocmp_chars): Don't reset point. That is done by
197 restore_point_unwind (Bug#5984).
198
75bfc667
JL
1992011-08-07 Juri Linkov <juri@jurta.org>
200
201 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
202 to show the arg `TIME' instead of `TIMEVAL'.
203
d1410150
EZ
2042011-08-06 Eli Zaretskii <eliz@gnu.org>
205
206 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
207 display property strides EOL and includes a newline, as in
208 longlines-mode. (Bug#9254)
75b771e4
EZ
209 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
210 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
211
212 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
213 is non-zero, even if the data buffer is NULL. Fixes a crash in
214 vertical-motion with longlines-mode. (Bug#9254)
215
35928349
EZ
2162011-08-05 Eli Zaretskii <eliz@gnu.org>
217
ec7cc85b
EZ
218 * bidi.c <bidi_cache_total_alloc>: Now static.
219 (bidi_initialize): Initialize bidi_cache_total_alloc.
220
35928349
EZ
221 *xdisp.c (display_line): Release buffer allocated for shelved bidi
222 cache. (Bug#9221)
223
224 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
225 amount allocated this far in `bidi_cache_total_alloc'.
226 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
227 non-zero, only free the data buffer without restoring the cache
228 contents. All callers changed.
229
230 * dispextern.h (bidi_unshelve_cache): Update prototype.
231
232 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
233 (move_it_in_display_line, move_it_to)
234 (move_it_vertically_backward, move_it_by_lines): Replace the call
235 to xfree to an equivalent call to bidi_unshelve_cache.
236 (move_it_in_display_line_to): Fix logic of returning
412b6358 237 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 238
e2e2423b
EZ
2392011-08-05 Eli Zaretskii <eliz@gnu.org>
240
241 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
242 came from a string character with a `cursor' property. (Bug#9229)
243
ae9e757a
JD
2442011-08-04 Jan Djärv <jan.h.d@swipnet.se>
245
246 * Makefile.in (LIB_PTHREAD): New variable.
247 (LIBES): Add LIB_PTHREAD (Bug#9216).
248
249 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
250 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
251
213bd7f2
AS
2522011-08-04 Andreas Schwab <schwab@linux-m68k.org>
253
254 * regex.c (re_iswctype): Remove some redundant boolean
255 conversions.
256
99aaf75f
JD
2572011-08-04 Jan Djärv <jan.h.d@swipnet.se>
258
259 * xterm.c (x_find_topmost_parent): New function.
260 (x_set_frame_alpha): Find topmost parent window with
261 x_find_topmost_parent and set the property there also (bug#9181).
262 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
263
c74e9d86
PE
2642011-08-04 Paul Eggert <eggert@cs.ucla.edu>
265
266 * callproc.c (Fcall_process): Avoid vfork clobbering
267 the local vars buffer, coding_systems, current_dir.
268
640c8776
SM
2692011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
270
271 * keymap.c (Fmake_composed_keymap): Move to subr.el.
272
f26d0e4c
PE
2732011-08-03 Paul Eggert <eggert@cs.ucla.edu>
274
8a10d76c
PE
275 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
276 so that it is not optimized away.
277
f26d0e4c
PE
278 * xdisp.c (compute_display_string_pos): Remove unused local.
279
55439c61
EZ
2802011-08-02 Eli Zaretskii <eliz@gnu.org>
281
282 Fix slow cursor motion and scrolling in large buffers with
283 selective display, like Org Mode buffers. (Bug#9218)
284
285 * dispextern.h (struct bidi_it): New member disp_prop_p.
286
287 * xdisp.c: Remove one-slot cache of display string positions.
288 (compute_display_string_pos): Accept an additional argument
289 DISP_PROP_P; callers changed. Scan at most 5K characters forward
290 for a display string or property. If found, set DISP_PROP_P
291 non-zero.
292
293 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
294 DISP_PROP_P, and pass it to compute_display_string_pos.
295 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
296 non-zero. All callers of bidi_fetch_char changed.
297
fb33fa43
SM
2982011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
299
300 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
301
b099e063
DM
3022010-12-03 Don March <don@ohspite.net>
303
304 * keymap.c (Fdefine_key): Fix non-prefix key error message when
305 last character M-[char] is translated to ESC [char] (bug#7541).
306
5cc7f7af
KH
3072011-08-02 Kenichi Handa <handa@m17n.org>
308
d0fffa3f 309 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
310
311 * chartab.c (uniprop_table): Make it non-static.
312
525d5e6e
EZ
3132011-08-01 Eli Zaretskii <eliz@gnu.org>
314
315 * xdisp.c (forward_to_next_line_start): Accept additional argument
316 BIDI_IT_PREV, and store into it the state of the bidi iterator had
317 on the newline.
318 (reseat_at_next_visible_line_start): Use the bidi iterator state
319 returned by forward_to_next_line_start to restore the state of
320 it->bidi_it after backing up to previous newline. (Bug#9212)
321
31011111
AS
3222011-07-30 Andreas Schwab <schwab@linux-m68k.org>
323
324 * regex.c (re_comp): Protoize.
325 (re_exec): Fix return type.
326 (regexec): Fix type of `ret'. (Bug#9203)
327
e5d76069
PE
3282011-07-29 Paul Eggert <eggert@cs.ucla.edu>
329
330 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
331 This is needed if max-image-size is a floating-point number.
332
9a79b20c
AS
3332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
334
335 * print.c (print_object): Print empty symbol as ##.
336
337 * lread.c (read1): Read ## as empty symbol.
338
d8c2fa78
AA
3392011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
340
341 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
342 setting frame foreground color (Bug#9175).
343 (x_set_background_color): Likewise.
344
ffe57a7a
AA
345 * nsmenu.m (-setText): Size tooltip dimensions precisely to
346 contents (Bug#9176).
347 (EmacsTooltip -init): Remove bezels and add shadows to
348 tooltip windows.
349
bf3492a5
AA
350 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
351 or scroll bar (Bug#8470).
352
d55e9c53
AA
353 * nsfont.m (nsfont_open): Remove assignment to voffset and
354 unnecessary vars hshink, expand, hd, full_height, min_height.
355 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
356
357 * nsterm.h (nsfont_info): Remove voffset field.
358
d8c2fa78 3592011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
360
361 Implement strike-through and overline on NextStep (Bug#8863).
362
363 * nsfont.m (nsfont_open): Use underline position provided by font,
364 instead of hard-coded value of 2.
365 (nsfont_draw): Call ns_draw_text_decoration instead.
366
367 * nsterm.h: Add declaration for ns_draw_text_decoration.
368
369 * nsterm.m (ns_draw_text_decoration): New function for drawing
370 underline, overline, and strike-through.
371 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
372 ns_draw_text_decoration. Change treatment of cursor drawing to
373 accomodate underlining, etc.
374
4cc60b9b
EZ
3752011-07-28 Eli Zaretskii <eliz@gnu.org>
376
bc7ece87
EZ
377 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
378 default.
4cc60b9b 379
476371c4
PE
3802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
381
66606eea
PE
382 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
383 Without this fix, if a signal arrives just after memory fills up,
384 'malloc' might be invoked reentrantly.
385
476371c4
PE
386 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
387 In other words, assume that every image size is allowed, on non-X
388 hosts. This assumption is probably wrong, but it lets Emacs compile.
389
f3fcc40d
AS
3902011-07-28 Andreas Schwab <schwab@linux-m68k.org>
391
392 * regex.c (re_iswctype): Convert return values to boolean.
393
350c992f
EZ
3942011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
395
396 * xdisp.c (compute_display_string_pos): Don't use cached display
397 string position if the buffer had its restriction changed.
398 (Bug#9184)
399
5266b4bb
PE
4002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
401
402 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
403
2573a837 4042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 405
41f55ccd 406 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 407
39e378da
PE
408 * bidi.c: Integer size and overflow fixes.
409 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
410 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
411 (bidi_cache_find_level_change, bidi_cache_ensure_space)
412 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
413 (bidi_find_other_level_edge):
414 Use ptrdiff_t instead of EMACS_INT where either will do.
415 This works better on 32-bit hosts configured --with-wide-int.
416 (bidi_cache_ensure_space): Check for size-calculation overflow.
417 Use % rather than repeated addition, for better worst-case speed.
418 Don't set bidi_cache_size until after xrealloc returns, because it
419 might not return.
420 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
421 (bidi_cache_ensure_space): Also check that the bidi cache size
422 does not exceed that of the largest Lisp string or buffer. See Eli
423 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 424
5e927815
PE
425 * alloc.c (__malloc_size_t): Remove.
426 All uses replaced by size_t. See Andreas Schwab's note
427 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
428
ca4aa935
PE
429 * image.c: Improve checking for integer overflow.
430 (check_image_size): Assume that f is nonnull, since
431 it is always nonnull in practice. This is one less thing to
432 worry about when checking for integer overflow later.
433 (x_check_image_size): New function, which checks for integer
434 overflow issues inside X.
435 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
436 This removes the need for a memory_full check.
437 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
438 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
439 (xbm_read_bitmap_data): Change locals back to 'int', since
440 their values must fit in 'int'.
441 (xpm_load_image, png_load, tiff_load):
442 Invoke x_create_x_image_and_pixmap earlier,
443 to avoid much needless work if the image is too large.
444 (tiff_load): Treat overly large images as if
445 x_create_x_image_and_pixmap failed, not as malloc failures.
446 (gs_load): Use x_check_image_size.
447
5f8f9cc2
PE
448 * gtkutil.c: Omit integer casts.
449 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
450 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
451
5adf60bc
PE
452 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
453
c8907a93
PE
454 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
455 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
456 would wrongly return t on a 64-bit host.
457
e3c25c68
PE
458 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
459 The plain *_OVERFLOW macros run afoul of GCC bug 49705
460 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
461 and therefore cause GCC to emit a bogus diagnostic in some cases.
462
3f791afe
PE
463 * image.c: Integer signedness and overflow and related fixes.
464 This is not an exhaustive set of fixes, but it's time to
465 record what I've got.
466 (lookup_pixel_color, check_image_size): Remove redundant decls.
467 (check_image_size): Don't assume that arbitrary EMACS_INT values
468 fit in 'int', or that arbitrary 'double' values fit in 'int'.
469 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
470 (tiff_load, imagemagick_load_image):
471 Check for overflow in size calculations.
472 (x_create_x_image_and_pixmap): Remove unnecessary test for
473 xmalloc returning NULL; that can't happen.
474 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
475 (xpm_color_bucket): Use better integer hashing function.
476 (xpm_cache_color): Don't possibly over-allocate memory.
477 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
478 (gif_memory_source):
479 Use ptrdiff_t, not int or size_t, to record sizes.
480 (png_load): Don't assume values greater than 2**31 fit in 'int'.
481 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
482 either works, as we prefer signed integers.
483 (tiff_read_from_memory, tiff_write_from_memory):
484 Return tsize_t, not size_t, since that's what the TIFF API wants.
485 (tiff_read_from_memory): Don't fail simply because the read would
486 go past EOF; instead, return a short read.
487 (tiff_load): Omit no-longer-needed casts.
488 (Fimagemagick_types): Don't assume size fits into 'int'.
489
3cc5a532
PE
490 Improve hashing quality when configured --with-wide-int.
491 * fns.c (hash_string): New function, taken from sxhash_string.
492 Do not discard information about ASCII character case; this
493 discarding is no longer needed.
494 (sxhash-string): Use it. Change sig to match it. Caller changed.
495 * lisp.h: Declare it.
496 * lread.c (hash_string): Remove, since we now use fns.c's version.
497 The fns.c version returns a wider integer if --with-wide-int is
498 specified, so this should help the quality of the hashing a bit.
499
b312a492
PE
500 * emacs.c: Integer overflow minor fix.
501 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
502 Define only if GNU_LINUX.
503 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
504
dfd153ae
PE
505 * dispnew.c: Integer signedness and overflow fixes.
506 Remove unnecessary forward decls, that were a maintenance hassle.
507 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
508 All uses changed.
509 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
510 (scrolling_window): Use ptrdiff_t, not int, for byte count.
511 (prepare_desired_row, line_draw_cost):
512 Use int, not unsigned, where either works.
513 (save_current_matrix, restore_current_matrix):
514 Use ptrdiff_t, not size_t, where either works.
515 (init_display): Check for overflow more accurately, and without
516 relying on undefined behavior.
517
a81d11a3
PE
518 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
519 Remove, replacing with the new symbols in lisp.h. All uses changed.
520 * fileio.c (make_temp_name):
521 * filelock.c (lock_file_1, lock_file):
522 * xdisp.c (message_dolog):
523 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
524 Use pMd etc. instead.
525 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
526 replacing the pWIDE etc. symbols removed from editfns.c.
527
3300e6fd
PE
528 * keyboard.h (num_input_events): Now uintmax_t.
529 This is (very slightly) less likely to mess up due to wraparound.
530 All uses changed.
531
fd05c7e9
PE
532 * buffer.c: Integer signedness fixes.
533 (alloc_buffer_text, enlarge_buffer_text):
534 Use ptrdiff_t rather than size_t when either will do, as we prefer
535 signed integers.
536
903fe15d
PE
537 * alloc.c: Integer signedness and overflow fixes.
538 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
539 (__malloc_size_t): Default to size_t, not to int.
540 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
541 (Fgarbage_collect, mark_object_loop_halt, mark_object):
542 Prefer ptrdiff_t to size_t when either would do, as we prefer
543 signed integers.
544 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
545 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
546 Now const. Initialize with values that are in range even if char
547 is signed.
548 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
549 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
550 These functions do the right thing with sizes > 2**32.
551 (check_depth): Now ptrdiff_t, not int.
552 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
553 Adjust to new way of storing sizes. Check for size overflow bugs
554 in rest of code.
555 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
556 slightly wrong anyway, as it missed one instance of
557 XMALLOC_OVERRUN_CHECK_OVERHEAD.
558 (refill_memory_reserve): Omit needless cast to size_t.
559 (mark_object_loop_halt): Mark as externally visible.
560
ac82cc6a
PE
561 * xselect.c: Integer signedness and overflow fixes.
562 (Fx_register_dnd_atom, x_handle_dnd_message):
563 Use ptrdiff_t, not size_t, since we prefer signed.
564 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
565 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
566 x_dnd_atoms_size and x_dnd_atoms_length.
567
c2d1e36d
PE
568 * doprnt.c: Prefer signed to unsigned when either works.
569 * eval.c (verror):
570 * doprnt.c (doprnt):
571 * lisp.h (doprnt):
572 * xdisp.c (vmessage):
573 Use ptrdiff_t, not size_t, when using or implementing doprnt,
574 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
575 prefer signed arithmetic to avoid comparison confusion.
576 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
577 but is a bit tricky.
578
0e926e56
PE
579 Assume freestanding C89 headers, string.h, stdlib.h.
580 * data.c, doprnt.c, floatfns.c, print.c:
581 Include float.h unconditionally.
582 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
583 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
584 * regex.c: Likewise for stddef.h, string.h.
585 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
586 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
587 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
588 (STDC_HEADERS): Remove obsolete defines.
589 * sysdep.c: Include limits.h unconditionally.
590
9cfdb3ec
PE
591 Assume support for memcmp, memcpy, memmove, memset.
592 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
593 * regex.c (memcmp, memcpy):
594 Remove; we assume C89 now.
595
596 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
597 (__malloc_safe_bcopy): Remove; no longer needed.
598
cf950e6b 599 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
600 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
601 well either way, and we prefer signed to unsigned.
602
dbf38e02
LMI
6032011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
604
605 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
606 closes the connection while we're reading (bug#9182).
607
d6f0886c
JD
6082011-07-25 Jan Djärv <jan.h.d@swipnet.se>
609
610 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
611 are specified (Bug#9168).
612
2eb1f9e6
PE
6132011-07-25 Paul Eggert <eggert@cs.ucla.edu>
614
615 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
616 Found by GCC static checking and --with-wide-int on a 32-bit host.
617
22381272 6182011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
619
620 * xdisp.c (compute_display_string_pos): Fix logic of caching
621 previous display string position. Initialize cached_prev_pos to
622 -1. Fixes slow-down at the beginning of a buffer.
623
f25e39b4
EZ
6242011-07-24 Eli Zaretskii <eliz@gnu.org>
625
626 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
627 for attrs[LFACE_FONTSET_INDEX].
628
04c4b52e
PE
6292011-07-23 Paul Eggert <eggert@cs.ucla.edu>
630
631 * xml.c (parse_region): Remove unused local
632 that was recently introduced.
633
c1734fbd
EZ
6342011-07-23 Eli Zaretskii <eliz@gnu.org>
635
be18c5a5
EZ
636 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
637 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
638
c1734fbd
EZ
639 * xdisp.c (move_it_in_display_line_to): Record the best matching
640 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
641 exit if none of the characters scanned was an exact match.
642 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
643 when exact match is impossible due to invisible text, and the
644 lines are truncated.
645
a258d627
JD
6462011-07-23 Jan Djärv <jan.h.d@swipnet.se>
647
648 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
649 for OSX >= 10.7.
650
b6d5a689
EZ
6512011-07-22 Eli Zaretskii <eliz@gnu.org>
652
0f74f785
EZ
653 Fix a significant slow-down of cursor motion with C-n, C-p,
654 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
655 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 656 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
657 (next_element_from_buffer): Call compute_stop_pos_backwards to
658 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
659 base_level_stop.
660 (reseat): Don't look for prev_stop, as that could mean a very long
661 run.
662 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
663 <cached_disp_overlay_modiff>: Cache for last found display string
664 position.
551918c1 665 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
666 about the same buffer in the same area of character positions, and
667 the buffer wasn't changed since the time the display string
668 position was cached.
551918c1 669
b2d0c91a
EZ
6702011-07-22 Eli Zaretskii <eliz@gnu.org>
671
672 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
673 is an integer, which is important for empty lines. (Bug#9149)
674
043604ee
CY
6752011-07-22 Chong Yidong <cyd@stupidchicken.com>
676
677 * frame.c (Fmodify_frame_parameters): In tty case, update the
678 default face if necessary (Bug#4238).
679
da4adb04
CY
6802011-07-21 Chong Yidong <cyd@stupidchicken.com>
681
682 * editfns.c (Fstring_to_char): No need to explain what a character
683 is in the docstring (Bug#6576).
684
9abd0532
LMI
6852011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
686
687 * xml.c (parse_region): Make sure we always return a tree.
688
36881d16
HK
6892011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
690
691 * xml.c (parse_region): If a document contains only comments,
692 return that, too.
693
1e98674d
LMI
6942011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
695
696 * xml.c (make_dom): Return comments, too.
697
590bd467
PE
6982011-07-19 Paul Eggert <eggert@cs.ucla.edu>
699
700 Port to OpenBSD.
701 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
702 and the surrounding thread.
703 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
704 rather than fgets, and retry after EINTR. Otherwise, 'emacs
705 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
706 timer goes off.
707 * s/openbsd.h (BROKEN_SIGIO): Define.
708 * unexelf.c (unexec) [__OpenBSD__]:
709 Don't update the .mdebug section of the Alpha COFF symbol table.
710
f41628b2
LMI
7112011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
712
713 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
714 (bug#8460).
715
b59b67c5
PE
7162011-07-18 Paul Eggert <eggert@cs.ucla.edu>
717
15e3a074
PE
718 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
719 This fixes some race conditions on the permissions of any newly
720 created file.
721
41bed37d
PE
722 * alloc.c (valid_pointer_p): Use pipe, not open.
723 This fixes some permissions issues when debugging.
724
b59b67c5
PE
725 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
726 If fchown fails to set both uid and gid, try to set just gid,
727 as that is sometimes allowed. Adjust the file's mode to eliminate
728 setuid or setgid bits that are inappropriate if fchown fails.
729
925a6be7
SM
7302011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
731
732 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
733 to compare Lisp_Objects.
734 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
735 global_gnutls_log_level, don't mistake it for a Lisp_Object.
736 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
737
52968808
AS
7382011-07-17 Andreas Schwab <schwab@linux-m68k.org>
739
0a6a104b
AS
740 * lread.c (read_integer): Unread even EOF character.
741 (read1): Likewise. Properly record start position of symbol.
742
52968808
AS
743 * lread.c (read1): Read `#:' as empty uninterned symbol if no
744 symbol character follows.
745
9e381cdd
PE
7462011-07-17 Paul Eggert <eggert@cs.ucla.edu>
747
748 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
749 This works around a problem with the previous change to Fcopy_file.
750 Recent glibc declares fchown with __attribute__((warn_unused_result)),
751 and without this change, GCC might complain about discarding
752 fchown's return value.
753
b5641435
JB
7542011-07-16 Juanma Barranquero <lekktu@gmail.com>
755
756 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
757
a8031457
PE
7582011-07-16 Paul Eggert <eggert@cs.ucla.edu>
759
760 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
761
dd889327
LMI
7622011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
763
750c33f7
LMI
764 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
765 it's used from the C level.
766
dd889327
LMI
767 * process.c: Use the same condition for POLL_FOR_INPUT in both
768 keyboard.c and process.c (bug#1858).
769
87e86684
LM
7702011-07-09 Lawrence Mitchell <wence@gmx.li>
771
772 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
773 (Fgnutls_boot): Use it.
774
64348f40
AS
7752011-07-15 Andreas Schwab <schwab@linux-m68k.org>
776
777 * doc.c (Fsubstitute_command_keys): Revert last change.
778
1d698799
LMI
7792011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
780
f863868c
LMI
781 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
782 quotes the next character, and doesn't affect other longer
783 sequences (bug#8935).
784
1d698799
LMI
785 * lread.c (syms_of_lread): Clarify that is isn't only
786 `eval-buffer' and `eval-defun' that's affected by
787 `lexical-binding' (bug#8460).
788
aa4b6df6
EZ
7892011-07-15 Eli Zaretskii <eliz@gnu.org>
790
791 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
792 bidi redisplay when a line includes both an image and is
793 truncated.
794
5d856da6
PE
7952011-07-14 Paul Eggert <eggert@cs.ucla.edu>
796
ad6042bb
PE
797 Fix minor problems found by static checking.
798 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
799 (elsz): Now a signed constant, not a size_t var. We prefer signed
800 types to unsigned, to avoid integer comparison confusion. Without
801 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
802 "cannot optimize loop, the loop counter may overflow", a symptom
803 of the confusion.
f00bbb22 804 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
805 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
806
6468f31c
LMI
8072011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
808
49080b10
LMI
809 * search.c (Fre_search_backward): Mention `case-fold-search' in
810 all the re_search_* functions (bug#8138).
811
6468f31c
LMI
812 * keyboard.c (Fopen_dribble_file): Document when the file is
813 closed (bug#8056).
814
c965adc5
EZ
8152011-07-14 Eli Zaretskii <eliz@gnu.org>
816
df9733bf
EZ
817 * bidi.c (bidi_dump_cached_states): Fix format of displaying
818 bidi_cache_idx.
819
0bb23927
EZ
820 Support bidi reordering of display and overlay strings.
821 * xdisp.c (compute_display_string_pos)
822 (compute_display_string_end): Accept additional argument STRING.
823 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
824 (reseat_to_string): Initialize bidi_it->string.s and
825 bidi_it->string.schars.
826 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
827 NULL (avoids a crash in bidi_paragraph_init).
828 Initialize itb.string.lstring.
0bb23927
EZ
829 (init_iterator): Call bidi_init_it only of a valid
830 buffer position was specified. Initialize paragraph_embedding to
831 L2R.
832 (reseat_to_string): Initialize the bidi iterator.
833 (display_string): If we need to ignore text properties of
834 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
835 original value of -1 will not work with bidi.)
836 (compute_display_string_pos): First arg is now struct
837 `text_pos *'; all callers changed. Support display properties on
838 Lisp strings.
839 (compute_display_string_end): Support display properties on Lisp
840 strings.
841 (init_iterator, reseat_1, reseat_to_string): Initialize the
842 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
843 when iterating on a string not from display properties).
640c8776
SM
844 (compute_display_string_pos, compute_display_string_end):
845 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
846 arrow keys.
847 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
848 base_level_stop; instead, set base_level_stop to BEGV.
849 Fixes crashes in vertical-motion.
0bb23927
EZ
850 (next_element_from_buffer): Improve commentary for when
851 the iterator is before prev_stop.
852 (init_iterator): Initialize bidi_p from the default value of
853 bidi-display-reordering, not from buffer-local value. Use the
854 buffer-local value only if initializing for buffer iteration.
855 (handle_invisible_prop): Support invisible properties on strings
856 that are being bidi-reordered.
857 (set_iterator_to_next): Support bidi reordering of C strings and
858 Lisp strings.
859 (next_element_from_string): Support bidi reordering of Lisp
860 strings.
861 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
862 (display_string): Support display of R2L glyph rows.
863 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
864 (init_iterator): Don't initialize it->bidi_p for strings
865 here.
866 (reseat_to_string): Initialize it->bidi_p for strings here.
867 (next_element_from_string, next_element_from_c_string)
868 (next_element_from_buffer): Add xassert's for correspondence
869 between IT's object being iterated and it->bidi_it.string
870 structure.
871 (face_before_or_after_it_pos): Support bidi iteration.
872 (next_element_from_c_string): Handle the case of the first string
873 character that is not the first one in the visual order.
874 (get_visually_first_element): New function, refactored from common
875 parts of next_element_from_buffer, next_element_from_string, and
876 next_element_from_c_string.
877 (tool_bar_lines_needed, redisplay_tool_bar)
878 (display_menu_bar): Force left-to-right direction. Add a FIXME
879 comment for making that be controlled by a user option.
880 (push_it, pop_it): Save and restore the state of the
881 bidi iterator. Save and restore the bidi_p flag.
882 (pop_it): Iterate out of display property for string iteration as
883 well.
884 (iterate_out_of_display_property): Support iteration over strings.
885 (handle_single_display_spec): Set up it->bidi_it for iteration
886 over a display string, and call bidi_init_it.
887 (handle_single_display_spec, next_overlay_string)
888 (get_overlay_strings_1, push_display_prop): Set up the bidi
889 iterator for displaying display or overlay strings.
890 (forward_to_next_line_start): Don't use the shortcut if
891 bidi-iterating.
892 (back_to_previous_visible_line_start): If handle_display_prop
893 pushed the iterator stack, restore the internal state of the bidi
894 iterator by calling bidi_pop_it same number of times.
895 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
896 and we are bidi-iterating, don't decrement the iterator position;
897 instead, set the first_elt flag in the bidi iterator, to produce
898 the same effect.
899 (reseat_1): Remove redundant setting of string_from_display_prop_p.
900 (push_display_prop): xassert that we are iterating a buffer.
901 (push_it, pop_it): Save and restore paragraph_embedding member.
902 (handle_single_display_spec, next_overlay_string)
903 (get_overlay_strings_1, reseat_1, reseat_to_string)
904 (push_display_prop): Set up the `unibyte' member of bidi_it.string
905 correctly. Don't assume unibyte strings are not bidi-reordered.
906 (compute_display_string_pos)
907 (compute_display_string_end): Fix handling the case of C string.
908 (push_it, pop_it): Save and restore from_disp_prop_p.
909 (handle_single_display_spec, push_display_prop): Set the
910 from_disp_prop_p flag.
911 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
912 (pop_it): Call iterate_out_of_display_property only if we are
913 popping after iteration over a string that came from a display
914 property. Fix a typo in popping stretch info. Add an assertion
915 for verifying that the iterator position is in sync with the bidi
916 iterator.
917 (handle_single_display_spec, get_overlay_strings_1)
918 (push_display_prop): Fix initialization of paragraph direction for
919 string when that of the parent object is not yet determined.
920 (reseat_1): Call bidi_init_it to resync the bidi
921 iterator with IT's position. (Bug#7616)
922 (find_row_edges): If ROW->start.pos gives position
923 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
924 (handle_stop, back_to_previous_visible_line_start, reseat_1):
925 Reset the from_disp_prop_p flag.
926 (SAVE_IT, RESTORE_IT): New macros.
927 (pos_visible_p, face_before_or_after_it_pos)
928 (back_to_previous_visible_line_start)
929 (move_it_in_display_line_to, move_it_in_display_line)
930 (move_it_to, move_it_vertically_backward, move_it_by_lines)
931 (try_scrolling, redisplay_window, display_line): Use them when
932 saving a temporary copy of the iterator and restoring it back.
933 (back_to_previous_visible_line_start, reseat_1)
934 (init_iterator): Empty the bidi cache "stack".
935 (move_it_in_display_line_to): If iterator ended up at
936 EOL, but we never saw any buffer positions smaller than
937 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
938 motion in bidi-reordered lines.
939 (move_it_in_display_line_to): Record prev_method and prev_pos
940 immediately before the call to set_iterator_to_next. Fixes cursor
941 motion in bidi-reordered lines with stretch glyphs and strings
942 displayed in margins. (Bug#8133) (Bug#8867)
943 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
944 TO_CHARPOS.
640c8776
SM
945 (pos_visible_p): Support positions in bidi-reordered lines.
946 Save and restore bidi cache.
0bb23927
EZ
947
948 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
949 (bidi_paragraph_info): Delete unused struct.
950 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
951 (bidi_cache_start): New variable.
952 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
953 to zero.
954 (bidi_cache_fetch_state, bidi_cache_search)
955 (bidi_cache_find_level_change, bidi_cache_iterator_state)
956 (bidi_cache_find, bidi_peek_at_next_level)
957 (bidi_level_of_next_char, bidi_find_other_level_edge)
958 (bidi_move_to_visually_next): Compare cache index with
959 bidi_cache_start rather than with zero.
960 (bidi_fetch_char): Accept new argument STRING; all callers
961 changed. Support iteration over a string. Support strings with
962 display properties. Support unibyte strings. Fix the type of
963 `len' according to what STRING_CHAR_AND_LENGTH expects.
964 (bidi_paragraph_init, bidi_resolve_explicit_1)
965 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
966 (bidi_level_of_next_char, bidi_move_to_visually_next):
967 Support iteration over a string.
0bb23927
EZ
968 (bidi_set_sor_type, bidi_resolve_explicit_1)
969 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
970 can now be zero (for strings); special values 0 and -1 were
971 changed to -1 and -2, respectively.
972 (bidi_char_at_pos): New function.
973 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
974 Call it instead of FETCH_MULTIBYTE_CHAR.
975 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
976 initialized to valid values.
977 (bidi_init_it): Don't initialize charpos and bytepos with invalid
978 values.
979 (bidi_level_of_next_char): Allow the sentinel "position" to pass
980 the test for valid cached positions. Fix the logic for looking up
981 the sentinel state in the cache. GCPRO the Lisp string we are
982 iterating.
983 (bidi_push_it, bidi_pop_it): New functions.
984 (bidi_initialize): Initialize the bidi cache start stack pointer.
985 (bidi_cache_ensure_space): New function, refactored from part of
986 bidi_cache_iterator_state. Don't assume the required size is just
987 one BIDI_CACHE_CHUNK away.
988 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
989 (bidi_count_bytes, bidi_char_at_pos): New functions.
990 (bidi_cache_search): Don't assume bidi_cache_last_idx is
991 always valid if bidi_cache_idx is valid.
992 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
993 is valid if it's going to be used.
994 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
995 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
996 (bidi_cache_find_level_change, bidi_cache_ensure_space)
997 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
998 (bidi_find_other_level_edge, bidi_cache_start_stack):
999 All variables related to cache indices are now EMACS_INT.
c965adc5 1000
0bb23927
EZ
1001 * dispextern.h (struct bidi_string_data): New structure.
1002 (struct bidi_it): New member `string'. Make flag members be 1-bit
1003 fields, and put them last in the struct.
640c8776
SM
1004 (compute_display_string_pos, compute_display_string_end):
1005 Update prototypes.
0bb23927
EZ
1006 (bidi_push_it, bidi_pop_it): Add prototypes.
1007 (struct iterator_stack_entry): New members bidi_p,
1008 paragraph_embedding, and from_disp_prop_p.
1009 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1010 (bidi_shelve_cache, bidi_unshelve_cache):
1011 Declare prototypes.
0bb23927
EZ
1012
1013 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1014 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1015 and vector-like objects.
1016
1017 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1018 cache around display iteration.
1019
1020 * window.c (Fwindow_end, window_scroll_pixel_based)
1021 (displayed_window_lines, Frecenter): Save and restore the bidi
1022 cache around display iteration.
1023
3bbd2265
LMI
10242011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1025
1026 * editfns.c (Fdelete_region): Clarify the use of the named
1027 parameters (bug#6788).
1028
adc47434
MR
10292011-07-14 Martin Rudalics <rudalics@gmx.at>
1030
1031 * indent.c (Fvertical_motion): Set and restore w->pointm when
1032 saving and restoring the window's buffer (Bug#9006).
1033
837c31f8
LMI
10342011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1035
1036 * editfns.c (Fstring_to_char): Clarify just what is returned
1037 (bug#6576). Text by Eli Zaretskii.
1038
ac389d0c
JB
10392011-07-13 Juanma Barranquero <lekktu@gmail.com>
1040
1041 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1042
0be0ce47
EZ
10432011-07-13 Eli Zaretskii <eliz@gnu.org>
1044
1045 * buffer.c (mmap_find): Fix a typo.
1046
cd18e7e3
JB
10472011-07-13 Johan Bockgård <bojohan@gnu.org>
1048
1049 Fix execution of x selection hooks.
1050 * xselect.c (Qx_lost_selection_functions)
1051 (Qx_sent_selection_functions): New vars.
1052 (syms_of_xselect): DEFSYM them.
1053 (x_handle_selection_request): Pass Qx_sent_selection_functions
1054 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1055 (x_handle_selection_clear,x_clear_frame_selections):
1056 Pass Qx_lost_selection_functions rather than
1057 Vx_lost_selection_functions to Frun_hook_with_args.
1058
47ea7f44
PE
10592011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1060
ac389d0c 1061 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1062 The old code sometimes used this field without initializing it.
1063
47ea7f44
PE
1064 * alloc.c (gc_sweep): Don't read past end of array.
1065 In theory, the old code could also have corrupted Emacs internals,
1066 though it'd be very unlikely.
1067
bc985c87
AS
10682011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1069
1070 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1071 argument. (Bug#4026)
bc985c87 1072
0cf34688
LMI
10732011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1074
b3dadd76
LMI
1075 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1076 key" (bug#4257).
1077
0cf34688
LMI
1078 * window.c (Fset_window_start): Doc fix (bug#4199).
1079 (Fset_window_hscroll): Ditto.
1080
270768cd
PE
10812011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1082
077e3dda 1083 Fix minor new problems caught by GCC 4.6.1.
270768cd 1084 * term.c (init_tty): Remove unused local.
490011a6 1085 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1086 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1087 not used otherwise.
270768cd 1088
b1f58454
CY
10892011-07-12 Chong Yidong <cyd@stupidchicken.com>
1090
1091 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1092
22b9578d
LMI
10932011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1094
6e70ab07
LMI
1095 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1096 are the mini-buffer and the echo area (bug#3320).
1097
22b9578d
LMI
1098 * term.c (init_tty): Remove support for supdup, c10 and perq
1099 terminals, which are no longer supported (bug#1482).
1100
8974cc9f
JB
11012011-07-10 Johan Bockgård <bojohan@gnu.org>
1102
1103 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1104
a560d974
JD
11052011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1106
1107 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1108 for non-popups (Bug#3642).
1109
1dae0f0a
AS
11102011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1111
268c2c36 1112 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1113 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1114 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1115 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1116 * data.c (fmod): Likewise.
1117 * dispnew.c (swap_glyphs_in_rows): Likewise.
1118 * emacs.c (memory_warning_signal): Likewise.
1119 * floatfns.c (float_error): Likewise.
1120 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1121 (otf_open, font_otf_capability, generate_otf_features)
1122 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1123 Likewise.
1124 * image.c (pbm_read_file): Likewise.
1125 * indent.c (string_display_width): Likewise.
1126 * intervals.c (check_for_interval, search_for_interval)
1127 (inc_interval_count, count_intervals, root_interval)
1128 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1129 * lread.c (defalias): Likewise.
268c2c36 1130 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1131 * regex.c (set_image_of_range_1, set_image_of_range)
1132 (regex_grow_registers): Likewise.
1133 * sysdep.c (strerror): Likewise.
1134 * termcap.c (valid_filename_p, tprint, main): Likewise.
1135 * tparam.c (main): Likewise.
1136 * unexhp9k800.c (run_time_remap, save_data_space)
1137 (update_file_ptrs, read_header, write_header, calculate_checksum)
1138 (copy_file, copy_rest, display_header): Likewise.
1139 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1140 Likewise.
1141 * xdisp.c (check_it): Likewise.
1142 * xfaces.c (register_color, unregister_color, unregister_colors):
1143 Likewise.
1144 * xfns.c (print_fontset_result): Likewise.
1145 * xrdb.c (member, fatal, main): Likewise.
1146
99033785
PE
11472011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1148
1149 Fix minor problems found by static checking (Bug#9031).
1150 * chartab.c (char_table_set_range, map_sub_char_table):
1151 Remove unused locals.
1152 (uniprop_table): Now static.
1153 * composite.c (_work_char): Remove unused static var.
1154
9cb2ac56
JB
11552011-07-09 Juanma Barranquero <lekktu@gmail.com>
1156
1157 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1158
f25661f0
JD
11592011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1160
1161 * gtkutil.c (qttip_cb): Remove code without function.
1162
8278c4fe
EZ
11632011-07-09 Eli Zaretskii <eliz@gnu.org>
1164
1165 * w32.c (pthread_sigmask): New stub.
1166
1692ae2d 11672011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1168
8a6ebd58 1169 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1170 sigprocmask is portable only for single-threaded applications, and
1171 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1172 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1173 (LIBES): Use it.
1174 * callproc.c (Fcall_process):
1175 * process.c (create_process):
1176 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1177 Use pthread_sigmask, not sigprocmask.
123403e4 1178
1b854618
JD
11792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1180
1181 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1182 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1183 wrong (Bug#8591).
1184
3fe4b549
JD
11852011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1186
0ce7e563
JD
1187 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1188 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1189 (xg_hide_tooltip): Fix comment.
1190
3fe4b549
JD
1191 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1192 in registerServicesMenuSendTypes.
1193 (validRequestorForSendType): Don't check ns_return_types.
1194
1195 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1196 ns_return_type.
1197
5df75e47
JR
11982011-07-08 Jason Rumney <jasonr@gnu.org>
1199
1200 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1201 frame struct members of non-existent frames (Bug#6284).
1202
699c10bd
JD
12032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1204
4393663b
JD
1205 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1206 variable firstTime not needed on OSX >= 10.6.
1207 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1208 >= 10.5. Use setKnobProportion, setDoubleValue.
1209
1210 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1211 (MAC_OS_X_VERSION_10_5): Define if not defined.
1212 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1213 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1214 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1215
1216 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1217 cString and lossyCString on OSX >= 10.4
1218
1219 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1220 sizeToFit on OSX >= 10.2.
1221
1222 * nsimage.m (allocInitFromFile): Don't use deprecated method
1223 bestRepresentationForDevice on OSX >= 10.6.
1224
1225 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1226 to avoid warning.
1227
1228 * emacs.c: Declare unexec_init_emacs_zone.
1229
a63e0781
JD
1230 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1231
699c10bd
JD
1232 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1233
1234 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1235 on svcsMenu (Bug#8842).
1236
1237 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1238 ns_return_types.
1239 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1240
1241 * nsterm.m (QUTF8_STRING): Declare.
1242 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1243 (validRequestorForSendType): Return type is (id).
1244 Change indexOfObjectIdenticalTo to indexOfObject.
1245 Check if we have local selection before returning self (Bug#8842).
1246 (writeSelectionToPasteboard): Put local selection into paste board
1247 if we have a local selection (Bug#8842).
1248 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1249
1250 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1251 (ns_get_local_selection): Declare.
1252
54e10184
LMI
12532011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1254
9888ff71
LMI
1255 * keymap.c (describe_map_tree): Don't insert a double newline at
1256 the end of the buffer (bug#1169) and return whether we inserted
1257 something.
1258
54e10184
LMI
1259 * callint.c (Fcall_interactively): Change "reading args" to
1260 "providing args" to try to clarify what it does (bug#1010).
1261
15fa4783
KH
12622011-07-07 Kenichi Handa <handa@m17n.org>
1263
1264 * composite.c (composition_compute_stop_pos): Ignore a static
1265 composition starting before CHARPOS (Bug#8915).
1266
1267 * xdisp.c (handle_composition_prop): Likewise.
1268
a8815b00
EZ
12692011-07-07 Eli Zaretskii <eliz@gnu.org>
1270
1271 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1272 (Bug#9015)
1273
ef7b981d 12742011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1275
1276 * character.h (unicode_category_t): New enum type.
1277
1278 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1279 (Qchar_code_property_table): New variable.
1280 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1281 (UNIPROP_COMPRESSED_FORM_P): New macros.
1282 (char_table_ascii): Uncompress the compressed values.
1283 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1284 Uncompress the compressed values.
ac389d0c 1285 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1286 (char_table_ref_and_range): Uncompress the compressed values.
1287 (sub_char_table_set): New arg is_uniprop. Callers changed.
1288 Uncompress the compressed values.
1289 (sub_char_table_set_range): Args changed. Callers changed.
1290 (char_table_set_range): Adjuted for the above change.
1291 (map_sub_char_table): Delete args default_val and parent. Add arg
1292 top. Give decoded values to a Lisp function.
640c8776 1293 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1294 values to a Lisp function. Gcpro more variables.
1295 (uniprop_table_uncompress)
1296 (uniprop_decode_value_run_length): New functions.
1297 (uniprop_decoder, uniprop_decoder_count): New variables.
1298 (uniprop_get_decoder, uniprop_encode_value_character)
1299 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1300 New functions.
1301 (uniprop_encoder, uniprop_encoder_count): New variables.
1302 (uniprop_get_encoder, uniprop_table)
1303 (Funicode_property_table_internal, Fget_unicode_property_internal)
1304 (Fput_unicode_property_internal): New functions.
1305 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1306 Sunicode_property_table_internal, Sget_unicode_property_internal,
1307 and Sput_unicode_property_internal. Defvar_lisp
1308 char-code-property-alist.
1309
640c8776 1310 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1311 Vunicode_category_table.
1312
640c8776 1313 * font.c (font_range): Adjust for the change of
c805dec0
KH
1314 Vunicode_category_table.
1315
76b397fb
DN
13162011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1317
1318 * m/iris4d.h: Remove file, move contents ...
1319 * s/irix6-5.h: ... here.
1320
22b4128e
PE
13212011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1322
1323 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1324 * alloc.c (mark_buffer):
1325 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1326 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1327 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1328 This isn't true in general, and it's particularly not true
1329 if Emacs is configured with --with-wide-int.
1330 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1331 New macros, used in the buffer.c change.
1332
869795d6
JD
13332011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1334
1335 * xsettings.c: Use both GConf and GSettings if both are available.
1336 (store_config_changed_event): Add comment.
1337 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1338 (store_tool_bar_style_changed): New functions.
1339 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1340 (struct xsettings): Move font inside HAVE_XFT.
1341 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1342 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1343 Move inside HAVE_XFT.
640c8776 1344 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1345 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1346 also.
1347 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1348 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1349 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1350 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1351 (parse_settings): Move check for font inside HAVE_XFT.
1352 (read_settings, apply_xft_settings): Add comment.
1353 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1354 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1355 call store_font_name_changed.
1356 (xft_settings_event): Add comment.
1357 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1358 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1359 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1360 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1361 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1362 (xsettings_get_system_font, xsettings_get_system_normal_font):
1363 Add comment.
869795d6 1364
d8ed26bd
PE
13652011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1366
1367 Random fixes. E.g., (random) never returned negative values.
1368 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1369 subseconds part to the entropy, as that's a bit more random.
1370 Prefer signed to unsigned, since the signedness doesn't matter and
1371 in general we prefer signed. When given a limit, use a
1372 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1373 latter isn't right if USE_2_TAGS_FOR_INTS.
1374 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1375 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1376
cabf1cac
SM
13772011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1378
1379 * textprop.c (text_property_stickiness):
1380 Obey Vtext_property_default_nonsticky.
1381 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1382 * w32fns.c (syms_of_w32fns):
1383 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1384
6e9b2be9
PE
13852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1386
1387 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1388 This is more efficient than Ffile_directory_p and avoids a minor race.
1389
90186c68
LMI
13902011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1391
7c301272
LMI
1392 * buffer.c (Foverlay_put): Say what the return value is
1393 (bug#7835).
1394
c4f2d8d4
LMI
1395 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1396 is a directory before asking whether to use the file name
1397 (bug#7564).
ad637907
LMI
1398 (barf_or_query_if_file_exists): Make the "File is a directory"
1399 error be more correct.
c4f2d8d4 1400
90186c68
LMI
1401 * fns.c (Frequire): Remove the mention of the .gz files, since
1402 that's installation-specific, but keep the mention of
1403 `get-load-suffixes'.
1404
da64016e
PE
14052011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1406
1407 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1408 Report string overflow if the output is too long.
1409
7d47b580
JB
14102011-07-04 Juanma Barranquero <lekktu@gmail.com>
1411
a555cb87
JB
1412 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1413 (syms_of_gnutls): Remove duplicate DEFSYM for
1414 Qgnutls_bootprop_verify_hostname_error, an error for
1415 Qgnutls_bootprop_verify_error (which is no longer used).
1416
7d47b580
JB
1417 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1418 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1419 Also (re)move comments that are misplaced or no longer relevant.
1420
1e49bfab
LMI
14212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1422
1423 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1424
1485f4c0
CY
14252011-07-03 Chong Yidong <cyd@stupidchicken.com>
1426
1427 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1428 and background color parameters if they have been changed.
1429
a9ab721e
LMI
14302011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1431
1432 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1433
cf7cff57
PE
14342011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1435
2e13213d
PE
1436 * xsettings.c (SYSTEM_FONT): Define only when used.
1437 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1438
cf7cff57
PE
1439 * keymap.c (access_keymap_1): Now static.
1440
7a8e04f7
CY
14412011-07-02 Chong Yidong <cyd@stupidchicken.com>
1442
1443 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1444 leave any prefix arg for the up event (Bug#1586).
1445
61352f62
LMI
14462011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1447
69bb1ef7
LMI
1448 * lread.c (syms_of_lread): Mention single symbols defined by
1449 `defvar' or `defconst' (bug#7154).
1450
61352f62 1451 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1452 (Frequire): Mention get-load-suffixes.
61352f62 1453
28545e04
MR
14542011-07-02 Martin Rudalics <rudalics@gmx.at>
1455
1456 * window.h (window): Remove clone_number slot.
1457 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1458 Remove.
1459 (make_parent_window, make_window, saved_window)
1460 (Fset_window_configuration, save_window_save): Don't deal with
1461 clone numbers.
1462 * buffer.c (Qclone_number): Remove declaration.
1463 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1464
3349e122
SM
14652011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1466
1467 Add multiple inheritance to keymaps.
1468 * keymap.c (Fmake_composed_keymap): New function.
1469 (Fset_keymap_parent): Simplify.
1470 (fix_submap_inheritance): Remove.
1471 (access_keymap_1): New function extracted from access_keymap to handle
1472 embedded parents and handle lists of maps.
1473 (access_keymap): Use it.
1474 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1475 (Fcopy_keymap): Handle embedded parents.
1476 (Fcommand_remapping, define_as_prefix): Simplify.
1477 (Fkey_binding): Simplify.
1478 (syms_of_keymap): Move minibuffer-local-completion-map,
1479 minibuffer-local-filename-completion-map,
1480 minibuffer-local-must-match-map, and
1481 minibuffer-local-filename-must-match-map to Elisp.
1482 (syms_of_keymap): Defsubr make-composed-keymap.
1483 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1484 (parse_menu_item): Trivial simplification.
1485
3279eb87
GM
14862011-07-01 Glenn Morris <rgm@gnu.org>
1487
1488 * Makefile.in (SETTINGS_LIBS): Fix typo.
1489
4550efdf
KI
14902011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1491
1492 * coding.c (Fencode_coding_string): Record the last coding system
1493 used, as the function doc string says (bug#8738).
1494
0949d2b6
JD
14952011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1496
1497 * xsettings.c (store_monospaced_changed): Take new font as arg and
1498 check for change against current_mono_font.
1499 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1500 (emacs_settings_constructor, emacs_settings_get_property)
1501 (emacs_settings_set_property, emacs_settings_class_init)
1502 (emacs_settings_init, gsettings_obj): Remove.
1503 (something_changedCB): New function for HAVE_GSETTINGS.
1504 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1505 with value as argument.
1506 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1507 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1508 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1509 "changed".
1510
1511 * xgselect.c: Add defined (HAVE_GSETTINGS).
1512 (xgselect_initialize): Ditto.
1513
1514 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1515 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1516 xg_select.
1517
bbc6b304
PE
15182011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 * eval.c (struct backtrace): Simplify and port the data structure.
1521 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1522 signed bit field, as this assumption is not portable and it makes
1523 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1524 "char debug_on_exit : 1" as this is not portable either; instead,
1525 use the portable "unsigned int debug_on_exit : 1". Remove unused
1526 member evalargs. Remove obsolete comments about cc bombing out.
1527
9851bfc5
JD
15282011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1529
51bb811f 1530 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1531 Let HAVE_GSETTINGS override HAVE_GCONF.
1532 (store_monospaced_changed): New function.
1533 (EMACS_SETTINGS): A new type derived from GObject to handle
1534 GSettings notifications.
1535 (emacs_settings_constructor, emacs_settings_get_property)
1536 (emacs_settings_set_property, emacs_settings_class_init):
1537 New functions.
1538 (gsettings_client, gsettings_obj): New variables.
1539 (GSETTINGS_SCHEMA): New define.
1540 (something_changedCB): Call store_monospaced_changed.
1541 (init_gsettings): New function.
1542 (xsettings_initialize): Call init_gsettings.
1543 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1544 to NULL.
1545
640c8776 1546 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1547 GCONF_CFLAGS/LIBS.
1548
5386012d
MR
15492011-06-29 Martin Rudalics <rudalics@gmx.at>
1550
1551 * window.c (resize_root_window, grow_mini_window)
1552 (shrink_mini_window): Rename Qresize_root_window to
1553 Qwindow_resize_root_window and Qresize_root_window_vertically to
1554 Qwindow_resize_root_window_vertically.
1555
f13e0b08
PE
15562011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1557
1558 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1559
94515237
JB
15602011-06-27 Juanma Barranquero <lekktu@gmail.com>
1561
1562 * makefile.w32-in: Redesign dependencies so they reflect more
1563 clearly which files are directly included by each source file,
1564 and not through other includes.
1565
e43b6e43
MR
15662011-06-27 Martin Rudalics <rudalics@gmx.at>
1567
1568 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1569 (sort_overlays, overlay_strings): When an overlay's clone number
1570 matches the window's clone number process the overlay even if
1571 the overlay's window property doesn't match the current window.
1572
d68443dc
MR
1573 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1574 (Fwindow_hchild): Rename to Fwindow_left_child.
1575 (Fwindow_next): Rename to Fwindow_next_sibling.
1576 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1577 (resize_window_check): Rename to window_resize_check.
1578 (resize_window_apply): Rename to window_resize_apply.
1579 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1580 (Fdelete_other_windows_internal, resize_frame_windows)
1581 (Fsplit_window_internal, Fdelete_window_internal)
1582 (grow_mini_window, shrink_mini_window)
1583 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1584
c7e73be5
JD
15852011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1586
1587 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1588 (emacs_fixed_set_min_size): Remove.
1589 (emacs_fixed_new): Take frame as argument.
1590
1591 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1592 (_EmacsFixedPrivate): Remove minwidth/height.
1593 Add struct frame *f.
1594 (emacs_fixed_init): Initialize priv->f.
1595 (get_parent_class, emacs_fixed_set_min_size): Remove.
1596 (emacs_fixed_new): Set priv->f to argument.
1597 (emacs_fixed_get_preferred_width)
1598 (emacs_fixed_get_preferred_height): Use min_width/height from
1599 frames size_hint to set minimum and natural (Bug#8919).
1600 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1601 and use min_width/height from frames size_hint to set
1602 min_width/height (Bug#8919).
1603
1604 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1605 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1606 Fix indentation.
c7e73be5 1607
cf99dcf8
EZ
16082011-06-26 Eli Zaretskii <eliz@gnu.org>
1609
1610 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1611 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1612 called at ZV.
1613
029529ac
CY
16142011-06-26 Chong Yidong <cyd@stupidchicken.com>
1615
1616 * process.c (wait_reading_process_output): Bypass select if
1617 waiting for a cell while ignoring keyboard input, and input is
1618 pending. Suggested by Jan Djärv (Bug#8869).
1619
7a7ef429
PE
16202011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1621
1622 Use gnulib's dup2 module instead of rolling our own.
1623 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1624
11fdef7d 16252011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1626
1627 * dispnew.c (scrolling_window): Before scrolling, turn off a
1628 mouse-highlight in the window being scrolled.
1629
cd3520a4
JB
16302011-06-24 Juanma Barranquero <lekktu@gmail.com>
1631
1632 Move DEFSYM to lisp.h and use everywhere.
1633
1634 * character.h (DEFSYM): Move declaration...
1635 * lisp.h (DEFSYM): ...here.
1636
1637 * gnutls.c:
1638 * minibuf.c:
1639 * w32menu.c:
1640 * w32proc.c:
1641 * w32select.c: Don't include character.h.
1642
1643 * alloc.c (syms_of_alloc):
1644 * buffer.c (syms_of_buffer):
1645 * bytecode.c (syms_of_bytecode):
1646 * callint.c (syms_of_callint):
1647 * casefiddle.c (syms_of_casefiddle):
1648 * casetab.c (init_casetab_once):
1649 * category.c (init_category_once, syms_of_category):
1650 * ccl.c (syms_of_ccl):
1651 * cmds.c (syms_of_cmds):
1652 * composite.c (syms_of_composite):
1653 * dbusbind.c (syms_of_dbusbind):
1654 * dired.c (syms_of_dired):
1655 * dispnew.c (syms_of_display):
1656 * doc.c (syms_of_doc):
1657 * editfns.c (syms_of_editfns):
1658 * emacs.c (syms_of_emacs):
1659 * eval.c (syms_of_eval):
1660 * fileio.c (syms_of_fileio):
1661 * fns.c (syms_of_fns):
1662 * frame.c (syms_of_frame):
1663 * fringe.c (syms_of_fringe):
1664 * insdel.c (syms_of_insdel):
1665 * keymap.c (syms_of_keymap):
1666 * lread.c (init_obarray, syms_of_lread):
1667 * macros.c (syms_of_macros):
1668 * msdos.c (syms_of_msdos):
1669 * print.c (syms_of_print):
1670 * process.c (syms_of_process):
1671 * search.c (syms_of_search):
1672 * sound.c (syms_of_sound):
1673 * syntax.c (init_syntax_once, syms_of_syntax):
1674 * terminal.c (syms_of_terminal):
1675 * textprop.c (syms_of_textprop):
1676 * undo.c (syms_of_undo):
1677 * w32.c (globals_of_w32):
1678 * window.c (syms_of_window):
1679 * xdisp.c (syms_of_xdisp):
1680 * xfaces.c (syms_of_xfaces):
1681 * xfns.c (syms_of_xfns):
1682 * xmenu.c (syms_of_xmenu):
1683 * xsettings.c (syms_of_xsettings):
1684 * xterm.c (syms_of_xterm): Use DEFSYM.
1685
4228cf16
TZ
16862011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1687
cd3520a4 1688 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1689
7fcccf1e
PE
16902011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1691
7efb4e0e
PE
1692 Integer and buffer overflow fixes (Bug#8873).
1693
ff5844ad
PE
1694 * print.c (printchar, strout): Check for string overflow.
1695 (PRINTPREPARE, printchar, strout):
1696 Don't set size unless allocation succeeds.
1697
90532f02
PE
1698 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1699 for sizes. Check for string overflow more accurately.
1700 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1701
6d84508d
PE
1702 * macros.c: Integer and buffer overflow fixes.
1703 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1704 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1705 Use ptrdiff_t, not int, for sizes.
1706 Don't increment bufsize until after realloc succeeds.
1707 Check for size-calculation overflow.
1708 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1709
437b2cb4
PE
1710 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1711
8b9ac8b4
PE
1712 * lread.c: Integer overflow fixes.
1713 (read_integer): Radix is now EMACS_INT, not int,
1714 to improve quality of diagnostics for out-of-range radices.
1715 Calculate buffer size correctly for out-of-range radices.
1716 (read1): Check for integer overflow in radices, and in
1717 read-circle numbers.
82cb60d3
PE
1718 (read_escape): Avoid int overflow.
1719 (Fload, openp, read_buffer_size, read1)
1720 (substitute_object_recurse, read_vector, read_list, map_obarray):
1721 Use ptrdiff_t, not int, for sizes.
1722 (read1): Use EMACS_INT, not int, for sizes.
20270765 1723 Check for size overflow.
8b9ac8b4 1724
7fcccf1e
PE
1725 * image.c (cache_image): Check for size arithmetic overflow.
1726
bfbbd7e7
PE
1727 * lread.c: Integer overflow issues.
1728 (saved_doc_string_size, saved_doc_string_length)
1729 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1730 Now ptrdiff_t, not int.
1731 (read1): Don't assume doc string length fits in int. Check for
1732 out-of-range doc string lengths.
1733 (read_list): Don't assume file position fits in int.
39019e54 1734 (read_escape): Check for hex character overflow.
bfbbd7e7 1735
4e323265
LL
17362011-06-22 Leo Liu <sdl.web@gmail.com>
1737
1738 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1739 Move to minibuffer.el.
1740
85fece3e
PE
17412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1742
20b84ce9 1743 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1744 The following patches are for when GLYPH_DEBUG && !XASSERT.
1745 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1746 * dispnew.c (flush_stdout):
1747 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1748 Mark as externally visible.
1749 * dispnew.c (check_window_matrix_pointers): Now static.
1750 * dispnew.c (window_to_frame_vpos):
1751 * xfns.c (unwind_create_frame):
1752 * xterm.c (x_check_font): Remove unused local.
1753 * scroll.c (CHECK_BOUNDS):
1754 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1755 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1756 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1757 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1758 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1759 Now static.
1760 (debug_method_add): Use va_list and vsprintf rather than relying
1761 on undefined behavior with wrong number of arguments.
1762 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1763 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1764 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1765 since we're not interested in debugging glyphs with old libraries.
1766 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1767 GCC 4.6.0's static checking.
1768
0766b489
PE
17692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1770
31fd4b32
PE
1771 Integer overflow and signedness fixes (Bug#8873).
1772 A few related buffer overrun fixes, too.
1773
b79e8648
PE
1774 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1775
0766b489
PE
1776 * dispextern.h (struct face.stipple):
1777 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1778 (x_bitmap_mask, x_allocate_bitmap_record)
1779 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1780 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1781 (x_create_bitmap_from_xpm_data):
1782 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1783 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1784 (.bitmaps_last):
1785 * xfaces.c (load_pixmap):
1786 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1787 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1788 (.bitmaps_last, struct x_output.icon_bitmap):
1789 Use ptrdiff_t, not int, for bitmap indexes.
1790 (x_allocate_bitmap_record): Check for size overflow.
1791 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1792
b081724f
PE
1793 Use ptrdiff_t, not int, for overlay counts.
1794 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1795 * editfns.c (overlays_around, get_pos_property):
1796 * textprop.c (get_char_property_and_overlay):
1797 * xdisp.c (next_overlay_change, note_mouse_highlight):
1798 * xfaces.c (face_at_buffer_position):
21514da7
PE
1799 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1800 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1801 (Fnext_overlay_change, Fprevious_overlay_change)
1802 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1803 Use ptrdiff_t, not int, for sizes.
21514da7 1804 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1805
3de73e5e
PE
1806 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1807
2606c57b
PE
1808 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1809 (x_session_initialize): Do not assume string length fits in int.
1810
aaafe47a
PE
1811 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1812 This is unlikely, but can occur if DPI is outlandish.
1813
2674ddc8 1814 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1815 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1816
28154962
PE
1817 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1818 * xrdb.c (magic_file_p, search_magic_path):
1819 Omit last arg SUFFIX; it was always 0. All callers changed.
1820 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1821
7de51af5
PE
1822 * xfont.c (xfont_match): Avoid need for strlen.
1823
25ed6cc3
PE
1824 * xfns.c: Don't assume strlen fits in int.
1825 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1826
4eab31dd
PE
1827 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1828 not unsigned long, as we prefer signed integers. All callers changed.
1829 Detect integer overflow in repeat count.
1830 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1831 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1832
171e2a58
PE
1833 * termcap.c: Don't assume sizes fit in int and never overflow.
1834 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1835 (gobble_line): Check for size-calculation overflow.
1836
ad39faca 1837 * minibuf.c (Fread_buffer):
6e5bb2dc 1838 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1839 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1840 Don't assume string length fits in int.
1841
52c61c22 1842 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1843 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1844
b5b8c9e5
PE
1845 * font.c: Don't assume string length fits in int.
1846 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1847 Use ptrdiff_t, not int.
ccd6111c
PE
1848 (font_intern_prop): Don't assume string length fits in int.
1849 Don't assume integer property fits in fixnum.
1850 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1851
882f0d81 1852 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1853 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1854 Reformulate so as not to need the command string.
1855 Invoke gzip -cd rather than gunzip, as it's more portable.
1856 (lock_info_type, lock_file_1, lock_file):
1857 Don't assume pid_t and time_t fit in unsigned long.
1858 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1859 (current_lock_owner): Prefer signed type for sizes.
1860 Use memcpy, not strncpy, where memcpy is what is really wanted.
1861 Don't assume (via atoi) that time_t and pid_t fit in int.
1862 Check for time_t and/or pid_t out of range, e.g., via a network share.
1863 Don't alloca where an auto var works fine.
1864
93f4cf88
PE
1865 * fileio.c: Fix some integer overflow issues.
1866 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1867 Don't assume string length fits in int.
1868 (directory_file_name): Don't assume string length fits in long.
1869 (make_temp_name): Don't assume pid fits in int, or that its print
1870 length is less than 20.
1871
f3e92b69
PE
1872 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1873
1bfdaf10
PE
1874 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1875
35016e9a
PE
1876 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1877
3d1e65a1
PE
1878 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1879 We prefer signed integers, even for size calculations.
1880
0b963a93
PE
1881 * emacs.c: Don't assume string length fits in 'int'.
1882 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1883 (main): Don't invoke strlen when not needed.
1884
573f4b54
PE
1885 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1886 (XD_DEBUG_MESSAGE): Don't waste a byte.
1887
989f33ba
PE
1888 * callproc.c (getenv_internal_1, getenv_internal)
1889 (Fgetenv_internal):
965d34eb
PE
1890 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1891
e4d29b33
PE
1892 * lread.c (invalid_syntax): Omit length argument.
1893 All uses changed. This doesn't fix a bug, but it simplifies the
1894 code away from its former Hollerith-constant appearance, and it's
1895 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1896 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1897
eb49b136
PE
1898 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1899 This didn't break anything, but it didn't help either.
1900 It's confusing to put a bogus integer in a place where the actual
1901 value does not matter.
9f62aeb1 1902 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1903 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1904
15375a22
PE
1905 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1906 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1907 implementation.
b61cc01c
PE
1908 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1909 We prefer signed types, and the value cannot exceed the EMACS_INT
1910 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1911 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1912 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1913 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1914
53b2623d
PE
1915 * indent.c (sane_tab_width): New function.
1916 (current_column, scan_for_column, Findent_to, position_indentation)
1917 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1918 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1919
51cab52b 1920 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1921
f2ed8a70
PE
1922 * lisp.h (lint_assume): New macro.
1923 * composite.c (composition_gstring_put_cache):
1924 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1925
abe80cc6
PE
1926 * editfns.c, insdel.c:
1927 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1928
b02c740e
PE
1929 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1930
ebc96716
PE
1931 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1932
b4e50fa0 1933 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1934 Use much-faster test for byte-length change.
311d5d7c 1935 Don't assume string byte-length fits in 'int'.
a4cf38e4 1936 Check that character arg fits in 'int'.
85461888 1937 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1938
c0c1ee9f
PE
1939 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1940
a498d7f4
PE
1941 * fns.c (concat): Catch string overflow earlier.
1942 Do not rely on integer wraparound.
1943
51cab52b
PE
1944 * dispextern.h (struct it.overlay_strings_charpos)
1945 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1946 * xdisp.c (forward_to_next_line_start)
1947 (back_to_previous_visible_line_start)
1948 (reseat_at_next_visible_line_start, next_element_from_buffer):
1949 Don't arbitrarily truncate the value of 'selective' to int.
1950
76031fad
PE
1951 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1952
5eb55db9
PE
1953 * composite.c: Don't truncate sizes to 'int'.
1954 (composition_gstring_p, composition_reseat_it)
1955 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1956 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1957 not EMACS_UINT, for indexes.
5eb55db9 1958
0703a717
PE
1959 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1960
d6202519
PE
1961 * buffer.c: Include <verify.h>.
1962 (struct sortvec.priority, struct sortstr.priority):
8961a454 1963 Now EMACS_INT, not int.
c20998a7 1964 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1965 (struct sortstr.size, record_overlay_string)
1966 (struct sortstrlist.size, struct sortlist.used):
1967 Don't truncate size to int.
1968 (record_overlay_string): Check for size-calculation overflow.
d6202519 1969 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1970
d5a19415
JM
19712011-06-22 Jim Meyering <meyering@redhat.com>
1972
029529ac 1973 Don't leak an XBM-image-sized buffer
d5a19415
JM
1974 * image.c (xbm_load): Free the image buffer after using it.
1975
a9041e6c
PE
19762011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1977
1978 Port to Sun C.
1979 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1980 that Sun C diagnosed.
1981 * fns.c (secure_hash): Fix pointer signedness issue.
1982 * intervals.c (static_offset_intervals): New function.
1983 (offset_intervals): Use it.
1984
7f3f739f
LL
19852011-06-21 Leo Liu <sdl.web@gmail.com>
1986
1987 * deps.mk (fns.o):
1988 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1989 sha512.h.
1990
1991 * fns.c (secure_hash): Rename from crypto_hash_function and change
1992 the first arg to accept symbols.
5b66d427 1993 (Fsecure_hash): New primitive.
7f3f739f
LL
1994 (syms_of_fns): New symbols.
1995
76147d94
DD
19962011-06-20 Deniz Dogan <deniz@dogan.se>
1997
1998 * process.c (Fset_process_buffer): Clarify return value in
1999 docstring.
2000
7d7d0045
CY
20012011-06-18 Chong Yidong <cyd@stupidchicken.com>
2002
2003 * dispnew.c (add_window_display_history): Use BVAR.
2004
2005 * xdisp.c (debug_method_add): Use BVAR.
2006 (check_window_end, dump_glyph_matrix, dump_glyph)
2007 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2008
2009 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2010 Likewise.
2011
2012 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2013 check till after the cache is created in init_frame_faces.
2014
ff2bc410
SM
20152011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2016
2017 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2018
28177add
PE
20192011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2020
dd3482fe
PE
2021 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2022 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2023 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2024
393d71f3 2025 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2026 * fileio.c (Finsert_file_contents):
2027 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2028 Remove the old (too-loose) buffer overflow checks.
2029 They weren't needed, since make_gap checks for buffer overflow.
2030 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2031 The old code merely checked for Emacs fixnum overflow, and relied
2032 on undefined (wraparound) behavior. The new code avoids undefined
2033 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2034
2e6813b0 2035 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2036 Tune. Don't use wider integers than needed. Don't use alloca.
2037 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2038
599a9e4f
PE
2039 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2040
99561444
PE
2041 * insdel.c, lisp.h (buffer_overflow): New function.
2042 (insert_from_buffer_1, replace_range, replace_range_2):
2043 * insdel.c (make_gap_larger):
2044 * editfns.c (Finsert_char):
2045 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2046
28177add
PE
2047 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2048
e69dafad
PE
20492011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2050
a7af7fde 2051 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2052
b1c46f02
PE
2053 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2054 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2055
e69dafad
PE
2056 * fileio.c: Don't assume EMACS_INT fits in off_t.
2057 (emacs_lseek): New static function.
2058 (Finsert_file_contents, Fwrite_region): Use it.
2059 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2060
566684ea
PE
2061 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2062
e6966cd6
PE
2063 * fns.c: Don't overflow int when computing a list length.
2064 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2065 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2066 truncation on 64-bit hosts. Check for QUIT every
2067 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2068 faster and is responsive enough.
2069 (Flength): Report an error instead of overflowing an integer.
2070 (Fsafe_length): Return a float if the value is not representable
2071 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2072 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2073 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2074
dd0b0efb
PE
2075 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2076 (header_size, word_size): New constants.
2077 (allocate_vectorlike): Don't check size overflow here.
2078 (allocate_vector): Check it here instead, since this is the only
2079 caller of allocate_vectorlike that could cause overflow.
2080 Check that the new vector's length is representable as a fixnum.
2081
86fe5cfe
PE
2082 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2083 The previous code was bogus. For example, next_almost_prime (32)
2084 returned 39, which is undesirable as it is a multiple of 3; and
2085 next_almost_prime (24) returned 25, which is a multiple of 5 so
2086 why was the code bothering to check for multiples of 7?
2087
80e88859
PE
2088 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2089
4a2f0ad6
PE
2090 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2091
f66c7cf8
PE
2092 Variadic C functions now count arguments with ptrdiff_t.
2093 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2094 Back then I didn't know that the Emacs coding style prefers signed int.
2095 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2096 were being counted with int, which may truncate counts on 64-bit
2097 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2098 * lisp.h (struct Lisp_Subr.function.aMANY)
2099 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2100 Arg counts are now ptrdiff_t, not size_t.
2101 All variadic functions and their callers changed accordingly.
2102 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2103 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2104 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2105 * callint.c (Fcall_interactively): Check arg count for overflow,
2106 to avoid potential buffer overrun. Use signed char, not 'int',
2107 for 'varies' array, so that we needn't bother to check its size
2108 calculation for overflow.
2109 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2110 * eval.c (apply_lambda):
2111 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2112 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2113 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2114
a1759b76
PE
2115 * callint.c (Fcall_interactively): Don't use index var as event count.
2116
d96be9fc
PE
2117 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2118 * mem-limits.h (SIZE): Remove; no longer used.
2119
a690a978 2120 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2121
578c21e6
PE
2122 Remove unnecessary casts.
2123 * xterm.c (x_term_init):
2124 * xfns.c (x_set_border_pixel):
2125 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2126 These aren't needed now that we assume ANSI C.
2127
96f53c6c
PE
2128 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2129 It's more likely to cause problems (due to unsigned overflow)
2130 than to cure them.
2131
83c77d31
PE
2132 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2133
ee2079f1
PE
2134 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2135
6da65536
PE
2136 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2137
7147c4a4
PE
2138 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2139
193e32d9
PE
2140 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2141
e5533da6
PE
2142 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2143
9910e595
PE
2144 GLYPH_CODE_FACE returns EMACS_INT, not int.
2145 * dispextern.h (merge_faces):
2146 * xfaces.c (merge_faces):
01103c44
PE
2147 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2148 Don't assume EMACS_INT fits in int.
9910e595 2149
2638320e
PE
2150 * character.h (CHAR_VALID_P): Remove unused parameter.
2151 * fontset.c, lisp.h, xdisp.c: All uses changed.
2152
045eb8d9
PE
2153 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2154
c1f134b5
PE
2155 * fns.c (concat): Minor tuning based on overflow analysis.
2156 This doesn't fix any bugs. Use int to hold character, instead
2157 of constantly refetching from Emacs object. Use XFASTINT, not
2158 XINT, for value known to be a character. Don't bother comparing
2159 a single byte to 0400, as it's always less.
2160
395fcb93 2161 * floatfns.c (Fexpt):
327eeec8
PE
2162 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2163
abbd3d23
PE
2164 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2165 for characters.
2166
684a03ef
PE
2167 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2168
0fed43f3
PE
2169 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2170 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2171 incorrectly succeed when S was a string, because 4294967386 was
2172 truncated before it was used.
2173
8fd02eb7
PE
2174 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2175 Otherwise, an out-of-range integer could cause undefined behavior
2176 on a 64-bit host.
2177
f8c86b69
PE
2178 * composite.c: Use int, not EMACS_INT, for characters.
2179 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2180 EMACS_INT, for values that are known to be in character range.
2181 This doesn't fix any bugs but is the usual style inside Emacs and
2182 may generate better code on 32-bit machines.
2183
34206dd2
PE
2184 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2185 This is for reasons similar to the recent CHAR_STRING fix.
2186 * charset.c (Fencode_char): Check that character arg is actually
2187 a character. Pass an int to ENCODE_CHAR.
2188 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2189 wider than 'int', as a compile-time check to prevent future regressions
2190 in this area.
2191
c5958d4c 2192 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2193
2194 Make sure a 64-bit char is never passed to CHAR_STRING.
2195 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2196 by silently ignoring the top 32 bits, allowing some values
2197 that were far too large to be valid characters.
2198 * character.h: Include <verify.h>.
2199 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2200 arguments are no wider than unsigned, as a compile-time check
2201 to prevent future regressions in this area.
2202 * data.c (Faset):
01103c44 2203 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2204 (Fsubst_char_in_region):
2205 * fns.c (concat):
2206 * xdisp.c (decode_mode_spec_coding):
2207 Adjust to CHAR_STRING's new requirement.
2208 * editfns.c (Finsert_char, Fsubst_char_in_region):
2209 * fns.c (concat): Check that character args are actually
2210 characters. Without this test, these functions did the wrong
2211 thing with wildly out-of-range values on 64-bit hosts.
2212
d37ca623
PE
2213 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2214 These casts should not be needed on 32-bit hosts, either.
2215 * keyboard.c (read_char):
2216 * lread.c (Fload): Remove casts to unsigned.
2217
ea204efb
PE
2218 * lisp.h (UNSIGNED_CMP): New macro.
2219 This fixes comparison bugs on 64-bit hosts.
2220 (ASCII_CHAR_P): Use it.
2221 * casefiddle.c (casify_object):
01103c44 2222 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2223 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2224 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2225 * dispextern.h (FACE_FROM_ID):
2226 * keyboard.c (read_char): Use UNSIGNED_CMP.
2227
41cb286c
PE
2228 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2229 not to EMACS_INT, to avoid GCC warning.
2230
4a1b9832
PE
2231 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2232
55daad71
PE
2233 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2234 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2235 isn't needed on 32-bit machines.
8f95c75c 2236
01103c44
PE
2237 * buffer.c (Fgenerate_new_buffer_name):
2238 Use EMACS_INT for count, not int.
0ceccced 2239 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2240
2241 * data.c (Qcompiled_function): Now static.
2242
c6f072e7
PE
2243 * window.c (window_body_lines): Now static.
2244
20ce5912
PE
2245 * image.c (gif_load): Rename local to avoid shadowing.
2246
9c4c5f81
PE
2247 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2248 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2249 * alloc.c (make_save_value): Integer argument is now of type
2250 ptrdiff_t, not int.
2251 (mark_object): Use ptrdiff_t, not int.
2252 * lisp.h (pD): New macro.
2253 * print.c (print_object): Use it.
2254
c0c5c8ae
PE
2255 * alloc.c: Use EMACS_INT, not int, to count objects.
2256 (total_conses, total_markers, total_symbols, total_vector_size)
2257 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2258 (total_free_floats, total_floats, total_free_intervals)
2259 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2260 Now EMACS_INT, not int. All uses changed.
2261 (Fgarbage_collect): Compute overall total using a double, so that
2262 integer overflow is less likely to be a problem. Check for overflow
2263 when converting back to an integer.
5a25e253
PE
2264 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2265 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2266 These were 'int' variables that could overflow on 64-bit hosts;
2267 they were never used, so remove them instead of repairing them.
211a0b2a 2268 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2269 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2270 Previously, this ceilinged at INT_MAX, but that doesn't work on
2271 64-bit machines.
e46bb31a 2272 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2273
c78baabf 2274 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2275 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2276 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2277 when a (possibly-narrower) signed value would do just as well.
2278 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2279
c9d624c6
PE
2280 * alloc.c: Catch some string size overflows that we were missing.
2281 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2282 for convenience in STRING_BYTES_MAX.
2283 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2284 The definition here is exact; the one in lisp.h was approximate.
2285 (allocate_string_data): Check for string overflow. This catches
2286 some instances we weren't catching before. Also, it catches
2287 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2288 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2289 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2290
c9d624c6
PE
2291 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2292 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2293 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2294
353032ce
PE
2295 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2296
2bccce07
PE
2297 * alloc.c (Fmake_string): Check for out-of-range init.
2298
0ac30604
SM
22992011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2300
2301 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2302
c195f2de
JD
23032011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2304
2305 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2306 xg_get_default_scrollbar_width.
2307
2308 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2309 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2310 (style_changed_cb): Call update_theme_scrollbar_width and call
2311 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2312 all frames (Bug#8505).
2313 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2314 Call gtk_window_set_resizable if HAVE_GTK3.
2315 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2316 and height if HAVE_GTK3 (Bug#8505).
2317 (scroll_bar_width_for_theme): New variable.
2318 (update_theme_scrollbar_width): New function.
2319 (xg_get_default_scrollbar_width): Move code to
2320 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2321 (xg_initialize): Call update_theme_scrollbar_width.
2322
2323 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2324
2325 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2326
e10ac9f1
MR
23272011-06-12 Martin Rudalics <rudalics@gmx.at>
2328
2329 * frame.c (make_frame): Call other_buffer_safely instead of
2330 other_buffer.
2331
2332 * window.c (temp_output_buffer_show): Call display_buffer with
2333 second argument Vtemp_buffer_show_specifiers and reset latter
2334 immediately after the call.
2335 (Vtemp_buffer_show_specifiers): New variable.
2336 (auto_window_vscroll_p, next_screen_context_lines)
2337 (Vscroll_preserve_screen_position): Remove leading asterisks from
2338 doc-strings.
2339
2d3c217e 23402011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2341
7b7f97e8 2342 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2343 * buffer.c (Qclone_number): Remove for now, as it's unused.
2344 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2345 (record_buffer): Remove unused local.
2346 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2347 (set_frame_buffer_list): Remove; unused.
2348 * frame.h (other_visible_frames): Remove decl.
2349 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2350 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2351 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2352 if HAVE_GPM.
2353 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2354 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2355 Define only if HAVE_GPM.
2356 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2357 (update_hints_inhibit): Remove; never set. All uses removed.
2358 * widgetprv.h (emacsFrameClassRec): Remove decl.
2359 * window.c (delete_deletable_window): Now returns void, since it
2360 wasn't returning anything.
2361 (compare_window_configurations): Remove unused locals.
2362 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2363 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2364 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2365 the same widths as pointers. This follows up on the 2011-05-06 patch.
2366 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2367 * xterm.h: Likewise.
2368 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2369
1384b89e
JB
23702011-06-12 Juanma Barranquero <lekktu@gmail.com>
2371
2372 * makefile.w32-in: Update dependencies.
2373 (LISP_H): Add lib/intprops.h.
2374
1100a63c
CY
23752011-06-11 Chong Yidong <cyd@stupidchicken.com>
2376
2377 * image.c (gif_load): Add animation frame delay to the metadata.
2378 (syms_of_image): Use DEFSYM. New symbol `delay'.
2379
6198ccd0
MR
23802011-06-11 Martin Rudalics <rudalics@gmx.at>
2381
2382 * window.c (delete_deletable_window): Re-add.
2383 (Fset_window_configuration): Rewrite to handle dead buffers and
2384 consequently deletable windows.
2385 (window_tree, Fwindow_tree): Remove. Supply functionality in
2386 window.el.
2387 (compare_window_configurations): Simplify code.
2388
b6e3633c
AS
23892011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2390
1ab0dee5
AS
2391 * image.c (imagemagick_load_image): Fix type mismatch.
2392 (Fimagemagick_types): Likewise.
2393
b6e3633c
AS
2394 * window.h (replace_buffer_in_windows): Declare.
2395
9397e56f
MR
23962011-06-11 Martin Rudalics <rudalics@gmx.at>
2397
2398 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2399 Qclone_number. Remove external declaration of Qdelete_window.
2400 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2401 code.
640c8776
SM
2402 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2403 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2404 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2405 buffer list implementation.
2406 (other_buffer_safely): New function.
2407 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2408 calls to replace_buffer_in_windows and
2409 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2410 if allowed.
2411 (record_buffer): Inhibit quitting and rewrite using quittable
2412 functions. Run Qbuffer_list_update_hook if allowed.
2413 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2414 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2415 Move switch-to-buffer to window.el.
9397e56f
MR
2416 (bury-buffer): Move to window.el.
2417 (Vbuffer_list_update_hook): New variable.
2418
2419 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2420 section.
2421
2422 * window.h (resize_frame_windows): Move up in code.
2423 (Fwindow_frame): Remove EXFUN.
2424 (replace_buffer_in_all_windows): Remove prototype.
2425 (replace_buffer_in_windows_safely): Add prototype.
2426
2427 * window.c: Declare Qdelete_window static again. Move down
2428 declaration of select_count.
2429 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2430 (Fother_window): Move to window.el.
2431 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2432 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2433 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2434 window.el.
2435 (replace_buffer_in_windows): Implement by calling
2436 Qreplace_buffer_in_windows.
2437 (replace_buffer_in_all_windows): Remove with some functionality
2438 moved into replace_buffer_in_windows_safely.
2439 (replace_buffer_in_windows_safely): New function.
2440 (select_window_norecord, select_frame_norecord): Move in front
2441 of run_window_configuration_change_hook. Remove now obsolete
2442 declarations.
640c8776
SM
2443 (Fset_window_buffer): Rewrite doc-string.
2444 Call Qrecord_window_buffer.
9397e56f
MR
2445 (keys_of_window): Move binding for other-window to window.el.
2446
b50691aa
CY
24472011-06-11 Chong Yidong <cyd@stupidchicken.com>
2448
2449 * dispextern.h (struct image): Replace data member, whose int_val
2450 and ptr_val fields were not used by anything, with a single
2451 lisp_val object.
2452
2453 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2454 (gif_clear_image, gif_load, imagemagick_load_image)
2455 (gs_clear_image, gs_load): Callers changed.
2456
3f754b86
PE
24572011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2458
cca69397
PE
2459 * buffer.h: Include <time.h>, for time_t.
2460 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2461
109e28d0
PE
2462 Fix minor problems found by static checking.
2463
60737f02
PE
2464 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2465
4b66faf3
PE
2466 Make identifiers static if they are not used in other modules.
2467 * data.c (Qcompiled_function, Qframe, Qvector):
2468 * image.c (QimageMagick, Qsvg):
2469 * minibuf.c (Qmetadata):
2470 * window.c (resize_window_check, resize_root_window): Now static.
2471 * window.h (resize_window_check, resize_root_window): Remove decls.
2472
109e28d0
PE
2473 * window.c (window_deletion_count, delete_deletable_window):
2474 Remove; unused.
46a4ce9e
PE
2475 (window_body_lines): Now static.
2476 (Fdelete_other_windows_internal): Mark vars as initialized.
2477 Make sure 'resize_failed' is initialized.
2478 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2479 (resize_window_apply): Remove unused local.
2480 * window.h (delete_deletable_window): Remove decl.
2481
109e28d0 2482 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2483 (imagemagick_load_image): Fix pointer signedness problem by changing
2484 last arg from unsigned char * to char *. All uses changed.
2485 Also, fix a local for similar reasons.
2486 Remove unused locals. Remove locals to avoid shadowing.
2487 (fn_rsvg_handle_free): Remove; unused.
2488 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2489 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2490
3f754b86
PE
2491 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2492
2547adb1
CY
24932011-06-10 Chong Yidong <cyd@stupidchicken.com>
2494
2495 * image.c (gif_load): Fix omitted cast error introduced by
2496 2011-06-06 change.
2497
2c8e37d4
MR
24982011-06-10 Martin Rudalics <rudalics@gmx.at>
2499
2500 * window.h (resize_proportionally, orig_total_lines)
2501 (orig_top_line): Remove from window structure.
2502 (set_window_height, set_window_width, change_window_heights)
2503 (Fdelete_window): Remove prototypes.
2504 (resize_frame_windows): Remove duplicate declaration.
2505
440a42e3
EZ
25062011-06-10 Eli Zaretskii <eliz@gnu.org>
2507
2508 * window.h (resize_frame_windows, resize_window_check)
2509 (delete_deletable_window, resize_root_window)
2510 (resize_frame_windows): Declare prototypes.
2511
2512 * window.c (resize_window_apply): Make definition be "static" to
2513 match the prototype.
2514
562dd5e9
MR
25152011-06-10 Martin Rudalics <rudalics@gmx.at>
2516
2517 * window.c: Remove declarations of Qwindow_size_fixed,
2518 window_min_size_1, window_min_size_2, window_min_size,
2519 size_window, window_fixed_size_p, enlarge_window, delete_window.
2520 Remove static from declaration of Qdelete_window, it's
2521 temporarily needed by Fbury_buffer.
2522 (replace_window): Don't assign orig_top_line and
2523 orig_total_lines.
2524 (Fdelete_window, delete_window): Remove. Window deletion is
2525 handled by window.el.
640c8776
SM
2526 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2527 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2528 (Fdelete_other_windows): Remove. Deleting other windows is
2529 handled by window.el.
2530 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2531 handled in window.el.
2532 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2533 Window minimum sizes are handled in window.el.
2534 (shrink_windows, size_window, set_window_height)
2535 (set_window_width, change_window_heights, window_height)
2536 (window_width, CURBEG, CURSIZE, enlarge_window)
2537 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2538 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2539 handled in window.el.
2540 (make_dummy_parent): Rename to make_parent_window and give it a
2541 second argument horflag.
2542 (make_window): Don't set resize_proportionally any more.
2543 (Fsplit_window): Remove. Windows are split in window.el.
2544 (save_restore_action, save_restore_orig_size)
2545 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2546 Resize mini windows in window.el.
2547 (grow_mini_window, shrink_mini_window): Implement by calling
2548 Qresize_root_window_vertically, resize_window_check and
2549 resize_window_apply.
640c8776
SM
2550 (saved_window, Fset_window_configuration, save_window_save):
2551 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2552 resize_proportionally.
2553 (window_min_height, window_min_width): Move to window.el.
2554 (keys_of_window): Move bindings for delete-other-windows,
2555 split-window, delete-window and enlarge-window to window.el.
2556
2557 * buffer.c: Temporarily extern Qdelete_window.
2558 (Fbury_buffer): Temporarily call Qdelete_window instead of
2559 Fdelete_window (Fbury_buffer will move to window.el soon).
2560
2561 * frame.c (set_menu_bar_lines_1): Remove code handling
2562 orig_top_line and orig_total_lines.
2563
2564 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2565 set_window_height but set heights directly.
2566 (change_frame_size_1): Use resize_frame_windows.
2567
2568 * xdisp.c (init_xdisp): Don't use set_window_height but set
2569 heights directly.
2570
640c8776
SM
2571 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2572 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2573 run_window_configuration_change_hook.
2574
2575 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2576 instead of change_window_heights and run
2577 run_window_configuration_change_hook.
2578
1a13852e
MR
25792011-06-09 Martin Rudalics <rudalics@gmx.at>
2580
2581 * window.c (replace_window): Rename second argument REPLACEMENT to
2582 NEW. New third argument SETFLAG. Rewrite.
2583 (delete_window, make_dummy_parent): Call replace_window with
2584 third argument 1.
2585 (window_list_1): Move down in code.
2586 (run_window_configuration_change_hook): Move set_buffer part
2587 before select_frame_norecord part in order to unwind correctly.
2588 Rename count1 to count.
2589 (recombine_windows, delete_deletable_window, resize_root_window)
2590 (Fdelete_other_windows_internal)
2591 (Frun_window_configuration_change_hook, make_parent_window)
2592 (resize_window_check, resize_window_apply, Fresize_window_apply)
2593 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2594 (Fdelete_window_internal, Fresize_mini_window_internal):
2595 New functions.
1a13852e
MR
2596 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2597
f3d1777e
MR
25982011-06-08 Martin Rudalics <rudalics@gmx.at>
2599
496e208e
MR
2600 * window.h (window): Add some new members to window structure -
2601 normal_lines, normal_cols, new_total, new_normal, clone_number,
2602 splits, nest, prev_buffers, next_buffers.
2603 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2604 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2605
f3d1777e
MR
2606 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2607 Remove.
496e208e
MR
2608 (make_dummy_parent): Set new members of windows structure.
2609 (make_window): Move down in code. Handle new members of window
2610 structure.
2611 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2612 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2613 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2614 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2615 (Fset_window_next_buffers, Fset_window_clone_number):
2616 New functions.
496e208e
MR
2617 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2618 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2619 Doc-string fixes.
2620 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2621 Argument WINDOW can be now internal window too.
2622 (Fwindow_use_time): Move up in code.
2623 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2624 Rewrite doc-string.
2625 (Fset_window_configuration, saved_window)
2626 (Fcurrent_window_configuration, save_window_save): Handle new
2627 members of window structure.
b9e809c2
MR
2628 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2629 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2630 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2631 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2632 Qget_mru_window, Qresize_root_window,
2633 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2634 Qauto_buffer_name; staticpro them.
f3d1777e 2635
abde8f8c
MR
26362011-06-07 Martin Rudalics <rudalics@gmx.at>
2637
2638 * window.c (Fwindow_total_size, Fwindow_left_column)
2639 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2640 (Fwindow_list_1): New functions.
2641 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2642 (Fwindow_width, Fscroll_left, Fscroll_right):
2643 Use window_body_cols instead of window_box_text_cols.
2644 (delete_window, Fset_window_configuration):
2645 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2646 (delete_all_subwindows): Take a window as argument and not a
2647 structure. Rewrite.
190b47e6
MR
2648 (window_loop): Remove handling of GET_LRU_WINDOW and
2649 GET_LARGEST_WINDOW.
2650 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2651
2652 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2653 window_box_text_cols. delete_all_subwindows now takes a
2654 Lisp_Object as argument.
abde8f8c 2655
640c8776
SM
2656 * indent.c (compute_motion, Fcompute_motion):
2657 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2658
fa8a67e6
MR
2659 * frame.c (delete_frame): Call delete_all_subwindows with root
2660 window as argument.
2661
a54e3482
DC
26622011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2663
2664 * fns.c (Fputhash): Document return value.
2665
60002bf5
CY
26662011-06-06 Chong Yidong <cyd@stupidchicken.com>
2667
2668 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2669
0c671da6 26702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2671
b862a52a 2672 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2673
be44ca6c
PE
2674 Check for overflow when converting integer to cons and back.
2675 * charset.c (Fdefine_charset_internal, Fdecode_char):
2676 Use cons_to_unsigned to catch overflow.
2677 (Fencode_char): Use INTEGER_TO_CONS.
2678 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2679 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2680 * data.c (long_to_cons, cons_to_long): Remove.
2681 (cons_to_unsigned, cons_to_signed): New functions.
2682 These signal an error for invalid or out-of-range values.
2683 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2684 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2685 * font.c (Ffont_variation_glyphs):
2686 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2687 * lisp.h: Include <intprops.h>.
2688 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2689 (cons_to_signed, cons_to_unsigned): New decls.
2690 (long_to_cons, cons_to_long): Remove decls.
2691 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2692 (Fprimitive_undo): Use CONS_TO_INTEGER.
2693 * xfns.c (Fx_window_property): Likewise.
2694 * xselect.c: Include <limits.h>.
2695 (x_own_selection, selection_data_to_lisp_data):
2696 Use INTEGER_TO_CONS.
2697 (x_handle_selection_request, x_handle_selection_clear)
2698 (x_get_foreign_selection, Fx_disown_selection_internal)
2699 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2700 (lisp_data_to_selection_data): Use cons_to_unsigned.
2701 (x_fill_property_data): Use cons_to_signed.
2702 Report values out of range.
2703
d1f3d2af
PE
2704 Check for buffer and string overflow more precisely.
2705 * buffer.h (BUF_BYTES_MAX): New macro.
2706 * lisp.h (STRING_BYTES_MAX): New macro.
2707 * alloc.c (Fmake_string):
2708 * character.c (string_escape_byte8):
2709 * coding.c (coding_alloc_by_realloc):
2710 * doprnt.c (doprnt):
2711 * editfns.c (Fformat):
2712 * eval.c (verror):
2713 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2714 since they may not be the same number.
2715 * editfns.c (Finsert_char):
2716 * fileio.c (Finsert_file_contents):
2717 Likewise for BUF_BYTES_MAX.
2718
dd52fcea
PE
2719 * image.c: Use ptrdiff_t, not int, for sizes.
2720 (slurp_file): Switch from int to ptrdiff_t.
2721 All uses changed.
2722 (slurp_file): Check that file size fits in both size_t (for
2723 malloc) and ptrdiff_t (for sanity and safety).
2724
7f9bbdbb
PE
2725 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2726 if b->modtime has its maximal value.
2727
dfe18f82
PE
2728 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2729
84acfcf0
PE
2730 Don't assume time_t can fit into int.
2731 * buffer.h (struct buffer.modtime): Now time_t, not int.
2732 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2733 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2734
ccd9a01a
PE
2735 Minor fixes for signed vs unsigned integers.
2736 * character.h (MAYBE_UNIFY_CHAR):
2737 * charset.c (maybe_unify_char):
2738 * keyboard.c (read_char, reorder_modifiers):
2739 XINT -> XFASTINT, since the integer must be nonnegative.
2740 * ftfont.c (ftfont_spec_pattern):
2741 * keymap.c (access_keymap, silly_event_symbol_error):
2742 XUINT -> XFASTINT, since the integer must be nonnegative.
2743 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2744 since it makes no difference and we prefer signed.
2745 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2746 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2747 nonnegative.
2748
d6d100dd
SM
27492011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2750
2751 * window.h (Fwindow_frame): Declare.
2752
2b6148e4
PE
27532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2754
2755 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2756 (SPARE_MEMORY): Always define.
2757 (LARGE_REQUEST): Remove.
2758 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2759
f230ecc9
MR
27602011-06-06 Martin Rudalics <rudalics@gmx.at>
2761
727e958e
MR
2762 * lisp.h: Move EXFUNS for Fframe_root_window,
2763 Fframe_first_window and Fset_frame_selected_window to window.h.
2764
2765 * window.h: Move EXFUNS for Fframe_root_window,
2766 Fframe_first_window and Fset_frame_selected_window here from
2767 lisp.h.
2768
2769 * frame.c (Fwindow_frame, Fframe_first_window)
2770 (Fframe_root_window, Fframe_selected_window)
2771 (Fset_frame_selected_window): Move to window.c.
2772 (Factive_minibuffer_window): Move to minibuf.c.
2773 (Fother_visible_frames_p): New function.
2774
2775 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2776
f230ecc9
MR
2777 * window.c (decode_window, decode_any_window): Move up in code.
2778 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2779 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2780 (Fwindow_buffer): Move up and rewrite doc-string.
2781 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2782 (Fwindow_prev): New functions.
727e958e
MR
2783 (Fwindow_frame): Move here from frame.c. Accept any window as
2784 argument.
2785 (Fframe_root_window, Fframe_first_window)
2786 (Fframe_selected_window): Move here from frame.c. Accept frame
2787 or arbitrary window as argument. Update doc-strings.
2788 (Fminibuffer_window): Move up in code.
2789 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2790 (Fset_frame_selected_window): Move here from frame.c.
2791 Marginal rewrite.
727e958e
MR
2792 (Fselected_window, select_window, Fselect_window): Move up in
2793 code. Minor doc-string fixes.
f230ecc9 2794
4d09bcf6
PE
27952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2796
2797 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2798 Do not assume that spare memory exists; that assumption is valid
2799 only if SYSTEM_MALLOC.
2800 (LARGE_REQUEST): New macro, so that the issue of large requests
2801 is separated from the issue of spare memory.
2802
810928a2
AS
28032011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2804
172418ad
AS
2805 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2806 format. (Bug#8806)
2807
43f862f7
AS
2808 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2809
810928a2
AS
2810 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2811 before statements.
2812
a059fe24
JD
28132011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2814
2815 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2816
2817 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2818
2819 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2820 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2821
989bf368
JB
28222011-06-05 Juanma Barranquero <lekktu@gmail.com>
2823
2824 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2825
4b80f674
CY
28262011-06-04 Chong Yidong <cyd@stupidchicken.com>
2827
2828 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2829 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2830 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2831 New error handlers.
4b80f674
CY
2832 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2833 Obey Vx_select_enable_clipboard_manager. Catch errors in
2834 x_clipboard_manager_save (Bug#8779).
2835 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2836 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2837
99a33b77 28382011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2839
2840 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2841
99a33b77 28422011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2843
2844 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2845 in the current matrix if keep_current_p is non-zero.
2846
8264569d
EZ
28472011-06-04 Eli Zaretskii <eliz@gnu.org>
2848
2849 * bidi.c (bidi_level_of_next_char): Fix last change.
2850
57f97249
EZ
28512011-06-03 Eli Zaretskii <eliz@gnu.org>
2852
fec2107c 2853 Support bidi reordering of text covered by display properties.
57f97249 2854
fec2107c
EZ
2855 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2856 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2857 (bidi_cache_search, bidi_cache_iterator_state)
2858 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2859 (bidi_level_of_next_char, bidi_move_to_visually_next):
2860 Support character positions inside a run of characters covered by a
fec2107c
EZ
2861 display string.
2862 (bidi_paragraph_init, bidi_resolve_explicit_1)
2863 (bidi_level_of_next_char): Call bidi_fetch_char and
2864 bidi_fetch_char_advance instead of FETCH_CHAR and
2865 FETCH_CHAR_ADVANCE.
2866 (bidi_init_it): Initialize new members.
2867 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2868 definitions.
2869 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2870 instead of using explicit *_CHAR codes.
d6d100dd
SM
2871 (bidi_resolve_explicit, bidi_resolve_weak):
2872 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2873 bidirectional text is supported only in multibyte buffers.
2874 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2875 it to initialize the frame_window_p member of struct bidi_it.
2876 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2877 (bidi_resolve_explicit, bidi_resolve_weak)
2878 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2879 bidi_it->nchars is non-positive.
2880 (bidi_level_of_next_char): Don't try to lookup the cache for the
2881 next/previous character if nothing is cached there yet, or if we
2882 were just reseat()'ed to a new position.
c40e2fb2 2883
0e14fe90
EZ
2884 * xdisp.c (set_cursor_from_row): Set start and stop points
2885 according to the row's direction when priming the loop that looks
2886 for the glyph on which to display cursor.
2887 (single_display_spec_intangible_p): Function deleted.
2888 (display_prop_intangible_p): Reimplement to call
2889 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2890 Accept 3 additional arguments needed by handle_display_spec.
2891 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2892 values: lists, `(when COND...)' forms, etc.
2893 (single_display_spec_string_p): Support property values that are
2894 lists with the argument STRING its top-level element.
2895 (display_prop_string_p): Fix the condition for processing a
2896 property that is a list to be consistent with handle_display_spec.
fec2107c 2897 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2898 last portion of handle_display_prop.
2899 (compute_display_string_pos): Accept additional argument
2900 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2901 value of a `display' property is a "replacing spec".
2902 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2903 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2904 the display property, but just return a value indicating whether
2905 the display property will replace the characters it covers.
2906 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2907 frame_window_p members of struct bidi_it.
d6d100dd
SM
2908 (compute_display_string_pos, compute_display_string_end):
2909 New functions.
fec2107c
EZ
2910 (push_it): Accept second argument POSITION, where pop_it should
2911 jump to continue iteration.
2912 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2913
fec2107c
EZ
2914 * keyboard.c (adjust_point_for_property): Adjust the call to
2915 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2916
2917 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2918 (bidi_init_it): Update prototypes.
2919 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2920 (compute_display_string_pos, compute_display_string_end):
2921 Declare prototypes.
fec2107c
EZ
2922 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2923 EMACS_INT.
fc6f18ce 2924
40087514 29252011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2926
57f53182
PE
2927 Malloc failure behavior now depends on size of allocation.
2928 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2929 * lisp.h: Change signatures accordingly.
2930 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2931 All callers changed. (Bug#8762)
2932
2933 * gnutls.c: Use Emacs's memory allocators.
2934 Without this change, the gnutls library would invoke malloc etc.
2935 directly, which causes problems on non-SYNC_INPUT hosts, and which
2936 runs afoul of improving memory_full behavior. (Bug#8761)
2937 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2938 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2939 xfree instead of the default malloc, realloc, free.
2940 (Fgnutls_boot): No need to check for memory allocation failure,
2941 since xmalloc does that for us.
2942
ac32cd99 2943 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2944 * category.c (hash_get_category_set):
2945 * ccl.c (ccl_driver):
2946 * charset.c (Fdefine_charset_internal):
2947 * charset.h (struct charset.hash_index):
2948 * composite.c (get_composition_id, gstring_lookup_cache)
2949 (composition_gstring_put_cache):
2950 * composite.h (struct composition.hash_index):
2951 * dispextern.h (struct image.hash):
2952 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2953 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2954 (hashfn_equal, hashfn_user_defined, make_hash_table)
2955 (maybe_resize_hash_table, hash_lookup, hash_put)
2956 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2957 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2958 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2959 * image.c (make_image, search_image_cache, lookup_image)
2960 (xpm_put_color_table_h):
2961 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2962 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2963 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2964 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2965 * alloc.c (allocate_vectorlike):
2966 Check for overflow in vector size calculations.
2967 * ccl.c (ccl_driver):
2968 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2969 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2970 need to be updated by these changes.
40087514
PE
2971 * fns.c (make_hash_table, maybe_resize_hash_table):
2972 Check for integer overflow with large hash tables.
0de4bb68
PE
2973 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2974 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2975 (SXHASH_REDUCE): New macro.
2976 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2977 Use it instead of discarding useful hash info with large hash values.
2978 (sxhash_float): New function.
2979 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2980 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2981 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2982 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2983 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2984 Adjust signatures to match updated version of code.
2985 (consing_since_gc): Now EMACS_INT, since a single hash table can
2986 use more than INT_MAX bytes.
2987
698d32e2
DN
29882011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2989
2990 Make it possible to build with GCC-4.6+ -O2 -flto.
2991
2992 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2993
fd6fa53f
SM
29942011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2995
2996 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2997 Call minibuffer-inactive-mode.
2998
864db017
JB
29992011-05-31 Juanma Barranquero <lekktu@gmail.com>
3000
3001 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3002 Update dependencies.
3003
2ad0baf4
DN
30042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3005
3006 * data.c (init_data): Remove code for UTS, this system is not
3007 supported anymore.
3008
4fcc2638
DN
30092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3010
3011 Don't force ./temacs to start in terminal mode.
3012
3013 * frame.c (make_initial_frame): Initialize faces in all cases, not
3014 only when CANNOT_DUMP is defined.
3015 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3016
c56e0fd5
DN
30172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3018
3019 * dispnew.c (add_window_display_history): Use const for the string
3020 pointer. Remove declaration, not needed.
3021
333d54da 30222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3023
55d4c1b2 3024 Use 'inline', not 'INLINE'.
333d54da 3025 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3026 * alloc.c, fontset.c (INLINE): Remove.
3027 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3028 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3029 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3030 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3031 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3032
738db178
DN
30332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3034
3035 Make it possible to run ./temacs.
3036
3037 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3038 syms_of_callproc does the same thing. Remove test for
3039 "initialized", do it in the caller.
3040 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3041
620c53a6
SM
30422011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3043
3044 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3045 (read_minibuf): Use get_minibuffer.
3046 (syms_of_minibuf): Use DEFSYM.
3047 (Qmetadata): New var.
3048 * data.c (Qbuffer): Don't make it static.
3049 (syms_of_data): Use DEFSYM.
3050
e003a292
PE
30512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3052
3053 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3054 (CCL_CODE_MIN): New macro.
3055
ed008a6d
PE
30562011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3057
3687c2ef
PE
3058 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3059
ed008a6d
PE
3060 * eval.c (Qdebug): Now static.
3061 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3062 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3063 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3064
d66c4c7c
CY
30652011-05-29 Chong Yidong <cyd@stupidchicken.com>
3066
3067 * image.c: Various fixes to ImageMagick code comments.
3068 (Fimagemagick_types): Doc fix.
3069
5fbc2025
PE
30702011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3071
0196f88a
PE
3072 Minor fixes prompted by GCC 4.6.0 warnings.
3073
3074 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3075
5fbc2025
PE
3076 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3077 (x_clipboard_manager_save_all): Move extern decl to ...
3078 * xterm.h: ... here, so that it can be checked for consistency.
3079
1dd3c2d9
CY
30802011-05-29 Chong Yidong <cyd@stupidchicken.com>
3081
3082 * xselect.c (x_clipboard_manager_save_frame)
3083 (x_clipboard_manager_save_all): New functions.
3084 (Fx_clipboard_manager_save): Lisp function deleted.
3085
3086 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3087 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3088
3089 * xterm.h: Update prototype.
3090
5ba6571d
WX
30912011-05-28 William Xu <william.xwl@gmail.com>
3092
3093 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3094 exiting (Bug#8239).
3095
3eaff834
JM
30962011-05-28 Jim Meyering <meyering@redhat.com>
3097
e1900994 3098 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3099 * fns.c (to_uchar): Define.
3100 (crypto_hash_function): Use it to convert some newly-signed
3101 variables to unsigned, to avoid sign-extension bugs. For example,
3102 without this change, (md5 "truc") would evaluate to
3103 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3104 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3105 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3106
0f6990a7
PE
31072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3108
3109 Integer overflow fixes.
c8a9ca5a 3110
08686060
PE
3111 * dbusbind.c: Serial number integer overflow fixes.
3112 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3113 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3114 to hold a serial number that is too large for a fixnum.
3115 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3116 Check for serial numbers out of range. Decode any serial number
59568bf0 3117 that was so large that it became a float. (Bug#8722)
08686060 3118
2d1fc3c7
PE
3119 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3120 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3121 Use XFASTINT rather than XUINT when numbers are nonnegative.
3122 (xd_append_arg, Fdbus_method_return_internal):
3123 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3124 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3125 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3126 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3127 (Bug#8722)
2d1fc3c7 3128
c8a9ca5a
PE
3129 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3130
519e1d69
PE
3131 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3132
30569699
PE
3133 ccl: add integer overflow checks
3134 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3135 (IN_INT_RANGE): New macros.
3136 (ccl_driver): Use them to check for integer overflow when
3137 decoding a CCL program. Many of the new checks are whether XINT (x)
3138 fits in int; it doesn't always, on 64-bit hosts. The new version
3139 doesn't catch all possible integer overflows, but it's an
847044ea 3140 improvement. (Bug#8719)
30569699 3141
c11285dc
PE
3142 * alloc.c (make_event_array): Use XINT, not XUINT.
3143 There's no need for unsigned here.
3144
fdccd48e
PE
3145 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3146 This follows up to the 2011-05-06 change that substituted uintptr_t
3147 for EMACS_INT. This case wasn't caught back then.
3148
37910ab2
PE
3149 Rework Fformat to avoid integer overflow issues.
3150 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3151 now (part of C89). Include <verify.h>.
3152 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3153 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3154 (Fformat): Avoid the prepass trying to compute sizes; it was only
3155 approximate and thus did not catch overflow reliably. Instead, walk
3156 through the format just once, formatting and computing sizes as we go,
3157 checking for integer overflow at every step, and allocating a larger
3158 buffer as needed. Keep track separately whether the format is
3159 multibyte. Keep only the most-recently calculated precision, rather
3160 than them all. Record whether each argument has been converted to
3161 string. Use EMACS_INT, not int, for byte and char and arg counts.
3162 Support field widths and precisions larger than INT_MAX. Avoid
3163 sprintf's undefined behavior with conversion specifications such as %#d
3164 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3165 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3166 formatting out-of-range floating point numbers with int
9173deec 3167 formats. (Bug#8668)
37910ab2 3168
2e6578fb
PE
3169 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3170
0ae6bdee
PE
3171 * data.c: Avoid integer truncation in expressions involving floats.
3172 * data.c: Include <intprops.h>.
3173 (arith_driver): When there's an integer overflow in an expression
3174 involving floating point, convert the integers to floating point
3175 so that the resulting value does not suffer from catastrophic
3176 integer truncation. For example, on a 64-bit host (* 4
3177 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3178 Do not rely on undefined behavior after integer overflow.
3179
de883a70
PE
3180 merge count_size_as_multibyte, parse_str_to_multibyte
3181 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3182 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3183 Check for integer overflow.
3184 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3185 since it's now a duplicate of the other. This is more of
3186 a character than a buffer op, so better that it's in character.c.
3187 * fns.c, print.c: Adjust to above changes.
3188
2ff916cb
PE
31892011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3190
3191 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3192
f1b54466
PE
31932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3194
fb1ac845
PE
3195 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3196 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3197 (x_clipboard_manager_save): Now static.
3198 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3199
f1b54466
PE
3200 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3201 (crypto_hash_function): Now static.
3202 Fix pointer signedness problems. Avoid unnecessary initializations.
3203
a9f737ee
CY
32042011-05-27 Chong Yidong <cyd@stupidchicken.com>
3205
3206 * termhooks.h (Vselection_alist): Make it terminal-local.
3207
3208 * terminal.c (create_terminal): Initialize it.
3209
3210 * xselect.c: Support for clipboard managers.
3211 (Vselection_alist): Move to termhooks.h as terminal-local var.
3212 (LOCAL_SELECTION): New macro.
3213 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3214 (symbol_to_x_atom): Remove gratuitous arg.
3215 (x_handle_selection_request, lisp_data_to_selection_data)
3216 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3217 (x_own_selection, x_get_local_selection, x_convert_selection):
3218 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3219 (some_frame_on_display): Delete unused function.
3220 (Fx_own_selection_internal, Fx_get_selection_internal)
3221 (Fx_disown_selection_internal, Fx_selection_owner_p)
3222 (Fx_selection_exists_p): New optional frame arg.
3223 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3224 (x_handle_selection_clear): Don't treat other terminals with the
3225 same keyboard specially. Use the terminal-local Vselection_alist.
3226 (x_clear_frame_selections): Use Frun_hook_with_args.
3227
3228 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3229
3230 * xterm.h: Add support for those atoms.
3231
e067f0c1
CY
32322011-05-26 Chong Yidong <cyd@stupidchicken.com>
3233
3234 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3235 (converted_selections, conversion_fail_tag): New global variables.
3236 (x_selection_request_lisp_error): Free the above.
3237 (x_get_local_selection): Remove unnecessary code.
3238 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3239 of converted selections stored in converted_selections.
3240 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3241 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3242 (x_convert_selection): New function.
3243 (x_handle_selection_event): Simplify.
3244 (x_get_foreign_selection): Don't ignore incoming requests while
3245 waiting for an answer; this will fail when we implement
3246 SAVE_TARGETS, and seems unnecessary anyway.
3247 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3248 (Vx_sent_selection_functions): Doc fix.
3249
0f4aebc0
LL
32502011-05-26 Leo Liu <sdl.web@gmail.com>
3251
3252 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3253
e61124cd
YM
32542011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3255
3256 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3257
3258 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3259 for fringe update if it has periodic bitmap.
ac389d0c 3260 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3261 and fringe_bitmap_periodic_p.
3262
3263 * fringe.c (get_fringe_bitmap_data): New function.
3264 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3265 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3266 row. Mark glyph row for fringe update if periodicity changed.
3267
3268 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3269 for fringe update unless it has periodic bitmap.
3270
f16d9837
KH
32712011-05-25 Kenichi Handa <handa@m17n.org>
3272
3273 * xdisp.c (get_next_display_element): Set correct it->face_id for
3274 a static composition.
3275
e1b90ef6
LL
32762011-05-24 Leo Liu <sdl.web@gmail.com>
3277
3278 * deps.mk (fns.o):
3279 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3280
3281 * fns.c (crypto_hash_function, Fsha1): New function.
3282 (Fmd5): Use crypto_hash_function.
3283 (syms_of_fns): Add Ssha1.
3284
7400048f
PE
32852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3286
3287 * gnutls.c: Remove unused macros.
3288 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3289 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3290 Remove macros that are defined and never used.
3291 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3292
abb71cf4
CY
32932011-05-22 Chong Yidong <cyd@stupidchicken.com>
3294
3295 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3296 (Fx_get_selection_internal): Minor cleanup.
3297 (Fx_own_selection_internal): Rename arguments for consistency with
3298 select.el.
3299
6307db39
PE
33002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3301
3302 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3303
f3d4e0a4
CY
33042011-05-22 Chong Yidong <cyd@stupidchicken.com>
3305
3306 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3307
4d8ade89
YM
33082011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3309
3310 * dispnew.c (scrolling_window): Don't exclude the case that the
3311 last enabled row in the desired matrix touches the bottom boundary.
3312
32078c8d
GM
33132011-05-21 Glenn Morris <rgm@gnu.org>
3314
3315 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3316 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3317 and add some more files.
32078c8d 3318
7285dc67
EZ
33192011-05-20 Eli Zaretskii <eliz@gnu.org>
3320
3321 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3322 report_file_error introduced by the change from 2011-05-07.
3323
89d1bd22
PE
33242011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3325
3326 * systime.h (Time): Define only if emacs is defined.
3327 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3328 where the include path doesn't have X11/X.h by default. See
3329 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3330
e23640bb 33312011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3332
3333 * composite.c (find_automatic_composition): Fix previous change.
3334
b9704ad9
GM
33352011-05-20 Glenn Morris <rgm@gnu.org>
3336
3337 * lisp.mk: New file, split from Makefile.in.
3338 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3339 (shortlisp): Remove.
3340 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3341
4a720484
GM
33422011-05-19 Glenn Morris <rgm@gnu.org>
3343
3344 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3345 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3346 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3347 (lisp): Set the order to that of loadup.el.
3348 (shortlisp): Make it a copy of $lisp.
3349 (SOME_MACHINE_LISP): Remove.
3350 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3351 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3352
a28d4396
KH
33532011-05-18 Kenichi Handa <handa@m17n.org>
3354
3355 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3356 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3357 (find_automatic_composition): Mostly rewrite for efficiency.
3358
a2b1fa8e
JB
33592011-05-18 Juanma Barranquero <lekktu@gmail.com>
3360
3361 * makefile.w32-in: Update dependencies.
3362
8e1f5610
CS
33632011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3364
3365 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3366 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3367
7025ee00 33682011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3369
cdfa6eab
PE
3370 Fix some integer overflow issues, such as string length overflow.
3371
06d6db33
PE
3372 * insdel.c (count_size_as_multibyte): Check for string overflow.
3373
2b4560a8
PE
3374 * character.c (lisp_string_width): Check for string overflow.
3375 Use EMACS_INT, not int, for string indexes and lengths; in
3376 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3377 the resulting string length overflows an EMACS_INT; instead,
3378 report a string overflow if no precision given. When checking for
3379 precision exhaustion, use a check that cannot possibly have
3380 integer overflow. (Bug#8675)
3381 * character.h (lisp_string_width): Adjust to new signature.
3382
cb93f9be
PE
3383 * alloc.c (string_overflow): New function.
3384 (Fmake_string): Use it. This doesn't change behavior, but saves
3385 a few bytes and will simplify future changes.
3386 * character.c (string_escape_byte8): Likewise.
3387 * lisp.h (string_overflow): New decl.
3388
1a1f3366
PE
3389 Fixups, following up to the user-interface timestamp change.
3390 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3391 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3392 * msdos.c (mouse_get_pos): Likewise.
3393 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3394 * w32gui.h (Time): Define by including "systime.h" rather than by
3395 declaring it ourselves. (Bug#8664)
3396
d4e3e4d3
PE
3397 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3398 * image.c (clear_image_cache): Likewise.
3399
f6a24d19
PE
3400 * term.c (term_mouse_position): Don't assume time_t wraparound.
3401
08dc5ae6
PE
3402 Be more systematic about user-interface timestamps.
3403 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3404 and sometimes 'EMACS_UINT', to represent these timestamps.
3405 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3406 This makes the code easier to follow, and makes it easier to catch
3407 integer overflow bugs such as Bug#8664.
3408 * frame.c (Fmouse_position, Fmouse_pixel_position):
3409 Use Time, not unsigned long, for user-interface timestamps.
3410 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3411 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3412 * keyboard.h (last_event_timestamp): Likewise.
3413 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3414 * menu.h (xmenu_show): Likewise.
3415 * term.c (term_mouse_position): Likewise.
3416 * termhooks.h (struct input_event.timestamp): Likewise.
3417 (struct terminal.mouse_position_hook): Likewise.
3418 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3419 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3420 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3421 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3422 what it was before.
3423 * menu.h, termhooks.h: Include "systime.h", for Time.
3424
8e55734a
PE
3425 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3426 Don't assume that the difference between two unsigned long values
3427 can fit into an integer. At this point, we know button_down_time
3428 <= event->timestamp, so the difference must be nonnegative, so
3429 there's no need to cast the result if double-click-time is
3430 nonnegative, as it should be; check that it's nonnegative, just in
3431 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3432 apart (about 25 days). (Bug#8664)
8e55734a 3433
841f1b75 3434 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3435 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3436
3e26f69c
PE
3437 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3438 that always fit in int. Use a sentinel instead of a counter, to
3439 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3440 * frame.h (struct frame): Use int for menu_bar_items_used
3441 instead of EMACS_INT, since it always fits in int.
3e26f69c 3442
5cc152c0
PE
3443 * menu.c (grow_menu_items): Check for int overflow.
3444
d89eb65e
PE
3445 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3446
5235bd3e
PE
3447 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3448 Before, the code was not consistent. These values cannot exceed
3449 2**31 - 1 so there's no need to make them unsigned.
3450 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3451 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3452 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3453 as modifiers.
3454 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3455
bc827e23
PE
3456 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3457 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3458 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3459 presumably because the widths might not match.
3460
78eb494e
PE
3461 * window.c (size_window): Avoid needless test at loop start.
3462
04f2d78b
CB
34632011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3464
3465 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3466
d2fc7e3d 34672011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3468
3469 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3470
d2fc7e3d 34712011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3472
3473 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3474 `width' to `bar_area_x' and `bar_area_width', respectively.
3475 (x_scroll_run): Take account of fringe background extension.
3476
04f2d78b
CB
3477 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3478 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3479 `bar_area_width', respectively.
3480 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3481 background extension.
3482
79b70037
GM
34832011-05-10 Jim Meyering <meyering@redhat.com>
3484
3485 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3486
2f142cc5
JB
34872011-05-10 Juanma Barranquero <lekktu@gmail.com>
3488
3489 * image.c (Finit_image_library): Return t for built-in image types,
3490 like pbm and xbm. (Bug#8640)
3491
57679c86
AS
34922011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3493
3494 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3495
888c9e86
EZ
34962011-05-07 Eli Zaretskii <eliz@gnu.org>
3497
b0512a1d
EZ
3498 * w32console.c (Fset_screen_color): Doc fix.
3499 (Fget_screen_color): New function.
3500 (syms_of_ntterm): Defsubr it.
3501
7285dc67
EZ
3502 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3503 unlink the temporary file if Fcall_process didn't create it in the
3504 first place.
3505 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3506 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3507 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3508 cue to call_process_cleanup not to close that handle.
3509
4d3fcc8e
BK
35102011-05-07 Ben Key <bkey76@gmail.com>
3511
3512 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3513 one of two shell specific rules, either bootstrap-temacs-CMD or
3514 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3515 to the previous implementation of the bootstrap-temacs rule.
3516 The bootstrap-temacs-CMD rule is similar to the previous
3517 implementation of the bootstrap-temacs rule except that it
3518 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3519 variable.
3520
3521 These changes, along with some changes to nt/configure.bat,
3522 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3523 earlier fix to add support for --cflags and --ldflags options
3524 that include quotes so that it works whether make uses cmd or
3525 sh as the shell.
3526
b4289b64
MA
35272011-05-06 Michael Albinus <michael.albinus@gmx.de>
3528
3529 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3530 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3531 is a constant.
3532 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3533 a string. Handle both cases.
3534 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3535 (Fdbus_register_method): Use Qinvalid_function.
3536
af4c0e28
JB
35372011-05-06 Juanma Barranquero <lekktu@gmail.com>
3538
3539 * makefile.w32-in: Update dependencies.
3540 (LISP_H): Add inttypes.h and stdin.h.
3541 (PROCESS_H): Add unistd.h.
3542
c51453d9
EZ
35432011-05-06 Eli Zaretskii <eliz@gnu.org>
3544
3545 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3546 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3547
8ff0ac3c 35482011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3549
4c4b566b
PE
3550 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3551
aab2b9b5
PE
3552 * term.c (vfatal): Remove stray call to va_end.
3553 It's not needed and the C Standard doesn't allow it here anyway.
3554
c378da0b
PE
3555 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3556 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3557
288b08c7
PE
3558 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3559 bytes.
3560
e3601888
PE
3561 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3562
db6c0e74
PE
3563 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3564
dd5963ea
PE
3565 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3566
88c9450f
PE
3567 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3568
2f9442b8
PE
3569 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3570
c032b5f8
PE
3571 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3572 * charset.c (Fdefine_charset_internal): Don't initialize
3573 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3574 32-bit int (Bug#8600).
a108c10b
PE
3575
3576 * lread.c (read_integer): Be more consistent with string-to-number.
3577 Use string_to_number to do the actual conversion; this avoids
3578 rounding errors and fixes some other screwups. Without this fix,
3579 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3580 (digit_to_number): Move earlier, for benefit of read_integer.
3581 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3582 not a digit in any supported base. (Bug#8602)
a108c10b 3583
ad5f9eea
PE
3584 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3585
aec1708a
PE
3586 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3587 to match comment at start of function. This also removes a
3588 GCC warning about overflow in a 32+64-bit port.
3589
47be4ab5
PE
3590 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3591
371cac43
PE
3592 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3593 Reported by Stefan Monnier in
3594 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3595 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3596 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3597
d01a7826
PE
3598 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3599 (EMACS_UINTPTR): Likewise, with uintptr_t.
3600
7fd47d5c
PE
3601 * lisp.h: Prefer 64-bit EMACS_INT if available.
3602 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3603 on 32-bit hosts that have 64-bit int, so that they can access
3604 large files.
122b0c86
PE
3605 However, temporarily disable this change unless the temporary
3606 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3607
8727937b
PE
3608 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3609
8ac068ac
PE
3610 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3611 This removes an assumption that EMACS_INT and long are the same
3612 width as pointers. The assumption is true for Emacs porting targets
3613 now, but we want to make other targets possible.
3614 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3615 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3616 In the rest of the code, change types of integers that hold casted
3617 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3618 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3619 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3620 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3621 No need to cast type when ORing.
3622 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3623 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3624 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3625 assume EMACS_INT is the same width as char *.
3626 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3627 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3628 Remove no-longer-needed casts.
3629 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3630 (xg_tool_bar_help_callback, xg_make_tool_item):
3631 Use EMACS_INTPTR to hold an integer
3632 that will be cast to void *; this can avoid a GCC warning
3633 if EMACS_INT is not the same width as void *.
3634 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3635 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3636 (current_message_1, set_message_1):
3637 Use a local to convert to proper width without a cast.
3638 * xmenu.c (dialog_selection_callback): Likewise.
3639
ede49d71
PE
3640 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3641 Also, don't assume VALBITS / RAND_BITS is less than 5,
3642 and don't rely on undefined behavior when shifting a 1 left into
3643 the sign bit.
3644 * lisp.h (get_random): Change signature to match.
3645
2f30ecd0
PE
3646 * lread.c (hash_string): Use size_t, not int, for hash computation.
3647 Normally we prefer signed values; but hashing is special, because
3648 it's better to use unsigned division on hash table sizes so that
3649 the remainder is nonnegative. Also, size_t is the natural width
3650 for hashing into memory. The previous code used 'int', which doesn't
3651 retain enough info to hash well into very large tables.
3652 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3653
2a866e7b
PE
3654 * dbusbind.c: Don't possibly lose pointer info when converting.
3655 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3656 Use XPNTR rather than XHASH, so that the high-order bits of
3657 the pointer aren't lost when converting through void *.
3658
51639eac
PE
3659 * eval.c (Fautoload): Don't double-shift a pointer.
3660
92394119
PE
3661 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3662
dbdb9a7c
JB
36632011-05-06 Juanma Barranquero <lekktu@gmail.com>
3664
3665 * gnutls.c (DEF_GNUTLS_FN):
3666 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3667
db7a0b4f
AS
36682011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3669
3670 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3671 marker. (Bug#8610)
3672
f7ff1b0f 36732011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3674
3675 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3676 New version that can reserve upto 2GB of heap space.
3677
f7ff1b0f 36782011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3679
3680 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3681
639c109b
TZ
36822011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3683
3684 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3685 `gnutls_certificate_set_x509_key_file'.
3686
d2127135
JB
36872011-05-05 Juanma Barranquero <lekktu@gmail.com>
3688
3689 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3690 Update dependencies.
3691
e968f4f3
JB
36922011-05-04 Juanma Barranquero <lekktu@gmail.com>
3693
3694 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3695 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3696 Remove unused parameter `fildes'.
3697 * process.c (read_process_output, send_process): Don't pass it.
3698
84d358f0
JB
36992011-05-04 Juanma Barranquero <lekktu@gmail.com>
3700
3701 Fix previous change: the library cache is defined in w32.c.
3702 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3703 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3704
0898ca10
JB
37052011-05-04 Juanma Barranquero <lekktu@gmail.com>
3706
3707 Implement dynamic loading of GnuTLS on Windows.
3708
3709 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3710 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3711 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3712 Declare.
3713
3714 * gnutls.c (Qgnutls_dll): Define.
3715 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3716 (gnutls_*): Declare function pointers.
3717 (init_gnutls_functions): New function to initialize function pointers.
3718 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3719 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3720 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3721 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3722 (emacs_gnutls_write, emacs_gnutls_read)
3723 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3724 (Fgnutls_available_p): New function.
3725 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3726 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3727 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3728
3729 * image.c: Include w32.h.
3730 (Vimage_type_cache): Delete.
3731 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3732 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3733 (w32_delayed_load): Move to w32.c.
3734
3735 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3736
3737 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3738 (w32_delayed_load): Move from image.c. When loading a library, record
3739 its filename in the :loaded-from property of the library id.
3740 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3741 Initialize and staticpro them.
3742 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3743
3744 * process.c: Include lisp.h before w32.h, not after.
3745 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3746 instead of gnutls_record_check_pending.
3747
3748 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3749
ff4de4aa
TZ
37502011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3751
3752 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3753 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3754 as passed in.
3755
abe95abb
JD
37562011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3757
3758 * xterm.c (x_set_frame_alpha): Do not set property on anything
3759 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3760
e16e55d4
JB
37612011-05-02 Juanma Barranquero <lekktu@gmail.com>
3762
3763 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3764
bafcf6a5
JB
37652011-05-02 Juanma Barranquero <lekktu@gmail.com>
3766
3767 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3768 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3769 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3770 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3771 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3772 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3773 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3774 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3775 (Qgnutls_bootprop_callbacks_verify): Make static.
3776
e7a6747f
AS
37772011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3778
19ed11ba
AS
3779 * callproc.c: Indentation fixup.
3780
e7a6747f 3781 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3782 (wait_for_termination, interruptible_wait_for_termination):
3783 Move after wait_for_termination_1.
e7a6747f 3784
1ef14cb4
LMI
37852011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3786
3787 * sysdep.c (interruptible_wait_for_termination): New function
3788 which is like wait_for_termination, but allows keyboard
3789 interruptions.
3790
3791 * callproc.c (Fcall_process): Add (:file "file") as an option for
3792 the STDOUT buffer.
3793 (Fcall_process_region): Ditto.
3794
330d880c
EZ
37952011-04-30 Eli Zaretskii <eliz@gnu.org>
3796
8db90b73
EZ
3797 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3798 rather than `XVECTOR (FOO)->size'.
3799
330d880c
EZ
3800 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3801 inttypes.h, as a gnulib replacement is used if it not available in
3802 system headers.
3803
15cbd324
EZ
38042011-04-21 Eli Zaretskii <eliz@gnu.org>
3805
3806 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3807 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3808 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3809
3810 * coding.c (coding_alloc_by_realloc): Error out if destination
3811 will grow beyond MOST_POSITIVE_FIXNUM.
3812 (decode_coding_emacs_mule): Abort if there isn't enough place in
3813 charbuf for the composition carryover bytes. Reserve an extra
3814 space for up to 2 characters produced in a loop.
3815 (decode_coding_iso_2022): Abort if there isn't enough place in
3816 charbuf for the composition carryover bytes.
3817
38182011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3819
ae940cca
EZ
3820 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3821 aborting when %lld or %lll format is passed.
3822 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3823 %llo or %llx format is passed. (Bug#8545)
3824
03ab8921
EZ
3825 * window.c (window_scroll_line_based): Use a marker instead of
3826 simple variables to record original value of point. (Bug#7952)
3827
afda1437
EZ
3828 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3829 produced by %s or %c overflows available buffer space. (Bug#8545)
3830
f76dee0c
PE
38312011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3832
3833 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3834 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3835
fdc5744d
JB
38362011-04-28 Juanma Barranquero <lekktu@gmail.com>
3837
3838 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3839
638f053a
JB
38402011-04-28 Juanma Barranquero <lekktu@gmail.com>
3841
3842 * keyboard.c (Qdelayed_warnings_hook): Define.
3843 (command_loop_1): Run `delayed-warnings-hook'
3844 if Vdelayed_warnings_list is non-nil.
3845 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3846 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3847
d178f871
EZ
38482011-04-28 Eli Zaretskii <eliz@gnu.org>
3849
3850 * doprnt.c (doprnt): Don't return value smaller than the buffer
3851 size if the message was truncated. (Bug#8545).
3852
b124fd93
JB
38532011-04-28 Juanma Barranquero <lekktu@gmail.com>
3854
3855 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3856 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3857
e810457d
PE
38582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3859
3860 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3861
ea51cceb
JB
38622011-04-27 Juanma Barranquero <lekktu@gmail.com>
3863
3864 * makefile.w32-in: Update dependencies.
3865
94dcfacf
EZ
38662011-04-27 Eli Zaretskii <eliz@gnu.org>
3867
3868 Improve `doprnt' and its usage. (Bug#8545)
3869 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3870 `format_end'. Remove support for %l as a conversion specifier.
3871 Don't use xrealloc. Improve diagnostics when the %l size modifier
3872 is used. Update the commentary.
3873
3874 * eval.c (verror): Simplify calculation of size_t.
3875
3876 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3877 messages.
3878
f61f41d7
PE
38792011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3880
3881 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3882 change.
3883
96fb4434
PE
38842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3885
3886 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3887 This makes this file independent of the recent pseudovector change.
3888
671875da 38892011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3890
69e9b5a3
PE
3891 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3892
b5f869a7 3893 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3894 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3895 Remove unused local.
c8926152 3896 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3897
841a1577 3898 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3899 GCC 4.6.0 optimizes based on type-based alias analysis.
3900 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3901 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3902 != &v->size, and therefore "v->size = 1; b->size = 2; return
3903 v->size;" must therefore return 1. This assumption is incorrect
3904 for Emacs, since it type-puns struct Lisp_Vector * with many other
3905 types. To fix this problem, this patch adds a new type struct
f904488f 3906 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3907 and pseudovectors, and helps optimizing compilers not get fooled
3908 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3909 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3910 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3911 the size member.
eab3844f
PE
3912 (XSETPVECTYPE): Rewrite in terms of new macro.
3913 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3914 This is a bit clearer, and further avoids the possibility of
3915 undesirable aliasing.
3916 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3917 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3918 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3919 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3920 (ASIZE): Now uses header.size rather than size.
3921 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3922 to avoid the hassle of writing XVECTOR (foo)->header.size.
3923 (struct vectorlike_header): New type.
eab3844f
PE
3924 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3925 object, to help avoid aliasing.
3926 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3927 (SUBRP): Likewise, since Lisp_Subr is a special case.
3928 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3929 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3930 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3931 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3932 changed to be "header.size" and "header.next".
3933 * buffer.h (struct buffer): Likewise.
3934 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3935 * frame.h (struct frame): Likewise.
3936 * process.h (struct Lisp_Process): Likewise.
3937 * termhooks.h (struct terminal): Likewise.
3938 * window.c (struct save_window_data, struct saved_window): Likewise.
3939 * window.h (struct window): Likewise.
3940 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3941 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3942 * buffer.c (init_buffer_once): Likewise.
3943 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3944 special case.
3945 * process.c (Fformat_network_address): Use local var for size,
3946 for brevity.
3947
0df1eac5
PE
3948 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3949
847ab9d1 3950 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3951 * data.c (atof): Remove decl; no longer used or needed.
3952 (digit_to_number): Move to lread.c.
3953 (Fstring_to_number): Use new string_to_number function, to be
3954 consistent with how the Lisp reader treats infinities and NaNs.
3955 Do not assume that floating-point numbers represent EMACS_INT
3956 without losing information; this is not true on most 64-bit hosts.
3957 Avoid double-rounding errors, by insisting on integers when
3958 parsing non-base-10 numbers, as the documentation specifies.
3959 * lisp.h (string_to_number): New decl, replacing ...
3960 (isfloat_string): Remove.
bc0a5c13 3961 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3962 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3963 appears to have been a coding error. Similarly, do not accept
3964 strings like +-1e0 as floating point numbers. Do not report
3965 overflow for integer overflows unless the base is not 10 which
3966 means we have no simple and reliable way to continue.
3967 Break out the floating-point parsing into a new
3968 function string_to_number, so that Fstring_to_number parses
3969 floating point numbers consistently with the Lisp reader.
04f2d78b 3970 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3971 (E_CHAR, EXP_INT): Remove, replacing with ...
3972 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3973 (string_to_number): New function, replacing isfloat_string.
3974 This function checks for valid syntax and produces the resulting
3975 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3976 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3977 so that overflow for non-base-10 numbers is reported only when
3978 there's no portable and simple way to convert to floating point.
452f4150 3979
67769ffc
PE
3980 * textprop.c (set_text_properties_1): Rewrite for clarity,
3981 and to avoid GCC warning about integer overflow.
3982
c20db43f
PE
3983 * intervals.h (struct interval): Use EMACS_INT for members
3984 where EMACS_UINT might cause problems. See
3985 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3986 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3987 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3988 All uses changed.
37aa2f85
PE
3989 (offset_intervals): Tell GCC not to worry about length overflow
3990 when negating a negative length.
c20db43f 3991
2538aa2f
PE
3992 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3993 (overrun_check_free): Likewise.
3994
f2d3008d
PE
3995 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3996 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3997 word size.
3998
ec8df744
PE
3999 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4000 (gnutls_make_error): Rename local to avoid shadowing.
4001 (gnutls_emacs_global_deinit): ifdef out; not used.
4002 (Fgnutls_boot): Use const for pointer to readonly storage.
4003 Comment out unused local. Fix pointer signedness problems.
4004
640ee02d
PE
4005 * lread.c (openp): Don't stuff size_t into an 'int'.
4006 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4007 about possible signed overflow.
4008
6048fb2a
PE
4009 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4010 (GDK_KEY_g): Don't define if already defined.
4011 (xg_prepare_tooltip): Avoid pointer signedness problem.
4012 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4013
fa3c87e1
PE
4014 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4015 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4016
2172544b
PE
4017 * xfns.c (Fx_window_property): Simplify a bit,
4018 to make a bit faster and to avoid GCC 4.6.0 warning.
4019 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4020
9b821a21
PE
4021 * fns.c (internal_equal): Don't assume size_t fits in int.
4022
3c616cfa
PE
4023 * alloc.c (compact_small_strings): Tighten assertion a little.
4024
c2982e87
PE
4025 Replace pEd with more-general pI, and fix some printf arg casts.
4026 * lisp.h (pI): New macro, generalizing old pEd macro to other
4027 conversion specifiers. For example, use "...%"pI"d..." rather
4028 than "...%"pEd"...".
4029 (pEd): Remove. All uses replaced with similar uses of pI.
4030 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4031 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4032 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4033 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4034 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4035 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4036 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4037 64-bit hosts.
4038 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4039 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4040 * print.c (safe_debug_print, print_object): Likewise.
4041 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4042 to int.
6f04d126
PE
4043 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4044 avoiding the 0 flag, which is not portable.
c2982e87
PE
4045 * process.c (Fmake_network_process): Use pI to avoid cast.
4046 * region-cache.c (pp_cache): Likewise.
4047 * xdisp.c (decode_mode_spec): Likewise.
4048 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4049 behavior on 64-bit hosts with printf arg.
6f04d126 4050 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4051 (x_stop_queuing_selection_requests): Likewise.
4052 (x_get_window_property): Don't truncate byte count to an 'int'
4053 when tracing.
0b432f21 4054
5e073ec7
PE
4055 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4056 here, since it parses constructs like leading '-' and spaces,
4057 which are not wanted; and it overflows with large numbers.
4058 Instead, simply match F[0-9]+, which is what is wanted anyway.
4059
36372bf9
PE
4060 * alloc.c: Remove unportable assumptions about struct layout.
4061 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4062 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4063 (allocate_vectorlike, make_pure_vector): Use the new macros,
4064 plus offsetof, to remove unportable assumptions about struct layout.
4065 These assumptions hold on all porting targets that I know of, but
4066 they are not guaranteed, they're easy to remove, and removing them
4067 makes further changes easier.
4068
0b432f21
PE
4069 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4070 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4071 (string_overrun_cookie): Now const. Use initializers that
4072 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4073 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4074 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4075 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4076 multiple of sizeof (EMACS_INT); it need not be, if
4077 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4078 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4079
895009e1
JB
40802011-04-26 Juanma Barranquero <lekktu@gmail.com>
4081
4082 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4083
6a7a1b0b
TZ
40842011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4085
4086 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4087 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4088 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4089
841a1577 40902011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4091
4092 * lisp.h (Qdebug): List symbol.
895009e1 4093 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4094 * keyboard.c (debug-on-event): New variable.
4095 (handle_user_signal): Break into debugger when debug-on-event
4096 matches the current signal symbol.
4097
f2d3ba6f
DN
40982011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4099
4100 * alloc.c (check_sblock, check_string_bytes)
4101 (check_string_free_list): Convert to standard C.
4102
42ce4c63
TZ
41032011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4104
4105 * w32.c (emacs_gnutls_push): Fix typo.
4106
825cd63c
EZ
41072011-04-25 Eli Zaretskii <eliz@gnu.org>
4108
fb11d64d
EZ
4109 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4110 "cast to pointer from integer of different size".
4111
825cd63c
EZ
4112 Improve doprnt and its use in verror. (Bug#8545)
4113 * doprnt.c (doprnt): Document the set of format control sequences
4114 supported by the function. Use SAFE_ALLOCA instead of always
4115 using `alloca'.
4116
4117 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4118 is one byte too soon. Don't use xrealloc; instead xfree and
4119 xmalloc anew.
4120
e061a11b
TZ
41212011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4122
4123 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4124 callbacks stage.
4125
4126 * gnutls.c: Renamed global_initialized to
4127 gnutls_global_initialized. Added internals for the
4128 :verify-hostname-error, :verify-error, and :verify-flags
4129 parameters of `gnutls-boot' and documented those parameters in the
4130 docstring. Start callback support.
9173deec
JB
4131 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4132 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4133 on error. Return error code.
e061a11b
TZ
4134 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4135 (emacs_gnutls_read): Likewise.
4136 (Fgnutls_boot): Return handshake error code.
4137 (emacs_gnutls_handle_error): New function.
4138 (wsaerror_to_errno): Likewise.
4139
4140 * w32.h (emacs_gnutls_pull): Add prototype.
4141 (emacs_gnutls_push): Likewise.
4142
4143 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4144 (emacs_gnutls_push): Likewise.
4145
41462011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4147
4148 * process.c (wait_reading_process_output): Check if GnuTLS
4149 buffered some data internally if no FDs are set for TLS
4150 connections.
4151
4152 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4153 (LIBS): Link to USER_LIBS.
4154 ($(BLD)/gnutls.$(0)): New target.
4155
fa6996bc
EZ
41562011-04-24 Eli Zaretskii <eliz@gnu.org>
4157
eb35682e
EZ
4158 * xdisp.c (handle_single_display_spec): Rename the
4159 display_replaced_before_p argument into display_replaced_p, to
4160 make it consistent with the commentary. Fix typos in the
4161 commentary.
4162
e2ad650c
EZ
4163 * textprop.c (syms_of_textprop): Remove dead code.
4164 (copy_text_properties): Delete obsolete commentary about an
4165 interface that was deleted long ago. Fix typos in the description
4166 of arguments.
4167
1b2de274
EZ
4168 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4169 to changes in oldXMenu/XMenu.h from 2011-04-16.
4170 <menu_help_message, prev_menu_help_message>: Constify.
4171 (IT_menu_make_room): menu->help_text is now `const char **';
4172 adjust.
4173
4174 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4175 to changes in oldXMenu/XMenu.h from 2011-04-16.
4176 (struct XMenu): Declare `help_text' `const char **'.
4177
4178 * xfaces.c <Qunspecified>: Make extern again.
4179
4180 * syntax.c: Include sys/types.h before including regex.h, as
4181 required by Posix.
4182
762b15be
EZ
4183 * doc.c (get_doc_string): Improve the format passed to `error'.
4184
4185 * doprnt.c (doprnt): Improve commentary.
4186
4187 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4188
4189 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4190 them with etags.
4191
f1052e5d
EZ
4192 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4193 changes in globals.h immediately force recompilation.
762b15be
EZ
4194 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4195 $(CURDIR)/s/ms-w32.h.
4196 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4197
fa6996bc
EZ
4198 * character.c (Fchar_direction): Function deleted.
4199 (syms_of_character): Don't defsubr it.
4200 <char-direction-table>: Deleted.
4201
e6c3da20
EZ
42022011-04-23 Eli Zaretskii <eliz@gnu.org>
4203
4204 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4205 * doprnt.c: Include limits.h.
4206 (SIZE_MAX): New macro.
04f2d78b
CB
4207 (doprnt): Return a size_t value. 2nd arg is now size_t.
4208 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4209 Improve overflow protection. Support `l' modifier for integer
4210 conversions. Support %l conversion. Don't assume an EMACS_INT
4211 argument for integer conversions and for %c.
4212
4213 * lisp.h (doprnt): Restore prototype.
4214
4215 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4216 $(SRC)/character.h.
4217
4218 * Makefile.in (base_obj): Add back doprnt.o.
4219
4220 * deps.mk (doprnt.o): Add back prerequisites.
4221 (callint.o): Depend on character.h.
4222
4223 * eval.c (internal_lisp_condition_case): Include the handler
4224 representation in the error message.
4225 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4226 when breaking from the loop.
4227
4228 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4229
4230 * callint.c (Fcall_interactively): When displaying error message
4231 about invalid control letter, pass the character's codepoint, not
4232 a pointer to its multibyte form. Improve display of the character
4233 in octal and display also its hex code.
4234
4235 * character.c (char_string): Use %x to display the (unsigned)
4236 codepoint of an invalid character, to avoid displaying a bogus
4237 negative value.
4238
4239 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4240 `error', not SYMBOL_NAME itself.
4241
4242 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4243 character arguments to `error'.
4244
4245 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4246 to `error' in error message about FINAL_CHAR argument. Make sure
4247 FINAL_CHAR is a character, and use %c when it is passed as
4248 argument to `error'.
4249
4ffd0d6b 42502011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4251
4252 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4253
4254 * w32.c: Include <time.h>.
4255 (sys_localtime): New function.
4256
4ffd0d6b 42572011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4258
4259 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4260
4ffd0d6b 4261 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4262
4ffd0d6b 42632011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4264
4ffd0d6b
GM
4265 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4266 zombies (Bug#8467).
aac0c6e3 4267
04c56954
EZ
42682011-04-19 Eli Zaretskii <eliz@gnu.org>
4269
4270 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4271 gl_state.e_property when gl_state.object is Qt.
4272
4273 * insdel.c (make_gap_larger): Remove limitation of buffer size
4274 to <= INT_MAX.
4275
16a43933
CY
42762011-04-18 Chong Yidong <cyd@stupidchicken.com>
4277
4278 * xdisp.c (lookup_glyphless_char_display)
4279 (produce_glyphless_glyph): Handle cons cell entry in
4280 glyphless-char-display.
4281 (Vglyphless_char_display): Document it.
4282
4283 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4284 glyphless-char-display.
4285
4581706e
CY
42862011-04-17 Chong Yidong <cyd@stupidchicken.com>
4287
4288 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4289
4290 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4291
4292 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4293 definition for no-X builds.
4294
4887c6e2 42952011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4296
fd35b6f9
PE
4297 Static checks with GCC 4.6.0 and non-default toolkits.
4298
5c1ccb01
PE
4299 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4300
006c5daa
PE
4301 * process.c (keyboard_bit_set): Define only if SIGIO.
4302 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4303 (send_process): Repair possible setjmp clobbering.
4304
efc736d3
PE
4305 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4306
4e2fe2e6
PE
4307 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4308
f97334a2
PE
4309 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4310
4e75f29d
PE
4311 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4312 Define only if needed.
4313
90efadd1
PE
4314 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4315 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4316 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4317
3c647824
PE
4318 * dispextern.h (struct redisplay_interface): Rename param
4319 to avoid shadowing.
e264f262 4320 * termhooks.h (struct terminal): Likewise.
761383f4 4321 * xterm.c (xembed_send_message): Likewise.
3c647824 4322
b58c5c4a
PE
4323 * insdel.c (make_gap_smaller): Define only if
4324 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4325
cad59032
PE
4326 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4327 it.
4328
c339dc2e
PE
4329 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4330 so that we aren't warned about unused symbols.
4331
91a3e27b
PE
4332 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4333
399c71d3 4334 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4335
8ffc96f5
PE
4336 * xfns.c (x_real_positions): Mark locals as initialized.
4337
eef9bc79
PE
4338 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4339
098db9dd
PE
4340 * xterm.c: Fix problems found by static analysis with other toolkits.
4341 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4342 (x_dispatch_event): Declare static if USE_GTK, and
4343 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4344 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4345 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4346 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4347 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4348
eb18f6cc
PE
4349 * xmenu.c (menu_help_callback): Pointer type fixes.
4350 Use const pointers when pointing at readonly data. Avoid pointer
4351 signedness clashes.
4352 (FALSE): Remove unused macro.
4353 (update_frame_menubar): Remove unused decl.
4354
1fe72bf8
PE
4355 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4356
60d9e1db
PE
4357 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4358 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4359 (single_menu_item): Rename local to avoid shadowing.
4360
39261c26
PE
4361 * keyboard.c (make_lispy_event): Remove unused local var.
4362
018c5e19
PE
4363 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4364 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4365
63d2b86e
PE
4366 * bitmaps: Change bitmaps from unsigned char back to the X11
4367 compatible char. Avoid the old compiler warnings about
4368 out-of-range initializers by using, for example, '\xab' rather
4369 than 0xab.
4370
aefd87e1
PE
4371 * xgselect.c (xgselect_initialize): Check vs interface
4372 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4373
bf501fb9
PE
4374 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4375
e9829fdf
PE
4376 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4377 to read-only memory.
4378
1086c095
PE
4379 * fns.c (vector): Remove; this old hack is no longer needed.
4380
2baccd04 4381 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4382 Remove unused var.
dde42981 4383 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4384
72391843 4385 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4386
436c16df 4387 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4388 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4389 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4390
92bb796d 4391 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4392 (x_term_init): Remove local to avoid shadowing.
92bb796d 4393
764430a3 4394 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4395
4396 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4397 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4398
d1dfb56c
EZ
43992011-04-16 Eli Zaretskii <eliz@gnu.org>
4400
c4354cb4
EZ
4401 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4402
d1dfb56c
EZ
4403 Fix regex.c, syntax.c and friends for buffers > 2GB.
4404 * syntax.h (struct gl_state_s): Declare character position members
4405 EMACS_INT.
4406
4407 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4408
04f2d78b
CB
4409 * textprop.c (verify_interval_modification, interval_of):
4410 Declare arguments EMACS_INT.
d1dfb56c
EZ
4411
4412 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4413 EMACS_INT.
4414
4415 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4416
4417 * indent.c (Fvertical_motion): Local variable it_start is now
4418 EMACS_INT.
4419
4420 * regex.c (re_match, re_match_2, re_match_2_internal)
4421 (bcmp_translate, regcomp, regexec, print_double_string)
4422 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4423 (re_compile_pattern, re_exec): Declare arguments and local
4424 variables `size_t' and `ssize_t' and return values `regoff_t', as
4425 appropriate.
4426 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4427 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4428 <compile_stack_type>: `size' and `avail' are now `size_t'.
4429
4430 * regex.h <regoff_t>: Use ssize_t, not int.
4431 (re_search, re_search_2, re_match, re_match_2): Arguments that
4432 specify buffer/string position and length are now ssize_t and
4433 size_t. Return type is regoff_t.
4434
613052cd
BK
44352011-04-16 Ben Key <bkey76@gmail.com>
4436
4437 * nsfont.m: Fixed bugs in ns_get_family and
4438 ns_descriptor_to_entity that were caused by using free to
4439 deallocate memory blocks that were allocated by xmalloc (via
4440 xstrdup). This caused Emacs to crash when compiled with
4441 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4442 --enable-checking=xmallocoverrun). xfree is now used to
4443 deallocate these memory blocks.
4444
4170f62f 44452011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4446
71b41406
PE
4447 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4448
9587a89d
PE
4449 emacs_write: Accept and return EMACS_INT for sizes.
4450 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4451 et seq.
4452 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4453 Accept and return EMACS_INT.
4454 (emacs_gnutls_write): Return the number of bytes written on
4455 partial writes.
4456 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4457 (emacs_read, emacs_write): Remove check for negative size, as the
4458 Emacs source code has been audited now.
9587a89d
PE
4459 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4460 (emacs_read, emacs_write): Use it.
273a5f82
PE
4461 * process.c (send_process): Adjust to the new signatures of
4462 emacs_write and emacs_gnutls_write. Do not attempt to store
4463 a byte offset into an 'int'; it might overflow.
9587a89d 4464 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4465
3e047f51
PE
4466 * sound.c: Don't assume sizes fit in 'int'.
4467 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4468 Return EMACS_INT, not int.
3e047f51 4469 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4470 Accept EMACS_INT, not int.
4471 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4472 record read return values.
4473
cc39a9db
BK
44742011-04-15 Ben Key <bkey76@gmail.com>
4475
c9d0ec6d
JB
4476 * keyboard.c (Qundefined): Don't declare static since it is used
4477 in nsfns.m.
4478 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4479 static since they are used in nsfont.m.
cc39a9db 4480
6c60eb9f
SM
44812011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4482
4483 * process.c (Qprocessp): Don't declare static.
4484 * lisp.h (Qprocessp): Declare again.
4485
7990b61a
JB
44862011-04-15 Juanma Barranquero <lekktu@gmail.com>
4487
4488 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4489
5d4cb038
PE
44902011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4491
8bd7b830 4492 Improve C-level modularity by making more things 'static'.
cd64ea1d 4493
e3b27b31
PE
4494 Don't publish debugger-only interfaces to other modules.
4495 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4496 (verify_bytepos, count_markers): Move decls to the only modules
4497 that need them.
4498 * region-cache.h (pp_cache): Likewise.
4499 * window.h (check_all_windows): Likewise.
4500 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4501
5d4cb038
PE
4502 * sysdep.c (croak): Now static, if
4503 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4504 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4505
4506 * alloc.c (refill_memory_reserve): Now static if
4507 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4508 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4509
e87b6180
PE
4510 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4511 Define only if USE_LUCID.
4512
ac64929e
PE
4513 * xrdb.c (x_customization_string, x_rm_string): Now static.
4514
6f37259d
PE
4515 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4516 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4517
1683e3ab
PE
4518 * xdisp.c (draw_row_with_mouse_face): Now static.
4519 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4520
de9c2632
PE
4521 * window.h (check_all_windows): Mark externally visible.
4522
2b96acb7
PE
4523 * window.c (window_deletion_count): Now static.
4524
4525 * undo.c: Make symbols static if they're not exported.
4526 (last_undo_buffer, last_boundary_position, pending_boundary):
4527 Now static.
4528
50436f33
PE
4529 * textprop.c (interval_insert_behind_hooks): Now static.
4530 (interval_insert_in_front_hooks): Likewise.
4531
64520e5c
PE
4532 * term.c: Make symbols static if they're not exported.
4533 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4534 (max_frame_lines, tty_set_terminal_modes):
4535 (tty_reset_terminal_modes, tty_turn_off_highlight):
4536 (get_tty_terminal): Now static.
4537 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4538 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4539 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4540 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4541 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4542
1fa53021
PE
4543 * sysdep.c: Make symbols static if they're not exported.
4544 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4545 Now static.
4546 (sigprocmask_set, full_mask): Remove; unused.
4547 (wait_debugging): Mark as visible.
4548 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4549 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4550
d4b43b22
PE
4551 * syntax.c (syntax_temp): Define only if !__GNUC__.
4552
b7c513d0
PE
4553 * sound.c (current_sound_device, current_sound): Now static.
4554
989b29ad
PE
4555 * search.c (searchbufs, searchbuf_head): Now static.
4556
13a55a78
PE
4557 * scroll.c (scroll_cost): Remove; unused.
4558 * dispextern.h (scroll_cost): Remove decl.
4559
de68a1fc
PE
4560 * region-cache.h (pp_cache): Mark as externally visible.
4561
40ccffa6
PE
4562 * process.c: Make symbols static if they're not exported.
4563 (process_tick, update_tick, create_process, chan_process):
4564 (Vprocess_alist, proc_buffered_char, datagram_access):
4565 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4566 (deactivate_process): Mark defn as static, as well as decl.
4567 * lisp.h (create_process): Remove decl.
4568 * process.h (chan_process, Vprocess_alist): Remove decls.
4569
ad64fc97
PE
4570 * print.c: Make symbols static if they're not exported.
4571 (print_depth, new_backquote_output, being_printed, print_buffer):
4572 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4573 (print_interval, print_number_index, initial_stderr_stream):
4574 Now static.
4575 * lisp.h (Fprinc): Remove decl.
4576 (debug_output_compilation_hack): Mark as externally visible.
4577
adddb265
PE
4578 * sysdep.c (croak): Move decl from here to syssignal.h.
4579 * syssignal.h (croak): Put it here, so the API can be checked when
4580 'croak' is called from dissociate_if_controlling_tty.
4581
1717ede2
PE
4582 * minibuf.c: Make symbols static if they're not exported.
4583 (minibuf_save_list, choose_minibuf_frame): Now static.
4584 * lisp.h (choose_minibuf_frame): Remove decl.
4585
fa5fb2bc
PE
4586 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4587
1e3890d1
PE
4588 * lread.c: Make symbols static if they're not exported.
4589 (read_objects, initial_obarray, oblookup_last_bucket_number):
4590 Now static.
4591 (make_symbol): Remove; unused.
4592 * lisp.h (initial_obarray, make_symbol): Remove decls.
4593
8a1414fa
PE
4594 * keyboard.c: Make symbols static if they're not exported.
4595 (single_kboard, recent_keys_index, total_keys, recent_keys):
4596 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4597 (this_single_command_key_start, echoing, last_auto_save):
4598 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4599 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4600 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4601 (Vlispy_mouse_stem, double_click_count):
4602 Now static.
4603 (force_auto_save_soon): Define only if SIGDANGER.
4604 (ignore_mouse_drag_p): Now static if
4605 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4606 (print_help): Remove; unused.
4607 (stop_character, last_timer_event): Mark as externally visible.
4608 * keyboard.h (ignore_mouse_drag_p): Declare only if
4609 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4610 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4611 * lisp.h (echoing): Remove decl.
4612 (force_auto_save_soon): Declare only if SIGDANGER.
4613 * xdisp.c (redisplay_window): Simplify code, to make it more
4614 obvious that ignore_mouse_drag_p is not accessed if !defined
4615 USE_GTK && !defined HAVE_NS.
4616
93ea6e8f
PE
4617 * intervals.c: Make symbols static if they're not exported.
4618 (merge_properties_sticky, merge_interval_right, delete_interval):
4619 Now static.
4620 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4621
77382fcc
PE
4622 * insdel.c: Make symbols static if they're not exported.
4623 However, leave prepare_to_modify_buffer alone. It's never
4624 called from outside this function, but that appears to be a bug.
4625 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4626 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4627 (adjust_after_replace_noundo): Remove; unused.
4628 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4629 (signal_before_change): Remove decls.
77382fcc 4630
9306c32e
PE
4631 * indent.c (val_compute_motion, val_vmotion): Now static.
4632
cd44d2eb
PE
4633 * image.c: Make symbols static if they're not exported.
4634 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4635 if USE_GTK.
4636 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4637 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4638
ad9a7a06
PE
4639 * fringe.c (standard_bitmaps): Now static.
4640 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4641
81626931
PE
4642 * frame.c: Make symbols static if they're not exported.
4643 (x_report_frame_params, make_terminal_frame): Now static.
4644 (get_frame_param): Now static, unless HAVE_NS.
4645 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4646 (x_get_resource_string): Remove; not used.
4647 * frame.h (make_terminal_frame, x_report_frame_params):
4648 (x_get_resource_string); Remove decls.
4649 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4650 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4651
239f9db9
PE
4652 * font.c, fontset.c: Make symbols static if they're not exported.
4653 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4654 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4655 * font.c (font_close_object): Now static.
4656 * font.h (font_close_object): Remove.
4657 * fontset.c (FONTSET_OBJLIST): Remove.
4658 (free_realized_fontset) #if-0 the body, which does nothing.
4659 (face_suitable_for_char_p): #if-0, as it's never called.
4660 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4661 * xfaces.c (face_at_string_position):
4662 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4663 since 0 is always ASCII.
4664
dfcf3579
PE
4665 * fns.c (weak_hash_tables): Now static.
4666
5045092b
PE
4667 * fileio.c: Make symbols static if they're not exported.
4668 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4669 (Vwrite_region_annotation_buffers): Now static.
4670
57a96f5c
PE
4671 * eval.c: Make symbols static if they're not exported.
4672 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4673 * lisp.h (backtrace_list): Remove decl.
4674
35f08c38
PE
4675 * emacs.c: Make symbols static if they're not exported.
4676 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4677 (fatal_error_code, fatal_error_signal_hook, standard_args):
4678 Now static.
4679 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4680 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4681 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4682 * lisp.h (fatal_error_signal_hook): Remove decl.
4683 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4684
f44bd759
PE
4685 * editfns.c: Move a (normally-unused) function to its only use.
4686 * editfns.c, lisp.h (get_operating_system_release): Remove.
4687 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4688 worth the hassle of breaking this out.
4689
b532497d
PE
4690 * xterm.c: Make symbols static if they're not exported.
4691 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4692 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4693 (x_destroy_window, x_delete_display):
4694 Now static.
4695 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4696 (x_mouse_leave): Remove; unused.
4697 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4698 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4699 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4700 Remove decls.
4701 (x_mouse_leave): Declare only if WINDOWSNT.
4702 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4703 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4704 USE_X_TOOLKIT.
4705
1675728f
PE
4706 * ftxfont.c: Make symbols static if they're not exported.
4707 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4708 HAVE_FREETYPE.
4709 * font.h (ftxfont_driver): Likewise.
4710
e4cebfca
PE
4711 * xfns.c: Make symbols static if they're not exported.
4712 (x_last_font_name, x_display_info_for_name):
4713 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4714 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4715 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4716 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4717 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4718 (last_show_tip_args): Now static.
4719 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4720 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4721 (x_screen_planes): Remove; unused.
4722 * dispextern.h (x_screen_planes): Remove decl.
4723
5bf46f05
PE
4724 * dispnew.c: Make symbols static if they're not exported.
4725 * dispextern.h (redraw_garbaged_frames, scrolling):
4726 (increment_row_positions): Remove.
4727 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4728 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4729 Now static.
4730 (redraw_garbaged_frames): Remove; unused.
4731
435f4c28
PE
4732 * xfaces.c: Make symbols static if they're not exported.
4733 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4734 Remove decls.
4735 * xterm.h (defined_color): Remove decls.
4736 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4737 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4738 (menu_face_changed_default, defined_color, free_realized_face):
4739 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4740 (ascii_face_of_lisp_face): Remove; unused.
4741
8524aef3
PE
4742 * xdisp.c: Make symbols static if they're not exported.
4743 * dispextern.h (scratch_glyph_row, window_box_edges):
4744 (glyph_to_pixel_coords, set_cursor_from_row):
4745 (get_next_display_element, set_iterator_to_next):
4746 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4747 (show_mouse_face): Remove decls
4748 * frame.h (message_buf_print): Likewise.
4749 * lisp.h (pop_message, set_message, check_point_in_composition):
4750 Likewise.
4751 * xterm.h (set_vertical_scroll_bar): Likewise.
4752 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4753 (message_buf_print, scratch_glyph_row, displayed_buffer):
4754 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4755 (get_next_display_element, show_mouse_face, window_box_edges):
4756 (frame_to_window_pixel_xy, check_point_in_composition):
4757 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4758 (glyph_to_pixel_coords): Remove; unused.
4759
16390cd2
PE
4760 * dired.c (file_name_completion): Now static.
4761
4762 * dbusbind.c (xd_in_read_queued_messages): Now static.
4763
a25f4dfa
PE
4764 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4765 * data.c (circular_list_error): Remove.
4766
14a9c8df
PE
4767 * commands.h (last_point_position, last_point_position_buffer):
4768 (last_point_position_window): Remove decls.
4769 * keyboard.c: Make these variables static.
4770
04f2d78b
CB
4771 * coding.h (coding, code_convert_region, encode_coding_gap):
4772 Remove decls.
74ab6df5
PE
4773 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4774 (iso_code_class, detect_coding, code_convert_region): Now static.
4775 (encode_coding_gap): Remove; unused.
4776
38dfbee1
PE
4777 * chartab.c (chartab_chars, chartab_bits): Now static.
4778
a2cb4e63
PE
4779 * charset.h (charset_iso_8859_1): Remove decl.
4780 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4781 Now static.
4782
127198fd
PE
4783 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4784 * ccl.c (Vccl_program_table): Now static.
4785 (check_ccl_update): Remove; unused.
4786
d85b608f
PE
4787 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4788 * category.h: ... from here.
4789 * category.c (check_category_table, set_category_set): Now static.
4790
31cd66f3
PE
4791 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4792 * lisp.h: Remove these decls.
4793
c358e587
PE
4794 * buffer.c (buffer_count): Remove unused var.
4795
e78aecca
PE
4796 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4797 so that it's not optimized away.
4798 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4799 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4800 exported only to the debugger.
4801
e192d7d3 4802 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4803 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4804
92470028
PE
4805 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4806 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4807 was inaccessible from Lisp.
4808 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4809 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4810
244ed907
PE
4811 alloc.c: Import and export fewer symbols, and remove unused items.
4812 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4813 is defined.
4814 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4815 it's not optimized away by whole-program optimization.
4816 (message_enable_multibyte, free_misc): Remove.
4817 (catchlist, handlerlist, mark_backtrace):
4818 Declare only if BYTE_MARK_STACK.
4819 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4820 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4821 (message_enable_multibyte): Remove decl.
4822 (free_misc, interval_free_list, float_block, float_block_index):
4823 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4824 (cons_free_list, last_marked_index):
4825 Now static.
4826 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4827 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4828 (mark_backtrace): Define only if BYTE_MARK_STACK.
4829 * xdisp.c (message_enable_multibyte): Now static.
4830
61c2b50e 4831 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4832 This makes it easier for human readers (and static analyzers)
4833 to see whether these variables are used from other modules.
4834 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4835 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4836 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4837 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4838 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4839 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4840 * xmenu.c, xselect.c:
4841 Declare Q* vars static if they are not used in other modules.
4842 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4843 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4844 Remove decls of unexported vars.
4845 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4846
95c82688
PE
4847 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4848
16a97296
PE
4849 Make Emacs functions such as Fatom 'static' by default.
4850 This makes it easier for human readers (and static analyzers)
4851 to see whether these functions can be called from other modules.
4852 DEFUN now defines a static function. To make the function external
4853 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4854 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4855 (Finit_image_library):
16a97296
PE
4856 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4857 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4858 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4859 Remove decls, since these functions are now static.
4860 (Funintern, Fget_internal_run_time): New decls, since these functions
4861 were already external.
95c82688 4862
16a97296
PE
4863 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4864 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4865 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4866 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4867 * keyboard.c, keymap.c, lread.c:
4868 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4869 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4870 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4871 Mark functions with DEFUE instead of DEFUN,
4872 if they are used in other modules.
4873 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4874 decls for now-static functions.
4875 * buffer.h (Fdelete_overlay): Remove decl.
4876 * callproc.c (Fgetenv_internal): Mark as internal.
4877 * composite.c (Fremove_list_of_text_properties): Remove decl.
4878 (Fcomposition_get_gstring): New forward static decl.
4879 * composite.h (Fcomposite_get_gstring): Remove decl.
4880 * dired.c (Ffile_attributes): New forward static decl.
4881 * doc.c (Fdocumntation_property): New forward static decl.
4882 * eval.c (Ffetch_bytecode): New forward static decl.
4883 (Funintern): Remove extern decl; now in .h file where it belongs.
4884 * fileio.c (Fmake_symbolic_link): New forward static decl.
4885 * image.c (Finit_image_library): New forward static decl.
4886 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4887 * intervals.h (Fprevious_property_change):
4888 (Fremove_list_of_text_properties): Remove decls.
4889 * keyboard.c (Fthis_command_keys): Remove decl.
4890 (Fcommand_execute): New forward static decl.
4891 * keymap.c (Flookup_key): New forward static decl.
4892 (Fcopy_keymap): Now static.
4893 * keymap.h (Flookup_key): Remove decl.
4894 * process.c (Fget_process): New forward static decl.
4895 (Fprocess_datagram_address): Mark as internal.
4896 * syntax.c (Fsyntax_table_p): New forward static decl.
4897 (skip_chars): Remove duplicate decl.
4898 * textprop.c (Fprevious_property_change): New forward static decl.
4899 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4900 Now internal.
4901 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4902 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4903
785bbd42
PE
4904 * editfns.c (Fformat): Remove unreachable code.
4905
8b913b57
AS
49062011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4907
4908 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4909 change. (Bug#8496)
4910
a6744a35
EZ
49112011-04-13 Eli Zaretskii <eliz@gnu.org>
4912
4913 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4914 when at ZV. (Bug#8487)
4915
e7974947
AS
49162011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4917
baad03f0
AS
4918 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4919 (Bug#8437)
4920 * keyboard.c (parse_tool_bar_item): Likewise.
4921 * sound.c (sound_cleanup, alsa_close): Likewise.
4922 * termcap.c (tgetent): Likewise.
4923 * xfns.c (x_default_font_parameter): Likewise.
4924 * xsettings.c (read_and_apply_settings): Likewise.
4925
e7974947
AS
4926 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4927 (overrun_check_free): Protoize.
4928
28272684
PE
49292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4930
4931 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4932 since callers should never pass a negative size.
4933 Change the signature to match that of plain 'read' and 'write'; see
4934 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4935 * lisp.h: Update prototypes of emacs_write and emacs_read.
4936
11997c76
EZ
49372011-04-11 Eli Zaretskii <eliz@gnu.org>
4938
4939 * xdisp.c (redisplay_window): Don't try to determine the character
4940 position of the scroll margin if the window start point w->startp
e896f03c 4941 is outside the buffer's accessible region. (Bug#8468)
11997c76 4942
8a2cbd72
EZ
49432011-04-10 Eli Zaretskii <eliz@gnu.org>
4944
4945 Fix write-region and its subroutines for buffers > 2GB.
4946 * fileio.c (a_write, e_write): Modify declaration of arguments and
4947 local variables to support buffers larger than 2GB.
4948 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4949
4950 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4951 argument, local variables, and return value.
4952
4953 * lisp.h: Update prototypes of emacs_write and emacs_read.
4954
4955 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4956
4073e537 49572011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4958
1ebfdcb6
PE
4959 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4960
b2ded58d
PE
4961 Fix more problems found by GCC 4.6.0's static checks.
4962
7d66342c
PE
4963 * xdisp.c (vmessage): Use a better test for character truncation.
4964
bbf47d44
PE
4965 * charset.c (load_charset_map): <, not <=, for optimization,
4966 and to avoid potential problems with integer overflow.
9248994d 4967 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4968 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4969 * editfns.c (Fformat): Likewise.
1e69125e 4970 * syntax.c (skip_chars): Likewise.
3befa583 4971
e3019616
PE
4972 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4973 This also lets GCC 4.6.0 generate slightly better loop code.
4974
becfa255
PE
4975 * callint.c (Fcall_interactively): <, not <=, for optimization.
4976 (Fcall_interactively): Count the number of arguments produced,
4977 not the number of arguments given. This is simpler and lets GCC
4978 4.6.0 generate slightly better code.
4979
dae0cd48
PE
4980 * ftfont.c: Distingish more carefully between FcChar8 and char.
4981 The previous code passed unsigned char * to a functions like
4982 strlen and xstrcasecmp that expect char *, which does not
4983 conform to the C standard.
4984 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4985 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4986 char * when the C standard requires it.
4987
76032d70
PE
4988 * keyboard.c (read_char): Remove unused var.
4989
eb3f1cc8
PE
4990 * eval.c: Port to Windows vsnprintf (Bug#8435).
4991 Include <limits.h>.
4992 (SIZE_MAX): Define if the headers do not.
4993 (verror): Do not give up if vsnprintf returns a negative count.
4994 Instead, grow the buffer. This ports to Windows vsnprintf, which
4995 does not conform to C99. Problem reported by Eli Zaretskii.
4996 Also, simplify the allocation scheme, by avoiding the need for
4997 calling realloc, and removing the ALLOCATED variable.
4998
70476b54
PE
4999 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5000
12020a9e
PE
5001 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5002 But keep the doprint source code for now, as we might revamp it
5003 and use it again (Bug#8435).
ea6c7ae6
PE
5004 * lisp.h (doprnt): Remove.
5005 * Makefile.in (base_obj): Remove doprnt.o.
5006 * deps.mk (doprnt.o): Remove.
5007
5fdb398c
PE
5008 error: Print 32- and 64-bit integers portably (Bug#8435).
5009 Without this change, on typical 64-bit hosts error ("...%d...", N)
5010 was used to print both 32- and 64-bit integers N, which relied on
5011 undefined behavior.
5012 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5013 New macro.
5014 * lisp.h (error, verror): Mark as printf-like functions.
5015 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5016 Report overflow in size calculations when allocating printf buffer.
5017 Do not truncate output string at its first null byte.
5018 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5019 Truncate the output at a character boundary, since vsnprintf does not
5020 do that.
5021 * charset.c (check_iso_charset_parameter): Convert internal
5022 character to string before calling 'error', since %c now has the
5023 printf meaning.
5024 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5025 overflow when computing char to be passed to 'error'. Do not
5026 pass Lisp_Object to 'error'; pass the integer instead.
5027 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5028 formatted with plain %d.
5029
b189fa66
PE
5030 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5031
bff87ef0
PE
5032 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5033
7e2cac20
PE
5034 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5035
ce4d90b5
PE
5036 * xterm.c (x_catch_errors): Remove duplicate declaration.
5037
266c9547
PE
5038 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5039
79c49ad2
PE
5040 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5041
368f4090
JM
50422011-04-10 Jim Meyering <meyering@redhat.com>
5043
5044 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5045 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5046 return ssize_t not "int", and use size_t as the buffer length.
5047 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5048 * gnutls.h: Update declarations.
5049 * process.c (read_process_output): Use ssize_t, to match.
5050 (send_process): Likewise.
5051
a32d4040
CY
50522011-04-09 Chong Yidong <cyd@stupidchicken.com>
5053
5054 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5055
8546720e 50562011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5057
04f2d78b
CB
5058 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5059 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5060
8546720e
GM
5061 * xterm.c (handle_one_xevent):
5062 * xmenu.c (create_and_show_popup_menu):
5063 * xselect.c (x_decline_selection_request)
5064 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5065
0a2f5c1a 50662011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5067
5068 Fix some uses of `int' instead of EMACS_INT.
5069 * search.c (string_match_1, fast_string_match)
5070 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5071 (scan_buffer, find_next_newline_no_quit)
5072 (find_before_next_newline, search_command, Freplace_match)
5073 (Fmatch_data): Make some `int' variables be EMACS_INT.
5074
5075 * xdisp.c (display_count_lines): 3rd argument and return value now
5076 EMACS_INT. All callers changed.
5077 (pint2hrstr): Last argument is now EMACS_INT.
5078
5079 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5080 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5081 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5082 (decode_coding_utf_16, decode_coding_emacs_mule)
5083 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5084 (decode_coding_ccl, decode_coding_charset)
5085 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5086 (decode_coding_iso_2022, decode_coding_emacs_mule)
5087 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5088 <char_offset, last_offset>: Declare EMACS_INT.
5089 (encode_coding_utf_8, encode_coding_utf_16)
5090 (encode_coding_emacs_mule, encode_invocation_designation)
5091 (encode_designation_at_bol, encode_coding_iso_2022)
5092 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5093 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5094 Declare EMACS_INT.
5095 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5096 (encode_invocation_designation): Last argument P_NCHARS is now
5097 EMACS_INT.
5098 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5099 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5100
5101 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5102 All users changed.
5103
5104 * ccl.c (Fccl_execute_on_string): Declare some variables
5105 EMACS_INT.
5106
8546720e 51072011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5108
5109 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5110
4e19a977
CS
51112011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5112
5113 * process.c (Fformat_network_address): Doc fix.
5114
87302331
R
51152011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5116
5117 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5118
cbb59342
CY
51192011-04-08 Chong Yidong <cyd@stupidchicken.com>
5120
5121 * keyboard.c (read_char): Call Lisp function help-form-show,
5122 instead of using internal_with_output_to_temp_buffer.
5123 (Qhelp_form_show): New var.
e0d38eeb 5124 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5125
5126 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5127
5128 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5129
e67a13ab
CY
51302011-04-06 Chong Yidong <cyd@stupidchicken.com>
5131
04f2d78b
CB
5132 * process.c (Flist_processes): Remove to Lisp.
5133 (list_processes_1): Delete.
e67a13ab 5134
973f782d
EZ
51352011-04-06 Eli Zaretskii <eliz@gnu.org>
5136
7c106b1e
EZ
5137 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5138
973f782d
EZ
5139 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5140
41cf7d1a 51412011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5142
ca23cc88
PE
5143 Fix more problems found by GCC 4.6.0's static checks.
5144
f390e2d5
PE
5145 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5146
42eea0d0
PE
5147 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5148
b69769da 5149 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5150
f9541e84
PE
5151 * xdisp.c (vmessage): Mark as a printf-like function.
5152
13841b55
PE
5153 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5154
c136c10f
PE
5155 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5156
5e2d4a30
PE
5157 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5158 printf-like functions.
5159 (tiff_load): Add casts to remove these marks before passing them
5160 to system-supplied API.
5161
583f48b9
PE
5162 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5163
b25d760e
PE
5164 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5165 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5166 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5167 directly, rather than having caller test rule sign. This avoids
5168 some unnecessary tests.
5169 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5170 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5171 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5172
bc7b6697 5173 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5174 (xfont_open): Avoid unnecessary tests.
bc7b6697 5175
27ccc379
PE
5176 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5177
dcd5c89a
PE
5178 * composite.h, composite.c (composition_gstring_put_cache):
5179 Use EMACS_INT, not int, for length.
5180
b13a45c6
PE
5181 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5182 breaking out part of COMPOSITION_DECODE_RULE.
5183 (COMPOSITION_DECODE_RULE): Use it.
5184 * composite.c (get_composition_id): Remove unused local vars,
5185 by using the new macro.
5186
1e792e4d
PE
5187 * textprop.c (set_text_properties_1): Change while to do-while,
5188 since the condition is always true at first.
5189
dc6c6455 5190 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5191 (interval_deletion_adjustment): Return unsigned value.
5192 All uses changed.
dc6c6455 5193
aba7731a
PE
5194 * process.c (list_processes_1, create_pty, read_process_output):
5195 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5196 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5197 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5198 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5199 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5200
fdfc4bf3
PE
5201 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5202
fca8fe46 5203 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5204 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5205
06a0259a 5206 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5207 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5208 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5209
e7b9e80f
PE
5210 * print.c (print_error_message): Avoid int overflow.
5211
56201685
PE
5212 * font.c (font_list_entities): Redo for clarity,
5213 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5214
78834453 5215 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5216 (font_score): Avoid potential overflow in diff calculation.
78834453 5217
0bc0b309 5218 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5219 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5220
e610eaca
PE
5221 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5222
b895abce
PE
5223 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5224 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5225 can always succeed if overflow has undefined behavior.
5226
1f1d9321 5227 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5228 (wordify): Omit three unnecessary tests.
1f1d9321 5229
c59478bc
PE
5230 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5231 All callers changed. This avoids the need for an unused var.
5232
79b73827
PE
5233 * casefiddle.c (casify_region): Remove var that is set but not used.
5234
a4db5dfe
PE
5235 * dired.c (file_name_completion): Remove var that is set but not used.
5236
43aae36e
PE
5237 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5238
2a47c44d 5239 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5240 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5241
a37c69bf
PE
5242 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5243 Check for integer overflow on size calculations.
5244
328ab8e7
PE
5245 * buffer.c (Fprevious_overlay_change): Remove var that is set
5246 but not used.
5247
e5a2a5cb
PE
5248 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5249 Remove vars that are set but not used.
8d84a6eb 5250 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5251 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5252
a60e5f68
PE
5253 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5254
f661cb61 5255 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5256 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5257
f0397f5a
PE
5258 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5259 that are set but not used.
5260
8664db06 5261 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5262 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5263
6abdaa4a
PE
5264 * xselect.c (x_get_local_selection, x_handle_property_notify):
5265 Remove vars that are set but not used.
5266
0ce7538d 5267 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5268 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5269
9ae848fc
PE
5270 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5271 Remove var that is set but not used.
0b918413
PE
5272 (scroll_bar_windows_size): Now size_t, not int.
5273 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5274 Check for overflow.
9ae848fc 5275
a5a62657
PE
5276 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5277 (map_tty_color) [!defined MSDOS]: Likewise.
5278
5c5cdd39
PE
5279 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5280
66ebf983
PE
5281 * coding.c: Remove vars that are set but not used.
5282 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5283 All callers changed.
5284 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5285 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5286 (decode_coding_charset): Remove vars that are set but not used.
5287
1be4d761
PE
5288 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5289 that is set but not used.
5290
47553fa8
PE
5291 * print.c (print_object): Remove var that is set but not used.
5292
1f7196bf 5293 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5294 The gnulib version avoids calling malloc in the usual case,
5295 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5296 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5297 * filelock.c (current_lock_owner): Likewise.
5298 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5299 * sysdep.c: Include allocator.h, careadlinkat.h.
5300 (emacs_no_realloc_allocator): New static constant.
5301 (emacs_readlink): New function.
fdb61804
PE
5302 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5303 ../lib/careadlinkat.h.
d1fdcab7 5304
f84c17c7
SM
53052011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5306
5307 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5308 first non-nil return value).
5309
ef3862ad
JD
53102011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5311
5312 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5313 if not defined (Bug#8403).
5314
376a7006
JB
53152011-04-02 Juanma Barranquero <lekktu@gmail.com>
5316
5317 * xdisp.c (display_count_lines): Remove parameter `start',
5318 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5319 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5320 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5321 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5322 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5323 and thereabouts. All callers changed.
5324 (get_per_char_metric): Remove parameter `f', unused since
5325 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5326
6ca3801d
JM
53272011-04-02 Jim Meyering <meyering@redhat.com>
5328
5329 do not dereference NULL upon failed strdup
5330 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5331 (ns_get_family): Likewise.
5332
d8e2b5ba
JB
53332011-04-02 Juanma Barranquero <lekktu@gmail.com>
5334
5335 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5336
8c74fcbd
JD
53372011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5338
5339 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5340 later (Bug#8403).
5341
7200d79c
SM
53422011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5343
03408648 5344 Add lexical binding.
7200d79c 5345
03408648
SM
5346 * window.c (Ftemp_output_buffer_show): New fun.
5347 (Fsave_window_excursion):
5348 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5349
5350 * lread.c (lisp_file_lexically_bound_p): New function.
5351 (Fload): Bind Qlexical_binding.
5352 (readevalloop): Remove `evalfun' arg.
5353 Bind Qinternal_interpreter_environment.
5354 (Feval_buffer): Bind Qlexical_binding.
5355 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5356 Mark as dynamic.
5357 (syms_of_lread): Declare `lexical-binding'.
5358
5359 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5360
5361 * keyboard.c (eval_dyn): New fun.
5362 (menu_item_eval_property): Use it.
ca105506
SM
5363
5364 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5365
03408648
SM
5366 * fns.c (concat, mapcar1): Accept byte-code-functions.
5367
5368 * eval.c (Fsetq): Handle lexical vars.
5369 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5370 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5371 (FletX, Flet): Obey lexical binding.
5372 (Fcommandp): Handle closures.
5373 (Feval): New `lexical' arg.
5374 (eval_sub): New function extracted from Feval. Use it almost
5375 everywhere where Feval was used. Look up vars in lexical env.
5376 Handle closures.
5377 (Ffunctionp): Move from subr.el.
5378 (Ffuncall): Handle closures.
5379 (apply_lambda): Remove `eval_flags'.
5380 (funcall_lambda): Handle closures and new byte-code-functions.
5381 (Fspecial_variable_p): New function.
5382 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5383 but without exporting it to Lisp.
23aba0ea 5384
23aba0ea 5385 * doc.c (Fdocumentation, store_function_docstring):
03408648 5386 * data.c (Finteractive_form): Handle closures.
23aba0ea 5387
03408648
SM
5388 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5389 interactive spec.
ba83908c 5390
04f2d78b
CB
5391 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5392 New byte-codes.
03408648
SM
5393 (exec_byte_code): New function extracted from Fbyte_code to handle new
5394 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5395
03408648 5396 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5397
03408648 5398 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5399
e2abce01
JB
54002011-03-31 Juanma Barranquero <lekktu@gmail.com>
5401
5402 * xdisp.c (redisplay_internal): Fix prototype.
5403
63696a73 54042011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5405
63696a73 5406 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5407 (try_scrolling): Use it when setting scroll_limit.
5408 Limit scrolling to 100 screen lines.
63696a73
EZ
5409 (redisplay_window): Even when falling back on "recentering",
5410 position point in the window according to scroll-conservatively,
5411 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5412
5413 (try_scrolling): When point is above the window, allow searching
5414 as far as scroll_max, or one screenful, to compute vertical
5415 distance from PT to the scroll margin position. This prevents
5416 try_scrolling from unnecessarily failing when
5417 scroll-conservatively is set to a value slightly larger than the
5418 window height. Clean up the case of PT below the margin at bottom
5419 of window: scroll_max can no longer be INT_MAX. When aggressive
5420 scrolling is in use, don't let point enter the opposite scroll
5421 margin as result of the scroll.
5422 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5423 threshold of 100 lines for never-recentering scrolling.
5424
e4cc2dfc
JB
54252011-03-31 Juanma Barranquero <lekktu@gmail.com>
5426
5427 * dispextern.h (move_it_by_lines):
5428 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5429 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5430 (message_log_check_duplicate): Remove parameters `prev_bol' and
5431 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5432 (redisplay_internal): Remove parameter `preserve_echo_area',
5433 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5434
5435 * indent.c (Fvertical_motion):
5436 * window.c (window_scroll_pixel_based, Frecenter):
5437 Don't pass `need_y_p' to `move_it_by_lines'.
5438
1c470562
SM
54392011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5440
44f230aa
SM
5441 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5442 steal a few bits to be more compact.
5443 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5444 Remove unneeded casts.
5445
1c470562
SM
5446 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5447
888adce9
ZK
54482011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5449
5450 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5451 binding" message (bug#7967).
5452
f838ed7b
PE
54532011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5454
77861b95
PE
5455 Fix more problems found by GCC 4.6.0's static checks.
5456
de6dbc14
PE
5457 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5458 Remove unused local var.
5459
f838ed7b
PE
5460 * editfns.c (Fmessage_box): Remove unused local var.
5461
792c7b2b
PE
5462 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5463 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5464 Omit unused local vars.
c499e557 5465 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5466 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5467 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5468 Omit unused local var.
5469
ba0165e1
PE
5470 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5471 Don't assume string length fits in int.
32ad8845 5472 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5473 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5474
3c59b4c9
PE
5475 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5476 instead of alloca (Bug#8344).
5477
a3eed478 5478 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5479 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5480
eb4d412d
PE
5481 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5482
1658b401
PE
5483 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5484 concerns.
5485
5486 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5487
5488 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5489
9a2c6e05
PE
5490 * keyboard.c (syms_of_keyboard): Use the same style as later
5491 in this function when indexing through an array. This also
5492 works around GCC bug 48267.
5493
03d0a109
PE
5494 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5495
44f730c8
PE
5496 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5497
fe75f926
PE
5498 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5499 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5500
ffa8c828
PE
5501 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5502 This avoids undefined behavior on integer overflow, and is a bit
5503 more convenient anyway since it is compared to a size_t variable.
5504
c5101a77
PE
5505 Variadic C functions now count arguments with size_t, not int.
5506 This avoids an unnecessary limitation on 64-bit machines, which
5507 caused (substring ...) to crash on large vectors (Bug#8344).
5508 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5509 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5510 All variadic functions and their callers changed accordingly.
c5101a77
PE
5511 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5512 * data.c (arith_driver, float_arith_driver): Likewise.
5513 * editfns.c (general_insert_function): Likewise.
5514 * eval.c (struct backtrace.nargs, interactive_p)
5515 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5516 (funcall_lambda, mark_backtrace): Likewise.
5517 * fns.c (concat): Likewise.
5518 * frame.c (x_set_frame_parameters): Likewise.
5519 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5520 0 if not found, not -1. All callers changed.
5521
dd3f25f7
PE
5522 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5523 (stack_copy_size): Now size_t, not int.
5524 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5525
461c2ab9
JB
55262011-03-28 Juanma Barranquero <lekktu@gmail.com>
5527
5528 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5529 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5530 All callers changed.
5531
5532 * lisp.h (multibyte_char_to_unibyte):
5533 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5534 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5535 * character.h (CHAR_TO_BYTE8):
5536 * cmds.c (internal_self_insert):
5537 * editfns.c (general_insert_function):
5538 * keymap.c (push_key_description):
5539 * search.c (Freplace_match):
5540 * xdisp.c (message_dolog, set_message_1): All callers changed.
5541
f6d62986
SM
55422011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5543
5544 * keyboard.c (safe_run_hook_funcall): New function.
5545 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5546 don't set the hook to nil, but remove the offending function instead.
5547 (Qcommand_hook_internal): Remove, unused.
5548 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5549 Vcommand_hook_internal.
5550
5551 * eval.c (enum run_hooks_condition): Remove.
5552 (funcall_nil, funcall_not): New functions.
5553 (run_hook_with_args): Call each function through a `funcall' argument.
5554 Remove `cond' argument, now redundant.
5555 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5556 (Frun_hook_with_args_until_failure): Adjust accordingly.
5557 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5558
1db5b1ad
JB
55592011-03-28 Juanma Barranquero <lekktu@gmail.com>
5560
5561 * dispextern.h (string_buffer_position): Remove declaration.
5562
5563 * print.c (strout): Remove parameter `multibyte', unused since
5564 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5565
5566 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5567 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5568 All callers changed.
5569
5570 * w32.c (_wsa_errlist): Use braces for struct initializers.
5571
5572 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5573 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5574 All callers changed.
5575 (string_buffer_position): Likewise. Also, make static (it's never
5576 used outside xdisp.c).
5577 (cursor_row_p): Remove parameter `w', unused since
5578 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5579 (decode_mode_spec): Remove parameter `precision', introduced during
5580 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5581 All callers changed.
5582
5ffb62aa
JD
55832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5584
5585 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5586
461c2ab9 55872011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5588
5589 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5590 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5591 (ns_update_auto_hide_menu_bar): New functions.
5592 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5593 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5594 ns_constrain_all_frames.
5595 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5596 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5597
5c380ffb
JD
55982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5599
5600 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5601
9af30bdf
GM
56022011-03-27 Glenn Morris <rgm@gnu.org>
5603
5604 * syssignal.h: Replace RETSIGTYPE with void.
5605 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5606 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5607 Replace SIGTYPE with void everywhere.
5608 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5609 * s/template.h (SIGTYPE): Remove commented out definition.
5610
e2abce01
JB
56112011-03-26 Eli Zaretskii <eliz@gnu.org>
5612
5613 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5614 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5615
f868cd8a
JB
56162011-03-26 Juanma Barranquero <lekktu@gmail.com>
5617
59eb0929
JB
5618 * w32.c (read_unc_volume): Use parameter `henum', instead of
5619 global variable `wget_enum_handle'.
5620
5621 * keymap.c (describe_vector): Remove parameters `indices' and
5622 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5623 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5624
f868cd8a
JB
5625 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5626
5627 * keyboard.c (timer_check): Remove parameter `do_it_now',
5628 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5629 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5630 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5631
5632 * keyboard.c (read_char):
5633 * w32menu.c (w32_menu_display_help):
5634 * xmenu.c (show_help_event, menu_help_callback):
5635 Adjust calls to `show_help_echo'.
5636
5637 * gtkutil.c (xg_maybe_add_timer):
5638 * keyboard.c (readable_events):
5639 * process.c (wait_reading_process_output):
5640 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5641
5642 * insdel.c (adjust_markers_gap_motion):
5643 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5644 (gap_left, gap_right): Don't call it.
5645
2ecf6fdb
CY
56462011-03-25 Chong Yidong <cyd@stupidchicken.com>
5647
5648 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5649 incurred during fontification.
5650
6b1f9ba4
JB
56512011-03-25 Juanma Barranquero <lekktu@gmail.com>
5652
5653 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5654 (DEFVAR_PER_BUFFER): Don't pass it.
5655
5656 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5657 (scrolling_window): Don't pass it.
5658
0f4a96b5
JB
56592011-03-25 Juanma Barranquero <lekktu@gmail.com>
5660
5661 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5662
5663 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5664 and `suffix'.
5665 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5666 of variables specific to SELinux and computation of `encoded_absname'.
5667
5668 * image.c (XPutPixel): Remove unused variable `height'.
5669
5670 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5671
5672 * unexw32.c (get_section_info): Remove unused variable `section'.
5673
5674 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5675 (system_process_attributes): Remove unused variable `sess'.
5676 (sys_read): Remove unused variable `err'.
5677
5678 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5679 (w32_wnd_proc): Remove unused variable `isdead'.
5680 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5681 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5682 (x_create_tip_frame): Remove unused variable `tem'.
5683
5684 * w32inevt.c (w32_console_read_socket):
5685 Remove unused variable `no_events'.
5686
5687 * w32term.c (x_draw_composite_glyph_string_foreground):
5688 Remove unused variable `width'.
5689
1149507c
JB
56902011-03-24 Juanma Barranquero <lekktu@gmail.com>
5691
5692 * w32term.c (x_set_glyph_string_clipping):
5693 Don't pass uninitialized region to CombineRgn.
5694
9c88f339
JB
56952011-03-23 Juanma Barranquero <lekktu@gmail.com>
5696
5697 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5698 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5699 (Fx_close_connection): Remove unused variable `i'.
5700
5701 * w32font.c (w32font_draw): Return number of glyphs.
5702 (w32font_open_internal): Remove unused variable `i'.
5703 (w32font_driver): Add missing initializer.
5704
5705 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5706 (fill_in_menu): Remove unused variable `items_added'.
5707
5708 * w32term.c (last_mouse_press_frame): Remove static global variable.
5709 (w32_clip_to_row): Remove unused variable `f'.
5710 (x_delete_terminal): Remove unused variable `i'.
5711
5712 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5713 (NOTHING): Remove unused static global variable.
5714 (uniscribe_check_otf): Remove unused variable `table'.
5715 (uniscribe_font_driver): Add missing initializers.
5716
dee091a3
JD
57172011-03-23 Julien Danjou <julien@danjou.info>
5718
5719 * term.c (Fsuspend_tty, Fresume_tty):
5720 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5721 * window.c (temp_output_buffer_show):
5722 * insdel.c (signal_before_change):
5723 * frame.c (Fhandle_switch_frame):
5724 * fileio.c (Fdo_auto_save):
5725 * emacs.c (Fkill_emacs):
5726 * editfns.c (save_excursion_restore):
5727 * cmds.c (internal_self_insert):
5728 * callint.c (Fcall_interactively):
5729 * buffer.c (Fkill_all_local_variables):
5730 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5731 Use Frun_hooks.
0f4a96b5 5732 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5733 unconditionnaly since it does the check itself.
5734
2c520ab5 57352011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5736
c9c49752
PE
5737 Fix more problems found by GCC 4.5.2's static checks.
5738
8abc3f12
PE
5739 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5740 the first time through the loop, since we know p0 < p1 then.
5741 This also avoids a gcc -Wstrict-overflow warning.
5742
a2d26660
PE
5743 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5744 leading to a memory leak, possible in functions like
5745 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5746 of objects (Bug#8318).
a2d26660 5747
916c72e9
PE
5748 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5749 that could (at least in theory) be that large.
5750
19ab8a18
PE
5751 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5752 This is less likely to overflow, and avoids undefined behavior if
5753 overflow does occur. All callers changed. Use strtoul to scan
5754 for the unsigned long integer.
b7cbbd6f
PE
5755 (pint2hrstr): Simplify and tune code slightly.
5756 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5757
f0641eff
PE
5758 * scroll.c (do_scrolling): Work around GCC bug 48228.
5759 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5760
7f650bb9
PE
5761 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5762 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5763 (validate_x_resource_name): Simplify count usage.
5764 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5765
37dd57d1
PE
5766 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5767 fail (Bug#8306).
81e56e61 5768
699979fc 5769 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5770
401bf9b4
PE
5771 * process.c (Fmake_network_process): Use socklen_t, not int,
5772 where POSIX says socklen_t is required in portable programs.
5773 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5774 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5775 (Fmake_network_process, server_accept_connection):
5776 (wait_reading_process_output, read_process_output):
5777 Likewise.
5778
b93aacde
PE
5779 * process.c: Rename or move locals to avoid shadowing.
5780 (list_processes_1, Fmake_network_process):
5781 (read_process_output_error_handler, exec_sentinel_error_handler):
5782 Rename or move locals.
4dc343ee 5783 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5784 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5785 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5786 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5787 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5788
af8a867c 5789 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5790 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5791 Include tparam.h instead, since it declares them.
af8a867c
PE
5792 * cm.h (PC): Remove extern decl; tparam.h now does this.
5793 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5794 * terminfo.c: Include tparam.h, to check interfaces.
5795 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5796 (tparam): Adjust signature to match interface in tparam.h;
5797 this removes some undefined behavior. Check that outstring and len
5798 are zero, which they always are with Emacs.
5799 * tparam.h (PC, BC, UP): New extern decls.
5800
0248044d 5801 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5802 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5803
8ff096c1 5804 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5805 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5806 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5807 (ftfont_list): Remove unused local.
49eaafba
PE
5808 (get_adstyle_property, ftfont_pattern_entity):
5809 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5810 Rename locals to avoid shadowing.
8ff096c1 5811
e2be39f6
PE
5812 * xfont.c (xfont_list_family): Mark var as initialized.
5813
c9735e30
PE
5814 * xml.c (make_dom): Now static.
5815
8f5201ae
PE
5816 * composite.c (composition_compute_stop_pos): Rename local to
5817 avoid shadowing.
b246f932
PE
5818 (composition_reseat_it): Remove unused locals.
5819 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5820 (composition_update_it): Mark var as initialized.
11b61122
PE
5821 (find_automatic_composition): Mark vars as initialized,
5822 with a FIXME (Bug#8290).
8f5201ae 5823
760fbc2c
PE
5824 character.h: Rename locals to avoid shadowing.
5825 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5826 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5827 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5828 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5829 to avoid shadowing.
5830
ff08eb85
PE
5831 * textprop.c (property_change_between_p): Remove; unused.
5832
fc7bf025
PE
5833 * intervals.c (interval_start_pos): Now static.
5834
235d7abc
PE
5835 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5836
44f230aa
SM
5837 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5838 Rename locals to avoid shadowing.
3e7d6594 5839
50060332
PE
5840 * sound.c (wav_play, au_play, Fplay_sound_internal):
5841 Fix pointer signedness.
d01f234b 5842 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5843 (wav_play): Initialize a variable to 0, to prevent undefined
5844 behavior (Bug#8278).
50060332 5845
c4fc4e30
PE
5846 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5847
918436ed
PE
5848 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5849
c939f91b
PE
5850 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5851 clobbering (Bug#8298).
b9c7f648
PE
5852 * sysdep.c (sys_subshell): Likewise.
5853 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5854
6bd8c144
PE
5855 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5856 This should get cleaned up, so that child_setup has the
5857 same signature on all platforms.
5858
7710357c 5859 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5860 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5861
c59da222
CY
58622011-03-22 Chong Yidong <cyd@stupidchicken.com>
5863
5864 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5865 not to be necessary, and produces flickering.
5866
66b87493
GM
58672011-03-20 Glenn Morris <rgm@gnu.org>
5868
5869 * config.in: Remove file.
5870
45b6f6d5
JB
58712011-03-20 Juanma Barranquero <lekktu@gmail.com>
5872
5873 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5874 are now in src/globals.h.
5875 (syms_of_minibuf): Remove spurious & from previous change.
5876
3ec03f7e
LL
58772011-03-20 Leo <sdl.web@gmail.com>
5878
5879 * minibuf.c (completing-read-function): New variable.
5880 (completing-read-default): Rename from completing-read.
5881 (completing-read): Call completing-read-function.
5882
b14e3e21
CY
58832011-03-19 Juanma Barranquero <lekktu@gmail.com>
5884
5885 * xfaces.c (Fx_load_color_file):
5886 Read color file from absolute filename (bug#8250).
5887
f2b726e6
JB
58882011-03-19 Juanma Barranquero <lekktu@gmail.com>
5889
5890 * makefile.w32-in: Update dependencies.
5891
09f6ff02
EZ
58922011-03-17 Eli Zaretskii <eliz@gnu.org>
5893
5894 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5895
29a6015a
PE
58962011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5897
a3a6c54e
PE
5898 Fix more problems found by GCC 4.5.2's static checks.
5899
b766f867
PE
5900 * process.c (make_serial_process_unwind, send_process_trap):
5901 (sigchld_handler): Now static.
5902
be02381c
PE
5903 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5904 That way, the code declares only the vars that it needs.
5905 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5906 * s/cygwin.h (PTY_ITERATION): Likewise.
5907 * s/darwin.h (PTY_ITERATION): Likewise.
5908 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5909
57048744
PE
5910 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5911 * process.c (allocate_pty): Don't declare stb unless it's needed.
5912
7914961c 5913 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5914 (CONSTANTLIM): Remove; unused.
5915 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5916 Define only if needed.
7914961c 5917
b3967b18
PE
5918 * unexelf.c (unexec): Name an expression,
5919 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5920 Use a different way to cause a compilation error if anyone uses
5921 n rather than nn, a way that does not involve shadowing.
73366a00 5922 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5923
29a6015a
PE
5924 * deps.mk (unexalpha.o): Remove; unused.
5925
43cfc33e 5926 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5927 * unexec.h: New file.
ce701a33
PE
5928 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5929 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5930 Depend on unexec.h.
5931 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5932 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5933 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5934 Change as necessary to match prototype in unexec.h.
ce701a33 5935
01f44d5a
PE
5936 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5937 shadowing.
4f63c6bb 5938 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5939
a6670b0b
PE
5940 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5941 Rename locals to avoid shadowing.
5942
cef2010d 5943 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5944 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5945
d4d7173a
PE
5946 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5947
f08b802a
PE
5948 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5949 warning when compiling print.c.
5950
3ddb0639
PE
5951 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5952 instead of using an uninitialized var.
5ad03b97 5953 (font_sort_entities): Mark var as initialized.
3ddb0639 5954
170a2692
PE
5955 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5956
e663c700
PE
5957 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5958 pointers to constants.
89bc529a 5959 (font_parse_fcname): Remove unused vars.
7b81e2d0 5960 (font_delete_unmatched): Now static.
ea838e10 5961 (font_get_spec): Remove; unused.
13a547c6
PE
5962 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5963 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5964 Rename or move locals to avoid shadowing.
e663c700 5965
2a80c887 5966 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5967 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5968
1384fa33 5969 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5970 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5971
8b2c52e9
PE
5972 * alloc.c (mark_backtrace): Move decl from here ...
5973 * lisp.h: ... to here, so that it can be checked.
5974
475545b5 5975 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5976 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5977 (lisp_indirect_variable): Name an expression,
5978 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5979 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5980
b1349114 5981 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5982 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5983 Use const pointer when appropriate.
b1349114 5984
a2928364
PE
5985 * lisp.h (get_system_name, get_operating_system_release):
5986 Move decls here, to check interfaces.
5987 * process.c (get_operating_system_release): Move decl to lisp.h.
5988 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5989 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5990 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5991 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5992 (Fformat_time_string, Fencode_time, Finsert_char):
5993 (Ftranslate_region_internal, Fformat):
5994 Rename or remove local vars to avoid shadowing.
9710023e 5995 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5996
a415e694
PE
5997 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5998 avoid shadowing.
5999
8ef4622d
PE
6000 * lisp.h (eassert): Check that the argument compiles, even if
6001 ENABLE_CHECKING is not defined.
6002
946f9a5b
PE
6003 * data.c (Findirect_variable): Name an expression, to avoid
6004 gcc -Wbad-function-cast warning.
112396d6 6005 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6006 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6007 (Fmake_variable_buffer_local, Fmake_local_variable):
6008 Mark variables as initialized.
52746918 6009 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6010
e5aab7e7 6011 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6012 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6013 Rename locals to avoid shadowing.
dff45157
PE
6014 (mark_stack): Move local variables into the #ifdef region where
6015 they're used.
7bc26fdb
PE
6016 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6017 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6018 needed otherwise.
6019 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6020 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6021 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6022
e5aab7e7
PE
6023 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6024 avoids undefined behavior in theory.
6025
4da60324
PE
6026 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6027
88043301
PE
6028 Use functions, not macros, for up- and down-casing (Bug#8254).
6029 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6030 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6031 to use the following functions instead of these macros.
6032 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6033 EMACS_INT, since callers assume the returned value fits in int.
6034 (upcase1): Likewise, for UPCASE_TABLE.
6035 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6036 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6037 the race-condition problem in the old DOWNCASE.
88043301 6038
19ed5445
PE
6039 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6040 Rename locals to avoid shadowing.
6041 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6042 (regex_compile, re_search_2, re_match_2_internal):
6043 Remove unused local vars.
952db0d7
PE
6044 (FREE_VAR): Rewrite so as not to use empty "else",
6045 which gcc can warn about.
da053e48 6046 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6047 (RETALLOC_IF): Define only if needed.
6048 (WORDCHAR_P): Likewise. This one is never needed, but is used
6049 only in a comment talking about a compiler bug, so put inside
6050 the #if 0 of that comment.
6051 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6052 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6053 Remove; unused.
19ed5445 6054
1f3561e4 6055 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6056 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6057 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6058
ded6f8f7
PE
6059 * search.c (simple_search): Remove unused var.
6060
dbd37a95
PE
6061 * dired.c (compile_pattern): Move decl from here ...
6062 * lisp.h: ... to here, so that it can be checked.
6063 (struct re_registers): New forward decl.
6064
7e47afad
PE
6065 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6066
85f24f61
PE
6067 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6068 All uses changed.
6069 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6070 Rename locals to avoid shadowing.
5671df8f 6071 (Fvertical_motion): Mark locals as initialized.
85f24f61 6072
181aa2be 6073 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6074 (casify_region): Mark local as initialized.
181aa2be 6075
930d429c
PE
6076 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6077
7082eac6
PE
6078 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6079 New macros, so that the caller can use some names other than
6080 gcpro1, gcpro2, etc.
6081 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6082 of the new macros.
6083 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6084 argument, for consistency with GCPRO2_VAR, etc: it is now the
6085 prefix of the variable, not the variable itself. All uses
6086 changed.
38b2c076
PE
6087 * dired.c (directory_files_internal, file_name_completion):
6088 Rename locals to avoid shadowing.
6089
15206ed9
PE
6090 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6091 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6092 dired.c's scmp function, had undefined behavior.
6093 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6094 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6095 * buffer.h: ... to here, because these macros use current_buffer,
6096 and the new implementation with inline functions needs to have
6097 current_buffer in scope now, rather than later when the macros
6098 are used.
6099 (downcase, upcase1): New static inline functions.
6100 (DOWNCASE, UPCASE1): Reimplement using these functions.
6101 This avoids undefined behavior in expressions like
6102 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6103 from race conditions in accessing the global variables
6104 case_temp1 and case_temp2.
6105 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6106 * lisp.h (case_temp1, case_temp2): Remove their decls.
6107 * character.h (ASCII_CHAR_P): Move from here ...
6108 * lisp.h: ... to here, so that the inline functions mentioned
6109 above can use them.
6110
4a6bea26
PE
6111 * dired.c (directory_files_internal_unwind): Now static.
6112
f14b7e14
PE
6113 * fileio.c (file_name_as_directory, directory_file_name):
6114 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6115 Now static.
2893f146
PE
6116 (file_name_as_directory): Use const pointers when appropriate.
6117 (Fexpand_file_name): Likewise. In particular, newdir might
6118 point at constant storage, so make it a const pointer.
fd4ead52 6119 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6120 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6121 signedness issues.
f839df0c
PE
6122 (Fset_file_times, Finsert_file_contents, auto_save_error):
6123 Rename locals to avoid shadowing.
f14b7e14 6124
5716756e 6125 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6126 (Ftry_completion, Fall_completions): Rename or remove locals
6127 to avoid shadowing.
5716756e 6128
b4c3046a
PE
6129 * marker.c (bytepos_to_charpos): Remove; unused.
6130
b45db522
PE
6131 * lisp.h (verify_bytepos, count_markers): New decls,
6132 so that gcc does not warn that these functions aren't declared.
6133
85876d07
PE
6134 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6135 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6136 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6137 (copy_text): Remove unused local var.
85876d07 6138
03d78a21 6139 * filelock.c (within_one_second): Now static.
b3dd38ab 6140 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6141
5df8f01b
PE
6142 * buffer.c (fix_overlays_before): Mark locals as initialized.
6143 (fix_start_end_in_overlays): Likewise. This function should be
6144 simplified by using pointers-to-pointers, but that's a different
6145 matter.
b1d876f1 6146 (switch_to_buffer_1): Now static.
8f54f30a
PE
6147 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6148 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6149
a70072c9 6150 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6151 Fix pointer signedness issue.
edced198
PE
6152 (sys_subshell): Mark local as volatile if checking for lint,
6153 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6154 (MAXPATHLEN): Define only if needed.
a70072c9 6155
a0977c44
PE
6156 * process.c (serial_open, serial_configure): Move decls from here ...
6157 * systty.h: ... to here, so that they can be checked.
6158
a884fdcc
PE
6159 * fns.c (get_random, seed_random): Move extern decls from here ...
6160 * lisp.h: ... to here, so that they can be checked.
6161
604efe86 6162 * sysdep.c (reset_io): Now static.
b8950c94 6163 (wait_for_termination_signal): Remove; unused.
604efe86 6164
38fc62d9
PE
6165 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6166 (copy_keymap_item, append_key, push_text_char_description):
6167 Now static.
1004a21a 6168 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6169 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6170 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6171 (describe_map_tree):
6172 Rename locals to avoid shadowing.
38fc62d9 6173
2f2650da
PE
6174 * keyboard.c: Declare functions static if they are not used elsewhere.
6175 (echo_char, echo_dash, cmd_error, top_level_2):
6176 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6177 (read_char, kbd_buffer_get_event, make_lispy_position):
6178 (make_lispy_event, make_lispy_movement, apply_modifiers):
6179 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6180 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6181 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6182 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6183 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6184
a053e86c 6185 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6186 (mark_kboards): Move decl here ...
6187 * alloc.c (mark_kboards): ... from here.
a053e86c 6188
4752793e
PE
6189 * lisp.h (force_auto_save_soon): New decl.
6190
74f10ca7 6191 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6192 (DEFINE_DUMMY_FUNCTION): New macro.
6193 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6194 Use it.
c03cd23f
PE
6195 (main): Add casts to avoid warnings
6196 if GCC considers string literals to be constants.
74f10ca7 6197
022e70d4
PE
6198 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6199
59d6fe83
PE
6200 * dbusbind.c: Pointer signedness fixes.
6201 (xd_signature, xd_append_arg, xd_initialize):
6202 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6203 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6204 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6205 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6206
78320123
PE
6207 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6208 if GCC considers string literals to be constants.
49cebcca 6209 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6210
35ac2a97
SM
62112011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6212
fb103ca9
SM
6213 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6214 (print_preprocess, print_object): New macro to fix last change.
6215
35ac2a97
SM
6216 * print.c (print_preprocess): Don't forget font objects.
6217
62973b41
JB
62182011-03-16 Juanma Barranquero <lekktu@gmail.com>
6219
6220 * emacs.c (USAGE3): Doc fixes.
6221
0e48bb22
AS
62222011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6223
6224 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6225 structure.
6226
7684e57b
JB
62272011-03-14 Juanma Barranquero <lekktu@gmail.com>
6228
6229 * lisp.h (VWindow_system, Qfile_name_history):
6230 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6231 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6232 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6233
6234 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6235 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6236
6237 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6238 * w32console.c (detect_input_pending, read_input_pending)
6239 (encode_terminal_code):
6240 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6241 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6242 (w32_system_caret_y, Qfile_name_history):
6243 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6244 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6245 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6246 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6247 * w32proc.c (Qlocal, report_file_error):
6248 * w32term.c (Vwindow_system, updating_frame):
6249 * w32uniscribe.c (initialized, uniscribe_font_driver):
6250 Remove unneeded extern declarations.
6251
2aa46d6c
CY
62522011-03-14 Chong Yidong <cyd@stupidchicken.com>
6253
c96bbc66 6254 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6255
cffc6f3b
CY
62562011-03-13 Chong Yidong <cyd@stupidchicken.com>
6257
6258 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6259 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6260 These macros can no longer be used for assignment.
6261
44f230aa
SM
6262 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6263 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6264 (record_buffer_markers, fetch_buffer_markers): New functions for
6265 recording and fetching special buffer markers.
6266 (set_buffer_internal_1, set_buffer_temp): Use them.
6267
6268 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6269
6270 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6271
6272 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6273 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6274
6275 * xdisp.c (hscroll_window_tree):
6276 (reconsider_clip_changes): Use PT instead of BUF_PT.
6277
d251f04b
EZ
62782011-03-13 Eli Zaretskii <eliz@gnu.org>
6279
6280 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6281 $(EMACS_ROOT)/lib/intprops.h.
6282
f0c77cd1
PE
62832011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6284
3eca4629
PE
6285 Fix more problems found by GCC 4.5.2's static checks.
6286
7c86ee98
PE
6287 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6288 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6289 (xg_free_frame_widgets): Make it clear that a local variable is
6290 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6291 (gdk_window_get_screen): Make it clear that this macro is needed
6292 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6293 (int_gtk_range_get_value): New function, which avoids a diagnostic
6294 from gcc -Wbad-function-cast.
6295 (xg_set_toolkit_scroll_bar_thumb): Use it.
6296 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6297 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6298 (get_utf8_string, xg_get_file_with_chooser):
6299 Rename locals to avoid shadowing.
6300 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6301
41729b81
PE
6302 * xgselect.c (xg_select): Remove unused var.
6303
f0c77cd1
PE
6304 * image.c (four_corners_best): Mark locals as initialized.
6305 (gif_load): Initialize transparent_p to zero (Bug#8238).
6306 Mark another local as initialized.
ec6cf4c6 6307 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6308
ce0ad53d 6309 * image.c (clear_image_cache): Now static.
d5d5a617 6310 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6311 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6312 (x_edge_detection): Remove unnecessary cast that
6313 gcc -Wbad-function-cast diagnoses.
2037898d 6314 (gif_load): Fix pointer signedness.
6ae141d6
PE
6315 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6316 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6317
33383987 63182011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6319
d32df629
PE
6320 Improve quality of tests for time stamp overflow.
6321 For example, without this patch (encode-time 0 0 0 1 1
6322 1152921504606846976) returns the obviously-bogus value (-948597
6323 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6324 reports time overflow. See
6325 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6326 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6327 * editfns.c: Include limits.h and intprops.h.
6328 (TIME_T_MIN, TIME_T_MAX): New macros.
6329 (time_overflow): Move earlier, to before first use.
6330 (hi_time, lo_time): New functions, for an accurate test for
6331 out-of-range times.
6332 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6333 (Fget_internal_run_time): Don't assume time_t fits in int.
6334 (make_time): Use list2 instead of Fcons twice.
6335 (Fdecode_time): More accurate test for out-of-range times.
6336 (check_tm_member): New function.
6337 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6338 (lisp_time_argument): Don't rely on undefined left-shift and
6339 right-shift behavior when checking for time stamp overflow.
8be6f318 6340
fe31d94c
PE
6341 * editfns.c (time_overflow): New function, refactoring common code.
6342 (Fformat_time_string, Fdecode_time, Fencode_time):
6343 (Fcurrent_time_string): Use it.
6344
8be6f318
PE
6345 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6346 * dired.c (make_time): Move to ...
6347 * editfns.c (make_time): ... here.
6348 * systime.h: Note the move.
6349
09d9db2c 63502011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6351
126bc0dc
YM
6352 * fringe.c (update_window_fringes): Remove unused variables.
6353
c47cbdfd
YM
6354 * unexmacosx.c (copy_data_segment): Also copy __got section.
6355 (Bug#8223)
6356
7ac80be9
EZ
63572011-03-12 Eli Zaretskii <eliz@gnu.org>
6358
c96bbc66 6359 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6360 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6361 Constify `char *' arguments and their references according to
6362 prototypes in tparam.h.
6363
ecb0f94d 6364 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6365
7ac80be9
EZ
6366 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6367 Adapt all references accordingly.
6368
6369 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6370
ef1fd07e
TT
63712011-03-11 Tom Tromey <tromey@redhat.com>
6372
6373 * buffer.c (syms_of_buffer): Remove obsolete comment.
6374
7ef4b50c
EZ
63752011-03-11 Eli Zaretskii <eliz@gnu.org>
6376
6377 * termhooks.h (encode_terminal_code): Declare prototype.
6378
6379 * msdos.c (encode_terminal_code): Don't declare prototype.
6380
6381 * term.c (encode_terminal_code): Now external again, used by
6382 w32console.c and msdos.c.
6383
44f230aa
SM
6384 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6385 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6386
4b1ec863 63872011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6388
1714f52b 6389 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6390
4b1ec863
PE
6391 * fringe.c (update_window_fringes): Mark locals as initialized
6392 (Bug#8227).
6393 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6394
524c7aa6
PE
6395 * alloc.c (mark_fringe_data): Move decl from here ...
6396 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6397 to check its interface.
6398 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6399
a5c0af81 6400 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6401 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6402 (fontset_font): Mark local as initialized.
a9a06e0b 6403 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6404
b4716021
PE
6405 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6406
811e9bac 6407 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6408 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6409 (x_own_selection, Fx_disown_selection_internal): Rename locals
6410 to avoid shadowing.
6411 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6412
7e3ab302
PE
6413 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6414 so that the caller can use some name other than gcpro1.
6415 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6416 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6417 (Fx_backspace_delete_keys_p):
6418 Use them to avoid shadowing, and rename vars to avoid shadowing.
6419 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6420 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6421 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6422 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6423 Remove unused locals.
7e3ab302
PE
6424 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6425 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6426 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6427 macros.
f78faa98 6428
e2b13473
PE
6429 * xterm.h (x_mouse_leave): New decl.
6430
77f23912
PE
6431 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6432 Remove unused functions.
cdf4ba58
PE
6433 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6434 (x_calc_absolute_position): Now static.
7411c686 6435 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6436 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6437 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6438 unless they are used.
38d0b34a
PE
6439 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6440 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6441 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6442 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6443 (x_error_catcher, x_connection_closed, x_error_handler):
6444 (x_error_quitter, xembed_send_message, x_iconify_frame):
6445 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6446 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6447 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6448
44f230aa
SM
6449 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6450 Rename or move locals to avoid shadowing.
6b463e58 6451 (tty_defined_color, merge_face_heights): Now static.
5967d051 6452 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6453 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6454 does not deduce is never used uninitialized.
73719eba
PE
6455 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6456 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6457
426994c3 6458 * terminal.c (store_terminal_param): Now static.
5489860b 6459
032f1620 6460 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6461 (set_frame_menubar): Remove unused local.
d4323972 6462 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6463 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6464 since they might point to immutable storage.
281585b0
PE
6465 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6466 since it's unused otherwise.
032f1620 6467
367c19e5 6468 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6469 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6470 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6471 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6472 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6473 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6474 does not deduce are never used uninitialized.
70739cbe 6475
07b48fa9
PE
6476 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6477
8868a238 6478 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6479 * window.c (window_loop, size_window):
6480 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6481
7e5cf297 6482 * window.c (display_buffer): Now static.
d6550a9f
PE
6483 (size_window): Mark variables that gcc -Wuninitialized
6484 does not deduce are never used uninitialized.
a586633d
PE
6485 * window.h (check_all_windows): New decl, to forestall
6486 gcc -Wmissing-prototypes diagnostic.
5b555da1 6487 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6488
f6095868
PE
6489 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6490 shadowing.
6491 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6492 Include <limits.h>.
6493 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6494 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6495 (load_charset_map): Mark variables that gcc -Wuninitialized
6496 does not deduce are never used uninitialized.
53df7c11 6497 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6498
f38b440c
PE
6499 * coding.c (coding_set_source, coding_set_destination):
6500 Use "else { /* comment */ }" rather than "else /* comment */;"
6501 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6502 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6503 a block, when the outer 'i' will do.
6504 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6505 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6506 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6507 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6508 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6509 Rename locals to avoid shadowing.
6510 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6511 * coding.c (emacs_mule_char, encode_invocation_designation):
6512 Now static, since they're not used elsewhere.
413bb2db 6513 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6514 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6515 (decode_coding_emacs_mule): Mark variables that gcc
6516 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6517 (detect_coding_iso_2022): Initialize a local variable that might
6518 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6519 this initialization is needed. (Bug#8211)
5f58e762
PE
6520 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6521 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6522 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6523 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6524 Remove unused macros.
f38b440c 6525
232b38b9 6526 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6527 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6528 * character.c (string_count_byte8): Likewise.
232b38b9 6529
fb90da1b
PE
6530 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6531 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6532
fb93dbc2
PE
6533 * chartab.c (copy_sub_char_table): Now static, since it's not used
6534 elsewhere.
5c156ace
PE
6535 (sub_char_table_ref_and_range, char_table_ref_and_range):
6536 Rename locals to avoid shadowing.
bbcd0949 6537 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6538
7d3b3862 6539 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6540 (BIDI_BOB): Remove unused macro.
7d3b3862 6541
6be7d3da
PE
6542 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6543 deduce are never used uninitialized.
c2ed9c8b 6544 * term.c (encode_terminal_code): Likewise.
6be7d3da 6545
75f8807f 6546 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6547
50938595
PE
6548 * tparam.h: New file.
6549 * term.c, tparam.h: Include it.
6550 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6551 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6552 Move these decls to tparam.h, and make them agree with what
6553 is actually in tparam.c. The previous trick of using incompatible
6554 decls in different modules does not conform to the C standard.
6555 All callers of tparam changed to use tparam's actual API.
6556 * tparam.c (tparam1, tparam, tgoto):
6557 Use const pointers where appropriate.
6558
fbceeba2
PE
6559 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6560 * cm.h (struct cm): Likewise.
6561 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6562 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6563 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6564 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6565 (turn_on_face, init_tty): Likewise.
6566 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6567
7f3f1250
PE
6568 * term.c (term_mouse_position): Rename local to avoid shadowing.
6569
e6ca6543
PE
6570 * alloc.c (mark_ttys): Move decl from here ...
6571 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6572
c40f8d15
AS
65732011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6574
6575 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6576
cfe0661d
JB
65772011-03-09 Juanma Barranquero <lekktu@gmail.com>
6578
6579 * search.c (compile_pattern_1): Remove argument regp, unused since
6580 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6581 (compile_pattern): Don't pass it.
6582
0afb4571
J
65832011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6584
6585 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6586 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6587 for ! HAVE_GTK3.
6588 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6589
6590 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6591
6592 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6593 gdk_window_get_screen, gdk_window_get_geometry,
6594 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6595 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6596 (xg_get_pixbuf_from_pixmap): New function.
6597 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6598 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6599 Call xg_get_pixbuf_from_pixmap instead of
6600 gdk_pixbuf_get_from_drawable.
6601 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6602 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6603 (xg_check_special_colors): Use GtkStyleContext and its functions
6604 for HAVE_GTK3.
6605 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6606 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6607 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6608 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6609 Call gtk_widget_get_preferred_size.
0afb4571
J
6610 (xg_frame_resized): gdk_window_get_geometry only takes 5
6611 parameters.
44f230aa
SM
6612 (xg_win_to_widget, xg_event_is_for_menubar):
6613 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6614 (xg_set_widget_bg): New function.
6615 (delete_cb): New function.
895009e1 6616 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6617 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6618 (xg_set_background_color): Call xg_set_widget_bg.
6619 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6620 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6621 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6622 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6623 if ! HAVE_GTK3.
6624 (update_frame_tool_bar): Call gtk_widget_hide.
6625 (xg_initialize): Use GDK_KEY_g.
6626
6627 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6628 if ! HAVE_GTK3
6629 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6630
6631 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6632 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6633 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6634
1c2cc4ef
JB
66352011-03-08 Juanma Barranquero <lekktu@gmail.com>
6636
6637 * w32xfns.c (select_palette): Check success of RealizePalette against
6638 GDI_ERROR, not zero.
6639
33383987 6640See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6641
6642;; Local Variables:
6643;; coding: utf-8
aac0c6e3
MR
6644;; End:
6645
33383987 6646 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6647
6648 This file is part of GNU Emacs.
6649
6650 GNU Emacs is free software: you can redistribute it and/or modify
6651 it under the terms of the GNU General Public License as published by
6652 the Free Software Foundation, either version 3 of the License, or
6653 (at your option) any later version.
6654
6655 GNU Emacs is distributed in the hope that it will be useful,
6656 but WITHOUT ANY WARRANTY; without even the implied warranty of
6657 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6658 GNU General Public License for more details.
6659
6660 You should have received a copy of the GNU General Public License
6661 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.