* print.c: Make symbols static if they're not exported.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
93ea6e8f
PE
12011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2
ad64fc97
PE
3 * print.c: Make symbols static if they're not exported.
4 (print_depth, new_backquote_output, being_printed, print_buffer):
5 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6 (print_interval, print_number_index, initial_stderr_stream):
7 Now static.
8 * lisp.h (Fprinc): Remove decl.
9 (debug_output_compilation_hack): Mark as externally visible.
10
adddb265
PE
11 * sysdep.c (croak): Move decl from here to syssignal.h.
12 * syssignal.h (croak): Put it here, so the API can be checked when
13 'croak' is called from dissociate_if_controlling_tty.
14
1717ede2
PE
15 * minibuf.c: Make symbols static if they're not exported.
16 (minibuf_save_list, choose_minibuf_frame): Now static.
17 * lisp.h (choose_minibuf_frame): Remove decl.
18
fa5fb2bc
PE
19 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
20
1e3890d1
PE
21 * lread.c: Make symbols static if they're not exported.
22 (read_objects, initial_obarray, oblookup_last_bucket_number):
23 Now static.
24 (make_symbol): Remove; unused.
25 * lisp.h (initial_obarray, make_symbol): Remove decls.
26
8a1414fa
PE
27 * keyboard.c: Make symbols static if they're not exported.
28 (single_kboard, recent_keys_index, total_keys, recent_keys):
29 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
30 (this_single_command_key_start, echoing, last_auto_save):
31 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
32 (command_loop, echo_now, keyboard_init_hook, help_char_p):
33 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
34 (Vlispy_mouse_stem, double_click_count):
35 Now static.
36 (force_auto_save_soon): Define only if SIGDANGER.
37 (ignore_mouse_drag_p): Now static if
38 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
39 (print_help): Remove; unused.
40 (stop_character, last_timer_event): Mark as externally visible.
41 * keyboard.h (ignore_mouse_drag_p): Declare only if
42 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
43 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
44 * lisp.h (echoing): Remove decl.
45 (force_auto_save_soon): Declare only if SIGDANGER.
46 * xdisp.c (redisplay_window): Simplify code, to make it more
47 obvious that ignore_mouse_drag_p is not accessed if !defined
48 USE_GTK && !defined HAVE_NS.
49
93ea6e8f
PE
50 * intervals.c: Make symbols static if they're not exported.
51 (merge_properties_sticky, merge_interval_right, delete_interval):
52 Now static.
53 * intervals.h (merge_interval_right, delete_interval): Remove decls.
54
b532497d
PE
552011-04-13 Paul Eggert <eggert@cs.ucla.edu>
56
77382fcc
PE
57 * insdel.c: Make symbols static if they're not exported.
58 However, leave prepare_to_modify_buffer alone. It's never
59 called from outside this function, but that appears to be a bug.
60 (combine_after_change_list, combine_after_change_buffer):
4889fc82 61 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
62 (adjust_after_replace_noundo): Remove; unused.
63 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 64 (signal_before_change): Remove decls.
77382fcc 65
9306c32e
PE
66 * indent.c (val_compute_motion, val_vmotion): Now static.
67
cd44d2eb
PE
68 * image.c: Make symbols static if they're not exported.
69 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
70 if USE_GTK.
71 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
72 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
73
ad9a7a06
PE
74 * fringe.c (standard_bitmaps): Now static.
75 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
76
81626931
PE
77 * frame.c: Make symbols static if they're not exported.
78 (x_report_frame_params, make_terminal_frame): Now static.
79 (get_frame_param): Now static, unless HAVE_NS.
80 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
81 (x_get_resource_string): Remove; not used.
82 * frame.h (make_terminal_frame, x_report_frame_params):
83 (x_get_resource_string); Remove decls.
84 (x_fullscreen_adjust): Declare only if WINDOWSNT.
85 * lisp.h (get_frame_param): Declare only if HAVE_NS.
86
239f9db9
PE
87 * font.c, fontset.c: Make symbols static if they're not exported.
88 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
89 (FACE_SUITABLE_FOR_CHAR_P): Use it.
90 * font.c (font_close_object): Now static.
91 * font.h (font_close_object): Remove.
92 * fontset.c (FONTSET_OBJLIST): Remove.
93 (free_realized_fontset) #if-0 the body, which does nothing.
94 (face_suitable_for_char_p): #if-0, as it's never called.
95 * fontset.h (face_suitable_for_char_p): Remove decl.
96 * xfaces.c (face_at_string_position): Use
97 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
98 since 0 is always ASCII.
99
dfcf3579
PE
100 * fns.c (weak_hash_tables): Now static.
101
5045092b
PE
102 * fileio.c: Make symbols static if they're not exported.
103 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
104 (Vwrite_region_annotation_buffers): Now static.
105
57a96f5c
PE
106 * eval.c: Make symbols static if they're not exported.
107 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
108 * lisp.h (backtrace_list): Remove decl.
109
35f08c38
PE
110 * emacs.c: Make symbols static if they're not exported.
111 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
112 (fatal_error_code, fatal_error_signal_hook, standard_args):
113 Now static.
114 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
115 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
116 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
117 * lisp.h (fatal_error_signal_hook): Remove decl.
118 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
119
f44bd759
PE
120 * editfns.c: Move a (normally-unused) function to its only use.
121 * editfns.c, lisp.h (get_operating_system_release): Remove.
122 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
123 worth the hassle of breaking this out.
124
b532497d
PE
125 * xterm.c: Make symbols static if they're not exported.
126 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
127 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
128 (x_destroy_window, x_delete_display):
129 Now static.
130 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
131 (x_mouse_leave): Remove; unused.
132 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
133 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
134 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
135 Remove decls.
136 (x_mouse_leave): Declare only if WINDOWSNT.
137 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
138 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
139 USE_X_TOOLKIT.
140
a25f4dfa
PE
1412011-04-12 Paul Eggert <eggert@cs.ucla.edu>
142
1675728f
PE
143 * ftxfont.c: Make symbols static if they're not exported.
144 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
145 HAVE_FREETYPE.
146 * font.h (ftxfont_driver): Likewise.
147
e4cebfca
PE
148 * xfns.c: Make symbols static if they're not exported.
149 (x_last_font_name, x_display_info_for_name):
150 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
151 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
152 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
153 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
154 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
155 (last_show_tip_args): Now static.
156 (xic_defaut_fontset, xic_create_fontsetname): Define only if
157 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
158 (x_screen_planes): Remove; unused.
159 * dispextern.h (x_screen_planes): Remove decl.
160
5bf46f05
PE
161 * dispnew.c: Make symbols static if they're not exported.
162 * dispextern.h (redraw_garbaged_frames, scrolling):
163 (increment_row_positions): Remove.
164 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
165 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
166 Now static.
167 (redraw_garbaged_frames): Remove; unused.
168
435f4c28
PE
169 * xfaces.c: Make symbols static if they're not exported.
170 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
171 Remove decls.
172 * xterm.h (defined_color): Remove decls.
173 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
174 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
175 (menu_face_changed_default, defined_color, free_realized_face):
176 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
177 (ascii_face_of_lisp_face): Remove; unused.
178
8524aef3
PE
179 * xdisp.c: Make symbols static if they're not exported.
180 * dispextern.h (scratch_glyph_row, window_box_edges):
181 (glyph_to_pixel_coords, set_cursor_from_row):
182 (get_next_display_element, set_iterator_to_next):
183 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
184 (show_mouse_face): Remove decls
185 * frame.h (message_buf_print): Likewise.
186 * lisp.h (pop_message, set_message, check_point_in_composition):
187 Likewise.
188 * xterm.h (set_vertical_scroll_bar): Likewise.
189 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
190 (message_buf_print, scratch_glyph_row, displayed_buffer):
191 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
192 (get_next_display_element, show_mouse_face, window_box_edges):
193 (frame_to_window_pixel_xy, check_point_in_composition):
194 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
195 (glyph_to_pixel_coords): Remove; unused.
196
16390cd2
PE
197 * dired.c (file_name_completion): Now static.
198
199 * dbusbind.c (xd_in_read_queued_messages): Now static.
200
a25f4dfa
PE
201 * lisp.h (circular_list_error, FOREACH): Remove; unused.
202 * data.c (circular_list_error): Remove.
203
16a97296
PE
2042011-04-11 Paul Eggert <eggert@cs.ucla.edu>
205
14a9c8df
PE
206 * commands.h (last_point_position, last_point_position_buffer):
207 (last_point_position_window): Remove decls.
208 * keyboard.c: Make these variables static.
209
74ab6df5
PE
210 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
211 decls.
212 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
213 (iso_code_class, detect_coding, code_convert_region): Now static.
214 (encode_coding_gap): Remove; unused.
215
38dfbee1
PE
216 * chartab.c (chartab_chars, chartab_bits): Now static.
217
a2cb4e63
PE
218 * charset.h (charset_iso_8859_1): Remove decl.
219 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
220 Now static.
221
127198fd
PE
222 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
223 * ccl.c (Vccl_program_table): Now static.
224 (check_ccl_update): Remove; unused.
225
d85b608f
PE
226 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
227 * category.h: ... from here.
228 * category.c (check_category_table, set_category_set): Now static.
229
31cd66f3
PE
230 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
231 * lisp.h: Remove these decls.
232
c358e587
PE
233 * buffer.c (buffer_count): Remove unused var.
234
e78aecca
PE
235 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
236 so that it's not optimized away.
237 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
238 * dispextern.h (bidi_dump_cached_states): Remove, since it's
239 exported only to the debugger.
240
e192d7d3
PE
241 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
242 * atimer.h (run_all_atimers): Removed; not exported.
243
92470028
PE
244 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
245 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
246 was inaccessible from Lisp.
247 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
248 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
249
244ed907
PE
250 alloc.c: Import and export fewer symbols, and remove unused items.
251 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
252 is defined.
253 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
254 it's not optimized away by whole-program optimization.
255 (message_enable_multibyte, free_misc): Remove.
256 (catchlist, handlerlist, mark_backtrace):
257 Declare only if BYTE_MARK_STACK.
258 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
259 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
260 (message_enable_multibyte): Remove decl.
261 (free_misc, interval_free_list, float_block, float_block_index):
262 (n_float_blocks, float_free_list, cons_block, cons_block_index):
263 (cons_free_list, last_marked_index):
264 Now static.
265 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
266 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
267 (mark_backtrace): Define only if BYTE_MARK_STACK.
268 * xdisp.c (message_enable_multibyte): Now static.
269
955cbe7b
PE
270 Declare Lisp_Object Q* variables to be 'static' if not exproted.
271 This makes it easier for human readers (and static analyzers)
272 to see whether these variables are used from other modules.
273 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
274 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
275 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
276 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
277 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
278 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
279 * xmenu.c, xselect.c:
280 Declare Q* vars static if they are not used in other modules.
281 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
282 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
283 Remove decls of unexported vars.
284 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
285
95c82688
PE
286 * lisp.h (DEFINE_FUNC): Make sname 'static'.
287
16a97296
PE
288 Make Emacs functions such as Fatom 'static' by default.
289 This makes it easier for human readers (and static analyzers)
290 to see whether these functions can be called from other modules.
291 DEFUN now defines a static function. To make the function external
292 so that it can be used in other C modules, use the new macro DEFUE.
293 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
294 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
295 static function definition. Use DEFUE if you want an extern one.
296 (DEFUE, INFUN): New macros.
297 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
298 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
299 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
300 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
301 Remove decls, since these functions are now static.
302 (Funintern, Fget_internal_run_time): New decls, since these functions
303 were already external.
95c82688 304
16a97296
PE
305 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
306 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
307 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
308 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
309 * keyboard.c, keymap.c, lread.c:
310 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
311 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
312 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
313 Mark functions with DEFUE instead of DEFUN,
314 if they are used in other modules.
315 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
316 decls for now-static functions.
317 * buffer.h (Fdelete_overlay): Remove decl.
318 * callproc.c (Fgetenv_internal): Mark as internal.
319 * composite.c (Fremove_list_of_text_properties): Remove decl.
320 (Fcomposition_get_gstring): New forward static decl.
321 * composite.h (Fcomposite_get_gstring): Remove decl.
322 * dired.c (Ffile_attributes): New forward static decl.
323 * doc.c (Fdocumntation_property): New forward static decl.
324 * eval.c (Ffetch_bytecode): New forward static decl.
325 (Funintern): Remove extern decl; now in .h file where it belongs.
326 * fileio.c (Fmake_symbolic_link): New forward static decl.
327 * image.c (Finit_image_library): New forward static decl.
328 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
329 * intervals.h (Fprevious_property_change):
330 (Fremove_list_of_text_properties): Remove decls.
331 * keyboard.c (Fthis_command_keys): Remove decl.
332 (Fcommand_execute): New forward static decl.
333 * keymap.c (Flookup_key): New forward static decl.
334 (Fcopy_keymap): Now static.
335 * keymap.h (Flookup_key): Remove decl.
336 * process.c (Fget_process): New forward static decl.
337 (Fprocess_datagram_address): Mark as internal.
338 * syntax.c (Fsyntax_table_p): New forward static decl.
339 (skip_chars): Remove duplicate decl.
340 * textprop.c (Fprevious_property_change): New forward static decl.
341 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
342 Now internal.
343 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
344 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
345
785bbd42
PE
3462011-04-10 Paul Eggert <eggert@cs.ucla.edu>
347
348 * editfns.c (Fformat): Remove unreachable code.
349
4073e537 3502011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 351
b2ded58d
PE
352 Fix more problems found by GCC 4.6.0's static checks.
353
7d66342c
PE
354 * xdisp.c (vmessage): Use a better test for character truncation.
355
bbf47d44
PE
356 * charset.c (load_charset_map): <, not <=, for optimization,
357 and to avoid potential problems with integer overflow.
9248994d 358 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 359 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 360 * editfns.c (Fformat): Likewise.
1e69125e 361 * syntax.c (skip_chars): Likewise.
3befa583 362
e3019616
PE
363 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
364 This also lets GCC 4.6.0 generate slightly better loop code.
365
becfa255
PE
366 * callint.c (Fcall_interactively): <, not <=, for optimization.
367 (Fcall_interactively): Count the number of arguments produced,
368 not the number of arguments given. This is simpler and lets GCC
369 4.6.0 generate slightly better code.
370
dae0cd48
PE
371 * ftfont.c: Distingish more carefully between FcChar8 and char.
372 The previous code passed unsigned char * to a functions like
373 strlen and xstrcasecmp that expect char *, which does not
374 conform to the C standard.
375 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
376 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
377 char * when the C standard requires it.
378
76032d70
PE
379 * keyboard.c (read_char): Remove unused var.
380
eb3f1cc8
PE
381 * eval.c: Port to Windows vsnprintf (Bug#8435).
382 Include <limits.h>.
383 (SIZE_MAX): Define if the headers do not.
384 (verror): Do not give up if vsnprintf returns a negative count.
385 Instead, grow the buffer. This ports to Windows vsnprintf, which
386 does not conform to C99. Problem reported by Eli Zaretskii.
387 Also, simplify the allocation scheme, by avoiding the need for
388 calling realloc, and removing the ALLOCATED variable.
389
70476b54
PE
390 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
391
12020a9e
PE
392 Remove invocations of doprnt, as Emacs now uses vsnprintf.
393 But keep the doprint source code for now, as we might revamp it
394 and use it again (Bug#8435).
ea6c7ae6
PE
395 * lisp.h (doprnt): Remove.
396 * Makefile.in (base_obj): Remove doprnt.o.
397 * deps.mk (doprnt.o): Remove.
398
5fdb398c
PE
399 error: Print 32- and 64-bit integers portably (Bug#8435).
400 Without this change, on typical 64-bit hosts error ("...%d...", N)
401 was used to print both 32- and 64-bit integers N, which relied on
402 undefined behavior.
403 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
404 New macro.
405 * lisp.h (error, verror): Mark as printf-like functions.
406 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
407 Report overflow in size calculations when allocating printf buffer.
408 Do not truncate output string at its first null byte.
409 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
410 Truncate the output at a character boundary, since vsnprintf does not
411 do that.
412 * charset.c (check_iso_charset_parameter): Convert internal
413 character to string before calling 'error', since %c now has the
414 printf meaning.
415 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
416 overflow when computing char to be passed to 'error'. Do not
417 pass Lisp_Object to 'error'; pass the integer instead.
418 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
419 formatted with plain %d.
420
b189fa66
PE
421 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
422
bff87ef0
PE
423 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
424
7e2cac20
PE
425 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
426
ce4d90b5
PE
427 * xterm.c (x_catch_errors): Remove duplicate declaration.
428
266c9547
PE
429 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
430
79c49ad2
PE
431 * xdisp.c, lisp.h (message_nolog): Remove; unused.
432
368f4090
JM
4332011-04-10 Jim Meyering <meyering@redhat.com>
434
435 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
436 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
437 return ssize_t not "int", and use size_t as the buffer length.
438 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
439 * gnutls.h: Update declarations.
440 * process.c (read_process_output): Use ssize_t, to match.
441 (send_process): Likewise.
442
a32d4040
CY
4432011-04-09 Chong Yidong <cyd@stupidchicken.com>
444
445 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
446
8546720e 4472011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 448
8546720e
GM
449 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
450 unsigned char, to match FcChar8 type definition.
aac0c6e3 451
8546720e
GM
452 * xterm.c (handle_one_xevent):
453 * xmenu.c (create_and_show_popup_menu):
454 * xselect.c (x_decline_selection_request)
455 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 456
a53e2e89
EZ
4572011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
458
459 Fix some uses of `int' instead of EMACS_INT.
460 * search.c (string_match_1, fast_string_match)
461 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
462 (scan_buffer, find_next_newline_no_quit)
463 (find_before_next_newline, search_command, Freplace_match)
464 (Fmatch_data): Make some `int' variables be EMACS_INT.
465
466 * xdisp.c (display_count_lines): 3rd argument and return value now
467 EMACS_INT. All callers changed.
468 (pint2hrstr): Last argument is now EMACS_INT.
469
470 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
471 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
472 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
473 (decode_coding_utf_16, decode_coding_emacs_mule)
474 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
475 (decode_coding_ccl, decode_coding_charset)
476 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
477 (decode_coding_iso_2022, decode_coding_emacs_mule)
478 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
479 <char_offset, last_offset>: Declare EMACS_INT.
480 (encode_coding_utf_8, encode_coding_utf_16)
481 (encode_coding_emacs_mule, encode_invocation_designation)
482 (encode_designation_at_bol, encode_coding_iso_2022)
483 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
484 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
485 Declare EMACS_INT.
486 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
487 (encode_invocation_designation): Last argument P_NCHARS is now
488 EMACS_INT.
489 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
490 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
491
492 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
493 All users changed.
494
495 * ccl.c (Fccl_execute_on_string): Declare some variables
496 EMACS_INT.
497
8546720e 4982011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
499
500 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
501
4e19a977
CS
5022011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
503
504 * process.c (Fformat_network_address): Doc fix.
505
87302331
R
5062011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
507
508 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
509
cbb59342
CY
5102011-04-08 Chong Yidong <cyd@stupidchicken.com>
511
512 * keyboard.c (read_char): Call Lisp function help-form-show,
513 instead of using internal_with_output_to_temp_buffer.
514 (Qhelp_form_show): New var.
e0d38eeb 515 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
516
517 * print.c (internal_with_output_to_temp_buffer): Function deleted.
518
519 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
520
e67a13ab
CY
5212011-04-06 Chong Yidong <cyd@stupidchicken.com>
522
523 * process.c (Flist_processes): Removed to Lisp.
524 (list_processes_1): Deleted.
525
973f782d
EZ
5262011-04-06 Eli Zaretskii <eliz@gnu.org>
527
7c106b1e
EZ
528 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
529
973f782d
EZ
530 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
531
41cf7d1a 5322011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 533
ca23cc88
PE
534 Fix more problems found by GCC 4.6.0's static checks.
535
f390e2d5
PE
536 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
537
42eea0d0
PE
538 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
539
b69769da 540 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 541
f9541e84
PE
542 * xdisp.c (vmessage): Mark as a printf-like function.
543
13841b55
PE
544 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
545
c136c10f
PE
546 * sound.c (sound_warning): Don't crash if arg contains a printf format.
547
5e2d4a30
PE
548 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
549 printf-like functions.
550 (tiff_load): Add casts to remove these marks before passing them
551 to system-supplied API.
552
583f48b9
PE
553 * eval.c (Fsignal): Remove excess argument to 'fatal'.
554
b25d760e
PE
555 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
556 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
557 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
558 directly, rather than having caller test rule sign. This avoids
559 some unnecessary tests.
560 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
561 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
562 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 563
bc7b6697 564 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 565 (xfont_open): Avoid unnecessary tests.
bc7b6697 566
27ccc379
PE
567 * composite.c (composition_gstring_put_cache): Use unsigned integer.
568
dcd5c89a
PE
569 * composite.h, composite.c (composition_gstring_put_cache):
570 Use EMACS_INT, not int, for length.
571
b13a45c6
PE
572 * composite.h (COMPOSITION_DECODE_REFS): New macro,
573 breaking out part of COMPOSITION_DECODE_RULE.
574 (COMPOSITION_DECODE_RULE): Use it.
575 * composite.c (get_composition_id): Remove unused local vars,
576 by using the new macro.
577
1e792e4d
PE
578 * textprop.c (set_text_properties_1): Change while to do-while,
579 since the condition is always true at first.
580
dc6c6455 581 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
582 (interval_deletion_adjustment): Return unsigned value.
583 All uses changed.
dc6c6455 584
aba7731a
PE
585 * process.c (list_processes_1, create_pty, read_process_output):
586 (exec_sentinel): Remove vars that were set but not used.
afd4052b 587 (create_pty): Remove unnecessary "volatile"s.
bc57d757 588 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 589 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 590 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 591
fdfc4bf3
PE
592 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
593
fca8fe46 594 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 595 (update_syntax_table): Use unsigned instead of int.
fca8fe46 596
06a0259a 597 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 598 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 599 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 600
e7b9e80f
PE
601 * print.c (print_error_message): Avoid int overflow.
602
56201685
PE
603 * font.c (font_list_entities): Redo for clarity,
604 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
605
78834453 606 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 607 (font_score): Avoid potential overflow in diff calculation.
78834453 608
0bc0b309 609 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 610 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 611
e610eaca
PE
612 * eval.c (funcall_lambda): Rename local to avoid shadowing.
613
b895abce
PE
614 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
615 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
616 can always succeed if overflow has undefined behavior.
617
1f1d9321 618 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 619 (wordify): Omit three unnecessary tests.
1f1d9321 620
c59478bc
PE
621 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
622 All callers changed. This avoids the need for an unused var.
623
79b73827
PE
624 * casefiddle.c (casify_region): Remove var that is set but not used.
625
a4db5dfe
PE
626 * dired.c (file_name_completion): Remove var that is set but not used.
627
43aae36e
PE
628 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
629
2a47c44d 630 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 631 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 632
a37c69bf
PE
633 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
634 Check for integer overflow on size calculations.
635
328ab8e7
PE
636 * buffer.c (Fprevious_overlay_change): Remove var that is set
637 but not used.
638
e5a2a5cb
PE
639 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
640 Remove vars that are set but not used.
8d84a6eb 641 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 642 (timer_check_2): Mark vars as initialized.
e5a2a5cb 643
a60e5f68
PE
644 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
645
f661cb61 646 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 647 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 648
f0397f5a
PE
649 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
650 that are set but not used.
651
8664db06 652 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 653 if XCreateBitmapFromData fails (Bug#8410).
8664db06 654
6abdaa4a
PE
655 * xselect.c (x_get_local_selection, x_handle_property_notify):
656 Remove vars that are set but not used.
657
0ce7538d 658 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 659 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 660
9ae848fc
PE
661 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
662 Remove var that is set but not used.
0b918413
PE
663 (scroll_bar_windows_size): Now size_t, not int.
664 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
665 Check for overflow.
9ae848fc 666
a5a62657
PE
667 * xfaces.c (realize_named_face): Remove vars that are set but not used.
668 (map_tty_color) [!defined MSDOS]: Likewise.
669
5c5cdd39
PE
670 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
671
66ebf983
PE
672 * coding.c: Remove vars that are set but not used.
673 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
674 All callers changed.
675 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
676 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
677 (decode_coding_charset): Remove vars that are set but not used.
678
1be4d761
PE
679 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
680 that is set but not used.
681
47553fa8
PE
682 * print.c (print_object): Remove var that is set but not used.
683
1f7196bf 684 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
685 The gnulib version avoids calling malloc in the usual case,
686 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
687 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
688 * filelock.c (current_lock_owner): Likewise.
689 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
690 * sysdep.c: Include allocator.h, careadlinkat.h.
691 (emacs_no_realloc_allocator): New static constant.
692 (emacs_readlink): New function.
fdb61804
PE
693 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
694 ../lib/careadlinkat.h.
d1fdcab7 695
f84c17c7
SM
6962011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
697
698 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
699 first non-nil return value).
700
ef3862ad
JD
7012011-04-03 Jan Djärv <jan.h.d@swipnet.se>
702
703 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
704 if not defined (Bug#8403).
705
376a7006
JB
7062011-04-02 Juanma Barranquero <lekktu@gmail.com>
707
708 * xdisp.c (display_count_lines): Remove parameter `start',
709 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
710 (get_char_face_and_encoding): Remove parameter `multibyte_p',
711 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
712 (fill_stretch_glyph_string): Remove parameters `row' and `area',
713 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
714 and thereabouts. All callers changed.
715 (get_per_char_metric): Remove parameter `f', unused since
716 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
717
6ca3801d
JM
7182011-04-02 Jim Meyering <meyering@redhat.com>
719
720 do not dereference NULL upon failed strdup
721 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
722 (ns_get_family): Likewise.
723
d8e2b5ba
JB
7242011-04-02 Juanma Barranquero <lekktu@gmail.com>
725
726 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
727
8c74fcbd
JD
7282011-04-02 Jan Djärv <jan.h.d@swipnet.se>
729
730 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
731 later (Bug#8403).
732
7200d79c
SM
7332011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
734
03408648 735 Add lexical binding.
7200d79c 736
03408648
SM
737 * window.c (Ftemp_output_buffer_show): New fun.
738 (Fsave_window_excursion):
739 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
740
741 * lread.c (lisp_file_lexically_bound_p): New function.
742 (Fload): Bind Qlexical_binding.
743 (readevalloop): Remove `evalfun' arg.
744 Bind Qinternal_interpreter_environment.
745 (Feval_buffer): Bind Qlexical_binding.
746 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
747 Mark as dynamic.
748 (syms_of_lread): Declare `lexical-binding'.
749
750 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
751
752 * keyboard.c (eval_dyn): New fun.
753 (menu_item_eval_property): Use it.
ca105506
SM
754
755 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 756
03408648
SM
757 * fns.c (concat, mapcar1): Accept byte-code-functions.
758
759 * eval.c (Fsetq): Handle lexical vars.
760 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
761 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
762 (FletX, Flet): Obey lexical binding.
763 (Fcommandp): Handle closures.
764 (Feval): New `lexical' arg.
765 (eval_sub): New function extracted from Feval. Use it almost
766 everywhere where Feval was used. Look up vars in lexical env.
767 Handle closures.
768 (Ffunctionp): Move from subr.el.
769 (Ffuncall): Handle closures.
770 (apply_lambda): Remove `eval_flags'.
771 (funcall_lambda): Handle closures and new byte-code-functions.
772 (Fspecial_variable_p): New function.
773 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
774 but without exporting it to Lisp.
23aba0ea 775
23aba0ea 776 * doc.c (Fdocumentation, store_function_docstring):
03408648 777 * data.c (Finteractive_form): Handle closures.
23aba0ea 778
03408648
SM
779 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
780 interactive spec.
ba83908c 781
03408648
SM
782 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
783 byte-codes.
784 (exec_byte_code): New function extracted from Fbyte_code to handle new
785 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 786
03408648 787 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 788
03408648 789 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 790
e2abce01
JB
7912011-03-31 Juanma Barranquero <lekktu@gmail.com>
792
793 * xdisp.c (redisplay_internal): Fix prototype.
794
63696a73 7952011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 796
63696a73
EZ
797 * xdisp.c (SCROLL_LIMIT): New macro.
798 (try_scrolling): Use it when setting scroll_limit. Limit
799 scrolling to 100 screen lines.
800 (redisplay_window): Even when falling back on "recentering",
801 position point in the window according to scroll-conservatively,
802 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
803
804 (try_scrolling): When point is above the window, allow searching
805 as far as scroll_max, or one screenful, to compute vertical
806 distance from PT to the scroll margin position. This prevents
807 try_scrolling from unnecessarily failing when
808 scroll-conservatively is set to a value slightly larger than the
809 window height. Clean up the case of PT below the margin at bottom
810 of window: scroll_max can no longer be INT_MAX. When aggressive
811 scrolling is in use, don't let point enter the opposite scroll
812 margin as result of the scroll.
813 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
814 threshold of 100 lines for never-recentering scrolling.
815
e4cc2dfc
JB
8162011-03-31 Juanma Barranquero <lekktu@gmail.com>
817
818 * dispextern.h (move_it_by_lines):
819 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
820 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
821 (message_log_check_duplicate): Remove parameters `prev_bol' and
822 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
823 (redisplay_internal): Remove parameter `preserve_echo_area',
824 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
825
826 * indent.c (Fvertical_motion):
827 * window.c (window_scroll_pixel_based, Frecenter):
828 Don't pass `need_y_p' to `move_it_by_lines'.
829
1c470562
SM
8302011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
831
44f230aa
SM
832 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
833 steal a few bits to be more compact.
834 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
835 Remove unneeded casts.
836
1c470562
SM
837 * bytecode.c (Fbyte_code): CAR and CDR can GC.
838
888adce9
ZK
8392011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
840
841 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
842 binding" message (bug#7967).
843
f838ed7b
PE
8442011-03-30 Paul Eggert <eggert@cs.ucla.edu>
845
77861b95
PE
846 Fix more problems found by GCC 4.6.0's static checks.
847
de6dbc14
PE
848 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
849 Remove unused local var.
850
f838ed7b
PE
851 * editfns.c (Fmessage_box): Remove unused local var.
852
792c7b2b
PE
853 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
854 (note_mode_line_or_margin_highlight, note_mouse_highlight):
855 Omit unused local vars.
c499e557 856 * window.c (shrink_windows): Omit unused local var.
b01a1c29 857 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
858 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
859 Omit unused local var.
860
ba0165e1
PE
861 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
862 Don't assume string length fits in int.
32ad8845 863 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 864 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 865
3c59b4c9
PE
866 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
867 instead of alloca (Bug#8344).
868
a3eed478 869 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 870 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 871
eb4d412d
PE
872 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
873
1658b401
PE
874 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
875 concerns.
876
877 * term.c (produce_glyphless_glyph): Remove unnecessary test.
878
879 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 880
9a2c6e05
PE
881 * keyboard.c (syms_of_keyboard): Use the same style as later
882 in this function when indexing through an array. This also
883 works around GCC bug 48267.
884
03d0a109
PE
885 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
886
44f730c8
PE
887 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
888
fe75f926
PE
889 * chartab.c (sub_char_table_ref_and_range): Redo for slight
890 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
891
ffa8c828
PE
892 * keyboard.c, keyboard.h (num_input_events): Now size_t.
893 This avoids undefined behavior on integer overflow, and is a bit
894 more convenient anyway since it is compared to a size_t variable.
895
c5101a77
PE
896 Variadic C functions now count arguments with size_t, not int.
897 This avoids an unnecessary limitation on 64-bit machines, which
898 caused (substring ...) to crash on large vectors (Bug#8344).
899 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
900 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 901 All variadic functions and their callers changed accordingly.
c5101a77
PE
902 (struct gcpro.nvars): Now size_t, not int. All uses changed.
903 * data.c (arith_driver, float_arith_driver): Likewise.
904 * editfns.c (general_insert_function): Likewise.
905 * eval.c (struct backtrace.nargs, interactive_p)
906 (internal_condition_case_n, run_hook_with_args, apply_lambda)
907 (funcall_lambda, mark_backtrace): Likewise.
908 * fns.c (concat): Likewise.
909 * frame.c (x_set_frame_parameters): Likewise.
910 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
911 0 if not found, not -1. All callers changed.
912
dd3f25f7
PE
913 * alloc.c (garbage_collect): Don't assume stack size fits in int.
914 (stack_copy_size): Now size_t, not int.
915 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
916
461c2ab9
JB
9172011-03-28 Juanma Barranquero <lekktu@gmail.com>
918
919 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
920 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
921 All callers changed.
922
923 * lisp.h (multibyte_char_to_unibyte):
924 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
925 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
926 * character.h (CHAR_TO_BYTE8):
927 * cmds.c (internal_self_insert):
928 * editfns.c (general_insert_function):
929 * keymap.c (push_key_description):
930 * search.c (Freplace_match):
931 * xdisp.c (message_dolog, set_message_1): All callers changed.
932
f6d62986
SM
9332011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
934
935 * keyboard.c (safe_run_hook_funcall): New function.
936 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
937 don't set the hook to nil, but remove the offending function instead.
938 (Qcommand_hook_internal): Remove, unused.
939 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
940 Vcommand_hook_internal.
941
942 * eval.c (enum run_hooks_condition): Remove.
943 (funcall_nil, funcall_not): New functions.
944 (run_hook_with_args): Call each function through a `funcall' argument.
945 Remove `cond' argument, now redundant.
946 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
947 (Frun_hook_with_args_until_failure): Adjust accordingly.
948 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
949
1db5b1ad
JB
9502011-03-28 Juanma Barranquero <lekktu@gmail.com>
951
952 * dispextern.h (string_buffer_position): Remove declaration.
953
954 * print.c (strout): Remove parameter `multibyte', unused since
955 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
956
957 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
958 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
959 All callers changed.
960
961 * w32.c (_wsa_errlist): Use braces for struct initializers.
962
963 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
964 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
965 All callers changed.
966 (string_buffer_position): Likewise. Also, make static (it's never
967 used outside xdisp.c).
968 (cursor_row_p): Remove parameter `w', unused since
969 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
970 (decode_mode_spec): Remove parameter `precision', introduced during
971 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
972 All callers changed.
973
5ffb62aa
JD
9742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
975
976 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
977
461c2ab9 9782011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
979
980 * nsterm.m (ns_menu_bar_is_hidden): New variable.
981 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
982 (ns_update_auto_hide_menu_bar): New functions.
983 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
984 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
985 ns_constrain_all_frames.
986 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
987 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
988
5c380ffb
JD
9892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
990
991 * nsmenu.m (runDialogAt): Remove argument to timer_check.
992
9af30bdf
GM
9932011-03-27 Glenn Morris <rgm@gnu.org>
994
995 * syssignal.h: Replace RETSIGTYPE with void.
996 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
997 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
998 Replace SIGTYPE with void everywhere.
999 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1000 * s/template.h (SIGTYPE): Remove commented out definition.
1001
e2abce01
JB
10022011-03-26 Eli Zaretskii <eliz@gnu.org>
1003
1004 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1005 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1006
f868cd8a
JB
10072011-03-26 Juanma Barranquero <lekktu@gmail.com>
1008
59eb0929
JB
1009 * w32.c (read_unc_volume): Use parameter `henum', instead of
1010 global variable `wget_enum_handle'.
1011
1012 * keymap.c (describe_vector): Remove parameters `indices' and
1013 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1014 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1015
f868cd8a
JB
1016 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1017
1018 * keyboard.c (timer_check): Remove parameter `do_it_now',
1019 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1020 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1021 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1022
1023 * keyboard.c (read_char):
1024 * w32menu.c (w32_menu_display_help):
1025 * xmenu.c (show_help_event, menu_help_callback):
1026 Adjust calls to `show_help_echo'.
1027
1028 * gtkutil.c (xg_maybe_add_timer):
1029 * keyboard.c (readable_events):
1030 * process.c (wait_reading_process_output):
1031 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1032
1033 * insdel.c (adjust_markers_gap_motion):
1034 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1035 (gap_left, gap_right): Don't call it.
1036
2ecf6fdb
CY
10372011-03-25 Chong Yidong <cyd@stupidchicken.com>
1038
1039 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1040 incurred during fontification.
1041
6b1f9ba4
JB
10422011-03-25 Juanma Barranquero <lekktu@gmail.com>
1043
1044 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1045 (DEFVAR_PER_BUFFER): Don't pass it.
1046
1047 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1048 (scrolling_window): Don't pass it.
1049
0f4a96b5
JB
10502011-03-25 Juanma Barranquero <lekktu@gmail.com>
1051
1052 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1053
1054 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1055 and `suffix'.
1056 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1057 of variables specific to SELinux and computation of `encoded_absname'.
1058
1059 * image.c (XPutPixel): Remove unused variable `height'.
1060
1061 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1062
1063 * unexw32.c (get_section_info): Remove unused variable `section'.
1064
1065 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1066 (system_process_attributes): Remove unused variable `sess'.
1067 (sys_read): Remove unused variable `err'.
1068
1069 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1070 (w32_wnd_proc): Remove unused variable `isdead'.
1071 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1072 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1073 (x_create_tip_frame): Remove unused variable `tem'.
1074
1075 * w32inevt.c (w32_console_read_socket):
1076 Remove unused variable `no_events'.
1077
1078 * w32term.c (x_draw_composite_glyph_string_foreground):
1079 Remove unused variable `width'.
1080
1149507c
JB
10812011-03-24 Juanma Barranquero <lekktu@gmail.com>
1082
1083 * w32term.c (x_set_glyph_string_clipping):
1084 Don't pass uninitialized region to CombineRgn.
1085
9c88f339
JB
10862011-03-23 Juanma Barranquero <lekktu@gmail.com>
1087
1088 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1089 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1090 (Fx_close_connection): Remove unused variable `i'.
1091
1092 * w32font.c (w32font_draw): Return number of glyphs.
1093 (w32font_open_internal): Remove unused variable `i'.
1094 (w32font_driver): Add missing initializer.
1095
1096 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1097 (fill_in_menu): Remove unused variable `items_added'.
1098
1099 * w32term.c (last_mouse_press_frame): Remove static global variable.
1100 (w32_clip_to_row): Remove unused variable `f'.
1101 (x_delete_terminal): Remove unused variable `i'.
1102
1103 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1104 (NOTHING): Remove unused static global variable.
1105 (uniscribe_check_otf): Remove unused variable `table'.
1106 (uniscribe_font_driver): Add missing initializers.
1107
dee091a3
JD
11082011-03-23 Julien Danjou <julien@danjou.info>
1109
1110 * term.c (Fsuspend_tty, Fresume_tty):
1111 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1112 * window.c (temp_output_buffer_show):
1113 * insdel.c (signal_before_change):
1114 * frame.c (Fhandle_switch_frame):
1115 * fileio.c (Fdo_auto_save):
1116 * emacs.c (Fkill_emacs):
1117 * editfns.c (save_excursion_restore):
1118 * cmds.c (internal_self_insert):
1119 * callint.c (Fcall_interactively):
1120 * buffer.c (Fkill_all_local_variables):
1121 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1122 Use Frun_hooks.
0f4a96b5 1123 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1124 unconditionnaly since it does the check itself.
1125
2c520ab5 11262011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1127
c9c49752
PE
1128 Fix more problems found by GCC 4.5.2's static checks.
1129
8abc3f12
PE
1130 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1131 the first time through the loop, since we know p0 < p1 then.
1132 This also avoids a gcc -Wstrict-overflow warning.
1133
a2d26660
PE
1134 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1135 leading to a memory leak, possible in functions like
1136 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1137 of objects (Bug#8318).
a2d26660 1138
916c72e9
PE
1139 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1140 that could (at least in theory) be that large.
1141
19ab8a18
PE
1142 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1143 This is less likely to overflow, and avoids undefined behavior if
1144 overflow does occur. All callers changed. Use strtoul to scan
1145 for the unsigned long integer.
b7cbbd6f
PE
1146 (pint2hrstr): Simplify and tune code slightly.
1147 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1148
f0641eff
PE
1149 * scroll.c (do_scrolling): Work around GCC bug 48228.
1150 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1151
7f650bb9
PE
1152 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1153 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1154 (validate_x_resource_name): Simplify count usage.
1155 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1156
37dd57d1
PE
1157 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1158 fail (Bug#8306).
81e56e61 1159
699979fc 1160 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1161
401bf9b4
PE
1162 * process.c (Fmake_network_process): Use socklen_t, not int,
1163 where POSIX says socklen_t is required in portable programs.
1164 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1165 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1166 (Fmake_network_process, server_accept_connection):
1167 (wait_reading_process_output, read_process_output):
1168 Likewise.
1169
b93aacde
PE
1170 * process.c: Rename or move locals to avoid shadowing.
1171 (list_processes_1, Fmake_network_process):
1172 (read_process_output_error_handler, exec_sentinel_error_handler):
1173 Rename or move locals.
4dc343ee 1174 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1175 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1176 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1177 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1178 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1179
af8a867c 1180 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1181 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1182 Include tparam.h instead, since it declares them.
af8a867c
PE
1183 * cm.h (PC): Remove extern decl; tparam.h now does this.
1184 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1185 * terminfo.c: Include tparam.h, to check interfaces.
1186 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1187 (tparam): Adjust signature to match interface in tparam.h;
1188 this removes some undefined behavior. Check that outstring and len
1189 are zero, which they always are with Emacs.
1190 * tparam.h (PC, BC, UP): New extern decls.
1191
0248044d 1192 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1193 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1194
8ff096c1 1195 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1196 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1197 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1198 (ftfont_list): Remove unused local.
49eaafba
PE
1199 (get_adstyle_property, ftfont_pattern_entity):
1200 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1201 Rename locals to avoid shadowing.
8ff096c1 1202
e2be39f6
PE
1203 * xfont.c (xfont_list_family): Mark var as initialized.
1204
c9735e30
PE
1205 * xml.c (make_dom): Now static.
1206
8f5201ae
PE
1207 * composite.c (composition_compute_stop_pos): Rename local to
1208 avoid shadowing.
b246f932
PE
1209 (composition_reseat_it): Remove unused locals.
1210 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1211 (composition_update_it): Mark var as initialized.
11b61122
PE
1212 (find_automatic_composition): Mark vars as initialized,
1213 with a FIXME (Bug#8290).
8f5201ae 1214
760fbc2c
PE
1215 character.h: Rename locals to avoid shadowing.
1216 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1217 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1218 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1219 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1220 to avoid shadowing.
1221
ff08eb85
PE
1222 * textprop.c (property_change_between_p): Remove; unused.
1223
fc7bf025
PE
1224 * intervals.c (interval_start_pos): Now static.
1225
235d7abc
PE
1226 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1227
44f230aa
SM
1228 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1229 Rename locals to avoid shadowing.
3e7d6594 1230
50060332
PE
1231 * sound.c (wav_play, au_play, Fplay_sound_internal):
1232 Fix pointer signedness.
d01f234b 1233 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1234 (wav_play): Initialize a variable to 0, to prevent undefined
1235 behavior (Bug#8278).
50060332 1236
c4fc4e30
PE
1237 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1238
918436ed
PE
1239 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1240
c939f91b
PE
1241 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1242 clobbering (Bug#8298).
b9c7f648
PE
1243 * sysdep.c (sys_subshell): Likewise.
1244 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1245
6bd8c144
PE
1246 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1247 This should get cleaned up, so that child_setup has the
1248 same signature on all platforms.
1249
7710357c 1250 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1251 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1252
c59da222
CY
12532011-03-22 Chong Yidong <cyd@stupidchicken.com>
1254
1255 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1256 not to be necessary, and produces flickering.
1257
66b87493
GM
12582011-03-20 Glenn Morris <rgm@gnu.org>
1259
1260 * config.in: Remove file.
1261
45b6f6d5
JB
12622011-03-20 Juanma Barranquero <lekktu@gmail.com>
1263
1264 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1265 are now in src/globals.h.
1266 (syms_of_minibuf): Remove spurious & from previous change.
1267
3ec03f7e
LL
12682011-03-20 Leo <sdl.web@gmail.com>
1269
1270 * minibuf.c (completing-read-function): New variable.
1271 (completing-read-default): Rename from completing-read.
1272 (completing-read): Call completing-read-function.
1273
b14e3e21
CY
12742011-03-19 Juanma Barranquero <lekktu@gmail.com>
1275
1276 * xfaces.c (Fx_load_color_file):
1277 Read color file from absolute filename (bug#8250).
1278
f2b726e6
JB
12792011-03-19 Juanma Barranquero <lekktu@gmail.com>
1280
1281 * makefile.w32-in: Update dependencies.
1282
09f6ff02
EZ
12832011-03-17 Eli Zaretskii <eliz@gnu.org>
1284
1285 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1286
29a6015a
PE
12872011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1288
a3a6c54e
PE
1289 Fix more problems found by GCC 4.5.2's static checks.
1290
b766f867
PE
1291 * process.c (make_serial_process_unwind, send_process_trap):
1292 (sigchld_handler): Now static.
1293
be02381c
PE
1294 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1295 That way, the code declares only the vars that it needs.
1296 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1297 * s/cygwin.h (PTY_ITERATION): Likewise.
1298 * s/darwin.h (PTY_ITERATION): Likewise.
1299 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1300
57048744
PE
1301 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1302 * process.c (allocate_pty): Don't declare stb unless it's needed.
1303
7914961c 1304 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1305 (CONSTANTLIM): Remove; unused.
1306 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1307 Define only if needed.
7914961c 1308
b3967b18
PE
1309 * unexelf.c (unexec): Name an expression,
1310 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1311 Use a different way to cause a compilation error if anyone uses
1312 n rather than nn, a way that does not involve shadowing.
73366a00 1313 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1314
29a6015a
PE
1315 * deps.mk (unexalpha.o): Remove; unused.
1316
43cfc33e 1317 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1318 * unexec.h: New file.
ce701a33
PE
1319 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1320 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1321 Depend on unexec.h.
1322 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1323 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1324 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1325 Change as necessary to match prototype in unexec.h.
ce701a33 1326
01f44d5a
PE
1327 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1328 shadowing.
4f63c6bb 1329 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1330
a6670b0b
PE
1331 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1332 Rename locals to avoid shadowing.
1333
cef2010d 1334 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1335 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1336
d4d7173a
PE
1337 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1338
f08b802a
PE
1339 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1340 warning when compiling print.c.
1341
3ddb0639
PE
1342 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1343 instead of using an uninitialized var.
5ad03b97 1344 (font_sort_entities): Mark var as initialized.
3ddb0639 1345
170a2692
PE
1346 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1347
e663c700
PE
1348 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1349 pointers to constants.
89bc529a 1350 (font_parse_fcname): Remove unused vars.
7b81e2d0 1351 (font_delete_unmatched): Now static.
ea838e10 1352 (font_get_spec): Remove; unused.
13a547c6
PE
1353 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1354 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1355 Rename or move locals to avoid shadowing.
e663c700 1356
2a80c887 1357 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1358 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1359
1384fa33 1360 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1361 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1362
8b2c52e9
PE
1363 * alloc.c (mark_backtrace): Move decl from here ...
1364 * lisp.h: ... to here, so that it can be checked.
1365
475545b5 1366 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1367 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1368 (lisp_indirect_variable): Name an expression,
1369 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1370 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1371
b1349114 1372 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1373 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1374 Use const pointer when appropriate.
b1349114 1375
a2928364
PE
1376 * lisp.h (get_system_name, get_operating_system_release):
1377 Move decls here, to check interfaces.
1378 * process.c (get_operating_system_release): Move decl to lisp.h.
1379 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1380 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1381 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1382 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1383 (Fformat_time_string, Fencode_time, Finsert_char):
1384 (Ftranslate_region_internal, Fformat):
1385 Rename or remove local vars to avoid shadowing.
9710023e 1386 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1387
a415e694
PE
1388 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1389 avoid shadowing.
1390
8ef4622d
PE
1391 * lisp.h (eassert): Check that the argument compiles, even if
1392 ENABLE_CHECKING is not defined.
1393
946f9a5b
PE
1394 * data.c (Findirect_variable): Name an expression, to avoid
1395 gcc -Wbad-function-cast warning.
112396d6 1396 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1397 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1398 (Fmake_variable_buffer_local, Fmake_local_variable):
1399 Mark variables as initialized.
52746918 1400 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1401
e5aab7e7 1402 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1403 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1404 Rename locals to avoid shadowing.
dff45157
PE
1405 (mark_stack): Move local variables into the #ifdef region where
1406 they're used.
7bc26fdb
PE
1407 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1408 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1409 needed otherwise.
1410 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1411 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1412 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1413
e5aab7e7
PE
1414 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1415 avoids undefined behavior in theory.
1416
4da60324
PE
1417 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1418
88043301
PE
1419 Use functions, not macros, for up- and down-casing (Bug#8254).
1420 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1421 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1422 to use the following functions instead of these macros.
1423 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1424 EMACS_INT, since callers assume the returned value fits in int.
1425 (upcase1): Likewise, for UPCASE_TABLE.
1426 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1427 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1428 the race-condition problem in the old DOWNCASE.
88043301 1429
19ed5445
PE
1430 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1431 Rename locals to avoid shadowing.
1432 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1433 (regex_compile, re_search_2, re_match_2_internal):
1434 Remove unused local vars.
952db0d7
PE
1435 (FREE_VAR): Rewrite so as not to use empty "else",
1436 which gcc can warn about.
da053e48 1437 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1438 (RETALLOC_IF): Define only if needed.
1439 (WORDCHAR_P): Likewise. This one is never needed, but is used
1440 only in a comment talking about a compiler bug, so put inside
1441 the #if 0 of that comment.
1442 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1443 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1444 Remove; unused.
19ed5445 1445
1f3561e4 1446 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1447 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1448 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1449
ded6f8f7
PE
1450 * search.c (simple_search): Remove unused var.
1451
dbd37a95
PE
1452 * dired.c (compile_pattern): Move decl from here ...
1453 * lisp.h: ... to here, so that it can be checked.
1454 (struct re_registers): New forward decl.
1455
7e47afad
PE
1456 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1457
85f24f61
PE
1458 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1459 All uses changed.
1460 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1461 Rename locals to avoid shadowing.
5671df8f 1462 (Fvertical_motion): Mark locals as initialized.
85f24f61 1463
181aa2be 1464 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1465 (casify_region): Mark local as initialized.
181aa2be 1466
930d429c
PE
1467 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1468
7082eac6
PE
1469 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1470 New macros, so that the caller can use some names other than
1471 gcpro1, gcpro2, etc.
1472 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1473 of the new macros.
1474 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1475 argument, for consistency with GCPRO2_VAR, etc: it is now the
1476 prefix of the variable, not the variable itself. All uses
1477 changed.
38b2c076
PE
1478 * dired.c (directory_files_internal, file_name_completion):
1479 Rename locals to avoid shadowing.
1480
15206ed9
PE
1481 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1482 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1483 dired.c's scmp function, had undefined behavior.
1484 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1485 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1486 * buffer.h: ... to here, because these macros use current_buffer,
1487 and the new implementation with inline functions needs to have
1488 current_buffer in scope now, rather than later when the macros
1489 are used.
1490 (downcase, upcase1): New static inline functions.
1491 (DOWNCASE, UPCASE1): Reimplement using these functions.
1492 This avoids undefined behavior in expressions like
1493 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1494 from race conditions in accessing the global variables
1495 case_temp1 and case_temp2.
1496 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1497 * lisp.h (case_temp1, case_temp2): Remove their decls.
1498 * character.h (ASCII_CHAR_P): Move from here ...
1499 * lisp.h: ... to here, so that the inline functions mentioned
1500 above can use them.
1501
4a6bea26
PE
1502 * dired.c (directory_files_internal_unwind): Now static.
1503
f14b7e14
PE
1504 * fileio.c (file_name_as_directory, directory_file_name):
1505 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1506 Now static.
2893f146
PE
1507 (file_name_as_directory): Use const pointers when appropriate.
1508 (Fexpand_file_name): Likewise. In particular, newdir might
1509 point at constant storage, so make it a const pointer.
fd4ead52 1510 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1511 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1512 signedness issues.
f839df0c
PE
1513 (Fset_file_times, Finsert_file_contents, auto_save_error):
1514 Rename locals to avoid shadowing.
f14b7e14 1515
5716756e 1516 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1517 (Ftry_completion, Fall_completions): Rename or remove locals
1518 to avoid shadowing.
5716756e 1519
b4c3046a
PE
1520 * marker.c (bytepos_to_charpos): Remove; unused.
1521
b45db522
PE
1522 * lisp.h (verify_bytepos, count_markers): New decls,
1523 so that gcc does not warn that these functions aren't declared.
1524
85876d07
PE
1525 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1526 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1527 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1528 (copy_text): Remove unused local var.
85876d07 1529
03d78a21 1530 * filelock.c (within_one_second): Now static.
b3dd38ab 1531 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1532
5df8f01b
PE
1533 * buffer.c (fix_overlays_before): Mark locals as initialized.
1534 (fix_start_end_in_overlays): Likewise. This function should be
1535 simplified by using pointers-to-pointers, but that's a different
1536 matter.
b1d876f1 1537 (switch_to_buffer_1): Now static.
8f54f30a
PE
1538 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1539 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1540
a70072c9 1541 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1542 Fix pointer signedness issue.
edced198
PE
1543 (sys_subshell): Mark local as volatile if checking for lint,
1544 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1545 (MAXPATHLEN): Define only if needed.
a70072c9 1546
a0977c44
PE
1547 * process.c (serial_open, serial_configure): Move decls from here ...
1548 * systty.h: ... to here, so that they can be checked.
1549
a884fdcc
PE
1550 * fns.c (get_random, seed_random): Move extern decls from here ...
1551 * lisp.h: ... to here, so that they can be checked.
1552
604efe86 1553 * sysdep.c (reset_io): Now static.
b8950c94 1554 (wait_for_termination_signal): Remove; unused.
604efe86 1555
38fc62d9
PE
1556 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1557 (copy_keymap_item, append_key, push_text_char_description):
1558 Now static.
1004a21a 1559 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1560 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1561 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1562 (describe_map_tree):
1563 Rename locals to avoid shadowing.
38fc62d9 1564
2f2650da
PE
1565 * keyboard.c: Declare functions static if they are not used elsewhere.
1566 (echo_char, echo_dash, cmd_error, top_level_2):
1567 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1568 (read_char, kbd_buffer_get_event, make_lispy_position):
1569 (make_lispy_event, make_lispy_movement, apply_modifiers):
1570 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1571 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1572 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1573 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1574 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1575
a053e86c 1576 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1577 (mark_kboards): Move decl here ...
1578 * alloc.c (mark_kboards): ... from here.
a053e86c 1579
4752793e
PE
1580 * lisp.h (force_auto_save_soon): New decl.
1581
74f10ca7 1582 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1583 (DEFINE_DUMMY_FUNCTION): New macro.
1584 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1585 Use it.
c03cd23f
PE
1586 (main): Add casts to avoid warnings
1587 if GCC considers string literals to be constants.
74f10ca7 1588
022e70d4
PE
1589 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1590
59d6fe83
PE
1591 * dbusbind.c: Pointer signedness fixes.
1592 (xd_signature, xd_append_arg, xd_initialize):
1593 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1594 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1595 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1596 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1597
78320123
PE
1598 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1599 if GCC considers string literals to be constants.
49cebcca 1600 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1601
35ac2a97
SM
16022011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1603
fb103ca9
SM
1604 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1605 (print_preprocess, print_object): New macro to fix last change.
1606
35ac2a97
SM
1607 * print.c (print_preprocess): Don't forget font objects.
1608
62973b41
JB
16092011-03-16 Juanma Barranquero <lekktu@gmail.com>
1610
1611 * emacs.c (USAGE3): Doc fixes.
1612
0e48bb22
AS
16132011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1614
1615 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1616 structure.
1617
7684e57b
JB
16182011-03-14 Juanma Barranquero <lekktu@gmail.com>
1619
1620 * lisp.h (VWindow_system, Qfile_name_history):
1621 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1622 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1623 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1624
1625 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1626 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1627
1628 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1629 * w32console.c (detect_input_pending, read_input_pending)
1630 (encode_terminal_code):
1631 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1632 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1633 (w32_system_caret_y, Qfile_name_history):
1634 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1635 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1636 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1637 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1638 * w32proc.c (Qlocal, report_file_error):
1639 * w32term.c (Vwindow_system, updating_frame):
1640 * w32uniscribe.c (initialized, uniscribe_font_driver):
1641 Remove unneeded extern declarations.
1642
2aa46d6c
CY
16432011-03-14 Chong Yidong <cyd@stupidchicken.com>
1644
c96bbc66 1645 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1646
cffc6f3b
CY
16472011-03-13 Chong Yidong <cyd@stupidchicken.com>
1648
1649 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1650 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1651 These macros can no longer be used for assignment.
1652
44f230aa
SM
1653 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1654 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1655 (record_buffer_markers, fetch_buffer_markers): New functions for
1656 recording and fetching special buffer markers.
1657 (set_buffer_internal_1, set_buffer_temp): Use them.
1658
1659 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1660
1661 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1662
1663 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1664 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1665
1666 * xdisp.c (hscroll_window_tree):
1667 (reconsider_clip_changes): Use PT instead of BUF_PT.
1668
d251f04b
EZ
16692011-03-13 Eli Zaretskii <eliz@gnu.org>
1670
1671 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1672 $(EMACS_ROOT)/lib/intprops.h.
1673
f0c77cd1
PE
16742011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1675
3eca4629
PE
1676 Fix more problems found by GCC 4.5.2's static checks.
1677
7c86ee98
PE
1678 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1679 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1680 (xg_free_frame_widgets): Make it clear that a local variable is
1681 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1682 (gdk_window_get_screen): Make it clear that this macro is needed
1683 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1684 (int_gtk_range_get_value): New function, which avoids a diagnostic
1685 from gcc -Wbad-function-cast.
1686 (xg_set_toolkit_scroll_bar_thumb): Use it.
1687 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1688 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1689 (get_utf8_string, xg_get_file_with_chooser):
1690 Rename locals to avoid shadowing.
1691 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1692
41729b81
PE
1693 * xgselect.c (xg_select): Remove unused var.
1694
f0c77cd1
PE
1695 * image.c (four_corners_best): Mark locals as initialized.
1696 (gif_load): Initialize transparent_p to zero (Bug#8238).
1697 Mark another local as initialized.
ec6cf4c6 1698 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1699
ce0ad53d 1700 * image.c (clear_image_cache): Now static.
d5d5a617 1701 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1702 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1703 (x_edge_detection): Remove unnecessary cast that
1704 gcc -Wbad-function-cast diagnoses.
2037898d 1705 (gif_load): Fix pointer signedness.
6ae141d6
PE
1706 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1707 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1708
33383987 17092011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1710
d32df629
PE
1711 Improve quality of tests for time stamp overflow.
1712 For example, without this patch (encode-time 0 0 0 1 1
1713 1152921504606846976) returns the obviously-bogus value (-948597
1714 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1715 reports time overflow. See
1716 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1717 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1718 * editfns.c: Include limits.h and intprops.h.
1719 (TIME_T_MIN, TIME_T_MAX): New macros.
1720 (time_overflow): Move earlier, to before first use.
1721 (hi_time, lo_time): New functions, for an accurate test for
1722 out-of-range times.
1723 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1724 (Fget_internal_run_time): Don't assume time_t fits in int.
1725 (make_time): Use list2 instead of Fcons twice.
1726 (Fdecode_time): More accurate test for out-of-range times.
1727 (check_tm_member): New function.
1728 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1729 (lisp_time_argument): Don't rely on undefined left-shift and
1730 right-shift behavior when checking for time stamp overflow.
8be6f318 1731
fe31d94c
PE
1732 * editfns.c (time_overflow): New function, refactoring common code.
1733 (Fformat_time_string, Fdecode_time, Fencode_time):
1734 (Fcurrent_time_string): Use it.
1735
8be6f318
PE
1736 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1737 * dired.c (make_time): Move to ...
1738 * editfns.c (make_time): ... here.
1739 * systime.h: Note the move.
1740
09d9db2c 17412011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1742
126bc0dc
YM
1743 * fringe.c (update_window_fringes): Remove unused variables.
1744
c47cbdfd
YM
1745 * unexmacosx.c (copy_data_segment): Also copy __got section.
1746 (Bug#8223)
1747
7ac80be9
EZ
17482011-03-12 Eli Zaretskii <eliz@gnu.org>
1749
c96bbc66 1750 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1751 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1752 Constify `char *' arguments and their references according to
1753 prototypes in tparam.h.
1754
ecb0f94d 1755 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1756
7ac80be9
EZ
1757 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1758 Adapt all references accordingly.
1759
1760 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1761
ef1fd07e
TT
17622011-03-11 Tom Tromey <tromey@redhat.com>
1763
1764 * buffer.c (syms_of_buffer): Remove obsolete comment.
1765
7ef4b50c
EZ
17662011-03-11 Eli Zaretskii <eliz@gnu.org>
1767
1768 * termhooks.h (encode_terminal_code): Declare prototype.
1769
1770 * msdos.c (encode_terminal_code): Don't declare prototype.
1771
1772 * term.c (encode_terminal_code): Now external again, used by
1773 w32console.c and msdos.c.
1774
44f230aa
SM
1775 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1776 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1777
4b1ec863 17782011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1779
1714f52b 1780 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1781
4b1ec863
PE
1782 * fringe.c (update_window_fringes): Mark locals as initialized
1783 (Bug#8227).
1784 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1785
524c7aa6
PE
1786 * alloc.c (mark_fringe_data): Move decl from here ...
1787 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1788 to check its interface.
1789 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1790
a5c0af81 1791 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1792 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1793 (fontset_font): Mark local as initialized.
a9a06e0b 1794 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1795
b4716021
PE
1796 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1797
811e9bac 1798 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1799 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1800 (x_own_selection, Fx_disown_selection_internal): Rename locals
1801 to avoid shadowing.
1802 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1803
7e3ab302
PE
1804 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1805 so that the caller can use some name other than gcpro1.
1806 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1807 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1808 (Fx_backspace_delete_keys_p):
1809 Use them to avoid shadowing, and rename vars to avoid shadowing.
1810 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1811 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1812 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1813 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1814 Remove unused locals.
7e3ab302
PE
1815 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1816 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1817 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1818 macros.
f78faa98 1819
e2b13473
PE
1820 * xterm.h (x_mouse_leave): New decl.
1821
77f23912
PE
1822 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1823 Remove unused functions.
cdf4ba58
PE
1824 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1825 (x_calc_absolute_position): Now static.
7411c686 1826 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1827 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1828 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1829 unless they are used.
38d0b34a
PE
1830 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1831 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1832 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1833 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1834 (x_error_catcher, x_connection_closed, x_error_handler):
1835 (x_error_quitter, xembed_send_message, x_iconify_frame):
1836 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1837 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1838 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1839
44f230aa
SM
1840 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1841 Rename or move locals to avoid shadowing.
6b463e58 1842 (tty_defined_color, merge_face_heights): Now static.
5967d051 1843 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1844 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1845 does not deduce is never used uninitialized.
73719eba
PE
1846 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1847 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1848
426994c3 1849 * terminal.c (store_terminal_param): Now static.
5489860b 1850
032f1620 1851 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1852 (set_frame_menubar): Remove unused local.
d4323972 1853 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1854 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1855 since they might point to immutable storage.
281585b0
PE
1856 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1857 since it's unused otherwise.
032f1620 1858
367c19e5 1859 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1860 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1861 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1862 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1863 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1864 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1865 does not deduce are never used uninitialized.
70739cbe 1866
07b48fa9
PE
1867 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1868
8868a238 1869 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1870 * window.c (window_loop, size_window):
1871 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1872
7e5cf297 1873 * window.c (display_buffer): Now static.
d6550a9f
PE
1874 (size_window): Mark variables that gcc -Wuninitialized
1875 does not deduce are never used uninitialized.
a586633d
PE
1876 * window.h (check_all_windows): New decl, to forestall
1877 gcc -Wmissing-prototypes diagnostic.
5b555da1 1878 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1879
f6095868
PE
1880 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1881 shadowing.
1882 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1883 Include <limits.h>.
1884 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1885 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1886 (load_charset_map): Mark variables that gcc -Wuninitialized
1887 does not deduce are never used uninitialized.
53df7c11 1888 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1889
f38b440c
PE
1890 * coding.c (coding_set_source, coding_set_destination):
1891 Use "else { /* comment */ }" rather than "else /* comment */;"
1892 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1893 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1894 a block, when the outer 'i' will do.
1895 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1896 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1897 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1898 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1899 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1900 Rename locals to avoid shadowing.
1901 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1902 * coding.c (emacs_mule_char, encode_invocation_designation):
1903 Now static, since they're not used elsewhere.
413bb2db 1904 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1905 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1906 (decode_coding_emacs_mule): Mark variables that gcc
1907 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1908 (detect_coding_iso_2022): Initialize a local variable that might
1909 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1910 this initialization is needed. (Bug#8211)
5f58e762
PE
1911 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1912 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1913 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1914 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1915 Remove unused macros.
f38b440c 1916
232b38b9 1917 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1918 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1919 * character.c (string_count_byte8): Likewise.
232b38b9 1920
fb90da1b
PE
1921 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1922 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1923
fb93dbc2
PE
1924 * chartab.c (copy_sub_char_table): Now static, since it's not used
1925 elsewhere.
5c156ace
PE
1926 (sub_char_table_ref_and_range, char_table_ref_and_range):
1927 Rename locals to avoid shadowing.
bbcd0949 1928 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1929
7d3b3862 1930 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1931 (BIDI_BOB): Remove unused macro.
7d3b3862 1932
6be7d3da
PE
1933 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1934 deduce are never used uninitialized.
c2ed9c8b 1935 * term.c (encode_terminal_code): Likewise.
6be7d3da 1936
75f8807f 1937 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1938
50938595
PE
1939 * tparam.h: New file.
1940 * term.c, tparam.h: Include it.
1941 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1942 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1943 Move these decls to tparam.h, and make them agree with what
1944 is actually in tparam.c. The previous trick of using incompatible
1945 decls in different modules does not conform to the C standard.
1946 All callers of tparam changed to use tparam's actual API.
1947 * tparam.c (tparam1, tparam, tgoto):
1948 Use const pointers where appropriate.
1949
fbceeba2
PE
1950 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1951 * cm.h (struct cm): Likewise.
1952 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1953 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1954 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1955 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1956 (turn_on_face, init_tty): Likewise.
1957 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1958
7f3f1250
PE
1959 * term.c (term_mouse_position): Rename local to avoid shadowing.
1960
e6ca6543
PE
1961 * alloc.c (mark_ttys): Move decl from here ...
1962 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1963
c40f8d15
AS
19642011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1965
1966 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1967
cfe0661d
JB
19682011-03-09 Juanma Barranquero <lekktu@gmail.com>
1969
1970 * search.c (compile_pattern_1): Remove argument regp, unused since
1971 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1972 (compile_pattern): Don't pass it.
1973
0afb4571
J
19742011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1975
1976 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1977 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1978 for ! HAVE_GTK3.
1979 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1980
1981 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1982
1983 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1984 gdk_window_get_screen, gdk_window_get_geometry,
1985 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1986 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1987 (xg_get_pixbuf_from_pixmap): New function.
1988 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1989 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1990 Call xg_get_pixbuf_from_pixmap instead of
1991 gdk_pixbuf_get_from_drawable.
1992 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1993 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1994 (xg_check_special_colors): Use GtkStyleContext and its functions
1995 for HAVE_GTK3.
1996 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1997 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1998 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1999 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2000 Call gtk_widget_get_preferred_size.
0afb4571
J
2001 (xg_frame_resized): gdk_window_get_geometry only takes 5
2002 parameters.
44f230aa
SM
2003 (xg_win_to_widget, xg_event_is_for_menubar):
2004 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2005 (xg_set_widget_bg): New function.
2006 (delete_cb): New function.
2007 (xg_create_frame_widgets): connect delete-event to delete_cb.
2008 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2009 (xg_set_background_color): Call xg_set_widget_bg.
2010 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2011 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2012 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2013 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2014 if ! HAVE_GTK3.
2015 (update_frame_tool_bar): Call gtk_widget_hide.
2016 (xg_initialize): Use GDK_KEY_g.
2017
2018 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2019 if ! HAVE_GTK3
2020 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2021
2022 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2023 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2024 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2025
1c2cc4ef
JB
20262011-03-08 Juanma Barranquero <lekktu@gmail.com>
2027
2028 * w32xfns.c (select_palette): Check success of RealizePalette against
2029 GDI_ERROR, not zero.
2030
33383987 2031See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2032
2033;; Local Variables:
2034;; coding: utf-8
aac0c6e3
MR
2035;; End:
2036
33383987 2037 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2038
2039 This file is part of GNU Emacs.
2040
2041 GNU Emacs is free software: you can redistribute it and/or modify
2042 it under the terms of the GNU General Public License as published by
2043 the Free Software Foundation, either version 3 of the License, or
2044 (at your option) any later version.
2045
2046 GNU Emacs is distributed in the hope that it will be useful,
2047 but WITHOUT ANY WARRANTY; without even the implied warranty of
2048 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2049 GNU General Public License for more details.
2050
2051 You should have received a copy of the GNU General Public License
2052 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.