Tweak Emacs manual info menu ordering.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
041a49a6
DA
12012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Do not use Fdelete_overlay in delete_all_overlays
4 to avoid redundant calls to unchain_overlay.
5 * buffer.c (drop_overlay): New function.
6 (delete_all_overlays, Fdelete_overlay): Use it.
7 * minibuf.c (get_minibuffer): Fix comment.
8
7dca65a4
PE
92012-07-06 Paul Eggert <eggert@cs.ucla.edu>
10
11 Port to OpenBSD 5.1 amd64.
12 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
13 This is needed for OpenBSD, and should be harmless on all BSD systems.
14 Also, include <sys/sysctl.h>, as it should be available on all
15 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
16 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
17 use p_pid member, not kp_proc.pid.
18
8eb876e2
GM
192012-07-06 Glenn Morris <rgm@gnu.org>
20
21 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
22
38182d90
PE
232012-07-05 Paul Eggert <eggert@cs.ucla.edu>
24
25 More xmalloc and related cleanup.
26 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
27 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
28 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
29 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
30 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
31 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
32 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
33 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
34 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
35 * xterm.c:
36 Omit needless casts involving void * pointers and allocation.
37 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
38 as the former is more robust if P's type is changed.
39 Prefer xzalloc to xmalloc + memset 0.
40 Simplify malloc-or-realloc to realloc.
41 Don't worry about xmalloc returning a null pointer.
42 Prefer xstrdup to xmalloc + strcpy.
43 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
44 growing it.
45 * keyboard.c (apply_modifiers_uncached): Prefer local array to
46 alloca of a constant.
47
6dd5a677
EZ
482012-07-05 Eli Zaretskii <eliz@gnu.org>
49
50 * xdisp.c (display_line): Fix horizontal pixel coordinates when
51 hscroll is larger than the line width. Fixes long and futile
52 looping inside extend_face_to_end_of_line (on a TTY) producing
53 glyphs that are not needed and thrown away.
54
6b312f0f
DA
552012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
56
57 * marker.c (set_marker_restricted_both): Simplify by using
58 clip_to_bounds.
59
f520ef9b
PE
602012-07-05 Paul Eggert <eggert@cs.ucla.edu>
61
62 * editfns.c (region_limit): Simplify by using clip_to_bounds.
63
383b7c95
JD
642012-07-05 Jan Djärv <jan.h.d@swipnet.se>
65
66 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
67 not defined (Bug#11768).
68 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
69 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
70 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
71 followed by gtk_box_set_homogeneous (Bug#11768).
72 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
73 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
74 gtk_scrollbar_new (Bug#11768).
75 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
76 (is_box_type): New function (Bug#11768).
77 (xg_tool_item_stale_p): Call is_box_type.
78 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
79 with default display (Bug#11768).
80
d6e7bf45
EZ
812012-07-05 Eli Zaretskii <eliz@gnu.org>
82
83 * xdisp.c (window_hscroll_limited): New function.
84 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
85 coordinates when window's hscroll is set to insanely large
86 values. (Bug#11857)
87
431391ec
JB
882012-07-05 Juanma Barranquero <lekktu@gmail.com>
89
90 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
91 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
92
23f86fce
DA
932012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
94
95 Cleanup xmalloc.
96 * lisp.h (xzalloc): New prototype. Omit needless casts.
97 * alloc.c (xzalloc): New function. Omit needless casts.
98 * charset.c: Omit needless casts. Convert all calls to
99 xmalloc with following memset to xzalloc.
100 * dispnew.c: Likewise.
101 * fringe.c: Likewise.
102 * image.c: Likewise.
103 * sound.c: Likewise.
104 * term.c: Likewise.
105 * w32fns.c: Likewise.
106 * w32font.c: Likewise.
107 * w32term.c: Likewise.
108 * xfaces.c: Likewise.
109 * xfns.c: Likewise.
110 * xterm.c: Likewise.
111 * atimer.c: Omit needless casts.
112 * buffer.c: Likewise.
113 * callproc.c: Likewise.
114 * ccl.c: Likewise.
115 * coding.c: Likewise.
116 * composite.c: Likewise.
117 * doc.c: Likewise.
118 * doprnt.c: Likewise.
119 * editfns.c: Likewise.
120 * emacs.c: Likewise.
121 * eval.c: Likewise.
122 * filelock.c: Likewise.
123 * fns.c: Likewise.
124 * gtkutil.c: Likewise.
125 * keyboard.c: Likewise.
126 * lisp.h: Likewise.
127 * lread.c: Likewise.
128 * minibuf.c: Likewise.
129 * msdos.c: Likewise.
130 * print.c: Likewise.
131 * process.c: Likewise.
132 * region-cache.c: Likewise.
133 * search.c: Likewise.
134 * sysdep.c: Likewise.
135 * termcap.c: Likewise.
136 * terminal.c: Likewise.
137 * tparam.c: Likewise.
138 * w16select.c: Likewise.
139 * w32.c: Likewise.
140 * w32reg.c: Likewise.
141 * w32select.c: Likewise.
142 * w32uniscribe.c: Likewise.
143 * widget.c: Likewise.
144 * xdisp.c: Likewise.
145 * xmenu.c: Likewise.
146 * xrdb.c: Likewise.
147 * xselect.c: Likewise.
148
0497dc44
PE
1492012-07-05 Paul Eggert <eggert@cs.ucla.edu>
150
151 * fileio.c (time_error_value): Check the right error number.
152 Problem reported by Troels Nielsen in
153 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
154
356e7178
PE
1552012-07-04 Paul Eggert <eggert@cs.ucla.edu>
156
4e71fd89
PE
157 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
158 This should be fixed in a better way; see Eli Zaretskii in
159 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
160 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
161
f0941253
PE
162 * fileio.c (time_error_value): Rename from special_mtime.
163 The old name's problems were noted by Eli Zaretskii in
164 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
165
065c9eb4
PE
166 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
167 This variable's comment says Emacs needs at least one GDB-visible
168 symbol of type enum pvec_type, to work around GDB problems.
169 The symbol's value doesn't matter.
170
356e7178
PE
171 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
172 that causes compilation to fail on pre-C99 compilers.
173
95f61aa2
JB
1742012-07-04 Juanma Barranquero <lekktu@gmail.com>
175
176 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
177 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
178
3884d954
DA
1792012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
180
d209e2fb 181 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
182 headers for buffer_defaults and buffer_local_symbols.
183 Reported by Juanma Barranquero <lekktu@gmail.com>.
184
ee28be33
SM
1852012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
186
187 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
188 * lisp.h (enum pvec_type): Use fewer bits.
189 (PSEUDOVECTOR_SIZE_BITS): New constant.
190 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
191 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
192 change in pvec_type.
193 (PSEUDOVECTOR_TYPEP): New macro.
194 (TYPED_PSEUDOVECTORP): Use it.
195 * fns.c (internal_equal): Adapt code to extract pvectype.
196 * emacs.c (gdb_pvec_type): Update type.
197 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
198 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
199 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
200 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
201 (sweep_vectors): Use it. Use local var `total_bytes' instead of
202 abusing vector->header.next.nbytes.
203 (live_vector_p): Use PVEC_TYPE.
204 (mark_object): Adapt code to extract pvectype. Use switch.
205
c7f2cd7f
PE
2062012-07-04 Paul Eggert <eggert@cs.ucla.edu>
207
208 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
209 Tighten new eassert a bit.
210
8ce70ed2
DA
2112012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
212
213 Fix compilation with --enable-gcc-warnings and -O1
214 optimization level.
215 * doprnt.c (doprnt): Change type of tem to int, initialize
216 to avoid compiler warning. Add eassert.
217 * search.c (simple_search): Initialize match_byte to avoid
218 compiler warning. Add eassert.
219
dea7f1e5
PE
2202012-07-04 Paul Eggert <eggert@cs.ucla.edu>
221
24a212eb
PE
222 Avoid weird behavior with large horizontal scrolls.
223 Without this change, for example, large hscroll values would
224 mess up Emacs's display on Fedora 15 x86, presumably due to
225 overflows in int calculations in the display code.
226 Also, if buffers had long lines, Emacs would freeze.
227 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
228 (set_window_hscroll): New function, containing the old guts of
229 Fset_window_hscroll. Return the clipped value.
230 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
231 This avoids the need to check against PTRDIFF_MAX.
232
dea7f1e5
PE
233 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
234
76046526
DA
2352012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
236
237 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
238
39adff0d
PE
2392012-07-04 Paul Eggert <eggert@cs.ucla.edu>
240
63807d47
PE
241 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
242 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
243 since GCC 4.4.6 issues a bogus warning for them.
244
39adff0d
PE
245 Fix bugs in file timestamp newness comparisons.
246 * fileio.c (Ffile_newer_than_file_p):
247 * lread.c (Fload): Use full timestamp resolution of files,
248 not just the 1-second resolution, so that files that are only
249 slightly newer still count as newer.
250 * fileio.c (Ffile_newer_than_file_p): Don't assume file
251 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
252
dbeed9a6
PE
2532012-07-03 Paul Eggert <eggert@cs.ucla.edu>
254
255 * fileio.c: Improve handling of file time marker. (Bug#11852)
256 (special_mtime): New function.
257 (Finsert_file_contents, Fverify_visited_file_modtime):
258 Use it to set special mtime values consistently.
259
636334d6
AS
2602012-07-03 Andreas Schwab <schwab@linux-m68k.org>
261
262 * fileio.c (Finsert_file_contents): Properly handle st_mtime
263 marker for non-existing file. (Bug#11852)
264
e2017fe2
GM
2652012-07-03 Glenn Morris <rgm@gnu.org>
266
267 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
268 and did not make it into globals.h).
269
404dbd37
TT
2702012-07-03 Tom Tromey <tromey@redhat.com>
271
272 * window.c (Fset_window_margins, Fset_window_fringes)
273 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
274 * textprop.c (Fprevious_property_change): No longer static.
275 * syntax.c (Fsyntax_table_p): No longer static.
276 * process.c (Fget_process, Fprocess_datagram_address): No longer
277 static.
278 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
279 * keyboard.c (Fcommand_execute): No longer static.
280 Remove EXFUN.
281 * insdel.c (Fcombine_after_change_execute): No longer static.
282 * image.c (Finit_image_library): No longer static.
283 * fileio.c (Fmake_symbolic_link): No longer static.
284 * eval.c (Ffetch_bytecode): No longer static.
285 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
286 * doc.c (Fdocumentation_property, Fsnarf_documentation):
287 No longer static.
404dbd37
TT
288 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
289 static.
290 * dired.c (Ffile_attributes): No longer static.
291 * composite.c (Fcomposition_get_gstring): No longer static.
292 * callproc.c (Fgetenv_internal): No longer static.
293
294 * ccl.h: Remove EXFUNs.
295 * buffer.h: Remove EXFUNs.
296 * dispextern.h: Remove EXFUNs.
297 * intervals.h: Remove EXFUNs.
298 * fontset.h: Remove EXFUN.
299 * font.h: Remove EXFUNs.
300 * dosfns.c (system_process_attributes): Remove EXFUN.
301 * keymap.h: Remove EXFUNs.
302 * lisp.h: Remove EXFUNs.
303 * w32term.h: Remove EXFUNs.
304 * window.h: Remove EXFUNs.
305 * xsettings.h: Remove EXFUN.
306 * xterm.h: Remove EXFUN.
307
8e4fd1e1
GM
3082012-07-03 Glenn Morris <rgm@gnu.org>
309
310 * lisp.h (Frandom): Make it visible to C.
311 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
312 buffer for invisible buffers. (Bug#1229)
313
ca95b3eb
DA
3142012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
315
316 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
317 values which aren't power of 2.
318 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
319 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
320 accordingly.
321
7555c33f
SM
3222012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
323
324 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
325
326 * alloc.c (mark_object): Revert part of last patch to use `switch'.
327
d12e8f5a
DA
3282012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
329
330 * alloc.c (allocate_vector_block): Remove redundant
331 calls to mallopt if DOUG_LEA_MALLOC is defined.
332 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
333 avoid calls to mallopt if zero_vector is returned.
334
296094c3
DA
3352012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
336
337 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
338 is enabled, avoid dereferencing NULL current_sblock if
339 running undumped.
340
36429c89
DA
3412012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
342
343 Cleanup basic buffer management.
344 * buffer.h (struct buffer): Change layout to use generic vector
345 marking code. Fix some comments. Change type of 'clip_changed'
346 to bitfield. Remove unused #ifndef old.
347 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
348 (GET_OVERLAYS_AT): Fix indentation.
349 (for_each_per_buffer_object_at): New macro.
350 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
351 (Fbuffer_local_variables): Use it.
352 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
353 * alloc.c (allocate_buffer): Adjust to match new layout of
354 struct buffer. Fix comment.
355 (mark_overlay): New function.
356 (mark_buffer): Use it. Use mark_vectorlike to mark normal
357 Lisp area of struct buffer.
358 (mark_object): Use it. Adjust marking of misc objects
359 and related comments.
360
3b3e4cac
PE
3612012-07-02 Paul Eggert <eggert@cs.ucla.edu>
362
363 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
364 wrapper that is not needed because the wrapped code is a no-op (zero
365 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
366 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
367
cf5c0175
DA
3682012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
369
370 * alloc.c (mark_buffer): Simplify. Remove prototype.
371 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 372 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
373 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
374 redundant calls to mark_vectorlike for bool vectors.
375
ca26824c
GM
3762012-06-30 Glenn Morris <rgm@gnu.org>
377
2e4c5312
GM
378 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
379
ca26824c
GM
380 * epaths.in (PATH_SITELOADSEARCH): New.
381 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
382 This is rather than relying on --enable-locallisppath elements
383 having "site-lisp" in their names. (Bug#10208#25, 11658)
384
0d23c240
EZ
3852012-06-30 Eli Zaretskii <eliz@gnu.org>
386
c9240d7a
EZ
387 * w32proc.c (sys_select): Accept and ignore one more argument.
388
389 * w32.c (emacs_gnutls_pull): Call select with one more argument.
390
0d23c240 391 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 392 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
393
394 * sysdep.c: Don't include dos.h and dosfns.h.
395
396 * process.c (sys_select):
397 * msdos.c (sys_select): Accept one more argument and ignore it.
398
399 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
400 adapt data types and code to that.
401
402 * dosfns.c:
403 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
404 which clashes with the gnulib function of the same name.
405
af5a5a98
AS
4062012-06-30 Andreas Schwab <schwab@linux-m68k.org>
407
c5e4379c
AS
408 * font.c (font_style_to_value, font_style_symbolic)
409 (font_prop_validate_style): Add type checks for values in
410 font_style_table.
411
af5a5a98
AS
412 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
413 argument.
414 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
415 uses.
416
8d38f461
EZ
4172012-06-29 Eli Zaretskii <eliz@gnu.org>
418
2e5a6631
EZ
419 * xdisp.c (try_window_id): Undo last change.
420
8d38f461
EZ
421 * w32.c (getwd): Adjust commentary about startup_dir.
422 (init_environment): Always call sys_access, even in non-MSVC
423 builds. Don't chdir to the directory of the Emacs executable.
424 This undoes code from 1997 which was justified by the need to
425 "avoid conflicts when removing and renaming directories". But its
426 downside was that every relative file name was being interpreted
427 relative to the directory of the Emacs executable, which can never
428 be TRT. In particular, it broke sys_access when called with
429 relative file names.
430 (sys_access): Map GetLastError to errno.
431
2af3565e
DA
4322012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
433
434 * window.h (struct window): Change type of 'fringes_outside_margins'
435 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 436 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
437 Adjust comment.
438 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
439 to ptrdiff_t.
440
c8d3a25c 4412012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 442
c8d3a25c
GM
443 * gnutls.c (emacs_gnutls_handshake):
444 Add QUIT to make the loop interruptible.
57570cd3 445
c8d3a25c 4462012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 447
c8d3a25c
GM
448 * charset.c (init_charset): Make lack of etc/charsets fatal.
449
3e984ee8
DA
4502012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
451
452 * editfns.c (region_limit): Fix type mismatch.
453
ef884f23
DA
4542012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
455
456 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
457 undefined. Convert from xassert to eassert.
458 * nsmenu.m: Convert from xassert to eassert.
459 * nsterm.m: Likewise.
460
7d7e0027
SM
4612012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
462
463 * editfns.c (region_limit): Clip to narrowing (bug#11770).
464
aa754e6a
PE
4652012-06-28 Paul Eggert <eggert@cs.ucla.edu>
466
467 Avoid integer overflow on scroll-left and scroll-right.
468 * window.c (HSCROLL_MAX): New macro.
469 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
470 overflow when requested scroll falls outside ptrdiff_t range.
471
80b00b08
DA
4722012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
473
474 * window.h (struct window): Change type of 'hscroll',
475 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
476 'last_modified' and 'last_overlay_modified' to EMACS_INT.
477 Adjust users accordingly.
478 * xdisp.c (try_cursor_movement): Replace type check with eassert.
479 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
480 from EMACS_INT to ptrdiff_t.
481 (make_window): Omit redundant initialization.
482
62b2bcf6
JB
4832012-06-28 Juanma Barranquero <lekktu@gmail.com>
484
485 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
486
45942c7d
DA
4872012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
488
489 * window.h (struct window): Change type of 'use_time' and
490 'sequence_number' from Lisp_Object to int.
491 * frame.c (make_frame): Adjust users accordingly.
492 * print.c (print_object): Likewise.
493 * window.c (select_window, Fwindow_use_time, make_parent_window)
494 (make_window): Likewise.
495
e509cfa6
DA
4962012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
497
498 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
499 enabled with --enable-checking=[all,glyphs] configure option.
500 Fix GLYPH_DEBUG usage assuming that it may be undefined,
501 adjust comments accordingly.
502 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
503 undefined, adjust comments accordingly.
504 * image.c: Likewise.
505 * scroll.c: Likewise.
506 * w32fns.c: Likewise.
507 * w32term.c: Likewise.
508 * xdisp.c: Likewise.
509 * xfaces.c: Likewise.
510 * xfns.c: Likewise.
511 * xterm.c: Likewise.
512
a54e2c05
DA
5132012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
514
515 Generalize run-time debugging checks.
516 * dispextern.h (XASSERTS): Remove.
517 * fontset.c (xassert): Remove.
518 Convert from xassert to eassert.
519 * alloc.c: Convert from xassert to eassert.
520 * bidi.c: Likewise.
521 * dispnew.c: Likewise.
522 * fns.c: Likewise.
523 * fringe.c: Likewise.
524 * ftfont.c: Likewise.
525 * gtkutil.c: Likewise.
526 * image.c: Likewise.
527 * keyboard.c: Likewise.
528 * menu.c: Likewise.
529 * process.c: Likewise.
530 * scroll.c: Likewise.
531 * sound.c: Likewise.
532 * term.c: Likewise.
533 * w32console.c: Likewise.
534 * w32fns.c: Likewise.
535 * w32term.c: Likewise.
536 * window.c: Likewise.
537 * xdisp.c: Likewise.
538 * xfaces.c: Likewise.
539 * xfns.c: Likewise.
540 * xselect.c: Likewise.
541 * xterm.c: Likewise.
542
1ec4b7b2
SM
5432012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
544
545 * fns.c (maybe_resize_hash_table): Output message when growing the
546 purify-hashtable.
547
2014308a
DA
5482012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
549
550 * alloc.c (allocate_string_data): Remove dead code.
551 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
552 avoid GCC warning about unused macro.
553
246155eb
DA
5542012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
555
556 * alloc.c (allocate_string): Omit intervals initialization.
557 * alloc.c (make_uninit_multibyte_string): Initialize intervals
558 as in make_pure_string and make_pure_c_string.
559
43184b7b
DA
5602012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
561
d209e2fb 562 * alloc.c (allocate_string): Fix last change.
43184b7b 563
3fe6dd74
DA
5642012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
565
d209e2fb 566 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
567 to memset, add explicit initialization where appropriate.
568
1ba6038a
GM
5692012-06-27 Glenn Morris <rgm@gnu.org>
570
571 * lisp.mk (lisp): Remove paths.elc.
572
c89926a5
CY
5732012-06-27 Chong Yidong <cyd@gnu.org>
574
575 * doc.c (Fsubstitute_command_keys): Fix punctuation.
576
ed6b3510
JW
5772012-06-26 John Wiegley <johnw@newartisans.com>
578
1ec4b7b2 579 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
580 on Mac OS X Lion: __mod_init_func and __mod_term_func.
581
ed6b3510
JW
582 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
583 when building with Clang.
584
8edd4a2b
SM
5852012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
586
587 * eval.c (Fapply): Allow calling it with a single argument.
588
f6f62d1b
EZ
5892012-06-26 Eli Zaretskii <eliz@gnu.org>
590
591 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
592 _stricmp and _strnicmp.
593 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
594
62efea5e
DA
5952012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
596
597 * alloc.c (allocate_window): Zero out non-Lisp part of newly
598 allocated window.
599 (allocate_process): Likewise for new process.
8edd4a2b 600 (allocate_terminal): Change to use offsetof.
62efea5e
DA
601 (allocate_frame): Likewise.
602 * frame.c (make_frame): Omit redundant initialization.
603 * window.c (make_parent_window): Use memset.
604 (make_window): Omit redundant initialization.
605 * process.c (make_process): Omit redundant initialization.
606 * terminal.c (create_terminal): Likewise.
607
42997f4d
DA
6082012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
609
610 * term.c (delete_tty): Remove redundant call to memset.
611
1130ecfc
DA
6122012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
613
614 * alloc.c: Remove build_string.
615 * lisp.h: Define build_string as static inline. This provides
616 a better opportunity to optimize away calls to strlen when the
617 function is called with compile-time constant argument.
618 * image.c (imagemagick_error): Convert to build_string.
619 * w32proc.c (sys_spawnve): Likewise.
620 * xterm.c (x_term_init): Likewise.
621
cf38a720
PE
6222012-06-26 Paul Eggert <eggert@cs.ucla.edu>
623
99027bdd
PE
624 Use sprintf return value instead of invoking strlen on result.
625 In the old days this wasn't portable, since some sprintf
626 implementations returned char *. But they died out years ago and
627 Emacs already assumes sprintf returns int.
628 Similarly for float_to_string.
629 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
630 * ccl.c (ccl_driver):
631 * character.c (string_escape_byte8):
632 * data.c (Fnumber_to_string):
633 * doprnt.c (doprnt):
634 * print.c (print_object):
635 * xdisp.c (message_dolog):
636 * xfns.c (syms_of_xfns):
637 Use sprintf or float_to_string result to avoid need to call strlen.
638 * data.c (Fnumber_to_string):
639 Use make_unibyte_string, since the string must be ASCII.
640 * lisp.h, print.c (float_to_string): Now returns int length.
641 * term.c (produce_glyphless_glyph):
642 Use sprintf result rather than recomputing it.
643
cf38a720
PE
644 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
645 * Makefile.in (ALL_CFLAGS):
646 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
647 * gmalloc.c, regex.c: Include <config.h> unconditionally.
648
3511c784
DA
6492012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
650
0a08eb21 651 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
652 strcasecmp if available.
653 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
654
fb7da12e
AS
6552012-06-25 Andreas Schwab <schwab@linux-m68k.org>
656
657 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
658 Avoid comma operator.
659 * menu.c (push_submenu_start, push_submenu_end)
660 (push_left_right_boundary, push_menu_pane): Likewise.
661 * msdos.c (dos_rawgetc): Likewise.
662
afa2ffd8
DA
6632012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
664
665 * xfns.c (xic_create_fontsetname): Remove redundant calls
666 to memset.
667
b3b4476b
PE
6682012-06-25 Paul Eggert <eggert@cs.ucla.edu>
669
4495ff38
PE
670 * gtkutil.c (get_utf8_string): Remove redundant assignment.
671 sprintf already null-terminates its output.
672
b3b4476b
PE
673 * xfns.c (x_window): Remove redundant cast.
674
b00876c9
DA
6752012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
676
677 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
678 `const char *' to `char *' to avoid compiler warning.
679
d188e26b
PE
6802012-06-24 Paul Eggert <eggert@cs.ucla.edu>
681
885d1d74
PE
682 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
683 instead of truncating it to 63 (admittedly a generous limit).
684
d188e26b
PE
685 * process.c: Fix spelling and caps in comments.
686
e2f560b1
DN
6872012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
688
e86db54b 689 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
690 * sysdep.c (setpgrp): Remove definition, not used in this file.
691
7583a3a1
JB
6922012-06-24 Juanma Barranquero <lekktu@gmail.com>
693
694 * makefile.w32-in: Update dependencies.
695
696056c2
EZ
6962012-06-24 Eli Zaretskii <eliz@gnu.org>
697
698 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
699 (SYSTIME_H): Add nt/inc/sys/time.h.
700
701 * systime.h [WINDOWSNT]: Include sys/time.h.
702
703 * s/ms-w32.h (struct timespec): Definition moved from
704 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
705
845ca893
PE
7062012-06-24 Paul Eggert <eggert@cs.ucla.edu>
707
708 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
709 * buffer.h (buffer_slot_type_mismatch):
710 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
711 * eval.c (unwind_to_catch):
712 * image.c (my_png_error, my_error_exit):
713 * keyboard.c (quit_throw_to_read_char, user_error)
714 (Fexit_recursive_edit, Fabort_recursive_edit):
715 * lisp.h (die, args_out_of_range, args_out_of_range_3)
716 (wrong_type_argument, buffer_overflow, __executable_start)
717 (memory_full, buffer_memory_full, string_overflow, Fthrow)
718 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
719 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
720 (fatal):
721 (child_setup) [!DOS_NT]:
722 * lread.c (end_of_file_error, invalid_syntax):
723 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
724 * puresize.h (pure_write_error):
725 * search.c (matcher_overflow):
726 * sound.c (sound_perror, alsa_sound_perror):
727 * sysdep.c, syssignal.h (croak):
728 * term.c (maybe_fatal, vfatal):
729 * textprop.c (text_read_only):
730 * undo.c (user_error):
731 * unexmacosx.c (unexec_error):
732 * xterm.c (x_ins_del_lines, x_delete_glyphs):
733 Use _Noreturn rather than NO_RETURN.
734 No need for separate decl merely because of _Noreturn.
735 * sound.c (sound_warning, parse_sound):
736 Remove unnecessary forward decls.
737
f1dd8073
PE
7382012-06-24 Paul Eggert <eggert@cs.ucla.edu>
739
740 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
741 * lisp.h (WAIT_READING_MAX): New macro.
742 * dispnew.c (Fsleep_for, sit_for):
743 * keyboard.c (kbd_buffer_get_event):
744 * process.c (Faccept_process_output):
745 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
746 This improves on the previous patch, which introduced a bug
747 when time_t is unsigned and as wide as intmax_t.
748 See <http://bugs.gnu.org/9000#51>.
749
b82c1755
EZ
7502012-06-23 Eli Zaretskii <eliz@gnu.org>
751
752 * dispnew.c (sit_for, Fsleep_for):
753 * keyboard.c (kbd_buffer_get_event):
754 * process.c (Faccept_process_output): Avoid compiler warnings when
755 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
756
ca300656
JB
7572012-06-23 Juanma Barranquero <lekktu@gmail.com>
758
049ec95b
JB
759 * makefile.w32-in: Update dependencies.
760
ca300656
JB
761 * w32.c (ltime): Add return type and declare static.
762 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
763
db7b8d06
PE
7642012-06-23 Paul Eggert <eggert@cs.ucla.edu>
765
766 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
767 Privately reported by Herbert J. Skuhra.
768 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
769 All uses changed.
770 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
771 not make_lisp_timeval, when the argument is of type EMACS_TIME.
772
0bd8297f
EZ
7732012-06-23 Eli Zaretskii <eliz@gnu.org>
774
96512555
EZ
775 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
776 last argument of make_unibyte_string.
777
0bd8297f
EZ
778 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
779 language ID in the event parameters.
780
781 * w32term.c (w32_read_socket): Put the new keyboard codepage into
782 event.code, not the obscure "character set ID".
783
63def6b6
CY
7842012-06-23 Chong Yidong <cyd@gnu.org>
785
786 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
787
e8a02204
EZ
7882012-06-23 Eli Zaretskii <eliz@gnu.org>
789
388cdec0
EZ
790 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
791 * w32.c (fdutimens): New function.
792
793 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
794
795 * s/ms-w32.h (pselect): Redirect to sys_select.
796
797 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
798
e8a02204
EZ
799 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
800 in the logic of incrementing and decrementing the value of
801 use_relocatable_buffers.
802
d054f3fb
PE
8032012-06-23 Paul Eggert <eggert@cs.ucla.edu>
804
805 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
806 Privately reported by Herbert J. Skuhra.
807 [__FreeBSD__]: Remove "*/" typo after "#include".
808 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
809 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
810 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
811 Don't assume EMACS_TIME and struct timeval are the same type.
812
d35af63c
PE
8132012-06-22 Paul Eggert <eggert@cs.ucla.edu>
814
815 Support higher-resolution time stamps (Bug#9000).
816 The time stamps are only nanosecond-resolution at the C level,
817 since that's the best that any real-world system supports now.
818 But they are picosecond-resolution at the Lisp level, as that's
819 easy, and leaves room for future OS improvements.
820
821 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
822 (LIBES): Use it.
823
824 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
825 Don't get current time unless it's needed.
826
827 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
828 now provides it if it's absent.
829 (start_atimer): Port to higher-res time stamps.
830 Check for time stamp overflow. Don't get current time more
831 often than is needed.
832
833 * buffer.h (struct buffer): Buffer modtime now has high resolution.
834 Include systime.h, not time.h.
835 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
836
837 * dired.c: Include stat-time.h.
838 (Ffile-attributes): File times now have higher resolution.
839
840 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
841 (struct image): Timestamp now has higher resolution.
842
843 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
844 has at least microseconds now. All uses removed.
845 (update_frame, update_single_window, update_window, update_frame_1)
846 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
847
848 * editfns.c (time_overflow): Now extern.
849 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
850 (float-time, Fformat_time_string, Fcurrent_time_string)
851 (Fcurrent_time_zone): Accept and generate higher-resolution
852 time stamps.
853 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
854 (decode_time_components, lisp_seconds_argument): New functions.
855 (make_time): Now static.
856 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
857 Report an error if the time is invalid, rather than having the caller
858 do that.
859
860 * fileio.c: Include <stat-time.h>
861 (Fcopy_file): Copy higher-resolution time stamps.
862 Prefer to set the time stamp via a file descriptor if that works.
863 (Fset_file_times, Finsert_file_contents, Fwrite_region)
864 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
865 (Fvisited_file_modtime, Fset_visited_file_modtime):
866 Support higher-resolution time stamps.
867
868 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
869
870 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
871
872 * image.c (prepare_image_for_display, clear_image_cache)
873 (lookup_image): Port to higer-resolution time stamps.
874
875 * keyboard.c (start_polling, bind_polling_period):
876 Check for time stamp overflow.
877 (read_char, kbd_buffer_get_event, timer_start_idle)
878 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
879 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
880 Port to higher-resolution time stamps. Do not assume time_t is signed.
881 (decode_timer): New function. Timers are now vectors of length 9,
882 not 8, to accommodate the picosecond component.
883 (timer_check_2): Use it.
884
885 * nsterm.m (select_timeout, timeval_subtract): Remove.
886 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
887 as they're a bit more accurate and handle overflow better.
888 (ns_select): Change prototype to be compatible with pselect.
889 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
890 * nsterm.h (ns_select): Adjust prototype.
891
892 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
893 us-resolution time stamps.
894 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
895
896 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
897
898 * lisp.h (time_overflow): New decl.
899 (wait_reading_process_output): First arg is now intmax_t, not int,
900 to accommodate larger waits.
901
902 * process.h (struct Lisp_Process.read_output_delay):
903 Now counts nanoseconds, not microseconds.
904 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
905 EMACS_HAS_USECS.
906 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
907 (wait_reading_process_output):
908 Port to ns-resolution time stamps.
909 (Faccept_process_output, wait_reading_process_output):
910 Check for time stamp overflow. Do not assume time_t is signed.
911 (select_wrapper): Remove; we now use pselect.
912 (Fprocess_attributes): Now generates ns-resolution time stamps.
913
914 * sysdep.c: Include utimens.h. Don't include utime.h
915 or worry about struct utimbuf; gnulib does that for us now.
916 (gettimeofday): Remove; gnulib provides a substitute.
917 (make_timeval): New function.
918 (set_file_times): Now sets ns-resolution time stamps.
919 New arg FD; all uses changed.
920 (time_from_jiffies, ltime_from_jiffies, get_up_time)
921 (system_process_attributes):
922 Now returns ns-resolution time stamp. All uses changed.
923 Check for time stamp overflow.
924
925 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
926 provides a substitute now.
927
928 * systime.h: Include timespec.h rather than sys/time.h and time.h,
929 since it guarantees struct timespec.
930 (EMACS_TIME): Now struct timespec, so that we can support
931 ns-resolution time stamps.
932 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
933 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
934 (EMACS_USECS): Remove.
935 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
936 so multiply the arg by 1000 before storing it.
937 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
938 New macros.
939 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
940 Port to ns-resolution time stamps.
941 (EMACS_TIME_NEG_P): Remove; replaced by....
942 (EMACS_TIME_SIGN): New macro.
943 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
944 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
945 (set_file_times, make_time, lisp_time_argument): Adjust signature.
946 (make_timeval, make_lisp_time, decode_time_components): New decls.
947 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
948 that it mishandled time_t overflow. You can't compare by subtracting!
949 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
950 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
951
952 * term.c: Include <sys/time.h>.
953 (timeval_to_Time): New function, for proper overflow wraparound.
954 (term_mouse_position, term_mouse_click): Use it.
955
956 * undo.c (record_first_change): Support higher-resolution time stamps
957 in the undo buffer.
958 (Fprimitive_undo): Use them when restoring time stamps.
959
960 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
961 (w32_get_internal_run_time):
962 Port to higher-resolution Emacs time stamps.
963 (ltime): Now accepts single 64-bit integer, as that's more convenient
964 for callers.
965
966 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
967
968 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
969 for compatibility with pselect. Support ns-resolution time stamps.
970
971 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
972
973 * xselect.c (wait_for_property_change, x_get_foreign_selection):
974 Check for time stamp overflow, and support ns-resolution time stamps.
975
976 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
977 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
978 (timeval_subtract): Remove; no longer needed.
979 (XTflash, XTring_bell, x_wait_for_event):
980 Port to ns-resolution time stamps. Don't assume time_t is signed.
981
b6a92dfe
CY
9822012-06-22 Chong Yidong <cyd@gnu.org>
983
984 * xdisp.c (x_consider_frame_title): Revert last change.
985
d251c37c
EZ
9862012-06-22 Eli Zaretskii <eliz@gnu.org>
987
988 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
989 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
990 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
991 staticidx goes up to 1597 out of 1600 = 0x640.)
992
f10deafb
PE
9932012-06-20 Paul Eggert <eggert@cs.ucla.edu>
994
995 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
996 Otherwise, the umask might be mistakenly 0 while handling input signals.
997
ec6de1e2
SM
9982012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
999
1000 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1001
28be1ada
DA
10022012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1003
1004 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1005 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1006 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1007 access to `contents' member of Lisp_Vector objects with AREF and ASET
1008 where appropriate.
1009
c6bf3022
CY
10102012-06-19 Chong Yidong <cyd@gnu.org>
1011
1012 * frame.c (delete_frame): When selecting a frame on a different
1013 text terminal, do not alter the terminal's top-frame.
1014
1015 * xdisp.c (format_mode_line_unwind_data): Record the target
1016 frame's selected window and its terminal's top-frame.
1017 (unwind_format_mode_line): Restore them.
1018 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1019 Callers changed.
1020 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1021 since tty frames can be explicitly named.
1022 (prepare_menu_bars): Likewise.
1023
1024 * term.c (Ftty_top_frame): New function.
1025
defd4196
PE
10262012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 Port byte-code-meter to modern targets.
1029 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1030 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1031 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1032 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1033 (METER_1, METER_2): Simplify.
1034
1053a871
SM
10352012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1036
1037 * data.c (Fdefalias): Return `symbol' (bug#11686).
1038
b7e8d081
MR
10392012-06-18 Martin Rudalics <rudalics@gmx.at>
1040
1041 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1042 gets killed during executing of this function (Bug#11665).
1043 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1044 (Vkill_buffer_query_functions): In doc-string say that functions
1045 run by this hook should not change the current buffer.
1046
7ea2b339
PE
10472012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1048
1049 Fix recently-introduced process.c problems found by static checking.
1050 * process.c (write_queue_push, write_queue_pop, send_process):
1051 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1052 (write_queue_pop): Fix pointer signedness problem.
1053 (send_process): Remove unused local.
1054
96a313a1
CY
10552012-06-17 Chong Yidong <cyd@gnu.org>
1056
1057 * xdisp.c (redisplay_internal): No need to redisplay terminal
1058 frames that are not on top.
1059
20ca2e94
TN
10602012-06-17 Troels Nielsen <bn.troels@gmail.com>
1061
1062 * process.c (make_process): Initialize write_queue.
1063 (write_queue_push, write_queue_pop): New functions.
1064 (send_process): Use them to maintain correct ordering of process
1065 writes (Bug#10815).
1066
9a900ca9
PE
10672012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1068
310fbfa8
PE
1069 * lisp.h (eassert): Assume C89 or later.
1070 This removes the need for CHECK.
1071 (CHECK): Remove. Its comments about always evaluating its
1072 argument were confusing, as 'eassert' typically does not evaluate
1073 its argument.
1074
27bb1ca4
PE
1075 * coding.c (produce_chars): Use ptrdiff_t, not int.
1076
9a900ca9
PE
1077 * xterm.c (x_draw_underwave): Check for integer overflow.
1078 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1079
41b7f8bc 10802012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1081
1082 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1083 referenced (Bug#11583).
1084
9b0e3eba
AA
10852012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1086
1087 Implement wave-style variant of underlining.
1088 * dispextern.h (face_underline_type): New enum.
1089 (face): Add field for underline type.
1090 * nsterm.m (ns_draw_underwave): New function.
1091 (ns_draw_text_decoration): Use it.
1092 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1093 New functions.
1094 (x_draw_glyph_string): Use them.
1095 * xfaces.c (Qline, Qwave): New Lisp objects.
1096 (check_lface_attrs, merge_face_ref)
1053a871
SM
1097 (Finternal_set_lisp_face_attribute, realize_x_face):
1098 Handle wave-style underline face attributes.
9b0e3eba
AA
1099 * xterm.c (x_draw_underwave): New function.
1100 (x_draw_glyph_string): Use it.
1101
0fb52f11
JB
11022012-06-16 Juanma Barranquero <lekktu@gmail.com>
1103
1104 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1105 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1106 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1107 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1108 ($(BLD)/w32select.$(O)): Update dependencies.
1109
e5560ff7
AS
11102012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1111
1112 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1113 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1114 * character.c (_fetch_multibyte_char_p): Remove.
1115 * alloc.c: Include "character.h" before "buffer.h".
1116 * bidi.c: Likewise.
1117 * buffer.c: Likewise.
1118 * bytecode.c: Likewise.
1119 * callint.c: Likewise.
1120 * callproc.c: Likewise.
1121 * casefiddle.c: Likewise.
1122 * casetab.c: Likewise.
1123 * category.c: Likewise.
1124 * cmds.c: Likewise.
1125 * coding.c: Likewise.
1126 * composite.c: Likewise.
1127 * dired.c: Likewise.
1128 * dispnew.c: Likewise.
1129 * doc.c: Likewise.
1130 * dosfns.c: Likewise.
1131 * editfns.c: Likewise.
1132 * emacs.c: Likewise.
1133 * fileio.c: Likewise.
1134 * filelock.c: Likewise.
1135 * font.c: Likewise.
1136 * fontset.c: Likewise.
1137 * fringe.c: Likewise.
1138 * indent.c: Likewise.
1139 * insdel.c: Likewise.
1140 * intervals.c: Likewise.
1141 * keyboard.c: Likewise.
1142 * keymap.c: Likewise.
1143 * lread.c: Likewise.
1144 * macros.c: Likewise.
1145 * marker.c: Likewise.
1146 * minibuf.c: Likewise.
1147 * nsfns.m: Likewise.
1148 * nsmenu.m: Likewise.
1149 * print.c: Likewise.
1150 * process.c: Likewise.
1151 * regex.c: Likewise.
1152 * region-cache.c: Likewise.
1153 * search.c: Likewise.
1154 * syntax.c: Likewise.
1155 * term.c: Likewise.
1156 * textprop.c: Likewise.
1157 * undo.c: Likewise.
1158 * unexsol.c: Likewise.
1159 * w16select.c: Likewise.
1160 * w32fns.c: Likewise.
1161 * w32menu.c: Likewise.
1162 * window.c: Likewise.
1163 * xdisp.c: Likewise.
1164 * xfns.c: Likewise.
1165 * xmenu.c: Likewise.
1166 * xml.c: Likewise.
1167 * xselect.c: Likewise.
1168
2f07e6af
EZ
11692012-06-16 Eli Zaretskii <eliz@gnu.org>
1170
1053a871
SM
1171 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1172 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1173 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1174 row.
1175 (handle_face_prop): Use chunk-relative overlay string index when
1176 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1177 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1178 the rightmost. (Bug#11720)
2f07e6af 1179
29b83cec
AS
11802012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1181
1182 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1183 (CATEGORY_MEMBER): Enforce 1/0 value.
1184 * category.c (_temp_category_set): Remove.
1185
4c5501e9
EZ
11862012-06-16 Eli Zaretskii <eliz@gnu.org>
1187
1188 * window.c (Fdelete_other_windows_internal)
1189 (Fdelete_window_internal): Don't access frame's mouse highlight
1190 info of the initial frame. (Bug#11677)
1191
2b570124
PE
11922012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1193
e93864f9
PE
1194 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1195 Assume USE_2_TAGS_FOR_INTS.
1196 (xreload): Adjust $tagmask width to match recent lisp.h change.
1197
2b570124
PE
1198 Simplify lisp.h in minor ways that should not affect code.
1199 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1200 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1201 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1202 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1203 (INTTYPEBITS): New macro, for clarity.
1204 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1205 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1206 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1207 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1208 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1209
81755f69
JB
12102012-06-13 Juanma Barranquero <lekktu@gmail.com>
1211
1212 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1213
16192a57
GM
12142012-06-13 Glenn Morris <rgm@gnu.org>
1215
1216 * s/bsd-common.h (BSD4_3):
1217 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1218
646b5f55
AS
12192012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1220
1221 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1222 instead of union.
1223 (XLI, XIL): Define.
1053a871
SM
1224 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1225 Use them.
1226 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1227 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1228 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1229 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1230 * frame.c (delete_frame): Remove outdated comment.
1231 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1232 USE_LISP_UNION_TYPE.
1233 (Fw32_unregister_hot_key): Likewise.
1234 (Fw32_toggle_lock_key): Likewise.
1235 * w32menu.c (add_menu_item): Likewise.
1236 (w32_menu_display_help): Use XIL instead of checking
1237 USE_LISP_UNION_TYPE.
1238 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1239 (init_heap): Likewise.
1240 * w32term.c (w32_read_socket): Update comment.
1241
1d3823c9
GM
12422012-06-13 Glenn Morris <rgm@gnu.org>
1243
c62ff706
GM
1244 * s/usg5-4-common.h, src/s/unixware.h:
1245 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1246
1d3823c9
GM
1247 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1248
bfe3e0a2
PE
12492012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1250
1251 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1252 * alloc.c (make_number) [!defined make_number]:
1253 Remove, as lisp.h always defines this now.
1254 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1255 (roundup_size): Verify that it is a power of 2.
1256 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1257 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1258 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1259 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1260 USE_LSB_TAG now is always defined to be either 0 or 1.
1261 All uses changed.
1262 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1263 code works fine either way, and efficiency is not a concern here,
1264 as the union type is for debugging, not for production.
1265 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1266 Use an inline function on all platforms when using the union type,
1267 since this is simpler and 'static inline' can be used portably
1268 within Emacs now.
1269 (LISP_INITIALLY_ZERO): New macro.
1270 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1271 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1272
45fa9c0f
GM
12732012-06-12 Glenn Morris <rgm@gnu.org>
1274
b4492cba
GM
1275 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1276
1277 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1278
45fa9c0f
GM
1279 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1280 Move BROKEN_SIGIO to configure.
1281
1282 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1283 Move NO_TERMIO to configure.
1284
0e25d334
CY
12852012-06-12 Chong Yidong <cyd@gnu.org>
1286
1287 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1288 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1289 MagickExportImagePixels is undefined.
1290
43682bb6
PE
12912012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1292
1293 * image.c (imagemagick_load_image): Remove unused label.
1294
a9be7d2b
GM
12952012-06-11 Glenn Morris <rgm@gnu.org>
1296
1297 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1298 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1299 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1300 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1301
3017f87f
SM
13022012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1303
1304 * alloc.c (make_byte_code): New function.
1305 (Fmake_byte_code): Use it. Don't purify here.
1306 * lread.c (read1): Use it as well to avoid extra allocation.
1307
1b9b4cf4
CY
13082012-06-11 Chong Yidong <cyd@gnu.org>
1309
1310 * image.c (imagemagick_load_image): Implement transparency.
1311
95988fcf
AS
13122012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1313
1314 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1315 account for preceding backslashes. (Bug#11663)
1316
cd4eb164
CY
13172012-06-09 Chong Yidong <cyd@gnu.org>
1318
1319 * term.c: Support italics in capable terminals (Bug#9652).
1320 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1321 (turn_on_face): Output using TS_enter_italic_mode if available.
1322 Don't handle unused blinking and alt-charset cases.
1323 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1324 and tty_alt_charset_p cases.
1325 (tty_capable_p, init_tty): Support italics.
1326
1327 * termchar.h (struct tty_display_info): Add field for italics.
1328 Remove unused blink field.
1329
1330 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1331 Handle slant.
1332
1333 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1334 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1335 tty_alt_charset_p. Add tty_italic_p.
1336
ff88beb8
MA
13372012-06-09 Michael Albinus <michael.albinus@gmx.de>
1338
1339 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1340 dbus_type_is_basic if available.
1341 (xd_extract_signed, xd_extract_unsigned): Rename from
1342 extract_signed and extract_unsigned, respectively. Adapt callers.
1343
44286096
CY
13442012-06-09 Chong Yidong <cyd@gnu.org>
1345
1682701f
CY
1346 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1347
44286096
CY
1348 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1349 case (Bug#9752).
1350
d86feb17
PE
13512012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1352
1353 * xdisp.c (vmessage): Treat frame message as multibyte.
1354 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1355 would generate the diagnostic "Making \302\247 buffer-local while
1356 let-bound!".
1357
d5c20fe8
EZ
13582012-06-08 Eli Zaretskii <eliz@gnu.org>
1359
1360 * dispnew.c (showing_window_margins_p): Undo last change, which
1361 was done due to an inadvertent commit.
1362 (adjust_frame_glyphs_for_frame_redisplay): Do call
1363 showing_window_margins_p.
1364
513749ee
SM
13652012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1366
1367 * eval.c (Fmake_var_non_special): New primitive.
1368 (syms_of_eval): Defsubr it.
1369 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1370
d4a8f5c1
JB
13712012-06-08 Juanma Barranquero <lekktu@gmail.com>
1372
1373 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1374 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1375
8bbbc977
EZ
13762012-06-08 Eli Zaretskii <eliz@gnu.org>
1377
1378 * alloc.c (allocate_vectorlike): Fix last change.
1379
f3372c87
DA
13802012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1381
1382 Block-based vector allocation of small vectors.
1383 * lisp.h (struct vectorlike_header): New field `nbytes',
1384 adjust comment accordingly.
1385 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1386 to denote vector blocks. Adjust users (live_vector_p,
1387 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1388 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1389 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1390 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1391 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1392 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1393 (roundup_size): New constant.
1394 (struct vector_block): New data type.
1395 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1396 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1397 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1398 (sweep_vectors): New functions.
1399 (allocate_vectorlike): Return `zero_vector' as the only vector of
1400 0 items. Allocate new vector from block if vector size is less than
1401 or equal to VBLOCK_BYTES_MAX.
1402 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1403 (init_alloc_once): Add call to init_vectors.
1404
4f18a4ed
SM
14052012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1406
1407 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1408
86f158bc
PE
14092012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 * doprnt.c (doprnt): Truncate multibyte char correctly.
1412 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1413 would mishandle a string argument "Xc" if X was a multibyte
1414 character of length 2: it would truncate after X's first byte
1415 rather than including all of X.
1416
c5cfcbe0
CY
14172012-06-06 Chong Yidong <cyd@gnu.org>
1418
1419 * buffer.c (word_wrap): Doc fix.
1420
c05cf390
PE
14212012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1422
1423 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1424
0c3461de
GM
14252012-06-03 Glenn Morris <rgm@gnu.org>
1426
1427 * xdisp.c (tool-bar-style): Doc fix.
1428
c71232db
UM
14292012-06-03 Ulrich Müller <ulm@gentoo.org>
1430
1431 * Makefile.in (PAXCTL): Define.
1432 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1433 binary via PaX flags if the paxctl utility is available.
1434 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1435 Restore PaX flags to their default. (Bug#11398)
1436
383f7350
CY
14372012-06-03 Chong Yidong <cyd@gnu.org>
1438
1439 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1440 buffer (Bug#11226).
1441
5f2c76c6
CY
14422012-06-03 Chong Yidong <cyd@gnu.org>
1443
1444 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1445 (note_mode_line_or_margin_highlight): If there is no help echo,
1446 use mode-line-default-help-echo. Handle the case where the mouse
1447 position is past the end of the mode line string.
1448
1449 * buffer.c (buffer_local_value_1): New function, split from
1450 Fbuffer_local_value; can return Qunbound.
1451 (Fbuffer_local_value): Use it.
1452 (Vmode_line_format): Docstring tweaks.
1453
773d47f6
PE
14542012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1455
1456 * sysdep.c (system_process_attributes): Improve comment.
1457
f2d6a3df
SM
14582012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1459
1460 * keyboard.c: Export real-this-command to Elisp.
1461 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1462 and DEFVAR it. Update all users.
1463
63810350
PE
14642012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1465
7bd5c1f4
PE
1466 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1467
63810350
PE
1468 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1469 Convert pctcpu and pctmem to Lisp float properly.
1470 Let the compiler fold better, as 100.0/0x8000 is exact.
1471
a2821611
AS
14722012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1473
1474 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1475 cons_block.
1476
5fceba1d
PE
14772012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1478
1479 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1480
c98ff5dd
DA
14812012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1482
1483 For a 'struct window', replace some Lisp_Object fields to
1484 bitfields where appropriate, remove unused fields.
1485 * window.h (struct window): Remove unused 'last_mark_x' and
1486 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1487 change it's type from Lisp_Object to bitfield.
1488 Change type of 'force_start', 'optional_new_start',
1489 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1490 fields from Lisp_Object to bitfield. Adjust users accordingly.
1491
ca34e0be
PE
14922012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 Pacify gcc -Wdouble-precision when using Xaw.
1495 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1496 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1497 Use 'float' consistently, rather than 'float' in most places
1498 and 'double' in a couple of places.
1499
efc00ab1 15002012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1501
1502 * xdisp.c (handle_stop): Detect whether we have overlay strings
1503 loaded by testing it->current.overlay_string_index to be
1504 non-negative, instead of checking whether n_overlay_strings is
1505 positive. (Bug#11587)
1506
efc00ab1 15072012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1508
1509 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1510
1511 * doc.c (Fsubstitute_command_keys): Doc fix.
1512
efc00ab1 15132012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1514
1515 * search.c (search_buffer): Remove calls to
1516 r_alloc_inhibit_buffer_relocation, as it is now called by
1517 maybe_unify_char, which was the cause of relocation of buffer text
1518 in bug#11519.
1519
efc00ab1 15202012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1521
1522 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1523 for the duration of call to load_charset, to avoid problems with
1524 callers of maybe_unify_char that access buffer text through C
1525 pointers.
1526
1527 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1528 decrement the inhibition flag, instead of just setting or
1529 resetting it.
1530
ba93a187
PE
15312012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 Remove obsolete '#define static' cruft.
1534 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1535 This #undef was "temporary" in 2000; it is no longer needed
1536 now that '#define static' has gone away.
1537 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1538 (gray_bitmap_bits): Remove; no longer needed.
1539 All uses replaced with definiens.
1540 * xterm.c: Include "bitmaps/gray.xbm".
1541
9e4bf381
PE
15422012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1543
1544 Clean up __executable_start, monstartup when --enable-profiling.
1545 The following changes affect the code only when profiling.
1546 * dispnew.c (__executable_start): Rename from safe_bcopy.
1547 Define only on platforms that need it.
1548 * emacs.c: Include <sys/gmon.h> when profiling.
1549 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1550 (__executable_start): Remove decl, since lisp.h does it now.
1551 (safe_bcopy): Remove decl; no longer has that name.
1552 (main): Coalesce #if into single bit of code, for simplicity.
1553 Cast pointers to uintptr_t, since standard libraries want integers
1554 and not pointers.
1555 * lisp.h (__executable_start): New decl.
1556
32d72c2f
GM
15572012-05-31 Glenn Morris <rgm@gnu.org>
1558
1559 * image.c (Fimagemagick_types): Doc fix.
1560
baac5bc7
JM
15612012-05-30 Jim Meyering <meyering@redhat.com>
1562
1563 * callproc.c (Fcall_process_region): Include directory component
1564 in mkstemp error message (Bug#11586).
1565
72cb32cf
PE
15662012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1567
1568 * alloc.c, lisp.h (make_pure_vector): Now static.
1569
61b108cc
SM
15702012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1571
1572 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1573 Move to byte-run.el.
1574 (Fautoload): Do the hash-doc more carefully.
1575 * data.c (Fdefalias): Purify definition, except for keymaps.
1576 (Qdefun): Move from eval.c.
1577 * lisp.h (Qdefun): Remove.
1578 * lread.c (read1): Tiny simplification.
1579
471fe23d
TN
15802012-05-29 Troels Nielsen <bn.troels@gmail.com>
1581
934f3f58 1582 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1583 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1584 Bug#9642, but explicitly check that the buffer the overlay would
1585 be moved to is live and rearrange lines to make sure that errors
1586 will not put the overlay in an inconsistent state.
1587 (Fdelete_overlay): Cosmetics.
1588
85d0efd1
EZ
15892012-05-28 Eli Zaretskii <eliz@gnu.org>
1590
1591 * w32term.c (my_bring_window_to_top): New function.
1592 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1593 could be different from the original one.
1594 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1595 (Bug#11513)
1596
1597 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1598 by calling BringWindowToTop.
1599
1600 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1601 (WM_EMACS_END): Increase by one.
1602
da92a98c
PE
16032012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1604
1605 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1606 This avoids undefined behavior that might cause the eassert
1607 to not catch an out-of-range value.
1608
74d1f848
JB
16092012-05-28 Juanma Barranquero <lekktu@gmail.com>
1610
1611 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1612 Update dependencies.
1613
9e1a06fc
EZ
16142012-05-27 Eli Zaretskii <eliz@gnu.org>
1615
1616 * bidi.c (bidi_mirror_char): Fix last change.
1617
f3dd7312
AS
16182012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1619
1620 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1621 when referring to sectname field in printf format.
1622
81899c91
PE
16232012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1624
57b81a9f
PE
1625 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1626 Only r_alloc_inhibit_buffer_relocation needed to be added;
1627 the others were already declared.
1628
81899c91
PE
1629 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1630 before checking whether it's out of range. Put the check inside
1631 eassert. See
1632 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1633
33017faf 16342012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1635
1636 * callproc.c (Fcall_process): Restore a line that was accidentally
1637 commented out in the 2011-02-13 change (bug#11547).
1638
33017faf 16392012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1640
1641 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1642 defined on ralloc.c.
1643
1644 * buffer.c [REL_ALLOC]: Remove prototypes of
1645 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1646 they are now on lisp.h.
1647
1648 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1649
1650 * search.c (search_buffer): Use it to inhibit relocation of buffer
1651 text while re_search_2 is doing its job, because re_search_2 is
1652 passed C pointers to buffer text. (Bug#11519)
1653
23415acf
EZ
1654 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1655 Update value to 24.
1656
44e27368
EZ
1657 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1658 state after an additional call to move_it_in_display_line_to, keep
1659 the values of it->max_ascent and it->max_descent found for the
1660 entire line.
1661 (pos_visible_p): Revert the comparison against bottom_y to what it
1662 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1663 (Bug#11464)
1664
c1892f11
PE
16652012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1666
1667 Fix coding-related core dumps with gcc -ftrapv.
1668 The code was computing A - B, where A and B are pointers, and B is
1669 random garbage. This can lead to core dumps on platforms that
1670 have special pointer registers, and it also leads to core dumps on
1671 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1672 A - B only when B is initialized properly.
1673 * coding.c (coding_set_source, coding_set_destination): Return void.
1674 (coding_change_source, coding_change_destinations): New functions,
1675 with the old behaviors of coding_set_source and coding_set_destination.
1676 All callers that need an offset changed to use these new functions.
1677
eb7afdad
GM
16782012-05-26 Glenn Morris <rgm@gnu.org>
1679
1680 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1681
f12fdf02
EZ
16822012-05-26 Eli Zaretskii <eliz@gnu.org>
1683
53a63be6 1684 Extend mouse support on W32 text-mode console.
61b108cc
SM
1685 * xdisp.c (draw_row_with_mouse_face):
1686 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1687
eb3f6f01 1688 * w32console.c: Include window.h.
61b108cc
SM
1689 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1690 New functions.
eb3f6f01
EZ
1691 (initialize_w32_display): Initialize mouse-highlight data.
1692
53a63be6
EZ
1693 * w32inevt.c: Include termchar.h and window.h.
1694 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1695 moves, call note_mouse_highlight. If help_echo changed, call
1696 gen_help_event to produce help-echo message in the echo area.
1697 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1698 highlight info.
1699
4cfd81f6
PE
17002012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1701
1702 * lread.c (read1): Simplify slightly to avoid an overflow warning
1703 with GCC 4.7.0 on x86-64.
1704
4446092a
EZ
17052012-05-26 Eli Zaretskii <eliz@gnu.org>
1706
1707 * bidi.c (bidi_mirror_char): Revert last change: an int is
1708 definitely wide enough here.
1709
42b2a986 17102012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1711
42b2a986 1712 Fix integer width and related bugs (Bug#9874).
eb106a49 1713 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1714 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1715 (string_bytes, check_sblock, allocate_string_data):
1716 (compact_small_strings, Fmake_bool_vector, make_string)
1717 (make_unibyte_string, make_multibyte_string)
1718 (make_string_from_bytes, make_specified_string)
1719 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1720 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1721 (mark_vectorlike):
1722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1723 (allocate_pseudovector):
1724 Use int, not EMACS_INT, where int is wide enough.
1725 (inhibit_garbage_collection, Fgarbage_collect):
1726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1727 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1728 int might not be wide enough.
1729 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1730 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1731 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1732 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1733 (bidi_level_of_next_char, bidi_move_to_visually_next):
1734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1735 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1736 (Fkill_buffer, Fset_buffer_major_mode)
1737 (advance_to_char_boundary, Fbuffer_swap_text)
1738 (Fset_buffer_multibyte, overlays_at, overlays_in)
1739 (overlay_touches_p, struct sortvec, record_overlay_string)
1740 (overlay_strings, recenter_overlay_lists)
1741 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1742 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1743 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1744 (Foverlay_recenter, last_overlay_modification_hooks_used)
1745 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1747 (validate_region): Omit unnecessary test for b <= e,
1748 since that's guaranteed by the previous test.
d311d28c
PE
1749 (adjust_overlays_for_delete): Avoid pos + length overflow.
1750 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1751 (report_overlay_modification):
1752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1753 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1754 Omit pointer cast, which isn't needed anyway, and doesn't work
1755 after the EMACS_INT -> ptrdiff_t change.
02481186 1756 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1757 * buffer.h: Adjust decls to match defn changes elsewhere.
1758 (struct buffer_text, struct buffer):
1759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1760 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1761 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1762 not int, to avoid needless 32-bit limit on 64-bit hosts.
1763 (exec_byte_code): Use tighter memory-full test, one that checks
1764 for alloca overflow. Don't compute the address of the object just
1765 before an array, as that's not portable. Use EMACS_INT, not
1766 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1767 * callint.c (Fcall_interactively):
1768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1769 * callproc.c (call_process_kill, Fcall_process):
1770 Don't assume pid_t fits into an Emacs fixnum.
1771 (call_process_cleanup, Fcall_process, child_setup):
1772 Don't assume pid_t fits into int.
1773 (call_process_cleanup, Fcall_process, delete_temp_file)
1774 (Fcall_process_region):
1775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1776 (Fcall_process): Simplify handling of volatile integers.
1777 Use int, not EMACS_INT, where int will do.
1778 * casefiddle.c (casify_object, casify_region, operate_on_word)
1779 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1781 (casify_object): Avoid integer overflow when overallocating buffer.
1782 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1783 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1784 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1785 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1786 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1787 integers are now checked earlier. All uses replaced with XINT.
1788 (ccl_driver):
1789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1790 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1791 (ccl_driver, Fregister_code_conversion_map):
1792 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1793 (resolve_symbol_ccl_program): Check that vector header is in range.
1794 Always copy the vector, so that we can check its contents reliably
1795 now rather than having to recheck each instruction as it's being
1796 executed. Check that vector words fit in 'int'.
1797 (ccl_get_compiled_code, Fregister_ccl_program)
1798 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1799 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1800 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1801 contents are in range.
1802 (Fccl_execute_on_string): Check that status is in range.
1803 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1804 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1805 Accept and return EMACS_INT, not int, because callers can pass values
1806 out of 'int' range.
1807 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1808 (multibyte_chars_in_text, parse_str_as_multibyte)
1809 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1810 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1811 (string_escape_byte8, Fget_byte):
1812 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1813 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1814 avoid mishandling large integers.
1815 * character.h: Adjust decls to match defn changes elsewhere.
1816 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1817 (Ffind_charset_region):
1818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1819 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1820 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1821 Don't assume fixnum fits in int.
d311d28c
PE
1822 (load_charset_map_from_vector, Fmap_charset_chars):
1823 Remove now-unnecessary CHECK_NATNUMs.
1824 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1825 Don't rely on undefined behavior with signed left shift overflow.
1826 Don't assume unsigned int fits into fixnum, or that fixnum fits
1827 into unsigned int. Don't require max_code to be a valid fixnum;
1828 that's not true for gb10830 4-byte on a 32-bit host. Allow
1829 invalid_code to be a cons, for the same reason. Require code_offset
1830 to be a character. Avoid int overflow if max_char is close
1831 to INT_MAX.
1832 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1833 this is intended anyway and avoids some undefined behavior.
1834 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1835 INDEX_TO_CODE_POINT, as that's what it expects.
1836 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1837 * charset.h (DECODE_CHAR): Return int, not unsigned;
1838 this is what was intended anyway, and it avoids undefined behavior.
1839 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1840 integer-overflow issues.
1841 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1842 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1843 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1844 * chartab.c (Fmake_char_table, Fset_char_table_range)
1845 (uniprop_get_decoder, uniprop_get_encoder):
1846 Don't assume fixnum fits in int.
1847 * cmds.c (move_point): New function, that does the gist of
1848 Fforward_char and Fbackward_char, but does so while checking
1849 for integer overflow more accurately.
c96e5d6a 1850 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1851 (Fforward_line, Fend_of_line, internal_self_insert)
1852 (internal_self_insert):
1853 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1854 Fix a FIXME, by checking for integer overflow when calculating
1855 target_clm and actual_clm.
1856 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1857 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1858 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1859 (coding_alloc_by_making_gap, alloc_destination)
1860 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1861 (encode_coding_utf_16, detect_coding_emacs_mule)
1862 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1863 (detect_coding_iso_2022, decode_coding_iso_2022)
1864 (encode_invocation_designation, encode_designation_at_bol)
1865 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1866 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1867 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1868 (encode_coding_ccl, encode_coding_raw_text)
1869 (detect_coding_charset, decode_coding_charset)
1870 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1871 (produce_composition, produce_charset, produce_annotation)
1872 (decode_coding, handle_composition_annotation)
1873 (handle_charset_annotation, consume_chars, decode_coding_gap)
1874 (decode_coding_object, encode_coding_object, detect_coding_system)
1875 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1876 (code_convert_region, code_convert_string)
8f50130c
PE
1877 (Fdefine_coding_system_internal)
1878 (coding_set_source, coding_set_destination):
d311d28c
PE
1879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1880 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1881 (Fdefine_coding_system_internal):
1882 Don't assume fixnums fit in int.
1883 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1884 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1885 (Funencodable_char_position, Fcheck_coding_systems_region)
1886 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1888 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1889 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1890 Don't access memory outside of the args array.
d311d28c 1891 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1892 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1893 result of ENCODE_CHAR.
d311d28c
PE
1894 * coding.h: Adjust decls to match defn changes elsewhere.
1895 (struct coding_system):
1896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1897 * composite.c (get_composition_id, find_composition)
1898 (run_composition_function, update_compositions)
1899 (compose_text, composition_gstring_put_cache)
1900 (composition_gstring_p, composition_gstring_width)
1901 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1902 (composition_compute_stop_pos, composition_reseat_it)
1903 (composition_update_it, struct position_record)
1904 (find_automatic_composition, composition_adjust_point)
1905 (Fcomposition_get_gstring, Ffind_composition_internal):
1906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1907 (update_compositions):
1908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1909 * composite.h: Adjust decls to match defn changes elsewhere.
1910 (struct composition):
1911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1912 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1913 Do not attempt to compute the address of the object just before a
1914 buffer; this is not portable.
1915 (Faref, Faset):
1916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1917 (Faset): Use int, not EMACS_INT, where int is wide enough.
1918 (Fstring_to_number): Don't assume fixnums fit in int.
1919 (Frem): Don't assume arg is nonnegative.
1920 * dbusbind.c (xd_append_arg): Check for integers out of range.
1921 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1922 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1923 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1924 (xd_get_connection_references): Return ptrdiff_t, not int.
1925 All uses changed.
1926 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1927 (xd_read_message_1):
1928 Use int, not unsigned, where the dbus API uses int.
1929 (Fdbus_message_internal): Don't overflow mtype.
1930 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1931 * dired.c (directory_files_internal, file_name_completion, scmp)
1932 (file_name_completion_stat):
1933 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1934 (file_name_completion): Don't overflow matchcount.
1935 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1936 * dispextern.h: Adjust decls to match defn changes elsewhere.
1937 (struct text_pos, struct glyph, struct bidi_saved_info)
1938 (struct bidi_string_data, struct bidi_it, struct composition_it)
1939 (struct it):
1940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1941 (struct display_pos, struct composition_it, struct it):
1942 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1943 * dispnew.c (increment_matrix_positions)
1944 (increment_row_positions, mode_line_string)
1945 (marginal_area_string):
1946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1947 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1948 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1949 (duration_to_sec_usec): New function, to check for overflow better.
1950 (Fsleep_for, sit_for): Use it.
1951 * doc.c (get_doc_string, store_function_docstring):
1952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1953 (get_doc_string, Fsnarf_documentation):
1954 Use int, not EMACS_INT, where int is wide enough.
1955 (get_doc_string):
1956 Use SAFE_ALLOCA, not alloca.
1957 Check for overflow when converting EMACS_INT to off_t.
1958 * doprnt.c (doprnt):
1959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1960 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1961 Don't assume uid_t fits into fixnum.
1962 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1963 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1964 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1965 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1966 (general_insert_function)
1967 (Finsert_char, make_buffer_string, make_buffer_string_both)
1968 (update_buffer_properties, Fbuffer_substring)
1969 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1970 (Fsubst_char_in_region, check_translation)
1971 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1972 (transpose_markers, Ftranspose_regions):
1973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1974 (clip_to_bounds): Move to lisp.h as an inline function).
1975 (Fconstrain_to_field): Don't assume integers are nonnegative.
1976 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1977 (Fsubst_char_in_region, Fsave_restriction):
1978 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1979 (Femacs_pid): Don't assume pid_t fits into fixnum.
1980 (lo_time): Use int, not EMACS_INT, when int suffices.
1981 (lisp_time_argument): Check for usec out of range.
1982 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1983 (Fuser_login_name, Fuser_full_name): Signal an error
1984 if a uid argument is out of range, rather than relying on
1985 undefined behavior.
c8d5c857
PE
1986 (Fformat_time_string): Remove now-unnecessary check.
1987 lisp_time_argument checks for out-of-range usec now.
243e0530 1988 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1989 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1990 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1991 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1992 (init_cmdargs, Fdump_emacs):
1993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1994 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1995 the bottom (typically) 32 bits of the fixnum.
1996 * eval.c (specpdl_size, call_debugger):
1997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1998 (when_entered_debugger, Fbacktrace_debug):
1999 Don't assume fixnum can fit in int.
2000 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2001 the object just before a buffer; this is not portable.
2002 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2003 (grow_specpdl, unbind_to):
2004 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2005 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2006 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2007 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2008 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2009 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2011 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2012 (a_write, e_write):
2013 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2014 (Fcopy_file, non_regular_nbytes, read_non_regular)
2015 (Finsert_file_contents):
2016 Use int, not EMACS_INT, where int is wide enough.
2017 (READ_BUF_SIZE): Verify that it fits in int.
2018 (Finsert_file_contents): Check that counts are in proper range,
2019 rather than assuming fixnums fit into ptrdiff_t etc.
2020 Don't assume fixnums fit into int.
125b3835 2021 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2022 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2023 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2024 (string_char_to_byte, string_byte_to_char)
2025 (string_make_multibyte, string_to_multibyte)
2026 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2027 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2028 (substring_both, Fdelete, internal_equal, Ffillarray)
2029 (Fclear_string, mapcar1)
2030 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2031 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2032 (larger_vector, make_hash_table, maybe_resize_hash_table)
2033 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2034 (Fmaphash, secure_hash):
2035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2036 (concat): Check for string index and length overflow.
2037 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2038 (Frequire):
2039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2040 (larger_vector): New API (vec, incr_min, size_max) replaces old
2041 one (vec, new_size, init). This catches size overflow.
2042 INIT was removed because it was always Qnil.
2043 All callers changed.
2044 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2045 the upper bound on a hash table index size.
2046 (make_hash_table, maybe_resize_hash_table): Use it.
2047 (secure_hash): Computer start_byte and end_byte only after
2048 they're known to be in ptrdiff_t range.
2049 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2050 (Ffont_get_glyphs, Ffont_at):
2051 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2052 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2053 (Flist_fonts, Fopen_font):
2054 Don't assume fixnum can fit in int.
2055 (check_gstring): Don't assume index can fit in int.
2056 (font_match_p): Check that fixnum is a character, not a nonnegative
2057 fixnum, since the later code needs to stuff it into an int.
2058 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2059 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2060 conversion overflow issues.
2061 (Fopen_font): Check for integer out of range.
2062 (Ffont_get_glyphs): Don't assume index can fit in int.
2063 * font.h: Adjust decls to match defn changes elsewhere.
2064 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2065 integer overflow.
2066 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2067 printmax_t, where ptrdiff_t is wide enough.
2068 (Finternal_char_font):
2069 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2070 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2071 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2072 (Fset_frame_position, x_set_frame_parameters)
2073 (x_set_line_spacing, x_set_border_width)
2074 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2075 Check that fixnums are in proper range for system types.
2076 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2078 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2079 Use SAFE_ALLOCA_LISP, not alloca.
2080 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2081 intptr_t is wide enough.
2082 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2083 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2084 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2085 Check for fixnum out of range.
2086 * ftfont.c (ftfont_list): Don't assume index fits in int.
2087 Check that fixnums are in proper range for system types.
2088 (ftfont_shape_by_flt):
2089 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2090 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2092 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2093 Check that fixnums are in proper range for system types.
2094 * gnutls.h: Adjust decls to match defn changes elsewhere.
2095 * gtkutil.c (xg_dialog_run):
2096 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2097 (update_frame_tool_bar):
2098 Check that fixnums are in proper range for system types.
2099 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2100 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2101 * indent.c (last_known_column, last_known_column_point):
2102 (current_column_bol_cache):
2103 (skip_invisible, current_column, check_display_width):
2104 (check_display_width, scan_for_column, current_column_1)
2105 (Findent_to, Fcurrent_indentation, position_indentation)
2106 (indented_beyond_p, Fmove_to_column, compute_motion):
2107 (Fcompute_motion, Fvertical_motion):
2108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2109 (last_known_column_modified): Use EMACS_INT, not int.
2110 (check_display_width):
2111 (Fcompute_motion):
2112 Check that fixnums and floats are in proper range for system types.
2113 (compute_motion): Don't assume index or fixnum fits in int.
2114 (compute_motion, Fcompute_motion):
2115 Use int, not EMACS_INT, when it is wide enough.
2116 (vmotion): Omit local var start_hpos that is always 0; that way
2117 we don't need to worry about overflow in expressions involving it.
2118 * indent.h: Adjust decls to match defn changes elsewhere.
2119 (struct position):
2120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2121 Use int, not EMACS_INT, where int is wide enough.
2122 Remove unused members ovstring_chars_done and tab_offset;
2123 all uses removed.
2124 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2125 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2126 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2127 (make_gap, copy_text, insert, insert_and_inherit)
2128 (insert_before_markers, insert_before_markers_and_inherit)
2129 (insert_1, count_combining_before, count_combining_after)
2130 (insert_1_both, insert_from_string)
2131 (insert_from_string_before_markers, insert_from_string_1)
2132 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2133 (adjust_after_replace, adjust_after_insert, replace_range)
2134 (replace_range_2, del_range, del_range_1, del_range_byte)
2135 (del_range_both, del_range_2, modify_region)
2136 (prepare_to_modify_buffer, signal_before_change)
2137 (signal_after_change, Fcombine_after_change_execute):
2138 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2139 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2140 (balance_an_interval, split_interval_right, split_interval_left)
2141 (find_interval, next_interval, update_interval)
2142 (adjust_intervals_for_insertion, delete_node, delete_interval)
2143 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2144 (static_offset_intervals, offset_intervals)
2145 (merge_interval_right, merge_interval_left, make_new_interval)
2146 (graft_intervals_into_buffer, temp_set_point_both)
2147 (temp_set_point, set_point, adjust_for_invis_intang)
2148 (set_point_both, move_if_not_intangible, get_property_and_range)
2149 (get_local_map, copy_intervals, copy_intervals_to_string)
2150 (compare_string_intervals, set_intervals_multibyte_1):
2151 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2152 * intervals.h: Adjust decls to match defn changes elsewhere.
2153 (struct interval):
2154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2155 * keyboard.c (this_command_key_count, this_single_command_key_start)
2156 (before_command_key_count, before_command_echo_length, echo_now)
2157 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2158 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2159 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2160 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2162 (last_non_minibuf_size, last_point_position, echo_truncate)
2163 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2164 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2165 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2166 (stuff_buffered_input):
2167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2168 (last_auto_save, command_loop_1, read_char):
2169 Use EMACS_INT, not int, to avoid integer overflow.
2170 (record_char): Avoid overflow in total_keys computation.
2171 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2172 * keyboard.h: Adjust decls to match defn changes elsewhere.
2173 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2174 (Fkey_description, Fdescribe_vector, Flookup_key):
2175 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2176 (click_position): New function, to check that positions are in range.
2177 (Fcurrent_active_maps):
2178 (describe_command):
2179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2180 (Faccessible_keymaps, Fkey_description):
2181 (preferred_sequence_p):
2182 Don't assume fixnum can fit into int.
2183 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2184 Check for integer overflow in size calculations.
2185 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2186 avoid mishandling large integers.
2187 * lisp.h: Adjust decls to match defn changes elsewhere.
2188 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2189 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2190 (struct Lisp_Marker):
2191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2192 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2193 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2194 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2195 All callers changed.
2196 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2197 Assume the arg has valid form, since it always does.
2198 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2199 unsigned integer system type.
2200 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2201 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2203 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2204 (duration_to_sec_usec): New decl.
2205 * lread.c (read_from_string_index, read_from_string_index_byte)
2206 (read_from_string_limit, readchar, unreadchar, openp)
2207 (read_internal_start, read1, oblookup):
2208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2209 (Fload, readevalloop, Feval_buffer, Feval_region):
2210 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2211 (openp): Check for out-of-range argument to 'access'.
2212 (read1): Use int, not EMACS_INT, where int is wide enough.
2213 Don't assume fixnum fits into int.
6efdadfd 2214 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2215 (read_filtered_event): Use duration_to_sec_usec
2216 to do proper overflow checking on durations.
d311d28c
PE
2217 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2218 in size calculation.
2219 (Fexecute_kbd_macro):
2220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2221 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2222 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2223 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2224 (set_marker_both, set_marker_restricted_both, marker_position)
2225 (marker_byte_position, Fbuffer_has_markers_at):
2226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2227 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2228 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2229 It now merely ensures that the menu is large enough, without
2230 necessarily growing it, as this avoids some integer overflow issues.
2231 All callers changed.
2232 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2234 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2235 Use SAFE_ALLOCA_LISP, not alloca.
2236 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2237 to EMACS_INT. Check that fixnums are in proper range for system types.
2238 * minibuf.c (minibuf_prompt_width, string_to_object)
2239 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2240 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2241 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2242 (get_minibuffer, read_minibuf_unwind):
2243 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2244 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2245 this simplifies overflow checking. All callers changed.
2246 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2247 (Ftest_completion):
2248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2249 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2250 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2251 Check that fixnums are in proper range for system types.
2252 (Fx_create_frame, Fx_show_tip):
2253 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2254 * nsfont.m (ns_findfonts, nsfont_list_family):
2255 Don't assume fixnum fits in long.
2256 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2257 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2258 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2259 wide enough.
17fdb222 2260 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2262 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2263 (PRINTDECLARE, PRINTPREPARE):
2264 (strout, print_string):
2265 (print, print_preprocess, print_check_string_charset_prop)
2266 (print_object):
2267 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2268 (PRINTDECLARE):
2269 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2270 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2271 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2272 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2273 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2274 (print_error_message): Use SAFE_ALLOCA, not alloca.
2275 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2276 (print_depth, new_backquote_output, print_number_index):
2277 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2278 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2279 (Fset_process_window_size, Fformat_network_address)
2280 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2281 (sigchld_handler):
d311d28c 2282 Check that fixnums are in proper range for system types.
d44287d4 2283 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2284 Check for process-ids out of pid_t range rather than relying on
2285 undefined behavior.
e4d81efc 2286 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2287 (Fformat_network_address, read_process_output, send_process)
2288 (Fprocess_send_region, status_notify):
2289 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2290 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2291 (wait_reading_process_output, read_process_output, exec_sentinel):
2292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2293 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2294 (Faccept_process_output): Use duration_to_sec_usec to do proper
2295 overflow checking on durations.
dde14581
PE
2296 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2297 Don't assume pid_t fits in int.
02481186
PE
2298 * process.h (struct Lisp_Process): Members tick and update_tick
2299 are now of type EMACS_INT, not int.
b62b53e8
PE
2300 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2301 configured --with-wide-int.
d311d28c
PE
2302 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2303 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2304 * search.c (looking_at_1, string_match_1):
2305 (fast_string_match, fast_c_string_match_ignore_case)
2306 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2307 (scan_newline, find_before_next_newline, search_command)
2308 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2309 (set_search_regs, wordify):
2310 (Freplace_match):
2311 (Fmatch_data):
2312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2313 (string_match_1, search_buffer, set_search_regs):
2314 (Fmatch_data):
2315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2316 (wordify): Check for overflow in size calculation.
2317 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2318 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2319 Check that fixnums are in proper range for system types.
2320 * sound.c (struct sound_device)
2321 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2323 (Fplay_sound_internal):
2324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2325 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2326 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2327 (Fparse_partial_sexp):
2328 Don't assume fixnums can fit in int.
2329 (struct lisp_parse_state, find_start_pos, find_start_value)
2330 (find_start_value_byte, find_start_begv)
2331 (update_syntax_table, char_quoted, dec_bytepos)
2332 (find_defun_start, prev_char_comend_first, back_comment):
2333 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2334 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2336 (Finternal_describe_syntax_value): Check that match_lisp is a
2337 character, not an integer, since the code stuffs it into int.
2338 (scan_words, scan_sexps_forward):
2339 Check that fixnums are in proper range for system types.
2340 (Fforward_word):
2341 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2342 (scan_sexps_forward):
2343 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2344 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2345 * syntax.h: Adjust decls to match defn changes elsewhere.
2346 (struct gl_state_s):
2347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2348 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2349 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2350 * sysdep.c (wait_for_termination_1, wait_for_termination)
2351 (interruptible_wait_for_termination, mkdir):
2352 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2353 (emacs_read, emacs_write):
2354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2355 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2356 and double all fit in int.
d311d28c
PE
2357 * term.c (set_tty_color_mode):
2358 Check that fixnums are in proper range for system types.
2359 * termhooks.h (struct input_event):
2360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2361 * textprop.c (validate_interval_range, interval_of)
2362 (Fadd_text_properties, set_text_properties_1)
2363 (Fremove_text_properties, Fremove_list_of_text_properties)
2364 (Ftext_property_any, Ftext_property_not_all)
2365 (copy_text_properties, text_property_list, extend_property_ranges)
2366 (verify_interval_modification):
2367 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2368 (Fnext_single_char_property_change)
2369 (Fprevious_single_char_property_change):
2370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2371 (copy_text_properties):
2372 Check for integer overflow in index calculation.
d311d28c
PE
2373 * undo.c (last_boundary_position, record_point, record_insert)
2374 (record_delete, record_marker_adjustment, record_change)
2375 (record_property_change):
2376 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2377 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2378 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2379 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2380 (Fx_hide_tip, Fx_file_dialog):
2381 * w32menu.c (set_frame_menubar):
2382 Use ptrdiff_t, not int, for consistency with rest of code.
2383 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2384 (select_window, Fdelete_other_windows_internal)
2385 (window_scroll_pixel_based, window_scroll_line_based)
2386 (Frecenter, Fset_window_configuration):
2387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2388 (Fset_window_hscroll, run_window_configuration_change_hook)
2389 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2390 (Fscroll_other_window, Frecenter):
d311d28c
PE
2391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2392 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2393 Don't assume fixnum fits in int.
2394 (Fset_window_scroll_bars):
2395 Check that fixnums are in proper range for system types.
2396 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2397 (string_pos, c_string_pos, number_of_chars, init_iterator)
2398 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2399 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2400 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2401 (face_before_or_after_it_pos, handle_invisible_prop)
2402 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2403 (display_prop_intangible_p, string_buffer_position_lim)
2404 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2405 (get_overlay_strings_1, get_overlay_strings)
2406 (iterate_out_of_display_property, forward_to_next_line_start)
2407 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2408 (get_next_display_element, set_iterator_to_next)
2409 (get_visually_first_element, compute_stop_pos_backwards)
2410 (handle_stop_backwards, next_element_from_buffer)
2411 (move_it_in_display_line_to, move_it_in_display_line)
2412 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2413 (add_to_log, message_dolog, message_log_check_duplicate)
2414 (message2, message2_nolog, message3, message3_nolog
2415 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2416 (current_message_1, truncate_echo_area, truncate_message_1)
2417 (set_message, set_message_1, store_mode_line_noprop)
2418 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2419 (text_outside_line_unchanged_p, check_point_in_composition)
2420 (reconsider_clip_changes)
2421 (redisplay_internal, set_cursor_from_row, try_scrolling)
2422 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2423 (redisplay_window, find_last_unchanged_at_beg_row)
2424 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2425 (trailing_whitespace_p, find_row_edges, display_line)
2426 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2427 (display_mode_element, store_mode_line_string)
2428 (pint2str, pint2hrstr, decode_mode_spec)
2429 (display_count_lines, display_string, draw_glyphs)
2430 (x_produce_glyphs, x_insert_glyphs)
2431 (rows_from_pos_range, mouse_face_from_buffer_pos)
2432 (fast_find_string_pos, mouse_face_from_string_pos)
2433 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2435 (safe_call, init_from_display_pos, handle_fontified_prop)
2436 (handle_single_display_spec, load_overlay_strings)
2437 (with_echo_area_buffer, setup_echo_area_for_printing)
2438 (display_echo_area, echo_area_display)
2439 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2440 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2441 (redisplay_window, dump_glyph_row, display_mode_line)
2442 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2443 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2444 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2445 (handle_single_display_spec, build_desired_tool_bar_string)
2446 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2447 (get_specified_cursor_type):
2448 Check that fixnums are in proper range for system types.
2449 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2450 (Flookup_image_map):
2451 Don't assume fixnums fit in int.
2452 (compare_overlay_entries):
2453 Avoid mishandling comparisons due to subtraction overflow.
2454 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2455 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2456 (handle_tool_bar_click):
2457 Use int, not unsigned, since we prefer signed and the signedness
2458 doesn't matter here.
2459 (get_next_display_element, next_element_from_display_vector):
2460 Use int, not EMACS_INT, when int is wide enough.
2461 (start_hourglass): Use duration_to_sec_usec to do proper
2462 overflow checking on durations.
2463 * xfaces.c (Fbitmap_spec_p):
2464 Check that fixnums are in proper range for system types.
2465 (compare_fonts_by_sort_order):
2466 Avoid mishandling comparisons due to subtraction overflow.
2467 (Fx_family_fonts, realize_basic_faces):
2468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2469 (Fx_family_fonts):
2470 Don't assume fixnum fits in int.
2471 Use SAFE_ALLOCA_LISP, not alloca.
2472 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2473 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2474 (face_at_buffer_position, face_for_overlay_string)
2475 (face_at_string_position):
2476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2477 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2478 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2479 (Fx_show_tip):
2480 Check that fixnums are in proper range for system types.
2481 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2482 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2484 (Fx_change_window_property): Don't assume fixnums fit in int.
2485 * xfont.c (xfont_chars_supported):
2486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2487 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2488 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2490 * xml.c (parse_region):
2491 * xrdb.c (magic_file_p):
2492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2493 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2494 (x_get_local_selection, x_reply_selection_request)
2495 (x_handle_selection_request, wait_for_property_change):
2496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2497 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2498 short is wide enough.
2499 (x_send_client_event): Don't assume fixnum fits in int.
2500 * xterm.c (x_x_to_emacs_modifiers):
2501 Don't assume EMACS_INT overflows nicely into int.
2502 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2503 may come from Lisp.
2504 (handle_one_xevent): NATNUMP can eval its arg twice.
2505 (x_connection_closed):
2506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2507 * xterm.h: Adjust decls to match defn changes elsewhere.
2508 (struct scroll_bar): Use struct vectorlike_header
2509 rather than rolling our own approximation.
2510 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2511
c6574eb5
GM
25122012-05-25 Glenn Morris <rgm@gnu.org>
2513
2514 * lisp.mk (lisp): Update for more files being compiled now.
2515
e8d32c7e
SM
25162012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2517
48def666
SM
2518 * lread.c: Remove `read_pure' which makes no difference.
2519 (read_pure): Remove var.
2520 (unreadpure): Remove function.
2521 (readevalloop): Don't call read_list with -1 flag.
2522 (read1, read_vector): Don't test read_pure any more.
2523 (read_list): Simplify.
2524
e8d32c7e
SM
2525 * fileio.c, character.h: Minor style tweaks.
2526
4b2addb7
DA
25272012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2528
2529 * window.h (clip_changed): Remove useless declaration.
2530
584461b2
JB
25312012-05-22 Juanma Barranquero <lekktu@gmail.com>
2532
2533 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2534 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2535
34374650
PE
25362012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2537
2538 Remove src/m/*.
2539 This directory predates autoconf and is no longer needed nowadays.
2540 Move its few remaining bits of functionality to where they're needed.
2541 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2542 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2543 * m/template.h: Remove.
2544 * Makefile.in (M_FILE): Remove. All uses removed.
2545 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2546 * lisp.h (USE_LSB_TAG):
2547 * mem-limits.h (EXCEEDS_LISP_PTR):
2548 Use VAL_MAX, not VALBITS, in #if.
2549 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2550 (EMACS_UINT): Define unconditionally now.
2551 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2552 (BITS_PER_EMACS_INT): New constants, replacing
2553 what used to be in config.h, but not useful in #if.
2554 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2555 define them any more.
2556 (VAL_MAX): New macro.
2557 (VALMASK): Use it.
2558 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2559 BITS_PER_EMACS_INT, in #if.
2560 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2561 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2562 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2563 * s/ms-w32.h (DATA_START):
2564 Move here from removed file m/intel386.h.
2565 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2566 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2567
261cb4bb
PE
25682012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2569
2570 Assume C89 or later.
2571 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2572 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2573 (xrealloc):
2574 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2575 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2576 * textprop.c, tparam.c (NULL): Remove.
2577 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2578 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2579 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2580 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2581 * xterm.c (input_signal_count): Assume volatile works.
2582
ff23cd9f
KB
25832012-05-21 Ken Brown <kbrown@cornell.edu>
2584
2585 * xgselect.c (xg_select): Fix first argument in call to 'select'
2586 (bug#11508).
2587
1b170bc6
KB
25882012-05-20 Ken Brown <kbrown@cornell.edu>
2589
2590 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2591 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2592
b2f4d39f
KB
25932012-05-19 Ken Brown <kbrown@cornell.edu>
2594
2595 * xfns.c (x_in_use): Remove `static' qualifier.
2596 * xterm.h (x_in_use): Declare.
2597 * xgselect.c: Include xterm.h.
2598 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2599 and `display_arg' (bug#9754).
2600
003fdae2
PE
26012012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2602
9232a6d9
PE
2603 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2604
003fdae2
PE
2605 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2606 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2607
784b56e2
EZ
26082012-05-18 Eli Zaretskii <eliz@gnu.org>
2609
2610 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2611
2612 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2613 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2614
2615 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2616 reference to image_cache->refcount.
2617 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2618
a0a79cde
JL
26192012-05-17 Juri Linkov <juri@jurta.org>
2620
2621 * search.c (Fword_search_regexp, Fword_search_backward)
2622 (Fword_search_forward, Fword_search_backward_lax)
2623 (Fword_search_forward_lax): Move functions to isearch.el
2624 (bug#10145, bug#11381).
2625
b0572523
PE
26262012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2627
2628 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2629
9660f5fc
SM
26302012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2631
2632 * lread.c (init_obarray): Declare Qt and Qnil as special.
2633
4374de83
GM
26342012-05-14 Glenn Morris <rgm@gnu.org>
2635
2636 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2637 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2638
dc44c39a
PE
26392012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2640
078c97cb
PE
2641 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2642
dc44c39a
PE
2643 * unexaix.c: Port to more-recent AIX compilers.
2644 (report_error, report_error_1, make_hdr, copy_sym)
2645 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2646 Make arguments const char *, not char *, to avoid violations of C
2647 standard and to fix some AIX warnings reported by Gilles Pion.
2648
e18afed7 26492012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2650
2651 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2652 already have overlays loaded.
2653 (handle_single_display_spec): Before returning without displaying
2654 fringe bitmap, synchronize the bidi iterator with the main display
2655 iterator, by calling iterate_out_of_display_property.
2656 (iterate_out_of_display_property): Detect buffer iteration by
2657 testing that it->string is a Lisp string.
2658 (get_next_display_element): When the current object is exhausted,
2659 and there's something on it->stack, call set_iterator_to_next to
2660 proceed with what's on the stack, instead of returning zero.
2661 (set_iterator_to_next): If called at the end of a Lisp string,
2662 proceed to consider_string_end without incrementing string
2663 position. Don't increment display vector index past the end of
2664 the display vector. (Bug#11417)
c8fb9dc6
EZ
2665 (pos_visible_p): Don't report a position visible when move_it_to
2666 stopped at the last line of window, which happens to be scanned
2667 backwards by the bidi iteration. (Bug#11464)
ac268e67 2668
e18afed7 26692012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2670
2671 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2672 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2673 are on a TTY, and thus unable to display on the fringes.
2674 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2675 so we need to signal to the caller that this is a "replacing"
2676 display spec. This fixes display when the spec is invalid or we
2677 are on a TTY.
2678
e18afed7 26792012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2680
2681 * unexaix.c (make_hdr): Fix typo in prototype.
2682 This bug broke the build on AIX. Problem reported by Gilles Pion.
2683
9d0a235a
MA
26842012-05-14 Michael Albinus <michael.albinus@gmx.de>
2685
2686 * keyboard.c (kbd_buffer_get_event): Read special events also in
2687 batch mode. (Bug#11415)
2688
9e6b06ed
GM
26892012-05-12 Glenn Morris <rgm@gnu.org>
2690
2691 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2692
c1a1d7a3
EZ
26932012-05-12 Eli Zaretskii <eliz@gnu.org>
2694
2695 * lisp.mk (lisp): Add newcomment.elc.
2696
3fe7cdc8
GM
26972012-05-12 Glenn Morris <rgm@gnu.org>
2698
2699 * Makefile.in (MKDIR_P): New, set by configure.
2700 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2701
53f7d2c0
PE
27022012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2703
2704 Remove unused function hourglass_started.
2705 * dispextern.h (hourglass_started):
2706 * w32fns.c (hourglass_started):
2707 * xdisp.c (hourglass_started): Remove.
2708
75aafb17
JB
27092012-05-10 Juanma Barranquero <lekktu@gmail.com>
2710
2711 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2712 Update dependencies.
2713
12959e8e
PE
27142012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2715
97107e2e
PE
2716 * xgselect.c (xg_select): Put maxfds+1 into a var.
2717 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2718
12959e8e
PE
2719 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2720
836d29b3
DA
27212012-05-10 Dave Abrahams <dave@boostpro.com>
2722
2723 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2724 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2725
5cb67954
MA
27262012-05-09 Michael Albinus <michael.albinus@gmx.de>
2727
2728 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2729 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2730 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2731 Initialize xd_registered_buses.
2732
3478ec45
PE
27332012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2734
b263a6b0
PE
2735 Untag more efficiently if USE_LSB_TAG.
2736 This is based on a proposal by YAMAMOTO Mitsuharu in
2737 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2738 For an admittedly artificial (nth 8000 longlist) benchmark on
2739 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2740 Emacs's overall text size by 1%.
2741 * lisp.h (XUNTAG): New macro.
2742 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2743 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2744 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2745 * eval.c (Fautoload):
2746 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2747 * frame.h (XFRAME): Use XUNTAG.
2748
3478ec45
PE
2749 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2750 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2751 Remove unportable assumptions about print widths of types like
2752 dbus_uint32_t.
2753 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2754 intptr_t when converting between pointer and integer, to avoid GCC
2755 warnings about wrong width.
2756
666b903b 27572012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2758
2759 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2760 stack for each reader_thread, instead of defaulting to 8MB
2761 determined by the linker. This avoids failures in creating
2762 subprocesses on Windows 7, see the discussion in this thread:
2763 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2764
b120cc17
JC
27652012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2766
2767 Fix up display of the *Minibuf-0* buffer in the mini window.
2768 * keyboard.c (read_char): Don't clear the echo area if there's no
2769 message to clear.
2770 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2771 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2772
9a4b36f8
MA
27732012-05-07 Michael Albinus <michael.albinus@gmx.de>
2774
2775 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2776 batch mode.
2777
e5f9458f
CY
27782012-05-06 Chong Yidong <cyd@gnu.org>
2779
2780 * lisp.mk (lisp): Update.
2781
eceeb5fc 27822012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2783
2784 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2785
71873e2b
SM
27862012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2787
2788 * data.c (PUT_ERROR): New macro.
2789 (syms_of_data): Use it. Add new error type `user-error'.
2790 * undo.c (user_error): New function.
2791 (Fprimitive_undo): Use it.
2792 * print.c (print_error_message): Adjust print style for `user-error'.
2793 * keyboard.c (user_error): New function.
2794 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2795
ab0fa4e4
PE
27962012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2797
2798 Do not limit current-time-string to years 1000..9999.
2799 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2800 (Fcurrent_time_string): Support any year that is supported by the
2801 underlying localtime representation. Don't use asctime, as it
2802 has undefined behavior for years outside the range -999..9999.
2803
7ed806a7
PE
28042012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2805
2806 Fix race conditions involving setenv, gmtime, localtime, asctime.
2807 Without this fix, interrupts could mess up code that uses these
2808 nonreentrant functions, since setting TZ invalidates existing
2809 tm_zone or tzname values, and since most of these functions return
2810 pointers to static storage.
2811 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2812 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2813 Grow the critical sections to include not just invoking
2814 localtime/gmtime, but also accessing these functions' results
2815 including their tm_zone values if any, and any related TZ setting.
2816 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2817 so that the struct tm is saved in the critical section.
2818 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2819 motivated by the fact that memory allocation needs to be outside
2820 the critical section.
2821
0c16dfed
DA
28222012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2823
2824 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2825 with RESET_INTERVAL.
2826
2827 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2828 Remove duplicated buffer name initialization.
2829
3f83ace8
JM
28302012-05-02 Jim Meyering <jim@meyering.net>
2831
2832 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2833
c7b8541e
JM
2834 * xfns.c (x_window): Use xstrdup (Bug#11375).
2835
90207a15 28362012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2837
2838 * xdisp.c (pos_visible_p): If already at a newline from the
2839 display string before the 'while' loop, don't walk back the glyphs
2840 from it3.glyph_row. Solves assertion violation when the display
2841 string begins with a newline (egg.el). (Bug#11367)
2842
b593d6a9
AH
28432012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2844
2845 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2846 Move to simple.el.
2847
4737362e
GM
28482012-05-01 Glenn Morris <rgm@gnu.org>
2849
99cf43f9
GM
2850 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2851 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2852 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2853 All were removed before 23.1.
2854
9311dcff
GM
2855 * dispnew.c: Remove HAVE_LIBNCURSES test;
2856 it is always true on relevant platforms.
2857
4d5c6349
GM
2858 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2859 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2860
4737362e
GM
2861 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2862
74dd3a6b
AS
28632012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2864
2865 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2866 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2867 Remove.
2868
13c379ee
PE
28692012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2870
2871 Do not avoid creating empty evaporating overlays (Bug#9642).
2872 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2873 That is, do not delete an evaporating overlay if it becomes
2874 empty after its bounds are adjusted to fit within its buffer.
2875 This fix caused other problems, and I'm reverting it until we get
2876 to the bottom of them.
2877
a8e7d6d7 28782012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2879
2880 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2881
a8e7d6d7 28822012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2883
2884 * xdisp.c (pos_visible_p): If the window start position is beyond
2885 ZV, start the display from buffer beginning. Prevents assertion
2886 violation in init_iterator when the minibuffer window is scrolled
2887 via the scroll bar.
2888
2889 * window.c (window_scroll_pixel_based): Likewise.
2890
a8e7d6d7 28912012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2892
2893 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2894
a8e7d6d7 28952012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2896
2897 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2898 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2899
a8e7d6d7 29002012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2901
b593d6a9
AH
2902 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2903 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2904
1c6900d9
EZ
29052012-04-26 Eli Zaretskii <eliz@gnu.org>
2906
4c3fa1d9
EZ
2907 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2908 display element, check also the underlying string or buffer
2909 character. (Bug#11341)
2910
1c6900d9
EZ
2911 * w32menu.c: Include w32heap.h.
2912 (add_menu_item): If the call to AppendMenuW (via
2913 unicode_append_menu) fails, disable Unicode menus only if we are
2914 running on Windows 9X/Me.
2915
42bf8205
AS
29162012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2917
2918 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2919 (xgetint): Add missing shift for LSB tags.
2920
b1bac16e
MR
29212012-04-24 Martin Rudalics <rudalics@gmx.at>
2922
2923 * keyboard.c (read_char): Don't wipe echo area for select window
2924 events: These might get delayed via `mouse-autoselect-window'
2925 (Bug#11304).
2926
d69621cc
JB
29272012-04-24 Juanma Barranquero <lekktu@gmail.com>
2928
2929 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2930 manipulation of :loaded-from data.
2931
02fd101b
JB
29322012-04-23 Juanma Barranquero <lekktu@gmail.com>
2933
2934 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2935 now a cons (bug#11311).
2936
888bec30
PE
29372012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2938
89a438bd
PE
2939 Do not create empty overlays with the evaporate property (Bug#9642).
2940 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2941 if it becomes empty after its bounds are adjusted to fit within
2942 its buffer. Without this fix, in a nonempty buffer (let ((o
2943 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2944 yields an empty overlay that has the evaporate property, which is
2945 not supposed to happen.
2946
1068fe4d
PE
2947 Fix minor GTK3 problems found by static checking.
2948 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2949 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2950 (struct _EmacsFixedClass, emacs_fixed_get_type):
2951 Move decls here from emacsgtkfixed.h, since they needn't be public.
2952 (emacs_fixed_get_type): Now static.
2953 (emacs_fixed_class_init): Omit unused local.
2954 (emacs_fixed_child_type): Remove; unused.
2955 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2956 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2957 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2958 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2959 (EMACS_FIXED_GET_CLASS): Remove; unused.
2960 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2961
888bec30
PE
2962 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2963 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2964
de85e130
PE
29652012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2966
d0baac98 2967 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2968 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2969 (__malloc_size_t, __malloc_ptrdiff_t):
2970 Remove. All uses removed, replaced by the definiens if needed,
2971 since we can assume C89 or better now.
2972 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2973 (protect_malloc_state, align, get_contiguous_space)
2974 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2975 (malloc_atfork_handler_child, malloc_enable_thread)
2976 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2977 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2978 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2979 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2980 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2981 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2982 Define using prototypes, not old style.
2983 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2984 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2985 (align): Don't assume that signed integer overflow wraps around.
2986 Omit unused local var.
2987 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2988 (_free_internal_nolock, memalign, mallochook, reallochook):
2989 Omit no-longer-needed casts.
2990 (valloc): Use getpagesize, not __getpagesize.
2991 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2992 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2993
de85e130
PE
2994 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2995
dcbf5805
MA
29962012-04-22 Michael Albinus <michael.albinus@gmx.de>
2997
2998 Move functions from C to Lisp. Make non-blocking method calls
2999 the default. Implement further D-Bus standard interfaces.
3000
3001 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3002 (QCdbus_request_name_allow_replacement)
3003 (QCdbus_request_name_replace_existing)
3004 (QCdbus_request_name_do_not_queue)
3005 (QCdbus_request_name_reply_primary_owner)
3006 (QCdbus_request_name_reply_in_queue)
3007 (QCdbus_request_name_reply_exists)
3008 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3009 (QCdbus_registered_serial, QCdbus_registered_method)
3010 (QCdbus_registered_signal): New Lisp objects.
3011 (XD_DEBUG_MESSAGE): Use sizeof.
3012 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3013 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3014 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3015 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3016 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3017 (xd_signature, xd_append_arg): Allow float for integer types.
3018 (xd_get_connection_references): New function.
b593d6a9
AH
3019 (xd_get_connection_address): Rename from xd_initialize.
3020 Return cached address.
dcbf5805
MA
3021 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3022 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3023 level.
3024 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3025 Return number of refcounts.
dcbf5805
MA
3026 (Fdbus_get_unique_name): Make stronger parameter check.
3027 (Fdbus_message_internal): New defun.
3028 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3029 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3030 (Fdbus_send_signal, Fdbus_register_service)
3031 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3032 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3033 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3034 (Vdbus_compiled_version, Vdbus_runtime_version)
3035 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3036 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3037 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3038 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3039 Adapt docstring.
dcbf5805 3040
52828e02
PE
30412012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3042
da05bc4c
PE
3043 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3044 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3045 Do not assume ptrdiff_t is the same width as 'int'.
3046
52828e02
PE
3047 * alloc.c: Handle unusual debugging option combinations.
3048 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3049 since the two debugging options are incompatible.
3050 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3051 is defined.
3052 (mem_init, mem_insert, mem_insert_fixup):
3053 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3054 (NEED_MEM_INSERT): Remove; no longer needed.
3055
f01769f9
LL
30562012-04-22 Leo Liu <sdl.web@gmail.com>
3057
3058 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3059
5790543d
PE
30602012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3061
3062 * sysdep.c [__FreeBSD__]: Minor cleanups.
3063 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3064 Use Emacs indenting style more consistently. Avoid some casts.
3065 Use 'double' consistently rather than mixing 'float' and 'double'.
3066
b91b7e4d
EW
30672012-04-21 Eduard Wiebe <usenet@pusto.de>
3068
b593d6a9
AH
3069 * sysdep.c (list_system_processes, system_process_attributes):
3070 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3071
6114eb15
AS
30722012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3073
3074 * lisp.mk (lisp): Update.
3075
2f38dff7
PE
30762012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3077
3078 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3079 It is never used otherwise.
3080
4ae29f89
SM
30812012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3082
3083 * print.c (print_preprocess): Only check print_depth if print-circle
3084 is nil.
3085 (print_object): Check for cycles even when print-circle is nil and
3086 print-gensym is t, but only check print_depth if print-circle is nil.
3087
f30d612a
CY
30882012-04-20 Chong Yidong <cyd@gnu.org>
3089
3090 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3091 set the status to "failed" and ensure that sentinel is run.
3092
c07a4c0b 30932012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3094
3095 * process.c (Fset_process_inherit_coding_system_flag)
3096 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3097 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3098
c07a4c0b 30992012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3100
3101 * xdisp.c (string_buffer_position_lim): Limit starting position to
3102 BEGV.
3103 (set_cursor_from_row): If called for a mode-line or header-line
3104 row, return zero immediately.
3105 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3106 farther than the first row after the header line, if any.
3107 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3108 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3109
c07a4c0b 31102012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3111
4ae29f89
SM
3112 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3113 (bug#11238).
ad3a2b41 3114
c07a4c0b 31152012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 31162012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3117
3118 configure: new option --enable-gcc-warnings (Bug#11207)
3119 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3120 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3121 (ALL_CFLAGS): Use new macros rather than old.
3122 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3123 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3124 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3125 -Wunused-result, -Wunused-variable. This should go away once
3126 the Emacs and Gnulib regex code is merged.
3127 (xmalloc, xrealloc): Now static.
3128
aba027e8
PE
31292012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3130
3131 * dired.c (Fsystem_groups): Remove unused local.
3132
e5a36063
GM
31332012-04-17 Glenn Morris <rgm@gnu.org>
3134
3135 * dired.c (Fsystem_users): Doc fix.
3136
316411f0
DA
31372012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3138
3139 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3140 (syms_of_dired): Add them.
3141
9426aba4
PE
31422012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3143
b62a57be
PE
3144 Fix minor alloc.c problems found by static checking.
3145 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3146 New extern decls, to avoid calling undeclared functions.
3147 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3148 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3149 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3150 (NEED_MEM_INSERT): New macro.
3151 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3152 Remove one incorrect comment and fix another.
b62a57be 3153
3539f31f
PE
3154 Fix minor ralloc.c problems found by static checking.
3155 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3156 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3157 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3158 (r_alloc_sbrk): Now static.
3159
a041960a
PE
3160 Improve ralloc.c interface checking.
3161 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3162 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3163 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3164 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3165 [REL_ALLOC]: ... to here, to check interface.
3166 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3167 Remove decls. This fixes an "It stinks!".
3168
9426aba4
PE
3169 * alloc.c (which_symbols): Fix alignment issue / type clash.
3170
d55c12ed
AS
31712012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3172
3173 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3174 (struct Lisp_Misc_Any): Likewise.
3175 (struct Lisp_Free): Likewise.
3176 * alloc.c (union aligned_Lisp_Symbol): Define.
3177 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3178 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3179 (union aligned_Lisp_Misc): Define.
3180 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3181 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3182 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3183
b948ce8b
PE
31842012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3185
3186 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3187 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3188 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3189 * s/netbsd.h, s/sol2-6.h:
3190 Remove definition of GC_MARK_STACK, since the default now works.
3191 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3192 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3193 no longer the default.
3194 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3195
35dc09a1 31962012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3197
35dc09a1
GM
3198 * lread.c (lisp_file_lexically_bound_p):
3199 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3200
35dc09a1
GM
32012012-04-14 Eli Zaretskii <eliz@gnu.org>
3202
3203 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3204 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3205
32062012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3207
3208 * nsterm.m (constrainFrameRect): Always constrain when there is only
3209 one screen (Bug#10962).
3210
bcd86815
KB
32112012-04-13 Ken Brown <kbrown@cornell.edu>
3212
3213 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3214
c25df26e
RT
32152012-04-13 Reuben Thomas <rrt@sc3d.org>
3216
3217 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3218
0fc59f1e
DC
32192012-04-11 Daniel Colascione <dancol@dancol.org>
3220
3221 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3222 against is gone. It's better to use vfork now so that when Cygwin
3223 gains a new, working vfork, we use it automatically (bug#10398).
3224
de8c03dc
SM
32252012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3226
3227 * window.c (save_window_save): Obey window-point-insertion-type.
3228
2f097256
GM
32292012-04-11 Glenn Morris <rgm@gnu.org>
3230
3231 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3232
453b951e
SM
32332012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3234
3235 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3236
75f1671a 32372012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3238
3239 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3240 (force_quit_count): New var.
3241 (handle_interrupt): Use it.
3242
2a8ce227
JB
32432012-04-10 Juanma Barranquero <lekktu@gmail.com>
3244
3245 * w32.c (w32_delayed_load): Record the full path of the library
3246 being loaded (bug#10424).
3247
935396c0
GM
32482012-04-09 Glenn Morris <rgm@gnu.org>
3249
05920a43
GM
3250 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3251 not just in the obarray, before snarfing them. (Bug#11036)
3252
935396c0
GM
3253 * Makefile.in ($(leimdir)/leim-list.el):
3254 Pass EMACS rather than BUILT_EMACS.
3255
a18ecafa
TZ
32562012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3257
3258 * process.c (make_process):
3259 * process.h: Add integer `gnutls_handshakes_tried' member to
3260 process struct.
3261
6bbef4e5
JC
3262 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3263 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3264
3265 * gnutls.c (gnutls_log_function2i): Convenience log function.
3266 (emacs_gnutls_read): Use new log functions,
3267 `gnutls_handshakes_tried' process member, and
3268 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3269 attempts per process (connection).
3270
b4d3bc10
CY
32712012-04-09 Chong Yidong <cyd@gnu.org>
3272
3273 * eval.c (Fuser_variable_p, user_variable_p_eh)
3274 (lisp_indirect_variable): Functions deleted.
3275 (Fdefvar): Caller changed.
3276
3277 * callint.c (Finteractive, Fcall_interactively):
3278 * minibuf.c (Fread_variable): Callers changed.
3279
70f4d973
EZ
32802012-04-09 Eli Zaretskii <eliz@gnu.org>
3281
3282 * xdisp.c (set_cursor_from_row): If the display string appears in
3283 the buffer at position that is closer to point than the position
3284 after the display string, display the cursor on the first glyph of
3285 the display string. Fixes cursor display when a 'display' text
3286 property immediately follows invisible text. (Bug#11094)
3287
cb3c2e3e
PE
32882012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3289
3290 composite.c: use 'double' consistently
3291 * composite.c (get_composition_id): Use 'double' consistently
3292 instead of converting 'float' to 'double' and vice versa; this is
3293 easier to understand and avoids a GCC warning.
3294
fd06db5d
GM
32952012-04-09 Glenn Morris <rgm@gnu.org>
3296
50fe702a
GM
3297 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3298 preparation for dumping it with emacs. (Bug#4789)
3299 (leimdir): New variable.
3300 ($(leimdir)/leim-list.el): New rule.
3301 (emacs$(EXEEXT)): Depend on leim-list.el.
3302
fd06db5d
GM
3303 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3304 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3305 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3306
55c131ee
AS
33072012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3308
3309 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3310 proper alignment.
3311
9209588f
JB
33122012-04-07 Juanma Barranquero <lekktu@gmail.com>
3313
3314 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3315 Remove unused local variable.
3316
e3fb2efb
PE
33172012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3318
3319 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3320 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3321 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3322 objects, as mark_maybe_pointer will catch them otherwise.
3323 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3324 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3325
b5385551
PE
33262012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3327
3328 Fix typo that broke non-Windows builds.
3329 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3330
9078ead6
EZ
33312012-04-07 Eli Zaretskii <eliz@gnu.org>
3332
3333 Support building on MS-Windows with libxml2.
3334
3335 * makefile.w32-in (OBJ2): Add xml.$(O).
3336 (GLOBAL_SOURCES): Add xml.c.
3337 ($(BLD)/xml.$(O)): New dependency list.
3338
3339 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3340 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3341 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3342 [!WINDOWSNT]: New macros.
3343 (init_libxml2_functions, libxml2_loaded_p): New functions.
3344 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3345 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3346 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3347 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3348 linked in).
6bbef4e5
JC
3349 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3350 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3351 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3352
3353 * emacs.c: Don't include libxml/parser.h.
3354 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3355 xmlCleanupParser directly.
3356
3357 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3358
3811fdf3
EZ
33592012-04-07 Eli Zaretskii <eliz@gnu.org>
3360
3361 * indent.c (Fvertical_motion): If there is a display string at
3362 point, use it.vpos to compute how many lines to backtrack after
3363 move_it_to point. (Bug#11133)
3364
2f8e16b2
EZ
33652012-04-06 Eli Zaretskii <eliz@gnu.org>
3366
3367 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3368 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3369 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3370 macros related to unification of CJK characters. For the details,
3371 see the discussion following the message here:
3372 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3373
3d439cd1
CY
33742012-04-04 Chong Yidong <cyd@gnu.org>
3375
3376 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3377
8bc53d00
EZ
33782012-04-01 Eli Zaretskii <eliz@gnu.org>
3379
3380 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3381 instead of alloca. (Bug#11138)
3382
3b0512a3
AS
33832012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3384
3385 * w32menu.c (is_simple_dialog): Properly check lisp types.
3386 (Bug#11141)
3387
8427ddd2
EZ
33882012-03-31 Eli Zaretskii <eliz@gnu.org>
3389
979022ef
EZ
3390 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3391 position we get to after a call to move_it_to fails the
3392 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3393 only if we wind up in a string from display property. (Bug#11063)
3394
a6b1c7cc
EZ
3395 * window.c (Fdelete_other_windows_internal): Invalidate the row
3396 and column information about mouse highlight, so that redisplay
3397 restores it after reallocating the glyph matrices. (Bug#7464)
3398
8427ddd2
EZ
3399 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3400 string comes from a `display' text property, use the buffer
3401 position of that property as if we actually saw that position in
3402 the row's glyphs.
697ba24b
EZ
3403 (move_it_by_lines): Remove the assertion that
3404 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3405 violated when there's a before-string at the beginning of a line.
3406 (Bug#11063)
8427ddd2 3407
65a0a738
EZ
34082012-03-30 Eli Zaretskii <eliz@gnu.org>
3409
3410 * xdisp.c (append_space_for_newline): If the default face was
3411 remapped, use the remapped face for the appended newline.
3412 (extend_face_to_end_of_line): Use the remapped default face for
3413 extending the face to the end of the line.
3414 (display_line): Call extend_face_to_end_of_line when the default
3415 face was remapped. (Bug#11068)
3416
581355cc
EZ
34172012-03-29 Eli Zaretskii <eliz@gnu.org>
3418
3419 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3420
e8fc049f
SM
34212012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3422
3423 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3424
4fb9a543
GM
34252012-03-27 Glenn Morris <rgm@gnu.org>
3426
3427 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3428 Doc fixes.
3429
679910f1
KH
34302012-03-26 Kenichi Handa <handa@m17n.org>
3431
3432 * dispextern.h (struct glyph): Fix previous change. Change the
3433 bit length of glyphless.ch to 25 (Bug#11082).
3434
90d49b7f
CY
34352012-03-26 Chong Yidong <cyd@gnu.org>
3436
3437 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3438 (command_loop_1): Use it; inhibit selection update for
3439 handle-select-window too (Bug#8996).
3440
f514f6f0
FP
34412012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3442
e8fc049f 3443 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3444
bf43fa51
KH
34452012-03-25 Kenichi Handa <handa@m17n.org>
3446
3447 * dispextern.h (struct glyph): Change the bit length of
3448 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3449
8a0c01dd
EZ
34502012-03-24 Eli Zaretskii <eliz@gnu.org>
3451
3452 * s/ms-w32.h (tzname): Include time.h before redirecting to
3453 _tzname. Fixes the MSVC build. (Bug#9960)
3454
7d1c3a76
AS
34552012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3456
8ed79523
AS
3457 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3458 characters.
3459
7d1c3a76
AS
3460 * xterm.c (XTread_socket): Only modify handling_signal if
3461 !SYNC_INPUT. (Bug#11080)
3462
e99a9b8b
EZ
34632012-03-23 Eli Zaretskii <eliz@gnu.org>
3464
3465 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3466 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3467 when fetching a multibyte character consumes more bytes than
3468 CHAR_BYTES returns, due to unification of CJK characters in
3469 string_char. (Bug#11073)
3470
5063c0e1
TN
34712012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3472
3473 * process.c (wait_reading_process_output): Handle pty disconnect
3474 by refraining from sending oneself a SIGCHLD (bug#10933).
3475
9f851fbd
CY
34762012-03-22 Chong Yidong <cyd@gnu.org>
3477
3478 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3479
5063c0e1 3480 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3481 Mark string as coming from a prefix property.
3482 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3483 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3484
fb5b8aca
CY
34852012-03-21 Chong Yidong <cyd@gnu.org>
3486
3487 * xfaces.c (Vface_remapping_alist): Doc fix.
3488
62356a1b
EZ
34892012-03-20 Eli Zaretskii <eliz@gnu.org>
3490
3491 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3492 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3493 Doc fixes.
62356a1b 3494
025de85b
CY
34952012-03-20 Chong Yidong <cyd@gnu.org>
3496
3497 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3498 to reflect default non-nil value of redisplay-dont-pause.
3499
4827f94e
KH
35002012-03-19 Kenichi Handa <handa@m17n.org>
3501
3502 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3503 it fit in a valid range (Bug#11003).
3504
e50a24a2
EZ
35052012-03-18 Eli Zaretskii <eliz@gnu.org>
3506
3507 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3508 that is not from display property, accept the row as a "cursor
3509 row" if one of the string's character has a non-nil `cursor'
3510 property. Fixes cursor positioning when there are newlines in
3511 overlay strings, e.g. in icomplete.el. (Bug#11035)
3512
9af5ed87
PE
35132012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3516
d1f55f16
CY
35172012-03-12 Chong Yidong <cyd@gnu.org>
3518
3519 * eval.c (inhibit_lisp_code): Rename from
3520 inhibit_window_configuration_change_hook; move from window.c.
3521
3522 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3523 * window.c (run_window_configuration_change_hook)
3524 (syms_of_window): Callers changed.
3525
66c5eebd
CY
35262012-03-11 Chong Yidong <cyd@gnu.org>
3527
413df973
CY
3528 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3529
66c5eebd
CY
3530 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3531
1de11f56
CY
35322012-03-10 Chong Yidong <cyd@gnu.org>
3533
3534 * frame.c (other_visible_frames): Don't assume the selected frame
3535 is visible (Bug#10955).
3536
cae07000
SM
35372012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3538
3539 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3540
89c94350
JD
35412012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3542
3543 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3544 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3545 zero (Bug#10954).
3546
999dd333
GM
35472012-03-03 Glenn Morris <rgm@gnu.org>
3548
01a6dcc8 3549 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3550
de0100f2
EZ
35512012-03-02 Eli Zaretskii <eliz@gnu.org>
3552
3553 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3554 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3555 (redisplay_window, next_element_from_string): Fix typos in
3556 comments.
3e441275
EZ
3557 (redisplay_window): Pass to move_it_vertically the margin in
3558 pixels, not in screen lines.
de0100f2 3559
96a72ee9
GM
35602012-03-02 Glenn Morris <rgm@gnu.org>
3561
3562 * buffer.c (buffer-list-update-hook): Doc fix.
3563
312508d7
EZ
35642012-02-29 Eli Zaretskii <eliz@gnu.org>
3565
3566 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3567 push_it before setting up the iterator for the first overlay
3568 string, even if we have an empty string loaded.
3569 (next_overlay_string): If there's an empty string on the iterator
3570 stack, pop the stack. (Bug#10903)
3571
27f3c637
PE
35722012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3573
3574 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3575 Suggested by Stefan Monnier in
3576 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3577 * alloc.c (widen_to_Lisp_Object): New static function.
3578 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3579 and widening them to Lisp_Objects. This would work even if
3580 USE_LSB_TAG is defined and wide integers are used, which might
3581 happen in a future version of Emacs.
3582
3c9dfce6
CY
35832012-02-25 Chong Yidong <cyd@gnu.org>
3584
fa74b241
CY
3585 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3586 Doc fix.
3587
3c9dfce6
CY
3588 * xselect.c (Fx_selection_exists_p): Doc fix.
3589 (x_clipboard_manager_save_all): Print an informative message
3590 before saving to clipboard manager.
3591
9486df08
CY
35922012-02-24 Chong Yidong <cyd@gnu.org>
3593
3594 * keyboard.c (process_special_events): Handle all X selection
3595 requests in kbd_buffer, not just the next one (Bug#8869).
3596
f01d3321
CY
35972012-02-23 Chong Yidong <cyd@gnu.org>
3598
3599 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3600 call when setting menu-bar-lines and tool-bar-lines parameters.
3601 (unwind_create_frame_1): New helper function.
3602
3603 * window.c (inhibit_window_configuration_change_hook): New var.
3604 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3605 (syms_of_window): Initialize it.
f01d3321 3606
86b847b6
CY
36072012-02-22 Chong Yidong <cyd@gnu.org>
3608
3609 * xterm.c (x_draw_image_relief): Add missing type check for
3610 Vtool_bar_button_margin (Bug#10743).
3611
a59225b1
CY
36122012-02-21 Chong Yidong <cyd@gnu.org>
3613
3614 * fileio.c (Vfile_name_handler_alist): Doc fix.
3615
3616 * buffer.c (Fget_file_buffer): Protect against invalid file
3617 handler return value.
3618
310f5bd4
PE
36192012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3620
cb3a28cc
PE
3621 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3622 when computing $valmask.
3623
310f5bd4
PE
3624 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3625 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3626 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3627 It's useless in that case, and it can cause problems on hosts
3628 that allocate halves of EMACS_INT values separately.
3629 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3630 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3631 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3632 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3633 it avoids undefined behavior on hosts where shifting right by more
3634 than the word width has undefined behavior.
3635
2375c96a
CY
36362012-02-19 Chong Yidong <cyd@gnu.org>
3637
3638 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3639 (Funhandled_file_name_directory, Ffile_name_as_directory)
3640 (Fdirectory_file_name, Fexpand_file_name)
3641 (Fsubstitute_in_file_name): Protect against invalid file handler
3642 return values (Bug#10845).
3643
3eb49e71
EZ
36442012-02-18 Eli Zaretskii <eliz@gnu.org>
3645
3646 * .gdbinit (pitx): Fix incorrect references to fields of the
3647 iterator stack.
3648
7b926f3f
CY
36492012-02-17 Chong Yidong <cyd@gnu.org>
3650
3651 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3652
11273115
PE
36532012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3654
3655 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3656 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3657
c3a70e2b
CY
36582012-02-15 Chong Yidong <cyd@gnu.org>
3659
3660 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3661 marked as special. Also, starting docstrings with * is obsolete.
3662
0ca43699
AS
36632012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3664
3665 * gnutls.c (emacs_gnutls_write): Fix last change.
3666
2e8f3c56
LI
36672012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3668
3669 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3670 send_process.
3671
af70074f
SM
36722012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3673
3674 * keymap.c (Fsingle_key_description): Handle char ranges.
3675
95986d52
CY
36762012-02-12 Chong Yidong <cyd@gnu.org>
3677
afd83bd1
CY
3678 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3679 as that creates a dangerous corner case.
3680
95986d52
CY
3681 * window.c (Fdelete_window_internal): Invalidate the mouse
3682 highlight (Bug#9904).
3683
bd7da63e
GM
36842012-02-12 Glenn Morris <rgm@gnu.org>
3685
3686 * xselect.c (Fx_own_selection_internal)
3687 (Fx_get_selection_internal, Fx_disown_selection_internal)
3688 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3689 * nsselect.m (Fx_own_selection_internal)
3690 (Fx_disown_selection_internal, Fx_selection_exists_p)
3691 (Fx_selection_owner_p, Fx_get_selection_internal):
3692 Sync docs and argument specs with the xselect.c versions.
3693
77abcbc2
LI
36942012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3695
3696 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3697
90b671e2
EZ
36982012-02-11 Eli Zaretskii <eliz@gnu.org>
3699
1c0ca0b7
EZ
3700 * w32select.c (Fx_selection_exists_p): Sync doc string and
3701 argument list with xselect.c. (Bug#10783)
3702
3703 * w16select.c (Fx_selection_exists_p): Sync doc string and
3704 argument list with xselect.c. (Bug#10783)
90b671e2 3705
49241268
GM
37062012-02-10 Glenn Morris <rgm@gnu.org>
3707
3708 * fns.c (Fsecure_hash): Doc fix.
3709
f998bbe7 37102012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3711
3712 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3713
0992bd9c
CY
37142012-02-07 Chong Yidong <cyd@gnu.org>
3715
3716 * buffer.c (Fbuffer_local_variables)
3717 (buffer_lisp_local_variables): Handle unbound vars correctly;
3718 don't let Qunbound leak into Lisp.
3719
af008560
GM
37202012-02-07 Glenn Morris <rgm@gnu.org>
3721
dd605cc4
GM
3722 * image.c (Fimagemagick_types): Doc fix.
3723
af008560
GM
3724 * image.c (imagemagick-render-type): Change it from a lisp object
3725 to an integer. Move the doc here from the lisp manual.
3726 Treat all values not equal to 0 the same.
3727
1449fa1d
CY
37282012-02-06 Chong Yidong <cyd@gnu.org>
3729
3730 * doc.c (store_function_docstring): Avoid applying docstring of
3731 alias to base function (Bug#2603).
3732
3723ec07
AS
37332012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3734
3735 * .gdbinit (pp1, pv1): Remove redundant defines.
3736 (pr): Use pp.
3737
79c1cc1e
CY
37382012-02-04 Chong Yidong <cyd@gnu.org>
3739
3740 * nsterm.m: Declare a global (Bug#10694).
3741
d7f29f8e
EZ
37422012-02-04 Eli Zaretskii <eliz@gnu.org>
3743
cae07000
SM
3744 * w32.c (get_emacs_configuration_options):
3745 Include --enable-checking, if specified, in the return value.
d7f29f8e 3746
3b95a6f9
MR
37472012-02-04 Martin Rudalics <rudalics@gmx.at>
3748
3749 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3750 after rounding frame sizes. (Bug#9723)
3751
d6fa96a6
EZ
37522012-02-04 Eli Zaretskii <eliz@gnu.org>
3753
3754 * keyboard.c (adjust_point_for_property): Don't position point
3755 before BEGV. (Bug#10696)
3756
df0b2940
PE
37572012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3758
3759 Handle overflow when computing char display width (Bug#9496).
3760 * character.c (char_width): Return EMACS_INT, not int.
3761 (char_width, c_string_width): Check for overflow when
3762 computing the width; this is possible now that individual
3763 characters can have unbounded width. Problem introduced
3764 by merge from Emacs 23 on 2012-01-19.
3765
6bee44d6
MA
37662012-02-02 Michael Albinus <michael.albinus@gmx.de>
3767
3768 * dbusbind.c (Fdbus_register_method): Mention the return value
3769 :ignore in the docstring.
3770
44f92739
GM
37712012-02-02 Glenn Morris <rgm@gnu.org>
3772
1b9f60cc
GM
3773 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3774
44f92739
GM
3775 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3776 Unconditionally set to t. (Bug#10673)
3777 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3778 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3779 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3780
c5d3843c
KH
37812012-02-02 Kenichi Handa <handa@m17n.org>
3782
3783 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3784 0, do not call append_composite_glyph.
3785
159462d4 37862012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3787
3788 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3789 NULL (Bug#6988).
3790 (x_produce_glyphs): If the component of a composition is a null
3791 string, set it->pixel_width to 1 to avoid zero-width glyph.
3792
78cef877
EZ
37932012-02-01 Eli Zaretskii <eliz@gnu.org>
3794
3795 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3796 first 2 arguments are identical. This makes inserting large
3797 output from a subprocess an order of magnitude faster on
3798 MS-Windows, where all sbrk'ed memory is always contiguous.
3799
97897668
GM
38002012-01-31 Glenn Morris <rgm@gnu.org>
3801
3802 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3803 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3804 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3805
31fd3586
GM
38062012-01-29 Glenn Morris <rgm@gnu.org>
3807
3808 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3809
0e24a8b2
CY
38102012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3811
3812 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3813
cc0adcb0
CY
38142012-01-28 Chong Yidong <cyd@gnu.org>
3815
3816 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3817
acc28cb9
CY
38182012-01-26 Chong Yidong <cyd@gnu.org>
3819
9c69cfb7
CY
3820 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3821
acc28cb9
CY
3822 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3823 repeat counts (Bug#10507).
3824
48da7392
GM
38252012-01-26 Glenn Morris <rgm@gnu.org>
3826
3827 * lread.c (syms_of_lread): Doc fix.
3828
14af5f7f
CY
38292012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3830
3831 * coding.c (encode_designation_at_bol): Change return value to
3832 EMACS_INT.
3833
0b21c100
CY
38342012-01-25 Chong Yidong <cyd@gnu.org>
3835
3836 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3837
3c2907f7
CY
38382012-01-21 Chong Yidong <cyd@gnu.org>
3839
3840 * floatfns.c (Fcopysign): Make the second argument non-optional,
3841 since nil is not allowed anyway.
3842
959ad23f
AS
38432012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3844
3845 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3846 (send_process): Likewise.
3847
34a02f46
MR
38482012-01-19 Martin Rudalics <rudalics@gmx.at>
3849
3850 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3851 (Vwindow_persistent_parameters): Do not use Qstate.
3852 Rewrite doc-strings.
34a02f46 3853
1259009a 38542012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3855
3856 * character.c (char_width): New function.
70d4fdf6
GM
3857 (Fchar_width, c_string_width, lisp_string_width):
3858 Use char_width (Bug#9496).
25ed9e61 3859
6a6ee00d
MR
38602012-01-16 Martin Rudalics <rudalics@gmx.at>
3861
3862 * window.c (Vwindow_persistent_parameters): New variable.
3863 (Fset_window_configuration, save_window_save): Handle persistent
3864 window parameters.
3865
c85efaf7
EZ
38662012-01-14 Eli Zaretskii <eliz@gnu.org>
3867
3868 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3869 thrashing the stack of the thread. (Bug#9087)
3870
5944709e
PE
38712012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3874
e71f5d99
EZ
38752012-01-11 Eli Zaretskii <eliz@gnu.org>
3876
3877 * xdisp.c (rows_from_pos_range): Handle the case where the
3878 highlight ends on a newline. (Bug#10464)
3879 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3880 he end column for display of highlight that ends on a newline
3881 before a R2L line.
3882
ce316182
GM
38832012-01-11 Glenn Morris <rgm@gnu.org>
3884
3885 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3886 from load-path also when installation-directory is nil. (Bug#10208)
3887
5b43da69
GM
38882012-01-10 Glenn Morris <rgm@gnu.org>
3889
74cc8ff9
GM
3890 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3891
7d8d6e4e
GM
3892 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3893 Update template values to be closer to their typical values these days.
5b43da69 3894
a0db8d43
EZ
38952012-01-09 Eli Zaretskii <eliz@gnu.org>
3896
3897 * xdisp.c (rows_from_pos_range): Accept additional argument
3898 DISP_STRING, and accept any glyph in a row whose object is that
3899 string as eligible for mouse highlight. Fixes mouse highlight of
3900 display strings from overlays. (Bug#10464)
3901
9a0115ab 39022012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3903
b9110d6a 3904 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3905 * fileio.c (auto_saving_dir_umask): New static var.
3906 (Fmake_directory_internal): Use it.
3907 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3908 creating the directory. The old code temporarily assigns
3909 too-generous permissions to the directory.
3910 (do_auto_save_eh): Clear it.
b9110d6a 3911 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3912 that the var is always cleared.
3913
6c1bd3f3
EZ
39142012-01-07 Eli Zaretskii <eliz@gnu.org>
3915
3916 * search.c (scan_buffer): Pass character positions to
3917 know_region_cache, not byte positions. (Bug#6540)
3918
069d2b50
L
39192012-01-07 LynX <_LynX@bk.ru> (tiny change)
3920
3921 * w32.c (sys_rename): Report EXDEV when rename of a directory
3922 fails because the target is on another logical disk. (Bug#10284)
3923
75bf0d33
DB
39242012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3925
3926 * xterm.c (x_embed_request_focus): New function.
3927
3928 * xterm.h: Add prototype.
3929
3930 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3931
1c6e5a32
GM
39322012-01-05 Glenn Morris <rgm@gnu.org>
3933
3934 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3935
651e947e
EZ
39362012-01-01 Eli Zaretskii <eliz@gnu.org>
3937
3938 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3939 Load gnutls_transport_set_lowat only if GnuTLS version is below
3940 2.11.1.
3941 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3942 GnuTLS versions below 2.11.1.
3943
3778cdd8
AL
39442011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3945
3946 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3947 to the doc string advising against its use for altering the way
3948 windows are scrolled.
3949
0e5317f7
KH
39502011-12-28 Kenichi Handa <handa@m17n.org>
3951
3952 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3953 coding-system ASCII compatible only when it does not produce BOM
3954 on encoding (Bug#10383).
3955
93d5ca1f
JD
39562011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3957
3958 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3959 can scroll.
3960 (create_and_show_popup_menu): Always use menu_position_func for
3961 Gtk3 (Bug#10361).
3962
ca22b785
AS
39632011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3964
3965 * callint.c (Fcall_interactively): Don't truncate prompt string.
3966
d048e1e6
EZ
39672011-12-23 Eli Zaretskii <eliz@gnu.org>
3968
3969 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3970 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3971 resumed from there (after widening). (Bug#10360)
d048e1e6 3972
5ccaba1f
JD
39732011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3974
3975 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3976
204ee57f
JD
39772011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3978
b81d40f0
JB
3979 * nsterm.m (x_free_frame_resources):
3980 Release f->output_data.ns->miniimage.
204ee57f
JD
3981 (ns_index_color): Fix indentation. Do not retain
3982 color_table->colors[i].
3983
3984 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3985 before returning.
3986
3987 * nsfns.m (x_set_background_color): Assign return value from
3988 ns_index_color to face-background instead of NSColor*.
3989 (ns_implicitly_set_icon_type): Fix indentation.
3990 Change assignment in for loop to comparison.
3991
3992 * emacs.c (ns_pool): New variable.
3993 (main): Assign ns_pool.
3994 (Fkill_emacs): Call ns_release_autorelease_pool.
3995
3996 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3997 autorelease fdesc, release fdAttrs and tdict.
3998 (ns_get_covering_families): Release charset.
3999 (ns_findfonts): Release NSFontDescriptor created with new.
4000 (ns_uni_to_glyphs): Fix indentation.
4001 (setString): Release attrStr before assigning new value.
4002
c803b2b7
JD
40032011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4004
678f4426
JD
4005 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4006 and NS_IMPL_COCOA.
4007 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4008 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4009
cd394be1 40102011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4011
5fecd5fc
JD
4012 * nsterm.m (ns_term_init): Subscribe for notifications
4013 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4014 to method trackingNotification in EmacsMenu.
4015
4016 * nsmenu.m (trackingMenu): New variable.
3771cb17 4017 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4018 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4019 from Aquamacs (Bug#7030).
678f4426
JD
4020
40212011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4022
c803b2b7
JD
4023 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4024 (symbol_to_nsstring): Fix indentation.
4025 (ns_symbol_to_pb): New function.
cae07000
SM
4026 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4027 (Fns_rotate_cut_buffers_internal): Remove.
4028 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4029 Fns_store_cut_buffer_internal.
4030 (ns_get_foreign_selection, Fx_own_selection_internal)
4031 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4032 (Fns_get_selection_internal, Fns_store_selection_internal):
4033 Use ns_symbol_to_pb and check if return value is nil.
4034 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4035 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4036 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4037 renamed to Sns_store_selection_internal.
4038 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4039 and remove this function.
4040 (ns_handle_selection_clear): Remove, never used.
4041 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4042 here.
4043
e1b01a3a
KB
40442011-12-17 Ken Brown <kbrown@cornell.edu>
4045
4046 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4047 GID is unknown (Bug#10257).
4048
2adb6e85
PE
40492011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4050
4051 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4052 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4053 which caused a build failure on GNU/Linux IA-64. This problem was
4054 introduced by my 2011-10-07 patch.
4055
d1d7b339
JL
40562011-12-15 Juri Linkov <juri@jurta.org>
4057
4058 * image.c (imagemagick_error): New function. (Bug#10112)
4059 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4060 Use `imagemagick_error' where ImageMagick functions return
4061 `MagickFalse'.
4062 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4063 proper order.
4064
100d5755
KH
40652011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4066
4067 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4068 fill background (Bug#8992).
4069
454592a6
MR
40702011-12-13 Martin Rudalics <rudalics@gmx.at>
4071
4072 * window.c (Vwindow_combination_resize)
4073 (Vwindow_combination_limit): Use t instead of non-nil in
4074 doc-strings.
61d4b438
MR
4075 (Vrecenter_redisplay): Add first sentence of doc-string on
4076 separate line.
53524d93 4077 (Frecenter): Fix doc-string typo.
454592a6 4078
3633e3aa
KH
40792011-12-11 Kenichi Handa <handa@m17n.org>
4080
4081 * coding.c (Funencodable_char_position): Pay attention to the
4082 buffer text relocation (Bug#9389).
4083
7b9d523a 40842011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4085
7b9d523a
JD
4086 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4087 gtk_init (Bug#10100).
4088
b73189c6
EZ
40892011-12-10 Eli Zaretskii <eliz@gnu.org>
4090
4091 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4092 IT->string is nil. (Bug#10263)
4093
f7dfe5d6
JD
40942011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4095
83faebb4
JD
4096 * nsterm.h (x_free_frame_resources): Declare.
4097
f7dfe5d6
JD
4098 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4099 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4100
4101 * nsterm.h (ns_get_defaults_value): Declare.
4102
4103 * nsterm.m (ns_default): Call ns_get_defaults_value.
4104
7cd4e72c
EZ
41052011-12-09 Eli Zaretskii <eliz@gnu.org>
4106
4107 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4108 (Bug#10170)
4109
b34d7317
YM
41102011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4111
4112 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4113 that where the value of an _OBJC_* symbol points to is in the .bss
4114 section (Bug#10240).
4115
76470ad1
KH
41162011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4117
4118 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4119 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4120
745fff94
KH
41212011-12-08 Kenichi Handa <handa@m17n.org>
4122
4123 * ftfont.c (get_adstyle_property): Fix previous change
4124 (Bug#10233).
4125
6e44397c
JB
41262011-12-07 Juanma Barranquero <lekktu@gmail.com>
4127
4128 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4129 dirs from the default value of EMACSLOADPATH (bug#10208).
4130
7efa6272
GM
41312011-12-07 Glenn Morris <rgm@gnu.org>
4132
4133 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4134 installation and source directories as well. (Bug#10208)
4135
f6fc4d87
CY
41362011-12-06 Chong Yidong <cyd@gnu.org>
4137
4138 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4139
2bf26180
GM
41402011-12-06 Glenn Morris <rgm@gnu.org>
4141
4142 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4143 as an error, not just -1. (Bug#10217)
4144
3a6ad4f0
CY
41452011-12-05 Chong Yidong <cyd@gnu.org>
4146
4147 * keyboard.c (process_special_events): New function.
4148 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4149
75a3b399
PE
41502011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4151
4152 * coding.c (encode_designation_at_bol): Don't use uninitialized
4153 local variable (Bug#9318).
4154
c3c9e25e
KH
41552011-12-05 Kenichi Handa <handa@m17n.org>
4156
4157 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4158 return Qnil (Bug#8046, Bug#10193).
4159
5eb05ea3
KH
41602011-12-05 Kenichi Handa <handa@m17n.org>
4161
4162 * coding.c (encode_designation_at_bol): New args charbuf_end and
4163 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4164 (coding_set_source): Return how many bytes coding->source was
4165 relocated.
4166 (coding_set_destination): Return how many bytes
4167 coding->destination was relocated.
4168 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4169 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4170
41712011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4172
4173 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4174 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4175 macro (Bug#9318).
4176
41772011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4178
4179 The following changes are to fix Bug#9318.
4180
a79703f5 4181 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4182 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4183 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4184 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4185
7dbda6df
JB
41862011-12-05 Juanma Barranquero <lekktu@gmail.com>
4187
4188 * lisp.h (process_quit_flag): Fix external declaration.
4189
6d5eb5b0
SM
41902011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4191
4192 Don't macro-inline non-performance-critical code.
4193 * eval.c (process_quit_flag): New function.
4194 * lisp.h (QUIT): Use it.
4195
a0c3fad0
JD
41962011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4197
4198 * nsfns.m (get_geometry_from_preferences): New function.
4199 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4200
6c07aac2
AS
42012011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4202
4203 * emacs.c (Qkill_emacs): Define.
4204 (syms_of_emacs): Initialize it.
4205 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4206 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4207 (quit_throw_to_read_char): Add parameter `from_signal'.
4208 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4209 * lisp.h (QUIT): Call Fkill_emacs if requested.
4210
c052ead4
JD
42112011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4212
4213 * widget.c (update_wm_hints): Return if wmshell is null.
4214 (widget_update_wm_size_hints): New function.
4215
4216 * widget.h (widget_update_wm_size_hints): Declare.
4217
4218 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4219 widget_update_wm_size_hints (Bug#10104).
4220
9e49252b
EZ
42212011-12-03 Eli Zaretskii <eliz@gnu.org>
4222
4223 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4224 before a newline, prepare the bidi iterator for consuming the
4225 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4226 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4227
02b16839
JL
42282011-12-02 Juri Linkov <juri@jurta.org>
4229
4230 * search.c (Fword_search_regexp): New Lisp function created from
4231 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4232 (Fword_search_backward, Fword_search_forward)
4233 (Fword_search_backward_lax, Fword_search_forward_lax):
4234 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4235 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4236
0068070e
SM
42372011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4238
4239 * fileio.c (Finsert_file_contents): Move after-change-function call
4240 to before the "handled:" label, since all "goto handled" appear in
4241 cases where the *-change-functions have already been properly called
4242 (bug#10117).
4243
3360a3fc
AS
42442011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4245
4246 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4247 waiting for input. (Bug#10169)
4248
73d6c093
EZ
42492011-11-30 Eli Zaretskii <eliz@gnu.org>
4250
4251 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4252 verifies glyph row's hash code--we have just reallocated the
4253 glyphs, so their contents can be complete garbage. (Bug#10164)
4254
febe6bea
JB
42552011-11-30 Juanma Barranquero <lekktu@gmail.com>
4256
4257 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4258
801a4313
EZ
42592011-11-30 Eli Zaretskii <eliz@gnu.org>
4260
4261 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4262 attributes are tested _before_ calling verify_row_hash, to protect
4263 against GCC re-ordering of the tests. (Bug#10164)
4264
2b56b87e
JD
42652011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4266
4267 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4268
4269 * xterm.c (handle_one_xevent): Only set async_visible and friends
4270 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4271 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4272 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4273
dbf31225
PE
42742011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4275
4276 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4277 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4278 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4279 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4280 All uses changed to use GCPRO1 etc.
4281 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4282 Revert to old implementation (i.e., before 2011-03-11).
4283
1305621b
YM
42842011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4285
4286 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4287 of scroll runs so as to avoid assigning disabled bogus rows and
4288 unnecessary graphics copy operations.
4289
8c9afb46
EZ
42902011-11-27 Eli Zaretskii <eliz@gnu.org>
4291
4292 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4293 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4294 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4295 (malloc, free, realloc, calloc): Redirect to e_* only when
4296 compiling Emacs.
4297
4298 * lisp.h (GCTYPEBITS): Move before first use.
4299 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4300 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4301 this macro definition.
4302
4303 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4304 _MSC_VER.
4305
54e9e3bf
JD
43062011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4307
6d5eb5b0
SM
4308 * gtkutil.c (xg_create_frame_widgets):
4309 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4310 present with Gtk+ 2.0.
4311
83aca1cb
PE
43122011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4313
4314 * fileio.c (Finsert_file_contents): Undo previous change; see
4315 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4316
5b76caa4
PE
43172011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4318
4319 Rename locals to avoid shadowing.
4320 * fileio.c (Finsert_file_contents):
4321 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4322 * process.c (wait_reading_process_output):
4323 Rename inner 'proc' to 'p' to avoid shadowing.
4324 Indent for consistency with usual Emacs style.
4325
8c535114
EZ
43262011-11-25 Eli Zaretskii <eliz@gnu.org>
4327
4328 * xdisp.c (redisplay_window): If cursor row is not fully visible
4329 after recentering, and scroll-conservatively is set to a large
4330 number, scroll window by a few more lines to make the cursor fully
4331 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4332 (start_display): Don't move to the next line if the display should
4333 start at a newline that is part of a display vector or an overlay
4334 string. (Bug#10119)
8c535114 4335
fa4fdb5c
JL
43362011-11-24 Juri Linkov <juri@jurta.org>
4337
4338 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4339 after the `MagickPingImage' call. (Bug#10112)
4340
90ec88df
CY
43412011-11-23 Chong Yidong <cyd@gnu.org>
4342
4343 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4344
56e2e794
MR
43452011-11-23 Martin Rudalics <rudalics@gmx.at>
4346
4347 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4348 making another buffer current. (Bug#10114)
4349
b6e64c41
GM
43502011-11-23 Glenn Morris <rgm@gnu.org>
4351
4352 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4353
6b21de18
CY
43542011-11-23 Chong Yidong <cyd@gnu.org>
4355
4356 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4357 using it (Bug#5984).
4358
b12cd789
EZ
43592011-11-22 Eli Zaretskii <eliz@gnu.org>
4360
4361 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4362 and header-lines, as they don't have one computed for them.
4363 (Bug#10098)
4364
4365 * .gdbinit (prow): Make displayed values more self-explaining.
4366 Add row's hash code.
4367
261b6fd4
LMI
43682011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4369
4370 * process.c (wait_reading_process_output): Fix asynchrounous
4371 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4372 (wait_reading_process_output): Add comment and URL.
261b6fd4 4373
e7cfd277
JD
43742011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4375
4376 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4377
a9b9b7f5
CY
43782011-11-21 Chong Yidong <cyd@gnu.org>
4379
4380 * window.c (Fnext_window, Fprevious_window): Doc fix.
4381
b0d15b4f
SM
43822011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4383
4384 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4385
fe7a3057
JB
43862011-11-20 Juanma Barranquero <lekktu@gmail.com>
4387
4388 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4389
d2999b1a
MR
43902011-11-20 Martin Rudalics <rudalics@gmx.at>
4391
4392 * window.c (Fset_window_combination_limit): Rename argument
4393 STATUS to LIMIT.
4394 (Vwindow_combination_limit): Remove "status" from doc-string.
4395
d5ff9cd0
AS
43962011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4397
4398 * m/ibms390.h: Remove.
4399 * m/ibms390x.h: Don't include "ibms390.h".
4400
a5bb9bd3
SM
44012011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4402
4403 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4404 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4405
cd1181db
JB
44062011-11-20 Juanma Barranquero <lekktu@gmail.com>
4407
4408 * casetab.c (Fset_case_table):
4409 * charset.c (Fcharset_after): Fix typos.
4410
615a3b8d 44112011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4412
17e845af
PE
4413 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4414 Otherwise, valgrind does not work on some platforms.
4415 Problem reported by Andreas Schwab in
6a0bf43d
PE
4416 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4417 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4418 is set, removing the need for VIRT_ADDRESS_VARIES.
4419 (PURE_P): Use a more-efficient implementation that needs just one
4420 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4421 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4422 to 4 (xorl, subq, cmpq, setbe).
4423 * alloc.c (pure): Always extern now, since that's the
4424 VIRT_ADDR_VARIES behavior.
4425 (PURE_POINTER_P): Use a single comparison, not two, for
4426 consistency with the new puresize.h.
4427 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4428 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4429 Remove VIRT_ADDR_VARIES no longer needed.
4430
f8fe6f96
EZ
44312011-11-19 Eli Zaretskii <eliz@gnu.org>
4432
4433 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4434 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4435 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4436 behave as if the cursor position were at the window margin.
4437
4438 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4439 and the cursor position is out of bounds, behave as if the cursor
4440 position were at the window margin. (Bug#10075)
4441
df05a53c
CY
44422011-11-18 Chong Yidong <cyd@gnu.org>
4443
4444 * window.c (Fwindow_combination_limit): Make first argument
4445 non-optional, since it is meaningless for live windows like the
4446 selected window.
61ccba97 4447
2071918e
DA
44482011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4449
4450 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4451
b50a28de
SM
44522011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4453
4454 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4455 (graft_intervals_into_buffer): Simplify.
4456
015137db
EZ
44572011-11-18 Eli Zaretskii <eliz@gnu.org>
4458
4459 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4460 hash values of the two rows.
4461 (copy_row_except_pointers): Preserve the used[] arrays and the
4462 hash values of the two rows. (Bug#10035)
68c95424 4463 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4464
4465 * xdisp.c (row_hash): New function, body extracted from
4466 compute_line_metrics.
4467 (compute_line_metrics): Call row_hash, instead of computing the
4468 hash code inline.
4469
4470 * dispnew.c (verify_row_hash): Call row_hash for computing the
4471 hash code of a row, instead of duplicating code from xdisp.c.
4472
4473 * dispextern.h (row_hash): Add prototype.
4474
a2addb04
TH
44752011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4476
4477 * frame.c (delete_frame): Don't delete the terminal when the last
4478 X frame is closed if emacs is built with GTK toolkit.
4479
df85d315
JB
44802011-11-17 Juanma Barranquero <lekktu@gmail.com>
4481
4482 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4483
a0c2d0ae
MR
44842011-11-17 Martin Rudalics <rudalics@gmx.at>
4485
4486 * window.c (Vwindow_splits): Rename to
4487 Vwindow_combination_resize. Suggested by Juri Linkov.
4488 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4489 of Vwindow_splits.
4490
58179cce
JB
44912011-11-16 Juanma Barranquero <lekktu@gmail.com>
4492
7877f373
JB
4493 * nsfns.m (Fns_font_name):
4494 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4495
b6f67890
MR
44962011-11-16 Martin Rudalics <rudalics@gmx.at>
4497
4498 * window.h (window): Rename slot "nest" to "combination_limit".
4499 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4500 (Fset_window_nest): Rename to Fset_window_combination_limit.
4501 (Vwindow_nest): Rename to Vwindow_combination_limit.
4502 (recombine_windows, make_parent_window, make_window)
4503 (Fsplit_window_internal, saved_window)
4504 (Fset_window_configuration, save_window_save): Rename all
4505 occurrences of window_nest to window_combination_limit.
4506
c7015153
JB
45072011-11-15 Juanma Barranquero <lekktu@gmail.com>
4508
4509 * image.c (imagemagick_load_image): Fix typo.
4510
322ad6ec
EZ
45112011-11-14 Eli Zaretskii <eliz@gnu.org>
4512
4513 * xdisp.c (display_line): Move the call to
4514 highlight_trailing_whitespace before the call to
4515 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4516 faces of all the glyphs to compute ROW's hash value.
4517 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4518
f067b8ec
JB
45192011-11-14 Juanma Barranquero <lekktu@gmail.com>
4520
4521 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4522 just return (bug#10044).
4523
1e5b2111
EZ
45242011-11-12 Eli Zaretskii <eliz@gnu.org>
4525
7ef3cbd5
EZ
4526 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4527 with user-defined heap size. Bump the default size of the temacs
4528 heap to 27MB, to avoid memory warning when running temacs.
4529 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4530
1e5b2111
EZ
4531 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4532 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4533 (verify_row_hash) [XASSERTS]: New function.
4534 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4535 that the hash value of glyph rows is correct.
1e5b2111 4536
89d61221
MR
45372011-11-12 Martin Rudalics <rudalics@gmx.at>
4538
4539 * window.h (window): Remove splits slot.
4540 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4541 (Fdelete_other_windows_internal, make_parent_window)
4542 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4543 (Fset_window_configuration, save_window_save): Don't deal with
4544 split status of windows.
4545 (saved_window): Remove splits slot.
4546 (Vwindow_splits): Rewrite doc-string.
4547
97f18cc8
JD
45482011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4549
4550 * xfns.c (unwind_create_frame):
4551 * nsfns.m (unwind_create_frame):
4552 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4553 Vframe_list (Bug#9999).
4554
22a648b4
DA
45552011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4556
0b381c7e 4557 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4558
659afede
KH
45592011-11-11 Kenichi Handa <handa@m17n.org>
4560
4561 * callproc.c (Fcall_process): Set the member dst_multibyte of
4562 process_coding.
4563
9ac0394b
KH
45642011-11-11 Johan Bockgård <bojohan@gnu.org>
4565
4566 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4567 avoid a crash (bug#9496).
4568
2fbdc249
CY
45692011-11-09 Chong Yidong <cyd@gnu.org>
4570
4571 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4572 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4573
ac6b1f81
PE
45742011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4575
4576 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4577
09db192c
PE
45782011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4579
4580 Avoid some portability problems by eschewing 'extern inline' functions.
4581 The trivial performance wins aren't worth the portability hassles; see
4582 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4583 et seq.
4584 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4585 (window_box_width, window_box_left, window_box_left_offset)
4586 (window_box_right, window_box_right_offset): Undo previous change,
4587 by removing the "extern"s.
4588 * intervals.c (adjust_intervals_for_insertion)
4589 (adjust_intervals_for_deletion): Undo previous change,
4590 making these static again.
4591 (offset_intervals, temp_set_point_both, temp_set_point)
4592 (copy_intervals_to_string): No longer inline.
4593 * xdisp.c (window_text_bottom_y, window_box_width)
4594 (window_box_height, window_box_left_offset)
4595 (window_box_right_offset, window_box_left, window_box_right)
4596 (window_box): No longer inline.
4597
105216ed
CY
45982011-11-08 Chong Yidong <cyd@gnu.org>
4599
4600 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4601 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4602 Signal an error if not a live window.
105216ed
CY
4603 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4604 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4605
ae9e237f
JB
46062011-11-07 Juanma Barranquero <lekktu@gmail.com>
4607
4608 * lisp.h (syms_of_abbrev): Remove declaration.
4609 Reported by CHENG Gao <chenggao@royau.me>.
4610
c7aa8333
EZ
46112011-11-07 Eli Zaretskii <eliz@gnu.org>
4612
4613 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4614 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4615 of temacs in GUI mode.
4616
be7f5545
MR
46172011-11-07 Martin Rudalics <rudalics@gmx.at>
4618
4619 * window.h: Declare delete_all_child_windows instead of
4620 delete_all_subwindows.
4621 * window.c (Fwindow_nest, Fset_window_nest)
4622 (Fset_window_new_total, Fset_window_new_normal)
4623 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4624 (delete_all_subwindows): Rename to delete_all_child_windows.
4625 (Fdelete_other_windows_internal, Fset_window_configuration):
4626 Call delete_all_child_windows instead of delete_all_subwindows.
4627 * frame.c (delete_frame): Call delete_all_child_windows instead
4628 of delete_all_subwindows.
4629
ca78dc43
PE
46302011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4631
4632 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4633 This is also needed for porting to any host where GC_MARK_STACK is
4634 not GC_MAKE_GCPROS_NOOPS.
4635 (which_symbols): Use it.
4636
a0241d01
KH
46372011-11-07 Kenichi Handa <handa@m17n.org>
4638
4639 * coding.c (coding_set_destination): Check coding->src_pos only
4640 when coding->src_object is a buffer (bug#9910).
4641
4642 * process.c (send_process): Set the member src_multibyte of coding
4643 to 0 (bug#9911) when sending a unibyte text.
4644
4645 * callproc.c (Fcall_process): Set the member src_multibyte of
4646 process_coding to 0 (bug#9912).
4647
a64bfdfa 46482011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4649
4650 * xmenu.c (cleanup_widget_value_tree): New function.
4651 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4652 calling free_menubar_widget_value_tree directly (Bug#9830).
4653
cb41b32a
PE
46542011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4655
4656 Fix some portability problems with 'inline'.
4657 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4658 (window_box_width, window_box_left, window_box_left_offset)
4659 (window_box_right, window_box_right_offset): Declare extern.
4660 Otherwise, these inline functions do not conform to C99 and
4661 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4662 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4663 * intervals.c (adjust_intervals_for_insertion)
4664 (adjust_intervals_for_deletion): Now extern, because otherwise the
4665 extern inline functions 'offset_intervals' couldn't refer to it.
4666 (static_offset_intervals): Remove.
4667 (offset_intervals): Rewrite using the old contents of
4668 static_offset_intervals. The old version didn't conform to C99
4669 because an extern inline function contained a reference to an
4670 identifier with static linkage.
4671
b7041366
AS
46722011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4673
4674 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4675 GC.
4676
88a37c4d
EZ
46772011-11-06 Eli Zaretskii <eliz@gnu.org>
4678
4679 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4680 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4681 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4682 return Qleft_to_right.
4683
49745b39
CY
46842011-11-06 Chong Yidong <cyd@gnu.org>
4685
4686 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4687 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4688 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4689 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4690 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4691 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4692 (Fwindow_vscroll): Doc fix.
4693 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4694 argument, since it makes no sense to pass a live window and for
4695 consistency with window-child.
4696
1f05cd82
CS
46972011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4698
4699 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4700 support MSVC.
4701
22610910
JR
47022011-11-05 Jason Rumney <jasonr@gnu.org>
4703
4704 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4705 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4706 fonts (Bug#6029).
4707 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4708 bitwise arithmetic preventing use of unicode-sip and non-truetype
4709 opentype fonts.
4710
a06776b2
EZ
47112011-11-05 Eli Zaretskii <eliz@gnu.org>
4712
3ad924ba
EZ
4713 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4714 "emacs"-only part.
4715
a06776b2
EZ
4716 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4717 initialization code to keep similarity to xfns.c after changes
4718 from 2011-11-05.
4719
c9e7db78
JD
47202011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4721
a97f8f3f
JD
4722 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4723 (unwind_create_frame): New function (Bug#9943).
4724 (Fx_create_frame): Restructure code to be more similar to the one in
4725 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4726 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4727 Move terminal->reference_count++ just before making the frame official
4728 (Bug#9943).
4729
4730 * nsterm.m (x_free_frame_resources): New function.
4731 (x_destroy_window): Move code to x_free_frame_resources.
4732
c9e7db78 4733 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4734 (Fx_create_frame, x_create_tip_frame):
4735 Move terminal->reference_count++ just before making the frame
75f1671a 4736 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4737 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4738
a6fc3b5c
EZ
47392011-11-05 Eli Zaretskii <eliz@gnu.org>
4740
4741 Support MSVC build with newer versions of Visual Studio.
4742 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4743 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4744 nt/gmake.defs.
4745
4746 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4747 which are not supported by MSVC.
4748 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4749 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4750 bitfields.
4751 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4752 types in bitfields.
4753 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4754
4755 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4756
58179cce 47572011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4758
4759 Support MSVC build with newer versions of Visual Studio.
4760 * w32.c: Don't include w32api.h for MSVC.
4761 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4762
4763 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4764 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4765 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4766 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4767 e_* cousins.
4768 (alloca) [_MSC_VER]: Define to _alloca.
4769
4770 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4771
4772 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4773
a58c13ed
EZ
47742011-11-04 Eli Zaretskii <eliz@gnu.org>
4775
4776 * xdisp.c (note_mouse_highlight): If either of
4777 previous/next-single-property-change returns nil, treat that as
4778 the beginning or the end of the buffer. (Bug#9955)
4779
fe0b6370
JD
47802011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4781
a58c13ed 4782 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4783 label is not null (Bug#9951).
4784 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4785 may be NULL.
4786
89bd5ee1
EZ
47872011-11-04 Eli Zaretskii <eliz@gnu.org>
4788
4789 * window.c (Fwindow_body_size): Mention in the doc string that the
4790 return value is in frame's canonical units. (Bug#9949)
4791
84c3edb9
EZ
47922011-11-03 Eli Zaretskii <eliz@gnu.org>
4793
4e2fb5c7
EZ
4794 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4795
84c3edb9 4796 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4797 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4798 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4799
bc17a887
EZ
48002011-11-01 Eli Zaretskii <eliz@gnu.org>
4801
4802 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4803 Don't stop backward scan on the continuation glyph, even though
4804 its CHARPOS is positive.
6d5eb5b0
SM
4805 (mouse_face_from_buffer_pos, note_mouse_highlight):
4806 Rename cover_string to disp_string.
bc17a887 4807
4ee88440
MR
48082011-11-01 Martin Rudalics <rudalics@gmx.at>
4809
4810 * window.c (temp_output_buffer_show): Don't use
4811 Vtemp_buffer_show_specifiers.
4812 (Vtemp_buffer_show_specifiers): Remove unused variable.
4813
c2ff3c02
EZ
48142011-10-30 Eli Zaretskii <eliz@gnu.org>
4815
4816 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4817 past the beginning of the current glyph matrix.
4818
58179cce 48192011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4820
4821 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4822 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4823 HAVE_GTK3 (Bug#9869).
b77a6a7f 4824
3b574623
JD
4825 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4826 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4827
b77a6a7f
JD
4828 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4829
4830 * xterm.c: Declare x_handle_net_wm_state to return int.
4831 (handle_one_xevent): Check if we are iconified but don't have
4832 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4833 (get_current_wm_state): Return non-zero if not hidden,
4834 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4835 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4836 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4837 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4838
196e41e4
PE
48392011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4840
4841 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4842 so that this new function doesn't get optimized away by a
4843 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4844
021f2e1a
AS
48452011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4846
4847 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4848
8b058d44
EZ
48492011-10-29 Eli Zaretskii <eliz@gnu.org>
4850
4851 Fix the `xbytecode' command.
4852 * .gdbinit (xprintbytestr): New command.
b50a28de 4853 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4854 (xbytecode): Print the byte-code string as well.
4855
4452fb80
EZ
48562011-10-29 Kim Storm <storm@cua.dk>
4857
8b058d44
EZ
4858 * alloc.c (which_symbols): New function.
4859
21b72067
AS
48602011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4861
4862 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4863 line. (Bug#9903)
4864
83ed7b5c
GM
48652011-10-29 Glenn Morris <rgm@gnu.org>
4866
4867 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4868 Not clear what it was for, and it causes various bugs. (Bug#9839)
4869
5a7a728b
EZ
48702011-10-28 Eli Zaretskii <eliz@gnu.org>
4871
4872 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4873 possible random value that matches one of those tested as
4874 condition to clear the mouse face.
4875
d3d0842f
CY
48762011-10-28 Chong Yidong <cyd@gnu.org>
4877
4878 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4879
31b39d13
DN
48802011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4881
4882 * window.c (make_window): Initialize phys_cursor_on_p.
4883
9aba6043
SM
48842011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4885
4886 * lisp.h (struct Lisp_Symbol): Update comments.
4887
c20992f4
JB
48882011-10-28 Juanma Barranquero <lekktu@gmail.com>
4889
4890 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4891
db4f02f2
EZ
48922011-10-28 Eli Zaretskii <eliz@gnu.org>
4893
4894 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4895 <oslsachem@gmail.com> for helping to debug this.
4896
4897 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4898 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4899 (g_b_init_get_glyph_outline_w): New static variables.
4900 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4901 (GetGlyphOutlineW_Proc): New typedefs.
4902 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4903 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4904 New functions.
4905 (w32font_open_internal, compute_metrics):
4906 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4907 instead of calling the "wide" APIs directly.
4908
4909 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4910
4911 * w32.h (syms_of_w32font): Add prototype.
4912
87e68db4
JB
49132011-10-27 Juanma Barranquero <lekktu@gmail.com>
4914
4915 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4916 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4917 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4918 (Fmove_to_window_line): Doc fix.
4919
435c1d67
CY
49202011-10-27 Chong Yidong <cyd@gnu.org>
4921
4922 * process.c (make_process): Set gnutls_state to NULL.
4923
4924 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4925 non-NULL, regardless of GNUTLS_INITSTAGE.
4926 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4927 an error. Set process slots as soon as we allocate them.
4928
4929 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4930
9c6c6f49
CY
49312011-10-27 Chong Yidong <cyd@gnu.org>
4932
9aba6043
SM
4933 * gnutls.c (emacs_gnutls_deinit): New function.
4934 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4935 (Fgnutls_deinit, Fgnutls_boot): Use it.
4936
4937 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4938 (deactivate_process): Call emacs_gnutls_deinit.
4939
657d08d3
JB
49402011-10-27 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * image.c (x_create_x_image_and_pixmap):
4943 * w32.c (sys_rename, w32_delayed_load):
4944 * w32font.c (fill_in_logfont):
4945 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4946
5430d399
JB
49472011-10-26 Juanma Barranquero <lekktu@gmail.com>
4948
4949 * w32fns.c (w32_default_color_map): New function,
4950 extracted from Fw32_default_color_map.
a7ef684b 4951 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4952
fe0055fa
PE
49532011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4954
4955 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4956
e6346438
SM
49572011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4958
4959 * keyboard.c (test_undefined): New function (bug#9751).
4960 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4961
e112cc37
ET
49622011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4963
4964 * sysdep.c (init_sys_modes): Fix the check for the controlling
4965 terminal (Bug#6649).
4966
7b5d6677
EZ
49672011-10-20 Eli Zaretskii <eliz@gnu.org>
4968
4969 * dispextern.h (struct bidi_it): New member next_en_type.
4970
4971 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4972 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4973 current character, check also for next_en_type being WEAK_EN.
4974 (bidi_resolve_weak): Don't enter the expensive loop if the current
4975 position is before next_en_pos. Record the bidi type of the first
4976 non-ET, non-BN character we find, in addition to its position.
4977 (bidi_level_of_next_char): Invalidate next_en_type when
4978 next_en_pos is over-stepped.
4979
7da0b018
PE
49802011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4981
4982 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4983 * editfns.c: Rewrite current-time-zone so that it invokes
4984 the equivalent of (format-time-string "%Z") to get the time zone name.
4985 This fixes a bug when the time zone name contains characters that
4986 need converting from the system time locale to Emacs internal format.
4987 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4988 that patch fixed format-time-string to do the conversion, but
4989 I forgot to fix current-time-zone.
4990 (format_time_string): New function, containing most of
4991 what Fformat_time_string used to contain.
4992 (Fformat_time_string): Rewrite in terms of format_time_string.
4993 This doesn't change this function's behavior.
4994 (current-time-zone): Rewrite to use format_time_string.
4995 This fixes the bug reported by Michael Schierl in
4996 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4997 Jason Rumney's 2007-06-07 change worked around this bug, but
4998 didn't fix it.
4999 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5000
8547b010
EZ
50012011-10-19 Eli Zaretskii <eliz@gnu.org>
5002
5003 * xdisp.c (start_display): If the character at POS is displayed
5004 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5005 (try_window_reusing_current_matrix): If a line ends in a display
5006 vector or the next line starts in a display vector, continue
5007 redrawing the window even though the character position of
5008 start_row was reached.
8547b010
EZ
5009 (Bug#9771, part 2)
5010
4e948d15
CY
50112011-10-18 Chong Yidong <cyd@gnu.org>
5012
5013 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5014 with nobreak-char-display too.
5015
4787455f
EZ
50162011-10-18 Eli Zaretskii <eliz@gnu.org>
5017
5018 Fix part 3 of bug#9771.
5019 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5020 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5021 non-neutral characters if the current character is a paragraph
5022 separator (a.k.a. Newline). This avoids running the same
5023 expensive loop twice, once when we consume the preceding newline
5024 and the other time when the line actually needs to be displayed.
5025 Avoid the loop when we see neutrals on the base embedding level
5026 following a character whose directionality is the same as the
5027 paragraph's. This avoids running the expensive loop when a line
5028 ends in a long sequence of neutrals, like control characters.
5029 Add assertion against STRONG_AL type. Slightly rearrange code
5030 that determines the type of a neutral given the first non-neutral
5031 that follows it.
5032 (bidi_level_of_next_char): Set next_en_pos to zero when
5033 invalidating its info.
5034
2c91f553
EZ
50352011-10-17 Eli Zaretskii <eliz@gnu.org>
5036
5037 * xdisp.c (push_display_prop): Determine whether to record string
5038 or buffer position by IT->string, not by IT->method. Allow
5039 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5040 (move_it_vertically_backward): Don't look for character position
5041 immediately after the newline when in a continuation line.
5042 (Bug#9771, part 1)
2c91f553 5043
c7b08b0d
MR
50442011-10-15 Martin Rudalics <rudalics@gmx.at>
5045
5046 * window.c (coordinates_in_window): Rewrite and delabelize
5047 vertical border check. (Bug#5357) (Bug#9618)
5048
6b02f655
SM
50492011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5050
5051 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5052 errors in XSetWindowBorder (bug#9310).
5053
81d40c92
DA
50542011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5055
5056 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5057 avoid crash when xmalloc overrun checking is enabled.
5058
d4172c3b
EZ
50592011-10-13 Eli Zaretskii <eliz@gnu.org>
5060
5061 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5062 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5063 cursor motion with <left> and <right> arrow keys.
5064
5065 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5066 some callers set that themselves.
5067
b00eea75
EZ
50682011-10-12 Eli Zaretskii <eliz@gnu.org>
5069
5070 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5071 display string and the previous row comes from the same string and
5072 is empty. (Bug#9739) (Bug#9738)
5073
8fe012c4
SM
50742011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5075
5076 * doc.c (get_doc_string): Encode file name (bug#9735).
5077
0074aef2
EZ
50782011-10-12 Eli Zaretskii <eliz@gnu.org>
5079
79beb178
EZ
5080 * bidi.c (bidi_level_of_next_char):
5081 * xdisp.c (get_visually_first_element): Remove old incorrect
5082 comments regarding the Unicode Line Separator character.
5083
0074aef2
EZ
5084 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5085
6e4b3fbe
DA
50862011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5087
5088 * alloc.c (Fgc_status): Do not access beyond zombies array
5089 boundary if nzombies > MAX_ZOMBIES.
5090 * alloc.c (dump_zombies): Add missing format specifier.
5091
0324f3af
PE
50922011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5093
b5525cac
PE
5094 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5095 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5096
0324f3af
PE
5097 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5098 Some packages use them to denote characters with modifiers.
5099
e9b5f888
AS
51002011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5101
5102 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5103 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5104 matching a pp-number. Rename parameter var to var1.
5105
127827c0
SM
51062011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5107
5108 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5109
c8fd3bd0
GM
51102011-10-08 Glenn Morris <rgm@gnu.org>
5111
5112 * callint.c (Fcall_interactively): Give a more explicit error for the
5113 'c' case with a non-character input. (Bug#8479)
5114
352ec8ff
EZ
51152011-10-08 Eli Zaretskii <eliz@gnu.org>
5116
03669ccb
EZ
5117 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5118 lines.
7061c986
EZ
5119 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5120 lines that are hscrolled on the left.
03669ccb 5121
352ec8ff
EZ
5122 * dispnew.c (buffer_posn_from_coords): Account for a possible
5123 presence of header-line. (Bug#4426)
5124
a66cfb1c
SM
51252011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5126
6b02f655
SM
5127 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5128 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5129
7c5ee88e
PE
51302011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5131
5132 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5133 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5134 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5135 this makes Emacs dump core during garbage collection on rare
5136 occasions. sizeof is obviously inferior to offsetof here, so
5137 stick with offsetof.
5138 (GC_POINTER_ALIGNMENT): New macro.
5139 (mark_memory): Omit 3rd (offset) arg; caller changed.
5140 Don't assume EMACS_INT alignment is the same as pointer alignment.
5141
df1bbe5b
SM
51422011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5143
5144 * keyboard.c (read_key_sequence_remapped): New var.
5145 (read_key_sequence): Compute remapping in the right buffer.
5146 (command_loop_1): Use read_key_sequence's remapping directly.
5147
51553db6
SM
51482011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5149
32c1fffd
SM
5150 * dired.c (file_name_completion): Don't expand file name.
5151 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5152 before checking file name handler.
5153
51553db6
SM
5154 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5155 they've been requested explicitly (bug#9591).
5156
b6bd1599 51572011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5158
5159 * keymap.c (Fsingle_key_description): Use make_specified_string
5160 instead of build_string to build string from push_key_description.
5161 (Bug#5193)
5162
f701dc2a
PE
51632011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5164
4222c55d
PE
5165 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5166 This fixes a Y2038 bug on 64-bit hosts.
5167 * buffer.c (reset_buffer):
5168 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5169 (Fclear_buffer_auto_save_failure):
5170 Use 0, not -1, to represent an unset failure time, since time_t
5171 might not be signed.
5172
f701dc2a
PE
5173 Remove dependency on glibc malloc internals.
5174 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5175 Move back here from lisp.h, but with their new implementations.
5176 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5177 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5178 * charset.c (charset_table_init): New static var.
5179 (syms_of_charset): Use it instead of xmalloc. This removes a
5180 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5181 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5182 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5183 Move back to alloc.c.
5184 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5185 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5186
9ceebf39
JD
51872011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5188
5189 * nsterm.m (windowDidResize): Call x_set_window_size only when
5190 ns_in_resize is true. Otherwise set pixelwidth/height and
5191 call change_frame_size (Bug#9628).
5192
cb993c58
PE
51932011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5194
3930c88b
PE
5195 Port --enable-checking=all to Fedora 14 x86-64.
5196 * charset.c (syms_of_charset): Also account for glibc malloc's
5197 internal overhead when calculating the initial malloc maximum.
5198
cb993c58
PE
5199 Port --enable-checking=all to Fedora 14 x86.
5200 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5201 Move to lisp.h.
5202 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5203 (overrun_check_realloc, overrun_check_free):
5204 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5205 That way, xmalloc returns a properly-aligned pointer even if
5206 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5207 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5208 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5209 into account when calculating the initial malloc maximum.
5210 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5211 Move here from alloc.c, so that charset.c can use it too.
5212 Properly align; the old code wasn't right for common 32-bit hosts
5213 when configured with --enable-checking=all.
5214 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5215 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5216
31bed486
EZ
52172011-09-29 Eli Zaretskii <eliz@gnu.org>
5218
04c70788 5219 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5220 use EDOM.
5221
fbcaa2f3
EZ
52222011-09-28 Eli Zaretskii <eliz@gnu.org>
5223
5224 * xdisp.c (compute_display_string_end): If there's no display
5225 string at CHARPOS, return -1.
5226
5227 * bidi.c (bidi_fetch_char): When compute_display_string_end
5228 returns a negative value, treat the character as a normal
5229 character not covered by a display string. (Bug#9624)
5230
a239d4e9
JB
52312011-09-28 Juanma Barranquero <lekktu@gmail.com>
5232
5233 * lread.c (Fread_from_string): Fix typo in docstring.
5234
88652fd5
EZ
52352011-09-27 Eli Zaretskii <eliz@gnu.org>
5236
5237 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5238 newline, reseat the iterator instead of bidi-iterating there one
5239 character at a time. (Bug#9610)
32c1fffd
SM
5240 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5241 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5242
ed497dd4
AS
52432011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5244
5245 * lread.c (readevalloop): Use correct code for NBSP.
5246 (read1): Likewise. (Bug#9608)
5247
b2bf61aa
MA
52482011-09-25 Michael Albinus <michael.albinus@gmx.de>
5249
5250 * dbusbind.c (Fdbus_register_signal): When service is not
5251 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5252
32bbb17c
GM
52532011-09-25 Glenn Morris <rgm@gnu.org>
5254
5255 * buffer.c (truncate-lines): Doc fix.
5256
94e0933e
CY
52572011-09-24 Chong Yidong <cyd@stupidchicken.com>
5258
5259 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5260 (Fset_window_next_buffers): Doc fix.
5261
cddde921
GM
52622011-09-24 Glenn Morris <rgm@gnu.org>
5263
5264 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5265
1260aef1
PE
52662011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5267
25b4bfa0
PE
5268 Fix minor problems found by static checking.
5269 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5270 * indent.c (Fvertical_motion): Fix == vs = typo.
5271
e3cbd34b
EZ
52722011-09-24 Eli Zaretskii <eliz@gnu.org>
5273
a66cfb1c
SM
5274 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5275 Default value is now t. Doc fix.
6bf7006f 5276
e3cbd34b 5277 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5278 logic when moving up, not only when moving down. Fix the
e3cbd34b 5279 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5280 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5281
5282 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5283 CHARPOS is covered by a display string which includes newlines.
5284 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5285 is covered by a display string with embedded newlines.
5286
a3de0cbd
MA
52872011-09-24 Michael Albinus <michael.albinus@gmx.de>
5288
5289 * dbusbind.c (Fdbus_register_signal): Add match rule to
5290 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5291 (Fdbus_register_method, Vdbus_registered_objects_table):
5292 Fix docstring.
a3de0cbd 5293
b260039d
JM
52942011-09-24 Jim Meyering <meyering@redhat.com>
5295
32c1fffd 5296 do not ignore write error for any output size
b260039d
JM
5297 The previous change was incomplete.
5298 While it makes emacs --batch detect the vast majority of stdout
5299 write failures, errors were still ignored whenever the output size is
5300 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5301 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5302 && echo FAIL: ignored write error
5303 FAIL: ignored write error
5304 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5305 && echo FAIL: ignored write error
5306 FAIL: ignored write error
5307 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5308
8eca8a7c
AS
53092011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5310
5311 * emacs.c (Fkill_emacs): In noninteractive mode exit
5312 non-successfully if a write error occurred on stdout. (Bug#9574)
5313
3341db62
EZ
53142011-09-21 Eli Zaretskii <eliz@gnu.org>
5315
5316 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5317 the xassert test.
5318
5319 * dispextern.h (struct it): Update the comment documenting what
5320 can it->OBJECT be.
5321
8c203dbf
EZ
53222011-09-20 Eli Zaretskii <eliz@gnu.org>
5323
5324 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5325 a display string, extend search for cursor position to end of row.
5326 (find_row_edges): If the row ends in a newline from a display
5327 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5328 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5329 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5330 non-empty line. Fixes confusing cursor motion with arrow keys at
5331 the beginning of a line that starts with whitespace.
8c203dbf 5332
a4824228
LMI
53332011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5334
5335 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5336 (bug#9493).
5337
33ed493b
CY
53382011-09-18 Chong Yidong <cyd@stupidchicken.com>
5339
5340 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5341 boolean (Bug#9154).
5342
56cd55c8
EZ
53432011-09-18 Eli Zaretskii <eliz@gnu.org>
5344
5345 * xdisp.c (display_line): Record maximum and minimum buffer
5346 positions even if no glyphs were produced (e.g., by a zero-width
5347 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5348 buffer positions that will be removed from the glyph row because
5349 they don't fit.
c02dcedf
EZ
5350 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5351 column is beyond frame width: don't subtract 1 "pixel" when
5352 computing width of the stretch.
3e62b7e0
EZ
5353 (reseat_at_next_visible_line_start): Undo the change made on
5354 2011-09-17 that saved paragraph information and restored it after
5355 the call to `reseat'. (Bug#9545)
56cd55c8 5356
5ed99d36 53572011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5358
5359 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5360 and turn window cursor on if cleared (Bug#9415).
5361
5ed99d36 53622011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5363
5364 * search.c (boyer_moore): Take unibyte characters from pattern
5365 literally. (Bug#9458)
5366
9bade7b2
EZ
53672011-09-18 Eli Zaretskii <eliz@gnu.org>
5368
5369 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5370
e5e9d610
PE
53712011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5372
87e4427a
PE
5373 Fix minor problem found by static checking.
5374 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5375 initialized, to pacify gcc -Wuninitialized.
5376
e5e9d610
PE
5377 * fileio.c: Report proper errno when syscall falls.
5378 (Finsert_file_contents): Save and restore errno,
5379 so that report_file_error outputs the correct diagnostic.
5380 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5381
a1674f0b
EZ
53822011-09-18 Eli Zaretskii <eliz@gnu.org>
5383
5384 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5385
fbfb6dd4
EZ
53862011-09-17 Eli Zaretskii <eliz@gnu.org>
5387
5388 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5389 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5390
bb187662
EZ
53912011-09-17 Eli Zaretskii <eliz@gnu.org>
5392
1137e8b8 5393 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5394 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5395
5396 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5397 (bidi_find_paragraph_start): Search back for paragraph beginning
5398 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5399 (bidi_move_to_visually_next): Only trigger paragraph-related
5400 computations when the last character is a newline or at EOB, not
5401 just any NEUTRAL_B. (Bug#9470)
5402
bb187662
EZ
5403 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5404 truncated lines if point is covered by a display string. (Bug#9524)
5405
2e621251
PE
54062011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5407
5408 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5409 (cons_to_x_long): New function.
5410 (lisp_data_to_selection_data): Use it. Correct the test for
5411 short-versus-long data; it was negated. Break out of vector
5412 loop, for efficiency, when a long datum is discovered.
5413
91a15bc6
SM
54142011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5415
5416 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5417
b41c3a35
EZ
54182011-09-16 Eli Zaretskii <eliz@gnu.org>
5419
5420 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5421 GCC PR/17406) by declaring this function with external scope.
5422
7812ba2d
PE
54232011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5424
5425 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5426 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5427
cf7edc2a
AS
54282011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5429
5430 * editfns.c (Fformat): Correctly handle text properties on "%%".
5431
bd01620e
EZ
54322011-09-15 Eli Zaretskii <eliz@gnu.org>
5433
5434 * xterm.c (x_draw_composite_glyph_string_foreground):
5435 * w32term.c (x_draw_composite_glyph_string_foreground):
5436 * term.c (encode_terminal_code):
5437 * composite.c (composition_update_it, get_composition_id):
5438 * xdisp.c (get_next_display_element)
5439 (fill_composite_glyph_string): Add comments about special meaning
5440 of TAB characters in a composition.
5441
a02719a3
PE
54422011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5443
5444 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5445 This occurs when processing a multibyte format.
5446 Problem reported by Wolfgang Jenker.
a02719a3 5447
72589a3c
JB
54482011-09-15 Johan Bockgård <bojohan@gnu.org>
5449
5450 * xdisp.c (try_cursor_movement): Only check for exact match if
5451 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5452
1c14176c
PE
54532011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5454
5455 Remove unused external symbols.
5456 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5457 * xdisp.c (calc_pixel_width_or_height): Now static.
5458 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5459 * indent.c (check_display_width):
5460 * w32term.c: Fix comment to match code.
5461 * xterm.c, xterm.h (x_catching_errors): Remove.
5462
d2eea5b5
PE
54632011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5464
5465 * xselect.c: Use signed conversions more consistently (Bug#9498).
5466 (selection_data_to_lisp_data): Assume incoming selection data are
5467 signed integers, not unsigned. This is to be consistent with
5468 outgoing selection data, which was modified to use signed integers
5469 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5470 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5471 expects long, not unsigned long.
5472
46888499
EZ
54732011-09-14 Eli Zaretskii <eliz@gnu.org>
5474
5475 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5476 computation of loop end. Reported by Johan Bockgård
5477 <bojohan@gnu.org>.
5478
ef8ef9fb
CY
54792011-09-13 Chong Yidong <cyd@stupidchicken.com>
5480
5481 * frame.c (Fother_visible_frames_p): Function deleted.
5482
fa819fed
EZ
54832011-09-12 Eli Zaretskii <eliz@gnu.org>
5484
5485 * indent.c (compute_motion): Process display vector front to back
5486 rather than the other way around. (Bug#2496)
5487
2ba8e008
SM
54882011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5489
5490 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5491
20f53c69
CY
54922011-09-11 Chong Yidong <cyd@stupidchicken.com>
5493
5494 * minibuf.c (Fread_from_minibuffer): Doc fix.
5495
d562d7a4
EZ
54962011-09-11 Eli Zaretskii <eliz@gnu.org>
5497
5498 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5499 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5500
1c4d7f3d
LMI
55012011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5502
5503 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5504 value for non-existent files.
5505
b885bf36
EZ
55062011-09-11 Eli Zaretskii <eliz@gnu.org>
5507
5508 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5509 set its "size" to -1. This will set the modtime_size field of
5510 the corresponding buffer to -1, which is what
5511 verify-visited-file-modtime expects for files that do not exist.
5512 (Bug#9139)
5513
6612f0bf
PE
55142011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5515
5516 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5517 here ...
5518 * lisp.h: ... from here. push_key_description is no longer
5519 defined in keyboard.c, so its declaration should not be in
5520 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5521 logically belongs with push_key_description.
5522
dfb3f755
PE
55232011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5524
5525 * buffer.h: Include <sys/types.h> instead of <time.h>.
5526 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5527 Problem reported by Herbert J. Skuhra.
5528
3134906c
LMI
55292011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5530
5531 * xml.c (parse_region): Make the parsing work for
5532 non-comment-starting XML files again (bug#9144).
5533
8d903f4e
AS
55342011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5535
5536 * image.c (gif_load): Fix calculation of bottom and right corner.
5537 (Bug#9468)
5538
80ad64f4
EZ
55392011-09-10 Eli Zaretskii <eliz@gnu.org>
5540
5541 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5542 redisplay in small windows.
5543
208a048d
EZ
55442011-09-09 Eli Zaretskii <eliz@gnu.org>
5545
5546 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5547
9b1c252e
MR
55482011-09-08 Martin Rudalics <rudalics@gmx.at>
5549
5550 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5551 Operate on live windows only.
5552
2949f33b
JB
55532011-09-08 Juanma Barranquero <lekktu@gmail.com>
5554
5555 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5556
e08dcafd
EZ
55572011-09-07 Eli Zaretskii <eliz@gnu.org>
5558
5559 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5560 only under bidi iteration.
5561
115b96bd
JD
55622011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5563
5564 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5565
c8199d0f
PE
55662011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5567
5568 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5569 Without this fix, the command to link temacs failed due to an
5570 undefined symbol __builtin_isnan. This is because
5571 /usr/include/iso/math_c99.h #defines isnan(x) to
5572 __builtin_isnan(x), but the bundled gcc, which identifies itself
5573 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5574 a __builtin_isnan.
5575 * floatfns.c (isnan): #undef, and then #define to a clone of
5576 what's in data.c.
5577 (Fisnan): Always define, since it's always available now.
5578 (syms_of_floatfns): Always define isnan at the Lisp level.
5579
e39b275c 55802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5581
5582 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5583
b2db44d9 55842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5585
f4af5137 5586 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5587 The previous code assumed that file offsets (off_t values) fit in
5588 EMACS_INT variables, which is not true on typical 32-bit hosts.
5589 The code messed up by falsely reporting buffer overflow in cases
5590 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5591 when "big" contains more than 2**29 bytes, even though this
5592 inserts just one byte and does not overflow the buffer.
5593 (Finsert_file_contents): Store file offsets as off_t
5594 values, not as EMACS_INT values. Check for overflow when
5595 converting between EMACS_INT and off_t. When checking for
5596 buffer overflow or for overlap, take the offsets into account.
5597 Don't use EMACS_INT for small values where int suffices.
5598 When checking for overlap, fix a typo: ZV was used where
5599 ZV_BYTE was intended.
5600 (Fwrite_region): Don't assume off_t fits into 'long'.
5601 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5602
ecfc0a49
MA
56032011-09-05 Michael Albinus <michael.albinus@gmx.de>
5604
5605 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5606
6511acf2 56072011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5608
0999621a 5609 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5610
5611 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5612 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5613 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5614 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5615 (modify_event_symbol): Do not assume that the length of
5616 name_alist_or_stem is safe to alloca and fits in int.
5617 (Fexecute_extended_command): Likewise for function name and binding.
5618 (Frecursion_depth): Wrap around reliably on integer overflow.
5619 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5620 since some callers pass EMACS_INT values.
5621 (Fsingle_key_description): Don't crash if symbol name contains more
5622 than MAX_ALLOCA bytes.
5623 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5624 (get_minibuffer): Arg is now EMACS_INT, not int.
5625 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5626 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5627 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5628
2be7d702
PE
5629 * dbusbind.c (signature_cat): New function.
5630 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5631 Do not overrun buffer; instead, report string overflow.
5632
9d1df220
PE
5633 * dispnew.c (add_window_display_history): Don't overrun buffer.
5634 Truncate instead; this is OK since it's just a log.
5635
33ef5c64
PE
5636 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5637 even if the time zone offset is outlandishly large.
5638 Don't mishandle offset == INT_MIN.
5639
66c6fdd5
PE
5640 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5641 when creating daemon; the previous buffer-overflow check was incorrect.
5642
d749b01b
PE
5643 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5644 which has the guts of the old verror function.
5645
b5cd1905
PE
5646 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5647 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5648
6e1a67fb
PE
5649 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5650 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5651 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5652 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5653 length of string rather than counting it via multiple sprintfs;
5654 that's simpler and more reliable.
c21721cc
PE
5655 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5656 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5657 sprintf, in case result does not fit in int.
5658
c57b67fc
PE
5659 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5660 (fontset_from_font): Print it.
5661
8a401434
PE
5662 * frame.c (tty_frame_count): Now printmax_t, not int.
5663 (make_terminal_frame, set_term_frame_name): Print it.
5664 (x_report_frame_params): In X, window IDs are unsigned long,
5665 not signed long, so print them as unsigned.
5666 (validate_x_resource_name): Check for implausibly long names,
5667 and don't assume name length fits in 'int'.
5668 (x_get_resource_string): Don't blindly alloca invocation name;
5669 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5670 not fit in int.
5671
6e1a67fb
PE
5672 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5673 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5674 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5675
0df02bf3
PE
5676 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5677 Use esprintf, not sprintf, in case result does not fit in int.
5678
48e30793
PE
5679 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5680 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5681 it as a large positive number.
5682 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5683 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5684
a66ff6d8
PE
5685 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5686 in case result does not fit in int.
5687
aca216ff
PE
5688 * print.c (float_to_string): Detect width overflow more reliably.
5689 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5690 buffer overrun. Don't assume list length fits in 'int'. Treat
5691 print length of 0 as 0, not as infinity; to be consistent with other
5692 uses of print length in this function. Don't overflow print length
5693 index. Don't assume hash table size fits in 'long', or that
5694 vectorlike size fits in 'unsigned long'.
5695
31c286f7
PE
5696 * process.c (make_process): Use printmax_t, not int, to format
5697 process-name gensyms.
5698
55e5faa1
PE
5699 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5700
80f2e268
PE
5701 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5702 to avoid potential buffer overrun.
5703
670741ab
PE
5704 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5705 if X resource line is longer than 512 bytes.
5706
b7163a50
PE
5707 * xfns.c (x_window): Make sprintf buffer a bit bigger
5708 to avoid potential buffer overrun.
5709
ae58ff1f
PE
5710 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5711
c43c8a6a
PE
5712 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5713
3f8236f4
PE
57142011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5715
53e9fe90 5716 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5717 Without these, Emacs silently mishandles large integers sometimes.
5718 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5719 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5720
6511acf2
PE
5721 * xdisp.c (try_window_id): Check Emacs fixnum range before
5722 converting to 'int'.
806add1d 5723
6511acf2 5724 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5725 Check that an Emacs fixnum is in range before assigning it to 'int'.
5726 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5727 values converted from Emacs fixnums.
5728 (Frecenter): Don't wrap around a line count if it is out of 'int'
5729 range; instead, treat it as an extreme value.
5730 (Fset_window_configuration, compare_window_configurations):
5731 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5732
6511acf2
PE
5733 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5734 that can exceed INT_MAX. Check that EMACS_INT value is in range
5735 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5736 (match_limit): Don't assume that a fixnum can fit in 'int'.
5737
6511acf2 5738 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5739 exceed INT_MAX.
5740
6511acf2 5741 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5742 (Fvertical_motion): Don't wrap around LINES values that don't fit
5743 in 'int'. Instead, treat them as extreme values. This is good
5744 enough for windows, which can't have more than INT_MAX lines anyway.
5745
fcb901a7
LMI
57462011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5747
0f2f6b6d
LMI
5748 * Require libxml/parser.h to avoid compilation warning.
5749
fcb901a7
LMI
5750 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5751
5752 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5753 since this reportedly can destroy thread storage.
5754
6e20a0d4
CY
57552011-08-30 Chong Yidong <cyd@stupidchicken.com>
5756
5757 * syntax.c (find_defun_start): Update all cache variables if
5758 exiting early (Bug#9401).
5759
148ae00e
EZ
57602011-08-30 Eli Zaretskii <eliz@gnu.org>
5761
f6cfbd8f
EZ
5762 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5763
148ae00e
EZ
5764 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5765 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5766 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5767
5768 * term.c (tty_append_glyph): New function.
5769 (produce_stretch_glyph): Static function and its prototype deleted.
5770
a66cfb1c
SM
5771 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5772 Add prototypes.
148ae00e 5773
c4a07a4c
PE
57742011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5775
5776 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5777 when checking :margin (Bug#9390).
5778 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5779 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5780 so that the name doesn't mislead. All uses changed.
5781
6bc8cd65
JB
57822011-08-28 Johan Bockgård <bojohan@gnu.org>
5783
5784 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5785 set_tty_hooks.
5786
dca4927e
EZ
57872011-08-27 Eli Zaretskii <eliz@gnu.org>
5788
5789 * xdisp.c (move_it_to): Don't bail out early when reaching
5790 position beyond to_charpos, if we are scanning backwards.
5791 (move_it_vertically_backward): When DY == 0, make sure we get to
5792 the first character in the line after the newline.
5793
f2cad773
PE
57942011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5795
5796 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5797 (ccl_driver): Do not generate an out-of-range pointer.
5798 (Fccl_execute_on_string): Remove unnecessary check for
5799 integer overflow, noted by Stefan Monnier in
5800 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5801 Remove a FIXME that didn't need fixing.
5802 Simplify the newly-introduced buffer reallocation code.
5803
0cae2cdb
JB
58042011-08-27 Juanma Barranquero <lekktu@gmail.com>
5805
5806 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5807
5fc295a4 58082011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5809
70c60eb2 5810 Integer and memory overflow issues (Bug#9196).
726e0ab1 5811
d31850da
PE
5812 * doc.c (get_doc_string): Rework so that
5813 get_doc_string_buffer_size is the actual buffer size, rather than
5814 being 1 less than the actual buffer size; this makes xpalloc more
5815 convenient.
5816
a69fbedb
PE
5817 * image.c (x_allocate_bitmap_record, cache_image):
5818 * xselect.c (Fx_register_dnd_atom):
5819 Simplify previous changes by using xpalloc.
5820
fe5c5d37
PE
5821 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5822 since either will do and ptrdiff_t is convenient with xpalloc.
5823
0065d054
PE
5824 * charset.c (charset_table_size)
5825 (struct charset_sort_data.priority): Now ptrdiff_t.
5826 (charset_compare): Don't overflow if priorities differ greatly.
5827 (Fsort_charsets): Don't assume list length fits in int.
5828 Check for size-calculation overflow when allocating sort data.
5829 (syms_of_charset): Allocate an initial charset table that is
5830 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5831
5832 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5833
5834 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5835 The actual value is always <= INT_MAX, and leaving it unsigned made
5836 overflow checking harder.
5837
5838 * dispextern.h (struct glyph_matrix.rows_allocated)
5839 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5840 with xpalloc. The values are still always <= INT_MAX.
5841
5842 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5843
5844 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5845 (SAFE_NALLOCA): New macro.
5846
5847 * region-cache.c (struct boundary.pos, find_cache_boundary)
5848 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5849 (set_cache_region, invalidate_region_cache)
5850 (revalidate_region_cache, know_region_cache, region_cache_forward)
5851 (region_cache_backward, pp_cache):
5852 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5853 so that ptrdiff_t * can be passed to xpalloc.
5854 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5855 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5856 (pp_cache): Don't assume cache_len fits in int.
5857 * region-cache.h: Adjust extern decls to match.
5858
5859 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5860 EMACS_INT, since either will do, for xpalloc.
5861
5862 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5863 (xnmalloc, xnrealloc, xpalloc): New functions.
5864
726e0ab1
PE
5865 * bidi.c (bidi_shelve_header_size): New constant.
5866 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5867 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5868
51f30bc5 5869 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5870 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5871 (overlay_strings):
5872 Don't update size of array until after memory allocation succeeds,
5873 because xmalloc/xrealloc may not return.
0065d054
PE
5874 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5875 now that we have proper integer overflow checking.
5876 (record_overlay_string, overlay_strings): Catch overflows when
5877 calculating size of overlay_str_buf.
726e0ab1 5878
0065d054
PE
5879 * callproc.c (Fcall_process): Check for size overflow when
5880 calculating size of args2.
5881 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5882 Normally we prefer signed values, but sticking with ptrdiff_t would
5883 require adding more-complicated checks.
726e0ab1
PE
5884
5885 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5886 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5887 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5888 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5889
5890 * character.c (Fstring): Check for size-calculation overflow.
5891
5892 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5893 unnecessary integer overflow. Check for size overflow.
5894 (encode_coding_object): Don't update size until xmalloc succeeds.
5895
5896 * composite.c (get_composition_id): Check for overflow in glyph
5897 length calculations.
5898
5899 Integer and memory overflow fixes for display code.
5900 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5901 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5902 (scrolling_window): Check for overflow in size calculations.
5903 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5904 Don't assume glyph table len fits in int.
5905 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5906 (row_table_size): Now ptrdiff_t, not int.
5907 (scrolling_window): Avoid overflow in size calculations.
5908 Don't update size until allocation succeeds.
5909 * fns.c (concat): Check for overflow in size calculations.
5910 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5911 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5912 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5913
5914 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5915 (get_doc_string): Check for size calculation overflow.
5916 Don't update size until allocation succeeds.
5917 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5918 EMACS_INT, where ptrdiff_t will do.
5919 (Fsubstitute_command_keys): Check for string overflow.
5920
5921 * editfns.c (set_time_zone_rule): Don't assume environment length
5922 fits in int.
5923 (message_length): Now ptrdiff_t, not int.
5924 (Fmessage_box): Don't update size until allocation succeeds.
5925 Don't assume message length fits in int.
5926 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5927
0065d054
PE
5928 * emacs.c (main): Do not reallocate argv, since there is a null at
5929 the end that can be overwritten, and this way there's no need to
5930 worry about size-calculation overflow.
5931 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5932
5933 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5934 alloc succeeds.
5935 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5936
5937 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5938 (x_set_scroll_bar_width, x_figure_window_size):
5939 Check for integer overflow.
5940 (x_set_alpha): Do not assume XINT fits in int.
5941
5942 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5943 This is for the members text_lines, text_cols, total_lines, total_cols,
5944 where the system imposes an 'int' limit.
5945
5946 * fringe.c (Fdefine_fringe_bitmap):
5947 Don't update size until alloc works.
5948
5949 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5950 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5951
5952 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5953 Check for size-calculation overflow.
5954 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5955 do, as we prefer signed integers.
5956 (id_to_widget.max_size, id_to_widget.used)
5957 (xg_store_widget_in_map, xg_remove_widget_from_map)
5958 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5959 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5960 Use and return ptrdiff_t, not int.
5961 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5962 * gtkutil.h: Change prototypes to match the above.
5963
5964 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5965 are duplicate now that they've been promoted to lisp.h.
5966 (x_allocate_bitmap_record, x_alloc_image_color)
5967 (make_image_cache, cache_image, xpm_load):
5968 Don't update size until alloc is done.
5969 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5970 (x_detect_edges):
3256efce 5971 Check for size calculation overflow.
726e0ab1
PE
5972 (ct_colors_allocated_max): New constant.
5973 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5974 overflow.
3256efce 5975
726e0ab1
PE
5976 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5977 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5978 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5979 Use ptrdiff_t, not int, to count maps.
5980 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5981 calculations. Don't update size until allocation succeeds.
5982 Redo calculations to avoid overflow.
726e0ab1
PE
5983 * keyboard.h: Change prototypes to match the above.
5984
5985 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5986 to count maps.
5987 (current_minor_maps): Check for size calculation overflow.
5988 * keymap.h: Change prototypes to match the above.
5989
5990 * lread.c (read1, init_obarray): Don't update size until alloc done.
5991
5992 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5993 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5994
726e0ab1
PE
5995 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5996 Now ptrdiff_t, not int.
5997 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5998 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5999
6000 * process.c (Fnetwork_interface_list): Check for overflow
6001 in size calculation.
6002
6003 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6004
6005 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6006 overflow. Don't bother calling xmalloc when xrealloc will do.
6007
6008 * search.c (Freplace_match): Check for size calculation overflow.
6009 (Fset_match_data): Don't assume list lengths fit in 'int'.
6010
6011 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6012 for command line length. Do not attempt to address one before the
6013 beginning of an array, as that's not portable.
6014
6015 * term.c (max_frame_lines): Remove; unused.
6016 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6017 not int.
6018 (encode_terminal_code, calculate_costs): Check for size
6019 calculation overflow.
6020 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6021 table lengths and related sizes. Don't update size until alloc
6022 done. Redo calculations to avoid overflow.
6023 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6024
6025 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6026 subtracting pointers.
6027 (gobble_line): Check for overflow more carefully. Don't update size
6028 until alloc done.
6029
6030 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6031 Don't update size until alloc done.
6032 Redo size calculations to avoid overflow.
6033 Check for size calculation overflow.
0065d054 6034 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6035
6036 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6037 Use ptrdiff_t, not int, for sizes.
6038 (store_mode_line_noprop_char): Don't update size until alloc done.
6039
0065d054
PE
6040 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6041 Use ptrdiff_t, not int, for sizes.
6042 (Finternal_make_lisp_face, cache_face):
6043 Check for size calculation overflow.
6044 (cache_face): Treat size calculation overflows as if they were
6045 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6046
6047 * xfns.c (x_encode_text, x_set_name_internal)
6048 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6049 sizes, since they can exceed INT_MAX in size. Check for size
6050 calculation overflow.
6051
0065d054
PE
6052 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6053 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6054 Don't update size until alloc done.
6055
0065d054 6056 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6057 as sprintf is limited to int lengths.
1d526e2f 6058
252c5ee1
PE
6059 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6060 (X_LONG_MIN): New macros.
864d7ce7
PE
6061 Use them to make the following changes clearer.
6062 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6063 This change doesn't affect the value now, but it may help remind
6064 future maintainers not to raise the value too much later.
6065 (SELECTION_QUANTUM): Remove, replacing with ...
6066 (selection_quantum): ... new function, which avoids overflow.
6067 All uses changed.
6068 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6069 assumption that selection length fits in 'int'.
6070 (x_reply_selection_request, x_handle_selection_request)
6071 (x_get_window_property, receive_incremental_selection)
6072 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6073 (lisp_data_to_selection_data, clean_local_selection_data):
6074 Use ptrdiff_t, not int, to record length of selection.
6075 (x_reply_selection_request, x_get_window_property)
6076 (receive_incremental_selection, x_property_data_to_lisp):
6077 Redo calculations to avoid overflow.
6078 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6079 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6080 something.
6081 (x_get_window_property, receive_incremental_selection)
6082 (lisp_data_to_selection_data, x_property_data_to_lisp):
6083 Check for size-calculation overflow.
6084 (x_get_window_property, receive_incremental_selection)
6085 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6086 Don't store size until memory allocation succeeds.
6087 (x_get_window_property): Plug memory leak on memory exhaustion.
6088 Don't double-block input; malloc is safe here. Don't assume 2**34
6089 - 4 fits in unsigned long. Add an xassert to check
6090 XGetWindowProperty overflow. Be more careful about overflow
6091 calculations, and distinguish size from memory overflow better.
6092 (receive_incremental_selection): When tracing, don't assume
6093 unsigned int is less than INT_MAX.
6094 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6095 harmful) conversions of unsigned short to int.
6096 (lisp_data_to_selection_data): Don't assume that integers
6097 in the range -65535 through -1 fit in an X unsigned short.
6098 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6099 result parameters unless successful. Rely on cons_to_unsigned
6100 to report problems with elements; the old code wasn't right anyway.
6101 (x_check_property_data): Check for int overflow; we cannot use
6102 a wider type due to X limits.
6103 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6104
726e0ab1 6105 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6106
0065d054
PE
6107 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6108 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6109 (x_color_cells): Don't store size until memory allocation succeeds.
6110 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6111 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6112 (x_term_init): Don't assume length fits in int (sprintf is limited
6113 to int size).
bc18e09d 6114
ebfa62c0
PE
6115 Use ptrdiff_t for composition IDs.
6116 * character.c (lisp_string_width):
6117 * composite.c (composition_table_size, n_compositions)
6118 (get_composition_id, composition_gstring_from_id):
6119 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6120 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6121 * window.c (Frecenter):
6122 Use ptrdiff_t, not int, for composition IDs.
6123 * composite.c (get_composition_id): Check for integer overflow.
6124 * composite.h: Adjust prototypes to match the above changes.
6125
d3411f89
PE
6126 Use ptrdiff_t for hash table indexes.
6127 * category.c (hash_get_category_set):
6128 * ccl.c (ccl_driver):
6129 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6130 * coding.c (coding_system_charset_list, detect_coding_system):
6131 * coding.h (struct coding_system.id):
6132 * composite.c (get_composition_id, gstring_lookup_cache):
6133 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6134 * image.c (xpm_get_color_table_h):
6135 * lisp.h (hash_lookup, hash_put):
6136 * minibuf.c (Ftest_completion):
6137 Use ptrdiff_t for hash table indexes, not int (which is too
6138 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6139 32-bit --with-wide-int hosts).
6140
e097a6fa
PE
6141 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6142 Add a FIXME comment about memory leaks.
6143 (syms_of_charset): Don't assume xmalloc returns.
6144
5637687f
PE
6145 Don't assume that stated character widths fit in int.
6146 * character.c (Fchar_width, c_string_width, lisp_string_width):
6147 * character.h (CHAR_WIDTH):
6148 * indent.c (MULTIBYTE_BYTES_WIDTH):
6149 Use sanitize_char_width to avoid undefined and/or bad behavior
6150 with outlandish widths.
a66cfb1c 6151 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6152 now that we have two such functions. All uses changed.
6153 (sanitize_char_width): New inline function.
6154
a2271ba2
PE
6155 Don't assume that tab-width fits in int.
6156 * character.h (sanitize_width): New inline function.
6157 (SANE_TAB_WIDTH): New macro.
6158 (ASCII_CHAR_WIDTH): Use it.
6159 * indent.c (sane_tab_width): Remove. All uses replaced by
6160 SANE_TAB_WIDTH (current_buffer).
6161 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6162
18c52557
PE
6163 * fileio.c: Integer overflow issues with file modes.
6164 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6165
caeeedc1
PE
6166 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6167 Remove unreachable code.
6168 (read_hex, load_charset_map_from_file): Check for integer overflow.
6169
6df6ae42 6170 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6171 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6172 (x_send_scroll_bar_event): Likewise. Check that the size does not
6173 exceed limits imposed by XClientMessageEvent, as well as the usual
6174 ptrdiff_t and size_t limits.
6175
b13995db
PE
6176 * keyboard.c: Overflow, signedness and related fixes.
6177 (make_lispy_movement): Use same integer type in forward decl
6178 that is used in the definition.
6179 (read_key_sequence, keyremap_step):
6180 Change bufsize argument back to int, undoing my 2011-03-30 change.
6181 We prefer signed types, and int is wide enough here.
6182 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6183 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6184 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6185 length, not size_t. Use ptrdiff_t for index, not int.
6186 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6187 possibility of integer overflow.
6188
13464394
PE
6189 Overflow, signedness and related fixes for images.
6190
6191 * dispextern.h (struct it.stack[0].u.image.image_id)
6192 (struct_it.image_id, struct image.id, struct image_cache.size)
6193 (struct image_cache.used, struct image_cache.ref_count):
6194 * gtkutil.c (update_frame_tool_bar):
6195 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6196 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6197 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6198 * nsmenu.m (update_frame_tool_bar):
6199 * xdisp.c (calc_pixel_width_or_height):
6200 * xfns.c (image_cache_refcount):
6201 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6202 on typical 64-bit hosts.
6203
6204 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6205 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6206 Omit unnecessary casts to int.
6207 (parse_image_spec): Check that integers fall into 'int' range
6208 when the callers expect that.
6209 (image_ascent): Redo ascent calculation to avoid int overflow.
6210 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6211 (lookup_image): Remove unnecessary tests.
6212 (xbm_image_p): Locals are now of int, not EMACS_INT,
6213 since parse_image_check makes sure they fit into int.
6214 (png_load, gif_load, svg_load_image):
6215 Prefer int to unsigned where either will do.
6216 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6217 old tiff_error_handler and tiff_warning_handler.
6218 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6219 stack buffer overflows. It uses only the features of vsnprintf
6220 that are common to both POSIX and native Microsoft.
6221 (tiff_error_handler, tiff_warning_handler): Use it.
6222 (tiff_load, gif_load, imagemagick_load_image):
6223 Don't assume :index value fits in 'int'.
6224 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6225 (imagemagick_load_image): Check that crop parameters fit into
6226 the integer types that MagickCropImage accepts. Don't assume
6227 Vimagemagick_render_type has a nonnegative value. Don't assume
6228 size_t fits in 'long'.
6229 (gs_load): Use printmax_t to print the widest integers possible.
6230 Check for integer overflow when computing image height and width.
6231
c11821d4
EZ
62322011-08-26 Eli Zaretskii <eliz@gnu.org>
6233
6234 * xdisp.c (redisplay_window): Don't force window start if point
6235 will be invisible in the resulting window. (Bug#9324)
6236
0c95fcf7
EZ
62372011-08-25 Eli Zaretskii <eliz@gnu.org>
6238
6239 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6240 the display spec is of the form `(space ...)'.
6241 (handle_display_spec): Return the value returned by
6242 handle_single_display_spec, not just 1 or zero.
6243 (handle_single_display_spec): If the display spec is of the form
6244 `(space ...)', and specifies display in the text area, return 2
6245 rather than 1.
fee65a97 6246 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6247 accurately, and prefer exact match for point under bidi.
6248 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6249
6250 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6251 into disp_prop; all users changed.
6252
6253 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6254 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6255 for the text covered by the display property.
6256
e4ed06f1
CY
62572011-08-25 Chong Yidong <cyd@stupidchicken.com>
6258
6259 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6260 Change return value to nil.
6261 (Frecord_buffer): Delete unused function.
6262
f67cdd7f
EZ
62632011-08-24 Eli Zaretskii <eliz@gnu.org>
6264
5980d4c6
EZ
6265 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6266 buffers, return left-to-right.
8610fe8b
EZ
6267 (set_cursor_from_row): Consider candidate row a win if its glyph
6268 represents a newline and point is on that newline. Fixes cursor
6269 positioning on the newline at EOL of R2L text within L2R
6270 paragraph, and vice versa.
6271 (try_cursor_movement): Check continued rows, in addition to
6272 continuation rows. Fixes unwarranted scroll when point enters a
6273 continued line of R2L text within an L2R paragraph, or vice versa.
6274 (cursor_row_p): Consider the case of point being equal to
6275 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6276 from the end of a short line to the beginning of a continued line
6277 of R2L text within L2R paragraph.
6278 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6279 composed characters.
5980d4c6 6280
f67cdd7f
EZ
6281 * bidi.c (bidi_check_type): Use xassert.
6282 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6283 members.
6284
bca633fb
EZ
62852011-08-23 Eli Zaretskii <eliz@gnu.org>
6286
6287 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6288 a character.
6289
4a5885a7
CY
62902011-08-23 Chong Yidong <cyd@stupidchicken.com>
6291
6292 * nsfont.m (ns_otf_to_script): Fix typo.
6293
0902a04e
KH
62942011-08-22 Kenichi Handa <handa@m17n.org>
6295
6296 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6297 extra slot even if the purpose is char-code-property-table.
6298
1a2e6670
EZ
62992011-08-23 Eli Zaretskii <eliz@gnu.org>
6300
8ddde651
EZ
6301 * xdisp.c (redisplay_window): When computing centering_position,
6302 account for the height of the header line. (Bug#8874)
6303
425cc014
EZ
6304 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6305 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6306 candidate is selected by the mouse, and that candidate has a
6307 composed character under the mouse.
6308
1a2e6670
EZ
6309 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6310 coordinates reported by pos-visible-in-window-p for a composed
6311 character in column zero.
6312
8b76d6f8
SM
63132011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6314
6315 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6316
dac347dd
EZ
63172011-08-22 Eli Zaretskii <eliz@gnu.org>
6318
6319 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6320 consider it a hit if to_charpos is anywhere in the range of the
6321 composed buffer positions.
6322
e013fb34
CY
63232011-08-22 Chong Yidong <cyd@stupidchicken.com>
6324
6325 * image.c (gif_load): Don't assume that each subimage has the same
6326 dimensions as the base image. Handle disposal method that is
6327 "undefined" by the gif spec (Bug#9335).
6328
bd1ba3e8
CY
63292011-08-20 Chong Yidong <cyd@stupidchicken.com>
6330
6331 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6332 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6333
54a1215b
EZ
63342011-08-19 Eli Zaretskii <eliz@gnu.org>
6335
823564e5
EZ
6336 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6337 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6338 from an Org mode buffer to a Speedbar frame.
6339
54a1215b
EZ
6340 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6341 a composition, take its buffer position from IT->cmp_it.charpos.
6342 Fixes cursor positioning at the beginning of a line that begins
6343 with a composed character.
6344
9778ebcc
EZ
63452011-08-18 Eli Zaretskii <eliz@gnu.org>
6346
0be6ee06
EZ
6347 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6348 character bidirectional type, use STRONG_L instead. Fixes crashes
6349 in a buffer produced by `describe-categories'.
6350
9778ebcc
EZ
6351 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6352 members before the level stack, so they would be saved and
6353 restored when copying iterator state. Fixes incorrect reordering
6354 around TABs covered by display properties.
6355
156bffbe
AS
63562011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6357
6b02f655 6358 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6359
72ad093b
CY
63602011-08-17 Chong Yidong <cyd@stupidchicken.com>
6361
6362 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6363 (internal_condition_case_2, internal_condition_case_n):
6364 Remove unnecessary aborts (Bug#9081).
72ad093b 6365
35774242
EZ
63662011-08-17 Eli Zaretskii <eliz@gnu.org>
6367
6368 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6369 has no `load' handler, try opening the file locally. (Bug#9311)
6370
db76dd85
KB
63712011-08-16 Ken Brown <kbrown@cornell.edu>
6372
6373 * gmalloc.c: Expand comment.
6374
b215eee5
EZ
63752011-08-16 Eli Zaretskii <eliz@gnu.org>
6376
6377 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6378 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6379
a4579d33
KB
63802011-08-16 Ken Brown <kbrown@cornell.edu>
6381
6382 Fix memory allocation problems in Cygwin build (Bug#9273).
6383
6384 * unexcw.c ( __malloc_initialized): Declare external variable.
6385 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6386
8b76d6f8
SM
6387 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6388 New variables.
a4579d33
KB
6389 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6390 dumped emacs.
6391 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6392 in the static heap.
6393 [CYGWIN] (special_realloc): New function.
6394 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6395 requests to realloc storage in the static heap.
6396
3ebec551
PE
63972011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6398
6399 * bidi.c (bidi_initialize): Remove unused local.
6400
9fd8be00
EZ
64012011-08-15 Eli Zaretskii <eliz@gnu.org>
6402
6b02f655
SM
6403 * bidimirror.h:
6404 * biditype.h: Remove file.
6405 * makefile.w32-in ($(BLD)/bidi.$(O)):
6406 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6407
6408 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6409
6410 * chartab.c: Improve commentary for the uniprop_table API.
6411
32413314
EZ
6412 * bidi.c (bidi_paragraph_init): Support zero value of
6413 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6414 (bidi_initialize): Use uniprop_table instead of including
6415 biditype.h and bidimirror.h.
32413314 6416
9fd8be00
EZ
6417 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6418 coordinates of the iterator when restoring from ppos_it.
6419 (Bug#9296)
6420
5cf2b69b
KH
64212011-08-14 Kenichi Handa <handa@m17n.org>
6422
6423 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6424 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6425
daf17d00
EZ
64262011-08-14 Eli Zaretskii <eliz@gnu.org>
6427
6428 * xdisp.c (move_it_in_display_line_to): Don't invoke
6429 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6430 ppos_it. Fixes vertical cursor motion when line beginning is
6431 covered by an image. (Bug#9296)
6432
08e3161a
JD
64332011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6434
6435 * nsterm.h (ns_run_ascript): Declare.
6436 (NSAPP_DATA2_RUNASSCRIPT): Define.
6437
6438 * nsfns.m (as_script, as_result, as_status): New static variables.
6439 (ns_run_ascript): New function.
5e617bc2 6440 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6441 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6442 the event loop. Get status from as_status (Bug#7276).
6443
6444 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6445 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6446 the event loop (Bug#7276).
6447
a3720aa2
AS
64482011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6449
6450 * gnutls.c (QCgnutls_bootprop_priority)
6451 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6452 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6453 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6454 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6455 (QCgnutls_bootprop_verify_hostname_error)
6456 (QCgnutls_bootprop_callbacks_verify): Rename from
6457 Qgnutls_bootprop_..., all uses changed.
6458
6459 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6460 uses changed.
6461
0a0d27fb
PE
64622011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6463
19d5c50c
PE
6464 * xfaces.c (Qframe_set_background_mode): Now static.
6465 * dispextern.h (Qframe_set_background_mode): Remove decl.
6466
0a0d27fb
PE
6467 * process.c (Fnetwork_interface_info): Declare local only if needed.
6468
377538cb
JD
64692011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6470
6471 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6472 (Fnetwork_interface_list): Allocate in increments of bytes instead
6473 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6474 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6475 sockaddr.
6476 (struct ifflag_def): notrailers is smart on OSX.
6477 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6478 Get hardware address with getifaddrs if available.
6479
08fff70c
EZ
64802011-08-12 Eli Zaretskii <eliz@gnu.org>
6481
6482 * xdisp.c (iterate_out_of_display_property): xassert that
6483 IT->position is set to within IT->object's boundaries. Break from
6484 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6485 when IT->position is set up wrongly due to some bug.
6486 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6487 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6488 entry. Force push_it to save on the stack the current
6489 buffer/string position, to be restored by pop_it. Fix flags in
6490 the iterator structure wrt the object coming from a display
6491 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6492 properties. (Bug#9284)
6493
7be1c708 64942011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6495
7be1c708
CY
6496 * fontset.c (fontset_get_font_group): Add proper type checks.
6497 (Bug#9172)
aac0c6e3 6498
7be1c708 64992011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6500
7be1c708
CY
6501 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6502 and LC_VERSION_MIN_MACOSX.
6503 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6504 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6505
97bb72a6
EZ
65062011-08-08 Eli Zaretskii <eliz@gnu.org>
6507
6508 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6509 no-display-properties-and-no-overlays under bidi display.
6510 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6511 properties and overlays.
97bb72a6 6512
d5617611
CY
65132011-08-08 Chong Yidong <cyd@stupidchicken.com>
6514
37e11a63
CY
6515 * editfns.c (Fset_time_zone_rule): Document relationship with the
6516 setenv function.
6517
d5617611
CY
6518 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6519 the font entity extracted from the cache (Bug#8109).
6520
58872834
CY
65212011-08-07 Chong Yidong <cyd@stupidchicken.com>
6522
6523 * composite.c (autocmp_chars): Don't reset point. That is done by
6524 restore_point_unwind (Bug#5984).
6525
75bfc667
JL
65262011-08-07 Juri Linkov <juri@jurta.org>
6527
6528 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6529 to show the arg `TIME' instead of `TIMEVAL'.
6530
d1410150
EZ
65312011-08-06 Eli Zaretskii <eliz@gnu.org>
6532
6533 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6534 display property strides EOL and includes a newline, as in
6535 longlines-mode. (Bug#9254)
75b771e4
EZ
6536 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6537 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6538
6539 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6540 is non-zero, even if the data buffer is NULL. Fixes a crash in
6541 vertical-motion with longlines-mode. (Bug#9254)
6542
35928349
EZ
65432011-08-05 Eli Zaretskii <eliz@gnu.org>
6544
ec7cc85b
EZ
6545 * bidi.c <bidi_cache_total_alloc>: Now static.
6546 (bidi_initialize): Initialize bidi_cache_total_alloc.
6547
8b76d6f8 6548 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6549 cache. (Bug#9221)
6550
6551 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6552 amount allocated this far in `bidi_cache_total_alloc'.
6553 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6554 non-zero, only free the data buffer without restoring the cache
6555 contents. All callers changed.
6556
6557 * dispextern.h (bidi_unshelve_cache): Update prototype.
6558
6559 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6560 (move_it_in_display_line, move_it_to)
6561 (move_it_vertically_backward, move_it_by_lines): Replace the call
6562 to xfree to an equivalent call to bidi_unshelve_cache.
6563 (move_it_in_display_line_to): Fix logic of returning
412b6358 6564 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6565
e2e2423b
EZ
65662011-08-05 Eli Zaretskii <eliz@gnu.org>
6567
6568 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6569 came from a string character with a `cursor' property. (Bug#9229)
6570
ae9e757a
JD
65712011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6572
6573 * Makefile.in (LIB_PTHREAD): New variable.
6574 (LIBES): Add LIB_PTHREAD (Bug#9216).
6575
6576 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6577 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6578
213bd7f2
AS
65792011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6580
6b02f655 6581 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6582
99aaf75f
JD
65832011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6584
6585 * xterm.c (x_find_topmost_parent): New function.
6586 (x_set_frame_alpha): Find topmost parent window with
6587 x_find_topmost_parent and set the property there also (bug#9181).
6588 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6589
c74e9d86
PE
65902011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6591
6592 * callproc.c (Fcall_process): Avoid vfork clobbering
6593 the local vars buffer, coding_systems, current_dir.
6594
640c8776
SM
65952011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6596
6597 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6598
f26d0e4c
PE
65992011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6600
8a10d76c
PE
6601 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6602 so that it is not optimized away.
6603
f26d0e4c
PE
6604 * xdisp.c (compute_display_string_pos): Remove unused local.
6605
55439c61
EZ
66062011-08-02 Eli Zaretskii <eliz@gnu.org>
6607
6608 Fix slow cursor motion and scrolling in large buffers with
6609 selective display, like Org Mode buffers. (Bug#9218)
6610
6611 * dispextern.h (struct bidi_it): New member disp_prop_p.
6612
6613 * xdisp.c: Remove one-slot cache of display string positions.
6614 (compute_display_string_pos): Accept an additional argument
5e617bc2 6615 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6616 for a display string or property. If found, set DISP_PROP_P
6617 non-zero.
6618
6619 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6620 DISP_PROP_P, and pass it to compute_display_string_pos.
6621 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6622 non-zero. All callers of bidi_fetch_char changed.
6623
fb33fa43
SM
66242011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6625
6626 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6627
b099e063
DM
66282010-12-03 Don March <don@ohspite.net>
6629
6630 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6631 last character M-[char] is translated to ESC [char] (bug#7541).
6632
5cc7f7af
KH
66332011-08-02 Kenichi Handa <handa@m17n.org>
6634
d0fffa3f 6635 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6636
6637 * chartab.c (uniprop_table): Make it non-static.
6638
525d5e6e
EZ
66392011-08-01 Eli Zaretskii <eliz@gnu.org>
6640
6641 * xdisp.c (forward_to_next_line_start): Accept additional argument
6642 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6643 on the newline.
6644 (reseat_at_next_visible_line_start): Use the bidi iterator state
6645 returned by forward_to_next_line_start to restore the state of
6646 it->bidi_it after backing up to previous newline. (Bug#9212)
6647
31011111
AS
66482011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6649
6650 * regex.c (re_comp): Protoize.
6651 (re_exec): Fix return type.
6652 (regexec): Fix type of `ret'. (Bug#9203)
6653
476371c4
PE
66542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6655
e5d76069
PE
6656 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6657 This is needed if max-image-size is a floating-point number.
6658
9a79b20c
AS
66592011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6660
6661 * print.c (print_object): Print empty symbol as ##.
6662
6663 * lread.c (read1): Read ## as empty symbol.
6664
d8c2fa78
AA
66652011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6666
6667 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6668 setting frame foreground color (Bug#9175).
6669 (x_set_background_color): Likewise.
6670
ffe57a7a
AA
6671 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6672 contents (Bug#9176).
6673 (EmacsTooltip -init): Remove bezels and add shadows to
6674 tooltip windows.
6675
bf3492a5
AA
6676 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6677 or scroll bar (Bug#8470).
6678
d55e9c53
AA
6679 * nsfont.m (nsfont_open): Remove assignment to voffset and
6680 unnecessary vars hshink, expand, hd, full_height, min_height.
6681 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6682
6683 * nsterm.h (nsfont_info): Remove voffset field.
6684
d8c2fa78 66852011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6686
6687 Implement strike-through and overline on NextStep (Bug#8863).
6688
6689 * nsfont.m (nsfont_open): Use underline position provided by font,
6690 instead of hard-coded value of 2.
6691 (nsfont_draw): Call ns_draw_text_decoration instead.
6692
6693 * nsterm.h: Add declaration for ns_draw_text_decoration.
6694
6695 * nsterm.m (ns_draw_text_decoration): New function for drawing
6696 underline, overline, and strike-through.
6697 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6698 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6699 accommodate underlining, etc.
4843aac3 6700
4cc60b9b
EZ
67012011-07-28 Eli Zaretskii <eliz@gnu.org>
6702
bc7ece87
EZ
6703 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6704 default.
4cc60b9b 6705
476371c4
PE
67062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6707
66606eea
PE
6708 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6709 Without this fix, if a signal arrives just after memory fills up,
6710 'malloc' might be invoked reentrantly.
6711
476371c4
PE
6712 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6713 In other words, assume that every image size is allowed, on non-X
6714 hosts. This assumption is probably wrong, but it lets Emacs compile.
6715
f3fcc40d
AS
67162011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6717
6718 * regex.c (re_iswctype): Convert return values to boolean.
6719
350c992f
EZ
67202011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6721
6722 * xdisp.c (compute_display_string_pos): Don't use cached display
6723 string position if the buffer had its restriction changed.
6724 (Bug#9184)
6725
5266b4bb
PE
67262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6727
6728 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6729
2573a837 67302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6731
41f55ccd 6732 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6733
39e378da
PE
6734 * bidi.c: Integer size and overflow fixes.
6735 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6736 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6737 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6738 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6739 (bidi_find_other_level_edge):
6740 Use ptrdiff_t instead of EMACS_INT where either will do.
6741 This works better on 32-bit hosts configured --with-wide-int.
6742 (bidi_cache_ensure_space): Check for size-calculation overflow.
6743 Use % rather than repeated addition, for better worst-case speed.
6744 Don't set bidi_cache_size until after xrealloc returns, because it
6745 might not return.
6746 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6747 (bidi_cache_ensure_space): Also check that the bidi cache size
6748 does not exceed that of the largest Lisp string or buffer. See Eli
6749 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6750
5e927815
PE
6751 * alloc.c (__malloc_size_t): Remove.
6752 All uses replaced by size_t. See Andreas Schwab's note
6753 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6754
ca4aa935
PE
6755 * image.c: Improve checking for integer overflow.
6756 (check_image_size): Assume that f is nonnull, since
6757 it is always nonnull in practice. This is one less thing to
6758 worry about when checking for integer overflow later.
6759 (x_check_image_size): New function, which checks for integer
6760 overflow issues inside X.
6761 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6762 This removes the need for a memory_full check.
6763 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6764 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6765 (xbm_read_bitmap_data): Change locals back to 'int', since
6766 their values must fit in 'int'.
6767 (xpm_load_image, png_load, tiff_load):
6768 Invoke x_create_x_image_and_pixmap earlier,
6769 to avoid much needless work if the image is too large.
6770 (tiff_load): Treat overly large images as if
6771 x_create_x_image_and_pixmap failed, not as malloc failures.
6772 (gs_load): Use x_check_image_size.
6773
5f8f9cc2
PE
6774 * gtkutil.c: Omit integer casts.
6775 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6776 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6777
5adf60bc
PE
6778 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6779
c8907a93
PE
6780 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6781 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6782 would wrongly return t on a 64-bit host.
6783
e3c25c68
PE
6784 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6785 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6786 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6787 and therefore cause GCC to emit a bogus diagnostic in some cases.
6788
3f791afe
PE
6789 * image.c: Integer signedness and overflow and related fixes.
6790 This is not an exhaustive set of fixes, but it's time to
6791 record what I've got.
6792 (lookup_pixel_color, check_image_size): Remove redundant decls.
6793 (check_image_size): Don't assume that arbitrary EMACS_INT values
6794 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6795 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6796 (tiff_load, imagemagick_load_image):
6797 Check for overflow in size calculations.
6798 (x_create_x_image_and_pixmap): Remove unnecessary test for
6799 xmalloc returning NULL; that can't happen.
6800 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6801 (xpm_color_bucket): Use better integer hashing function.
6802 (xpm_cache_color): Don't possibly over-allocate memory.
6803 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6804 (gif_memory_source):
6805 Use ptrdiff_t, not int or size_t, to record sizes.
6806 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6807 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6808 either works, as we prefer signed integers.
6809 (tiff_read_from_memory, tiff_write_from_memory):
6810 Return tsize_t, not size_t, since that's what the TIFF API wants.
6811 (tiff_read_from_memory): Don't fail simply because the read would
6812 go past EOF; instead, return a short read.
6813 (tiff_load): Omit no-longer-needed casts.
6814 (Fimagemagick_types): Don't assume size fits into 'int'.
6815
3cc5a532
PE
6816 Improve hashing quality when configured --with-wide-int.
6817 * fns.c (hash_string): New function, taken from sxhash_string.
6818 Do not discard information about ASCII character case; this
6819 discarding is no longer needed.
6820 (sxhash-string): Use it. Change sig to match it. Caller changed.
6821 * lisp.h: Declare it.
6822 * lread.c (hash_string): Remove, since we now use fns.c's version.
6823 The fns.c version returns a wider integer if --with-wide-int is
6824 specified, so this should help the quality of the hashing a bit.
6825
b312a492
PE
6826 * emacs.c: Integer overflow minor fix.
6827 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6828 Define only if GNU_LINUX.
6829 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6830
dfd153ae
PE
6831 * dispnew.c: Integer signedness and overflow fixes.
6832 Remove unnecessary forward decls, that were a maintenance hassle.
6833 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6834 All uses changed.
6835 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6836 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6837 (prepare_desired_row, line_draw_cost):
6838 Use int, not unsigned, where either works.
6839 (save_current_matrix, restore_current_matrix):
6840 Use ptrdiff_t, not size_t, where either works.
6841 (init_display): Check for overflow more accurately, and without
6842 relying on undefined behavior.
6843
a81d11a3
PE
6844 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6845 Remove, replacing with the new symbols in lisp.h. All uses changed.
6846 * fileio.c (make_temp_name):
6847 * filelock.c (lock_file_1, lock_file):
6848 * xdisp.c (message_dolog):
6849 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6850 Use pMd etc. instead.
6851 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6852 replacing the pWIDE etc. symbols removed from editfns.c.
6853
3300e6fd
PE
6854 * keyboard.h (num_input_events): Now uintmax_t.
6855 This is (very slightly) less likely to mess up due to wraparound.
6856 All uses changed.
6857
fd05c7e9
PE
6858 * buffer.c: Integer signedness fixes.
6859 (alloc_buffer_text, enlarge_buffer_text):
6860 Use ptrdiff_t rather than size_t when either will do, as we prefer
6861 signed integers.
6862
903fe15d
PE
6863 * alloc.c: Integer signedness and overflow fixes.
6864 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6865 (__malloc_size_t): Default to size_t, not to int.
6866 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6867 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6868 Prefer ptrdiff_t to size_t when either would do, as we prefer
6869 signed integers.
6870 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6871 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6872 Now const. Initialize with values that are in range even if char
6873 is signed.
6874 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6875 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6876 These functions do the right thing with sizes > 2**32.
6877 (check_depth): Now ptrdiff_t, not int.
6878 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6879 Adjust to new way of storing sizes. Check for size overflow bugs
6880 in rest of code.
6881 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6882 slightly wrong anyway, as it missed one instance of
6883 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6884 (refill_memory_reserve): Omit needless cast to size_t.
6885 (mark_object_loop_halt): Mark as externally visible.
6886
ac82cc6a
PE
6887 * xselect.c: Integer signedness and overflow fixes.
6888 (Fx_register_dnd_atom, x_handle_dnd_message):
6889 Use ptrdiff_t, not size_t, since we prefer signed.
6890 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6891 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6892 x_dnd_atoms_size and x_dnd_atoms_length.
6893
c2d1e36d
PE
6894 * doprnt.c: Prefer signed to unsigned when either works.
6895 * eval.c (verror):
6896 * doprnt.c (doprnt):
6897 * lisp.h (doprnt):
6898 * xdisp.c (vmessage):
6899 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6900 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6901 prefer signed arithmetic to avoid comparison confusion.
6902 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6903 but is a bit tricky.
6904
0e926e56
PE
6905 Assume freestanding C89 headers, string.h, stdlib.h.
6906 * data.c, doprnt.c, floatfns.c, print.c:
6907 Include float.h unconditionally.
6908 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6909 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6910 * regex.c: Likewise for stddef.h, string.h.
6911 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6912 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6913 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6914 (STDC_HEADERS): Remove obsolete defines.
6915 * sysdep.c: Include limits.h unconditionally.
6916
9cfdb3ec
PE
6917 Assume support for memcmp, memcpy, memmove, memset.
6918 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6919 * regex.c (memcmp, memcpy):
6920 Remove; we assume C89 now.
6921
6922 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6923 (__malloc_safe_bcopy): Remove; no longer needed.
6924
cf950e6b 6925 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6926 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6927 well either way, and we prefer signed to unsigned.
6928
dbf38e02
LMI
69292011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6930
6931 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6932 closes the connection while we're reading (bug#9182).
6933
d6f0886c 69342011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6935
d6f0886c
JD
6936 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6937 are specified (Bug#9168).
24e0f6b1 6938
2eb1f9e6
PE
69392011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6940
6941 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6942 Found by GCC static checking and --with-wide-int on a 32-bit host.
6943
22381272 69442011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6945
6946 * xdisp.c (compute_display_string_pos): Fix logic of caching
6947 previous display string position. Initialize cached_prev_pos to
6948 -1. Fixes slow-down at the beginning of a buffer.
6949
f25e39b4
EZ
69502011-07-24 Eli Zaretskii <eliz@gnu.org>
6951
6952 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6953 for attrs[LFACE_FONTSET_INDEX].
6954
04c4b52e
PE
69552011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6956
6957 * xml.c (parse_region): Remove unused local
6958 that was recently introduced.
6959
c1734fbd
EZ
69602011-07-23 Eli Zaretskii <eliz@gnu.org>
6961
be18c5a5
EZ
6962 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6963 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6964
c1734fbd
EZ
6965 * xdisp.c (move_it_in_display_line_to): Record the best matching
6966 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6967 exit if none of the characters scanned was an exact match.
6968 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6969 when exact match is impossible due to invisible text, and the
6970 lines are truncated.
6971
a258d627
JD
69722011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6973
6974 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6975 for OSX >= 10.7.
6976
b6d5a689
EZ
69772011-07-22 Eli Zaretskii <eliz@gnu.org>
6978
0f74f785
EZ
6979 Fix a significant slow-down of cursor motion with C-n, C-p,
6980 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6981 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6982 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6983 (next_element_from_buffer): Call compute_stop_pos_backwards to
6984 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6985 base_level_stop.
6986 (reseat): Don't look for prev_stop, as that could mean a very long
6987 run.
6988 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6989 <cached_disp_overlay_modiff>: Cache for last found display string
6990 position.
551918c1 6991 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6992 about the same buffer in the same area of character positions, and
6993 the buffer wasn't changed since the time the display string
6994 position was cached.
551918c1 6995
b2d0c91a
EZ
69962011-07-22 Eli Zaretskii <eliz@gnu.org>
6997
6998 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6999 is an integer, which is important for empty lines. (Bug#9149)
7000
043604ee
CY
70012011-07-22 Chong Yidong <cyd@stupidchicken.com>
7002
7003 * frame.c (Fmodify_frame_parameters): In tty case, update the
7004 default face if necessary (Bug#4238).
7005
da4adb04
CY
70062011-07-21 Chong Yidong <cyd@stupidchicken.com>
7007
7008 * editfns.c (Fstring_to_char): No need to explain what a character
7009 is in the docstring (Bug#6576).
7010
9abd0532
LMI
70112011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7012
7013 * xml.c (parse_region): Make sure we always return a tree.
7014
36881d16
HK
70152011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7016
7017 * xml.c (parse_region): If a document contains only comments,
7018 return that, too.
7019
1e98674d
LMI
70202011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7021
7022 * xml.c (make_dom): Return comments, too.
7023
590bd467
PE
70242011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7025
7026 Port to OpenBSD.
7027 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7028 and the surrounding thread.
7029 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7030 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7031 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7032 timer goes off.
7033 * s/openbsd.h (BROKEN_SIGIO): Define.
7034 * unexelf.c (unexec) [__OpenBSD__]:
7035 Don't update the .mdebug section of the Alpha COFF symbol table.
7036
f41628b2
LMI
70372011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7038
7039 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7040 (bug#8460).
7041
b59b67c5
PE
70422011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7043
15e3a074
PE
7044 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7045 This fixes some race conditions on the permissions of any newly
7046 created file.
7047
41bed37d
PE
7048 * alloc.c (valid_pointer_p): Use pipe, not open.
7049 This fixes some permissions issues when debugging.
7050
b59b67c5
PE
7051 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7052 If fchown fails to set both uid and gid, try to set just gid,
7053 as that is sometimes allowed. Adjust the file's mode to eliminate
7054 setuid or setgid bits that are inappropriate if fchown fails.
7055
925a6be7
SM
70562011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7057
7058 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7059 to compare Lisp_Objects.
7060 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7061 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7062 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7063
52968808
AS
70642011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7065
0a6a104b
AS
7066 * lread.c (read_integer): Unread even EOF character.
7067 (read1): Likewise. Properly record start position of symbol.
7068
52968808
AS
7069 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7070 symbol character follows.
7071
9e381cdd
PE
70722011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7073
7074 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7075 This works around a problem with the previous change to Fcopy_file.
7076 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7077 and without this change, GCC might complain about discarding
7078 fchown's return value.
7079
b5641435
JB
70802011-07-16 Juanma Barranquero <lekktu@gmail.com>
7081
7082 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7083
a8031457
PE
70842011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7085
7086 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7087
dd889327
LMI
70882011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7089
750c33f7
LMI
7090 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7091 it's used from the C level.
7092
dd889327
LMI
7093 * process.c: Use the same condition for POLL_FOR_INPUT in both
7094 keyboard.c and process.c (bug#1858).
7095
87e86684
LM
70962011-07-09 Lawrence Mitchell <wence@gmx.li>
7097
7098 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7099 (Fgnutls_boot): Use it.
7100
64348f40
AS
71012011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7102
7103 * doc.c (Fsubstitute_command_keys): Revert last change.
7104
1d698799
LMI
71052011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7106
f863868c
LMI
7107 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7108 quotes the next character, and doesn't affect other longer
7109 sequences (bug#8935).
7110
1d698799
LMI
7111 * lread.c (syms_of_lread): Clarify that is isn't only
7112 `eval-buffer' and `eval-defun' that's affected by
7113 `lexical-binding' (bug#8460).
7114
aa4b6df6
EZ
71152011-07-15 Eli Zaretskii <eliz@gnu.org>
7116
7117 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7118 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7119
5d856da6
PE
71202011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7121
ad6042bb
PE
7122 Fix minor problems found by static checking.
7123 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7124 (elsz): Now a signed constant, not a size_t var. We prefer signed
7125 types to unsigned, to avoid integer comparison confusion. Without
7126 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7127 "cannot optimize loop, the loop counter may overflow", a symptom
7128 of the confusion.
f00bbb22 7129 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7130 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7131
6468f31c
LMI
71322011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7133
49080b10
LMI
7134 * search.c (Fre_search_backward): Mention `case-fold-search' in
7135 all the re_search_* functions (bug#8138).
7136
6468f31c
LMI
7137 * keyboard.c (Fopen_dribble_file): Document when the file is
7138 closed (bug#8056).
7139
c965adc5
EZ
71402011-07-14 Eli Zaretskii <eliz@gnu.org>
7141
df9733bf
EZ
7142 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7143 bidi_cache_idx.
7144
0bb23927
EZ
7145 Support bidi reordering of display and overlay strings.
7146 * xdisp.c (compute_display_string_pos)
7147 (compute_display_string_end): Accept additional argument STRING.
7148 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7149 (reseat_to_string): Initialize bidi_it->string.s and
7150 bidi_it->string.schars.
7151 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7152 NULL (avoids a crash in bidi_paragraph_init).
7153 Initialize itb.string.lstring.
0bb23927
EZ
7154 (init_iterator): Call bidi_init_it only of a valid
7155 buffer position was specified. Initialize paragraph_embedding to
7156 L2R.
7157 (reseat_to_string): Initialize the bidi iterator.
7158 (display_string): If we need to ignore text properties of
7159 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7160 original value of -1 will not work with bidi.)
7161 (compute_display_string_pos): First arg is now struct
7162 `text_pos *'; all callers changed. Support display properties on
7163 Lisp strings.
7164 (compute_display_string_end): Support display properties on Lisp
7165 strings.
7166 (init_iterator, reseat_1, reseat_to_string): Initialize the
7167 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7168 when iterating on a string not from display properties).
640c8776
SM
7169 (compute_display_string_pos, compute_display_string_end):
7170 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7171 arrow keys.
7172 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7173 base_level_stop; instead, set base_level_stop to BEGV.
7174 Fixes crashes in vertical-motion.
0bb23927
EZ
7175 (next_element_from_buffer): Improve commentary for when
7176 the iterator is before prev_stop.
7177 (init_iterator): Initialize bidi_p from the default value of
7178 bidi-display-reordering, not from buffer-local value. Use the
7179 buffer-local value only if initializing for buffer iteration.
7180 (handle_invisible_prop): Support invisible properties on strings
7181 that are being bidi-reordered.
7182 (set_iterator_to_next): Support bidi reordering of C strings and
7183 Lisp strings.
7184 (next_element_from_string): Support bidi reordering of Lisp
7185 strings.
7186 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7187 (display_string): Support display of R2L glyph rows.
7188 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7189 (init_iterator): Don't initialize it->bidi_p for strings
7190 here.
7191 (reseat_to_string): Initialize it->bidi_p for strings here.
7192 (next_element_from_string, next_element_from_c_string)
7193 (next_element_from_buffer): Add xassert's for correspondence
7194 between IT's object being iterated and it->bidi_it.string
7195 structure.
7196 (face_before_or_after_it_pos): Support bidi iteration.
7197 (next_element_from_c_string): Handle the case of the first string
7198 character that is not the first one in the visual order.
7199 (get_visually_first_element): New function, refactored from common
7200 parts of next_element_from_buffer, next_element_from_string, and
7201 next_element_from_c_string.
7202 (tool_bar_lines_needed, redisplay_tool_bar)
7203 (display_menu_bar): Force left-to-right direction. Add a FIXME
7204 comment for making that be controlled by a user option.
7205 (push_it, pop_it): Save and restore the state of the
7206 bidi iterator. Save and restore the bidi_p flag.
7207 (pop_it): Iterate out of display property for string iteration as
7208 well.
7209 (iterate_out_of_display_property): Support iteration over strings.
7210 (handle_single_display_spec): Set up it->bidi_it for iteration
7211 over a display string, and call bidi_init_it.
7212 (handle_single_display_spec, next_overlay_string)
7213 (get_overlay_strings_1, push_display_prop): Set up the bidi
7214 iterator for displaying display or overlay strings.
7215 (forward_to_next_line_start): Don't use the shortcut if
7216 bidi-iterating.
7217 (back_to_previous_visible_line_start): If handle_display_prop
7218 pushed the iterator stack, restore the internal state of the bidi
7219 iterator by calling bidi_pop_it same number of times.
7220 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7221 and we are bidi-iterating, don't decrement the iterator position;
7222 instead, set the first_elt flag in the bidi iterator, to produce
7223 the same effect.
7224 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7225 (push_display_prop): xassert that we are iterating a buffer.
7226 (push_it, pop_it): Save and restore paragraph_embedding member.
7227 (handle_single_display_spec, next_overlay_string)
7228 (get_overlay_strings_1, reseat_1, reseat_to_string)
7229 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7230 correctly. Don't assume unibyte strings are not bidi-reordered.
7231 (compute_display_string_pos)
7232 (compute_display_string_end): Fix handling the case of C string.
7233 (push_it, pop_it): Save and restore from_disp_prop_p.
7234 (handle_single_display_spec, push_display_prop): Set the
7235 from_disp_prop_p flag.
7236 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7237 (pop_it): Call iterate_out_of_display_property only if we are
7238 popping after iteration over a string that came from a display
7239 property. Fix a typo in popping stretch info. Add an assertion
7240 for verifying that the iterator position is in sync with the bidi
7241 iterator.
7242 (handle_single_display_spec, get_overlay_strings_1)
7243 (push_display_prop): Fix initialization of paragraph direction for
7244 string when that of the parent object is not yet determined.
7245 (reseat_1): Call bidi_init_it to resync the bidi
7246 iterator with IT's position. (Bug#7616)
7247 (find_row_edges): If ROW->start.pos gives position
7248 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7249 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7250 Reset the from_disp_prop_p flag.
7251 (SAVE_IT, RESTORE_IT): New macros.
7252 (pos_visible_p, face_before_or_after_it_pos)
7253 (back_to_previous_visible_line_start)
7254 (move_it_in_display_line_to, move_it_in_display_line)
7255 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7256 (try_scrolling, redisplay_window, display_line): Use them when
7257 saving a temporary copy of the iterator and restoring it back.
7258 (back_to_previous_visible_line_start, reseat_1)
7259 (init_iterator): Empty the bidi cache "stack".
7260 (move_it_in_display_line_to): If iterator ended up at
7261 EOL, but we never saw any buffer positions smaller than
7262 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7263 motion in bidi-reordered lines.
7264 (move_it_in_display_line_to): Record prev_method and prev_pos
7265 immediately before the call to set_iterator_to_next. Fixes cursor
7266 motion in bidi-reordered lines with stretch glyphs and strings
7267 displayed in margins. (Bug#8133) (Bug#8867)
7268 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7269 TO_CHARPOS.
640c8776
SM
7270 (pos_visible_p): Support positions in bidi-reordered lines.
7271 Save and restore bidi cache.
0bb23927
EZ
7272
7273 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7274 (bidi_paragraph_info): Delete unused struct.
7275 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7276 (bidi_cache_start): New variable.
7277 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7278 to zero.
7279 (bidi_cache_fetch_state, bidi_cache_search)
7280 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7281 (bidi_cache_find, bidi_peek_at_next_level)
7282 (bidi_level_of_next_char, bidi_find_other_level_edge)
7283 (bidi_move_to_visually_next): Compare cache index with
7284 bidi_cache_start rather than with zero.
7285 (bidi_fetch_char): Accept new argument STRING; all callers
7286 changed. Support iteration over a string. Support strings with
7287 display properties. Support unibyte strings. Fix the type of
7288 `len' according to what STRING_CHAR_AND_LENGTH expects.
7289 (bidi_paragraph_init, bidi_resolve_explicit_1)
7290 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7291 (bidi_level_of_next_char, bidi_move_to_visually_next):
7292 Support iteration over a string.
0bb23927
EZ
7293 (bidi_set_sor_type, bidi_resolve_explicit_1)
7294 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7295 can now be zero (for strings); special values 0 and -1 were
7296 changed to -1 and -2, respectively.
7297 (bidi_char_at_pos): New function.
7298 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7299 Call it instead of FETCH_MULTIBYTE_CHAR.
7300 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7301 initialized to valid values.
7302 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7303 values.
7304 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7305 the test for valid cached positions. Fix the logic for looking up
7306 the sentinel state in the cache. GCPRO the Lisp string we are
7307 iterating.
7308 (bidi_push_it, bidi_pop_it): New functions.
7309 (bidi_initialize): Initialize the bidi cache start stack pointer.
7310 (bidi_cache_ensure_space): New function, refactored from part of
7311 bidi_cache_iterator_state. Don't assume the required size is just
7312 one BIDI_CACHE_CHUNK away.
7313 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7314 (bidi_count_bytes, bidi_char_at_pos): New functions.
7315 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7316 always valid if bidi_cache_idx is valid.
7317 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7318 is valid if it's going to be used.
7319 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7320 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7321 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7322 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7323 (bidi_find_other_level_edge, bidi_cache_start_stack):
7324 All variables related to cache indices are now EMACS_INT.
c965adc5 7325
0bb23927
EZ
7326 * dispextern.h (struct bidi_string_data): New structure.
7327 (struct bidi_it): New member `string'. Make flag members be 1-bit
7328 fields, and put them last in the struct.
640c8776
SM
7329 (compute_display_string_pos, compute_display_string_end):
7330 Update prototypes.
0bb23927
EZ
7331 (bidi_push_it, bidi_pop_it): Add prototypes.
7332 (struct iterator_stack_entry): New members bidi_p,
7333 paragraph_embedding, and from_disp_prop_p.
7334 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7335 (bidi_shelve_cache, bidi_unshelve_cache):
7336 Declare prototypes.
0bb23927
EZ
7337
7338 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7339 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7340 and vector-like objects.
7341
7342 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7343 cache around display iteration.
7344
7345 * window.c (Fwindow_end, window_scroll_pixel_based)
7346 (displayed_window_lines, Frecenter): Save and restore the bidi
7347 cache around display iteration.
7348
3bbd2265
LMI
73492011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7350
7351 * editfns.c (Fdelete_region): Clarify the use of the named
7352 parameters (bug#6788).
7353
adc47434
MR
73542011-07-14 Martin Rudalics <rudalics@gmx.at>
7355
7356 * indent.c (Fvertical_motion): Set and restore w->pointm when
7357 saving and restoring the window's buffer (Bug#9006).
7358
837c31f8
LMI
73592011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7360
7361 * editfns.c (Fstring_to_char): Clarify just what is returned
7362 (bug#6576). Text by Eli Zaretskii.
7363
ac389d0c
JB
73642011-07-13 Juanma Barranquero <lekktu@gmail.com>
7365
7366 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7367
0be0ce47
EZ
73682011-07-13 Eli Zaretskii <eliz@gnu.org>
7369
7370 * buffer.c (mmap_find): Fix a typo.
7371
cd18e7e3
JB
73722011-07-13 Johan Bockgård <bojohan@gnu.org>
7373
7374 Fix execution of x selection hooks.
7375 * xselect.c (Qx_lost_selection_functions)
7376 (Qx_sent_selection_functions): New vars.
7377 (syms_of_xselect): DEFSYM them.
7378 (x_handle_selection_request): Pass Qx_sent_selection_functions
7379 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7380 (x_handle_selection_clear,x_clear_frame_selections):
7381 Pass Qx_lost_selection_functions rather than
7382 Vx_lost_selection_functions to Frun_hook_with_args.
7383
47ea7f44
PE
73842011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7385
ac389d0c 7386 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7387 The old code sometimes used this field without initializing it.
7388
47ea7f44
PE
7389 * alloc.c (gc_sweep): Don't read past end of array.
7390 In theory, the old code could also have corrupted Emacs internals,
7391 though it'd be very unlikely.
7392
bc985c87
AS
73932011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7394
7395 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7396 argument. (Bug#4026)
bc985c87 7397
0cf34688
LMI
73982011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7399
b3dadd76
LMI
7400 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7401 key" (bug#4257).
7402
0cf34688
LMI
7403 * window.c (Fset_window_start): Doc fix (bug#4199).
7404 (Fset_window_hscroll): Ditto.
7405
270768cd
PE
74062011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7407
077e3dda 7408 Fix minor new problems caught by GCC 4.6.1.
270768cd 7409 * term.c (init_tty): Remove unused local.
490011a6 7410 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7411 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7412 not used otherwise.
270768cd 7413
b1f58454
CY
74142011-07-12 Chong Yidong <cyd@stupidchicken.com>
7415
7416 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7417
22b9578d
LMI
74182011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7419
6e70ab07
LMI
7420 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7421 are the mini-buffer and the echo area (bug#3320).
7422
22b9578d
LMI
7423 * term.c (init_tty): Remove support for supdup, c10 and perq
7424 terminals, which are no longer supported (bug#1482).
7425
8974cc9f
JB
74262011-07-10 Johan Bockgård <bojohan@gnu.org>
7427
7428 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7429
a560d974
JD
74302011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7431
7432 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7433 for non-popups (Bug#3642).
7434
1dae0f0a
AS
74352011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7436
268c2c36 7437 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7438 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7439 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7440 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7441 * data.c (fmod): Likewise.
7442 * dispnew.c (swap_glyphs_in_rows): Likewise.
7443 * emacs.c (memory_warning_signal): Likewise.
7444 * floatfns.c (float_error): Likewise.
7445 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7446 (otf_open, font_otf_capability, generate_otf_features)
7447 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7448 Likewise.
7449 * image.c (pbm_read_file): Likewise.
7450 * indent.c (string_display_width): Likewise.
7451 * intervals.c (check_for_interval, search_for_interval)
7452 (inc_interval_count, count_intervals, root_interval)
7453 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7454 * lread.c (defalias): Likewise.
268c2c36 7455 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7456 * regex.c (set_image_of_range_1, set_image_of_range)
7457 (regex_grow_registers): Likewise.
7458 * sysdep.c (strerror): Likewise.
7459 * termcap.c (valid_filename_p, tprint, main): Likewise.
7460 * tparam.c (main): Likewise.
7461 * unexhp9k800.c (run_time_remap, save_data_space)
7462 (update_file_ptrs, read_header, write_header, calculate_checksum)
7463 (copy_file, copy_rest, display_header): Likewise.
7464 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7465 Likewise.
7466 * xdisp.c (check_it): Likewise.
7467 * xfaces.c (register_color, unregister_color, unregister_colors):
7468 Likewise.
7469 * xfns.c (print_fontset_result): Likewise.
7470 * xrdb.c (member, fatal, main): Likewise.
7471
99033785
PE
74722011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7473
7474 Fix minor problems found by static checking (Bug#9031).
7475 * chartab.c (char_table_set_range, map_sub_char_table):
7476 Remove unused locals.
7477 (uniprop_table): Now static.
7478 * composite.c (_work_char): Remove unused static var.
7479
9cb2ac56
JB
74802011-07-09 Juanma Barranquero <lekktu@gmail.com>
7481
7482 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7483
f25661f0
JD
74842011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7485
7486 * gtkutil.c (qttip_cb): Remove code without function.
7487
8278c4fe
EZ
74882011-07-09 Eli Zaretskii <eliz@gnu.org>
7489
7490 * w32.c (pthread_sigmask): New stub.
7491
1692ae2d 74922011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7493
8a6ebd58 7494 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7495 sigprocmask is portable only for single-threaded applications, and
7496 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7497 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7498 (LIBES): Use it.
7499 * callproc.c (Fcall_process):
7500 * process.c (create_process):
7501 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7502 Use pthread_sigmask, not sigprocmask.
123403e4 7503
1b854618
JD
75042011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7505
7506 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7507 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7508 wrong (Bug#8591).
7509
3fe4b549
JD
75102011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7511
0ce7e563
JD
7512 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7513 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7514 (xg_hide_tooltip): Fix comment.
7515
3fe4b549
JD
7516 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7517 in registerServicesMenuSendTypes.
7518 (validRequestorForSendType): Don't check ns_return_types.
7519
7520 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7521 ns_return_type.
7522
5df75e47
JR
75232011-07-08 Jason Rumney <jasonr@gnu.org>
7524
22610910
JR
7525 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7526 SH_SHOW for hidden windows (Bug#5482).
7527
5df75e47
JR
7528 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7529 frame struct members of non-existent frames (Bug#6284).
7530
699c10bd
JD
75312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7532
4393663b
JD
7533 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7534 variable firstTime not needed on OSX >= 10.6.
7535 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7536 >= 10.5. Use setKnobProportion, setDoubleValue.
7537
7538 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7539 (MAC_OS_X_VERSION_10_5): Define if not defined.
7540 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7541 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7542 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7543
7544 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7545 cString and lossyCString on OSX >= 10.4
7546
58179cce 7547 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7548 sizeToFit on OSX >= 10.2.
7549
7550 * nsimage.m (allocInitFromFile): Don't use deprecated method
7551 bestRepresentationForDevice on OSX >= 10.6.
7552
7553 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7554 to avoid warning.
7555
7556 * emacs.c: Declare unexec_init_emacs_zone.
7557
a63e0781
JD
7558 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7559
699c10bd
JD
7560 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7561
7562 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7563 on svcsMenu (Bug#8842).
7564
7565 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7566 ns_return_types.
7567 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7568
7569 * nsterm.m (QUTF8_STRING): Declare.
7570 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7571 (validRequestorForSendType): Return type is (id).
7572 Change indexOfObjectIdenticalTo to indexOfObject.
7573 Check if we have local selection before returning self (Bug#8842).
7574 (writeSelectionToPasteboard): Put local selection into paste board
7575 if we have a local selection (Bug#8842).
7576 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7577
7578 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7579 (ns_get_local_selection): Declare.
7580
54e10184
LMI
75812011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7582
9888ff71
LMI
7583 * keymap.c (describe_map_tree): Don't insert a double newline at
7584 the end of the buffer (bug#1169) and return whether we inserted
7585 something.
7586
54e10184
LMI
7587 * callint.c (Fcall_interactively): Change "reading args" to
7588 "providing args" to try to clarify what it does (bug#1010).
7589
15fa4783
KH
75902011-07-07 Kenichi Handa <handa@m17n.org>
7591
7592 * composite.c (composition_compute_stop_pos): Ignore a static
7593 composition starting before CHARPOS (Bug#8915).
7594
7595 * xdisp.c (handle_composition_prop): Likewise.
7596
a8815b00
EZ
75972011-07-07 Eli Zaretskii <eliz@gnu.org>
7598
7599 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7600 (Bug#9015)
7601
ef7b981d 76022011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7603
7604 * character.h (unicode_category_t): New enum type.
7605
7606 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7607 (Qchar_code_property_table): New variable.
7608 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7609 (UNIPROP_COMPRESSED_FORM_P): New macros.
7610 (char_table_ascii): Uncompress the compressed values.
7611 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7612 Uncompress the compressed values.
ac389d0c 7613 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7614 (char_table_ref_and_range): Uncompress the compressed values.
7615 (sub_char_table_set): New arg is_uniprop. Callers changed.
7616 Uncompress the compressed values.
7617 (sub_char_table_set_range): Args changed. Callers changed.
7618 (char_table_set_range): Adjuted for the above change.
7619 (map_sub_char_table): Delete args default_val and parent. Add arg
7620 top. Give decoded values to a Lisp function.
640c8776 7621 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7622 values to a Lisp function. Gcpro more variables.
7623 (uniprop_table_uncompress)
7624 (uniprop_decode_value_run_length): New functions.
7625 (uniprop_decoder, uniprop_decoder_count): New variables.
7626 (uniprop_get_decoder, uniprop_encode_value_character)
7627 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7628 New functions.
7629 (uniprop_encoder, uniprop_encoder_count): New variables.
7630 (uniprop_get_encoder, uniprop_table)
7631 (Funicode_property_table_internal, Fget_unicode_property_internal)
7632 (Fput_unicode_property_internal): New functions.
7633 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7634 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7635 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7636 char-code-property-alist.
7637
640c8776 7638 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7639 Vunicode_category_table.
7640
640c8776 7641 * font.c (font_range): Adjust for the change of
c805dec0
KH
7642 Vunicode_category_table.
7643
76b397fb
DN
76442011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7645
7646 * m/iris4d.h: Remove file, move contents ...
7647 * s/irix6-5.h: ... here.
7648
22b4128e
PE
76492011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7650
7651 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7652 * alloc.c (mark_buffer):
7653 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7654 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7655 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7656 This isn't true in general, and it's particularly not true
7657 if Emacs is configured with --with-wide-int.
7658 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7659 New macros, used in the buffer.c change.
7660
869795d6
JD
76612011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7662
7663 * xsettings.c: Use both GConf and GSettings if both are available.
7664 (store_config_changed_event): Add comment.
7665 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7666 (store_tool_bar_style_changed): New functions.
5e617bc2 7667 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7668 (struct xsettings): Move font inside HAVE_XFT.
7669 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7670 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7671 Move inside HAVE_XFT.
640c8776 7672 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7673 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7674 also.
7675 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7676 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7677 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7678 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7679 (parse_settings): Move check for font inside HAVE_XFT.
7680 (read_settings, apply_xft_settings): Add comment.
7681 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7682 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7683 call store_font_name_changed.
7684 (xft_settings_event): Add comment.
7685 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7686 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7687 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7688 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7689 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7690 (xsettings_get_system_font, xsettings_get_system_normal_font):
7691 Add comment.
869795d6 7692
d8ed26bd
PE
76932011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7694
7695 Random fixes. E.g., (random) never returned negative values.
7696 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7697 subseconds part to the entropy, as that's a bit more random.
7698 Prefer signed to unsigned, since the signedness doesn't matter and
7699 in general we prefer signed. When given a limit, use a
7700 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7701 latter isn't right if USE_2_TAGS_FOR_INTS.
7702 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7703 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7704
cabf1cac
SM
77052011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7706
7707 * textprop.c (text_property_stickiness):
7708 Obey Vtext_property_default_nonsticky.
7709 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7710 * w32fns.c (syms_of_w32fns):
7711 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7712
6e9b2be9
PE
77132011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7714
7715 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7716 This is more efficient than Ffile_directory_p and avoids a minor race.
7717
90186c68
LMI
77182011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7719
7c301272
LMI
7720 * buffer.c (Foverlay_put): Say what the return value is
7721 (bug#7835).
7722
c4f2d8d4
LMI
7723 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7724 is a directory before asking whether to use the file name
7725 (bug#7564).
ad637907
LMI
7726 (barf_or_query_if_file_exists): Make the "File is a directory"
7727 error be more correct.
c4f2d8d4 7728
90186c68
LMI
7729 * fns.c (Frequire): Remove the mention of the .gz files, since
7730 that's installation-specific, but keep the mention of
7731 `get-load-suffixes'.
7732
da64016e
PE
77332011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7734
7735 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7736 Report string overflow if the output is too long.
7737
7d47b580
JB
77382011-07-04 Juanma Barranquero <lekktu@gmail.com>
7739
a555cb87
JB
7740 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7741 (syms_of_gnutls): Remove duplicate DEFSYM for
7742 Qgnutls_bootprop_verify_hostname_error, an error for
7743 Qgnutls_bootprop_verify_error (which is no longer used).
7744
7d47b580
JB
7745 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7746 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7747 Also (re)move comments that are misplaced or no longer relevant.
7748
1e49bfab
LMI
77492011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7750
7751 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7752
1485f4c0
CY
77532011-07-03 Chong Yidong <cyd@stupidchicken.com>
7754
7755 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7756 and background color parameters if they have been changed.
7757
a9ab721e
LMI
77582011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7759
7760 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7761
cf7cff57
PE
77622011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7763
2e13213d
PE
7764 * xsettings.c (SYSTEM_FONT): Define only when used.
7765 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7766
cf7cff57
PE
7767 * keymap.c (access_keymap_1): Now static.
7768
7a8e04f7
CY
77692011-07-02 Chong Yidong <cyd@stupidchicken.com>
7770
7771 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7772 leave any prefix arg for the up event (Bug#1586).
7773
61352f62
LMI
77742011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7775
69bb1ef7
LMI
7776 * lread.c (syms_of_lread): Mention single symbols defined by
7777 `defvar' or `defconst' (bug#7154).
7778
61352f62 7779 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7780 (Frequire): Mention get-load-suffixes.
61352f62 7781
28545e04
MR
77822011-07-02 Martin Rudalics <rudalics@gmx.at>
7783
7784 * window.h (window): Remove clone_number slot.
7785 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7786 Remove.
7787 (make_parent_window, make_window, saved_window)
7788 (Fset_window_configuration, save_window_save): Don't deal with
7789 clone numbers.
7790 * buffer.c (Qclone_number): Remove declaration.
7791 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7792
3349e122
SM
77932011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7794
7795 Add multiple inheritance to keymaps.
7796 * keymap.c (Fmake_composed_keymap): New function.
7797 (Fset_keymap_parent): Simplify.
7798 (fix_submap_inheritance): Remove.
7799 (access_keymap_1): New function extracted from access_keymap to handle
7800 embedded parents and handle lists of maps.
7801 (access_keymap): Use it.
7802 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7803 (Fcopy_keymap): Handle embedded parents.
7804 (Fcommand_remapping, define_as_prefix): Simplify.
7805 (Fkey_binding): Simplify.
7806 (syms_of_keymap): Move minibuffer-local-completion-map,
7807 minibuffer-local-filename-completion-map,
7808 minibuffer-local-must-match-map, and
7809 minibuffer-local-filename-must-match-map to Elisp.
7810 (syms_of_keymap): Defsubr make-composed-keymap.
7811 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7812 (parse_menu_item): Trivial simplification.
7813
3279eb87
GM
78142011-07-01 Glenn Morris <rgm@gnu.org>
7815
7816 * Makefile.in (SETTINGS_LIBS): Fix typo.
7817
4550efdf
KI
78182011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7819
7820 * coding.c (Fencode_coding_string): Record the last coding system
7821 used, as the function doc string says (bug#8738).
7822
0949d2b6
JD
78232011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7824
7825 * xsettings.c (store_monospaced_changed): Take new font as arg and
7826 check for change against current_mono_font.
7827 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7828 (emacs_settings_constructor, emacs_settings_get_property)
7829 (emacs_settings_set_property, emacs_settings_class_init)
7830 (emacs_settings_init, gsettings_obj): Remove.
7831 (something_changedCB): New function for HAVE_GSETTINGS.
7832 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7833 with value as argument.
7834 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7835 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7836 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7837 "changed".
7838
7839 * xgselect.c: Add defined (HAVE_GSETTINGS).
7840 (xgselect_initialize): Ditto.
7841
7842 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7843 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7844 xg_select.
7845
bbc6b304
PE
78462011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7847
7848 * eval.c (struct backtrace): Simplify and port the data structure.
7849 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7850 signed bit field, as this assumption is not portable and it makes
7851 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7852 "char debug_on_exit : 1" as this is not portable either; instead,
7853 use the portable "unsigned int debug_on_exit : 1". Remove unused
7854 member evalargs. Remove obsolete comments about cc bombing out.
7855
9851bfc5
JD
78562011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7857
51bb811f 7858 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7859 Let HAVE_GSETTINGS override HAVE_GCONF.
7860 (store_monospaced_changed): New function.
7861 (EMACS_SETTINGS): A new type derived from GObject to handle
7862 GSettings notifications.
7863 (emacs_settings_constructor, emacs_settings_get_property)
7864 (emacs_settings_set_property, emacs_settings_class_init):
7865 New functions.
7866 (gsettings_client, gsettings_obj): New variables.
7867 (GSETTINGS_SCHEMA): New define.
7868 (something_changedCB): Call store_monospaced_changed.
7869 (init_gsettings): New function.
7870 (xsettings_initialize): Call init_gsettings.
7871 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7872 to NULL.
7873
640c8776 7874 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7875 GCONF_CFLAGS/LIBS.
7876
5386012d
MR
78772011-06-29 Martin Rudalics <rudalics@gmx.at>
7878
7879 * window.c (resize_root_window, grow_mini_window)
7880 (shrink_mini_window): Rename Qresize_root_window to
7881 Qwindow_resize_root_window and Qresize_root_window_vertically to
7882 Qwindow_resize_root_window_vertically.
7883
f13e0b08
PE
78842011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7885
7886 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7887
94515237
JB
78882011-06-27 Juanma Barranquero <lekktu@gmail.com>
7889
7890 * makefile.w32-in: Redesign dependencies so they reflect more
7891 clearly which files are directly included by each source file,
7892 and not through other includes.
7893
e43b6e43
MR
78942011-06-27 Martin Rudalics <rudalics@gmx.at>
7895
7896 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7897 (sort_overlays, overlay_strings): When an overlay's clone number
7898 matches the window's clone number process the overlay even if
7899 the overlay's window property doesn't match the current window.
7900
d68443dc
MR
7901 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7902 (Fwindow_hchild): Rename to Fwindow_left_child.
7903 (Fwindow_next): Rename to Fwindow_next_sibling.
7904 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7905 (resize_window_check): Rename to window_resize_check.
7906 (resize_window_apply): Rename to window_resize_apply.
7907 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7908 (Fdelete_other_windows_internal, resize_frame_windows)
7909 (Fsplit_window_internal, Fdelete_window_internal)
7910 (grow_mini_window, shrink_mini_window)
7911 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7912
c7e73be5
JD
79132011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7914
7915 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7916 (emacs_fixed_set_min_size): Remove.
7917 (emacs_fixed_new): Take frame as argument.
7918
7919 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7920 (_EmacsFixedPrivate): Remove minwidth/height.
7921 Add struct frame *f.
7922 (emacs_fixed_init): Initialize priv->f.
7923 (get_parent_class, emacs_fixed_set_min_size): Remove.
7924 (emacs_fixed_new): Set priv->f to argument.
7925 (emacs_fixed_get_preferred_width)
7926 (emacs_fixed_get_preferred_height): Use min_width/height from
7927 frames size_hint to set minimum and natural (Bug#8919).
7928 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7929 and use min_width/height from frames size_hint to set
7930 min_width/height (Bug#8919).
7931
7932 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7933 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7934 Fix indentation.
c7e73be5 7935
cf99dcf8
EZ
79362011-06-26 Eli Zaretskii <eliz@gnu.org>
7937
7938 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7939 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7940 called at ZV.
7941
029529ac
CY
79422011-06-26 Chong Yidong <cyd@stupidchicken.com>
7943
7944 * process.c (wait_reading_process_output): Bypass select if
7945 waiting for a cell while ignoring keyboard input, and input is
7946 pending. Suggested by Jan Djärv (Bug#8869).
7947
7a7ef429
PE
79482011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7949
7950 Use gnulib's dup2 module instead of rolling our own.
7951 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7952
11fdef7d 79532011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7954
7955 * dispnew.c (scrolling_window): Before scrolling, turn off a
7956 mouse-highlight in the window being scrolled.
7957
cd3520a4
JB
79582011-06-24 Juanma Barranquero <lekktu@gmail.com>
7959
7960 Move DEFSYM to lisp.h and use everywhere.
7961
7962 * character.h (DEFSYM): Move declaration...
7963 * lisp.h (DEFSYM): ...here.
7964
7965 * gnutls.c:
7966 * minibuf.c:
7967 * w32menu.c:
7968 * w32proc.c:
7969 * w32select.c: Don't include character.h.
7970
7971 * alloc.c (syms_of_alloc):
7972 * buffer.c (syms_of_buffer):
7973 * bytecode.c (syms_of_bytecode):
7974 * callint.c (syms_of_callint):
7975 * casefiddle.c (syms_of_casefiddle):
7976 * casetab.c (init_casetab_once):
7977 * category.c (init_category_once, syms_of_category):
7978 * ccl.c (syms_of_ccl):
7979 * cmds.c (syms_of_cmds):
7980 * composite.c (syms_of_composite):
7981 * dbusbind.c (syms_of_dbusbind):
7982 * dired.c (syms_of_dired):
7983 * dispnew.c (syms_of_display):
7984 * doc.c (syms_of_doc):
7985 * editfns.c (syms_of_editfns):
7986 * emacs.c (syms_of_emacs):
7987 * eval.c (syms_of_eval):
7988 * fileio.c (syms_of_fileio):
7989 * fns.c (syms_of_fns):
7990 * frame.c (syms_of_frame):
7991 * fringe.c (syms_of_fringe):
7992 * insdel.c (syms_of_insdel):
7993 * keymap.c (syms_of_keymap):
7994 * lread.c (init_obarray, syms_of_lread):
7995 * macros.c (syms_of_macros):
7996 * msdos.c (syms_of_msdos):
7997 * print.c (syms_of_print):
7998 * process.c (syms_of_process):
7999 * search.c (syms_of_search):
8000 * sound.c (syms_of_sound):
8001 * syntax.c (init_syntax_once, syms_of_syntax):
8002 * terminal.c (syms_of_terminal):
8003 * textprop.c (syms_of_textprop):
8004 * undo.c (syms_of_undo):
8005 * w32.c (globals_of_w32):
8006 * window.c (syms_of_window):
8007 * xdisp.c (syms_of_xdisp):
8008 * xfaces.c (syms_of_xfaces):
8009 * xfns.c (syms_of_xfns):
8010 * xmenu.c (syms_of_xmenu):
8011 * xsettings.c (syms_of_xsettings):
8012 * xterm.c (syms_of_xterm): Use DEFSYM.
8013
4228cf16
TZ
80142011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8015
cd3520a4 8016 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8017
7fcccf1e
PE
80182011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8019
7efb4e0e
PE
8020 Integer and buffer overflow fixes (Bug#8873).
8021
ff5844ad
PE
8022 * print.c (printchar, strout): Check for string overflow.
8023 (PRINTPREPARE, printchar, strout):
8024 Don't set size unless allocation succeeds.
8025
90532f02
PE
8026 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8027 for sizes. Check for string overflow more accurately.
8028 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8029
6d84508d
PE
8030 * macros.c: Integer and buffer overflow fixes.
8031 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8032 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8033 Use ptrdiff_t, not int, for sizes.
8034 Don't increment bufsize until after realloc succeeds.
8035 Check for size-calculation overflow.
8036 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8037
437b2cb4
PE
8038 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8039
8b9ac8b4
PE
8040 * lread.c: Integer overflow fixes.
8041 (read_integer): Radix is now EMACS_INT, not int,
8042 to improve quality of diagnostics for out-of-range radices.
8043 Calculate buffer size correctly for out-of-range radices.
8044 (read1): Check for integer overflow in radices, and in
8045 read-circle numbers.
82cb60d3
PE
8046 (read_escape): Avoid int overflow.
8047 (Fload, openp, read_buffer_size, read1)
8048 (substitute_object_recurse, read_vector, read_list, map_obarray):
8049 Use ptrdiff_t, not int, for sizes.
8050 (read1): Use EMACS_INT, not int, for sizes.
20270765 8051 Check for size overflow.
8b9ac8b4 8052
7fcccf1e
PE
8053 * image.c (cache_image): Check for size arithmetic overflow.
8054
bfbbd7e7
PE
8055 * lread.c: Integer overflow issues.
8056 (saved_doc_string_size, saved_doc_string_length)
8057 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8058 Now ptrdiff_t, not int.
8059 (read1): Don't assume doc string length fits in int. Check for
8060 out-of-range doc string lengths.
8061 (read_list): Don't assume file position fits in int.
39019e54 8062 (read_escape): Check for hex character overflow.
bfbbd7e7 8063
4e323265
LL
80642011-06-22 Leo Liu <sdl.web@gmail.com>
8065
8066 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8067 Move to minibuffer.el.
8068
85fece3e
PE
80692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8070
20b84ce9 8071 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8072 The following patches are for when GLYPH_DEBUG && !XASSERT.
8073 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8074 * dispnew.c (flush_stdout):
8075 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8076 Mark as externally visible.
8077 * dispnew.c (check_window_matrix_pointers): Now static.
8078 * dispnew.c (window_to_frame_vpos):
8079 * xfns.c (unwind_create_frame):
8080 * xterm.c (x_check_font): Remove unused local.
8081 * scroll.c (CHECK_BOUNDS):
8082 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8083 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8084 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8085 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8086 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8087 Now static.
8088 (debug_method_add): Use va_list and vsprintf rather than relying
8089 on undefined behavior with wrong number of arguments.
8090 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8091 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8092 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8093 since we're not interested in debugging glyphs with old libraries.
8094 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8095 GCC 4.6.0's static checking.
8096
0766b489
PE
80972011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8098
31fd4b32
PE
8099 Integer overflow and signedness fixes (Bug#8873).
8100 A few related buffer overrun fixes, too.
8101
b79e8648
PE
8102 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8103
0766b489
PE
8104 * dispextern.h (struct face.stipple):
8105 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8106 (x_bitmap_mask, x_allocate_bitmap_record)
8107 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8108 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8109 (x_create_bitmap_from_xpm_data):
8110 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8111 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8112 (.bitmaps_last):
8113 * xfaces.c (load_pixmap):
8114 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8115 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8116 (.bitmaps_last, struct x_output.icon_bitmap):
8117 Use ptrdiff_t, not int, for bitmap indexes.
8118 (x_allocate_bitmap_record): Check for size overflow.
8119 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8120
b081724f
PE
8121 Use ptrdiff_t, not int, for overlay counts.
8122 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8123 * editfns.c (overlays_around, get_pos_property):
8124 * textprop.c (get_char_property_and_overlay):
8125 * xdisp.c (next_overlay_change, note_mouse_highlight):
8126 * xfaces.c (face_at_buffer_position):
21514da7
PE
8127 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8128 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8129 (Fnext_overlay_change, Fprevious_overlay_change)
8130 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8131 Use ptrdiff_t, not int, for sizes.
21514da7 8132 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8133
3de73e5e
PE
8134 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8135
2606c57b
PE
8136 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8137 (x_session_initialize): Do not assume string length fits in int.
8138
aaafe47a
PE
8139 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8140 This is unlikely, but can occur if DPI is outlandish.
8141
2674ddc8 8142 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8143 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8144
28154962
PE
8145 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8146 * xrdb.c (magic_file_p, search_magic_path):
8147 Omit last arg SUFFIX; it was always 0. All callers changed.
8148 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8149
7de51af5
PE
8150 * xfont.c (xfont_match): Avoid need for strlen.
8151
25ed6cc3
PE
8152 * xfns.c: Don't assume strlen fits in int.
8153 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8154
4eab31dd
PE
8155 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8156 not unsigned long, as we prefer signed integers. All callers changed.
8157 Detect integer overflow in repeat count.
8158 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8159 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8160
171e2a58
PE
8161 * termcap.c: Don't assume sizes fit in int and never overflow.
8162 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8163 (gobble_line): Check for size-calculation overflow.
8164
ad39faca 8165 * minibuf.c (Fread_buffer):
6e5bb2dc 8166 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8167 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8168 Don't assume string length fits in int.
8169
52c61c22 8170 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8171 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8172
b5b8c9e5
PE
8173 * font.c: Don't assume string length fits in int.
8174 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8175 Use ptrdiff_t, not int.
ccd6111c
PE
8176 (font_intern_prop): Don't assume string length fits in int.
8177 Don't assume integer property fits in fixnum.
8178 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8179
882f0d81 8180 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8181 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8182 Reformulate so as not to need the command string.
8183 Invoke gzip -cd rather than gunzip, as it's more portable.
8184 (lock_info_type, lock_file_1, lock_file):
8185 Don't assume pid_t and time_t fit in unsigned long.
8186 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8187 (current_lock_owner): Prefer signed type for sizes.
8188 Use memcpy, not strncpy, where memcpy is what is really wanted.
8189 Don't assume (via atoi) that time_t and pid_t fit in int.
8190 Check for time_t and/or pid_t out of range, e.g., via a network share.
8191 Don't alloca where an auto var works fine.
8192
93f4cf88
PE
8193 * fileio.c: Fix some integer overflow issues.
8194 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8195 Don't assume string length fits in int.
8196 (directory_file_name): Don't assume string length fits in long.
8197 (make_temp_name): Don't assume pid fits in int, or that its print
8198 length is less than 20.
8199
f3e92b69
PE
8200 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8201
1bfdaf10
PE
8202 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8203
35016e9a
PE
8204 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8205
3d1e65a1
PE
8206 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8207 We prefer signed integers, even for size calculations.
8208
0b963a93
PE
8209 * emacs.c: Don't assume string length fits in 'int'.
8210 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8211 (main): Don't invoke strlen when not needed.
8212
573f4b54
PE
8213 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8214 (XD_DEBUG_MESSAGE): Don't waste a byte.
8215
989f33ba
PE
8216 * callproc.c (getenv_internal_1, getenv_internal)
8217 (Fgetenv_internal):
965d34eb
PE
8218 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8219
e4d29b33
PE
8220 * lread.c (invalid_syntax): Omit length argument.
8221 All uses changed. This doesn't fix a bug, but it simplifies the
8222 code away from its former Hollerith-constant appearance, and it's
8223 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8224 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8225
eb49b136
PE
8226 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8227 This didn't break anything, but it didn't help either.
8228 It's confusing to put a bogus integer in a place where the actual
8229 value does not matter.
9f62aeb1 8230 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8231 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8232
15375a22
PE
8233 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8234 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8235 implementation.
b61cc01c
PE
8236 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8237 We prefer signed types, and the value cannot exceed the EMACS_INT
8238 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8239 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8240 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8241 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8242
53b2623d
PE
8243 * indent.c (sane_tab_width): New function.
8244 (current_column, scan_for_column, Findent_to, position_indentation)
8245 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8246 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8247
51cab52b 8248 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8249
f2ed8a70
PE
8250 * lisp.h (lint_assume): New macro.
8251 * composite.c (composition_gstring_put_cache):
8252 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8253
abe80cc6
PE
8254 * editfns.c, insdel.c:
8255 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8256
b02c740e
PE
8257 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8258
ebc96716
PE
8259 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8260
b4e50fa0 8261 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8262 Use much-faster test for byte-length change.
311d5d7c 8263 Don't assume string byte-length fits in 'int'.
a4cf38e4 8264 Check that character arg fits in 'int'.
85461888 8265 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8266
c0c1ee9f
PE
8267 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8268
a498d7f4
PE
8269 * fns.c (concat): Catch string overflow earlier.
8270 Do not rely on integer wraparound.
8271
51cab52b
PE
8272 * dispextern.h (struct it.overlay_strings_charpos)
8273 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8274 * xdisp.c (forward_to_next_line_start)
8275 (back_to_previous_visible_line_start)
8276 (reseat_at_next_visible_line_start, next_element_from_buffer):
8277 Don't arbitrarily truncate the value of 'selective' to int.
8278
76031fad
PE
8279 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8280
5eb55db9
PE
8281 * composite.c: Don't truncate sizes to 'int'.
8282 (composition_gstring_p, composition_reseat_it)
8283 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8284 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8285 not EMACS_UINT, for indexes.
5eb55db9 8286
0703a717
PE
8287 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8288
d6202519
PE
8289 * buffer.c: Include <verify.h>.
8290 (struct sortvec.priority, struct sortstr.priority):
8961a454 8291 Now EMACS_INT, not int.
c20998a7 8292 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8293 (struct sortstr.size, record_overlay_string)
8294 (struct sortstrlist.size, struct sortlist.used):
8295 Don't truncate size to int.
8296 (record_overlay_string): Check for size-calculation overflow.
d6202519 8297 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8298
d5a19415
JM
82992011-06-22 Jim Meyering <meyering@redhat.com>
8300
029529ac 8301 Don't leak an XBM-image-sized buffer
d5a19415
JM
8302 * image.c (xbm_load): Free the image buffer after using it.
8303
a9041e6c
PE
83042011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8305
8306 Port to Sun C.
8307 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8308 that Sun C diagnosed.
8309 * fns.c (secure_hash): Fix pointer signedness issue.
8310 * intervals.c (static_offset_intervals): New function.
8311 (offset_intervals): Use it.
8312
7f3f739f
LL
83132011-06-21 Leo Liu <sdl.web@gmail.com>
8314
8315 * deps.mk (fns.o):
8316 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8317 sha512.h.
8318
8319 * fns.c (secure_hash): Rename from crypto_hash_function and change
8320 the first arg to accept symbols.
5b66d427 8321 (Fsecure_hash): New primitive.
7f3f739f
LL
8322 (syms_of_fns): New symbols.
8323
76147d94
DD
83242011-06-20 Deniz Dogan <deniz@dogan.se>
8325
8326 * process.c (Fset_process_buffer): Clarify return value in
8327 docstring.
8328
7d7d0045
CY
83292011-06-18 Chong Yidong <cyd@stupidchicken.com>
8330
8331 * dispnew.c (add_window_display_history): Use BVAR.
8332
8333 * xdisp.c (debug_method_add): Use BVAR.
8334 (check_window_end, dump_glyph_matrix, dump_glyph)
8335 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8336
8337 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8338 Likewise.
8339
8340 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8341 check till after the cache is created in init_frame_faces.
8342
ff2bc410
SM
83432011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8344
8345 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8346
28177add
PE
83472011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8348
dd3482fe
PE
8349 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8350 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8351 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8352
393d71f3 8353 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8354 * fileio.c (Finsert_file_contents):
8355 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8356 Remove the old (too-loose) buffer overflow checks.
8357 They weren't needed, since make_gap checks for buffer overflow.
8358 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8359 The old code merely checked for Emacs fixnum overflow, and relied
8360 on undefined (wraparound) behavior. The new code avoids undefined
8361 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8362
2e6813b0 8363 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8364 Tune. Don't use wider integers than needed. Don't use alloca.
8365 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8366
599a9e4f
PE
8367 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8368
99561444
PE
8369 * insdel.c, lisp.h (buffer_overflow): New function.
8370 (insert_from_buffer_1, replace_range, replace_range_2):
8371 * insdel.c (make_gap_larger):
8372 * editfns.c (Finsert_char):
8373 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8374
28177add
PE
8375 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8376
e69dafad
PE
83772011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8378
4baa020d 8379 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8380
b1c46f02
PE
8381 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8382 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8383
e69dafad
PE
8384 * fileio.c: Don't assume EMACS_INT fits in off_t.
8385 (emacs_lseek): New static function.
8386 (Finsert_file_contents, Fwrite_region): Use it.
8387 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8388
566684ea
PE
8389 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8390
e6966cd6
PE
8391 * fns.c: Don't overflow int when computing a list length.
8392 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8393 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8394 truncation on 64-bit hosts. Check for QUIT every
8395 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8396 faster and is responsive enough.
8397 (Flength): Report an error instead of overflowing an integer.
8398 (Fsafe_length): Return a float if the value is not representable
8399 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8400 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8401 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8402
dd0b0efb
PE
8403 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8404 (header_size, word_size): New constants.
8405 (allocate_vectorlike): Don't check size overflow here.
8406 (allocate_vector): Check it here instead, since this is the only
8407 caller of allocate_vectorlike that could cause overflow.
8408 Check that the new vector's length is representable as a fixnum.
8409
86fe5cfe
PE
8410 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8411 The previous code was bogus. For example, next_almost_prime (32)
8412 returned 39, which is undesirable as it is a multiple of 3; and
8413 next_almost_prime (24) returned 25, which is a multiple of 5 so
8414 why was the code bothering to check for multiples of 7?
8415
80e88859
PE
8416 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8417
4a2f0ad6
PE
8418 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8419
f66c7cf8
PE
8420 Variadic C functions now count arguments with ptrdiff_t.
8421 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8422 Back then I didn't know that the Emacs coding style prefers signed int.
8423 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8424 were being counted with int, which may truncate counts on 64-bit
8425 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8426 * lisp.h (struct Lisp_Subr.function.aMANY)
8427 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8428 Arg counts are now ptrdiff_t, not size_t.
8429 All variadic functions and their callers changed accordingly.
8430 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8431 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8432 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8433 * callint.c (Fcall_interactively): Check arg count for overflow,
8434 to avoid potential buffer overrun. Use signed char, not 'int',
8435 for 'varies' array, so that we needn't bother to check its size
8436 calculation for overflow.
8437 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8438 * eval.c (apply_lambda):
8439 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8440 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8441 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8442
a1759b76
PE
8443 * callint.c (Fcall_interactively): Don't use index var as event count.
8444
d96be9fc
PE
8445 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8446 * mem-limits.h (SIZE): Remove; no longer used.
8447
a690a978 8448 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8449
578c21e6
PE
8450 Remove unnecessary casts.
8451 * xterm.c (x_term_init):
8452 * xfns.c (x_set_border_pixel):
8453 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8454 These aren't needed now that we assume ANSI C.
8455
96f53c6c
PE
8456 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8457 It's more likely to cause problems (due to unsigned overflow)
8458 than to cure them.
8459
83c77d31
PE
8460 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8461
ee2079f1
PE
8462 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8463
6da65536
PE
8464 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8465
7147c4a4
PE
8466 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8467
193e32d9
PE
8468 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8469
e5533da6
PE
8470 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8471
9910e595
PE
8472 GLYPH_CODE_FACE returns EMACS_INT, not int.
8473 * dispextern.h (merge_faces):
8474 * xfaces.c (merge_faces):
01103c44
PE
8475 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8476 Don't assume EMACS_INT fits in int.
9910e595 8477
2638320e
PE
8478 * character.h (CHAR_VALID_P): Remove unused parameter.
8479 * fontset.c, lisp.h, xdisp.c: All uses changed.
8480
045eb8d9
PE
8481 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8482
c1f134b5
PE
8483 * fns.c (concat): Minor tuning based on overflow analysis.
8484 This doesn't fix any bugs. Use int to hold character, instead
8485 of constantly refetching from Emacs object. Use XFASTINT, not
8486 XINT, for value known to be a character. Don't bother comparing
8487 a single byte to 0400, as it's always less.
8488
395fcb93 8489 * floatfns.c (Fexpt):
327eeec8
PE
8490 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8491
abbd3d23
PE
8492 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8493 for characters.
8494
684a03ef
PE
8495 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8496
0fed43f3
PE
8497 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8498 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8499 incorrectly succeed when S was a string, because 4294967386 was
8500 truncated before it was used.
8501
8fd02eb7
PE
8502 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8503 Otherwise, an out-of-range integer could cause undefined behavior
8504 on a 64-bit host.
8505
f8c86b69
PE
8506 * composite.c: Use int, not EMACS_INT, for characters.
8507 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8508 EMACS_INT, for values that are known to be in character range.
8509 This doesn't fix any bugs but is the usual style inside Emacs and
8510 may generate better code on 32-bit machines.
8511
34206dd2
PE
8512 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8513 This is for reasons similar to the recent CHAR_STRING fix.
8514 * charset.c (Fencode_char): Check that character arg is actually
8515 a character. Pass an int to ENCODE_CHAR.
8516 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8517 wider than 'int', as a compile-time check to prevent future regressions
8518 in this area.
8519
c5958d4c 8520 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8521
8522 Make sure a 64-bit char is never passed to CHAR_STRING.
8523 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8524 by silently ignoring the top 32 bits, allowing some values
8525 that were far too large to be valid characters.
8526 * character.h: Include <verify.h>.
8527 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8528 arguments are no wider than unsigned, as a compile-time check
8529 to prevent future regressions in this area.
8530 * data.c (Faset):
01103c44 8531 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8532 (Fsubst_char_in_region):
8533 * fns.c (concat):
8534 * xdisp.c (decode_mode_spec_coding):
8535 Adjust to CHAR_STRING's new requirement.
8536 * editfns.c (Finsert_char, Fsubst_char_in_region):
8537 * fns.c (concat): Check that character args are actually
8538 characters. Without this test, these functions did the wrong
8539 thing with wildly out-of-range values on 64-bit hosts.
8540
d37ca623
PE
8541 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8542 These casts should not be needed on 32-bit hosts, either.
8543 * keyboard.c (read_char):
8544 * lread.c (Fload): Remove casts to unsigned.
8545
ea204efb
PE
8546 * lisp.h (UNSIGNED_CMP): New macro.
8547 This fixes comparison bugs on 64-bit hosts.
8548 (ASCII_CHAR_P): Use it.
8549 * casefiddle.c (casify_object):
01103c44 8550 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8551 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8552 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8553 * dispextern.h (FACE_FROM_ID):
8554 * keyboard.c (read_char): Use UNSIGNED_CMP.
8555
41cb286c
PE
8556 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8557 not to EMACS_INT, to avoid GCC warning.
8558
4a1b9832
PE
8559 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8560
55daad71
PE
8561 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8562 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8563 isn't needed on 32-bit machines.
8f95c75c 8564
01103c44
PE
8565 * buffer.c (Fgenerate_new_buffer_name):
8566 Use EMACS_INT for count, not int.
0ceccced 8567 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8568
8569 * data.c (Qcompiled_function): Now static.
8570
c6f072e7
PE
8571 * window.c (window_body_lines): Now static.
8572
20ce5912
PE
8573 * image.c (gif_load): Rename local to avoid shadowing.
8574
9c4c5f81
PE
8575 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8576 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8577 * alloc.c (make_save_value): Integer argument is now of type
8578 ptrdiff_t, not int.
8579 (mark_object): Use ptrdiff_t, not int.
8580 * lisp.h (pD): New macro.
8581 * print.c (print_object): Use it.
8582
c0c5c8ae
PE
8583 * alloc.c: Use EMACS_INT, not int, to count objects.
8584 (total_conses, total_markers, total_symbols, total_vector_size)
8585 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8586 (total_free_floats, total_floats, total_free_intervals)
8587 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8588 Now EMACS_INT, not int. All uses changed.
8589 (Fgarbage_collect): Compute overall total using a double, so that
8590 integer overflow is less likely to be a problem. Check for overflow
8591 when converting back to an integer.
5a25e253
PE
8592 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8593 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8594 These were 'int' variables that could overflow on 64-bit hosts;
8595 they were never used, so remove them instead of repairing them.
211a0b2a 8596 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8597 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8598 Previously, this ceilinged at INT_MAX, but that doesn't work on
8599 64-bit machines.
e46bb31a 8600 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8601
c78baabf 8602 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8603 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8604 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8605 when a (possibly-narrower) signed value would do just as well.
8606 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8607
c9d624c6
PE
8608 * alloc.c: Catch some string size overflows that we were missing.
8609 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8610 for convenience in STRING_BYTES_MAX.
8611 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8612 The definition here is exact; the one in lisp.h was approximate.
8613 (allocate_string_data): Check for string overflow. This catches
8614 some instances we weren't catching before. Also, it catches
8615 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8616 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8617 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8618
c9d624c6
PE
8619 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8620 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8621 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8622
353032ce
PE
8623 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8624
2bccce07
PE
8625 * alloc.c (Fmake_string): Check for out-of-range init.
8626
0ac30604
SM
86272011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8628
8629 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8630
c195f2de
JD
86312011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8632
8633 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8634 xg_get_default_scrollbar_width.
8635
8636 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8637 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8638 (style_changed_cb): Call update_theme_scrollbar_width and call
8639 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8640 all frames (Bug#8505).
8641 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8642 Call gtk_window_set_resizable if HAVE_GTK3.
8643 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8644 and height if HAVE_GTK3 (Bug#8505).
8645 (scroll_bar_width_for_theme): New variable.
8646 (update_theme_scrollbar_width): New function.
8647 (xg_get_default_scrollbar_width): Move code to
8648 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8649 (xg_initialize): Call update_theme_scrollbar_width.
8650
8651 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8652
8653 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8654
e10ac9f1
MR
86552011-06-12 Martin Rudalics <rudalics@gmx.at>
8656
8657 * frame.c (make_frame): Call other_buffer_safely instead of
8658 other_buffer.
8659
8660 * window.c (temp_output_buffer_show): Call display_buffer with
8661 second argument Vtemp_buffer_show_specifiers and reset latter
8662 immediately after the call.
8663 (Vtemp_buffer_show_specifiers): New variable.
8664 (auto_window_vscroll_p, next_screen_context_lines)
8665 (Vscroll_preserve_screen_position): Remove leading asterisks from
8666 doc-strings.
8667
2d3c217e 86682011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8669
7b7f97e8 8670 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8671 * buffer.c (Qclone_number): Remove for now, as it's unused.
8672 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8673 (record_buffer): Remove unused local.
8674 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8675 (set_frame_buffer_list): Remove; unused.
8676 * frame.h (other_visible_frames): Remove decl.
8677 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8678 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8679 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8680 if HAVE_GPM.
8681 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8682 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8683 Define only if HAVE_GPM.
8684 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8685 (update_hints_inhibit): Remove; never set. All uses removed.
8686 * widgetprv.h (emacsFrameClassRec): Remove decl.
8687 * window.c (delete_deletable_window): Now returns void, since it
8688 wasn't returning anything.
8689 (compare_window_configurations): Remove unused locals.
8690 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8691 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8692 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8693 the same widths as pointers. This follows up on the 2011-05-06 patch.
8694 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8695 * xterm.h: Likewise.
8696 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8697
1384b89e
JB
86982011-06-12 Juanma Barranquero <lekktu@gmail.com>
8699
8700 * makefile.w32-in: Update dependencies.
8701 (LISP_H): Add lib/intprops.h.
8702
1100a63c
CY
87032011-06-11 Chong Yidong <cyd@stupidchicken.com>
8704
8705 * image.c (gif_load): Add animation frame delay to the metadata.
8706 (syms_of_image): Use DEFSYM. New symbol `delay'.
8707
6198ccd0
MR
87082011-06-11 Martin Rudalics <rudalics@gmx.at>
8709
8710 * window.c (delete_deletable_window): Re-add.
8711 (Fset_window_configuration): Rewrite to handle dead buffers and
8712 consequently deletable windows.
8713 (window_tree, Fwindow_tree): Remove. Supply functionality in
8714 window.el.
8715 (compare_window_configurations): Simplify code.
8716
b6e3633c
AS
87172011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8718
1ab0dee5
AS
8719 * image.c (imagemagick_load_image): Fix type mismatch.
8720 (Fimagemagick_types): Likewise.
8721
b6e3633c
AS
8722 * window.h (replace_buffer_in_windows): Declare.
8723
9397e56f
MR
87242011-06-11 Martin Rudalics <rudalics@gmx.at>
8725
8726 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8727 Qclone_number. Remove external declaration of Qdelete_window.
8728 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8729 code.
640c8776
SM
8730 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8731 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8732 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8733 buffer list implementation.
8734 (other_buffer_safely): New function.
8735 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8736 calls to replace_buffer_in_windows and
8737 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8738 if allowed.
8739 (record_buffer): Inhibit quitting and rewrite using quittable
8740 functions. Run Qbuffer_list_update_hook if allowed.
8741 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8742 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8743 Move switch-to-buffer to window.el.
9397e56f
MR
8744 (bury-buffer): Move to window.el.
8745 (Vbuffer_list_update_hook): New variable.
8746
8747 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8748 section.
8749
8750 * window.h (resize_frame_windows): Move up in code.
8751 (Fwindow_frame): Remove EXFUN.
8752 (replace_buffer_in_all_windows): Remove prototype.
8753 (replace_buffer_in_windows_safely): Add prototype.
8754
8755 * window.c: Declare Qdelete_window static again. Move down
8756 declaration of select_count.
8757 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8758 (Fother_window): Move to window.el.
8759 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8760 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8761 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8762 window.el.
8763 (replace_buffer_in_windows): Implement by calling
8764 Qreplace_buffer_in_windows.
8765 (replace_buffer_in_all_windows): Remove with some functionality
8766 moved into replace_buffer_in_windows_safely.
8767 (replace_buffer_in_windows_safely): New function.
8768 (select_window_norecord, select_frame_norecord): Move in front
8769 of run_window_configuration_change_hook. Remove now obsolete
8770 declarations.
640c8776
SM
8771 (Fset_window_buffer): Rewrite doc-string.
8772 Call Qrecord_window_buffer.
9397e56f
MR
8773 (keys_of_window): Move binding for other-window to window.el.
8774
b50691aa
CY
87752011-06-11 Chong Yidong <cyd@stupidchicken.com>
8776
8777 * dispextern.h (struct image): Replace data member, whose int_val
8778 and ptr_val fields were not used by anything, with a single
8779 lisp_val object.
8780
8781 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8782 (gif_clear_image, gif_load, imagemagick_load_image)
8783 (gs_clear_image, gs_load): Callers changed.
8784
3f754b86
PE
87852011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8786
cca69397
PE
8787 * buffer.h: Include <time.h>, for time_t.
8788 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8789
109e28d0
PE
8790 Fix minor problems found by static checking.
8791
60737f02
PE
8792 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8793
4b66faf3
PE
8794 Make identifiers static if they are not used in other modules.
8795 * data.c (Qcompiled_function, Qframe, Qvector):
8796 * image.c (QimageMagick, Qsvg):
8797 * minibuf.c (Qmetadata):
8798 * window.c (resize_window_check, resize_root_window): Now static.
8799 * window.h (resize_window_check, resize_root_window): Remove decls.
8800
109e28d0
PE
8801 * window.c (window_deletion_count, delete_deletable_window):
8802 Remove; unused.
46a4ce9e
PE
8803 (window_body_lines): Now static.
8804 (Fdelete_other_windows_internal): Mark vars as initialized.
8805 Make sure 'resize_failed' is initialized.
8806 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8807 (resize_window_apply): Remove unused local.
8808 * window.h (delete_deletable_window): Remove decl.
8809
109e28d0 8810 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8811 (imagemagick_load_image): Fix pointer signedness problem by changing
8812 last arg from unsigned char * to char *. All uses changed.
8813 Also, fix a local for similar reasons.
8814 Remove unused locals. Remove locals to avoid shadowing.
8815 (fn_rsvg_handle_free): Remove; unused.
8816 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8817 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8818
3f754b86
PE
8819 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8820
2547adb1
CY
88212011-06-10 Chong Yidong <cyd@stupidchicken.com>
8822
8823 * image.c (gif_load): Fix omitted cast error introduced by
8824 2011-06-06 change.
8825
2c8e37d4
MR
88262011-06-10 Martin Rudalics <rudalics@gmx.at>
8827
8828 * window.h (resize_proportionally, orig_total_lines)
8829 (orig_top_line): Remove from window structure.
8830 (set_window_height, set_window_width, change_window_heights)
8831 (Fdelete_window): Remove prototypes.
8832 (resize_frame_windows): Remove duplicate declaration.
8833
440a42e3
EZ
88342011-06-10 Eli Zaretskii <eliz@gnu.org>
8835
8836 * window.h (resize_frame_windows, resize_window_check)
8837 (delete_deletable_window, resize_root_window)
8838 (resize_frame_windows): Declare prototypes.
8839
8840 * window.c (resize_window_apply): Make definition be "static" to
8841 match the prototype.
8842
562dd5e9
MR
88432011-06-10 Martin Rudalics <rudalics@gmx.at>
8844
8845 * window.c: Remove declarations of Qwindow_size_fixed,
8846 window_min_size_1, window_min_size_2, window_min_size,
8847 size_window, window_fixed_size_p, enlarge_window, delete_window.
8848 Remove static from declaration of Qdelete_window, it's
8849 temporarily needed by Fbury_buffer.
8850 (replace_window): Don't assign orig_top_line and
8851 orig_total_lines.
8852 (Fdelete_window, delete_window): Remove. Window deletion is
8853 handled by window.el.
640c8776
SM
8854 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8855 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8856 (Fdelete_other_windows): Remove. Deleting other windows is
8857 handled by window.el.
8858 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8859 handled in window.el.
8860 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8861 Window minimum sizes are handled in window.el.
8862 (shrink_windows, size_window, set_window_height)
8863 (set_window_width, change_window_heights, window_height)
8864 (window_width, CURBEG, CURSIZE, enlarge_window)
8865 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8866 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8867 handled in window.el.
8868 (make_dummy_parent): Rename to make_parent_window and give it a
8869 second argument horflag.
8870 (make_window): Don't set resize_proportionally any more.
8871 (Fsplit_window): Remove. Windows are split in window.el.
8872 (save_restore_action, save_restore_orig_size)
8873 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8874 Resize mini windows in window.el.
8875 (grow_mini_window, shrink_mini_window): Implement by calling
8876 Qresize_root_window_vertically, resize_window_check and
8877 resize_window_apply.
640c8776
SM
8878 (saved_window, Fset_window_configuration, save_window_save):
8879 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8880 resize_proportionally.
8881 (window_min_height, window_min_width): Move to window.el.
8882 (keys_of_window): Move bindings for delete-other-windows,
8883 split-window, delete-window and enlarge-window to window.el.
8884
8885 * buffer.c: Temporarily extern Qdelete_window.
8886 (Fbury_buffer): Temporarily call Qdelete_window instead of
8887 Fdelete_window (Fbury_buffer will move to window.el soon).
8888
8889 * frame.c (set_menu_bar_lines_1): Remove code handling
8890 orig_top_line and orig_total_lines.
8891
8892 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8893 set_window_height but set heights directly.
8894 (change_frame_size_1): Use resize_frame_windows.
8895
8896 * xdisp.c (init_xdisp): Don't use set_window_height but set
8897 heights directly.
8898
640c8776
SM
8899 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8900 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8901 run_window_configuration_change_hook.
8902
8903 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8904 instead of change_window_heights and run
8905 run_window_configuration_change_hook.
8906
1a13852e
MR
89072011-06-09 Martin Rudalics <rudalics@gmx.at>
8908
8909 * window.c (replace_window): Rename second argument REPLACEMENT to
8910 NEW. New third argument SETFLAG. Rewrite.
8911 (delete_window, make_dummy_parent): Call replace_window with
8912 third argument 1.
8913 (window_list_1): Move down in code.
8914 (run_window_configuration_change_hook): Move set_buffer part
8915 before select_frame_norecord part in order to unwind correctly.
8916 Rename count1 to count.
8917 (recombine_windows, delete_deletable_window, resize_root_window)
8918 (Fdelete_other_windows_internal)
8919 (Frun_window_configuration_change_hook, make_parent_window)
8920 (resize_window_check, resize_window_apply, Fresize_window_apply)
8921 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8922 (Fdelete_window_internal, Fresize_mini_window_internal):
8923 New functions.
1a13852e
MR
8924 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8925
f3d1777e
MR
89262011-06-08 Martin Rudalics <rudalics@gmx.at>
8927
496e208e
MR
8928 * window.h (window): Add some new members to window structure -
8929 normal_lines, normal_cols, new_total, new_normal, clone_number,
8930 splits, nest, prev_buffers, next_buffers.
8931 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8932 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8933
f3d1777e
MR
8934 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8935 Remove.
496e208e
MR
8936 (make_dummy_parent): Set new members of windows structure.
8937 (make_window): Move down in code. Handle new members of window
8938 structure.
8939 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8940 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8941 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8942 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8943 (Fset_window_next_buffers, Fset_window_clone_number):
8944 New functions.
496e208e
MR
8945 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8946 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8947 Doc-string fixes.
8948 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8949 Argument WINDOW can be now internal window too.
8950 (Fwindow_use_time): Move up in code.
8951 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8952 Rewrite doc-string.
8953 (Fset_window_configuration, saved_window)
8954 (Fcurrent_window_configuration, save_window_save): Handle new
8955 members of window structure.
b9e809c2
MR
8956 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8957 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8958 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8959 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8960 Qget_mru_window, Qresize_root_window,
8961 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8962 Qauto_buffer_name; staticpro them.
f3d1777e 8963
abde8f8c
MR
89642011-06-07 Martin Rudalics <rudalics@gmx.at>
8965
8966 * window.c (Fwindow_total_size, Fwindow_left_column)
8967 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8968 (Fwindow_list_1): New functions.
8969 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8970 (Fwindow_width, Fscroll_left, Fscroll_right):
8971 Use window_body_cols instead of window_box_text_cols.
8972 (delete_window, Fset_window_configuration):
8973 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8974 (delete_all_subwindows): Take a window as argument and not a
8975 structure. Rewrite.
190b47e6
MR
8976 (window_loop): Remove handling of GET_LRU_WINDOW and
8977 GET_LARGEST_WINDOW.
8978 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8979
8980 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8981 window_box_text_cols. delete_all_subwindows now takes a
8982 Lisp_Object as argument.
abde8f8c 8983
640c8776
SM
8984 * indent.c (compute_motion, Fcompute_motion):
8985 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8986
fa8a67e6
MR
8987 * frame.c (delete_frame): Call delete_all_subwindows with root
8988 window as argument.
8989
a54e3482
DC
89902011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8991
8992 * fns.c (Fputhash): Document return value.
8993
60002bf5
CY
89942011-06-06 Chong Yidong <cyd@stupidchicken.com>
8995
8996 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8997
0c671da6 89982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8999
b862a52a 9000 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9001
be44ca6c
PE
9002 Check for overflow when converting integer to cons and back.
9003 * charset.c (Fdefine_charset_internal, Fdecode_char):
9004 Use cons_to_unsigned to catch overflow.
9005 (Fencode_char): Use INTEGER_TO_CONS.
9006 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9007 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9008 * data.c (long_to_cons, cons_to_long): Remove.
9009 (cons_to_unsigned, cons_to_signed): New functions.
9010 These signal an error for invalid or out-of-range values.
9011 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9012 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9013 * font.c (Ffont_variation_glyphs):
9014 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9015 * lisp.h: Include <intprops.h>.
9016 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9017 (cons_to_signed, cons_to_unsigned): New decls.
9018 (long_to_cons, cons_to_long): Remove decls.
9019 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9020 (Fprimitive_undo): Use CONS_TO_INTEGER.
9021 * xfns.c (Fx_window_property): Likewise.
9022 * xselect.c: Include <limits.h>.
9023 (x_own_selection, selection_data_to_lisp_data):
9024 Use INTEGER_TO_CONS.
9025 (x_handle_selection_request, x_handle_selection_clear)
9026 (x_get_foreign_selection, Fx_disown_selection_internal)
9027 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9028 (lisp_data_to_selection_data): Use cons_to_unsigned.
9029 (x_fill_property_data): Use cons_to_signed.
9030 Report values out of range.
9031
d1f3d2af
PE
9032 Check for buffer and string overflow more precisely.
9033 * buffer.h (BUF_BYTES_MAX): New macro.
9034 * lisp.h (STRING_BYTES_MAX): New macro.
9035 * alloc.c (Fmake_string):
9036 * character.c (string_escape_byte8):
9037 * coding.c (coding_alloc_by_realloc):
9038 * doprnt.c (doprnt):
9039 * editfns.c (Fformat):
9040 * eval.c (verror):
9041 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9042 since they may not be the same number.
9043 * editfns.c (Finsert_char):
9044 * fileio.c (Finsert_file_contents):
9045 Likewise for BUF_BYTES_MAX.
9046
dd52fcea
PE
9047 * image.c: Use ptrdiff_t, not int, for sizes.
9048 (slurp_file): Switch from int to ptrdiff_t.
9049 All uses changed.
9050 (slurp_file): Check that file size fits in both size_t (for
9051 malloc) and ptrdiff_t (for sanity and safety).
9052
7f9bbdbb
PE
9053 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9054 if b->modtime has its maximal value.
9055
dfe18f82
PE
9056 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9057
84acfcf0
PE
9058 Don't assume time_t can fit into int.
9059 * buffer.h (struct buffer.modtime): Now time_t, not int.
9060 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9061 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9062
ccd9a01a
PE
9063 Minor fixes for signed vs unsigned integers.
9064 * character.h (MAYBE_UNIFY_CHAR):
9065 * charset.c (maybe_unify_char):
9066 * keyboard.c (read_char, reorder_modifiers):
9067 XINT -> XFASTINT, since the integer must be nonnegative.
9068 * ftfont.c (ftfont_spec_pattern):
9069 * keymap.c (access_keymap, silly_event_symbol_error):
9070 XUINT -> XFASTINT, since the integer must be nonnegative.
9071 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9072 since it makes no difference and we prefer signed.
9073 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9074 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9075 nonnegative.
9076
d6d100dd
SM
90772011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9078
9079 * window.h (Fwindow_frame): Declare.
9080
2b6148e4
PE
90812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9082
9083 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9084 (SPARE_MEMORY): Always define.
9085 (LARGE_REQUEST): Remove.
9086 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9087
f230ecc9
MR
90882011-06-06 Martin Rudalics <rudalics@gmx.at>
9089
727e958e
MR
9090 * lisp.h: Move EXFUNS for Fframe_root_window,
9091 Fframe_first_window and Fset_frame_selected_window to window.h.
9092
9093 * window.h: Move EXFUNS for Fframe_root_window,
9094 Fframe_first_window and Fset_frame_selected_window here from
9095 lisp.h.
9096
9097 * frame.c (Fwindow_frame, Fframe_first_window)
9098 (Fframe_root_window, Fframe_selected_window)
9099 (Fset_frame_selected_window): Move to window.c.
9100 (Factive_minibuffer_window): Move to minibuf.c.
9101 (Fother_visible_frames_p): New function.
9102
9103 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9104
f230ecc9
MR
9105 * window.c (decode_window, decode_any_window): Move up in code.
9106 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9107 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9108 (Fwindow_buffer): Move up and rewrite doc-string.
9109 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9110 (Fwindow_prev): New functions.
727e958e
MR
9111 (Fwindow_frame): Move here from frame.c. Accept any window as
9112 argument.
9113 (Fframe_root_window, Fframe_first_window)
9114 (Fframe_selected_window): Move here from frame.c. Accept frame
9115 or arbitrary window as argument. Update doc-strings.
9116 (Fminibuffer_window): Move up in code.
9117 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9118 (Fset_frame_selected_window): Move here from frame.c.
9119 Marginal rewrite.
727e958e
MR
9120 (Fselected_window, select_window, Fselect_window): Move up in
9121 code. Minor doc-string fixes.
f230ecc9 9122
4d09bcf6
PE
91232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9124
9125 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9126 Do not assume that spare memory exists; that assumption is valid
9127 only if SYSTEM_MALLOC.
9128 (LARGE_REQUEST): New macro, so that the issue of large requests
9129 is separated from the issue of spare memory.
9130
810928a2
AS
91312011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9132
172418ad
AS
9133 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9134 format. (Bug#8806)
9135
43f862f7
AS
9136 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9137
810928a2
AS
9138 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9139 before statements.
9140
a059fe24
JD
91412011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9142
9143 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9144
9145 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9146
9147 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9148 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9149
989bf368
JB
91502011-06-05 Juanma Barranquero <lekktu@gmail.com>
9151
9152 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9153
4b80f674
CY
91542011-06-04 Chong Yidong <cyd@stupidchicken.com>
9155
9156 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9157 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9158 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9159 New error handlers.
4b80f674
CY
9160 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9161 Obey Vx_select_enable_clipboard_manager. Catch errors in
9162 x_clipboard_manager_save (Bug#8779).
9163 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9164 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9165
99a33b77 91662011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9167
9168 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9169
99a33b77 91702011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9171
9172 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9173 in the current matrix if keep_current_p is non-zero.
9174
8264569d
EZ
91752011-06-04 Eli Zaretskii <eliz@gnu.org>
9176
9177 * bidi.c (bidi_level_of_next_char): Fix last change.
9178
57f97249
EZ
91792011-06-03 Eli Zaretskii <eliz@gnu.org>
9180
fec2107c 9181 Support bidi reordering of text covered by display properties.
57f97249 9182
fec2107c
EZ
9183 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9184 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9185 (bidi_cache_search, bidi_cache_iterator_state)
9186 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9187 (bidi_level_of_next_char, bidi_move_to_visually_next):
9188 Support character positions inside a run of characters covered by a
fec2107c
EZ
9189 display string.
9190 (bidi_paragraph_init, bidi_resolve_explicit_1)
9191 (bidi_level_of_next_char): Call bidi_fetch_char and
9192 bidi_fetch_char_advance instead of FETCH_CHAR and
9193 FETCH_CHAR_ADVANCE.
9194 (bidi_init_it): Initialize new members.
9195 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9196 definitions.
9197 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9198 instead of using explicit *_CHAR codes.
d6d100dd
SM
9199 (bidi_resolve_explicit, bidi_resolve_weak):
9200 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9201 bidirectional text is supported only in multibyte buffers.
9202 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9203 it to initialize the frame_window_p member of struct bidi_it.
9204 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9205 (bidi_resolve_explicit, bidi_resolve_weak)
9206 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9207 bidi_it->nchars is non-positive.
9208 (bidi_level_of_next_char): Don't try to lookup the cache for the
9209 next/previous character if nothing is cached there yet, or if we
9210 were just reseat()'ed to a new position.
c40e2fb2 9211
0e14fe90
EZ
9212 * xdisp.c (set_cursor_from_row): Set start and stop points
9213 according to the row's direction when priming the loop that looks
9214 for the glyph on which to display cursor.
9215 (single_display_spec_intangible_p): Function deleted.
9216 (display_prop_intangible_p): Reimplement to call
9217 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9218 Accept 3 additional arguments needed by handle_display_spec.
9219 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9220 values: lists, `(when COND...)' forms, etc.
9221 (single_display_spec_string_p): Support property values that are
9222 lists with the argument STRING its top-level element.
9223 (display_prop_string_p): Fix the condition for processing a
9224 property that is a list to be consistent with handle_display_spec.
fec2107c 9225 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9226 last portion of handle_display_prop.
9227 (compute_display_string_pos): Accept additional argument
9228 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9229 value of a `display' property is a "replacing spec".
9230 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9231 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9232 the display property, but just return a value indicating whether
9233 the display property will replace the characters it covers.
9234 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9235 frame_window_p members of struct bidi_it.
d6d100dd
SM
9236 (compute_display_string_pos, compute_display_string_end):
9237 New functions.
fec2107c
EZ
9238 (push_it): Accept second argument POSITION, where pop_it should
9239 jump to continue iteration.
9240 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9241
fec2107c
EZ
9242 * keyboard.c (adjust_point_for_property): Adjust the call to
9243 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9244
9245 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9246 (bidi_init_it): Update prototypes.
9247 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9248 (compute_display_string_pos, compute_display_string_end):
9249 Declare prototypes.
fec2107c
EZ
9250 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9251 EMACS_INT.
fc6f18ce 9252
40087514 92532011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9254
57f53182
PE
9255 Malloc failure behavior now depends on size of allocation.
9256 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9257 * lisp.h: Change signatures accordingly.
9258 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9259 All callers changed. (Bug#8762)
9260
9261 * gnutls.c: Use Emacs's memory allocators.
9262 Without this change, the gnutls library would invoke malloc etc.
9263 directly, which causes problems on non-SYNC_INPUT hosts, and which
9264 runs afoul of improving memory_full behavior. (Bug#8761)
9265 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9266 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9267 xfree instead of the default malloc, realloc, free.
9268 (Fgnutls_boot): No need to check for memory allocation failure,
9269 since xmalloc does that for us.
9270
ac32cd99 9271 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9272 * category.c (hash_get_category_set):
9273 * ccl.c (ccl_driver):
9274 * charset.c (Fdefine_charset_internal):
9275 * charset.h (struct charset.hash_index):
9276 * composite.c (get_composition_id, gstring_lookup_cache)
9277 (composition_gstring_put_cache):
9278 * composite.h (struct composition.hash_index):
9279 * dispextern.h (struct image.hash):
9280 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9281 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9282 (hashfn_equal, hashfn_user_defined, make_hash_table)
9283 (maybe_resize_hash_table, hash_lookup, hash_put)
9284 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9285 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9286 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9287 * image.c (make_image, search_image_cache, lookup_image)
9288 (xpm_put_color_table_h):
9289 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9290 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9291 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9292 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9293 * alloc.c (allocate_vectorlike):
9294 Check for overflow in vector size calculations.
9295 * ccl.c (ccl_driver):
9296 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9297 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9298 need to be updated by these changes.
40087514
PE
9299 * fns.c (make_hash_table, maybe_resize_hash_table):
9300 Check for integer overflow with large hash tables.
0de4bb68
PE
9301 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9302 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9303 (SXHASH_REDUCE): New macro.
9304 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9305 Use it instead of discarding useful hash info with large hash values.
9306 (sxhash_float): New function.
9307 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9308 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9309 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9310 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9311 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9312 Adjust signatures to match updated version of code.
9313 (consing_since_gc): Now EMACS_INT, since a single hash table can
9314 use more than INT_MAX bytes.
9315
698d32e2
DN
93162011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9317
9318 Make it possible to build with GCC-4.6+ -O2 -flto.
9319
9320 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9321
fd6fa53f
SM
93222011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9323
9324 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9325 Call minibuffer-inactive-mode.
9326
864db017
JB
93272011-05-31 Juanma Barranquero <lekktu@gmail.com>
9328
9329 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9330 Update dependencies.
9331
2ad0baf4
DN
93322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9333
9334 * data.c (init_data): Remove code for UTS, this system is not
9335 supported anymore.
9336
4fcc2638
DN
93372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9338
9339 Don't force ./temacs to start in terminal mode.
9340
9341 * frame.c (make_initial_frame): Initialize faces in all cases, not
9342 only when CANNOT_DUMP is defined.
9343 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9344
c56e0fd5
DN
93452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9346
9347 * dispnew.c (add_window_display_history): Use const for the string
9348 pointer. Remove declaration, not needed.
9349
333d54da 93502011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9351
55d4c1b2 9352 Use 'inline', not 'INLINE'.
333d54da 9353 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9354 * alloc.c, fontset.c (INLINE): Remove.
9355 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9356 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9357 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9358 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9359 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9360
738db178
DN
93612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9362
9363 Make it possible to run ./temacs.
9364
9365 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9366 syms_of_callproc does the same thing. Remove test for
9367 "initialized", do it in the caller.
9368 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9369
620c53a6
SM
93702011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9371
9372 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9373 (read_minibuf): Use get_minibuffer.
9374 (syms_of_minibuf): Use DEFSYM.
9375 (Qmetadata): New var.
9376 * data.c (Qbuffer): Don't make it static.
9377 (syms_of_data): Use DEFSYM.
9378
e003a292
PE
93792011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9380
9381 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9382 (CCL_CODE_MIN): New macro.
9383
ed008a6d
PE
93842011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9385
3687c2ef
PE
9386 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9387
ed008a6d
PE
9388 * eval.c (Qdebug): Now static.
9389 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9390 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9391 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9392
d66c4c7c
CY
93932011-05-29 Chong Yidong <cyd@stupidchicken.com>
9394
9395 * image.c: Various fixes to ImageMagick code comments.
9396 (Fimagemagick_types): Doc fix.
9397
5fbc2025
PE
93982011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9399
0196f88a
PE
9400 Minor fixes prompted by GCC 4.6.0 warnings.
9401
9402 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9403
5fbc2025
PE
9404 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9405 (x_clipboard_manager_save_all): Move extern decl to ...
9406 * xterm.h: ... here, so that it can be checked for consistency.
9407
1dd3c2d9
CY
94082011-05-29 Chong Yidong <cyd@stupidchicken.com>
9409
9410 * xselect.c (x_clipboard_manager_save_frame)
9411 (x_clipboard_manager_save_all): New functions.
9412 (Fx_clipboard_manager_save): Lisp function deleted.
9413
9414 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9415 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9416
9417 * xterm.h: Update prototype.
9418
5ba6571d
WX
94192011-05-28 William Xu <william.xwl@gmail.com>
9420
9421 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9422 exiting (Bug#8239).
9423
3eaff834
JM
94242011-05-28 Jim Meyering <meyering@redhat.com>
9425
e1900994 9426 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9427 * fns.c (to_uchar): Define.
9428 (crypto_hash_function): Use it to convert some newly-signed
9429 variables to unsigned, to avoid sign-extension bugs. For example,
9430 without this change, (md5 "truc") would evaluate to
9431 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9432 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9433 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9434
0f6990a7
PE
94352011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9436
9437 Integer overflow fixes.
c8a9ca5a 9438
08686060
PE
9439 * dbusbind.c: Serial number integer overflow fixes.
9440 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9441 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9442 to hold a serial number that is too large for a fixnum.
9443 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9444 Check for serial numbers out of range. Decode any serial number
59568bf0 9445 that was so large that it became a float. (Bug#8722)
08686060 9446
2d1fc3c7
PE
9447 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9448 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9449 Use XFASTINT rather than XUINT when numbers are nonnegative.
9450 (xd_append_arg, Fdbus_method_return_internal):
9451 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9452 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9453 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9454 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9455 (Bug#8722)
2d1fc3c7 9456
c8a9ca5a
PE
9457 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9458
519e1d69
PE
9459 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9460
6df6ae42 9461 ccl: Add integer overflow checks.
30569699
PE
9462 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9463 (IN_INT_RANGE): New macros.
9464 (ccl_driver): Use them to check for integer overflow when
9465 decoding a CCL program. Many of the new checks are whether XINT (x)
9466 fits in int; it doesn't always, on 64-bit hosts. The new version
9467 doesn't catch all possible integer overflows, but it's an
847044ea 9468 improvement. (Bug#8719)
30569699 9469
c11285dc
PE
9470 * alloc.c (make_event_array): Use XINT, not XUINT.
9471 There's no need for unsigned here.
9472
fdccd48e
PE
9473 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9474 This follows up to the 2011-05-06 change that substituted uintptr_t
9475 for EMACS_INT. This case wasn't caught back then.
9476
37910ab2
PE
9477 Rework Fformat to avoid integer overflow issues.
9478 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9479 now (part of C89). Include <verify.h>.
9480 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9481 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9482 (Fformat): Avoid the prepass trying to compute sizes; it was only
9483 approximate and thus did not catch overflow reliably. Instead, walk
9484 through the format just once, formatting and computing sizes as we go,
9485 checking for integer overflow at every step, and allocating a larger
9486 buffer as needed. Keep track separately whether the format is
9487 multibyte. Keep only the most-recently calculated precision, rather
9488 than them all. Record whether each argument has been converted to
9489 string. Use EMACS_INT, not int, for byte and char and arg counts.
9490 Support field widths and precisions larger than INT_MAX. Avoid
9491 sprintf's undefined behavior with conversion specifications such as %#d
9492 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9493 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9494 formatting out-of-range floating point numbers with int
9173deec 9495 formats. (Bug#8668)
37910ab2 9496
2e6578fb
PE
9497 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9498
0ae6bdee
PE
9499 * data.c: Avoid integer truncation in expressions involving floats.
9500 * data.c: Include <intprops.h>.
9501 (arith_driver): When there's an integer overflow in an expression
9502 involving floating point, convert the integers to floating point
9503 so that the resulting value does not suffer from catastrophic
9504 integer truncation. For example, on a 64-bit host (* 4
9505 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9506 Do not rely on undefined behavior after integer overflow.
9507
de883a70
PE
9508 merge count_size_as_multibyte, parse_str_to_multibyte
9509 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9510 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9511 Check for integer overflow.
9512 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9513 since it's now a duplicate of the other. This is more of
9514 a character than a buffer op, so better that it's in character.c.
9515 * fns.c, print.c: Adjust to above changes.
9516
2ff916cb
PE
95172011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9518
9519 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9520
f1b54466
PE
95212011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9522
fb1ac845
PE
9523 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9524 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9525 (x_clipboard_manager_save): Now static.
9526 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9527
f1b54466
PE
9528 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9529 (crypto_hash_function): Now static.
9530 Fix pointer signedness problems. Avoid unnecessary initializations.
9531
a9f737ee
CY
95322011-05-27 Chong Yidong <cyd@stupidchicken.com>
9533
9534 * termhooks.h (Vselection_alist): Make it terminal-local.
9535
9536 * terminal.c (create_terminal): Initialize it.
9537
9538 * xselect.c: Support for clipboard managers.
9539 (Vselection_alist): Move to termhooks.h as terminal-local var.
9540 (LOCAL_SELECTION): New macro.
9541 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9542 (symbol_to_x_atom): Remove gratuitous arg.
9543 (x_handle_selection_request, lisp_data_to_selection_data)
9544 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9545 (x_own_selection, x_get_local_selection, x_convert_selection):
9546 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9547 (some_frame_on_display): Delete unused function.
9548 (Fx_own_selection_internal, Fx_get_selection_internal)
9549 (Fx_disown_selection_internal, Fx_selection_owner_p)
9550 (Fx_selection_exists_p): New optional frame arg.
9551 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9552 (x_handle_selection_clear): Don't treat other terminals with the
9553 same keyboard specially. Use the terminal-local Vselection_alist.
9554 (x_clear_frame_selections): Use Frun_hook_with_args.
9555
9556 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9557
9558 * xterm.h: Add support for those atoms.
9559
e067f0c1
CY
95602011-05-26 Chong Yidong <cyd@stupidchicken.com>
9561
9562 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9563 (converted_selections, conversion_fail_tag): New global variables.
9564 (x_selection_request_lisp_error): Free the above.
9565 (x_get_local_selection): Remove unnecessary code.
9566 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9567 of converted selections stored in converted_selections.
9568 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9569 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9570 (x_convert_selection): New function.
9571 (x_handle_selection_event): Simplify.
9572 (x_get_foreign_selection): Don't ignore incoming requests while
9573 waiting for an answer; this will fail when we implement
9574 SAVE_TARGETS, and seems unnecessary anyway.
9575 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9576 (Vx_sent_selection_functions): Doc fix.
9577
0f4aebc0
LL
95782011-05-26 Leo Liu <sdl.web@gmail.com>
9579
9580 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9581
e61124cd
YM
95822011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9583
9584 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9585
9586 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9587 for fringe update if it has periodic bitmap.
ac389d0c 9588 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9589 and fringe_bitmap_periodic_p.
9590
9591 * fringe.c (get_fringe_bitmap_data): New function.
9592 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9593 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9594 row. Mark glyph row for fringe update if periodicity changed.
9595
9596 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9597 for fringe update unless it has periodic bitmap.
9598
f16d9837
KH
95992011-05-25 Kenichi Handa <handa@m17n.org>
9600
9601 * xdisp.c (get_next_display_element): Set correct it->face_id for
9602 a static composition.
9603
e1b90ef6
LL
96042011-05-24 Leo Liu <sdl.web@gmail.com>
9605
9606 * deps.mk (fns.o):
9607 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9608
9609 * fns.c (crypto_hash_function, Fsha1): New function.
9610 (Fmd5): Use crypto_hash_function.
9611 (syms_of_fns): Add Ssha1.
9612
7400048f
PE
96132011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9614
9615 * gnutls.c: Remove unused macros.
9616 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9617 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9618 Remove macros that are defined and never used.
9619 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9620
abb71cf4
CY
96212011-05-22 Chong Yidong <cyd@stupidchicken.com>
9622
9623 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9624 (Fx_get_selection_internal): Minor cleanup.
9625 (Fx_own_selection_internal): Rename arguments for consistency with
9626 select.el.
9627
6307db39
PE
96282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9629
9630 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9631
f3d4e0a4
CY
96322011-05-22 Chong Yidong <cyd@stupidchicken.com>
9633
9634 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9635
4d8ade89
YM
96362011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9637
9638 * dispnew.c (scrolling_window): Don't exclude the case that the
9639 last enabled row in the desired matrix touches the bottom boundary.
9640
32078c8d
GM
96412011-05-21 Glenn Morris <rgm@gnu.org>
9642
9643 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9644 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9645 and add some more files.
32078c8d 9646
7285dc67
EZ
96472011-05-20 Eli Zaretskii <eliz@gnu.org>
9648
9649 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9650 report_file_error introduced by the change from 2011-05-07.
9651
89d1bd22
PE
96522011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9653
9654 * systime.h (Time): Define only if emacs is defined.
9655 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9656 where the include path doesn't have X11/X.h by default. See
9657 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9658
cd394be1 96592011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9660
9661 * composite.c (find_automatic_composition): Fix previous change.
9662
b9704ad9
GM
96632011-05-20 Glenn Morris <rgm@gnu.org>
9664
9665 * lisp.mk: New file, split from Makefile.in.
9666 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9667 (shortlisp): Remove.
9668 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9669
4a720484
GM
96702011-05-19 Glenn Morris <rgm@gnu.org>
9671
9672 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9673 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9674 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9675 (lisp): Set the order to that of loadup.el.
9676 (shortlisp): Make it a copy of $lisp.
9677 (SOME_MACHINE_LISP): Remove.
9678 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9679 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9680
a28d4396
KH
96812011-05-18 Kenichi Handa <handa@m17n.org>
9682
9683 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9684 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9685 (find_automatic_composition): Mostly rewrite for efficiency.
9686
a2b1fa8e
JB
96872011-05-18 Juanma Barranquero <lekktu@gmail.com>
9688
9689 * makefile.w32-in: Update dependencies.
9690
8e1f5610
CS
96912011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9692
9693 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9694 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9695
7025ee00 96962011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9697
cdfa6eab
PE
9698 Fix some integer overflow issues, such as string length overflow.
9699
06d6db33
PE
9700 * insdel.c (count_size_as_multibyte): Check for string overflow.
9701
2b4560a8
PE
9702 * character.c (lisp_string_width): Check for string overflow.
9703 Use EMACS_INT, not int, for string indexes and lengths; in
9704 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9705 the resulting string length overflows an EMACS_INT; instead,
9706 report a string overflow if no precision given. When checking for
9707 precision exhaustion, use a check that cannot possibly have
9708 integer overflow. (Bug#8675)
9709 * character.h (lisp_string_width): Adjust to new signature.
9710
cb93f9be
PE
9711 * alloc.c (string_overflow): New function.
9712 (Fmake_string): Use it. This doesn't change behavior, but saves
9713 a few bytes and will simplify future changes.
9714 * character.c (string_escape_byte8): Likewise.
9715 * lisp.h (string_overflow): New decl.
9716
1a1f3366
PE
9717 Fixups, following up to the user-interface timestamp change.
9718 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9719 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9720 * msdos.c (mouse_get_pos): Likewise.
9721 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9722 * w32gui.h (Time): Define by including "systime.h" rather than by
9723 declaring it ourselves. (Bug#8664)
9724
d4e3e4d3
PE
9725 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9726 * image.c (clear_image_cache): Likewise.
9727
f6a24d19
PE
9728 * term.c (term_mouse_position): Don't assume time_t wraparound.
9729
08dc5ae6
PE
9730 Be more systematic about user-interface timestamps.
9731 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9732 and sometimes 'EMACS_UINT', to represent these timestamps.
9733 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9734 This makes the code easier to follow, and makes it easier to catch
9735 integer overflow bugs such as Bug#8664.
9736 * frame.c (Fmouse_position, Fmouse_pixel_position):
9737 Use Time, not unsigned long, for user-interface timestamps.
9738 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9739 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9740 * keyboard.h (last_event_timestamp): Likewise.
9741 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9742 * menu.h (xmenu_show): Likewise.
9743 * term.c (term_mouse_position): Likewise.
9744 * termhooks.h (struct input_event.timestamp): Likewise.
9745 (struct terminal.mouse_position_hook): Likewise.
9746 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9747 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9748 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9749 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9750 what it was before.
9751 * menu.h, termhooks.h: Include "systime.h", for Time.
9752
8e55734a
PE
9753 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9754 Don't assume that the difference between two unsigned long values
9755 can fit into an integer. At this point, we know button_down_time
9756 <= event->timestamp, so the difference must be nonnegative, so
9757 there's no need to cast the result if double-click-time is
9758 nonnegative, as it should be; check that it's nonnegative, just in
9759 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9760 apart (about 25 days). (Bug#8664)
8e55734a 9761
841f1b75 9762 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9763 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9764
3e26f69c
PE
9765 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9766 that always fit in int. Use a sentinel instead of a counter, to
9767 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9768 * frame.h (struct frame): Use int for menu_bar_items_used
9769 instead of EMACS_INT, since it always fits in int.
3e26f69c 9770
5cc152c0
PE
9771 * menu.c (grow_menu_items): Check for int overflow.
9772
d89eb65e
PE
9773 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9774
5235bd3e
PE
9775 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9776 Before, the code was not consistent. These values cannot exceed
9777 2**31 - 1 so there's no need to make them unsigned.
9778 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9779 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9780 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9781 as modifiers.
9782 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9783
bc827e23
PE
9784 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9785 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9786 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9787 presumably because the widths might not match.
9788
78eb494e
PE
9789 * window.c (size_window): Avoid needless test at loop start.
9790
04f2d78b
CB
97912011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9792
9793 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9794
d2fc7e3d 97952011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9796
9797 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9798
d2fc7e3d 97992011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9800
9801 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9802 `width' to `bar_area_x' and `bar_area_width', respectively.
9803 (x_scroll_run): Take account of fringe background extension.
9804
04f2d78b
CB
9805 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9806 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9807 `bar_area_width', respectively.
9808 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9809 background extension.
9810
79b70037
GM
98112011-05-10 Jim Meyering <meyering@redhat.com>
9812
9813 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9814
2f142cc5
JB
98152011-05-10 Juanma Barranquero <lekktu@gmail.com>
9816
9817 * image.c (Finit_image_library): Return t for built-in image types,
9818 like pbm and xbm. (Bug#8640)
9819
57679c86
AS
98202011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9821
9822 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9823
888c9e86
EZ
98242011-05-07 Eli Zaretskii <eliz@gnu.org>
9825
b0512a1d
EZ
9826 * w32console.c (Fset_screen_color): Doc fix.
9827 (Fget_screen_color): New function.
9828 (syms_of_ntterm): Defsubr it.
9829
7285dc67
EZ
9830 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9831 unlink the temporary file if Fcall_process didn't create it in the
9832 first place.
9833 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9834 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9835 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9836 cue to call_process_cleanup not to close that handle.
9837
4d3fcc8e
BK
98382011-05-07 Ben Key <bkey76@gmail.com>
9839
9840 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9841 one of two shell specific rules, either bootstrap-temacs-CMD or
9842 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9843 to the previous implementation of the bootstrap-temacs rule.
9844 The bootstrap-temacs-CMD rule is similar to the previous
9845 implementation of the bootstrap-temacs rule except that it
9846 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9847 variable.
9848
9849 These changes, along with some changes to nt/configure.bat,
9850 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9851 earlier fix to add support for --cflags and --ldflags options
9852 that include quotes so that it works whether make uses cmd or
9853 sh as the shell.
9854
b4289b64
MA
98552011-05-06 Michael Albinus <michael.albinus@gmx.de>
9856
9857 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9858 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9859 is a constant.
9860 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9861 a string. Handle both cases.
9862 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9863 (Fdbus_register_method): Use Qinvalid_function.
9864
af4c0e28
JB
98652011-05-06 Juanma Barranquero <lekktu@gmail.com>
9866
9867 * makefile.w32-in: Update dependencies.
9868 (LISP_H): Add inttypes.h and stdin.h.
9869 (PROCESS_H): Add unistd.h.
9870
c51453d9
EZ
98712011-05-06 Eli Zaretskii <eliz@gnu.org>
9872
9873 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9874 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9875
8ff0ac3c 98762011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9877
4c4b566b
PE
9878 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9879
aab2b9b5
PE
9880 * term.c (vfatal): Remove stray call to va_end.
9881 It's not needed and the C Standard doesn't allow it here anyway.
9882
c378da0b
PE
9883 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9884 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9885
288b08c7
PE
9886 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9887 bytes.
9888
e3601888
PE
9889 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9890
db6c0e74
PE
9891 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9892
dd5963ea
PE
9893 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9894
88c9450f
PE
9895 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9896
2f9442b8
PE
9897 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9898
c032b5f8
PE
9899 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9900 * charset.c (Fdefine_charset_internal): Don't initialize
9901 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9902 32-bit int (Bug#8600).
a108c10b
PE
9903
9904 * lread.c (read_integer): Be more consistent with string-to-number.
9905 Use string_to_number to do the actual conversion; this avoids
9906 rounding errors and fixes some other screwups. Without this fix,
9907 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9908 (digit_to_number): Move earlier, for benefit of read_integer.
9909 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9910 not a digit in any supported base. (Bug#8602)
a108c10b 9911
ad5f9eea
PE
9912 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9913
aec1708a
PE
9914 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9915 to match comment at start of function. This also removes a
9916 GCC warning about overflow in a 32+64-bit port.
9917
47be4ab5
PE
9918 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9919
371cac43
PE
9920 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9921 Reported by Stefan Monnier in
9922 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9923 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9924 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9925
d01a7826
PE
9926 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9927 (EMACS_UINTPTR): Likewise, with uintptr_t.
9928
7fd47d5c
PE
9929 * lisp.h: Prefer 64-bit EMACS_INT if available.
9930 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9931 on 32-bit hosts that have 64-bit int, so that they can access
9932 large files.
122b0c86
PE
9933 However, temporarily disable this change unless the temporary
9934 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9935
8727937b
PE
9936 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9937
8ac068ac
PE
9938 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9939 This removes an assumption that EMACS_INT and long are the same
9940 width as pointers. The assumption is true for Emacs porting targets
9941 now, but we want to make other targets possible.
9942 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9943 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9944 In the rest of the code, change types of integers that hold casted
9945 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9946 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9947 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9948 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9949 No need to cast type when ORing.
9950 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9951 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9952 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9953 assume EMACS_INT is the same width as char *.
9954 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9955 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9956 Remove no-longer-needed casts.
9957 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9958 (xg_tool_bar_help_callback, xg_make_tool_item):
9959 Use EMACS_INTPTR to hold an integer
9960 that will be cast to void *; this can avoid a GCC warning
9961 if EMACS_INT is not the same width as void *.
9962 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9963 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9964 (current_message_1, set_message_1):
9965 Use a local to convert to proper width without a cast.
9966 * xmenu.c (dialog_selection_callback): Likewise.
9967
ede49d71
PE
9968 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9969 Also, don't assume VALBITS / RAND_BITS is less than 5,
9970 and don't rely on undefined behavior when shifting a 1 left into
9971 the sign bit.
9972 * lisp.h (get_random): Change signature to match.
9973
2f30ecd0
PE
9974 * lread.c (hash_string): Use size_t, not int, for hash computation.
9975 Normally we prefer signed values; but hashing is special, because
9976 it's better to use unsigned division on hash table sizes so that
9977 the remainder is nonnegative. Also, size_t is the natural width
9978 for hashing into memory. The previous code used 'int', which doesn't
9979 retain enough info to hash well into very large tables.
9980 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9981
2a866e7b
PE
9982 * dbusbind.c: Don't possibly lose pointer info when converting.
9983 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9984 Use XPNTR rather than XHASH, so that the high-order bits of
9985 the pointer aren't lost when converting through void *.
9986
51639eac
PE
9987 * eval.c (Fautoload): Don't double-shift a pointer.
9988
92394119
PE
9989 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9990
dbdb9a7c
JB
99912011-05-06 Juanma Barranquero <lekktu@gmail.com>
9992
9993 * gnutls.c (DEF_GNUTLS_FN):
9994 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9995
db7a0b4f
AS
99962011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9997
9998 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9999 marker. (Bug#8610)
10000
cd394be1 100012011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10002
10003 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10004 New version that can reserve upto 2GB of heap space.
10005
f7ff1b0f 100062011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10007
10008 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10009
639c109b
TZ
100102011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10011
10012 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10013 `gnutls_certificate_set_x509_key_file'.
10014
d2127135
JB
100152011-05-05 Juanma Barranquero <lekktu@gmail.com>
10016
10017 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10018 Update dependencies.
10019
e968f4f3
JB
100202011-05-04 Juanma Barranquero <lekktu@gmail.com>
10021
10022 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10023 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10024 Remove unused parameter `fildes'.
10025 * process.c (read_process_output, send_process): Don't pass it.
10026
84d358f0
JB
100272011-05-04 Juanma Barranquero <lekktu@gmail.com>
10028
10029 Fix previous change: the library cache is defined in w32.c.
10030 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10031 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10032
0898ca10
JB
100332011-05-04 Juanma Barranquero <lekktu@gmail.com>
10034
10035 Implement dynamic loading of GnuTLS on Windows.
10036
10037 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10038 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10039 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10040 Declare.
10041
10042 * gnutls.c (Qgnutls_dll): Define.
10043 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10044 (gnutls_*): Declare function pointers.
10045 (init_gnutls_functions): New function to initialize function pointers.
10046 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10047 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10048 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10049 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10050 (emacs_gnutls_write, emacs_gnutls_read)
10051 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10052 (Fgnutls_available_p): New function.
10053 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10054 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10055 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10056
10057 * image.c: Include w32.h.
10058 (Vimage_type_cache): Delete.
10059 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10060 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10061 (w32_delayed_load): Move to w32.c.
10062
10063 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10064
10065 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10066 (w32_delayed_load): Move from image.c. When loading a library, record
10067 its filename in the :loaded-from property of the library id.
10068 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10069 Initialize and staticpro them.
10070 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10071
10072 * process.c: Include lisp.h before w32.h, not after.
10073 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10074 instead of gnutls_record_check_pending.
10075
10076 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10077
ff4de4aa
TZ
100782011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10079
10080 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10081 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10082 as passed in.
10083
abe95abb
JD
100842011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10085
10086 * xterm.c (x_set_frame_alpha): Do not set property on anything
10087 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10088
e16e55d4
JB
100892011-05-02 Juanma Barranquero <lekktu@gmail.com>
10090
10091 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10092
bafcf6a5
JB
100932011-05-02 Juanma Barranquero <lekktu@gmail.com>
10094
10095 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10096 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10097 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10098 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10099 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10100 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10101 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10102 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10103 (Qgnutls_bootprop_callbacks_verify): Make static.
10104
e7a6747f
AS
101052011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10106
19ed11ba
AS
10107 * callproc.c: Indentation fixup.
10108
e7a6747f 10109 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10110 (wait_for_termination, interruptible_wait_for_termination):
10111 Move after wait_for_termination_1.
e7a6747f 10112
1ef14cb4
LMI
101132011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10114
10115 * sysdep.c (interruptible_wait_for_termination): New function
10116 which is like wait_for_termination, but allows keyboard
10117 interruptions.
10118
10119 * callproc.c (Fcall_process): Add (:file "file") as an option for
10120 the STDOUT buffer.
10121 (Fcall_process_region): Ditto.
10122
330d880c
EZ
101232011-04-30 Eli Zaretskii <eliz@gnu.org>
10124
8db90b73
EZ
10125 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10126 rather than `XVECTOR (FOO)->size'.
10127
330d880c
EZ
10128 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10129 inttypes.h, as a gnulib replacement is used if it not available in
10130 system headers.
10131
15cbd324
EZ
101322011-04-21 Eli Zaretskii <eliz@gnu.org>
10133
10134 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10135 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10136 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10137
10138 * coding.c (coding_alloc_by_realloc): Error out if destination
10139 will grow beyond MOST_POSITIVE_FIXNUM.
10140 (decode_coding_emacs_mule): Abort if there isn't enough place in
10141 charbuf for the composition carryover bytes. Reserve an extra
10142 space for up to 2 characters produced in a loop.
10143 (decode_coding_iso_2022): Abort if there isn't enough place in
10144 charbuf for the composition carryover bytes.
10145
101462011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10147
ae940cca
EZ
10148 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10149 aborting when %lld or %lll format is passed.
10150 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10151 %llo or %llx format is passed. (Bug#8545)
10152
03ab8921
EZ
10153 * window.c (window_scroll_line_based): Use a marker instead of
10154 simple variables to record original value of point. (Bug#7952)
10155
afda1437
EZ
10156 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10157 produced by %s or %c overflows available buffer space. (Bug#8545)
10158
f76dee0c
PE
101592011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10160
10161 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10162 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10163
fdc5744d
JB
101642011-04-28 Juanma Barranquero <lekktu@gmail.com>
10165
10166 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10167
638f053a
JB
101682011-04-28 Juanma Barranquero <lekktu@gmail.com>
10169
10170 * keyboard.c (Qdelayed_warnings_hook): Define.
10171 (command_loop_1): Run `delayed-warnings-hook'
10172 if Vdelayed_warnings_list is non-nil.
10173 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10174 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10175
d178f871
EZ
101762011-04-28 Eli Zaretskii <eliz@gnu.org>
10177
10178 * doprnt.c (doprnt): Don't return value smaller than the buffer
10179 size if the message was truncated. (Bug#8545).
10180
b124fd93
JB
101812011-04-28 Juanma Barranquero <lekktu@gmail.com>
10182
10183 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10184 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10185
e810457d
PE
101862011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10187
10188 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10189
ea51cceb
JB
101902011-04-27 Juanma Barranquero <lekktu@gmail.com>
10191
10192 * makefile.w32-in: Update dependencies.
10193
94dcfacf
EZ
101942011-04-27 Eli Zaretskii <eliz@gnu.org>
10195
10196 Improve `doprnt' and its usage. (Bug#8545)
10197 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10198 `format_end'. Remove support for %l as a conversion specifier.
10199 Don't use xrealloc. Improve diagnostics when the %l size modifier
10200 is used. Update the commentary.
10201
10202 * eval.c (verror): Simplify calculation of size_t.
10203
10204 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10205 messages.
10206
f61f41d7
PE
102072011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10208
10209 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10210 change.
10211
96fb4434
PE
102122011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10213
10214 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10215 This makes this file independent of the recent pseudovector change.
10216
671875da 102172011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10218
69e9b5a3
PE
10219 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10220
b5f869a7 10221 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10222 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10223 Remove unused local.
c8926152 10224 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10225
841a1577 10226 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10227 GCC 4.6.0 optimizes based on type-based alias analysis.
10228 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10229 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10230 != &v->size, and therefore "v->size = 1; b->size = 2; return
10231 v->size;" must therefore return 1. This assumption is incorrect
10232 for Emacs, since it type-puns struct Lisp_Vector * with many other
10233 types. To fix this problem, this patch adds a new type struct
f904488f 10234 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10235 and pseudovectors, and helps optimizing compilers not get fooled
10236 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10237 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10238 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10239 the size member.
eab3844f
PE
10240 (XSETPVECTYPE): Rewrite in terms of new macro.
10241 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10242 This is a bit clearer, and further avoids the possibility of
10243 undesirable aliasing.
10244 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10245 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10246 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10247 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10248 (ASIZE): Now uses header.size rather than size.
10249 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10250 to avoid the hassle of writing XVECTOR (foo)->header.size.
10251 (struct vectorlike_header): New type.
eab3844f
PE
10252 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10253 object, to help avoid aliasing.
10254 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10255 (SUBRP): Likewise, since Lisp_Subr is a special case.
10256 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10257 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10258 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10259 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10260 changed to be "header.size" and "header.next".
10261 * buffer.h (struct buffer): Likewise.
10262 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10263 * frame.h (struct frame): Likewise.
10264 * process.h (struct Lisp_Process): Likewise.
10265 * termhooks.h (struct terminal): Likewise.
10266 * window.c (struct save_window_data, struct saved_window): Likewise.
10267 * window.h (struct window): Likewise.
10268 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10269 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10270 * buffer.c (init_buffer_once): Likewise.
10271 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10272 special case.
10273 * process.c (Fformat_network_address): Use local var for size,
10274 for brevity.
10275
0df1eac5
PE
10276 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10277
847ab9d1 10278 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10279 * data.c (atof): Remove decl; no longer used or needed.
10280 (digit_to_number): Move to lread.c.
10281 (Fstring_to_number): Use new string_to_number function, to be
10282 consistent with how the Lisp reader treats infinities and NaNs.
10283 Do not assume that floating-point numbers represent EMACS_INT
10284 without losing information; this is not true on most 64-bit hosts.
10285 Avoid double-rounding errors, by insisting on integers when
10286 parsing non-base-10 numbers, as the documentation specifies.
10287 * lisp.h (string_to_number): New decl, replacing ...
10288 (isfloat_string): Remove.
bc0a5c13 10289 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10290 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10291 appears to have been a coding error. Similarly, do not accept
10292 strings like +-1e0 as floating point numbers. Do not report
10293 overflow for integer overflows unless the base is not 10 which
10294 means we have no simple and reliable way to continue.
10295 Break out the floating-point parsing into a new
10296 function string_to_number, so that Fstring_to_number parses
10297 floating point numbers consistently with the Lisp reader.
04f2d78b 10298 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10299 (E_CHAR, EXP_INT): Remove, replacing with ...
10300 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10301 (string_to_number): New function, replacing isfloat_string.
10302 This function checks for valid syntax and produces the resulting
10303 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10304 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10305 so that overflow for non-base-10 numbers is reported only when
10306 there's no portable and simple way to convert to floating point.
452f4150 10307
67769ffc
PE
10308 * textprop.c (set_text_properties_1): Rewrite for clarity,
10309 and to avoid GCC warning about integer overflow.
10310
c20db43f
PE
10311 * intervals.h (struct interval): Use EMACS_INT for members
10312 where EMACS_UINT might cause problems. See
10313 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10314 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10315 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10316 All uses changed.
37aa2f85
PE
10317 (offset_intervals): Tell GCC not to worry about length overflow
10318 when negating a negative length.
c20db43f 10319
2538aa2f
PE
10320 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10321 (overrun_check_free): Likewise.
10322
f2d3008d
PE
10323 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10324 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10325 word size.
10326
ec8df744
PE
10327 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10328 (gnutls_make_error): Rename local to avoid shadowing.
10329 (gnutls_emacs_global_deinit): ifdef out; not used.
10330 (Fgnutls_boot): Use const for pointer to readonly storage.
10331 Comment out unused local. Fix pointer signedness problems.
10332
640ee02d
PE
10333 * lread.c (openp): Don't stuff size_t into an 'int'.
10334 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10335 about possible signed overflow.
10336
6048fb2a
PE
10337 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10338 (GDK_KEY_g): Don't define if already defined.
10339 (xg_prepare_tooltip): Avoid pointer signedness problem.
10340 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10341
fa3c87e1
PE
10342 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10343 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10344
2172544b
PE
10345 * xfns.c (Fx_window_property): Simplify a bit,
10346 to make a bit faster and to avoid GCC 4.6.0 warning.
10347 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10348
9b821a21
PE
10349 * fns.c (internal_equal): Don't assume size_t fits in int.
10350
3c616cfa
PE
10351 * alloc.c (compact_small_strings): Tighten assertion a little.
10352
c2982e87
PE
10353 Replace pEd with more-general pI, and fix some printf arg casts.
10354 * lisp.h (pI): New macro, generalizing old pEd macro to other
10355 conversion specifiers. For example, use "...%"pI"d..." rather
10356 than "...%"pEd"...".
10357 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10358 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10359 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10360 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10361 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10362 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10363 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10364 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10365 64-bit hosts.
10366 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10367 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10368 * print.c (safe_debug_print, print_object): Likewise.
10369 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10370 to int.
6f04d126
PE
10371 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10372 avoiding the 0 flag, which is not portable.
c2982e87
PE
10373 * process.c (Fmake_network_process): Use pI to avoid cast.
10374 * region-cache.c (pp_cache): Likewise.
10375 * xdisp.c (decode_mode_spec): Likewise.
10376 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10377 behavior on 64-bit hosts with printf arg.
6f04d126 10378 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10379 (x_stop_queuing_selection_requests): Likewise.
10380 (x_get_window_property): Don't truncate byte count to an 'int'
10381 when tracing.
0b432f21 10382
5e073ec7
PE
10383 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10384 here, since it parses constructs like leading '-' and spaces,
10385 which are not wanted; and it overflows with large numbers.
10386 Instead, simply match F[0-9]+, which is what is wanted anyway.
10387
36372bf9
PE
10388 * alloc.c: Remove unportable assumptions about struct layout.
10389 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10390 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10391 (allocate_vectorlike, make_pure_vector): Use the new macros,
10392 plus offsetof, to remove unportable assumptions about struct layout.
10393 These assumptions hold on all porting targets that I know of, but
10394 they are not guaranteed, they're easy to remove, and removing them
10395 makes further changes easier.
10396
0b432f21
PE
10397 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10398 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10399 (string_overrun_cookie): Now const. Use initializers that
10400 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10401 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10402 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10403 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10404 multiple of sizeof (EMACS_INT); it need not be, if
10405 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10406 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10407
895009e1
JB
104082011-04-26 Juanma Barranquero <lekktu@gmail.com>
10409
10410 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10411
6a7a1b0b
TZ
104122011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10413
10414 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10415 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10416 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10417
841a1577 104182011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10419
10420 * lisp.h (Qdebug): List symbol.
895009e1 10421 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10422 * keyboard.c (debug-on-event): New variable.
10423 (handle_user_signal): Break into debugger when debug-on-event
10424 matches the current signal symbol.
10425
f2d3ba6f
DN
104262011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10427
10428 * alloc.c (check_sblock, check_string_bytes)
10429 (check_string_free_list): Convert to standard C.
10430
42ce4c63
TZ
104312011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10432
10433 * w32.c (emacs_gnutls_push): Fix typo.
10434
825cd63c
EZ
104352011-04-25 Eli Zaretskii <eliz@gnu.org>
10436
fb11d64d
EZ
10437 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10438 "cast to pointer from integer of different size".
10439
825cd63c
EZ
10440 Improve doprnt and its use in verror. (Bug#8545)
10441 * doprnt.c (doprnt): Document the set of format control sequences
10442 supported by the function. Use SAFE_ALLOCA instead of always
10443 using `alloca'.
10444
10445 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10446 is one byte too soon. Don't use xrealloc; instead xfree and
10447 xmalloc anew.
10448
e061a11b
TZ
104492011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10450
10451 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10452 callbacks stage.
10453
10454 * gnutls.c: Renamed global_initialized to
10455 gnutls_global_initialized. Added internals for the
10456 :verify-hostname-error, :verify-error, and :verify-flags
10457 parameters of `gnutls-boot' and documented those parameters in the
10458 docstring. Start callback support.
9173deec
JB
10459 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10460 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10461 on error. Return error code.
e061a11b
TZ
10462 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10463 (emacs_gnutls_read): Likewise.
10464 (Fgnutls_boot): Return handshake error code.
10465 (emacs_gnutls_handle_error): New function.
10466 (wsaerror_to_errno): Likewise.
10467
10468 * w32.h (emacs_gnutls_pull): Add prototype.
10469 (emacs_gnutls_push): Likewise.
10470
10471 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10472 (emacs_gnutls_push): Likewise.
10473
104742011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10475
10476 * process.c (wait_reading_process_output): Check if GnuTLS
10477 buffered some data internally if no FDs are set for TLS
10478 connections.
10479
10480 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10481 (LIBS): Link to USER_LIBS.
10482 ($(BLD)/gnutls.$(0)): New target.
10483
fa6996bc
EZ
104842011-04-24 Eli Zaretskii <eliz@gnu.org>
10485
eb35682e
EZ
10486 * xdisp.c (handle_single_display_spec): Rename the
10487 display_replaced_before_p argument into display_replaced_p, to
10488 make it consistent with the commentary. Fix typos in the
10489 commentary.
10490
e2ad650c
EZ
10491 * textprop.c (syms_of_textprop): Remove dead code.
10492 (copy_text_properties): Delete obsolete commentary about an
10493 interface that was deleted long ago. Fix typos in the description
10494 of arguments.
10495
1b2de274
EZ
10496 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10497 to changes in oldXMenu/XMenu.h from 2011-04-16.
10498 <menu_help_message, prev_menu_help_message>: Constify.
10499 (IT_menu_make_room): menu->help_text is now `const char **';
10500 adjust.
10501
10502 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10503 to changes in oldXMenu/XMenu.h from 2011-04-16.
10504 (struct XMenu): Declare `help_text' `const char **'.
10505
10506 * xfaces.c <Qunspecified>: Make extern again.
10507
10508 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10509 required by POSIX.
1b2de274 10510
762b15be
EZ
10511 * doc.c (get_doc_string): Improve the format passed to `error'.
10512
10513 * doprnt.c (doprnt): Improve commentary.
10514
10515 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10516
10517 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10518 them with etags.
10519
f1052e5d
EZ
10520 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10521 changes in globals.h immediately force recompilation.
762b15be
EZ
10522 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10523 $(CURDIR)/s/ms-w32.h.
10524 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10525
fa6996bc
EZ
10526 * character.c (Fchar_direction): Function deleted.
10527 (syms_of_character): Don't defsubr it.
10528 <char-direction-table>: Deleted.
10529
e6c3da20
EZ
105302011-04-23 Eli Zaretskii <eliz@gnu.org>
10531
10532 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10533 * doprnt.c: Include limits.h.
10534 (SIZE_MAX): New macro.
04f2d78b
CB
10535 (doprnt): Return a size_t value. 2nd arg is now size_t.
10536 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10537 Improve overflow protection. Support `l' modifier for integer
10538 conversions. Support %l conversion. Don't assume an EMACS_INT
10539 argument for integer conversions and for %c.
10540
10541 * lisp.h (doprnt): Restore prototype.
10542
10543 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10544 $(SRC)/character.h.
10545
10546 * Makefile.in (base_obj): Add back doprnt.o.
10547
10548 * deps.mk (doprnt.o): Add back prerequisites.
10549 (callint.o): Depend on character.h.
10550
10551 * eval.c (internal_lisp_condition_case): Include the handler
10552 representation in the error message.
10553 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10554 when breaking from the loop.
10555
10556 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10557
10558 * callint.c (Fcall_interactively): When displaying error message
10559 about invalid control letter, pass the character's codepoint, not
10560 a pointer to its multibyte form. Improve display of the character
10561 in octal and display also its hex code.
10562
10563 * character.c (char_string): Use %x to display the (unsigned)
10564 codepoint of an invalid character, to avoid displaying a bogus
10565 negative value.
10566
10567 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10568 `error', not SYMBOL_NAME itself.
10569
10570 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10571 character arguments to `error'.
10572
10573 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10574 to `error' in error message about FINAL_CHAR argument. Make sure
10575 FINAL_CHAR is a character, and use %c when it is passed as
10576 argument to `error'.
10577
4ffd0d6b 105782011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10579
10580 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10581
10582 * w32.c: Include <time.h>.
10583 (sys_localtime): New function.
10584
4ffd0d6b 105852011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10586
10587 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10588
4ffd0d6b 10589 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10590
4ffd0d6b 105912011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10592
4ffd0d6b
GM
10593 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10594 zombies (Bug#8467).
aac0c6e3 10595
04c56954
EZ
105962011-04-19 Eli Zaretskii <eliz@gnu.org>
10597
10598 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10599 gl_state.e_property when gl_state.object is Qt.
10600
10601 * insdel.c (make_gap_larger): Remove limitation of buffer size
10602 to <= INT_MAX.
10603
16a43933
CY
106042011-04-18 Chong Yidong <cyd@stupidchicken.com>
10605
10606 * xdisp.c (lookup_glyphless_char_display)
10607 (produce_glyphless_glyph): Handle cons cell entry in
10608 glyphless-char-display.
10609 (Vglyphless_char_display): Document it.
10610
10611 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10612 glyphless-char-display.
10613
4581706e
CY
106142011-04-17 Chong Yidong <cyd@stupidchicken.com>
10615
10616 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10617
10618 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10619
10620 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10621 definition for no-X builds.
10622
4887c6e2 106232011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10624
fd35b6f9
PE
10625 Static checks with GCC 4.6.0 and non-default toolkits.
10626
5c1ccb01
PE
10627 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10628
006c5daa
PE
10629 * process.c (keyboard_bit_set): Define only if SIGIO.
10630 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10631 (send_process): Repair possible setjmp clobbering.
10632
efc736d3
PE
10633 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10634
4e2fe2e6
PE
10635 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10636
f97334a2
PE
10637 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10638
4e75f29d
PE
10639 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10640 Define only if needed.
10641
90efadd1
PE
10642 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10643 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10644 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10645
3c647824
PE
10646 * dispextern.h (struct redisplay_interface): Rename param
10647 to avoid shadowing.
e264f262 10648 * termhooks.h (struct terminal): Likewise.
761383f4 10649 * xterm.c (xembed_send_message): Likewise.
3c647824 10650
b58c5c4a
PE
10651 * insdel.c (make_gap_smaller): Define only if
10652 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10653
cad59032
PE
10654 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10655 it.
10656
c339dc2e
PE
10657 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10658 so that we aren't warned about unused symbols.
10659
91a3e27b
PE
10660 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10661
399c71d3 10662 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10663
8ffc96f5
PE
10664 * xfns.c (x_real_positions): Mark locals as initialized.
10665
eef9bc79
PE
10666 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10667
098db9dd
PE
10668 * xterm.c: Fix problems found by static analysis with other toolkits.
10669 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10670 (x_dispatch_event): Declare static if USE_GTK, and
10671 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10672 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10673 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10674 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10675 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10676
eb18f6cc
PE
10677 * xmenu.c (menu_help_callback): Pointer type fixes.
10678 Use const pointers when pointing at readonly data. Avoid pointer
10679 signedness clashes.
10680 (FALSE): Remove unused macro.
10681 (update_frame_menubar): Remove unused decl.
10682
1fe72bf8
PE
10683 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10684
60d9e1db
PE
10685 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10686 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10687 (single_menu_item): Rename local to avoid shadowing.
10688
39261c26
PE
10689 * keyboard.c (make_lispy_event): Remove unused local var.
10690
018c5e19
PE
10691 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10692 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10693
63d2b86e
PE
10694 * bitmaps: Change bitmaps from unsigned char back to the X11
10695 compatible char. Avoid the old compiler warnings about
10696 out-of-range initializers by using, for example, '\xab' rather
10697 than 0xab.
10698
aefd87e1
PE
10699 * xgselect.c (xgselect_initialize): Check vs interface
10700 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10701
bf501fb9
PE
10702 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10703
e9829fdf
PE
10704 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10705 to read-only memory.
10706
1086c095
PE
10707 * fns.c (vector): Remove; this old hack is no longer needed.
10708
2baccd04 10709 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10710 Remove unused var.
dde42981 10711 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10712
72391843 10713 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10714
436c16df 10715 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10716 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10717 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10718
92bb796d 10719 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10720 (x_term_init): Remove local to avoid shadowing.
92bb796d 10721
764430a3 10722 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10723
10724 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10725 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10726
d1dfb56c
EZ
107272011-04-16 Eli Zaretskii <eliz@gnu.org>
10728
c4354cb4
EZ
10729 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10730
d1dfb56c
EZ
10731 Fix regex.c, syntax.c and friends for buffers > 2GB.
10732 * syntax.h (struct gl_state_s): Declare character position members
10733 EMACS_INT.
10734
10735 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10736
04f2d78b
CB
10737 * textprop.c (verify_interval_modification, interval_of):
10738 Declare arguments EMACS_INT.
d1dfb56c
EZ
10739
10740 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10741 EMACS_INT.
10742
10743 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10744
10745 * indent.c (Fvertical_motion): Local variable it_start is now
10746 EMACS_INT.
10747
10748 * regex.c (re_match, re_match_2, re_match_2_internal)
10749 (bcmp_translate, regcomp, regexec, print_double_string)
10750 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10751 (re_compile_pattern, re_exec): Declare arguments and local
10752 variables `size_t' and `ssize_t' and return values `regoff_t', as
10753 appropriate.
10754 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10755 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10756 <compile_stack_type>: `size' and `avail' are now `size_t'.
10757
10758 * regex.h <regoff_t>: Use ssize_t, not int.
10759 (re_search, re_search_2, re_match, re_match_2): Arguments that
10760 specify buffer/string position and length are now ssize_t and
10761 size_t. Return type is regoff_t.
10762
613052cd
BK
107632011-04-16 Ben Key <bkey76@gmail.com>
10764
10765 * nsfont.m: Fixed bugs in ns_get_family and
10766 ns_descriptor_to_entity that were caused by using free to
10767 deallocate memory blocks that were allocated by xmalloc (via
10768 xstrdup). This caused Emacs to crash when compiled with
10769 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10770 --enable-checking=xmallocoverrun). xfree is now used to
10771 deallocate these memory blocks.
10772
4170f62f 107732011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10774
71b41406
PE
10775 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10776
9587a89d
PE
10777 emacs_write: Accept and return EMACS_INT for sizes.
10778 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10779 et seq.
10780 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10781 Accept and return EMACS_INT.
10782 (emacs_gnutls_write): Return the number of bytes written on
10783 partial writes.
10784 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10785 (emacs_read, emacs_write): Remove check for negative size, as the
10786 Emacs source code has been audited now.
9587a89d
PE
10787 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10788 (emacs_read, emacs_write): Use it.
273a5f82
PE
10789 * process.c (send_process): Adjust to the new signatures of
10790 emacs_write and emacs_gnutls_write. Do not attempt to store
10791 a byte offset into an 'int'; it might overflow.
9587a89d 10792 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10793
3e047f51
PE
10794 * sound.c: Don't assume sizes fit in 'int'.
10795 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10796 Return EMACS_INT, not int.
3e047f51 10797 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10798 Accept EMACS_INT, not int.
10799 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10800 record read return values.
10801
cc39a9db
BK
108022011-04-15 Ben Key <bkey76@gmail.com>
10803
c9d0ec6d
JB
10804 * keyboard.c (Qundefined): Don't declare static since it is used
10805 in nsfns.m.
10806 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10807 static since they are used in nsfont.m.
cc39a9db 10808
6c60eb9f
SM
108092011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10810
10811 * process.c (Qprocessp): Don't declare static.
10812 * lisp.h (Qprocessp): Declare again.
10813
7990b61a
JB
108142011-04-15 Juanma Barranquero <lekktu@gmail.com>
10815
10816 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10817
5d4cb038
PE
108182011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10819
8bd7b830 10820 Improve C-level modularity by making more things 'static'.
cd64ea1d 10821
e3b27b31
PE
10822 Don't publish debugger-only interfaces to other modules.
10823 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10824 (verify_bytepos, count_markers): Move decls to the only modules
10825 that need them.
10826 * region-cache.h (pp_cache): Likewise.
10827 * window.h (check_all_windows): Likewise.
10828 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10829
5d4cb038
PE
10830 * sysdep.c (croak): Now static, if
10831 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10832 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10833
10834 * alloc.c (refill_memory_reserve): Now static if
10835 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10836 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10837
e87b6180
PE
10838 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10839 Define only if USE_LUCID.
10840
ac64929e
PE
10841 * xrdb.c (x_customization_string, x_rm_string): Now static.
10842
6f37259d
PE
10843 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10844 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10845
1683e3ab
PE
10846 * xdisp.c (draw_row_with_mouse_face): Now static.
10847 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10848
de9c2632
PE
10849 * window.h (check_all_windows): Mark externally visible.
10850
2b96acb7
PE
10851 * window.c (window_deletion_count): Now static.
10852
10853 * undo.c: Make symbols static if they're not exported.
10854 (last_undo_buffer, last_boundary_position, pending_boundary):
10855 Now static.
10856
50436f33
PE
10857 * textprop.c (interval_insert_behind_hooks): Now static.
10858 (interval_insert_in_front_hooks): Likewise.
10859
64520e5c
PE
10860 * term.c: Make symbols static if they're not exported.
10861 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10862 (max_frame_lines, tty_set_terminal_modes):
10863 (tty_reset_terminal_modes, tty_turn_off_highlight):
10864 (get_tty_terminal): Now static.
10865 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10866 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10867 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10868 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10869 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10870
1fa53021
PE
10871 * sysdep.c: Make symbols static if they're not exported.
10872 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10873 Now static.
10874 (sigprocmask_set, full_mask): Remove; unused.
10875 (wait_debugging): Mark as visible.
10876 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10877 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10878
d4b43b22
PE
10879 * syntax.c (syntax_temp): Define only if !__GNUC__.
10880
b7c513d0
PE
10881 * sound.c (current_sound_device, current_sound): Now static.
10882
989b29ad
PE
10883 * search.c (searchbufs, searchbuf_head): Now static.
10884
13a55a78
PE
10885 * scroll.c (scroll_cost): Remove; unused.
10886 * dispextern.h (scroll_cost): Remove decl.
10887
de68a1fc
PE
10888 * region-cache.h (pp_cache): Mark as externally visible.
10889
40ccffa6
PE
10890 * process.c: Make symbols static if they're not exported.
10891 (process_tick, update_tick, create_process, chan_process):
10892 (Vprocess_alist, proc_buffered_char, datagram_access):
10893 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10894 (deactivate_process): Mark defn as static, as well as decl.
10895 * lisp.h (create_process): Remove decl.
10896 * process.h (chan_process, Vprocess_alist): Remove decls.
10897
ad64fc97
PE
10898 * print.c: Make symbols static if they're not exported.
10899 (print_depth, new_backquote_output, being_printed, print_buffer):
10900 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10901 (print_interval, print_number_index, initial_stderr_stream):
10902 Now static.
10903 * lisp.h (Fprinc): Remove decl.
10904 (debug_output_compilation_hack): Mark as externally visible.
10905
adddb265
PE
10906 * sysdep.c (croak): Move decl from here to syssignal.h.
10907 * syssignal.h (croak): Put it here, so the API can be checked when
10908 'croak' is called from dissociate_if_controlling_tty.
10909
1717ede2
PE
10910 * minibuf.c: Make symbols static if they're not exported.
10911 (minibuf_save_list, choose_minibuf_frame): Now static.
10912 * lisp.h (choose_minibuf_frame): Remove decl.
10913
fa5fb2bc
PE
10914 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10915
1e3890d1
PE
10916 * lread.c: Make symbols static if they're not exported.
10917 (read_objects, initial_obarray, oblookup_last_bucket_number):
10918 Now static.
10919 (make_symbol): Remove; unused.
10920 * lisp.h (initial_obarray, make_symbol): Remove decls.
10921
8a1414fa
PE
10922 * keyboard.c: Make symbols static if they're not exported.
10923 (single_kboard, recent_keys_index, total_keys, recent_keys):
10924 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10925 (this_single_command_key_start, echoing, last_auto_save):
10926 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10927 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10928 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10929 (Vlispy_mouse_stem, double_click_count):
10930 Now static.
10931 (force_auto_save_soon): Define only if SIGDANGER.
10932 (ignore_mouse_drag_p): Now static if
10933 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10934 (print_help): Remove; unused.
10935 (stop_character, last_timer_event): Mark as externally visible.
10936 * keyboard.h (ignore_mouse_drag_p): Declare only if
10937 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10938 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10939 * lisp.h (echoing): Remove decl.
10940 (force_auto_save_soon): Declare only if SIGDANGER.
10941 * xdisp.c (redisplay_window): Simplify code, to make it more
10942 obvious that ignore_mouse_drag_p is not accessed if !defined
10943 USE_GTK && !defined HAVE_NS.
10944
93ea6e8f
PE
10945 * intervals.c: Make symbols static if they're not exported.
10946 (merge_properties_sticky, merge_interval_right, delete_interval):
10947 Now static.
10948 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10949
77382fcc
PE
10950 * insdel.c: Make symbols static if they're not exported.
10951 However, leave prepare_to_modify_buffer alone. It's never
10952 called from outside this function, but that appears to be a bug.
10953 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10954 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10955 (adjust_after_replace_noundo): Remove; unused.
10956 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10957 (signal_before_change): Remove decls.
77382fcc 10958
9306c32e
PE
10959 * indent.c (val_compute_motion, val_vmotion): Now static.
10960
cd44d2eb
PE
10961 * image.c: Make symbols static if they're not exported.
10962 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10963 if USE_GTK.
10964 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10965 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10966
ad9a7a06
PE
10967 * fringe.c (standard_bitmaps): Now static.
10968 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10969
81626931
PE
10970 * frame.c: Make symbols static if they're not exported.
10971 (x_report_frame_params, make_terminal_frame): Now static.
10972 (get_frame_param): Now static, unless HAVE_NS.
10973 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10974 (x_get_resource_string): Remove; not used.
10975 * frame.h (make_terminal_frame, x_report_frame_params):
10976 (x_get_resource_string); Remove decls.
10977 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10978 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10979
239f9db9
PE
10980 * font.c, fontset.c: Make symbols static if they're not exported.
10981 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10982 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10983 * font.c (font_close_object): Now static.
10984 * font.h (font_close_object): Remove.
10985 * fontset.c (FONTSET_OBJLIST): Remove.
10986 (free_realized_fontset) #if-0 the body, which does nothing.
10987 (face_suitable_for_char_p): #if-0, as it's never called.
10988 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10989 * xfaces.c (face_at_string_position):
10990 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10991 since 0 is always ASCII.
10992
dfcf3579
PE
10993 * fns.c (weak_hash_tables): Now static.
10994
5045092b
PE
10995 * fileio.c: Make symbols static if they're not exported.
10996 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10997 (Vwrite_region_annotation_buffers): Now static.
10998
57a96f5c
PE
10999 * eval.c: Make symbols static if they're not exported.
11000 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11001 * lisp.h (backtrace_list): Remove decl.
11002
35f08c38
PE
11003 * emacs.c: Make symbols static if they're not exported.
11004 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11005 (fatal_error_code, fatal_error_signal_hook, standard_args):
11006 Now static.
11007 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11008 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11009 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11010 * lisp.h (fatal_error_signal_hook): Remove decl.
11011 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11012
f44bd759
PE
11013 * editfns.c: Move a (normally-unused) function to its only use.
11014 * editfns.c, lisp.h (get_operating_system_release): Remove.
11015 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11016 worth the hassle of breaking this out.
11017
b532497d
PE
11018 * xterm.c: Make symbols static if they're not exported.
11019 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11020 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11021 (x_destroy_window, x_delete_display):
11022 Now static.
11023 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11024 (x_mouse_leave): Remove; unused.
11025 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11026 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11027 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11028 Remove decls.
11029 (x_mouse_leave): Declare only if WINDOWSNT.
11030 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11031 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11032 USE_X_TOOLKIT.
11033
1675728f
PE
11034 * ftxfont.c: Make symbols static if they're not exported.
11035 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11036 HAVE_FREETYPE.
11037 * font.h (ftxfont_driver): Likewise.
11038
e4cebfca
PE
11039 * xfns.c: Make symbols static if they're not exported.
11040 (x_last_font_name, x_display_info_for_name):
11041 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11042 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11043 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11044 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11045 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11046 (last_show_tip_args): Now static.
11047 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11048 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11049 (x_screen_planes): Remove; unused.
11050 * dispextern.h (x_screen_planes): Remove decl.
11051
5bf46f05
PE
11052 * dispnew.c: Make symbols static if they're not exported.
11053 * dispextern.h (redraw_garbaged_frames, scrolling):
11054 (increment_row_positions): Remove.
11055 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11056 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11057 Now static.
11058 (redraw_garbaged_frames): Remove; unused.
11059
435f4c28
PE
11060 * xfaces.c: Make symbols static if they're not exported.
11061 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11062 Remove decls.
11063 * xterm.h (defined_color): Remove decls.
11064 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11065 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11066 (menu_face_changed_default, defined_color, free_realized_face):
11067 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11068 (ascii_face_of_lisp_face): Remove; unused.
11069
8524aef3
PE
11070 * xdisp.c: Make symbols static if they're not exported.
11071 * dispextern.h (scratch_glyph_row, window_box_edges):
11072 (glyph_to_pixel_coords, set_cursor_from_row):
11073 (get_next_display_element, set_iterator_to_next):
11074 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11075 (show_mouse_face): Remove decls
11076 * frame.h (message_buf_print): Likewise.
11077 * lisp.h (pop_message, set_message, check_point_in_composition):
11078 Likewise.
11079 * xterm.h (set_vertical_scroll_bar): Likewise.
11080 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11081 (message_buf_print, scratch_glyph_row, displayed_buffer):
11082 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11083 (get_next_display_element, show_mouse_face, window_box_edges):
11084 (frame_to_window_pixel_xy, check_point_in_composition):
11085 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11086 (glyph_to_pixel_coords): Remove; unused.
11087
16390cd2
PE
11088 * dired.c (file_name_completion): Now static.
11089
11090 * dbusbind.c (xd_in_read_queued_messages): Now static.
11091
a25f4dfa
PE
11092 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11093 * data.c (circular_list_error): Remove.
11094
14a9c8df
PE
11095 * commands.h (last_point_position, last_point_position_buffer):
11096 (last_point_position_window): Remove decls.
11097 * keyboard.c: Make these variables static.
11098
04f2d78b
CB
11099 * coding.h (coding, code_convert_region, encode_coding_gap):
11100 Remove decls.
74ab6df5
PE
11101 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11102 (iso_code_class, detect_coding, code_convert_region): Now static.
11103 (encode_coding_gap): Remove; unused.
11104
38dfbee1
PE
11105 * chartab.c (chartab_chars, chartab_bits): Now static.
11106
a2cb4e63
PE
11107 * charset.h (charset_iso_8859_1): Remove decl.
11108 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11109 Now static.
11110
127198fd
PE
11111 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11112 * ccl.c (Vccl_program_table): Now static.
11113 (check_ccl_update): Remove; unused.
11114
d85b608f
PE
11115 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11116 * category.h: ... from here.
11117 * category.c (check_category_table, set_category_set): Now static.
11118
31cd66f3
PE
11119 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11120 * lisp.h: Remove these decls.
11121
c358e587
PE
11122 * buffer.c (buffer_count): Remove unused var.
11123
e78aecca
PE
11124 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11125 so that it's not optimized away.
11126 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11127 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11128 exported only to the debugger.
11129
e192d7d3 11130 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11131 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11132
92470028
PE
11133 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11134 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11135 was inaccessible from Lisp.
11136 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11137 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11138
244ed907
PE
11139 alloc.c: Import and export fewer symbols, and remove unused items.
11140 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11141 is defined.
11142 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11143 it's not optimized away by whole-program optimization.
11144 (message_enable_multibyte, free_misc): Remove.
11145 (catchlist, handlerlist, mark_backtrace):
11146 Declare only if BYTE_MARK_STACK.
11147 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11148 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11149 (message_enable_multibyte): Remove decl.
11150 (free_misc, interval_free_list, float_block, float_block_index):
11151 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11152 (cons_free_list, last_marked_index):
11153 Now static.
11154 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11155 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11156 (mark_backtrace): Define only if BYTE_MARK_STACK.
11157 * xdisp.c (message_enable_multibyte): Now static.
11158
61c2b50e 11159 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11160 This makes it easier for human readers (and static analyzers)
11161 to see whether these variables are used from other modules.
11162 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11163 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11164 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11165 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11166 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11167 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11168 * xmenu.c, xselect.c:
11169 Declare Q* vars static if they are not used in other modules.
11170 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11171 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11172 Remove decls of unexported vars.
11173 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11174
95c82688
PE
11175 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11176
16a97296
PE
11177 Make Emacs functions such as Fatom 'static' by default.
11178 This makes it easier for human readers (and static analyzers)
11179 to see whether these functions can be called from other modules.
11180 DEFUN now defines a static function. To make the function external
11181 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11182 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11183 (Finit_image_library):
16a97296
PE
11184 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11185 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11186 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11187 Remove decls, since these functions are now static.
11188 (Funintern, Fget_internal_run_time): New decls, since these functions
11189 were already external.
95c82688 11190
16a97296
PE
11191 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11192 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11193 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11194 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11195 * keyboard.c, keymap.c, lread.c:
11196 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11197 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11198 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11199 Mark functions with DEFUE instead of DEFUN,
11200 if they are used in other modules.
11201 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11202 decls for now-static functions.
11203 * buffer.h (Fdelete_overlay): Remove decl.
11204 * callproc.c (Fgetenv_internal): Mark as internal.
11205 * composite.c (Fremove_list_of_text_properties): Remove decl.
11206 (Fcomposition_get_gstring): New forward static decl.
11207 * composite.h (Fcomposite_get_gstring): Remove decl.
11208 * dired.c (Ffile_attributes): New forward static decl.
11209 * doc.c (Fdocumntation_property): New forward static decl.
11210 * eval.c (Ffetch_bytecode): New forward static decl.
11211 (Funintern): Remove extern decl; now in .h file where it belongs.
11212 * fileio.c (Fmake_symbolic_link): New forward static decl.
11213 * image.c (Finit_image_library): New forward static decl.
11214 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11215 * intervals.h (Fprevious_property_change):
11216 (Fremove_list_of_text_properties): Remove decls.
11217 * keyboard.c (Fthis_command_keys): Remove decl.
11218 (Fcommand_execute): New forward static decl.
11219 * keymap.c (Flookup_key): New forward static decl.
11220 (Fcopy_keymap): Now static.
11221 * keymap.h (Flookup_key): Remove decl.
11222 * process.c (Fget_process): New forward static decl.
11223 (Fprocess_datagram_address): Mark as internal.
11224 * syntax.c (Fsyntax_table_p): New forward static decl.
11225 (skip_chars): Remove duplicate decl.
11226 * textprop.c (Fprevious_property_change): New forward static decl.
11227 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11228 Now internal.
11229 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11230 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11231
785bbd42
PE
11232 * editfns.c (Fformat): Remove unreachable code.
11233
8b913b57
AS
112342011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11235
11236 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11237 change. (Bug#8496)
11238
a6744a35
EZ
112392011-04-13 Eli Zaretskii <eliz@gnu.org>
11240
11241 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11242 when at ZV. (Bug#8487)
11243
e7974947
AS
112442011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11245
baad03f0
AS
11246 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11247 (Bug#8437)
11248 * keyboard.c (parse_tool_bar_item): Likewise.
11249 * sound.c (sound_cleanup, alsa_close): Likewise.
11250 * termcap.c (tgetent): Likewise.
11251 * xfns.c (x_default_font_parameter): Likewise.
11252 * xsettings.c (read_and_apply_settings): Likewise.
11253
e7974947
AS
11254 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11255 (overrun_check_free): Protoize.
11256
28272684
PE
112572011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11258
11259 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11260 since callers should never pass a negative size.
11261 Change the signature to match that of plain 'read' and 'write'; see
11262 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11263 * lisp.h: Update prototypes of emacs_write and emacs_read.
11264
11997c76
EZ
112652011-04-11 Eli Zaretskii <eliz@gnu.org>
11266
11267 * xdisp.c (redisplay_window): Don't try to determine the character
11268 position of the scroll margin if the window start point w->startp
e896f03c 11269 is outside the buffer's accessible region. (Bug#8468)
11997c76 11270
8a2cbd72
EZ
112712011-04-10 Eli Zaretskii <eliz@gnu.org>
11272
11273 Fix write-region and its subroutines for buffers > 2GB.
11274 * fileio.c (a_write, e_write): Modify declaration of arguments and
11275 local variables to support buffers larger than 2GB.
11276 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11277
11278 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11279 argument, local variables, and return value.
11280
11281 * lisp.h: Update prototypes of emacs_write and emacs_read.
11282
11283 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11284
4073e537 112852011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11286
1ebfdcb6
PE
11287 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11288
b2ded58d
PE
11289 Fix more problems found by GCC 4.6.0's static checks.
11290
7d66342c
PE
11291 * xdisp.c (vmessage): Use a better test for character truncation.
11292
bbf47d44
PE
11293 * charset.c (load_charset_map): <, not <=, for optimization,
11294 and to avoid potential problems with integer overflow.
9248994d 11295 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11296 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11297 * editfns.c (Fformat): Likewise.
1e69125e 11298 * syntax.c (skip_chars): Likewise.
3befa583 11299
e3019616
PE
11300 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11301 This also lets GCC 4.6.0 generate slightly better loop code.
11302
becfa255
PE
11303 * callint.c (Fcall_interactively): <, not <=, for optimization.
11304 (Fcall_interactively): Count the number of arguments produced,
11305 not the number of arguments given. This is simpler and lets GCC
11306 4.6.0 generate slightly better code.
11307
dae0cd48
PE
11308 * ftfont.c: Distingish more carefully between FcChar8 and char.
11309 The previous code passed unsigned char * to a functions like
11310 strlen and xstrcasecmp that expect char *, which does not
11311 conform to the C standard.
11312 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11313 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11314 char * when the C standard requires it.
11315
76032d70
PE
11316 * keyboard.c (read_char): Remove unused var.
11317
eb3f1cc8
PE
11318 * eval.c: Port to Windows vsnprintf (Bug#8435).
11319 Include <limits.h>.
11320 (SIZE_MAX): Define if the headers do not.
11321 (verror): Do not give up if vsnprintf returns a negative count.
11322 Instead, grow the buffer. This ports to Windows vsnprintf, which
11323 does not conform to C99. Problem reported by Eli Zaretskii.
11324 Also, simplify the allocation scheme, by avoiding the need for
11325 calling realloc, and removing the ALLOCATED variable.
11326
70476b54
PE
11327 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11328
12020a9e
PE
11329 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11330 But keep the doprint source code for now, as we might revamp it
11331 and use it again (Bug#8435).
ea6c7ae6
PE
11332 * lisp.h (doprnt): Remove.
11333 * Makefile.in (base_obj): Remove doprnt.o.
11334 * deps.mk (doprnt.o): Remove.
11335
5fdb398c
PE
11336 error: Print 32- and 64-bit integers portably (Bug#8435).
11337 Without this change, on typical 64-bit hosts error ("...%d...", N)
11338 was used to print both 32- and 64-bit integers N, which relied on
11339 undefined behavior.
61bdb816 11340 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11341 * lisp.h (error, verror): Mark as printf-like functions.
11342 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11343 Report overflow in size calculations when allocating printf buffer.
11344 Do not truncate output string at its first null byte.
11345 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11346 Truncate the output at a character boundary, since vsnprintf does not
11347 do that.
11348 * charset.c (check_iso_charset_parameter): Convert internal
11349 character to string before calling 'error', since %c now has the
11350 printf meaning.
11351 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11352 overflow when computing char to be passed to 'error'. Do not
11353 pass Lisp_Object to 'error'; pass the integer instead.
11354 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11355 formatted with plain %d.
11356
b189fa66
PE
11357 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11358
bff87ef0
PE
11359 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11360
7e2cac20
PE
11361 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11362
ce4d90b5
PE
11363 * xterm.c (x_catch_errors): Remove duplicate declaration.
11364
266c9547
PE
11365 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11366
79c49ad2
PE
11367 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11368
368f4090
JM
113692011-04-10 Jim Meyering <meyering@redhat.com>
11370
11371 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11372 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11373 return ssize_t not "int", and use size_t as the buffer length.
11374 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11375 * gnutls.h: Update declarations.
11376 * process.c (read_process_output): Use ssize_t, to match.
11377 (send_process): Likewise.
11378
a32d4040
CY
113792011-04-09 Chong Yidong <cyd@stupidchicken.com>
11380
11381 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11382
8546720e 113832011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11384
04f2d78b
CB
11385 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11386 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11387
8546720e
GM
11388 * xterm.c (handle_one_xevent):
11389 * xmenu.c (create_and_show_popup_menu):
11390 * xselect.c (x_decline_selection_request)
11391 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11392
0a2f5c1a 113932011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11394
11395 Fix some uses of `int' instead of EMACS_INT.
11396 * search.c (string_match_1, fast_string_match)
11397 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11398 (scan_buffer, find_next_newline_no_quit)
11399 (find_before_next_newline, search_command, Freplace_match)
11400 (Fmatch_data): Make some `int' variables be EMACS_INT.
11401
11402 * xdisp.c (display_count_lines): 3rd argument and return value now
11403 EMACS_INT. All callers changed.
11404 (pint2hrstr): Last argument is now EMACS_INT.
11405
11406 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11407 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11408 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11409 (decode_coding_utf_16, decode_coding_emacs_mule)
11410 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11411 (decode_coding_ccl, decode_coding_charset)
11412 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11413 (decode_coding_iso_2022, decode_coding_emacs_mule)
11414 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11415 <char_offset, last_offset>: Declare EMACS_INT.
11416 (encode_coding_utf_8, encode_coding_utf_16)
11417 (encode_coding_emacs_mule, encode_invocation_designation)
11418 (encode_designation_at_bol, encode_coding_iso_2022)
11419 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11420 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11421 Declare EMACS_INT.
11422 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11423 (encode_invocation_designation): Last argument P_NCHARS is now
11424 EMACS_INT.
11425 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11426 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11427
11428 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11429 All users changed.
11430
11431 * ccl.c (Fccl_execute_on_string): Declare some variables
11432 EMACS_INT.
11433
8546720e 114342011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11435
11436 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11437
4e19a977
CS
114382011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11439
11440 * process.c (Fformat_network_address): Doc fix.
11441
87302331
R
114422011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11443
ee7683eb 11444 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11445
cbb59342
CY
114462011-04-08 Chong Yidong <cyd@stupidchicken.com>
11447
11448 * keyboard.c (read_char): Call Lisp function help-form-show,
11449 instead of using internal_with_output_to_temp_buffer.
11450 (Qhelp_form_show): New var.
e0d38eeb 11451 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11452
11453 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11454
11455 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11456
e67a13ab
CY
114572011-04-06 Chong Yidong <cyd@stupidchicken.com>
11458
04f2d78b
CB
11459 * process.c (Flist_processes): Remove to Lisp.
11460 (list_processes_1): Delete.
e67a13ab 11461
973f782d
EZ
114622011-04-06 Eli Zaretskii <eliz@gnu.org>
11463
7c106b1e
EZ
11464 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11465
973f782d
EZ
11466 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11467
41cf7d1a 114682011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11469
ca23cc88
PE
11470 Fix more problems found by GCC 4.6.0's static checks.
11471
f390e2d5
PE
11472 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11473
42eea0d0
PE
11474 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11475
b69769da 11476 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11477
f9541e84
PE
11478 * xdisp.c (vmessage): Mark as a printf-like function.
11479
13841b55
PE
11480 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11481
c136c10f
PE
11482 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11483
5e2d4a30
PE
11484 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11485 printf-like functions.
11486 (tiff_load): Add casts to remove these marks before passing them
11487 to system-supplied API.
11488
583f48b9
PE
11489 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11490
b25d760e
PE
11491 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11492 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11493 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11494 directly, rather than having caller test rule sign. This avoids
11495 some unnecessary tests.
11496 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11497 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11498 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11499
bc7b6697 11500 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11501 (xfont_open): Avoid unnecessary tests.
bc7b6697 11502
27ccc379
PE
11503 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11504
dcd5c89a
PE
11505 * composite.h, composite.c (composition_gstring_put_cache):
11506 Use EMACS_INT, not int, for length.
11507
b13a45c6
PE
11508 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11509 breaking out part of COMPOSITION_DECODE_RULE.
11510 (COMPOSITION_DECODE_RULE): Use it.
11511 * composite.c (get_composition_id): Remove unused local vars,
11512 by using the new macro.
11513
1e792e4d
PE
11514 * textprop.c (set_text_properties_1): Change while to do-while,
11515 since the condition is always true at first.
11516
dc6c6455 11517 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11518 (interval_deletion_adjustment): Return unsigned value.
11519 All uses changed.
dc6c6455 11520
aba7731a
PE
11521 * process.c (list_processes_1, create_pty, read_process_output):
11522 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11523 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11524 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11525 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11526 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11527
fdfc4bf3
PE
11528 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11529
fca8fe46 11530 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11531 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11532
06a0259a 11533 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11534 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11535 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11536
e7b9e80f
PE
11537 * print.c (print_error_message): Avoid int overflow.
11538
56201685
PE
11539 * font.c (font_list_entities): Redo for clarity,
11540 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11541
78834453 11542 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11543 (font_score): Avoid potential overflow in diff calculation.
78834453 11544
0bc0b309 11545 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11546 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11547
e610eaca
PE
11548 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11549
b895abce
PE
11550 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11551 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11552 can always succeed if overflow has undefined behavior.
11553
1f1d9321 11554 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11555 (wordify): Omit three unnecessary tests.
1f1d9321 11556
c59478bc
PE
11557 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11558 All callers changed. This avoids the need for an unused var.
11559
79b73827
PE
11560 * casefiddle.c (casify_region): Remove var that is set but not used.
11561
a4db5dfe
PE
11562 * dired.c (file_name_completion): Remove var that is set but not used.
11563
43aae36e
PE
11564 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11565
2a47c44d 11566 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11567 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11568
a37c69bf
PE
11569 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11570 Check for integer overflow on size calculations.
11571
328ab8e7
PE
11572 * buffer.c (Fprevious_overlay_change): Remove var that is set
11573 but not used.
11574
e5a2a5cb
PE
11575 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11576 Remove vars that are set but not used.
8d84a6eb 11577 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11578 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11579
a60e5f68
PE
11580 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11581
f661cb61 11582 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11583 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11584
f0397f5a
PE
11585 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11586 that are set but not used.
11587
8664db06 11588 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11589 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11590
6abdaa4a
PE
11591 * xselect.c (x_get_local_selection, x_handle_property_notify):
11592 Remove vars that are set but not used.
11593
0ce7538d 11594 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11595 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11596
9ae848fc
PE
11597 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11598 Remove var that is set but not used.
0b918413
PE
11599 (scroll_bar_windows_size): Now size_t, not int.
11600 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11601 Check for overflow.
9ae848fc 11602
a5a62657
PE
11603 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11604 (map_tty_color) [!defined MSDOS]: Likewise.
11605
5c5cdd39
PE
11606 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11607
66ebf983
PE
11608 * coding.c: Remove vars that are set but not used.
11609 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11610 All callers changed.
11611 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11612 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11613 (decode_coding_charset): Remove vars that are set but not used.
11614
1be4d761
PE
11615 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11616 that is set but not used.
11617
47553fa8
PE
11618 * print.c (print_object): Remove var that is set but not used.
11619
1f7196bf 11620 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11621 The gnulib version avoids calling malloc in the usual case,
11622 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11623 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11624 * filelock.c (current_lock_owner): Likewise.
11625 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11626 * sysdep.c: Include allocator.h, careadlinkat.h.
11627 (emacs_no_realloc_allocator): New static constant.
11628 (emacs_readlink): New function.
fdb61804
PE
11629 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11630 ../lib/careadlinkat.h.
d1fdcab7 11631
f84c17c7
SM
116322011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11633
11634 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11635 first non-nil return value).
11636
ef3862ad
JD
116372011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11638
11639 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11640 if not defined (Bug#8403).
11641
376a7006
JB
116422011-04-02 Juanma Barranquero <lekktu@gmail.com>
11643
11644 * xdisp.c (display_count_lines): Remove parameter `start',
11645 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11646 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11647 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11648 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11649 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11650 and thereabouts. All callers changed.
11651 (get_per_char_metric): Remove parameter `f', unused since
11652 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11653
6ca3801d
JM
116542011-04-02 Jim Meyering <meyering@redhat.com>
11655
11656 do not dereference NULL upon failed strdup
11657 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11658 (ns_get_family): Likewise.
11659
d8e2b5ba
JB
116602011-04-02 Juanma Barranquero <lekktu@gmail.com>
11661
11662 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11663
8c74fcbd
JD
116642011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11665
11666 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11667 later (Bug#8403).
11668
7200d79c
SM
116692011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11670
03408648 11671 Add lexical binding.
7200d79c 11672
03408648
SM
11673 * window.c (Ftemp_output_buffer_show): New fun.
11674 (Fsave_window_excursion):
11675 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11676
11677 * lread.c (lisp_file_lexically_bound_p): New function.
11678 (Fload): Bind Qlexical_binding.
11679 (readevalloop): Remove `evalfun' arg.
11680 Bind Qinternal_interpreter_environment.
11681 (Feval_buffer): Bind Qlexical_binding.
11682 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11683 Mark as dynamic.
11684 (syms_of_lread): Declare `lexical-binding'.
11685
11686 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11687
11688 * keyboard.c (eval_dyn): New fun.
11689 (menu_item_eval_property): Use it.
ca105506
SM
11690
11691 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11692
03408648
SM
11693 * fns.c (concat, mapcar1): Accept byte-code-functions.
11694
11695 * eval.c (Fsetq): Handle lexical vars.
11696 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11697 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11698 (FletX, Flet): Obey lexical binding.
11699 (Fcommandp): Handle closures.
11700 (Feval): New `lexical' arg.
11701 (eval_sub): New function extracted from Feval. Use it almost
11702 everywhere where Feval was used. Look up vars in lexical env.
11703 Handle closures.
11704 (Ffunctionp): Move from subr.el.
11705 (Ffuncall): Handle closures.
11706 (apply_lambda): Remove `eval_flags'.
11707 (funcall_lambda): Handle closures and new byte-code-functions.
11708 (Fspecial_variable_p): New function.
11709 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11710 but without exporting it to Lisp.
23aba0ea 11711
23aba0ea 11712 * doc.c (Fdocumentation, store_function_docstring):
03408648 11713 * data.c (Finteractive_form): Handle closures.
23aba0ea 11714
03408648
SM
11715 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11716 interactive spec.
ba83908c 11717
04f2d78b
CB
11718 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11719 New byte-codes.
03408648
SM
11720 (exec_byte_code): New function extracted from Fbyte_code to handle new
11721 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11722
03408648 11723 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11724
03408648 11725 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11726
e2abce01
JB
117272011-03-31 Juanma Barranquero <lekktu@gmail.com>
11728
11729 * xdisp.c (redisplay_internal): Fix prototype.
11730
63696a73 117312011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11732
63696a73 11733 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11734 (try_scrolling): Use it when setting scroll_limit.
11735 Limit scrolling to 100 screen lines.
63696a73
EZ
11736 (redisplay_window): Even when falling back on "recentering",
11737 position point in the window according to scroll-conservatively,
11738 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11739
11740 (try_scrolling): When point is above the window, allow searching
11741 as far as scroll_max, or one screenful, to compute vertical
11742 distance from PT to the scroll margin position. This prevents
11743 try_scrolling from unnecessarily failing when
11744 scroll-conservatively is set to a value slightly larger than the
11745 window height. Clean up the case of PT below the margin at bottom
11746 of window: scroll_max can no longer be INT_MAX. When aggressive
11747 scrolling is in use, don't let point enter the opposite scroll
11748 margin as result of the scroll.
11749 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11750 threshold of 100 lines for never-recentering scrolling.
11751
e4cc2dfc
JB
117522011-03-31 Juanma Barranquero <lekktu@gmail.com>
11753
11754 * dispextern.h (move_it_by_lines):
11755 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11756 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11757 (message_log_check_duplicate): Remove parameters `prev_bol' and
11758 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11759 (redisplay_internal): Remove parameter `preserve_echo_area',
11760 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11761
11762 * indent.c (Fvertical_motion):
11763 * window.c (window_scroll_pixel_based, Frecenter):
11764 Don't pass `need_y_p' to `move_it_by_lines'.
11765
1c470562
SM
117662011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11767
44f230aa
SM
11768 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11769 steal a few bits to be more compact.
11770 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11771 Remove unneeded casts.
11772
1c470562
SM
11773 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11774
888adce9
ZK
117752011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11776
11777 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11778 binding" message (bug#7967).
11779
f838ed7b
PE
117802011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11781
77861b95
PE
11782 Fix more problems found by GCC 4.6.0's static checks.
11783
de6dbc14
PE
11784 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11785 Remove unused local var.
11786
f838ed7b
PE
11787 * editfns.c (Fmessage_box): Remove unused local var.
11788
792c7b2b
PE
11789 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11790 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11791 Omit unused local vars.
c499e557 11792 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11793 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11794 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11795 Omit unused local var.
11796
ba0165e1
PE
11797 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11798 Don't assume string length fits in int.
32ad8845 11799 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11800 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11801
3c59b4c9
PE
11802 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11803 instead of alloca (Bug#8344).
11804
a3eed478 11805 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11806 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11807
eb4d412d
PE
11808 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11809
1658b401
PE
11810 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11811 concerns.
11812
11813 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11814
11815 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11816
9a2c6e05
PE
11817 * keyboard.c (syms_of_keyboard): Use the same style as later
11818 in this function when indexing through an array. This also
11819 works around GCC bug 48267.
11820
03d0a109
PE
11821 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11822
44f730c8
PE
11823 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11824
fe75f926
PE
11825 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11826 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11827
ffa8c828
PE
11828 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11829 This avoids undefined behavior on integer overflow, and is a bit
11830 more convenient anyway since it is compared to a size_t variable.
11831
c5101a77
PE
11832 Variadic C functions now count arguments with size_t, not int.
11833 This avoids an unnecessary limitation on 64-bit machines, which
11834 caused (substring ...) to crash on large vectors (Bug#8344).
11835 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11836 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11837 All variadic functions and their callers changed accordingly.
c5101a77
PE
11838 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11839 * data.c (arith_driver, float_arith_driver): Likewise.
11840 * editfns.c (general_insert_function): Likewise.
11841 * eval.c (struct backtrace.nargs, interactive_p)
11842 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11843 (funcall_lambda, mark_backtrace): Likewise.
11844 * fns.c (concat): Likewise.
11845 * frame.c (x_set_frame_parameters): Likewise.
11846 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11847 0 if not found, not -1. All callers changed.
11848
dd3f25f7
PE
11849 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11850 (stack_copy_size): Now size_t, not int.
11851 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11852
461c2ab9
JB
118532011-03-28 Juanma Barranquero <lekktu@gmail.com>
11854
11855 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11856 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11857 All callers changed.
11858
11859 * lisp.h (multibyte_char_to_unibyte):
11860 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11861 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11862 * character.h (CHAR_TO_BYTE8):
11863 * cmds.c (internal_self_insert):
11864 * editfns.c (general_insert_function):
11865 * keymap.c (push_key_description):
11866 * search.c (Freplace_match):
11867 * xdisp.c (message_dolog, set_message_1): All callers changed.
11868
f6d62986
SM
118692011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11870
11871 * keyboard.c (safe_run_hook_funcall): New function.
11872 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11873 don't set the hook to nil, but remove the offending function instead.
11874 (Qcommand_hook_internal): Remove, unused.
11875 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11876 Vcommand_hook_internal.
11877
11878 * eval.c (enum run_hooks_condition): Remove.
11879 (funcall_nil, funcall_not): New functions.
11880 (run_hook_with_args): Call each function through a `funcall' argument.
11881 Remove `cond' argument, now redundant.
11882 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11883 (Frun_hook_with_args_until_failure): Adjust accordingly.
11884 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11885
1db5b1ad
JB
118862011-03-28 Juanma Barranquero <lekktu@gmail.com>
11887
11888 * dispextern.h (string_buffer_position): Remove declaration.
11889
11890 * print.c (strout): Remove parameter `multibyte', unused since
11891 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11892
11893 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11894 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11895 All callers changed.
11896
11897 * w32.c (_wsa_errlist): Use braces for struct initializers.
11898
11899 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11900 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11901 All callers changed.
11902 (string_buffer_position): Likewise. Also, make static (it's never
11903 used outside xdisp.c).
11904 (cursor_row_p): Remove parameter `w', unused since
11905 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11906 (decode_mode_spec): Remove parameter `precision', introduced during
11907 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11908 All callers changed.
11909
5ffb62aa
JD
119102011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11911
11912 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11913
461c2ab9 119142011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11915
11916 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11917 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11918 (ns_update_auto_hide_menu_bar): New functions.
11919 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11920 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11921 ns_constrain_all_frames.
11922 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11923 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11924
5c380ffb
JD
119252011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11926
11927 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11928
9af30bdf
GM
119292011-03-27 Glenn Morris <rgm@gnu.org>
11930
11931 * syssignal.h: Replace RETSIGTYPE with void.
11932 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11933 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11934 Replace SIGTYPE with void everywhere.
11935 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11936 * s/template.h (SIGTYPE): Remove commented out definition.
11937
e2abce01
JB
119382011-03-26 Eli Zaretskii <eliz@gnu.org>
11939
11940 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11941 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11942
f868cd8a
JB
119432011-03-26 Juanma Barranquero <lekktu@gmail.com>
11944
59eb0929
JB
11945 * w32.c (read_unc_volume): Use parameter `henum', instead of
11946 global variable `wget_enum_handle'.
11947
11948 * keymap.c (describe_vector): Remove parameters `indices' and
11949 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11950 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11951
f868cd8a
JB
11952 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11953
11954 * keyboard.c (timer_check): Remove parameter `do_it_now',
11955 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11956 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11957 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11958
11959 * keyboard.c (read_char):
11960 * w32menu.c (w32_menu_display_help):
11961 * xmenu.c (show_help_event, menu_help_callback):
11962 Adjust calls to `show_help_echo'.
11963
11964 * gtkutil.c (xg_maybe_add_timer):
11965 * keyboard.c (readable_events):
11966 * process.c (wait_reading_process_output):
11967 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11968
11969 * insdel.c (adjust_markers_gap_motion):
11970 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11971 (gap_left, gap_right): Don't call it.
11972
2ecf6fdb
CY
119732011-03-25 Chong Yidong <cyd@stupidchicken.com>
11974
11975 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11976 incurred during fontification.
11977
6b1f9ba4
JB
119782011-03-25 Juanma Barranquero <lekktu@gmail.com>
11979
11980 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11981 (DEFVAR_PER_BUFFER): Don't pass it.
11982
11983 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11984 (scrolling_window): Don't pass it.
11985
0f4a96b5
JB
119862011-03-25 Juanma Barranquero <lekktu@gmail.com>
11987
11988 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11989
11990 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11991 and `suffix'.
11992 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11993 of variables specific to SELinux and computation of `encoded_absname'.
11994
11995 * image.c (XPutPixel): Remove unused variable `height'.
11996
11997 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11998
11999 * unexw32.c (get_section_info): Remove unused variable `section'.
12000
12001 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12002 (system_process_attributes): Remove unused variable `sess'.
12003 (sys_read): Remove unused variable `err'.
12004
12005 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12006 (w32_wnd_proc): Remove unused variable `isdead'.
12007 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12008 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12009 (x_create_tip_frame): Remove unused variable `tem'.
12010
12011 * w32inevt.c (w32_console_read_socket):
12012 Remove unused variable `no_events'.
12013
12014 * w32term.c (x_draw_composite_glyph_string_foreground):
12015 Remove unused variable `width'.
12016
1149507c
JB
120172011-03-24 Juanma Barranquero <lekktu@gmail.com>
12018
12019 * w32term.c (x_set_glyph_string_clipping):
12020 Don't pass uninitialized region to CombineRgn.
12021
9c88f339
JB
120222011-03-23 Juanma Barranquero <lekktu@gmail.com>
12023
12024 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12025 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12026 (Fx_close_connection): Remove unused variable `i'.
12027
12028 * w32font.c (w32font_draw): Return number of glyphs.
12029 (w32font_open_internal): Remove unused variable `i'.
12030 (w32font_driver): Add missing initializer.
12031
12032 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12033 (fill_in_menu): Remove unused variable `items_added'.
12034
12035 * w32term.c (last_mouse_press_frame): Remove static global variable.
12036 (w32_clip_to_row): Remove unused variable `f'.
12037 (x_delete_terminal): Remove unused variable `i'.
12038
12039 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12040 (NOTHING): Remove unused static global variable.
12041 (uniscribe_check_otf): Remove unused variable `table'.
12042 (uniscribe_font_driver): Add missing initializers.
12043
dee091a3
JD
120442011-03-23 Julien Danjou <julien@danjou.info>
12045
12046 * term.c (Fsuspend_tty, Fresume_tty):
12047 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12048 * window.c (temp_output_buffer_show):
12049 * insdel.c (signal_before_change):
12050 * frame.c (Fhandle_switch_frame):
12051 * fileio.c (Fdo_auto_save):
12052 * emacs.c (Fkill_emacs):
12053 * editfns.c (save_excursion_restore):
12054 * cmds.c (internal_self_insert):
12055 * callint.c (Fcall_interactively):
12056 * buffer.c (Fkill_all_local_variables):
12057 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12058 Use Frun_hooks.
0f4a96b5 12059 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12060 unconditionally since it does the check itself.
dee091a3 12061
2c520ab5 120622011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12063
c9c49752
PE
12064 Fix more problems found by GCC 4.5.2's static checks.
12065
8abc3f12
PE
12066 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12067 the first time through the loop, since we know p0 < p1 then.
12068 This also avoids a gcc -Wstrict-overflow warning.
12069
a2d26660
PE
12070 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12071 leading to a memory leak, possible in functions like
12072 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12073 of objects (Bug#8318).
a2d26660 12074
916c72e9
PE
12075 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12076 that could (at least in theory) be that large.
12077
19ab8a18
PE
12078 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12079 This is less likely to overflow, and avoids undefined behavior if
12080 overflow does occur. All callers changed. Use strtoul to scan
12081 for the unsigned long integer.
b7cbbd6f
PE
12082 (pint2hrstr): Simplify and tune code slightly.
12083 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12084
f0641eff
PE
12085 * scroll.c (do_scrolling): Work around GCC bug 48228.
12086 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12087
7f650bb9
PE
12088 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12089 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12090 (validate_x_resource_name): Simplify count usage.
12091 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12092
37dd57d1
PE
12093 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12094 fail (Bug#8306).
81e56e61 12095
699979fc 12096 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12097
401bf9b4
PE
12098 * process.c (Fmake_network_process): Use socklen_t, not int,
12099 where POSIX says socklen_t is required in portable programs.
12100 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12101 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12102 (Fmake_network_process, server_accept_connection):
12103 (wait_reading_process_output, read_process_output):
12104 Likewise.
12105
b93aacde
PE
12106 * process.c: Rename or move locals to avoid shadowing.
12107 (list_processes_1, Fmake_network_process):
12108 (read_process_output_error_handler, exec_sentinel_error_handler):
12109 Rename or move locals.
4dc343ee 12110 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12111 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12112 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12113 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12114 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12115
af8a867c 12116 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12117 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12118 Include tparam.h instead, since it declares them.
af8a867c
PE
12119 * cm.h (PC): Remove extern decl; tparam.h now does this.
12120 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12121 * terminfo.c: Include tparam.h, to check interfaces.
12122 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12123 (tparam): Adjust signature to match interface in tparam.h;
12124 this removes some undefined behavior. Check that outstring and len
12125 are zero, which they always are with Emacs.
12126 * tparam.h (PC, BC, UP): New extern decls.
12127
0248044d 12128 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12129 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12130
8ff096c1 12131 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12132 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12133 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12134 (ftfont_list): Remove unused local.
49eaafba
PE
12135 (get_adstyle_property, ftfont_pattern_entity):
12136 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12137 Rename locals to avoid shadowing.
8ff096c1 12138
e2be39f6
PE
12139 * xfont.c (xfont_list_family): Mark var as initialized.
12140
c9735e30
PE
12141 * xml.c (make_dom): Now static.
12142
8f5201ae
PE
12143 * composite.c (composition_compute_stop_pos): Rename local to
12144 avoid shadowing.
b246f932
PE
12145 (composition_reseat_it): Remove unused locals.
12146 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12147 (composition_update_it): Mark var as initialized.
11b61122
PE
12148 (find_automatic_composition): Mark vars as initialized,
12149 with a FIXME (Bug#8290).
8f5201ae 12150
760fbc2c
PE
12151 character.h: Rename locals to avoid shadowing.
12152 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12153 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12154 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12155 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12156 to avoid shadowing.
12157
ff08eb85
PE
12158 * textprop.c (property_change_between_p): Remove; unused.
12159
fc7bf025
PE
12160 * intervals.c (interval_start_pos): Now static.
12161
235d7abc
PE
12162 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12163
44f230aa
SM
12164 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12165 Rename locals to avoid shadowing.
3e7d6594 12166
50060332
PE
12167 * sound.c (wav_play, au_play, Fplay_sound_internal):
12168 Fix pointer signedness.
d01f234b 12169 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12170 (wav_play): Initialize a variable to 0, to prevent undefined
12171 behavior (Bug#8278).
50060332 12172
c4fc4e30
PE
12173 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12174
918436ed
PE
12175 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12176
c939f91b
PE
12177 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12178 clobbering (Bug#8298).
b9c7f648
PE
12179 * sysdep.c (sys_subshell): Likewise.
12180 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12181
6bd8c144
PE
12182 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12183 This should get cleaned up, so that child_setup has the
12184 same signature on all platforms.
12185
7710357c 12186 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12187 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12188
c59da222
CY
121892011-03-22 Chong Yidong <cyd@stupidchicken.com>
12190
12191 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12192 not to be necessary, and produces flickering.
12193
66b87493
GM
121942011-03-20 Glenn Morris <rgm@gnu.org>
12195
12196 * config.in: Remove file.
12197
45b6f6d5
JB
121982011-03-20 Juanma Barranquero <lekktu@gmail.com>
12199
12200 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12201 are now in src/globals.h.
12202 (syms_of_minibuf): Remove spurious & from previous change.
12203
cd394be1 122042011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12205
12206 * minibuf.c (completing-read-function): New variable.
12207 (completing-read-default): Rename from completing-read.
12208 (completing-read): Call completing-read-function.
12209
b14e3e21
CY
122102011-03-19 Juanma Barranquero <lekktu@gmail.com>
12211
12212 * xfaces.c (Fx_load_color_file):
12213 Read color file from absolute filename (bug#8250).
12214
f2b726e6
JB
122152011-03-19 Juanma Barranquero <lekktu@gmail.com>
12216
12217 * makefile.w32-in: Update dependencies.
12218
09f6ff02
EZ
122192011-03-17 Eli Zaretskii <eliz@gnu.org>
12220
12221 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12222
29a6015a
PE
122232011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12224
a3a6c54e
PE
12225 Fix more problems found by GCC 4.5.2's static checks.
12226
b766f867
PE
12227 * process.c (make_serial_process_unwind, send_process_trap):
12228 (sigchld_handler): Now static.
12229
be02381c
PE
12230 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12231 That way, the code declares only the vars that it needs.
12232 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12233 * s/cygwin.h (PTY_ITERATION): Likewise.
12234 * s/darwin.h (PTY_ITERATION): Likewise.
12235 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12236
57048744
PE
12237 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12238 * process.c (allocate_pty): Don't declare stb unless it's needed.
12239
7914961c 12240 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12241 (CONSTANTLIM): Remove; unused.
12242 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12243 Define only if needed.
7914961c 12244
b3967b18
PE
12245 * unexelf.c (unexec): Name an expression,
12246 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12247 Use a different way to cause a compilation error if anyone uses
12248 n rather than nn, a way that does not involve shadowing.
73366a00 12249 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12250
29a6015a
PE
12251 * deps.mk (unexalpha.o): Remove; unused.
12252
43cfc33e 12253 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12254 * unexec.h: New file.
ce701a33
PE
12255 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12256 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12257 Depend on unexec.h.
12258 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12259 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12260 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12261 Change as necessary to match prototype in unexec.h.
ce701a33 12262
01f44d5a
PE
12263 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12264 shadowing.
4f63c6bb 12265 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12266
a6670b0b
PE
12267 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12268 Rename locals to avoid shadowing.
12269
cef2010d 12270 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12271 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12272
d4d7173a
PE
12273 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12274
f08b802a
PE
12275 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12276 warning when compiling print.c.
12277
3ddb0639
PE
12278 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12279 instead of using an uninitialized var.
5ad03b97 12280 (font_sort_entities): Mark var as initialized.
3ddb0639 12281
170a2692
PE
12282 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12283
e663c700
PE
12284 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12285 pointers to constants.
89bc529a 12286 (font_parse_fcname): Remove unused vars.
7b81e2d0 12287 (font_delete_unmatched): Now static.
ea838e10 12288 (font_get_spec): Remove; unused.
13a547c6
PE
12289 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12290 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12291 Rename or move locals to avoid shadowing.
e663c700 12292
2a80c887 12293 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12294 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12295
1384fa33 12296 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12297 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12298
8b2c52e9
PE
12299 * alloc.c (mark_backtrace): Move decl from here ...
12300 * lisp.h: ... to here, so that it can be checked.
12301
475545b5 12302 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12303 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12304 (lisp_indirect_variable): Name an expression,
12305 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12306 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12307
b1349114 12308 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12309 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12310 Use const pointer when appropriate.
b1349114 12311
a2928364
PE
12312 * lisp.h (get_system_name, get_operating_system_release):
12313 Move decls here, to check interfaces.
12314 * process.c (get_operating_system_release): Move decl to lisp.h.
12315 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12316 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12317 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12318 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12319 (Fformat_time_string, Fencode_time, Finsert_char):
12320 (Ftranslate_region_internal, Fformat):
12321 Rename or remove local vars to avoid shadowing.
9710023e 12322 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12323
a415e694
PE
12324 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12325 avoid shadowing.
12326
8ef4622d
PE
12327 * lisp.h (eassert): Check that the argument compiles, even if
12328 ENABLE_CHECKING is not defined.
12329
946f9a5b
PE
12330 * data.c (Findirect_variable): Name an expression, to avoid
12331 gcc -Wbad-function-cast warning.
112396d6 12332 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12333 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12334 (Fmake_variable_buffer_local, Fmake_local_variable):
12335 Mark variables as initialized.
52746918 12336 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12337
e5aab7e7 12338 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12339 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12340 Rename locals to avoid shadowing.
dff45157
PE
12341 (mark_stack): Move local variables into the #ifdef region where
12342 they're used.
7bc26fdb
PE
12343 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12344 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12345 needed otherwise.
12346 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12347 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12348 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12349
e5aab7e7
PE
12350 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12351 avoids undefined behavior in theory.
12352
4da60324
PE
12353 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12354
88043301
PE
12355 Use functions, not macros, for up- and down-casing (Bug#8254).
12356 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12357 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12358 to use the following functions instead of these macros.
12359 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12360 EMACS_INT, since callers assume the returned value fits in int.
12361 (upcase1): Likewise, for UPCASE_TABLE.
12362 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12363 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12364 the race-condition problem in the old DOWNCASE.
88043301 12365
19ed5445
PE
12366 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12367 Rename locals to avoid shadowing.
12368 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12369 (regex_compile, re_search_2, re_match_2_internal):
12370 Remove unused local vars.
952db0d7
PE
12371 (FREE_VAR): Rewrite so as not to use empty "else",
12372 which gcc can warn about.
da053e48 12373 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12374 (RETALLOC_IF): Define only if needed.
12375 (WORDCHAR_P): Likewise. This one is never needed, but is used
12376 only in a comment talking about a compiler bug, so put inside
12377 the #if 0 of that comment.
12378 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12379 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12380 Remove; unused.
19ed5445 12381
1f3561e4 12382 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12383 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12384 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12385
ded6f8f7
PE
12386 * search.c (simple_search): Remove unused var.
12387
dbd37a95
PE
12388 * dired.c (compile_pattern): Move decl from here ...
12389 * lisp.h: ... to here, so that it can be checked.
12390 (struct re_registers): New forward decl.
12391
7e47afad
PE
12392 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12393
85f24f61
PE
12394 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12395 All uses changed.
12396 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12397 Rename locals to avoid shadowing.
5671df8f 12398 (Fvertical_motion): Mark locals as initialized.
85f24f61 12399
181aa2be 12400 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12401 (casify_region): Mark local as initialized.
181aa2be 12402
930d429c
PE
12403 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12404
7082eac6
PE
12405 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12406 New macros, so that the caller can use some names other than
12407 gcpro1, gcpro2, etc.
12408 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12409 of the new macros.
12410 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12411 argument, for consistency with GCPRO2_VAR, etc: it is now the
12412 prefix of the variable, not the variable itself. All uses
12413 changed.
38b2c076
PE
12414 * dired.c (directory_files_internal, file_name_completion):
12415 Rename locals to avoid shadowing.
12416
15206ed9
PE
12417 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12418 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12419 dired.c's scmp function, had undefined behavior.
12420 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12421 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12422 * buffer.h: ... to here, because these macros use current_buffer,
12423 and the new implementation with inline functions needs to have
12424 current_buffer in scope now, rather than later when the macros
12425 are used.
12426 (downcase, upcase1): New static inline functions.
12427 (DOWNCASE, UPCASE1): Reimplement using these functions.
12428 This avoids undefined behavior in expressions like
12429 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12430 from race conditions in accessing the global variables
12431 case_temp1 and case_temp2.
12432 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12433 * lisp.h (case_temp1, case_temp2): Remove their decls.
12434 * character.h (ASCII_CHAR_P): Move from here ...
12435 * lisp.h: ... to here, so that the inline functions mentioned
12436 above can use them.
12437
4a6bea26
PE
12438 * dired.c (directory_files_internal_unwind): Now static.
12439
f14b7e14
PE
12440 * fileio.c (file_name_as_directory, directory_file_name):
12441 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12442 Now static.
2893f146
PE
12443 (file_name_as_directory): Use const pointers when appropriate.
12444 (Fexpand_file_name): Likewise. In particular, newdir might
12445 point at constant storage, so make it a const pointer.
fd4ead52 12446 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12447 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12448 signedness issues.
f839df0c
PE
12449 (Fset_file_times, Finsert_file_contents, auto_save_error):
12450 Rename locals to avoid shadowing.
f14b7e14 12451
5716756e 12452 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12453 (Ftry_completion, Fall_completions): Rename or remove locals
12454 to avoid shadowing.
5716756e 12455
b4c3046a
PE
12456 * marker.c (bytepos_to_charpos): Remove; unused.
12457
b45db522
PE
12458 * lisp.h (verify_bytepos, count_markers): New decls,
12459 so that gcc does not warn that these functions aren't declared.
12460
85876d07
PE
12461 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12462 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12463 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12464 (copy_text): Remove unused local var.
85876d07 12465
03d78a21 12466 * filelock.c (within_one_second): Now static.
b3dd38ab 12467 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12468
5df8f01b
PE
12469 * buffer.c (fix_overlays_before): Mark locals as initialized.
12470 (fix_start_end_in_overlays): Likewise. This function should be
12471 simplified by using pointers-to-pointers, but that's a different
12472 matter.
b1d876f1 12473 (switch_to_buffer_1): Now static.
8f54f30a
PE
12474 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12475 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12476
a70072c9 12477 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12478 Fix pointer signedness issue.
edced198
PE
12479 (sys_subshell): Mark local as volatile if checking for lint,
12480 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12481 (MAXPATHLEN): Define only if needed.
a70072c9 12482
a0977c44
PE
12483 * process.c (serial_open, serial_configure): Move decls from here ...
12484 * systty.h: ... to here, so that they can be checked.
12485
a884fdcc
PE
12486 * fns.c (get_random, seed_random): Move extern decls from here ...
12487 * lisp.h: ... to here, so that they can be checked.
12488
604efe86 12489 * sysdep.c (reset_io): Now static.
b8950c94 12490 (wait_for_termination_signal): Remove; unused.
604efe86 12491
38fc62d9
PE
12492 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12493 (copy_keymap_item, append_key, push_text_char_description):
12494 Now static.
1004a21a 12495 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12496 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12497 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12498 (describe_map_tree):
12499 Rename locals to avoid shadowing.
38fc62d9 12500
2f2650da
PE
12501 * keyboard.c: Declare functions static if they are not used elsewhere.
12502 (echo_char, echo_dash, cmd_error, top_level_2):
12503 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12504 (read_char, kbd_buffer_get_event, make_lispy_position):
12505 (make_lispy_event, make_lispy_movement, apply_modifiers):
12506 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12507 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12508 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12509 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12510 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12511
a053e86c 12512 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12513 (mark_kboards): Move decl here ...
12514 * alloc.c (mark_kboards): ... from here.
a053e86c 12515
4752793e
PE
12516 * lisp.h (force_auto_save_soon): New decl.
12517
74f10ca7 12518 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12519 (DEFINE_DUMMY_FUNCTION): New macro.
12520 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12521 Use it.
c03cd23f
PE
12522 (main): Add casts to avoid warnings
12523 if GCC considers string literals to be constants.
74f10ca7 12524
022e70d4
PE
12525 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12526
59d6fe83
PE
12527 * dbusbind.c: Pointer signedness fixes.
12528 (xd_signature, xd_append_arg, xd_initialize):
12529 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12530 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12531 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12532 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12533
78320123
PE
12534 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12535 if GCC considers string literals to be constants.
49cebcca 12536 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12537
35ac2a97
SM
125382011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12539
fb103ca9
SM
12540 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12541 (print_preprocess, print_object): New macro to fix last change.
12542
35ac2a97
SM
12543 * print.c (print_preprocess): Don't forget font objects.
12544
62973b41
JB
125452011-03-16 Juanma Barranquero <lekktu@gmail.com>
12546
12547 * emacs.c (USAGE3): Doc fixes.
12548
0e48bb22
AS
125492011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12550
12551 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12552 structure.
12553
7684e57b
JB
125542011-03-14 Juanma Barranquero <lekktu@gmail.com>
12555
12556 * lisp.h (VWindow_system, Qfile_name_history):
12557 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12558 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12559 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12560
12561 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12562 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12563
12564 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12565 * w32console.c (detect_input_pending, read_input_pending)
12566 (encode_terminal_code):
12567 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12568 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12569 (w32_system_caret_y, Qfile_name_history):
12570 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12571 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12572 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12573 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12574 * w32proc.c (Qlocal, report_file_error):
12575 * w32term.c (Vwindow_system, updating_frame):
12576 * w32uniscribe.c (initialized, uniscribe_font_driver):
12577 Remove unneeded extern declarations.
12578
2aa46d6c
CY
125792011-03-14 Chong Yidong <cyd@stupidchicken.com>
12580
c96bbc66 12581 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12582
cffc6f3b
CY
125832011-03-13 Chong Yidong <cyd@stupidchicken.com>
12584
12585 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12586 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12587 These macros can no longer be used for assignment.
12588
44f230aa
SM
12589 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12590 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12591 (record_buffer_markers, fetch_buffer_markers): New functions for
12592 recording and fetching special buffer markers.
12593 (set_buffer_internal_1, set_buffer_temp): Use them.
12594
12595 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12596
12597 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12598
12599 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12600 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12601
12602 * xdisp.c (hscroll_window_tree):
12603 (reconsider_clip_changes): Use PT instead of BUF_PT.
12604
d251f04b
EZ
126052011-03-13 Eli Zaretskii <eliz@gnu.org>
12606
12607 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12608 $(EMACS_ROOT)/lib/intprops.h.
12609
f0c77cd1
PE
126102011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12611
3eca4629
PE
12612 Fix more problems found by GCC 4.5.2's static checks.
12613
7c86ee98
PE
12614 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12615 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12616 (xg_free_frame_widgets): Make it clear that a local variable is
12617 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12618 (gdk_window_get_screen): Make it clear that this macro is needed
12619 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12620 (int_gtk_range_get_value): New function, which avoids a diagnostic
12621 from gcc -Wbad-function-cast.
12622 (xg_set_toolkit_scroll_bar_thumb): Use it.
12623 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12624 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12625 (get_utf8_string, xg_get_file_with_chooser):
12626 Rename locals to avoid shadowing.
12627 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12628
41729b81
PE
12629 * xgselect.c (xg_select): Remove unused var.
12630
f0c77cd1
PE
12631 * image.c (four_corners_best): Mark locals as initialized.
12632 (gif_load): Initialize transparent_p to zero (Bug#8238).
12633 Mark another local as initialized.
ec6cf4c6 12634 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12635
ce0ad53d 12636 * image.c (clear_image_cache): Now static.
d5d5a617 12637 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12638 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12639 (x_edge_detection): Remove unnecessary cast that
12640 gcc -Wbad-function-cast diagnoses.
2037898d 12641 (gif_load): Fix pointer signedness.
6ae141d6
PE
12642 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12643 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12644
33383987 126452011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12646
d32df629
PE
12647 Improve quality of tests for time stamp overflow.
12648 For example, without this patch (encode-time 0 0 0 1 1
12649 1152921504606846976) returns the obviously-bogus value (-948597
12650 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12651 reports time overflow. See
12652 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12653 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12654 * editfns.c: Include limits.h and intprops.h.
12655 (TIME_T_MIN, TIME_T_MAX): New macros.
12656 (time_overflow): Move earlier, to before first use.
12657 (hi_time, lo_time): New functions, for an accurate test for
12658 out-of-range times.
12659 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12660 (Fget_internal_run_time): Don't assume time_t fits in int.
12661 (make_time): Use list2 instead of Fcons twice.
12662 (Fdecode_time): More accurate test for out-of-range times.
12663 (check_tm_member): New function.
12664 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12665 (lisp_time_argument): Don't rely on undefined left-shift and
12666 right-shift behavior when checking for time stamp overflow.
8be6f318 12667
fe31d94c
PE
12668 * editfns.c (time_overflow): New function, refactoring common code.
12669 (Fformat_time_string, Fdecode_time, Fencode_time):
12670 (Fcurrent_time_string): Use it.
12671
8be6f318
PE
12672 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12673 * dired.c (make_time): Move to ...
12674 * editfns.c (make_time): ... here.
12675 * systime.h: Note the move.
12676
09d9db2c 126772011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12678
126bc0dc
YM
12679 * fringe.c (update_window_fringes): Remove unused variables.
12680
c47cbdfd
YM
12681 * unexmacosx.c (copy_data_segment): Also copy __got section.
12682 (Bug#8223)
12683
7ac80be9
EZ
126842011-03-12 Eli Zaretskii <eliz@gnu.org>
12685
c96bbc66 12686 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12687 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12688 Constify `char *' arguments and their references according to
12689 prototypes in tparam.h.
12690
ecb0f94d 12691 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12692
7ac80be9
EZ
12693 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12694 Adapt all references accordingly.
12695
12696 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12697
ef1fd07e
TT
126982011-03-11 Tom Tromey <tromey@redhat.com>
12699
12700 * buffer.c (syms_of_buffer): Remove obsolete comment.
12701
7ef4b50c
EZ
127022011-03-11 Eli Zaretskii <eliz@gnu.org>
12703
12704 * termhooks.h (encode_terminal_code): Declare prototype.
12705
12706 * msdos.c (encode_terminal_code): Don't declare prototype.
12707
12708 * term.c (encode_terminal_code): Now external again, used by
12709 w32console.c and msdos.c.
12710
44f230aa
SM
12711 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12712 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12713
4b1ec863 127142011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12715
1714f52b 12716 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12717
4b1ec863
PE
12718 * fringe.c (update_window_fringes): Mark locals as initialized
12719 (Bug#8227).
12720 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12721
524c7aa6
PE
12722 * alloc.c (mark_fringe_data): Move decl from here ...
12723 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12724 to check its interface.
12725 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12726
a5c0af81 12727 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12728 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12729 (fontset_font): Mark local as initialized.
a9a06e0b 12730 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12731
b4716021
PE
12732 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12733
811e9bac 12734 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12735 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12736 (x_own_selection, Fx_disown_selection_internal): Rename locals
12737 to avoid shadowing.
12738 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12739
7e3ab302
PE
12740 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12741 so that the caller can use some name other than gcpro1.
12742 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12743 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12744 (Fx_backspace_delete_keys_p):
12745 Use them to avoid shadowing, and rename vars to avoid shadowing.
12746 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12747 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12748 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12749 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12750 Remove unused locals.
7e3ab302
PE
12751 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12752 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12753 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12754 macros.
f78faa98 12755
e2b13473
PE
12756 * xterm.h (x_mouse_leave): New decl.
12757
77f23912
PE
12758 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12759 Remove unused functions.
cdf4ba58
PE
12760 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12761 (x_calc_absolute_position): Now static.
7411c686 12762 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12763 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12764 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12765 unless they are used.
38d0b34a
PE
12766 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12767 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12768 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12769 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12770 (x_error_catcher, x_connection_closed, x_error_handler):
12771 (x_error_quitter, xembed_send_message, x_iconify_frame):
12772 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12773 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12774 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12775
44f230aa
SM
12776 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12777 Rename or move locals to avoid shadowing.
6b463e58 12778 (tty_defined_color, merge_face_heights): Now static.
5967d051 12779 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12780 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12781 does not deduce is never used uninitialized.
73719eba
PE
12782 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12783 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12784
426994c3 12785 * terminal.c (store_terminal_param): Now static.
5489860b 12786
032f1620 12787 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12788 (set_frame_menubar): Remove unused local.
d4323972 12789 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12790 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12791 since they might point to immutable storage.
281585b0
PE
12792 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12793 since it's unused otherwise.
032f1620 12794
367c19e5 12795 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12796 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12797 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12798 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12799 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12800 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12801 does not deduce are never used uninitialized.
70739cbe 12802
07b48fa9
PE
12803 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12804
8868a238 12805 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12806 * window.c (window_loop, size_window):
12807 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12808
7e5cf297 12809 * window.c (display_buffer): Now static.
d6550a9f
PE
12810 (size_window): Mark variables that gcc -Wuninitialized
12811 does not deduce are never used uninitialized.
a586633d
PE
12812 * window.h (check_all_windows): New decl, to forestall
12813 gcc -Wmissing-prototypes diagnostic.
5b555da1 12814 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12815
f6095868
PE
12816 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12817 shadowing.
12818 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12819 Include <limits.h>.
12820 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12821 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12822 (load_charset_map): Mark variables that gcc -Wuninitialized
12823 does not deduce are never used uninitialized.
53df7c11 12824 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12825
f38b440c
PE
12826 * coding.c (coding_set_source, coding_set_destination):
12827 Use "else { /* comment */ }" rather than "else /* comment */;"
12828 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12829 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12830 a block, when the outer 'i' will do.
12831 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12832 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12833 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12834 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12835 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12836 Rename locals to avoid shadowing.
12837 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12838 * coding.c (emacs_mule_char, encode_invocation_designation):
12839 Now static, since they're not used elsewhere.
413bb2db 12840 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12841 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12842 (decode_coding_emacs_mule): Mark variables that gcc
12843 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12844 (detect_coding_iso_2022): Initialize a local variable that might
12845 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12846 this initialization is needed. (Bug#8211)
5f58e762
PE
12847 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12848 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12849 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12850 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12851 Remove unused macros.
f38b440c 12852
232b38b9 12853 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12854 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12855 * character.c (string_count_byte8): Likewise.
232b38b9 12856
fb90da1b
PE
12857 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12858 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12859
fb93dbc2
PE
12860 * chartab.c (copy_sub_char_table): Now static, since it's not used
12861 elsewhere.
5c156ace
PE
12862 (sub_char_table_ref_and_range, char_table_ref_and_range):
12863 Rename locals to avoid shadowing.
bbcd0949 12864 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12865
7d3b3862 12866 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12867 (BIDI_BOB): Remove unused macro.
7d3b3862 12868
6be7d3da
PE
12869 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12870 deduce are never used uninitialized.
c2ed9c8b 12871 * term.c (encode_terminal_code): Likewise.
6be7d3da 12872
75f8807f 12873 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12874
50938595
PE
12875 * tparam.h: New file.
12876 * term.c, tparam.h: Include it.
12877 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12878 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12879 Move these decls to tparam.h, and make them agree with what
12880 is actually in tparam.c. The previous trick of using incompatible
12881 decls in different modules does not conform to the C standard.
12882 All callers of tparam changed to use tparam's actual API.
12883 * tparam.c (tparam1, tparam, tgoto):
12884 Use const pointers where appropriate.
12885
fbceeba2
PE
12886 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12887 * cm.h (struct cm): Likewise.
12888 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12889 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12890 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12891 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12892 (turn_on_face, init_tty): Likewise.
12893 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12894
7f3f1250
PE
12895 * term.c (term_mouse_position): Rename local to avoid shadowing.
12896
e6ca6543
PE
12897 * alloc.c (mark_ttys): Move decl from here ...
12898 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12899
c40f8d15
AS
129002011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12901
12902 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12903
cfe0661d
JB
129042011-03-09 Juanma Barranquero <lekktu@gmail.com>
12905
12906 * search.c (compile_pattern_1): Remove argument regp, unused since
12907 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12908 (compile_pattern): Don't pass it.
12909
0afb4571
J
129102011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12911
12912 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12913 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12914 for ! HAVE_GTK3.
12915 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12916
12917 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12918
12919 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12920 gdk_window_get_screen, gdk_window_get_geometry,
12921 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12922 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12923 (xg_get_pixbuf_from_pixmap): New function.
12924 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12925 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12926 Call xg_get_pixbuf_from_pixmap instead of
12927 gdk_pixbuf_get_from_drawable.
12928 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12929 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12930 (xg_check_special_colors): Use GtkStyleContext and its functions
12931 for HAVE_GTK3.
12932 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12933 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12934 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12935 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12936 Call gtk_widget_get_preferred_size.
0afb4571
J
12937 (xg_frame_resized): gdk_window_get_geometry only takes 5
12938 parameters.
44f230aa
SM
12939 (xg_win_to_widget, xg_event_is_for_menubar):
12940 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12941 (xg_set_widget_bg): New function.
12942 (delete_cb): New function.
895009e1 12943 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12944 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12945 (xg_set_background_color): Call xg_set_widget_bg.
12946 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12947 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12948 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12949 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12950 if ! HAVE_GTK3.
12951 (update_frame_tool_bar): Call gtk_widget_hide.
12952 (xg_initialize): Use GDK_KEY_g.
12953
12954 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12955 if ! HAVE_GTK3
12956 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12957
12958 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12959 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12960 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12961
1c2cc4ef
JB
129622011-03-08 Juanma Barranquero <lekktu@gmail.com>
12963
12964 * w32xfns.c (select_palette): Check success of RealizePalette against
12965 GDI_ERROR, not zero.
12966
33383987 12967See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12968
12969;; Local Variables:
12970;; coding: utf-8
aac0c6e3
MR
12971;; End:
12972
2f097256 12973 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12974
12975 This file is part of GNU Emacs.
12976
12977 GNU Emacs is free software: you can redistribute it and/or modify
12978 it under the terms of the GNU General Public License as published by
12979 the Free Software Foundation, either version 3 of the License, or
12980 (at your option) any later version.
12981
12982 GNU Emacs is distributed in the hope that it will be useful,
12983 but WITHOUT ANY WARRANTY; without even the implied warranty of
12984 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12985 GNU General Public License for more details.
12986
12987 You should have received a copy of the GNU General Public License
12988 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.