Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c32af1e4
PE
12012-07-30 Paul Eggert <eggert@cs.ucla.edu>
2
3 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
4 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
5 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
6 gdb_make_enums_visible.
7 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
8 (DIRECTORY_SEP): Now a constant, not a macro.
9
302fc036
EZ
102012-07-30 Eli Zaretskii <eliz@gnu.org>
11
12 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
13 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
14
15 * w32term.c <w32_keyboard_codepage>: Renamed from
16 keyboard_codepage and now external. All users changed.
17
18 * w32term.h: Add declaration of w32_keyboard_codepage.
19
20 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
21 the codepage to translate keys to Unicode. If this argument is
22 -1, use the value returned by GetConsoleCP. All callers changed.
23
88fb40b4
PE
242012-07-30 Paul Eggert <eggert@cs.ucla.edu>
25
0aee6912
PE
26 Update .PHONY listings in makefiles.
27 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
28 bootstrap-clean, distclean, maintainer-clean, versioclean,
29 extraclean, frc.
30
88fb40b4
PE
31 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
32 This is a bit clearer. Fix some commentary typos.
33
0a763bd1
GM
342012-07-30 Glenn Morris <rgm@gnu.org>
35
32bac6d6
GM
36 * s/netbsd.h: Let configure include signal.h if needed.
37 Remove file, which is now empty.
38
b65e7c46
GM
39 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
40 Let configure set them.
41 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
42 No more need to undefine.
0a763bd1 43
169304bd
AS
442012-07-30 Andreas Schwab <schwab@linux-m68k.org>
45
46 * keymap.c (Fkey_description): Don't remove 0x80 bit from
47 non-single-byte char when adding meta modifier. (Bug#12090)
48
6cd7a139
DA
492012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
50
51 Convert safe_call to use variable number of arguments.
52 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
53 (safe_call2): Fix comment.
54 * lisp.h (safe_call): Adjust prototype.
55 * coding.c (encode_coding_object): Change to use safe_call2.
56 * xfaces.c (merge_face_heights): Change to use safe_call1.
57
d34d6ffc
GM
582012-07-30 Glenn Morris <rgm@gnu.org>
59
7b8a48e4 60 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 61 does that unconditionally. Remove file, which is now empty.
7b8a48e4 62
d34d6ffc
GM
63 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
64 Remove empty files.
65
03a660a6
PE
662012-07-30 Paul Eggert <eggert@cs.ucla.edu>
67
68 Export to GDB most of lisp.h's remaining object-like macros.
69 * lisp.h (min, max): Move earlier, because they're used earlier now.
70 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
71 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
72 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
73 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
74 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
75 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
76 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
77 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
78 Now constants, for GDB. They need not be macros.
79 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
80 Now constants, for GDB, as well as macros, for static initializers.
81 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
82 Move to after the definition of struct Lisp_Char_Table,
83 since the former now needs that type defined.
84 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
85 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
86 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
87 New enums, for gdb_make_enums_visible.
88 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 89 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
90 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
91 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
92 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
93 enum maxargs, enum MAX_ALLOCA.
94 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
95 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
96 no longer needed, now that they are done in lisp.h.
97
e499d0ee
DA
982012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
99
100 Cleanup string bytes checking.
101 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
102 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
103 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
104 (check_sblock, compact_small_strings): Simplify.
105
d5040d2d
PE
1062012-07-29 Paul Eggert <eggert@cs.ucla.edu>
107
108 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
109 These macros are confusing and no longer need to be defined, as
110 the enum values now suffice. All uses replaced with definiens.
111 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
112
7f259ae6
JB
1132012-07-29 Juanma Barranquero <lekktu@gmail.com>
114
115 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
116 ($(BLD)/w32console.$(O)): Update dependencies.
117
7e63e0c3
DA
1182012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
119
120 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
121 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
122 time. Adjust users.
123 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
124
ffd817eb
JD
1252012-07-29 Jan Djärv <jan.h.d@swipnet.se>
126
127 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
128 setting sitelisp (Bug#12010).
129
417a7a0e
EZ
1302012-07-29 Eli Zaretskii <eliz@gnu.org>
131
132 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
133
134 * w32heap.c (cache_system_info):
135 * w32.c (sys_rename):
136 * w32proc.c (find_child_console, sys_kill): All users changed.
137
387d4d92
PE
1382012-07-29 Paul Eggert <eggert@cs.ucla.edu>
139
140 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
141
55a6cca6
EZ
1422012-07-29 Eli Zaretskii <eliz@gnu.org>
143
144 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
145
dbcf001c
DA
1462012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
147
148 Cleanup statistics calculation in Fgarbage_collect.
149 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
150 zombies percentage calculation. Simplify elapsed time calculation.
151
e2688e4a
DA
1522012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
153
154 Generalize marker debugging code under MARKER_DEBUG and use eassert.
155 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
156 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
157 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
158 (replace_range, replace_range_2, del_range_2): Change to eassert.
159 * marker.c (byte_char_debug_check): Adjust style.
160
b46a6a83
PE
1612012-07-29 Paul Eggert <eggert@cs.ucla.edu>
162
163 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
164 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
165 long-ago-commented-out code that talks about "WIN32".
166 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
167 All uses changed.
168
e32a5799
PE
1692012-07-28 Paul Eggert <eggert@cs.ucla.edu>
170
171 Use Gnulib stdalign module (Bug#9772, Bug#9960).
172 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
173 Simplify by using alignof.
174 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
175 * lisp.h: Include <stdalign.h>.
176 (GCALIGNMENT): New macro and constant.
177 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
178 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
179 (stdalign): New macro, if not already defined.
180
df81cd29
EZ
1812012-07-28 Eli Zaretskii <eliz@gnu.org>
182
01bd1b0d
EZ
183 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
184 * w32inevt.c: Include w32inevt.h.
185 (w32_read_console_input): New inline function, calls either
186 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
187 w32_console_unicode_input.
188 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
189 (w32_kbd_patch_key, key_event): Use the codepage returned by
190 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
191 (key_event): use uChar.UnicodeChar only if
192 w32_console_unicode_input is non-zero.
193
194 * w32console.c: Include w32heap.h.
195 <w32_console_unicode_input>: New global variable.
196 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
197 family of Windows, zero otherwise.
198
199 * w32inevt.h: Declare w32_console_unicode_input.
200
df81cd29
EZ
201 * xdisp.c (init_iterator): Don't reference tip_frame in a build
202 --without-x. (Bug#11742)
203
c20fdd9e
PE
2042012-07-27 Paul Eggert <eggert@cs.ucla.edu>
205
206 Adjust GDB to reflect pvec_type changes (Bug#12036).
207 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
208 2012-07-04 changes to pseudovector representation. Problem
209 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
210
32770973 2112012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
212
213 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
214 bus address.
215 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
216
3438fe21
EZ
2172012-07-27 Eli Zaretskii <eliz@gnu.org>
218
bcfbc9de
EZ
219 * alloc.c (listn): Fix the order the arguments are consed onto the
220 list.
221
3438fe21
EZ
222 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
223 enumeration constants, as PURE and HEAP are too general, and clash
224 with other headers and sources, such as gmalloc.c and the
225 MS-Windows system headers. All users changed.
226
eeaea515
DA
2272012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
228
229 Revert last save_excursion_save and save_excursion_restore changes.
230 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
231 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
232
073c88c2
DA
2332012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
234
235 Fix recently-introduced typos in Windows port.
236 Reported by Martin Rudalics <rudalics@gmx.at>.
237 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 238 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 239
4706125e
PE
2402012-07-27 Paul Eggert <eggert@cs.ucla.edu>
241
242 Improve GDB symbol export (Bug#12036).
243 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
244 arms of an 'if', not using conditional expressions; otherwise GDB
245 complains about the types in the unevaluated arm when the argument
246 is an integer literal.
247 (xgetint): Simplify expression.
248 * alloc.c (gdb_make_enums_visible): New constant. This ports to
249 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
250 Zaretskii in <http://bugs.gnu.org/12036#13>.
251 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
252 needed now that we have gdb_make_enums_visible.
253 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
254 (enum enum_USE_LSB_TAG):
255 New enum types, packaging up enums that need to be exported to GDB.
256
694b6c97
DA
2572012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
258
259 Utility function to make a list from specified amount of objects.
260 * lisp.h (enum constype): New datatype.
261 (listn): New prototype.
262 * alloc.c (listn): New function.
263 (Fmemory_use_count, syms_of_alloc): Use it.
264 * buffer.c (syms_of_buffer): Likewise.
265 * callint.c (syms_of_callint): Likewise.
266 * charset.c (define_charset_internal): Likewise.
267 * coding.c (syms_of_coding): Likewise.
268 * keymap.c (syms_of_keymap): Likewise.
269 * search.c (syms_of_search): Likewise.
270 * syntax.c (syms_of_syntax): Likewise.
271 * w32.c (init_environment): Likewise.
272 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
273 * xdisp.c (syms_of_xdisp): Likewise.
274 * xfns.c (syms_of_xfns): Likewise.
275
6195f384
DA
2762012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
277
278 Fast save_excursion_save and save_excursion_restore.
279 * lisp.h (struct Lisp_Excursion): New data type.
280 (PVEC_EXCURSION): New pseudovector type.
281 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
282 to deal with it. Adjust comments.
283 (init_marker, attach_marker): New prototype.
284 (unchain_marker): Adjust prototype.
285 * marker.c (attach_marker): Change to global.
286 (init_marker): New function.
287 * alloc.c (Fmake_marker, build_marker): Use it.
288 (build_marker): More easserts.
289 (mark_object): Handle struct Lisp_Excursion.
290 * editfns.c (save_excursion_save, save_excursion_restore):
291 Reimplement to use struct Lisp_Excursion. Add comments.
292
5eceb8fb
PE
2932012-07-26 Paul Eggert <eggert@cs.ucla.edu>
294
295 Fix export of symbols to GDB (Bug#12036).
296 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
297 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
298 emacs.c, as this is a more-suitable home. Had this been done earlier
299 the fix for 12036 would have avoided some of the problems noted in
300 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
301 would have been more obvious.
562157c8
PE
302 * emacs.c: Do not include <verify.h>; no longer needed.
303 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
304 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
305 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
306 Remove; now done in lisp.h.
307 * lisp.h (PUBLISH_TO_GDB): New macro.
308 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
309 (DATA_SEG_BITS): Use it.
310 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
311 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
312 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
313 not be usable in #if. This simplifies things.
314
d6749401
JB
3152012-07-26 Juanma Barranquero <lekktu@gmail.com>
316
317 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
318
1781b9e9
PE
3192012-07-26 Paul Eggert <eggert@cs.ucla.edu>
320
d89518db 321 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
322 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
323 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
324 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
325 Adjust to changes in lisp.h and emacs.c, by using
326 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
327 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
328 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
329 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
330 instead of gdb_valbits.
331 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
332 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
333 instead of gdb_array_mark_flag.
334 (xboolvector): Get size from $->size, not $->header.size.
335 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
336 (xreload, hook-run, hookpost-run): Remove.
337 * emacs.c: Include <verify.h>.
338 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
339 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
340 Remove.
341 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
342 (gdb_USE_LSB_TAG): New enum constants.
343 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
344 Also define these as enum constants, so they're visible to GDB.
345 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
346 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
347 as constants, so they're visible to GDB.
348 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
349 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
350 Now enum constants, not macros, so they're visible to GDB.
351 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
352 more convenient now. All uses changed.
353 (VALMASK) [USE_LSB_TAG]: Also define in this case.
354 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
355
3628596a
DA
3562012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
357
358 Explicitly free restriction data that are not needed anymore.
359 * editfns.c (save_restriction_restore): Free restriction data.
360
7abaf5cc
SM
3612012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
362
363 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
364 add argument, tune behavior, and adjust all callers.
365
71f88e00
PE
3662012-07-25 Paul Eggert <eggert@cs.ucla.edu>
367
368 Use typedef for EMACS_INT, EMACS_UINT.
369 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
370 than macros. This simplifies debugging in the usual case, since
371 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
372 and it allows expressions involving EMACS_INT casts.
373 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
374
57ec3034
JD
3752012-07-25 Jan Djärv <jan.h.d@swipnet.se>
376
377 * nsterm.m (ns_read_socket): Return early if there is a modal
378 window (Bug#12043).
379
8137e7b3
MR
3802012-07-25 Martin Rudalics <rudalics@gmx.at>
381
382 * frame.c (Fredirect_frame_focus): In doc-string don't mention
383 that FOCUS-FRAME can be omitted.
384
04e9897c
DA
3852012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
386
387 Adjust buffer text indirection counters at the end of Fkill_buffer.
388 * buffer.c (Fkill_buffer): Adjust indirection counters when the
389 buffer is definitely dead. This should really fix an issue reported
390 by Christoph Scholtes again. (Bug#12007).
391 (init_buffer_once): Initialize indirection counters of
392 buffer_defaults and buffer_local_symbols (for sanity and safety).
393
8a0484e1
EZ
3942012-07-24 Eli Zaretskii <eliz@gnu.org>
395
396 * xdisp.c (init_iterator): Don't compute dimensions of truncation
397 and continuation glyphs on tooltip frames, leave them at zero.
398 Avoids continued lines in tooltips. (Bug#11832)
399
fa691a83
DA
4002012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
401
402 Simplify copy_overlay.
04e9897c 403 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
404 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
405
436bc8e0
EZ
4062012-07-23 Eli Zaretskii <eliz@gnu.org>
407
408 * print.c (print_object): Don't crash when a frame's name is nil
409 or invalid. (Bug#12025)
410
411 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
412 it signals an error when a tooltip frame is being created.
413
d7a7fda3
DA
4142012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
415
416 Cleanup miscellaneous objects allocation and initialization.
417 * alloc.c (allocate_misc): Change to static. Add argument to
418 specify the subtype. Adjust comment and users.
419 (build_overlay): New function.
420 * buffer.c (copy_overlays, Fmake_overlay): Use it.
421 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
422 (allocate_misc): Remove prototype.
423 (build_overlay): Add prototype.
424
4252012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
426
427 Swap buffer text indirection counters in Fbuffer_swap_text.
428 * buffer.c (Fbuffer_swap_text): Swap indirections too.
429 This avoids crash reported by Christoph Scholtes at
430 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
431
9d7fa573
JD
4322012-07-22 Jan Djärv <jan.h.d@swipnet.se>
433
434 * nsmenu.m (Popdown_data): New struct.
435 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
436 free Popdown_data.
437 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
438 (initWithContentRect): Make imgView and contentView non-static
439 and autorelease them. Also autorelease img and matrix (Bug#12005).
440 (dealloc): Remove (Bug#12005).
441
0dd6d66d
DA
4422012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
443
444 Adjust consing_since_gc when objects are explicitly freed.
445 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
446 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
447 (free_cons, free_misc): Subtract object size from consing_since_gc.
448
d36d71df
DA
4492012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
450
451 Simplify and cleanup markers positioning code.
452 * marker.c (attach_marker): More useful eassert.
453 (live_buffer, set_marker_internal): New function.
454 (Fset_marker, set_marker_restricted): Use set_marker_internal.
455 (set_marker_both, set_marker_restricted_both): Use live_buffer.
456
fb9ea40f
PE
4572012-07-22 Paul Eggert <eggert@cs.ucla.edu>
458
459 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
460 as it's limited by the amount of memory, not by INT_MAX.
461
2d5c5f7d
EZ
4622012-07-21 Eli Zaretskii <eliz@gnu.org>
463
07fb592e
EZ
464 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
465 in special-event-map. See the discussion at
466 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
467 for the reasons.
468
37a9eac8 469 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
470 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
471 Fabrice Popineau <fabrice.popineau@supelec.fr>.
472
c4328746
JD
4732012-07-21 Jan Djärv <jan.h.d@swipnet.se>
474
475 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 476 (conversationIdentifier): Return value is NSInteger.
784051c4 477 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 478
6e5d1c12
CY
4792012-07-21 Chong Yidong <cyd@gnu.org>
480
481 * window.c (decode_any_window): Signal an error if the window is
482 on a dead frame (Bug#11984).
483
9928463d
DA
4842012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
485
486 Add indirection counting to speed up Fkill_buffer.
487 * buffer.h (struct buffer): New member.
488 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
489 (Fmake_indirect_buffer): Set indirection counter to -1, increment
490 base buffer indirection counter.
491 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
492 (Fkill_buffer): Adjust indirection counters as needed, don't walk
493 through buffer list if indirection counter is 0.
494
f8643a6b
DA
4952012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
496
497 Extend the value returned by Fgarbage_collect with heap statistics.
498 * alloc.c (Qheap): New symbol.
499 (syms_of_alloc): DEFSYM it.
500 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
501 (Fmemory_free): Remove.
502 (syms_of_alloc): Don't defsubr it.
503 * buffer.c (Fcompact_buffer): Remove.
504 (syms_of_buffer): Don't defsubr it.
505
dac616ff
DA
5062012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
507
508 Make maybe_gc inline.
509 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
510 * lisp.h (consing_since_gc, gc_relative_threshold)
511 (memory_full_cons_threshold): Revert declaration.
512 (maybe_gc): Remove prototype, define as inline.
513 * alloc.c: Remove old commented-out code.
514 (consing_since_gc, gc_relative_threshold)
515 (memory_full_cons_threshold): Revert to global.
516 (maybe_gc): Remove.
517
d7ea76b4
DA
5182012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
519
520 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
521 * lisp.h (build_unibyte_string): New function.
522 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
523 * sysdep.c, w32fns.c, xfns.c: Use it.
524 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
525 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
526 Adjust users accordingly.
527 * font.h (font_open_by_name): Adjust prototype.
528
765e61e3
DA
5292012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
530
531 Cleanup calls to Fgarbage_collect.
532 * lisp.h (maybe_gc): New prototype.
533 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
534 Remove declarations.
535 * alloc.c (maybe_gc): New function.
536 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
537 Make them static.
538 * bytecode.c (MAYBE_GC): Use maybe_gc.
539 * eval.c (eval_sub, Ffuncall): Likewise.
540 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
541 to avoid dependency from auto-save feature.
542
52b852c7
PE
5432012-07-19 Paul Eggert <eggert@cs.ucla.edu>
544
545 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
546 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
547 'for_each_per_buffer_object_at'.
548 All uses changed. It's better to use upper-case for macros that
549 cannot be implemented as functions, to give the reader a clue
550 that they're special.
551
5db81e33
SM
5522012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
553
554 * alloc.c (Fgarbage_collect): Tweak docstring.
555
5b835e1d
DA
5562012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
557
558 Tweak the value returned from Fgarbage_collect again.
559 * alloc.c (Fgarbage_collect): New return value, as confirmed in
560 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
561 Adjust documentation.
562 (total_vector_bytes): Rename to total_vector_slots, adjust
563 accounting.
564 (total_free_vector_bytes): Rename to total_free_vector_slots,
565 adjust accounting.
566 (Qstring_bytes, Qvector_slots): New symbols.
567 (syms_of_alloc): DEFSYM them.
568
9cd47b72
DA
5692012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
570
571 Buffer compaction primitive which may be used from Lisp.
572 * buffer.c (compact_buffer, Fcompact_buffer): New function.
573 (syms_of_buffer): Register Fcompact_buffer.
574 * alloc.c (Fgarbage_collect): Use compact_buffer.
575 * buffer.h (compact_buffer): New prototype.
576 (struct buffer_text): New member.
577
d17337e5
DA
5782012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
579
580 New macro to iterate over all buffers, miscellaneous cleanups.
581 * lisp.h (all_buffers): Remove declaration.
582 * buffer.h (all_buffers): Add declaration, with comment.
583 (for_each_buffer): New macro.
584 * alloc.c (Fgarbage_collect, mark_object): Use it.
585 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
586 (init_buffer): Likewise.
587 * data.c (Fset_default): Likewise.
588 * coding.c (code_conversion_restore): Remove redundant check
589 for dead buffer.
590 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
591
60cfd278
AS
5922012-07-18 Andreas Schwab <schwab@linux-m68k.org>
593
594 Fix bug that created negative-length intervals.
595 * intervals.c (merge_interval_right, merge_interval_left):
596 Do not zero out this interval if it is absorbed by its children,
597 as this interval's total length doesn't change in that case. See
598 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
599
d06714cb
PE
6002012-07-18 Paul Eggert <eggert@cs.ucla.edu>
601
83713154
PE
602 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
603 when invoking (make-bool-vector N t) and N is a positive
604 multiple of 8 -- the last 8 bits were mistakenly cleared.
605
d06714cb
PE
606 Remove some struct layout assumptions in bool vectors.
607 * alloc.c (bool_header_size): New constant.
608 (header_size, word_size): Move earlier, as they're now used earlier.
609 Use 'word_size' in a few more places, where it's appropriate.
610 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
611 padding before the data member of a bool vector.
612 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
613 than doing the check by hand with an abort ().
614
464d5a5e
SM
6152012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
616
5fbc0409
SM
617 * eval.c (Fdefvar): Don't check constants since we only set the var if
618 it's not yet defined anyway (bug#11904).
619
464d5a5e
SM
620 * lisp.h (last_undo_boundary): Declare new var.
621 * keyboard.c (command_loop_1): Set it.
622 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
623 were auto-added by the command loop (bug#11774).
624
8dc2e44a
AS
6252012-07-18 Andreas Schwab <schwab@linux-m68k.org>
626
627 * w32font.c (Qsymbol): Remove local definition.
628 (syms_of_w32font): Don't DEFSYM it.
629
169925ec
DA
6302012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
631
632 Fix sweep_vectors to handle large bool vectors correctly.
633 * alloc.c (sweep_vectors): Account total_vector_bytes for
634 bool vectors larger than VBLOCK_BYTES_MAX.
635
5fbfb018
CY
6362012-07-18 Chong Yidong <cyd@gnu.org>
637
638 * frame.c (x_set_frame_parameters): Revert bogus change introduced
639 in 2012-05-25 commit by Paul Eggert (Bug#11738).
640
3ab6e069
DA
6412012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
642
643 Return more descriptive data from Fgarbage_collect.
644 Suggested by Stefan Monnier in
645 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
646 * alloc.c (bounded_number): New function.
647 (total_buffers, total_vectors): New variable.
648 (total_string_size): Rename to total_string_bytes, adjust users.
649 (total_vector_size): Rename to total_vector_bytes, adjust users.
650 (sweep_vectors): Account total_vectors and total_vector_bytes.
651 (Fgarbage_collect): New return value. Adjust documentation.
652 (gc_sweep): Account total_buffers.
653 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
654 (VECTOR_SIZE): Remove.
655 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
656 (Qinterval, Qmisc): New symbols.
657 (syms_of_data): Initialize them.
658 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
659 (Qcons, Qbuffer): New declarations.
660
6d02fe5b
PE
6612012-07-17 Paul Eggert <eggert@cs.ucla.edu>
662
663 * alloc.c (Fmemory_free): Account for memory-free's own storage.
664 Round up, not down. Improve doc.
665
b7ffe040
DA
6662012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
667
668 Restore old code in allocate_string_data to avoid Faset breakage.
669 Reported by Julien Danjou <julien@danjou.info> in
670 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
671 * alloc.c (allocate_string_data): Restore old code with minor
672 adjustments, fix comment to explain this subtle issue.
673
4dc7c8d5
SM
6742012-07-17 Eli Zaretskii <eliz@gnu.org>
675
676 Remove FILE_SYSTEM_CASE.
677 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
678
679 * fileio.c (FILE_SYSTEM_CASE): Don't define.
680 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
681 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
682 call-process-region passes it through expand-file-name.
683
684 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
685
6862012-07-17 Andreas Schwab <schwab@linux-m68k.org>
687
688 Fix crash when creating indirect buffer (Bug#11917)
689 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
690 Don't handle unbound variables specially if non-zero.
691 (Fbuffer_local_variables): Pass zero.
692 (clone_per_buffer_values): Pass non-zero.
693
6942012-07-17 Andreas Schwab <schwab@linux-m68k.org>
695
696 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
697 to make the loop interruptible.
698
6992012-07-17 Andreas Schwab <schwab@linux-m68k.org>
700
701 * gnutls.c (emacs_gnutls_handshake): Only retry if
702 GNUTLS_E_INTERRUPTED.
703
cce7fefc
DA
7042012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
705
706 Cleanup and convert miscellaneous checks to eassert.
707 * alloc.c (mark_interval): Fix comment, partially rephrase
708 old comment from intervals.h (see below).
709 * intervals.c (find_interval, adjust_intervals_for_insertion)
710 (delete_interval, adjust_intervals_for_deletion)
711 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
712 Convert to eassert.
713 (adjust_intervals_for_insertion, make_new_interval):
714 Remove obsolete and unused code.
715 * intervals.h (struct interval): Remove obsolete comment.
716 * textprotp.c (erase_properties): Remove unused code.
717 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
718 (Fremove_list_of_text_properties): Convert to eassert.
719
9ea10cc3
CY
7202012-07-17 Chong Yidong <cyd@gnu.org>
721
722 * editfns.c (Finsert_char): Doc fix.
723
3900d5de
DA
7242012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
725
726 Fix previous change to make Fmemory_free always accurate.
727 * alloc.c (make_interval): Update total_free_intervals.
728 (make_float): Likewise for total_free_floats.
729 (free_cons, Fcons): Likewise for total_free_conses.
730 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
731 Likewise for total_free_vector_bytes.
732 (Fmake_symbol): Likewise for total_free_symbols.
733 (bytes_free): Remove.
734
7098646f
DA
7352012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
736
737 Simple free memory accounting feature.
738 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
739 (sweep_vectors): Accumulate size of free vectors.
740 (Fgarbage_collect): Setup bytes_free.
741 (Fmemory_free): New function.
742 (syms_of_alloc): Register it.
743
22657b40
DA
7442012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
745
746 Cleanup overlays checking.
747 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
748 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
749 eassert and OVERLAYP.
750 (sort_overlays): Change to use OVERLAYP.
751
ddfc8813
RK
7522012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
753
754 * editfns.c (Finsert_char): Make it interactive, and make the
755 second arg optional. Copy interactive spec and docstring from
756 ucs-insert.
757
7c26cf3c
PE
7582012-07-17 Paul Eggert <eggert@cs.ucla.edu>
759
760 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
761 Unlike the other wrapped functions, fabs has an unspecified
762 effect on errno.
763
5d127af9
JD
7642012-07-16 Jan Djärv <jan.h.d@swipnet.se>
765
766 * nsterm.m (keyDown): Interpret flags without left/right bits
767 as the left key (Bug#11670).
768
6a0dd1d7
DA
7692012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
770
771 Remove empty and useless init functions.
772 * lisp.h (init_character_once, init_fns, init_image)
773 (init_filelock, init_sound): Remove prototype.
774 * character.c (init_character_once): Remove.
775 * filelock.c (init_filelock): Likewise.
776 * fns.c (init_fns): Likewise.
777 * image.c (init_image): Likewise.
778 * sound.c (init_sound): Likewise.
779 * emacs.c (main): Adjust accordingly.
780
7a6136fd
DA
7812012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
782
783 * gtkutil.h: Tiny cleanups.
784 (use_old_gtk_file_dialog): Remove useless declaration.
785 (xg_uses_old_file_dialog): Add suggested const attribute.
786
ce811ad9
EZ
7872012-07-15 Eli Zaretskii <eliz@gnu.org>
788
789 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
790 (bidi_paragraph_init): Use it to limit search forward for a strong
791 directional character in abnormally large paragraphs full of
792 neutral or weak characters. (Bug#11943)
793
c9adfeaa
SF
7942012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
795
796 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
797 the toolbar (Bug#9451).
798 (xg_make_tool_item): Give the widget event box a transparent
799 background.
800
fff62aa9
DA
8012012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
802
803 Cleanup basic allocation variables and functions.
804 * alloc.c (ignore_warnings, init_intervals, init_float)
805 (init_cons, init_symbol, init_marker): Remove.
806 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
807 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
808 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
809 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
810 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
811 (staticidx, init_alloc_once, init_strings, free_ablock):
812 Remove redundant initialization.
813 * fns.c (init_weak_hash_tables): Remove.
814 * lisp.h (init_weak_hash_tables): Remove prototype.
815
9730daca
DA
8162012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
817
818 Use zero_vector where appropriate.
819 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
820 accordingly.
821 * lisp.h (zero_vector): New declaration.
822 * font.c (null_vector): Remove.
823 (syms_of_font): Remove initialization and staticpro.
824 (font_list_entities, font_find_for_lface): Change to use zero_vector.
825 * keymap.c (Faccessible_keymaps): Likewise.
826
2e2d2a13
LL
8272012-07-15 Leo Liu <sdl.web@gmail.com>
828
829 * fringe.c: Fix typo in comments.
830
cd276f6e
LL
8312012-07-14 Leo Liu <sdl.web@gmail.com>
832
833 * fringe.c: Add a new bitmap exclamation-mark.
834
5a1131d9
EZ
8352012-07-14 Eli Zaretskii <eliz@gnu.org>
836
837 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
838
839 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
840 (HAVE_MENUS): Don't define, defined by editing config.in with
841 msdos/sed2v2.inp.
842 (GMALLOC_INHIBIT_VALLOC): Don't define.
843 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
844
22e983b7
JB
8452012-07-14 Juanma Barranquero <lekktu@gmail.com>
846
847 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
848
5b3f250f
GM
8492012-07-14 Glenn Morris <rgm@gnu.org>
850
851 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
852 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
853 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
854
33d63ff4
GM
8552012-07-13 Glenn Morris <rgm@gnu.org>
856
5b633342
GM
857 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
858
33d63ff4
GM
859 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
860 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
861
b55b9f85
JD
8622012-07-13 Jan Djärv <jan.h.d@swipnet.se>
863
0dc8cf50
JD
864 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
865 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
866 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
867 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
868 where appropriate.
869 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
870 as boolean expression.
871 (x_set_window_size): Remove unused variable toolbar.
872 (ns_get_color_default, ns_mod_to_lisp): Remove.
873 (ns_mouse_position): Remove unused variables xchar and ychar.
874 (ns_compute_glyph_string_overhangs): Remove unused variable face.
875 (ns_set_vertical_scroll_bar): Remove unused variable count.
876 (ns_delete_terminal): Remove unused variable i.
877 (ns_term_init): Remove unused variables r, g and b.
878 (mouseDown): Remove unused variable window.
879 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
880 (initFrameFromEmacs): Remove unused variable vbextra.
881 (mouseEntered): Remove unused variables p and dpyinfo.
882 (mouseExited): Remove unused variables p and r.
883 (ns_define_frame_cursor, ns_clear_frame_area)
884 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
885 (menuDown): Assign [sender tag] to variable and cast the variable.
886
887 * nsterm.h (menuDown): Add id as type to argument sender.
888 (ns_display_info_for_name): Add Lisp_Object argument.
889 (ns_term_init): Add Lisp_Object argument.
890 (ns_map_event_to_object): Add void argument.
891 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
892 prototype with arguments and only declare if __OBJC__.
893 (nxatoms_of_nsselect): Add void argument.
894 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
895 (ns_alloc_autorelease_pool): Add void argument.
896 (ns_release_autorelease_pool): Add void* argument.
897 (ns_get_defaults_value): Add const char* argument.
898
899 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
900 (initFromContents): Use SSDATA where appropriate.
901 (ns_update_menubar): Add braces to ambigous if-else.
902 (initWithTitle): Put () around assignment in if statement.
903 (ns_menu_show): Remove unused variables window and keymap.
904 (update_frame_tool_bar): Remove unused variable selected_p.
905 (initWithContentRect): Remove unused variable this_cmd_name.
906
907 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
908 appropriate.
909 (setXBMColor): Remove unused variable len.
910 (setPixmapData): Put () around assignment in loop statement.
911
912 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
913 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
914 where appropriate.
915 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
916 around assignment in loop statement.
917 (nsfont_open): Remove unused variable i.
918 (nsfont_open): Remove unused variable len.
919 (nsfont_draw): Remove unused variable cs.
920
921 * nsfns.m (x_set_icon_name, ns_set_name_internal)
922 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
923 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
924 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
925 (Fns_font_name, Fns_perform_service)
926 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
927 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
928 (ns_set_name): Remove unused variable view.
929 (x_set_menu_bar_lines): Remove unused variable olines.
930 (x_set_tool_bar_lines): Remove unused variable root_window.
931 (Fns_list_colors): Put () around assignment in while statement.
932 (Fns_perform_service): Remove unused variable len.
933 (Fns_display_usable_bounds): Remove unused variable top.
934 (syms_of_nsfns): Remove unused variable i.
935
b55b9f85
JD
936 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
937 memcpy (Bug#11907).
938
ed9265fc 9392012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
940
941 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
942 and free it with DestroyExceptionInfo (Bug#11558).
943
ef099b57
JB
9442012-07-13 Juanma Barranquero <lekktu@gmail.com>
945
946 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
947 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
948 Set here, not in nt/config.nt.
949
ea814a5d
EZ
9502012-07-13 Eli Zaretskii <eliz@gnu.org>
951
952 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
953 cursor overflow into the last glyph on display line when the right
954 fringe is off. (Bug#11832)
955
1a952767
PE
9562012-07-13 Paul Eggert <eggert@cs.ucla.edu>
957
958 * xdisp.c (produce_special_glyphs): Now static.
959 * dispextern.h (produce_special_glyphs): Remove decl.
960
983188fd
GM
9612012-07-13 Glenn Morris <rgm@gnu.org>
962
32fb4bb6
GM
963 * s/bsd-common, s/cygwin.h: Remove empty files.
964 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
965
983188fd
GM
966 * s/usg5-4-common.h (USG, USG5):
967 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
968 * s/sol2-6.h (SOLARIS2):
969 * s/irix6-5.h (IRIX6_5):
970 * s/hpux10-20.h (USG, USG5, HPUX):
971 * s/gnu-linux.h (USG, GNU_LINUX):
972 * s/freebsd.h (BSD_SYSTEM):
973 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
974 * s/cygwin.h (CYGWIN):
975 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
976 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
977
d1e68667 9782012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
979
980 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 981
6de0e799
GM
9822012-07-13 Glenn Morris <rgm@gnu.org>
983
739ae010
GM
984 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
985
dbee5793
GM
986 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
987
6de0e799
GM
988 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
989 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
990
b82da769
GM
9912012-07-12 Glenn Morris <rgm@gnu.org>
992
4fae5a7a 993 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
994
995 * process.c (init_process_emacs): Rename from init_process.
996 The old name is also the name of a Mach system call.
997 * lisp.h, emacs.c: Update for this name change.
998 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
999 longer needed.
1000
5a979817
EZ
10012012-07-12 Eli Zaretskii <eliz@gnu.org>
1002
1003 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1004 memmove call that removes glyphs covered by the left truncation
1005 glyph. Improve commentary.
1006 (display_line): Fix display of continuation glyphs on GUI frames
1007 when the right fringe is turned off and variable-size fonts are
1008 used in the window. Move the code that appends a stretch glyph to
1009 produce_special_glyphs, so that it could be used for truncation
1010 and continuation glyphs alike.
1011 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1012 glyph of a suitably computed width, to align the special glyphs at
1013 the window margin. Code moved from display_line. (Bug#11832)
1014
3e91a053
GM
10152012-07-12 Glenn Morris <rgm@gnu.org>
1016
ba9e4b84
GM
1017 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1018
1019 * s/gnu-linux.h, s/hpux10-20.h:
1020 Do not unconditionally define HAVE_XRMSETDATABASE.
1021
3e91a053
GM
1022 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1023
b300b1f4
PE
10242012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1025
1026 Fix typos that broke OS X build.
1027 Reported by Randal L. Schwartz in
1028 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1029 * nsterm.m (ns_timeout): Add missing local decl.
1030 (ns_get_color): snprintf -> sprintf, to fix typo.
1031
6e777848
GM
10322012-07-12 Glenn Morris <rgm@gnu.org>
1033
3f922c37
GM
1034 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1035 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1036 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1037 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1038
0ab7b23a
GM
1039 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1040 Move PTY_OPEN to configure.
1041
6e777848
GM
1042 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1043 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1044 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1045
4a7edc24
DA
10462012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1047
1048 Use empty_unibyte_string where applicable.
1049 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1050 * lread.c (read1): Likewise.
1051 * xsettings.c (syms_of_xsettings): Likewise.
1052
308aab79
GM
10532012-07-12 Glenn Morris <rgm@gnu.org>
1054
42bd1719
GM
1055 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1056 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1057 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1058 * s/hpux10-20.h (RUN_TIME_REMAP):
1059 * s/bsd-common.h (TABDLY): Move to configure.
1060
1061 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1062
1063 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1064
ea0bbd17 1065 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1066 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1067
1068 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1069
308aab79
GM
1070 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1071 * s/template.h: Move NARROWPROTO to configure.
1072
ee1cf5cf
GM
10732012-07-11 Glenn Morris <rgm@gnu.org>
1074
30fe9bf4
GM
1075 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1076 unused since 2011-01-17 change to systty.h.
1077
ee1cf5cf
GM
1078 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1079 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1080 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1081
63e47e07
PE
10822012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1085
c43fb4c3
GM
10862012-07-11 Glenn Morris <rgm@gnu.org>
1087
1088 * s/darwin.h, s/gnu-linux.h, s/template.h:
1089 Move INTERRUPT_INPUT to configure.
1090
e8df9267
DA
10912012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1092
1093 Minor adjustments to interning code.
1094 * lisp.h (intern, intern_c_string): Redefine as static inline
1095 wrappers for intern_1 and intern_c_string_1, respectively.
1096 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1097 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1098 Vobarray checking.
e8df9267
DA
1099 * font.c (font_intern_prop): Likewise. Adjust comment.
1100 * w32font.c (intern_font_name): Likewise.
1101
34348bd4
AS
11022012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1103
d96a1e0c
AS
1104 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1105
34348bd4
AS
1106 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1107 of Fcar/Fcdr if possible.
1108 * font.c (check_otf_features): Likewise.
1109 * fontset.c (Fnew_fontset): Likewise.
1110 * gnutls.c (Fgnutls_boot): Likewise.
1111 * minibuf.c (read_minibuf): Likewise.
1112 * msdos.c (IT_set_frame_parameters): Likewise.
1113 * xmenu.c (Fx_popup_dialog): Likewise.
1114 * w32menu.c (Fx_popup_dialog): Likewise.
1115
c8add24e
GM
11162012-07-11 Glenn Morris <rgm@gnu.org>
1117
4b575b3c
GM
1118 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1119 since nothing has defined it on these platforms.
1120
09f4e3b0
GM
1121 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1122 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1123
172bedef
GM
1124 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1125 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1126 Move CLASH_DETECTION to configure.
1127
249685df
GM
1128 * s/gnu.h: Remove file, which is now empty.
1129
c8add24e
GM
1130 * s/gnu.h, s/gnu-linux.h:
1131 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1132
b41253a3
JW
11332012-07-11 John Wiegley <johnw@newartisans.com>
1134
1135 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1136 function attribute, so we only use it if it exists in the
1137 compiler.
1138
d923b542
DA
11392012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1140
1141 Avoid call to strlen in fast_c_string_match_ignore_case.
1142 * search.c (fast_c_string_match_ignore_case): Change to use
1143 length argument. Adjust users accordingly.
1144 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1145
5ebbef1d
PE
11462012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1147
bb352260
PE
1148 Assume mkdir, rmdir.
1149 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1150 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1151
57054ddd
PE
1152 Assume rename.
1153 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1154
b747d3f7
PE
1155 Assume perror.
1156 * s/hpux10-20.h (HAVE_PERROR): Remove.
1157 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1158 Remove dummy definition, as this problem was obsolete long ago.
1159
5ebbef1d
PE
1160 Assume strerror.
1161 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1162
984e7f30
DA
11632012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1164
1165 Avoid calls to strlen in font processing functions.
1166 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1167 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1168 users accordingly.
d923b542
DA
1169 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1170 Adjust prototypes.
1171 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1172 Change to return ptrdiff_t.
984e7f30
DA
1173 (xfont_list_pattern, xfont_match): Use length returned by
1174 xfont_decode_coding_xlfd.
1175 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1176
20e94fdd
GM
11772012-07-11 Glenn Morris <rgm@gnu.org>
1178
9d596af3
GM
1179 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1180 Move DONT_REOPEN_PTY to configure.
1181
20e94fdd
GM
1182 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1183 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1184
e99a530f
PE
11852012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1186
22ffb973
PE
1187 Remove "#define unix" that is no longer needed (Bug#11905).
1188 * s/aix4-2.h (unix): Remove; no longer needed.
1189
e9a9ae03
PE
1190 EMACS_TIME simplification (Bug#11875).
1191 This replaces macros (which typically do not work in GDB)
1192 with functions, typedefs and enums, making the code easier to debug.
1193 The functional style also makes code easier to read and maintain.
1194 * systime.h: Include <sys/time.h> on all hosts, not just if
1195 WINDOWSNT, since 'struct timeval' is needed in general.
1196 (EMACS_TIME): Now a typedef, not a macro.
1197 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1198 not macros.
1199 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1200 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1201 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1202 (EMACS_TIME_LE): Now functions, not macros.
1203 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1204 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1205 which are not functions. All uses rewritten to use:
1206 (make_emacs_time): New function.
1207 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1208 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1209 not functions. All uses rewritten to use the following, respectively:
1210 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1211 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1212 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1213 * fileio.c (Fcopy_file):
1214 * xterm.c (XTflash): Get the current time closer to when it's used.
1215 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1216
ffacb126
PE
1217 * bytecode.c (targets): Suppress -Woverride-init warnings.
1218
e99a530f
PE
1219 Simplify by avoiding confusing use of strncpy etc.
1220 * doc.c (Fsnarf_documentation):
1221 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1222 * frame.c (Fmake_terminal_frame):
1223 * gtkutil.c (get_utf8_string):
1224 * lread.c (openp):
1225 * nsmenu.m (ns_update_menubar):
1226 * regex.c (regerror):
1227 Prefer memcpy to strncpy and strncat when either will do.
1228 * fileio.c (Fsubstitute_in_file_name):
1229 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1230 (menu_separator_name_p):
1231 * nsmenu.m (ns_update_menubar):
1232 Prefer memcmp to strncmp when either will do.
1233 * nsterm.m: Include <ftoastr.h>.
1234 (ns_get_color):
1235 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1236 Prefer snprintf to strncpy.
1237 * nsterm.m (ns_term_init):
1238 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1239 * nsterm.m (ns_term_init):
1240 Avoid the need for strncpy, by using build_string or
1241 make_unibyte_string directly. Use dtoastr, not snprintf.
1242 * process.c (Fmake_network_process): Diagnose service names that
1243 are too long, rather than silently truncating them or creating
1244 non-null-terminated names.
1245 (Fnetwork_interface_info): Likewise, for interface names.
1246 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1247 Prefer sprintf to strncat.
1248 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1249 Prefer vsnprintf to vsprintf + strncpy.
1250
c59592b3
GM
12512012-07-10 Glenn Morris <rgm@gnu.org>
1252
1253 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1254 Clarify fallback case.
1255
7d7bbefd
DA
12562012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1257
1258 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1259 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1260 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1261 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1262 where argument type is known to be a Lisp_Cons.
1263
3a4c8000
TT
12642012-07-10 Tom Tromey <tromey@redhat.com>
1265
1266 * bytecode.c (BYTE_CODE_THREADED): New macro.
1267 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1268 (enum byte_code_op): New type.
1269 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1270 (exec_byte_code): Use them. Use token threading when applicable.
1271
2a0213a6
DA
12722012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1273
1274 Optimize pure C strings initialization.
1275 * lisp.h (make_pure_string): Fix prototype.
1276 (build_pure_c_string): New function, defined as static inline. This
1277 provides a better opportunity to optimize away calls to strlen when
1278 the function is called with compile-time constant argument.
1279 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1280 argument, adjust users accordingly. Use build_pure_c_string where
1281 appropriate.
1282 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1283 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1284 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1285
cb1caeaf
DA
12862012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1287
1288 Avoid calls to strlen in miscellaneous functions.
1289 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1290 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1291 * lread.c (openp): Likewise.
1292
c293e30c
DA
12932012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1294
1295 Avoid calls to strlen in path processing functions.
1296 * fileio.c (file_name_as_directory): Add comment. Change to add
1297 srclen argument and return the length of result. Adjust users
1298 accordingly.
1299 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1300 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1301 users accordingly.
1302 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1303
9e059e3f
GM
13042012-07-10 Glenn Morris <rgm@gnu.org>
1305
d02eb359
GM
1306 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1307 Move PENDING_OUTPUT_COUNT definition to configure.
1308
882cf227
GM
1309 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1310 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1311 * s/gnu.h (DATA_START): Move definitions to configure.
1312
af6e839f
GM
1313 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1314 We include usg5-4-common.h, which defines them both.
1315
40289a12
GM
1316 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1317 O_RDONLY already includes it).
1318
9e059e3f
GM
1319 Stop ns builds setting the EMACSLOADPATH environment variable.
1320 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1321 Now it does not set EMACSLOADPATH, just returns the load-path string.
1322 * nsterm.h: Update accordingly.
1323 * lread.c [HAVE_NS]: Include nsterm.h.
1324 (init_lread) [HAVE_NS]: Use ns_load_path.
1325 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1326
7c4e8ec0
GM
13272012-07-09 Glenn Morris <rgm@gnu.org>
1328
d4f600ff
GM
1329 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1330 since the included bsd-common.h does so.
1331
cbb31951
GM
1332 Stop ns builds setting the EMACSPATH environment variable.
1333 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1334 (ns_init_paths): Do not set EMACSPATH.
1335 * nsterm.h (ns_exec_path): Add it.
1336 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1337 Use ns_exec_path.
1338
7c4e8ec0
GM
1339 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1340
26bccfae
PE
13412012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1342
a0bee46f
PE
1343 * process.c (wait_reading_process_output): 'waitchannels' was unset
1344 when read_kbd || !NILP (wait_for_cell); fix this.
1345
5994c183
PE
1346 Add GCC-style 'const' attribute to functions that can use it.
1347 * character.h (char_resolve_modifier_mask):
1348 * keyboard.h (make_ctrl_char):
1349 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1350 (init_character_once, next_almost_prime, init_fns, init_image)
1351 (flush_pending_output, init_sound):
1352 * mem-limits.h (start_of_data):
1353 * menu.h (finish_menu_items):
1354 Add ATTRIBUTE_CONST.
1355 * emacs.c (DEFINE_DUMMY_FUNCTION):
1356 Declare the dummy function with ATTRIBUTE_CONST.
1357 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1358 Add decls with ATTRIBUTE_CONST.
1359
26bccfae
PE
1360 Minor improvements to make_formatted_string.
1361 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1362 where int is good enough, as vsprintf returns an int.
1363 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1364
a8290ec3
DA
13652012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1366
1367 Use make_formatted_string to avoid double length calculation.
1368 * lisp.h (make_formatted_string): New prototype.
1369 * alloc.c (make_formatted_string): New function.
1370 * buffer.c (Fgenerate_new_buffer_name): Use it.
1371 * dbus.c (syms_of_dbusbind): Likewise.
1372 * editfns.c (Fcurrent_time_zone): Likewise.
1373 * filelock.c (get_boot_time): Likewise.
1374 * frame.c (make_terminal_frame, set_term_frame_name)
1375 (x_report_frame_params): Likewise.
1376 * image.c (gs_load): Likewise.
1377 * minibuf.c (get_minibuffer): Likewise.
1378 * msdos.c (dos_set_window_size): Likewise.
1379 * process.c (make_process): Likewise.
1380 * xdisp.c (ensure_echo_area_buffers): Likewise.
1381 * xsettings.c (apply_xft_settings): Likewise.
1382
d01ba2f1
GM
13832012-07-09 Glenn Morris <rgm@gnu.org>
1384
1385 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1386 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1387 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1388 * nsterm.h (ns_etc_directory): Add it.
1389 * callproc.c [HAVE_NS]: Include nsterm.h.
1390 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1391
f1f924b6
DA
13922012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1393
1394 Move marker debugging code under MARKER_DEBUG.
1395 * marker.c (MARKER_DEBUG): Move marker debugging code under
1396 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1397 for bootstrap with --enable-checking (~3x slowdown reported
1398 by Juanma Barranquero <lekktu@gmail.com>).
1399 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1400
ab531b66
PE
14012012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1402
1403 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1404 See <http://bugs.gnu.org/11825#29>.
1405
c4b3bc8a
EZ
14062012-07-08 Eli Zaretskii <eliz@gnu.org>
1407
1408 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1409 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1410 (display_line): Add commentary about displaying truncation glyphs
1411 on GUI frames.
1412 (produce_special_glyphs): Move here from term.c.
1413
1414 * term.c (produce_special_glyphs): Move to xdisp.c.
1415
1416 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1417 section.
c4b3bc8a 1418
b676b881
AS
14192012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1420
f17c5273
AS
1421 * xdisp.c (display_line): Avoid warning about implicit declaration
1422 of FRAME_FONT.
1423
298819b9
AS
1424 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1425
b676b881
AS
1426 * lisp.h: Remove empty conditional.
1427
6045c4fd
PE
14282012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1429
b3350bf9
PE
1430 * lread.c (load_path_check): Now static.
1431
6045c4fd
PE
1432 Fix some minor --with-ns problems found by static checking.
1433 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1434 (x_set_font) [!HAVE_X_WINDOWS]:
1435 * image.c (xpm_load_image) [HAVE_NS]:
1436 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1437 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1438 Remove unused local.
1439 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1440 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1441 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1442 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1443 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1444 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1445 Fix pointer signedness problem.
1446 * xfaces.c (FRAME_X_FONT_TABLE):
1447 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1448
929e7845
GM
14492012-07-07 Glenn Morris <rgm@gnu.org>
1450
1451 * lread.c (load_path_check): New function, split from init_lread.
1452 (init_lread): Reorganize. Motivation:
1453 If EMACSLOADPATH is set, check/warn about that rather than the
1454 defaults, which we are not going to use. Hence we can remove
1455 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1456 Don't warn if site-lisp directories are missing.
1457 If not installed, start from a blank load-path, since
1458 PATH_LOADSEARCH refers to the eventual installation directories.
1459
58dd0aa4
EZ
14602012-07-07 Eli Zaretskii <eliz@gnu.org>
1461
1462 Support truncation and continuation glyphs on GUI frames, when
1463 fringes are disabled. (Bug#11832)
1464 * xdisp.c (init_iterator): Get dimensions of truncation and
1465 continuation glyphs even if on GUI frames. Adjust
1466 it->last_visible_x on GUI frames when the left or right fringes,
1467 or both, are absent.
1468 (start_display, move_it_in_display_line_to): Handle the case of a
1469 GUI frame without a fringe to display continuation or truncation
1470 glyphs.
1471 (insert_left_trunc_glyphs): Support GUI frames: make sure
1472 truncation glyphs overwrite enough glyphs from the current line to
1473 have sufficient space in pixels.
1474 (display_line): Support truncation and continuation glyphs on GUI
1475 frames. If some spare pixels are left on the line after inserting
1476 the truncation glyphs, fill that space with a stretch glyph of a
1477 suitably computed width.
1478
1479 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1480 produce_glyphs, to support GUI sessions.
1481
31571fd7
PE
14822012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1483
5a16b9bc
PE
1484 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1485
f3047c75
PE
1486 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1487
31571fd7
PE
1488 Do not require float-time's arg to fit in time_t (Bug#11825).
1489 This works better on hosts where time_t is unsigned, and where
1490 float-time is applied to the (negative) difference between two times.
1491 * editfns.c (decode_time_components): Last arg is now double *,
1492 not int *, and means to store all the result as a double, without
1493 worrying about whether the seconds part fits in time_t.
1494 All callers changed.
1495 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1496 All callers changed.
1497 (Ffloat_time): Do not fail merely because the specified time falls
1498 outside of time_t range.
1499
4516fbef
GM
15002012-07-07 Glenn Morris <rgm@gnu.org>
1501
1502 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1503 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1504 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1505
07adc2c6
JB
15062012-07-07 Juanma Barranquero <lekktu@gmail.com>
1507
1508 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1509 Update dependencies.
1510
1511 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1512
fd573f31
PE
15132012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1514
fee5959d
PE
1515 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1516 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1517 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1518 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1519 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1520 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1521
fd573f31
PE
1522 * xfont.c (compare_font_names): Redo to omit the need for casts.
1523
ddadbc0e
AS
15242012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1525
fca8d6b6
AS
1526 * xfns.c (Fx_change_window_property): Doc fix.
1527 * w32fns.c (Fx_change_window_property): Doc fix.
1528
ddadbc0e
AS
1529 * w32fns.c (Fx_window_property): Accept the same arguments as the
1530 X Windows version. Doc fix.
1531 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1532
ed9265fc 15332012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1534 Eli Zaretskii <eliz@gnu.org>
1535
1536 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1537 Windows-specific code from nt/config.nt moved here.
1538 Obsolete settings removed.
1539
216ee680
PE
15402012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1541
1542 * process.c: Avoid unnecessary calls to gettime.
1543 (wait_reading_process_output): Don't get the time of day
1544 when gobbling data immediately and not waiting, as there's no need
1545 for it in that case. This removes a FIXME.
1546
bdd091e4
JD
15472012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1548
1549 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1550 is defined (Bug#11768).
1551
9d44f8ce
DA
15522012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1553
1554 Fix marker debugging code.
1555 * marker.c (byte_char_debug_check): Do not perform the check
1556 if buffer is not multibyte.
090bd7cb
JB
1557 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1558 Call byte_char_debug_check with correct arguments.
9d44f8ce 1559
90fc4786
DA
15602012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1561
1562 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1563 * marker.c (byte_char_debug_check, count_markers):
1564 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1565 (byte_debug_flag): Remove.
1566 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1567 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1568
7b7ae965
DA
15692012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1570
4e57b342
DA
1571 Avoid code repetition in marker-related functions.
1572 * marker.c (attach_marker): New function.
1573 (Fset_marker, set_marker_restricted, set_marker_both)
1574 (set_marker_restricted_both): Use it.
1575 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1576 Consistently rename charno to charpos.
1577 (marker_position): Add eassert.
1578 (marker_byte_position): Convert to eassert.
1579
15802012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1581
1582 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1583 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1584 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1585
657924ff
DA
15862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1587
1588 Introduce fast path for the widely used marker operation.
1589 * alloc.c (build_marker): New function.
1590 * lisp.h (build_marker): New prototype.
1591 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1592 * composite.c (autocmp_chars): Likewise.
1593 * editfns.c (buildmark): Remove.
1594 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1595 (save_restriction_save): Use build_marker.
1596 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1597 * window.c (save_window_save): Likewise.
1598
041a49a6
DA
15992012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1600
1601 Do not use Fdelete_overlay in delete_all_overlays
1602 to avoid redundant calls to unchain_overlay.
1603 * buffer.c (drop_overlay): New function.
1604 (delete_all_overlays, Fdelete_overlay): Use it.
1605 * minibuf.c (get_minibuffer): Fix comment.
1606
7dca65a4
PE
16072012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1608
1609 Port to OpenBSD 5.1 amd64.
1610 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1611 This is needed for OpenBSD, and should be harmless on all BSD systems.
1612 Also, include <sys/sysctl.h>, as it should be available on all
1613 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1614 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1615 use p_pid member, not kp_proc.pid.
1616
8eb876e2
GM
16172012-07-06 Glenn Morris <rgm@gnu.org>
1618
1619 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1620
38182d90
PE
16212012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1622
1623 More xmalloc and related cleanup.
1624 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1625 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1626 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1627 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1628 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1629 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1630 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1631 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1632 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1633 * xterm.c:
1634 Omit needless casts involving void * pointers and allocation.
1635 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1636 as the former is more robust if P's type is changed.
1637 Prefer xzalloc to xmalloc + memset 0.
1638 Simplify malloc-or-realloc to realloc.
1639 Don't worry about xmalloc returning a null pointer.
1640 Prefer xstrdup to xmalloc + strcpy.
1641 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1642 growing it.
1643 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1644 alloca of a constant.
1645
6dd5a677
EZ
16462012-07-05 Eli Zaretskii <eliz@gnu.org>
1647
1648 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1649 hscroll is larger than the line width. Fixes long and futile
1650 looping inside extend_face_to_end_of_line (on a TTY) producing
1651 glyphs that are not needed and thrown away.
1652
6b312f0f
DA
16532012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1654
1655 * marker.c (set_marker_restricted_both): Simplify by using
1656 clip_to_bounds.
1657
f520ef9b
PE
16582012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1659
1660 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1661
383b7c95
JD
16622012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1663
1664 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1665 not defined (Bug#11768).
1666 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1667 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1668 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1669 followed by gtk_box_set_homogeneous (Bug#11768).
1670 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1671 (update_theme_scrollbar_width, xg_create_scroll_bar):
1672 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1673 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1674 (is_box_type): New function (Bug#11768).
1675 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1676 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1677 with default display (Bug#11768).
1678
d6e7bf45
EZ
16792012-07-05 Eli Zaretskii <eliz@gnu.org>
1680
1681 * xdisp.c (window_hscroll_limited): New function.
1682 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1683 coordinates when window's hscroll is set to insanely large
1684 values. (Bug#11857)
1685
431391ec
JB
16862012-07-05 Juanma Barranquero <lekktu@gmail.com>
1687
1688 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1689 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1690
23f86fce
DA
16912012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1692
1693 Cleanup xmalloc.
1694 * lisp.h (xzalloc): New prototype. Omit needless casts.
1695 * alloc.c (xzalloc): New function. Omit needless casts.
1696 * charset.c: Omit needless casts. Convert all calls to
1697 xmalloc with following memset to xzalloc.
1698 * dispnew.c: Likewise.
1699 * fringe.c: Likewise.
1700 * image.c: Likewise.
1701 * sound.c: Likewise.
1702 * term.c: Likewise.
1703 * w32fns.c: Likewise.
1704 * w32font.c: Likewise.
1705 * w32term.c: Likewise.
1706 * xfaces.c: Likewise.
1707 * xfns.c: Likewise.
1708 * xterm.c: Likewise.
1709 * atimer.c: Omit needless casts.
1710 * buffer.c: Likewise.
1711 * callproc.c: Likewise.
1712 * ccl.c: Likewise.
1713 * coding.c: Likewise.
1714 * composite.c: Likewise.
1715 * doc.c: Likewise.
1716 * doprnt.c: Likewise.
1717 * editfns.c: Likewise.
1718 * emacs.c: Likewise.
1719 * eval.c: Likewise.
1720 * filelock.c: Likewise.
1721 * fns.c: Likewise.
1722 * gtkutil.c: Likewise.
1723 * keyboard.c: Likewise.
1724 * lisp.h: Likewise.
1725 * lread.c: Likewise.
1726 * minibuf.c: Likewise.
1727 * msdos.c: Likewise.
1728 * print.c: Likewise.
1729 * process.c: Likewise.
1730 * region-cache.c: Likewise.
1731 * search.c: Likewise.
1732 * sysdep.c: Likewise.
1733 * termcap.c: Likewise.
1734 * terminal.c: Likewise.
1735 * tparam.c: Likewise.
1736 * w16select.c: Likewise.
1737 * w32.c: Likewise.
1738 * w32reg.c: Likewise.
1739 * w32select.c: Likewise.
1740 * w32uniscribe.c: Likewise.
1741 * widget.c: Likewise.
1742 * xdisp.c: Likewise.
1743 * xmenu.c: Likewise.
1744 * xrdb.c: Likewise.
1745 * xselect.c: Likewise.
1746
0497dc44
PE
17472012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1748
1749 * fileio.c (time_error_value): Check the right error number.
1750 Problem reported by Troels Nielsen in
1751 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1752
356e7178
PE
17532012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1754
4e71fd89
PE
1755 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1756 This should be fixed in a better way; see Eli Zaretskii in
1757 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1758 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1759
f0941253
PE
1760 * fileio.c (time_error_value): Rename from special_mtime.
1761 The old name's problems were noted by Eli Zaretskii in
1762 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1763
065c9eb4
PE
1764 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1765 This variable's comment says Emacs needs at least one GDB-visible
1766 symbol of type enum pvec_type, to work around GDB problems.
1767 The symbol's value doesn't matter.
1768
356e7178
PE
1769 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1770 that causes compilation to fail on pre-C99 compilers.
1771
ed9265fc 17722012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1773
1774 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1775 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1776
3884d954
DA
17772012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1778
d209e2fb 1779 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1780 headers for buffer_defaults and buffer_local_symbols.
1781 Reported by Juanma Barranquero <lekktu@gmail.com>.
1782
ee28be33
SM
17832012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1784
1785 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1786 * lisp.h (enum pvec_type): Use fewer bits.
1787 (PSEUDOVECTOR_SIZE_BITS): New constant.
1788 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1789 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1790 change in pvec_type.
1791 (PSEUDOVECTOR_TYPEP): New macro.
1792 (TYPED_PSEUDOVECTORP): Use it.
1793 * fns.c (internal_equal): Adapt code to extract pvectype.
1794 * emacs.c (gdb_pvec_type): Update type.
1795 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1796 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1797 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1798 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1799 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1800 abusing vector->header.next.nbytes.
1801 (live_vector_p): Use PVEC_TYPE.
1802 (mark_object): Adapt code to extract pvectype. Use switch.
1803
c7f2cd7f
PE
18042012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1805
1806 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1807 Tighten new eassert a bit.
1808
8ce70ed2
DA
18092012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1810
1811 Fix compilation with --enable-gcc-warnings and -O1
1812 optimization level.
1813 * doprnt.c (doprnt): Change type of tem to int, initialize
1814 to avoid compiler warning. Add eassert.
1815 * search.c (simple_search): Initialize match_byte to avoid
1816 compiler warning. Add eassert.
1817
dea7f1e5
PE
18182012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1819
24a212eb
PE
1820 Avoid weird behavior with large horizontal scrolls.
1821 Without this change, for example, large hscroll values would
1822 mess up Emacs's display on Fedora 15 x86, presumably due to
1823 overflows in int calculations in the display code.
1824 Also, if buffers had long lines, Emacs would freeze.
1825 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1826 (set_window_hscroll): New function, containing the old guts of
1827 Fset_window_hscroll. Return the clipped value.
1828 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1829 This avoids the need to check against PTRDIFF_MAX.
1830
dea7f1e5
PE
1831 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1832
76046526
DA
18332012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1834
1835 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1836
39adff0d
PE
18372012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1838
63807d47
PE
1839 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1840 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1841 since GCC 4.4.6 issues a bogus warning for them.
1842
39adff0d
PE
1843 Fix bugs in file timestamp newness comparisons.
1844 * fileio.c (Ffile_newer_than_file_p):
1845 * lread.c (Fload): Use full timestamp resolution of files,
1846 not just the 1-second resolution, so that files that are only
1847 slightly newer still count as newer.
1848 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1849 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1850
dbeed9a6
PE
18512012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1852
1853 * fileio.c: Improve handling of file time marker. (Bug#11852)
1854 (special_mtime): New function.
1855 (Finsert_file_contents, Fverify_visited_file_modtime):
1856 Use it to set special mtime values consistently.
1857
636334d6
AS
18582012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1859
1860 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1861 marker for non-existing file. (Bug#11852)
1862
e2017fe2
GM
18632012-07-03 Glenn Morris <rgm@gnu.org>
1864
1865 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1866 and did not make it into globals.h).
1867
404dbd37
TT
18682012-07-03 Tom Tromey <tromey@redhat.com>
1869
1870 * window.c (Fset_window_margins, Fset_window_fringes)
1871 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1872 * textprop.c (Fprevious_property_change): No longer static.
1873 * syntax.c (Fsyntax_table_p): No longer static.
1874 * process.c (Fget_process, Fprocess_datagram_address): No longer
1875 static.
1876 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1877 * keyboard.c (Fcommand_execute): No longer static.
1878 Remove EXFUN.
1879 * insdel.c (Fcombine_after_change_execute): No longer static.
1880 * image.c (Finit_image_library): No longer static.
1881 * fileio.c (Fmake_symbolic_link): No longer static.
1882 * eval.c (Ffetch_bytecode): No longer static.
1883 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1884 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1885 No longer static.
404dbd37
TT
1886 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1887 static.
1888 * dired.c (Ffile_attributes): No longer static.
1889 * composite.c (Fcomposition_get_gstring): No longer static.
1890 * callproc.c (Fgetenv_internal): No longer static.
1891
1892 * ccl.h: Remove EXFUNs.
1893 * buffer.h: Remove EXFUNs.
1894 * dispextern.h: Remove EXFUNs.
1895 * intervals.h: Remove EXFUNs.
1896 * fontset.h: Remove EXFUN.
1897 * font.h: Remove EXFUNs.
1898 * dosfns.c (system_process_attributes): Remove EXFUN.
1899 * keymap.h: Remove EXFUNs.
1900 * lisp.h: Remove EXFUNs.
1901 * w32term.h: Remove EXFUNs.
1902 * window.h: Remove EXFUNs.
1903 * xsettings.h: Remove EXFUN.
1904 * xterm.h: Remove EXFUN.
1905
8e4fd1e1
GM
19062012-07-03 Glenn Morris <rgm@gnu.org>
1907
1908 * lisp.h (Frandom): Make it visible to C.
1909 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1910 buffer for invisible buffers. (Bug#1229)
1911
ca95b3eb
DA
19122012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1913
1914 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1915 values which aren't power of 2.
1916 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1917 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1918 accordingly.
1919
7555c33f
SM
19202012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1921
1922 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1923
1924 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1925
d12e8f5a
DA
19262012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1927
1928 * alloc.c (allocate_vector_block): Remove redundant
1929 calls to mallopt if DOUG_LEA_MALLOC is defined.
1930 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1931 avoid calls to mallopt if zero_vector is returned.
1932
296094c3
DA
19332012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1934
1935 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1936 is enabled, avoid dereferencing NULL current_sblock if
1937 running undumped.
1938
36429c89
DA
19392012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1940
1941 Cleanup basic buffer management.
1942 * buffer.h (struct buffer): Change layout to use generic vector
1943 marking code. Fix some comments. Change type of 'clip_changed'
1944 to bitfield. Remove unused #ifndef old.
1945 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1946 (GET_OVERLAYS_AT): Fix indentation.
1947 (for_each_per_buffer_object_at): New macro.
1948 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1949 (Fbuffer_local_variables): Use it.
1950 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1951 * alloc.c (allocate_buffer): Adjust to match new layout of
1952 struct buffer. Fix comment.
1953 (mark_overlay): New function.
1954 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1955 Lisp area of struct buffer.
1956 (mark_object): Use it. Adjust marking of misc objects
1957 and related comments.
1958
3b3e4cac
PE
19592012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1960
1961 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1962 wrapper that is not needed because the wrapped code is a no-op (zero
1963 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1964 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1965
cf5c0175
DA
19662012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1967
1968 * alloc.c (mark_buffer): Simplify. Remove prototype.
1969 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1970 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1971 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1972 redundant calls to mark_vectorlike for bool vectors.
1973
ca26824c
GM
19742012-06-30 Glenn Morris <rgm@gnu.org>
1975
2e4c5312
GM
1976 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1977
ca26824c
GM
1978 * epaths.in (PATH_SITELOADSEARCH): New.
1979 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1980 This is rather than relying on --enable-locallisppath elements
1981 having "site-lisp" in their names. (Bug#10208#25, 11658)
1982
0d23c240
EZ
19832012-06-30 Eli Zaretskii <eliz@gnu.org>
1984
c9240d7a
EZ
1985 * w32proc.c (sys_select): Accept and ignore one more argument.
1986
1987 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1988
0d23c240 1989 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1990 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1991
1992 * sysdep.c: Don't include dos.h and dosfns.h.
1993
1994 * process.c (sys_select):
1995 * msdos.c (sys_select): Accept one more argument and ignore it.
1996
1997 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1998 adapt data types and code to that.
1999
2000 * dosfns.c:
2001 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2002 which clashes with the gnulib function of the same name.
2003
af5a5a98
AS
20042012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2005
c5e4379c
AS
2006 * font.c (font_style_to_value, font_style_symbolic)
2007 (font_prop_validate_style): Add type checks for values in
2008 font_style_table.
2009
af5a5a98
AS
2010 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2011 argument.
2012 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2013 uses.
2014
8d38f461
EZ
20152012-06-29 Eli Zaretskii <eliz@gnu.org>
2016
2e5a6631
EZ
2017 * xdisp.c (try_window_id): Undo last change.
2018
8d38f461
EZ
2019 * w32.c (getwd): Adjust commentary about startup_dir.
2020 (init_environment): Always call sys_access, even in non-MSVC
2021 builds. Don't chdir to the directory of the Emacs executable.
2022 This undoes code from 1997 which was justified by the need to
2023 "avoid conflicts when removing and renaming directories". But its
2024 downside was that every relative file name was being interpreted
2025 relative to the directory of the Emacs executable, which can never
2026 be TRT. In particular, it broke sys_access when called with
2027 relative file names.
2028 (sys_access): Map GetLastError to errno.
2029
2af3565e
DA
20302012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2031
2032 * window.h (struct window): Change type of 'fringes_outside_margins'
2033 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2034 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2035 Adjust comment.
2036 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2037 to ptrdiff_t.
2038
c8d3a25c 20392012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2040
c8d3a25c
GM
2041 * gnutls.c (emacs_gnutls_handshake):
2042 Add QUIT to make the loop interruptible.
57570cd3 2043
c8d3a25c 20442012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2045
c8d3a25c
GM
2046 * charset.c (init_charset): Make lack of etc/charsets fatal.
2047
3e984ee8
DA
20482012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2049
2050 * editfns.c (region_limit): Fix type mismatch.
2051
ef884f23
DA
20522012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2053
2054 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2055 undefined. Convert from xassert to eassert.
2056 * nsmenu.m: Convert from xassert to eassert.
2057 * nsterm.m: Likewise.
2058
7d7e0027
SM
20592012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2060
2061 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2062
aa754e6a
PE
20632012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 Avoid integer overflow on scroll-left and scroll-right.
2066 * window.c (HSCROLL_MAX): New macro.
2067 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2068 overflow when requested scroll falls outside ptrdiff_t range.
2069
80b00b08
DA
20702012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2071
2072 * window.h (struct window): Change type of 'hscroll',
2073 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2074 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2075 Adjust users accordingly.
2076 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2077 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2078 from EMACS_INT to ptrdiff_t.
2079 (make_window): Omit redundant initialization.
2080
62b2bcf6
JB
20812012-06-28 Juanma Barranquero <lekktu@gmail.com>
2082
2083 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2084
45942c7d
DA
20852012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2086
2087 * window.h (struct window): Change type of 'use_time' and
2088 'sequence_number' from Lisp_Object to int.
2089 * frame.c (make_frame): Adjust users accordingly.
2090 * print.c (print_object): Likewise.
2091 * window.c (select_window, Fwindow_use_time, make_parent_window)
2092 (make_window): Likewise.
2093
e509cfa6
DA
20942012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2095
2096 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2097 enabled with --enable-checking=[all,glyphs] configure option.
2098 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2099 adjust comments accordingly.
2100 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2101 undefined, adjust comments accordingly.
2102 * image.c: Likewise.
2103 * scroll.c: Likewise.
2104 * w32fns.c: Likewise.
2105 * w32term.c: Likewise.
2106 * xdisp.c: Likewise.
2107 * xfaces.c: Likewise.
2108 * xfns.c: Likewise.
2109 * xterm.c: Likewise.
2110
a54e2c05
DA
21112012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2112
2113 Generalize run-time debugging checks.
2114 * dispextern.h (XASSERTS): Remove.
2115 * fontset.c (xassert): Remove.
2116 Convert from xassert to eassert.
2117 * alloc.c: Convert from xassert to eassert.
2118 * bidi.c: Likewise.
2119 * dispnew.c: Likewise.
2120 * fns.c: Likewise.
2121 * fringe.c: Likewise.
2122 * ftfont.c: Likewise.
2123 * gtkutil.c: Likewise.
2124 * image.c: Likewise.
2125 * keyboard.c: Likewise.
2126 * menu.c: Likewise.
2127 * process.c: Likewise.
2128 * scroll.c: Likewise.
2129 * sound.c: Likewise.
2130 * term.c: Likewise.
2131 * w32console.c: Likewise.
2132 * w32fns.c: Likewise.
2133 * w32term.c: Likewise.
2134 * window.c: Likewise.
2135 * xdisp.c: Likewise.
2136 * xfaces.c: Likewise.
2137 * xfns.c: Likewise.
2138 * xselect.c: Likewise.
2139 * xterm.c: Likewise.
2140
1ec4b7b2
SM
21412012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2142
2143 * fns.c (maybe_resize_hash_table): Output message when growing the
2144 purify-hashtable.
2145
2014308a
DA
21462012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2147
2148 * alloc.c (allocate_string_data): Remove dead code.
2149 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2150 avoid GCC warning about unused macro.
2151
246155eb
DA
21522012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2153
2154 * alloc.c (allocate_string): Omit intervals initialization.
2155 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2156 as in make_pure_string and make_pure_c_string.
2157
43184b7b
DA
21582012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2159
d209e2fb 2160 * alloc.c (allocate_string): Fix last change.
43184b7b 2161
3fe6dd74
DA
21622012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2163
d209e2fb 2164 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2165 to memset, add explicit initialization where appropriate.
2166
1ba6038a
GM
21672012-06-27 Glenn Morris <rgm@gnu.org>
2168
2169 * lisp.mk (lisp): Remove paths.elc.
2170
c89926a5
CY
21712012-06-27 Chong Yidong <cyd@gnu.org>
2172
2173 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2174
ed6b3510
JW
21752012-06-26 John Wiegley <johnw@newartisans.com>
2176
1ec4b7b2 2177 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2178 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2179
ed6b3510
JW
2180 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2181 when building with Clang.
2182
8edd4a2b
SM
21832012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2184
2185 * eval.c (Fapply): Allow calling it with a single argument.
2186
f6f62d1b
EZ
21872012-06-26 Eli Zaretskii <eliz@gnu.org>
2188
2189 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2190 _stricmp and _strnicmp.
2191 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2192
62efea5e
DA
21932012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2194
2195 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2196 allocated window.
2197 (allocate_process): Likewise for new process.
8edd4a2b 2198 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2199 (allocate_frame): Likewise.
2200 * frame.c (make_frame): Omit redundant initialization.
2201 * window.c (make_parent_window): Use memset.
2202 (make_window): Omit redundant initialization.
2203 * process.c (make_process): Omit redundant initialization.
2204 * terminal.c (create_terminal): Likewise.
2205
42997f4d
DA
22062012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2207
2208 * term.c (delete_tty): Remove redundant call to memset.
2209
1130ecfc
DA
22102012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2211
2212 * alloc.c: Remove build_string.
2213 * lisp.h: Define build_string as static inline. This provides
2214 a better opportunity to optimize away calls to strlen when the
2215 function is called with compile-time constant argument.
2216 * image.c (imagemagick_error): Convert to build_string.
2217 * w32proc.c (sys_spawnve): Likewise.
2218 * xterm.c (x_term_init): Likewise.
2219
cf38a720
PE
22202012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2221
99027bdd
PE
2222 Use sprintf return value instead of invoking strlen on result.
2223 In the old days this wasn't portable, since some sprintf
2224 implementations returned char *. But they died out years ago and
2225 Emacs already assumes sprintf returns int.
2226 Similarly for float_to_string.
2227 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2228 * ccl.c (ccl_driver):
2229 * character.c (string_escape_byte8):
2230 * data.c (Fnumber_to_string):
2231 * doprnt.c (doprnt):
2232 * print.c (print_object):
2233 * xdisp.c (message_dolog):
2234 * xfns.c (syms_of_xfns):
2235 Use sprintf or float_to_string result to avoid need to call strlen.
2236 * data.c (Fnumber_to_string):
2237 Use make_unibyte_string, since the string must be ASCII.
2238 * lisp.h, print.c (float_to_string): Now returns int length.
2239 * term.c (produce_glyphless_glyph):
2240 Use sprintf result rather than recomputing it.
2241
cf38a720
PE
2242 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2243 * Makefile.in (ALL_CFLAGS):
2244 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2245 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2246
3511c784
DA
22472012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2248
0a08eb21 2249 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2250 strcasecmp if available.
2251 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2252
fb7da12e
AS
22532012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2254
2255 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2256 Avoid comma operator.
2257 * menu.c (push_submenu_start, push_submenu_end)
2258 (push_left_right_boundary, push_menu_pane): Likewise.
2259 * msdos.c (dos_rawgetc): Likewise.
2260
afa2ffd8
DA
22612012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2262
2263 * xfns.c (xic_create_fontsetname): Remove redundant calls
2264 to memset.
2265
b3b4476b
PE
22662012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2267
4495ff38
PE
2268 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2269 sprintf already null-terminates its output.
2270
b3b4476b
PE
2271 * xfns.c (x_window): Remove redundant cast.
2272
b00876c9
DA
22732012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2274
2275 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2276 `const char *' to `char *' to avoid compiler warning.
2277
d188e26b
PE
22782012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2279
885d1d74
PE
2280 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2281 instead of truncating it to 63 (admittedly a generous limit).
2282
d188e26b
PE
2283 * process.c: Fix spelling and caps in comments.
2284
e2f560b1
DN
22852012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2286
e86db54b 2287 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2288 * sysdep.c (setpgrp): Remove definition, not used in this file.
2289
7583a3a1
JB
22902012-06-24 Juanma Barranquero <lekktu@gmail.com>
2291
2292 * makefile.w32-in: Update dependencies.
2293
696056c2
EZ
22942012-06-24 Eli Zaretskii <eliz@gnu.org>
2295
2296 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2297 (SYSTIME_H): Add nt/inc/sys/time.h.
2298
2299 * systime.h [WINDOWSNT]: Include sys/time.h.
2300
2301 * s/ms-w32.h (struct timespec): Definition moved from
2302 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2303
845ca893
PE
23042012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2305
2306 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2307 * buffer.h (buffer_slot_type_mismatch):
2308 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2309 * eval.c (unwind_to_catch):
2310 * image.c (my_png_error, my_error_exit):
2311 * keyboard.c (quit_throw_to_read_char, user_error)
2312 (Fexit_recursive_edit, Fabort_recursive_edit):
2313 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2314 (wrong_type_argument, buffer_overflow, __executable_start)
2315 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2316 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2317 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2318 (fatal):
2319 (child_setup) [!DOS_NT]:
2320 * lread.c (end_of_file_error, invalid_syntax):
2321 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2322 * puresize.h (pure_write_error):
2323 * search.c (matcher_overflow):
2324 * sound.c (sound_perror, alsa_sound_perror):
2325 * sysdep.c, syssignal.h (croak):
2326 * term.c (maybe_fatal, vfatal):
2327 * textprop.c (text_read_only):
2328 * undo.c (user_error):
2329 * unexmacosx.c (unexec_error):
2330 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2331 Use _Noreturn rather than NO_RETURN.
2332 No need for separate decl merely because of _Noreturn.
2333 * sound.c (sound_warning, parse_sound):
2334 Remove unnecessary forward decls.
2335
f1dd8073
PE
23362012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2337
2338 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2339 * lisp.h (WAIT_READING_MAX): New macro.
2340 * dispnew.c (Fsleep_for, sit_for):
2341 * keyboard.c (kbd_buffer_get_event):
2342 * process.c (Faccept_process_output):
2343 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2344 This improves on the previous patch, which introduced a bug
2345 when time_t is unsigned and as wide as intmax_t.
2346 See <http://bugs.gnu.org/9000#51>.
2347
b82c1755
EZ
23482012-06-23 Eli Zaretskii <eliz@gnu.org>
2349
2350 * dispnew.c (sit_for, Fsleep_for):
2351 * keyboard.c (kbd_buffer_get_event):
2352 * process.c (Faccept_process_output): Avoid compiler warnings when
2353 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2354
ca300656
JB
23552012-06-23 Juanma Barranquero <lekktu@gmail.com>
2356
049ec95b
JB
2357 * makefile.w32-in: Update dependencies.
2358
ca300656
JB
2359 * w32.c (ltime): Add return type and declare static.
2360 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2361
db7b8d06
PE
23622012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2363
2364 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2365 Privately reported by Herbert J. Skuhra.
2366 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2367 All uses changed.
2368 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2369 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2370
0bd8297f
EZ
23712012-06-23 Eli Zaretskii <eliz@gnu.org>
2372
96512555
EZ
2373 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2374 last argument of make_unibyte_string.
2375
0bd8297f
EZ
2376 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2377 language ID in the event parameters.
2378
2379 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2380 event.code, not the obscure "character set ID".
2381
63def6b6
CY
23822012-06-23 Chong Yidong <cyd@gnu.org>
2383
2384 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2385
e8a02204
EZ
23862012-06-23 Eli Zaretskii <eliz@gnu.org>
2387
388cdec0
EZ
2388 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2389 * w32.c (fdutimens): New function.
2390
2391 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2392
2393 * s/ms-w32.h (pselect): Redirect to sys_select.
2394
2395 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2396
e8a02204
EZ
2397 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2398 in the logic of incrementing and decrementing the value of
2399 use_relocatable_buffers.
2400
d054f3fb
PE
24012012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2402
2403 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2404 Privately reported by Herbert J. Skuhra.
2405 [__FreeBSD__]: Remove "*/" typo after "#include".
2406 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2407 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2408 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2409 Don't assume EMACS_TIME and struct timeval are the same type.
2410
d35af63c
PE
24112012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2412
2413 Support higher-resolution time stamps (Bug#9000).
2414 The time stamps are only nanosecond-resolution at the C level,
2415 since that's the best that any real-world system supports now.
2416 But they are picosecond-resolution at the Lisp level, as that's
2417 easy, and leaves room for future OS improvements.
2418
2419 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2420 (LIBES): Use it.
2421
2422 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2423 Don't get current time unless it's needed.
2424
2425 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2426 now provides it if it's absent.
2427 (start_atimer): Port to higher-res time stamps.
2428 Check for time stamp overflow. Don't get current time more
2429 often than is needed.
2430
2431 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2432 Include systime.h, not time.h.
2433 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2434
2435 * dired.c: Include stat-time.h.
2436 (Ffile-attributes): File times now have higher resolution.
2437
2438 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2439 (struct image): Timestamp now has higher resolution.
2440
2441 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2442 has at least microseconds now. All uses removed.
2443 (update_frame, update_single_window, update_window, update_frame_1)
2444 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2445
2446 * editfns.c (time_overflow): Now extern.
2447 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2448 (float-time, Fformat_time_string, Fcurrent_time_string)
2449 (Fcurrent_time_zone): Accept and generate higher-resolution
2450 time stamps.
2451 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2452 (decode_time_components, lisp_seconds_argument): New functions.
2453 (make_time): Now static.
2454 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2455 Report an error if the time is invalid, rather than having the caller
2456 do that.
2457
2458 * fileio.c: Include <stat-time.h>
2459 (Fcopy_file): Copy higher-resolution time stamps.
2460 Prefer to set the time stamp via a file descriptor if that works.
2461 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2462 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2463 (Fvisited_file_modtime, Fset_visited_file_modtime):
2464 Support higher-resolution time stamps.
2465
2466 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2467
2468 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2469
2470 * image.c (prepare_image_for_display, clear_image_cache)
2471 (lookup_image): Port to higer-resolution time stamps.
2472
2473 * keyboard.c (start_polling, bind_polling_period):
2474 Check for time stamp overflow.
2475 (read_char, kbd_buffer_get_event, timer_start_idle)
2476 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2477 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2478 Port to higher-resolution time stamps. Do not assume time_t is signed.
2479 (decode_timer): New function. Timers are now vectors of length 9,
2480 not 8, to accommodate the picosecond component.
2481 (timer_check_2): Use it.
2482
2483 * nsterm.m (select_timeout, timeval_subtract): Remove.
2484 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2485 as they're a bit more accurate and handle overflow better.
2486 (ns_select): Change prototype to be compatible with pselect.
2487 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2488 * nsterm.h (ns_select): Adjust prototype.
2489
2490 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2491 us-resolution time stamps.
2492 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2493
2494 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2495
2496 * lisp.h (time_overflow): New decl.
2497 (wait_reading_process_output): First arg is now intmax_t, not int,
2498 to accommodate larger waits.
2499
2500 * process.h (struct Lisp_Process.read_output_delay):
2501 Now counts nanoseconds, not microseconds.
2502 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2503 EMACS_HAS_USECS.
2504 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2505 (wait_reading_process_output):
2506 Port to ns-resolution time stamps.
2507 (Faccept_process_output, wait_reading_process_output):
2508 Check for time stamp overflow. Do not assume time_t is signed.
2509 (select_wrapper): Remove; we now use pselect.
2510 (Fprocess_attributes): Now generates ns-resolution time stamps.
2511
2512 * sysdep.c: Include utimens.h. Don't include utime.h
2513 or worry about struct utimbuf; gnulib does that for us now.
2514 (gettimeofday): Remove; gnulib provides a substitute.
2515 (make_timeval): New function.
2516 (set_file_times): Now sets ns-resolution time stamps.
2517 New arg FD; all uses changed.
2518 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2519 (system_process_attributes):
2520 Now returns ns-resolution time stamp. All uses changed.
2521 Check for time stamp overflow.
2522
2523 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2524 provides a substitute now.
2525
2526 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2527 since it guarantees struct timespec.
2528 (EMACS_TIME): Now struct timespec, so that we can support
2529 ns-resolution time stamps.
2530 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2531 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2532 (EMACS_USECS): Remove.
2533 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2534 so multiply the arg by 1000 before storing it.
2535 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2536 New macros.
2537 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2538 Port to ns-resolution time stamps.
2539 (EMACS_TIME_NEG_P): Remove; replaced by....
2540 (EMACS_TIME_SIGN): New macro.
2541 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2542 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2543 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2544 (make_timeval, make_lisp_time, decode_time_components): New decls.
2545 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2546 that it mishandled time_t overflow. You can't compare by subtracting!
2547 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2548 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2549
2550 * term.c: Include <sys/time.h>.
2551 (timeval_to_Time): New function, for proper overflow wraparound.
2552 (term_mouse_position, term_mouse_click): Use it.
2553
2554 * undo.c (record_first_change): Support higher-resolution time stamps
2555 in the undo buffer.
2556 (Fprimitive_undo): Use them when restoring time stamps.
2557
2558 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2559 (w32_get_internal_run_time):
2560 Port to higher-resolution Emacs time stamps.
2561 (ltime): Now accepts single 64-bit integer, as that's more convenient
2562 for callers.
2563
2564 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2565
2566 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2567 for compatibility with pselect. Support ns-resolution time stamps.
2568
2569 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2570
2571 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2572 Check for time stamp overflow, and support ns-resolution time stamps.
2573
2574 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2575 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2576 (timeval_subtract): Remove; no longer needed.
2577 (XTflash, XTring_bell, x_wait_for_event):
2578 Port to ns-resolution time stamps. Don't assume time_t is signed.
2579
b6a92dfe
CY
25802012-06-22 Chong Yidong <cyd@gnu.org>
2581
2582 * xdisp.c (x_consider_frame_title): Revert last change.
2583
d251c37c
EZ
25842012-06-22 Eli Zaretskii <eliz@gnu.org>
2585
2586 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2587 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2588 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2589 staticidx goes up to 1597 out of 1600 = 0x640.)
2590
f10deafb
PE
25912012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2592
2593 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2594 Otherwise, the umask might be mistakenly 0 while handling input signals.
2595
ec6de1e2
SM
25962012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2597
2598 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2599
28be1ada
DA
26002012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2601
2602 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2603 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2604 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2605 access to `contents' member of Lisp_Vector objects with AREF and ASET
2606 where appropriate.
2607
c6bf3022
CY
26082012-06-19 Chong Yidong <cyd@gnu.org>
2609
2610 * frame.c (delete_frame): When selecting a frame on a different
2611 text terminal, do not alter the terminal's top-frame.
2612
2613 * xdisp.c (format_mode_line_unwind_data): Record the target
2614 frame's selected window and its terminal's top-frame.
2615 (unwind_format_mode_line): Restore them.
2616 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2617 Callers changed.
2618 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2619 since tty frames can be explicitly named.
2620 (prepare_menu_bars): Likewise.
2621
2622 * term.c (Ftty_top_frame): New function.
2623
defd4196
PE
26242012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2625
2626 Port byte-code-meter to modern targets.
2627 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2628 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2629 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2630 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2631 (METER_1, METER_2): Simplify.
2632
1053a871
SM
26332012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2634
2635 * data.c (Fdefalias): Return `symbol' (bug#11686).
2636
b7e8d081
MR
26372012-06-18 Martin Rudalics <rudalics@gmx.at>
2638
2639 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2640 gets killed during executing of this function (Bug#11665).
2641 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2642 (Vkill_buffer_query_functions): In doc-string say that functions
2643 run by this hook should not change the current buffer.
2644
7ea2b339
PE
26452012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2646
2647 Fix recently-introduced process.c problems found by static checking.
2648 * process.c (write_queue_push, write_queue_pop, send_process):
2649 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2650 (write_queue_pop): Fix pointer signedness problem.
2651 (send_process): Remove unused local.
2652
96a313a1
CY
26532012-06-17 Chong Yidong <cyd@gnu.org>
2654
2655 * xdisp.c (redisplay_internal): No need to redisplay terminal
2656 frames that are not on top.
2657
20ca2e94
TN
26582012-06-17 Troels Nielsen <bn.troels@gmail.com>
2659
2660 * process.c (make_process): Initialize write_queue.
2661 (write_queue_push, write_queue_pop): New functions.
2662 (send_process): Use them to maintain correct ordering of process
2663 writes (Bug#10815).
2664
9a900ca9
PE
26652012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2666
310fbfa8
PE
2667 * lisp.h (eassert): Assume C89 or later.
2668 This removes the need for CHECK.
2669 (CHECK): Remove. Its comments about always evaluating its
2670 argument were confusing, as 'eassert' typically does not evaluate
2671 its argument.
2672
27bb1ca4
PE
2673 * coding.c (produce_chars): Use ptrdiff_t, not int.
2674
9a900ca9
PE
2675 * xterm.c (x_draw_underwave): Check for integer overflow.
2676 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2677
41b7f8bc 26782012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2679
2680 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2681 referenced (Bug#11583).
2682
9b0e3eba
AA
26832012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2684
2685 Implement wave-style variant of underlining.
2686 * dispextern.h (face_underline_type): New enum.
2687 (face): Add field for underline type.
2688 * nsterm.m (ns_draw_underwave): New function.
2689 (ns_draw_text_decoration): Use it.
2690 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2691 New functions.
2692 (x_draw_glyph_string): Use them.
2693 * xfaces.c (Qline, Qwave): New Lisp objects.
2694 (check_lface_attrs, merge_face_ref)
1053a871
SM
2695 (Finternal_set_lisp_face_attribute, realize_x_face):
2696 Handle wave-style underline face attributes.
9b0e3eba
AA
2697 * xterm.c (x_draw_underwave): New function.
2698 (x_draw_glyph_string): Use it.
2699
0fb52f11
JB
27002012-06-16 Juanma Barranquero <lekktu@gmail.com>
2701
2702 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2703 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2704 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2705 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2706 ($(BLD)/w32select.$(O)): Update dependencies.
2707
e5560ff7
AS
27082012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2709
2710 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2711 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2712 * character.c (_fetch_multibyte_char_p): Remove.
2713 * alloc.c: Include "character.h" before "buffer.h".
2714 * bidi.c: Likewise.
2715 * buffer.c: Likewise.
2716 * bytecode.c: Likewise.
2717 * callint.c: Likewise.
2718 * callproc.c: Likewise.
2719 * casefiddle.c: Likewise.
2720 * casetab.c: Likewise.
2721 * category.c: Likewise.
2722 * cmds.c: Likewise.
2723 * coding.c: Likewise.
2724 * composite.c: Likewise.
2725 * dired.c: Likewise.
2726 * dispnew.c: Likewise.
2727 * doc.c: Likewise.
2728 * dosfns.c: Likewise.
2729 * editfns.c: Likewise.
2730 * emacs.c: Likewise.
2731 * fileio.c: Likewise.
2732 * filelock.c: Likewise.
2733 * font.c: Likewise.
2734 * fontset.c: Likewise.
2735 * fringe.c: Likewise.
2736 * indent.c: Likewise.
2737 * insdel.c: Likewise.
2738 * intervals.c: Likewise.
2739 * keyboard.c: Likewise.
2740 * keymap.c: Likewise.
2741 * lread.c: Likewise.
2742 * macros.c: Likewise.
2743 * marker.c: Likewise.
2744 * minibuf.c: Likewise.
2745 * nsfns.m: Likewise.
2746 * nsmenu.m: Likewise.
2747 * print.c: Likewise.
2748 * process.c: Likewise.
2749 * regex.c: Likewise.
2750 * region-cache.c: Likewise.
2751 * search.c: Likewise.
2752 * syntax.c: Likewise.
2753 * term.c: Likewise.
2754 * textprop.c: Likewise.
2755 * undo.c: Likewise.
2756 * unexsol.c: Likewise.
2757 * w16select.c: Likewise.
2758 * w32fns.c: Likewise.
2759 * w32menu.c: Likewise.
2760 * window.c: Likewise.
2761 * xdisp.c: Likewise.
2762 * xfns.c: Likewise.
2763 * xmenu.c: Likewise.
2764 * xml.c: Likewise.
2765 * xselect.c: Likewise.
2766
2f07e6af
EZ
27672012-06-16 Eli Zaretskii <eliz@gnu.org>
2768
1053a871
SM
2769 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2770 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2771 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2772 row.
2773 (handle_face_prop): Use chunk-relative overlay string index when
2774 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2775 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2776 the rightmost. (Bug#11720)
2f07e6af 2777
29b83cec
AS
27782012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2779
2780 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2781 (CATEGORY_MEMBER): Enforce 1/0 value.
2782 * category.c (_temp_category_set): Remove.
2783
4c5501e9
EZ
27842012-06-16 Eli Zaretskii <eliz@gnu.org>
2785
2786 * window.c (Fdelete_other_windows_internal)
2787 (Fdelete_window_internal): Don't access frame's mouse highlight
2788 info of the initial frame. (Bug#11677)
2789
2b570124
PE
27902012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2791
e93864f9
PE
2792 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2793 Assume USE_2_TAGS_FOR_INTS.
2794 (xreload): Adjust $tagmask width to match recent lisp.h change.
2795
2b570124
PE
2796 Simplify lisp.h in minor ways that should not affect code.
2797 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2798 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2799 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2800 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2801 (INTTYPEBITS): New macro, for clarity.
2802 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2803 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2804 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2805 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2806 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2807
81755f69
JB
28082012-06-13 Juanma Barranquero <lekktu@gmail.com>
2809
2810 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2811
16192a57
GM
28122012-06-13 Glenn Morris <rgm@gnu.org>
2813
2814 * s/bsd-common.h (BSD4_3):
2815 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2816
646b5f55
AS
28172012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2818
2819 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2820 instead of union.
2821 (XLI, XIL): Define.
1053a871
SM
2822 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2823 Use them.
2824 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2825 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2826 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2827 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2828 * frame.c (delete_frame): Remove outdated comment.
2829 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2830 USE_LISP_UNION_TYPE.
2831 (Fw32_unregister_hot_key): Likewise.
2832 (Fw32_toggle_lock_key): Likewise.
2833 * w32menu.c (add_menu_item): Likewise.
2834 (w32_menu_display_help): Use XIL instead of checking
2835 USE_LISP_UNION_TYPE.
2836 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2837 (init_heap): Likewise.
2838 * w32term.c (w32_read_socket): Update comment.
2839
1d3823c9
GM
28402012-06-13 Glenn Morris <rgm@gnu.org>
2841
c62ff706
GM
2842 * s/usg5-4-common.h, src/s/unixware.h:
2843 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2844
1d3823c9
GM
2845 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2846
bfe3e0a2
PE
28472012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2848
2849 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2850 * alloc.c (make_number) [!defined make_number]:
2851 Remove, as lisp.h always defines this now.
2852 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2853 (roundup_size): Verify that it is a power of 2.
2854 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2855 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2856 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2857 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2858 USE_LSB_TAG now is always defined to be either 0 or 1.
2859 All uses changed.
2860 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2861 code works fine either way, and efficiency is not a concern here,
2862 as the union type is for debugging, not for production.
2863 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2864 Use an inline function on all platforms when using the union type,
2865 since this is simpler and 'static inline' can be used portably
2866 within Emacs now.
2867 (LISP_INITIALLY_ZERO): New macro.
2868 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2869 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2870
45fa9c0f
GM
28712012-06-12 Glenn Morris <rgm@gnu.org>
2872
b4492cba
GM
2873 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2874
2875 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2876
45fa9c0f
GM
2877 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2878 Move BROKEN_SIGIO to configure.
2879
2880 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2881 Move NO_TERMIO to configure.
2882
0e25d334
CY
28832012-06-12 Chong Yidong <cyd@gnu.org>
2884
2885 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2886 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2887 MagickExportImagePixels is undefined.
2888
43682bb6
PE
28892012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2890
2891 * image.c (imagemagick_load_image): Remove unused label.
2892
a9be7d2b
GM
28932012-06-11 Glenn Morris <rgm@gnu.org>
2894
2895 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2896 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2897 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2898 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2899
3017f87f
SM
29002012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2901
2902 * alloc.c (make_byte_code): New function.
2903 (Fmake_byte_code): Use it. Don't purify here.
2904 * lread.c (read1): Use it as well to avoid extra allocation.
2905
1b9b4cf4
CY
29062012-06-11 Chong Yidong <cyd@gnu.org>
2907
2908 * image.c (imagemagick_load_image): Implement transparency.
2909
95988fcf
AS
29102012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2911
2912 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2913 account for preceding backslashes. (Bug#11663)
2914
cd4eb164
CY
29152012-06-09 Chong Yidong <cyd@gnu.org>
2916
2917 * term.c: Support italics in capable terminals (Bug#9652).
2918 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2919 (turn_on_face): Output using TS_enter_italic_mode if available.
2920 Don't handle unused blinking and alt-charset cases.
2921 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2922 and tty_alt_charset_p cases.
2923 (tty_capable_p, init_tty): Support italics.
2924
2925 * termchar.h (struct tty_display_info): Add field for italics.
2926 Remove unused blink field.
2927
2928 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2929 Handle slant.
2930
2931 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2932 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2933 tty_alt_charset_p. Add tty_italic_p.
2934
ff88beb8
MA
29352012-06-09 Michael Albinus <michael.albinus@gmx.de>
2936
2937 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2938 dbus_type_is_basic if available.
2939 (xd_extract_signed, xd_extract_unsigned): Rename from
2940 extract_signed and extract_unsigned, respectively. Adapt callers.
2941
44286096
CY
29422012-06-09 Chong Yidong <cyd@gnu.org>
2943
1682701f
CY
2944 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2945
44286096
CY
2946 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2947 case (Bug#9752).
2948
d86feb17
PE
29492012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2950
2951 * xdisp.c (vmessage): Treat frame message as multibyte.
2952 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2953 would generate the diagnostic "Making \302\247 buffer-local while
2954 let-bound!".
2955
d5c20fe8
EZ
29562012-06-08 Eli Zaretskii <eliz@gnu.org>
2957
2958 * dispnew.c (showing_window_margins_p): Undo last change, which
2959 was done due to an inadvertent commit.
2960 (adjust_frame_glyphs_for_frame_redisplay): Do call
2961 showing_window_margins_p.
2962
513749ee
SM
29632012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2964
2965 * eval.c (Fmake_var_non_special): New primitive.
2966 (syms_of_eval): Defsubr it.
2967 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2968
d4a8f5c1
JB
29692012-06-08 Juanma Barranquero <lekktu@gmail.com>
2970
2971 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2972 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2973
8bbbc977
EZ
29742012-06-08 Eli Zaretskii <eliz@gnu.org>
2975
2976 * alloc.c (allocate_vectorlike): Fix last change.
2977
f3372c87
DA
29782012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2979
2980 Block-based vector allocation of small vectors.
2981 * lisp.h (struct vectorlike_header): New field `nbytes',
2982 adjust comment accordingly.
2983 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2984 to denote vector blocks. Adjust users (live_vector_p,
2985 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2986 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2987 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2988 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2989 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2990 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2991 (roundup_size): New constant.
2992 (struct vector_block): New data type.
2993 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2994 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2995 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2996 (sweep_vectors): New functions.
2997 (allocate_vectorlike): Return `zero_vector' as the only vector of
2998 0 items. Allocate new vector from block if vector size is less than
2999 or equal to VBLOCK_BYTES_MAX.
3000 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3001 (init_alloc_once): Add call to init_vectors.
3002
4f18a4ed
SM
30032012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3004
3005 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3006
86f158bc
PE
30072012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3008
3009 * doprnt.c (doprnt): Truncate multibyte char correctly.
3010 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3011 would mishandle a string argument "Xc" if X was a multibyte
3012 character of length 2: it would truncate after X's first byte
3013 rather than including all of X.
3014
c5cfcbe0
CY
30152012-06-06 Chong Yidong <cyd@gnu.org>
3016
3017 * buffer.c (word_wrap): Doc fix.
3018
c05cf390
PE
30192012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3020
3021 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3022
0c3461de
GM
30232012-06-03 Glenn Morris <rgm@gnu.org>
3024
3025 * xdisp.c (tool-bar-style): Doc fix.
3026
c71232db
UM
30272012-06-03 Ulrich Müller <ulm@gentoo.org>
3028
3029 * Makefile.in (PAXCTL): Define.
3030 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3031 binary via PaX flags if the paxctl utility is available.
3032 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3033 Restore PaX flags to their default. (Bug#11398)
3034
383f7350
CY
30352012-06-03 Chong Yidong <cyd@gnu.org>
3036
3037 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3038 buffer (Bug#11226).
3039
5f2c76c6
CY
30402012-06-03 Chong Yidong <cyd@gnu.org>
3041
3042 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3043 (note_mode_line_or_margin_highlight): If there is no help echo,
3044 use mode-line-default-help-echo. Handle the case where the mouse
3045 position is past the end of the mode line string.
3046
3047 * buffer.c (buffer_local_value_1): New function, split from
3048 Fbuffer_local_value; can return Qunbound.
3049 (Fbuffer_local_value): Use it.
3050 (Vmode_line_format): Docstring tweaks.
3051
773d47f6
PE
30522012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3053
3054 * sysdep.c (system_process_attributes): Improve comment.
3055
f2d6a3df
SM
30562012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3057
3058 * keyboard.c: Export real-this-command to Elisp.
3059 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3060 and DEFVAR it. Update all users.
3061
63810350
PE
30622012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3063
7bd5c1f4
PE
3064 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3065
63810350
PE
3066 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3067 Convert pctcpu and pctmem to Lisp float properly.
3068 Let the compiler fold better, as 100.0/0x8000 is exact.
3069
a2821611
AS
30702012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3071
3072 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3073 cons_block.
3074
5fceba1d
PE
30752012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3076
3077 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3078
c98ff5dd
DA
30792012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3080
3081 For a 'struct window', replace some Lisp_Object fields to
3082 bitfields where appropriate, remove unused fields.
3083 * window.h (struct window): Remove unused 'last_mark_x' and
3084 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3085 change it's type from Lisp_Object to bitfield.
3086 Change type of 'force_start', 'optional_new_start',
3087 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3088 fields from Lisp_Object to bitfield. Adjust users accordingly.
3089
ca34e0be
PE
30902012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3091
3092 Pacify gcc -Wdouble-precision when using Xaw.
3093 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3094 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3095 Use 'float' consistently, rather than 'float' in most places
3096 and 'double' in a couple of places.
3097
efc00ab1 30982012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3099
3100 * xdisp.c (handle_stop): Detect whether we have overlay strings
3101 loaded by testing it->current.overlay_string_index to be
3102 non-negative, instead of checking whether n_overlay_strings is
3103 positive. (Bug#11587)
3104
efc00ab1 31052012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3106
3107 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3108
3109 * doc.c (Fsubstitute_command_keys): Doc fix.
3110
efc00ab1 31112012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3112
3113 * search.c (search_buffer): Remove calls to
3114 r_alloc_inhibit_buffer_relocation, as it is now called by
3115 maybe_unify_char, which was the cause of relocation of buffer text
3116 in bug#11519.
3117
efc00ab1 31182012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3119
3120 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3121 for the duration of call to load_charset, to avoid problems with
3122 callers of maybe_unify_char that access buffer text through C
3123 pointers.
3124
3125 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3126 decrement the inhibition flag, instead of just setting or
3127 resetting it.
3128
ba93a187
PE
31292012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3130
3131 Remove obsolete '#define static' cruft.
3132 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3133 This #undef was "temporary" in 2000; it is no longer needed
3134 now that '#define static' has gone away.
3135 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3136 (gray_bitmap_bits): Remove; no longer needed.
3137 All uses replaced with definiens.
3138 * xterm.c: Include "bitmaps/gray.xbm".
3139
9e4bf381
PE
31402012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3141
3142 Clean up __executable_start, monstartup when --enable-profiling.
3143 The following changes affect the code only when profiling.
3144 * dispnew.c (__executable_start): Rename from safe_bcopy.
3145 Define only on platforms that need it.
3146 * emacs.c: Include <sys/gmon.h> when profiling.
3147 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3148 (__executable_start): Remove decl, since lisp.h does it now.
3149 (safe_bcopy): Remove decl; no longer has that name.
3150 (main): Coalesce #if into single bit of code, for simplicity.
3151 Cast pointers to uintptr_t, since standard libraries want integers
3152 and not pointers.
3153 * lisp.h (__executable_start): New decl.
3154
32d72c2f
GM
31552012-05-31 Glenn Morris <rgm@gnu.org>
3156
3157 * image.c (Fimagemagick_types): Doc fix.
3158
baac5bc7
JM
31592012-05-30 Jim Meyering <meyering@redhat.com>
3160
3161 * callproc.c (Fcall_process_region): Include directory component
3162 in mkstemp error message (Bug#11586).
3163
72cb32cf
PE
31642012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3165
3166 * alloc.c, lisp.h (make_pure_vector): Now static.
3167
61b108cc
SM
31682012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3169
3170 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3171 Move to byte-run.el.
3172 (Fautoload): Do the hash-doc more carefully.
3173 * data.c (Fdefalias): Purify definition, except for keymaps.
3174 (Qdefun): Move from eval.c.
3175 * lisp.h (Qdefun): Remove.
3176 * lread.c (read1): Tiny simplification.
3177
471fe23d
TN
31782012-05-29 Troels Nielsen <bn.troels@gmail.com>
3179
934f3f58 3180 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3181 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3182 Bug#9642, but explicitly check that the buffer the overlay would
3183 be moved to is live and rearrange lines to make sure that errors
3184 will not put the overlay in an inconsistent state.
3185 (Fdelete_overlay): Cosmetics.
3186
85d0efd1
EZ
31872012-05-28 Eli Zaretskii <eliz@gnu.org>
3188
3189 * w32term.c (my_bring_window_to_top): New function.
3190 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3191 could be different from the original one.
3192 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3193 (Bug#11513)
3194
3195 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3196 by calling BringWindowToTop.
3197
3198 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3199 (WM_EMACS_END): Increase by one.
3200
da92a98c
PE
32012012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3202
3203 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3204 This avoids undefined behavior that might cause the eassert
3205 to not catch an out-of-range value.
3206
74d1f848
JB
32072012-05-28 Juanma Barranquero <lekktu@gmail.com>
3208
3209 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3210 Update dependencies.
3211
9e1a06fc
EZ
32122012-05-27 Eli Zaretskii <eliz@gnu.org>
3213
3214 * bidi.c (bidi_mirror_char): Fix last change.
3215
f3dd7312
AS
32162012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3217
3218 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3219 when referring to sectname field in printf format.
3220
81899c91
PE
32212012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3222
57b81a9f
PE
3223 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3224 Only r_alloc_inhibit_buffer_relocation needed to be added;
3225 the others were already declared.
3226
81899c91
PE
3227 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3228 before checking whether it's out of range. Put the check inside
3229 eassert. See
3230 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3231
33017faf 32322012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3233
3234 * callproc.c (Fcall_process): Restore a line that was accidentally
3235 commented out in the 2011-02-13 change (bug#11547).
3236
33017faf 32372012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3238
3239 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3240 defined on ralloc.c.
3241
3242 * buffer.c [REL_ALLOC]: Remove prototypes of
3243 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3244 they are now on lisp.h.
3245
3246 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3247
3248 * search.c (search_buffer): Use it to inhibit relocation of buffer
3249 text while re_search_2 is doing its job, because re_search_2 is
3250 passed C pointers to buffer text. (Bug#11519)
3251
23415acf
EZ
3252 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3253 Update value to 24.
3254
44e27368
EZ
3255 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3256 state after an additional call to move_it_in_display_line_to, keep
3257 the values of it->max_ascent and it->max_descent found for the
3258 entire line.
3259 (pos_visible_p): Revert the comparison against bottom_y to what it
3260 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3261 (Bug#11464)
3262
c1892f11
PE
32632012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3264
3265 Fix coding-related core dumps with gcc -ftrapv.
3266 The code was computing A - B, where A and B are pointers, and B is
3267 random garbage. This can lead to core dumps on platforms that
3268 have special pointer registers, and it also leads to core dumps on
3269 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3270 A - B only when B is initialized properly.
3271 * coding.c (coding_set_source, coding_set_destination): Return void.
3272 (coding_change_source, coding_change_destinations): New functions,
3273 with the old behaviors of coding_set_source and coding_set_destination.
3274 All callers that need an offset changed to use these new functions.
3275
eb7afdad
GM
32762012-05-26 Glenn Morris <rgm@gnu.org>
3277
3278 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3279
f12fdf02
EZ
32802012-05-26 Eli Zaretskii <eliz@gnu.org>
3281
53a63be6 3282 Extend mouse support on W32 text-mode console.
61b108cc
SM
3283 * xdisp.c (draw_row_with_mouse_face):
3284 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3285
eb3f6f01 3286 * w32console.c: Include window.h.
61b108cc
SM
3287 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3288 New functions.
eb3f6f01
EZ
3289 (initialize_w32_display): Initialize mouse-highlight data.
3290
53a63be6
EZ
3291 * w32inevt.c: Include termchar.h and window.h.
3292 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3293 moves, call note_mouse_highlight. If help_echo changed, call
3294 gen_help_event to produce help-echo message in the echo area.
3295 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3296 highlight info.
3297
4cfd81f6
PE
32982012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3299
3300 * lread.c (read1): Simplify slightly to avoid an overflow warning
3301 with GCC 4.7.0 on x86-64.
3302
4446092a
EZ
33032012-05-26 Eli Zaretskii <eliz@gnu.org>
3304
3305 * bidi.c (bidi_mirror_char): Revert last change: an int is
3306 definitely wide enough here.
3307
42b2a986 33082012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3309
42b2a986 3310 Fix integer width and related bugs (Bug#9874).
eb106a49 3311 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3312 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3313 (string_bytes, check_sblock, allocate_string_data):
3314 (compact_small_strings, Fmake_bool_vector, make_string)
3315 (make_unibyte_string, make_multibyte_string)
3316 (make_string_from_bytes, make_specified_string)
3317 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3318 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3319 (mark_vectorlike):
3320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3321 (allocate_pseudovector):
3322 Use int, not EMACS_INT, where int is wide enough.
3323 (inhibit_garbage_collection, Fgarbage_collect):
3324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3325 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3326 int might not be wide enough.
3327 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3328 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3329 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3330 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3331 (bidi_level_of_next_char, bidi_move_to_visually_next):
3332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3333 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3334 (Fkill_buffer, Fset_buffer_major_mode)
3335 (advance_to_char_boundary, Fbuffer_swap_text)
3336 (Fset_buffer_multibyte, overlays_at, overlays_in)
3337 (overlay_touches_p, struct sortvec, record_overlay_string)
3338 (overlay_strings, recenter_overlay_lists)
3339 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3340 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3341 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3342 (Foverlay_recenter, last_overlay_modification_hooks_used)
3343 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3345 (validate_region): Omit unnecessary test for b <= e,
3346 since that's guaranteed by the previous test.
d311d28c
PE
3347 (adjust_overlays_for_delete): Avoid pos + length overflow.
3348 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3349 (report_overlay_modification):
3350 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3351 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3352 Omit pointer cast, which isn't needed anyway, and doesn't work
3353 after the EMACS_INT -> ptrdiff_t change.
02481186 3354 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3355 * buffer.h: Adjust decls to match defn changes elsewhere.
3356 (struct buffer_text, struct buffer):
3357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3358 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3359 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3360 not int, to avoid needless 32-bit limit on 64-bit hosts.
3361 (exec_byte_code): Use tighter memory-full test, one that checks
3362 for alloca overflow. Don't compute the address of the object just
3363 before an array, as that's not portable. Use EMACS_INT, not
3364 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3365 * callint.c (Fcall_interactively):
3366 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3367 * callproc.c (call_process_kill, Fcall_process):
3368 Don't assume pid_t fits into an Emacs fixnum.
3369 (call_process_cleanup, Fcall_process, child_setup):
3370 Don't assume pid_t fits into int.
3371 (call_process_cleanup, Fcall_process, delete_temp_file)
3372 (Fcall_process_region):
3373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3374 (Fcall_process): Simplify handling of volatile integers.
3375 Use int, not EMACS_INT, where int will do.
3376 * casefiddle.c (casify_object, casify_region, operate_on_word)
3377 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3379 (casify_object): Avoid integer overflow when overallocating buffer.
3380 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3381 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3382 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3383 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3384 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3385 integers are now checked earlier. All uses replaced with XINT.
3386 (ccl_driver):
3387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3388 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3389 (ccl_driver, Fregister_code_conversion_map):
3390 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3391 (resolve_symbol_ccl_program): Check that vector header is in range.
3392 Always copy the vector, so that we can check its contents reliably
3393 now rather than having to recheck each instruction as it's being
3394 executed. Check that vector words fit in 'int'.
3395 (ccl_get_compiled_code, Fregister_ccl_program)
3396 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3397 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3398 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3399 contents are in range.
3400 (Fccl_execute_on_string): Check that status is in range.
3401 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3402 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3403 Accept and return EMACS_INT, not int, because callers can pass values
3404 out of 'int' range.
3405 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3406 (multibyte_chars_in_text, parse_str_as_multibyte)
3407 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3408 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3409 (string_escape_byte8, Fget_byte):
3410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3411 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3412 avoid mishandling large integers.
3413 * character.h: Adjust decls to match defn changes elsewhere.
3414 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3415 (Ffind_charset_region):
3416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3417 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3418 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3419 Don't assume fixnum fits in int.
d311d28c
PE
3420 (load_charset_map_from_vector, Fmap_charset_chars):
3421 Remove now-unnecessary CHECK_NATNUMs.
3422 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3423 Don't rely on undefined behavior with signed left shift overflow.
3424 Don't assume unsigned int fits into fixnum, or that fixnum fits
3425 into unsigned int. Don't require max_code to be a valid fixnum;
3426 that's not true for gb10830 4-byte on a 32-bit host. Allow
3427 invalid_code to be a cons, for the same reason. Require code_offset
3428 to be a character. Avoid int overflow if max_char is close
3429 to INT_MAX.
3430 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3431 this is intended anyway and avoids some undefined behavior.
3432 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3433 INDEX_TO_CODE_POINT, as that's what it expects.
3434 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3435 * charset.h (DECODE_CHAR): Return int, not unsigned;
3436 this is what was intended anyway, and it avoids undefined behavior.
3437 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3438 integer-overflow issues.
3439 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3440 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3441 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3442 * chartab.c (Fmake_char_table, Fset_char_table_range)
3443 (uniprop_get_decoder, uniprop_get_encoder):
3444 Don't assume fixnum fits in int.
3445 * cmds.c (move_point): New function, that does the gist of
3446 Fforward_char and Fbackward_char, but does so while checking
3447 for integer overflow more accurately.
c96e5d6a 3448 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3449 (Fforward_line, Fend_of_line, internal_self_insert)
3450 (internal_self_insert):
3451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3452 Fix a FIXME, by checking for integer overflow when calculating
3453 target_clm and actual_clm.
3454 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3455 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3456 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3457 (coding_alloc_by_making_gap, alloc_destination)
3458 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3459 (encode_coding_utf_16, detect_coding_emacs_mule)
3460 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3461 (detect_coding_iso_2022, decode_coding_iso_2022)
3462 (encode_invocation_designation, encode_designation_at_bol)
3463 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3464 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3465 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3466 (encode_coding_ccl, encode_coding_raw_text)
3467 (detect_coding_charset, decode_coding_charset)
3468 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3469 (produce_composition, produce_charset, produce_annotation)
3470 (decode_coding, handle_composition_annotation)
3471 (handle_charset_annotation, consume_chars, decode_coding_gap)
3472 (decode_coding_object, encode_coding_object, detect_coding_system)
3473 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3474 (code_convert_region, code_convert_string)
8f50130c
PE
3475 (Fdefine_coding_system_internal)
3476 (coding_set_source, coding_set_destination):
d311d28c
PE
3477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3478 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3479 (Fdefine_coding_system_internal):
3480 Don't assume fixnums fit in int.
3481 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3482 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3483 (Funencodable_char_position, Fcheck_coding_systems_region)
3484 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3486 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3487 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3488 Don't access memory outside of the args array.
d311d28c 3489 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3490 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3491 result of ENCODE_CHAR.
d311d28c
PE
3492 * coding.h: Adjust decls to match defn changes elsewhere.
3493 (struct coding_system):
3494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3495 * composite.c (get_composition_id, find_composition)
3496 (run_composition_function, update_compositions)
3497 (compose_text, composition_gstring_put_cache)
3498 (composition_gstring_p, composition_gstring_width)
3499 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3500 (composition_compute_stop_pos, composition_reseat_it)
3501 (composition_update_it, struct position_record)
3502 (find_automatic_composition, composition_adjust_point)
3503 (Fcomposition_get_gstring, Ffind_composition_internal):
3504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3505 (update_compositions):
3506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3507 * composite.h: Adjust decls to match defn changes elsewhere.
3508 (struct composition):
3509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3510 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3511 Do not attempt to compute the address of the object just before a
3512 buffer; this is not portable.
3513 (Faref, Faset):
3514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3515 (Faset): Use int, not EMACS_INT, where int is wide enough.
3516 (Fstring_to_number): Don't assume fixnums fit in int.
3517 (Frem): Don't assume arg is nonnegative.
3518 * dbusbind.c (xd_append_arg): Check for integers out of range.
3519 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3520 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3521 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3522 (xd_get_connection_references): Return ptrdiff_t, not int.
3523 All uses changed.
3524 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3525 (xd_read_message_1):
3526 Use int, not unsigned, where the dbus API uses int.
3527 (Fdbus_message_internal): Don't overflow mtype.
3528 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3529 * dired.c (directory_files_internal, file_name_completion, scmp)
3530 (file_name_completion_stat):
3531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3532 (file_name_completion): Don't overflow matchcount.
3533 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3534 * dispextern.h: Adjust decls to match defn changes elsewhere.
3535 (struct text_pos, struct glyph, struct bidi_saved_info)
3536 (struct bidi_string_data, struct bidi_it, struct composition_it)
3537 (struct it):
3538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3539 (struct display_pos, struct composition_it, struct it):
3540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3541 * dispnew.c (increment_matrix_positions)
3542 (increment_row_positions, mode_line_string)
3543 (marginal_area_string):
3544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3545 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3547 (duration_to_sec_usec): New function, to check for overflow better.
3548 (Fsleep_for, sit_for): Use it.
3549 * doc.c (get_doc_string, store_function_docstring):
3550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3551 (get_doc_string, Fsnarf_documentation):
3552 Use int, not EMACS_INT, where int is wide enough.
3553 (get_doc_string):
3554 Use SAFE_ALLOCA, not alloca.
3555 Check for overflow when converting EMACS_INT to off_t.
3556 * doprnt.c (doprnt):
3557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3558 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3559 Don't assume uid_t fits into fixnum.
3560 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3561 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3562 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3563 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3564 (general_insert_function)
3565 (Finsert_char, make_buffer_string, make_buffer_string_both)
3566 (update_buffer_properties, Fbuffer_substring)
3567 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3568 (Fsubst_char_in_region, check_translation)
3569 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3570 (transpose_markers, Ftranspose_regions):
3571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3572 (clip_to_bounds): Move to lisp.h as an inline function).
3573 (Fconstrain_to_field): Don't assume integers are nonnegative.
3574 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3575 (Fsubst_char_in_region, Fsave_restriction):
3576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3577 (Femacs_pid): Don't assume pid_t fits into fixnum.
3578 (lo_time): Use int, not EMACS_INT, when int suffices.
3579 (lisp_time_argument): Check for usec out of range.
3580 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3581 (Fuser_login_name, Fuser_full_name): Signal an error
3582 if a uid argument is out of range, rather than relying on
3583 undefined behavior.
c8d5c857
PE
3584 (Fformat_time_string): Remove now-unnecessary check.
3585 lisp_time_argument checks for out-of-range usec now.
243e0530 3586 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3587 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3588 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3589 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3590 (init_cmdargs, Fdump_emacs):
3591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3592 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3593 the bottom (typically) 32 bits of the fixnum.
3594 * eval.c (specpdl_size, call_debugger):
3595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3596 (when_entered_debugger, Fbacktrace_debug):
3597 Don't assume fixnum can fit in int.
3598 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3599 the object just before a buffer; this is not portable.
3600 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3601 (grow_specpdl, unbind_to):
3602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3603 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3604 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3605 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3606 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3607 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3609 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3610 (a_write, e_write):
3611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3612 (Fcopy_file, non_regular_nbytes, read_non_regular)
3613 (Finsert_file_contents):
3614 Use int, not EMACS_INT, where int is wide enough.
3615 (READ_BUF_SIZE): Verify that it fits in int.
3616 (Finsert_file_contents): Check that counts are in proper range,
3617 rather than assuming fixnums fit into ptrdiff_t etc.
3618 Don't assume fixnums fit into int.
125b3835 3619 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3620 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3621 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3622 (string_char_to_byte, string_byte_to_char)
3623 (string_make_multibyte, string_to_multibyte)
3624 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3625 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3626 (substring_both, Fdelete, internal_equal, Ffillarray)
3627 (Fclear_string, mapcar1)
3628 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3629 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3630 (larger_vector, make_hash_table, maybe_resize_hash_table)
3631 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3632 (Fmaphash, secure_hash):
3633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3634 (concat): Check for string index and length overflow.
3635 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3636 (Frequire):
3637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3638 (larger_vector): New API (vec, incr_min, size_max) replaces old
3639 one (vec, new_size, init). This catches size overflow.
3640 INIT was removed because it was always Qnil.
3641 All callers changed.
3642 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3643 the upper bound on a hash table index size.
3644 (make_hash_table, maybe_resize_hash_table): Use it.
3645 (secure_hash): Computer start_byte and end_byte only after
3646 they're known to be in ptrdiff_t range.
3647 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3648 (Ffont_get_glyphs, Ffont_at):
3649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3650 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3651 (Flist_fonts, Fopen_font):
3652 Don't assume fixnum can fit in int.
3653 (check_gstring): Don't assume index can fit in int.
3654 (font_match_p): Check that fixnum is a character, not a nonnegative
3655 fixnum, since the later code needs to stuff it into an int.
3656 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3657 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3658 conversion overflow issues.
3659 (Fopen_font): Check for integer out of range.
3660 (Ffont_get_glyphs): Don't assume index can fit in int.
3661 * font.h: Adjust decls to match defn changes elsewhere.
3662 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3663 integer overflow.
3664 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3665 printmax_t, where ptrdiff_t is wide enough.
3666 (Finternal_char_font):
3667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3668 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3669 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3670 (Fset_frame_position, x_set_frame_parameters)
3671 (x_set_line_spacing, x_set_border_width)
3672 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3673 Check that fixnums are in proper range for system types.
3674 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3676 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3677 Use SAFE_ALLOCA_LISP, not alloca.
3678 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3679 intptr_t is wide enough.
3680 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3681 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3682 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3683 Check for fixnum out of range.
3684 * ftfont.c (ftfont_list): Don't assume index fits in int.
3685 Check that fixnums are in proper range for system types.
3686 (ftfont_shape_by_flt):
3687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3688 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3690 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3691 Check that fixnums are in proper range for system types.
3692 * gnutls.h: Adjust decls to match defn changes elsewhere.
3693 * gtkutil.c (xg_dialog_run):
3694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3695 (update_frame_tool_bar):
3696 Check that fixnums are in proper range for system types.
3697 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3698 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3699 * indent.c (last_known_column, last_known_column_point):
3700 (current_column_bol_cache):
3701 (skip_invisible, current_column, check_display_width):
3702 (check_display_width, scan_for_column, current_column_1)
3703 (Findent_to, Fcurrent_indentation, position_indentation)
3704 (indented_beyond_p, Fmove_to_column, compute_motion):
3705 (Fcompute_motion, Fvertical_motion):
3706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3707 (last_known_column_modified): Use EMACS_INT, not int.
3708 (check_display_width):
3709 (Fcompute_motion):
3710 Check that fixnums and floats are in proper range for system types.
3711 (compute_motion): Don't assume index or fixnum fits in int.
3712 (compute_motion, Fcompute_motion):
3713 Use int, not EMACS_INT, when it is wide enough.
3714 (vmotion): Omit local var start_hpos that is always 0; that way
3715 we don't need to worry about overflow in expressions involving it.
3716 * indent.h: Adjust decls to match defn changes elsewhere.
3717 (struct position):
3718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3719 Use int, not EMACS_INT, where int is wide enough.
3720 Remove unused members ovstring_chars_done and tab_offset;
3721 all uses removed.
3722 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3723 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3724 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3725 (make_gap, copy_text, insert, insert_and_inherit)
3726 (insert_before_markers, insert_before_markers_and_inherit)
3727 (insert_1, count_combining_before, count_combining_after)
3728 (insert_1_both, insert_from_string)
3729 (insert_from_string_before_markers, insert_from_string_1)
3730 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3731 (adjust_after_replace, adjust_after_insert, replace_range)
3732 (replace_range_2, del_range, del_range_1, del_range_byte)
3733 (del_range_both, del_range_2, modify_region)
3734 (prepare_to_modify_buffer, signal_before_change)
3735 (signal_after_change, Fcombine_after_change_execute):
3736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3737 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3738 (balance_an_interval, split_interval_right, split_interval_left)
3739 (find_interval, next_interval, update_interval)
3740 (adjust_intervals_for_insertion, delete_node, delete_interval)
3741 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3742 (static_offset_intervals, offset_intervals)
3743 (merge_interval_right, merge_interval_left, make_new_interval)
3744 (graft_intervals_into_buffer, temp_set_point_both)
3745 (temp_set_point, set_point, adjust_for_invis_intang)
3746 (set_point_both, move_if_not_intangible, get_property_and_range)
3747 (get_local_map, copy_intervals, copy_intervals_to_string)
3748 (compare_string_intervals, set_intervals_multibyte_1):
3749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3750 * intervals.h: Adjust decls to match defn changes elsewhere.
3751 (struct interval):
3752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3753 * keyboard.c (this_command_key_count, this_single_command_key_start)
3754 (before_command_key_count, before_command_echo_length, echo_now)
3755 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3756 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3757 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3758 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3760 (last_non_minibuf_size, last_point_position, echo_truncate)
3761 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3762 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3763 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3764 (stuff_buffered_input):
3765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3766 (last_auto_save, command_loop_1, read_char):
3767 Use EMACS_INT, not int, to avoid integer overflow.
3768 (record_char): Avoid overflow in total_keys computation.
3769 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3770 * keyboard.h: Adjust decls to match defn changes elsewhere.
3771 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3772 (Fkey_description, Fdescribe_vector, Flookup_key):
3773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3774 (click_position): New function, to check that positions are in range.
3775 (Fcurrent_active_maps):
3776 (describe_command):
3777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3778 (Faccessible_keymaps, Fkey_description):
3779 (preferred_sequence_p):
3780 Don't assume fixnum can fit into int.
3781 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3782 Check for integer overflow in size calculations.
3783 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3784 avoid mishandling large integers.
3785 * lisp.h: Adjust decls to match defn changes elsewhere.
3786 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3787 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3788 (struct Lisp_Marker):
3789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3790 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3791 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3792 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3793 All callers changed.
3794 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3795 Assume the arg has valid form, since it always does.
3796 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3797 unsigned integer system type.
3798 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3799 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3801 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3802 (duration_to_sec_usec): New decl.
3803 * lread.c (read_from_string_index, read_from_string_index_byte)
3804 (read_from_string_limit, readchar, unreadchar, openp)
3805 (read_internal_start, read1, oblookup):
3806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3807 (Fload, readevalloop, Feval_buffer, Feval_region):
3808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3809 (openp): Check for out-of-range argument to 'access'.
3810 (read1): Use int, not EMACS_INT, where int is wide enough.
3811 Don't assume fixnum fits into int.
6efdadfd 3812 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3813 (read_filtered_event): Use duration_to_sec_usec
3814 to do proper overflow checking on durations.
d311d28c
PE
3815 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3816 in size calculation.
3817 (Fexecute_kbd_macro):
3818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3819 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3820 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3821 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3822 (set_marker_both, set_marker_restricted_both, marker_position)
3823 (marker_byte_position, Fbuffer_has_markers_at):
3824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3825 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3826 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3827 It now merely ensures that the menu is large enough, without
3828 necessarily growing it, as this avoids some integer overflow issues.
3829 All callers changed.
3830 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3832 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3833 Use SAFE_ALLOCA_LISP, not alloca.
3834 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3835 to EMACS_INT. Check that fixnums are in proper range for system types.
3836 * minibuf.c (minibuf_prompt_width, string_to_object)
3837 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3838 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3840 (get_minibuffer, read_minibuf_unwind):
3841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3842 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3843 this simplifies overflow checking. All callers changed.
3844 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3845 (Ftest_completion):
3846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3847 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3848 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3849 Check that fixnums are in proper range for system types.
3850 (Fx_create_frame, Fx_show_tip):
3851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3852 * nsfont.m (ns_findfonts, nsfont_list_family):
3853 Don't assume fixnum fits in long.
3854 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3855 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3856 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3857 wide enough.
17fdb222 3858 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3860 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3861 (PRINTDECLARE, PRINTPREPARE):
3862 (strout, print_string):
3863 (print, print_preprocess, print_check_string_charset_prop)
3864 (print_object):
3865 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3866 (PRINTDECLARE):
3867 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3869 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3870 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3871 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3872 (print_error_message): Use SAFE_ALLOCA, not alloca.
3873 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3874 (print_depth, new_backquote_output, print_number_index):
3875 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3876 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3877 (Fset_process_window_size, Fformat_network_address)
3878 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3879 (sigchld_handler):
d311d28c 3880 Check that fixnums are in proper range for system types.
d44287d4 3881 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3882 Check for process-ids out of pid_t range rather than relying on
3883 undefined behavior.
e4d81efc 3884 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3885 (Fformat_network_address, read_process_output, send_process)
3886 (Fprocess_send_region, status_notify):
3887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3888 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3889 (wait_reading_process_output, read_process_output, exec_sentinel):
3890 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3891 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3892 (Faccept_process_output): Use duration_to_sec_usec to do proper
3893 overflow checking on durations.
dde14581
PE
3894 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3895 Don't assume pid_t fits in int.
02481186
PE
3896 * process.h (struct Lisp_Process): Members tick and update_tick
3897 are now of type EMACS_INT, not int.
b62b53e8
PE
3898 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3899 configured --with-wide-int.
d311d28c
PE
3900 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3901 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3902 * search.c (looking_at_1, string_match_1):
3903 (fast_string_match, fast_c_string_match_ignore_case)
3904 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3905 (scan_newline, find_before_next_newline, search_command)
3906 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3907 (set_search_regs, wordify):
3908 (Freplace_match):
3909 (Fmatch_data):
3910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3911 (string_match_1, search_buffer, set_search_regs):
3912 (Fmatch_data):
3913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3914 (wordify): Check for overflow in size calculation.
3915 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3916 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3917 Check that fixnums are in proper range for system types.
3918 * sound.c (struct sound_device)
3919 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3921 (Fplay_sound_internal):
3922 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3923 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3924 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3925 (Fparse_partial_sexp):
3926 Don't assume fixnums can fit in int.
3927 (struct lisp_parse_state, find_start_pos, find_start_value)
3928 (find_start_value_byte, find_start_begv)
3929 (update_syntax_table, char_quoted, dec_bytepos)
3930 (find_defun_start, prev_char_comend_first, back_comment):
3931 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3932 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3933 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3934 (Finternal_describe_syntax_value): Check that match_lisp is a
3935 character, not an integer, since the code stuffs it into int.
3936 (scan_words, scan_sexps_forward):
3937 Check that fixnums are in proper range for system types.
3938 (Fforward_word):
3939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3940 (scan_sexps_forward):
3941 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3942 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3943 * syntax.h: Adjust decls to match defn changes elsewhere.
3944 (struct gl_state_s):
3945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3946 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3947 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3948 * sysdep.c (wait_for_termination_1, wait_for_termination)
3949 (interruptible_wait_for_termination, mkdir):
3950 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3951 (emacs_read, emacs_write):
3952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3953 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3954 and double all fit in int.
d311d28c
PE
3955 * term.c (set_tty_color_mode):
3956 Check that fixnums are in proper range for system types.
3957 * termhooks.h (struct input_event):
3958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3959 * textprop.c (validate_interval_range, interval_of)
3960 (Fadd_text_properties, set_text_properties_1)
3961 (Fremove_text_properties, Fremove_list_of_text_properties)
3962 (Ftext_property_any, Ftext_property_not_all)
3963 (copy_text_properties, text_property_list, extend_property_ranges)
3964 (verify_interval_modification):
3965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3966 (Fnext_single_char_property_change)
3967 (Fprevious_single_char_property_change):
3968 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3969 (copy_text_properties):
3970 Check for integer overflow in index calculation.
d311d28c
PE
3971 * undo.c (last_boundary_position, record_point, record_insert)
3972 (record_delete, record_marker_adjustment, record_change)
3973 (record_property_change):
3974 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3975 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3977 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3978 (Fx_hide_tip, Fx_file_dialog):
3979 * w32menu.c (set_frame_menubar):
3980 Use ptrdiff_t, not int, for consistency with rest of code.
3981 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3982 (select_window, Fdelete_other_windows_internal)
3983 (window_scroll_pixel_based, window_scroll_line_based)
3984 (Frecenter, Fset_window_configuration):
3985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3986 (Fset_window_hscroll, run_window_configuration_change_hook)
3987 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3988 (Fscroll_other_window, Frecenter):
d311d28c
PE
3989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3990 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3991 Don't assume fixnum fits in int.
3992 (Fset_window_scroll_bars):
3993 Check that fixnums are in proper range for system types.
3994 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3995 (string_pos, c_string_pos, number_of_chars, init_iterator)
3996 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3997 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3998 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3999 (face_before_or_after_it_pos, handle_invisible_prop)
4000 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4001 (display_prop_intangible_p, string_buffer_position_lim)
4002 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4003 (get_overlay_strings_1, get_overlay_strings)
4004 (iterate_out_of_display_property, forward_to_next_line_start)
4005 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4006 (get_next_display_element, set_iterator_to_next)
4007 (get_visually_first_element, compute_stop_pos_backwards)
4008 (handle_stop_backwards, next_element_from_buffer)
4009 (move_it_in_display_line_to, move_it_in_display_line)
4010 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4011 (add_to_log, message_dolog, message_log_check_duplicate)
4012 (message2, message2_nolog, message3, message3_nolog
4013 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4014 (current_message_1, truncate_echo_area, truncate_message_1)
4015 (set_message, set_message_1, store_mode_line_noprop)
4016 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4017 (text_outside_line_unchanged_p, check_point_in_composition)
4018 (reconsider_clip_changes)
4019 (redisplay_internal, set_cursor_from_row, try_scrolling)
4020 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4021 (redisplay_window, find_last_unchanged_at_beg_row)
4022 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4023 (trailing_whitespace_p, find_row_edges, display_line)
4024 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4025 (display_mode_element, store_mode_line_string)
4026 (pint2str, pint2hrstr, decode_mode_spec)
4027 (display_count_lines, display_string, draw_glyphs)
4028 (x_produce_glyphs, x_insert_glyphs)
4029 (rows_from_pos_range, mouse_face_from_buffer_pos)
4030 (fast_find_string_pos, mouse_face_from_string_pos)
4031 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4033 (safe_call, init_from_display_pos, handle_fontified_prop)
4034 (handle_single_display_spec, load_overlay_strings)
4035 (with_echo_area_buffer, setup_echo_area_for_printing)
4036 (display_echo_area, echo_area_display)
4037 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4038 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4039 (redisplay_window, dump_glyph_row, display_mode_line)
4040 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4041 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4043 (handle_single_display_spec, build_desired_tool_bar_string)
4044 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4045 (get_specified_cursor_type):
4046 Check that fixnums are in proper range for system types.
4047 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4048 (Flookup_image_map):
4049 Don't assume fixnums fit in int.
4050 (compare_overlay_entries):
4051 Avoid mishandling comparisons due to subtraction overflow.
4052 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4053 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4054 (handle_tool_bar_click):
4055 Use int, not unsigned, since we prefer signed and the signedness
4056 doesn't matter here.
4057 (get_next_display_element, next_element_from_display_vector):
4058 Use int, not EMACS_INT, when int is wide enough.
4059 (start_hourglass): Use duration_to_sec_usec to do proper
4060 overflow checking on durations.
4061 * xfaces.c (Fbitmap_spec_p):
4062 Check that fixnums are in proper range for system types.
4063 (compare_fonts_by_sort_order):
4064 Avoid mishandling comparisons due to subtraction overflow.
4065 (Fx_family_fonts, realize_basic_faces):
4066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4067 (Fx_family_fonts):
4068 Don't assume fixnum fits in int.
4069 Use SAFE_ALLOCA_LISP, not alloca.
4070 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4071 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4072 (face_at_buffer_position, face_for_overlay_string)
4073 (face_at_string_position):
4074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4075 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4076 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4077 (Fx_show_tip):
4078 Check that fixnums are in proper range for system types.
4079 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4080 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4082 (Fx_change_window_property): Don't assume fixnums fit in int.
4083 * xfont.c (xfont_chars_supported):
4084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4085 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4086 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4088 * xml.c (parse_region):
4089 * xrdb.c (magic_file_p):
4090 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4091 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4092 (x_get_local_selection, x_reply_selection_request)
4093 (x_handle_selection_request, wait_for_property_change):
4094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4095 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4096 short is wide enough.
4097 (x_send_client_event): Don't assume fixnum fits in int.
4098 * xterm.c (x_x_to_emacs_modifiers):
4099 Don't assume EMACS_INT overflows nicely into int.
4100 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4101 may come from Lisp.
4102 (handle_one_xevent): NATNUMP can eval its arg twice.
4103 (x_connection_closed):
4104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4105 * xterm.h: Adjust decls to match defn changes elsewhere.
4106 (struct scroll_bar): Use struct vectorlike_header
4107 rather than rolling our own approximation.
4108 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4109
c6574eb5
GM
41102012-05-25 Glenn Morris <rgm@gnu.org>
4111
4112 * lisp.mk (lisp): Update for more files being compiled now.
4113
e8d32c7e
SM
41142012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4115
48def666
SM
4116 * lread.c: Remove `read_pure' which makes no difference.
4117 (read_pure): Remove var.
4118 (unreadpure): Remove function.
4119 (readevalloop): Don't call read_list with -1 flag.
4120 (read1, read_vector): Don't test read_pure any more.
4121 (read_list): Simplify.
4122
e8d32c7e
SM
4123 * fileio.c, character.h: Minor style tweaks.
4124
4b2addb7
DA
41252012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4126
4127 * window.h (clip_changed): Remove useless declaration.
4128
584461b2
JB
41292012-05-22 Juanma Barranquero <lekktu@gmail.com>
4130
4131 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4132 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4133
34374650
PE
41342012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4135
4136 Remove src/m/*.
4137 This directory predates autoconf and is no longer needed nowadays.
4138 Move its few remaining bits of functionality to where they're needed.
4139 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4140 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4141 * m/template.h: Remove.
4142 * Makefile.in (M_FILE): Remove. All uses removed.
4143 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4144 * lisp.h (USE_LSB_TAG):
4145 * mem-limits.h (EXCEEDS_LISP_PTR):
4146 Use VAL_MAX, not VALBITS, in #if.
4147 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4148 (EMACS_UINT): Define unconditionally now.
4149 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4150 (BITS_PER_EMACS_INT): New constants, replacing
4151 what used to be in config.h, but not useful in #if.
4152 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4153 define them any more.
4154 (VAL_MAX): New macro.
4155 (VALMASK): Use it.
4156 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4157 BITS_PER_EMACS_INT, in #if.
4158 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4159 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4160 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4161 * s/ms-w32.h (DATA_START):
4162 Move here from removed file m/intel386.h.
4163 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4164 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4165
261cb4bb
PE
41662012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4167
4168 Assume C89 or later.
4169 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4170 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4171 (xrealloc):
4172 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4173 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4174 * textprop.c, tparam.c (NULL): Remove.
4175 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4176 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4177 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4178 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4179 * xterm.c (input_signal_count): Assume volatile works.
4180
ff23cd9f
KB
41812012-05-21 Ken Brown <kbrown@cornell.edu>
4182
4183 * xgselect.c (xg_select): Fix first argument in call to 'select'
4184 (bug#11508).
4185
1b170bc6
KB
41862012-05-20 Ken Brown <kbrown@cornell.edu>
4187
4188 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4189 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4190
b2f4d39f
KB
41912012-05-19 Ken Brown <kbrown@cornell.edu>
4192
4193 * xfns.c (x_in_use): Remove `static' qualifier.
4194 * xterm.h (x_in_use): Declare.
4195 * xgselect.c: Include xterm.h.
4196 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4197 and `display_arg' (bug#9754).
4198
003fdae2
PE
41992012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4200
9232a6d9
PE
4201 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4202
003fdae2
PE
4203 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4204 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4205
784b56e2
EZ
42062012-05-18 Eli Zaretskii <eliz@gnu.org>
4207
4208 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4209
4210 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4211 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4212
4213 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4214 reference to image_cache->refcount.
4215 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4216
a0a79cde
JL
42172012-05-17 Juri Linkov <juri@jurta.org>
4218
4219 * search.c (Fword_search_regexp, Fword_search_backward)
4220 (Fword_search_forward, Fword_search_backward_lax)
4221 (Fword_search_forward_lax): Move functions to isearch.el
4222 (bug#10145, bug#11381).
4223
b0572523
PE
42242012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4225
4226 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4227
9660f5fc
SM
42282012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4229
4230 * lread.c (init_obarray): Declare Qt and Qnil as special.
4231
4374de83
GM
42322012-05-14 Glenn Morris <rgm@gnu.org>
4233
4234 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4235 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4236
dc44c39a
PE
42372012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4238
078c97cb
PE
4239 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4240
dc44c39a
PE
4241 * unexaix.c: Port to more-recent AIX compilers.
4242 (report_error, report_error_1, make_hdr, copy_sym)
4243 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4244 Make arguments const char *, not char *, to avoid violations of C
4245 standard and to fix some AIX warnings reported by Gilles Pion.
4246
e18afed7 42472012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4248
4249 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4250 already have overlays loaded.
4251 (handle_single_display_spec): Before returning without displaying
4252 fringe bitmap, synchronize the bidi iterator with the main display
4253 iterator, by calling iterate_out_of_display_property.
4254 (iterate_out_of_display_property): Detect buffer iteration by
4255 testing that it->string is a Lisp string.
4256 (get_next_display_element): When the current object is exhausted,
4257 and there's something on it->stack, call set_iterator_to_next to
4258 proceed with what's on the stack, instead of returning zero.
4259 (set_iterator_to_next): If called at the end of a Lisp string,
4260 proceed to consider_string_end without incrementing string
4261 position. Don't increment display vector index past the end of
4262 the display vector. (Bug#11417)
c8fb9dc6
EZ
4263 (pos_visible_p): Don't report a position visible when move_it_to
4264 stopped at the last line of window, which happens to be scanned
4265 backwards by the bidi iteration. (Bug#11464)
ac268e67 4266
e18afed7 42672012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4268
4269 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4270 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4271 are on a TTY, and thus unable to display on the fringes.
4272 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4273 so we need to signal to the caller that this is a "replacing"
4274 display spec. This fixes display when the spec is invalid or we
4275 are on a TTY.
4276
e18afed7 42772012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4278
4279 * unexaix.c (make_hdr): Fix typo in prototype.
4280 This bug broke the build on AIX. Problem reported by Gilles Pion.
4281
9d0a235a
MA
42822012-05-14 Michael Albinus <michael.albinus@gmx.de>
4283
4284 * keyboard.c (kbd_buffer_get_event): Read special events also in
4285 batch mode. (Bug#11415)
4286
9e6b06ed
GM
42872012-05-12 Glenn Morris <rgm@gnu.org>
4288
4289 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4290
c1a1d7a3
EZ
42912012-05-12 Eli Zaretskii <eliz@gnu.org>
4292
4293 * lisp.mk (lisp): Add newcomment.elc.
4294
3fe7cdc8
GM
42952012-05-12 Glenn Morris <rgm@gnu.org>
4296
4297 * Makefile.in (MKDIR_P): New, set by configure.
4298 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4299
53f7d2c0
PE
43002012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4301
4302 Remove unused function hourglass_started.
4303 * dispextern.h (hourglass_started):
4304 * w32fns.c (hourglass_started):
4305 * xdisp.c (hourglass_started): Remove.
4306
75aafb17
JB
43072012-05-10 Juanma Barranquero <lekktu@gmail.com>
4308
4309 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4310 Update dependencies.
4311
12959e8e
PE
43122012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4313
97107e2e
PE
4314 * xgselect.c (xg_select): Put maxfds+1 into a var.
4315 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4316
12959e8e
PE
4317 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4318
836d29b3
DA
43192012-05-10 Dave Abrahams <dave@boostpro.com>
4320
4321 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4322 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4323
5cb67954
MA
43242012-05-09 Michael Albinus <michael.albinus@gmx.de>
4325
4326 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4327 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4328 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4329 Initialize xd_registered_buses.
4330
3478ec45
PE
43312012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4332
b263a6b0
PE
4333 Untag more efficiently if USE_LSB_TAG.
4334 This is based on a proposal by YAMAMOTO Mitsuharu in
4335 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4336 For an admittedly artificial (nth 8000 longlist) benchmark on
4337 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4338 Emacs's overall text size by 1%.
4339 * lisp.h (XUNTAG): New macro.
4340 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4341 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4342 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4343 * eval.c (Fautoload):
4344 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4345 * frame.h (XFRAME): Use XUNTAG.
4346
3478ec45
PE
4347 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4348 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4349 Remove unportable assumptions about print widths of types like
4350 dbus_uint32_t.
4351 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4352 intptr_t when converting between pointer and integer, to avoid GCC
4353 warnings about wrong width.
4354
666b903b 43552012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4356
4357 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4358 stack for each reader_thread, instead of defaulting to 8MB
4359 determined by the linker. This avoids failures in creating
4360 subprocesses on Windows 7, see the discussion in this thread:
4361 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4362
b120cc17
JC
43632012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4364
4365 Fix up display of the *Minibuf-0* buffer in the mini window.
4366 * keyboard.c (read_char): Don't clear the echo area if there's no
4367 message to clear.
4368 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4369 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4370
9a4b36f8
MA
43712012-05-07 Michael Albinus <michael.albinus@gmx.de>
4372
4373 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4374 batch mode.
4375
e5f9458f
CY
43762012-05-06 Chong Yidong <cyd@gnu.org>
4377
4378 * lisp.mk (lisp): Update.
4379
eceeb5fc 43802012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4381
4382 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4383
71873e2b
SM
43842012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4385
4386 * data.c (PUT_ERROR): New macro.
4387 (syms_of_data): Use it. Add new error type `user-error'.
4388 * undo.c (user_error): New function.
4389 (Fprimitive_undo): Use it.
4390 * print.c (print_error_message): Adjust print style for `user-error'.
4391 * keyboard.c (user_error): New function.
4392 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4393
ab0fa4e4
PE
43942012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4395
4396 Do not limit current-time-string to years 1000..9999.
4397 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4398 (Fcurrent_time_string): Support any year that is supported by the
4399 underlying localtime representation. Don't use asctime, as it
4400 has undefined behavior for years outside the range -999..9999.
4401
7ed806a7
PE
44022012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4403
4404 Fix race conditions involving setenv, gmtime, localtime, asctime.
4405 Without this fix, interrupts could mess up code that uses these
4406 nonreentrant functions, since setting TZ invalidates existing
4407 tm_zone or tzname values, and since most of these functions return
4408 pointers to static storage.
4409 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4410 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4411 Grow the critical sections to include not just invoking
4412 localtime/gmtime, but also accessing these functions' results
4413 including their tm_zone values if any, and any related TZ setting.
4414 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4415 so that the struct tm is saved in the critical section.
4416 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4417 motivated by the fact that memory allocation needs to be outside
4418 the critical section.
4419
0c16dfed
DA
44202012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4421
4422 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4423 with RESET_INTERVAL.
4424
4425 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4426 Remove duplicated buffer name initialization.
4427
3f83ace8
JM
44282012-05-02 Jim Meyering <jim@meyering.net>
4429
4430 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4431
c7b8541e
JM
4432 * xfns.c (x_window): Use xstrdup (Bug#11375).
4433
90207a15 44342012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4435
4436 * xdisp.c (pos_visible_p): If already at a newline from the
4437 display string before the 'while' loop, don't walk back the glyphs
4438 from it3.glyph_row. Solves assertion violation when the display
4439 string begins with a newline (egg.el). (Bug#11367)
4440
b593d6a9
AH
44412012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4442
4443 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4444 Move to simple.el.
4445
4737362e
GM
44462012-05-01 Glenn Morris <rgm@gnu.org>
4447
99cf43f9
GM
4448 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4449 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4450 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4451 All were removed before 23.1.
4452
9311dcff
GM
4453 * dispnew.c: Remove HAVE_LIBNCURSES test;
4454 it is always true on relevant platforms.
4455
4d5c6349
GM
4456 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4457 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4458
4737362e
GM
4459 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4460
74dd3a6b
AS
44612012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4462
4463 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4464 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4465 Remove.
4466
13c379ee
PE
44672012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4468
4469 Do not avoid creating empty evaporating overlays (Bug#9642).
4470 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4471 That is, do not delete an evaporating overlay if it becomes
4472 empty after its bounds are adjusted to fit within its buffer.
4473 This fix caused other problems, and I'm reverting it until we get
4474 to the bottom of them.
4475
a8e7d6d7 44762012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4477
4478 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4479
a8e7d6d7 44802012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4481
4482 * xdisp.c (pos_visible_p): If the window start position is beyond
4483 ZV, start the display from buffer beginning. Prevents assertion
4484 violation in init_iterator when the minibuffer window is scrolled
4485 via the scroll bar.
4486
4487 * window.c (window_scroll_pixel_based): Likewise.
4488
a8e7d6d7 44892012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4490
4491 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4492
a8e7d6d7 44932012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4494
4495 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4496 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4497
a8e7d6d7 44982012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4499
b593d6a9
AH
4500 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4501 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4502
1c6900d9
EZ
45032012-04-26 Eli Zaretskii <eliz@gnu.org>
4504
4c3fa1d9
EZ
4505 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4506 display element, check also the underlying string or buffer
4507 character. (Bug#11341)
4508
1c6900d9
EZ
4509 * w32menu.c: Include w32heap.h.
4510 (add_menu_item): If the call to AppendMenuW (via
4511 unicode_append_menu) fails, disable Unicode menus only if we are
4512 running on Windows 9X/Me.
4513
42bf8205
AS
45142012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4515
4516 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4517 (xgetint): Add missing shift for LSB tags.
4518
b1bac16e
MR
45192012-04-24 Martin Rudalics <rudalics@gmx.at>
4520
4521 * keyboard.c (read_char): Don't wipe echo area for select window
4522 events: These might get delayed via `mouse-autoselect-window'
4523 (Bug#11304).
4524
d69621cc
JB
45252012-04-24 Juanma Barranquero <lekktu@gmail.com>
4526
4527 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4528 manipulation of :loaded-from data.
4529
02fd101b
JB
45302012-04-23 Juanma Barranquero <lekktu@gmail.com>
4531
4532 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4533 now a cons (bug#11311).
4534
888bec30
PE
45352012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4536
89a438bd
PE
4537 Do not create empty overlays with the evaporate property (Bug#9642).
4538 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4539 if it becomes empty after its bounds are adjusted to fit within
4540 its buffer. Without this fix, in a nonempty buffer (let ((o
4541 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4542 yields an empty overlay that has the evaporate property, which is
4543 not supposed to happen.
4544
1068fe4d
PE
4545 Fix minor GTK3 problems found by static checking.
4546 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4547 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4548 (struct _EmacsFixedClass, emacs_fixed_get_type):
4549 Move decls here from emacsgtkfixed.h, since they needn't be public.
4550 (emacs_fixed_get_type): Now static.
4551 (emacs_fixed_class_init): Omit unused local.
4552 (emacs_fixed_child_type): Remove; unused.
4553 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4554 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4555 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4556 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4557 (EMACS_FIXED_GET_CLASS): Remove; unused.
4558 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4559
888bec30
PE
4560 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4561 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4562
de85e130
PE
45632012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4564
d0baac98 4565 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4566 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4567 (__malloc_size_t, __malloc_ptrdiff_t):
4568 Remove. All uses removed, replaced by the definiens if needed,
4569 since we can assume C89 or better now.
4570 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4571 (protect_malloc_state, align, get_contiguous_space)
4572 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4573 (malloc_atfork_handler_child, malloc_enable_thread)
4574 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4575 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4576 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4577 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4578 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4579 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4580 Define using prototypes, not old style.
4581 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4582 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4583 (align): Don't assume that signed integer overflow wraps around.
4584 Omit unused local var.
4585 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4586 (_free_internal_nolock, memalign, mallochook, reallochook):
4587 Omit no-longer-needed casts.
4588 (valloc): Use getpagesize, not __getpagesize.
4589 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4590 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4591
de85e130
PE
4592 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4593
dcbf5805
MA
45942012-04-22 Michael Albinus <michael.albinus@gmx.de>
4595
4596 Move functions from C to Lisp. Make non-blocking method calls
4597 the default. Implement further D-Bus standard interfaces.
4598
4599 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4600 (QCdbus_request_name_allow_replacement)
4601 (QCdbus_request_name_replace_existing)
4602 (QCdbus_request_name_do_not_queue)
4603 (QCdbus_request_name_reply_primary_owner)
4604 (QCdbus_request_name_reply_in_queue)
4605 (QCdbus_request_name_reply_exists)
4606 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4607 (QCdbus_registered_serial, QCdbus_registered_method)
4608 (QCdbus_registered_signal): New Lisp objects.
4609 (XD_DEBUG_MESSAGE): Use sizeof.
4610 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4611 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4612 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4613 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4614 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4615 (xd_signature, xd_append_arg): Allow float for integer types.
4616 (xd_get_connection_references): New function.
b593d6a9
AH
4617 (xd_get_connection_address): Rename from xd_initialize.
4618 Return cached address.
dcbf5805
MA
4619 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4620 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4621 level.
4622 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4623 Return number of refcounts.
dcbf5805
MA
4624 (Fdbus_get_unique_name): Make stronger parameter check.
4625 (Fdbus_message_internal): New defun.
4626 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4627 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4628 (Fdbus_send_signal, Fdbus_register_service)
4629 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4630 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4631 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4632 (Vdbus_compiled_version, Vdbus_runtime_version)
4633 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4634 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4635 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4636 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4637 Adapt docstring.
dcbf5805 4638
52828e02
PE
46392012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4640
da05bc4c
PE
4641 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4642 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4643 Do not assume ptrdiff_t is the same width as 'int'.
4644
52828e02
PE
4645 * alloc.c: Handle unusual debugging option combinations.
4646 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4647 since the two debugging options are incompatible.
4648 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4649 is defined.
4650 (mem_init, mem_insert, mem_insert_fixup):
4651 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4652 (NEED_MEM_INSERT): Remove; no longer needed.
4653
f01769f9
LL
46542012-04-22 Leo Liu <sdl.web@gmail.com>
4655
4656 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4657
5790543d
PE
46582012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4659
4660 * sysdep.c [__FreeBSD__]: Minor cleanups.
4661 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4662 Use Emacs indenting style more consistently. Avoid some casts.
4663 Use 'double' consistently rather than mixing 'float' and 'double'.
4664
b91b7e4d
EW
46652012-04-21 Eduard Wiebe <usenet@pusto.de>
4666
b593d6a9
AH
4667 * sysdep.c (list_system_processes, system_process_attributes):
4668 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4669
6114eb15
AS
46702012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4671
4672 * lisp.mk (lisp): Update.
4673
2f38dff7
PE
46742012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4675
4676 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4677 It is never used otherwise.
4678
4ae29f89
SM
46792012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4680
4681 * print.c (print_preprocess): Only check print_depth if print-circle
4682 is nil.
4683 (print_object): Check for cycles even when print-circle is nil and
4684 print-gensym is t, but only check print_depth if print-circle is nil.
4685
f30d612a
CY
46862012-04-20 Chong Yidong <cyd@gnu.org>
4687
4688 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4689 set the status to "failed" and ensure that sentinel is run.
4690
c07a4c0b 46912012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4692
4693 * process.c (Fset_process_inherit_coding_system_flag)
4694 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4695 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4696
c07a4c0b 46972012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4698
4699 * xdisp.c (string_buffer_position_lim): Limit starting position to
4700 BEGV.
4701 (set_cursor_from_row): If called for a mode-line or header-line
4702 row, return zero immediately.
4703 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4704 farther than the first row after the header line, if any.
4705 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4706 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4707
c07a4c0b 47082012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4709
4ae29f89
SM
4710 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4711 (bug#11238).
ad3a2b41 4712
c07a4c0b 47132012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 47142012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4715
4716 configure: new option --enable-gcc-warnings (Bug#11207)
4717 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4718 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4719 (ALL_CFLAGS): Use new macros rather than old.
4720 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4721 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4722 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4723 -Wunused-result, -Wunused-variable. This should go away once
4724 the Emacs and Gnulib regex code is merged.
4725 (xmalloc, xrealloc): Now static.
4726
aba027e8
PE
47272012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4728
4729 * dired.c (Fsystem_groups): Remove unused local.
4730
e5a36063
GM
47312012-04-17 Glenn Morris <rgm@gnu.org>
4732
4733 * dired.c (Fsystem_users): Doc fix.
4734
316411f0
DA
47352012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4736
4737 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4738 (syms_of_dired): Add them.
4739
9426aba4
PE
47402012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4741
b62a57be
PE
4742 Fix minor alloc.c problems found by static checking.
4743 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4744 New extern decls, to avoid calling undeclared functions.
4745 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4746 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4747 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4748 (NEED_MEM_INSERT): New macro.
4749 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4750 Remove one incorrect comment and fix another.
b62a57be 4751
3539f31f
PE
4752 Fix minor ralloc.c problems found by static checking.
4753 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4754 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4755 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4756 (r_alloc_sbrk): Now static.
4757
a041960a
PE
4758 Improve ralloc.c interface checking.
4759 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4760 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4761 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4762 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4763 [REL_ALLOC]: ... to here, to check interface.
4764 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4765 Remove decls. This fixes an "It stinks!".
4766
9426aba4
PE
4767 * alloc.c (which_symbols): Fix alignment issue / type clash.
4768
d55c12ed
AS
47692012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4770
4771 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4772 (struct Lisp_Misc_Any): Likewise.
4773 (struct Lisp_Free): Likewise.
4774 * alloc.c (union aligned_Lisp_Symbol): Define.
4775 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4776 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4777 (union aligned_Lisp_Misc): Define.
4778 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4779 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4780 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4781
b948ce8b
PE
47822012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4783
4784 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4785 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4786 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4787 * s/netbsd.h, s/sol2-6.h:
4788 Remove definition of GC_MARK_STACK, since the default now works.
4789 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4790 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4791 no longer the default.
4792 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4793
35dc09a1 47942012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4795
35dc09a1
GM
4796 * lread.c (lisp_file_lexically_bound_p):
4797 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4798
35dc09a1
GM
47992012-04-14 Eli Zaretskii <eliz@gnu.org>
4800
4801 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4802 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4803
48042012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4805
4806 * nsterm.m (constrainFrameRect): Always constrain when there is only
4807 one screen (Bug#10962).
4808
bcd86815
KB
48092012-04-13 Ken Brown <kbrown@cornell.edu>
4810
4811 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4812
c25df26e
RT
48132012-04-13 Reuben Thomas <rrt@sc3d.org>
4814
4815 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4816
0fc59f1e
DC
48172012-04-11 Daniel Colascione <dancol@dancol.org>
4818
4819 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4820 against is gone. It's better to use vfork now so that when Cygwin
4821 gains a new, working vfork, we use it automatically (bug#10398).
4822
de8c03dc
SM
48232012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4824
4825 * window.c (save_window_save): Obey window-point-insertion-type.
4826
2f097256
GM
48272012-04-11 Glenn Morris <rgm@gnu.org>
4828
4829 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4830
453b951e
SM
48312012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4832
4833 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4834
75f1671a 48352012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4836
4837 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4838 (force_quit_count): New var.
4839 (handle_interrupt): Use it.
4840
2a8ce227
JB
48412012-04-10 Juanma Barranquero <lekktu@gmail.com>
4842
4843 * w32.c (w32_delayed_load): Record the full path of the library
4844 being loaded (bug#10424).
4845
935396c0
GM
48462012-04-09 Glenn Morris <rgm@gnu.org>
4847
05920a43
GM
4848 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4849 not just in the obarray, before snarfing them. (Bug#11036)
4850
935396c0
GM
4851 * Makefile.in ($(leimdir)/leim-list.el):
4852 Pass EMACS rather than BUILT_EMACS.
4853
a18ecafa
TZ
48542012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4855
4856 * process.c (make_process):
4857 * process.h: Add integer `gnutls_handshakes_tried' member to
4858 process struct.
4859
6bbef4e5
JC
4860 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4861 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4862
4863 * gnutls.c (gnutls_log_function2i): Convenience log function.
4864 (emacs_gnutls_read): Use new log functions,
4865 `gnutls_handshakes_tried' process member, and
4866 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4867 attempts per process (connection).
4868
b4d3bc10
CY
48692012-04-09 Chong Yidong <cyd@gnu.org>
4870
4871 * eval.c (Fuser_variable_p, user_variable_p_eh)
4872 (lisp_indirect_variable): Functions deleted.
4873 (Fdefvar): Caller changed.
4874
4875 * callint.c (Finteractive, Fcall_interactively):
4876 * minibuf.c (Fread_variable): Callers changed.
4877
70f4d973
EZ
48782012-04-09 Eli Zaretskii <eliz@gnu.org>
4879
4880 * xdisp.c (set_cursor_from_row): If the display string appears in
4881 the buffer at position that is closer to point than the position
4882 after the display string, display the cursor on the first glyph of
4883 the display string. Fixes cursor display when a 'display' text
4884 property immediately follows invisible text. (Bug#11094)
4885
cb3c2e3e
PE
48862012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4887
4888 composite.c: use 'double' consistently
4889 * composite.c (get_composition_id): Use 'double' consistently
4890 instead of converting 'float' to 'double' and vice versa; this is
4891 easier to understand and avoids a GCC warning.
4892
fd06db5d
GM
48932012-04-09 Glenn Morris <rgm@gnu.org>
4894
50fe702a
GM
4895 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4896 preparation for dumping it with emacs. (Bug#4789)
4897 (leimdir): New variable.
4898 ($(leimdir)/leim-list.el): New rule.
4899 (emacs$(EXEEXT)): Depend on leim-list.el.
4900
fd06db5d
GM
4901 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4902 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4903 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4904
55c131ee
AS
49052012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4906
4907 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4908 proper alignment.
4909
9209588f
JB
49102012-04-07 Juanma Barranquero <lekktu@gmail.com>
4911
4912 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4913 Remove unused local variable.
4914
e3fb2efb
PE
49152012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4916
4917 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4918 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4919 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4920 objects, as mark_maybe_pointer will catch them otherwise.
4921 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4922 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4923
b5385551
PE
49242012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4925
4926 Fix typo that broke non-Windows builds.
4927 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4928
9078ead6
EZ
49292012-04-07 Eli Zaretskii <eliz@gnu.org>
4930
4931 Support building on MS-Windows with libxml2.
4932
4933 * makefile.w32-in (OBJ2): Add xml.$(O).
4934 (GLOBAL_SOURCES): Add xml.c.
4935 ($(BLD)/xml.$(O)): New dependency list.
4936
4937 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4938 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4939 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4940 [!WINDOWSNT]: New macros.
4941 (init_libxml2_functions, libxml2_loaded_p): New functions.
4942 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4943 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4944 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4945 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4946 linked in).
6bbef4e5
JC
4947 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4948 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4949 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4950
4951 * emacs.c: Don't include libxml/parser.h.
4952 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4953 xmlCleanupParser directly.
4954
4955 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4956
3811fdf3
EZ
49572012-04-07 Eli Zaretskii <eliz@gnu.org>
4958
4959 * indent.c (Fvertical_motion): If there is a display string at
4960 point, use it.vpos to compute how many lines to backtrack after
4961 move_it_to point. (Bug#11133)
4962
2f8e16b2
EZ
49632012-04-06 Eli Zaretskii <eliz@gnu.org>
4964
4965 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4966 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4967 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4968 macros related to unification of CJK characters. For the details,
4969 see the discussion following the message here:
4970 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4971
3d439cd1
CY
49722012-04-04 Chong Yidong <cyd@gnu.org>
4973
4974 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4975
8bc53d00
EZ
49762012-04-01 Eli Zaretskii <eliz@gnu.org>
4977
4978 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4979 instead of alloca. (Bug#11138)
4980
3b0512a3
AS
49812012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4982
4983 * w32menu.c (is_simple_dialog): Properly check lisp types.
4984 (Bug#11141)
4985
8427ddd2
EZ
49862012-03-31 Eli Zaretskii <eliz@gnu.org>
4987
979022ef
EZ
4988 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4989 position we get to after a call to move_it_to fails the
4990 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4991 only if we wind up in a string from display property. (Bug#11063)
4992
a6b1c7cc
EZ
4993 * window.c (Fdelete_other_windows_internal): Invalidate the row
4994 and column information about mouse highlight, so that redisplay
4995 restores it after reallocating the glyph matrices. (Bug#7464)
4996
8427ddd2
EZ
4997 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4998 string comes from a `display' text property, use the buffer
4999 position of that property as if we actually saw that position in
5000 the row's glyphs.
697ba24b
EZ
5001 (move_it_by_lines): Remove the assertion that
5002 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5003 violated when there's a before-string at the beginning of a line.
5004 (Bug#11063)
8427ddd2 5005
65a0a738
EZ
50062012-03-30 Eli Zaretskii <eliz@gnu.org>
5007
5008 * xdisp.c (append_space_for_newline): If the default face was
5009 remapped, use the remapped face for the appended newline.
5010 (extend_face_to_end_of_line): Use the remapped default face for
5011 extending the face to the end of the line.
5012 (display_line): Call extend_face_to_end_of_line when the default
5013 face was remapped. (Bug#11068)
5014
581355cc
EZ
50152012-03-29 Eli Zaretskii <eliz@gnu.org>
5016
5017 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5018
e8fc049f
SM
50192012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5020
5021 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5022
4fb9a543
GM
50232012-03-27 Glenn Morris <rgm@gnu.org>
5024
5025 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5026 Doc fixes.
5027
679910f1
KH
50282012-03-26 Kenichi Handa <handa@m17n.org>
5029
5030 * dispextern.h (struct glyph): Fix previous change. Change the
5031 bit length of glyphless.ch to 25 (Bug#11082).
5032
90d49b7f
CY
50332012-03-26 Chong Yidong <cyd@gnu.org>
5034
5035 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5036 (command_loop_1): Use it; inhibit selection update for
5037 handle-select-window too (Bug#8996).
5038
f514f6f0
FP
50392012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5040
e8fc049f 5041 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5042
bf43fa51
KH
50432012-03-25 Kenichi Handa <handa@m17n.org>
5044
5045 * dispextern.h (struct glyph): Change the bit length of
5046 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5047
8a0c01dd
EZ
50482012-03-24 Eli Zaretskii <eliz@gnu.org>
5049
5050 * s/ms-w32.h (tzname): Include time.h before redirecting to
5051 _tzname. Fixes the MSVC build. (Bug#9960)
5052
7d1c3a76
AS
50532012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5054
8ed79523
AS
5055 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5056 characters.
5057
7d1c3a76
AS
5058 * xterm.c (XTread_socket): Only modify handling_signal if
5059 !SYNC_INPUT. (Bug#11080)
5060
e99a9b8b
EZ
50612012-03-23 Eli Zaretskii <eliz@gnu.org>
5062
5063 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5064 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5065 when fetching a multibyte character consumes more bytes than
5066 CHAR_BYTES returns, due to unification of CJK characters in
5067 string_char. (Bug#11073)
5068
5063c0e1
TN
50692012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5070
5071 * process.c (wait_reading_process_output): Handle pty disconnect
5072 by refraining from sending oneself a SIGCHLD (bug#10933).
5073
9f851fbd
CY
50742012-03-22 Chong Yidong <cyd@gnu.org>
5075
5076 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5077
5063c0e1 5078 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5079 Mark string as coming from a prefix property.
5080 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5081 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5082
fb5b8aca
CY
50832012-03-21 Chong Yidong <cyd@gnu.org>
5084
5085 * xfaces.c (Vface_remapping_alist): Doc fix.
5086
62356a1b
EZ
50872012-03-20 Eli Zaretskii <eliz@gnu.org>
5088
5089 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5090 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5091 Doc fixes.
62356a1b 5092
025de85b
CY
50932012-03-20 Chong Yidong <cyd@gnu.org>
5094
5095 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5096 to reflect default non-nil value of redisplay-dont-pause.
5097
4827f94e
KH
50982012-03-19 Kenichi Handa <handa@m17n.org>
5099
5100 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5101 it fit in a valid range (Bug#11003).
5102
e50a24a2
EZ
51032012-03-18 Eli Zaretskii <eliz@gnu.org>
5104
5105 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5106 that is not from display property, accept the row as a "cursor
5107 row" if one of the string's character has a non-nil `cursor'
5108 property. Fixes cursor positioning when there are newlines in
5109 overlay strings, e.g. in icomplete.el. (Bug#11035)
5110
9af5ed87
PE
51112012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5112
5113 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5114
d1f55f16
CY
51152012-03-12 Chong Yidong <cyd@gnu.org>
5116
5117 * eval.c (inhibit_lisp_code): Rename from
5118 inhibit_window_configuration_change_hook; move from window.c.
5119
5120 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5121 * window.c (run_window_configuration_change_hook)
5122 (syms_of_window): Callers changed.
5123
66c5eebd
CY
51242012-03-11 Chong Yidong <cyd@gnu.org>
5125
413df973
CY
5126 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5127
66c5eebd
CY
5128 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5129
1de11f56
CY
51302012-03-10 Chong Yidong <cyd@gnu.org>
5131
5132 * frame.c (other_visible_frames): Don't assume the selected frame
5133 is visible (Bug#10955).
5134
cae07000
SM
51352012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5136
5137 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5138
89c94350
JD
51392012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5140
5141 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5142 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5143 zero (Bug#10954).
5144
999dd333
GM
51452012-03-03 Glenn Morris <rgm@gnu.org>
5146
01a6dcc8 5147 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5148
de0100f2
EZ
51492012-03-02 Eli Zaretskii <eliz@gnu.org>
5150
5151 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5152 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5153 (redisplay_window, next_element_from_string): Fix typos in
5154 comments.
3e441275
EZ
5155 (redisplay_window): Pass to move_it_vertically the margin in
5156 pixels, not in screen lines.
de0100f2 5157
96a72ee9
GM
51582012-03-02 Glenn Morris <rgm@gnu.org>
5159
5160 * buffer.c (buffer-list-update-hook): Doc fix.
5161
312508d7
EZ
51622012-02-29 Eli Zaretskii <eliz@gnu.org>
5163
5164 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5165 push_it before setting up the iterator for the first overlay
5166 string, even if we have an empty string loaded.
5167 (next_overlay_string): If there's an empty string on the iterator
5168 stack, pop the stack. (Bug#10903)
5169
27f3c637
PE
51702012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5171
5172 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5173 Suggested by Stefan Monnier in
5174 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5175 * alloc.c (widen_to_Lisp_Object): New static function.
5176 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5177 and widening them to Lisp_Objects. This would work even if
5178 USE_LSB_TAG is defined and wide integers are used, which might
5179 happen in a future version of Emacs.
5180
3c9dfce6
CY
51812012-02-25 Chong Yidong <cyd@gnu.org>
5182
fa74b241
CY
5183 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5184 Doc fix.
5185
3c9dfce6
CY
5186 * xselect.c (Fx_selection_exists_p): Doc fix.
5187 (x_clipboard_manager_save_all): Print an informative message
5188 before saving to clipboard manager.
5189
9486df08
CY
51902012-02-24 Chong Yidong <cyd@gnu.org>
5191
5192 * keyboard.c (process_special_events): Handle all X selection
5193 requests in kbd_buffer, not just the next one (Bug#8869).
5194
f01d3321
CY
51952012-02-23 Chong Yidong <cyd@gnu.org>
5196
5197 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5198 call when setting menu-bar-lines and tool-bar-lines parameters.
5199 (unwind_create_frame_1): New helper function.
5200
5201 * window.c (inhibit_window_configuration_change_hook): New var.
5202 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5203 (syms_of_window): Initialize it.
f01d3321 5204
86b847b6
CY
52052012-02-22 Chong Yidong <cyd@gnu.org>
5206
5207 * xterm.c (x_draw_image_relief): Add missing type check for
5208 Vtool_bar_button_margin (Bug#10743).
5209
a59225b1
CY
52102012-02-21 Chong Yidong <cyd@gnu.org>
5211
5212 * fileio.c (Vfile_name_handler_alist): Doc fix.
5213
5214 * buffer.c (Fget_file_buffer): Protect against invalid file
5215 handler return value.
5216
310f5bd4
PE
52172012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5218
cb3a28cc
PE
5219 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5220 when computing $valmask.
5221
310f5bd4
PE
5222 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5223 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5224 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5225 It's useless in that case, and it can cause problems on hosts
5226 that allocate halves of EMACS_INT values separately.
5227 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5228 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5229 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5230 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5231 it avoids undefined behavior on hosts where shifting right by more
5232 than the word width has undefined behavior.
5233
2375c96a
CY
52342012-02-19 Chong Yidong <cyd@gnu.org>
5235
5236 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5237 (Funhandled_file_name_directory, Ffile_name_as_directory)
5238 (Fdirectory_file_name, Fexpand_file_name)
5239 (Fsubstitute_in_file_name): Protect against invalid file handler
5240 return values (Bug#10845).
5241
3eb49e71
EZ
52422012-02-18 Eli Zaretskii <eliz@gnu.org>
5243
5244 * .gdbinit (pitx): Fix incorrect references to fields of the
5245 iterator stack.
5246
7b926f3f
CY
52472012-02-17 Chong Yidong <cyd@gnu.org>
5248
5249 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5250
11273115
PE
52512012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5252
5253 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5254 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5255
c3a70e2b
CY
52562012-02-15 Chong Yidong <cyd@gnu.org>
5257
5258 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5259 marked as special. Also, starting docstrings with * is obsolete.
5260
0ca43699
AS
52612012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5262
5263 * gnutls.c (emacs_gnutls_write): Fix last change.
5264
2e8f3c56
LI
52652012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5266
5267 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5268 send_process.
5269
af70074f
SM
52702012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5271
5272 * keymap.c (Fsingle_key_description): Handle char ranges.
5273
95986d52
CY
52742012-02-12 Chong Yidong <cyd@gnu.org>
5275
afd83bd1
CY
5276 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5277 as that creates a dangerous corner case.
5278
95986d52
CY
5279 * window.c (Fdelete_window_internal): Invalidate the mouse
5280 highlight (Bug#9904).
5281
bd7da63e
GM
52822012-02-12 Glenn Morris <rgm@gnu.org>
5283
5284 * xselect.c (Fx_own_selection_internal)
5285 (Fx_get_selection_internal, Fx_disown_selection_internal)
5286 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5287 * nsselect.m (Fx_own_selection_internal)
5288 (Fx_disown_selection_internal, Fx_selection_exists_p)
5289 (Fx_selection_owner_p, Fx_get_selection_internal):
5290 Sync docs and argument specs with the xselect.c versions.
5291
77abcbc2
LI
52922012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5293
5294 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5295
90b671e2
EZ
52962012-02-11 Eli Zaretskii <eliz@gnu.org>
5297
1c0ca0b7
EZ
5298 * w32select.c (Fx_selection_exists_p): Sync doc string and
5299 argument list with xselect.c. (Bug#10783)
5300
5301 * w16select.c (Fx_selection_exists_p): Sync doc string and
5302 argument list with xselect.c. (Bug#10783)
90b671e2 5303
49241268
GM
53042012-02-10 Glenn Morris <rgm@gnu.org>
5305
5306 * fns.c (Fsecure_hash): Doc fix.
5307
f998bbe7 53082012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5309
5310 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5311
0992bd9c
CY
53122012-02-07 Chong Yidong <cyd@gnu.org>
5313
5314 * buffer.c (Fbuffer_local_variables)
5315 (buffer_lisp_local_variables): Handle unbound vars correctly;
5316 don't let Qunbound leak into Lisp.
5317
af008560
GM
53182012-02-07 Glenn Morris <rgm@gnu.org>
5319
dd605cc4
GM
5320 * image.c (Fimagemagick_types): Doc fix.
5321
af008560
GM
5322 * image.c (imagemagick-render-type): Change it from a lisp object
5323 to an integer. Move the doc here from the lisp manual.
5324 Treat all values not equal to 0 the same.
5325
1449fa1d
CY
53262012-02-06 Chong Yidong <cyd@gnu.org>
5327
5328 * doc.c (store_function_docstring): Avoid applying docstring of
5329 alias to base function (Bug#2603).
5330
3723ec07
AS
53312012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5332
5333 * .gdbinit (pp1, pv1): Remove redundant defines.
5334 (pr): Use pp.
5335
79c1cc1e
CY
53362012-02-04 Chong Yidong <cyd@gnu.org>
5337
5338 * nsterm.m: Declare a global (Bug#10694).
5339
d7f29f8e
EZ
53402012-02-04 Eli Zaretskii <eliz@gnu.org>
5341
cae07000
SM
5342 * w32.c (get_emacs_configuration_options):
5343 Include --enable-checking, if specified, in the return value.
d7f29f8e 5344
3b95a6f9
MR
53452012-02-04 Martin Rudalics <rudalics@gmx.at>
5346
5347 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5348 after rounding frame sizes. (Bug#9723)
5349
d6fa96a6
EZ
53502012-02-04 Eli Zaretskii <eliz@gnu.org>
5351
5352 * keyboard.c (adjust_point_for_property): Don't position point
5353 before BEGV. (Bug#10696)
5354
df0b2940
PE
53552012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5356
5357 Handle overflow when computing char display width (Bug#9496).
5358 * character.c (char_width): Return EMACS_INT, not int.
5359 (char_width, c_string_width): Check for overflow when
5360 computing the width; this is possible now that individual
5361 characters can have unbounded width. Problem introduced
5362 by merge from Emacs 23 on 2012-01-19.
5363
6bee44d6
MA
53642012-02-02 Michael Albinus <michael.albinus@gmx.de>
5365
5366 * dbusbind.c (Fdbus_register_method): Mention the return value
5367 :ignore in the docstring.
5368
44f92739
GM
53692012-02-02 Glenn Morris <rgm@gnu.org>
5370
1b9f60cc
GM
5371 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5372
44f92739
GM
5373 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5374 Unconditionally set to t. (Bug#10673)
5375 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5376 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5377 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5378
c5d3843c
KH
53792012-02-02 Kenichi Handa <handa@m17n.org>
5380
5381 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5382 0, do not call append_composite_glyph.
5383
159462d4 53842012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5385
5386 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5387 NULL (Bug#6988).
5388 (x_produce_glyphs): If the component of a composition is a null
5389 string, set it->pixel_width to 1 to avoid zero-width glyph.
5390
78cef877
EZ
53912012-02-01 Eli Zaretskii <eliz@gnu.org>
5392
5393 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5394 first 2 arguments are identical. This makes inserting large
5395 output from a subprocess an order of magnitude faster on
5396 MS-Windows, where all sbrk'ed memory is always contiguous.
5397
97897668
GM
53982012-01-31 Glenn Morris <rgm@gnu.org>
5399
5400 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5401 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5402 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5403
31fd3586
GM
54042012-01-29 Glenn Morris <rgm@gnu.org>
5405
5406 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5407
0e24a8b2
CY
54082012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5409
5410 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5411
cc0adcb0
CY
54122012-01-28 Chong Yidong <cyd@gnu.org>
5413
5414 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5415
acc28cb9
CY
54162012-01-26 Chong Yidong <cyd@gnu.org>
5417
9c69cfb7
CY
5418 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5419
acc28cb9
CY
5420 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5421 repeat counts (Bug#10507).
5422
48da7392
GM
54232012-01-26 Glenn Morris <rgm@gnu.org>
5424
5425 * lread.c (syms_of_lread): Doc fix.
5426
14af5f7f
CY
54272012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5428
5429 * coding.c (encode_designation_at_bol): Change return value to
5430 EMACS_INT.
5431
0b21c100
CY
54322012-01-25 Chong Yidong <cyd@gnu.org>
5433
5434 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5435
3c2907f7
CY
54362012-01-21 Chong Yidong <cyd@gnu.org>
5437
5438 * floatfns.c (Fcopysign): Make the second argument non-optional,
5439 since nil is not allowed anyway.
5440
959ad23f
AS
54412012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5442
5443 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5444 (send_process): Likewise.
5445
34a02f46
MR
54462012-01-19 Martin Rudalics <rudalics@gmx.at>
5447
5448 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5449 (Vwindow_persistent_parameters): Do not use Qstate.
5450 Rewrite doc-strings.
34a02f46 5451
1259009a 54522012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5453
5454 * character.c (char_width): New function.
70d4fdf6
GM
5455 (Fchar_width, c_string_width, lisp_string_width):
5456 Use char_width (Bug#9496).
25ed9e61 5457
6a6ee00d
MR
54582012-01-16 Martin Rudalics <rudalics@gmx.at>
5459
5460 * window.c (Vwindow_persistent_parameters): New variable.
5461 (Fset_window_configuration, save_window_save): Handle persistent
5462 window parameters.
5463
c85efaf7
EZ
54642012-01-14 Eli Zaretskii <eliz@gnu.org>
5465
5466 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5467 thrashing the stack of the thread. (Bug#9087)
5468
5944709e
PE
54692012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5470
5471 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5472
e71f5d99
EZ
54732012-01-11 Eli Zaretskii <eliz@gnu.org>
5474
5475 * xdisp.c (rows_from_pos_range): Handle the case where the
5476 highlight ends on a newline. (Bug#10464)
5477 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5478 he end column for display of highlight that ends on a newline
5479 before a R2L line.
5480
ce316182
GM
54812012-01-11 Glenn Morris <rgm@gnu.org>
5482
5483 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5484 from load-path also when installation-directory is nil. (Bug#10208)
5485
5b43da69
GM
54862012-01-10 Glenn Morris <rgm@gnu.org>
5487
74cc8ff9
GM
5488 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5489
7d8d6e4e
GM
5490 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5491 Update template values to be closer to their typical values these days.
5b43da69 5492
a0db8d43
EZ
54932012-01-09 Eli Zaretskii <eliz@gnu.org>
5494
5495 * xdisp.c (rows_from_pos_range): Accept additional argument
5496 DISP_STRING, and accept any glyph in a row whose object is that
5497 string as eligible for mouse highlight. Fixes mouse highlight of
5498 display strings from overlays. (Bug#10464)
5499
9a0115ab 55002012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5501
b9110d6a 5502 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5503 * fileio.c (auto_saving_dir_umask): New static var.
5504 (Fmake_directory_internal): Use it.
5505 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5506 creating the directory. The old code temporarily assigns
5507 too-generous permissions to the directory.
5508 (do_auto_save_eh): Clear it.
b9110d6a 5509 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5510 that the var is always cleared.
5511
6c1bd3f3
EZ
55122012-01-07 Eli Zaretskii <eliz@gnu.org>
5513
5514 * search.c (scan_buffer): Pass character positions to
5515 know_region_cache, not byte positions. (Bug#6540)
5516
069d2b50
L
55172012-01-07 LynX <_LynX@bk.ru> (tiny change)
5518
5519 * w32.c (sys_rename): Report EXDEV when rename of a directory
5520 fails because the target is on another logical disk. (Bug#10284)
5521
75bf0d33
DB
55222012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5523
5524 * xterm.c (x_embed_request_focus): New function.
5525
5526 * xterm.h: Add prototype.
5527
5528 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5529
1c6e5a32
GM
55302012-01-05 Glenn Morris <rgm@gnu.org>
5531
5532 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5533
651e947e
EZ
55342012-01-01 Eli Zaretskii <eliz@gnu.org>
5535
5536 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5537 Load gnutls_transport_set_lowat only if GnuTLS version is below
5538 2.11.1.
5539 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5540 GnuTLS versions below 2.11.1.
5541
3778cdd8
AL
55422011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5543
5544 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5545 to the doc string advising against its use for altering the way
5546 windows are scrolled.
5547
0e5317f7
KH
55482011-12-28 Kenichi Handa <handa@m17n.org>
5549
5550 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5551 coding-system ASCII compatible only when it does not produce BOM
5552 on encoding (Bug#10383).
5553
93d5ca1f
JD
55542011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5555
5556 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5557 can scroll.
5558 (create_and_show_popup_menu): Always use menu_position_func for
5559 Gtk3 (Bug#10361).
5560
ca22b785
AS
55612011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5562
5563 * callint.c (Fcall_interactively): Don't truncate prompt string.
5564
d048e1e6
EZ
55652011-12-23 Eli Zaretskii <eliz@gnu.org>
5566
5567 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5568 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5569 resumed from there (after widening). (Bug#10360)
d048e1e6 5570
5ccaba1f
JD
55712011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5572
5573 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5574
204ee57f
JD
55752011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5576
b81d40f0
JB
5577 * nsterm.m (x_free_frame_resources):
5578 Release f->output_data.ns->miniimage.
204ee57f
JD
5579 (ns_index_color): Fix indentation. Do not retain
5580 color_table->colors[i].
5581
5582 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5583 before returning.
5584
5585 * nsfns.m (x_set_background_color): Assign return value from
5586 ns_index_color to face-background instead of NSColor*.
5587 (ns_implicitly_set_icon_type): Fix indentation.
5588 Change assignment in for loop to comparison.
5589
5590 * emacs.c (ns_pool): New variable.
5591 (main): Assign ns_pool.
5592 (Fkill_emacs): Call ns_release_autorelease_pool.
5593
5594 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5595 autorelease fdesc, release fdAttrs and tdict.
5596 (ns_get_covering_families): Release charset.
5597 (ns_findfonts): Release NSFontDescriptor created with new.
5598 (ns_uni_to_glyphs): Fix indentation.
5599 (setString): Release attrStr before assigning new value.
5600
c803b2b7
JD
56012011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5602
678f4426
JD
5603 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5604 and NS_IMPL_COCOA.
5605 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5606 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5607
cd394be1 56082011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5609
5fecd5fc
JD
5610 * nsterm.m (ns_term_init): Subscribe for notifications
5611 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5612 to method trackingNotification in EmacsMenu.
5613
5614 * nsmenu.m (trackingMenu): New variable.
3771cb17 5615 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5616 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5617 from Aquamacs (Bug#7030).
678f4426
JD
5618
56192011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5620
c803b2b7
JD
5621 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5622 (symbol_to_nsstring): Fix indentation.
5623 (ns_symbol_to_pb): New function.
cae07000
SM
5624 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5625 (Fns_rotate_cut_buffers_internal): Remove.
5626 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5627 Fns_store_cut_buffer_internal.
5628 (ns_get_foreign_selection, Fx_own_selection_internal)
5629 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5630 (Fns_get_selection_internal, Fns_store_selection_internal):
5631 Use ns_symbol_to_pb and check if return value is nil.
5632 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5633 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5634 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5635 renamed to Sns_store_selection_internal.
5636 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5637 and remove this function.
5638 (ns_handle_selection_clear): Remove, never used.
5639 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5640 here.
5641
e1b01a3a
KB
56422011-12-17 Ken Brown <kbrown@cornell.edu>
5643
5644 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5645 GID is unknown (Bug#10257).
5646
2adb6e85
PE
56472011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5648
5649 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5650 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5651 which caused a build failure on GNU/Linux IA-64. This problem was
5652 introduced by my 2011-10-07 patch.
5653
d1d7b339
JL
56542011-12-15 Juri Linkov <juri@jurta.org>
5655
5656 * image.c (imagemagick_error): New function. (Bug#10112)
5657 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5658 Use `imagemagick_error' where ImageMagick functions return
5659 `MagickFalse'.
5660 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5661 proper order.
5662
100d5755
KH
56632011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5664
5665 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5666 fill background (Bug#8992).
5667
454592a6
MR
56682011-12-13 Martin Rudalics <rudalics@gmx.at>
5669
5670 * window.c (Vwindow_combination_resize)
5671 (Vwindow_combination_limit): Use t instead of non-nil in
5672 doc-strings.
61d4b438
MR
5673 (Vrecenter_redisplay): Add first sentence of doc-string on
5674 separate line.
53524d93 5675 (Frecenter): Fix doc-string typo.
454592a6 5676
3633e3aa
KH
56772011-12-11 Kenichi Handa <handa@m17n.org>
5678
5679 * coding.c (Funencodable_char_position): Pay attention to the
5680 buffer text relocation (Bug#9389).
5681
7b9d523a 56822011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5683
7b9d523a
JD
5684 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5685 gtk_init (Bug#10100).
5686
b73189c6
EZ
56872011-12-10 Eli Zaretskii <eliz@gnu.org>
5688
5689 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5690 IT->string is nil. (Bug#10263)
5691
f7dfe5d6
JD
56922011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5693
83faebb4
JD
5694 * nsterm.h (x_free_frame_resources): Declare.
5695
f7dfe5d6
JD
5696 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5697 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5698
5699 * nsterm.h (ns_get_defaults_value): Declare.
5700
5701 * nsterm.m (ns_default): Call ns_get_defaults_value.
5702
7cd4e72c
EZ
57032011-12-09 Eli Zaretskii <eliz@gnu.org>
5704
5705 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5706 (Bug#10170)
5707
b34d7317
YM
57082011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5709
5710 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5711 that where the value of an _OBJC_* symbol points to is in the .bss
5712 section (Bug#10240).
5713
76470ad1
KH
57142011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5715
5716 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5717 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5718
745fff94
KH
57192011-12-08 Kenichi Handa <handa@m17n.org>
5720
5721 * ftfont.c (get_adstyle_property): Fix previous change
5722 (Bug#10233).
5723
6e44397c
JB
57242011-12-07 Juanma Barranquero <lekktu@gmail.com>
5725
5726 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5727 dirs from the default value of EMACSLOADPATH (bug#10208).
5728
7efa6272
GM
57292011-12-07 Glenn Morris <rgm@gnu.org>
5730
5731 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5732 installation and source directories as well. (Bug#10208)
5733
f6fc4d87
CY
57342011-12-06 Chong Yidong <cyd@gnu.org>
5735
5736 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5737
2bf26180
GM
57382011-12-06 Glenn Morris <rgm@gnu.org>
5739
5740 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5741 as an error, not just -1. (Bug#10217)
5742
3a6ad4f0
CY
57432011-12-05 Chong Yidong <cyd@gnu.org>
5744
5745 * keyboard.c (process_special_events): New function.
5746 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5747
75a3b399
PE
57482011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5749
5750 * coding.c (encode_designation_at_bol): Don't use uninitialized
5751 local variable (Bug#9318).
5752
c3c9e25e
KH
57532011-12-05 Kenichi Handa <handa@m17n.org>
5754
5755 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5756 return Qnil (Bug#8046, Bug#10193).
5757
5eb05ea3
KH
57582011-12-05 Kenichi Handa <handa@m17n.org>
5759
5760 * coding.c (encode_designation_at_bol): New args charbuf_end and
5761 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5762 (coding_set_source): Return how many bytes coding->source was
5763 relocated.
5764 (coding_set_destination): Return how many bytes
5765 coding->destination was relocated.
5766 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5767 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5768
57692011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5770
5771 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5772 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5773 macro (Bug#9318).
5774
57752011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5776
5777 The following changes are to fix Bug#9318.
5778
a79703f5 5779 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5780 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5781 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5782 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5783
7dbda6df
JB
57842011-12-05 Juanma Barranquero <lekktu@gmail.com>
5785
5786 * lisp.h (process_quit_flag): Fix external declaration.
5787
6d5eb5b0
SM
57882011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5789
5790 Don't macro-inline non-performance-critical code.
5791 * eval.c (process_quit_flag): New function.
5792 * lisp.h (QUIT): Use it.
5793
a0c3fad0
JD
57942011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5795
5796 * nsfns.m (get_geometry_from_preferences): New function.
5797 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5798
6c07aac2
AS
57992011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5800
5801 * emacs.c (Qkill_emacs): Define.
5802 (syms_of_emacs): Initialize it.
5803 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5804 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5805 (quit_throw_to_read_char): Add parameter `from_signal'.
5806 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5807 * lisp.h (QUIT): Call Fkill_emacs if requested.
5808
c052ead4
JD
58092011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5810
5811 * widget.c (update_wm_hints): Return if wmshell is null.
5812 (widget_update_wm_size_hints): New function.
5813
5814 * widget.h (widget_update_wm_size_hints): Declare.
5815
5816 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5817 widget_update_wm_size_hints (Bug#10104).
5818
9e49252b
EZ
58192011-12-03 Eli Zaretskii <eliz@gnu.org>
5820
5821 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5822 before a newline, prepare the bidi iterator for consuming the
5823 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5824 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5825
02b16839
JL
58262011-12-02 Juri Linkov <juri@jurta.org>
5827
5828 * search.c (Fword_search_regexp): New Lisp function created from
5829 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5830 (Fword_search_backward, Fword_search_forward)
5831 (Fword_search_backward_lax, Fword_search_forward_lax):
5832 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5833 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5834
0068070e
SM
58352011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5836
5837 * fileio.c (Finsert_file_contents): Move after-change-function call
5838 to before the "handled:" label, since all "goto handled" appear in
5839 cases where the *-change-functions have already been properly called
5840 (bug#10117).
5841
3360a3fc
AS
58422011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5843
5844 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5845 waiting for input. (Bug#10169)
5846
73d6c093
EZ
58472011-11-30 Eli Zaretskii <eliz@gnu.org>
5848
5849 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5850 verifies glyph row's hash code--we have just reallocated the
5851 glyphs, so their contents can be complete garbage. (Bug#10164)
5852
febe6bea
JB
58532011-11-30 Juanma Barranquero <lekktu@gmail.com>
5854
5855 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5856
801a4313
EZ
58572011-11-30 Eli Zaretskii <eliz@gnu.org>
5858
5859 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5860 attributes are tested _before_ calling verify_row_hash, to protect
5861 against GCC re-ordering of the tests. (Bug#10164)
5862
2b56b87e
JD
58632011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5864
5865 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5866
5867 * xterm.c (handle_one_xevent): Only set async_visible and friends
5868 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5869 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5870 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5871
dbf31225
PE
58722011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5873
5874 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5875 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5876 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5877 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5878 All uses changed to use GCPRO1 etc.
5879 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5880 Revert to old implementation (i.e., before 2011-03-11).
5881
1305621b
YM
58822011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5883
5884 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5885 of scroll runs so as to avoid assigning disabled bogus rows and
5886 unnecessary graphics copy operations.
5887
8c9afb46
EZ
58882011-11-27 Eli Zaretskii <eliz@gnu.org>
5889
5890 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5891 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5892 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5893 (malloc, free, realloc, calloc): Redirect to e_* only when
5894 compiling Emacs.
5895
5896 * lisp.h (GCTYPEBITS): Move before first use.
5897 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5898 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5899 this macro definition.
5900
5901 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5902 _MSC_VER.
5903
54e9e3bf
JD
59042011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5905
6d5eb5b0
SM
5906 * gtkutil.c (xg_create_frame_widgets):
5907 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5908 present with Gtk+ 2.0.
5909
83aca1cb
PE
59102011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5911
5912 * fileio.c (Finsert_file_contents): Undo previous change; see
5913 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5914
5b76caa4
PE
59152011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5916
5917 Rename locals to avoid shadowing.
5918 * fileio.c (Finsert_file_contents):
5919 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5920 * process.c (wait_reading_process_output):
5921 Rename inner 'proc' to 'p' to avoid shadowing.
5922 Indent for consistency with usual Emacs style.
5923
8c535114
EZ
59242011-11-25 Eli Zaretskii <eliz@gnu.org>
5925
5926 * xdisp.c (redisplay_window): If cursor row is not fully visible
5927 after recentering, and scroll-conservatively is set to a large
5928 number, scroll window by a few more lines to make the cursor fully
5929 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5930 (start_display): Don't move to the next line if the display should
5931 start at a newline that is part of a display vector or an overlay
5932 string. (Bug#10119)
8c535114 5933
fa4fdb5c
JL
59342011-11-24 Juri Linkov <juri@jurta.org>
5935
5936 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5937 after the `MagickPingImage' call. (Bug#10112)
5938
90ec88df
CY
59392011-11-23 Chong Yidong <cyd@gnu.org>
5940
5941 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5942
56e2e794
MR
59432011-11-23 Martin Rudalics <rudalics@gmx.at>
5944
5945 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5946 making another buffer current. (Bug#10114)
5947
b6e64c41
GM
59482011-11-23 Glenn Morris <rgm@gnu.org>
5949
5950 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5951
6b21de18
CY
59522011-11-23 Chong Yidong <cyd@gnu.org>
5953
5954 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5955 using it (Bug#5984).
5956
b12cd789
EZ
59572011-11-22 Eli Zaretskii <eliz@gnu.org>
5958
5959 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5960 and header-lines, as they don't have one computed for them.
5961 (Bug#10098)
5962
5963 * .gdbinit (prow): Make displayed values more self-explaining.
5964 Add row's hash code.
5965
261b6fd4
LMI
59662011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5967
5968 * process.c (wait_reading_process_output): Fix asynchrounous
5969 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5970 (wait_reading_process_output): Add comment and URL.
261b6fd4 5971
e7cfd277
JD
59722011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5973
5974 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5975
a9b9b7f5
CY
59762011-11-21 Chong Yidong <cyd@gnu.org>
5977
5978 * window.c (Fnext_window, Fprevious_window): Doc fix.
5979
b0d15b4f
SM
59802011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5981
5982 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5983
fe7a3057
JB
59842011-11-20 Juanma Barranquero <lekktu@gmail.com>
5985
5986 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5987
d2999b1a
MR
59882011-11-20 Martin Rudalics <rudalics@gmx.at>
5989
5990 * window.c (Fset_window_combination_limit): Rename argument
5991 STATUS to LIMIT.
5992 (Vwindow_combination_limit): Remove "status" from doc-string.
5993
d5ff9cd0
AS
59942011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5995
5996 * m/ibms390.h: Remove.
5997 * m/ibms390x.h: Don't include "ibms390.h".
5998
a5bb9bd3
SM
59992011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6000
6001 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6002 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6003
cd1181db
JB
60042011-11-20 Juanma Barranquero <lekktu@gmail.com>
6005
6006 * casetab.c (Fset_case_table):
6007 * charset.c (Fcharset_after): Fix typos.
6008
615a3b8d 60092011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6010
17e845af
PE
6011 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6012 Otherwise, valgrind does not work on some platforms.
6013 Problem reported by Andreas Schwab in
6a0bf43d
PE
6014 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6015 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6016 is set, removing the need for VIRT_ADDRESS_VARIES.
6017 (PURE_P): Use a more-efficient implementation that needs just one
6018 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6019 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6020 to 4 (xorl, subq, cmpq, setbe).
6021 * alloc.c (pure): Always extern now, since that's the
6022 VIRT_ADDR_VARIES behavior.
6023 (PURE_POINTER_P): Use a single comparison, not two, for
6024 consistency with the new puresize.h.
6025 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6026 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6027 Remove VIRT_ADDR_VARIES no longer needed.
6028
f8fe6f96
EZ
60292011-11-19 Eli Zaretskii <eliz@gnu.org>
6030
6031 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6032 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6033 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6034 behave as if the cursor position were at the window margin.
6035
6036 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6037 and the cursor position is out of bounds, behave as if the cursor
6038 position were at the window margin. (Bug#10075)
6039
df05a53c
CY
60402011-11-18 Chong Yidong <cyd@gnu.org>
6041
6042 * window.c (Fwindow_combination_limit): Make first argument
6043 non-optional, since it is meaningless for live windows like the
6044 selected window.
61ccba97 6045
2071918e
DA
60462011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6047
6048 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6049
b50a28de
SM
60502011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6051
6052 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6053 (graft_intervals_into_buffer): Simplify.
6054
015137db
EZ
60552011-11-18 Eli Zaretskii <eliz@gnu.org>
6056
6057 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6058 hash values of the two rows.
6059 (copy_row_except_pointers): Preserve the used[] arrays and the
6060 hash values of the two rows. (Bug#10035)
68c95424 6061 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6062
6063 * xdisp.c (row_hash): New function, body extracted from
6064 compute_line_metrics.
6065 (compute_line_metrics): Call row_hash, instead of computing the
6066 hash code inline.
6067
6068 * dispnew.c (verify_row_hash): Call row_hash for computing the
6069 hash code of a row, instead of duplicating code from xdisp.c.
6070
6071 * dispextern.h (row_hash): Add prototype.
6072
a2addb04
TH
60732011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6074
6075 * frame.c (delete_frame): Don't delete the terminal when the last
6076 X frame is closed if emacs is built with GTK toolkit.
6077
df85d315
JB
60782011-11-17 Juanma Barranquero <lekktu@gmail.com>
6079
6080 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6081
a0c2d0ae
MR
60822011-11-17 Martin Rudalics <rudalics@gmx.at>
6083
6084 * window.c (Vwindow_splits): Rename to
6085 Vwindow_combination_resize. Suggested by Juri Linkov.
6086 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6087 of Vwindow_splits.
6088
58179cce
JB
60892011-11-16 Juanma Barranquero <lekktu@gmail.com>
6090
7877f373
JB
6091 * nsfns.m (Fns_font_name):
6092 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6093
b6f67890
MR
60942011-11-16 Martin Rudalics <rudalics@gmx.at>
6095
6096 * window.h (window): Rename slot "nest" to "combination_limit".
6097 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6098 (Fset_window_nest): Rename to Fset_window_combination_limit.
6099 (Vwindow_nest): Rename to Vwindow_combination_limit.
6100 (recombine_windows, make_parent_window, make_window)
6101 (Fsplit_window_internal, saved_window)
6102 (Fset_window_configuration, save_window_save): Rename all
6103 occurrences of window_nest to window_combination_limit.
6104
c7015153
JB
61052011-11-15 Juanma Barranquero <lekktu@gmail.com>
6106
6107 * image.c (imagemagick_load_image): Fix typo.
6108
322ad6ec
EZ
61092011-11-14 Eli Zaretskii <eliz@gnu.org>
6110
6111 * xdisp.c (display_line): Move the call to
6112 highlight_trailing_whitespace before the call to
6113 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6114 faces of all the glyphs to compute ROW's hash value.
6115 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6116
f067b8ec
JB
61172011-11-14 Juanma Barranquero <lekktu@gmail.com>
6118
6119 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6120 just return (bug#10044).
6121
1e5b2111
EZ
61222011-11-12 Eli Zaretskii <eliz@gnu.org>
6123
7ef3cbd5
EZ
6124 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6125 with user-defined heap size. Bump the default size of the temacs
6126 heap to 27MB, to avoid memory warning when running temacs.
6127 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6128
1e5b2111
EZ
6129 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6130 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6131 (verify_row_hash) [XASSERTS]: New function.
6132 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6133 that the hash value of glyph rows is correct.
1e5b2111 6134
89d61221
MR
61352011-11-12 Martin Rudalics <rudalics@gmx.at>
6136
6137 * window.h (window): Remove splits slot.
6138 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6139 (Fdelete_other_windows_internal, make_parent_window)
6140 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6141 (Fset_window_configuration, save_window_save): Don't deal with
6142 split status of windows.
6143 (saved_window): Remove splits slot.
6144 (Vwindow_splits): Rewrite doc-string.
6145
97f18cc8
JD
61462011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6147
6148 * xfns.c (unwind_create_frame):
6149 * nsfns.m (unwind_create_frame):
6150 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6151 Vframe_list (Bug#9999).
6152
22a648b4
DA
61532011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6154
0b381c7e 6155 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6156
659afede
KH
61572011-11-11 Kenichi Handa <handa@m17n.org>
6158
6159 * callproc.c (Fcall_process): Set the member dst_multibyte of
6160 process_coding.
6161
9ac0394b
KH
61622011-11-11 Johan Bockgård <bojohan@gnu.org>
6163
6164 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6165 avoid a crash (bug#9496).
6166
2fbdc249
CY
61672011-11-09 Chong Yidong <cyd@gnu.org>
6168
6169 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6170 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6171
ac6b1f81
PE
61722011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6173
6174 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6175
09db192c
PE
61762011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6177
6178 Avoid some portability problems by eschewing 'extern inline' functions.
6179 The trivial performance wins aren't worth the portability hassles; see
6180 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6181 et seq.
6182 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6183 (window_box_width, window_box_left, window_box_left_offset)
6184 (window_box_right, window_box_right_offset): Undo previous change,
6185 by removing the "extern"s.
6186 * intervals.c (adjust_intervals_for_insertion)
6187 (adjust_intervals_for_deletion): Undo previous change,
6188 making these static again.
6189 (offset_intervals, temp_set_point_both, temp_set_point)
6190 (copy_intervals_to_string): No longer inline.
6191 * xdisp.c (window_text_bottom_y, window_box_width)
6192 (window_box_height, window_box_left_offset)
6193 (window_box_right_offset, window_box_left, window_box_right)
6194 (window_box): No longer inline.
6195
105216ed
CY
61962011-11-08 Chong Yidong <cyd@gnu.org>
6197
6198 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6199 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6200 Signal an error if not a live window.
105216ed
CY
6201 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6202 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6203
ae9e237f
JB
62042011-11-07 Juanma Barranquero <lekktu@gmail.com>
6205
6206 * lisp.h (syms_of_abbrev): Remove declaration.
6207 Reported by CHENG Gao <chenggao@royau.me>.
6208
c7aa8333
EZ
62092011-11-07 Eli Zaretskii <eliz@gnu.org>
6210
6211 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6212 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6213 of temacs in GUI mode.
6214
be7f5545
MR
62152011-11-07 Martin Rudalics <rudalics@gmx.at>
6216
6217 * window.h: Declare delete_all_child_windows instead of
6218 delete_all_subwindows.
6219 * window.c (Fwindow_nest, Fset_window_nest)
6220 (Fset_window_new_total, Fset_window_new_normal)
6221 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6222 (delete_all_subwindows): Rename to delete_all_child_windows.
6223 (Fdelete_other_windows_internal, Fset_window_configuration):
6224 Call delete_all_child_windows instead of delete_all_subwindows.
6225 * frame.c (delete_frame): Call delete_all_child_windows instead
6226 of delete_all_subwindows.
6227
ca78dc43
PE
62282011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6229
6230 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6231 This is also needed for porting to any host where GC_MARK_STACK is
6232 not GC_MAKE_GCPROS_NOOPS.
6233 (which_symbols): Use it.
6234
a0241d01
KH
62352011-11-07 Kenichi Handa <handa@m17n.org>
6236
6237 * coding.c (coding_set_destination): Check coding->src_pos only
6238 when coding->src_object is a buffer (bug#9910).
6239
6240 * process.c (send_process): Set the member src_multibyte of coding
6241 to 0 (bug#9911) when sending a unibyte text.
6242
6243 * callproc.c (Fcall_process): Set the member src_multibyte of
6244 process_coding to 0 (bug#9912).
6245
a64bfdfa 62462011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6247
6248 * xmenu.c (cleanup_widget_value_tree): New function.
6249 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6250 calling free_menubar_widget_value_tree directly (Bug#9830).
6251
cb41b32a
PE
62522011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6253
6254 Fix some portability problems with 'inline'.
6255 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6256 (window_box_width, window_box_left, window_box_left_offset)
6257 (window_box_right, window_box_right_offset): Declare extern.
6258 Otherwise, these inline functions do not conform to C99 and
6259 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6260 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6261 * intervals.c (adjust_intervals_for_insertion)
6262 (adjust_intervals_for_deletion): Now extern, because otherwise the
6263 extern inline functions 'offset_intervals' couldn't refer to it.
6264 (static_offset_intervals): Remove.
6265 (offset_intervals): Rewrite using the old contents of
6266 static_offset_intervals. The old version didn't conform to C99
6267 because an extern inline function contained a reference to an
6268 identifier with static linkage.
6269
b7041366
AS
62702011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6271
6272 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6273 GC.
6274
88a37c4d
EZ
62752011-11-06 Eli Zaretskii <eliz@gnu.org>
6276
6277 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6278 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6279 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6280 return Qleft_to_right.
6281
49745b39
CY
62822011-11-06 Chong Yidong <cyd@gnu.org>
6283
6284 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6285 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6286 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6287 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6288 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6289 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6290 (Fwindow_vscroll): Doc fix.
6291 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6292 argument, since it makes no sense to pass a live window and for
6293 consistency with window-child.
6294
1f05cd82
CS
62952011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6296
6297 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6298 support MSVC.
6299
22610910
JR
63002011-11-05 Jason Rumney <jasonr@gnu.org>
6301
6302 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6303 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6304 fonts (Bug#6029).
6305 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6306 bitwise arithmetic preventing use of unicode-sip and non-truetype
6307 opentype fonts.
6308
a06776b2
EZ
63092011-11-05 Eli Zaretskii <eliz@gnu.org>
6310
3ad924ba
EZ
6311 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6312 "emacs"-only part.
6313
a06776b2
EZ
6314 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6315 initialization code to keep similarity to xfns.c after changes
6316 from 2011-11-05.
6317
c9e7db78
JD
63182011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6319
a97f8f3f
JD
6320 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6321 (unwind_create_frame): New function (Bug#9943).
6322 (Fx_create_frame): Restructure code to be more similar to the one in
6323 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6324 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6325 Move terminal->reference_count++ just before making the frame official
6326 (Bug#9943).
6327
6328 * nsterm.m (x_free_frame_resources): New function.
6329 (x_destroy_window): Move code to x_free_frame_resources.
6330
c9e7db78 6331 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6332 (Fx_create_frame, x_create_tip_frame):
6333 Move terminal->reference_count++ just before making the frame
75f1671a 6334 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6335 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6336
a6fc3b5c
EZ
63372011-11-05 Eli Zaretskii <eliz@gnu.org>
6338
6339 Support MSVC build with newer versions of Visual Studio.
6340 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6341 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6342 nt/gmake.defs.
6343
6344 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6345 which are not supported by MSVC.
6346 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6347 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6348 bitfields.
6349 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6350 types in bitfields.
6351 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6352
6353 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6354
58179cce 63552011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6356
6357 Support MSVC build with newer versions of Visual Studio.
6358 * w32.c: Don't include w32api.h for MSVC.
6359 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6360
6361 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6362 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6363 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6364 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6365 e_* cousins.
6366 (alloca) [_MSC_VER]: Define to _alloca.
6367
6368 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6369
6370 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6371
a58c13ed
EZ
63722011-11-04 Eli Zaretskii <eliz@gnu.org>
6373
6374 * xdisp.c (note_mouse_highlight): If either of
6375 previous/next-single-property-change returns nil, treat that as
6376 the beginning or the end of the buffer. (Bug#9955)
6377
fe0b6370
JD
63782011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6379
a58c13ed 6380 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6381 label is not null (Bug#9951).
6382 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6383 may be NULL.
6384
89bd5ee1
EZ
63852011-11-04 Eli Zaretskii <eliz@gnu.org>
6386
6387 * window.c (Fwindow_body_size): Mention in the doc string that the
6388 return value is in frame's canonical units. (Bug#9949)
6389
84c3edb9
EZ
63902011-11-03 Eli Zaretskii <eliz@gnu.org>
6391
4e2fb5c7
EZ
6392 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6393
84c3edb9 6394 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6395 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6396 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6397
bc17a887
EZ
63982011-11-01 Eli Zaretskii <eliz@gnu.org>
6399
6400 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6401 Don't stop backward scan on the continuation glyph, even though
6402 its CHARPOS is positive.
6d5eb5b0
SM
6403 (mouse_face_from_buffer_pos, note_mouse_highlight):
6404 Rename cover_string to disp_string.
bc17a887 6405
4ee88440
MR
64062011-11-01 Martin Rudalics <rudalics@gmx.at>
6407
6408 * window.c (temp_output_buffer_show): Don't use
6409 Vtemp_buffer_show_specifiers.
6410 (Vtemp_buffer_show_specifiers): Remove unused variable.
6411
c2ff3c02
EZ
64122011-10-30 Eli Zaretskii <eliz@gnu.org>
6413
6414 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6415 past the beginning of the current glyph matrix.
6416
58179cce 64172011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6418
6419 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6420 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6421 HAVE_GTK3 (Bug#9869).
b77a6a7f 6422
3b574623
JD
6423 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6424 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6425
b77a6a7f
JD
6426 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6427
6428 * xterm.c: Declare x_handle_net_wm_state to return int.
6429 (handle_one_xevent): Check if we are iconified but don't have
6430 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6431 (get_current_wm_state): Return non-zero if not hidden,
6432 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6433 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6434 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6435 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6436
196e41e4
PE
64372011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6438
6439 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6440 so that this new function doesn't get optimized away by a
6441 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6442
021f2e1a
AS
64432011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6444
6445 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6446
8b058d44
EZ
64472011-10-29 Eli Zaretskii <eliz@gnu.org>
6448
6449 Fix the `xbytecode' command.
6450 * .gdbinit (xprintbytestr): New command.
b50a28de 6451 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6452 (xbytecode): Print the byte-code string as well.
6453
4452fb80
EZ
64542011-10-29 Kim Storm <storm@cua.dk>
6455
8b058d44
EZ
6456 * alloc.c (which_symbols): New function.
6457
21b72067
AS
64582011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6459
6460 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6461 line. (Bug#9903)
6462
83ed7b5c
GM
64632011-10-29 Glenn Morris <rgm@gnu.org>
6464
6465 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6466 Not clear what it was for, and it causes various bugs. (Bug#9839)
6467
5a7a728b
EZ
64682011-10-28 Eli Zaretskii <eliz@gnu.org>
6469
6470 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6471 possible random value that matches one of those tested as
6472 condition to clear the mouse face.
6473
d3d0842f
CY
64742011-10-28 Chong Yidong <cyd@gnu.org>
6475
6476 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6477
31b39d13
DN
64782011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6479
6480 * window.c (make_window): Initialize phys_cursor_on_p.
6481
9aba6043
SM
64822011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6483
6484 * lisp.h (struct Lisp_Symbol): Update comments.
6485
c20992f4
JB
64862011-10-28 Juanma Barranquero <lekktu@gmail.com>
6487
6488 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6489
db4f02f2
EZ
64902011-10-28 Eli Zaretskii <eliz@gnu.org>
6491
6492 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6493 <oslsachem@gmail.com> for helping to debug this.
6494
6495 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6496 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6497 (g_b_init_get_glyph_outline_w): New static variables.
6498 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6499 (GetGlyphOutlineW_Proc): New typedefs.
6500 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6501 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6502 New functions.
6503 (w32font_open_internal, compute_metrics):
6504 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6505 instead of calling the "wide" APIs directly.
6506
6507 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6508
6509 * w32.h (syms_of_w32font): Add prototype.
6510
87e68db4
JB
65112011-10-27 Juanma Barranquero <lekktu@gmail.com>
6512
6513 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6514 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6515 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6516 (Fmove_to_window_line): Doc fix.
6517
435c1d67
CY
65182011-10-27 Chong Yidong <cyd@gnu.org>
6519
6520 * process.c (make_process): Set gnutls_state to NULL.
6521
6522 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6523 non-NULL, regardless of GNUTLS_INITSTAGE.
6524 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6525 an error. Set process slots as soon as we allocate them.
6526
6527 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6528
9c6c6f49
CY
65292011-10-27 Chong Yidong <cyd@gnu.org>
6530
9aba6043
SM
6531 * gnutls.c (emacs_gnutls_deinit): New function.
6532 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6533 (Fgnutls_deinit, Fgnutls_boot): Use it.
6534
6535 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6536 (deactivate_process): Call emacs_gnutls_deinit.
6537
657d08d3
JB
65382011-10-27 Juanma Barranquero <lekktu@gmail.com>
6539
6540 * image.c (x_create_x_image_and_pixmap):
6541 * w32.c (sys_rename, w32_delayed_load):
6542 * w32font.c (fill_in_logfont):
6543 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6544
5430d399
JB
65452011-10-26 Juanma Barranquero <lekktu@gmail.com>
6546
6547 * w32fns.c (w32_default_color_map): New function,
6548 extracted from Fw32_default_color_map.
a7ef684b 6549 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6550
fe0055fa
PE
65512011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6552
6553 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6554
e6346438
SM
65552011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6556
6557 * keyboard.c (test_undefined): New function (bug#9751).
6558 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6559
e112cc37
ET
65602011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6561
6562 * sysdep.c (init_sys_modes): Fix the check for the controlling
6563 terminal (Bug#6649).
6564
7b5d6677
EZ
65652011-10-20 Eli Zaretskii <eliz@gnu.org>
6566
6567 * dispextern.h (struct bidi_it): New member next_en_type.
6568
6569 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6570 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6571 current character, check also for next_en_type being WEAK_EN.
6572 (bidi_resolve_weak): Don't enter the expensive loop if the current
6573 position is before next_en_pos. Record the bidi type of the first
6574 non-ET, non-BN character we find, in addition to its position.
6575 (bidi_level_of_next_char): Invalidate next_en_type when
6576 next_en_pos is over-stepped.
6577
7da0b018
PE
65782011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6579
6580 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6581 * editfns.c: Rewrite current-time-zone so that it invokes
6582 the equivalent of (format-time-string "%Z") to get the time zone name.
6583 This fixes a bug when the time zone name contains characters that
6584 need converting from the system time locale to Emacs internal format.
6585 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6586 that patch fixed format-time-string to do the conversion, but
6587 I forgot to fix current-time-zone.
6588 (format_time_string): New function, containing most of
6589 what Fformat_time_string used to contain.
6590 (Fformat_time_string): Rewrite in terms of format_time_string.
6591 This doesn't change this function's behavior.
6592 (current-time-zone): Rewrite to use format_time_string.
6593 This fixes the bug reported by Michael Schierl in
6594 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6595 Jason Rumney's 2007-06-07 change worked around this bug, but
6596 didn't fix it.
6597 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6598
8547b010
EZ
65992011-10-19 Eli Zaretskii <eliz@gnu.org>
6600
6601 * xdisp.c (start_display): If the character at POS is displayed
6602 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6603 (try_window_reusing_current_matrix): If a line ends in a display
6604 vector or the next line starts in a display vector, continue
6605 redrawing the window even though the character position of
6606 start_row was reached.
8547b010
EZ
6607 (Bug#9771, part 2)
6608
4e948d15
CY
66092011-10-18 Chong Yidong <cyd@gnu.org>
6610
6611 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6612 with nobreak-char-display too.
6613
4787455f
EZ
66142011-10-18 Eli Zaretskii <eliz@gnu.org>
6615
6616 Fix part 3 of bug#9771.
6617 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6618 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6619 non-neutral characters if the current character is a paragraph
6620 separator (a.k.a. Newline). This avoids running the same
6621 expensive loop twice, once when we consume the preceding newline
6622 and the other time when the line actually needs to be displayed.
6623 Avoid the loop when we see neutrals on the base embedding level
6624 following a character whose directionality is the same as the
6625 paragraph's. This avoids running the expensive loop when a line
6626 ends in a long sequence of neutrals, like control characters.
6627 Add assertion against STRONG_AL type. Slightly rearrange code
6628 that determines the type of a neutral given the first non-neutral
6629 that follows it.
6630 (bidi_level_of_next_char): Set next_en_pos to zero when
6631 invalidating its info.
6632
2c91f553
EZ
66332011-10-17 Eli Zaretskii <eliz@gnu.org>
6634
6635 * xdisp.c (push_display_prop): Determine whether to record string
6636 or buffer position by IT->string, not by IT->method. Allow
6637 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6638 (move_it_vertically_backward): Don't look for character position
6639 immediately after the newline when in a continuation line.
6640 (Bug#9771, part 1)
2c91f553 6641
c7b08b0d
MR
66422011-10-15 Martin Rudalics <rudalics@gmx.at>
6643
6644 * window.c (coordinates_in_window): Rewrite and delabelize
6645 vertical border check. (Bug#5357) (Bug#9618)
6646
6b02f655
SM
66472011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6648
6649 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6650 errors in XSetWindowBorder (bug#9310).
6651
81d40c92
DA
66522011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6653
6654 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6655 avoid crash when xmalloc overrun checking is enabled.
6656
d4172c3b
EZ
66572011-10-13 Eli Zaretskii <eliz@gnu.org>
6658
6659 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6660 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6661 cursor motion with <left> and <right> arrow keys.
6662
6663 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6664 some callers set that themselves.
6665
b00eea75
EZ
66662011-10-12 Eli Zaretskii <eliz@gnu.org>
6667
6668 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6669 display string and the previous row comes from the same string and
6670 is empty. (Bug#9739) (Bug#9738)
6671
8fe012c4
SM
66722011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6673
6674 * doc.c (get_doc_string): Encode file name (bug#9735).
6675
0074aef2
EZ
66762011-10-12 Eli Zaretskii <eliz@gnu.org>
6677
79beb178
EZ
6678 * bidi.c (bidi_level_of_next_char):
6679 * xdisp.c (get_visually_first_element): Remove old incorrect
6680 comments regarding the Unicode Line Separator character.
6681
0074aef2
EZ
6682 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6683
6e4b3fbe
DA
66842011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6685
6686 * alloc.c (Fgc_status): Do not access beyond zombies array
6687 boundary if nzombies > MAX_ZOMBIES.
6688 * alloc.c (dump_zombies): Add missing format specifier.
6689
0324f3af
PE
66902011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6691
b5525cac
PE
6692 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6693 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6694
0324f3af
PE
6695 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6696 Some packages use them to denote characters with modifiers.
6697
e9b5f888
AS
66982011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6699
6700 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6701 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6702 matching a pp-number. Rename parameter var to var1.
6703
127827c0
SM
67042011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6705
6706 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6707
c8fd3bd0
GM
67082011-10-08 Glenn Morris <rgm@gnu.org>
6709
6710 * callint.c (Fcall_interactively): Give a more explicit error for the
6711 'c' case with a non-character input. (Bug#8479)
6712
352ec8ff
EZ
67132011-10-08 Eli Zaretskii <eliz@gnu.org>
6714
03669ccb
EZ
6715 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6716 lines.
7061c986
EZ
6717 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6718 lines that are hscrolled on the left.
03669ccb 6719
352ec8ff
EZ
6720 * dispnew.c (buffer_posn_from_coords): Account for a possible
6721 presence of header-line. (Bug#4426)
6722
a66cfb1c
SM
67232011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6724
6b02f655
SM
6725 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6726 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6727
7c5ee88e
PE
67282011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6729
6730 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6731 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6732 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6733 this makes Emacs dump core during garbage collection on rare
6734 occasions. sizeof is obviously inferior to offsetof here, so
6735 stick with offsetof.
6736 (GC_POINTER_ALIGNMENT): New macro.
6737 (mark_memory): Omit 3rd (offset) arg; caller changed.
6738 Don't assume EMACS_INT alignment is the same as pointer alignment.
6739
df1bbe5b
SM
67402011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6741
6742 * keyboard.c (read_key_sequence_remapped): New var.
6743 (read_key_sequence): Compute remapping in the right buffer.
6744 (command_loop_1): Use read_key_sequence's remapping directly.
6745
51553db6
SM
67462011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6747
32c1fffd
SM
6748 * dired.c (file_name_completion): Don't expand file name.
6749 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6750 before checking file name handler.
6751
51553db6
SM
6752 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6753 they've been requested explicitly (bug#9591).
6754
b6bd1599 67552011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6756
6757 * keymap.c (Fsingle_key_description): Use make_specified_string
6758 instead of build_string to build string from push_key_description.
6759 (Bug#5193)
6760
f701dc2a
PE
67612011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6762
4222c55d
PE
6763 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6764 This fixes a Y2038 bug on 64-bit hosts.
6765 * buffer.c (reset_buffer):
6766 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6767 (Fclear_buffer_auto_save_failure):
6768 Use 0, not -1, to represent an unset failure time, since time_t
6769 might not be signed.
6770
f701dc2a
PE
6771 Remove dependency on glibc malloc internals.
6772 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6773 Move back here from lisp.h, but with their new implementations.
6774 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6775 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6776 * charset.c (charset_table_init): New static var.
6777 (syms_of_charset): Use it instead of xmalloc. This removes a
6778 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6779 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6780 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6781 Move back to alloc.c.
6782 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6783 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6784
9ceebf39
JD
67852011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6786
6787 * nsterm.m (windowDidResize): Call x_set_window_size only when
6788 ns_in_resize is true. Otherwise set pixelwidth/height and
6789 call change_frame_size (Bug#9628).
6790
cb993c58
PE
67912011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6792
3930c88b
PE
6793 Port --enable-checking=all to Fedora 14 x86-64.
6794 * charset.c (syms_of_charset): Also account for glibc malloc's
6795 internal overhead when calculating the initial malloc maximum.
6796
cb993c58
PE
6797 Port --enable-checking=all to Fedora 14 x86.
6798 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6799 Move to lisp.h.
6800 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6801 (overrun_check_realloc, overrun_check_free):
6802 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6803 That way, xmalloc returns a properly-aligned pointer even if
6804 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6805 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6806 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6807 into account when calculating the initial malloc maximum.
6808 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6809 Move here from alloc.c, so that charset.c can use it too.
6810 Properly align; the old code wasn't right for common 32-bit hosts
6811 when configured with --enable-checking=all.
6812 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6813 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6814
31bed486
EZ
68152011-09-29 Eli Zaretskii <eliz@gnu.org>
6816
04c70788 6817 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6818 use EDOM.
6819
fbcaa2f3
EZ
68202011-09-28 Eli Zaretskii <eliz@gnu.org>
6821
6822 * xdisp.c (compute_display_string_end): If there's no display
6823 string at CHARPOS, return -1.
6824
6825 * bidi.c (bidi_fetch_char): When compute_display_string_end
6826 returns a negative value, treat the character as a normal
6827 character not covered by a display string. (Bug#9624)
6828
a239d4e9
JB
68292011-09-28 Juanma Barranquero <lekktu@gmail.com>
6830
6831 * lread.c (Fread_from_string): Fix typo in docstring.
6832
88652fd5
EZ
68332011-09-27 Eli Zaretskii <eliz@gnu.org>
6834
6835 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6836 newline, reseat the iterator instead of bidi-iterating there one
6837 character at a time. (Bug#9610)
32c1fffd
SM
6838 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6839 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6840
ed497dd4
AS
68412011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6842
6843 * lread.c (readevalloop): Use correct code for NBSP.
6844 (read1): Likewise. (Bug#9608)
6845
b2bf61aa
MA
68462011-09-25 Michael Albinus <michael.albinus@gmx.de>
6847
6848 * dbusbind.c (Fdbus_register_signal): When service is not
6849 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6850
32bbb17c
GM
68512011-09-25 Glenn Morris <rgm@gnu.org>
6852
6853 * buffer.c (truncate-lines): Doc fix.
6854
94e0933e
CY
68552011-09-24 Chong Yidong <cyd@stupidchicken.com>
6856
6857 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6858 (Fset_window_next_buffers): Doc fix.
6859
cddde921
GM
68602011-09-24 Glenn Morris <rgm@gnu.org>
6861
6862 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6863
1260aef1
PE
68642011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6865
25b4bfa0
PE
6866 Fix minor problems found by static checking.
6867 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6868 * indent.c (Fvertical_motion): Fix == vs = typo.
6869
e3cbd34b
EZ
68702011-09-24 Eli Zaretskii <eliz@gnu.org>
6871
a66cfb1c
SM
6872 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6873 Default value is now t. Doc fix.
6bf7006f 6874
e3cbd34b 6875 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6876 logic when moving up, not only when moving down. Fix the
e3cbd34b 6877 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6878 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6879
6880 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6881 CHARPOS is covered by a display string which includes newlines.
6882 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6883 is covered by a display string with embedded newlines.
6884
a3de0cbd
MA
68852011-09-24 Michael Albinus <michael.albinus@gmx.de>
6886
6887 * dbusbind.c (Fdbus_register_signal): Add match rule to
6888 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6889 (Fdbus_register_method, Vdbus_registered_objects_table):
6890 Fix docstring.
a3de0cbd 6891
b260039d
JM
68922011-09-24 Jim Meyering <meyering@redhat.com>
6893
32c1fffd 6894 do not ignore write error for any output size
b260039d
JM
6895 The previous change was incomplete.
6896 While it makes emacs --batch detect the vast majority of stdout
6897 write failures, errors were still ignored whenever the output size is
6898 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6899 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6900 && echo FAIL: ignored write error
6901 FAIL: ignored write error
6902 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6903 && echo FAIL: ignored write error
6904 FAIL: ignored write error
6905 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6906
8eca8a7c
AS
69072011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6908
6909 * emacs.c (Fkill_emacs): In noninteractive mode exit
6910 non-successfully if a write error occurred on stdout. (Bug#9574)
6911
3341db62
EZ
69122011-09-21 Eli Zaretskii <eliz@gnu.org>
6913
6914 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6915 the xassert test.
6916
6917 * dispextern.h (struct it): Update the comment documenting what
6918 can it->OBJECT be.
6919
8c203dbf
EZ
69202011-09-20 Eli Zaretskii <eliz@gnu.org>
6921
6922 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6923 a display string, extend search for cursor position to end of row.
6924 (find_row_edges): If the row ends in a newline from a display
6925 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6926 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6927 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6928 non-empty line. Fixes confusing cursor motion with arrow keys at
6929 the beginning of a line that starts with whitespace.
8c203dbf 6930
a4824228
LMI
69312011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6932
6933 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6934 (bug#9493).
6935
33ed493b
CY
69362011-09-18 Chong Yidong <cyd@stupidchicken.com>
6937
6938 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6939 boolean (Bug#9154).
6940
56cd55c8
EZ
69412011-09-18 Eli Zaretskii <eliz@gnu.org>
6942
6943 * xdisp.c (display_line): Record maximum and minimum buffer
6944 positions even if no glyphs were produced (e.g., by a zero-width
6945 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6946 buffer positions that will be removed from the glyph row because
6947 they don't fit.
c02dcedf
EZ
6948 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6949 column is beyond frame width: don't subtract 1 "pixel" when
6950 computing width of the stretch.
3e62b7e0
EZ
6951 (reseat_at_next_visible_line_start): Undo the change made on
6952 2011-09-17 that saved paragraph information and restored it after
6953 the call to `reseat'. (Bug#9545)
56cd55c8 6954
5ed99d36 69552011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6956
6957 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6958 and turn window cursor on if cleared (Bug#9415).
6959
5ed99d36 69602011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6961
6962 * search.c (boyer_moore): Take unibyte characters from pattern
6963 literally. (Bug#9458)
6964
9bade7b2
EZ
69652011-09-18 Eli Zaretskii <eliz@gnu.org>
6966
6967 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6968
e5e9d610
PE
69692011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6970
87e4427a
PE
6971 Fix minor problem found by static checking.
6972 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6973 initialized, to pacify gcc -Wuninitialized.
6974
e5e9d610
PE
6975 * fileio.c: Report proper errno when syscall falls.
6976 (Finsert_file_contents): Save and restore errno,
6977 so that report_file_error outputs the correct diagnostic.
6978 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6979
a1674f0b
EZ
69802011-09-18 Eli Zaretskii <eliz@gnu.org>
6981
6982 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6983
fbfb6dd4
EZ
69842011-09-17 Eli Zaretskii <eliz@gnu.org>
6985
6986 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6987 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6988
bb187662
EZ
69892011-09-17 Eli Zaretskii <eliz@gnu.org>
6990
1137e8b8 6991 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6992 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6993
6994 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6995 (bidi_find_paragraph_start): Search back for paragraph beginning
6996 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6997 (bidi_move_to_visually_next): Only trigger paragraph-related
6998 computations when the last character is a newline or at EOB, not
6999 just any NEUTRAL_B. (Bug#9470)
7000
bb187662
EZ
7001 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7002 truncated lines if point is covered by a display string. (Bug#9524)
7003
2e621251
PE
70042011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7005
7006 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7007 (cons_to_x_long): New function.
7008 (lisp_data_to_selection_data): Use it. Correct the test for
7009 short-versus-long data; it was negated. Break out of vector
7010 loop, for efficiency, when a long datum is discovered.
7011
91a15bc6
SM
70122011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7013
7014 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7015
b41c3a35
EZ
70162011-09-16 Eli Zaretskii <eliz@gnu.org>
7017
7018 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7019 GCC PR/17406) by declaring this function with external scope.
7020
7812ba2d
PE
70212011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7022
7023 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7024 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7025
cf7edc2a
AS
70262011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7027
7028 * editfns.c (Fformat): Correctly handle text properties on "%%".
7029
bd01620e
EZ
70302011-09-15 Eli Zaretskii <eliz@gnu.org>
7031
7032 * xterm.c (x_draw_composite_glyph_string_foreground):
7033 * w32term.c (x_draw_composite_glyph_string_foreground):
7034 * term.c (encode_terminal_code):
7035 * composite.c (composition_update_it, get_composition_id):
7036 * xdisp.c (get_next_display_element)
7037 (fill_composite_glyph_string): Add comments about special meaning
7038 of TAB characters in a composition.
7039
a02719a3
PE
70402011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7041
7042 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7043 This occurs when processing a multibyte format.
7044 Problem reported by Wolfgang Jenker.
a02719a3 7045
72589a3c
JB
70462011-09-15 Johan Bockgård <bojohan@gnu.org>
7047
7048 * xdisp.c (try_cursor_movement): Only check for exact match if
7049 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7050
1c14176c
PE
70512011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7052
7053 Remove unused external symbols.
7054 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7055 * xdisp.c (calc_pixel_width_or_height): Now static.
7056 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7057 * indent.c (check_display_width):
7058 * w32term.c: Fix comment to match code.
7059 * xterm.c, xterm.h (x_catching_errors): Remove.
7060
d2eea5b5
PE
70612011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7062
7063 * xselect.c: Use signed conversions more consistently (Bug#9498).
7064 (selection_data_to_lisp_data): Assume incoming selection data are
7065 signed integers, not unsigned. This is to be consistent with
7066 outgoing selection data, which was modified to use signed integers
7067 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7068 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7069 expects long, not unsigned long.
7070
46888499
EZ
70712011-09-14 Eli Zaretskii <eliz@gnu.org>
7072
7073 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7074 computation of loop end. Reported by Johan Bockgård
7075 <bojohan@gnu.org>.
7076
ef8ef9fb
CY
70772011-09-13 Chong Yidong <cyd@stupidchicken.com>
7078
7079 * frame.c (Fother_visible_frames_p): Function deleted.
7080
fa819fed
EZ
70812011-09-12 Eli Zaretskii <eliz@gnu.org>
7082
7083 * indent.c (compute_motion): Process display vector front to back
7084 rather than the other way around. (Bug#2496)
7085
2ba8e008
SM
70862011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7087
7088 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7089
20f53c69
CY
70902011-09-11 Chong Yidong <cyd@stupidchicken.com>
7091
7092 * minibuf.c (Fread_from_minibuffer): Doc fix.
7093
d562d7a4
EZ
70942011-09-11 Eli Zaretskii <eliz@gnu.org>
7095
7096 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7097 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7098
1c4d7f3d
LMI
70992011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7100
7101 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7102 value for non-existent files.
7103
b885bf36
EZ
71042011-09-11 Eli Zaretskii <eliz@gnu.org>
7105
7106 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7107 set its "size" to -1. This will set the modtime_size field of
7108 the corresponding buffer to -1, which is what
7109 verify-visited-file-modtime expects for files that do not exist.
7110 (Bug#9139)
7111
6612f0bf
PE
71122011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7113
7114 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7115 here ...
7116 * lisp.h: ... from here. push_key_description is no longer
7117 defined in keyboard.c, so its declaration should not be in
7118 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7119 logically belongs with push_key_description.
7120
dfb3f755
PE
71212011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7122
7123 * buffer.h: Include <sys/types.h> instead of <time.h>.
7124 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7125 Problem reported by Herbert J. Skuhra.
7126
3134906c
LMI
71272011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7128
7129 * xml.c (parse_region): Make the parsing work for
7130 non-comment-starting XML files again (bug#9144).
7131
8d903f4e
AS
71322011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7133
7134 * image.c (gif_load): Fix calculation of bottom and right corner.
7135 (Bug#9468)
7136
80ad64f4
EZ
71372011-09-10 Eli Zaretskii <eliz@gnu.org>
7138
7139 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7140 redisplay in small windows.
7141
208a048d
EZ
71422011-09-09 Eli Zaretskii <eliz@gnu.org>
7143
7144 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7145
9b1c252e
MR
71462011-09-08 Martin Rudalics <rudalics@gmx.at>
7147
7148 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7149 Operate on live windows only.
7150
2949f33b
JB
71512011-09-08 Juanma Barranquero <lekktu@gmail.com>
7152
7153 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7154
e08dcafd
EZ
71552011-09-07 Eli Zaretskii <eliz@gnu.org>
7156
7157 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7158 only under bidi iteration.
7159
115b96bd
JD
71602011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7161
7162 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7163
c8199d0f
PE
71642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7165
7166 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7167 Without this fix, the command to link temacs failed due to an
7168 undefined symbol __builtin_isnan. This is because
7169 /usr/include/iso/math_c99.h #defines isnan(x) to
7170 __builtin_isnan(x), but the bundled gcc, which identifies itself
7171 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7172 a __builtin_isnan.
7173 * floatfns.c (isnan): #undef, and then #define to a clone of
7174 what's in data.c.
7175 (Fisnan): Always define, since it's always available now.
7176 (syms_of_floatfns): Always define isnan at the Lisp level.
7177
e39b275c 71782011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7179
7180 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7181
b2db44d9 71822011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7183
f4af5137 7184 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7185 The previous code assumed that file offsets (off_t values) fit in
7186 EMACS_INT variables, which is not true on typical 32-bit hosts.
7187 The code messed up by falsely reporting buffer overflow in cases
7188 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7189 when "big" contains more than 2**29 bytes, even though this
7190 inserts just one byte and does not overflow the buffer.
7191 (Finsert_file_contents): Store file offsets as off_t
7192 values, not as EMACS_INT values. Check for overflow when
7193 converting between EMACS_INT and off_t. When checking for
7194 buffer overflow or for overlap, take the offsets into account.
7195 Don't use EMACS_INT for small values where int suffices.
7196 When checking for overlap, fix a typo: ZV was used where
7197 ZV_BYTE was intended.
7198 (Fwrite_region): Don't assume off_t fits into 'long'.
7199 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7200
ecfc0a49
MA
72012011-09-05 Michael Albinus <michael.albinus@gmx.de>
7202
7203 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7204
6511acf2 72052011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7206
0999621a 7207 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7208
7209 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7210 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7211 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7212 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7213 (modify_event_symbol): Do not assume that the length of
7214 name_alist_or_stem is safe to alloca and fits in int.
7215 (Fexecute_extended_command): Likewise for function name and binding.
7216 (Frecursion_depth): Wrap around reliably on integer overflow.
7217 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7218 since some callers pass EMACS_INT values.
7219 (Fsingle_key_description): Don't crash if symbol name contains more
7220 than MAX_ALLOCA bytes.
7221 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7222 (get_minibuffer): Arg is now EMACS_INT, not int.
7223 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7224 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7225 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7226
2be7d702
PE
7227 * dbusbind.c (signature_cat): New function.
7228 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7229 Do not overrun buffer; instead, report string overflow.
7230
9d1df220
PE
7231 * dispnew.c (add_window_display_history): Don't overrun buffer.
7232 Truncate instead; this is OK since it's just a log.
7233
33ef5c64
PE
7234 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7235 even if the time zone offset is outlandishly large.
7236 Don't mishandle offset == INT_MIN.
7237
66c6fdd5
PE
7238 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7239 when creating daemon; the previous buffer-overflow check was incorrect.
7240
d749b01b
PE
7241 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7242 which has the guts of the old verror function.
7243
b5cd1905
PE
7244 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7245 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7246
6e1a67fb
PE
7247 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7248 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7249 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7250 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7251 length of string rather than counting it via multiple sprintfs;
7252 that's simpler and more reliable.
c21721cc
PE
7253 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7254 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7255 sprintf, in case result does not fit in int.
7256
c57b67fc
PE
7257 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7258 (fontset_from_font): Print it.
7259
8a401434
PE
7260 * frame.c (tty_frame_count): Now printmax_t, not int.
7261 (make_terminal_frame, set_term_frame_name): Print it.
7262 (x_report_frame_params): In X, window IDs are unsigned long,
7263 not signed long, so print them as unsigned.
7264 (validate_x_resource_name): Check for implausibly long names,
7265 and don't assume name length fits in 'int'.
7266 (x_get_resource_string): Don't blindly alloca invocation name;
7267 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7268 not fit in int.
7269
6e1a67fb
PE
7270 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7271 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7272 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7273
0df02bf3
PE
7274 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7275 Use esprintf, not sprintf, in case result does not fit in int.
7276
48e30793
PE
7277 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7278 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7279 it as a large positive number.
7280 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7281 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7282
a66ff6d8
PE
7283 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7284 in case result does not fit in int.
7285
aca216ff
PE
7286 * print.c (float_to_string): Detect width overflow more reliably.
7287 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7288 buffer overrun. Don't assume list length fits in 'int'. Treat
7289 print length of 0 as 0, not as infinity; to be consistent with other
7290 uses of print length in this function. Don't overflow print length
7291 index. Don't assume hash table size fits in 'long', or that
7292 vectorlike size fits in 'unsigned long'.
7293
31c286f7
PE
7294 * process.c (make_process): Use printmax_t, not int, to format
7295 process-name gensyms.
7296
55e5faa1
PE
7297 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7298
80f2e268
PE
7299 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7300 to avoid potential buffer overrun.
7301
670741ab
PE
7302 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7303 if X resource line is longer than 512 bytes.
7304
b7163a50
PE
7305 * xfns.c (x_window): Make sprintf buffer a bit bigger
7306 to avoid potential buffer overrun.
7307
ae58ff1f
PE
7308 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7309
c43c8a6a
PE
7310 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7311
3f8236f4
PE
73122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7313
53e9fe90 7314 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7315 Without these, Emacs silently mishandles large integers sometimes.
7316 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7317 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7318
6511acf2
PE
7319 * xdisp.c (try_window_id): Check Emacs fixnum range before
7320 converting to 'int'.
806add1d 7321
6511acf2 7322 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7323 Check that an Emacs fixnum is in range before assigning it to 'int'.
7324 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7325 values converted from Emacs fixnums.
7326 (Frecenter): Don't wrap around a line count if it is out of 'int'
7327 range; instead, treat it as an extreme value.
7328 (Fset_window_configuration, compare_window_configurations):
7329 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7330
6511acf2
PE
7331 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7332 that can exceed INT_MAX. Check that EMACS_INT value is in range
7333 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7334 (match_limit): Don't assume that a fixnum can fit in 'int'.
7335
6511acf2 7336 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7337 exceed INT_MAX.
7338
6511acf2 7339 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7340 (Fvertical_motion): Don't wrap around LINES values that don't fit
7341 in 'int'. Instead, treat them as extreme values. This is good
7342 enough for windows, which can't have more than INT_MAX lines anyway.
7343
fcb901a7
LMI
73442011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7345
0f2f6b6d
LMI
7346 * Require libxml/parser.h to avoid compilation warning.
7347
fcb901a7
LMI
7348 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7349
7350 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7351 since this reportedly can destroy thread storage.
7352
6e20a0d4
CY
73532011-08-30 Chong Yidong <cyd@stupidchicken.com>
7354
7355 * syntax.c (find_defun_start): Update all cache variables if
7356 exiting early (Bug#9401).
7357
148ae00e
EZ
73582011-08-30 Eli Zaretskii <eliz@gnu.org>
7359
f6cfbd8f
EZ
7360 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7361
148ae00e
EZ
7362 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7363 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7364 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7365
7366 * term.c (tty_append_glyph): New function.
7367 (produce_stretch_glyph): Static function and its prototype deleted.
7368
a66cfb1c
SM
7369 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7370 Add prototypes.
148ae00e 7371
c4a07a4c
PE
73722011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7373
7374 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7375 when checking :margin (Bug#9390).
7376 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7377 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7378 so that the name doesn't mislead. All uses changed.
7379
6bc8cd65
JB
73802011-08-28 Johan Bockgård <bojohan@gnu.org>
7381
7382 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7383 set_tty_hooks.
7384
dca4927e
EZ
73852011-08-27 Eli Zaretskii <eliz@gnu.org>
7386
7387 * xdisp.c (move_it_to): Don't bail out early when reaching
7388 position beyond to_charpos, if we are scanning backwards.
7389 (move_it_vertically_backward): When DY == 0, make sure we get to
7390 the first character in the line after the newline.
7391
f2cad773
PE
73922011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7393
7394 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7395 (ccl_driver): Do not generate an out-of-range pointer.
7396 (Fccl_execute_on_string): Remove unnecessary check for
7397 integer overflow, noted by Stefan Monnier in
7398 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7399 Remove a FIXME that didn't need fixing.
7400 Simplify the newly-introduced buffer reallocation code.
7401
0cae2cdb
JB
74022011-08-27 Juanma Barranquero <lekktu@gmail.com>
7403
7404 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7405
5fc295a4 74062011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7407
70c60eb2 7408 Integer and memory overflow issues (Bug#9196).
726e0ab1 7409
d31850da
PE
7410 * doc.c (get_doc_string): Rework so that
7411 get_doc_string_buffer_size is the actual buffer size, rather than
7412 being 1 less than the actual buffer size; this makes xpalloc more
7413 convenient.
7414
a69fbedb
PE
7415 * image.c (x_allocate_bitmap_record, cache_image):
7416 * xselect.c (Fx_register_dnd_atom):
7417 Simplify previous changes by using xpalloc.
7418
fe5c5d37
PE
7419 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7420 since either will do and ptrdiff_t is convenient with xpalloc.
7421
0065d054
PE
7422 * charset.c (charset_table_size)
7423 (struct charset_sort_data.priority): Now ptrdiff_t.
7424 (charset_compare): Don't overflow if priorities differ greatly.
7425 (Fsort_charsets): Don't assume list length fits in int.
7426 Check for size-calculation overflow when allocating sort data.
7427 (syms_of_charset): Allocate an initial charset table that is
7428 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7429
7430 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7431
7432 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7433 The actual value is always <= INT_MAX, and leaving it unsigned made
7434 overflow checking harder.
7435
7436 * dispextern.h (struct glyph_matrix.rows_allocated)
7437 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7438 with xpalloc. The values are still always <= INT_MAX.
7439
7440 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7441
7442 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7443 (SAFE_NALLOCA): New macro.
7444
7445 * region-cache.c (struct boundary.pos, find_cache_boundary)
7446 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7447 (set_cache_region, invalidate_region_cache)
7448 (revalidate_region_cache, know_region_cache, region_cache_forward)
7449 (region_cache_backward, pp_cache):
7450 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7451 so that ptrdiff_t * can be passed to xpalloc.
7452 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7453 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7454 (pp_cache): Don't assume cache_len fits in int.
7455 * region-cache.h: Adjust extern decls to match.
7456
7457 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7458 EMACS_INT, since either will do, for xpalloc.
7459
7460 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7461 (xnmalloc, xnrealloc, xpalloc): New functions.
7462
726e0ab1
PE
7463 * bidi.c (bidi_shelve_header_size): New constant.
7464 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7465 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7466
51f30bc5 7467 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7468 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7469 (overlay_strings):
7470 Don't update size of array until after memory allocation succeeds,
7471 because xmalloc/xrealloc may not return.
0065d054
PE
7472 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7473 now that we have proper integer overflow checking.
7474 (record_overlay_string, overlay_strings): Catch overflows when
7475 calculating size of overlay_str_buf.
726e0ab1 7476
0065d054
PE
7477 * callproc.c (Fcall_process): Check for size overflow when
7478 calculating size of args2.
7479 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7480 Normally we prefer signed values, but sticking with ptrdiff_t would
7481 require adding more-complicated checks.
726e0ab1
PE
7482
7483 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7484 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7485 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7486 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7487
7488 * character.c (Fstring): Check for size-calculation overflow.
7489
7490 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7491 unnecessary integer overflow. Check for size overflow.
7492 (encode_coding_object): Don't update size until xmalloc succeeds.
7493
7494 * composite.c (get_composition_id): Check for overflow in glyph
7495 length calculations.
7496
7497 Integer and memory overflow fixes for display code.
7498 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7499 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7500 (scrolling_window): Check for overflow in size calculations.
7501 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7502 Don't assume glyph table len fits in int.
7503 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7504 (row_table_size): Now ptrdiff_t, not int.
7505 (scrolling_window): Avoid overflow in size calculations.
7506 Don't update size until allocation succeeds.
7507 * fns.c (concat): Check for overflow in size calculations.
7508 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7509 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7510 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7511
7512 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7513 (get_doc_string): Check for size calculation overflow.
7514 Don't update size until allocation succeeds.
7515 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7516 EMACS_INT, where ptrdiff_t will do.
7517 (Fsubstitute_command_keys): Check for string overflow.
7518
7519 * editfns.c (set_time_zone_rule): Don't assume environment length
7520 fits in int.
7521 (message_length): Now ptrdiff_t, not int.
7522 (Fmessage_box): Don't update size until allocation succeeds.
7523 Don't assume message length fits in int.
7524 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7525
0065d054
PE
7526 * emacs.c (main): Do not reallocate argv, since there is a null at
7527 the end that can be overwritten, and this way there's no need to
7528 worry about size-calculation overflow.
7529 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7530
7531 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7532 alloc succeeds.
7533 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7534
7535 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7536 (x_set_scroll_bar_width, x_figure_window_size):
7537 Check for integer overflow.
7538 (x_set_alpha): Do not assume XINT fits in int.
7539
7540 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7541 This is for the members text_lines, text_cols, total_lines, total_cols,
7542 where the system imposes an 'int' limit.
7543
7544 * fringe.c (Fdefine_fringe_bitmap):
7545 Don't update size until alloc works.
7546
7547 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7548 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7549
7550 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7551 Check for size-calculation overflow.
7552 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7553 do, as we prefer signed integers.
7554 (id_to_widget.max_size, id_to_widget.used)
7555 (xg_store_widget_in_map, xg_remove_widget_from_map)
7556 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7557 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7558 Use and return ptrdiff_t, not int.
7559 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7560 * gtkutil.h: Change prototypes to match the above.
7561
7562 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7563 are duplicate now that they've been promoted to lisp.h.
7564 (x_allocate_bitmap_record, x_alloc_image_color)
7565 (make_image_cache, cache_image, xpm_load):
7566 Don't update size until alloc is done.
7567 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7568 (x_detect_edges):
3256efce 7569 Check for size calculation overflow.
726e0ab1
PE
7570 (ct_colors_allocated_max): New constant.
7571 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7572 overflow.
3256efce 7573
726e0ab1
PE
7574 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7575 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7576 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7577 Use ptrdiff_t, not int, to count maps.
7578 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7579 calculations. Don't update size until allocation succeeds.
7580 Redo calculations to avoid overflow.
726e0ab1
PE
7581 * keyboard.h: Change prototypes to match the above.
7582
7583 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7584 to count maps.
7585 (current_minor_maps): Check for size calculation overflow.
7586 * keymap.h: Change prototypes to match the above.
7587
7588 * lread.c (read1, init_obarray): Don't update size until alloc done.
7589
7590 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7591 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7592
726e0ab1
PE
7593 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7594 Now ptrdiff_t, not int.
7595 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7596 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7597
7598 * process.c (Fnetwork_interface_list): Check for overflow
7599 in size calculation.
7600
7601 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7602
7603 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7604 overflow. Don't bother calling xmalloc when xrealloc will do.
7605
7606 * search.c (Freplace_match): Check for size calculation overflow.
7607 (Fset_match_data): Don't assume list lengths fit in 'int'.
7608
7609 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7610 for command line length. Do not attempt to address one before the
7611 beginning of an array, as that's not portable.
7612
7613 * term.c (max_frame_lines): Remove; unused.
7614 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7615 not int.
7616 (encode_terminal_code, calculate_costs): Check for size
7617 calculation overflow.
7618 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7619 table lengths and related sizes. Don't update size until alloc
7620 done. Redo calculations to avoid overflow.
7621 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7622
7623 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7624 subtracting pointers.
7625 (gobble_line): Check for overflow more carefully. Don't update size
7626 until alloc done.
7627
7628 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7629 Don't update size until alloc done.
7630 Redo size calculations to avoid overflow.
7631 Check for size calculation overflow.
0065d054 7632 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7633
7634 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7635 Use ptrdiff_t, not int, for sizes.
7636 (store_mode_line_noprop_char): Don't update size until alloc done.
7637
0065d054
PE
7638 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7639 Use ptrdiff_t, not int, for sizes.
7640 (Finternal_make_lisp_face, cache_face):
7641 Check for size calculation overflow.
7642 (cache_face): Treat size calculation overflows as if they were
7643 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7644
7645 * xfns.c (x_encode_text, x_set_name_internal)
7646 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7647 sizes, since they can exceed INT_MAX in size. Check for size
7648 calculation overflow.
7649
0065d054
PE
7650 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7651 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7652 Don't update size until alloc done.
7653
0065d054 7654 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7655 as sprintf is limited to int lengths.
1d526e2f 7656
252c5ee1
PE
7657 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7658 (X_LONG_MIN): New macros.
864d7ce7
PE
7659 Use them to make the following changes clearer.
7660 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7661 This change doesn't affect the value now, but it may help remind
7662 future maintainers not to raise the value too much later.
7663 (SELECTION_QUANTUM): Remove, replacing with ...
7664 (selection_quantum): ... new function, which avoids overflow.
7665 All uses changed.
7666 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7667 assumption that selection length fits in 'int'.
7668 (x_reply_selection_request, x_handle_selection_request)
7669 (x_get_window_property, receive_incremental_selection)
7670 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7671 (lisp_data_to_selection_data, clean_local_selection_data):
7672 Use ptrdiff_t, not int, to record length of selection.
7673 (x_reply_selection_request, x_get_window_property)
7674 (receive_incremental_selection, x_property_data_to_lisp):
7675 Redo calculations to avoid overflow.
7676 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7677 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7678 something.
7679 (x_get_window_property, receive_incremental_selection)
7680 (lisp_data_to_selection_data, x_property_data_to_lisp):
7681 Check for size-calculation overflow.
7682 (x_get_window_property, receive_incremental_selection)
7683 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7684 Don't store size until memory allocation succeeds.
7685 (x_get_window_property): Plug memory leak on memory exhaustion.
7686 Don't double-block input; malloc is safe here. Don't assume 2**34
7687 - 4 fits in unsigned long. Add an xassert to check
7688 XGetWindowProperty overflow. Be more careful about overflow
7689 calculations, and distinguish size from memory overflow better.
7690 (receive_incremental_selection): When tracing, don't assume
7691 unsigned int is less than INT_MAX.
7692 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7693 harmful) conversions of unsigned short to int.
7694 (lisp_data_to_selection_data): Don't assume that integers
7695 in the range -65535 through -1 fit in an X unsigned short.
7696 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7697 result parameters unless successful. Rely on cons_to_unsigned
7698 to report problems with elements; the old code wasn't right anyway.
7699 (x_check_property_data): Check for int overflow; we cannot use
7700 a wider type due to X limits.
7701 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7702
726e0ab1 7703 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7704
0065d054
PE
7705 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7706 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7707 (x_color_cells): Don't store size until memory allocation succeeds.
7708 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7709 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7710 (x_term_init): Don't assume length fits in int (sprintf is limited
7711 to int size).
bc18e09d 7712
ebfa62c0
PE
7713 Use ptrdiff_t for composition IDs.
7714 * character.c (lisp_string_width):
7715 * composite.c (composition_table_size, n_compositions)
7716 (get_composition_id, composition_gstring_from_id):
7717 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7718 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7719 * window.c (Frecenter):
7720 Use ptrdiff_t, not int, for composition IDs.
7721 * composite.c (get_composition_id): Check for integer overflow.
7722 * composite.h: Adjust prototypes to match the above changes.
7723
d3411f89
PE
7724 Use ptrdiff_t for hash table indexes.
7725 * category.c (hash_get_category_set):
7726 * ccl.c (ccl_driver):
7727 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7728 * coding.c (coding_system_charset_list, detect_coding_system):
7729 * coding.h (struct coding_system.id):
7730 * composite.c (get_composition_id, gstring_lookup_cache):
7731 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7732 * image.c (xpm_get_color_table_h):
7733 * lisp.h (hash_lookup, hash_put):
7734 * minibuf.c (Ftest_completion):
7735 Use ptrdiff_t for hash table indexes, not int (which is too
7736 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7737 32-bit --with-wide-int hosts).
7738
e097a6fa
PE
7739 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7740 Add a FIXME comment about memory leaks.
7741 (syms_of_charset): Don't assume xmalloc returns.
7742
5637687f
PE
7743 Don't assume that stated character widths fit in int.
7744 * character.c (Fchar_width, c_string_width, lisp_string_width):
7745 * character.h (CHAR_WIDTH):
7746 * indent.c (MULTIBYTE_BYTES_WIDTH):
7747 Use sanitize_char_width to avoid undefined and/or bad behavior
7748 with outlandish widths.
a66cfb1c 7749 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7750 now that we have two such functions. All uses changed.
7751 (sanitize_char_width): New inline function.
7752
a2271ba2
PE
7753 Don't assume that tab-width fits in int.
7754 * character.h (sanitize_width): New inline function.
7755 (SANE_TAB_WIDTH): New macro.
7756 (ASCII_CHAR_WIDTH): Use it.
7757 * indent.c (sane_tab_width): Remove. All uses replaced by
7758 SANE_TAB_WIDTH (current_buffer).
7759 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7760
18c52557
PE
7761 * fileio.c: Integer overflow issues with file modes.
7762 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7763
caeeedc1
PE
7764 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7765 Remove unreachable code.
7766 (read_hex, load_charset_map_from_file): Check for integer overflow.
7767
6df6ae42 7768 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7769 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7770 (x_send_scroll_bar_event): Likewise. Check that the size does not
7771 exceed limits imposed by XClientMessageEvent, as well as the usual
7772 ptrdiff_t and size_t limits.
7773
b13995db
PE
7774 * keyboard.c: Overflow, signedness and related fixes.
7775 (make_lispy_movement): Use same integer type in forward decl
7776 that is used in the definition.
7777 (read_key_sequence, keyremap_step):
7778 Change bufsize argument back to int, undoing my 2011-03-30 change.
7779 We prefer signed types, and int is wide enough here.
7780 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7781 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7782 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7783 length, not size_t. Use ptrdiff_t for index, not int.
7784 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7785 possibility of integer overflow.
7786
13464394
PE
7787 Overflow, signedness and related fixes for images.
7788
7789 * dispextern.h (struct it.stack[0].u.image.image_id)
7790 (struct_it.image_id, struct image.id, struct image_cache.size)
7791 (struct image_cache.used, struct image_cache.ref_count):
7792 * gtkutil.c (update_frame_tool_bar):
7793 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7794 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7795 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7796 * nsmenu.m (update_frame_tool_bar):
7797 * xdisp.c (calc_pixel_width_or_height):
7798 * xfns.c (image_cache_refcount):
7799 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7800 on typical 64-bit hosts.
7801
7802 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7803 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7804 Omit unnecessary casts to int.
7805 (parse_image_spec): Check that integers fall into 'int' range
7806 when the callers expect that.
7807 (image_ascent): Redo ascent calculation to avoid int overflow.
7808 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7809 (lookup_image): Remove unnecessary tests.
7810 (xbm_image_p): Locals are now of int, not EMACS_INT,
7811 since parse_image_check makes sure they fit into int.
7812 (png_load, gif_load, svg_load_image):
7813 Prefer int to unsigned where either will do.
7814 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7815 old tiff_error_handler and tiff_warning_handler.
7816 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7817 stack buffer overflows. It uses only the features of vsnprintf
7818 that are common to both POSIX and native Microsoft.
7819 (tiff_error_handler, tiff_warning_handler): Use it.
7820 (tiff_load, gif_load, imagemagick_load_image):
7821 Don't assume :index value fits in 'int'.
7822 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7823 (imagemagick_load_image): Check that crop parameters fit into
7824 the integer types that MagickCropImage accepts. Don't assume
7825 Vimagemagick_render_type has a nonnegative value. Don't assume
7826 size_t fits in 'long'.
7827 (gs_load): Use printmax_t to print the widest integers possible.
7828 Check for integer overflow when computing image height and width.
7829
c11821d4
EZ
78302011-08-26 Eli Zaretskii <eliz@gnu.org>
7831
7832 * xdisp.c (redisplay_window): Don't force window start if point
7833 will be invisible in the resulting window. (Bug#9324)
7834
0c95fcf7
EZ
78352011-08-25 Eli Zaretskii <eliz@gnu.org>
7836
7837 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7838 the display spec is of the form `(space ...)'.
7839 (handle_display_spec): Return the value returned by
7840 handle_single_display_spec, not just 1 or zero.
7841 (handle_single_display_spec): If the display spec is of the form
7842 `(space ...)', and specifies display in the text area, return 2
7843 rather than 1.
fee65a97 7844 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7845 accurately, and prefer exact match for point under bidi.
7846 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7847
7848 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7849 into disp_prop; all users changed.
7850
7851 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7852 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7853 for the text covered by the display property.
7854
e4ed06f1
CY
78552011-08-25 Chong Yidong <cyd@stupidchicken.com>
7856
7857 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7858 Change return value to nil.
7859 (Frecord_buffer): Delete unused function.
7860
f67cdd7f
EZ
78612011-08-24 Eli Zaretskii <eliz@gnu.org>
7862
5980d4c6
EZ
7863 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7864 buffers, return left-to-right.
8610fe8b
EZ
7865 (set_cursor_from_row): Consider candidate row a win if its glyph
7866 represents a newline and point is on that newline. Fixes cursor
7867 positioning on the newline at EOL of R2L text within L2R
7868 paragraph, and vice versa.
7869 (try_cursor_movement): Check continued rows, in addition to
7870 continuation rows. Fixes unwarranted scroll when point enters a
7871 continued line of R2L text within an L2R paragraph, or vice versa.
7872 (cursor_row_p): Consider the case of point being equal to
7873 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7874 from the end of a short line to the beginning of a continued line
7875 of R2L text within L2R paragraph.
7876 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7877 composed characters.
5980d4c6 7878
f67cdd7f
EZ
7879 * bidi.c (bidi_check_type): Use xassert.
7880 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7881 members.
7882
bca633fb
EZ
78832011-08-23 Eli Zaretskii <eliz@gnu.org>
7884
7885 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7886 a character.
7887
4a5885a7
CY
78882011-08-23 Chong Yidong <cyd@stupidchicken.com>
7889
7890 * nsfont.m (ns_otf_to_script): Fix typo.
7891
0902a04e
KH
78922011-08-22 Kenichi Handa <handa@m17n.org>
7893
7894 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7895 extra slot even if the purpose is char-code-property-table.
7896
1a2e6670
EZ
78972011-08-23 Eli Zaretskii <eliz@gnu.org>
7898
8ddde651
EZ
7899 * xdisp.c (redisplay_window): When computing centering_position,
7900 account for the height of the header line. (Bug#8874)
7901
425cc014
EZ
7902 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7903 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7904 candidate is selected by the mouse, and that candidate has a
7905 composed character under the mouse.
7906
1a2e6670
EZ
7907 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7908 coordinates reported by pos-visible-in-window-p for a composed
7909 character in column zero.
7910
8b76d6f8
SM
79112011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7912
7913 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7914
dac347dd
EZ
79152011-08-22 Eli Zaretskii <eliz@gnu.org>
7916
7917 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7918 consider it a hit if to_charpos is anywhere in the range of the
7919 composed buffer positions.
7920
e013fb34
CY
79212011-08-22 Chong Yidong <cyd@stupidchicken.com>
7922
7923 * image.c (gif_load): Don't assume that each subimage has the same
7924 dimensions as the base image. Handle disposal method that is
7925 "undefined" by the gif spec (Bug#9335).
7926
bd1ba3e8
CY
79272011-08-20 Chong Yidong <cyd@stupidchicken.com>
7928
7929 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7930 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7931
54a1215b
EZ
79322011-08-19 Eli Zaretskii <eliz@gnu.org>
7933
823564e5
EZ
7934 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7935 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7936 from an Org mode buffer to a Speedbar frame.
7937
54a1215b
EZ
7938 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7939 a composition, take its buffer position from IT->cmp_it.charpos.
7940 Fixes cursor positioning at the beginning of a line that begins
7941 with a composed character.
7942
9778ebcc
EZ
79432011-08-18 Eli Zaretskii <eliz@gnu.org>
7944
0be6ee06
EZ
7945 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7946 character bidirectional type, use STRONG_L instead. Fixes crashes
7947 in a buffer produced by `describe-categories'.
7948
9778ebcc
EZ
7949 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7950 members before the level stack, so they would be saved and
7951 restored when copying iterator state. Fixes incorrect reordering
7952 around TABs covered by display properties.
7953
156bffbe
AS
79542011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7955
6b02f655 7956 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7957
72ad093b
CY
79582011-08-17 Chong Yidong <cyd@stupidchicken.com>
7959
7960 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7961 (internal_condition_case_2, internal_condition_case_n):
7962 Remove unnecessary aborts (Bug#9081).
72ad093b 7963
35774242
EZ
79642011-08-17 Eli Zaretskii <eliz@gnu.org>
7965
7966 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7967 has no `load' handler, try opening the file locally. (Bug#9311)
7968
db76dd85
KB
79692011-08-16 Ken Brown <kbrown@cornell.edu>
7970
7971 * gmalloc.c: Expand comment.
7972
b215eee5
EZ
79732011-08-16 Eli Zaretskii <eliz@gnu.org>
7974
7975 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7976 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7977
a4579d33
KB
79782011-08-16 Ken Brown <kbrown@cornell.edu>
7979
7980 Fix memory allocation problems in Cygwin build (Bug#9273).
7981
7982 * unexcw.c ( __malloc_initialized): Declare external variable.
7983 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7984
8b76d6f8
SM
7985 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7986 New variables.
a4579d33
KB
7987 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7988 dumped emacs.
7989 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7990 in the static heap.
7991 [CYGWIN] (special_realloc): New function.
7992 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7993 requests to realloc storage in the static heap.
7994
3ebec551
PE
79952011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7996
7997 * bidi.c (bidi_initialize): Remove unused local.
7998
9fd8be00
EZ
79992011-08-15 Eli Zaretskii <eliz@gnu.org>
8000
6b02f655
SM
8001 * bidimirror.h:
8002 * biditype.h: Remove file.
8003 * makefile.w32-in ($(BLD)/bidi.$(O)):
8004 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8005
8006 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8007
8008 * chartab.c: Improve commentary for the uniprop_table API.
8009
32413314
EZ
8010 * bidi.c (bidi_paragraph_init): Support zero value of
8011 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8012 (bidi_initialize): Use uniprop_table instead of including
8013 biditype.h and bidimirror.h.
32413314 8014
9fd8be00
EZ
8015 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8016 coordinates of the iterator when restoring from ppos_it.
8017 (Bug#9296)
8018
5cf2b69b
KH
80192011-08-14 Kenichi Handa <handa@m17n.org>
8020
8021 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8022 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8023
daf17d00
EZ
80242011-08-14 Eli Zaretskii <eliz@gnu.org>
8025
8026 * xdisp.c (move_it_in_display_line_to): Don't invoke
8027 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8028 ppos_it. Fixes vertical cursor motion when line beginning is
8029 covered by an image. (Bug#9296)
8030
08e3161a
JD
80312011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8032
8033 * nsterm.h (ns_run_ascript): Declare.
8034 (NSAPP_DATA2_RUNASSCRIPT): Define.
8035
8036 * nsfns.m (as_script, as_result, as_status): New static variables.
8037 (ns_run_ascript): New function.
5e617bc2 8038 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8039 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8040 the event loop. Get status from as_status (Bug#7276).
8041
8042 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8043 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8044 the event loop (Bug#7276).
8045
a3720aa2
AS
80462011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8047
8048 * gnutls.c (QCgnutls_bootprop_priority)
8049 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8050 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8051 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8052 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8053 (QCgnutls_bootprop_verify_hostname_error)
8054 (QCgnutls_bootprop_callbacks_verify): Rename from
8055 Qgnutls_bootprop_..., all uses changed.
8056
8057 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8058 uses changed.
8059
0a0d27fb
PE
80602011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8061
19d5c50c
PE
8062 * xfaces.c (Qframe_set_background_mode): Now static.
8063 * dispextern.h (Qframe_set_background_mode): Remove decl.
8064
0a0d27fb
PE
8065 * process.c (Fnetwork_interface_info): Declare local only if needed.
8066
377538cb
JD
80672011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8068
8069 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8070 (Fnetwork_interface_list): Allocate in increments of bytes instead
8071 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8072 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8073 sockaddr.
8074 (struct ifflag_def): notrailers is smart on OSX.
8075 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8076 Get hardware address with getifaddrs if available.
8077
08fff70c
EZ
80782011-08-12 Eli Zaretskii <eliz@gnu.org>
8079
8080 * xdisp.c (iterate_out_of_display_property): xassert that
8081 IT->position is set to within IT->object's boundaries. Break from
8082 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8083 when IT->position is set up wrongly due to some bug.
8084 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8085 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8086 entry. Force push_it to save on the stack the current
8087 buffer/string position, to be restored by pop_it. Fix flags in
8088 the iterator structure wrt the object coming from a display
8089 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8090 properties. (Bug#9284)
8091
7be1c708 80922011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8093
7be1c708
CY
8094 * fontset.c (fontset_get_font_group): Add proper type checks.
8095 (Bug#9172)
aac0c6e3 8096
7be1c708 80972011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8098
7be1c708
CY
8099 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8100 and LC_VERSION_MIN_MACOSX.
8101 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8102 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8103
97bb72a6
EZ
81042011-08-08 Eli Zaretskii <eliz@gnu.org>
8105
8106 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8107 no-display-properties-and-no-overlays under bidi display.
8108 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8109 properties and overlays.
97bb72a6 8110
d5617611
CY
81112011-08-08 Chong Yidong <cyd@stupidchicken.com>
8112
37e11a63
CY
8113 * editfns.c (Fset_time_zone_rule): Document relationship with the
8114 setenv function.
8115
d5617611
CY
8116 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8117 the font entity extracted from the cache (Bug#8109).
8118
58872834
CY
81192011-08-07 Chong Yidong <cyd@stupidchicken.com>
8120
8121 * composite.c (autocmp_chars): Don't reset point. That is done by
8122 restore_point_unwind (Bug#5984).
8123
75bfc667
JL
81242011-08-07 Juri Linkov <juri@jurta.org>
8125
8126 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8127 to show the arg `TIME' instead of `TIMEVAL'.
8128
d1410150
EZ
81292011-08-06 Eli Zaretskii <eliz@gnu.org>
8130
8131 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8132 display property strides EOL and includes a newline, as in
8133 longlines-mode. (Bug#9254)
75b771e4
EZ
8134 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8135 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8136
8137 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8138 is non-zero, even if the data buffer is NULL. Fixes a crash in
8139 vertical-motion with longlines-mode. (Bug#9254)
8140
35928349
EZ
81412011-08-05 Eli Zaretskii <eliz@gnu.org>
8142
ec7cc85b
EZ
8143 * bidi.c <bidi_cache_total_alloc>: Now static.
8144 (bidi_initialize): Initialize bidi_cache_total_alloc.
8145
8b76d6f8 8146 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8147 cache. (Bug#9221)
8148
8149 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8150 amount allocated this far in `bidi_cache_total_alloc'.
8151 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8152 non-zero, only free the data buffer without restoring the cache
8153 contents. All callers changed.
8154
8155 * dispextern.h (bidi_unshelve_cache): Update prototype.
8156
8157 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8158 (move_it_in_display_line, move_it_to)
8159 (move_it_vertically_backward, move_it_by_lines): Replace the call
8160 to xfree to an equivalent call to bidi_unshelve_cache.
8161 (move_it_in_display_line_to): Fix logic of returning
412b6358 8162 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8163
e2e2423b
EZ
81642011-08-05 Eli Zaretskii <eliz@gnu.org>
8165
8166 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8167 came from a string character with a `cursor' property. (Bug#9229)
8168
ae9e757a
JD
81692011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8170
8171 * Makefile.in (LIB_PTHREAD): New variable.
8172 (LIBES): Add LIB_PTHREAD (Bug#9216).
8173
8174 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8175 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8176
213bd7f2
AS
81772011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8178
6b02f655 8179 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8180
99aaf75f
JD
81812011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8182
8183 * xterm.c (x_find_topmost_parent): New function.
8184 (x_set_frame_alpha): Find topmost parent window with
8185 x_find_topmost_parent and set the property there also (bug#9181).
8186 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8187
c74e9d86
PE
81882011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8189
8190 * callproc.c (Fcall_process): Avoid vfork clobbering
8191 the local vars buffer, coding_systems, current_dir.
8192
640c8776
SM
81932011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8194
8195 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8196
f26d0e4c
PE
81972011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8198
8a10d76c
PE
8199 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8200 so that it is not optimized away.
8201
f26d0e4c
PE
8202 * xdisp.c (compute_display_string_pos): Remove unused local.
8203
55439c61
EZ
82042011-08-02 Eli Zaretskii <eliz@gnu.org>
8205
8206 Fix slow cursor motion and scrolling in large buffers with
8207 selective display, like Org Mode buffers. (Bug#9218)
8208
8209 * dispextern.h (struct bidi_it): New member disp_prop_p.
8210
8211 * xdisp.c: Remove one-slot cache of display string positions.
8212 (compute_display_string_pos): Accept an additional argument
5e617bc2 8213 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8214 for a display string or property. If found, set DISP_PROP_P
8215 non-zero.
8216
8217 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8218 DISP_PROP_P, and pass it to compute_display_string_pos.
8219 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8220 non-zero. All callers of bidi_fetch_char changed.
8221
fb33fa43
SM
82222011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8223
8224 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8225
b099e063
DM
82262010-12-03 Don March <don@ohspite.net>
8227
8228 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8229 last character M-[char] is translated to ESC [char] (bug#7541).
8230
5cc7f7af
KH
82312011-08-02 Kenichi Handa <handa@m17n.org>
8232
d0fffa3f 8233 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8234
8235 * chartab.c (uniprop_table): Make it non-static.
8236
525d5e6e
EZ
82372011-08-01 Eli Zaretskii <eliz@gnu.org>
8238
8239 * xdisp.c (forward_to_next_line_start): Accept additional argument
8240 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8241 on the newline.
8242 (reseat_at_next_visible_line_start): Use the bidi iterator state
8243 returned by forward_to_next_line_start to restore the state of
8244 it->bidi_it after backing up to previous newline. (Bug#9212)
8245
31011111
AS
82462011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8247
8248 * regex.c (re_comp): Protoize.
8249 (re_exec): Fix return type.
8250 (regexec): Fix type of `ret'. (Bug#9203)
8251
476371c4
PE
82522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8253
e5d76069
PE
8254 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8255 This is needed if max-image-size is a floating-point number.
8256
9a79b20c
AS
82572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8258
8259 * print.c (print_object): Print empty symbol as ##.
8260
8261 * lread.c (read1): Read ## as empty symbol.
8262
d8c2fa78
AA
82632011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8264
8265 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8266 setting frame foreground color (Bug#9175).
8267 (x_set_background_color): Likewise.
8268
ffe57a7a
AA
8269 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8270 contents (Bug#9176).
8271 (EmacsTooltip -init): Remove bezels and add shadows to
8272 tooltip windows.
8273
bf3492a5
AA
8274 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8275 or scroll bar (Bug#8470).
8276
d55e9c53
AA
8277 * nsfont.m (nsfont_open): Remove assignment to voffset and
8278 unnecessary vars hshink, expand, hd, full_height, min_height.
8279 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8280
8281 * nsterm.h (nsfont_info): Remove voffset field.
8282
d8c2fa78 82832011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8284
8285 Implement strike-through and overline on NextStep (Bug#8863).
8286
8287 * nsfont.m (nsfont_open): Use underline position provided by font,
8288 instead of hard-coded value of 2.
8289 (nsfont_draw): Call ns_draw_text_decoration instead.
8290
8291 * nsterm.h: Add declaration for ns_draw_text_decoration.
8292
8293 * nsterm.m (ns_draw_text_decoration): New function for drawing
8294 underline, overline, and strike-through.
8295 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8296 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8297 accommodate underlining, etc.
4843aac3 8298
4cc60b9b
EZ
82992011-07-28 Eli Zaretskii <eliz@gnu.org>
8300
bc7ece87
EZ
8301 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8302 default.
4cc60b9b 8303
476371c4
PE
83042011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8305
66606eea
PE
8306 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8307 Without this fix, if a signal arrives just after memory fills up,
8308 'malloc' might be invoked reentrantly.
8309
476371c4
PE
8310 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8311 In other words, assume that every image size is allowed, on non-X
8312 hosts. This assumption is probably wrong, but it lets Emacs compile.
8313
f3fcc40d
AS
83142011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8315
8316 * regex.c (re_iswctype): Convert return values to boolean.
8317
350c992f
EZ
83182011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8319
8320 * xdisp.c (compute_display_string_pos): Don't use cached display
8321 string position if the buffer had its restriction changed.
8322 (Bug#9184)
8323
5266b4bb
PE
83242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8325
8326 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8327
2573a837 83282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8329
41f55ccd 8330 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8331
39e378da
PE
8332 * bidi.c: Integer size and overflow fixes.
8333 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8334 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8335 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8336 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8337 (bidi_find_other_level_edge):
8338 Use ptrdiff_t instead of EMACS_INT where either will do.
8339 This works better on 32-bit hosts configured --with-wide-int.
8340 (bidi_cache_ensure_space): Check for size-calculation overflow.
8341 Use % rather than repeated addition, for better worst-case speed.
8342 Don't set bidi_cache_size until after xrealloc returns, because it
8343 might not return.
8344 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8345 (bidi_cache_ensure_space): Also check that the bidi cache size
8346 does not exceed that of the largest Lisp string or buffer. See Eli
8347 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8348
5e927815
PE
8349 * alloc.c (__malloc_size_t): Remove.
8350 All uses replaced by size_t. See Andreas Schwab's note
8351 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8352
ca4aa935
PE
8353 * image.c: Improve checking for integer overflow.
8354 (check_image_size): Assume that f is nonnull, since
8355 it is always nonnull in practice. This is one less thing to
8356 worry about when checking for integer overflow later.
8357 (x_check_image_size): New function, which checks for integer
8358 overflow issues inside X.
8359 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8360 This removes the need for a memory_full check.
8361 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8362 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8363 (xbm_read_bitmap_data): Change locals back to 'int', since
8364 their values must fit in 'int'.
8365 (xpm_load_image, png_load, tiff_load):
8366 Invoke x_create_x_image_and_pixmap earlier,
8367 to avoid much needless work if the image is too large.
8368 (tiff_load): Treat overly large images as if
8369 x_create_x_image_and_pixmap failed, not as malloc failures.
8370 (gs_load): Use x_check_image_size.
8371
5f8f9cc2
PE
8372 * gtkutil.c: Omit integer casts.
8373 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8374 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8375
5adf60bc
PE
8376 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8377
c8907a93
PE
8378 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8379 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8380 would wrongly return t on a 64-bit host.
8381
e3c25c68
PE
8382 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8383 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8384 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8385 and therefore cause GCC to emit a bogus diagnostic in some cases.
8386
3f791afe
PE
8387 * image.c: Integer signedness and overflow and related fixes.
8388 This is not an exhaustive set of fixes, but it's time to
8389 record what I've got.
8390 (lookup_pixel_color, check_image_size): Remove redundant decls.
8391 (check_image_size): Don't assume that arbitrary EMACS_INT values
8392 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8393 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8394 (tiff_load, imagemagick_load_image):
8395 Check for overflow in size calculations.
8396 (x_create_x_image_and_pixmap): Remove unnecessary test for
8397 xmalloc returning NULL; that can't happen.
8398 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8399 (xpm_color_bucket): Use better integer hashing function.
8400 (xpm_cache_color): Don't possibly over-allocate memory.
8401 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8402 (gif_memory_source):
8403 Use ptrdiff_t, not int or size_t, to record sizes.
8404 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8405 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8406 either works, as we prefer signed integers.
8407 (tiff_read_from_memory, tiff_write_from_memory):
8408 Return tsize_t, not size_t, since that's what the TIFF API wants.
8409 (tiff_read_from_memory): Don't fail simply because the read would
8410 go past EOF; instead, return a short read.
8411 (tiff_load): Omit no-longer-needed casts.
8412 (Fimagemagick_types): Don't assume size fits into 'int'.
8413
3cc5a532
PE
8414 Improve hashing quality when configured --with-wide-int.
8415 * fns.c (hash_string): New function, taken from sxhash_string.
8416 Do not discard information about ASCII character case; this
8417 discarding is no longer needed.
8418 (sxhash-string): Use it. Change sig to match it. Caller changed.
8419 * lisp.h: Declare it.
8420 * lread.c (hash_string): Remove, since we now use fns.c's version.
8421 The fns.c version returns a wider integer if --with-wide-int is
8422 specified, so this should help the quality of the hashing a bit.
8423
b312a492
PE
8424 * emacs.c: Integer overflow minor fix.
8425 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8426 Define only if GNU_LINUX.
8427 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8428
dfd153ae
PE
8429 * dispnew.c: Integer signedness and overflow fixes.
8430 Remove unnecessary forward decls, that were a maintenance hassle.
8431 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8432 All uses changed.
8433 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8434 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8435 (prepare_desired_row, line_draw_cost):
8436 Use int, not unsigned, where either works.
8437 (save_current_matrix, restore_current_matrix):
8438 Use ptrdiff_t, not size_t, where either works.
8439 (init_display): Check for overflow more accurately, and without
8440 relying on undefined behavior.
8441
a81d11a3
PE
8442 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8443 Remove, replacing with the new symbols in lisp.h. All uses changed.
8444 * fileio.c (make_temp_name):
8445 * filelock.c (lock_file_1, lock_file):
8446 * xdisp.c (message_dolog):
8447 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8448 Use pMd etc. instead.
8449 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8450 replacing the pWIDE etc. symbols removed from editfns.c.
8451
3300e6fd
PE
8452 * keyboard.h (num_input_events): Now uintmax_t.
8453 This is (very slightly) less likely to mess up due to wraparound.
8454 All uses changed.
8455
fd05c7e9
PE
8456 * buffer.c: Integer signedness fixes.
8457 (alloc_buffer_text, enlarge_buffer_text):
8458 Use ptrdiff_t rather than size_t when either will do, as we prefer
8459 signed integers.
8460
903fe15d
PE
8461 * alloc.c: Integer signedness and overflow fixes.
8462 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8463 (__malloc_size_t): Default to size_t, not to int.
8464 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8465 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8466 Prefer ptrdiff_t to size_t when either would do, as we prefer
8467 signed integers.
8468 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8469 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8470 Now const. Initialize with values that are in range even if char
8471 is signed.
8472 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8473 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8474 These functions do the right thing with sizes > 2**32.
8475 (check_depth): Now ptrdiff_t, not int.
8476 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8477 Adjust to new way of storing sizes. Check for size overflow bugs
8478 in rest of code.
8479 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8480 slightly wrong anyway, as it missed one instance of
8481 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8482 (refill_memory_reserve): Omit needless cast to size_t.
8483 (mark_object_loop_halt): Mark as externally visible.
8484
ac82cc6a
PE
8485 * xselect.c: Integer signedness and overflow fixes.
8486 (Fx_register_dnd_atom, x_handle_dnd_message):
8487 Use ptrdiff_t, not size_t, since we prefer signed.
8488 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8489 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8490 x_dnd_atoms_size and x_dnd_atoms_length.
8491
c2d1e36d
PE
8492 * doprnt.c: Prefer signed to unsigned when either works.
8493 * eval.c (verror):
8494 * doprnt.c (doprnt):
8495 * lisp.h (doprnt):
8496 * xdisp.c (vmessage):
8497 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8498 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8499 prefer signed arithmetic to avoid comparison confusion.
8500 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8501 but is a bit tricky.
8502
0e926e56
PE
8503 Assume freestanding C89 headers, string.h, stdlib.h.
8504 * data.c, doprnt.c, floatfns.c, print.c:
8505 Include float.h unconditionally.
8506 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8507 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8508 * regex.c: Likewise for stddef.h, string.h.
8509 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8510 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8511 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8512 (STDC_HEADERS): Remove obsolete defines.
8513 * sysdep.c: Include limits.h unconditionally.
8514
9cfdb3ec
PE
8515 Assume support for memcmp, memcpy, memmove, memset.
8516 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8517 * regex.c (memcmp, memcpy):
8518 Remove; we assume C89 now.
8519
8520 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8521 (__malloc_safe_bcopy): Remove; no longer needed.
8522
cf950e6b 8523 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8524 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8525 well either way, and we prefer signed to unsigned.
8526
dbf38e02
LMI
85272011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8528
8529 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8530 closes the connection while we're reading (bug#9182).
8531
d6f0886c 85322011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8533
d6f0886c
JD
8534 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8535 are specified (Bug#9168).
24e0f6b1 8536
2eb1f9e6
PE
85372011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8538
8539 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8540 Found by GCC static checking and --with-wide-int on a 32-bit host.
8541
22381272 85422011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8543
8544 * xdisp.c (compute_display_string_pos): Fix logic of caching
8545 previous display string position. Initialize cached_prev_pos to
8546 -1. Fixes slow-down at the beginning of a buffer.
8547
f25e39b4
EZ
85482011-07-24 Eli Zaretskii <eliz@gnu.org>
8549
8550 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8551 for attrs[LFACE_FONTSET_INDEX].
8552
04c4b52e
PE
85532011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8554
8555 * xml.c (parse_region): Remove unused local
8556 that was recently introduced.
8557
c1734fbd
EZ
85582011-07-23 Eli Zaretskii <eliz@gnu.org>
8559
be18c5a5
EZ
8560 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8561 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8562
c1734fbd
EZ
8563 * xdisp.c (move_it_in_display_line_to): Record the best matching
8564 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8565 exit if none of the characters scanned was an exact match.
8566 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8567 when exact match is impossible due to invisible text, and the
8568 lines are truncated.
8569
a258d627
JD
85702011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8571
8572 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8573 for OSX >= 10.7.
8574
b6d5a689
EZ
85752011-07-22 Eli Zaretskii <eliz@gnu.org>
8576
0f74f785
EZ
8577 Fix a significant slow-down of cursor motion with C-n, C-p,
8578 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8579 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8580 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8581 (next_element_from_buffer): Call compute_stop_pos_backwards to
8582 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8583 base_level_stop.
8584 (reseat): Don't look for prev_stop, as that could mean a very long
8585 run.
8586 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8587 <cached_disp_overlay_modiff>: Cache for last found display string
8588 position.
551918c1 8589 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8590 about the same buffer in the same area of character positions, and
8591 the buffer wasn't changed since the time the display string
8592 position was cached.
551918c1 8593
b2d0c91a
EZ
85942011-07-22 Eli Zaretskii <eliz@gnu.org>
8595
8596 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8597 is an integer, which is important for empty lines. (Bug#9149)
8598
043604ee
CY
85992011-07-22 Chong Yidong <cyd@stupidchicken.com>
8600
8601 * frame.c (Fmodify_frame_parameters): In tty case, update the
8602 default face if necessary (Bug#4238).
8603
da4adb04
CY
86042011-07-21 Chong Yidong <cyd@stupidchicken.com>
8605
8606 * editfns.c (Fstring_to_char): No need to explain what a character
8607 is in the docstring (Bug#6576).
8608
9abd0532
LMI
86092011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8610
8611 * xml.c (parse_region): Make sure we always return a tree.
8612
36881d16
HK
86132011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8614
8615 * xml.c (parse_region): If a document contains only comments,
8616 return that, too.
8617
1e98674d
LMI
86182011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8619
8620 * xml.c (make_dom): Return comments, too.
8621
590bd467
PE
86222011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8623
8624 Port to OpenBSD.
8625 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8626 and the surrounding thread.
8627 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8628 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8629 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8630 timer goes off.
8631 * s/openbsd.h (BROKEN_SIGIO): Define.
8632 * unexelf.c (unexec) [__OpenBSD__]:
8633 Don't update the .mdebug section of the Alpha COFF symbol table.
8634
f41628b2
LMI
86352011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8636
8637 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8638 (bug#8460).
8639
b59b67c5
PE
86402011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8641
15e3a074
PE
8642 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8643 This fixes some race conditions on the permissions of any newly
8644 created file.
8645
41bed37d
PE
8646 * alloc.c (valid_pointer_p): Use pipe, not open.
8647 This fixes some permissions issues when debugging.
8648
b59b67c5
PE
8649 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8650 If fchown fails to set both uid and gid, try to set just gid,
8651 as that is sometimes allowed. Adjust the file's mode to eliminate
8652 setuid or setgid bits that are inappropriate if fchown fails.
8653
925a6be7
SM
86542011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8655
8656 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8657 to compare Lisp_Objects.
8658 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8659 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8660 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8661
52968808
AS
86622011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8663
0a6a104b
AS
8664 * lread.c (read_integer): Unread even EOF character.
8665 (read1): Likewise. Properly record start position of symbol.
8666
52968808
AS
8667 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8668 symbol character follows.
8669
9e381cdd
PE
86702011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8671
8672 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8673 This works around a problem with the previous change to Fcopy_file.
8674 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8675 and without this change, GCC might complain about discarding
8676 fchown's return value.
8677
b5641435
JB
86782011-07-16 Juanma Barranquero <lekktu@gmail.com>
8679
8680 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8681
a8031457
PE
86822011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8683
8684 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8685
dd889327
LMI
86862011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8687
750c33f7
LMI
8688 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8689 it's used from the C level.
8690
dd889327
LMI
8691 * process.c: Use the same condition for POLL_FOR_INPUT in both
8692 keyboard.c and process.c (bug#1858).
8693
87e86684
LM
86942011-07-09 Lawrence Mitchell <wence@gmx.li>
8695
8696 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8697 (Fgnutls_boot): Use it.
8698
64348f40
AS
86992011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8700
8701 * doc.c (Fsubstitute_command_keys): Revert last change.
8702
1d698799
LMI
87032011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8704
f863868c
LMI
8705 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8706 quotes the next character, and doesn't affect other longer
8707 sequences (bug#8935).
8708
1d698799
LMI
8709 * lread.c (syms_of_lread): Clarify that is isn't only
8710 `eval-buffer' and `eval-defun' that's affected by
8711 `lexical-binding' (bug#8460).
8712
aa4b6df6
EZ
87132011-07-15 Eli Zaretskii <eliz@gnu.org>
8714
8715 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8716 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8717
5d856da6
PE
87182011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8719
ad6042bb
PE
8720 Fix minor problems found by static checking.
8721 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8722 (elsz): Now a signed constant, not a size_t var. We prefer signed
8723 types to unsigned, to avoid integer comparison confusion. Without
8724 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8725 "cannot optimize loop, the loop counter may overflow", a symptom
8726 of the confusion.
f00bbb22 8727 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8728 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8729
6468f31c
LMI
87302011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8731
49080b10
LMI
8732 * search.c (Fre_search_backward): Mention `case-fold-search' in
8733 all the re_search_* functions (bug#8138).
8734
6468f31c
LMI
8735 * keyboard.c (Fopen_dribble_file): Document when the file is
8736 closed (bug#8056).
8737
c965adc5
EZ
87382011-07-14 Eli Zaretskii <eliz@gnu.org>
8739
df9733bf
EZ
8740 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8741 bidi_cache_idx.
8742
0bb23927
EZ
8743 Support bidi reordering of display and overlay strings.
8744 * xdisp.c (compute_display_string_pos)
8745 (compute_display_string_end): Accept additional argument STRING.
8746 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8747 (reseat_to_string): Initialize bidi_it->string.s and
8748 bidi_it->string.schars.
8749 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8750 NULL (avoids a crash in bidi_paragraph_init).
8751 Initialize itb.string.lstring.
0bb23927
EZ
8752 (init_iterator): Call bidi_init_it only of a valid
8753 buffer position was specified. Initialize paragraph_embedding to
8754 L2R.
8755 (reseat_to_string): Initialize the bidi iterator.
8756 (display_string): If we need to ignore text properties of
8757 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8758 original value of -1 will not work with bidi.)
8759 (compute_display_string_pos): First arg is now struct
8760 `text_pos *'; all callers changed. Support display properties on
8761 Lisp strings.
8762 (compute_display_string_end): Support display properties on Lisp
8763 strings.
8764 (init_iterator, reseat_1, reseat_to_string): Initialize the
8765 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8766 when iterating on a string not from display properties).
640c8776
SM
8767 (compute_display_string_pos, compute_display_string_end):
8768 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8769 arrow keys.
8770 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8771 base_level_stop; instead, set base_level_stop to BEGV.
8772 Fixes crashes in vertical-motion.
0bb23927
EZ
8773 (next_element_from_buffer): Improve commentary for when
8774 the iterator is before prev_stop.
8775 (init_iterator): Initialize bidi_p from the default value of
8776 bidi-display-reordering, not from buffer-local value. Use the
8777 buffer-local value only if initializing for buffer iteration.
8778 (handle_invisible_prop): Support invisible properties on strings
8779 that are being bidi-reordered.
8780 (set_iterator_to_next): Support bidi reordering of C strings and
8781 Lisp strings.
8782 (next_element_from_string): Support bidi reordering of Lisp
8783 strings.
8784 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8785 (display_string): Support display of R2L glyph rows.
8786 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8787 (init_iterator): Don't initialize it->bidi_p for strings
8788 here.
8789 (reseat_to_string): Initialize it->bidi_p for strings here.
8790 (next_element_from_string, next_element_from_c_string)
8791 (next_element_from_buffer): Add xassert's for correspondence
8792 between IT's object being iterated and it->bidi_it.string
8793 structure.
8794 (face_before_or_after_it_pos): Support bidi iteration.
8795 (next_element_from_c_string): Handle the case of the first string
8796 character that is not the first one in the visual order.
8797 (get_visually_first_element): New function, refactored from common
8798 parts of next_element_from_buffer, next_element_from_string, and
8799 next_element_from_c_string.
8800 (tool_bar_lines_needed, redisplay_tool_bar)
8801 (display_menu_bar): Force left-to-right direction. Add a FIXME
8802 comment for making that be controlled by a user option.
8803 (push_it, pop_it): Save and restore the state of the
8804 bidi iterator. Save and restore the bidi_p flag.
8805 (pop_it): Iterate out of display property for string iteration as
8806 well.
8807 (iterate_out_of_display_property): Support iteration over strings.
8808 (handle_single_display_spec): Set up it->bidi_it for iteration
8809 over a display string, and call bidi_init_it.
8810 (handle_single_display_spec, next_overlay_string)
8811 (get_overlay_strings_1, push_display_prop): Set up the bidi
8812 iterator for displaying display or overlay strings.
8813 (forward_to_next_line_start): Don't use the shortcut if
8814 bidi-iterating.
8815 (back_to_previous_visible_line_start): If handle_display_prop
8816 pushed the iterator stack, restore the internal state of the bidi
8817 iterator by calling bidi_pop_it same number of times.
8818 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8819 and we are bidi-iterating, don't decrement the iterator position;
8820 instead, set the first_elt flag in the bidi iterator, to produce
8821 the same effect.
8822 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8823 (push_display_prop): xassert that we are iterating a buffer.
8824 (push_it, pop_it): Save and restore paragraph_embedding member.
8825 (handle_single_display_spec, next_overlay_string)
8826 (get_overlay_strings_1, reseat_1, reseat_to_string)
8827 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8828 correctly. Don't assume unibyte strings are not bidi-reordered.
8829 (compute_display_string_pos)
8830 (compute_display_string_end): Fix handling the case of C string.
8831 (push_it, pop_it): Save and restore from_disp_prop_p.
8832 (handle_single_display_spec, push_display_prop): Set the
8833 from_disp_prop_p flag.
8834 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8835 (pop_it): Call iterate_out_of_display_property only if we are
8836 popping after iteration over a string that came from a display
8837 property. Fix a typo in popping stretch info. Add an assertion
8838 for verifying that the iterator position is in sync with the bidi
8839 iterator.
8840 (handle_single_display_spec, get_overlay_strings_1)
8841 (push_display_prop): Fix initialization of paragraph direction for
8842 string when that of the parent object is not yet determined.
8843 (reseat_1): Call bidi_init_it to resync the bidi
8844 iterator with IT's position. (Bug#7616)
8845 (find_row_edges): If ROW->start.pos gives position
8846 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8847 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8848 Reset the from_disp_prop_p flag.
8849 (SAVE_IT, RESTORE_IT): New macros.
8850 (pos_visible_p, face_before_or_after_it_pos)
8851 (back_to_previous_visible_line_start)
8852 (move_it_in_display_line_to, move_it_in_display_line)
8853 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8854 (try_scrolling, redisplay_window, display_line): Use them when
8855 saving a temporary copy of the iterator and restoring it back.
8856 (back_to_previous_visible_line_start, reseat_1)
8857 (init_iterator): Empty the bidi cache "stack".
8858 (move_it_in_display_line_to): If iterator ended up at
8859 EOL, but we never saw any buffer positions smaller than
8860 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8861 motion in bidi-reordered lines.
8862 (move_it_in_display_line_to): Record prev_method and prev_pos
8863 immediately before the call to set_iterator_to_next. Fixes cursor
8864 motion in bidi-reordered lines with stretch glyphs and strings
8865 displayed in margins. (Bug#8133) (Bug#8867)
8866 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8867 TO_CHARPOS.
640c8776
SM
8868 (pos_visible_p): Support positions in bidi-reordered lines.
8869 Save and restore bidi cache.
0bb23927
EZ
8870
8871 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8872 (bidi_paragraph_info): Delete unused struct.
8873 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8874 (bidi_cache_start): New variable.
8875 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8876 to zero.
8877 (bidi_cache_fetch_state, bidi_cache_search)
8878 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8879 (bidi_cache_find, bidi_peek_at_next_level)
8880 (bidi_level_of_next_char, bidi_find_other_level_edge)
8881 (bidi_move_to_visually_next): Compare cache index with
8882 bidi_cache_start rather than with zero.
8883 (bidi_fetch_char): Accept new argument STRING; all callers
8884 changed. Support iteration over a string. Support strings with
8885 display properties. Support unibyte strings. Fix the type of
8886 `len' according to what STRING_CHAR_AND_LENGTH expects.
8887 (bidi_paragraph_init, bidi_resolve_explicit_1)
8888 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8889 (bidi_level_of_next_char, bidi_move_to_visually_next):
8890 Support iteration over a string.
0bb23927
EZ
8891 (bidi_set_sor_type, bidi_resolve_explicit_1)
8892 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8893 can now be zero (for strings); special values 0 and -1 were
8894 changed to -1 and -2, respectively.
8895 (bidi_char_at_pos): New function.
8896 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8897 Call it instead of FETCH_MULTIBYTE_CHAR.
8898 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8899 initialized to valid values.
8900 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8901 values.
8902 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8903 the test for valid cached positions. Fix the logic for looking up
8904 the sentinel state in the cache. GCPRO the Lisp string we are
8905 iterating.
8906 (bidi_push_it, bidi_pop_it): New functions.
8907 (bidi_initialize): Initialize the bidi cache start stack pointer.
8908 (bidi_cache_ensure_space): New function, refactored from part of
8909 bidi_cache_iterator_state. Don't assume the required size is just
8910 one BIDI_CACHE_CHUNK away.
8911 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8912 (bidi_count_bytes, bidi_char_at_pos): New functions.
8913 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8914 always valid if bidi_cache_idx is valid.
8915 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8916 is valid if it's going to be used.
8917 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8918 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8919 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8920 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8921 (bidi_find_other_level_edge, bidi_cache_start_stack):
8922 All variables related to cache indices are now EMACS_INT.
c965adc5 8923
0bb23927
EZ
8924 * dispextern.h (struct bidi_string_data): New structure.
8925 (struct bidi_it): New member `string'. Make flag members be 1-bit
8926 fields, and put them last in the struct.
640c8776
SM
8927 (compute_display_string_pos, compute_display_string_end):
8928 Update prototypes.
0bb23927
EZ
8929 (bidi_push_it, bidi_pop_it): Add prototypes.
8930 (struct iterator_stack_entry): New members bidi_p,
8931 paragraph_embedding, and from_disp_prop_p.
8932 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8933 (bidi_shelve_cache, bidi_unshelve_cache):
8934 Declare prototypes.
0bb23927
EZ
8935
8936 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8937 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8938 and vector-like objects.
8939
8940 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8941 cache around display iteration.
8942
8943 * window.c (Fwindow_end, window_scroll_pixel_based)
8944 (displayed_window_lines, Frecenter): Save and restore the bidi
8945 cache around display iteration.
8946
3bbd2265
LMI
89472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8948
8949 * editfns.c (Fdelete_region): Clarify the use of the named
8950 parameters (bug#6788).
8951
adc47434
MR
89522011-07-14 Martin Rudalics <rudalics@gmx.at>
8953
8954 * indent.c (Fvertical_motion): Set and restore w->pointm when
8955 saving and restoring the window's buffer (Bug#9006).
8956
837c31f8
LMI
89572011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8958
8959 * editfns.c (Fstring_to_char): Clarify just what is returned
8960 (bug#6576). Text by Eli Zaretskii.
8961
ac389d0c
JB
89622011-07-13 Juanma Barranquero <lekktu@gmail.com>
8963
8964 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8965
0be0ce47
EZ
89662011-07-13 Eli Zaretskii <eliz@gnu.org>
8967
8968 * buffer.c (mmap_find): Fix a typo.
8969
cd18e7e3
JB
89702011-07-13 Johan Bockgård <bojohan@gnu.org>
8971
8972 Fix execution of x selection hooks.
8973 * xselect.c (Qx_lost_selection_functions)
8974 (Qx_sent_selection_functions): New vars.
8975 (syms_of_xselect): DEFSYM them.
8976 (x_handle_selection_request): Pass Qx_sent_selection_functions
8977 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8978 (x_handle_selection_clear,x_clear_frame_selections):
8979 Pass Qx_lost_selection_functions rather than
8980 Vx_lost_selection_functions to Frun_hook_with_args.
8981
47ea7f44
PE
89822011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8983
ac389d0c 8984 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8985 The old code sometimes used this field without initializing it.
8986
47ea7f44
PE
8987 * alloc.c (gc_sweep): Don't read past end of array.
8988 In theory, the old code could also have corrupted Emacs internals,
8989 though it'd be very unlikely.
8990
bc985c87
AS
89912011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8992
8993 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8994 argument. (Bug#4026)
bc985c87 8995
0cf34688
LMI
89962011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8997
b3dadd76
LMI
8998 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8999 key" (bug#4257).
9000
0cf34688
LMI
9001 * window.c (Fset_window_start): Doc fix (bug#4199).
9002 (Fset_window_hscroll): Ditto.
9003
270768cd
PE
90042011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9005
077e3dda 9006 Fix minor new problems caught by GCC 4.6.1.
270768cd 9007 * term.c (init_tty): Remove unused local.
490011a6 9008 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9009 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9010 not used otherwise.
270768cd 9011
b1f58454
CY
90122011-07-12 Chong Yidong <cyd@stupidchicken.com>
9013
9014 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9015
22b9578d
LMI
90162011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9017
6e70ab07
LMI
9018 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9019 are the mini-buffer and the echo area (bug#3320).
9020
22b9578d
LMI
9021 * term.c (init_tty): Remove support for supdup, c10 and perq
9022 terminals, which are no longer supported (bug#1482).
9023
8974cc9f
JB
90242011-07-10 Johan Bockgård <bojohan@gnu.org>
9025
9026 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9027
a560d974
JD
90282011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9029
9030 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9031 for non-popups (Bug#3642).
9032
1dae0f0a
AS
90332011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9034
268c2c36 9035 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9036 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9037 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9038 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9039 * data.c (fmod): Likewise.
9040 * dispnew.c (swap_glyphs_in_rows): Likewise.
9041 * emacs.c (memory_warning_signal): Likewise.
9042 * floatfns.c (float_error): Likewise.
9043 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9044 (otf_open, font_otf_capability, generate_otf_features)
9045 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9046 Likewise.
9047 * image.c (pbm_read_file): Likewise.
9048 * indent.c (string_display_width): Likewise.
9049 * intervals.c (check_for_interval, search_for_interval)
9050 (inc_interval_count, count_intervals, root_interval)
9051 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9052 * lread.c (defalias): Likewise.
268c2c36 9053 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9054 * regex.c (set_image_of_range_1, set_image_of_range)
9055 (regex_grow_registers): Likewise.
9056 * sysdep.c (strerror): Likewise.
9057 * termcap.c (valid_filename_p, tprint, main): Likewise.
9058 * tparam.c (main): Likewise.
9059 * unexhp9k800.c (run_time_remap, save_data_space)
9060 (update_file_ptrs, read_header, write_header, calculate_checksum)
9061 (copy_file, copy_rest, display_header): Likewise.
9062 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9063 Likewise.
9064 * xdisp.c (check_it): Likewise.
9065 * xfaces.c (register_color, unregister_color, unregister_colors):
9066 Likewise.
9067 * xfns.c (print_fontset_result): Likewise.
9068 * xrdb.c (member, fatal, main): Likewise.
9069
99033785
PE
90702011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9071
9072 Fix minor problems found by static checking (Bug#9031).
9073 * chartab.c (char_table_set_range, map_sub_char_table):
9074 Remove unused locals.
9075 (uniprop_table): Now static.
9076 * composite.c (_work_char): Remove unused static var.
9077
9cb2ac56
JB
90782011-07-09 Juanma Barranquero <lekktu@gmail.com>
9079
9080 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9081
f25661f0
JD
90822011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9083
9084 * gtkutil.c (qttip_cb): Remove code without function.
9085
8278c4fe
EZ
90862011-07-09 Eli Zaretskii <eliz@gnu.org>
9087
9088 * w32.c (pthread_sigmask): New stub.
9089
1692ae2d 90902011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9091
8a6ebd58 9092 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9093 sigprocmask is portable only for single-threaded applications, and
9094 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9095 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9096 (LIBES): Use it.
9097 * callproc.c (Fcall_process):
9098 * process.c (create_process):
9099 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9100 Use pthread_sigmask, not sigprocmask.
123403e4 9101
1b854618
JD
91022011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9103
9104 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9105 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9106 wrong (Bug#8591).
9107
3fe4b549
JD
91082011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9109
0ce7e563
JD
9110 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9111 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9112 (xg_hide_tooltip): Fix comment.
9113
3fe4b549
JD
9114 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9115 in registerServicesMenuSendTypes.
9116 (validRequestorForSendType): Don't check ns_return_types.
9117
9118 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9119 ns_return_type.
9120
5df75e47
JR
91212011-07-08 Jason Rumney <jasonr@gnu.org>
9122
22610910
JR
9123 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9124 SH_SHOW for hidden windows (Bug#5482).
9125
5df75e47
JR
9126 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9127 frame struct members of non-existent frames (Bug#6284).
9128
699c10bd
JD
91292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9130
4393663b
JD
9131 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9132 variable firstTime not needed on OSX >= 10.6.
9133 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9134 >= 10.5. Use setKnobProportion, setDoubleValue.
9135
9136 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9137 (MAC_OS_X_VERSION_10_5): Define if not defined.
9138 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9139 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9140 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9141
9142 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9143 cString and lossyCString on OSX >= 10.4.
4393663b 9144
58179cce 9145 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9146 sizeToFit on OSX >= 10.2.
9147
9148 * nsimage.m (allocInitFromFile): Don't use deprecated method
9149 bestRepresentationForDevice on OSX >= 10.6.
9150
9151 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9152 to avoid warning.
9153
9154 * emacs.c: Declare unexec_init_emacs_zone.
9155
a63e0781
JD
9156 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9157
699c10bd
JD
9158 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9159
9160 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9161 on svcsMenu (Bug#8842).
9162
9163 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9164 ns_return_types.
9165 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9166
9167 * nsterm.m (QUTF8_STRING): Declare.
9168 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9169 (validRequestorForSendType): Return type is (id).
9170 Change indexOfObjectIdenticalTo to indexOfObject.
9171 Check if we have local selection before returning self (Bug#8842).
9172 (writeSelectionToPasteboard): Put local selection into paste board
9173 if we have a local selection (Bug#8842).
9174 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9175
9176 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9177 (ns_get_local_selection): Declare.
9178
54e10184
LMI
91792011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9180
9888ff71
LMI
9181 * keymap.c (describe_map_tree): Don't insert a double newline at
9182 the end of the buffer (bug#1169) and return whether we inserted
9183 something.
9184
54e10184
LMI
9185 * callint.c (Fcall_interactively): Change "reading args" to
9186 "providing args" to try to clarify what it does (bug#1010).
9187
15fa4783
KH
91882011-07-07 Kenichi Handa <handa@m17n.org>
9189
9190 * composite.c (composition_compute_stop_pos): Ignore a static
9191 composition starting before CHARPOS (Bug#8915).
9192
9193 * xdisp.c (handle_composition_prop): Likewise.
9194
a8815b00
EZ
91952011-07-07 Eli Zaretskii <eliz@gnu.org>
9196
9197 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9198 (Bug#9015)
9199
ef7b981d 92002011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9201
9202 * character.h (unicode_category_t): New enum type.
9203
9204 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9205 (Qchar_code_property_table): New variable.
9206 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9207 (UNIPROP_COMPRESSED_FORM_P): New macros.
9208 (char_table_ascii): Uncompress the compressed values.
9209 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9210 Uncompress the compressed values.
ac389d0c 9211 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9212 (char_table_ref_and_range): Uncompress the compressed values.
9213 (sub_char_table_set): New arg is_uniprop. Callers changed.
9214 Uncompress the compressed values.
9215 (sub_char_table_set_range): Args changed. Callers changed.
9216 (char_table_set_range): Adjuted for the above change.
9217 (map_sub_char_table): Delete args default_val and parent. Add arg
9218 top. Give decoded values to a Lisp function.
640c8776 9219 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9220 values to a Lisp function. Gcpro more variables.
9221 (uniprop_table_uncompress)
9222 (uniprop_decode_value_run_length): New functions.
9223 (uniprop_decoder, uniprop_decoder_count): New variables.
9224 (uniprop_get_decoder, uniprop_encode_value_character)
9225 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9226 New functions.
9227 (uniprop_encoder, uniprop_encoder_count): New variables.
9228 (uniprop_get_encoder, uniprop_table)
9229 (Funicode_property_table_internal, Fget_unicode_property_internal)
9230 (Fput_unicode_property_internal): New functions.
9231 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9232 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9233 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9234 char-code-property-alist.
9235
640c8776 9236 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9237 Vunicode_category_table.
9238
640c8776 9239 * font.c (font_range): Adjust for the change of
c805dec0
KH
9240 Vunicode_category_table.
9241
76b397fb
DN
92422011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9243
9244 * m/iris4d.h: Remove file, move contents ...
9245 * s/irix6-5.h: ... here.
9246
22b4128e
PE
92472011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9248
9249 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9250 * alloc.c (mark_buffer):
9251 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9252 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9253 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9254 This isn't true in general, and it's particularly not true
9255 if Emacs is configured with --with-wide-int.
9256 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9257 New macros, used in the buffer.c change.
9258
869795d6
JD
92592011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9260
9261 * xsettings.c: Use both GConf and GSettings if both are available.
9262 (store_config_changed_event): Add comment.
9263 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9264 (store_tool_bar_style_changed): New functions.
5e617bc2 9265 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9266 (struct xsettings): Move font inside HAVE_XFT.
9267 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9268 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9269 Move inside HAVE_XFT.
640c8776 9270 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9271 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9272 also.
9273 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9274 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9275 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9276 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9277 (parse_settings): Move check for font inside HAVE_XFT.
9278 (read_settings, apply_xft_settings): Add comment.
9279 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9280 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9281 call store_font_name_changed.
9282 (xft_settings_event): Add comment.
9283 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9284 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9285 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9286 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9287 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9288 (xsettings_get_system_font, xsettings_get_system_normal_font):
9289 Add comment.
869795d6 9290
d8ed26bd
PE
92912011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9292
9293 Random fixes. E.g., (random) never returned negative values.
9294 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9295 subseconds part to the entropy, as that's a bit more random.
9296 Prefer signed to unsigned, since the signedness doesn't matter and
9297 in general we prefer signed. When given a limit, use a
9298 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9299 latter isn't right if USE_2_TAGS_FOR_INTS.
9300 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9301 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9302
cabf1cac
SM
93032011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9304
9305 * textprop.c (text_property_stickiness):
9306 Obey Vtext_property_default_nonsticky.
9307 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9308 * w32fns.c (syms_of_w32fns):
9309 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9310
6e9b2be9
PE
93112011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9312
9313 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9314 This is more efficient than Ffile_directory_p and avoids a minor race.
9315
90186c68
LMI
93162011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9317
7c301272
LMI
9318 * buffer.c (Foverlay_put): Say what the return value is
9319 (bug#7835).
9320
c4f2d8d4
LMI
9321 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9322 is a directory before asking whether to use the file name
9323 (bug#7564).
ad637907
LMI
9324 (barf_or_query_if_file_exists): Make the "File is a directory"
9325 error be more correct.
c4f2d8d4 9326
90186c68
LMI
9327 * fns.c (Frequire): Remove the mention of the .gz files, since
9328 that's installation-specific, but keep the mention of
9329 `get-load-suffixes'.
9330
da64016e
PE
93312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9332
9333 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9334 Report string overflow if the output is too long.
9335
7d47b580
JB
93362011-07-04 Juanma Barranquero <lekktu@gmail.com>
9337
a555cb87
JB
9338 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9339 (syms_of_gnutls): Remove duplicate DEFSYM for
9340 Qgnutls_bootprop_verify_hostname_error, an error for
9341 Qgnutls_bootprop_verify_error (which is no longer used).
9342
7d47b580
JB
9343 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9344 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9345 Also (re)move comments that are misplaced or no longer relevant.
9346
1e49bfab
LMI
93472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9348
9349 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9350
1485f4c0
CY
93512011-07-03 Chong Yidong <cyd@stupidchicken.com>
9352
9353 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9354 and background color parameters if they have been changed.
9355
a9ab721e
LMI
93562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9357
9358 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9359
cf7cff57
PE
93602011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9361
2e13213d
PE
9362 * xsettings.c (SYSTEM_FONT): Define only when used.
9363 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9364
cf7cff57
PE
9365 * keymap.c (access_keymap_1): Now static.
9366
7a8e04f7
CY
93672011-07-02 Chong Yidong <cyd@stupidchicken.com>
9368
9369 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9370 leave any prefix arg for the up event (Bug#1586).
9371
61352f62
LMI
93722011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9373
69bb1ef7
LMI
9374 * lread.c (syms_of_lread): Mention single symbols defined by
9375 `defvar' or `defconst' (bug#7154).
9376
61352f62 9377 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9378 (Frequire): Mention get-load-suffixes.
61352f62 9379
28545e04
MR
93802011-07-02 Martin Rudalics <rudalics@gmx.at>
9381
9382 * window.h (window): Remove clone_number slot.
9383 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9384 Remove.
9385 (make_parent_window, make_window, saved_window)
9386 (Fset_window_configuration, save_window_save): Don't deal with
9387 clone numbers.
9388 * buffer.c (Qclone_number): Remove declaration.
9389 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9390
3349e122
SM
93912011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9392
9393 Add multiple inheritance to keymaps.
9394 * keymap.c (Fmake_composed_keymap): New function.
9395 (Fset_keymap_parent): Simplify.
9396 (fix_submap_inheritance): Remove.
9397 (access_keymap_1): New function extracted from access_keymap to handle
9398 embedded parents and handle lists of maps.
9399 (access_keymap): Use it.
9400 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9401 (Fcopy_keymap): Handle embedded parents.
9402 (Fcommand_remapping, define_as_prefix): Simplify.
9403 (Fkey_binding): Simplify.
9404 (syms_of_keymap): Move minibuffer-local-completion-map,
9405 minibuffer-local-filename-completion-map,
9406 minibuffer-local-must-match-map, and
9407 minibuffer-local-filename-must-match-map to Elisp.
9408 (syms_of_keymap): Defsubr make-composed-keymap.
9409 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9410 (parse_menu_item): Trivial simplification.
9411
3279eb87
GM
94122011-07-01 Glenn Morris <rgm@gnu.org>
9413
9414 * Makefile.in (SETTINGS_LIBS): Fix typo.
9415
4550efdf
KI
94162011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9417
9418 * coding.c (Fencode_coding_string): Record the last coding system
9419 used, as the function doc string says (bug#8738).
9420
0949d2b6
JD
94212011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9422
9423 * xsettings.c (store_monospaced_changed): Take new font as arg and
9424 check for change against current_mono_font.
9425 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9426 (emacs_settings_constructor, emacs_settings_get_property)
9427 (emacs_settings_set_property, emacs_settings_class_init)
9428 (emacs_settings_init, gsettings_obj): Remove.
9429 (something_changedCB): New function for HAVE_GSETTINGS.
9430 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9431 with value as argument.
9432 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9433 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9434 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9435 "changed".
9436
9437 * xgselect.c: Add defined (HAVE_GSETTINGS).
9438 (xgselect_initialize): Ditto.
9439
9440 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9441 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9442 xg_select.
9443
bbc6b304
PE
94442011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9445
9446 * eval.c (struct backtrace): Simplify and port the data structure.
9447 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9448 signed bit field, as this assumption is not portable and it makes
9449 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9450 "char debug_on_exit : 1" as this is not portable either; instead,
9451 use the portable "unsigned int debug_on_exit : 1". Remove unused
9452 member evalargs. Remove obsolete comments about cc bombing out.
9453
9851bfc5
JD
94542011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9455
51bb811f 9456 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9457 Let HAVE_GSETTINGS override HAVE_GCONF.
9458 (store_monospaced_changed): New function.
9459 (EMACS_SETTINGS): A new type derived from GObject to handle
9460 GSettings notifications.
9461 (emacs_settings_constructor, emacs_settings_get_property)
9462 (emacs_settings_set_property, emacs_settings_class_init):
9463 New functions.
9464 (gsettings_client, gsettings_obj): New variables.
9465 (GSETTINGS_SCHEMA): New define.
9466 (something_changedCB): Call store_monospaced_changed.
9467 (init_gsettings): New function.
9468 (xsettings_initialize): Call init_gsettings.
9469 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9470 to NULL.
9471
640c8776 9472 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9473 GCONF_CFLAGS/LIBS.
9474
5386012d
MR
94752011-06-29 Martin Rudalics <rudalics@gmx.at>
9476
9477 * window.c (resize_root_window, grow_mini_window)
9478 (shrink_mini_window): Rename Qresize_root_window to
9479 Qwindow_resize_root_window and Qresize_root_window_vertically to
9480 Qwindow_resize_root_window_vertically.
9481
f13e0b08
PE
94822011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9483
9484 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9485
94515237
JB
94862011-06-27 Juanma Barranquero <lekktu@gmail.com>
9487
9488 * makefile.w32-in: Redesign dependencies so they reflect more
9489 clearly which files are directly included by each source file,
9490 and not through other includes.
9491
e43b6e43
MR
94922011-06-27 Martin Rudalics <rudalics@gmx.at>
9493
9494 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9495 (sort_overlays, overlay_strings): When an overlay's clone number
9496 matches the window's clone number process the overlay even if
9497 the overlay's window property doesn't match the current window.
9498
d68443dc
MR
9499 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9500 (Fwindow_hchild): Rename to Fwindow_left_child.
9501 (Fwindow_next): Rename to Fwindow_next_sibling.
9502 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9503 (resize_window_check): Rename to window_resize_check.
9504 (resize_window_apply): Rename to window_resize_apply.
9505 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9506 (Fdelete_other_windows_internal, resize_frame_windows)
9507 (Fsplit_window_internal, Fdelete_window_internal)
9508 (grow_mini_window, shrink_mini_window)
9509 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9510
c7e73be5
JD
95112011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9512
9513 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9514 (emacs_fixed_set_min_size): Remove.
9515 (emacs_fixed_new): Take frame as argument.
9516
9517 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9518 (_EmacsFixedPrivate): Remove minwidth/height.
9519 Add struct frame *f.
9520 (emacs_fixed_init): Initialize priv->f.
9521 (get_parent_class, emacs_fixed_set_min_size): Remove.
9522 (emacs_fixed_new): Set priv->f to argument.
9523 (emacs_fixed_get_preferred_width)
9524 (emacs_fixed_get_preferred_height): Use min_width/height from
9525 frames size_hint to set minimum and natural (Bug#8919).
9526 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9527 and use min_width/height from frames size_hint to set
9528 min_width/height (Bug#8919).
9529
9530 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9531 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9532 Fix indentation.
c7e73be5 9533
cf99dcf8
EZ
95342011-06-26 Eli Zaretskii <eliz@gnu.org>
9535
9536 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9537 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9538 called at ZV.
9539
029529ac
CY
95402011-06-26 Chong Yidong <cyd@stupidchicken.com>
9541
9542 * process.c (wait_reading_process_output): Bypass select if
9543 waiting for a cell while ignoring keyboard input, and input is
9544 pending. Suggested by Jan Djärv (Bug#8869).
9545
7a7ef429
PE
95462011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9547
9548 Use gnulib's dup2 module instead of rolling our own.
9549 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9550
11fdef7d 95512011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9552
9553 * dispnew.c (scrolling_window): Before scrolling, turn off a
9554 mouse-highlight in the window being scrolled.
9555
cd3520a4
JB
95562011-06-24 Juanma Barranquero <lekktu@gmail.com>
9557
9558 Move DEFSYM to lisp.h and use everywhere.
9559
9560 * character.h (DEFSYM): Move declaration...
9561 * lisp.h (DEFSYM): ...here.
9562
9563 * gnutls.c:
9564 * minibuf.c:
9565 * w32menu.c:
9566 * w32proc.c:
9567 * w32select.c: Don't include character.h.
9568
9569 * alloc.c (syms_of_alloc):
9570 * buffer.c (syms_of_buffer):
9571 * bytecode.c (syms_of_bytecode):
9572 * callint.c (syms_of_callint):
9573 * casefiddle.c (syms_of_casefiddle):
9574 * casetab.c (init_casetab_once):
9575 * category.c (init_category_once, syms_of_category):
9576 * ccl.c (syms_of_ccl):
9577 * cmds.c (syms_of_cmds):
9578 * composite.c (syms_of_composite):
9579 * dbusbind.c (syms_of_dbusbind):
9580 * dired.c (syms_of_dired):
9581 * dispnew.c (syms_of_display):
9582 * doc.c (syms_of_doc):
9583 * editfns.c (syms_of_editfns):
9584 * emacs.c (syms_of_emacs):
9585 * eval.c (syms_of_eval):
9586 * fileio.c (syms_of_fileio):
9587 * fns.c (syms_of_fns):
9588 * frame.c (syms_of_frame):
9589 * fringe.c (syms_of_fringe):
9590 * insdel.c (syms_of_insdel):
9591 * keymap.c (syms_of_keymap):
9592 * lread.c (init_obarray, syms_of_lread):
9593 * macros.c (syms_of_macros):
9594 * msdos.c (syms_of_msdos):
9595 * print.c (syms_of_print):
9596 * process.c (syms_of_process):
9597 * search.c (syms_of_search):
9598 * sound.c (syms_of_sound):
9599 * syntax.c (init_syntax_once, syms_of_syntax):
9600 * terminal.c (syms_of_terminal):
9601 * textprop.c (syms_of_textprop):
9602 * undo.c (syms_of_undo):
9603 * w32.c (globals_of_w32):
9604 * window.c (syms_of_window):
9605 * xdisp.c (syms_of_xdisp):
9606 * xfaces.c (syms_of_xfaces):
9607 * xfns.c (syms_of_xfns):
9608 * xmenu.c (syms_of_xmenu):
9609 * xsettings.c (syms_of_xsettings):
9610 * xterm.c (syms_of_xterm): Use DEFSYM.
9611
4228cf16
TZ
96122011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9613
cd3520a4 9614 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9615
7fcccf1e
PE
96162011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9617
7efb4e0e
PE
9618 Integer and buffer overflow fixes (Bug#8873).
9619
ff5844ad
PE
9620 * print.c (printchar, strout): Check for string overflow.
9621 (PRINTPREPARE, printchar, strout):
9622 Don't set size unless allocation succeeds.
9623
90532f02
PE
9624 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9625 for sizes. Check for string overflow more accurately.
9626 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9627
6d84508d
PE
9628 * macros.c: Integer and buffer overflow fixes.
9629 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9630 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9631 Use ptrdiff_t, not int, for sizes.
9632 Don't increment bufsize until after realloc succeeds.
9633 Check for size-calculation overflow.
9634 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9635
437b2cb4
PE
9636 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9637
8b9ac8b4
PE
9638 * lread.c: Integer overflow fixes.
9639 (read_integer): Radix is now EMACS_INT, not int,
9640 to improve quality of diagnostics for out-of-range radices.
9641 Calculate buffer size correctly for out-of-range radices.
9642 (read1): Check for integer overflow in radices, and in
9643 read-circle numbers.
82cb60d3
PE
9644 (read_escape): Avoid int overflow.
9645 (Fload, openp, read_buffer_size, read1)
9646 (substitute_object_recurse, read_vector, read_list, map_obarray):
9647 Use ptrdiff_t, not int, for sizes.
9648 (read1): Use EMACS_INT, not int, for sizes.
20270765 9649 Check for size overflow.
8b9ac8b4 9650
7fcccf1e
PE
9651 * image.c (cache_image): Check for size arithmetic overflow.
9652
bfbbd7e7
PE
9653 * lread.c: Integer overflow issues.
9654 (saved_doc_string_size, saved_doc_string_length)
9655 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9656 Now ptrdiff_t, not int.
9657 (read1): Don't assume doc string length fits in int. Check for
9658 out-of-range doc string lengths.
9659 (read_list): Don't assume file position fits in int.
39019e54 9660 (read_escape): Check for hex character overflow.
bfbbd7e7 9661
4e323265
LL
96622011-06-22 Leo Liu <sdl.web@gmail.com>
9663
9664 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9665 Move to minibuffer.el.
9666
85fece3e
PE
96672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9668
20b84ce9 9669 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9670 The following patches are for when GLYPH_DEBUG && !XASSERT.
9671 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9672 * dispnew.c (flush_stdout):
9673 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9674 Mark as externally visible.
9675 * dispnew.c (check_window_matrix_pointers): Now static.
9676 * dispnew.c (window_to_frame_vpos):
9677 * xfns.c (unwind_create_frame):
9678 * xterm.c (x_check_font): Remove unused local.
9679 * scroll.c (CHECK_BOUNDS):
9680 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9681 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9682 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9683 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9684 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9685 Now static.
9686 (debug_method_add): Use va_list and vsprintf rather than relying
9687 on undefined behavior with wrong number of arguments.
9688 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9689 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9690 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9691 since we're not interested in debugging glyphs with old libraries.
9692 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9693 GCC 4.6.0's static checking.
9694
0766b489
PE
96952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9696
31fd4b32
PE
9697 Integer overflow and signedness fixes (Bug#8873).
9698 A few related buffer overrun fixes, too.
9699
b79e8648
PE
9700 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9701
0766b489
PE
9702 * dispextern.h (struct face.stipple):
9703 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9704 (x_bitmap_mask, x_allocate_bitmap_record)
9705 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9706 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9707 (x_create_bitmap_from_xpm_data):
9708 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9709 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9710 (.bitmaps_last):
9711 * xfaces.c (load_pixmap):
9712 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9713 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9714 (.bitmaps_last, struct x_output.icon_bitmap):
9715 Use ptrdiff_t, not int, for bitmap indexes.
9716 (x_allocate_bitmap_record): Check for size overflow.
9717 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9718
b081724f
PE
9719 Use ptrdiff_t, not int, for overlay counts.
9720 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9721 * editfns.c (overlays_around, get_pos_property):
9722 * textprop.c (get_char_property_and_overlay):
9723 * xdisp.c (next_overlay_change, note_mouse_highlight):
9724 * xfaces.c (face_at_buffer_position):
21514da7
PE
9725 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9726 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9727 (Fnext_overlay_change, Fprevious_overlay_change)
9728 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9729 Use ptrdiff_t, not int, for sizes.
21514da7 9730 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9731
3de73e5e
PE
9732 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9733
2606c57b
PE
9734 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9735 (x_session_initialize): Do not assume string length fits in int.
9736
aaafe47a
PE
9737 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9738 This is unlikely, but can occur if DPI is outlandish.
9739
2674ddc8 9740 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9741 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9742
28154962
PE
9743 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9744 * xrdb.c (magic_file_p, search_magic_path):
9745 Omit last arg SUFFIX; it was always 0. All callers changed.
9746 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9747
7de51af5
PE
9748 * xfont.c (xfont_match): Avoid need for strlen.
9749
25ed6cc3
PE
9750 * xfns.c: Don't assume strlen fits in int.
9751 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9752
4eab31dd
PE
9753 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9754 not unsigned long, as we prefer signed integers. All callers changed.
9755 Detect integer overflow in repeat count.
9756 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9757 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9758
171e2a58
PE
9759 * termcap.c: Don't assume sizes fit in int and never overflow.
9760 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9761 (gobble_line): Check for size-calculation overflow.
9762
ad39faca 9763 * minibuf.c (Fread_buffer):
6e5bb2dc 9764 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9765 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9766 Don't assume string length fits in int.
9767
52c61c22 9768 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9769 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9770
b5b8c9e5
PE
9771 * font.c: Don't assume string length fits in int.
9772 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9773 Use ptrdiff_t, not int.
ccd6111c
PE
9774 (font_intern_prop): Don't assume string length fits in int.
9775 Don't assume integer property fits in fixnum.
9776 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9777
882f0d81 9778 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9779 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9780 Reformulate so as not to need the command string.
9781 Invoke gzip -cd rather than gunzip, as it's more portable.
9782 (lock_info_type, lock_file_1, lock_file):
9783 Don't assume pid_t and time_t fit in unsigned long.
9784 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9785 (current_lock_owner): Prefer signed type for sizes.
9786 Use memcpy, not strncpy, where memcpy is what is really wanted.
9787 Don't assume (via atoi) that time_t and pid_t fit in int.
9788 Check for time_t and/or pid_t out of range, e.g., via a network share.
9789 Don't alloca where an auto var works fine.
9790
93f4cf88
PE
9791 * fileio.c: Fix some integer overflow issues.
9792 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9793 Don't assume string length fits in int.
9794 (directory_file_name): Don't assume string length fits in long.
9795 (make_temp_name): Don't assume pid fits in int, or that its print
9796 length is less than 20.
9797
f3e92b69
PE
9798 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9799
1bfdaf10
PE
9800 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9801
35016e9a
PE
9802 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9803
3d1e65a1
PE
9804 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9805 We prefer signed integers, even for size calculations.
9806
0b963a93
PE
9807 * emacs.c: Don't assume string length fits in 'int'.
9808 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9809 (main): Don't invoke strlen when not needed.
9810
573f4b54
PE
9811 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9812 (XD_DEBUG_MESSAGE): Don't waste a byte.
9813
989f33ba
PE
9814 * callproc.c (getenv_internal_1, getenv_internal)
9815 (Fgetenv_internal):
965d34eb
PE
9816 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9817
e4d29b33
PE
9818 * lread.c (invalid_syntax): Omit length argument.
9819 All uses changed. This doesn't fix a bug, but it simplifies the
9820 code away from its former Hollerith-constant appearance, and it's
9821 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9822 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9823
eb49b136
PE
9824 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9825 This didn't break anything, but it didn't help either.
9826 It's confusing to put a bogus integer in a place where the actual
9827 value does not matter.
9f62aeb1 9828 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9829 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9830
15375a22
PE
9831 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9832 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9833 implementation.
b61cc01c
PE
9834 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9835 We prefer signed types, and the value cannot exceed the EMACS_INT
9836 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9837 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9838 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9839 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9840
53b2623d
PE
9841 * indent.c (sane_tab_width): New function.
9842 (current_column, scan_for_column, Findent_to, position_indentation)
9843 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9844 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9845
51cab52b 9846 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9847
f2ed8a70
PE
9848 * lisp.h (lint_assume): New macro.
9849 * composite.c (composition_gstring_put_cache):
9850 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9851
abe80cc6
PE
9852 * editfns.c, insdel.c:
9853 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9854
b02c740e
PE
9855 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9856
ebc96716
PE
9857 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9858
b4e50fa0 9859 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9860 Use much-faster test for byte-length change.
311d5d7c 9861 Don't assume string byte-length fits in 'int'.
a4cf38e4 9862 Check that character arg fits in 'int'.
85461888 9863 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9864
c0c1ee9f
PE
9865 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9866
a498d7f4
PE
9867 * fns.c (concat): Catch string overflow earlier.
9868 Do not rely on integer wraparound.
9869
51cab52b
PE
9870 * dispextern.h (struct it.overlay_strings_charpos)
9871 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9872 * xdisp.c (forward_to_next_line_start)
9873 (back_to_previous_visible_line_start)
9874 (reseat_at_next_visible_line_start, next_element_from_buffer):
9875 Don't arbitrarily truncate the value of 'selective' to int.
9876
76031fad
PE
9877 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9878
5eb55db9
PE
9879 * composite.c: Don't truncate sizes to 'int'.
9880 (composition_gstring_p, composition_reseat_it)
9881 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9882 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9883 not EMACS_UINT, for indexes.
5eb55db9 9884
0703a717
PE
9885 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9886
d6202519
PE
9887 * buffer.c: Include <verify.h>.
9888 (struct sortvec.priority, struct sortstr.priority):
8961a454 9889 Now EMACS_INT, not int.
c20998a7 9890 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9891 (struct sortstr.size, record_overlay_string)
9892 (struct sortstrlist.size, struct sortlist.used):
9893 Don't truncate size to int.
9894 (record_overlay_string): Check for size-calculation overflow.
d6202519 9895 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9896
d5a19415
JM
98972011-06-22 Jim Meyering <meyering@redhat.com>
9898
029529ac 9899 Don't leak an XBM-image-sized buffer
d5a19415
JM
9900 * image.c (xbm_load): Free the image buffer after using it.
9901
a9041e6c
PE
99022011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9903
9904 Port to Sun C.
9905 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9906 that Sun C diagnosed.
9907 * fns.c (secure_hash): Fix pointer signedness issue.
9908 * intervals.c (static_offset_intervals): New function.
9909 (offset_intervals): Use it.
9910
7f3f739f
LL
99112011-06-21 Leo Liu <sdl.web@gmail.com>
9912
9913 * deps.mk (fns.o):
9914 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9915 sha512.h.
9916
9917 * fns.c (secure_hash): Rename from crypto_hash_function and change
9918 the first arg to accept symbols.
5b66d427 9919 (Fsecure_hash): New primitive.
7f3f739f
LL
9920 (syms_of_fns): New symbols.
9921
76147d94
DD
99222011-06-20 Deniz Dogan <deniz@dogan.se>
9923
9924 * process.c (Fset_process_buffer): Clarify return value in
9925 docstring.
9926
7d7d0045
CY
99272011-06-18 Chong Yidong <cyd@stupidchicken.com>
9928
9929 * dispnew.c (add_window_display_history): Use BVAR.
9930
9931 * xdisp.c (debug_method_add): Use BVAR.
9932 (check_window_end, dump_glyph_matrix, dump_glyph)
9933 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9934
9935 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9936 Likewise.
9937
9938 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9939 check till after the cache is created in init_frame_faces.
9940
ff2bc410
SM
99412011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9942
9943 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9944
28177add
PE
99452011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9946
dd3482fe
PE
9947 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9948 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9949 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9950
393d71f3 9951 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9952 * fileio.c (Finsert_file_contents):
9953 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9954 Remove the old (too-loose) buffer overflow checks.
9955 They weren't needed, since make_gap checks for buffer overflow.
9956 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9957 The old code merely checked for Emacs fixnum overflow, and relied
9958 on undefined (wraparound) behavior. The new code avoids undefined
9959 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9960
2e6813b0 9961 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9962 Tune. Don't use wider integers than needed. Don't use alloca.
9963 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9964
599a9e4f
PE
9965 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9966
99561444
PE
9967 * insdel.c, lisp.h (buffer_overflow): New function.
9968 (insert_from_buffer_1, replace_range, replace_range_2):
9969 * insdel.c (make_gap_larger):
9970 * editfns.c (Finsert_char):
9971 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9972
28177add
PE
9973 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9974
e69dafad
PE
99752011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9976
4baa020d 9977 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9978
b1c46f02
PE
9979 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9980 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9981
e69dafad
PE
9982 * fileio.c: Don't assume EMACS_INT fits in off_t.
9983 (emacs_lseek): New static function.
9984 (Finsert_file_contents, Fwrite_region): Use it.
9985 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9986
566684ea
PE
9987 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9988
e6966cd6
PE
9989 * fns.c: Don't overflow int when computing a list length.
9990 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9991 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9992 truncation on 64-bit hosts. Check for QUIT every
9993 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9994 faster and is responsive enough.
9995 (Flength): Report an error instead of overflowing an integer.
9996 (Fsafe_length): Return a float if the value is not representable
9997 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9998 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9999 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10000
dd0b0efb
PE
10001 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10002 (header_size, word_size): New constants.
10003 (allocate_vectorlike): Don't check size overflow here.
10004 (allocate_vector): Check it here instead, since this is the only
10005 caller of allocate_vectorlike that could cause overflow.
10006 Check that the new vector's length is representable as a fixnum.
10007
86fe5cfe
PE
10008 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10009 The previous code was bogus. For example, next_almost_prime (32)
10010 returned 39, which is undesirable as it is a multiple of 3; and
10011 next_almost_prime (24) returned 25, which is a multiple of 5 so
10012 why was the code bothering to check for multiples of 7?
10013
80e88859
PE
10014 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10015
4a2f0ad6
PE
10016 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10017
f66c7cf8
PE
10018 Variadic C functions now count arguments with ptrdiff_t.
10019 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10020 Back then I didn't know that the Emacs coding style prefers signed int.
10021 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10022 were being counted with int, which may truncate counts on 64-bit
10023 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10024 * lisp.h (struct Lisp_Subr.function.aMANY)
10025 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10026 Arg counts are now ptrdiff_t, not size_t.
10027 All variadic functions and their callers changed accordingly.
10028 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10029 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10030 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10031 * callint.c (Fcall_interactively): Check arg count for overflow,
10032 to avoid potential buffer overrun. Use signed char, not 'int',
10033 for 'varies' array, so that we needn't bother to check its size
10034 calculation for overflow.
10035 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10036 * eval.c (apply_lambda):
10037 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10038 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10039 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10040
a1759b76
PE
10041 * callint.c (Fcall_interactively): Don't use index var as event count.
10042
d96be9fc
PE
10043 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10044 * mem-limits.h (SIZE): Remove; no longer used.
10045
a690a978 10046 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10047
578c21e6
PE
10048 Remove unnecessary casts.
10049 * xterm.c (x_term_init):
10050 * xfns.c (x_set_border_pixel):
10051 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10052 These aren't needed now that we assume ANSI C.
10053
96f53c6c
PE
10054 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10055 It's more likely to cause problems (due to unsigned overflow)
10056 than to cure them.
10057
83c77d31
PE
10058 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10059
ee2079f1
PE
10060 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10061
6da65536
PE
10062 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10063
7147c4a4
PE
10064 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10065
193e32d9
PE
10066 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10067
e5533da6
PE
10068 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10069
9910e595
PE
10070 GLYPH_CODE_FACE returns EMACS_INT, not int.
10071 * dispextern.h (merge_faces):
10072 * xfaces.c (merge_faces):
01103c44
PE
10073 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10074 Don't assume EMACS_INT fits in int.
9910e595 10075
2638320e
PE
10076 * character.h (CHAR_VALID_P): Remove unused parameter.
10077 * fontset.c, lisp.h, xdisp.c: All uses changed.
10078
045eb8d9
PE
10079 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10080
c1f134b5
PE
10081 * fns.c (concat): Minor tuning based on overflow analysis.
10082 This doesn't fix any bugs. Use int to hold character, instead
10083 of constantly refetching from Emacs object. Use XFASTINT, not
10084 XINT, for value known to be a character. Don't bother comparing
10085 a single byte to 0400, as it's always less.
10086
395fcb93 10087 * floatfns.c (Fexpt):
327eeec8
PE
10088 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10089
abbd3d23
PE
10090 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10091 for characters.
10092
684a03ef
PE
10093 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10094
0fed43f3
PE
10095 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10096 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10097 incorrectly succeed when S was a string, because 4294967386 was
10098 truncated before it was used.
10099
8fd02eb7
PE
10100 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10101 Otherwise, an out-of-range integer could cause undefined behavior
10102 on a 64-bit host.
10103
f8c86b69
PE
10104 * composite.c: Use int, not EMACS_INT, for characters.
10105 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10106 EMACS_INT, for values that are known to be in character range.
10107 This doesn't fix any bugs but is the usual style inside Emacs and
10108 may generate better code on 32-bit machines.
10109
34206dd2
PE
10110 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10111 This is for reasons similar to the recent CHAR_STRING fix.
10112 * charset.c (Fencode_char): Check that character arg is actually
10113 a character. Pass an int to ENCODE_CHAR.
10114 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10115 wider than 'int', as a compile-time check to prevent future regressions
10116 in this area.
10117
c5958d4c 10118 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10119
10120 Make sure a 64-bit char is never passed to CHAR_STRING.
10121 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10122 by silently ignoring the top 32 bits, allowing some values
10123 that were far too large to be valid characters.
10124 * character.h: Include <verify.h>.
10125 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10126 arguments are no wider than unsigned, as a compile-time check
10127 to prevent future regressions in this area.
10128 * data.c (Faset):
01103c44 10129 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10130 (Fsubst_char_in_region):
10131 * fns.c (concat):
10132 * xdisp.c (decode_mode_spec_coding):
10133 Adjust to CHAR_STRING's new requirement.
10134 * editfns.c (Finsert_char, Fsubst_char_in_region):
10135 * fns.c (concat): Check that character args are actually
10136 characters. Without this test, these functions did the wrong
10137 thing with wildly out-of-range values on 64-bit hosts.
10138
d37ca623
PE
10139 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10140 These casts should not be needed on 32-bit hosts, either.
10141 * keyboard.c (read_char):
10142 * lread.c (Fload): Remove casts to unsigned.
10143
ea204efb
PE
10144 * lisp.h (UNSIGNED_CMP): New macro.
10145 This fixes comparison bugs on 64-bit hosts.
10146 (ASCII_CHAR_P): Use it.
10147 * casefiddle.c (casify_object):
01103c44 10148 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10149 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10150 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10151 * dispextern.h (FACE_FROM_ID):
10152 * keyboard.c (read_char): Use UNSIGNED_CMP.
10153
41cb286c
PE
10154 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10155 not to EMACS_INT, to avoid GCC warning.
10156
4a1b9832
PE
10157 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10158
55daad71
PE
10159 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10160 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10161 isn't needed on 32-bit machines.
8f95c75c 10162
01103c44
PE
10163 * buffer.c (Fgenerate_new_buffer_name):
10164 Use EMACS_INT for count, not int.
0ceccced 10165 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10166
10167 * data.c (Qcompiled_function): Now static.
10168
c6f072e7
PE
10169 * window.c (window_body_lines): Now static.
10170
20ce5912
PE
10171 * image.c (gif_load): Rename local to avoid shadowing.
10172
9c4c5f81
PE
10173 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10174 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10175 * alloc.c (make_save_value): Integer argument is now of type
10176 ptrdiff_t, not int.
10177 (mark_object): Use ptrdiff_t, not int.
10178 * lisp.h (pD): New macro.
10179 * print.c (print_object): Use it.
10180
c0c5c8ae
PE
10181 * alloc.c: Use EMACS_INT, not int, to count objects.
10182 (total_conses, total_markers, total_symbols, total_vector_size)
10183 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10184 (total_free_floats, total_floats, total_free_intervals)
10185 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10186 Now EMACS_INT, not int. All uses changed.
10187 (Fgarbage_collect): Compute overall total using a double, so that
10188 integer overflow is less likely to be a problem. Check for overflow
10189 when converting back to an integer.
5a25e253
PE
10190 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10191 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10192 These were 'int' variables that could overflow on 64-bit hosts;
10193 they were never used, so remove them instead of repairing them.
211a0b2a 10194 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10195 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10196 Previously, this ceilinged at INT_MAX, but that doesn't work on
10197 64-bit machines.
e46bb31a 10198 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10199
c78baabf 10200 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10201 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10202 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10203 when a (possibly-narrower) signed value would do just as well.
10204 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10205
c9d624c6
PE
10206 * alloc.c: Catch some string size overflows that we were missing.
10207 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10208 for convenience in STRING_BYTES_MAX.
10209 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10210 The definition here is exact; the one in lisp.h was approximate.
10211 (allocate_string_data): Check for string overflow. This catches
10212 some instances we weren't catching before. Also, it catches
10213 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10214 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10215 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10216
c9d624c6
PE
10217 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10218 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10219 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10220
353032ce
PE
10221 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10222
2bccce07
PE
10223 * alloc.c (Fmake_string): Check for out-of-range init.
10224
0ac30604
SM
102252011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10226
10227 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10228
c195f2de
JD
102292011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10230
10231 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10232 xg_get_default_scrollbar_width.
10233
10234 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10235 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10236 (style_changed_cb): Call update_theme_scrollbar_width and call
10237 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10238 all frames (Bug#8505).
10239 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10240 Call gtk_window_set_resizable if HAVE_GTK3.
10241 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10242 and height if HAVE_GTK3 (Bug#8505).
10243 (scroll_bar_width_for_theme): New variable.
10244 (update_theme_scrollbar_width): New function.
10245 (xg_get_default_scrollbar_width): Move code to
10246 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10247 (xg_initialize): Call update_theme_scrollbar_width.
10248
10249 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10250
10251 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10252
e10ac9f1
MR
102532011-06-12 Martin Rudalics <rudalics@gmx.at>
10254
10255 * frame.c (make_frame): Call other_buffer_safely instead of
10256 other_buffer.
10257
10258 * window.c (temp_output_buffer_show): Call display_buffer with
10259 second argument Vtemp_buffer_show_specifiers and reset latter
10260 immediately after the call.
10261 (Vtemp_buffer_show_specifiers): New variable.
10262 (auto_window_vscroll_p, next_screen_context_lines)
10263 (Vscroll_preserve_screen_position): Remove leading asterisks from
10264 doc-strings.
10265
2d3c217e 102662011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10267
7b7f97e8 10268 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10269 * buffer.c (Qclone_number): Remove for now, as it's unused.
10270 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10271 (record_buffer): Remove unused local.
10272 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10273 (set_frame_buffer_list): Remove; unused.
10274 * frame.h (other_visible_frames): Remove decl.
10275 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10276 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10277 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10278 if HAVE_GPM.
10279 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10280 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10281 Define only if HAVE_GPM.
10282 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10283 (update_hints_inhibit): Remove; never set. All uses removed.
10284 * widgetprv.h (emacsFrameClassRec): Remove decl.
10285 * window.c (delete_deletable_window): Now returns void, since it
10286 wasn't returning anything.
10287 (compare_window_configurations): Remove unused locals.
10288 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10289 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10290 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10291 the same widths as pointers. This follows up on the 2011-05-06 patch.
10292 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10293 * xterm.h: Likewise.
10294 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10295
1384b89e
JB
102962011-06-12 Juanma Barranquero <lekktu@gmail.com>
10297
10298 * makefile.w32-in: Update dependencies.
10299 (LISP_H): Add lib/intprops.h.
10300
1100a63c
CY
103012011-06-11 Chong Yidong <cyd@stupidchicken.com>
10302
10303 * image.c (gif_load): Add animation frame delay to the metadata.
10304 (syms_of_image): Use DEFSYM. New symbol `delay'.
10305
6198ccd0
MR
103062011-06-11 Martin Rudalics <rudalics@gmx.at>
10307
10308 * window.c (delete_deletable_window): Re-add.
10309 (Fset_window_configuration): Rewrite to handle dead buffers and
10310 consequently deletable windows.
10311 (window_tree, Fwindow_tree): Remove. Supply functionality in
10312 window.el.
10313 (compare_window_configurations): Simplify code.
10314
b6e3633c
AS
103152011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10316
1ab0dee5
AS
10317 * image.c (imagemagick_load_image): Fix type mismatch.
10318 (Fimagemagick_types): Likewise.
10319
b6e3633c
AS
10320 * window.h (replace_buffer_in_windows): Declare.
10321
9397e56f
MR
103222011-06-11 Martin Rudalics <rudalics@gmx.at>
10323
10324 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10325 Qclone_number. Remove external declaration of Qdelete_window.
10326 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10327 code.
640c8776
SM
10328 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10329 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10330 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10331 buffer list implementation.
10332 (other_buffer_safely): New function.
10333 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10334 calls to replace_buffer_in_windows and
10335 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10336 if allowed.
10337 (record_buffer): Inhibit quitting and rewrite using quittable
10338 functions. Run Qbuffer_list_update_hook if allowed.
10339 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10340 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10341 Move switch-to-buffer to window.el.
9397e56f
MR
10342 (bury-buffer): Move to window.el.
10343 (Vbuffer_list_update_hook): New variable.
10344
10345 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10346 section.
10347
10348 * window.h (resize_frame_windows): Move up in code.
10349 (Fwindow_frame): Remove EXFUN.
10350 (replace_buffer_in_all_windows): Remove prototype.
10351 (replace_buffer_in_windows_safely): Add prototype.
10352
10353 * window.c: Declare Qdelete_window static again. Move down
10354 declaration of select_count.
10355 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10356 (Fother_window): Move to window.el.
10357 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10358 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10359 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10360 window.el.
10361 (replace_buffer_in_windows): Implement by calling
10362 Qreplace_buffer_in_windows.
10363 (replace_buffer_in_all_windows): Remove with some functionality
10364 moved into replace_buffer_in_windows_safely.
10365 (replace_buffer_in_windows_safely): New function.
10366 (select_window_norecord, select_frame_norecord): Move in front
10367 of run_window_configuration_change_hook. Remove now obsolete
10368 declarations.
640c8776
SM
10369 (Fset_window_buffer): Rewrite doc-string.
10370 Call Qrecord_window_buffer.
9397e56f
MR
10371 (keys_of_window): Move binding for other-window to window.el.
10372
b50691aa
CY
103732011-06-11 Chong Yidong <cyd@stupidchicken.com>
10374
10375 * dispextern.h (struct image): Replace data member, whose int_val
10376 and ptr_val fields were not used by anything, with a single
10377 lisp_val object.
10378
10379 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10380 (gif_clear_image, gif_load, imagemagick_load_image)
10381 (gs_clear_image, gs_load): Callers changed.
10382
3f754b86
PE
103832011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10384
cca69397
PE
10385 * buffer.h: Include <time.h>, for time_t.
10386 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10387
109e28d0
PE
10388 Fix minor problems found by static checking.
10389
60737f02
PE
10390 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10391
4b66faf3
PE
10392 Make identifiers static if they are not used in other modules.
10393 * data.c (Qcompiled_function, Qframe, Qvector):
10394 * image.c (QimageMagick, Qsvg):
10395 * minibuf.c (Qmetadata):
10396 * window.c (resize_window_check, resize_root_window): Now static.
10397 * window.h (resize_window_check, resize_root_window): Remove decls.
10398
109e28d0
PE
10399 * window.c (window_deletion_count, delete_deletable_window):
10400 Remove; unused.
46a4ce9e
PE
10401 (window_body_lines): Now static.
10402 (Fdelete_other_windows_internal): Mark vars as initialized.
10403 Make sure 'resize_failed' is initialized.
10404 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10405 (resize_window_apply): Remove unused local.
10406 * window.h (delete_deletable_window): Remove decl.
10407
109e28d0 10408 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10409 (imagemagick_load_image): Fix pointer signedness problem by changing
10410 last arg from unsigned char * to char *. All uses changed.
10411 Also, fix a local for similar reasons.
10412 Remove unused locals. Remove locals to avoid shadowing.
10413 (fn_rsvg_handle_free): Remove; unused.
10414 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10415 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10416
3f754b86
PE
10417 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10418
2547adb1
CY
104192011-06-10 Chong Yidong <cyd@stupidchicken.com>
10420
10421 * image.c (gif_load): Fix omitted cast error introduced by
10422 2011-06-06 change.
10423
2c8e37d4
MR
104242011-06-10 Martin Rudalics <rudalics@gmx.at>
10425
10426 * window.h (resize_proportionally, orig_total_lines)
10427 (orig_top_line): Remove from window structure.
10428 (set_window_height, set_window_width, change_window_heights)
10429 (Fdelete_window): Remove prototypes.
10430 (resize_frame_windows): Remove duplicate declaration.
10431
440a42e3
EZ
104322011-06-10 Eli Zaretskii <eliz@gnu.org>
10433
10434 * window.h (resize_frame_windows, resize_window_check)
10435 (delete_deletable_window, resize_root_window)
10436 (resize_frame_windows): Declare prototypes.
10437
10438 * window.c (resize_window_apply): Make definition be "static" to
10439 match the prototype.
10440
562dd5e9
MR
104412011-06-10 Martin Rudalics <rudalics@gmx.at>
10442
10443 * window.c: Remove declarations of Qwindow_size_fixed,
10444 window_min_size_1, window_min_size_2, window_min_size,
10445 size_window, window_fixed_size_p, enlarge_window, delete_window.
10446 Remove static from declaration of Qdelete_window, it's
10447 temporarily needed by Fbury_buffer.
10448 (replace_window): Don't assign orig_top_line and
10449 orig_total_lines.
10450 (Fdelete_window, delete_window): Remove. Window deletion is
10451 handled by window.el.
640c8776
SM
10452 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10453 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10454 (Fdelete_other_windows): Remove. Deleting other windows is
10455 handled by window.el.
10456 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10457 handled in window.el.
10458 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10459 Window minimum sizes are handled in window.el.
10460 (shrink_windows, size_window, set_window_height)
10461 (set_window_width, change_window_heights, window_height)
10462 (window_width, CURBEG, CURSIZE, enlarge_window)
10463 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10464 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10465 handled in window.el.
10466 (make_dummy_parent): Rename to make_parent_window and give it a
10467 second argument horflag.
10468 (make_window): Don't set resize_proportionally any more.
10469 (Fsplit_window): Remove. Windows are split in window.el.
10470 (save_restore_action, save_restore_orig_size)
10471 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10472 Resize mini windows in window.el.
10473 (grow_mini_window, shrink_mini_window): Implement by calling
10474 Qresize_root_window_vertically, resize_window_check and
10475 resize_window_apply.
640c8776
SM
10476 (saved_window, Fset_window_configuration, save_window_save):
10477 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10478 resize_proportionally.
10479 (window_min_height, window_min_width): Move to window.el.
10480 (keys_of_window): Move bindings for delete-other-windows,
10481 split-window, delete-window and enlarge-window to window.el.
10482
10483 * buffer.c: Temporarily extern Qdelete_window.
10484 (Fbury_buffer): Temporarily call Qdelete_window instead of
10485 Fdelete_window (Fbury_buffer will move to window.el soon).
10486
10487 * frame.c (set_menu_bar_lines_1): Remove code handling
10488 orig_top_line and orig_total_lines.
10489
10490 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10491 set_window_height but set heights directly.
10492 (change_frame_size_1): Use resize_frame_windows.
10493
10494 * xdisp.c (init_xdisp): Don't use set_window_height but set
10495 heights directly.
10496
640c8776
SM
10497 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10498 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10499 run_window_configuration_change_hook.
10500
10501 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10502 instead of change_window_heights and run
10503 run_window_configuration_change_hook.
10504
1a13852e
MR
105052011-06-09 Martin Rudalics <rudalics@gmx.at>
10506
10507 * window.c (replace_window): Rename second argument REPLACEMENT to
10508 NEW. New third argument SETFLAG. Rewrite.
10509 (delete_window, make_dummy_parent): Call replace_window with
10510 third argument 1.
10511 (window_list_1): Move down in code.
10512 (run_window_configuration_change_hook): Move set_buffer part
10513 before select_frame_norecord part in order to unwind correctly.
10514 Rename count1 to count.
10515 (recombine_windows, delete_deletable_window, resize_root_window)
10516 (Fdelete_other_windows_internal)
10517 (Frun_window_configuration_change_hook, make_parent_window)
10518 (resize_window_check, resize_window_apply, Fresize_window_apply)
10519 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10520 (Fdelete_window_internal, Fresize_mini_window_internal):
10521 New functions.
1a13852e
MR
10522 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10523
f3d1777e
MR
105242011-06-08 Martin Rudalics <rudalics@gmx.at>
10525
496e208e
MR
10526 * window.h (window): Add some new members to window structure -
10527 normal_lines, normal_cols, new_total, new_normal, clone_number,
10528 splits, nest, prev_buffers, next_buffers.
10529 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10530 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10531
f3d1777e
MR
10532 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10533 Remove.
496e208e
MR
10534 (make_dummy_parent): Set new members of windows structure.
10535 (make_window): Move down in code. Handle new members of window
10536 structure.
10537 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10538 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10539 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10540 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10541 (Fset_window_next_buffers, Fset_window_clone_number):
10542 New functions.
496e208e
MR
10543 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10544 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10545 Doc-string fixes.
10546 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10547 Argument WINDOW can be now internal window too.
10548 (Fwindow_use_time): Move up in code.
10549 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10550 Rewrite doc-string.
10551 (Fset_window_configuration, saved_window)
10552 (Fcurrent_window_configuration, save_window_save): Handle new
10553 members of window structure.
b9e809c2
MR
10554 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10555 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10556 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10557 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10558 Qget_mru_window, Qresize_root_window,
10559 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10560 Qauto_buffer_name; staticpro them.
f3d1777e 10561
abde8f8c
MR
105622011-06-07 Martin Rudalics <rudalics@gmx.at>
10563
10564 * window.c (Fwindow_total_size, Fwindow_left_column)
10565 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10566 (Fwindow_list_1): New functions.
10567 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10568 (Fwindow_width, Fscroll_left, Fscroll_right):
10569 Use window_body_cols instead of window_box_text_cols.
10570 (delete_window, Fset_window_configuration):
10571 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10572 (delete_all_subwindows): Take a window as argument and not a
10573 structure. Rewrite.
190b47e6
MR
10574 (window_loop): Remove handling of GET_LRU_WINDOW and
10575 GET_LARGEST_WINDOW.
10576 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10577
10578 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10579 window_box_text_cols. delete_all_subwindows now takes a
10580 Lisp_Object as argument.
abde8f8c 10581
640c8776
SM
10582 * indent.c (compute_motion, Fcompute_motion):
10583 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10584
fa8a67e6
MR
10585 * frame.c (delete_frame): Call delete_all_subwindows with root
10586 window as argument.
10587
a54e3482
DC
105882011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10589
10590 * fns.c (Fputhash): Document return value.
10591
60002bf5
CY
105922011-06-06 Chong Yidong <cyd@stupidchicken.com>
10593
10594 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10595
0c671da6 105962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10597
b862a52a 10598 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10599
be44ca6c
PE
10600 Check for overflow when converting integer to cons and back.
10601 * charset.c (Fdefine_charset_internal, Fdecode_char):
10602 Use cons_to_unsigned to catch overflow.
10603 (Fencode_char): Use INTEGER_TO_CONS.
10604 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10605 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10606 * data.c (long_to_cons, cons_to_long): Remove.
10607 (cons_to_unsigned, cons_to_signed): New functions.
10608 These signal an error for invalid or out-of-range values.
10609 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10610 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10611 * font.c (Ffont_variation_glyphs):
10612 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10613 * lisp.h: Include <intprops.h>.
10614 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10615 (cons_to_signed, cons_to_unsigned): New decls.
10616 (long_to_cons, cons_to_long): Remove decls.
10617 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10618 (Fprimitive_undo): Use CONS_TO_INTEGER.
10619 * xfns.c (Fx_window_property): Likewise.
10620 * xselect.c: Include <limits.h>.
10621 (x_own_selection, selection_data_to_lisp_data):
10622 Use INTEGER_TO_CONS.
10623 (x_handle_selection_request, x_handle_selection_clear)
10624 (x_get_foreign_selection, Fx_disown_selection_internal)
10625 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10626 (lisp_data_to_selection_data): Use cons_to_unsigned.
10627 (x_fill_property_data): Use cons_to_signed.
10628 Report values out of range.
10629
d1f3d2af
PE
10630 Check for buffer and string overflow more precisely.
10631 * buffer.h (BUF_BYTES_MAX): New macro.
10632 * lisp.h (STRING_BYTES_MAX): New macro.
10633 * alloc.c (Fmake_string):
10634 * character.c (string_escape_byte8):
10635 * coding.c (coding_alloc_by_realloc):
10636 * doprnt.c (doprnt):
10637 * editfns.c (Fformat):
10638 * eval.c (verror):
10639 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10640 since they may not be the same number.
10641 * editfns.c (Finsert_char):
10642 * fileio.c (Finsert_file_contents):
10643 Likewise for BUF_BYTES_MAX.
10644
dd52fcea
PE
10645 * image.c: Use ptrdiff_t, not int, for sizes.
10646 (slurp_file): Switch from int to ptrdiff_t.
10647 All uses changed.
10648 (slurp_file): Check that file size fits in both size_t (for
10649 malloc) and ptrdiff_t (for sanity and safety).
10650
7f9bbdbb
PE
10651 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10652 if b->modtime has its maximal value.
10653
dfe18f82
PE
10654 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10655
84acfcf0
PE
10656 Don't assume time_t can fit into int.
10657 * buffer.h (struct buffer.modtime): Now time_t, not int.
10658 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10659 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10660
ccd9a01a
PE
10661 Minor fixes for signed vs unsigned integers.
10662 * character.h (MAYBE_UNIFY_CHAR):
10663 * charset.c (maybe_unify_char):
10664 * keyboard.c (read_char, reorder_modifiers):
10665 XINT -> XFASTINT, since the integer must be nonnegative.
10666 * ftfont.c (ftfont_spec_pattern):
10667 * keymap.c (access_keymap, silly_event_symbol_error):
10668 XUINT -> XFASTINT, since the integer must be nonnegative.
10669 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10670 since it makes no difference and we prefer signed.
10671 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10672 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10673 nonnegative.
10674
d6d100dd
SM
106752011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10676
10677 * window.h (Fwindow_frame): Declare.
10678
2b6148e4
PE
106792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10680
10681 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10682 (SPARE_MEMORY): Always define.
10683 (LARGE_REQUEST): Remove.
10684 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10685
f230ecc9
MR
106862011-06-06 Martin Rudalics <rudalics@gmx.at>
10687
727e958e
MR
10688 * lisp.h: Move EXFUNS for Fframe_root_window,
10689 Fframe_first_window and Fset_frame_selected_window to window.h.
10690
10691 * window.h: Move EXFUNS for Fframe_root_window,
10692 Fframe_first_window and Fset_frame_selected_window here from
10693 lisp.h.
10694
10695 * frame.c (Fwindow_frame, Fframe_first_window)
10696 (Fframe_root_window, Fframe_selected_window)
10697 (Fset_frame_selected_window): Move to window.c.
10698 (Factive_minibuffer_window): Move to minibuf.c.
10699 (Fother_visible_frames_p): New function.
10700
10701 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10702
f230ecc9
MR
10703 * window.c (decode_window, decode_any_window): Move up in code.
10704 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10705 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10706 (Fwindow_buffer): Move up and rewrite doc-string.
10707 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10708 (Fwindow_prev): New functions.
727e958e
MR
10709 (Fwindow_frame): Move here from frame.c. Accept any window as
10710 argument.
10711 (Fframe_root_window, Fframe_first_window)
10712 (Fframe_selected_window): Move here from frame.c. Accept frame
10713 or arbitrary window as argument. Update doc-strings.
10714 (Fminibuffer_window): Move up in code.
10715 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10716 (Fset_frame_selected_window): Move here from frame.c.
10717 Marginal rewrite.
727e958e
MR
10718 (Fselected_window, select_window, Fselect_window): Move up in
10719 code. Minor doc-string fixes.
f230ecc9 10720
4d09bcf6
PE
107212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10722
10723 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10724 Do not assume that spare memory exists; that assumption is valid
10725 only if SYSTEM_MALLOC.
10726 (LARGE_REQUEST): New macro, so that the issue of large requests
10727 is separated from the issue of spare memory.
10728
810928a2
AS
107292011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10730
172418ad
AS
10731 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10732 format. (Bug#8806)
10733
43f862f7
AS
10734 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10735
810928a2
AS
10736 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10737 before statements.
10738
a059fe24
JD
107392011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10740
10741 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10742
10743 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10744
10745 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10746 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10747
989bf368
JB
107482011-06-05 Juanma Barranquero <lekktu@gmail.com>
10749
10750 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10751
4b80f674
CY
107522011-06-04 Chong Yidong <cyd@stupidchicken.com>
10753
10754 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10755 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10756 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10757 New error handlers.
4b80f674
CY
10758 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10759 Obey Vx_select_enable_clipboard_manager. Catch errors in
10760 x_clipboard_manager_save (Bug#8779).
10761 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10762 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10763
99a33b77 107642011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10765
10766 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10767
99a33b77 107682011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10769
10770 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10771 in the current matrix if keep_current_p is non-zero.
10772
8264569d
EZ
107732011-06-04 Eli Zaretskii <eliz@gnu.org>
10774
10775 * bidi.c (bidi_level_of_next_char): Fix last change.
10776
57f97249
EZ
107772011-06-03 Eli Zaretskii <eliz@gnu.org>
10778
fec2107c 10779 Support bidi reordering of text covered by display properties.
57f97249 10780
fec2107c
EZ
10781 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10782 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10783 (bidi_cache_search, bidi_cache_iterator_state)
10784 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10785 (bidi_level_of_next_char, bidi_move_to_visually_next):
10786 Support character positions inside a run of characters covered by a
fec2107c
EZ
10787 display string.
10788 (bidi_paragraph_init, bidi_resolve_explicit_1)
10789 (bidi_level_of_next_char): Call bidi_fetch_char and
10790 bidi_fetch_char_advance instead of FETCH_CHAR and
10791 FETCH_CHAR_ADVANCE.
10792 (bidi_init_it): Initialize new members.
10793 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10794 definitions.
10795 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10796 instead of using explicit *_CHAR codes.
d6d100dd
SM
10797 (bidi_resolve_explicit, bidi_resolve_weak):
10798 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10799 bidirectional text is supported only in multibyte buffers.
10800 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10801 it to initialize the frame_window_p member of struct bidi_it.
10802 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10803 (bidi_resolve_explicit, bidi_resolve_weak)
10804 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10805 bidi_it->nchars is non-positive.
10806 (bidi_level_of_next_char): Don't try to lookup the cache for the
10807 next/previous character if nothing is cached there yet, or if we
10808 were just reseat()'ed to a new position.
c40e2fb2 10809
0e14fe90
EZ
10810 * xdisp.c (set_cursor_from_row): Set start and stop points
10811 according to the row's direction when priming the loop that looks
10812 for the glyph on which to display cursor.
10813 (single_display_spec_intangible_p): Function deleted.
10814 (display_prop_intangible_p): Reimplement to call
10815 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10816 Accept 3 additional arguments needed by handle_display_spec.
10817 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10818 values: lists, `(when COND...)' forms, etc.
10819 (single_display_spec_string_p): Support property values that are
10820 lists with the argument STRING its top-level element.
10821 (display_prop_string_p): Fix the condition for processing a
10822 property that is a list to be consistent with handle_display_spec.
fec2107c 10823 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10824 last portion of handle_display_prop.
10825 (compute_display_string_pos): Accept additional argument
10826 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10827 value of a `display' property is a "replacing spec".
10828 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10829 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10830 the display property, but just return a value indicating whether
10831 the display property will replace the characters it covers.
10832 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10833 frame_window_p members of struct bidi_it.
d6d100dd
SM
10834 (compute_display_string_pos, compute_display_string_end):
10835 New functions.
fec2107c
EZ
10836 (push_it): Accept second argument POSITION, where pop_it should
10837 jump to continue iteration.
10838 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10839
fec2107c
EZ
10840 * keyboard.c (adjust_point_for_property): Adjust the call to
10841 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10842
10843 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10844 (bidi_init_it): Update prototypes.
10845 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10846 (compute_display_string_pos, compute_display_string_end):
10847 Declare prototypes.
fec2107c
EZ
10848 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10849 EMACS_INT.
fc6f18ce 10850
40087514 108512011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10852
57f53182
PE
10853 Malloc failure behavior now depends on size of allocation.
10854 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10855 * lisp.h: Change signatures accordingly.
10856 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10857 All callers changed. (Bug#8762)
10858
10859 * gnutls.c: Use Emacs's memory allocators.
10860 Without this change, the gnutls library would invoke malloc etc.
10861 directly, which causes problems on non-SYNC_INPUT hosts, and which
10862 runs afoul of improving memory_full behavior. (Bug#8761)
10863 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10864 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10865 xfree instead of the default malloc, realloc, free.
10866 (Fgnutls_boot): No need to check for memory allocation failure,
10867 since xmalloc does that for us.
10868
ac32cd99 10869 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10870 * category.c (hash_get_category_set):
10871 * ccl.c (ccl_driver):
10872 * charset.c (Fdefine_charset_internal):
10873 * charset.h (struct charset.hash_index):
10874 * composite.c (get_composition_id, gstring_lookup_cache)
10875 (composition_gstring_put_cache):
10876 * composite.h (struct composition.hash_index):
10877 * dispextern.h (struct image.hash):
10878 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10879 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10880 (hashfn_equal, hashfn_user_defined, make_hash_table)
10881 (maybe_resize_hash_table, hash_lookup, hash_put)
10882 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10883 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10884 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10885 * image.c (make_image, search_image_cache, lookup_image)
10886 (xpm_put_color_table_h):
10887 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10888 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10889 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10890 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10891 * alloc.c (allocate_vectorlike):
10892 Check for overflow in vector size calculations.
10893 * ccl.c (ccl_driver):
10894 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10895 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10896 need to be updated by these changes.
40087514
PE
10897 * fns.c (make_hash_table, maybe_resize_hash_table):
10898 Check for integer overflow with large hash tables.
0de4bb68
PE
10899 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10900 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10901 (SXHASH_REDUCE): New macro.
10902 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10903 Use it instead of discarding useful hash info with large hash values.
10904 (sxhash_float): New function.
10905 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10906 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10907 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10908 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10909 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10910 Adjust signatures to match updated version of code.
10911 (consing_since_gc): Now EMACS_INT, since a single hash table can
10912 use more than INT_MAX bytes.
10913
698d32e2
DN
109142011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10915
10916 Make it possible to build with GCC-4.6+ -O2 -flto.
10917
10918 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10919
fd6fa53f
SM
109202011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10921
10922 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10923 Call minibuffer-inactive-mode.
10924
864db017
JB
109252011-05-31 Juanma Barranquero <lekktu@gmail.com>
10926
10927 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10928 Update dependencies.
10929
2ad0baf4
DN
109302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10931
10932 * data.c (init_data): Remove code for UTS, this system is not
10933 supported anymore.
10934
4fcc2638
DN
109352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10936
10937 Don't force ./temacs to start in terminal mode.
10938
10939 * frame.c (make_initial_frame): Initialize faces in all cases, not
10940 only when CANNOT_DUMP is defined.
10941 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10942
c56e0fd5
DN
109432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10944
10945 * dispnew.c (add_window_display_history): Use const for the string
10946 pointer. Remove declaration, not needed.
10947
333d54da 109482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10949
55d4c1b2 10950 Use 'inline', not 'INLINE'.
333d54da 10951 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10952 * alloc.c, fontset.c (INLINE): Remove.
10953 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10954 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10955 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10956 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10957 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10958
738db178
DN
109592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10960
10961 Make it possible to run ./temacs.
10962
10963 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10964 syms_of_callproc does the same thing. Remove test for
10965 "initialized", do it in the caller.
10966 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10967
620c53a6
SM
109682011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10969
10970 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10971 (read_minibuf): Use get_minibuffer.
10972 (syms_of_minibuf): Use DEFSYM.
10973 (Qmetadata): New var.
10974 * data.c (Qbuffer): Don't make it static.
10975 (syms_of_data): Use DEFSYM.
10976
e003a292
PE
109772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10978
10979 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10980 (CCL_CODE_MIN): New macro.
10981
ed008a6d
PE
109822011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10983
3687c2ef
PE
10984 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10985
ed008a6d
PE
10986 * eval.c (Qdebug): Now static.
10987 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10988 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10989 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10990
d66c4c7c
CY
109912011-05-29 Chong Yidong <cyd@stupidchicken.com>
10992
10993 * image.c: Various fixes to ImageMagick code comments.
10994 (Fimagemagick_types): Doc fix.
10995
5fbc2025
PE
109962011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10997
0196f88a
PE
10998 Minor fixes prompted by GCC 4.6.0 warnings.
10999
11000 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11001
5fbc2025
PE
11002 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11003 (x_clipboard_manager_save_all): Move extern decl to ...
11004 * xterm.h: ... here, so that it can be checked for consistency.
11005
1dd3c2d9
CY
110062011-05-29 Chong Yidong <cyd@stupidchicken.com>
11007
11008 * xselect.c (x_clipboard_manager_save_frame)
11009 (x_clipboard_manager_save_all): New functions.
11010 (Fx_clipboard_manager_save): Lisp function deleted.
11011
11012 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11013 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11014
11015 * xterm.h: Update prototype.
11016
5ba6571d
WX
110172011-05-28 William Xu <william.xwl@gmail.com>
11018
11019 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11020 exiting (Bug#8239).
11021
3eaff834
JM
110222011-05-28 Jim Meyering <meyering@redhat.com>
11023
e1900994 11024 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11025 * fns.c (to_uchar): Define.
11026 (crypto_hash_function): Use it to convert some newly-signed
11027 variables to unsigned, to avoid sign-extension bugs. For example,
11028 without this change, (md5 "truc") would evaluate to
11029 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11030 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11031 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11032
0f6990a7
PE
110332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11034
11035 Integer overflow fixes.
c8a9ca5a 11036
08686060
PE
11037 * dbusbind.c: Serial number integer overflow fixes.
11038 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11039 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11040 to hold a serial number that is too large for a fixnum.
11041 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11042 Check for serial numbers out of range. Decode any serial number
59568bf0 11043 that was so large that it became a float. (Bug#8722)
08686060 11044
2d1fc3c7
PE
11045 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11046 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11047 Use XFASTINT rather than XUINT when numbers are nonnegative.
11048 (xd_append_arg, Fdbus_method_return_internal):
11049 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11050 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11051 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11052 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11053 (Bug#8722)
2d1fc3c7 11054
c8a9ca5a
PE
11055 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11056
519e1d69
PE
11057 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11058
6df6ae42 11059 ccl: Add integer overflow checks.
30569699
PE
11060 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11061 (IN_INT_RANGE): New macros.
11062 (ccl_driver): Use them to check for integer overflow when
11063 decoding a CCL program. Many of the new checks are whether XINT (x)
11064 fits in int; it doesn't always, on 64-bit hosts. The new version
11065 doesn't catch all possible integer overflows, but it's an
847044ea 11066 improvement. (Bug#8719)
30569699 11067
c11285dc
PE
11068 * alloc.c (make_event_array): Use XINT, not XUINT.
11069 There's no need for unsigned here.
11070
fdccd48e
PE
11071 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11072 This follows up to the 2011-05-06 change that substituted uintptr_t
11073 for EMACS_INT. This case wasn't caught back then.
11074
37910ab2
PE
11075 Rework Fformat to avoid integer overflow issues.
11076 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11077 now (part of C89). Include <verify.h>.
11078 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11079 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11080 (Fformat): Avoid the prepass trying to compute sizes; it was only
11081 approximate and thus did not catch overflow reliably. Instead, walk
11082 through the format just once, formatting and computing sizes as we go,
11083 checking for integer overflow at every step, and allocating a larger
11084 buffer as needed. Keep track separately whether the format is
11085 multibyte. Keep only the most-recently calculated precision, rather
11086 than them all. Record whether each argument has been converted to
11087 string. Use EMACS_INT, not int, for byte and char and arg counts.
11088 Support field widths and precisions larger than INT_MAX. Avoid
11089 sprintf's undefined behavior with conversion specifications such as %#d
11090 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11091 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11092 formatting out-of-range floating point numbers with int
9173deec 11093 formats. (Bug#8668)
37910ab2 11094
2e6578fb
PE
11095 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11096
0ae6bdee
PE
11097 * data.c: Avoid integer truncation in expressions involving floats.
11098 * data.c: Include <intprops.h>.
11099 (arith_driver): When there's an integer overflow in an expression
11100 involving floating point, convert the integers to floating point
11101 so that the resulting value does not suffer from catastrophic
11102 integer truncation. For example, on a 64-bit host (* 4
11103 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11104 Do not rely on undefined behavior after integer overflow.
11105
de883a70
PE
11106 merge count_size_as_multibyte, parse_str_to_multibyte
11107 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11108 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11109 Check for integer overflow.
11110 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11111 since it's now a duplicate of the other. This is more of
11112 a character than a buffer op, so better that it's in character.c.
11113 * fns.c, print.c: Adjust to above changes.
11114
2ff916cb
PE
111152011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11116
11117 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11118
f1b54466
PE
111192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11120
fb1ac845
PE
11121 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11122 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11123 (x_clipboard_manager_save): Now static.
11124 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11125
f1b54466
PE
11126 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11127 (crypto_hash_function): Now static.
11128 Fix pointer signedness problems. Avoid unnecessary initializations.
11129
a9f737ee
CY
111302011-05-27 Chong Yidong <cyd@stupidchicken.com>
11131
11132 * termhooks.h (Vselection_alist): Make it terminal-local.
11133
11134 * terminal.c (create_terminal): Initialize it.
11135
11136 * xselect.c: Support for clipboard managers.
11137 (Vselection_alist): Move to termhooks.h as terminal-local var.
11138 (LOCAL_SELECTION): New macro.
11139 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11140 (symbol_to_x_atom): Remove gratuitous arg.
11141 (x_handle_selection_request, lisp_data_to_selection_data)
11142 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11143 (x_own_selection, x_get_local_selection, x_convert_selection):
11144 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11145 (some_frame_on_display): Delete unused function.
11146 (Fx_own_selection_internal, Fx_get_selection_internal)
11147 (Fx_disown_selection_internal, Fx_selection_owner_p)
11148 (Fx_selection_exists_p): New optional frame arg.
11149 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11150 (x_handle_selection_clear): Don't treat other terminals with the
11151 same keyboard specially. Use the terminal-local Vselection_alist.
11152 (x_clear_frame_selections): Use Frun_hook_with_args.
11153
11154 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11155
11156 * xterm.h: Add support for those atoms.
11157
e067f0c1
CY
111582011-05-26 Chong Yidong <cyd@stupidchicken.com>
11159
11160 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11161 (converted_selections, conversion_fail_tag): New global variables.
11162 (x_selection_request_lisp_error): Free the above.
11163 (x_get_local_selection): Remove unnecessary code.
11164 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11165 of converted selections stored in converted_selections.
11166 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11167 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11168 (x_convert_selection): New function.
11169 (x_handle_selection_event): Simplify.
11170 (x_get_foreign_selection): Don't ignore incoming requests while
11171 waiting for an answer; this will fail when we implement
11172 SAVE_TARGETS, and seems unnecessary anyway.
11173 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11174 (Vx_sent_selection_functions): Doc fix.
11175
0f4aebc0
LL
111762011-05-26 Leo Liu <sdl.web@gmail.com>
11177
11178 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11179
e61124cd
YM
111802011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11181
11182 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11183
11184 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11185 for fringe update if it has periodic bitmap.
ac389d0c 11186 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11187 and fringe_bitmap_periodic_p.
11188
11189 * fringe.c (get_fringe_bitmap_data): New function.
11190 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11191 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11192 row. Mark glyph row for fringe update if periodicity changed.
11193
11194 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11195 for fringe update unless it has periodic bitmap.
11196
f16d9837
KH
111972011-05-25 Kenichi Handa <handa@m17n.org>
11198
11199 * xdisp.c (get_next_display_element): Set correct it->face_id for
11200 a static composition.
11201
e1b90ef6
LL
112022011-05-24 Leo Liu <sdl.web@gmail.com>
11203
11204 * deps.mk (fns.o):
11205 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11206
11207 * fns.c (crypto_hash_function, Fsha1): New function.
11208 (Fmd5): Use crypto_hash_function.
11209 (syms_of_fns): Add Ssha1.
11210
7400048f
PE
112112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11212
11213 * gnutls.c: Remove unused macros.
11214 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11215 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11216 Remove macros that are defined and never used.
11217 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11218
abb71cf4
CY
112192011-05-22 Chong Yidong <cyd@stupidchicken.com>
11220
11221 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11222 (Fx_get_selection_internal): Minor cleanup.
11223 (Fx_own_selection_internal): Rename arguments for consistency with
11224 select.el.
11225
6307db39
PE
112262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11227
11228 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11229
f3d4e0a4
CY
112302011-05-22 Chong Yidong <cyd@stupidchicken.com>
11231
11232 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11233
4d8ade89
YM
112342011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11235
11236 * dispnew.c (scrolling_window): Don't exclude the case that the
11237 last enabled row in the desired matrix touches the bottom boundary.
11238
32078c8d
GM
112392011-05-21 Glenn Morris <rgm@gnu.org>
11240
11241 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11242 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11243 and add some more files.
32078c8d 11244
7285dc67
EZ
112452011-05-20 Eli Zaretskii <eliz@gnu.org>
11246
11247 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11248 report_file_error introduced by the change from 2011-05-07.
11249
89d1bd22
PE
112502011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11251
11252 * systime.h (Time): Define only if emacs is defined.
11253 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11254 where the include path doesn't have X11/X.h by default. See
11255 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11256
cd394be1 112572011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11258
11259 * composite.c (find_automatic_composition): Fix previous change.
11260
b9704ad9
GM
112612011-05-20 Glenn Morris <rgm@gnu.org>
11262
11263 * lisp.mk: New file, split from Makefile.in.
11264 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11265 (shortlisp): Remove.
11266 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11267
4a720484
GM
112682011-05-19 Glenn Morris <rgm@gnu.org>
11269
11270 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11271 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11272 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11273 (lisp): Set the order to that of loadup.el.
11274 (shortlisp): Make it a copy of $lisp.
11275 (SOME_MACHINE_LISP): Remove.
11276 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11277 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11278
a28d4396
KH
112792011-05-18 Kenichi Handa <handa@m17n.org>
11280
11281 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11282 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11283 (find_automatic_composition): Mostly rewrite for efficiency.
11284
a2b1fa8e
JB
112852011-05-18 Juanma Barranquero <lekktu@gmail.com>
11286
11287 * makefile.w32-in: Update dependencies.
11288
8e1f5610
CS
112892011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11290
11291 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11292 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11293
7025ee00 112942011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11295
cdfa6eab
PE
11296 Fix some integer overflow issues, such as string length overflow.
11297
06d6db33
PE
11298 * insdel.c (count_size_as_multibyte): Check for string overflow.
11299
2b4560a8
PE
11300 * character.c (lisp_string_width): Check for string overflow.
11301 Use EMACS_INT, not int, for string indexes and lengths; in
11302 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11303 the resulting string length overflows an EMACS_INT; instead,
11304 report a string overflow if no precision given. When checking for
11305 precision exhaustion, use a check that cannot possibly have
11306 integer overflow. (Bug#8675)
11307 * character.h (lisp_string_width): Adjust to new signature.
11308
cb93f9be
PE
11309 * alloc.c (string_overflow): New function.
11310 (Fmake_string): Use it. This doesn't change behavior, but saves
11311 a few bytes and will simplify future changes.
11312 * character.c (string_escape_byte8): Likewise.
11313 * lisp.h (string_overflow): New decl.
11314
1a1f3366
PE
11315 Fixups, following up to the user-interface timestamp change.
11316 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11317 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11318 * msdos.c (mouse_get_pos): Likewise.
11319 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11320 * w32gui.h (Time): Define by including "systime.h" rather than by
11321 declaring it ourselves. (Bug#8664)
11322
d4e3e4d3
PE
11323 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11324 * image.c (clear_image_cache): Likewise.
11325
f6a24d19
PE
11326 * term.c (term_mouse_position): Don't assume time_t wraparound.
11327
08dc5ae6
PE
11328 Be more systematic about user-interface timestamps.
11329 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11330 and sometimes 'EMACS_UINT', to represent these timestamps.
11331 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11332 This makes the code easier to follow, and makes it easier to catch
11333 integer overflow bugs such as Bug#8664.
11334 * frame.c (Fmouse_position, Fmouse_pixel_position):
11335 Use Time, not unsigned long, for user-interface timestamps.
11336 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11337 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11338 * keyboard.h (last_event_timestamp): Likewise.
11339 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11340 * menu.h (xmenu_show): Likewise.
11341 * term.c (term_mouse_position): Likewise.
11342 * termhooks.h (struct input_event.timestamp): Likewise.
11343 (struct terminal.mouse_position_hook): Likewise.
11344 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11345 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11346 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11347 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11348 what it was before.
11349 * menu.h, termhooks.h: Include "systime.h", for Time.
11350
8e55734a
PE
11351 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11352 Don't assume that the difference between two unsigned long values
11353 can fit into an integer. At this point, we know button_down_time
11354 <= event->timestamp, so the difference must be nonnegative, so
11355 there's no need to cast the result if double-click-time is
11356 nonnegative, as it should be; check that it's nonnegative, just in
11357 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11358 apart (about 25 days). (Bug#8664)
8e55734a 11359
841f1b75 11360 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11361 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11362
3e26f69c
PE
11363 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11364 that always fit in int. Use a sentinel instead of a counter, to
11365 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11366 * frame.h (struct frame): Use int for menu_bar_items_used
11367 instead of EMACS_INT, since it always fits in int.
3e26f69c 11368
5cc152c0
PE
11369 * menu.c (grow_menu_items): Check for int overflow.
11370
d89eb65e
PE
11371 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11372
5235bd3e
PE
11373 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11374 Before, the code was not consistent. These values cannot exceed
11375 2**31 - 1 so there's no need to make them unsigned.
11376 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11377 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11378 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11379 as modifiers.
11380 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11381
bc827e23
PE
11382 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11383 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11384 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11385 presumably because the widths might not match.
11386
78eb494e
PE
11387 * window.c (size_window): Avoid needless test at loop start.
11388
04f2d78b
CB
113892011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11390
11391 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11392
d2fc7e3d 113932011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11394
11395 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11396
d2fc7e3d 113972011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11398
11399 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11400 `width' to `bar_area_x' and `bar_area_width', respectively.
11401 (x_scroll_run): Take account of fringe background extension.
11402
04f2d78b
CB
11403 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11404 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11405 `bar_area_width', respectively.
11406 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11407 background extension.
11408
79b70037
GM
114092011-05-10 Jim Meyering <meyering@redhat.com>
11410
11411 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11412
2f142cc5
JB
114132011-05-10 Juanma Barranquero <lekktu@gmail.com>
11414
11415 * image.c (Finit_image_library): Return t for built-in image types,
11416 like pbm and xbm. (Bug#8640)
11417
57679c86
AS
114182011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11419
11420 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11421
888c9e86
EZ
114222011-05-07 Eli Zaretskii <eliz@gnu.org>
11423
b0512a1d
EZ
11424 * w32console.c (Fset_screen_color): Doc fix.
11425 (Fget_screen_color): New function.
11426 (syms_of_ntterm): Defsubr it.
11427
7285dc67
EZ
11428 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11429 unlink the temporary file if Fcall_process didn't create it in the
11430 first place.
11431 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11432 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11433 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11434 cue to call_process_cleanup not to close that handle.
11435
4d3fcc8e
BK
114362011-05-07 Ben Key <bkey76@gmail.com>
11437
11438 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11439 one of two shell specific rules, either bootstrap-temacs-CMD or
11440 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11441 to the previous implementation of the bootstrap-temacs rule.
11442 The bootstrap-temacs-CMD rule is similar to the previous
11443 implementation of the bootstrap-temacs rule except that it
11444 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11445 variable.
11446
11447 These changes, along with some changes to nt/configure.bat,
11448 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11449 earlier fix to add support for --cflags and --ldflags options
11450 that include quotes so that it works whether make uses cmd or
11451 sh as the shell.
11452
b4289b64
MA
114532011-05-06 Michael Albinus <michael.albinus@gmx.de>
11454
11455 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11456 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11457 is a constant.
11458 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11459 a string. Handle both cases.
11460 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11461 (Fdbus_register_method): Use Qinvalid_function.
11462
af4c0e28
JB
114632011-05-06 Juanma Barranquero <lekktu@gmail.com>
11464
11465 * makefile.w32-in: Update dependencies.
11466 (LISP_H): Add inttypes.h and stdin.h.
11467 (PROCESS_H): Add unistd.h.
11468
c51453d9
EZ
114692011-05-06 Eli Zaretskii <eliz@gnu.org>
11470
11471 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11472 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11473
8ff0ac3c 114742011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11475
4c4b566b
PE
11476 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11477
aab2b9b5
PE
11478 * term.c (vfatal): Remove stray call to va_end.
11479 It's not needed and the C Standard doesn't allow it here anyway.
11480
c378da0b
PE
11481 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11482 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11483
288b08c7
PE
11484 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11485 bytes.
11486
e3601888
PE
11487 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11488
db6c0e74
PE
11489 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11490
dd5963ea
PE
11491 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11492
88c9450f
PE
11493 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11494
2f9442b8
PE
11495 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11496
c032b5f8
PE
11497 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11498 * charset.c (Fdefine_charset_internal): Don't initialize
11499 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11500 32-bit int (Bug#8600).
a108c10b
PE
11501
11502 * lread.c (read_integer): Be more consistent with string-to-number.
11503 Use string_to_number to do the actual conversion; this avoids
11504 rounding errors and fixes some other screwups. Without this fix,
11505 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11506 (digit_to_number): Move earlier, for benefit of read_integer.
11507 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11508 not a digit in any supported base. (Bug#8602)
a108c10b 11509
ad5f9eea
PE
11510 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11511
aec1708a
PE
11512 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11513 to match comment at start of function. This also removes a
11514 GCC warning about overflow in a 32+64-bit port.
11515
47be4ab5
PE
11516 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11517
371cac43
PE
11518 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11519 Reported by Stefan Monnier in
11520 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11521 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11522 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11523
d01a7826
PE
11524 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11525 (EMACS_UINTPTR): Likewise, with uintptr_t.
11526
7fd47d5c
PE
11527 * lisp.h: Prefer 64-bit EMACS_INT if available.
11528 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11529 on 32-bit hosts that have 64-bit int, so that they can access
11530 large files.
122b0c86
PE
11531 However, temporarily disable this change unless the temporary
11532 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11533
8727937b
PE
11534 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11535
8ac068ac
PE
11536 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11537 This removes an assumption that EMACS_INT and long are the same
11538 width as pointers. The assumption is true for Emacs porting targets
11539 now, but we want to make other targets possible.
11540 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11541 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11542 In the rest of the code, change types of integers that hold casted
11543 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11544 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11545 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11546 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11547 No need to cast type when ORing.
11548 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11549 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11550 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11551 assume EMACS_INT is the same width as char *.
11552 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11553 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11554 Remove no-longer-needed casts.
11555 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11556 (xg_tool_bar_help_callback, xg_make_tool_item):
11557 Use EMACS_INTPTR to hold an integer
11558 that will be cast to void *; this can avoid a GCC warning
11559 if EMACS_INT is not the same width as void *.
11560 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11561 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11562 (current_message_1, set_message_1):
11563 Use a local to convert to proper width without a cast.
11564 * xmenu.c (dialog_selection_callback): Likewise.
11565
ede49d71
PE
11566 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11567 Also, don't assume VALBITS / RAND_BITS is less than 5,
11568 and don't rely on undefined behavior when shifting a 1 left into
11569 the sign bit.
11570 * lisp.h (get_random): Change signature to match.
11571
2f30ecd0
PE
11572 * lread.c (hash_string): Use size_t, not int, for hash computation.
11573 Normally we prefer signed values; but hashing is special, because
11574 it's better to use unsigned division on hash table sizes so that
11575 the remainder is nonnegative. Also, size_t is the natural width
11576 for hashing into memory. The previous code used 'int', which doesn't
11577 retain enough info to hash well into very large tables.
11578 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11579
2a866e7b
PE
11580 * dbusbind.c: Don't possibly lose pointer info when converting.
11581 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11582 Use XPNTR rather than XHASH, so that the high-order bits of
11583 the pointer aren't lost when converting through void *.
11584
51639eac
PE
11585 * eval.c (Fautoload): Don't double-shift a pointer.
11586
92394119
PE
11587 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11588
dbdb9a7c
JB
115892011-05-06 Juanma Barranquero <lekktu@gmail.com>
11590
11591 * gnutls.c (DEF_GNUTLS_FN):
11592 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11593
db7a0b4f
AS
115942011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11595
11596 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11597 marker. (Bug#8610)
11598
cd394be1 115992011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11600
11601 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11602 New version that can reserve upto 2GB of heap space.
11603
f7ff1b0f 116042011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11605
11606 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11607
639c109b
TZ
116082011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11609
11610 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11611 `gnutls_certificate_set_x509_key_file'.
11612
d2127135
JB
116132011-05-05 Juanma Barranquero <lekktu@gmail.com>
11614
11615 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11616 Update dependencies.
11617
e968f4f3
JB
116182011-05-04 Juanma Barranquero <lekktu@gmail.com>
11619
11620 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11621 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11622 Remove unused parameter `fildes'.
11623 * process.c (read_process_output, send_process): Don't pass it.
11624
84d358f0
JB
116252011-05-04 Juanma Barranquero <lekktu@gmail.com>
11626
11627 Fix previous change: the library cache is defined in w32.c.
11628 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11629 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11630
0898ca10
JB
116312011-05-04 Juanma Barranquero <lekktu@gmail.com>
11632
11633 Implement dynamic loading of GnuTLS on Windows.
11634
11635 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11636 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11637 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11638 Declare.
11639
11640 * gnutls.c (Qgnutls_dll): Define.
11641 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11642 (gnutls_*): Declare function pointers.
11643 (init_gnutls_functions): New function to initialize function pointers.
11644 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11645 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11646 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11647 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11648 (emacs_gnutls_write, emacs_gnutls_read)
11649 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11650 (Fgnutls_available_p): New function.
11651 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11652 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11653 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11654
11655 * image.c: Include w32.h.
11656 (Vimage_type_cache): Delete.
11657 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11658 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11659 (w32_delayed_load): Move to w32.c.
11660
11661 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11662
11663 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11664 (w32_delayed_load): Move from image.c. When loading a library, record
11665 its filename in the :loaded-from property of the library id.
11666 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11667 Initialize and staticpro them.
11668 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11669
11670 * process.c: Include lisp.h before w32.h, not after.
11671 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11672 instead of gnutls_record_check_pending.
11673
11674 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11675
ff4de4aa
TZ
116762011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11677
11678 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11679 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11680 as passed in.
11681
abe95abb
JD
116822011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11683
11684 * xterm.c (x_set_frame_alpha): Do not set property on anything
11685 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11686
e16e55d4
JB
116872011-05-02 Juanma Barranquero <lekktu@gmail.com>
11688
11689 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11690
bafcf6a5
JB
116912011-05-02 Juanma Barranquero <lekktu@gmail.com>
11692
11693 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11694 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11695 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11696 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11697 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11698 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11699 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11700 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11701 (Qgnutls_bootprop_callbacks_verify): Make static.
11702
e7a6747f
AS
117032011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11704
19ed11ba
AS
11705 * callproc.c: Indentation fixup.
11706
e7a6747f 11707 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11708 (wait_for_termination, interruptible_wait_for_termination):
11709 Move after wait_for_termination_1.
e7a6747f 11710
1ef14cb4
LMI
117112011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11712
11713 * sysdep.c (interruptible_wait_for_termination): New function
11714 which is like wait_for_termination, but allows keyboard
11715 interruptions.
11716
11717 * callproc.c (Fcall_process): Add (:file "file") as an option for
11718 the STDOUT buffer.
11719 (Fcall_process_region): Ditto.
11720
330d880c
EZ
117212011-04-30 Eli Zaretskii <eliz@gnu.org>
11722
8db90b73
EZ
11723 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11724 rather than `XVECTOR (FOO)->size'.
11725
330d880c
EZ
11726 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11727 inttypes.h, as a gnulib replacement is used if it not available in
11728 system headers.
11729
15cbd324
EZ
117302011-04-21 Eli Zaretskii <eliz@gnu.org>
11731
11732 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11733 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11734 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11735
11736 * coding.c (coding_alloc_by_realloc): Error out if destination
11737 will grow beyond MOST_POSITIVE_FIXNUM.
11738 (decode_coding_emacs_mule): Abort if there isn't enough place in
11739 charbuf for the composition carryover bytes. Reserve an extra
11740 space for up to 2 characters produced in a loop.
11741 (decode_coding_iso_2022): Abort if there isn't enough place in
11742 charbuf for the composition carryover bytes.
11743
117442011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11745
ae940cca
EZ
11746 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11747 aborting when %lld or %lll format is passed.
11748 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11749 %llo or %llx format is passed. (Bug#8545)
11750
03ab8921
EZ
11751 * window.c (window_scroll_line_based): Use a marker instead of
11752 simple variables to record original value of point. (Bug#7952)
11753
afda1437
EZ
11754 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11755 produced by %s or %c overflows available buffer space. (Bug#8545)
11756
f76dee0c
PE
117572011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11758
11759 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11760 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11761
fdc5744d
JB
117622011-04-28 Juanma Barranquero <lekktu@gmail.com>
11763
11764 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11765
638f053a
JB
117662011-04-28 Juanma Barranquero <lekktu@gmail.com>
11767
11768 * keyboard.c (Qdelayed_warnings_hook): Define.
11769 (command_loop_1): Run `delayed-warnings-hook'
11770 if Vdelayed_warnings_list is non-nil.
11771 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11772 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11773
d178f871
EZ
117742011-04-28 Eli Zaretskii <eliz@gnu.org>
11775
11776 * doprnt.c (doprnt): Don't return value smaller than the buffer
11777 size if the message was truncated. (Bug#8545).
11778
b124fd93
JB
117792011-04-28 Juanma Barranquero <lekktu@gmail.com>
11780
11781 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11782 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11783
e810457d
PE
117842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11785
11786 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11787
ea51cceb
JB
117882011-04-27 Juanma Barranquero <lekktu@gmail.com>
11789
11790 * makefile.w32-in: Update dependencies.
11791
94dcfacf
EZ
117922011-04-27 Eli Zaretskii <eliz@gnu.org>
11793
11794 Improve `doprnt' and its usage. (Bug#8545)
11795 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11796 `format_end'. Remove support for %l as a conversion specifier.
11797 Don't use xrealloc. Improve diagnostics when the %l size modifier
11798 is used. Update the commentary.
11799
11800 * eval.c (verror): Simplify calculation of size_t.
11801
11802 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11803 messages.
11804
f61f41d7
PE
118052011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11806
11807 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11808 change.
11809
96fb4434
PE
118102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11811
11812 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11813 This makes this file independent of the recent pseudovector change.
11814
671875da 118152011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11816
69e9b5a3
PE
11817 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11818
b5f869a7 11819 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11820 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11821 Remove unused local.
c8926152 11822 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11823
841a1577 11824 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11825 GCC 4.6.0 optimizes based on type-based alias analysis.
11826 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11827 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11828 != &v->size, and therefore "v->size = 1; b->size = 2; return
11829 v->size;" must therefore return 1. This assumption is incorrect
11830 for Emacs, since it type-puns struct Lisp_Vector * with many other
11831 types. To fix this problem, this patch adds a new type struct
f904488f 11832 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11833 and pseudovectors, and helps optimizing compilers not get fooled
11834 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11835 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11836 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11837 the size member.
eab3844f
PE
11838 (XSETPVECTYPE): Rewrite in terms of new macro.
11839 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11840 This is a bit clearer, and further avoids the possibility of
11841 undesirable aliasing.
11842 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11843 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11844 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11845 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11846 (ASIZE): Now uses header.size rather than size.
11847 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11848 to avoid the hassle of writing XVECTOR (foo)->header.size.
11849 (struct vectorlike_header): New type.
eab3844f
PE
11850 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11851 object, to help avoid aliasing.
11852 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11853 (SUBRP): Likewise, since Lisp_Subr is a special case.
11854 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11855 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11856 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11857 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11858 changed to be "header.size" and "header.next".
11859 * buffer.h (struct buffer): Likewise.
11860 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11861 * frame.h (struct frame): Likewise.
11862 * process.h (struct Lisp_Process): Likewise.
11863 * termhooks.h (struct terminal): Likewise.
11864 * window.c (struct save_window_data, struct saved_window): Likewise.
11865 * window.h (struct window): Likewise.
11866 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11867 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11868 * buffer.c (init_buffer_once): Likewise.
11869 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11870 special case.
11871 * process.c (Fformat_network_address): Use local var for size,
11872 for brevity.
11873
0df1eac5
PE
11874 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11875
847ab9d1 11876 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11877 * data.c (atof): Remove decl; no longer used or needed.
11878 (digit_to_number): Move to lread.c.
11879 (Fstring_to_number): Use new string_to_number function, to be
11880 consistent with how the Lisp reader treats infinities and NaNs.
11881 Do not assume that floating-point numbers represent EMACS_INT
11882 without losing information; this is not true on most 64-bit hosts.
11883 Avoid double-rounding errors, by insisting on integers when
11884 parsing non-base-10 numbers, as the documentation specifies.
11885 * lisp.h (string_to_number): New decl, replacing ...
11886 (isfloat_string): Remove.
bc0a5c13 11887 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11888 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11889 appears to have been a coding error. Similarly, do not accept
11890 strings like +-1e0 as floating point numbers. Do not report
11891 overflow for integer overflows unless the base is not 10 which
11892 means we have no simple and reliable way to continue.
11893 Break out the floating-point parsing into a new
11894 function string_to_number, so that Fstring_to_number parses
11895 floating point numbers consistently with the Lisp reader.
04f2d78b 11896 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11897 (E_CHAR, EXP_INT): Remove, replacing with ...
11898 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11899 (string_to_number): New function, replacing isfloat_string.
11900 This function checks for valid syntax and produces the resulting
11901 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11902 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11903 so that overflow for non-base-10 numbers is reported only when
11904 there's no portable and simple way to convert to floating point.
452f4150 11905
67769ffc
PE
11906 * textprop.c (set_text_properties_1): Rewrite for clarity,
11907 and to avoid GCC warning about integer overflow.
11908
c20db43f
PE
11909 * intervals.h (struct interval): Use EMACS_INT for members
11910 where EMACS_UINT might cause problems. See
11911 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11912 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11913 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11914 All uses changed.
37aa2f85
PE
11915 (offset_intervals): Tell GCC not to worry about length overflow
11916 when negating a negative length.
c20db43f 11917
2538aa2f
PE
11918 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11919 (overrun_check_free): Likewise.
11920
f2d3008d
PE
11921 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11922 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11923 word size.
11924
ec8df744
PE
11925 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11926 (gnutls_make_error): Rename local to avoid shadowing.
11927 (gnutls_emacs_global_deinit): ifdef out; not used.
11928 (Fgnutls_boot): Use const for pointer to readonly storage.
11929 Comment out unused local. Fix pointer signedness problems.
11930
640ee02d
PE
11931 * lread.c (openp): Don't stuff size_t into an 'int'.
11932 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11933 about possible signed overflow.
11934
6048fb2a
PE
11935 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11936 (GDK_KEY_g): Don't define if already defined.
11937 (xg_prepare_tooltip): Avoid pointer signedness problem.
11938 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11939
fa3c87e1
PE
11940 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11941 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11942
2172544b
PE
11943 * xfns.c (Fx_window_property): Simplify a bit,
11944 to make a bit faster and to avoid GCC 4.6.0 warning.
11945 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11946
9b821a21
PE
11947 * fns.c (internal_equal): Don't assume size_t fits in int.
11948
3c616cfa
PE
11949 * alloc.c (compact_small_strings): Tighten assertion a little.
11950
c2982e87
PE
11951 Replace pEd with more-general pI, and fix some printf arg casts.
11952 * lisp.h (pI): New macro, generalizing old pEd macro to other
11953 conversion specifiers. For example, use "...%"pI"d..." rather
11954 than "...%"pEd"...".
11955 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11956 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11957 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11958 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11959 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11960 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11961 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11962 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11963 64-bit hosts.
11964 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11965 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11966 * print.c (safe_debug_print, print_object): Likewise.
11967 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11968 to int.
6f04d126
PE
11969 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11970 avoiding the 0 flag, which is not portable.
c2982e87
PE
11971 * process.c (Fmake_network_process): Use pI to avoid cast.
11972 * region-cache.c (pp_cache): Likewise.
11973 * xdisp.c (decode_mode_spec): Likewise.
11974 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11975 behavior on 64-bit hosts with printf arg.
6f04d126 11976 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11977 (x_stop_queuing_selection_requests): Likewise.
11978 (x_get_window_property): Don't truncate byte count to an 'int'
11979 when tracing.
0b432f21 11980
5e073ec7
PE
11981 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11982 here, since it parses constructs like leading '-' and spaces,
11983 which are not wanted; and it overflows with large numbers.
11984 Instead, simply match F[0-9]+, which is what is wanted anyway.
11985
36372bf9
PE
11986 * alloc.c: Remove unportable assumptions about struct layout.
11987 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11988 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11989 (allocate_vectorlike, make_pure_vector): Use the new macros,
11990 plus offsetof, to remove unportable assumptions about struct layout.
11991 These assumptions hold on all porting targets that I know of, but
11992 they are not guaranteed, they're easy to remove, and removing them
11993 makes further changes easier.
11994
0b432f21
PE
11995 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11996 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11997 (string_overrun_cookie): Now const. Use initializers that
11998 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11999 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12000 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12001 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12002 multiple of sizeof (EMACS_INT); it need not be, if
12003 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12004 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12005
895009e1
JB
120062011-04-26 Juanma Barranquero <lekktu@gmail.com>
12007
12008 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12009
6a7a1b0b
TZ
120102011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12011
12012 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12013 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12014 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12015
841a1577 120162011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12017
12018 * lisp.h (Qdebug): List symbol.
895009e1 12019 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12020 * keyboard.c (debug-on-event): New variable.
12021 (handle_user_signal): Break into debugger when debug-on-event
12022 matches the current signal symbol.
12023
f2d3ba6f
DN
120242011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12025
12026 * alloc.c (check_sblock, check_string_bytes)
12027 (check_string_free_list): Convert to standard C.
12028
42ce4c63
TZ
120292011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12030
12031 * w32.c (emacs_gnutls_push): Fix typo.
12032
825cd63c
EZ
120332011-04-25 Eli Zaretskii <eliz@gnu.org>
12034
fb11d64d
EZ
12035 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12036 "cast to pointer from integer of different size".
12037
825cd63c
EZ
12038 Improve doprnt and its use in verror. (Bug#8545)
12039 * doprnt.c (doprnt): Document the set of format control sequences
12040 supported by the function. Use SAFE_ALLOCA instead of always
12041 using `alloca'.
12042
12043 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12044 is one byte too soon. Don't use xrealloc; instead xfree and
12045 xmalloc anew.
12046
e061a11b
TZ
120472011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12048
12049 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12050 callbacks stage.
12051
12052 * gnutls.c: Renamed global_initialized to
12053 gnutls_global_initialized. Added internals for the
12054 :verify-hostname-error, :verify-error, and :verify-flags
12055 parameters of `gnutls-boot' and documented those parameters in the
12056 docstring. Start callback support.
9173deec
JB
12057 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12058 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12059 on error. Return error code.
e061a11b
TZ
12060 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12061 (emacs_gnutls_read): Likewise.
12062 (Fgnutls_boot): Return handshake error code.
12063 (emacs_gnutls_handle_error): New function.
12064 (wsaerror_to_errno): Likewise.
12065
12066 * w32.h (emacs_gnutls_pull): Add prototype.
12067 (emacs_gnutls_push): Likewise.
12068
12069 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12070 (emacs_gnutls_push): Likewise.
12071
120722011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12073
12074 * process.c (wait_reading_process_output): Check if GnuTLS
12075 buffered some data internally if no FDs are set for TLS
12076 connections.
12077
12078 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12079 (LIBS): Link to USER_LIBS.
12080 ($(BLD)/gnutls.$(0)): New target.
12081
fa6996bc
EZ
120822011-04-24 Eli Zaretskii <eliz@gnu.org>
12083
eb35682e
EZ
12084 * xdisp.c (handle_single_display_spec): Rename the
12085 display_replaced_before_p argument into display_replaced_p, to
12086 make it consistent with the commentary. Fix typos in the
12087 commentary.
12088
e2ad650c
EZ
12089 * textprop.c (syms_of_textprop): Remove dead code.
12090 (copy_text_properties): Delete obsolete commentary about an
12091 interface that was deleted long ago. Fix typos in the description
12092 of arguments.
12093
1b2de274
EZ
12094 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12095 to changes in oldXMenu/XMenu.h from 2011-04-16.
12096 <menu_help_message, prev_menu_help_message>: Constify.
12097 (IT_menu_make_room): menu->help_text is now `const char **';
12098 adjust.
12099
12100 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12101 to changes in oldXMenu/XMenu.h from 2011-04-16.
12102 (struct XMenu): Declare `help_text' `const char **'.
12103
12104 * xfaces.c <Qunspecified>: Make extern again.
12105
12106 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12107 required by POSIX.
1b2de274 12108
762b15be
EZ
12109 * doc.c (get_doc_string): Improve the format passed to `error'.
12110
12111 * doprnt.c (doprnt): Improve commentary.
12112
12113 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12114
12115 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12116 them with etags.
12117
f1052e5d
EZ
12118 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12119 changes in globals.h immediately force recompilation.
762b15be
EZ
12120 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12121 $(CURDIR)/s/ms-w32.h.
12122 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12123
fa6996bc
EZ
12124 * character.c (Fchar_direction): Function deleted.
12125 (syms_of_character): Don't defsubr it.
12126 <char-direction-table>: Deleted.
12127
e6c3da20
EZ
121282011-04-23 Eli Zaretskii <eliz@gnu.org>
12129
12130 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12131 * doprnt.c: Include limits.h.
12132 (SIZE_MAX): New macro.
04f2d78b
CB
12133 (doprnt): Return a size_t value. 2nd arg is now size_t.
12134 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12135 Improve overflow protection. Support `l' modifier for integer
12136 conversions. Support %l conversion. Don't assume an EMACS_INT
12137 argument for integer conversions and for %c.
12138
12139 * lisp.h (doprnt): Restore prototype.
12140
12141 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12142 $(SRC)/character.h.
12143
12144 * Makefile.in (base_obj): Add back doprnt.o.
12145
12146 * deps.mk (doprnt.o): Add back prerequisites.
12147 (callint.o): Depend on character.h.
12148
12149 * eval.c (internal_lisp_condition_case): Include the handler
12150 representation in the error message.
12151 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12152 when breaking from the loop.
12153
12154 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12155
12156 * callint.c (Fcall_interactively): When displaying error message
12157 about invalid control letter, pass the character's codepoint, not
12158 a pointer to its multibyte form. Improve display of the character
12159 in octal and display also its hex code.
12160
12161 * character.c (char_string): Use %x to display the (unsigned)
12162 codepoint of an invalid character, to avoid displaying a bogus
12163 negative value.
12164
12165 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12166 `error', not SYMBOL_NAME itself.
12167
12168 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12169 character arguments to `error'.
12170
12171 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12172 to `error' in error message about FINAL_CHAR argument. Make sure
12173 FINAL_CHAR is a character, and use %c when it is passed as
12174 argument to `error'.
12175
4ffd0d6b 121762011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12177
12178 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12179
12180 * w32.c: Include <time.h>.
12181 (sys_localtime): New function.
12182
4ffd0d6b 121832011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12184
12185 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12186
4ffd0d6b 12187 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12188
4ffd0d6b 121892011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12190
4ffd0d6b
GM
12191 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12192 zombies (Bug#8467).
aac0c6e3 12193
04c56954
EZ
121942011-04-19 Eli Zaretskii <eliz@gnu.org>
12195
12196 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12197 gl_state.e_property when gl_state.object is Qt.
12198
12199 * insdel.c (make_gap_larger): Remove limitation of buffer size
12200 to <= INT_MAX.
12201
16a43933
CY
122022011-04-18 Chong Yidong <cyd@stupidchicken.com>
12203
12204 * xdisp.c (lookup_glyphless_char_display)
12205 (produce_glyphless_glyph): Handle cons cell entry in
12206 glyphless-char-display.
12207 (Vglyphless_char_display): Document it.
12208
12209 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12210 glyphless-char-display.
12211
4581706e
CY
122122011-04-17 Chong Yidong <cyd@stupidchicken.com>
12213
12214 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12215
12216 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12217
12218 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12219 definition for no-X builds.
12220
4887c6e2 122212011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12222
fd35b6f9
PE
12223 Static checks with GCC 4.6.0 and non-default toolkits.
12224
5c1ccb01
PE
12225 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12226
006c5daa
PE
12227 * process.c (keyboard_bit_set): Define only if SIGIO.
12228 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12229 (send_process): Repair possible setjmp clobbering.
12230
efc736d3
PE
12231 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12232
4e2fe2e6
PE
12233 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12234
f97334a2
PE
12235 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12236
4e75f29d
PE
12237 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12238 Define only if needed.
12239
90efadd1
PE
12240 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12241 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12242 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12243
3c647824
PE
12244 * dispextern.h (struct redisplay_interface): Rename param
12245 to avoid shadowing.
e264f262 12246 * termhooks.h (struct terminal): Likewise.
761383f4 12247 * xterm.c (xembed_send_message): Likewise.
3c647824 12248
b58c5c4a
PE
12249 * insdel.c (make_gap_smaller): Define only if
12250 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12251
cad59032
PE
12252 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12253 it.
12254
c339dc2e
PE
12255 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12256 so that we aren't warned about unused symbols.
12257
91a3e27b
PE
12258 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12259
399c71d3 12260 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12261
8ffc96f5
PE
12262 * xfns.c (x_real_positions): Mark locals as initialized.
12263
eef9bc79
PE
12264 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12265
098db9dd
PE
12266 * xterm.c: Fix problems found by static analysis with other toolkits.
12267 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12268 (x_dispatch_event): Declare static if USE_GTK, and
12269 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12270 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12271 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12272 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12273 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12274
eb18f6cc
PE
12275 * xmenu.c (menu_help_callback): Pointer type fixes.
12276 Use const pointers when pointing at readonly data. Avoid pointer
12277 signedness clashes.
12278 (FALSE): Remove unused macro.
12279 (update_frame_menubar): Remove unused decl.
12280
1fe72bf8
PE
12281 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12282
60d9e1db
PE
12283 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12284 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12285 (single_menu_item): Rename local to avoid shadowing.
12286
39261c26
PE
12287 * keyboard.c (make_lispy_event): Remove unused local var.
12288
018c5e19
PE
12289 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12290 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12291
63d2b86e
PE
12292 * bitmaps: Change bitmaps from unsigned char back to the X11
12293 compatible char. Avoid the old compiler warnings about
12294 out-of-range initializers by using, for example, '\xab' rather
12295 than 0xab.
12296
aefd87e1
PE
12297 * xgselect.c (xgselect_initialize): Check vs interface
12298 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12299
bf501fb9
PE
12300 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12301
e9829fdf
PE
12302 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12303 to read-only memory.
12304
1086c095
PE
12305 * fns.c (vector): Remove; this old hack is no longer needed.
12306
2baccd04 12307 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12308 Remove unused var.
dde42981 12309 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12310
72391843 12311 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12312
436c16df 12313 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12314 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12315 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12316
92bb796d 12317 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12318 (x_term_init): Remove local to avoid shadowing.
92bb796d 12319
764430a3 12320 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12321
12322 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12323 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12324
d1dfb56c
EZ
123252011-04-16 Eli Zaretskii <eliz@gnu.org>
12326
c4354cb4
EZ
12327 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12328
d1dfb56c
EZ
12329 Fix regex.c, syntax.c and friends for buffers > 2GB.
12330 * syntax.h (struct gl_state_s): Declare character position members
12331 EMACS_INT.
12332
12333 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12334
04f2d78b
CB
12335 * textprop.c (verify_interval_modification, interval_of):
12336 Declare arguments EMACS_INT.
d1dfb56c
EZ
12337
12338 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12339 EMACS_INT.
12340
12341 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12342
12343 * indent.c (Fvertical_motion): Local variable it_start is now
12344 EMACS_INT.
12345
12346 * regex.c (re_match, re_match_2, re_match_2_internal)
12347 (bcmp_translate, regcomp, regexec, print_double_string)
12348 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12349 (re_compile_pattern, re_exec): Declare arguments and local
12350 variables `size_t' and `ssize_t' and return values `regoff_t', as
12351 appropriate.
12352 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12353 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12354 <compile_stack_type>: `size' and `avail' are now `size_t'.
12355
12356 * regex.h <regoff_t>: Use ssize_t, not int.
12357 (re_search, re_search_2, re_match, re_match_2): Arguments that
12358 specify buffer/string position and length are now ssize_t and
12359 size_t. Return type is regoff_t.
12360
613052cd
BK
123612011-04-16 Ben Key <bkey76@gmail.com>
12362
12363 * nsfont.m: Fixed bugs in ns_get_family and
12364 ns_descriptor_to_entity that were caused by using free to
12365 deallocate memory blocks that were allocated by xmalloc (via
12366 xstrdup). This caused Emacs to crash when compiled with
12367 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12368 --enable-checking=xmallocoverrun). xfree is now used to
12369 deallocate these memory blocks.
12370
4170f62f 123712011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12372
71b41406
PE
12373 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12374
9587a89d
PE
12375 emacs_write: Accept and return EMACS_INT for sizes.
12376 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12377 et seq.
12378 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12379 Accept and return EMACS_INT.
12380 (emacs_gnutls_write): Return the number of bytes written on
12381 partial writes.
12382 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12383 (emacs_read, emacs_write): Remove check for negative size, as the
12384 Emacs source code has been audited now.
9587a89d
PE
12385 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12386 (emacs_read, emacs_write): Use it.
273a5f82
PE
12387 * process.c (send_process): Adjust to the new signatures of
12388 emacs_write and emacs_gnutls_write. Do not attempt to store
12389 a byte offset into an 'int'; it might overflow.
9587a89d 12390 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12391
3e047f51
PE
12392 * sound.c: Don't assume sizes fit in 'int'.
12393 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12394 Return EMACS_INT, not int.
3e047f51 12395 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12396 Accept EMACS_INT, not int.
12397 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12398 record read return values.
12399
cc39a9db
BK
124002011-04-15 Ben Key <bkey76@gmail.com>
12401
c9d0ec6d
JB
12402 * keyboard.c (Qundefined): Don't declare static since it is used
12403 in nsfns.m.
12404 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12405 static since they are used in nsfont.m.
cc39a9db 12406
6c60eb9f
SM
124072011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12408
12409 * process.c (Qprocessp): Don't declare static.
12410 * lisp.h (Qprocessp): Declare again.
12411
7990b61a
JB
124122011-04-15 Juanma Barranquero <lekktu@gmail.com>
12413
12414 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12415
5d4cb038
PE
124162011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12417
8bd7b830 12418 Improve C-level modularity by making more things 'static'.
cd64ea1d 12419
e3b27b31
PE
12420 Don't publish debugger-only interfaces to other modules.
12421 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12422 (verify_bytepos, count_markers): Move decls to the only modules
12423 that need them.
12424 * region-cache.h (pp_cache): Likewise.
12425 * window.h (check_all_windows): Likewise.
12426 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12427
5d4cb038
PE
12428 * sysdep.c (croak): Now static, if
12429 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12430 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12431
12432 * alloc.c (refill_memory_reserve): Now static if
12433 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12434 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12435
e87b6180
PE
12436 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12437 Define only if USE_LUCID.
12438
ac64929e
PE
12439 * xrdb.c (x_customization_string, x_rm_string): Now static.
12440
6f37259d
PE
12441 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12442 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12443
1683e3ab
PE
12444 * xdisp.c (draw_row_with_mouse_face): Now static.
12445 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12446
de9c2632
PE
12447 * window.h (check_all_windows): Mark externally visible.
12448
2b96acb7
PE
12449 * window.c (window_deletion_count): Now static.
12450
12451 * undo.c: Make symbols static if they're not exported.
12452 (last_undo_buffer, last_boundary_position, pending_boundary):
12453 Now static.
12454
50436f33
PE
12455 * textprop.c (interval_insert_behind_hooks): Now static.
12456 (interval_insert_in_front_hooks): Likewise.
12457
64520e5c
PE
12458 * term.c: Make symbols static if they're not exported.
12459 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12460 (max_frame_lines, tty_set_terminal_modes):
12461 (tty_reset_terminal_modes, tty_turn_off_highlight):
12462 (get_tty_terminal): Now static.
12463 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12464 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12465 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12466 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12467 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12468
1fa53021
PE
12469 * sysdep.c: Make symbols static if they're not exported.
12470 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12471 Now static.
12472 (sigprocmask_set, full_mask): Remove; unused.
12473 (wait_debugging): Mark as visible.
12474 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12475 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12476
d4b43b22
PE
12477 * syntax.c (syntax_temp): Define only if !__GNUC__.
12478
b7c513d0
PE
12479 * sound.c (current_sound_device, current_sound): Now static.
12480
989b29ad
PE
12481 * search.c (searchbufs, searchbuf_head): Now static.
12482
13a55a78
PE
12483 * scroll.c (scroll_cost): Remove; unused.
12484 * dispextern.h (scroll_cost): Remove decl.
12485
de68a1fc
PE
12486 * region-cache.h (pp_cache): Mark as externally visible.
12487
40ccffa6
PE
12488 * process.c: Make symbols static if they're not exported.
12489 (process_tick, update_tick, create_process, chan_process):
12490 (Vprocess_alist, proc_buffered_char, datagram_access):
12491 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12492 (deactivate_process): Mark defn as static, as well as decl.
12493 * lisp.h (create_process): Remove decl.
12494 * process.h (chan_process, Vprocess_alist): Remove decls.
12495
ad64fc97
PE
12496 * print.c: Make symbols static if they're not exported.
12497 (print_depth, new_backquote_output, being_printed, print_buffer):
12498 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12499 (print_interval, print_number_index, initial_stderr_stream):
12500 Now static.
12501 * lisp.h (Fprinc): Remove decl.
12502 (debug_output_compilation_hack): Mark as externally visible.
12503
adddb265
PE
12504 * sysdep.c (croak): Move decl from here to syssignal.h.
12505 * syssignal.h (croak): Put it here, so the API can be checked when
12506 'croak' is called from dissociate_if_controlling_tty.
12507
1717ede2
PE
12508 * minibuf.c: Make symbols static if they're not exported.
12509 (minibuf_save_list, choose_minibuf_frame): Now static.
12510 * lisp.h (choose_minibuf_frame): Remove decl.
12511
fa5fb2bc
PE
12512 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12513
1e3890d1
PE
12514 * lread.c: Make symbols static if they're not exported.
12515 (read_objects, initial_obarray, oblookup_last_bucket_number):
12516 Now static.
12517 (make_symbol): Remove; unused.
12518 * lisp.h (initial_obarray, make_symbol): Remove decls.
12519
8a1414fa
PE
12520 * keyboard.c: Make symbols static if they're not exported.
12521 (single_kboard, recent_keys_index, total_keys, recent_keys):
12522 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12523 (this_single_command_key_start, echoing, last_auto_save):
12524 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12525 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12526 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12527 (Vlispy_mouse_stem, double_click_count):
12528 Now static.
12529 (force_auto_save_soon): Define only if SIGDANGER.
12530 (ignore_mouse_drag_p): Now static if
12531 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12532 (print_help): Remove; unused.
12533 (stop_character, last_timer_event): Mark as externally visible.
12534 * keyboard.h (ignore_mouse_drag_p): Declare only if
12535 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12536 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12537 * lisp.h (echoing): Remove decl.
12538 (force_auto_save_soon): Declare only if SIGDANGER.
12539 * xdisp.c (redisplay_window): Simplify code, to make it more
12540 obvious that ignore_mouse_drag_p is not accessed if !defined
12541 USE_GTK && !defined HAVE_NS.
12542
93ea6e8f
PE
12543 * intervals.c: Make symbols static if they're not exported.
12544 (merge_properties_sticky, merge_interval_right, delete_interval):
12545 Now static.
12546 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12547
77382fcc
PE
12548 * insdel.c: Make symbols static if they're not exported.
12549 However, leave prepare_to_modify_buffer alone. It's never
12550 called from outside this function, but that appears to be a bug.
12551 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12552 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12553 (adjust_after_replace_noundo): Remove; unused.
12554 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12555 (signal_before_change): Remove decls.
77382fcc 12556
9306c32e
PE
12557 * indent.c (val_compute_motion, val_vmotion): Now static.
12558
cd44d2eb
PE
12559 * image.c: Make symbols static if they're not exported.
12560 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12561 if USE_GTK.
12562 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12563 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12564
ad9a7a06
PE
12565 * fringe.c (standard_bitmaps): Now static.
12566 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12567
81626931
PE
12568 * frame.c: Make symbols static if they're not exported.
12569 (x_report_frame_params, make_terminal_frame): Now static.
12570 (get_frame_param): Now static, unless HAVE_NS.
12571 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12572 (x_get_resource_string): Remove; not used.
12573 * frame.h (make_terminal_frame, x_report_frame_params):
12574 (x_get_resource_string); Remove decls.
12575 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12576 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12577
239f9db9
PE
12578 * font.c, fontset.c: Make symbols static if they're not exported.
12579 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12580 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12581 * font.c (font_close_object): Now static.
12582 * font.h (font_close_object): Remove.
12583 * fontset.c (FONTSET_OBJLIST): Remove.
12584 (free_realized_fontset) #if-0 the body, which does nothing.
12585 (face_suitable_for_char_p): #if-0, as it's never called.
12586 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12587 * xfaces.c (face_at_string_position):
12588 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12589 since 0 is always ASCII.
12590
dfcf3579
PE
12591 * fns.c (weak_hash_tables): Now static.
12592
5045092b
PE
12593 * fileio.c: Make symbols static if they're not exported.
12594 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12595 (Vwrite_region_annotation_buffers): Now static.
12596
57a96f5c
PE
12597 * eval.c: Make symbols static if they're not exported.
12598 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12599 * lisp.h (backtrace_list): Remove decl.
12600
35f08c38
PE
12601 * emacs.c: Make symbols static if they're not exported.
12602 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12603 (fatal_error_code, fatal_error_signal_hook, standard_args):
12604 Now static.
12605 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12606 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12607 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12608 * lisp.h (fatal_error_signal_hook): Remove decl.
12609 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12610
f44bd759
PE
12611 * editfns.c: Move a (normally-unused) function to its only use.
12612 * editfns.c, lisp.h (get_operating_system_release): Remove.
12613 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12614 worth the hassle of breaking this out.
12615
b532497d
PE
12616 * xterm.c: Make symbols static if they're not exported.
12617 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12618 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12619 (x_destroy_window, x_delete_display):
12620 Now static.
12621 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12622 (x_mouse_leave): Remove; unused.
12623 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12624 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12625 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12626 Remove decls.
12627 (x_mouse_leave): Declare only if WINDOWSNT.
12628 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12629 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12630 USE_X_TOOLKIT.
12631
1675728f
PE
12632 * ftxfont.c: Make symbols static if they're not exported.
12633 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12634 HAVE_FREETYPE.
12635 * font.h (ftxfont_driver): Likewise.
12636
e4cebfca
PE
12637 * xfns.c: Make symbols static if they're not exported.
12638 (x_last_font_name, x_display_info_for_name):
12639 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12640 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12641 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12642 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12643 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12644 (last_show_tip_args): Now static.
12645 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12646 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12647 (x_screen_planes): Remove; unused.
12648 * dispextern.h (x_screen_planes): Remove decl.
12649
5bf46f05
PE
12650 * dispnew.c: Make symbols static if they're not exported.
12651 * dispextern.h (redraw_garbaged_frames, scrolling):
12652 (increment_row_positions): Remove.
12653 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12654 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12655 Now static.
12656 (redraw_garbaged_frames): Remove; unused.
12657
435f4c28
PE
12658 * xfaces.c: Make symbols static if they're not exported.
12659 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12660 Remove decls.
12661 * xterm.h (defined_color): Remove decls.
12662 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12663 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12664 (menu_face_changed_default, defined_color, free_realized_face):
12665 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12666 (ascii_face_of_lisp_face): Remove; unused.
12667
8524aef3
PE
12668 * xdisp.c: Make symbols static if they're not exported.
12669 * dispextern.h (scratch_glyph_row, window_box_edges):
12670 (glyph_to_pixel_coords, set_cursor_from_row):
12671 (get_next_display_element, set_iterator_to_next):
12672 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12673 (show_mouse_face): Remove decls
12674 * frame.h (message_buf_print): Likewise.
12675 * lisp.h (pop_message, set_message, check_point_in_composition):
12676 Likewise.
12677 * xterm.h (set_vertical_scroll_bar): Likewise.
12678 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12679 (message_buf_print, scratch_glyph_row, displayed_buffer):
12680 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12681 (get_next_display_element, show_mouse_face, window_box_edges):
12682 (frame_to_window_pixel_xy, check_point_in_composition):
12683 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12684 (glyph_to_pixel_coords): Remove; unused.
12685
16390cd2
PE
12686 * dired.c (file_name_completion): Now static.
12687
12688 * dbusbind.c (xd_in_read_queued_messages): Now static.
12689
a25f4dfa
PE
12690 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12691 * data.c (circular_list_error): Remove.
12692
14a9c8df
PE
12693 * commands.h (last_point_position, last_point_position_buffer):
12694 (last_point_position_window): Remove decls.
12695 * keyboard.c: Make these variables static.
12696
04f2d78b
CB
12697 * coding.h (coding, code_convert_region, encode_coding_gap):
12698 Remove decls.
74ab6df5
PE
12699 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12700 (iso_code_class, detect_coding, code_convert_region): Now static.
12701 (encode_coding_gap): Remove; unused.
12702
38dfbee1
PE
12703 * chartab.c (chartab_chars, chartab_bits): Now static.
12704
a2cb4e63
PE
12705 * charset.h (charset_iso_8859_1): Remove decl.
12706 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12707 Now static.
12708
127198fd
PE
12709 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12710 * ccl.c (Vccl_program_table): Now static.
12711 (check_ccl_update): Remove; unused.
12712
d85b608f
PE
12713 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12714 * category.h: ... from here.
12715 * category.c (check_category_table, set_category_set): Now static.
12716
31cd66f3
PE
12717 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12718 * lisp.h: Remove these decls.
12719
c358e587
PE
12720 * buffer.c (buffer_count): Remove unused var.
12721
e78aecca
PE
12722 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12723 so that it's not optimized away.
12724 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12725 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12726 exported only to the debugger.
12727
e192d7d3 12728 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12729 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12730
92470028
PE
12731 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12732 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12733 was inaccessible from Lisp.
12734 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12735 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12736
244ed907
PE
12737 alloc.c: Import and export fewer symbols, and remove unused items.
12738 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12739 is defined.
12740 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12741 it's not optimized away by whole-program optimization.
12742 (message_enable_multibyte, free_misc): Remove.
12743 (catchlist, handlerlist, mark_backtrace):
12744 Declare only if BYTE_MARK_STACK.
12745 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12746 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12747 (message_enable_multibyte): Remove decl.
12748 (free_misc, interval_free_list, float_block, float_block_index):
12749 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12750 (cons_free_list, last_marked_index):
12751 Now static.
12752 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12753 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12754 (mark_backtrace): Define only if BYTE_MARK_STACK.
12755 * xdisp.c (message_enable_multibyte): Now static.
12756
61c2b50e 12757 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12758 This makes it easier for human readers (and static analyzers)
12759 to see whether these variables are used from other modules.
12760 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12761 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12762 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12763 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12764 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12765 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12766 * xmenu.c, xselect.c:
12767 Declare Q* vars static if they are not used in other modules.
12768 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12769 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12770 Remove decls of unexported vars.
12771 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12772
95c82688
PE
12773 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12774
16a97296
PE
12775 Make Emacs functions such as Fatom 'static' by default.
12776 This makes it easier for human readers (and static analyzers)
12777 to see whether these functions can be called from other modules.
12778 DEFUN now defines a static function. To make the function external
12779 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12780 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12781 (Finit_image_library):
16a97296
PE
12782 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12783 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12784 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12785 Remove decls, since these functions are now static.
12786 (Funintern, Fget_internal_run_time): New decls, since these functions
12787 were already external.
95c82688 12788
16a97296
PE
12789 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12790 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12791 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12792 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12793 * keyboard.c, keymap.c, lread.c:
12794 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12795 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12796 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12797 Mark functions with DEFUE instead of DEFUN,
12798 if they are used in other modules.
12799 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12800 decls for now-static functions.
12801 * buffer.h (Fdelete_overlay): Remove decl.
12802 * callproc.c (Fgetenv_internal): Mark as internal.
12803 * composite.c (Fremove_list_of_text_properties): Remove decl.
12804 (Fcomposition_get_gstring): New forward static decl.
12805 * composite.h (Fcomposite_get_gstring): Remove decl.
12806 * dired.c (Ffile_attributes): New forward static decl.
12807 * doc.c (Fdocumntation_property): New forward static decl.
12808 * eval.c (Ffetch_bytecode): New forward static decl.
12809 (Funintern): Remove extern decl; now in .h file where it belongs.
12810 * fileio.c (Fmake_symbolic_link): New forward static decl.
12811 * image.c (Finit_image_library): New forward static decl.
12812 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12813 * intervals.h (Fprevious_property_change):
12814 (Fremove_list_of_text_properties): Remove decls.
12815 * keyboard.c (Fthis_command_keys): Remove decl.
12816 (Fcommand_execute): New forward static decl.
12817 * keymap.c (Flookup_key): New forward static decl.
12818 (Fcopy_keymap): Now static.
12819 * keymap.h (Flookup_key): Remove decl.
12820 * process.c (Fget_process): New forward static decl.
12821 (Fprocess_datagram_address): Mark as internal.
12822 * syntax.c (Fsyntax_table_p): New forward static decl.
12823 (skip_chars): Remove duplicate decl.
12824 * textprop.c (Fprevious_property_change): New forward static decl.
12825 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12826 Now internal.
12827 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12828 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12829
785bbd42
PE
12830 * editfns.c (Fformat): Remove unreachable code.
12831
8b913b57
AS
128322011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12833
12834 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12835 change. (Bug#8496)
12836
a6744a35
EZ
128372011-04-13 Eli Zaretskii <eliz@gnu.org>
12838
12839 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12840 when at ZV. (Bug#8487)
12841
e7974947
AS
128422011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12843
baad03f0
AS
12844 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12845 (Bug#8437)
12846 * keyboard.c (parse_tool_bar_item): Likewise.
12847 * sound.c (sound_cleanup, alsa_close): Likewise.
12848 * termcap.c (tgetent): Likewise.
12849 * xfns.c (x_default_font_parameter): Likewise.
12850 * xsettings.c (read_and_apply_settings): Likewise.
12851
e7974947
AS
12852 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12853 (overrun_check_free): Protoize.
12854
28272684
PE
128552011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12856
12857 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12858 since callers should never pass a negative size.
12859 Change the signature to match that of plain 'read' and 'write'; see
12860 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12861 * lisp.h: Update prototypes of emacs_write and emacs_read.
12862
11997c76
EZ
128632011-04-11 Eli Zaretskii <eliz@gnu.org>
12864
12865 * xdisp.c (redisplay_window): Don't try to determine the character
12866 position of the scroll margin if the window start point w->startp
e896f03c 12867 is outside the buffer's accessible region. (Bug#8468)
11997c76 12868
8a2cbd72
EZ
128692011-04-10 Eli Zaretskii <eliz@gnu.org>
12870
12871 Fix write-region and its subroutines for buffers > 2GB.
12872 * fileio.c (a_write, e_write): Modify declaration of arguments and
12873 local variables to support buffers larger than 2GB.
12874 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12875
12876 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12877 argument, local variables, and return value.
12878
12879 * lisp.h: Update prototypes of emacs_write and emacs_read.
12880
12881 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12882
4073e537 128832011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12884
1ebfdcb6
PE
12885 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12886
b2ded58d
PE
12887 Fix more problems found by GCC 4.6.0's static checks.
12888
7d66342c
PE
12889 * xdisp.c (vmessage): Use a better test for character truncation.
12890
bbf47d44
PE
12891 * charset.c (load_charset_map): <, not <=, for optimization,
12892 and to avoid potential problems with integer overflow.
9248994d 12893 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12894 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12895 * editfns.c (Fformat): Likewise.
1e69125e 12896 * syntax.c (skip_chars): Likewise.
3befa583 12897
e3019616
PE
12898 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12899 This also lets GCC 4.6.0 generate slightly better loop code.
12900
becfa255
PE
12901 * callint.c (Fcall_interactively): <, not <=, for optimization.
12902 (Fcall_interactively): Count the number of arguments produced,
12903 not the number of arguments given. This is simpler and lets GCC
12904 4.6.0 generate slightly better code.
12905
dae0cd48
PE
12906 * ftfont.c: Distingish more carefully between FcChar8 and char.
12907 The previous code passed unsigned char * to a functions like
12908 strlen and xstrcasecmp that expect char *, which does not
12909 conform to the C standard.
12910 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12911 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12912 char * when the C standard requires it.
12913
76032d70
PE
12914 * keyboard.c (read_char): Remove unused var.
12915
eb3f1cc8
PE
12916 * eval.c: Port to Windows vsnprintf (Bug#8435).
12917 Include <limits.h>.
12918 (SIZE_MAX): Define if the headers do not.
12919 (verror): Do not give up if vsnprintf returns a negative count.
12920 Instead, grow the buffer. This ports to Windows vsnprintf, which
12921 does not conform to C99. Problem reported by Eli Zaretskii.
12922 Also, simplify the allocation scheme, by avoiding the need for
12923 calling realloc, and removing the ALLOCATED variable.
12924
70476b54
PE
12925 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12926
12020a9e
PE
12927 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12928 But keep the doprint source code for now, as we might revamp it
12929 and use it again (Bug#8435).
ea6c7ae6
PE
12930 * lisp.h (doprnt): Remove.
12931 * Makefile.in (base_obj): Remove doprnt.o.
12932 * deps.mk (doprnt.o): Remove.
12933
5fdb398c
PE
12934 error: Print 32- and 64-bit integers portably (Bug#8435).
12935 Without this change, on typical 64-bit hosts error ("...%d...", N)
12936 was used to print both 32- and 64-bit integers N, which relied on
12937 undefined behavior.
61bdb816 12938 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12939 * lisp.h (error, verror): Mark as printf-like functions.
12940 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12941 Report overflow in size calculations when allocating printf buffer.
12942 Do not truncate output string at its first null byte.
12943 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12944 Truncate the output at a character boundary, since vsnprintf does not
12945 do that.
12946 * charset.c (check_iso_charset_parameter): Convert internal
12947 character to string before calling 'error', since %c now has the
12948 printf meaning.
12949 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12950 overflow when computing char to be passed to 'error'. Do not
12951 pass Lisp_Object to 'error'; pass the integer instead.
12952 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12953 formatted with plain %d.
12954
b189fa66
PE
12955 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12956
bff87ef0
PE
12957 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12958
7e2cac20
PE
12959 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12960
ce4d90b5
PE
12961 * xterm.c (x_catch_errors): Remove duplicate declaration.
12962
266c9547
PE
12963 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12964
79c49ad2
PE
12965 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12966
368f4090
JM
129672011-04-10 Jim Meyering <meyering@redhat.com>
12968
12969 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12970 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12971 return ssize_t not "int", and use size_t as the buffer length.
12972 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12973 * gnutls.h: Update declarations.
12974 * process.c (read_process_output): Use ssize_t, to match.
12975 (send_process): Likewise.
12976
a32d4040
CY
129772011-04-09 Chong Yidong <cyd@stupidchicken.com>
12978
12979 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12980
8546720e 129812011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12982
04f2d78b
CB
12983 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12984 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12985
8546720e
GM
12986 * xterm.c (handle_one_xevent):
12987 * xmenu.c (create_and_show_popup_menu):
12988 * xselect.c (x_decline_selection_request)
12989 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12990
0a2f5c1a 129912011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12992
12993 Fix some uses of `int' instead of EMACS_INT.
12994 * search.c (string_match_1, fast_string_match)
12995 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12996 (scan_buffer, find_next_newline_no_quit)
12997 (find_before_next_newline, search_command, Freplace_match)
12998 (Fmatch_data): Make some `int' variables be EMACS_INT.
12999
13000 * xdisp.c (display_count_lines): 3rd argument and return value now
13001 EMACS_INT. All callers changed.
13002 (pint2hrstr): Last argument is now EMACS_INT.
13003
13004 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13005 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13006 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13007 (decode_coding_utf_16, decode_coding_emacs_mule)
13008 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13009 (decode_coding_ccl, decode_coding_charset)
13010 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13011 (decode_coding_iso_2022, decode_coding_emacs_mule)
13012 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13013 <char_offset, last_offset>: Declare EMACS_INT.
13014 (encode_coding_utf_8, encode_coding_utf_16)
13015 (encode_coding_emacs_mule, encode_invocation_designation)
13016 (encode_designation_at_bol, encode_coding_iso_2022)
13017 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13018 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13019 Declare EMACS_INT.
13020 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13021 (encode_invocation_designation): Last argument P_NCHARS is now
13022 EMACS_INT.
13023 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13024 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13025
13026 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13027 All users changed.
13028
13029 * ccl.c (Fccl_execute_on_string): Declare some variables
13030 EMACS_INT.
13031
8546720e 130322011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13033
13034 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13035
4e19a977
CS
130362011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13037
13038 * process.c (Fformat_network_address): Doc fix.
13039
87302331
R
130402011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13041
ee7683eb 13042 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13043
cbb59342
CY
130442011-04-08 Chong Yidong <cyd@stupidchicken.com>
13045
13046 * keyboard.c (read_char): Call Lisp function help-form-show,
13047 instead of using internal_with_output_to_temp_buffer.
13048 (Qhelp_form_show): New var.
e0d38eeb 13049 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13050
13051 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13052
13053 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13054
e67a13ab
CY
130552011-04-06 Chong Yidong <cyd@stupidchicken.com>
13056
04f2d78b
CB
13057 * process.c (Flist_processes): Remove to Lisp.
13058 (list_processes_1): Delete.
e67a13ab 13059
973f782d
EZ
130602011-04-06 Eli Zaretskii <eliz@gnu.org>
13061
7c106b1e
EZ
13062 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13063
973f782d
EZ
13064 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13065
41cf7d1a 130662011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13067
ca23cc88
PE
13068 Fix more problems found by GCC 4.6.0's static checks.
13069
f390e2d5
PE
13070 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13071
42eea0d0
PE
13072 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13073
b69769da 13074 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13075
f9541e84
PE
13076 * xdisp.c (vmessage): Mark as a printf-like function.
13077
13841b55
PE
13078 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13079
c136c10f
PE
13080 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13081
5e2d4a30
PE
13082 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13083 printf-like functions.
13084 (tiff_load): Add casts to remove these marks before passing them
13085 to system-supplied API.
13086
583f48b9
PE
13087 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13088
b25d760e
PE
13089 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13090 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13091 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13092 directly, rather than having caller test rule sign. This avoids
13093 some unnecessary tests.
13094 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13095 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13096 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13097
bc7b6697 13098 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13099 (xfont_open): Avoid unnecessary tests.
bc7b6697 13100
27ccc379
PE
13101 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13102
dcd5c89a
PE
13103 * composite.h, composite.c (composition_gstring_put_cache):
13104 Use EMACS_INT, not int, for length.
13105
b13a45c6
PE
13106 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13107 breaking out part of COMPOSITION_DECODE_RULE.
13108 (COMPOSITION_DECODE_RULE): Use it.
13109 * composite.c (get_composition_id): Remove unused local vars,
13110 by using the new macro.
13111
1e792e4d
PE
13112 * textprop.c (set_text_properties_1): Change while to do-while,
13113 since the condition is always true at first.
13114
dc6c6455 13115 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13116 (interval_deletion_adjustment): Return unsigned value.
13117 All uses changed.
dc6c6455 13118
aba7731a
PE
13119 * process.c (list_processes_1, create_pty, read_process_output):
13120 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13121 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13122 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13123 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13124 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13125
fdfc4bf3
PE
13126 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13127
fca8fe46 13128 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13129 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13130
06a0259a 13131 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13132 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13133 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13134
e7b9e80f
PE
13135 * print.c (print_error_message): Avoid int overflow.
13136
56201685
PE
13137 * font.c (font_list_entities): Redo for clarity,
13138 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13139
78834453 13140 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13141 (font_score): Avoid potential overflow in diff calculation.
78834453 13142
0bc0b309 13143 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13144 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13145
e610eaca
PE
13146 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13147
b895abce
PE
13148 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13149 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13150 can always succeed if overflow has undefined behavior.
13151
1f1d9321 13152 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13153 (wordify): Omit three unnecessary tests.
1f1d9321 13154
c59478bc
PE
13155 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13156 All callers changed. This avoids the need for an unused var.
13157
79b73827
PE
13158 * casefiddle.c (casify_region): Remove var that is set but not used.
13159
a4db5dfe
PE
13160 * dired.c (file_name_completion): Remove var that is set but not used.
13161
43aae36e
PE
13162 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13163
2a47c44d 13164 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13165 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13166
a37c69bf
PE
13167 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13168 Check for integer overflow on size calculations.
13169
328ab8e7
PE
13170 * buffer.c (Fprevious_overlay_change): Remove var that is set
13171 but not used.
13172
e5a2a5cb
PE
13173 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13174 Remove vars that are set but not used.
8d84a6eb 13175 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13176 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13177
a60e5f68
PE
13178 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13179
f661cb61 13180 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13181 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13182
f0397f5a
PE
13183 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13184 that are set but not used.
13185
8664db06 13186 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13187 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13188
6abdaa4a
PE
13189 * xselect.c (x_get_local_selection, x_handle_property_notify):
13190 Remove vars that are set but not used.
13191
0ce7538d 13192 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13193 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13194
9ae848fc
PE
13195 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13196 Remove var that is set but not used.
0b918413
PE
13197 (scroll_bar_windows_size): Now size_t, not int.
13198 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13199 Check for overflow.
9ae848fc 13200
a5a62657
PE
13201 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13202 (map_tty_color) [!defined MSDOS]: Likewise.
13203
5c5cdd39
PE
13204 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13205
66ebf983
PE
13206 * coding.c: Remove vars that are set but not used.
13207 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13208 All callers changed.
13209 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13210 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13211 (decode_coding_charset): Remove vars that are set but not used.
13212
1be4d761
PE
13213 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13214 that is set but not used.
13215
47553fa8
PE
13216 * print.c (print_object): Remove var that is set but not used.
13217
1f7196bf 13218 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13219 The gnulib version avoids calling malloc in the usual case,
13220 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13221 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13222 * filelock.c (current_lock_owner): Likewise.
13223 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13224 * sysdep.c: Include allocator.h, careadlinkat.h.
13225 (emacs_no_realloc_allocator): New static constant.
13226 (emacs_readlink): New function.
fdb61804
PE
13227 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13228 ../lib/careadlinkat.h.
d1fdcab7 13229
f84c17c7
SM
132302011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13231
13232 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13233 first non-nil return value).
13234
ef3862ad
JD
132352011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13236
13237 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13238 if not defined (Bug#8403).
13239
376a7006
JB
132402011-04-02 Juanma Barranquero <lekktu@gmail.com>
13241
13242 * xdisp.c (display_count_lines): Remove parameter `start',
13243 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13244 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13245 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13246 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13247 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13248 and thereabouts. All callers changed.
13249 (get_per_char_metric): Remove parameter `f', unused since
13250 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13251
6ca3801d
JM
132522011-04-02 Jim Meyering <meyering@redhat.com>
13253
13254 do not dereference NULL upon failed strdup
13255 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13256 (ns_get_family): Likewise.
13257
d8e2b5ba
JB
132582011-04-02 Juanma Barranquero <lekktu@gmail.com>
13259
13260 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13261
8c74fcbd
JD
132622011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13263
13264 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13265 later (Bug#8403).
13266
7200d79c
SM
132672011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13268
03408648 13269 Add lexical binding.
7200d79c 13270
03408648
SM
13271 * window.c (Ftemp_output_buffer_show): New fun.
13272 (Fsave_window_excursion):
13273 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13274
13275 * lread.c (lisp_file_lexically_bound_p): New function.
13276 (Fload): Bind Qlexical_binding.
13277 (readevalloop): Remove `evalfun' arg.
13278 Bind Qinternal_interpreter_environment.
13279 (Feval_buffer): Bind Qlexical_binding.
13280 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13281 Mark as dynamic.
13282 (syms_of_lread): Declare `lexical-binding'.
13283
13284 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13285
13286 * keyboard.c (eval_dyn): New fun.
13287 (menu_item_eval_property): Use it.
ca105506
SM
13288
13289 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13290
03408648
SM
13291 * fns.c (concat, mapcar1): Accept byte-code-functions.
13292
13293 * eval.c (Fsetq): Handle lexical vars.
13294 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13295 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13296 (FletX, Flet): Obey lexical binding.
13297 (Fcommandp): Handle closures.
13298 (Feval): New `lexical' arg.
13299 (eval_sub): New function extracted from Feval. Use it almost
13300 everywhere where Feval was used. Look up vars in lexical env.
13301 Handle closures.
13302 (Ffunctionp): Move from subr.el.
13303 (Ffuncall): Handle closures.
13304 (apply_lambda): Remove `eval_flags'.
13305 (funcall_lambda): Handle closures and new byte-code-functions.
13306 (Fspecial_variable_p): New function.
13307 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13308 but without exporting it to Lisp.
23aba0ea 13309
23aba0ea 13310 * doc.c (Fdocumentation, store_function_docstring):
03408648 13311 * data.c (Finteractive_form): Handle closures.
23aba0ea 13312
03408648
SM
13313 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13314 interactive spec.
ba83908c 13315
04f2d78b
CB
13316 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13317 New byte-codes.
03408648
SM
13318 (exec_byte_code): New function extracted from Fbyte_code to handle new
13319 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13320
03408648 13321 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13322
03408648 13323 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13324
e2abce01
JB
133252011-03-31 Juanma Barranquero <lekktu@gmail.com>
13326
13327 * xdisp.c (redisplay_internal): Fix prototype.
13328
63696a73 133292011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13330
63696a73 13331 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13332 (try_scrolling): Use it when setting scroll_limit.
13333 Limit scrolling to 100 screen lines.
63696a73
EZ
13334 (redisplay_window): Even when falling back on "recentering",
13335 position point in the window according to scroll-conservatively,
13336 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13337
13338 (try_scrolling): When point is above the window, allow searching
13339 as far as scroll_max, or one screenful, to compute vertical
13340 distance from PT to the scroll margin position. This prevents
13341 try_scrolling from unnecessarily failing when
13342 scroll-conservatively is set to a value slightly larger than the
13343 window height. Clean up the case of PT below the margin at bottom
13344 of window: scroll_max can no longer be INT_MAX. When aggressive
13345 scrolling is in use, don't let point enter the opposite scroll
13346 margin as result of the scroll.
13347 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13348 threshold of 100 lines for never-recentering scrolling.
13349
e4cc2dfc
JB
133502011-03-31 Juanma Barranquero <lekktu@gmail.com>
13351
13352 * dispextern.h (move_it_by_lines):
13353 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13354 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13355 (message_log_check_duplicate): Remove parameters `prev_bol' and
13356 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13357 (redisplay_internal): Remove parameter `preserve_echo_area',
13358 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13359
13360 * indent.c (Fvertical_motion):
13361 * window.c (window_scroll_pixel_based, Frecenter):
13362 Don't pass `need_y_p' to `move_it_by_lines'.
13363
1c470562
SM
133642011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13365
44f230aa
SM
13366 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13367 steal a few bits to be more compact.
13368 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13369 Remove unneeded casts.
13370
1c470562
SM
13371 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13372
888adce9
ZK
133732011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13374
13375 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13376 binding" message (bug#7967).
13377
f838ed7b
PE
133782011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13379
77861b95
PE
13380 Fix more problems found by GCC 4.6.0's static checks.
13381
de6dbc14
PE
13382 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13383 Remove unused local var.
13384
f838ed7b
PE
13385 * editfns.c (Fmessage_box): Remove unused local var.
13386
792c7b2b
PE
13387 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13388 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13389 Omit unused local vars.
c499e557 13390 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13391 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13392 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13393 Omit unused local var.
13394
ba0165e1
PE
13395 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13396 Don't assume string length fits in int.
32ad8845 13397 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13398 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13399
3c59b4c9
PE
13400 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13401 instead of alloca (Bug#8344).
13402
a3eed478 13403 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13404 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13405
eb4d412d
PE
13406 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13407
1658b401
PE
13408 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13409 concerns.
13410
13411 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13412
13413 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13414
9a2c6e05
PE
13415 * keyboard.c (syms_of_keyboard): Use the same style as later
13416 in this function when indexing through an array. This also
13417 works around GCC bug 48267.
13418
03d0a109
PE
13419 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13420
44f730c8
PE
13421 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13422
fe75f926
PE
13423 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13424 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13425
ffa8c828
PE
13426 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13427 This avoids undefined behavior on integer overflow, and is a bit
13428 more convenient anyway since it is compared to a size_t variable.
13429
c5101a77
PE
13430 Variadic C functions now count arguments with size_t, not int.
13431 This avoids an unnecessary limitation on 64-bit machines, which
13432 caused (substring ...) to crash on large vectors (Bug#8344).
13433 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13434 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13435 All variadic functions and their callers changed accordingly.
c5101a77
PE
13436 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13437 * data.c (arith_driver, float_arith_driver): Likewise.
13438 * editfns.c (general_insert_function): Likewise.
13439 * eval.c (struct backtrace.nargs, interactive_p)
13440 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13441 (funcall_lambda, mark_backtrace): Likewise.
13442 * fns.c (concat): Likewise.
13443 * frame.c (x_set_frame_parameters): Likewise.
13444 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13445 0 if not found, not -1. All callers changed.
13446
dd3f25f7
PE
13447 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13448 (stack_copy_size): Now size_t, not int.
13449 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13450
461c2ab9
JB
134512011-03-28 Juanma Barranquero <lekktu@gmail.com>
13452
13453 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13454 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13455 All callers changed.
13456
13457 * lisp.h (multibyte_char_to_unibyte):
13458 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13459 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13460 * character.h (CHAR_TO_BYTE8):
13461 * cmds.c (internal_self_insert):
13462 * editfns.c (general_insert_function):
13463 * keymap.c (push_key_description):
13464 * search.c (Freplace_match):
13465 * xdisp.c (message_dolog, set_message_1): All callers changed.
13466
f6d62986
SM
134672011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13468
13469 * keyboard.c (safe_run_hook_funcall): New function.
13470 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13471 don't set the hook to nil, but remove the offending function instead.
13472 (Qcommand_hook_internal): Remove, unused.
13473 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13474 Vcommand_hook_internal.
13475
13476 * eval.c (enum run_hooks_condition): Remove.
13477 (funcall_nil, funcall_not): New functions.
13478 (run_hook_with_args): Call each function through a `funcall' argument.
13479 Remove `cond' argument, now redundant.
13480 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13481 (Frun_hook_with_args_until_failure): Adjust accordingly.
13482 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13483
1db5b1ad
JB
134842011-03-28 Juanma Barranquero <lekktu@gmail.com>
13485
13486 * dispextern.h (string_buffer_position): Remove declaration.
13487
13488 * print.c (strout): Remove parameter `multibyte', unused since
13489 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13490
13491 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13492 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13493 All callers changed.
13494
13495 * w32.c (_wsa_errlist): Use braces for struct initializers.
13496
13497 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13498 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13499 All callers changed.
13500 (string_buffer_position): Likewise. Also, make static (it's never
13501 used outside xdisp.c).
13502 (cursor_row_p): Remove parameter `w', unused since
13503 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13504 (decode_mode_spec): Remove parameter `precision', introduced during
13505 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13506 All callers changed.
13507
5ffb62aa
JD
135082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13509
13510 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13511
461c2ab9 135122011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13513
13514 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13515 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13516 (ns_update_auto_hide_menu_bar): New functions.
13517 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13518 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13519 ns_constrain_all_frames.
13520 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13521 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13522
5c380ffb
JD
135232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13524
13525 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13526
9af30bdf
GM
135272011-03-27 Glenn Morris <rgm@gnu.org>
13528
13529 * syssignal.h: Replace RETSIGTYPE with void.
13530 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13531 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13532 Replace SIGTYPE with void everywhere.
13533 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13534 * s/template.h (SIGTYPE): Remove commented out definition.
13535
e2abce01
JB
135362011-03-26 Eli Zaretskii <eliz@gnu.org>
13537
13538 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13539 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13540
f868cd8a
JB
135412011-03-26 Juanma Barranquero <lekktu@gmail.com>
13542
59eb0929
JB
13543 * w32.c (read_unc_volume): Use parameter `henum', instead of
13544 global variable `wget_enum_handle'.
13545
13546 * keymap.c (describe_vector): Remove parameters `indices' and
13547 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13548 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13549
f868cd8a
JB
13550 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13551
13552 * keyboard.c (timer_check): Remove parameter `do_it_now',
13553 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13554 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13555 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13556
13557 * keyboard.c (read_char):
13558 * w32menu.c (w32_menu_display_help):
13559 * xmenu.c (show_help_event, menu_help_callback):
13560 Adjust calls to `show_help_echo'.
13561
13562 * gtkutil.c (xg_maybe_add_timer):
13563 * keyboard.c (readable_events):
13564 * process.c (wait_reading_process_output):
13565 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13566
13567 * insdel.c (adjust_markers_gap_motion):
13568 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13569 (gap_left, gap_right): Don't call it.
13570
2ecf6fdb
CY
135712011-03-25 Chong Yidong <cyd@stupidchicken.com>
13572
13573 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13574 incurred during fontification.
13575
6b1f9ba4
JB
135762011-03-25 Juanma Barranquero <lekktu@gmail.com>
13577
13578 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13579 (DEFVAR_PER_BUFFER): Don't pass it.
13580
13581 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13582 (scrolling_window): Don't pass it.
13583
0f4a96b5
JB
135842011-03-25 Juanma Barranquero <lekktu@gmail.com>
13585
13586 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13587
13588 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13589 and `suffix'.
13590 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13591 of variables specific to SELinux and computation of `encoded_absname'.
13592
13593 * image.c (XPutPixel): Remove unused variable `height'.
13594
13595 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13596
13597 * unexw32.c (get_section_info): Remove unused variable `section'.
13598
13599 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13600 (system_process_attributes): Remove unused variable `sess'.
13601 (sys_read): Remove unused variable `err'.
13602
13603 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13604 (w32_wnd_proc): Remove unused variable `isdead'.
13605 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13606 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13607 (x_create_tip_frame): Remove unused variable `tem'.
13608
13609 * w32inevt.c (w32_console_read_socket):
13610 Remove unused variable `no_events'.
13611
13612 * w32term.c (x_draw_composite_glyph_string_foreground):
13613 Remove unused variable `width'.
13614
1149507c
JB
136152011-03-24 Juanma Barranquero <lekktu@gmail.com>
13616
13617 * w32term.c (x_set_glyph_string_clipping):
13618 Don't pass uninitialized region to CombineRgn.
13619
9c88f339
JB
136202011-03-23 Juanma Barranquero <lekktu@gmail.com>
13621
13622 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13623 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13624 (Fx_close_connection): Remove unused variable `i'.
13625
13626 * w32font.c (w32font_draw): Return number of glyphs.
13627 (w32font_open_internal): Remove unused variable `i'.
13628 (w32font_driver): Add missing initializer.
13629
13630 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13631 (fill_in_menu): Remove unused variable `items_added'.
13632
13633 * w32term.c (last_mouse_press_frame): Remove static global variable.
13634 (w32_clip_to_row): Remove unused variable `f'.
13635 (x_delete_terminal): Remove unused variable `i'.
13636
13637 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13638 (NOTHING): Remove unused static global variable.
13639 (uniscribe_check_otf): Remove unused variable `table'.
13640 (uniscribe_font_driver): Add missing initializers.
13641
dee091a3
JD
136422011-03-23 Julien Danjou <julien@danjou.info>
13643
13644 * term.c (Fsuspend_tty, Fresume_tty):
13645 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13646 * window.c (temp_output_buffer_show):
13647 * insdel.c (signal_before_change):
13648 * frame.c (Fhandle_switch_frame):
13649 * fileio.c (Fdo_auto_save):
13650 * emacs.c (Fkill_emacs):
13651 * editfns.c (save_excursion_restore):
13652 * cmds.c (internal_self_insert):
13653 * callint.c (Fcall_interactively):
13654 * buffer.c (Fkill_all_local_variables):
13655 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13656 Use Frun_hooks.
0f4a96b5 13657 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13658 unconditionally since it does the check itself.
dee091a3 13659
2c520ab5 136602011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13661
c9c49752
PE
13662 Fix more problems found by GCC 4.5.2's static checks.
13663
8abc3f12
PE
13664 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13665 the first time through the loop, since we know p0 < p1 then.
13666 This also avoids a gcc -Wstrict-overflow warning.
13667
a2d26660
PE
13668 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13669 leading to a memory leak, possible in functions like
13670 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13671 of objects (Bug#8318).
a2d26660 13672
916c72e9
PE
13673 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13674 that could (at least in theory) be that large.
13675
19ab8a18
PE
13676 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13677 This is less likely to overflow, and avoids undefined behavior if
13678 overflow does occur. All callers changed. Use strtoul to scan
13679 for the unsigned long integer.
b7cbbd6f
PE
13680 (pint2hrstr): Simplify and tune code slightly.
13681 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13682
f0641eff
PE
13683 * scroll.c (do_scrolling): Work around GCC bug 48228.
13684 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13685
7f650bb9
PE
13686 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13687 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13688 (validate_x_resource_name): Simplify count usage.
13689 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13690
37dd57d1
PE
13691 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13692 fail (Bug#8306).
81e56e61 13693
699979fc 13694 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13695
401bf9b4
PE
13696 * process.c (Fmake_network_process): Use socklen_t, not int,
13697 where POSIX says socklen_t is required in portable programs.
13698 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13699 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13700 (Fmake_network_process, server_accept_connection):
13701 (wait_reading_process_output, read_process_output):
13702 Likewise.
13703
b93aacde
PE
13704 * process.c: Rename or move locals to avoid shadowing.
13705 (list_processes_1, Fmake_network_process):
13706 (read_process_output_error_handler, exec_sentinel_error_handler):
13707 Rename or move locals.
4dc343ee 13708 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13709 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13710 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13711 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13712 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13713
af8a867c 13714 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13715 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13716 Include tparam.h instead, since it declares them.
af8a867c
PE
13717 * cm.h (PC): Remove extern decl; tparam.h now does this.
13718 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13719 * terminfo.c: Include tparam.h, to check interfaces.
13720 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13721 (tparam): Adjust signature to match interface in tparam.h;
13722 this removes some undefined behavior. Check that outstring and len
13723 are zero, which they always are with Emacs.
13724 * tparam.h (PC, BC, UP): New extern decls.
13725
0248044d 13726 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13727 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13728
8ff096c1 13729 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13730 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13731 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13732 (ftfont_list): Remove unused local.
49eaafba
PE
13733 (get_adstyle_property, ftfont_pattern_entity):
13734 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13735 Rename locals to avoid shadowing.
8ff096c1 13736
e2be39f6
PE
13737 * xfont.c (xfont_list_family): Mark var as initialized.
13738
c9735e30
PE
13739 * xml.c (make_dom): Now static.
13740
8f5201ae
PE
13741 * composite.c (composition_compute_stop_pos): Rename local to
13742 avoid shadowing.
b246f932
PE
13743 (composition_reseat_it): Remove unused locals.
13744 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13745 (composition_update_it): Mark var as initialized.
11b61122
PE
13746 (find_automatic_composition): Mark vars as initialized,
13747 with a FIXME (Bug#8290).
8f5201ae 13748
760fbc2c
PE
13749 character.h: Rename locals to avoid shadowing.
13750 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13751 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13752 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13753 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13754 to avoid shadowing.
13755
ff08eb85
PE
13756 * textprop.c (property_change_between_p): Remove; unused.
13757
fc7bf025
PE
13758 * intervals.c (interval_start_pos): Now static.
13759
235d7abc
PE
13760 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13761
44f230aa
SM
13762 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13763 Rename locals to avoid shadowing.
3e7d6594 13764
50060332
PE
13765 * sound.c (wav_play, au_play, Fplay_sound_internal):
13766 Fix pointer signedness.
d01f234b 13767 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13768 (wav_play): Initialize a variable to 0, to prevent undefined
13769 behavior (Bug#8278).
50060332 13770
c4fc4e30
PE
13771 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13772
918436ed
PE
13773 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13774
c939f91b
PE
13775 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13776 clobbering (Bug#8298).
b9c7f648
PE
13777 * sysdep.c (sys_subshell): Likewise.
13778 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13779
6bd8c144
PE
13780 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13781 This should get cleaned up, so that child_setup has the
13782 same signature on all platforms.
13783
7710357c 13784 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13785 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13786
c59da222
CY
137872011-03-22 Chong Yidong <cyd@stupidchicken.com>
13788
13789 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13790 not to be necessary, and produces flickering.
13791
66b87493
GM
137922011-03-20 Glenn Morris <rgm@gnu.org>
13793
13794 * config.in: Remove file.
13795
45b6f6d5
JB
137962011-03-20 Juanma Barranquero <lekktu@gmail.com>
13797
13798 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13799 are now in src/globals.h.
13800 (syms_of_minibuf): Remove spurious & from previous change.
13801
cd394be1 138022011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13803
13804 * minibuf.c (completing-read-function): New variable.
13805 (completing-read-default): Rename from completing-read.
13806 (completing-read): Call completing-read-function.
13807
b14e3e21
CY
138082011-03-19 Juanma Barranquero <lekktu@gmail.com>
13809
13810 * xfaces.c (Fx_load_color_file):
13811 Read color file from absolute filename (bug#8250).
13812
f2b726e6
JB
138132011-03-19 Juanma Barranquero <lekktu@gmail.com>
13814
13815 * makefile.w32-in: Update dependencies.
13816
09f6ff02
EZ
138172011-03-17 Eli Zaretskii <eliz@gnu.org>
13818
13819 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13820
29a6015a
PE
138212011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13822
a3a6c54e
PE
13823 Fix more problems found by GCC 4.5.2's static checks.
13824
b766f867
PE
13825 * process.c (make_serial_process_unwind, send_process_trap):
13826 (sigchld_handler): Now static.
13827
be02381c
PE
13828 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13829 That way, the code declares only the vars that it needs.
13830 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13831 * s/cygwin.h (PTY_ITERATION): Likewise.
13832 * s/darwin.h (PTY_ITERATION): Likewise.
13833 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13834
57048744
PE
13835 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13836 * process.c (allocate_pty): Don't declare stb unless it's needed.
13837
7914961c 13838 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13839 (CONSTANTLIM): Remove; unused.
13840 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13841 Define only if needed.
7914961c 13842
b3967b18
PE
13843 * unexelf.c (unexec): Name an expression,
13844 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13845 Use a different way to cause a compilation error if anyone uses
13846 n rather than nn, a way that does not involve shadowing.
73366a00 13847 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13848
29a6015a
PE
13849 * deps.mk (unexalpha.o): Remove; unused.
13850
43cfc33e 13851 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13852 * unexec.h: New file.
ce701a33
PE
13853 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13854 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13855 Depend on unexec.h.
13856 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13857 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13858 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13859 Change as necessary to match prototype in unexec.h.
ce701a33 13860
01f44d5a
PE
13861 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13862 shadowing.
4f63c6bb 13863 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13864
a6670b0b
PE
13865 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13866 Rename locals to avoid shadowing.
13867
cef2010d 13868 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13869 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13870
d4d7173a
PE
13871 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13872
f08b802a
PE
13873 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13874 warning when compiling print.c.
13875
3ddb0639
PE
13876 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13877 instead of using an uninitialized var.
5ad03b97 13878 (font_sort_entities): Mark var as initialized.
3ddb0639 13879
170a2692
PE
13880 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13881
e663c700
PE
13882 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13883 pointers to constants.
89bc529a 13884 (font_parse_fcname): Remove unused vars.
7b81e2d0 13885 (font_delete_unmatched): Now static.
ea838e10 13886 (font_get_spec): Remove; unused.
13a547c6
PE
13887 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13888 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13889 Rename or move locals to avoid shadowing.
e663c700 13890
2a80c887 13891 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13892 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13893
1384fa33 13894 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13895 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13896
8b2c52e9
PE
13897 * alloc.c (mark_backtrace): Move decl from here ...
13898 * lisp.h: ... to here, so that it can be checked.
13899
475545b5 13900 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13901 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13902 (lisp_indirect_variable): Name an expression,
13903 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13904 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13905
b1349114 13906 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13907 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13908 Use const pointer when appropriate.
b1349114 13909
a2928364
PE
13910 * lisp.h (get_system_name, get_operating_system_release):
13911 Move decls here, to check interfaces.
13912 * process.c (get_operating_system_release): Move decl to lisp.h.
13913 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13914 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13915 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13916 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13917 (Fformat_time_string, Fencode_time, Finsert_char):
13918 (Ftranslate_region_internal, Fformat):
13919 Rename or remove local vars to avoid shadowing.
9710023e 13920 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13921
a415e694
PE
13922 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13923 avoid shadowing.
13924
8ef4622d
PE
13925 * lisp.h (eassert): Check that the argument compiles, even if
13926 ENABLE_CHECKING is not defined.
13927
946f9a5b
PE
13928 * data.c (Findirect_variable): Name an expression, to avoid
13929 gcc -Wbad-function-cast warning.
112396d6 13930 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13931 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13932 (Fmake_variable_buffer_local, Fmake_local_variable):
13933 Mark variables as initialized.
52746918 13934 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13935
e5aab7e7 13936 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13937 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13938 Rename locals to avoid shadowing.
dff45157
PE
13939 (mark_stack): Move local variables into the #ifdef region where
13940 they're used.
7bc26fdb
PE
13941 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13942 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13943 needed otherwise.
13944 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13945 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13946 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13947
e5aab7e7
PE
13948 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13949 avoids undefined behavior in theory.
13950
4da60324
PE
13951 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13952
88043301
PE
13953 Use functions, not macros, for up- and down-casing (Bug#8254).
13954 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13955 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13956 to use the following functions instead of these macros.
13957 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13958 EMACS_INT, since callers assume the returned value fits in int.
13959 (upcase1): Likewise, for UPCASE_TABLE.
13960 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13961 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13962 the race-condition problem in the old DOWNCASE.
88043301 13963
19ed5445
PE
13964 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13965 Rename locals to avoid shadowing.
13966 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13967 (regex_compile, re_search_2, re_match_2_internal):
13968 Remove unused local vars.
952db0d7
PE
13969 (FREE_VAR): Rewrite so as not to use empty "else",
13970 which gcc can warn about.
da053e48 13971 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13972 (RETALLOC_IF): Define only if needed.
13973 (WORDCHAR_P): Likewise. This one is never needed, but is used
13974 only in a comment talking about a compiler bug, so put inside
13975 the #if 0 of that comment.
13976 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13977 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13978 Remove; unused.
19ed5445 13979
1f3561e4 13980 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13981 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13982 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13983
ded6f8f7
PE
13984 * search.c (simple_search): Remove unused var.
13985
dbd37a95
PE
13986 * dired.c (compile_pattern): Move decl from here ...
13987 * lisp.h: ... to here, so that it can be checked.
13988 (struct re_registers): New forward decl.
13989
7e47afad
PE
13990 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13991
85f24f61
PE
13992 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13993 All uses changed.
13994 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13995 Rename locals to avoid shadowing.
5671df8f 13996 (Fvertical_motion): Mark locals as initialized.
85f24f61 13997
181aa2be 13998 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13999 (casify_region): Mark local as initialized.
181aa2be 14000
930d429c
PE
14001 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14002
7082eac6
PE
14003 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14004 New macros, so that the caller can use some names other than
14005 gcpro1, gcpro2, etc.
14006 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14007 of the new macros.
14008 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14009 argument, for consistency with GCPRO2_VAR, etc: it is now the
14010 prefix of the variable, not the variable itself. All uses
14011 changed.
38b2c076
PE
14012 * dired.c (directory_files_internal, file_name_completion):
14013 Rename locals to avoid shadowing.
14014
15206ed9
PE
14015 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14016 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14017 dired.c's scmp function, had undefined behavior.
14018 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14019 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14020 * buffer.h: ... to here, because these macros use current_buffer,
14021 and the new implementation with inline functions needs to have
14022 current_buffer in scope now, rather than later when the macros
14023 are used.
14024 (downcase, upcase1): New static inline functions.
14025 (DOWNCASE, UPCASE1): Reimplement using these functions.
14026 This avoids undefined behavior in expressions like
14027 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14028 from race conditions in accessing the global variables
14029 case_temp1 and case_temp2.
14030 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14031 * lisp.h (case_temp1, case_temp2): Remove their decls.
14032 * character.h (ASCII_CHAR_P): Move from here ...
14033 * lisp.h: ... to here, so that the inline functions mentioned
14034 above can use them.
14035
4a6bea26
PE
14036 * dired.c (directory_files_internal_unwind): Now static.
14037
f14b7e14
PE
14038 * fileio.c (file_name_as_directory, directory_file_name):
14039 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14040 Now static.
2893f146
PE
14041 (file_name_as_directory): Use const pointers when appropriate.
14042 (Fexpand_file_name): Likewise. In particular, newdir might
14043 point at constant storage, so make it a const pointer.
fd4ead52 14044 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14045 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14046 signedness issues.
f839df0c
PE
14047 (Fset_file_times, Finsert_file_contents, auto_save_error):
14048 Rename locals to avoid shadowing.
f14b7e14 14049
5716756e 14050 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14051 (Ftry_completion, Fall_completions): Rename or remove locals
14052 to avoid shadowing.
5716756e 14053
b4c3046a
PE
14054 * marker.c (bytepos_to_charpos): Remove; unused.
14055
b45db522
PE
14056 * lisp.h (verify_bytepos, count_markers): New decls,
14057 so that gcc does not warn that these functions aren't declared.
14058
85876d07
PE
14059 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14060 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14061 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14062 (copy_text): Remove unused local var.
85876d07 14063
03d78a21 14064 * filelock.c (within_one_second): Now static.
b3dd38ab 14065 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14066
5df8f01b
PE
14067 * buffer.c (fix_overlays_before): Mark locals as initialized.
14068 (fix_start_end_in_overlays): Likewise. This function should be
14069 simplified by using pointers-to-pointers, but that's a different
14070 matter.
b1d876f1 14071 (switch_to_buffer_1): Now static.
8f54f30a
PE
14072 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14073 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14074
a70072c9 14075 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14076 Fix pointer signedness issue.
edced198
PE
14077 (sys_subshell): Mark local as volatile if checking for lint,
14078 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14079 (MAXPATHLEN): Define only if needed.
a70072c9 14080
a0977c44
PE
14081 * process.c (serial_open, serial_configure): Move decls from here ...
14082 * systty.h: ... to here, so that they can be checked.
14083
a884fdcc
PE
14084 * fns.c (get_random, seed_random): Move extern decls from here ...
14085 * lisp.h: ... to here, so that they can be checked.
14086
604efe86 14087 * sysdep.c (reset_io): Now static.
b8950c94 14088 (wait_for_termination_signal): Remove; unused.
604efe86 14089
38fc62d9
PE
14090 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14091 (copy_keymap_item, append_key, push_text_char_description):
14092 Now static.
1004a21a 14093 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14094 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14095 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14096 (describe_map_tree):
14097 Rename locals to avoid shadowing.
38fc62d9 14098
2f2650da
PE
14099 * keyboard.c: Declare functions static if they are not used elsewhere.
14100 (echo_char, echo_dash, cmd_error, top_level_2):
14101 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14102 (read_char, kbd_buffer_get_event, make_lispy_position):
14103 (make_lispy_event, make_lispy_movement, apply_modifiers):
14104 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14105 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14106 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14107 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14108 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14109
a053e86c 14110 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14111 (mark_kboards): Move decl here ...
14112 * alloc.c (mark_kboards): ... from here.
a053e86c 14113
4752793e
PE
14114 * lisp.h (force_auto_save_soon): New decl.
14115
74f10ca7 14116 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14117 (DEFINE_DUMMY_FUNCTION): New macro.
14118 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14119 Use it.
c03cd23f
PE
14120 (main): Add casts to avoid warnings
14121 if GCC considers string literals to be constants.
74f10ca7 14122
022e70d4
PE
14123 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14124
59d6fe83
PE
14125 * dbusbind.c: Pointer signedness fixes.
14126 (xd_signature, xd_append_arg, xd_initialize):
14127 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14128 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14129 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14130 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14131
78320123
PE
14132 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14133 if GCC considers string literals to be constants.
49cebcca 14134 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14135
35ac2a97
SM
141362011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14137
fb103ca9
SM
14138 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14139 (print_preprocess, print_object): New macro to fix last change.
14140
35ac2a97
SM
14141 * print.c (print_preprocess): Don't forget font objects.
14142
62973b41
JB
141432011-03-16 Juanma Barranquero <lekktu@gmail.com>
14144
14145 * emacs.c (USAGE3): Doc fixes.
14146
0e48bb22
AS
141472011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14148
14149 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14150 structure.
14151
7684e57b
JB
141522011-03-14 Juanma Barranquero <lekktu@gmail.com>
14153
14154 * lisp.h (VWindow_system, Qfile_name_history):
14155 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14156 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14157 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14158
14159 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14160 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14161
14162 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14163 * w32console.c (detect_input_pending, read_input_pending)
14164 (encode_terminal_code):
14165 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14166 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14167 (w32_system_caret_y, Qfile_name_history):
14168 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14169 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14170 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14171 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14172 * w32proc.c (Qlocal, report_file_error):
14173 * w32term.c (Vwindow_system, updating_frame):
14174 * w32uniscribe.c (initialized, uniscribe_font_driver):
14175 Remove unneeded extern declarations.
14176
2aa46d6c
CY
141772011-03-14 Chong Yidong <cyd@stupidchicken.com>
14178
c96bbc66 14179 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14180
cffc6f3b
CY
141812011-03-13 Chong Yidong <cyd@stupidchicken.com>
14182
14183 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14184 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14185 These macros can no longer be used for assignment.
14186
44f230aa
SM
14187 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14188 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14189 (record_buffer_markers, fetch_buffer_markers): New functions for
14190 recording and fetching special buffer markers.
14191 (set_buffer_internal_1, set_buffer_temp): Use them.
14192
14193 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14194
14195 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14196
14197 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14198 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14199
14200 * xdisp.c (hscroll_window_tree):
14201 (reconsider_clip_changes): Use PT instead of BUF_PT.
14202
d251f04b
EZ
142032011-03-13 Eli Zaretskii <eliz@gnu.org>
14204
14205 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14206 $(EMACS_ROOT)/lib/intprops.h.
14207
f0c77cd1
PE
142082011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14209
3eca4629
PE
14210 Fix more problems found by GCC 4.5.2's static checks.
14211
7c86ee98
PE
14212 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14213 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14214 (xg_free_frame_widgets): Make it clear that a local variable is
14215 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14216 (gdk_window_get_screen): Make it clear that this macro is needed
14217 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14218 (int_gtk_range_get_value): New function, which avoids a diagnostic
14219 from gcc -Wbad-function-cast.
14220 (xg_set_toolkit_scroll_bar_thumb): Use it.
14221 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14222 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14223 (get_utf8_string, xg_get_file_with_chooser):
14224 Rename locals to avoid shadowing.
14225 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14226
41729b81
PE
14227 * xgselect.c (xg_select): Remove unused var.
14228
f0c77cd1
PE
14229 * image.c (four_corners_best): Mark locals as initialized.
14230 (gif_load): Initialize transparent_p to zero (Bug#8238).
14231 Mark another local as initialized.
ec6cf4c6 14232 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14233
ce0ad53d 14234 * image.c (clear_image_cache): Now static.
d5d5a617 14235 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14236 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14237 (x_edge_detection): Remove unnecessary cast that
14238 gcc -Wbad-function-cast diagnoses.
2037898d 14239 (gif_load): Fix pointer signedness.
6ae141d6
PE
14240 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14241 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14242
33383987 142432011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14244
d32df629
PE
14245 Improve quality of tests for time stamp overflow.
14246 For example, without this patch (encode-time 0 0 0 1 1
14247 1152921504606846976) returns the obviously-bogus value (-948597
14248 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14249 reports time overflow. See
14250 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14251 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14252 * editfns.c: Include limits.h and intprops.h.
14253 (TIME_T_MIN, TIME_T_MAX): New macros.
14254 (time_overflow): Move earlier, to before first use.
14255 (hi_time, lo_time): New functions, for an accurate test for
14256 out-of-range times.
14257 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14258 (Fget_internal_run_time): Don't assume time_t fits in int.
14259 (make_time): Use list2 instead of Fcons twice.
14260 (Fdecode_time): More accurate test for out-of-range times.
14261 (check_tm_member): New function.
14262 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14263 (lisp_time_argument): Don't rely on undefined left-shift and
14264 right-shift behavior when checking for time stamp overflow.
8be6f318 14265
fe31d94c
PE
14266 * editfns.c (time_overflow): New function, refactoring common code.
14267 (Fformat_time_string, Fdecode_time, Fencode_time):
14268 (Fcurrent_time_string): Use it.
14269
8be6f318
PE
14270 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14271 * dired.c (make_time): Move to ...
14272 * editfns.c (make_time): ... here.
14273 * systime.h: Note the move.
14274
09d9db2c 142752011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14276
126bc0dc
YM
14277 * fringe.c (update_window_fringes): Remove unused variables.
14278
c47cbdfd
YM
14279 * unexmacosx.c (copy_data_segment): Also copy __got section.
14280 (Bug#8223)
14281
7ac80be9
EZ
142822011-03-12 Eli Zaretskii <eliz@gnu.org>
14283
c96bbc66 14284 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14285 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14286 Constify `char *' arguments and their references according to
14287 prototypes in tparam.h.
14288
ecb0f94d 14289 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14290
7ac80be9
EZ
14291 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14292 Adapt all references accordingly.
14293
14294 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14295
ef1fd07e
TT
142962011-03-11 Tom Tromey <tromey@redhat.com>
14297
14298 * buffer.c (syms_of_buffer): Remove obsolete comment.
14299
7ef4b50c
EZ
143002011-03-11 Eli Zaretskii <eliz@gnu.org>
14301
14302 * termhooks.h (encode_terminal_code): Declare prototype.
14303
14304 * msdos.c (encode_terminal_code): Don't declare prototype.
14305
14306 * term.c (encode_terminal_code): Now external again, used by
14307 w32console.c and msdos.c.
14308
44f230aa
SM
14309 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14310 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14311
4b1ec863 143122011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14313
1714f52b 14314 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14315
4b1ec863
PE
14316 * fringe.c (update_window_fringes): Mark locals as initialized
14317 (Bug#8227).
14318 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14319
524c7aa6
PE
14320 * alloc.c (mark_fringe_data): Move decl from here ...
14321 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14322 to check its interface.
14323 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14324
a5c0af81 14325 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14326 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14327 (fontset_font): Mark local as initialized.
a9a06e0b 14328 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14329
b4716021
PE
14330 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14331
811e9bac 14332 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14333 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14334 (x_own_selection, Fx_disown_selection_internal): Rename locals
14335 to avoid shadowing.
14336 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14337
7e3ab302
PE
14338 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14339 so that the caller can use some name other than gcpro1.
14340 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14341 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14342 (Fx_backspace_delete_keys_p):
14343 Use them to avoid shadowing, and rename vars to avoid shadowing.
14344 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14345 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14346 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14347 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14348 Remove unused locals.
7e3ab302
PE
14349 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14350 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14351 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14352 macros.
f78faa98 14353
e2b13473
PE
14354 * xterm.h (x_mouse_leave): New decl.
14355
77f23912
PE
14356 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14357 Remove unused functions.
cdf4ba58
PE
14358 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14359 (x_calc_absolute_position): Now static.
7411c686 14360 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14361 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14362 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14363 unless they are used.
38d0b34a
PE
14364 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14365 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14366 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14367 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14368 (x_error_catcher, x_connection_closed, x_error_handler):
14369 (x_error_quitter, xembed_send_message, x_iconify_frame):
14370 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14371 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14372 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14373
44f230aa
SM
14374 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14375 Rename or move locals to avoid shadowing.
6b463e58 14376 (tty_defined_color, merge_face_heights): Now static.
5967d051 14377 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14378 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14379 does not deduce is never used uninitialized.
73719eba
PE
14380 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14381 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14382
426994c3 14383 * terminal.c (store_terminal_param): Now static.
5489860b 14384
032f1620 14385 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14386 (set_frame_menubar): Remove unused local.
d4323972 14387 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14388 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14389 since they might point to immutable storage.
281585b0
PE
14390 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14391 since it's unused otherwise.
032f1620 14392
367c19e5 14393 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14394 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14395 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14396 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14397 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14398 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14399 does not deduce are never used uninitialized.
70739cbe 14400
07b48fa9
PE
14401 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14402
8868a238 14403 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14404 * window.c (window_loop, size_window):
14405 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14406
7e5cf297 14407 * window.c (display_buffer): Now static.
d6550a9f
PE
14408 (size_window): Mark variables that gcc -Wuninitialized
14409 does not deduce are never used uninitialized.
a586633d
PE
14410 * window.h (check_all_windows): New decl, to forestall
14411 gcc -Wmissing-prototypes diagnostic.
5b555da1 14412 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14413
f6095868
PE
14414 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14415 shadowing.
14416 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14417 Include <limits.h>.
14418 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14419 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14420 (load_charset_map): Mark variables that gcc -Wuninitialized
14421 does not deduce are never used uninitialized.
53df7c11 14422 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14423
f38b440c
PE
14424 * coding.c (coding_set_source, coding_set_destination):
14425 Use "else { /* comment */ }" rather than "else /* comment */;"
14426 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14427 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14428 a block, when the outer 'i' will do.
14429 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14430 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14431 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14432 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14433 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14434 Rename locals to avoid shadowing.
14435 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14436 * coding.c (emacs_mule_char, encode_invocation_designation):
14437 Now static, since they're not used elsewhere.
413bb2db 14438 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14439 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14440 (decode_coding_emacs_mule): Mark variables that gcc
14441 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14442 (detect_coding_iso_2022): Initialize a local variable that might
14443 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14444 this initialization is needed. (Bug#8211)
5f58e762
PE
14445 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14446 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14447 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14448 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14449 Remove unused macros.
f38b440c 14450
232b38b9 14451 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14452 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14453 * character.c (string_count_byte8): Likewise.
232b38b9 14454
fb90da1b
PE
14455 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14456 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14457
fb93dbc2
PE
14458 * chartab.c (copy_sub_char_table): Now static, since it's not used
14459 elsewhere.
5c156ace
PE
14460 (sub_char_table_ref_and_range, char_table_ref_and_range):
14461 Rename locals to avoid shadowing.
bbcd0949 14462 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14463
7d3b3862 14464 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14465 (BIDI_BOB): Remove unused macro.
7d3b3862 14466
6be7d3da
PE
14467 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14468 deduce are never used uninitialized.
c2ed9c8b 14469 * term.c (encode_terminal_code): Likewise.
6be7d3da 14470
75f8807f 14471 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14472
50938595
PE
14473 * tparam.h: New file.
14474 * term.c, tparam.h: Include it.
14475 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14476 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14477 Move these decls to tparam.h, and make them agree with what
14478 is actually in tparam.c. The previous trick of using incompatible
14479 decls in different modules does not conform to the C standard.
14480 All callers of tparam changed to use tparam's actual API.
14481 * tparam.c (tparam1, tparam, tgoto):
14482 Use const pointers where appropriate.
14483
fbceeba2
PE
14484 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14485 * cm.h (struct cm): Likewise.
14486 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14487 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14488 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14489 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14490 (turn_on_face, init_tty): Likewise.
14491 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14492
7f3f1250
PE
14493 * term.c (term_mouse_position): Rename local to avoid shadowing.
14494
e6ca6543
PE
14495 * alloc.c (mark_ttys): Move decl from here ...
14496 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14497
c40f8d15
AS
144982011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14499
14500 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14501
cfe0661d
JB
145022011-03-09 Juanma Barranquero <lekktu@gmail.com>
14503
14504 * search.c (compile_pattern_1): Remove argument regp, unused since
14505 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14506 (compile_pattern): Don't pass it.
14507
0afb4571
J
145082011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14509
14510 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14511 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14512 for ! HAVE_GTK3.
14513 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14514
14515 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14516
14517 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14518 gdk_window_get_screen, gdk_window_get_geometry,
14519 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14520 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14521 (xg_get_pixbuf_from_pixmap): New function.
14522 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14523 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14524 Call xg_get_pixbuf_from_pixmap instead of
14525 gdk_pixbuf_get_from_drawable.
14526 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14527 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14528 (xg_check_special_colors): Use GtkStyleContext and its functions
14529 for HAVE_GTK3.
14530 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14531 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14532 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14533 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14534 Call gtk_widget_get_preferred_size.
0afb4571
J
14535 (xg_frame_resized): gdk_window_get_geometry only takes 5
14536 parameters.
44f230aa
SM
14537 (xg_win_to_widget, xg_event_is_for_menubar):
14538 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14539 (xg_set_widget_bg): New function.
14540 (delete_cb): New function.
895009e1 14541 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14542 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14543 (xg_set_background_color): Call xg_set_widget_bg.
14544 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14545 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14546 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14547 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14548 if ! HAVE_GTK3.
14549 (update_frame_tool_bar): Call gtk_widget_hide.
14550 (xg_initialize): Use GDK_KEY_g.
14551
14552 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14553 if ! HAVE_GTK3
14554 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14555
14556 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14557 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14558 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14559
1c2cc4ef
JB
145602011-03-08 Juanma Barranquero <lekktu@gmail.com>
14561
14562 * w32xfns.c (select_palette): Check success of RealizePalette against
14563 GDI_ERROR, not zero.
14564
33383987 14565See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14566
14567;; Local Variables:
14568;; coding: utf-8
aac0c6e3
MR
14569;; End:
14570
2f097256 14571 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14572
14573 This file is part of GNU Emacs.
14574
14575 GNU Emacs is free software: you can redistribute it and/or modify
14576 it under the terms of the GNU General Public License as published by
14577 the Free Software Foundation, either version 3 of the License, or
14578 (at your option) any later version.
14579
14580 GNU Emacs is distributed in the hope that it will be useful,
14581 but WITHOUT ANY WARRANTY; without even the implied warranty of
14582 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14583 GNU General Public License for more details.
14584
14585 You should have received a copy of the GNU General Public License
14586 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.