Fix minor corner case bugs in byte compilation and pcase.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
85d0efd1
EZ
12012-05-28 Eli Zaretskii <eliz@gnu.org>
2
3 * w32term.c (my_bring_window_to_top): New function.
4 (x_raise_frame): Use handle returned by DeferWindowPos, which
5 could be different from the original one. Call
6 my_bring_window_to_top instead of my_set_foreground_window.
7 (Bug#11513)
8
9 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
10 by calling BringWindowToTop.
11
12 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
13 (WM_EMACS_END): Increase by one.
14
da92a98c
PE
152012-05-28 Paul Eggert <eggert@cs.ucla.edu>
16
17 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
18 This avoids undefined behavior that might cause the eassert
19 to not catch an out-of-range value.
20
74d1f848
JB
212012-05-28 Juanma Barranquero <lekktu@gmail.com>
22
23 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
24 Update dependencies.
25
9e1a06fc
EZ
262012-05-27 Eli Zaretskii <eliz@gnu.org>
27
28 * bidi.c (bidi_mirror_char): Fix last change.
29
f3dd7312
AS
302012-05-27 Andreas Schwab <schwab@linux-m68k.org>
31
32 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
33 when referring to sectname field in printf format.
34
81899c91
PE
352012-05-27 Paul Eggert <eggert@cs.ucla.edu>
36
57b81a9f
PE
37 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
38 Only r_alloc_inhibit_buffer_relocation needed to be added;
39 the others were already declared.
40
81899c91
PE
41 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
42 before checking whether it's out of range. Put the check inside
43 eassert. See
44 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
45
33017faf 462012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
47
48 * callproc.c (Fcall_process): Restore a line that was accidentally
49 commented out in the 2011-02-13 change (bug#11547).
50
33017faf 512012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
52
53 * lisp.h [REL_ALLOC]: Add prototypes for external functions
54 defined on ralloc.c.
55
56 * buffer.c [REL_ALLOC]: Remove prototypes of
57 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
58 they are now on lisp.h.
59
60 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
61
62 * search.c (search_buffer): Use it to inhibit relocation of buffer
63 text while re_search_2 is doing its job, because re_search_2 is
64 passed C pointers to buffer text. (Bug#11519)
65
23415acf
EZ
66 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
67 Update value to 24.
68
44e27368
EZ
69 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
70 state after an additional call to move_it_in_display_line_to, keep
71 the values of it->max_ascent and it->max_descent found for the
72 entire line.
73 (pos_visible_p): Revert the comparison against bottom_y to what it
74 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
75 (Bug#11464)
76
c1892f11
PE
772012-05-26 Paul Eggert <eggert@cs.ucla.edu>
78
79 Fix coding-related core dumps with gcc -ftrapv.
80 The code was computing A - B, where A and B are pointers, and B is
81 random garbage. This can lead to core dumps on platforms that
82 have special pointer registers, and it also leads to core dumps on
83 x86-64 when compiled with gcc -ftrapv. The fix is to compute
84 A - B only when B is initialized properly.
85 * coding.c (coding_set_source, coding_set_destination): Return void.
86 (coding_change_source, coding_change_destinations): New functions,
87 with the old behaviors of coding_set_source and coding_set_destination.
88 All callers that need an offset changed to use these new functions.
89
eb7afdad
GM
902012-05-26 Glenn Morris <rgm@gnu.org>
91
92 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
93
f12fdf02
EZ
942012-05-26 Eli Zaretskii <eliz@gnu.org>
95
53a63be6 96 Extend mouse support on W32 text-mode console.
eb3f6f01
EZ
97 * xdisp.c (draw_row_with_mouse_face): Call
98 tty_draw_row_with_mouse_face for WINDOWSNT as well.
99
eb3f6f01
EZ
100 * w32console.c: Include window.h.
101 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face): New
102 functions.
103 (initialize_w32_display): Initialize mouse-highlight data.
104
53a63be6
EZ
105 * w32inevt.c: Include termchar.h and window.h.
106 (do_mouse_event): Support mouse-autoselect-window. When the mouse
107 moves, call note_mouse_highlight. If help_echo changed, call
108 gen_help_event to produce help-echo message in the echo area.
109 Call clear_mouse_face if mouse_face_hidden is set in the mouse
110 highlight info.
111
4cfd81f6
PE
1122012-05-26 Paul Eggert <eggert@cs.ucla.edu>
113
114 * lread.c (read1): Simplify slightly to avoid an overflow warning
115 with GCC 4.7.0 on x86-64.
116
4446092a
EZ
1172012-05-26 Eli Zaretskii <eliz@gnu.org>
118
119 * bidi.c (bidi_mirror_char): Revert last change: an int is
120 definitely wide enough here.
121
42b2a986 1222012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 123
42b2a986 124 Fix integer width and related bugs (Bug#9874).
eb106a49 125 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
126 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
127 (string_bytes, check_sblock, allocate_string_data):
128 (compact_small_strings, Fmake_bool_vector, make_string)
129 (make_unibyte_string, make_multibyte_string)
130 (make_string_from_bytes, make_specified_string)
131 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
132 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
133 (mark_vectorlike):
134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
135 (allocate_pseudovector):
136 Use int, not EMACS_INT, where int is wide enough.
137 (inhibit_garbage_collection, Fgarbage_collect):
138 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
139 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
140 int might not be wide enough.
141 (bidi_cache_search, bidi_cache_find, bidi_init_it)
142 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
143 (bidi_at_paragraph_end, bidi_find_paragraph_start)
144 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
145 (bidi_level_of_next_char, bidi_move_to_visually_next):
146 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
147 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
148 (Fkill_buffer, Fset_buffer_major_mode)
149 (advance_to_char_boundary, Fbuffer_swap_text)
150 (Fset_buffer_multibyte, overlays_at, overlays_in)
151 (overlay_touches_p, struct sortvec, record_overlay_string)
152 (overlay_strings, recenter_overlay_lists)
153 (adjust_overlays_for_insert, adjust_overlays_for_delete)
154 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
155 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
156 (Foverlay_recenter, last_overlay_modification_hooks_used)
157 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
159 (validate_region): Omit unnecessary test for b <= e,
160 since that's guaranteed by the previous test.
d311d28c
PE
161 (adjust_overlays_for_delete): Avoid pos + length overflow.
162 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
163 (report_overlay_modification):
164 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
165 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
166 Omit pointer cast, which isn't needed anyway, and doesn't work
167 after the EMACS_INT -> ptrdiff_t change.
02481186 168 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
169 * buffer.h: Adjust decls to match defn changes elsewhere.
170 (struct buffer_text, struct buffer):
171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
172 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
173 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
174 not int, to avoid needless 32-bit limit on 64-bit hosts.
175 (exec_byte_code): Use tighter memory-full test, one that checks
176 for alloca overflow. Don't compute the address of the object just
177 before an array, as that's not portable. Use EMACS_INT, not
178 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
179 * callint.c (Fcall_interactively):
180 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
181 * callproc.c (call_process_kill, Fcall_process):
182 Don't assume pid_t fits into an Emacs fixnum.
183 (call_process_cleanup, Fcall_process, child_setup):
184 Don't assume pid_t fits into int.
185 (call_process_cleanup, Fcall_process, delete_temp_file)
186 (Fcall_process_region):
187 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
188 (Fcall_process): Simplify handling of volatile integers.
189 Use int, not EMACS_INT, where int will do.
190 * casefiddle.c (casify_object, casify_region, operate_on_word)
191 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
193 (casify_object): Avoid integer overflow when overallocating buffer.
194 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 195 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
196 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
197 * category.h (CATEGORYP): Don't assume arg is nonnegative.
198 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
199 integers are now checked earlier. All uses replaced with XINT.
200 (ccl_driver):
201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
202 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
203 (ccl_driver, Fregister_code_conversion_map):
204 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
205 (resolve_symbol_ccl_program): Check that vector header is in range.
206 Always copy the vector, so that we can check its contents reliably
207 now rather than having to recheck each instruction as it's being
208 executed. Check that vector words fit in 'int'.
209 (ccl_get_compiled_code, Fregister_ccl_program)
210 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
211 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
212 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
213 contents are in range.
214 (Fccl_execute_on_string): Check that status is in range.
215 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
216 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
217 Accept and return EMACS_INT, not int, because callers can pass values
218 out of 'int' range.
219 (c_string_width, strwidth, lisp_string_width, chars_in_text)
220 (multibyte_chars_in_text, parse_str_as_multibyte)
221 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
222 (str_as_unibyte, str_to_unibyte, string_count_byte8)
223 (string_escape_byte8, Fget_byte):
224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 225 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
226 avoid mishandling large integers.
227 * character.h: Adjust decls to match defn changes elsewhere.
228 * charset.c (load_charset_map_from_file, find_charsets_in_text)
229 (Ffind_charset_region):
230 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
231 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
232 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 233 Don't assume fixnum fits in int.
d311d28c
PE
234 (load_charset_map_from_vector, Fmap_charset_chars):
235 Remove now-unnecessary CHECK_NATNUMs.
236 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
237 Don't rely on undefined behavior with signed left shift overflow.
238 Don't assume unsigned int fits into fixnum, or that fixnum fits
239 into unsigned int. Don't require max_code to be a valid fixnum;
240 that's not true for gb10830 4-byte on a 32-bit host. Allow
241 invalid_code to be a cons, for the same reason. Require code_offset
242 to be a character. Avoid int overflow if max_char is close
243 to INT_MAX.
244 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
245 this is intended anyway and avoids some undefined behavior.
246 (load_charset_map): Pass unsigned, not int, as 2nd arg of
247 INDEX_TO_CODE_POINT, as that's what it expects.
248 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
249 * charset.h (DECODE_CHAR): Return int, not unsigned;
250 this is what was intended anyway, and it avoids undefined behavior.
251 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
252 integer-overflow issues.
253 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
254 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
255 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
256 * chartab.c (Fmake_char_table, Fset_char_table_range)
257 (uniprop_get_decoder, uniprop_get_encoder):
258 Don't assume fixnum fits in int.
259 * cmds.c (move_point): New function, that does the gist of
260 Fforward_char and Fbackward_char, but does so while checking
261 for integer overflow more accurately.
c96e5d6a 262 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
263 (Fforward_line, Fend_of_line, internal_self_insert)
264 (internal_self_insert):
265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
266 Fix a FIXME, by checking for integer overflow when calculating
267 target_clm and actual_clm.
268 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 269 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
270 (ASSURE_DESTINATION, coding_alloc_by_realloc)
271 (coding_alloc_by_making_gap, alloc_destination)
272 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
273 (encode_coding_utf_16, detect_coding_emacs_mule)
274 (decode_coding_emacs_mule, encode_coding_emacs_mule)
275 (detect_coding_iso_2022, decode_coding_iso_2022)
276 (encode_invocation_designation, encode_designation_at_bol)
277 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
278 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
279 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
280 (encode_coding_ccl, encode_coding_raw_text)
281 (detect_coding_charset, decode_coding_charset)
282 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
283 (produce_composition, produce_charset, produce_annotation)
284 (decode_coding, handle_composition_annotation)
285 (handle_charset_annotation, consume_chars, decode_coding_gap)
286 (decode_coding_object, encode_coding_object, detect_coding_system)
287 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
288 (code_convert_region, code_convert_string)
8f50130c
PE
289 (Fdefine_coding_system_internal)
290 (coding_set_source, coding_set_destination):
d311d28c
PE
291 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
292 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
293 (Fdefine_coding_system_internal):
294 Don't assume fixnums fit in int.
295 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 296 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
297 (Funencodable_char_position, Fcheck_coding_systems_region)
298 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 300 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 301 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 302 Don't access memory outside of the args array.
d311d28c 303 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
304 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
305 result of ENCODE_CHAR.
d311d28c
PE
306 * coding.h: Adjust decls to match defn changes elsewhere.
307 (struct coding_system):
308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
309 * composite.c (get_composition_id, find_composition)
310 (run_composition_function, update_compositions)
311 (compose_text, composition_gstring_put_cache)
312 (composition_gstring_p, composition_gstring_width)
313 (fill_gstring_header, fill_gstring_body, autocmp_chars)
314 (composition_compute_stop_pos, composition_reseat_it)
315 (composition_update_it, struct position_record)
316 (find_automatic_composition, composition_adjust_point)
317 (Fcomposition_get_gstring, Ffind_composition_internal):
318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
319 (update_compositions):
320 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
321 * composite.h: Adjust decls to match defn changes elsewhere.
322 (struct composition):
323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
324 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
325 Do not attempt to compute the address of the object just before a
326 buffer; this is not portable.
327 (Faref, Faset):
328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
329 (Faset): Use int, not EMACS_INT, where int is wide enough.
330 (Fstring_to_number): Don't assume fixnums fit in int.
331 (Frem): Don't assume arg is nonnegative.
332 * dbusbind.c (xd_append_arg): Check for integers out of range.
333 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 334 (extract_signed, extract_unsigned): New functions.
243e0530
PE
335 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
336 (xd_get_connection_references): Return ptrdiff_t, not int.
337 All uses changed.
338 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
339 (xd_read_message_1):
340 Use int, not unsigned, where the dbus API uses int.
341 (Fdbus_message_internal): Don't overflow mtype.
342 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
343 * dired.c (directory_files_internal, file_name_completion, scmp)
344 (file_name_completion_stat):
345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
346 (file_name_completion): Don't overflow matchcount.
347 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
348 * dispextern.h: Adjust decls to match defn changes elsewhere.
349 (struct text_pos, struct glyph, struct bidi_saved_info)
350 (struct bidi_string_data, struct bidi_it, struct composition_it)
351 (struct it):
352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
353 (struct display_pos, struct composition_it, struct it):
354 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
355 * dispnew.c (increment_matrix_positions)
356 (increment_row_positions, mode_line_string)
357 (marginal_area_string):
358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 359 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
360 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
361 (duration_to_sec_usec): New function, to check for overflow better.
362 (Fsleep_for, sit_for): Use it.
363 * doc.c (get_doc_string, store_function_docstring):
364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
365 (get_doc_string, Fsnarf_documentation):
366 Use int, not EMACS_INT, where int is wide enough.
367 (get_doc_string):
368 Use SAFE_ALLOCA, not alloca.
369 Check for overflow when converting EMACS_INT to off_t.
370 * doprnt.c (doprnt):
371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
372 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
373 Don't assume uid_t fits into fixnum.
374 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
375 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
376 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
377 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
378 (general_insert_function)
379 (Finsert_char, make_buffer_string, make_buffer_string_both)
380 (update_buffer_properties, Fbuffer_substring)
381 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
382 (Fsubst_char_in_region, check_translation)
383 (Ftranslate_region_internal, save_restriction_restore, Fformat)
384 (transpose_markers, Ftranspose_regions):
385 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
386 (clip_to_bounds): Move to lisp.h as an inline function).
387 (Fconstrain_to_field): Don't assume integers are nonnegative.
388 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
389 (Fsubst_char_in_region, Fsave_restriction):
390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
391 (Femacs_pid): Don't assume pid_t fits into fixnum.
392 (lo_time): Use int, not EMACS_INT, when int suffices.
393 (lisp_time_argument): Check for usec out of range.
394 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
395 (Fuser_login_name, Fuser_full_name): Signal an error
396 if a uid argument is out of range, rather than relying on
397 undefined behavior.
c8d5c857
PE
398 (Fformat_time_string): Remove now-unnecessary check.
399 lisp_time_argument checks for out-of-range usec now.
243e0530 400 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
401 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
402 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
403 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
404 (init_cmdargs, Fdump_emacs):
405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
406 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
407 the bottom (typically) 32 bits of the fixnum.
408 * eval.c (specpdl_size, call_debugger):
409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
410 (when_entered_debugger, Fbacktrace_debug):
411 Don't assume fixnum can fit in int.
412 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
413 the object just before a buffer; this is not portable.
414 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
415 (grow_specpdl, unbind_to):
416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
417 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
418 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 419 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
420 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
421 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
423 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
424 (a_write, e_write):
425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
426 (Fcopy_file, non_regular_nbytes, read_non_regular)
427 (Finsert_file_contents):
428 Use int, not EMACS_INT, where int is wide enough.
429 (READ_BUF_SIZE): Verify that it fits in int.
430 (Finsert_file_contents): Check that counts are in proper range,
431 rather than assuming fixnums fit into ptrdiff_t etc.
432 Don't assume fixnums fit into int.
125b3835 433 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
434 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
435 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
436 (string_char_to_byte, string_byte_to_char)
437 (string_make_multibyte, string_to_multibyte)
438 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
439 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
440 (substring_both, Fdelete, internal_equal, Ffillarray)
441 (Fclear_string, mapcar1)
442 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
443 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
444 (larger_vector, make_hash_table, maybe_resize_hash_table)
445 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
446 (Fmaphash, secure_hash):
447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
448 (concat): Check for string index and length overflow.
449 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
450 (Frequire):
451 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
452 (larger_vector): New API (vec, incr_min, size_max) replaces old
453 one (vec, new_size, init). This catches size overflow.
454 INIT was removed because it was always Qnil.
455 All callers changed.
456 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
457 the upper bound on a hash table index size.
458 (make_hash_table, maybe_resize_hash_table): Use it.
459 (secure_hash): Computer start_byte and end_byte only after
460 they're known to be in ptrdiff_t range.
461 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
462 (Ffont_get_glyphs, Ffont_at):
463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
464 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
465 (Flist_fonts, Fopen_font):
466 Don't assume fixnum can fit in int.
467 (check_gstring): Don't assume index can fit in int.
468 (font_match_p): Check that fixnum is a character, not a nonnegative
469 fixnum, since the later code needs to stuff it into an int.
470 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
471 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
472 conversion overflow issues.
473 (Fopen_font): Check for integer out of range.
474 (Ffont_get_glyphs): Don't assume index can fit in int.
475 * font.h: Adjust decls to match defn changes elsewhere.
476 * fontset.c (reorder_font_vector): Redo score calculation to avoid
477 integer overflow.
478 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
479 printmax_t, where ptrdiff_t is wide enough.
480 (Finternal_char_font):
481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
482 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
483 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
484 (Fset_frame_position, x_set_frame_parameters)
485 (x_set_line_spacing, x_set_border_width)
486 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
487 Check that fixnums are in proper range for system types.
488 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
490 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
491 Use SAFE_ALLOCA_LISP, not alloca.
492 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
493 intptr_t is wide enough.
494 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
495 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
496 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
497 Check for fixnum out of range.
498 * ftfont.c (ftfont_list): Don't assume index fits in int.
499 Check that fixnums are in proper range for system types.
500 (ftfont_shape_by_flt):
501 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
502 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
504 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
505 Check that fixnums are in proper range for system types.
506 * gnutls.h: Adjust decls to match defn changes elsewhere.
507 * gtkutil.c (xg_dialog_run):
508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
509 (update_frame_tool_bar):
510 Check that fixnums are in proper range for system types.
511 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 512 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
513 * indent.c (last_known_column, last_known_column_point):
514 (current_column_bol_cache):
515 (skip_invisible, current_column, check_display_width):
516 (check_display_width, scan_for_column, current_column_1)
517 (Findent_to, Fcurrent_indentation, position_indentation)
518 (indented_beyond_p, Fmove_to_column, compute_motion):
519 (Fcompute_motion, Fvertical_motion):
520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
521 (last_known_column_modified): Use EMACS_INT, not int.
522 (check_display_width):
523 (Fcompute_motion):
524 Check that fixnums and floats are in proper range for system types.
525 (compute_motion): Don't assume index or fixnum fits in int.
526 (compute_motion, Fcompute_motion):
527 Use int, not EMACS_INT, when it is wide enough.
528 (vmotion): Omit local var start_hpos that is always 0; that way
529 we don't need to worry about overflow in expressions involving it.
530 * indent.h: Adjust decls to match defn changes elsewhere.
531 (struct position):
532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
533 Use int, not EMACS_INT, where int is wide enough.
534 Remove unused members ovstring_chars_done and tab_offset;
535 all uses removed.
536 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
537 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
538 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
539 (make_gap, copy_text, insert, insert_and_inherit)
540 (insert_before_markers, insert_before_markers_and_inherit)
541 (insert_1, count_combining_before, count_combining_after)
542 (insert_1_both, insert_from_string)
543 (insert_from_string_before_markers, insert_from_string_1)
544 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
545 (adjust_after_replace, adjust_after_insert, replace_range)
546 (replace_range_2, del_range, del_range_1, del_range_byte)
547 (del_range_both, del_range_2, modify_region)
548 (prepare_to_modify_buffer, signal_before_change)
549 (signal_after_change, Fcombine_after_change_execute):
550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
551 * intervals.c (traverse_intervals, rotate_right, rotate_left)
552 (balance_an_interval, split_interval_right, split_interval_left)
553 (find_interval, next_interval, update_interval)
554 (adjust_intervals_for_insertion, delete_node, delete_interval)
555 (interval_deletion_adjustment, adjust_intervals_for_deletion)
556 (static_offset_intervals, offset_intervals)
557 (merge_interval_right, merge_interval_left, make_new_interval)
558 (graft_intervals_into_buffer, temp_set_point_both)
559 (temp_set_point, set_point, adjust_for_invis_intang)
560 (set_point_both, move_if_not_intangible, get_property_and_range)
561 (get_local_map, copy_intervals, copy_intervals_to_string)
562 (compare_string_intervals, set_intervals_multibyte_1):
563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
564 * intervals.h: Adjust decls to match defn changes elsewhere.
565 (struct interval):
566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
567 * keyboard.c (this_command_key_count, this_single_command_key_start)
568 (before_command_key_count, before_command_echo_length, echo_now)
569 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
570 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
571 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
572 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
574 (last_non_minibuf_size, last_point_position, echo_truncate)
575 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
576 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
577 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
578 (stuff_buffered_input):
579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
580 (last_auto_save, command_loop_1, read_char):
581 Use EMACS_INT, not int, to avoid integer overflow.
582 (record_char): Avoid overflow in total_keys computation.
583 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
584 * keyboard.h: Adjust decls to match defn changes elsewhere.
585 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
586 (Fkey_description, Fdescribe_vector, Flookup_key):
587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
588 (click_position): New function, to check that positions are in range.
589 (Fcurrent_active_maps):
590 (describe_command):
591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
592 (Faccessible_keymaps, Fkey_description):
593 (preferred_sequence_p):
594 Don't assume fixnum can fit into int.
595 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
596 Check for integer overflow in size calculations.
597 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
598 avoid mishandling large integers.
599 * lisp.h: Adjust decls to match defn changes elsewhere.
600 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
601 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
602 (struct Lisp_Marker):
603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
604 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
605 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
606 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
607 All callers changed.
608 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
609 Assume the arg has valid form, since it always does.
610 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
611 unsigned integer system type.
612 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
613 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
614 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
615 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
616 (duration_to_sec_usec): New decl.
617 * lread.c (read_from_string_index, read_from_string_index_byte)
618 (read_from_string_limit, readchar, unreadchar, openp)
619 (read_internal_start, read1, oblookup):
620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
621 (Fload, readevalloop, Feval_buffer, Feval_region):
622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
623 (openp): Check for out-of-range argument to 'access'.
624 (read1): Use int, not EMACS_INT, where int is wide enough.
625 Don't assume fixnum fits into int.
6efdadfd 626 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
627 (read_filtered_event): Use duration_to_sec_usec
628 to do proper overflow checking on durations.
d311d28c
PE
629 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
630 in size calculation.
631 (Fexecute_kbd_macro):
632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
633 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
634 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
635 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
636 (set_marker_both, set_marker_restricted_both, marker_position)
637 (marker_byte_position, Fbuffer_has_markers_at):
638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
639 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
640 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
641 It now merely ensures that the menu is large enough, without
642 necessarily growing it, as this avoids some integer overflow issues.
643 All callers changed.
644 (keymap_panes, parse_single_submenu, Fx_popup_menu):
645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
646 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
647 Use SAFE_ALLOCA_LISP, not alloca.
648 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
649 to EMACS_INT. Check that fixnums are in proper range for system types.
650 * minibuf.c (minibuf_prompt_width, string_to_object)
651 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
652 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
654 (get_minibuffer, read_minibuf_unwind):
655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
656 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
657 this simplifies overflow checking. All callers changed.
658 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
659 (Ftest_completion):
660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
661 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
662 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
663 Check that fixnums are in proper range for system types.
664 (Fx_create_frame, Fx_show_tip):
665 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
666 * nsfont.m (ns_findfonts, nsfont_list_family):
667 Don't assume fixnum fits in long.
668 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
670 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
671 wide enough.
17fdb222 672 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
674 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
675 (PRINTDECLARE, PRINTPREPARE):
676 (strout, print_string):
677 (print, print_preprocess, print_check_string_charset_prop)
678 (print_object):
679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
680 (PRINTDECLARE):
681 (temp_output_buffer_setup, Fprin1_to_string, print_object):
682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
683 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 684 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 685 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
686 (print_error_message): Use SAFE_ALLOCA, not alloca.
687 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
688 (print_depth, new_backquote_output, print_number_index):
689 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
690 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
691 (Fset_process_window_size, Fformat_network_address)
692 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 693 (sigchld_handler):
d311d28c 694 Check that fixnums are in proper range for system types.
d44287d4 695 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
696 Check for process-ids out of pid_t range rather than relying on
697 undefined behavior.
e4d81efc 698 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
699 (Fformat_network_address, read_process_output, send_process)
700 (Fprocess_send_region, status_notify):
701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
702 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
703 (wait_reading_process_output, read_process_output, exec_sentinel):
704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
705 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
706 (Faccept_process_output): Use duration_to_sec_usec to do proper
707 overflow checking on durations.
dde14581
PE
708 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
709 Don't assume pid_t fits in int.
02481186
PE
710 * process.h (struct Lisp_Process): Members tick and update_tick
711 are now of type EMACS_INT, not int.
b62b53e8
PE
712 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
713 configured --with-wide-int.
d311d28c
PE
714 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
715 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
716 * search.c (looking_at_1, string_match_1):
717 (fast_string_match, fast_c_string_match_ignore_case)
718 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
719 (scan_newline, find_before_next_newline, search_command)
720 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
721 (set_search_regs, wordify):
722 (Freplace_match):
723 (Fmatch_data):
724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
725 (string_match_1, search_buffer, set_search_regs):
726 (Fmatch_data):
727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
728 (wordify): Check for overflow in size calculation.
729 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
730 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
731 Check that fixnums are in proper range for system types.
732 * sound.c (struct sound_device)
733 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
735 (Fplay_sound_internal):
736 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 737 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
738 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
739 (Fparse_partial_sexp):
740 Don't assume fixnums can fit in int.
741 (struct lisp_parse_state, find_start_pos, find_start_value)
742 (find_start_value_byte, find_start_begv)
743 (update_syntax_table, char_quoted, dec_bytepos)
744 (find_defun_start, prev_char_comend_first, back_comment):
745 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
746 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
748 (Finternal_describe_syntax_value): Check that match_lisp is a
749 character, not an integer, since the code stuffs it into int.
750 (scan_words, scan_sexps_forward):
751 Check that fixnums are in proper range for system types.
752 (Fforward_word):
753 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
754 (scan_sexps_forward):
755 Use CHARACTERP, not INTEGERP, since the value must fit into int.
756 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
757 * syntax.h: Adjust decls to match defn changes elsewhere.
758 (struct gl_state_s):
759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
760 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
761 MOST_POSITIVE_FIXNUM.
d311d28c
PE
762 * sysdep.c (wait_for_termination_1, wait_for_termination)
763 (interruptible_wait_for_termination, mkdir):
764 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
765 (emacs_read, emacs_write):
766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
767 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
768 and double all fit in int.
d311d28c
PE
769 * term.c (set_tty_color_mode):
770 Check that fixnums are in proper range for system types.
771 * termhooks.h (struct input_event):
772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
773 * textprop.c (validate_interval_range, interval_of)
774 (Fadd_text_properties, set_text_properties_1)
775 (Fremove_text_properties, Fremove_list_of_text_properties)
776 (Ftext_property_any, Ftext_property_not_all)
777 (copy_text_properties, text_property_list, extend_property_ranges)
778 (verify_interval_modification):
779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
780 (Fnext_single_char_property_change)
781 (Fprevious_single_char_property_change):
782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
783 (copy_text_properties):
784 Check for integer overflow in index calculation.
d311d28c
PE
785 * undo.c (last_boundary_position, record_point, record_insert)
786 (record_delete, record_marker_adjustment, record_change)
787 (record_property_change):
788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
789 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
791 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
792 (Fx_hide_tip, Fx_file_dialog):
793 * w32menu.c (set_frame_menubar):
794 Use ptrdiff_t, not int, for consistency with rest of code.
795 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
796 (select_window, Fdelete_other_windows_internal)
797 (window_scroll_pixel_based, window_scroll_line_based)
798 (Frecenter, Fset_window_configuration):
799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
800 (Fset_window_hscroll, run_window_configuration_change_hook)
801 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 802 (Fscroll_other_window, Frecenter):
d311d28c
PE
803 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
804 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
805 Don't assume fixnum fits in int.
806 (Fset_window_scroll_bars):
807 Check that fixnums are in proper range for system types.
808 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
809 (string_pos, c_string_pos, number_of_chars, init_iterator)
810 (in_ellipses_for_invisible_text_p, init_from_display_pos)
811 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
812 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
813 (face_before_or_after_it_pos, handle_invisible_prop)
814 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
815 (display_prop_intangible_p, string_buffer_position_lim)
816 (string_buffer_position, handle_composition_prop, load_overlay_strings)
817 (get_overlay_strings_1, get_overlay_strings)
818 (iterate_out_of_display_property, forward_to_next_line_start)
819 (back_to_previous_visible_line_start, reseat, reseat_to_string)
820 (get_next_display_element, set_iterator_to_next)
821 (get_visually_first_element, compute_stop_pos_backwards)
822 (handle_stop_backwards, next_element_from_buffer)
823 (move_it_in_display_line_to, move_it_in_display_line)
824 (move_it_to, move_it_vertically_backward, move_it_by_lines)
825 (add_to_log, message_dolog, message_log_check_duplicate)
826 (message2, message2_nolog, message3, message3_nolog
827 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
828 (current_message_1, truncate_echo_area, truncate_message_1)
829 (set_message, set_message_1, store_mode_line_noprop)
830 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
831 (text_outside_line_unchanged_p, check_point_in_composition)
832 (reconsider_clip_changes)
833 (redisplay_internal, set_cursor_from_row, try_scrolling)
834 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
835 (redisplay_window, find_last_unchanged_at_beg_row)
836 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
837 (trailing_whitespace_p, find_row_edges, display_line)
838 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
839 (display_mode_element, store_mode_line_string)
840 (pint2str, pint2hrstr, decode_mode_spec)
841 (display_count_lines, display_string, draw_glyphs)
842 (x_produce_glyphs, x_insert_glyphs)
843 (rows_from_pos_range, mouse_face_from_buffer_pos)
844 (fast_find_string_pos, mouse_face_from_string_pos)
845 (note_mode_line_or_margin_highlight, note_mouse_highlight):
846 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
847 (safe_call, init_from_display_pos, handle_fontified_prop)
848 (handle_single_display_spec, load_overlay_strings)
849 (with_echo_area_buffer, setup_echo_area_for_printing)
850 (display_echo_area, echo_area_display)
851 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
852 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
853 (redisplay_window, dump_glyph_row, display_mode_line)
854 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 855 (handle_display_spec, display_prop_string_p):
d311d28c
PE
856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
857 (handle_single_display_spec, build_desired_tool_bar_string)
858 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
859 (get_specified_cursor_type):
860 Check that fixnums are in proper range for system types.
861 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
862 (Flookup_image_map):
863 Don't assume fixnums fit in int.
864 (compare_overlay_entries):
865 Avoid mishandling comparisons due to subtraction overflow.
866 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
867 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
868 (handle_tool_bar_click):
869 Use int, not unsigned, since we prefer signed and the signedness
870 doesn't matter here.
871 (get_next_display_element, next_element_from_display_vector):
872 Use int, not EMACS_INT, when int is wide enough.
873 (start_hourglass): Use duration_to_sec_usec to do proper
874 overflow checking on durations.
875 * xfaces.c (Fbitmap_spec_p):
876 Check that fixnums are in proper range for system types.
877 (compare_fonts_by_sort_order):
878 Avoid mishandling comparisons due to subtraction overflow.
879 (Fx_family_fonts, realize_basic_faces):
880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
881 (Fx_family_fonts):
882 Don't assume fixnum fits in int.
883 Use SAFE_ALLOCA_LISP, not alloca.
884 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
885 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
886 (face_at_buffer_position, face_for_overlay_string)
887 (face_at_string_position):
888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
889 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
890 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
891 (Fx_show_tip):
892 Check that fixnums are in proper range for system types.
893 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
894 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
896 (Fx_change_window_property): Don't assume fixnums fit in int.
897 * xfont.c (xfont_chars_supported):
898 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
899 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
900 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
902 * xml.c (parse_region):
903 * xrdb.c (magic_file_p):
904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
905 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
906 (x_get_local_selection, x_reply_selection_request)
907 (x_handle_selection_request, wait_for_property_change):
908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
909 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
910 short is wide enough.
911 (x_send_client_event): Don't assume fixnum fits in int.
912 * xterm.c (x_x_to_emacs_modifiers):
913 Don't assume EMACS_INT overflows nicely into int.
914 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
915 may come from Lisp.
916 (handle_one_xevent): NATNUMP can eval its arg twice.
917 (x_connection_closed):
918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
919 * xterm.h: Adjust decls to match defn changes elsewhere.
920 (struct scroll_bar): Use struct vectorlike_header
921 rather than rolling our own approximation.
922 (SCROLL_BAR_VEC_SIZE): Remove; not used.
923
c6574eb5
GM
9242012-05-25 Glenn Morris <rgm@gnu.org>
925
926 * lisp.mk (lisp): Update for more files being compiled now.
927
e8d32c7e
SM
9282012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
929
48def666
SM
930 * lread.c: Remove `read_pure' which makes no difference.
931 (read_pure): Remove var.
932 (unreadpure): Remove function.
933 (readevalloop): Don't call read_list with -1 flag.
934 (read1, read_vector): Don't test read_pure any more.
935 (read_list): Simplify.
936
e8d32c7e
SM
937 * fileio.c, character.h: Minor style tweaks.
938
4b2addb7
DA
9392012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
940
941 * window.h (clip_changed): Remove useless declaration.
942
584461b2
JB
9432012-05-22 Juanma Barranquero <lekktu@gmail.com>
944
945 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
946 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
947
34374650
PE
9482012-05-22 Paul Eggert <eggert@cs.ucla.edu>
949
950 Remove src/m/*.
951 This directory predates autoconf and is no longer needed nowadays.
952 Move its few remaining bits of functionality to where they're needed.
953 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
954 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
955 * m/template.h: Remove.
956 * Makefile.in (M_FILE): Remove. All uses removed.
957 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
958 * lisp.h (USE_LSB_TAG):
959 * mem-limits.h (EXCEEDS_LISP_PTR):
960 Use VAL_MAX, not VALBITS, in #if.
961 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
962 (EMACS_UINT): Define unconditionally now.
963 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
964 (BITS_PER_EMACS_INT): New constants, replacing
965 what used to be in config.h, but not useful in #if.
966 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
967 define them any more.
968 (VAL_MAX): New macro.
969 (VALMASK): Use it.
970 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
971 BITS_PER_EMACS_INT, in #if.
972 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
973 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
974 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
975 * s/ms-w32.h (DATA_START):
976 Move here from removed file m/intel386.h.
977 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
978 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
979
261cb4bb
PE
9802012-05-21 Paul Eggert <eggert@cs.ucla.edu>
981
982 Assume C89 or later.
983 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
984 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
985 (xrealloc):
986 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
987 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
988 * textprop.c, tparam.c (NULL): Remove.
989 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
990 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
991 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
992 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
993 * xterm.c (input_signal_count): Assume volatile works.
994
ff23cd9f
KB
9952012-05-21 Ken Brown <kbrown@cornell.edu>
996
997 * xgselect.c (xg_select): Fix first argument in call to 'select'
998 (bug#11508).
999
1b170bc6
KB
10002012-05-20 Ken Brown <kbrown@cornell.edu>
1001
1002 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1003 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1004
b2f4d39f
KB
10052012-05-19 Ken Brown <kbrown@cornell.edu>
1006
1007 * xfns.c (x_in_use): Remove `static' qualifier.
1008 * xterm.h (x_in_use): Declare.
1009 * xgselect.c: Include xterm.h.
1010 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1011 and `display_arg' (bug#9754).
1012
003fdae2
PE
10132012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1014
9232a6d9
PE
1015 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1016
003fdae2
PE
1017 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1018 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1019
784b56e2
EZ
10202012-05-18 Eli Zaretskii <eliz@gnu.org>
1021
1022 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1023
1024 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1025 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1026
1027 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1028 reference to image_cache->refcount.
1029 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1030
a0a79cde
JL
10312012-05-17 Juri Linkov <juri@jurta.org>
1032
1033 * search.c (Fword_search_regexp, Fword_search_backward)
1034 (Fword_search_forward, Fword_search_backward_lax)
1035 (Fword_search_forward_lax): Move functions to isearch.el
1036 (bug#10145, bug#11381).
1037
b0572523
PE
10382012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1039
1040 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1041
9660f5fc
SM
10422012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1043
1044 * lread.c (init_obarray): Declare Qt and Qnil as special.
1045
4374de83
GM
10462012-05-14 Glenn Morris <rgm@gnu.org>
1047
1048 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1049 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1050
dc44c39a
PE
10512012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1052
078c97cb
PE
1053 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1054
dc44c39a
PE
1055 * unexaix.c: Port to more-recent AIX compilers.
1056 (report_error, report_error_1, make_hdr, copy_sym)
1057 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1058 Make arguments const char *, not char *, to avoid violations of C
1059 standard and to fix some AIX warnings reported by Gilles Pion.
1060
e18afed7 10612012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1062
1063 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1064 already have overlays loaded.
1065 (handle_single_display_spec): Before returning without displaying
1066 fringe bitmap, synchronize the bidi iterator with the main display
1067 iterator, by calling iterate_out_of_display_property.
1068 (iterate_out_of_display_property): Detect buffer iteration by
1069 testing that it->string is a Lisp string.
1070 (get_next_display_element): When the current object is exhausted,
1071 and there's something on it->stack, call set_iterator_to_next to
1072 proceed with what's on the stack, instead of returning zero.
1073 (set_iterator_to_next): If called at the end of a Lisp string,
1074 proceed to consider_string_end without incrementing string
1075 position. Don't increment display vector index past the end of
1076 the display vector. (Bug#11417)
c8fb9dc6
EZ
1077 (pos_visible_p): Don't report a position visible when move_it_to
1078 stopped at the last line of window, which happens to be scanned
1079 backwards by the bidi iteration. (Bug#11464)
ac268e67 1080
e18afed7 10812012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1082
1083 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1084 and right-margin display specs even if the spec is invalid or we
1085 are on a TTY, and thus unable to display on the fringes. That's
1086 because the text with the property will not be displayed anyway,
1087 so we need to signal to the caller that this is a "replacing"
1088 display spec. This fixes display when the spec is invalid or we
1089 are on a TTY.
1090
e18afed7 10912012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1092
1093 * unexaix.c (make_hdr): Fix typo in prototype.
1094 This bug broke the build on AIX. Problem reported by Gilles Pion.
1095
9d0a235a
MA
10962012-05-14 Michael Albinus <michael.albinus@gmx.de>
1097
1098 * keyboard.c (kbd_buffer_get_event): Read special events also in
1099 batch mode. (Bug#11415)
1100
9e6b06ed
GM
11012012-05-12 Glenn Morris <rgm@gnu.org>
1102
1103 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1104
c1a1d7a3
EZ
11052012-05-12 Eli Zaretskii <eliz@gnu.org>
1106
1107 * lisp.mk (lisp): Add newcomment.elc.
1108
3fe7cdc8
GM
11092012-05-12 Glenn Morris <rgm@gnu.org>
1110
1111 * Makefile.in (MKDIR_P): New, set by configure.
1112 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1113
53f7d2c0
PE
11142012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1115
1116 Remove unused function hourglass_started.
1117 * dispextern.h (hourglass_started):
1118 * w32fns.c (hourglass_started):
1119 * xdisp.c (hourglass_started): Remove.
1120
75aafb17
JB
11212012-05-10 Juanma Barranquero <lekktu@gmail.com>
1122
1123 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1124 Update dependencies.
1125
12959e8e
PE
11262012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1127
97107e2e
PE
1128 * xgselect.c (xg_select): Put maxfds+1 into a var.
1129 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1130
12959e8e
PE
1131 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1132
836d29b3
DA
11332012-05-10 Dave Abrahams <dave@boostpro.com>
1134
1135 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1136 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1137
5cb67954
MA
11382012-05-09 Michael Albinus <michael.albinus@gmx.de>
1139
1140 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1141 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1142 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1143 Initialize xd_registered_buses.
1144
3478ec45
PE
11452012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1146
b263a6b0
PE
1147 Untag more efficiently if USE_LSB_TAG.
1148 This is based on a proposal by YAMAMOTO Mitsuharu in
1149 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1150 For an admittedly artificial (nth 8000 longlist) benchmark on
1151 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1152 Emacs's overall text size by 1%.
1153 * lisp.h (XUNTAG): New macro.
1154 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1155 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1156 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1157 * eval.c (Fautoload):
1158 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1159 * frame.h (XFRAME): Use XUNTAG.
1160
3478ec45
PE
1161 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1162 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1163 Remove unportable assumptions about print widths of types like
1164 dbus_uint32_t.
1165 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1166 intptr_t when converting between pointer and integer, to avoid GCC
1167 warnings about wrong width.
1168
666b903b 11692012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1170
1171 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1172 stack for each reader_thread, instead of defaulting to 8MB
1173 determined by the linker. This avoids failures in creating
1174 subprocesses on Windows 7, see the discussion in this thread:
1175 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1176
b120cc17
JC
11772012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1178
1179 Fix up display of the *Minibuf-0* buffer in the mini window.
1180 * keyboard.c (read_char): Don't clear the echo area if there's no
1181 message to clear.
1182 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1183 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1184
9a4b36f8
MA
11852012-05-07 Michael Albinus <michael.albinus@gmx.de>
1186
1187 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1188 batch mode.
1189
e5f9458f
CY
11902012-05-06 Chong Yidong <cyd@gnu.org>
1191
1192 * lisp.mk (lisp): Update.
1193
eceeb5fc 11942012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1195
1196 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1197
71873e2b
SM
11982012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1199
1200 * data.c (PUT_ERROR): New macro.
1201 (syms_of_data): Use it. Add new error type `user-error'.
1202 * undo.c (user_error): New function.
1203 (Fprimitive_undo): Use it.
1204 * print.c (print_error_message): Adjust print style for `user-error'.
1205 * keyboard.c (user_error): New function.
1206 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1207
ab0fa4e4
PE
12082012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1209
1210 Do not limit current-time-string to years 1000..9999.
1211 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1212 (Fcurrent_time_string): Support any year that is supported by the
1213 underlying localtime representation. Don't use asctime, as it
1214 has undefined behavior for years outside the range -999..9999.
1215
7ed806a7
PE
12162012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1217
1218 Fix race conditions involving setenv, gmtime, localtime, asctime.
1219 Without this fix, interrupts could mess up code that uses these
1220 nonreentrant functions, since setting TZ invalidates existing
1221 tm_zone or tzname values, and since most of these functions return
1222 pointers to static storage.
1223 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1224 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1225 Grow the critical sections to include not just invoking
1226 localtime/gmtime, but also accessing these functions' results
1227 including their tm_zone values if any, and any related TZ setting.
1228 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1229 so that the struct tm is saved in the critical section.
1230 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1231 motivated by the fact that memory allocation needs to be outside
1232 the critical section.
1233
0c16dfed
DA
12342012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1235
1236 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1237 with RESET_INTERVAL.
1238
1239 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1240 Remove duplicated buffer name initialization.
1241
3f83ace8
JM
12422012-05-02 Jim Meyering <jim@meyering.net>
1243
1244 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1245
c7b8541e
JM
1246 * xfns.c (x_window): Use xstrdup (Bug#11375).
1247
90207a15 12482012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1249
1250 * xdisp.c (pos_visible_p): If already at a newline from the
1251 display string before the 'while' loop, don't walk back the glyphs
1252 from it3.glyph_row. Solves assertion violation when the display
1253 string begins with a newline (egg.el). (Bug#11367)
1254
b593d6a9
AH
12552012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1256
1257 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1258 Move to simple.el.
1259
4737362e
GM
12602012-05-01 Glenn Morris <rgm@gnu.org>
1261
99cf43f9
GM
1262 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1263 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1264 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1265 All were removed before 23.1.
1266
9311dcff
GM
1267 * dispnew.c: Remove HAVE_LIBNCURSES test;
1268 it is always true on relevant platforms.
1269
4d5c6349
GM
1270 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1271 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1272
4737362e
GM
1273 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1274
74dd3a6b
AS
12752012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1276
1277 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1278 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1279 Remove.
1280
13c379ee
PE
12812012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1282
1283 Do not avoid creating empty evaporating overlays (Bug#9642).
1284 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1285 That is, do not delete an evaporating overlay if it becomes
1286 empty after its bounds are adjusted to fit within its buffer.
1287 This fix caused other problems, and I'm reverting it until we get
1288 to the bottom of them.
1289
a8e7d6d7 12902012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1291
1292 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1293
a8e7d6d7 12942012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1295
1296 * xdisp.c (pos_visible_p): If the window start position is beyond
1297 ZV, start the display from buffer beginning. Prevents assertion
1298 violation in init_iterator when the minibuffer window is scrolled
1299 via the scroll bar.
1300
1301 * window.c (window_scroll_pixel_based): Likewise.
1302
a8e7d6d7 13032012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1304
1305 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1306
a8e7d6d7 13072012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1308
1309 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1310 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1311
a8e7d6d7 13122012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1313
b593d6a9
AH
1314 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1315 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1316
1c6900d9
EZ
13172012-04-26 Eli Zaretskii <eliz@gnu.org>
1318
4c3fa1d9
EZ
1319 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1320 display element, check also the underlying string or buffer
1321 character. (Bug#11341)
1322
1c6900d9
EZ
1323 * w32menu.c: Include w32heap.h.
1324 (add_menu_item): If the call to AppendMenuW (via
1325 unicode_append_menu) fails, disable Unicode menus only if we are
1326 running on Windows 9X/Me.
1327
42bf8205
AS
13282012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1329
1330 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1331 (xgetint): Add missing shift for LSB tags.
1332
b1bac16e
MR
13332012-04-24 Martin Rudalics <rudalics@gmx.at>
1334
1335 * keyboard.c (read_char): Don't wipe echo area for select window
1336 events: These might get delayed via `mouse-autoselect-window'
1337 (Bug#11304).
1338
d69621cc
JB
13392012-04-24 Juanma Barranquero <lekktu@gmail.com>
1340
1341 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1342 manipulation of :loaded-from data.
1343
02fd101b
JB
13442012-04-23 Juanma Barranquero <lekktu@gmail.com>
1345
1346 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1347 now a cons (bug#11311).
1348
888bec30
PE
13492012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1350
89a438bd
PE
1351 Do not create empty overlays with the evaporate property (Bug#9642).
1352 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1353 if it becomes empty after its bounds are adjusted to fit within
1354 its buffer. Without this fix, in a nonempty buffer (let ((o
1355 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1356 yields an empty overlay that has the evaporate property, which is
1357 not supposed to happen.
1358
1068fe4d
PE
1359 Fix minor GTK3 problems found by static checking.
1360 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1361 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1362 (struct _EmacsFixedClass, emacs_fixed_get_type):
1363 Move decls here from emacsgtkfixed.h, since they needn't be public.
1364 (emacs_fixed_get_type): Now static.
1365 (emacs_fixed_class_init): Omit unused local.
1366 (emacs_fixed_child_type): Remove; unused.
1367 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1368 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1369 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1370 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1371 (EMACS_FIXED_GET_CLASS): Remove; unused.
1372 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1373
888bec30
PE
1374 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1375 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1376
de85e130
PE
13772012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1378
d0baac98 1379 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1380 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1381 (__malloc_size_t, __malloc_ptrdiff_t):
1382 Remove. All uses removed, replaced by the definiens if needed,
1383 since we can assume C89 or better now.
1384 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1385 (protect_malloc_state, align, get_contiguous_space)
1386 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1387 (malloc_atfork_handler_child, malloc_enable_thread)
1388 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1389 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1390 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1391 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1392 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1393 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1394 Define using prototypes, not old style.
1395 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1396 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1397 (align): Don't assume that signed integer overflow wraps around.
1398 Omit unused local var.
1399 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1400 (_free_internal_nolock, memalign, mallochook, reallochook):
1401 Omit no-longer-needed casts.
1402 (valloc): Use getpagesize, not __getpagesize.
1403 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1404 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1405
de85e130
PE
1406 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1407
dcbf5805
MA
14082012-04-22 Michael Albinus <michael.albinus@gmx.de>
1409
1410 Move functions from C to Lisp. Make non-blocking method calls
1411 the default. Implement further D-Bus standard interfaces.
1412
1413 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1414 (QCdbus_request_name_allow_replacement)
1415 (QCdbus_request_name_replace_existing)
1416 (QCdbus_request_name_do_not_queue)
1417 (QCdbus_request_name_reply_primary_owner)
1418 (QCdbus_request_name_reply_in_queue)
1419 (QCdbus_request_name_reply_exists)
1420 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1421 (QCdbus_registered_serial, QCdbus_registered_method)
1422 (QCdbus_registered_signal): New Lisp objects.
1423 (XD_DEBUG_MESSAGE): Use sizeof.
1424 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1425 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1426 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1427 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1428 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1429 (xd_signature, xd_append_arg): Allow float for integer types.
1430 (xd_get_connection_references): New function.
b593d6a9
AH
1431 (xd_get_connection_address): Rename from xd_initialize.
1432 Return cached address.
dcbf5805
MA
1433 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1434 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1435 level.
1436 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1437 Return number of refcounts.
dcbf5805
MA
1438 (Fdbus_get_unique_name): Make stronger parameter check.
1439 (Fdbus_message_internal): New defun.
1440 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1441 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1442 (Fdbus_send_signal, Fdbus_register_service)
1443 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1444 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1445 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1446 (Vdbus_compiled_version, Vdbus_runtime_version)
1447 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1448 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1449 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1450 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1451 Adapt docstring.
dcbf5805 1452
52828e02
PE
14532012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1454
da05bc4c
PE
1455 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1456 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1457 Do not assume ptrdiff_t is the same width as 'int'.
1458
52828e02
PE
1459 * alloc.c: Handle unusual debugging option combinations.
1460 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1461 since the two debugging options are incompatible.
1462 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1463 is defined.
1464 (mem_init, mem_insert, mem_insert_fixup):
1465 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1466 (NEED_MEM_INSERT): Remove; no longer needed.
1467
f01769f9
LL
14682012-04-22 Leo Liu <sdl.web@gmail.com>
1469
1470 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1471
5790543d
PE
14722012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1473
1474 * sysdep.c [__FreeBSD__]: Minor cleanups.
1475 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1476 Use Emacs indenting style more consistently. Avoid some casts.
1477 Use 'double' consistently rather than mixing 'float' and 'double'.
1478
b91b7e4d
EW
14792012-04-21 Eduard Wiebe <usenet@pusto.de>
1480
b593d6a9
AH
1481 * sysdep.c (list_system_processes, system_process_attributes):
1482 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1483
6114eb15
AS
14842012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1485
1486 * lisp.mk (lisp): Update.
1487
2f38dff7
PE
14882012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1489
1490 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1491 It is never used otherwise.
1492
4ae29f89
SM
14932012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1494
1495 * print.c (print_preprocess): Only check print_depth if print-circle
1496 is nil.
1497 (print_object): Check for cycles even when print-circle is nil and
1498 print-gensym is t, but only check print_depth if print-circle is nil.
1499
f30d612a
CY
15002012-04-20 Chong Yidong <cyd@gnu.org>
1501
1502 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1503 set the status to "failed" and ensure that sentinel is run.
1504
c07a4c0b 15052012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1506
1507 * process.c (Fset_process_inherit_coding_system_flag)
1508 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1509 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1510
c07a4c0b 15112012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1512
1513 * xdisp.c (string_buffer_position_lim): Limit starting position to
1514 BEGV.
1515 (set_cursor_from_row): If called for a mode-line or header-line
1516 row, return zero immediately.
1517 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1518 farther than the first row after the header line, if any.
1519 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1520 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1521
c07a4c0b 15222012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1523
4ae29f89
SM
1524 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1525 (bug#11238).
ad3a2b41 1526
c07a4c0b 15272012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 15282012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1529
1530 configure: new option --enable-gcc-warnings (Bug#11207)
1531 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1532 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1533 (ALL_CFLAGS): Use new macros rather than old.
1534 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1535 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1536 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1537 -Wunused-result, -Wunused-variable. This should go away once
1538 the Emacs and Gnulib regex code is merged.
1539 (xmalloc, xrealloc): Now static.
1540
aba027e8
PE
15412012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1542
1543 * dired.c (Fsystem_groups): Remove unused local.
1544
e5a36063
GM
15452012-04-17 Glenn Morris <rgm@gnu.org>
1546
1547 * dired.c (Fsystem_users): Doc fix.
1548
316411f0
DA
15492012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1550
1551 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1552 (syms_of_dired): Add them.
1553
9426aba4
PE
15542012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1555
b62a57be
PE
1556 Fix minor alloc.c problems found by static checking.
1557 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1558 New extern decls, to avoid calling undeclared functions.
1559 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1560 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1561 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1562 (NEED_MEM_INSERT): New macro.
1563 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1564 Remove one incorrect comment and fix another.
b62a57be 1565
3539f31f
PE
1566 Fix minor ralloc.c problems found by static checking.
1567 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1568 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1569 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1570 (r_alloc_sbrk): Now static.
1571
a041960a
PE
1572 Improve ralloc.c interface checking.
1573 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1574 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1575 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1576 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1577 [REL_ALLOC]: ... to here, to check interface.
1578 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1579 Remove decls. This fixes an "It stinks!".
1580
9426aba4
PE
1581 * alloc.c (which_symbols): Fix alignment issue / type clash.
1582
d55c12ed
AS
15832012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1584
1585 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1586 (struct Lisp_Misc_Any): Likewise.
1587 (struct Lisp_Free): Likewise.
1588 * alloc.c (union aligned_Lisp_Symbol): Define.
1589 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1590 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1591 (union aligned_Lisp_Misc): Define.
1592 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1593 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1594 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1595
b948ce8b
PE
15962012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1597
1598 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1599 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1600 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1601 * s/netbsd.h, s/sol2-6.h:
1602 Remove definition of GC_MARK_STACK, since the default now works.
1603 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1604 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1605 no longer the default.
1606 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1607
35dc09a1 16082012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1609
35dc09a1
GM
1610 * lread.c (lisp_file_lexically_bound_p):
1611 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1612
35dc09a1
GM
16132012-04-14 Eli Zaretskii <eliz@gnu.org>
1614
1615 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1616 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1617
16182012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1619
1620 * nsterm.m (constrainFrameRect): Always constrain when there is only
1621 one screen (Bug#10962).
1622
bcd86815
KB
16232012-04-13 Ken Brown <kbrown@cornell.edu>
1624
1625 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1626
c25df26e
RT
16272012-04-13 Reuben Thomas <rrt@sc3d.org>
1628
1629 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1630
0fc59f1e
DC
16312012-04-11 Daniel Colascione <dancol@dancol.org>
1632
1633 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1634 against is gone. It's better to use vfork now so that when Cygwin
1635 gains a new, working vfork, we use it automatically (bug#10398).
1636
de8c03dc
SM
16372012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1638
1639 * window.c (save_window_save): Obey window-point-insertion-type.
1640
2f097256
GM
16412012-04-11 Glenn Morris <rgm@gnu.org>
1642
1643 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1644
453b951e
SM
16452012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1646
1647 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1648
75f1671a 16492012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1650
1651 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1652 (force_quit_count): New var.
1653 (handle_interrupt): Use it.
1654
2a8ce227
JB
16552012-04-10 Juanma Barranquero <lekktu@gmail.com>
1656
1657 * w32.c (w32_delayed_load): Record the full path of the library
1658 being loaded (bug#10424).
1659
935396c0
GM
16602012-04-09 Glenn Morris <rgm@gnu.org>
1661
05920a43
GM
1662 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1663 not just in the obarray, before snarfing them. (Bug#11036)
1664
935396c0
GM
1665 * Makefile.in ($(leimdir)/leim-list.el):
1666 Pass EMACS rather than BUILT_EMACS.
1667
a18ecafa
TZ
16682012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1669
1670 * process.c (make_process):
1671 * process.h: Add integer `gnutls_handshakes_tried' member to
1672 process struct.
1673
6bbef4e5
JC
1674 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1675 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1676
1677 * gnutls.c (gnutls_log_function2i): Convenience log function.
1678 (emacs_gnutls_read): Use new log functions,
1679 `gnutls_handshakes_tried' process member, and
1680 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1681 attempts per process (connection).
1682
b4d3bc10
CY
16832012-04-09 Chong Yidong <cyd@gnu.org>
1684
1685 * eval.c (Fuser_variable_p, user_variable_p_eh)
1686 (lisp_indirect_variable): Functions deleted.
1687 (Fdefvar): Caller changed.
1688
1689 * callint.c (Finteractive, Fcall_interactively):
1690 * minibuf.c (Fread_variable): Callers changed.
1691
70f4d973
EZ
16922012-04-09 Eli Zaretskii <eliz@gnu.org>
1693
1694 * xdisp.c (set_cursor_from_row): If the display string appears in
1695 the buffer at position that is closer to point than the position
1696 after the display string, display the cursor on the first glyph of
1697 the display string. Fixes cursor display when a 'display' text
1698 property immediately follows invisible text. (Bug#11094)
1699
cb3c2e3e
PE
17002012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1701
1702 composite.c: use 'double' consistently
1703 * composite.c (get_composition_id): Use 'double' consistently
1704 instead of converting 'float' to 'double' and vice versa; this is
1705 easier to understand and avoids a GCC warning.
1706
fd06db5d
GM
17072012-04-09 Glenn Morris <rgm@gnu.org>
1708
50fe702a
GM
1709 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1710 preparation for dumping it with emacs. (Bug#4789)
1711 (leimdir): New variable.
1712 ($(leimdir)/leim-list.el): New rule.
1713 (emacs$(EXEEXT)): Depend on leim-list.el.
1714
fd06db5d
GM
1715 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1716 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1717 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1718
55c131ee
AS
17192012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1720
1721 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1722 proper alignment.
1723
9209588f
JB
17242012-04-07 Juanma Barranquero <lekktu@gmail.com>
1725
1726 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1727 Remove unused local variable.
1728
e3fb2efb
PE
17292012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1730
1731 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1732 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1733 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1734 objects, as mark_maybe_pointer will catch them otherwise.
1735 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1736 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1737
b5385551
PE
17382012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1739
1740 Fix typo that broke non-Windows builds.
1741 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1742
9078ead6
EZ
17432012-04-07 Eli Zaretskii <eliz@gnu.org>
1744
1745 Support building on MS-Windows with libxml2.
1746
1747 * makefile.w32-in (OBJ2): Add xml.$(O).
1748 (GLOBAL_SOURCES): Add xml.c.
1749 ($(BLD)/xml.$(O)): New dependency list.
1750
1751 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1752 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1753 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1754 [!WINDOWSNT]: New macros.
1755 (init_libxml2_functions, libxml2_loaded_p): New functions.
1756 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1757 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1758 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1759 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1760 linked in).
6bbef4e5
JC
1761 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1762 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
1763 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1764
1765 * emacs.c: Don't include libxml/parser.h.
1766 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1767 xmlCleanupParser directly.
1768
1769 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1770
3811fdf3
EZ
17712012-04-07 Eli Zaretskii <eliz@gnu.org>
1772
1773 * indent.c (Fvertical_motion): If there is a display string at
1774 point, use it.vpos to compute how many lines to backtrack after
1775 move_it_to point. (Bug#11133)
1776
2f8e16b2
EZ
17772012-04-06 Eli Zaretskii <eliz@gnu.org>
1778
1779 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1780 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1781 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1782 macros related to unification of CJK characters. For the details,
1783 see the discussion following the message here:
1784 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1785
3d439cd1
CY
17862012-04-04 Chong Yidong <cyd@gnu.org>
1787
1788 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1789
8bc53d00
EZ
17902012-04-01 Eli Zaretskii <eliz@gnu.org>
1791
1792 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1793 instead of alloca. (Bug#11138)
1794
3b0512a3
AS
17952012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1796
1797 * w32menu.c (is_simple_dialog): Properly check lisp types.
1798 (Bug#11141)
1799
8427ddd2
EZ
18002012-03-31 Eli Zaretskii <eliz@gnu.org>
1801
979022ef
EZ
1802 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1803 position we get to after a call to move_it_to fails the
1804 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1805 only if we wind up in a string from display property. (Bug#11063)
1806
a6b1c7cc
EZ
1807 * window.c (Fdelete_other_windows_internal): Invalidate the row
1808 and column information about mouse highlight, so that redisplay
1809 restores it after reallocating the glyph matrices. (Bug#7464)
1810
8427ddd2
EZ
1811 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1812 string comes from a `display' text property, use the buffer
1813 position of that property as if we actually saw that position in
1814 the row's glyphs.
697ba24b
EZ
1815 (move_it_by_lines): Remove the assertion that
1816 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1817 violated when there's a before-string at the beginning of a line.
1818 (Bug#11063)
8427ddd2 1819
65a0a738
EZ
18202012-03-30 Eli Zaretskii <eliz@gnu.org>
1821
1822 * xdisp.c (append_space_for_newline): If the default face was
1823 remapped, use the remapped face for the appended newline.
1824 (extend_face_to_end_of_line): Use the remapped default face for
1825 extending the face to the end of the line.
1826 (display_line): Call extend_face_to_end_of_line when the default
1827 face was remapped. (Bug#11068)
1828
581355cc
EZ
18292012-03-29 Eli Zaretskii <eliz@gnu.org>
1830
1831 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1832
e8fc049f
SM
18332012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1834
1835 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1836
4fb9a543
GM
18372012-03-27 Glenn Morris <rgm@gnu.org>
1838
1839 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1840 Doc fixes.
1841
679910f1
KH
18422012-03-26 Kenichi Handa <handa@m17n.org>
1843
1844 * dispextern.h (struct glyph): Fix previous change. Change the
1845 bit length of glyphless.ch to 25 (Bug#11082).
1846
90d49b7f
CY
18472012-03-26 Chong Yidong <cyd@gnu.org>
1848
1849 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1850 (command_loop_1): Use it; inhibit selection update for
1851 handle-select-window too (Bug#8996).
1852
f514f6f0
FP
18532012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1854
e8fc049f 1855 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 1856
bf43fa51
KH
18572012-03-25 Kenichi Handa <handa@m17n.org>
1858
1859 * dispextern.h (struct glyph): Change the bit length of
1860 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1861
8a0c01dd
EZ
18622012-03-24 Eli Zaretskii <eliz@gnu.org>
1863
1864 * s/ms-w32.h (tzname): Include time.h before redirecting to
1865 _tzname. Fixes the MSVC build. (Bug#9960)
1866
7d1c3a76
AS
18672012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1868
8ed79523
AS
1869 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1870 characters.
1871
7d1c3a76
AS
1872 * xterm.c (XTread_socket): Only modify handling_signal if
1873 !SYNC_INPUT. (Bug#11080)
1874
e99a9b8b
EZ
18752012-03-23 Eli Zaretskii <eliz@gnu.org>
1876
1877 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1878 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1879 when fetching a multibyte character consumes more bytes than
1880 CHAR_BYTES returns, due to unification of CJK characters in
1881 string_char. (Bug#11073)
1882
5063c0e1
TN
18832012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1884
1885 * process.c (wait_reading_process_output): Handle pty disconnect
1886 by refraining from sending oneself a SIGCHLD (bug#10933).
1887
9f851fbd
CY
18882012-03-22 Chong Yidong <cyd@gnu.org>
1889
1890 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1891
5063c0e1 1892 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
1893 Mark string as coming from a prefix property.
1894 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1895 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1896
fb5b8aca
CY
18972012-03-21 Chong Yidong <cyd@gnu.org>
1898
1899 * xfaces.c (Vface_remapping_alist): Doc fix.
1900
62356a1b
EZ
19012012-03-20 Eli Zaretskii <eliz@gnu.org>
1902
1903 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
1904 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1905 Doc fixes.
62356a1b 1906
025de85b
CY
19072012-03-20 Chong Yidong <cyd@gnu.org>
1908
1909 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1910 to reflect default non-nil value of redisplay-dont-pause.
1911
4827f94e
KH
19122012-03-19 Kenichi Handa <handa@m17n.org>
1913
1914 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1915 it fit in a valid range (Bug#11003).
1916
e50a24a2
EZ
19172012-03-18 Eli Zaretskii <eliz@gnu.org>
1918
1919 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1920 that is not from display property, accept the row as a "cursor
1921 row" if one of the string's character has a non-nil `cursor'
1922 property. Fixes cursor positioning when there are newlines in
1923 overlay strings, e.g. in icomplete.el. (Bug#11035)
1924
9af5ed87
PE
19252012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1928
d1f55f16
CY
19292012-03-12 Chong Yidong <cyd@gnu.org>
1930
1931 * eval.c (inhibit_lisp_code): Rename from
1932 inhibit_window_configuration_change_hook; move from window.c.
1933
1934 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1935 * window.c (run_window_configuration_change_hook)
1936 (syms_of_window): Callers changed.
1937
66c5eebd
CY
19382012-03-11 Chong Yidong <cyd@gnu.org>
1939
413df973
CY
1940 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1941
66c5eebd
CY
1942 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1943
1de11f56
CY
19442012-03-10 Chong Yidong <cyd@gnu.org>
1945
1946 * frame.c (other_visible_frames): Don't assume the selected frame
1947 is visible (Bug#10955).
1948
cae07000
SM
19492012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1950
1951 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1952
89c94350
JD
19532012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1954
1955 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1956 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1957 zero (Bug#10954).
1958
999dd333
GM
19592012-03-03 Glenn Morris <rgm@gnu.org>
1960
01a6dcc8 1961 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 1962
de0100f2
EZ
19632012-03-02 Eli Zaretskii <eliz@gnu.org>
1964
1965 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1966 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
1967 (redisplay_window, next_element_from_string): Fix typos in
1968 comments.
3e441275
EZ
1969 (redisplay_window): Pass to move_it_vertically the margin in
1970 pixels, not in screen lines.
de0100f2 1971
96a72ee9
GM
19722012-03-02 Glenn Morris <rgm@gnu.org>
1973
1974 * buffer.c (buffer-list-update-hook): Doc fix.
1975
312508d7
EZ
19762012-02-29 Eli Zaretskii <eliz@gnu.org>
1977
1978 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1979 push_it before setting up the iterator for the first overlay
1980 string, even if we have an empty string loaded.
1981 (next_overlay_string): If there's an empty string on the iterator
1982 stack, pop the stack. (Bug#10903)
1983
27f3c637
PE
19842012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1987 Suggested by Stefan Monnier in
1988 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1989 * alloc.c (widen_to_Lisp_Object): New static function.
1990 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1991 and widening them to Lisp_Objects. This would work even if
1992 USE_LSB_TAG is defined and wide integers are used, which might
1993 happen in a future version of Emacs.
1994
3c9dfce6
CY
19952012-02-25 Chong Yidong <cyd@gnu.org>
1996
fa74b241
CY
1997 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1998 Doc fix.
1999
3c9dfce6
CY
2000 * xselect.c (Fx_selection_exists_p): Doc fix.
2001 (x_clipboard_manager_save_all): Print an informative message
2002 before saving to clipboard manager.
2003
9486df08
CY
20042012-02-24 Chong Yidong <cyd@gnu.org>
2005
2006 * keyboard.c (process_special_events): Handle all X selection
2007 requests in kbd_buffer, not just the next one (Bug#8869).
2008
f01d3321
CY
20092012-02-23 Chong Yidong <cyd@gnu.org>
2010
2011 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2012 call when setting menu-bar-lines and tool-bar-lines parameters.
2013 (unwind_create_frame_1): New helper function.
2014
2015 * window.c (inhibit_window_configuration_change_hook): New var.
2016 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2017 (syms_of_window): Initialize it.
f01d3321 2018
86b847b6
CY
20192012-02-22 Chong Yidong <cyd@gnu.org>
2020
2021 * xterm.c (x_draw_image_relief): Add missing type check for
2022 Vtool_bar_button_margin (Bug#10743).
2023
a59225b1
CY
20242012-02-21 Chong Yidong <cyd@gnu.org>
2025
2026 * fileio.c (Vfile_name_handler_alist): Doc fix.
2027
2028 * buffer.c (Fget_file_buffer): Protect against invalid file
2029 handler return value.
2030
310f5bd4
PE
20312012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2032
cb3a28cc
PE
2033 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2034 when computing $valmask.
2035
310f5bd4
PE
2036 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2037 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2038 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2039 It's useless in that case, and it can cause problems on hosts
2040 that allocate halves of EMACS_INT values separately.
2041 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2042 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2043 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2044 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2045 it avoids undefined behavior on hosts where shifting right by more
2046 than the word width has undefined behavior.
2047
2375c96a
CY
20482012-02-19 Chong Yidong <cyd@gnu.org>
2049
2050 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2051 (Funhandled_file_name_directory, Ffile_name_as_directory)
2052 (Fdirectory_file_name, Fexpand_file_name)
2053 (Fsubstitute_in_file_name): Protect against invalid file handler
2054 return values (Bug#10845).
2055
3eb49e71
EZ
20562012-02-18 Eli Zaretskii <eliz@gnu.org>
2057
2058 * .gdbinit (pitx): Fix incorrect references to fields of the
2059 iterator stack.
2060
7b926f3f
CY
20612012-02-17 Chong Yidong <cyd@gnu.org>
2062
2063 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2064
11273115
PE
20652012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2066
2067 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2068 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2069
c3a70e2b
CY
20702012-02-15 Chong Yidong <cyd@gnu.org>
2071
2072 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2073 marked as special. Also, starting docstrings with * is obsolete.
2074
0ca43699
AS
20752012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2076
2077 * gnutls.c (emacs_gnutls_write): Fix last change.
2078
2e8f3c56
LI
20792012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2080
2081 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2082 send_process.
2083
af70074f
SM
20842012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2085
2086 * keymap.c (Fsingle_key_description): Handle char ranges.
2087
95986d52
CY
20882012-02-12 Chong Yidong <cyd@gnu.org>
2089
afd83bd1
CY
2090 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2091 as that creates a dangerous corner case.
2092
95986d52
CY
2093 * window.c (Fdelete_window_internal): Invalidate the mouse
2094 highlight (Bug#9904).
2095
bd7da63e
GM
20962012-02-12 Glenn Morris <rgm@gnu.org>
2097
2098 * xselect.c (Fx_own_selection_internal)
2099 (Fx_get_selection_internal, Fx_disown_selection_internal)
2100 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2101 * nsselect.m (Fx_own_selection_internal)
2102 (Fx_disown_selection_internal, Fx_selection_exists_p)
2103 (Fx_selection_owner_p, Fx_get_selection_internal):
2104 Sync docs and argument specs with the xselect.c versions.
2105
77abcbc2
LI
21062012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2107
2108 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2109
90b671e2
EZ
21102012-02-11 Eli Zaretskii <eliz@gnu.org>
2111
1c0ca0b7
EZ
2112 * w32select.c (Fx_selection_exists_p): Sync doc string and
2113 argument list with xselect.c. (Bug#10783)
2114
2115 * w16select.c (Fx_selection_exists_p): Sync doc string and
2116 argument list with xselect.c. (Bug#10783)
90b671e2 2117
49241268
GM
21182012-02-10 Glenn Morris <rgm@gnu.org>
2119
2120 * fns.c (Fsecure_hash): Doc fix.
2121
f998bbe7 21222012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2123
2124 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2125
0992bd9c
CY
21262012-02-07 Chong Yidong <cyd@gnu.org>
2127
2128 * buffer.c (Fbuffer_local_variables)
2129 (buffer_lisp_local_variables): Handle unbound vars correctly;
2130 don't let Qunbound leak into Lisp.
2131
af008560
GM
21322012-02-07 Glenn Morris <rgm@gnu.org>
2133
dd605cc4
GM
2134 * image.c (Fimagemagick_types): Doc fix.
2135
af008560
GM
2136 * image.c (imagemagick-render-type): Change it from a lisp object
2137 to an integer. Move the doc here from the lisp manual.
2138 Treat all values not equal to 0 the same.
2139
1449fa1d
CY
21402012-02-06 Chong Yidong <cyd@gnu.org>
2141
2142 * doc.c (store_function_docstring): Avoid applying docstring of
2143 alias to base function (Bug#2603).
2144
3723ec07
AS
21452012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2146
2147 * .gdbinit (pp1, pv1): Remove redundant defines.
2148 (pr): Use pp.
2149
79c1cc1e
CY
21502012-02-04 Chong Yidong <cyd@gnu.org>
2151
2152 * nsterm.m: Declare a global (Bug#10694).
2153
d7f29f8e
EZ
21542012-02-04 Eli Zaretskii <eliz@gnu.org>
2155
cae07000
SM
2156 * w32.c (get_emacs_configuration_options):
2157 Include --enable-checking, if specified, in the return value.
d7f29f8e 2158
3b95a6f9
MR
21592012-02-04 Martin Rudalics <rudalics@gmx.at>
2160
2161 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2162 after rounding frame sizes. (Bug#9723)
2163
d6fa96a6
EZ
21642012-02-04 Eli Zaretskii <eliz@gnu.org>
2165
2166 * keyboard.c (adjust_point_for_property): Don't position point
2167 before BEGV. (Bug#10696)
2168
df0b2940
PE
21692012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2170
2171 Handle overflow when computing char display width (Bug#9496).
2172 * character.c (char_width): Return EMACS_INT, not int.
2173 (char_width, c_string_width): Check for overflow when
2174 computing the width; this is possible now that individual
2175 characters can have unbounded width. Problem introduced
2176 by merge from Emacs 23 on 2012-01-19.
2177
6bee44d6
MA
21782012-02-02 Michael Albinus <michael.albinus@gmx.de>
2179
2180 * dbusbind.c (Fdbus_register_method): Mention the return value
2181 :ignore in the docstring.
2182
44f92739
GM
21832012-02-02 Glenn Morris <rgm@gnu.org>
2184
1b9f60cc
GM
2185 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2186
44f92739
GM
2187 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2188 Unconditionally set to t. (Bug#10673)
2189 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2190 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2191 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2192
c5d3843c
KH
21932012-02-02 Kenichi Handa <handa@m17n.org>
2194
2195 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2196 0, do not call append_composite_glyph.
2197
159462d4 21982012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2199
2200 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2201 NULL (Bug#6988).
2202 (x_produce_glyphs): If the component of a composition is a null
2203 string, set it->pixel_width to 1 to avoid zero-width glyph.
2204
78cef877
EZ
22052012-02-01 Eli Zaretskii <eliz@gnu.org>
2206
2207 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2208 first 2 arguments are identical. This makes inserting large
2209 output from a subprocess an order of magnitude faster on
2210 MS-Windows, where all sbrk'ed memory is always contiguous.
2211
97897668
GM
22122012-01-31 Glenn Morris <rgm@gnu.org>
2213
2214 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2215 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2216 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2217
31fd3586
GM
22182012-01-29 Glenn Morris <rgm@gnu.org>
2219
2220 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2221
0e24a8b2
CY
22222012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2223
2224 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2225
cc0adcb0
CY
22262012-01-28 Chong Yidong <cyd@gnu.org>
2227
2228 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2229
acc28cb9
CY
22302012-01-26 Chong Yidong <cyd@gnu.org>
2231
9c69cfb7
CY
2232 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2233
acc28cb9
CY
2234 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2235 repeat counts (Bug#10507).
2236
48da7392
GM
22372012-01-26 Glenn Morris <rgm@gnu.org>
2238
2239 * lread.c (syms_of_lread): Doc fix.
2240
14af5f7f
CY
22412012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2242
2243 * coding.c (encode_designation_at_bol): Change return value to
2244 EMACS_INT.
2245
0b21c100
CY
22462012-01-25 Chong Yidong <cyd@gnu.org>
2247
2248 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2249
3c2907f7
CY
22502012-01-21 Chong Yidong <cyd@gnu.org>
2251
2252 * floatfns.c (Fcopysign): Make the second argument non-optional,
2253 since nil is not allowed anyway.
2254
959ad23f
AS
22552012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2256
2257 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2258 (send_process): Likewise.
2259
34a02f46
MR
22602012-01-19 Martin Rudalics <rudalics@gmx.at>
2261
2262 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2263 (Vwindow_persistent_parameters): Do not use Qstate.
2264 Rewrite doc-strings.
34a02f46 2265
1259009a 22662012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2267
2268 * character.c (char_width): New function.
70d4fdf6
GM
2269 (Fchar_width, c_string_width, lisp_string_width):
2270 Use char_width (Bug#9496).
25ed9e61 2271
6a6ee00d
MR
22722012-01-16 Martin Rudalics <rudalics@gmx.at>
2273
2274 * window.c (Vwindow_persistent_parameters): New variable.
2275 (Fset_window_configuration, save_window_save): Handle persistent
2276 window parameters.
2277
c85efaf7
EZ
22782012-01-14 Eli Zaretskii <eliz@gnu.org>
2279
2280 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2281 thrashing the stack of the thread. (Bug#9087)
2282
5944709e
PE
22832012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2284
2285 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2286
e71f5d99
EZ
22872012-01-11 Eli Zaretskii <eliz@gnu.org>
2288
2289 * xdisp.c (rows_from_pos_range): Handle the case where the
2290 highlight ends on a newline. (Bug#10464)
2291 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2292 he end column for display of highlight that ends on a newline
2293 before a R2L line.
2294
ce316182
GM
22952012-01-11 Glenn Morris <rgm@gnu.org>
2296
2297 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2298 from load-path also when installation-directory is nil. (Bug#10208)
2299
5b43da69
GM
23002012-01-10 Glenn Morris <rgm@gnu.org>
2301
74cc8ff9
GM
2302 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2303
7d8d6e4e
GM
2304 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2305 Update template values to be closer to their typical values these days.
5b43da69 2306
a0db8d43
EZ
23072012-01-09 Eli Zaretskii <eliz@gnu.org>
2308
2309 * xdisp.c (rows_from_pos_range): Accept additional argument
2310 DISP_STRING, and accept any glyph in a row whose object is that
2311 string as eligible for mouse highlight. Fixes mouse highlight of
2312 display strings from overlays. (Bug#10464)
2313
9a0115ab 23142012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2315
b9110d6a 2316 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2317 * fileio.c (auto_saving_dir_umask): New static var.
2318 (Fmake_directory_internal): Use it.
2319 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2320 creating the directory. The old code temporarily assigns
2321 too-generous permissions to the directory.
2322 (do_auto_save_eh): Clear it.
b9110d6a 2323 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2324 that the var is always cleared.
2325
6c1bd3f3
EZ
23262012-01-07 Eli Zaretskii <eliz@gnu.org>
2327
2328 * search.c (scan_buffer): Pass character positions to
2329 know_region_cache, not byte positions. (Bug#6540)
2330
069d2b50
L
23312012-01-07 LynX <_LynX@bk.ru> (tiny change)
2332
2333 * w32.c (sys_rename): Report EXDEV when rename of a directory
2334 fails because the target is on another logical disk. (Bug#10284)
2335
75bf0d33
DB
23362012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2337
2338 * xterm.c (x_embed_request_focus): New function.
2339
2340 * xterm.h: Add prototype.
2341
2342 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2343
1c6e5a32
GM
23442012-01-05 Glenn Morris <rgm@gnu.org>
2345
2346 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2347
651e947e
EZ
23482012-01-01 Eli Zaretskii <eliz@gnu.org>
2349
2350 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2351 Load gnutls_transport_set_lowat only if GnuTLS version is below
2352 2.11.1.
2353 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2354 GnuTLS versions below 2.11.1.
2355
3778cdd8
AL
23562011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2357
2358 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2359 to the doc string advising against its use for altering the way
2360 windows are scrolled.
2361
0e5317f7
KH
23622011-12-28 Kenichi Handa <handa@m17n.org>
2363
2364 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2365 coding-system ASCII compatible only when it does not produce BOM
2366 on encoding (Bug#10383).
2367
93d5ca1f
JD
23682011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2369
2370 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2371 can scroll.
2372 (create_and_show_popup_menu): Always use menu_position_func for
2373 Gtk3 (Bug#10361).
2374
ca22b785
AS
23752011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2376
2377 * callint.c (Fcall_interactively): Don't truncate prompt string.
2378
d048e1e6
EZ
23792011-12-23 Eli Zaretskii <eliz@gnu.org>
2380
2381 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2382 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2383 resumed from there (after widening). (Bug#10360)
d048e1e6 2384
5ccaba1f
JD
23852011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2386
2387 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2388
204ee57f
JD
23892011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2390
b81d40f0
JB
2391 * nsterm.m (x_free_frame_resources):
2392 Release f->output_data.ns->miniimage.
204ee57f
JD
2393 (ns_index_color): Fix indentation. Do not retain
2394 color_table->colors[i].
2395
2396 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2397 before returning.
2398
2399 * nsfns.m (x_set_background_color): Assign return value from
2400 ns_index_color to face-background instead of NSColor*.
2401 (ns_implicitly_set_icon_type): Fix indentation.
2402 Change assignment in for loop to comparison.
2403
2404 * emacs.c (ns_pool): New variable.
2405 (main): Assign ns_pool.
2406 (Fkill_emacs): Call ns_release_autorelease_pool.
2407
2408 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2409 autorelease fdesc, release fdAttrs and tdict.
2410 (ns_get_covering_families): Release charset.
2411 (ns_findfonts): Release NSFontDescriptor created with new.
2412 (ns_uni_to_glyphs): Fix indentation.
2413 (setString): Release attrStr before assigning new value.
2414
c803b2b7
JD
24152011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2416
678f4426
JD
2417 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2418 and NS_IMPL_COCOA.
2419 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2420 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2421
cd394be1 24222011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2423
5fecd5fc
JD
2424 * nsterm.m (ns_term_init): Subscribe for notifications
2425 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2426 to method trackingNotification in EmacsMenu.
2427
2428 * nsmenu.m (trackingMenu): New variable.
3771cb17 2429 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2430 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2431 from Aquamacs (Bug#7030).
678f4426
JD
2432
24332011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2434
c803b2b7
JD
2435 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2436 (symbol_to_nsstring): Fix indentation.
2437 (ns_symbol_to_pb): New function.
cae07000
SM
2438 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2439 (Fns_rotate_cut_buffers_internal): Remove.
2440 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2441 Fns_store_cut_buffer_internal.
2442 (ns_get_foreign_selection, Fx_own_selection_internal)
2443 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2444 (Fns_get_selection_internal, Fns_store_selection_internal):
2445 Use ns_symbol_to_pb and check if return value is nil.
2446 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2447 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2448 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2449 renamed to Sns_store_selection_internal.
2450 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2451 and remove this function.
2452 (ns_handle_selection_clear): Remove, never used.
2453 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2454 here.
2455
e1b01a3a
KB
24562011-12-17 Ken Brown <kbrown@cornell.edu>
2457
2458 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2459 GID is unknown (Bug#10257).
2460
2adb6e85
PE
24612011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2462
2463 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2464 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2465 which caused a build failure on GNU/Linux IA-64. This problem was
2466 introduced by my 2011-10-07 patch.
2467
d1d7b339
JL
24682011-12-15 Juri Linkov <juri@jurta.org>
2469
2470 * image.c (imagemagick_error): New function. (Bug#10112)
2471 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2472 Use `imagemagick_error' where ImageMagick functions return
2473 `MagickFalse'.
2474 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2475 proper order.
2476
100d5755
KH
24772011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2478
2479 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2480 fill background (Bug#8992).
2481
454592a6
MR
24822011-12-13 Martin Rudalics <rudalics@gmx.at>
2483
2484 * window.c (Vwindow_combination_resize)
2485 (Vwindow_combination_limit): Use t instead of non-nil in
2486 doc-strings.
61d4b438
MR
2487 (Vrecenter_redisplay): Add first sentence of doc-string on
2488 separate line.
53524d93 2489 (Frecenter): Fix doc-string typo.
454592a6 2490
3633e3aa
KH
24912011-12-11 Kenichi Handa <handa@m17n.org>
2492
2493 * coding.c (Funencodable_char_position): Pay attention to the
2494 buffer text relocation (Bug#9389).
2495
7b9d523a 24962011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2497
7b9d523a
JD
2498 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2499 gtk_init (Bug#10100).
2500
b73189c6
EZ
25012011-12-10 Eli Zaretskii <eliz@gnu.org>
2502
2503 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2504 IT->string is nil. (Bug#10263)
2505
f7dfe5d6
JD
25062011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2507
83faebb4
JD
2508 * nsterm.h (x_free_frame_resources): Declare.
2509
f7dfe5d6
JD
2510 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2511 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2512
2513 * nsterm.h (ns_get_defaults_value): Declare.
2514
2515 * nsterm.m (ns_default): Call ns_get_defaults_value.
2516
7cd4e72c
EZ
25172011-12-09 Eli Zaretskii <eliz@gnu.org>
2518
2519 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2520 (Bug#10170)
2521
b34d7317
YM
25222011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2523
2524 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2525 that where the value of an _OBJC_* symbol points to is in the .bss
2526 section (Bug#10240).
2527
76470ad1
KH
25282011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2529
2530 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2531 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2532
745fff94
KH
25332011-12-08 Kenichi Handa <handa@m17n.org>
2534
2535 * ftfont.c (get_adstyle_property): Fix previous change
2536 (Bug#10233).
2537
6e44397c
JB
25382011-12-07 Juanma Barranquero <lekktu@gmail.com>
2539
2540 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2541 dirs from the default value of EMACSLOADPATH (bug#10208).
2542
7efa6272
GM
25432011-12-07 Glenn Morris <rgm@gnu.org>
2544
2545 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2546 installation and source directories as well. (Bug#10208)
2547
f6fc4d87
CY
25482011-12-06 Chong Yidong <cyd@gnu.org>
2549
2550 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2551
2bf26180
GM
25522011-12-06 Glenn Morris <rgm@gnu.org>
2553
2554 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2555 as an error, not just -1. (Bug#10217)
2556
3a6ad4f0
CY
25572011-12-05 Chong Yidong <cyd@gnu.org>
2558
2559 * keyboard.c (process_special_events): New function.
2560 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2561
75a3b399
PE
25622011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 * coding.c (encode_designation_at_bol): Don't use uninitialized
2565 local variable (Bug#9318).
2566
c3c9e25e
KH
25672011-12-05 Kenichi Handa <handa@m17n.org>
2568
2569 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2570 return Qnil (Bug#8046, Bug#10193).
2571
5eb05ea3
KH
25722011-12-05 Kenichi Handa <handa@m17n.org>
2573
2574 * coding.c (encode_designation_at_bol): New args charbuf_end and
2575 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2576 (coding_set_source): Return how many bytes coding->source was
2577 relocated.
2578 (coding_set_destination): Return how many bytes
2579 coding->destination was relocated.
2580 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2581 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2582
25832011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2584
2585 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2586 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2587 macro (Bug#9318).
2588
25892011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2590
2591 The following changes are to fix Bug#9318.
2592
a79703f5 2593 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2594 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2595 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2596 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2597
7dbda6df
JB
25982011-12-05 Juanma Barranquero <lekktu@gmail.com>
2599
2600 * lisp.h (process_quit_flag): Fix external declaration.
2601
6d5eb5b0
SM
26022011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2603
2604 Don't macro-inline non-performance-critical code.
2605 * eval.c (process_quit_flag): New function.
2606 * lisp.h (QUIT): Use it.
2607
a0c3fad0
JD
26082011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2609
2610 * nsfns.m (get_geometry_from_preferences): New function.
2611 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2612
6c07aac2
AS
26132011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2614
2615 * emacs.c (Qkill_emacs): Define.
2616 (syms_of_emacs): Initialize it.
2617 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2618 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2619 (quit_throw_to_read_char): Add parameter `from_signal'.
2620 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2621 * lisp.h (QUIT): Call Fkill_emacs if requested.
2622
c052ead4
JD
26232011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2624
2625 * widget.c (update_wm_hints): Return if wmshell is null.
2626 (widget_update_wm_size_hints): New function.
2627
2628 * widget.h (widget_update_wm_size_hints): Declare.
2629
2630 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2631 widget_update_wm_size_hints (Bug#10104).
2632
9e49252b
EZ
26332011-12-03 Eli Zaretskii <eliz@gnu.org>
2634
2635 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2636 before a newline, prepare the bidi iterator for consuming the
2637 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2638 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2639
02b16839
JL
26402011-12-02 Juri Linkov <juri@jurta.org>
2641
2642 * search.c (Fword_search_regexp): New Lisp function created from
2643 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2644 (Fword_search_backward, Fword_search_forward)
2645 (Fword_search_backward_lax, Fword_search_forward_lax):
2646 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2647 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2648
0068070e
SM
26492011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2650
2651 * fileio.c (Finsert_file_contents): Move after-change-function call
2652 to before the "handled:" label, since all "goto handled" appear in
2653 cases where the *-change-functions have already been properly called
2654 (bug#10117).
2655
3360a3fc
AS
26562011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2657
2658 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2659 waiting for input. (Bug#10169)
2660
73d6c093
EZ
26612011-11-30 Eli Zaretskii <eliz@gnu.org>
2662
2663 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2664 verifies glyph row's hash code--we have just reallocated the
2665 glyphs, so their contents can be complete garbage. (Bug#10164)
2666
febe6bea
JB
26672011-11-30 Juanma Barranquero <lekktu@gmail.com>
2668
2669 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2670
801a4313
EZ
26712011-11-30 Eli Zaretskii <eliz@gnu.org>
2672
2673 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2674 attributes are tested _before_ calling verify_row_hash, to protect
2675 against GCC re-ordering of the tests. (Bug#10164)
2676
2b56b87e
JD
26772011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2678
2679 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2680
2681 * xterm.c (handle_one_xevent): Only set async_visible and friends
2682 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2683 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2684 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2685
dbf31225
PE
26862011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2687
2688 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2689 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2690 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2691 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2692 All uses changed to use GCPRO1 etc.
2693 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2694 Revert to old implementation (i.e., before 2011-03-11).
2695
1305621b
YM
26962011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2697
2698 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2699 of scroll runs so as to avoid assigning disabled bogus rows and
2700 unnecessary graphics copy operations.
2701
8c9afb46
EZ
27022011-11-27 Eli Zaretskii <eliz@gnu.org>
2703
2704 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2705 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2706 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2707 (malloc, free, realloc, calloc): Redirect to e_* only when
2708 compiling Emacs.
2709
2710 * lisp.h (GCTYPEBITS): Move before first use.
2711 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2712 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2713 this macro definition.
2714
2715 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2716 _MSC_VER.
2717
54e9e3bf
JD
27182011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2719
6d5eb5b0
SM
2720 * gtkutil.c (xg_create_frame_widgets):
2721 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2722 present with Gtk+ 2.0.
2723
83aca1cb
PE
27242011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2725
2726 * fileio.c (Finsert_file_contents): Undo previous change; see
2727 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2728
5b76caa4
PE
27292011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2730
2731 Rename locals to avoid shadowing.
2732 * fileio.c (Finsert_file_contents):
2733 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2734 * process.c (wait_reading_process_output):
2735 Rename inner 'proc' to 'p' to avoid shadowing.
2736 Indent for consistency with usual Emacs style.
2737
8c535114
EZ
27382011-11-25 Eli Zaretskii <eliz@gnu.org>
2739
2740 * xdisp.c (redisplay_window): If cursor row is not fully visible
2741 after recentering, and scroll-conservatively is set to a large
2742 number, scroll window by a few more lines to make the cursor fully
2743 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2744 (start_display): Don't move to the next line if the display should
2745 start at a newline that is part of a display vector or an overlay
2746 string. (Bug#10119)
8c535114 2747
fa4fdb5c
JL
27482011-11-24 Juri Linkov <juri@jurta.org>
2749
2750 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2751 after the `MagickPingImage' call. (Bug#10112)
2752
90ec88df
CY
27532011-11-23 Chong Yidong <cyd@gnu.org>
2754
2755 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2756
56e2e794
MR
27572011-11-23 Martin Rudalics <rudalics@gmx.at>
2758
2759 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2760 making another buffer current. (Bug#10114)
2761
b6e64c41
GM
27622011-11-23 Glenn Morris <rgm@gnu.org>
2763
2764 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2765
6b21de18
CY
27662011-11-23 Chong Yidong <cyd@gnu.org>
2767
2768 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2769 using it (Bug#5984).
2770
b12cd789
EZ
27712011-11-22 Eli Zaretskii <eliz@gnu.org>
2772
2773 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2774 and header-lines, as they don't have one computed for them.
2775 (Bug#10098)
2776
2777 * .gdbinit (prow): Make displayed values more self-explaining.
2778 Add row's hash code.
2779
261b6fd4
LMI
27802011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2781
2782 * process.c (wait_reading_process_output): Fix asynchrounous
2783 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 2784 (wait_reading_process_output): Add comment and URL.
261b6fd4 2785
e7cfd277
JD
27862011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2787
2788 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2789
a9b9b7f5
CY
27902011-11-21 Chong Yidong <cyd@gnu.org>
2791
2792 * window.c (Fnext_window, Fprevious_window): Doc fix.
2793
b0d15b4f
SM
27942011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2795
2796 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2797
fe7a3057
JB
27982011-11-20 Juanma Barranquero <lekktu@gmail.com>
2799
2800 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2801
d2999b1a
MR
28022011-11-20 Martin Rudalics <rudalics@gmx.at>
2803
2804 * window.c (Fset_window_combination_limit): Rename argument
2805 STATUS to LIMIT.
2806 (Vwindow_combination_limit): Remove "status" from doc-string.
2807
d5ff9cd0
AS
28082011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2809
2810 * m/ibms390.h: Remove.
2811 * m/ibms390x.h: Don't include "ibms390.h".
2812
a5bb9bd3
SM
28132011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2814
2815 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2816 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2817
cd1181db
JB
28182011-11-20 Juanma Barranquero <lekktu@gmail.com>
2819
2820 * casetab.c (Fset_case_table):
2821 * charset.c (Fcharset_after): Fix typos.
2822
615a3b8d 28232011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 2824
17e845af
PE
2825 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2826 Otherwise, valgrind does not work on some platforms.
2827 Problem reported by Andreas Schwab in
6a0bf43d
PE
2828 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2829 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2830 is set, removing the need for VIRT_ADDRESS_VARIES.
2831 (PURE_P): Use a more-efficient implementation that needs just one
2832 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2833 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2834 to 4 (xorl, subq, cmpq, setbe).
2835 * alloc.c (pure): Always extern now, since that's the
2836 VIRT_ADDR_VARIES behavior.
2837 (PURE_POINTER_P): Use a single comparison, not two, for
2838 consistency with the new puresize.h.
2839 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2840 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2841 Remove VIRT_ADDR_VARIES no longer needed.
2842
f8fe6f96
EZ
28432011-11-19 Eli Zaretskii <eliz@gnu.org>
2844
2845 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2846 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2847 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2848 behave as if the cursor position were at the window margin.
2849
2850 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2851 and the cursor position is out of bounds, behave as if the cursor
2852 position were at the window margin. (Bug#10075)
2853
df05a53c
CY
28542011-11-18 Chong Yidong <cyd@gnu.org>
2855
2856 * window.c (Fwindow_combination_limit): Make first argument
2857 non-optional, since it is meaningless for live windows like the
2858 selected window.
61ccba97 2859
2071918e
DA
28602011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2861
2862 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2863
b50a28de
SM
28642011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2865
2866 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2867 (graft_intervals_into_buffer): Simplify.
2868
015137db
EZ
28692011-11-18 Eli Zaretskii <eliz@gnu.org>
2870
2871 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2872 hash values of the two rows.
2873 (copy_row_except_pointers): Preserve the used[] arrays and the
2874 hash values of the two rows. (Bug#10035)
68c95424 2875 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
2876
2877 * xdisp.c (row_hash): New function, body extracted from
2878 compute_line_metrics.
2879 (compute_line_metrics): Call row_hash, instead of computing the
2880 hash code inline.
2881
2882 * dispnew.c (verify_row_hash): Call row_hash for computing the
2883 hash code of a row, instead of duplicating code from xdisp.c.
2884
2885 * dispextern.h (row_hash): Add prototype.
2886
a2addb04
TH
28872011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2888
2889 * frame.c (delete_frame): Don't delete the terminal when the last
2890 X frame is closed if emacs is built with GTK toolkit.
2891
df85d315
JB
28922011-11-17 Juanma Barranquero <lekktu@gmail.com>
2893
2894 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2895
a0c2d0ae
MR
28962011-11-17 Martin Rudalics <rudalics@gmx.at>
2897
2898 * window.c (Vwindow_splits): Rename to
2899 Vwindow_combination_resize. Suggested by Juri Linkov.
2900 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2901 of Vwindow_splits.
2902
58179cce
JB
29032011-11-16 Juanma Barranquero <lekktu@gmail.com>
2904
7877f373
JB
2905 * nsfns.m (Fns_font_name):
2906 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 2907
b6f67890
MR
29082011-11-16 Martin Rudalics <rudalics@gmx.at>
2909
2910 * window.h (window): Rename slot "nest" to "combination_limit".
2911 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2912 (Fset_window_nest): Rename to Fset_window_combination_limit.
2913 (Vwindow_nest): Rename to Vwindow_combination_limit.
2914 (recombine_windows, make_parent_window, make_window)
2915 (Fsplit_window_internal, saved_window)
2916 (Fset_window_configuration, save_window_save): Rename all
2917 occurrences of window_nest to window_combination_limit.
2918
c7015153
JB
29192011-11-15 Juanma Barranquero <lekktu@gmail.com>
2920
2921 * image.c (imagemagick_load_image): Fix typo.
2922
322ad6ec
EZ
29232011-11-14 Eli Zaretskii <eliz@gnu.org>
2924
2925 * xdisp.c (display_line): Move the call to
2926 highlight_trailing_whitespace before the call to
2927 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
2928 faces of all the glyphs to compute ROW's hash value.
2929 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 2930
f067b8ec
JB
29312011-11-14 Juanma Barranquero <lekktu@gmail.com>
2932
2933 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2934 just return (bug#10044).
2935
1e5b2111
EZ
29362011-11-12 Eli Zaretskii <eliz@gnu.org>
2937
7ef3cbd5
EZ
2938 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2939 with user-defined heap size. Bump the default size of the temacs
2940 heap to 27MB, to avoid memory warning when running temacs.
2941 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2942
1e5b2111
EZ
2943 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2944 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
2945 (verify_row_hash) [XASSERTS]: New function.
2946 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2947 that the hash value of glyph rows is correct.
1e5b2111 2948
89d61221
MR
29492011-11-12 Martin Rudalics <rudalics@gmx.at>
2950
2951 * window.h (window): Remove splits slot.
2952 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2953 (Fdelete_other_windows_internal, make_parent_window)
2954 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2955 (Fset_window_configuration, save_window_save): Don't deal with
2956 split status of windows.
2957 (saved_window): Remove splits slot.
2958 (Vwindow_splits): Rewrite doc-string.
2959
97f18cc8
JD
29602011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2961
2962 * xfns.c (unwind_create_frame):
2963 * nsfns.m (unwind_create_frame):
2964 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2965 Vframe_list (Bug#9999).
2966
22a648b4
DA
29672011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2968
0b381c7e 2969 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 2970
659afede
KH
29712011-11-11 Kenichi Handa <handa@m17n.org>
2972
2973 * callproc.c (Fcall_process): Set the member dst_multibyte of
2974 process_coding.
2975
9ac0394b
KH
29762011-11-11 Johan Bockgård <bojohan@gnu.org>
2977
2978 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2979 avoid a crash (bug#9496).
2980
2fbdc249
CY
29812011-11-09 Chong Yidong <cyd@gnu.org>
2982
2983 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2984 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2985
ac6b1f81
PE
29862011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2987
2988 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2989
09db192c
PE
29902011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2991
2992 Avoid some portability problems by eschewing 'extern inline' functions.
2993 The trivial performance wins aren't worth the portability hassles; see
2994 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2995 et seq.
2996 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2997 (window_box_width, window_box_left, window_box_left_offset)
2998 (window_box_right, window_box_right_offset): Undo previous change,
2999 by removing the "extern"s.
3000 * intervals.c (adjust_intervals_for_insertion)
3001 (adjust_intervals_for_deletion): Undo previous change,
3002 making these static again.
3003 (offset_intervals, temp_set_point_both, temp_set_point)
3004 (copy_intervals_to_string): No longer inline.
3005 * xdisp.c (window_text_bottom_y, window_box_width)
3006 (window_box_height, window_box_left_offset)
3007 (window_box_right_offset, window_box_left, window_box_right)
3008 (window_box): No longer inline.
3009
105216ed
CY
30102011-11-08 Chong Yidong <cyd@gnu.org>
3011
3012 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3013 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3014 Signal an error if not a live window.
105216ed
CY
3015 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3016 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3017
ae9e237f
JB
30182011-11-07 Juanma Barranquero <lekktu@gmail.com>
3019
3020 * lisp.h (syms_of_abbrev): Remove declaration.
3021 Reported by CHENG Gao <chenggao@royau.me>.
3022
c7aa8333
EZ
30232011-11-07 Eli Zaretskii <eliz@gnu.org>
3024
3025 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3026 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3027 of temacs in GUI mode.
3028
be7f5545
MR
30292011-11-07 Martin Rudalics <rudalics@gmx.at>
3030
3031 * window.h: Declare delete_all_child_windows instead of
3032 delete_all_subwindows.
3033 * window.c (Fwindow_nest, Fset_window_nest)
3034 (Fset_window_new_total, Fset_window_new_normal)
3035 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3036 (delete_all_subwindows): Rename to delete_all_child_windows.
3037 (Fdelete_other_windows_internal, Fset_window_configuration):
3038 Call delete_all_child_windows instead of delete_all_subwindows.
3039 * frame.c (delete_frame): Call delete_all_child_windows instead
3040 of delete_all_subwindows.
3041
ca78dc43
PE
30422011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3043
3044 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3045 This is also needed for porting to any host where GC_MARK_STACK is
3046 not GC_MAKE_GCPROS_NOOPS.
3047 (which_symbols): Use it.
3048
a0241d01
KH
30492011-11-07 Kenichi Handa <handa@m17n.org>
3050
3051 * coding.c (coding_set_destination): Check coding->src_pos only
3052 when coding->src_object is a buffer (bug#9910).
3053
3054 * process.c (send_process): Set the member src_multibyte of coding
3055 to 0 (bug#9911) when sending a unibyte text.
3056
3057 * callproc.c (Fcall_process): Set the member src_multibyte of
3058 process_coding to 0 (bug#9912).
3059
a64bfdfa 30602011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3061
3062 * xmenu.c (cleanup_widget_value_tree): New function.
3063 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3064 calling free_menubar_widget_value_tree directly (Bug#9830).
3065
cb41b32a
PE
30662011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 Fix some portability problems with 'inline'.
3069 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3070 (window_box_width, window_box_left, window_box_left_offset)
3071 (window_box_right, window_box_right_offset): Declare extern.
3072 Otherwise, these inline functions do not conform to C99 and
3073 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3074 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3075 * intervals.c (adjust_intervals_for_insertion)
3076 (adjust_intervals_for_deletion): Now extern, because otherwise the
3077 extern inline functions 'offset_intervals' couldn't refer to it.
3078 (static_offset_intervals): Remove.
3079 (offset_intervals): Rewrite using the old contents of
3080 static_offset_intervals. The old version didn't conform to C99
3081 because an extern inline function contained a reference to an
3082 identifier with static linkage.
3083
b7041366
AS
30842011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3085
3086 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3087 GC.
3088
88a37c4d
EZ
30892011-11-06 Eli Zaretskii <eliz@gnu.org>
3090
3091 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3092 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3093 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3094 return Qleft_to_right.
3095
49745b39
CY
30962011-11-06 Chong Yidong <cyd@gnu.org>
3097
3098 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3099 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3100 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3101 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3102 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3103 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3104 (Fwindow_vscroll): Doc fix.
3105 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3106 argument, since it makes no sense to pass a live window and for
3107 consistency with window-child.
3108
1f05cd82
CS
31092011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3110
3111 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3112 support MSVC.
3113
22610910
JR
31142011-11-05 Jason Rumney <jasonr@gnu.org>
3115
3116 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3117 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3118 fonts (Bug#6029).
3119 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3120 bitwise arithmetic preventing use of unicode-sip and non-truetype
3121 opentype fonts.
3122
a06776b2
EZ
31232011-11-05 Eli Zaretskii <eliz@gnu.org>
3124
3ad924ba
EZ
3125 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3126 "emacs"-only part.
3127
a06776b2
EZ
3128 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3129 initialization code to keep similarity to xfns.c after changes
3130 from 2011-11-05.
3131
c9e7db78
JD
31322011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3133
a97f8f3f
JD
3134 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3135 (unwind_create_frame): New function (Bug#9943).
3136 (Fx_create_frame): Restructure code to be more similar to the one in
3137 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3138 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3139 Move terminal->reference_count++ just before making the frame official
3140 (Bug#9943).
3141
3142 * nsterm.m (x_free_frame_resources): New function.
3143 (x_destroy_window): Move code to x_free_frame_resources.
3144
c9e7db78 3145 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3146 (Fx_create_frame, x_create_tip_frame):
3147 Move terminal->reference_count++ just before making the frame
75f1671a 3148 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3149 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3150
a6fc3b5c
EZ
31512011-11-05 Eli Zaretskii <eliz@gnu.org>
3152
3153 Support MSVC build with newer versions of Visual Studio.
3154 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3155 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3156 nt/gmake.defs.
3157
3158 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3159 which are not supported by MSVC.
3160 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3161 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3162 bitfields.
3163 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3164 types in bitfields.
3165 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3166
3167 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3168
58179cce 31692011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3170
3171 Support MSVC build with newer versions of Visual Studio.
3172 * w32.c: Don't include w32api.h for MSVC.
3173 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3174
3175 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3176 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3177 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3178 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3179 e_* cousins.
3180 (alloca) [_MSC_VER]: Define to _alloca.
3181
3182 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3183
3184 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3185
a58c13ed
EZ
31862011-11-04 Eli Zaretskii <eliz@gnu.org>
3187
3188 * xdisp.c (note_mouse_highlight): If either of
3189 previous/next-single-property-change returns nil, treat that as
3190 the beginning or the end of the buffer. (Bug#9955)
3191
fe0b6370
JD
31922011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3193
a58c13ed 3194 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3195 label is not null (Bug#9951).
3196 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3197 may be NULL.
3198
89bd5ee1
EZ
31992011-11-04 Eli Zaretskii <eliz@gnu.org>
3200
3201 * window.c (Fwindow_body_size): Mention in the doc string that the
3202 return value is in frame's canonical units. (Bug#9949)
3203
84c3edb9
EZ
32042011-11-03 Eli Zaretskii <eliz@gnu.org>
3205
4e2fb5c7
EZ
3206 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3207
84c3edb9 3208 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3209 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3210 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3211
bc17a887
EZ
32122011-11-01 Eli Zaretskii <eliz@gnu.org>
3213
3214 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3215 Don't stop backward scan on the continuation glyph, even though
3216 its CHARPOS is positive.
6d5eb5b0
SM
3217 (mouse_face_from_buffer_pos, note_mouse_highlight):
3218 Rename cover_string to disp_string.
bc17a887 3219
4ee88440
MR
32202011-11-01 Martin Rudalics <rudalics@gmx.at>
3221
3222 * window.c (temp_output_buffer_show): Don't use
3223 Vtemp_buffer_show_specifiers.
3224 (Vtemp_buffer_show_specifiers): Remove unused variable.
3225
c2ff3c02
EZ
32262011-10-30 Eli Zaretskii <eliz@gnu.org>
3227
3228 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3229 past the beginning of the current glyph matrix.
3230
58179cce 32312011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3232
3233 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3234 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3235 HAVE_GTK3 (Bug#9869).
b77a6a7f 3236
3b574623
JD
3237 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3238 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3239
b77a6a7f
JD
3240 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3241
3242 * xterm.c: Declare x_handle_net_wm_state to return int.
3243 (handle_one_xevent): Check if we are iconified but don't have
3244 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3245 (get_current_wm_state): Return non-zero if not hidden,
3246 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3247 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3248 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3249 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3250
196e41e4
PE
32512011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3252
3253 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3254 so that this new function doesn't get optimized away by a
3255 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3256
021f2e1a
AS
32572011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3258
3259 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3260
8b058d44
EZ
32612011-10-29 Eli Zaretskii <eliz@gnu.org>
3262
3263 Fix the `xbytecode' command.
3264 * .gdbinit (xprintbytestr): New command.
b50a28de 3265 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3266 (xbytecode): Print the byte-code string as well.
3267
4452fb80
EZ
32682011-10-29 Kim Storm <storm@cua.dk>
3269
8b058d44
EZ
3270 * alloc.c (which_symbols): New function.
3271
21b72067
AS
32722011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3273
3274 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3275 line. (Bug#9903)
3276
83ed7b5c
GM
32772011-10-29 Glenn Morris <rgm@gnu.org>
3278
3279 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3280 Not clear what it was for, and it causes various bugs. (Bug#9839)
3281
5a7a728b
EZ
32822011-10-28 Eli Zaretskii <eliz@gnu.org>
3283
3284 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3285 possible random value that matches one of those tested as
3286 condition to clear the mouse face.
3287
d3d0842f
CY
32882011-10-28 Chong Yidong <cyd@gnu.org>
3289
3290 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3291
31b39d13
DN
32922011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3293
3294 * window.c (make_window): Initialize phys_cursor_on_p.
3295
9aba6043
SM
32962011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3297
3298 * lisp.h (struct Lisp_Symbol): Update comments.
3299
c20992f4
JB
33002011-10-28 Juanma Barranquero <lekktu@gmail.com>
3301
3302 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3303
db4f02f2
EZ
33042011-10-28 Eli Zaretskii <eliz@gnu.org>
3305
3306 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3307 <oslsachem@gmail.com> for helping to debug this.
3308
3309 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3310 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3311 (g_b_init_get_glyph_outline_w): New static variables.
3312 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3313 (GetGlyphOutlineW_Proc): New typedefs.
3314 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3315 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3316 New functions.
3317 (w32font_open_internal, compute_metrics):
3318 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3319 instead of calling the "wide" APIs directly.
3320
3321 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3322
3323 * w32.h (syms_of_w32font): Add prototype.
3324
87e68db4
JB
33252011-10-27 Juanma Barranquero <lekktu@gmail.com>
3326
3327 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3328 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3329 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3330 (Fmove_to_window_line): Doc fix.
3331
435c1d67
CY
33322011-10-27 Chong Yidong <cyd@gnu.org>
3333
3334 * process.c (make_process): Set gnutls_state to NULL.
3335
3336 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3337 non-NULL, regardless of GNUTLS_INITSTAGE.
3338 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3339 an error. Set process slots as soon as we allocate them.
3340
3341 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3342
9c6c6f49
CY
33432011-10-27 Chong Yidong <cyd@gnu.org>
3344
9aba6043
SM
3345 * gnutls.c (emacs_gnutls_deinit): New function.
3346 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3347 (Fgnutls_deinit, Fgnutls_boot): Use it.
3348
3349 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3350 (deactivate_process): Call emacs_gnutls_deinit.
3351
657d08d3
JB
33522011-10-27 Juanma Barranquero <lekktu@gmail.com>
3353
3354 * image.c (x_create_x_image_and_pixmap):
3355 * w32.c (sys_rename, w32_delayed_load):
3356 * w32font.c (fill_in_logfont):
3357 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3358
5430d399
JB
33592011-10-26 Juanma Barranquero <lekktu@gmail.com>
3360
3361 * w32fns.c (w32_default_color_map): New function,
3362 extracted from Fw32_default_color_map.
a7ef684b 3363 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3364
fe0055fa
PE
33652011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3366
3367 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3368
e6346438
SM
33692011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3370
3371 * keyboard.c (test_undefined): New function (bug#9751).
3372 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3373
e112cc37
ET
33742011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3375
3376 * sysdep.c (init_sys_modes): Fix the check for the controlling
3377 terminal (Bug#6649).
3378
7b5d6677
EZ
33792011-10-20 Eli Zaretskii <eliz@gnu.org>
3380
3381 * dispextern.h (struct bidi_it): New member next_en_type.
3382
3383 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3384 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3385 current character, check also for next_en_type being WEAK_EN.
3386 (bidi_resolve_weak): Don't enter the expensive loop if the current
3387 position is before next_en_pos. Record the bidi type of the first
3388 non-ET, non-BN character we find, in addition to its position.
3389 (bidi_level_of_next_char): Invalidate next_en_type when
3390 next_en_pos is over-stepped.
3391
7da0b018
PE
33922011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3393
3394 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3395 * editfns.c: Rewrite current-time-zone so that it invokes
3396 the equivalent of (format-time-string "%Z") to get the time zone name.
3397 This fixes a bug when the time zone name contains characters that
3398 need converting from the system time locale to Emacs internal format.
3399 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3400 that patch fixed format-time-string to do the conversion, but
3401 I forgot to fix current-time-zone.
3402 (format_time_string): New function, containing most of
3403 what Fformat_time_string used to contain.
3404 (Fformat_time_string): Rewrite in terms of format_time_string.
3405 This doesn't change this function's behavior.
3406 (current-time-zone): Rewrite to use format_time_string.
3407 This fixes the bug reported by Michael Schierl in
3408 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3409 Jason Rumney's 2007-06-07 change worked around this bug, but
3410 didn't fix it.
3411 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3412
8547b010
EZ
34132011-10-19 Eli Zaretskii <eliz@gnu.org>
3414
3415 * xdisp.c (start_display): If the character at POS is displayed
3416 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3417 (try_window_reusing_current_matrix): If a line ends in a display
3418 vector or the next line starts in a display vector, continue
3419 redrawing the window even though the character position of
3420 start_row was reached.
8547b010
EZ
3421 (Bug#9771, part 2)
3422
4e948d15
CY
34232011-10-18 Chong Yidong <cyd@gnu.org>
3424
3425 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3426 with nobreak-char-display too.
3427
4787455f
EZ
34282011-10-18 Eli Zaretskii <eliz@gnu.org>
3429
3430 Fix part 3 of bug#9771.
3431 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3432 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3433 non-neutral characters if the current character is a paragraph
3434 separator (a.k.a. Newline). This avoids running the same
3435 expensive loop twice, once when we consume the preceding newline
3436 and the other time when the line actually needs to be displayed.
3437 Avoid the loop when we see neutrals on the base embedding level
3438 following a character whose directionality is the same as the
3439 paragraph's. This avoids running the expensive loop when a line
3440 ends in a long sequence of neutrals, like control characters.
3441 Add assertion against STRONG_AL type. Slightly rearrange code
3442 that determines the type of a neutral given the first non-neutral
3443 that follows it.
3444 (bidi_level_of_next_char): Set next_en_pos to zero when
3445 invalidating its info.
3446
2c91f553
EZ
34472011-10-17 Eli Zaretskii <eliz@gnu.org>
3448
3449 * xdisp.c (push_display_prop): Determine whether to record string
3450 or buffer position by IT->string, not by IT->method. Allow
3451 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3452 (move_it_vertically_backward): Don't look for character position
3453 immediately after the newline when in a continuation line.
3454 (Bug#9771, part 1)
2c91f553 3455
c7b08b0d
MR
34562011-10-15 Martin Rudalics <rudalics@gmx.at>
3457
3458 * window.c (coordinates_in_window): Rewrite and delabelize
3459 vertical border check. (Bug#5357) (Bug#9618)
3460
6b02f655
SM
34612011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3462
3463 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3464 errors in XSetWindowBorder (bug#9310).
3465
81d40c92
DA
34662011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3467
3468 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3469 avoid crash when xmalloc overrun checking is enabled.
3470
d4172c3b
EZ
34712011-10-13 Eli Zaretskii <eliz@gnu.org>
3472
3473 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3474 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3475 cursor motion with <left> and <right> arrow keys.
3476
3477 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3478 some callers set that themselves.
3479
b00eea75
EZ
34802011-10-12 Eli Zaretskii <eliz@gnu.org>
3481
3482 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3483 display string and the previous row comes from the same string and
3484 is empty. (Bug#9739) (Bug#9738)
3485
8fe012c4
SM
34862011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3487
3488 * doc.c (get_doc_string): Encode file name (bug#9735).
3489
0074aef2
EZ
34902011-10-12 Eli Zaretskii <eliz@gnu.org>
3491
79beb178
EZ
3492 * bidi.c (bidi_level_of_next_char):
3493 * xdisp.c (get_visually_first_element): Remove old incorrect
3494 comments regarding the Unicode Line Separator character.
3495
0074aef2
EZ
3496 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3497
6e4b3fbe
DA
34982011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3499
3500 * alloc.c (Fgc_status): Do not access beyond zombies array
3501 boundary if nzombies > MAX_ZOMBIES.
3502 * alloc.c (dump_zombies): Add missing format specifier.
3503
0324f3af
PE
35042011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3505
b5525cac
PE
3506 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3507 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3508
0324f3af
PE
3509 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3510 Some packages use them to denote characters with modifiers.
3511
e9b5f888
AS
35122011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3513
3514 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3515 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3516 matching a pp-number. Rename parameter var to var1.
3517
127827c0
SM
35182011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3519
3520 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3521
c8fd3bd0
GM
35222011-10-08 Glenn Morris <rgm@gnu.org>
3523
3524 * callint.c (Fcall_interactively): Give a more explicit error for the
3525 'c' case with a non-character input. (Bug#8479)
3526
352ec8ff
EZ
35272011-10-08 Eli Zaretskii <eliz@gnu.org>
3528
03669ccb
EZ
3529 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3530 lines.
7061c986
EZ
3531 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3532 lines that are hscrolled on the left.
03669ccb 3533
352ec8ff
EZ
3534 * dispnew.c (buffer_posn_from_coords): Account for a possible
3535 presence of header-line. (Bug#4426)
3536
a66cfb1c
SM
35372011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3538
6b02f655
SM
3539 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3540 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3541
7c5ee88e
PE
35422011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3543
3544 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3545 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3546 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3547 this makes Emacs dump core during garbage collection on rare
3548 occasions. sizeof is obviously inferior to offsetof here, so
3549 stick with offsetof.
3550 (GC_POINTER_ALIGNMENT): New macro.
3551 (mark_memory): Omit 3rd (offset) arg; caller changed.
3552 Don't assume EMACS_INT alignment is the same as pointer alignment.
3553
df1bbe5b
SM
35542011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3555
3556 * keyboard.c (read_key_sequence_remapped): New var.
3557 (read_key_sequence): Compute remapping in the right buffer.
3558 (command_loop_1): Use read_key_sequence's remapping directly.
3559
51553db6
SM
35602011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3561
32c1fffd
SM
3562 * dired.c (file_name_completion): Don't expand file name.
3563 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3564 before checking file name handler.
3565
51553db6
SM
3566 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3567 they've been requested explicitly (bug#9591).
3568
b6bd1599 35692011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3570
3571 * keymap.c (Fsingle_key_description): Use make_specified_string
3572 instead of build_string to build string from push_key_description.
3573 (Bug#5193)
3574
f701dc2a
PE
35752011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3576
4222c55d
PE
3577 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3578 This fixes a Y2038 bug on 64-bit hosts.
3579 * buffer.c (reset_buffer):
3580 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3581 (Fclear_buffer_auto_save_failure):
3582 Use 0, not -1, to represent an unset failure time, since time_t
3583 might not be signed.
3584
f701dc2a
PE
3585 Remove dependency on glibc malloc internals.
3586 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3587 Move back here from lisp.h, but with their new implementations.
3588 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3589 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3590 * charset.c (charset_table_init): New static var.
3591 (syms_of_charset): Use it instead of xmalloc. This removes a
3592 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3593 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3594 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3595 Move back to alloc.c.
3596 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3597 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3598
9ceebf39
JD
35992011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3600
3601 * nsterm.m (windowDidResize): Call x_set_window_size only when
3602 ns_in_resize is true. Otherwise set pixelwidth/height and
3603 call change_frame_size (Bug#9628).
3604
cb993c58
PE
36052011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3606
3930c88b
PE
3607 Port --enable-checking=all to Fedora 14 x86-64.
3608 * charset.c (syms_of_charset): Also account for glibc malloc's
3609 internal overhead when calculating the initial malloc maximum.
3610
cb993c58
PE
3611 Port --enable-checking=all to Fedora 14 x86.
3612 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3613 Move to lisp.h.
3614 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3615 (overrun_check_realloc, overrun_check_free):
3616 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3617 That way, xmalloc returns a properly-aligned pointer even if
3618 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3619 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3620 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3621 into account when calculating the initial malloc maximum.
3622 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3623 Move here from alloc.c, so that charset.c can use it too.
3624 Properly align; the old code wasn't right for common 32-bit hosts
3625 when configured with --enable-checking=all.
3626 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3627 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3628
31bed486
EZ
36292011-09-29 Eli Zaretskii <eliz@gnu.org>
3630
04c70788 3631 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3632 use EDOM.
3633
fbcaa2f3
EZ
36342011-09-28 Eli Zaretskii <eliz@gnu.org>
3635
3636 * xdisp.c (compute_display_string_end): If there's no display
3637 string at CHARPOS, return -1.
3638
3639 * bidi.c (bidi_fetch_char): When compute_display_string_end
3640 returns a negative value, treat the character as a normal
3641 character not covered by a display string. (Bug#9624)
3642
a239d4e9
JB
36432011-09-28 Juanma Barranquero <lekktu@gmail.com>
3644
3645 * lread.c (Fread_from_string): Fix typo in docstring.
3646
88652fd5
EZ
36472011-09-27 Eli Zaretskii <eliz@gnu.org>
3648
3649 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3650 newline, reseat the iterator instead of bidi-iterating there one
3651 character at a time. (Bug#9610)
32c1fffd
SM
3652 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3653 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3654
ed497dd4
AS
36552011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3656
3657 * lread.c (readevalloop): Use correct code for NBSP.
3658 (read1): Likewise. (Bug#9608)
3659
b2bf61aa
MA
36602011-09-25 Michael Albinus <michael.albinus@gmx.de>
3661
3662 * dbusbind.c (Fdbus_register_signal): When service is not
3663 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3664
32bbb17c
GM
36652011-09-25 Glenn Morris <rgm@gnu.org>
3666
3667 * buffer.c (truncate-lines): Doc fix.
3668
94e0933e
CY
36692011-09-24 Chong Yidong <cyd@stupidchicken.com>
3670
3671 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3672 (Fset_window_next_buffers): Doc fix.
3673
cddde921
GM
36742011-09-24 Glenn Morris <rgm@gnu.org>
3675
3676 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3677
1260aef1
PE
36782011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3679
25b4bfa0
PE
3680 Fix minor problems found by static checking.
3681 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3682 * indent.c (Fvertical_motion): Fix == vs = typo.
3683
e3cbd34b
EZ
36842011-09-24 Eli Zaretskii <eliz@gnu.org>
3685
a66cfb1c
SM
3686 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3687 Default value is now t. Doc fix.
6bf7006f 3688
e3cbd34b 3689 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3690 logic when moving up, not only when moving down. Fix the
e3cbd34b 3691 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3692 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3693
3694 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3695 CHARPOS is covered by a display string which includes newlines.
3696 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3697 is covered by a display string with embedded newlines.
3698
a3de0cbd
MA
36992011-09-24 Michael Albinus <michael.albinus@gmx.de>
3700
3701 * dbusbind.c (Fdbus_register_signal): Add match rule to
3702 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3703 (Fdbus_register_method, Vdbus_registered_objects_table):
3704 Fix docstring.
a3de0cbd 3705
b260039d
JM
37062011-09-24 Jim Meyering <meyering@redhat.com>
3707
32c1fffd 3708 do not ignore write error for any output size
b260039d
JM
3709 The previous change was incomplete.
3710 While it makes emacs --batch detect the vast majority of stdout
3711 write failures, errors were still ignored whenever the output size is
3712 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3713 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3714 && echo FAIL: ignored write error
3715 FAIL: ignored write error
3716 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3717 && echo FAIL: ignored write error
3718 FAIL: ignored write error
3719 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3720
8eca8a7c
AS
37212011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3722
3723 * emacs.c (Fkill_emacs): In noninteractive mode exit
3724 non-successfully if a write error occurred on stdout. (Bug#9574)
3725
3341db62
EZ
37262011-09-21 Eli Zaretskii <eliz@gnu.org>
3727
3728 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3729 the xassert test.
3730
3731 * dispextern.h (struct it): Update the comment documenting what
3732 can it->OBJECT be.
3733
8c203dbf
EZ
37342011-09-20 Eli Zaretskii <eliz@gnu.org>
3735
3736 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3737 a display string, extend search for cursor position to end of row.
3738 (find_row_edges): If the row ends in a newline from a display
3739 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3740 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3741 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3742 non-empty line. Fixes confusing cursor motion with arrow keys at
3743 the beginning of a line that starts with whitespace.
8c203dbf 3744
a4824228
LMI
37452011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3746
3747 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3748 (bug#9493).
3749
33ed493b
CY
37502011-09-18 Chong Yidong <cyd@stupidchicken.com>
3751
3752 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3753 boolean (Bug#9154).
3754
56cd55c8
EZ
37552011-09-18 Eli Zaretskii <eliz@gnu.org>
3756
3757 * xdisp.c (display_line): Record maximum and minimum buffer
3758 positions even if no glyphs were produced (e.g., by a zero-width
3759 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3760 buffer positions that will be removed from the glyph row because
3761 they don't fit.
c02dcedf
EZ
3762 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3763 column is beyond frame width: don't subtract 1 "pixel" when
3764 computing width of the stretch.
3e62b7e0
EZ
3765 (reseat_at_next_visible_line_start): Undo the change made on
3766 2011-09-17 that saved paragraph information and restored it after
3767 the call to `reseat'. (Bug#9545)
56cd55c8 3768
5ed99d36 37692011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
3770
3771 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3772 and turn window cursor on if cleared (Bug#9415).
3773
5ed99d36 37742011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
3775
3776 * search.c (boyer_moore): Take unibyte characters from pattern
3777 literally. (Bug#9458)
3778
9bade7b2
EZ
37792011-09-18 Eli Zaretskii <eliz@gnu.org>
3780
3781 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3782
e5e9d610
PE
37832011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3784
87e4427a
PE
3785 Fix minor problem found by static checking.
3786 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3787 initialized, to pacify gcc -Wuninitialized.
3788
e5e9d610
PE
3789 * fileio.c: Report proper errno when syscall falls.
3790 (Finsert_file_contents): Save and restore errno,
3791 so that report_file_error outputs the correct diagnostic.
3792 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3793
a1674f0b
EZ
37942011-09-18 Eli Zaretskii <eliz@gnu.org>
3795
3796 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3797
fbfb6dd4
EZ
37982011-09-17 Eli Zaretskii <eliz@gnu.org>
3799
3800 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3801 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3802
bb187662
EZ
38032011-09-17 Eli Zaretskii <eliz@gnu.org>
3804
1137e8b8 3805 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 3806 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
3807
3808 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3809 (bidi_find_paragraph_start): Search back for paragraph beginning
3810 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3811 (bidi_move_to_visually_next): Only trigger paragraph-related
3812 computations when the last character is a newline or at EOB, not
3813 just any NEUTRAL_B. (Bug#9470)
3814
bb187662
EZ
3815 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3816 truncated lines if point is covered by a display string. (Bug#9524)
3817
2e621251
PE
38182011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3819
3820 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3821 (cons_to_x_long): New function.
3822 (lisp_data_to_selection_data): Use it. Correct the test for
3823 short-versus-long data; it was negated. Break out of vector
3824 loop, for efficiency, when a long datum is discovered.
3825
91a15bc6
SM
38262011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3827
3828 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3829
b41c3a35
EZ
38302011-09-16 Eli Zaretskii <eliz@gnu.org>
3831
3832 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3833 GCC PR/17406) by declaring this function with external scope.
3834
7812ba2d
PE
38352011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3836
3837 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3838 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3839
cf7edc2a
AS
38402011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3841
3842 * editfns.c (Fformat): Correctly handle text properties on "%%".
3843
bd01620e
EZ
38442011-09-15 Eli Zaretskii <eliz@gnu.org>
3845
3846 * xterm.c (x_draw_composite_glyph_string_foreground):
3847 * w32term.c (x_draw_composite_glyph_string_foreground):
3848 * term.c (encode_terminal_code):
3849 * composite.c (composition_update_it, get_composition_id):
3850 * xdisp.c (get_next_display_element)
3851 (fill_composite_glyph_string): Add comments about special meaning
3852 of TAB characters in a composition.
3853
a02719a3
PE
38542011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3855
3856 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
3857 This occurs when processing a multibyte format.
3858 Problem reported by Wolfgang Jenker.
a02719a3 3859
72589a3c
JB
38602011-09-15 Johan Bockgård <bojohan@gnu.org>
3861
3862 * xdisp.c (try_cursor_movement): Only check for exact match if
3863 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3864
1c14176c
PE
38652011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3866
3867 Remove unused external symbols.
3868 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3869 * xdisp.c (calc_pixel_width_or_height): Now static.
3870 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3871 * indent.c (check_display_width):
3872 * w32term.c: Fix comment to match code.
3873 * xterm.c, xterm.h (x_catching_errors): Remove.
3874
d2eea5b5
PE
38752011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3876
3877 * xselect.c: Use signed conversions more consistently (Bug#9498).
3878 (selection_data_to_lisp_data): Assume incoming selection data are
3879 signed integers, not unsigned. This is to be consistent with
3880 outgoing selection data, which was modified to use signed integers
3881 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3882 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3883 expects long, not unsigned long.
3884
46888499
EZ
38852011-09-14 Eli Zaretskii <eliz@gnu.org>
3886
3887 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3888 computation of loop end. Reported by Johan Bockgård
3889 <bojohan@gnu.org>.
3890
ef8ef9fb
CY
38912011-09-13 Chong Yidong <cyd@stupidchicken.com>
3892
3893 * frame.c (Fother_visible_frames_p): Function deleted.
3894
fa819fed
EZ
38952011-09-12 Eli Zaretskii <eliz@gnu.org>
3896
3897 * indent.c (compute_motion): Process display vector front to back
3898 rather than the other way around. (Bug#2496)
3899
2ba8e008
SM
39002011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3901
3902 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3903
20f53c69
CY
39042011-09-11 Chong Yidong <cyd@stupidchicken.com>
3905
3906 * minibuf.c (Fread_from_minibuffer): Doc fix.
3907
d562d7a4
EZ
39082011-09-11 Eli Zaretskii <eliz@gnu.org>
3909
3910 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3911 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3912
1c4d7f3d
LMI
39132011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3914
3915 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3916 value for non-existent files.
3917
b885bf36
EZ
39182011-09-11 Eli Zaretskii <eliz@gnu.org>
3919
3920 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3921 set its "size" to -1. This will set the modtime_size field of
3922 the corresponding buffer to -1, which is what
3923 verify-visited-file-modtime expects for files that do not exist.
3924 (Bug#9139)
3925
6612f0bf
PE
39262011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3927
3928 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3929 here ...
3930 * lisp.h: ... from here. push_key_description is no longer
3931 defined in keyboard.c, so its declaration should not be in
3932 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3933 logically belongs with push_key_description.
3934
dfb3f755
PE
39352011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3936
3937 * buffer.h: Include <sys/types.h> instead of <time.h>.
3938 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3939 Problem reported by Herbert J. Skuhra.
3940
3134906c
LMI
39412011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3942
3943 * xml.c (parse_region): Make the parsing work for
3944 non-comment-starting XML files again (bug#9144).
3945
8d903f4e
AS
39462011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3947
3948 * image.c (gif_load): Fix calculation of bottom and right corner.
3949 (Bug#9468)
3950
80ad64f4
EZ
39512011-09-10 Eli Zaretskii <eliz@gnu.org>
3952
3953 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3954 redisplay in small windows.
3955
208a048d
EZ
39562011-09-09 Eli Zaretskii <eliz@gnu.org>
3957
3958 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3959
9b1c252e
MR
39602011-09-08 Martin Rudalics <rudalics@gmx.at>
3961
3962 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3963 Operate on live windows only.
3964
2949f33b
JB
39652011-09-08 Juanma Barranquero <lekktu@gmail.com>
3966
3967 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3968
e08dcafd
EZ
39692011-09-07 Eli Zaretskii <eliz@gnu.org>
3970
3971 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3972 only under bidi iteration.
3973
115b96bd
JD
39742011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3975
3976 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3977
c8199d0f
PE
39782011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3979
3980 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3981 Without this fix, the command to link temacs failed due to an
3982 undefined symbol __builtin_isnan. This is because
3983 /usr/include/iso/math_c99.h #defines isnan(x) to
3984 __builtin_isnan(x), but the bundled gcc, which identifies itself
3985 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3986 a __builtin_isnan.
3987 * floatfns.c (isnan): #undef, and then #define to a clone of
3988 what's in data.c.
3989 (Fisnan): Always define, since it's always available now.
3990 (syms_of_floatfns): Always define isnan at the Lisp level.
3991
e39b275c 39922011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
3993
3994 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3995
b2db44d9 39962011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 3997
f4af5137 3998 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
3999 The previous code assumed that file offsets (off_t values) fit in
4000 EMACS_INT variables, which is not true on typical 32-bit hosts.
4001 The code messed up by falsely reporting buffer overflow in cases
4002 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4003 when "big" contains more than 2**29 bytes, even though this
4004 inserts just one byte and does not overflow the buffer.
4005 (Finsert_file_contents): Store file offsets as off_t
4006 values, not as EMACS_INT values. Check for overflow when
4007 converting between EMACS_INT and off_t. When checking for
4008 buffer overflow or for overlap, take the offsets into account.
4009 Don't use EMACS_INT for small values where int suffices.
4010 When checking for overlap, fix a typo: ZV was used where
4011 ZV_BYTE was intended.
4012 (Fwrite_region): Don't assume off_t fits into 'long'.
4013 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4014
ecfc0a49
MA
40152011-09-05 Michael Albinus <michael.albinus@gmx.de>
4016
4017 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4018
6511acf2 40192011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4020
0999621a 4021 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4022
4023 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4024 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4025 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4026 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4027 (modify_event_symbol): Do not assume that the length of
4028 name_alist_or_stem is safe to alloca and fits in int.
4029 (Fexecute_extended_command): Likewise for function name and binding.
4030 (Frecursion_depth): Wrap around reliably on integer overflow.
4031 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4032 since some callers pass EMACS_INT values.
4033 (Fsingle_key_description): Don't crash if symbol name contains more
4034 than MAX_ALLOCA bytes.
4035 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4036 (get_minibuffer): Arg is now EMACS_INT, not int.
4037 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4038 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4039 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4040
2be7d702
PE
4041 * dbusbind.c (signature_cat): New function.
4042 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4043 Do not overrun buffer; instead, report string overflow.
4044
9d1df220
PE
4045 * dispnew.c (add_window_display_history): Don't overrun buffer.
4046 Truncate instead; this is OK since it's just a log.
4047
33ef5c64
PE
4048 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4049 even if the time zone offset is outlandishly large.
4050 Don't mishandle offset == INT_MIN.
4051
66c6fdd5
PE
4052 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4053 when creating daemon; the previous buffer-overflow check was incorrect.
4054
d749b01b
PE
4055 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4056 which has the guts of the old verror function.
4057
b5cd1905
PE
4058 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4059 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4060
6e1a67fb
PE
4061 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4062 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4063 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4064 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4065 length of string rather than counting it via multiple sprintfs;
4066 that's simpler and more reliable.
c21721cc
PE
4067 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4068 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4069 sprintf, in case result does not fit in int.
4070
c57b67fc
PE
4071 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4072 (fontset_from_font): Print it.
4073
8a401434
PE
4074 * frame.c (tty_frame_count): Now printmax_t, not int.
4075 (make_terminal_frame, set_term_frame_name): Print it.
4076 (x_report_frame_params): In X, window IDs are unsigned long,
4077 not signed long, so print them as unsigned.
4078 (validate_x_resource_name): Check for implausibly long names,
4079 and don't assume name length fits in 'int'.
4080 (x_get_resource_string): Don't blindly alloca invocation name;
4081 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4082 not fit in int.
4083
6e1a67fb
PE
4084 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4085 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4086 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4087
0df02bf3
PE
4088 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4089 Use esprintf, not sprintf, in case result does not fit in int.
4090
48e30793
PE
4091 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4092 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4093 it as a large positive number.
4094 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4095 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4096
a66ff6d8
PE
4097 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4098 in case result does not fit in int.
4099
aca216ff
PE
4100 * print.c (float_to_string): Detect width overflow more reliably.
4101 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4102 buffer overrun. Don't assume list length fits in 'int'. Treat
4103 print length of 0 as 0, not as infinity; to be consistent with other
4104 uses of print length in this function. Don't overflow print length
4105 index. Don't assume hash table size fits in 'long', or that
4106 vectorlike size fits in 'unsigned long'.
4107
31c286f7
PE
4108 * process.c (make_process): Use printmax_t, not int, to format
4109 process-name gensyms.
4110
55e5faa1
PE
4111 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4112
80f2e268
PE
4113 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4114 to avoid potential buffer overrun.
4115
670741ab
PE
4116 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4117 if X resource line is longer than 512 bytes.
4118
b7163a50
PE
4119 * xfns.c (x_window): Make sprintf buffer a bit bigger
4120 to avoid potential buffer overrun.
4121
ae58ff1f
PE
4122 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4123
c43c8a6a
PE
4124 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4125
3f8236f4
PE
41262011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4127
53e9fe90 4128 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4129 Without these, Emacs silently mishandles large integers sometimes.
4130 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4131 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4132
6511acf2
PE
4133 * xdisp.c (try_window_id): Check Emacs fixnum range before
4134 converting to 'int'.
806add1d 4135
6511acf2 4136 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4137 Check that an Emacs fixnum is in range before assigning it to 'int'.
4138 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4139 values converted from Emacs fixnums.
4140 (Frecenter): Don't wrap around a line count if it is out of 'int'
4141 range; instead, treat it as an extreme value.
4142 (Fset_window_configuration, compare_window_configurations):
4143 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4144
6511acf2
PE
4145 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4146 that can exceed INT_MAX. Check that EMACS_INT value is in range
4147 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4148 (match_limit): Don't assume that a fixnum can fit in 'int'.
4149
6511acf2 4150 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4151 exceed INT_MAX.
4152
6511acf2 4153 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4154 (Fvertical_motion): Don't wrap around LINES values that don't fit
4155 in 'int'. Instead, treat them as extreme values. This is good
4156 enough for windows, which can't have more than INT_MAX lines anyway.
4157
fcb901a7
LMI
41582011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4159
0f2f6b6d
LMI
4160 * Require libxml/parser.h to avoid compilation warning.
4161
fcb901a7
LMI
4162 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4163
4164 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4165 since this reportedly can destroy thread storage.
4166
6e20a0d4
CY
41672011-08-30 Chong Yidong <cyd@stupidchicken.com>
4168
4169 * syntax.c (find_defun_start): Update all cache variables if
4170 exiting early (Bug#9401).
4171
148ae00e
EZ
41722011-08-30 Eli Zaretskii <eliz@gnu.org>
4173
f6cfbd8f
EZ
4174 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4175
148ae00e
EZ
4176 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4177 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4178 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4179
4180 * term.c (tty_append_glyph): New function.
4181 (produce_stretch_glyph): Static function and its prototype deleted.
4182
a66cfb1c
SM
4183 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4184 Add prototypes.
148ae00e 4185
c4a07a4c
PE
41862011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4187
4188 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4189 when checking :margin (Bug#9390).
4190 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4191 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4192 so that the name doesn't mislead. All uses changed.
4193
6bc8cd65
JB
41942011-08-28 Johan Bockgård <bojohan@gnu.org>
4195
4196 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4197 set_tty_hooks.
4198
dca4927e
EZ
41992011-08-27 Eli Zaretskii <eliz@gnu.org>
4200
4201 * xdisp.c (move_it_to): Don't bail out early when reaching
4202 position beyond to_charpos, if we are scanning backwards.
4203 (move_it_vertically_backward): When DY == 0, make sure we get to
4204 the first character in the line after the newline.
4205
f2cad773
PE
42062011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4207
4208 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4209 (ccl_driver): Do not generate an out-of-range pointer.
4210 (Fccl_execute_on_string): Remove unnecessary check for
4211 integer overflow, noted by Stefan Monnier in
4212 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4213 Remove a FIXME that didn't need fixing.
4214 Simplify the newly-introduced buffer reallocation code.
4215
0cae2cdb
JB
42162011-08-27 Juanma Barranquero <lekktu@gmail.com>
4217
4218 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4219
5fc295a4 42202011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4221
70c60eb2 4222 Integer and memory overflow issues (Bug#9196).
726e0ab1 4223
d31850da
PE
4224 * doc.c (get_doc_string): Rework so that
4225 get_doc_string_buffer_size is the actual buffer size, rather than
4226 being 1 less than the actual buffer size; this makes xpalloc more
4227 convenient.
4228
a69fbedb
PE
4229 * image.c (x_allocate_bitmap_record, cache_image):
4230 * xselect.c (Fx_register_dnd_atom):
4231 Simplify previous changes by using xpalloc.
4232
fe5c5d37
PE
4233 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4234 since either will do and ptrdiff_t is convenient with xpalloc.
4235
0065d054
PE
4236 * charset.c (charset_table_size)
4237 (struct charset_sort_data.priority): Now ptrdiff_t.
4238 (charset_compare): Don't overflow if priorities differ greatly.
4239 (Fsort_charsets): Don't assume list length fits in int.
4240 Check for size-calculation overflow when allocating sort data.
4241 (syms_of_charset): Allocate an initial charset table that is
4242 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4243
4244 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4245
4246 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4247 The actual value is always <= INT_MAX, and leaving it unsigned made
4248 overflow checking harder.
4249
4250 * dispextern.h (struct glyph_matrix.rows_allocated)
4251 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4252 with xpalloc. The values are still always <= INT_MAX.
4253
4254 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4255
4256 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4257 (SAFE_NALLOCA): New macro.
4258
4259 * region-cache.c (struct boundary.pos, find_cache_boundary)
4260 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4261 (set_cache_region, invalidate_region_cache)
4262 (revalidate_region_cache, know_region_cache, region_cache_forward)
4263 (region_cache_backward, pp_cache):
4264 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4265 so that ptrdiff_t * can be passed to xpalloc.
4266 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4267 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4268 (pp_cache): Don't assume cache_len fits in int.
4269 * region-cache.h: Adjust extern decls to match.
4270
4271 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4272 EMACS_INT, since either will do, for xpalloc.
4273
4274 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4275 (xnmalloc, xnrealloc, xpalloc): New functions.
4276
726e0ab1
PE
4277 * bidi.c (bidi_shelve_header_size): New constant.
4278 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4279 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4280
51f30bc5 4281 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4282 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4283 (overlay_strings):
4284 Don't update size of array until after memory allocation succeeds,
4285 because xmalloc/xrealloc may not return.
0065d054
PE
4286 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4287 now that we have proper integer overflow checking.
4288 (record_overlay_string, overlay_strings): Catch overflows when
4289 calculating size of overlay_str_buf.
726e0ab1 4290
0065d054
PE
4291 * callproc.c (Fcall_process): Check for size overflow when
4292 calculating size of args2.
4293 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4294 Normally we prefer signed values, but sticking with ptrdiff_t would
4295 require adding more-complicated checks.
726e0ab1
PE
4296
4297 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4298 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4299 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4300 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4301
4302 * character.c (Fstring): Check for size-calculation overflow.
4303
4304 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4305 unnecessary integer overflow. Check for size overflow.
4306 (encode_coding_object): Don't update size until xmalloc succeeds.
4307
4308 * composite.c (get_composition_id): Check for overflow in glyph
4309 length calculations.
4310
4311 Integer and memory overflow fixes for display code.
4312 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4313 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4314 (scrolling_window): Check for overflow in size calculations.
4315 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4316 Don't assume glyph table len fits in int.
4317 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4318 (row_table_size): Now ptrdiff_t, not int.
4319 (scrolling_window): Avoid overflow in size calculations.
4320 Don't update size until allocation succeeds.
4321 * fns.c (concat): Check for overflow in size calculations.
4322 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4323 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4324 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4325
4326 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4327 (get_doc_string): Check for size calculation overflow.
4328 Don't update size until allocation succeeds.
4329 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4330 EMACS_INT, where ptrdiff_t will do.
4331 (Fsubstitute_command_keys): Check for string overflow.
4332
4333 * editfns.c (set_time_zone_rule): Don't assume environment length
4334 fits in int.
4335 (message_length): Now ptrdiff_t, not int.
4336 (Fmessage_box): Don't update size until allocation succeeds.
4337 Don't assume message length fits in int.
4338 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4339
0065d054
PE
4340 * emacs.c (main): Do not reallocate argv, since there is a null at
4341 the end that can be overwritten, and this way there's no need to
4342 worry about size-calculation overflow.
4343 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4344
4345 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4346 alloc succeeds.
4347 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4348
4349 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4350 (x_set_scroll_bar_width, x_figure_window_size):
4351 Check for integer overflow.
4352 (x_set_alpha): Do not assume XINT fits in int.
4353
4354 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4355 This is for the members text_lines, text_cols, total_lines, total_cols,
4356 where the system imposes an 'int' limit.
4357
4358 * fringe.c (Fdefine_fringe_bitmap):
4359 Don't update size until alloc works.
4360
4361 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4362 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4363
4364 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4365 Check for size-calculation overflow.
4366 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4367 do, as we prefer signed integers.
4368 (id_to_widget.max_size, id_to_widget.used)
4369 (xg_store_widget_in_map, xg_remove_widget_from_map)
4370 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4371 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4372 Use and return ptrdiff_t, not int.
4373 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4374 * gtkutil.h: Change prototypes to match the above.
4375
4376 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4377 are duplicate now that they've been promoted to lisp.h.
4378 (x_allocate_bitmap_record, x_alloc_image_color)
4379 (make_image_cache, cache_image, xpm_load):
4380 Don't update size until alloc is done.
4381 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4382 (x_detect_edges):
3256efce 4383 Check for size calculation overflow.
726e0ab1
PE
4384 (ct_colors_allocated_max): New constant.
4385 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4386 overflow.
3256efce 4387
726e0ab1
PE
4388 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4389 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4390 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4391 Use ptrdiff_t, not int, to count maps.
4392 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4393 calculations. Don't update size until allocation succeeds.
4394 Redo calculations to avoid overflow.
726e0ab1
PE
4395 * keyboard.h: Change prototypes to match the above.
4396
4397 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4398 to count maps.
4399 (current_minor_maps): Check for size calculation overflow.
4400 * keymap.h: Change prototypes to match the above.
4401
4402 * lread.c (read1, init_obarray): Don't update size until alloc done.
4403
4404 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4405 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4406
726e0ab1
PE
4407 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4408 Now ptrdiff_t, not int.
4409 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4410 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4411
4412 * process.c (Fnetwork_interface_list): Check for overflow
4413 in size calculation.
4414
4415 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4416
4417 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4418 overflow. Don't bother calling xmalloc when xrealloc will do.
4419
4420 * search.c (Freplace_match): Check for size calculation overflow.
4421 (Fset_match_data): Don't assume list lengths fit in 'int'.
4422
4423 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4424 for command line length. Do not attempt to address one before the
4425 beginning of an array, as that's not portable.
4426
4427 * term.c (max_frame_lines): Remove; unused.
4428 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4429 not int.
4430 (encode_terminal_code, calculate_costs): Check for size
4431 calculation overflow.
4432 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4433 table lengths and related sizes. Don't update size until alloc
4434 done. Redo calculations to avoid overflow.
4435 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4436
4437 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4438 subtracting pointers.
4439 (gobble_line): Check for overflow more carefully. Don't update size
4440 until alloc done.
4441
4442 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4443 Don't update size until alloc done.
4444 Redo size calculations to avoid overflow.
4445 Check for size calculation overflow.
0065d054 4446 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4447
4448 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4449 Use ptrdiff_t, not int, for sizes.
4450 (store_mode_line_noprop_char): Don't update size until alloc done.
4451
0065d054
PE
4452 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4453 Use ptrdiff_t, not int, for sizes.
4454 (Finternal_make_lisp_face, cache_face):
4455 Check for size calculation overflow.
4456 (cache_face): Treat size calculation overflows as if they were
4457 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4458
4459 * xfns.c (x_encode_text, x_set_name_internal)
4460 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4461 sizes, since they can exceed INT_MAX in size. Check for size
4462 calculation overflow.
4463
0065d054
PE
4464 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4465 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4466 Don't update size until alloc done.
4467
0065d054 4468 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4469 as sprintf is limited to int lengths.
1d526e2f 4470
252c5ee1
PE
4471 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4472 (X_LONG_MIN): New macros.
864d7ce7
PE
4473 Use them to make the following changes clearer.
4474 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4475 This change doesn't affect the value now, but it may help remind
4476 future maintainers not to raise the value too much later.
4477 (SELECTION_QUANTUM): Remove, replacing with ...
4478 (selection_quantum): ... new function, which avoids overflow.
4479 All uses changed.
4480 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4481 assumption that selection length fits in 'int'.
4482 (x_reply_selection_request, x_handle_selection_request)
4483 (x_get_window_property, receive_incremental_selection)
4484 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4485 (lisp_data_to_selection_data, clean_local_selection_data):
4486 Use ptrdiff_t, not int, to record length of selection.
4487 (x_reply_selection_request, x_get_window_property)
4488 (receive_incremental_selection, x_property_data_to_lisp):
4489 Redo calculations to avoid overflow.
4490 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4491 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4492 something.
4493 (x_get_window_property, receive_incremental_selection)
4494 (lisp_data_to_selection_data, x_property_data_to_lisp):
4495 Check for size-calculation overflow.
4496 (x_get_window_property, receive_incremental_selection)
4497 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4498 Don't store size until memory allocation succeeds.
4499 (x_get_window_property): Plug memory leak on memory exhaustion.
4500 Don't double-block input; malloc is safe here. Don't assume 2**34
4501 - 4 fits in unsigned long. Add an xassert to check
4502 XGetWindowProperty overflow. Be more careful about overflow
4503 calculations, and distinguish size from memory overflow better.
4504 (receive_incremental_selection): When tracing, don't assume
4505 unsigned int is less than INT_MAX.
4506 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4507 harmful) conversions of unsigned short to int.
4508 (lisp_data_to_selection_data): Don't assume that integers
4509 in the range -65535 through -1 fit in an X unsigned short.
4510 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4511 result parameters unless successful. Rely on cons_to_unsigned
4512 to report problems with elements; the old code wasn't right anyway.
4513 (x_check_property_data): Check for int overflow; we cannot use
4514 a wider type due to X limits.
4515 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4516
726e0ab1 4517 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4518
0065d054
PE
4519 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4520 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4521 (x_color_cells): Don't store size until memory allocation succeeds.
4522 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4523 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4524 (x_term_init): Don't assume length fits in int (sprintf is limited
4525 to int size).
bc18e09d 4526
ebfa62c0
PE
4527 Use ptrdiff_t for composition IDs.
4528 * character.c (lisp_string_width):
4529 * composite.c (composition_table_size, n_compositions)
4530 (get_composition_id, composition_gstring_from_id):
4531 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4532 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4533 * window.c (Frecenter):
4534 Use ptrdiff_t, not int, for composition IDs.
4535 * composite.c (get_composition_id): Check for integer overflow.
4536 * composite.h: Adjust prototypes to match the above changes.
4537
d3411f89
PE
4538 Use ptrdiff_t for hash table indexes.
4539 * category.c (hash_get_category_set):
4540 * ccl.c (ccl_driver):
4541 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4542 * coding.c (coding_system_charset_list, detect_coding_system):
4543 * coding.h (struct coding_system.id):
4544 * composite.c (get_composition_id, gstring_lookup_cache):
4545 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4546 * image.c (xpm_get_color_table_h):
4547 * lisp.h (hash_lookup, hash_put):
4548 * minibuf.c (Ftest_completion):
4549 Use ptrdiff_t for hash table indexes, not int (which is too
4550 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4551 32-bit --with-wide-int hosts).
4552
e097a6fa
PE
4553 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4554 Add a FIXME comment about memory leaks.
4555 (syms_of_charset): Don't assume xmalloc returns.
4556
5637687f
PE
4557 Don't assume that stated character widths fit in int.
4558 * character.c (Fchar_width, c_string_width, lisp_string_width):
4559 * character.h (CHAR_WIDTH):
4560 * indent.c (MULTIBYTE_BYTES_WIDTH):
4561 Use sanitize_char_width to avoid undefined and/or bad behavior
4562 with outlandish widths.
a66cfb1c 4563 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4564 now that we have two such functions. All uses changed.
4565 (sanitize_char_width): New inline function.
4566
a2271ba2
PE
4567 Don't assume that tab-width fits in int.
4568 * character.h (sanitize_width): New inline function.
4569 (SANE_TAB_WIDTH): New macro.
4570 (ASCII_CHAR_WIDTH): Use it.
4571 * indent.c (sane_tab_width): Remove. All uses replaced by
4572 SANE_TAB_WIDTH (current_buffer).
4573 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4574
18c52557
PE
4575 * fileio.c: Integer overflow issues with file modes.
4576 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4577
caeeedc1
PE
4578 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4579 Remove unreachable code.
4580 (read_hex, load_charset_map_from_file): Check for integer overflow.
4581
6df6ae42 4582 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4583 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4584 (x_send_scroll_bar_event): Likewise. Check that the size does not
4585 exceed limits imposed by XClientMessageEvent, as well as the usual
4586 ptrdiff_t and size_t limits.
4587
b13995db
PE
4588 * keyboard.c: Overflow, signedness and related fixes.
4589 (make_lispy_movement): Use same integer type in forward decl
4590 that is used in the definition.
4591 (read_key_sequence, keyremap_step):
4592 Change bufsize argument back to int, undoing my 2011-03-30 change.
4593 We prefer signed types, and int is wide enough here.
4594 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4595 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4596 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4597 length, not size_t. Use ptrdiff_t for index, not int.
4598 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4599 possibility of integer overflow.
4600
13464394
PE
4601 Overflow, signedness and related fixes for images.
4602
4603 * dispextern.h (struct it.stack[0].u.image.image_id)
4604 (struct_it.image_id, struct image.id, struct image_cache.size)
4605 (struct image_cache.used, struct image_cache.ref_count):
4606 * gtkutil.c (update_frame_tool_bar):
4607 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4608 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4609 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4610 * nsmenu.m (update_frame_tool_bar):
4611 * xdisp.c (calc_pixel_width_or_height):
4612 * xfns.c (image_cache_refcount):
4613 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4614 on typical 64-bit hosts.
4615
4616 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4617 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4618 Omit unnecessary casts to int.
4619 (parse_image_spec): Check that integers fall into 'int' range
4620 when the callers expect that.
4621 (image_ascent): Redo ascent calculation to avoid int overflow.
4622 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4623 (lookup_image): Remove unnecessary tests.
4624 (xbm_image_p): Locals are now of int, not EMACS_INT,
4625 since parse_image_check makes sure they fit into int.
4626 (png_load, gif_load, svg_load_image):
4627 Prefer int to unsigned where either will do.
4628 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4629 old tiff_error_handler and tiff_warning_handler.
4630 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4631 stack buffer overflows. It uses only the features of vsnprintf
4632 that are common to both POSIX and native Microsoft.
4633 (tiff_error_handler, tiff_warning_handler): Use it.
4634 (tiff_load, gif_load, imagemagick_load_image):
4635 Don't assume :index value fits in 'int'.
4636 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4637 (imagemagick_load_image): Check that crop parameters fit into
4638 the integer types that MagickCropImage accepts. Don't assume
4639 Vimagemagick_render_type has a nonnegative value. Don't assume
4640 size_t fits in 'long'.
4641 (gs_load): Use printmax_t to print the widest integers possible.
4642 Check for integer overflow when computing image height and width.
4643
c11821d4
EZ
46442011-08-26 Eli Zaretskii <eliz@gnu.org>
4645
4646 * xdisp.c (redisplay_window): Don't force window start if point
4647 will be invisible in the resulting window. (Bug#9324)
4648
0c95fcf7
EZ
46492011-08-25 Eli Zaretskii <eliz@gnu.org>
4650
4651 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4652 the display spec is of the form `(space ...)'.
4653 (handle_display_spec): Return the value returned by
4654 handle_single_display_spec, not just 1 or zero.
4655 (handle_single_display_spec): If the display spec is of the form
4656 `(space ...)', and specifies display in the text area, return 2
4657 rather than 1.
fee65a97 4658 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4659 accurately, and prefer exact match for point under bidi.
4660 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4661
4662 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4663 into disp_prop; all users changed.
4664
4665 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4666 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4667 for the text covered by the display property.
4668
e4ed06f1
CY
46692011-08-25 Chong Yidong <cyd@stupidchicken.com>
4670
4671 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4672 Change return value to nil.
4673 (Frecord_buffer): Delete unused function.
4674
f67cdd7f
EZ
46752011-08-24 Eli Zaretskii <eliz@gnu.org>
4676
5980d4c6
EZ
4677 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4678 buffers, return left-to-right.
8610fe8b
EZ
4679 (set_cursor_from_row): Consider candidate row a win if its glyph
4680 represents a newline and point is on that newline. Fixes cursor
4681 positioning on the newline at EOL of R2L text within L2R
4682 paragraph, and vice versa.
4683 (try_cursor_movement): Check continued rows, in addition to
4684 continuation rows. Fixes unwarranted scroll when point enters a
4685 continued line of R2L text within an L2R paragraph, or vice versa.
4686 (cursor_row_p): Consider the case of point being equal to
4687 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4688 from the end of a short line to the beginning of a continued line
4689 of R2L text within L2R paragraph.
4690 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4691 composed characters.
5980d4c6 4692
f67cdd7f
EZ
4693 * bidi.c (bidi_check_type): Use xassert.
4694 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4695 members.
4696
bca633fb
EZ
46972011-08-23 Eli Zaretskii <eliz@gnu.org>
4698
4699 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4700 a character.
4701
4a5885a7
CY
47022011-08-23 Chong Yidong <cyd@stupidchicken.com>
4703
4704 * nsfont.m (ns_otf_to_script): Fix typo.
4705
0902a04e
KH
47062011-08-22 Kenichi Handa <handa@m17n.org>
4707
4708 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4709 extra slot even if the purpose is char-code-property-table.
4710
1a2e6670
EZ
47112011-08-23 Eli Zaretskii <eliz@gnu.org>
4712
8ddde651
EZ
4713 * xdisp.c (redisplay_window): When computing centering_position,
4714 account for the height of the header line. (Bug#8874)
4715
425cc014
EZ
4716 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4717 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4718 candidate is selected by the mouse, and that candidate has a
4719 composed character under the mouse.
4720
1a2e6670
EZ
4721 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4722 coordinates reported by pos-visible-in-window-p for a composed
4723 character in column zero.
4724
8b76d6f8
SM
47252011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4726
4727 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4728
dac347dd
EZ
47292011-08-22 Eli Zaretskii <eliz@gnu.org>
4730
4731 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4732 consider it a hit if to_charpos is anywhere in the range of the
4733 composed buffer positions.
4734
e013fb34
CY
47352011-08-22 Chong Yidong <cyd@stupidchicken.com>
4736
4737 * image.c (gif_load): Don't assume that each subimage has the same
4738 dimensions as the base image. Handle disposal method that is
4739 "undefined" by the gif spec (Bug#9335).
4740
bd1ba3e8
CY
47412011-08-20 Chong Yidong <cyd@stupidchicken.com>
4742
4743 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4744 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4745
54a1215b
EZ
47462011-08-19 Eli Zaretskii <eliz@gnu.org>
4747
823564e5
EZ
4748 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4749 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4750 from an Org mode buffer to a Speedbar frame.
4751
54a1215b
EZ
4752 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4753 a composition, take its buffer position from IT->cmp_it.charpos.
4754 Fixes cursor positioning at the beginning of a line that begins
4755 with a composed character.
4756
9778ebcc
EZ
47572011-08-18 Eli Zaretskii <eliz@gnu.org>
4758
0be6ee06
EZ
4759 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4760 character bidirectional type, use STRONG_L instead. Fixes crashes
4761 in a buffer produced by `describe-categories'.
4762
9778ebcc
EZ
4763 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4764 members before the level stack, so they would be saved and
4765 restored when copying iterator state. Fixes incorrect reordering
4766 around TABs covered by display properties.
4767
156bffbe
AS
47682011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4769
6b02f655 4770 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 4771
72ad093b
CY
47722011-08-17 Chong Yidong <cyd@stupidchicken.com>
4773
4774 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
4775 (internal_condition_case_2, internal_condition_case_n):
4776 Remove unnecessary aborts (Bug#9081).
72ad093b 4777
35774242
EZ
47782011-08-17 Eli Zaretskii <eliz@gnu.org>
4779
4780 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4781 has no `load' handler, try opening the file locally. (Bug#9311)
4782
db76dd85
KB
47832011-08-16 Ken Brown <kbrown@cornell.edu>
4784
4785 * gmalloc.c: Expand comment.
4786
b215eee5
EZ
47872011-08-16 Eli Zaretskii <eliz@gnu.org>
4788
4789 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4790 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4791
a4579d33
KB
47922011-08-16 Ken Brown <kbrown@cornell.edu>
4793
4794 Fix memory allocation problems in Cygwin build (Bug#9273).
4795
4796 * unexcw.c ( __malloc_initialized): Declare external variable.
4797 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4798
8b76d6f8
SM
4799 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4800 New variables.
a4579d33
KB
4801 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4802 dumped emacs.
4803 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4804 in the static heap.
4805 [CYGWIN] (special_realloc): New function.
4806 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4807 requests to realloc storage in the static heap.
4808
3ebec551
PE
48092011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4810
4811 * bidi.c (bidi_initialize): Remove unused local.
4812
9fd8be00
EZ
48132011-08-15 Eli Zaretskii <eliz@gnu.org>
4814
6b02f655
SM
4815 * bidimirror.h:
4816 * biditype.h: Remove file.
4817 * makefile.w32-in ($(BLD)/bidi.$(O)):
4818 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
4819
4820 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4821
4822 * chartab.c: Improve commentary for the uniprop_table API.
4823
32413314
EZ
4824 * bidi.c (bidi_paragraph_init): Support zero value of
4825 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
4826 (bidi_initialize): Use uniprop_table instead of including
4827 biditype.h and bidimirror.h.
32413314 4828
9fd8be00
EZ
4829 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4830 coordinates of the iterator when restoring from ppos_it.
4831 (Bug#9296)
4832
5cf2b69b
KH
48332011-08-14 Kenichi Handa <handa@m17n.org>
4834
4835 * process.c (create_process): Call setup_process_coding_systems
72ad093b 4836 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 4837
daf17d00
EZ
48382011-08-14 Eli Zaretskii <eliz@gnu.org>
4839
4840 * xdisp.c (move_it_in_display_line_to): Don't invoke
4841 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4842 ppos_it. Fixes vertical cursor motion when line beginning is
4843 covered by an image. (Bug#9296)
4844
08e3161a
JD
48452011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4846
4847 * nsterm.h (ns_run_ascript): Declare.
4848 (NSAPP_DATA2_RUNASSCRIPT): Define.
4849
4850 * nsfns.m (as_script, as_result, as_status): New static variables.
4851 (ns_run_ascript): New function.
5e617bc2 4852 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
4853 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4854 the event loop. Get status from as_status (Bug#7276).
4855
4856 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4857 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4858 the event loop (Bug#7276).
4859
a3720aa2
AS
48602011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4861
4862 * gnutls.c (QCgnutls_bootprop_priority)
4863 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4864 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4865 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4866 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4867 (QCgnutls_bootprop_verify_hostname_error)
4868 (QCgnutls_bootprop_callbacks_verify): Rename from
4869 Qgnutls_bootprop_..., all uses changed.
4870
4871 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4872 uses changed.
4873
0a0d27fb
PE
48742011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4875
19d5c50c
PE
4876 * xfaces.c (Qframe_set_background_mode): Now static.
4877 * dispextern.h (Qframe_set_background_mode): Remove decl.
4878
0a0d27fb
PE
4879 * process.c (Fnetwork_interface_info): Declare local only if needed.
4880
377538cb
JD
48812011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4882
4883 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4884 (Fnetwork_interface_list): Allocate in increments of bytes instead
4885 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4886 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4887 sockaddr.
4888 (struct ifflag_def): notrailers is smart on OSX.
4889 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4890 Get hardware address with getifaddrs if available.
4891
08fff70c
EZ
48922011-08-12 Eli Zaretskii <eliz@gnu.org>
4893
4894 * xdisp.c (iterate_out_of_display_property): xassert that
4895 IT->position is set to within IT->object's boundaries. Break from
4896 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
4897 when IT->position is set up wrongly due to some bug.
4898 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
4899 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4900 entry. Force push_it to save on the stack the current
4901 buffer/string position, to be restored by pop_it. Fix flags in
4902 the iterator structure wrt the object coming from a display
4903 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4904 properties. (Bug#9284)
4905
7be1c708 49062011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 4907
7be1c708
CY
4908 * fontset.c (fontset_get_font_group): Add proper type checks.
4909 (Bug#9172)
aac0c6e3 4910
7be1c708 49112011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 4912
7be1c708
CY
4913 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4914 and LC_VERSION_MIN_MACOSX.
4915 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4916 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 4917
97bb72a6
EZ
49182011-08-08 Eli Zaretskii <eliz@gnu.org>
4919
4920 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
4921 no-display-properties-and-no-overlays under bidi display.
4922 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 4923 properties and overlays.
97bb72a6 4924
d5617611
CY
49252011-08-08 Chong Yidong <cyd@stupidchicken.com>
4926
37e11a63
CY
4927 * editfns.c (Fset_time_zone_rule): Document relationship with the
4928 setenv function.
4929
d5617611
CY
4930 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4931 the font entity extracted from the cache (Bug#8109).
4932
58872834
CY
49332011-08-07 Chong Yidong <cyd@stupidchicken.com>
4934
4935 * composite.c (autocmp_chars): Don't reset point. That is done by
4936 restore_point_unwind (Bug#5984).
4937
75bfc667
JL
49382011-08-07 Juri Linkov <juri@jurta.org>
4939
4940 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4941 to show the arg `TIME' instead of `TIMEVAL'.
4942
d1410150
EZ
49432011-08-06 Eli Zaretskii <eliz@gnu.org>
4944
4945 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4946 display property strides EOL and includes a newline, as in
4947 longlines-mode. (Bug#9254)
75b771e4
EZ
4948 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4949 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
4950
4951 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4952 is non-zero, even if the data buffer is NULL. Fixes a crash in
4953 vertical-motion with longlines-mode. (Bug#9254)
4954
35928349
EZ
49552011-08-05 Eli Zaretskii <eliz@gnu.org>
4956
ec7cc85b
EZ
4957 * bidi.c <bidi_cache_total_alloc>: Now static.
4958 (bidi_initialize): Initialize bidi_cache_total_alloc.
4959
8b76d6f8 4960 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
4961 cache. (Bug#9221)
4962
4963 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4964 amount allocated this far in `bidi_cache_total_alloc'.
4965 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4966 non-zero, only free the data buffer without restoring the cache
4967 contents. All callers changed.
4968
4969 * dispextern.h (bidi_unshelve_cache): Update prototype.
4970
4971 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4972 (move_it_in_display_line, move_it_to)
4973 (move_it_vertically_backward, move_it_by_lines): Replace the call
4974 to xfree to an equivalent call to bidi_unshelve_cache.
4975 (move_it_in_display_line_to): Fix logic of returning
412b6358 4976 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 4977
e2e2423b
EZ
49782011-08-05 Eli Zaretskii <eliz@gnu.org>
4979
4980 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4981 came from a string character with a `cursor' property. (Bug#9229)
4982
ae9e757a
JD
49832011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4984
4985 * Makefile.in (LIB_PTHREAD): New variable.
4986 (LIBES): Add LIB_PTHREAD (Bug#9216).
4987
4988 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4989 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4990
213bd7f2
AS
49912011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4992
6b02f655 4993 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 4994
99aaf75f
JD
49952011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4996
4997 * xterm.c (x_find_topmost_parent): New function.
4998 (x_set_frame_alpha): Find topmost parent window with
4999 x_find_topmost_parent and set the property there also (bug#9181).
5000 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5001
c74e9d86
PE
50022011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5003
5004 * callproc.c (Fcall_process): Avoid vfork clobbering
5005 the local vars buffer, coding_systems, current_dir.
5006
640c8776
SM
50072011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5008
5009 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5010
f26d0e4c
PE
50112011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5012
8a10d76c
PE
5013 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5014 so that it is not optimized away.
5015
f26d0e4c
PE
5016 * xdisp.c (compute_display_string_pos): Remove unused local.
5017
55439c61
EZ
50182011-08-02 Eli Zaretskii <eliz@gnu.org>
5019
5020 Fix slow cursor motion and scrolling in large buffers with
5021 selective display, like Org Mode buffers. (Bug#9218)
5022
5023 * dispextern.h (struct bidi_it): New member disp_prop_p.
5024
5025 * xdisp.c: Remove one-slot cache of display string positions.
5026 (compute_display_string_pos): Accept an additional argument
5e617bc2 5027 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5028 for a display string or property. If found, set DISP_PROP_P
5029 non-zero.
5030
5031 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5032 DISP_PROP_P, and pass it to compute_display_string_pos.
5033 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5034 non-zero. All callers of bidi_fetch_char changed.
5035
fb33fa43
SM
50362011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5037
5038 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5039
b099e063
DM
50402010-12-03 Don March <don@ohspite.net>
5041
5042 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5043 last character M-[char] is translated to ESC [char] (bug#7541).
5044
5cc7f7af
KH
50452011-08-02 Kenichi Handa <handa@m17n.org>
5046
d0fffa3f 5047 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5048
5049 * chartab.c (uniprop_table): Make it non-static.
5050
525d5e6e
EZ
50512011-08-01 Eli Zaretskii <eliz@gnu.org>
5052
5053 * xdisp.c (forward_to_next_line_start): Accept additional argument
5054 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5055 on the newline.
5056 (reseat_at_next_visible_line_start): Use the bidi iterator state
5057 returned by forward_to_next_line_start to restore the state of
5058 it->bidi_it after backing up to previous newline. (Bug#9212)
5059
31011111
AS
50602011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5061
5062 * regex.c (re_comp): Protoize.
5063 (re_exec): Fix return type.
5064 (regexec): Fix type of `ret'. (Bug#9203)
5065
476371c4
PE
50662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5067
e5d76069
PE
5068 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5069 This is needed if max-image-size is a floating-point number.
5070
9a79b20c
AS
50712011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5072
5073 * print.c (print_object): Print empty symbol as ##.
5074
5075 * lread.c (read1): Read ## as empty symbol.
5076
d8c2fa78
AA
50772011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5078
5079 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5080 setting frame foreground color (Bug#9175).
5081 (x_set_background_color): Likewise.
5082
ffe57a7a
AA
5083 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5084 contents (Bug#9176).
5085 (EmacsTooltip -init): Remove bezels and add shadows to
5086 tooltip windows.
5087
bf3492a5
AA
5088 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5089 or scroll bar (Bug#8470).
5090
d55e9c53
AA
5091 * nsfont.m (nsfont_open): Remove assignment to voffset and
5092 unnecessary vars hshink, expand, hd, full_height, min_height.
5093 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5094
5095 * nsterm.h (nsfont_info): Remove voffset field.
5096
d8c2fa78 50972011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5098
5099 Implement strike-through and overline on NextStep (Bug#8863).
5100
5101 * nsfont.m (nsfont_open): Use underline position provided by font,
5102 instead of hard-coded value of 2.
5103 (nsfont_draw): Call ns_draw_text_decoration instead.
5104
5105 * nsterm.h: Add declaration for ns_draw_text_decoration.
5106
5107 * nsterm.m (ns_draw_text_decoration): New function for drawing
5108 underline, overline, and strike-through.
5109 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5110 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5111 accommodate underlining, etc.
4843aac3 5112
4cc60b9b
EZ
51132011-07-28 Eli Zaretskii <eliz@gnu.org>
5114
bc7ece87
EZ
5115 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5116 default.
4cc60b9b 5117
476371c4
PE
51182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5119
66606eea
PE
5120 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5121 Without this fix, if a signal arrives just after memory fills up,
5122 'malloc' might be invoked reentrantly.
5123
476371c4
PE
5124 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5125 In other words, assume that every image size is allowed, on non-X
5126 hosts. This assumption is probably wrong, but it lets Emacs compile.
5127
f3fcc40d
AS
51282011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5129
5130 * regex.c (re_iswctype): Convert return values to boolean.
5131
350c992f
EZ
51322011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5133
5134 * xdisp.c (compute_display_string_pos): Don't use cached display
5135 string position if the buffer had its restriction changed.
5136 (Bug#9184)
5137
5266b4bb
PE
51382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5139
5140 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5141
2573a837 51422011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5143
41f55ccd 5144 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5145
39e378da
PE
5146 * bidi.c: Integer size and overflow fixes.
5147 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5148 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5149 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5150 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5151 (bidi_find_other_level_edge):
5152 Use ptrdiff_t instead of EMACS_INT where either will do.
5153 This works better on 32-bit hosts configured --with-wide-int.
5154 (bidi_cache_ensure_space): Check for size-calculation overflow.
5155 Use % rather than repeated addition, for better worst-case speed.
5156 Don't set bidi_cache_size until after xrealloc returns, because it
5157 might not return.
5158 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5159 (bidi_cache_ensure_space): Also check that the bidi cache size
5160 does not exceed that of the largest Lisp string or buffer. See Eli
5161 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5162
5e927815
PE
5163 * alloc.c (__malloc_size_t): Remove.
5164 All uses replaced by size_t. See Andreas Schwab's note
5165 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5166
ca4aa935
PE
5167 * image.c: Improve checking for integer overflow.
5168 (check_image_size): Assume that f is nonnull, since
5169 it is always nonnull in practice. This is one less thing to
5170 worry about when checking for integer overflow later.
5171 (x_check_image_size): New function, which checks for integer
5172 overflow issues inside X.
5173 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5174 This removes the need for a memory_full check.
5175 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5176 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5177 (xbm_read_bitmap_data): Change locals back to 'int', since
5178 their values must fit in 'int'.
5179 (xpm_load_image, png_load, tiff_load):
5180 Invoke x_create_x_image_and_pixmap earlier,
5181 to avoid much needless work if the image is too large.
5182 (tiff_load): Treat overly large images as if
5183 x_create_x_image_and_pixmap failed, not as malloc failures.
5184 (gs_load): Use x_check_image_size.
5185
5f8f9cc2
PE
5186 * gtkutil.c: Omit integer casts.
5187 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5188 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5189
5adf60bc
PE
5190 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5191
c8907a93
PE
5192 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5193 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5194 would wrongly return t on a 64-bit host.
5195
e3c25c68
PE
5196 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5197 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5198 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5199 and therefore cause GCC to emit a bogus diagnostic in some cases.
5200
3f791afe
PE
5201 * image.c: Integer signedness and overflow and related fixes.
5202 This is not an exhaustive set of fixes, but it's time to
5203 record what I've got.
5204 (lookup_pixel_color, check_image_size): Remove redundant decls.
5205 (check_image_size): Don't assume that arbitrary EMACS_INT values
5206 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5207 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5208 (tiff_load, imagemagick_load_image):
5209 Check for overflow in size calculations.
5210 (x_create_x_image_and_pixmap): Remove unnecessary test for
5211 xmalloc returning NULL; that can't happen.
5212 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5213 (xpm_color_bucket): Use better integer hashing function.
5214 (xpm_cache_color): Don't possibly over-allocate memory.
5215 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5216 (gif_memory_source):
5217 Use ptrdiff_t, not int or size_t, to record sizes.
5218 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5219 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5220 either works, as we prefer signed integers.
5221 (tiff_read_from_memory, tiff_write_from_memory):
5222 Return tsize_t, not size_t, since that's what the TIFF API wants.
5223 (tiff_read_from_memory): Don't fail simply because the read would
5224 go past EOF; instead, return a short read.
5225 (tiff_load): Omit no-longer-needed casts.
5226 (Fimagemagick_types): Don't assume size fits into 'int'.
5227
3cc5a532
PE
5228 Improve hashing quality when configured --with-wide-int.
5229 * fns.c (hash_string): New function, taken from sxhash_string.
5230 Do not discard information about ASCII character case; this
5231 discarding is no longer needed.
5232 (sxhash-string): Use it. Change sig to match it. Caller changed.
5233 * lisp.h: Declare it.
5234 * lread.c (hash_string): Remove, since we now use fns.c's version.
5235 The fns.c version returns a wider integer if --with-wide-int is
5236 specified, so this should help the quality of the hashing a bit.
5237
b312a492
PE
5238 * emacs.c: Integer overflow minor fix.
5239 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5240 Define only if GNU_LINUX.
5241 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5242
dfd153ae
PE
5243 * dispnew.c: Integer signedness and overflow fixes.
5244 Remove unnecessary forward decls, that were a maintenance hassle.
5245 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5246 All uses changed.
5247 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5248 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5249 (prepare_desired_row, line_draw_cost):
5250 Use int, not unsigned, where either works.
5251 (save_current_matrix, restore_current_matrix):
5252 Use ptrdiff_t, not size_t, where either works.
5253 (init_display): Check for overflow more accurately, and without
5254 relying on undefined behavior.
5255
a81d11a3
PE
5256 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5257 Remove, replacing with the new symbols in lisp.h. All uses changed.
5258 * fileio.c (make_temp_name):
5259 * filelock.c (lock_file_1, lock_file):
5260 * xdisp.c (message_dolog):
5261 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5262 Use pMd etc. instead.
5263 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5264 replacing the pWIDE etc. symbols removed from editfns.c.
5265
3300e6fd
PE
5266 * keyboard.h (num_input_events): Now uintmax_t.
5267 This is (very slightly) less likely to mess up due to wraparound.
5268 All uses changed.
5269
fd05c7e9
PE
5270 * buffer.c: Integer signedness fixes.
5271 (alloc_buffer_text, enlarge_buffer_text):
5272 Use ptrdiff_t rather than size_t when either will do, as we prefer
5273 signed integers.
5274
903fe15d
PE
5275 * alloc.c: Integer signedness and overflow fixes.
5276 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5277 (__malloc_size_t): Default to size_t, not to int.
5278 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5279 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5280 Prefer ptrdiff_t to size_t when either would do, as we prefer
5281 signed integers.
5282 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5283 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5284 Now const. Initialize with values that are in range even if char
5285 is signed.
5286 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5287 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5288 These functions do the right thing with sizes > 2**32.
5289 (check_depth): Now ptrdiff_t, not int.
5290 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5291 Adjust to new way of storing sizes. Check for size overflow bugs
5292 in rest of code.
5293 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5294 slightly wrong anyway, as it missed one instance of
5295 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5296 (refill_memory_reserve): Omit needless cast to size_t.
5297 (mark_object_loop_halt): Mark as externally visible.
5298
ac82cc6a
PE
5299 * xselect.c: Integer signedness and overflow fixes.
5300 (Fx_register_dnd_atom, x_handle_dnd_message):
5301 Use ptrdiff_t, not size_t, since we prefer signed.
5302 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5303 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5304 x_dnd_atoms_size and x_dnd_atoms_length.
5305
c2d1e36d
PE
5306 * doprnt.c: Prefer signed to unsigned when either works.
5307 * eval.c (verror):
5308 * doprnt.c (doprnt):
5309 * lisp.h (doprnt):
5310 * xdisp.c (vmessage):
5311 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5312 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5313 prefer signed arithmetic to avoid comparison confusion.
5314 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5315 but is a bit tricky.
5316
0e926e56
PE
5317 Assume freestanding C89 headers, string.h, stdlib.h.
5318 * data.c, doprnt.c, floatfns.c, print.c:
5319 Include float.h unconditionally.
5320 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5321 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5322 * regex.c: Likewise for stddef.h, string.h.
5323 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5324 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5325 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5326 (STDC_HEADERS): Remove obsolete defines.
5327 * sysdep.c: Include limits.h unconditionally.
5328
9cfdb3ec
PE
5329 Assume support for memcmp, memcpy, memmove, memset.
5330 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5331 * regex.c (memcmp, memcpy):
5332 Remove; we assume C89 now.
5333
5334 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5335 (__malloc_safe_bcopy): Remove; no longer needed.
5336
cf950e6b 5337 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5338 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5339 well either way, and we prefer signed to unsigned.
5340
dbf38e02
LMI
53412011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5342
5343 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5344 closes the connection while we're reading (bug#9182).
5345
d6f0886c 53462011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5347
d6f0886c
JD
5348 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5349 are specified (Bug#9168).
24e0f6b1 5350
2eb1f9e6
PE
53512011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5352
5353 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5354 Found by GCC static checking and --with-wide-int on a 32-bit host.
5355
22381272 53562011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5357
5358 * xdisp.c (compute_display_string_pos): Fix logic of caching
5359 previous display string position. Initialize cached_prev_pos to
5360 -1. Fixes slow-down at the beginning of a buffer.
5361
f25e39b4
EZ
53622011-07-24 Eli Zaretskii <eliz@gnu.org>
5363
5364 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5365 for attrs[LFACE_FONTSET_INDEX].
5366
04c4b52e
PE
53672011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5368
5369 * xml.c (parse_region): Remove unused local
5370 that was recently introduced.
5371
c1734fbd
EZ
53722011-07-23 Eli Zaretskii <eliz@gnu.org>
5373
be18c5a5
EZ
5374 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5375 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5376
c1734fbd
EZ
5377 * xdisp.c (move_it_in_display_line_to): Record the best matching
5378 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5379 exit if none of the characters scanned was an exact match.
5380 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5381 when exact match is impossible due to invisible text, and the
5382 lines are truncated.
5383
a258d627
JD
53842011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5385
5386 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5387 for OSX >= 10.7.
5388
b6d5a689
EZ
53892011-07-22 Eli Zaretskii <eliz@gnu.org>
5390
0f74f785
EZ
5391 Fix a significant slow-down of cursor motion with C-n, C-p,
5392 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5393 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5394 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5395 (next_element_from_buffer): Call compute_stop_pos_backwards to
5396 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5397 base_level_stop.
5398 (reseat): Don't look for prev_stop, as that could mean a very long
5399 run.
5400 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5401 <cached_disp_overlay_modiff>: Cache for last found display string
5402 position.
551918c1 5403 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5404 about the same buffer in the same area of character positions, and
5405 the buffer wasn't changed since the time the display string
5406 position was cached.
551918c1 5407
b2d0c91a
EZ
54082011-07-22 Eli Zaretskii <eliz@gnu.org>
5409
5410 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5411 is an integer, which is important for empty lines. (Bug#9149)
5412
043604ee
CY
54132011-07-22 Chong Yidong <cyd@stupidchicken.com>
5414
5415 * frame.c (Fmodify_frame_parameters): In tty case, update the
5416 default face if necessary (Bug#4238).
5417
da4adb04
CY
54182011-07-21 Chong Yidong <cyd@stupidchicken.com>
5419
5420 * editfns.c (Fstring_to_char): No need to explain what a character
5421 is in the docstring (Bug#6576).
5422
9abd0532
LMI
54232011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5424
5425 * xml.c (parse_region): Make sure we always return a tree.
5426
36881d16
HK
54272011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5428
5429 * xml.c (parse_region): If a document contains only comments,
5430 return that, too.
5431
1e98674d
LMI
54322011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5433
5434 * xml.c (make_dom): Return comments, too.
5435
590bd467
PE
54362011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5437
5438 Port to OpenBSD.
5439 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5440 and the surrounding thread.
5441 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5442 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5443 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5444 timer goes off.
5445 * s/openbsd.h (BROKEN_SIGIO): Define.
5446 * unexelf.c (unexec) [__OpenBSD__]:
5447 Don't update the .mdebug section of the Alpha COFF symbol table.
5448
f41628b2
LMI
54492011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5450
5451 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5452 (bug#8460).
5453
b59b67c5
PE
54542011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5455
15e3a074
PE
5456 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5457 This fixes some race conditions on the permissions of any newly
5458 created file.
5459
41bed37d
PE
5460 * alloc.c (valid_pointer_p): Use pipe, not open.
5461 This fixes some permissions issues when debugging.
5462
b59b67c5
PE
5463 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5464 If fchown fails to set both uid and gid, try to set just gid,
5465 as that is sometimes allowed. Adjust the file's mode to eliminate
5466 setuid or setgid bits that are inappropriate if fchown fails.
5467
925a6be7
SM
54682011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5469
5470 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5471 to compare Lisp_Objects.
5472 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5473 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5474 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5475
52968808
AS
54762011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5477
0a6a104b
AS
5478 * lread.c (read_integer): Unread even EOF character.
5479 (read1): Likewise. Properly record start position of symbol.
5480
52968808
AS
5481 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5482 symbol character follows.
5483
9e381cdd
PE
54842011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5485
5486 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5487 This works around a problem with the previous change to Fcopy_file.
5488 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5489 and without this change, GCC might complain about discarding
5490 fchown's return value.
5491
b5641435
JB
54922011-07-16 Juanma Barranquero <lekktu@gmail.com>
5493
5494 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5495
a8031457
PE
54962011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5497
5498 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5499
dd889327
LMI
55002011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5501
750c33f7
LMI
5502 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5503 it's used from the C level.
5504
dd889327
LMI
5505 * process.c: Use the same condition for POLL_FOR_INPUT in both
5506 keyboard.c and process.c (bug#1858).
5507
87e86684
LM
55082011-07-09 Lawrence Mitchell <wence@gmx.li>
5509
5510 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5511 (Fgnutls_boot): Use it.
5512
64348f40
AS
55132011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5514
5515 * doc.c (Fsubstitute_command_keys): Revert last change.
5516
1d698799
LMI
55172011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5518
f863868c
LMI
5519 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5520 quotes the next character, and doesn't affect other longer
5521 sequences (bug#8935).
5522
1d698799
LMI
5523 * lread.c (syms_of_lread): Clarify that is isn't only
5524 `eval-buffer' and `eval-defun' that's affected by
5525 `lexical-binding' (bug#8460).
5526
aa4b6df6
EZ
55272011-07-15 Eli Zaretskii <eliz@gnu.org>
5528
5529 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5530 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5531
5d856da6
PE
55322011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5533
ad6042bb
PE
5534 Fix minor problems found by static checking.
5535 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5536 (elsz): Now a signed constant, not a size_t var. We prefer signed
5537 types to unsigned, to avoid integer comparison confusion. Without
5538 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5539 "cannot optimize loop, the loop counter may overflow", a symptom
5540 of the confusion.
f00bbb22 5541 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5542 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5543
6468f31c
LMI
55442011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5545
49080b10
LMI
5546 * search.c (Fre_search_backward): Mention `case-fold-search' in
5547 all the re_search_* functions (bug#8138).
5548
6468f31c
LMI
5549 * keyboard.c (Fopen_dribble_file): Document when the file is
5550 closed (bug#8056).
5551
c965adc5
EZ
55522011-07-14 Eli Zaretskii <eliz@gnu.org>
5553
df9733bf
EZ
5554 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5555 bidi_cache_idx.
5556
0bb23927
EZ
5557 Support bidi reordering of display and overlay strings.
5558 * xdisp.c (compute_display_string_pos)
5559 (compute_display_string_end): Accept additional argument STRING.
5560 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5561 (reseat_to_string): Initialize bidi_it->string.s and
5562 bidi_it->string.schars.
5563 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5564 NULL (avoids a crash in bidi_paragraph_init).
5565 Initialize itb.string.lstring.
0bb23927
EZ
5566 (init_iterator): Call bidi_init_it only of a valid
5567 buffer position was specified. Initialize paragraph_embedding to
5568 L2R.
5569 (reseat_to_string): Initialize the bidi iterator.
5570 (display_string): If we need to ignore text properties of
5571 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5572 original value of -1 will not work with bidi.)
5573 (compute_display_string_pos): First arg is now struct
5574 `text_pos *'; all callers changed. Support display properties on
5575 Lisp strings.
5576 (compute_display_string_end): Support display properties on Lisp
5577 strings.
5578 (init_iterator, reseat_1, reseat_to_string): Initialize the
5579 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5580 when iterating on a string not from display properties).
640c8776
SM
5581 (compute_display_string_pos, compute_display_string_end):
5582 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5583 arrow keys.
5584 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5585 base_level_stop; instead, set base_level_stop to BEGV.
5586 Fixes crashes in vertical-motion.
0bb23927
EZ
5587 (next_element_from_buffer): Improve commentary for when
5588 the iterator is before prev_stop.
5589 (init_iterator): Initialize bidi_p from the default value of
5590 bidi-display-reordering, not from buffer-local value. Use the
5591 buffer-local value only if initializing for buffer iteration.
5592 (handle_invisible_prop): Support invisible properties on strings
5593 that are being bidi-reordered.
5594 (set_iterator_to_next): Support bidi reordering of C strings and
5595 Lisp strings.
5596 (next_element_from_string): Support bidi reordering of Lisp
5597 strings.
5598 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5599 (display_string): Support display of R2L glyph rows.
5600 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5601 (init_iterator): Don't initialize it->bidi_p for strings
5602 here.
5603 (reseat_to_string): Initialize it->bidi_p for strings here.
5604 (next_element_from_string, next_element_from_c_string)
5605 (next_element_from_buffer): Add xassert's for correspondence
5606 between IT's object being iterated and it->bidi_it.string
5607 structure.
5608 (face_before_or_after_it_pos): Support bidi iteration.
5609 (next_element_from_c_string): Handle the case of the first string
5610 character that is not the first one in the visual order.
5611 (get_visually_first_element): New function, refactored from common
5612 parts of next_element_from_buffer, next_element_from_string, and
5613 next_element_from_c_string.
5614 (tool_bar_lines_needed, redisplay_tool_bar)
5615 (display_menu_bar): Force left-to-right direction. Add a FIXME
5616 comment for making that be controlled by a user option.
5617 (push_it, pop_it): Save and restore the state of the
5618 bidi iterator. Save and restore the bidi_p flag.
5619 (pop_it): Iterate out of display property for string iteration as
5620 well.
5621 (iterate_out_of_display_property): Support iteration over strings.
5622 (handle_single_display_spec): Set up it->bidi_it for iteration
5623 over a display string, and call bidi_init_it.
5624 (handle_single_display_spec, next_overlay_string)
5625 (get_overlay_strings_1, push_display_prop): Set up the bidi
5626 iterator for displaying display or overlay strings.
5627 (forward_to_next_line_start): Don't use the shortcut if
5628 bidi-iterating.
5629 (back_to_previous_visible_line_start): If handle_display_prop
5630 pushed the iterator stack, restore the internal state of the bidi
5631 iterator by calling bidi_pop_it same number of times.
5632 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5633 and we are bidi-iterating, don't decrement the iterator position;
5634 instead, set the first_elt flag in the bidi iterator, to produce
5635 the same effect.
5636 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5637 (push_display_prop): xassert that we are iterating a buffer.
5638 (push_it, pop_it): Save and restore paragraph_embedding member.
5639 (handle_single_display_spec, next_overlay_string)
5640 (get_overlay_strings_1, reseat_1, reseat_to_string)
5641 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5642 correctly. Don't assume unibyte strings are not bidi-reordered.
5643 (compute_display_string_pos)
5644 (compute_display_string_end): Fix handling the case of C string.
5645 (push_it, pop_it): Save and restore from_disp_prop_p.
5646 (handle_single_display_spec, push_display_prop): Set the
5647 from_disp_prop_p flag.
5648 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5649 (pop_it): Call iterate_out_of_display_property only if we are
5650 popping after iteration over a string that came from a display
5651 property. Fix a typo in popping stretch info. Add an assertion
5652 for verifying that the iterator position is in sync with the bidi
5653 iterator.
5654 (handle_single_display_spec, get_overlay_strings_1)
5655 (push_display_prop): Fix initialization of paragraph direction for
5656 string when that of the parent object is not yet determined.
5657 (reseat_1): Call bidi_init_it to resync the bidi
5658 iterator with IT's position. (Bug#7616)
5659 (find_row_edges): If ROW->start.pos gives position
5660 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5661 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5662 Reset the from_disp_prop_p flag.
5663 (SAVE_IT, RESTORE_IT): New macros.
5664 (pos_visible_p, face_before_or_after_it_pos)
5665 (back_to_previous_visible_line_start)
5666 (move_it_in_display_line_to, move_it_in_display_line)
5667 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5668 (try_scrolling, redisplay_window, display_line): Use them when
5669 saving a temporary copy of the iterator and restoring it back.
5670 (back_to_previous_visible_line_start, reseat_1)
5671 (init_iterator): Empty the bidi cache "stack".
5672 (move_it_in_display_line_to): If iterator ended up at
5673 EOL, but we never saw any buffer positions smaller than
5674 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5675 motion in bidi-reordered lines.
5676 (move_it_in_display_line_to): Record prev_method and prev_pos
5677 immediately before the call to set_iterator_to_next. Fixes cursor
5678 motion in bidi-reordered lines with stretch glyphs and strings
5679 displayed in margins. (Bug#8133) (Bug#8867)
5680 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5681 TO_CHARPOS.
640c8776
SM
5682 (pos_visible_p): Support positions in bidi-reordered lines.
5683 Save and restore bidi cache.
0bb23927
EZ
5684
5685 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5686 (bidi_paragraph_info): Delete unused struct.
5687 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5688 (bidi_cache_start): New variable.
5689 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5690 to zero.
5691 (bidi_cache_fetch_state, bidi_cache_search)
5692 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5693 (bidi_cache_find, bidi_peek_at_next_level)
5694 (bidi_level_of_next_char, bidi_find_other_level_edge)
5695 (bidi_move_to_visually_next): Compare cache index with
5696 bidi_cache_start rather than with zero.
5697 (bidi_fetch_char): Accept new argument STRING; all callers
5698 changed. Support iteration over a string. Support strings with
5699 display properties. Support unibyte strings. Fix the type of
5700 `len' according to what STRING_CHAR_AND_LENGTH expects.
5701 (bidi_paragraph_init, bidi_resolve_explicit_1)
5702 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5703 (bidi_level_of_next_char, bidi_move_to_visually_next):
5704 Support iteration over a string.
0bb23927
EZ
5705 (bidi_set_sor_type, bidi_resolve_explicit_1)
5706 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5707 can now be zero (for strings); special values 0 and -1 were
5708 changed to -1 and -2, respectively.
5709 (bidi_char_at_pos): New function.
5710 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5711 Call it instead of FETCH_MULTIBYTE_CHAR.
5712 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5713 initialized to valid values.
5714 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5715 values.
5716 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5717 the test for valid cached positions. Fix the logic for looking up
5718 the sentinel state in the cache. GCPRO the Lisp string we are
5719 iterating.
5720 (bidi_push_it, bidi_pop_it): New functions.
5721 (bidi_initialize): Initialize the bidi cache start stack pointer.
5722 (bidi_cache_ensure_space): New function, refactored from part of
5723 bidi_cache_iterator_state. Don't assume the required size is just
5724 one BIDI_CACHE_CHUNK away.
5725 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5726 (bidi_count_bytes, bidi_char_at_pos): New functions.
5727 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5728 always valid if bidi_cache_idx is valid.
5729 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5730 is valid if it's going to be used.
5731 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5732 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5733 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5734 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5735 (bidi_find_other_level_edge, bidi_cache_start_stack):
5736 All variables related to cache indices are now EMACS_INT.
c965adc5 5737
0bb23927
EZ
5738 * dispextern.h (struct bidi_string_data): New structure.
5739 (struct bidi_it): New member `string'. Make flag members be 1-bit
5740 fields, and put them last in the struct.
640c8776
SM
5741 (compute_display_string_pos, compute_display_string_end):
5742 Update prototypes.
0bb23927
EZ
5743 (bidi_push_it, bidi_pop_it): Add prototypes.
5744 (struct iterator_stack_entry): New members bidi_p,
5745 paragraph_embedding, and from_disp_prop_p.
5746 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5747 (bidi_shelve_cache, bidi_unshelve_cache):
5748 Declare prototypes.
0bb23927
EZ
5749
5750 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5751 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5752 and vector-like objects.
5753
5754 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5755 cache around display iteration.
5756
5757 * window.c (Fwindow_end, window_scroll_pixel_based)
5758 (displayed_window_lines, Frecenter): Save and restore the bidi
5759 cache around display iteration.
5760
3bbd2265
LMI
57612011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5762
5763 * editfns.c (Fdelete_region): Clarify the use of the named
5764 parameters (bug#6788).
5765
adc47434
MR
57662011-07-14 Martin Rudalics <rudalics@gmx.at>
5767
5768 * indent.c (Fvertical_motion): Set and restore w->pointm when
5769 saving and restoring the window's buffer (Bug#9006).
5770
837c31f8
LMI
57712011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5772
5773 * editfns.c (Fstring_to_char): Clarify just what is returned
5774 (bug#6576). Text by Eli Zaretskii.
5775
ac389d0c
JB
57762011-07-13 Juanma Barranquero <lekktu@gmail.com>
5777
5778 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5779
0be0ce47
EZ
57802011-07-13 Eli Zaretskii <eliz@gnu.org>
5781
5782 * buffer.c (mmap_find): Fix a typo.
5783
cd18e7e3
JB
57842011-07-13 Johan Bockgård <bojohan@gnu.org>
5785
5786 Fix execution of x selection hooks.
5787 * xselect.c (Qx_lost_selection_functions)
5788 (Qx_sent_selection_functions): New vars.
5789 (syms_of_xselect): DEFSYM them.
5790 (x_handle_selection_request): Pass Qx_sent_selection_functions
5791 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5792 (x_handle_selection_clear,x_clear_frame_selections):
5793 Pass Qx_lost_selection_functions rather than
5794 Vx_lost_selection_functions to Frun_hook_with_args.
5795
47ea7f44
PE
57962011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5797
ac389d0c 5798 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
5799 The old code sometimes used this field without initializing it.
5800
47ea7f44
PE
5801 * alloc.c (gc_sweep): Don't read past end of array.
5802 In theory, the old code could also have corrupted Emacs internals,
5803 though it'd be very unlikely.
5804
bc985c87
AS
58052011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5806
5807 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 5808 argument. (Bug#4026)
bc985c87 5809
0cf34688
LMI
58102011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5811
b3dadd76
LMI
5812 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5813 key" (bug#4257).
5814
0cf34688
LMI
5815 * window.c (Fset_window_start): Doc fix (bug#4199).
5816 (Fset_window_hscroll): Ditto.
5817
270768cd
PE
58182011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5819
077e3dda 5820 Fix minor new problems caught by GCC 4.6.1.
270768cd 5821 * term.c (init_tty): Remove unused local.
490011a6 5822 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 5823 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 5824 not used otherwise.
270768cd 5825
b1f58454
CY
58262011-07-12 Chong Yidong <cyd@stupidchicken.com>
5827
5828 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5829
22b9578d
LMI
58302011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5831
6e70ab07
LMI
5832 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5833 are the mini-buffer and the echo area (bug#3320).
5834
22b9578d
LMI
5835 * term.c (init_tty): Remove support for supdup, c10 and perq
5836 terminals, which are no longer supported (bug#1482).
5837
8974cc9f
JB
58382011-07-10 Johan Bockgård <bojohan@gnu.org>
5839
5840 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5841
a560d974
JD
58422011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5843
5844 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5845 for non-popups (Bug#3642).
5846
1dae0f0a
AS
58472011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5848
268c2c36 5849 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 5850 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
5851 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5852 * cm.c (losecursor): Likewise.
1dae0f0a
AS
5853 * data.c (fmod): Likewise.
5854 * dispnew.c (swap_glyphs_in_rows): Likewise.
5855 * emacs.c (memory_warning_signal): Likewise.
5856 * floatfns.c (float_error): Likewise.
5857 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5858 (otf_open, font_otf_capability, generate_otf_features)
5859 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5860 Likewise.
5861 * image.c (pbm_read_file): Likewise.
5862 * indent.c (string_display_width): Likewise.
5863 * intervals.c (check_for_interval, search_for_interval)
5864 (inc_interval_count, count_intervals, root_interval)
5865 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5866 * lread.c (defalias): Likewise.
268c2c36 5867 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
5868 * regex.c (set_image_of_range_1, set_image_of_range)
5869 (regex_grow_registers): Likewise.
5870 * sysdep.c (strerror): Likewise.
5871 * termcap.c (valid_filename_p, tprint, main): Likewise.
5872 * tparam.c (main): Likewise.
5873 * unexhp9k800.c (run_time_remap, save_data_space)
5874 (update_file_ptrs, read_header, write_header, calculate_checksum)
5875 (copy_file, copy_rest, display_header): Likewise.
5876 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5877 Likewise.
5878 * xdisp.c (check_it): Likewise.
5879 * xfaces.c (register_color, unregister_color, unregister_colors):
5880 Likewise.
5881 * xfns.c (print_fontset_result): Likewise.
5882 * xrdb.c (member, fatal, main): Likewise.
5883
99033785
PE
58842011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5885
5886 Fix minor problems found by static checking (Bug#9031).
5887 * chartab.c (char_table_set_range, map_sub_char_table):
5888 Remove unused locals.
5889 (uniprop_table): Now static.
5890 * composite.c (_work_char): Remove unused static var.
5891
9cb2ac56
JB
58922011-07-09 Juanma Barranquero <lekktu@gmail.com>
5893
5894 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5895
f25661f0
JD
58962011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5897
5898 * gtkutil.c (qttip_cb): Remove code without function.
5899
8278c4fe
EZ
59002011-07-09 Eli Zaretskii <eliz@gnu.org>
5901
5902 * w32.c (pthread_sigmask): New stub.
5903
1692ae2d 59042011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 5905
8a6ebd58 5906 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
5907 sigprocmask is portable only for single-threaded applications, and
5908 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
5909 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5910 (LIBES): Use it.
5911 * callproc.c (Fcall_process):
5912 * process.c (create_process):
5913 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5914 Use pthread_sigmask, not sigprocmask.
123403e4 5915
1b854618
JD
59162011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5917
5918 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5919 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5920 wrong (Bug#8591).
5921
3fe4b549
JD
59222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5923
0ce7e563
JD
5924 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5925 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5926 (xg_hide_tooltip): Fix comment.
5927
3fe4b549
JD
5928 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5929 in registerServicesMenuSendTypes.
5930 (validRequestorForSendType): Don't check ns_return_types.
5931
5932 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5933 ns_return_type.
5934
5df75e47
JR
59352011-07-08 Jason Rumney <jasonr@gnu.org>
5936
22610910
JR
5937 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5938 SH_SHOW for hidden windows (Bug#5482).
5939
5df75e47
JR
5940 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5941 frame struct members of non-existent frames (Bug#6284).
5942
699c10bd
JD
59432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5944
4393663b
JD
5945 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5946 variable firstTime not needed on OSX >= 10.6.
5947 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5948 >= 10.5. Use setKnobProportion, setDoubleValue.
5949
5950 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5951 (MAC_OS_X_VERSION_10_5): Define if not defined.
5952 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5953 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5954 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5955
5956 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5957 cString and lossyCString on OSX >= 10.4
5958
58179cce 5959 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
5960 sizeToFit on OSX >= 10.2.
5961
5962 * nsimage.m (allocInitFromFile): Don't use deprecated method
5963 bestRepresentationForDevice on OSX >= 10.6.
5964
5965 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5966 to avoid warning.
5967
5968 * emacs.c: Declare unexec_init_emacs_zone.
5969
a63e0781
JD
5970 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5971
699c10bd
JD
5972 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5973
5974 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5975 on svcsMenu (Bug#8842).
5976
5977 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5978 ns_return_types.
5979 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5980
5981 * nsterm.m (QUTF8_STRING): Declare.
5982 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5983 (validRequestorForSendType): Return type is (id).
5984 Change indexOfObjectIdenticalTo to indexOfObject.
5985 Check if we have local selection before returning self (Bug#8842).
5986 (writeSelectionToPasteboard): Put local selection into paste board
5987 if we have a local selection (Bug#8842).
5988 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5989
5990 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5991 (ns_get_local_selection): Declare.
5992
54e10184
LMI
59932011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5994
9888ff71
LMI
5995 * keymap.c (describe_map_tree): Don't insert a double newline at
5996 the end of the buffer (bug#1169) and return whether we inserted
5997 something.
5998
54e10184
LMI
5999 * callint.c (Fcall_interactively): Change "reading args" to
6000 "providing args" to try to clarify what it does (bug#1010).
6001
15fa4783
KH
60022011-07-07 Kenichi Handa <handa@m17n.org>
6003
6004 * composite.c (composition_compute_stop_pos): Ignore a static
6005 composition starting before CHARPOS (Bug#8915).
6006
6007 * xdisp.c (handle_composition_prop): Likewise.
6008
a8815b00
EZ
60092011-07-07 Eli Zaretskii <eliz@gnu.org>
6010
6011 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6012 (Bug#9015)
6013
ef7b981d 60142011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6015
6016 * character.h (unicode_category_t): New enum type.
6017
6018 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6019 (Qchar_code_property_table): New variable.
6020 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6021 (UNIPROP_COMPRESSED_FORM_P): New macros.
6022 (char_table_ascii): Uncompress the compressed values.
6023 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6024 Uncompress the compressed values.
ac389d0c 6025 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6026 (char_table_ref_and_range): Uncompress the compressed values.
6027 (sub_char_table_set): New arg is_uniprop. Callers changed.
6028 Uncompress the compressed values.
6029 (sub_char_table_set_range): Args changed. Callers changed.
6030 (char_table_set_range): Adjuted for the above change.
6031 (map_sub_char_table): Delete args default_val and parent. Add arg
6032 top. Give decoded values to a Lisp function.
640c8776 6033 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6034 values to a Lisp function. Gcpro more variables.
6035 (uniprop_table_uncompress)
6036 (uniprop_decode_value_run_length): New functions.
6037 (uniprop_decoder, uniprop_decoder_count): New variables.
6038 (uniprop_get_decoder, uniprop_encode_value_character)
6039 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6040 New functions.
6041 (uniprop_encoder, uniprop_encoder_count): New variables.
6042 (uniprop_get_encoder, uniprop_table)
6043 (Funicode_property_table_internal, Fget_unicode_property_internal)
6044 (Fput_unicode_property_internal): New functions.
6045 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6046 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6047 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6048 char-code-property-alist.
6049
640c8776 6050 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6051 Vunicode_category_table.
6052
640c8776 6053 * font.c (font_range): Adjust for the change of
c805dec0
KH
6054 Vunicode_category_table.
6055
76b397fb
DN
60562011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6057
6058 * m/iris4d.h: Remove file, move contents ...
6059 * s/irix6-5.h: ... here.
6060
22b4128e
PE
60612011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6062
6063 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6064 * alloc.c (mark_buffer):
6065 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6066 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6067 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6068 This isn't true in general, and it's particularly not true
6069 if Emacs is configured with --with-wide-int.
6070 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6071 New macros, used in the buffer.c change.
6072
869795d6
JD
60732011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6074
6075 * xsettings.c: Use both GConf and GSettings if both are available.
6076 (store_config_changed_event): Add comment.
6077 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6078 (store_tool_bar_style_changed): New functions.
5e617bc2 6079 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6080 (struct xsettings): Move font inside HAVE_XFT.
6081 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6082 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6083 Move inside HAVE_XFT.
640c8776 6084 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6085 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6086 also.
6087 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6088 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6089 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6090 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6091 (parse_settings): Move check for font inside HAVE_XFT.
6092 (read_settings, apply_xft_settings): Add comment.
6093 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6094 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6095 call store_font_name_changed.
6096 (xft_settings_event): Add comment.
6097 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6098 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6099 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6100 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6101 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6102 (xsettings_get_system_font, xsettings_get_system_normal_font):
6103 Add comment.
869795d6 6104
d8ed26bd
PE
61052011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6106
6107 Random fixes. E.g., (random) never returned negative values.
6108 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6109 subseconds part to the entropy, as that's a bit more random.
6110 Prefer signed to unsigned, since the signedness doesn't matter and
6111 in general we prefer signed. When given a limit, use a
6112 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6113 latter isn't right if USE_2_TAGS_FOR_INTS.
6114 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6115 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6116
cabf1cac
SM
61172011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6118
6119 * textprop.c (text_property_stickiness):
6120 Obey Vtext_property_default_nonsticky.
6121 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6122 * w32fns.c (syms_of_w32fns):
6123 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6124
6e9b2be9
PE
61252011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6126
6127 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6128 This is more efficient than Ffile_directory_p and avoids a minor race.
6129
90186c68
LMI
61302011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6131
7c301272
LMI
6132 * buffer.c (Foverlay_put): Say what the return value is
6133 (bug#7835).
6134
c4f2d8d4
LMI
6135 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6136 is a directory before asking whether to use the file name
6137 (bug#7564).
ad637907
LMI
6138 (barf_or_query_if_file_exists): Make the "File is a directory"
6139 error be more correct.
c4f2d8d4 6140
90186c68
LMI
6141 * fns.c (Frequire): Remove the mention of the .gz files, since
6142 that's installation-specific, but keep the mention of
6143 `get-load-suffixes'.
6144
da64016e
PE
61452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6146
6147 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6148 Report string overflow if the output is too long.
6149
7d47b580
JB
61502011-07-04 Juanma Barranquero <lekktu@gmail.com>
6151
a555cb87
JB
6152 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6153 (syms_of_gnutls): Remove duplicate DEFSYM for
6154 Qgnutls_bootprop_verify_hostname_error, an error for
6155 Qgnutls_bootprop_verify_error (which is no longer used).
6156
7d47b580
JB
6157 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6158 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6159 Also (re)move comments that are misplaced or no longer relevant.
6160
1e49bfab
LMI
61612011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6162
6163 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6164
1485f4c0
CY
61652011-07-03 Chong Yidong <cyd@stupidchicken.com>
6166
6167 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6168 and background color parameters if they have been changed.
6169
a9ab721e
LMI
61702011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6171
6172 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6173
cf7cff57
PE
61742011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6175
2e13213d
PE
6176 * xsettings.c (SYSTEM_FONT): Define only when used.
6177 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6178
cf7cff57
PE
6179 * keymap.c (access_keymap_1): Now static.
6180
7a8e04f7
CY
61812011-07-02 Chong Yidong <cyd@stupidchicken.com>
6182
6183 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6184 leave any prefix arg for the up event (Bug#1586).
6185
61352f62
LMI
61862011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6187
69bb1ef7
LMI
6188 * lread.c (syms_of_lread): Mention single symbols defined by
6189 `defvar' or `defconst' (bug#7154).
6190
61352f62 6191 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6192 (Frequire): Mention get-load-suffixes.
61352f62 6193
28545e04
MR
61942011-07-02 Martin Rudalics <rudalics@gmx.at>
6195
6196 * window.h (window): Remove clone_number slot.
6197 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6198 Remove.
6199 (make_parent_window, make_window, saved_window)
6200 (Fset_window_configuration, save_window_save): Don't deal with
6201 clone numbers.
6202 * buffer.c (Qclone_number): Remove declaration.
6203 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6204
3349e122
SM
62052011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6206
6207 Add multiple inheritance to keymaps.
6208 * keymap.c (Fmake_composed_keymap): New function.
6209 (Fset_keymap_parent): Simplify.
6210 (fix_submap_inheritance): Remove.
6211 (access_keymap_1): New function extracted from access_keymap to handle
6212 embedded parents and handle lists of maps.
6213 (access_keymap): Use it.
6214 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6215 (Fcopy_keymap): Handle embedded parents.
6216 (Fcommand_remapping, define_as_prefix): Simplify.
6217 (Fkey_binding): Simplify.
6218 (syms_of_keymap): Move minibuffer-local-completion-map,
6219 minibuffer-local-filename-completion-map,
6220 minibuffer-local-must-match-map, and
6221 minibuffer-local-filename-must-match-map to Elisp.
6222 (syms_of_keymap): Defsubr make-composed-keymap.
6223 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6224 (parse_menu_item): Trivial simplification.
6225
3279eb87
GM
62262011-07-01 Glenn Morris <rgm@gnu.org>
6227
6228 * Makefile.in (SETTINGS_LIBS): Fix typo.
6229
4550efdf
KI
62302011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6231
6232 * coding.c (Fencode_coding_string): Record the last coding system
6233 used, as the function doc string says (bug#8738).
6234
0949d2b6
JD
62352011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6236
6237 * xsettings.c (store_monospaced_changed): Take new font as arg and
6238 check for change against current_mono_font.
6239 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6240 (emacs_settings_constructor, emacs_settings_get_property)
6241 (emacs_settings_set_property, emacs_settings_class_init)
6242 (emacs_settings_init, gsettings_obj): Remove.
6243 (something_changedCB): New function for HAVE_GSETTINGS.
6244 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6245 with value as argument.
6246 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6247 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6248 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6249 "changed".
6250
6251 * xgselect.c: Add defined (HAVE_GSETTINGS).
6252 (xgselect_initialize): Ditto.
6253
6254 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6255 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6256 xg_select.
6257
bbc6b304
PE
62582011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6259
6260 * eval.c (struct backtrace): Simplify and port the data structure.
6261 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6262 signed bit field, as this assumption is not portable and it makes
6263 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6264 "char debug_on_exit : 1" as this is not portable either; instead,
6265 use the portable "unsigned int debug_on_exit : 1". Remove unused
6266 member evalargs. Remove obsolete comments about cc bombing out.
6267
9851bfc5
JD
62682011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6269
51bb811f 6270 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6271 Let HAVE_GSETTINGS override HAVE_GCONF.
6272 (store_monospaced_changed): New function.
6273 (EMACS_SETTINGS): A new type derived from GObject to handle
6274 GSettings notifications.
6275 (emacs_settings_constructor, emacs_settings_get_property)
6276 (emacs_settings_set_property, emacs_settings_class_init):
6277 New functions.
6278 (gsettings_client, gsettings_obj): New variables.
6279 (GSETTINGS_SCHEMA): New define.
6280 (something_changedCB): Call store_monospaced_changed.
6281 (init_gsettings): New function.
6282 (xsettings_initialize): Call init_gsettings.
6283 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6284 to NULL.
6285
640c8776 6286 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6287 GCONF_CFLAGS/LIBS.
6288
5386012d
MR
62892011-06-29 Martin Rudalics <rudalics@gmx.at>
6290
6291 * window.c (resize_root_window, grow_mini_window)
6292 (shrink_mini_window): Rename Qresize_root_window to
6293 Qwindow_resize_root_window and Qresize_root_window_vertically to
6294 Qwindow_resize_root_window_vertically.
6295
f13e0b08
PE
62962011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6297
6298 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6299
94515237
JB
63002011-06-27 Juanma Barranquero <lekktu@gmail.com>
6301
6302 * makefile.w32-in: Redesign dependencies so they reflect more
6303 clearly which files are directly included by each source file,
6304 and not through other includes.
6305
e43b6e43
MR
63062011-06-27 Martin Rudalics <rudalics@gmx.at>
6307
6308 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6309 (sort_overlays, overlay_strings): When an overlay's clone number
6310 matches the window's clone number process the overlay even if
6311 the overlay's window property doesn't match the current window.
6312
d68443dc
MR
6313 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6314 (Fwindow_hchild): Rename to Fwindow_left_child.
6315 (Fwindow_next): Rename to Fwindow_next_sibling.
6316 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6317 (resize_window_check): Rename to window_resize_check.
6318 (resize_window_apply): Rename to window_resize_apply.
6319 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6320 (Fdelete_other_windows_internal, resize_frame_windows)
6321 (Fsplit_window_internal, Fdelete_window_internal)
6322 (grow_mini_window, shrink_mini_window)
6323 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6324
c7e73be5
JD
63252011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6326
6327 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6328 (emacs_fixed_set_min_size): Remove.
6329 (emacs_fixed_new): Take frame as argument.
6330
6331 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6332 (_EmacsFixedPrivate): Remove minwidth/height.
6333 Add struct frame *f.
6334 (emacs_fixed_init): Initialize priv->f.
6335 (get_parent_class, emacs_fixed_set_min_size): Remove.
6336 (emacs_fixed_new): Set priv->f to argument.
6337 (emacs_fixed_get_preferred_width)
6338 (emacs_fixed_get_preferred_height): Use min_width/height from
6339 frames size_hint to set minimum and natural (Bug#8919).
6340 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6341 and use min_width/height from frames size_hint to set
6342 min_width/height (Bug#8919).
6343
6344 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6345 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6346 Fix indentation.
c7e73be5 6347
cf99dcf8
EZ
63482011-06-26 Eli Zaretskii <eliz@gnu.org>
6349
6350 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6351 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6352 called at ZV.
6353
029529ac
CY
63542011-06-26 Chong Yidong <cyd@stupidchicken.com>
6355
6356 * process.c (wait_reading_process_output): Bypass select if
6357 waiting for a cell while ignoring keyboard input, and input is
6358 pending. Suggested by Jan Djärv (Bug#8869).
6359
7a7ef429
PE
63602011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6361
6362 Use gnulib's dup2 module instead of rolling our own.
6363 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6364
11fdef7d 63652011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6366
6367 * dispnew.c (scrolling_window): Before scrolling, turn off a
6368 mouse-highlight in the window being scrolled.
6369
cd3520a4
JB
63702011-06-24 Juanma Barranquero <lekktu@gmail.com>
6371
6372 Move DEFSYM to lisp.h and use everywhere.
6373
6374 * character.h (DEFSYM): Move declaration...
6375 * lisp.h (DEFSYM): ...here.
6376
6377 * gnutls.c:
6378 * minibuf.c:
6379 * w32menu.c:
6380 * w32proc.c:
6381 * w32select.c: Don't include character.h.
6382
6383 * alloc.c (syms_of_alloc):
6384 * buffer.c (syms_of_buffer):
6385 * bytecode.c (syms_of_bytecode):
6386 * callint.c (syms_of_callint):
6387 * casefiddle.c (syms_of_casefiddle):
6388 * casetab.c (init_casetab_once):
6389 * category.c (init_category_once, syms_of_category):
6390 * ccl.c (syms_of_ccl):
6391 * cmds.c (syms_of_cmds):
6392 * composite.c (syms_of_composite):
6393 * dbusbind.c (syms_of_dbusbind):
6394 * dired.c (syms_of_dired):
6395 * dispnew.c (syms_of_display):
6396 * doc.c (syms_of_doc):
6397 * editfns.c (syms_of_editfns):
6398 * emacs.c (syms_of_emacs):
6399 * eval.c (syms_of_eval):
6400 * fileio.c (syms_of_fileio):
6401 * fns.c (syms_of_fns):
6402 * frame.c (syms_of_frame):
6403 * fringe.c (syms_of_fringe):
6404 * insdel.c (syms_of_insdel):
6405 * keymap.c (syms_of_keymap):
6406 * lread.c (init_obarray, syms_of_lread):
6407 * macros.c (syms_of_macros):
6408 * msdos.c (syms_of_msdos):
6409 * print.c (syms_of_print):
6410 * process.c (syms_of_process):
6411 * search.c (syms_of_search):
6412 * sound.c (syms_of_sound):
6413 * syntax.c (init_syntax_once, syms_of_syntax):
6414 * terminal.c (syms_of_terminal):
6415 * textprop.c (syms_of_textprop):
6416 * undo.c (syms_of_undo):
6417 * w32.c (globals_of_w32):
6418 * window.c (syms_of_window):
6419 * xdisp.c (syms_of_xdisp):
6420 * xfaces.c (syms_of_xfaces):
6421 * xfns.c (syms_of_xfns):
6422 * xmenu.c (syms_of_xmenu):
6423 * xsettings.c (syms_of_xsettings):
6424 * xterm.c (syms_of_xterm): Use DEFSYM.
6425
4228cf16
TZ
64262011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6427
cd3520a4 6428 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6429
7fcccf1e
PE
64302011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6431
7efb4e0e
PE
6432 Integer and buffer overflow fixes (Bug#8873).
6433
ff5844ad
PE
6434 * print.c (printchar, strout): Check for string overflow.
6435 (PRINTPREPARE, printchar, strout):
6436 Don't set size unless allocation succeeds.
6437
90532f02
PE
6438 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6439 for sizes. Check for string overflow more accurately.
6440 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6441
6d84508d
PE
6442 * macros.c: Integer and buffer overflow fixes.
6443 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6444 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6445 Use ptrdiff_t, not int, for sizes.
6446 Don't increment bufsize until after realloc succeeds.
6447 Check for size-calculation overflow.
6448 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6449
437b2cb4
PE
6450 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6451
8b9ac8b4
PE
6452 * lread.c: Integer overflow fixes.
6453 (read_integer): Radix is now EMACS_INT, not int,
6454 to improve quality of diagnostics for out-of-range radices.
6455 Calculate buffer size correctly for out-of-range radices.
6456 (read1): Check for integer overflow in radices, and in
6457 read-circle numbers.
82cb60d3
PE
6458 (read_escape): Avoid int overflow.
6459 (Fload, openp, read_buffer_size, read1)
6460 (substitute_object_recurse, read_vector, read_list, map_obarray):
6461 Use ptrdiff_t, not int, for sizes.
6462 (read1): Use EMACS_INT, not int, for sizes.
20270765 6463 Check for size overflow.
8b9ac8b4 6464
7fcccf1e
PE
6465 * image.c (cache_image): Check for size arithmetic overflow.
6466
bfbbd7e7
PE
6467 * lread.c: Integer overflow issues.
6468 (saved_doc_string_size, saved_doc_string_length)
6469 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6470 Now ptrdiff_t, not int.
6471 (read1): Don't assume doc string length fits in int. Check for
6472 out-of-range doc string lengths.
6473 (read_list): Don't assume file position fits in int.
39019e54 6474 (read_escape): Check for hex character overflow.
bfbbd7e7 6475
4e323265
LL
64762011-06-22 Leo Liu <sdl.web@gmail.com>
6477
6478 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6479 Move to minibuffer.el.
6480
85fece3e
PE
64812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6482
20b84ce9 6483 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6484 The following patches are for when GLYPH_DEBUG && !XASSERT.
6485 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6486 * dispnew.c (flush_stdout):
6487 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6488 Mark as externally visible.
6489 * dispnew.c (check_window_matrix_pointers): Now static.
6490 * dispnew.c (window_to_frame_vpos):
6491 * xfns.c (unwind_create_frame):
6492 * xterm.c (x_check_font): Remove unused local.
6493 * scroll.c (CHECK_BOUNDS):
6494 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6495 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6496 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6497 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6498 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6499 Now static.
6500 (debug_method_add): Use va_list and vsprintf rather than relying
6501 on undefined behavior with wrong number of arguments.
6502 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6503 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6504 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6505 since we're not interested in debugging glyphs with old libraries.
6506 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6507 GCC 4.6.0's static checking.
6508
0766b489
PE
65092011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6510
31fd4b32
PE
6511 Integer overflow and signedness fixes (Bug#8873).
6512 A few related buffer overrun fixes, too.
6513
b79e8648
PE
6514 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6515
0766b489
PE
6516 * dispextern.h (struct face.stipple):
6517 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6518 (x_bitmap_mask, x_allocate_bitmap_record)
6519 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6520 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6521 (x_create_bitmap_from_xpm_data):
6522 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6523 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6524 (.bitmaps_last):
6525 * xfaces.c (load_pixmap):
6526 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6527 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6528 (.bitmaps_last, struct x_output.icon_bitmap):
6529 Use ptrdiff_t, not int, for bitmap indexes.
6530 (x_allocate_bitmap_record): Check for size overflow.
6531 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6532
b081724f
PE
6533 Use ptrdiff_t, not int, for overlay counts.
6534 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6535 * editfns.c (overlays_around, get_pos_property):
6536 * textprop.c (get_char_property_and_overlay):
6537 * xdisp.c (next_overlay_change, note_mouse_highlight):
6538 * xfaces.c (face_at_buffer_position):
21514da7
PE
6539 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6540 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6541 (Fnext_overlay_change, Fprevious_overlay_change)
6542 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6543 Use ptrdiff_t, not int, for sizes.
21514da7 6544 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6545
3de73e5e
PE
6546 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6547
2606c57b
PE
6548 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6549 (x_session_initialize): Do not assume string length fits in int.
6550
aaafe47a
PE
6551 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6552 This is unlikely, but can occur if DPI is outlandish.
6553
2674ddc8 6554 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6555 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6556
28154962
PE
6557 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6558 * xrdb.c (magic_file_p, search_magic_path):
6559 Omit last arg SUFFIX; it was always 0. All callers changed.
6560 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6561
7de51af5
PE
6562 * xfont.c (xfont_match): Avoid need for strlen.
6563
25ed6cc3
PE
6564 * xfns.c: Don't assume strlen fits in int.
6565 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6566
4eab31dd
PE
6567 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6568 not unsigned long, as we prefer signed integers. All callers changed.
6569 Detect integer overflow in repeat count.
6570 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6571 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6572
171e2a58
PE
6573 * termcap.c: Don't assume sizes fit in int and never overflow.
6574 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6575 (gobble_line): Check for size-calculation overflow.
6576
ad39faca 6577 * minibuf.c (Fread_buffer):
6e5bb2dc 6578 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6579 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6580 Don't assume string length fits in int.
6581
52c61c22 6582 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6583 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6584
b5b8c9e5
PE
6585 * font.c: Don't assume string length fits in int.
6586 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6587 Use ptrdiff_t, not int.
ccd6111c
PE
6588 (font_intern_prop): Don't assume string length fits in int.
6589 Don't assume integer property fits in fixnum.
6590 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6591
882f0d81 6592 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6593 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6594 Reformulate so as not to need the command string.
6595 Invoke gzip -cd rather than gunzip, as it's more portable.
6596 (lock_info_type, lock_file_1, lock_file):
6597 Don't assume pid_t and time_t fit in unsigned long.
6598 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6599 (current_lock_owner): Prefer signed type for sizes.
6600 Use memcpy, not strncpy, where memcpy is what is really wanted.
6601 Don't assume (via atoi) that time_t and pid_t fit in int.
6602 Check for time_t and/or pid_t out of range, e.g., via a network share.
6603 Don't alloca where an auto var works fine.
6604
93f4cf88
PE
6605 * fileio.c: Fix some integer overflow issues.
6606 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6607 Don't assume string length fits in int.
6608 (directory_file_name): Don't assume string length fits in long.
6609 (make_temp_name): Don't assume pid fits in int, or that its print
6610 length is less than 20.
6611
f3e92b69
PE
6612 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6613
1bfdaf10
PE
6614 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6615
35016e9a
PE
6616 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6617
3d1e65a1
PE
6618 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6619 We prefer signed integers, even for size calculations.
6620
0b963a93
PE
6621 * emacs.c: Don't assume string length fits in 'int'.
6622 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6623 (main): Don't invoke strlen when not needed.
6624
573f4b54
PE
6625 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6626 (XD_DEBUG_MESSAGE): Don't waste a byte.
6627
989f33ba
PE
6628 * callproc.c (getenv_internal_1, getenv_internal)
6629 (Fgetenv_internal):
965d34eb
PE
6630 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6631
e4d29b33
PE
6632 * lread.c (invalid_syntax): Omit length argument.
6633 All uses changed. This doesn't fix a bug, but it simplifies the
6634 code away from its former Hollerith-constant appearance, and it's
6635 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6636 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6637
eb49b136
PE
6638 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6639 This didn't break anything, but it didn't help either.
6640 It's confusing to put a bogus integer in a place where the actual
6641 value does not matter.
9f62aeb1 6642 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6643 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6644
15375a22
PE
6645 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6646 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6647 implementation.
b61cc01c
PE
6648 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6649 We prefer signed types, and the value cannot exceed the EMACS_INT
6650 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6651 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6652 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6653 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6654
53b2623d
PE
6655 * indent.c (sane_tab_width): New function.
6656 (current_column, scan_for_column, Findent_to, position_indentation)
6657 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6658 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6659
51cab52b 6660 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6661
f2ed8a70
PE
6662 * lisp.h (lint_assume): New macro.
6663 * composite.c (composition_gstring_put_cache):
6664 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6665
abe80cc6
PE
6666 * editfns.c, insdel.c:
6667 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6668
b02c740e
PE
6669 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6670
ebc96716
PE
6671 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6672
b4e50fa0 6673 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6674 Use much-faster test for byte-length change.
311d5d7c 6675 Don't assume string byte-length fits in 'int'.
a4cf38e4 6676 Check that character arg fits in 'int'.
85461888 6677 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6678
c0c1ee9f
PE
6679 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6680
a498d7f4
PE
6681 * fns.c (concat): Catch string overflow earlier.
6682 Do not rely on integer wraparound.
6683
51cab52b
PE
6684 * dispextern.h (struct it.overlay_strings_charpos)
6685 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6686 * xdisp.c (forward_to_next_line_start)
6687 (back_to_previous_visible_line_start)
6688 (reseat_at_next_visible_line_start, next_element_from_buffer):
6689 Don't arbitrarily truncate the value of 'selective' to int.
6690
76031fad
PE
6691 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6692
5eb55db9
PE
6693 * composite.c: Don't truncate sizes to 'int'.
6694 (composition_gstring_p, composition_reseat_it)
6695 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6696 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6697 not EMACS_UINT, for indexes.
5eb55db9 6698
0703a717
PE
6699 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6700
d6202519
PE
6701 * buffer.c: Include <verify.h>.
6702 (struct sortvec.priority, struct sortstr.priority):
8961a454 6703 Now EMACS_INT, not int.
c20998a7 6704 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6705 (struct sortstr.size, record_overlay_string)
6706 (struct sortstrlist.size, struct sortlist.used):
6707 Don't truncate size to int.
6708 (record_overlay_string): Check for size-calculation overflow.
d6202519 6709 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6710
d5a19415
JM
67112011-06-22 Jim Meyering <meyering@redhat.com>
6712
029529ac 6713 Don't leak an XBM-image-sized buffer
d5a19415
JM
6714 * image.c (xbm_load): Free the image buffer after using it.
6715
a9041e6c
PE
67162011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6717
6718 Port to Sun C.
6719 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6720 that Sun C diagnosed.
6721 * fns.c (secure_hash): Fix pointer signedness issue.
6722 * intervals.c (static_offset_intervals): New function.
6723 (offset_intervals): Use it.
6724
7f3f739f
LL
67252011-06-21 Leo Liu <sdl.web@gmail.com>
6726
6727 * deps.mk (fns.o):
6728 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6729 sha512.h.
6730
6731 * fns.c (secure_hash): Rename from crypto_hash_function and change
6732 the first arg to accept symbols.
5b66d427 6733 (Fsecure_hash): New primitive.
7f3f739f
LL
6734 (syms_of_fns): New symbols.
6735
76147d94
DD
67362011-06-20 Deniz Dogan <deniz@dogan.se>
6737
6738 * process.c (Fset_process_buffer): Clarify return value in
6739 docstring.
6740
7d7d0045
CY
67412011-06-18 Chong Yidong <cyd@stupidchicken.com>
6742
6743 * dispnew.c (add_window_display_history): Use BVAR.
6744
6745 * xdisp.c (debug_method_add): Use BVAR.
6746 (check_window_end, dump_glyph_matrix, dump_glyph)
6747 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6748
6749 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6750 Likewise.
6751
6752 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6753 check till after the cache is created in init_frame_faces.
6754
ff2bc410
SM
67552011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6756
6757 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6758
28177add
PE
67592011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6760
dd3482fe
PE
6761 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6762 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6763 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6764
393d71f3 6765 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
6766 * fileio.c (Finsert_file_contents):
6767 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6768 Remove the old (too-loose) buffer overflow checks.
6769 They weren't needed, since make_gap checks for buffer overflow.
6770 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6771 The old code merely checked for Emacs fixnum overflow, and relied
6772 on undefined (wraparound) behavior. The new code avoids undefined
6773 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6774
2e6813b0 6775 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
6776 Tune. Don't use wider integers than needed. Don't use alloca.
6777 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6778
599a9e4f
PE
6779 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6780
99561444
PE
6781 * insdel.c, lisp.h (buffer_overflow): New function.
6782 (insert_from_buffer_1, replace_range, replace_range_2):
6783 * insdel.c (make_gap_larger):
6784 * editfns.c (Finsert_char):
6785 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6786
28177add
PE
6787 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6788
e69dafad
PE
67892011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6790
4baa020d 6791 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 6792
b1c46f02
PE
6793 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6794 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6795
e69dafad
PE
6796 * fileio.c: Don't assume EMACS_INT fits in off_t.
6797 (emacs_lseek): New static function.
6798 (Finsert_file_contents, Fwrite_region): Use it.
6799 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6800
566684ea
PE
6801 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6802
e6966cd6
PE
6803 * fns.c: Don't overflow int when computing a list length.
6804 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6805 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6806 truncation on 64-bit hosts. Check for QUIT every
6807 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6808 faster and is responsive enough.
6809 (Flength): Report an error instead of overflowing an integer.
6810 (Fsafe_length): Return a float if the value is not representable
6811 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 6812 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 6813 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 6814
dd0b0efb
PE
6815 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6816 (header_size, word_size): New constants.
6817 (allocate_vectorlike): Don't check size overflow here.
6818 (allocate_vector): Check it here instead, since this is the only
6819 caller of allocate_vectorlike that could cause overflow.
6820 Check that the new vector's length is representable as a fixnum.
6821
86fe5cfe
PE
6822 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6823 The previous code was bogus. For example, next_almost_prime (32)
6824 returned 39, which is undesirable as it is a multiple of 3; and
6825 next_almost_prime (24) returned 25, which is a multiple of 5 so
6826 why was the code bothering to check for multiples of 7?
6827
80e88859
PE
6828 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6829
4a2f0ad6
PE
6830 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6831
f66c7cf8
PE
6832 Variadic C functions now count arguments with ptrdiff_t.
6833 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6834 Back then I didn't know that the Emacs coding style prefers signed int.
6835 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
6836 were being counted with int, which may truncate counts on 64-bit
6837 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
6838 * lisp.h (struct Lisp_Subr.function.aMANY)
6839 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6840 Arg counts are now ptrdiff_t, not size_t.
6841 All variadic functions and their callers changed accordingly.
6842 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6843 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6844 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6845 * callint.c (Fcall_interactively): Check arg count for overflow,
6846 to avoid potential buffer overrun. Use signed char, not 'int',
6847 for 'varies' array, so that we needn't bother to check its size
6848 calculation for overflow.
6849 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6850 * eval.c (apply_lambda):
6851 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6852 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6853 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6854
a1759b76
PE
6855 * callint.c (Fcall_interactively): Don't use index var as event count.
6856
d96be9fc
PE
6857 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6858 * mem-limits.h (SIZE): Remove; no longer used.
6859
a690a978 6860 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 6861
578c21e6
PE
6862 Remove unnecessary casts.
6863 * xterm.c (x_term_init):
6864 * xfns.c (x_set_border_pixel):
6865 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6866 These aren't needed now that we assume ANSI C.
6867
96f53c6c
PE
6868 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6869 It's more likely to cause problems (due to unsigned overflow)
6870 than to cure them.
6871
83c77d31
PE
6872 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6873
ee2079f1
PE
6874 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6875
6da65536
PE
6876 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6877
7147c4a4
PE
6878 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6879
193e32d9
PE
6880 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6881
e5533da6
PE
6882 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6883
9910e595
PE
6884 GLYPH_CODE_FACE returns EMACS_INT, not int.
6885 * dispextern.h (merge_faces):
6886 * xfaces.c (merge_faces):
01103c44
PE
6887 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6888 Don't assume EMACS_INT fits in int.
9910e595 6889
2638320e
PE
6890 * character.h (CHAR_VALID_P): Remove unused parameter.
6891 * fontset.c, lisp.h, xdisp.c: All uses changed.
6892
045eb8d9
PE
6893 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6894
c1f134b5
PE
6895 * fns.c (concat): Minor tuning based on overflow analysis.
6896 This doesn't fix any bugs. Use int to hold character, instead
6897 of constantly refetching from Emacs object. Use XFASTINT, not
6898 XINT, for value known to be a character. Don't bother comparing
6899 a single byte to 0400, as it's always less.
6900
395fcb93 6901 * floatfns.c (Fexpt):
327eeec8
PE
6902 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6903
abbd3d23
PE
6904 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6905 for characters.
6906
684a03ef
PE
6907 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6908
0fed43f3
PE
6909 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6910 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6911 incorrectly succeed when S was a string, because 4294967386 was
6912 truncated before it was used.
6913
8fd02eb7
PE
6914 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6915 Otherwise, an out-of-range integer could cause undefined behavior
6916 on a 64-bit host.
6917
f8c86b69
PE
6918 * composite.c: Use int, not EMACS_INT, for characters.
6919 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6920 EMACS_INT, for values that are known to be in character range.
6921 This doesn't fix any bugs but is the usual style inside Emacs and
6922 may generate better code on 32-bit machines.
6923
34206dd2
PE
6924 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6925 This is for reasons similar to the recent CHAR_STRING fix.
6926 * charset.c (Fencode_char): Check that character arg is actually
6927 a character. Pass an int to ENCODE_CHAR.
6928 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6929 wider than 'int', as a compile-time check to prevent future regressions
6930 in this area.
6931
c5958d4c 6932 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
6933
6934 Make sure a 64-bit char is never passed to CHAR_STRING.
6935 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6936 by silently ignoring the top 32 bits, allowing some values
6937 that were far too large to be valid characters.
6938 * character.h: Include <verify.h>.
6939 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6940 arguments are no wider than unsigned, as a compile-time check
6941 to prevent future regressions in this area.
6942 * data.c (Faset):
01103c44 6943 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
6944 (Fsubst_char_in_region):
6945 * fns.c (concat):
6946 * xdisp.c (decode_mode_spec_coding):
6947 Adjust to CHAR_STRING's new requirement.
6948 * editfns.c (Finsert_char, Fsubst_char_in_region):
6949 * fns.c (concat): Check that character args are actually
6950 characters. Without this test, these functions did the wrong
6951 thing with wildly out-of-range values on 64-bit hosts.
6952
d37ca623
PE
6953 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6954 These casts should not be needed on 32-bit hosts, either.
6955 * keyboard.c (read_char):
6956 * lread.c (Fload): Remove casts to unsigned.
6957
ea204efb
PE
6958 * lisp.h (UNSIGNED_CMP): New macro.
6959 This fixes comparison bugs on 64-bit hosts.
6960 (ASCII_CHAR_P): Use it.
6961 * casefiddle.c (casify_object):
01103c44 6962 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
6963 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6964 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6965 * dispextern.h (FACE_FROM_ID):
6966 * keyboard.c (read_char): Use UNSIGNED_CMP.
6967
41cb286c
PE
6968 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6969 not to EMACS_INT, to avoid GCC warning.
6970
4a1b9832
PE
6971 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6972
55daad71
PE
6973 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6974 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6975 isn't needed on 32-bit machines.
8f95c75c 6976
01103c44
PE
6977 * buffer.c (Fgenerate_new_buffer_name):
6978 Use EMACS_INT for count, not int.
0ceccced 6979 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
6980
6981 * data.c (Qcompiled_function): Now static.
6982
c6f072e7
PE
6983 * window.c (window_body_lines): Now static.
6984
20ce5912
PE
6985 * image.c (gif_load): Rename local to avoid shadowing.
6986
9c4c5f81
PE
6987 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6988 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6989 * alloc.c (make_save_value): Integer argument is now of type
6990 ptrdiff_t, not int.
6991 (mark_object): Use ptrdiff_t, not int.
6992 * lisp.h (pD): New macro.
6993 * print.c (print_object): Use it.
6994
c0c5c8ae
PE
6995 * alloc.c: Use EMACS_INT, not int, to count objects.
6996 (total_conses, total_markers, total_symbols, total_vector_size)
6997 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
6998 (total_free_floats, total_floats, total_free_intervals)
6999 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7000 Now EMACS_INT, not int. All uses changed.
7001 (Fgarbage_collect): Compute overall total using a double, so that
7002 integer overflow is less likely to be a problem. Check for overflow
7003 when converting back to an integer.
5a25e253
PE
7004 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7005 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7006 These were 'int' variables that could overflow on 64-bit hosts;
7007 they were never used, so remove them instead of repairing them.
211a0b2a 7008 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7009 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7010 Previously, this ceilinged at INT_MAX, but that doesn't work on
7011 64-bit machines.
e46bb31a 7012 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7013
c78baabf 7014 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7015 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7016 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7017 when a (possibly-narrower) signed value would do just as well.
7018 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7019
c9d624c6
PE
7020 * alloc.c: Catch some string size overflows that we were missing.
7021 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7022 for convenience in STRING_BYTES_MAX.
7023 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7024 The definition here is exact; the one in lisp.h was approximate.
7025 (allocate_string_data): Check for string overflow. This catches
7026 some instances we weren't catching before. Also, it catches
7027 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7028 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7029 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7030
c9d624c6
PE
7031 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7032 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7033 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7034
353032ce
PE
7035 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7036
2bccce07
PE
7037 * alloc.c (Fmake_string): Check for out-of-range init.
7038
0ac30604
SM
70392011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7040
7041 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7042
c195f2de
JD
70432011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7044
7045 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7046 xg_get_default_scrollbar_width.
7047
7048 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7049 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7050 (style_changed_cb): Call update_theme_scrollbar_width and call
7051 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7052 all frames (Bug#8505).
7053 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7054 Call gtk_window_set_resizable if HAVE_GTK3.
7055 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7056 and height if HAVE_GTK3 (Bug#8505).
7057 (scroll_bar_width_for_theme): New variable.
7058 (update_theme_scrollbar_width): New function.
7059 (xg_get_default_scrollbar_width): Move code to
7060 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7061 (xg_initialize): Call update_theme_scrollbar_width.
7062
7063 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7064
7065 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7066
e10ac9f1
MR
70672011-06-12 Martin Rudalics <rudalics@gmx.at>
7068
7069 * frame.c (make_frame): Call other_buffer_safely instead of
7070 other_buffer.
7071
7072 * window.c (temp_output_buffer_show): Call display_buffer with
7073 second argument Vtemp_buffer_show_specifiers and reset latter
7074 immediately after the call.
7075 (Vtemp_buffer_show_specifiers): New variable.
7076 (auto_window_vscroll_p, next_screen_context_lines)
7077 (Vscroll_preserve_screen_position): Remove leading asterisks from
7078 doc-strings.
7079
2d3c217e 70802011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7081
7b7f97e8 7082 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7083 * buffer.c (Qclone_number): Remove for now, as it's unused.
7084 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7085 (record_buffer): Remove unused local.
7086 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7087 (set_frame_buffer_list): Remove; unused.
7088 * frame.h (other_visible_frames): Remove decl.
7089 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7090 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7091 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7092 if HAVE_GPM.
7093 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7094 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7095 Define only if HAVE_GPM.
7096 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7097 (update_hints_inhibit): Remove; never set. All uses removed.
7098 * widgetprv.h (emacsFrameClassRec): Remove decl.
7099 * window.c (delete_deletable_window): Now returns void, since it
7100 wasn't returning anything.
7101 (compare_window_configurations): Remove unused locals.
7102 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7103 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7104 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7105 the same widths as pointers. This follows up on the 2011-05-06 patch.
7106 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7107 * xterm.h: Likewise.
7108 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7109
1384b89e
JB
71102011-06-12 Juanma Barranquero <lekktu@gmail.com>
7111
7112 * makefile.w32-in: Update dependencies.
7113 (LISP_H): Add lib/intprops.h.
7114
1100a63c
CY
71152011-06-11 Chong Yidong <cyd@stupidchicken.com>
7116
7117 * image.c (gif_load): Add animation frame delay to the metadata.
7118 (syms_of_image): Use DEFSYM. New symbol `delay'.
7119
6198ccd0
MR
71202011-06-11 Martin Rudalics <rudalics@gmx.at>
7121
7122 * window.c (delete_deletable_window): Re-add.
7123 (Fset_window_configuration): Rewrite to handle dead buffers and
7124 consequently deletable windows.
7125 (window_tree, Fwindow_tree): Remove. Supply functionality in
7126 window.el.
7127 (compare_window_configurations): Simplify code.
7128
b6e3633c
AS
71292011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7130
1ab0dee5
AS
7131 * image.c (imagemagick_load_image): Fix type mismatch.
7132 (Fimagemagick_types): Likewise.
7133
b6e3633c
AS
7134 * window.h (replace_buffer_in_windows): Declare.
7135
9397e56f
MR
71362011-06-11 Martin Rudalics <rudalics@gmx.at>
7137
7138 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7139 Qclone_number. Remove external declaration of Qdelete_window.
7140 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7141 code.
640c8776
SM
7142 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7143 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7144 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7145 buffer list implementation.
7146 (other_buffer_safely): New function.
7147 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7148 calls to replace_buffer_in_windows and
7149 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7150 if allowed.
7151 (record_buffer): Inhibit quitting and rewrite using quittable
7152 functions. Run Qbuffer_list_update_hook if allowed.
7153 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7154 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7155 Move switch-to-buffer to window.el.
9397e56f
MR
7156 (bury-buffer): Move to window.el.
7157 (Vbuffer_list_update_hook): New variable.
7158
7159 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7160 section.
7161
7162 * window.h (resize_frame_windows): Move up in code.
7163 (Fwindow_frame): Remove EXFUN.
7164 (replace_buffer_in_all_windows): Remove prototype.
7165 (replace_buffer_in_windows_safely): Add prototype.
7166
7167 * window.c: Declare Qdelete_window static again. Move down
7168 declaration of select_count.
7169 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7170 (Fother_window): Move to window.el.
7171 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7172 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7173 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7174 window.el.
7175 (replace_buffer_in_windows): Implement by calling
7176 Qreplace_buffer_in_windows.
7177 (replace_buffer_in_all_windows): Remove with some functionality
7178 moved into replace_buffer_in_windows_safely.
7179 (replace_buffer_in_windows_safely): New function.
7180 (select_window_norecord, select_frame_norecord): Move in front
7181 of run_window_configuration_change_hook. Remove now obsolete
7182 declarations.
640c8776
SM
7183 (Fset_window_buffer): Rewrite doc-string.
7184 Call Qrecord_window_buffer.
9397e56f
MR
7185 (keys_of_window): Move binding for other-window to window.el.
7186
b50691aa
CY
71872011-06-11 Chong Yidong <cyd@stupidchicken.com>
7188
7189 * dispextern.h (struct image): Replace data member, whose int_val
7190 and ptr_val fields were not used by anything, with a single
7191 lisp_val object.
7192
7193 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7194 (gif_clear_image, gif_load, imagemagick_load_image)
7195 (gs_clear_image, gs_load): Callers changed.
7196
3f754b86
PE
71972011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7198
cca69397
PE
7199 * buffer.h: Include <time.h>, for time_t.
7200 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7201
109e28d0
PE
7202 Fix minor problems found by static checking.
7203
60737f02
PE
7204 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7205
4b66faf3
PE
7206 Make identifiers static if they are not used in other modules.
7207 * data.c (Qcompiled_function, Qframe, Qvector):
7208 * image.c (QimageMagick, Qsvg):
7209 * minibuf.c (Qmetadata):
7210 * window.c (resize_window_check, resize_root_window): Now static.
7211 * window.h (resize_window_check, resize_root_window): Remove decls.
7212
109e28d0
PE
7213 * window.c (window_deletion_count, delete_deletable_window):
7214 Remove; unused.
46a4ce9e
PE
7215 (window_body_lines): Now static.
7216 (Fdelete_other_windows_internal): Mark vars as initialized.
7217 Make sure 'resize_failed' is initialized.
7218 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7219 (resize_window_apply): Remove unused local.
7220 * window.h (delete_deletable_window): Remove decl.
7221
109e28d0 7222 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7223 (imagemagick_load_image): Fix pointer signedness problem by changing
7224 last arg from unsigned char * to char *. All uses changed.
7225 Also, fix a local for similar reasons.
7226 Remove unused locals. Remove locals to avoid shadowing.
7227 (fn_rsvg_handle_free): Remove; unused.
7228 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7229 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7230
3f754b86
PE
7231 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7232
2547adb1
CY
72332011-06-10 Chong Yidong <cyd@stupidchicken.com>
7234
7235 * image.c (gif_load): Fix omitted cast error introduced by
7236 2011-06-06 change.
7237
2c8e37d4
MR
72382011-06-10 Martin Rudalics <rudalics@gmx.at>
7239
7240 * window.h (resize_proportionally, orig_total_lines)
7241 (orig_top_line): Remove from window structure.
7242 (set_window_height, set_window_width, change_window_heights)
7243 (Fdelete_window): Remove prototypes.
7244 (resize_frame_windows): Remove duplicate declaration.
7245
440a42e3
EZ
72462011-06-10 Eli Zaretskii <eliz@gnu.org>
7247
7248 * window.h (resize_frame_windows, resize_window_check)
7249 (delete_deletable_window, resize_root_window)
7250 (resize_frame_windows): Declare prototypes.
7251
7252 * window.c (resize_window_apply): Make definition be "static" to
7253 match the prototype.
7254
562dd5e9
MR
72552011-06-10 Martin Rudalics <rudalics@gmx.at>
7256
7257 * window.c: Remove declarations of Qwindow_size_fixed,
7258 window_min_size_1, window_min_size_2, window_min_size,
7259 size_window, window_fixed_size_p, enlarge_window, delete_window.
7260 Remove static from declaration of Qdelete_window, it's
7261 temporarily needed by Fbury_buffer.
7262 (replace_window): Don't assign orig_top_line and
7263 orig_total_lines.
7264 (Fdelete_window, delete_window): Remove. Window deletion is
7265 handled by window.el.
640c8776
SM
7266 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7267 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7268 (Fdelete_other_windows): Remove. Deleting other windows is
7269 handled by window.el.
7270 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7271 handled in window.el.
7272 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7273 Window minimum sizes are handled in window.el.
7274 (shrink_windows, size_window, set_window_height)
7275 (set_window_width, change_window_heights, window_height)
7276 (window_width, CURBEG, CURSIZE, enlarge_window)
7277 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7278 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7279 handled in window.el.
7280 (make_dummy_parent): Rename to make_parent_window and give it a
7281 second argument horflag.
7282 (make_window): Don't set resize_proportionally any more.
7283 (Fsplit_window): Remove. Windows are split in window.el.
7284 (save_restore_action, save_restore_orig_size)
7285 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7286 Resize mini windows in window.el.
7287 (grow_mini_window, shrink_mini_window): Implement by calling
7288 Qresize_root_window_vertically, resize_window_check and
7289 resize_window_apply.
640c8776
SM
7290 (saved_window, Fset_window_configuration, save_window_save):
7291 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7292 resize_proportionally.
7293 (window_min_height, window_min_width): Move to window.el.
7294 (keys_of_window): Move bindings for delete-other-windows,
7295 split-window, delete-window and enlarge-window to window.el.
7296
7297 * buffer.c: Temporarily extern Qdelete_window.
7298 (Fbury_buffer): Temporarily call Qdelete_window instead of
7299 Fdelete_window (Fbury_buffer will move to window.el soon).
7300
7301 * frame.c (set_menu_bar_lines_1): Remove code handling
7302 orig_top_line and orig_total_lines.
7303
7304 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7305 set_window_height but set heights directly.
7306 (change_frame_size_1): Use resize_frame_windows.
7307
7308 * xdisp.c (init_xdisp): Don't use set_window_height but set
7309 heights directly.
7310
640c8776
SM
7311 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7312 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7313 run_window_configuration_change_hook.
7314
7315 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7316 instead of change_window_heights and run
7317 run_window_configuration_change_hook.
7318
1a13852e
MR
73192011-06-09 Martin Rudalics <rudalics@gmx.at>
7320
7321 * window.c (replace_window): Rename second argument REPLACEMENT to
7322 NEW. New third argument SETFLAG. Rewrite.
7323 (delete_window, make_dummy_parent): Call replace_window with
7324 third argument 1.
7325 (window_list_1): Move down in code.
7326 (run_window_configuration_change_hook): Move set_buffer part
7327 before select_frame_norecord part in order to unwind correctly.
7328 Rename count1 to count.
7329 (recombine_windows, delete_deletable_window, resize_root_window)
7330 (Fdelete_other_windows_internal)
7331 (Frun_window_configuration_change_hook, make_parent_window)
7332 (resize_window_check, resize_window_apply, Fresize_window_apply)
7333 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7334 (Fdelete_window_internal, Fresize_mini_window_internal):
7335 New functions.
1a13852e
MR
7336 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7337
f3d1777e
MR
73382011-06-08 Martin Rudalics <rudalics@gmx.at>
7339
496e208e
MR
7340 * window.h (window): Add some new members to window structure -
7341 normal_lines, normal_cols, new_total, new_normal, clone_number,
7342 splits, nest, prev_buffers, next_buffers.
7343 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7344 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7345
f3d1777e
MR
7346 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7347 Remove.
496e208e
MR
7348 (make_dummy_parent): Set new members of windows structure.
7349 (make_window): Move down in code. Handle new members of window
7350 structure.
7351 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7352 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7353 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7354 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7355 (Fset_window_next_buffers, Fset_window_clone_number):
7356 New functions.
496e208e
MR
7357 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7358 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7359 Doc-string fixes.
7360 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7361 Argument WINDOW can be now internal window too.
7362 (Fwindow_use_time): Move up in code.
7363 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7364 Rewrite doc-string.
7365 (Fset_window_configuration, saved_window)
7366 (Fcurrent_window_configuration, save_window_save): Handle new
7367 members of window structure.
b9e809c2
MR
7368 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7369 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7370 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7371 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7372 Qget_mru_window, Qresize_root_window,
7373 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7374 Qauto_buffer_name; staticpro them.
f3d1777e 7375
abde8f8c
MR
73762011-06-07 Martin Rudalics <rudalics@gmx.at>
7377
7378 * window.c (Fwindow_total_size, Fwindow_left_column)
7379 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7380 (Fwindow_list_1): New functions.
7381 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7382 (Fwindow_width, Fscroll_left, Fscroll_right):
7383 Use window_body_cols instead of window_box_text_cols.
7384 (delete_window, Fset_window_configuration):
7385 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7386 (delete_all_subwindows): Take a window as argument and not a
7387 structure. Rewrite.
190b47e6
MR
7388 (window_loop): Remove handling of GET_LRU_WINDOW and
7389 GET_LARGEST_WINDOW.
7390 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7391
7392 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7393 window_box_text_cols. delete_all_subwindows now takes a
7394 Lisp_Object as argument.
abde8f8c 7395
640c8776
SM
7396 * indent.c (compute_motion, Fcompute_motion):
7397 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7398
fa8a67e6
MR
7399 * frame.c (delete_frame): Call delete_all_subwindows with root
7400 window as argument.
7401
a54e3482
DC
74022011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7403
7404 * fns.c (Fputhash): Document return value.
7405
60002bf5
CY
74062011-06-06 Chong Yidong <cyd@stupidchicken.com>
7407
7408 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7409
0c671da6 74102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7411
b862a52a 7412 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7413
be44ca6c
PE
7414 Check for overflow when converting integer to cons and back.
7415 * charset.c (Fdefine_charset_internal, Fdecode_char):
7416 Use cons_to_unsigned to catch overflow.
7417 (Fencode_char): Use INTEGER_TO_CONS.
7418 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7419 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7420 * data.c (long_to_cons, cons_to_long): Remove.
7421 (cons_to_unsigned, cons_to_signed): New functions.
7422 These signal an error for invalid or out-of-range values.
7423 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7424 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7425 * font.c (Ffont_variation_glyphs):
7426 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7427 * lisp.h: Include <intprops.h>.
7428 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7429 (cons_to_signed, cons_to_unsigned): New decls.
7430 (long_to_cons, cons_to_long): Remove decls.
7431 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7432 (Fprimitive_undo): Use CONS_TO_INTEGER.
7433 * xfns.c (Fx_window_property): Likewise.
7434 * xselect.c: Include <limits.h>.
7435 (x_own_selection, selection_data_to_lisp_data):
7436 Use INTEGER_TO_CONS.
7437 (x_handle_selection_request, x_handle_selection_clear)
7438 (x_get_foreign_selection, Fx_disown_selection_internal)
7439 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7440 (lisp_data_to_selection_data): Use cons_to_unsigned.
7441 (x_fill_property_data): Use cons_to_signed.
7442 Report values out of range.
7443
d1f3d2af
PE
7444 Check for buffer and string overflow more precisely.
7445 * buffer.h (BUF_BYTES_MAX): New macro.
7446 * lisp.h (STRING_BYTES_MAX): New macro.
7447 * alloc.c (Fmake_string):
7448 * character.c (string_escape_byte8):
7449 * coding.c (coding_alloc_by_realloc):
7450 * doprnt.c (doprnt):
7451 * editfns.c (Fformat):
7452 * eval.c (verror):
7453 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7454 since they may not be the same number.
7455 * editfns.c (Finsert_char):
7456 * fileio.c (Finsert_file_contents):
7457 Likewise for BUF_BYTES_MAX.
7458
dd52fcea
PE
7459 * image.c: Use ptrdiff_t, not int, for sizes.
7460 (slurp_file): Switch from int to ptrdiff_t.
7461 All uses changed.
7462 (slurp_file): Check that file size fits in both size_t (for
7463 malloc) and ptrdiff_t (for sanity and safety).
7464
7f9bbdbb
PE
7465 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7466 if b->modtime has its maximal value.
7467
dfe18f82
PE
7468 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7469
84acfcf0
PE
7470 Don't assume time_t can fit into int.
7471 * buffer.h (struct buffer.modtime): Now time_t, not int.
7472 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7473 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7474
ccd9a01a
PE
7475 Minor fixes for signed vs unsigned integers.
7476 * character.h (MAYBE_UNIFY_CHAR):
7477 * charset.c (maybe_unify_char):
7478 * keyboard.c (read_char, reorder_modifiers):
7479 XINT -> XFASTINT, since the integer must be nonnegative.
7480 * ftfont.c (ftfont_spec_pattern):
7481 * keymap.c (access_keymap, silly_event_symbol_error):
7482 XUINT -> XFASTINT, since the integer must be nonnegative.
7483 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7484 since it makes no difference and we prefer signed.
7485 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7486 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7487 nonnegative.
7488
d6d100dd
SM
74892011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7490
7491 * window.h (Fwindow_frame): Declare.
7492
2b6148e4
PE
74932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7494
7495 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7496 (SPARE_MEMORY): Always define.
7497 (LARGE_REQUEST): Remove.
7498 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7499
f230ecc9
MR
75002011-06-06 Martin Rudalics <rudalics@gmx.at>
7501
727e958e
MR
7502 * lisp.h: Move EXFUNS for Fframe_root_window,
7503 Fframe_first_window and Fset_frame_selected_window to window.h.
7504
7505 * window.h: Move EXFUNS for Fframe_root_window,
7506 Fframe_first_window and Fset_frame_selected_window here from
7507 lisp.h.
7508
7509 * frame.c (Fwindow_frame, Fframe_first_window)
7510 (Fframe_root_window, Fframe_selected_window)
7511 (Fset_frame_selected_window): Move to window.c.
7512 (Factive_minibuffer_window): Move to minibuf.c.
7513 (Fother_visible_frames_p): New function.
7514
7515 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7516
f230ecc9
MR
7517 * window.c (decode_window, decode_any_window): Move up in code.
7518 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7519 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7520 (Fwindow_buffer): Move up and rewrite doc-string.
7521 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7522 (Fwindow_prev): New functions.
727e958e
MR
7523 (Fwindow_frame): Move here from frame.c. Accept any window as
7524 argument.
7525 (Fframe_root_window, Fframe_first_window)
7526 (Fframe_selected_window): Move here from frame.c. Accept frame
7527 or arbitrary window as argument. Update doc-strings.
7528 (Fminibuffer_window): Move up in code.
7529 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7530 (Fset_frame_selected_window): Move here from frame.c.
7531 Marginal rewrite.
727e958e
MR
7532 (Fselected_window, select_window, Fselect_window): Move up in
7533 code. Minor doc-string fixes.
f230ecc9 7534
4d09bcf6
PE
75352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7536
7537 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7538 Do not assume that spare memory exists; that assumption is valid
7539 only if SYSTEM_MALLOC.
7540 (LARGE_REQUEST): New macro, so that the issue of large requests
7541 is separated from the issue of spare memory.
7542
810928a2
AS
75432011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7544
172418ad
AS
7545 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7546 format. (Bug#8806)
7547
43f862f7
AS
7548 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7549
810928a2
AS
7550 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7551 before statements.
7552
a059fe24
JD
75532011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7554
7555 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7556
7557 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7558
7559 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7560 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7561
989bf368
JB
75622011-06-05 Juanma Barranquero <lekktu@gmail.com>
7563
7564 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7565
4b80f674
CY
75662011-06-04 Chong Yidong <cyd@stupidchicken.com>
7567
7568 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7569 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7570 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7571 New error handlers.
4b80f674
CY
7572 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7573 Obey Vx_select_enable_clipboard_manager. Catch errors in
7574 x_clipboard_manager_save (Bug#8779).
7575 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7576 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7577
99a33b77 75782011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7579
7580 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7581
99a33b77 75822011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7583
7584 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7585 in the current matrix if keep_current_p is non-zero.
7586
8264569d
EZ
75872011-06-04 Eli Zaretskii <eliz@gnu.org>
7588
7589 * bidi.c (bidi_level_of_next_char): Fix last change.
7590
57f97249
EZ
75912011-06-03 Eli Zaretskii <eliz@gnu.org>
7592
fec2107c 7593 Support bidi reordering of text covered by display properties.
57f97249 7594
fec2107c
EZ
7595 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7596 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7597 (bidi_cache_search, bidi_cache_iterator_state)
7598 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7599 (bidi_level_of_next_char, bidi_move_to_visually_next):
7600 Support character positions inside a run of characters covered by a
fec2107c
EZ
7601 display string.
7602 (bidi_paragraph_init, bidi_resolve_explicit_1)
7603 (bidi_level_of_next_char): Call bidi_fetch_char and
7604 bidi_fetch_char_advance instead of FETCH_CHAR and
7605 FETCH_CHAR_ADVANCE.
7606 (bidi_init_it): Initialize new members.
7607 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7608 definitions.
7609 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7610 instead of using explicit *_CHAR codes.
d6d100dd
SM
7611 (bidi_resolve_explicit, bidi_resolve_weak):
7612 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7613 bidirectional text is supported only in multibyte buffers.
7614 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7615 it to initialize the frame_window_p member of struct bidi_it.
7616 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7617 (bidi_resolve_explicit, bidi_resolve_weak)
7618 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7619 bidi_it->nchars is non-positive.
7620 (bidi_level_of_next_char): Don't try to lookup the cache for the
7621 next/previous character if nothing is cached there yet, or if we
7622 were just reseat()'ed to a new position.
c40e2fb2 7623
0e14fe90
EZ
7624 * xdisp.c (set_cursor_from_row): Set start and stop points
7625 according to the row's direction when priming the loop that looks
7626 for the glyph on which to display cursor.
7627 (single_display_spec_intangible_p): Function deleted.
7628 (display_prop_intangible_p): Reimplement to call
7629 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7630 Accept 3 additional arguments needed by handle_display_spec.
7631 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7632 values: lists, `(when COND...)' forms, etc.
7633 (single_display_spec_string_p): Support property values that are
7634 lists with the argument STRING its top-level element.
7635 (display_prop_string_p): Fix the condition for processing a
7636 property that is a list to be consistent with handle_display_spec.
fec2107c 7637 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7638 last portion of handle_display_prop.
7639 (compute_display_string_pos): Accept additional argument
7640 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7641 value of a `display' property is a "replacing spec".
7642 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7643 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7644 the display property, but just return a value indicating whether
7645 the display property will replace the characters it covers.
7646 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7647 frame_window_p members of struct bidi_it.
d6d100dd
SM
7648 (compute_display_string_pos, compute_display_string_end):
7649 New functions.
fec2107c
EZ
7650 (push_it): Accept second argument POSITION, where pop_it should
7651 jump to continue iteration.
7652 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7653
fec2107c
EZ
7654 * keyboard.c (adjust_point_for_property): Adjust the call to
7655 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7656
7657 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7658 (bidi_init_it): Update prototypes.
7659 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7660 (compute_display_string_pos, compute_display_string_end):
7661 Declare prototypes.
fec2107c
EZ
7662 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7663 EMACS_INT.
fc6f18ce 7664
40087514 76652011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7666
57f53182
PE
7667 Malloc failure behavior now depends on size of allocation.
7668 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7669 * lisp.h: Change signatures accordingly.
7670 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7671 All callers changed. (Bug#8762)
7672
7673 * gnutls.c: Use Emacs's memory allocators.
7674 Without this change, the gnutls library would invoke malloc etc.
7675 directly, which causes problems on non-SYNC_INPUT hosts, and which
7676 runs afoul of improving memory_full behavior. (Bug#8761)
7677 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7678 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7679 xfree instead of the default malloc, realloc, free.
7680 (Fgnutls_boot): No need to check for memory allocation failure,
7681 since xmalloc does that for us.
7682
ac32cd99 7683 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7684 * category.c (hash_get_category_set):
7685 * ccl.c (ccl_driver):
7686 * charset.c (Fdefine_charset_internal):
7687 * charset.h (struct charset.hash_index):
7688 * composite.c (get_composition_id, gstring_lookup_cache)
7689 (composition_gstring_put_cache):
7690 * composite.h (struct composition.hash_index):
7691 * dispextern.h (struct image.hash):
7692 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7693 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7694 (hashfn_equal, hashfn_user_defined, make_hash_table)
7695 (maybe_resize_hash_table, hash_lookup, hash_put)
7696 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7697 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7698 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7699 * image.c (make_image, search_image_cache, lookup_image)
7700 (xpm_put_color_table_h):
7701 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7702 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7703 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7704 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7705 * alloc.c (allocate_vectorlike):
7706 Check for overflow in vector size calculations.
7707 * ccl.c (ccl_driver):
7708 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7709 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7710 need to be updated by these changes.
40087514
PE
7711 * fns.c (make_hash_table, maybe_resize_hash_table):
7712 Check for integer overflow with large hash tables.
0de4bb68
PE
7713 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7714 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7715 (SXHASH_REDUCE): New macro.
7716 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7717 Use it instead of discarding useful hash info with large hash values.
7718 (sxhash_float): New function.
7719 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7720 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7721 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7722 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7723 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7724 Adjust signatures to match updated version of code.
7725 (consing_since_gc): Now EMACS_INT, since a single hash table can
7726 use more than INT_MAX bytes.
7727
698d32e2
DN
77282011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7729
7730 Make it possible to build with GCC-4.6+ -O2 -flto.
7731
7732 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7733
fd6fa53f
SM
77342011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7735
7736 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7737 Call minibuffer-inactive-mode.
7738
864db017
JB
77392011-05-31 Juanma Barranquero <lekktu@gmail.com>
7740
7741 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7742 Update dependencies.
7743
2ad0baf4
DN
77442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7745
7746 * data.c (init_data): Remove code for UTS, this system is not
7747 supported anymore.
7748
4fcc2638
DN
77492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7750
7751 Don't force ./temacs to start in terminal mode.
7752
7753 * frame.c (make_initial_frame): Initialize faces in all cases, not
7754 only when CANNOT_DUMP is defined.
7755 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7756
c56e0fd5
DN
77572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7758
7759 * dispnew.c (add_window_display_history): Use const for the string
7760 pointer. Remove declaration, not needed.
7761
333d54da 77622011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 7763
55d4c1b2 7764 Use 'inline', not 'INLINE'.
333d54da 7765 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
7766 * alloc.c, fontset.c (INLINE): Remove.
7767 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7768 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7769 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7770 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7771 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7772
738db178
DN
77732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7774
7775 Make it possible to run ./temacs.
7776
7777 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7778 syms_of_callproc does the same thing. Remove test for
7779 "initialized", do it in the caller.
7780 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7781
620c53a6
SM
77822011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7783
7784 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7785 (read_minibuf): Use get_minibuffer.
7786 (syms_of_minibuf): Use DEFSYM.
7787 (Qmetadata): New var.
7788 * data.c (Qbuffer): Don't make it static.
7789 (syms_of_data): Use DEFSYM.
7790
e003a292
PE
77912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7792
7793 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7794 (CCL_CODE_MIN): New macro.
7795
ed008a6d
PE
77962011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7797
3687c2ef
PE
7798 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7799
ed008a6d
PE
7800 * eval.c (Qdebug): Now static.
7801 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7802 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7803 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7804
d66c4c7c
CY
78052011-05-29 Chong Yidong <cyd@stupidchicken.com>
7806
7807 * image.c: Various fixes to ImageMagick code comments.
7808 (Fimagemagick_types): Doc fix.
7809
5fbc2025
PE
78102011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7811
0196f88a
PE
7812 Minor fixes prompted by GCC 4.6.0 warnings.
7813
7814 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7815
5fbc2025
PE
7816 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7817 (x_clipboard_manager_save_all): Move extern decl to ...
7818 * xterm.h: ... here, so that it can be checked for consistency.
7819
1dd3c2d9
CY
78202011-05-29 Chong Yidong <cyd@stupidchicken.com>
7821
7822 * xselect.c (x_clipboard_manager_save_frame)
7823 (x_clipboard_manager_save_all): New functions.
7824 (Fx_clipboard_manager_save): Lisp function deleted.
7825
7826 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7827 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7828
7829 * xterm.h: Update prototype.
7830
5ba6571d
WX
78312011-05-28 William Xu <william.xwl@gmail.com>
7832
7833 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7834 exiting (Bug#8239).
7835
3eaff834
JM
78362011-05-28 Jim Meyering <meyering@redhat.com>
7837
e1900994 7838 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
7839 * fns.c (to_uchar): Define.
7840 (crypto_hash_function): Use it to convert some newly-signed
7841 variables to unsigned, to avoid sign-extension bugs. For example,
7842 without this change, (md5 "truc") would evaluate to
7843 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7844 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 7845 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 7846
0f6990a7
PE
78472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7848
7849 Integer overflow fixes.
c8a9ca5a 7850
08686060
PE
7851 * dbusbind.c: Serial number integer overflow fixes.
7852 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
7853 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7854 to hold a serial number that is too large for a fixnum.
7855 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7856 Check for serial numbers out of range. Decode any serial number
59568bf0 7857 that was so large that it became a float. (Bug#8722)
08686060 7858
2d1fc3c7
PE
7859 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7860 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7861 Use XFASTINT rather than XUINT when numbers are nonnegative.
7862 (xd_append_arg, Fdbus_method_return_internal):
7863 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7864 arguments, check that Lisp number is nonnegative, rather than
59568bf0 7865 silently wrapping negative numbers around. (Bug#8722)
30217ff0 7866 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 7867 (Bug#8722)
2d1fc3c7 7868
c8a9ca5a
PE
7869 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7870
519e1d69
PE
7871 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7872
6df6ae42 7873 ccl: Add integer overflow checks.
30569699
PE
7874 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7875 (IN_INT_RANGE): New macros.
7876 (ccl_driver): Use them to check for integer overflow when
7877 decoding a CCL program. Many of the new checks are whether XINT (x)
7878 fits in int; it doesn't always, on 64-bit hosts. The new version
7879 doesn't catch all possible integer overflows, but it's an
847044ea 7880 improvement. (Bug#8719)
30569699 7881
c11285dc
PE
7882 * alloc.c (make_event_array): Use XINT, not XUINT.
7883 There's no need for unsigned here.
7884
fdccd48e
PE
7885 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7886 This follows up to the 2011-05-06 change that substituted uintptr_t
7887 for EMACS_INT. This case wasn't caught back then.
7888
37910ab2
PE
7889 Rework Fformat to avoid integer overflow issues.
7890 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7891 now (part of C89). Include <verify.h>.
7892 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7893 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7894 (Fformat): Avoid the prepass trying to compute sizes; it was only
7895 approximate and thus did not catch overflow reliably. Instead, walk
7896 through the format just once, formatting and computing sizes as we go,
7897 checking for integer overflow at every step, and allocating a larger
7898 buffer as needed. Keep track separately whether the format is
7899 multibyte. Keep only the most-recently calculated precision, rather
7900 than them all. Record whether each argument has been converted to
7901 string. Use EMACS_INT, not int, for byte and char and arg counts.
7902 Support field widths and precisions larger than INT_MAX. Avoid
7903 sprintf's undefined behavior with conversion specifications such as %#d
7904 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7905 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7906 formatting out-of-range floating point numbers with int
9173deec 7907 formats. (Bug#8668)
37910ab2 7908
2e6578fb
PE
7909 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7910
0ae6bdee
PE
7911 * data.c: Avoid integer truncation in expressions involving floats.
7912 * data.c: Include <intprops.h>.
7913 (arith_driver): When there's an integer overflow in an expression
7914 involving floating point, convert the integers to floating point
7915 so that the resulting value does not suffer from catastrophic
7916 integer truncation. For example, on a 64-bit host (* 4
7917 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7918 Do not rely on undefined behavior after integer overflow.
7919
de883a70
PE
7920 merge count_size_as_multibyte, parse_str_to_multibyte
7921 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 7922 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
7923 Check for integer overflow.
7924 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7925 since it's now a duplicate of the other. This is more of
7926 a character than a buffer op, so better that it's in character.c.
7927 * fns.c, print.c: Adjust to above changes.
7928
2ff916cb
PE
79292011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7930
7931 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7932
f1b54466
PE
79332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7934
fb1ac845
PE
7935 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7936 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7937 (x_clipboard_manager_save): Now static.
7938 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7939
f1b54466
PE
7940 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7941 (crypto_hash_function): Now static.
7942 Fix pointer signedness problems. Avoid unnecessary initializations.
7943
a9f737ee
CY
79442011-05-27 Chong Yidong <cyd@stupidchicken.com>
7945
7946 * termhooks.h (Vselection_alist): Make it terminal-local.
7947
7948 * terminal.c (create_terminal): Initialize it.
7949
7950 * xselect.c: Support for clipboard managers.
7951 (Vselection_alist): Move to termhooks.h as terminal-local var.
7952 (LOCAL_SELECTION): New macro.
7953 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7954 (symbol_to_x_atom): Remove gratuitous arg.
7955 (x_handle_selection_request, lisp_data_to_selection_data)
7956 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
7957 (x_own_selection, x_get_local_selection, x_convert_selection):
7958 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
7959 (some_frame_on_display): Delete unused function.
7960 (Fx_own_selection_internal, Fx_get_selection_internal)
7961 (Fx_disown_selection_internal, Fx_selection_owner_p)
7962 (Fx_selection_exists_p): New optional frame arg.
7963 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7964 (x_handle_selection_clear): Don't treat other terminals with the
7965 same keyboard specially. Use the terminal-local Vselection_alist.
7966 (x_clear_frame_selections): Use Frun_hook_with_args.
7967
7968 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7969
7970 * xterm.h: Add support for those atoms.
7971
e067f0c1
CY
79722011-05-26 Chong Yidong <cyd@stupidchicken.com>
7973
7974 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7975 (converted_selections, conversion_fail_tag): New global variables.
7976 (x_selection_request_lisp_error): Free the above.
7977 (x_get_local_selection): Remove unnecessary code.
7978 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
7979 of converted selections stored in converted_selections.
7980 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
7981 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7982 (x_convert_selection): New function.
7983 (x_handle_selection_event): Simplify.
7984 (x_get_foreign_selection): Don't ignore incoming requests while
7985 waiting for an answer; this will fail when we implement
7986 SAVE_TARGETS, and seems unnecessary anyway.
7987 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7988 (Vx_sent_selection_functions): Doc fix.
7989
0f4aebc0
LL
79902011-05-26 Leo Liu <sdl.web@gmail.com>
7991
7992 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7993
e61124cd
YM
79942011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7995
7996 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7997
7998 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7999 for fringe update if it has periodic bitmap.
ac389d0c 8000 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8001 and fringe_bitmap_periodic_p.
8002
8003 * fringe.c (get_fringe_bitmap_data): New function.
8004 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8005 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8006 row. Mark glyph row for fringe update if periodicity changed.
8007
8008 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8009 for fringe update unless it has periodic bitmap.
8010
f16d9837
KH
80112011-05-25 Kenichi Handa <handa@m17n.org>
8012
8013 * xdisp.c (get_next_display_element): Set correct it->face_id for
8014 a static composition.
8015
e1b90ef6
LL
80162011-05-24 Leo Liu <sdl.web@gmail.com>
8017
8018 * deps.mk (fns.o):
8019 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8020
8021 * fns.c (crypto_hash_function, Fsha1): New function.
8022 (Fmd5): Use crypto_hash_function.
8023 (syms_of_fns): Add Ssha1.
8024
7400048f
PE
80252011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8026
8027 * gnutls.c: Remove unused macros.
8028 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8029 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8030 Remove macros that are defined and never used.
8031 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8032
abb71cf4
CY
80332011-05-22 Chong Yidong <cyd@stupidchicken.com>
8034
8035 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8036 (Fx_get_selection_internal): Minor cleanup.
8037 (Fx_own_selection_internal): Rename arguments for consistency with
8038 select.el.
8039
6307db39
PE
80402011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8041
8042 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8043
f3d4e0a4
CY
80442011-05-22 Chong Yidong <cyd@stupidchicken.com>
8045
8046 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8047
4d8ade89
YM
80482011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8049
8050 * dispnew.c (scrolling_window): Don't exclude the case that the
8051 last enabled row in the desired matrix touches the bottom boundary.
8052
32078c8d
GM
80532011-05-21 Glenn Morris <rgm@gnu.org>
8054
8055 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8056 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8057 and add some more files.
32078c8d 8058
7285dc67
EZ
80592011-05-20 Eli Zaretskii <eliz@gnu.org>
8060
8061 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8062 report_file_error introduced by the change from 2011-05-07.
8063
89d1bd22
PE
80642011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8065
8066 * systime.h (Time): Define only if emacs is defined.
8067 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8068 where the include path doesn't have X11/X.h by default. See
8069 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8070
cd394be1 80712011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8072
8073 * composite.c (find_automatic_composition): Fix previous change.
8074
b9704ad9
GM
80752011-05-20 Glenn Morris <rgm@gnu.org>
8076
8077 * lisp.mk: New file, split from Makefile.in.
8078 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8079 (shortlisp): Remove.
8080 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8081
4a720484
GM
80822011-05-19 Glenn Morris <rgm@gnu.org>
8083
8084 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8085 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8086 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8087 (lisp): Set the order to that of loadup.el.
8088 (shortlisp): Make it a copy of $lisp.
8089 (SOME_MACHINE_LISP): Remove.
8090 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8091 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8092
a28d4396
KH
80932011-05-18 Kenichi Handa <handa@m17n.org>
8094
8095 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8096 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8097 (find_automatic_composition): Mostly rewrite for efficiency.
8098
a2b1fa8e
JB
80992011-05-18 Juanma Barranquero <lekktu@gmail.com>
8100
8101 * makefile.w32-in: Update dependencies.
8102
8e1f5610
CS
81032011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8104
8105 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8106 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8107
7025ee00 81082011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8109
cdfa6eab
PE
8110 Fix some integer overflow issues, such as string length overflow.
8111
06d6db33
PE
8112 * insdel.c (count_size_as_multibyte): Check for string overflow.
8113
2b4560a8
PE
8114 * character.c (lisp_string_width): Check for string overflow.
8115 Use EMACS_INT, not int, for string indexes and lengths; in
8116 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8117 the resulting string length overflows an EMACS_INT; instead,
8118 report a string overflow if no precision given. When checking for
8119 precision exhaustion, use a check that cannot possibly have
8120 integer overflow. (Bug#8675)
8121 * character.h (lisp_string_width): Adjust to new signature.
8122
cb93f9be
PE
8123 * alloc.c (string_overflow): New function.
8124 (Fmake_string): Use it. This doesn't change behavior, but saves
8125 a few bytes and will simplify future changes.
8126 * character.c (string_escape_byte8): Likewise.
8127 * lisp.h (string_overflow): New decl.
8128
1a1f3366
PE
8129 Fixups, following up to the user-interface timestamp change.
8130 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8131 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8132 * msdos.c (mouse_get_pos): Likewise.
8133 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8134 * w32gui.h (Time): Define by including "systime.h" rather than by
8135 declaring it ourselves. (Bug#8664)
8136
d4e3e4d3
PE
8137 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8138 * image.c (clear_image_cache): Likewise.
8139
f6a24d19
PE
8140 * term.c (term_mouse_position): Don't assume time_t wraparound.
8141
08dc5ae6
PE
8142 Be more systematic about user-interface timestamps.
8143 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8144 and sometimes 'EMACS_UINT', to represent these timestamps.
8145 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8146 This makes the code easier to follow, and makes it easier to catch
8147 integer overflow bugs such as Bug#8664.
8148 * frame.c (Fmouse_position, Fmouse_pixel_position):
8149 Use Time, not unsigned long, for user-interface timestamps.
8150 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8151 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8152 * keyboard.h (last_event_timestamp): Likewise.
8153 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8154 * menu.h (xmenu_show): Likewise.
8155 * term.c (term_mouse_position): Likewise.
8156 * termhooks.h (struct input_event.timestamp): Likewise.
8157 (struct terminal.mouse_position_hook): Likewise.
8158 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8159 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8160 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8161 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8162 what it was before.
8163 * menu.h, termhooks.h: Include "systime.h", for Time.
8164
8e55734a
PE
8165 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8166 Don't assume that the difference between two unsigned long values
8167 can fit into an integer. At this point, we know button_down_time
8168 <= event->timestamp, so the difference must be nonnegative, so
8169 there's no need to cast the result if double-click-time is
8170 nonnegative, as it should be; check that it's nonnegative, just in
8171 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8172 apart (about 25 days). (Bug#8664)
8e55734a 8173
841f1b75 8174 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8175 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8176
3e26f69c
PE
8177 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8178 that always fit in int. Use a sentinel instead of a counter, to
8179 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8180 * frame.h (struct frame): Use int for menu_bar_items_used
8181 instead of EMACS_INT, since it always fits in int.
3e26f69c 8182
5cc152c0
PE
8183 * menu.c (grow_menu_items): Check for int overflow.
8184
d89eb65e
PE
8185 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8186
5235bd3e
PE
8187 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8188 Before, the code was not consistent. These values cannot exceed
8189 2**31 - 1 so there's no need to make them unsigned.
8190 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8191 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8192 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8193 as modifiers.
8194 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8195
bc827e23
PE
8196 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8197 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8198 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8199 presumably because the widths might not match.
8200
78eb494e
PE
8201 * window.c (size_window): Avoid needless test at loop start.
8202
04f2d78b
CB
82032011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8204
8205 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8206
d2fc7e3d 82072011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8208
8209 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8210
d2fc7e3d 82112011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8212
8213 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8214 `width' to `bar_area_x' and `bar_area_width', respectively.
8215 (x_scroll_run): Take account of fringe background extension.
8216
04f2d78b
CB
8217 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8218 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8219 `bar_area_width', respectively.
8220 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8221 background extension.
8222
79b70037
GM
82232011-05-10 Jim Meyering <meyering@redhat.com>
8224
8225 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8226
2f142cc5
JB
82272011-05-10 Juanma Barranquero <lekktu@gmail.com>
8228
8229 * image.c (Finit_image_library): Return t for built-in image types,
8230 like pbm and xbm. (Bug#8640)
8231
57679c86
AS
82322011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8233
8234 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8235
888c9e86
EZ
82362011-05-07 Eli Zaretskii <eliz@gnu.org>
8237
b0512a1d
EZ
8238 * w32console.c (Fset_screen_color): Doc fix.
8239 (Fget_screen_color): New function.
8240 (syms_of_ntterm): Defsubr it.
8241
7285dc67
EZ
8242 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8243 unlink the temporary file if Fcall_process didn't create it in the
8244 first place.
8245 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8246 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8247 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8248 cue to call_process_cleanup not to close that handle.
8249
4d3fcc8e
BK
82502011-05-07 Ben Key <bkey76@gmail.com>
8251
8252 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8253 one of two shell specific rules, either bootstrap-temacs-CMD or
8254 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8255 to the previous implementation of the bootstrap-temacs rule.
8256 The bootstrap-temacs-CMD rule is similar to the previous
8257 implementation of the bootstrap-temacs rule except that it
8258 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8259 variable.
8260
8261 These changes, along with some changes to nt/configure.bat,
8262 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8263 earlier fix to add support for --cflags and --ldflags options
8264 that include quotes so that it works whether make uses cmd or
8265 sh as the shell.
8266
b4289b64
MA
82672011-05-06 Michael Albinus <michael.albinus@gmx.de>
8268
8269 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8270 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8271 is a constant.
8272 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8273 a string. Handle both cases.
8274 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8275 (Fdbus_register_method): Use Qinvalid_function.
8276
af4c0e28
JB
82772011-05-06 Juanma Barranquero <lekktu@gmail.com>
8278
8279 * makefile.w32-in: Update dependencies.
8280 (LISP_H): Add inttypes.h and stdin.h.
8281 (PROCESS_H): Add unistd.h.
8282
c51453d9
EZ
82832011-05-06 Eli Zaretskii <eliz@gnu.org>
8284
8285 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8286 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8287
8ff0ac3c 82882011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8289
4c4b566b
PE
8290 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8291
aab2b9b5
PE
8292 * term.c (vfatal): Remove stray call to va_end.
8293 It's not needed and the C Standard doesn't allow it here anyway.
8294
c378da0b
PE
8295 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8296 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8297
288b08c7
PE
8298 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8299 bytes.
8300
e3601888
PE
8301 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8302
db6c0e74
PE
8303 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8304
dd5963ea
PE
8305 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8306
88c9450f
PE
8307 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8308
2f9442b8
PE
8309 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8310
c032b5f8
PE
8311 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8312 * charset.c (Fdefine_charset_internal): Don't initialize
8313 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8314 32-bit int (Bug#8600).
a108c10b
PE
8315
8316 * lread.c (read_integer): Be more consistent with string-to-number.
8317 Use string_to_number to do the actual conversion; this avoids
8318 rounding errors and fixes some other screwups. Without this fix,
8319 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8320 (digit_to_number): Move earlier, for benefit of read_integer.
8321 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8322 not a digit in any supported base. (Bug#8602)
a108c10b 8323
ad5f9eea
PE
8324 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8325
aec1708a
PE
8326 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8327 to match comment at start of function. This also removes a
8328 GCC warning about overflow in a 32+64-bit port.
8329
47be4ab5
PE
8330 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8331
371cac43
PE
8332 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8333 Reported by Stefan Monnier in
8334 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8335 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8336 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8337
d01a7826
PE
8338 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8339 (EMACS_UINTPTR): Likewise, with uintptr_t.
8340
7fd47d5c
PE
8341 * lisp.h: Prefer 64-bit EMACS_INT if available.
8342 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8343 on 32-bit hosts that have 64-bit int, so that they can access
8344 large files.
122b0c86
PE
8345 However, temporarily disable this change unless the temporary
8346 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8347
8727937b
PE
8348 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8349
8ac068ac
PE
8350 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8351 This removes an assumption that EMACS_INT and long are the same
8352 width as pointers. The assumption is true for Emacs porting targets
8353 now, but we want to make other targets possible.
8354 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8355 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8356 In the rest of the code, change types of integers that hold casted
8357 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8358 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8359 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8360 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8361 No need to cast type when ORing.
8362 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8363 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8364 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8365 assume EMACS_INT is the same width as char *.
8366 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8367 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8368 Remove no-longer-needed casts.
8369 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8370 (xg_tool_bar_help_callback, xg_make_tool_item):
8371 Use EMACS_INTPTR to hold an integer
8372 that will be cast to void *; this can avoid a GCC warning
8373 if EMACS_INT is not the same width as void *.
8374 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8375 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8376 (current_message_1, set_message_1):
8377 Use a local to convert to proper width without a cast.
8378 * xmenu.c (dialog_selection_callback): Likewise.
8379
ede49d71
PE
8380 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8381 Also, don't assume VALBITS / RAND_BITS is less than 5,
8382 and don't rely on undefined behavior when shifting a 1 left into
8383 the sign bit.
8384 * lisp.h (get_random): Change signature to match.
8385
2f30ecd0
PE
8386 * lread.c (hash_string): Use size_t, not int, for hash computation.
8387 Normally we prefer signed values; but hashing is special, because
8388 it's better to use unsigned division on hash table sizes so that
8389 the remainder is nonnegative. Also, size_t is the natural width
8390 for hashing into memory. The previous code used 'int', which doesn't
8391 retain enough info to hash well into very large tables.
8392 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8393
2a866e7b
PE
8394 * dbusbind.c: Don't possibly lose pointer info when converting.
8395 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8396 Use XPNTR rather than XHASH, so that the high-order bits of
8397 the pointer aren't lost when converting through void *.
8398
51639eac
PE
8399 * eval.c (Fautoload): Don't double-shift a pointer.
8400
92394119
PE
8401 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8402
dbdb9a7c
JB
84032011-05-06 Juanma Barranquero <lekktu@gmail.com>
8404
8405 * gnutls.c (DEF_GNUTLS_FN):
8406 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8407
db7a0b4f
AS
84082011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8409
8410 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8411 marker. (Bug#8610)
8412
cd394be1 84132011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8414
8415 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8416 New version that can reserve upto 2GB of heap space.
8417
f7ff1b0f 84182011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8419
8420 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8421
639c109b
TZ
84222011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8423
8424 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8425 `gnutls_certificate_set_x509_key_file'.
8426
d2127135
JB
84272011-05-05 Juanma Barranquero <lekktu@gmail.com>
8428
8429 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8430 Update dependencies.
8431
e968f4f3
JB
84322011-05-04 Juanma Barranquero <lekktu@gmail.com>
8433
8434 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8435 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8436 Remove unused parameter `fildes'.
8437 * process.c (read_process_output, send_process): Don't pass it.
8438
84d358f0
JB
84392011-05-04 Juanma Barranquero <lekktu@gmail.com>
8440
8441 Fix previous change: the library cache is defined in w32.c.
8442 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8443 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8444
0898ca10
JB
84452011-05-04 Juanma Barranquero <lekktu@gmail.com>
8446
8447 Implement dynamic loading of GnuTLS on Windows.
8448
8449 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8450 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8451 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8452 Declare.
8453
8454 * gnutls.c (Qgnutls_dll): Define.
8455 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8456 (gnutls_*): Declare function pointers.
8457 (init_gnutls_functions): New function to initialize function pointers.
8458 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8459 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8460 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8461 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8462 (emacs_gnutls_write, emacs_gnutls_read)
8463 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8464 (Fgnutls_available_p): New function.
8465 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8466 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8467 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8468
8469 * image.c: Include w32.h.
8470 (Vimage_type_cache): Delete.
8471 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8472 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8473 (w32_delayed_load): Move to w32.c.
8474
8475 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8476
8477 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8478 (w32_delayed_load): Move from image.c. When loading a library, record
8479 its filename in the :loaded-from property of the library id.
8480 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8481 Initialize and staticpro them.
8482 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8483
8484 * process.c: Include lisp.h before w32.h, not after.
8485 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8486 instead of gnutls_record_check_pending.
8487
8488 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8489
ff4de4aa
TZ
84902011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8491
8492 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8493 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8494 as passed in.
8495
abe95abb
JD
84962011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8497
8498 * xterm.c (x_set_frame_alpha): Do not set property on anything
8499 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8500
e16e55d4
JB
85012011-05-02 Juanma Barranquero <lekktu@gmail.com>
8502
8503 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8504
bafcf6a5
JB
85052011-05-02 Juanma Barranquero <lekktu@gmail.com>
8506
8507 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8508 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8509 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8510 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8511 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8512 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8513 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8514 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8515 (Qgnutls_bootprop_callbacks_verify): Make static.
8516
e7a6747f
AS
85172011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8518
19ed11ba
AS
8519 * callproc.c: Indentation fixup.
8520
e7a6747f 8521 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8522 (wait_for_termination, interruptible_wait_for_termination):
8523 Move after wait_for_termination_1.
e7a6747f 8524
1ef14cb4
LMI
85252011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8526
8527 * sysdep.c (interruptible_wait_for_termination): New function
8528 which is like wait_for_termination, but allows keyboard
8529 interruptions.
8530
8531 * callproc.c (Fcall_process): Add (:file "file") as an option for
8532 the STDOUT buffer.
8533 (Fcall_process_region): Ditto.
8534
330d880c
EZ
85352011-04-30 Eli Zaretskii <eliz@gnu.org>
8536
8db90b73
EZ
8537 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8538 rather than `XVECTOR (FOO)->size'.
8539
330d880c
EZ
8540 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8541 inttypes.h, as a gnulib replacement is used if it not available in
8542 system headers.
8543
15cbd324
EZ
85442011-04-21 Eli Zaretskii <eliz@gnu.org>
8545
8546 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8547 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8548 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8549
8550 * coding.c (coding_alloc_by_realloc): Error out if destination
8551 will grow beyond MOST_POSITIVE_FIXNUM.
8552 (decode_coding_emacs_mule): Abort if there isn't enough place in
8553 charbuf for the composition carryover bytes. Reserve an extra
8554 space for up to 2 characters produced in a loop.
8555 (decode_coding_iso_2022): Abort if there isn't enough place in
8556 charbuf for the composition carryover bytes.
8557
85582011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8559
ae940cca
EZ
8560 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8561 aborting when %lld or %lll format is passed.
8562 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8563 %llo or %llx format is passed. (Bug#8545)
8564
03ab8921
EZ
8565 * window.c (window_scroll_line_based): Use a marker instead of
8566 simple variables to record original value of point. (Bug#7952)
8567
afda1437
EZ
8568 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8569 produced by %s or %c overflows available buffer space. (Bug#8545)
8570
f76dee0c
PE
85712011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8572
8573 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8574 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8575
fdc5744d
JB
85762011-04-28 Juanma Barranquero <lekktu@gmail.com>
8577
8578 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8579
638f053a
JB
85802011-04-28 Juanma Barranquero <lekktu@gmail.com>
8581
8582 * keyboard.c (Qdelayed_warnings_hook): Define.
8583 (command_loop_1): Run `delayed-warnings-hook'
8584 if Vdelayed_warnings_list is non-nil.
8585 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8586 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8587
d178f871
EZ
85882011-04-28 Eli Zaretskii <eliz@gnu.org>
8589
8590 * doprnt.c (doprnt): Don't return value smaller than the buffer
8591 size if the message was truncated. (Bug#8545).
8592
b124fd93
JB
85932011-04-28 Juanma Barranquero <lekktu@gmail.com>
8594
8595 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8596 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8597
e810457d
PE
85982011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8599
8600 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8601
ea51cceb
JB
86022011-04-27 Juanma Barranquero <lekktu@gmail.com>
8603
8604 * makefile.w32-in: Update dependencies.
8605
94dcfacf
EZ
86062011-04-27 Eli Zaretskii <eliz@gnu.org>
8607
8608 Improve `doprnt' and its usage. (Bug#8545)
8609 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8610 `format_end'. Remove support for %l as a conversion specifier.
8611 Don't use xrealloc. Improve diagnostics when the %l size modifier
8612 is used. Update the commentary.
8613
8614 * eval.c (verror): Simplify calculation of size_t.
8615
8616 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8617 messages.
8618
f61f41d7
PE
86192011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8620
8621 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8622 change.
8623
96fb4434
PE
86242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8625
8626 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8627 This makes this file independent of the recent pseudovector change.
8628
671875da 86292011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8630
69e9b5a3
PE
8631 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8632
b5f869a7 8633 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8634 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8635 Remove unused local.
c8926152 8636 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8637
841a1577 8638 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8639 GCC 4.6.0 optimizes based on type-based alias analysis.
8640 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8641 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8642 != &v->size, and therefore "v->size = 1; b->size = 2; return
8643 v->size;" must therefore return 1. This assumption is incorrect
8644 for Emacs, since it type-puns struct Lisp_Vector * with many other
8645 types. To fix this problem, this patch adds a new type struct
f904488f 8646 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8647 and pseudovectors, and helps optimizing compilers not get fooled
8648 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8649 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8650 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8651 the size member.
eab3844f
PE
8652 (XSETPVECTYPE): Rewrite in terms of new macro.
8653 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8654 This is a bit clearer, and further avoids the possibility of
8655 undesirable aliasing.
8656 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8657 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8658 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8659 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8660 (ASIZE): Now uses header.size rather than size.
8661 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8662 to avoid the hassle of writing XVECTOR (foo)->header.size.
8663 (struct vectorlike_header): New type.
eab3844f
PE
8664 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8665 object, to help avoid aliasing.
8666 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8667 (SUBRP): Likewise, since Lisp_Subr is a special case.
8668 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8669 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8670 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8671 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8672 changed to be "header.size" and "header.next".
8673 * buffer.h (struct buffer): Likewise.
8674 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8675 * frame.h (struct frame): Likewise.
8676 * process.h (struct Lisp_Process): Likewise.
8677 * termhooks.h (struct terminal): Likewise.
8678 * window.c (struct save_window_data, struct saved_window): Likewise.
8679 * window.h (struct window): Likewise.
8680 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8681 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8682 * buffer.c (init_buffer_once): Likewise.
8683 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8684 special case.
8685 * process.c (Fformat_network_address): Use local var for size,
8686 for brevity.
8687
0df1eac5
PE
8688 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8689
847ab9d1 8690 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8691 * data.c (atof): Remove decl; no longer used or needed.
8692 (digit_to_number): Move to lread.c.
8693 (Fstring_to_number): Use new string_to_number function, to be
8694 consistent with how the Lisp reader treats infinities and NaNs.
8695 Do not assume that floating-point numbers represent EMACS_INT
8696 without losing information; this is not true on most 64-bit hosts.
8697 Avoid double-rounding errors, by insisting on integers when
8698 parsing non-base-10 numbers, as the documentation specifies.
8699 * lisp.h (string_to_number): New decl, replacing ...
8700 (isfloat_string): Remove.
bc0a5c13 8701 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8702 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8703 appears to have been a coding error. Similarly, do not accept
8704 strings like +-1e0 as floating point numbers. Do not report
8705 overflow for integer overflows unless the base is not 10 which
8706 means we have no simple and reliable way to continue.
8707 Break out the floating-point parsing into a new
8708 function string_to_number, so that Fstring_to_number parses
8709 floating point numbers consistently with the Lisp reader.
04f2d78b 8710 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8711 (E_CHAR, EXP_INT): Remove, replacing with ...
8712 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8713 (string_to_number): New function, replacing isfloat_string.
8714 This function checks for valid syntax and produces the resulting
8715 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8716 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8717 so that overflow for non-base-10 numbers is reported only when
8718 there's no portable and simple way to convert to floating point.
452f4150 8719
67769ffc
PE
8720 * textprop.c (set_text_properties_1): Rewrite for clarity,
8721 and to avoid GCC warning about integer overflow.
8722
c20db43f
PE
8723 * intervals.h (struct interval): Use EMACS_INT for members
8724 where EMACS_UINT might cause problems. See
8725 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8726 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8727 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8728 All uses changed.
37aa2f85
PE
8729 (offset_intervals): Tell GCC not to worry about length overflow
8730 when negating a negative length.
c20db43f 8731
2538aa2f
PE
8732 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8733 (overrun_check_free): Likewise.
8734
f2d3008d
PE
8735 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8736 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8737 word size.
8738
ec8df744
PE
8739 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8740 (gnutls_make_error): Rename local to avoid shadowing.
8741 (gnutls_emacs_global_deinit): ifdef out; not used.
8742 (Fgnutls_boot): Use const for pointer to readonly storage.
8743 Comment out unused local. Fix pointer signedness problems.
8744
640ee02d
PE
8745 * lread.c (openp): Don't stuff size_t into an 'int'.
8746 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8747 about possible signed overflow.
8748
6048fb2a
PE
8749 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8750 (GDK_KEY_g): Don't define if already defined.
8751 (xg_prepare_tooltip): Avoid pointer signedness problem.
8752 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8753
fa3c87e1
PE
8754 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8755 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8756
2172544b
PE
8757 * xfns.c (Fx_window_property): Simplify a bit,
8758 to make a bit faster and to avoid GCC 4.6.0 warning.
8759 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8760
9b821a21
PE
8761 * fns.c (internal_equal): Don't assume size_t fits in int.
8762
3c616cfa
PE
8763 * alloc.c (compact_small_strings): Tighten assertion a little.
8764
c2982e87
PE
8765 Replace pEd with more-general pI, and fix some printf arg casts.
8766 * lisp.h (pI): New macro, generalizing old pEd macro to other
8767 conversion specifiers. For example, use "...%"pI"d..." rather
8768 than "...%"pEd"...".
8769 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 8770 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
8771 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8772 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8773 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8774 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8775 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8776 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8777 64-bit hosts.
8778 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8779 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8780 * print.c (safe_debug_print, print_object): Likewise.
8781 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8782 to int.
6f04d126
PE
8783 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8784 avoiding the 0 flag, which is not portable.
c2982e87
PE
8785 * process.c (Fmake_network_process): Use pI to avoid cast.
8786 * region-cache.c (pp_cache): Likewise.
8787 * xdisp.c (decode_mode_spec): Likewise.
8788 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8789 behavior on 64-bit hosts with printf arg.
6f04d126 8790 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
8791 (x_stop_queuing_selection_requests): Likewise.
8792 (x_get_window_property): Don't truncate byte count to an 'int'
8793 when tracing.
0b432f21 8794
5e073ec7
PE
8795 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8796 here, since it parses constructs like leading '-' and spaces,
8797 which are not wanted; and it overflows with large numbers.
8798 Instead, simply match F[0-9]+, which is what is wanted anyway.
8799
36372bf9
PE
8800 * alloc.c: Remove unportable assumptions about struct layout.
8801 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8802 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8803 (allocate_vectorlike, make_pure_vector): Use the new macros,
8804 plus offsetof, to remove unportable assumptions about struct layout.
8805 These assumptions hold on all porting targets that I know of, but
8806 they are not guaranteed, they're easy to remove, and removing them
8807 makes further changes easier.
8808
0b432f21
PE
8809 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8810 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
8811 (string_overrun_cookie): Now const. Use initializers that
8812 don't formally overflow signed char, to avoid warnings.
000098c1
PE
8813 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8814 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
8815 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8816 multiple of sizeof (EMACS_INT); it need not be, if
8817 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 8818 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 8819
895009e1
JB
88202011-04-26 Juanma Barranquero <lekktu@gmail.com>
8821
8822 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8823
6a7a1b0b
TZ
88242011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8825
8826 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 8827 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
8828 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8829
841a1577 88302011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
8831
8832 * lisp.h (Qdebug): List symbol.
895009e1 8833 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
8834 * keyboard.c (debug-on-event): New variable.
8835 (handle_user_signal): Break into debugger when debug-on-event
8836 matches the current signal symbol.
8837
f2d3ba6f
DN
88382011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8839
8840 * alloc.c (check_sblock, check_string_bytes)
8841 (check_string_free_list): Convert to standard C.
8842
42ce4c63
TZ
88432011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8844
8845 * w32.c (emacs_gnutls_push): Fix typo.
8846
825cd63c
EZ
88472011-04-25 Eli Zaretskii <eliz@gnu.org>
8848
fb11d64d
EZ
8849 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8850 "cast to pointer from integer of different size".
8851
825cd63c
EZ
8852 Improve doprnt and its use in verror. (Bug#8545)
8853 * doprnt.c (doprnt): Document the set of format control sequences
8854 supported by the function. Use SAFE_ALLOCA instead of always
8855 using `alloca'.
8856
8857 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8858 is one byte too soon. Don't use xrealloc; instead xfree and
8859 xmalloc anew.
8860
e061a11b
TZ
88612011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8862
8863 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8864 callbacks stage.
8865
8866 * gnutls.c: Renamed global_initialized to
8867 gnutls_global_initialized. Added internals for the
8868 :verify-hostname-error, :verify-error, and :verify-flags
8869 parameters of `gnutls-boot' and documented those parameters in the
8870 docstring. Start callback support.
9173deec
JB
8871 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8872 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8873 on error. Return error code.
e061a11b
TZ
8874 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8875 (emacs_gnutls_read): Likewise.
8876 (Fgnutls_boot): Return handshake error code.
8877 (emacs_gnutls_handle_error): New function.
8878 (wsaerror_to_errno): Likewise.
8879
8880 * w32.h (emacs_gnutls_pull): Add prototype.
8881 (emacs_gnutls_push): Likewise.
8882
8883 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8884 (emacs_gnutls_push): Likewise.
8885
88862011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8887
8888 * process.c (wait_reading_process_output): Check if GnuTLS
8889 buffered some data internally if no FDs are set for TLS
8890 connections.
8891
8892 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8893 (LIBS): Link to USER_LIBS.
8894 ($(BLD)/gnutls.$(0)): New target.
8895
fa6996bc
EZ
88962011-04-24 Eli Zaretskii <eliz@gnu.org>
8897
eb35682e
EZ
8898 * xdisp.c (handle_single_display_spec): Rename the
8899 display_replaced_before_p argument into display_replaced_p, to
8900 make it consistent with the commentary. Fix typos in the
8901 commentary.
8902
e2ad650c
EZ
8903 * textprop.c (syms_of_textprop): Remove dead code.
8904 (copy_text_properties): Delete obsolete commentary about an
8905 interface that was deleted long ago. Fix typos in the description
8906 of arguments.
8907
1b2de274
EZ
8908 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8909 to changes in oldXMenu/XMenu.h from 2011-04-16.
8910 <menu_help_message, prev_menu_help_message>: Constify.
8911 (IT_menu_make_room): menu->help_text is now `const char **';
8912 adjust.
8913
8914 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8915 to changes in oldXMenu/XMenu.h from 2011-04-16.
8916 (struct XMenu): Declare `help_text' `const char **'.
8917
8918 * xfaces.c <Qunspecified>: Make extern again.
8919
8920 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 8921 required by POSIX.
1b2de274 8922
762b15be
EZ
8923 * doc.c (get_doc_string): Improve the format passed to `error'.
8924
8925 * doprnt.c (doprnt): Improve commentary.
8926
8927 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8928
8929 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8930 them with etags.
8931
f1052e5d
EZ
8932 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8933 changes in globals.h immediately force recompilation.
762b15be
EZ
8934 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8935 $(CURDIR)/s/ms-w32.h.
8936 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 8937
fa6996bc
EZ
8938 * character.c (Fchar_direction): Function deleted.
8939 (syms_of_character): Don't defsubr it.
8940 <char-direction-table>: Deleted.
8941
e6c3da20
EZ
89422011-04-23 Eli Zaretskii <eliz@gnu.org>
8943
8944 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8945 * doprnt.c: Include limits.h.
8946 (SIZE_MAX): New macro.
04f2d78b
CB
8947 (doprnt): Return a size_t value. 2nd arg is now size_t.
8948 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
8949 Improve overflow protection. Support `l' modifier for integer
8950 conversions. Support %l conversion. Don't assume an EMACS_INT
8951 argument for integer conversions and for %c.
8952
8953 * lisp.h (doprnt): Restore prototype.
8954
8955 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8956 $(SRC)/character.h.
8957
8958 * Makefile.in (base_obj): Add back doprnt.o.
8959
8960 * deps.mk (doprnt.o): Add back prerequisites.
8961 (callint.o): Depend on character.h.
8962
8963 * eval.c (internal_lisp_condition_case): Include the handler
8964 representation in the error message.
8965 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8966 when breaking from the loop.
8967
8968 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8969
8970 * callint.c (Fcall_interactively): When displaying error message
8971 about invalid control letter, pass the character's codepoint, not
8972 a pointer to its multibyte form. Improve display of the character
8973 in octal and display also its hex code.
8974
8975 * character.c (char_string): Use %x to display the (unsigned)
8976 codepoint of an invalid character, to avoid displaying a bogus
8977 negative value.
8978
8979 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8980 `error', not SYMBOL_NAME itself.
8981
8982 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8983 character arguments to `error'.
8984
8985 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8986 to `error' in error message about FINAL_CHAR argument. Make sure
8987 FINAL_CHAR is a character, and use %c when it is passed as
8988 argument to `error'.
8989
4ffd0d6b 89902011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
8991
8992 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8993
8994 * w32.c: Include <time.h>.
8995 (sys_localtime): New function.
8996
4ffd0d6b 89972011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
8998
8999 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9000
4ffd0d6b 9001 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9002
4ffd0d6b 90032011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9004
4ffd0d6b
GM
9005 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9006 zombies (Bug#8467).
aac0c6e3 9007
04c56954
EZ
90082011-04-19 Eli Zaretskii <eliz@gnu.org>
9009
9010 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9011 gl_state.e_property when gl_state.object is Qt.
9012
9013 * insdel.c (make_gap_larger): Remove limitation of buffer size
9014 to <= INT_MAX.
9015
16a43933
CY
90162011-04-18 Chong Yidong <cyd@stupidchicken.com>
9017
9018 * xdisp.c (lookup_glyphless_char_display)
9019 (produce_glyphless_glyph): Handle cons cell entry in
9020 glyphless-char-display.
9021 (Vglyphless_char_display): Document it.
9022
9023 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9024 glyphless-char-display.
9025
4581706e
CY
90262011-04-17 Chong Yidong <cyd@stupidchicken.com>
9027
9028 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9029
9030 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9031
9032 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9033 definition for no-X builds.
9034
4887c6e2 90352011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9036
fd35b6f9
PE
9037 Static checks with GCC 4.6.0 and non-default toolkits.
9038
5c1ccb01
PE
9039 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9040
006c5daa
PE
9041 * process.c (keyboard_bit_set): Define only if SIGIO.
9042 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9043 (send_process): Repair possible setjmp clobbering.
9044
efc736d3
PE
9045 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9046
4e2fe2e6
PE
9047 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9048
f97334a2
PE
9049 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9050
4e75f29d
PE
9051 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9052 Define only if needed.
9053
90efadd1
PE
9054 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9055 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9056 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9057
3c647824
PE
9058 * dispextern.h (struct redisplay_interface): Rename param
9059 to avoid shadowing.
e264f262 9060 * termhooks.h (struct terminal): Likewise.
761383f4 9061 * xterm.c (xembed_send_message): Likewise.
3c647824 9062
b58c5c4a
PE
9063 * insdel.c (make_gap_smaller): Define only if
9064 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9065
cad59032
PE
9066 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9067 it.
9068
c339dc2e
PE
9069 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9070 so that we aren't warned about unused symbols.
9071
91a3e27b
PE
9072 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9073
399c71d3 9074 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9075
8ffc96f5
PE
9076 * xfns.c (x_real_positions): Mark locals as initialized.
9077
eef9bc79
PE
9078 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9079
098db9dd
PE
9080 * xterm.c: Fix problems found by static analysis with other toolkits.
9081 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9082 (x_dispatch_event): Declare static if USE_GTK, and
9083 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9084 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9085 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9086 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9087 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9088
eb18f6cc
PE
9089 * xmenu.c (menu_help_callback): Pointer type fixes.
9090 Use const pointers when pointing at readonly data. Avoid pointer
9091 signedness clashes.
9092 (FALSE): Remove unused macro.
9093 (update_frame_menubar): Remove unused decl.
9094
1fe72bf8
PE
9095 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9096
60d9e1db
PE
9097 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9098 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9099 (single_menu_item): Rename local to avoid shadowing.
9100
39261c26
PE
9101 * keyboard.c (make_lispy_event): Remove unused local var.
9102
018c5e19
PE
9103 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9104 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9105
63d2b86e
PE
9106 * bitmaps: Change bitmaps from unsigned char back to the X11
9107 compatible char. Avoid the old compiler warnings about
9108 out-of-range initializers by using, for example, '\xab' rather
9109 than 0xab.
9110
aefd87e1
PE
9111 * xgselect.c (xgselect_initialize): Check vs interface
9112 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9113
bf501fb9
PE
9114 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9115
e9829fdf
PE
9116 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9117 to read-only memory.
9118
1086c095
PE
9119 * fns.c (vector): Remove; this old hack is no longer needed.
9120
2baccd04 9121 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9122 Remove unused var.
dde42981 9123 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9124
72391843 9125 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9126
436c16df 9127 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9128 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9129 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9130
92bb796d 9131 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9132 (x_term_init): Remove local to avoid shadowing.
92bb796d 9133
764430a3 9134 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9135
9136 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9137 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9138
d1dfb56c
EZ
91392011-04-16 Eli Zaretskii <eliz@gnu.org>
9140
c4354cb4
EZ
9141 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9142
d1dfb56c
EZ
9143 Fix regex.c, syntax.c and friends for buffers > 2GB.
9144 * syntax.h (struct gl_state_s): Declare character position members
9145 EMACS_INT.
9146
9147 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9148
04f2d78b
CB
9149 * textprop.c (verify_interval_modification, interval_of):
9150 Declare arguments EMACS_INT.
d1dfb56c
EZ
9151
9152 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9153 EMACS_INT.
9154
9155 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9156
9157 * indent.c (Fvertical_motion): Local variable it_start is now
9158 EMACS_INT.
9159
9160 * regex.c (re_match, re_match_2, re_match_2_internal)
9161 (bcmp_translate, regcomp, regexec, print_double_string)
9162 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9163 (re_compile_pattern, re_exec): Declare arguments and local
9164 variables `size_t' and `ssize_t' and return values `regoff_t', as
9165 appropriate.
9166 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9167 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9168 <compile_stack_type>: `size' and `avail' are now `size_t'.
9169
9170 * regex.h <regoff_t>: Use ssize_t, not int.
9171 (re_search, re_search_2, re_match, re_match_2): Arguments that
9172 specify buffer/string position and length are now ssize_t and
9173 size_t. Return type is regoff_t.
9174
613052cd
BK
91752011-04-16 Ben Key <bkey76@gmail.com>
9176
9177 * nsfont.m: Fixed bugs in ns_get_family and
9178 ns_descriptor_to_entity that were caused by using free to
9179 deallocate memory blocks that were allocated by xmalloc (via
9180 xstrdup). This caused Emacs to crash when compiled with
9181 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9182 --enable-checking=xmallocoverrun). xfree is now used to
9183 deallocate these memory blocks.
9184
4170f62f 91852011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9186
71b41406
PE
9187 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9188
9587a89d
PE
9189 emacs_write: Accept and return EMACS_INT for sizes.
9190 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9191 et seq.
9192 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9193 Accept and return EMACS_INT.
9194 (emacs_gnutls_write): Return the number of bytes written on
9195 partial writes.
9196 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9197 (emacs_read, emacs_write): Remove check for negative size, as the
9198 Emacs source code has been audited now.
9587a89d
PE
9199 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9200 (emacs_read, emacs_write): Use it.
273a5f82
PE
9201 * process.c (send_process): Adjust to the new signatures of
9202 emacs_write and emacs_gnutls_write. Do not attempt to store
9203 a byte offset into an 'int'; it might overflow.
9587a89d 9204 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9205
3e047f51
PE
9206 * sound.c: Don't assume sizes fit in 'int'.
9207 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9208 Return EMACS_INT, not int.
3e047f51 9209 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9210 Accept EMACS_INT, not int.
9211 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9212 record read return values.
9213
cc39a9db
BK
92142011-04-15 Ben Key <bkey76@gmail.com>
9215
c9d0ec6d
JB
9216 * keyboard.c (Qundefined): Don't declare static since it is used
9217 in nsfns.m.
9218 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9219 static since they are used in nsfont.m.
cc39a9db 9220
6c60eb9f
SM
92212011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9222
9223 * process.c (Qprocessp): Don't declare static.
9224 * lisp.h (Qprocessp): Declare again.
9225
7990b61a
JB
92262011-04-15 Juanma Barranquero <lekktu@gmail.com>
9227
9228 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9229
5d4cb038
PE
92302011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9231
8bd7b830 9232 Improve C-level modularity by making more things 'static'.
cd64ea1d 9233
e3b27b31
PE
9234 Don't publish debugger-only interfaces to other modules.
9235 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9236 (verify_bytepos, count_markers): Move decls to the only modules
9237 that need them.
9238 * region-cache.h (pp_cache): Likewise.
9239 * window.h (check_all_windows): Likewise.
9240 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9241
5d4cb038
PE
9242 * sysdep.c (croak): Now static, if
9243 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9244 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9245
9246 * alloc.c (refill_memory_reserve): Now static if
9247 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9248 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9249
e87b6180
PE
9250 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9251 Define only if USE_LUCID.
9252
ac64929e
PE
9253 * xrdb.c (x_customization_string, x_rm_string): Now static.
9254
6f37259d
PE
9255 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9256 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9257
1683e3ab
PE
9258 * xdisp.c (draw_row_with_mouse_face): Now static.
9259 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9260
de9c2632
PE
9261 * window.h (check_all_windows): Mark externally visible.
9262
2b96acb7
PE
9263 * window.c (window_deletion_count): Now static.
9264
9265 * undo.c: Make symbols static if they're not exported.
9266 (last_undo_buffer, last_boundary_position, pending_boundary):
9267 Now static.
9268
50436f33
PE
9269 * textprop.c (interval_insert_behind_hooks): Now static.
9270 (interval_insert_in_front_hooks): Likewise.
9271
64520e5c
PE
9272 * term.c: Make symbols static if they're not exported.
9273 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9274 (max_frame_lines, tty_set_terminal_modes):
9275 (tty_reset_terminal_modes, tty_turn_off_highlight):
9276 (get_tty_terminal): Now static.
9277 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9278 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9279 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9280 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9281 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9282
1fa53021
PE
9283 * sysdep.c: Make symbols static if they're not exported.
9284 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9285 Now static.
9286 (sigprocmask_set, full_mask): Remove; unused.
9287 (wait_debugging): Mark as visible.
9288 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9289 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9290
d4b43b22
PE
9291 * syntax.c (syntax_temp): Define only if !__GNUC__.
9292
b7c513d0
PE
9293 * sound.c (current_sound_device, current_sound): Now static.
9294
989b29ad
PE
9295 * search.c (searchbufs, searchbuf_head): Now static.
9296
13a55a78
PE
9297 * scroll.c (scroll_cost): Remove; unused.
9298 * dispextern.h (scroll_cost): Remove decl.
9299
de68a1fc
PE
9300 * region-cache.h (pp_cache): Mark as externally visible.
9301
40ccffa6
PE
9302 * process.c: Make symbols static if they're not exported.
9303 (process_tick, update_tick, create_process, chan_process):
9304 (Vprocess_alist, proc_buffered_char, datagram_access):
9305 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9306 (deactivate_process): Mark defn as static, as well as decl.
9307 * lisp.h (create_process): Remove decl.
9308 * process.h (chan_process, Vprocess_alist): Remove decls.
9309
ad64fc97
PE
9310 * print.c: Make symbols static if they're not exported.
9311 (print_depth, new_backquote_output, being_printed, print_buffer):
9312 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9313 (print_interval, print_number_index, initial_stderr_stream):
9314 Now static.
9315 * lisp.h (Fprinc): Remove decl.
9316 (debug_output_compilation_hack): Mark as externally visible.
9317
adddb265
PE
9318 * sysdep.c (croak): Move decl from here to syssignal.h.
9319 * syssignal.h (croak): Put it here, so the API can be checked when
9320 'croak' is called from dissociate_if_controlling_tty.
9321
1717ede2
PE
9322 * minibuf.c: Make symbols static if they're not exported.
9323 (minibuf_save_list, choose_minibuf_frame): Now static.
9324 * lisp.h (choose_minibuf_frame): Remove decl.
9325
fa5fb2bc
PE
9326 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9327
1e3890d1
PE
9328 * lread.c: Make symbols static if they're not exported.
9329 (read_objects, initial_obarray, oblookup_last_bucket_number):
9330 Now static.
9331 (make_symbol): Remove; unused.
9332 * lisp.h (initial_obarray, make_symbol): Remove decls.
9333
8a1414fa
PE
9334 * keyboard.c: Make symbols static if they're not exported.
9335 (single_kboard, recent_keys_index, total_keys, recent_keys):
9336 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9337 (this_single_command_key_start, echoing, last_auto_save):
9338 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9339 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9340 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9341 (Vlispy_mouse_stem, double_click_count):
9342 Now static.
9343 (force_auto_save_soon): Define only if SIGDANGER.
9344 (ignore_mouse_drag_p): Now static if
9345 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9346 (print_help): Remove; unused.
9347 (stop_character, last_timer_event): Mark as externally visible.
9348 * keyboard.h (ignore_mouse_drag_p): Declare only if
9349 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9350 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9351 * lisp.h (echoing): Remove decl.
9352 (force_auto_save_soon): Declare only if SIGDANGER.
9353 * xdisp.c (redisplay_window): Simplify code, to make it more
9354 obvious that ignore_mouse_drag_p is not accessed if !defined
9355 USE_GTK && !defined HAVE_NS.
9356
93ea6e8f
PE
9357 * intervals.c: Make symbols static if they're not exported.
9358 (merge_properties_sticky, merge_interval_right, delete_interval):
9359 Now static.
9360 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9361
77382fcc
PE
9362 * insdel.c: Make symbols static if they're not exported.
9363 However, leave prepare_to_modify_buffer alone. It's never
9364 called from outside this function, but that appears to be a bug.
9365 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9366 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9367 (adjust_after_replace_noundo): Remove; unused.
9368 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9369 (signal_before_change): Remove decls.
77382fcc 9370
9306c32e
PE
9371 * indent.c (val_compute_motion, val_vmotion): Now static.
9372
cd44d2eb
PE
9373 * image.c: Make symbols static if they're not exported.
9374 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9375 if USE_GTK.
9376 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9377 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9378
ad9a7a06
PE
9379 * fringe.c (standard_bitmaps): Now static.
9380 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9381
81626931
PE
9382 * frame.c: Make symbols static if they're not exported.
9383 (x_report_frame_params, make_terminal_frame): Now static.
9384 (get_frame_param): Now static, unless HAVE_NS.
9385 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9386 (x_get_resource_string): Remove; not used.
9387 * frame.h (make_terminal_frame, x_report_frame_params):
9388 (x_get_resource_string); Remove decls.
9389 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9390 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9391
239f9db9
PE
9392 * font.c, fontset.c: Make symbols static if they're not exported.
9393 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9394 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9395 * font.c (font_close_object): Now static.
9396 * font.h (font_close_object): Remove.
9397 * fontset.c (FONTSET_OBJLIST): Remove.
9398 (free_realized_fontset) #if-0 the body, which does nothing.
9399 (face_suitable_for_char_p): #if-0, as it's never called.
9400 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9401 * xfaces.c (face_at_string_position):
9402 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9403 since 0 is always ASCII.
9404
dfcf3579
PE
9405 * fns.c (weak_hash_tables): Now static.
9406
5045092b
PE
9407 * fileio.c: Make symbols static if they're not exported.
9408 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9409 (Vwrite_region_annotation_buffers): Now static.
9410
57a96f5c
PE
9411 * eval.c: Make symbols static if they're not exported.
9412 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9413 * lisp.h (backtrace_list): Remove decl.
9414
35f08c38
PE
9415 * emacs.c: Make symbols static if they're not exported.
9416 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9417 (fatal_error_code, fatal_error_signal_hook, standard_args):
9418 Now static.
9419 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9420 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9421 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9422 * lisp.h (fatal_error_signal_hook): Remove decl.
9423 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9424
f44bd759
PE
9425 * editfns.c: Move a (normally-unused) function to its only use.
9426 * editfns.c, lisp.h (get_operating_system_release): Remove.
9427 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9428 worth the hassle of breaking this out.
9429
b532497d
PE
9430 * xterm.c: Make symbols static if they're not exported.
9431 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9432 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9433 (x_destroy_window, x_delete_display):
9434 Now static.
9435 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9436 (x_mouse_leave): Remove; unused.
9437 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9438 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9439 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9440 Remove decls.
9441 (x_mouse_leave): Declare only if WINDOWSNT.
9442 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9443 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9444 USE_X_TOOLKIT.
9445
1675728f
PE
9446 * ftxfont.c: Make symbols static if they're not exported.
9447 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9448 HAVE_FREETYPE.
9449 * font.h (ftxfont_driver): Likewise.
9450
e4cebfca
PE
9451 * xfns.c: Make symbols static if they're not exported.
9452 (x_last_font_name, x_display_info_for_name):
9453 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9454 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9455 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9456 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9457 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9458 (last_show_tip_args): Now static.
9459 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9460 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9461 (x_screen_planes): Remove; unused.
9462 * dispextern.h (x_screen_planes): Remove decl.
9463
5bf46f05
PE
9464 * dispnew.c: Make symbols static if they're not exported.
9465 * dispextern.h (redraw_garbaged_frames, scrolling):
9466 (increment_row_positions): Remove.
9467 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9468 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9469 Now static.
9470 (redraw_garbaged_frames): Remove; unused.
9471
435f4c28
PE
9472 * xfaces.c: Make symbols static if they're not exported.
9473 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9474 Remove decls.
9475 * xterm.h (defined_color): Remove decls.
9476 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9477 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9478 (menu_face_changed_default, defined_color, free_realized_face):
9479 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9480 (ascii_face_of_lisp_face): Remove; unused.
9481
8524aef3
PE
9482 * xdisp.c: Make symbols static if they're not exported.
9483 * dispextern.h (scratch_glyph_row, window_box_edges):
9484 (glyph_to_pixel_coords, set_cursor_from_row):
9485 (get_next_display_element, set_iterator_to_next):
9486 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9487 (show_mouse_face): Remove decls
9488 * frame.h (message_buf_print): Likewise.
9489 * lisp.h (pop_message, set_message, check_point_in_composition):
9490 Likewise.
9491 * xterm.h (set_vertical_scroll_bar): Likewise.
9492 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9493 (message_buf_print, scratch_glyph_row, displayed_buffer):
9494 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9495 (get_next_display_element, show_mouse_face, window_box_edges):
9496 (frame_to_window_pixel_xy, check_point_in_composition):
9497 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9498 (glyph_to_pixel_coords): Remove; unused.
9499
16390cd2
PE
9500 * dired.c (file_name_completion): Now static.
9501
9502 * dbusbind.c (xd_in_read_queued_messages): Now static.
9503
a25f4dfa
PE
9504 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9505 * data.c (circular_list_error): Remove.
9506
14a9c8df
PE
9507 * commands.h (last_point_position, last_point_position_buffer):
9508 (last_point_position_window): Remove decls.
9509 * keyboard.c: Make these variables static.
9510
04f2d78b
CB
9511 * coding.h (coding, code_convert_region, encode_coding_gap):
9512 Remove decls.
74ab6df5
PE
9513 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9514 (iso_code_class, detect_coding, code_convert_region): Now static.
9515 (encode_coding_gap): Remove; unused.
9516
38dfbee1
PE
9517 * chartab.c (chartab_chars, chartab_bits): Now static.
9518
a2cb4e63
PE
9519 * charset.h (charset_iso_8859_1): Remove decl.
9520 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9521 Now static.
9522
127198fd
PE
9523 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9524 * ccl.c (Vccl_program_table): Now static.
9525 (check_ccl_update): Remove; unused.
9526
d85b608f
PE
9527 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9528 * category.h: ... from here.
9529 * category.c (check_category_table, set_category_set): Now static.
9530
31cd66f3
PE
9531 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9532 * lisp.h: Remove these decls.
9533
c358e587
PE
9534 * buffer.c (buffer_count): Remove unused var.
9535
e78aecca
PE
9536 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9537 so that it's not optimized away.
9538 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9539 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9540 exported only to the debugger.
9541
e192d7d3 9542 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9543 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9544
92470028
PE
9545 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9546 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9547 was inaccessible from Lisp.
9548 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9549 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9550
244ed907
PE
9551 alloc.c: Import and export fewer symbols, and remove unused items.
9552 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9553 is defined.
9554 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9555 it's not optimized away by whole-program optimization.
9556 (message_enable_multibyte, free_misc): Remove.
9557 (catchlist, handlerlist, mark_backtrace):
9558 Declare only if BYTE_MARK_STACK.
9559 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9560 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9561 (message_enable_multibyte): Remove decl.
9562 (free_misc, interval_free_list, float_block, float_block_index):
9563 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9564 (cons_free_list, last_marked_index):
9565 Now static.
9566 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9567 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9568 (mark_backtrace): Define only if BYTE_MARK_STACK.
9569 * xdisp.c (message_enable_multibyte): Now static.
9570
61c2b50e 9571 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9572 This makes it easier for human readers (and static analyzers)
9573 to see whether these variables are used from other modules.
9574 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9575 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9576 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9577 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9578 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9579 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9580 * xmenu.c, xselect.c:
9581 Declare Q* vars static if they are not used in other modules.
9582 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9583 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9584 Remove decls of unexported vars.
9585 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9586
95c82688
PE
9587 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9588
16a97296
PE
9589 Make Emacs functions such as Fatom 'static' by default.
9590 This makes it easier for human readers (and static analyzers)
9591 to see whether these functions can be called from other modules.
9592 DEFUN now defines a static function. To make the function external
9593 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9594 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9595 (Finit_image_library):
16a97296
PE
9596 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9597 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9598 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9599 Remove decls, since these functions are now static.
9600 (Funintern, Fget_internal_run_time): New decls, since these functions
9601 were already external.
95c82688 9602
16a97296
PE
9603 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9604 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9605 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9606 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9607 * keyboard.c, keymap.c, lread.c:
9608 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9609 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9610 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9611 Mark functions with DEFUE instead of DEFUN,
9612 if they are used in other modules.
9613 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9614 decls for now-static functions.
9615 * buffer.h (Fdelete_overlay): Remove decl.
9616 * callproc.c (Fgetenv_internal): Mark as internal.
9617 * composite.c (Fremove_list_of_text_properties): Remove decl.
9618 (Fcomposition_get_gstring): New forward static decl.
9619 * composite.h (Fcomposite_get_gstring): Remove decl.
9620 * dired.c (Ffile_attributes): New forward static decl.
9621 * doc.c (Fdocumntation_property): New forward static decl.
9622 * eval.c (Ffetch_bytecode): New forward static decl.
9623 (Funintern): Remove extern decl; now in .h file where it belongs.
9624 * fileio.c (Fmake_symbolic_link): New forward static decl.
9625 * image.c (Finit_image_library): New forward static decl.
9626 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9627 * intervals.h (Fprevious_property_change):
9628 (Fremove_list_of_text_properties): Remove decls.
9629 * keyboard.c (Fthis_command_keys): Remove decl.
9630 (Fcommand_execute): New forward static decl.
9631 * keymap.c (Flookup_key): New forward static decl.
9632 (Fcopy_keymap): Now static.
9633 * keymap.h (Flookup_key): Remove decl.
9634 * process.c (Fget_process): New forward static decl.
9635 (Fprocess_datagram_address): Mark as internal.
9636 * syntax.c (Fsyntax_table_p): New forward static decl.
9637 (skip_chars): Remove duplicate decl.
9638 * textprop.c (Fprevious_property_change): New forward static decl.
9639 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9640 Now internal.
9641 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9642 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9643
785bbd42
PE
9644 * editfns.c (Fformat): Remove unreachable code.
9645
8b913b57
AS
96462011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9647
9648 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9649 change. (Bug#8496)
9650
a6744a35
EZ
96512011-04-13 Eli Zaretskii <eliz@gnu.org>
9652
9653 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9654 when at ZV. (Bug#8487)
9655
e7974947
AS
96562011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9657
baad03f0
AS
9658 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9659 (Bug#8437)
9660 * keyboard.c (parse_tool_bar_item): Likewise.
9661 * sound.c (sound_cleanup, alsa_close): Likewise.
9662 * termcap.c (tgetent): Likewise.
9663 * xfns.c (x_default_font_parameter): Likewise.
9664 * xsettings.c (read_and_apply_settings): Likewise.
9665
e7974947
AS
9666 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9667 (overrun_check_free): Protoize.
9668
28272684
PE
96692011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9670
9671 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9672 since callers should never pass a negative size.
9673 Change the signature to match that of plain 'read' and 'write'; see
9674 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9675 * lisp.h: Update prototypes of emacs_write and emacs_read.
9676
11997c76
EZ
96772011-04-11 Eli Zaretskii <eliz@gnu.org>
9678
9679 * xdisp.c (redisplay_window): Don't try to determine the character
9680 position of the scroll margin if the window start point w->startp
e896f03c 9681 is outside the buffer's accessible region. (Bug#8468)
11997c76 9682
8a2cbd72
EZ
96832011-04-10 Eli Zaretskii <eliz@gnu.org>
9684
9685 Fix write-region and its subroutines for buffers > 2GB.
9686 * fileio.c (a_write, e_write): Modify declaration of arguments and
9687 local variables to support buffers larger than 2GB.
9688 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9689
9690 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9691 argument, local variables, and return value.
9692
9693 * lisp.h: Update prototypes of emacs_write and emacs_read.
9694
9695 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9696
4073e537 96972011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9698
1ebfdcb6
PE
9699 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9700
b2ded58d
PE
9701 Fix more problems found by GCC 4.6.0's static checks.
9702
7d66342c
PE
9703 * xdisp.c (vmessage): Use a better test for character truncation.
9704
bbf47d44
PE
9705 * charset.c (load_charset_map): <, not <=, for optimization,
9706 and to avoid potential problems with integer overflow.
9248994d 9707 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9708 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9709 * editfns.c (Fformat): Likewise.
1e69125e 9710 * syntax.c (skip_chars): Likewise.
3befa583 9711
e3019616
PE
9712 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9713 This also lets GCC 4.6.0 generate slightly better loop code.
9714
becfa255
PE
9715 * callint.c (Fcall_interactively): <, not <=, for optimization.
9716 (Fcall_interactively): Count the number of arguments produced,
9717 not the number of arguments given. This is simpler and lets GCC
9718 4.6.0 generate slightly better code.
9719
dae0cd48
PE
9720 * ftfont.c: Distingish more carefully between FcChar8 and char.
9721 The previous code passed unsigned char * to a functions like
9722 strlen and xstrcasecmp that expect char *, which does not
9723 conform to the C standard.
9724 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9725 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9726 char * when the C standard requires it.
9727
76032d70
PE
9728 * keyboard.c (read_char): Remove unused var.
9729
eb3f1cc8
PE
9730 * eval.c: Port to Windows vsnprintf (Bug#8435).
9731 Include <limits.h>.
9732 (SIZE_MAX): Define if the headers do not.
9733 (verror): Do not give up if vsnprintf returns a negative count.
9734 Instead, grow the buffer. This ports to Windows vsnprintf, which
9735 does not conform to C99. Problem reported by Eli Zaretskii.
9736 Also, simplify the allocation scheme, by avoiding the need for
9737 calling realloc, and removing the ALLOCATED variable.
9738
70476b54
PE
9739 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9740
12020a9e
PE
9741 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9742 But keep the doprint source code for now, as we might revamp it
9743 and use it again (Bug#8435).
ea6c7ae6
PE
9744 * lisp.h (doprnt): Remove.
9745 * Makefile.in (base_obj): Remove doprnt.o.
9746 * deps.mk (doprnt.o): Remove.
9747
5fdb398c
PE
9748 error: Print 32- and 64-bit integers portably (Bug#8435).
9749 Without this change, on typical 64-bit hosts error ("...%d...", N)
9750 was used to print both 32- and 64-bit integers N, which relied on
9751 undefined behavior.
61bdb816 9752 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9753 * lisp.h (error, verror): Mark as printf-like functions.
9754 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9755 Report overflow in size calculations when allocating printf buffer.
9756 Do not truncate output string at its first null byte.
9757 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9758 Truncate the output at a character boundary, since vsnprintf does not
9759 do that.
9760 * charset.c (check_iso_charset_parameter): Convert internal
9761 character to string before calling 'error', since %c now has the
9762 printf meaning.
9763 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9764 overflow when computing char to be passed to 'error'. Do not
9765 pass Lisp_Object to 'error'; pass the integer instead.
9766 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9767 formatted with plain %d.
9768
b189fa66
PE
9769 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9770
bff87ef0
PE
9771 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9772
7e2cac20
PE
9773 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9774
ce4d90b5
PE
9775 * xterm.c (x_catch_errors): Remove duplicate declaration.
9776
266c9547
PE
9777 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9778
79c49ad2
PE
9779 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9780
368f4090
JM
97812011-04-10 Jim Meyering <meyering@redhat.com>
9782
9783 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9784 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9785 return ssize_t not "int", and use size_t as the buffer length.
9786 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9787 * gnutls.h: Update declarations.
9788 * process.c (read_process_output): Use ssize_t, to match.
9789 (send_process): Likewise.
9790
a32d4040
CY
97912011-04-09 Chong Yidong <cyd@stupidchicken.com>
9792
9793 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9794
8546720e 97952011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 9796
04f2d78b
CB
9797 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9798 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 9799
8546720e
GM
9800 * xterm.c (handle_one_xevent):
9801 * xmenu.c (create_and_show_popup_menu):
9802 * xselect.c (x_decline_selection_request)
9803 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 9804
0a2f5c1a 98052011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
9806
9807 Fix some uses of `int' instead of EMACS_INT.
9808 * search.c (string_match_1, fast_string_match)
9809 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9810 (scan_buffer, find_next_newline_no_quit)
9811 (find_before_next_newline, search_command, Freplace_match)
9812 (Fmatch_data): Make some `int' variables be EMACS_INT.
9813
9814 * xdisp.c (display_count_lines): 3rd argument and return value now
9815 EMACS_INT. All callers changed.
9816 (pint2hrstr): Last argument is now EMACS_INT.
9817
9818 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9819 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9820 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9821 (decode_coding_utf_16, decode_coding_emacs_mule)
9822 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9823 (decode_coding_ccl, decode_coding_charset)
9824 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9825 (decode_coding_iso_2022, decode_coding_emacs_mule)
9826 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9827 <char_offset, last_offset>: Declare EMACS_INT.
9828 (encode_coding_utf_8, encode_coding_utf_16)
9829 (encode_coding_emacs_mule, encode_invocation_designation)
9830 (encode_designation_at_bol, encode_coding_iso_2022)
9831 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9832 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9833 Declare EMACS_INT.
9834 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9835 (encode_invocation_designation): Last argument P_NCHARS is now
9836 EMACS_INT.
9837 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9838 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9839
9840 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9841 All users changed.
9842
9843 * ccl.c (Fccl_execute_on_string): Declare some variables
9844 EMACS_INT.
9845
8546720e 98462011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
9847
9848 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9849
4e19a977
CS
98502011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9851
9852 * process.c (Fformat_network_address): Doc fix.
9853
87302331
R
98542011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9855
ee7683eb 9856 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 9857
cbb59342
CY
98582011-04-08 Chong Yidong <cyd@stupidchicken.com>
9859
9860 * keyboard.c (read_char): Call Lisp function help-form-show,
9861 instead of using internal_with_output_to_temp_buffer.
9862 (Qhelp_form_show): New var.
e0d38eeb 9863 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
9864
9865 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9866
9867 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9868
e67a13ab
CY
98692011-04-06 Chong Yidong <cyd@stupidchicken.com>
9870
04f2d78b
CB
9871 * process.c (Flist_processes): Remove to Lisp.
9872 (list_processes_1): Delete.
e67a13ab 9873
973f782d
EZ
98742011-04-06 Eli Zaretskii <eliz@gnu.org>
9875
7c106b1e
EZ
9876 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9877
973f782d
EZ
9878 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9879
41cf7d1a 98802011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 9881
ca23cc88
PE
9882 Fix more problems found by GCC 4.6.0's static checks.
9883
f390e2d5
PE
9884 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9885
42eea0d0
PE
9886 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9887
b69769da 9888 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 9889
f9541e84
PE
9890 * xdisp.c (vmessage): Mark as a printf-like function.
9891
13841b55
PE
9892 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9893
c136c10f
PE
9894 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9895
5e2d4a30
PE
9896 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9897 printf-like functions.
9898 (tiff_load): Add casts to remove these marks before passing them
9899 to system-supplied API.
9900
583f48b9
PE
9901 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9902
b25d760e
PE
9903 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9904 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
9905 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9906 directly, rather than having caller test rule sign. This avoids
9907 some unnecessary tests.
9908 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9909 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9910 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 9911
bc7b6697 9912 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 9913 (xfont_open): Avoid unnecessary tests.
bc7b6697 9914
27ccc379
PE
9915 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9916
dcd5c89a
PE
9917 * composite.h, composite.c (composition_gstring_put_cache):
9918 Use EMACS_INT, not int, for length.
9919
b13a45c6
PE
9920 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9921 breaking out part of COMPOSITION_DECODE_RULE.
9922 (COMPOSITION_DECODE_RULE): Use it.
9923 * composite.c (get_composition_id): Remove unused local vars,
9924 by using the new macro.
9925
1e792e4d
PE
9926 * textprop.c (set_text_properties_1): Change while to do-while,
9927 since the condition is always true at first.
9928
dc6c6455 9929 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
9930 (interval_deletion_adjustment): Return unsigned value.
9931 All uses changed.
dc6c6455 9932
aba7731a
PE
9933 * process.c (list_processes_1, create_pty, read_process_output):
9934 (exec_sentinel): Remove vars that were set but not used.
afd4052b 9935 (create_pty): Remove unnecessary "volatile"s.
bc57d757 9936 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 9937 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 9938 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 9939
fdfc4bf3
PE
9940 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9941
fca8fe46 9942 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 9943 (update_syntax_table): Use unsigned instead of int.
fca8fe46 9944
06a0259a 9945 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 9946 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 9947 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 9948
e7b9e80f
PE
9949 * print.c (print_error_message): Avoid int overflow.
9950
56201685
PE
9951 * font.c (font_list_entities): Redo for clarity,
9952 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9953
78834453 9954 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 9955 (font_score): Avoid potential overflow in diff calculation.
78834453 9956
0bc0b309 9957 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 9958 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 9959
e610eaca
PE
9960 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9961
b895abce
PE
9962 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9963 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9964 can always succeed if overflow has undefined behavior.
9965
1f1d9321 9966 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 9967 (wordify): Omit three unnecessary tests.
1f1d9321 9968
c59478bc
PE
9969 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9970 All callers changed. This avoids the need for an unused var.
9971
79b73827
PE
9972 * casefiddle.c (casify_region): Remove var that is set but not used.
9973
a4db5dfe
PE
9974 * dired.c (file_name_completion): Remove var that is set but not used.
9975
43aae36e
PE
9976 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9977
2a47c44d 9978 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 9979 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 9980
a37c69bf
PE
9981 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9982 Check for integer overflow on size calculations.
9983
328ab8e7
PE
9984 * buffer.c (Fprevious_overlay_change): Remove var that is set
9985 but not used.
9986
e5a2a5cb
PE
9987 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9988 Remove vars that are set but not used.
8d84a6eb 9989 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 9990 (timer_check_2): Mark vars as initialized.
e5a2a5cb 9991
a60e5f68
PE
9992 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9993
f661cb61 9994 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 9995 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 9996
f0397f5a
PE
9997 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9998 that are set but not used.
9999
8664db06 10000 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10001 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10002
6abdaa4a
PE
10003 * xselect.c (x_get_local_selection, x_handle_property_notify):
10004 Remove vars that are set but not used.
10005
0ce7538d 10006 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10007 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10008
9ae848fc
PE
10009 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10010 Remove var that is set but not used.
0b918413
PE
10011 (scroll_bar_windows_size): Now size_t, not int.
10012 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10013 Check for overflow.
9ae848fc 10014
a5a62657
PE
10015 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10016 (map_tty_color) [!defined MSDOS]: Likewise.
10017
5c5cdd39
PE
10018 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10019
66ebf983
PE
10020 * coding.c: Remove vars that are set but not used.
10021 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10022 All callers changed.
10023 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10024 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10025 (decode_coding_charset): Remove vars that are set but not used.
10026
1be4d761
PE
10027 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10028 that is set but not used.
10029
47553fa8
PE
10030 * print.c (print_object): Remove var that is set but not used.
10031
1f7196bf 10032 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10033 The gnulib version avoids calling malloc in the usual case,
10034 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10035 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10036 * filelock.c (current_lock_owner): Likewise.
10037 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10038 * sysdep.c: Include allocator.h, careadlinkat.h.
10039 (emacs_no_realloc_allocator): New static constant.
10040 (emacs_readlink): New function.
fdb61804
PE
10041 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10042 ../lib/careadlinkat.h.
d1fdcab7 10043
f84c17c7
SM
100442011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10045
10046 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10047 first non-nil return value).
10048
ef3862ad
JD
100492011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10050
10051 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10052 if not defined (Bug#8403).
10053
376a7006
JB
100542011-04-02 Juanma Barranquero <lekktu@gmail.com>
10055
10056 * xdisp.c (display_count_lines): Remove parameter `start',
10057 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10058 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10059 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10060 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10061 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10062 and thereabouts. All callers changed.
10063 (get_per_char_metric): Remove parameter `f', unused since
10064 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10065
6ca3801d
JM
100662011-04-02 Jim Meyering <meyering@redhat.com>
10067
10068 do not dereference NULL upon failed strdup
10069 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10070 (ns_get_family): Likewise.
10071
d8e2b5ba
JB
100722011-04-02 Juanma Barranquero <lekktu@gmail.com>
10073
10074 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10075
8c74fcbd
JD
100762011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10077
10078 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10079 later (Bug#8403).
10080
7200d79c
SM
100812011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10082
03408648 10083 Add lexical binding.
7200d79c 10084
03408648
SM
10085 * window.c (Ftemp_output_buffer_show): New fun.
10086 (Fsave_window_excursion):
10087 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10088
10089 * lread.c (lisp_file_lexically_bound_p): New function.
10090 (Fload): Bind Qlexical_binding.
10091 (readevalloop): Remove `evalfun' arg.
10092 Bind Qinternal_interpreter_environment.
10093 (Feval_buffer): Bind Qlexical_binding.
10094 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10095 Mark as dynamic.
10096 (syms_of_lread): Declare `lexical-binding'.
10097
10098 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10099
10100 * keyboard.c (eval_dyn): New fun.
10101 (menu_item_eval_property): Use it.
ca105506
SM
10102
10103 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10104
03408648
SM
10105 * fns.c (concat, mapcar1): Accept byte-code-functions.
10106
10107 * eval.c (Fsetq): Handle lexical vars.
10108 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10109 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10110 (FletX, Flet): Obey lexical binding.
10111 (Fcommandp): Handle closures.
10112 (Feval): New `lexical' arg.
10113 (eval_sub): New function extracted from Feval. Use it almost
10114 everywhere where Feval was used. Look up vars in lexical env.
10115 Handle closures.
10116 (Ffunctionp): Move from subr.el.
10117 (Ffuncall): Handle closures.
10118 (apply_lambda): Remove `eval_flags'.
10119 (funcall_lambda): Handle closures and new byte-code-functions.
10120 (Fspecial_variable_p): New function.
10121 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10122 but without exporting it to Lisp.
23aba0ea 10123
23aba0ea 10124 * doc.c (Fdocumentation, store_function_docstring):
03408648 10125 * data.c (Finteractive_form): Handle closures.
23aba0ea 10126
03408648
SM
10127 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10128 interactive spec.
ba83908c 10129
04f2d78b
CB
10130 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10131 New byte-codes.
03408648
SM
10132 (exec_byte_code): New function extracted from Fbyte_code to handle new
10133 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10134
03408648 10135 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10136
03408648 10137 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10138
e2abce01
JB
101392011-03-31 Juanma Barranquero <lekktu@gmail.com>
10140
10141 * xdisp.c (redisplay_internal): Fix prototype.
10142
63696a73 101432011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10144
63696a73 10145 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10146 (try_scrolling): Use it when setting scroll_limit.
10147 Limit scrolling to 100 screen lines.
63696a73
EZ
10148 (redisplay_window): Even when falling back on "recentering",
10149 position point in the window according to scroll-conservatively,
10150 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10151
10152 (try_scrolling): When point is above the window, allow searching
10153 as far as scroll_max, or one screenful, to compute vertical
10154 distance from PT to the scroll margin position. This prevents
10155 try_scrolling from unnecessarily failing when
10156 scroll-conservatively is set to a value slightly larger than the
10157 window height. Clean up the case of PT below the margin at bottom
10158 of window: scroll_max can no longer be INT_MAX. When aggressive
10159 scrolling is in use, don't let point enter the opposite scroll
10160 margin as result of the scroll.
10161 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10162 threshold of 100 lines for never-recentering scrolling.
10163
e4cc2dfc
JB
101642011-03-31 Juanma Barranquero <lekktu@gmail.com>
10165
10166 * dispextern.h (move_it_by_lines):
10167 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10168 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10169 (message_log_check_duplicate): Remove parameters `prev_bol' and
10170 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10171 (redisplay_internal): Remove parameter `preserve_echo_area',
10172 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10173
10174 * indent.c (Fvertical_motion):
10175 * window.c (window_scroll_pixel_based, Frecenter):
10176 Don't pass `need_y_p' to `move_it_by_lines'.
10177
1c470562
SM
101782011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10179
44f230aa
SM
10180 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10181 steal a few bits to be more compact.
10182 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10183 Remove unneeded casts.
10184
1c470562
SM
10185 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10186
888adce9
ZK
101872011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10188
10189 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10190 binding" message (bug#7967).
10191
f838ed7b
PE
101922011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10193
77861b95
PE
10194 Fix more problems found by GCC 4.6.0's static checks.
10195
de6dbc14
PE
10196 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10197 Remove unused local var.
10198
f838ed7b
PE
10199 * editfns.c (Fmessage_box): Remove unused local var.
10200
792c7b2b
PE
10201 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10202 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10203 Omit unused local vars.
c499e557 10204 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10205 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10206 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10207 Omit unused local var.
10208
ba0165e1
PE
10209 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10210 Don't assume string length fits in int.
32ad8845 10211 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10212 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10213
3c59b4c9
PE
10214 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10215 instead of alloca (Bug#8344).
10216
a3eed478 10217 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10218 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10219
eb4d412d
PE
10220 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10221
1658b401
PE
10222 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10223 concerns.
10224
10225 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10226
10227 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10228
9a2c6e05
PE
10229 * keyboard.c (syms_of_keyboard): Use the same style as later
10230 in this function when indexing through an array. This also
10231 works around GCC bug 48267.
10232
03d0a109
PE
10233 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10234
44f730c8
PE
10235 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10236
fe75f926
PE
10237 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10238 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10239
ffa8c828
PE
10240 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10241 This avoids undefined behavior on integer overflow, and is a bit
10242 more convenient anyway since it is compared to a size_t variable.
10243
c5101a77
PE
10244 Variadic C functions now count arguments with size_t, not int.
10245 This avoids an unnecessary limitation on 64-bit machines, which
10246 caused (substring ...) to crash on large vectors (Bug#8344).
10247 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10248 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10249 All variadic functions and their callers changed accordingly.
c5101a77
PE
10250 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10251 * data.c (arith_driver, float_arith_driver): Likewise.
10252 * editfns.c (general_insert_function): Likewise.
10253 * eval.c (struct backtrace.nargs, interactive_p)
10254 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10255 (funcall_lambda, mark_backtrace): Likewise.
10256 * fns.c (concat): Likewise.
10257 * frame.c (x_set_frame_parameters): Likewise.
10258 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10259 0 if not found, not -1. All callers changed.
10260
dd3f25f7
PE
10261 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10262 (stack_copy_size): Now size_t, not int.
10263 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10264
461c2ab9
JB
102652011-03-28 Juanma Barranquero <lekktu@gmail.com>
10266
10267 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10268 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10269 All callers changed.
10270
10271 * lisp.h (multibyte_char_to_unibyte):
10272 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10273 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10274 * character.h (CHAR_TO_BYTE8):
10275 * cmds.c (internal_self_insert):
10276 * editfns.c (general_insert_function):
10277 * keymap.c (push_key_description):
10278 * search.c (Freplace_match):
10279 * xdisp.c (message_dolog, set_message_1): All callers changed.
10280
f6d62986
SM
102812011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10282
10283 * keyboard.c (safe_run_hook_funcall): New function.
10284 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10285 don't set the hook to nil, but remove the offending function instead.
10286 (Qcommand_hook_internal): Remove, unused.
10287 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10288 Vcommand_hook_internal.
10289
10290 * eval.c (enum run_hooks_condition): Remove.
10291 (funcall_nil, funcall_not): New functions.
10292 (run_hook_with_args): Call each function through a `funcall' argument.
10293 Remove `cond' argument, now redundant.
10294 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10295 (Frun_hook_with_args_until_failure): Adjust accordingly.
10296 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10297
1db5b1ad
JB
102982011-03-28 Juanma Barranquero <lekktu@gmail.com>
10299
10300 * dispextern.h (string_buffer_position): Remove declaration.
10301
10302 * print.c (strout): Remove parameter `multibyte', unused since
10303 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10304
10305 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10306 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10307 All callers changed.
10308
10309 * w32.c (_wsa_errlist): Use braces for struct initializers.
10310
10311 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10312 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10313 All callers changed.
10314 (string_buffer_position): Likewise. Also, make static (it's never
10315 used outside xdisp.c).
10316 (cursor_row_p): Remove parameter `w', unused since
10317 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10318 (decode_mode_spec): Remove parameter `precision', introduced during
10319 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10320 All callers changed.
10321
5ffb62aa
JD
103222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10323
10324 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10325
461c2ab9 103262011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10327
10328 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10329 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10330 (ns_update_auto_hide_menu_bar): New functions.
10331 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10332 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10333 ns_constrain_all_frames.
10334 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10335 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10336
5c380ffb
JD
103372011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10338
10339 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10340
9af30bdf
GM
103412011-03-27 Glenn Morris <rgm@gnu.org>
10342
10343 * syssignal.h: Replace RETSIGTYPE with void.
10344 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10345 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10346 Replace SIGTYPE with void everywhere.
10347 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10348 * s/template.h (SIGTYPE): Remove commented out definition.
10349
e2abce01
JB
103502011-03-26 Eli Zaretskii <eliz@gnu.org>
10351
10352 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10353 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10354
f868cd8a
JB
103552011-03-26 Juanma Barranquero <lekktu@gmail.com>
10356
59eb0929
JB
10357 * w32.c (read_unc_volume): Use parameter `henum', instead of
10358 global variable `wget_enum_handle'.
10359
10360 * keymap.c (describe_vector): Remove parameters `indices' and
10361 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10362 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10363
f868cd8a
JB
10364 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10365
10366 * keyboard.c (timer_check): Remove parameter `do_it_now',
10367 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10368 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10369 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10370
10371 * keyboard.c (read_char):
10372 * w32menu.c (w32_menu_display_help):
10373 * xmenu.c (show_help_event, menu_help_callback):
10374 Adjust calls to `show_help_echo'.
10375
10376 * gtkutil.c (xg_maybe_add_timer):
10377 * keyboard.c (readable_events):
10378 * process.c (wait_reading_process_output):
10379 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10380
10381 * insdel.c (adjust_markers_gap_motion):
10382 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10383 (gap_left, gap_right): Don't call it.
10384
2ecf6fdb
CY
103852011-03-25 Chong Yidong <cyd@stupidchicken.com>
10386
10387 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10388 incurred during fontification.
10389
6b1f9ba4
JB
103902011-03-25 Juanma Barranquero <lekktu@gmail.com>
10391
10392 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10393 (DEFVAR_PER_BUFFER): Don't pass it.
10394
10395 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10396 (scrolling_window): Don't pass it.
10397
0f4a96b5
JB
103982011-03-25 Juanma Barranquero <lekktu@gmail.com>
10399
10400 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10401
10402 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10403 and `suffix'.
10404 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10405 of variables specific to SELinux and computation of `encoded_absname'.
10406
10407 * image.c (XPutPixel): Remove unused variable `height'.
10408
10409 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10410
10411 * unexw32.c (get_section_info): Remove unused variable `section'.
10412
10413 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10414 (system_process_attributes): Remove unused variable `sess'.
10415 (sys_read): Remove unused variable `err'.
10416
10417 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10418 (w32_wnd_proc): Remove unused variable `isdead'.
10419 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10420 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10421 (x_create_tip_frame): Remove unused variable `tem'.
10422
10423 * w32inevt.c (w32_console_read_socket):
10424 Remove unused variable `no_events'.
10425
10426 * w32term.c (x_draw_composite_glyph_string_foreground):
10427 Remove unused variable `width'.
10428
1149507c
JB
104292011-03-24 Juanma Barranquero <lekktu@gmail.com>
10430
10431 * w32term.c (x_set_glyph_string_clipping):
10432 Don't pass uninitialized region to CombineRgn.
10433
9c88f339
JB
104342011-03-23 Juanma Barranquero <lekktu@gmail.com>
10435
10436 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10437 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10438 (Fx_close_connection): Remove unused variable `i'.
10439
10440 * w32font.c (w32font_draw): Return number of glyphs.
10441 (w32font_open_internal): Remove unused variable `i'.
10442 (w32font_driver): Add missing initializer.
10443
10444 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10445 (fill_in_menu): Remove unused variable `items_added'.
10446
10447 * w32term.c (last_mouse_press_frame): Remove static global variable.
10448 (w32_clip_to_row): Remove unused variable `f'.
10449 (x_delete_terminal): Remove unused variable `i'.
10450
10451 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10452 (NOTHING): Remove unused static global variable.
10453 (uniscribe_check_otf): Remove unused variable `table'.
10454 (uniscribe_font_driver): Add missing initializers.
10455
dee091a3
JD
104562011-03-23 Julien Danjou <julien@danjou.info>
10457
10458 * term.c (Fsuspend_tty, Fresume_tty):
10459 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10460 * window.c (temp_output_buffer_show):
10461 * insdel.c (signal_before_change):
10462 * frame.c (Fhandle_switch_frame):
10463 * fileio.c (Fdo_auto_save):
10464 * emacs.c (Fkill_emacs):
10465 * editfns.c (save_excursion_restore):
10466 * cmds.c (internal_self_insert):
10467 * callint.c (Fcall_interactively):
10468 * buffer.c (Fkill_all_local_variables):
10469 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10470 Use Frun_hooks.
0f4a96b5 10471 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10472 unconditionally since it does the check itself.
dee091a3 10473
2c520ab5 104742011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10475
c9c49752
PE
10476 Fix more problems found by GCC 4.5.2's static checks.
10477
8abc3f12
PE
10478 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10479 the first time through the loop, since we know p0 < p1 then.
10480 This also avoids a gcc -Wstrict-overflow warning.
10481
a2d26660
PE
10482 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10483 leading to a memory leak, possible in functions like
10484 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10485 of objects (Bug#8318).
a2d26660 10486
916c72e9
PE
10487 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10488 that could (at least in theory) be that large.
10489
19ab8a18
PE
10490 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10491 This is less likely to overflow, and avoids undefined behavior if
10492 overflow does occur. All callers changed. Use strtoul to scan
10493 for the unsigned long integer.
b7cbbd6f
PE
10494 (pint2hrstr): Simplify and tune code slightly.
10495 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10496
f0641eff
PE
10497 * scroll.c (do_scrolling): Work around GCC bug 48228.
10498 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10499
7f650bb9
PE
10500 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10501 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10502 (validate_x_resource_name): Simplify count usage.
10503 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10504
37dd57d1
PE
10505 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10506 fail (Bug#8306).
81e56e61 10507
699979fc 10508 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10509
401bf9b4
PE
10510 * process.c (Fmake_network_process): Use socklen_t, not int,
10511 where POSIX says socklen_t is required in portable programs.
10512 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10513 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10514 (Fmake_network_process, server_accept_connection):
10515 (wait_reading_process_output, read_process_output):
10516 Likewise.
10517
b93aacde
PE
10518 * process.c: Rename or move locals to avoid shadowing.
10519 (list_processes_1, Fmake_network_process):
10520 (read_process_output_error_handler, exec_sentinel_error_handler):
10521 Rename or move locals.
4dc343ee 10522 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10523 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10524 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10525 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10526 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10527
af8a867c 10528 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10529 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10530 Include tparam.h instead, since it declares them.
af8a867c
PE
10531 * cm.h (PC): Remove extern decl; tparam.h now does this.
10532 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10533 * terminfo.c: Include tparam.h, to check interfaces.
10534 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10535 (tparam): Adjust signature to match interface in tparam.h;
10536 this removes some undefined behavior. Check that outstring and len
10537 are zero, which they always are with Emacs.
10538 * tparam.h (PC, BC, UP): New extern decls.
10539
0248044d 10540 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10541 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10542
8ff096c1 10543 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10544 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10545 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10546 (ftfont_list): Remove unused local.
49eaafba
PE
10547 (get_adstyle_property, ftfont_pattern_entity):
10548 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10549 Rename locals to avoid shadowing.
8ff096c1 10550
e2be39f6
PE
10551 * xfont.c (xfont_list_family): Mark var as initialized.
10552
c9735e30
PE
10553 * xml.c (make_dom): Now static.
10554
8f5201ae
PE
10555 * composite.c (composition_compute_stop_pos): Rename local to
10556 avoid shadowing.
b246f932
PE
10557 (composition_reseat_it): Remove unused locals.
10558 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10559 (composition_update_it): Mark var as initialized.
11b61122
PE
10560 (find_automatic_composition): Mark vars as initialized,
10561 with a FIXME (Bug#8290).
8f5201ae 10562
760fbc2c
PE
10563 character.h: Rename locals to avoid shadowing.
10564 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10565 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10566 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10567 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10568 to avoid shadowing.
10569
ff08eb85
PE
10570 * textprop.c (property_change_between_p): Remove; unused.
10571
fc7bf025
PE
10572 * intervals.c (interval_start_pos): Now static.
10573
235d7abc
PE
10574 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10575
44f230aa
SM
10576 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10577 Rename locals to avoid shadowing.
3e7d6594 10578
50060332
PE
10579 * sound.c (wav_play, au_play, Fplay_sound_internal):
10580 Fix pointer signedness.
d01f234b 10581 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10582 (wav_play): Initialize a variable to 0, to prevent undefined
10583 behavior (Bug#8278).
50060332 10584
c4fc4e30
PE
10585 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10586
918436ed
PE
10587 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10588
c939f91b
PE
10589 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10590 clobbering (Bug#8298).
b9c7f648
PE
10591 * sysdep.c (sys_subshell): Likewise.
10592 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10593
6bd8c144
PE
10594 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10595 This should get cleaned up, so that child_setup has the
10596 same signature on all platforms.
10597
7710357c 10598 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10599 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10600
c59da222
CY
106012011-03-22 Chong Yidong <cyd@stupidchicken.com>
10602
10603 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10604 not to be necessary, and produces flickering.
10605
66b87493
GM
106062011-03-20 Glenn Morris <rgm@gnu.org>
10607
10608 * config.in: Remove file.
10609
45b6f6d5
JB
106102011-03-20 Juanma Barranquero <lekktu@gmail.com>
10611
10612 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10613 are now in src/globals.h.
10614 (syms_of_minibuf): Remove spurious & from previous change.
10615
cd394be1 106162011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10617
10618 * minibuf.c (completing-read-function): New variable.
10619 (completing-read-default): Rename from completing-read.
10620 (completing-read): Call completing-read-function.
10621
b14e3e21
CY
106222011-03-19 Juanma Barranquero <lekktu@gmail.com>
10623
10624 * xfaces.c (Fx_load_color_file):
10625 Read color file from absolute filename (bug#8250).
10626
f2b726e6
JB
106272011-03-19 Juanma Barranquero <lekktu@gmail.com>
10628
10629 * makefile.w32-in: Update dependencies.
10630
09f6ff02
EZ
106312011-03-17 Eli Zaretskii <eliz@gnu.org>
10632
10633 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10634
29a6015a
PE
106352011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10636
a3a6c54e
PE
10637 Fix more problems found by GCC 4.5.2's static checks.
10638
b766f867
PE
10639 * process.c (make_serial_process_unwind, send_process_trap):
10640 (sigchld_handler): Now static.
10641
be02381c
PE
10642 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10643 That way, the code declares only the vars that it needs.
10644 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10645 * s/cygwin.h (PTY_ITERATION): Likewise.
10646 * s/darwin.h (PTY_ITERATION): Likewise.
10647 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10648
57048744
PE
10649 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10650 * process.c (allocate_pty): Don't declare stb unless it's needed.
10651
7914961c 10652 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10653 (CONSTANTLIM): Remove; unused.
10654 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10655 Define only if needed.
7914961c 10656
b3967b18
PE
10657 * unexelf.c (unexec): Name an expression,
10658 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10659 Use a different way to cause a compilation error if anyone uses
10660 n rather than nn, a way that does not involve shadowing.
73366a00 10661 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10662
29a6015a
PE
10663 * deps.mk (unexalpha.o): Remove; unused.
10664
43cfc33e 10665 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10666 * unexec.h: New file.
ce701a33
PE
10667 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10668 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10669 Depend on unexec.h.
10670 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10671 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10672 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10673 Change as necessary to match prototype in unexec.h.
ce701a33 10674
01f44d5a
PE
10675 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10676 shadowing.
4f63c6bb 10677 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10678
a6670b0b
PE
10679 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10680 Rename locals to avoid shadowing.
10681
cef2010d 10682 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10683 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10684
d4d7173a
PE
10685 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10686
f08b802a
PE
10687 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10688 warning when compiling print.c.
10689
3ddb0639
PE
10690 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10691 instead of using an uninitialized var.
5ad03b97 10692 (font_sort_entities): Mark var as initialized.
3ddb0639 10693
170a2692
PE
10694 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10695
e663c700
PE
10696 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10697 pointers to constants.
89bc529a 10698 (font_parse_fcname): Remove unused vars.
7b81e2d0 10699 (font_delete_unmatched): Now static.
ea838e10 10700 (font_get_spec): Remove; unused.
13a547c6
PE
10701 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10702 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10703 Rename or move locals to avoid shadowing.
e663c700 10704
2a80c887 10705 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10706 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10707
1384fa33 10708 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10709 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10710
8b2c52e9
PE
10711 * alloc.c (mark_backtrace): Move decl from here ...
10712 * lisp.h: ... to here, so that it can be checked.
10713
475545b5 10714 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10715 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10716 (lisp_indirect_variable): Name an expression,
10717 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10718 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10719
b1349114 10720 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10721 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10722 Use const pointer when appropriate.
b1349114 10723
a2928364
PE
10724 * lisp.h (get_system_name, get_operating_system_release):
10725 Move decls here, to check interfaces.
10726 * process.c (get_operating_system_release): Move decl to lisp.h.
10727 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10728 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10729 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10730 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10731 (Fformat_time_string, Fencode_time, Finsert_char):
10732 (Ftranslate_region_internal, Fformat):
10733 Rename or remove local vars to avoid shadowing.
9710023e 10734 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10735
a415e694
PE
10736 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10737 avoid shadowing.
10738
8ef4622d
PE
10739 * lisp.h (eassert): Check that the argument compiles, even if
10740 ENABLE_CHECKING is not defined.
10741
946f9a5b
PE
10742 * data.c (Findirect_variable): Name an expression, to avoid
10743 gcc -Wbad-function-cast warning.
112396d6 10744 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10745 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10746 (Fmake_variable_buffer_local, Fmake_local_variable):
10747 Mark variables as initialized.
52746918 10748 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10749
e5aab7e7 10750 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10751 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10752 Rename locals to avoid shadowing.
dff45157
PE
10753 (mark_stack): Move local variables into the #ifdef region where
10754 they're used.
7bc26fdb
PE
10755 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10756 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10757 needed otherwise.
10758 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10759 (GC_STRING_CHARS): Remove; not used.
d40d4be1 10760 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 10761
e5aab7e7
PE
10762 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10763 avoids undefined behavior in theory.
10764
4da60324
PE
10765 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10766
88043301
PE
10767 Use functions, not macros, for up- and down-casing (Bug#8254).
10768 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10769 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10770 to use the following functions instead of these macros.
10771 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10772 EMACS_INT, since callers assume the returned value fits in int.
10773 (upcase1): Likewise, for UPCASE_TABLE.
10774 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 10775 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 10776 the race-condition problem in the old DOWNCASE.
88043301 10777
19ed5445
PE
10778 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10779 Rename locals to avoid shadowing.
10780 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
10781 (regex_compile, re_search_2, re_match_2_internal):
10782 Remove unused local vars.
952db0d7
PE
10783 (FREE_VAR): Rewrite so as not to use empty "else",
10784 which gcc can warn about.
da053e48 10785 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
10786 (RETALLOC_IF): Define only if needed.
10787 (WORDCHAR_P): Likewise. This one is never needed, but is used
10788 only in a comment talking about a compiler bug, so put inside
10789 the #if 0 of that comment.
10790 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10791 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10792 Remove; unused.
19ed5445 10793
1f3561e4 10794 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
10795 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10796 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 10797
ded6f8f7
PE
10798 * search.c (simple_search): Remove unused var.
10799
dbd37a95
PE
10800 * dired.c (compile_pattern): Move decl from here ...
10801 * lisp.h: ... to here, so that it can be checked.
10802 (struct re_registers): New forward decl.
10803
7e47afad
PE
10804 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10805
85f24f61
PE
10806 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10807 All uses changed.
10808 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10809 Rename locals to avoid shadowing.
5671df8f 10810 (Fvertical_motion): Mark locals as initialized.
85f24f61 10811
181aa2be 10812 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 10813 (casify_region): Mark local as initialized.
181aa2be 10814
930d429c
PE
10815 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10816
7082eac6
PE
10817 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10818 New macros, so that the caller can use some names other than
10819 gcpro1, gcpro2, etc.
10820 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10821 of the new macros.
10822 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10823 argument, for consistency with GCPRO2_VAR, etc: it is now the
10824 prefix of the variable, not the variable itself. All uses
10825 changed.
38b2c076
PE
10826 * dired.c (directory_files_internal, file_name_completion):
10827 Rename locals to avoid shadowing.
10828
15206ed9
PE
10829 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10830 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10831 dired.c's scmp function, had undefined behavior.
10832 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10833 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10834 * buffer.h: ... to here, because these macros use current_buffer,
10835 and the new implementation with inline functions needs to have
10836 current_buffer in scope now, rather than later when the macros
10837 are used.
10838 (downcase, upcase1): New static inline functions.
10839 (DOWNCASE, UPCASE1): Reimplement using these functions.
10840 This avoids undefined behavior in expressions like
10841 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10842 from race conditions in accessing the global variables
10843 case_temp1 and case_temp2.
10844 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10845 * lisp.h (case_temp1, case_temp2): Remove their decls.
10846 * character.h (ASCII_CHAR_P): Move from here ...
10847 * lisp.h: ... to here, so that the inline functions mentioned
10848 above can use them.
10849
4a6bea26
PE
10850 * dired.c (directory_files_internal_unwind): Now static.
10851
f14b7e14
PE
10852 * fileio.c (file_name_as_directory, directory_file_name):
10853 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10854 Now static.
2893f146
PE
10855 (file_name_as_directory): Use const pointers when appropriate.
10856 (Fexpand_file_name): Likewise. In particular, newdir might
10857 point at constant storage, so make it a const pointer.
fd4ead52 10858 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
10859 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10860 signedness issues.
f839df0c
PE
10861 (Fset_file_times, Finsert_file_contents, auto_save_error):
10862 Rename locals to avoid shadowing.
f14b7e14 10863
5716756e 10864 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
10865 (Ftry_completion, Fall_completions): Rename or remove locals
10866 to avoid shadowing.
5716756e 10867
b4c3046a
PE
10868 * marker.c (bytepos_to_charpos): Remove; unused.
10869
b45db522
PE
10870 * lisp.h (verify_bytepos, count_markers): New decls,
10871 so that gcc does not warn that these functions aren't declared.
10872
85876d07
PE
10873 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10874 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 10875 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 10876 (copy_text): Remove unused local var.
85876d07 10877
03d78a21 10878 * filelock.c (within_one_second): Now static.
b3dd38ab 10879 (lock_file_1): Rename local to avoid shadowing.
03d78a21 10880
5df8f01b
PE
10881 * buffer.c (fix_overlays_before): Mark locals as initialized.
10882 (fix_start_end_in_overlays): Likewise. This function should be
10883 simplified by using pointers-to-pointers, but that's a different
10884 matter.
b1d876f1 10885 (switch_to_buffer_1): Now static.
8f54f30a
PE
10886 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10887 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 10888
a70072c9 10889 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 10890 Fix pointer signedness issue.
edced198
PE
10891 (sys_subshell): Mark local as volatile if checking for lint,
10892 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 10893 (MAXPATHLEN): Define only if needed.
a70072c9 10894
a0977c44
PE
10895 * process.c (serial_open, serial_configure): Move decls from here ...
10896 * systty.h: ... to here, so that they can be checked.
10897
a884fdcc
PE
10898 * fns.c (get_random, seed_random): Move extern decls from here ...
10899 * lisp.h: ... to here, so that they can be checked.
10900
604efe86 10901 * sysdep.c (reset_io): Now static.
b8950c94 10902 (wait_for_termination_signal): Remove; unused.
604efe86 10903
38fc62d9
PE
10904 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10905 (copy_keymap_item, append_key, push_text_char_description):
10906 Now static.
1004a21a 10907 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 10908 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
10909 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10910 (describe_map_tree):
10911 Rename locals to avoid shadowing.
38fc62d9 10912
2f2650da
PE
10913 * keyboard.c: Declare functions static if they are not used elsewhere.
10914 (echo_char, echo_dash, cmd_error, top_level_2):
10915 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
10916 (read_char, kbd_buffer_get_event, make_lispy_position):
10917 (make_lispy_event, make_lispy_movement, apply_modifiers):
10918 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10919 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10920 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 10921 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 10922 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 10923
a053e86c 10924 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
10925 (mark_kboards): Move decl here ...
10926 * alloc.c (mark_kboards): ... from here.
a053e86c 10927
4752793e
PE
10928 * lisp.h (force_auto_save_soon): New decl.
10929
74f10ca7 10930 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
10931 (DEFINE_DUMMY_FUNCTION): New macro.
10932 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10933 Use it.
c03cd23f
PE
10934 (main): Add casts to avoid warnings
10935 if GCC considers string literals to be constants.
74f10ca7 10936
022e70d4
PE
10937 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10938
59d6fe83
PE
10939 * dbusbind.c: Pointer signedness fixes.
10940 (xd_signature, xd_append_arg, xd_initialize):
10941 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10942 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10943 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10944 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10945
78320123
PE
10946 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10947 if GCC considers string literals to be constants.
49cebcca 10948 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 10949
35ac2a97
SM
109502011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10951
fb103ca9
SM
10952 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10953 (print_preprocess, print_object): New macro to fix last change.
10954
35ac2a97
SM
10955 * print.c (print_preprocess): Don't forget font objects.
10956
62973b41
JB
109572011-03-16 Juanma Barranquero <lekktu@gmail.com>
10958
10959 * emacs.c (USAGE3): Doc fixes.
10960
0e48bb22
AS
109612011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10962
10963 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10964 structure.
10965
7684e57b
JB
109662011-03-14 Juanma Barranquero <lekktu@gmail.com>
10967
10968 * lisp.h (VWindow_system, Qfile_name_history):
10969 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10970 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10971 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10972
10973 * w32select.c: Don't #include "keyboard.h".
c96bbc66 10974 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
10975
10976 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10977 * w32console.c (detect_input_pending, read_input_pending)
10978 (encode_terminal_code):
10979 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10980 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10981 (w32_system_caret_y, Qfile_name_history):
10982 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10983 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10984 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10985 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10986 * w32proc.c (Qlocal, report_file_error):
10987 * w32term.c (Vwindow_system, updating_frame):
10988 * w32uniscribe.c (initialized, uniscribe_font_driver):
10989 Remove unneeded extern declarations.
10990
2aa46d6c
CY
109912011-03-14 Chong Yidong <cyd@stupidchicken.com>
10992
c96bbc66 10993 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 10994
cffc6f3b
CY
109952011-03-13 Chong Yidong <cyd@stupidchicken.com>
10996
10997 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10998 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10999 These macros can no longer be used for assignment.
11000
44f230aa
SM
11001 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11002 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11003 (record_buffer_markers, fetch_buffer_markers): New functions for
11004 recording and fetching special buffer markers.
11005 (set_buffer_internal_1, set_buffer_temp): Use them.
11006
11007 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11008
11009 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11010
11011 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11012 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11013
11014 * xdisp.c (hscroll_window_tree):
11015 (reconsider_clip_changes): Use PT instead of BUF_PT.
11016
d251f04b
EZ
110172011-03-13 Eli Zaretskii <eliz@gnu.org>
11018
11019 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11020 $(EMACS_ROOT)/lib/intprops.h.
11021
f0c77cd1
PE
110222011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11023
3eca4629
PE
11024 Fix more problems found by GCC 4.5.2's static checks.
11025
7c86ee98
PE
11026 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11027 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11028 (xg_free_frame_widgets): Make it clear that a local variable is
11029 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11030 (gdk_window_get_screen): Make it clear that this macro is needed
11031 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11032 (int_gtk_range_get_value): New function, which avoids a diagnostic
11033 from gcc -Wbad-function-cast.
11034 (xg_set_toolkit_scroll_bar_thumb): Use it.
11035 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11036 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11037 (get_utf8_string, xg_get_file_with_chooser):
11038 Rename locals to avoid shadowing.
11039 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11040
41729b81
PE
11041 * xgselect.c (xg_select): Remove unused var.
11042
f0c77cd1
PE
11043 * image.c (four_corners_best): Mark locals as initialized.
11044 (gif_load): Initialize transparent_p to zero (Bug#8238).
11045 Mark another local as initialized.
ec6cf4c6 11046 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11047
ce0ad53d 11048 * image.c (clear_image_cache): Now static.
d5d5a617 11049 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11050 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11051 (x_edge_detection): Remove unnecessary cast that
11052 gcc -Wbad-function-cast diagnoses.
2037898d 11053 (gif_load): Fix pointer signedness.
6ae141d6
PE
11054 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11055 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11056
33383987 110572011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11058
d32df629
PE
11059 Improve quality of tests for time stamp overflow.
11060 For example, without this patch (encode-time 0 0 0 1 1
11061 1152921504606846976) returns the obviously-bogus value (-948597
11062 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11063 reports time overflow. See
11064 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11065 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11066 * editfns.c: Include limits.h and intprops.h.
11067 (TIME_T_MIN, TIME_T_MAX): New macros.
11068 (time_overflow): Move earlier, to before first use.
11069 (hi_time, lo_time): New functions, for an accurate test for
11070 out-of-range times.
11071 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11072 (Fget_internal_run_time): Don't assume time_t fits in int.
11073 (make_time): Use list2 instead of Fcons twice.
11074 (Fdecode_time): More accurate test for out-of-range times.
11075 (check_tm_member): New function.
11076 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11077 (lisp_time_argument): Don't rely on undefined left-shift and
11078 right-shift behavior when checking for time stamp overflow.
8be6f318 11079
fe31d94c
PE
11080 * editfns.c (time_overflow): New function, refactoring common code.
11081 (Fformat_time_string, Fdecode_time, Fencode_time):
11082 (Fcurrent_time_string): Use it.
11083
8be6f318
PE
11084 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11085 * dired.c (make_time): Move to ...
11086 * editfns.c (make_time): ... here.
11087 * systime.h: Note the move.
11088
09d9db2c 110892011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11090
126bc0dc
YM
11091 * fringe.c (update_window_fringes): Remove unused variables.
11092
c47cbdfd
YM
11093 * unexmacosx.c (copy_data_segment): Also copy __got section.
11094 (Bug#8223)
11095
7ac80be9
EZ
110962011-03-12 Eli Zaretskii <eliz@gnu.org>
11097
c96bbc66 11098 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11099 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11100 Constify `char *' arguments and their references according to
11101 prototypes in tparam.h.
11102
ecb0f94d 11103 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11104
7ac80be9
EZ
11105 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11106 Adapt all references accordingly.
11107
11108 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11109
ef1fd07e
TT
111102011-03-11 Tom Tromey <tromey@redhat.com>
11111
11112 * buffer.c (syms_of_buffer): Remove obsolete comment.
11113
7ef4b50c
EZ
111142011-03-11 Eli Zaretskii <eliz@gnu.org>
11115
11116 * termhooks.h (encode_terminal_code): Declare prototype.
11117
11118 * msdos.c (encode_terminal_code): Don't declare prototype.
11119
11120 * term.c (encode_terminal_code): Now external again, used by
11121 w32console.c and msdos.c.
11122
44f230aa
SM
11123 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11124 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11125
4b1ec863 111262011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11127
1714f52b 11128 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11129
4b1ec863
PE
11130 * fringe.c (update_window_fringes): Mark locals as initialized
11131 (Bug#8227).
11132 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11133
524c7aa6
PE
11134 * alloc.c (mark_fringe_data): Move decl from here ...
11135 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11136 to check its interface.
11137 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11138
a5c0af81 11139 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11140 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11141 (fontset_font): Mark local as initialized.
a9a06e0b 11142 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11143
b4716021
PE
11144 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11145
811e9bac 11146 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11147 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11148 (x_own_selection, Fx_disown_selection_internal): Rename locals
11149 to avoid shadowing.
11150 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11151
7e3ab302
PE
11152 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11153 so that the caller can use some name other than gcpro1.
11154 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11155 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11156 (Fx_backspace_delete_keys_p):
11157 Use them to avoid shadowing, and rename vars to avoid shadowing.
11158 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11159 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11160 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11161 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11162 Remove unused locals.
7e3ab302
PE
11163 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11164 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11165 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11166 macros.
f78faa98 11167
e2b13473
PE
11168 * xterm.h (x_mouse_leave): New decl.
11169
77f23912
PE
11170 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11171 Remove unused functions.
cdf4ba58
PE
11172 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11173 (x_calc_absolute_position): Now static.
7411c686 11174 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11175 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11176 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11177 unless they are used.
38d0b34a
PE
11178 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11179 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11180 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11181 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11182 (x_error_catcher, x_connection_closed, x_error_handler):
11183 (x_error_quitter, xembed_send_message, x_iconify_frame):
11184 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11185 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11186 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11187
44f230aa
SM
11188 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11189 Rename or move locals to avoid shadowing.
6b463e58 11190 (tty_defined_color, merge_face_heights): Now static.
5967d051 11191 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11192 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11193 does not deduce is never used uninitialized.
73719eba
PE
11194 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11195 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11196
426994c3 11197 * terminal.c (store_terminal_param): Now static.
5489860b 11198
032f1620 11199 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11200 (set_frame_menubar): Remove unused local.
d4323972 11201 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11202 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11203 since they might point to immutable storage.
281585b0
PE
11204 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11205 since it's unused otherwise.
032f1620 11206
367c19e5 11207 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11208 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11209 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11210 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11211 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11212 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11213 does not deduce are never used uninitialized.
70739cbe 11214
07b48fa9
PE
11215 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11216
8868a238 11217 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11218 * window.c (window_loop, size_window):
11219 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11220
7e5cf297 11221 * window.c (display_buffer): Now static.
d6550a9f
PE
11222 (size_window): Mark variables that gcc -Wuninitialized
11223 does not deduce are never used uninitialized.
a586633d
PE
11224 * window.h (check_all_windows): New decl, to forestall
11225 gcc -Wmissing-prototypes diagnostic.
5b555da1 11226 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11227
f6095868
PE
11228 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11229 shadowing.
11230 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11231 Include <limits.h>.
11232 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11233 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11234 (load_charset_map): Mark variables that gcc -Wuninitialized
11235 does not deduce are never used uninitialized.
53df7c11 11236 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11237
f38b440c
PE
11238 * coding.c (coding_set_source, coding_set_destination):
11239 Use "else { /* comment */ }" rather than "else /* comment */;"
11240 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11241 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11242 a block, when the outer 'i' will do.
11243 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11244 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11245 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11246 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11247 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11248 Rename locals to avoid shadowing.
11249 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11250 * coding.c (emacs_mule_char, encode_invocation_designation):
11251 Now static, since they're not used elsewhere.
413bb2db 11252 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11253 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11254 (decode_coding_emacs_mule): Mark variables that gcc
11255 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11256 (detect_coding_iso_2022): Initialize a local variable that might
11257 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11258 this initialization is needed. (Bug#8211)
5f58e762
PE
11259 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11260 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11261 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11262 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11263 Remove unused macros.
f38b440c 11264
232b38b9 11265 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11266 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11267 * character.c (string_count_byte8): Likewise.
232b38b9 11268
fb90da1b
PE
11269 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11270 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11271
fb93dbc2
PE
11272 * chartab.c (copy_sub_char_table): Now static, since it's not used
11273 elsewhere.
5c156ace
PE
11274 (sub_char_table_ref_and_range, char_table_ref_and_range):
11275 Rename locals to avoid shadowing.
bbcd0949 11276 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11277
7d3b3862 11278 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11279 (BIDI_BOB): Remove unused macro.
7d3b3862 11280
6be7d3da
PE
11281 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11282 deduce are never used uninitialized.
c2ed9c8b 11283 * term.c (encode_terminal_code): Likewise.
6be7d3da 11284
75f8807f 11285 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11286
50938595
PE
11287 * tparam.h: New file.
11288 * term.c, tparam.h: Include it.
11289 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11290 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11291 Move these decls to tparam.h, and make them agree with what
11292 is actually in tparam.c. The previous trick of using incompatible
11293 decls in different modules does not conform to the C standard.
11294 All callers of tparam changed to use tparam's actual API.
11295 * tparam.c (tparam1, tparam, tgoto):
11296 Use const pointers where appropriate.
11297
fbceeba2
PE
11298 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11299 * cm.h (struct cm): Likewise.
11300 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11301 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11302 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11303 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11304 (turn_on_face, init_tty): Likewise.
11305 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11306
7f3f1250
PE
11307 * term.c (term_mouse_position): Rename local to avoid shadowing.
11308
e6ca6543
PE
11309 * alloc.c (mark_ttys): Move decl from here ...
11310 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11311
c40f8d15
AS
113122011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11313
11314 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11315
cfe0661d
JB
113162011-03-09 Juanma Barranquero <lekktu@gmail.com>
11317
11318 * search.c (compile_pattern_1): Remove argument regp, unused since
11319 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11320 (compile_pattern): Don't pass it.
11321
0afb4571
J
113222011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11323
11324 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11325 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11326 for ! HAVE_GTK3.
11327 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11328
11329 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11330
11331 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11332 gdk_window_get_screen, gdk_window_get_geometry,
11333 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11334 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11335 (xg_get_pixbuf_from_pixmap): New function.
11336 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11337 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11338 Call xg_get_pixbuf_from_pixmap instead of
11339 gdk_pixbuf_get_from_drawable.
11340 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11341 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11342 (xg_check_special_colors): Use GtkStyleContext and its functions
11343 for HAVE_GTK3.
11344 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11345 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11346 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11347 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11348 Call gtk_widget_get_preferred_size.
0afb4571
J
11349 (xg_frame_resized): gdk_window_get_geometry only takes 5
11350 parameters.
44f230aa
SM
11351 (xg_win_to_widget, xg_event_is_for_menubar):
11352 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11353 (xg_set_widget_bg): New function.
11354 (delete_cb): New function.
895009e1 11355 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11356 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11357 (xg_set_background_color): Call xg_set_widget_bg.
11358 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11359 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11360 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11361 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11362 if ! HAVE_GTK3.
11363 (update_frame_tool_bar): Call gtk_widget_hide.
11364 (xg_initialize): Use GDK_KEY_g.
11365
11366 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11367 if ! HAVE_GTK3
11368 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11369
11370 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11371 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11372 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11373
1c2cc4ef
JB
113742011-03-08 Juanma Barranquero <lekktu@gmail.com>
11375
11376 * w32xfns.c (select_palette): Check success of RealizePalette against
11377 GDI_ERROR, not zero.
11378
33383987 11379See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11380
11381;; Local Variables:
11382;; coding: utf-8
aac0c6e3
MR
11383;; End:
11384
2f097256 11385 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11386
11387 This file is part of GNU Emacs.
11388
11389 GNU Emacs is free software: you can redistribute it and/or modify
11390 it under the terms of the GNU General Public License as published by
11391 the Free Software Foundation, either version 3 of the License, or
11392 (at your option) any later version.
11393
11394 GNU Emacs is distributed in the hope that it will be useful,
11395 but WITHOUT ANY WARRANTY; without even the implied warranty of
11396 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11397 GNU General Public License for more details.
11398
11399 You should have received a copy of the GNU General Public License
11400 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.